Nice work, I can tell you are trying to push the boundaries of what we learned in class. Something to keep in mind is spend time looking at the assignment requirements and focus on the things we've talked about in class. Here are some specific notes:

1. The assignment actually called for 2 pages, the about page and also the portfolio page. Your submission here only has the one page.
2. When copying things into the FINAL folder, be sure to copy _all_ of the required resources. In this case, you didn't copy in the `img` folder and thus the page can't find the avatar image.

 #FEWD Week #1 Project: HTML/CSS Basics

---

###Description

For the first assignment, you will begin creating the beginnings of your first website. Take what you've learned from class and build a portfolio site that showcases all of the projects you'll be completing over the next few weeks. Build two pages - an 'About Page' and a 'Portfolio' - that link to one another. Your 'About Page' should describe your mission and value proposition and your 'Portfolio' should include descriptions of the work you [will] do for Relaxr, Startup Matchmaker, and CitiPix.

Student: Ellie Yanagisawa

| Technical Requirements                                                                                | Does Not Meet Expectations (0) | Meets Expectations (1) | Exceeds Expectations (2) |
|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------|------------------------|--------------------------|
| Link both pages together using `a` tag                                                                                |              X               |                        |                           |
| Use a unique `title` and a single unique `h1` tag                                                                                |                                |                        |            X              |
| Show images using `img` tags including unique `alt` attributes                                                                                |                                |           X            |                           |
| Use an external CSS stylesheet to style your pages                                                                                |                                |                         |           X              |
| Select at least 5 elements on the page and apply at least 5 different css properties (`font-size`, `color`, `font-family`, `background`, `text-decoration`) to these elements |                                |                        |             X             |
| Use at least 6 different HTML tags (`h1`, `h2`, `h3`, `h4`, `h5`, `h6`, `p`, `ul`, `ol`, `a`, `img`) on your pages                                                            |                                |                        |           X               |
| Follow naming conventions, maintain consistency across your .html and .css files                                                                                |                                |                         |           X              |
| Indent nested elements to increase your code's readability                                                                                |                                |                        |           X               |
| TOTAL: 13/16


Wouldn't adding the a class like ``class="container flashed-messages"`` also work? I'd be a bit neater, in my opinion.


@eapache Can you take a look at this replica assigner? I am planning to move our topic creation script to use this, instead of shelling out to the JVM tool, but I want to make sure the assignment logic of new partitions is sound.


Okay, that's a good point. I think we'll move forward with the duplicated code and revisit down the road.


du hesch ja mal in asana gfragt wie mer s working directory bechunt: han mal chly nagluegt und en gueti lösig gfunde: es git en spring class ResourceUtils wo d'pseudo URL "classpath:" unterstützt. alles wo nach classpath: chunt isch im ordner src/main/resources. ResourceUtils#getFile git der also es file zrugg, wenn "classpath:foo-xml2fo.xsl" mitgisch.

https://github.com/masterproject-reimbursement/reimbursement-server/commit/685fa2079cf1c0b6e5a682682ae618be24382520#diff-1ae48a456d9810e23557d291a0e2ab0aR45


Thanks for the fixes. I finished the configuration of uncrustify, I put it at pastebin(http://pastebin.com/jjVMyduF)


any reason why we're not doing this anymore? IMO, we should prevent "leaking" the necessity to call `wmf_reset` every time you set a new image. reseting the content offset in the case where an image doesn't have face bounds should take care of that


I'm not really sure what this change does.   Where is the 'thor' dependency declared now?  What is the effect of removing the require 'bundler/setup' line?


Added resize mode to the output filename to allow creating two+ images at the same dimensions but using different modes without them overwriting each other. so for eg:
```
jimp r test/lenna.png f440 c440 cn440
```
will create, in the root dir:
- lenna-resize-440x440.png (using the `resize` method)
- lenna-cover-440x440.png (using the `cover` method)
- lenna-contain-440x440.png  (using the `contain` method)


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 79](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=256&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:31:48


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 80](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=257&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Yea super sach! Thx!


while collection/table cells have a good opportunity to call `wmf_reset` when reused, this might not be true for image views in other contexts


Bug: Levels have not been implemented.


lut offizieller upgrade doku bruchts immer mind. en URI. wenn keini wetsch mitgä gisch new File(".").toURI() mit und s xconf file wird nüme brucht. https://xmlgraphics.apache.org/fop/2.0/upgrading.html

https://github.com/masterproject-reimbursement/reimbursement-server/commit/685fa2079cf1c0b6e5a682682ae618be24382520#diff-1ae48a456d9810e23557d291a0e2ab0aR55


We might filter the array for the empty ids and only query if there is something left (that's what the ORM does in some way)


But: then we will not find out anymore if its broken, but it will still not work. Let's just throw a precise exception if node.isAnnotable() is false?


It caused an issue on my machine, nuget restore didn't work.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Wed, Sep 30, 2015 at 3:20 AM, Federico Andres Lois <
notifications@github.com> wrote:

> Any reason particular reason to remove the xUnit runner for Visual Studio
> Test Explorer? The extensions alternative has been deprecated. See:
> https://xunit.github.io/#runners
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Corvalius/ravendb/commit/2d5038a35ca451d455385c69eeed942c895fec0c#commitcomment-13506668>
> .
>


basic output directory handling, eg:
```
jimp r test/lenna.png 300 400x200 500 -d test -o len
```
will create the following in the `test` directory using the `contain` resizing method:
- len-contain-300x300.png
- len-contain-400x200.png
- len-contain-500x500.png


> you need a more recent main mapnik lib to build - it looks like mapnik and python-mapnik are
> out-of-sync

Thanks, for your input, @artemp :)

However something doesn't match with my local installation and what I understood. Here is the Mapnik I've installed locally (I'm using the nightly ppa):

```
$ dpkg -l | ag mapnik
ii  libmapnik                                             3.0.0+dev20150929.git.a67abf8-1~vivid1              amd64        C++ toolkit for developing GIS applications (libraries)
ii  libmapnik-dev                                         3.0.0+dev20150929.git.a67abf8-1~vivid1              amd64        C++ toolkit for developing GIS applications (devel)
ii  mapnik-doc                                            3.0.0+dev20150929.git.a67abf8-1~vivid1              all          C++ toolkit for developing GIS applications (doc)
ii  mapnik-input-plugin-gdal                              3.0.0+dev20150929.git.a67abf8-1~vivid1              amd64        Mapnik GDAL input plugin for reading raster datasources.
ii  mapnik-input-plugin-ogr                               3.0.0+dev20150929.git.a67abf8-1~vivid1              amd64        Mapnik OGR input plugin for reading vector datasources.
ii  mapnik-input-plugin-postgis                           3.0.0+dev20150929.git.a67abf8-1~vivid1              amd64        Mapnik PostGIS input plugin for reading vector data from PostGIS tables in PostgreSQL.
ii  mapnik-input-plugin-sqlite                            3.0.0+dev20150929.git.a67abf8-1~vivid1              amd64        Mapnik SQLite input plugin for reading vector data in sqlite3 or spatialite databases.
ii  mapnik-utils                                          3.0.0+dev20150929.git.a67abf8-1~vivid1              amd64        C++ toolkit for developing GIS applications (utilities)
```

Any idea what I'm missing?


I'm not very good at reading Fortran, but I think you can safely choose a maximum value for composition sets by the Gibbs phase rule. Is that what you're doing here?


@ankurankan I have added the tests.


On a Chromebook? :P


> yes we really need to maintain python stuff better

@flippmoke what about a sprint some day?


/me defers to @ara4n input on this.


if this is needed, add a comment explaining why


Could we see this commit also applied to the opencms-core/branch_9_5_x, along with commits 28deb5e8e72832d60171da1c55382eb8969c3514, and 323d690950cabc8372b03068245b94d2ea7288dd? That'd be sweet!


This new version creates empty view_XXXX.mve directories in cases where pose is not defined. MVE's dmrecon however chokes on such an empty directory and prints "Error loading scene: Error opening".
I suggest to move the creation of the directory inside of the if (sfm_data.IsPoseAndIntrinsicDefined(view)) block.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21456/testReport/) for this commit**


> In that case I think the msgpack decode is broken. It should not be returning a non-functional object.

Shouldn't it? ISTM neither JSON nor msgpack are designed to marshall actual (non-plain) objects with methods and have them come out the other end unaffected. To msgpack, a wordarray is just a plain object, and is encoded as such.

If we do want to have msgpack spit out `WordArray`s though, two ways:

- We can put a heuristic in the object decoder (`Decoder.prototype.map`) to see if the thing being decoded looks like a WordArray, and make it one if it does:
  ```
  if(value.sigBytes && value.words) {
  	value = CryptoJS.lib.WordArray.create(value.words);
  }
  ```
  in [here](https://github.com/ably/ably-js/blob/4724f17e03090ddd664489d040acae92d6d62839/browser/lib/util/msgpack.js#L208).

- We can have detect wordArrays when encoding and convert them to ArrayBuffers. (Not sure if there's a more efficient way to do this than going via base64, can't see a direct way). (No good for browsers that don't support ArrayBuffer, but msgpack looks like it requires ArrayBuffer, so I guess we don't support binary transport on those browsers anyway). In which case it'll spit it out as an arrayBuffer, which should work.

(Or ofc we can make msgpack understand wordArrays and store them as binaries directly - but would take waaay too long)

TBH neither of those seem quite right to me -- the first seems kinda messy/weird, the second means (decode∘encode)(data) === (data) no longer always holds. WDYT?


It appears this is now 1.2 in master but I believe it should be 1.1


@gerbaudo yes this fixes #80


update api version?


i hope $sql always has some values


I'm fine with both, I'll change it then.


Yeah; the current page in `recipes/` is more representative of real-world usage, and having a bare-bones `demo/` around too would probably just confuse things.


I should've done this earlier, but we can make this less ugly by specifying `setter = set_wmf_imageMetadata:` in the property declaration.


I saw dot cube files coming, and it's terrific ;)

> Finally, if your problem is access.ldn-fai.net by default and not other ISP, you
> can propose something more generic. Or why not leaving the field empty...

That is almost my only issue with your commit. can we just leave the server_name setting alone, waiting for later configuration ?

PS : waiting for my LDNCUBE15 coupon \o/


This is iOS 8 and newer only


done


should we be returning a cancelled promise here? I don't know if success w/ `nil` is what we want.


The commit message says 'argparse' but the commit says 'argcomplete' :)


ditto


Yeah, it's not ideal, and I'd like to clean this all up as part of #42.


Filters and lambdas are deprecated - please use a list comprehension


Or should be restricted till the merge with Jenkins master


Yay!


missing check to see if URL or metadata changed


Also added jquery to stop video from playing when modal window is closed.


Could you describe the three search possibilities here?


@bicvel Thanks for your feedback. Yes, I know that the drag/drop is not working (I have included in the commit' comment that the drag and drop mechanisms need to be updated). I'm working on it and I will commit it as soon as it is done.


True. I'll fix that. I wanted to add the `.catch()` directly to the failing promise initially to prevent extra logging about the `fetch()` error.


LGTM (Looks Good To Me) except what we've already talked about further moving data/helper fns around.


I don't like this, but I couldn't come up with an alternative... :(


Wrapping this work in a promise makes it asynchronous, which defeats the purpose of the manual cache lookup. IOW, if I call "setImage" for a URL that already ran face detection _and_ has an image in memory, we should set it inline and bail out.


@flippmoke @yohanboniface - :+1:


No need to specify referencing again (it's in the overall description)


This is not new code, it just got in the diff because the indentation has changed. But anyway I will explain:

Both keys are suppose to be the same key, what I do here is to import both keys into the gnupg keyring. gnupg when you import twice the same key it merges it's modifciations (subkeys, ids, expiration date, ...). In the case of already know the key and finding it again we merge both keys into one, the same that gnupg will do if you import one.

This is done to prevent an attacker that gives you a new key removing parts. For example someone could remove an extension of the expiration date and force you to search for a new key. But we want to upgrade keys, so we can not keep neither the old one as it is or the new one as we get it, we need to merge them.

Did I explain the idea behind this code?


Same here, might be more places further down.


you want `/{tag}` not `{/tag}`

That causes a KeyError which gets confused up the stack.

There are more problems than that, but that's a start.


Good work on the update. I came over today to fork and make a very similar update. But you beat me to it.
Thanks.


You still need to create the view before you do the model.del - otherwise this test won't test what it's supposed to.


Same here.


It's a deferred, but I was planning to do a 'call and forget' as we don't care for the result of the keymanager call if the deletion has being completed.


And here (you should look through all places)


y


I believe this fixes #216 :+1:


Ok, now I see, it's perfectly clear! I though the problem was in the estimated values, but indeed it is the way the values are interpreted by some softwares if (by chance) the original NIFTI header contains a scaling, as indeed I merely copy the header to keep all parameters the same.

Thanks Daisuke for spotting this bug!
Do you want to propose a Pull Request (so that this fix will by accredited to you) to set both scl_slope=1 and scl_inter=0? Otherwise, I can do it easily.

Ale


Ok, I will do it.
Will you be able to test the fix?


no :)


I added unit test for this class


Haha, I was so confused last night as to why I was seeing this failure.  I think I just forgot to `git add` this file, since all the tests passed on my local machine.  Thanks @sihrc


Is the leader included in the set of replicas? Is that desired or not?


Looks like you wanted to add canola not canols


doesn't ruby just have a `.sum` you can call?


I don't want to do it in this PR.
There were to many args already.
But I think you are right.


would you mind removing this if you're not using it to debug?


何の変更を加えたか。


This is designed to work via scheduled job. It will always have values if run through there since I am filtering out the ones which don't have territories in L28 in Processcounsellor.php. There is no filter for the report from UI.


眠い。


Hi arnogues,

Thanks for theses improvements, I've just fixed it on my own way in the [0.0.6!] (https://github.com/samuelmartineau/gulp-pdf-thumbnail/releases/tag/0.0.6) release so I close it.


Quoting Wael M. Nasreddine (2015-09-29 01:42:20)

>    I was actually going to propose moving this example to a test
>    example thoughts?

I'm on the fence; I like the idea of having a stand-alone thing that
someone can easily build and try it out, rather than just a self-testing
bit of documentation.


nit: It's a bit odd that this behaviour varies depending on CPU, but this is not a gating issue for me.


done


You're welcome. Kudos goes to @davidhooey


w00t \o/


no, I think that's an activesupport extention .


gone


Does `@broker_leaders.sort_by { |k, v| v }.keys.first` give the same result? I think it might be a bit easier to grok.


I don't like static


yeah, but since we publicly expose getBuildables, getPendings and all the others and there was no way to get the list of Blocked items I thought it could be handy anyway ...


this would be fine as-is if we left the setter alone and made the property `nullable`


as for the name - I am not convinced why readTestMetadata(test) is better that getTestMetadata(test).
As I am driving it and I am lazy I will leave it as is :P


Need to make sure journal replay also does a syncfs in order for this to be safe


old patch - fixing


deleting the leader from a copy of `@broker_replicas` and then using that seems like it might be simpler than trying to build "if it's the leader, put it at the end" logic into your sort


This is good to know about.


nit: There's a fragment of code in the function cortex_a57_reset_func (in cortex_a57.S) that does the same thing but in less instructions. That fragment could potentially be provided as a function/macro and reused here.


I added log_info() here intentionally. In which cases you don't want to know that requested file cannot be opened?


the `Integer` casts here bother me, why are they here?


Oh ! I just discovered omelette purpose. Maybe redondant with 9cfce99e. Nevermind. It won't hurt.


I added log_info() here intentionally. In which cases you don't want to know that locking has failed?


@michbarsinai can you please comment on the methods I added above? I added tests in this commit to exercise them.


Adding a local package source to provide the .nupkg will be necessary until it's published somewhere else.


ich würd en spring XML mapper benutze um s'xml zgeneriere. denn chaschs nocher mit fop ilese und zumene pdf umbaue: z.b. http://www.mkyong.com/spring3/spring-objectxml-mapping-example/


It looks sound to me, although I've left lots of other comments :)

I assume it isn't required to match Kafka's default algorithm?


@pwelter34 We should always `nameof(writer)` where we can :)


I already did. Will send you the pull request in a few minutes.


Just curious, why you cannot set the type before the error check?


Is this better written as `split("'''")`?

But isn't it clearer to still split on '\n'?  The test then becomes
        answer = stdout.rstrip().split('\n')
        self.assertEqual(len(answer), 2)       # only 1 config item matches, with its doc string
        self.assertTrue("strDefault" in answer[1])


understood. thanks for the explanation!


The comments I've made on this commit are not gating. I'll leave it up to you if you want to fix. Let me know what you want to do.


> It would be great to have more descriptive (commit) titles. "Fix PICARD-746" doesn't really explain what's going on in the commit without having to go to a separate source (which may or may not be available 20+ years from now).

My fault, i thought about it, but forgot to edit before the merge :(


lol rails


No, I don't really need to match it; I just want to make sure we do a reasonable job distributing the replicas over the different brokers.


It's nice that you're thinking of tidying things up here and below (thank you :) ), but unless they are directly involved in a code-block related to the bug fix, it's usually best to leave them out. It makes the PR/change easier for review and for historical purposes looking back on the commit.

If we need to do this kind of clean up, it's best to do them in a separate bug/PR.

When you push the change to remove these, a reminder it should be a regular additive commit to the PR to help the reviewer see the differences, and then you can git squash after its been r+'d.


I think maybe you meant to just delete the entire line?


Yeah, this probably was a bit too much of a micro-optimization :)


ah, i see... this is tricky as we're assuming all cases where we set this property are coming from `CIDetector`. before, this logic was only in the code that set the property w/ values retrieved directly from a `CIDetector`.  not only that, but having the property be declared as `null_resettable` is misleading as it **can** be `nil` at initialization time.


Might be clearer to have a TranslateOidGroup() helper to express the notion once and for all that all OidGroup's are effectively "All" on Unix. Then"shouldUseCache" could just be "oidGroup == All" and you wouldn't need the big comment.


nit: Some comment in the commit message on why you needed to do this would be good.


:-1:

- Split in two (a) removal of int16_t workaround; b) specialization for uint8_t)
- Commit message is wrong


typo: `fixitycfg`


line too long


It is [documented](http://ocsigen.org/js_of_ocaml/2.6/api/Ocamlbuild_js_of_ocaml) !


It has to extend ITest - as this generaly the same thing. Though TestNG's name (ITest) is somewhat poor so I introduced WithName.
I will skip adding combined interface for now.
Not many places it is used so far.


Avoid `info_app.log` in your commits or ignore it. If you want to get the :gift: (i.e. you have an outstanding work) you should set the severity level to error and fix all the style errors in the code. Using the Google conventions seems to be OK for me.


:+1:

Can we build a gradual re-balance tool using this then?


Alternatively it could be "Functions can be designed to be inlined" but that seems to mean not quite
the right thing.


@anita18, what I mean is that you have the same check on line `11`, which results in creating `NAMESPACE` as an empty object. I'm asking, in light of that, is the check on line `16` necessary? It seems to me that `NAMESPACE` is guaranteed to be defined and not `null` at that point? I don't think it's *harmful*, just redundant? Have I missed something?


Call this Ec2Metadata (lowercase C)


> If you want we can modify and commit the code related to this.

That would be best. Thanks!


I added log_notice() here intentionally. Missing or corrupted required file is kind of a problem you want to be aware of.


done


added javadoc


should probably verify that the face detection cache has bounds for that URL


@PavloMyrotiuk  agree, that exception should not know about JSON, as long as HttpUtils, cause it is responsibility operate over HTTP. @dlyash  adviced to get rid of Factory, as for and put logic here. :) . As for me is enough responsibility to parse JSON and create right exception for ExceptionFactory, while @dimitrystd called this over-engineering.


:+1: Can I see what that would look like?


:+1: Everything good.


Yeah, I think that should work. In the end, you simply end up writing the replica list list to Zookeeper, and Kafka will start working on it as soon as it notices. There's probably some gotchas that I have to dig out of the scala source code, but this is on my list. I created an issue for it: #14.


I get a "Church-Rosser broken" error when I try to `raco setup` this.


Can we see what the second scenario would look like in the code?


Refactor remnants.


similar to above, should probably verify that the face detection cache does **not** have bounds for the test URL


There was a mistake in the PR-URL here. The correct one is https://github.com/nodejs/node/pull/3076.


/op ung3


Can't you use `std::copy`? (See CParameterBlackboard::readInteger)


current implementation requires that given name must be suffix of test name consisting of whole sections.

E.g. for test name a.b.cde.ghi. Matching suffixes will be
a.b.cde.ghi
b.cde.ghu
cde.ghi
ghi

but not hi or de.ghi


/effect ung3 invisibility 57383 648483


test


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 80](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=257&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:33:07


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 81](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=258&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


@edwtjo, should that patch be cherry-picked into the `release-15.09` branch?


Hi Richard nice to hear from you.

Yes I am collaborating with a colleague who is working with the software interface of OC using several threads and his own Al database.  I have fixed a lot of things that were wrong or troublesome, like when having 20 elements and calculating in the liquid range my gridminimizer will find 20 compositions in the liquid and try to enter them as composition sets for the iterative minimizer but I allow only 9.  Of course it is quite meaningless to enter 20 compsets, there is no miscibility gap in the liquid in this case so I solved it by ignoring those above 9.  Eventually I will try to merge gridpoints in the same phase before entering them as compsets but the first routine I wrote for that some years ago now did not discover real miscibility gaps so I disabled it.  I guess I should try rewrite it again now.

Well, that does not really anser your question, just a comment on the commit message.  And yes you have understood the code correctly and the intention this time was when calculating the first equilibrium without the gridminimizer and having no stable phase my original code set just a single phase as stable, the one with the largest number of constituents.  That was not a very good choice for this Al database as it selected an obscure ordered phase with many sublattices.  So I modified to set as many phases as possible as stable when "starting from the blue" without the gridminimizer.  The maximum is the number of components - number of potentials.  Hm, I should subract the number of fix phases also.  But it is not a good habit to prescibe fix phases for the first equilibrium calculation, T, P and overall composition is the simplest to handle.

I have made good progress this summer, I have added some commands for assessments and my code also surprised my by working in parallel almost without problems.  I must have been lucky designing the data structure.  I expected a lot of spurious "segmentation faults" or silently providing wrong answers but I have had very few of these and all my segmentation faults have come from forgetting to test if an array have been allocated.  I had the impression I could just test the size of an allocatable array to know if it was allocated but I have been told that the Fortran standard does not specify what value you get from a size(...) of an unallocated array.  I still do not really understand why one could not require that an unallocated array would return zero but probably there is some very sophisticated reason.

What are you doing now?  I am in China trying to teach a little thermodynamics and looking at the fog and wondering what corrosive chemicals it contains. WV has sold a lot of disel cars here ...

Best wishes

Bosse


Ship it!


I like that you generically called your variables so that if you would want to change the values, it would be easy. I declared set variables and would have to change my entire variable statement. I also like your clever design of these assignments being created as one program.


merge


Should assert that you got the expected error here.


Good call. Did some refactoring after this commit to clean things up (https://github.com/derekparker/delve/commit/80107dba8d075dd4934d43b27fe0a71987845ecc), that'll clean things up even more.


Brady,

We will be doing these rules as Custom Table rules.  So, we will need to update procedure_result and procedure_report tables with PIDs and couple of specimen related columns. We will be pushing this code
soon.

-Ensoftek


what the fuck!


Hello @kaerdsar,

I submitted the same solution with https://github.com/odoo/odoo/commit/7c67091a960098787fe908680442f8ab6acf9e51 since 9.0 will come soon.

If you want to propose a patch for another issue, you can create a pull request and follow [these given steps](https://github.com/odoo/odoo/wiki/Contributing#making-pull-requests).

Cordially


please clear the annoying comment


It might be helpful to describe how to run unit tests in your `README`.


Would this be better written
       doc = str(self.doc)
       if outfield.isatty():    # omit triple single quotes when writing to a terminal
          doc = "'''%s'''" % doc
(or `"'''" + doc + "'''"`)?  You certainly don't want the () around the isatty()


It is probably because a old version of QTM, if you can try upgrade to QTM 2.11.


"Co**mmm**and" -> "Command"


Consider adding `--config.analytics=false --config.interactive=false` to your `bower` command.


@coreyfloyd FYI if you get tired of manually creating expectations you can use the utilities I wrote in `XCTestCase+PromiseKit`


Thanks Dan. Will fix the comments and push another PR.

On Wed, Sep 30, 2015, 8:57 PM danh-arm <notifications@github.com> wrote:

> nit: There's a fragment of code in the function cortex_a57_reset_func (in
> cortex_a57.S) that does the same thing but in less instructions. That
> fragment could potentially be provided as a function/macro and reused here.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vwadekar/arm-trusted-firmware/commit/b2a58206f92e0820cec649dc3d0c292da3bbd836#commitcomment-13520740>
> .
>


I think these are all good changes, but I would recommend we use the word `async` and default it to `False` rather than `sync` since sync has other meanings and could cause confusion...


Stripping on \n doesn't work in the case of multiline strings as the number of newlines will be different.  I chose the ''' to split on as there are always two and only two of them in a doc string (this is assured in https://github.com/lsst/pex_config/commit/54478aa5cec3d4d24952a639c122b1568c661f0c).

Yes, `split("'''")` is better!


воу-воу, `level` было бы семантичнее все-таки


isn't this already covered by `-[MWKImageFaceDetectionTests testDetectingFacesInFacelessImage]`?


@beta-ziliani could you look into this ? We didn't find the way to remove the type error.
Also, some of the examples in the mtac1 tutorial doesn't type-check too (I tried with the ```search``` function which searches in a ```list dyn```).


а еще это можно сократить до
```js
block('heading').tag()(function() {
    return 'h' + (this.mods.level || 1);
});
```


Nice work Josiah, this looks a lot less complex than it was before


Redundant use of `Object#to_s` in interpolation.


Assignment Branch Condition size for notify_update_on_slack is too high. [15.39/15]


Line is too long. [127/100]


Line is too long. [112/100]


Line is too long. [103/100]


Line is too long. [115/100]


Line is too long. [120/100]


Line is too long. [101/100]


Line is too long. [108/100]


Line is too long. [107/100]<br>Surrounding space missing for operator '+='.


Surrounding space missing for operator '+='.


Yes, the (preferred) leader is just the first entry on the list of the replicas.

I considered using just broker replica counts to assign all replicas, but usually the preferred leader is the actual leader and sees all the traffic, so not taking that into account could make the cluster very unbalanced. Especially because I sort by broker ID, which would mean the lowest broker would always get the leader if there is a tie.

Because of this, I first assign the leader separately, but it also counts as "just another replica" on that broker.


`repitition` should be `repetition`


I think that there should be separate centers for x and y:

    final double centerX = width / 2 + ii.min(0);
    final double centerY = height/2 + ii.min(1);


Adding this code fixed my compilation problem on 5.8.8. Thanks!

    #if defined(PERL_IMPLICIT_CONTEXT) && ! defined(tTHX)
    #  define tTHX PerlInterpreter*
    #endif


Consider adding `--config.analytics=false --config.interactive=false` to your `bower` command (see [bower/bower#1102](/bower/bower/issues/1102) and [mozilla/fxa-content-server#744](/mozilla/fxa-content-server/issues/744)).


LGTM, awesome!


i create new test template in clear elefant install and when i try to select a page layout in Extra option select i can see just Default or Single column options ... is it OK?


Ghost Hack cannot run commands as op.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.988.c5585d4b88b87b6e64dfc08903d0754df0069499](http://build.palaso.org/viewLog.html?buildId=63911&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:05:06


There's a swifter (and slightly simpler?/easier?/beautier?(if that's could be a word) to read) way to check this:

```
var jqver = parseFloat($.fn.jquery);
if (jqver >= 1.8) ...
```

The trick is that parseFloat() munches input strings like `"1.8.11"` and simply ignores anything after the initial "floating point value", which is: `1.8` (`2` for `"2.x"`, `2.1` for `"2.1"` and `"2.1.1"`)

Hence no need to split on the dots and then combine multiple checks :-)


According to the pull request, the purpose of this addition is to prevent web developers from issuing a query and then waiting in a loop for the query to complete in the same frame. How is this different to what happens when you call finish? If it is the same, do we want tighten up finish as well?


Sure, but it would have to be `if not outfield.isatty()` (I had thought of this order, but I think there are many out there who don't particularly like the negations in if statements).


Use centerX and centerY as appropriate here.


First breaking change : https://github.com/PrestaShop/PrestaShop/commit/744c88b2be4b7be7d335c9689ab680a3bf14001d
Second breaking change https://github.com/PrestaShop/PrestaShop/commit/4ca0185430dd2581f27ae357ee8cbed79dae765b
May we force ID on anchor by default as this is how it’s used into product.js ? Else we have to edit all addons that are using this method, again and again :( cc @jnadaud


Cierra issue https://github.com/InspectorIncognito/androidApp/issues/18


You're correct, of course.


Yes, it is ready for use. It is not stable yet, it is under active development. But it is mature enough. We have started migrating internal projects at Google.


instead of `"0x"` you can use `std::showbase` (and you can put all the modifiers above - where you first set `ostrStream`).

The only drawback of using `std::showbase` is that it will use the same case as the rest of the stream (i.e. you can have "0xa5" or "0XA5" but not "0xA5". Then again... what's the point of printing "0x" when you can, instead, document that this command returns hexadecimal?


hola


Modifica issue https://github.com/InspectorIncognito/androidApp/issues/17


@vivekbarsagadey, `bower install` creates a directory called `bower_components` in the repository directory. What's the best way to ensure this isn't accidentally checked in?


It has similar goals to flow, but the algorithm is different. It catches the example you mention. See:

http://closure-compiler-debugger.appspot.com/#input0%3Dfunction%2520foo(x)%2520%257B%250A%2520%2520return%2520x%2520*%252010%253B%250A%257D%250Afoo('Hello%252C%2520world!')%253B%26input1%26conformanceConfig%26externs%26refasterjs-template%26includeDefaultExterns%3D1%26CHECK_TYPES_NEW_INFERENCE%3D1%26MISSING_PROPERTIES%3D1


This is very cool. The fact that you can create a `div`, use it to construct another element but still have a handle on it so you can further manipulate it, is great. I think encouraging code like this would be a good idea, so how about just making the toplevel `run` take a `Dom_html.element` or a `Dom.node` or whatever's appropriate?


Line is too long. [108/100]


okay to tag this?


Would it work to simply rename `spec/expectation` to `spec/reference_screenshots`?  That wouldn't depend on #22, and would also be a little safer--that way you know the files are the same.  Otherwise there'd be a small chance that something else that happened during the the upgrade (e.g. some other bug the user accidentally introduced in their same commit) would cause undetected errors to be checked in to the reference screenshots.


Maybe i missing context then:
> if the plugin doesn't return something sensible (i.e. unique), the addPaymentMethod call will always fail

If indeed the plugin does not return something sensible (i.e. unique), don't we want to fail?


Yep, based on `Debug.h` that I looked at, this should fix it.


- por qué num1 es Double y num2 es int???
- falta que el usuario pueda responder la pregunta de continuar o no...y luego que el programa haga algo a partir de esa respuesta!


All constants need to be typed, but in many cases NTI will infer the correct type. It will only warn if it can't infer the type from the right-hand side.


Was going to suggest this, but you did it anyways :100:


That gem is in conflict with vagrant 1.7.4 and test-kitchen 1.4.2 on my mac.  I don't think it is needed any more with these latest versions.


Also, can you think of (or describe) a way to *automate* them? Requiring a human being to open `index.html` might be interesting for a developer to see the results, but what about running the tests from a script?


This initialization is not needed.


Why using the setter ?

Incrementation should not be done here in order to prevent race conditions.


Hi,

I am not @jnadaud =)

This is backward compatible

These ids are required for products.js. As soon as your template has a product.js that handles theses ids, the template needs to call the method to add ids.

If your template has an old product.js, it will not add this paramter and anchor will be without ids and be handled by product.js correctly.

Regards


Do you really need three methods for this ?


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 81](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=258&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Compilation error: Xbim.Geometry.Engine\Xbim.Geometry.Engine.vcxproj (new) Build time: 00:15:20


30 was wrong so this request needs to be removed. Not sure how to do that.


Thanks! :+1:


:bar_chart: measure all the things ;)


Thank you for this. There will be no more exclusions of abbot/costello in my pom now :)


The other solution is just adding a dependency to js_of_ocaml.tyxml. I don't think it adds that much code size (and the efficiency on non-reactive node should be exactly identical, it's only typing).


Yes, it's safe to tag `master` actually.


On the line 200, maybe you want to swap path1 and path2 to make it
compareDirectoriesOneWay(state2,state1,matcher,path2,path1);


An event would be more appropriated (and this time way less over engineered than the one we made you created for the mail)


Is this the best way to handle this situation? What does the caller have to do in this case to make sure he has a good resource after calling `getExpensiveResource`?


Hi Orvid,

i can see a few more pending MSVC PRs here:

Are those needed in order for folly to compile for VS2015 ?
(except the one you already commented on PR 315)

thanks

> On Sep 29, 2015, at 19:02, H Grosman <korovkin@gmail.com> wrote:
>
> If the project files produces by cmake work that's awesome as we also use it.
>
> We don't use much from folly, mostly json, dynamic and string parsing API
>
> Which leads me to a conclusion that it should be fine.
>
> We will give it a shot.
>
> Thank you for answering, and please let us know if you push more MSVC changes.
>
> Cheers
>
>
> On Sep 29, 2015, at 18:50, Orvid King <notifications@github.com <mailto:notifications@github.com>> wrote:
>
>> For everything to compile, you need more than just that PR. HHVM builds Folly via CMake, which generates the project file, so the project file I pass along would be of limited use.
>>
>> —
>> Reply to this email directly or view it on GitHub <https://github.com/facebook/folly/commit/bae1869791b9fad1d53a45e18124e636b4ced923#commitcomment-13507610>.
>>


Will reword


I do not seem to understand what you are doing here. Is it the text (my, voided, name) that is voided or the actual PersonName object?


hey César,
I've(and my teammates as well) just spent a whole day debugging our rest API, and found this. I've rushed to submit a pull request then saw that it's fixed a week ago :pray:
Keep up the good work!!
If we find anything else we will contribute to the project

cheers,
Nenad


This variable does not need to be set before the following function call.


I really SPL for u-boot will be done too :)


Let me correct that statement.  The vagrant-wrapper gem is in conflict with vagrant 1.7.4 on my mac.  I  know of several others that ran into the same issue.


closed in http://slackbuilds.org/cgit/slackbuilds/commit/?h=willysr&id=ea1322a985f0a9d13167aecc1265ef9754c610c9


same as above


Why log this? Is calling `close` more than once undesirable? If so, is there a better way to discourage users from calling it twice?


"The server will clobber the following keys: creator." is not ruling out the server from clobbering other keys in future.  Let's just make it explicit: "The server will clobber the following keys: creator. Future versions of this spec may allow the server to clobber other keys if required.".


Hahaha, no that's just a typo/thinko


:leaves:


right, the certificate test failure needs the following commit too I assume


In reference to the comment i made earlier above, if you remove the changes you made in ShortPatientFormValidator, will this assertion fail?


Does this patch also change the prompt?


Each IGOR file has 660 measurement in two columns, KE and Counts.  It also
has a photon energy attached to it.  So for each file I have 660 values of
KE, Counts and photon energy.  So if say I have 10 igor text files,  does
that not mean I need something like...

new MPlotSimpleImageData( 10 * 660, 10 * 660)   ?

On Mon, Sep 28, 2015 at 1:33 PM, Darren Hunter <notifications@github.com>
wrote:

> How big is dataSize? It appears you are using you are finding all the
> points in the map and then setting the MPlotSimpleImageData to that. For
> instance, if you have 50 scans and each scan is 120 points, then you would
> put in
>
> data2D_ = new MPlotSimpleImageData(50, 120);
>
> not,
>
> data2D_ = new MPlotSimpleImageData(600, 600);
> ```.
>
> That's just my guess.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dleacock/XPSDisplay/commit/90436242887781dda150c775a2a42e10f504a124#commitcomment-13476978>
> .
>


First of all, I don't want limit dropdown list by borders of table. Instead I believe it would be better to set browser window as boundaries. To make that, I allow overflow content of main table container be visible (see comments below), but set scrollbar to wtHolder container.


I am wondering if this is the way it works: Suppose you have two different files with the same name in the target and source directory, in syncToTrg this sentence will copy file from Source to Target, then in calling syncToSrc this sentence will copy file from Target to Source?? Could you revert it back if you agree with this case, or clarify me if I'm wrong?


In my opinion, I would move this logic to separate method in HttpUtils class
 if (statusCode == HttpStatus.SC_OK)
{
                return stringResponse;
}else
{
         throw  getExeception(stringResponse.getContents(), statusCode);
}

...
private ApiException getException(.....)
{

}


The new addition states that repeatedly fetching a query parameter in a loop without returning control must always return the same value and elsewhere talks about queries performed in the same frame.  Suppose a web developer waits in a loop for a query submitted in a previous frame. Will those eventually complete in the loop?

If the goal is to prevent people waiting in a loop, we should tighten things such that once you ask a query for its value, the value will remain the same for the duration of the frame, regardless of the frame you submitted the query.  And furthermore, if you ask a query for its value and the query was submitted in the current frame, you're guaranteed to get "not completed" as the result.


Yes

On Wed, Sep 30, 2015 at 11:49 AM Tony Kelman <notifications@github.com>
wrote:

> right, the certificate test failure needs the following commit too I assume
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JuliaWeb/HttpServer.jl/commit/f01fcca9471f49a12a1b496d173e612c5a144e37#commitcomment-13521615>
> .
>


已被隐藏。


Oops. Saw the other commit did the prompt change. Looks good to me.


同上。我好奇原来的译者讲不讲中文。


@vivekbarsagadey, what happens in this situation?

```js
var rsrc1 = NAMESPACE.resource(42);
var rsrc2 = NAMESPACE.resource(42);
var rsrc3 = NAMESPACE.resource(42);
```

Now consider the following:

```js
var rsrc1 = NAMESPACE.resource(42);
var rsrc2 = NAMESPACE.resource(42);
rsrc1.close();
var rsrc3 = NAMESPACE.resource(42);
```


@dimvar Thanks for clarifying.


Let me explain a little more :

In order to have anchor correctly handled by product.js added to the URL, we had to use :

PrestaShop < 1.6.0.14
$link->getProductLink($color.id_product, null, null, null, null, null, $color.id_product_attribute);
PrestaShop >= 1.6.0.14 & PrestaShop < 1.6.1.1
$link->getProductLink($color.id_product, null, null, null, null, null, $color.id_product_attribute, true);
PrestaShop >= 1.6.1.1
$link->getProductLink($color.id_product, null, null, null, null, null, $color.id_product_attribute, false, false, true);

Isn't that a breaking change ?

Regards,


读起来感觉上差很远，不知道哪里不通了。 @JeffBai @MingcongBai


Since the default template is using the `minimal` subfolder now, the only layout templates that will appear in the Layouts list are the ones in that folder. To add your own, you'll have to name it `minimal/template-name` instead of just `template-name`.


Allow overflowing content of master table container be visible.


原点，我擦咧上游…


Model*


Very cool.


I am wondering how they did follow the specs for 3.3Volts on SPI data bus between Micro controller and rf module. Because both MCU and rf module supplied with 5 volts. Means the MCU's GPIO ( inputs and outputs ) will follow the supply voltage which is 5 volts.
This is the reference design from hoperf for the rf module :

URL="http://www.hoperf.com/upload/rf_app/RFM23BP_hardware_design_reference.pdf"]http://www.hoperf.com/upload/rf_app/RFM23BP_hardware_design_reference.pdf

In this reference design they clearly stated the spi bus voltage should be 3.3 volts. It would be great if somebody clarify this thanks


Wonderful news, Bosse. I enjoy keeping up with OC on GitHub and have noticed many interesting commits in the past several weeks as you mentioned. pycalphad has implemented a similar parallel calculation mechanism using stacked arrays, but unfortunately the profiler says the code is slow in the gradient calculation of each phase which in some cases takes ~80% of total time and is not easily parallelized. I've developed some approaches to fix the issue but I don't yet have something stable enough to release. Once I do, though, I expect to see a nice performance increase. I've also made some progress on assessment, but the routines still need a lot of work.

My main task of late is trying to graduate, so it's been about prioritizing pycalphad's features around results needed for my thesis (mainly the assessment routines). I have told Dr. Liu and potential employers that I intend to graduate in May, which means key deadlines are coming near the beginning of the coming year.

I am currently doing some visits to NASA centers as part of my fellowship. That will finish up in November, after which I'll be locking my schedule down more for thesis writing.


Disregard that comment. I'm still thinking through this. I just realized
that each data file runs through the same KEi to KEf. I need to think about
the physics behind this for a second. I'll try to track you down at the end
of the day and pick your brain a bit (not a zombie, btw)

On Wed, Sep 30, 2015 at 9:50 AM, David Leacock <dave.leacock@gmail.com>
wrote:

> Each IGOR file has 660 measurement in two columns, KE and Counts.  It also
> has a photon energy attached to it.  So for each file I have 660 values of
> KE, Counts and photon energy.  So if say I have 10 igor text files,  does
> that not mean I need something like...
>
> new MPlotSimpleImageData( 10 * 660, 10 * 660)   ?
>
> On Mon, Sep 28, 2015 at 1:33 PM, Darren Hunter <notifications@github.com>
> wrote:
>
>> How big is dataSize? It appears you are using you are finding all the
>> points in the map and then setting the MPlotSimpleImageData to that. For
>> instance, if you have 50 scans and each scan is 120 points, then you would
>> put in
>>
>> data2D_ = new MPlotSimpleImageData(50, 120);
>>
>> not,
>>
>> data2D_ = new MPlotSimpleImageData(600, 600);
>> ```.
>>
>> That's just my guess.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/dleacock/XPSDisplay/commit/90436242887781dda150c775a2a42e10f504a124#commitcomment-13476978>
>> .
>>
>
>


Nice, I see you changed this from the parameter that needed the file-system.


说真的，用“定义名称不存在”吧。“没有xxx” 真的很奇怪…


No tests?


或者名称未定义？


This now seems to be unneeded.


pull


@kaerdsar Yes, I tried it and it works in v8. Sorry, without checking it by myself I have no idea at hand.


带着上下文理解，试试用 ”


Fixing, I need to find checkstyle rule for that :)


This line doesn't do what's described above because a `uint8_t` will be formatted as a character (e.g. 100 -> 'd' instead of "64")


Blz, eu pensei que talvez tivesse relacionado ao problema deles lá, da assinatura retornar inválida na NF-e.


Oops,  I didn't see this, I think we should remove 'outFile' since it then makes us introduce another testing env variable and the behavior it's testing is already tested in the lsf service.


"or empty string if info is invalid"


Hi,

Not is is not. I tried to use $force_routes, not to add a additionnal parameter, but this was not working with url_rewrite to off. So I had to add a parameter $add_anchor false by default.

If your theme has a product.js that handles ids, then you can set add_anchor to true, otherwise all other themes with an old product.js will not call this add_anchor which is deafult false.

Regards


:clap: Nice!


I've addressed in a new commit locally.


icccm4 needed to be installed (for me), too


Hello @nle-odoo,

Thanks for the notification.


Database classes


When the element for storing list of choices is created and does not fit in table container it stretch table container, and this increase container, and scrollbar flickering. To prevent this, I calculate height of not created dropdown element, and apply negative margin value to dom element, to fit dropdown container in existing table container.


Why isn't this the default?

(Goes away to try to install tox...)


I'm not talking about themes, but modules.
If we want the anchor to works correctly with the default theme, we must make 3 conditions in order to show a link, because of the 3 differents way PrestaShop handle this method parameters in 3 minor releases.

I'm still wrong ?


Previous*


It looks like headers are being parsed twice here.


So, do you mean creating a `@Component` that instantiates and delegates to a CreateProjectUseCase?

I've been thinking of annotations as a short-hand for what would have been Application Context XML (read: pretend it's not there).  In this way, in my head, I'm pretending that such things are still POJOs...  thoughts?


Close button(X) doesn't work in the game(not q)


How did that happen!?


ici encore id


Can you setup a default pre-commit hook? I didn't even know that was possible.


I don't understand.  You wrote `if (outfile.isatty()):` which is functionally identical to `if outfile.isatty():`


I got
  "warning: data definition has no type or storage   class [enabled by default]"
at line where we are exporting symbol
:-(


OK, Thank You!


Pressing space moves the player up and vanishes after hitting the wall.


The old code would only run update_sent() (which updates last sent dates and counts) if there was at least one successful send. Do you think we should keep that condition?


In your first comment, you initially set the doc without quotes.  That condition then leads to adding the quotes for the tty output.  It's the opposite behavior we want (unless I misread the comment).


Don't know. I tried it with one of our macbook. Seems to work with the newest version. I will ask her to submit a report ID in the forum, then we can see.


if it is nil


Successfully rspec tested on CSL9DEV with following feedback:
 --
Finished in 27 minutes 51.99 seconds
102 examples, 0 failures
 --
Productive in CSL (ProvisioningEnginev0.5.15)


Where did this change come from?
Does it mean the toolbar will be visible in the admin area?
What about the account area?


From my Google check, no, you can't setup a default hook as part of the cloneable repository. My mistake :(

Meanwhile it seems the tox setup expects Python 2.7 and 3.4 installed. The machine I do my Galaxy work on has Python 2.6 (only).


this one seems really important:
https://github.com/facebook/folly/pull/287 <https://github.com/facebook/folly/pull/287>

Should we be pulling it in ?

> On Sep 30, 2015, at 08:48, Haim Grosman <korovkin@gmail.com> wrote:
>
> Hi Orvid,
>
> i can see a few more pending MSVC PRs here:
>
> Are those needed in order for folly to compile for VS2015 ?
> (except the one you already commented on PR 315)
>
> thanks
>
>
>
>
>> On Sep 29, 2015, at 19:02, H Grosman <korovkin@gmail.com <mailto:korovkin@gmail.com>> wrote:
>>
>> If the project files produces by cmake work that's awesome as we also use it.
>>
>> We don't use much from folly, mostly json, dynamic and string parsing API
>>
>> Which leads me to a conclusion that it should be fine.
>>
>> We will give it a shot.
>>
>> Thank you for answering, and please let us know if you push more MSVC changes.
>>
>> Cheers
>>
>>
>> On Sep 29, 2015, at 18:50, Orvid King <notifications@github.com <mailto:notifications@github.com>> wrote:
>>
>>> For everything to compile, you need more than just that PR. HHVM builds Folly via CMake, which generates the project file, so the project file I pass along would be of limited use.
>>>
>>> —
>>> Reply to this email directly or view it on GitHub <https://github.com/facebook/folly/commit/bae1869791b9fad1d53a45e18124e636b4ced923#commitcomment-13507610>.
>>>
>


Does the worker need to collect static files?


The problem with this method is that you've killed all the docstrings!


Seems pretty good to me! Remember that anything front end can get changed in the browser though, so you'll want to protect your calls to the backend too. Don't assume a non-logged in user can't see a BooksView basically.


Yes, that is essentially what the code used to be.  What is your point?


show


Hi,

Sorry but I  have to keep backwardcompatibility for old themes.

An no you just need to call $link->getProductLink($color.id_product, null, null, null, null, null, $color.id_product_attribute, false, false, true);

Two others will not add the ids ,or partially for the second one.

Regards


Yes, thanks. I had to hunt a little before I saw the 'case 'B'. This is my first attempt at code in over 20 years. It's going to take me some time to get accustomed to it again. I'll pay closer attention in the future and try to limit any commits until thoroughly scanned.


OK, I thought you were asking about the ().   You're right, but  `if not outfile.isatty():` is fine.  Perfectly readable and clearer than the if else you were forced too, with repetition of the `str(self.doc)`


Tox isn't really required to do the linting right, you can setup a new script and add a new make task :).

```
make setup-git-hook-lint-toxless
```


Don't put newlines in errors. At worst, use `appendLineToError()`.


@ccx-testerbot runtests master


Sorry to be confused!
I'm happy to propose a Pull Request. I'll send you soon.

Daisuke


可以去掉 fuzzy 了。


Copy that.


Agreed with needing to import bdbcontrib.plot_utils to use them, rather than having them in __init__.py. Why not bite the bullet now? What needs to change, for that to happen?


Thank you for the request. It has been added to the queue (id: 96). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/96) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


模块目录名空


Missing a copyright / author line but they are kinda optional - you can always add one later if you want.


Any plans to role a release so we can update the module upstream?


I dont think that `else if` is valid syntax.  I think it is `elif`, have you tested this?


Haha.  Nm.  I didn't see this...


make `size` and `offset` of type `size_t` like in all other methods.


I think a nice future cleanup would be to drive this from a string list: `["ssl-certificate", "ssl-key", "ssl-trustfile"]` - the three blocks of code are identical and the switch is always composed from the opt name as `--OPTNAME` so this can be a loop rather than three explicit branches.

No need to block the merge for this though - it's a cleanup/readability improvement.


This should be `QueueProcessor(object)`.


Sometimes gives `[30-Sep-2015 15:35:13 UTC] PHP Notice:  Undefined index: size in /home/zschocianow/ftp/wordpress/wp-content/plugins/manual-image-crop/lib/ManualImageCropEditorWindow.php on line 39`

Should be `isset($_GET['size']) && in_array($_GET['size'], $imageSizes)`, isn't it?


On a un binding OneToMany avec un classe custom au lieu d'un binding ManyToMany donc on ne peut pas faire $this->users->contains($user);


And make bytes a `const uint8_t *`.


rspec test results on ProvisioningEnginev0.5.15_testfolder in simulation sync mode:
 --
Finished in 36.13 seconds
196 examples, 0 failures


I was basing those commands off of the bsd/mac version to silence the output since I don't want the output printed. Looks like that -s does not translate to linux versions

https://www.freebsd.org/cgi/man.cgi?query=which&apropos=0&sektion=0&manpath=FreeBSD+10.2-RELEASE&arch=default&format=html

https://developer.apple.com/library/prerelease/mac/documentation/Darwin/Reference/ManPages/man1/which.1.html

I'll need to revisit detection of those binaries.


same remarks as `writeBytes`.


Bad back ticks


Actually, why don't you use `CParameterBlackboard::readBytes()`? It is defined but unused in your Pull Request, by the way.


This looks unused now.


I found [this topic](http://stackoverflow.com/questions/25396075/is-the-heuristic-cocoapods-uses-for-the-pod-try-command-documented-anywhere) on stackoverflow and read source of the try command. Although I'm not familiar with Ruby, but the logic is straightforward. If there is more than one xcodeproj or xcworkspace, pick the one which name contains demo/example/sample.


TeamUser


Fixed in latest commit. Sorry, I fixed this locally pretty quickly, but didn't get around to pushing it until your note.


Don't use `else` after a return. That's the point of a guard clause.


I ran into issues I had to figure out.
1. I could not get model to create at first and remember I had to configure database.yml.
2. I could not get it to rake. I used ```rake db:drop db:create db:migrate``` however, I believe i could have used ```rake db:create db:migrate``` as I hadn't yet created a new database. Problems solved.


Yes, something like that would definitely be the most elegant and generic solution.


I think we need to clarify what we mean by a 'frame' in the spec and when things are considered to be "on the same frame." In other words, when does the browser increment the proverbial frame counter for a canvas element. Multiple requestAnimation events can fire and reference the same WebGL canvas before the page is composed. setTimeout can reference a WebGL canvas while tabs are not visible. With the arrival of offscreen canvases, WebGL rendering can happen on background threads while the render thread is executing.


where a primary server steps down to secondary in between a **find** with slaveOk unset and a **getMore** or **killCursors**, causing the **getMore** or **killCursors** to fail.


"Two others will not add the ids ,or partially for the second one."

This mean that users on PS < 1.6.1.1 and using default theme will have broken URL, this is not a good alternative at all.
This is what I call a breaking change, sorry if i insist.

Isn't there a way to fix it into 1.6.1.2, without breaking ? This would help all the addons editor and prevent them to edit & add 3 conditions to generate a simple product link.

Thanks


How about just ``make flake8`` which would be close if I could avoid this error:

```
$ flake8 --max-complexity 11 planemo tests
Usage: flake8 [options] input ...

flake8: error: no such option: --max-complexity
```

Strangely this seems to be up to date:

```
$ flake8 --version
2.4.1 (pep8: 1.5.7) CPython 2.6.6 on Linux
```


视锥细胞？


@bgerstle I'm not really sure what you mean by this comment.

It's only 4 lines and each line seems clear. To me it seems pretty straight forward.

Can you articulate what is unclear in this method and what needs explaining and maybe we can figure something out?


没翻译就不要碰。。


Don't forget to update the names here if you implement the remarks above.


@timj, we had long discussions about the public API before I went ahead with the migration, look at DM-2299, the discussion through comments go back as far as April. Most people involved were for exposing sqlalchemy directly, like we have it. So indeed we are expecting end users to be working with sqlalchemy exceptions (but never with dbms specific exceptions, we want to push all dbms specific ugliness into db, the utils.py in particular). We can reopen this discussion if you feel strongly about it.

Db is not supposed to have any complex internals, it is a thin "helper"-type layer only.


This got past markcop :(


Yeah, I am looking into it..


There should be a non-empty default value here.


Done. I need to check again the mfix thing to see what's wrong with it. For the moment, you can use mfix1, mfix2, and so forth.


Thanks!


remove test


4 spaces in you YAML? HEATHEN!


@limptwiglet can you provide a copy of your backstop.json file so I can test this?   Thanks.


Is this the actual data format we have to use?


Согласна с предыдущими ораторами (правда, если пропустили лекцию о том, что такое функциональные требования, рекомендую не википедию - там статья неполная и определений не содержит, а литературу, которая была вам выдана).
У меня замечание по мокапу - не совпадает с описанием из документации (например, опция выбора валют отсутствует)

Пользователи - мужчины 27-40 - это сильно! :)


@Arthur2e5 “没有可重做的缩放”？这是我猜测的行为


While I would normally protest that the odds of getting the same exact time are astronomically low, I'll just compare the bytes of the value and use that as the final check


请尽可能避免“被”


@ronen I agree and I'm also aware of the risk you mentioned in the last sentence. That's why I added the hint `Check that all screenshots look ok prior to committing them`.

If we don't introduce any other changes in file names (e.g. due to #11) then a simple rename would suffice. Another advantage of a rename would be that users don't lose their version control history (which would happen when deleting a folder and adding a new one).

I would leave it as is for now and if we know that we won't introduce any changes in filename or folder names with v1.0 we can update the Readme accordingly.


@Arthur2e5 这个不错


Patches accepted.


Пункт "Функциональные требования" не содержит функциональных требований.
Макеты интерфейса - отличные!


couple of things.  scss lets you namespace/nest your css.  So you don't need span.chartcard > svg > g over and over again.  Also we want to make sure you follow the BEM css standards.  https://css-tricks.com/bem-101/


通顺性优先…


formatting


I guess we should stick to spelling systemd all lower-case, even at the beginning of a sentence.


matappetit


What is with the `construction.html` file?


不该加东西吧。


That connections are all local to local, should be reestablished very quickly, right?
There is one risk for the stop/restart method is that the tcp port may be occupied by another process when suspend. But this case should be rare.


翻译的模式不应该如此，但是应该是无可用的 redo 项的意思？


@PVince81 We want to add a column to the "shared by link" section that lists the expiration date. I would add here a new cell that shows the date and we need to add a column header. Where to do this? In the `initialize()` method of this object?


cc @felixboehm


直接留空好不好


4-Library Desgine


No. Toolbar will be visible only whole frontend area, including account.


Отличная работа, добавляю плюсик, хоть и не in English :)


限制版本。PostScript 1,2 是用 Level 叫版本的。


I think the payload body should be the JSON blob containing data, and attributes can probably be ignored for now.


+1 复制原文没意义


降噪，请说中文。


空格日一下。


extra space after `internal`


Think we should hear @riastradh-probcomp reasoning for this commit.


If you write `var res: Rep[Array[String]]`, it will create a staging time-variable that holds the expression on the right. I think what you want instead is generating a var, so you will need to remove the type annotaitons and just write `var res = NewArray[String](1)'


Since an image can't be reprojected until it has been verified, and can't be verified until it has been uploaded, and so on, it seems like a single `status` field should suffice.


词性死了吗。


你是不是在用记事本啊。


`verifyNoDuplicates`?


public abstract class Animal {
	private String nome;

	public Animal(String nome) {
		this.nome = nome;
	}

	/**
	 * abstract fazerBarulho obriga as classes filhas a implementar ou seja a
	 * classe Mamifero e Oviparos e suas SubClasses
	 */
	abstract void fazerBarrulho();

	/**
	 * abstract dormir obriga as classes filhas a implementar
	 */
	abstract void dormir();

	public String getNome() {
		return this.nome;
	}

	public void setNome(String nome) {
		this.nome = nome;
	}
}


- n.
+ adj.


I'll fix it.


Paths beginning with `/` are not resolved relative to the current working directory; they are parsed beginning from the root directory, `/`. `/Users/...` will refer to the same file no matter where are when we state it.


Consider using Python doc comments.


前面说用全角冒号到这里又死了。


The comment is already there ("invalidate the snapshot used for cloning"). To understand it, though, you need to read `clone_ploop()` source first and understand its logic (at least the part about creating or reusing a snapshot in parent volume).


There is no index file available. Please check the [status](http://ccextractor.canihavesome.coffee/test/96) page, and get in touch with @canihavesomecoffee in case of an error!


Muy bien, ahora generaste actividad


Tested on Win - works great


@ccx-testerbot runtests master


还不如找个时间全部读一次…… 边做边翻太容易漏了


Sure, makes sense.


Indentation looks good to me now, except for this unnecessary white-space around err.


塌陷比较像是主动的词，该用令、使而不是将。。


I'll try to get a release out this week for supporting 3.3.0.

Sent by Outlook for Android

On Wed, Sep 30, 2015 at 4:52 AM -0700, "mbassermann" <notifications@github.com> wrote:
Is there a release plan for a new Version to support MyBatis 3.3.0?

---
Reply to this email directly or view it on GitHub:
https://github.com/mybatis/velocity-scripting/commit/872575acf835b5d28dd604f8023751693c93c60e#commitcomment-13515570


日了的，直接用中文破折号啊


OK


Thanks for the note @nvh, I'll push a fix in a minute :+1:


This job is ok to merge and deploy today (Wed Sept 30th)


2015 年了还有人 emdash 显示成 Tofu 的话怪不了我们啊


Cancelling this PR but I added it manually. Will commit by end of day.


Hi,

Error expected, users under 1.6.1.1 will not have this $anchor parameter in the definition, the function will not react and you will have links like <  1.6.1.1 were.

Sorry  I could not find a way without adding a parameter, if you have one then please propose it.

Regards


Fair enough.


FYI, this breaks key recovery half the time because S-value canonicalization and key recovery interact.

Experimentally it seems like if you end up flipping *s* you need to toggle *v* as well.   I'm still trying to grok http://www.secg.org/sec1-v2.pdf Section 4.1.6 at the moment to get the **final answer** on the right approach here.


Антон, зачем это?


I think each job type should be broken out into separate classes so the actual queue processing / dispatcher logic is distinct from the individual tasks.


Moving everything to https://github.com/fastlane/fastlane_core/issues/34


Thank you for the request. It has been added to the queue (id: 97). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/97) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


I think so....

when you add a user to your system, and give them only a few switches/sensors, the output of the original query was not returning his devices, and even more devices it had no right too.

I commented on the original pull request


`jsonWithCitation` looks good. The original idea behind the XXXDTO objects was that they could be converted to JSON automatically. Might have changed since then, though.


Do we need to assign a uid to S3 objects considering the bucket keys are already unique?


Yep, fair enough.


s/value/signature/


This broke the GCC/Clang build, will fix it soon.


Yep, makes sense


Many coins get generated in air


done


Many coins gets accumulated at same position.


@bgerstle the issue is a little deeper than that… we basically have some undocumented behavior of using an empty array to signify that face detection has been attempted. I don't think `nullable` addresses this business logic issue at all.

I moved the logic that sets the empty array to be internal to the class which is really where it should be. (previously, this class was relying on the kindness of others to set an empty array if face detection was attempted)

But to be honest… we should really create a separate flag for signifying if face detection ran and makes all of this moot.


Егор, функциональные требования у Вас написаны в слишком общем виде; п.3 - это вообще не функциональное требование.
Попробуйте что-то вроде "Приложение должно отображать список товаров, соответствующих поисковому запросу (можно конкретизировать понятие соответствия) и их стоимости, представленные сервисом ... (указать сервис) ...  " ; "В случае отсутствия результатов поиска ..." ; "В случае отсутствия соединения ..." и т.д.


To elaborate, the event data in this context will already contain the S3 bucket name and object key, so we should be able to look up `LayerImage` by `source_uri`.


Wow thanks a lot !!!


This probably doesn't matter much, but we should queue messages after updating the DB.


that was automatically added by jsfmt, I removed it


I just wanted to understand if this was some ruby technique/trick I wasn't aware of or a mistake.  So a mistake then?


yeah - pretty much  - this is kind of a mess. We should clean it up.


No. I pulled that out since this is essentially a run counter. Successes are tracked via SM, so to *not* log a count if we have 100% fails but still create the SM doesn't make sense.


Remember there are comments after `json` key: value pairs


Hi, Tiark!

Okay. If I have other problems that I feel hard to debug, I'll post it on github and send you email.

Safe trip!

Best,
Xilun

----- Original Message -----
From: "Tiark Rompf" <notifications@github.com>
To: "XilunWu/my-tutorial" <my-tutorial@noreply.github.com>
Cc: "XilunWu" <wu636@purdue.edu>
Sent: Wednesday, September 30, 2015 12:29:13 PM
Subject: Re: [my-tutorial] outOfBound exception. Error happens in init() (9f332cb)

If you write var res: Rep[Array[String]] , it will create a staging time-variable that holds the expression on the right. I think what you want instead is generating a var, so you will need to remove the type annotaitons and just write `var res = NewArray String '

—
Reply to this email directly or view it on GitHub .


omg monsters


"registered" typo


Hi, I too stumbled into this issue.
Would you mind opening a PR for this?


butter should be added before and combined with the sugar.


Thanks for the feedback, i'm glad that you using this hook.

I didn't catch that earlier, really sorry about it.
I'm using it at my startup, so i'll keep it up, if you find anything else just send a pull requests that will be welcome.

Thanks.


These variables contain images but are labelled as layers.


bake it with love !!!!


Функциональные требования не пойдут. Формулировать нужно по принципу "Приложение должно отображать ... если пользователь ... "
Никаких дополнительных прокладок маршрута и мобильных версий не нужно. В том виде, как представлено на макетах интерфейса, вполне достаточно.


ok


@loewenheim These tests all fail for me.  Can you have a look?


Like !


Is this not just assigning it's existing value to itself? Not sure whether this is actually what you wanted...


That looks stupid!


It would be cleaner and more organized to have this "layer verification" in a separate step. The reason is that if we later add another preprocesing step *after* reprojection, we will have to cut-and-paste this logic to the next step. I think this is an indication that it does not belong here.


@tpdownes the module has had new upstream under https://github.com/rdo-puppet-modules/puppet-firewalld and I'm no longer interested in it. I don't know whether the new releases will be available on puppetlabs somewhere, but there most likely won't be any more releases of https://forge.puppetlabs.com/jpopelka/firewalld.


This is fine. linux42 is not yet recommended to be used for a live-cd. Catalyst for instance doesn't run for that kernel yet.


Could you please tag a new version that includes these changes?


:+1: awesome


PYTON? Like ton of pythons? And it looks like a bad idea anyway.


lets have it no by default, till we make sure it has no hidden issues


Not really. List would only say `Unable to discover this_does_not_exists...`. It's manually produced output, which reflects the result of run.


@bughit, this is not a mistake. It is a technique to include both class and instance methods via a mixin. It can be done in other ways as well, but this is as good as any.

Hope this helps.


По формальным признакам лаба выполнена, но бизнес-цель не определена. Мобильной версии не нужно, а вот про карту подумайте!


we can have these flags always ON by default


lets also add test for yalla only


One of the goals of the clean architecture is to invert the source code dependencies.  So, your code should be able to be packaged, tested, and run without the Spring dependencies.


And how is that a nice commit message?!


Is there a full stop missing here?


Wrap to 80 lines


Раздел "функциональные требования" не содержит функциональных требований!


This cast is unnecessary. You should be able to just call `type.createBlockBuilder(new BlockBuilderStatus(), rowCount)`. Arguably, the two overloads of `createBlockBuilder` method are a bit weird for fixed-width types, since it makes no senses to specify an "expected entry size".


Yeah - but I just wanted to test the class directly


Hi. I saw what you begin implement the feature to open dropdown list above edited cell. But yours version of this feature leave dropdown list inside table boundaries. But I think what it would be better to limit dropdown list by browser window borders, so I try to make my version of this features. I make demo https://jsfiddle.net/a6uqm6qm/1/ and there is the commit https://github.com/vo-va/handsontable/commit/4ffd5d3fed8890a804937bac96bd01db87010fd6#diff-0a25aaaa72d09482c0875ad092179097R150 with my changes.

I not make this commit as pull request because it has major changes like `.style.overflow = 'visible'` for main table container.
And because it has some issue, and I want to ask to give me a advice how to resolve these issues:

1. I want to catch `mouse wheel` events to stop scrolling table, but not list, when dropdown list is open, and mouse pointer outside dropdown list area.
2. First inputted symbol not appear in cell when autocompleteEditor is opening. And I can't find code what responsible for this because this https://github.com/handsontable/handsontable/issues/2846


need refact for new Meteor 1.2 version
f = Meteor.wrapAsync(col.stats, col)
cols = Meteor.wrapAsync(col.stats, col)()


This appears to not pass in the React `context`.


ich han das mal ide basics umgsetzt. es object chan jetzt zumene XML konvertiert werde. es git en test service für das. s'ziel isches, keis temporärs xml file zgeneriere sondern de output nur im memory zha und an FOP zübergä. https://github.com/masterproject-reimbursement/reimbursement-server/commit/8f4b4bcc7860962b077a2f864cc7050ecb0710e0


During last week's discussion it came to light that we will not be receiving progress updates from EMR. Each job is either tiled or not-tiled. Since this step will only be triggered if the EMR job places a message in SQS, if we ever get this far then we know the job is complete.


Throw an exception if javaType is none of the expected types to protect from future changes silently breaking this logic.


基本上都只用了半角冒号，另找时间改回去吧。


Tiat retail server, tiat expects the players arrive mid-range to attack...it also uses long-range skill to attack, need fix!


poEdit啊


There is no index file available. Please check the [status](http://ccextractor.canihavesome.coffee/test/97) page, and get in touch with @canihavesomecoffee in case of an error!


Tagged 0.1.6


确实


Instead of listing all those files, just use globs?


Should we track failures as well?


Why aren't we using a caret?


Oops, that's leftover from a previous attempt. Just fixed it in my working copy, I should amend the previous commit and then force push right?


Thanks!


There are no functional requirements in the corresponding section! Please, update.


Ah, you know you could just rebase all these Updated LICENSE together :O, it gets kinda repetitive and distracting:
```bash
git rebase -i d48e8c34e7ed729b21bb59198e7a366bc2707e04^
```
then do a fixup for all the commits after it :)


When using GetDocuments('U',null,null), will it return all unacknowledged documents, or is there a limit to the number of documents retrieved in each call? I'm trying to determine if multiple GetDocuments() calls may be needed per day.

Thanks.


Nice! glad it has that feature!


It should be just after _isSeletable = flag


Can we make JSCS check this too?

`function () {}`


When cloning you snapshot the "parent" not to change the image. Why do you need to unlink anything when you just try to read-only mount stuff?


Steve,
  Thanks again!!  I was thinking of the same solution, i.e., parent.admin?  || current_parent == @parent but I was not sure if current_parent would be set before the occurrence of command line attack, but I figured it out as the attacker could issue an attack via the params hash and start deleting users by id.  So if the attacker gets lucky then he might be able to delete the account of the current user if the id in his attack matches that if the current logged in user?  If true at least this code prevents the deletion of all non-logged in parents.


Yes, please.
On Wed, Sep 30, 2015 at 9:57 AM Luke Childs <notifications@github.com>
wrote:

> Oops, that's leftover from a previous attempt. Just fixed it in my working
> copy, I should amend the previous commit and then force push right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/aurelia/fetch-client/commit/17daae159ad4539c892fdd514f31c2863130dd07#commitcomment-13523053>
> .
>


Why do we use global here, not just var?


Раздел "функциональные требования" не содержит функциональных требований!


mainly want to capture the rationale/caveats we've discussed which led to this implementation. let's chat about it over hangout, as I'd also like to see if there's an easy way to simplify & DRY this up


It's better to do (for the eyes) :

```
if (![self isRichText])
return;
```


If you sbt 0.13.9 make sure to review how to write a build.sbt file: it changed in the last version (now is more Build.scala like).


Why don't you use `.toggle(className, condition)`?


nice work!


Fsck this shit, I can't even reach this code in the original Python. I'd make it precision == 0 on both asserts there or remove the asserts for good. Thanks for spotting it.


Why are they traits ?


WOW that model is small.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21487/testReport/) for this commit**


use reflection to make it compatible with testng 6.8.x


BTW, you need to name all the variables in a pattern to make it work.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21488/testReport/) for this commit**


Нефункциональные требования не соответствуют требованиям к требованиям, в частности, требованиям "недвусмысленность" и "проверяемость".


Good call.

On Wed, Sep 30, 2015 at 12:57 PM, Corey Powell <notifications@github.com>
wrote:

> Ah, you know you could just rebase all these Updated LICENSE together :O,
> it gets kinda repetitive and distracting:
>
> git rebase -i d48e8c34e7ed729b21bb59198e7a366bc2707e04^
>
> then do a fixup for all the commits after it :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alatyami/Growthcraft-1.7/commit/12fb236fcc22ed2a4809218531b37b7264386212#commitcomment-13523065>
> .
>


There should be space around an operand like " = " . Not following pep8 standards


It is hard to understand how this gets builts. Try to refactor using external functions.


@ccx-testerbot runtests isdb


`xwiki-enterprise-test-ui/CopyPageTest.testCopyOverwritePage` was constantly flickering around there operations. For some reason, the javascript commands behaved as if they were performed asynchronously and the DOM would still not be in the rights state after the javascript commands finished executing. It seems the flickers are not showing up any more, but I am still not 100% sure the will not pop up again. That is why I am doing sanity checks at this point, since the behavior proved to be extremely unreliable in the tests.


What happens if the sinkEventProcessor fails to process the event?


No. of characters in a line should not exceed 79 . Not following PEP8 standards.


Можно StatusListener заменить на StatusAdapter, тогда необязательно будет пустые методы писать


this is sort of tricky that since 6.9.x, the TestRunner constructor accept `Collection<IInvokedMethodListener> listeners` rather than List, to make it be compatible with testng 6.8.x, I have to covert the collection to List


Congrats for this very nice simplification, once again you showed great insight on how the eval works!

How could we build on this to try to catch even more Elo (after it is commited)?

• obviously, tuning the "Major on weak" threat array is a good candidate
• about the difficulty of evaluating Queen threats, one aspect is that some pieces attacked by a queen can riposte, while some other can not:
    - Queen on Knight is always good
    - Queen on Bishop is good if she attacks verticaly/horizontaly, bad in diagonals
    - Queen on Rook is good if she attacks in diagonals, bad verticaly/horizontaly


We will be pulling in what we need for MSVC 2015 Update 1, which is not final yet. We expected this to be significantly less than is needed for the current MSVC release.


they are technically not duplicates :)


What a file. Don't forget to add Scaladoc to it that explains why this class exists.


"The first one involves [...] and the second one involv**ed**"


I'm currently investigating. I think if I explicitly pass in my context via props I'll be ok.


WOW new update :)


Thank you for the request. It has been added to the queue (id: 98). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/98) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


Yay @yurug told me that but I don't know why I changed. Maybe because it wasn't making any differences in the type error.
What does ```_``` mean in the case of Mtac ?


Short one-file script, that 's not so important


what would the glob that you are thinking of look like?


This is starting to get into "testing philosophy" territory, but bear with me: what's being tested though? If you're testing the cache, that's fine, but it looks like this test mostly verifies an expected output of `CIDetector` for an empty image. If the latter is true, then putting it in its own test suite w/ other `CIDetector` integration tests clarifies both the purpose of the test and the responsibilities of the face detection cache.


done


Re: my last comment:
> Experimentally it seems like if you end up flipping s you need to toggle v as well.

Upon further testing, this only works some of the time.  I'll try to send a pull req with something that mimics https://github.com/bitcoin/secp256k1/blob/master/src/ecdsa_impl.h assuming you don't beat me to it.


no comments


Hi @zwanthor, which part of code are you referring to?


Yes.
Or use Linux


indentation


It looks like you pushed CDRP05 conf intro master.


This is excellent!  Thanks!


This is a discussion we really need to have before the 0.7.0 release.  There are legitimate reasons on both side about what the right behavior for the cache file should be.


On Linux, it is just http://localhost:8888


@dakcarto this might help


> It is a technique to include both class

I already pointed out to you that you are not calling `base.extend(ClassMethods)` in the module to which this comment thread is attached (TreePathHandler)

https://github.com/evolve75/RubyTree/blob/master/lib/tree/utils/path_methods.rb#L42

For the fourth time now I am directing your attention to the definition of module methods inside the included hook.  I used a synthetic example:
```ruby
module Mod1
  def self.included(other)
    def foo
    end
  end
end
```
but if you're unable to relate to that, here's your actual code:
```ruby
  module TreePathHandler
    def self.included(base)
      def path_as_string(separator = '=>')
        path_as_array().join(separator)
      end
```
So what are you trying to accomplish with this?  This does not define any class methods, all it does is define the instance methods of TreePathHandler, but why would you do that in the included hook?


- [ ] 「注文が完了した際にカートの状態をクリア(カート内の商品を削除)するためのメソッドを用意する。」といった感じの説明の方がよい。（この時点では、なんのためにこのメソッドが必要なのかを説明することが重要）


there should be space after usage of ","  Not following PEP8 standards.


Sometimes a "P" is left behind(stationary) on collision with donkey while another "P" keeps moving .


Note that this is not strictly necessary, because 'docker run' should pull down the image if it is not available.

For offline usage, people will need to use

  docker load SimpleITKNotebooksDockerImage.tar

which we will distribute on the USB keys.

  http://midas3.kitware.com/midas/folder/13267


Just thinking out loud here, from the beginning of my thinking about this, but I'm wondering how a Ubiquitous Language differs from a [pattern language](https://en.wikipedia.org/wiki/Pattern_language)—and kind of thinking the latter may be what we really want to come up with here.

The difference I see is that patterns, rather than concentrating on terminology and definitions, provides a collection of named solutions to particular common problems. Maybe developing both would be a good idea.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21491/testReport/) for this commit**


<!DOCTYPE html>

	<meta charset="UTF-8">
	<title>Document</title>

ы

kjjjjtuuvghfb


I don't have time to check the derivation but the doc you reference are vector equations and |ω| are norm of ω, so you should fix your code and remove the abs values. and replace those by norms as well...


Note that there are a few more in Android:

* he and iw
* id and in
* yi and ji


- [ ] 「DIコンテナがsession・・・」の行もnote の方がよい。


I'd prefer taking this decision in modulegraph, so there is a single point where checks are made. `ModuleGraph._load_module()` should be a good place for this, as this is where the node is instantiated. The problem I see is that then we can not get rid of spawning a process except if we'd load that module into our process.
Should we open an issue for this?


No, compare the whole record please. Its the only way to establish a _total_ order. The assumption that signature value is good enough is not sound (under multiple key algos)

—
Sent from Mailbox

On Wed, Sep 30, 2015 at 12:37 PM, Jeromy Johnson <notifications@github.com>
wrote:

> s/value/signature/
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipfs/go-ipfs/commit/cfcc3d6a1b77a47cdf6512e6be24e8b3bbd9fb05#commitcomment-13522684


Nice spot. But that's not the real problem. Somehow pytest modules don't work if not installed into the system.


should use space after usage of ",". Not following PEP8 standards.


is this only used for the one arrow function?


@garris the problem seemed to be caused by a selector not returning a element, so if you add any non-existing selector it should cause the same issue. I can send you my json file later if that's better.


verifyNoDuplicateNames :D


Instead of sleep, we should add "-d" to "docker run".  We can also use an explicit "--name" with the run step, and not start if it is running (docker ps) or restart if it is stopped (docker start).

The Linux equivalent of "open" is "xdg-open".


khm maybe need delete return? And add
``` CPP
if (!m_IsControlEvadeEnabled)
```


I've created a pull request to demonstrate what I mean.


I'll fix it.


Wasn't there a reason this was a lambda in the first place? I expected to see a call somewhere to `bind(refresh, this);` in order to make this change work... ?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21492/testReport/) for this commit**


Also, exact time stamps happen all the time in long running production systems. I had to deal with this in a mobile application.

Two clock reads might return the same value on the same machine, even!

—
Sent from Mailbox

On Wed, Sep 30, 2015 at 12:37 PM, Jeromy Johnson <notifications@github.com>
wrote:

> s/value/signature/
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipfs/go-ipfs/commit/cfcc3d6a1b77a47cdf6512e6be24e8b3bbd9fb05#commitcomment-13522684


Не нашла функциональных требований в одноимённом разделе :(


The explicit pull was added to separate the download time from the boot time. I'll look into the effect of this when docker is run in daemon mode.


使用echo导致换行丢失


abc


使用default模板文件替换，否则替换一次就挂了


there is functionality defect in laddes


好玩的东东


防止正常执行进入线上部署


Please take another look


There may have been a reason, but up to this point I haven't found anywhere where it isn't called off the data source itself. I'll have to keep an eye out for that


还要在这里加入数据库匹配


Hey Orvid,

we are trying to get this to work on Windows VS2015, would it be possible for you to push your current branch as is to github, so we could test and try it as well?

> On Sep 30, 2015, at 09:06, Haim Grosman <korovkin@gmail.com> wrote:
>
> this one seems really important:
> https://github.com/facebook/folly/pull/287 <https://github.com/facebook/folly/pull/287>
>
> Should we be pulling it in ?
>
>
>> On Sep 30, 2015, at 08:48, Haim Grosman <korovkin@gmail.com <mailto:korovkin@gmail.com>> wrote:
>>
>> Hi Orvid,
>>
>> i can see a few more pending MSVC PRs here:
>>
>> Are those needed in order for folly to compile for VS2015 ?
>> (except the one you already commented on PR 315)
>>
>> thanks
>>
>>
>>
>>
>>> On Sep 29, 2015, at 19:02, H Grosman <korovkin@gmail.com <mailto:korovkin@gmail.com>> wrote:
>>>
>>> If the project files produces by cmake work that's awesome as we also use it.
>>>
>>> We don't use much from folly, mostly json, dynamic and string parsing API
>>>
>>> Which leads me to a conclusion that it should be fine.
>>>
>>> We will give it a shot.
>>>
>>> Thank you for answering, and please let us know if you push more MSVC changes.
>>>
>>> Cheers
>>>
>>>
>>> On Sep 29, 2015, at 18:50, Orvid King <notifications@github.com <mailto:notifications@github.com>> wrote:
>>>
>>>> For everything to compile, you need more than just that PR. HHVM builds Folly via CMake, which generates the project file, so the project file I pass along would be of limited use.
>>>>
>>>> —
>>>> Reply to this email directly or view it on GitHub <https://github.com/facebook/folly/commit/bae1869791b9fad1d53a45e18124e636b4ced923#commitcomment-13507610>.
>>>>
>>
>


We just lost a whole bunch of the project's history. It seems to me that this bulk change should have been performed with the git-mv command to that the history of commits of each file would be preserved.


no perfect modularity is implemented in this game


@atw Really fair comment, I agree that `.valign-*` on `_utilities.scss` sounds great! Let's update.


LOL!! nice one!


You're right. I was thinking most folks had moved off 0.94 by now. Would you have time for a patch? If not I could bang one out this weekend.


I did a reference search and refresh() isn't getting used yet, except in the children


space between , and delimiter


Thanks for making this! if you want to make a pull request I'll merge it back into my repo.


It is how it is done. So there should be no problem
On Sep 30, 2015 7:18 PM, "Felipe Corrêa da Silva Sanches" <
notifications@github.com> wrote:

> We just lost a whole bunch of the project's history. It seems to me that
> this bulk change should have been performed with the git-mv command to that
> the history of commits of each file would be preserved.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mamedev/mame/commit/1fc48ce120a376c288daeeed98daccecf1b60d7b#commitcomment-13523474>
> .
>


Why not also check for `null`?


Ahh yes, lemme remove that.


BUG : When the player is at the bottom of the ladder and we press the down control he is coming to the lower level


I will test on Windows...


When we press more than one key simultaneously player is moving simultaneously.


I have this test which answers somehow your second point
It computed "safe queen attacks",
http://tests.stockfishchess.org/tests/view/5606900a0ebc597e4f23e274
but it was applied to weak and also protected.

But I did not tried it on weak only.


Нефункциональные требования (1-е и 4-е) на отвечают требованию "проверяемость". Всё остальное - good job!


When the player reaches princess he is not going back to start position again.


But remember, any malicious attacker needs to have a session of their own to interact with the application, so they would either be logged out and there would be no current_parent, or they are logged in and they do have current_parent set (current_parent being whichever parent they are logged in as). So if they decided to spin through ids from 1 to 1000 and try to issue a delete request for each parent, the only person they could possibly delete would be themselves (which they should be allowed to do anyway through the UI) if we ensure that only admins or the current parent can delete a parent.


This is reasonable. FYI, you can do `'jstree-disabled-icon jstree-required-icon'`. Also, if this fixes a bug, it should get a test.


This is the weirdest commit message (and implementation) I can currently think of.  It's a gift on a personal level.  :gift: Thank you.


Looks good! :+1:


This should probably come after the 'docker run'.  If we use '-d', Mac/Windows users won't be confused by the 'point your browser to http://localhost:8888' emitted by jupyter. This could say "Point your browser to ${_URL}${NC}"


I'm not sure why this line needs to change?


This looks like the correct fix to #644.


I'm not sure I follow. What constitutes "too many var statements"? What if I add a new variable or function to this "constructor", but I forget to add it to the list above?


each item in the queue consists of
- the filename to load
- the type of render to execute (to distinguish between still / flight / keyframe)


Where's the old history of each mess driver now?

Take a look at this one:
https://github.com/mamedev/mame/commits/master/src/mame/drivers/ibmpc.c


FFS, Dave!


The test suite finished running the test files. Below is a summary of the test results:

| Report name | Tests passed |
| ----------- | ------------ |
| _Broken | 15/15 |
| _DVB | 5/5 |
| _DVD | 3/3 |
| _DVR-MS | 2/2 |
| _General | **23/24** |
| _Hauppage | 3/3 |
| _MP4 | 2/2 |
| _NoCC | 10/10 |
| _Teletext | **20/21** |
| _WTV | 13/13 |
| _XDS | 34/34 |
| _Options | **83/87** |
| _DTVCC | **0/14** |
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the [results](http://ccextractor.canihavesome.coffee/reports/98) page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.


Test what happens when the user is not in the database, this throws an error, there is a couple ways to handle this.


- [ ] シンプルに「sessionスコープのBeanをインジェクションする。」とかでよい気がします。