Typo: "at the moment of writing this it's enabled" -> "at the moment of writing this *is* enabled".

Also I think the use of the word "enabled" is a bit confusing in the last two sentences. I'd probably leave the penultimate sentence the same and change the parenthesised clause in the last sentence to say something more like:

> ... (currently govspeak is only available for landing and outcome pages, i.e. not question pages)


You should replace this `linter-ruby` with `linter-lsc`


+1 for the release name! XD


Ah ok, perfect then.


tert


Maybe keep the commit title under 50 characters? :innocent: A bit longer than 50 is okay, but the second sentence could have been the message instead of the title :)


Adicionando Java na Listagem de Linguagens


Done.


Adiciona Artigos sobre JavaFX, JavaEE e VRaptor 4


Should be fixed now - I was a bit careless about types


cc @sbrossie @kevinpostlewaite


They are too small to worth it. And most of them are fixes after review in fact.


you forgot to update the rawgit URL, it should now be:

https://cdn.rawgit.com/sinkap/160b4a3c4287d12c3bbe/raw/c10aa7c5c5d9e995296ae90d8ff8f0ea89b9bdc7/IPlotter.html


* "PGE Manager" is an installer/updater of PGE components
* "PGE Maintainer" is a special toolset which gives you able to convert, repair and fix errors inside content. I will merge LazyFixTool, GIFs2PNG, PNG2GIFs into united PGE Maintainer which will also have a bunch of wizards to give able execute batch processes more convenient. Now it can convert music on entire episode only with applying new filenames to the level files, but later it will have lots other wizards which will help to people repair/fix/convert their custom stuff


Other than in cases of doing pointer-math, the fact that VB sees a pointer as signed shouldn't matter, it's still a 4GB address range; Windows will only ever place 32-bit executable code within the first 4 GB of RAM, regardless of how much RAM the system has -- in fact, it wasn't until Windows 8.1 that Windows gained the ability to put executable code anywhere in the address-space.


@at15 It must be long...


Lets see first an example and try to solve it and write a proper UPGRADING paragraph.


Perhaps having a default value would be a good thing, because Beanstalk will just start failing deployments when some limit is reached. (Perhaps 50? I don't remember for sure.) This is the reason why the plugin currently deletes the old deployments: it will just start to fail at some point otherwise.

So while in principle deleting by default feels silly, it also feels silly to just start failing after some time.

That said, 20 is quite an arbitrary number, perhaps even 1 would be a good default: keep the latest version just in case. Usually when you really need to rollback, you'll do another deployment from version control anyway. Then again, 20 is the old value which would mean that meaning of old build files wouldn't change if we keep it at that.


It gives me the idea: How about adding an explorer context menu item "Fix sample rate to 44.1kHz" for windows?


Actually that is exactly how I did it but the I realized there are some tests that pass concepts as values. At first I thought the value passed should always be string but I was wrong. This seemed like the easiest way to handle this otherwise we will end up with if/else clauses just to see what was passed!


me gustaba mas las verciones anteriores mejor diseño. ahora no se pueden poner logos y estaria bien la epg tambien


I guess this should be `if (versionsToKeep != null && versionsToKeep >= 0)` because it's perfectly reasonable to want to keep zero versions. That is, when deploying, delete all old versions without having a backup version.


This breaks "qemu -device pci-assign,..." of video card, because video card has two devices (vga + audio) and pci-express bus in one iommu group.


I think that i can add it to the TODO file.


Don't use hard coded sources. Use @Url.Content instead


@halfcrazy  这个改动可以么？我夹在 [PR#113](https://github.com/python-cn/firefly/pull/113) 里面了，单独摘出来先让你 review 一下。


Shouldn't UTF-8 be used for all languages?


Just a question. Is 'havana' removed intentionally ?


Don't need the extra parentheses here ;)


The `:0` was correct.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20306/testReport/) for this commit**


This is my first and initial repo


It might be nice to use Faraday middleware to parse the JSON here.


Do you need to parse it and re-generate it? Could you just return the contents of the `File.read`?


if we change this, then usage -texts should be std::cerr then ?


these texts here too should be std::cerr everywhere


What do u mean by 'Itee' ?
Function Name should be self descriptive.


@jaxx56 But let's do that after we merged the databases.


@nfeske: please try the following commit


Unfortunately I'm not sure. If it were to be used for all languages than the XML would need to be discarded entirely.
One good part about the XML would be that it could be patched easier if somebody would want to modify a part of it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20308/testReport/) for this commit**


Why? These are only information, no errors. printf() outputs to stdout as does std::cout


don't use hard coded value here. Remove this line.
content should be minified if attribute debug is set to FALSE in the section system.web/compilation (web.config file)
  <system.web>
    <compilation debug="false" />
  </system.web>

otherwise you should see full version of scripts and styles


No need to create new $id array, as there is no difference between $m and $id array. Please check.


img.add - returns add results. works for me img = img.add(slide[0])


static


Папку .idea не нужно заливать в репозиторий


префикс group у полей не пишем


La valeur maximale est de l'ordre de 24, mais on peut accepter de 1 à 99 sans trop de problème.


Why "bonnie"?


Can you follow the convention used above for the pep8/build/nosetests steps which use the `display_result` function to exit the script if any of the steps fail?


Сигнатуры должны быть совершенно случаными, высокоэнтропийными данными. Никаких 'pwrm'.


Just switched, everything looks to be absolutely fine. Witch name/directory changes like that it might happen that files aren't found and such, but no problems here. :)


@vanthome `didSelect`, is such naming aligned with the rest of our actions?


Nous allons vous appeler dans %1$d:%2$02d


Nitpicking:
According to [https://msdn.microsoft.com/en-us/library/18x8h1bh.aspx] the max length returned by tmpnam_s is not
L_tmpnam but *L_tmpnam_s*!


Evaluting -> Evaluating


I didn't know what to name it so I just named it how I would do it :) Was going to ask what name we want to use there.


You forgot to add vendor prefixes here.


Зачем включать этот файл ДО проверки, подключен ли модуль pwrmon.c в конфигурации проекта?
Он специально стоял _после_ #ifdef


Votre nom


Yea, good idea, because I wanna make PGE Maintainer as hybrid Console+GUI to have able use it in scripts too (and if you will wanna force it to be GUI or console, arguments --force-gui or --no-gui are will be added). The difference is that progress will be shown in the console or will be shown as pop-up dialog box with progress/statistics stuff, etc.


Hi Varun,

On Wed, Sep 09, 2015 at 05:38:40AM +0100, varunw-nvidia wrote:
> @achingupta<https://github.com/achingupta>
>
> Thanks Achin.
>
> Do you think 'max_off_lvl' and 'end_pwrlvl' usage is a bit confusing? 'end_pwrlvl' might change after state co-ordination but 'max_off_lvl' remains as is. So I thought that 'end_pwrlvl' might not be equal to 'max_off_lvl' in all scenarios.
>
> Based on this understanding, I thought if 'max_off_lvl' would be SYSTEM_SUSPEND when the actual highest power level after co-ordination is 'not' SYSTEM_SUSPEND.
>
> Does this make sense?

ah! I see what put you off track. I agree that the terminology can be
improved. It would be simpler to refer to power levels as the ones that were
requested and the ones that are targetted post state coordination. However I
would not like to change the scope of this patch with those changes. If you have
no further concerns then I will update the PR after incorporating Dan's
comments.

We will push out a separate patch to improve the readability of the code.

Thanks,
Achin

>
> �
> Reply to this email directly or view it on GitHub<https://github.com/achingupta/arm-trusted-firmware/commit/3bf351c857df0c5a181cd21fdbfc8071569f1e47#commitcomment-13127584>.

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2548782


Nom (facultatif)


Just fix the typo and LGTM.


служебные файлы IDE следует исключить из состава исходников.
.dep сгенерируются заново при сборке проекта.


don't ask me why; sometimes socket onclose is called before onerror and sometimes not that's why there is a !this.socket check


En attente que %s soit en ligne...


Prefer to use Should.Throw<EntityNotFoundException>(() => ... here keeping with using Shouldly for all assertions.


Discussion privée annulée


doesn't change a thing


mmh, seems they are not in the current 2.8 release.
I hope mpv will hold the removal until they will.


Not really, the synchronisation object is only file here. Synchronized is not really needed here, but won't harm either. May be just for the case of misuse, volatile will not harm either.


Tried this style previously when following esri-leaflet, but the links break when accessing the changelog via github in the browser. "Upcoming changes" with with square brackets is working, however.


テスト


That's supposed to fix issue #667, not 616.


file


@BibMartin Okay. Is that 17 always fixed in the notebook, regardless of window size? Is there some other way in the HTML (or elsewhere) we can specify width as 100% but maintain a desired aspect ratio?


the evaluate in pawns.cpp is called only when a new pawn configuration occurs on the board.
The resulti is stored in Hash, so anytime the same pawn configuration occurs,
it does not reevaluate, and simply take the stored result.

For this reason, you cannot  refer to non-pawn pieces in pawns,cpp


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20309/testReport/) for this commit**


Use current version, compile it yourself.


done


#5048-HVAC-Sizing-Summary-Thermostat-Setpoint-Temperature-at-Peak-Load-=-0-for-ThermostatSetpointDualSetpoint (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (775 of 775 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-18.79%25-green.svg)


remove these two lines and add scripts in the bundleconfig


Thanks


I think there is a bug. Try casting a creature that has changeling ability(Mirror Entity) before playing a land. You cannot play the land afterwards. Maybe the allsubtypes ability or the changeling itself returns all types...


After a new merge and a new test, @LeMagnesium  tell me it works with Minetestserver-0.4.13-stable version...


ok


Please revert this one. It now reads silly. For instance: "In A month".


The answer is it depends.  Yes, if module B depends on module A.  If module B does not depend on module A then it should probably have it’s own type table (specified using the  '-DSWIG_TYPE_TABLE=‘ option) and then the order doesn’t matter.  However in that scenario there will be 2 global type table variables, one for each module.

> On Sep 9, 2015, at 1:51 AM, Joel Andersson <notifications@github.com> wrote:
>
> Will this work if you:
>
> Load module A
> clear all
> Load module B
> Load module A
> ?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/dcb210/swig/commit/37f9d5276c8355e168ccdb3e38ae33b6208d5d75#commitcomment-13128119>.
>


Maybe we could just give `java.lang.StringBuilder` similar treatment as `java.lang.String`?


Tämä on nyt vasta pelkkä otsikko, lisää siihen nuo hakasulut ja normisulut niin siitä tulee oikea kohta linkkeineen päivineen


Yup, thanks for pointing that out - doesn't make much sense for this to ever be None, so I've made it an assertion in 070e00a.


It brakes the close callback in controllerAs syntax:
http://plnkr.co/edit/5UIOVj3sDYIyUoNScql9


Niin oliki. En jaksanu muistella, mitä eilen puhuttiin niin aloin vaan testailemaan. Thanks!


No habría que modificar también el get_aspectable_method ? Si no va a romper cuando se transgoreme un metodo privado. De todas formas, lo pide el enunciado esto? Pq no se si tiene mucho sentido que un usuario modifique un método privado, no?


Nice work Frank, thanks for the PR.  Aside from my one nit pick, happy from my end.  Feel free to update https://github.com/YoloDev/elephanet/blob/master/release-notes.md and https://github.com/YoloDev/elephanet/blob/master/.travis.yml (build deploy file) if you are comfortable as well, then I can pull this straight in and deploy.  FYI, I'm trying to stick to sem-ver for the versioning, but as we are still pre 1.0, I'm not too stressed.  As this isn't breaking, just bumping the last number is my pick.


also, if you add

```
[["osx" "homebrew"] ["bmake"]]
```

here then the Travis OSX tests will pass.


else if


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20310/testReport/) for this commit**


The reading and writing do not have to be in separate loops, but I guess it's not strictly necessary to fix in this PR.


Great work in producing a working cec driver.

Can you please confirm my understanding of your comments:

echo "1b 10 6c" >/sys/devices/virtual/amhdmitx/amhdmitx0/cec
This would correspondent to a cec message that looks like "10:44:6c"

I don't understand what happened to the 44 in the first line so do not understand how to code the cec command for the echo?

should the echo statement be "1b 10 44 6c" rather than "1b 10 6c" and if so would cec command "10:36" be coded as echo "1b 10 36"

Thank you.


Voit käyttää sähköpostiosoitteissa < > -merkintöjä, eli kun laitat osoitteen noiden merkkien sisään niin se on suoraan klikattava linkki sit kätevästi


done


Trailing comma here?


@vanthome does the model here refers to an Ember Route model? maybe it's better to keep `name` (or `id`) instead? So that it's more generic


How can this idea be tested?


@arter97 @temasek

I don't think this patch is required any more. For my device(cortex-a15) I don't have any more any seg fault.

Those errors were occurring with  5.0.x. Seems that 5.1.x resolved that.


run_until_idle needs to be either static or proper public API

I think it should be proper public API  (and hence also implemented for bare-metal)

Then we could potentially get rid of the built-in call to Scheduler::postCallback - the implementation of eventOS_scheduler_signal() in the adaptor could do that. Then I think we could manage without a separate event.cpp implementation at all, at least until the MINAR integration gets fancier.


http://s2.iranxm.com/up/c53d30ad023c.png

please check it


useitem ID = 0, means nothing right?
and i avoid using array, to do some quick mapping though :laughing:


Done


Great I think the same.
This project is now so popular, and I/we need to improve the flexibility.
Im interested to refactor the code to have a request service that can be extended.
Also to reorder the js in different folders, like controllers, directives, etc.

Regarding ES6, I guess the project at this moment is very young, then maybe could be limited just for js coders that write in ES6...


Actually, reading the source a bit better, I can see why simply reverting is also suboptimal. I'll give this some thought.


Why this file is called _Layout_template ? Do you use it anywhere?


I agree, but could you please add more info about the "index is a 4-byte opaque key' or give an example.


"In A month" could maybe become "A month from now"


Sure is!


Files are implicitly flushed when they are unmapped. Is that a problem?


Hola Ale.
Estaba viendo los commits que estás haciendo sobre este branch y estaría bueno que crees algunas issues para que luego se haga más fácil el seguimiento. ¿Qué te parece?


@OmgImAlexis can you replace fuzzymoment with timeago (with allowFuture ofc)? Does this work as cdn?
http://timeago.yarp.com/jquery.timeago.js


storeMode 删除吧？ 没啥必要


Almost all yes, although they haven't been that before.


You're fast :) A few questions/suggestions on the patch:
- CMAKEMODDIR may be changed CYGCMAKE_ARGS, this seems to be be easier than patching
- I've committed M_PI chunk upstream, so you won't need to patch it for next release
- I don't understand why's lexical_cast chunk needed: before it used std::to_string which is as I know not available on some compilers; however now it uses very basic std::string construction and concatenation which doesn't even require c++11


:ok: :1234:


I managed to merge the two options thanks to `nargs='?'`. You can do `--parallel` or `--parallel=4`. That's even better!


In this case getting "hFind == INVALID_HANDLE_VALUE" just means the directory to delete is empty, so the return value should be 0 to signal to the caller that it is fine to remove the directory.


multiple 时总是数组，统一下，不然调用者还要判断


These two lines could be `buffer.position( 0 );`, no?


Create new directory for product images. You will able to separate images for the site and business products


Okei! ja toi (a)-merkintä on miukumaukuksi riittävä?


kid is optional only for JSON keys. My thought was to add a key resolution mechanism, as you suggested, once we have a real and clear use case.


not all necessary styles are added here


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20311/testReport/) for this commit**


Argh. Thanks a lot @Blaisorblade, I didn't see that! I'll make the change and test again! Thank you!


add bundles for scripst


There need to be a ',' behind PutFileNoPermission. Otherwhise this would raise a SyntaxError


можно заменить на else


It seems to work on 0.4.13 with that commit. I created the world in 0.4.12, so I'm not sure it's because of the fix. Let's still try.


Yes. Good spot. Thanks.


Yes that is true will recover it when back in home. :/


Well, check_ssl_certificate should entail two parts:
* checking that the certificate chain is valid and that it leads back to the proper CA
* checking the hostname

it is perfectly valid to check the certificate is valid and have the hostname not match, which happens quite often when you don't have control of the hostname of a machine (Amazon for example) but you do control the CA.

We've done this with PyMongo and TxMongo:
https://jira.mongodb.org/browse/PYTHON-834

Is it possible to also do this for s3cmd?


Nope, ihan oikea @-miukumauku.


Wasn't sure if that starts to cause problems once you start working with Javascript. But I guess you just assign new Javascript friendly variable names when that comes into play. Also, didn't know it was called snake-case. So that's cool.


defined pi on the phi


Check.


I think your test is wrong or at least incomplete because you are setting the value of the setting and then testing it in the same process and it is presumably cached, so you aren't actually storing and retrieving the setting.

That and the fact that it doesn't actually fix the problem.


It does. I put your wording in the comment.


I think I was just allowing some h breathing room. Just in case I need more important h's for other content on other pages. That was the thinking anyway. Always felt a bit weird using an h for a logo either way.


Ok, but then you load a module C that depends on both A and B.
I think the persistent/mlock approach is safer.


I would argue that QUnit should have some kind of syntax like:

```javascript
strictEqual({
  expected: 42,
  actual: jQuery( form ) .data( "test", 42 ).data( "test" )
}, "form with aliased DOM properties");
```

This arguments confusion seems pretty common, since a reader cannot infer the arguments order from the calling code upon review. Also, for those who also work with [JUnit](http://junit.org/apidocs/org/junit/Assert.html) in a day to day basis will be confused by the fact that the arguments are inverted.

@jzaefferer is it worth creating an issue in QUnit, or this has been discussed already? I couldn't find it.


Hi, have you tested this with the nRF52 Preview DK? When I compile my fruitymesh with this setup, it runs into a hardfault at the SOFTDEVICE_HANDLER_INIT macro.


In this second commit, the singularize() function is being modified as well.


Yes, of course. Bah.

Thanks.


I was just hoping that the next mpv release will come after the ffmpeg  one for obvious reasons.

It is not a matter of me don't want to compile myself,I just compiled ffmpeg and mpv and ladspa works good without the need to specify channel layout anymore, thank tou very much.


I honestly don't know why temasek picked this :P


Normal props will always die even if only a LINKMSG line is in a SET NC.  That will make this type of change very difficult to deal with.  At least must be taken into account before this type of change can move forward.


Are you sure this one is invalid? I am asking because this one get's checked by Suse::Validator in line 1109. So either it already fails there and this additional check isn't needed. Or it passes, which would make me wonder if it's truly illegal.


hmm? not following? when `get_proc_cmdline_key()` fails we don't cache. That's the general logic here: only if we *know* that we want or don't want the hierarchy we cache. If we failed to determine if we want it or not, then we don't cache, so that the caller can redo the check. This is useful in some cases, where `/proc` is not yet mounted, where `get_proc_cmdline_key()` is likely to fail, and it should really fail and not result in a cache fail forever...

Or am I misunderstanding what you are trying to say?


don't use absolute position here. use bootstrap class pull-left instead. remove margin-left property


I really want to know in what case this code works very wrong


Why not remove the Unlock instead ?


Я бы оставил пустую строку перед каждым элементом. У вас как-то всё налеплено - неудобно читать код.


Yes, LoL, I'll fix it


Won't hold up, but generally prefer a trailing comma in Python - makes it easy to append now lines
(JS barfs in IE & hence compiler)


don't use absolute position here, use pull-right instead. remove margin-right


ditto


Needs more line-breaks.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20313/testReport/) for this commit**


we could, but mafft is already required for bootstrap so is the logical
choice. For create it is pretty straightforward to run your own
favourite multiple aligner, because you can provide it as fasta as an
option in create.

Any particular reason you like muscle?


В следующем коммите можете уже этот лист убрать. Вы его объявили, но не используете.


you should add clearfix class to this div after adding pull right and pull left its children


Fixed.


Release note added.


我没法用啊，如果不能紧张这个store的话


:yum:


`finally` on its own line.


我觉得可以直接禁止store的功能，感觉那个东西应该通过prop传递进来


Опять же, оставляйте по пустой строке перед объявлением каждого нового элемента и метода.
private ExpensesAdapter expensesAdapter;

@ViewById(R.id.recycler_view_content)
RecyclerView recyclerView;

@ViewById(R.id.fab)
FloatingActionButton fab;


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20314/testReport/) for this commit**


datatable迁移


It was forgotten. Those time when we use GCC 5.0 but using art with 4.8


@jwass I guess this is not fixed ; it may depend on the screen resolution and orientation. But the notebook rendering of a mpl figure is also dependent. It seems logical to me to output something *behaving like* matplotlib by default.
If you want to have "100%", you can simply use `mplleaflet.display(fig, figsize="100%")`.

If you want "100%" to be the default behaviour, you shall replace line `155 : figsize=(None,None)` by `figsize=("100%",None)`


I only tested without softdevice so far.  I haven't got time to test softdevice yet.  Still have a few projects to complete before I can get back to the nRF52.


It looks like we have a more general problem because there are 29 instances of `addCleanup(shutil.rmtree, ...)` in the source tree, only 2 of which wrap their second argument in `six.text_type`. I'm making a note to investigate. For now I'll leave it in.


@josevalim I hope this is not obscure, I wrote it as a reduce before doing this but I thought `Map.merge/3` would be much more elegant, even if we have to pass again later to purge `{path, :existing}` tuples.


File name should be 'Insert.php' instead of 'insert.php'. Please update all service classes file name accordingly.
File name 'insert.php' will work fine with windows server but it will create issue with linux server.
For more information regarding naming convention refer following link :
http://framework.zend.com/manual/1.12/en/coding-standard.naming-conventions.html#coding-standard.naming-conventions.filenames


This can be replaced with the following context manager. It's not important but I think is a nice thing to learn from python.

    with open(SECRET_FILE, 'w') as secret_file:
        secret_file.write(SECRET_KEY)


Line is too long. [106/100]


Line is too long. [132/100]


Line is too long. [125/100]


Line is too long. [102/100]


Line is too long. [102/100]<br>Space inside parentheses detected.


I'm happy to merge this as it is. But I'll leave it to you whether or not you want to use a context manager to open the file ;)


Line is too long. [115/100]<br>Space inside parentheses detected.


Line is too long. [101/100]<br>Space inside parentheses detected.


Space inside square brackets detected.


add new line at the end of the file


I didn't document it because it's a bit of a hack. It exists only because Django has API that are incredibly hard to test in isolation. If there's a lot of demand, perhaps we'll document it, but I'd rather encourage people to write testable code (e.g. mocking or dependency injection).


This is just fine as a standalone commit :-)


Don't overwrite bootstrap classes. In your code remove .one-item class from the div.col-xs-6, wrap your code with container. add class one-item to this container.


Because it is before all other calls to completion_ret(), not sure if they're actually necessary, but there's no point in having this one thing behave differently.


I want create pie chart using dynamic data from JSON.
Data will looks like:
 [
 {
"name": "Baner",
"per": 77.69
},
 {
"name": "Wagholi",
"per": 22.31
 } ]
I pass data "perArr"to renderInLayer method,
[self.pieChartView renderInLayer:self.pieChartView dataArray:perArr];
and change return value intValue to floatValue but in pie char it showing round of value like 77.69 it showing 78 and 22.3 to 22. Sir,Can u tell me how to show PerArr values in pie Chart.?
 plz Replay,


Well, inform me on the progress anyway.
Mentioning with @ will also work ;)

Thanks for your time :)


Yeah python has a built in function for everything and there always is a shorter way of doing something. Lists have a lot of things in python that make them super powerful. Also you could ensure lowercase on your input via...

```python
word = input().lower()
```


Can you prefix this variable with the module name. The reason is that the all the config variables are then loaded into the same global dictionary and there is a risk of collisions with very common names.

Actually a good name for this variable would be: "`CITATIONS_FETCH_LEGACY_URL`" to describe the fact that this is the URL of a legacy system.

Also can you add a `docstring` before the variable to document its value?

E.g. see: https://github.com/inveniosoftware/invenio-search/blob/master/invenio_search/config.py#L31


TeamCity ReOpenLDAP :: devel-2.5 [Build 112](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=516&buildTypeId=ReOpenLDAP_Devel25&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:35:02


That's a fair point. It may be worth having a 2nd flag.  Not sure python's
ssl validation library knows the distinction though.

On Wed, Sep 9, 2015 at 6:46 AM, Bret Curtis <notifications@github.com>
wrote:

> Well, check_ssl_certificate should entail two parts:
>
>    - checking that the certificate chain is valid and that it leads back
>    to the proper CA
>    - checking the hostname
>
> it is perfectly valid to check the certificate is valid and have the
> hostname not match, which happens quite often when you don't have control
> of the hostname of a machine (Amazon for example) but you do control the CA.
>
> We've done this with PyMongo and TxMongo:
> https://jira.mongodb.org/browse/PYTHON-834
>
> Is it possible to also do this for s3cmd?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/s3tools/s3cmd/commit/6da1585975882027c8bbbf297c573765c6cd6a2f#commitcomment-13133854>
> .
>


Fixed #108 as well.


@miigotu I use that myself I can but I can it wait till tomorrow night? I've got plans to sit down and redo most of the js then and there's no point in swapping it now if we're going to do that as it needs date elements and stuff.


done


Yes that's what I wanted to do. I'm doing it now.


None, I almost exclusively use mafft, but I know muscle is used around commonly enough. I thought providing the choice may be nice. But you're right, a user could just provide their own alignment. Never mind then


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


GOOD WORK FRANK


Thanks


No problem, Frank


Please, add a `docstring` to document this function. The syntax we use for docstrings is RestructuredText: https://docs.python.org/devguide/documenting.html


seguro que lo tenes presente :). Habría que completar esta ISR o poner un TODO


![student](https://cloud.githubusercontent.com/assets/8422699/9761267/ad51a1b2-56c9-11e5-95fb-7cabccd7aae5.jpg) look at this spooky picture, Frank


Can you `export DJANGO_TEST_PROCESSES=2` in the appropriate Jenkins tests scripts and ping me on IRC when that's done? Then I'll force-push the branch with all the changes to take your review into account.


Here too, please document the function :+1: .


I am not sure this should be treated an error. Or not always be treated as an error.

Maybe add a new option for this `--fail`. If it is passed we'll log at LOG_ERROR level and return EXIT_FAILURE. If it is not passed we'll still log, but at LOG_DEBUG level, and return EXIT_SUCCESS?


Note: I now realize we are missing correspondingly populating the `Citation` table, by carefully adding or removing citations following the actions in the log.


`https` instead of `http`


- Каждый класс в отдельном файле
- Я все так же ожидаю увидеть паттерн observer.


This import seems not to be needed.


The reason this is causing problems for current users is because `rails new something --database=mysql` generates a local Gemfile with an unconstrained `gem 'mysql2'`.  But then mysql2_adapter.rb, as above, was loading the `mysql2` gem with `gem 'mysql2', '~> 0.3.13'`, which means any `0.3.x`.

Now that mysql2 0.4.0 is out, bundler will install it, because of the unconstrained line in a newly generated Gemfile.  But mysql2_adapter will refuse to use it.

You've updated the spec in mysql2_adapter above to `gem 'mysql2', '>= 0.3.13', '< 0.5'` -- but the basic problem remains lying in wait for whenever a mysql2 0.5.0 is released.  No?

I think the same problem will occur when mysql 0.5.0 is released -- `rails new something --database=mysql` will add an unconstrained mysql to the app Gemfile, which will allow 0.5.0, but mysql2_adapter will refuse to use it. So this is not a great fix.

I think the right solution is that the spec generated by `rails new --database=mysql` needs to match the spec in the `gem` line in mysql2_adapter.  Either they both need to be unconstrained (like the generated Gemfile is now), or they both need to be constrained, and matching each other (like the `gem` line in mysql2_adapter is now).

Am I wrong?


LowSpeedEvent, HighSpeedEvent   - сделат один класс принимающий время задержки.


@OrKoN it's the property name under which the data is made available to the template.
With "name" I have two probems:
1.) It's already use in the Context for the name of the page
2.) It's too generic
so maybe `key`?


Fixed


`key` is good too!


Use more descriptive variable name to avoid confusion,  as show service is also having 'showDetails' method.  We can use '$showServcieObject' instead of '$showDetails'. It will help us to know variable is holding any value , array or object. So be specific with class, method and variable name.


This struct now has a _lot_ of arguments, would it be possible to turn this into a real class and perhaps offload some of  the code `SearchCheck#result` into that?


@smarterclayton

This was added more than half an year ago and noone is actually using it. Can I remove it?


Du coup, `\d+` convient, ou on limite à `\d{2}` ?


@rileyjshaw or @iiegor: Could you provide me some example `data` before you strip the ANSI codes with `stripAnsi`? IMHO there is something really wrong with the ANSI codes here, because the parser should be fine with handling em alone.


This sometimes produces an error saying that test and train data sizes sum to num_instances + 1. Which should probably be fixed in scikit-learn, but in the meantime using the following works and is nicer anyway:
`test_size=None`


It was that Adrian and Michael said... I'll check with some of them then.


It looks great!


Oh neat .. I will use that as a test and add reading the header for Accept formats to the listActivity method; i.e. if "format" is not set via the URL, check the Accept content types in order and return what we can.

I'll also make it set the content-type properly too.

Thanks.


I'm working on this code as we speak.

I don't think this change is quite correct, we wouldn't want to update the user details this way, otherwise someone can change the user details of another user just by using their email address when placing an order.


ok let's do it in another branch :)


Pleas don't freeze library dependecies to avoid conflicts with application using it


Done.
https://github.com/MinetestForFun/server-minetestforfun-magichet/commit/1791085b8ea9db90f0cdb77312d1ae8c79d79f6c


This overwrites the custom config. So if I have a different port it's overwritten to 4444. This should be
```
this._config = merge(detectSeleniumBackend(this._config), this._config));
```


Hi @vlimant just logical. It's either by lumi or block. But I overlook problems for other part of submission.


According to this:
https://docs.python.org/2/library/ssl.html

there is this function that can be re-used:
https://docs.python.org/2/library/ssl.html#ssl.match_hostname

and the attribute in SSLContext:
https://docs.python.org/2/library/ssl.html#ssl.SSLContext.check_hostname

That way when you go to validate the certificate, you can also check the hostname (or not).


To keep the default sending format, you could have:
```java
if (converser == null)
     reqBuilder.post(tracesToSend)
else
     reqBuilder.post(conversor.convert(tracesToSend));
```


void


Switched the order around here so that clojure.test failures read better (it phrases things such that the first argument is the expected value)


I am talking about this line exactly, which IMO should not be this way


This should be set through a method (or passed as a parameter in the constructor) and configured from outside.


Example:
```
import socket, ssl

context = ssl.SSLContext(ssl.PROTOCOL_TLSv1)
context.verify_mode = ssl.CERT_REQUIRED  # validation required
context.check_hostname = False  # hostname validate off
context.load_default_certs()

s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
ssl_sock = context.wrap_socket(s, server_hostname='www.verisign.com')
ssl_sock.connect(('www.verisign.com', 443))```


Looks good.


converter*


It was already removed on our Jenkins instance. But that's fine. Havana is already EOL


There is a small bug in line 57  (`sed -i "s/443/8443/" ....`) as it keeps prefixing with 8443, 88443, 888443, when doing `docker start / stop`. Just change that line to `"s/= 443/= 8443/"` and it should be ok.

It would also be nice that port number be in environment variable. Just maybe.


Wouldn't be more extensible to have TracesConverter as an interface and then to have XAPITracesConverter that implements it?


Oops, guess I should've been more clear. I meant we should have a utility function which appends any param to a URL, since there are several places in our code where we could use it.

ex: `public static String appendUrlParam(String url, String paramName, String paramValue)`


@dschuermann  Could you hold off on refactoring commits before the first release? e.g. renaming the app while I'm working caused me to waste time rebasing and merging my changes.


1: M111 unrecognized component name: legacy


38:1: I100 Imports statements are in the wrong order. import cgi should be before from invenio.utils.deprecation
38:1: E402 module level import not at top of file
39:1: E402 module level import not at top of file
40:1: E402 module level import not at top of file
41:1: E402 module level import not at top of file
42:1: E402 module level import not at top of file
45:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS, CFG_BASE_URL, CFG_BIBFORMAT_HIDDEN_TAGS, CFG_BIBINDEX_CHARS_PUNCTUATION, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS, CFG_BIBSORT_BUCKETS, CFG_BIBSORT_ENABLED, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE, CFG_CERN_SITE, CFG_INSPIRE_SITE, CFG_LOGDIR, CFG_LOGDIR, CFG_OAI_ID_FIELD, CFG_SITE_LANG, CFG_SITE_NAME, CFG_SITE_RECORD, CFG_SITE_URL, CFG_WEBSEARCH_DEF_RECORDS_IN_GROUPS, CFG_WEBSEARCH_DETAILED_META_FORMAT, CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS, CFG_WEBSEARCH_FIELDS_CONVERT, CFG_WEBSEARCH_FULLTEXT_SNIPPETS, CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH, CFG_WEBSEARCH_IDXPAIRS_FIELDS, CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT, CFG_WEBSEARCH_SYNONYM_KBRS, CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY, CFG_WEBSEARCH_WILDCARD_LIMIT, CFG_WEBSEARCH_WILDCARD_LIMIT
45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' from line 45
45:1: F999 redefinition of unused 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' from line 45
45:1: F999 redefinition of unused 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' from line 45
45:1: F999 redefinition of unused 'CFG_LOGDIR' from line 45
45:1: F999 redefinition of unused 'CFG_WEBSEARCH_WILDCARD_LIMIT' from line 45
45:1: F401 'CFG_BIBINDEX_CHARS_PUNCTUATION' imported but unused
45:1: F401 'CFG_WEBSEARCH_VIEWRESTRCOLL_POLICY' imported but unused
45:1: F401 'CFG_WEBSEARCH_SYNONYM_KBRS' imported but unused
45:1: F401 'CFG_BIBUPLOAD_SERIALIZE_RECORD_STRUCTURE' imported but unused
45:1: F401 'CFG_WEBSEARCH_DISPLAY_NEAREST_TERMS' imported but unused
45:1: F401 'CFG_OAI_ID_FIELD' imported but unused
45:1: F401 'CFG_WEBSEARCH_FIELDS_CONVERT' imported but unused
45:1: F401 'CFG_ACCESS_CONTROL_LEVEL_ACCOUNTS' imported but unused
45:1: F401 'CFG_SITE_RECORD' imported but unused
45:1: F401 'CFG_BIBRANK_SHOW_DOWNLOAD_GRAPHS' imported but unused
45:1: F401 'CFG_INSPIRE_SITE' imported but unused
45:1: F401 'CFG_BASE_URL' imported but unused
45:1: F401 'CFG_LOGDIR' imported but unused
45:1: F401 'CFG_BIBUPLOAD_EXTERNAL_SYSNO_TAG' imported but unused
45:1: F401 'CFG_BIBSORT_ENABLED' imported but unused
45:1: F401 'CFG_WEBSEARCH_PREV_NEXT_HIT_LIMIT' imported but unused
45:1: F401 'CFG_BIBFORMAT_HIDDEN_TAGS' imported but unused
45:1: F401 'CFG_WEBSEARCH_WILDCARD_LIMIT' imported but unused
45:1: F401 'CFG_WEBSEARCH_DETAILED_META_FORMAT' imported but unused
45:1: F401 'CFG_BIBSORT_BUCKETS' imported but unused
45:1: F401 'CFG_WEBSEARCH_FULLTEXT_SNIPPETS' imported but unused
45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_EXACT_SEARCH' imported but unused
45:1: F401 'CFG_WEBSEARCH_IDXPAIRS_FIELDS' imported but unused
45:1: E402 module level import not at top of file
46:6: E126 continuation line over-indented for hanging indent
80:1: F401 'get_most_popular_field_values' imported but unused
80:1: E402 module level import not at top of file
81:1: I101 Imported names are in the wrong order. Should be InvenioWebSearchCitedbyLimitError, InvenioWebSearchReferstoLimitError, InvenioWebSearchUnknownCollectionError, InvenioWebSearchWildcardLimitError
81:1: I100 Imports statements are in the wrong order. from invenio_search.errors should be before from invenio_search.utils
81:1: F401 'InvenioWebSearchUnknownCollectionError' imported but unused
81:1: F401 'InvenioWebSearchReferstoLimitError' imported but unused
81:1: F401 'InvenioWebSearchCitedbyLimitError' imported but unused
81:1: F401 'InvenioWebSearchWildcardLimitError' imported but unused
81:1: E402 module level import not at top of file
82:6: E126 continuation line over-indented for hanging indent
86:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio_search.errors
86:1: F401 'get_fieldvalues_alephseq_like' imported but unused
86:1: E402 module level import not at top of file
88:1: E402 module level import not at top of file
89:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from .utils
89:1: I201 Missing newline before sections or imports.
89:1: F401 'record_xml_output' imported but unused
89:1: F401 'create_record' imported but unused
89:1: E402 module level import not at top of file
90:1: F401 'DataCacher' imported but unused
90:1: E402 module level import not at top of file
91:1: I201 Missing newline before sections or imports.
91:1: E402 module level import not at top of file
92:1: I101 Imported names are in the wrong order. Should be CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS, CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS, VIEWRESTRCOLL
92:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
92:1: F401 'CFG_ACC_GRANT_AUTHOR_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
92:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_USERIDS_IN_TAGS' imported but unused
92:1: F401 'CFG_ACC_GRANT_VIEWER_RIGHTS_TO_EMAILS_IN_TAGS' imported but unused
92:1: E402 module level import not at top of file
98:1: I100 Imports statements are in the wrong order. from intbitset should be before from invenio_access.local_config
98:1: F401 'intbitset' imported but unused
98:1: E402 module level import not at top of file
99:1: I201 Missing newline before sections or imports.
99:1: F401 'InvenioDbQueryWildcardLimitError' imported but unused
99:1: E402 module level import not at top of file
100:1: F401 'deserialize_via_marshal' imported but unused
100:1: E402 module level import not at top of file
101:1: I201 Missing newline before sections or imports.
101:1: F401 'acc_authorize_action' imported but unused
101:1: E402 module level import not at top of file
102:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio_access.engine
102:1: I201 Missing newline before sections or imports.
102:1: F401 'register_exception' imported but unused
102:1: E402 module level import not at top of file
103:1: I101 Imported names are in the wrong order. Should be encode_for_xml, strip_accents, wash_for_utf8
103:1: F401 'encode_for_xml' imported but unused
103:1: F401 'wash_for_utf8' imported but unused
103:1: F401 'strip_accents' imported but unused
103:1: E402 module level import not at top of file
104:1: I100 Imports statements are in the wrong order. from invenio.legacy should be before from invenio.utils.text
104:1: F401 'bibrecord' imported but unused
104:1: E402 module level import not at top of file
106:1: I101 Imported names are in the wrong order. Should be get_table_update_time, run_sql, run_sql_with_limit, wash_table_column_name
106:1: F401 'wash_table_column_name' imported but unused
106:1: F401 'get_table_update_time' imported but unused
106:1: F401 'run_sql_with_limit' imported but unused
106:1: E402 module level import not at top of file
108:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid
108:1: F401 'collect_user_info' imported but unused
108:1: E402 module level import not at top of file
109:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.legacy.webuser
109:1: E402 module level import not at top of file
111:1: F401 'apache' imported but unused
111:1: E402 module level import not at top of file
113:1: F401 'DatabaseError' imported but unused
113:1: E402 module level import not at top of file
118:22: E203 whitespace before ':'
118:14: E225 missing whitespace around operator
119:24: E203 whitespace before ':'
120:24: E203 whitespace before ':'
121:28: E203 whitespace before ':'
122:30: E203 whitespace before ':'
123:24: E203 whitespace before ':'
124:23: E203 whitespace before ':'
125:29: E203 whitespace before ':'
126:26: E203 whitespace before ':'
127:33: E203 whitespace before ':'
128:30: E203 whitespace before ':'
129:30: E203 whitespace before ':'
130:30: E203 whitespace before ':'
131:30: E203 whitespace before ':'
132:30: E203 whitespace before ':'
133:30: E203 whitespace before ':'
134:41: E703 statement ends with a semicolon
136:1: I100 Imports statements are in the wrong order. from invenio_collections.cache should be before from sqlalchemy.exc
136:1: F401 'collection_restricted_p' imported but unused
136:1: E402 module level import not at top of file
137:1: F401 'restricted_collection_cache' imported but unused
137:1: E402 module level import not at top of file
138:1: I201 Missing newline before sections or imports.
138:1: F401 'get_permitted_restricted_collections' imported but unused
138:1: E402 module level import not at top of file
141:1: I100 Imports statements are in the wrong order. from invenio_records.access should be before from invenio_search.utils
141:1: F401 'check_user_can_view_record' imported but unused
141:1: E402 module level import not at top of file
143:1: I100 Imports statements are in the wrong order. from invenio_collections.cache should be before from invenio_records.access
143:1: F401 'get_coll_i18nname' imported but unused
143:1: E402 module level import not at top of file
144:1: I201 Missing newline before sections or imports.
144:1: F401 'get_field_i18nname' imported but unused
144:1: E402 module level import not at top of file
147: D401 First line should be in imperative mood ('Create', not 'Creates')
147: D400 First line should end with a period (not 'n')
147: D205 1 blank line required between summary line and description (found 0)
154:1: F403 'from invenio_search.washers import *' used; unable to detect undefined names
154:1: E402 module level import not at top of file
157: D401 First line should be in imperative mood ('Return', not 'Returns')
157: D300 Use """triple double quotes""" (found '-quotes)
178:1: I100 Imports statements are in the wrong order. from invenio_collections.cache should be before from invenio_search.washers
178:1: F401 'get_collection_allchildren' imported but unused
178:1: E402 module level import not at top of file
181: D400 First line should end with a period (not 'o')
181: D205 1 blank line required between summary line and description (found 0)
181: D208 Docstring is over-indented
223: D209 Multi-line docstring closing quotes should be on a separate line
223: D400 First line should end with a period (not 'y')
223: D205 1 blank line required between summary line and description (found 0)
223: D208 Docstring is over-indented
236:38: E203 whitespace before ','
267:1: E302 expected 2 blank lines, found 0
267: D209 Multi-line docstring closing quotes should be on a separate line
267: D400 First line should end with a period (not 'g')
267: D205 1 blank line required between summary line and description (found 0)
267: D208 Docstring is over-indented
296: D209 Multi-line docstring closing quotes should be on a separate line
296: D205 1 blank line required between summary line and description (found 0)
309:1: E303 too many blank lines (3)
309: D103 Missing docstring in public function
319: D401 First line should be in imperative mood ('calculate', not 'calculates')
319: D209 Multi-line docstring closing quotes should be on a separate line
319: D202 No blank lines allowed after function docstring (found 1)
319: D400 First line should end with a period (not 'e')
319: D205 1 blank line required between summary line and description (found 0)
330:20: E261 at least two spaces before inline comment
334:17: E261 at least two spaces before inline comment
361:1: E302 expected 2 blank lines, found 1
379: D210 No whitespaces allowed surrounding docstring text
379: D400 First line should end with a period (not 'n')
385:25: E261 at least two spaces before inline comment
386:13: E222 multiple spaces after operator
409:10: E261 at least two spaces before inline comment
426:1: E266 too many leading '#' for block comment
428: D103 Missing docstring in public function
429:25: E128 continuation line under-indented for visual indent
430:25: E128 continuation line under-indented for visual indent
431:25: E128 continuation line under-indented for visual indent
432:25: E128 continuation line under-indented for visual indent
449: D401 First line should be in imperative mood ('Set', not 'Sets')
449: D202 No blank lines allowed after function docstring (found 1)
449: D400 First line should end with a period (not 'l')
449: D200 One-line docstring should fit on one line with quotes (found 3)
450:23: E128 continuation line under-indented for visual indent
451:23: E128 continuation line under-indented for visual indent
452:23: E128 continuation line under-indented for visual indent
453:23: E128 continuation line under-indented for visual indent
454:23: E128 continuation line under-indented for visual indent
492:9: B901 blind except: statement


1: M100 needs more reviewers
1: M101 signature is missing
1: M110 missing component name


1: D100 Missing docstring in public module
21:1: I100 Imports statements are in the wrong order. import shutil should be before import time
25:1: I101 Imported names are in the wrong order. Should be CFG_ACCESS_CONTROL_LEVEL_SITE, CFG_INSPIRE_SITE, CFG_SITE_LANG, CFG_SITE_RECORD, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_TMPSHAREDDIR, CFG_WEBSUBMIT_STORAGEDIR
25:1: I100 Imports statements are in the wrong order. from invenio.config should be before from six
26:6: E126 continuation line over-indented for hanging indent
35:6: E126 continuation line over-indented for hanging indent
39:1: I201 Missing newline before sections or imports.
41:1: I100 Imports statements are in the wrong order. from invenio_access.engine should be before from invenio_access.mailcookie
42:1: I100 Imports statements are in the wrong order. from invenio_access.control should be before from invenio_access.engine
43:1: I201 Missing newline before sections or imports.
44:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibrecord should be before from invenio_records.api
44:1: I201 Missing newline before sections or imports.
47:1: I101 Imported names are in the wrong order. Should be collect_user_info, getUid, isGuestUser, isUserSuperAdmin, page_not_authorized
48:29: E126 continuation line over-indented for hanging indent
49:1: I101 Imported names are in the wrong order. Should be WebInterfaceDirectory, wash_urlargd
49:1: I100 Imports statements are in the wrong order. from invenio.ext.legacy.handler should be before from invenio.legacy.webuser
51:1: I100 Imports statements are in the wrong order. from invenio.base.i18n should be before from invenio.utils.url
52:1: I101 Imported names are in the wrong order. Should be check_user_can_view_record, guess_primary_collection_of_a_record, record_exists
53:6: E126 continuation line over-indented for hanging indent
56:1: I101 Imported names are in the wrong order. Should be BibDoc, BibRecDocs, InvenioBibDocFileError, file_strip_ext, get_subformat_from_format, normalize_format, stream_restricted_icon
56:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.api should be before from invenio_records.access
56:1: I201 Missing newline before sections or imports.
59:1: I100 Imports statements are in the wrong order. from invenio.ext.logging should be before from invenio.legacy.bibdocfile.api
64:1: I101 Imported names are in the wrong order. Should be create_file_upload_interface, get_upload_file_interface_css, get_upload_file_interface_javascript, move_uploaded_files_to_storage
64:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibdocfile.managedocfiles should be before import invenio.legacy.template
64:1: E402 module level import not at top of file
65:6: E126 continuation line over-indented for hanging indent
71: D101 Missing docstring in public class
73: D102 Missing docstring in public method
109:90: E203 whitespace before ':'
111:29: E127 continuation line over-indented for visual indent
111:94: E502 the backslash is redundant between brackets
111:75: E203 whitespace before ':'
111:91: E203 whitespace before ':'
115:56: E502 the backslash is redundant between brackets
116:45: E127 continuation line over-indented for visual indent
116:49: E251 unexpected spaces around keyword / parameter equals
116:51: E251 unexpected spaces around keyword / parameter equals
145:17: E266 too many leading '#' for block comment
146:17: E266 too many leading '#' for block comment
164:13: E266 too many leading '#' for block comment
186:37: E266 too many leading '#' for block comment
187:37: E266 too many leading '#' for block comment
190:45: E128 continuation line under-indented for visual indent
197:107: E203 whitespace before ':'
199:37: E122 continuation line missing indentation or outdented
199:102: E502 the backslash is redundant between brackets
199:83: E203 whitespace before ':'
199:99: E203 whitespace before ':'
200:41: E128 continuation line under-indented for visual indent
234: D400 First line should end with a period (not 't')
234: D205 1 blank line required between summary line and description (found 0)
234: D208 Docstring is over-indented
246:1: E302 expected 2 blank lines, found 1
246: D210 No whitespaces allowed surrounding docstring text
246: D202 No blank lines allowed after function docstring (found 1)
246: D400 First line should end with a period (not 's')
255:13: E203 whitespace before ':'
262:13: E266 too many leading '#' for block comment
274:17: E266 too many leading '#' for block comment
289: D101 Missing docstring in public class
293: D400 First line should end with a period (not 'd')
293: D200 One-line docstring should fit on one line with quotes (found 3)
314:22: E126 continuation line over-indented for hanging indent
314:50: E203 whitespace before ':'
315:55: E203 whitespace before ':'
325:9: E122 continuation line missing indentation or outdented
377:50: E502 the backslash is redundant between brackets
397:5: E128 continuation line under-indented for visual indent
405:26: E251 unexpected spaces around keyword / parameter equals
405:28: E251 unexpected spaces around keyword / parameter equals
408:111: E502 the backslash is redundant between brackets
408:34: E251 unexpected spaces around keyword / parameter equals
408:36: E251 unexpected spaces around keyword / parameter equals
409:37: E127 continuation line over-indented for visual indent
410:25: E251 unexpected spaces around keyword / parameter equals
410:27: E251 unexpected spaces around keyword / parameter equals
411:24: E251 unexpected spaces around keyword / parameter equals
411:26: E251 unexpected spaces around keyword / parameter equals
416: D202 No blank lines allowed after function docstring (found 1)
416: D400 First line should end with a period (not 'e')
416: D300 Use """triple double quotes""" (found '-quotes)
431:16: E127 continuation line over-indented for visual indent
435:35: E128 continuation line under-indented for visual indent
436:35: E128 continuation line under-indented for visual indent
446:13: B901 blind except: statement
452:13: B901 blind except: statement
457:17: E128 continuation line under-indented for visual indent
458:17: E128 continuation line under-indented for visual indent
459:17: E128 continuation line under-indented for visual indent


4: L102 copyright year is outdated, expected 2015 but got 2014
27:1: E302 expected 2 blank lines, found 1
27: D103 Missing docstring in public function


Umm... okeo, thanks for the heads up. :)


> But I do not really consider the supported ruby version API.

I think you should reconsider this: Rubygems does not seem to be able to deal with this on its own and will try to install a non-compatible version even though an earlier, compatible version is available.

> Chances you could simply go with the 0.2.4 release?

If necessary, yes. Some people may experience upgrade problems though.


But "_attribute" is not in the array of elements that gets checked in the line 1109, isn't it?
Only "_aggregate", "_constraints", "_link", "_service", "_patchinfo" and "_channel" are checked there.

Adrian said that the _attribute file shouldn't be updated via save_file,... , never.


:+1:  Lycka till kamrat


I'm considering to yank the `0.2.5` release and go for `0.3.0` without ruby < 2.1 than.


![photo 1275272_10101026493146301_791186452_o](https://cloud.githubusercontent.com/assets/8430762/9761764/5c42d46e-571c-11e5-9acb-7bf23c5aa182.jpg)


They are not autoapprovrd.

Please test yourself, don't look at mines

n't loWednesday, September 9, 2015, ajithcj <notifications@github.com>
wrote:

> Marco, I see that the FF tests are getting auto-approved. If so, I hope
> you intend to fix it. Else it is an easy target for a troll.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mcostalba/Stockfish/commit/0157fd7cc255dc8601a0967edfa0db325ba25be4#commitcomment-13131289>
> .
>


thanks a lot, maybe someone at Nordic has an idea.


you are using "Random" here vs "random" before.


Thanks for this pr.
You should be the only author of the documentation that you've written independently (I think that includes all of the *.rst files in this commit).


OurMedia
OurMediaMaster
OurMediaReformer
OurUniverseReformer
OurReformer


@jgriffiths Sry, yes will hold of refactoring commits.


vcvcv


You're welcome :) Also, remove globalentity registration from mobs category.


@yjun2 DWMR. Perhaps sending events to GA when the app disconnects unexpectedly would help surface if there is a small or significant issue with the multi-peer framework.


#our


This looks like binary_try to me, binary_search threw me off since I thought it'd return the optimal callee_max_width and then we could call rewrite_call_inner with that value.


soory


g方法


It just happened to come in on the same commit. I sign each release and you
can use that key to verify.

On Wednesday, September 9, 2015, Scott Markwell <notifications@github.com>
wrote:

> Why was your public PGP/GPG key committed to fix this issue?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/couchbase/couchbase-lite-net/commit/6d7b1627b1ed072a23ab2c7a3a0e3c9006915464#commitcomment-13125037>
> .
>


Shall we backport to 15.09?


Unused


That would be great.


Yes, please send a pull request!


Cool. Also, googling around for the appropriate content-type for different formats, I came across a page suggesting the following, which seems reasnable to me:
Format	Symbol	Mime Type	File Extension
GPX Track	:gpx_track	application/gpx+xml	.gpx
Garmin TCX	:tcx	application/vnd.garmin.tcx+xml	.tcx
ANT+ FIT	:fit	application/vnd.ant.fit	.fit
https://github.com/adambird/broutes

I guess pwx would be something like application/vnd.trainingpeaks.pwx?


Too many spaces? We don't use this kind of aligning anywhere else in this file.


Could you open an issue for your problem? It allows better tracking of problems. Also, I'm not sure what 'time is wrong' means. Could you provide more details? (expected results and actual results, etc.)


@poettering , the option `--fail` will break all my scripts:)

Well, I read the section [Return value](http://www.freedesktop.org/software/systemd/man/sd_notify.html#Return%20Value)

> In order to support both, init systems that implement this scheme and those which do not, it is generally recommended to ignore the return value of this call.

I agree. This option makes sense for init systems that implement `notify` scheme.


Any particular reason for this? Wouldn't using a variable seed probably exercise more parts of our framework in the long term?


I don't think its worth another signature, unless you want to try and propagate that to other libraries as well, like [node's assert](https://nodejs.org/api/assert.html). A check in jshint or eslint might make sense, if its possible to reliably detect this issue.


It has been released today :smile:


TIL how the `===` operator work...


fixed.


https://hypernews.cern.ch/HyperNews/CMS/get/dmDevelopment/1661/1/1.html
As an early example, here LumiList is goes with SplittingAlgo. If you ask me if computing requires this field, unfortunately I don't know


java class path ignore


maxResultSize?


Yep. Its pretty simple to get the timestamp from show.airdate btw.


@rogersb11 can you give us hint ? is it your commit or not . if yes we can fix authorship.


type 不用

新增 price 欄位

price: DataTypes.FLOAT

參考畫面

<img width="596" alt="screen shot 2015-09-09 at 8 39 42 pm" src="https://cloud.githubusercontent.com/assets/1689227/9761995/f495b310-5732-11e5-89c6-8d3e8e46cb89.png">

所以兩個測試資料一個有  discount 一個有 price


as mentioned here https://www.playframework.com/documentation/2.4.x/Migration24
you also should include specs2 dependency or remove tests that are using specs.


Hey. Is this the official API for mpesa?


I updated both documents (and even put the notes about the database backend changes in the corresponding commit).


#5048-HVAC-Sizing-Summary-Thermostat-Setpoint-Temperature-at-Peak-Load-=-0-for-ThermostatSetpointDualSetpoint (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1308 of 1308 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.16%25-green.svg)


We have it among our dev dependencies, I can't see why we need to install it twice :)

https://github.com/Financial-Times/email-users-kafka-consumer/blob/master/package.json


fixed


@evverx how would it break them? I mean, the tool would work exactly as before, except when you specify --fail, in which case it would fail if $NOTIFY_SOCKET is not set.


@jzaefferer I guess the only thing which can be reliably checked for via a lint tool is that the "actual"-value isnt passed as a constant. the "expected" value is most of the time a constant, but sometimes also expression are used.


Do you need the var assignment here?


@miigotu all I need is a ISO timestamp like this `2015-09-09T12:42:57.333Z`.


Slightly uncomfortable that we modify the migrated store files after moving them into the store directory, but then again, so did the `ensureStoreVersion` method.


@mfonville , Could we (you) add a reliable check (in inc.sourceshelper.sh) to notify if our opengapps/opengapps repo is not up-to-date with the origin/master?


> I meant we should have a utility function which appends any param to a URL, since there are several places in our code where we could use it.

Ahhh, makes sense, I'll change that.


I think the info messages when not using deeplocalizer are unnecessary. Apart from that: Looks good to me!


I don't like to repeat myself. The 44 has to be omitted as I told already, because the driver will insert it. Just look into the implementation of cec_usrcmd_device_menu_control() that my patch is calling.

Gerald


What if we could specify sth like `required_role` in the `IndicoBlueprint` just like in case of `EventFeatures`?


My server is having a huge issue with factions how can we talk about it? (GIANT bug)


zhe shi zen me hui shi


Geef aan welke concrete dingen het zijn


do you really need this check now? it looks like you are going to have prop no matter what?


In many cases the blueprint also contains non-management endpoints.


Javadocs describing what this returns would be nice.


The current behaviour:
```
$ env -i systemd-notify --ready
$ echo $?
1
```

The new behaviour:
```
$ env -i systemd-notify --ready
$ echo $?
0
```


Gebruik 1.8.0-alpha3


It would if these changes could be squashed into the commits that originally made them.


I just read a news about this this morning.... and bim, 1 commit.

You may need `install_require` for aiohttp in `setup.py`


So, we took this out a while back because it causes 10 lines of annoying, useless red output in FD every time I code complete. Is it necessary?

I'm on my phone, but it's something like "can't do X, possible typing order mismatch" or whatever. Right now, I get the same output from GenericStack<T> because hscript uses it and I use hscript.


@sjackman This method now is OS X only. You may want to change it to:
```ruby
def describe_java
  if OS.linux?
    return "N/A" if which("java").nil?
    java = `java -version 2>&1`.lines.first.chomp
    return java =~ /java version "(.+?)"/ ? $1 : java
  end
  ...
end


You are right I remove that info message.


Ok, misunderstood. I guess I was expecting to return -1 (that is an error), if we don't know, rather than return "(uncached) false" -- not-needed.


Please note Windows users #168 and #170 are still crashing on you in Windows.
My Windows compiler is on strike and as a result I cannot update the Windows version.
As soon as it gives up its strike I will update the Windows version as well.
Sorry for the inconvienience.


can improve the dependencies of gradle :dancer:
https://services.gradle.org/distributions


lets say value of episode.airdate is 735143:

```python
>>>import datetime
>>> datetime.datetime.fromtimestamp(735143).isoformat()
'1970-01-09T04:12:23'
```

The format can be customized as well.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20319/testReport/) for this commit**


This closes #13


Не следует допускать Magic numbers в коде.


Failed to instantiate [ch.qos.logback.classic.LoggerContext] thiss issue will be coming to me when i tried
to establish a hibernate connectivity


See https://github.com/HaxeFoundation/hxnodejs/issues/42


fixed


:smile:


I made a direct link to the corresponding section.


this is no longer accurate, start time is `now()`


Не хватает теста, проверяющего что задача со статусом In progress не может перейти в Open


The final problem is related to `self.idx.arr` not always being a `c_void_p`, but for some reason reverting to `int`.
I have a version that runs with a "manual desctructor". I'll see if can come up with a nicer solution.


No, the comment is confusing. It is trying to say that we shouldn't call flush otherwise we rotate the counts store. I'll rewrite this and the other comment below to explain this in a better way.


Sentences should be separated with a dot.


@gandm, thanks for being flexible. On the issue, I seem to get repeated calls to the same scope:

<img width="1057" alt="variable scope" src="https://cloud.githubusercontent.com/assets/8850708/9762199/3fb556f6-5702-11e5-9196-2454a162809c.png">

I saw that you also made some changes from storage to variable, don't know if that might be the issue.


i think @captain-sysadmin needs to add `node_modules/.bin` to the $PATH and then it'll just work™


This should be renamed to CacheLoadDataStage or similar.


[without either]


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20320/testReport/) for this commit**


hmm well it doesn't seem to be breaking my code. I'm using unsigned ints
for calculating the cycle length which is probably why. Is this not what we
are supposed to do? I've seen some posts from Lane where he used them so I
just assumed..

On Tue, Sep 8, 2015 at 9:33 PM, Nick <notifications@github.com> wrote:

> 737961 is in the list of overflow numbers
> https://piazza.com/class/idgl07a8yrx5m6?cid=123
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cs371p-fall-2015/collatz-tests/commit/bc08edbb0adb6893ea4a37fcc19f2dad6359bb25#commitcomment-13126481>
> .
>


It's quite necessary, IMHO.

Without it, the C++ code generates this:
```cpp
Void FlxPool_obj::putUnsafe( Dynamic obj){
{
		bool tmp = (obj != null());
		if ((tmp)){
			obj->__Field(HX_HCSTRING("destroy","\xfa","\x2c","\x86","\x24"), hx::paccDynamic )();
			Dynamic tmp1 = this->_pool;
			int tmp2 = (this->_count)++;
			Dynamic tmp3 = obj;
			hx::IndexRef((tmp1).mPtr,tmp2) = tmp3;
		}
	}
return null();
}
```

I count at least 3 Dynamic casts, for a class whose entire purpose is to minimize the impact of GC :P

These Dynamics increase the GC cost, and slow the whole operation down, and FlxPoint allocations and puts are used *everywhere*.


Right, #170 and #168 are now fixed in Windows as well. #169 was only an asset bug and thus its fix affects both versions without recompilation ;)


Oh NO, I missed Rails API.


Might have to look into this a little more but we need a RFC 3339 timestamp like [this](https://stackoverflow.com/questions/8556398/generate-rfc-3339-timestamp-in-python).


@gcb, am I misunderstanding or does this commit mean that I can set environment variables in my npm scripts without worrying about the platform? Currently, in several of my scripts, I'll set environment variables like so:

```javascript
{
  "build:dev": "NODE_ENV=development webpack",
  "build:prod": "NODE_ENV=production webpack"
}
```

@benoror created [better-npm-run](https://github.com/benoror/better-npm-run) which attempts to overcome the cross-platform issues. But if it's now supported by npm, I'd love to use this. Am I misunderstanding?


Thanks.

My confusion came from the comment:

 "omit the sender address"

where I now understand I am to omit the 44 code ( Used to indicate that the user pressed a remote control button) but retain the sender/receive "10" (recording device1 to TV)

It now makes sense as the design of the driver is to mimic a remote control.

In my tests the 44 does not work with all TVs so I prefer to use the raw codes such as 10:36 (standby) but that is purely my preference but now I understand the design of your driver...thank you


thanks!


Yes. --no-check-certificate is setting context.check_hostname=False.

Question is should that instead set context.verify_mode to something else
that defeats the actual certificate validation, and add an option
--no-check-hostname that just disabled hostname checking.
On Sep 9, 2015 7:24 AM, "Bret Curtis" <notifications@github.com> wrote:

> Example:
>
> import socket, ssl
>
> context = ssl.SSLContext(ssl.PROTOCOL_TLSv1)
> context.verify_mode = ssl.CERT_REQUIRED  # validation required
> context.check_hostname = False  # hostname validate off
> context.load_default_certs()
>
> s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
> ssl_sock = context.wrap_socket(s, server_hostname='www.verisign.com')
> ssl_sock.connect(('www.verisign.com', 443))```
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/s3tools/s3cmd/commit/6da1585975882027c8bbbf297c573765c6cd6a2f#commitcomment-13134520>
> .
>


I merged the two options and removed the documentation of `--parallel-num`.


done


@meji46 after or before running this query?


设计这个的时候,  我的确没有考虑到 服务端渲染,

当时只是为了记录用户的习惯.   `RGB/HSB/HSV`  为了多形式表示一个 hex 色值,


**ERRATA**

O certo desse commit é fechar a issue #252


this `custom_field_14_chosen` is specific to your installation, does not belong to eventum core repository


Done


The problem is that we need to modify also files that we didn't copy from `migrationDir`. I am unsure if it make sense copy all those files into `migrationDir` remove the trailer and move them back into `storeDir`.


nevermind, seems you fixed it in 0a29e01f61023f6fb3a0571c2ebf7c7a0c446d85


@poettering ,

current behaviour:
```
$ env -i systemd-notify --ready
$ echo $?
1
```

new behaviour:
```
$ env -i systemd-notify --ready
$ echo $?
0
```


Please `` room_id :)


I don't think it is the only place where reference to `field.values` is used.


Ok I will try it. Big thanks. This is hard :)


Nice, i see you got some things working :D keep it up!


So lets force-use AOSP RIL ;)


After this change the seeds file is now broken (still uses `name` on items).


lol


then we need to move the lock.Unlock() right after completion_ret returns otherwise the lock.Lock() that follows should fail ? Unless calling lock.Lock() multiple times is just confusing but not actually harmless. What do you think ?


Use `//` comments everywhere


Вот так верно будет?
```
public static final String PERSON = "/person/{id}";
```


Could be normal. Each descent into a brace, paren or array bracket will fo this but should unravel at the end. e.g. { { { ( ( ( will have three mentions of curly brtace and parens ) ) ) } } } but none here.


My thought was that it's odd to see a commit that adds an unused, untested, undocumented class.


Uhhh, please, do not do this. It may be safe in practice with current code, because sym.add() internally copies the string, but from the external perspective this looks awful. One of the calls to sym_find_or_add() function passes local char array there, and unless you investigate how symbol table works, it will look like a terrible mistake.

I suggest fixing symbolTable class instead and add "const" modifiers to string parameters where required.

E: I tried a quick fix, and it looks like it won't be too difficult to do, except it will require adding "const" in additional number of places. But logically these strings should have been const, so it does not break anything.


Can you tell me little more, why we introduceed such change?
I really like foreach() that look like statement. I had been compiled BibleTime backend on many odd compilers and platrorms and did not ever encountered with any problem from it.


e83c5163316f89bfbde7d9ab23ca2e25604af290 the sha that began it all...


Legend!


Done


My example just didnt have any seconds, you can append the Z, and using network_timezones we can even adjust by network time vs local time.


const QVector3D& eye() const ! Pour eviter la copie !


Même chose!


Alright, that sounds good then.


Hola Gus!

Es verdad. Incluso creo que hay unos issues creados para tal fin. Creo que
el adecuado es el   "Implmenent POSIX driver in CIAA-FSL for ADC #236"

En los próximos commits voy a incluir una referencia a dicho issue.

Saludos!

Ale.

El 9 de septiembre de 2015, 8:37, Gustavo Muro <notifications@github.com>
escribió:

> Hola Ale.
> Estaba viendo los commits que estás haciendo sobre este branch y estaría
> bueno que crees algunas issues para que luego se haga más fácil el
> seguimiento. ¿Qué te parece?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ciaa/Firmware/commit/9e311c6e06e28e21b86eb99f9a95ec1960f1fa57#commitcomment-13133738>
> .
>

--
Ing. Alejandro Permingeat
Ingeniero en Informática


it would be great to have there a possibility to change default delimiter character on CLI.


IMO you should write "4", not "4.0.0". Current setup will mean you won't test on future updates to the v4 line. Those updates are not allowed to introduce breaking changes and only the newest one is officially supported.

In the same way, you don't write "0.10.0" or "0.12.0" but "0.10" & "0.12" so it catches latest updates.


This should be changed to `iojs-3` to catch latest updates to the v3 line or dropped.


SetEyePosition except parameter. should be rename to : initEyePosition()


@okal this test serves right.


u no beetch me is beetch


I think this was mis-leading


can current_fs be 0? if it can be 0 there should be some log or error on 0?


How can this idea be tested ?

Currently, features that relates pawns and pieces are in evaluate.cpp
You may precompute your feature in Pawns:: evaluate() (such as passed_pawns,
or open files...) and use it later.

Other remarks:
opposed here just means "a pawn in front along the column", not necessarily blocking.
So your code is considering "opposed" if a piece on the 8th rank too,

Also, I did not check thoroughly, but I think the pawn hash key is not erased after each game.
(Pawns::init() is called only once)


hound, take this: 76bdd5e6e30a4200938d3bb03a3857192ad3cd1a


@rmg +1 - Changing `package.json` to 3.0.11 is throwing this error on `npm install`:

`npm ERR! version not found: sqlite3@3.0.11`


For a 6.0 release (which I think master is currently targetting?), should we instead remove this search_params_logic on the controller entirely, remove the feature where it can be anything but `true`, and just always pass `true` to the SearchBuilder, requiring people to configure on SearchBuilder as intended?


yesh


*Name*, *Email* and *Birthday* fields should be wrapped inside a ``label`` tag.
It's a requirement to build semantic forms and will improve not only accessibility for screen readers (by correctly associating a caption to a form field) but also navigation (by accessing the input clicking on the label, for example). You can check further info about ``label`` [here](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/label).


Да.


What happens if the used browser do not support mp4 video format? Should we add some other video format?


Same here with the audio file format


@jimeh Perfect.


It was #1430, I'll check what the deal is with the haxe commit since it seems like it was closed a while ago. I'm also on a random dev haxe (where multiple @:build work and macro + struct issues are resolved) if you don't get this.


Yes, that was the goal.


Avoid using ``<br />`` tags to add line breaks, all spacing will be handled by CSS.


I cannot completely get rid of the passing group to a function, while I want to have same template for making names and making regexes, but I've got your concern and refactored specific case into hopefully clearer function, and dropped makeRunFilenameRegex


From my understanding, the turn flag is not fixed based on the processor right?

Here I have used the turn flag based on the previous implementation but I think we can use the processor instance `procInstance_p` as the turn variable as following:

````C
    DUALPROCSHM_INVALIDATE_DCACHE_RANGE(pLock, sizeof(tDualprocLock));

    DPSHM_WRITE8(&pLock->flag[procInstance_p], 1);
    DUALPROCSHM_FLUSH_DCACHE_RANGE(&pLock->flag[procInstance_p],
                                   sizeof(pLock->flag[procInstance_p]));

    DPSHM_WRITE8(&pLock->turn, procInstance_p);
    DUALPROCSHM_FLUSH_DCACHE_RANGE(&pLock->turn, sizeof(pLock->turn));

    DPSHM_DMB();

    do
    {
        DUALPROCSHM_INVALIDATE_DCACHE_RANGE(pLock, sizeof(tDualprocLock));
    } while (DPSHM_READ8(&pLock->flag[procInstance_p]) && (DPSHM_READ8(&pLock->turn) == procInstance_p));
````

Please let me know if it is possible


I should have caught this the first time around, but why aren't we using the same pattern as in `.track` here? ie. https://github.com/segment-integrations/analytics.js-integration-mixpanel/blob/9bdcd5723aa981ad07c4eca3ed0862d36be2d820/lib/index.js#L177


Is it possible, that `tryFindDaemon` returns not null `service`, but `checkCompilerId` returns `false`?


For this exercise it's OK but the table border should be handled using css classes not inline attributes or inline styles.


This causes problems for Spring Cloud Data Flow (where they have a custom class loader based on this one - which seems reasonable to me). Can we revert this bit?


We use it in OpenShift.  We used it in pods previously but removed it.  Please don't remove it.  :)


Ah. nice!


**Mega-minor:** maybe this should be *"Mobile"* (remember to *almost* always write in English :P).


Missing space before `<`.


Well, everything can be 0. Not sure what that would mean here actually. @ogoffart ?


There are no other versions between 3.1.0 and 4.0.3?


I already do that here

https://github.com/SpongePowered/Sponge/blob/master/src/main/java/org/spongepowered/mod/mixin/core/fml/common/eventhandler/MixinEventBus.java#L55


Hm.... I guess it would be better to check if loglevel presents in config and if yes set the log level the given value otherwise set it to info. Put the whole part in a try catch struct. If the level is invalid catch the exception and tell the user. Invalid loglevel


Sure (it was my suspicion that you added it because of OpenShift).


Yoo


If the key is not modified, the EXEC command still returns a empty list which is equal to null in condition clause. Hence, L172 is always got executed. Is this right?


This should be handled by CLI, not the logger. Thoughts?


Same here


I think I need to fix this one commit, because there'll be two lock.Lock() in same thread without lock.Unlock() in between.


Да, нехорошо выходит, спасибо что объяснил. Думаю, вообще не стоит кидать собственные исключения - хотел сделать более user friendly, но не имеет смысла. При возникновении любых исключений они итак будут отображаться, пусть и только на английском.


make A 3D


do not use all capital letters for methods (why not naming this: clearAllDatasetValues() ?)


Fixed! See https://github.com/relaciones-internacionales-journal/ojs/commit/103e99c2e80b83381cccf8de5e7869de28eda14e


Done! https://github.com/relaciones-internacionales-journal/ojs/commit/103e99c2e80b83381cccf8de5e7869de28eda14e


Is there a reason why the fix was not applied to lib/ransack_ui/adapters/active_record/base.rb ?


Well this shouldn't be committed, but let's have it online now.


@mxRazumov thanks!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20327/testReport/) for this commit**


You can use ``thead`` and ``tbody`` tags to wrap what would be the header and body for your table, in order to build a more complete markup. E.g.:

```
<table>
    <thead>
        <tr><!-- Magic!--></tr>
    </thead>
    <tbody>
        <tr><!-- More magic! --></tr>
    </tbody>
</table>
```


I have a habit of making references to these member structures final in order to avoid ever setting the reference to null, this way we always know that the reference points to a valid map object. I am aware that clearing and putAll is very expensive compared to a simple reference change. Thoughts @stefano-cliqz @kuc ?


What is that?


**Minor:** remember that ``input`` is a self-closing tag, this should be: ``<input type="date" name="birthday" id="birthday" value="" />`` (check slash before ``>``).


On this fragment, it would probably make more sense for the user to select weather or not they are a student or a teacher, then if they are a student they are asked for their name and student id and if they are a teacher they are just asked for their name. Generally its not expected for anyone besides the phone owner to be using the owners phone, so using password authentication feels strange.

This step is mainly just to establish what kind of user the user is, get the relevent identifying information from them, and present them with the proper interface.


@dschuermann Great, thanks!


@rhass You should be able to peg to the old version in your project definition:

```ruby
override :ncurses, version: '5.9-20150530'
```


Hello

I think, I have found the response of our prefix/xmlns problem:

http://upnp.org/specs/av/UPnP-av-ContentDirectory-v3-Service.pdf

Go to Chapter 1.4  (End of page 21)  It is explain !
(But they don't list  "sec" prefix, and the Freebox use this prefix without
xmlns definition !)

Regards,

2015-09-08 22:36 GMT+02:00 s-leger <notifications@github.com>:

> nope, sorry
>
> I get this from a LG screen :
> Unknown xmlns for prefix res@dlna token= res@dlna:cleartextSize
>
> Note:
> Some media urls in dlna devices are also prefixed with dlna: (HdHomerun)
> Ps3 media server adds a $ as prefix ..
>
>
> > Le 8 sept. 2015 à 14:47, Olivier Oeuillot <notifications@github.com> a
> écrit :
> >
> > Yes I known, but it was possible that you have access to it ;-P
> >
> >
> > 2015-09-08 14:44 GMT+02:00 s-leger <notifications@github.com>:
> >
> > > Uhuh, nope,
> > > DLNA spec is available for DLNA association members only,
> > > and membership caosts an arm. (aka 700+)
> > > Lame dlna !
> > >
> > >
> > > > Le 8 sept. 2015 à 11:06, Olivier Oeuillot <notifications@github.com>
> a
> > > écrit :
> > > >
> > > > Do you have DLNA spec ?
> > > >
> > > > I can not find them !
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub <
> > >
> https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13107151
> > > >.
> > >
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13111065
> >
> > > .
> > >
> > —
> > Reply to this email directly or view it on GitHub <
> https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13111126
> >.
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13121648>
> .
>


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.959.5779dc6449fb3854d3fff2d28d15319116b1f3c0](http://build.palaso.org/viewLog.html?buildId=62970&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 504, ignored: 6 Build time: 00:04:23


done https://github.com/ResurrectionRemix/android_frameworks_base/commit/cb42c31d858098763d5e5f72214649fc7635f9b6


please review the files that you want to commit, if it's checked in your client (github) then it will be added online.

Try now to remove this file


Remember to add a ``label`` for your ``select`` and ``textarea`` elements.


Jag glömde plocka bort det efter jag testat. SLÅ MIG INTE.


@craue why not dropping support for symfony 2.1 and 2.2, which are long unmaintained ? It would allow to simplify a bunch of code.


What a hell?


**Mega-minor:** scpace before tag close (should be <... ``"submit" />``). Line 22 also.


Not sure if this question is answered already, but yes: they can share the same model.

I see that a `Comment` `belongs_to` a team, an application and a user (the comment-author?). So it is perfectly possible.

I would prefer a polymorphic link instead, and I probably would not nest the controllers either (because I would assume rendering the comments for "a commentable" thing is always the same).


Generally for bug fixes please clarify in the commit message:
- What is the problem / bug description.
- How is it fixed.

Please update the commit message by minding the points!


sorry.


please remove this file too


+1

Allows us to prevent MAX_FILE_SIZE errors in `tempfile.mkstemp` due to long pseudo-file names in the url.


shouldn't we clear the cach before `is_dir` to make sure we dont get a cached result above?


Seems to me that this algorithm can run infinitely, can't it?


codec has a fast reverse function, may be we can export it


There is no actual need to return that value, reverting to `void`.


LGTM


This will be confusing as hell, because you still `require('move')`


Please use os.path.getmtime() instead.  The last modified time reflects better what we're going for


Hola, creo que me he ausentado un poco. Me pondré de nuevo al corriente para continuar con las traducciones.


`sort | uniq` → `sort -u`


`file_exists` and `is_dir` both will trigger a sys-call. why not only use `is_file` and have a constant number of syscalls for this method?


Why with upper case XmlRoot ?


we can refer codec int, use 8 for negative sign, 16 for 0, and 24 for positive sign, so if 0, we will only use one byte.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20329/testReport/) for this commit**


Yes, that's a fully valid case. Discovery is done using compiler classpath as a string, while checkCompilerId verifies whether the contents of the files are not changed.
But may be your question is a hint that something should be named more clearly. I'll think about it.


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1838 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Fallback should probably empty objet here, not empty string?


Fix this method with appropriate return value.( change from Event_Action_Code_Responder to Event_Code_Display_Responder)


Ah, that's how you did it! BTW: Do you know what the bottlenecks are specific to Foxx?


Originally it was for the way pod status was implemented.  It's definitely
less necessary today for real resources.  It's actually very valuable for
virtual resources, so we'll find more uses for it in the future.

On Wed, Sep 9, 2015 at 9:17 AM, Wojciech Tyczynski <notifications@github.com
> wrote:

> Sure (it was my suspicion that you added it because of OpenShift).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kubernetes/kubernetes/commit/23d199ded960f1be4797ab7218f17a469290a13c#commitcomment-13135823>
> .
>

--
Clayton Coleman | Lead Engineer, OpenShift


devise, 메일인증까지 완료


Is `opts->from_string` guaranteed to not be `NULL` here?


a) Please do never commit to master directly. Always use a branch and create a Pull Request.
b) You did not update changelog
c) You did not add plone.app.discussion to coredev buildouts checkout.cfg

Please also correct similar problems very soon in
- https://github.com/plone/plone.app.dexterity/commit/d0f2672c7169513a99417383d2dd569f140242d8
- https://github.com/plone/plone.app.dexterity/commit/913148a844e118a719c39df23a42aab186384b44
- https://github.com/plone/plone.app.multilingual/commit/3d8f00928847fb2a644203060c9319e6154245ce
- https://github.com/plone/plone.app.multilingual/commit/697837878332e09a0e854ede1271503979da9060
- https://github.com/plone/plone.app.versioningbehavior/commit/05e807a5303e4759ba85c8c97b8e174f4dd1cd74
- https://github.com/plone/plone.app.event/commit/740befb23a78cf7c2f257ba844eccd28033bf955

Otherwise I'll revert all this.


Oh didn't spot that. Still is a bit of a risk as the object is still constructed so as long as those fields aren't accessed in a sub-class constructor it's all good.


Got it - thanks for explanation.


각자 컴퓨터에서 작업할때는 새로 workspace만들고 run한 다음에 회원가입을 다시 해야할건데

회원가입 메일이 thisistester2@gmail.com 으로만 가니까, 가입 메일은 그렇게 지정해야함.

이 계정 비밀번호는 단톡방에 올려놓음


Сделай здесь `display: inline-block !important;` - от нижележащей правки `#de-win-reply` приаттаченную постформу распидорашивает на всю ширину вьюпорта.


Timo -
  there is a problem in 2.6 and before.  If you assign long=long  it gets confused.  Python can not tell that the LHS is a variable and the RHS is a type.
> On Sep 8, 2015, at 7:29 PM, zack-vii <notifications@github.com> wrote:
>
> Hey Josh,
> could you please comment on why you changes the basestring and long to basestring_type and long_type, respectively?
> I agree on the sys.version_info which probably should be something like
> ispy3 = sys.version_info>=(3,)
> So ispy3 can be used as switch
>
> I am digging deeper now on python3 as our IT only provides python3.3.
> cheers
> Timo
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/zack-vii/mdsplus/commit/c1d79bcf19ffecabf2fccf8e9893df7b801e3e1c#commitcomment-13124609>.
>


we can use codec encode int to reduce size.


remove the cast the byte and use 0L :)


we may move this to codec.


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I don't get why to start searching for daemon again after trying to acquire the lock?
Why not just check if lock is taken, and if it is then start daemon, otherwise consider an attempt as failed?

```kotlin
 if (fileLock == null || !fileLock.isLocked()) {
    File(daemonOptions.runFilesPath).mkdirs()
    fileLock = FileBasedLock(compilerId, daemonOptions)
    if (fileLock.isLocked()) {
         startDaemon(compilerId, daemonJVMOptions, daemonOptions, errStream)
         errStream.println("[daemon client] daemon started, trying to connect")
    }
```


I think this should be long priority rather than Long,
the thing is: setPriority(null) would be valid from the caller but on setting and unboxing I think this would cause a NPE.


Maybe the extra semi-colon should be deleted instead.


Please refer to https://en.wikipedia.org/wiki/Peterson's_algorithm (please add this link to the file's header, thx!)

Yes, you can directly use the `procInstance_p` value and write it to the `turn` field, and again check the turn field against the `procInstance_p` - the value doesn't matter (0 or 1 or ... as in the wiki example) but it needs to be unique!
However, you need to check the other's flag!!! So, the first processor checks the second's processor flag if it is TRUE.


I am not really sure what the correct behaviour for this, what do you think?


Never mind, I can see it fixed in this PR: https://github.com/Mei152/open_todo/pull/3/files#diff-f7a25bc30a409fc77050703fc048ca8cR32


Here you probably wanted `if (!mdata->sub_str)`.


You are right, I mixed it up, sorry. It is already some months ago that I did it.
The driver is not made by me! I made only the patch.

Gerald


Ditto.


Nice.


Keith -
  So you are saying we don’t have to bother defining FILENAME_H ?  If so, I am fine with remove these defines

> On Sep 8, 2015, at 5:32 PM, kgerickson <notifications@github.com> wrote:
>
> I agree. If a user was relying on those defines, that's unsupportable code.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/MDSplus/mdsplus/commit/e95b36f2c24259e77a619302486e5a810306cdf7#commitcomment-13122738>.
>


I didn't read every single line of code but it looks good.

Something that may goes wrong: if people are using addons (Metamod, AMX Mod X), it may cause conflicts.

For instance, the Desert Eagle has it's own laser (CEagleLaser, classname = "eagle_laser") in the stock Opposing Force, I don't know why Gearbox made a copy/paste/rename of the RPG's laser, but you get the idea.

I might upload my non-complete attempt to recreate BS/OpFor. I'll see when I get home.


I've added a class to keep track of the references like:

```python
class Index4(object):
    def __init__(self, idx0, idx1, idx2, idx3):
        index_vec = Index * 4
        self.array = index_vec(idx0, idx1, idx2, idx3)
        # Do not lose those idx references
        self.idxs = [idx0,idx1,idx2,idx3]
    @property
    def pointer(self):
        return ct.pointer(self.array)

    def __getitem__(self, idx):
        return self.array[idx]

    def __setitem__(self, idx, value):
        self.array[idx] = value
        self.idxs[idx] = value
```

I've added the extra c_void_p to the destructor:
```python
    def __del__(self):
        if not self.isSeq:
            arr = ct.c_void_p(self.idx.arr)
            backend.get().af_release_array(arr)
```

and then modified _get_indices():
```python
def _get_indices(key):

    S = Index(slice(None))
    inds = Index4(S,S,S,S)
```

and replaced the `ct.pointer(inds)` by the new `inds.pointer` in `array.__getitem__` and `array.__setitem__`.

I think this is a cleaner way to fix the problem.


Try to write all the code in english please, that's a requirement :)


Don't forget updating the documentation due to the changed parameter name!


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 20](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=146&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


That is what I tried to do here:
https://github.com/s3tools/s3cmd/pull/582

But as you said, it became just a rename and didn't fix anything.

IMO: verify_mode should set to ssl.CERT_REQUIRED if you set --check-certificate is called. If --no-check-certificate is used, then verify_mode should be ssl.CERT_NONE. It shouldn't be ambiguous with ssl.CERT_OPTIONAL.. either you do, or you don't.

--validate-hostname and --no-validate-hostname (or *check*) would also be parameters that can be used to set context.check_hostname

Is this doable? :)