MiscReleaseFixes (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1879 of 1880 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


raft may ask for snapshots at the same index to send to all followers, and raftStorage needs to host the KV snapshot part for these snapshots. The structure is used to find the KV snapshot when rafthttp wants it.


gan jin follow wo


and add in config translate to controls... "Android Abilite Key" and ...


I think your answer seems very logical! it makes sense to me.


sry, forgot the author during commit of this backport :S


cli-documentation-fixes (nealkruis) - x86_64-MacOS-10.9-clang: OK (1873 of 1873 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


My only "complaint" is that on some examples **.to** is written with a space, e.g.:

```ruby
expect { application.save } .to change { application.application_type }
```

and on others, like with the rest of the suite, the **.to** is written as the instance method:

```ruby
 expect(application.ni_number).to eql(expected_ni_number)
```


Yes. It is correct those two methods are back to previous commit state and should not break other audit logging services


@novotnyjakub since you'll be away for next two days. I'll be "rude" and I'll fix this before merging. Thanks


I'm trying to get reproducible results with linking, but it's not cooperating well. Sometimes I get a libpromises.so, dynamically linked to `/home/.../libjq.so`. Ideally we'd like `libjq.a` to be statically linked in libpromises. I'll let you know if I manage.


can you make the tag 1.1.7 with this fix?


Thanks!


xD xD


I think I know a good solution for this. I would suggest to remove this line and instead do one or two of the following:
* In PlayerActionsLevelModifier, within each if statement for an action, log "Player performed the ... action".
* If you want to log coordinates, I should log them in Kinetics Level Modifier, at the end of the updatePlayer method.


Sorry ...


@eaquigley and @posixeleni it seems like we wanted a link here so I went ahead and added it. You can see the difference in the HTML if you compare these:

- http://guides.dataverse.org/en/4.1/user/find-use-data.html#explore-data
- http://guides.dataverse.org/en/4.2/user/find-use-data.html#explore-data


wot
not me
@TheStrix made the device maintainers commit :v


me is jobless enough to copy paste xD


Just for the sake of completeness, I'm thinking that we should make it possible to also link to the system's jq, if it is there. For example:

* ```./configure``` uses the jq that we ship.
* ```./configure --with-jq=/usr``` looks for headers in /usr/include and libs in /usr/lib
* ```./configure --without-jq``` disables the jq feature.

I understand this might be way too complex though.


Bahh, ficou show :) . Tu acha que seria conveniente testar nome null?


Thx Rob. This was a silly oversight; not easily testable due to access...


Uploaded.


Those LTC are hard to pass !!!


Updated


I think this one misses actually calling the function :)


As per https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/glusterfs/glusterfs.go#L73, let's look up a flocker-service endpoint with the API to save hardcoding the host/port.


Depende, creio que a partir do momento que o construtor é criado recebendo um parametro para Nome, não há como o nome do objeto ser null.


Tá bala, brother. Ali tem um teste elfoNãoRecebeNomeERecebeFlechasPorParametro, tá ok?


+1 :shipit:


Lel!


Hola Leandro, muchas gracias por compartir tu extensión para Magento, intentamos utilizarla pero no tuvimos éxito, nos informaron de Bancomer que la Firma electronica no se genera de manera correcta, nos podrías ayudar?


Cara acho que você trocou o valor esperado pelo atual, não devia ser assertEquals("Legolas possui 10 flechas e 0 pontos de experiência.", legolas.toString());?


Shouldn't be `shard.lock` instead of `.shard.lock`, like above?


The endpoint should be PATH_WHITE_LISTINGS_GAV


@alexWhitworth : thank you for the heads up, and mentioning that paper.
(Honestly, I find it a shame that referees in 2015 still allow such papers to be published without some code availability.... but yes, I am extreme).   Did you ever hear anything recent from @jeffwong ?


Should be `dic['module'] = module_name`


I guess three looks like 256 -> 128-> 64 -> 32 -> 16 -> 8 -> 4 -> 2 -> 1
1) 256 -> 128 : 128 summations / 8 = 16
2) 128 -> 64 : 64 summations / 8 = 8
... Total second would be 16 + 8 + 4 + 2 + 1 = 31 sec? but my guess could be wrong.


:trollface:


No código não faz diferença, porque ele comprara os dois valores sem importar qual vem antes. Pode ser que haja alguma convenção, mas aí não sei. Se descobrir me avisa.


Fine. I reneg. Take out ads if you want. But you can't complain to me on
skype any more about the project, lack of structure, Peter wasting your
time because of JS, etc. It is now your problem. The AWS server is still
available if you want it. My team will contribute to flyspray when it is
convenient for us. I'm happy to chat about architecture and things like
that, but I don't want to hear about any of the problems related to slow
development, Peter, or whatever other drama. Not my problem since it seems
everyone wants to run this project the same way it's been run the last 2
years, rather than try something new. Users want git integration and mail
listening? Good luck. Ask Peter, Scott, Psycho and Bryan Tong do build that
for you for free. Bryan talks a huge game, maybe you can convince him to do
some free development work for you, cause he never did any development
during my time driving the project.

________________________Jordan Mendler
[image: The Veloz Group]
The Veloz Group
President & Chief Technology Officer
jordan@thevelozgroup.com
www.thevelozgroup.com

On Thu, Sep 17, 2015 at 9:10 AM, Psycho <notifications@github.com> wrote:

> Damnit, leave it with that money discussion.... Money isn't needed here,
> everything is free, but the hosting by Flo! Donations? Where did they ever
> go? For what?
>
> Talking about git featuring mail listening, it works really well, just saw
> now that 2 of my answers don't show up here... First one being the fact I
> don't understand why you say I won't work for free. None of my previous
> projects, even own ones, ever made me any sustainable incomes. I run my own
> business, have 35 employees. Summer was hot, nature is early, I won't tell
> my producers: Hey guys, wait, don't deliver the 60 tons of grapes now, I
> have to release Flyspray!! So it's a matter of priorities.
>
> Again, Google ads were meant to be implemented for users not forcing the
> whole population to make us money for nothing. A simple admin field to give
> your own private key. Ads were displayed in the bug flow, taking the height
> of 2 bug lines, kindda like on forums where the ads take the first reply
> place. Money goes to the admins that wanted their FS instance to have
> Google ads.
>
> The only thing I see here is: We need money. Google ads will NEVER give
> you 60k a year, never! And hiring a pro dev is not a good idea.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Flyspray/flyspray/commit/b889759b1805196a5a22de7501b99408f4bd6cd1#commitcomment-13291834>
> .
>


no problem


Tá bacana. Vários cenários de teste. Show!


Shouldn't this just be part of a DefaultDataFetcher that tries property first then falls back to field?


tá ok, foi pra testar os dois parâmetros.


Another thing to notice, I believe you have copied jq from their release tarball into our source. As a result I get various fatal errors when running `./autogen.sh`.

If it cooperates well, you might want to try shipping a clean git check out (not configured), so that our `./autogen.sh` processes their `configure.ac` as well. Not a requirement in general, but it /might/ work better. OR we might want to remove it from SUBDIRS in our `configure.ac`.


good!!!


thanks for catching, will fix


@mmaechler I have not heard anything from @jeffwong . Though I did hear back from Tutz & Ramzan that Mr Ramzan is currently working on an R package implementing their methods and that it should be available "soon".

In the meantime, I've forked this package and implemented w-kNN using Gaussian kernels on my own account: github.com/alexwhitworth/imputation. I'm currently running it on a dataset with ~320k observations and it's rather slow, sadly.


The first line I haven't put in the spec, so feel free to fix it. I never leave space between the expectation and `.to` call. It's a method call and that should be without space. In fact I'm surprised that Rubocop hasn't picked that up.

As to the way I wrote the spec, the reason I moved all existing tests to the `context 'with running benefit check' do` is that it's really difficult to test anything like this in isolation as the benefit check runs inline in the model. As I mentioned today, we should remove it and make it responsibility of the controller (or any other flow control) to invoke it, not the model itself.

Please, fix as you think, merge and deploy together with the other NI bug, which got fixed today. Thanks a lot!


needs any tests at all, and would like to see the same code deleted from venv-update

getting venv-update to use this script would test it sufficiently without changing any tests, i think


Thanks, that's fixed now.


Going off of how it was before, but it's also shown as a method in the protractor examples and Selenium docs.


Realmente, acho que a convenção é assertEquals(Valor que se espera, valor atual);


The problems are
* You can't run/use compiled binary (without explicit LD_LIBRARY_PATH) until before you install the compiled library (as it won't find the library):
```
 [kir@kir-tpad mosaic]$ ./moctl/moctl
 ./moctl/moctl: error while loading shared libraries: libmosaic.so.0: cannot open shared object file: No such file or directory
```
* If a library is installed, when you run the binary, the installed (rather than the one you compiled) version will be used

So, this is to help a developer be able to run the moctl binary
* right from the source directory,
* without a need to install a mosaic library,
* and in a transparent way.

Hope it makes sense


I don't think we need it for the client.


Receio que possa receber o seguinte: Elfo(null)


Or is it for both, since `/v1` is inside this route? Then it's fine, disregard me.


Based on an offline discussion it seems that we are ignoring the sum-modules based on some anecdotal evidence that they will end up sharing the same target folder as that created for the parent, and this happens only when the submodule is specified as a path to an XML file ... so it might be nice to pull that logic out to a method like: `private boolean moduleSharesParentTarget(String module)` and simply add the xml check (`module.endsWith(".xml")`) in that method.


Nice! I'v been searching for something like this to build URI but they where not this elegant.


I disagree. What's your rationale?


Consider making this also the default case, or throwing an exception in a default case.


Cara o que eu vi aqui foi só questão de boas práticas, geralmente o construtor vem antes dos métodos.


There's also an existing discussion here https://github.com/littlebits/code-standards-js/commit/d0a360b38f81eaf33cc85776e8e3fe81e92582ae#commitcomment-13204183 that would have been nice to see you in before an abrupt commit. I won't pull out a `git revert` on this.


I was trying to make a tiny change to get this branch to rebuild since the previous travis job had somehow never finished and I couldn't see how to restart it.


bom, que eu saiba seria assertEquals(expected, actual), o expected o valor que deveria ser e o actual o valor testado


Realmente, é possível


Typo - should be "bind itself to"


thnxs for the merge @AAlakkad now i dont understand why i still get alakkad/world-countries-cities v0.1.0 requires illuminate/support 5.0.* -> when i composer require alakkad/world-countries-cities


the whole native fullscreen vs other fullscreen behavior very schizophrenic and I'm thinking to nuke out the old in factor of native. thoughts ?


Looks like this would be the same as the eurekaConfig class member value. Does it need to be retrieved twice, or could you use the member variable in this method?


Not possible, I have to sing in Bristol 6pm - 7pm. UNLESS YOU WANT TO COME


Loop here could start from i=1 ?
(we already parsed i=0)


warning, this seems to have triggered a crash when smb idles. on list to track down.


bien adri


MiscReleaseFixes (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (806 of 806 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.92%25-green.svg)


Did you intentionally lose the screenshot? I think it's worth updating and keeping.


You would call the method in the spec.


Seems strange to me to initialize the member variable here. If you want to have lazy initialization, I'd suggest putting it in the getAmazonRoute53Client() method and use that method everywhere the client is referenced.


as i told u, when u want to build u use manifest as u wish, next dude will modify as his convenience :p


Is there any plan to support for HDR ?


@DacoTaco y u no use github releases?


:+1: just saying :P


@jessegreenberg Can you please add JSdoc and visibility modifiers for all of the new stuff?


Why'd you arbitrarily pick "us-east-1c" as a fallback? I'd expect it to throw an exception if it was unable to determine the AZ rather than picking this value.


I think the tuple case return an error for some time now.

In live discussion with @carriepl, it was harder to make scan use shared
var then to make pfunc support In with updates.

What the tuples was doing? I also think we can get rid of it (but raise an
error in that case)

On Thu, Sep 17, 2015 at 12:08 PM, Pascal Lamblin <notifications@github.com>
wrote:

> Either way, there should be only one class at the end. The question is
> whether this class should accept update or not. I think it is easier to
> maintain and make sure it works if it does not, since we do not have to
> worry about weird corner cases. However, if it makes things better /
> simpler / more efficient in @carriepl <https://github.com/carriepl>'s
> feature, then I'm not opposed to it.
> If we remove the update feature, then we should remove that part of the
> documentation.
> In my opinion, we should remove the "tuple" way as well, I don't know
> anyone using it, and it is confusing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/carriepl/Theano/commit/b351f47a806d617b6cfd4b05c9c1f0b38b8cf49e#commitcomment-13291769>
> .
>


@moatazharb could you actually remove the line rather than comment it out?


> I'd avoid tricks like that.

Care to provide a better way of handling AIX that doesn't involve getting IBM to change AIX (including retroactively changing *existing* versions of AIX)?  That's why that trick was originally created.

> It is better to change `Packet32.h`

Yes, but that's part of a different project, and I don't want to start changing it until I hear from Gerald Combs about what the plans for a "next release" of WinPcap are - they might want the "next release" to be the minimum necessary to get it to work sufficiently well on Windows 10, with upgrading to the latest libpcap etc. being deferred for later.


Yeah LTC keeps kicking my ass.


I like this


needs more jquery


"Toggle Private Mode" kind of makes it sounds like we're entering/leaving private browsing. "Private tabs"/"Normal tabs" (depending on the state) might be clearer, though @dusek might have other suggestions as the resident a11y expert :)


this doesn't catch additions to containers. e.g. Block.transactions


Hooray for good defaults. r+


`safe?` も `adjoin-position` も `k` 使わずに書けたっぽい……合ってるのか謎


"specification" seems wrong, I would have though the parameter specification is the definition in the operator model file, not its value.


why I can not find this great commit in official release ui4j-all 2.0.0?
https://i.gyazo.com/54f9fadb89827cf452e7f67846defa95.png


Use a link to parallel?


It's not in the jar; you'll see it if you check out the repository.  See the "Building" section in the readme.


i think you still have a potential security flaw here. Albeit one with a much smaller window than the one that the commit fixes.

 Imagine that I manage to get hold of the auth_code and duplicate the request to get an access token for it. While the first call to get an access token is going over the network to find the auth code (line 67 of oauth2.js), my call to get an auth code is serviced and also goes over the network at the same code location. The first call comes back, deletes the auth code and then issues the access token. You might think everything is good and the code can't be reused. But, the second call can make it into the queue for mongodb before the delete. So, it will find the auth code, come back to the same callback and issue an access token. It will delete the non-existent token too.

Unless I missed something?

ed


This doesn't actually change. TOFU is still MitM risky, just avoidable on subsequent connections. Just generalizing this to "anonymous connection attempts" to cover all possibilities, even odd opportunistic encryption tactics, sounds fine.


Maybe consider using `new URL(url).getHost()` here? This would have the added benefit to validating the url value.


Is it a merge issue ?


Oh.....

On Thu, Sep 17, 2015 at 3:43 AM, Neil Layne <notifications@github.com>
wrote:

> This is a reply to your commit bby.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/creesch/reddit-moderator-toolbox/commit/60b66582deafd15397c76a01137c7bd8464b1364#commitcomment-13280271


System.out.println("texto valido");


@aembler I was just digging into this. It looks like it used to be

```
foreach($r->find('concrete-picture') as $picture) {
                $style = $picture->style;
```

But that was when we were finding `img` and not `concrete-picture`. See https://github.com/concrete5/concrete5/commit/e68f2068dca9ee994684c6160d031b7e1724c7e0#diff-1feb76f8bcec7ac898f5bddc2d8cb975


Thank you, good thinking. :-)


fdfd


Seems more like the top one (line 39) is wrong and this one is right, judging from the old names.


hey cyberium i played around with the new system and noticed some potential issues:

when you pass for an item and someone else rolls for it, the pass massage is displayed again when the rolls are displayed

when the timer for need/greed runs out on items from raid bosses, it doesnt disappear, but pass messages are displayed (maybe a backport issue as the timer was increased in later expansions?) works on chests etc

when an item in a group is dropped that has a condition that is not fulfilled, it is not replaced by an item that fulfills all conditions(for example when a shaman raid item set piece dropps for alliance)


What about "flags for tx verification" analogous to script flags?
I'm thinking that once we expose VerifyTx() (currently non-existent) in libconsensus, we will want tx flags rather than locktime flags (there may be some other tx flags in the future).


Is there a reason you used LinkedList and not ArrayList?
Generally ArrayList is both faster and more efficient in terms of RAM. It also reduces class count since we try to avoid other collection classes thus reduce the core generated C/H files.


Nit: one liner:

```
query_map[:controlPluginName] = options.delete(:controlPluginNames) if options.include? :controlPluginNames
```


I removed this later.


No reason, really.  Since most of the time, it will only have a single item, I figured LinkedList would be more efficient.


This ends up looking like: ```https://bitbucket.org/pypy/pypy/downloads//pypy-...```. One slash too much :)


:+1:  Thanks :)


Mea culpa.

The good news is that the crash has nothing to do with the fixes. The bad news is that I messed up trying to write a loop in a more compact way. I checked it multiple times, and still managed to get it wrong.

Fixed now.

/me goes off to hide in shame in a dark corner somewhere.


I love this :trollface:


Утечка памяти


Changed it to ArrayList.
50c2ae0


Бесполезный комментарий


Extracted the `rvm::multi` recipe into `travis_rvm::multi` in later commits


nit: newline between stdlib imports and package imports (and 3rd party imports) is always nice.


Sure. r+


This code also gets executed if a user is registering or logging in during checkout: in which case the guest cart will have no email, and won't be correctly added. It will redirect the user to the address page, not telling him that his cart was lost and replaced with his last 'signed in cart' -- if the user isn't careful, they might end up purchasing different items from what they intended.

We've reverted this on our fork.


The protection against that is to require client authentication when the code is exchanged for a token.  If you manage to get the auth code, you'd also have to steal the client secret in order to use it.


It actually should be ">= 6.8.9" anyway...


I don't know how to compile it.  I just downloaded from wiibrew.org.

Seems to work fine. It was version  .8.

Sent from my iPhone

> On Sep 17, 2015, at 1:05 PM, s3r1alpari4h <notifications@github.com> wrote:
>
> @DacoTaco y u no use github releases?
>
> —
> Reply to this email directly or view it on GitHub.
>


@lyndonbartlett88 DWMR. Good. Everything is good here. Press on!


we can drop these if they'll be empty


Just quickly: I don't have an idea yet what the UI looks like, but from brief look at the code, there are three options with these kind of toggles:

1. `accessibilityLabel = "Private Mode"`, and rely on VoiceOver automatically saying "selected" when the button is selected; good to be supplemented with an `accessibilityHint` like "Turns private mode on or off" (I hope I got it right). This option is what Safari Reader button does
1. Be explicit in label by having a label "Turn on private mode" and "Turn off private mode" (or what Brian suggested)
1. Be explicit and while having label like in 1, distinguish the state by `accessibilityValue` (e.g. `accessibilityValue = "On"` or `"Off"`) - just like the show tabs button in `URLBarView` has a label of "Show Tabs" and value of "1" or whatever the number of tabs is.

I am always torn between options like these, but the current state is not good (when VoiceOver says "Toogle Private Mode, selected", it is confusing and I would not know what it means if I did not see it on the screen). Options 1 and 3 seem semantically clearer to me. A conservative (and easier) option is probably 1.


Why is this a placeholder and not actually added?


Thanks for working on this!

I wonder if we could re-use actions for this. Maybe make actions take a void* or variant argument, and then we can re-use tag.1.apply. If we went with void*, we'd have to make input bindings pass NULL, which isn't great, so maybe some kind of tagged union is better. I still have to think more about this.

Also, I think if we do this, we should also support matching on window app_id.

Maybe you can solve your whitespace problem by allowing the title/app_id to be quoted?

    rule title "Mozilla Firefox" tag.2.apply


Please help me setting up SPSA parameters list.

I am new to SPSA testing.


@pmoulon Is there a reason for converting the SIFT extracted by VLFEAT (float) into unsigned char? (Beside the less storage space required on disk)


Great idea, adding now.


nit: m1 and m2 -> msg1 and msg2
nit: should_be_allowed -> allowed (it's clear enough)


to use the psuedo classes, make sure the : and the action have no spaces ( ie :hover)


@Diego-F-Aguirre DWMR. Good. Good start. Press on!


Please fix your import order. It should be alphabetical. Java ▶ Code Style ▶ Organize Imports. Order should be com, java, javax, org. This is part of the [ImageJ preferences](https://github.com/imagej/imagej/blob/imagej-2.0.0-rc-39/config/eclipse-preferences.epf).


Think the TTL value should be declared as a constant?


You have a lot of floats going on but the two columns aren't working, try to use them on the largest container you need to float so that you manipulate the smallest number of elements.


Thanks for the 3 options @dusek. Here's some mocks of the UI to clarify: https://mozilla.invisionapp.com/share/JY4675I9W#/screens/101227133. Tapping the mask button in the top right will switch between seeing private tabs and normal tabs.


LGTM :shipit:


@s3r1alpari4h WHY R I LAZY? :p
there is also just no need for it imo. latest works and doesn't need any fixing anyway (besides linux compiling XD)


#FEWD Week #3 Project: CSS Layouts

---

###Description

Relaxr was really impressed by your work last week and wants you to continue development on their landing page. Starting in class, you will work to build out a more complex layout for their company site. They decided on creating a blog, and their back-end engineers will be focused on developing the blog's functionality. They want your front-end skills to style their designs using HTML and CSS so Relaxr's engineers can begin integrating. Once again, the designers have handed you a basic design file with instructions and a JPEG to help you bring the blog to life. Submit the finished version for homework.

Student: Portia

Project URL:

|                                                                                |                                |                        |                          |
|--------------------------------------------------------------------------------------------------------------------------------------|--------------------------------|------------------------|--------------------------|
| Technical Requirements                                                                                | Does Not Meet Expectations (0) | Meets Expectations (1) | Exceeds Expectations (2) |
| Use in-line-block or floats in your CSS to achieve a two-column layout                                                               |                                |            x            |                         |
| Use the correct ```Open Sans``` Google Font typeface to style the text denoted in the design file and according to the JPEG provided |               x                 |                        |                        |
| Use proper filename conventions (lowercase, .html)                                                                                |                                |                        |            x             |
| Use a single external CSS stylesheet to style all pages                                                                              |                                |                        |            x             |
| Add a hover effect to all the links using pseudo-classes                                                                             |                               |                        |          x                |
| Integrate drop caps using pseudo-classes                                                                                |                                |                       |             x             |
| TOTAL: ___9___/12                                                                                |                                |                        |                          |

Notes:

* no hover effects for links
* drop-cap done using span instead of pseudo-class


ddd


dfgasffd


si avevo pensato le stesse cose prima dando un'occhiata veloce.
pensavo di trasferire le cose che fa gamesystem a flussodigioco.
di flussodigioco mi disturba un pò che il costruttore vuole un quantum; se riesco lo aggiusto. In realtà anche le fasi mi sembrano un accollo di lavoro extra visto che si potrebbero usare esclusivamente le azioni; ma non le tocco per adesso


@abnero DWMR. Press on Abner! Good work here.


This might be too conservative, but trying a property first always and then the field would involve an extra reflection call every time, which can impact the performance.


I made a call. Both this and comma dangle I don't agree with and I shortcut discussion in the name of productivity, which I rarely do. They are both massive visual noise/distraction in existing codebase with at best debatable gains and I didn't feel like debating :)


Didn't work ??? (graphite optimizations)


This two lines are the key to solve the linker error


Don't think `developed_open` should make it into this list twice.  Tall Grass Prairie seems like it is replaced by `grassland` (NLCD 71) which is also already in this list.


belongs to #4


I think this comment ended up out of place.  I believe it goes with the remove line.


Same, I think prairie -> grassland is more correct per #765


Please do not use nested ternary operators. Little bit hard to read.


Update network settings


@jenrana DWMR. This was, in my experience, the single most challenging assignment of all. Proved to be something that your ultimate soltuion dealt with concisely, completely and correctly. :+1:


If we are worried about performance we should restructure both data fetchers to store the field/methods they resolve to and then you have at most 2 reflections per field per lifetime, right now we have 1 per execution.


Hello,

This is a WIP, comments are welcome.

Thanks,


I think if we are leaning this heavily on jquery we should add it as an explicit dependency. https://github.com/RenovoSolutions/TypeScript-Angular-Utilities/blob/master/bower.json#L25-L27


@setriplette @HelenaSabel Stacey, I'm just reviewing your <anchor/> coding of the translation units, and this struck me as a suddenly interesting point: Looks like Southey just skips skips over 6 of Montalvo's clauses! Is it a big gap here?


Right now it is present, but only because we are assuming it will be required as a dependency of angular.


Sort of, there is an obsolete line that shouldn't have been there. Don't know why it's there, but I must have put it in :-(


ah damn. wanted to refactor that one but missed it.


In the future, angular may not require jquery.


: D


On Thu, Sep 17, 2015 at 6:51 PM, Alex Whitworth <notifications@github.com>
wrote:

> @mmaechler <https://github.com/mmaechler> I have not heard anything from
> @jeffwong <https://github.com/jeffwong> . Though I did hear back from
> Tutz & Ramzan that Mr Ramzan is currently working on an R package
> implementing their methods and that it should be available "soon".
>

I see...

> In the meantime, I've forked this package and implemented w-kNN using
> Gaussian kernels on my own account: github.com/alexwhitworth/imputation.
> I'm currently running it on a dataset with ~320k observations and it's
> rather slow, sadly.
>

Well, if I look at the source code,  I see many places where things can be
made faster..

> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jeffwong/imputation/commit/c1cc5e4db150dc5fe4fa069be0670284143a105f#commitcomment-13292913>
> .
>


No problem!


Hey Maria, do you have an image that you'd like displayed? If yes, send it to me via email and I'll add it for you. (:


Probably should document somewhere the reused of the EIP params in this class.


Done with first pass of a review.


Here, the code starts to look weired:

- You are returning an error if `se_num != 0` but nevertheless you have some dead code below that *need* `se_num` to be `!= 0`.
- Also, your handling of locking/unlocking is broken.

@philipWendland Could you please have an other look at this code?


This should be called from the prune function as well.


Well I was thinking it would be safe (at least until somebody modifies the code :) because it is a const reference, and it's not dereferenced until after the data collection on the file thread has finished. But there's no guarantee that the browser thread will see the updated version of the OSExchangeData before it is used in the browser thread, so you're right, it is unsafe.

I will fix this by storing only the target_location and root_location members of the DropTargetEvent. That will avoid the issue and also make it easier to modify the code safely.


yes, thats true .. but on the other hand it may be time to quote knuth "premature optimization is the root of all evil" and just merge both DataFetcher as @tberman suggested to make it very easy for the user and lets deal with performance when it comes up.

@erikogenvik What do you think?


updated. btw you commented on the commit again :D


`pasture` shows up twice in this list


i think the underscore helps readability for private methods, for inline methods i think we can drop them since they are already scoped.


i would just inline this


ditto


Good point. Then how about "You will need the generated client id and secret later"

There's no point in telling them to store it, Google does that for them (you can always go back to that page and retrieve it)


This is the initial version of the contribution for supporting encrypted properties.
It is working now, but I have planned renaming of AESEncryption class and writing a little documentation about the new features.


I always wondered if it could be useful to adjust our depth formulas with some scaling based on the some avg max_depth that we could compute for different time controls.


comment on how to use this class, maybe an example


I think `separated` was more grammatically correct?


Let's cut this section. We're not using `oslo`.


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1343 of 1343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We can cut this one too; we're not using any of these OpenStack libraries.


It is deterministic memory reuse, not uninitialized memory, it was repeatable, as long as you printed the right pair of numbers in the right pair of show modes. I ran Jiahao's script in a debugger with:
```
output[1] == '0' && ccall(:jl_breakpoint, Void, (Any,), (tuple of all arguments and locals,))
```
then would figure out that path it had taken through that function and repeat on the next function a level down.
while doing this on `bignumdtoa`, I noticed that the results were repeatable at the repl, given those locals, but that one of the locals (`decimal_point`) was not computed correctly. That meant the bug was somewhere in the initialization code, which is when I eventually noticed how these values are used, and that they weren't being set.

As an aside, out show compact code seems slightly wasteful in the number of times it calls `sprint(showcompact_lim,v)` on every cell in the array (3 to 8 times, by my estimate), then uses a regex to determine if it contains a particular character sequence (`[.eE]` for Real, `[+-]` for Complex, `//` for rational)


document the return type (i.e.:  what's  in the tuple)


It works, but many people reported about increased power consumption, reverting it for now.


My latest commit should fix it as well:
https://github.com/xbianonpi/xbian-package-repo/commit/40ca806add1c1f85be5370bd54e86c4f7ac4e982


Yes you're right. Fixed on 57c909c80773c017dda8f25cbbc837e76a8e06f4


Maaan, forgot to add rotteSide.html


fk u


Might be better to do the suppress warning here in initialize, and write `minMaxFunc = (FunctionOp) ops().function(...)` and then you can do proper typing up on line 66. What do you think?


If you do my suggestion above, you won't need this suppression here.


ezpz :+1:


it would be nice to have a diff_text property that expose a diff output via https://docs.python.org/2/library/difflib.html


`mode.lower()`?


:shipit:


Pull request to solve the #7 issue. The line breaks were not being respected.


Let's cut `hardcoded_tmp_directory`. It generates a warning since it's undefined.


Why did you use PLATFORM_LINUX_MICRO=y in the pre-built config?


Would be better to use the `RTs` helper class here. You get proper typing and can type on `T` instead of hardcoding `DoubleType`?


wow amazing commit message :a:


Çeviri gerekiyor...


Yes, this is `shard.lock`


The indenting is incorrect. Unfortunately I cannot deduce from the code whether that's intentional or not (maybe some brackets are missing?)

@dengert could you review your code again?


Hey, thanks for replying.

I can also express the issue, as I see it, in terms of the client issuing the request to exchange authcode for token twice, which wouldn't meet the spec. But the point I think is the security implication of not meeting the spec.

Let me see if I understand your point: hold the client secret in a backend service and make the request to exchange from the backend service, initiated from the user agent? This would indeed force me to know the secret of the client too, if I were to impersonate the client to the oauth provider. However, it looks to me that I could still impersonate the end user and pass the auth_code to the client's backend service and get the access token?


not a big deal, but this change generally should be a separate commit (it's fine for this time unless you want to split it)


@zhued thanks man :100:


Recovered from the dustbin


I vote for just one profile. `pykmip_conservative` is fully covered by `pykmip_verbose`, so let's just rename `pykmip_verbose` to something else (e.g., `pykmip`) and just use that in `tox.ini`, and delete `pykmip_conservative` altogether. I don't see us needing multiple profiles yet.


ChunkyPNG. Unsurprisingly, it only works on PNGs. This is a problem.


:heart:


We can probably cut this section too. It doesn't apply to PyKMIP.


you can break once is_unique has changed, no point in continuing the loop.


What is this looking for? Needs comment.


Thank you for the information. I would agree, in the case of `MONKEYC_STARTING_CONSTANT` that it would be best placed in the relevant class. However, constants that are to be used globally, such as `IS_DEBUG` or something like that, would be placed in a constants file like this. I'll leave in the class with your changes in case we do implement variables that are used across multiple classes and packages.


MiscReleaseFixes (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1879 of 1880 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


ok. Sounds reasonable. Let's just keep it simple for now.


cripes; sorry for the hassle. who knew just using a  cache of BigNums would cause so much trouble. It's interesting this didn't result in any errors when running it through the big grisu test suite (which tests 100K different configurations for hte different printing modes).


OK, and what's the "new" command line to run a compiled binary with compiled library?


Should the keys in this file also be updated?


Yes, it's removed in this commit. I think its purpose was to show how to invoke the app passing the runtime path, but currently it adds no value to what's described above


History Gravity may be the reason why my stats patches struggles at LTC.
Since at higher depth (d>21) it actually cause an inversion to the values.


we actually want `DoubleType` here as we want to mean with full precision.


I am working on this I need to create application


test


basically from $row you can also reach $tablerow (from $row->data), so it's not really needed a new param


наверное это лучше назвать add, чем translate. к тому же раз есть subtraction


Correct is +IDS_LOG_BALLOON_TOOLTIP "Você deseja ajudar o Unchecky a evitar programas potencialmente indesejados? Diga sobre isso para seus amigos e familiares. Compartilhar agora!"


comparing len() of ThriftStructs should be inside is_isomorphic_to()


@mmaechler I'm happy to receive a pull request :)


It looks broken now http://hydra.nixos.org/job/nixpkgs/trunk/urweb.x86_64-linux


Nice catch. Done in 35d1d04ab1c8b8ae4cf01d342eb69b048b1c5c3b.


Okay. Done in 35d1d04ab1c8b8ae4cf01d342eb69b048b1c5c3b.


not None should be checked inside is_isomorphic_to() to make it more robust


Hi correct is +IDS_LOG_BALLOON_TOOLTIP "Deseja ajudar o Unchecky a evitar programas potencialmente indesejados? Diga sobre isso para seus amigos e familiares. Compartilhar agora!"


What exactly is this for?


Wrong path.
Right one is ```/categories/class/categories.class.php```


Again.
That's why copy/pasting code is bad ;)


@po-cruz @jakemarvin05


The authorization code is exchanged for an access token using client credentials.  The user is not involved here and attempting to impersonate them will fail.

How much effort you go to to prevent a code from being exchanged twice is up to the application (it is not something oauth2orize does).  If you want strict once-only semantics, you need a database capable of reading and deleting a record in an atomic transaction.  Otherwise, you leave open a very small window in which requests and database queries are racing.  The chance that this could be abused (especially if client authentication is enforced), is almost non-existent.


This commit looks wrong.


This doesn't look like a formatting change ;).  Do you want to write up a separate commit making and motivating this change, or shall I spin it out?  If I spin it out, can I keep you as the author?


We've lost all the php versions.


Photovoltaics (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


TeamCity DNN JavaScript Libraries :: CI [Build 77](http://teamcity.engagesoftware.com/viewLog.html?buildId=345&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 77](http://teamcity.engagesoftware.com/viewLog.html?buildId=345&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:18


native fullscreen is available since osx 10.7 if i recall correctly. Since 10.7 is mainlines deployment target - go ahead in nuking anything that isn't up to pace.


Do we have appropriate test for this since it's uncommented now?


This makes sense. However, I am not sure about using `the_title`. Looks like it would be hard to differentiate a post taxonomy term title from the actual post title.

I think I'd prefer introducing `wpas_taxonomy_name` to which we could pass a post ID and field ID. This would make it easy to target a specific custom field for a specific ticket.

```
$term_title = apply_filters( 'wpas_taxonomy_name', $term->name, $post_id, $field );
```

What do you think?


cli-documentation-fixes (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1879 of 1879 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@rec: On line 74 I'm surprised that a `HandlerImpl` has both an `Application& app_` and a `ServerDescription desc_` -- and the `desc_` includes an `app`.  At first blush it seems like you'd be better off always using the `app` provided by the `desc_`.  It seems dangerous to have two sources for an `app`.  Thoughts?


Disregard the comment, I misread/misinterpreted the code. I was thinking idx+8 as the range not as start :cry:  my bad.


Please add a chore to update the usage text to include descriptions for the other commands. Thanks.


k


???

$i == $#$marked is the last element in the list. so why the loop?

btw: i do not understand what you are doing here :P looks like this stuff should go into __unicode_sprintf()


The direct deletion link is found on the new TOS: https://www.spotify.com/us/legal/end-user-agreement/#s2


"dangerous" isn't the word I would use. Its something we can clean up in the future


This is a good edit.


Updated at the community post link.  TL;DR – this was an intentional change.  We should probably bite the bullet and add `drive.readonly` to our scopes.

https://plus.google.com/u/0/+JoeGibbsPolitz/posts/7xLaiAMUP8q


Ah, I knew that was out there somewhere!


cli-documentation-fixes (nealkruis) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This is unsigned, so -1 means `0xffffffff`.

"No space to write to" is already indicatable by passing NULL, in fact the last argument's value does not matter in that case. That's why originally I didn't have the last parameter.


I added another test to the integration test suit and made a few modifications to account of the changes to functionality supporting aria-labelledby.


agree it's very small, thanks for your time.


Yes,  the tests now do verify that the command only deletes the stemcells
that pass our filter.  Should one be added specifically with the same name
as the ones our pipeline produces?

On Thu, Sep 17, 2015, 10:55 AM dr.max <notifications@github.com> wrote:

> Do we have appropriate test for this since it's uncommented now?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/maximilien/bosh-softlayer-stemcells/commit/01b85fcc03b30f053d39865e6ee9ebdbfc6d07ed#commitcomment-13294116>
> .
>


Oh I See, I think we can also remove the dependency from Janez' branch. Will do that soon.
On Jun 30, 2015 4:38 PM, Stuart Berg <notifications@github.com> wrote:I added this because dlib is needed for Janez's structured_learning branch of pgmlink.  I guess it was a bit premature of me to add dlib here, since this build still uses the master branch (which doesn't need it).

—Reply to this email directly or view it on GitHub.


I believe this should error. If you call `.single()` on something, and it's empty, it should propagate through an EmptyError when it completes (which already exists in the library).


@jakemarvin05 @po-cruz


@julien731

Yes, of course. I just tested how it worked with `the_title`  (automatically translated the product titles with WPGlobus plugin) - but a new filter can work, too.


... this is another thing that differentiates `.single()` from `.first()`


I believe the `softlayer-go` `test_helper.go` has a method to do wait for transactions to complete on a VG. Might be cleaner to use it (if needed) or add a similar helper. Thoughts?

See it here: https://github.com/maximilien/softlayer-go/blob/master/test_helpers/test_helpers.go#L426-L437


@atwice все пофиксил


@GrahamCampbell This commit brought in the upstream `php` cookbook.  Everything we've been maintaining as the `php` cookbook has now been moved to `./cookbooks/travis_php` :smiley:


Again, I think in this case it should `error`, because `single` asserts that there is at least that one item in there. As opposed to `first`. I never really use `single`, but coming from .NET, this is what I think I would expect.


Kudos! Kudos! Kudos! I was just about to fork the repo and discovered this branch. Thanks for making this change.


Right, thanks. Fixed.


Where did it move to?


This actually landed.


I think that will be better. Currently the tests take a long time. I will
make the changes and resubmit.

On Thu, Sep 17, 2015, 11:02 AM dr.max <notifications@github.com> wrote:

> I believe the softlayer-go test_helper.go has a method to do wait for
> transactions to complete on a VG. Might be cleaner to use it (if needed) or
> add a similar helper. Thoughts?
>
> See it here:
> https://github.com/maximilien/softlayer-go/blob/master/test_helpers/test_helpers.go#L426-L437
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/maximilien/bosh-softlayer-stemcells/commit/a01f46090cf46d60d2dc778f368c7a99eecc9d24#commitcomment-13294270>
> .
>


hah!


Instead of this `if` statement, since this is test, do the following:

```
Expect(swift_username).ToNot(Equal(""))
```

Same for password and other checks. Thanks.


MiscReleaseFixes (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1344 of 1344 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.24%25-green.svg)


I'll wait for you to update the PR and then I'll happily merge it into core. Thanks :)


Nice use of the framework package. I think it's even cleaner to use ResourceEventHandlerFuncs so that the executor isn't implementing yet another interface. see https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/daemon/controller.go#L103


Noted


Ok I didn't know about this. I will go over this.


can we publish node v4 support? it's blocking me right now :(


Will do


Same as before, I am trying to send an error if two unrelated messages are being compared. I do length check in isomorphic too but there we just return True/False


I think I am trying to fail with an error. is_isomorphic_to doesn't throw an error. I have a null check there as well (for the path that doesn't use the can_diff method)


Will do.


This is reused thats why I did not inline.


Done


Something doesn't look good with AutoIt. Jon announced new version for tomorrow or the day after, so we'll see if he'd change/fix anything that could be related.
Anyway, your solution with changing _WinHttpSendRequest() doesn't seem to be correct solution. In case you want to be sure your input is processed correctly you should pass correct binary representation of the data to it. Like this maybe:
<code>_WinHttpSendRequest($hRequest, ..., StringToBinary($sYourData, 4))</code>


@TraDuong1 this key gave me access to Dell OSS' AWS stack. You probably didn't want this public.


we don't actually need to save podStore, can be replaced with `_`


we never reference podStore outside of New(), can drop it here


why is this indented an extra level past the if block?


It looks fine to me, and I've asked other people to look at it and they haven't had anything to say about it... so I guess that leaves it to you to decide when it's ready.  Just send it as a PR when you feel it's final!


Maybe we don't need all of them.


I had wanted to return a message to the user so they know that they did wrong. I changed the message to "empty string!" to make it more clear.


Left from old recipe, the new package doesn't provide these binaries anymore. They are built-in commands now.


@jonathanong what isn't working? node v4 support landed a while back (https://github.com/ncb000gt/node.bcrypt.js/commit/addc2b494028060d31bc6ac1cf1be483bc7b7d09) in the form of iojs v3 support.


Fine to make it work for now but we should really fix this to work with relative paths :/ (documented)


ok, I made the changes on this commit:

commit 14029f42716c9173c278e27e896e6bd995633716
Author: hennigk <kayla.hennig@gmail.com>
Date:   Sat Sep 12 20:34:38 2015 +0000

    updated some functions with the feedback from Ziad


New guideline says that python2-* subpackage provides python-* but that's supposed to be automatic using %python_provide macro and will change to python3-* subpkg when distro default Python version is changed:

https://fedoraproject.org/wiki/Packaging:Python#Python_Version_Support


I'm getting a ton of errors from clippy that look like:

```
/home/cgag/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.14/src/loops.rs:10:5: 10:26 error: a value named `LitStr` has already been imported in this module [E0251]
/home/cgag/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.14/src/loops.rs:10 use syntax::ast::Lit_::*;
                                                                                ^~~~~~~~~~~~~~~~~~~~~
/home/cgag/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.14/src/loops.rs:10:5: 10:26 help: run `rustc --explain E0251` to see a detailed explanation
/home/cgag/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.14/src/loops.rs:10:5: 10:26 error: a value named `LitInt` has already been imported in this module [E0251]
/home/cgag/.cargo/registry/src/github.com-0a35038f75765ae4/clippy-0.0.14/src/loops.rs:10 use syntax::ast::Lit_::*;
                                                                                ^~~~~~~~~~~~~~~~~~~~~
```


Sorry, I push "send" to fast. it should be GenericName[fr] (not Generix).
Tell me if you want another pull request.


Logically I'm feeling that makes more sense, while existing RxJS behaves to return `undefined` instead, tried to mimic same behavior. [docs here](https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/single.md)

After checking .net implementation [here] (https://msdn.microsoft.com/en-us/library/hh229425%28v=vs.103%29.aspx?f=255&MSPPError=-2147217396) says
>  throws an exception if there is not exactly one element in the observable sequence.

seems RxJS had bit different behavior to .net does.

Would it be better to align behaviors to throw?


This commit looks good, let's see if we break any working code with it. A mention in the release notes seems worthwhile.


@justinpombrio FYI


I should probably stop tracking the "nightly" builds but I'm curious ;) now that `updateWithAudioDescription` is gone what's the best way to go about calling `setAudioSessionCategory`, `setOutputEnabled` `setInputEnabled`, etc… in one fell swoop?


needs fix


There is apparently a typo here `RxNext.Observablerange`.


eclipse weird auto-indentation on save


Thanks, completely missed it.


I did consider that approach, but I'm a bit wary of too much magic. I'm worrying that there's a risk for subtle errors to arise. Consider if a property but not the field is renamed. Code would still run but with slightly altered behaviour.
This approach seemed to me to be a suitable amount of magic.

The field lookup issue is also something that I considered, but that's a general issue that can be dealt with further on as an optimization.


fixed in https://github.com/cfpb/cfgov-refresh/commit/7eddfdab1e3b99710b38fe703a60f10d8a0208c7


I only faintly remember there was some kind of problem with using 59.94.
It might have been fixed by now though.
Best thing to do: Have someone run Valkyrie Profile 2 in progressive scan mode while watching for glitches in the intro movies :)


misspelling: themselves


Is `summary` the correct moniker for this field? I immediately thought of seeing a string summary when I first read it? Thoughts?


Sure, many roads lead to Rome
But unfortunately, this does not help users which already switched to Jessie


You're welcome.

I think that akka-sse introduces little overhead over Akka HTTP. Given that SSE messages typically are small and not too frequent (<= 1/s), I would guess – but that's not validated by any experiments at all – that you can easily serve many 10k clients concurrently from a usual box.


Is there any reason you didn't leave this in read_cmdline()?


Should have an explicit default value set


Now that you're at it, isn't it worth it to create a soletta-devel-git too? Or is arch against this separation?
Why leave linux-micro out?


Indentation.


I'll take care of this.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 644](https://teamcity.labkey.org/viewLog.html?buildId=272755&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:27:19
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

##### there are 23 more failed tests, see build details
```


Here you are accessing a private attribute: _return_fields.
You can add gettter if you want to access it.
You __getattr__ will not interfere with this getter since _return_fields is already defined.


**new-cap**: A function with a name starting with an uppercase letter should only be used as a constructor.


**no-undef**: "describe" is not defined.


**no-undef**: "TestUtils" is not defined.


**Eslint**: 'return' outside of function


**no-undef**: "sinon" is not defined.


**no-undef**: "expect" is not defined.


**no-undef**: "it" is not defined.


**no-undef**: "ReactDOM" is not defined.


**no-undef**: "before" is not defined.


I have no idea what this does, not gsdx code.


Data title should not be "Dwarf Scrub". Description should read "woody wetland" instead of "wooded wetland" to match NLCD.


why?


You seem to have a fallthrough path that doesn't return a value here...


yrty


ah ok. i was confused by the commit history.

hitting a GCC error after updating to xcode 7... sigh


I don't understand why you couldn't use templates.
```js
var buttonRowInner = (new Template(buttonRowTemplateEl.innerHTML)).evaluate({
    gene_number: idx,
    gene_index: geneIndex
})
```

Then, just make sure that the `buttonRowTemplateEl` generated by velocity initially has `#{gene_number}` and `#{gene_index}` instead of `GENE_NUMBER_PLACEHOLDER` and `GENE_INDEX_PLACEHOLDER` respectively. You can optimize it by creating the template once, and reusing it each time you need to generate a new gene row.


Most probably it is working, I've missed it. Fixing.


Not really. I'll put it there.


Nit: extra space after '='.


Still here... `RxNext.Observablerange` should be `RxNext.Observable.range` :)


I thought this schema was the same contained in $pkgdir/usr/share/soletta/flow/schemas


Then please also remove the screenshot file from assets/images/tutorials/command-line


const?


Oh my.. apologies for errors. Will update immediately.


This is silly.  The Hack font is clearly different even if minimally.


@manthey so this was just an initialization ordering issue?


Mm, unless those lines up there are just creating dirs. Disregard if so.


Any need to keep `starfield{1,2,3}.png` in default/data/art? (Not that it matters much, since they're just 10 kB each...)


> Best thing to do: Have someone run Valkyrie Profile 2 in progressive scan mode while watching for glitches in the intro movies :)

OK, so you're our VP2 and nails polish guy (I don't have either...), care to run it for few minutes, report if everything is normal or if something weird happens?

Other than the prints, the only difference with this patch is that NTSC progressive was hardcoded to 60, and now it's the "normal" NTSC rate (so if you configure the NTSC rate to 60 and use an NTSC progressive mode, then it's identical to how it was before).


Actually, I think I did this wrong. The C++11 equivelent of a boost scoped_array is the array specialization of unique_ptr, so it would be unique_ptr<char[]>. I wrote this commit twice to clean up when I started to wander into the implementation side of things, and evidently missed some things.


I know, but I was used to Source Code Pro before and Hack replaced that. Now the differences between Hack and DejaVu Sans Mono don't look that striking to me.

Note aside: I switch fonts on regular basis, might go back to Hack soon enough.


Oops, meant to. I'll go fix that tonight.


You're right, I was doing it from memory.


@laurenam @TallJimbo    0.5 arcsec seems a reasonable default.  If you're running without an ADC, your astrometric accuracy isn't going to get much better than that.

In ESSENCE (Miknaitis07, Naryan15 submitted) our astrometric RMS was 0.3 arcsec, with typical ~1 arcsec seeing.  This was **with** an ADC, but the ADC was fixed to one position for the several-minute duration of the exposure.  I not holding up ESSENCE as an example of the current best-of-breed, but less than 0.5 arcsec would likely surprise people and lead to many false negatives when comparing catalogs from different times, and particularly different surveys.  I probably would have even picked 1".


The version does not appear to have changed here? :confused:


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Mmm, I think I left that builtins.json out, gotta check why again.


selectedIndex should be set to a default value explicitly.


I'm totally baffled by the confusion over this, but let me elaborate: `1.2.3+` is greater than all other versions starting with `1.2.3`, including `1.2.3`, `1.2.3-abc`, `1.2.3+z`, `1.2.3+zz`, `1.2.3+zzz`, `1.2.3+zzzz`, ... (there are an infinite number of such versions, with no upper bound, which is why it's convenient to have a thing that is bigger than all of them. When I see an infinite sequence with no upper bound, I want to complete it.


I checked the version to see if I needed to change it, and it appeared to be 1.0.3, which is the same as the new version of the main utilities


LGTM after comments


Completely correct, I forgot a line:
```
cmake_minimum_required(VERSION 3.1.0 FATAL_ERROR)
```
Needs 3.1.0, so this needs a look over on the mailing list.


You found a very neat way to compute asymmetry, and the concept is interesting too.
Congratulations !

If this works, and for a very small speed up, (save a few popcount)
you may eventually move the calculation to pawns.cpp, and use the result,


Should be fixed with the latest version `1.1.1`


These pkgdesc vars could benefit from mine, that are more complete.


oh okk, we will see :-)
right now first boot with recompiled linux kernel with graphite ... and it feels much faster .... but for that it was needed to recompile gcc with: --with-isl ... to make it working ... and now i need to make the same for the toolchain .. xD


I don't see why you'd ever want to use that as a lower bound. Maybe as an upper since upper bounds in require are exclusive, right?


I didn't update the version just when I added jquery as a dependency, since this was still part of the other PR


Consider using the pre-generated config too.


I'll bet it already changed (perhaps even in a previous PR) but we haven't done a release yet.


As discussed, we're both irrelevantly wrong


You're welcome, thanks for the quick review!

I'll fix up the issues tonight and then post to the mailing list to see if anyone else has a weigh in. I think my boost-removal still might have to go deeper, it slipped my mind to look into the files included from these for more boost dependencies.

And I just sorta kept with the surrounding text format, though I should probably go grab a formatter later. Vim's pretty decent at keeping things sane.

From what I've heard from the Dolphin devs, switching on the flag to use C++11 in your program is far easier than trying to readjust your whole build system to support Boost, but we'll see how it goes once this branching is finished.


Use whatever you feel like. It's your dot files!

I'm actually a long time old school DejaVu user and for years that was the best thing I could find. It still probably is best widely distributed (i.e. installed by default so easy to get stated with) mono font out there in my opinion. But I switched away from it for my own personal use a couple years ago for some bits and pieces in other fonts I thought had a leg up. Now I feel like hack combines a lot of those details I went elsewhere for with some of the solid base items that were good in DejaVu. So I like it, and the accusation that it's a "pointless" or "cynical" fork of DejaVu rings little hollow on my ears given my own history with the font family.


LGTM


expected should be:

```js
   var e1 =    hot('--a--|');
   var expected =  '-----(a|)';
```

The operator needs to wait for the source to complete to assert that there was only one item.


Why the split?


Yes, but that's what xbian-update is for :)


@gabest11 I meant if you know anything about PS2 running in 60fps in NTSC progressive mode but 59.94 in other modes. My patch basically assumes that 60 was an error, and changes NTSC progressive to 59.94, and I'm wondering if I shouldn't have done that.


Photovoltaics (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.19%25-red.svg)


Yes, I believe you're correct by definition of `single` does.


This should be:

```js
    var e1 =    hot('--a--b--c--|');
    var expected =  '-----------#';
```

Because there is more than one element in the sequence.


fixed in 0a32080


This assignment is far from complete..


This would make sense to make it as a property than a method.

    @property
    def infoblox_object_type(self):
        return self._infoblox_object_type

This getter will not interfere with __getattr__ since __getattr__ is called for an attribute that does not exist yet.


@d-meiser I had a quick look at GitHub pages but the tutorials I found was all about creating a special branch and jada, jada. So it looked overly complicated. But I see now that it should be fairly easy to just dump the HTML there. I'll make a stab at it. Maybe we can even auto-publish from Travis...


Should be:

```js
    var e1 =    hot('--a--b--c--|');
    var expected =  '-----------(b|)';
```

Again, because it waits for the whole sequence


Should be:

```js
    var e1 =    hot('--a--b--a--b--b--|');
    var expected =  '-----------#';
```

... because the sequence contains more than one element matching the predicate (which is looking for b).


Oh the deflection!


cli-documentation-fixes (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (805 of 805 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.92%25-green.svg)


Well done :+1:


```js
    var e1 = hot('--a--^--|');
    var expected =    '---#';
```

because no elements in sequence.


depends how people react to the new starfield style, I suppose...


Oh good, more hand-waving without concrete example.

> They certainly are similar.
Understatement of the century.

> And right now Hack has more alignment and cross platform issue than it's more mature heritage.

I don't even.


Like I mentioned earlier, acessing as a property like below would be more natural.
When I see a method call on this, I thought some logic is involved to get this but this just returns a private variable.

local_obj.infoblox_type


I don't believe you built a Roos by calling her tiny. Something like this might be closer to reality:

```ruby
[9] pry(main)> class Christine; end
=> nil
[10] pry(main)>
[11] pry(main)> class Piet
[11] pry(main)*   def +(other)
[11] pry(main)*     fail "Incompatible" unless other.is_a?(Christine)
[11] pry(main)*     Roos.new
[11] pry(main)*   end
[11] pry(main)* end
=> :+
[12] pry(main)>
[13] pry(main)> class Roos
[13] pry(main)* end
=> nil
[14] pry(main)>
[15] pry(main)> Piet.new + Christine.new
=> #<Roos:0x007fecf38706f8>
```
But still:
```
Bad code < Good Code < Correct Code < Cute Code
```
So just leave it


You can just take it out.


This extension is created only for the fatal error user extension. However, if the user application needs to add more entries to the extension table (for task start, exit, terminate etc), you could do so create another extension in the application code and will not override this fatal error extension. *TESTED*


change ib_type to local_obj.infoblox_type


Spelling error in commit message. Should be "nrf_pwm_set_value() will NOW return NRF_ERROR_BUSY until previous update has finished"


We gotta check why is this file needed/generated anyway.


O.o
TheStrix was here :p


A previsão de chegada deve ser calculada, assim como o consumo.


I assume we want these to be in the `PrivateBrowsing` tableName, too?


Is it possible to contrive a test case or two that would have failed before this fix?


I believe we need is to replace

``` if($style) ```
with
```if($picture->style)```


This description of failure is a bit misleading now, since it doesn't need to be higher than the bottom of the scheduler anymore, but higher of than the bottom of the viewport instead, right? The same goes for the assertion description on line 673. Could you update?


I can also update on my side on a different commit if you prefer, and then I can push to master :)


My first attempt at committing.


no ```-ggdb``` required any more?


I'm adding the initialize extension here in the bsp predriver hook. However, I feel this should be called immediately after rtems has finished initializing the data structures. This place doesn't suite well because the extension table is not a "driver" to be initialized. Your thoughts or comments?


besides the ```-ggdb``` comment, patch looks good. +1


@appleguy Not sure if this is the right move? I did this because the `init` initializer passes `nil` as the layoutable but is this class intended to be used if you don't have a layoutable? Seems silly.


awesome
+1


Ohh, I see that now! Awesome. Side note, are there any intentions of ever updating the Smarty version? 3.1.24 was supposed to have increased compiling speeds by 30-40%.


Photovoltaics (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I don't quite agree with that statement, but will fix.


I am not clear why parsing_class is needed here.
local_obj.from_dict(connector, ib_obj) won't work?


I don't know how to use this...


please use the ```%{version}``` and ```%{release}``` macros here...


On Thu, Sep 17, 2015 at 11:39:10AM -0700, MercenaryJosh wrote:
> You can just take it out.

It seems useful to get it into master one way or the other.  For
example, we already do this for categories [1].  It's independent of
the shift to Algolia, so I'm just asking how you would like it to get
to master.  If you have no preference, I'll write up a commit for it
with you as the author (since you noticed the omission) and this
commit's date as the date.  If you'd rather not be the author, I'm
fine making the commit in my own name.

[1]: https://github.com/azurestandard/azure-angular-providers/blob/v0.3.21/azure-providers.js#L461


container.metallurgycm.furnace.bronze=bronze Furnace another gamebreaking "bug" similiar to which @Shadowclaimer fixed in Metallurgy 4 :smile:


Yup - I'll add them there as well


Challenge 1


we could even introduce the major, minor and release macros so we can use it to expand ```libsoletta.so.%{major}``` also set the version expanding from it, like: ```Version: %{major}.%{minor}.%{release}```


Haha death to typos!


besides the version thing, patch looks good, +1


Really? Where o.O xD
On Sep 18, 2015 12:10 AM, "Parth Bhatia" <notifications@github.com> wrote:

> O.o
> TheStrix was here :p
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Radium-Devices/device_yu_lettuce/commit/094d1e5d31038630489b0949b153e1a1e5fcbe8d#commitcomment-13295061>
> .
>


Sir, your last instruction is somewhat unclear.  How am I to run like boss? Should one must be boss, in order to run like a boss?


kwargs.get(field) would be safer than kwargs[field] in case no field exists.


Keep this comment short.
```
A list of rules used to configure the Ingress.
http://<host>:<port>/<path>?<searchpart> -> IngressBackend
Where parts of the url conform to RFC 1738.
```


Make this:
Rules []IngressRule


Change this to IngressRule, as discussed previously


don't give specific examples, makes it hard to modify beyond (which we will be doing).
Say:
```
// Host is the fully qualified domain name of a network host, or its IP
// address as a set of four decimal digit groups separated by ".".
// Conforms to RFC 1738.
```


Again, don't give examples, also I'm not set on including the / in the path
```
// Path is the HTTP selector used to access the backend.
```


Rename this ServiceRef and make it a localObjectReference, eg: https://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go#L567 (don't make it a pointer though, because it's not optional or something we can default)


this needs to be util.IntOrString to accomodate named ports, eg:https://github.com/kubernetes/kubernetes/blob/master/pkg/api/types.go#L1243


Typo


It appears this commit removes many things from `typeaheadjs.css` that it shouldn't, and doesn't add the new `.tt-suggestion.tt-cursor > p` rule to `typeaheadjs.css`.


why not
```
if i := strings.LastIndexAny(path, "/."); i >= 0 && path[i] == '.' {
    return path[:i]
}
return path
}
```


Are you guaranteeing that key always exist?
If not, use get to access key.
cls._remap.get(key)
kwargs.get(key)


I have a few other changes to the AzureProduct, I will make sure that this line is added with those.


You are now titled "Boss of Specificity." Now you are boss so you can run like boss.


Oh, I'm not speaking to its usage here, just explaining what it means.


Ok I'll take a look. For now I am just trying to get the device description matching the actual device a close as possible. Once I am able to connect the controller then the actual work starts


Yes this indeed looks a bit weird. Thanks for spotting and notifying me. I will make a PR, but give me a few more days. I might have some more small additions/fixes in the pipe.


Thanks you kind sir.


@n0aaz the battery saver app has a different purpose. It doesn't implement Hush algorithm. Hush indeed has to be inside a ROM.
@lozo2010 Sure. This shall be fun. Which phone make/model are you testing on?


Red Sox > Giants
Boston > San Francisco


On Thu, Sep 17, 2015 at 11:50:46AM -0700, MercenaryJosh wrote:
> I have a few other changes to the AzureProduct, I will make sure
> that this line is added with those.

Great, thanks :).


oops, good catch! Didn't mean to do that.


Also, you are missing extension :)


Please Install Maven on Eclipse and pull the Project again. Cheers


I was getting a linter note that underbar as an identifier is not future-compatible.

```
    [javac]                                      ^
    [javac]   (use of '_' as an identifier might not be supported in releases after Java SE 8)
    [javac] 5 warnings
```

[JLS 8](http://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.27.1) says

> It is a compile-time error if a lambda parameter has the name `_` (that is, a single underscore character).

> *The use of the variable name _ in any context is discouraged. Future versions of the Java programming language may reserve this name as a keyword and/or give it special semantics.*


While there are certainly some operator precedences which people tend to confuse this spot should be clear. This is the very reason why we have operator '->'

(*a).b  =  a->b

now it should be clear what
*a->b
means.


Needs to be `13.1.0`, not `13.0.0`.


cli-documentation-fixes (nealkruis) - Win64-Windows-7-VisualStudio-12: OK (1879 of 1879 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Sorry.  indent-tabs-mode was t for some reason.


Done! Thank you!


I don't know.   Kevin might have a better idea.


fednjndlknnnnvnnvfnkj jkhjkhkjvhkjv
dskdlskjnjn ncnk mckmlcm d;ld
 fnj dn n ndkkfa;kl'k;kak;lklak'lkla;lkflakl;k;ak;


Aproveitando, poderia ser perfeitamente uma interface aqui.


good point. should have caught that.


And why do you want to parenthesize this? There is really nothing to confuse...


We now (1) call ktsan_task_destroy without the current ktsan thread, (2) read prev->ktsan after prev was freed. Why is it better than the current code?


Hmm.. I tested and for me works ok... Idk where you are wrong.


A couple of questions:
* Why is the character set in the htmlentities call hard-coded to 'utf-8'?  Does it have something to do with the fact that the module is called via an ajax request?
* What issue is this update addressing?


I'm feeling this can be

```
var e1 =    hot('--a--b--c--|');
var expected =  '-----#';
```

to raise early since it's already known there are multiple elements when `b` emits instead of going through whole source. What do you think?


I'm asking because I'm thinking of using akka-sse in scenario where client subscribes to events for given correlationId (commandId or sessionId) just before sending the command to write-side (in CQRS/eventual-consistency scenario). The client would receive events automatically (and update UI using event-driven technology like redux/reactjs) without querying the view again (no polling etc). But this is another topic :) Thanks again.


Oh, this autoplay thing might be worth testing options with too. If that's true, you could do this:

    window._wq = window._wq || [];
    _wq.push({ "thumbnail_test": { autoPlay: autoPlay });


I don't think we should revert this commit. AppMap doesn't depend on can/route/pushstate, so why should it import it?


Remove this console.log


Output format `junit` is removed and not yet implemented in v3+.


Are you guaranteeing that ips_v4 is always a list that has an element?


The same


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#JT8_gEXAQmagjx5LrRqy8g


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#OD-2LaZaQAqjNoJIi5vgSg


Ok. The generator needs to be updated then.


`json_encode` requires the first param to be utf8-encoded. Ref: http://php.net/manual/en/function.json-encode.php


Drop Object so just IPAllocation


eita jeovana


Sounds good. Keep me posted on your success.

For future conversations which aren't issues or PRs, please use Gitter: https://gitter.im/hseeberger/akka-sse


no, i was never able to reproduce it without just rerunning Jiahao's script.


Added JSDoc and visibility annotations to new accessibility code.  Thanks for the reminder!


I tried to change the function numChar(charString, charNum)
to use try and catch.

commit name: changed charat fucntion to use throw and catch
commit number: c6a6b3ebc5d05a1c22a14599567327a20ade1f71


This is illustrating cases like
`Rx.Observable.empty().single()`
which returns `undefined` instead of raising error. ([doc] (https://github.com/Reactive-Extensions/RxJS/blob/master/doc/api/core/operators/single.md))

so basically,
- if predicate matches multiple : raise error
- if predicate matches none : return undefined

feel bit inconsistent though. Do you feel to revise behavior? or mimic existing implementation first then revisit later?


Custom localization? 5k lines .lang file? pls, not again :)


@fesch this line should read if( sid == null || !fieldsBySid.containsKey(sid)).
The missing invert caused SID lookup to fail.
Do you want a new pull request, with some testing code included?


ok. I made the changes on:
commit:  updated some functions with the feadback from Ziad


I does not need to be in gdb format, I left it more broad.


whyyy


Eu criei um alias pra essa pasta no webpack, então pode usar isso assim:
@import "style/grid-flex.less";
:smile:


and this'll align behavior as same as when predicate is not empty and there are multiple matching element like

```js
    var e1 =    hot('--a--b--a--b--b--|');
    var expected =  '-----------#';
```


hi @mapilarc ,
i hope you are on the way to get your branch in sync with dev branch
my python is too bad to help you :( but i can test my code with my 4 thermostats 1 is installed and 3 are arriving tomorrow .. they have temperature, target temp., a 4-way switch and a dimmer
but i am sure there are people on the chat https://gitter.im/balloob/home-assistant with the code
greetings kai


WHY


Ack.


OH MY GOSH


You're welcome! And happy birthday to you :)

P.S is Metallurgy 5 is going for 1.7.10? Or for 1.8+?


New line character needs to be added after `result`


@cala Still being able to build (and run) the core is the whole idea of installing that more modern compiler. You will have to make sure that the build is using the new compiler of course, so you'll want to (re-)run CMake like this from now on:
`cmake <whatever options you have now> -DCMAKE_C_COMPILER=~/toolchains/gcc-4.8.5/bin/gcc -DCMAKE_CXX_COMPILER=~/toolchains/gcc-4.8.5/bin/g++`

Then use `make` and `make install` etc as before. Actually, you can give it a try already of course, to see how far you get.


We're aiming at 1.9 specifically. There's a lot of good new features/content and I'd hate to have to redo it all over again for 1.8 then 1.9 lol


incrementalUtils.kt is too vague name, I suggest protoDifferenceUtils.kt


```
// An Ingress is a way to give services externally-reachable urls. Each Ingress is a
// collection of rules that allow inbound connections to reach the endpoints defined by
// a backend.
```


Can previous exception-throwing branch be removed now?
```
// ...
ProtoCompareGenerated.ProtoBufClassKind.CLASS_ANNOTATION_LIST ->
                     throw IllegalArgumentException("Unexpected kind: $kind")
```


TaskCluster: @sw337y-314159 does not have permission to trigger tasks.


ingress -> Ingress since we're using it as a proper noun not a noun.


Let's just altogether get rid of this endpoint. We already have the ```GET /hawkular/metrics/metrics``` endpoint that provides this functionality. I do not see the value add in keeping it especially since it was not used to begin with.


Mesma coisa aqui dos alias:
@import "style/main.less";


@thoni56 yes, it's fairly easy. Just put the html in the gh-pages branch like you said. Would be pretty sweet to automate this from travis. Let me know if you need help.


You are correct, it is not required. I have fixed it.

https://github.com/alembic/alembic/commit/25ad81995bda455fd4e8bc957d89abf9fa44de9a

On 12 September 2015 at 12:12, Nick Porcino <notifications@github.com>
wrote:

> HALF_EXPORTS is only supposed to be defined when building Half.dll as part
> of the IlmBase build. Are you adding it here to trick the symbols into
> generating as part of Alembic without needing to link Half.dll, or is there
> a symbol export bug currently in the Half.dll generation?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nyue/alembic/commit/6a556a35b6f8130b510a0b3b05412dfbea123a1f#commitcomment-13197814>
> .
>

--
Nicholas Yue
Graphics - Arnold, Alembic, RenderMan, OpenGL, HDF5
Custom Dev - C++ porting, OSX, Linux, Windows
http://au.linkedin.com/in/nicholasyue
https://vimeo.com/channels/naiadtools


I guessed that you are going to 1.9 when I saw shield previews. Good job and good luck!


About the CMake changes: I'm not in favor of __hiding__ warnings, so if reasonably possible I would prefer to fix the actual code instead of setting up compiler flags to hide them.

The GCC changes don't really make sense to me. Why would you want to hide warnings for every architecture except (32-bit) x86? Am I detecting a quick copy/paste mistake there - the GCC file is very similar to the clang one, but not quite the same?


This might prevent the jig from rebooting for legitimate reasons? We want to specifically target the accel cal reboot, I think.


@quinnj – do you think you could coax this into hitting those new branches somehow?


Yea that and the new attack speed changes open up a lot for mods so I'm looking forward to that. I think the harder combat will also make the reliance on raw damage a lot less too.


Epic!


2nd tuning landed amazingly nicely.


Alias :laughing:


#4402-VRF-outputs-and-multiplied-floor (rraustad) - x86_64-MacOS-10.9-clang: OK (1868 of 1875 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


There is at least a typo in that change: "markMesage" instead of "markMessage" - btw, is there a ".push" missing as well?

What problem is this trying to solve? And is there a chance that this change (once the typos are fixed) will introduce an infinite loop?


Any good reason for this?


I'll fix it.


Ok, I'll change it.


because PKG_DEPENDS_TARGET="$PROJECT" makes no sense, maybe ?


cli-documentation-fixes (nealkruis) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1343 of 1343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.24%25-green.svg)


Are you sure that this is in the correct branch ? Actually, I don't even know what this branch is for.


Wasn't Verizon mentioned by Seth or AJ as using verizon.net for PRM already? It's likely that I'm misremembering.


Thanks for the responses, there's always something to be learned!


No. That tag already used.
I can't insert this patch into git commit history without breaking changes.


commit: made factorial function recurisive

I had to google the solution so it is not as impressive.


big work.
it's need to fix window size


I was wrong about non-printing NONE changes, makes tests more error prone.
Should be reverted.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#VUsqcnarS2i735idzuX6Jw


TaskCluster, Validation failed against schema: http://schemas.taskcluster.net/github/v1/taskcluster-github-config.json# ```{
    "validation": {
        "version": {
            "enum": true
        }
    }
}```


This will create duplicate entries if any of the player's stats change between runs, a behavior we don't want. You should get the playerstat object using just the player and week, then modify the stats and finally save it back with playerstat.save()


I think `if(isTRUE(check.names))` is better


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#eAmlAt_zQk-TLvAx5iRPRw


If you have package named same as project (like for Generic packages/Generic/package.mk) it is also build. I see no reason to remove this.


Why is `main` needed in each test case?


Fixed in 5a0cc23
Thanks Lu <3


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 645](https://teamcity.labkey.org/viewLog.html?buildId=272766&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 34 (10 new), passed: 8 Build time: 00:27:27
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSLoginTest.testLoginPage: <no details avaliable>

org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

##### there are 24 more failed tests, see build details
```


This is the "stable" branch, where all R39 fixes are located. The master branch is the development branch (R40).


I prefer to keep two different messages: "Unsupported" means we don't know about such kind, so the code should be updated, "Unexpected" means we know about kind, but it is not expected at this place.


ah - i see, I normally have `node_modules/.bin` in my path so it can find `node_modules/.bin/karma`. These modules will be installed with `npm install` since they're already in the package.json, so probably not worth mentioning.


What about changing companion object visibility (public->private) for example?


That was my concern, but no, they use.com, vzw.com, etc, same with comcast and others...


YAY segfaults :D


Well, 30/60 fps is certainly not for CRT televisions, on which PS2 runs.


ok


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1340 of 1340 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Command here should be `npm run prepublish`, install will work but it's probably doing a lot more work to check installed packages.


It is not really needed, but is also doesn't harm, I hope.


This currently works but something we might want to keep in mind is that this can fail if our database collation changes to something that supports case sensitivity.


Hmm that's weird, I ran `npm install`, but I still had to install those packages myself.


Boom! Thanks!


o_O. where is this documented ?


you know what. fuck it.


Can you expand this acronym or explain in the comment on line 338 what OC stands for?


I would only specify that it *may* be software-emulated. I'd also move it to future-features for now, but otherwise I like quad double.


In the future, I think it's more helpful to add the failing test prior to your changes because it shows the previous and proposed emits. That way, you and your reviewers can verify the difference.

The workflow I usually use is:

1. Create failing tests
2. Accept baselines
3. Make changes
4. Accept baselines
5. Go to 3 until you get appropriate :+1:s

Though, nobody else does this so feel free to not do anything described here.


What about changing primary or secondary constructor visibility?


Merged here right now : everything is OK !


@sultanxda i'm going to update the ui of this app soon, since it's going to be used as cm app :)


PropertyDataFetcher is already magic imo (same magic that Jackson/etc use) so its expected.

Just seems weird to add something to the builder for this as its already represented w/ `.dataFetcher`

I guess I would keep the same default from before, and include this as an optional DataFetcher for people to use.

I also wrote a CompositeDataFetcher that takes a list of data fetchers and calls them in sequence until it finds a non-null value which I could upstream if there is interest.


Yeah I know, a very bad name for a stable-release branch :expressionless:


I'll add new tests.


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1343 of 1343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ok, I'll revert the corresponding changes.


yup!
commit: changed my find-longest-word-function to use string.prototype.split


Language please.

Documented? Where is documented everything else :-)


I am interested in potentially merging this into TurboVNC.  Can you provide more details as to what specific issues it addresses?  When I recently finished adding VeNCrypt support to our server, I started exercising SSLEngineManager in the viewer more, and I didn't notice any performance problems.


What do those icons represent? I'm curious!


@refractalize I don't mind if you decide not to add anything of this there, I just thought I could have used that information a while ago.


Thanks for the explanation.

Yeah, haha. :P


omg i missed the "warning block"

About hiding its only about all case when we have something like
fread(..,size,.) and we dont realy need to check if size is same to the returned by function size.


 @janisozaur, there is nothing wrong in passing arguments by value in general, except inefficiency.
But here we should always create a copy of |path| to modify it's content. That's why efficiency wouldn't be damaged at all.


1.9.0-MinorFixes (macumber) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


What about function, val visibility changed?


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1343 of 1343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why is this a field and not a tag?


For anyone wondering: even though I've managed to build them all on my Linux machine so I could test this commit, not all the tools in the contrib folder (extractor, vmap_extractor, mmap, etc) actually build nicely out of the box on *nix systems yet. But we're working on that, so stay tuned!


Same as above.


I already changed it to something that should work better.


It looks like you are using them as tags. Why not rename them to be tags*?


# is not in the list of valid characters for class names or id, which forces to make a  custom syntax templating. Was trying to make it work all evening yesterday, somehow did not work.
I do exactly the same thing now as you described - template for new gene or variant row is loaded once on initialization and then filled with data each time, the only difference is that custom tamplating is implemented with regural .replace(), which allows optimized search for multiple regexes, same as evaluate.


Not a huge fan of doing the exact same thing in the rescue block because the control flow is nonobvious. Wouldn't this just exception out of the process if it fails?


You already have ClassWithFunAdded, ClassWithFunRemoved, why do you need to duplicate it?


Used for new AirSend Apps


The generated documents (included in this PR for reference, primarily) were created by invoking `gulp markdown`. Ideally the ToC's would be generated during the Travis build and published on swagger.io. But folks that refer to the GitHub doc as their primary reference point wouldn't have a ToC. But you can't please all the people, I suppose.


Why is this required?


Right, that's what I think too. Thanks.

I think @ramapcsx2 says that with this new 59.94 rate for progressive, VP2 intro video has more audio issues than when it's 60, it could also be timing issues elsewhere, and I also think that progressive should not be 60 flat.


Another interesting case would be changing var to val.


I am a nice comment


Pourquoi nous faites~vous cela
Ça vous amuse??


I made a small utility function a little while ago for combining class names. Perhaps you can use it.
```js
function combineClassNames(...classNames) {
  return classNames.map((value) => {
    if (!value) {
      return value;
    }

    return Array.isArray(value) ?
      combineClassNames.apply(void 0, value) :
      value;
  }).join(` `).replace(/ +/g, ` `).trim();
}
```
It combines both arrays and strings, and strips excess spaces.

It is totally overkill for this, but you could maybe use part of it like this:

```js
vtree.property.className = [vtree.property.className, scope].join(` `).replace(/ +/g, ` `).trim();
```


Assim que chegar em casa, farei os cálculos. Obrigado.


> If we ever add `plugin_idle_add_full()` to provide a deleter function for the container/data, it would be nice here to get rid of the _extremely_ unlikely case where the plugin is somehow unloaded before the idle handler is run and container is leaked.
As you say, it is quite unlikely to happen and even if, the leak is
rather small. Still, true.


@DavidArenburg  I was just following the format of `check.names` [in `data.table`](https://github.com/Rdatatable/data.table/blob/master/R/data.table.R#L324), though now I see we go so far as to use `isTRUE(as.logical(check.names))` [in `fread`](https://github.com/Rdatatable/data.table/blob/master/R/fread.R#L97). Pretty easy fix.


Why add machineName tag here and in batchPoints below?


oh, in that case then i'm not sure what's going on... I'll mention the thing about node_modules/.bin though


#4402-VRF-outputs-and-multiplied-floor (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Do you want to encode the hostname as well?


all good


cli-documentation-fixes (nealkruis) - i386-Windows-7-VisualStudio-12: OK (1879 of 1879 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Does this make it possible to also get https urls to images? Currently I get links like this:

["http://image.tmdb.org/t/p/h632/rX4LRmkYshMRfQ6lVbeZVAfqVKI.jpg", "http://image.tmdb.org/t/p/h632/mv2DgT9RABBYCxOY4ZHYalYBiUt.jpg", "http://image.tmdb.org/t/p/h632/eZBAmGqwG2q2bFWD3xLTLt69QAb.jpg", "http://image.tmdb.org/t/p/h632/fxOwiq2A41huXU9ltq4zAhpSiEG.jpg"]


Oh, pitty.
May I ask why (so suddenly)?


Fixes both TECG-130 and TECG-121 bugs


Just curious: Is this the case even with the latest InfluxDB clients?


Interesting


Duplicate? ClassWithFunAdd is in old.kt & new.kt only, I think.


I'll add it.


I also think it's good to mention how to start the tests, as when you run `karma start` it just starts the web server and connecting to it there is no button on anything to start the tests. I had to search Stack Overflow for the run command.


You probably have one of the more challenging movements. The idea of implementing optical illusion and visual experimentation within a functional of web page are daunting. Which is why I think option #1 may be your best bet. It ties in the Bauhaus roots and still evokes the discordance and visual friction of op art but does it in a clean, legible way. I also find the palette and font choices on #1 grounding but appropriate.


i got some build errors  on serial after
git pull
npm install
https://gist.github.com/luxus/b1657fa1c37b6a0d72e3


Seems this can be a shared middleware.


See [forum](http://community.smartstore.com/index.php?/topic/47270-best-aproach-for-a-new-kind-of-dashboard/)


#4402-VRF-outputs-and-multiplied-floor (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1874 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


Probably done a little simpler with lodash.


There is a english typo in the "should" word


Nit: typo in `THese`.