1. This does not fix 428, it fixes wires sometimes not being removed at all. I encountered the bug described in 428 with this fix yesterday. Unless changing it to run at tick start changes anything, which i dont  think
2. Please dont pr this, i am working on a pr (hopefully done today) that edits immersivenethandler as well, it contains this fix in a local commit already, and i dont think blu wants to deal with merge conflicts


@soulf


habe reverted und im commit 2b4a1bca2cc0ed91e55ccf91807b1b5c8844791b sollten nun alle am Modelwizard gemachten  Änderungen sichtbar sein.


Don't we want to change that one to https://github.com/scaleway-community/scaleway-camlistore now ?


Submitted an issue here: https://github.com/golang/go/issues/12663


对于直接注释掉的bosen新增的内容有些不确定


> how do other languages cope with this?

In haskell 'union' is left biased, if you want something else you use 'unionWith' and provide a merging function:

    union :: Ord k => Map k a -> Map k a -> Map k a

O(n+m). The expression (union t1 t2) takes the left-biased union of t1 and t2. It prefers t1 when duplicate keys are encountered, i.e. (union == unionWith const). The implementation uses the efficient hedge-union algorithm.

    union (fromList [(5, "a"), (3, "b")]) (fromList [(5, "A"), (7, "C")]) == fromList [(3, "b"), (5, "a"), (7, "C")]

    unionWith :: Ord k => (a -> a -> a) -> Map k a -> Map k a -> Map k a

O(n+m). Union with a combining function. The implementation uses the efficient hedge-union algorithm.

    unionWith (++) (fromList [(5, "a"), (3, "b")]) (fromList [(5, "A"), (7, "C")]) == fromList [(3, "b"), (5, "aA"), (7, "C")]


They're different concerns, I don't think they should be merged. If, for some reason, you have a non-nil response, but a nil status, then this would reflect that.


Ola


LGTM


Awesome!!


Shouldn't this be `contains("node")`?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@condret Thanks. I'm having some issues in trying to understand how to document esil. I noticed that you are using reverse polish notation, but I'm not sure how to document flags and other stuff.

I'm using this guide: http://the-dreams.de/aay64.txt  I trust that info. It is based on the official C64 programmers guide, and also includes more info... like the 65816 opcodes.

The opcodes are divided in two: documented vs. undocumented. And I'm only working on the documented ones.
Legends of the guide:

- A,X,Y: are general purpose registers.
- M: memory
- /\:  bitwise-and (&)
- V:  bitwise-or (|)
- eor: bitwise-xor

Flags:
   C: Carry
   Z: Zero
   N: Negative
    I: Interrups enabled/disabled
   D: decimal mode on/off
   V: overflow

It might make sense to copy the work that I'm doing on anal_6502.c and paste it anal_snes.c
And only include in the anal_6502.c  the undocumented opcodes, and treat them as undocumented.
Similar to `asm_6502.c` / `asm_snes.c`.


@fabricioflores cómo hacen lint en grubhub?


Please replace with:
`val currentInputs = mapInputsOutputs.filter(x => x._1 == FragmentType.input)`


Without ReadFull we got MANY failures running unit tests as we would not always get back the number of bytes requested.  rand.Reader was not doing ReadFull as when running the units we would get back say 8 or 8 bytes when asking for 12.


maldito javascript
cc @fabricioflores


Hi there,

Thanks for trying out Buildtime Trend!
I noticed you enabled the Buildtime Trend webhook in Travis CI to analyse the build process data and timings of your project.

If you have questions or feature requests, don't hesitate to ask. We have a mailing list and a twitter account where you can reach us : https://buildtimetrend.github.io/#contact

I'm also interested to hear why you started using Buildtime Trend, what your expectations are, or how you found out about Buildtime Trend.

I hope you find using Buildtime Trend useful and that it can help you gain some insights about your build process!

Kind regards,

Dieter
Buildtime Trend founder and developer


Exciting idea!


readme


why not to use Semaphore?


Please replace with:
`if(currentInputs.isEmpty && !apConfig.input.isDefined) {`


Wurde im commit 2b4a1bca2cc0ed91e55ccf91807b1b5c8844791b behoben


\xD/


And back to `1.0.0` huh.


Thinking maybe this commit should be reverted.


:shipit:


Class AuthServiceProvider does not have a Docblock comment.


There is two pass with the first locator. The first pass adding the RTR's RLOC without passing to the next locator in the list. The second pass adding it's own private address.


How in the world did you figure this out?


Hi @MtnBiker please look at this link. There are 3 maps so far- http://maptimela.github.io/old-la-restaurants/


Oh, yeah that works. Otherwise I was thinking of later on making the TLD part of the url configurable in the settings and submitting a pull reqest. But maybe that's unnecessary?


Glad to be of help :D


Should probably better be `Errors`, as it is used as a constructor function with `new`.


For a moment, the count that's returned from the tabManager can be zero because this delegate method is called BEFORE we add a new tab if we've reached zero tabs: https://github.com/mozilla/firefox-ios/blob/sleroux/Bug1201501-PBModeTabTray/Client/Frontend/Browser/TabManager.swift#L294. I'm not sure if I should reorder this in tabManager or leave it as is with the max.


@arjenvrielink Is het dit?


:mod:`trappy.run.Run`


It would be good to have a weak reference to strongSelf so that it is not retained by dispatch_async on to the main queue


What about tearing down the objects you intiated?
public void tearDown() {
 test = null;
}


@themotionclub Could you upgrade to v2.4.5 and let us know if it works again?


@macool ellos usan grunt. Este proyecto tiene gulp. Yo configuré en Niara con gulp-lintspaces


Thanks for the answer. :)


It's a very specific case, we're running it in Chromium Embedded Framework with a fake hostname. :)


Awesome


A webpage I had to create for an assignment


The errors module only exports an object containing constructors. As by convention only the constructors are in CamelCase, so lower case errors is IMHO the better fit.


I like changing to to computeFromStack and computeFromStackTrace. We are not leaking the element because it's defined on line 732.


```java
{[r=0,c=0]|g:10000|r:3|h:5|b:f}		{[r=0,c=1]|g:10000|r:2|h:5|b:f}	{[r=0,c=2]|g:1|r:1|h:5|b:f}		{[r=0,c=3]|g:0|r:0|h:5|b:f}+++
{[r=1,c=0]|g:10000|r:10000|h:4|b:t}	{[r=1,c=1]|g:2|r:2|h:4|b:f}	{[r=1,c=2]|g:10000|r:10000|h:4|b:t}	{[r=1,c=3]|g:1|r:1|h:4|b:f}+++
{[r=2,c=0]|g:10000|r:10000|h:3|b:t}	{[r=2,c=1]|g:3|r:3|h:3|b:f}	{[r=2,c=2]|g:10000|r:10000|h:3|b:t}	{[r=2,c=3]|g:2|r:2|h:3|b:f}+++
{[r=3,c=0]|g:10000|r:10000|h:2|b:t}	{[r=3,c=1]|g:4|r:4|h:2|b:f}	{[r=3,c=2]|g:10000|r:10000|h:2|b:t}	{[r=3,c=3]|g:3|r:3|h:3|b:f}+++
{[r=4,c=0]|g:10000|r:10000|h:1|b:t}	{[r=4,c=1]|g:5|r:5|h:1|b:f}	{[r=4,c=2]|g:10000|r:10000|h:2|b:t}	{[r=4,c=3]|g:10000|r:4|h:3|b:f}+++
{[r=5,c=0]|g:6|r:6|h:0|b:f}		{[r=5,c=1]|g:10000|r:6|h:1|b:f}	{[r=5,c=2]|g:10000|r:6|h:2|b:f}		{[r=5,c=3]|g:10000|r:10000|h:3|b:f}+++
```


Thanks for the explanation. I've changed our configuration files to use 127.0.0.1 instead so as to not trigger the check.


@paulathevalley -- Mind giving me your opinion of my attempt at a quick blackbox wrapper for text on a non-darkened background image?

<img width="1202" alt="screen shot 2015-09-17 at 7 41 44 am" src="https://cloud.githubusercontent.com/assets/445557/9936198/a6d02b0a-5d0f-11e5-9282-56b24bd81d87.png">


So far, this new loot system looks good. :+1:


Argh, expand tabs wasn't turned on.


You're right; it's rand.Read that does the ReadFull.


@md5 Thanks for pointing that out.  Looks like it is fixed now.


@jshrake I'm unclear what you mean, as we have set that to 3 params now?


I have reviewed you pull request and it seems fine to me. The code looks cleaner now that the blocks of code are put together in a method. Could you please run maven build and fix the checkstyle warnings and add missing javadoc for the new methods?


LGTM :shipit:


I'm scared of remembering operators' precedence and associativity ;)


Neither do it lol. Want help making plugins?


This code looks correct


Fully agree.

This is part of why I don't contribute to minetest_game much.


This commit has been updated and squashed just now. Please update again if it has not be made yet.


Makefile is Done.

I also created a pull request.  your compile.sh script was the final piece,
tested the code, and it seems to be working.  Working on setting up the gdb
environment for debugging with gcc, but that should be pretty
straightforward from here.

I followed the nrf51 SDK convention a little with creating a _build folder,
and there is no longer a need to copy the source files out of the external
projects into the local directory under the project with the makefile.

Let me know if you have any questions.  I removed some extra include
directives which were not hurting the build, but were not being used.
Added makefile suffix rules, and Vpath directives based on your compile.sh
script.  I can probably refine it a bit more, but wanted to check this in
since it is working at this point.

I am thinking of creating am installation script to build the nrf folder
tree so you can automate standing up an environment and avoid the license
issues with replicating code, but the workshop class around our BLE mesh is
in 3 weeks (Chicago area), so I am going to focus a bit more on tutorial
work.  tutorial will likely be around propogating a button press event
through the mesh, and if i have more time to drill into your mesh code,
maybe an app that can read proximity of neighboring devices and exchange
information with the closest nodes.

We also plan on building some gateway code to connect multiple meshes
across different offices together.  Andy McWilliams (
https://www.linkedin.com/in/amcwill) is going to be focusing on that so any
pointers you have on using the dongle and its host as a internet gateway to
relay messages to and from the web to the mesh would be helpful :)

Thanks again Marius.  Great work.  I noticed you were doing some
experimental encryption.  There is a backlog item for someone to look at
how we might bolt telehash onto your mesh.  I have not looked at anything
you have done around encryption yet, so maybe you are already headed that
route?  This weekend and next week should be more fun as I will start
playing with the modules and digging into the mesh code a bit more.
Finally freeing up a little from billable work...

Tim

On Thu, Sep 10, 2015 at 5:30 AM, Marius Heil <notifications@github.com>
wrote:

> Hi,
> have you been successful with the makefiles? I've merged a pull request
> with Linux compatibility but if you have a makefile, I'd like to add that
> to make the process smoother. I've just added nRF52 compatibility as well.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mwaylabs/fruitymesh/commit/45b932a0c7eb9fff6bd907b235e3e903abf027fc#commitcomment-13155264>
> .
>


:+1: (I didn't want to nitpick before...)


Merged :heart:


I like those better than what I had.

They could also be namespaced or the signature could changed
computeStackFrom(e.stacktrace)
computeStackFrom(e.stack)
On 17 Sep 2015 07:42, "Blake Niemyjski" <notifications@github.com> wrote:

> I like changing to to computeFromStack and computeFromStackTrace. We are
> not leaking the element because it's defined on line 732.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/csnover/TraceKit/commit/6e886ab174e090cb1b8c2c820e7eda3b97513412#commitcomment-13289268>
> .
>


dc


This change leads to client crashes on exit for me.
gdb:
Program received signal SIGSEGV, Segmentation fault.
0x0043910e in free_emote_data (data=0xe0ca340) at actor_scripts.c:2593
2593                                    for (frame = head, tf = head->next; frame; frame = tf, tf = tf->next)
(gdb) bt full
#0  0x0043910e in free_emote_data (data=0xe0ca340) at actor_scripts.c:2593
        emote = 0xe0ca340
        head = 0xe149048
        frame = 0x0
        tf = 0x0
        i = 0
        j = 0
        k = 0
#1  0x00448d6e in destroy_hash_table ()

valgrind:
==5402==  Invalid read of size 8
==5402==    at 0x41C785: free_emote_data (actor_scripts.c:2593)
==5402==    by 0x54C5FF: destroy_hash_table (hash.c:39)
==5402==    by 0x41D5B6: free_emotes (actor_scripts.c:2825)
==5402==    by 0x4B357A: start_rendering (main.c:267)
==5402==    by 0x4B3C50: main (main.c:467)
==5402==  Address 0x28 is not stack'd, malloc'd or (recently) free'd


Onward and upward!  :shipit:


Actually nope, no it does not :scissors:


hi :</>


Ja hier wurde tatsächlich nicht wirklich etwas integriert, sondern vielmehr neuhinzugefügt und zwar das gesamte Template-Plugin.
Außer der Konfigurationsdateien wie plugin.xml, MANIFEST.MF, .classpath, .project ist da nix geblieben und auch diese wurde fast vollständig ersetzt, da das Plugin vorher mehr eine PLatzhalterrolle hatte, ohne Logik zuenthalten.


You don't need the line spaces between the listings, I remember you asked me the question, may be you got me wrong, I meant, a line space from the previous paragraph to the new list, e.g.

We have this para, then

* this
* lists
* etc


Ship it :shipit:


note: python convention is to use `underscore_case_for_variables`, not `camelCase`


I'm guessing we overrode this at some point (??)


Do we need to include the logging level in each method name? It makes the method name unnecessarily verbose IMO since we have already have the level in the ```@LogMessage``` annotation.


Huh.  Maybe this, too?


Usually longer comments like this are wrapped in triple-quotes, instead of `#`


Nice, I missed the #features section. :sob:


Merged


The whitespace after the `:` is important here, otherwise your error message will look strange:
```
Error example:it shall look like this
```

Can you fix this on the line above and all other occurences below?


This is probably the easiest thing to do, but we'll need to change the mllp code in redox. It makes things simpler there though, so I'm for this. Just gotta test it out.


Well, if the only different part is a TLD, it will be much easier. Otherwise, some mapping for TLD -> URL can be created.
Feel free to send PR :)


@MatSchaeff ca posait des problemes ca


YESYUH


Class AuthServiceProvider does not have a Docblock comment.


superseded by a later re-vendoring


* TODO: rewrite this as it is doing way too much and is very messy now.


> `#define PCAP_DONT_INCLUDE_PCAP_BPF_H`

I'd avoid tricks like that. It is better to change `Packet32.h` as I did here:
https://svn.code.sf.net/p/winpcap413-176/code/trunk/Common/Packet32.h

Then you do not need bother about header file inclusion.


Do you know if there is any way that we could inject the logger maybe using a CDI provider?


The reason I had this stuff below was that I was concerned we could receive data before the `data` handler was setup. Or an error would occur before the `error` handler was setup. So I setup the handlers first, then did the connection if necessary.

But if you don't think that could happen, I'm happy with this. Thinking about the node event queue, it seems like the handlers should be setup before any event was triggered, but I just wasn't 100% confident.


LGTM :shipit:


Yes, that's right.
Thank you both. I will deal with it.


I have concerns with this approach:

 * It relies on iquery being installed on the client machine, instead of using SciDB-Py's normal mechanism of using the shim

 * This will raise an exception of the command fails. You shouldn't need a connection to SciDB in order to import SciDB-Py (for instance readthedocs won't be able to build the docs with this code)

 * This work should probably be done if + when the user establishes a connection to scidb.

 * It should perhaps also be redone when a user loads a new plugin


which *is* generated


Any idea when this will get rolled into an officially released version of this plugin and placed into the NPM registry? We have several Intel XDK customers that have reported issues with this problem on Android devices, it would sure be nice to get it rolled into the registry.


MiscReleaseFixes (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1880 of 1880 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


nit: `operator_list`, not `operatorList`


filter


1: M111 unrecognized component name: kwalitee


1: M111 unrecognized component name: tests


Use lodash I think


@tdreyno I need your help again - sorry! Any idea why my tests are always passed?

For example:

```cucumber
Feature: Google Analytics tag helper

  Scenario: Basic tracking code
    Given the Server is running at "basic-app"
    When I go to "/google-analytics.html"
    Then I should see:
      """
      <script type="text/javascript">
        var _gaq = _gaq || [];
        _gaq.push(["_setAccount", "UA-123456-78"]);
        _gaq.push(["_trackPageview"]);
        (function() {
          var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
          ga.src = ('https:' == document.location.protocol ? '//ssl' : '//www') + '.google-analytics.com/ga.js';
          var s = document.getElementsByTagName('script')[0]; s.parentNode.insertBefore(ga, s);
        })();
      </script>
      """
```

When I change `When I go to "/google-analytics.html"` to `When I go to "/foo.bar"` then the test is still passed. Same with `Then I should see:` ...

:confused:


With you now working on ccminer, I hopefully will never need to "help" again!
I believe the "time-limit" with benchmarking turned on now displays funny, due to it using "fprintf".  If you could fix that it would be appreciated, b/c as this lesson has shown us, I certainly can't.


Could use `x10.util.RailUtils.reduce` here


forked it


Beide Packages werden Template-Plugin benötigt:

-org.bflow.toolbox.hive.interchange.utils
die ModelDigger-KLasse wird zum Einlesen von EPC-Dateien die MEthode resolveModelData(File sourceFile) benötigt

-org.bflow.toolbox.hive.interchange.commons
wird  zur Offscreen-Erezugung von EPC-Diagram-Vorschaubildern genutzt
getOffscreenDiagramEditPart(Shell shell, IFile file)


Could use `x10.util.RailUtils.scan` to compute offsets


yes.


Yes, sure. I could not test it 'cos I could not run js stuff.


Duplicate of lines 276-279 - should be moved up to `scatter` method (and made unconditional).


MiscReleaseFixes (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1344 of 1344 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.24%25-green.svg)


Bitte diesen Commit mit dem Commit c77ef7e squashen.


What happened to good faithful IRC for meetings and planning, this allows everyone to be a participant and not just developers. The mailing list is fine for slow messaging but if you want input from people plan a monthly or every two month irc meetup.

I know i haven't contributed in a long time on flyspray but this is a dick move and would easily fork with a rebranding if this was left in. There are plenty of instances out there where this is not okay. Look at other projects and see how things are done for planning and communicating with the community.

Worrying about revenue is not how open source works. Set Up a donations page but dont force ad system on installs...that turns into shareware crap. I bet you could find volunteers via reddit and other social media platforms, i always see posts on looking for an open source project to work on.


**General**
- Fix your GitHub identity, make sure your `config user.email` matches your email on GitHub, I suspect the one you are using now is Andela's while the one on GitHub is your GMail.


Bitte entferne die überflüssigen Zeilenumbrüche.


`.js` in `require` is redundant.


I am okay with excluding this commit. But without that also the coverage would be the same right?


Can you explain why you placed the logging of the Player movement in this method? I think this could work the right way, would just like some clarification though.


This one was brought in as a dependency of `ark`, I believe.  LGTM :shipit:


dependency of a dependency :shipit:


@chochos I need you to improve this impl. I'm not sure what were all the possibilities you were trying to match, and I'm not sure how to use a JS regex in a `dynamic` block.


:+1: Exactly how I would've done it.


Same here, everything seems fine excpet for the checkstyle errors.
< layout


Merged :smile:


Ich würde dies weglassen, da es verschiedene Wege gibt, `virtualenv` auf dem Computer zu installieren.


Unnecessary. If you require mongoose and then do `mongoose.model('Product')`, because it has already been registered, you will gain access.


Tippfehler in "viertualenv".


`bodyParser` is already running on every route -- check `server/app/configure/parsing-middleware.js`


Class AuthServiceProvider does not have a Docblock comment.


garnicht :-D
alle unnützen Imports wurden im commit 62f0178bfc7f0337119789ec7ae926942170420f entfernt


script 작업으로 여러학과 array 모으는 작업해야한다. 아직 안함.


Ich würde `mkproject` und `workon` nicht aufnehmen, da du sonst noch beschreiben muss, dass man auch noch `virtualenvwrapper` auf dem Computer installieren muss.


**ReadME/Comments - Critical**
- Your ReadMe should be more descriptive, provide context, etc. Perhaps referencing the checkpoints document.


Theunderstated,

I agree that Git integration is important, but it is also a lot of work. If
there was revenue coming in that could fund a developer to do it. Unless of
course you want to implement it... I prefer ads and more functionality to
no ads and no git integration. No point in beating a dead horse further
with this discussion though.

_________________

Jordan Mendler
President & Chief Technology Officer
The Veloz Group | www.thevelozgroup.com
On Sep 17, 2015 3:00 AM, "theunderstated" <notifications@github.com> wrote:

> I hope no one minds if I comment but as an avid user and supporter of
> Flyspray I feel slightly downhearted that after the great efforts made by
> the various contributors that the project now finds itself at a cross
> roads. I have watched over the past few months how the project has become
> more fragmented as people have struggled to meet the requirements set by
> the volume of work. This has had the knock on effect that the deadlines
> contributors have tried hard to meet have come and gone increasing the
> stress levels of all involved. The argument over fundraising, in this
> instance, using adverts has clearly hit a raw nerve and given rise to a
> whole heap of pent up emotions clearly showing just how much stress and
> frustration there is within the group. So this argument in one way or
> another was always going to happen. My personal feelings about this whole
> thing is:-
>
> the inclusion or validation of 'ads' in the software should be consigned
> to a separate fork for testing out these and other ideas. I'd probably
> prefer that you spent the time on closer integration with Git and
> Subversion and doing a plugin for Visual Studio so that I don't have to
> keep telling people that Flyspray is better that TFS and them saying but
> it's not integrated with the rest of the development environment, etc,etc.
>
> the work that people are already committed to doing needs to finished off
> or at tied off so that it is at least usable if not completed to the full
> specification.
>
> I do also feel that some of leading contributors do actually need a
> 'holiday' away from the project for a week or so. Tempers are frayed
> currently so now would be good time to have a break and then to come back
> and to have the discussion about moving the whole thing forward.
>
> In short - don't let your hard work and good intentions go to waste having
> invested so much time and energy and have come so far.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Flyspray/flyspray/commit/b889759b1805196a5a22de7501b99408f4bd6cd1#commitcomment-13282753>
> .
>


:goberserk:


Did we add SASL?


@lavalamp I would particularly ask if the `pkg/client`->`pkg/client/unversioned` changes are the right thing. Everything else easy/obvious....


You changed this line by mistake.  Keep `dfr` as it is.


AFAICT the [old impl](https://github.com/ceylon/ceylon.language/blob/a02c660780f5de3b756e29e7a77b77f8fd573daa/runtime-js/runtime/name.js) should be equivalent to
```ceylon
path.endsWith("node")
    || path.endsWith("nodejs")
    || path.endsWIth("node.exe")
    || path.endsWith("nodejs.exe")
```
which doesn’t seem too long to me, and might even be faster than the regex.


This is fine, but something to note: `Product.find()` doesn't return an actual promise, despite having a `.then`. Using `Product.find().exec()` is a bit safer.


Das ist nicht nötig, da es ja bereits ein `.gitignore` im Repo gibt.


Unfortunately, that wouldn't be a simple fix as the tag parser uses `"` as a control character. So, it would involve a bit of a redesign for how the parser behaves and I wouldn't have the time to do that in the near future.


Thanks, I was just about to do this in fact :)


sdfghj


Merging it


Pointless line. Probably in your linter.


obviated by later vendoring of memcached 1.8.0


Could be moved inside conditional for `DEBUG_INTERNALS` three lines down


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#H0UtKFXuR2CDubwF9VEZGw


`User`?


I wonder if this is going to be terrible performance? Looking in `get_related_resource_type` I see this:
``` python
    if hasattr(relation, 'get_queryset') and relation.get_queryset() is not None:
        relation_model = relation.get_queryset().model
```
which at first glance makes me think it's making two queries per record.


Why `next()`?


um, seems a few things are missing from your published version, `ntp`


user?


Should be `WP_Post`


A little late there, given I'd got it working in another commit right after this. A note on whether the current take on it works as intended would be more helpful. ;w;


`_.merge/extend/assign` from lodash is a lot simpler, but simplest is using mongoose `findByIdAndUpdate`.


Scott,

Do you want to volunteer to code git and subversion integration, proper
timesheet tracking, and doing a rewrite of flyspray with a more
maintainable MVC architecture? Those are just some of the things we've been
talking about for years that still never got done because people aren't
motivated to work for free.

_________________

Jordan Mendler
President & Chief Technology Officer
The Veloz Group | www.thevelozgroup.com
On Sep 17, 2015 8:03 AM, "Jordan Mendler" <jordan@thevelozgroup.com> wrote:

> Theunderstated,
>
> I agree that Git integration is important, but it is also a lot of work.
> If there was revenue coming in that could fund a developer to do it. Unless
> of course you want to implement it... I prefer ads and more functionality
> to no ads and no git integration. No point in beating a dead horse further
> with this discussion though.
>
> _________________
>
> Jordan Mendler
> President & Chief Technology Officer
> The Veloz Group | www.thevelozgroup.com
> On Sep 17, 2015 3:00 AM, "theunderstated" <notifications@github.com>
> wrote:
>
>> I hope no one minds if I comment but as an avid user and supporter of
>> Flyspray I feel slightly downhearted that after the great efforts made by
>> the various contributors that the project now finds itself at a cross
>> roads. I have watched over the past few months how the project has become
>> more fragmented as people have struggled to meet the requirements set by
>> the volume of work. This has had the knock on effect that the deadlines
>> contributors have tried hard to meet have come and gone increasing the
>> stress levels of all involved. The argument over fundraising, in this
>> instance, using adverts has clearly hit a raw nerve and given rise to a
>> whole heap of pent up emotions clearly showing just how much stress and
>> frustration there is within the group. So this argument in one way or
>> another was always going to happen. My personal feelings about this whole
>> thing is:-
>>
>> the inclusion or validation of 'ads' in the software should be consigned
>> to a separate fork for testing out these and other ideas. I'd probably
>> prefer that you spent the time on closer integration with Git and
>> Subversion and doing a plugin for Visual Studio so that I don't have to
>> keep telling people that Flyspray is better that TFS and them saying but
>> it's not integrated with the rest of the development environment, etc,etc.
>>
>> the work that people are already committed to doing needs to finished off
>> or at tied off so that it is at least usable if not completed to the full
>> specification.
>>
>> I do also feel that some of leading contributors do actually need a
>> 'holiday' away from the project for a week or so. Tempers are frayed
>> currently so now would be good time to have a break and then to come back
>> and to have the discussion about moving the whole thing forward.
>>
>> In short - don't let your hard work and good intentions go to waste
>> having invested so much time and energy and have come so far.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/Flyspray/flyspray/commit/b889759b1805196a5a22de7501b99408f4bd6cd1#commitcomment-13282753>
>> .
>>
>


WAT


Don't need this.


cc @vcunat do you like this? Or it's better to use a regex to update default.nix? Not sure if I like more a regex or a separate file for autoupdating packages.


unique


Using JSONB may be quite an overhead, see http://adpgtech.blogspot.ru/2015/09/when-to-use-json-and-when-to-use-jsonb.html

Also it might be better to have table column crossbar.meta.value defined as JSON if we don't need heavy indexing on it.


OK. I think I understand it about as well as I am going to until I spend some quality time with the import functionality. :+1:


You guess wrong.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (805 of 805 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.92%25-green.svg)


You didn't create a pull request. Is this change ready for merging?


LGTM :shipit:


Merged


None of the following routes use `userID` as a param, so what's the point?


And PS, it's good to hear from you scott. If you're still in the southwest,
we should catch up for a beer some time

_________________

Jordan Mendler
President & Chief Technology Officer
The Veloz Group | www.thevelozgroup.com
On Sep 17, 2015 8:07 AM, "Jordan Mendler" <jordanmendler@gmail.com> wrote:

> Scott,
>
> Do you want to volunteer to code git and subversion integration, proper
> timesheet tracking, and doing a rewrite of flyspray with a more
> maintainable MVC architecture? Those are just some of the things we've been
> talking about for years that still never got done because people aren't
> motivated to work for free.
>
> _________________
>
> Jordan Mendler
> President & Chief Technology Officer
> The Veloz Group | www.thevelozgroup.com
> On Sep 17, 2015 8:03 AM, "Jordan Mendler" <jordan@thevelozgroup.com>
> wrote:
>
>> Theunderstated,
>>
>> I agree that Git integration is important, but it is also a lot of work.
>> If there was revenue coming in that could fund a developer to do it. Unless
>> of course you want to implement it... I prefer ads and more functionality
>> to no ads and no git integration. No point in beating a dead horse further
>> with this discussion though.
>>
>> _________________
>>
>> Jordan Mendler
>> President & Chief Technology Officer
>> The Veloz Group | www.thevelozgroup.com
>> On Sep 17, 2015 3:00 AM, "theunderstated" <notifications@github.com>
>> wrote:
>>
>>> I hope no one minds if I comment but as an avid user and supporter of
>>> Flyspray I feel slightly downhearted that after the great efforts made by
>>> the various contributors that the project now finds itself at a cross
>>> roads. I have watched over the past few months how the project has become
>>> more fragmented as people have struggled to meet the requirements set by
>>> the volume of work. This has had the knock on effect that the deadlines
>>> contributors have tried hard to meet have come and gone increasing the
>>> stress levels of all involved. The argument over fundraising, in this
>>> instance, using adverts has clearly hit a raw nerve and given rise to a
>>> whole heap of pent up emotions clearly showing just how much stress and
>>> frustration there is within the group. So this argument in one way or
>>> another was always going to happen. My personal feelings about this whole
>>> thing is:-
>>>
>>> the inclusion or validation of 'ads' in the software should be consigned
>>> to a separate fork for testing out these and other ideas. I'd probably
>>> prefer that you spent the time on closer integration with Git and
>>> Subversion and doing a plugin for Visual Studio so that I don't have to
>>> keep telling people that Flyspray is better that TFS and them saying but
>>> it's not integrated with the rest of the development environment, etc,etc.
>>>
>>> the work that people are already committed to doing needs to finished
>>> off or at tied off so that it is at least usable if not completed to the
>>> full specification.
>>>
>>> I do also feel that some of leading contributors do actually need a
>>> 'holiday' away from the project for a week or so. Tempers are frayed
>>> currently so now would be good time to have a break and then to come back
>>> and to have the discussion about moving the whole thing forward.
>>>
>>> In short - don't let your hard work and good intentions go to waste
>>> having invested so much time and energy and have come so far.
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/Flyspray/flyspray/commit/b889759b1805196a5a22de7501b99408f4bd6cd1#commitcomment-13282753>
>>> .
>>>
>>


This looks good to me.

I wonder if in the long-term we should consider including some of the publisher and licensing details which OCDS also includes in the package, but that would need CoVE etc. to support user-input of that information - so not important to get this sorted for now.


If I'm not mistaken, it should not get to this point because `hasattr(relation, '_meta'):` should be `True`.


sdfsdf


MiscReleaseFixes (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1879 of 1880 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Thanks for all the info. I'd be happy to help from a use-case and documentation perspective. I'll go make a few comments on #91.


That woudln't be nearly half as cute and remember:

```
Bad code < Good Code < Cute Code
```


Is this file ever required?


We don't need to check "nat_info->status != NO_NAT" since we want to process all locators the same way (regardless they are behind NAT or not).

As a side note, I believe that both your code and our code will have troubles with more than one RTR ;)


I have reviewed it and it seems fine to me, although I am having second doubts on the box field. I am not 100% sure if we will be using this field, but this isn't a fully completed class, so maybe it's better not to remove it yet. <feature


You're right, we missed that. Note that we should add the locators in order as specified in RFC6830

"The Locator-Set MUST be sorted in order of ascending IP
   address where an IPv4 locator address is considered numerically 'less
   than' an IPv6 locator address."


I figured out the issue, turns out I didn't know VM's didn't have a wifi adapter. Thank you for troubleshooting!


Amazing! :smile:


Oops, yes. I forgot the fact that this commit changes the very lines I referenced


Reviews are completed arbitrary embedded objects.


doesn't this apply "cursor:inherit" for:
- .list-group-item
- .list-group-item .badge
- .list-group-item i.fa

but it should only be applied for:
- .list-group-item i.fa
- .badge i.fa


Also notice how we can just reply to emails and it updates the thread on
github. That's another thing I'd love to see in flyspray that I don't see
getting built any time soon.

_________________

Jordan Mendler
President & Chief Technology Officer
The Veloz Group | www.thevelozgroup.com
On Sep 17, 2015 8:10 AM, "Jordan Mendler" <jordanmendler@gmail.com> wrote:

> And PS, it's good to hear from you scott. If you're still in the
> southwest, we should catch up for a beer some time
>
> _________________
>
> Jordan Mendler
> President & Chief Technology Officer
> The Veloz Group | www.thevelozgroup.com
> On Sep 17, 2015 8:07 AM, "Jordan Mendler" <jordanmendler@gmail.com> wrote:
>
>> Scott,
>>
>> Do you want to volunteer to code git and subversion integration, proper
>> timesheet tracking, and doing a rewrite of flyspray with a more
>> maintainable MVC architecture? Those are just some of the things we've been
>> talking about for years that still never got done because people aren't
>> motivated to work for free.
>>
>> _________________
>>
>> Jordan Mendler
>> President & Chief Technology Officer
>> The Veloz Group | www.thevelozgroup.com
>> On Sep 17, 2015 8:03 AM, "Jordan Mendler" <jordan@thevelozgroup.com>
>> wrote:
>>
>>> Theunderstated,
>>>
>>> I agree that Git integration is important, but it is also a lot of work.
>>> If there was revenue coming in that could fund a developer to do it. Unless
>>> of course you want to implement it... I prefer ads and more functionality
>>> to no ads and no git integration. No point in beating a dead horse further
>>> with this discussion though.
>>>
>>> _________________
>>>
>>> Jordan Mendler
>>> President & Chief Technology Officer
>>> The Veloz Group | www.thevelozgroup.com
>>> On Sep 17, 2015 3:00 AM, "theunderstated" <notifications@github.com>
>>> wrote:
>>>
>>>> I hope no one minds if I comment but as an avid user and supporter of
>>>> Flyspray I feel slightly downhearted that after the great efforts made by
>>>> the various contributors that the project now finds itself at a cross
>>>> roads. I have watched over the past few months how the project has become
>>>> more fragmented as people have struggled to meet the requirements set by
>>>> the volume of work. This has had the knock on effect that the deadlines
>>>> contributors have tried hard to meet have come and gone increasing the
>>>> stress levels of all involved. The argument over fundraising, in this
>>>> instance, using adverts has clearly hit a raw nerve and given rise to a
>>>> whole heap of pent up emotions clearly showing just how much stress and
>>>> frustration there is within the group. So this argument in one way or
>>>> another was always going to happen. My personal feelings about this whole
>>>> thing is:-
>>>>
>>>> the inclusion or validation of 'ads' in the software should be
>>>> consigned to a separate fork for testing out these and other ideas. I'd
>>>> probably prefer that you spent the time on closer integration with Git and
>>>> Subversion and doing a plugin for Visual Studio so that I don't have to
>>>> keep telling people that Flyspray is better that TFS and them saying but
>>>> it's not integrated with the rest of the development environment, etc,etc.
>>>>
>>>> the work that people are already committed to doing needs to finished
>>>> off or at tied off so that it is at least usable if not completed to the
>>>> full specification.
>>>>
>>>> I do also feel that some of leading contributors do actually need a
>>>> 'holiday' away from the project for a week or so. Tempers are frayed
>>>> currently so now would be good time to have a break and then to come back
>>>> and to have the discussion about moving the whole thing forward.
>>>>
>>>> In short - don't let your hard work and good intentions go to waste
>>>> having invested so much time and energy and have come so far.
>>>>
>>>> —
>>>> Reply to this email directly or view it on GitHub
>>>> <https://github.com/Flyspray/flyspray/commit/b889759b1805196a5a22de7501b99408f4bd6cd1#commitcomment-13282753>
>>>> .
>>>>
>>>


This is completely different.  I'm going to move our legacy copy to `./cookbooks/travis_php`.


Categories seems like it should be another model/document.


Sorry, mate.  I didn't mean to discourage you.  These days pull/compile/run isn't really sufficient testing in collaborative opensource dev, is all.  Lots of collaborators, lots toes to step on, etc.  It seems especially so in this cryptocurrency corner where code is pretty hack and review is basically non-existent.

Anyway, if you aren't up for it, I'll take a look at the time-limit logging after I figure out this VTC solo mining crash.  In the mean time, mind being a bit more descriptive with the problem?  Platform and command line at least?


required?


If you change the scale of "gain" here, don't you need to change it in the library as well ?


Yes, I think we will eventually want this information. I was very tempted to add publisher information at this stage, but it's possible we might change that in OCDS - https://github.com/open-contracting/standard/issues/245


Why is this not referencing Review model documents?


max/min


required


Hm, this place is strange.
It might work, but it's just strange — we're returning class instead of an instance.

(Returning `TrelloConnection.new` here won't work. We need a [test double](https://www.relishapp.com/rspec/rspec-mocks/v/3-3/docs/basics/test-doubles) here, maybe?)


http://www.lix.polytechnique.fr/coq/pylons/contribs/files/Pocklington/v8.4/Pocklington.fermat.html has
Theorem flt : ∀ (a : Z) (p : nat), Prime p → ¬ Mod a 0 p → Mod (Exp a (pred p)) 1 p.


120 character review? Sheesh


It might be useful in the future to check for multiple settings and pick the most recent one, to avoid the Multiple objects complaint


:joy:


I would stress the "iterates" part here, and call a `reviewlette.run` with a couple of mocked repos in the config.
And the would verify that both repos have been called.

(Also it's strange to have a test in `describe '.run'` which has nothing to do with actual `.run` call.)


@saeedmb8 Not sure I follow how this fixes things


Ok, thx... but I changed it anyway ;)
Because this code wouldn't work for browsers (they don't have `process`). It also makes the test for node much less fragile by not depending on something like an executable's file path.
I also made the browser side return at least *something* useful for the `version`.


Merged


**Functionality/Code Quality - Awesome**
This is great, using PSR4 autoloading!


@atd, can you please help me to style this so it is well displayed for small screens? I am stacked here, specially with the isNotification part.

Thanks!


Two things did, first it displayed "NVML GPU monitoring enabled." and second was the display of fan/temp while hashing. (More information is displayed about the hardware in the api but I forget the specifics for that.)
It certainly could have been a driver update and I just didn't realize it.  It was just that tpruvot's release has had working nvml monitoring for months on my machine, so that is why I didn't think that a driver update was the case.
The other strange thing is pallas needs to use --with-nvml while doing the configure step with sp-hash's ccminer to get nvml monitoring on, while I don't need to do that (I have done a completely fresh clone of sp-hash's ccmine).  But with tpruvot's release neither of us need to use --with-nvml.
I'm probably missing something and just too blind to see it.


Thanks -- this was failing on OpenBSD before since ocamlbuild also emits a non-native warning when ocamlopt is not available.  Now just the exit code is checked and the warning goes out on stderr and can be ignord.


Looks great, but just a couple of minor (possible) changes.
 - A more intuitive name for the allEvents attribute in Logger might be LogEvents
- We need an attribute maxLogItems : int which wil be used to make sure the log(file) doesn't get to large.
- A better name for the WriteLog class might be LogWriter.


Linter is telling you that this formatting is MESSED


This is much better now. :+1:


I would change "Its content SHOULD" to "Its content MUST"


**Functionality - Awesome**
Using `namespaces`, that's good, and meets expectations.


Fixes #51


https://github.com/Stolao/Npc_Release/blob/master/Reset_Girl/resetnpc.txt

yo happy, saw you did a similar script thought id link mine~


Alright that's understandable. But it's was mainly to remove non-ramdisk stuff out from default.prop.
However if HAL2 supports come someway later it's good


Should also add comment here: "TODO not supported for Java or PAMI".


Should also add comment here "TODO not supported for Java or PAMI".


lol


Lines 5 - 13 not necessary since you have line 21


IGNORE PLEASE - Got overzealous with https - my bad...


"You can often ignore the tearDown( ) method because individual unit tests are not long-running processes, and objects are garbage-collected as soon as the JVM exits." - http://etutorials.org/Programming/Java+extreme+programming/Chapter+4.+JUnit/4.6+Set+Up+and+Tear+Down/


Hm, you are changing the semantics of rtnl_link_info_data_bridge_types (dropping the old definition and adding a new one, not merely extending it). Was the old one buggy (I did not check)? Please explain in the commit message.


Well, multiple settings shouldn't occur. I might add unique constraint on Setting object.


You have `var products` again on line 82


Is that for the G9x? That means that there is some LED whose color indicate the current profile. Does that also mean, there is an *official* way (from LGS) to switch profiles?


Cooool, thanks!


Yeah the issue I was having was that if you updated the settings before the caching had occurred itd create multiple objects


@ryan-roemer Looks great! :+1:


Hm, we really want to hide the uglyness of these flags from the callers. In other cases we manage to deduce what the flags should be automatically. Could that be done here too, if not, could you explain in the commit message?


A process cannot spread further than the number of pixels available.


When I get back to my machine I will definitely give a command line and output description.  Its probably something super simple involving the changing of this line: fprintf(stderr, "%llu\n", (long long unsigned int) global_hashrate);


WTF?


Usually NuGet dlls are not included in the source control, packages.config is enough and it will take care of restoring the right dll version.
See for example https://github.com/jackpoz/OnlineRadio/tree/master/OnlineRadio.Plugins.Audio folder structure that references NAudio NuGet package without actually pushing the dll to github


안녕하세요 박준규입니다.
2014134068입니다.


Sorry about that, it looks like I created a conflict with your changes. I've applied them separately.


I can confirm it. The fan on the extruder doesn't work with this change.


instead of computing `strip_height` as the global max of of `strip_heights`, we instead take the max for each row, and then compute the cumsum to use for `strip_h` when defining `plotdim.ystart`.

Now all tests pass so I will merge with master.


@miltontony this changes the width of the dropdown boxes. so here I set it to 0 which makes the width of the dropdown boxes adapt to the width of the text within it


Hi @clintonskitson / @kacole2,

Although nothing in this change should affect you two, I wanted you to be aware of it and why it was made.


I could pull this change as-is, if you would prepare a pull request of this single commit?

Mixing issues in a single pull request is problematic, especially if one patch is solid, and the other needs some refinement.  Thanks!


Ok. I will not modify other tests regarding priorities. The [test case of command injection](https://github.com/h3xstream/find-sec-bugs/blob/96b7f037552a915c6351ea0feef0cad7e061dc24/plugin/src/test/java/com/h3xstream/findsecbugs/injection/command/CommandInjectionDetectorTest.java#L86) will not be alter regarding priorities.


@trufanov-nok I see. Sure, I can do these changes. And perhaps add a few plots also. I guess that would be taking more advantage of R. Thanks for the suggestions.


Hm, so now there is a race. We don't do this in other cases (we don't create and then configure, but create netdev's with the right settings from the get-go). Why can't this just be appended to the initial NEWLINK call when creating the bridge netdev?


Hi,
Beware of addType arguments : as type checks variable on soapRequest there is now an soapErrorCode argument just after type. The default code is   600 : "Argument Value Invalid"
You may want to provide specific soapErrors for your services as they are on per service basis dependents.
Take a look into util. The errors for service files names start with exact service filename without Service and ends with ErrorSoap.

I'm also thinking about a single variable for stateVars callbacks. A single object with onBeforeEvent onAfterEvent and onValidate keys, to handle LastValue event model and provide specific validation functions.

Note : variable range support is there, you can provide a {minimum: , maximum:, step:optional} instead of valueList.


This looks cleaner than an ad-hoc regex.


The link is visible to only `User.admin?` however the relevant Policy aliases `can_history` to `can_show` which means admin + client_admin + (anyone connected with the proposal).


When i was working on flyspray, i always felt it needed a rewrite. It was a mess. I haven't dived into the code or looked at it, at its current state so I can't say if its still needed or not. For me its not the being motivated to work for free, money isn't an issue its time. I had have two little kids, i broke away because it was just too much. I since then have started my own company in centralized logging and trying to figure out clustering that is easy for an idiot to install ;)

If I was to redesign the internals, I would go with Laravel LTS and start making it work with the db, get functions working again and that might get laravel devs on board as volunteers. But like i said i haven't looked at the code in years.

I do like how these update though, ajax wizardry. That would be easy to do.


This enable_if solution does work, but I think a static assert would be a little clearer and achieve the same aim. I only really tend to use this construct when I absolutely have to as it's a little awkward.


Hmm, OK. It seems to work, although I would like to see more examples of mixing `In` with updates and shared variables (with updates as well) in the tests, if this is what we want to support.
However, if I remember correctly, and after re-reading the code, `Param` was supposed to be like `In`, but _without_ support for an update, since the update mechanism was now handled by `pfunc`, and was the prelude to removing `update` from `In`, so that the support would be easier. I think we have two choices now:
- finally drop the support for specifying updates in `In()`,
- or decide to support it with `Param()` (in which case, we also have to decide what to do with the tuple syntax: either get rid of it, or simply call `function_module.convert_function_input`.
In both cases, we can get rid of the different code paths in `function_orig` and `pfunc`, and merge `pfunc` with `function_orig` and `function`.

Unless there is still a strong use case for specifying updates via `In()` rather than through shared variables, I would favor simplifying the code.


We should not be committing commented out code. This is not good at all. Please either remove it or keep it, but do not commit code like this...


@liupeiyang any reason why to prohibit this? Disabling this will mean that creation will not be idempotent.


Yes it's ready! There wasn't concrete meaning, then I just correct the part
without meaning.
Em 17/09/2015 12:09, "RaMMicHaeL" <notifications@github.com> escreveu:

> You didn't create a pull request. Is this change ready for merging?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Gilson-Olive/unchecky-translate/commit/b5be4f2d87ba091668b35a099b7736ae0f09c227#commitcomment-13290068>
> .
>


If you have any ideas about this part which has been bugging me for quite some time I am all ears.


Hi @goldshtn,

I consider your idea of the mini dumps great, but I think that the tool will be much more useful if it has the same command line interface as in procdump (the one from sysinternals). This will make the transition smooth for most of the people.

So... I created a fork and would like to add a debug loop (available in CLRMD) to the tool and implement some of the most popular (at least based on my experience) command options from procdump. I'm now going for vacations but in two weeks I should have some more commits :) I plan to make a pull request to your main repo later. What do you think?


**Functionality - Awesome**
Good, checking if the word exists before adding it.


This code seems to be fine, overall. Would just advise against the commented out HTML and please don't upload .idea/ file.


"avalistriplight2.png" needs to be changed to "avalistriplight.png" in a few places :) I did the same last night and it threw up errors in the log.


I think that updating the expression in place is cleaner: less repo clutter, and an standard package style. Besides, a regexp can always be replaced with something better.


brought in as dependency


replace `User.find` with current user.


Le 17/09/2015 16:49, jsanda a écrit :
> Do we need to include the logging level in each method name? It makes
> the method name unnecessarily verbose IMO since we have already have the
> level in the |@LogMessage| annotation.

That's my opinion as well but this is a Hawkular wide convention (see my
email to the devel list)


**Code Quality - Nitpick**
You switched up the naming convention from `camelCase` to `lowercase_with_underscores`, should be consistent.


Thank you for the fast merge @freekmurze.


I think there's only 3 instances that need to be changed...


MiscReleaseFixes (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1873 of 1874 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


where is the `@item` coming from? I think you just need `Item` here.


please don't do this


This change breaks module support.  -mexinfix made more sense because it could be applied to imported modules.  With -mexname we now don't know the name of the mex file for the imported module.


https://github.com/node-modules/autod/commit/06d6aa510114d850b0e1bb6741d68d273a2a3b42 ？

traceur is much smaller


1: D100 Missing docstring in public module


42:1: I201 Missing newline before sections or imports.
180:9: E126 continuation line over-indented for hanging indent
187:9: E126 continuation line over-indented for hanging indent


40:1: F401 '_PACKAGES_EXCLUDE' imported but unused
41:1: I101 Imported names are in the wrong order. Should be RECORD_KEY_ALIASES, RECORD_PROCESSORS
41:1: I201 Missing newline before sections or imports.
45:1: I100 Imports statements are in the wrong order. from collections should be before from invenio_records.config
144:4: E131 continuation line unaligned for hanging indent
171:54: E261 at least two spaces before inline comment
171:55: E262 inline comment should start with '# '
180:9: E126 continuation line over-indented for hanging indent
187:9: E126 continuation line over-indented for hanging indent


1: D205 1 blank line required between summary line and description (found 0)
27:1: I101 Imported names are in the wrong order. Should be find_packages, setup
29:1: I100 Imports statements are in the wrong order. import os should be before from setuptools.command.test
29:1: I201 Missing newline before sections or imports.


23:1: I201 Missing newline before sections or imports.
23:1: F401 'url_for' imported but unused
24:1: I201 Missing newline before sections or imports.


So we have `RippleCalc`, `rippleCalculate`, and now `rippleCalc` as identifiers. Whose idea was this?


this was brought in as a dependency, and is a huge jump from where we are now


**Code Quality/Comments - Nitpick**
Please use the formal docblock syntax with tags, see http://www.phpdoc.org/docs/latest/guides/docblocks.html

Remember to do _docblocks_ for all the classes in `/src`


Тут у тебя скорее всего должно падать, т.к. `isNaN` вроде как не определена. Наверно, имелось в виду `_.isNan`


Hi,

Here is my steps:

EDD 2.4.3 - quick edit is working
EDD 2.4.4 - quick edit link does nothing
EDD 2.4.5 - updated today in the morning, Didn't fix the issue with quick edit
So with EDD 2.4.5 installed, I tried to find a solution today and found this post. Then i manually changed the line in scripts.php file back, after which quick edit functionality started to work again.

Actually i do not use quick edit at this moment, but I want EDD to be ideal.

Thank You


Ying's comment.


brought in as dependency


chesu. aun no se como usar esto..... -.-


:+1:  A habit worth losing in my case then. Thanks.


brought in as a dependency


**Comments - Nitpick**
As noted in the [above comment](https://github.com/andela-bkagia/php-checkpoints/commit/dd885eee694f807a1e242df744394d614a1239ec#commitcomment-13290783), use the formal tags and syntax for docblock.


DataProcessing:
     Data Processor - A DataProcessor object is a way of connecting to a MySQL DB and retrieving data.
     Created in a way to make it easy to reuse for future projects. This code is still in progress and does
     not yet include methods for insertions into a DB.

     Purchase - A Purchase Object mirrors an existing MySQL table. This will change as I get a more solid
     idea about what data I need my table to hold.


as insight will benefit from the limit, that may become ``omero.client...`` property


Why do you do this?


dependency of a dependency walking through memory laaaaane with @sax :heart_eyes_cat:


Where is build.gradle located? I can't find it?


legit


@jasuarez I'm not sure this is correct. The handle_user_manifest() call actually does all the object reading, so at this point the op completes.


Yeah, much better


Indeed. All depends on how you use it. Just wanted to put the warning out
there. If you specify a name this api is great, if you don't... There be
dragons :)

On Thu, Sep 17, 2015, 6:18 AM Ryan Pendergast <notifications@github.com>
wrote:

> nope keeping describe as it lets you specify a particular stack name.
> listStacks
> <http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/CloudFormation.html#listStacks-property>
> does not..
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jaws-framework/JAWS/commit/023bbc532861e4c4c1abb8b465e86b86d35426e3#commitcomment-13286745>
> .
>


why not passing size to the constructor?


Just noting, the visibility should rather be package than public no? Because this class doesn't have purpose to be used outside.


@dcb210 If you have explicitly named a module, this has to be implemented.


逝者安息 RIP Jim :'(


All the merit goes to the contributors, that provided the fixes :-)
And by the way, thanks to the "lint-like" checking of metadata, now all
version numbers should be ok too.

2015-09-17 17:19 GMT+02:00 Anil Madhavapeddy <notifications@github.com>:

> Thanks -- this was failing on OpenBSD before since ocamlbuild also emits a
> non-native warning when ocamlopt is not available. Now just the exit code
> is checked and the warning goes out on stderr and can be ignord.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rdicosmo/parmap/commit/a276c4ac61d5f06f1f966a88a551892f290bbb40#commitcomment-13290364>
> .
>

--
Roberto Di Cosmo

------------------------------------------------------------------
Professeur               En detachement a l'INRIA
PPS                      E-mail: roberto@dicosmo.org
Universite Paris Diderot WWW  : http://www.dicosmo.org
Case 7014                Tel  : ++33-(0)1-57 27 92 20
5, Rue Thomas Mann
F-75205 Paris Cedex 13   Identica: http://identi.ca/rdicosmo
FRANCE.                  Twitter: http://twitter.com/rdicosmo
------------------------------------------------------------------
Attachments:
MIME accepted, Word deprecated
      http://www.gnu.org/philosophy/no-word-attachments.html
------------------------------------------------------------------
Office location:

Bureau 320 (3rd floor)
Batiment Sophie Germain
Avenue de France
Metro Bibliotheque Francois Mitterrand, ligne 14/RER C
-----------------------------------------------------------------
GPG fingerprint 2931 20CE 3A5A 5390 98EC 8BFC FCCA C3BE 39CB 12D3


**Code Quality - Awesome**
Throughout the whole project, you've been consistent with the spacing and arrangement for the code blocks — `if, for, function, class` and the `{`'s, as recommended by `PSR-2`.

That's pretty good, keep it up.


Guy, how I do a pull request??


What is missing is the ability to specify the `mexname` when importing a module, see above. Will this not resolve that?


I wanted so see acquire event in trace after lock event.
Maybe it's not that useful, removed.


Why remove the hyphen? Isn't that the standard spelling?

https://en.wikipedia.org/wiki/Cross-validation_(statistics)


That would be great! Thanks Martin!


У тебя в описании указаны параметры расчета. Вот их и желательно принимать параметрами в функцию, а к глобальному (относительно метода расчета) объекту `vm` не обращаться


going to import latest instead, methinks.  what an ancient mess


Also we don't need to pass the time the event happened as a String when creating a logevent. We can simply get the system time when the constructor of the log Event is called.


Here's a tutorial:
https://help.github.com/articles/using-pull-requests/
Thanks!


Тут так же по поводу параметров


xD


Photovoltaics (evanweaver) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


LGTM :shipit:


Sorry! Realised there was an error on the other test, but not on this one


Yeah I think `Iterable = Union(AbstractArray, Tuple)` is reasonable.


obviated by later re-vendoring


На данном этапе приводить к формату двух знаков после запятой не надо. Это имеет смысл делать во время вывода - там можно будет использовать ангуляровский фильтр


Are you saying we should at it as an option to %module, like:
%module(mexname="importmoduleMEX") importModule.

That would fix the problem.


**new-cap**: A function with a name starting with an uppercase letter should only be used as a constructor.


**no-undef**: "describe" is not defined.


**no-undef**: "ReactDOM" is not defined.


**no-undef**: "expect" is not defined.


**no-undef**: "before" is not defined.


**no-undef**: "TestUtils" is not defined.


**no-undef**: "sinon" is not defined.


**no-undef**: "it" is not defined.


**Eslint**: 'return' outside of function


**no-unused-expressions**: Expected an assignment or function call and instead saw an expression.


I'm afraid this is buggy now, you should remove ".communication" from the String (but depends on the code in your Manager, I'm not sure).


Le 17/09/2015 16:52, jsanda a écrit :
> Do you know if there is any way that we could inject the logger maybe
> using a CDI provider?

We could, but why?


Il metodo get c'è per i servizi, quindi la soluzione è molto semplice: se un component pubblica un servizio deve essere anche iscritto alla raccolta Game.Services


Yes, that was my conclusion from the discussion with @wsfulton.


You're right, I might change it in the next version.

I actually didn't realize, I thought all dll's were ignored and handled properly.


I will make the change. The current code base breaks my build system.


access a property using a string literal within a pair of square brackets when the property name is not a reserved word, so i think you  should use dot notation to accomplish something like this


Oops, made that commit in my DeLorean.  :)

Fixed, thanks for the catch!


is this really needed at runtime?


@vilchik-elena it seems we will accept namespace\namespace\xx which is probably not valid PHP, but why not.


`return` так не работает. Должно возвращаться только одно значение. Если надо вернуть насколько, то возвращай их как поля одного объекта


keep everything on one line like it was


Oops, made that commit in my DeLorean. :)

Fixed, thanks for the catch!


You're right. I misunderstood that part of the code. Apologies for the noise.


no need for `>=...5.2`, the slot `:5` is enough


@vilchik-elena @pynicolas +1 for keep it as a separated case.


**no-undef**: "before" is not defined.


**no-undef**: "describe" is not defined.


**no-undef**: "ReactDOM" is not defined.


**no-undef**: "sinon" is not defined.


**new-cap**: A function with a name starting with an uppercase letter should only be used as a constructor.


**no-unused-expressions**: Expected an assignment or function call and instead saw an expression.


**no-undef**: "it" is not defined.


**no-undef**: "TestUtils" is not defined.


**no-undef**: "expect" is not defined.


to explain further on the note, usually the interface libraries (LINK_INTERFACE_LIBRARIES) are empty by default (AFAIK) and since no interface libraries are set either via the legacy LINK_INTERFACE_LIBRARIES or PUBLIC tarrget properties this may cause some troubles with e.g. lld from the LLVM project.


greate !


Sorry for all the breaking changes... Want to get these low-level things 100 % right...


河蟹..


reset() needs to be substituted by ``beginResetModel()`` and ``endResetModel()`` in order to work properly.


Better to include specific elements.


You could make it 2.8.12 just to be sure.


@trufanov-nok Don't you think it's better to make a small package with both functions ( dt2vw.R and vw.R) ? So it can be installed with devtools. This way it would be easier to make more contributions.


Don't commit commented out code if possible: if it's not needed anymore, you can remove it.


After thinking about it, I would leave the v2 snapshot as data in the raftpb.Snapshot when sending latest snapshot. This keeps original logic and saves the time to write it into v3 storage.

I still plan to save v2 snapshot into v3 storage at fixed interval, which is a follow-up.


Ditto for all includes, here it should be

````
#include <QApplication>
````


The idea was also to allow specifying it when importing:
```
%import(mexname ="importmoduleMEX") "basemodule.i"
```


@lindamartin what do you mean by "a separated case"?


Ok... refactored the isErrorIndicated() method and updated build and pull response items.


Final nit: no spaces around record brackets


same here


Good point - what's a better name?  `estimateLiquidity()`?


**no-undef**: "before" is not defined.


**no-undef**: "describe" is not defined.


**no-undef**: "expect" is not defined.


**no-undef**: "sinon" is not defined.


**no-undef**: "it" is not defined.


**Eslint**: 'return' outside of function


**no-undef**: "ReactDOM" is not defined.


**no-undef**: "TestUtils" is not defined.


Nope, I'm fine cause I don't see anyway to improve it :)


I think in discussions offline you told me you added logging of GET so that an export transaction could see the changes made.   I think it would be valuable to add a sentence here that an export tx could do something like this.


@jjungle Hättest du evtl. auch hinbekommen :wink:


Я себе представлял структуру по-другому:
```
credit = {
    initialParams: { // параметры, которые ты собираешь с формы. возможно, как-то преобразованные
        amount: ...,
        method: ...,
        ...
    },
    calculation: [ // массив с объектами состояния кредита на каждый месяц
        {
            payment: ...,
            partToInterest: ...,
            partToRepay: ...,
            restOfLoan:...,
            ...
        }
    ]
}
```
так у тебя будет только один массив с состоянием на каждый месяц и его легко можно будет вывести в таблицу


@vilchik-elena like another possible case in a ``firstOf()`` for example. Make sens or not ?


#891 was about doing the first option.


While here, it'd be nice to leave a comment mentioning the word "nondeterministic" so that people interested in nondeterminism can easily find the relevant parts of the spec.


Зачем тебе id понадобился?


Data would be enough


This is a nice refactor.


Nitpick (but can be a separate commit): use the same style for CMake throughout the code, either `IF` or `if`.


Gamesystem è una classe molto semplice, il nome è davvero infelice perché non si capisce cosa faccia
Di base fa due cose: crea e inizializza i giocatori, e gestisce i turni.
Probabilmente può essere cancellata, spostando le funzionalità dentro FlussoDiGioco

FlussoDiGioco in pratica è solo un wrapper per le azioni, ma lo terrei separato da quantum principalmente a) per evitare di mettere robba in quantum, che essendo la classe principale andrebbe lasciata pulita, e b) perché quando avremo il menù iniziale così potremo creare il flusso di gioco solo dopo l'inizio effettivo della partita (prima è inutile; anzi, per essere chiaro, l'intero menù andrebbe gestito da un blocco di codice a parte)


@vilchik-elena This second constructor could call the first one: this(tryToken, blockTree, catchBlocks, null, null)


Lovely job.


The A10 API is already bizarre enough.  Let's keep this simple.  Instead of adding a bunch more methods, let's just expose the method that returns the Response object.  The caller can do whatever they want with it.

```java
getJsonResponse(...).body().string()
```

The naming I came up with was really terrible.  getJsonResponse() makes it sound like it is fetching a json response, which it is not.


well you got trapped in.. a certain indentation style.

[this](https://github.com/ArcEye/machinekit/blob/ck-integration/src/hal/i_components/weighted_sumv2.icomp#L65-L73) suggests `sum = running_total` is executed if (!hold), which is bogus. The block before is; that assignment is not. Lining up things that way does not make sense to me.

Other than what the documentation says, sum will become zero if hold is true. running_total must be part of the instance data because it must persist across funct invocations.


Ah thanks for fixing, I didn't realize the structure should mirror the build folder!


Ok. I didn't even know that was possible for %import.


This is nice. Could this be better as a module mixed into both classes, with a helper method? Something like `attribute :date`?


True, but finding a better position than this or keypress is difficult.  Preferences?

<organization


I'll check it out and see. BTW, I don't think there is any reason this extension couldn't be `>= 3.4`, rather than 4 only. If you're using Travis, you can test against 2 different Gemfiles. 1 for 3.x, 1 for 4.x


That works


FYI this is using MiniTest::Spec instead of Rspec --- just a lighter-weight approach for a small test suite.

The task in the Rakefile lets you run tests with `rake test`

@jgautsch @GeekOnCoffee


Great. Did the fix for this become more obvious once you'd tested it?


Perfect, I'll close the issue.
Thanks!


uhoh, maybe that was your naming. ;-)


Time = $$$ :-)

________________________Jordan Mendler
[image: The Veloz Group]
The Veloz Group
President & Chief Technology Officer
jordan@thevelozgroup.com
www.thevelozgroup.com

On Thu, Sep 17, 2015 at 8:29 AM, Scott <notifications@github.com> wrote:

> When i was working on flyspray, i always felt it needed a rewrite. It was
> a mess. I haven't dived into the code or looked at it, at its current state
> so I can't say if its still needed or not. For me its not the being
> motivated to work for free, money isn't an issue its time. I had have two
> little kids, i broke away because it was just too much. I since then have
> started my own company in centralized logging and trying to figure out
> clustering that is easy for an idiot to install ;)
>
> If I was to redesign the internals, I would go with Laravel LTS and start
> making it work with the db, get functions working again and that might get
> laravel devs on board as volunteers. But like i said i haven't looked at
> the code in years.
>
> I do like how these update though, ajax wizardry. That would be easy to do.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Flyspray/flyspray/commit/b889759b1805196a5a22de7501b99408f4bd6cd1#commitcomment-13290661>
> .
>


we need a better naming anyway.


Better you using it as usual. @Bind(R.id.progressLayout) ProgressLayout progressLayout;


Ignoring is not the same than expecting the test to fail, no?


Sweet addition bro!


Photovoltaics (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.31%25-red.svg)


Dahora o nome do elfo hehe


Congrats!
Rspamd is such reliable and smooth. Much wow.
Thanks for your work.


1. Add a description to each data set array element.
2. Add a comment describing how the data set its composed `// Description => [shared by default, shared]`
3. Replace booleans with variables describing the value. `Shared: T, ByDefault: F` => [$isShared, !$byDefaultShare]`
4. Wrap the array with `@codingStandardsIgnoreStart` and `@codingStandardsIgnoreEnd`
5. Align the columns with whitespaces

Ex: https://github.com/zendframework/zend-inputfilter/blob/master/test/InputTest.php#L625


Mostly the mitmot PR used In for the scan speed up instead of shared var. It use the update parameter.

@carriepl do you think it would it be long to change that in the PR?

Param isn't documented and the tutorial on using GPU describe the use of In. So people try to use it from time to time with shared var and have an error. We should update it if we don't merge the this change.


:heart:


We don`t need this variable on the class. findById can works fine.


@vilchik-elena maybe we could add a case where the exception type is not an unqualified name.


and fix name item.tritainum_spine.name to item.tritanium_spine.name


use `share` instead `cache`


add tests for null values


Consider using list comprehensions to reduce code:

```python
nlcd_names = [v[1] for v in NLCD_MAPPING.itervalues()]
used_nlcd_names = [k for k in survey[0]['categories'].iterkeys()]
```


@thoni56 have you considered hosting the generated documentation on github? github provides hosting of one website free of charge for open source projects. I've set this up for some of my other github projects and could help out. For example:

http://d-meiser.github.io/mbo/

and

http://d-meiser.github.io/mbo/docs/html/index.html


supply some solutions that I have came with in the process of practicing the leet code quiz


Another test it's needed for verify when the element is not set (isset)


I think we should configure the `clientRawDataChannel` with this check in the `setUp()` method instead of doing this again and again in multiple test cases.


Somehow, people with a RPi2 get their xbian.list sources updated to rpi-jessie instead of rpi2-jessie? I don't see why so can't fix it.


Although I think you're technically right (both `host_params` and `import` are nondeterministic from a host-agnostic pov), I think saying "these values are nondeterministic" in a comment would confuse people more than the more specific statement that these values are host parameters.


PHPUnit allow to place a custom description on the array key


This in a base platform you need tout pen programmes built before you attempt any changes this programme is patented and copywritten you wee only allowed to upload files and documents for storage and repair Not adjustment you Allowed to use the platforms that github providers and you wee limites to what you get what you Payfor git mat be free Yo use but lu platform serveur is not


typo in 'middleware'


move to `setUp()` method


indentation


This does not fully fix the problem:
https://github.com/mitchellh/vagrant/issues/6026#issuecomment-137182653


This is *bold*


I test with pymongo <3 and i confirme it's not compatible :-(


`dataSize_` should be initialized to 0 before you do an operation like this.  You want to guarantee that what you're doing will have the outcome you expect.


Thanks bro! In October do we have to call ourselves "fifth year PhD students"? :s


In the documentation:

http://www.swig.org/Doc3.0/SWIGDocumentation.html#Modules_nn1

It looks like %import currently just supports module. I'll looking into adding this as well.


*This message is italicized*
**This message is bold**
#hello


Is this missing an underscore?


After thinking about it, i cannot make it a map because raft may ask for snapshot at some index multiple times, and cannot find a good key for the map.


testing a comment.


Made it possible for women only to enact this kind of laws.


Commit LockerManagementSystems Initial Version


Use `DTLSConnectorTest.newStandardConfig(InetSocketAddress)` instead ...


Photovoltaics (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


It causes error when you use `gulp` and `ck86/main-bower-files` - files are not copied.


Either way, there should be only one class at the end. The question is whether this class should accept `update` or not. I think it is easier to maintain and make sure it works if it does not, since we do not have to worry about weird corner cases. However, if it makes things better / simpler / more efficient in @carriepl's feature, then I'm not opposed to it.
If we remove the `update` feature, then we should remove that part of the documentation.
In my opinion, we should remove the "tuple" way as well, I don't know anyone using it, and it is confusing.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 643](https://teamcity.labkey.org/viewLog.html?buildId=272704&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:27:56
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

##### there are 23 more failed tests, see build details
```


commenting on comment.


add the "defer" property after the src similar to the statement in line 12. Also move this script to position after the including of "config.js" it's just a cosmetic change but it will be better positioned there.


@CurlyMoo
... because `upgrade_wheezy_to_jessie()` doesn't make any difference between RPi and RPi2 (line 27). Does simply change wheezy to jessie - and a rpi2-wheezy never exists


`.then(null, next)`


`error.status = 404`


pep-8 FTW! :+1:


Be fine if it was `res`


Nesta linha assumes um comprimento de 8 bits para `x`, o que não é correcto. Se eu tentar fazer `rightrot` de um número superior a 255 terei problemas pois este código irá corromper o padrão de bits.


`Order.findById(id)` doesn't actually return a promise, despite being able to call `.then` on it.


> @tdreyno
> I'll check it out and see.

Thanks a lot!

> @tdreyno
>  BTW, I don't think there is any reason this extension couldn't be >= 3.4, rather than 4 only. If you're using Travis, you can test against 2 different Gemfiles. 1 for 3.x, 1 for 4.x

Thanks for the note. I'll try!


Damnit, leave it with that money discussion.... Money isn't needed here, everything is free, but the hosting by Flo! Donations? Where did they ever go? For what?

Talking about git featuring mail listening, it works really well, just saw now that 2 of my answers don't show up here... First one being the fact I don't understand why you say I won't work for free. None of my previous projects, even own ones, ever made me any sustainable incomes. I run my own business, have 35 employees. Summer was hot, nature is early, I won't tell my producers: Hey guys, wait, don't deliver the 60 tons of grapes now, I have to release Flyspray!! So it's a matter of priorities.

Again, Google ads were meant to be implemented for users not forcing the whole population to make us money for nothing. A simple admin field to give your own private key. Ads were displayed in the bug flow, taking the height of 2 bug lines, kindda like on forums where the ads take the first reply place. Money goes to the admins that wanted their FS instance to have Google ads.

The only thing I see here is: We need money. Google ads will NEVER give you 60k a year, never! And hiring a pro dev is not a good idea.


Should probably be named `testConnectorPerformsFullHandshakeWhenResumingNonExistingSession`?


This is used to avoid binding the same DOM object twice. It seems that there is no way of checking whether there are click listeners on an object other than storing them on assignment


Misnomer


Unfortunately, multiple main entries are marked invalid by bower.
I guess the solution would be to move additional plugins to separate repos, but this causes a maintenance overhead.


Will pinning this to 1.2.1 conflict with apps that have another version pinned in their Gemfile?

https://github.com/alphagov/frontend/blob/5dbf598b173abc30ea3d2e40c556a603a7d90ec7/Gemfile#L9


This way, the plugins will be parsed one by one in the interface. This should make the loading of a large number of plugins much more responsive.


My version did it:
```
    # Prepare an optional switch from Wheezy to Jessie
    if [ "$version" = wheezy ] && ! grep -q "^deb .* jessie" /etc/apt/sources.list; then
        FILES="/etc/apt/sources.list /etc/apt/sources.list.d/xbian.list"
        for f in $FILES; do
            [ -e $f.dpkg-$version ] || cp -a $f $f.dpkg-$version
            sed -i s/wheezy/jessie/g $f
            if [ "$config_platform" = rpi2 ]; then
                sed -i s%deb.*raspbian.*%deb\ http:\/\/http.debian.net\/debian\/\ jessie\ main\ non-free%g $f
                sed -i s/rpi-jessie/rpi2-jessie/g $f
            fi
        done
        if [ "$config_platform" = rpi2 ]; then
            KEYRINGDEB="debian-archive-keyring_2014.3_all.deb"
            cpath=$(pwd)
            cd /tmp
            [ -e $KEYRINGDEB ] && rm -f $KEYRINGDEB
            wget -q http://http.debian.net/debian/pool/main/d/debian-archive-keyring/$KEYRINGDEB
            ar -x $KEYRINGDEB
            rm -f $KEYRINGDEB
            TMP=$(mktemp -d)
            cd $TMP
            tar xf /tmp/data.tar.xz
            cp -a * /
            cd $cpath
        fi
        PINDEBS="systemd-sysv watchdog"
        for deb in $PINDEBS; do
            if ! cat /etc/apt/preferences.d/xbian | grep -q $deb; then
                echo ""                      >> /etc/apt/preferences.d/xbian
                echo "Package: $deb"         >> /etc/apt/preferences.d/xbian
                echo "Pin: release o=Debian" >> /etc/apt/preferences.d/xbian
                echo "Pin-Priority: -1"      >> /etc/apt/preferences.d/xbian
            fi
        done
    fi
```
But already said, @mk01 was faster :smile:


I can't say that I'm experienced R user but in my opinion most users don't look into implementation of functions provided by packages they use. If they can't find suitable functionality then they're looking for another package. In other words packages have bigger audience and thus should expect user has no programming skills.
So if you seal this code into a package then exported functionality shall be flexible enough to support many use cases. And this requires some thinking on interface design and long term support.
If this is just a code it put less constrains on author. You just show the way how things could be done and expect the end user to adapt your code or write own using your as a sample. You don't need to do a wrapper for whole VW functionality.

So in my opinion if there will be a good comprehensive VW package for R than we can just replace "example of VW usage in R" with "example of R's VW package usage". Till that it's better to showcase the whole code. Just hiding these 2 R files in a small package won't help.


Just like earlier:

This is used to avoid binding the same DOM object twice. It seems that there is no way of checking whether there are click listeners on an object other than storing them on assignment


This server logs the fortune to the console, but not on the page. Is that what you were expecting for this exercise?


Nice! The benefits of having removed the magic numbers are already starting to show! Lol.


i'd say the `first return K replies` is not accurate, put it in a less pedantic way:

the read request would issue sub reads to all shards, and use the received shads once they are able to form the minimal shards set to decode the data. In the case of jerasure and isa erasure plugins, once the first K replies return, client's request is served immediately using the data decoded from these replies.

[OT] we can be faster, if we are using @xinze 's fast read approach at #4467: to return once the requested range is returned without waiting for the minimal set.


Pretty much.


this additional dependency is needed as node js fs.watch doesn't work properly on mac and doesn't support subdirectories


No http in front url


testing another comment.


Cool. Thanks for the information and answering my question! Maybe I'll take a look some other day, until then, `-spec` everywhere! XD


`x.y.z+` is the supremum of all versions starting with `x.y.z`.


yet another comment.


Nice way to avoid an extra request on the front-end.


constantly watch for any changes in the plugins directory. If so, set add them to list of new modifications.


Suggest getting used to lodash, and using something like `_.merge` or `_.extend`.


#Hoàng đẹp zai


No http in front all url


Why `element` and `results` instead of `product` and `products`?


Write `26*`. The stars means the test is expected to fail at this point.


:a:


Write `27*`. The stars means the test is expected to fail at this point.


No http use only /


It is researched these days, looked at the code, just the only alternative thought is to change the coding, seems to be related to the LG ... Anyway thanks... made some changes, if you want to take, feel free ... (as the play pause button appears at the same time,size of icons)


`Beginning` was the correct spelling.


Maybe states should be its own documents or an enum?


Jenny: also useful for a dropdown


have to fix this


@bootleq 那這樣表示原本 nginx 的處理就需要 rewrite 了，其實那行註解可以拿掉


It is is possible to configure OpenStack components to log through syslog. Moreover, journald captures the relevant details, so capturing journalctl output in addition to /var/log/sahara is useful.


`user` is a better name for this.


@bootleq 如果 nginx 的 ssi 處理沒有這個問題，我就去 node-ssi 那邊發 bug


Does this actually work?


Hey Marco,

You hit it on the head. The name change was due to the inconsistency in the documentation for set up and for the implementation.  They need to line up in order to work.


mrpp? totally dont remember doing this.. must've been in the wrong project! sry!


type: [{ type: ObjectId, ref: "Product" }]


The same for Windows 8.1, Arduino IDE 1.6.5


Just want to confirm that the two methods that were changed were returned back to their original state before this PR.  is that correct?  Want to make sure we're not breaking anything for the other services.


Hello,
Now after your update you are creating the GBJailbreakDetection framework with using the minimal iOS version 8.2. This is necessary? I would like use your 1.1.0 Pod Version but how my project support since 7.0 I´m receiving a lot of warning messages. Here you are an example:

ld: warning: object file (/XXXXX/Pods/GBJailbreakDetection/GBJailbreakDetection.framework/GBJailbreakDetection(GBJailbreakDetection.o)) was built for newer iOS version (8.2) than being linked (7.0)

Thanks in advance Francisco Javier


removed!


I was almost wondering if this needs to be changed to some type of custom material block, as to support things like iron channels in the future, without requiring massive code duplication. We would have to change the way the harvest level, resistance, and sound are got though...


Instead of using applescript, which requires special permissions to run against system preferences, try using objective-c. Maybe?

http://www.informit.com/articles/article.aspx?p=1819492


Maybe another model?


Why not `locationId`? :camel:


That definition almost puts one into endofunctor world.


"Writing up"


BUFU


If only more objects had such a property like IsDisposed and Disposing. :P


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1343 of 1343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


test


nice :)


:ghost:


MiscReleaseFixes (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1879 of 1880 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


这行少了个标点符号。


You have 2 options instead of this:


1: Move the require in the models/index.js to put products and orders before user


Adding the new .png to Github fixed that problem, I didn't receive any errors in my .log file when I placed it in many different locations. I'm affraid that what you have edited may have been wrong.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1343 of 1343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.24%25-green.svg)


2: mongoose.model('NeededModel') in methods/statics when they are invoked


No, person, it is not a performance hit.


:camel:


good


是吗


Thanks for the heads up, I'll take a look at this


Can you please fix the rspec tests


+    B_diag = np.array([bx,by,bz,bvx,bvy,bvz])
+    B = np.diag(B_diag)
I declared the diagonal matrix by manual... but the way you declare it seems much nicer!


@jayvachon can you add a credentials.json.template (with fake data), and instructions in the README for creating one's own.  I can't test this out until I make that file...


Quantity?


1. example: closure-compiler(https://github.com/google/closure-compiler/blob/master/pom.xml)

  <modules>
    <module>externs/pom.xml</module>
    <module>pom-main.xml</module>
  </modules>

2. When a xml file is in the same folder with other submodule or with parent module, it shares same target directory. Test classes should be in the same folder.


They should be available on the WOCommunity Maven repository. I'll check on that. Thanks for the information.


+1 this is great! :shipit:


This guide states that this is just for a development setup, not for production. I think that storing the clientID and secret in a secure place is a bit overkill here.


the metrics can ensure nothing, your code could. it just can let you see the result.


Why not just Promise.all here?


i do not follow.


Promise resolve order is for what?


MiscReleaseFixes (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Wow! Nice work!


You can also use `six.text_type` FYI but feel free to leave as is


Markdown will take care of the encoding, so I would just use `å`. Markdown is supposed to be readable without processing, so having all the `å` stuff would be difficult. Also, I think that the directory for this file should be `sv` as that is the ISO language code for Swedish. Great work. I was starting my own swedish translation (as I am taking language courses), but since you already did the work (and it is clearly much better than I could have done), I copied it into my forked repository and submitted a pull request to the sugru/master (giving you credit for it, of course). Tack!


formatting


should be `done`, not an empty function


maybe you can make the three lines a line like
x_filter, y_filter, z_filter = [np.array(s_filter[i,:])[0] for i in range(3))


Tnx for building buildtime Dieter! I found buildtime on an example travis file so decided to try it out. It gives us nice stats :)


A bit unnecessary.


Other than that, everything looks good to me!


MiscReleaseFixes (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1880 of 1880 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


When we provide a v1 client (coming soon), we'll use that. Right now the client is in unversioned to remind people that it's... unversioned. :)


[fromage blanc]http://fromage.blanc.com


Modified


Based on https://www.zabbix.org/wiki/Docs/howto/ssl_certificate_check
Modified to work with FreeBSD's date
Also changed HOST.CONN with HOSTNAME on template


I'm digging this. Good work team!


[fromageblanc.com]http://fromage-blanc-recette.com
- [*] aaa
- [x] bbb


The same as mine.


And also a little clean-up.
Forgot the close #1


So here's how I invoke the script. I _do_ have a `.packages` file in that directory.

I can't think of anything not being standard... I'm on MacOS, on a case sensitive partition.

```bash
$ dart --version
Dart VM version: 1.12.1 (Tue Sep  8 04:10:39 2015) on "macos_x64"

$ pub global run rpc:generate discovery -p 8082 --api-prefix api/ -i lib/api/admin/admin.dart
in ShutdownIsolate: Unhandled exception:
Uncaught Error: IsolateSpawnException: Unhandled exception:
Invalid package name '    import 'dart' in http://127.0.0.1:62876/.packages:
    import 'dart:async';
#0      _handlePackagesReply (dart:_builtin:416)
#1      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)
Stack Trace:
#0      Isolate._spawnUri (dart:isolate-patch/isolate_patch.dart:364)
#1      Isolate.spawnUri (dart:isolate-patch/isolate_patch.dart:317)
#2      ClientApiGenerator._isolateTrampoline.<_isolateTrampoline_async_body> (http://localhost:63598/generate.dart:255)
#3      Future.Future.microtask.<anonymous closure> (dart:async/future.dart:144)
#4      _microtaskLoop (dart:async/schedule_microtask.dart:43)
#5      _microtaskLoopEntry (dart:async/schedule_microtask.dart:52)
#6      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#7      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:149)

#0      _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:895)
#1      _microtaskLoop (dart:async/schedule_microtask.dart:43)
#2      _microtaskLoopEntry (dart:async/schedule_microtask.dart:52)
#3      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#4      _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:149)
^C

$ ls -la .packages
-rw-r--r--  1 enyo  staff  7128 Sep 17 17:35 .packages
```


Glad you like it :)


Nope. If ignore_base is false and the base is valid we need to emit the `addq` instruction. If base is invalid or ignore_base is true we don't need to emit the instruction. Note that ignore_base is negated. By default ignore_base is false because: `inline void VptrToReg(Vptr s, Vreg d, bool ignore_base=0)`. I need to ignore base when using a load/store instruction: at `PatchMemoryOperand` i call: `VptrToReg(s, s.index, 1);` hence when call `if(s.base.isValid() && !ignore_base)` even if base is valid, (negate)ignore_base will be false and the instruction will not be emitted.  The instruction will be emitted only when base is valid and ignore_base is false.


I think accessibility labels are supposed to use sentence case (i.e., "Toggle private tab") so that it reads the label with the appropriate inflection.

Also, should this be "tabs" instead of "tab"?


Rather than ignoring errors, that could potentially impact others not in LXC.  Could we ignore errors only when in LXC?  I don't think we want to do this globally.


I think my code can let it get snapshot in 1ms. will improve the comment


everything looks good to me except part 6.
I think while bags are being taken to coworkers, other coworkers who have already bags can do computations. So, I guess computations need to be waited for all bags to be taken all.
So, my answer is 255+1 sec, but I think your answer seems sensible!


Not really, in the sense that only pbench-unpack-tarballs makes use of it., I'll get rid of it in pbench-base.sh and create it in pbench-unpack-tarballs instead.


`Order.findById(id).exec()`


Good! the plot looks similar to me.


yo kheel is so jobless


I'm not sure if the header files are needed at all. Why not just use `-I../3rdparty/...` in `CPPFLAGS` and simply include the headers you need? As a bonus you don't need to copy-paste when updating jq.


We also need an int LogLevel (that indicates the loglevel) in the logger class so we can select what messages we want to log and what messages we want to ignore.

>organisation


good! the same as mine


Please try to write in a non-tricky way, such that even non C developers are not confused. The two lines above look way more clear like this:

```c

    bool jsonmode = (strcmp(conversion, "json") == 0);
    bool jqmode = (strcmp(conversion, "jq") == 0);
```


Не уверен, что правильно понял суть вот этого всего.


I forgot this REVIEW: std::string as a parameter ALWAYS has const &.


hehe


and fix unlocalisation name item.tritainum_spine.name to item.tritanium_spine.name


I guess those two are not enough because we have 3 levels of directories:
* `root`
* `iis-workflows` along with `iis-core` etc
* `iis-workflows`' sub modules

So if we don't want to use `**/*/target` (because it may accidentally exclude something we don't want to exclude) let's go with:

    /*/*/target
    /*/target
    /target