is this working now?


yea, i copied this from another bit of code, but it turns out aws doesn't use consistent status strings across their apis. surprise :-)


Just a note, the commented python lines are needed for nginx as well, IIRC.


yes, this needs fixing.


fix by new cherry pick


Clever way of doing this. Looks good to me


should we have a volume type instead of using plain strings for this?


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1355 of 1355 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Not sure if this is intentional, or if I misled you before, but I think this should be:

```java
private static Logger logger = Logger.getLogger(LinkCheckerUtils.class);
```

and so on for the others below.


*Much* easier to follow, thanks :+1:


perhaps as the aws wrappers mature, we can create types for different aws identifiers to do Real Typing :tm: but i'm not sure about making types for everything in this initial run..


@yeshasimaria shouldnt put as parent activity. remove this


yessssssssssss


I'll remove the `"gold",` from this line if you don't want the gold styling on the button.


@yeshasimaria remove this line


@yeshasimaria no caps pls


74564912Issue4347BBRadConvHW (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (818 of 818 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.7%25-green.svg)


like in the ec2 stuff, maybe we should have some types for these instead of using strings


We'll have to figure something out for the G920I. It has the highlighted trustlet, but falls under the zeroflte banner (can provide screenshots if needed).


teste de uso atraves do eclipse


@yeshasimaria have u done the rails routes configuration ? Can u also change this endpoint naming to just "VENUE"


Why did you remove the subdir-objects  option?


What's this for?


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1885 of 1885 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Welcome to rectify.
I am a novice :D


Well, I'll do a brief review since I'm interested in clever multi-threading.


As a matter of policy, it's preferable to use the QMutexLocker class, rather than directly locking a mutex. In this case, if an exception is thrown while you have a mutex locked, the call stack gets blown up, and the mutex remains locked. QMutexLocker releases in its destructor (so avoids this problem)


Still does not work on EC2

2015-09-23 19:38:09 The following units had errors:
   unit: dns/0: machine: 37 agent-state: error details: hook failed: "programmable-multiple-relation-changed"
2015-09-23 19:38:09 Deployment stopped. run time: 849.62


I believe that `disable` and `enabled` are better variable names.


var goods = target.Goods;
這一段的寫法比較偏向被實作綁住了。如果沒有先呼叫 getter, 似乎就無法 assign 進去給 _goods 的 dictionary, 因為沒有初始化。這還不是主要的問題，另一個問題是，如果有兩個 Given 是針對同一集重複購買，例如 Given第一集買2本，Given第一集買3本。以 Dictionary 的設計來說，可能會把值覆寫掉。當然，雖然你的 key 是吃 Book 的 instance ，但對維護跟測試案例中的測試程式可讀性來說，用 List<Book> 做 Add ，對外部使用 PotterShoppingCart 來說，可能易用很多。

至於那個 List<Book> 裡面有沒有重複的，那是 PotterShoppingCart  自己想要想辦解決的。我是呼叫端，只管一直把我要買的東西加進去 Cart 裡面，最後呼叫結帳就結束了。


A timer without repeats is just a delay, we can get rid of this. Actually we can call this a repeat and have it be similar to `delay()`


`disable` is a better variable name than `disableVar` in this case


NOT STABLE YET. Do not merge.


Generally, we should prefer to use Globals->parallelism to QThread::idealThreadCount. It doesn't really matter here,  since QtConcurrent::run schedules on the main QThreadPool anyway (so if too many jobs are created in this way, only Globals->parallelism will be schedule), but I'd still prefer if you used Globals->parallelism


ok


:dancer:


The objective of seeking full-time software engineer position starting from January 2015 seems to be inconsistent with other sections. Do you mean Jan. 2016?


also, if you used a QMutexLocker scoped in this if block, you wouldn't need two separate unlock calls (or any explicit unlock calls)


This is on my short list to test tomorrow ASAP. If it works, MonkeyC2 is bugless until further driver testing... :tropical_drink:


Please get rid of the sleep - use waitFor instead.


wtf? Yoda?


This has to be weak, otherwise there is a retain loop


103353562-Issue-when-using-different-heating-and-cooling-airflow-rates-with-Airflow-Network-#5134 (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1891 of 1892 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


This is what I have:
```
public class C4Timer : NSObject {
    public private(set) var interval: NSTimeInterval = 0.0
    private var action: () -> ()
    private weak var timer: NSTimer?

    public init(interval: NSTimeInterval, action: () -> ()) {
        self.action = action
        self.interval = interval
        super.init()
    }

    public func fire() {
        action()
    }

    public func start() {
        guard timer == nil else {
            return // Timer already running
        }

        timer = NSTimer(timeInterval: interval, target: self, selector: "fire", userInfo: nil, repeats: true)
        NSRunLoop.mainRunLoop().addTimer(timer!, forMode: NSDefaultRunLoopMode)
    }

    public func stop() {
        timer?.invalidate()
    }
}
```


Commit is OK.


I don't think you need the comma after compliance.


Fixed


Add a Hive error code for this


thats cool


Speedy!! Well done, @patrick-steele-idem!


>  .. and enumerating all the entries in the map was not much more expensive than looking up the last
> entry in the file, so it made sense.

That OS X is slow is no excuse for *not* using it on other OS'es. It's nice to see the name of the "well-known services" in a tcpdump. Instead of remembering that port 514 is `syslog`. Wireshark does this, why not tcpdump/windump too?

A typical `%SystemRoot%/drivers/etc/services` file (default in a Win-8 installation) is 20 kByte. So it should take 10 usec to load and parse **once** at startup.


you missed one. `"both"` is currently broken because of this.


TaskCluster, Authorization Failed ```{
    "info": "None of the scope-sets was satisfied",
    "scopesets": [
        [
            "queue:*",
            "docker-worker:*",
            "scheduler:*"
        ]
    ],
    "scopes": [
        "assume:worker-type:test/test",
        "assume:worker-id:test/test",
        "assume:scheduler-id:*",
        "scheduler:*",
        "queue:define-task:test/test",
        "queue:create-task:test/test",
        "queue:define-task:test/test",
        "queue:claim-task",
        "assume:worker-type:test/test",
        "assume:worker-id:test/test",
        "queue:report-task-completed",
        "queue:resolve-task",
        "queue:route:tc-treeherder-test.*",
        "queue:route:tc-treeherder-test*",
        "queue:rerun-task",
        "queue:route:taskcluster-github*",
        "docker-worker:cache:*",
        "docker-worker:feature:*"
    ]
}```


I write the code very fast and may has typos xD... after I test it, but atm is a little ugly the UI (some sleep, or something lol), if somebody can do some beautiful with it... is welcome xD


correct solution it didn't fail on my side because my system can handle the shortcut


What? From 0.33.1 to 0.30.7?!


Thanks, this is also in preparation for #113 which I will do next


Why are you re-saving photos?


well sorta correct, didn't need to move the /images/spacer.png into the echo but the <? to <?php was the bugfix


This comment matches the name but seems not to match the behavior, which is to return the number of groups (so it returns `max + 1`)


is that right?

``v3.1.8.3`` vs ``v3.1.8.3.2``


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/82031441


aha, that's a good point.

How do you think I should go about testing that?


`service`s renders in a way that breaks the flow of my reading.  Also repetition of component. How about: The metaconfig component contains a `dict` called `service` where the keys of the dict are the names of the files to be generated.


Merged here.


Primer Comentario


output is here: https://springrts.com/dl/buildbot/doc/


The include here seems to unnecessarily complex. Why not just define the type in the same file?


Sólo nos faltóla plurazación :stuck_out_tongue:


This statement works for `Python 2.6`.


Yes I agree, a getter would be better


Why though? Spaces should be valid; anything `zfs` accepts should be valid. Any error from `zfs create` should just halt the script and undo anything it has done.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 710](https://teamcity.labkey.org/viewLog.html?buildId=274074&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:27:33
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 23 more failed tests, see build details
```


This is good. I recommend that in removeDelegateForTask you remove the associated object or set associated object to nil. This will protect against future changes to this file that might change how and when delegates are set/unset. (Yes I have something in mind but I'm not telling yet.)

After that change +1.


Ok, so I created a new file named skis.png containing a single metallic texture for the skis, but to which branch should I push it?


Perfecto, muchas gracias por la edición.


Putting TextRender in `` seems inconsistent here since you haven't used it for metaconfig since the first time you used it. I see the value in using `` for technical items the first time they are used but it seems like a lot extra typing to keep doing so all the way through?


Good catch! I'll get a patch in for this.


I Imagine that most Eatables will have the same implementation as in PlayerFish and EnemyFish. In fact, because it's the same, wouldn't it be easier to make that a default implementation? If we later have an Eatable that does not follow the size larger than the other rule, that class can simply override it.


Space, same as in filesnames, should be banned from usage, even if ZFS
does not have problem with that, but its only my opinion.

Regards,
vermaden

On 09/24/2015 22:09, Bryan Drewery wrote:
>
> Why though? Spaces should be valid; anything |zfs| accepts should be
> valid. Any error from |zfs create| should just halt the script and
> undo anything it has done.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vermaden/beadm/commit/7c1b1de2a6af28ae3c8dc230a715a3096ecb64ad#commitcomment-13424139>.
>


Также советую рассмотреть Glide (в целом немного лучше Picasso) и Fresco


Why do this?

And why modify the CURRENT entropy file just because a BE is being created? Maybe the BE is not being booted into. I would expect `beadm create` to not modify my current system at all. This is not even in the `beadm activate` code. Can _/etc/rc.d/entropy_ not already handle this?


please send me patched kext AppleHDA


`eval` and manual check for compilers, see some ES6 tests.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.609](http://teamcity.monogame.net/viewLog.html?buildId=10273&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


is work on 10 6 8 and vt1802p?


https://github.com/ironcladlou/GoTools/pull/116

I cut a new version `0.1.7.1` for this. Thanks.


Links are not available , what to do?


This `else` is redundant


>  It's nice to see the name of the "well-known services" in a tcpdump.

Yes, but should that be done by having tcpdump scan the entire services file and build its own index, or by having tcpdump call `getservbyport()`, which *does* exist in Windows, to look up the ports (and cache the results)?


I turns out I can’t type.


I suggestion making this method default and simply do kill(), as most of the times that will happen. If Eatables don't want to get killed when they're eaten, they can just as well override it.

<organisation

<organisation


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21174/testReport/) for this commit**


Не реализован CollapsingToolbar. Нужно было использовать android design support library.


If we move a few variables above the `if`, this redundancy can be removed


Note that a monotonic clock is guaranteed to always return a bigger value for a time in the future. With `gettimeofday` the time may jump unexpectedly and cause weird bugs.

https://www.softwariness.com/articles/monotonic-clocks-windows-and-posix/


if you include es6-shim:
```js
Array.from(document.querySelectorAll('iframe').forEach(function() {...});
```
:P


TaskCluster, Authorization Failed ```{
    "info": "None of the scope-sets was satisfied",
    "scopesets": [
        [
            "queue:*",
            "docker-worker:*",
            "scheduler:*"
        ]
    ],
    "scopes": [
        "assume:worker-type:test/test",
        "assume:worker-id:test/test",
        "assume:scheduler-id:*",
        "scheduler:*",
        "queue:define-task:test/test",
        "queue:create-task:test/test",
        "queue:define-task:test/test",
        "queue:claim-task",
        "assume:worker-type:test/test",
        "assume:worker-id:test/test",
        "queue:report-task-completed",
        "queue:resolve-task",
        "queue:route:tc-treeherder-test.*",
        "queue:route:tc-treeherder-test*",
        "queue:rerun-task",
        "queue:route:taskcluster-github*",
        "docker-worker:cache:*",
        "docker-worker:feature:*"
    ]
}```


StatCollector.translateToLocal is the old way, I18n is the proper/new way.
My concern is the key name to use in the .lang file: container.weaponbox.nextbutton or container.weaponbox.btn.next or button.next or something


Who are you

On Thursday, September 24, 2015, Bedndarc <notifications@github.com> wrote:

> Links are not available , what to do?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EpicGames/Signup/commit/888ab3ee6e3c145d3fee45ca6e6418e4c92ba9d2#commitcomment-13424210>
> .
>


auto_fit не подходит, в задании было четкое количество столбцов для всех ориентаций / устройств. Нужно было создать папки values, values-land, values-sw600dp, values-sw600dp-land и в них поместить ресурс типа integer для количества столбцов.


Add a TODO to put this in a helper


Все-таки стоит избегать использования inner классов, когда для этого нет необходимости.


should the `else` and ` endif` but on separate lines?


Missing newline


Стоит отказываться от GridView, ему на замену лучше использовать RecyclerView + GridLayoutManager


code identique L145 donc à sortir du if else...


We should probably just make a new PR out of this one, or merge it into the other PR soon.


This is the first use of the acronym TT in this part so I suggest spelling it out here and then you can use TT the rest of the doc. (Perhaps also linking to the TT library docs?)


Does current code implicitly throws Exception in case error occurs in methods?


D'oh!


r+


Initialize in declaration


I'll go ahead and revert it this evening and open a PR with propositions
for future go direction.

On Thu, Sep 24, 2015, 03:15 Jaka Hudoklin <notifications@github.com> wrote:

> @edolstra <https://github.com/edolstra> @wkennington
> <https://github.com/wkennington> let's try to do it right, can we instead
> of reverting, split binary packages from go packages. We depend on this in
> production.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/d0179b917ee24e4735051f06a65c908d622c7a96#commitcomment-13411122>
> .
>


This is never shutdown


Didn't even realize you were paying attention to these. :)

That will be nice to use. I can't justify pulling in any more js yet until we get the page load faster. It's struggling  bit now.


Ох зачем так жестко :)


Nice, thanks!


very basic.. but I guess its doing its job


saw approval from jedmccaleb
at https://github.com/jedmccaleb/stellar-core/commit/501eb9de4236f3f9fc31912b909a979ee92f4a4b


Link to the PAN book here.


merging jedmccaleb/stellar-core/master = 501eb9de into auto


jedmccaleb/stellar-core/master = 501eb9de merged ok, testing candidate = bd8b6d00


In some cases it is although we only save a return. But how we discuss we (all together) decide implement it! Do you remember? :)


What's the reason for using this type of executor? This should probably use the direct constructor that allows a named thread factory


sorry about this, total mental lapse there. Thanks for catching


It _works_ fine in ZFS though. It's an arbitrary restriction in the script.

<pre>
# zfs list -r "zroot/foo bar"
NAME            USED  AVAIL  REFER  MOUNTPOINT
zroot/foo bar    19K   104G    19K  /foo bar
# ls "/foo bar"
./  ../
# zfs snapshot "zroot/foo bar@snapshot space"
# zfs list -rt snapshot "zroot/foo bar"
NAME                                                    USED  AVAIL  REFER  MOUNTPOINT
zroot/foo bar@zfs-auto-snap_weekly-2015-09-20-00h14        0      -    19K  -
zroot/foo bar@zfs-auto-snap_daily-2015-09-24-00h07         0      -    19K  -
zroot/foo bar@zfs-auto-snap_hourly-2015-09-24-20h00        0      -    19K  -
zroot/foo bar@zfs-auto-snap_frequent-2015-09-24-20h15      0      -    19K  -
zroot/foo bar@snapshot space                               0      -    19K  -
</pre>

The real fix is to quote parameters to `zfs` to retain spaces.


В случае использования DAO обычно создают интерфейс DAO, который потом реализуют разные классы. Это делается для лучшей модульности и большей гибкости.


Shouldn't the third parameter here be `true`, because that is `allow_generate` and so the command can't be used to pre-generate the map.


wow, good job!


@peterwilli https://github.com/johnmuhl/electron-prebuilt-updater/issues/2


What does this achieve, exactly? What's wrong with the existing behavior, where the exception is propagated out of ExoPlayer.Listener.onPlayerError method? Note that you can call getCause() on the exception propagated to this method to discover the underlying reason for the failure.


almost doesn't count


Just to comply with google python code standard you should always use absolute path for importing.


I meant #104


Для создания диалогов очень рекомендую эту библиотеку https://github.com/afollestad/material-dialogs Тк обычные диалоги на четверках выглядят очень убого


> Keine Ahnung ob ich die Distanz richtig berechne?

Also Luftlinie ist immer kürzer :)
Aber wenn Du die distance estimates verwendest die viel schneller sind als die präzisen, kann es in seltenen Fällen (aber eigentlich nicht in DE-Breitengraden) zu solchen Problemen kommen. Für die verschiedenen Distance Messungsklassen -> siehe DistanceCalc*

> Diese braucht auf meinem Rechner aber schon ein bisschen zum Starten.

Ja, leider ist das durch maven so

> Wie ist eigentlich der Entwicklungsworkflow? Gibt es hier einen besseren Weg? Z.B. Hotdeploy, Debugging aus der IDE etc?

Gute Fragen! Und ja geht besser! ... habe das mal hier beschrieben:
https://discuss.graphhopper.com/t/how-to-develop-or-change-stuff-in-graphhopper-and-use-ide-features-like-debugging-etc/154


Si tu ne parles plus directement de boucle événementielle, il faudra peut-être changer le titre.


Support for 'space' would probably require beadm rewrite, but I can do
that. My fear is about *vfs.**root.mountfrom*, does it support 'space'?

Regards,
vermaden

On 09/24/2015 22:20, Bryan Drewery wrote:
>
> It /works/ fine in ZFS though. It's an arbitrary restriction in the
> script.
>
> # zfs list -r "zroot/foo bar"
> NAME            USED  AVAIL  REFER  MOUNTPOINT
> zroot/foo bar    19K   104G    19K  /foo bar
> # ls "/foo bar"
> ./  ../
> # zfs snapshot "zroot/foo bar@snapshot space"
> # zfs list -rt snapshot "zroot/foo bar"
> NAME                                                    USED  AVAIL  REFER  MOUNTPOINT
> zroot/foo bar@zfs-auto-snap_weekly-2015-09-20-00h14        0      -    19K  -
> zroot/foo bar@zfs-auto-snap_daily-2015-09-24-00h07         0      -    19K  -
> zroot/foo bar@zfs-auto-snap_hourly-2015-09-24-20h00        0      -    19K  -
> zroot/foo bar@zfs-auto-snap_frequent-2015-09-24-20h15      0      -    19K  -
> zroot/foo bar@snapshot space                               0      -    19K  -
>
> The real fix is to quote parameters to |zfs| to retain spaces.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vermaden/beadm/commit/7c1b1de2a6af28ae3c8dc230a715a3096ecb64ad#commitcomment-13424389>.
>


As per comment on this entire pull request, I think you are wrong on CA and AU

they should not have commas
http://auspost.com.au/education/letterwriting/students/addressing.html
https://www.canadapost.ca/tools/pg/manual/PGaddress-e.asp?ecid=murl10006450

in the US I know putting comma between city and state is very common in practice, I am not sure it is the true standard though
http://pe.usps.com/businessmail101/addressing/deliveryAddress.htm


Очень древний и очень плохой контейнер


Should this logic be in `PartitionCommitter`? It already has a metastore and is directly creating the partition, so it should probably also drop them itself


Maybe we'll figure out something we can agree on in a future PR as I still
completely disagree with the above.

On Thu, Sep 24, 2015, 03:10 Jaka Hudoklin <notifications@github.com> wrote:

> @wkennington <https://github.com/wkennington> can we come to consensus
> here please. I know you maintain a lot of go packages, but I think
> @edolstra <https://github.com/edolstra> has a point.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/2f3eb5e0eff9958999245fb8ae9f2702480cf6c6#commitcomment-13411076>
> .
>


I saw it in slack.


`vfs.root.mountfrom` is not needed. I have it commented out in my loader.conf.

I don't think it would take a rewrite, but yes a lot of work.


This method is committing a table creation. Shouldn't it drop the table on rollback? And if it drops the table, no need to drop partitions first?


I think you are missing a return here :wink:


`vfs.root.mountfrom` isn't needed on at least 10+.


Top, da hätte ich dran denken sollen :-)


На 100% не скажу, но это вроде как не работает. BATTERY_CHANGED можно регистрировать только локальные ресиверы. Тут нужен либо сервис, который будет постоянно мониторить состояние батареи, либо использовать BATTERY_OKAY + BATTERY_LOW


Can you keep this within 80 char limit.


не надо такие страшные названия, пожалуйста :) у java и Android есть вполне определенный стиль именования


Why do we need to disable info test?


To me a 'UNIX Person' does not use spaces for such things as ZFS
datasets and/or LVM volumes but this becomes theoretical discussion, not
a technical one ...

On 09/24/2015 22:25, Bryan Drewery wrote:
>
> |vfs.root.mountfrom| is not needed. I have it commented out in my
> loader.conf.
>
> I don't think it would take a rewrite, but yes a lot of work.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vermaden/beadm/commit/7c1b1de2a6af28ae3c8dc230a715a3096ecb64ad#commitcomment-13424484>.
>


Fix indentation :)


séparer cette logique dans une autre méthode...


Hi
Too much properties.
Is it a better solution?
```objc
@property (nonatomic) UIEdgeInsets chartMargin;
```


Сомнительно, что здесь нужна база данных. Такие настройки можно хранить и в SharedPreferences


Remove unnecessary spaces.


fix #3


Just consistency


Change the environment variable to something like `AF_MULTI_GPU_TESTS=0` or something such.


Styles have to be contained in the `<head>` at the top of the page.


I did improvements as you suggested.
* Restored trigger control, removing some stopwords before checking two words pattern
* Add some non-trigger examples in tests
* Add some primary and secondary query examples
* Put trigger words as _start_ (except `password` as _startend_ trigger, to handle `generate strong password` for example)


This no russian locale.


#30143 appears twice! One should be enough... ;-)


This seems to duplicate the exception logic in the above method, but slightly differently (non-recursive delete). Why do we need it in both places?


bizarre on ajoute au datatstore à chaque appel REST sans cache ?????


I see a lot of `.timeline > li:after` and `.timeline > li:before`. You can consolidate all the styles together.


Nope, because of two insecurities:
1. It doesn't wait until the area is emerged, but simply tells the emergethread: "if you have time, please emerge those"
2. after the area has been emerged, you can't be sure how long it is that way, because the server will unload unused areas.

Therefore, the only legal use case is for calling the mapgen.


I think there are other tests that run on multiple devices as well.


I'd remove the trailing blank here.


Is this true for S3?


Файл содержит неоднозначную разметку. В одних местах отступы по 4 пробела, в других их вовсе нет. Лучше использовать одно общее правило для всех тегов.


c'est quoi "code" ?


proger


This is looking awesome! Though I can't see any of the dragon's images at the minute.

On another note, would it be a terrible thing if I separated the data collection aspect of my program into a new one that just created information files that our programs could use? Would it only be terrible if I published it?


Le lecteur fera-t-il le lien entre le mot-clé `yield` et l'attendre d'un évènement ? J'aurais plus simplement dit un truc du genre :

> ces tâches étant implémentées sous la forme de coroutines. Comme nous souhaitons effectuer plusieurs tâches en parallèle, il ne nous reste plus qu'à trouver un moyen d'exécuter plusieurs coroutines de façon **concurrente**


This comment should go now, right?


It definitely does not work on 10.6.8. It will not work on anything lower than 10.8.


No these are the only 2 files with setDevice/af_set_device calls


Hi Remy,

That's cool! I played briefly with intercepting system calls,
specifically, by patching CDE, ( http://www.pgbovine.net/cde.html ) ,
but I was running into trouble with some of our larger Java and Ruby
services. I *think* there may have been dependencies that were just very
rarely excercised in the course of the runtime.. ie possibly there were
dlopens that didn't fire under normal conditions or etc..

I might have just missed something, or did something silly. Really I
didn't have much time to focus on this but given the attention it seems
to be getting I have been thinking about rewriting it in go to use
libcontainer directly instead of calling docker commands.

I'll definately check out reprozip though, thanks for the heads up!
Also, sorry for the slow reply, I only rarely check this account. Feel
free to email me at work though (dave@librato.com) because that gets
checked daily.

--dave

On Thu, Sep 10, 2015 at 08:37:51AM -0700, Remi Rampin wrote:
> As far as I understand this, it statically detects linked libraries using ldd right?
>
> I have a tool, [ReproZip](https://github.com/ViDA-NYU/reprozip), that can find *all file requirements* using dynamic tracing (ptrace) then generate a Docker image from that.
> I always intended it to run on your host machine and "dockerize" (or "export") your app or software experiment, but if I follow your example and run it on an existing image, I would effectively be shrinking it :open_mouth:
>
> (came here from your [blog post](http://blog.librato.com/posts/docker-images), but couldn't comment there, so here we go)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/djosephsen/skinnywhale/commit/5936625032e2e8031bab7fa53d43eb8372251233#commitcomment-13162903


You have two `<i>` start tags.


You can also use a `<br/>` to create a new line.


No closing `</ul>`.


This should read return PVR_ERROR_SERVER_ERROR;


Pas faux.


The rollback method will be called if the commit method throws an exception. Commit might fail because someone else already created the table. If using the final location for the write path, as in S3, this could delete the wrong data.


Yo I can't find your .xcodeproj file. Glad you're using Swift though!


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.609](http://teamcity.monogame.net/viewLog.html?buildId=10273&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:18:52


Unless we always use random paths for new tables.


Ah yes, I've pointed out @kwolekr to fix that, but both he and me read the implementation of the method wrong, and we thought the param doesnt influence generation, and only is used for queues. But it does:

https://github.com/minetest/minetest/commit/f062bbd7a182233f96c61287d0397534811627d9#diff-1dc3934293fad6b8769890134ac51c21R248


Why this is removed??
-FinnT730 (Creator)
Me: Its not needed....


`orchestration build-info`


ha, incredible that they support labels in java, that means there's a `goto` like keyword right?


I'd put this either in a static member function or in an unnamed namespace.


build-info


Ты используешь форму с сабмит кнопкой. Но не используешь её по назначению (так как делаешь return false в submit секции). Далее подписывашься на клик по сабмит кнопке. Возникает вопрос: зачем юзать форму? Можно ведь и обычными дивами тогда заверстать ;)


With this added in, are the list and retail just optional and rate will still return the price as always?


В общем использование onXXX хендлеров в html - это плохой стиль ;)


No inline styles and organize things into folders

```
/assets/images/
/assets/javascript/
/assets/css/
```


This should be `Incrementable`, not `Integral`. Iota views of iterators are very useful.


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/82037906


No tabs, 2 space indentation.


ResectionSquaredResidualError has moved to the Localization API
I don't get the point about the dPrecision parameter... since now it is embed in the resection data struct.


Было бы круто, если бы основные секции с HTML были закомментированы. Всмысле описано было, за что они отвечают.


I went with a quick fix for now because I basically just needed one specific mode. I think long term, we want something like the following:
```
syntax Int ::= #open(String, OpenMode, Set)
syntax OpenMode ::= "O_RDONLY" | "O_WRONLY" | "O_RDWR"
syntax OpenFlag ::= "O_APPEND" | "O_CREAT" | ...
rule open(S:String) => #open(S, O_WRONLY, SetItem(O_APPEND) SetItem(O_CREAT))
```


@jakep does not approve of the inline style.


You should make all of these constants static.


I'm not sure if it ever makes sense to memoize a fn that returns a channel. It seems if we call the fn with the same arguments a second time it will return the same channel, as per the contract by memoize. That channel may have already been modified and not have the same values on it. I think we should remove the memoization.


indentation? here and below...


Sos un capo ruludo, sacando dependencias bien ahí. Hoy voy temprano a la cerveza con los pibes, 18.30.


This would require us to actually annotate these types in the store, right?


aah yeah ayou also haha i felt i forgot something tho :P


Right now we just treat them all the same once they're imported


`rate` and `currency` are still the quoted rate. List is for non-negotiated account rates and retail is the rate if you went to the post office and bought the postage.


Первая проблема здесь - это глобальные функции. Общее правило гласит: не создавать глобальных функций. Желательно создать отдельный namespace, например App.todo.addData() и App.todo.removeEl() и т.д.


That's the same conclusion I reached and effectively what I've done. I'm now memoizing a function that *takes* from the channel.


> ... having tcpdump call getservbyport(), which does exist in Windows,..

Ok, fine. But `getservbyport()` is present in Vista onwards. So no Win-XP support.


unnamed namespace or static member function?!


No problem, thanks!


two empty lines in a row intended?


(already set manually ingame, no need to merge for this commit)


indentation? here and above...


https://www.unrealengine.com/ue4-on-github
STEP №2
and read the mail!


rax retry tests


Thanks, fixed in 24157128295b9c23c8002e419abd69a7b6b5a1eb with subtests, and re-added babel and traceur as passing one of the two tests.


Going back to my point above - this is specifically describing an ACI since other image types might have different schema


Addresses #4


Version is optional in ACIs: https://github.com/appc/spec/blame/master/spec/aci.md#L222


can we make this an argument with a default value?


extra whitespace


Thanks, Faber :)


> shouldn't we use the same QucsSettings implementation throughout the whole project?

practically, yes. The code (smell) above is present in most/all of the Qucs GUI+Tools, copy/pasted, ...

> why not put this code into QucsSettings::QucsSettings(const sometype& settings)?

you mean having a class that handles this used by all the GUI+Tools. Will surely make sense.


Commit has been amended  and ready to be merged :)


explanation


"for a detailed explanation of each state"


States before the pod is running.


This was WRONG.  I am glad I left the original code commented out, since I was not sure.  The other usages of split IS right, but the $opts{argv} already IS an array, so we should not try to split it.  Doing the split simpyl gets us the 'string' ARRAY(0xsomehex) as the value.


After you have pushed the file, the next commit will be processed by Travis.

Did you set up your project at travis-ci.org?


At some point we'll need to figure out naming here. End users should not know or care about the optimization algorithm when creating a pipeline - at least we could make this a parameter?


@bgoodri Should this `offset <- double(0)` line be here or was it just intended as something temporary for the initial commit that needs to get fixed? Looks like this removes any user-specified offset.


I don't think we want to talk about the locking here, seems like an implementation detail


Thanks for the reminder @ryanwiemer.
https://github.com/ResponsiveImagesCG/wp-tevko-responsive-images/releases/tag/2.5.0


Also undo this.


And this.


Why inject `$window` here?

Unless you need to mock out `eep`, I'd just use it directly as a global.


OK, sorry for my emotions. I now see that only the strongest patches pass.


Hey, this is cool.  Give me a pull request when you get this working so I can incorporate it into master.


It would be nice to have a _little_ more detail about what's happening during each state, though


Probably something temporary.

On Thu, Sep 24, 2015 at 4:44 PM, Jonah Gabry <notifications@github.com>
wrote:

> @bgoodri <https://github.com/bgoodri> Should this offset <- double(0)
> line be here or was it just intended as something temporary for the initial
> commit that needs to get fixed? Looks like this removes any user-specified
> offset.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stan-dev/rstanarm/commit/c4bfe6dcb423492eeabd7a1365a6e1c77ae3de87#commitcomment-13424915>
> .
>


There are still several calls to revisionID() in the code, for example in expandFns.php and category.php. These should be removed.


...and that's exactly what you've done here. You're memoizing what comes off the channel.


yeah, this repo is abandoned I think. This issue is over a 1 y/o so I don't it's ever going to be merged


And also the comment in GetTimers. Maybe there are some more of this kind around?


The ID of the pod, in the form of a UUID


Didn't we figure out a way around this without duplicating code? Let me double check my code..


No, the dragon images require image files which are not up here.  There was a backup image file, but that is also an image file.  I'll see about making a non-image image, that is a square.

You mean secretly breaking the rules?  I could not condone that.  For one thing, you would have to link people to it, and the admins would be able to follow the links too.  One way or another, they would fine it.  Also, I think the reason auto-server scraping is not permitted is you could probably do a lot of malicious things with automatically gathering data.  I think servers have ways of telling when they are being connected to via a program versus a human, and even if the program was not connected to your account, they would share an IP address.  Best not to risk it, I say.  People put all this data into spreadsheet anyway, what's another program?  And if we do manage to create a family of affiliates with compatible save file formats, people would like it.


TeamCity Gribble ORM :: Deploy [Build 1.6.133.0](http://build.mikeobrien.net/viewLog.html?buildId=2471&buildTypeId=gribble&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 412 Build time: 00:02:50


represents


Oh, yes I think a lot can be done in this regard.  My changes were basically in line with existing properties in some of the other graphs.


indentation here is off our standard formatting.


please remove commented code.


well, what I wanted to do is just rename `QucsTranscalc::saveModes` to `QucsTranscalc::saveModesFile`. I may see that in an ideal world `QucsTranscalc`should not implement file I/O but it did already and my goal was just to make it work properly again.


Call to revisionID() should be removed.


Please move to either zeroth article or indefinite article across the board.
Zeroth article: "Name of the app."
Indefinite article: "The name of the app."

"Image used by the app." / "The image used by the app." , etc etc


typo: Successful has two c's


Sounds good!


separate `LowerCase` into its own line? Does it need `()`? Same with `Tokenizer()`?


You right :)


Tout l'exemple est le développement d'une boucle événementielle. J'ai juste viré l'épithète ici parce que ça alourdissait le texte.


А почему li элемент называется e, а "а" элемент называется а? ))) Лучше уже liEl и aEl


These two steps should probably be hidden from the user (Optimize and apply) - but that can be saved for a future PR.


Also, there is still an $edit_initiator in category.php.


Ah interesting.

It wouldn't be a huge lift for me (and I think it would be helpful) to
write the content for a variety of tables, but we can coordinate that post
launch, if we want to go simple for now.

?

On Thu, Sep 24, 2015 at 11:11 AM, Joshua Carp <notifications@github.com>
wrote:

> This is a generic placeholder and would apply to many tables (independent
> expenditures, electioneering costs, candidate and committee filings, etc.).
> The language above makes sense for filings, but probably not for
> electioneering or communication costs. If necessary, we can write different
> text for each table, but it would be simpler to use a single generic
> message.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jmcarp/openFEC-web-app/commit/ba1cf24356292108b9cdff326fc3eab2f1992c79#commitcomment-13417583>
> .
>


shouldn't it be "${@}" everywhere ;) ?


Я уже писал выше про onXXX хендлеры. Лучше юзай addEventListener()


Yup, LowerCase takes locale (w/ a default parameter), and Tokenizer takes a separator string (w/ a default parameter). If anything "Trim" is the outlier here because it'd could be nice to be consistent about everything requiring a '()'


Does this note need to be there?


Lets just move them to the -cli package, you can't run pacemaker without that installed anyway.


I'll also update this in the newsgroups pipeline


wide line


If you can add descriptions for any of these classes, it would be helpful.


wide line.


is snake_case more idiomatic than camelCase for protobufs?


Also a wide line!


I can't right now think of a malicious use of a lot of dragon data, but you're probably right. No data mining then, that's a shame. I do like the idea of a tool family with shared file type :)


    void writeLeds(n); //activar led's del 1 al n que se le da como parametro
    void writeLeds2(n,m);//activar led's del 1 al n que se le da como parametro; en el primer multiplexor el rango es de 1 a n, mientras que en el segundo es del 9(el primer led del segundo shield register ) al m
    void begin(int, int, int); //metodo para inicializar. (latch, clock, data)
    void darPines(); // imprime por el monitor Serial los pines definidos como lactch, clock y data
    void apagar(); //apagar todos los led's
    void mostrarUno(int); //prende solo un un led del 1 al 8

    int darUltimoData1();
    int darUltimoDataBit1();


clean this up?


I think you were looking into some stuff to do it using reflection, I just gave up and copy/pasted and force cached because I needed to get the paper experiments up and running.


@phoney—I can't guarantee that the association will be removed in all cases, since in `removeAllDelegates`, we don't have a pointer to every task that this session manager is responsible for. If that's alright, I'm happy to half-solve the problem for you!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21176/testReport/) for this commit**


I'm not 100% positive all the optimizers are multi-class, but for now I can just take out LBFGS from the name and we can make them parameterizable later?


Aren't fp/lr/sp normal registers which are in the __x array ?


s/the rkt/rkt/


s/the appc/appc/


:hamburger: :+1:


Actually, removing the association there would break the case where data tasks become download tasks (the call to `removeDelegateForTask:` at `AFURLSessionManager:1036`). I'm not sure that's the right place to remove the association.


Oh whoops I need to undo that


> Le lecteur fera-t-il le lien entre le mot-clé yield et l'attendre d'un évènement ?

Oui. S'il ne le fait pas immédiatement, il le fera plus tard. Dans tous les cas, on explique plus haut que `yield` sert à suspendre la tâche. Donc la suspendre pour en laisser d'autres bosser en attendant d'être reprise, et la plupart du temps, la tâche sera reprise sur un événement. Sauf que s'appesantir sur la notion d'*événement* ici compliquerait le texte, tous les exemples suivants consistent à programmer des événements pendant lesquels la tâche est suspendue. Bref : "en attendant un événement (tout court)", c'est relativement intuitif et ça suffit à légitimer pour l'instant l'appellation "boucle événementielle".

Encore une fois, ce n'est pas parce que le lecteur n'a pas (encore) eu des explications exhaustives qu'il ne comprendra pas le texte. Le but est de "construire" la programmation asynchrone en N exemples. Si l'utilisateur pouvait piger *tous* les détails du fonctionnement de la boucle dès le premier exemple, l'article s'intitulerait "UN exemple pour comprendre la programmation asynchrone".


My bad. I thought that names starting from "'datasource', 'datasourceOrganization_provision_isProvidedBy'" correspond to tables, but apparently they are columns. So anyway, would it make sense to not hardcode them in this script?


is this Epoch time?


This library allows you to use RFM69 over softSPI while using another SPI peripheral.
It is a modified version of RFM69 library by Felix Rusu (LowPowerLab). It's structure is similar to rf24_softSPI. The SoftSPI library is by William Greiman. The only modifications I've made here are to create a soft spi addressable RFM69 instance like in rf24_softSPI (sorry, I don't know it's author).

To use this library, copy each folder to your Arduino additional Libraries folder. Then select 'Import Library' in Arduino like you would for any other library.

The default settings are:
	MISO	- pin 16,
	MOSI	- pin 15,
	SCK	- pin 14,
	NSS	- pin 17,
but you can change this by going into your RFM69.h file in the RFM69 folder and modifying the lines:

const uint8_t SOFT_SPI_MISO_PIN = 16;	// choose your own MISO pin if you wish
const uint8_t SOFT_SPI_MOSI_PIN = 15;	// choose your own MOSI pin if you wish
const uint8_t SOFT_SPI_SCK_PIN  = 14;	// choose your own SCL pin if you wish
#define RF69_SPI_CS 17						// choose your own DATA pin if you wish

Note: Don't remove the original RFM69 library folder - just copy it. If you want to use hardware SPI again you have to return to the regular version of RFM69.

Additionaly at example cataloque you find the Fritzing images show the connections of RFM69 module to Arduino (Mega, Pro Mini).


Is this future proofing or does every RPC require an argument?


Yeah - that ended up being done here: https://github.com/etrain/keystone/blob/dag-estimation/src/main/scala/nodes/learning/LogisticRegressionModel.scala

Let's get @shivaram's opinion.


Where are the prompts in the test suite?  When i run it it says waiting for message...i assume i'm suppose to run gpsfake but when i do it goes on forever...didn't spend too much time here -- assume its a simple addition of a printf in the test function to tell user what to do?


s/the image/the specified image/


it was just plain wrong. It didn't pass plugin plugin->cb_data, but i guess at one late night I read it that way and came to the conclusion that was freed before (by the cb_data_destroy invocation). But I when I read it again the other day I saw the mistake.


This merge shows no changes, even though it should have caused `file1` to be deleted in Branch-1.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21178/testReport/) for this commit**


You can either pull ski and add it to that and push it back, or make a new branch called skitext or something and push it and I can grab it from there and then I will delete the new branch, or you can post a zip somewhere, thanks.


Don't we need to unset client_id?


and the other 3?


interested, but interesting would probably be better


The branch this commit is in was originally targeted at Play 2.3

This work was taken and revised in
https://github.com/playframework/playframework/pull/4142
and incorporated into Play 2.4

Same origin requests should be working, at least there are a couple of tests for it in that PR
https://github.com/playframework/playframework/pull/4142/files#diff-167641178be120c7267385e24a7fa5aaR117


Can you add a white block to the texture to represent "painted white metal", maybe a little dirty, or off white? I'll use it on the braces and the axle holder.


This taks (`[| A-->B; A-->B-->B |] ==> A --> C` in Isabelle lingo) is not actually provable, or am I missing something?


oops, my bad, sorry I completely missed the changes in sfm_robust_model_estimation :-)


It doesn't really matter. It doesn't affect anything.

On Thu, Sep 24, 2015 at 4:01 PM, Graham Campbell <notifications@github.com>
wrote:

> and the other 3?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/socialite/commit/0d2cde649e0fb3008ea001c4e1a9506d8e7955f9#commitcomment-13425288>
> .
>


I disagree. There shouldn't be any noise introduced by files that are clear not belong to proxy A.

Since they might belong to proxy B or an ordinary plugin that would just useless noise everytime Geany is run or the PM dialog opened.

A plugin author who creates files for a proxy in an incorrect way will find it sooner or later (at last through a break point in its probe), and it should be a by far a more rare case.


mistake


Added the changes. Call Pickup/Intercept within a ring-group with 2x8 multiple registered devices on 8 extensions works like a charm right now. Please commit.


Mind if I do something like ```<div class="content-l_col
                              {%- if loop.length == 1 -%}
                                  content-l_col-1
                              {%- else -%}
                                  content-l_col-1-2
                              {%- endif -%}
                                  ">``` to keep the spacing on the classes aligned?


sure


Eliminate errors and can this closed?


Are you trying to coerce open to a boolean value? You could also use `open = !!open`.


Nice


https://en.wikipedia.org/wiki/Fail-fast ;-)


Ops... I sent the clean Ramdisk to Alu but completely forgot to update this repo...! Shame on me!! :-P


@andresilvasantos top-vlc needs this as well. New build running smoothly.


Hey, checked you project. Well builded requirements, but you forgot a point about end-user characteristics, fix this one, please.


I'm mimicking what I see in ReportsFactory.cs which seems to only allow the color option to be set for windows environments


Cool!


Yup, only use of `$window` is for eep, I can just use it as a global in future code.


Thanks for reminding me, i'll fix it ASAP.


@jonboulle probobuf 3 removes the optional and required keywords, everything is optional by default.https://github.com/google/protobuf/releases/tag/v3.0.0-alpha-3


cleaned up unit tests to always return booleans, add manual hooks for running unit tests, and fixed unit tests that left the database open on success, which could cause subsequent tests to fail


Thanks! BitHub has sent payment of  $34.15USD for this commit.


Ok


fdsafds


I think it might be better to make all the required changes together in a batch for the issue you referred?


@yifan-gu ok that's fine (although raises another question: should we be making more fields "required"?). But I think it should be called out here explicitly that version is just another label and might not be present.


snoresnore


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 711](https://teamcity.labkey.org/viewLog.html?buildId=274126&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **SUCCESS**
Summary: Tests passed: 9, muted: 34 Build time: 00:25:31


@Dr-Bean Thanks for walking me through the process of recreating this patch. I wouldn't have figured it out otherwise.


yes, https://developers.google.com/protocol-buffers/docs/style


done!


This should probably be "Compute request headers representing token authorization.", or something similar.


> This should be `WeaklyIncrementable`...

> `WeaklyIncrementable`

I see you are getting onboard with the Weak Ranges idea ;)

Yes it should be `WeaklyIncrementable`, I didn't want to go to the trouble of typing up requires clauses for the operators. The views are extremely preliminary; they exist solely so that I could have some infinite ranges with which to test the `partition_point` family.


every RPC requires an argument.


thanks #lazyweb

On Thu, Sep 24, 2015 at 2:14 PM, Yifan Gu <notifications@github.com> wrote:

> yes, https://developers.google.com/protocol-buffers/docs/style
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/yifan-gu/rocket/commit/9a48e581ae65555df7eb8585eb56519ab00de0ef#commitcomment-13425540>
> .
>


q can be "&my_queue", i don't think it would work in this case.


One thing this doesn't do is consider the type of error. For example, one might throw a TypeError as opposed to an Error:
```
throw new TypeError("foo bar baz");
```
or
```
throw new Error('foo bar baz');
```
In this case the message is identical but the type of error isn't the same, but a TypeError is considered an instance of Error:
```
var e = new TypeError('foo bar baz');
e instanceof Error // is true
```
We may want to take into account the type of error as well as the message.


Yeah I suppose. The return value is actually added to metadata, but by gRPC, not by this method.


hjhkklnkl


The other macros in this file use next too, so I don't suppose there's gonna be a problem.

But I can suggest prefxing those with tmp__


Evan,

Are you sure that you have the right code? Clean build? I'll start investigating from this end to see if I can find the disconnect.
Jon

On September 24, 2015 3:58:07 PM CDT, evanosky <notifications@github.com> wrote:
>Where are the prompts in the test suite?  When i run it it says waiting
>for message...i assume i'm suppose to run gpsfake but when i do it goes
>on forever...didn't spend too much time here -- assume its a simple
>addition of a printf in the test function to tell user what to do?
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/punchcard60/kubos-core/commit/ae0016d440ce9e98a433b16a3ecf3fc5fe802174#commitcomment-13425215

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


Sure, I will add it and push it to a branch called skitext.


The issue here is that we need to differentiate between user exceptions and dnx exceptions. From the bootstrapper, it's hard to tell whether the InvalidOperationException came from here or somewhere in user code. Instead of creating a new subclass of exceptions, I feel it's better to simply display the error message and exit.


Just to refresh my memory what is the problem here? Is it that MLLib forcibly caches things when we use LBFGS + Logistic ?


What do you gain by putting this in a function? It's only called once right?


@infirit
Can you please explain why you revert this fix?
This fix comes from a fedora maintainer and fix a downstrean report.


Please also add a TypeError as well.


```python
from __future__ import absolute_import
```


@bjornblomqvist I was really thinking about it and I feelwe need the `dist/` in the repo to be able to link to the latest build for people - so got it out of `.gitignore`

But I also marked `dist/` files as binary - so on your local `git diff` they wont show up :)


I started to investigate the few reactions in the GramNegative template that had a mass imbalance. The first instance was that of an ATP hydrolysis that was missing water. A quick grep of the reactions spreadsheet told me that there was 37 reactions that:

1) were using ATP (cpd00002) and ADP (cpd00008)
2) were not using water (cpd00001)
3) and the mass imbalance was only for hydrogen and oxygen

Adding the appropriate amount of water to the correct side of the equation resulted in all of these reactions being mass-balanced, and only four of them still have a charge-imbalance (to be addressed later).

An extra bonus to this process meant that a few of the updated reactions were then linked to other reactions reinforcing the notion that the equation was updated correctly.


I applied a swapparoo with devise_dev and master is now back on track :):):):):)
git checkout devise_dev
git merge -s ours master
git checkout master
git merge devise_dev


Hrm, I have no argument for not doing this.
But, we may have to get into inspecting the constructor for this.  I'll find out.


What's the plan for future oci? are we going to convert it to appc? probably not I guess. But these fields should be generic enough. Maybe I just need to change the comments.


rax retry tests


Readability.  No?


I think so -- i pulled right from your branch and just checked your branch
on github to confirm files were similar.  We can debug tomorrow if you
want.  I'll plan to have my laptop

On Thu, Sep 24, 2015 at 4:18 PM, Jon Pattison <notifications@github.com>
wrote:

> Evan,
>
> Are you sure that you have the right code? Clean build? I'll start
> investigating from this end to see if I can find the disconnect.
> Jon
>
> On September 24, 2015 3:58:07 PM CDT, evanosky <notifications@github.com>
> wrote:
> >Where are the prompts in the test suite? When i run it it says waiting
> >for message...i assume i'm suppose to run gpsfake but when i do it goes
> >on forever...didn't spend too much time here -- assume its a simple
> >addition of a printf in the test function to tell user what to do?
> >
> >---
> >Reply to this email directly or view it on GitHub:
> >
> https://github.com/punchcard60/kubos-core/commit/ae0016d440ce9e98a433b16a3ecf3fc5fe802174#commitcomment-13425215
>
> --
> Sent from my Android device with K-9 Mail. Please excuse my brevity.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/punchcard60/kubos-core/commit/ae0016d440ce9e98a433b16a3ecf3fc5fe802174#commitcomment-13425614>
> .
>


Sure.


d'uh, i took QucsSettings for a class, which it is not. actually it seems to be `tQucsSettings` right now, violating the naming convention (does it?).

> you mean having a class that handles this

excacty. maybe just turn it into a class, but better remove it from `main.h`. how about `settings.h`?


if it works for you, go for it


Very hard to predict the final outcome. Even at LLR = -2.5, is not over (and conversely, when LLR +2.5, it can still drop very low...)
There was one worker with a +50 score after 500 games. Small exceptions can make a test look very good, or very bad... Numbers starts to be really reliable after 25M games. Also some tests oscillate a lot between LLR +/- 2, which is normal.
Even when a test pass, there is still a 5% chance that it is a regression.


Yeah, because it doesn't allow you to disable feature scaling, which in turn forces caching.


Done, look for `/Models/skis.png` in the `skitext` branch, and let me know if you need improvements/adjustments/etc.


hjhkklnkl


Still using a weird d here, no?


Requirements
------

MELShimmeringLabel  requires Xcode 6, targeting iOS 7.0


done


ack


LGTM :+1:


> There shouldn't be any noise introduced by files that are clear to not belong to proxy A.

Agreed, if it's clearly not correct (your example of incorrect shebang -- although it could be a typo) and not a small author mistake during development testing (missing shebang maybe, or a small typo in the shebang).

My remark was just that your paragraph seems to say "never print debug or anything from ::probe()", while IMO it would make sense to warn the user if something looks reasonably correct yet isn't completely.  But well, you could then argue whether in this case the proxy should try and assume ownership or not (I guess not in case it was really another proxy's plugin, but that they happen to be too similar).

Anyway, doesn't really matter, those are guidelines, and I expect actual authors to use their best judgment anyway (so it might indeed make sense to suggest them not to abuse here).


Great!


really?  I mean, keygen has generated keys... but keygen isn't finished yet.  Why not?  Because it hasn't answered a challenge, and it doesn't have a machine number.  I mean, in context (since the diff looks a bit weird to me), we end up with:

```
        /* Generate keys. */
        if (crypto_keys_generate(CRYPTO_KEYMASK_USER)) {
                warnp("Error generating keys");
                goto err1;
        }

        /*
         * We're not done, haven't answered a challenge, and don't have a
         * machine number.
         */
        if (keygen_network_challenge_machine(&C) != 0)
                goto err1;

        /* Exit with a code of 1 if we couldn't register. */
        if (C.machinenum == (uint64_t)(-1))
                goto err1;
```

As for the function name... well, that function:
- is only used for `keygen` (and keyregen)
- it takes care of the network challenge
- it also registers the machine number

I suppose I could call it `keygen_network_register()` instead?  I'll go ahead and prepare the next draft with that function name, but I still think the comment makes sense.


  In this file, I have implemented an internet proxy. It follows the simple
  flow of accepting a connection from a client and spawning a thread to
  take care of the particular client's request. The thread then parses
  it's request into the host name, the uri, path and the port. It then
  goes through the cache (implemented in file cachep.c), and if present in
  the cache, forwards the pages from the cache to the client. If the
  pages aren't present in the cache, the proxy reaches outs to the server
  which the sends the pages to the proxy, and the proxy forwards these
  pages to the client. The implementation allows concurrency and caching.
  I've used a simple LRU model for the cache, and used semaphores to
  synchronize use of shared objetcs.

   The read and write wrappers in csim.c have been eddited to account for
   ECCONRESET in errno for read and EPIPE errno for write.


Opps :)  Fair enough then


Awesome thanks!


Time command doesn't provide nanoseconds, and it seemed like over kill anyways.


MakXe?


Maybe something like:
```
Object.prototype.constructor(a).toString() === Object.prototype.constructor(b).toString()
```


I see - and we don't want both feature scaling and caching ? or we do want one of them ?

FWIW I don't think the reflection approach is good as if the private API changes we won't catch it at compile time. The code copying approach is slightly better and the estimators are meant to be used using teh builder model for use cases that are advanced.


Well since OCI currently does not define an image format the path we'll initially go is an importer:
https://github.com/coreos/rkt/issues/1355#issuecomment-136940945

which is kinda similar to what we do with docker2aci


Ignore this commit.  I accepted this file in a later commit. (Sept 24).


Ack.


So if we put these in application.css, we don't need them in the other places? If that's the case, looks good to me. I'll let someone else check and merge.


jkl


Cool stuff, thanks @Yomguithereal !


Feels strange to have duplicated values though.


Hi @waltermoreira , @eriksf and I were wondering, is there was any reason to not pass along the original request headers in a `passthrough` adapter?

As an example, if we created a passthrough adapter to ThaleMine using ADAMA, we would need to atleast pass along the `X-Jwt-Assertion-Araport-Org` header, in order to ensure that ThaleMine recognizes the user trying to make the request.

Thank you!


Ignore this commit.  I accepted this file in a later commit.


These should be specified in build.gradle, should not?


It's hard for me to tell for sure whether the symptoms I observe are general or specific since I manufacture the serial responses you know.  I should get a reprap printer so I can run some more mainstream firmware for testing.

I've got my plugin working more reliably now by setting the setting "unknownCommandsNeedAck" and always giving an ok back no matter what, so GPX is fine, but considering the symptoms I was seeing, I'm afraid there might be a bug lurking here for others.

So here's my repro steps which might work on another printer:
- Make sure unknownCommandsNeedAck is off
- Inside of a gcode source file (sending from the terminal window doesn't repro) put a command that doesn't have a gcode that the printer doesn't respond to (just reads without response), I was using a parenthetical comment like this (* this is a test *)
- play back that gcode source

result:
a timeout pause after that line is sent

My theory for what is happening is that even though the event counter is correct (didn't go down here or up later because no "ok"), the wait still waits because the previous wait already got the event.

I could be completely off track and there was something else going on with my repro case, but if this does repro on a reprap printer, I would think a fix would be to invert the sense and always clear, but conditionally set when !use_up_clear.

need_ok = self._unknownCommandsNeedAck
if is_gcode:
   self._process_command...yada
   need_ok = True

self._clear_to_send.clear()
if not need_ok:
    self._clear_to_send.set()

result for the counter should be the same as before, but when bouncing off 0 it should toggle the event so the wait returns immediately (for no ok needed case)


> The other macros in this file use next too, so I don't suppose there's gonna be a problem.

which ones?  can't seem to find any macros here that use it in any way?

> q can be "&my_queue", i don't think it would work in this case.

Good point, indeed.

So I'd suggest the longer but more unique `foreach_queue_` prefix (or doubling the `_` indeed), but anything would do.  `tmp__` it probably fair, too.


Vitya, sorry for bothering. Was it made by mistake or there is hidden purpose of double checking that login Pattern is present?


fdsafds


hjhkklnkl


В общем, код не содержит никаких комментов. Желательно их все таки писать. В нашем примере хорошо было бы описать сам модуль и его паблик методы.


What


Ah ok, I see your point. Guess I was a little bit confused and thought the currency is somehow bound to the locale it is from. But the [ICU rules](http://userguide.icu-project.org/formatparse/numbers) just covers how to format the number and where to put the currency sign, which can be anything. Touché ;)
I think a way for a custom currency sign would be handy.


@DAB0mB Ok, I see know. Since there can't be two html processors we remove everything that handles html in Meteor and are left to process everything manually. That what I didn't get at first, completely forgot about that.
Please remove 'path: file.getDirname() + '/head.html' since it's not needed and I'll merge in.


Согласись нелогично, что метод добавления тудушки называется addData(), а метод удаления removeEl(). Лучше уже называть их на один лад: addTodo(), removeTodo()


> Was there supposed to be a change to a .h file here?

I guess so, although both `gcc` and `clang` compile it perfectly happily without `keygen_network_register()` being in `keygen.h` file.  Maybe because both `.c` files are listed in `tarsnap_keygen_SOURCES` in the Makefile?


-rc.0 seems to be not needed.


extra line


I agree with @shivaram on this one. I think we can copy some code and
ignore the builder pattern in Keystone since we're just worried about Scala
for now and can have named arguments, etc.

On Thu, Sep 24, 2015 at 2:29 PM, Shivaram Venkataraman <
notifications@github.com> wrote:

> I see - and we don't want both feature scaling and caching ? or we do want
> one of them ?
>
> FWIW I don't think the reflection approach is good as if the private API
> changes we won't catch it at compile time. The code copying approach is
> slightly better and the estimators are meant to be used using teh builder
> model for use cases that are advanced.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tomerk/keystone/commit/8c4006a693276ac1e55aa102915b03a370ad473e#commitcomment-13425805>
> .
>


Please remove -rc.0


>
> which ones? can't seem to find any macros here that use it in any way?
>

Oh, i misremembered. But other fairly generic terms like items are in
use. I'll change to tmp__ prefix now.


I filed #96. I'll take care of it after this is merged.


Ok


You forget to push the svg file…


@tangphillip Well all the existing code in that file is correct regarding the associated object. My code calls removeDelegateForTask and then addDelegateForDownloadTask:progress:destination:completionHandler: so it should also be correct (my code is related to reconnecting to background downloads after app restart). So I'll withdraw my request.

+1


The way the context object works, it automatically scopes things for us.  So each http request gets its own request ID and that request ID goes away as we move back up the stack and leave the http handler. The context object pushes info like a stack, its doesn't replace values.


Are you sure? The watcher tests do some funky stuff with the shell that might be dicey on CRAN (e.g. solaris)


Won't this lead to internal members of anything visible from any test root?


Every query on a sharded model needs to filter by the shard ids we are expecting to reside in the given database. This is to prevent getting stale data when using the method of shard migration that we have discussed.


If you use Vim splits, I recommend this blog post: https://robots.thoughtbot.com/seamlessly-navigate-vim-and-tmux-splits


I don't think this is the logic we discussed earlier today.

If component with same name has been added and component is the same, return true
If component with same name has been added and component is different, return false.


Why is this needed here?


@vivekbarsagadey, thanks for the submission. A few questions:

1. How would we easily be able to see your changes from the original?
1. Does it work? If so, is there a way we could easily tell?

Thanks, and I look forward to seeing your response.


It's usually a little more convenient to do this via Apache config (if you're running Apache): http://httpd.apache.org/docs/2.2/mod/mod_env.html

Or, if you're running your preferred rails server out of RubyMine, there is a setting for that under Run > Edit Config > <your config> (something like Development: Exchange) > Environment Vars

Somebody is going to commit this file by accident at some point :smile:


Please change this if the PR is approved. :)


test


Invert this


The empty assignment could be done in the initializer


I know these are my words, but out of context they do not explain what this interface does. Please rephrase or don't put it here


Agree with @b4n, "consists" without the "is".


@Rocky640: Thank you for explanation. I think that 33% chance for
regression is OK. Of course, 5% is much better, but it seems that
we should combine 2-3 ideas that failed (but with positive score) to one
working patch. It seems reasonable to me. What is your opinion about that?

On Thu, Sep 24, 2015 at 11:22 PM, Rocky640 <notifications@github.com> wrote:

> Very hard to predict the final outcome. Even at LLR = -2.5, is not over
> (and conversely, when LLR +2.5, it can still drop very low...)
> There was one worker with a +50 score after 500 games. Small exceptions
> can make a test look very good, or very bad... Numbers starts to be really
> reliable after 25M games. Also some tests oscillate a lot between LLR +/-
> 2, which is normal.
> Even when a test pass, there is still a 5% chance that it is a regression.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Rocky640/Stockfish/commit/4d3bfab8a7aae5f26efc0a25791dcbe862c111b5#commitcomment-13425702>
> .
>

--
IQ World <http://www.ultimaiq.net/>


I don't think zfs-git should be kept, no.

We don't tag new ZoL releases that regular, but as ZFS is a filesystem
people should not be building from git head unless they know what
they're doing, i.e. are ZoL developers.

There are plans to have point releases when required, for bug fixes or
to support newer kernels, so running head should be discouraged.
Getting rid of zfs-git would help.

--
Regards,
Hajo Möller


Why only property setter by the way?..


fileCommands.js:1105: no error handling?


thx


for icon you can got it from this
https://www.google.com/design/spec/style/icons.html#icons-system-icons


> But other fairly generic terms like items are in use.

Can't see them either, all macros here only use their arguments and don't declare anything, but `setptr` which uses `setptr_tmp` (e.g. prefixed name).

Anyway, `tmp__` looks fine


also, this way if we really did need something more global then we could attach it to the context immediately, which I suspect is the more proper way to do things instead of trying to use a global variable/instance - like logrus.  I think this is why the distribution code does this too - e.g. they have logrus attached to their context and do logging on that instead of trying to use a global instance/variabelt - which I think makes more sense.


The string should be "insertTableHandle"


ditto


Yes, that’s just a typo, fixed by now. Thanks for checking!


Otherwise the error would say "invalid insertHandle must be of type ..." which is weird


:+1: good call


This specific patch is has been pulled, thank you!


![](http://i.imgur.com/pmTP1U0.jpg)
![](http://i.imgur.com/ARH6Kq1.jpg)
![](http://i.imgur.com/Nymq0li.jpg)


ha! good spot @gronke


unknown 'space', removed at next commit.


@rodrigopavezi I think these names could be shortened to `parentContainerClass` and `containerClass`, thanks.


Is there a public issue tracker for this? Maybe add a link to the reported issue? If it's a bug on their side, it would be nice to have a reference to it.


@rodrigopavezi Looks like this commented out line can be removed, thanks


In that case maybe skip should return `invisible(TRUE)` so you can do `skip_on_cran() && skip_on_windows()`.


Nope.  We're trying to report it to them via other channels, but they do not have a public issue tracker for things like this.


Well that's totally unrelated, but I think it would look (and read) nice


Agree with @kugel- there should be no noise.  One proxy does not know how close its plugins may be to another proxy.  For example there may be a python 2 and a python 3 proxy and it would be a bad thing (tm) if the python 2 proxy gave error messages for all python scripts that had python3 in the shebang.


Note that DEBUG_FLAGS are always used for compilation (not just when DEBUG=GDB), so every build will be a debug build.


Yes, for now.


another solution:
Perhaps this solution do you like better

<img src="<?php echo get_template_directory_uri(); ?>/images/spacer.png" >

I mark this as been fixed.


@mativs

1) Todo los que comience con dashboard, no estara incluido en Datal por ahora. No lo corrijas ni mejores. Directamente podes borrar las carpetas y toda referencia hacia ellas en urls.py

2) Validá con @danielpadula y @dbleyenda si los valores en los id son en realidad el id de la revision.


std::replace_if ?


yeah...I **DO** remember :P ... including some rocks being throw. Actually this is a prove that actually I do not forget stuff :P


Actually I don't see why this is necessary and I don't like this change.
If it is an artifact of a bug that needs to be fixed, then add a BIG comment there, to know to return and change it later.
Haven't we discussed in the K meeting that we will do that if we have top make changes that just circumvent limitations of the current implementation?

Grigore


awesome! thanks for updating @jasondavies :sparkles:


Are you sure we want to expose this endpoint to unauthorized users? They could query the server for e.g. OAuth provider secret.


Is the cloudinit change related to the unit test fix?  If not, please either add comments to the commit message or split the changes into two commits.


This is the KitBlinky fritzing. Not the Lesson 201 fritzing which uses a different GPIO. I don't think we have a KitBlinky fritzing in the repo alreeady.


Ok can you make this return `invisible(TRUE)` and then use `&&` style in the test? Then I'll merge


I'm not sure about that. I often use an Event class that is used for several events. For instance:

```php
class UserEvent extends Event
{
   const EVENT_CREATED = 'user.created';
   const EVENT_UPDATED = 'user.updated';
}
```

And use:

```php
$evm->trigger(UserEvent::EVENT_CREATED, $userEvent);
```

But your change no longer allow this because it relies on the fact that an event can only return a single name. And trigger does not support this neither because it expects $event to be a string.


@jonboulle ack, will do. in fact there's no way to say anything is required or optional. they are all optional...


@ luc  Regarde le [link]( http://stackoverflow.com/questions/24289418/how-to-suppress-warning-qpixmap-it-is-not-safe-to-use-pixmaps-outside-the-gui-) pour comprendre la motivation des changements.


Can you move this to the Blinky folder in a new "Fritzing" sub folder?


Although maybe it should be `skip_on_os(x)` with some helpers so you can do use windows, mac, linux etc


I'd change the order to $event, $callback, $target, $argv, as the most important is the event.


I'd change the order to $event, $callback


This can be 'cloud-samples-tests-bucket'


shouldn't this be 'stop' instead of start?


I didn’t want to do it via Apache. I can add the file to .gitignore...
> On Sep 24, 2015, at 5:42 PM, Stefan <notifications@github.com> wrote:
>
> It's usually a little more convenient to do this via Apache config (if you're running Apache): http://httpd.apache.org/docs/2.2/mod/mod_env.html <http://httpd.apache.org/docs/2.2/mod/mod_env.html>
> Or, if you're running your preferred rails server out of RubyMine, there is a setting for that under Run > Edit Config > (something like Development: Exchange) > Environment Vars
>
> Somebody is going to commit this file by accident at some point
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/CollectiveAccessProject/Exchange/commit/3a35ee9e979d5b4bc19a35ca53fa56a63d701c3a#commitcomment-13426071>.
>


Ah I forgot to change this back, it should be a placeholder like in bigquery. Will fix.


@luc la discretization on la fais directement sur SetOfIntervals


A `PresenceChannel` is a `PrivateChannel`, and both are `Channel`s. Should we consider the inheritance hierarchy in the `get` or only return a direct type as the code does now?


As we discussed we need synchronization between garbage cleanup and write for sure.


@luc ca on peut reajuter


Just add a new look to the EventManagerInterface, here some feedbacks:

* Should we keep the `getEvents`? The naming is confusing. `getEvents` I'd expect to receive instance of events but instead it returns event NAMES. I'm not sure if it's really useful (never used it personally), so we should eitehr rename it or remove it from the interface ? (which become to start pretty massive)


Type should be `Channel`.


* Can't you use `pass` instead?
* correct me if i'm wrong, you don't send Control-C to `aws` command ?


Can you update the README to have the install step to install requirements.txt to lib?


yeah, I'll clean it in the end. This was a question to KT more than anything else.


R Programmin - Assignment2


practica joac


Practica 0


Jaja, nicht testen, aber behaupten, dass es geht :P gerade noch mal Glück gehabt :D


Why do this only to undo it later?
Are they causing undesired behaviour?


Something more extensible is clearly called for here. I don't yet know what that is. I don't know if we'll design that in at this time or iterate towards that as we go. TBD. KT, any comment?


Is this to be the final UI?
If not, I don't see why we should add a temporary UI instead of referencing RA where possible.


@mativs En el embed por el momento quedará asi. Posteriormente sera cambiado al modelo async que usan la fichas de visualizaciones.


remove unknown 'space' from the commit. sorry.


wow, that's a bit nasty.


If you have the updated local_settings, you can keep this in. Instead of sending texts, it will print to the log. Also, I recommend putting a real number or two in you db as well as the numbers in the below link (be sure to add them to activeSubscription too). That way you can see how the program behaves when sending to good/bad numbers.

https://www.twilio.com/docs/api/rest/test-credentials#test-sms-messages-parameters-To


The lint check errors if anything uses an upgrade type that is not yet provided/granted anywhere.


The comment is *true*, but it's not *meaningful* in that it doesn't explain the following code.


The `get` is symmetrical with the `subscribe` functions, so I think it wins through consistency

Maybe casting is bad, but at least the API isn't asking the user to do it, and the implementation seems to play it safe.

I'm happy with this as a solution if we fix the `getChannel` return type and add a bunch of tests for the new methods.


nope, because `fclose()` should be called even if `fgets()` failed :)


thanks


can we add "workflow" to the exception list? We use it a lot in the company messaging and the norm seems to be one word.


Looks good, this is according to spec, allowing 1-1 or n-1 or 1-n but blocking n-n transfers


Ah yes, you are right


Do you have a description of the items? The binding is already build and I am trying to get the serial connection to my wr3223 running.


great


@mklucsarits: Good call! How do you like it now? :smirk_cat:


>Can't you use pass instead?

The `print` is actually to workaround some oddities in the library prompt-toolkit which didn't handle the traceback output gracefully.  Adding a `print` fixes the issue on Mac/Unix/Linux.  I should have added a comment to explain this.

Unfortunately, after further testing the Windows command prompt is really not liking this at all, `print` or `pass`.  I'll file a bug report with `prompt-toolkit` see if I can get some help.

>Correct me if i'm wrong, you don't send Control-C to aws command ?

I might have misunderstood your question, but under the hood the official `awscli` is actually handling the command, so I believe the answer is yes, Control-C is sent/handled by the `awscli`.


Good Job


:+1:
Thanks! I'm kinda new to python. Thanks for explaining :)


Because PropertySetter doesn't contain information about source. I remember some comments in code about it. I'll try to find it.


Yes, can I do it in the next PR?

On Thu, Sep 24, 2015 at 2:59 PM Jerjou <notifications@github.com> wrote:

> Can you update the README to have the install step to install
> requirements.txt to lib?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GoogleCloudPlatform/python-docs-samples/commit/b452ef86dabc15bc8028ac0d5be1da94474b1802#commitcomment-13426407>
> .
>


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21184/testReport/) for this commit**


Was just about to add some tests to your commit, but I think there's a refactoring we should discuss first. The `getContent()` method in all these editors is identical. How about we move it to the common base class `RuntimePluginBaseEditor`? In order to make that work we also need to move the `view()` method to this base class:

```java
public abstract class RuntimePluginBaseEditor extends BaseEditor {

    ... skipped ...

    public PluginSimpleContent getContent() {
        return new PluginSimpleContent( view().getContent(), view().getTemplate(), view().getCss(),      view().getCodeMap(), view().getFramework(),  view().getContent().getLanguage() );
    }

    protected RuntimePluginBaseView view() {
        return (RuntimePluginBaseView) baseView;
    }
}
```

The final step is to add `getFramework` and `setFramework` to the `RuntimePluginBaseView` or a new interface that it will implement.

This will get rid of quite some code duplication. What do you think?


I'm guessing it's a typo.


Is there a naming convention followed on the docs? Should this be "container_name" or is "container name" acceptable?


For efficiency, we probably could skip this first call to the parameter service and rewrite the second if as:

// don't need to continue if parameter evaluates to true (many to many accounting lines are allowed) - or is empty
        if (getParameterService().getParameterValueAsBoolean(componentClass, parameterName, Boolean.true))) {
    	    return true;
        }


Have you run this code through jsHint yet?


Note from Qt Docs: Do not delete the object in the slot connected to the error() or finished() signal. Use deleteLater().


Looks like you miss-spelled "canola" oil.


@josevalim if you give me the :+1: I'll release 0.6.0 right away :)


Back ticks denote table and column names, is there a specific reason these should be removed?


I am not totally sure that this is relevant, but `KPropertyImpl.kt` contains the following code and comment at line 75
```
        override val descriptor: PropertySetterDescriptor by ReflectProperties.lazySoft {
            // TODO: default setter created this way won't have any source information
            property.descriptor.setter ?: DescriptorFactory.createDefaultSetter(property.descriptor, Annotations.EMPTY)
```


@vjeux I just cut 0.12-stable branch and this commit just missed it. Looks like it should be cherry-picked to the release branch?


First commit in a while, brought repo up to date with all changes I've made recently to the javascript and html. Some of those changes include jquery event handlers for price input, debugging/testing of the jquery, and the creation of the pinkie-review.html page.


broken old api


We return -1 on failure.


FYI, `@YES` and `@NO` would also work here.


does not need to be a public symbol does it?  lower-case the "probe"


[bcrypt-then](https://github.com/thenables/bcrypt-then) wraps bcrypt in promises, would make this much more beautiful. :smile_cat:


    /* Register the keys with the server. */

perhaps?


this commit LGTM - just one nit on caps


This belongs in main, even if it is duplicated code.


Pull closes No. 1064


バステメッセージの追加 #110


You should definitely fix this indentation. In Ruby community - 2 spaces are almost like a religion to follow :).


Lots of trailing whitespace.


I would be consistent and use `= image_tag ...`


Ich hab mir halt den Code angeschaut O:-) Wir könnten auch mal überlegen, ob man die unittests an einen push oder merge binden kann/will


r+


ma`D:<`ilto:open`D:<`sprites@`D:<`opensprit`D:<`es`D:<`.`D:<``D:<`or`:(`g

Lolol. Not a bad idea though.


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/7e7499e19d6e9489447b045b64ed66ff4ad671c2


merging MonsieurNicolas/stellar-core/trustLine0fix = 7e7499e1 into auto


MonsieurNicolas/stellar-core/trustLine0fix = 7e7499e1 merged ok, testing candidate = 735e1491


Indentation is random here. Please fix.


I get that; this is slightly different.

On Thu, Sep 24, 2015 at 5:03 PM, Benjamin Scott Corwin <
notifications@github.com> wrote:

> If you have the updated local_settings, you can keep this in. Instead of
> sending texts, it will print to the log. Also, I recommend putting a real
> number or two in you db as well as the numbers in the below link (be sure
> to add them to activeSubscription too). That way you can see how the
> program behaves when sending to good/bad numbers.
>
>
> https://www.twilio.com/docs/api/rest/test-credentials#test-sms-messages-parameters-To
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cutreth/MsgSender/commit/b4460a148dcd1cfa0d26516362e002094007977a#commitcomment-13426475>
> .
>


@udalov
For now I am not sure what to write here, so I deleted these texts.


I would recommend to use `create!` in `seeds.rb`. It will notify you on wrong Video if there is a validation error while non-bang version won't.


Wrong indentation.


Already did :-)

> On Sep 24, 2015, at 5:57 PM, CollectiveAccess <notifications@github.com> wrote:
>
> I didn’t want to do it via Apache. I can add the file to .gitignore...
> > On Sep 24, 2015, at 5:42 PM, Stefan <notifications@github.com> wrote:
> >
> > It's usually a little more convenient to do this via Apache config (if you're running Apache): http://httpd.apache.org/docs/2.2/mod/mod_env.html <http://httpd.apache.org/docs/2.2/mod/mod_env.html>
> > Or, if you're running your preferred rails server out of RubyMine, there is a setting for that under Run > Edit Config > (something like Development: Exchange) > Environment Vars
> >
> > Somebody is going to commit this file by accident at some point
> >
> > —
> > Reply to this email directly or view it on GitHub <https://github.com/CollectiveAccessProject/Exchange/commit/3a35ee9e979d5b4bc19a35ca53fa56a63d701c3a#commitcomment-13426071>.
> >
>
> —
> Reply to this email directly or view it on GitHub.
>


Lots of training whitespace and wrong indentation.


Basically #194 is done with this, however before I close this issue, I first need to perform a full test of this, and since I had a busy day today, this test will have to wait till tomorrow or maybe even till the weekend.


There is no need for `@videos` now. You can access them from `@categories` when you iterate over the collection and using associations.


Thanks, I'll check shippable tomorrow if it passes with that.


Please discuss at

https://github.com/Arabidopsis-Information-Portal/adama/issues/88


Thank you :-)
> On Sep 24, 2015, at 6:26 PM, Stefan <notifications@github.com> wrote:
>
> Already did :-)
>
> > On Sep 24, 2015, at 5:57 PM, CollectiveAccess <notifications@github.com> wrote:
> >
> > I didn’t want to do it via Apache. I can add the file to .gitignore...
> > > On Sep 24, 2015, at 5:42 PM, Stefan <notifications@github.com> wrote:
> > >
> > > It's usually a little more convenient to do this via Apache config (if you're running Apache): http://httpd.apache.org/docs/2.2/mod/mod_env.html <http://httpd.apache.org/docs/2.2/mod/mod_env.html>
> > > Or, if you're running your preferred rails server out of RubyMine, there is a setting for that under Run > Edit Config > (something like Development: Exchange) > Environment Vars
> > >
> > > Somebody is going to commit this file by accident at some point
> > >
> > > —
> > > Reply to this email directly or view it on GitHub <https://github.com/CollectiveAccessProject/Exchange/commit/3a35ee9e979d5b4bc19a35ca53fa56a63d701c3a#commitcomment-13426071>.
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/CollectiveAccessProject/Exchange/commit/3a35ee9e979d5b4bc19a35ca53fa56a63d701c3a#commitcomment-13426825>.
>


Should even be able to modify `m_getRect()` to just take in `near`.


<!-- PMABOT:TAB -->
This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/tbl_columns_definition_form.inc.php


err... ok, but why?  I mean, is it because I forgot to add `network_fini()` to `err1`?  logically, I would suggest that since all other network-related stuff happened inside `keygen_network.c`, `network_fini()` should be there too.


I've added a comment about this above the code.


@thekaveman don't know if you know about this trick. While experimenting with splitting up JS files in an attempt to better organize things, I found that I can abuse [`include_relative`](http://jekyllrb.com/docs/templates/#including-files-relative-to-another-file) and front-matter to have Jekyll concat partial JS files together. Probably room for improvement and cleaner code to avoid multiple `$(document).ready()` calls but it works.


Moved this to common.h.


Ack.


Look like it propagated just now. Maven Central is slow :)
http://search.maven.org/#search%7Cgav%7C1%7Cg%3A%22com.facebook.react%22%20AND%20a%3A%22react-native%22


This comparison doesn't make sense. The comparison you probably want is:

```c++
if (display_schema_1::DisplayDescriptor::FULL_SCREEN == desc.activeResolution().display_mode)
```


Still have to wait for 0.12.0 to appear here:
https://bintray.com/bintray/jcenter/com.facebook.react%3Areact-native/view


How do I incorporate these code changes in a custom rom? I'm on Exodus android.


I noticed you left out 'extra_connections' option from the latest version. Was that feature replaced with some other setting? Thanks in advance!


Correct indentations.


(Don't even use getNumDisplayInputs - can even remove that from the code - it's just a way for the file to contradict itself)


Added a comment.


@Urigo do we really need to return that action as well? Lets return only id as it was before, it'd keep it simple. What do you think?


Don't think we need this console log :)


Nit: Since Primitives/Sockets include most of these we could probably simplify this project.json a lot (maybe down to a couple of lines) - see the Security json file.


Guarded it with #ifdef WIN32


LGTM


Why was this deleted? Needs to be reinstated ASAP. Without this, codegen does not know what line it is on, blocking our trick to prevent LLVM from commoning error sites. Just cost me a lot of debugging time. This regression is on release-0.4 as well.


Ok


Forgot to mention this to you, in commits https://github.com/CityofSantaMonica/hackthebeach/commit/437edf15645a6abdba25f8eb2528a4c7eea1662d and https://github.com/CityofSantaMonica/hackthebeach/commit/7cdeb7bc4bead413f776aa09072aca463e6c18a3, I changed it so the jumbotron had equal padding all around because if a jumbotron didn't have buttons, then there was no padding at the bottom. Instead of adding new classes or modifying BS' classes, I changed the buttons to a `<div>` so they don't have a margin-bottom.

**with `<p>`**

![before](https://cloud.githubusercontent.com/assets/1246453/10088834/9a96984c-62d2-11e5-8c7f-c0a3847fd242.PNG)

**with `<div>`**

![after](https://cloud.githubusercontent.com/assets/1246453/10088841/a86d2f94-62d2-11e5-8ff3-935b31bb3300.PNG)

Don't know if you'd prefer a different approach.


Nit: add a comment to describe 169/649.


I'm not sure why, but this code didn't get rendered properly in the build:

 ```liquid
  {% raw %}
  {% if jekyll.environment == "production" %}
     {% include disqus.html %}
     {% include disqus.html %}
  {% endif %}
  {% endraw %}
 ```

Also, I accidentally used sentence case style in the "Specifying a Jekyll environment at build time" instead of title case (like the other sections).


(multiple locations)


added google analytics


@bloodmc #175


Slightly simpler as just:

```rust
try!(dev_file.read_to_string(&mut s));
Ok(s)
```


Is this a TODO or aren't we supporting 32bit *NIX?


lgtm


What do you think about something like that?
'''
valid_addresses =
  %w[user@example.com USER@foo.COM A_US-ER@foo.bar.org first.last@foo.jp alice+bob@baz.cn]
'''


fix #5


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/82058848


Same as above? TODO or aren't we supporting 32bit?


I don't see how negative timeout fails the execution.
sleep 1 still has exit code 0.  Is this leftover from when there was activeTimeoutSeconds?


Could you make a release with that commit?


I wonder why it's not the problem for property *getters*. In that file the you can see the same happens with property getters at line 53. Would you mind to try invent a test with a property getter which would fail? It might blow up unexpectedly later otherwise


What `completing-read-function` would we bind to? Like mentioned, I only know about the one in `ido-ubiquitous` (in `ido-completing-read+`, actually).

> One is that I don't actually like ido in many situations; it's visually overbearing and harder to use when it doesn't stand a good chance of having the eventual result in the first few matches.

Maybe that's a motivation to use a package that allows to specify the exact commands to use Ido for. You could write your own, but `ido-ubiquitous` has `ido-ubiquitous-command-overrides`. I imagine ending that list with `(disable prefix "")` would disable it in all but the specified commands (though I haven't tried that).

I also recommend `icomplete-mode`, as a less overbearing option.


Ok, please remember to log it to the tracker.


`get_value_from_file` does not appear to be used anywhere else in this commit and should probably be removed with this same commit.


Looks good.
:+1:


If you want to email a `git-patch` to the email on my github I'll be happy to apply it directly without a pull.


You may also want to remove `Makefile`


Nit: there was a discussion and decision on replacing all `TRAVE` to `TRACE_VERBOSE` and keep this as a corefx-global knob to enable debug, high verbosity tracing.
See #3163.


Some things went wrong in the current executable builds on Mac. This update fixes that. The Windows version should not have had any trouble, but to make sure this was the case, I recompiled the Windows version as well.


For 1 second at 11:59:59pm, this test will probably fail. While this is only 1 out of 86400, should we maybe consider DateTime.now().plusDays(MAX_EXPIRES_ON_DAYS+1)? It's roughly as loose as the test we have now, and almost certainly won't fail.

The other alternatives are plusDays(MAX_EXPIRES_DAYS).plusMinutes(10) (because this test won't take 10 minutes), or DateTileUtils.setCurrentTime().


Is it worth adding a test for a ScheduleContext that passes the validator?


Bij deze commit moet je https://docs.google.com/uc?id=0B0TFe3UuzMKmYmh3Mkt5VVkwTU0&export=download downloaden en opnieuw in de resources doen icm github restrictions


Because this is called no matter what, it could be moved outside of the if statement removing the necessity of the else clause. Thus looking something like this (pseudo code):
```python
end()
if (...):
    start()
```


Hmm, if the command defines it's own `-a` I think the help text there should take precedence. For example, in `heroku addons`, I'd want to spell `-a` more specifically with text "app to show add-ons for" or something.


I'll try to do it.


SDDS functional tests com selenium :( welcome protractor!


NIT: the comment variable name was not updated to _iocpBoundHandle.


This is the definition of that struct:
```
_STRUCT_ARM_THREAD_STATE64
{
	__uint64_t    __x[29];	/* General purpose registers x0-x28 */
	__uint64_t    __fp;		/* Frame pointer x29 */
	__uint64_t    __lr;		/* Link register x30 */
	__uint64_t    __sp;		/* Stack pointer x31 */
	__uint64_t    __pc;		/* Program counter */
	__uint32_t    __cpsr;	/* Current program status register */
	__uint32_t    __pad;    /* Same size for 32-bit or 64-bit clients */
};
```

__x has 29 registers.
I decided to avoid unspecified behavior of doing __x[29] to mean __fp.


Thanks! @parkr -- this-- in reference to my emails this afternoon.


Is this needed? It seems it is always the last element in the list.


Test


Sorry, Max. :(


Feel free to PR your proposed changes.


Alternatively you could reverse the string with `StringBuilder#reverse` http://docs.oracle.com/javase/7/docs/api/java/lang/StringBuilder.html#reverse() and just compare for equality with the original one.


Thanks man :clap:
I understand. I forked this project and replaced the cryptography with hash for the cases where us can't use cryptography fields.
https://github.com/dannluciano/hashed_attr/


why would it define its own `-a` and set `needsApp: true`?


I was just wondering why my :sync wasn't running! That'll explain it.


These helper methods should probably be private.


Nit: replace all `PROJECTN` to `NetNative`


I don't think there's anything that could raise an exception in the function so this is probably a little overkill.


Note that the `Integer#toBinaryString` method does this already (http://docs.oracle.com/javase/7/docs/api/java/lang/Integer.html#toBinaryString(int)), but your implementation is good too!


@Pavel2451 what does it mean? Is the fix not working?


I'd prefer allowing override from the command line.


I'm sorry, Max. :(  :(  :(  :(


The code is mostly fine, but this indentation makes it quite hard to read...