But there could be other reasons than scheduler shutdown, such as invalid cron expression? We should definitely always try to remove triggers that have already been created, and log and ignore the fact that the remove failed.


Fair enough. How about pointing users to our troubleshooting guide so the document can stay up-to-date?

https://github.com/kubernetes/kubernetes/blob/master/docs/user-guide/application-troubleshooting.md


Yup fixing. Dunno what happened with the GenEventImpl


Should this test use shape instead of the legacy accessors for clarity? It could be confusing since the channel dimension is 3rd here unlike the order of legacy dimensions.


哦？我再去试试看。


Don't know why that happened...I'm a git noob


确实如此，看来是我孤陋寡闻了。请帮忙改下吧。


In ace-jump-mode, it adds such padding (line 523 - line 525).


Yes. This patch is around making sure that we shade and have a basic unit test working. We can open a separate JIRA if you want to create a comprehensive suite for testing every JDBC type or similar.


will do


FourPipeBeamAirTerminal (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1825 of 1826 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


sure


@yujuhong Good suggestion! Updated, thank you :)


That's since go 1.4, but also has some annoyances, especially when you `go get` a package that has this in it.


Doh. Nice catch!


On Thu, 3 Sep 2015, Loic Dachary wrote:
> for what reason should we prefer blkid over sgdisk -i ?

blkid is designed for exactly this purpose; sgdisk is a big hammer.
Also, sgdisk generates a ton of udev noise each time it is run while
blkid generates none.


Thank you very much!


http://review.teameos.org/#/c/770/  or  https://github.com/BenzoRom/external_sepolicy/commit/8d6bcc9d6d762abf7d7b3ebf0cd6b2efb7e692eb

Works for me, the Benzo one, but TeamEOS says theirs work too.


^~^good


For future reference, these examples/tests were removed because [they will no longer be supported by ggplot2](https://github.com/hadley/ggplot2/blob/816d789a73e3bd594e8243151e4938b990aed9c8/NEWS#L195-L197)


I think a concrete example will help to show what's needed here:

In Plum, we need to look up metadata from an external source before saving
the scanned_book but *after* applying the submitted attributes because one
of the attributes is the metadata ID that we use to retrieve the metadata.
So

In actor.create all we need to do is:

curation_concern.attributes = attributes
curation_concern.apply_external_metadata
curation_concern.save

In actor.update, we only want to call
curation_concern.apply_external_metadata if it's been requested.

Either way, currently there's not a clear path for triggering
curation_concern.apply_external_metadata after applying the submitted
attributes but before saving the curation_concern.

In this case, it is really tempting to have an after_apply_attributes or a
before_save callback.

Or I could override apply_save_data_to_curation_concern from
CurationConcerns::BaseActor and make it call  apply_external_metadata.

Either way, the [way it's currently done](
https://github.com/projecthydra-labs/curation_concerns/blob/master/curation_concerns-models/app/actors/curation_concerns/work_actor_behavior.rb#L7-L10)
is a bit cockamamie.

On Thu, Sep 3, 2015 at 5:27 PM, Justin Coyne <notifications@github.com>
wrote:

> Can you override interpret_visibility (or whatever), do custom stuff and
> then call super? If we have to override too much then I think we need to
> refactor the actor methods into smaller chunks
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/projecthydra-labs/curation_concerns/commit/0de7ddbf6f96e5df20f9a48571771da9b3cf022b#commitcomment-13060339>
> .
>


Yeah that's why I was committing generated files. `go get` is awful in cases like this. Nice work so far, by the way!


Interesting. The red/green indicator seems to be a roll-up of the amount of additions/deletions.


The code i pull is "short press" Swype button to change IME but not long press
I'm using this code in my nexus 5 (4.4.2) and i have tested it in emulator "Genymotion (4.4.4) + arm translation" and it work fine. Sorry that i haven't test in other device and other android version.


Thanks @mydongistiny!


I just read the thread on Doomworld, so thumbs up for this one.


Podrias explicar exactamente que es lo que hay que hacer con WART y que hay que poner en el WhatsBot.json?

Me da un error al ejecutarlo y no se si es porque estoy haciendo algo mal.

Este es el error:


too long


hehe


Hi ! Your project is very interresting  , for music please choose somethings like this :
you just have to write credits as it is do on the video  https://www.youtube.com/watch?v=9__sJWMXjE0


Yeah, which is probably not good either... :/  I'll add a FIXME to clean this up at some point, if that's ok for you.  The virtenv reset can also happen in pre_exec...


:ok:


C'est bon @yaf . Je pense avoir compris d'où vient le souci. Je pushe en conséquence dans la journée.


It should be
`cmdExec.Flags().StringVarP{(&flags.Cmd, "cmd", "c", "", "command to execute")`
or `c` will become the default value.


Wyrzuciłem parę ringów ze sceny.


The advantage of doing it centrally like in POPEN, is that it only has to be done once.
Although moving it to the CU is probably a performance "hit" that I'm willing to make.
So adding a note to resolve that is fine.
There are probably some issues open on setting the CU env anyway.


Wyłączyłem poprzednie standardowe menu


At worst, CircleCI will time-out after 10 minutes.

I had previously experimented with `timeout` and failed, but it seems a technique has been found, e.g. https://github.com/weaveworks/weave/blob/f8327c3c6c7928cdc4b4678bd7c4bf0a4fc04b75/test/120_discovery_3_test.sh#L37


agree!


AccountOverview only shows 10 transactions and I don't think it should show any more really, which is why AccountHistory was there to allow access to older transactions..


thanks!


Added req libs


sytle of comma inconsistent xD


Why depend on the Lua cli?


I ought to add a "Integration test" window to validate some of those implementation details.
Thanks for working on this!


Basic reformatting
Changed champ detection
Added lib require


I get the following error in the version command:

``Tool Version:	R version 3.2.0 (2015-04-16) -- "Full of Ingredients", DESeq2 version ARGUMENT '~+~~+~~+~~+~~+~~+~~+~~+~cat(sessionInfo()$otherPkgs$DESeq2$Version)' ``

I think you can fix it by removing the double ampersand (cat is here an R function and not a bash function).


Version Modified


Это изменение неправильно работает для `style[key1]===0` (например, opacity). Я его верну назад. Напомните, зачем это понадобилось? Может быть, реализовать deep clone как-нибудь поаккуратнее?


The `main()` function should also take these parameters: `int argc`, `char* argv[]`.


We already have this in commonSettings or does it not work?


Not needed yet.


Part of the comment starting with "110" doesn't make sense here anymore.


islo mi to.. pokial viem tak to je obsolete od el6


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8134/testReport/) for this commit**


Can we get news from the APIv2 yet? If so, I will change it to a native view.


APCU is ported now: https://github.com/krakjoe/apcu/tree/seven


Last try I have problem making the settings it stick.....haven't try this though.


A bit picky :)


I'll abandon this settings.....


Waiting for yours...:)


Can we change this to be `org.elasticsearch.maven` or something so we don't mix elasticsearch actual stuff and maven stuff?

May be at some point we will produce also maven plugins for elasticsearch (who knows?). :p


Hace más o menos una semana, whatsapp bloqueó todos mis números (los de
argentina parecían no tener problemas), pero bueno, no he probado con otros
números.

Si ya has configurado el número, password y nick en WhatsBot.json, edita
WhatsBot.php y setea $Debug a true. Si en la consola aparece algo tipo
<failure><non-authorized></failure>, el número está bloqueado ;-;
El 04/09/2015 07:00, "Albermonte" <notifications@github.com> escribió:

> Podrias explicar exactamente que es lo que hay que hacer con WART y que
> hay que poner en el WhatsBot.json?
>
> Me da un error al ejecutarlo y no se si es porque estoy haciendo algo mal.
>
> Este es el error:
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fermino/WhatsBot/commit/5f2e6dcbab94878f84cf4d88db312d85f79b5a7c#commitcomment-13065883>
> .
>


I'd be more explicit here to what this plugin is providing.


Done, though I don't see it as a goal to keep try blocks as small as possible - they shouldn't be too broad, I agree, however there's no reason for try blocks not to contain relevant code that would not cause the exception being caught in the except block to be thrown.


Ouh, just don't forget to change the ret->data allocation to zalloc if removing this.


Why a so old version? Does maven "force" to publish plugins compatibles with 2.x?


Isn't this more like "handleCustomScalaRejection"? Since the trait for extending by users is Rejection, so it's the scaladsl's "custom".


Me too, old hash.


Applying this revert in 15.09 too.


You probably want to do Math.abs(dblVal - 1.0e-131) <= EPSILON where epsilon is somewhere near 1e-9 or so, otherwise the precision of double conversion between the JVM and oracle might land you in teh exact same situation.

I would also place both the oracle epsilon and the comparison epsilon in a named a static final.


hey kantanand please update my name in developer list of pool


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20082/testReport/) for this commit**


No problem. I agree that git (as well as probably any version control system) is sometimes very hard on the user. Good that we can at least see the changes. I'll fix this if/when merging will start.


I don't think it's needed. By default, we have:

```xml
<includes>
 <include>**/Test*.java</include>
 <include>**/*Test.java</include>
 <include>**/*TestCase.java</include>
</includes>
```

Which includes `**/*Tests.java`.


OK, I'll be back at PC in a couple minutes and will get it changed up and push :-)


I've tended to prefer writing `if !self.items[i].borrow().is_none() { continue; }` to avoid endlessly indenting code.


In the end I realized this was the version where `scientific` was introduced.

In theory, we could add this constraint only if `aeson >= 0.7.0.0`.  I don't even know if it's possible in cabal, and I don't think it's worth it anyway.


Can you just say `if item.as_mut() .... { changed = true; }`?


Damn u are fast


Requires an update of the deprecated message above.


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1821 of 1822 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


What version of MySQL are you using?

Cause I would recommend this:

```
`createdDate` DATETIME DEFAULT CURRENT_TIMESTAMP,
`lastUpdated` DATETIME ON UPDATE CURRENT_TIMESTAMP
```


This is for backwads compability. Otherwise, CURRENT_TIMESTAMP works fine.


i don't understand?


А, я совсем забыл, что куки отправляются в заголовках запроса. Ну теперь всё понятно. Нас исследуют.


This whole thing is ugly. Three configurable parameters to convert ADC reading to voltage?!
16bit number in 8.8 fixed point will be much  cleaner ...


:ok:


My bad, for some reason vim decided it was a linux file. Allready fixed.


Done, thanks!


utils.getFile(stagePath, 'elements', 'fxsync.html')

IMHO, the parameter style for path is for cross-platform (Windows uses '\' delimiter for path, but UNIX-like uses '/' )
How about this way:
```javascript
var fileList = {
   process: [
      ['index.html'],
      ['elements', 'root.html']
   ],
   remove: [
      ['js','fxsync.js'],
      ['elements', 'fxsync.html']
  ]
}
```
`getFile` will be delegated in preprocessor as well.


This code did round resulting value before change..


@Admicos I see, since that `CURRENT_TIMESTAMP` is only supported on MySQL v. 5.6.5+.

Also I would also call them `created_date` and `last_updated` instead of using camel case.
Only because you do this the other places, stick to one type of case.


@nik9000 Pointed me to an interesting document where oss-parent pom is actually deprecated.

http://central.sonatype.org/pages/apache-maven.html

Which makes me think that it's ok to start with that for now so we can have that plugin delivered soonish but I think that at some point we should update the elasticsearch parent project (and simplify it a lot or create a new one only for repository distribution purpose) which defines exactly what are our repositories, plugins, whatever...


Hi Juhasch,
I am experiencing problems with this extension. It happens that it pastes multiple copies of the clipboard at the same time. It also happens that it pastes the clipboard content into a cell instead of pasting a new cell below. I can send you a notebook file if you need it.


just experimenting :) trying to to fix TC build with @onibox


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yeah, i'm very inconsistent right now. But after templating everything i'm going to do the other stuff.


Typo here: Once the module has been enabled the feature a new content type called


Isn't that `dev/bundle.js`?


@avermeulen What do you think of these?


Typo: in order to create submission form on
Fix: Either create a submission or create forms


The old URL is the one in their documentation, they didn't even bother to announce this change or update documentation. Amazing :no_good:

I've noticed the https equivalent works too https://www.paysera.com/download/public.key, I think it's worth updating to use it.


For consistency with the previous section, you could say `prod/bundle.min.js`.


эм... может всё-таки вместо нулей будете собирать какую-нибудь переменную? :laughing:


My comment


Alright, I made comments but I can see everything was fixed here.


Line note Ben


True, it can be beneficial to scope variables to a try block, just not in this case. The Python style guide says "minimize the amount of code in a try/except block", since there's always a slim chance that "code that would not cause the exception being caught in the except block" will unexpectedly raise just such an exception at some time in the future. Arguably, it might be good to catch that under the same umbrella, or it might hide a bug.


Note that the underflow validation is made by the oracle JDBC driver, not on the DB server.  if you put the value in the SQL an insert statement (i.e., not in a bind variable) the DB server accepts and stores 0.


Под колпаком стало в 10 раз больше людей, теперь 10%


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8135/testReport/) for this commit**


Must have slipped in when copy/pasting the makefile.


My comments above (and the ability to revert this) are moot now that module support is actually in place. Might still make sense to change back to non-raw pointers (for safety), but it would have to be done in a different way. I see no urgency in this though, as long as we don't start to get reports of segfaults.


Create a new notebook, with the single cell:
> %%javascript
> require(['base/js/utils'],
> function(utils) {
>    utils.load_extensions('usability/chrome-clipboard/main');
>});
Execute it, then select it, then hit Ctrl-C twice. The second will insert the cell twice, thus resulting in four copies of the cell in total, instead of three.
I don't know yet how to reproduce the other bug when it inserts the cell inside an other one, but that happened many times too.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20083/testReport/) for this commit**


Still an svg :P


yes, of course... but without configuring backports.lzma the building fails...
it was the first time that I tried to compile the BlissPop, and through the fault of the error due to backports.lzma it took me two days to understand how to fix it...
I found a commit on official BlissPop github, where someone had added those lines commented on file BoardConfig.mk of another device, and then I was able to successfully compile the ROM without error..
I added those lines because, if someone else wants to compile the ROM, can easily find the fix to the problem ;)


Add Email input field the Subscribe Form content type
should be
Add Email input field to the Subscribe Form content type


Choose to just comment this part so that I make minimum changes to that library, this is enough for our app to still run while avoiding this crash with 3rd party keyboards


You are right. I should have checked that myself :/. Already submitted a commit with this change.


I'd add a default case that sets the fail bit on the ostream.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20084/testReport/) for this commit**


This is introducing a new use of `Preconditions` from Guava which is on the way out. (We can remove existing uses later, but we shouldn't add new ones.)


I appreciate you have touched on Orchard.Layouts but I think it still needs its own documentation. It needs stuff like user docs for newbies to build up their pages and developer docs to build their own custom elements.


Ebenso wurde der Standard auf EURO Preisliste umgestellt und Verbesserungen eingeführt, wenn wieder Währung umgestellt werden muss.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 592](http://build.prxm.it:8811/viewLog.html?buildId=3939&buildTypeId=Jarvis_DocumentStore_CI) is now running


you need to add you form fields
you need to add your form fields


That seems to cause the FP http://trac.cppcheck.net/ticket/6967


@fnikitin j'ai enlevé ton implementation car ca ne fonctionnait pas comme avant.. on regarde ca ensemble


I think this paragraph contains stuff from the old Orchard.CustomForms module? The screenshot seems to be from the old module and the description sounds like we are building the form again.


All is up to date and version 1.9.39 shows on cdnjs - thanks for your help.

On 9/4/2015 2:28 AM, Peter Dave Hello wrote:
> add autonumeric v1.9.31~1.3.39, cc @BobKnothe
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cdnjs/cdnjs/commit/0bdf6b51af110c651951bf770896cac46a257c02
>
>
>


Выполнил `statlogsValueEvent('OLOLO','OLOLO','YA','VODITEL','NLO');`
Подпортим статистику :laughing:


You can do a small hack as follow:
If you want to Long-press Dragon button to change IME, change the value of:
final int ENTER_CODE from **10** to **6463**
If you want to Short-press Deagon button to change IME, change the value of:
final int SWYPE_CODE from **43575** to **6463**

You can add a debug code between line 174 and 175:
**log("before onKey(): " + code);**
so you can check the key code in xposed installer log (Just open Xposed Installer and you can find the log)


foreach (var target in Program.Enemies.Where(target => Program.ValidUlt(target) && target.IsValidTarget(R.Range)))
            {
				foreach (var buff in target.Buffs.Where(buff => buff.Name == "dariushemo"))
				{
                if (R.GetDamage(target) + (((20 * R.Level) + (0.15 * Player.FlatPhysicalDamageMod)) * buff.Count) - target.Level > target.Health)
                {
                    R.Cast(target, true);
                }
				}
            }


wihtout / without


Your status as being part of PMPlugins is public.


I think we should report a bug against the minimal profile. As no YaST2 packages are installed, glibc-locale remains uninstalled (and you'll get errors about system locales).


I also posted a link on my profile page (On PM forums)


Fixes #36


FourPipeBeamAirTerminal (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (1819 of 1820 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Have you tried to run this code? :)

There is a good russian proverb about the situation which this code produces:
> Не руби ветку на которой сидишь.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20085/testReport/) for this commit**


Import-Export-Module
Import-Export module


@djorocas this can be xyz


Please remove this alert


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 592](http://build.prxm.it:8811/viewLog.html?buildId=3939&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Tests failed: 8 (8 new), passed: 287; compilation error: src\Jarvis.DocumentStore.Tests\Jarvis.DocumentStore.Tests.csproj (new) Build time: 00:14:13
### Failed tests
```
Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.DocumentControllerIntegrationTests("v1").verify_de_duplication__not_delete_original_blob_before_15_days: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.DocumentControllerIntegrationTests("v2").verify_de_duplication__not_delete_original_blob_before_15_days: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_html_to_pdf("v1").verify_html_plain_ToPdf_old: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_html_to_pdf("v2").verify_html_plain_ToPdf_old: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_multiple_password("v1").verify_tika_job_with_two_password: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_multiple_password("v2").verify_tika_job_with_two_password: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_password("v1").verify_tika_job_with_password: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_password("v2").verify_tika_job_with_password: <no details avaliable>

```


Ping @jbrooksuk. Does this look ok? Had to make all the changes in incident.blade.php manually.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 593](http://build.prxm.it:8811/viewLog.html?buildId=3941&buildTypeId=Jarvis_DocumentStore_CI) is now running


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20086/testReport/) for this commit**


How will MOOF be different from MUF?


Mehr darauf achten, dass ihr "atomar" committet. Das Löschen der Reste von `station_instances` sollte eigentlich ein eigener commit sein, genau so wie die Korrektur der association.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 593](http://build.prxm.it:8811/viewLog.html?buildId=3941&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Compilation error: src\Jarvis.DocumentStore.Tests\Jarvis.DocumentStore.Tests.csproj (new) Build time: 00:01:43


As far as I can tell, this will cause the resource to become "Smack", which may causes `resource-conflict` on login. Why was resource generation by server disabled?


But it's strange @BobKnothe, in ajax/libs/autonumeric/1.9.31/autoNumeric.js, the version in comment is 1.9.39?


it's funny that you use both `<$>` and `fmap` on the same line :P


Perfect!


This name no longer makes sense.


Nicht so viele Leerzeilen. ;)


it's (fmap . fmap)


Why ? How can you keep track of the `index.html` in this case ? I do not agree to ignore the whole folder.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20087/testReport/) for this commit**


Is this line necessary? I thought I added some foo to update the slug automatically when name changes


The store key is the first half of a full sha512 hash. So it's correct to use it as the imageID. It's just not the full imageID.


wasn't this changed in 2.2.1 ?


are phrases like `'like a man` still being caught? `girlish` and `girly` might be interesting too.


Dynamic Forms Widget
Should be just: Form Widget


@mohitmamoria  i love your habit of commiting in every change of code.


@sahilsarpal15 thanks..


I have to admit I don't exactly know the intention here but this line give an error: JS ERROR: TypeError: popup_rendering_actor.contain is not a function


Yeah, they are: [girlish and girly](https://github.com/wooorm/retext-equality/blob/ee7c95e41003b7426c4bb523898d66cdbf25d305/script/gender.yml#L653), and [like a man](https://github.com/wooorm/retext-equality/blob/ee7c95e41003b7426c4bb523898d66cdbf25d305/script/gender.yml#L1296)!


Works now! Thanks! 😃👍🏼


@arter97

What do you think of this commit ? Am I right on this ? Would it be profitable to built the init binary with Os flag ?

Also its static binaries are the following:

https://github.com/Khaon/android_system_core/blob/cm-12.1/init/Android.mk#L53

Should few of them, such libfs_mgr, be built as well with Os ?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20088/testReport/) for this commit**


Если style[key1] === undefined возникает сообщение об ошибке в Chrome


"an empty"


Just saw it is. Excellent ^___^


It was, but since we can't add it to currently released versions, I figured it was most likely to be read if it was in the latest section. Ill add a note about it being the default since 2.2.0


@lethalman ok, thx!


@jacksontj I am wondering what is the whole purpose of making async as sync? The problem is that we observe strange behavior of Salt API where _sometimes_ the HTTP returns error 500, and the tracebacks leads here. Usually, this happens when there are intense number of requests to the Salt API CherryPy.
```
[DEBUG   ] Error while processing request for: /run
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/salt/netapi/rest_cherrypy/app.py", line 438, in hypermedia_handle
r
    ret = cherrypy.serving.request._hypermedia_inner_handler(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/cherrypy/_cpdispatch.py", line 61, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/usr/lib/python2.7/site-packages/salt/netapi/rest_cherrypy/app.py", line 1605, in POST
    'return': list(self.exec_lowstate()),
  File "/usr/lib/python2.7/site-packages/salt/netapi/rest_cherrypy/app.py", line 702, in exec_lowstate
    ret = self.api.run(chunk)
  File "/usr/lib/python2.7/site-packages/salt/netapi/__init__.py", line 66, in run
    return l_fun(*f_call.get('args', ()), **f_call.get('kwargs', {}))
  File "/usr/lib/python2.7/site-packages/salt/netapi/__init__.py", line 183, in wheel
    return wheel.cmd_sync(kwargs)
  File "/usr/lib/python2.7/site-packages/salt/wheel/__init__.py", line 90, in cmd_sync
    return self.master_call(**low)
  File "/usr/lib/python2.7/site-packages/salt/wheel/__init__.py", line 66, in master_call
    ret = channel.send(load)
  File "/usr/lib/python2.7/site-packages/salt/utils/async.py", line 77, in wrap
    ret = self._block_future(ret)
  File "/usr/lib/python2.7/site-packages/salt/utils/async.py", line 87, in _block_future
    return future.result()
  File "/usr/lib64/python2.7/site-packages/tornado/concurrent.py", line 215, in result
    self._check_done()
  File "/usr/lib64/python2.7/site-packages/tornado/concurrent.py", line 293, in _check_done
    raise Exception("DummyFuture does not support blocking for results")
```

Do you have any comments on this?


Наверное, лучше было бы разобраться, откуда берутся такие странные стили. Ну или явно проверять на `undefined`.


If I understand how acbuild is implemented, the store is just used as a facility for rendering images as it handles image dependencies. I don't know if in future it will be replaced with something else or it will also be used for remote image fetching. In this case also other big parts of rkt should be reused (the fetching logic etc...).

Do you think that is should be kept for every run (becoming bigger) like done now (using future rkt image gc features), or it'll be better to create a temporary store for every run?


if someone do it in production, happen that a third party can access to a new API exporting sensitive data. is a seriously DON'T DO IT for security reason. like the --XXX option... we can put them all documented in NOTES without any indication if the --help.


Hur mycket skall flyttas ut? Kan man få tag på ApplicationBasePath i config-fil? UseSqlite("Data source=...") kräver absolute path av nån anledning och vill att det funkar på både win och linux servern.


This will reduce initial ramdisk unpacking time by 0.x seconds and I see nothing else regarding performance.
After ramdisk is unpacked, /init size shouldn't matter as it's literally in the ramdisk. It's blazing fast.

I wouldn't do this if I were you. Be careful as /init is a supervisor for all processes running under it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20089/testReport/) for this commit**


@mohitmamoria  your welcome


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8136/testReport/) for this commit**


And I should add, -Os generally decreases performance.


Tom commit ftw


I think it's better to be explicit and put the exact instructions as steps rather than asking somebody to crib off the screenshot. If somebody is reading it on a mobile this is going to potentially be really small, if they have disabilities they can't use their assistance software to make it high contrast or large print, if the tutorial is saved it might get broken images, etc. They are edge cases but it's better to explain each step :)


It's not weird :stuck_out_tongue_closed_eyes: . As the tar should be extracted in a chroot jail, instead of writing additional helper programs (difficult to find, distribute etc...) it just reuses itself (see coreos/rkt#923).


Done


typo: downloading


and extract it


Me sigue apareciendo esto:

Starting WhatsBot...

[INFO] [WHATSBOT] Loading. Debug = true

[INFO] [CONFIG] Loading
[INFO] [CONFIG] Ready!

[INFO] [INCLUDES] Loading
[INFO] [INCLUDES] Ready!

[INFO] [WHATSBOT] I am Bot (%92%a6%b3%d7%ac%3d%84%d7x%be0%01%cf%c5d%d3%c3%bci%f4)

[INFO] [MODULES] Loading
[INFO] [MODULES] Ready!

[INFO] [EVENTS] Binding listener
[INFO] [EVENTS] Ready!

[INFO] [WHATSBOT] Connecting
[INFO] [WHATSBOT] Connected!

[INFO] [WHATSBOT] Logging in
tx  <stream:features>
tx    <readreceipts></readreceipts>
tx    <groups_v2></groups_v2>
tx    <privacy></privacy>
tx    <presence></presence>
tx  </stream:features>

tx  <auth mechanism="WAUTH-2" user="%92%a6********************************"></auth>

rx  <start from="s.whatsapp.net"></start>

rx  <stream:features></stream:features>

rx  <challenge>k<=e`f</challenge>
                                        #`vYgb</response>
tx  <response>_.<%&{|6nvb7  }yOR{1ʡߨU~C6
rx  <failure>
rx    <not-authorized></not-authorized>
rx  </failure>

PHP Fatal error:  Uncaught exception 'Exception' with message 'Login Failure' in /home/albermonte/Web/WABOT/class/whatsapi/whatsp
rot.class.php:2297
Stack trace:
#0 /home/albermonte/Web/WABOT/class/whatsapi/whatsprot.class.php(564): WhatsProt->doLogin()
#1 /home/albermonte/Web/WABOT/class/WhatsApp.php(35): WhatsProt->loginWithPassword('sJbSGeR2uaiQnEt...')
#2 /home/albermonte/Web/WABOT/class/WhatsBot.php(104): WhatsApp->LoginWithPassword('sJbSGeR2uaiQnEt...')
#3 /home/albermonte/Web/WABOT/WhatsBot.php(12): WhatsBot->Start()
#4 {main}
  thrown in /home/albermonte/Web/WABOT/class/whatsapi/whatsprot.class.php on line 2297
./start.bat: line 4: pause: command not found


Fixed


цей рядок забрав!


@agorrod: Sorry, Alex, what did I miss?  And does it need a comment?


Well, let's say one *could*, but it would take some more effort. Currently this implementation is never chosen implicitly, since you do not use a Shape as parameter. Other than that, behaviour of `MapNeighborhood` is `ArrayIndexOutOfBoundsException` in most cases, if no OutOfBoundsFactory is present or the input image has been extended before running the op.

There is no case where the other map and this implementation give exactly the same result, since the other `MapNeighborhood` implementation will *never* ignore out of bounds pixels due to it's implementation.


@narcoticfresh this is afaik actually the way to go, since we do not want to run into the rather complex mocking hell trying to get rid of the original Producer.

so +1 for this solution. thx


Sorry, I meant that ret->data = NULL probably could be removed. Haven't double checked though.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20090/testReport/) for this commit**


unzip it


Yeah I do know, that's why I am not sure if it should be built with O3 that may also brings more instability.

Overall Os or O2 shouldn't be preferred for important components instead of O3.

I know that, for example, that the updater-binary's size doubles under O3.

I am not sure about this but I think default's flags enabled under Os and O2 for androideabi are not the same for the arm-eabi.

So you think the gain in term of unpacking wouldn't be worth by a potential decreases in performance under O3 once unpacked ?

Also do you think fsck.f2fs should be built with Os/2 ? I was always wondering/worried if building it with O3 could not result in a broken code(well with a very very low probability)


Ah, no, estás poniendo la identity en WhatsBot.json[WhatsApp][Username].
Ahi debes poner el número con código de país.
El 04/09/2015 08:11, "Albermonte" <notifications@github.com> escribió:

> Me sigue apareciendo esto:
>
> Starting WhatsBot...
>
> [INFO] [WHATSBOT] Loading. Debug = true
>
> [INFO] [CONFIG] Loading
> [INFO] [CONFIG] Ready!
>
> [INFO] [INCLUDES] Loading
> [INFO] [INCLUDES] Ready!
>
> [INFO] [WHATSBOT] I am Bot
> (%92%a6%b3%d7%ac%3d%84%d7x%be0%01%cf%c5d%d3%c3%bci%f4)
>
> [INFO] [MODULES] Loading
> [INFO] [MODULES] Ready!
>
> [INFO] [EVENTS] Binding listener
> [INFO] [EVENTS] Ready!
>
> [INFO] [WHATSBOT] Connecting
> [INFO] [WHATSBOT] Connected!
>
> [INFO] [WHATSBOT] Logging in
> tx stream:features
> tx
> tx
> tx
> tx
> tx /stream:features
>
> tx
>
> rx
>
> rx stream:features/stream:features
>
> rx k<=ef</challenge>
> #vYgb
> tx _.<%&{|6nvb7 }yOR{1ʡߨU~C6
> rx
> rx
> rx
>
> PHP Fatal error: Uncaught exception 'Exception' with message 'Login
> Failure' in /home/albermonte/Web/WABOT/class/whatsapi/whatsp
> rot.class.php:2297
> Stack trace:
> #0 /home/albermonte/Web/WABOT/class/whatsapi/whatsprot.class.php(564):
> WhatsProt->doLogin()
> #1 <https://github.com/fermino/WhatsBot/pull/1>
> /home/albermonte/Web/WABOT/class/WhatsApp.php(35):
> WhatsProt->loginWithPassword('sJbSGeR2uaiQnEt...')
> #2 <https://github.com/fermino/WhatsBot/pull/2>
> /home/albermonte/Web/WABOT/class/WhatsBot.php(104):
> WhatsApp->LoginWithPassword('sJbSGeR2uaiQnEt...')
> #3 <https://github.com/fermino/WhatsBot/issues/3>
> /home/albermonte/Web/WABOT/WhatsBot.php(12): WhatsBot->Start()
> #4 <https://github.com/fermino/WhatsBot/issues/4> {main}
> thrown in /home/albermonte/Web/WABOT/class/whatsapi/whatsprot.class.php on
> line 2297
> ./start.bat: line 4: pause: command not found
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fermino/WhatsBot/commit/5f2e6dcbab94878f84cf4d88db312d85f79b5a7c#commitcomment-13066927>
> .
>


TeamCity ReOpenLDAP :: ps-2.4-stable [Build 87](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=341&buildTypeId=ReOpenLDAP_ps24stable&guest=1) is now running


мне кажется, что не все в курсе, что такое i18n и тут лучше сделать акцент на этом.


Sorry for that


Neato shortcut, tolerable cruft in hookrepo.


Woop woop!


I believe these are very much needed to handle ISO9660/UDF images with large files (> 4GB) using libcdio.

See https://github.com/pbatard/rufus/blob/master/src/libcdio/udf/udf_fs.c#L344


I suggest linking because then if anyone makes commits to those files in the future it won't be necessary to re-copy; symbolic links will just point to the most recent version in the _githooks/ path.


I didn't experience any magic; updating the name left me with an oudated slug.


This is always shows for me and I am not sure what it does.


I think those warnings were thrown when running Visual Studio code analysis...


Thanks!


And docs.


@peckomingo Sollen wir hier nicht zur Registrierung verlinken? In der Anmeldung sind wir ja bereits.


That might be helpful... I'll see if I can steal this one! :smile:


I know. But who would look at my profile?


For what is this used for ? Should this really be a fix value ?


Pewnie opacznie zrozumiałeś mój komentarz  - lepszym rozwiązaniem będzie jeśli prześlesz mi Twój plik <code>.gitignore</code>


Excuse me, I overlooked that! Thanks for noticing.


Closed #10


нет, ниже расписано, какие файлы используются для keysets


Look for ting_lookup_and_translate().
Might make the trick.


it should be HEAD...


@Flowdalic resource now set to client generated value. Server generation was disabled because new resource was generated every connection. Later I will implement saving of first time generated resource and enable server generation.


ALTER TABLE realmd_db_version CHANGE COLUMN required_10008_01_realmd_realmd_db_version required_z2678_01_realmd bit;


I don't think Os/O2/O3 or even Ofast would make a noticeable difference in boot time.

Regarding stability, I don't think there are fragile codes in system/core/init. It's relatively simple compared to rest of the Android.

Other fsck and stuffs, you shouldn't worry as if O3 or such would break things, someone else would have reported it first(especially e2fsck).

And also, I haven't seen O3 breaking something if it was running fine on O2.
We have some breakages because we switched Os to O3, not O2 to O3.
And it's very unlikely that fsck tools are NOT tested under O2.


Expanding #3's use case, it affords refactoring to:

[ -f 'badfile' ] || exit 1

I think it's easier for a user to grok and less error prone (i.e. this blocks 'badfile' being deleted).


ALTER TABLE character_db_version CHANGE COLUMN required_z2559_s2204_12756_01_characters_pvpstats required_z2678_02_characters bit;


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (764 of 764 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-10.43%25-green.svg)


Making this set a var might be a small optimization. Would save us some extra allocations.


Done


ok


That table does not exist.


Is this commit supposed to reduce the iso size (as indicated by commit message), or only note it as a shortcoming (what the diff actually does)?


This line causes a typeerror Cannot read property '1' of undefined if a message does not contain a session-id.
A check sohuld be included if session-id is included at all in the package


missing header?

    #!/usr/bin/env python


maybe export SPARK_SUBMIT and check for that instead?
this way perhaps it should check the make sure `${SPARK_HOME}/bin/spark-submit` exists when in bin/interpreter.sh


Check out factory_girl's "lint"


result or acc(umulator) perhaps?


fix_zone_hvac_objects (mbadams5) - i386-Windows-7-VisualStudio-12: OK (2318 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.19%25-yellow.svg)


Once again - if extracted we'd be doing less allocations here.


Ah nee dat gaat niet checken of ze valid zijn of niet


Good catch !!!!


Wait what. How you even do this?


@robertavram did you get Equitrack working on your mac with these steps? I have to set it up on my new macbook


Pas sûr que je puisse de la sorte, car il y a une relation many-to-many entre un User et un Account.


Separate every 3 digits in the integer portion of a number with underscores(_).


Space missing after comma.


Comment should probably say that it's in nanoseconds, to avoid confusion.


The reduce action is a bit convoluted and should probably be extracted into a separate function.


so if i write to arduino that code and i connect to rcd300 data out, data in and clock, when i double press on button CD, apears that i have cd changer but have no cd. what i do wrong.
sorry for my bad english.


ok, I don't understand why the result of `build()` is never used


nice cleanup


It would probably be better to do this as a float, since multiplying by the water factor will require a conversion to float anyhow.


Undrar detsamma :P


FourPipeBeamAirTerminal (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1825 of 1826 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


I'm wondering if this loop would be better written as
```python
for plant in featurelist:
    string1 = plant['properties']['capacity']
    ...
```


Please use a more semantic ID here.


LGTM


Spacing; also `if session["validated"]`.


Hmm, you're absolutely right.


Running a few tests that require this, its anywhere from 18-25% slower on a 3 param out of order code ... no surprise as its a lot more computation vs permute.  Will likely do better when you have >3 or really >? (5 or 6) but thats the ,01 fringe case IMO


Hm I recall that forcing O3 on libchromium would yield the final lib to be  48MB instead of 24~.
Also It would yield many runtime errors.

I aggree with you about simple code: chromium's libs contains many more complicated code.

And Os was enforced in the chromium's Android makefiles. So as you stated that why we had those tons of issues.

Well thanks for the answer, I ll just drop the idea of being "secure" :p


Couldn't you use Registration::distort here? Seems to be identical...


Let's not get ahead of ourselves here... let's get everything else working first, then add this.


rfile() and absolute paths are needed to make out-of-tree builds (with -Y option) work. This must be fixed in a different way.


isn't it better to source control the JS and CSS files to?


Spacing plus semantic IDs.


idk  :P


this is rather verbose. Looks like simple if-return pairs would have been a lot more readable


-- phpMyAdmin SQL Dump
-- version 4.2.11
-- http://www.phpmyadmin.net
--
-- Host: 127.0.0.1
-- Generation Time: Aug 27, 2015 at 03:40 PM
-- Server version: 5.6.21
-- PHP Version: 5.6.3

SET SQL_MODE = "NO_AUTO_VALUE_ON_ZERO";
SET time_zone = "+00:00";

/*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */;
/*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */;
/*!40101 SET @OLD_COLLATION_CONNECTION=@@COLLATION_CONNECTION */;
/*!40101 SET NAMES utf8 */;

--
-- Database: `customers`
--

-- --------------------------------------------------------

--
-- Table structure for table `registration`
--

CREATE TABLE IF NOT EXISTS `registration` (
`usr_id` int(3) NOT NULL,
  `usr_name` varchar(13) DEFAULT NULL,
  `usr_password` varchar(13) DEFAULT NULL,
  `usr_email` varchar(13) DEFAULT NULL,
  `usrl_id` varchar(13) DEFAULT NULL,
  `lng_id` varchar(13) DEFAULT NULL,
  `usr_active` varchar(13) DEFAULT NULL,
  `usr_question` varchar(13) DEFAULT NULL,
  `usr_answer` varchar(13) DEFAULT NULL,
  `usr_picture` varchar(13) DEFAULT NULL,
  `usr_password_salt` varchar(13) DEFAULT NULL,
  `usr_registration_date` varchar(13) DEFAULT NULL,
  `usr_registration_token` varchar(13) DEFAULT NULL,
  `usr_email_confirmed` varchar(13) DEFAULT NULL
) ENGINE=InnoDB AUTO_INCREMENT=6 DEFAULT CHARSET=latin1;

--
-- Dumping data for table `registration`
--

INSERT INTO `registration` (`usr_id`, `usr_name`, `usr_password`, `usr_email`, `usrl_id`, `lng_id`, `usr_active`, `usr_question`, `usr_answer`, `usr_picture`, `usr_password_salt`, `usr_registration_date`, `usr_registration_token`, `usr_email_confirmed`) VALUES
(1, 'brent', 'ef270e101e10a', 'hello@gmail.c', '2', '1', '0', NULL, NULL, NULL, 'wJL+"n)BGA`}>', '2015-08-11 10', 'f4b6c772788df', '0'),
(2, '123', '90fcddd7f8ab1', '123@gmail.com', '2', '1', '0', NULL, NULL, NULL, 'SQ_h3qMn03''aj', '2015-08-26 10', '559fbee236bfe', '0'),
(3, 'brent1', '293c2f0754371', 'brent@gmail.c', '2', '1', '0', NULL, NULL, NULL, '62nLT\\,YYi.eg', '2015-08-27 13', '910645a503419', '0'),
(4, 'luwi', '2dcde6ad97d07', 'luwi@gmail.co', '2', '1', '0', NULL, NULL, NULL, 'EWv$Vz_zYw[^W', '2015-08-27 14', '5e525059ee65a', '0'),
(5, 'ad', '680828786a4da', 'ad@gmail.com', '2', '1', '0', NULL, NULL, NULL, 'r/BhmCu(*}PqU', '2015-08-27 15', 'cca6a675d5e89', '0');

--
-- Indexes for dumped tables
--

--
-- Indexes for table `registration`
--
ALTER TABLE `registration`
 ADD PRIMARY KEY (`usr_id`);

--
-- AUTO_INCREMENT for dumped tables
--

--
-- AUTO_INCREMENT for table `registration`
--
ALTER TABLE `registration`
MODIFY `usr_id` int(3) NOT NULL AUTO_INCREMENT,AUTO_INCREMENT=6;
/*!40101 SET CHARACTER_SET_CLIENT=@OLD_CHARACTER_SET_CLIENT */;
/*!40101 SET CHARACTER_SET_RESULTS=@OLD_CHARACTER_SET_RESULTS */;
/*!40101 SET COLLATION_CONNECTION=@OLD_COLLATION_CONNECTION */;


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20091/testReport/) for this commit**


Цикл?


This is not a great way to do this.  For internal use we should be building a python structure.  Then, if we need the JSON version we could use `json.dump()` or even `json.dumps()`, if we want to have the string internally.  We definitely shouldn't be building up the JSON string incrementally.


Chromium is an another, entire platform.
If I recall that moment from now, it was stupid to globally change the
compilation flag on Chromium.

Now we use Chromium directly provided by Google, so we can rest easy there
:)

On Fri, Sep 4, 2015 at 8:33 PM, Maxime Poulain <notifications@github.com>
wrote:

> Hm I recall that forcing O3 on libchromium would yield the final lib to be
> 48MB instead of 24~.
> Also It would yield many runtime errors.
>
> I aggree with you about simple code: chromium's libs contains many more
> complicated code.
>
> And Os was enforced in the chromium's Android makefiles. So as you stated
> that why we had those tons of issues.
>
> Well thanks for the answer, I ll just drop the idea of being "secure" :p
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Khaon/android_system_core/commit/181cbaac986c6fdc61a2c20f44f18616b341b6a9#commitcomment-13067193>
> .
>


Some "magic numbers" here, perhaps explain them briefly?


@fatmcgav We typically configure mongo so that it isn't listening on localhost. Thus the revert. I could certainly change this... but it does concern me that others might hit this issue as well.

Perhaps another option would be to make it so that the initialization host is configurable (i.e. make it so that host = 127.0.0.1 isn't hardcoded)


Why do we need to exclude private properties? Is it because they will be reported elsewhere?


Use an absolute path here. (Also `class="form"`?)


name wrong, I'd call it
val answer = getAnswer(answer)


Typo in the commit message...


@Nadahar you can also get one thread to wait for an event in another thread using a (CountDownLatch)[http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/CountDownLatch.html].


Corrected


What other elements can occur here?


Lowercase IDs.


So no short names, but long descriptive names


@loonycyborg then it is already broken, because next test uses that line: https://github.com/techtonik/wesnoth/commit/d77178eb8b4ecc5af6822deb6a044200cefbcb24#diff-5012934025925b7143e4ccfc5571462eR113


`if email`


never do == false. Instead you could: answer == Some(false)


Yeah the code is kinda huge so is the the final lib, it is the biggest lib among the android's lib if I am not mistaken.

Yeah using prebuilts is better I think. However, where do you get those ?


Ok


Good point, probably forgot to (auto) format the file


Why the change? Using session["email"] seems more obvious.


Why is this check needed?


@ptitzler couldn't it just be written as `email.toLowerCase().endsWith("ibm.com")`?


They were caused by the fact we used json-path library in tempto. @sogorkis changed the code to use jackson instead; so we got rid of these conflicts.


actually, summary.yesQ2 < summary.noQ2 is also Some(false)


Moved to airlift http client.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20092/testReport/) for this commit**


Ideally, people will never need to enter this in — it will just be a magic URL parameter.


The log class will handle all errors (set in the constructor). But I don't know any better way than to initialize a variable


Done.


I try to keep code under 80 characters; please wrap here.


`element.containigFile` is named `jetFile` already, I think


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8137/testReport/) for this commit**


@dprince If it's considered best practise to not listen on localhost, then that's fine...
However the issue was that the initalize call with auth_enabled doesn't work through a non-localhost address, unless I've missed something :)

Having it configurable would probably be a good middle-ground...


Fixed


Please de-inline.


sorry, testFunc was to test if I could reach the model. No TDD or whatsoever. But I'll implement tests later on


Attributes should be prefixed by an `m`, e.g. `mGifMovie`


Nope, will look into it


TeamCity ReOpenLDAP :: ps-2.4-stable [Build 87](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=341&buildTypeId=ReOpenLDAP_ps24stable&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 00:24:18


I believe this is extraneous, since Bootstrap uses 12 columns.


No, rend is physical damage, you don't need to add spellshield into calculations.


What do you mean ?

Something like :

@Inject
public void init(ClassPathConfigurationProvider classPathConfigurationProvider,
                        JavaMailRepository javaMailRepository) {
    /* init stuff */
}

?


I don't understand this at all.  If I'm understanding the preceding code right, `output` is a string.  `json.dumps()` takes a python object and converts it to a JSON string representation, which is not what we want to do here.


Thanks Denis +1


Typo?


None of these tokens exist. `die` is parsed as `T_EXIT` and `self` and `parent` are `T_STRING`.


"Logout" — also spacing.


Ne, das `save` würde ich da tatsächlich ganz wegnehmen. Wenn jemand ein neues Schiff anlegt, will er es nicht unbedingt sofort speichern (und auch nicht teilweise speichern, also z.B. nur die Zuordnungen zu den stations).


I've used this "class" before with some other students, that's why. But when the code get some kind of stable I'll implement more docs


Why default the completion code to OUT_OF_SPACE?


This code needs to be wrapped in `if __name__ == "__main__":` so that it will execute only if this file is being run as a stand-alone script, not whenever the module is imported for use in another module.


Please de-inline. Also, let's hold off on adding this until we actually implement this feature.


Why ?
Without this, how Guice retrieves the method parameters ?


True, but depending on the url (base.com or base.com/admin) You'll end up inside an or another


Organized templates using [this guide](https://scotch.io/tutorials/use-ejs-to-template-your-node-application)


我在10.10.4下通知不会出现, 你那有这个问题吗


Ok


What about non-gif files dimensions? Maybe you should use `mBitmapWidth` and `mBitmapHeight` to store it, so it's shared for any type?


On the email.
remove


Btw, this changeset landing probably means that you can drop ST_LOOKING_FOR_FUNC_NAME support in the lexer.


You're right, I'll implement it in a different way


для каждой библиотеки ядро лежит в своем кейсет-файле


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1294 of 1294 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.02%25-green.svg)


Is this some kind of a good practice even though modules are not expected to be executed? (Unless there is a test suite included. But that is not our case.)


I thought it would be better this way then everything on it's own line


There is no `has_roles?` method in rolify gem, but you are right about moving this code to model.


You said in a previous review that my GuiceGenericLoader looked like a bad idea...
Anyway, I will recode it.


Doesn't this still need to pass the user/pass or does making it a PSCustomObject change into a param array?


@gsaponaro
I think `if (!yarp::os::Network::checkNetwork())` is enough (and a bit more readable)


This also means that it needs to be run as root for getting chroot capability, or adding that cap to the acbuild executable.


RCD300 is special somehow..... what it say on serial console of arduino?


Ty


Już wysyłam.


Please add whitespace around +.


Perhaps `acbuild` for the command and also the library will be cleaner and consistent with the doc.


For ``x = <something>` this method will be called twice: with PropertyDescriptor ans PropertySetterDescriptor.
If property is private and setter is private, we report warning for property.
If setter is private and property is not private, we report warning for setter.


Hmm, it is indeed not that easy to read. But I made this with the thought that if you could merge 3 lines into 1, it would be better. But to be honest, I have no clue...


I really think I had a reason why I needed out_packet_ready instead of sending the packet directly but I cannot remember.


Not possible

TER does not accept this dependency: `7.4.0-7.99.99` but any other dependency would be wrong. typo3_console is not compatible with 6.2.x any more


It gives immutability and the trust that no field is missing. I would say it's better with than without so I'm not inclined to change it now. You would have suggested a POJO ?


1579840-GroundTemps (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Add an extra note here along the lines of:

If you don't see the bindings tab then save your form and go back into it.

You made saving the form optional earlier so people might not have saved it and then they wont see the bindings tab.


Why did you ditch SHA comparison?


ok


What about calling it `rm-dep`. `rm` looks like removing a file from an aci.


I am not sure about it. For now I'll replace this check with assert.


I'll fix it.


It would be nice to fix this in the [UPGRADE.md](https://github.com/contao/core-bundle/blob/master/UPGRADE.md#css-classes-of-included-elements) file too.


not sure if you want to change the programmatic api in this place. the intention here is to return json and not a human readable textstring, as it is harder to process from consumers. teh return value of the promise is the programmatic api for http://robertkowalski.github.io/nmo/api/nmo-isonline.html


Lines 75-76 can be written more succinctly as `b = json.load(z)` .  Generally, we shouldn't really be using `json.dumps()` and `json.loads()` at all.  Inside of python code we only want python objects, not JSON strings.  When we read in from disk we want to use `json.load()` to get a python object, and when we go out to disk (or to another type of file, like an I/O pipe) we want to use `json.dump()`.


As per the above comment what about something like: `add one or more ACIs to the input ACI's dependencies list`


What about calling it `add-dep`? It will be consistent with `rm-dep`.


Awesome!


Actually, jetFile is out of scope here.


with the `done()`added there this async tests ends too early. if you take a look at the block above, line 159 - where i monkey patch console.log to verify that we are logging the result to the console and then call `done` - that is the asserting part of the test


For what is worth, a good tool for checking the sources is https://pypi.python.org/pypi/pep8
It would be nice if we can run this on existing files and try to run it before each PR (git can be setup to run it automatically before each commit, but we may not like that upfront :)


Have this function take a python object that was _parsed from_ JSON, rather than a raw JSON string.


I don't think this would be necessary, given that most users don't see the dialog when they invoke the action.


I guess we can add here a few tests about the existing functions as well.


`\t` on this and the disabled line ;)


Here comes some forex trading tips what were given to traders from the original website: http://www.smarttrade.co.com

You will find professional analysis for each trading tips as well.

2015.08.31 Monday. SELL WTI Crude Oil at $ 43.80

for more details click here:
http://www.smarttrade.co.com/en/tradingtip/sell/WTI-Crude-Oil-at-dollar-43-80-2015-08-31-4-47-19

2015.09.01 Tuesday. BUY EUR/USD 1.1250

for more details click here:
http://www.smarttrade.co.com/en/tradingtip/buy/EUR-USD-1-1250-2015-09-01-5-16-58

2015.09.02 Wednesday. BUY EUR/USD at 1.1250

for more details click here:
http://www.smarttrade.co.com/en/tradingtip/buy/EUR-USD-at-1-1250-2015-09-02-4-45-15

2015.09.03 Thursday. BUY Tesla (TSLA) at $ 248.50

for more details click here:
http://www.smarttrade.co.com/en/tradingtip/buy/Tesla-TSLA-at-dollar-248-50-2015-09-03-3-34-31

See You on next monday.


I'm not sure what this is needed, so some comments and an expanded commit message are probably in oder.


Get what?
On Sep 4, 2015 8:36 PM, "Maxime Poulain" <notifications@github.com> wrote:

> Yeah the code is kinda huge so is the the final lib, it is the biggest lib
> among the android's lib if I am not mistaken.
>
> Yeah using prebuilts is better I think. However, where do you get those ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Khaon/android_system_core/commit/181cbaac986c6fdc61a2c20f44f18616b341b6a9#commitcomment-13067241>
> .
>


bind it too
bind it to


You are the master of bpf filters, so what ever you say here..


`checkdoc` will complain here.


I'm pretty sure the ast package is not really intended for what we're using it for here.  I think it is only supposed to be used by people who are fiddling with python's internals.


I'm running the `registry:2` image and for tags, the pagination support is working. Is the documentation referring to how it should work, once it is implemented?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20093/testReport/) for this commit**


:+1: update readme.md !


I sense some overlap with `var-info` here. At least from the docstring it's not clear at all why this extra command is needed.


The list of file are the cassandra-reaper-ui assets.
Ignoring the asset folder would Work as well.  I wasn't if it one day the official UI would be included as part of the project

Sent from Outlook on iPhone

On Fri, Sep 4, 2015 at 2:32 AM -0700, "Hannu Varjoranta" <notifications@github.com> wrote:

These files seem a bit random to be included into the .gitignore. Could you be a bit more specific on why these are here, and why not add some upper folder with wildcards?

—
Reply to this email directly or view it on GitHub.


I see. That makes sense. On the other hand it does not look very nice from the security point of view... I like to know what's happening exactly in those hooks. And I believe contributors could have similar preference.


good


Agreed. Use JUnit (or Hamcrest) assertions for Unit tests.

The Java **assert** keyword is mainly used in actual code, for example to check whether constructor arguments were passed when creating an Object. It also needs the -ea flag to be added when starting your JVM to work.


@sferik Hello Erik! Do you have automation script to update RubyGem like this commit? Saw you did dependency updates for so many projects, it is awesome. Thank you.


Use `loads()` to do this.


Hi, Damien!

Actually I don't think this is the right fix, since the counters can be used from different places, and sometimes it is useful to know whether the key exists or not in the cache.
I ```get_dialog_profile```'s case, you are right, the counter should be set to 0 if the value was not previously found. And I double checked the code and it is, indeed, set to 0, but there are two Error messages displayed. Are you trying to get rid of those messages? Because if that's what you want to do, I think the best way to go is to update the ```get_dialog_profile``` function to check the returned code of the cachedb function and if it is -2, do not consider it an error, but simply set the counter to 0.
Let me know what you think.

Best regards,
Răzvan


Maven doesn't force this and this was my best "guess". We use enforcer 1.4, so I went with the version used there: https://github.com/apache/maven-enforcer/blob/enforcer-1.4.1/pom.xml#L69

The example enforcer rule uses an even older version: http://maven.apache.org/enforcer/enforcer-api/writing-a-custom-rule.html

Do you think we should change this?


i think this deletion cause this error:
Fatal error: Class 'Template' not found in /piwigo/install.php on line 244


This was not covered in the Unit Testing & Mocking workshop, but is indeed one of the newer and easier ways to do assertions.


I'm not 100% certain, but I _think_ this may cause problems if/when we switch to python 3.  If so, we should at least flag it with a comment to that effect.


Also, all of your functions need to have documentation strings.


Needs explanation of where the submitted content goes to (that it creates a new "content item" for each submit).


Once again, we probably don't need the loop index here.  We can loop over the items in the list, instead of an index that allows us to find the items in the list.


I'll avoiding using Layer here and in other places (also the doc) since ACIs are not layered but an ACI can have dependencies (one or more) on other ACIs and IMHO it looks confusing.


I'm a bit against the following removal:
* I use extrastereo to have a wider audio image when listening to speakers that are too much close each other; there are no equivalent in ffmpeg

* af_export filter has worked really well for simple vmeters visualization within my gui, xt7-player.
could you please reconsider the removal of export filter if/when mpv will provide another/better way to do visualizations?

* xt7 player also has a wrapper/gui to use a tons of ladspa plugins like multiband compressor (which i find very useful)
I know ladspa is a filter present in ffmpeg too, but it needs to be explicitely enabled at compile time, and it is not (at least on my distro, arch, which includes ladspa in mpv);
For the latter, i already did a request to ffmpeg package to include ladspa anyway.

Thanks you very much.


Is it intended to leave the file migration-chat-addon.js and the documentation about this script ?


Hi. First above all, thank you for sharing your code. I hope my mpl3115a2 sensor data by your code.
I am using Raspberrypi and OS is Rasbian Wheezy(version is 4.1.6-v7+). I've installed sqlite3 on my rashperrypi and
now I am following this install script. when I execute make in src, the message is this.

gcc - g - O - Wall   -c I2cWriteRegister.c
gcc - g - O - Wall   -c I2cReadRegBytes.
I2cRReadRegBytes.c : In function 'I2cRReadRegBytes' :+1:
I2cRReadRegBytes.c : 20 : 5 : warning : pointer targets in initialization differ in signedness [ - Wpointer -sign]
I2cRReadRegBytes.c : 20 : 5 : warning : (near initialization for 'rdwr.msgs[0].buf') [ -Wpointer-sign]
I2cRReadRegBytes.c : 26 : 5 : warning : pointer targets in initialization differ in signedness [ - Wpointer - sign]
I2cRReadRegbytes.c : 26 : 5 : warning : (near initialization for 'rdwr_msgs[1].buf') [ - Wpointer -sign]
gcc - g - O - Wall -c ReadSQLiteTime.c
gcc - g - O - Wall -c InsertSQLite.c
gcc - g - O - Wall -c mpl3115a2d.c
gcc -lm -lsqlite3 - O I2cWriteRegister.o I2cRReadRegBytes.o ReadSQLiteTime.o InsertSQLite.o mpl3115a2d.o -o mpl3115a2d

and when I execute sudo ./mkmpl3115a2d in doc, the message is "sudo ./mkmpl3115a2d : command not found.

and I don't know how can I do now.
Actually I am really beginner in linux. how can I do?

And I have one more question. above install script, you said
# Installation script for Rasbian Wheezy. The installation script can be
# run after compiling the binaries.

what does "run after compiling the binaries?" mean?

Please give me any help.

Thanks in advance.

Regards,

JaeHyuk.


Well, I did make the icon somewhat smaller. I tried to give the icon the same height as the "Media-Player" plasmoid. Most StatusNotifier icons are in fact a little bigger that this.


@aschempp : No need to change the version of MySQL?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20094/testReport/) for this commit**


Hi Keith,

That one was paranoia on my part. I wanted to merge the branch, and wasn't
comfortable removing the skip test from the clause. I didn't see you
explicitly describe why it was OK to remove that particular check, so I
added back in and merged.

Please open another pull request with that change if you think it does not
need to be there.

I thought it might be required when evicting from dead or closing handles.
On 4 Sep 2015 9:12 pm, "Keith Bostic" <notifications@github.com> wrote:

> @agorrod <https://github.com/agorrod>: Sorry, Alex, what did I miss? And
> does it need a comment?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wiredtiger/wiredtiger/commit/3f3c3a59e6d2e2fdcec19d040accb50c05fa52a8#commitcomment-13066937>
> .
>


I guess I forgot to implement it then. I think we need to override this method on the model:

http://www.rubydoc.info/github/norman/friendly_id/FriendlyId%2FSlugged%3Ashould_generate_new_friendly_id%3F

To return true if `slug.blank? || name_changed?`


@legoboy0215 I did because I was mentioned.


I have no idea. Was just wondering if it makes sense as we require on the other end Maven 3.1 at least. But not a big deal.


@legoboy0215 I did because I was mentioned. Blame @Gamecrafter.


No tests are run with just:

```xml
<build>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <version>2.18.1</version>
            </plugin>
        </plugins>
    </build>
```

Where is the default defined?


In IntelliJ, use `Alt+Enter` on that line and choose `Add on demand static import for ...` to statically import the assertEquals or any other static method.

IntelliJ will add `import static org.junit.Assert.*;` at the top of your class automatically.


Without this check,  there are cases, when this warning is not really should be generated, see
JetDiagnosticsTestGenerated.testPrivateFromOuterPackage for example.


Justo esto. Con los editores y las distros de Linux casi que habría que hacer lo mismo. Aquí quiero colar la regla de "Sed Hackers" de dominar al menos tres lenguajes: uno general, uno de scripting y otro raro.


This is a good place to use a python list comprehension.  Any time you need an output list where each item is a function of an item in some other list, instead of writing
```python
for item in inputlist:
    newitem = func(item)
    output.append(newitem)
```
write
```python
output = [func(item) for item in inputlist]
```

There are a lot of bells and whistles you can add to a list comprehension.  For more information:  https://docs.python.org/2/tutorial/datastructures.html#list-comprehensions


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


I think this should be enhanced to let the user specify the dependency. One should provide an existent aci to extract data from it (like in this case) but also just providing a name and some labels .


Public variables must remain as is to remain backward compatible.


Since you're already using Lombok, use the `@Slf4J` annotation on your class. Lombok will add a `log` instance to your class at compile-time:

    private static final org.slf4j.Logger log = org.slf4j.LoggerFactory.getLogger(LogExample.class);

You can then use this instance to log wherever you want in that class.


I'm quite sure all of that should be below the check for bash version because we use the =~ for compare


No, but I was wrong


Can you please not mix two subjects in one commit, and make line endings trimming as separate commit, eg.:

1. db_mysql: Trim whitespace
2. db_mysql: Update to fastRows() description

Thanks :)


fixes after review: https://github.com/JetBrains/kotlin/commit/0b084f0d2b84999b57851b18fda6e95c7172e009


Hecho (6b5d657).

Sobre las distros yo las mencionaría de pasada y añadiría que tanto nosotros (en seminarios) como la OSL pueden echar una mano a instalar y configurar un Linux.


I'll also add the image labels as they will be needed for retrieving the right image on discovery.


@wfleming @GordonDiggs Please note that this change increases the size of the image from 37.47MB to 286.6MB. Default `ruby` image is even bigger (over 700MB).


it's a provider, param will be injected without @Inject


Oh...:P


This isn't enough, as Dynamic Forms has its own separate feature for enabling import / export:

![image](https://cloud.githubusercontent.com/assets/1038062/9683255/550ccdd6-5306-11e5-85ac-49364e47d3ec.png)


I was just considering jumbo.h sort of porting 'glue' code.  Code/data gets put here, that helps for porting.

Like

- the unified fseek/ftell working 64 bit 'clean' across all systems
- systems missing functions 'assumed' universal in code (strcasecmp, etc). NOTE, the getopts code should probably be part of this, or at least that header file should get included within jumbo.h (adding that to my todo list).
- other defines to make compilers more compatible with each other.

Now, the code you added certainly works here, but it really is different than most.  I am not sure where it really could go.  Do we have other crypto generic stuff scattered?  If so, is there a need for a crypto-misc or crypto-common  code, which may actually reduce file count, if there are numerous smaller one-offs.   I think a lot of this 'common' stuff is probably buried inside of format source files, which makes it unusable as common code, and things get rewritten over and over again, OR someone uses 3rd party libs to do the work for them.   I know you hate extra files getting sprayed out.  We really should look at grouping the code into directories (we have a couple, aes for one), but a layout more like oSSL where it splits things up into lib groups may be something that would make sense for john also.

Yes, I know this is very OT for posting against a code push, but it may be something we should at least think about, to try to overcome the growing pains of  having 700 or so base files, and growing.


This file (and the matching header) is missing from this commit. Either move the changes to the other commit or merge the two commits?


I couldn't find where are the Google's prebuilts chromium libs.


I can't thank you enough man. Let's just hope this all pays off. Shoulda brought my laptop to school so I could test this


Reverted support.


There's probably a misunderstanding, my negative comment was probably more about how it was done


Erm... needs work!


@12345ieee et voila' ;-)


Shit, I forgot a couple things here. Sorry, will pull in a few minutes, hadn't been awake long


not directly relevant to this PR, but note Docker's package is now named "docker-engine"; see https://blog.docker.com/2015/07/new-apt-and-yum-repos/


#BlameCrafter


Shouldn't `Gif.h`, `Gif.cpp` and `DllLibGif.` be part of the `guilib` subdirectory like `JpegIO.h` and `JpegIO.cpp`? I always considered the `pcitures` subdirectory for the slideshow and "picture library" handling.

But I just saw that `DllLibExif.h` is also in there so looks like it's not very consistent.


It's on the Play store.
www.apkmirror.com/apk/google-inc/android-system-webview/

On Fri, Sep 4, 2015 at 9:11 PM, Maxime Poulain <notifications@github.com>
wrote:

> I couldn't find where are the Google's prebuilts chromium libs.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Khaon/android_system_core/commit/181cbaac986c6fdc61a2c20f44f18616b341b6a9#commitcomment-13067881>
> .
>


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20095/testReport/) for this commit**


This commit removes the run operation flag processing, which allowed specification of which instance to target, as you can now specify a target instance globally.


Probably the ideal fix is to convert this to a call to `delay_span_bug`, instead of `span_bug`. This will result in an ICE, but only if the error isn't already reported elsewhere.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 594](http://build.prxm.it:8811/viewLog.html?buildId=3944&buildTypeId=Jarvis_DocumentStore_CI) is now running


@ChrisDenham Yes, this looks very odd. I am guessing that the driver assigns the texture handles in numerical order and since no other processes are spawning texture this code work by pure luck. It should probably be changed according to your suggestion. Would you mind making the change, test it and if it is working, send a pull request?


Oh yeah my my... :D

Thx you.


Is there a method in `utils/EndianSwap.h` that you could use instead?


`nullptr` instead of `NULL`.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 594](http://build.prxm.it:8811/viewLog.html?buildId=3944&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Compilation error: src\Jarvis.DocumentStore.Tests\Jarvis.DocumentStore.Tests.csproj Build time: 00:01:51


Yay! Fin!


I don't think, i love the bricked one.


It looks like its the same path as used in the linux variant. Perhaps just add the build tag to a common file for both linux and darwin?


No need for an assert in a temporary code like this. Let it stay as it is


Ok, thanks


Why not extension method?


It is. I don't know why github shows it like that...
![aligned with others](https://cloud.githubusercontent.com/assets/812037/9683369/ccd168aa-530f-11e5-9969-a8f9cda4f0fa.png)


Sorry for all the feedback. This is the final feedback. After comparing your code to Bloc's code, we actually want to do this *within* the DataSource constructor that starts on line 19, rather than after it. Keep the code as is, but move it up so it runs _within_ the constructor for DataSource. Let me know if that fixes your problem.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 595](http://build.prxm.it:8811/viewLog.html?buildId=3946&buildTypeId=Jarvis_DocumentStore_CI) is now running


Changed to lock


"is not an executable file" sounds better IMHO


true


у нас есть отдельные файлы, где прописываются зависимости. Это общая информация по БЭМ. К моменту сборки человек уже написал кучу файлов с зависимостями


Well, I guess this is just me being lazy. I'm not sure which is the appropriate basepath for this on darwin. We can leave it as is for now, unless you have some other idea? The /usr/share folder exists on darwin by default, but autograder folder must be created.


You can always update a pull request with a rebase or simply by adding a commit to the HEAD ;)


Should the app name be constant between all different instances? This means the name will be Autograder globally even tho its for UIS, UIA or similar. Could be customizable through config file or we could add a new line for location specific app name.


Per our style guide, this `7 years` should be `seven years'` :)


> Do you think that is should be kept for every run (becoming bigger) like done now (using future rkt image gc features), or it'll be better to create a temporary store for every run?

Ok, Looks like a persistent store is needed for `render` since it needs the images to be already available in the store.


I think we should validate this in HasLinks->add_links, not here. Here we should just validate the existence of the required links(like "self", "related", etc...).


hej hej


Needs to be checked if there is a value there, or else the name will be changed to noname when the user have no change of this name. Could also be a part of the config file.


This is the system/application name. This should be independent of the university deploying it. We could perhaps add a university logo or something somewhere, but I don't think we should use UIS or UIA etc in the branding.


I like PEP8, so I suggest we all use it :) I've become a little sloppy lately...


Thx!


Verdad. Si alguien acaba liado instalando lo mejor es eso.


`1` should be `one`


The package `enum` is incompatible with python 2.x, which is going to be important for quite some time still.
I would strongly recommend not using it.


Thanks to @PEMapModder!


Hey Craig, yes agreed, but somehow that didn't work for me, maybe it was just a temporary issue :)


:+1: :


Hello Mohamed,
Could send me each step to reproduce your bug in odoo 8.0 on runbot?
http://runbot.odoo.com/runbot


@fiedl you might want to have a look at the implementation I just comitted, as it does not depend on the order of the attachments. It uses the actual content_id.


Here the value of input becomes color of svg rectangle.


1579840-GroundTemps (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1817 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.13%25-yellow.svg)


um... why


Ups. This is a bug. It should be "versionsys", "GitHub" on line 26.


1579840-GroundTemps (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (771 of 771 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-10.63%25-green.svg)


Ok, then we can keep it as a constant. I have some thoughts about getting more control though admin panel, so a upload of logo can perhaps be done there.


Whoopsie. Have read about that so often now that confusion is at its peak ^^


because it's a block


After taking another look at this, I think it would be better like this:

https://gist.github.com/chriscool/94ef32392f6c2a4bd7d7


@alhashash  I can't find any definition for i_line.move_id - as I can understand the original code:
i_line = invoice.line object which doesn't have any move_id field by itself .
also there's no i_line.move_id defined in the anglo-saxon module nor in any other place.

I tried the original code without the if statement to ensure it's correct and I got errors that invoice.line have no field move_id - so this move_id will make if statement always false and unit price will always be standard price defined on the product without taking care of sale unit .


Ups, vale lo cambiaré y te cuento


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 595](http://build.prxm.it:8811/viewLog.html?buildId=3946&buildTypeId=Jarvis_DocumentStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 261 Build time: 00:11:06


This is a comment just for test.


nullptr


This patch worked for me on Windows 10.
@gitlie Find the file on your machine (../Cmder/vendor/profile.ps1) and add the code highlighted in green.


Also needs work.


I test all my changes on 3.4.3 and 2.7.10 so I am assuming they backported it to 2.7 at some point.


Espera que me parta el culo de risa (ironía)


I think this should be `--exclude docs/ --exclude sandbox/ --exclude release/`


`ImmutableList.copyOf()` since ImmutableList does not support null


i have an exception after updating:
![bildschirmfoto 2015-09-04 um 14 34 29](https://cloud.githubusercontent.com/assets/995707/9683625/1fc0061e-5312-11e5-9fdd-0359f560a77b.png)

ping @rande


Nothing to preview
Nothing to preview


Ah nvm I see you caught this in the next commit


@bjornblissing It doesn't seem to break anything if I make the change. I'm in the middle of trying to get the MSAA stuff working at the moment, so I may include it in that pull request if I can make it work.


muss nicht global sein, oder? `@color_count` -> `color_count`

das gleiche auch für `@keyword_hash`


get it!


I found something interesting in specification("document structure" section):

Unless otherwise noted, objects defined by this specification MUST NOT contain any additional members. Client
and server implementations MUST ignore members not recognized by this specification.

.....

The top-level links object MAY contain the following members:

self: the link that generated the current response document.
related: a related resource link when the primary data represents a resource relationship.
pagination links for the primary data.

From these 2 paragraphs I understand that we should check that we have only "self" or "related" in "links". All the other links should be dropped/ignored.


This should be EDITORIAL_STAFF


This is actually *more* broken now. You have an extra `; i = 0`, which causes your `for` loop to have **4** expressions instead of three.


:+1:  less is more :)


This should use doxygen format. There are also typos here.


:+1:  I forgot to import the code. BTW, how do you put those doc files on github so easily?


* Shifted the regex matching outcomes out of the async.parallel as @Deborah-Digges suggested.
* Function prototypes of `singleRegexMatch` and `multipleRegexMatch` had to be changed for this outcome.


The field 'move_id' is defined in "account.invoice.line" model in the file you 've just modified:
[account_anglo_saxon/invoice.py#L31](https://github.com/mohamedhagag/odoo/blob/7c425635d8a3d8e3d63d297cd9bec04bb85fbece/addons/account_anglo_saxon/invoice.py#L31)


What's the reason for removing old-version download links? Are the download links somewhere else too?


Anong tinype sir?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20096/testReport/) for this commit**


You mean the PocketMine docs? I used Doxygen.


* Shifted tag indexes json file creation to when the process exits.
* Realised that when many files are being parsed, the original method would lead to some updates on the tag indexes to be left out before putting them in a file.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.954.8cb85eb099577e08344e05deab82c6bb9957da09](http://build.palaso.org/viewLog.html?buildId=62684&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 502, ignored: 6 Build time: 00:04:17


I wonder if we could do this:

```
# @param {Object} opts
# @param {Object} opts.docpad - The docpad instance that we are loading plugins for
# @param {String} opts.dirPath - The directory path of the plugin
# @param {Object} opts.BasePlugin - The base plugin class
```


It' s really strange... It' s a service, in permissive mode should be executed like all the others... Others services are correctly executed in your kernel? Some error regarding dancing led start in logs?
PS: Have you tried to delete the out/intermediates files to see if some change has not correctly picked during the build process?
@AntaresOne: You are the genius that create this... Any ideas about what could be? :-)


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 596](http://build.prxm.it:8811/viewLog.html?buildId=3947&buildTypeId=Jarvis_DocumentStore_CI) is now running


If you find a piece of code that triggers this problem I can take a quick look and see if there is some cases that MSPSim is not handling correct (assuming that the test code actually works on hardware also).


Yes, there's a detailed Download page in the User Guide for each release.  The UG landing page has an obvious link to it.  So this seems cleaner -- you agree?


Branch and PR so we can squash.


sicuro di aver ignorato tutto?


Hmm looks like one of the `python2` packages on my machine installed `enum34` as a dependency. I do not like adding dependencies, but it looks like the package can be installed through `pip`. Let me look into alternatives.


@peckomingo Musste die CSS Klasse von 'user' in 'initiator' umbenennen. Selbes Problem wie hier: https://github.com/klappradla/im_graetzl/issues/46
Hab aber im Markup schon alles entsprechend angepasst, sollte keine Probleme geben.


Je ne comprends pas trop l'intérêt de créer des threads si ils ne peuvent pas vraiment s'exécuter en même temps, en parallèle.


Fair enough. I like having the links for all versions on one page, but it'll be an ongoing maintenance hassle and you are right that it's obvious to find the downloads via the version link.


我用的是 10.11，一切正常。没测试过 10.10.4 下面的情况。


@cehallen DWMR. Press on.


remove from header as well


Great!!! That is good!
This works :)
Thank! Thank much!
Now all good is and Danation can pull and deliver :)


ur gay zach


feedback applied, with a comment and test to explain why it is used.


@cehallen DWMR. This is good. Keep it up!


I have found segfault which is fixed by this patch.
https://fedorahosted.org/openscap/ticket/504


Also, `add` is a function, so no space before `(`.


@cehallen DWMR. 11 checkpoints done. Nice.


Yeah, just ran into this too. I'll make a pr.


@simongoffin I'm not sure how to send them on runbot, but here's the steps:
1- create new empty DB
2- install accounting, WH, Sales, Purch
3- install US CoA or any CoA with anglo-saxon
4- create a stockable product and set its cost, sale prices plus UoM in Ton and UoS to Kg - income account to sales and expense account to "Purchases - resale items"
5- setup realtime stock valuation for that product category to:
--- input account: stock input > current assets
--- out account: stock out > current assets
--- stk vaulation: Current inventory > current assets

make a purchase order of the product in any unit and the stock entries are OK
make a sale order in a unit different than the one defined on the product and you will get stock entries wrong values - for example if the product unit is Ton and you made a sale in Kg then the expected entry on stock out and current inventory accounts to be cost price of a Kg but you it will be cost of a Ton which is 1000x than the real one.

please have a look at below images for example or check this thread on the mailing list
https://www.odoo.com/groups/community-59/community-13743387

before fix - the stock out item and purchase (CoGS) accounts cr/dr are in Tons
![Before Fix](https://cloud.githubusercontent.com/assets/1042088/9683925/9975c9a6-5314-11e5-96c9-d8fc8d3d1f7c.png)

After the fix - we can see the difference:
![After Fix](https://cloud.githubusercontent.com/assets/1042088/9683859/166e9cb8-5314-11e5-93df-46fedd2cd1cb.png)


There's  an `if` missing.


Implemented in https://github.com/mloccy/freeablo/commit/5da4d6bacb76925caf4e22001ccf7c69f73b6f21


Sure, updated. Maybe *magic* should complain about it ?


86139842-AddAutoSizing (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1787 of 1818 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.29%25-yellow.svg)


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 597](http://build.prxm.it:8811/viewLog.html?buildId=3948&buildTypeId=Jarvis_DocumentStore_CI) is now running


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 596](http://build.prxm.it:8811/viewLog.html?buildId=3947&buildTypeId=Jarvis_DocumentStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 287 Build time: 00:11:54


What is this?


sorry where?


Le jar est de la partie d'avant, car le passage à ce commit a fait planter la partie IA.


Might as well make this whole chunk into its own function, since it's likely going to get used elsewhere too.


You can check out [my branch](https://github.com/LoveMondays/heaven/tree/capistrano3) if it helps.


All functions in this file operate without nREPL requests, by resolving things from the cache information.
I'll clarify that distinction in the docstring.


I think you might also want to test that a oveloaded method is not part of the identifiers

```
public class SpecialJobRepositoryImpl extends JobRepositoryImpl {
   ...
   void createJob(String id);
}
```


This is generating a huge number of warnings in the Crowbar code, and I also happen to disagree with it.  If you want it to become universally adopted within SUSE, please can you add the rationale?


> Server generation was disabled because new resource was generated every connection.
That's usually considered a feature. :) You make it sound like an issue. Why?

> Later I will implement saving of first time generated resource and enable server generation.
Having a fixed resource (once dynamically created or not) leads to problems with servers deploying a `resource-conflict` policy (instead of "terminate last session").


That method name sounds a bit clumsy to me, maybe just call it `check_repositories`?


@ChrisDenham Well, since it such a tiny change and you have tested it. I can do the change remote via the GitHub web interface.


You announce ``%u```  but don't reference the var to log out.


I wonder where this code went, I can't find a reference anymore to `Arrays.toString( parameterTypes )`


File an issue, but not something we should prioritize at this point.


@elbrujohalcon :+1:


@simongoffin yes - my fault - I didn't find this field definition - so the original code should work fine in case of invoicing a stock move.
and my code will work if we invoice a sales order.
so the else clause should have my code in case that we are invoicing a SO .
and maybe another else clause with standard_price for any other case.


A good thing about jumbo.c is we don't clobber a core file. Also (perhaps not very important in this case but very important in *2john tools) jumbo.h does not need anything other than jumbo.o whereas common.h is often unusable because it means dependencies of a boatload of .o files.


this non-breaking change is to allow the DynamoDB Storage Backend for Titan to no longer need to copy over and override an entire test method.
https://github.com/awslabs/dynamodb-titan-storage-backend/blob/0.5.4/src/test/java/com/amazon/titan/graphdb/dynamodb/SingleDynamoDBGraphTest.java#L81


The check is about repositories in general, right? So `valid` repositories is a bit misleading maybe.


Thanks, that's what I thought too. I think I'll add a note to the Readme how to preserve cap2 support.


Since we're disabling it at startup, should `android:enabled="false"` be added to the receiver in the manifest?


make this configurable


I was in a bit of a hurry when I wrote this. Now I think this is not the best place for the `save-match-data`.
I should either be inside `clojure-find-ns`, or it should be used by the function that actually needs to preserve the match data.


ok. but normally you should know which flags you set.


I should tell you Brazilians are immune to jedi mind tricks. ;-)


Holy crap...


adasdasdasdwwdwa


ah sorry

```CLog::Log(LOGDEBUG, "CALSAHControlMonitor - Monitored ALSA hctl value changed with mask value of %u", mask);```

updating patch and recompiling to provide log.


s/eneter/enter


That's a bit too detailed for end users imo. What's relevant to them is that they can now autoyast-export descriptions of systems that have no repositories configured.


get this from the config


if property `otherCloseables` is actually a List, then this borderline usage won't be as visible but behavior won't be explicite


make this


:+1: that looks great :)


@fermino Probably. :P


dry


fix


if this is not actually needed, simply remove/null it out


@mohamedhagag, line.move_id will be set only if you generated the invoice based on delivery. In your example, the invoice is generated form the sale order which is covered in the `else` part of the `if` statement you mentioned. This is the other bug I mentioned in my comment above, you need to convert price unit from the product unit to the invoice unit.

BTW, What do you mean by "UoS" in step 4 of the scenario, is it the product default unit of measure (defined in the information tab in the product view) or you activated the dual unit of measure option (the option titled "Store products in a different unit of measure than the sales order" in the Warehouse settings)?


Please move this under `Know Issues/Road map` section


Please provide the logs to @anssih - as said before, it is only hacking
arround an issue, that might have a different source.
Am 04.09.2015 4:02 nachm. schrieb "uNiversaI" <notifications@github.com>:

> ah sorry
>
> CLog::Log(LOGDEBUG, "CALSAHControlMonitor - Monitored ALSA hctl value
> changed with mask value of %u", mask);
>
> updating patch and recompiling to provide log.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/uNiversaI/kodi/commit/f7bf4743a650e53e0e174c6324c5153a05a9b8fe#commitcomment-13068867>
> .
>


mettici i commenti


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 597](http://build.prxm.it:8811/viewLog.html?buildId=3948&buildTypeId=Jarvis_DocumentStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 289 Build time: 00:12:03


If you use this in only one place, might as well just use the list comprehension directly


Here #533 people have problems with OTR. But I think, the problem might be in no multi session support #249
And [here](http://wiki.xmpp.org/web/XMPP_IM_Client_Design_Guidelines#Do_not_to_encode_any_semantics_into_the_resource.2C_let_the_server_generate_a_resource_for_you)  (by your recomentation) is written:
> Store the resource you obtained from the server on the first connection, and re-use that on later connections. That way, a properly-configured server will close your old session if it still was deemed active by it.
Or it means, that server will generate new resource anyway, but will look for old session by previously stored resource?


This isn't executed immediately when setting new custom CSS, right? (Maybe it should, otherwise somebody is up for a very slow first request.)


@ntrncic , Yes and it works! :) try it out and let me know if you run into any problems (you shouldn't).


Yeah, it should, but I think it's a little too hard right now, since magic has no actual parser.


No need for triple quote plus it has an extra space at end of string


This is really a separate issue, but wanted to mention it: it seems a shame to reset the suggestion table here since this feature is so rarely used, perhaps `SuggestionTable` could reset itself the first time it's accessed instead?


Could use a comment here explaining the purpose of  `deferredInit` and why it was deemed necessary.


Use full version '8.0.1.0'


Add `OCA (Odoo Community Association)` in authors


It seems the current behaviour is correct, so additional tests is not necessary.


@alhashash by UoS - I mean the unit defined on the product in the sale tab - or the unit on the sale order line of the product.


dunno why it write tag here


Is the date correct?


We don't need extra tab for history if we make Overview's transactions expandable


@BRoddeck, commitest du etwa schon wieder JavaScript? ;)


Assets are compiled on-demand, so yes, someone will have a very slow first request :P It's just easier this way, and not that big of a deal.


86139842-AddAutoSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1793 of 1824 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.3%25-yellow.svg)


@geekgonecrazy - why do we have multiple copies of same files for android and ios? Cannot we have one file for all and let cordova/build compile it for each platform?


You can remove the last line from the comments.


![screen shot 2015-09-04 at 14 11 56](https://cloud.githubusercontent.com/assets/319055/9684375/0579c46e-530f-11e5-86f1-f73ad97752a6.png)
![screen shot 2015-09-04 at 14 12 07](https://cloud.githubusercontent.com/assets/319055/9684376/057b6152-530f-11e5-9663-3fa3d64c6028.png)


`/* can i addz feet plz?*/`


Right Im compiling with only the mask logging entry and not the if (mask != (SND_CTL_EVENT_MASK_VALUE | SND_CTL_EVENT_MASK_INFO))


deploy /d/ivanbabaiev.fortytwotesttask-200
http://fortytwotesttask-200.ivanbabaiev.at.getbarista.com
https://github.com/ivanbabaiev/FortyTwoTestTask


Type in the name of the oil.


This help is not helpful :smile:


This probably needs exclusive locking to avoid races.


This is due to our tinkering with `width: 100%`. Will need to sit down and work through it properly


OK, I see what you mean. It was quite obvious indeed.


@OskarStark just revert the PR for now. @core23 can you rework the original PR ? Thanks


I have now picked your changes in pbatard/rufus@387b1fbce7036fa7e54bf00c7070d9986e1397f0 - thank you very much!

I had to modify a few things as MinGW and WDK produced an error when trying to use `_wdupenv_s`, so I used `_wgetenv_s` instead.


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1816 of 1817 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


probably needs file locking to avoid races


comentario


fix_zone_hvac_objects (mbadams5) - Win64-Windows-7-VisualStudio-12: OK (2318 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.19%25-yellow.svg)


You can remove the `+` at end of line
In python this concatenate the strings already:

    ('start of string '
     'end of string')


86139842-AddAutoSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@htgoebel it might be related but my motivation was that modulegraph supports more bad module types so I wanted to take advantage of it.