Strange.  Any chance I'm seeing a windows specific issue?  How did you test?

On 22 September 2015 at 18:45, Ruslan Prokopchuk <notifications@github.com>
wrote:

> Okay, I just tested against c86fc8a of WR and see that CLJS version in
> ampere doesn't influence to WR build. But I also have successful build with
> 1.7.28, 1.7.48, 1.7.122 in WR's project.clj. May be it was weird caching
> issue? Try again with lein clean or even manual deletion of target and
> generated js.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/condense/ampere/commit/e7d96f159e2c1276026f073834b3a3f795743150#commitcomment-13361496>
> .
>


This is wonderful


``No tablespace handler for URI scheme '%s'`` is right one. ``No tablespace`` is my mistake. Will ``'%s'``  contain uri or scheme?


Is `$optimalCpu` an array?


@balajikris did it broke Close side?


2nd time I've come across this in 2 different projects.  Glad there is a fix and looking forward to it being in master.


Well, we use the `%` formatting everywhere, so I thought staying consistent is the better way (even though I like the `.format` function better as well).


highly unfortunate that methods of `LoadedTemplateDao` do not use the same session has the one opened in `DisplayLogOnDeprecatedProjects`


so it returns either an empty array or a boolean value? seems like sth didn't go according to plan ;)


Some quick feedback on your first outing into Coffeescript ;)

We prefer single qoutes (`'`) over double qoutes. Only use double quotes (`"`) when using String Interpolation.


@cblichmann Ok


Merge #28 1.2.0.7


```'%s'``` should be scheme, I think.


No. On shutdown you want to flush no matter what. So we cannot change `forceCheckPoint` to be `tryCheckPoint`.


Unnecessary change


what if a tag is added and then a different one removed? this will still return false :/


Sure. But how about adding a `data-renderer` attribute? Are there any other relevant attributes we may want to use?


Good use of the `and` alias


ok


Instead of using `==` and `||`, consider using the aliases `is` and `or`

`if landing.get_internet_explorer_version() is 9 or landing.get_internet_explorer_version() is 10`


so, if I get it right, you are using a template as a flag stored in DB to know if the message has already been displayed or not, right?

weird... but seems to work


you could use direct assignment, `commit.tag_list = "tag1, tag2, tag3"` should work

check the documentation: https://github.com/mbleigh/acts-as-taggable-on


If you get a TooBigToSpellError you're screwed anyways and the only reasonable thing you can do is fallback to unspelled numbers or error out completely.


Smart Analysis load dynamic libraries which analyze CL downsclaed image and send back the analyze results.


> (like if we do not use SSL, then it may not be needed to validate the ```handshakeTimeout``` at all)

Checked that, and this comment is wrong, as the ```handshakeTimeout``` is not related to SSL, but rather to AMQP


Hey! What if there's an even number of posts?


"Comfortable Runabout Vehicle" hahahha

https://www.google.com.ph/search?q=honda+crv+what+is+crv&oq=honda+crv+what+is+crv&aqs=chrome..69i57.5061j0j1&sourceid=chrome&es_sm=91&ie=UTF-8#q=what+does+crv+stand+for


What language you are speaking on?


@AnriShitko


@YannRobert I see your point. Explicit validation won't work. Time will tell if having the kind of validation we have right now is worth it. We don't mind reverting things that don't work out in bug fix releases.


Good Style, but where are the tests?


imo there should be an ITranscoder and a CFFmpegTranscoder.


:dolphin:


no worries - thanks for looking


Open/close/unlock (as appropriate) doors, loot chests, pickup containable items (keys).


`INSTALL.ja`を配置したのと、あまり`SUBLEVEL`を増やすのもなんなので、`yasuna-7.3.0`へ修正。


I'm flipping you the :bird: !


You may have some items in a dropdown that you want to hide (as example: some obsolete items), but you want to keep them for historical reasons.


Thanks, I was struggling to think of a good name for this one =)


Ya I guess... saw something similar here as well:
https://github.com/leungmanhin/atomspace/blob/master/opencog/query/Implicator.cc#L117-L120


I checked out mentioned revision of WR, and tried to do subsequent `lein do
clean, cljsbuild once` for ampere with different versions of cljs. After
that I've repeated building process while changing cljs versions in WR. All
builds were successful. Couldn't test with Windows at the moment, but a
little bit later I will check, may be it is really Windows-specific error
(may be one which is fixed here
https://github.com/clojure/clojurescript/releases/tag/r1.7.58 ???)

вт, 22 сент. 2015 г. в 12:09, Oliver George <notifications@github.com>:

> Strange. Any chance I'm seeing a windows specific issue? How did you test?
>
> On 22 September 2015 at 18:45, Ruslan Prokopchuk <notifications@github.com
> >
> wrote:
>
> > Okay, I just tested against c86fc8a of WR and see that CLJS version in
> > ampere doesn't influence to WR build. But I also have successful build
> with
> > 1.7.28, 1.7.48, 1.7.122 in WR's project.clj. May be it was weird caching
> > issue? Try again with lein clean or even manual deletion of target and
> > generated js.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/condense/ampere/commit/e7d96f159e2c1276026f073834b3a3f795743150#commitcomment-13361496
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/condense/ampere/commit/e7d96f159e2c1276026f073834b3a3f795743150#commitcomment-13362031>
> .
>


Replace the file in `assets/files/test.pdf` with the PDF you want the link to go to.


Replace this example with the logos and links you want to use.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21026/testReport/) for this commit**


It's also a way to hide the parents in a hierarchical list


As in, a separate class?


<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

	<meta http-equiv="content-type" content="text/html; charset=utf-8">
	<meta name="description" content="Finike City">
	<meta name="keywords" content="Everything about Finike">
	<meta name="author" content="Mehmet Emin Yildiz">
	<title>Finike City</title>
	<link rel="shortcut icon" href="img/finike.ico">
	<link rel="stylesheet" href="style.css" type="text/css" media="screen">
	<link rel="stylesheet" href="print.css" type="text/css" media="print">

			Finike

Home

Finike's Mayor

History

Economy

Photos

Videos

Contact

			Weather

			Social Media

			Bookmark Bar

District Governorship

Municipality

Pharmacies

Finike's Hospital

Akdeniz University Finike Vocational School

Finike Police Office

				Finike

				About Finike

			Finike, the ancient Phoenicus, is a district on the Mediterranean coast of Antalya Province in Turkey,
			to the west of the city of Antalya, along the Turkish Riviera. It is located on the southern shore of the Teke peninsula,
			and the coast here is a popular tourist destination. However, Finike is best known for its oranges, the symbol of the town.

			The local economy depends on agriculture, particularly oranges and other citrus fruits.
			This is supplemented by income from tourism in the summertime,
			although because of the lucrative orange production and the distance from Antalya Finike has not seen the large-scale tourism boom that has so radically changed the other coastal districts of Antalya.
			Finike is a quiet district where people buzz around on mopeds going about their daily lives.
			Indeed many of the visitors that Finike does attract are retired people in search of relaxation. That's mostly because of the construction policy of 1980.
			That policy made the land more suitable for investment in agriculture rather than in hotels, luxury apartments and other tourist attractions.

			A type of pale limestone is quarried at Limyra, and sold as a decorative building material.
			It's cream colored with a homogeneous structure.
			Moreover it's extremely light and that makes it a perfect for building walking alleys and streets where only light vehicles are passing.
			The geologist classify the Limura limestone as with medium density.

			The port of Finike is now a yacht marina, and has a small fishing fleet. The coast is rich in marine life, including sea turtles,
			and fish, including local specialities red porgy Sparidae and grouper;
			other fish found along the coast include leerfish (Carangidae) and the more widespread Mediterranean varieties such as bluefish,
			sea bream, sea bass, with swordfish, sardines and others found further out to sea. However, the coast suffers from overfishing,
			and many varieties, including the porgy, are in decline.

			The beaches of Finike are an important nesting ground for Caretta caretta sea turtles,
			and the rocky parts of the coast are used by the rare Mediterranean Monk Seal.

				Places of interest

The ruins of Limyra are to be seen three miles east of the Finike, they consist of a theatre, tombs, Sarcophagi, bas-reliefs, Greek and Lycian inscriptions, etc.

The ancient city of Arycanda, in a narrow valley off the road to Elmali.

The ruins of Trysa with a carved frieze depicting Theseus, on the road to Kas.

The small village of Turuncova, hidden in a small valley of Taurus Mountains, has preserved its traditional lifestyle and culture.

The cave of Suluin.

Wreck of a Phoenician merchant ship from about 1200 BC in Cape Gelidonya

This site preparing for given more information about Finike City in English.

		This site created by Mehmet Emin Yildiz for Karabuk university Stage Project 2015 - Copyright ©


How about using only part of the string: e.g. RTL-8100/8101L/8139?
This would eventually cover additional string which might differ in the rest of the string.


Same as above: "Intel Corporation PRO/100"


why don't you use bold


Could we pass the lock as  ```Lock &``` instead of using a pointer? This also applies to the member variable.

In general, if we have a variable or a member that is not expected to be a null pointer, we should better use a reference (which cannot be null by definition) to document this assumption.

BTW, now I remember that I wanted to make the same remark on the new object-pool interface but I somehow missed it. When invoking a lambda function, it would be sensible to pass a reference to the lambda, not a pointer. So the lambda function knows that it deals with a valid object. Right now, save programming practices would mandate a null-pointer check at the beginning of the lambda function.


Add the image to `assets/images` and then reference it with `image_tag('whatever_the_filename_is.png')`


Make the function return a value instead of printing inside the function


this should be end = size - 1;


What would be the advantage of that? I figured an immutable map that can be accessed from anywhere would be useful (since you can take advantage of other Map methods, like, eg. containsKey() )


Should be handled by https://github.com/JuliaLang/Compat.jl/commit/cbdebe3fbe6252a0cf8e9611ae0d4a85aded2652. Is your Compat dirty and therefore really old?


Do we still need this?


Also add success case. For eg find(3,arr,10);
Also add more cases like arr1[]={1}; // 1 element in the array


Just a subsidiary question to make it completely clear to me: before any change on BaseBagging, I don't understand how `max_samples` (which was also defined above in fit(), in function of `self.max_samples` and its type) was used, since this line didn't exist?


Looks like $attachments should be an array, could it be type hinted as one too please?


Same here too.


read http://googleresearch.blogspot.in/2006/06/extra-extra-read-all-about-it-nearly.html


表示する場合分け、パターンをすべて挙げて欲しい
yes/no の分岐のつながりでいいので


Well, we already had `openshift_uri` in `self.spec` and `url` everywhere in the plugins, so I tried to stay consistent with that (perhaps not a good idea, I know; I'll fix this to use url for everything else than `openshift_uri`)


ffuming.com


> The race is still there, but you have reduced the window of opportunity. To remove the race altogether, it needs to be part of the same transaction.

I thought this will work, but that does make sense. It still reduces the window considerably.
It makes sense to me if we can only set resolved in case the unit is in error, to clear resolved when it comes out of error.

> Do we need ClearResolved at all then?

First thought would be that no, not really, but I'd have to go through the usecases


break いらない（以下）


Should `hostSynonyms` not better be unmodifiable?
```
hostSynonyms = Collections.unmodifiableList(Arrays.asList(synonyms.split(",")));
```


I want players to be able to interact() with items they're standing next to (not just on top of), so need some way of determining which locations the player is adjacent to.


Use `== null`. It is highly optimized and idiomatic way to check for `null` or `undefined`.


Hmm, OTOH we use "uri" in tons of other places, so maybe that may be a better way to go. I'm kind of torn right now, I'll think about this some more.


I don't really know why this hook has been deleted, but I checked in setup.php on my current version and it's not there, there is only the pre_item_update and the pre_item_purge.


Regarding the object pool: I've used a pointer there including zero pointers to obtain merely a compatible interface. Some of the calling contexts e.g.: have thrown an exception when no object was found. On the other hand the calling context specific return value can be used with the current scheme, so there was no room to indicate that the object pool search was not successful by using a corresponding return value.

Regarding the above lock pointer, of course I can change it to a reference. I just copied it over from the original implementation with preferably less modifications.


Oh, the previous comment should have been here, amber-cli.js is generated.


Ok, so I'll make the whole `else` clause a special exception just for pulp plugin.


Is there a reason for an extra build.sh here? I was about to delete but I thought I'd ask.


Thanks for a pull request @jskvara , but this repo is used only for hosting. Source file that should be modified is located here https://github.com/GDG-Ukraine/hoverboard/blob/master/app/data/sessions.json


@Michael-Lotus this makes me wonder maybe actor should be an item.


I really enjoyed this J. I did in fact pause a moment lol to reflect on my misguided self.
I like your entry b/c it is a personal reflection but still makes reference to the more technical aspects of
this experience.  I really like your positive attitude going forward!


@renecannao how did you choose the new size?


Ok, sorry. I didn't know. I will create a new PR


Given that `hostSynonyms.contains` will be called quite often, having `hostSynonyms` as a `Set` would result in a better performance.


It's already a separate class. Move it to a separate java file.


cool! didn't notice this ...man it's been too ong since I made anything cool with + for sverchok :/


Denna fix kräver att kurskategorier raderas och att det efter radering av kurskategorier görs en ny manuell import av kurslistan. @TheresePersson


Oh, I see... updating presently...


What I meant to use here are Fieldlists http://docutils.sourceforge.net/docs/user/rst/quickref.html#field-lists


Indeed i'm not suggesting an optimization - yet I'd keep `scryRenderedDOMComponentsWithClass` working with multiple classes. Better said, what is `className` the function is referring to? The value of the `className` attribute as in React <=0.13 or a single css class as in the rc1?


@kmike Typo


Absolutely right; this is another oversight of mine :)


Whoops, personal style preference slipped in there. Will change this in the separate commit.


Slight niggle -- I think the parameter order here should be `channel_id, message_id, event_url` to make it match the ordering in `load_event_url`.


Will change this.


其實我不喜歡用"//"欸, 因為fb og image會拿不到這個網站 他會噴error給你看


Can we get this new version pushed up to Rubygems? :smile:

```sh
$ gem list -r elastomer-client

*** REMOTE GEMS ***

elastomer-client (0.6.0)
```


Hi @ldoktor
Why need to go outside the for loop? we need to add the disable_legacy and disable_modern options for all of virtio devices.


This deny everything, as space means `&&`.


OK, I will check it.


Better create a PR than just a line comment.


Comma, you mean?


Does this really help? We still have the same stacktrace limit with this, so this will just shorten the trace. I think we should just drop the reraising all together.


The map is an implementation detail. As for what _might_ be useful: [YAGNI].

Also, this approach duplicates the association between chars and terrain types (the constructor already knows the char for an enum value).

[YAGNI]: https://en.wikipedia.org/wiki/YAGNI


Nevermind this commit, changed later to be in order of appearance.


102867486-FixRectangleShapeTest-5173 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (807 of 807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.54%25-green.svg)


As a trivial example using the above stab:

    #include "stlab/future.hpp"
    #include <iostream>
    #include <thread>
    auto schedule = [](auto f) // F is void() and movable
    {
        std::thread(std::move(f)).detach();
    };

    // trivial transform double -> double
    double x2(double x) { return 2*x; }
    double p1(double x) { return x+1; }

    int main() {
       auto r1 = stlab::async( schedule, x2, 3 );
       auto r2 = r1.then( schedule, p1 );
       auto f = r2.get_try();
       if (f) std::cout << *f << std::endl;
       else   std::cout << "no f???" << std::endl;
    }

which produces the printout '7' as expected. Now we just need to scale this example by a few orders of magnitude in both scale and complexity, and we're done ;-)
Note how the .then serves as a way to automatically 'route' the output of 'x2' into the input of 'p1'.... Byebye TES. But of course you could also insert a transform that does nothing but write its input into the TES, and then returns it for the next in-line to process it... and you can imagine the 'head' of this chain to pick up something from the TES and inject it into the flow...


Heh, yeah, just saw them. Updated to meet requirements with ||


Hey, thanks, capstone rocks! capstone is already included in requirements.txt, that part with manually install is for users who do not have cmake (on windows), so they have to install capstone-windows but I will clarify things out.


You're missing an `end` here.


json-path bauch man momentan glaub ich net


用中文吧，这么写是有问题的吧。。。
如果我是一个段落的话，2-5 行距是 1，6-7 是右对齐，那么就会导致 6-7 出现行距为 1 的情况


This name is crap!


I see. Will change that. Thanks.


This needs to be updated, maybe AuthorEditorListener


Done


@Arthur2e5 @MingcongBai

Could you help me to fetch the latest translation files and remove the "fucked-up" Inkscape translation file? I seldom have free time to do it.


You do *not* want cascade=remove here


You do not want cascade=remove here


But wait, what would set this environment variable?

`SOURCE_SECRET_PATH` is special, set by OpenShift from the `sourceSecret` value in the Build.
https://github.com/openshift/origin/blob/7542a7223371f0d5aabd99b110cfe3464bab4aac/pkg/build/controller/strategy/util.go#L128

I think we want the `pdc_secret_path` keyword to be the only way that path is specified.


Documentation for `EventPlot`, `ILinePlot` and `ILinePlotGen` is not generated because it can't find the IPython Profile.  I've said it before and I'll say it again: we should only call IPythonConf.iplot_install() if we're actually going to plot.  Maybe we should move the invocations to the `view()` method of `EventPlot` and `ILinePlot`?

    /tmp/home/trappy/doc/api_reference/trappy.plotter.EventPlot.rst:4: WARNING: autodoc: failed to import module u'trappy.plotter.EventPlot'; the following exception was raised:
    Traceback (most recent call last):
      File "/usr/lib/python2.7/dist-packages/sphinx/ext/autodoc.py", line 385, in import_object
        __import__(self.modname)
      File "/tmp/home/trappy/doc/api_reference/../../trappy/plotter/EventPlot.py", line 40, in <module>
        IPythonConf.iplot_install("EventPlot")
      File "/tmp/home/trappy/doc/api_reference/../../trappy/plotter/IPythonConf.py", line 112, in iplot_install
        get_scripts_path(),
      File "/tmp/home/trappy/doc/api_reference/../../trappy/plotter/IPythonConf.py", line 199, in get_scripts_path
        dir_name = os.path.join(get_ipython_dir(profile), PLOTTER_SCRIPTS)
      File "/tmp/home/trappy/doc/api_reference/../../trappy/plotter/IPythonConf.py", line 172, in get_ipython_dir
        profile = get_profile_name()
      File "/tmp/home/trappy/doc/api_reference/../../trappy/plotter/IPythonConf.py", line 149, in get_profile_name
        raise ImportError("Cannot Find IPython Profile")
    ImportError: Cannot Find IPython Profile


UserdataEntity норм?


SUpermodif


That's a lot of refactoring :P


Ok, but don't you just click on the cell to interact with it? The user already knows which cells are adjacent because they can see them rendered on the screen.


A typical use of `recall` is to prove anti-aliasing, but it's more general than that. It is assumed in st.ft:
```F#
assume val recall: #a:Type -> r:ref a -> STATE unit
                                         (fun 'p h -> Heap.contains h r ==> 'p () h)
                                         (fun 'p h -> Heap.contains h r ==> 'p () h)
```
Its weakest-precondition transformer can be read as "if you are given a reference, then you know it is in the heap". This is assumed to be sound because `ST.alloc` is the only way of obtaining a reference, and its post-condition asserts that the resulted heap contains the reference.

Having a look at the specification of `ST.alloc`, you can see why it can prove anti-aliasing in this case:
```F#
val server_cnt: r:ref uint16{r <> client_cnt}
let server_cnt = recall client_cnt; lemma_repr_bytes_values 0; ST.alloc 0
```
```F#
assume val alloc:  #a:Type -> init:a -> ST (ref a)
                                           (fun h -> True)
                                           (fun h0 r h1 -> not(contains h0 r) /\ contains h1 r /\ h1==upd h0 r init)
```
`recall client_cnt` allows you to recall the fact that `client_cnt` is in the initial heap and `ST.alloc` tells you that the new reference wasn't in the initial heap, so it cannot be the same as `client_cnt`.


什么意思...我其实没理解


header аналогично с главной


для интро можно оставить див и не ставить section в отличии от главной, т.к. по факту вся страница это одна форма


вместо интро контент  - отцентровщик,


лучше здесь сразу открыть форму и задать класс ей, т.к. внутри есть  блоки с разным фоновым цветом, проще сразу работать внутри формы


инфо теперь должен оборачивать белый блок до начала серого блока который начинается со слов "с каким приложением"


This seems to have had the effect that navigating to [http://openab.org/](http://openab.org/) no longer loads a page successfully which is not ideal.

I don't think both can be aliased using this file (https://help.github.com/articles/my-custom-domain-isn-t-working/#multiple-domains-in-cname-file) but should be possible through DNS (although I'm not sure how exactly)


здесь открываем отцентровщик  вместо этого класса


здесь формы уже нет мы открыли выше


поставь second-name чтобы отличалось от первого инпута


закрываем сначала отцентровщик, потом инфо


после идет отцентровщик


класс active, не пиши транслитом


My mistake - thanks for spotting this. Fixed.


после отцентровщик и далее везде так по аналогии, в каждой секции со своим цветом после обозначения блока идет его отцентровщик


див либо p


input type="file"


по html5 это уже <button type="submit" value="отправить форму">отправить форму</button>


здесь вместо p лучше див


это картинка, не шрифт


будет свг


див вместо p


здесь должен быть <header> в нем <figure>, в figure <a>, в ссылке картинка img (лого предпочтительнее делать изображением и избегать написания шрифтом), после закрытия figure сразу идет конструкция иконки меню, можешь делать на чистом css, но я бы просто сделал ссылкой и потом подключил открытие меню по тапу на иконку через js, после нее nav, nav - основная навигация - либо ссылки, либо список с ссылками, поэтому тебе нужно переделать структуру до .main


это section т.к. есть заголовок


здесь должен быть отцентровщик  который оборачивает только заголовок вместо intro_content, класс который держит контент в пределах ширины сетки по которой делал макет дизайнер, обычно называют center-wrapper,container и разные вариации


после этого дива  download должен идти также отцентровщик


пока можешь оставить img, но вообще здесь будет свг в дальнейшем


это p


лишняя обертка, здесь идет чередование белых и серых блоков, нет смысле оборачивать их  вдвоем


инфо-контент должен заканчиваться, где заканчивается белый блок, названия классов не проверяю сейчас, т.к. все равно переделывать нужно по методологиям, суть в том что каждый блок должен быть независимым, т.е .мы всегда можем выдернуть к примеру этот белый блок и перенести в другое место,после инфо контента должен идти отцентровщик - он всегда должен открываться в новой секции в которой фоновый цвет всего блока отличается от вышестоящего, а контент идет в пределах контейнера по середине


тут вместо спанов - p


после открывается отцентровщик


можно поставить section не смотря на то, что нет явного заголовка, после нужен отцентровщик


можешь пока оставить все так, я к примеру заверстал бы это 3мя ul


ну в верстке это проблем не создаст) главная без футера, а внутренние с ним, хотя я бы вставил на его месте из за соц кнопок


это section


Heh, you're right :) I'll fix this.


нужен отцентровщик


어썸


前面需要空行


缺少参数类型


cs


это не заголовки по смыслу, проще разметить 2мя  p или дивами каждую строку


@sartak This should be translated in the JavascriptConfig (https://github.com/bestpractical/rt/blob/stable/share/html/Elements/JavascriptConfig#L65-L67) to give the user a descriptive message in their language.


Type hint.


br не нужен после звоните закрываем p - p и див это блочные элементы, след. элемент сам по себе будет с новой строки


не вижу закрывающего </body> и </html>


大括号在新行


等号没对齐


`return` 前面空一行比较好 :smile:


@euwars
Please diverge from `initWithBarButtonSystemItem:UIBarButtonSystemItemCancel` into `initWithTitle:@"بستن"` by 'if' statement if this title is required localizing into Persian.


I think we're really close. Some cleanup work, as well as spot checking some pages.

I also think Raj wanted to add some content. The main elements are all done- footer is finished now too.

I think we should be able to launch this week.

Thoughts?

Sent from my iPhone

> On Sep 22, 2015, at 1:47 AM, Torkel Ödegaard <notifications@github.com> wrote:
>
> nothing more yesterday? feels like every day is a baby step, let me know if I can help to get this done :)
>
> —
> Reply to this email directly or view it on GitHub.
>


good graph :) I also had exactly the same figure as yours.

But I'm curious about the 'best strategy' of Problem 6 : if the first cashier has 256 bags and then pass it to the second cashier 128 bags, then the first cashier still has to count the rest of 128 bags i guess..??
Then isn't 127 seconds necessary to add up 128 bags..??
(If I didn't grasp what you were to say, then it's fine :))


TeamCity Colore :: Release Build [Build 2.2.1.78](http://tc.sharpblade.net/viewLog.html?buildId=662&buildTypeId=colore_releasebuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:3:26


TeamCity Colore :: Release Build [Build 79](http://tc.sharpblade.net/viewLog.html?buildId=664&buildTypeId=colore_releasebuild) is now running


TeamCity Colore :: Release Build [Build 79](http://tc.sharpblade.net/viewLog.html?buildId=664&buildTypeId=colore_releasebuild) outcome was **SUCCESS**
Summary: Skipping master branch Build time: 0:0:4


rename var name


@arrowrowe 0.0


@calavera why is the daemon started twice?


sublime also support `.editorconfig`, besides you got a new laptop. why use sublime


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21080/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21081/testReport/) for this commit**


The ReadMe hasn't been updated to reflect that the current version is 3.1 :)


why sleep for 10 seconds?


... and the spelling of IsUnitTarg.....


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21083/testReport/) for this commit**


Nice graph for infinite number of employees, for describing in detail with discrete number of works..!
At first, I didn't recognize that you depicted the graph in log-based unit in y-axis, but depicting the graph in this way seems to be great, since if we plot in linear unit, the gap would be too big to watch all :)


wow, no wonder it takes a while! I think we can remove some of these permutations - I'll comment inline.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21084/testReport/) for this commit**


Http no longer supports Dart, so this could be simplified. We could get rid of the `RequestMethodsNameMap` and just use TypeScript's enum lookup to get the right enum integer.

```
if (isString(method) {
  method = RequestMethods[toUpperCamelCase(method)]; // toUpperCamelCase is a made up function
  if (typeof method !== 'number')  throw makeTypeError(`Invalid request method. The method ${originalMethod} doesn't exist.`);
}
```


Nit: pass the function instead of calling it from within anonymous function.
`var observer = new MutationObserver(findLogins);`

Given using `findLogins` is being used as an event listener as well as a mutation listener this would ordinarily be problem, but you're not using `mutations`.


`subtree: true`


We only need to build  no cloud with the default app (leave APP empty). It's the system firmware that's really tested here.   We can also add a build with no cloud and  `TEST=wiring/api` to be sure that disabling the cloud still preserves API compatibility.


normalize method would be called twice if called in `merge` and the `constructor`.


r+


Not a big deal, but one extra function call, and doesn't provide any value.


`DEBUG_BUILD=y  SPARK_CLOUD=n PLATFORM=photon` can be excluded.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21085/testReport/) for this commit**


can remove these instances of `SPARK_CLOUD=n PLATFORM=P1`


can remove these too. SPARK_CLOUD=n is only a band-aid for the Core to reduce the flash space used.


@abbradar: this downgrade specifically, or the previous bump to 1.9.20150703? I.e., does https://github.com/nckx/nixpkgs/commit/329adb3a4bbdbe8e04e208cedfde53d3cf17a7df fix this for you?

I was going to push the latter y'day, but am getting confus{ing,ed} reports.


Unused `event` which is sometimes an `event` and sometimes `mutations`. Recommend changing to `mutations` or removing.


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/f642d090f45555cbdf62ac2419c61d747eceafaf


merging MonsieurNicolas/stellar-core/trustlineOffersIssuersFix = f642d090 into auto


MonsieurNicolas/stellar-core/trustlineOffersIssuersFix = f642d090 merged ok, testing candidate = a4c20a75


Why is the indentation different here?


flake8 add spaces around the +


What `PLATFORM` should that build be?


So should I remove all `SPARK_CLOUD=n` builds that are not `PLATFORM=core`?


yes please


The core specifically, since the debug build is a test of system firmware - and it's the same system firmware that's build on the for for every app. (Core is monolithic.)


@joshcough If the connection between `Matrix` and `Board` is broken, this can be straightforwardly changed back to an MPTC.


aha.  so THIS is where the magic happens.


wow very commit, such awesome


This is an improvement. :+1: However, this still lists all posts. It should not list all posts. This method should only return the posts that have been created after the previous digest email was sent.


![screen shot 2015-09-22 at 6 20 55 pm](https://cloud.githubusercontent.com/assets/7003022/10035388/b48bd4ce-6156-11e5-9894-4d36cf05e164.png)


the screen is getting chopped off, trevor.  you probably know about this but i figured i would share.


This should be plural ("Posts") since it is a list of many posts, not just a single "Post".


good job


Hello World!


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.604](http://teamcity.monogame.net/viewLog.html?buildId=10253&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


ah stripping whitespaces :smile:


+1 nice!!


@rebelos enable this option in your IDE. makes code look neater and saves space :+1:


This may be challenging to include the full post body. Most posts are short, but they have the potential to be long. Truncating this would also be difficult since it is HTML. I think it would be more helpful to display the name, date, number of votes, and number of comments (just like on the homepage).


`ExecConstants.ADMIN_USERS_KEY` changed to `ExecConstants.ADMIN_USERS_VALIDATOR`, is it the same ?


same question here


What should be done if nonexistent fields are passed along with the PUT request?


Why would it slow it down?


how should we use this new --harmony<_classes,_generators,...> flag ?
its giving error if we have this flag in our mocha.opt file

thanks


I'd suggest using `~>` rather than specifying versions exactly.

e.g. heroku-api `"~> 0.3"` instead of exactly equal to `"0.3.23"`.

http://guides.rubygems.org/patterns/#pessimistic-version-constraint


Comment left in


Another comment.


Mary, please insert the bang(!) after every create.....it is a greater check to qualify if your seed is actually persisting.


#5112-Array-bounds-error-with-ControllerMechanicalVentilation-and-no-DesignSpecificationOutdoorAir-objects (rraustad) - i386-Windows-7-VisualStudio-12: OK (1885 of 1885 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi,

I do have some knowledge, as I wrote OpenSSL's UI API, and I'd like to help if I can.


Good, some array definition can use reshape in the end to let you type les []s :)


This is definitely not correct according to the SQL standard. It should count the rows in zips (technically, it is the number of rows for which the expression `7` does not evaluate to `null`). Are we consciously deviating from the standard?

Note that we have another related ticket: https://slamdata.atlassian.net/browse/SD-887


This entire commit doesn't seem to make much sense to me.  Bower components aren't limited to javascript only.  They're also not meant to be interpreted as production files, which I'm concerned that by labeling it 'js', you imply that they are.

In terms of naming, I would suggest something like 'client' or even 'front-end' if you want, but with regards to the location of the 'libs' folder, it's not impossible that the backend, and also tests may need to reference something that is installed via bower.  I'm not sure if moving the location of the bower components anywhere but the top level is a good idea for now, until we have a clearer picture of how the frontend, backend, and testing/integration is going to work together.


这个还是解了吧。。
其实我感觉最应该封死的是-Wreorder


you got some warnings in there hoss. Might wanna hose those down.


If the contents of the object being put is to support inspection by new eleveldb code, it should be encoded with msgpack as a the third parameter (https://github.com/basho/riak_kv/commit/ad6125e82). I can well stand corrected on this point if msgpack encoding happens elsewhere (but then, is riak_object encoding happening twice?)


they [the bower components] also aren't directly part of the app, which is why they weren't placed under the 'app' directory to begin with


sheeeeeeit , looks like you already did


fs


101163020-SetpointOutdoorAirTempOneDirection-4627 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-70.9%25-red.svg)


@kenwheeler I don't fuck around with warnings, I kill em fast


It's multiple flags. Maybe that's not very clear. E.g. --harmony_classes, --harmony_generators, --harmony_scoping, etc


Tu pensais pas que j'te donnerais du trouble de même, hein : P

En fait j'dis ça mais moé-avec, plus j'regarde ton repository, plus j'me dis que j'devrais réorganiser mes trucs. C'est propre ton affaire. J'vas m'en inspirer.


I think we can do better than this. Should fail for non-numeric or arity != 1. In other words, just match `Int :: Nil` and `Dec :: Nil`.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/81694755


I added it here.


'Update jQuery and reduce load time. There was probably a better way to do it, but anyways...'


101163020-SetpointOutdoorAirTempOneDirection-4627 (rglazer2) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


this isn't a library other people should depend on, I want to lock them down to very specific versions


Try commenting your code more so that you have a quick way of knowing how you are using your variables.


添字追加


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.604](http://teamcity.monogame.net/viewLog.html?buildId=10253&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:19:17


empd (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1343 of 1346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.24%25-green.svg)


fast-forwarding master to auto = a4c20a75


Link download latest build ?


Thanks. Does this square images?


The production version won't allow for more than 8 pages to be downloaded


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 688](https://teamcity.labkey.org/viewLog.html?buildId=273591&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:24:38
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

##### there are 23 more failed tests, see build details
```


test comment


This is really just a stylistic thing, but I think the code would be a little more clear this way:
if piece_at_dest.present?
  capture(dest_row, dest_col)
end


No problem，thanks!


How about
```
for (String library : MANDATORY_LIBRARIES) {
    if (libDir != null) {
         System.load(libDir + File.separator + "lib" + library + ".so");
    } else {
        System.loadLibrary(library);
    }
}
```


I've got linting to work with the instructions found at `eslint-rules/README.md`, but I when I do `npm install .` I get a `'eslint-plugin-react-internal' is not in the npm registry.` error :/


Fixed! Thanks :)


Ok, it's a static method.


Good idea. I'll put this in.


This is caused by occasional errors in CircleCI when Cassandra doesn't start in time


sql


I added a test in a422f66660e27f7c2f3942fb2afc87a1f2723ff4 but I realise only now that it doesn't get included in the test suite. d'oh.


What you said first I have no clue honestly... what I had in mind is that
since we use windows of 10 sec. we generate a vector with the values
contained in this window. We do the same with the GT, and we check the
similarity between the vectors computing the angle. So at the end, we deal
with the values themselves rather than with the pairs of values at specific
time t like Chromback alpha does. So the color matrix shows how similar the
windows of 10 sec are between them. And what I wanted to remark is that
even if we are using a complete different measurement from the conceptual
point of view, the points I marked in the plot (1,2,3...) has a
correspondence with the GT in figure 9. I dont know if kshitij had a chance
to look at it. It would be useful.

Ferran

2015-09-23 0:42 GMT+02:00 Séverin Lemaignan <notifications@github.com>:

> ...so we can use the cosine similarity to find the time shift, right? and
> then, we could use this time shift to re-align the measurements and compute
> a cronbach alpha, I guess.
> So my question was more: what is the meaning of the cosine similarity
> value (found in table 1) for instance? and: how to read the cosine
> similarity matrix? (in particular, where do we see the value of the time
> shift?)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/chili-epfl/paper-HRI2016-attentionTracker/commit/53eb446108923da30274405ee981f28e478980bf#commitcomment-13379559>
> .
>


Just do `npm install` from the root of react.


this https://doc.rust-lang.org/std/slice/trait.SliceConcatExt.html#tymethod.join shows join is preferred


Correção


to_ascii_xxx causes another copy.


This is more useful if it says why it was different. i.e.

    def step_impl(ctx):
        actual = util.read_printable(ctx.pty).splitlines()
        wanted = ctx.text.splitlines()
        got = actual[-len(wanted):]
        assert got == wanted, "\nExpected =====>\n{0}\n\nGot ----->\n{1}\n".format(wanted, got)


@bakhshb @amar441:
I added explicit TODOs where there was no implementation. That way, we see where the steps are mocked.
Further, I adapted the tests a bit to make them test what they intended to test.


Yeah, I need to find a library for that :) There should be one that provides a diff. May even be better to just pull in unittest and use its assertion methods, which AFAIK just raise exceptions if they fail.


Yeah, unit test methods are good.

I've never used behave before, so I'm not sure how to integrate them in.

Though there's always this https://expects.readthedocs.org/


Ooh, expects looks nice. Although I'm not 100% convinced about the ridiculously long chained method calls :) Feels like the bad part of Ruby (I suspect it is written by a Rubyist). I think I'll integrate it though, as it feels more sensible than hashing unittest and behave together.

FWIW, I will add unit tests with the stdlib unittest too, although only on things like the `io` module, especially once multiplexing hits master. Cucumber style tests (i.e. behave) are a more natural fit for the integration testing, where you're describing user actions and expected results, rather than testing code itself.

I should have had tests there from day one, rather than retrofitting them, but c'est la vie!


There's also should_dsl ( http://www.should-dsl.info) which a fun read if you want to learn about magic.

As for tests. I think this is a good time for tests. Sometimes it's good to get something working first. (thin line to walk though)


%status_label apparently isn't defined on the right hand side of this line.

"make test" says:

t/1_compile.t ...... 85/? [Tue Sep 22 14:59:38 2015] 1_compile.t: require failed with 'Global symbol "%status_label" requires explicit package name at /export/data/gbell/code/omp-perl/blib/lib/OMP/CGIComponent/Obslog.pm line 365, <DATA> line 389.


Did you know about `format_token.matching_bracket`? Would that work here?


What happened to #502?


You can set the properties by opening Script Editor -> File -> Project Properties -> Script Properties.


There is no guarantee of this.  For example, the writer could sort the rows and then write them.


Don't bump up the version just yet. I normally do that right before a release. :-)


not "pip install -r --upgrade requirements.txt" instead "pip install --upgrade -r requirements.txt"
=> "r" after "update"


@bakhshb @amar441 Required steps to get to the result page have been pulled up to a `Background` per Feature. That way, it is less verbose for you to write the next tests. Hope that it okay.


Line length exceeds coding standard limit of 110 chars.


That was the change.  I expect that there are other areas where the former terms remain.  Will scan project


Could you undo this formatting? I prefer the `for` to be on the next line. (If YAPF did this, then we need to fix it...)


oh... when the "message"

nice catch, will do


Actually you can delete this package/class, it is not needed


is extend as fast as push_all? https://doc.rust-lang.org/collections/vec/struct.Vec.html#method.push_all leaves me hanging.


You might be able to use `cur_token.CloseScope()` here.


Looks good! I must have been doing something wrong. I started with my Assignement2, which has a switch/case function in it. When I started breaking my methods apart, I created strings to output like you did and my case functions looked like yours, but I kept getting errors. I was having trouble with my javadoc, couldn't seem to get it right. I think that may have been the problem. I eventually changed my program to if and else if statements. Sorry if I am writing a book here, any insight you may have would be great.


This looks a lot like `lsst.pipe.tasks.ingest.RegisterConfig`.  You should either subclass it or find some other way to reuse the code instead of duplicate it.


Thanks for this! Could you add a few test cases as well?

As for the CLA, it looks like Facebook has a company-wide one. But I think you need to submit the pull from your facebook.com account.


Why remove this? having 'sshd.service' as an alias for 'ssh.service' seems useful. (on other distros it's 'sshd.service')


Kind of a lazy commit message there, Guy :)


Lee McNeal


Suggest:

    obstype = md.get("OBSTYPE").strip().lower()


I think it's pretty normal to link syslog.service to whichever syslog daemon you use.


Could you elaborate on this @lucaswoj? On iOS we are doing commits of the platform-specific form like https://github.com/mapbox/mapbox-gl-native/commit/29baa6f6ac23ed03c695dee70413ea558746526a.

Details in https://github.com/mapbox/mapbox-gl-native/blob/d89aa51e0f59b2465dbbe5e56dd7c59ed88b2e86/scripts/ios/run.sh#L11 and the rest of that script.


There's a lot of duplication here from `lsst.pipe.tasks.ingest.RegisterTask`.  Please find a way to reuse the code.


The topic says "the input string is 30", and "should be equal" is 15 lenght, although I tested with a 30 phrase lengh and the code worked well :+1:


101163020-SetpointOutdoorAirTempOneDirection-4627 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (749 of 749 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.21%25-green.svg)


就是说 paragraphStyle 这个 property 是有后效性的修改，你第一次修改的内容 第二次使用的时候没有清理掉。


This revision is clean.


After a bit of discussion, we decided we should avoid use of `super`.


@tremainebuchanan why or?


@nedbat @singingwolfboy This commit needs an associated configuration update. The setting `FOOTER_ORGANIZATION_IMAGE` used in `edx-platform/lms/djangoapps/branding/api.py` defaults to the value `'images/default-theme/logo.png'`. Given that the value is not overridden for devstack or sandboxes, the removal of this image breaks both devstack and sandboxes.

FYI @feanil


@Fraser999 Can you please help me out here ? I'm trying to integrate google tests with my code base and I'm lost here. I added these CMakeLists.txt but I'm sure they won't work. Ideally, I'd like to be able to control building/generating the test suite from cmake, something like this:

build$ cmake .. => this will build and generate all the test suites

Moving forward, I will have many Test suites testing different parts of code. The way I think about this is, by default, cmake will generate the makefile to build all test suites and if i specify a target test suite, it will only build that. But baby steps, and I'd like to be able to build the entire test suite. I also asked this stack overflow question here: http://stackoverflow.com/questions/32662276/how-do-i-compile-link-test-cases-googletest-using-cmake-to-the-code-bundled-up

(Also, I will not have googleTest downloaded in a local directory. It would be best to download the package from git).


@ttuegel I just submitted a PR.  Thanks for the help!


this breaks socket reading because the buffer is 0 now bytes.  I realize the unit tests don't catch that.


Haha ouais j’ai comme changé d’idée après avoir checké la doc sur C++ !

J’ai trop de trucs à apprendre encore avec C# et comme c’est ce que j’utilise à 100% dans ma day-job, c’est plus profitable.

De : AlphaCygni [mailto:notifications@github.com]
Envoyé : 22 septembre 2015 20:40
À : stevehemond/codeeval-solutions <codeeval-solutions@noreply.github.com>
Cc : Steve Hémond <steve.hemond@outlook.com>
Objet : Re: [codeeval-solutions] Reorganize. (22de4dc)

Tu pensais pas que j'te donnerais du trouble de même, hein : P

En fait j'dis ça mais moé-avec, plus j'regarde ton repository, plus j'me dis que j'devrais réorganiser mes trucs. C'est propre ton affaire. J'vas m'en inspirer.

—
Reply to this email directly or view it on GitHub <https://github.com/stevehemond/codeeval-solutions/commit/22de4dc02594efe1a4bd13676bf3c60d2289ec56#commitcomment-13381123> .  <https://github.com/notifications/beacon/ANh3zyROlktxRwVCNfW3oCOtPMhOTB3Iks5o0exGgaJpZM4GCCzw.gif>


Nice! Hopefully it works first try. Fingers crossed


Nice commit!  really clean... good use of the `goTo()` function


Oops console log


Any help?

Regards,
Abhishek

On Mon, Sep 21, 2015 at 12:10 PM, Olaf Kwant <notifications@github.com>
wrote:

> This is not a chrome app. This is a Zendesk app.
>
> You need to run this with zat:
> https://developer.zendesk.com/apps/docs/agent/getting_started
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zendesk/bookmarks_app/commit/54136b08a816287189c9be0d6a622184aed86323#commitcomment-13334826>
> .
>


Can you offer explanation please?


goTo! I remember using that in qBasic.


This is will return A.B.C if they LOOK like a qualifiedName. It may be a column reference or field reference. We use it for:
1) TupleDescriptor.resolveFields(QualifiedName)
2) as key in resolvedNames map
3) To rewrite DeReferenceExpression to QNR in TranslationMap
4) TupleAnalyzer JoinOn comparision


Any help on this?

Regards,
Abhishek

On Wed, Sep 23, 2015 at 6:46 AM, Abhishek Pandey <pandey@agilecrm.com>
wrote:

> Any help?
>
>
> Regards,
> Abhishek
>
> On Mon, Sep 21, 2015 at 12:10 PM, Olaf Kwant <notifications@github.com>
> wrote:
>
>> This is not a chrome app. This is a Zendesk app.
>>
>> You need to run this with zat:
>> https://developer.zendesk.com/apps/docs/agent/getting_started
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/zendesk/bookmarks_app/commit/54136b08a816287189c9be0d6a622184aed86323#commitcomment-13334826>
>> .
>>
>
>


Doesn't this test fail without all the other work?  If so, it should be grouped with the other work.


@Tieske was working on it


Seems that the newer `runas` module is in conflict with the old one in atom, I'll unpublish this and sorry for breaking the master build.


Nice spacing and comments. Very easy to read through. I started with my assignment2, which had a switch/case function in it. I had trouble breaking it apart for methods. I was obviously doing something wrong. I ended up having to change everything to if type statements, strip away my counter and while loop and then it was much easier to code.


Very good logic, althouh break and continue are not recommended. It is better to use while condition


Still needs:

- Argparse for lint tests in all codebase
- Read/set minimum score to pass the commit
- Function to install/copy pre-commit hook into .git/hook/pre-commit
- Parse tests results from pylint.Run, suppress results if >= score


Add a comment noting which ones are not included (presumably because the CCDs died).


Release 1.01


Can you make this throw an `Invalid` exception instead of just `assert`, please?


acá falta una comilla al principio


MyAdmin should be LocationAdmin...soz


Release 1.00


ha! thanks, I'll be fascinated to see what changed.


I forgot to include all the files in that commit, 2cfa818 includes square images for collapsed q2.


Can you protect yourself from NOAO changing how things are done, e.g., by checking if what comes back from `md.get` is iterable, or embedding the indexing in a `try` block?


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 689](https://teamcity.labkey.org/viewLog.html?buildId=273598&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:27:24
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

##### there are 23 more failed tests, see build details
```


This should be squashed into the previous commit.


Perhaps you can use an iteration variable keep all the number (1 to 15) and then test something like you did in testRecentFileListContent, so I can see that when more than 15 files are put, the oldest file is removed and the new file is added to the list


Of course!


Hi,

Can you please take me off this list?

Alex Hoffman

> On Sep 22, 2015, at 2:26 PM, Vladimir Strigun <notifications@github.com> wrote:
>
> Да все так, просто в логах довольно тяжело искать определённые сообщения. Для тестирования неудобно, откатил локально себе
>
> —
> Reply to this email directly or view it on GitHub.
>


Explain in the docstring what the MasterCal image looks like, and what needs to be done for it to be standardized.


I don't think it works.


This is wrong, the initial state should be user's personal calendar.


typo


Use `str.replace` instead of `re.sub` for these uncomplicated regexes.


You probably didnt need to check in migrations that add and then remove a single table.

Looks good to me though! Ship it!


Fix issue #1


To be clear, SatZoneDarcyLayers requires the D8 flow file (a 2D grid of values), yet it can accept a DEM of lower dimensionality (Scalar, Time Series). The flow file is made by RiverTools from the DEM (see link above).

The file **default_flow.rtg** I provided is a RiverTools Grid file with a 44 x 29 (the grid size given in **default.rti**) array of zeros.


The hidden field doesn't have input for users, so its value should not be changed by users. That's why its value is always constant (`$field['std']`).


@abbradar: this revert fixes `bitcoin` on Hydra, as the reverted commit broke it there.


# This commit made me feel like a Angry Pig.
![giphy Angry Pig](http://media.giphy.com/media/QC2wyrB776ve/100.gif)


I don't know if this is fully complete, how about adding something else as well.


没意义吧?


oops :disappointed: . nice catch!


I think that it'll be better to have single action with id and type instead of one action per each type. @jnv, what do you think?


don't try std::string since different stl has different behavior. we use char* to control the string ourself.


Awesome!


should probably be DigitalSensor—types generally start with an uppercase letter to distinguish them from values, and are singular nouns.


hahaha i love truth or dare option.  Solid program, too.


Very good idea to use Observer class :+1:


It would be better to use `os.sep` rather than assuming the path separator is a forward slash.


# This commit made me feel like a Aloof Cat.
![giphy Aloof Cat](undefined)


Why is this needed, since it is run in Home.xml already?


5-11行不要使用tab字符，缩进用四个空格


大括号写上一行去


Here is what I've done so far. I basically just modified my old list to work with members instead of farm animals. I still need to read in from the input file, and finish a lot of things up, but this is the basics of it


Especially explain the wtmap.


大于号左右两边加上一个空格


no need to keep this function since Mengjia already moved translate_3a_results_to_xcam to xcore/aiq3a_utils.h
it's a very easy call and easy to maintain.


You can not duplicate the L here, I think this way of writing 90 is incorrect


This is the correct way


Killer documentation.  Super easy to read.


写成三行

   if ((st.final > 80) && (st.paper > 0)) {
        return 8000;
    }


# This commit made me feel like a Confused Cat.
![giphy Confused Cat](http://media.giphy.com/media/bJvh95UPkQ2WI/100.gif)


All these test name suck, don't try to write all the steps made by a test in the name. The important part of a test is not what it does, but what is being tested. Please use a name describing what is being tested.

If you want to describe what is done by the test, you are allowed to describe it INSIDE the code (using comments). Also, this is appreciated :), but not in the name of the test.


# This commit made me feel like a Scared Gorilla.
![giphy Scared Gorilla](http://media.giphy.com/media/Rq2KDuUQp6848/100.gif)


写成三行


# This commit made me feel like a Scared Dog.
![giphy Scared Dog](http://media.giphy.com/media/4d4EfxUjHAK6A/100.gif)


# This commit made me feel like a Scared Unicorn.
![giphy Scared Unicorn](http://media.giphy.com/media/GPbsln6TeoO40/100.gif)


# This commit made me feel like a Scared Cat.
![giphy Scared Cat](http://media.giphy.com/media/9PPIsF7fIIj84/100.gif)


# This commit made me feel like a Scared Pig.
![giphy Scared Pig](http://media.giphy.com/media/JFWaNo8IkdGgw/100.gif)


try free_3a_result from xcore/aiq3a_utils.h instead of xcam_free because result also have a reserved <destroy> function, we may consider to support it when necessary.


note "."


Since these stats a received from Servers these should be sent to servers as well, perhaps a different service on Server side starting with

"Donut"


I don't think this is a good idea.  You're fooling yourself if you think the weight map (almost whatever way it's generated) can be representative of reality.  Better to leave the variance zero, IMO.


> "Donut"

```
Donut.RebalanceStats
Donut.UsageStats
Donut.StorageStats
```


Get Hyped


Thanks for the clean up! @surajpkn and I were actually curious about this.


It works, but there's no implementation of selecting the group you want to email to. Not yet at least


I'm guessing this is an old enum value that they haven't changed because it could break backwards compatibility - you upgrade your .NET Framework and suddenly SSL connections to some old legacy service stop working because it doesn't do TLS... Why TLS 1.1/1.2 isn't included is a great question though.

In any case this isn't even an option in .NET Core ("the future") so I simply changed to `SslProtocols.Tls | SslProtocols.Tls11 | SslProtocols.Tls12`, even when using .NET Framework.


pode cortar estas linhas sobrando :scissors:


don't use hardcode for smartlib path search. try MACRO definition.


大括号写上一行去


大于号左右两边加上一个空格


写成三行


It's more complicated than going to the site and clicking it @theseanconn, you have to spin up the node server (which you probably don't have)


não é preciso esse `item.getDescricao() != null`


缩进问题 else 之前的空格应该为 4 个


If you do `wcs = afwImage.makeWcs(md, True)`, then lines 165-167 aren't necessary.


妈的 后面这种问题自己改掉吧 一个个打 comment 累


At least some of this should be squashed with a previous commit.


缩进问题：if 前的空格应该为 4 个


Hi intrixius,

I like your answer to sorting the names of the calendars on the right. But to get it to sort, you need to mention that the user has to edit the database.

By default, the value of 'calendarorder' for each calendar is 0. Just making the change to $stmt above won't cause the calendars to sort. The user needs to go into the database, to the clndr_calendars table and put a value into calendarorder corresponding to where he wants it to show up on the list.

This can be done alphabetically, but it also gives the user the ability to group calendars and then sort each group alphabetically.

The drawback is, of course, that the user might break something in the database. It would be cool if the user could drag and drop the calendars directly on the webpage to set the sort order.


缩进问题 应该为 4 个空格


As our unit tests sometimes needs to wait until it reaches the `DEFAULT_WAIT_SECONDS_4_TERMINATION` which is 20 seconds, does this mean that users might also hit this issue?


Meanwhile, it had been tuned further more, using lower resolution,
but those new values did not pass STC.
http://tests.stockfishchess.org/tests/view/55fb01d90ebc5976a2d6ddf9

I just learned the "Modify" trick, and just restarted using the "Modify" trick.
Wish I would have known earlier.


Squash into previous commit.


文件最后一行应该是一个空行（你最后一行加个回车就可以了）


这诡异的缩进……


This test doesn't work without other commits made after this one.  Squash it with them.


Totally have no idea what you just said @Ernie3 but you are probably right. I do not have the node server or whatever.

When this site is published it'll work from any computer or browser or anything right?


@themightychris @aharley40
Demonstrations and demonstrations-legacy both look great.

The competencies export still raises questions in terms of which grade levels it displays.

#1. For example, when running the report http://dev-cbl.node0.slate.is/cbl/exports/competencies?students=section+ENG1-001, ELA.3-AVG shows average scores of 27 for Glennie Gattison in Grade 9 when there are 0 logs in ELA.3-Total for 9th grade. This happens in numerous places.

It also shows 14 demonstrations logged for everyone in SCI.6-Logged but 0 in the total for all SCI-Logged, which is impossible if the sub groups has logs.

If you look through any row, you'll see that the totals don't sum correctly or agree between total logs and averages that exist when there are no logs.

#2. The logic to determine what rows show up doesn't reflect the logs in the dashboard. For example, Jimmy Jaquith has levels 1, 4, 6 and 7 but nothing logged at those levels would be possible because all students started on level 9. These rows may be showing because of errors in #1 that create data that then needs a line, but skipping levels and showing levels that were not possible raises flags.


Yes

On Tue, Sep 22, 2015 at 9:43 PM, Sean Connolly <notifications@github.com>
wrote:

> Totally have no idea what you just said @Ernie3
> <https://github.com/Ernie3> but you are probably right. I do not have the
> node server or whatever.
>
> When this site is published it'll work from any computer or browser or
> anything right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Ernie3/khs-minithon/commit/fc1832f845114d3ac8cc54bbe0e11a69a68aeb1f#commitcomment-13381845>
> .
>

--

Thank you,

Ernest G. Wilson III
Email: ErnestGWilsonIII@gmail.com
Cell: 302.668.7620


Refactoring validation of login through by userDAO


`except TypeError`

(Try to avoid blanket exception catching.)


@edmistj  looks good!


Mind sharing how to convert the dtb blobs to source?


No problem. It happens. Appreciate all you do.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 690](https://teamcity.labkey.org/viewLog.html?buildId=273601&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:24:54
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

##### there are 23 more failed tests, see build details
```


- Very good work on topic 4, but you can improve the package used, for example separate the Beans, the Services and the DAOs


101163020-SetpointOutdoorAirTempOneDirection-4627 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1274 of 1274 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.95%25-green.svg)


Can this be reduce to something very low like 1 - 2 seconds?


Good point - I should probably point out that this is the tota11y UI.


Yeah :( Rebase gone wrong.


Don't you also want this for the `flat`?


That sounds good to me!


I'm a ninny. No, vim, I don't want to use spaces.


Super long line!  Maximum length is 110 chars per line.  Use `"""` for multiple lines.


If the post starts with a quite (typical when replying) and the user who replies insert text before the quote using the rich text editor, MyBB mistakenly includes that text in the quote line:

![quoting messes up the quote line when adding text before the first quote](https://cloud.githubusercontent.com/assets/33569/10036312/adf0bffe-615a-11e5-8b39-69720fc2c12f.gif)

This check looks for text in the quote line that's longer than the typical MyBB username.


YAY!  is there a way this can help with the sim phet link as well?


Are you hyped?


Don't use `super` unless you really know what you're doing.


Isn't this better if instead of onCreated was onRendered?


It will check if libDir is null for every loop


ops my bad added these two lines to make it boot


Vbgj


This is more useful if it says why it was different. i.e.

    def step_impl(ctx):
        actual = util.read_printable(ctx.pty).splitlines()
        wanted = ctx.text.splitlines()
        got = actual[-len(wanted):]
        assert got == wanted, "\nExpected =====>\n{0}\n\nGot ----->\n{1}\n".format(wanted, got)


Yeah, I need to find a library for that :) There should be one that provides a diff. May even be better to just pull in unittest and use its assertion methods, which AFAIK just raise exceptions if they fail.


Yeah, unit test methods are good.

I've never used behave before, so I'm not sure how to integrate them in.

Though there's always this https://expects.readthedocs.org/


Ooh, expects looks nice. Although I'm not 100% convinced about the ridiculously long chained method calls :) Feels like the bad part of Ruby (I suspect it is written by a Rubyist). I think I'll integrate it though, as it feels more sensible than hashing unittest and behave together.

FWIW, I will add unit tests with the stdlib unittest too, although only on things like the `io` module, especially once multiplexing hits master. Cucumber style tests (i.e. behave) are a more natural fit for the integration testing, where you're describing user actions and expected results, rather than testing code itself.

I should have had tests there from day one, rather than retrofitting them, but c'est la vie!


There's also should_dsl ( http://www.should-dsl.info) which a fun read if you want to learn about magic.

As for tests. I think this is a good time for tests. Sometimes it's good to get something working first. (thin line to walk though)


Didn't understood this comment :(


I think there are a couple more things you want here.  The `HscMapper` has:

        tables:      "flat"
        columns:     "ccd"
        columns:     "filter"
        columns:     "taiObs"
        reference:   "raw_visit"
        refCols:     "visit"
        refCols:     "filter"
        filter:      true
        validRange:  true
        validStartName: validStart
        validEndName: validEnd


You should test this, create a unit test case that create twice with the same user


Good catch! Thank you.


Instead of normal comment you should use javadoc comment


Oops.  I think I've fixed it in a78aba00a09891488024f54eb6f2fd5036760346.


Need docstring to explain what you're doing.  What *are* you doing?


A `Task` should not hold any ephemeral data.  What if I run this in parallel?


Add docstring.


反正只影响第三方库，这个没关系吧0.0


sorry : (
probably a good call though


Blanket `except`.


I thought you'd enjoy this!


Cool!


So line#18 https://github.com/ophrescue/RescueRails/commit/65eec9fb8a1528509e45d642c6749869a5512955#diff-4e05ad0d64e6100656b63ad1e78f32c5R18 calls this filtering slice thing.  Not sure if that is still needed or not.  Thoughts? @TheDudeWithTheThing


So, that means subscriptions are not bound to queries. How we are going to map subscriptions and queries.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.605](http://teamcity.monogame.net/viewLog.html?buildId=10257&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This might be clearer as:

```ruby
yield if can_access_sendgrid?
```


@jayapalu Please do! That we we end up with cleaner code.


I've pushed https://github.com/hughsie/PackageKit/commit/b47f987b2572cc1d6490627196972d002dbafd4b to fix things.


do we require action here?


Yes, I thought a lot about that. I'm torn whether to port this to release or not. It might be better to invest the work into it now. It's mostly clean renames so shouldn't cause many problems. Thoughts?


This issue can be closed


Could you add a comment explaining that this is the page they'll be redirected to after login? It wasn't obvious to me until I read the commit message - but someone reading the code directly later will only see in-line comments :-)

Also it might be worth mentioning that django-browserid uses [is_safe_url()](https://github.com/django/django/blob/1.8.4/django/utils/http.py#L269) (https://github.com/mozilla/django-browserid/blob/v1.0.0/django_browserid/views.py#L38) so this can't be [abused](https://www.owasp.org/index.php/Unvalidated_Redirects_and_Forwards_Cheat_Sheet) - since at first glance I had that concern :-)


What kind of issues? Do you have warnings or errors?


Simply holding back at version `20150430` is the simplest solution, and what I had queued up anyway. I'll push it and wait for the altcoins to catch up next year.


@mhlavac ok thanks. Sometimes I like to use Vendor/Project/ValueObjects namespare and also Vendor/Project/Services namespace. What do you think about?


@borisroman I will do that. If the rest of the thing is good please give LGTM


IMHO it shouldn't be hard to port this patch to `release-15.09`. :+1:


lel


@peti: c10f705 should cause a similar effect after regenerating from hackage.


Still get error while compiling even though your libvpx version is used:

Configuring for target 'arm64-darwin-gcc'
  enabling arm64
  enabling neon
Toolchain is unable to link executables

Configuration failed. This could reflect a misconfiguration of your
toolchains, improper options selected, or another problem. If you
don't see any useful error messages above, the next step is to look
at the configure error log file (config.log) to determine what
configure was trying to do when it died.

The log file config.log in "./WORK/ios-arm64/Build/vpx/config.log":

// VERY BOTTOM.
required architecture arm64 in file /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/lib/system/libcache.tbd for architecture arm64


Services namespace is fine. I didn't want to introduce it because there was only one Service, but it's indeed a good idea


Excellent! Thanks for doing this!


I'm not sure I understand why this line is outside of a class or function?


@marion42, the `@ParamConverter` annotation is not necessary when there's only one parameter to convert. In that case, type hinting is used to determine the class, and the entity is fetched using the `id` route parameter (see http://symfony.com/fr/doc/current/bundles/SensioFrameworkExtraBundle/annotations/converters.html#utilisation).


Great! This wrapper for better codes quality. About camera driver, if you use proper header, there should be no problem with this gcc wrapper.


Reviewed by Dietmar Zabel.


Oh, I didn't notice there were three versions switched around. I suppose it's best to stick to the version that works for everything, if you don't know about any important fixes in the newer ones.


Shouldn't we have a BREAKING CHANGES section in this commit so we can properly generate CHANGELOG?


Nothing I know of; +1 for just using `20150430`.


I must admit I really prefer parenthesis in these cases to avoid any ambiguity i.e.
```javascript
if((this.state === states.connected) && (state === 'disconnected')) {
```

I appreciate JS provides precedence to the `===`, however I still think as a matter of best practice it's better to use parenthesis


No. The breaking change comes when we remove the deprecated version.

The library still works perfectly, no breaking change. People will only get warnings on their console about deprecation.

For 1.0, we will remove all the deprecated versions so then, we will make clear all the breaking changes.


Fix moving Tiat... :-1:


Ok, it was only a suggestion, the final decision is up to you.


Looks good to me


I'm not sure about power consumption but maybe will be safe some micro second or nano second operation :D Why do we do something that is definitely will be ignored.


@gabizou is this the correct way to implement? Looks like I'm the first to do so.


@vcunat: just a leak and some malloc checks, nothing worth breakage.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21092/testReport/) for this commit**


Shouldn't this be `if (stopIfUnsupported(test)) { return; }` so that the following code is not executed anyway?


Klingt sehr gut, gute Arbeit!


Oops :facepunch: me! Fixed it now


why not:

```js
return inputDate.length==0 || date.getDate()==dateArray[0] && (date.getMonth()+1)==dateArray[1] && date.getFullYear()==dateArray[2];
```

Also, I'd extract that into a variable or function 'isDateValid' or something, so
```js
return isDateValid(inputDate, date, dateArray);
```


Line 91 is dead code.


Can we add a simple test for this to ensure the defaults are in fact used?


It's setting the `short_description` attribute of that function, so that the application list will have a column named 'owner'. See the [list_display](https://docs.djangoproject.com/en/1.8/ref/contrib/admin/#django.contrib.admin.ModelAdmin.list_display) docs for more info


ugly, but it is what it is...


This doesn't fix the issue. The second condition is never hit (except for a value of midnight/00:00, but this a corner case) because the timedelta value evaluates to True.


This will crash if called with a player name that is not in game (e.g. if called from irc_commands) That's why /home has that extra check there.


changes done


The type argument actually takes any function, which converts a string to the desired value, so this can be simplified.

https://docs.python.org/3/library/argparse.html#type


use equals method


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.605](http://teamcity.monogame.net/viewLog.html?buildId=10257&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:18:23


Yes, as long as both have fully functional `DataProcessor`s :).


use constant first


This will crash if `homes_file` is not writeable for some reason (disk space or permissions for example). Testing `output` for `nil` and returning both its return values here would be better.


why is the service contract?


error handling


Oh ok

-------- Original message --------
From: Passthejam <notifications@github.com>
Date: 23/09/2015 9:23 pm (GMT+12:00)
To: incaterradev/Incaterra <Incaterra@noreply.github.com>
Cc: "Jackson C. Rakena" <rakenaj@scotscollege.school.nz>
Subject: Re: [Incaterra] Fixed a thing (e0626db)

Because it is a drop, and it is not made from a dirt block.

On Wed, Sep 23, 2015 at 8:18 PM, TrueArstotzkan <notifications@github.com>
wrote:

> What's this?
> Why is there a need to remove the DemonSkin recipe?
>
> -
> Reply to this email directly or view it on GitHub
> <https://github.com/incaterradev/Incaterra/commit/e0626dbec1c163a60173b550a6a568e7040116a2#commitcomment-13384982>
> .
>

-
Reply to this email directly or view it on GitHub<https://github.com/incaterradev/Incaterra/commit/e0626dbec1c163a60173b550a6a568e7040116a2#commitcomment-13386151>.


These seem to format the output as a single character, which ends up UTF8 encoded as 3 binary bytes.


Hi Jakub,

Thanks for the prompt reply.

I get compilation errors because the function clEnqueueBarrier is enclosed
within the in-active pre-processor block `
CL_USE_DEPRECATED_OPENCL_1_1_APIS`.

Below is the first error from clang:

|In file included from compute_test.cpp:3:
In file included from /home/daniel/compute/include/boost/compute.hpp:14:
In file included from
/home/daniel/compute/include/boost/compute/algorithm.hpp:18:
In file included from
/home/daniel/compute/include/boost/compute/algorithm/accumulate.hpp:16:
In file included from
/home/daniel/compute/include/boost/compute/system.hpp:24:
/home/daniel/compute/include/boost/compute/command_queue.hpp:1208:19:
error: use of undeclared identifier 'clEnqueueBarrier';
      did you mean 'enqueue_barrier'?
            ret = clEnqueueBarrier(m_queue);
                  ^~~~~~~~~~~~~~~~
                  enqueue_barrier

For reference here is the block from the bottom of cl.h:
https://gist.github.com/daniel-murray/a5983d3e8caf1bc21741

Note, I'm setting up a new system and I stumbled across this so fully
prepared for it to be my problem!

On 23 September 2015 at 11:03, Jakub Szuppe <notifications@github.com>
wrote:

> What kind of issues? Do you have warnings or errors?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/boostorg/compute/commit/c882466dbd2a3d9f3d8132075cf92d06f557930a#commitcomment-13386980>
> .
>


misspelled resource... check across the codebase, I've seen it at least 2 times.


capture event.asStartElement().getName().getLocalPart() in a variable


Yeah, probably a good idea to cherry-pick this to release-15.09 now.


Yeah I meant more it's a strange pattern, but it's in the Django docs, so wfm :-)


is this config file necessary? I like to include a sample config, but I think you should put it into

/examples/config/gfreespace

or something so it's clear it's just a template


why do you need to define thread_local as thread_local? Wouldn't just not defining it work?


Opened an issue: https://github.com/Polymer/web-component-tester/issues/218


missing space between the comma and `"\n"`


no internet Explorer pls :D


This commit makes the guppy tracking logic incorrect. picking up e.g. two nine lives's should not count as two cat touches
in the commit message you propose changing how guppy tracking works to be "loop over the collected_item list" (every frame? every time any new item is picked up? i don't really see the point) but that's not what this commit actually does


Could well be, this was a quick and dirty hack while I was prototyping, I openly admit to knowing basically nothing about Aurelia.


I guess I'll shelve my plan to replace all conditionals with short-circuiting boolean operators ;)

`this.state === states.connected && state === 'disconnected' && self.requestState({state: 'connecting'}) || newState.retryDelay && this.startRetryTimer(newState.retryDelay);`


else if condition


Ha, nice!


Please make sure comments are correct


Teste Synchronize


this doesn't match to config path being loaded in utils


Why not `if alias.recurseForDerivations or false then removeAttrs ...`.


Why not just put lines 78 and 76 inside an if(!is_null()) { } ?


does user.save() cause a write to the DB or is that just local to the app?  If it does write to the DB, don't you want to check if the user already exists in the DB and then update the user with the latest info from WISP?


Removal of an extra b in brew command


@vcunat: https://github.com/peti/nixpkgs/commit/5d276bdfdac60e5a67c2970d109877483525bd8e updates the Haskell package set


+1 you'd still need to rewrite functionality to swap this, right?


We're generally taking a fairly conservative approach when returning const data like this to python - since python doesn't have any concept of const and the consequences of modifying some of our const data would be absolutely dire (totally invalidating our computation cache for instance). If we you take a look at the bindings for getValue() in TypedObjectPlugBinding.inl, you'll see we've added an _copy parameter, which defaults to True - let's do the same here.


Pull requests, please!

![https://imgflip.com/i/rh613](https://imgflip.com/i/rh613)


:clap: :clap:


v1 unit test panic:
```
TEST_KUBE=1 hack/test-go.sh Godeps/_workspace/src/k8s.io/kubernetes/pkg/api/v1/
--- FAIL: TestAPItoV1VolumeSourceConversion (0.00s)
	converter.go:510: Calling custom conversion of 'api.VolumeSource' to 'v1.VolumeSource'
	converter.go:555: Trying to convert 'api.VolumeSource' to 'v1.VolumeSource'
	converter.go:555: Trying to convert '*api.HostPathVolumeSource' to '*v1.HostPathVolumeSource'
	converter.go:555: Trying to convert '*api.EmptyDirVolumeSource' to '*v1.EmptyDirVolumeSource'
	converter.go:555: Trying to convert '*api.GCEPersistentDiskVolumeSource' to '*v1.GCEPersistentDiskVolumeSource'
	converter.go:555: Trying to convert '*api.AWSElasticBlockStoreVolumeSource' to '*v1.AWSElasticBlockStoreVolumeSource'
	converter.go:555: Trying to convert '*api.GitRepoVolumeSource' to '*v1.GitRepoVolumeSource'
	converter.go:555: Trying to convert '*api.SecretVolumeSource' to '*v1.SecretVolumeSource'
	converter.go:555: Trying to convert '*api.NFSVolumeSource' to '*v1.NFSVolumeSource'
	converter.go:555: Trying to convert '*api.ISCSIVolumeSource' to '*v1.ISCSIVolumeSource'
	converter.go:555: Trying to convert '*api.GlusterfsVolumeSource' to '*v1.GlusterfsVolumeSource'
	converter.go:555: Trying to convert '*api.PersistentVolumeClaimVolumeSource' to '*v1.PersistentVolumeClaimVolumeSource'
	converter.go:555: Trying to convert '*api.RBDVolumeSource' to '*v1.RBDVolumeSource'
	converter.go:555: Trying to convert '*api.CinderVolumeSource' to '*v1.CinderVolumeSource'
	converter.go:555: Trying to convert '*api.CephFSVolumeSource' to '*v1.CephFSVolumeSource'
	converter.go:555: Trying to convert '*api.DownwardAPIVolumeSource' to '*v1.DownwardAPIVolumeSource'
	converter.go:555: Trying to convert 'api.DownwardAPIVolumeSource' to 'v1.DownwardAPIVolumeSource'
	converter.go:555: Trying to convert '[]api.DownwardAPIVolumeFile' to '[]v1.DownwardAPIVolumeFile'
	converter.go:555: Trying to convert 'api.DownwardAPIVolumeFile' to 'v1.DownwardAPIVolumeFile'
	converter.go:555: Trying to convert 'api.ObjectFieldSelector' to 'v1.ObjectFieldSelector'
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xb code=0x1 addr=0x0 pc=0x4c68e3]

goroutine 11 [running]:
testing.func·006()
	/usr/local/go/src/testing/testing.go:441 +0x181
github.com/openshift/origin/Godeps/_workspace/src/k8s.io/kubernetes/pkg/api/v1.TestAPItoV1VolumeSourceConversion(0xc20806c240)
	/home/mkargaki/go/src/github.com/kargakis/origin/_output/local/go/src/github.com/openshift/origin/Godeps/_workspace/src/k8s.io/kubernetes/pkg/api/v1/conversion_volumesource_test.go:32 +0x703
```
It seems that the conversion from downward to metadata never happens probably because DefaultConvert doesn't fail. So the right thing here seems to be
```go
if err := s.DefaultConvert(in, out, conversion.IgnoreMissingFields); err == nil {
```


感谢您的翻译工作！


:yellow_heart: Redundant code should be deleted. This includes code that has been commented out.


What is this change needed for?


What do we use this for? Does any of the supported OSes still use code pages? I thought unicode support was pretty much complete today?


Is it really intended that pixel is passed by reference and therefore is modified after return from this function? As we discussed before, let's not include this commit until we have a use for it, and can test it.


@kean Well, cannot really be implemented this way without swizzling. It should not influence external code or other swizzling for that matter. If you find any issues, let me know.


My bad. I didn't have NUnit installed so I must've accidentally applied it to the entire project


There was a bug where the final `</ul>` of the navigation was not output.


You may want to explain why you set `children` to `null` **before** the disposal of each child, thing that you haven't done above for the parents.


:yellow_heart: We may have to think about creating a model for event categories. For now, we should store the categories in a JSON file that would help save time since we'll have just one point to edit.


What kind of OpenCL SKD do you use? Because it's really weird cl.hp file.  `#ifdef CL_USE_DEPRECATED_OPENCL_1_1_APIS` does not occur in original one from Khronos website https://www.khronos.org/registry/cl/api/1.2/cl.h.


Yes, that seems better. Pushed as 63f3fef.


My bad, I applied NUnit to the entire project, not just the test project


:question: What does `more-events` represent?


Thanks for doing this! I'm not so keen on making the tests new up specific kinds of rules to test this. Instead could you please introduce a new @Value.Immutable type that has the 3 fields: `getPathToTextSymbolsFile()`, `getRDotJavaPackage()`, `shouldWarnMissingResources()` and pass around a set of those values?


Shouldn't this say "12.4.2" in commit message?


:yellow_heart: We may need to refactor this to avoid using `!important`.


I could be wrong, but from my tests, tidy doesn't trigger an error if the line length is over the configured wrap option, so I'm still unsure I understand if and how this prevents from submitting PR that aren't properly wrapped.


works fine for b3


I'm just waiting to hear that #53 is resolved, then I'm happy to make a new release.

I think we need a small extra change to meet the needs of Linux distros, though - this only lets it work without an internet connection if it's already cached the list of valid classifiers previously. I'll change it to warn rather than erroring if it can't get the list at all.


:green_heart: Good job deleting the commented-out code.


:green_heart: Good use of the filter here.


OK, I'll port this merge to 15.09, carefully.

@peti: looks good to me. I don't think Haskell needs special handling of this on 15.09 – either it will remain the same or just updated when regenerating (I suppose clean regeneration would be preferred to cherry-picking).


Let add a couple of test cases for this as well while we're at it - asserting the contents are right and that the copy behaviour is as expected.


Please provide a changelog entry. Next time do a pull request as this is the process.


In this way though we swallow any `DefaultConvert` error.

I think the right way for this is to call `DefaultConvert` after `in.Downward != nil`:
```go
if in.DownwardAPI != nil {
    if err := s.DefaultConvert(in, out, conversion.IgnoreMissingFields); err != nil {
        return err
    }
    out.Metadata = new(MetadataVolumeSource)
    return custom_api_DownwardAPIVolumeSource_To_v1_MetadataVolumeSource(in.DownwardAPI, out.Metadata, s)
} else {
```


The tree nodes are deselected synchronously, check the [source code](https://github.com/vakata/jstree/blob/3.0.8/src/jstree.js#L2932). When the call to ``deselect_all()`` returns the tree nodes are already deselected. Moreover,  ``executeScript()`` is synchronous too, unlike ``executeAsyncScript()``, so I really don't see why we would need these additional waits.


QualifiedName ?


Thanks for the pointer, I'll see what I can do in the next few days.  It might take 'til next week before I get to it.


ClassHierarchy ?


This is so bad... Hmm I know I will change the name of trial plots to plotworld, what's that you say? I've broken a shit ton of plugins? What's that? Because they aren't configurable? Well that doesn't seem very smart.

See where this leads? Try not to solid code every fine detail, especially if the details SHOULD be extremely configurable.


No worries thanks for helping to implement these validations, very much needed!

Yep the module's code base was very quickly written from ZPanel 6 into the ZPanelX framework with linux support extended. So the code isn't the best and needs a fair bit of attention :+1:


Let's just construct offsets as a temporary inside the `new IntVectorData()` call - that way we're not having an extra copy we don't need sit around as static data forever.


I don't believe FIG has anything w.r.t how variables are named :)


Also too generic name, similar suggestion


will do funny things when you use it on malloc://32, i think


its disabled by default, just needs some testing and such, but at least the option is there :P

> On 23 Sep 2015, at 12:51, condret <notifications@github.com> wrote:
>
> will do funny things when you use it on malloc://32, i think
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/radare/radare2/commit/bbf7a2221c6a35ebc4e1a223406ae708ac4b6704#commitcomment-13387731>.
>


Too generic name


also, the whole debugging on top of esil thing must be implemented outside the core, with an easy-to-use api for stepping and such.

but i dont plan to do this before the release.

> On 23 Sep 2015, at 12:51, condret <notifications@github.com> wrote:
>
> will do funny things when you use it on malloc://32, i think
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/radare/radare2/commit/bbf7a2221c6a35ebc4e1a223406ae708ac4b6704#commitcomment-13387731>.
>


can we have single io pass ?


@BrutalSimplicity If you want to continue the discussion, ***please open an issue.***

> Ahh, yeah I had a feeling that wasn’t the best way of starting a discussion. Thanks. I think postgresql sounds awesome (I’ve never used it), and from what I’ve read it is industrial standard so I have no qualms there. I only brought up the idea because some users might want to just muck around with the pure data rather than through the interface. For example, sqlite make the tool more portable. I can easily jump zip this solution up and send it to someone else oblivious of the underlying implementation, and they can start using it with little to no prior setup

You don't need to use the Python module to much with the data. It's true that you need to go through the process of setting up PostgreSQL---which isn't bad for a one-time thing---but it pays for itself again and again.

>  I’m guessing stored procedures.

No. It is just aware of the problem domain, doesn't do useless joins and uses aggregations and group by to great effect.

You are more than welcome to try and convert the `Query` interface to an ORM as an experiment. Writing a little code before suggesting *major* structural changes to an existing project is good form. :-)


Typo, should be `Test`


Shit. Missed that one. My bad


Casting data types should probably happen in model or repository classes and not controllers. See the changes I made in pull request #741.


Awesome. Thanks @tijmenb.


private ?


I searched  `eave` ....


Oh, also, there's no need for that ScopedGILRelease - I think you've probably got that from the `channelData()` binding above. It's there because the call to `plug.channelData()` will trigger computation, potentially spawning threads which want to then use the python interpreter - which obviously won't work if we haven't released it. But there's no such problem in this method, so we can leave that. The `channelData()` method does provide a good example of the copy behaviour we need though - better than the one I previously mentioned.


What does `if (false)` have to do with this rule? I find this example confusing.


Great!  Thank you very much!


Decl -> Declaration


hi


Okay, I've removed the warning and the original comment.


Visual Studio and I agree on the fact that a function of type int needs to return *something*...


`entry` may be uninitialized, right?


Resolve is verb but this name is class name so it should be XXXResolver


Yup, you're right. I noticed that when I tried to run it on IE, & fixed it in https://github.com/ably/ably-js/commit/b72cbca22ce7d5a8c550bf892436c59a38336f3e


Could you move the property to `KillbillServerConfig` (the `config` variable is already initialized)?


@daniel-abbey is merging the changes I made using the [issue/pondermatic](https://github.com/LearningLocker/learninglocker/commits/issue/pondermatic) branch.


Here and in a few other places there are spaces after the ``{{` but not before the closing `}}`


On second thought: It is implicitly known that the lambda function is called with `e == nullptr` if `cap` was not found, right?


I might say, this broke my test


re @at15: It's a typo for `leave`...... I've corrected it...


Changed to `__file__` in latest force-push.


No, it is never uninitialized, but it may be nullptr. The apply function does a dynamic_cast to the lambda argument, moreover if the object is not found, a nullptr argument is given.


So you only changed version without checking if it still compiles?


hi sir @arco , can you explain to me. Why you remove this flag?


It appears to be that way. I thought I had a working version of it but when I double checked the version on my fork it was as I expected.

It fails for "arm" not sure about the others though.


Hey, just a question, is there any reason to set this to 1026mhz, instead to 702mhz as it was before?


I think these should be moved above `edX.Widget.CreationButton` for proper widget sequence.


Would "No **authorised** application found with id" be clearer? :-)


@duncanspumpkin any suggestions?


:red_circle: The `getBooks` function should be a member of the `Index` prototype. It should be called like so:

```javascript
var index = new Index();

index.getBooks(/* JSON filePath or name */);
``


Looks like a merge issue here. This would cause Travis to fail.


Sure, it would be nice to be added as a contributor. :)  I'll add some tests for the invite method as well.
My name is Wouter Vernaillen and my website is www.vernaillen.com
Thanks!


Done.


I dont think we need the render.
The render is done in via the graph. When the graph is loaded


Yeah, I think it's working as of 1.6.3. Hehe, it's funny, I think I first started this gem nearly 2 years ago, but my use case was only ever creating a torrent from a single (large) file. Now that's changed, and it's great to see at least one other person is using it :)


Considering that `AutoEnable` will be calling this every tick when it's running it would make sense to cache the EnergyRequired blueprint variable locally.


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: mixer


Happened by accident, but I left it that way to avoid any kind of problem I had in the past (wakeup delay)


You are right, I must have forgotten to adjust the example. I'll fix it.
El 23/09/2015 12:59, "Michał Gołębiowski" <notifications@github.com>
escribió:

> What does if (false) have to do with this rule? I find this example
> confusing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/eslint/eslint/commit/ebfc290801cab51d8d7b3f29846318cea00e1409#commitcomment-13387879>
> .
>


I think this convention of naming for a toggle function is slightly confusing -- in other places around the codebase we have conventions like `SetEnabled(enabled)`, and from the naming here it's not too clear that `auto : bool`.


Well, above, this is not parent disposal, but disconnection of the node from its parents. It is definitely safe to be done many times and could not be the source of any loop because the operation is not recursive at all. On the other hand, the dispose operation is a recursive process, so if a loop exists, there is a potential (unchecked) risk of infinite loop. I have therefore "disconnected" the list of children from the entry before proceeding.


Эй @keksobot а ты специально баги пушишь мне тут?


GNB 미작성
29행>.top btn: absolute; right:0 안 먹음


:green_heart: The `response` variable name is preferable to `data`. This is excellent work.


@MohamedIhab  Please review


I'm aware of this ticket, I'll try to fix it a.s.a.p.


I think we should not put the thin provisioning check here. InitialAllocation will return virtual_size if the sm_config does not contain the key "initial_allocation" (I think if the sm_config does not contain "initial_allocation" , then it is thick provisioned, so this case is covered).


Looks like only one person can code at upwork :)


:red_circle: The `getBooks` method should be called within the `Index` instance.


Thanks :)