It seems to be that if mpv.desktop is used then an ext. profile cannot override the force-window=yes set by the .desktop. Doesn't really matter if that's done by pseudo-gui or by prior method of setting force-window in the .desktop
(I removed pseudo-gui from code, same result
Only when there is no force-window option set by the .desktop will an ext. profile option work.
This justs comes from some users commenting that when opening a playlist file for online streams & there is an issue or slow to buffer  there's no indication that mpv is running.
Overall I can't see the point of force-window=immediate from cli, it just obscures the terminal. It's limited value, if any, seems to be from gui opening(s)


I start reviewing your stuff, I'll review all your commits one-by-one. This one is ok :+1:


Code Smell : Duplicated Code
Could have used a loop to generate the given requirements.


@jfalcou Does it is implemented in a later version?


By gui openings I mean only for certain files (online stream playlists), for local files  the option is pretty much worthless & can cause window placement issues.


Never use french for function name


else if is a smell code (kind of)


Movement should be with W,S,A,D keys.


素晴らしい！！


Avoid using Global variables


ok


Bad Practice . Its generally good to write functions on the top of the code after import statements .


too long methods.
Please splite in 8 line max (5 would be the best agreed to
https://robots.thoughtbot.com/sandi-metz-rules-for-developers
please adapt it for .js


forge url and link in separated functions


when there is var1 and var2 it mean that you need an array


Jump and other functions not implemented.


olon is not an understoodable variable name.
Please use real words in camel case


We should still do a forced update here, I think? (We are required to insert an "empty" value)


This is a very bad indentation please indent your file with ide - shortcut or plugin - before commit


ここの初期化追加しました。


Line length violated PEP 8 Standards https://www.python.org/dev/peps/pep-0008/#maximum-line-length
Not only here many time .. Must try to split them using '\'


use a function name with a real meaning


Line 69-77
Code Smell : Duplicated Code
Could have used a loop to generate the given requirements.


Line 79-88
Code Smell : Duplicated Code
Could have used a loop to generate the given requirements.


True, I though it was glxext.h.


Line 90-98
Code Smell : Duplicated Code
Could have used a loop to generate the given requirements.


Long Function
It can be broken down into smaller functions.


Instead of using values like 200 and 100 .. define some variables as limits and use them . Then code becomes readable and maintainable


Thanks.  Fixed.  New test here
http://tests.stockfishchess.org/tests/view/56080fef0ebc597e4f23e2e9


Line 142-151
Code Smell : Duplicated Code
Could have used a loop to generate the given requirements.


These should be a series of else-if statements rather than just "if" statements .


fgdgf


Oh whoops. Sorry, didn't see that. Well, either way, it's back now! :P


Code Smell : Cyclomatic Complexity
Too many branches or loops; this may indicate a function needs to be broken up into smaller functions, or that it has potential for simplification.


more-eng-ref-corrections (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (1896 of 1896 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


No idea what it should do...


There should be a line gap at the start of every function . Not following PEP8 standards.


Hard coded levels, difficult to debug.


Much code is repeated like adding brick into the array.It can be done once.


No comments and documentation used in the above code . Use comments to mention about variables


Nah, I think that one will do great, we'll just need to make it a bit more brighter in Unity (transparent). We don't need to spend too much time on the game content, just do simple things and even it has some mistakes or whatever, that'll do for us :)


Give variables appropriate names so that reader can understand the code


I think the min possible score for HTTP security headers is -3 so this grading cannot work. It will not give any site the D grade at all.


{"soldiers":[


more-eng-ref-corrections (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1360 of 1360 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.36%25-green.svg)


white space required


mixed indentation. Better use a good text editor like sublime etc not vim :P


Finally. Now local repository fixed, git replaces the github desktop for mac in my computer.


Bug found : Player jumps on pressing ''w" key.


Elvileg most jó.


Nice try, but this only verifies that the HTTP status is 200 but not that the returned entity is a PNG file that is the same as the PNG file that you have in your project.


Queen is not in a cage.


Screen resolution does not fit standard screen size.


Discussion: https://groups.google.com/forum/?fromgroups=#!topic/fishcooking/GVdyWSWEpQY


Split code into functions and re-factor them so that it enhances re usability of the code


Game doesn't quit on pressing 'Q'


Bug found : Fireballs don't fall from the ladder.


Broken Ladders not implemented


These values no longer meaningful as they are superseded by Gradle.


Use variables instead of direct values so that modification of the code would be easy


What if the array is an rvalue?


Donkey teleports instead of moving.


Player can not move when jumping.


Yep, if it's an effect, that needs to be represented in the type, i.e. `Task`. Even in test code, to the extent possible.


Yeah, it makes me forget that I'm writing JavaScript for a while...

More seriously, I'm following [Vjeux's advice](http://blog.vjeux.com/2013/javascript/react-coffeescript.html)


Class names should normally use the CapWords convention.
PEP8 standards violated.


Already done! :-)


more colors not even used in code
only two colors used


Using Global variables should be avoided.


@jgarboza813 DWMR of Checkpoints #30 and #31. Good job all around. :+1:


Если ошибиться в параметрах, приложение вылетает


The present LMK minfree values are the CM defaults, but it's possible that they're too high, particularly given that the adaptive LMK will kill lower adj things when thrashing is detected. I'll look into it when I get time. The defaults seemed alright for me, but LMK almost never kills anything on my device, even when I have a bunch of apps doing a bunch of things in the background.

You seem to be having far far far more low memory issues than I ever had on osprey. I do highly recommend that you try my unofficial builds to see if they behave any differently. You can back up your present state and restore it after you're done trying it out. I just want to know if the kernel and zRAM configuration differences are significant, or if you and your device just don't get along on CM.


The import wasn't used? Weird, I normally check unused imports


Nice


Large Function
It can be broken down into smaller functions.


We should not write before commit... I think...


Not necessary, I'd rather you didn't add it


Why the indentation change? Did you add a tab?


Recomiendo que los archivos de conexión no se modifiquen, no sabemos las repercusiones que puedan tener en otros archivos. Sí, la interfaz que se usa está obsoleta, hace un buen rato salió mysqli, sin embargo no podemos hacer estos cambios porque tendríamos que verificar que todo el proyecto está en el mismo estado. Estas advertencias las podemos configurar en nuestro apache ya sea si estamos usando XAMPP o WAMPP para levantar los servicios.

Una pregunta, ¿cón qué versión de scripts se está trabajando? ¿De dónde salieron? Me parece que el script más incluye está solución.


Предпочитаю тогда уже просто "promo".


@benzakour Pour avancer sur `RoomTest` j'ai été obligé de modifier un peu ton code :-/ La classe `Door` n'avait plus besoin du troisième paramètre (`locked`) qui est géré par la classe `LockedDoor`.


No. of characters in a  line should not exceed 79 . Not following PEP8 standards.


game booster time & install mode value would be other, this is temp atm... I tried in a unique file all values, but I had problems with game booster values and grep stucks at comparing stuff... My experience is limited :x


Much dead code present.


Мне не очень нравится такая рекомендация без объяснения причин. У меня эта обертка используется, чтобы при добавлении большой картинки верстка не развалилась. Зачем ее убирать?


Line 37-41 45-50 53-58
Code Smell : Duplicated Code
The same could be easily implemented with the help of a list that iterates over the given data and generates the given requirements.


Ок, logo и logo__item есть.


hello this is my first repository....


Try not to use many if's in your code.


The split has added more to type for the default case, unfortunately. If we can come up with a good name for:

* [ ] Classes with toString(), hashCode() and equals() - basically lang.Generic semantics
* [ ] Classes with toString(), hashCode() and compareTo() - basically, lang.Value semantics

...we could add these as aggregates of the above.


Сделал promo__image


more-eng-ref-corrections (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1896 of 1896 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The below function doesn't add any functionality ->code smell It is just a wrapper.


-fixed wrong length calculation
-don't stop client connection


Use communicative variable names


Не, не, у меня этот блок text универсальный и используется в разных местах.
1. Под хеадером
2. Возле кнопки Найти гостиницу
3. В заголовке блога
4. В заголовке поста.

Какой смысл мне делать несколько одинаковых по функциональности блоков.


A commit should be a single logical modification. You did many here:
  - fix the dependencies
  - replace numerical constants with named ones
  - style changes

As you did three modifications, this should be three separate commits.

As for the style modifications (indentation, spacing, explicit container types...), unless we talk about it and apply the modification to the whole project, I would prefer that you avoid applying them. However, if you find a line of code that is inconsistent in style with the rest of the project, feel free to correct it.


You check for same type in gexpr and not here?


Затем, что используется универсальный блок text, а в этом единственном месте шрифт 30px. Поэтому, чтобы не создавать новый блок просто добавил модификатор.


Sanjay Yadav commit for R Programming course


 I would recommend tap to keep using symlink, which is more robust. So you probably want:
```sh
sudo rm -rf /usr/local/Library/Taps/homebrew/homebrew-php/
sudo chown -R $USER /usr/local
brew tap homebrew/dupes
brew tap homebrew/versions
ln -s $PWD $(brew --prefix)/Library/Taps/homebrew/homebrew-php
cd /usr/local/Library/Taps/homebrew/homebrew-php
export TRAVIS_BUILD_DIR="/usr/local/Library/Taps/homebrew/homebrew-php"
env | grep TRAVIS_
if [ -f ".git/shallow" ]; then travis_retry git fetch --unshallow; fi # only needed for possible future bottling
```


Game.py is very large .
It can be broken down into smaller modules.


Not perfect, as everything has to be duplicated on the EFI partition, since syslinux doesn't seem to support booting images not on the same filesystem.

GRUB does, however. Might re-do this patch with GRUB similar to how the Fedora Live ISOs work.


Параграф ок, но оставил content, так как оставил text для названия блока.


Watch the indentation


Got your commit!


First commit msg


This file is now executable (0755 instead of 0644)


#38 another problem found


This commit could be merged with the previous one. And "." is not an acceptable commit name.


Oh, I totally forgot we had to do this...

-[Unknown]


Cordova vibrate plugin has been udpated and it's no longer under "notification"


You do an intermediate evaluation?


you really should rename your repo to `ng2-playground`


Biggest update for now!


`--tap=homebrew/php` may still be required.


2 lines should be left blank between Class and first method.
PEP8 standards violated.


Это можно сделать и через первую обертку, не обязательно делать их две


this is under ES5 when it should be under traceur


Person class written twice -> Code Smell


@gdi2290 my bad, I read ES6 :)


По внешнему виду эти блоки повторяются только в шапке блога и поста. И даже если ты придумал использовать их где оо ещё, то название text слишком универсальное и непонятно что это вообще за блок


This is exactly equivalent to:

```java
for (Block b : blocks)
{
   ...
}
```

I prefer the `for` syntax because it is both shorter and clearer.


Nem jó, hibaüzenet sincs, egyből kilép.
A telepített rendszerem próbálgatom.


Ок, но я назвал details.


Тогда уж fz30 это принятое сокращение для fonr-size


Global variables should be avoided.


I think I will, maybe even a different name. Just couldn't come up with something better at that point.


`other.size()` is not enough?


Functions should have been written in classes i.e jump, check_wall should have been written in player class


Coding style: the braces are on the next line.


Watch the trailing whitespace


Neste commit realizei algumas melhorias e correções:

- Correção do arquivo /app/config/ database.php
 O arquivo não estava sendo enviado com 'git clone'

- Correção do campo de login
Modifiquei a propriedade 'type'  do campo de login do formulário de acesso ao painel de controle. Originalmente era 'email' e mudei para 'text' pois agora pode-se fazer login usando o nome de usuário ou o email.

- Correção no redirecionamento do cadastro do primeiro usuário
Na última atualização passou despercebido um erro de redirecionamento no setup do cms, quando se criava o primeiro administrador o usuário esta sendo redirecionado para um link inexistente, isso foi corrigido neste commit.

- Comentários na classe setup()
Como a documentação do wpanelcms praticamente não existe, estou comentando as classes pouco a pouco para facilitar na compreensão e utilização.

- Correção do menu responsivo no site de exemplo
No site de exemplo o menu não estava funcionando corretamente no modo celular, consertei isso neste commit.

- Limpeza na pasta assets
Havia ficado uns arquivos antigos e não utilizados na pasta 'assets' e removi neste commit.


Да, что-то я разошелся


This is two separate modifications, so it should be two commits.


Why not using autofor here?


:+1: I'm the author, don't hesitate to contact me on the Bottleneck Gitter channel if you have any questions or comments.


And here


ок


So, after discussing this on the phone - the problem is that BASH doesn't like CRLF. To address only this specific problem we need "/jsc eol=lf" in gitattributes. I suspect we will have to add more settings later (e.g. "text", etc).


ya a better name would be awesome. @pkozlowski-opensource kinda owns all the `ng2-play` repos


Here too.


Nice use of random levels and random turning of donkey.


Unnecessary ;


Invalid name x and y


This is what you are doing when running this script:
1. view file
2. how many lines are there
3. how many characters are there
4. removes all punctuation
5. removes upper case
6. convert all of the Windows CRLF line endings to the LF line endings that characterize Linux and OS X files
7. gives us a file where each word is on its own line
8. sort that file so the words are in alphabetical order
9. file where the words are listed alphabetically, each preceded by its frequency


Don't use 'l' as a variable name instead use 'L' in your code.


Does it mean that I just have to flash the unofficial kernel? No need to flash system.img?


Unused sys,re,os
Unused import from wildcard import (unused-wildcard-import)


I dont think there will be any difference...
curly braces will be needed for example in that case:
http://stackoverflow.com/questions/8748831/bash-when-do-we-need-curly-braces-in-variables

but if we want to be able to grep for all the occurrences, maybe it will be better to decide for the curly version and use it everywhere...


Report's functionality should be as self-contained as possible and do no processing outside of it.

For example, `if ( !$report->report_post_exists( $no ) )` and `if ( $report->report_post_isSticky( $no ) )` should be relocated to be processed automatically inside the class.

To see a better example in action, look at Captcha in Regist which does no processing other than if it returned valid (from the class).

Also this shouldn't be in imgboard at all, especially if it's such an edge case. This needs to be redone.


I'm not sure how much the map was to blame. Most likely the inefficiency was mostly caused by the rewriting  of output per compilation unit. The main problem I had with with that map was it being global, which also got in the way of parallelization. Turns out I don't need to parallelize for now though, as code performs very well for me now.


Missing Doctring


Добавил:


Writing block comments is a good practice.


Should use different folder for media objects


Wrong Indentation


Unused wildcard import


Unused wildcasd import


Unused Wildcard Import


Invalid Name


> is it possible for t2 == t to be true?

Yes, it happens quite often.  Consider 06:00 AM in New York on the spring-forward day (e.g. 2015-03-08.)  Since UTC transition time is 07:00 AM, local(t)  - t gives you STD offset of -5h and the first guess, u1 corresponds to 11:00 AM UTC which is after the transition and maps to 07:00 AM DST.  Now, b is the offset after the transition (-4h) and our second guess u2 corresponds to   06:00 AM - (-4h) = 10:00 AM UTC and maps to  06:00 AM DST thus giving us the solution.

To summarize

  * t ~ 06:00
  * a ~ -5 hours
  * u1 = t - a ~ 11:00
  * t1 ~ 07:00
  * b ~ -4 hours
  * u2 = t - b ~ 10:00
  * t2 ~ 06:00

In general, this situation occurs in timezones "west of UTC" in the interval of the size of the UTC offset (STD?) right after the spring-forward transition.  (The algebra should be straightforward, but I find arithmetics more convincing.:-)


Using global variables leads to loss of encapsulation.


@gdi2290 just moved the repo under Traceur.


Repetitive Codes, should have used a function


We should not check the `buffer` instead?


Repetitive codes, should have used a function


s0 -> s1?


Long Line


You don't check if it is contains?


Very long class


You revert your previous commit?


Вот с заменой icons на features мало что понял. Типа идея, что использовать ту же сетку, что и для features-row? Ну они же вроде разные по стилизации...

И почему ```feature feature--icon feature--icon-house```? Почему вначале название блока, а не элемента? Вообщем с этим блоком icons не понял пока что. Нужно объяснение.


@brettwooldridge mind doing a 2.4.2-rc1 or the like? I'd really like to remove an error-prone patch, yet understand if you're hesitant to call 2.4.2 done.


By clicking on the PayPal link the donor was directed to the wrong link and so the error occurred.


BUGS: On quitting game pygame.error: display Surface quit


Wrong name


Oops. Fixed now. Thanks.


Ок, тут понятно, укоротил название.


make changes


Тоже надо пояснение, у меня здесь блок универсальный text + блок details для "Позавчера" и "Проишествия"


you only check for pointer to gexpr and not for pointer to raw data buffer?


width и height - задаются в css, center - устаревший тег. А за использование инлайновых стилей в комите нужно бить по рукам.


Not implemented correctly. We had to implement 4 steps in the jump. In this version, you can change direction whenever you want and there are many steps in the jump


Тут ок, перенес.


You revert here too?


Returns error at global jj = 5*k as this cannot be done.


@jlhanl DWMR (done with my review). Good good.


nit: lets use single quotes (') everywhere, for consistency


ditto


venga!
On Sep 27, 2015 6:36 AM, "sandstrom" <notifications@github.com> wrote:

> [image: :heavy_check_mark:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/torvalds/linux/commit/1da177e4c3f41524e886b7f1b8a0c1fc7321cac2#commitcomment-13455751>
> .
>


a small comment on what this class will provide


a small docstring on what this class will provide pls


This is only a flag, so it could fit in a `bool` (to be very descriptive) or `uint8_t` (to prevent the compiler coercing values to true/false).


@jlhanl DWMR. Complete! Press on.


Exit on q not implemented


This seems strange to me.  There is one new flag, but it controls two different things.

1. It controls whether the status bar / cockpit modes show the unlabeled [cloak](#diff-0d2b598e75d717b25fdb6f0dedb912acR1922) / [invulnerability](#diff-0d2b598e75d717b25fdb6f0dedb912acR2433) indicators.
1. It controls whether the modes that have always had an indicator will use the more verbose mode I added 3 years ago in [Show cloak/invulnerability time remaining on HUD](https://github.com/dxx-rebirth/dxx-rebirth/commit/88ec115c3818d808c51379d583075517f0cae495).


The following could also be a problem with the old code.
If `hislen==1` and `hisidx[history_type]==0` the old code would iterate two times for only one history entry:
* `hist_iter(NULL,...,false, &entry)` returns `hstart`, `entry = *hstart`
* `hist_iter(hstart,...,false, &entry)` returns `NULL`, `entry = *hstart`

New code:
* `hist_iter(NULL,...,false, &entry)` returns `NULL`, `entry = *hstart`


Queen is not present in a cage.


Modularity not implemented at all


That fixes https://github.com/awesomeWM/awesome/issues/471, right?


Should we add a test(s) for ThriftMessageFile?

Also, I think ThriftFile should just be called File, since it's only about reading files efficiently and it has nothing to do with Thrift per se.

And then, ThriftMessageFile should just be called ThriftFile given it can have many messages.


Ye они же идентичне и отличаются только темс что у них нет номера, но есть иконки.

feature - базовый класс
feature--icon - класс по которому мы задаем паддинг сверху и вставляем псевдоэлемент, который будет содержать иконку
feature--icon-house - указываем размер иконки и адрес иконки. Это все на первой строке


No OOP implemented ( Modularity, Abstraction etc )


@HashBang173  https://github.com/MotoX-2015/android_device_motorola_clark/blob/cm-12.1-booting/fstab.qcom
use 'git mv fstab.qcom rootdir/fstab.qcom'


здесь тоже самое что на странице блога, очень универсальное название не понятно, что это за блок по его названию


BUG : Player falls from the second platform.


Doesn't quit on pressing "Q"


There should be space before and after a comma( , ) operand.Not following pep8 standards.


None of the functions asked are present
The functions getPosition(), checkWall(), checkCollision() and collectCoin() not present.


Actually, game doesn't meet any of the basic requirements


You are right.  Fixed in f40c3e99629eaa9e7de43f3088a2eb494f78e26d.


I think, '\' can be avoided


Hard code of dimensions directly..Its better to remove them and use limits as variables and use them here . It improves re-usability of code so that it can be extended to any dimensions.


Ааа, понял, я попутал с версткой этого блока на главной.
Тут все ок, согласен.

Исправил так:
```
<div class="promo">
      <img class="promo__image" src="img/label-middle.png" width="458" height="78" alt="">
</div>
```


Bah, hab ich doch einige noch Übersehen, wobei ich hauptsächlich mit Search & Replace gearbeitet habe.

Sind allerdings die leeren Zeilen am Ende gewollt?


Movement should be with W,S,A,D keys.


Попробовал добавить элемент в возвращаемый массив


Hi Francois, could you please send me your email address, as I'd like to add you as a Podam contributor.


What's the reason for this being public? Surely it's better to access it all the time via the specific getter method?


amended into this commit: https://github.com/HashBang173/android_device_motorola_clark-1/commit/fb6c21b84a9ed1adce55e99d42210f671bdcfd26


Many irrelevant functions written in Parent class. Many of these functions are not required for Donkey class . So better to write them in Players class . Also many unnecessary variables are defined in parent class. These are not required for Donkey class. So better to remove them here  and include them in Players class


NOTE: This code is temporary.  I was experimenting, but I think defining these things as polygons with origins is going to be better.  It also means that Ships/asteroids/etc all have the same underlying representation.


not sure it this is valid in python. but it works.


This should probably be moved to an "additional tar arguments" argument


Instead of using fixed values like 79 32 etc define them as variables in class and use those variables as limits so that the code becomes maintainable.


coin should not be on the wall.


Да, в шапке блока и поста с модификатором text__title--fs30 (размер заголовка 30px). А с размером заголовка 18px повторяются под шапкой на главной странице "Седона - небольшой городок в..." и с размером заголовка 21px прямо над кнопкой Найти гостиницу. То есть идеально подходит с использованием модификатора размера заголовка.

По поводу названия: да, можно что-то и другое, но из красивого пока только text придумал) Было text-block, но это итак block, поэтому сократил. Есть идеи?


Это ок, исправил


@AnriShitko


Ок


It should be obvious without algebra: the only reason our first guess can fail is when utc offset changes between t and t - a (in UTC) which means a != b.  I kind of knew that from the start, but when I saw a == b happening due to a bug elsewhere, I added defensive code. :-(


DSTU1 FHIR libraries (found at http://www.nuget.org/packages/Hl7.Fhir) are used to connect to DSTU1 servers like : http://fhirtest.uhn.ca/baseDstu1


The reason is that `__init__` gets called multiple times during precompilation. `@guard` is a hack – I just happened to notice that the first time `__init__` gets called, it gets called in the context of `Main`, followed by the context of whatever the dependent package is. Would be great to come up with a better way to make sure requires only get called once, though.


PEP standards violated in naming methods .
1. https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables

2. https://www.python.org/dev/peps/pep-0008/#function-names

 Method Names and Instance Variables

Use the function naming rules: lowercase with words separated by underscores as necessary to improve readability.

Use one leading underscore only for non-public methods and instance variables.


line must not contain more then 79 characters.


This had to be destroyed because I created a category:string attribute in my photo model that caused an invalid fixture error when I associated belongs_to :category in said model.


thanks :heart:


Deu certo.


Could a snippet be added to give an example of the changes required?


Do we run this on digital ocean's machine or on a local machine?


Many of the functions must be implemented in the classes as it was the main objective of the assignment


Die Leerzeilen sollten eigentlich keine Auswirkungen haben.

Für die Ersetzungen von zeugs bleibt aber noch genug zu tun, ist momentan auch nur teilautomatisch.


haha this probably explains a lot @hlee


still don't work... let me fix it


I'm all for replacing `#gsub` with `#strip`. Pull request has been updated.

But there is an issue with this union idea. There are 17 domains in original `vendor/disposable_emails.yml` that has some white space characters. That's what makes union operation contain duplicated values(with and without white space characters).

Example: https://github.com/lisinge/valid_email2/pull/32/files#diff-c7efa0bc492423b84dc09c1d12bea069L91


Интересное приложение с достаточно сложной реализацией. Я думаю что для полноты проекта не хватает привязки к электронному кошельку.


民权运动的若干理论基础


Added proper association


It makes sure that you fill the screen.

Without this commit, you can keep on zooming out until the minHourHeight is reached, but it's possible that you then have 12PM in the middle of your screen and then a blank space. Therefore the "effective" minHourHeight is used, but it can only be measured on view time, thats why it has to be stored in a temporary state mNewHourHeight until the view is redrawn.


association test that passes


One difference between the two is that WiFi is in a separate kernel module in the unofficial builds, while it's built in to the kernel in the official builds. As a result, if you flash the boot.img from an unofficial build while running the system from an official build, WiFi won't work.

What you can do is either do a clean install of an unofficial build (back up your present state so that you can go back once you are done testing), or the easier option would be to wait for me to release my kernel as a standalone zip for osprey that can be flashed on top of official builds. I've been a bit busy this week but I hope to have it ready either tonight or tomorrow.


It's on both, by spinning up the command below `docker-compose up` will spin up an instance on digital ocean for sure, I think it was also on local machine too.

I'll confirm later when I have chance.


Same code is written twice can be split into functions to enhance re-usability of code


Exactly one space required after comma


Ok, köszi.
Most az van, hogy ha a live mód van kiválasztva, akkor egy hibaüzenet után visszaáll a normál módra.
Magyarul nem engedjük aktiválni a live módot.
Gány módszer, de egyelőre ez van.
Működik, de nekem valamiért nem működik a gettext...


Exactly one space required after assignment


Consistency. See the lines surrounding it. I agree it makes more sense using getter and setter only.


PEP 8 standards violated. Maximum line length exceeded .https://www.python.org/dev/peps/pep-0008/#maximum-line-length Read about PEP8 standards try to follow them :P


Should use inheritance, polymorphism,modularity.


unnecessary function .. could call directly func(1,0) from code itself


@pikajude This commit and the previous one have broken several packages on (impure) Darwin for me.  By reverting them both, `global` is able to build again, for example.


Line too long, complicated condition, not easily readable.
Should have been broken down into simple conditions, could also have made it a method if it contained many conditions.


Unused import sys (unused-import)
Unused importPlatform (unused-import)
Unused import Ladders (unused-import)


Я все таки считаю что это независимый блок blog-intro, здесь и на странице поста, а для тех что в другом месте я бы придумал другие названия.


This will not integrate with all Mybb installations. Some users use different database structures and have different table prefixes instead of mybb_

Always use built in db functions to construct and execute queries.


This isn't the result we should expect: the action is "remove obsolete returns statement" and should do just that. That text outside of it should definitely stay.


It's better to put `"4"` here; Node is now adhering to semver & receiving minor updates pretty often; only the latest one is supported upstream.

When Node 4.2.0 comes out Protractor should be tested on it instead of 4.1.1.


Ок, сделал.


Local dll. You can just get the new one from NuGet though: https://www.nuget.org/packages/RoslynTester

v1.6.0 is already released


Excessively short identifiers, hard to understand the functionality of some variables.


yep


the regex:
![image](https://cloud.githubusercontent.com/assets/6675409/10124102/03d55e44-651a-11e5-9059-c68dcf9408ee.png)


Creating a custom data attribute wasn't necessary. D3's filter method allowed me to filter the array of bound data to return a specific element of the array.


I submitted a PR: #2543


size of player is very small.


I'll add test with a file annotation later.


Well its not working yet, dunno why but hey it will be someday :P


Excessive use of literals, in the following loop, variables could have been declared for better readability and understanding.
eg. since 2 is always the value of the step in "random.randrange()", it could have been stored in a variable so that the modification of the code becomes easier.


(convention)
```$labelWrapper```

we only use camel case in javascript. snake case is for ruby.


i've seen better


@wh1pch81n
Please code review.


PEP 8 Standards . Maximum line length exceeded


Das is gud.


Good.  This was Ambiguous


I suggest in the table MailAttachment to change the type of column Attachment to BinaryBlobType this good mapping to .NET Property Type  byte[]. In oracle db this is type BLOB.


I think I should add tests for the Factor class after getting this cleared.
Please look into it.


Duplicated code


OK


Fixed!


I know, I'm not too experienced with MyBB so this was the quick fix for me. I submitted it showing my quick fix, and to maybe show you that it isn't working as intended. Thank you for your reply though.


Probably should cache '#prev' and '#next' too.


Follow PEP Standards while writing function names and method names
https://www.python.org/dev/peps/pep-0008/#function-names


URLs


I want lines 3 to 6 to end in a period.  @wh1pch81n


var doesn't get minified. so all reserved keywords. It's a good habit to keep all declarations irrespective kind of assignment in a single var.


The problem is that there is no value over 100. You should know that. And don't trust samsung devs..


Yup.. It is on my To do List.. Have added you to the trello board


w ten sposób nie można wylosować maxPlanetSize
rand() % (maxPlanetSize - minPlanetSize + 1) + minPlanetSize


On master, I'm getting the new hash.


Fixed in 2.0.4


TeamCity pull requests :: netty [Build 314](https://garage.netty.io/teamcity/viewLog.html?buildId=1774&buildTypeId=pulls_netty&guest=1) is now running


You missed the `&` here.


DTSU2 FHIR libraries (found at https://www.nuget.org/packages/Hl7.Fhir.DSTU2) are used to connect to DTSU2 servers http://fhirtest.uhn.ca/baseDstu2


You can't see all the NPCs ingame, because the ingame console has a limit on how far you can scroll up.


@balloob I have not idea how to prevent this from coming up. :(

Any ideas?  other than this, the GIT Desktop is super easy to use for adding images directly into the Repo.


code smell : lazy class this class has only initialization which also can be in the other class itself.


try using lodash templates for this and for js strings made too.


Done with changes.  @wh1pch81n


PrivatePlanetInfo samo prosi się o jakiś domniemany konstruktor ;)


No function present to create the level dynamically. Hard coding fixed the level.
So no further levels implemented.


code smell: duplicated code used in getCoins method


code smell: duplicated code. All the if conditions have almost same functionality but at different positions on the display, so the positions can be sent as arguments to the function and decrease code redundancy.


TeamCity pull requests :: netty [Build 314](https://garage.netty.io/teamcity/viewLog.html?buildId=1774&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3 (3 new), passed: 3929, ignored: 12 Build time: 00:06:56
### Failed tests
```
io.netty.handler.codec.ReplayingDecoderTest.testSingleDecode: <no details avaliable>

io.netty.handler.codec.ReplayingDecoderTest.testLineProtocol: <no details avaliable>

io.netty.handler.codec.ReplayingDecoderTest.testReplacement: <no details avaliable>

```


@10se1ucgo what are you using to generate your wxPython GUIs? or are you hand-coding them?


Unnecessary declaration of private methods above, since they are just being called with the same parameters by the functions below.


This is wrong, it was right the way it was before. If anything needs to change, is the code that uses these two fields.


The reason is that it doesn't make sense to separate these two, both of them come together.


##

makeCacheMatrix <- function(x = matrix()) {
  m <- NULL
  set <- function(y) {
    x <<- y
    m <<- NULL
  }
  get <- function() x
  setSolve <- function(solve) m <<- solve
  getSolve <- function() m
  list(set = set, get = get,
       setSolve = setSolve,
       getSolve = getSolve)
}

##

cacheSolve <- function(x, ...) {
  m <- x$getSolve()
  if(!is.null(m)) {
    message("getting cached data")
    return(m)
  }
  data <- x$get()
  m <- solve(data, ...)
  x$setSolve(m)
  m
}


The transition in moving on ladder is not shown


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 27](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=201&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Docstrings not used.


I did an initial commit before this, where i had just all empty files. I committed it, but because of network issues couldn't push it. I tried pushing before committing this new changes, it didn't push anything, so i just recommitted everything and pushed all I have done.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 27](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=201&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:55


This refers to fields in the `PatientClass`. Since these two aren't fields in `PatientClass`, it was correct the way it was.

The whole concept of `fields`, as used by the `RecordConfiguration`, is wrong and needs to be reimplemented.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 28](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=202&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Many hard-coded values used.


bug : if the player reach the position on f(3rd floor in level 1)floor beneath which a broken ladder is present then he will down even if he doesn't press the down arrow key


this does not work for llvm 3.6, because VERSION_GREATER 3.6 is also true for e.g llvm 3.6.2
please change it to "NOT (${LLVM_STRING_VERSION} VERSION_LESS 3.7)"


Unnecesary Constant


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 28](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=202&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **SUCCESS**
Summary: Running Build time: 00:00:45


# Matrix inversion is usually a costly computation and there may be some benefit
# to caching the inverse of a matrix rather than compute it repeatedly. The
# following two functions are used to cache the inverse of a matrix.

#We have the following functions-
#makeCacheMatrix: This function creates a special "matrix"
#object that can cache its inverse.
#cacheSolve: This function computes the inverse of the special
#"matrix" returned by makeCacheMatrix above.
#If the inverse has already been calculated
#(and the matrix has not changed),
#then cacheSolve should retrieve the inverse from the cache.

makeCacheMatrix <- function(x = matrix()) {
  inv <- NULL
  set <- function(y) {
    x <<- y
    inv <<- NULL
  }
  get <- function() x
  setinverse <- function(inverse) inv <<- inverse
  getinverse <- function() inv
  list(set=set, get=get, setinverse=setinverse, getinverse=getinverse)
}

# The following function returns the inverse of the matrix. It first checks if
# the inverse has already been computed. If so, it gets the result and skips the
# computation. If not, it computes the inverse, sets the value in the cache via
# setinverse function.

# This function assumes that the matrix is always invertible.
cacheSolve <- function(x, ...) {
  inv <- x$getinverse()
  if(!is.null(inv)) {
    message("getting cached data.")
    return(inv)
  }
  data <- x$get()
  inv <- solve(data)
  x$setinverse(inv)
  inv
}


Bug :
Player sometimes jumps twice even on pressing the space bar once which makes the irritates the user.


#The first function, makeVector creates a special "matrix", which is really a
#list containing a function to set the value of the matrix,get the value of the
#matrix, set the value of the inverse, get the value of the inverse

makeCacheMatrix <- function(x = matrix()) {
    m<-NULL
    set<-function(y){
        x<<-y
        m<<-NULL
    }
    get<-function() x
    setinv<-function(inverse) m<<-inverse
    getinv<-function() m
    list(set = set, get = get,
         setinv = setinv,
         getinv = getinv)
}

#The following function calculates the inverse of the special cacheMatrix created
#with the above function. However, it first checks to see if the inverse has
#already been calculated. If so, it gets the inverse from the cache and skips
#the computation. Otherwise, it calculates the inverse of the data and sets the
#value of the inverse in the cache via the setinv function.

cacheSolve <- function(x, ...) {
    m<-x$getinv()
    if(!is.null(m)){
        message("getting cached data")
        return(m)
    }
    data<-x$get()
    m<-solve(data,...)
    x$setinv(m)
    m
}


@nihaozz 我写的命令不是完整测试过的，大概那个意思，需要一点的编程基础就能看懂（包括调试）。我真没有太多时间来跟大家逐一解释，抱歉 ；）


That's a good workaround. But it's just that my opinion (and we're probably
talking about two slightly different issues) is that a color scheme should
not modify the background color; it is the responsibility of the terminal
theme. Also, one shouldn't have to drop functionality in order to have the
same background in Vim that one has in their terminal (such as, as you say,
switching between light and dark during run-time, etc).

Disclaimer: my change isn't complete (yet) since it doesn't do all that
since I only modified the light theme when 256 color support is available.

On 27 September 2015 at 16:11, Asa Jay <notifications@github.com> wrote:

> I was thinking of implementing your change, but then I found this:
>
> *Alternative solution for your change*
>
> colorscheme kalisi
> highlight Normal ctermbg=NONE
>
> It's important to load the colorscheme before the ctermbg settings in
> .vimrc because they need to override the same ones set by the colorscheme.
> This also means you can't switch colorscheme while Vim is running and
> expect it to work.
> Found here:
>
> http://stackoverflow.com/questions/4325682/vim-colorschemes-not-changing-background-color
> by cptloop
>
> If this doesn't fix it, then here's another hint:
> If your term doesn't change its bgcolor back after closing vim, then I
> think you have a terminal configuration problem. At least my zsh inside
> mintty (xterm-256color) reverts back after closing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/enrdstrm/vim-kalisi/commit/c5340f696cee07d083e965da6b01b826bab5e722#commitcomment-13456612>
> .
>


Thanks for noticing it!

Added issue #38 and fixed it in release [v1.5.2 (https://github.com/gpapp/FreePlaneGTD/releases/tag/v1.5.2)


Keep in mind the unit tests will only work with versions >= 3


Is this intended or just a leftover?


^4.1.2 doesn't exist. Use ^4.1.0 instead.


Don't change the coding style. Please keep it consistent.


Bug : Must have printed score at the end of each life and at the end of game . Very bad. User gets disappointed if he cant view his score at the end of game.


jajaja vamos con fe con affine


Sorry, that's embarrassing.


Writing Doubly Linked List as defined by:

http://opendatastructures.org/ods-cpp.pdf


That is a feature I wanted to implement. I am sorry it was misleading and made you think it was a bug but I intended to show it as though the player falls of a broken ladder when he goes over it. Thanks for pointing out the misunderstanding though.


@darkcoderrises x , y are valid names.
http://pygame.org/project-Rect+Collision+Response-1061-.html


This will break compilation with (very) old versions of ffmpeg.
I don't know which version of ffmpeg introduced the new API, so maybe it's better to add a check for the ffmpeg version to detect which API to use...


Imported time twice.


This does not solve the issue on my Android 4.1.2. Why was this applied to lollipop+ devices?


code smell: Contrived complexity in this if block


"super-init-not-called" warning generated. This is generated when the ancestor class method has an __init__ method which is not called by the derived class.


Re importing 'sys'


# Cachematrix code

# Matrix inversion is usually a costly computation and there may be some benefit
# to caching the inverse of a matrix rather than compute it repeatedly. The
# following two functions are used to cache the inverse of a matrix.

#We have the following functions-
#makeCacheMatrix: This function creates a special "matrix"
#object that can cache its inverse.
#cacheSolve: This function computes the inverse of the special
#"matrix" returned by makeCacheMatrix above.
#If the inverse has already been calculated
#(and the matrix has not changed),
#then cacheSolve should retrieve the inverse from the cache.

makeCacheMatrix <- function(x = matrix()) {
  inv <- NULL
  set <- function(y) {
    x <<- y
    inv <<- NULL
  }
  get <- function() x
  setinverse <- function(inverse) inv <<- inverse
  getinverse <- function() inv
  list(set=set, get=get, setinverse=setinverse, getinverse=getinverse)
}

# The following function returns the inverse of the matrix. It first checks if
# the inverse has already been computed. If so, it gets the result and skips the
# computation. If not, it computes the inverse, sets the value in the cache via
# setinverse function.

# This function assumes that the matrix is always invertible.
cacheSolve <- function(x, ...) {
  inv <- x$getinverse()
  if(!is.null(inv)) {
    message("getting cached data.")
    return(inv)
  }
  data <- x$get()
  inv <- solve(data)
  x$setinverse(inv)
  inv
}


Why did I do this in the first place? Should it be CHASING?


More than one statement in a single line. Not according to PEP - 8.


oovo je test comment


Too much hard code.


Unnecessarily making the variable private


Reimporting and redefining 'sys' from outer scope. See line 2.


TeamCity pull requests :: netty [Build 315](https://garage.netty.io/teamcity/viewLog.html?buildId=1775&buildTypeId=pulls_netty&guest=1) is now running


Dont use global variables bad Practice


Code for Windows present uncommented in code for Unix.
Failed to import msvcrt (which is only for Windows) error.


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4059/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


Excessive use of literals, values have been hard coded, would have been easier to read and modify if variables were declared.
eg, 3 could have been stored in a variable and used while calling player.move() and player.jump()


All basic functionality implemented like moving , jumping , loosing life when hit by a fireball etc.


Doc strings are not present for the classes, methods, etc.
A few constants, variables names are invalid.
PEP 8 standards are not followed.


From this line onwards -
Error - Instance of 'Fireball' has no 'arr' member and yet 'arr' used many times.


@polyester could you please revert your commit. It broke the build:

http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3028/

It could be that p.a.linkintegrity is really responsible for this. When I made Plone 5 releases today I had problems with that package. It seems those tests fail somehow randomly, which is pretty bad. Though, we need to revert in order to confirm that your commit is not responsible.

@pbauer did you see those test failures before?


TeamCity pull requests :: netty [Build 316](https://garage.netty.io/teamcity/viewLog.html?buildId=1776&buildTypeId=pulls_netty&guest=1) is now running


Error - Instance of 'Fireball' has no 'pposx' and 'pposy' member.


Same as cvarlist. Just check qconsole.log.


Why did you change this?


Ineffective code.
Used == instead of =.


Layout function is to large.


i got err

[ERROR] Failed to execute goal on project statsfeeder-GraphiteReceiver: Could not resolve dependencies for project de.synaxon:statsfeeder-GraphiteReceiver:jar:1.0-IPM-3.5: Could not find artifact com.vmware.tools:vsphere-sdk:jar:4.1 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[root@server1 GraphiteReceiver]# cp target/GraphiteReceiver-1.0-SNAPSHOT.jar ../statsfeeder/lib

more details in attached

mine is rhel 6x box.


Inappropriate intimacy: class Player depends on class Board.


Line is too long


[root@server1 ~]# wget http://download3.vmware.com/software/vmw-tools/statsfeeder/StatsFeeder-4.1.697.zip
--2015-09-27 10:43:03--  http://download3.vmware.com/software/vmw-tools/statsfeeder/StatsFeeder-4.1.697.zip
Resolving download3.vmware.com... 184.30.179.47, 2001:4de0:4104:185::2ef, 2001:4de0:4104:186::2ef
Connecting to download3.vmware.com|184.30.179.47|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 5034561 (4.8M) [application/x-octet-stream]
Saving to: “StatsFeeder-4.1.697.zip”

100%[===========================================================================================================================================================>] 5,034,561   4.30M/s   in 1.1s

2015-09-27 10:43:04 (4.30 MB/s) - “StatsFeeder-4.1.697.zip” saved [5034561/5034561]

[root@server1 ~]#
[root@server1 ~]#
[root@server1 ~]#
[root@server1 ~]# mkdir statsfeeder
[root@server1 ~]# cd statsfeeder
[root@server1 statsfeeder]# unzip ../StatsFeeder-4.1.697.zip
Archive:  ../StatsFeeder-4.1.697.zip
   creating: sample/
  inflating: sample/pom.xml
   creating: sample/src/
   creating: sample/src/main/
   creating: sample/src/main/java/
   creating: sample/src/main/java/samples/
  inflating: sample/src/main/java/samples/SampleStatsReceiver.java
   creating: sample/target/
   creating: sample/target/classes/
   creating: sample/target/classes/samples/
  inflating: sample/target/classes/samples/SampleStatsReceiver.class
   creating: sample/target/maven-archiver/
  inflating: sample/target/maven-archiver/pom.properties
  inflating: sample/target/statsfeeder-sample-4.1.jar
   creating: sample/target/maven-status/
   creating: sample/target/maven-status/maven-compiler-plugin/
   creating: sample/target/maven-status/maven-compiler-plugin/compile/
   creating: sample/target/maven-status/maven-compiler-plugin/compile/default-compile/
  inflating: sample/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst
  inflating: sample/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
   creating: sample/target/surefire/
  inflating: sample/target/surefire/surefirebooter9072825976750451174.jar
   creating: tools/
  inflating: tools/start-tsdb.sh
  inflating: tools/tsdb-populate.sh
  inflating: tools/tsdb-create-table.sh
  inflating: tools/config-hbase.sh
  inflating: StatsFeeder.bat
  inflating: GetAllHostProps.bat
  inflating: StatsFeeder.sh
  inflating: GetAllHostProps.sh
  inflating: GetAllVMProps.sh
  inflating: GetAllVMProps.bat
   creating: doc/
  inflating: doc/README
  inflating: doc/Importing_StatsFeeder_output_files_to_Perfmon.pdf
  inflating: doc/open_source_licenses.txt
   creating: config/
  inflating: config/sampleConfig.xml
  inflating: config/logConfig.xml
  inflating: log4j.properties
   creating: lib/
  inflating: lib/vsphere-sdk-4.1.jar
  inflating: lib/log4j-1.2.8.jar
  inflating: lib/commons-logging-1.1.1.jar
  inflating: lib/commons-cli-1.2.jar
  inflating: lib/statsfeeder-common-4.1.jar
  inflating: lib/statsfeeder-props-4.1.jar
  inflating: lib/statsfeeder-core-4.1.jar
  inflating: lib/jaxrpc-api-1.1.jar
  inflating: lib/statsfeeder-perfmon-4.1.jar
  inflating: lib/statsfeeder-sample-4.1.jar
  inflating: lib/statsfeeder-main-4.1.jar
  inflating: lib/opentsdb-tools-4.1.jar
  inflating: lib/jetty-client-8.1.4.v20120524.jar
  inflating: lib/jetty-http-8.1.4.v20120524.jar
  inflating: lib/jetty-io-8.1.4.v20120524.jar
  inflating: lib/jetty-util-8.1.4.v20120524.jar
  inflating: lib/kairosdb-tools-4.1.jar
  inflating: lib/jackson-mapper-asl-1.9.12.jar
  inflating: lib/jackson-core-asl-1.9.12.jar
[root@server1 statsfeeder]#
[root@server1 statsfeeder]#
[root@server1 statsfeeder]#
[root@server1 statsfeeder]# cd ..
[root@server1 ~]# git clone https://github.com/SYNAXON/GraphiteReceiver.git
Initialized empty Git repository in /root/GraphiteReceiver/.git/
remote: Counting objects: 218, done.
remote: Total 218 (delta 0), reused 0 (delta 0), pack-reused 218
Receiving objects: 100% (218/218), 61.49 KiB, done.
Resolving deltas: 100% (57/57), done.
[root@server1 ~]#
[root@server1 ~]#
[root@server1 ~]#
[root@server1 ~]# cd GraphiteReceiver
[root@server1 GraphiteReceiver]# mkdir -p ~/.m2/repository/com/vmware/tools/statsfeeder-common/4.1
[root@server1 GraphiteReceiver]# mkdir -p ~/.m2/repository/com/vmware/tools/statsfeeder-core/4.1
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]# cp ../statsfeeder/lib/statsfeeder-common-4.1.jar ~/.m2/repository/com/vmware/tools/statsfeeder-common/4.1
[root@server1 GraphiteReceiver]# cp ../statsfeeder/lib/statsfeeder-core-4.1.jar ~/.m2/repository/com/vmware/tools/statsfeeder-core/4.1
[root@server1 GraphiteReceiver]# Install Maven :)  Maybe with
-bash: syntax error near unexpected token `)'
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]# yum --disablerepo="*" --enablerepo="synaptics-linux-stable" install  maven
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
No package maven available.
Error: Nothing to do
[root@server1 GraphiteReceiver]# yum --disablerepo="*" --enablerepo="epel" install  maven
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
No package maven available.
Error: Nothing to do
[root@server1 GraphiteReceiver]# yum --disablerepo="*" --enablerepo="epel" install  maven*
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
No package maven* available.
Error: Nothing to do
[root@server1 GraphiteReceiver]# yum --disablerepo="*" --enablerepo="synaptics-linux-stable" install  maven*
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
No package maven* available.
Error: Nothing to do
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]# sudo wget http://repos.fedorapeople.org/repos/dchen/apache-maven/epel-apache-maven.repo -O /etc/yum.repos.d/epel-apache-maven.repo
--2015-09-27 10:47:44--  http://repos.fedorapeople.org/repos/dchen/apache-maven/epel-apache-maven.repo
Resolving repos.fedorapeople.org... 152.19.134.196, 2610:28:3090:3001:5054:ff:feff:683f
Connecting to repos.fedorapeople.org|152.19.134.196|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://repos.fedorapeople.org/repos/dchen/apache-maven/epel-apache-maven.repo [following]
--2015-09-27 10:47:45--  https://repos.fedorapeople.org/repos/dchen/apache-maven/epel-apache-maven.repo
Connecting to repos.fedorapeople.org|152.19.134.196|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 445
Saving to: “/etc/yum.repos.d/epel-apache-maven.repo”

100%[===========================================================================================================================================================>] 445         --.-K/s   in 0s

2015-09-27 10:47:45 (22.3 MB/s) - “/etc/yum.repos.d/epel-apache-maven.repo” saved [445/445]

[root@server1 GraphiteReceiver]# sudo sed -i s/\$releasever/6/g /etc/yum.repos.d/epel-apache-maven.repo
[root@server1 GraphiteReceiver]# sudo yum install -y apache-maven
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
epel-apache-maven                                                                                | 2.4 kB     00:00
epel-apache-maven/primary_db                                                                                | 3.1 kB     00:00
Resolving Dependencies
--> Running transaction check
---> Package apache-maven.noarch 0:3.2.5-1.el6 will be installed
--> Finished Dependency Resolution

Dependencies Resolved

=====================================================================================================================================================================================================
 Package                                         Arch                                      Version                                        Repository                                            Size
=====================================================================================================================================================================================================
Installing:
 apache-maven                                    noarch                                    3.2.5-1.el6                                    epel-apache-maven                                    7.5 M

Transaction Summary
=====================================================================================================================================================================================================
Install       1 Package(s)

Total download size: 7.5 M
Installed size: 8.9 M
Downloading Packages:
apache-maven-3.2.5-1.el6.noarch.rpm                                                                                | 7.5 MB     00:01
Running rpm_check_debug
Running Transaction Test
Transaction Test Succeeded
Running Transaction
  Installing : apache-maven-3.2.5-1.el6.noarch                                                                                1/1
  Verifying  : apache-maven-3.2.5-1.el6.noarch                                                                                1/1

Installed:
  apache-maven.noarch 0:3.2.5-1.el6

Complete!
[root@server1 GraphiteReceiver]# mvn package
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building statsfeeder-GraphiteReceiver 1.0-IPM-3.5
[INFO] ------------------------------------------------------------------------
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom (8 KB at 12.7 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom (9 KB at 219.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/22/maven-parent-22.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/22/maven-parent-22.pom (30 KB at 744.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/11/apache-11.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/11/apache-11.pom (15 KB at 535.7 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.jar (29 KB at 670.4 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.pom (8 KB at 198.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/18/maven-plugins-18.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/18/maven-plugins-18.pom (13 KB at 276.0 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/16/maven-parent-16.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/16/maven-parent-16.pom (23 KB at 733.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/7/apache-7.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/7/apache-7.pom (15 KB at 469.7 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.jar (29 KB at 814.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.pom (11 KB at 208.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.12.4/surefire-2.12.4.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.12.4/surefire-2.12.4.pom (14 KB at 448.9 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.jar (30 KB at 874.9 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.pom (6 KB at 219.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom (13 KB at 410.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom (26 KB at 715.0 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom (15 KB at 370.6 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.jar (34 KB at 922.9 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/com/vmware/tools/statsfeeder-core/4.1/statsfeeder-core-4.1.pom
[WARNING] The POM for com.vmware.tools:statsfeeder-core:jar:4.1 is missing, no dependency information available
Downloading: https://repo.maven.apache.org/maven2/com/vmware/tools/statsfeeder-common/4.1/statsfeeder-common-4.1.pom
[WARNING] The POM for com.vmware.tools:statsfeeder-common:jar:4.1 is missing, no dependency information available
Downloading: https://repo.maven.apache.org/maven2/com/vmware/tools/vsphere-sdk/4.1/vsphere-sdk-4.1.pom
[WARNING] The POM for com.vmware.tools:vsphere-sdk:jar:4.1 is missing, no dependency information available
Downloading: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.pom
Downloaded: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.pom (18 KB at 245.7 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/5/commons-parent-5.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/5/commons-parent-5.pom (16 KB at 447.6 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/4/apache-4.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/4/apache-4.pom (5 KB at 121.9 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/com/vmware/tools/vsphere-sdk/4.1/vsphere-sdk-4.1.jar
Downloading: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.jar
Downloaded: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.jar (60 KB at 1234.7 KB/sec)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.378 s
[INFO] Finished at: 2015-09-27T10:48:39-07:00
[INFO] Final Memory: 10M/107M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project statsfeeder-GraphiteReceiver: Could not resolve dependencies for project de.synaxon:statsfeeder-GraphiteReceiver:jar:1.0-IPM-3.5: Could not find artifact com.vmware.tools:vsphere-sdk:jar:4.1 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[root@server1 GraphiteReceiver]# cp target/GraphiteReceiver-1.0-SNAPSHOT.jar ../statsfeeder/lib
cp: cannot stat `target/GraphiteReceiver-1.0-SNAPSHOT.jar': No such file or directory
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#


This was a really small commit @xzhangpeijin


Too many branches and statements.
Code to be refactored to be modularized and distributed.


This worked for me,
Thanks!


Interestingly enough, a ALIEN_PLAYER_RATIO 5 would still restrict the crew


Unused variables __ax, __ay


Unused variable __dx, __dy


Just a leftover. This is still work in progress.


Pylint showed this error


Getting the new one, too.


Unused variables __tx, __ty


done.


__init__ method from base class 'Player' is not called (super-init-not-called) warning.


`computeContoursKernel` 实现有错：
`int x_left=max(0,x-1),x_right=min(x-1,src.cols),y_top=max(0,x-1),y_down=min(x-1,src.cols);`
`impaintKernel` 拼错；实现完全错。


Please invert the condition and turn the parameter a positive way, a good candidate would be : allow_upscale


My example uses only one loop (a) and the `// ...` is where you would free the item (b), not to say it's _the_ way to solve the problem (remember I wrote it after being awake for only 5 minutes :). I disagree that we should obscure common idioms behind macros. If it was really that useful, it should be submitted to GLib for inclusion upstream, where it'll at least get a descriptive name and a namespace prefix so it doesn't spam the global namespace. Is the next macro going to be like `#define foreach_index(arr, ind) ...`? :)

Anyway, if we're keeping it, it should at least not crash when the queue is empty. It would also be nicer to give it some name prefix, so a plugin using some other library that defines `foreach_whatever` won't clash, and why not make it more generic so it works with `GList` and `GSList` as well, so we don't need 3 macros doing pretty much the same thing?


TeamCity pull requests :: netty [Build 315](https://garage.netty.io/teamcity/viewLog.html?buildId=1775&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 3929, ignored: 12 Build time: 00:06:50
### Failed tests
```
io.netty.handler.codec.ReplayingDecoderTest.testSingleDecode: <no details avaliable>

io.netty.handler.codec.ReplayingDecoderTest.testLineProtocol: <no details avaliable>

io.netty.handler.codec.ReplayingDecoderTest.testReplacement: <no details avaliable>

```


I have a rhel 6x box on which i tried above, Please suggest on  the err i got

[root@server1 ~]# wget http://download3.vmware.com/software/vmw-tools/statsfeeder/StatsFeeder-4.1.697.zip
--2015-09-27 10:43:03--  http://download3.vmware.com/software/vmw-tools/statsfeeder/StatsFeeder-4.1.697.zip
Resolving download3.vmware.com... 184.30.179.47, 2001:4de0:4104:185::2ef, 2001:4de0:4104:186::2ef
Connecting to download3.vmware.com|184.30.179.47|:80... connected.
HTTP request sent, awaiting response... 200 OK
Length: 5034561 (4.8M) [application/x-octet-stream]
Saving to: “StatsFeeder-4.1.697.zip”

100%[===========================================================================================================================================================>] 5,034,561   4.30M/s   in 1.1s

2015-09-27 10:43:04 (4.30 MB/s) - “StatsFeeder-4.1.697.zip” saved [5034561/5034561]

[root@server1 ~]#
[root@server1 ~]#
[root@server1 ~]#
[root@server1 ~]# mkdir statsfeeder
[root@server1 ~]# cd statsfeeder
[root@server1 statsfeeder]# unzip ../StatsFeeder-4.1.697.zip
Archive:  ../StatsFeeder-4.1.697.zip
   creating: sample/
  inflating: sample/pom.xml
   creating: sample/src/
   creating: sample/src/main/
   creating: sample/src/main/java/
   creating: sample/src/main/java/samples/
  inflating: sample/src/main/java/samples/SampleStatsReceiver.java
   creating: sample/target/
   creating: sample/target/classes/
   creating: sample/target/classes/samples/
  inflating: sample/target/classes/samples/SampleStatsReceiver.class
   creating: sample/target/maven-archiver/
  inflating: sample/target/maven-archiver/pom.properties
  inflating: sample/target/statsfeeder-sample-4.1.jar
   creating: sample/target/maven-status/
   creating: sample/target/maven-status/maven-compiler-plugin/
   creating: sample/target/maven-status/maven-compiler-plugin/compile/
   creating: sample/target/maven-status/maven-compiler-plugin/compile/default-compile/
  inflating: sample/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst
  inflating: sample/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
   creating: sample/target/surefire/
  inflating: sample/target/surefire/surefirebooter9072825976750451174.jar
   creating: tools/
  inflating: tools/start-tsdb.sh
  inflating: tools/tsdb-populate.sh
  inflating: tools/tsdb-create-table.sh
  inflating: tools/config-hbase.sh
  inflating: StatsFeeder.bat
  inflating: GetAllHostProps.bat
  inflating: StatsFeeder.sh
  inflating: GetAllHostProps.sh
  inflating: GetAllVMProps.sh
  inflating: GetAllVMProps.bat
   creating: doc/
  inflating: doc/README
  inflating: doc/Importing_StatsFeeder_output_files_to_Perfmon.pdf
  inflating: doc/open_source_licenses.txt
   creating: config/
  inflating: config/sampleConfig.xml
  inflating: config/logConfig.xml
  inflating: log4j.properties
   creating: lib/
  inflating: lib/vsphere-sdk-4.1.jar
  inflating: lib/log4j-1.2.8.jar
  inflating: lib/commons-logging-1.1.1.jar
  inflating: lib/commons-cli-1.2.jar
  inflating: lib/statsfeeder-common-4.1.jar
  inflating: lib/statsfeeder-props-4.1.jar
  inflating: lib/statsfeeder-core-4.1.jar
  inflating: lib/jaxrpc-api-1.1.jar
  inflating: lib/statsfeeder-perfmon-4.1.jar
  inflating: lib/statsfeeder-sample-4.1.jar
  inflating: lib/statsfeeder-main-4.1.jar
  inflating: lib/opentsdb-tools-4.1.jar
  inflating: lib/jetty-client-8.1.4.v20120524.jar
  inflating: lib/jetty-http-8.1.4.v20120524.jar
  inflating: lib/jetty-io-8.1.4.v20120524.jar
  inflating: lib/jetty-util-8.1.4.v20120524.jar
  inflating: lib/kairosdb-tools-4.1.jar
  inflating: lib/jackson-mapper-asl-1.9.12.jar
  inflating: lib/jackson-core-asl-1.9.12.jar
[root@server1 statsfeeder]#
[root@server1 statsfeeder]#
[root@server1 statsfeeder]#
[root@server1 statsfeeder]# cd ..
[root@server1 ~]# git clone https://github.com/SYNAXON/GraphiteReceiver.git
Initialized empty Git repository in /root/GraphiteReceiver/.git/
remote: Counting objects: 218, done.
remote: Total 218 (delta 0), reused 0 (delta 0), pack-reused 218
Receiving objects: 100% (218/218), 61.49 KiB, done.
Resolving deltas: 100% (57/57), done.
[root@server1 ~]#
[root@server1 ~]#
[root@server1 ~]#
[root@server1 ~]# cd GraphiteReceiver
[root@server1 GraphiteReceiver]# mkdir -p ~/.m2/repository/com/vmware/tools/statsfeeder-common/4.1
[root@server1 GraphiteReceiver]# mkdir -p ~/.m2/repository/com/vmware/tools/statsfeeder-core/4.1
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]# cp ../statsfeeder/lib/statsfeeder-common-4.1.jar ~/.m2/repository/com/vmware/tools/statsfeeder-common/4.1
[root@server1 GraphiteReceiver]# cp ../statsfeeder/lib/statsfeeder-core-4.1.jar ~/.m2/repository/com/vmware/tools/statsfeeder-core/4.1

[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]# yum --disablerepo="*" --enablerepo="Linux" install  maven
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
No package maven available.
Error: Nothing to do
[root@server1 GraphiteReceiver]# yum --disablerepo="*" --enablerepo="epel" install  maven
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
No package maven available.
Error: Nothing to do
[root@server1 GraphiteReceiver]# yum --disablerepo="*" --enablerepo="epel" install  maven*
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
No package maven* available.
Error: Nothing to do
[root@server1 GraphiteReceiver]# yum --disablerepo="*" --enablerepo="Linux" install  maven*
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
No package maven* available.
Error: Nothing to do
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]# sudo wget http://repos.fedorapeople.org/repos/dchen/apache-maven/epel-apache-maven.repo -O /etc/yum.repos.d/epel-apache-maven.repo
--2015-09-27 10:47:44--  http://repos.fedorapeople.org/repos/dchen/apache-maven/epel-apache-maven.repo
Resolving repos.fedorapeople.org... 152.19.134.196, 2610:28:3090:3001:5054:ff:feff:683f
Connecting to repos.fedorapeople.org|152.19.134.196|:80... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://repos.fedorapeople.org/repos/dchen/apache-maven/epel-apache-maven.repo [following]
--2015-09-27 10:47:45--  https://repos.fedorapeople.org/repos/dchen/apache-maven/epel-apache-maven.repo
Connecting to repos.fedorapeople.org|152.19.134.196|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 445
Saving to: “/etc/yum.repos.d/epel-apache-maven.repo”

100%[===========================================================================================================================================================>] 445         --.-K/s   in 0s

2015-09-27 10:47:45 (22.3 MB/s) - “/etc/yum.repos.d/epel-apache-maven.repo” saved [445/445]

[root@server1 GraphiteReceiver]# sudo sed -i s/\$releasever/6/g /etc/yum.repos.d/epel-apache-maven.repo
[root@server1 GraphiteReceiver]# sudo yum install -y apache-maven
Loaded plugins: product-id, security, subscription-manager
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
Setting up Install Process
epel-apache-maven                                                                                | 2.4 kB     00:00
epel-apache-maven/primary_db                                                                                | 3.1 kB     00:00
Resolving Dependencies
--> Running transaction check
---> Package apache-maven.noarch 0:3.2.5-1.el6 will be installed
--> Finished Dependency Resolution

Dependencies Resolved

=====================================================================================================================================================================================================
 Package                                         Arch                                      Version                                        Repository                                            Size
=====================================================================================================================================================================================================
Installing:
 apache-maven                                    noarch                                    3.2.5-1.el6                                    epel-apache-maven                                    7.5 M

Transaction Summary
=====================================================================================================================================================================================================
Install       1 Package(s)

Total download size: 7.5 M
Installed size: 8.9 M
Downloading Packages:
apache-maven-3.2.5-1.el6.noarch.rpm                                                                                | 7.5 MB     00:01
Running rpm_check_debug
Running Transaction Test
Transaction Test Succeeded
Running Transaction
  Installing : apache-maven-3.2.5-1.el6.noarch                                                                                1/1
  Verifying  : apache-maven-3.2.5-1.el6.noarch                                                                                1/1

Installed:
  apache-maven.noarch 0:3.2.5-1.el6

Complete!
[root@server1 GraphiteReceiver]# mvn package
[INFO] Scanning for projects...
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building statsfeeder-GraphiteReceiver 1.0-IPM-3.5
[INFO] ------------------------------------------------------------------------
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom (8 KB at 12.7 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom (9 KB at 219.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/22/maven-parent-22.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/22/maven-parent-22.pom (30 KB at 744.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/11/apache-11.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/11/apache-11.pom (15 KB at 535.7 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.jar (29 KB at 670.4 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.pom (8 KB at 198.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/18/maven-plugins-18.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/18/maven-plugins-18.pom (13 KB at 276.0 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/16/maven-parent-16.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/16/maven-parent-16.pom (23 KB at 733.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/7/apache-7.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/7/apache-7.pom (15 KB at 469.7 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/2.3.2/maven-compiler-plugin-2.3.2.jar (29 KB at 814.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.pom (11 KB at 208.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.12.4/surefire-2.12.4.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/surefire/surefire/2.12.4/surefire-2.12.4.pom (14 KB at 448.9 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-surefire-plugin/2.12.4/maven-surefire-plugin-2.12.4.jar (30 KB at 874.9 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.pom (6 KB at 219.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom (13 KB at 410.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom (26 KB at 715.0 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom (15 KB at 370.6 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-jar-plugin/2.4/maven-jar-plugin-2.4.jar (34 KB at 922.9 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/com/vmware/tools/statsfeeder-core/4.1/statsfeeder-core-4.1.pom
[WARNING] The POM for com.vmware.tools:statsfeeder-core:jar:4.1 is missing, no dependency information available
Downloading: https://repo.maven.apache.org/maven2/com/vmware/tools/statsfeeder-common/4.1/statsfeeder-common-4.1.pom
[WARNING] The POM for com.vmware.tools:statsfeeder-common:jar:4.1 is missing, no dependency information available
Downloading: https://repo.maven.apache.org/maven2/com/vmware/tools/vsphere-sdk/4.1/vsphere-sdk-4.1.pom
[WARNING] The POM for com.vmware.tools:vsphere-sdk:jar:4.1 is missing, no dependency information available
Downloading: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.pom
Downloaded: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.pom (18 KB at 245.7 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/5/commons-parent-5.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/commons/commons-parent/5/commons-parent-5.pom (16 KB at 447.6 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/4/apache-4.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/4/apache-4.pom (5 KB at 121.9 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/com/vmware/tools/vsphere-sdk/4.1/vsphere-sdk-4.1.jar
Downloading: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.jar
Downloaded: https://repo.maven.apache.org/maven2/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.jar (60 KB at 1234.7 KB/sec)
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.378 s
[INFO] Finished at: 2015-09-27T10:48:39-07:00
[INFO] Final Memory: 10M/107M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project statsfeeder-GraphiteReceiver: Could not resolve dependencies for project de.synaxon:statsfeeder-GraphiteReceiver:jar:1.0-IPM-3.5: Could not find artifact com.vmware.tools:vsphere-sdk:jar:4.1 in central (https://repo.maven.apache.org/maven2) -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[root@server1 GraphiteReceiver]# cp target/GraphiteReceiver-1.0-SNAPSHOT.jar ../statsfeeder/lib
cp: cannot stat `target/GraphiteReceiver-1.0-SNAPSHOT.jar': No such file or directory
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#
[root@server1 GraphiteReceiver]#


class set_screen used.
class Board not used.
Too much of hardcoding which restricts portability of the code.


To be honest, I had this patch laying around for some time, so I don't even remember why I made this change. There are several test cases that have the "pure" keyword and none of them broke, so that's at least an assurance that at least nothing broke.
But I can exclude this patch from this PR and create again later when I find the test case again.


Very large init method with redundant code.
No use of Random to make the layout.


PEP8 violation: Use of wildcards in import statement.


The first lines of 2nd page


class Person is not implemented as per requirements.
Instead class Donkey inherits from class Player which is not what is specified.


Game doesn't work.


TeamCity pull requests :: netty [Build 317](https://garage.netty.io/teamcity/viewLog.html?buildId=1777&buildTypeId=pulls_netty&guest=1) is now running


Code Smell: Contrived Complexity. No duplication should exist for each movement


##this is a markdown file


No, but you should be able to use something like sinon to spy on it


typo in canola


All the methods are working fine!


variable names are not descriptive


Methods getPosition(), checkWall(), checkCollision(), collectCoin() not implemented.


It's good to use try-finally statement!


Didn't even take 2 mins for the hotfix to compile, good job.


Encapsulation well implemented.


Actually to run this application locally, you can just spin up another `docker-machine` locally to run locally rather than with digital ocean as cloud provider.


Inappropriate intimacy : player class depends on the board class.


Use underscore in methods and attributes names instead of camel case. (PEP-8 standards)


correction: issue number #11


code smell: class Player is a feature envy class


TeamCity pull requests :: netty [Build 317](https://garage.netty.io/teamcity/viewLog.html?buildId=1777&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 3929, ignored: 12 Build time: 00:06:39
### Failed tests
```
io.netty.handler.codec.ReplayingDecoderTest.testSingleDecode: <no details avaliable>

io.netty.handler.codec.ReplayingDecoderTest.testLineProtocol: <no details avaliable>

io.netty.handler.codec.ReplayingDecoderTest.testReplacement: <no details avaliable>

```


done.


PEP 8 standard well followed in import statements and constants


Bad code smell. Code can be defined as a function and can be called


TeamCity pull requests :: netty [Build 318](https://garage.netty.io/teamcity/viewLog.html?buildId=1778&buildTypeId=pulls_netty&guest=1) is now running


Using an array of laddar would be better


The important layout of the game attributes like platform and ladders are public which is serious problem


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4060/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


Excessive use of literals, values hard coded, would have have been easier to read and modify if variables were declared and used.


Ah, this makes a lot more sense.  Cool.

-[Unknown]


实现仍有错：e.g., `x_right==src.cols` 时，导致 `src.ptr(y_top)[x_left]` 越界。目前运行暂无 crash


You don't know what you're talking about, do you? Syntax is about the code, **not** indents! :stuck_out_tongue:


OOP principles, Inheritance not implemented.


PEP8 Standard violated
There should be 2 blank line between Class and first method


WHAT IS TRAVIS? Is it minecraft Jarvis?


Same code is written twice .. So better make it a function . Bad code smell. Code can be defined as a function and can be called
http://blog.codinghorror.com/code-smells/
>Combinitorial Explosion
>>You have lots of code that does almost the same thing.. but with tiny variations in data or behavior. This can be difficult to refactor-- perhaps using generics or an interpreter?


wew


sys module imported unnecessarily not used anywhere in the file.


Why did you even create this variable if the value doesn't change and you only use it once?


Oops, Ill push a fix to that now.


PEP8 standards violated:
2 blank lines should be left between Class and first method.


Pas mal, mais ya des modifs de gameplay ?


@Ruined1 Hand written, form builders are too wonky for me.


para islaremota


@pavel-kirienko
Why does uavcan_stm32::clock::adjustUtc(uavcan::UtcDuration::fromUSec(hrt_absolute_time())); (in uavcan_main.cpp) not work to initially set the phase difference to close to 0?


@pbauer plone.app.contenttypes is importing p.a.linkintegrity without declaring it in setup.py, this is why the build fails:

http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3028/consoleFull

p.a.linkintegrity shouldn't be required IMO though. Can we make the imports conditional?


@tisto Look at the changeset in plonetheme.barceloneta. The failure makes no sense and I could not reproduce it locally. I bet the test will run ok next time.


Name of a class should begin with a capital letter. (CapWords converntion; PEP-8 standards)


board width and height hardcoded,changing any of these will create problems.


Redundant code to create the layout. A function should have been present.


@pbauer that's my point. The build fails randomly and the problem seems to be p.a.linkintegrity and p.a.contenttypes. I started the AT build 8 times and it fails at least 2 times (passes for others): http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3031/


I´d go with "Dialog" instead of "Dialogue" to stay consistent with other naming schemes in Confluence / skinning engine.


Nice pictures used!


code smell: long class


Basic functionality is not implemented, such as,
Fireballs not implemented,
Coins cannot be collected,
Score is not there,
The player can float around the screen and even go out of the screen.


Looking into it


The following lines of code till line 138 should have been included in a class.


actually stepped back and left this code intact (it's better to avoid leaking `pErr` into the outer scope). Also cleaned up the index w.r.t `WriteIntentError` below.


I just reverted @polyester's commit to prove that this was not responsible...we can re-apply once we solved the issue...


If it's a different bug please use https://github.com/L2J/L2J_DataPack/issues/new


well commented and readable.


@Summary should be only one sentence. @Description is used for longer content.


TeamCity pull requests :: netty [Build 318](https://garage.netty.io/teamcity/viewLog.html?buildId=1778&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 10 (10 new), passed: 4765, ignored: 16 Build time: 00:09:40
### Failed tests
```
io.netty.handler.codec.stomp.StompSubframeDecoderTest.testSingleFrameWithBodyWithoutContentLength: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeDecoderTest.testSingleFrameWithBodyAndContentLength: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeDecoderTest.testSingleFrameDecoding: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeDecoderTest.testMultipleFramesDecoding: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeDecoderTest.testSingleFrameChunked: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeAggregatorTest.testSingleFrameWithBodyAndContentLength: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeAggregatorTest.testSingleFrameDecoding: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeAggregatorTest.testMultipleFramesDecoding: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeAggregatorTest.testSingleFrameChunked: <no details avaliable>

io.netty.handler.codec.stomp.StompSubframeAggregatorTest.testTooLongFrameException: <no details avaliable>

```


done (removed the check). There's always something in this `Batch`.


Just a hint, you can use the File type directly.


New version released. Thanks :)


not readable , not well commented.


code smell: long method


changed the `elsewhere` instead (felt ever so slightly cleaner).


I see, that makes sense. And the utf-8 markers?


Unused import pygame


OH COME ON


Extract method: verifyLinkStatus()


Missing whitespace after ","


PEP8 standards violated.
2 blank lines should be left between class name and first method


Values hard-coded; might be difficult to change the game.


Wrong formatting to store values in the list. White-spaces and commas


Awesome !


Create a container class for all textures


code smell: cyclomatic complexity in this if block


Just a comment to this: I was thinking about if i should store the long/lat data or not....
I decided against it because of privacy reasons.

What about only updating the long/lat if updateAddress is true?
So the user has the power to decide if the long/lat is saved.


multiple imports in one line


looks like a spelling mistake


wot is favicon ;-;


wew


lul


lol


Function checkWall not required, could use function checkCollision


Score is a public variable


Ок, сделал blog-intro на странице блога и странице поста, а также text-intro на главной под хеадером и возле кнопки Найти гостиницы.


The player moves only a certain amount of pixels when the direction keys are pressed, and does not keep moving as long the key is pressed.


Forbidden black magic.


Ок


Missing whitespace after ","


score attribute of the player is public


God object : player class.


I guess you would have to try to compile with those versions as well. In any case, the amount of effort I'm prepared to spend on making sure there are no unused imports is very very small. Adding gratuitous `#ifdef`'s is certainly above the threshold.


Ок, переделал на text-intro


Indentation contains mixed spaces and tabs


done.


this wont work if the consumer is using a different version of Trie -- need to add a duck typing method `Trie.isTrie()`

`instanceof` outside of base types like strings/numbers/undefined sucks unfortunately. Ok for internal-only classes i suppose.


Creation of fireballs and coins and setting there position not in there respective classes in there respective methods


Missing whitespace around the operator


functionality is good.


I just felt that it would be worth it to split off jQuery specific code off of the main Session class; not every project will include jQuery.

Ideally, I would like to see a separate namespace (project?) that adds a bunch of jQuery functionality via extension methods (the same for other things like Angular, Aurelia), while keeping the core Bumblebee relatively agnostic of those concerns.

So do you think I should move it into a Bumblebee.JQuery namespace to work toward that goal?


Excessive use of literals, variable could have been declared and used for better readability and easier modification of the code.
eg, the value 20 could have been stored in a variable and then used to call the function "self.rect.move()"


Because it just sets the clock to zero, regardless of the value of HRT. Therefore the resulting offset is roughly equal to the time passed between initialization of HRT and startup of the UAVCAN driver.


Hard coding y co-ordinate of the player according to the plaform in the layout


function is written but not used anywhere.


Improper inheritance, inherited things not required


PEP8 standards violated.
Found indentation with tabs instead of spaces.


Duplicated code, instead of adding coin1....coin6 separately, a list of coins[] could be made and the "mlist.add()" could have been called once under a for loop iterating over the list.


TeamCity pull requests :: netty [Build 319](https://garage.netty.io/teamcity/viewLog.html?buildId=1779&buildTypeId=pulls_netty&guest=1) is now running


Using if-else statement would be better


Many unused imports. (eg. sys)


Port of TextBlob PerceptronTagger


Duplicated code, The following 7 lines could be replaced with a list and a for loop for better readability and understandability of the code.


Code smell:
import sys is used twice


Please move this to the end of __process_line, rather than putting it in the middle of the logic for bibtex.


@tisto done.


Player not jumping properly, height of jump less less


done.


```
Author: Matthew Honnibal <email address>,
             Long Duong <email address> (NLTK port)
```


Must have written in multiple lines . Enhances readability of code


Docstrings missing.