why you recheck this as you are sure at line 258 ? please update a logic to avoid this condition. Hint - change line 271 to be sure what type you have.


too complicated expression, should wrapped by method with clear name.


This was a bug. It had to be changed, because we now use a list.


I don't really see why it's necessary, but I'll update.


Thanks! The iterator looks much better now.


single point of exit.


I suggest "Other operating systems and hardware may work with xCAT but have not been explicitly tested by this team. " be modified to "Other operating systems and hardware support, please refer to release note"


is it static candidate ?

it is good to mark methods as static to show that this method have no side effect to the class and pure util method.


if that ever happens, we can reconsider this


Erp, sorry.

-[Unknown]


> 1.8 means: major > 0 && minor > 8


move it below first usage in code


Strange! Okay, makes sense, thanks.


E.g. if the application doesn't provide "IconThemePath" property.... we will never get the icon names.


This should say 43, right?


Sles 11 SP4


That is a very good point, thanks :) My primary aim for this commit was getting the code to compile again. I'll improve the sorting and make the cache use a list instead of an array as well.


Rather than having a do_log variable, you can use else:

    try:
        yield
    except:
        raise
    else:
        text = '' if message == '' else ' for ' + message
        log(this, 'Elapsed time' + text, elapsed(starttime))


Check the discussion with @ploxiln here: https://github.com/meetecho/janus-gateway/issues/329#issuecomment-142511561
It's still weird that prflx end up in the candidates you negotiate in the first place, they're usually discovered while doing connectivity checks. In his case, it was probably happening because of the interfaces being bridged and VMs.


Are you watching this fork?
![image](https://cloud.githubusercontent.com/assets/1907011/10047825/9f836700-6218-11e5-9d11-e2c844894476.png)


den här attributen borde ha ett namn i pluralis - du kommer att ha många plan i den här listan.


You are now swallowing the exception.
I think if you re-raise from here your finally will still be called, so you could do:

    except:
        do_log = False
        raise


It is an implicit link. The link is at EOF : https://github.com/gitiki/Gitiki/blame/3bd5ab3a23db8e580bb68da2382510c797ba283c/wiki/index.md#L37

More details: http://daringfireball.net/projects/markdown/syntax#link


Sounds good and thanks for the suggestion. We are already using django's caching layer via memcached and have plans to monitor and stress test the api as well. The more we stress test and monitor, the more we can tweak caching and such.


Yikes! Well at least you got the CAPI signing operations working now.  That is the important thing.  Great work.


tänk på formateringen.


raw is not used any more, I do not understand your point.

I put everything together into this subroutine. Maybe later, I will reuse getDigestHexBytesWithColonsAndNewLines for printing existing-accounts certificates.


OK. Updated.


Yes I figured out later that it landed before the merge.


Можно даже `TemplateEngine` возвращать.


Formatteringen.


TeamCity pull requests :: netty [Build 256](https://garage.netty.io/teamcity/viewLog.html?buildId=1591&buildTypeId=pulls_netty&guest=1) is now running


Почему те методы без префикса th, а этот с префиксом? Случайно или специально?


А коммит-то не атомарный!


Använd inte puts i dina metoder. HUR informationen skall visas behöver inte definieras här.


:+1: fixed


Beta looks hard xDDDDDD


Sorry for being nit picky, but I think it should be ``parents=True`` in case of weird and nested paths. Do you think we should enforce `0o755`? It is already covered by `umask` in most cases.


Apply StyleCI fixes.


Fixed in cc3622956aa1c45ac35f78c3c60ad7f4f73c4a88.


I know, I was just asking about line 5 of SkinSettings.xml in particular.  It will auto-load when returning to Home, so why load when exiting Settings (which returns to Home)?  Just wondering is all.


I need 1.9 to use the new func. So min> 1 or maj > 8 can only be fulfilled by e.g. 1.9 or 2.0


Точно нужно? Потому что есть какая-то настройка в Spring Security, то оно само дописывает в конец форм это поле.


These flags are now found in `shada.c`.


Well I don't think I broke website_form by removing these because it's dead code: there's no `FormDataCompatibility` so it would have blown up if it were ever invoked, which it never is because `typeof` always returns a non-empty string[0], so negating it always yields `false` and the compatibility codepath couldn't be taken ever.


Är det Airport eller är det Plane som har metoden `can_take_off` definierad. Och när det handlar om metoder som returerar true eller false så är det bra om du lägger till ett '?' till metodnamnet.


Samma som ovan


TeamCity Dirigo Edge :: Deploy Pull Request [Build 89](http://tfs2013:8081/viewLog.html?buildId=876&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:05


Actually, I _think_ Apache 2 licensed projects are OK. It does not clash with BSD. It just means that _our_ code has the terms of BSD, whereas the dependency has the terms of Apache 2. There are some differences, mostly surrounding patents.

It does restrict our stuff from being combined with GPLv2, because GPLv2 is incompatible with Apache 2. But these days GPL v3 is well established, and it resolved the incompatibility with Apache 2. So I think all is well even downstream.

And if it isn't, we're already in trouble, because SJC depends on gentyref and eventbus, both of which are also Apache 2.


@ploxiln this commit adds the ```public_ip``` we had removed. It's basically the same thing, but with a new name, and the ```janus.cfg``` tries to clarify when it should only be used (as before it caused several ambiguities). Let me know if this makes the overall PR for you and I'll merge.


Лучше не использовать теги `<b>` и `<i>` вот так. Это теги для оформления, которое теперь должны реализовываться с помощью CSS.


См. про теги выше.


does not work always as well, same errors as with echo -e


Var är variabeln `plane`satt? (Jag ser att du har kommenterat ut ditt `let`-block)


Let me see, I'll check this right now.


:yellow_heart: The naming convention for Javascript classes involves the use of uppercase names. For example, `getIndex` should be renamed to `Index` to indicate that it represents a class (prototype).


Var finns `release? metoden?


ofullständigt test


approved


fast-forwarding develop to borshop-integration-66-feature/return-status-codes = 59ff69dd


Implemented in 7932687


`module` parameter in other datasources looks like `plugins/datasource/ds_dir/datasource`


:question: What does the `stringKeys` parameter represent?


why would it have dots in the first place?


No actually, the logic for `passport-localapikey` continues to function correctly with this change.  The difference is that the changes in the `passport` module do not affect our extension (which is why we had to make the change originally).

Also, I didn't realize my fork still exists.  I'm going to delete it soon.  Feel free to use project on antgraf's fork for future reference.  For example, this commit would be here:
https://github.com/antgraf/passport-localapikey/commit/f9419dceddffff29aa498856444bd3d713f172f9


Up sorry, I meant cert


There is a simpler and more effective way to do this in Java 7 and beyond:
```java
    try (BufferedReader br =
                   new BufferedReader(new FileReader(path))) {
        return br.readLine();
    }
```
That example is from: https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html


@malexh Hi, how are you?

It appears, GitHub keeps you subscribed to the public repos of orgs you have been a member of. Only you can unsubscribe from the public repos.

(Confirmed: you're not a member of `unisontech` on GitHub.)


:yellow_heart: A better name for the result of the AJAX request would be `bookData`.


Start working in R with the bike data


I'm not a fan of removing these methods and putting all the logic into the lamda.... the lambdas (and also functions) should IMO be short to be obvious what's happening there.
(I don't like long methods/pieces of code/)


ok


Shouldn't need this if we are using the viewthespace heroku toolbelt buildpack.  We already add heroku to the path.

https://github.com/viewthespace/heroku-buildpack-toolbelt/blob/master/bin/init-heroku-cli.sh


:green_heart: You did an excellent job determining the validity of the argument passed to the `readTexts` method.


Veebilehe idee: foorum, mis keskendub erinevatele ravimitele + nende mõjudele ja kasutajad saavad lisada oma isiklikud kokkupuuted antud ravimitega (ja lisaks anda hinnangu punktiskaalal).


In popcornmix' tree, having "Sync playback to display" enabled allows selecting "PLL adjust" as sync method:
https://github.com/popcornmix/xbmc/commit/940f6576948d4c43a7b1fdb13dc2bf3f05e1b81f
Not sure I understand why and how, but I wanted to point this out.


Why limit framerate? Dragging windows looks much smoother without this delay!


Also there's the strange overlap of data and extab. AFAIK no extab section should even be generated... are you using the supplied linker script (lpc1754.ld)?


make it a class attribute: like:
```python
self.tip_html_style = '<html><head/><body><p><span style="font-size:12pt; "color:grey;">%s</p></body></html>'
```


Adding high-byte output to a... controversial... message is absolutely a dick move, even if the intent isn't malicious.

There have been many comments, pull requests and even a gem written specifically because people don't want this gem's non-actionable output in their bundle install. The maintainer has ignored these, and that's his right.

But if you break the install that I've been debugging for a week by adding more "fun" to a message that I never wanted in the first place - and which worked fine for EVERY OTHER GEM in our catalog - then YOU are going to be the one to invoke my ire.

@jnunemaker xkcd.com/357 :)

@jgaskins it's not a puppet bug, they are paying attention to collation/locale rules that y'all aren't. If `LC_ALL=C` (or `ASCII` or some variant thereof) and you print emoji, it's binary data, not text. You can test with `sort` and different locale options. The More You Know :rainbow:


I'm using the supplied Makefile


also need to delete `query` and `annotations` from `partials`:
```
"partials": {
    "config": "app/plugins/datasource/zabbix/partials/config.html",
    "query": "app/plugins/datasource/zabbix/partials/query.editor.html",
    "annotations": "app/plugins/datasource/zabbix/partials/annotations.editor.html"
  },
```


@jomurgel is including susy something you'd be interested in merging? I've found it a heck of a lot more customisable over static 'span-x' classes.


А тут точно нужен пустой `<head>`?


Ahh, that should be easy to fix. I can run diff on the output of a real tidy run.


oh well, I would have reverted it once the "better pull request" is ready because with this the 9.0 using POS is broken in community...


There are more error on `lib/test`, i'm assuming superagent had a breaking release?


Do we need loc: to have two number inputs for lat and long?


ah okay, so you have to be identified by the server as an administrator. all these commands should be entered with a beginning "/" in chat mode. to identify enter "/identify xxx", xxx stands for a admin password.
like that?


because parameter names are derived from field names which may include dots if a joined entity field is referenced instead of a local one


Can you please apply the [AutoCloseable](http://docs.oracle.com/javase/7/docs/api/java/lang/AutoCloseable.html) pattern to the OutputStream from https://github.com/mwringe/hawkular-metrics/commit/6bb09b5734bc6c08dfe5af0e7c94f1fc0a3c598e#diff-f24647623d1a8fdd60465783a747f825R97


i've already commented that. I'll change, thanks


`QTextStream&` is the correct argument type here. why do you downgrade?


Thanks I'll address this in #80


Looks very promising (browser test) =) Good Work!
Swipeleft isn't needed, as far as I can notice (testing your rawgit demo).

Nevertheless you should add some boundries in order to distinguish scrolling top/down and opening the panel from the left side of the screen. I've seen many people scrolling downwards beginning at the lower left corner, pulling to the top right corner.
I was reading the JQM API of swiperight, where there is written ["Triggered when a horizontal drag of 30px or more (and less than 30px vertically) occurs within 1 second duration in the right direction"](https://api.jquerymobile.com/swiperight/).


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.976.237183382799e107eef2bece6afc1c7fd36b46b2](http://build.palaso.org/viewLog.html?buildId=63686&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 516, ignored: 6 Build time: 00:06:10


Depending on how persnickety you want to be on the definition of "zero" downtime (and also how big the `studynotes.org` oflder is), you would probably want to change lines 22 and 23 to be this instead:

```
cd /home/feross/www && mv studynotes.org studynotes.org-old
cd /home/feross/www && mv studynotes.org-build studynotes.org
cd /home/feross/www && rm -rf studynotes.org-old
```


Should `feb_meta` be part of the builds_controller? Seems like only builds controller would use this.


Можно объединить в один тег, чтобы не плодить лишнего. Кажется как-то так:

```
<b th:text="|${name}: ${exception.message}|">name: message</b>
```


:yellow_heart: The `createIndex` method need not return the index created for the file. It should store this within itself so it's easier to retrieve later on. This could be represented in this manner:

```javascript
Index.prototype.createIndex = function(file) {
  // other statements
  this.index = result;
};
```

There'll be no need to stringify the result.


Thanks for adding this. Looks good!

Do you mind adding a section to the README.md about how a developer can add their own meta tags?

Also, I assume you'll monkey patch `feb_meta` to get custom meta. That's fine for version 1, any thoughts on the next evolution of the API?

Thanks so much for adding this


TeamCity pull requests :: netty [Build 257](https://garage.netty.io/teamcity/viewLog.html?buildId=1592&buildTypeId=pulls_netty&guest=1) is now running


:yellow_heart: A comment describing this method would help explain how the method is to be used.


Updated in bfc9832ffc472dfc149976b56a47d63b19489b45.


@Gama11 Replacing the safe cast in FlxBitmapFont is causing a crash (tested in Neko and cpp):
```haxe
Invalid field access : parent
Called from flixel/graphics/frames/FlxBitmapFont.hx line 169
```

This is when i try to create a new bitmap font through:
```haxe
Reg.bGameFont = FlxBitmapFont.fromAngelCode(AssetPaths.arial_mt_32_out_2__png, AssetPaths.arial_mt_32_out_2__fnt);
```

I did revert the changes to this file in my fork and the problem is solved. It probably happens with the other two static creation methods also ( `fromXNA` and `fromMonospace` ).


Updated in 76a4857ec65ac1b620c604acd0447964432b7965.


or just introduce some kind of profiles for every user (some kind of a key) and then the server-admin could upload it's key to the server and the server would just have to compare these two keys (for example Teamspeak (VoIP-Service) is doing that)


Well, I generally agree. But I don't think we should split code into functions just for the sake of it, specially if those new functions will only be called from one place. If it comes to the situation where the split will improve reuse and modularity, then we should do it.


Larger than 1 ```> 1``` means _really_ larger so you would match 2 and above ... and with your ``||`` you would allow also 0.9 version

To target > 2.0 also something better is needed.


looks solid to me.


Diff's here are in the new VRF example file for coil size. The size is smaller, yet still higher than the calculated design loads in the html file.


Maybe not, as this data is indexed. An in-memory cache could be slightly faster. Updated the comment accordingly in 71a1e3ca41819b10f4fcfc3d49ab802d264a269a.


why the else if ?


Did you ever look at changing the way items are getting pulled into the partial? (The broken images)


``` ((MAJ == 1 && MIN > 8) || MAJ > 1))```

^^ perhaps is what is needed.


TeamCity pull requests :: netty [Build 256](https://garage.netty.io/teamcity/viewLog.html?buildId=1591&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5200, ignored: 21 Build time: 00:16:09


I think, that this was not caught in the original version, but I will add a further check, and message text. Will that be okay?


TeamCity pull requests :: netty [Build 258](https://garage.netty.io/teamcity/viewLog.html?buildId=1593&buildTypeId=pulls_netty&guest=1) is now running


title просто так написал или он действительно такой?


:yellow_heart: If the `files` parameter represents the source file from which the index was created, it would be helpful to give it a more descriptive name.


а обычный `value` где?


Verkar som att android studio automatiskt modifierar filer som jag hämtar efter andra committat. Bra att du hittade det här.


Steve,
I am moving on I want to finish the RESTful actions by tonight.  However, I could not figure how to test remember me, that is how to ensure the cookie hash (method) is set after checking the remember_me box.  Also ensuring the default unchecked does not set the cookie hash.  I also have to write a test to ensure that if a parent has multiple windows open and he logs out of one session, he does not create an exception when logging out of the other session.


А смысл в ` ` тогда?


Cierra issue https://github.com/InspectorIncognito/androidApp/issues/8


Are you mixing two things here?


This is baller. I havent worked with Ajax before but you made it look smooth


我使用了你的程式，将try catch移除后，有发生关于OpenSSL问题
是否可以帮忙我解决呢? 谢谢

  self._connection.send(message)
  File "/usr/lib/python2.6/site-packages/apnsclient/transport.py", line 255, in send
    with self:
  File "/usr/lib/python2.6/site-packages/apnsclient/transport.py", line 228, in __enter__
    self._open_connection() # can raise exception, bubblit up to the top
  File "/usr/lib/python2.6/site-packages/apnsclient/transport.py", line 519, in _open_connection
    timeout=self.session.connect_timeout
  File "/usr/lib/python2.6/site-packages/apnsclient/backends/__init__.py", line 88, in get_cached_connection
    return self.get_new_connection(address, certificate, timeout=timeout)
  File "/usr/lib/python2.6/site-packages/apnsclient/backends/stdio.py", line 378, in get_new_connection
    return self.connection_class(address, certificate, timeout=timeout)
  File "/usr/lib/python2.6/site-packages/apnsclient/backends/stdio.py", line 142, in __init__
    self._open_connection(timeout)
  File "/usr/lib/python2.6/site-packages/apnsclient/backends/stdio.py", line 153, in _open_connection
    self._connect_and_handshake()
  File "/usr/lib/python2.6/site-packages/apnsclient/backends/stdio.py", line 188, in _connect_and_handshake
    self._connection.do_handshake()
OpenSSL.SSL.SysCallError: (-1, 'Unexpected EOF')


I think there's one in GCE_PARALLEL_SKIP as well.


:yellow_heart: In general, variable names should represent the value stored in the variable as opposed to the data type of the variable. A more descriptive name for the search keys would be `searchKeys`. You could refactor the code like so:

```javascript
searchKeys = searchKeys.toLowerCase();
```


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (816 of 816 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.66%25-green.svg)


I've added a short note and a link back to the docs for data types as I think that's a better explanation than I could have come up with.  I also mistakenly said that the callback is optional.  I've fixed that as well.


tsukaコントローラは大変有意義な機能ですので、コンポーネント化しましょう。
よろしくお願いします(・∀・)


Кстати, можно было использовать одинарные кавычки, здесь и выше, при указании метода.


:green_heart: Converting the search keys into lowercase makes the application case-insensitive which makes it more accessible.


For now, binaries at:

https://risacher.org/putty-cac/testing/

-----Original Message-----
From: Josh Dantzler [mailto:notifications@github.com]
Sent: Wednesday, September 23, 2015 10:31 AM
To: risacher/putty-cac
Cc: Risacher, Daniel R CIV OSD DOD CIO (US)
Subject: Re: [putty-cac] Fix config and CAPI signing operations (6645bcf)

This email was sent from a non-Department of Defense email account, and contained active links. All links are disabled, and require you to copy and paste the address to a Web browser. Please verify the identity of the sender, and confirm authenticity of all links contained within the message.

Yikes! Well at least you got the CAPI signing operations working now. That is the important thing. Great work.

???
Reply to this email directly or view it on GitHub<Caution-github.com/risacher/putty-cac/commit/6645bcf72a9b5e6f69e625c8fdc79da87e8628f7#commitcomment-13392385>.


done


ok. thanks for these inputs. i will read the authentication procedure of teamspeak and cherry-pick what i need (maybe an irc authentication also).


:question: I would like to know why you stringified the data before returning it.


I agree with @cdeil that for now sticking them in a snippets section of the docs makes sense.  One way that might make this easier to manage, @bmorris3: use the ``nbconvert`` tool to convert the notebook to rst and just embed that directly in the docs as a snippet page.  See http://sphinx-ipynb.readthedocs.org/en/latest/howto.html for a description of this process.

(Caveat: I've not actually tried that so I'm not sure how well it works, particularly for issues like doctests... But it seems like a method that *might* make life simpler)


This line should be an `elsif`, not `if` (it's changed in later commits, but should be changed in this first one).


Looks like we have another bug with doctool, as some existing method descriptions are lost, e.g. in AudioStreamPlayback:
```
 		<method name="set_loop">
 			<argument index="0" name="enabled" type="bool">
 			</argument>
 			<description>
-			Set the loop hint for the audio stream playback. if true, audio stream will attempt to loop (restart) when finished.
 			</description>
 		</method>
```


teamspeak is closed source. maybe you want to look at the code of Mumble instead, its completely open source and uses certs for user-authentication.


perfekt, thanks for that hint.


Actually, on that note, we should revisit the breaking changes template because we missed some stuff on 0.13.4 - or rather, it didn't transfer over from the commit messages and I had to fix manually.


this check for the `bin` directory is not universally valid


Вынес бы в отдельный файл..


nit: indentation off.


that's strange


У тебя на всех страницах всегда указан язык "en", даже если переключиться на русский.


Or do those descriptions actually come from the code? Further down the diff there is e.g.:
```
+<class name="AudioStreamSpeex" inherits="AudioStream" category="Core">
 	<brief_description>
-	Simple gibberish speech stream playback.
+	Speex audio stream driver.
 	</brief_description>
 	<description>
-	AudioStream used for gibberish playback. It plays randomized phonemes, which can be used to accompany text dialogs.
+	Speex audio stream driver. Speex is very useful for compressed speech. It allows loading a very large amount of speech in memory at little IO/latency cost.
 	</description>
```


Oh, and @bmorris3 - if you get that to work, feel free to pull over my real-time dashboard at https://gist.github.com/eteq/773b263b7fceccc5961d into there - you should be able to do that in a way that preserves the commit history by merging and then renaming.  (I can also do it myself if you prefer)


@JimChung0403 这是由于苹果更新了 SSL 协议，将 apnsclient 库下的 stdio.py 文件中的 SSLv3_METHOD 换成 TLSv1_METHOD 即可


I didn't undo far enough 😱. Fixed and pushed.


Is it not that enum cases & class names are UpperCamelCase whereas properties of structs or classes are lowerCamelCase?

Either way, we've always done UpperCamelCase for constants up until now so I vote for consistency.


I think that was a bad usage from our part.


There is no `bin` involved in any check. I just removed the lines with red background.


P.S. Сейчас посмотрел HTML код кнопки выхода -- там аж два токена. Так что писать его самому не нужно.


so I tested in node and it actually throws an error if you change encoding so that's not an issue (and I added a test for just this occurrence)


I think [this SO question](http://stackoverflow.com/questions/19325960/rails-cucumber-capybara-how-to-set-retrieve-cookies-in-tests) might help. I think the relevant portion is `Capybara.current_session.driver.request.cookies.[]('auth_token')`. I haven't tested that, but it looks like Capybara can access the cookies from the test, even if it is quite verbose :-)


Limpando master dos testes de git


@mswiderski I've merged and cherry-picked this to 6.3.x and 6.2.x.

However, if you could write some sort of basic tests for this, that would be appreciated!


You could remove the done variable by making it an infinite loop with a break:

    while True:
        try:
            assemble(defs, app.config['target'])
            break
        except:
            pass


Thank you, Gary! You can merge


I know ...


:green_heart: This test spec is robust and covers a lot of cases. This is an excellent job.


Ok it's not a doctool bug, it's just a diff artefact since new classes were introduced with similar APIs. There is however potentially useful information lost in the process, but well, we'll soon rewrite it :D


We use "prollyfill" as opposed to "polyfill" for features that aspire to be standards but aren't yet as far down the line. Although prollyfill.org is down now, I think it's fine for us to revise the text to state that `TemplateBinding` is a prollyfill and in brackets say (`a polyfill for a not yet standardized API`), or similar.


I didn't catch the stop/start lines, so I guess it'd be more like:

```
sudo supervisorctl stop studynotes-site
sudo supervisorctl stop studynotes-liveupdater
cd /home/feross/www && mv studynotes.org studynotes.org-old
cd /home/feross/www && mv studynotes.org-build studynotes.org
sudo supervisorctl start studynotes-site
sudo supervisorctl start studynotes-liveupdater
cd /home/feross/www && rm -rf studynotes.org-old
```


:yellow_heart: To test that `indexRunner` is an `Array`, you'll have to check its type. The boolean value `true` would pass all the tests defined but would be a false-positive.


Ok... not a very big problem ;) :smile_cat:


lol


Awesome, looks good!


If you want to use `StartsWith()` it would have to be `objectType.FullName.StartsWith("System.Nullable`1[[UnitsNet")`


This type is getting big enough now that we need to have descriptions of each of the methods it contains.


Please pull down the latest. For any remaining problems, please open a new issue. Thanks!


:yellow_heart: Once the results of `createIndex` are made a property of the `Index` instance, the tests would have to be refactored.


Слишком сильное дублирование. Я бы попробовал вынести в переменную является ли пользователь админом, а потом в `th:colspan` использовал бы проверку и выводил либо одно число, либо другое.


Not kdiff3 this time. My fault.


cool.


You can mask the race condition above by turning this into an exclusive lock.


Thanks.


Great job!


It's strange finishing in 101 when the exercise talks about 1 to 100, better include explicitly the boundaries with <=


TeamCity Dirigo Edge :: Deploy Pull Request [Build 90](http://tfs2013:8081/viewLog.html?buildId=881&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:10


if you need any help on testing and compile the source ,i will do it ,i am compiling on cloud pc ,has 40 vcpus,220gb ram ,it done on 20 mins total cm build for boot image it compile in sec


Question 7.b: Compilation dynamique


I'm not sure what this comment refers to...


Better an inline initialization, faster and less memory consumed


@athanatos Want to confirm that we don't have to worry about dirtying info here.. that happens magically (sometimes) once enough epochs have gone by?


Don't need the "" + when you are returning strings


@gunturtif You can use any data you want in monitoring mode. The complicated is in the training mode, that you'll need to make the samples manually.


:+1: to the idea, but I think it belongs better in `astroplan` than `astroquery` - the latter is focused on the actual query service, whereas this is about *doing* something with the resulting data.

Also :+1: to @cdeil's comment that this would be better done by making `astroquery`/`wcsaxes` optional dependencies - Right now even matplotlib is not a requirement, so it would be odd to enforce `wcsaxes` (which itself depends on mpl).


Great!


You could replace it for "strToPrint.length ? strToPrint : i" , because 0 is false, then "strToPrint ? strToPrint : i" because "" is false and then "strToPrint || i" way more javascript-y


噗…


this would be for a single scheme build with regex unchecked


Since the method doesn't use `self`, I think I'd just make this a function - that also avoids complicating the inheritance hierarchy.


If that's the case, the gain for the integrator can be super tiny. I clear
it each time because right now, in a turn, it throws you way off course.
Asymetric clamping makes sense. Sounds like I need two integrators in
parallel and I clamp and use one while the other stays on listening but
doesn't contribute
On Sep 23, 2015 2:19 AM, "Paul Riseborough" <notifications@github.com>
wrote:

> See previous comment wrt limiting the input of an integrator.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Airphrame/ardupilot/commit/470949ca55168f8eadbc41194a025165b39518a4#commitcomment-13386091>
> .
>


isn't it the same as in the else ?


This file doesn't exist "out of the box".

In our case, we use webpack, but loading 'uikit' as a module doesn't work because the dist files don't exist.


@rvonstange DWMR (done with my review). Press on!


Because we're trying to focus on components rather than controllers, and bubbling doesn't happen this way in components.


You thinking something like this?

```csharp
private static bool FirstLineIsComment(SyntaxTriviaList trivia)
{
    if (trivia.Count == 0)
    {
        return false;
    }

    switch (trivia[0].Kind())
    {
    case SyntaxKind.SingleLineCommentTrivia:
    case SyntaxKind.MultiLineCommentTrivia:
        return true;

    case SyntaxKind.WhitespaceTrivia:
        break;

    default:
        return false;
    }

    if (trivia.Count == 1)
    {
        return false;
    }

    switch (trivia[1].Kind())
    {
    case SyntaxKind.SingleLineCommentTrivia:
    case SyntaxKind.MultiLineCommentTrivia:
        return true;

    default:
        return false;
    }
}
```


it is, an earlier version i was passing the Scheme name into executeBuild (or null for target).  I refactored that logic making the else if redundant, just missed cleaning it up


Go ahead and delete these commented out tests. They were stubs anyway.


There's no need to use `simplejson`, now that `json` is in the standard library, I think. Also I'd write it as `with open(...)` to make sure the file is closed, as in:
```python
with open(archive_file) as f:
    archives = json.load(f)
```


Would you mind tagging this so we can pull it in through packagist the regular way instead of requiring dev-master?


感谢你的回答，我在apnsclient库下找不到stdio.py 文件
不过我的程式有设定使用TLSv1_METHOD 协议
代码如下:

import OpenSSL
OpenSSL.SSL.SSLv3_METHOD = OpenSSL.SSL.TLSv1_METHOD
from apnsclient import Session, Message, APNs
import logging
logging.basicConfig()

session = Session()
con = session.get_connection("push_sandbox", cert_file="ck.pem", passphrase="XXX")
message = Message(["df84823054be03eb1e49e72c0f8c4be1640ff48d4085719f3543e8d50085d6c6""], alert="My message", badge=8)
# Send the message.
srv = APNs(con)

res = srv.send(message)


感谢你的回答，我在apnsclient库下找不到stdio.py 文件
不过我的程式有设定使用TLSv1_METHOD 协议
代码如下:

import OpenSSL
OpenSSL.SSL.SSLv3_METHOD = OpenSSL.SSL.TLSv1_METHOD
from apnsclient import Session, Message, APNs
import logging
logging.basicConfig()

session = Session()
con = session.get_connection("push_sandbox", cert_file="ck.pem", passphrase="XXX")
message = Message(["df84823054be03eb1e49e72c0f8c4be1640ff48d4085719f3543e8d50085d6c6""], alert="My message", badge=8)
srv = APNs(con)
res = srv.send(message)


@bmorris3 - Two things that occur to me that might be useful to add/change, though:
1. An option to save the figure without showing it.  Of course the user can always just ``plt.savefig``, but when scripting the download of a bunch of finding charts, it is nice if this can be done automatically, ideally *without* seeing the output in an MPL window (of course this depends on the backend, but I'm pretty sure this can be worked around by being careful when you do `draw`/show`/etc)
2. Support for putting a reticle on other objects  in the field.  I'm thinking of the common "target + offset star" scenario. Of course this can also just be added in a later PR if we want.


Do we expect this to be an issue with the new sponsorship app?


I added a note about CSV.  I didn't touch on Go as I'm trying to keep the scope of this article small, but we could look at a subsequent post that goes into greater depth.


Thx for advice! But it's actually already fine ... i'm satisfied :-)


I'm still seeing it at line 9, what's happening here?

<img width="941" alt="screen shot 2015-09-23 at 17 11 10" src="https://cloud.githubusercontent.com/assets/1799710/10049062/2837a0b4-6216-11e5-97ec-ab9ceb7f1c9c.png">


@alee8888 this isn't the right name for windows.  Should be win64.win64.XXXX?


:red_circle: The `books` property should only be created when the `createIndex` method is called. The `Index` object should be reusable; it should be able to create indexes for different sources.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.977.75564b6da49127811f9c90dfd41d41df7cba1a52](http://build.palaso.org/viewLog.html?buildId=63687&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 516, ignored: 6 Build time: 00:03:22


Looks ok to me, but will defer to @jaymzh


TeamCity Dirigo Edge :: Deploy Pull Request [Build 91](http://tfs2013:8081/viewLog.html?buildId=902&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:06


TeamCity Dirigo Edge :: Deploy Pull Request [Build 92](http://tfs2013:8081/viewLog.html?buildId=908&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:06


Are we using both these constants ? (Network_accessor_PT_Type_Code_IP=2 and Network_Accessor_PT_Type_Code_Name=2)


I think this is more confusing than using urlsplit and then using `.path`


Hi, would you mind tagging this as a new version, so we can pull it in through packagist without requiring dev-master?


У тебя в JSP было правильно написано -- `<button></button>`, а тут нет (и в других местах тоже). Здесь нужен закрывающий тег.


Here's a potentially simpler version:

```csharp
private static bool FirstLineIsComment(SyntaxTriviaList trivia)
{
    SyntaxKind first = trivia.Count >= 1 ? trivia[0].Kind() : SyntaxKind.None;
    switch (first)
    {
    case SyntaxKind.SingleLineCommentTrivia:
    case SyntaxKind.MultiLineCommentTrivia:
        return true;

    case SyntaxKind.WhitespaceTrivia:
        SyntaxKind second = trivia.Count >= 2 ? trivia[1].Kind() : SyntaxKind.None;
        return second == SyntaxKind.SingleLineCommentTrivia
            || second == SyntaxKind.MultiLineCommentTrivia;

    default:
        return false;
    }
}
```


I think since these `<br>` tags are here for layout - it'd be better to use CSS for that


outro teste 2


Should api-group be in eagle braces?


I've updated the PR to remove by key rather than iterator, which should take care of multiple occurrences. We'll address alternatives to multimap at another time.


А обычный `href` где?


This was already fixed in the next commit.


Why this alias is removed?


我找到stdio.py了 文件
改成下列方式，还是失败

#context = OpenSSL.SSL.Context(OpenSSL.SSL.SSLv3_METHOD)
context = OpenSSL.SSL.Context(OpenSSL.SSL.TLSv1_METHOD)


I think I ended with some weird output and that's why I did it hehe.


Actually, it should have them regardless as they are exported.  I'll add descriptions.


TeamCity Dirigo Edge :: Deploy Pull Request [Build 93](http://tfs2013:8081/viewLog.html?buildId=921&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:07


Yes


:yellow_heart: The authentication methods for the social accounts would be better placed in an authentication controller. The authentication controller would represent the authentication module for the application. This would greatly improve the modularity of the application.

This file should be renamed to reflect this.


Cerrado issue https://github.com/InspectorIncognito/androidApp/issues/10


Thanks! :)


I can move it there -- or maybe just into the BestsController since that's where it's actually called?


I like the last way  ```strToPrint || i```
I'm getting used to falsy values hehe


TeamCity Dirigo Edge :: Deploy Pull Request [Build 94](http://tfs2013:8081/viewLog.html?buildId=925&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:05


Why isn't this a set lookup?


Like Steve I'd thought that was some sort of duration, but https://apidocs.cloudfoundry.org/218/apps/get_detailed_stats_for_a_started_app.html gives an example value of:
"time":"2014-06-19 22:37:58 +0000"


is there a reason the `make remote` was left out? I use that as my primary build since i'm developing on my mac and don't want to garbage it up with packages.
TIA


Since the bug is going to be fixed quite soon, maybe it's worth putting ``0`` here instead of ``1``?


你好，那就真的抱歉了，我也不精通 Python，我的环境是 Python 2.7.9，Debian 8，代码是测试可以运行的 :)


Hey @daviddotzhang, why is this change needed? could you please explain the reason of the change you are doing in the commit message?


Why does Sum need to be updated? it's not an selector.


Hey @daviddotzhang, why is this change needed?


Don't worry. Java Collection has its own sort function. I added Comparable interface to our Member class so we can use Collections.sort();


:yellow_heart: The process of creating a router in this file leads to the creation of a redundant instance of the `express` router middleware. This could cause a dip in the performance of the application.

The application should have only one `router` instance. This instance should be passed into the `social.routes.js` file. You'll need to refactor the application to enable this.


我这边最开始也是

    File "/usr/lib/python2.6/site-packages/apnsclient/backends/stdio.py", line 188, in _connect_and_handshake
    self._connection.do_handshake()

handshake error，但是修改 SSL 协议之后，握手就正常了


This should probably be a constant error `errNotUnderPrefix`.


Seems like this should be made configurable just in case a user needs to override it same as the current managment_network_address config setting.


Hey @daviddotzhang, I think this is not correct.

This will make that in a site with staging enabled you can no longer select other sites you can administer or parent sites.


yoda style please. - First the expectation, then the actual value.


Lol, I actually did that because I didn't want to mess around with comparators. I'm glad you know how to use them XP


shouldnt this say Bluemix Deployments?


TeamCity Dirigo Edge :: Deploy Pull Request [Build 95](http://tfs2013:8081/viewLog.html?buildId=932&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:05


guess you meant management_network_mac in the commit not management_network_address.


It's not a big thing, but the history would be clearer if you squashed this into the earlier commit and add a note about your contribution to the commit message.


:red_circle: The Facebook account details should not be added to version control. It should be stored in the application's server. For the example, this block of code should read like so:

```javascript
'facebookAuth': {
  'clientID': process.env.FACEBOOK_CLIENT_ID
}
```

Please, create a Slack post containing all the credentials required by the application. I will add these to the server environments.


Konge! ☺


TeamCity pull requests :: netty [Build 259](https://garage.netty.io/teamcity/viewLog.html?buildId=1594&buildTypeId=pulls_netty&guest=1) is now running


TeamCity pull requests :: netty [Build 258](https://garage.netty.io/teamcity/viewLog.html?buildId=1593&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5602, ignored: 21 Build time: 00:36:46


NP -- and, will do. Yeah, the way I'm using this now is to use a decorator to override feb_meta. I think it would be pretty cool to incorporate custom meta attributes into the models and UI, personally, but I could see arguments against that, too. We have relatively non-technical people using the admin interface and allowing people to change configuration variables without changing any code would be sweet.

It's a slightly different feature, but I also like the ideas mentioned in https://github.com/tedconf/front_end_builds/issues/33 for exposing a low-level hook that allows you to take custom actions on the entire HTML before it's presented. I'd like to see this handled in a way that doesn't require monkey-patching with a decorator, but the only really nice way around that I've encountered is the way Devise handles it which involves a lot of extra overhead.


Made it blink if position is bad in 4a6cdf5, feel free to mess with it if you don't like it :-).


are references case insensitive ?


Thanks!


лол


@macropin hey thanks for this. Can you explain the reasoning behind `cp -a /etc/ssh /etc/ssh.cache` ?


The single line comment check is so that this code

    // <summary>Foo</summary>

comes out like this after the fix is run (I've used a single line comment for the copyright here so it's fairly brief)

```
// <copyright>Single line</copyright>
// <summary>Foo</summary>
```

but
```
#define STUFF
```

Looks like this after the fix

```
// <copyright>Single line</copyright>

#define STUFF
```

So for the multi line comment case (which can't be valid xml otherwise we would have gone down the other path)

```
/**************
*  DON'T MOVE *
**************/
```

Will end up looking like this option (A):

```
// <copyright>Single line</copyright>

/**************
*  DON'T MOVE *
**************/
```

Rather than option (B) below
```
// <copyright>Single line</copyright>
/**************
*  DON'T MOVE *
**************/
```

My personal preference is for option A (a happy accident of the code) but I'm really not that fussy.

I'm out after work this evening but I can make a change tomorrow (Thursday) if it's wanted.


"performanced" -> "performed" or "done" since we use the word performance a lot in this paragraph


You are literally the best.  :)


This looks good to me.  I guess that `isAnyIntegerType` is dead code now, but it seems like it might be useful in the future.


Hi Giego,

this commit brings all PhEDEx datasvc APIs in DMWMMON-datasvc, while we only want explicitly listed APIs specific to DMWMMON.
Could you please take this commit instead:
https://github.com/nataliaratnikova/cmsdist/commit/8bda80edb17f0b89d2de4cb94eef0f99c8c10685
It contains the exclude option:
tar -c perl_lib/PHEDEX/Web --exclude="*/API/*" | tar -x -C %i

Thanks,
 Natalia


> Could you use member empty() from std::string instead

OK - Updated.


thanks.


:yellow_heart: An alternate text would improve the accessibility of the application.


Thanks.  You may want to check out Gary's he used a switch/case with a loop also.


It's the old source, it's shown to give context.
See https://en.wikipedia.org/wiki/Diff_utility#Unified_format


maybe


:yellow_heart: While the `master` and `staging` versions of the application are being updated, it would be helpful set the `baseUrl` value based on the current environment of the application. For example, set the `baseUrl` to `https://localhost:5000` if the environment is `development` but set it to `https://hairven-staging.herokuapp.com` if the environment is `staging`.


what if custom manager do not need a list of users at all? override `__init__`?


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1354 of 1354 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.27%25-green.svg)


You need to extract it to a separate service


I played with WinRARBCDasm and Fiddler for a while, adding your code into the asasm file and reasemmble, auto response it, look into flashlog.txt and see those line, but it's wrong :(

{IQIYI_SALT}:eac64f22daf001da6ba9aa8da4d501508bbe90a4d4091fea3b0582a85b38c2cc


LGTM


Don't list in this form it doesn't make much sense. Add it in the form as shown below where each API has an example associated with itself.

The idea is that we avoid making API related documentation by citing full self contained documentation.


Actually, it's the top 1% (482/48160).


It's great you made your own module
But you can go next and move everything in a separate folder and devide this huge file into several
like folders service, directives, filters and files like OptionsRepository.js ...
Now it's very unclean


Well, if it's a duration it's broken from the beginning ;(
What does `2014-06-19` mean in that context?


Actually, it's the top 1% of blocks (482/48160).


Don't understand whyyou need this


Yes, that is a good idea, thanks. Any contribution is welcome!


Bad spacing


Thank you!


No need to have old unused code commented out, it stays in the commit history. Just remove it.


Oh, of course!


Nor am I. Perhaps @lizconlan does?


> So should we retain the margin for now, or no? :wink:

I meant to imply that I don't have a preference, it looks wrong either way.

I guess keep the space, it looks slightly less wrong.


8.0 deployment target? This is a major breaking change. Any way I can talk you out of this? How about 7.0?


Are these actually used, or just for debugging? Remove?


Do you know another way how to declare controller or any other classes without ['$scope','$timeout', '$http', this construction
It looks bad


no console.log in result


don't move then without dot on the next line


maybe make this variable's name more descriptive? Maybe call it currencies or something?


empty function not needed function


OK yeah that makes sense.


Setting this to false will lead to not open the file selector window when clicking on the parent label.


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1889 of 1890 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


I could go either way on that. Probably. Technically this codebase is generic for Cloud Foundry. Realistically, it's designed for Bluemix (and even says that in the header). I'm good with changing it to say "Bluemix Deployments" or "IBM Bluemix Deployments" if you'd prefer.


Since `is_building` removes the lock after returning, rather than using it as part of the claim, there's a race condition which could allow multiple builders.

    1 checks if something is building by taking an exclusive lock
    1 gains the lock and can see that nothing is building, so releases the lock
    2 checks if something is building by taking an exclusive lock
    2 gains the lock and thinks that because it could successfully take the lock, it should continue to build, then releases the lock
    1 takes the shared build lock and starts building
    2 takes the shared build lock and starts building

If you use an exclusive lock for the build instead, then it will raise an exception and cause a retry (though with an incorrect counter, since it's incremented elsewhere).

Given you don't need to have a shared lock on the build, and you retry on exception, you can simplify this:

    if not get_cache(defs, component):
        try:
            with claim(defs, component), app.timer(component, 'build of %s' % component['cache']):
                app.config['counter'] += 1
                build(defs, component)
        except IOError as e:
            if e.errno == errno.EWOULDBLOCK:
                # Assume that it's because lock failed, so don't retry immediately
                time.sleep(10)
            raise
    else:
        app.config['counter'] += 1

Even with the timeout you're still mostly busy waiting though, and if you extend the timeout to not wait so busily, you lose precision for when it actually stops being busy.

I'd recommend using a shared lock for the timeout, so all of your waiting builders get woken up immediately, as opposed to an exclusive lock, which would cause them to be woken sequentially.

You could probably do this by replacing the time.sleep(10) with:

    with open(lockfile(defs, component), 'r') as l:
        # --conflict-exit-code says that if we timed out return the specified code
        # Since we skip the extra wait on both a timeout and success, we can set it to 0.
        ret = subprocess.call(['flock', '--shared', '--timeout', str(60 * 5),
                                           '--conflict-exit-code', '0', str(l.fileno())])
        if ret != 0:
            # Failed for some unknown reason, wait for 10 so if waiting is broken we fall back to a busy-wait
            time.sleep(10)
        raise Exception() # retry


you know, that's actually been a setting for a long time


Add a ``defer close (c)`` as a practice for closing the channel.


Where is a place where you are waitin for this request will be finished
I mean you have a promise you can use it to increase a user experience, can't you ?


Meant to have commit comment denote the spelling errors in rando.h and rando.cpp for isDivisibleBy


Hello,

You probably meant to memset whole buffer (sizeof(bufsize) == 4 or 8).
Also You used this memset for debugging.


This looks like this was used for debugging?


Commented block - not needed block


if i use this file in my HTTPs site, can i access google.com openhand.cur image ?, because google.com is public site, https won't allow public site content?


Give it a more descriptive name, like currency or currentCurrency?


Thanks, it works for me.
Ruby 2.2.2
Rails 4.2.3
Grape 0.13.0


Método era solo el nombre para el ejercicio, cambia el nombre a ``Compute`` y si puedes poner los comentarios de regreso estaría excelente.


Was this used for debugging?


Why we need it ?


maybe call it something that implies it's an index, like j, since i is already taken?


I remember they planned to deprecate this
Don't use it
not safety


It's possible that this test (testFlat) passes while the other (testRaw) fails in some uncommon cases. For example, if the raw image cannot be properly standardized in DecamMapper, due to a policy change for raw or whatever, the flat image can still be retrieved correctly.  It does rely on the correctness of the raw registry.sqlite3, but not the correctness of actual retrieving a raw image.


why link
Why not controller


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (rraustad) - i386-Windows-7-VisualStudio-12: OK (1889 of 1890 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Hah, I dunno, I kind of like "performanced". What do you think of "The qthreads team performanced" :p


I just wonder why changing the directory was not enough for you. I have
some personal scripts that import other local scripts without problem. As
far as I know  your  current directory is part of the path.
On 23 Sep 2015 17:01, "Gael Varoquaux" <notifications@github.com> wrote:

> BUG: Make the gallery import local modules
>
> Fixes the plot_gradient_descent example
>
> Cc @Titan-C: we are going to have to do something like this in
> sphinx-gallery
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/scipy-lectures/scipy-lecture-notes/commit/f651d5e6e3139cfa664bd67463e8ff7cdc4cfa9e
>


I would define the constant inside the function


Again s is kind of weird name for an index, maybe use j again since it's a new loop/different scope.


Why do you need to use an accessor method here? why not read  $_category directly?


It is better to send a proper struct which is a combination of host string and probe.error. that way it can wrapped up later.


What if $_category doesn't exist?


Forgotten? :-p


Hay que hacer la costumbre de escribir: comentarios, variables, métodos y demás en inglés.


not a good place of using short if construction
Use simple if


sorry - I corrected that and changed the merge request.


@tank-bohr спасибо за то, что написал!

* Я не думаю, что это `NullObject`, т.к. `NullObject` имеет тот же интерфейс, но при вызове методов просто ничего не делает. А тут:
```ruby
BetterStruct.new(1) + BetterStruct.new(2)
# => BetterStruct.new(3)
```

* Во многом я и ориентировался на реализацию Стюарта :smile_cat:
Если очень хочется, то вместо его `and_then`

```ruby
g = ->(m) { Optional.new(m + 1) }

Optional.new(1).and_then(&g)
# => Optional.new(2)
```

Можно написать функцию отдельно:
```ruby
g = ->(m) { BetterStruct.new(m + 1) }

g.call(BetterStruct.new(1).value)
# => BetterStruct.new(2)
```

Я просто пошел дальше, заворачивая все передаваемые аргументы в монаду автоматически, чтобы не использовать все эти блоки-проки:
```ruby
BetterStruct.new(1) + 1
# => BetterStruct.new(2)
```


At this point You don't need to unlock. EXT4_MP_LOCK/EXT4_MP_UNLOCK should work like recursive mutex.


Let me know if this way of fetching and echoing the title is better. Thanks!

Also a note that the URL at the top is to the sites.olt.ubc.ca page where the template will be used. I've been testing them on a local install.  I'll put in a request today to activate the plugin on all relevant Education sites.


aquí se puede simplificar el código:

return DateTime.IsLeapYear(leapYear.Year);


Cool. And let it be 100 until #1207085 is resolved?
Arguably, could SuperSearch "automatically" set it to 0 if you're querying for aggregates?


console.log sholdbe removed


Here unlock is fine ;)


Open source camera HAL now available. We can improve it later.


:green_heart: This is an excellent comment! It's concise.


Hay que incluir siempre comentarios en los commits


indentation


More descriptive name? Not really average since it's just a list of prices used for calculating the average, maybe just call it prices or something similar?


Maybe it is good idea to keep both function set:
 - ext4_file
- path


TRAPpy?  You mean bart, no?


nice stuff


This line should read ```"ER34203" ``` instead of ```"ER34204"```, otherwise it references to an age variable.


You are right. Thanks for spotting


why is parseInt used here? Converting from float to an int?


:yellow_heart: The tokenization of the content of the Index could be improved by using a more detailed regular expression. Define a regular expression to filter out all parts of the string that are not words.


I have added some comments & suggestions. Great work. Keep it up !!!


Wrong order :wink:


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21111/testReport/) for this commit**


again, wrong order


https://fetch.spec.whatwg.org/ has 19 "non-null" and 1 "not null". https://dom.spec.whatwg.org/, written by the same person IIRC, has 30 "not null" and 10 "non-null". I don't think it matters.


The directory name I am getting when the pre-commit hook runs with this patch is "/usr/local/adnxs/autoenv-api/.git/hooks", and then schema-tools complains that config.json does not exist at that path, which is correct.  Reverting back to the original readlink operation works fine.

@christek91, perhaps we need to meet in the middle somewhere.  What was the nature of your original failure, and did this patch in fact fix it?


maybe describe the side effects though which you achieve this here?


Oops, thanks!


Looks sensible.


Is price defined? What is this variable used for?


Yeah, I bet this is going to go to prod at the same time as the fix, so that should really not be a problem.


Could we add some testing for the  _copy argument please?


Super Search cannot guess what you're going to do with the data it gives you, so it's impossible to guess if the hits are useful or not. :)


Yes. And add the ability to change this per user.


Go back to bed :p


The race condition you have is more easily triggerable if you have large numbers of builders soon after a synchronisation point (slow build blocking everything else), so it's definitely worth the effort to fix even if you do keep the fallback code for when a build races in shape.

It's more likely to bit-rot the less likely it is to happen, so the result of racing will get progressively worse over time if you don't prevent the race from happening.

I'd prefer a retry algorithm that tried to build something else if what it wanted to build if its current candidate was in progress, which can reliably happen after a synchronisation point if after shuffling you have multiple which have the same build first, which is likely to happen.


sorry, I just thought you were saying the `bin` check **was** modified.


ok enterado


>singleページのhtml
って
fukasawafrontpage.html
これとは違うのですか？


It does works. Take a look at `_InputArray::getMat_()`.


call the callback with the dictionary of average prices(btcAverages)? Also probably need to change the code that makes use of this as well.


oh es verdad.


Not everybody realises that if you install `global` script locally, like `gulp` - as long as you use npm scripts - everything is going to work since node_modules/.bin executables are in path when invoked like this.


I would recommend to remove the equality operator for boolean conditions entirely:
if (WavpackSeekSample(m_wpc, frameIndex)) {


We had these showing up in several jars, remember?

We should exclude them from all 5 pom.xmls at https://github.com/googlei18n/libphonenumber/commit/8d44a2913cc51bc8a70da15a63b2d80e91add1dc#diff-61657881d138c2b7ac1366d88c9ee035 (these generate the jars the get to Maven Central).

Did you check that none of the others include these files currently?


@ctrueden, @dietzc - Christian on gitter 'Eclipse Mars formatter has some serious problems'.  Are there known problems (other than imports)??  I'm noticing a bit of formatting weirdness since using Mars.  I did not expect the above line to change... but maybe I messed up the first time I formatted it.


The paragraphs contain links and other HTML markup; that’s what’s worrying me.

Also, you’d have to come up with names for each heading and each paragraph (each sentence?), and then use the name in the dictionary – all very inconvenient compared to just writing the document as it is.


Should this variable be present? If it hits the `if (g_bRecordFifoData)` branch at line 495, it'll be passing the bytes_read as zero due to variable shadowing. Just wondering if it was intended.


I know of the `implements` problem, where the `implements` statement has no empty space before it.


(You would have to run mvn package from each directory - running from libphonenumber/java invokes subdirectories' POMs, but run from each directory itself to ensure that doing "mvn package" only there wouldn't include these jars.)


TeamCity pull requests :: netty [Build 257](https://garage.netty.io/teamcity/viewLog.html?buildId=1592&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5602, ignored: 21 Build time: 01:12:00


TeamCity pull requests :: netty [Build 260](https://garage.netty.io/teamcity/viewLog.html?buildId=1595&buildTypeId=pulls_netty&guest=1) is now running


Use *args, **kwargs, super. And override, yes.


Yes, sorry about that. Hoping to put it back in with deprecation warnings.
Am I correct in observing that you are only using it here: https://github.com/tlycken/Interpolations.jl/blob/7646fe923f4c9e04e23cff2f26222917cbe9b4cb/test/scaling/nointerp.jl ?
It might be easier just to replace that with a try-catch that checks the error message


Looks like an ios7 target clears up the warnings I was trying to get rid of too.  So ios7 it is.
You can still compile back further, you just get a ton of warnings.


Nope, this is a bug.


@nilshg can you check that please?


@ctrueden I decided to use statusService instead of logService.  So no need to decide between log.info(...) and log.debug(...) anymore.


> I just wonder why changing the directory was not enough for you. I have
> some personal scripts that import other local scripts without problem.

Maybe the problem isn't present in sphinx-gallery. We'll see what happens
when we try to use sphinx-gallery in the scipy-lectures (I have postponed
right now, as it was too much work, and we really need to do a release).

> As far as I know your current directory is part of the path.

Agreed. But I don't know if it's the current directory of where the
Python interpretor was started. Anyhow, it failed without this patch.


TeamCity Dirigo Edge :: Deploy Pull Request [Build 96](http://tfs2013:8081/viewLog.html?buildId=941&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:09


Sounds good to me :smiley:  :+1:


TeamCity Dirigo Edge :: Deploy Pull Request [Build 97](http://tfs2013:8081/viewLog.html?buildId=944&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:06


TeamCity pull requests :: netty [Build 259](https://garage.netty.io/teamcity/viewLog.html?buildId=1594&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5600, ignored: 22 Build time: 00:36:16


i think this got taken out accidentally


The logic looks good to me. Does it make more sense here or in node-version.h? In node-version.h it would be more visible in case people made changes to the way NODE_VERSION_STRING is defined.


TeamCity pull requests :: netty [Build 261](https://garage.netty.io/teamcity/viewLog.html?buildId=1596&buildTypeId=pulls_netty&guest=1) is now running


@ctrueden fft_n is now nFFT.


Oh, silly mistake. Thanks for pointing out.


TeamCity Dirigo Edge :: Deploy Pull Request [Build 98](http://tfs2013:8081/viewLog.html?buildId=947&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:06


Thanks! :+1:


А вот тут лучше отделить функции друг от друга парой пустых строк


@lmy441900 If you temporarily don't have access to a po editor, run `msgfmt` with hotkey checks as guided in the translation guide.


Leaving this as a method call just for grouping things together, as discussed.


let's name it `renderResponse`


Only because the readme for the script says to.  I was just trying to adhere to their requirements.
https://github.com/BigNoid/script.skinshortcuts/blob/master/README.txt#L87


Think it's time to call this ready-to-pull?


longer term, when using server-side rendering we should determine a way to exclude the CSS from the static assets, as it will already be in the page. that would save about 5KB on the bundle size


Ship it

> Am 23.09.2015 um 17:24 schrieb Netkins <notifications@github.com>:
>
> TeamCity pull requests :: netty Build 259 is now running
>
> —
> Reply to this email directly or view it on GitHub.
>


:+1: awesome!


@popcornmix this should fix a couple of issues


Cierra Issue https://github.com/InspectorIncognito/androidApp/issues/9 e issue https://github.com/InspectorIncognito/androidApp/issues/11


dá para reduzir isso.

* `g = ~~!!g`
* `g = (g === 0) ? 1 : 0`
* `g = !!g ? 1 : 0`


Hi Isaac, I am afraid we can't move these functions to vcf.c. They are in the header file to allow inlining.


Or leave default `__init__` as you don't need all this args at all.


correct. This test already exists on master.


I think that's not necessary anymore, I added it just for debugging. The start process handles the waiting already.


it's about cursor size)


Are you suggesting this should take the place of the underlying validateOnBlur functionality?


r+


build logs can be found here: https://bugs.webkit.org/show_bug.cgi?id=145128


Hmm, do we pick this to 15.09 now or wait a while in case another mass-rebuild change appears? This is stdenv-changing, I'm afraid.


Does this work? How about a pull request to `sritchie/sbt-gitflow`?


Yep! You can see the result on http://gitiki.org


I notice your working on the whole lf-thing feel free to PR this as the next minor change should include everything to lf.


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/458e87211eb04c83b443f97c269294d479565594


merging graydon/stellar-core/dh-based-mutual-auth = 458e8721 into auto


graydon/stellar-core/dh-based-mutual-auth = 458e8721 merged ok, testing candidate = b5efe13a


Unclear how to apply above changes to jbuilder: https://github.com/rails/jbuilder/pull/293
Any help would be welcome.


Obrigado andrebian! Salvou aqui.


Did you disable/delete other packages as I described? If not, you're
probably seeing the effect I mentioned where one of your other packages is
being blamed for the load time.

On Monday, September 21, 2015, Graham <notifications@github.com> wrote:

> I've removed all requires in transpile.coffee. Makes no difference!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gandm/language-babel/commit/e03c01bb628dee4ba62b1f642918f37ae07cf5f2#commitcomment-13359183>
> .
>


TeamCity pull requests :: netty [Build 261](https://garage.netty.io/teamcity/viewLog.html?buildId=1596&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4782, ignored: 16 Build time: 00:09:48
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testNegativeTtl: <no details avaliable>

```


You avoided the test!! Sneaky :+1:


As far as I looked at just this change, I don't think twinkle needs its own namespace. Is this because you have a bigger picture in your mind? for example, refactoring?


Hmm, if this is necessary, then I think there may be a problem with having a shortcut to the skinshortcuts window from the Settings submenu.  I've noticed if I use the shortcut from there, it will occasionally not notice the change and thus doesn't build the new xml.


could you add a newline before and after this line so it matches the style of previous entries?


@peteri Thanks for the detailed overview. I think I agree with the current behavior based on that analysis.


Why aren't you using a constant for this expression?


@lackac thanks for the catch. don't mean to be a stickler but do you mind agreeing to the contributor license agreement https://docs.google.com/forms/d/1g7EF6PERciwn7zfmfke5Sir2n10yddGGSXyZsq98tVY/viewform?usp=send_form before we pull in.


Leave the newline.


Fixed in c42f519


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/81804308


@nightroan those get_next and get_previous routines shouldn't actually change any state, so I expect that its just trying to get the current piece right before the sub_6C683D call and after the callback.


Do you just want to check that the data comes through with _copy set to
False? It doesn't seem to return the same python object, which I thought
might be the case.


Not sure about keeping btcTimeStamp as a global variable. Think it would be better to keep it in btcAverages somehow. Maybe in a key called "TIMESTAMP" or something?


I think this line is unneeded.


true . I can do that if needed


+1 we did not meant to say that you are bad by using that, but make sure it is usable for the rest of us. @lmy441900


Style guide says variable names should start with lowercased letter.


is this right? if the photographer is signed in, authenticate them?


Yes, but that's not all. I think "core" implies something more generic than a specific song, so the structure is something closer to what I'd do in a project like this: core functions go in core, song-specific functions go in their own namespaces. Make sense? I'm still thinking about adding refactoring, but if you prefer I can put those functions back in core.clj for now and then move them back out later.


what about this?


I think there are issues on the function, when the hashed data big than (BUF_SIZE - AUTH_BYTES).
The function will skip to check hash and change the buf_len to zero.


Otherwise the code is technically making a memory leak (you forgot to delete it).
Easier to just use unique_ptr.


Thanks for the pull request and merging my code in the neural_style.lua file


One idea I had is to apply draw detection in SEE.
Example:
White has 1 pawn, 2 knight.
Black has 0 pawns, 2 knights.

Black captures the pawn and white captures 1, or even 2 knights.
White has a positive SEE, but the position is now dead draw.

White could have promoted the pawn and win.
.........................................................


fix this line to have double quotes


this.props.onMouseMove


indeed. I missed this part of the Markdown spec

> Link definition names may consist of letters, numbers, spaces, and punctuation — but they are not case sensitive.


Could you replace "Looks like there are no discussions here. Why don\'t you create a new one?" with a variable in order to have it translatable ?


Updated to say "Bluemix Deployments" in bb3df0c0362b8d9e48b0af917bbbf337cfca0929.


No, you are  a fool.  It's right as it is...


Did you try just to do    $this->ref = '';
then calling the create.
No need then to make the update.

If ref is not defined, the set of the prov ref should be already included into the create method.


See https://github.com/phpmyadmin/phpmyadmin/issues/11492


The idea is that this is extensible when additional RefType elements are added.

As I said in the commit comment, maybe this is overengineered – see deleted lines 32+33 for the old version of this regular expression pattern.


FTP


is not/is now ?


national_prefix is an optional string, so I'm a little worried about this... There's a difference between being absent/null, and being the empty string. Is it not possible for nationalPrefix to be null here?


Ditto my comment here.


Time to run http://www.pylint.org/?


...also fixed a few minor per-session memory leaks.


The key is correct, but iqiyi changes more. See https://github.com/soimort/you-get/issues/664#issuecomment-142622860


+1

Some news about this? I think this is a really important merge...


I recently learned that uv_udp_open and uv_udp_send don't actually assume that much and can be (ab)used to send raw packets as long as there is a way to create the raw socket first:

```lua
local ffi = require 'ffi'
local uv = require 'uv'

-- Darwin
local AF_INET = 2
local SOCK_RAW = 3
local IPPROTO_ICMP = 1
ffi.cdef[[
  int socket(int socket_family, int socket_type, int protocol);
]]

local sockfd = ffi.C.socket(AF_INET, SOCK_RAW, IPPROTO_ICMP)
assert(sockfd >= 0, "Failed to create socket")
p(sockfd)

local raw = uv.new_udp()
assert(raw:open(sockfd))
p(raw)

-- Data captured from real ping using wireshark
local icmp =
  "\x08\x00\xde\x44\x8e\x10\x00\x00\x56\x02\xcf\x8e\x00\x02\x7b\x14" ..
  "\x08\x09\x0a\x0b\x0c\x0d\x0e\x0f\x10\x11\x12\x13\x14\x15\x16\x17" ..
  "\x18\x19\x1a\x1b\x1c\x1d\x1e\x1f\x20\x21\x22\x23\x24\x25\x26\x27" ..
  "\x28\x29\x2a\x2b\x2c\x2d\x2e\x2f\x30\x31\x32\x33\x34\x35\x36\x37"

raw:send(icmp, "23.253.227.83", 0)
```


Thank you very much - I though there might be some clever way to do this.


Is "numberFormat" still a list here?


Why return when the loading failed?


could we go for only `this || self` and add a comment ?


Let's move this conversation back over to https://github.com/gandm/language-babel/issues/64 where it's easier to track.


Are you drunk?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Don't use 0. Use AF_UNSPEC.


TeamCity Dirigo Edge :: Deploy Pull Request [Build 99](http://tfs2013:8081/viewLog.html?buildId=954&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:05


Got it. Originall ext4fuse-lwext4 implements EXT4_MP_LOCK as normal mutex.


Cool, I like it.


I don't understand fix. Can you describe how to reproduce the bug ?


This comment doesn't match up with the implementation.


**no-unused-vars**: style is defined but never used


**no-unused-vars**: result is defined but never used


The 0 is converted to AF_UNSPEC in `net_gethostbyname`, I've used 0 to avoid including the header that defines AF_UNSPEC in every file that uses it.


Practice cloning and committing a Java project


@JiajunW  This package has failed to build. What's more, the error report mail has failed to send out...The error is:

```
../../js/src/libjs_static.a(Unified_cpp_js_src6.o): In function `js::jit::ArrayJoin(JSContext*, JS::Handle<JSObject*>, JS::Handle<JSString*>)':Unified_cpp_js_src6.cpp:(.text.unlikely._ZN2js3jit9ArrayJoinEP9JSContextN2JS6HandleIP8JSObjectEENS4_IP8JSStringEE+0x124): undefined reference to `JSString* js::ArrayJoin<false>(JSContext*, JS::Handle<JSObject*>, JS::Handle<JSLinearString*>, unsigned int)'collect2: error: ld returned 1 exit status/build/firefox-kde-opensuse/src/mozilla-release/config/rules.mk:815: recipe for target 'libxul.so' failed
```


Great, makes sense.


Ditto


How could we use rc_channels (though mavlink) if publish is set to false in simulator.cpp (line 120), when we built POSIX.


Redoing due to missing return


Avoid importing with wildcards.


Ditto.


No need for ?:, just assign directly, if you use AF_UNSPEC.


:yellow_heart: You've done an excellent job adding comments to help explain the procedures. However, some lines do not need comments. You could use your discretion to determine which blocks of code would require comments to help explain their complex procedures.


Why 100000 (arbitrary constant)?


0 might be a valid family.


TeamCity Dirigo Edge :: Deploy Pull Request [Build 100](http://tfs2013:8081/viewLog.html?buildId=959&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:09


This is arguably an issue with `gem` outputting a unicode `post_message` irrespective of locale. But this message is totally dumb.


DRF did not work for me on the VM clusters. Even a simple pi MR job gets stuck not able to get a container allocated


:green_heart: It's good to remove redundant modules to improve the performance of the application and also make it easier to understand.


And there she goes ! :tada:


You replicate this in different places. Can you re-use this code?


Nope. There were cases observed of a negative 0.0, which caused some bugs.


minor thing: indentation is off here and the following lines


:yellow_heart: If the `express` module is not required to start the server for the application, it may be recommended that it be uninstalled.


`DRF` did not work for me on the VM clusters. Even a simple `pi` MR job gets stuck not able to get a container allocated. Changing back to `fair` scheduler, that works fine.


Why is this necessary?


may want to make this 2.0.0 since it's a breaking change


Yeah, that's a sucky thing about our bindings - you need to use `thingy.isSame( otherThingy )` to see if they're the same C++ object, rather than the nice pythonic `thingy is otherThingy`. I'd want to use that to assert that you get a different one back each time with `_copy = True` and the same one each time with `_copy = False`.


Part of #118.


Note that this test is actually not enough - see https://github.com/stellar/stellar-core/issues/606/


Agree with all of your changes except this small one. We chose on purpose to not code-format the classes that are not part of Flitchio SDK (like KeyEvent here, and like SurfaceView in sdkandroid.rst). That facilitates the reading.


Thanks for writing these tests!


I will revert because I'm pushing other stuff.


@lizconlan thinks it should have been cut.


TeamCity Dirigo Edge :: Deploy Pull Request [Build 101](http://tfs2013:8081/viewLog.html?buildId=971&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:05


@nicolas-brousse Mostly that I forgot it existed. I personally haven't used it much, should we add it back?


Hi @matugm

What do you think about namespacing the CustomErrors module __into__ HighLine?

Like:

```ruby
class HighLine
  module CustomErrors
...
```

or just...

```ruby
module HighLine::CustomErrors
```

I think you will __still__ reference it withouth the trailing namespace like
```ruby
include CustomErrors
```

As they are inside a module that is already inside HighLine.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 693](https://teamcity.labkey.org/viewLog.html?buildId=273717&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:28:26
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

##### there are 23 more failed tests, see build details
```


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1354 of 1354 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


That does not work in my case, unfortunately. I have servers without DNS record or different different DNS domains.


usually would be 'exec test -e test'


@jakubpawlowicz Do you plan on using ES2015 syntax that Node v4+ only supports, like `let`, `const` and `=>`? Otherwise, is there any reason to drop Node v0.x support?


Hi @matugm ,

What do you think about namespacing QuestionAsker inside HighLine?


It's working fine, but there are just some minor integration issues which Tycho pointed out. I would ideally like to move the android parts into another project (cuberite-android?) to get CI working, and write some tutorials in the GitHub Wiki, but as always, time, time time... :P


Photovoltaics (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.19%25-red.svg)


Yeah. Point and score.


:heart: 2 COMMENTS :ghost:


I think it's fine to add the switch for future extension, but I don't think the code remotely works with ipv6, so you should just leave out the `case IPv6` for now to avoid people spamming us with bogus data


:heart: 3 COMMITS

:wolf:
:shirt:
:jeans:
^^ Business wolf :heart_eyes:


@morishitter will you publish a 1.3.4 for this or wait more bug fixes?


It looks like workflow_state is commonly instantiated the same way in many places. Would it be helpful to have a method that returns this object?


Hi @matugm,

What do you think about extracting a __method__ for this line?

```ruby
QuestionAsker.new(self, highline).ask_once
```

So we have a well defined and limited interface with other classes?

I'm not sure, but it could be something simple as:
```ruby
def ask_once
  QuestionAsker.new(self, highline).ask_once
end
```


@billccn , just pulled this down today and now TSC is complaining on my config:
    $httpProvider.defaults.headers.common.Accept = 'application/json';

(confirming to https://docs.angularjs.org/api/ng/service/$http#setting-http-headers)

Now headers.common is typed a string. Seems it should be an 'any'.

Thoughts?


Где можно об этом почитать/посмотреть? Везде только подобные туториалы.


Aha - thanks! Will do!

Hugh Macdonald
Nvizible - Visual Effects

020 3167 3860
07773 764708
www.nvizible.com

On 23 Sep 2015, at 17:33, John Haddon <notifications@github.com> wrote:

Yeah, that's a sucky thing about our bindings - you need to use thingy.isSame(
otherThingy ) to see if they're the same C++ object, rather than the nice
pythonic thingy is otherThingy. I'd want to use that to assert that you get
a different one back each time with _copy = True and the same one each time
with _copy = False.

—
Reply to this email directly or view it on GitHub
<https://github.com/HughMacdonald/gaffer/commit/5bfe16f80bccbad770800b15889459578af471b4#commitcomment-13395551>
.


Snuck in a fix in 1.0.16 since we needed to fix something on Windows anyway.


Не знаю где, но логично ведь, что кэширование нужно включать на сервере и выключать у разработчиков :)


It's not. I was just experimenting. I'll probably change the code to do lazy loading anyway.


Good point -- I don't think it's a significant enough break to warrant a major change, but it's too significant for a point fix. Going with 1.1.


They're more for me than you ;)


# FIXME: fails with `assert (<DoctestModule 'tests/spec/cli.py'> is None or <DoctestModule 'tests/spec/cli.py'> in [<Session 'pgctl'> ...`
pytest!=2.8.0


It's been removed, but this was "if a browser is saying they're a photographer, make sure they really are -- if not, make sure they're a real & authenticated user".

It's a strategy to make sure they're one of the two types of users


Missing " " before "?"


Я так и хотел сделать, когда кодил. Но что потом делать с этим `TemplateEngine` ?
![image](https://cloud.githubusercontent.com/assets/13660819/10051679/7011f55a-622b-11e5-96f3-53a462a8354f.png)


Move hash to class constant, then HASH[key] return the value


@michaelklishin just a minor comment here

```java.util.concurrent.ExecutorService#submit(java.lang.Runnable)``` returns a ```Future<?>``` that is not use.

Everywhere else in the code, it's the ```java.util.concurrent.Executor#execute``` method that is used, it returns ```void```, and may be more appropriate here also.


This should likely be prefixed with an underscore so we don't inadvertently clobber properties on people's applications, unlikely as it may be.

I don't _love_ the name `globalsMode` because the notion of a "mode" obfuscates exactly what's happening under the hood. Is there a better name we can use that encapsulates what behavior specifically is changing?


Убедил. Согласен, тогда придется оставить так.


clobbering the `seconds` value is smelly.
we might need to revisit this.


@dadouf I was reading the doc like a developer would so I can "get a feeling" of how it would appear to someone. When I reached that place I found myself "looking" at what the KeyEvent actually is (even though I know) so I would say that by removing it we are actually hindering the experience of someone reading the doc especially since it is a single link which is actually vital to that functionality of Flitchio and [developers like the Sphero team](http://sdk.sphero.com/sphero-robot-basics/robot-tech/) use links in some small parts that might be needed.


Потому что, когда я начал работать с Thymeleaf - не удалил бин с `InternalResourceViewResolver`, который имел такое же имя. И что бы не было конфликтов - переименовал этот бин в `thViewResolver`. Потом так и осталось.


Photovoltaics (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


needs lots of refactoring...


can we remove this plz?


Is the reference to the man page enough here, or should I document the available options in the comments?


What's the status of this commit?  I'm running into this issue with CORS in Play 2.4.  I've got a very simple form.  When that form is submitted, CORSFilter (or AbstractCORSPolicy, more likely) is rejecting that POST even though it's not a cross-origin request.

I can get it working by modifying the CORS config, whitelisting the Play application's own domain, but that shouldn't be necessary, and doesn't work as a long-term solution because we don't know the domain at compile/config time.


Commit not in the right branch


@use-strict I have filters that receive multiple parameters and the IFilterFunc is too restrictive. See any issue with me also just adding Function to the list on 789?


Do you prefer creating a special Iterator class over a transform function (which takes care of the hasNext and remove)?


Я намеренно это сделал. Рассуждал так: я изменил ресолвер на выдачу представлений в виде html-файлов. Значит все, что касалось JSP-файлов (а в данном случае именно так)  - я удаляю. Т.е. я считаю удалять этот файл отдельным комиттом без видимой причины неверно. Может я и не прав :)


"No new line at end of file" – und sowas lässt der formatter durchgehen


It seems like I also need to store some additional information (the container DN, and at least one krbSubtree), in order to perform the checks whether things actually worked. Should I just store this in some of the db fields with dbi-dbrc? They will differ from site to site, so I can't hardcode them.


SSL consistency check: it reports how many probes see a certificate different from the majority.

Example measurements: 1443162, 1443369

```
$ ripe-atlas report 1443162 --renderer ssl_consistency

RIPE Atlas Report for Measurement #1443162
===================================================

TPO SSL

Collecting results...
Certificate:
  Issuer: C=US, O=DigiCert Inc, CN=DigiCert High Assurance CA-3
  Subject: C=US, O=The Tor Project, Inc., CN=*.torproject.org
  SHA256 Fingerprint=36:13:D2:B2:2A:75:00:94:76:0C:41:AD:19:DB:52:A4:F0:5B:DE:A8:01:72:E2:57:87:61:AD:96:7F:7E:D9:AA

  Seen by 415 probes

Certificate:
  Issuer: C=US, O=DigiCert Inc, CN=DigiCert High Assurance EV Root CA
  Subject: C=US, O=DigiCert Inc, CN=DigiCert High Assurance CA-3
  SHA256 Fingerprint=21:EB:37:AB:4C:F6:EF:89:65:EC:17:66:40:9C:A7:6B:8B:2E:03:F2:D1:A3:88:DF:73:42:08:E8:6D:EE:E6:79

  Seen by 415 probes

Certificate:
  Issuer: C=US, O=GeoTrust Inc., CN=GeoTrust Global CA
  Subject: C=US, O=GeoTrust, Inc., CN=RapidSSL CA
  SHA256 Fingerprint=6D:5B:C9:79:46:1C:72:64:E1:71:00:10:CD:7D:4E:A3:EC:57:FA:11:21:5F:04:FF:A5:16:AE:61:95:9A:B2:B2

  Seen by 2 probes

  Below the threshold (80%)
  Probes that saw it:
    ID: 12318, country code: US, ASN (v4/v6): 20115/None
    ID: 12443, country code: US, ASN (v4/v6): 3737/None

Certificate:
  Issuer: C=US, O=GeoTrust, Inc., CN=RapidSSL CA
  Subject: C=None, O=None, CN=*.opendns.com
  SHA256 Fingerprint=BE:9E:83:54:86:12:70:4C:E3:18:7F:E4:53:F8:73:B2:05:B3:9D:7B:4E:7C:19:A9:05:27:B7:4E:05:F3:9E:5F

  Seen by 2 probes

  Below the threshold (80%)
  Probes that saw it:
    ID: 12318, country code: US, ASN (v4/v6): 20115/None
    ID: 12443, country code: US, ASN (v4/v6): 3737/None

Certificate:
  Issuer: C=None, O=None, CN=DSV Enterprise CA 1
  Subject: C=EU, O=DSV, CN=apac.proxy.dsv.com
  SHA256 Fingerprint=1A:B8:9E:ED:1B:DD:A0:E2:EA:67:89:C1:C5:4B:20:1C:49:9D:74:27:B0:5D:11:F2:9A:5F:C1:0D:F9:18:48:DA

  Seen by 1 probe

  Below the threshold (80%)
  Probes that saw it:
    ID: 2844, country code: HK, ASN (v4/v6): 49362/None

Certificate:
  Issuer: C=EU, O=DSV, CN=apac.proxy.dsv.com
  Subject: C=US, O=The Tor Project, Inc., CN=*.torproject.org
  SHA256 Fingerprint=07:52:BE:65:72:BF:02:D4:C9:E2:93:09:A8:E0:BE:3A:EA:D4:30:41:B8:49:FA:C5:F2:12:33:07:37:57:EE:C7

  Seen by 1 probe

  Below the threshold (80%)
  Probes that saw it:
    ID: 2844, country code: HK, ASN (v4/v6): 49362/None```


max_digits=8 for sponsorship.


Huh.  Okay.  It still seems funky to me that instances hold a back-pointer to the pool, but ... at least its consistent with `JRubyPuppetInstance`.


use translation from mycred


what do you think of this method? also add a before filter to the photographer controller that covers anything /p


Can we use JAN here?


translation from my cred. Cred name is configurable in the mycred admin panel.


Ditto


### Missing semicolon.

```
return "Hello, World!"
                      ^
```


### Use '===' to compare with 'null'.

```
if (bla == null) return;
        ^
```


Если я правильно понимаю, то после твоих вот этих изменений был сломан мастер и приложение просто не работало. Ведь как оно будет работать, когда ты добавил новый резолвер, но оставил старые вьюшки. Или я не прав?


Sure, I would just suggest documenting what someone needs to add to the field for the tests to work. That, or skip the tests if they're not found.


Not sure if you'd like to add a really small delay instead of the straight post to `drop`, as `drop` kills the connection asap (which may cause the ERROR_MSG to just be dropped on the floor as well). Now that I think of it we may want to just disable the Nagle algorithm on the sockets (not sure if we have any metrics around on latency time between requests and responses)


@paweldomas I haven't tested it, but shouldn't this be after the Unified Plan -> Plan B conversion when running on FF?


Ты прав, и меня поймал :) Это потому что я разделял на коммиты, уже после того как сделал все.


this change makes it so that mock module is required to use bcolz for python 2.*, but "mock" is not included in the deps (requirements.txt) for bcolz.


@wsnipex updated


This was too big dude.


Good catch - i didn't consider idl errors!
As I'm all about saving lines, will commit as

```python
os.remove(rpc.REQ_FIFO) if os.path.exists(rpc.REQ_FIFO) else None
os.remove(rpc.RESP_FIFO) if os.path.exists(rpc.RESP_FIFO) else None
```


This makes sense, but alternatively could we port more tests to use `create_data_portal_from_trade_history` so that we can use the same input/output for pre-existing tests.


I am getting relative branch out of reach with BEACON_IDLE=1


Yes, I think this fixes the crack sounds on seek.


:+1: on the clarity.

Would get my vote for doing this on master as well.


New line.


Thanks. You may well be right.


@correlator
the "-w tests" option will look for tests in the "tests" directory only.

Are you able to run the tests locally?

I currently get:

Ran 20 tests in 0.018s

FAILED (errors=3, failures=2)


Why remove the comment if we are still doing the hot-wiring?

An open TODO I think is that we should make data_portal an argument to slippage creation, or make the passing of data_portal part of the transact call.


What is this? I googled a bit but could you explain?


Thanks for getting this back in the right order.


Does this answer differ from master now?


why cann't remind me merger?!


Commited - thanks!


Maybe returns Vorbis {more clarification here} data size?


I'd have to leave the repo in an inconsistent state, e.g. the CHANGELOG will have to address the next version because of the "Added" functionality. That version will have to be 0.4.0 because semver. Of course, your repo, your rules but I don't understand what do you gain by leaving it untouched. If you discover a major bug tomorrow that warrants a quick release, it will just slow you down.


readNBytes


Yes, that was YAPF 0.3.0 ;-)


This sounds really good.


OK, will look if that works.


Awesome. Interface is clear now.


I didn't know about this. Will look if that works.


NOTE: I had to reimport the project into Android Studio after this change.


you are right, I had the same problem while doing something else on https://github.com/Blosc/bcolz/pull/253, I tried to solve it in https://github.com/FrancescElies/bcolz/commit/747c8d95394e6ebe80a5140c88868af41cfc7c93, do you think this the proper way to solve this?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (816 of 816 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.66%25-green.svg)


VorbisPage is better, I guess.


ack


Why not intend this `include`? It's clearly part of the `try` block.


thanks.
I don't want to nitpick, but "Disables passthrough audio" might be more explicit.


had an old "requirement.txt" file...only chesstalker left - but that's clear (cause no lib).


Yes, @MatthiasRo is correct - a fairly obvious typo given that all variables end in `03`, sorry for that!


si ese se me fue vacio


@jread-usgs I have some questions on the modeling, could I contact with you through Skype, may be it's more efficient than website. I met a situation that  when ice melting, the surface temperature rise anomaly.


Are these data fields need to be public?


Да, проверил: "In HTML5, the <head> element can be omitted". Я думал по-старинке что этот тэг обязательный. Буду везде где можно убирать.


TeamCity pull requests :: netty [Build 260](https://garage.netty.io/teamcity/viewLog.html?buildId=1595&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5601, ignored: 21 Build time: 01:11:26


Good catch! Although I'll remove the "the" before, otherwise I'd have to add "preference" afterwards; as in either:
> If 'Highlight all matches by default' is enabled

or
> If the 'Highlight all matches by default' preference is enabled

(I'm going with the first option because it's less words so quicker to read.)


@geohuanglei please ask questions about the model here: https://groups.google.com/forum/#!forum/aquaticmodelling

Thanks


line 98: empty line.


Why are you guys not using Rocket.Chat to discuss? We need to eat our own dog food! :)


really...


Close #15


This branch starts here


This won't be correct because passthrough is not disabled in general. paplayer can still use it. passthrough is a capability of the system layer. Components at a higher layer can use it or not.


ack


Wonderful work, Mike!


I will add tests of course. As for a "facebook.com account", I don't have one. I am a member of the "facebook" organization on GitHub though, shouldn't that be enough?

I just checked what the [React](https://github.com/facebook/react) guys are doing and indeed they're committing from personal e-mail addresses. I did add ambv@fb.com as one of my GitHub e-mail addresses but it's not the public one.


Thank you for you reply.
I suppose deadlock guard has been created to interrupt the thread that was deadlocked for any reasons.
If I am not mistaking, we will never interrupt the thread with current version of deadlock guard. Now deadlock guard task is scheduled at the expiration time of the packet so it starts always after expiration time and the packet is always expired at this moment.


@brianmc Any news on this?


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1354 of 1354 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


As my opinion, "the" is a necessary, and the "preference" is not necessary.


Out of curiosity, why was this reverted?


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-20.65%25-red.svg)


ack for feature


reack


I want to revisit this, because ido-ubiquitous is too big of a hammer, and on the other hand ido is really smooth for robe, since the first choice is very often right. I think what needs to be done is override completion-read-function, but only if default, solving this issue. Since it would take me a little while to write & test this, could you comment on whether you'd accept it?


Nitpick: `api` and `initialize` are pretty generically-named things. We might want to just `import datadog` and then use the more verbose `datadog.api` and `datadog.initialize` for clarity.


This is an error.

I pre-processed my light curve by joining the short cadence for in-transit, and long cadence for out-of-transit. This current oversight was because the model light curve from Joe Llama needed this down-sampling, and I absent-minededly added this flexibility. I *didn't* run my previous generation of Kepler 17 data like this (further down-sampling the long-cadence) and I wouldn't recommend doing so.


Ez miazanyádúristene?


Topology.


All the events .NET already has for this are here and start with Cluster or Server. Many of the other events might be covered by the "changed" events, but it was nicer to not make the user figure out what happened. I don't think that we necessarily need to mandate that. The one I noticed that would be useful would be the ServerHeartbeatXXX events.

We might need to make naming flexible here. Neither .NET nor Java use the terms Topology and SDAM doesn't require any particular terminology. As such, our term for this is Cluster.

Also, I'm not sure that SDAM has required anything in regards to structure of a "ServerDescription" or "TopologyDescription". As such, with some specification here, who knows what will show up in every driver. .NET's are here: https://github.com/mongodb/mongo-csharp-driver/blob/master/src/MongoDB.Driver.Core/Core/Clusters/ClusterDescription.cs and https://github.com/mongodb/mongo-csharp-driver/blob/master/src/MongoDB.Driver.Core/Core/Servers/ServerDescription.cs.


no nie zgodzę się, że `//div//div[@class="item-body"]/p` jest równoważne z `ul li div p > div` :P
Spróbujesz jeszcze raz?


Note to change in `plugins/UsersManager/Controller.php`: My plugin just needs the hard-coded name fix in `public function userSettings()`, but I changed the other cases also, for consistency and in case it is needed in future.


Washu makin' boi