Add network traffic


Interesting, I just tried it again, and didn't hit the same error I was getting before. I'm going to mark this as `user error` on my part - thanks so much for catching it!


Agree with your concerns. I will make the changes to handle these concerns, and then send a pull-request for your review. Thanks.


You might be curious why I opted for the local JS and not the CDN version.

This is because concatenation reduces load times by eliminating extra header requests at the cost of a larger file size. Since the CDN achieved the same purpose accept it relied on caching, the CDN became redundant in favor of the local which doesn't rely solely on caching.

The net load time should be reduced overall, even with the larger file.


Ok, sorry =)
I found the same problem here
https://jira.spring.io/browse/DATAREST-591


Plus, I'll keep the sort function as is. It's only a single loop so it should be more efficient (in theory, not messurable)


Use time.Tick


Log collect time


Add syslog-support


on my mobile i can see: 6 additions, one deletion, but on laptop I can see 1 addition 1 deletion. strange


I think this should be named "AllowNamedUnderscoreVariables".


Yes, although it also has to do with the border's location in the view hierarchy, as well as how the border is aligned with the normal toolbar as well as the web toolbar.  There's a build percolating through testflight now which should have the desired look and behaviour.


No. The sortBy may be CUserSortBy_Name which is valid.


Count open sockets


Implement SSL


thanks


@luxus The whole "device" part actually needs to be removed right now - Originally it required you to set the backend and frontend, but right now you just put in the backend and it automatically adds all frontends.  In the future, I want to let you specify the frontend, and have it automatically add all of them if you don't.


Change the hairstyle object reference in the saloon to an array of hairstyles


Not sure about this commit. From time to time when I have to modify the code having the variables around already is helpful (saves looking into the structure of the node, as always forget it). @jonas054 what do you think?


In any case it is much better than to say that you like curly brackets or to write if with branch statement on the same line. Define code convention using JsHint rules in the config files. If someone violates the convention there are tools which indicate it. And the most important that it is the true solution of the problem. There is no base anymore to start holly wars about code convention.


The effect is still the same, returning RSC_ROLE_UNKNOWN_S, but without dumping core and logging an assert. Calling role2text() with a bad value didn't seem worth all that. But I can add those back if you think they'd matter.


@asterite  O_o


Why not `while (attrType != null && attrType.FullName != "System.Object")`? I think the if/break at the bottom makes the intention less clear, but maybe just a matter of taste.


@microsingularities your inits should not use haskell init


When would this Hive variable ever be set?


**no-var**: Unexpected var, use let or const instead.


**no-unused-vars**: type is defined but never used


**no-unused-vars**: builder is defined but never used


**no-multi-spaces**: Multiple spaces found before 'require'.


**semi**: Missing semicolon.


баян


Give 0.4.8 a whirl.


When does this get set? Is this only if we are explicitly loading Hadoop config files? We should probably have a config for this


Oops, should be src.cols/8, width should be mod8


Should we make these sort of changes to the other YAML files as well?


Can we had a step to the build script that always seeks out these hidden folders to delete them before the build commences?


I didn't, they did :)

I just downloaded the latest version from upstream. It didn't change the one thing that coverity complained about (which is a false positive when using glibc at least), but I thought it would be worthwhile to update bundled code once in a blue moon. It did include one bug fix but nothing that would affect us.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 24](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=182&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Maybe add some comment that we can want to get rid of duplicates, so we use a set


IMHO this should only be allowed for the pulp plugin. New plugins should use the new mechanism.


acknowledging backport of trivial commit


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 24](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=182&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:52


Thanks.


Extra empty line.


Вообще хорошо бы как-то добавить комментариев или вынести в переменные, потому что четыре раза повторяющийся `true` непонятно к чему и зачем.


Pretty good indeed!


Remove the index for date and rating


А последние три поля могут иметь NULL в качестве значения?


Ты действительно собираешься хранить пароль вот так?


You got it right: because you want to pass different arguments, you had to wrap the function calls into an anonymous function, which you are passing a reference to along (not calling it right away as you would do with an IIFE). Nicely done.


So, it looks like MissingDatabase isn’t actually used anywhere? I’m guessing it disappeared when the requirement for an auth DB went away. So, uh, might as well delete this code!


Я как-то пропустил, но по моим заданиям все миграции должны выполняться через Liquibase. Будешь переделывать?


Good opportunity for abstracting function. Always better than hugely horizontal.


with no doubt, this patch is doing the intended thing. however, wouldn't it be less silly to unconditionally emit the dyload code and put it in between `#ifdef QUCSADMS_DYLOAD` ... `#endif`? i mean, it is not meant to make any difference in terms of the *model*.

(sorry, i had missed this completely)


Strange lack of isolate scope.


Remove the index on hairstyles populate reference


> ... environment **WITHOUT** MPI ...


Обычно логин уникальный, поэтому можно добавить `unique = true` и добавить соответствующее ограничение на уровне БД.


Импорт со зведочкой делает компиляцию проекта чуточку дольше.


OK merge me please. And after that we can revisit this and iterate on the API.


До сих пор не переименовал пакеты?..


ftpclass.cc:3966: error: expected primary-expression before ‘=’ token


> at least will prevent core from running in a bad state, as ASSERT is not enabled when not in debug mode

ASSERT is enabled on any build mode, Debug and Release


Всем строковым полям еще можно и `length` добавлять, как в схеме БД.


Typo, meant to write 'DataServer.py' instead of 'Device.py'.


I think we don't care :-)


Research about fixtures for mongodb/jasmine tests


Нет модификатора доступа.


is this by intent?


@livec: of course, this is very promising and most likely this will end up with completely different
mg values and eg values.
Please don't worry, Stefan is one of the most experienced and successful contributor, he (or someone else) will extract all the juice from this idea.


I agree with @evdb. Do you think you could add a fallback that keeps `max_redirects` working @SkySymbol?


У всех методов этого класса надо добавить `@Override`


Why is it a URL in one context but a URI in the other?


Ну вот, уникальный все-таки логин должен быть.


Very nice :) You also fixed the swig 3.0 issue so I'll have to update mine!


Why can't hosting create the address list feature?


I think an own class for shortcodes would be good. Can we separate code and view (HMTL-markup)? Or would this separation have impact on the maintainability?


does this create a valid crash report on Debug and RelWithDebInfo on Windows platform using WheatyExceptionReport ?


Я видел этот ворнинг, но там по-моему был хитроплан, связанный с тем что иногда оно вызывается как метод класса, а иногда как метод экземпляра.


It seems the following code do the same:
```
        val (logPath: String, fileIsGiven: Boolean) =
                System.getProperty(COMPILE_DAEMON_LOG_PATH_PROPERTY)?.trimQuotes?.let { Pair(it, File(it).isFile) } ?: Pair("%t", false)
```


Also added the mandatory version parameter


That would be helpful


lgtm


I think it would've been better to move it to `util` then, which is still in the compiler. Everything under `core/` ends up in `kotlin-reflect.jar` and space is precious there


`else throw cRuntimeError("invalid direction");`


While this certainly is a valid object, it doesn't really tell me anything about you!


Thanks

I currently used this at the top of my Shell.  Presumably I need to add
something else?

namespace App\Shell;

use Cake\Console\Shell;
use Cake\I18n\Time;
use Cake\Network\Email\Email;
use Cake\Database\Expression\QueryExpression;
use CakeResque\CakeResque;
use CakeResque\Resque_Job_Creator;

class RegisterShell extends AppShell {

On Mon, Sep 21, 2015 at 3:50 PM, Wan Qi Chen <notifications@github.com>
wrote:

> Job classes should probably be namespaced ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wa0x6e/Cake-Resque/commit/9b5cda2f371b413a6b330d7ed134bff1f8e60d70#commitcomment-13344546>
> .
>


Can you avoid doing direct DOM selection?


He tingut que fer un petit canvi a la traducció per una altra targeta al trello (#963)


This means that if scope.roundStep is not defined valueString will always be = ''...


Would `parseFloat()` be better here?


Аргумент `userName`, внутри запроса `loginName`, в БД `login` -- смысл?

И еще я не увидел тут где ты параметр-то биндишь к запросу?


Whoops, you're right


Let's talk about how this can be done differently.


Change the comment on line 55 to refer to the saloon model


Не надо ли тут добавить `@Repository`?


But this is redundant because bash remembers the previous directory: `cd -` or `cd $OLDPWD`


This will break when you deploy. This also doesn't have to be done in Javascript.


oh, atv2 does not have NSAppKitVersionNumber :)


Тут как и с дао:
- модификатор доступа для поля
- аннотация `@Service`
- аннотации `@Override`
- `loginName` я бы записал просто как `login`


Good idea!


However, this is no longer relevant, since rounding has since been moved to its own function that takes a number, and just returns the number unless != null and roundToStep is true


why does that work for you, but not for me??  *scratch*

FWIW, `/usr/bin/cc` works fine for gtod, and should be quite portable, so at least as a fallback that might be a good option, too.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8323/testReport/) for this commit**


ES6 template strings will allow you to indent and line break this!


Looks as I was mistaken. I now think it is rather a problem with the item graph rather than the testcase itself


@Shauren is going to revert it, as in windows makes the completelly useless message "Application has stopped" dialog.


duh...


use `if (storedUdp->getSourcePort() != liveUdp->getSourcePort())`


Thanks for this.


It sounds reasonable. Feel free to move it there.


Strange that `facebookLogin()` gets grabbed from some other scope when it could be easily put in this link function.


Ya decía yo que me salía muchas veces... xD


Я думаю, что у тебя все работает и не падает, потому что в БД ровно один пользователь. Хм.. впрочем, странно, ведь тут есть `where`, как оно работает вообще? Оно у тебя работает?


use `!=`


Possibly, but I do not know if others rely on having an actual QVariant returned in this case.

If you are calling:
ctkPluginFrameworkLauncher::run(NULL, NULL).toInt();
You do not want it to crash.


Lets change the title as well


А к чему такое переименовывание? Опять название сущности не совпадает с названием таблицы в БД.


I'd like to pull this change upstream but I wanted to make sure I understood your work first.

This commit might imply that you have tried netbsd, openbsd, and solaris and they do not work using this library.  Is that correct?  Or have you preemptively crippled them because you have not yet tested them?  I don't have any of those three OSs handy, so I'm curious to know.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8324/testReport/) for this commit**


:question:


NOOOO


Mestre usei essa lista
http://bl0g.cedricpernet.net/public/killav.yara

Vou pegar essa lista que você mandou e vou fazer diff e add o que falta na blacklist...

valeu !

abr


Typo.


GoogleO(logn)


Remove id variable declaration, make use of the id returned by the callback


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.61.57b5203f9edbe6463438e82381868fd9fb698ca7](http://build.palaso.org/viewLog.html?buildId=63507&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:36:21


А почему ты думаешь, что `loginService.get()` вернет `null`, если пользователя не найдет? Я вот думаю, что метод исключение выбросит. Или я не прав?


Strange that this doesn't have isolate.


`return (storedUdp->getSourcePort() == liveUdp->getSourcePort()) && (storedUdp->getDestinationPort() == liveUdp->getDestinationPort());`


The comma was causing the cc_voucher field indefinition.


One of the way is convert, rename .kt to .java, commit, rename .java to .kt, commit.


redefine if conditions for err and !hairstyle to reflect the two scenarios


this should come before the isConnected check.


Do you think we should do the TLD swap on twisted domains also ?


`$state.reload()` also works.


rax retry tests


Awkward to reload state to reinitialize.


Складывается впечатление, что ты куда-то торопишься. Снова упускаешь из виду те же самые мелочи, о которых я тебе уже писал. Попробуй сначала ревьвить себя сам, многие мелочи тогда бы до меня даже не доходили.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.483.57b5203f9edbe6463438e82381868fd9fb698ca7](http://build.palaso.org/viewLog.html?buildId=63518&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:21:38


Honestly, I have no idea, I stopped using PHP years ago


Don't you already have `currentUser`?


Hello,

I'm having memory leak issues with WiiuseJ, a wiiuse wrapper for Java. I don't know if its caused by WiiuseJ or wiiuse itself. Did this commit fix a memory leak issue present in wiiuse? Or was an issue only on your library, WiiC?

Thank you!


@Rocky640 : OK, I hope that my comments are not annoying.


constructor missing, 7 uninitialized pointers in class


`readOnly = true`?


add `const` for getter functions


Seems to break the execution.
While running with node, it throws :

``` javascript
/app/server/migrations.js:21
const noValidateMulti = { ...noValidate, multi: true };
                          ^
SyntaxError: Unexpected token .
    at Module._compile (module.js:439:25)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
    at startup (node.js:119:16)
    at node.js:935:3
```


This won't work.


Why?


I can't really see how the blue curve scales. They seem are simply two lines. Maybe you could scale the axis limits to get a more clear figure.


remove default ports


This example should probably be using a (validator)[https://github.com/dart-lang/polymer_elements/blob/master/lib/iron_validator_behavior.dart] element do do the validation, I haven't personally tried doing this but that seems to be the new way.


No isolate scope.


This commit is breaking a filter I have that logs API requests and responses.

I think this is failing because the response is no longer wrapped with http.ResponseWriter which my filter depends on.

Here is the filter this commit breaks:
```func logRequestResponse(request *restful.Request, response *restful.Response, chain *restful.FilterChain) {
	var requestBodyMap map[string]interface{}
	request.ReadEntity(&requestBodyMap)
	requestBody, _ := json.Marshal(requestBodyMap)
	fmt.Printf("Request: %s %s - %s\n", string(request.Request.Method), request.Request.URL.String(), string(requestBody))

	cachedResponseWriter := response.ResponseWriter
	recorder := httptest.NewRecorder()
	responseWriter := restful.NewResponse(recorder)
	response.ResponseWriter = responseWriter
	chain.ProcessFilter(request, responseWriter)

	// Write the host response and headers
	response.ResponseWriter = cachedResponseWriter
	for headerKey, headerValue := range recorder.HeaderMap {
		response.AddHeader(headerKey, fmt.Sprintf(strings.Join(headerValue, "")))
	}
	responseBody := recorder.Body.Bytes()
	response.ResponseWriter.WriteHeader(recorder.Code)
	response.Write(responseBody)

	var responseBodyMap map[string]interface{}
	json.Unmarshal(responseBody, &responseBodyMap)
	var err error
	responseBody, err = json.Marshal(responseBodyMap)

	if err != nil {
		fmt.Printf("Error: %v\n", err)
	} else {
		fmt.Printf("Response: %s\n", string(responseBody))
	}
}```

When I change req and resp back to wrappedRequest and wrappedResponse the filter works again.


Actually it's a double-bugfix :smile:.

Before commit https://github.com/QuantConnect/Lean/commit/f7d6ae6d5ef7fc7d7fc9b5468a3e63397fb417d4, ticks for internal feeds were streamed to the algorithms (while they shouldn't be). Unfortunately this caused the error reported above by @xenu256.

My commit should address both problems.


unused dataTransferMode?


Use the authenticated route control strategy (refer to `fsa-prebuilt.js` and `members-only.js` state).


@vlado Thank you :bow:


data: { authenticate: true }


The dates on this are wrong. Actually these changers were pushed on September 20, 2015.


Does chat work then now?


А попробуй вместо

offsetLeft.value = imageWidth - sizeValue.value
сделать evt.preventDefault() - проверь так не лучше? :)


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 666](https://teamcity.labkey.org/viewLog.html?buildId=273236&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:28:17
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 23 more failed tests, see build details
```


> How will volumes update their profile after creation? I assumed apply_profile would do this in the future ?

Right.


Hab ich verstanden. Werde ich noch machen. Aber vorher wahrscheinlich noch Content.


I fought with and researched that one for a little, and then eventually settled on `Number()`, but still wasn't sure if it was the best in the end.  Just thought to pull up [this jsperf](http://jsperf.com/number-vs-plus-vs-toint-vs-tofloat/16), and the results are interesting.  I also didn't consider `+`...  Oh I feel the :rabbit2: hole opening up.  I can just switch it over to `parseFloat()`, no prob!


I love Nim


Perhaps as a compile-time constant to avoid unnecessary fetches.

On Monday, September 21, 2015, Morwenn <notifications@github.com> wrote:

> This code screams for a dedicated constant :p
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DavidKnight247/solarus/commit/c9090c1dd9829ccfe5970ee9e5bab26d27e8f033#commitcomment-13337539>
> .
>


Just `=` works.


what is the reason for this? I get this error message on a FEI4A.


`ng-src`


Maybe we should think about introducing some contants.py file in the manager?
I've already seen 3 places with a similar code across the manager repo ..


Where is mdsshrp.h ?


Alright!

As you can see, we're mixing different syntax and level of "abstractions" to deal with our UI:

``` js
// Sometimes we have variables…
currentSongNumberCell.html(…);
// Sometimes we have not…
$('.left-controls .play-pause').html(…);
```

It's quite easy with jQuery to end up with a code base that's simply a flat "mess" of selectors, somewhat enhanced with the usage of variables, but all in all just a collection of instructions on how to edit the DOM. For small codebases, it will do; but as the number of lines and complexity grow, that will become cumbersome to reason about. To help with that, some people set to design "frameworks", that are responsible for handling the flow of data within an application: from a user event (click, scroll…) to its bound side effects (updating persisted data somewhere, and refreshing the display).


Hmm es het mer bim expense-item erstelle es date mitgä wo ned verhebt het. Darum isch s modal gar nie ufgange. Han alles updated und gstartet gha


why union?


This class name ("row main_content") breaks the page. You end up with the page without content.


@rzarzynski maybe we should have a more generic way to prevent unwanted headers to sneak in through this?


Sdatum vo hüt (glaub) im dütshce format (ddmmyyy) hets mitgä und de server het s iso format verlangt (yyyymmdd)


You mean `Object.keys(obj).length`


Yes, i was just update your source and it can work with multiple images :). Thanks for your code


@sreilly I noticed it right after posting my comment above. It looks perfect this way! Are you also adding this to the topbar? and in addition, can you add it at the top of each story like in the original designs?

![top-shadow](https://cloud.githubusercontent.com/assets/1379822/9996252/72a77a84-6086-11e5-9ed3-26e2db10a293.png)


If you are just fixing the indentation error in this change, why is this whole section of code deleted? Are there other things that you are intending to modify with this change that are not in the description?


This fixes issue #1


No big deal :) And you still might have been on to something, I just had a conversation with @Tiago-Ling on slack and the function signature seems noticeably different in cpp than for drawTilesItem.addQuad, so it still might be generating dynamic allocations, might merit some more investigation.


Excellent work.


Yes, have just about finished adding it to the top bars.  I'll pop one into the story cells too!


`Number()` is good. Leave it as is. Thx


Sorry, now issue can be added to this REPO


curious as to why you've unshared the scheme now?


Ah, I see. Thanks for clarifying! :)


Ik, but i am searching for a way to share variables

Question: How?


NB: I'm not offended by this language (Europe, or at least the Netherlands, uses these terms differently...), but it was quite surprising to see and most importantly very uninformative.


Good point. Although the burntime function is executed parallely and print in a almost random order, the final returns of pool.map() are the same, which is always 0-9. My guess is that the map() won't change the expected order of returns, and it may cause problems probably when the processes try to interact with each other.


Yes, you are right. Thank you.


Will fix.


The application requires a compilation/transpilation step, in development you can run it with `meteor run`, or use the already built application from the releases page. BTW you don’t need to execute this migration file manually, it will be automatically executed on the server start if the data aren’t up to date.

Does that help?


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8325/testReport/) for this commit**


@mbmufffin Looks like this should be `event.stopPropagation();` instead of `event.preventDefault();`. On a touch device, if you have a link inside of slide controls, that link will never redirect user when preventing default action. Instead the slider will switch to current slide and the event processing will end. If it was `event.stopPropagation();`, however, the link would redirect as expected.


Isn't a bit more elegant than "/(/" + userEvent.getUserId() + /")/" ? The requirements call for the userId to be parenthesized.


The optimal speedup should be 4x, but why in the graph the curve actually exceeds 4 at some points?


@Nakilon ah, totally makes sense! Can I use your implementation in RubySeeds? (I'm asking because it has "public domain" license as a principle.)


Looks like it will need dependencies eventually, but this is a great start, @evanshortiss.


See #9 as to why


on my provider skype port has blocked. can u give me contact on another messenger?


Hi grigi,

When I try to use this basic code:

import talkey
tts = talkey.Talkey(
    preferred_languages=['en', 'es', 'el', 'fr'],
    preferred_factor=80.0,
    engine_preference=['espeak'],
    espeak={
        'enabled': True,
        'defaults': {
                'words_per_minute': 150,
                'variant': 'f4',
        },
        'languages': {
            'en': {
                'voice': 'english-mb-en1',
                'words_per_minute': 130
            },
        }
    }
)
tts.say('Old McDonald had a farm')

I obtain the following language error:

Traceback (most recent call last):
  File "C:\Users\Pablo.Pablo-PC\Desktop\Sin título 0.py", line 42, in <module>
    'words_per_minute': 130
  File "C:\Users\Pablo.Pablo-PC\Anaconda3\lib\site-packages\talkey-0.1.0-py3.4.egg\talkey\tts.py", line 101, in __init__
    raise TTSError('No supported languages')
talkey.base.TTSError: No supported languages

What should I do to fix it? Thanks a lot :)


No you can still use VS2013. I think that versions dating back to VS2010 should be supported but I haven't tested it.

The reason I added a note about VS2015 is that the linked .vsix file isn't supported out of the box in VS2015 and requires some extra configuration.


Considering tests, I wasn't sure what kind of tests to add. The only options I know of are arguments for talking to an LDAP server, so we'd have to have some kind of mock or real LDAP server as a test dependency.


I'll check on that and add appropriate ifdefs in case they are needed.


Sure, I'll get on that.


LGTM


Thank you for the explanations, that's what I was supposing ans I do not found the meteor command in the default container.

The migration doesn't seems to be executed but that may come from singularities in my setup.


Thanks for the PR. I know the difference is not big but we should be efficient on what we do. Down the line, we might want to pull all this common code, that's used both here and in the JCache Remote module, into a single place.


put the close in a finally then


It was 4 spaces ?


Review complete. Nothing major, just a few questions and minor suggestions


@rzarzynski I think that the premise here should be different. We should have both tenant and bucket namespace. They might be holding the same value, but we should know under which tenant we're operating. The bucket namespace as I see it is just a technical pointer that helps us locate the data.


use EV_ERROR or cRuntimeError?


final isHungry = true;


On a few lines


I think assert() is fine


you're right. Didn't see the parenthesis.


 - __portability__: [include/chaiscript/utility/json_wrap.hpp:15](../blob/e62a38b39f1ccc8a246b765aca9ecc034ccc16a9/include/chaiscript/utility/json_wrap.hpp#L15) The extra qualification 'json_wrap::' is unnecessary and is considered an error by many compilers. (unnecessaryQualification)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/e62a38b39f1ccc8a246b765aca9ecc034ccc16a9/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/e62a38b39f1ccc8a246b765aca9ecc034ccc16a9/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/e62a38b39f1ccc8a246b765aca9ecc034ccc16a9/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/e62a38b39f1ccc8a246b765aca9ecc034ccc16a9/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/e62a38b39f1ccc8a246b765aca9ecc034ccc16a9/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


I' consider importing at least `Data.Aeson ((.=))` explictly to be able to write `.=` instead of `Aeson..=` which doesn't look very nice.


Looks fine to me. I'm surprised patchShebangs wasn't already being called.


## Brief self-introduction [max 500 words]


Also removed extra calls to semantic css


I got the feeling this generalization will bring quite a lot of ELO onced tuned!


Remove this comment as "max-width" is no longer here.


Good point.


1: M111 unrecognized component name: WebSubmit


ah good catch


103061520 蘇明合


yes, and also I think some versions of android can simply not provide the "game rotation vector", but that's a detail.


They're fine. I just hadn't noticed them before (or had forgotten if you
said something). The "greater than or equal to" implication of the symbol
makes perfect sense, now that you mention it. I just wasn't making that
connection for some reason.
On Sep 21, 2015 10:38 AM, "Kevin Hendricks" <notifications@github.com>
wrote:

> Hi Doug,
>
> If you mean adding the Greater than or Equal to char (>=) symbol in from
> of the fields for setting the Plugin Engine, then yes, I added those when I
> thought we were going to go with Python 3.5 and wanted to make it clear
> that any Python 3 >= 3.4 should work here.  They appear just fine on my
> Mac.  If they mess anything up, please feel free to remove them.
>
> Take care,
>
> Kevin
>
> On Sep 21, 2015, at 08:22 AM, Doug Massay <notifications@github.com>
> wrote:
>
> Hey Kevin... just checking if you purposely made these changes to the
> PPluginWidget.ui form when you updated the documentation in this commit, or
> if something weird happened. I just noticed those symbols showing up in the
> Manage Plugin preferences widget the other day and tracked it down to this
> commit.
> —
> Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dougmassay/Sigil/commit/2730aa52f982d7480c1f03af4b8297de8f0a34ba#commitcomment-13344193>
> .
>


Oh oh, one of our master tuner is already smelling blood...


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20985/testReport/) for this commit**


that's indeed the idea behind "*((volatile int*)NULL) = 0;" , git blame might even tell it


You were fine with the template the way it was before.


am I missing something - or do we have the repeated hash key 'user_env_key'?


if testJars does not exists then what ?


Ok, I understand, but I would like to validate Qserv/docker integration
before investing more. Today, this "public secret" is only used on
private/secure cluster at CC-IN2P3.
People knowing this secret can't use it to harm this cluster, unless
they belongs to Qserv team and have unix account at IN2P3.
The other issue would be that people can use our public docker images
with this built-in secret: they shouldn't for now, it's still a
undocumented WIP, and we can warn them in our doc.
This setup seems reasonable for running a multi-node test setup on a
secure cluster. (mysql pass is always CHANGEME in our current tests)

1. Quick and dirty solution is to generate a secret on the cluster, copy
it on all docker containers and then restart Qserv on all docker
containers, but it require some complex ssh scripting:
- Docker containers start services by default, so I would have to copy
secret and restart service on all containers,
- furthermore ssh access, required to copy secret, is enabled for
fjammes account only,
- docker access is enable for qserv account only,
- container doesn't have ssh service running.
=> this will require lot of effort to bring only a temporary solution.
I can do it before closing this ticket if you think it is really useful.
But this doesn't solve MySQL pass problem.

2. Managing gracefully a real secret is cost-effective and seems to
require a new ticket. There a real "secret" would be generated for each
Qser cluster, I think this will require something like etcd/consul+SSL
to share it between all docker images. MySQL pass whould be managed the
same way.

Would you agree with that?

Cheers

Le 21/09/2015 15:52, ktlim a écrit :
>
> We really should do this the right way from the beginning. Secrets
> should never be committed to git or pushed to public services, even
> temporarily.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lsst/qserv/commit/1751ebfc9853e69422ad0223e096b0b3347572ed#commitcomment-13342892>.
>


By twisted domains, do you mean on the domains generated by each of the functions in fuzz_domain()?  If so, this change does iterate through each of the TLDs for each function.  Each swapped TLD will be passed to each of the fuzzing functions.


Sure, I'll do a PR. But it's not like that screenshot is fake. Best to check for properties before trying to access them.


hi EyelessWerewolf here. i am not a human and take great offense when called a human... i am however a timelord and suck at typing. yeah, yeah, yeah, you may have heard of timelords from the hit show "Doctor Who" but i tell you now we are (i want to say 'nothing' like whats portrayed but we are) similar to whats portrayed... thats All for now....... Bye!


ок


Since winfork is merged into bleeding, is it obsolete?


Hmm...that will work during the image build, but it'll still appear at runtime.   That might not be a big deal though.

It seems like what we want here is to be able to turn off repo injection from the Red Hat docker.

/cc @rhatdan


Yes. There is no `syscall.Statfs` on those OS:es, so this changes that from a build failure to a runtime error return. (This is easily testable by just building with GOOS=solaris etc.)


Feel free to ask questions about your particular setup on [the forum](http://discuss.wekan.io) — it will be a bit more convenient to talk there than inside a big commit diff file ;-)


@lluismf i have just reverted this at https://github.com/openmrs/openmrs-core/commit/845f05db7a304fd1eab16d707d6329f4aa2768a8 until when then new line ending problems get sorted out.


@maruilian11 because we couldn't identify this kind of license. (see #5544)
Please use a `object structure` to show the license's `name` and `link` in repo .


We're certainly aware of standards and best practices for PHP. There was a lot of work done on this plugin in a very short timeframe by a number of parties to make it available to the community for launch, so it's possible something was missed. No one is making any accusations of fake screenshots. Additional community contributions are most welcome.


103061520 蘇明合


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8326/testReport/) for this commit**


This is a weird case because this code relies on the fact that the invalid delimiter *encoding* ends with the byte `0xfe`, which is kind of weird and janky. This whole bit of code has gotten pretty nasty and hard to modify or reason about.


ok


What's an example here that broke?  Are you doing e.g. "7.1" for `docker_os_name`?  That looks like it'll end up with multiple `/' which seems odd.


`PublishArtifact` doesn't carry the information, so there is no way to populate it here. See https://docs.gradle.org/2.7/javadoc/org/gradle/api/artifacts/PublishArtifact.html .

Moreover `extraInfo` is a property of the publication, not of the artifact. One might think that this shouldn't be in `PublishArtifactInfo` then, but JFrog has been consistently using this class in `BuildInfoPublicationsTask.java` for both the artifact properties and the publication properties.


Should have been "strech", not "streTch" http://www.factorioforums.com/forum/memberlist.php?mode=viewprofile&u=10084


upstream-disto-branch are all "core" defaults and can be removed


yes - good spot! will fix. :)


Maybe start using git reset --soft?


Reverting the agent to pre-s3_file cookbook version, v3425 (Jul 27th 2015), worked and I'm able to do my deployments. Judging from the logs, I was in 3427-20150911163841 when it was failing. Changelog lists v3426, but that one is not available on OpsWorks console, so I can't test with it.

I think lesson for me is to lock in to whatever works and auto-upgrade after manual testing. I've been having regularly to lock versions of various chef cookbooks we use too. Hard won knowledge, let me tell ya', when you learning chef on the go while managing production site :) So it's entirely possible that something else in my stack is causing this s3 download problem with s3_file...

Btw, will s3_file enable us to use instance roles? And thanks for replying to a comment on a commit., 'twas late and I didn't know the best place to look for support.


oh no, this needs to change.  Don't put a default password on this @tremainebuchanan.  Just seeing this.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20986/testReport/) for this commit**


I think that was also a very good analogy that Pilgrim made as to how HTML has essentially stayed the same despite its history. The fact that we can still look up web pages from 15 years ago is also very impressive because it shows that HTML still has the same, as you said, “core values and functionality”.
I was also surprised that W3C created XHTML to stop errors from occurring and based on its main function, I would have disliked using it too.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8460/testReport/) for this commit**


The plan is that there will be a default `String` type that can hold arbitrary data and interprets characters as UTF-8 when valid and as bytes otherwise; the new `Char` representation supports this and makes it efficient. There will also be ASCII and UTF-8 string types that check their data upon construction and only contain validly encoded data.


It looks like you might have already been able to solve the problem.

But one other solution to the problem is to just check if the dirty title exists in the directory along with the clean title.

This would keep user's from having to download files again and going forward they would have clean file names. We wouldn't have to do any migrations then either.


This is correct


Makes sense. I will use my fork + pull request next time.


Commit new database test specs


Hi Kevin,

What are you working on? Would love to chat about where you're taking this - what's your twitter username?


Yikes.


Nice, also so you know, you can pull these widgets in via Composer. It's a bit quicker, just add the widget to your `composer.json` file and be on your way :)


Yes -- thanks for the reminder.


Autogenerated .gitignore are evil (and stupid, and anti-git) - just saying :)

FIXME's won't ever hit dev - goes without saying you may add as many as you please in your branches but I would suggest you use an IDE:

![toobroadexc](https://cloud.githubusercontent.com/assets/1365079/9996948/eadd5480-6089-11e5-8d40-ce15d4c89626.jpg)

The `except pass` is serious problem though and I am glad you acknowledge it - I do not have time to review your next (more substantial) commits now, but will do - keep thinking on it. Search commit messages to see how I have been tackling it for the past year.

But I would suggest you turn your attention to more defined tasks for now - factoring out common code in the importers (see 200) blocks some final refactoring in the links modules (and a couple other things)

Thanks :)


no, l mean defining the functions locally, l don't think other mods use the functions of this mod.
http://dev.minetest.net/Lua_Optimization_Tips#Prefer_local_variables
http://www.lua.org/pil/4.2.html


Also have some reservations about the default value for the `ut_user_type`.


https://github.com/GlowstonePlusPlus/GlowstonePlusPlus/blob/master/CONTRIBUTING.md#rules

Modifying the git history is against the rules.


GroundDomainUpdate (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1872 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.svg)


Done!.


This is the retrieving logic. There is no way to read the user-defined tokens from `ivy.xml` here before having actually retrieved it.


ah das ist der fehler den hatte ich auch nur noch keine idee was das ist, gut erkannt


Can we move "control_node" into the sequence of "nodes"? That also serves an example to write development.yml.


Shouldn't this still be os.remove(list_path2)?

newfile should be closed automatically at the end of the with block


why?


> set_prolog_flag(clpfd_goal_expansion, false)

Thank you. That's very helpful for debugging.


Actually 5.0.2


I also think it's important to note that even though errors did occur in web pages using HTML, it was able to self-correct and maybe recognize those errors. Pilgrim also stated that over 99% of web pages had errors in its markup. However, if those errors didn't negatively affect how it functioned, I'm not too sure why W3C wanted to prevent it from happening.   Maybe it was just something that they did not think should be happening.


This wasn't necessary but I think it's a nice feature: doing so, the user-defined tokens set on the publication can also be used inside artifact paths.


yes


Closes #11


LGTM


There is no such thing in `MavenPublication`. See https://docs.gradle.org/2.7/javadoc/org/gradle/api/publish/maven/MavenPublication.html .


抱歉我上次因為咪挺沒有上到後半的課，希望你們伺服器沒收到奇怪的commit


@simonbrandhof thanks to review this commit


@danielhickman Haven’t forgotten about this, thinking about whether or not to. 💭


Demo installing i18n & ember-cli-materialize.


@Jonty this looks good but please use our normal pull request workflow even for relatively simple changes like this. As a team we've found it to be valuable in catching small mistakes, finding edge cases that we hadn't previously considered, ensuring that code is understandable by other members of the team, and raising awareness of what components are changing. We've had problems before, with this repo in-particular, where regressions have been introduced directly to master that would have probably been identified by peer review. Grab me if you'd like to chat about it more.


show translation in template


!!
ありがとうございます！


This does not work with wrapper cookbooks, try changing the version in a wrapper cookbook and see what happens.


Here's a comment!


Show i18n and template here.


*guide


Show translation file.


In Gradle 1.8, `IvyModuleDescriptorSpec` didn't exist. It was called `IvyModuleDescriptor` and didn't have the `extraInfo` property. Gradle 2.1 is the lowest version with which this feature can be implemented.


Show acceptance test.


Here is a comment!


Show router updated.


We only need 5 items here, So we are using that number


Show link-to acceptance test.


@matjames007 removing this at this point will prevent an admin user from creating a  new user.


Phew.


Show model.


Show model hook


Show updated template with model data


Got your commit!


@timfallmk and @BenWhitehead Why do we need `openjdk-7-jre-headless` is this because of `dcos spark`? We need to figure out a better solution for this as other subcommands may have more requirements.

I am all for hosting this in the DCOS CLI repository and pushing docker images as part of the regular DCOS CLI release process. I have made changes to the CLI that allow you to install the CLI in the root filesystem. This is the Dockerfile I have right now:

```
RUN pip3 install --upgrade dcoscli

CMD ["dcos"]
```

and it is run as: `docker run -t -i --volume=/home/jose/.dcos:/root/.dcos jose/dcos`


Good approach! Maybe storing the result on a variable and calling "cout <<r<<endl" at the end instead would be even better ;)


Show error template.


Because it's not used anymore.  I moved the block that used the $scsi variable to the bottom and changed its conditions so it's basically an "if all else fails" catch-all now.

I figured [this](https://github.com/ceph/ceph-cm-ansible/commit/d9db045141b08d90fdf68e4168639fca4288123c#diff-16ea2b6366719c8f3f3b4c818a8e8be8R204) made more sense versus continuously adding || statements to [Line 130](https://github.com/ceph/ceph-cm-ansible/commit/d9db045141b08d90fdf68e4168639fca4288123c#diff-16ea2b6366719c8f3f3b4c818a8e8be8L130) for every new SCSI card chipset we get.


Now that we build with Gradle 2, Groovy 2 is being used. I took here the same version as in the project `artifactory-maven-plugin`, which is the only other project having this dependency.


Show simplified version of this file.

clean up this file.


Show fixture.


Dark...


Also show ember install.


I would make the maintainer: `support@mesosphere.io`


`ember g fixture company-addresses`


Show timeout & demo loader.


Show loading template.


It is actually moving, so I set it back to prio 0


Show component source.


What it?


Show update to mirage.


Can you move it into imageon_bridge_async_bound() after the set_edid call? I think that should be the saver variant.


Show template here.


semi-colons?


Good call. Like that much better.


Show including the template.


Much better. Why do I suck at naming so much...?!


private val?


Got this.


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1345 of 1345 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.28%25-green.svg)


Got it.


Are you sure 0.4.1.post473 works correctly with SQLAlchemy 1? As of 0.4.1.post473 it was not the case.


The issue is that someone with access to this code-base (everyone on GitHub) could guess authenticated by guessing a user's newly created email.


Here's a comment!


Съехавшее форматирование. И кому понадобилась эта зависимость?


Haven't solved the problem AFAIK – I would expect this test to fail on Windows, but maybe it doesn't?

True, we could keep the "dirty" files instead of renaming them. Has the benefit of not renaming stuff that might be in use, and it might be less code overall. On the other hand, I kind of like how the renaming keeps the file structure more consistent.

As far as this test running on Windows is concerned, I guess it would apply equally whether we skip files or rename them.


@rift137 I added that type of logic to the feature_call_to_action_button() method in the feature_helpe.rb file. maybe we can just pull out the logic and use it for the feature call to action button and the watch and listen cards.


Зачем комментировать, если можно удалить?


TeamCity pull requests :: netty [Build 227](https://garage.netty.io/teamcity/viewLog.html?buildId=1522&buildTypeId=pulls_netty&guest=1) is now running


Не хватает модификатора `private`.
Зачем сокращать `repository` до `rep`?


> In other news, I added the popup modal with the list of errors to the UI.

Awesome!

Does the version string give any hints about what app it is?  I'll take a look later and see if I can find out anything.  Otherwise we might have to wait on mobile dev for that part.  I do think there's a reasonably small likelihood of two apps on the same domain having versions of the same number which are both active.
#thingswellhavetofigureoutbeforethisgoeslive


Реквестирую больше пробелов для лучшей читаемости!


Yes, agree, it’s a better idea.

Thanks,
Dragos

From: Lars-Peter Clausen [mailto:notifications@github.com]
Sent: Monday, September 21, 2015 7:08 PM
To: analogdevicesinc/linux
Cc: Bogdan, Dragos
Subject: Re: [linux] drivers/media/platform/imageon-bridge: Hotplug GPIO should be set after the EDID is programmed. (f43adc8)

Can you move it into imageon_bridge_async_bound() after the set_edid call? I think that should be the saver variant.

—
Reply to this email directly or view it on GitHub<https://github.com/analogdevicesinc/linux/commit/f43adc8b1356daca24f9906ab6add1993067d041#commitcomment-13346567>.


I see your pull request!


Эта аннотация точно здесь нужна?


I also thought it was interesting that Pilgrim said the progression of HTML over time has been very linear because although it has evolved over time, it still has the same principles and older web pages are still viewable. This is the opposite of what Haas' would probably have argued. I wonder if both Pilgrim and Haas are saying the same thing, despite Pilgrim believing that HTML has been linear, and Haas believing that technology is not linear. What are also the differences in their arguments?


indent the try block.


Либо одна аннотация, либо другая -- зачем здесь сразу две?


It occurs to me we should be XML-sanitizing target_value before using it in the xml_id (it can contain arbitrary characters). I don't see a readily available function for that, though. URL-escaping isn't sufficient (% is not valid in an XML ID). Maybe %d with hash(target_value).


Not a fan of the way the styling linter makes this way less readable. But I guess its just my subjective preference.


I'm at the office right now, so I can't test it on my windows box. But I
will give it a shot when I get home tonight at let you know what errors pop
up.

On Mon, Sep 21, 2015 at 11:10 AM, Henrik Nyh <notifications@github.com>
wrote:

> Haven't solved the problem AFAIK – I would expect this test to fail on
> Windows, but maybe it doesn't?
>
> True, we could keep the "dirty" files instead of renaming them. Has the
> benefit of not renaming stuff that might be in use, and it might be less
> code overall. On the other hand, I kind of like how the renaming keeps the
> file structure more consistent.
>
> As far as this test running on Windows is concerned, I guess it would
> apply equally whether we skip files or rename them.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/henrik/sipper/commit/7a72cc726e704bad195a04dff378380802f5a1fd#commitcomment-13346632>
> .
>


Awesome, thanks!


Thanks - merging.

We also have lots of tests in e.g. `wxml/test/` etc.  I'll try to work out if these can be included without too much rewriting of the shell scripts that do the work.


I like your solution of fixing the sidebar after a certain scroll position is reached and not having the header bar fixed.
LGTM.


Small typo in the commit message.


Зачем глушить предупреждение, если можно легко переписать код?

```
if (si == null) {
    return null;
}

return peopleRepository.saveAndFlush(si);
```


We should not include comments representing the FFmpeg project like this in our code.


The mode handling is clever but I think an enum would be more readable.


Почему у аргумента такое странно имя? Что это `si` означает?


Fixed in f33f512979b0f41f780c5e1d8c9700e4823ec490.


noob


Зачем так много пустых строк?


Should this be `getLogger(__name__)`?


Use mlt_log_debug instead of fprintf.


Sure, np.  :smile:
The testsuite is very efficient by the way. It reuses servers across suites and also the admin client. Currently it takes 2 min for me (~1min for each scala version). The bottleneck atm is to start the server: when in clustered mode, it takes about 20 or 30s to start (is this expected?). There goes half of the time of the whole build.


This commit is out of date. We already have made changes for API.


You sure you can skip the accessibility test ?


Renamed for better explanation in f33f512979b0f41f780c5e1d8c9700e4823ec490.


TeamCity pull requests :: netty [Build 227](https://garage.netty.io/teamcity/viewLog.html?buildId=1522&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4810, ignored: 16 Build time: 00:06:34
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testQueryMx: <no details avaliable>

```


@luqmaan: Should we add the output html files that get built from templates to `.gitignore`? I see the `dist/` directory added in there.

Then we'd just need to make sure the dev branches' `.gitignore` doesn't get into the `gh-pages` branch? Is that a pain?


Won't this invalidate any existing configurations using a regex in target? Should the CIB updater maybe check for regex characters and automatically convert target to target-pattern in that case?


What is the purpose of this line? Cleanup before making a pull request.


Reverted to previous code with some enhancements in f33f512979b0f41f780c5e1d8c9700e4823ec490. Support file with ".r" name -> suggested name will be `null`.


Awesome. So I think there is one more issue that is left when it comes to small screen. Links to youtube videos are not being resized (Example the video on top of the page when you select "Home" option). I played around with css and if you add:

.main_content iframe {
  width: 100% !important;
}

it can be fixed. Of course this is a bit hacky since it uses "!important" though it could work in this case since rarely would people style iframes on this page. However if you have a better solution that too is welcomed.

If that is fixed then this change will be good to go.


Implemented. :+1:


I think you might use spongeapi since sponge requires spongecommon which is not on the public maven of sponge.


Spurious newline...


Fucking lel


Same fault as happened in `MixinPortal_01` again.


Understood. I will have to write code to auto generate a password once the administrative user creates a new user.


Нет, в последующем добавлю PasswordEncoder


should this be `fpm_wait.pid` instead?


As I review these again, I can't help but comment on this great thread. @alexandradepalma reviews what I think she meant as people who were to become "web designers" appropriated the table element to serve design needs linked to print media / graphic design practices. @jkbuckeye, you raise some good personal points of clarification about this matter in connection to Brosset's exposition on the new spec for the CSS-Grid Module. @mattmuroya, I agree with much of what you add about connections between Dilger and Brosset.

I'd add that the writing practices framework that I am pushing for us to analyze these forms of digital writing help us see how web-based writing and design is intertwined with print-based graphical design and writing. Yet, web developers and designers, such as Brosset, notice recurrent, goal-directed skills that manifest in code libraries like Bootstrap, Pure.css, 960.css, etc. Such an abundance of grid frameworks and the consistent use of them over time have created a need within the greater community and culture to standardize CSS grids (in relation to Browser tech!).

Like all of you, I'm very curious about Dilger's opinion on the CSS Grid module proposed and implemented by the CSSWG as related to his "Grid 2.0."

So much to chew on here!


Почему бы нет?


a typo for path, I mixed batch & path…


Confundi o enunciado. Vou corrigir.


At best it will end up 111 and 144. Can that make any difference compared to the original values ?


I had left a copy of the required packages in README.md too, so that someone who already has these things installed doesn't have to go figure it out from INSTALL.md


Boa. Vou retificar.
Valeu.


deleted


Good catch. I'd forgotten about this. :P


lol noobs xdddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddddd


libswresample is not available in Libav, and we primarily use libsamplerate - independent project with legacy FFmpeg resampler as a fallback.


Я пока не знаю, с чем едят Liquibase.
Конечно, буду переделывать - ты ж тимлид, даешь задание, а я (кто там перед джуном по иерархии?), не? )


Wouldn't `format()` be a bit better here ?
`subject_template = 'Image {image}; Status {endstate}; Submitted by {user}'`
`return (subject_template.format(**formatting_dict), ...)`


ok


test this with actual gps points yet?


please remove this as fast as possible. Having `change`inside `new` is a dangerous bug. Do you know any way we could avoid this bug happening in the future? Maybe removing value from the signal call!


It's a typo, but at least used consistently :) (8 occurrences in the code)


ok i c , sorry about that. I will revert it


Apparently he discovered that you don't need the overwrite annotation if you're overwriting a forge/fml method.


Shouldn't this be ">= 3"? Enum would be obvious :)


Потому что много вариантов получается. По логике их всего два -- вкл/выкл, а в БД может быть еще NULL или -100 или 173 и как их интерпретировать тогда? Особенно весело c NULL, потому что он потом еще и к NPE может привести. Вообще, если можно как-то защитить данные в БД, чтобы они не были противоречивыми, то это нужно делать.


Знаю, сам так не делаю. IDE почему-то иногда принимает решения за меня, а я это динамлю (


Why don't you use Guava or commons-lang ??


I wonder if it's worth changing this default in 5.x or 6.x?


Тогда настрой свою IDE да и все.


А смысл? Какая разница, как пакеты обзывать?


wtf!


this is a inplace change, please consider using the new `artview.core.Variable.update` method instead of `artview.core.Variable.change`


Apparently Observables will unsubscribe when they complete, which is implicitly doing call.cancel() and at the moment you can't do that on the main thread. Jake advised me to add .unsubscribeOn(Schedulers.io()) to work around the issue, which moves this call.cancel() into a background thread and avoids the NetworkOnMainThreadException.


Please remove comments. If you can summerize something, you van C reá te functions too.
End of startup ? Let me call you George :)


Because Guava just accepts 2 parameters. commons-lang provides the feature starting with the 3.0 version which we don't have


Вот! Всегда интересовало, что это дает?


:+1: for having this on 4.x for BC reasons, but maybe it's best to be stricter on 5.x or 6.x? What do you think?


So [this] (https://github.com/ForgeEssentials/ForgeEssentials/blob/develop/src/main/java/com/forgeessentials/core/preloader/mixin/entity/MixinEntity_01.java) works the same? This type of mixin is not ever mentioned...


А это - что дает? При изменениях в базе придется еще и менять здесь?


The current model wants Sslcert as the type of measurements.


I added in the description it's taken from commons-lang


Agreed, this should be an internal variable. I will update. Thx


@michaelklishin I tend to prefer to never include any logic in setters (and getters), except in specific obvious cases where you can validate against constant values (like ```value > 0```), but never against any other property value (the current state that is not finished) (like ```prop1 > prop2```)
This allows the properties to be set in whatever order.

In order to perform validation, I like the ```PostContruct``` method (like the ```afterPropertiesSet()``` in Spring Framework)

This may or may not be introduced now in ```ConnectionFactory```, considering there are existing users of the class.
Considering that validation is a new feature, it may be provided to opt-in users that call a new ```validate()``` method.

Or, if we want to enforce validation, without adding a new method for the users to call, and without breaking anything for existing users, we can copy and validate the state as a ```ConnectionFactoryConfig``` Object uppon first ```newConnection``` method call. When a property settter is called, the validated ```ConnectionFactoryConfig``` is set to null, so that it is rebuilt and revalidated uppon next ```newConnection``` method call.
In order to make this clear, please have a look at this commit : https://github.com/YannRobert/rabbitmq-java-client/commit/aa1f3144827b9fe4ec5133b55e2959ac9768c616

I like this solution, because it provides other benefits such as
- evaluating all the properties together, and making the validation aware of the context (like if we do not use SSL, then it may not be needed to validate the ```handshakeTimeout``` at all)
- avoids recreating new temporary Objects on each ```newConnection``` call (like ```FrameHandlerFactory```)

Alternatively, we can also make a quick (and dirty) boolean switch only when a sensitive property is changed, and check for that boolean in the ```newConnection``` method call to execute the validation.


They were overridden with annotations.

Fixed in f33f512979b0f41f780c5e1d8c9700e4823ec490 because annotations has been added to `AbstractRunConfiguration`.


We still need this


Раньше я добавлял, а теперь на это ругается IDEA (раньше Eclipse не ругался). Я немало удивился, но поудалял.


verry nice


ok @Caffe1neAdd1ct thanks and still more cleaning coming to postfix stack as it relied heavily on postfix admin.


Моя болезнь. Ты прав - я слишком тороплюсь.


the argument is optional, in which case optarg will be NULL. This will explode if actually somebody omits it.


good to important


Can you submit test for interpolate func?__interpolate_string needs some refactor at least a minimal.


actually, the changes I was thinking of are more than insignificant, so I'll implement it better in the AI rewrite, but we'll leave it as is here until then (and hopefully there won't be any client patches before I finish the rewrite)


Надо было разобраться почему и на что она ругается, может там ошибка закралась? Или IDE неверно настроена.


We should not introduce another low-level util class, as there are already tons of them available through commons-* and guava. Upgrading to commons-lang3 can be an option. Using Guava through intermediary list is another option if caller does not require high-performance (``` Iterables.find(Arrays.asList(myArray), Predicates.notNull())```).


Changes in 3 files as expected (well I said 2). Let me look at the annuals. Do we need a change in the documentation?


googd tem...........


print("Hello World")


As commented previously, I prefer having two nested Guava Objects#firstNonNull(o1, o2) then introducing a new ObjectUtils class "just" for that.


lgtm


At the present, "all settings" appear to mean "all settings but including the master password".

In other words: currently, the master password is not cleared (but should be cleared, too. In my view).


Leading tabs get inserted in this patch.

$ git config core.whitespace blank-at-eol,space-before-tab,tab-in-indent
$ git diff --check

should dump then


first this is wrong: `Vgatefilter` must be `None` or `GateFilter` instance, `radar.fields[]['data'].mask` is a masked array.

Second: I don't understand why changing field should change gatefilter, gatefilter is radar specific, not field specific. Every field has a mask of its own and that is not to be mistaken for a gatefilter.

Third: I'm not convicted that `RadarDisplay` has the authority to change `Vgatefilter`, as it is only a passive user and don't have administrative functions, like it has for field and tilt (drop-down menus).


o


If object is not necessary why don't you eliminate everywhere ? If I remember well in a previous commit you added object after class definition, because of pep. Which is the preferred form ?


Must correct this line to:
>fnoisethr = fnoise_resp/fnoise_activ


assuming that you `git grep`ped for graingert and notthing else turned up :)


В нашем случае ничего кроме того, что по сущности сразу будет видно строение таблицы. В целом же подобные атрибуты позволяют генерировать схему БД. Т.е. ты сможешь не писать отдельно SQL-скрипт, а сгенерировать его из сущностей. Плюс у hibernate-а есть режим при котором он либо создает, либо валидирует базу на основе этих ограничений. Благодаря этому, он может обнаружить, что какая-то миграция не применилась, БД не в том состоянии как мы хотим и зафейлить приложение при старте.


thx to miss.Peng!


Use

```
BrowserDB.varlist(historyRowIDs.count)
```

passing the IDs as args.


@maikhoepfel Nice One Thanx


Usually, we try to parse command line arguments in full when we first look at them, and then only keep parsed data around. I'd prefer this in this case too, i.e. please parse the arguments already in parse_argv() and make the veth strv one of pairs, i.e. where two subsequent ones belong together. We can nicely iterate through "paired" strv's using STRV_FOREACH_PAIR() which always gives you two entries, instead of just one at once.


Nice catch.


```java
throw new PrestoException(HIVE_UNSUPPORTED_FORMAT, "Compression codec not found: " + compressionCodecClass, e);


...если очень захотеть, то можно сделать как-нибудь, чтобы приходилось менять ровно в 1 месте :)


Mask is not really an attribute of RadarDisplay, so I'm not really sure it should have a getMask.


Probably need to catch `RuntimeException` too:
```java
throw new PrestoException(HIVE_UNSUPPORTED_FORMAT, "Failed to load compression codec: " + compressionCodecClass, e);


canola?


We need to parse XML_ATTR_STONITH_INDEX, right? id stays 0 currently


Смысл введения пакетов, чтобы не пересекаться с другими разработчиками. Т.е. test это очень уж распротраненное название, то шанс таки есть. Ну и лучше с самого начала привыкать к нормальному наименованию.


I don't feel ok with tonumber()'ing things in general (what if the function will also accept strings in the future?), and the problem was solved at the root in SNDMSG anyway


you probably mean `return self.Vgatefilter.value`


@lpsandaruwan Nice!


@geohuanglei does Win64 work without the `--xdisp` argument? Thanks, this will help diagnose the issue.


Add min/max validation


@willkelleher : this is the GYP part that will set a define (across everything/all targets) if -D var=val is passed to gyp. The rest of this (connecting it to cmake) will come in a StagePresence PR that pulls this in...


Added Take Three


Your code looks good to me, clean and efficient. I've never seen the np.linalg.pinv() command, I will use that in the future.


@wfbuhl Need a newline/return at the end of this file.


Solid name.


While switching from XML_ATTR_ID to XML_ATTR_STONITH_INDEX seems logical, won't it cause problems in mixed-version clusters (e.g. during rolling upgrades)?


I'm really convinced that we should make an empty GateFilter here, why couldn't we just return None?


@StefanoRaggi -- as always, thanks for cleaning up after me :) I will pull this in.


Yeah, this really should become a loop, so that people can define arbitrary numbers of veth links. I think the way this should work is like this:

1. if you specify `-n`, or `--network-veth` without argument, you get the default mapping, where the host side is called "ve-xyz" as before, and the container side "host0".
2. if you specify `--network-veth=` with an argument however, you'd get an additional tunnel set up. If you specify a pair of names, that's how the ifaces will be called in host and the container. Or you specify only one then the two interfaces will be called the same.

And of course, if you only specify 2, you get no 1, and if you only specify 1 you get no 2. And if you specify both 1 and 2 you get both. And if you specify 2 multiple times you'll get many veth interfaces, but if you specify 1 multiple times you will get the exact same thing as if you had specified it once...

Makes sense I hope?


b recebe 1


`sites.flatMap { $0.id }`


Vgatefilter is not an argument of `__init__`


Great of you to fix this


Would this be more clear as `override-table-format` and default to `false`? Then when you configure it, you are enabling a behavior (rather than disabling).


MediaInfo = true
SeekByTime = true
DLNALocalizationRequired = true
DefaultVBVBufSize = false
WrapDTSIntoPCM = true
H264Level41Limited = true
KeepAspectRatio = true
RescaleByRenderer = false
TranscodeFastStart = true

This works good and fast for Vizio TV


can you remove the trailing comma on line 31
also, can you add config items for chirp, pin, chat, and blog. @arw180 or @clarkjefcoat will update the deployment to change these to the appropriate paths


@Serneum


It was made exactly as you suggested in the check in after this.


Seems simpler to CRM_CHECK(match != NULL, return);


> is uniquedrives just because failedout, like out, might have more than one entry per drive?

Right

>  I think I'd prefer to fix out as well (like say that drive has "N failed, M uncorrect sectors", and then we could just count @out; what do you think?

I agree.  Although now that I think about it, do we really care what the actual sector count is?  If the count is over the threshold for any sector type, should we just add the drive to @out and say "Drive X failing"

I think if we're going to re-write it to say "Drive Q has X reallocated, Y pending, and Z uncorrected" we might as well re-write this in python or whatever $more_manageable_language


I am not sure if that will work.  Are you just trying to block yum update from within container?

Would it be better to remove subscription-manager?

RUN yum -y remove subscription-manager


@wfbuhl For tests like this, it's safer to use EXPECT_NEAR(  14746.226690452937, HWBaseboard( 1 ).TotPower, 0.00001 );


Why did these get "no doc"?  They are useful functions that I think should be exposed and documented.


@ttuegel My understanding is that tests should only require `-threaded` to support `--show-details=streaming`, but detailed tests don't currently use that option.  I think that the problem in https://github.com/haskell/cabal/issues/2489 is that `rawSystemIOWithEnv` blocked by calling `waitForProcess`, and `hGetContents` was called after `rawSystemIOWithEnv`.


why this?sorry


isn't charge_counter = charge_max needed here?


Can you put the reason for not going up to 4.3.0 in the commit message? That will help the person upgrading this gem.


i saw this edit on tg too but i don't understand its use,is it something codewise or..?


why not as mob?


sensory?huh


why did ya remove var?sorry


here we are getting the gatefilter of display, this has one problem and one But. First gatefilter is a dynamic class, so alteration are done in place, so getting gatefilter but not Vgatefilter will make display confused, since it will change but no signal will be emit (or the emitted signal will never reach display). The but is the question, if we really want SelectRegion changing the gatefilter from display, may be we (the user) want the gatefilter to be used in an other plugin but not in the display.


I got lost in Github's search or *blame history* for `netdissect-stdinc.h`. Hence this comment here.

I'm not sure how or when `netdissect-stdinc.h` got broken on Windows. But WinPcap's `<bittypes.h>` seems to be required when compiling `print-bt.c` + `print-nflog.c`:
```
--- a/netdissect-stdinc.h	2015-09-21 16:55:54
+++ b/netdissect-stdinc.h	2015-09-21 15:33:35

@@ -56,7 +56,6 @@
 #include <io.h>
 #include <fcntl.h>
 #include <sys/types.h>
-#include <bittypes.h>   /* in wpcap's Win32/include */
```
otherwise compiling `print-bt.c` (MSVC) yields:
```
F:\MingW32\src\inet\libpcap\pcap/bluetooth.h(42): error C2061: syntax error: identifier 'u_int32_t'
F:\MingW32\src\inet\libpcap\pcap/bluetooth.h(43): error C2059: syntax error: '}'
F:\MingW32\src\inet\libpcap\pcap/bluetooth.h(50): error C2061: syntax error: identifier 'u_int16_t'
F:\MingW32\src\inet\libpcap\pcap/bluetooth.h(51): error C2061: syntax error: identifier 'opcode'
F:\MingW32\src\inet\libpcap\pcap/bluetooth.h(51): error C2059: syntax error: ';'
F:\MingW32\src\inet\libpcap\pcap/bluetooth.h(52): error C2059: syntax error: '}'
```

I built windump using `-DHAVE_PCAP_BLUETOOTH_H` since my libpcap do have that. Maybe that is naive since WinPcap cannot capture and hence windump cannot decode Bluetooth. Or?

Same issue with `print-nflog.c` with `-DHAVE_PCAP_NFLOG_H`.


@heiko-braun The DMR should stay the same as I'm not adding any new fields. The only thing that changes is making those fields mandatory so as a result of that they always have to be present in configuration as no default value is provided.


I calculated a number very close to this. I like the way you wrote this out line by line,.


this doesn't work,that's why i added in oview as nalar suggested


@wooorm Okay great looking forward to it.


we don't have organs damage


Please use the g_return_if_fail() macro provided by GLib here instead. It makes programming errors that much easier :)


add this back, otherwise reviving is too op


Maybe before this "start-server" line add something about "cd firecloud-ui" or "Inside the docker in the shell change to this repository's directory.  For example, "cd ~/broadinstitute/firecloud-ui/"  That add some clarity and context and helps make sure that the "./script/dev/start-server" command won't fail because of an error such as "-bash:./script/dev/start-server No such file or directory "


@tjwebb @kevinburkeshyp do you guys have time to jump on a Skype call about this?


Das sind gar nicht die letzten Änderungen.... hm... muss das nochmals anschauen.


this spell was refused by headmins,remove


the restored gatefilter is a empty one (`GateFilter.include_all()`), not with the mask of a specific field.


@kostya Thanks for letting us know. Apparently there's something about the new way we compute backtraces that is making this slow: LLVM doesn't want to inline some methods that previously it did. We still don't know why, but we'll definitely fix it for the next release.


i think it was a nice ability so i left it, not sure if we should leave it


Move null check out since it is used by both


You can probably remove the comment above now.


What's the `+ 1` for? This causes the table to overflow its width by one character for me.


Thanks, but this only applies to the github resolver: `github: ysbaddaden/minitest.cr`


flag_inv = 0 so it doesn't show as unknown


What is it being replaced with?


Очень сложно ревьювить сразу много кода. Кроме того, не атомарные коммиты и коммиты в которых неясно описано их назначение усложняют ревью. Собственно, это в ваших интересах получать быструю обратную помощь, но т.к. выдаете вы сразу много кода, то обратная связь затягивается :(

Я удивлен, что вы бились над проблемой, не могли ее решить и не спросили меня. В итоге, как понимаю, переписали чуть не весь проект в попытках исправить. В реальной разработке, это может сильно вредить вам :( Настолько сильно, что я знаю случаи, когда через некоторе время таких коллег даже увольняли, т.к. начальник был ими недоволен.

Попытаюсь объяснить идею с точки зрения любого тимлида/менеджера -- управленец хочет быть в курсе того, чем вы заняты и не хочет, чтобы вы "залипали" над задачей. Почему? Потому что это время, а время это деньги работодателя. Кроме того, очень часто ваш начальник лучше разбирается в теме и вашу проблему он мог бы решить очень быстро, поэтому, когда он видит, что вы потеряли день, а с его подсказкой решили бы за час-два, то это оставляет неприятный осадок. Если так повторяется несколько раз, то ваш профессионализм начинает меркнуть в его глазах.

Т.к. я не плачу вам денег, то мне в целом не жалко вашего времени, поэтому конечно вы можете хоть месяц что-нибудь делать, но в реальной жизни все из видимых мной руководителей этого не любят. Поэтому не стесняйтесь спрашивать, тогда будет хотя бы возможность вас вовремя направить в нужное русло.


no organs, revert the dethrall surgery to my one,it was pre-organ


В следующем коммите биндю. Exception словил и забиндил.
С User и Login произошло следующее:
сделал таблицу users, сущность User.
Обнаружил, что в UserDetailServiceImpl User можно спутать с коробочной версией и решил переименовать.


I like how you placed everything in a single function, but I do not see your plot code? The updated plot looks better than the first, it is strange that there is that jump in the timing. The general shape of the curve and range looks correct.


This creates list but doesn't do anything with it


_**Good**_ line!


This isn't correct


Change made


Почему эти обновления здесь? Они как часть исправления или они не относятся к нему? Тогда они должны быть в отдельном коммите.


__*Bad*__ line(((


GroundDomainUpdate (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1872 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.svg)


I see. Didn't try that on other repo before. Thanks for letting me know.


loginName - это String, login - это Login. Можно спутать.


https://blog.twitter.com/2015/building-distributedlog-twitter-s-high-performance-replicated-log-service , among other things. Kafka is used in some places as well.


Можно еще добавить `static` модификатор.


Смущает, что и в hibernate и в `@EnableJpaRepositories` указан один и тот же пакет. Обычно такого не должно быть.


hmm. Buffer overflow


Лучше возвращать интерфейс, а не его реализацию.


Nice job, bot!


There was an email exchange with Sherri in which we determined the URLs for themed collections. I just made a guess for /california-history/, /cal-cultures/, and /jarda/. Sherri suggested using /themed/ instead of /california-history/ but said the rest looked good.


Зачем этот лишний перевод строки?


Неиспользуемый импорт. Зачем?


Надо настроить IDE, чтобы не вставляла этот бесполезный текст.


So this simply enables support for reading a raw compressed instead of an archive?


Что это и зачем?


GroundDomainUpdate (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


You are correct, this is incorrect useage that I fixed most of, but must have missed here. Mental lapse on gatefilter and mask.

After looking back at this, I agree that ```RadarDisplay``` should not change ```Vgatefilter```. I'll remove this.


@crookedneighbor: How's this for an implementation of your suggestion? The PR will merge shortly, but I can continue to polish the test if there's further room for improvement.


Все методы в интерфейсе итак публичны, поэтому явно указывать идентификатор нет смысла.


Можно также добавить атрибут `readOnly = true`


Seems so.  That's the most obvious path to a smashed stack in that function, anyway.  I have a breakpoint on it now.  So if this isn't the fix, next time I hit it I'll actually be able to examine the parameters.  They weren't accessible on my first run.

There is poor coding practice like this all over the core code.  I aim to alleviate that in time.


:+1: looks good and works. @arw180 @wski

@clarkjefcoat or alan will need to update the deployment stuff when they get a chance


Зачем здесь вводится бесполезная переменная?


This should probably be done once in the constructor, both for safety and performance


Чем не подошел стандартный `@Autowired`?


In reality, this should be ```getRadar``` as you proposed and I can construct the mask in ```SelectRegion```.


Пробел бы добавить перед `{`, чтобы не слипалось..


"if not checked"...


ACK


Basically `overwrite` is just for the obfuscation.
In general Mixin seems to add all code it finds in the Mixin class into the original class.
If some method has the same signature (name and arguments) as another one, it will be overwritten.

The `@Override` in this case serves no other purpose than as a hint that it overrides an already existing method.
I let eclipse automatically add these because it simplifies some things.
For example if we merge to 1.8 and the original function name changed, the `@Override` will generate a compile-time error for us.


Зачем этот параметр?


for the time being, yes. unfortunately, I believe to be consistent in how firewalld works with zones for removing if absent and adding if present inside of the zone file as well as the whole file in general we would have to do a service restart for direct rules due to the bug/feature(Depends on what Thomas Woerner calls it, haven't heard back from him yet on whether it's a bug or not.)  Either way, I'll be dealing with it type/provider which will run `firewall-cmd --direct --remove-{chain,rule,etc.} args` and at that point enabling reload rather than restart, which will add the rules that exist in xml.


Ввожу несуществующий логин, работает нормально, исключений не бросает.
Пользователей 2 - admin и user.
А что не так?


These names "fieldInspector" should probably be "typeInfo"


I mean "I'm not really convinced..."


test


@Wistaro N'oublie pas de mettre le tokens.csv dans le dossier TypeHandlers, en tant que `programs_tokens.csv` :)


Sounds good, learnt a lot. Thanks.


Смесь различных кусков и непонятно что исправляли и что исправилось. Я сомневаюсь, что дело было в версии джавы, скорее в коде проекта.


The usual approach in documenting a structure is to add a description to each field. See eg struct cached_text_t around line 228 of this file. I tend to use a more compact form, see th_gfx.h around line 100


Can you include an example? Here's one: http://cg-horses.tumblr.com/post/44175751464


Не надо беречь закомментированные строчки. Удаляйте их смело.


`.stream()` on previous line. Maybe the whole thing in one line?


`emDb` -- не жалейте букв, никчему заставлять остальных расшифровывать аббревиатуры.


Nit: this can be outside the case, no need for default


Тут вопрос.
Название сущности совпадает с названием таблицы - это:
1) сущность User, таблица User;
2) сущность User, таблица user;
3) сущность User, таблица users.
Если 1), то может ли таблица именоваться с заглавной буквы? (понятно, что БД ругаться не будет, но нормально ли это?)


empty line not useful here


does this assume the error is always due to username unavailable? what if the input was garbage or there was some other error?
also pls take out console logging when done.


Неоправданное использование `this`. Зачем понадобилась проверка на `null`? Кроме того, не надо было `EmbeddedDatabase` выносить в член класса, нужно было просто возвращать экземпляр класса из этого метода. А где нужна БД, то там вызывать этот самый метод.

Советую почитать про джава конфигурацию в доке спринга, чтобы разобраться поглубже.


ACK


I see no obvious bugs. The logic of the main loop #347 looks good to me.


please take out console logging when done.


Yep another instance that I forgot to remove something after going down the wrong path.


Do we need all these `@Nonnull`? Isn't that the default in our coding style?


Done, see https://github.com/troessner/reek/commit/3f92ba84999f2c0ccb929bbe35dbf479af1e3ff9


No need for `format` here


Да!
Не хотел Вас сильно отвлекать - поэтому ковырялся сам.
Учту, вообще с коммуникацией проблем нету, так что думаю это не будет
проблемой.
Буду спрашивать! :)
(просто я отлично понимаю, что у Вас есть другие задачи, и это Вы делаете в
свободное время. А у меня было немного свободного времени, и я решил не
утомлять вопросами, а поковыряться сам, и подождать когда Вы посмотрите код)

Притом решение было не в некорректных зависимостях, а не в коде. :(

21 сентября 2015 г., 19:55 пользователь Slava Semushin <
notifications@github.com> написал:

> Очень сложно ревьювить сразу много кода. Кроме того, не атомарные коммиты
> и коммиты в которых неясно описано их назначение усложняют ревью.
> Собственно, это в ваших интересах получать быструю обратную помощь, но т.к.
> выдаете вы сразу много кода, то обратная связь затягивается :(
>
> Я удивлен, что вы бились над проблемой, не могли ее решить и не спросили
> меня. В итоге, как понимаю, переписали чуть не весь проект в попытках
> исправить. В реальной разработке, это может сильно вредить вам :( Настолько
> сильно, что я знаю случаи, когда через некоторе время таких коллег даже
> увольняли, т.к. начальник был ими недоволен.
>
> Попытаюсь объяснить идею с точки зрения любого тимлида/менеджера --
> управленец хочет быть в курсе того, чем вы заняты и не хочет, чтобы вы
> "залипали" над задачей. Почему? Потому что это время, а время это деньги
> работодателя. Кроме того, очень часто ваш начальник лучше разбирается в
> теме и вашу проблему он мог бы решить очень быстро, поэтому, когда он
> видит, что вы потеряли день, а с его подсказкой решили бы за час-два, то
> это оставляет неприятный осадок. Если так повторяется несколько раз, то ваш
> профессионализм начинает меркнуть в его глазах.
>
> Т.к. я не плачу вам денег, то мне в целом не жалко вашего времени, поэтому
> конечно вы можете хоть месяц что-нибудь делать, но в реальной жизни все из
> видимых мной руководителей этого не любят. Поэтому не стесняйтесь
> спрашивать, тогда будет хотя бы возможность вас вовремя направить в нужное
> русло.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AleksSPb/Spring-demo-App1/commit/851dd6365ad4d77110d47530edd2ba6e8575d194#commitcomment-13347674>
> .
>

--
Всего наилучшего, Пархоменко Александр


Этот метод не нужен как и мембер `emDb`, а чтобы БД корректно закрылась можно использовать атрибут `destroyMethod` у аннотации `@Bean`


what was forgot here? how about openForgotPasswordModal or openResetPasswordModal?


ACK.


@analytically Good catch; added #3.


Нехватает модификатора доступа.


pls take out console logging when done..


No need for `format`


beware: officially guava doesn't care about serialization compatibility, but that change broke it.


I hate setting up new git accounts - I always get it wrong :p


what is being reset here? like with ForgotModal..


Зачем? Это значение по умолчанию.


You remove the omsStorage* parameters in this same commit so this will not resolve.


Неиспользуемый аргумент в методе.


What happens when node does not have host_node?


> This kills uwsgi discovery in the case of running uwsgi from a virtualenv without having activated it (which was possible earlier and should definitely be supported).

But why would you do that, instead of activating it? It doesn't really kill it. `$ USWGI_BINARY=/venv/bin/uwsgi /venv/bin/uwsgi --http --wsgi-file myflaskapp.py`


I don't follow - why would I do that?
To what exactly from here: https://github.com/troessner/reek/commit/1a4cf2a0e450a511a9827956e0eaaf1e465c4c29 are you referring to?


I see now that this is not getting gatefilter and therefore not emitting a change signal properly.

Sorry I don't follow the second part of your comment. Do you mean that we shouldn't be allowing ```SelectRegion``` to make changes to shared ```Vgatefilter```?


Есть еще куда расти. Я уверен, что если бы вы перед коммитом внимательно посмотрели свои изменения, то многое и сами бы исправили..


Ah, you are right!


useless empty line


Зачем этот пустой класс? Классы в джаве обычно именуют с заглавной буквы.


Hi Largopipas

That error typically happens when Talkey cannot find any TTS engines.
It should be resolved by installing one of the supported engines.

It also looks like you are using Windows, which I haven't added support for this yet. I have only tested this on Linux systems, so I'll have to start up my windows VM to add support.

I'll create a ticket for Windows support.


Предлагаю добавить `NOT NULL` к обоим полям.


remove empty line


Yeeeeah, that's gonna have some side effects.


ACK


Thanks!


uniqueResult

Object uniqueResult()
                    throws HibernateException
Convenience method to return a single instance that matches the query, or null if the query returns no results.
Returns:
the single result or null


i'm gonna remove the option to get back to base from FOB.
The redeploy param will refer to the ability to teleport to FOB from now on


nice :) Let me know if there is anything I can help with in getting this out this week


We just need to maintain a version tag and a stable tag, correct?


Thanks! :rocket:


ACK (10.4 subsection, agree).


I'm more like asking that. But yes. In my version this is not default, to get this behavior I have to link


Would be nice if we maintained this workflow in one place. I didn't realize it lived here and in the Makefile.


You are correct. What we have is last part of full run arn.
So we are using it to convert into job arn.
I agree its a little complex. But the way code is written previously, this is the best we can do. Otherwise it would need a lot of refactoring.
I have added a comment explaining what we are  trying to do
// constructing job ARN for each job using the run ARN


need to mention orphanet in the list of the vocabularies of the vocabularies/pom.xml


Actually it's my mistake. Sorry for this.


We should decouple as much as possible the notion of metadata storage (in this case network configs) from the notion of discovery. Even though the network configuration goes through the same backend used for the discovery most of the time, we might be able to swap and change the discovery service while keeping the network configuration intact (they might use two different store).


Oh, this should be ```self.Vgatefilter.update(strong)``` correct? That way there is no value passed.


Done


Done via d97a2d85db1f5fbff25e0562fbb359d93d7b07d4 and 1bb9a2b2c3a43df54c5587147108d5ce4a7e569f.


ACK.


Removed


that was there for all successful ajax queries


RIP helios


Ох. Тут много разного...

1) Файл назван неверно. Нужно назвать его согласно языку для которого он содержит перевод. Если это для русской локали, то назовите его `messages_ru.properties`
2) Почему здесь часто на русском, а часть на английском?
3) Нужно стараться использовать сообщения общего характера, чтобы не зависесть от названия полей. Иначе вам нужно будет их чаще править и дублировать.


You cannot clear the master password unless you drink wayyyyy to much, because the master password is stored in your brain ;-)

Clearing all settings, i.e. clearing all encrypted stuff in the settings file automatically allows the entry of a new master password.


All these "fieldInspector" should be renamed


Wow, I had forgotten about this! Happy to help.


There is nothing to validate here. For other testtypes, we validate if user has left the textbox empty. But username and password can be empty.


`.stream()` on previous line


coment


Lots of indentation issues/inconsistencies. Use two spaces in JS files, 4 spaces in HTML (unless editing an existing file that uses a different convention)


During the review @ronawho suggested, and I agreed, that it may be redundant to document these when the "isSync" function in Types.chpl is already chpldoc'd.


@ghislaineguerin I just noticed that `common-style` repository depends on itself(?). Do you remember why it was done this way? It doesn't look like right to me.
FYI @RV-Adrian.


no, I mean that the function `New` would not get a value argument, just a variable (?) and a strong one.

Your use of update is right, but not here, `update` inside `new` is just as dangerous (infinite loop).


not clear what the TODO is for


Hey, can you give us more info about your project?
Are you planning to use WebGL? Or Java? Flash? Unity?

I am really curious about it.

On 9/18/2015 11:26 AM, Gé Vissers wrote:
>
> Hey Paul,
> All fair questions. Let me start answering them by telling you why I
> started this series. I am working on and off on a web-based client for
> EL (far from complete yet, don't get your hopes up), and many times
> when I was looking for how certain things got done in the official
> client, I got frustrated because parts of it are still in spaghetti
> form. That's where the first refactoring patches originated. As you
> guessed, I started using clang's scan-build static analysis tool to
> check for potentially dangerous situations after I encountered some
> questionable code. I have been trying to remove these warnings, 59
> remain, but I believe most of these are false positives, or things
> like dead assignments which I think make the code more uniform or
> safer. So I think I'm mostly done with those. What might follow is
> some small refactoring to untangle things (mainly interface.h, which
> exports variables from all over the place), perhaps some #include
> cleanups, but nothing major. Of course, i f you'd like me to stop
> these cleanup patches, or if there's something else you'd like me to
> take on, just let me know.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/raduprv/Eternal-Lands/commit/353998f0ddd0dffa09d44c38d05931147ac3389d#commitcomment-13305260>.
>


I cleared all settings. A new started Qt-Sesam just asks me to enter (and not: to set) the master password. One of us is wrong.

"Realität ist eine Illusion, die durch Mangel an Alkohol entsteht." (Wikinaut und http://www.aphorismen.de/zitat/53758)


Could you please split this into a separate commit?


- уберите бинарные файлы из репозитория -- им там не место


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8327/testReport/) for this commit**


it depends on what ajax will retrieve from check script that doesn't exist yet. if there gonna be a difference between username is taken and username is garbage - then there should be 2 options at least. as for now general message can be 'this username is not available'.


`finally` blocks (and sometimes `catch`) need to run to cleanup resources and shared state. Really bad things can happen otherwise (e.g. thread local data from one web request leaking into the next, for a different user.)

But, even if we could agree that `finally` blocks can be disregarded, other people won't agree with us. In Java, everyone would have to rewrite their code to `catch (Throwable)` wherever `catch (Exception)` is used today. And in Ceylon, `catch (Exception|AssertionError)` is awkward and easy to forget.

By elevating failed assertions to (what may believe to be) unrecoverable errors, recovery scenarios are lost. A couple possible repercussions include poor error reporting to users (Ceylon itself suffered this IIRC), and application or server exits when it's decided to exit/restart the process on unrecoverable errors. And there can also be strange results if some code treats `AssertionError`s as recoverable, and other code (libraries) in the same app don't.

On the flip side, I don't see what is gained by conflating errors and exceptions, aside from momentum.

> An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch.


Yeah probably. Would be cool if the bootstrap script just queried the github api directly...


I would map this rule to PCI-DSS Req-6 Section 2 (Req-5 speaks about anti-virus sw IMHO).


I think we'll want this block as early as possible because otherwise the module code of our imports gets executed which may yield an exception. I'd move this right to the top of the file together with the sys import.


Ahhh okay. I forgot to set the value of the settings variable `[mainwindow]/masterPasswordEntered` to `false`.


~/.config/ct/QtSesam.ini (after having cleared the settings):

```
mainwindow]
expertMode=true
geometry=@ByteArray(\x1\xd9\xd0\xcb\0\x2\0\0\0\0\0\xe7\0\0\0 \0\0\x4\x31\0\0\x2\xc6\0\0\0\xe7\0\0\0 \0\0\x4\x31\0\0\x2\xc6\0\0\0\0\0\0\0\0\x5\0)
masterPasswordEntered=true

[misc]
masterPasswordInvalidationTimeMins=5
passwordFile=
saltLength=16
writeBackups=false
```


but still asking. I am puzzled why.


Приведите структуру каталогов к виду, определенному на занятии: каталоги с заданиями должны быть вида:
 -001
 -002
 -...


Set `masterPasswordEntered` to `false` and try again.


forgot modal asks for email address to send password reset instructions. forgot modal is where user actually sets new password after receiving some reset link.


That's one way to write "8 MB". I personally prefer `8 * 1024 * 1024`.


And you correct it in the code, ok?


When using `insertHtml` this will automatically upgrade it to a widget (which fixes drag and drop and makes things nicer in general)


Before:
![help hints before](https://cloud.githubusercontent.com/assets/1788374/9999490/86c5d244-604b-11e5-8d24-455b203bc82c.png)

After:
![help hints after](https://cloud.githubusercontent.com/assets/1788374/9999492/8b387854-604b-11e5-984a-039552990738.png)


ACK.


Applys formats on `getData`


Before:
![help eula before](https://cloud.githubusercontent.com/assets/1788374/9999500/9799f8b6-604b-11e5-84f7-507e3aea77a3.png)

After:
![help eula after](https://cloud.githubusercontent.com/assets/1788374/9999504/9c02a538-604b-11e5-96ff-0da21a4a04dd.png)


ah, sry for the spaces before the `if`


@ola-ct wrote
> Set masterPasswordEntered to false and try again.

Confirmed. Works.


:+1: Thanks.


Нашел полезную статью, может кому пригодится:
http://habrahabr.ru/post/179425/


Nicht dafür. (Sagt man das noch?)


ok


macros++


@SabreCat the variables at the top like MIN_RANGE_FOR_POTION = 0 aren't going to be globals this way?


Want to clean this up before PRing https://github.com/ichord/At.js/compare/master...emord:override-insert


Comment is now inaccurate


Скромность была неуместа. Есть люди, которые задают по 3-5 вопросов в день, а то и чаще, вот им стоит больше самим ковыряться, в вашем же случае, лучше не стесняться/не бояться и спрашивать.

Ну и про время -- не пытайтесь думать за меня, потому что чужая душа потемки. В моем случае, как раз много удобнее, 10 раз посмотреть мелкие коммиты, чем сидеть и полчаса смотреть один. Почему? Во-первых, потому что найти пару-тройку минут проще, чем выделять полчаса-час. Во-вторых, когда смотришь немного, то глаз не замыливается, и я ревьювлю более внимательно.

P.S. И не забывайте, что вы пишете код не только для компьютера и себя, но и для меня :) Мне потом это читать приходится, поэтому я и бурчу по-поводу читабельности кода. Сейчас читаю я, а со временем этим займутся ваши коллеги, береги их время.


> An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch.

Exactly! An `AssertionError` is an error **in your code**. How could you meaningfully recover from that?


Before:
![pubkeymaster](https://cloud.githubusercontent.com/assets/1788374/9999557/e1b5329e-604b-11e5-8daf-f03f941ec067.png)

After:
![fix](https://cloud.githubusercontent.com/assets/1788374/9999560/e786531a-604b-11e5-8783-51397ccfc4c0.png)


Doubt this will actually get done as the next version is a complete rewrite to 5.0, but it would be nice if I didn't have to do some hacky stuff


Yes, Sir! ;-)

Resolved by commit 94798c747c025f08de25225996d929eb39b521ee


Hi @rtomayko
We need to use content-length on the client side to show some progress bars. Looks like via this commit you added Gzip streaming and removed content-length. Does it mean that there is no way to get content-length for zipped content? How does this change relate to https://rack.lighthouseapp.com/projects/22435/tickets/9-rackdeflater-doesnt-set-content-length?

Thanks,
Sudhindra.


Бинарным файлам в репозитории не место уберите пожалцйста ото всюду


Конкретно в этой версии кода нет биндинга параметра. Скорее всего вы его в другом коммите уже добавили.


is there any difference between ABORT() and ASSERT(false) now?


ACK.