may its better to return it typecasted as ```WiFiMode``` otherwise we will get a warning in the most usages.
and it shut make the exacted return values clearer for the most people.


Reference to Grunt concat task left in jquery-ui/README.md

The grunt concat task was removed from Gruntfile.js, however the "Building jQuery UI" section of the README.md still references the task.

Readme file:
[https://github.com/jquery/jquery-ui/blob/master/README.md]

Commit removing the task:
[https://github.com/jquery/jquery-ui/commit/7cb0a2ba890e6a5c921d74e1c563b57359419311]

Attempted to submit a bug report.
>Trac Error
>Submission rejected as potential spam (Maximum number of posts per hour for this IP (127.0.0.1) exceeded)


hmmm


@fwalch That's much better. I also had trouble because of an outdated ruby on ubuntu, so probably rbenv or whatever is still needed. But this saves a lot of hassle, thanks.


So you must be logged in with any account to see this pages no? Because this is what the code is going to do.

If you want to disable page if the viewed user hasn't got `explore_site`, then you should do the feat. flag check to `@viewed_user`.

Just to be sure we're doing what we want to.


now the 'margins' are defined using `p_info.panel_margin_lines` which comes from `theme(panel.margin=grid::unit(0, "lines"))` on the ggplot. This allows ggplots with no space between facets.


This is Kinda outdated


Cant be abstract, gives error


perhaps we should start moving library dependencies into a configure script?


I'd appreciate it if you didn't just kang other peoples code (namely mine). If you have changes you'd like to make, please maintain the original authorship.


Type can be omitted


@cklosowski restricted is misspelled here.


hi


Okay, sounds good. I think I can at least do three out of four. I honestly don't remember why I dropped description ?? string.Empty. I'm pretty sure that it was just extra code that didn't add value (description worked just as well as null as it did as string.Empty because of the way OptionSet works).


I'll fix it.


Fixed in 8595c2d.


wee


very nice job :+1:


this commit sucks


Why did you use AutoPlay instead of Play?


Is this something actually needed? I would think if someone needed this, they would probably be fine with adding `alpine-base` to their package list.


biraz daha açabilir misiniz ?


@Phantom66

El otro día me estabas preguntando sobre los controladores y las vistas, esto es lo que te estaba diciendo:

[en esta linea](https://github.com/slayerfat/sistemaPCI/blob/2d7ed4f0849df4f05746b1e639245fa3adecadff/src/app/Http/Controllers/User/UsersController.php#L84) se ve que estoy usando una fachada (Facade):

```php
public function show($id)
{
    $user = $this->userRepo->find($id);

    return View::make('users.show', compact('user'));
}
```
detalla que se busca un usuario por medio del ID y se regresa una vista (`users/show.blade.php`) con la variable usuario.

eso es completamente equivalente a [esta otra implementacion](https://github.com/slayerfat/sistemaPCI/blob/2d7ed4f0849df4f05746b1e639245fa3adecadff/src/app/Http/Controllers/User/UsersController.php#L59):

```php
public function create()
{
    $user = $this->userRepo->getNewInstance();

    $profiles = Profile::lists('desc', 'id');

    return $this->view->make('users.create', compact('user', 'profiles'));
}
```

detalla que `$user` es una instancia de usuario, o sea:

```php
$user = new User;
$user = $this->userRepo->getNewInstance();

// en esta implementacion son equivalentes
// quiere decir que sin el userRepo habria que usar la primera linea.
```

se buscan los perfiles ($profiles) y regresa la vista.

la diferencia es que la estoy devolviendo como un atributo del controlador `$this->view`, eso se debe a que:

```php
use Illuminate\View\Factory;
class UsersController extends Controller
{
    public function __construct(Factory $view)
    {
        $this->view = $view;
    }
```

acople la vista como atributo del controlador.

con esta implementacion se dice entonces que:

```php
//...

// suponiendo que:
$user = new User;

// por medio de una fachada
return View::make('users.show', compact('user'));

// por medio de un atributo
return $this->view->make('users.show', compact('user'));

// por medio de la funcion global (helper functions)
return view('users.show', compact('user'));

// las 3 son equivalentes.
```

la diferencia clave entre las 3 opciones y otras que no menciono es por la conveniencia versus la mantenibilidad.

espero que esto te ayude, cualquier cosa me avisas :+1:


Agreed, I'll change it.


Maybe something like `api_v1` would be better?


I believe my thoughts were something like not leaving it null, but fair enough.

Great, will look for it. When it's ready, will verify it and get it published.


Maybe "Are you running a test?" is not the best message for errors?


Sounds good. It would be good if you can add a clarification on the driver to be used during the network creation.
Docker engine supports pluggable network driver (with current, default driver being the single-host bridge driver). But in many cases, users will be interested in multi-host driver such as the in-built overlay driver to be used by their applications. Hence, it would be great if we have a way to mention the driver that the user wishes to use.

FWIW, docker daemon provides a way to set default network driver as a daemon-flag `--default-network`.


Pokus 1


Тут что-то не то...

Анонимный пользователь должен не только ни иметь доступа к URL-ам для изменения, но также и не видеть их в интерфейсе. А сейчас видит.

Кроме того, JS-метод не надо выводить на странице, если он нигде не вызывается (т.е. если нет людей в списке).

Ну и вот так вот делать непонятный JS-код, тоже не надо -- надо было просто весь тег `<script>` завернуть в `<sec:authorize access="isAuthenticated()">` (а лучше даже не просто `isAuthenticated()`, а что-нибудь вроде `hasRole('ADMIN')`)


I think this should be track with a Mule issue. And labeled in a way that we are sure we fix it before releasing mule 4.


Use a setVolume argument to let the background music play quiter than the effect sounds


Ожидал этого вопроса :)
Если бы я локализовал только сообщение, то у меня бы вышло:
> Your login attempt was not successful, try again.
> Reason: Неверное имя пользователя или пароль.
т.е. не все сообщение об ошибке на русском, как ты назначил мне в тикете.
А этот блок:
> Your login attempt was not successful, try again.
> Reason:
как я понял не локализуется через `properties` файл. Вот и пришлось делать свою страницу.


Thanks for contributing to this PR! Just one quick comment - instead of using something like a "class property" which is a pretty foreign concept, maybe we should make it easy for users to override methods by providing default implementations for the mappings:

```
typedef NS_ENUM(NSInteger, RLMPropertyMapping) {
    RLMPropertyMappingCamelToSnakeCase = 0,
    RLMPropertyMappingAsIs
};

+ (NSDictionary *)JSONInboundMappingDictionary {
  return [self defaultInboundMappingForType:RLMPropertyMappingCamelToSnakeCase];
}

+ (NSDictionary *)JSONOutboundMappingDictionary {
  return [self defaultOutboundMappingForType: RLMPropertyMappingAsIs];
}
```


asfasf


Committed in 0727a46c520b62f800931dca1ac02b4990e0ff4d and bf0d47854bc059638cb797df92dcc610b8f97237.


sdsd


Then whose was it?


Meele: Botr,Bilg,Ghos,Hydr,Tiam,Rand
Cleans: Merc,QSS


I tried it and this fails with:


Ок. В любом более-менее серьезном проекте все равно приходится свою страницу делать, так что не так и важно.


Same here


Fixed a lint issue with the files.


Why not just `>= 3.0`?  Since it seems to work w/ both other than the gemspec, might as well make it work w/ both 3 and 4..


You can access the values in `Path.routes.currentparams` from anywhere in your application

Setup the route:
````
Path.map("#feed(/:id)").to(app.feed)
````

Get the value somewhere in your code

````
entryName=decodeURIComponent(Path.routes.currentparams.id);
````


...Oh, maybe not. However, AFAIK, it's not a double free and `free(NULL)` is a noop, anyway.
We'll continue to ignore clang on this one!


Pokus 2


Yep, looks great and gives even more flexibility. Do you want me to update PR?


Pokus 3


Я тебя правильно понимаю, что у анонимного пользователя не должно быть видно ссылок 'Add', 'Delete` и `Edit` ? Значит я вообще неверно понял что требуется. Нужно тогда будет кнопку `Login` делать.


Is INDEFINITE not enough?
https://docs.oracle.com/javafx/2/api/javafx/scene/media/MediaPlayer.html#cycleCountProperty


I need to install sbcl at home at test it all. I'll do that and get back to
you.
New problem..."Package UTIL.DATE-TIME does not exist" on SBCL.

—
Reply to this email directly or view it on GitHub
<https://github.com/e40/cl-quakeinfo/commit/819c02af4f1c3c4693e14b8a28347a29aff8f116#commitcomment-13264548>
.


Haha, gotcha. And I was reading through the email notification, which had even less styling difference!

I'll go ahead and change it -- a little less verbose to get the same effect.


>Я тебя правильно понимаю, что у анонимного пользователя не должно быть видно ссылок Add, Delete и Edit ?

Да.

>Значит я вообще неверно понял что требуется. Нужно тогда будет кнопку Login делать.

Возможно, что задача была сформулирована не полно изначально. Да, сделай кнопку Login, пожалуйста.


I've spent a little time this morning trying to figure out how to write a test that ensures this is called, but I'm at a loss.


looking at this code almost two years later, I think it can be improved to automatically decode the parameters as they are stored, but i think this project is dead, so I will leave it as is.


А вот с этим тяжелее, ломал голову как засунуть это в `<body>` не создавая дополнительных файлов, но ничего не придумал. Подскажи куда копать?


Changes start here.


good job but will the framework be updated for lollipop 5.1? Implementing it in Rom will do significantly better job than an external, background app like your battery saver. And from how you describe it it looks very similar to Greenify...


Me parece que debería decir get temperature in celsius


Конечно, так и логичнее будет.


1: M111 unrecognized component name: legacy


26:1: F401 'CFG_DEVEL_SITE' imported but unused
80: D102 Missing docstring in public method
109: D209 Multi-line docstring closing quotes should be on a separate line
109: D203 1 blank line required before class docstring (found 0)
109: D400 First line should end with a period (not 'f')
109: D205 1 blank line required between summary line and description (found 0)
115: D102 Missing docstring in public method
148: D102 Missing docstring in public method
153:1: E303 too many blank lines (3)
153: D210 No whitespaces allowed surrounding docstring text
153: D209 Multi-line docstring closing quotes should be on a separate line
153: D203 1 blank line required before class docstring (found 0)
153: D400 First line should end with a period (not 'l')
153: D205 1 blank line required between summary line and description (found 0)
195: D102 Missing docstring in public method


Noob


Same here


A less hackey way is to put `<link rel="stylesheet" type="text/css" href="mystyle.css">` at the beginning of the file if there is already standalone css just for this MD.

This is still hackey though (still one line in the file). Don't know better alternatives at present. We can consider it later.


Não fica redundante a informação do estado?


Yep. Let us get to the bottom of this problem we are facing, and then we'll see if having a batch mode makes sense.
I already looked into which OS does not have `tee`. Windows does not have `tee`, but cygwin does, and so that should be fine.


Note that when Node 5 comes out (currently scheduled for October, this one cycle is short, starting from v5 releases will arrive in 6 month intervals) `"4"` will need to be added as it's going to be a new LTS version so it should remain supported.


Actually, I had the file sitting in my working copy as "untracked" and accidentally checked it in.

Where do you keep your unused parts until you decide to add them?


You should use bulk=True instead of type=None. Then you can just do "if bulk".


lembra sempre de também mandar compilado para ficar ok no gh-pages


Should we `stop_dnet $1 $2` ?


No necesariamente va ser ese path siempre. Yo sacaría ese comentario


> Given that the C bindings are not 100% complete

It is a bit spartan. :) What features is it missing that you need? In particular, want to make sure you're finding the generated `c/GraphQLAst.h` header, which includes the getters for all the scalar fields, like `const struct GraphQLAstName * GraphQLAstField_get_name(const struct GraphQLAstField *node);`. #9 should make this stuff easier to find once it lands by letting you install the library properly instead of having to dig around in the source tree for generated things.


`static`


Also removed paperclip gem


@yyfjmb For your reference.


`projectName` -> `keyword`


Stop making plugins...
And FYI its
```php
use pocketmine\event\player\PlayerJoinEvent;
```
And seriously, extends PluginBase(){?!?!?!!?

IT IS A CLASS NOT A METHOD SO GET RID OF THE BRACKETS.

Why do the sendMessage() function twice? Only one of them will be called.


That's nasty. Just do an if/else with a different message.


esos números deberían ser macros


`projectName` -> `identifier`


I commend your attentiveness.


typo


core.User doesn't have Email field.


I find this part hard to understand.

To me this says "return the list of successes unless the list length is empty"?  So return an empty list if an empty list was sent in?


It seems like all the views that use `_public_header.html.erb` are covered with this changes (I hope that i don't miss anyone :( )


I was talking with someone on IRC about mixed FDP/sleeve deployments the other day and they asked if it would be possible to use FDP intra-DC and encrypted sleeve inter-DC. As a consequence of the probing/fallback behaviour I said I thought this would work by turning encryption on and then blocking the VXLAN port inter-DC. If we removed this `nil` assignment and the assertion in `MakeForwarder` wouldn't that be the case? (Granted the 'UI' to controlling the behaviour isn't great and has the potential to fail-unsafe if the VXLAN path became available unintentionally)


This is an old change, right now uses the `@viewed_user` to check it


Nice.


Thanks ricky! It was just a quick draft that you were looking at that I made a lot of changes since two days ago, so instead of merging I just made these changes manually. Feel free to critique the newest version though!


please save the return value of myCoilGO() and dereference it in the if body in the same way as
```cpp
if (Creature* thaddius = ObjectAccessor::GetCreature(*me, instance->GetGuidData(DATA_THADDIUS)))
```
is handled


Another thing: it is
```php
 use pocketmine\Player;
```

Really? After calling a method
```php
//For example:
$player->sendMessage("Blah") //You need a semi colon (;) after it so it would be

$player->sendMessage("Blah");
```


Odd I thought the requirements page would pull various mentions of requirements out of other pages and into here.


Test added https://github.com/tessel/t2-cli/commit/f08df5c1885e8052a4847e75bd943c3bfcfe5b0f


What happens if the DeclaredConfiguration is multitenant?


This doesn't actually do anything yet, right? A task needs to be added to the `packages` role in ansible-common-roles that uses the `apt_repository` module to add the repo.


Please use a PHP IDE. Google if you don't understand.


Nice!


And Shoghicp won't accept plugins that end in <code>?></code>


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1872 of 1873 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Но почему? Я же проверяю имя проекта на принадлежность к ключевым словам. Такой же вопрос про идентификатор. :(


E.g[sp]


The namespace is ***INCORRECT***. It should be
```php
namespace MCPEGamerJPatGitHub\BuildBattleMCPE;
```


Would you like to improve exception handling here, too?


I'd happly drop \ here as I'm not sure it makes thing more readable, your choice.


Сделай еще один фрагмент и включай его в каждом файле в нужном месте.


We can have a cronjob that runs every Monday and updates the currentWeek field in the Season table


The class name is wrong. Instead of
```php
class BuildBattleMCPE extends PluginBase{

}
```
It should be
```php
class plugins extends PluginBase{

}
```

Because the file name is called plugin.php


@zhuangzeqiang need to add another check here if (op_state.has_existing_user()) to guard against a case where we add another index in the future


Great tests :D


You also need a plugin.yml file.


I think this is only a Debian requirement.  Can we standardise on something like Ubuntu throughout and let the deviations be from Ubuntu rather then having a mied bag.  Not critical to land this.


Just updated. Note the changes.


Didnt include the files :\


Oh nothing it is fine just funny 🐴


missing a closing brace


@marbre can you verify that GLM_INCLUDE_DIRS variable remains the same across the versions and is not changed to glm_INCLUDE_DIRS?


Fold in the word 'optimization' in that sentence I think so that people know why they install those others.


This is the original text.


Maybe rework the whole method:
```
reduceSuccesses: (successes) ->
  if successes?.length
    return false for s in successes when s is false
  return true
```


Should this really use AMG?


martyborya please tell me you realize this is a comment box for github and not your command line?


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (803 of 803 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.07%25-green.svg)


Yeah, I went back and forth on that a bit. There's a decent bit of overlap in the configuration for the monitoring and events modes, so I left the struct unified for now. I just removed some settings from the struct because they were duped, so the overlap in the configs is a bit easier to see now.

I strongly suspect that we'll end up with separate Configuration structs for each mode in the relatively near future, but I don't think we should do that work until we know for certain. Might end up complicating the code for no good reason.


@al-martinez DWMR. Nice job Al. Keep it up mate!


In the `vote_spec` file, you're only concerned about the `Vote` model. You shouldn't have anything beside vote-related stuff, so for instance, that `@post` variable doesn't belong here. On top of that, it's simply not defined!

What you can expect to find in that spec, is calls to `Vote.new`, creating different kind of `Vote` objects. For instance:

``` ruby
up_vote = Vote.new(value: 1)
down_vote = Vote.new(value: -1)
invalid_vote = Vote.new(value: 2)
```

With those, you would add expectations (checks), using methods you're already familiar with, such as:

``` ruby
expect(up_vote.valid?).to eq(true)
```


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - i386-Windows-7-VisualStudio-12: OK (1869 of 1872 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


I did notice in my debugging that for adding/removing a node and renaming a node, `successes` was always `undefined` or and array of `undefined`. That seemed a bit odd, but I just assumed that you needed an explicit `false` to have a fail return status.


增加MySql中procedure对cursor相关语法支持


You could use OSArgument::type:

https://github.com/NREL/OpenStudio/blob/develop/openstudiocore/src/ruleset/OSArgument.hpp#L198

Just saying....


[Here](http://bower.io/docs/creating-packages/#main) it says "Do not include minified files." What is your opinion about this? :smiley:


@henryHorsey @nllong


Oops, sorry. I introduced the notation `notation f`^[`n`]` := iterate f n` in data.nat.basic. I'm happy to change it to something else.


Could you try to rework *vote_spec.rb*? :)


Sure!


Not 100% sure that the link between the created ``createsuperuser`` user and ``verify_user`` is clear here.


@masensio you lost the style definition


Зачем `static`, если метод приватный?


No issue with the BC break, it's more [this comment](https://github.com/Soullivaneuh/AliceBundle/commit/c06e2a36c46a4ebe53758940accc00224d6fe6fd#commitcomment-13263499)


I don't *think* it's necessary, but I might have to do some testing to confirm that. If the connection to the AMQP broker goes down then both modes are effectively dead in the water and their process should be restarted from scratch (and the restart logic should be external to jex-events). I think I need to test each mode to make sure they exit in a failure state in that situation, though.


This will create duplicate entries if any of the player's stats change between runs,  a behavior we don't want. You should get the playerstat object using just the player and week, then modify the stats and finally save it back with playerstat.save()


> Odd I thought the requirements page would pull various mentions of requirements out of other pages and into here.

It does at least in so far as there were requirements listed on upgrade/installation pages.

Are there other pages with requirements listed that should be assimilated here?


No problem.
Most users (if not all) use the unicode version.


Fair enough.


The only problem I see with this approach is that ``stderr`` and ``stdout`` will spew into the shell in which the user is working.  Would it help to redirect this to a log?


Maybe, but I'd be pretty nervous about that.  The guarantees about when you do and don't get encryption should be really clear and predictable.  So if we want to go down that path, I'd favour a more explicit approach (e.g. nominating a "zone" when you do "weave launch", with encryption occurring on connections to other zones; or perhaps even a whitelist of IP addresses and address ranges to connect to without encryption).


why wrap this statement in extra parenthesis? The one below definitely, but just wondering on this (and _bad_max_content_hosts).


Hi,
thanks for sharing the code.
I got a project to send the commands through Wifi from PC to the strip Controller.
Any thoughts / helping material ...?


yep - i dont think you can pass arguments to createsuperuser - im not sure how to make it clearer


I would say this section should also go to the land of ``<web>``


We're in the same situation as the other spot. Closed AMQP connections == dead in the water + restart.


Right now it's at 1.0.0-beta. I was going to just release the 1.0, but got a little gun shy and I wanted to sit on the changes an little. It would be great if you would try out the 1.0.0-beta to make sure everything still meets your needs.


...additional steps for...


@chrishiebert Thanks, I've removed that section since it's no longer relevant.


Thanks, in this case we definitely need one. I'll get a defer added.


FWIW you can use `%r` in the format string to `repr()` the argument.


Here's a *fill-in the blanks* blueprint to help you get started:

``` ruby
describe Vote  do
  describe "validations" do

  before do
    up_vote = Vote.new(value: 1)
    down_vote = Vote.new(value: -1)
    invalid_vote = Vote.new(value: 5)
  end

  describe "value validations" do
     it "allows 1 as the vote's value" do
       # expect(up_vote).to …
    end

    it "allows -1 as the vote's value" do
      # …
    end

    it "does not allow values different from 1 or -1" do
      # …
    end
  end
end
```


可以啊，谢谢了


I'm pretty sure this works :). why the change?


i like the change!


I share your concern. The conditional encryption/zoning thing is a fair amount of work though, whereas this is potentially removing fives lines of code to enable a compelling headline feature. Can we make it safer? How about we put in a flag that controls it, and then document the technique with a big disclaimer? We could bill it as a preview of the full conditional encryption feature perhaps


тест


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1339 of 1339 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.27%25-green.svg)


default should be -1?


Então, eu pensei a mesma coisa, mas vi que ali em cima após o JS4Girls fica a sigla também, então quis manter o padrão que já estava e colocar nos outros também
Fica a critério de vocês tirar ou não


Désole, cela a ete reverted =)

Regards


cc @sebv any more information? :)


>Зачем `static`, если метод приватный?

1. Он не зависит от this.
2. Кажется, что это позволит создать массив только один раз. Но я не уверен, поэтому лучше и перед массивом добавить static, если такое в есть в джаве.


@AndyScherzinger
If you go to the last version of this file you can see that style definition is in the same line.
This commit was replaced by a commit with only the versionName and versionCode change.


ah eu tinha mandado um PR compilado, mas fechei porque achei que vocês é que ficavam responsáveis por fazer o build do deploy hehe


Yep thats probably a good idea.

I dont say anything here about stopping rqworker - but im figuring that is pretty self-explanatory.


No, I'd be pretty strongly opposed to that.


103404908-AddWarningWhenScheduleTimestepsDoNotAlighn (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (1843 of 1865 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.82%25-yellow.svg)


You have been writing `Go` to long :-)


great work, when I suggested that, I wasn't aware that this would be such a big change. sorry about that :)


In case of timeout the FTS error would match *canceled because it stayed in the queue for too long*. Pls @juztas could you update the patch?


yeah I have that locally and trying to work out submodules :D


Voy a hacer un fork y asi ves como lo haria yo, que no quiere decir que sea mejor ni peor, pero asi tienes en mente otra forma de hacerlo.


>Но почему? Я же проверяю имя проекта на принадлежность к ключевым словам. Такой же вопрос про идентификатор. :(

Лучше думать про метод, когда пишешь его сигнатуру, а не про его использование.


ive used debian throughout. Personally i would prefer to standardise on debian from a FOSS pov - but also it changes less regularly - so is a better target for reference implementations


2 Только если делать его полем класса, тогда можно сделать static.


perfect! that sounds much better and more robust. i'll give it a whirl.


You're welcome! We had in our instructions from awhile ago that it was 123 degrees and then I had seen 126 some where and 128 in the QCTools Help section. I just wanted to make sure we were on the right track with identifying "ideal" ranges for the various levels. Thanks!


I added this one Jessie-specific point in because i had used Debian in all the examples - and this is required with current stable.


Is there any reason we couldn't add this to the existing system opaque type?  Other array types have firmware, software version information too.


In seeds.rb instead of having a loop could we have the actual menu item data in there so we don't have to worry about adding it later?


Except for critical, urgent*,* or very small fixes...


damned, that's why you shouldn't have two versions of one file in two different folders :X


попытка номер два


Is GCC still needed and is this really the module we should use on Kesch (because there's also the -EB module)?


Eu pensei em algo mais ou menos assim em cima ficaria o estado e embaixo a cidade pois pode haver mais de um evento no mesmo estado.


Hi, I've found it interesting :-) Is it possible to use it as sniffer between another two devices (TV and receiver)?


ееей!


Addressed in `3.3.2`. Thanks! :apple:


> Maybe rework the whole method:

Except the problem is that undoable actions could sometimes return just a boolean, and sometimes return an array of booleans.

The original function was designed so that it would return true if and only if successes was either truthy, or an array of all truthies.

Honestly, though, this isn't documented, and hardly any undoable actions explicitly return anything. Indeed, I'm not sure when writing it if I could find an explicit case that returned false, but since the preliminary architecture for returning a value after an undo or redo seemed to be there, I decided to use it.

Perhaps we should just ditch this method, and recover it if/when we have an undoable action that explicitly wants to say if it failed?


Formatting the image list to the essentials ,the other fields do not seem to contain text data


(If the feature is really that compelling, then we should be able to spend the few days to add a zone option to weave launch, pass it in the connection features set, and use it to determine whether to encrypt overlay traffic or not.)


Yeah, not really sure what we would do in that scenario...? Try and bounce back to login? Would that get us caught in a loop?


Fixed.


With pleasure! :smiley:


In a3d6f2d I've added a `null` check and created a default `Gson` instance if the passed in instance was `null`.


Please revert the change; the UserDN as implemented prior to your change is absolutely necessary. It takes the place of the previous "Ms Ad SA" field but names it something more understandable. For an explanation, please see the updated LDAP Module readme.

On that note, can the LDAP Auth page in the documentation be updated with the new README?


Acel "=" din commit se datorează noului feature, acum (16092015) îmbunătățit: commit direct din linia de comandă, folosind comanda `php bin/m2cms repo:push`


попытка номер три


A good way to writing it clear is:

		var input = ...
		try {
			 input.read
			 input.close()
		} catch {
			case NonFatal(e) => // do whatever you want w
		} finally {
			IOUtils.closeQuietly(input)
		}


Taking out the break for now as the OpenStack GetImage is returning errors for cloned servers


Handling the Empty return of the OpenStack Get-Image
At least the list will display this way


We use BookIT! to **reserve** a desk...


I used the dynamic setup, which is a bit more convenient during dev. ;)


Mel Nijntje!


I think either one is fine, so no need to change it if it's already working.


nice. I totally forgot about this


Adding the exception to a global to return more detail. It seems when it changes scope we lose many details of the error message


Before you add anything, though, let me push up some reorganization that I've been doing.


Can you explain to me why you check this here? It doesn't seem to affect the outcome of the function?


The `IllegalAccessException` happens if we try to get the field and it isn't visible. I had already documented `QueryParameter` to say it should be used on `public` fields, but this handling wasn't great! `QueryParameter` should only be used internally so in a3d6f2d I've wrapped the `IllegalAccessException` in a `RuntimeException` so it can be thrown without checking and will break the tests if we have used it incorrectly on a non-public field.


The defer has been added.


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


To be a little clearer, I should note that the use of the "User Filter" setting when using simple LDAP differs slightly than when using bind DN LDAP. With a bind DN, it's used to filter the results down to a single user AND to restrict which users may log in based on some criteria. With simple auth, it's only used to determine if a user is allowed to log in based on some search criteria, but it does *not* identify _which_ user is logging in; that's what the UserDN is for. All of this is explained in a bit more detail in the README.


to **reserve** a desk


Poderia retornar a task


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1871 of 1873 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


@alain91 - This deletes all of the permissions associated with the system module, which includes all the module access rights. This makes a working system mostly unusable.

I'd like to be able to run a test system, unit tests and my editor all from the same repository, and this makes that very difficult.

Any thoughts on a safer way to accomplish this? Thanks!


trying to stick to the 80 chars rule - which i reckon is pretty important in docs


@Rashed97  I started from g4stylus https://github.com/TeamRegular/android_device_lge_g4stylus-common and referenced your tree. I was planning to drop my tree on yours and make a refractor commit, cleanup, or something ,but if you diff my tree you can clearly see it's not yours but cyanogen 8916.


The funky formatting is because GitHub thinks your "====" is underlining the text above, and hence formats it as a title. I fixed it by dropping a space in front of the lines.


Lower case leave without pay


... for the **birth or care**...
I think foster care should be lower case.
...the care of a **spouse, son, daughter, or parent** with... (same edit for second use)


Fixed, thanks.


So that would be more like:
```
reduceSuccesses: (successes) ->
  if isArray successes
    return false for s in successes when not s
    return true
  else
    return successes
```
Except that would currently give a lot of false fails due to undo commands not returning anything...

I'll defer to you guys on this - I just needed to fix the NPE that was getting thrown in some cases for CODAP.


@benzonico shouldn't be possible - CFG can contain only statements and expressions


`inProgress: map[string]struct{}{}`


@benzonico types shouldn't appear in CFG - it should contain only statements and expressions


I'm not sure what you mean. To me, www.contoso.com/foo.bar is a URL with a file name that includes its extension (.bar), and the writer's text (not my words)  is simply stating that you don't have to fully qualify the filename. If I'm misunderstanding the technical nuances of terminology, please let me know how this should read. Thanks!


> Is GCC still needed and is this really the module we should use on Kesch (because there's also the -EB module)?
Correct, GCC/4.8.2-EB is the right one now ! i will modify the readme


This commit/PR has been randomly selected by the ng-conf team. @itslenny, we would like to thank you for your dedication to helping the Angular community. We want to gift a free ticket to ng-conf 2016. How do I get in touch with you?


@benzonico 4 cases above shouldn't be possible - CFG can contain only statements and expressions


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8415/testReport/) for this commit**


Do you think I should cut it altogether then?


This commit/PR has been randomly selected by the ng-conf team. @hannahhoward, we (the ng-conf team) would like to thank you for your dedication to helping the Angular community. We want to gift a free ticket to ng-conf 2016. How do I get in touch with you?


Yea as soon as I get the menu I'll get that put in place.  I wanted to just get it seeded for now.

Sent via the Samsung GALAXY S® 5, an AT&T 4G LTE smartphone

-------- Original message --------
From: John Trenton Cary <notifications@github.com>
Date: 09/16/2015  10:56 AM  (GMT-06:00)
To: UNTSoftwareEngineeringGroup/RestrauntSystem <RestrauntSystem@noreply.github.com>
Cc: caynraiser <caynraiser@yahoo.com>
Subject: Re: [RestrauntSystem] Creation of menuItems model (dbcff32)

In seeds.rb instead of having a loop could we have the actual menu item data in there so we don't have to worry about adding it later?

—
Reply to this email directly or view it on GitHub.


good


@benzonico CFG should contain only statements and expressions


It was, but on reading this again the other part of this comment block was out of date too - I have updated it in c13c211.


Will this be an outdated comment?


Hmm... I see. I was looking at the example you give in the PR, which I now know somehow you give the BindDN one.


This is amazing. Congrats @itslenny !


Maybe move outside the loop:
```java
if ((write == null) && (page.getPositionCount() > 0))


Hi Colin and Bo,
I made some changes in the R code to fix the issue below.
The updated code should handle the case when the user input the rsem output matrix with path in.
Please let me know what you think
Thanks!
Ning

=======================

Thanks for the bug report here.  It looks like the problem is in the construction of the normalized counts output filename when the input counts matrix is not in the current working directory and specified as a relative path.  We’ll get this fixed soon, but in the meantime there are couple of workarounds:

1. Comment out or delete the last line of the script EBSeq/rsem-for-ebseq-find-DE
2. Run rsem-run-ebseq with the counts matrix in the local working directory

Option 1 will prevent the output of the normalized counts matrix file, but you may not need that.

Ning - we should think about how to best output the normalized counts matrix file.

Best,
Colin

=========================
On Aug 25, 2015, at 2:03 PM
I am using RSEM for the analysis of an RNAseq study, and I have encountered a possible bug in the script that calls EBSeq. In the newest version of RSEM (1.2.22), I receive an error at the conclusion of execution:

Error in file(file, ifelse(append, "a", "w")) :
 cannot open the connection
Calls: write.table -> file
In addition: Warning message:
In file(file, ifelse(append, "a", "w")) :
 cannot open file 'norm_/home/sslich2/CeO2/RSEM_STAR/out/Ctrl_V_CM.counts.matrix': No such file or directory
Execution halted

This error is not present in an older version of RSEM (1.2.9) using the same input matrix.  The output tables for each appear identical (except for the new means in the newer version), the only difference is in this error.

Just thought this may be of help.


Ah...much better.  Thanks!


This should be moved to authorization otherwise there is no way to authorize


LGTM


I'm late to this party, but for what it's worth I think `it/src/main` might not be a bad place for this code. It's clear and enforced that the `it` project contains no production code, but this is not used in automated tests, o putting it under `main` would make it easier to use `project it`; `console` to bash on the API.


The idea is to get rid of using a subrequest for the default bucket because it is costly (75 RPS to 70, ie. 7%)


Test added https://github.com/tessel/t2-cli/commit/e02ff9c845dfc408513b90d35c944f92c5431b94


closes #1


Changed


Comment on change left


Comment on change 2


Comment on whole commit


Use dynamic programming algoritm


jjust.... no...


@cutreth: Some change(s) in this may be preventing Heroku to work. Could it be the wsgi.py changes or something else? I'm able to run locally (on my work computer, but my home computer but that's a different issue I'm having at the moment).

https://devcenter.heroku.com/articles/getting-started-with-django


The example in #1581 does not use a BindDN; see the UserDN field in the screenshot.


Shouldn't have deleted watermark link. Need to re-add this


Why do you even do this? just permban like normal


@SergioBenitez please take a look at this one.


Is this the `merge_commit_sha` attribute that's [deprecated and scheduled for removal](https://developer.github.com/v3/pulls/#response-1)?


@itslenny you can reach out via aaron at frosty dot io. I will respond with you ticket code. Thanks again!


My bad :sob: fixed in another commit.


If we can get 2 or 3 of each category into seeds.rb I can start work on the menu view https://drive.google.com/drive/u/1/folders/0B2peGm8Jt0R8flZkX21sSnJJalgyRURMWEFRbERZQ1JCWEd4WWk1Nkw1N1RrZUNCbmVFV00


Ooh, good call.


FDGroundTempModelBugFix (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1850 of 1869 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.98%25-yellow.svg)


A pfd file with a few instructions


This update displays a live preview of the tile. Go to the layers tab while running a game, then hover over the image. A magnified version of the tile will appear. This only works with the BG layer, but eventually all layers will be able to be dumped like this.


The same fix should go in `ImplicitMidpoint` as well...


The original function, plus your change, seems to me to be the clearest, if we're still operating under the assumption that successes can optionally be an array, and we only want `false` if successes is false or contains a false.

```
reduceSuccesses: (successes) ->
  return successes unless successes?.length        # returns successes if it's not undefined and not an array
  return false for s in successes when s is false  # returns true if it's an array of truthies, or it's undefined
  return true
```

I think the minimal change would just be inserting that `?`.

I do think we may want to rework it how we call undo and redo, so for instance we could have an expectation that we always explicitly return true or false. But I don't think that needs to be part of your PR.


Do we want to create sha256sum files for the images on builds.beagleboard.org as well?


welcome back :+1: )


actually i dont think we need to redirect to a log as i think rqworker logs regardless.

Maybe we should background stderr as well - and mention where the log file is


This commit/PR has been randomly selected by the ng-conf team. @hannahhoward , we would like to thank you for your dedication to helping the Angular community. We want to gift a free ticket to ng-conf 2016. How do I get in touch with you?

You can reach out via aaron at frosty dot io. I will respond with you ticket code. Thanks again!


I added this line because inflection.dasherize does only work when the string has underscores. Which is in my opinion usually useless, since as far as I know class names are usually camelcase in python.


It doesn't; there is no `implements` operator. Its only use case is when declaring a class.

`instanceof` clearly won't work, as you're looking at the class name, and not an instance. Thus, you have to resort to `class_implements()`.


I don't think so because `(JsonObject) this.row` cannot be `null` here because of the if/else on lines 32-36. I don't think the `(JsonElement) row` passed into the constructor can be `null` because it comes from looping a `JsonArray` so if the value in the array is `null` it should become a non-null `JsonElement` of the `null JsonPrimitive`. In that case I think we would just get `false` for the `row.isJsonObject()` check.
Do you agree or am I missing something else?


Suggestion: would it not be better to get the function call string, I assume for using it with eval(), via
```
repr(Tree)
```
instead of
```
str(Tree)   ?
```


If @jdegoes and @sellout don't have anything to say, I think that sounds like a good compromise.


should readStructBegin and readStructEnd be inside ThriftStruct.read()


This works. Thanks!


Whoa, ok thanks for catching me on that. I assumed (bad) it had to be a copy/paste error from moving it to a function


Show me where that URL is used in a MVC app. MVC apps almost never have file extensions - it would be an extremely rare event so I would change the text. You could change it to URLs generally do not include file extensions but that is misleading.


@ragesoss To staging, certainly.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20810/testReport/) for this commit**


Nombreuses évolutions du code car test général de l'application en cours


@SergioBenitez no, thank you!

I had very little knowledge on LDAP and still learning as trying to setup a instance, many details I can't tell.


merge


partially fixes #2


> What features is it missing that you need?

Don't really know yet, we're building the bindings in parallel with the actual server that will use them, so they're evolving together. The thing that's most likely to be an issue once we get there (entirely speculation of course) is the inability to access the actual child vectors; the fact that the size but not the contents is exposed in C is a bit weird.

> In particular, want to make sure you're finding the generated c/GraphQLAst.h header

Yup, the latest version of this branch generates ruby accessors for each of those methods.

When we started this project on monday we complained about the complete lack of a `make install`, glad to see that not only has it been added already it's being actively improved :)


Wrong variable for error message. Should this be `schema.table`?


Hi @stargo, does BFQ work better than say ROW on our ancient 3.0 kernels? I'm thinking of jumping on this bandwagon after seeing the recent CM12.1 changes, but the BFQ-v4 I tested a while ago was running well. Anyway, I'll probably get inspiration from your tree when cherry-picking ;-)


I thought that if we return anything except `false` to CODAP that CODAP would treat that as a successful undo. (From `handleUndoRedoCompleted` in gameController.js)

So returning undefined should be fine, right?

Your proposed function seems identical to me to

```
reduceSuccesses: (successes) ->
  return successes unless successes?.length  # return successes directly unless successes exists and is an array
  return false for s in successes when s is false # return true if it's an array of truthies
  return true
```

Yours is more explicit, so I'm fine with that.

I do think we need to look into updating the undo system, perhaps by having a convention that we always return an explicit true or false success after a command, but that shouldn't be part of this PR.


No need to wrap


partially fixes #1


I'm afraid it should be a bit more complicated fix: we're not always use `deviceScreen.width * 2 / 3`, sometimes user can specify custom `openMenuOffset` property, so if you can take it into account, I would merge this PR :+1:


I am from...


Done.


Code that's not used in a production path should not be in production. All the more true when the code is "unsafe". It should be in tests or a separate subproject.


Paul - I cant seem to find a way to download this game for mac - Can you please help me - thescream80@aol.com


These are only used for errors. Using `SchemaTableName` would simplify things


Makes me think, shouldn't this simply be more general (not tied to PSK specifically) and live on the polymer docs site?


Ok, I have pushed a change with fixed height for the textarea. This should work better, but it won't grow when the widow grows...


Possible. Go ahead and try adding those three lines back in. You'll want to see if anything needs to go back into settings.py.


zffsfdasf


Static import


Edit: `return false for s in successes when not s` in your function would indeed trigger false nagatives, because it would return false for an array of falsies. I would stick with `return false for s in successes when s is false`.


@thenickcox great. I sent it to staging last night. I'll poke at staging for another day, but I think everything from the controller refactor seems to be working.


Minor: No point putting this into scope outside the branch which uses it


do you need 'this'? will you extract var for 'this.state.nics'?


I *think* I understand what the original author meant, but I agree that it's misleading/confusing. I changed it.


change it to
For ex, the controller action methods takes route data and query strings, pass ..


I wouldn't put this here but in the views/buckets.py file.


why _uuid?


Nice, I like this method. I'm going to merge and test the heck out of it.


Should undo 89d321c9fe20dd0dd6733f058b19ab3c3d1fe4fa


personally I don't see a *real* need for it, but note that the original motivation for #32 was to build an alpine image *except* with no init system. In that case, adding alpine-base drags in unwanted dependencies.


Right, there is no exception. I did not realise this. `Either` is fine by me than


Yeah, I sure felt gross when doing this.  I thought about keeping TearDown and having Dispose call it but . . . that's not actually different.  Filed #210 to restructure to a cleaner world here.


weird, you have it already defined above


listUuid -> nicUuids


Would you please the compiled binary to the Releases?
It could help us a lot.

Really appreciate for your help.


This is very weird: all calls to `calcDifferenceForMembers` pass `compareObject` field as `compareObject` parameter


One limitation of this approach that I just thought of is that the UI won't mark these fields as mandatory (no red star).
You can fix this using a 'mark_required' config like this:
https://github.com/flavour/eden/blob/master/modules/s3db/hms.py#L713


`descriptio` => `description`


Recently worked on a project that had an old version (0.2.3) of MMProgressHUD. Upon updating to the latest version (0.3.1) of MMProgressHUD, the project no longer compiled because MMProgressHUD contains a number of UIApplication methods which you cannot use if your project contains an extension. After doing a bit of research, I took a page from the AFNetworking team and added attributes to the offending methods which now allows MMProgressHUD to successfully compile.


so what if primary was removed and length > 1?


Try to avoid these blank lines in CSVs - may import OK, but harder to maintain


issue #4 closed


Typo: "is empty or"


Is this intentional?  It looks like this used to use `Assembly.Load(assemblyName)` any time WIN8_STORE was *not* defined, but now it does it only for PLATFORM_DOTNET.


Felicidades, *Herr Kiessling*! Ha encontrado usted la forma de hacerse millonario. :laughing:

Note el caso que, si usted se dedicara a la crianza de cerditos, y tuviera digamos unos veinte, con una tasa del crecimiento anual del 100%, en vez de cuarenta usted llegaría a la formidable suma  de 2000 cerditos en un año. El método de la población proyectada que diseñó será la envidia de cualquier granjero, no lo dude.

Lo saluda muy atte.

Cc @riclops17


I'll have a look

Le 16/09/2015 18:04, Richard Griffith a écrit :
> @alain91 <https://github.com/alain91> - This deletes all of the
> permissions associated with the system module, which includes all the
> module access rights. This makes a working system mostly unusable.
>
> I'd like to be able to run a test system, unit tests and my editor all
> from the same repository, and this makes that very difficult.
>
> Any thoughts on a safer way to accomplish this? Thanks!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/geekwright/XoopsCore/commit/5dc9078d0c8f7c2a96a5d0f4d5c94a54e127634b#commitcomment-13266444>.
>


103404908-AddWarningWhenScheduleTimestepsDoNotAlighn (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (1864 of 1867 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


I'll create a specific method (called from the constructor) instead of hardcoding it in the constructor. => to keep the constructor cleaner as much as we can)


I was just going to point that out. :)

That seems reasonable to me - we'll just have to remember that when we implement undo actions' return values here: false is a failure, anything else is success. Or put in a separate story to refactor everything to be more explicit.


LGTM.


but yeah I love the idea anyway. good !


Thank you for noticing this, it has been fixed in a22b775


* Not all editors guess automatically, but the biggest problem is for new files.
* Some programs create automatic backup in case of (crash, user that did not save but finally want to, etc). Sometimes, it could be also useful to create one manually and then it is more convenient to git add a folder instead of specfic(s) file(s) or remove the file, so sometimes by error git add folder adds backup files.
* ".txt" is not problem for at least GNU/Linux and *BSD, so there is no reason not to help Windows users by this way.
* I did not know your website, sorry.
* Thre is AGPL version 1, so with the previous text version 1 could be used, it would have been bad to loose the benefits of GPLv2 (which AGPL1 is based on) to GPLv3.


Olá, excelente trabalho!
Uma pergunta: o migtools não funciona em openelec. Está previsto suporte no futuro?


Dang it.


More likely, the tower electricity is lower because the dual towers are oversized.  They need sizing factors, will test that here and confirm.


pushed ;)


what is going on with these two commits? the build broke and i somehow didn't notice


> the fact that the size but not the contents is exposed in C is a bit weird.

Oh, I did that because the contents are available using a suitably-configured visitor. I didn't want to take the copying overhead (and burden on the API consumer to free the results or caching complication in the C++ AST itself) to expose `std::vector<std::unique_ptr<T>>` as `const T*`. This approach was loosely inspired by libclang's C API -- http://clang.llvm.org/doxygen/group__CINDEX__CURSOR__TRAVERSAL.html


Issue #2 work around -- by using "%AT%" in the doc in place of "@"


Personally I prefer ROW always with a read ahead of 2048KB...read over write does better on mobile handsets in my opinion and is most notable on older devices like omap4


perfect, yes fine, glad you liked it :D


Unused variable?


don't we need to add gc_ and fc_ in this array ? ...


OK. Which version of bundler are you using?


I think in this case we can omit the rule.


How would this reduce?


Ah your idea is to add the filter in Customizr Pro then, am I wrong ?


@clearhead/clearheaders YAY! Landed in v0.0.32 - cd into `clearhead/clearhead-experiments` and re-run `npm install`.  TLDR it auto sniffs and fires events back to every platform (when they exist) with a single call - better usage docs in this commit: https://github.com/clearhead/clearhead/blob/660c3a4316b372d8fcc347bf4ad38910f011e5ee/src/goal.js#L8-L22


I have not checked whether, but if we only use one of these output formats I see no reason for keeping code for the other ones. Hex-encoding is no harder at the caller than it is in this function.


@dwaynebailey Next time please comment on the *Files* tab of the PR. Comments on the commits can be forgot easily.


Using ITextView, not sure if it's most approrpaite but needed for getting text snapshot and position. It feels we should have some entity to encapsulate this but I'm not sure how it's done in other pieces of the code.


Keep the name WriteBytes, to be consistent with Stream.Read.


Add `this.`


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/e1a80fb5ceec23af39cdee27c568469a2579175d/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/e1a80fb5ceec23af39cdee27c568469a2579175d/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/e1a80fb5ceec23af39cdee27c568469a2579175d/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/e1a80fb5ceec23af39cdee27c568469a2579175d/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/e1a80fb5ceec23af39cdee27c568469a2579175d/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Fine. It might not matter much, but I'm pretty sure I saw a performance regression from the mem_align version so we should not use it unless needed.


Yes, this was intentional. This code should work for Windows 8 apps (which we do not officially support in 2.1).


what are these two for?


Add string to resource.


I don't think so. Release notes might have some requirements but I think it is better to keep them there.


Used in next line for example.
Trying to minimize code change, with comments. This may help future upgrade with the original repo.


wouldn't this ideally have an max exception depth?


oops not used, I didn't intend to push this.


i think we need to continue to use the general promote tables.  the point of those is to avoid logic. data is better than code in many cases.


103404908-AddWarningWhenScheduleTimestepsDoNotAlighn (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1870 of 1873 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


Your comment implies you want other people to be able to change it.  If that is the case you should be taking the value passed as an argument and returning that instead of your own default.

```
function custom_woocommerce_product_add_to_cart_text( $text ) {
    if ( $customText = get_post_meta( get_the_ID(), 'custom-add-to-cart-text', true ) ) {
        $text = $customText;
    }

    return $text;
}
```


I trust you know better and that I'm speaking from a point of naivety (in this case and all cases). I'm going to voice my disagreement solely because I'd like to better understand where I'm wrong.

I think a wrapper method is a trade-off at best. For a gain in clarity, you're adding more indirection and the potential for the method to do extra, deceptive things beyond simply initializing an object with the given parameters. With changes to the class, you may also need to update the name of the method to maintain clarity (ideally that's a quick search and replace, but it becomes annoying if you end up having to think up a non-trivial regex to pull it off). I also think the gain in clarity is hardly significant - specfiles are devoted to only one class in question anyway, and if you momentarily forget what it is, you can glance at the name of the file you have open.


Something like that.
gc_ isn't needed anymore, 'cause you prefixed gc options as tc_gc so => tc
in one of the versions of this code I wrote that :D (sorry :D)
fc_ is added by the footer customizer addon/plugin ('cause it can always be a plugin). [there's a PR for that in the fc repo ;)]
So basically yes! ;)


should this comment be deleted?


The replacement of the whole requirements section by this simple note is a changeset that belongs to the "Creating requirement docs page" commit.


Tests added https://github.com/tessel/t2-cli/commit/7317dc3dd047898686784a0c499c67ebb8b33222


Reverted in 9e2599e.


Righto - I'll make the change and keep that in mind.


Is it possible to use Type for left, right?  Using the more general type is often a good principle as is makes code more general and less sensitive to future changes. I use philosophy of putting the minimum constraints possible on data.


Thanks for the suggestion Narimm; change applied and committed


Agree the hex impl is in optional in our use case. But I plan to showcase this to the author of the upstream repo. Hoping that he will include something similar. Ideally, if everything gets merged back to upstream, I prefer to somehow fetch this library externally.


wouldn't this ideally have a max depth for exceptions, and when will this be patched? Since losing a postgres connection in rails trigger can this, it would be nice to have an updated client soon.


I just inverted the 'if' here.


103404908-AddWarningWhenScheduleTimestepsDoNotAlighn (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


The outermost parentheses define a generator. I could also use square brackets to define a list, but I prefer generators over lists when possible.


index can only be checked at runtime. also index can be expr like a+b not just a single integer literal :)


By the upstream repo, I meant the js-sha3


La permission qui permet d'enlever la commnde : /refarena c'est quoi ?


Sure, and as minimal system I didn't think the `etc` folder from `alpine-base` mattered. But seeing as it is a switch, I guess it can stay.


OK, we'll do without for now and see how it works. I just about have something ready to PR.


we can look up type names in the symbol table. They are in PREDEFINED scope at top level of scope tree :)


```python
>>> g = (i for i in range(10))
>>> g
<generator object <genexpr> at 0x7fce52fee048>
>>> l = [i for i in range(10)]
>>> l
[0, 1, 2, 3, 4, 5, 6, 7, 8, 9]
```


103404908-AddWarningWhenScheduleTimestepsDoNotAlighn (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1849 of 1871 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.82%25-yellow.svg)


ok perfect


Pronto, criei uma branch development e removi o .idea.


we don't know the size I'm afraid in general case.


パラメーターに含めるのはOKかと思います！

あとは、受け取り方の問題ですが
params[:id] で受け取るのは違和感を覚えませんか？
tag_nameをとるのに、key名は:idだとおかしいですよ、key名を`tag_name`に変えてしましましょう！

`paramメソッド`を使えばよいです。


Seems legit :+1:


:smile:


TD doesn't have a getColumnCounts(), is that something you need here? Also, must call Connect() first to start the connection.


update


this is an example of a comment. I am able to comment directly on specific lines of a file.


ok now need to rename this ;)


this comment is appended to the entire file.


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1339 of 1339 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.23%25-green.svg)


I would move all of this out to another actions file - keeping the buildHistory only about history (even though it's triggered from within the history, it's not really "history"). Maybe we can put it with the buildActions, not sure if it needs its own file..


come on if your going to update to 3.10.88
do it right! so you don't lie


PS: also see #317


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2309 of 2349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.3%25-yellow.svg)


Thank you! Fixed with cf9079c7832ecf470b867b9c7a87566808ab6706.


bool serialization should be fine - check saveBoolean()/loadBoolean() in Connection.h - bool's are always saved as ui8
Problems you refer to come from std::vector<bool> which (according to standard) is a special case and uses template specialization. And this case is handled as well


@return bool or id number no ?


strncpy doesn't promise to not read oob either (only strnlen does). But we already have the true length, so we can just memcpy.

Also, while you're at it, mind adding an overflow check to siz + 1?


But type hinting returns an error and wouldn't be much different from not having the is_array check.


Good. I hated that thing.


@jdalton I'm not sure which would be best. Open an issue so we can weigh the pros and cons.


неправильно закрывается сканер


@ ZoltanBojthe
I aggree, addressed this in fe0d3f1


Changed


fetch="http://android.googlesource.com/" name="korg"review="review.source.android.com"/>


You don't have to set this. It is done by the InitializePrefab method.


yes, totally right, sorry. So maybe better, ID or false


I have updated with the complete functions for the assignment.


im hoping it works?


Could you also include a root disk check example in the base passive sample checks?  You could leave it commented out.

#%HOSTNAME%|root free = /disk/logical/|/used_percent --warning 80 --critical 90


I added that because for some reason InitializePrefab didn't do that


`fs` module not needed


These methods are missing docs and I don't want to ask you to write them; but please add a one-line note to the definition here saying

BUF_strndup guarantees to never read past the first |siz| bytes of |str|.


Why would you want to set a gateway at all?

--
Scott McWhirter | konobi

On Wed, Sep 16, 2015 at 7:35 AM, Jorge Schrauwen <notifications@github.com>
wrote:

> perhaps tagging the first IPv6 static address for each interface with
> '''preferred''', this way it makes it more predictable which address will
> be used for outgoing traffic.
>
> Example of this is in PR #475
> <https://github.com/joyent/smartos-live/pull/475> on line 285
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/joyent/smartos-live/commit/837b13405c6e871699999565a02e33ac0a8ba075#commitcomment-13254089>
> .
>


>2 Только если делать его полем класса, тогда можно сделать static.

static средство, а не самоцель. Нужно сделать так, чтобы массив не создавался при каждом вызове. В плюсах это делается через статик у переменной. В джаве придется выносить в поле класса.


Restore this line, please.


Only thought I have is to take this and make it an option on `MVTSource` to support arbitrary point sizes, but otherwise LGTM.


Do you have a better explanation handy? My understanding is that given a url like <host>:<port>/blah/blah/blah the Docker client does not expect the API requests to be hosted at <host>:<port>/blah and will treat that as a namespace.
FTR testing against our Docker impl shows that trying to push to <host>:<port>/blah/blah/blah fails, as I would expect. Not sure what DockerHub would do with the same request, but strangely enough searching with /blah/blah/blah does return results.


Good.


Thats probably a good addition, i'll look into it.


Does the tunnel track still have a rail segment mesh with this change? I need that for my sunken station.


May I be rebel and rename to `store_only_val`?


develop (axelstudios) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


It's the old code, it has been removed. (red code is deleted code)


Good!


I bet those regressions were prior to the current macro expression only mem_align


Looks good to me.


Default values. `buildTriggeringDone` determines whether we should show the loader or not, and `buildTriggeringError` gets set if the server returns an error.


@marbemac I just noticed your action here, can you describe the problem you ran into so I can fix it?


Oh, no it doesn't. I think you need a separate sunken rail asset for that.


This animation timer has nothing to do with the sound.
backgroundSound.cycleCountProperty(); is defined in the Sound class, so it should be looping.


That's why you should check it before you make the call. The farther down
the chain you push issues, the harder it is to find them. Especially useful
for IDEs
On Sep 16, 2015 12:59 PM, "emanuele45" <notifications@github.com> wrote:

> But type hinting returns an error and wouldn't be much different from not
> having the is_array check.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/elkarte/Elkarte/commit/9a5be41a3d8427ce955e878a936e09f0de5a015b#commitcomment-13267616>
> .
>


Вот. Теперь отдельно вызов
```java
if (!isValidJavaIdentifier(projectName))
```
, отдельно метод
```java
private static boolean isValidJavaIdentifier(String identifier) {
```

Отлично читается


Do we need to update a script somewhere so these stop getting generated?  Or do you think it's already been altered and he just copy+pasted from a file that hadn't removed them?


Did you manually edit `dist/angular-cache, or just upgrade babel-core and run the build?


This is starting to get lengthy in the styles alist:

```lisp
(ess-align-continuations-in-calls . ("[ \t]*(" "\\(if\\|all\\|any\\)[ \t]*(" "[^ \t]+\\["))
```

Would it be good form if I replace those lines by
```lisp
(ess-align-continuations-in-calls . ,ess-align-continuations-in-calls)
```
to retrieve the default value?

Actually maybe it'd be helpful to use this pattern for all default values, so it's easy to see where a theme differs from the default.


- can you point to an example project that uses an external xml file to specify sub-modules?
- also is there a reason why we should not be trying to run our instrumenter on those sub-modules as well?


The preferred is not for setting a gateway.
If you have (multiple) static address(es) and at least one SLAAC address the preferred one will be use for outbound traffic for the subnet it is in.

if it is not set it seems to change sometimes, sometimes the SLAAC one is used, other times one of the static addresses.


@Funmungus You can try the build script introduced by this commit https://github.com/zjx20/scanmem/commit/e7eba8eb7c50cd6b47a82bb838bb4e0f5bf7a9b6. It builds scanmem with libreadline. See the README from my fork for details. Hope this helps.


Нужен статик у keywords


TeamCity pull requests :: netty [Build 212](https://garage.netty.io/teamcity/viewLog.html?buildId=1409&buildTypeId=pulls_netty&guest=1) is now running


Yeah, that was the mistake I was talking about...


what if it is an interface method and not explicitly implemented?


maybe use the RC11 method getName instead of getAlias


94006714-MultipleTowers (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1872 of 1872 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Các lỗi sửa hết chưa. Anh thấy cái lưu quá nhiều tile xuống DB cũng ko phải là nhanh lắm và cũng khá tốn CPU. Em có thể cân nhắc việc với các tile có ít điểm sóng, ví dụ, ít hơn 200 điểm thì sẽ ko lưu xuống DB nữa, mà chỉ cần lưu tạm vào 1 cái lru thôi. Với các tile ít điểm sóng (hoặc ko có điểm sóng) thì việc search trong  rtree rồi vẽ hết ra có khi còn nhanh hơn là đọc từ DB, và sẽ giảm bớt số lần phải access vào DB nhiều. Việc chọn bao nhiêu điểm được coi là "ít" thì em phải tự chọn thôi.


test file


Ok, should I re-issue this PR? Looks like it has been merged but don't see it in commit history.


Never mind yet... I've been looking at the first commit :) will check the final impl and raise it if its still a valid question.


warum nicht
```python
def get(self):
    return(self.xmin, self.xmax)
```


> so we can just memcpy.

Done.

> Also, while you're at it, mind adding an overflow check to siz + 1?

Is there any preferred way to do that in OpenSSL (like a macro or something)? Also, there doesn't seem to be any specific error for this, should I just use `ERR_R_FATAL`?


Why are we skipping this ? Understand we will get a green light now. But just curious to what the issue was.


Not that it's important or anything, but do we take capitalization into account for our other #includes?


@sjorge Good point. I'll add that to the setup scripts.

@konobi I think that you were commenting on the other line that @sjorge commented on. You may want to set a gateway if you had multiple gateways configured on your network, and wanted to configure them per-host. It's not needed by most people since they're probably using Router Advertisments, but you can configure it manually.


it matches the number in the actual device, as you can see in the structure bellow, its on the index 1 of the array.


Doesn't seem necessary, I don't see them being used anywhere? Are you referring to the same named (minus `this`) properties in `triggerBuildState`, `triggerBuildSuccess`, and `triggerBuildError`?


Shouldn't this be:
   this.mergeDeep(source1, source2);


I think I'm still missing something...it looks to me like this used to use `Assembly.Load(assemblyName)` in "desktop" mode (because `!WIN8_STORE`).  Now it uses `Assembly.Load(assemblyName.Name)` in "desktop" mode (because `PLATFORM_DOTNET` is not defined).  So that's a change in the "desktop" behavior, right?  Maybe I just have the preprocessor symbols mixed up... :)


Тормозов нет.


It's working fine for me with the bfq-support Steve added to CM: http://review.cyanogenmod.org/#/q/topic:bfqio-cgroup

I believe I can see a noticeable difference ;-)


url & email fields could use constraints "url: true" and "email: true"


I would toss out Meijer, but I would transform an int back to an Int and keep it.  I have this impression (perhaps mistaken?) that the results will still be better than tossing the whole thing out.


This is a good simplification, but let's expand the comment to capture the most problematic use case so the reader doesn't have to go do work to rediscover why exactly we're doing this. Also, it's great to mention here what it's replacing for the purposes of this code review, but that kind of comment will become less and eventually a distraction. How about:

    // On retries, allow [uncommitted] intents on range descriptor lookups to be
    // returned 50% of the time in order to succeed at finding the transaction
    // record pointed to by the intent itself. The 50% probability of returning either
    // the current intent or the previously committed value balances between the
    // two cases where the intent's txn hasn't yet been committed (the previous
    // value is correct), or the intent's txn has been committed (the intent value is
    // correct).


Seems to do the job, I'll close the issue.


@jdegoes Does that mean you agree that this is a good compromise?


“” + ii 如果把ii改为carid会更好，因为如果多个app客户端同时发送获得请求的话，无法区分是那辆车。同理问题也存在开始时间和结束时间的不同条件的结果。


Thanks for the edits and pointing out the bullet which sounds like a slight.  Reading it now, I see your point and agree with it.


Warum wird hier Reflection eingesetzt?


This looks good. I might phrase the commit message "Only terminate the task when there are no other pending callbacks"


Might be helpful to preface the code snippet with something like, "Consider the following example:"


Because circleci is running a kernel version less than 3.16 so overlay tests can't be run on circleci for now. But still I want this test in so we can still run these tests in our local machines


haha... wat? did I seriously have that defaulted to `true`? LOL :laughing:


good good study,day day up


indent to match above code snippets


Thanks for clarifying.


Bitte unproduktiven Code entfernen


The comment above now needs to be updated. I think you can just remove the entire comment and TODO.


ich  habe etwas gelernt :-) danke!
aber ich finde es verwirrend:

- `__eq__ ` sollte mathematische gleicheit bezeichnen!
- ich würde die methoden für <,>,==,... weglassen und nur zwei methoden definieren:
    * intersect()
    * union()
die haben eine logischere bedeutung. == muss Gleicheit darstellen


It's interesting to have the behaviour/events of your application in a time-series form, cool!


Prüfen, ob der Einsatz eines FocusAdapter nicht besser geeignet ist.


LGTM (on this particular commit).


Sure, the MigratorInterface doesn't seem to include some of the functions the db-migrate-mongodb driver uses. See the screenshot below - the _createMigrationsCollection is stripped by the reduceToInterface call. There are probably other functions that are needed and stripped as well, but I just needed a quick and dirty fix to make this work, so I removed the reducer :).

<img width="834" alt="screen shot 2015-09-16 at 12 11 41 pm" src="https://cloud.githubusercontent.com/assets/847542/9912409/15277b74-5c6d-11e5-99c8-74fcb3f6f373.png">


Yes, nice catch --- it is artefact of manually converted top-level functions to methods. I'll remove this parameter.


Dito, s.o.


Hi

What is the end result ?

Is there an example of the final design ?

Where I can see it?

Thank you


![2015-09-17 01 19 14](https://cloud.githubusercontent.com/assets/11828413/9912426/2c0e854a-5cda-11e5-88fc-3b9494bbc1f4.png)
支持相机、图片、视频  瀑布流～～～


FYI small update
http://aldostools.org/temp/test/webMAN_MOD_1.43.04.rar

- Added display of free space and total size of devices to the root of File Manager
- Added comma separator to display of free memory and hdd space of cpursx and popup info


Awesome! Thanks!


Bitte entfernen.


Bitte gemäß Anmerkungen überarbeiten.


I see in a later commit that you did this to test against multiple rails versions locally. Might be good to mention the rationale in the commit message (in case someone ever wants to delete the rake dependency later and is wondering why it was added)


What do you think about rewriting this piece in a more DRY way, like:
```kotlin
fun List<ProtoBuf.Callable>.names(nameResolver: NameResolver): List<String> =
        map { nameResolver.getString(it.name) }

val hashes = oldMap.keySet() + newMap.keySet()
for (hash in hashes) {
    val oldMembers = oldMap[hash]
    val newMembers = newMap[hash]

    val differentMembers = when {
        newMembers == null -> oldMembers!!.names(compareObject.oldNameResolver)
        oldMembers == null -> newMembers.names(compareObject.newNameResolver)
        else -> calcDifferenceForEqualHashes(compareObject, oldMembers, newMembers)
    }
    result.addAll(differentMembers)
}

return result
```
?


@Catagen Nice message :P


Not sure why this is speeding up tests ;)


Indeed, I'll fix it. This one slipped through (as you can guess from commit title) when completing switch to check what was lacking.


Another one


The rest seems good. Open a PR so the rest of the team can have a look in case I missed something.


>  it'd be helpful to use this pattern for all default values

Agreed.


Additional nitpick; I didn't test any of the code and wrote it blind to point you in the right direction ;-)

(jokes aside, thanks for the fixup)


I think in this case the numbers in the test's names are not required. I used that for database only because there was dependencies in the execution order


shouldn't this end with "/" to be consistent with getBaseBinURL()?


For questions, please open a new issue (https://github.com/squires/infinity-pedal/issues) instead of commenting on source files.


@barunio Sure. This isn't being added because of a later commit though. It's being added because it was a preexisting development dependency.


You're right; on second glance, that expression is odd. It would basically always use the first line of code except for Windows 8. The other `||` expressions don't matter, because they too are `!WIN8_STORE`.


yeah looks good.


It might be good to preserve these comments


Bhighley Bio added


tested and working


This creates an infinite loop that never ends for me.


Here (unlikely) `ParseFloat` errors can leak out to users. Is it better to return `DNull` with some `errRound...`?


@bsuttor please never, ever commit such changes directly on the master branch; always create a branch and open a PR so we can check your code


I actually found this a bit confusing as well, (that is, I would have written it to raise the exception in this commit). But, it ends up being fine later, so not a big deal.


I'd like to keep the "for ..." ones at least, in case code gets shuffled around to the point where the includes are unnecessary.


@dtolnay -- This is great, but in the following, the message about there being two compile errors is a bit confusing and maybe even incorrect:
```
./jq --arg a a -n '{$a : 1}'
jq: error: syntax error, unexpected ':', expecting '}' (Unix shell quoting issues?) at <top-level>, line 1:
{$a : 1}
jq: error: May need parentheses around object key at <top-level>, line 1:
{$a : 1}
jq: 2 compile errors
```

By the way, since `{ $a }` is valid (and I believe an advertised feature), the prospects for supporting `{ $a : 1 }` as well are rather dim, aren't they?


thanks @alandekok


Oh, ok; nevermind then.


Thinking about this again - if we're adding an element to the DS tag to
specify whether the BQ values are Integers or Probabilities, and we're
passing that info into the PBI for filtering we also need to add that to
the PBI header.  Another bit flag, perhaps?

-B

On Mon, Sep 14, 2015 at 6:55 PM, Brett Bowman <bnbowman@gmail.com> wrote:

> Eh, sure.  That seems like the least-bad option.
>
> I wanted to say we should add the FullPass flag as well, see if anyone
> still needs the CX tag, but there are no existing per-Subread Flag
> variables and we're not going to efficiently pack it below a uint8 ...
> which is already the size we're using for the CX tag.  So we might as well
> just pass along the whole shebang.
>
> -Brett
>
> On Mon, Sep 14, 2015 at 6:19 PM, David Alexander <notifications@github.com
> > wrote:
>
>> Seems reasonable. Do you think maybe we should just always include the cx
>> info, like put it in the compulsory subreads table?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/bnbowman/PacBioFileFormats/commit/559f2a0481e6eca2606a383e8cecf3081b181bef#commitcomment-13226988>
>> .
>>
>
>


@jaehoonkim I wonder if we should also point [deps.json](https://github.com/jaehoonkim/logyard/blob/7ab38a6cb7b88e99c0bc226fb54f451894f8824a/deps.json) to hpcloud repos instead of mirrors and use a real sha commit instead of master.


i like it m8


Disagree about the image as it doesn't seem to add anything to the text. Please elaborate if you feel I'm mistaken.


asdasd


What does '{{filterDomId}_results}'' do?


Removed alignment properties from WebVTTCue and fixed typo issues (\\u0020 -> \u0020)


Add the variable type of item_name in the description


Actually, you can also do it that way:
QRErrorCorrectLevel[options.correctLevel.toUpperCase()];

With eventually a try/catch for error handling.


Syndra Balls to the Wall/Syndra Balls to the Wall/Program.cs

what are you on about?

On Wed, Sep 16, 2015 at 9:53 AM, Justin <notifications@github.com> wrote:

> MANAPERCENT
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Shivermeme/League-Sharp/commit/b8c412a7526d2fc28d91ce31c3e5dacb44749db9#commitcomment-13262782>
> .
>


The way I dealt with this- and usually try to deal with it- is to instead write the underlying operations as atomic FS ops, and layer the code above so that it accounts for the potential of things disappearing.

The spot this breaks down is where something goes into the cache and wipes entries, rather than updating a cache entry.  However that should only be possible during the new clean code- and the wiping of an entry should only happen when a CPV is no longer in the tree.

For a pkgcore client to be accessing a (now) nonexistant CPV, that requires a sync to have happened in parallel, or someone modifying the fs directly.  Neither can be dealt with easily; taking out a lock on the repository fixes the sync issued however.

Specifically, we'd just implement it so that a pkgcore client takes out a read lock for the repo- and for sync, it requires exclusive.  If you've attempted an apt-get update while an install is running (or the rpm equivalent), it's the same protective pattern.


103404908-AddWarningWhenScheduleTimestepsDoNotAlighn (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1870 of 1873 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


FWIW, I don't know where this code is from, I would have written:

```python
with result.dat.vec as res:
    with F_a.dat.vec_ro as F_v:
        matrix.handle.mult(F_v, res)
```

Which saves marking `F_a` as dirty (and can save some comms)


Oh my god?


Heap allocates a new KeyCollection; just enumerate the dictionary directly and use entry.value which shouldn't allocate (the Enumerable is a struct)


Es sieht so aus, als ob einige Dateien nicht gemergt, sondern überschrieben wurden. Das macht es wahnsinnig schwierig nachzuvollziehen, was tatsächlich geändert wurde. Bitte merge erneut ausführen.


Actually, you can also do it that way:
`QRErrorCorrectLevel[options.correctLevel.toUpperCase()];`
With eventually a try/catch for error handling.


I must have been thinking the store needed them initialized since `buildHistory` and `modulesBuildHistory` are. I should be setting them in the success functions though.


Reverted to original


Do you mean in terms of ordering?  I don't think we're terribly consistent about that.


I tried it out on Ubuntu 12.04 on a repo that had no change history, and it seemed to return zero lines causing branchInfo to be undefined. I think 12.04 uses a pretty old version (1.7.9.5??) of git by default  (http://packages.ubuntu.com/precise/vcs/git). Might have been this issue: https://github.com/git/git/blob/77bd3ea9f54f1584147b594abc04c26ca516d987/Documentation/RelNotes/1.7.10.3.txt#L31 ???

No worries though, just happy to get contributions!


Wofür wird dieser Import benötigt?


The setting looks great. I agree the the multiple vimwiki configs are going to be tricky to parse :)

I'm still struggling with the actual config syntax..
I suppose that's where the actual #32 :Unite taskwarrior/settings come in :)
The docs are coming along great, but will also needs wiki entries.


I'd insert "field" in between "the" and "symbols" here, just because it's a little jarring of a sentence otherwise (I know you were just rearranging, so it doesn't have to happen now by any means).


Can't you use ${PV} here?


this can be rewritten as
```
if (!URIUtils::IsLiveTV(share.strPath))
  CGUIWindowVideoBase::OnAssignContent(share.strPath);
```


I never trust those comments.  They might be the reason the #include got added in the first place but I never expect them to be current.  I periodically add #if 0 around #includes to see what happens.  Also our headers are still pretty entangled and it's pretty common to break things by deleting unnecessary #includes from header files.


103404908-AddWarningWhenScheduleTimestepsDoNotAlighn (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (803 of 803 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.78%25-green.svg)


Hmm.  I see you've moved these from the comments relating to them.  I think it's fair to organize this way, but would like a comment indicating that the full descriptions of them follow (at least for all those after PROD)


It's a matter of opinion I guess. I implemented str(Tree) to give the tree, shot and mode because it is more informative than just the tree name. As I mentioned, if you just want the tree name you can always use Tree.tree instead. In any event unless there is a pressing need to change an existing behavior we try to retain it since users might expect and depend on the original behavior as is evidence in the fact that the change broke the python regression tests.


Yeah, that's what I mean.  Not to worry then!


We can! I will change that :)


Agreed, it seems more readable.


Can you change it like this: the /activefarms option is shown only if it is the bot devs group.


Nice, that's incentive enough to invest time into resolving conflicts. Thanks, @stargo.


Oh, snap. Do you have a list of target git versions you'd like to support? If you're right (and I think that's pretty much a certainty here) won't my recent commit break git-run on versions of git where --branch is ignored in --porcelain?


Hey Nate,

I think I checked this with @carloslancha and it shouldn't work.

YUI setters are invoked with two arguments, `val` and `attrName`. `PortletBase` methods `one` and `all` take the second parameter as `root`, so we need to either invoke them manually with just one attribute, or make those in `portlet_base.js` ignore the second argument if it's a string.


Heh, very true!


Why remove "GET"?


Bitte den Bedarf für den zusätzlichen Export der Packages kurz erläutern.


while I struggle to activate the wiki_root config..
(I'm currently at let g:inite_taskwarrior_wiki_root = '$HOME' . '.task/wiki')
I'm seeing an all-around incorrect path;
<pre>
 /home/djp.vim/wiki/project/acct.project.wiki
</pre>
Is there a "/" missing between $HOME and .vim/wiki, in the default ?


ternary operator can be used for such a simple output expression


probs left over


re-read this, located "inite".. oops


Static import `min`


no need to call .get just if (!m_pDB) return;


yes i wanted to keep these for review to make it easier to see what it replaces :)


Die Dateien wurden vermutlich nicht gemergt, sondern überschrieben. Damit ist es nur schwer möglich nachzuvollziehen, was nun tatsächlich geändert wurde. Bitte korrekt mergen.


This is more clear:
```java
System.exit((failed > 0) ? 1 : 0);


On unix, `bindir(package) = joinpath(PREFIX, "bin")` should do the trick.


Is this in the California?


On Windows, `bindir(package) = joinpath(PREFIX, "pkgs", version(package), "bin")` might work, but this would need a check.


I don't understand why `any` or `all` should be treated specially.
I'm pretty sure I want the same indentation -- differently than now (well "this morning") for all function calls in such a situation...


return to original occupation title?


I would like to have an example of a component level test! This is not an integration test. The current test already simulates twilio and pivots.pivotallabs.com


I went to master too.


vbnm


Changes look good, merge recommended!


Why drop the checks for older versions?  Are they not going to be supported anymore?


you shouldn't compare an iterator for < as it might not support it or give results you're not expecting.
use
```
for (auto oldPath = items.begin(); oldPath != items.end(); ++oldPath)
```
but even easier and just as effective
```
for (auto oldPath : items)
```
In this case oldPath won't be an iterator but the type you're storing such as string.


could you provide an example?


Looks good.


Done


Was wurde denn hier konkret "integriert"? Es wurden neue Dateien hinzugefügt und andere, die bereits existierten, wurden vermutlich überschrieben. Daher kann nicht nachvollzogen werden, worin hier jetzt die konkrete Integration aussieht. Bitte korrekt mergen.


Good.  Done.


Toronto, Canada ?


location? : - P


ah nice!


new comment


Which state is Earth in? :)


now working great, for me, with "$HOME/" . ".task/wiki"


develop (axelstudios) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


Pasha huj


I should have caught this earlier but there is no reason why you shouldnt make this a method in the class.


As of now, the parser method was passing in the minimum of the two integers to biclique() (line 146 in run_pipeline). However, I will change it such that biclique() takes both the integers and computes their minimum within the method itself.


This is still not fixed.


94006714-MultipleTowers (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1878 of 1878 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This is consistent with every other parser error message. First the compiler diagnostic, showing what token it saw and what token(s) it expected. Then a possible cause. For example:

```
$ jq -n '(if true then 1 else 0)'
jq: error: syntax error, unexpected ')' (Unix shell quoting issues?) at <top-level>, line 1:
(if true then 1 else 0)
jq: error: Possibly unterminated 'if' statement at <top-level>, line 1:
(if true then 1 else 0)
jq: 2 compile errors
```


this obiously doesn't work. doesn't matter NAB


TeamCity pull requests :: netty [Build 212](https://garage.netty.io/teamcity/viewLog.html?buildId=1409&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5601, ignored: 21 Build time: 00:39:08


Without mem_align it's just doing eg. `andq    $-32, %rsp`. With the mem_align we can only hope it ends up **that** simple but it should still be just a couple instructions worst-case.


You mean California?


I thought the function as `bindir(script) = joinpath(PREFIX, "bin", script)`  but your idea is also ok.


A more prominent and much more important instance of the date format is ISO-style YYYY-MM-DD: `2015-09-14`.


c'est tout bon :thumbsup:, sauf un plus qui s'est glissé ligne 171 du fichier /install/Fonction.php :sweat_smile:
Pour faire l'install, j'ai modifier le fichier version.php et renommer define_new.php. Je te fait une PR depuis la beta?


committed.


Could you merge this commit with the other one, since it's just a test?


Just to keep it consistent following google code style. Can you please change it to use underscore "_" for variable naming instead of lower camel style? and also indentation would two whitespaces. (I do not like it either.) Thanks!:)


94006714-MultipleTowers (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I think it was just from testing for isolation, they def should be added back before anything is packaged/released, I just haven't had time yet but feel free if you'd like :)


yeah it may have been why I did it as two commands earlier. It would be nice to support the Ubuntu LTS releases, but I'm OK with offering reduced functionality for user that have older versions of git. `--porcelain` output is supposed to be stable so I doubt it'll come up too often. I'll recheck once I get back home where I have my 12.04 machine.


What Rails feature is this? Why would you want to use it?


I would prefer not to support `{$a: 1}` as the only special case of key expressions that don't require parentheses. `{$a}` is supported because `{a: $a}` is very common and redundant.


103404908-AddWarningWhenScheduleTimestepsDoNotAlighn (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (1849 of 1871 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.82%25-yellow.svg)


The older method gives the ipv6 adress in some circumstances


What's the difference between using `<% %>` and `<%= %>`?


Minha recomendação, faça o CancellationToken ser obrigatório na API.


How do you know this is a sufficient source of randomness? Is there documentation on this?


Is `app` global or per client ?


aside, we usually do `self.digest` vs. `User.digest`


Seriously, do you not know how to leave a space between methods? I HAVE JAVA OCD.


Hello, sorry to post here. I don't know how to contact you in another way.
Thanks for this excelent addon and I have a sugestion:
playLists.txt is saved and pulled from /userdata/addon_data/plugin.video.playlistLoader
It would be great if the addon could pull a playLists.txt from an url. This way I could just change the remote file and all my kodi's would get the updated playLists.txt.

I made a workaround with the help from a friend, but I will loose the changes with an update. I think an option to choose folder (remote or local) of playLists.txt would be great to have on the config menu.


Im not sure what to do here. Because the folder `joinpath(PREFIX, "Scripts")` contains everything for https://github.com/JuliaLang/IJulia.jl/pull/357.
![image](https://cloud.githubusercontent.com/assets/7973946/9913298/76820c74-5cac-11e5-9fbc-768023ce0162.png)
and `joinpath(PREFIX, "pkgs", version(package), "Scripts")` contains mostly duplicates and some not present in `joinpath(PREFIX, "Scripts")`. `joinpath(PREFIX, "pkgs", version(package), "Scripts")` contains:
![image](https://cloud.githubusercontent.com/assets/7973946/9913345/b0d2f848-5cac-11e5-9518-c7753e4ee6d4.png)


Theoretically the --porcelain could be replaced by `git status --short --branch` with the old explicit removal of color settings. That might work on the old version of git as well as on newer ones, but will lack the stability of --porcelain's output format. I'll leave it up to you!

Thanks for the fantastic tool, I expect I'll be submitting more PR for other issues in your issue list as we use it more at work. :)


you aren't using id.c_str() in the query


$delegatorsCount is now unused


hitap services added and model edited.


For anyone passing by: upstream xmpp was merged into [xmpp-client](https://github.com/agl/xmpp-client) so there's no point creating a PR upstream.


This is based off the main.cpp that comes with MPlot. I'm getting intermitten segmentation faults.  Stack trace points to this line in MPlotSimpleIMageData::setXValues


Is there any reason to specify units? I thought CSS people discourage this. A zero is a zero is a zero...


Bitte korrekt mergen.


@natefoo fixed by https://github.com/galaxyproject/ansible-common-roles/commit/2821b948c372897f49c78f020ef8e6c7c66029a4


This just sets the component ID, adding _results to the scope filterDomId
value

On Wed, Sep 16, 2015 at 1:29 PM, Dave Taylor <notifications@github.com>
wrote:

> What does '{{filterDomId}_results}'' do?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jeff-phillips-18/angular-patternfly/commit/77ea63e5a97263a772ecaeffb21cb166940e2075#commitcomment-13268230>
> .
>


much cleaner!


Schlechter Code-Stil. Entweder Exception (weiter-)werfen oder ggf. loggen.


aside, you can usually avoid explicit `nil?` checks in ruby. I'd probably right this as

```
def authenticated?(remember_token)
  if remember_digest
    BCrypt::Password.new(remember_digest).is_password?(remember_token)
  else
    false
  end
end
```


What's the difference between a `string` column and a `text` column in Postgres?


Do you mean "PowerConnBroadcastReceiver" instead of "BluetoothBroadcastReceiver"?


@jaehoonkim Thanks for your contribution, please ignore my comment above. I will merge in this PR and make the changes to deps.json from our end.


TeamCity pull requests :: netty [Build 213](https://garage.netty.io/teamcity/viewLog.html?buildId=1414&buildTypeId=pulls_netty&guest=1) is now running


Good catch, copy & paste error


this was a bug; it's fixed now


@darxriggs The `install_cfg` target is meant to be executed from the [beats-packer](https://github.com/elastic/beats-packer) project, and that one creates the `build` directory. Are you trying to build your own packages?


aside, we usually do the whitespace like so:

```ruby
group :test do
  gem 'minitest-reporters', '1.0.5'
  gem 'mini_backtrace',     '0.1.3'
  gem 'guard-minitest',     '2.3.1'
end
```


When would the Gemfile.lock change? Why do we check it into the repository?


What's a CSRF token? What is it used to prevent?


Indentation? (Seems to be missing a space)