This is not a robust solution in my opinion. We should not have to modify the raster code in every place where the raster *might* be modified. Instead the transition between MutableRasterHandle and RasterHandle should signal to the Raster that memoization of the hash is safe.


Is [Argument null checking](https://github.com/aspnet/Home/wiki/Engineering-guidelines#argument-null-checking) of Engineering guidelines obsolete? I have seen similar changes in other repositories as well. I was wondering if there is any reason behind this replacement.


嗷，这个不是最新的，昨天忘记commit了


@RandQalan I just went through and added those lines (most were already added or are the default values already), then I removed lines that weren't being used, which was most of them. Can you try this version of the file? https://raw.githubusercontent.com/UniversalMediaServer/UniversalMediaServer/ae68a78b6db29619ff3ef6dee3fae06da1d20f8a/src/main/external-resources/renderers/Vizio-SmartTV.conf

@Nadahar MediaInfo = false can be faster because we do certain checks when using MediaInfo that we don't do without it


What's this extra guy doing :wink: ?


> Please add `data-fx-fade`
It’s in there already :)


attributes_for 以下が、下でもいちいち書いててDRYじゃないような

let(corp_rece_sur_attr) { attributes_for(~~) }
みたいにして書けない？


I see the point. So, should we only use caching when we're dealing with `RasterHandle` and not `MutableRH`?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20939/testReport/) for this commit**


Proposed HTML stucture

               ...

           ...your stuff...

See https://github.com/tripikad/trip2/blob/master/resources/views/pages/styleguide/index.blade.php#L32 about wrapper classes.


请认真看WIKI： https://github.com/overtrue/wechat/wiki/%E8%87%AA%E5%AE%9A%E4%B9%89%E7%BC%93%E5%AD%98


Actually, looking at the rest of the code, I think it was supposed to be:
```
$unq_head_array[2] = $email['message_id'];
```

but to answer your question, yes, probably it's better to use ```$unq_head_array[2]```.


corporation_id: corporation
と書くか、
corporation_id: corporation.id
と書くかは流儀次第だけど、大事なのはアプリケーション全体で統一すること！


Can use arrow functions for all of these too. `assert.throws(() => library.libraryVersion = -2);`


you really hate `function()`, don't you...


Will have to turn off CreateDLNATreeFaster
if media true
Vizio will not show the folders with both enabled


Will not work for tree with true on MediaInfo = true
      From: SubJunk <notifications@github.com>
 To: UniversalMediaServer/UniversalMediaServer <UniversalMediaServer@noreply.github.com>
Cc: RandQalan <randqalan@yahoo.com>
 Sent: Monday, September 21, 2015 2:02 AM
 Subject: Re: [UniversalMediaServer] Fixed aspect ratio when transcoding non-16/9 videos on Vizio TVs (145e183)

@RandQalan I just went through and added those lines (most were already added or are the default values already), then I removed lines that weren't being used, which was most of them. Can you try this version of the file? https://raw.githubusercontent.com/UniversalMediaServer/UniversalMediaServer/ae68a78b6db29619ff3ef6dee3fae06da1d20f8a/src/main/external-resources/renderers/Vizio-SmartTV.conf@Nadahar MediaInfo = false can be faster because we do certain checks when using MediaInfo that we don't do without it—
Reply to this email directly or view it on GitHub.


なぜ？ｗ
（後で修正されてそうだからいいけど）


There seems to be some copy-paste coding going on between these classes (Box, Sphere, etc) here. Consider using simple inheritance here in order to define methods such as updateThrusters(self, values) in the base class. Will also make it easier to add new shapes in the future.


I followed the instruction, But I encounter with an error. when I run the "run_experiment.m" it showed this error:
Error in nilm_eval (line 63)
            evaluation_and_training_days{2} = evalDays(trainingRange, :);

Error in run_experiment (line 30)
        nilm_eval([experiment_folder, setup_file]);
could you please guide me what should I do?


you need it!


Yeah, it's a bit messy because this means you have to somehow break the encapsulation between the Raster and the RasterHandle so the Raster knows what is pointing at it. Not sure what the cleanest strategy is. Another option is to store the hash in a separate object from either the RasterHandle or the Raster. The RasterHandle would point to both the Raster and the corresponding hash. This solves the problem of multiple RasterHandles sharing cached hashes, but has the potential downside of the overhead of another shared pointer.


Better to take out the `_typeOf` function to separate module. It will be usable for another parts of the system (when it will be extended).


demo


Also, just for your information. Performance comparison between `_typeof` and default `typeof`:

![2015-09-21_0912](https://cloud.githubusercontent.com/assets/4028472/9986140/5446292c-6041-11e5-96e9-84cc0423106b.png)


INTEGRATION TESTING_2015-09-21 09:16:08


@alexfedoseev @dylangrafmyre Please review.


@shinnn Not yet, unfortunately. The ecosystem is slow to adopt new Node.js versions... I'll stick supporting Node 0.10 for another half year I think.


打个小广告吧，客户端配置用proxifier吧，不用SwitchyOmega


node.params expose sensitive information(significant=False job parameters).

That was why I decided to drop it.


Consider moving the functions below to a subsim_physics_helper module to help break up the size of this file


Is there a reason to not implement the `_makeParamsWithDefault` function as a part of `Validator.prototype` ?


Is it ok if grab your changes? I havnt tried the current docker file, it just added since the pr was sent to styxit branch


Do we have these thruster values defined elsewhere already? Will we have a central location in our project where anyone can access these values?


Oh, with this version or with a previous one?


logo


Are we going to be able to specify the simulator params at runtime with a config file?


https://github.com/bq/Marlin/releases/tag/1.4.2

If you have a faulty board, you should consider contact with our support service:
Support3D@bq.com


Bytes don't grow on trees, you know.


There seems to be an error in .travis.yml file. Trying to track it down.


Please see https://www.python.org/dev/peps/pep-0008/#naming-conventions for proper naming conventions


These strings should probably be declared as QString, not as QString*, and should be initialized by assigning values, not references. You can use constructor initializer lists to initialize the instance variables, for example:

    StatusIcon::StatusIcon(const QString& watchfile, const QString& watchdir):
        statusfile(watchfile),
        statusdir(watchdir),
        message(""), // might not be necessary if Qt's default ctor is sensible
        title("")
    {
        // ...


Thanks for catching this!  Although the correct fix is to make the extra uppercase 'I', not remove it.  Just pushed a fix.


And, unless you have a really good reason for this to be a pointer, this should also be a value, rather than a pointer. This is part of basic RAII.


bssrun what now?
Also hardcoded desktop and jdbc paths are far from useful.


Should I change this? I couldn't work it out from the manuals, and if we want to fix now is the time to do it.


This is a case where you will need the object to be stored as a pointer type, rather than a value (otherwise you'll have a circular reference in the construction and this might cause huge problems), BUT bare pointers are a problem. This is a perfect situation for `unique_ptr`.


And this just becomes `watcher->addPath(statusfile)` etc., because now they're values, rather than pointers to dereference.


If above break, then this Release will not be called, is it OK?


@moioo thanks!


I object to the denigration of my beautiful copy-pasted typographical quotes, but will accept the patch for users of inferior text editors. ;)


@sindresorhus Good decision. Your modules are really widely used.


line 163.


And, again, things like this should be a unique_ptr or the like. Using a unique_ptr means that it'll automatically be deleted when the owner (i.e. `this`) gets deleted. If you want multiple things to be able to own a single object (where the last one out shuts off the lights) you use shared_ptr instead. There's also no harm in using shared_ptr instead of unique_ptr, but it has a little more overhead and the compiler can't optimize it as well.


Is the second argument needed in `isValidIdentifierStart` ?


Is testing the opposite still necessary after the original take passed STC?


Hi Simon,

I think PACKAGE_VERSION provides no information whether or not things have moved ahead wrt to the last commit. I interpret the following status (see below) as follows:  I have uncommitted compiled changes in my directories that I see with the "describe" (because it is labeled as dirty) but I do not see it with PACKAGE_VERSION (is that not created when doing cmake ..?). "describe" and PACKAGE_VERSION agree on the tag and commits wrt the tag and the commit hash.

Cheers,
--U.

   [edit tests/PixTest.cc]

   marwees>git st
   # On branch master
   # Your branch is ahead of 'origin/master' by 1 commit.
   #
   # Changes not staged for commit:
   #   (use "git add <file>..." to update what will be committed)
   #   (use "git checkout -- <file>..." to discard changes in working directory)
   #
   #	modified:   ../tests/PixTest.cc
   #	modified:   ../tests/PixTestTrim.cc
   #
   # Untracked files:
   #   (use "git add <file>..." to include in what will be committed)
   #
   #	./
   no changes added to commit (use "git add" and/or "git commit -a")

   marwees>cd ../build/ && make -j4 install ; cd -
   [ 11%] Built target pxar
   [ 22%] Built target pxarana
   [ 32%] Built target pxarutil
   [ 67%] Built target pxartests
   [ 91%] Built target pxarusertests
   [ 98%] Built target pxargui
   [100%] Built target pXar
   Install the project...
   -- Install configuration: "Debug"
   -- Installing: /Users/ursl/psi46/pxar/lib/libpxar.dylib
   -- Installing: /Users/ursl/psi46/pxar/lib/libpxarutil.dylib
   -- Installing: /Users/ursl/psi46/pxar/lib/libpxarana.dylib
   -- Installing: /Users/ursl/psi46/pxar/lib/libpxartests.dylib
   -- Installing: /Users/ursl/psi46/pxar/lib/libpxarusertests.dylib
   -- Installing: /Users/ursl/psi46/pxar/bin/pXar
   -- Installing: /Users/ursl/psi46/pxar/lib/libpxargui.dylib

   marwees>../bin/pXar -d testROC
   [08:25:33.170]     INFO: *** Welcome to pxar ***
   [08:25:33.170]     INFO: reading rootlogon.C, will use gStyle settings from there
   [08:25:33.180]     INFO: pxar: reading config parameters from testROC/configParameters.dat
   [08:25:33.180]     INFO: pxar: dumping results into testROC/pxar.root logfile = testROC/pxar.log
   [08:25:33.180]     INFO: creating backup files for previous run: testROC/pxar_20150921_082225.root and testROC/pxar_20150921_082225.log
   [08:25:33.193]     INFO: *** Welcome to pxar ***
   [08:25:33.193]     INFO: *** Today: 2015/09/21
   [08:25:33.225]     INFO: *** Version: v2.6.0-4-gf8ec-dirty
   [08:25:33.225]     INFO: readRocDacs: testROC/dacParameters_C0.dat .. testROC/dacParameters_C0.dat
   [08:25:33.225]     INFO: readTbmDacs: testROC/tbmParameters_C0a.dat .. testROC/tbmParameters_C4294967295b.dat
   [08:25:33.225]     INFO: readMaskFile: testROC/defaultMaskFile.dat
   [08:25:33.226]     INFO: readTrimFile: testROC/trimParameters_C0.dat .. testROC/trimParameters_C0.dat
   [08:25:33.239]     INFO:         clk: 3
   [08:25:33.239]     INFO:         ctr: 3
   [08:25:33.239]     INFO:         sda: 18
   [08:25:33.239]     INFO:         tin: 8
   [08:25:33.239]     INFO:         level: 15
   [08:25:33.239]     INFO:         deser160phase: 4
   [08:25:33.239]    QUIET: Instanciating API for pxar v2.6.0+4~gf8ec50b


You didn't break anything, it actually had to do with the feature that I wrote I think. Adding a directory to the torrent works fine itself. The problem is that when I open the torrent in utorrent the path of the files (in the files tab) is absolute (/Volumes/External/Torrent Download Path/file.mp3) instead of the relative path (file.mp3)


The above style is unnecessary since we are creating a utility class below, `.cf`, which will do the same thing once applied to the same element.


We can fix that by not sending sensitive params to the visualizer. That seems like a sensible thing to do regardless.


Should we file a bug with jsdom?


No need repeat ourselves here; every `.columns` element already has a `height: 100px` from line 66, so line 74 and 81 are unnecessary.


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - i386-Windows-7-VisualStudio-12: OK (1872 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.svg)


So, the basic code smell that all of the comments above are to address is that bare pointers are almost always a sign of trouble.  To summarize:

* Objects that just exist on their own should be a value-type (`QString`, `ConfigFile`, etc.)
* Objects that absolutely need to be initialized after this object's parent constructors are finished should be a `unique_ptr` (`std::unique_ptr<QAction>`, etc.)
* Objects that are shared between other objects should be a `shared_ptr`.

Tip for later: The thing to watch out for with both `unique_ptr` and `shared_ptr` is they don't handle reference cycles, as they are purely refcounted (in the case of `unique_ptr` the ref count is implicitly always 1). In order to avoid reference cycles you'll instead need to do something like use a `weak_ptr` between the objects in the cycle and have a "managing" owner that holds the original `shared_ptr`, or you'll need to figure out your data model such that there's no reference cycles. But this isn't something you need to worry about in this application. :)


@RandQalan thanks, so if I remove that line does it work? MediaInfo=true is the best setting since it is the most accurate


Please squash & cherry-pick commits next time - Looks like the physics module was already refactored - hence, my initial comments on the subsimPhysics module from the older commit can be ignored...


Doesn't really matter here but a `switch` is often more readable for things like this, e.g.:

    switch (reason) {
    case QSystemTrayIcon::MiddleClick:
    case QSystemTrayIcon::Trigger:
        showMessage();
        break;
    default: // do nothing
    }


What I would suggest is have a separate test case for asserting the value of `DESCRIPTION` constant.
Something like this:
```java
@Test
public void testElfKingDescription() {
  assertEquals("This is the Elven king!", ElfKing.DESCRIPTION);
}
```
Or even better if we can move this test case in `ElfKingTest.java`


Can you please add documentation/examples of the new usage to the docstrings above?


Oh and `switch` (with no `default`) gives you more useful compiler warnings in cases that you want everything to be handled.


Why is this line needed ?


Can you check how this is working with gnumpy? There might be a necessity to create ``climin.mathadapt.isnan``.


Okay so I don't know the Qt API, but this doesn't seem like something that should be done in a timer, I don't think? What are the semantics of the file watcher? If it just is intended to dispatch a message when a file changes, then you probably just want this to cause the operation right away.


This is not a chrome app. This is a Zendesk app.

You need to run this with zat: https://developer.zendesk.com/apps/docs/agent/getting_started


good job


`modelName in _registeredModels` aren't the best way to check for index in array/object. Take a look:

![2015-09-21_0940](https://cloud.githubusercontent.com/assets/4028472/9986413/f11fbfc6-6044-11e5-8929-66e595dc694f.png)


Whether you use a `m_` prefix or not, you should be consistent. Pick a side. ;)

I'm guessing this file came from an example, since the style is completely different than your other code. This one looks like it is following RAII principles and using the right types.

But I see problems with this too, so I'll comment on them.


Won't this also match undafe indentifiers (e.g. `@b`) ?
Shouldn't it be more like `/^[$_a-zA-Z][$_a-zA-Z0-9]*$/` ?


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - i386-Windows-7-VisualStudio-12: OK (1881 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


These should be done as init params:

    ConfigFile::ConfigFile(const QString& fname, const QString& title, const QString& msg):
        m_iconfile(fname),
        m_title(title),
        m_message(msg)
    {}

Also, another thing with init lists is that you can actually have the members have the same name as the argument, which some people hate but personally I like it. Because I'm in the no-`m_` camp these days. (But consistency is the important thing there.)


Maybe (typeof format.toValue == 'function' && typeof format.toDisplay == 'function')


> does apply_profile kick off during the creation of a volume?

@wallnerryan : there was no need for ``apply_profile`` as far as EBS is concerned. i kept it around in volume creation workflow so that i can confirm that none of the other backends need it. Will follow up on that after hack day. Thanks!

> Should we keep login in create_volume?

i am sorry, do you mean caching login information in order to access storage backend? EBS does a new connection on every storage driver call, so, i did not think of caching. If ScaleIO caches (which means potentially other storage drivers could cache as well), we will have to revisit create_volume - attach_volume coupling. Thanks!


I had thought about that, it is retesting the same thing, however I'm slightly new to open-source repositories, so I'm taking little steps to ensure I follow procedures outlined in the readme. However, not new to Java, of course.


                                                                                Hi,It is working fine in my Raspberry Pi with Raspbian and also in my VPN Server with Ubuntu (I reused the script there) To be on the save side I'll update it to single space or tabs and resubmitJofre                                                                                From: Jacob SalmelaSent: Montag, 21. September 2015 01:51To: jofrep/pi-holeReply To: jofrep/pi-holeCc: Jofre PalauSubject: Re: [pi-hole] Allow external IP as an input script parameter: ./gravity.sh 123.123.123.123 (885069d)In my experience, sometimes multiple spaces in the hosts file breaks it.  It needs to be either a single space or a tab.  I'm not sure how it works on Raspbian as I haven't tried it before.  Maybe we need something more to make this pull more effective.

—Reply to this email directly or view it on GitHub.


For main function, you can extract the preparation job to a class.


Go ahead. Create an `ElfKingTest.java` and test for the constant there, that's where it belongs. Do the same for other classes as well. If you have some doubts then we can discuss on Gitter chat room.


Hey @Diullei, out of curiosity, was there a reason this `any` type assertion?


I see, I dont know what to do with Ruby and all. Is this app available anywhere to download like a chrome extension?


`number_of_words` implies that how many words are going to be returned that isn't the case, I don't think this is a good parameter name, I would suggest `word_length_range`.


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why do we need to escape characters in a string ?


This won't work right (fromJson will just see that you passed in a null pointer and assume that means you don't want the error at all, but honestly this is a bit of a smell on the part of the Qt API). This should be:

    QJsonParseError error;
    QJsonDocument loadDoc(QJsonDocument::fromJson(contents, &error));
    if (error) {
    // ...

In this case `if (error)` still works because NoError happens to be value-equivalent to 0. But that's not *necessarily* the case, so if you want to be more pedantic you'd do e.g. `if (error != QJsonParseError::NoError)`. But in general, well-defined C++ APIs allow things like this to be truthy. For example, `std::istream` will be truthy as long as the stream is valid, e.g.:

    std::istream foo;
    std::string token;
    while ((foo >> token)) {
        // do something with token
    }


spelt my name wrong D:


_that allowed_  -->  _that are allowed_


Nej


Do you expect the `get_permissions` function to be used in some other place? I think it would make sense to move it the plugin or even inline it.


Hmmm - I thought it was a goal to run the SPE testcases without the `param.xml` - that might not be possible, but at the very least this `param.xml`can be trimmed.


_extensivelly_  -->  _extensively_


General style nit: Your filename should be exactly the same as the class that's being defined within it, including capitalization. e.g. `ConfigFile` should be defined in `ConfigFile.h` and `ConfigFile.cpp`.


There are 2 functions in operate(), one is operating, one is printing message, doesn't follow the SRP.

You can seperate these 2 functions, make the operate return a message or something, and there will be printer only foucus on the print message, don't need to care about when to print.


Thanks for doing this, I have a new audio interface that I like to keep at 48K but can only do 41K when using soundflower to route to Ableton, so my in & out are not matching.  I've been meaning to submit something just like this, but you're one step ahead! :)


那你看下一个为什么又变回去了=。=


No problem. I am just glad it worked :)


Log entropy


This seems not what you want?  Recall that r0 <- SP0 takes a cycle, so you need to delay the store.


I use DR’s higher resolution (it used to be 640x400 but there were some changes recently). And still, the picture is blurry to me. While it should be as sharp as a chainsaw.


Fingers crossed for the LTC!


Hi, remove empty lines and it will be ok ;)


GroundDomainUpdate (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1340 of 1344 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.12%25-green.svg)


I let each test focus on only one aspect of RangeEvent function to make it simple and easy to cover all cases in this aspect. This helps to avoid missing corner case for me.


Why double instead of long?


I agree. Dont know why I complicated thing like this. Maybe Sunday is loop day :D


Im alive!!

Why standard.sh? Only get problems :S


Now we have for all currency crosses:

"EURGBP: requires EUR and GBP to have non-zero conversion rates. This can be caused by lack of data."


Nope, not for now at least - this was the only place where it was necessary, since the ID gets created on the server. But we could discuss proper responses in general at some point.


Oh also this line of code looks a little confusing, due to the name of `loadDoc`. I'd probably call it `configDocument` or something, and also this is one spot where I'd do a `=` assignment instead:

    QJsonDocument loadedDoc = QJsonDocument::fromJson(contents, &error);

`Foo a(b);` and `Foo a = Foo(b);` are exactly equivalent, but one is more legible than the other. :) Oh and the `=` form also avoids a syntax ambiguity which can be very confusing.


Yes I think that is a very good goal (and it does run smoothly for me).

The rationale behind this xml-file is the timestep.adaptive=false part.


we know the first character is an identifier start character, so we need to move forward the number of positions equal to the length of the char


Yes, I think we should.
On Sep 21, 2015 8:59 AM, "Mato Žgajner" <notifications@github.com> wrote:

> Nope, not for now at least - this was the only place where it was
> necessary, since the ID gets created on the server. But we could discuss
> proper responses in general at some point.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RadioStudent/picapica/commit/ae698d95939fe24e6e3b6522da235d961f7447c2#commitcomment-13335017>
> .
>


Wouldn't it be more performant to check only once for `this.options.isIdentifierStart` ?
Same for `isIdentifierContinue`.


you are right, this is a leftover, fixing it


Yes, but on the other side, it is tightly connected with other code and it will be hard to keep both codes in touch without specifying hard dependencies (one refinery version will be connected only with one refinery-forms version in Gemfile).


zhuangbi


yep


I prefer not to modify `AbstractWebServer` with those settings because it's only related to `SimpleHttpServer`. Not all implementations of  `AbstractWebServer` should care.

You can override those settings with the following code:

```java
new WebServer() {
  @Override
  protected HttpServerWrapper createHttpServer(Handler httpHandler, WebSocketHandler webSocketHandler) {
    int count = 2;
    int select = 2;
    int webSocketThreads = 1;

    return new SimpleServerWrapper(httpHandler, webSocketHandler, count, select, webSocketThreads);
  }
}.start();
```


Yo kalpesh :+1:


Durch die Änderung an der Setup.py können keine Texte mehr eingegeben werden.

http://www.opena.tv/openatv-5-1-rueckmeldungen/19133-im-einstellungsmenue-lassen-sich-keine-server-eintippen-post172282.html#post172282


this is a defensive measure in case a user defines something we do not want as an identifier. Eg the quote character `'`


I think this is correct. This loads SP0 (which contains the original value of r0) while saving OVF.


This is going to generate a lot of garbage when sorting a collection of ObjectIds


machau resume :jack_o_lantern: :high_brightness: :wink:


Yeah, this is actually fine.  It might be bed time for me.


Test comment: I've added a file named `foo.txt`.


Another test comment: few lines added here.


After the 630 version does not work the lever and button...


Since we are enclosing the string in double quotes, do we need to escape anything else than unescaped `"` ?
(Just being curious.)


Опять?! А все потому что ты его до сих пор в `.gitignore` не добавил.


there are several options:
* assign `this.options.isIdentifierStart` or `this.isValidIdentifierStart` into a field (but has the side-effect that `this.options.isIdentifierStart` will be called with the wrong `this` and we would always have to calculate `codePointAt`
* assign to a field a wrapping function (another function call should be slower than an if)
* leave it as is

WDYT?


Knall! Det virker egentlig som om algoritmen fungerer nå, så lenge vi bruker den på symetriske matriser. Vi må uansett skrive tester, så vi kan gjøre litt grundigere sjekk da.


Corrected a typo


Насколько понимаю, смысла ставить аннотацию на интрефейс нет. Аннотация уже есть на классе, реализующем интерфейс. А тут она, скорее всего, бесполезна и ничего не делает, т.к. создать реальный бин из интерфейса невозможно.


Ah cool. I'll make a git issue. I will actually need that functionality for a new project, so I'll write a test to make sure it works


`maxId`


Множественное число от person, насколько помню, это people, а не persons.


I can give you some more details tomorrow in the issue. sleep time.


oh my...


why did you choose Long over long ? Do you expect the return value to be null ?


Maybe remove the whole block altogether, this is needed only if the implementation is in `.hpp` file and needs to be instantiated explicitly (which is not your case).


Jeg tror ikke A[k][l] kan være null, for vi kjører bare loopen så lenge det finnes ikke-null verdier noe annet sted enn på diagonalen. A[k][l] er jo det største mulige ikke-diagonale elementet.


when using `find_one()` you'll never get `data is none`.


Thanks a lot! I'll test it and merge asap


Должно быть не обязательно, т.к. @ModelAttribute который неявно стоит на аргументе этого метода уже пробросит `personDto` во вью.


Thanks for that.
Chat and Bookmark menus were visible in the drop-down-menu only if there were any present. This happened when the default landing page was /apps. Since this is not the case anymore it of course makes sense to put them back in...

Unfortantly there are still some modules which need lots of ux/ui work among others two big ones mail and calendar.

I hope i will have more time soon to work further on those things...


Зачем это здесь?


I would say this is more of an optimization on `stringEscapeFn` and not in this PR. BTW, there are a few more chars than just `"`, we should, at a minimum, escape `'"\\n\t\b\f\r\v\0`


What is a message quota ?


why not access it through `field_data`?


JS uses camelCase


@tadamski to what degree does this change the DMR representation?


namespaceあるとはいえ名前が…ｗ
AdminsController でいいのに


いる？


I already added a test case while testing a fix


Можно использовать `spring:url` еще. Когда адреса станут вида `/person/{id}`, то `spring:url` их корректно обработает.


Passing a dict to the `OrderedDict()` constructor defeats its purpose. You need to pass a list of `(key, value)` tuples.


top_controller はイケてない…


Атрибут `commandName` устарел. Сейчас принято использовать `modelAttribute`, кажется.


インスタンス変数にいれる必要あるんだっけ？


Про XSS я уже писал, да? Вижу, что пока не исправлена.


how a convert method can return the same object ?


変数名から何が入っている変数なのか推測しにくい。


    session.setdefault('reg_list_columns', {})

Also, didn't we say that we wanted to include the ID of the regform in the key?


build_condition ってどういうメソッド？


@shashiranjan84 Thanks a lot! That's exactly what I needed


Usually we use `.name == 'field'` to avoid having to pass the enum to the template


adminと同様に。
moduleとclassの違いがわかってるといいんだけど。


Допущена ошибка в слове "распространение".Правильное написание : Протоколы распространения ключей. В слове распространение в конце нужно вместо буквы е написать букву я.


1) Почему название пользователя захардкожено вот так? Хотя бы вынеси в константу
2) условие можно упросить до `! "supervisor".equals(userName)` т.к. `equals()` обычно нормально работает с `null`


Зачем сообщение на русском? Лучше на английском.


Пароль тоже лучше вынести ну хотя бы константу.


これ、上でインスタンス変数@userを定義しようとすると予期せぬ事態が起こりうるからあまりよくない
current_user のまま使おう


`var $this = $(this);` and then use `$this` instead of creating a new object all the time


Используй `Collections.emptySet()` (кажется так).


you should have a look at https://github.com/gobblejs/gobble :)


This function is gonna be removed. The `extractOptionsFromModel` itself will do all the job.


view でSQL呼ばない。以下同文


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20940/testReport/) for this commit**


Если будешь в след. раз свой валидатор писать, то не надо хардкодить сообщение вот так. Нужно сообщения выносить в properties-файлы, соответствующие языку.


その発想はなかった


ロジックはhelper へ


Мне кажется, что логичнее было бы называть валидатор и его реализацию одинаковым образом. А так не сразу очевидно, что одно реализует проверку для другого.


It looks like this broke our unit tests:

https://travis-ci.org/ampedandwired/html-webpack-plugin/builds/81340488


am I the only one who thinks wrapping like this is pretty ugly compared to e.g. this?

```javascript
$('...').on(..., function() {
    ...
}).on(..., function() {
   ...
});
```


Doesn’t `sudo chown -R $(whoami):admin /usr/local` imply the first command?


Зачем `language="java"`? Никогда не ставил и все работало без него.


Super great!
ytmnd


`data.items`


Отлично!


Зачем этот пустой `div`?


The idea here was be able to perform checks before the model was saved, but now realizing that _may_ cause incorrect data in the mailers. Need to figure out how to handle the different code paths.


Мне кажется, что если `allHomo` пустой, то тело цикла просто не будет выполнено ни разу. Не уверен в необходимости if-а.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20941/testReport/) for this commit**


As you use a boolean in thé rest of thé code, you should put false as the default value.

So you could cast the parameter as booleab


`setdefault`


Do you @ja-be know why Git shows these files were deleted in diff? I've checked your branch and they are also not there (e.g. `./lib/errorHandler` is gone)


Some math might be helpful here. When $\sigma$ is known I think I agree with Josh, but with $\sigma$ unknown I can see where Ryan is coming from. This seems confusing to use selected model-based estimates of $\sigma$ (this is the quadratic in $y$ that will show up in the denominator when $\sigma$ unknown) and then use a plugin estimate of $\sigma$ based on the full model (even if you are using the LASSO CV estimate, I would say they are estimating the same target in an idealized setting). Or is it something else?


not using xhtml -> no need for the `/`


System sent app into background. We are asking system for additional time to reload rules.


Same


Thank you, sleske! I put off tidying up for too long... ;-)


sorry was stolen from fca component. will change


In order to be consistent with e.g. `Iterables#find`, and to signal the intent better, could we throw a `NoSuchElementException`instead?

Since it's a `RTE`, not marked in the signature, I consider it an implementation detail, that we should be able to change. Opinions?


centered


Can you tell us what I should think of when I read `vreg`? More expressive variable names can help people reading the code, at least it helps me.


Wow, you don't keep the unit inside the Quota object, how can you know what is the actual value of max and used ?


I am not sure what you are talking about. Could you please elaborate or upload a pic?


@DeicPro its much more convenient than adding a whole tl;dr shit to the main script

welcome back m8 xD


what are the units ?


according to java standards, static methods should be on top of the class


I would think this code belongs directly in the `relationship_value_for` method, since it's actually doing what that method is supposed to do (except for when there is a virtual value), which leads to very similar names.


by using a builder, you could avoid leaking Quota.UNLIMITED value


This is entry point of background fetch. |t called in random times during random occasions.

If you want to try it in simulator, switch to scheme AdblockPlusSafariBackground.


but then relationship_value_For is doing two things. :-\

maybe this method should be called relationship_from_association? idk


unit ?


The `serializer` param is redundant, since this method is only called on the base serializer.


a mutable object doesn't look like a great idea


Update lists every day.


static method should be on top


Nice advice. Thx!


what is this string for ?


I didnt use victara's mkbootimg, i used the one from hima which works(/ed) fine.


Good job!


Наконец-то проревьювил. Возможно, недостаточно глубоко, т.к. много кода и немного времени.


I don't remember, I started with long and switched to double for some reason....

I suspect 2 reasons:

1.  Because double support is more mature and less chance of bugs if we use double
2.  The calculation I was using results in doubles and there is less chance of error in calculation.

Neither reason is really that good I suppose.  I will try out long and see if it works.


what is this String for ?


Potential NPE as ```lastAnalysisDate()``` may have a different result than previous call.


Background fetches are allowed in configuration. You should see in your iPhone setting, that app is requesting background running.


Nope, there's no need for task runners / build tools when you can simply use Makefiles. Build tools slow down compilation and are too fallible. See also #172 ;)


it didn't used to be.

removing. standby


I think that those parameters should come as a variable (configuration or user linked) this way you could je more flexible to add new dashboards


char


See this [gist] (https://gist.github.com/derDavidT/13848c2a1752a4163644).
TLDR: it shows the same behaviour as before.


Isn't this a Singleton ?


Usage:```
./configure --enable-static --disable-shared --enable-linear=static --enable-dejitter=static ... --disable-arctic2 --disable-corgi ...```


yea abolish line 19 on your most recent and should work fine :)


@delannoyk I did not make them failable, they were already failable. I just changed them to non-failable because they were not failing :)
After that i saw that SCNetworkCreateWith* return an optional so i thought i was a bit jumping to conclusions and i reverted my change and made them failable again.
I did not have time to look into it further.


No, because this action can have three case :
* default = false : get the cotent which aren't pusblised
* default = true : get the cotent which are published
* default = null : get the content without checking whether they are published or not


Tbh, i dont know why you changed the mkbootimg since the previous one (kanged from hima) works fine and has the same format as ours.


Filterlists are asynchronously downloaded by System, application does not need to run in foreground.


unit ?


Сейчас понял что эти комменты правильнее было бы вынести в отдельный коммит. Если уж совсем перфекционизмом заниматься.


This one :lol:


можно jsdoc использовать для этого - `@todo Something`


Is there a point having this concurrently-used object mutable ?


Same remark here (I gonna be very annoying, I can feel it), but now that CONTRIBUTING has been merged into `meta`, you're supposed to commit into a dedicated branch :). It's also easier for me to write the monthly recap with this workflow (I just have to have a look to merged PR).

If you're not confortable with this workflow (for instance because the dev is still in early stage), maybe you should consider adding your own CONTRIBUTING file at the root of this repo. Thus, it would be clear you're not following the Renaissance workflow yet.


you should use a constructor for injected dependencies


@mzgol Could you publish this as a new Karma version?


This delegate method returns, when NSURLSessionDownloadTask successfully finished its task. It means, that there weren't any connection or system errors, however server might not returned right response (404, 500, etc).


A vim command to covert to local namespace.

        %s/^\(.\)\(.*\) {/:local(\1\2) {


test names are ... not very helpful


Hi Sergey,

Understood, and thanks for the head-up.

If you don't mind sending a PR anyway, I'll merge it onto a feature branch and have a look. I'm trying to add a bunch of unit tests to put some validation around the lexer and parser, so I'll add some around the work you've done as well.

Cheers,

Mike
________________________________
From: sergey-raevskiy [notifications@github.com]
Sent: 18 September 2015 15:19
To: sergey-raevskiy/MofParser
Cc: Mike Clayton
Subject: Re: [MofParser] Class parsing. (57927b9)

My code is essentially a prototype and might break some behavior. There also some hacks and dirty places. Of course, I can send a pull request to you if you are really interested.

—
Reply to this email directly or view it on GitHub<https://github.com/sergey-raevskiy/MofParser/commit/57927b9a728414a7c4a9da1e3d3ad6c4870ddcbb#commitcomment-13312036>.


you should inject dependencies by constructor


Ap**PAIR**.in-**programming** :checkered_flag:


URL of filterlists.


you could extract each case in a submethod


unit for size ?


1) _typeOf and _makeParamsWithDefault are utils. I can move them to utils.js. But It will be first step for making my bicycle library. It is compromise for don't use third-party libraries and don't make bicycle.
2) I know about instanceof, but this function is more humanfriendly.


The ZMQ pipeline is not even implemented (and then it's optional). But we require ZMQ as must-have requirement?


See comment above


fafdsfa


NSURLSession is used for downloading filterlists. It executes downloads in background (used background configuration) separately from application process.


gobble is not a task runner, so you can keep your Makefile ;)
it's a build tool, and I found it really nice to use, after years avoiding grunt and the likes.


Why did you make the tolerance absolute? So `103` for example isn't `100`-ish anymore? :(


Moved downloaded filterlist from temporal to shared folder. Then we can commit transaction.


Update time is determined as minimum from last successful update time of both filterlists.


А смысл таких странных названий? Можно же проще: `name`, `age`.


@OskarStark even though the bundle provides a Sonata integration it does not have to be Sonata dependent.


dårlig as


Thank you very much


:+1:

IMO this could go in either `astroquery` directly or in `astroplan`.

You're saying `astroquery` and `wcsaxes` would become required dependencies.
Why not simply put the imports in the plotting function and keep them optional dependencies?

IMO it's good that a user can compute a rise time without having to have matplotlib installed and it should stay that way, i.e. matplotlib, astroquery, wcsaxes should be **optional** dependencies.


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1881 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Запускать надо тот тип расчета, который пользователь выбрал. И результаты получать в какую-то переменную, с помощью которой ты будешь выводить разметку.


@blackCmd did you find the solution?


Houh? Do we have to check the command line output for this? Shouldn't the apt module return "ok" if nothing new was installed?


target 拼錯字了...XD


config('app.locale')


Is possible to send us header with filterlist version. Or we can use special header:

http://stackoverflow.com/questions/5081397/understand-if-modified-since-http-header


Because it meant that comparison with 0 had no tolerance. I'd like to
implement a hybrid approach, but I just implemented the quickest fix at the
time.

On Mon, 21 Sep 2015 08:41 Sebastian Noack <notifications@github.com> wrote:

> Why did you make the tolerance absolute? So 103 for example isn't 100-ish
> anymore? :(
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/judy2k/ish/commit/42fc0042cb9a0c9fcd5173f6bd40e3526858f48b#commitcomment-13335557>
> .
>


@pbauer is this travis failure still the same like already discussed or did my cherry-pick break it?
https://travis-ci.org/plone/plone.app.contenttypes/builds/81254482


should be constructor injected


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 52](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=179&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


what if anything change this value under class usage ?


tabs are evil and should be replaced by spaces


Hi Jeffrey,

I'm not sure, I may have seen it before but my core builds ok for me now. Do you have Java 7 installed?
I have Java 8.

Thanks,
Stas.


Can you push the output feed through https://validator.w3.org/feed/ and report the results?


從需求面來看，我會比較建議 class 跟 function 的定義， 購物車.結帳() 會好一點。


I don't understand these images.  They use a completely different code example than you listed above.

(I didn't make this comment before because the images didn't display.)


Объявление переменных в начале функции


Давай все-таки в алфавитном порядке все


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 52](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=179&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Compilation error: Xbim.Geometry.Engine\Xbim.Geometry.Engine.vcxproj (new) Build time: 00:01:46


@localheinz this you meant in #14 ?


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


this looks like a bad idea : computing the entry can be long so you can have lot of parallel computations launched simultaneously by impatient client. The value should be ok, but it can load the server a lot


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1880 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 53](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=180&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Maybe add migration/task to update all old types to new type?


А в чем разница?


думаю, проще сделать какое-нибудь сокращение:
```
var params = creditObject.initialParameters;
```
и потом использовать в виде `params.amount`


Hi Laura,
I'm sorry for this stupid mistakes :)About the photos I made a pull request for them in your repo, after merging them I'll correct the 'url'. If this is not the way to do this, please I will need your help :)
Have a wonderful day :)Boryana

     On Saturday, September 19, 2015 6:57 PM, Laura <notifications@github.com> wrote:

 please change to Oscar's as the sign ` starts a code block in Markdown. :)—
Reply to this email directly or view it on GitHub.


I  think Noop is better suited


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (1875 of 1882 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


what is "patch" ?


UnlimitedMaxQuotaManager


lgtm


SLF4J should not be used here, but SQ API Logger


Single space indent? ;)

Please use more lines like
```
	nvvs? (
		>=x11-drivers/nvidia-drivers-352.39[uvm]
		<x11-drivers/nvidia-drivers-355.00[uvm]
	)
```


> The playlist wasn't being cleared previously, which was causing some strange behaviour.

@SyncedSynapse This fix introduces yet another bug. Take a look at #112.


OK..works now after use Java 7. Thanks!


why using setters instead of constructor parameters ?


Комментарии лучше на английском.


Hi Stephane,

thanks for the remarks and the appreciation.

For your point 1). You're right, but in passed pawns evaluation we already check whether we can block the path to queening square, so I thought that this part is maybe not relevant.

For point 2). Good idea, I will do that way.


Yes! Not only name and/or image ID but also labels as they will be useful to discover the right ACI (i.e. the version label).


Why?


Предпочтительнее использовать не чистый SQL, а XML элементы самого Liquibase (в данном случае http://www.liquibase.org/documentation/changes/create_table.html). Тогда мы будем менее зависимы от реальной БД.


test


I would rather have a tryAddition method that add and check


Нет перевода строки в конце файла. Желательно настроить IDE, чтобы она сама добавляла его.


Hmmm, we could move that whole if block into a generic "set_failure_message" and then do a

```Ruby
matching_smell_types? && matching_smell_details?
````

at the end of this method. This would be a slight duplication but I think it would be justified.

WDYT?


2 reasons :
1. DocunentDatabase initialization order issue. i.e. : 'Documents' for example doesn't available to AddAlert). Instead of changing DocumentDatabase's ctor I decided to pass the info like this.
2. When reaching DeleteRemoveIndexes - we do not hold the exception anymore, so in this way I can pass the data / reason.


Сейчас путь к api не соответствует адресу шлюза. Поэтому тут или настроить, или переехать на ip.ip.ip.ip/api.htm, что будет логичнее копировать родное api.

А вот с данными, имхо, на входе контролировать проще, чем в драйвере, тем более что api - это интерфейс и к приложениям, которые мы не можем контролировать вообще никак. Но пока это просто мысли по возможным доработкам.


Excellent point. Please see my comment above.


Has this been in the original code? I can't spot it there.
IMHO this will disable importing from a  zip-file, e.g. a zipped egg.


can u give us an example to use model to test an image? Thanks  a lot :)


Здесь подключается `db.changelog-0.1.0.xml`, а файл выше называется `db.changelog-0.7.2.xml` -- оно вообще работает?!


Should I parse IndexDefinitions/indexes.txt for the name here?


`keysym` is set (function `luaA_keystore`) via

    key->keysym = xkb_keysym_from_name(str, 0);

and `luaA_key_get_keysym` does the "inverse operation" via

    xkb_state_key_get_utf8(globalconf.xkb_state, k->keysym, buf, countof(buf));

That seems fishy to me. Google suggests that `xkb_keysym_get_name` exists (http://xkbcommon.org/doc/current/group__keysyms.html#ga63456bb7e56a2e7a3e02de86b19900ef).

Feel free to ignore this or do something else. I never looked closely into this XKB API.


工程不是上传了么……
https://github.com/piaopolar/iOS_Samples/blob/master/iOS_Samples.xcodeproj/project.pbxproj
3年前 Xcode3 时代的东西了

2015-09-17 10:59 GMT+08:00 ericzhou2008 <notifications@github.com>:

> 不知道上传工程啊，真是醉了
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/piaopolar/iOS_Samples/commit/eebdee731ac4def6ee98374a66d49bf1775c2247#commitcomment-13277857>
> .
>


since we intend to backport that to tex, we need to wrap it in..

```ruby
unless a["multi_domain_support"].has_key?

```


Почему такой странный id? Почему автор не указан нормально?


same here


Скорее всего, поля name и age нужно объявлять как `NOT NULL`.


Would it be better to write out `content_id` here for consistency?


Вместо полного пути используйте атрибут `relativeToChangelogFile="true"`


Yes, definitively worth to do this. At first I forgot about old types, thats why I had to do this to get results quickly visible. I'll make a rake task :+1:


@iNPUTmice Did you mean to revert 6f458deb222852f7d61fc2a69c9523c657371f9d?


it just went massive diet xD
@DeicPro should check which got left out and tell me what i should put back....
thanks :D


perhaps check here if keystone is nonempty (I'm not sure if we can guarantee that the keystone proposal exists and is not deactivated at this point in time..)


** facepalm ** -> good catch, fixed!


Там есть таки флаг регистронезависимости, регистрозависимое я делать бы не стал =)
В одном из предыдущих вариантов документации это было, но в текущей упоминания текстовых команд я снёс, а история потерялась с переименованием.


While the error message is obvious for someone who knows how things work, I guess we should make it more obvious to the casual user, like for example:

"Multi domain support requires enabling Keystone V3 API in the keystone proposal first."

or something like that.


got a typo here


Hmm .. I'm not entirely sure what you're thinking of, so I'd have to see the result.


It's a tough question where to draw the line when it comes to adding helper functions to `astroplan` or examples to the docs.
Maybe, at least for now, have a "recipes" or "snippets" section in the docs, like e.g. http://flask.pocoo.org/snippets/ ?
If you can put that functionality in re-usable utility functions or classes, you could also introduce an `astroplan.recipes` package, to make it clear that this is not core functionality and leave the possibility open to easily split it off in a separate repo later.

But for now where there is not much functionality, a separate repo is too much overhead IMO.


I don't I follow.
Wouldn't

```Ruby
expect('def simple(arga=local) arga.to_s end').not_to reek_of(:UtilityFunction)
```

trigger this? How are are smell_details involved here?


I'm confused about sending spead for each beam. How do I differentiate that packet is for this beam? Is different name enough? We should discuss.


例子11：
在例10 中读队列任务具有最高优先级，所以队列不会拥有一个以上的数据单元。这是因为一旦数据被写队列任务写进队列，读队列任务立即抢占写队列任务，把刚写入的数据单元读走。在例11 中，写队列任务具有最高优先级，所以队列正常情况下一直是处于满状态。这是因为一旦读队列任务从队列中读走一个数据单元，某个写队列任务就会立即抢占读队列任务，把刚刚读走的位置重新写入，之后便又转入阻塞态以等待队列空间有效。

写队列任务的实现：
写队列任务指定了100 毫秒的阻塞超时时间，以便在队列满时转入阻塞态以等待队列空间有效。进入阻塞态后，一旦队列空间有效，或是等待超过了100 毫秒队列空间尚无效，其将解除阻塞。在本例中，将永远不会出现100 毫秒超时的情况，因为读队列任务在不停地从队列中读出数据从而腾出队列数据空间。

读队列任务的实现：
读队列任务的优先级最低，所以只有在所有写队列任务都进入阻塞态后才有机会得到执行。而写队列任务只会在队列满时才会进入阻塞态，所以读队列任务得到执行时队列已满。因此读队列任务只管不停地读取数据，不必设定超时时间。

主函数main()与上一例比起来只作了微小的改动。创建的队列数可以保存三个xData 类型的数据单元，并且交换了写队列任务与读队列任务的优先级


Я бы даже сказал, что любить нужно JavaScript и в нужный момент уметь использовать подходящий инструмент ^_^


Следствие копипаста из jalusi-plugin'a. Впрочем, как и создание экземпляра плагина NooLite.
Раз можно снести, снесу к следующему коммиту.


Could this be made generic so that it would work for a list of Ints as well?


thanks :smile: aapka bhi :+1:


You're right, sorry. I was assuming there were always details present.


sets and maps infi god hai :smile:


I think on KAT7 the SPEAD identifier indicated the beam.

On 21 September 2015 at 10:02, Monika Obrocka <notifications@github.com>
wrote:

> I'm confused about sending spead for each beam. How do I differentiate
> that packet is for this beam? Is different name enough? We should discuss.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ska-sa/corr2/commit/2e73de07fc9274fae31ec41c5f6d090a1a154d1d#commitcomment-13335918>
> .
>


Нет большого смысла держать код закомментированным -- если что он сохранится в git-е. Поэтому я советую его просто удалять.


Почему/зачем это понадобилось делать?


brightness - int?, проверенный выше на null. Но это не сделало его int'oм.
Или здесь есть способ лучше?


Отсутствует модификатор доступа.


please pr with typo fix


Не жадничай на переводы строк. Они улучшают читабельность.


Почему мастер? Еще будет slave? :)


You're right. Fixing.


Excellent idea, can definitely see it being used for ids. Will improve


Right. But now I don't understand this command in respect to the README. I was thinking if was implementing the behavior explained there:
```
acbuild add-image add.aci -in=in.aci -out=out.aci add contents of image add.aci to image in.aci and outputs the value to out.aci
```

Shouldn't be clear to take an input aci and adds to it some dependencies (at the same level) generating a new ACI like in the other commands (-in option) (like .`acb rm`)? This will be also useful for inplace updates.


The ones I use (debian-based & opensuse) use that location to store the ldap configuration used by pam.  OpenSuSE is using sssd and debian uses libpam-ldapd as a newer alternative.


Did this trigger a warning/error?


Yes, good idea, I will do it later today.


Tiny nit: This appears to remove one space from the indentation.  I'd rather it did not.


@kahlil Nice!! Did not know about this.
Thought I was being all clever by adding the pathHelper code ... stolen from ember-cli. Guess they don't know about user-home either :-P


I'd like to hear the reasoning behind that.


Рекоммендую использовать `insert` из liquibase-а.


Please never break packages link...
I revert change to packages.html as i don't know how to make /packages/ working


chasch das rückgängig mache?


So it looks like you were not able to push this to npm either. Any more insight into this?


Хорошо, что не забываешь про откаты, но по возможности используй встроенные возможности самого liquibase.


Yep will do :)


I don't have strong opinions on this. But if the name will be `acb` than the README should be changed. Also other commands changed their names/options or are not implemented so this should be noted somewhere.


mer hend für view ame es aug gna und für validate en hammer


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20942/testReport/) for this commit**


@moozzyk This is pretty annoying. Do you know why this keeps happening?


Обычно лучше брать что-нибудь стабильное, а не release candidate/alpha/beta и прочие SNAPSHOT-ы. Со стабильными версиями обычно меньше проблем.


d


Зачем этот файл здесь? Надо удалить и добавить в .gitignore


Что-то с форматированием..


No problem, I deleted the test. Anyway, it performed badly on local tests 😞


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 602](http://build.prxm.it:8811/viewLog.html?buildId=4028&buildTypeId=Jarvis_DocumentStore_CI) is now running


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 602](http://build.prxm.it:8811/viewLog.html?buildId=4028&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:08


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 603](http://build.prxm.it:8811/viewLog.html?buildId=4029&buildTypeId=Jarvis_DocumentStore_CI) is now running


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 604](http://build.prxm.it:8811/viewLog.html?buildId=4030&buildTypeId=Jarvis_DocumentStore_CI) is now running


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 603](http://build.prxm.it:8811/viewLog.html?buildId=4029&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:04


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 604](http://build.prxm.it:8811/viewLog.html?buildId=4030&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:02


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 605](http://build.prxm.it:8811/viewLog.html?buildId=4031&buildTypeId=Jarvis_DocumentStore_CI) is now running


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 605](http://build.prxm.it:8811/viewLog.html?buildId=4031&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:03


Why did you remove the reloading sound code? The GTA one is disabled due to setWorldSoundEnabled (container 5, which holds weapon sounds) having been set to false. Please add it back it.

Also, triggerEvent for onRollMessageStart must be localPlayer, not root, else every player will get that message.


@karussell may be I'm missing something here, but since we're retrieving from a ```Map```, the returned values could be null?
(same goes for checks below at ```ref```)


No worries. I remember that decision (using apps and removing from the menu). was just trying to test something and discovered it needed a bit of work. Just making it usable again. Bookmarks are still ok to leave off the menu until we have some.


Commit message: s/save the exception/save the screenshot/


Не уверен, что нужно. Насколько помню, в `WebMvcConfigurerAdapter` реализации всех методов пустые.


Good Work my Friend! Some unit test would have saved us some weeks, however!


Chasch nbsp entferne? So gits 2 spaces mit em linebreak. De html minifier bhaltet immer 1 whitespace automatisch, damits i jedem fall na guet usgseht (whitespace isch ja be inline und inline-block elements wichtig)


`You should have overwritten it` or `You should overwrite it` ? :+1:


@hpatoio

Looks good to me, although I'd probably use a different order. Doesn't make a difference to Travis, but to the reader, it will. See this, for example: https://github.com/refinery29/php-cs-fixer-config/blob/master/.travis.yml.


Да, оставил именно по незнанию - вдруг что то там есть.


Обновить и api. Насчёт фильтрации числовых команд можно подумать, с текстовыми - без вариантов.
Плюс, новые команды требуют и нового железа, по крайней мере с нашим api мне пока не удалось взять новую 23-ю команду, хотя оно их и не фильтрует, и что-то отправляет.
Некоторые команды могут иметь расширение разным количеством байт, например, двумя. Тогда, как вариант, можно разрешить все режимы аргументов для всех команд.


Не помню, чтобы у меня была необходимость устанавливать название и время жизни cookie. А тебе оно зачем? Дефолтные настройки чем-то не устроили?


@zhanhb proxifier效率如何？以前用过COW自动分流，虽然智能，但是效率低了些。


Ты добавил переводы строк до и после   и смысл его теперь потерялся. Зачем тогда его использовать?


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 606](http://build.prxm.it:8811/viewLog.html?buildId=4032&buildTypeId=Jarvis_DocumentStore_CI) is now running


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 606](http://build.prxm.it:8811/viewLog.html?buildId=4032&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:06


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 607](http://build.prxm.it:8811/viewLog.html?buildId=4033&buildTypeId=Jarvis_DocumentStore_CI) is now running


Figured it out. Was calling the command without a location.
npm publish . --public worked. Was just doing npm publish --public.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 607](http://build.prxm.it:8811/viewLog.html?buildId=4033&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:05


I think this is OK. Please go ahead.


thx!


Useless.


效率这一块我说不来，我用起来没感觉到慢，但是功能挺强大的，拦截请求也比较底层。


You are useless


Right the spec isn't clear about this. Actually short hashes are used everywhere inside rkt (the store key and consequently the generated pod manifest). Also the spec exposes the ShortHash function (https://github.com/appc/spec/blob/master/schema/types/hash.go#L113-L118) used by rkt/fetch.go

@jonboulle any though on this? Thanks!


These are not some changes. Have you tried them on your machine. Even for mobile? You should have noticed that looks weird on smaller screens. I will fix all those things that can be done better.


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (807 of 807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.55%25-green.svg)


@djh- You can add quotes if you want to use a title that uses special characters, e.g.: "Parsing Text: Clean Up".


Would you please help me know how to run application when couchbase removed. Should I install it manually?


Please remove those "Internal Error: Content can't be null". They add no value whatsoever in cases like this. We really ought to clean that up everywhere.


there is always the fixWayName method in-between so we should be safe (?)


Honestly not sure what can be done about this one.

The exact same method to iterate is used everywhere. While I understand the concept of what may be happening (list is updated in another thread while this is being processed). I don't understand why this doesn't happen anywhere else the exact same method is used.

Now, there's a couple of things I could try here. From what I can see this same iterator is used EVERYWHERE.. However, not in Map.cpp. So it could be something to do with the multiple map threads.

I could move the code to Player Update(). However, in my mind even if Player functions exist in one thread, the maps are still busily being updated around it. So, not convinced it will solve the problem.

Some input from those with an understanding of the threading used in TC would be helpful here.


To reduce confusion, this should also support `options.includeSubDomains`


btw. what about this? While your patch looks correct, I don't know this API, and would like to have a test case which would indicate that this works as intended.


margin ="auto"


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 53](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=180&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:33:54


Оказывается, IDE не создает своего .gitignore, а работает как-то по-своему. Создал свой .gitignore, закоммитил.


> As for caching, I think its more intuitive that the same result should be returned.

Oh, sorry, that's not what I meant. Sure it is the expected result, my question was whether the file will be opened two times or will the result be cached and the file be opened one time? I'm not suggesting which one is better, I'm just not sure which one was your intention.


Chasch das na uf guest-view-expense umbenenne?


GuestViewExpenseController


Good luck with this. I'm a fan of LMR improvements - I believe a lot of space for improvements here.


Дефолтное значение устанавливает время жизни куки на сессию, верно?


I see, and there you go: #8


Тогда как будет множественное число от Human?


http://puu.sh/kiS1l.txt
Stryker the fucker added a fucking bug on purpose


Please a test case for that.


Mer hettet susch moment.js als dependency. Das macht genau so datumsberechnige und isch mega guet testet


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20944/testReport/) for this commit**


Gseht guet us :+1:


В модели, очевидно, типа Map<String, Object>?
Тогда двойного добавления не будет.
Тем не менее, уберу лишний код.


I suggest this instead:

```
                if ((ctx.flags & DDB_TF_CONTEXT_HAS_INDEX) && ctx.iter == PL_MAIN) {
                    listview->tf_redraw_track_idx = ctx.idx;
                }
                else {
                    listview->tf_redraw_track_idx = deadbeef->plt_get_item_idx (ctx.plt, it, ctx.iter);
                }
```


sdfsdf


![persamaan kuadrat 2](https://cloud.githubusercontent.com/assets/14210144/9987880/ce68c8fc-6075-11e5-8386-9cf9191332f7.jpeg)


Извини, я не понял вопроса. Можешь, пожалуйста, перефразировать?


Fixed by adding plone.app.blob to checkouts


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20945/testReport/) for this commit**


Kein Grund sich zu entschuldigen. :)
Ich sehe das so, dass Open Source ja erst dadurch lebt, dass sich Leute beteiligen.

Und die Erklärung mit dem reverse?caseA:caseB bei dem anderen Commit hat ja auch gestimmt.
Wobei ich auch seeebiii verstehen kann, dass er dachte das wäre ein Fehler.
Der Fehler eine Zuweisung statt einem Vergleich zu machen ist immerhin sehr beliebt :)

Die Bendiness klingt interessant.  Wenn ich das richtig verstehe stellt man dort ja einfach nur die tatsächliche Distanz einer Strecke der Luftlinie von Start und Endpunkt gegenüber. Das sollte auf jeden Fall schnell zu berechnen sein. Wobei man dann halt leider keine Gewichtung der Kurvenarten durchführen kann. Aber das kann man auf jeden Fall mal in der Hinterhand behalten.

Ich werde innerhalb der nächsten Tage mal https://github.com/adamfranco/curvature auf meinem PC zum Laufen bekommen. Um direkt sehen zu können wie lange die Ausführung dauert.


This is where s3.scheduler_task_id is defined:
https://github.com/flavour/eden/blob/master/models/tasks.py#L665

Perhaps this line needs moving to the top of the file?
It shouldn't make any difference, but perhaps it does.


Don't we allow to override the settings by the users?


:smile:


nice to me


blank line on the end.


Хм.. а если неаутентифицированный юзверь полезет?...
Ты имеешь в виду, что это нужно запретить еще при настройке Spring Security?


I don't actually think this type definition is needles. The commit that introduced it is this one (which has a pick equivalent in this series): https://github.com/thomassa/xen-api/commit/4061224cb16ce9c063437f62f6e6478109ba358f.

It is actually adding a constraint the polymorphic variant that can come in. If we rely on the type system then this will be what was previously in the the mli before the mentioned commit:
```
            [< `Halted
-            | `Migrating
-            | `Paused
-            | `Running
-            | `ShuttingDown
-            | `Suspended
-            > `Halted `Paused `Running `Suspended ]
```
This is due to the function [`Record_util.power_to_string`](https://github.com/xapi-project/xen-api/blob/master/ocaml/client_records/record_util.ml#L20-L27) which handles these extra variants that are no longer in the datamodel.


huh, interesting. I guess that is only required if you have to use the `--public` flag...


> dann halt leider keine Gewichtung der Kurvenarten durchführen kann.

ja, genau. ist evtl. mit einem extra parameter emulierbar aber genau wird das nicht sein, sollte aber gefühlt ausreichend sein ;)

> Um direkt sehen zu können wie lange die Ausführung dauert

Interessiert mich auch, gerade für längere Strecke geht es ja dann in die Millionen Male ... :)


OK, leave it there. It's fine because it's a method of django-template-the-library, not django-template-the-default-template-backend. So it doesn't imply that third-party backends should provide this method.


by the by, I did not try to publish. don't know if I even could.


c:url тоже вроде корректно обрабатывает...


Is there any difference between those two? I guess one should apply contact filter for provided term. You may consider getting rid of if altogether by implementing PassAlllContactRecordFilter internally and having two operations one with searchTerm and the other without. The first one would use the Soundex filter and the latter would use the new one.


typo (ParMETIS).


fine == file
nasty typos :/


so generous... I contributed other projects and never anybody add me to collaborators list. Thanks!


Also this commit is not in the original patch series in either of the pull requests that this pull request is a backport for:
* https://github.com/xapi-project/xen-api/pull/2272
* https://github.com/xapi-project/xen-api/pull/2400


This [commit](https://github.com/StefanoRaggi/Lean/commit/4799b363a3857df9f93ac5dcfe52786971609081) should fix the bug.


wow


i didn't do that because $event is still undefined.


Looks good! See my comment on the repository class.


Missing end of line.


amazing


Удалить (изменить на > и  <) скобки будет достаточно?
XSS чем-то напоминает SQL-инъекцию, только для веб-кода, ага?


sai rồi


The backport of this commit looks good. :+1:


Remove this as all commented out?


What are the changes you would apply? MediaInfo=false?


anyway Thanks


The test shows a positive score so there some merits to the patch.
I think the reason for the way off value for depth 3 is that this value is used for two cases.
The normal razoring at line 684 and in the depth = 1 special case on line 680. There are quit different.

So you could try to use the currently unused value razor_margin[0] for the latter case and retune.

if (     depth <= ONE_PLY
   && eval + razor_margin[0] <= alpha)
             return qsearch<NonPV, false>(pos, ss, alpha, beta, DEPTH_ZERO);

I would then start with this values {554, 570, 603, 730} for tuning.


Thanks Sharat, it looks good to me.


Passed super fast. I hope it scales into LTC as well. Good luck!


New translation: 'Impossible de trouver %{resource}. Certaines options de recherche sont manquantes, veuillez consulter --help.'
Comment: merge DS and new US translations


Maybe `ghc` alone can be made visible in `all-packages.nix`? That way at least `nix-env -i ghc` would work.


Все, вкурил тему... вся сила в JSTL


Спасибо за ревью ;)


谢谢


Are these needed by libcontainer?


What's the purpose of the above check? (a comment will be useful)


ignored error?


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8319/testReport/) for this commit**


LGTM


swifty media selector changes


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1875 of 1882 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


why this value?


> XSS чем-то напоминает SQL-инъекцию, только для веб-кода, ага?

Да, тут просто JavaScript код внедряют.

>Все, вкурил тему... вся сила в JSTL

В этом конкретном случае нужно использовать `<c:out>`, да.


Да, защита на уровне URL-ов настраивает в одном месте -- в конфиге Spring Security.


update


Instead of adding binary data shouldn't these files be generated?


...пока URL-ы обычные, то да...


Humans?


Yes, that would be nice.


**Sorry**, this was an unintended breaking change

Please use override


>В модели, очевидно, типа Map<String, Object>?
>Тогда двойного добавления не будет.

Не понял вопроса. Перефразируй.


Won't this have to all be done client-side?
So show onChange?


This is only a flow for login. More to come for trading Use Case


Nice, thanks!


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8320/testReport/) for this commit**


We don't guarantee, but require POSIX shell. But you're right, I didn't see this is hub-specific.


update devices doesnt tell me much, i have to open all these to see what happened here


we talked about that in another ticket ;-)


Which you are doing already here.
So it's just the default that you're wanting to be able to control?
I'd put it into the same script I think as this change I think


@tagliala http://semver.org/ states (and even if you're not adhering strictly to semver, this is still sound advice):
> What do I do if I accidentally release a backwards incompatible change as a minor version?

> As soon as you realize that you've broken the Semantic Versioning spec, fix the problem and release a new minor version that corrects the problem and restores backwards compatibility. Even under this circumstance, it is unacceptable to modify versioned releases. If it's appropriate, document the offending version and inform your users of the problem so that they are aware of the offending version.


Скорее всего да. Предлагаю заглянуть в код, посмотреть и рассказать мне :)


Hi Gabriele! Thanks for adding my contribution! However, sorry to be so picky, but my name is Jaime, not Jamie (notice the i before the m). It's Spanish for James. Thank you again, and sorry for the inconvenience!


This only serves to make tripmines do less damage when destroyed by slot 0. Perhaps this is just bad coding that wasn't properly tested. In any case, we will leave it out for now...


The backport of this commit looks good :+1:


Wonderful, thank you! Does `newPath` need to be on the heap though? Couldn't we just allocate a local `char[19 + strlen(param->value)]`?


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 608](http://build.prxm.it:8811/viewLog.html?buildId=4035&buildTypeId=Jarvis_DocumentStore_CI) is now running


commiting files to github


@hvelarde Sorry for that, indeed I should have done a PR !


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20946/testReport/) for this commit**


that's it


This looks weird with the developer preview screen. Is there no other place this could be added?


Yeah, much better. Sorry about that.


Some of these might be causing the error, or at least making it tougher to debug.

The `before` block is creating 4 users:

- 2 users are created by `create(:user)` calls
- 2 users are created by `create(:user_with_post_and_comment)` calls

The `post` local variables are misleading, the object returned by `create(:user_with...)` is a user object.


@thet this is still the same issue as discussed in https://github.com/plone/plone.app.contenttypes/issues/257


Once the `before` block is changed to create 2 users, then `.first(2)` ought not to be needed.


Tại sao lại allow index?


simple and cool fix


Does it have to be this grey? It looks muddy to me. Cant we just leave it white? It has a border anyway, it doesn't need a color.


` ` это специальный пробел который запрещает перенос в этом месте. Т.е. если есть "test1 test2" и места для отображения их в одну строчку не хватает, то браузер переносит по пробелу между словами. Но если ты напишешь "test1 test2" то при переносе он их либо вместе перенесет, как единое целое, либо просто появится скроллбар, потому что они не влезают, а переносить нельзя.

Теперь к твоему коду: если ты хотел сделать, чтобы "EN | RU" были всегда вместе и для этого добавил   то это, скорее всего, не сработает, ведь вокруг   есть переводы строк, которые как обычные пробелы. Попробуй это проверить, может я не прав. Ну или, если у тебя не было такой идеи, так может и убрать тогда  ?


@slobo Sorry for the release branch confusion, we were mid rollout when you noticed this issue so the release branch was not yet updated (it is now). For the issue can you see if you see the same problem with the previous agent version and report the results?


the method `tupleExtractor` is now unused, should be removed


Is this colour necessary? The solo change impies the element is clickable, which it isn't.


Making new Comment on issue for Testing


Значение по умолчанию: private Integer cookieMaxAge = null;
проверил - действует на сессию.


I'm bad, sorry! :) +2


yes, i used caffe-0.9999 instead of caffe-0.999.
and some configure..

2015-09-21 16:45 GMT+09:00 Elpidam <notifications@github.com>:

> @blackCmd <https://github.com/blackCmd> did you find the solution?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rbgirshick/caffe/commit/c28823f7829b91c5dd56060579dda2cecbc22d7b#commitcomment-13335622>
> .
>


I am not sure what I was doing incorrectly previously, but it is working now for all 3 file types. Thank you very much for your help Abhinav, it is greatly appreciated. I will be sure to recommend your videos to any of my classmates trying to learn shiny.


Т.е. кука бесконечная или что?


hm O_o


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20948/testReport/) for this commit**


Is the `castAwayConst()` call actually necessary? It seems like the GU_ConstDetailHandle (p.geometry) itself has a readLock() method? The docs also state that readLock() needs to be followed by an unlock() call - is there any reason we don't have one? However we do that it'd be nice to know it was robust to exceptions and early returns.


10ms延时，用来延时消除按键抖动。


Я бы не стал знаки пунктуации выность в переводы. Впрочем, может я и не прав.


Because intelmq cant work without the correct import of pyzmq.
https://github.com/certtools/intelmq/blob/master/intelmq/lib/pipeline.py#L7


Аналогично, мне кажется, что этот символ не зависит от локали. В твоем случае, как минимум.


I really don't like this grey as a background colour. It looks old and washed out. I know thats what we had last year, but I'd prefer a simple white. That looks fresher and more importantly cleaner. I few had more diverse colours on the site perhaps a grey would be in order but we don't have that.


Brandon assisted configuring my rack application to allow my tests to be run.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20949/testReport/) for this commit**


Yeah, that line should be removed, right. Will provide a "pythonic" fix.


Just a test bug: https://github.com/mongodb/motor/commit/5fec1ab4cbe0a5a6838dc591331895052ef512e7


Eh no worries it happens, it's just that I didn't notice immediately because travis was down for a while.


Выглядит странно. `spring:url` относится к внешнием URL-ам, а `include` оперирует адресами внутри приложения, на ФС (вернее в структуре WAR-а). Так что их смешивание выглядит странным.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8321/testReport/) for this commit**


I know this brings it closer to the template we had, but I think the larger margin looks better here.


Действует до закрытия браузера.


Норм, я бы тоже так сделал.


no I did not


I like this a lot, having the two languages beside each other rather than underneath.


@conslo I can't take this decision, it is up to @davegandy

If it is ok for him, we can revert the offending commit and schedule the change for 5.0.0


這個 step 跳太大了，建議先用最簡單的方式通過測試後，再進行重構。

會發生這個情況，很多是因為一開始就把所有 test case 都完成，所以一次就想把後面的 test case 需要的程式碼都補上去。


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1880 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


很好


А если я решу изменить строку целиком и, например, убрать символ << - мне придется искать во всех страницах.


Stas, you didn't change line 167 of `langpack-builder/blob/master/lib/lp-builder/utils.js`
it still has the old value of `moz.b2g.version`


I already changed it to inline-list because this approach completely fails on mobile.


建議如果要 refactor 的話，這一段可以改成用 dictionary, O(1) 的處理速度還是比 if/else 或是 switch case 快一些。


start variable name with lowercase letter `numberOfTargets`


Not sure we need another module for this stuff, but I wanted to test it and I'm always a little nervous to do `@doc false` to test stuff :)


use a more verbose variable name such as `ultrasonicSensor`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20950/testReport/) for this commit**


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 609](http://build.prxm.it:8811/viewLog.html?buildId=4036&buildTypeId=Jarvis_DocumentStore_CI) is now running


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 608](http://build.prxm.it:8811/viewLog.html?buildId=4035&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Tests failed: 4 (4 new), passed: 291 Build time: 00:14:18
### Failed tests
```
Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.DocumentControllerIntegrationTests("v1").verify_de_duplication__not_delete_original_blob_before_15_days: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_multiple_password("v1").verify_tika_job_with_password: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_multiple_password("v2").verify_tika_job_with_password: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_password("v1").verify_tika_job_with_password: <no details avaliable>

```


Shouldn't this be marked as `internal(set)` or `private(set)`?


Это одна из безуспешных попыток заставить работать на Томкате, потом я откатил этот коммит.


Да. Рад, что ты ты видишь плюсы/минусы и можешь сам выбирать, что тебе важнее.


This is the algorithm we talked about, it turned out very nice and easy to read. Left some comments for future us/contributors :)


since you are only printing `NumberOfTargets1` in this function and not using it anywhere else, you can declare it as a local variable in the function. It does not need to be a class variable


Mporeis kapws n kaneis checkout thn version pou thes . thanks to doume
Στις 21 Σεπ 2015 3:09 π.μ., ο χρήστης "G90DD" <notifications@github.com>
έγραψε:

> Psilogamithikan ligo ta pragmata, conflicts vlepo edo kai den mporo na
> kano kan commit/sync/discard.
>
> Tha kratiso oti kano offline kai avrio ta fiaxnoume, sto xml tis exercise1
> doulevo kai an prolavo tha arxiso kai to GPS.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/faniskou/monkey-island/commit/591fa3806ca6c0270419076b7e0850ba26e98150#commitcomment-13332789>
> .
>


You've opened my eyes! А я-то думал почему у меня локаль на my-stamps.ru "слетает" :))


Результаты рекурсивных вызовов --- в отдельные переменные. Иначе прочитать невозможно.


P.S. Отлично! Теперь уже я начал учиться у тебя :)


@kdavis-mozilla Thanks!  I just pushed a fix in https://github.com/l20n/langpack-builder/commit/75888ff394940cdf5b878529a5f53c47d3dcb19c.


Думаю можно! :)


Не думал что такое возможно в принципе :))


ok


Minor: We write `from .logger import get_logger` in other places. Might be good to keep it consistent.


please provide some comments about what this block of code is doing


Thanks for adding doc strings!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20952/testReport/) for this commit**


В модели для хранения атрибутов, очевидно, сидит мапка с добавлением по ключу String. Таким образом, двойного добавления не случится (personDto просто перезапишет старый в корзине). То есть, не будет в модели двух одинаковых атрибутов, просто будут лишние телодвижения Спринга, так?


kafka思密达。


### Name        : Calcultor<br/>


I think that use **Ant** and commit into repo external libs is really sucks. Let's use more advanced build tools like **maven** or **gradle**.


INTEGRATION TESTING_2015-09-21 12:18:30


minor: Would it make sense to prefix the temp file? I try to do that just to make it easier to identify them at runtime.


Bei mir sieht das leichte grau nicht schlecht aus. Kaum ein Unterschied zu weiß. Wenn es stört machen wir es halt wieder weiß.


ear Damien:
         I am glad to meet you. First please allow me to express respect and worship to you. I am a student from China.I have emailed to you.
         After I read you dissertation 《On L´evy Processes for Option Pricing :Numerical Methods and Calibration to Index Options》，I download the related MATLAB code of this paper. When I run the code, it appeared '' too many input arguments''errors, I am confused. Because I am weak in programing, I can not find the reason. Whether you can help me solve these problems, I would be very grateful if you can reply to me. And it will help me o lot in study.
                                                                                Best   wishes


Maybe we could have a default `gui_id` of "sonic-pi-cli-gem" or something, and then allow users to specify a different id from the command line or via an `ENV` variable.

The reason I didn't go for a full PR is that I couldn't figure out how to keep backwards compatibility. Sonic Pi does have a `/version` endpoint we could use to check for the need for a `gui_id` before each request but that would be a lot of overhead I think.

https://github.com/samaaron/sonic-pi/blob/master/app/server/bin/sonic-pi-server.rb#L481

Perhaps we could make that the default and log a warning saying something like

```
It looks like you're using Sonic Pi v.2.7 or greater
Set USE_GUI_ID=1 to get rid of this message
```

or

```
It looks like you're using Sonic Pi v.2.6 or older
Set USE_GUI_ID=0 to get rid of this message
```

and then leave it up to the end user to add that var in, otherwise we check the version every time


Wird das nöd alles im dashboard.tpl.html checkt?


# Calcultor

### Name:
Pic_Spider
### Author:

1anc3r(1ancer)
### Version:

1.0
### Copyright:

1anc3r (c) 2015
### Description:

Calcultor in Android, Ansi-style


INTEGRATION TESTING_2015-09-21 12:20:24


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20953/testReport/) for this commit**


What is `named`?


Denke ich nicht. Mussen wir mal ein paar Leute im FSR fragen was besser aussieht.


Please, handle nil object and key when adding to cellMappingDictionary.


Hi Ocke,

After doing the research and Installing Ruby, I was able to install the bookmarks and I also installed related tickets app which is more helpful but it displays only one app at a time.

May I have to do something extra.. How do I run two zat at a time?


layers-> layer


The exception method will automatically include a full call stack, so no need to pass in `e`. Probably better to pass in a human readable error message.


I would suggest having the joint game function also take care of the state transition as well. Consider something like `JogService.joinGame(gameId)`. Your markup will be a little cleaner without the `ui-sref` and it won't be possible to join a game _without_ the state transition.


Should all dots be replaced by _?

See http://stackoverflow.com/a/2821183


Please wait a moment. I am already correcting some mistakes. I will commit them asap.


LGTM. Thanks for your work.


Ja das habe ich auch gerade gesehen. Es kommt bei manchen Größen zu hässlichen Problemen. Aber es wäre schön, wenn wir die Sprachen vielleich doch nebeneinander haben können. Evtl. muss die Sitebar schneller nach unten verschwinden sofern die Screens zu klein werden.

Was mir hierbei außerdem wichtig ist: Der Language-Block soll genau so groß sein wie die Nav-Bar und auf der gleichen Höhe. Damit sieht das ganze einfach besser aus.


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1345 of 1345 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.28%25-green.svg)


Good spot. I've updated the test and commit note accordingly.


This line is illegal typedef's substatements (ref: https://tools.ietf.org/html/rfc6020#section-7.3.1)


I somewhat dislike that it messes with $args[0]? How about doing the special casing in the boolop function?


Yes


이거 실수로 지웠음.


Kuba, czy na pewno potrzebujesz całego tagu html/head/body jeszcze raz tutaj? :-)
W zasadzie to co jest w layout/application.html.erb przechodzi na resztę widoków - pod warunkiem, że mamy tam <%= yield %>. W miejsce yielda postawi się wtedy cały kod z reszty widoku.


этот метод можно улучшить - https://gist.github.com/ilyubin/f7995f18a9adc1b0590b


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20954/testReport/) for this commit**


RFC 2087 section 3.

By the way, it is a rework of what Norman Maurer did. Seems like "message quota" seemed important to him.


Ja da magst du recht haben.. ich persönlich finde es irgendwie angenehm gerade das hervorzuheben was ich mir anschaue damit ich nicht den Fokus verliere (oder so :D )
Zur Not kann das aber auch raus


right


'포스트 페이지'는 실수로 지웠다가 다시 넣었음.


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 609](http://build.prxm.it:8811/viewLog.html?buildId=4036&buildTypeId=Jarvis_DocumentStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 292 Build time: 00:12:44


I'll work on this, seems like a weak point of my implementation.


Keine Sorge, ich mache gerade nichts am Code und warte dein Commit ab. Musst dich nicht hetzen


Понял, все замечания исправил


No problem but It's more a message count or message number quota, don't you think ?


Этот метод есть в TestBase


Good refactoring, has this got test coverage for the scope and rake task?


Same thing i'll work on this


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/18210/testReport/) for this commit**


Will there be an issue here if an app (for some reason) wanted to pass back stdout during execution?
What about long running processes like the ingest app that may execute for weeks on end?
Just trying to think of cases to consider as this looks like a change in behaviour from how it worked before :)


declare one variable per line. Variable names should be done using camel case (`flagLeft`, `flagRight` etc.). The names should also explain what they are used for. What is the flag doing? what is `out`?


I feel like we should have no unit here, just B and count


spaces on either side of operators `flagl = false`


:clap:
:cake:


Можно перенести в TestBase


test


are you opening a file here but not closing it?


It looks like this commit has removed wok's dependencies from requirements.txt.  What was the reason for this?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20955/testReport/) for this commit**


???

The idea behind this in Memory Max quota manager is to BE MUTABLE for maximum default policies .

Maybe the naming let you think it should be mutable.I'll work this out.


lgtm


How about adding `get_logger().warning("Could not clean up temporary stdout capture file '%s': %s" % (stdout_path, e))`.


This code screams for a dedicated constant :p


Which string ?

Or this constructor ?


I don't see the value of a mutable policy : you should configure it once then go with the values. Why would you want to change it at runtime ? Am I missing something ?


Looking at the Eden Sync Adapter, yes the Content is sent here.
What we need to work out is how to configure the Content.
For the Eden Sync, this is all contained inside the sync_task.Row
For Notify syncs, this is contained in pr_subscription.Row


First sentence doesn't make any sense.


Cuối action không cần return;


please put at the top of the file


String value doesn't tell me what kind of value is expected : is it a name ? something else ?


It already is in my Spring declaration.
I'm not doing GUICE stuff here.


I'm not sure I understand.
Are you wanting to be able to remove the None option from the widget?
- how would you propose setting the value of None in this case then?


i think here it's enough to check if it contains rmissl, same for pnpssl


I suggest to rename either the `_mesh` or the `mesh` or both variables to clarify which is which.
Please have also a look if the description in the header file is up to date or needs more explanations.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20957/testReport/) for this commit**


We should pass `XMLHttpRequest` request here as well.


We need a comment why we pass `XMLHttpRequest` here.


@Singleton is not guice specific, it's JSR 330, which spring implement too. Saying if an object is a singleton or not should not be in some configuration file as it can lead to incorrect behavior.


same as above - i don't think you need to include e here. instead, add context:

```
except StandardError, e:
    get_logger().exception("Could not execute external process %s" % str(args))
```


nice master TIllNoske and Joshafest


Yes:
s3task.async("sync_synchronize", [repository_id])

https://github.com/flavour/eden/blob/master/models/tasks.py#L618


We can not fix heights. This will always break the mobile layout. In the actual layout (content - sidebar) there is no responsive friendly way to have them the same height.
You can expirement with the image sizes, so that they will scale correctly but you won't prevent the overflowing of the language switch.


>То есть, не будет в модели двух одинаковых атрибутов, просто будут лишние телодвижения Спринга, так?

Да.


always use braces even if it is a one-line if-statement

```
if (flagl && flagr) {
    backmove();
}
```


name the functions with camel case `backMove`


Is there a point in deciding that X would get 2 times more storage quota ?

 (If you have a look to JAMES-511 you'll see most of the inmemory quota configuration is done threw config file, but one can be very happy to not reboot its server for modifying a user quota. Hence, no immutability here ).

Humm I guess concurrent hash map handles the concurent RW access.


>Also man könnte probieren die curvature über die bendiness anzunähern, die sehr schnell berechnet werden kann: edge.getDistance/"calcDist(baseNode, adjNode)"

Ja das habe ich mir auch schon so überlegt. Finde die bendiness relativ ungenau, aber wenn man die bendiness noch mit dem roadType und der Geschwindigkeitsbegrenzung (falls die verfügbar ist?) kombiniert, könnte man vermutlich ganz gute Resultate erzielen.
`bendiness * speed`
Dadurch würden kurvige Straßen mit hoher Geschwindigkeit besser bewertet werden. Es gibt bei uns in der Gegend einige tolle Kurven, allerdings Großräumig auf 40 bzw 60 begrenzt. Die Kurven würden aber mit 120 Spaß machen. Mit 40 fällt man in der Kurve um ;).

Zusätzlich habe ich mir überlegt, dass man noch eine Liste von kurvigen Strecken, wie z.B. die vom adamfranco zu importieren. Diese könnten dann automatisch gering gewichtet werden, ähnlich wie ich das jetzt schon im CurvatureWeighting mache. Damit kann man quasi nochmal optional eine Optimierung anbieten.

> Um direkt sehen zu können wie lange die Ausführung dauert
>> Interessiert mich auch, gerade für längere Strecke geht es ja dann in die Millionen Male ... :)
Eigentlich kann/darf das nicht so lange dauern. Adamfranco bietet auf seiner Seite zig KML Dateien an (http://www2.adamfranco.com/curvature/kml/). Die hätte er bestimmt nicht alle erzeugt, wenn es pro Datei länger als eine Stunde dauern würde (was natürlich immer noch ziemlich lang ist).

>Ich werde innerhalb der nächsten Tage mal https://github.com/adamfranco/curvature auf meinem PC zum Laufen bekommen.
Sollte auf Ubuntu relativ einfach sein. Er baut auf eine Bibliothek auf, die etwas schlecht dokumentiert ist. Die Installation ist quasi nur für Ubuntu dokumentiert. Hab gerade leider keine Ubuntu Installation zur Hand um das zu testen. Ich denke für andere Betriebssysteme ist es etwas mehr auf Aufwand das ganze zum laufen zu bringen.


spaces between operators
`Obstacle obs = new Obstacle("sprites/parcours.gif");`


Since this is not a normal table with aa simple list but rather a timetable with big entries, I don't think it is necessary to highlight which element you are on.


Am I wright to say that it is that notation that made the Travis Build to fail ?


done


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20959/testReport/) for this commit**


Right


use variable names such as `lightSensor1` and `lightSensor2`


Gulov
program sardor;
var t,i,j,m,n:integer;
begin
readln(t);
for i:=1 to t do
begin
for j:=1 to i do
begin
if (i mod j=0) then n:=n+1;
end;
if (n<=2) then write(i,' ');
n:=0;
end;
end.


what is `d`


Right....................................


Fantastic comments! Makes everything extremely readable.


Сделала разметку 2 страниц, по ним есть вопросы, в разметке есть теги section, в некоторых section jотсутствуют заголовки  h2-h6 и поэтому страницы не проходят валидацию, как сделать чтоб валидацию проходили страницы, или может разметка должна быть другая?


Наконец-то нашел эту настройку.


What is not specified is : "what happen if I change the value at runtime ?"
Will it change the value for already created quotas or not ?
If not, how can I change them ?


The backport of this commit looks good :+1:


Thanks for you reply Nick - Created at PR.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 54](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=181&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Relique of the past that I have not removed.

Seems like this object will start / stop calculating quotas when unknown...


what's 'remaningSelected'?