102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (lgu1234) - Win64-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-59.21%25-red.svg)


I usually leave the named return values for when the names are enlightening, or when the return logic has lots of default values such that consolidating them makes it easier to read.  In this case, I think ret := true and return ret.


@abakst I made this edit because the qualifier was not well formed before, and the test fails now. Do you have any idea why it fails/how to fix it?


It is not guaranteed that the dictionary has a value for "favorite drink". Hence, it is an optional


Turns out it's not the impulse generator, but some yet to be determined issue with gcc causing occasional flakes (switched to clang/llvm for testing).

Partially tested with limited checksumming:

Between gbsdb.0.0.93-44-g28b1ae2.txt gbsdb.0.0.93-52-g336ae3b.txt, output changed for files:
(name, rom data crc32, output md5sum)
[none affected]


у тебя в проекте все еще полно мусорных файлов с ~


I'm using Xcode 7 GM seed and it complains that `rect` is undefined.


I hate to complain about code style, but for the sake of consistency, could you please insert a space between function name and first parenthesis, and put the brace on a new line?


You could have used the global "join" method instead.


No :). Well spotted.


closes #21


Looks like some redundancy in this line.


Please replace `1000000000` with `1e9`, it's easier to verify as correct.


Do you need this check?


Can also be written as mapLinks[newit]; but I guess that may look weird.


:blush: Still leftovers from debugging / testing. `localhost:8000` is `python -m SimpleHTTPServer` - so I can quickly go offline / online. :dancers:


nvm, you already did. Good...


This is wrong. The return value needs to be based on whether Worf is in that array or not.


We support OS X for now only as there is a bunch of scripts in our dev tools that rely on running on OS X https://github.com/facebook/react-native/issues/2684


That's a shame; they are/were so useful.
There are still his other tutorials at greyminecraftcoder.blogspot.co.uk.
Jabelar and coolAlias are also very helpful teachers and active on forums.
Their tutorials are at jabelarminecraft.blogspot.com and github.com/coolAlias/Forge_Tutorials
(To update your screen you probably need to call initGui() or displayScreen() often)


Extension should be extracted from the file name. you can use `helpers.getFileExtension`


We can use `let` instead of `var`


this one did still have a `->`


Did you check in some of these files by mistake?


Do we need to check for an iOS version less than 7? I don't think 6.x is supported by Cordova anymore.


EvapCoolingSizingFix (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1334 of 1334 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.21%25-green.svg)


Why not just `#define UNIX_EPOCH 116444736000000000ULL`?


Same as above.


@Punzo Since that specific change (removing the space before the suffix, and the one after the prefix) has always been here. I am not integrating that part.


OK, thanks for the info. Something to keep in mind then is that every project using `sky_tools` needs to use the exact same version of `test`. Or more specifically, be able to use that version, and have their constraint set to encompass it. Very narrow constraints are problematic when another direct or transitive dep also has a narrow, but incompatible, constraint.


I gave this version some processor hours at 60s, 2 min and 5 min: all positive, test at 15 min LMR also has not collapsed yet


In Base >= 4.8.0.0 the Prelude exports (<$>). Building on ghc 7.10.1 generates quite a few 'Warning: The import of ‘Control.Applicative’ is redundant...'


Re TODO: given that the code already assumes the entry exists, yes!


You could also use the method sortedArrayUsingDescriptors. That way you don't need a mutable array.


Se houver mais algum erro, avisem.


Shouldn't there be no registered notification?


Blank line missing


oops, pushed and rebased.


Consider using a filter like `_.reject(files, isValid)`.


The main question is how I can test this?!
I had approximately 20 Elo gain on 1000 games on my machine, but I can't
afford much more games on longer time controls.

On Mon, Sep 14, 2015 at 10:33 PM, alwey <notifications@github.com> wrote:

> I would postpone SPSA tuning for a moment. Your tests seem to be about
> neutral at STC, but the bench 7217127 version seems to be *very*
> promising at longer time controls. I would not be surprised to see double
> digit ELO gains, at least for 60s up to 5 minutes TC. The main question is.
> how does this scale further on?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/IIvec/Stockfish/commit/afd334590ca6b2d36a2eb7964d2ffa3b66c27aa4#commitcomment-13222442>
> .
>

--
IQ World <http://www.ultimaiq.net/>


return error?


Indeed. `rustc` wouldn't let go, unless I took care of that `_` path. (Also: I was even more afraid of using [`unreachable!`](https://doc.rust-lang.org/stable/std/macro.unreachable!.html)).


Shoudl we not remove the database here?


print` is defined in `host/` and is not part of the spec; it's just part of the test harness, same as the `script` commands like `assert_eq`.  We also agreed [elsewhere](https://github.com/WebAssembly/design/blob/master/NonWeb.md) not to attempt to standardize POSIX (so `write`) in wasm.  Also, the goal of `print` is to make it trivial print values for testing purposes; I think anything in the direction of `write` would mean more work to write test cases w/o any benefit.


Was an accident


That's true, but it won't be as narrow as this forever. As more versions of `test` are released that support `loadVMFileHook`, the constraint can grow to encompass them, and when we land a plugin API the issue will largely go away.


fixed


To match the syntax in goBinary.GenerateBuildActions


Надо бы  baystation12.int  в гитигнор пихнуть, да Воласа фиксы глянуть.


return error? (although it isn't currently returned either)


swap? Or just make setAllRemoves and txToRemove the same variable.


Trailing space.


Makes sense, this originally had a more complicated return path, but then I managed to simplify it. I'll fix this.


Is there any way to let valid files continue to upload, but raise a warning if an invalid file is detected?


Hey there, I am finding a case where loadEventEnd is zero and it subtracts navigationStart from it and becomes a negative number.

Maybe my page just has no onload events that were in queue?  I am going to try that out.

But in the meantime, should we maybe have some logic to check for bad values in this logic and massage it a bit if we see zeros like in the loadEventEnd case, we can handle it by subtracting the loadEventStart?

In my case where I think my sample page has no onload events, loadEventStart in the mix helps show that my page load time was 976 MS.


remove commented out code


remove


Yep, this is still confusing me but I wanted the update method to eat whatever comes out of the check, so I can call `ui::update(net::is_online());` in `main.rs`. (Well – and because it would compile. :eyes:) Come to think of your other comment I might just stick with the successful state and use the `enum` as a type.


How about a more idiomatic example, eg:

```
$ids = Vector { 1, 2, 3 };
$users = $ids->map($id ==> User::load($id));
```


Did you try clean install? What version of node? Mine is v0.10.25 and it works.


This function is never called with `id == CLOCK_MONOTONIC`. We deliberately run the tests against wall clock time.


(or array_map() if this is before collections)


alwey, can you be more precise about # of games and results.


Agreed. :)


Might want to use the method from  GT-14597 (app.getVisibleScrollerText)


fixed


we should only ever track jesusFilmActivity as a boolean internally.

the only reason that it is being returned as an int from the API is due to a clustering feature used in the Angular app that we implement locally in the Android app. I would convert from the int to a boolean at json parse time (0 = false, anything else = true), then handle it as a boolean internally for all other interactions.


BTW `@Nonnull` is pointless on a primitive type.


Looking forward to learning more about what "encapsulation" is :+1:


LGTM. Merging.


I understand what you are saying in regards to the for loop. Though the program only appears to output a string, it actually outputs a single character one at a time each iteration through the for loop.


this should be `JSON_JESUS_FILM_ACTIVITY`


Ah gotcha, I agree that a minimal thing is useful for testing. The test isn't in host though, which led to my confusion. I'm wary of this seeming like it's part of the spec, but I'm not sure how we could avoid it. Any ideas?


More common to create a `help-testResultsDir.html` rather than using the `description` attribute, but either works.


The PaletteController was acting as a kind of 'SelectedColorsService' already.

If we want to clean this up, we could:
- remove the getPrimary/SecondaryColor() methods from the PaletteController
- all previous callers should now rely on the SelectedColorsService
- SelectedColorsService is now listening to SELECT_COLOR events and firing COLOR_SELECTED events
- PaletteController is firing SELECT_COLOR events in onPickerChange_ and listening to COLOR_SELECTED events


Unused `description`?


missing a `break;`


Maybe indicate why you're commenting this out?


I'm really glad you caught it. I stared at that code for a good while before I really saw the bug.


But can I add diagram files on the tracker that will be source controlled?


Shouldn't this be `element.tagName === 'BODY'`?


See sys/build-m32.sh also the M32 env var is honored from install.sh and user.sh

Thanks for reporting! That was a nice usecase to catch issues in the build system

> On 14 Sep 2015, at 21:07, Francisco Alonso <notifications@github.com> wrote:
>
> cool, -m32 :-D
>
> —
> Reply to this email directly or view it on GitHub.
>


I believe that I have fixed the rebase issues, and I removed the cscope.out
from the cache.

-John

On Mon, Sep 14, 2015 at 01:37:45PM -0700, Christian Geier wrote:
>Did you check in some of these files by mistake?
>
>—
>Reply to this email directly or view it on GitHub.*
>


first test


Didnt knew this. I prefer bool. But lets travis and appveyour say :)

> On 14 Sep 2015, at 22:34, Anton Kochkov <notifications@github.com> wrote:
>
> @radare you can use bool instead of _Bool if you include
>
> —
> Reply to this email directly or view it on GitHub.
>


Do we need to delete the old one from the queue?


@jbecla `map` without using the return value triggers warnings in linters. It is recommended to use an explicit `for` loop in these cases.


Still in discussions.


That space.


@rndD От это уже ушли :)


"at least"


Why even have `std::make_unique` here, if you're scoping it only to the lambda as opposed to:

    PaymentSandbox sandbox (&*cache->getLedger(), tapNONE);


I feel like I remember 80 character line limit discussed, wander where 92 comes from..


→ 2a2126d


a preview is not really a thumbnail, although the patch does make some sense


There are a lot of contest bots out there that copy the text of a contest rather than retweeting the original.  Adding ability to add blocked users automatically to ignore list, so that that there is a way to not retweet these other contest bots.  Alternatively, could be used to selectively ignore users by blocking them, rather than having to manually edit the ignore list.


Tabs, not spaces.


Yep, confirmed that when I add an additional onload.  My loadTime is working fine.  I have

```
timing.loadEventStart - timing.loadEventEnd - timing.fetchStart
```

And I get an accurate timing of 11 seconds in my slow onload function I created.  I am sure most applications attach an onload event, but I am sure there could be cases where they dont have any attachments possibly.


To use SPSA here, just
1. Remove the const qualifier and assign values to variable
So it will be like

double a=0.83, b=3.488, c=0.47, d=4.76;
double K[][2] = {{ a, b }, { c, d }};

TUNE(a, b ,c ,d);
or just TUNE(c, d) if you want to tune c and d only.

Go for SPSA test, 30+.05 TC


I can press charges on this commit right here. Since I helped with the making of the mod you must credit me some.


TeamCity pull requests :: netty [Build 197](https://garage.netty.io/teamcity/viewLog.html?buildId=1324&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:59:23


TeamCity pull requests :: netty [Build 200](https://garage.netty.io/teamcity/viewLog.html?buildId=1328&buildTypeId=pulls_netty&guest=1) is now running


Not sure what you mean, that the old calls are not atomic. The doFetch etc are not implemented by the generic provider, so it's the task of the concrete implementation e.g. redis to make them atomic. But here the race condition is already built-into every cache implementation.


No, this is not intentional.  While close, the coefficients should be different for the Nexus 4 and 5.

The planned fix is to shift to a path loss formula, which is easier to implement for multiple devices.  It is a work in progress here:
https://github.com/AltBeacon/android-beacon-library/pull/251


Why did you have to change spacing in other lines to add a new entry?


ACID script for NPC 8982 should be dropped after this update.


you should be checking if the new value is different from the existing value, not the same.

the `mTrackingChanges` framework is setup to track only values that have changed. That way we can push only a minimal update to the API the next time we have internet access and not clobber an update made by another user when we didn't actually change the value locally.


@jbecla since the `map` returns no values this should be written as a for loop.


Funny that there are no matches for https://www.google.com/search?q=2ba0aaa11a3e96ec0af31d532d808e1f09cc6dcad0954e637902a1ab544b9e60 yet :)


EvapCoolingSizingFix (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1866 of 1868 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


Why GetCountWithDescendants() doesn't return uint64_t directly? can it be negative?


Why should checks be done in complete?


correct alphabetic order to the auto layout section.


"gen" is the name we've been using everywhere else


I should just delete this like the rest of the RHEL 6 stuff. Thanks


I like your summaries and connections regarding the articles by Dilger and Brosset. It was a bit tough for me to see more to the articles than just the surface of it, and upon reading what you saw as the connection between the two, I think I have a better understanding.


based on my understanding of the requirements, you should also prevent a user from saving a new church until they have selected a yes or no jesus film activity radio button.


isn't better just log this unexpected location and allows the compilation to crush? I think that `null` passed to sbt is even worse than NPE in this place


Cross-attendance of meetings is a good start, though my week is already pretty full of meetings so I'm reluctant to sign up for more myself. Another useful thing we could do would be to establish a way that anyone could look at the current open list of DefCore-related issues. For example, what if DefCore signed up for a Launchpad project page and filed bugs against both DefCore and the associated project when there was some sort of shortcoming? "Glance has no public image upload API suitable for interoperability testing" might be filed against Glance, so that team is aware of it, and DefCore, so we can find all of the bug reports and indicate their priorities to the DefCore committee. That wouldn't replace more direct communication, but would supplement it and support asynchronous perusing.


OK, thank you.

On Mon, Sep 14, 2015 at 10:52 PM, absimaldata <notifications@github.com>
wrote:

> To use SPSA here, just
> 1. Remove the const qualifier and assign values to variable
> So it will be like
>
> double a=0.83, b=3.488, c=0.47, d=4.76;
> double K[][2] = {{ a, b }, { c, d }};
>
> TUNE(a, b ,c ,d);
> or just TUNE(c, d) if you want to tune c and d only.
>
> Go for SPSA test, 30+.05 TC
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/IIvec/Stockfish/commit/afd334590ca6b2d36a2eb7964d2ffa3b66c27aa4#commitcomment-13222845>
> .
>

--
IQ World <http://www.ultimaiq.net/>


No, you cannot have general interface doing doFetch(value) and then doSave(newValue) later and still make it atomic inside of specific provider. If you want to do it properly you should have proper `add` or `increment` call which does both in one go at driver level.


He is asking for a proper issue on the tracker :-)

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 14 September 2015 at 22:53, Tobias Schultze <notifications@github.com>
wrote:

> Not sure what you mean, that the old calls are not atomic. The doFetch etc
> are not implemented by the generic provider, so it's the task of the
> concrete implementation e.g. redis to make them atomic. But here the race
> condition is already built-into every cache implementation.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/doctrine/cache/commit/80ecf211df0283d36d941fbf090d7b0c944da542#commitcomment-13222856>
> .
>


Why was the trim() on  line 1336 removed?


LGTM :+1:


Why do you retrieve this if you are not going to use it?


nice thanks


My limited understanding of defaultdict is that they were needed to avoid failing keyerrors. This isn't really something `sops` needs. Are there other benefits I'm missing?


Why this change?


Why aren't you using the item entity id that is sent by the client?


Done


This is going to interact strangely with variants.  If you called AddReverseDependency on a module that is a variant, you could actually end up adding a reverse dependency to a different variant that matched the first variant of the destination.  I think you'll need a Context.addReverseDependency, maybe take most of the Context.addDependency logic and extract it to Context.findMatchingVariant that can be called by both.


Is it still bad Python if I explicitly do want `tree['sops']['kms']` to be a list?
Would that code fail if it's defined in a superset of a list?


Thx ! I use Zip loader :)


TeamCity pull requests :: netty [Build 199](https://garage.netty.io/teamcity/viewLog.html?buildId=1327&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 5600, ignored: 21; resource leak detected (new) Build time: 00:36:41


TeamCity pull requests :: netty [Build 201](https://garage.netty.io/teamcity/viewLog.html?buildId=1329&buildTypeId=pulls_netty&guest=1) is now running


That's a great idea, and one that's actually come up in a couple of DefCore meetings as well.  I think we actually discussed setting up a Launchpad project at the midcycle a few months ago, but it was sort of passing discussion and nobody ever really followed up.  Probably time to change that. =)


I thought Brosset gave us a great introduction into what the advantages to CSS are, as far as how to actually use it.  In reading Dilger, too, I'm curious about how it is that we give our layout more variation, a "break" from the grid concept that he referred to.  We got some introduction to the coding, and so as a layman in that field I am starting to understand the basic terms. Is all the variation we can do in CSS still just within the construct of the grid (e.g., merging cells), or was Dilger referring to other, more advanced coding (which we may never even get to in this course, I suppose)?


Well, the tests are in `test/ which is also not in `spec/` and already depend on `host/` (viz., the top-level `command` language).  I think we'd need to define in the wasm spec a bunch of builtin libraries before we could define a totally host-independent test suite.  If we keep our builtins slim, though, it should be easy to implement in any host environment.


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1335 of 1335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.21%25-green.svg)


Let your mind wander some more, you might find no answer.


After update to version 4.1.406 WEB UI is blank in web browser


I do not really care what the IDEA configuration looks like, as I do not use it. :-)


Doesn't this mean that a 128x300 image is valid?


yeah, copy paste mistake, I didn't review it myself


On Monday 14 of September 2015 11:21:07 Brad Allred wrote:
> hmmm, any reason why `CountBits` isn't simply a free function somewhere (or
> at least a static member)? It's a generic operation that doesn't carry any
> actual dependency on the (already bloated) core.
Easy access everywhere, since it is needed mostly for debugging outside of the
previous scope. It's not static here, since we only have one Interface object
anyway (any other benefits?). If you can make it better, go ahead.
In the meanwhile I found out the original major reason for the split, another
user in SPLImporter, is not valid. But that part was never committed, so no
problem there.


94006714-MultipleTowers (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1869 of 1869 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


are you sure you need to use unary operator (|) instead of regular logical OR operator (||) ?

this is very likely a bug


same as before, I copied more than I should and didn't check when I pasted


I usually removing it and using clean import


ok


Did you run into some problem?
The only reason I can imagine for reverting this is that you'd want existing files to be silently clobbered by default, which might be useful in scripts.


And here I was thinking that the rationale behind changing one's computer name to ```0x6D746873``` was some leet-haxxor method of obfuscating one's computer name. or making it harder to target, somehow :)


Neither nCountWithDescendants nor nSizeWithDescendants can be negative.

Why int64_t instead of uint64_t?


@ragesoss Gets called from [here](https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/config/routes.rb#L72).


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2310 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.59%25-yellow.svg)


congrats to the react team. When can we expect a stable version any timelines?


You are doing MUCH BETTER job with variable and method naming! There are a few places for improvement which I will point out below.


DomainMessage interface has no method `toArray`. https://raw.githubusercontent.com/prooph/common/41adb277bfc5bd4eb10aa19c38a9304ad2bc3bd0/src/Messaging/Message.php


Thank @EmadMokhtar - but it's not the rst file that's broken. The Sphinx build is fine and all the single quotes render. The migration into Wordpress is the problem, so I need to fix this on the front end, not in the rst code.

Cheers,
Nige


Я бы сказал что окно ошибки стало не просто более красивое, а опустилось до уровня плинтуса. Дерьмо в общем. Верни старое более Маковое окошко ;(


![touched the butt](http://cdn1.theodysseyonline.com/files/2015/07/16/635726742637008567511161299_151298-finding-nemo-he-touched-the-bu-c7Ex.gif)


The names shiftDown and shiftUp are not very meaningful for me, however I don't remember the algorithm well. Maybe they are fine names.

Could you please add a link to a web page which you used to read about Heap Sort algorithm? You can add a comment with a URL in the beginning of the class.


why?


Looks good


Fine by me


This doc comment says everything we want, I think, but can you rewrite it so it doesn't refer directly to private functions and variables?


:+1: Great job!


`DomainMessage` is not the interface. It is a basic implementation of the interface `Message`. That said, the NoOpMessageConverter can only be used when using `DomainMessage` objects.


Also, super minor, but this last sentence shouldn't end in a comma. :)


I like how you brought up the concept of (non-working) and (working). It's interesting to realize that we can understand so much about technology and it's benefits, but completely fail to realize how other audiences view technological advancement. I'm curious, what is your personal understanding of technology?  As a student, would you view new technology, such as the iPencil as working or non-working.


I think createBuffer should initialize the buffer to zero.  But the buffer that is returned by OfflineAudioContext isn't observable until you startRendering() is finished, at which time, you can't tell if the audio buffer was ever initialized to zero.

I would just delete the part about being zero-initialized here.


The problem is, I only had 2 cores and 12 hours of time:

Intel Core-i5 1.6Mnps (for 1 core),  book 8moves_v3
NLMR bench 7217127   vs  master bench 8020484

                   60s+0.05s      2Min+0.3s   5Min+1s  15Min+1s
                   44-35-221        7-0-43         5-3-32       1-0-17

Appetizer. And yes - I know something about the lack of statistical confidence so far


Should we make a call to assert that in the method?


tests atm spit out a tone of garbage, making it hard to see what ran/failed at a glance.


Verdade, está tudo ok, apenas o 'AND' era pra estar 'And'.


:+1:, 34d336c


The problem is, I only had 2 cores and 12 hours of time:

Intel Core-i5 1.6Mnps (for 1 core), book 8moves_v3
NLMR bench 7217127 vs master bench 8020484

               60s+0.05s      2Min+0.3s   5Min+1s  15Min+1s
               44-35-221      7-0-43     5-3-32   1-0-17


saw approval from hmmr
at https://github.com/basho/riak_ql/commit/3119c1f73beed4b60524ef0f1f50a4912b4cecf9


merging basho/riak_ql/gg/timeseries = 3119c1f7 into borshop-integration-22-gg/timeseries


basho/riak_ql/gg/timeseries = 3119c1f7 merged ok, testing candidate = 473f9358


Appetizer. And yes - I know something about the lack of statistical confidence so far


the two lines here could cause circular reference dependencies. They are already included in on_board_led_control.h.
If this file is not used, consider deleting it


You could use ::GetSerializeSize(CTransaction(), SER_NETWORK, PROTOCOL_VERSION). Unsure if needed.


For anyone considering this recipe: keep in mind that this will not perform imports.


I really enjoyed the Keim's discussion of hands' contributions to our language, even as far back as our early ancestors. Hands play such an important role in our evolution, that apparently as soon as we decided to walk upright, we were on our way to developing syntax in our language!


I'm happy with this.


this will need to get somewhat more complicated. First you should hand the event over and than actually change it. Use the *update_property()* (e.g. *update_description()*) for that.


I merged in all of the changes because they significantly increased the readability of the new code as well as reduced the amount of duplicated code.  Small changes had to be made to get the code to run without error but overall excellent changes.


better use ```line.split(':', 1)``` it will turn ```'description: one: two'``` into ```['description', ' one: two']```


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 617](https://teamcity.labkey.org/viewLog.html?buildId=272019&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 32 (2 new), passed: 9 Build time: 00:26:55
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

##### there are 22 more failed tests, see build details
```


won't be supported on cordova ios 4.x, not sure if plugins have to mantain compatibility in case people is still using previous versions.

Anyway, if we remove the iOS 6 lines, both methods will have [self setStyleForStatusBar:UIStatusBarStyleLightContent]; not sure if that's right but it's the recommended change on the deprecation message.
I tested styleBlackTranslucent and styleBlackOpaque before and after the changes and they seem to do both the same thing (on iOS 7 at least)


Where is this guy used?


not needed. PHP will assert the type and break before our assertion would be performed :)
Look at the typehint in the message signature.

And checkout the docs. They'll tell you more about the [DomainMessage](https://github.com/prooph/common#domainmessage) and [Message](https://github.com/prooph/common#custom-messages) interface


this commit lgtm, but can you add a test?


lol i use npp for these xD


lgtm


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


I also fixed Half Saiyan ssj


hi my friend.
amazing work.
one question before i spent 40 bucks for bandicam.

can every single light grab a specific area ?
like left lamp just use average color of the left 1/3 of the screen and so on....?

thanks for your reply in advance !
kind regards
polykoma


Thanks! I couldn't find the solution you posted, but that order in brackets was my headache


This actually breaks the code because apparently it cannot access addons unless the addons path is explicitly included. Fixed in a later commit.


Hmm... would `%.2f` make it more flexible and cleaner. Not assuming that we have a mempool >1TB soon.


I don't use my Twitter that much. Link to my Github, please :D


Dude, doesnt that delete the data of the next iterator?
Shouldnt it be:
delete it->second;
erase(it);


Sounds good to me. @theuni any thoughts about this?


Would it be possible to make the `DEFAULT_MAX_MEMPOOL_SIZE` a multiple of `MAX_BLOCK_SIZE`?


Either amend this or line 109 to make the 2 test names consistent.


gnomes


Like: https://github.com/popcornmix/xbmc/commit/843abc764e8028e93bea1ec2a3526dd483f47857 ?


Why append to the body instead of `element`?


Sure, will fix that. :)
> On 14 Sep 2015, at 10:21 pm, Marius Petcu <notifications@github.com> wrote:
>
> I don't use my Twitter that much. Link to my Github, please :D
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/vladvelici/vladvelici.github.io/commit/ae81d84c3bfb4f56e8d1e4a5f909ab912f0f0fb9#commitcomment-13223364>.
>


oh no, not more crappy pics


why this change?


thx


Add a `LogPrint("mempool",..)`? also on L904+?


"Larger human practices" is a fantastic way to phrase what Haas is talking about. It strikes me as NOT a coincidence that as the population of the earth has exploded, so too have our technological advances. Did tech bring about the population surge, or did that enable a rise in tech (or both!)?


who are you working for?


Ah, so we set `top` and `left` relative to the entire doc and not the containing element, right?


And probably remove the color parameter from 'applyToolAt' tool core method.


Yea


done


I am not sure about this. Will look into it.

Syed
On Sep 14, 2015 11:38 AM, "Arno Puder" <notifications@github.com> wrote:

> One more comment: if you want the app to launch automatically upon
> reception of a broadcast, wouldn't you need a declaration in
> AndroidManifest.xml?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/omersalar/android-tutorials/commit/ac9773c67a04d95e697eb74acf43d6ce01ab02c7#commitcomment-13220158>
> .
>


all tests pass:
success: http://buildbot.bos1/builders/test-riak_ql/builds/111


the same, one less xor


This forces a second stat for each file.

Can we come up with another way to avoid the error without adding extra I/O?

One possible solution is to add a filter function callback to listFiles...


done, one more xor


Hi David, just tried a few languages and can not see this problem. The language selected stays on after logging out. Don't know if this issue has been addressed from when you made this post though


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20664/testReport/) for this commit**


Remember not to use default package, group the classes into significant package names


This seems fragile... I'm ok with the change, but we might want to rethink how these tests are written.

maybe add a todo?


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (lgu1234) - x86_64-MacOS-10.9-clang: OK (1862 of 1862 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yes, but the Date is added manually (L187), this avoid having a duplicated `Date` entry in the response headers.


I agree with what Sarah said and like how you phrased that technology is infused with power to complete a task rather than providing power itself to do so. I also liked how you noted that new technology does not replace, but may fill a newly presented niche instead.


can we create a Date.now() shim instead of this?


Again, @MarkusH  used "unapplying", I suggested "roll back" instead -- I haven't read the docs lately, I didn't remember seeing the term "unapply" in this context at all. I do think "roll back" is a better term, but the logs and documentation should be in agreement.


Since we're appending these to the body and the body hangs around as long as the app is loaded, to we need to register a handler on `scope.$destroy` to remove the tooltip element when this directive's scope is destroyed?

Otherwise, I think we'll have a bunch of hidden tooltips accumulating at the bottom of the body as users navigate around the site. Haven't tried this, but pretty sure that's how it works.


Chris, are we going to get a hands-on view of what the International Style is? Also, is there a good way to write out "[left arrow] table [right arrow]" so that it gets formatted correctly in Prose.io?


This has never been fixed. The fix (https://github.com/concrete5/concrete5/pull/2887) was reverted.


should be ``opam switch 4.02.1+modular-implicits-ber`` here?


this doesn't look right. if ng is undefined we should throw. otherwise this becomes a noop since the new object is not accessible from outside of this function.


I guess we should throw if `global` is null or undefined, otherwise it's ok to create new object.


okay, i think it'll be the same :-)


Myself


Vi behöver den har raden (getMessage(); // i rad 45) eftersom i den här fallet har du hunnit att skicka ett meddelande till servern. Du får timeout från servern men det betyder inte att servern är avstängd och därför kommer servern att svara. Det kommer att orsaka att nästa gång du försöker att koppla dig mot servern det kommer att finnas två meddelande i buffert.


This feels a little odd. What not have `scope: { text: @ruitTooltip }` above instead of `scope: true`?


SO has the answer:
http://stackoverflow.com/questions/10328215/retrieve-wifi-connection-statusandroid


Since the issue is that a resource may not be available by the time it is requested, the normal way to do this is with a `Promise` from [`$q`](https://docs.angularjs.org/api/ng/service/$q).

Rather than store the array statically, the `guacImage` service would need to provide a function like `getMimetypes()` which would return `Promise` which resolves with a `String[]` of supported mimetypes once available.

`ManagedClient.getInstance()` already assumes that the connect process is asynchronous, so it will not matter that the actual connection attempt has to wait for image mimetypes to become available. As long as that function always returns the same `Promise`, the supported mimetypes will only be determined once.

Refactoring to use a `Promise` within `guacImage` will likely require refactoring `ManagedClient.getInstance()` to use a `Promise` for the result of `getConnectString()`, as that is no longer guaranteed to be immediately available either.


Doesn't fileexists also work?


Seems this should be called end :)


After define userControl3, you use userControl2, is this correct or this is a typo (error of typing)?


Just getting used to Github and exploring the features.


You should define getter so can access to the attributes of Paypal


Yeah, that sounds good. The most general solution would be to have an API for sharing the existing stat results.


Error = this should be node.


You should define getter so can access to the attributes of CreditCard


just thought i'd share this version of [invariant](https://github.com/zertosh/invariant) ...appears to be the exact copy from FB's sources.


I don't think the `encoding` package was introduced until Go 1.2.


Why do we have a commit in this branch? @kn9ts


why is Edge considered to be slow?


you can remove that for liberty


btw slowness is a property of the device/hw and not of the OS.


Could you have this definition of `perms` up in `extract-tree` so that the `case` isn't duplicated?


OK. We're using something similar with Promise in our client code also.

On Mon, Sep 14, 2015 at 2:33 PM, Mike Jumper <notifications@github.com>
wrote:

> Since the issue is that a resource may not be available by the time it is
> requested, the normal way to do this is with a Promise from $q
> <https://docs.angularjs.org/api/ng/service/%24q>.
>
> Rather than store the array statically, the guacImage service would need
> to provide a function like getMimetypes() which would return Promise
> which resolves with a String[] of supported mimetypes once available.
>
> ManagedClient.getInstance() already assumes that the connect process is
> asynchronous, so it will not matter that the actual connection attempt has
> to wait for image mimetypes to become available. As long as that function
> always returns the same Promise, the supported mimetypes will only be
> determined once.
>
> Refactoring to use a Promise within guacImage will likely require
> refactoring ManagedClient.getInstance() to use a Promise for the result
> of getConnectString(), as that is no longer guaranteed to be immediately
> available either.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/flangelo/guacamole-client/commit/1544a43ea3d02c77502a8a47c17c73fa70c0f4f5#commitcomment-13223605>
> .
>


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 618](https://teamcity.labkey.org/viewLog.html?buildId=272030&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:21:51
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

##### there are 20 more failed tests, see build details
```


:joy_cat: :tropical_fish:


I liked how you mentioned that technology does not just advance to be something better, and that technology doesn't have to be new to be effective.


Okay moving to bitbukkit


otherwise this looks good


I'm not worried about a unit test that's only failing on Go 1.1. Using that package is fine.


It's scary to me that more and more kiddos will grow up not even knowing how to sign their name in cursive. I the style is becoming more and more archaic, and at best it will be seen as a novelty (like having taken a caligraphy class) and at worst it may be seen as some kind of ancient runes. But the fact is, for now it is still a part of our language and I hope all my grandkids will at least be able to read it, if not write it.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 619](https://teamcity.labkey.org/viewLog.html?buildId=272033&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Snapshot dependency failed: LabkeyTrunk :: build Build time: 00:00:00


The .rpm ? It's required for things to work... We'll update it when the rpm for liberty is out


just letting you know it is already updated for a while


There's no prove of you helping, you wiped the repo and your help wasn't even wanted.....


TeamCity pull requests :: netty [Build 201](https://garage.netty.io/teamcity/viewLog.html?buildId=1329&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5600, ignored: 21 Build time: 00:35:56


TeamCity pull requests :: netty [Build 202](https://garage.netty.io/teamcity/viewLog.html?buildId=1330&buildTypeId=pulls_netty&guest=1) is now running


Why /** here but not elsewhere ?


the actual unique id for each user is user_id ... slightly different than
akid, but close enough.  I had thought that you couldn't change user_id via
API, based on something that Patrick said about list de-duplication, but
that was some time ago, so it is possible that it has changed since then.

Tara M. Harwood
Manager of Analytics & Data Science
SumOfUs.org

tara@sumofus.org
(510) 725-2979

On Mon, Sep 14, 2015 at 11:23 AM, paulaferris <notifications@github.com>
wrote:

> This is thread drift, but also isn't the actual unique ID for AK the user's
> akid, not email? It looks like you can in fact change a user's email via
> the API, so even on a page the interacted with AK it's possible we'd want a
> current email and new email field to build our own update your contact
> details page. https://act.sumofus.org/docs/manual/api/rest/users.html
>
> We can certainly update a user's email manually through the AK dashboard.
>
> Or I might be missing something. Very possible too :)
>
> On Mon, Sep 14, 2015 at 2:11 PM, Eric Boersma <notifications@github.com>
> wrote:
>
> > @tara-harwood <https://github.com/tara-harwood> Some context for this
> > code - it's intended to be used to check for common typos in email
> > addresses. For instance, if I type email@gnail.con, it will ask if I
> mean
> > email@gmail.com, which would be the correct spelling of the TLD and the
> > domain. It's not integrating with AK at all, just checking for typos, and
> > so in that situation it's possible we might need to check for email
> > addresses in multiple places, so it makes sense to have the code be
> > flexible enough to handle that.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/SumOfUs/Champaign/commit/34f632970b0338c0972553fd08285075aaf96831#commitcomment-13219570
> >
> > .
> >
>
>
>
> --
> *Paul Ferris*
> Campaign Director | SumOfUs.org <http://sumofus.org>
> + 1 917 753 9204 (New York)
> skype: p.ferris
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SumOfUs/Champaign/commit/34f632970b0338c0972553fd08285075aaf96831#commitcomment-13219789>
> .
>


Please finish all comments with "." (ending a sentence).


I would have to code say
if okOld {
  ks.handlePodDelete(oldPod)
}

if okNew {
   ks.handlePodCreate(newPod)
}


Testing w/ multiple threads is an inefficient use of resources compared to simply increasing the TC.


@madhawa-gunasekara Hi Madhawa, I cannot add a datasource name, containing letter 's'. May I know why it is restricted? and why do we have '\' character twice in the restricted list?


rename it to variable name to _state_pin_info (do not mix it with pin_info struct)


It's a Javadoc comment specific to that field.


Show me something that you worked on the mod


Yes, I do realise my python is really sloppy. My experience with it is, honestly, limited to what Ive done here. I'll try and sort out the things you mentioned, and start using the styled popups dependency.


This is causing some regressions, as the `backKeyHandler` method of subkinds will not be called due to this return value.


#4672-AirLoopHVACUnitarySystem-with-heating-coil-but-blank-heating-supply-flow-fields-does-not-heat (rraustad) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


why not just stat if a ambiguity is possible. eg. a folder with a dot in it.


done


thanks!


Unhandled Fundamental Failure


Теперь наш визард делает то же самое. :)


Based on looking at some of the other hasChanged handlers you might need to defend against a null lastValue_ if you don't default initialize it.


I'll adjust these. Thanks!


I'll add a note to that effect.


94006714-MultipleTowers (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi @Munter, do you have access to that form? :)


Sure,  but why not make that a separate commit?
Atomic changes and all that.


MiscReleaseFixes (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1863 of 1863 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


#4672-AirLoopHVACUnitarySystem-with-heating-coil-but-blank-heating-supply-flow-fields-does-not-heat (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1870 of 1870 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


101917310_waterCoilHumRatFalseWarning (mjwitte) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Commit de prueba


error


For those who are wondering, the 0.0.4 version has been published to npm under a new name:
https://www.npmjs.com/package/passport-localapikey-update

Hopefully the original owner will continue to maintain this project, or give access to others so it can live on (please!)


OK, you are right. I'm forgetting having so many machines here.

On Mon, Sep 14, 2015 at 11:40 PM, mstembera <notifications@github.com>
wrote:

> Testing w/ multiple threads is an inefficient use of resources compared to
> simply increasing the TC.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/IIvec/Stockfish/commit/bf3023f13b50ac02808d51e6e50c29917004defb#commitcomment-13223810>
> .
>

--
IQ World <http://www.ultimaiq.net/>


I'd like to discuss the role of power in determining technologies development. The dichotomy between the two types of papers in the abortion clinic and what it meant for the advantages and disadvantages of semiotic and micropolitical power was really interesting. In this case, the semiotic power seemed to yield to the micropolitical.  And the newer technology was no match for the older. But which dynamic was more important in this case, and will semiotic power always yield to micropolitical in practice?


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (lgu1234) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


#4672-AirLoopHVACUnitarySystem-with-heating-coil-but-blank-heating-supply-flow-fields-does-not-heat (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Delete the deployment from queue when obj is DeletionFinalStateUnknown marker item?


you're right it should be CACHE STRING


These should be left intact with the copyright going to the Foundation.


why this change?


Unhandled Fundamental Failure


yeah, the fix broke more than it fixed.

On Mon, Sep 14, 2015 at 2:28 PM, jaromirdalecky <notifications@github.com>
wrote:

> This has never been fixed. The fix (#2887
> <https://github.com/concrete5/concrete5/pull/2887>) was reverted.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/concrete5/concrete5/commit/ba8061d7fe8da233d8ecb280c3c19d56269730a3#commitcomment-13223506>
> .
>


Please implement this function as two different functions: one  for diag and next one for file/rank (instead of using is_diag_ray). thus we can avoid if branching and can simplify the logic with slide_piece , queen_piece


`#<%= name %>-details`?


Great... I tried it on IE8 to confirm, and it seems to be working pretty well.  The only IE8 specific quirk I saw was a line under the selected tab label.  But I wouldn't worry about it, since IE8 is EOL in January 2016.

I also noticed (unrelatedly) that the editor icons (at least the ones for numbered and unnumbered lists) aren't mirrored in RTL mode.  Presumably they should be.


@jmchilton Stray print statement, invalid Python 3 syntax - thus explaining the TravisCI failure

I try to write ``print(...)`` which will work on both Python 2 and 3 for simple usage.


It makes them easier to change if necessary.

```swift
var representor = ...
representor.transitions["self"] = ...
```


MiscReleaseFixes (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Do we want to restrict the scope of this body with the `.` notation? Just to avoid conflict in names, because our adaptivejs scaffolding selects <body> and names it 'body' too.


In SL, most browsers including Chrome consistently time out on this test


We haven't fixed it yet :)

--

*José Valim*
www.plataformatec.com.br
Skype: jv.ptec
Founder and Director of R&D


Again? I think this is not required, you already apply this filter on `module_template.eex`, right?


Can this file have a comment in it about PBS_DIR? It's confusing as written as there is no hint as to whether it's really important for this env var to be set and what you gain by having it.


So why does the eventName field does not have javadoc style comment ?


Cool but how can i add/refresh this?


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1332 of 1332 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Keep in mind the launcher is not included in the nightly builds, so if you want me to take a look at it you'd have to share it somehow.


and `DYLD_LIBRARY_PATH` is missing.


Hmm. It's there to provide chroma info, not luma. Or is that the wrong way to go about it?


The tracker is not source controlled, it's a discussion and reporting forum. Basically you don't want to add things to a repo that aren't directly related to the code/assets/building/etc of the project.


There's a PR open for it: https://github.com/swannodette/delimc/pull/9


**HTTP [404] Not Found** — слишком длинная надпись.
Заменил иконкой с пояснением в 'title'.
То же самое с надписью `Closed` для закрытых тредов.


Please revert this.


What happens when a module only have a functions and macros, but no types or callbacks? In those cases the summary is gone, right?


Well as it is it just sets the status to "Active" which doesn't really change much.


on RPI2, `target_architecture()` returns `armv6` despite it is `armv7`.
I think it will return `armv7` if we compile the small code snippet with `-march=armv7-a` option.
I'm not an expert of compiler flag but I think we can compile without this flag and the binary could run both on RPi and RPi2.
At least, I have the experience of building a binary that works on both RPi versions.


Wasn't always catching the error caused by the z-index date validation routine.


fixed in 0466039


Больше сжатия богу сжатия!


Why is there so much red here? What happened? Are these line endings?


Doing it now is "free" diff-wise. But it's not a great improvement for later and other people have been repeating the same question in #6672, so I'm fine leaving the method for now.


I fudged up.


Just a heads up, from memory (its fuzzy as it was a while ago!) we hit an issue where the buildId counter reset (or looped back around) and we had issues with this type of ordering.  We were running in the order of 70k+ builds per month though, with some weekends logging 100k+, so we churned through them.  Also, this was back in TC6 days.  Not sure if this issue holds, just though I would mention it!


101917310_waterCoilHumRatFalseWarning (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1869 of 1869 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


> a folder with a dot in it

We don't know if it's a folder until after we stat (that's why we stat).

And every filename here will always have a dot in it (or in more general terms, will always match the inputFiles patterns). If it didn't, it would already have been filtered out.


I followed processing-sound notice

https://github.com/processing/processing-sound/blob/master/src/processing/sound/AudioIn.java


En este commit se ha reducido la complejidad del loggin.
Evito la actividad LoginActivity añadiendo el código que lanza la autenticación (para usar la lib de Evernote) en LoginChecker.Java, y por tanto la primera actividad que aparece es para que el usuario introduzca sus credenciales


File should have the same name as the skill.


Spaces everywhere.


`skill.Stack`?


@thenickcox ack! whoops. But it looks like *that* doesn't get called from anywhere. I can't find any references to setrole.


The longs are the location. You should actually check this, since people can otherwise throw the dice out of the allowed range.


SkillCancel is sent automatically.


Может обе эти строки перенести в `favIcoBlink`? Т.е. сделать так:
```js
function favIcoBlink(isEmpty) {
    var base64 = isEmpty ? 'azaza' : 'ololo';
    ...
```
а тут оставить `setInterval(() => favIcoBlink(true), 800);`.


Fun fact- You can trigger a new travis build by going to travis.ci website and rerunning any particular commit hash.


No, since the queue only stores the names, and if it's not found during processing it will just log and continue.


And I'm the boss ;)


Right, I agree


Forgot it indeed! I've pushed a commit with updated translations, thanks! :)
This should be good to release a public new version now.


As per the code in deleteRC above, I believe we only enqueue deployment objects, otherwise we don't call enqueueDeployment. LMK if that's not right.


hiya @jfiser and @jhritsik -- I am using an older version of SlideShow.js here but I wanted to flag that there does seem to be a bug where it always places the captions/arrows of inline galleries based on the height of picture 0, not the current picture. So if you have an inline gallery w/ a mix of aspect ratios, the caption/arrow bars never get moved.


we need to Finalize() before we exit the program.


I thought that is what attrs is for, but updated to an isolated scope as that certainly seems like the better option.


TeamCity pull requests :: netty [Build 200](https://garage.netty.io/teamcity/viewLog.html?buildId=1328&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5600, ignored: 21 Build time: 01:13:39


TeamCity pull requests :: netty [Build 203](https://garage.netty.io/teamcity/viewLog.html?buildId=1331&buildTypeId=pulls_netty&guest=1) is now running


develop (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


this replaces jquery.visible.js


only handle keypresses if the gallery is visible--this allows you to use more than one in a doc w/o it going craycray


Good suggestion. Mind submitting a PR? :)


How can you validate if profile is not connected to the user? Profile -> user_id is required.


when user changes slides, see if new aspect ratio requires arrow/caption repositioning


please rename these functions to
init_rank_pin_info
init_file_pin_info etc.


Hi mstembera,

I'm having difficulties with compiling and creating SPSA test.
I'm compiling outside GitHub terminal, because compiling inside it always
crashes on my machine.

It also says that TUNE is not declared and I can't run this command:
git fetch official-stockfish tune:my_tuning_branch

Also, why modern version for SPSA tests, and regular x64 for standard tests?

Can you give me some hints.
I'm trying to follow official rules:
https://github.com/glinscott/fishtest/wiki/Creating-my-first-test

Best regards,
Ivan

On Mon, Sep 14, 2015 at 11:40 PM, mstembera <notifications@github.com>
wrote:

> Testing w/ multiple threads is an inefficient use of resources compared to
> simply increasing the TC.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/IIvec/Stockfish/commit/bf3023f13b50ac02808d51e6e50c29917004defb#commitcomment-13223810>
> .
>

--
IQ World <http://www.ultimaiq.net/>


rename these to get_rank_pin_info, get_file_pin_info etc.


Thanks for catching that. I will add this hash to the list to PR to 2.x.


No probs. I'm using rootPath for relative URLs so unix style paths are preferred in my case.

Most node and cmd line file operations on windows seem to cope with the slashes either way so it's probably ok if anyone were to use the unix paths.


this only evaluates to true if all are empt and then we don't show the whole block. In each section we check if that particar set is empty and do not render that


Good catch, thanks! I just added the null check. https://github.com/rstudio/rstudio/commit/9285192a45239bf46346a5f7e042feba5d8a82b1


GLuint, perhaps?


no, the other is only all combined, see above comment


does `@renderer` need to be used twice here?


Since we have not made the decision to remove btl/sm from 2.x can you PR this over there?


This constant is now defined in 2 spots instead of being defined and imported from a single file. This will lead to errors if one value is modified and not the other (for example, it is also used in `test_sensor_data_classification.py`)

Consider making TEST_PARTITION_NAME public instead. That way it can be removed from `sensor_data_exp_settings.py`. Then we can `import TEST_PARTITION_NAME from classification_network` in `test_sensor_data_classification.py`

Or just leave it in a config file.


101917310_waterCoilHumRatFalseWarning (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1335 of 1335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


Why would you put it INSIDE the scheduler? Create a process for it?


I have problems with compiling this, and also with following SPSA rules from
https://github.com/glinscott/fishtest/wiki/Creating-my-first-test

Standard tests seems much more easier to create. Any hints?

Thank you,
Ivan

On Mon, Sep 14, 2015 at 10:52 PM, absimaldata <notifications@github.com>
wrote:

> To use SPSA here, just
> 1. Remove the const qualifier and assign values to variable
> So it will be like
>
> double a=0.83, b=3.488, c=0.47, d=4.76;
> double K[][2] = {{ a, b }, { c, d }};
>
> TUNE(a, b ,c ,d);
> or just TUNE(c, d) if you want to tune c and d only.
>
> Go for SPSA test, 30+.05 TC
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/IIvec/Stockfish/commit/afd334590ca6b2d36a2eb7964d2ffa3b66c27aa4#commitcomment-13222845>
> .
>

--
IQ World <http://www.ultimaiq.net/>


Remove priority here, rdo kilo should only be a fallback if dep isn't in either Fedora or liberty-testing Copr.


No idea how the original handled this, but it didn't stop the script. Maybe
it was creating some unstability though.
Thanks for the tip, I'll set this to 0 then...

2015-09-14 8:19 GMT+02:00 Marc Zinnschlag <notifications@github.com>:

> That's kinda interesting. Where is the difference to vanilla MW here? The
> running the script multiple times or the handling of multiple message boxes?
>
> btw. you should set mInterMessageBoxe to 0 after deleting it. Otherwise
> the code is not exception-safe.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zelurker/openmw/commit/4e458ae72bdee7a06fa4047469338cdafae06a3b#commitcomment-13205615>
> .
>


Ah, found it. But code tag is not just a style. Didn't take that style select list serious but it produces the code-tag for the "computer code"-style.

Users unknownly produce horribly garbage html when they are allowed to use htmleditors on a cms. I know that as freetimeadmin of a amateur sportclub website. They just copy&paste from word or from whatever then mix everything around trying to fix the look like it was in their word then wondered why it doesn't look right on the frontpage.

![ckeditor_flyspray_usability](https://cloud.githubusercontent.com/assets/1839154/9863058/251adb4c-5b3d-11e5-8a04-425f950f7ba7.png)


it is common practice to add comments on function declaration (not definition).
E.g. when you develop library you sell binary code with header files, and header files contain all the comments as documentation.
But for us, I think it is okay to keep it in .cc files


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 620](https://teamcity.labkey.org/viewLog.html?buildId=272036&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 32, passed: 9 Build time: 00:26:47
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

##### there are 22 more failed tests, see build details
```


Fixed by CSS modification.


We use `__` to separate layers rather than `.`.


Some merge conflict here.


@benzonico case, which wasn't tested and which is most likely not covered by current implementation:
```
while (condition) {
  int x = 0;
  use(x);
  x = 1;
  // "x" should not be live here
}
```


Makes sense to me - adding in a destroy bind to remove the element.


Oops, I replied without checking the code, setting mInterMessageBoxe is
useless, it's initialized with a new messagebox just after that.

2015-09-15 0:12 GMT+02:00 Emmanuel Anne <emmanuel.anne@gmail.com>:

> No idea how the original handled this, but it didn't stop the script.
> Maybe it was creating some unstability though.
> Thanks for the tip, I'll set this to 0 then...
>
>
> 2015-09-14 8:19 GMT+02:00 Marc Zinnschlag <notifications@github.com>:
>
>> That's kinda interesting. Where is the difference to vanilla MW here? The
>> running the script multiple times or the handling of multiple message boxes?
>>
>> btw. you should set mInterMessageBoxe to 0 after deleting it. Otherwise
>> the code is not exception-safe.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/zelurker/openmw/commit/4e458ae72bdee7a06fa4047469338cdafae06a3b#commitcomment-13205615>
>> .
>>
>
>


TeamCity pull requests :: netty [Build 202](https://garage.netty.io/teamcity/viewLog.html?buildId=1330&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5600, ignored: 21 Build time: 00:36:05


TeamCity pull requests :: netty [Build 204](https://garage.netty.io/teamcity/viewLog.html?buildId=1341&buildTypeId=pulls_netty&guest=1) is now running


Kindly correct the path.


I think I got this one in the next commit.


Not a typo. The record number is 0x07, and those records must have their LENGTH multiplied by 0x27.
http://www.uesp.net/wiki/Daggerfall:SaveTree.Dat#RecordType_enumeration
http://www.uesp.net/wiki/Daggerfall:SaveTree.Dat#RecordBase_structure


@benzonico actually might be better to use explicit check with throw instead of assert - see http://docs.oracle.com/javase/7/docs/technotes/guides/language/assert.html


Ok, well I can test the scenario on windows in better detail tomorrow, but I don't see the harm in merging this PR now, which simply makes the regular expression more robust.


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1869 of 1869 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Given that I can see a table relating students to their grades on each criteria


OK, I added a Context.addReverseDependency and split out a findMatchingVariant helper -- it's a small (but useful) portion of addDependency, since all the error messages still need to be customized.


@asterite missing something or this example is a dup from the one above? (no pun intended against *twice* in example description)


function name should be action (verb). you can rename it to set_rank_pin_info() (if this function only for rank, i don't understand the logic quite well, seems it is also used in init_pin_pos_board_a1h8 function)


to their grades


oja ;) .. grober Schnitzer ;)


Mm, not sure about that. I think a constant is more clear in this case, but I don't care much.


I use singular names everywhere so I wouldn’t really mind removing the inflector. I don't like the verbosity much but I guess I can just add something like `get_class($this)` in the BaseRepo.

Putting it in the annotation would be a clean compromise so I am all for it.


http://github.com/RubyFreedom/RubyFreedomMod/

Remember the old repo that you forgot to delete? Well that is still here.


If `begin(r)` and `end(r)` are valid expressions, then `begin(r)` is guaranteed to model `Iterator` and `end(r)` to model `Sentinel<decltype(begin(r))>`. Since `Sentinel` requires `EqualityComparable`, it's redundant here to require `==` and conversion to `bool`.


@benzonico we can check invariant here - "in" set for entry block and "out" set for exit block should be empty, and unlikely that test explained below will pass this invariant


one of the sections


please rename these to _rank_pin_info, _file_pin_info etc


I'm actually confused, why a directory even ends up in this list..


Fixed by 30174988cd9bb9f5ff21d7063e43811bc882463e and version 2.0.4.
@adrai thanks for the suggestion, I appreciate it.


var cl=m._cl[l.VKBUR]={};m.clickL(l,fromMap);
두가지 소스들이 큰 문제가 있어서 의도하신 로직으로 구현되도록 대폭 수정했습니다.


small_square_slide -> small_sliding_piece_pos
big_square_slide -> big_sliding_piece_pos


Is it possible to skip images containing `srcset` in this line? I'll need some assistance here, regexp is one of those things that happen to other people.


Yes.
Am 14.09.2015 21:39 schrieb "Michael Aufreiter" <notifications@github.com>:

> But then also move name into static? And displayName. No magic anymore... ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/substance/substance/commit/75a4358f34fc01e9dcd0ed57f75dbccd790db52a#commitcomment-13220188>
> .
>


Tru dat! Thanks for letting me know and keep up the stellar work! I am
using your Euphoria CAF build now!

Kind Regards,
Zachariah Kennedy

On Mon, Sep 14, 2015 at 2:14 PM, AK <notifications@github.com> wrote:

> Because i'm building now also ROMs ... so sometimes a wipe of cache is
> welcome! [image: :+1:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/anarkia1976/AK-OnePlusOne-CAF/commit/3b124cc8a1adfcead6a187961f6c396012267972#commitcomment-13220858>
> .
>


Oops. Curse you copy paste!


This line is causing GUI components to fail...


Document that this searches group for a module with the same variant as module, and returns that module.


@jgreben is this ready for a PR?
@azaroth42  is it ok for the code for grabbing the recs from LC to be posted?


Currently, the docs are updated but the code isn't.
Also, Google has a new flow now, where you can ask for offline access and automatically redirect the response with (containing the auth code) to your own server: https://developers.google.com/identity/sign-in/web/server-side-flow


np:) Thanks for sharing your code!


Fishtest does the compiling for your test.    You only have to compile locally for your own purposes.  If you are talking about a tuning session using TUNE then read
https://groups.google.com/forum/?fromgroups=#!searchin/fishcooking/tune$20marco/fishcooking/WIHeOEzrDq8/Q3vch2a9vEQJ


okay got the idea (we pass rotated boards for diag)


> No, you cannot have general interface doing doFetch(value) and then doSave(newValue)

You can with transactions. ;) But I see what you mean. I guess the problem is that not all cache drivers offer "increment" which is why it could not be used generally.


>target_architecture() returns armv6 despite it is armv7

Yea, that's the question, why so? It's better to change this in  `dev/cmake/TargetArch.cmake` directly rather than expose workarounds for it to OF.


Или все-таки лучше

```js
setInterval(() => favIcoBlink(false), 800)
```

Может, во всем скрипте такие замены сделать?


worst


About the issue, I detected some more architectural issues which I will try to adress in a PR or an proposal to change the design which will also cover this.


#4672-AirLoopHVACUnitarySystem-with-heating-coil-but-blank-heating-supply-flow-fields-does-not-heat (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (800 of 800 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.29%25-green.svg)


Хрен его знает. Мне без разницы.


It will be even better if we can find another way of detecting RPI2 than pulling someone's .cmake file to detect all possible platforms. We have specific platform here, let's make it a specific exception rather than general approach for all arm devices out there.


added bitdeli batch


A entrega satisfaz todos os itens do checklist.


Download the latest once it is avaiable:

```
dependencies {
    compile 'com.github.sundeepk:compact-calendar-view:1.7.5'
}
```


Done


AWESOME!!!!


@hadley checking in the tex in 9baf8c45d9d85edb1f12dc463e9de4f4429be8ab broke the make recipe, so here is a quick "fix".

(I don't see the benefit of having the tex without the figures, but I'll let you decide on a more permanent fix)


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 61](http://teamcity.otenv.com/viewLog.html?buildId=1508811&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 62](http://teamcity.otenv.com/viewLog.html?buildId=1508812&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


actually, perhaps suggestion 1 could be better expressed as:

    importedComponent->setName("component_in_this_model");
    importedComponent->setSource("some-other-model.xml", "a_component_in_that_model");

and we could then add an extra option to the `setSource` method to determine when a new import is being defined vs reusing an existing import. e.g., maybe something like:

    importedComponentTwo->setName("a_different_component");
    importedComponentTwo->setSource(importedComponent, "that_other_component");

for any option, I don't think it is important to be able to load the model from the specified URL when creating the imported component. A relative URL can't be resolved until `this` model is serialised to a location on disk. We could try and be fancy and work with model objects, like suggestion 2, and then resolve relative URLs on serialisation. Not sure how much work that would be, but it could be a nice feature for users.

If I understand your last comment and that you are really talking about whether a imported model is a different class than a normal model, then the answer is no. Maybe.

Perhaps a suggestion 4 (too lazy to edit the code at the moment, and ignoring namespaces, shared pointers, etc) would be something like:

    Model m;
    Model sourceModel("some-other-model.xml");
    Component sourceComponent = sourceModel.getComponent("a_component_in_that_model");
    Component importedComponent;
    importedComponent->setName("a_component_in_this_model");
    importedComponent->setSource(sourceComponent);

and that would allow imports to be aggregated by using the same instance of the `sourceModel` or distinguished by using different instances of model created from the same source URL.


Don't do this, port it or don't port it, don't clutter the codebase with random comments.


La redirection est à sortir du test conditionnel.


Thanks for the swell pic, dude.


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 61](http://teamcity.otenv.com/viewLog.html?buildId=1508811&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


CC: @marcelinkaaa


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20666/testReport/) for this commit**


hello


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 62](http://teamcity.otenv.com/viewLog.html?buildId=1508812&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


Deveria ser algo como: Then I can see all notifications


oh i see


and now?


I had to add "os" to the import section in order to get it to compile.
import (
    "os"
)


ut ACK (reviewed).


please correct this line of comment
(left_board and right_board are Bitboards where the position for the pinned piece to be located)
e.g.
in left_board and right_board Bitboards position of pinned pieces are stored and ...


concept ACK (slightly reviewed)


PropTypes.bool?


Thanks for testing that @wkeese.

> I also noticed (unrelatedly) that the editor icons (at least the ones for numbered and unnumbered lists) aren't mirrored in RTL mode. Presumably they should be.

Will address this.


BS bro, BS


OT but I noticed you manage the package for [ua-parser](https://pypi.python.org/pypi/ua-parser).
It's been bumped bumped to consume uap-core 0.5.0.


Fair enough.  We understand the issue of scale.  I'll talk my machine learning teammates and see what scale of models we have for some of our samples.  I guess then the converse question is for the smaller cases if there a burden caused by this caching?  However, that question is something we'll worry about on our end.  Thanks for your time and detailed explanation.


@hjelmn I'll probably need to do it as you don't have write permissions into my branch :-)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20667/testReport/) for this commit**


работаем


Why is this sleep required? After cluster stabilization (part of `bdp_util:build_cluster/1`), there's nothing left to wait for.

Secondly, your `start_services/2` will already have called `bdp:wait_services/2`, which ensures the Service Manager has arrived at the desired state.


The call to `bdp_util:wait_services/2`is redundant here (this function is called at the end of `:add_service/4`).


I'm may not send strictly a boolean for the condition:
` <If condition={hoverData.label}>`


Double 'e' in function call. This would have broken the test before it could start.


TeamCity pull requests :: netty [Build 204](https://garage.netty.io/teamcity/viewLog.html?buildId=1341&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5599, ignored: 21 Build time: 00:36:03


Can we use `parseInt(diffIndex[i].split(' ')[3]) > 0` here?


101917310_waterCoilHumRatFalseWarning (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (799 of 799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.28%25-green.svg)


This still doesnt address the case where oldPod is nil, but newPod is non-nil


Hi mstembera,

For running a test I need a test signature, and I get it by  ./stockfish bench, and for that I need to compile my changes. Am I missing something?


hello @jpchaufan


If you follow [these instructions](https://pkp.sfu.ca/wiki/index.php?title=Github_Documentation_for_PKP_Contributors#PKP_library_submodule_changes) you'll get Javascript linting of your lib/pkp submodule changes to boot. It's really easy to make JSLint unhappy (hey, JSLint, it's not me, it's you) so this is pretty much necessary in order to avoid breaking master upon merging.


Check for whitespace on both sides.


Please verify that the `riak-test -m bdp_start_worker` builds and completes on your local setup before pushing :}


I have some idea to make it a little faster, let me know what you think.

At the beginning of this function we could check if move.from is NOT in the same rank, file or diag we return false immediately.  To implement this checking at the start time we need to keep/initialize for each square it's all rank,file and diag bits and just and (&) it here


What kind of test coverage do we currently have in the app?


Ah thanks - at this point the tex is useful without the figures as it lets me see exactly what's changing in the output tex


Ah ok, so node-walk-sync returns dir (I didn't realize) But for our use-case, dir are never needed. So disabling that seems like a win.


JSLint is going to complain that you haven't prefixed this with `_`, as it's `@private`.


#4672-AirLoopHVACUnitarySystem-with-heating-coil-but-blank-heating-supply-flow-fields-does-not-heat (rraustad) - x86_64-MacOS-10.9-clang: OK (1864 of 1864 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Do these have to be expressions?


This seems like a good place for a property.


Oops. I didn't notice that. Can you do this? I just am not sure if I have
full access to those api.krypt.int related things.
On Sep 14, 2015 11:22 AM, "Robin Zhang" <notifications@github.com> wrote:

> Not all of JNIMapper is complete - there are several signatures to be
> updated (i.e. # of args).
> Corresponding usage in the JUnit tests and KEngine.java in krypto-api need
> to be updated as well.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kryptnostic/krypto/commit/5a956395f5af89fee4a809864e731cd3e6227151#commitcomment-13219758>
> .
>


I feel like it might not be necessary to assign the word's length to its own variable.  I mean, I guess it's just a personal preference kind of thing but you only need to use the word.length() two times.


When did Github start showing Commit comments in their Pull Requests?! That's why I always said no commit comments because they were lost from the PR.  I guess I stand corrected.
![my bad](http://cdn0.sbnation.com/imported_assets/1590893/BmcF0wm_medium.gif)


bnbnnbnb


>     #define uint UINT

Not needed, at least not with the compiles I did on Win7/MSVC 2013; removed in 2548affaea4494af909b0da699ffa96f21db4c78.


Darn it... didn't get the original author attribution. Sorry about that


I'd prefer not to, as this is a RAM limit; if the max block size is increased the RAM limit should stay the same.


No this is not the case and I did remove it in a later commit as part of this pull request—please refer to the full set of changes.

This did get me thinking, since pm2 uses the name of the main .js file, in this case app.js, as the process name, we should probably change it to something more descriptive, say harvester.js
If you're happy I will make that change and the corresponding changes to the documentation and commit in this branch.


Correct. I'm not an expert on the tuning branch.  I would post whatever problems you are having with it to the thread I linked above.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2311 of 2344 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.59%25-yellow.svg)


Merge branch 9/14/2015


What do you mean that isn't an extension? It states it right here
https://gcc.gnu.org/onlinedocs/gcc-5.2.0/gcc/Variable-Length.html#Variable-Length
compiling with the -pedantic also tell you this.


r+


Wait.. this was breaking the feed? Or something else?

I fixed something v. similar in the podcast feed when I worked on that. Suspect the iTunes portions of the main feed could be the real issue (and they aren't needed there anyway)...


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/37e931c08512092c5a27f74ab1aa608132ce0478


merging MonsieurNicolas/stellar-core/fixManageOfferPrice = 37e931c0 into auto


MonsieurNicolas/stellar-core/fixManageOfferPrice = 37e931c0 merged ok, testing candidate = 072359f2


This makes it compile, but I get runtime errors:

PSIO_ERROR: Can't find TOC Entry t

To confirm that this is due to this change, if I change the above second argument from "t" to this->T2_distarray4(spincase2,"x"), I get:

PSIO_ERROR: Can't find TOC Entry x


No line needs to be added to package.json as pm2 is not a required package—it's not used anywhere in the code. It's an optional completely separate system for process management.


Btw why do we have to reconstruct the error ? Because it complains about extra fields ?


Notice what happens if you set -maxmempool=0...


@jgreben sorry - I meant to do this in a separate branch and do a PR to your branch.  Anyway, here is how I did it:

for zs elements at the beginning:

```bash
sed -i '' 's/<zs:searchRetrieveResponse xmlns:zs="http:\/\/docs.oasis-open.org\/ns\/search-ws\/sruResponse"><zs:numberOfRecords>1<\/zs:numberOfRecords><zs:records><zs:record><zs:recordSchema>marcxml<\/zs:recordSchema><zs:recordXMLEscaping>xml<\/zs:recordXMLEscaping><zs:recordData>//g' spec/fixtures/loc/m2b-*/*/*.marcxml
```

for zs elements at the end:

```bash
sed -i '' 's/<\/zs:recordData><zs:recordPosition>1<\/zs:recordPosition><\/zs:record><\/zs:records><zs:echoedSearchRetrieveRequest><zs:version>2.0<\/zs:version><zs:query>rec.id=........<\/zs:query><zs:maximumRecords>1<\/zs:maximumRecords><zs:recordXMLEscaping>xml<\/zs:recordXMLEscaping><zs:recordSchema>marcxml<\/zs:recordSchema><\/zs:echoedSearchRetrieveRequest><\/zs:searchRetrieveResponse>//g' spec/fixtures/loc/m2b-*/*/*.marcxml
```


file system issues locally.  might be breaking commit.


Walk sync returns dirs with a trailing slash.


XXE and XEE vulnerability in this line of code.


Doctrine backup files should always be gitignored.


mr发了 #11

顺便把preview改成了一个color的input，在mac下可以调用系统识色板。


XXE and XEE vulnerability checked in this line of code.


FDGroundTempModelBugFix (mmatts) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


А что не так с Linux? Часть написана на чистом си, причём, планировалась портируемость на Linux, надеюсь она сохранится после того как я завершу правки кода связанные с переходом на индексы. Что касается C# на моно он вполне хорошо работает на линуксе. Для задач этой БД (учитывая что я не использую сборщик мусора) вполне подходит. Скажем так можно было и на С++ написать. Но мне C# ближе. Позднее возможно перепишу.


#4672-AirLoopHVACUnitarySystem-with-heating-coil-but-blank-heating-supply-flow-fields-does-not-heat (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1870 of 1870 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


(Thanks, I see where this is registered as a hook, but the register function looks like it's commented out.)


XXE and XEE vulnerability


I only want to kick the Go routine if it has not already a "kick" waiting for it..


nice idea! I wasn't thinking of this being a getter/setter, but this will make it easier to customize plugin-style!


Unhandled Fundamental Failure


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 621](https://teamcity.labkey.org/viewLog.html?buildId=272053&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 32 (2 new), passed: 9 Build time: 00:23:44
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

##### there are 22 more failed tests, see build details
```


gnu extension


client-side assets in /web should also always be gitignored.


External doctype resolution via XML. Please turn off Doctype support.


Thanks for your PR, appreciate it. Merging now


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 64](http://teamcity.otenv.com/viewLog.html?buildId=1508839&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 63](http://teamcity.otenv.com/viewLog.html?buildId=1508838&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 65](http://teamcity.otenv.com/viewLog.html?buildId=1508840&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


boolean CREATION - этого парметра быть не должно здесь


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 63](http://teamcity.otenv.com/viewLog.html?buildId=1508838&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 64](http://teamcity.otenv.com/viewLog.html?buildId=1508839&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 65](http://teamcity.otenv.com/viewLog.html?buildId=1508840&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


Add mustMatch check logic in GetConfigServerUrl(string uri).
Add constructors in ServerUrl class.


In a devrel setup, all nodes will have the same physical location on the local file system for the dets file. Including `node()` in file name (for example) could help.


boolean mODIFICATION2 - удалить 3-й параметр


удалить - boolean mODIFICATION2


The other fun one, is GetArg() interprets -1 as maxint... Which appears to work as expected, but still!


I can do this, although I think @makosblade will handle this later.


Это лишнее. В каждом методе выше итак есть rebuildCache();, это обнуление кеша излишнее.


не стоит во всех методах в конце писать return this. Если что-то не используем то и не пишем.


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (rraustad) - i386-Windows-7-VisualStudio-12: OK (1868 of 1870 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


TeamCity pull requests :: netty [Build 203](https://garage.netty.io/teamcity/viewLog.html?buildId=1331&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5599, ignored: 21 Build time: 01:11:15


Yeah, I'll handle the jni updates

On Mon, Sep 14, 2015 at 4:16 PM, Robin Zhang <notifications@github.com>
wrote:

> I can do this, although I think @makosblade
> <https://github.com/makosblade> will handle this later.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kryptnostic/krypto/commit/5a956395f5af89fee4a809864e731cd3e6227151#commitcomment-13225547>
> .
>


@rhiannonlynne @ivezic @mjuric @stevechesley

1. I found out that you use obscode=807 for LSST simulations, however, I used I33 (which is Cerro Pachon). We should use the same obscode. Why do you chose 807? I thought LSST is built atop of Cerro Pachon?

2. Even when I use 807, I get very similar discrepancies in RA and DEC between our results, see figures:

![compare_lsst1](https://cloud.githubusercontent.com/assets/13923689/9864145/513c6930-5afb-11e5-82db-565dfb71fe30.jpg)
![compare_lsst2](https://cloud.githubusercontent.com/assets/13923689/9864148/542ea540-5afb-11e5-94bd-2dc8717d7cc1.jpg)

We think that ~0.5 arcsec differences are too much, and also there is a systematic offset (the peak is 0.56", 0.35" of the 0,0 in RA and DEC

3. In OpenOrb and MaF:
- what do you use for planetary ephemerides? de405?
- how many perturbers? We use all planets + Pluto, Ceres, Pallas, Vesta.


S


конструкция if не нужна. Сразу пишем return условия


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (rraustad) - x86_64-MacOS-10.9-clang: OK (1862 of 1864 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


XXE, XEE vulnerability.


So [here0](https://github.com/WikiEducationFoundation/WikiEduDashboard/commit/478dea25f0365869e18e65193a593e7c6c292791#diff-21497849d8f00507c9c8dcaf6288b136R51) is the commit that introduced it, but even on that commit, it isn't used. Which makes me feel like I'm missing something. But perhaps he added it in anticipation of it being used in the future. You have more context than I into what he was writing at that time.


Injecting whole container is a bad practice and should be avoided.


XXE, XEE vulnerability


5.x firm w/ 4.x-MSET
7.x-8.x and 9.0-9.2 firm w/ 6.x-MSET are also supported.


I think a bunch of necessary packages got removed by accident during the upgrade.


it is better to send the ServerURL object back with real uri string as url properties instead of empty string. and also clean this PR


`resource.get(field_name)` should already return `None` if `field_name` isn't found. Would this work better than the ternary? `return encoding.force_text(resource.get(field_name, ''))`


Yeah you're right. A simple `Status = Active` should do the trick?


We can't post the source, so I'm not sure that the code that pulls the bib
ids out of the source is useful?
If the script could be abstracted to take a list of bibids and
directories/labels, that might be useful more broadly?

On Mon, Sep 14, 2015 at 3:24 PM, Naomi Dushay <notifications@github.com>
wrote:

> @jgreben <https://github.com/jgreben> is this ready for a PR?
> @azaroth42 <https://github.com/azaroth42> is it ok for the code for
> grabbing the recs from LC to be posted?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sul-dlss/marc-to-bibframe-validation/commit/4b347c407df71a3361358e4835f8a45f23ceeac6#commitcomment-13224674>
> .
>

--
Rob Sanderson
Information Standards Advocate
Digital Library Systems and Services
Stanford, CA 94305


Heya @hhuijser, just saw this commit, and thanks for adding it, I have a feeling it will have a great impact on performance :)
I do think there's one area that could be improved in here though, which is the performance of this method.
Right now, you're looping through the log, and individually collecting the file names individually, but you can instead get the list of file names with one git command:

`git diff --stat --name-only --diff-filter=ACMRTUXB master..head`

`git diff` with the `stat` and `name-only` will give you what you need (all paths will be relative to the root of the git repo), but the `diff-filter` option probably needs some explaining.
Basically, we need that in there so that it doesn't list files that have been deleted to be checked, but what it will list are the following:
```
A (Added)
C (Copied)
M (Modified)
R (Renamed)
T (Type changed, regular file to symlink, etc)
U (Unmerged)
X (Unknown)
B (Broken pairing)
```

Using the command will let you get the list in one go and not have to process it.

There might be other reasons you went with this approach, but just thought I'd mention it :)


This is really a style thing, but it might be cleaner / easier to modify if this was:
```
KEYWORDS = %w(users admin edit create update tags projects rails)
KEYWORD = /#{KEYWORDS.join("|")}/
```


этого параметра быть не должно здесь - boolean CREATION


удалить парамтер - boolean MODIFICATION


Split this up and document _briefly_ in the commit message what/why. One commit for Exception as, one for cosmetics (self.gPatchers ?), one for wx related stuff (more ?) - document especially the wx stuff


не пистаь return this, если не исопльзуете


I fixed the issue here!


удалить обнуление кеша здесь. выше уже явно вызываете rebuildCache();


сразу пишем return условия


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/80340022


Need a better name


This looks much better :+1:


That shouldn't even be necessary, if you leave the status as 'null' then it will default to "Active". That's all handled by the MakeFilter method.


my answers to project Euler


I'm just wondering about the concept of a reference to a pointer.
It seems very convoluted coming from Python.