You have got the effect of the drop caps but inline style like this is bad and more over we can achieve this type of effect in CSS as follows:

    article p:first-of-type:first-letter {
      float: left;
      font-size: 80px;
      line-height: 65px;
      padding-top: 4px;
      padding-right: 8px;
      padding-left: 3px;
      font-weight: 600;
    }


If the command you run in `iex` fails, it can not determine that it is not using the `$lastexitcode`.
So, It has to check both the `$?` and `$lastexitcode`.


Fixes https://github.com/dev-onenetworkecommerce/aia/issues/56


Huh!  I set my clock to Jerusalem time, and you're right - that block was needed.  I'm still baffled as to why the sign of the UTC offset matters, though - a fold occurs when the total UTC offset decreases ("moves to the left on the number line"), regardless of its sign.  Something's fishy here - probably a Windows bug ;-)


Application-Level Smell : Duplicated code
The code is similar level01() class in level01.py


mixed up a local test version with production.  Fixed.


假设现在你现在需要在Android应用中嵌入和解析外部数据，你会怎么做？本文中我们希望嵌入互联网顶级域名列表。你可以在ICANN TLD报告中看到一共有一千多种顶级域名，时不时有新域名的加入，也有旧的域名被废弃。


@fdaciuk correções feitas


Code Smell : Lazy class


Code Smell : Lazy Class Error


@garlicnation can you document this in the readme?


Missing end of line character at the end of the code


Code Smell : FeatureEnvy Class .
The class uses features of the sprite class excessively


Same comment as above.


When the value is 0 you don't need the units, in other words you can remove the `px`


I have a piece of code I've been working on to get the IMyCharacter from IMyPlayer, since the Character property on MyPlayer is MyCharacter, and neither is allowed in API.

`public static IMyCharacter GetCharacter(this IMyPlayer player)`
https://github.com/jpcsupplies/Economy_mod/blob/master/Economy/Data/Scripts/Economy.scripts/Extensions.cs


Again, the correct behavior is the one which you removed.


You don't need git tool. Run `build.bat` in cmd.exe (or powershell.exe) to see the real problem:
Press Win-R, type `cmd.exe`, click OK, execute following commands
```
cd %USERPROFILE%\Desktop\subtitleedit-master
.\build.bat
```


@Jokersoft the requirement to run the skeleton is now PHP 5.5. Please note that existing apps are unaffected by this change.


This whole commit is wrong, discard it.


@akhilnarang it shows an icon for the site lulz


You need to get a little bit more specific with your selectors otherwise ever paragraph on the page will have a drop cap.

you could do so by modifying to the following

    article p:first-of-type:first-letter {
        /* You code as before */
    }


Today I tried out an official nightly build and found that performance is indeed quite bad. It stutters and lags much more than my unofficial builds did, and free RAM is nearly half. The same thing is happening on surnia too. I made a post about this behaviour here: http://forum.xda-developers.com/showpost.php?p=63028834&postcount=384

I'll try to have a standalone kernel build for osprey up tonight.


How'd ya make?
Me taking @anik1199 ’s lol
On Sep 28, 2015 7:23 AM, "srisurya95" <notifications@github.com> wrote:

> @akhilnarang <https://github.com/akhilnarang> it shows an icon for the
> site lulz
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/srisurya95/srisurya95.github.io/commit/171a52846fd07902ff1e5d494700cc706b3cab8c#commitcomment-13460155>
> .
>


Right before the `#include "compiler-range_for.h"` in the includes at the top of the file, add:
```c++
#include "compiler-exchange.h"
```

Then, change the block under discussion:
```diff
-		select_primary_weapon(nullptr, delayed_primary, 1);
-		delayed_primary = -1;
+		select_primary_weapon(nullptr, exchange(delayed_primary, -1), 1);
```


Code Smell : Orphan Variable/Constant Class
contains collection of constants that are used elsewhere


One of the disadvantages of floating left and then right is that when you don't have a container width set you are going to get different results on different screens.  See attached what I see (a large gap down the center).

![relaxr-blog-paris](https://cloud.githubusercontent.com/assets/1712153/10126551/c0507fdc-65d7-11e5-9d1b-7ea1a0a2523d.png)


Something must be wrong with your setup. I just downloaded AnalogMux.ino and the UtilityFunctions.h&cpp files from GitHub and compiled without any errors using Arduino IDE 1.6.1.
I did notice 1 issue when compiling with 1.6.5, however:
With this newer IDE version (it did not exist when the post was written), one line must be changed in the setup():
from:void setup() {  ESP.wdtEnable();
to:void setup() {  ESP.wdtEnable(WDTO_0MS);
From the errors you sent, I am guessing that the ESP8266 files were not installed.
Here is what I suggest you do:
Go to: esp8266/Arduino
|   |
|   |  |   |   |   |   |   |
| esp8266/ArduinoArduino IDE for ESP8266 |
|  |
| View on github.com | Preview by Yahoo |
|  |
|   |

Scroll down to the section
Installing with Boards Manager
and follow the instructions to install Arduino IDE 1.6.5 and the esp8266 platform (last step).

Then, before compiling AnalogMux.ino, make sure you select "Generic ESP8266 Module" from the Tools>board menu in the Arduino IDE.
Hope this corrects your errors.
Dave

      From: qoreyshi <notifications@github.com>
 To: internetofhomethings/ESP8266AnalogMux <ESP8266AnalogMux@noreply.github.com>
Cc: Dave <surfnturf57@yahoo.com>
 Sent: Saturday, September 26, 2015 10:54 PM
 Subject: Re: [ESP8266AnalogMux] Update AnalogMux.ino (8d8e814)

hi
please help,
HOW TO error:
AnalogMux:22: error: variable or field 'killclient' declared void
AnalogMux:22: error: 'WiFiClient' was not declared in this scope
AnalogMux:22: error: expected primary-expression before 'bool'
AnalogMux:44: error: 'IPAddress' does not name a type
AnalogMux:45: error: 'IPAddress' does not name a type
AnalogMux:46: error: 'IPAddress' does not name a type
AnalogMux:59: error: 'WiFiServer' does not name a type
AnalogMux.ino: In function 'void startWIFI()':
AnalogMux:82: error: 'IPAddress' was not declared in this scope
AnalogMux:82: error: expected ;' before 'ip'
AnalogMux:84: error: 'ip' was not declared in this scope
AnalogMux:84: error: 'ipadd' was not declared in this scope
AnalogMux:85: error: 'WiFi' was not declared in this scope
AnalogMux:85: error: 'ipgat' was not declared in this scope
AnalogMux:85: error: 'ipsub' was not declared in this scope
AnalogMux:110: error: 'WiFi' was not declared in this scope
AnalogMux:112: error: 'WL_CONNECTED' was not declared in this scope
AnalogMux:120: error: 'server' was not declared in this scope
AnalogMux.ino: In function 'void readSensorIsr()':
AnalogMux:135: error: 'yield' was not declared in this scope
AnalogMux:221: error: 'ESP' was not declared in this scope
AnalogMux.ino: At global scope:
AnalogMux:246: error: variable or field 'killclient' declared void
AnalogMux:246: error: 'WiFiClient' was not declared in this scope
AnalogMux:246: error: expected primary-expression before 'bool'
AnalogMux.ino: In function 'void sysloop()':
AnalogMux:259: error: 'WiFi' was not declared in this scope
AnalogMux:259: error: 'WL_CONNECTED' was not declared in this scope
AnalogMux:269: error: 'ESP' was not declared in this scope
AnalogMux:289: error: 'WiFiClient' was not declared in this scope
AnalogMux:289: error: expected;' before 'client'
AnalogMux:290: error: 'client' was not declared in this scope
AnalogMux:295: error: 'client' was not declared in this scope
AnalogMux:298: error: 'killclient' was not declared in this scope
AnalogMux:304: error: 'client' was not declared in this scope
AnalogMux:304: error: 'killclient' was not declared in this scope
AnalogMux:309: error: 'ESP' was not declared in this scope
AnalogMux:312: error: 'client' was not declared in this scope
AnalogMux:374: error: ambiguous overload for 'operator=' in 'v = system_get_free_heap_size()'
C:\Program Files\Arduino\hardware\arduino\cores\arduino/WString.h:86: note: candidates are: String& String::operator=(const String&)
C:\Program Files\Arduino\hardware\arduino\cores\arduino/WString.h:87: note: String& String::operator=(const char)
C:\Program Files\Arduino\hardware\arduino\cores\arduino/WString.h:88: note: String& String::operator=(const __FlashStringHelper)
AnalogMux:376: error: ambiguous overload for 'operator=' in 'v = (millis() / 1000ul)'
C:\Program Files\Arduino\hardware\arduino\cores\arduino/WString.h:86: note: candidates are: String& String::operator=(const String&)
C:\Program Files\Arduino\hardware\arduino\cores\arduino/WString.h:87: note: String& String::operator=(const char)
C:\Program Files\Arduino\hardware\arduino\cores\arduino/WString.h:88: note: String& String::operator=(const __FlashStringHelper)
AnalogMux:380: error: 'yield' was not declared in this scope
AnalogMux.ino: In function 'void setup()':
AnalogMux:403: error: 'ESP' was not declared in this scope—
Reply to this email directly or view it on GitHub.


@akhilnarang :3
Favicon generator


This block can be collapsed by use of the ternary operator.


You can also does this on a single line, `return entry if name == entry.name`


sendReminder


daysBeforeExpiration


:red_circle: It is unwise to declare variables without assigning values to them. It would be preferable to assign `null` to the variables to indicate that they're to store the values of properties on the object.


Given you're stubbing the `ages_and_rates` hash, it feels wrong that the assertion isn't checking for the exact value, i.e. `137`, rather than just checking it gets a number back. I think all the tests would pass if the method returned the maximum value for all age ranges above `62`.


Proposes changes.
Customer adds email address and makes the verification email adress.
application processes the email address and once the verification is approved.
Adds email address  to verificate approved  email adress.

VerificateAppovedEmailAdress
____________________________
Id int
VerificateId int
EmailAdressId int

Verificate
________________
id int,
key varchar2(32),
status varchar(20)

EmailAdress
_______________
id int,
idUser int,
address varchar2(100)


:red_circle: The `loadJson` method should be defined as an attribute of the `Index` prototype. All actions on or by the `Index` prototype should be contained within it.


This commit breaks Xcode 6.4. Should we still support 6.4 though?


Ops! You are right, I was sure that the code had notnull validation. Sorry


Summary: known bc break. is documented in php-src, isn't at php.net.
filled bug https://bugs.php.net/bug.php?id=70597


Try to delete all console.log at the time of check in.


Yes


:green_heart: This is an excellent use of regular expressions.


It feels as if there's a lot going on in this commit. I think it would be better to split it up a bit.


Yo no puedo ayudarte mucho a identificar reflexivos, enclíticos,... porque estoy muy verde en temas de lengua, para eso tenemos a gente que sabe mucho más y seguro que entre todos lográis identificarlos adecuadamente.

----

Que yo sepa no hay reglas para escribir tests (cada uno tiene su código de estilo y tiene que sentirse cómodo con él).  Yo personalmente prefiero ver ```self.assertEqual(suma(2, 3), 5)``` que ```self.assertEqual(self.result, 5)```. En el primer caso veo explícitos los valores y entiendo mejor el test (estoy probando una función de suma) que en el segundo caso donde no tengo muy claro de dónde viene ```result```.

... pero a lo mejor en algún caso es más claro hacerlo de otra forma.

----

Tienes razón en que definir el producto final es importante (y muy díficil). No obstante yo no pensaría en el usuario sino en el programador que va a utilizar ese código. Después el programador se lo podrá mostrar al usuario como sea más conveniente. Es lo mismo que en las APIs, el objetivo es que la función devuelva datos estructurados que pueda interpretar un ordenador.

Tiro la primera apuesta, una salida de este tipo (la expreso como json):

```
{
  "palabra": "diselo",
  "results": [
    {  "verb": "decir",
       "objeto indirecto": "se",
       "objeto directo": "lo" },
    { ... ¿la respuesta siempre es única? ¿puede haber ambiguedad? }
  ]
}
```

o a lo mejor necesitamos más información sobre los complementes, algo como:

```
{
  "palabra": "cometele",
  "results": [
    {  "verbo": "comer",
       "objeto indirecto": {"enclitico": "te", },   # ¿esto sería de reflexivo?
       "objeto directo": {"enclitico": "le", "warning": "leismo" },
    { ... ¿la respuesta siempre es única? ¿puede haber ambiguedad? }
  ]
}
```

Se me ocurre, pero quizá lo que hay que hacer es preguntar a la gente qué respuestas espera/necesita y tratar de codificarlas de la mejor manera posible.


DAFAQ did I just see? :o


Looks sane to me - you can run it with build.conf and the tahrpup configuration to make sure it's sane. I made sure the defaults in testing produce the tahrpup kernel, but with a newer minor version.


If you read Dominic's review, he suggested setting the task to never run on schedule: period = 0
Instead it should be run whenever a new alert or info segment is approved
We could use the same approach for Notify here too.
I think this makes sense for this Alerts-based system


tries to fix #28


a comment about `replicaID` would be good (i.e. when is it zero).


:yellow_heart: This method could be made robust by storing the `filePath` in the `this.file` property. This way, the `Index` object can handle different indexes. This can be implemented like so:

```javascript
if (jsonPath === this.file[jsonPath]) {
  return this.index[jsonPath];
}
```


Congratulations!


Such operations are usually named "get" and "put".


FYI, sysfs interface can be found at /sys/bus/i2c/drivers/tfa9890
There should be a couple folders there, one for each amp.


Hi Tonni, that's good to hear. Please understand I'm a bit reluctant to hand over everything to a commerical entity. Have you guys (perhaps under a different user) contributed to the project before? Could you sketch out your plans or patches in general and especialy concerning 1.9 .. 2.x compatibility concerning byte/string handling?


Will do


This is part of the rwd package only!


Was this check also used in the old image reader?


@vilchik-elena I don't think so, my understanding is that NewPHPGrammar.NAMESPACE_NAME() should handle it (See https://github.com/SonarCommunity/sonar-php/blob/1ae853ebe67630c6c0b36b0b2d7a97c0563dfdf0/php-frontend/src/main/java/org/sonar/php/parser/NewPHPGrammar.java#L140). It should be the same than for CATCH_BLOCK.


Probably based on scraping the site by Anand Mishra - not probably, but for sure, because I did it myself, the scraping part.


顶~


ok


Does this affect both image reader?


Thanks!


Did not touched this piece. It seems like someone used exactly `style &` due performance.
See the comment above the code - *optimization call Style once and work with that rather than calling HasStyle a number of times*


noob? ;)


det her var ræva


No it doesn't. The default Image Reader can only read files which were selected by a dialog i.e. only local files.


better use pytest markers for that: https://pytest.org/latest/example/markers.html


通过io的形式获取body提交过来的数据


IMHO this sounds better:
In case of unlinking an opened file its inode will not be freed because "open"
increased inode's reference counter and added it to *tree map* of opened inodes:


On 09/25/2015 02:48 PM, Agustín Bergé wrote:
> For maximal backwards compatibility via conversions, you ought to do the exact opposite of what a proper design would mandate.

Right.

> How about splitting functions instead and having thin asserting
wrappers forwarding to the properly designed function, macros even? Or
designing `locality` properly from the go, and using a helper
`backwards_compatible_locality` type in function arguments that
implicitly convert from old and new types? Given that any solution would
be temporary, just one release until `id_type` is phased out, it might
not be worth the cost.

I guess the only way forward is to have two sets of functions, One that
is forwarding to the proper interface (with thin asserting wrappers) and
the "proper" one. That would allow proper design of the new interfaces
and easily flaggable functions with being deprecated that will hopefully
make it easier to phase out id_type. I guess you are right that implict
conversions should be avoided at all costs.

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/STEllAR-GROUP/hpx/commit/aaf5423395f855b6d9f08dc7c8a50e525594ab66#commitcomment-13437263
>


Hi Tim, I understand your concerns. I myself is mentioned as an author (https://github.com/a2800276/8583/blob/master/AUTHORS) :) I am working at QuickPay and we actively use the 8583-code in our projects and have also submitted PRs to 8583 - #8 & #9 . QuickPay has always been pro opensource and we contributed to a range of projects and sponsored others.

We are happy to maintain our own fork, but we'd like to keep this project alive and well. Of course, our efforts will first and foremost be on things that we need ourselves, but I guess our pledge as maintainers is to incorporate changes from other contributors and resolve issues - as well as keeping the project up to date.


No problem.  I couldn't tell from github what was going on.

John

On Mon, Sep 28, 2015 at 12:09 AM, gajennings <notifications@github.com>
wrote:

> Sorry for the confusion. It's a comment on a commit on my fork. I put a
> problem in the wrong DBsection, committed it, then noticed the error
> later on and fixed it in a later commit. There didn't seem to be a
> better way to
> fix the first commit without undoing a lot of other stuff.
>
> George
>
> On 09/27/2015 03:03 PM, John Jones wrote:
> > I am not sure what is going on. Is this a comment on an old commit, or is
> > it a commit in your fork?
> >
> > John
> >
> >
> > On Sat, Sep 26, 2015 at 6:19 PM, gajennings <notifications@github.com>
> > wrote:
> >
> > > Pending problem DBsection corrected in later commit. Should be Traces,
> > > contours, and level sets
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > >
> > <
> https://github.com/openwebwork/webwork-open-problem-library/commit/b21a2ea83070376dcca0702966328a946b80db39#commitcomment-13453655
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/openwebwork/webwork-open-problem-library/commit/b21a2ea83070376dcca0702966328a946b80db39#commitcomment-13459156
> >.
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openwebwork/webwork-open-problem-library/commit/b21a2ea83070376dcca0702966328a946b80db39#commitcomment-13460747>
> .
>


Good call.


Okay - thanks again. I knew that there is no real hw to do the decoding, I just thought - there is a possibility to use the some gpu supported assisted decoding or whatever it is called - just like it is done in windows.


Some of these changes are odd; I prefer the clauses of (and) and (or) to be aligned with one another and that's what `emacs-lisp-mode does` automatically.


Better to use `resource :items, :only => [:show, :index]`


Please fix offstring -1,  i beg you.


Better use inherited_resource


contributors


.idea need to add to gitignore


Better use inherited_resources


Hi Thomas,  looking at the code, I don't see immediately how to assert that an expression DOES-NOT trigger an error?  Is it possible?


That is wonderful!


Consider upgrading to Rails 4.2.4 to get the latest bug & security fixes. You can always find the latest release version number at https://rubygems.org/gems/rails/versions


I hope this does well!


... You published the string values. Edit the script, make it auto generate random string values and that it prints the values after encryption/execution, that way more secure then having static values that are published on github.


It might be worth clarifying that this is the handoff point to git-deploy: "commits templates changes to git-deploy at ..." ?


What is your OS and Qt version?


do you need both of these variables? it seems like you could get away with only having one boolean value here.


Какая-то странная конструкция c Math.floor примененным к целому числу) Ты что хотела этим сказать?


So when I run your code, the new face does not appear underneath the place where I tap. instead of looking at `trayView.frame.origin.x`, how about setting it to `sender.positionInView(view)`?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 29](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=204&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


It's not a mistake, but the meaning of `1` don't understandable for anyone (except you). Better approach will be:
```js
myLibrary.showAllModels = function(){
  this.showModels({ displayEverything: true });
}
```

or

```js
//better to be defined in separate module
var CONSTANTS = { DISPLAY_EVERYTHING: true };

myLibrary.showAllModels = function(){
  this.showModels(CONSTANTS.DISPLAY_EVERYTHING);
}
```


Yeah, I was looking through and realised you guys had be quite active in the past. Give me a day or two to think about it and sort out the ( byte array ) compatibility issues, set up travis, etc. I strongly tend to think it's a good idea handing the project over to you, but I've had bad experiences with similar circumstances in the past so I'd appreciate the chance to give it a bit of consideration. Would you consider, for instance, setting up a github organisation for the master repo so the project remains distinct from QuickPay? In case you'd like to discuss any of this offline, feel free to contact me via email.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 29](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=204&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:13


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 30](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=205&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Should we -S(ign) commits in examples? drives home security.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 30](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=205&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:15


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 31](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=206&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Функция из одной строки, которая вызывается 1 раз в коде — не очень. То есть это, конечно же, не ошибка, но тогда можно и, например,
```
reviewAvatar.style.height = '124px';
```
выносить в функцию `setAvatarHeight`.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 31](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=206&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:14


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 32](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=207&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


I actually think it would be nice if the arrow animated at the same time as the tray, but that's personal preference. =)


Wait a minute, I think I'm wrong. Sorry!  Let me do some investigation and I'll get back to you.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 32](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=207&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:44


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 33](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=208&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 33](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=208&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:38


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 34](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=209&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Should I modify some-app@.service so that my unit is started After=some-app-redis@.service? Tough to do in a 1-liner but good to show "systemd power" (flex)


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 34](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=209&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:40


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 35](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=210&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


This is great. We should think about adding greenkeeper to payments-ui + payments-client. Might help to maintain the libs whilst we're not actively working on it.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 35](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=210&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:38


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 36](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=211&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


s/I.e/i.e


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 36](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=211&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:39


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 37](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=212&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


At the moment the Rails app is setup to use the Rails default testing framework "test-unit". This is inferred from the presence of the `test/` directory and the generated files inside `test/`.

In the future you'll be using RSpec instead of test-unit. RSpec puts its testing code in the `spec/` directory instead of the `test/` directory.

For now you can delete the `test/` directory and regenerate the `config/application.rb` file as stated here: https://stackoverflow.com/questions/28929608/how-to-regenerate-config-application-rb-in-rails-4-2

Regenerating the application.rb as above will disable the test-unit framework and generators. This will save any future cleanup work as it stops Rails from generating tests and fixture files in the `test/` dir.

(For future Rails projects, you can pass the `--skip-test-unit` option to `rails new app-name-goes-here` to disable test-unit from the start)


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 37](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=212&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:39


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 38](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=213&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Why are these not set. As far as I understand are for backwards compatibility for firewalls.


Maybe worth mentioning:
"Note: Aborting transaction which created a file while there is a process which have it opened will crash when the other process will try to access it." or something like that.


Sorry about that Johann, I should have updated these myself. I had made the changes using a working set view that just showed the project I was working on, so I updated all of _my_ local references, but none of Wonder's! Sorry.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 38](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=213&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:40


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 20](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=214&buildTypeId=XbimEssentials_XbimEssentials) is now running


Fix'd. Thanks :)


I don't understand...I see a log per FTP transaction...and you need 1 more to summarise?
Or this will replace the ones above?


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 20](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=214&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:40


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 21](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=215&buildTypeId=XbimEssentials_XbimEssentials) is now running


The blank unused assets `user.coffee` and `user.scss` can be safely deleted.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 21](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=215&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:00:38


`user_helper.rb` can be safely deleted, its not likely to be used and can be easily created should we need it in the future.


cc @vinkla


This is really important. By default the app sets itself in "DEV" mode which enables dropping the database easily. This can be changed in the future.


Consider using the `resources` routing method instead of `get`. This would look like:

```ruby
  resources :user, only: :show
```


the `.output` files now seem to have wrong numeration


items.coffee and items.scss can be safely deleted.


@jwaterfield something weird has gone on with the indenting here, could you fix it please.


Das finde ich Gut!


ItemsHelper can be safely deleted.


King Louis XVIII*


@vilchik-elena fixed in a4979a3


Good idea. I'll do that as I've got it set up already. I'll file issues but take care of it today, after I run off to squash ^_^


How big is now vmlinuz with all these builtin modules?
What is the kernel reserved memory in this setting?


Also this line raises the error:

    NameError: name 'bipo' is not defined

should be `args.bipo` and the same for `fv_radius` and `outer_radius`.


I find this design approach questionable.


不错不错


@varemenos Thanks for doing a code review! I'll fix the typo :)


Same here, missing`args.` in front of arguments.


And same here too.


Line 6 works - which is good - however what do you think about putting the days left calculation logic in a view template? Is there anything you could do to make this days left logic more reusable, for example if you wanted to use it in a model or controller?


@oliverroick Is it better to combine them likes this maybe:

```python
try:
    user = User.objects.get(pk=user_id)
    Admins.objects.create(project=project, user=user)
except User.DoesNotExist:
    return Response(
        'The user you are trying to add to the user group does ' +
        'not exist',
        status=status.HTTP_400_BAD_REQUEST
    )
except IntegrityError:
    return Response(
        'The user you are trying to add to the user group already ' +
        'exists',
        status=status.HTTP_400_BAD_REQUEST
    )
```


I'll raise them with @cornae when the IE fixes are done. These are more important than new customisations.


foreword: thanks for the quick reply. I ran into kind of "hardware disaster" (managed to crash 2 MBP on 1 journey) - so: I am sorry to be so "lazy" - should be solved by tomorrow ...
-->
Yes, right. I was not sure about "versioning" at all and of your favorite "versioning syntax" for the folder name.
Is `1_1` ok? Or `1.1`? Or `1_1_0` or so?


sh гениален :-D


How do you think about to use the return type "void" here?


Вот это не взлетит


Restrict the routes to only those that are needed. Lines 5 and 6 will create 14 different routes. By being selective about which routes are exposed as URLs, we reduce the likelihood of accidentally introducing a vulnerability or bug into the app.

To select only those routes needed, use the `only:` option, for example:

```ruby
# No actions exposed for user resource:
resources :users, only: [] do
  # Only new and create actions from the ItemsController
  # are exposed as routes:
  resources :items, only: [:new, :create]
end
```


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 60](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=216&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Yup


И вот это тоже не взлетит


Are you concerned that someone might build with -DNDEBUG ?


@dmpas тебе тоже понравилось?


Typo in commit note: "Generate regression tests *for* state pension top up"


It is not working yet


Think about the `status` attribute on `Item`. Can you think of any alternative names to `status` that more clearly explains the purpose of the attribute?


TeamCity pull requests :: netty [Build 320](https://garage.netty.io/teamcity/viewLog.html?buildId=1780&buildTypeId=pulls_netty&guest=1) is now running


Yes right. Forgot about it.
btw: The schemas derived from a TS interface to JSON schema project which I wanted to upgrade to TS 1.6.2 -
note to me: make baseURL relative where I can ;)


It would be nice to remove this whitespace change from this commit.


@vilchik-elena fixed in 2dfb2dbe3cc5de70ff8ecfda3290679f6275f175


pushd вроде как есть. А вот слэши надо поменять


@EvilBeaver ага


TeamCity pull requests :: netty [Build 320](https://garage.netty.io/teamcity/viewLog.html?buildId=1780&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:18


Yes.


Thanks to all! We have a elo gaining version so i started a pull request. Later i will try a further tuning on top of this.


Syntax is a little confusing on this line, you might prefer one of these equivalents:

```
<%= form_for @item, url: user_items_path(current_user) do |f| %>
# or
<%= form_for(@item, url: user_items_path(current_user)) do |f| %>
```


да, я про слэши. pushd/popd есть. и %~dp0 - тоже нет.


@vilchik-elena fixed in d7e2a0e69231ae8a3343d1885979c15bd3978e4f


It looks as if there are a bunch of non-significant changes in the YAML files, presumably related to changes in YAML version/engine e.g. double quotes -> single quotes, removal of trailing whitespace after colon, etc. It would be better to make these changes as a separate commit, so it's easier to see the important changes.


тогда сделайте, как правильно.
Про слэши, как всегда, забыл


Fixed via fce3088dcf08e5bab477183cb4d87f93da2d18a9


I realize the return value is useless here. But I like a wrapper function to have the same
signature of the wrapped one.

Is that unconventional?


This fixes the issue I reported yesterday. Thanks very much.


XFS has 'xfs_growfs /path/to/device' to allow resizing to maximum. @cstrahan perhaps you can add that as well :)


It would be better to EITHER update the checksums only in the last commit OR update the checksums as you go along in each individual commit.


receive Error 6503 (http: 503): Unable to connect to the service. The service is unavailable, try again later.. The service is currently unavailable because a connection failed to a core component. Please contact an administrator or try again later. since this change ...


Congrats too!


Currently any user (including non-logged-in users) can access the ItemsController.

Review the `before_action :authenticate_user` code from bloccit. This prevents anonymous users from accessing a controller's actions.

Consider adding `before_action :authenticate_user` to `ApplicationController`. This will make authentication-required on by default for all controller actions as all controllers inherit from `ApplicationController`. This is a secure default to use. You can then be selective about which actions should be available to non-logged-in users with `skip_before_action :authenticate_user, only: :some_action_name_thats_safe_for_all` in the resource controllers.


aa


Is there a good alternative for asserts?
Or should I make sure NDEBUG is undefined in build scripts?


Hi Kevin,

I did it because Tantek removed 'alternates' from the parsing instructions page on the wiki http://microformats.org/wiki/microformats2-parsing I use this as a spec so as soon as I can after a change I update the tests and my parsers. There was a sentence in the page saying that 'alternates' would be remove at some point.

I rarely consume the rel=* data from parsed pages, so I have not been keeping up date with the conversation round this subject as much I should.  It does seem like we have got ourselves to a point of a lot of duplication, where some rationalisation would be good.

One to pick up on the IRC or the parsing issues page.

Glenn


Lines 46-49 indenting.


@lindamartin @vilchik-elena copy-paste


I generally prefer to avoid also unnecessary return values.


return errors.New("invalid snack, I cannot produce a snack of praise".")


There are a bunch of changes in here which are not explained by the bug fix commit i.e. I expected to see an extra line for when a woman is 62, but not for when a woman is 64 or when a man if 66. Assuming this change is correct (given this has been fact-checked), we should explain why it's changed somewhere - either in this commit, or probably more appropriately in the commit where the behaviour changed.


Sorry, this does not (always?) work. `#` isn't properly defined for what you call sparse tables:
http://www.lua.org/manual/5.1/manual.html#2.5.5
http://www.lua.org/manual/5.2/manual.html#3.4.6
http://www.lua.org/manual/5.3/manual.html#3.4.7

I fear this means that this has to use something like `pairs()` (or a loop with `next`) to extra all "interesting" elements and later sort them.

A quick (untested and ugly) idea would be:
```lua
local max_index = 0
for k, v in pairs(content) do
    if type(k) == "number" then
        max_index = math.max(max_index, k)
    end
end
for k = 1, max_index do
```


nice, and how about adding a blur to the camera when its shaking?


it is pointless to test for this, thus removal


`edit` action is for showing the edit form, it normally doesn't make any modifications to the model.

Modifications are usually made in the `update` action. The edit form submits to the `update` action.


committed by Rajesh


@vilchik-elena maybe we could add `case {@link #expression()} ; {@link #statements()}` to show that a semicolon can appear even when the list of statements is not empty


mmm


测试文件


Why did you do this? Now `publish` conflicts with `opam-query`.


Maybe just a mistake, but this block of code could also be removed and not just commented out.


I have a better implementation now. I had to change some logic in `FTConvertToCDI.cxx`. There is no more a `restrictedMC` flag which steers the behaviour of dumping stuff in the CDI file as this was a global flag. There are now two distinct flags `copy` and `copySlim`. These two flags steers the two possible behaviours of dumping stuff. In this way, there is no hard-coded information and no assumption on the filename. Committing this ~now..


<!-- asdf asdf asdf -->


right on time bro lol..


lol


This commit addresses this issue:
https://github.com/vermaden/beadm/issues/32

I can remove that entirely from BEADM as I do not need entropy handling in beadm code ...


@vilchik-elena why do we redeclare caseToken(), caseSeparatorToken() and statements() which are already in SwitchCaseClauseTree?


So good!


This is just a good practice to help type-inference. Without it `List(Preserve, Force)` has the inferred type `List[Intent with Product with Serializable]`.


Linux Mint, with Qt4.8.6 (Qt 5.2 installed but seems not involved in compilation).


**Code Quality - Critical**

Your code styling is not consistent from lines _3_ through _18_ with other parts of the code base.


Actually this is incorrect. The code should be updated to use capitals. Typically mysql is case-insensitive, so I have a bad habit of using lowercase in code. `Users` is the preferred casing if case-sensitivity is on, however.


add release note


@pynicolas To have clear understanding what does this interface represents


I am running some local tests against master with the following:

 const Score PassedFile[] = {
    S(10, 20), S(5, 15), S( 0,  5), S( 0,  0),
    S( 0, 0), S( 0,  5), S(5, 15), S(10, 20)
  };

The patch gains on average +30 points for 500 games but games are too few for statistics. My point is to try 0 as a lower limit for tuning because this file bonus is over and above the general bonus for passed pawn.


**Code Quality - Critical**

You have a missing semicolon here. Your javascript syntax should be formatted consistently using standards making your codebase environment proof (production, strict etc).


nice


@flavour something like this and this: https://github.com/biplovbhandari/eden/commit/33c0cddd09c223f8ee775e284a5aff78c6781103#diff-8b02f3a5c97483e605769a048020941cR905 ?


* How do you think about to use a macro or [inline function](http://en.cppreference.com/w/c/language/inline "Reuse of 'inline'?") there which will always check the return value of a function like "strdup"?
* Is [the reuse of C++ strings](http://en.cppreference.com/w/cpp/string "Strings library") (including automatic exception handling) another interesting software design alternative?


This one also trips me up. Because the file is being served from a node instance, I believe you can ignore everything before the slash, and it will still direct to the original host. I need to verify this however.


Print error message to STDERR


Looks good! Don't forget to change all URLs to that repo, like badge links etc.

Also, If you want to have similar setup to my Algolia bridge you can look at this package: https://github.com/GrahamCampbell/Laravel-Manager


Debugging? :grinning:


@BLangendorf Why only for tests? Needs to be set if recurring is being used, no?


5.3.3
5.3


Fantastic. I didn't even think to go looking, will take this and wget out.


**Code Quality - Critical**

`booksArray` will never return 'undefined'. `JSON.parse` throws an exception when  the argument string has an invalid JSON format.


All arrays now need to be long array syntax.


> We don't expose much non-final state at this point I guess, beyond RUNNING

True, but running is essential of course.


dasdasdasdasdasdasdasdas


Got it. You're quite right. I updated script. Also a short description of each module was included.


Currently LibAV 11.3.


Ah,  yes, of course -- `RUNNING` is kinda useful :)


If we could push the functionality of these files in to their similar express routes files, I think that would be best.

For example, when someone joins the media namespace, they need to get updated with the current video, just like when a song ends. No sense in duplicating that code if we could just route the io namespace to the same file as the express route


dimenticato `console.log` nel test


TeamCity pull requests :: netty [Build 321](https://garage.netty.io/teamcity/viewLog.html?buildId=1781&buildTypeId=pulls_netty&guest=1) is now running


This doesn't make sense to me:
_update_sync is run to configure the user settings...so why run a Sync task then?
Just create a task which has no interval here...so it never runs.

Do the actual run onapprove


Yeah, the same thing occurred to me after I posted that.. I'll probably just wait until Kodi supports it.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 60](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=216&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:31:00


@vilchik-elena should we add something for `declare(...);`?


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 24](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=217&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


It's already https://github.com/synrc/active/blob/master/src/active.erl#L87 in master


Obviously this captures new alerts...I'm not sure how new info segments work...do they get approved too?


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 24](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=217&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:42


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 39](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=218&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Ah, I see. The problem is that `Channel`s don't have a state, thus the [`flush()` call](https://github.com/MetaStack-pl/MetaRx/blob/master/shared/src/main/scala/pl/metastack/metarx/Channel.scala#L120) is a no-op. I would refrain from caching the values within `zip`. A better solution would be to prevent `Channel`s from being passed altogether. Ideally, there shouldn't be even any `flush()` defined on `Channel`. We should continue this conversation in a separate issue as a proper fix involves some refactoring.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 39](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=218&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Compilation error: Xbim.Exchanger\Xbim.Exchanger.csproj (new) Build time: 00:00:28


das heißt nur dass man nicht mehr mit Xcode 6 (5?) bauen kann, oder?


Wildcard import has lot of unused stuff


@jglick not sure you wanted me to change the `SleepBuilder` here too


It's green after only 247 games. We all hope this does well!


Feel free to give it some thought. I've personally got other opensource projects that really could use my attention, and I'm trying to hold back on adding projects under my responsibility. Creating a new organisation gives an overhead in administration that I'm quite reluctant to take on me/us - especially considering the relatively low "traffic".

Also, In my opinion and given that 5 of 7 merged PRs are from me or others at QuickPay, we've got a good track record and shown our interest in the project. As I mentioned we are quite satisfied maintaining our own fork and let others maintain the official repository - we'll keep creating PRs regardless :)

I would a shame though leaving the project dead.


исправлено


Sorry I meant to say that I was going to look at "widgets and submenus" early next (this) week.  First goal was to get them back to the way they were for defaults, and then re-examine them.

I didn't see a way to add possible actions to the chooser without adding it in as a default shortcut, but I'll look again.  I know it can do that widgets, backgrounds, and icons, but not sure for shortcut actions.


nil Check?


Variable name h1,h2 too short , not descriptive


I think this file is actually used under the lid: https://github.com/kynikos/archlinux-mediawiki/blob/5ac4f0ef1610ad29194e85d3b7d635515bafb420/LocalSettings.archlinux.org.php#L15
Even though it does not really fit into the `skins/` tree, it has to be somewhere...


As GST 1.6 is the stable version, while 1.5 was the experimental version, updating 3.2 to GST 1.6 seems to be a logical step. Please revert the revert.


Aqui, onde nomeei como alfa, era pra ser o valor de pertinência a cada conjunto fuzzy. O alfa (força de disparo) é, na verdade, o máximo entre os antecedentes das regras ("se x é A e y é b").


Has 'make clean' been updated too?


I don't want php 7 and IDK how to install it. Ill google it later.


@vilchik-elena why this change?


You don't need php7 for build 35


I've double check it now: the Current Opinion and Cell Press journals are "Non-Standard" journals in the Elsevier internal report (as oposed as the standard journals). There are many "non-standard" journals in the report and not all of them are in the skip list, since they don't make it to the  generate_dependent_styles/data/elsevier/_journals.tab

I think that in the past these journals were incorrectly identified in the internal report as standard but were not standard so we added them in the skip list. Now they are correctly identified as non-standard.


Just grab it here: http://jenkins.pocketmine.net/job/PocketMine-MP-Bleeding/35/


PEP8 Error:The line is too long
The assignments could have been done in separate lines.


For all the scripts, I think having both a `--bipo` and `--no-bipo` argument is a little confusing. The `store_true` action sets the relevant args variable as `False`, if the argument is not included. E.g. if you run:

    $ python multi_ntuple_spectrum.py -c /path/to/cnfg.yml -p /path/to/ntuple/direc

and then print the value of `args.bipo` it should evaluate as `True`. The default value for `bipo` in `fill_spectrum.fill_from_root` and `fill_spectrum.fill_from_ntuple` is `False`, so I would suggest having False as the default and then only apply the `--bipo` argument if you wish to apply BiPo cuts.

The value of the `--no-bipo` argument doesn't seem to be used anyway, so you can just delete the lines.


This is great!
Thank You so much!


THIS BROKE EVERYTHING. I forgot to properly test older features (including the most obvious and important, selecting and moving ships)


Changed "Is there a way to change the output directory of fonts, scripts and styles?" and "How can I have an environment specific build?"


OK for me.


Good Nice correction


This code was written in the year 2000. May not compile with latest compilers.
The files have got named to .C instead of .c , and need renaming.


@pynicolas we've discussed this already. I wanted this be alike everywhere. Actually, i did bulk update to `statements` here https://github.com/SonarCommunity/sonar-php/commit/fe8661e55b6f2686b0f5458f7c42d5a39608e4ad


stick to using one errors or errors()


А на какой разделитель ты сменил? Разделитель должен быть жестко зашит. Ранее с Сергеем мы договаривались о символе `|`.


I've fixed this in my local version of the branch.


так он csv файл в powershell генерирует его через запятые. из за этого не работало


TeamCity pull requests :: netty [Build 321](https://garage.netty.io/teamcity/viewLog.html?buildId=1781&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4791, ignored: 16 Build time: 00:11:11
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testResolveAAAA: <no details avaliable>

```


for biber 1.9 this is ok, since we can pass the compile dir directly to biber via cmdline. In biber 1.8, which a later commit supports for compatibility, this is not possible and probably looks more like what you expect.


@pierre no, this endpoint is used to retrieve `RecurringDetail`s from Adyen. But since the Adyen Plugin works with `recurringDetailId`s it gets from the PluginProperties it does not need to have the capability to retrieve them. For the tests on the other hand we need to retrieve a `recurringDetailId` to call the Plugin with it. That's also why the generated code from `Recurring.wsdl` is generated in `generate-wsdl-test-sources`.


PEP8 Violation : Whitespace error


roid-Terminal-Emulator                <
/system/bin/sh: https://github.com/jackpal/Android-Terminal-Emulator: not found
127|u0_a127@w3c:/ $ @-()
>


Állj!!!

A rohadék láthatatlan és elérhetetlenség tulajdonságok most nem működnek a gittünkbőlletöltött cuccokkalkészített csomaggal.!
Megpróbálom az újramentett glade fájllal, melyből kiirtom a swapped cuccokat.


I forgot to document this.

The short story is: when you use a volume mount without a data container ( docker run -v ... ), the owner of the directory will be root and Gerrit won't start without permissions being reset to the Gerrit user. You are totally correct that we don't need another mkdir in there, however.

Why would anyone want to not use a data container? Our context, for interest (since I might end up giving you more pull requests!), is that we're trying to containerise our existing buildsystem. This means not moving everything to nicely sized containers, but rather, using some monolithic containers as substitute VMs in the first instance. Our backup processes and a number of automation tools and external mount points rely on access to the host machine, so we're trying to keep the host machine touch points the same for the tools, while containerising and automating the service side.


PEP8 Error : The modules are not imported in a proper manner.
Valid : from directoryName.fileName import Class
Used from fileName import Class


The libcgi-pm-perl that I included from the beginning of the Dockerfile is also unnecessary as I checked right now.
So feel free to remove it or I will remove it myself. ;)


kokoko


I find this a bit odd.  Why are you passing in to the `Response` object that the type is binary when you can and should inspect the content type of the HTTP response itself to determine the content type.  This is far more reliable, and there are plenty of edge cases where the response may not be in the same format that the request was sent with.


Dear  sir,
i tested the code as given.But when i used read write command it not working....
![server](https://cloud.githubusercontent.com/assets/14104387/10134315/6a5e01aa-6602-11e5-9f9c-00787a68c2b9.png)
![client](https://cloud.githubusercontent.com/assets/14104387/10134317/70b7bef6-6602-11e5-968b-cb10bdeccf83.png)


It certainly makes these operations easier! But PWD is one of  the global variables that Lake scripts depend on, so it could bite.  I'd prefer not to mess with something that's working.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 40](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=219&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


I've just looked at the page and it does seem ok with just a title, so I'm happy to leave this commit unchanged.


Why skip_auth true?


hmm, not sure about that as a good reason to do this, it actually sounds like it's just a flat-out lie in the case of `Serializable` as there is no compiler check that what you've written **is** actually serialisable, and restricting to `Product` means that you only expect implementations that are case classes. It sounds much more like you're working around what you deem to be an ugly type parameter that you see in your IDE :wink: You could explicitly define the return type of the above if you want to restrict it.


I find the reset of this variable also unnecessary.


**Index Functions - Critical**

You didn't follow all the instructions listed in the ___01 - Inverted Index__ checkpoint.

The function names, and all the other requirements. Be sure to follow them to the letter whilst being creative.


А когда ты очищаешь `_transaction`? Зачем вообще его сохранять в `UnitOfWork`? Из-за этого возможна утечка памяти. Ты ссылку на объект оставляешь, изза этого сборщик uow тоже не заберет.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 40](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=219&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **SUCCESS**
Summary: Running Build time: 00:01:15


Зачем эта функция?


It seems we got into fairly non-technical discussion with `aiohttp` author. IMHO, we will be better off to use the standard library as much as possible, i.e. by creating appropriate `urllib.request` opener (which `aiohttp` authors should try to do, to not reinvent the whole `http.client` wheel).

Therefore, please test this commit with a proxy https://github.com/wrobell/geotiler/commit/ee5b2e1087873687f04ffba8b017d6d0e7a7de56

Longer term I would like to perform the tile retrieval in real async mode, but running in executor will have to do, for now.


@mfc-julius Yes, it's more readable.


@tiagofabre No probs, when it is - let me know although, there is an extension coming out for this very soon so if you can't get this to work, you may be interested in it.


This line is used so often, should we not just have a helper such as `protocol_channel_name('whatever')` that handle this?  Alternatively, in Ruby, I just append a random string to all channel names anyway so there is no risk of conflicts anyway.


The previous commit was only compatible with 1.9+. I'd want to keep this in here, once biber 1.9 is widespread enough, as it is way more clean than the bibtex-type hack.


I will definitely use the neater iabs code and updated 'windows' need.  The abs() fix needs discussing.


Оберни в `using`. Или полностью контролируй жизненный цикл транзакции (убери ссылку, за-нуль, rollback).


I'll whip it out :)

I do wonder if putting gitweb into the same container as Gerrit is the right thing to do, but it suits our purpose just fine right now.


error: getting status of ‘/nix/store/wvyihl9iz56yai4457j9wim3i80r8rh6-git-export/nixos/maintainers/scripts/ec2/amazon-hvm-config.nix’: No such file or directory


 120 margin: 0;
  121 padding: 0;
  border: 0;
  font: inherit;
  font-size: 100%;
  vertical-align: baseline;
}


Здесь и ниже - убери код в комментариях.


I've addressed both of these comments in my local version of the branch.


через него соединение и транзакцию передаю в репозитори


Дима уже делал замечание. Не используй глаголы для именования классов.


何も知らずに（つまり予備知識無しで）GitHubを使い始めている状態を示しています。
This is an example of typical user starting to use GitHub with no experience at all.


I understand. ^_^


Sebenernya aku tulis 'pakai' disitu biar cukup di buttonnya
Kalo pake 'gunakan' jadi kepotong


Oh.... ^_^


**Code Quality - Nitpick**

I'll advise you adopt a design pattern for you application, make it modular.
Since you have a class called _invertedIndex_ all the variable and output should be instance variables. In order words, `booksArray` should be property/attribute of your class, not a global variable.


Нельзя так делать. Кто попросил `scope` - тот и управляет его жизненный циклом. Этот класс - **фабрика**, а не менеджер.


@masensio the build is failing now, see travis ci: https://travis-ci.org/owncloud/android/ --> invalid resource directory name: /home/travis/build/owncloud/android/res values-en_DE

Sounds like some kind of transifex issue


コメントは、ご自由にどうぞ。
Your comments are welcomed.


Лучше тут всё-таки не Exception ловить (слишком общее исключение), а посмотреть что конкретно выкидывается если проблемы с интернетом.  А то сейчас (условно) юзер захочет прервать Кваст, нажмет Ctrl+С и его попросят подождать еще вторую попытку, а потом и третью и так для каждого референса!
На самом деле Ctrl+C сработает корректно, так как он BaseException начиная с питон 2.5 (а мы только 2.5-2.7 поддерживаем), но это я как пример + в питон 2.4 было бы правдой.


Will this return value be ever checked at the call site in your source files?


@flavour currently record approval is required for cap_alert https://github.com/flavour/eden/blob/master/modules/templates/SAMBRO/config.py#L56

If an alert is approved and we update it by adding info, I think its already approved?


Hi,

give "Type 'help [COMMAND]' for more details on a command." a chance :-):

("help read" =>
>  read CLIENT# URI
   CLIENT#: client number as returned by command 'list'
   URI: uri to read such as /3, /3//2, /3/0/2, /1024/11, /1024//1
   Result will be displayed asynchronously.)

So, you can only read a resource from a registered client. Therefore start the client also. I will then be listed at the server using the "list" command at the server. The list will contain the CLIENT# (usually 0 for the first client) and the offered resources (e.g. /3/0 for the device instance). Then use read with this information (read 0 /3/0) and you should get something.

Mit freundlichen Grüßen / Best regards

Achim Kraus

Bosch Software Innovations GmbH
Communications (INST/ESY4)
Stuttgarter Straße 130
71332 Waiblingen
GERMANY
www.bosch-si.de
www.blog.bosch-si.com

achim.kraus@bosch-si.com

Registered office: Berlin, Register court: Amtsgericht Charlottenburg, HRB 148411 B
Executives: Dr.-Ing. Rainer Kallenbach; Michael Hahn

Von: ravikasyap1717 [mailto:notifications@github.com]
Gesendet: Montag, 28. September 2015 13:31
An: eclipse/wakaama
Cc: Kraus Achim (INST/ESY4)
Betreff: Re: [wakaama] Merge pull request #57 from eclipse/fix_observe (69a32cf)

Dear sir,
i tested the code as given.But when i used read write command it not working....

—
Reply to this email directly or view it on GitHub.


@flavour How do we know which function when just create a task using task = S3Task() https://github.com/flavour/eden/blob/master/modules/s3/s3task.py#L71?


I've addressed both these comments in my local version of the branch.


Happy birthday to you babel (former 6to5), thanks for the billion hours you saved us :)


Где `scope` уничтожается?


Close the stream


**Code Quality - Critical**

In Javascript classes are declared as functions, as it's the adopted standard recommended camel-cased upper case first like so: `InvertedIndex`.


This and the next one should be manageable by adding the default handler for *,*


Про именование классов - тоже самое, что ранее говорил. Не используй глаголы!


I think in the more normal use case of having a ReadChannel derived from a Var it works fine as the flush() is delegated up to the Var?


Use try-with-resouce or IOUtils.closeQuietly to avoid propagating IOException (plus this can result in NPE)


Ta linia nie bedzie nigdy dostepna, przed ta linia konczysz dzialanie funkcji uzywajac `return`


I believe if you tell travis to only build if `.travis.yml` is present (over at the travis settings for the repo), you should be able to omit the `branches` section and just let it build any branch with a `.travis.yml`


Never do this


This is a good one. AFAIK there's no way to get MSVC compiler to built 32-bit code - although there are a LOT of flags for cl.exe!


**Code Quality - Critical**

Variables to be incremented should be declared as a __number__ that shows the starting point `0`.


Niepotrzebnie przypisujesz `$result` do zmiennej `$texttile`, mozesz zwrocic wprost:
`return $result['tile']`


You should be able to follow the pattern in TypeEquivcat, and for the 2 iso components, use a generic linv/rinv combinator.


Bad stream handling


Is `is not` using the equality operators? I'm just a bit surprised that it is expected behavior for two atoms of the same Topology to be not the same when they are compared from two different universes.


So this is the beast that broke my sync strategy because I was sending category slugs. No issues for several months. This sort of abrupt change just hurts. Can we at least get a deprecation warning or something so there's time to notice and clean it up properly?


I looked this up and I'm not sure if it is ever used or more importantly, expected to be supported. I'll add a TODO.

BTW: At present, it appears that `.Prefix` is only set on the `*yang.Entry` for a `yang.Module`.  It doesn't look as though the `.Parent` of the top level object (say, a container, in a test case I wrote) points at the `Module` - it's `nil`.

We could resolve the prefix all the way down - i.e., populate `.Prefix` during execution of `ToEntry`, and this would allow the `Find`/`FindRelative` functions to fully support prefixes very easily.

Does the above (`Prefix` population in all Entry) sound reasonable?


Jeszcze raz zobacze `@` to zakleje Ci `shift` i `2` ;)


can you please write `atom` instead of at. It's a little bit more verbose which makes reading it here nicer.


Questions in the comments responded to


see comment for `at`


A major part of your code is almost a verbatim copy of [someone else's work] (http://jsfiddle.net/gabrieleromanato/xugej/)

Although we support re-using other people's work, this onboarding project is to develop your own skills. You can re-use ideas, but please don't blanket copy and paste code


Are you sure about that?
Can you try //remove_all_skills, //give_all_skills


When I run (assuming the `args.` changes have been made):

    python echidna/scripts/multi_ntuple_spectrum.py -s /data/back/hdf5/echidn_v0.3-alpha/rat-5.0.2 -n Xe136_2n2b -c echidna/config/klz_pre-echidna_v0.3-alpha.yml -p /data/back/root/majorons/Xe136_2n2b/ -v 1200 -o 1540

I'm getting the error:

```
  File "/common/users/back/snoplus/software/echidna/echidna/echidna/core/dsextract.py", line 26, in function_factory
    return EnergyExtractTruth(**kwargs)
TypeError: __init__() got an unexpected keyword argument 'outer_radius'
```

It looks like the extractor classes are now getting keywords they are not supposed too. The quick fix for this would be to just add `**kwargs` to the `__init__` for each extractor class. But to do it properly you should probably select the correct kwargs in `function_factory`.


Maybe SpecFunc::IsInf could be used instead of x == std::numeric_limits<NumericalScalar>::infinity()


Is this not missing an `\n` now?


Why not? I need lists loaded in the project object.


:beers:


It looks like `QKeySequence::FullScreen` was introduced with Qt5. I serves a platform independent solution for the full screen hot key (see http://doc.qt.io/qt-5/qkeysequence.html#standard-shortcuts).
So using F11 key instead may be inconvenience e.g. for Mac users.
Thus I'd prefer a conditional compilation solution to keep LC platform independent with Qt4 too. If Qt version < 5, then set the shortcut keys manually, depending on the OS. And when Qt version >= 5 use `QKeySequence::FullScreen`. If we decide in future to cancel Qt4 support, we can remove this extra code.
Or is this decision already made?


这个地址无法访问，配置下短域名，像这样？

weibo.com/wuzhangjin


Oh, and `s/imprved/improved/` ;-)


Korzystajac z PDO mozesz wykorzystac:
http://php.net/manual/en/pdo.prepared-statements.php
Nie ma sensu angazowac PDO zeby pozniej recznie sklejac string.


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 13](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=220&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 13](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=220&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **FAILURE**
Summary: Compilation error: Xbim.Script\Xbim.Script.csproj (new) Build time: 00:00:13


Is this still a thing @redox\


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 14](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=221&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


Since this is all cpp code, should we start using <cstring> instead?


SQL injection mozna wykonac na rozne sposoby, nie wystarczy sprawdzenie czy w stringu jest znak `'`
Pozwol PDO zajac sie tym problemem, po to je wykorzystujesz ;)


What is your reasoning for not following the naming that Option is using?

The advantages of using map() is the infrastructure available, like for expressions, that uses it.

I was also trying to let the operators work with all descendants of ReadChannel, and then then map must behave the same:

```scala
   implicit class ReadChannelOrderingExtensions[T: Ordering, U :< ReadChannel[T]](rch: U)(implicit ord: Ordering[T]) extends ReadChannelExtensionBase[T, U](rch) {
    import ord._

    def <(other: ReadChannel[T]): ReadChannel[Boolean] = rch.zipWith(other)(_ < _)
```

where zipWith is using map, so that the combinator function "_ < _" needs to be able to handle Option[T] in this case.


this is close, but not quite there, it needs to cache the images locally


Worldwide Worldmind Worldwww & let ages of diplomacy begin TilTrue


I changed my mind, don't use this old encryption methode its too simple.
Use either an sha-2 encryption or use hashlib for python, those are
WAYYYY
 more secure.


@paulirish Is it possible to use this git diff view on vim when writing a commit message?


cachedPrebuild is inside the .npm folder so that it is shared across multiple installations of the same module.  Using only a local directory would preclude us from doing this.


This should not fail on zero hits.  That isn't an error.  You ran a query, it had zero hits.  The calling code can error if it wants, but not this.


That was deliberate :)


That could work as well, though I suggest perhaps doing that as a refactor later.


You mean, using std::? Yes that could be a way to go, but this would require replacing functions and included headers around the code.


:fire:


@flavour but every alert update require the status to change which is at alert segment. So we want to treat this as a same alert with the same UUID but keep both the record in the database.
I think this is a major chunk of work still needing to be done.
Will work on this after done with FTP Sync? What are your thoughts?


I will not merge this.  That contract is insane.  Lists don't fail on empty result sets.


Me too! Had to reset to HEAD@{5}.


@ticosax
Could that just use `HAS_DOCKER_PY = docker.version_info < (1, 4, 0)`?

Also a logger warning about the version mismatch might help here.


@flavour for s3db I think I should use alias as "from s3layouts import S3PopupLink as S3AddResourceLink" to maintain backward compatibility and for me to modify less lines for large files ;-) ?


@brucelawson, deployed


any test?


I was getting a foreign key constraint error when `Users` was lowercase. The SQL keywords are case-insensitive, but things like column names are sensitive.


On a second though, this maybe useful when upgrading from an existing Gerrit docker environment since we can't make sure the gerrit user id is 1000 on every time. So just keep them.


Wait. Not yet, in progress.


I don't want a partially complete group created here.  Make a //TODO to fix it and I'll do it after this merges.


Hello Pierre.
Do you plan to add a kind of fish-eye distortion model in omvg ?
Regards,
R.


I've split this commit up into three separate commits in my local version of the branch: (a) changes to the data query; (b) changes to the calculator; (c) changes to the flow e.g. removal of the outcome.


hallo


It's a start.  You'll need to add more post-merge.


I've fixed the commit note typo in my local version of the branch.


This just removes the default behaviour that matches the way api.php works. So, it won't break things, but it means that without ENV vars api2.php and api.php behave differently.


I guess just setting the exit_state to EXIT_FAILURE on either case would be fine too (without adding --fail-on-shred-miscount)


I think perhaps at this point we should add a little documentation about the difference between api.php and api2.php so if someone wants to use this they know what they are getting.


It might still need to be specified as I wasn't able to connect otherwise, but try it on your end. It's good practice to specify the full hostname in case you decide to split up the server and webapp later on.


The new camera model structure allow to do add as many as you want new camera model...
But someone need to contribute to it, it's not in my direct plan, by if someone from the community want to work on it, I would be happy to help him.


Is there a reason you are requesting we up the damping of this joint to 5?


The chown is necessary, the mkdir; probably not so much. All updated here: https://github.com/piete/docker-gerrit/commit/master


@pynicolas Fixed in fc823bd57fc946b7dbe122a4270ac9de202689ca


Yes, I just wanted to have that explicit (i.e. don't trigger CI build if I explicitly don't tell it to do so).

Otherwise I would need to *remove* `.travis.yml` for a branch that I don't want to have built (and that would result in conflicts when merging later).


Priorities are for Nuwan to decide.
I agree in general that better to finish this up since nearly done before launching on another major task.
The key for now is to ensure this doesn't get forgotten then.
I suspect that if we need Alerts to be Approved...then Updates to the same Alerts (Status+Info) also should be approved


@pynicolas Fixed in fc823bd


对cubic algorithm不知，因此看不懂此重要修复，可惜了


Why would you ever do that?
There should only be a single instance of S3Task(): current.s3task


Absolutely fantastic, thanks. Never thought I'd be able to get rid of that warning.


I was asking about an alternative to assertions in general. The strdup() wrapper
is not the only place where I use them.

I think I will opt for undefining NDEBUG explicitly.


WTF? You're referencing obj before it is defined.


The correct link for that is `http://maven.apache.org/plugins/maven-shade-plugin/`  and not `http://maven.apache.org/components/plugins/maven-shade-plugin` cause the latter one will not correctly render the icons etc. But thanks for the hint that i need to check the content that some of the links are missed in the code.


you cannot slice lists with path-statements like this


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 14](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=221&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:20:40


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 15](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=222&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 15](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=222&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:16


I would have this alias in s3layouts.py, just like these:
https://github.com/flavour/eden/blob/master/modules/s3layouts.py#L305

Means even less worry about backwards-compatibility :)


Usinge $(find val_description) in xacros in the val_description repo was causing a problem with our hydro bamboo builds. Something with a xacro trying to find its own package before the package was fully build and the paths setup. We may need to revisit this, because I do agree using $(find val_description) is preferable.


Érdekes, hogy MATE alatt a menüből indítva a felbukkanó jelszóbekérő ablak után működtethető a Live/Normál legördülő, vagyis nem működnek az elérhetetlenség és láthatatlansági tulajdonságok. Felhasználói Qterminálból indítva sem. Sima su -ként qterminálból sem.
Viszont su - esetén qterminálból jó. Krusader/konsole terminálból indítva felbukkanó jelszóbekérés után jó.
Sima konsole -ben indítva általában jó.
Tehát éles telepítési környezetben jól működik, de azért biztonságképp jó, hogy benne van a Live mód használhatatlanságára utaló hibejelzés.


Right now you can pass `chatManager` and `mediaManager` into the route files the same way you did with `io`. You can then define event callbacks there. We can also pass in `io` like you were before, and set the namespace at the top of the route file.

Then we can define the ..on('connection', ..) event in the route file, and immediately send back the current song that's playing. The current song can be stored in a variable in the route file.


I didn't explain this properly so I think you misunderstood me. My point was to have one function call to get *a* file, which would return a local prebuild if it exists, if not return a cached prebuild if it exists, if not error back and then we do the build.

I'm saving this for a refactor later :)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21259/testReport/) for this commit**


I might have missed something in the logic though.


tutaj warto było by użyć lib\Objects\User\User zamiast potrójnego zapytania.
np. $user = new lib\Objects\User\User(array('userId' => $usr['userid'])). w obiekcie $user od razu masz $homeCoordinates. nie ma radiusa, ale można łatwo dodać w okolicach 100 linijki.


There are better ways than to ignore also a setting like `NDEBUG`.


potential NPE here, this need to be moved to try


final, and inside of try


should not be on repo


final


I suggest replace `FunctionDescriptor` with `CallableDescriptor`.


I was waiting to do this


This feels like logs. Logs should't be printed to STDOUT, use logger instead


Зачем ты это делаешь?


maybe print stack trace? and DO NOT use STDOUT for logs


Why? It's a JetNamedFunction, so we know that its descriptor is a FunctionDescriptor.


no one have test , check it offline and in 3-4 weeks we can speak again


А где уничтожение потоков в `data`?


Removed? Why?


Actually, this should be like this:

```
render json: post.to_json(include: [:comments]), status: 200
```


Follow the same pattern as above to include posts in topic.


Because it’s total bullshit.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21260/testReport/) for this commit**


Yeah, there is a solution called hybrid decoding/encoding, splitting some tasks gpu Fix Function can't do and give them to cpu or EU. However, right now there is no high priority to use a hybrid solution support 10 bits hevc decoding on Braswell for otc libva-intel-driver team as I know.


snack overflow.


Do you even know what this actually do?


It's not needed, as long as inject gulp plugin will inject any css file in css folder.


IMHO all this need to be extracted to the method like:

Optional<String> readTextFromTheFile(final Path path);

use Path for path :) and return Optiona.empty in case of the error


Really good suggestion will give a follow up to the PR on salt.
https://github.com/saltstack/salt/pull/27451


looks like separate method "generateLine" is needed


yep I was already aware of the generic aspect of camera model in oMVG. Maybe I could work on that, we own a canon 8-15 mm fish-eye here and have some nice pictures taken with it. I'll let you know when I'll be a little bit more free to start.


Почему Camel Case с большой буквы?


Does it mean that we can't use those key in the viewer anymore ?


The trait is `sealed` so all the implementations *are* `case object`s. I don't use an IDE but this does avoid triggering the [Product wart](https://github.com/puffnfresh/wartremover#product) in projects that use wartremover. In my experience it also avoids some problems you run into when getting into more advanced scala (implicits, macros, etc).


być może, dla poprawienia wydajności wszędzie, gdzie używasz $zmienna = new dataBase(); warto było by użyć:
$zmienna  = \lib\Database\DataBaseSingleton::Instance();
(mniej połączeń z bazą, mniej zajętej pamięci)


What if put string value to 'required' field like 'true' or 'false'?
So I rewrote it to String(parameterSchema["required"]) === "true"


not cleat why we need this? to show first or last line? could you change the name to something more meeningfull


@chelmuth: please apply above fixup to fix x86 platform driver scenarios (e.g.: vbox_auto_win*)


good job


I don't think there are any technical benefits of SCSS over SASS. This article lays out a good list of the pros and cons to each: http://thesassway.com/editorial/sass-vs-scss-which-syntax-is-better

Personally, I like SCSS because I've come on to multiple projects where I wanted to convert from vanilla CSS and introducing SCSS into the project was dead simple. It let the other developers work in CSS if they still wanted to, but I was able to get the Sass goodness I wanted by just changing the file extension.

I don't think it's far fetched for us to think that we will need to convert a codebase from CSS to Sass in the future and I would be uncomfortable just running a vanilla CSS codebase through a SASS converter and calling it a day. It seems much more approachable to me to incrementally rewrite CSS to leverage features of SCSS. This migration path is the main reason I've migrated to just using SCSS on everything.

Another thing I like about SCSS is that there is a very good chance it is going to become the next version of CSS. Just like with JavaScript, I like the idea of writing things in a way that might be browser compliant someday without transpiling.


why not to implement Iterable on Words, the foreach can be used


Thank you very much!!!


final


Bug: Fireballs are not falling down at the end of a floor instead they are floating mid-air.


should implemet Iterabel, not Iterator


I've added earlier commits (in my local version of the branch) in which the two YAML files are re-generated thus making it easier to see what's changed in this commit.


field, should have type of the Interface! Not the impl


LGTM but someone else should approve


I find `if` reads more directly than `unless`: `if refresh_token.revoked_at.nil?`


this need to be in the iterator, not here


Hi @samaaron ! What's the rationale for this change? Is it necessairy to switch from "Parameter" to "Optionen" in German, too?


@asartori86 The files only contain the string "DEAL::OK" so it does not matter which way. I guess this is just the way git picked the changes up.


plass I do not see where you changign the index?


This is my primary motivation since this is the behavior we expect on our projects. We use a dangling paranthesis whenever it is followed by a method call and generally forbid it elsewhere.
```scala
Foo.call(
   alpha = a,
   beta = b,
   gamma = g)
// and
Foo.call(
   alpha = a,
   beta = b,
   gamma = g
).asSomeView
```


In fact the checking of docker-py version was already in place...
saltstack#27451


I'd switch `unless` by `if !`.


Iterator is generic interface, do not use it withous setting the type like: Iterator<...>


Ok


The closing bracket on multi-line construct should line with either the first non-whitespace character of the last line or the first character of the line that starts the construct. ( PEP-8 standards)


``Clients`` au pluriel plutot ?


This method is too long, do you think we can do some "extract method" refactors in this class? http://refactoring.com/catalog/extractMethod.html


I've kept the same authentication as package_delete.

On Mon, Sep 28, 2015 at 3:56 AM, danmihaila <notifications@github.com>
wrote:

> for dataset_purge, do we need any validation or authentication of the user?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OCHA-DAP/hdx-ckan/commit/19e3380b399682b143c40f77e0120d57471dd0a7#commitcomment-13462501>
> .
>


even final fields should not be public in Java. use getter (this comments need to be applied acrodd all the models)


http://blog.jonanin.com/2013/11/20/postgresql-char-varchar/

tl;dr: Use TEXT instead of VARCHAR or CHAR; TEXT has exactly the same performance and space usage characteristics while being much more flexible.


Yea.. definetely it makes a culprit. Reverted this commit and so far there are no wakeups.


You are right with both comments.
I wish I knew why it worked for me, because it did, but I don't have access to the code base any longer.
Are you ok with me deleting this branch?


Makes sense.

I'm curious what prompted this, but I can guess it is undue load form some incorrectly configured setups.

We could scrap someone's watched resources page to pickup the version string for a number of add-ons at once. Probably would work better for installs with potentially dozens of add-ons.


I never continued/finished it but feel free to take the lead @algolia/javascript


That's what I was checking. I think that makes more sense, since most of the channel events will happen in the Express route file anyway


Maybe you can add this logic in a service.


Word that describes labguage is strange, not clear. You have type Words, but instead you are using the String to store Text, this also looks not logically


Typo ( :


nice catch


Tu as fait ce commit sur «ma» branche. Je suis pas possesif, mais je pense que tu voulais le faire sur ``master`` plutot non ?
Au pire c'est pas grave ; ``git checkout master && git cherry-pick 1c512c6384ca44f2c6e03c1b3150b18e5e43312a" pour importer ce commit dans master


You don't need oppo vendor  folder anymore
On Sep 28, 2015 3:34 AM, "martin coulon" <notifications@github.com> wrote:

> build error: vendor/oppo/msm8974-common:
> MODULE.TARGET.APPS.com.qualcomm.location already defined by
> vendor/oneplus/bacon. Stop.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TheLoonyBin/proprietary_vendor_oneplus/commit/162bc3390c754e5cf0c46f2f906c8db85e7a9bf9#commitcomment-13462224>
> .
>


to avoid empty interfaces, use branching. In the master bransh should be always latest code that is ready for full CR or ready to be deployed or presented to the manager


So, default Uid depends on version of SDK, new version - new Uid, is it expected behavior?


I would have expected a case like this to result in a rejection.


There is [good recommendation](http://technicalpickles.com/posts/configure-git-to-globally-ignore-some-files/) to put [os and editor specific ignores](https://gist.github.com/octocat/9257657) to [global .gitignore](https://help.github.com/articles/ignoring-files/#create-a-global-gitignore) instead of projects one.


could you make a pull request for that to my repo? (it's much easier to retain authorship this way)


Doesn't look like it... props is a string there


@mfc thanks for the helpful + good suggestion :)


This commit put back the broken example configuration JSON that was fixed in the previous merge.


Bug: Donkey cannot throw fireballs.


This will not work


fireball is not moving.


Need to add "d2lte". For awhile the d2 family was called that.


You're logic makes sense.  I think that we need to do a better job of handling asynchrony across the codebase as well, which this can be part of a bigger refactor for that since `util.cachedPrebuild` will need to be asynchronous after that.


$job is already managed by doctrine.


ok, sorry. my mistake, i missed it.


Shouldn't you use constants here?


Game does not over, when player reaches to princess.


Fireballs are not emanating from the donkey. (Unimplemented feature)


Is this per file or global?


To prevent the rewrite of all plugins, maybe you can add an symbol alias to the old name


done (both). If by any chance you do have a predefined criteria for this, let me know. Thanks.


Well:
1- A4Tech has tested it locally
2- On the PLi-board no real issues have popped up
3- We did take onboard unstable updates without saying.

So what's the point of stopping development?
And else let's do an 'openatv.conf PREFFERED_VERSION'


add the material design training.


What if you'd use LESS or SASS or CSS?


In the intermission and stats screen you can show a zoomed out, non-rotated map of the level just finished.


This revert was made because the flags of the countries outside the EU are missing, but the change is actually okay. We just need to add the missing flags back.


Bad Code.


Yes, I see. Ok, let it be.


> You're logic makes sense. I think that we need to do a better job of handling asynchrony across the codebase as well, which this can be part of a bigger refactor for that since util.cachedPrebuild will need to be asynchronous after that.

Yeap!


@ritwickchaudhry
Are you sure you want to work on a public repository? May not be such a good idea.. agar private repo nhi hai to gitlabs dekh le..


Update readme.md


to quote spaces, bash provides the printf formatter `%q`, `$(printf "%q" "$@")`


No, I can't because there isn't an "old name" (cf. commit message and the changes to the "test" and "skeleton" subsystems).


Podrías resumir el test 01 y el 02 en uno solo, no?
guardando en el primer retorno en una variable y en el segundo en otra variable.
luego haces los ASSERT correspondientes


In `writeXmlForBrowser` you are now modifying the global variable `outputFile`. This means that with multiple browsers, and `outputFile` initially `null` this will first take the second branch and then the first for subsequent browsers (in the if statement at line 45). You will then continuously concatenate the paths. That can't be right....


I still think having both command line arguments there makes it a little more confusing, but I'm fine to merge as it is.


Is this visible yet? Compiled last night and couldn't figure out how to create a new game.


No, these keys were defined in OrbitManipulatorStandardMouseKeyboardController?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.626](http://teamcity.monogame.net/viewLog.html?buildId=10351&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


What's the additional value of using `isxdigit()` here (only on the first character)? `_parse_linux_audit_hexstring -> _decode_xbyte` would fail on non-hex digits.


Actually the other add on installer has been going a bit haywire on a specific site and there was a bit of ambiguity over what was causing that. For some reason it's making multiple requests every second. It's not helped by said site running both add on installers (I don't know why). So a custom UA should be considered best practice for now. It will help us, at a glance, recognise somewhat greedy behaviour from add ons scraping XF.com.
That's actually not a bad idea. We would need a prerequisite that watching resources is necessary. Maybe it should be based entirely on that. No messing with URLs. Of course identifying when an update has actually happened is still tricky that way - but I think monitoring the "Updated" time stamp would help here. The update time stamp is available under each resource list item on the .DateTime element under the data-time attribute.
Chris

Sent from Outlook

    _____________________________
From: Xon <notifications@github.com>
Sent: Monday, September 28, 2015 1:29 p.m.
Subject: Re: [XenForo-AddOnInstaller] XenForo may soon begin to block traffic to its servers that have the default 'Zend_Http_Client' user agent. The actual requirements haven't been finalised, yet, but I suggested to Mike that add-ons doing this should probably identify the add-on and author, so currently the proposed format is AddOnId_XFUserId, e.g. AddOnInstaller_11388. (dd14455)
To: Xon/XenForo-AddOnInstaller <xenforo-addoninstaller@noreply.github.com>
Cc: Chris Deeming <chris@deemit.co.uk>

Makes sense.

I'm curious what prompted this, but I can guess it is undue load form some incorrectly configured setups.

We could scrap someone's watched resources page to pickup the version string for a number of add-ons at once. Probably would work better for installs with potentially dozens of add-ons.

—
Reply to this email directly or view it on GitHub.


Congratulations on the Check Score Bonus!


I agree though


Let's keep it for now. I'll delete it when I'm done.


There are still quite a few generated files in this commit. Generated files are any files that automatically get generated during the build (for instance .js.map, bin\*, etc). We don't check these files in because when another developer checks out and builds a project these files would be generated automatically. We want to keep the checked in files to just the "source" code and nothing else. Generated files also add noise and make reviews harder because someone looking at a commit would need to scan through all the generated files too.


`mdDialog: angular.material.IDialogService`


change it back, it works


Of course there still needs to be some aspect of URL management to know which add ons are installed. But getting the rest of the data from that page seems useful.

Sent from Outlook

On Mon, Sep 28, 2015 at 5:29 AM -0700, "Xon" <notifications@github.com> wrote:

Makes sense.

I'm curious what prompted this, but I can guess it is undue load form some incorrectly configured setups.

We could scrap someone's watched resources page to pickup the version string for a number of add-ons at once. Probably would work better for installs with potentially dozens of add-ons.

—
Reply to this email directly or view it on GitHub.


I don't believe this works, I havn't tested on xbmc yet, but the regex doesnt match to the end on http://regexr.com/

From what I saw, I thought the regex needs to match the entire json so that the json.loads works properly...

There seems to be 2 main types of dailymotion links, ones with 6 character urls, and ones with many more 19?


Não precisa desse método, já tem como default o findOne


TeamCity Gensokyo Lobby :: Lobster Core [Build 0.0.1.40](https://pixelated.design/build/viewLog.html?buildId=125&buildTypeId=GensokyoLobby_LobsterCore&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 282 Build time: 00:00:18


Não precisa desse método, já existe o findOne como default


What about:

    val updateAction = queryReturningId.insertOrUpdate(elem)
      updateAction.flatMap {
        case Some(id) =>
          afterSave(elem)
          DBIO.successful(id)
        case None =>
          DBIO.failed(new SQLDataException(s"Exception on insertin element $elem"))
      }


Just curious what you're doing with your email now. Why the change?


Java warns if full package name not matches with path to source files. Root for sources is java, package name is com.parallels.desktopcloud, so we must keep source files in java/com/parallels/desktopcloud


yes its sealed, but another developer could come along and want to add another. In any case, this isn't my project so I don't have a say in the style usage (although I certainly wouldn't agree that this is "good practice", for that case I think you'd be best explicitly refining your return types at the point of use). I'm just happy that the feature has been implemented.


Tendrías que verificar que todos los valores de ret son los esperados en las llamadas previas también.


Bad indentation. Used 3 spaces instead of 4 according to pylint!


This block is obsolete. Use a consolidate view of the pool request


just wondering if we should add parens around the ternary operator.. I'm always very confused with operator precedence rules ;)


@gaganawhad the descriptions on your `it` methods should be updated to match what you're doing. Otherwise, this looks right.


what do you mean?


function initMap() {
  var map = new google.maps.Map(document.getElementById('map'), {
    zoom: 11,
    center: {lat: 41.876, lng: -87.624}
  });

  var ctaLayer = new google.maps.KmlLayer({
    url: 'http://googlemaps.github.io/js-v2-samples/ggeoxml/cta.kml',
    map: map
  });
}


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 41](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=223&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Nice catch!


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 41](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=223&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:48


Hi @cmeerw, please, send the PR. I was being on PTO since almost a month and I'm back, less busy than this summer :)

Thanks!


I want to make it clear that these are optional and not required :)


This comment seems to be copied from Merge, and in several cases says things that don't apply.


```php
`which ruby | grep 'bin' | awk '{print $1}'`
````
?


TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.34](https://pixelated.design/build/viewLog.html?buildId=126&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:19


Already tested it in-game before pushing the branch, didn't see any issue.


Jump not implemented properly, player does not jump straight up and towards left


I have the problem too with version 0.3.5. The path for the first browser is fine, but for the second browser the path is wrong:

```
28 09 2015 14:41:24.416:WARN [reporter.junit]: Cannot write JUnit xml
	ENOENT: no such file or directory, open 'myProject/reports/PhantomJS_1.9.8_(Mac_OS_X_0.0.0)/myProject/reports/TESTS-Chrome_45.0.2454_(Mac_OS_X_10.10.5).xml'
```


Not yet.
You can copy the contents of the build/data folder to games/[GAME-NAME] and then click on open in the editor to open it and it will show a dialog with options (Rockbot 1 is the build/data folder, any other ones are on build/games folder). But there is no way yet to make a new game from the editor itself.

I'm thinking in getting a game and making all stages empty and changing images to placeholder images to use as base for the "new", but I should be able to work on that only in the next weekend. Meanwhile I'll resume work in the scenes editing tool that is shaping nicely ;)


Class names should normally use the CapWords convention. (PEP-8 standards)


IndexError is there if player tries to move either left or right while on ladder


```php
# Get Ruby bin dir
`which ruby | sed 's/ruby$//'`
```


std::string strResponse;
    CURL* curl = curl_easy_init();
    curl_easy_setopt(curl, CURLOPT_URL, "http://120.25.81.161:8080/XYJR/clientapi/getSysTime");
    curl_easy_setopt(curl, CURLOPT_READFUNCTION, NULL);
    curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, OnWriteData);
    curl_easy_setopt(curl, CURLOPT_WRITEDATA, (void *)&strResponse);
    curl_easy_setopt(curl, CURLOPT_NOSIGNAL, 1);
    curl_easy_setopt(curl, CURLOPT_CONNECTTIMEOUT, 3);
    curl_easy_setopt(curl, CURLOPT_TIMEOUT, 3);
    CURLcode res = curl_easy_perform(curl);
    if(res != CURLE_OK)
    {
        qDebug("http error: %d\n", res);
        qDebug(curl_easy_strerror(res));
    }
    else
    {
        qDebug("http ok!");
        qDebug(strResponse.c_str());
    }
    curl_easy_cleanup(curl);


ok, yes


I think this should be mdl-card--border?


no need for proguard


Does this work for more then just cards? If yes, would you mind pulling this into `attributes.js`?


well, originally decoding was attempted on all key-value pairs, without having the table of potentially hex-encoded fields. There it really makes a difference to have a "fast" decision whether to start the longer/slower decoder or not.

now it is only applied for relevant fields, but still it is much faster to skip a name-value pair based on its first character (and its length!), than it is to check the list of fields that are potentially (but not always) encoded.

that's the rationale. I haven't really checked how fast kv-parser is, so we can call it a bad habit, but an audit line can have as much as 8-10 key-value pairs and a busy system can generate thousands of such entries per second easily, so this condition is executed on the order of couple of 10k/second.

From this, only about 5% is potentially hex encoded, and of those only a fraction is really encoded (e.g. contains either of NUL, control chars, or chars above #126, or a quote).


@edolstra thanks for doing this, and sorry I haven't had time to look at it :frowning:

Looking at your fix, I'm now not sure why this used to work for me. Any ideas? I tested a couple of days ago and the PR branch this came from is able to run these tests fine.


cool method to slice and forEach in one command :)


Remove it completely or uncomment


Naming of variables and classes are not according to PEP-8 standards.


I'll revive it when I get some time, but it did actually work pre-merge! No idea how it broke afterwards :sob:


Player start moving from ground platform after reaching queen platform


formatting? maybe we should consider 2 space formatting as well everywhere.


Can we have a test spec that validate it ?


@cadl 花了好多时间终于明白是怎么回事了，就是这里比较坑
顺便修了一个可以往自己腿上放方块的bug


Bad code smell: Too many if conditions can slow down the program

Should be avoided (and in place if some elif can be used to speedUp the program)


The point here is to exit task immediately if there is nothing to do — not much in terms of performance, but I think it's more correct approach

Alternatively we can remove `grunt.log.error` here and return `resolve()` which will throw Promise to final part, where results will be printed.

I'm ok with any solution, but I'm pretty much ensured that Task should inform you about results, and if nothing was done — it should inform about it too


Player does not die anyway.
Donkey doesn't kill  player


Hmm, you have a point. I didn't realize that cases were intended to be stacked like that, TIL.