>для такого маленького проекта и кучи мелких исправлений я запарюсь больше коммитить.

Решать конечно тебе, но есть и другая сторона:
а) привыкнешь делать красиво/правильно с самого начала
б) научишься чему-то новому (например, как сделать два коммита для двух изменения в одном файле?)
в) кто знает, может быть твой будущий работодатель решит посмотреть твой проект на гитхабе? Или даже поревьювить его и позадавать тебе вопросы по нему на собеседовании? (со мной такое было) Небрежность и неаккуратность в мелочах может сыграть плохую службу, если среди нанимателей окажется человек весьма дотошный, вроде меня :)


Until I've finalised the grid layout (documentation pages will be 2 column) I won;t have an exact size for images. The grid is my next thing to do (as it also appears on .com site) so won;t have to wait too much longer. it'll be after my holidays though, so around first week of October.


Ik vind dit geen mooie naam !


mjee.. i guess switch-context is a good candidate. Though maybe we can make this a switch-state to be more powerful?


Ah, understood. Still, we could change `labels` array to some `length` (a number) props, and then build `labels` inside TimeRangeFilter() using `length`. In this case `length` is 5.


I think I can confirm java8 version introduced regression in this test in a way in order to pass this test it should expect `java.lang.Integer<1990>`.

When setting maven compiler target to `1.6` `java.lang.String<1990>` should be expected.

Since we have to stick to `1.6` I will revert this change.


echo?


Да. Let me google that for you :)

- http://stackoverflow.com/questions/729692/why-should-files-end-with-a-newline
- http://unix.stackexchange.com/questions/18743/whats-the-point-in-adding-a-new-line-to-the-end-of-a-file
- https://robots.thoughtbot.com/no-newline-at-end-of-file


1. Yeah. I understand what an interlaced material would suffer. But if I understand correctly deinterlacing will not work at all on rewind because buffers has a different (in time) frames. for proper work of deinterlacing it requires a neighbor frames. Does DVDVideoPlayer produce a neighbor frames on rewind?
2. Yes, this is a kind of workaround. Currently only WinRenderer allows past frames and this is why I've placed workaround into WinRenderer before. Don't know about all renderers but WinRenderer requires at least one frame for successful rendering in all cases.
3. Understood. No it doesn't know the status.

as a result I think your suggestion to split stats in RenderManager::GetStats would be a most preferable.


Trying to merge form original repo to my fork.


The file was made with Cura and the Medium profile.
https://gist.github.com/fsukalia/d58e9a319fffdef90e10


make sense, will change it to preperty


Навряд ли работодателю можно показывать примитивный проект типа этого. Засмеют ведь )) Скажут - чего helloworld показываешь? ))


This commit is being reviewed as a part of review issue #7.


> No blinking when we get back to original state. This gives a clue that we cycled back to start.

Cool! Will try later today.

> if the whole function call got blinked

yes. I think this is a good idea.


small test i did correct btw :P


So I figured out the w.Activate(); is pointless. Visual Studio will simply sometimes decide it does not wan't to get focus. Oh well. Thanks Microsoft.


Hmm, this code was in the original source code as downloaded from ID way back in 1997, so some clot must've removed it!


@SrdjanMicin

Da li je ovde i dalje the_player ili je sada to malo prepravljeno?!

Poravnati komentare sa kodom.


wrongly placed comment ?


+Nguyễn Văn Thanh : 20112273


I am fine if you submit this to isengard branch, then we have more time to think about a better solution for 16.0. But please move NeedBufferRef as first condition to evaluate.


Planning to add unit tests with next pull request.


`addcssjs` can't be loaded on my MacOSX, so I removed it for now. Do you have any hint to get it working?


google стало глаголом? ))
спасибо, я понял )


I see, thanks for the help and motivation snicolet :)

Can you please explain how the best value is determined in SPSA from the graph?


Is the `sb = s.b` necessary for the `@inbounds` to work or is that a separate improvement?
I've seen this before (and had it in my first attempt), but I forget why.


please fix your commit message.


Yeah, and it was in Doom Retro up until v1.6.5. I must have taken it out after seeing Lee Killough's edits in WinMBF.


I will never use spaces, adjust your editor to show the tabs in your prefered size.
Entity info window is not the only window that needs rework, patch inspector too.


Hm. I see. Maybe a better solution would be to avoid using cl functions then?


ok, will fix name


The test suite finished running the test files. Below is a summary of the test results:

| Report name | Tests passed |
| ----------- | ------------ |
| _Broken | 15/15 |
| _DVB | 5/5 |
| _DVD | 3/3 |
| _DVR-MS | 2/2 |
| _General | 24/24 |
| _Hauppage | 3/3 |
| _MP4 | 2/2 |
| _NoCC | 10/10 |
| _Teletext | **20/21** |
| _WTV | 13/13 |
| _XDS | 34/34 |
| _Options | **83/87** |
| _DTVCC | **0/14** |
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the [results](http://ccextractor.canihavesome.coffee/reports/94) page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.


Need someone to do all the icons for Quake 3 arena (and Defrag), only got weapons and ammo icons.


ok, will update to "ARecordBase"


>Навряд ли работодателю можно показывать примитивный проект типа этого.

Реальный случай: я проработал на двух проектах, где делал интранет порталы. Собеседуюсь в другую компанию, они хотят посмотреть на мой код. Код с прошлых работ я им показать не могу, т.к. а) его у меня нет б) если бы и был, то я не могу его показывать, т.к. он принадлежит прошлым работодателям И что мне им показывать? Ничего или хоть какой-нибудь hello world? Я показывал свой hello world. Лучше чем ничего.


whatever this comment was


No problem ;)
Thanks for taking a look at the changes!


### Missing semicolon.

```
return "Hello, World!"
                      ^
```


### Use '===' to compare with 'null'.

```
if (bla == null) return;
        ^
```


Anyone applying this patch, please make sure to disable sleep_disabled via ramdisk after boot completes.


Hehe. :-D


those leftovers. xD


Esto es un repositorio


- Replace them with builtin functions or cl macros
- Use cl-lib instead of cl.el.(However this lets older version emacs users install cl-lib.el)


presense of the field was just verified one line upper:
>if field in kwargs:
So it is absolutely safe to do 'kwargs[field]'


dlaczego nie 3?


It's not a minor changes. I added processing of union fields in structs.


make sense to do it a property, bu t I would prefer to use a shorter name for the property, just 'infoblox_type' .


Твой helloworld - это mystamps что ли? )) Фигасе helloworld...


nie jest zły ale spróbuj to zamienić na selector css
http://code.tutsplus.com/tutorials/the-30-css-selectors-you-must-memorize--net-16048


Why is that `\\|` before the `lang`? It should be `\\(`, right?


@ivank I am pretty sure we should not use the signed request. It is provided for apps living as Facebook Canvas apps. Why not use something like this:

``` php
$response = $fb->get('/me');
$userNode = $response->getGraphUser();
$userId = $userNode->getId();
```


This commit broke non-OMP builds, for some reason, see https://github.com/magnumripper/JohnTheRipper/issues/1769

I did a git bisect, and it pointed to this commit.


Да. Когда-то он был меньше, да и сайт у него появился месяц-два назад, а до этого его никак нельзя было даже посмотреть, кроме как запустив у себя локально.


Yes. We will probably should switch to cl-lib. Maybe next year. Merging this for now. Thanks.


The last test seems to suggest it works now.


Well I've been following [this tutorial](https://benmarshall.me/facebook-php-sdk/#user-profile), but you might be right


thanks for the good work. merged.


ok


Sorry about that.


Well, the tutorial might be correct in its own context. Have a look at https://developers.facebook.com/docs/php/gettingstarted/5.0.0#making-requests. This seems right to me and more consistent with the way they have provided the data before.


yeah, will make 'return_fields' as a property


qtconcurrent is usually a runtime dep too, can you explain this choice?


Or may be not, and this commit just managed to expose some other bug. Reverting this commit didn't help to make issue https://github.com/magnumripper/JohnTheRipper/issues/1769 disappear.


If you want to optimize it and not perform a network request - there's more info here: http://stackoverflow.com/questions/23623268/get-facebook-user-id-in-fb-php-sdk-4-0


don't forget to call `cmake-utils_src_prepare`


I just do not see how .  This commit only affects valids.


cls.from_dict can not be used, since cls usually represents another class than local_obj,
however local_obj.from_dict (or local_obj.__class_.from_dict) should work fine.
Will update this part


Czy odpaliłeś ten test 5x na chromie i 5x na ff i za każdym razem przeszło?


> cls(connector, **kwargs)
has built in logic (in __new__) to return versioned object, so in most cases it returns instance of another class rather than incoming cls.
To parse reply from NIOS we should know versioned class.
So parsing_class stores versioned class, which is used to parse reply from NIOS.
Probably will not store parsing_class here, just will use local_obj.from_dict()


shouldn't it be "extra-"  instead of "extras-"
what I got from https://github.com/elixir-lang/ex_doc/issues/376
extras was as the lists of values, in mix.exs
but --extra (as in the command line option) as for each individual page.

Are we doing this to avoid a name collition with one of the modules?

Personally i find it a bit too much to prefix everything with extra(s).
we could just use "-", and no collition will happen.


will fix


oops, should be 'exclude'


Working late on a Friday night eh? :smile: Yeah it does get confusing


We have tested sending a "M106 0" and a "M106 255" (both included in your gcode file) to turn off and  on the blower fan. The blower fan is turned off and on as expected. Therefore, the problem might be in the electronics involving the blower fan. Check that the connection is OK in the fan, the cable to the board and in the connection to the board.


Why was this removed? Seems like it does not have to do with this issue?


Check 'if not ips_v4' ensure that it is not blank list. And custom_field_processing is used only for replies from NIOS, so I believe we are ok here


@KacperMadej @pawelfus Thanks for the fix! Just a note on best practice: Setting up the test to check against a specific path may be a bit too sensitive. If we change some design related options in the future, even something trivial like chart.marginLeft, the path for the whisker will change. So the test should be designed a bit more general, for example check that the bounding box width is within a certain range.


Good.


@pawelfus You read my mind :+1:


Sure thing!


Yep, i think too that we find further ideas and get some additional elo from  this.
Good luck for your running and future patches!


why is `NETSTACK_LLSEC.get_overhead()` gone?


**no-unused-vars**: changeInfos is defined but never used


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for _onError


I agree, that the creation of a default `user` is problematic. That's why I advocate using a group: using a data migration, a default group can be created (without any security issues). Then in the admin-interface one or more admins are added in production (not in the script). It is possible to list all admins, and if there's nobody in that group, show a different version.


ok


Done https://github.com/caskroom/homebrew-cask/pull/13819


another nit-picking suggestion.. ;-p
I think extras-api-reference.html should be renamed extras-API-Reference.html
to be consistent with the other pages in the sidebar.


Use the mechanism we already have in place: use `env`.

`env.str('ACCOUNT_MANAGER_USERNAME', default='admin')`


sorry, maybe `ext_struct` is better here, and then below `constraints` can become `basic_constraints`?


how about `max_payload` instead of `MAC_MAX_PAYLOAD`?
same issue addressed here :) https://github.com/contiki-os/contiki/pull/1119


A, I see what you mean, yes it will do a filter based on whatever tag (key and value) you pass in - the tag does not have have a key `Name` only - it can have any key and value. I only setup the help to read as:

```
Only snapshot instances that match passed in tags. E.g. --tag Name:foo will snapshot all instances with a tag `Name` and value is `foo`
```
But we could set that up to something more explicit / user friendly. I'm keen to know what you suggest we should put in there :smile:


ok, why not `max_payload` here?


same here


hey, could you add a github tag to go along? thanks :)


code style
```
if(frag_context == -1) {
  return;
}
```


why keep the line commented out?
please also avoid single-line comments


Theoretically yes. As it was it was wrong (sorry, I didn't realize it before):
If you ask for *.redhat-1 you shouldn't expext *.redhat-2


revert this.


@dangra this is backwards-incompatible change to some extent. I know it wasn't a part of public API but we have > 20 spiders that were using `scrapy.xlib.pydispatch.dispatcher` to connect to some signals in `spider.__init__` and there's not way to do that from `crawler` as `crawler` object is not set in `__init__`. Looking for a way to remove that from repo, but maybe it should be possible to use `scrapy.xlib.pydispatch` with deprecation warning?

```
  File ".../spiders/blahblahblah.py", line 8, in <module>
    from scrapy.xlib.pydispatch import dispatcher
ImportError: No module named pydispatch
```


@bonsaiviking there isn't a place holder for prefix in this format string; any idea what it should be?


This, however is wrong, there should stay redhat-2


Should be return (pageInfo.mbi.Protect & (PAGE_EXECUTE | PAGE_EXECUTE_READ | PAGE_EXECUTE_READWRITE | PAGE_EXECUTE_WRITECOPY)) != 0;


This is also wrong, there shouhl also stay redhat-2


No closing `>` caused a parsing error here @kchanba


this isn't used anywhere in the PR is it? (I suggest to remove it not)


This was the main problem. Yet obvious, you can´t put this library, since the MSP has no terminal.


@davidfestal I don't quite understand the semantics of `getTypecheckedRootNode()`. This is one the editor can use concurrently even if a build id currently in process?


I'd rewrite this as follows:
```python

def get_admin_user_or_none():
    admin_user_name = settings.OSMAXX['account_manager_username']
    admin_user = list(User.objects.filter(username=admin_user_name))
    if not admin_user:
         return None
    return admin_user[0]

view_context = {
         'next_page': request.GET['next'],
         'user': request.user,
         'admin_user': get_admin_user_or_none()
# ...
```


You can use ``setVisible(not isHidden())`` here for short.


Bad problems :  https://github.com/magnumripper/JohnTheRipper/commit/4e39b7e608e5bb09624c0b455561c73700e6f24f

This should be removed, until the problems are found.  jtr searching is greatly impacted.  There appears to be memory overwrite problems, or something like that.


requirejs aload controller can't work  why


Hi Igor, "service networking restart" is deprecated, and normally it does not work because it may not enable again some interfaces. An even better method may be "ifdown eth0 && ifup eth0".
I tried it and it works.
Thank you for your contributions Igor.


@tuexen @micchie

Hey Michio,

tested your patch, had no panics anymore. lgtm
Thanks!

Cheers
Felix


This looks like a great solution man!


the result of i2cRead should also be checked and/or productId  should be initialized.
there is another i2cRead  in line 330 which could also use a result check.


'ack' should be negated in this check.


Were this line removed intentionally? This breaks interprocess/containers/pair.hpp. piecewise_construct_t is defined in boost/container/detail/std_fwd.hpp, but piecewise_construct isn't.


No ,but I didn't see any difference in my main method in this case.


Agreed on `extra-` although I am not a fan of only `-`. Does anyone have a better suggestion? Maybe just `e-`? I think that would be confusing though.

> I think extras-api-reference.html should be renamed extras-API-Reference.html

What if I just downcase all filenames?


Good point


did you... directly edit .min.js? o.o


it's not precisely that it can be used concurrently with a build.
It's more :
if a build typecheck is in process, the CPC typechecking might have be cancelled at least once (because the source model read lock could not be acquired). In such a situation, the `getTypecheckedRootNode()` will return `null` because we can't have a root node that is equally consistent with the last source code *and* typechecked.


No. Really not. We should not use exceptions for program flow!


Looked at the checkstyle and findbugs reports and the code itself. You have my approval.


Vertical, not horizontal


"Canola" is misspelled.


could consolidate the identical parts of these two branches.


no need to `clear()` it, i guess?


Candidate for IN_SET()?


I will create an issue to move this to groups if we implement a request form. At the moment it makes no sense to create the ability for more than one 'admin'.


you only consider the main and control process now. I am pretty sure you should also consider everything else that is in the cgroup.


To say it differently :

`getTypecheckedRootNode()` will return the most recently parsed root node *only if the CPC has run until the `TYPE_ANALYSIS` stage*. Else it will return `null`.

because returning something else would introduce inconsistencies : either against the source code or Ceylon model inconsistencies


Sounds like a candidate for "strjoina()".


Shouldn't we set errno to `ENOENT` here?

BTW, the line above misses a space in `catch (Symlink_resolve_error)` according to the coding-style guidelines.


So events can't be added now...


Should not be an ```unmodifiableList```. Possible?


haha :P


Thanks for raising this pull request, i've seen this issue registered on a forum post as well. Thanks again for fixing :+1:


I have having coffee and I thought of "e-" ... I came here, to comment, but you already did. :-D

another option could be underscore as a prefix (it doesn't look confusing as "-"). the only downside is when highlighted in link, it may look like a space.
```
/e-API-Reference.html
/_API-Reference.html
```

about downcasing,... what if there two files with the same name when downcased.


Hello. I had commited the polish translation for scaneme/GameConqueror.

---
Michal D.


These would be provided by using artisan vendor:publish.


make sure , you are not breaking packaging


Added "Build your own VM in the Cloud with AWS"


co to jet


Nie zwróciłem uwagi na wersję. Zmienię na 3.3.0


> about downcasing,... what if there two files with the same name when downcased.

Most file systems are case insensitive, we don't need to worry about it.


Moje niedbalstwo.


Why key binding "run-command-terminal" is removed?


@flavour This is not working in the custom form. It does not show "Create Repository" link from S3AddResourceLink, nor it show like S3MultiSelectWidget nor the create options seems to work. It appears like this:http://i.imgur.com/8IAFiwV.jpg
But this works (link and create options) in the data model. What am I missing here?


To sum up, @eksperimental, @milmazz and @Dignifiedquire, which one do you prefer?

1. `/_api-reference.html`
2. `/e-api-reference.html`
3. `/extra-api-reference.html`

?


Odpalałem tylko na FF. Tak się ucieszyłem, że w końcu działa, że nie zrobiłem większej próby.


I am a nice comment


This complexity appears unnecessary, no? I mean, there's only one name for each socket, hence the we can leave socket_colllect_fds() as it is, and the caller of the function then just accesses the name directly, independently of this call? No need to make this a strv repeating the same string over and over again, which we free anyway right-away...


See https://github.com/magit/magit/issues/2246.


you can do it in one line.


you can do it in one line.

Widget::getInstance()->setVisible(true); // show window if it was hidden


Of course, if we accept inconsistencies against the source code (at the price of some wrong action result possibly), then we could use `getLastCompilationUnit()` and remove the `isEnabled()`. But I'm not sure it's the right choice to do.


We generally ignore errors when deserializing state, but log about it. THis is to make upgrades somewhat robust, where we better log and continue with whatever we can get intead of completely fail deserialization.


What is this change supposed to do?


Also, please do not do errors like "-1"... always return proper errors such as -EINVAL or so...


`extra-` is good


Ostatnio brałem udział w webinarze na temat wyszukiwania elementów i jeden z tematów miał odpowiedzieć na pytanie co jest lepsze - xpath czy css. W skrócie stanęło na tym, że różnice są tak mało znaczące, że w ich używaniu można stosować pełną dowolność w zależności od osobistych preferencji. Rozumiem, że Ty jesteś fanem cssów?;)


Thanks!


DMESG : http://pastebin.com/J6v9MS7g
Logcat : https://paste.ee/p/EAX6l
Logcat Radio : http://pastebin.com/afCErjux

I hope it will be useful


Yes, really! This is not C, it is Python and actually considered a good _pattern_ ['Easier to ask for forgiveness than permission'](https://docs.python.org/2/glossary.html#term-eafp)


Close #699.


The difference is that you can no longer write
`MatrixOperations matOp = new MatrixOperations()` anywhere except in the `MatrixOperations` class.
You have to write:
`MatrixOperations matOp = MatrixOperations.getInstance();` in order to create an instance of this class.


Debugging line


@perrozzi

#### Controlla che quello che ho scritto abbia senso

Questa schifezza di commit mette una pezza a un bug che ho introdotto io in f105b8e.

La variabile `fJet` della classe `RecoilCorrector` viene modificata da `CorrectMET3gaus` alla riga https://github.com/12345ieee/cmg-cmssw/blob/master/CMGTools/WMass/analysis/AnalysisCode/RecoilCorrector.cc#L270 , che però viene chiamato dopo `reset`.

Questo fa si che `reset` sia sempre un entry indietro rispetto a dove deve essere davvero.
Fortunatamente ora correggiamo solo un bin di rapidità alla volta, quindi il problema c'è solo con il primo evento di ogni chunk (che sono comunque migliaia), in cui `fJet` è `0` (vedi costruttore).

Si poteva anche risolvere facendo updatare `fJet` a `reset` come prima cosa, ma io ho paura a modificare quella classe.


I''ll  go with "e-" , and down with "_" since from what i read it is discouraged by many SEO sources, including google itself as a url separator.


@tarsius, thank you. It looks like this is the same issue. Unfortunetly I won't have access to my work windows PC in the next two weeks, so I won't be able to help with testing.


Unfortunately? Happy vacations!


We could also go with `-extra` at the end, not sure if it makes a difference. I added it as an option.


piecewise_construct_t is only used for piecewise_construct, if the later was not defined, how can it break code?


I think I'd err on the side of leaving the hardcoded values of `7` and `5` in the test, partly because I'd be paranoid my tests wouldn't raise an alarm if someone changed ITEM_LIFETIME_IN_DAYS. Even if the change was on purpose (say increase lifetime to 14 days), I'd sleep better with some test coverage to patronize me with "you used to have this be 7 days! are you sure or did you make a mistake?".


I thought dir, base, ext would always be pointers because util_alloc_file_components(...) will only change the content of that pointer?


ok, so this stops random from choosing another sampleBank. Now it only randomly selects a sample in the current bank.


Haha, thanks! I


github desktop was wonky and didn't actually commit my _init.js changes so they're in 21c118b1050d54606dd1604b14fd5b757a5c3783


Great, thanks!

- Michio

From:  Felix Weinrank
Reply-To:  nplab/multistack
Date:  Friday, September 18, 2015 at 13:07
To:  nplab/multistack
Cc:  Michio Honda
Subject:  Re: [multistack] Checking for null pointer (8a2503b)

@tuexen @micchie

Hey Michio,

tested your patch, had no panics anymore. lgtm
Thanks!

Cheers
Felix

—
Reply to this email directly or view it on GitHub.


This rake task knows a lot about the inner workings and business rules of our `Item`s.

How could you make the rake task less aware of the business rules for deleting expired items?


This also includes the hiding tooltips on esc from my previous commit


Tá show. Em ehBissexto, já revisou se há redundâncias?


I am a nice comment


C'est vraiment le genre de fonctions qu'on peut élégamment transformer en itérateur :
~~~
def iter_datadirs(self, subdir=None):
    for directory in self.config['datadir']:
        fullpath = os.path.join(directory, subdir)
        if os.path.isdir(fullpath):
            yield fullpath
~~~


I thought that private members would be hidden by default but it is not the case. We should in fact mark all public methods as visible. See https://gcc.gnu.org/wiki/Visibility


This is wrong! This has to be `api.process_pdf_stream = self.rais_grobid_request_error`, now that the API changed.


This commit is being reviewed as a part of review issue #64.


I am actually not entirely sure, I've had issues in the past when not specifying the full template for params and return types and afaik it does not harm.
I can test leaving it out and see if it works.


In interprocess/containers/pair.hpp, there is a line "using boost::container::container_detail::piecewise_construct;" that doesn't compile anymore now. No idea if it's needed there.


will do :)


Je me trompe ou cette fonction n'est utilisée nulle part ?


@Rocky640 OK, I'll give it another try this weekend.


Shouldn't this use ``sort_keys=True`` – ?


ok, it didn't. whatevs.


@carolstars1 missing "to" in this sentence. Students will learn how "to" use control flow statements.


Without this change, the fan works. So the problem is not my hardware. The fan is correctly connected to D9.


"Можно не указывать" или "не нужно указывать, потому что так делают только тупые ламеры"?


also make symbols hidden by default.


@grovecj

One of those is for Java one is for Scala.


@subutai Nice to see this. Is this research heading towards Hermansky's Neural TRAPs ?


Would be good to have this description reflect what we're actually testing for now - a successful response.


This commit involves very bad coding style. It is just to catch up the final release. Gonna have to refactor the code to do the positioning in a more clever way.


1: M111 unrecognized component name: legacy


Same question as @mflorea.

I also agree that need a better solution.


Theoretically it shouldn't be required - even if the order in a dict isn't guaranteed it should be consistent within a single process (python version really). Also given that query cache is not on by default it makes me hesitant to add another step.

But it is a good point and I think the key sorting won't add much overhead. I will run some tests and make it happen if it's cheap enough. Thanks for the tip!


2 причины:
1) хотел потренироваться в создании валидаторов;
2) не знал про стандартные валидаторы из hibernate.


This is a separate improvement.  In general, compilers seem to be bad at caching type fields, I'm not sure why; I've seen this even in C, where C compilers typically can't stick `foo.bar` in a register unless I copy it to a local variable.

Maybe I should file a Julia issue if I can boil this down to a small example.


I'm OK with `extra-` or a new directory called `extras` (`extras/*.html`)


So... I have some hesitation about having things that are going to be displayed in the browser (I assume, given the `span`s) generated this far down. Right off, with the way the JSON is generated below, I don't have a better suggestion. It might be worth exploring in the future if there's a way to more clearly separate the data from the display. I think it's ok to do it this way for now.


This commit is being reviewed as a part of review issue #94.


@luiges90   为何地图上显示的时间不对？


@josemarluedke  ignore it.. i got it  :+1:


Как сделать так, чтобы не создавать бин в конфигурации вообще? Это по сути у меня костыль, так как если не создать бин явно, то Спринг вообще его не создаст и будет not found.
Я же обозначил HomoDao как @Repository. Спринг по идее должен сообразить и создать синглтон бина. М?


Those are defined in compilersupport_p in another hunk, but are not used here.


For me to get to this point, I already know it's a repository and I definitely know it's Open Source. I need you to talk about what this app really does and the purpose why it was created.


Ah! It's unused also in Interprocess, I've removed it:

https://github.com/boostorg/interprocess/commit/d4c601183157551de503b849ddbbb2e8b9d470ff

Thanks for the report.


@philipnrmn are you fine with me pushing a new commit to make use of our `isValidPort`? Or do you prefer taking care of it?


Is it possible to include these in the `.po` file and use ugettext at some point along the way?


Что это даст?


 tree height is logaritmic,
 -> logarithmic


looks good!


I though you had a valid cert?


I need you to put back the `build` and `MIT License` status badge. Let the build badge reference the repo on circleci


So, same question as in `ss_calculator.py`, is it possible to include `TOO_YOUNG_ES` and `TOO_OLD_ES` in the `.po` file and use ugettext somewhere?


Not sure it works, but `/etc/init.d/mysql stop` would be more gentle for the cleanup of the running mysqld


Thanks!


:ok:


This is unnecessary. `foreach` will not execute if the array is empty anyway. Also, TIL:
```
php > var_dump(count("string"));
int(1)
```


Discovery server id. Also, we should ideally toggle inswcure by specifying the url, so that it's still verified but not signed by a CA


**no-undef**: "describe" is not defined.


**react/display-name**: InputDate component definition is missing display name


**no-unused-vars**: DataRangePicker is defined but never used


Awesome, but there is no part that indicates  running the migrations. I also need you to add the technologies used in this project


si mi sembra ok, grazie


@EricWittmann looks like this caused the test suite to fail.
[ERROR] Failed to execute goal on project apiman-test-suite: Could not resolve dependencies for project io.apiman:apiman-test-suite:jar:1.2.0.redhat-621011: Could not find artifact io.apiman:apiman-distro-db:jar:1.2.0.redhat-621011
Mind having a look? I could just comment it but I know nothing of the project so wasn't sure :-)


You need to add an MIT license and reference it here.


can you push the hive compatible client code?


Page_execute bit mask isn't enough? I thought this was included in all of
them. Page_execute|page_read should be the same as page_execute_read

On Fri, 18 Sep 2015 12:59 mrgreywater <notifications@github.com> wrote:

> Should be return (pageInfo.mbi.Protect & (PAGE_EXECUTE |
> PAGE_EXECUTE_READ | PAGE_EXECUTE_READWRITE | PAGE_EXECUTE_WRITECOPY)) != 0;
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/x64dbg/x64dbg/commit/eac21d6a3b142b1916ff62e26c1d5c54e8e14ccb#commitcomment-13308087>
> .
>


You don't need `buffer`: just pass NULL.


Of course you can make it mutable, but I strongly recommend you to use immutable entities:

* Thread safety
* No problems with inconsistency
* No state, mutability == state, more states -> more bugs!


Should infer this just because id is provided, not actually allow to pass it in by the user.


 +	// unsafe.  It consists of 24-bytes for each of key and value + 8 bytes
+	// for the each of the priority, left, and right fields (24*2 + 8*3).
--> 24 bytes for each key and value + 8 bytes for each of the priority, left and right fields (24*2 + 8*3)


Всё ок можно мержить


Is there anything we need from `Mage_Core_Model_Abstract`? We seem to be disabling all the code functionality of it anyway. Could do with just a `Varien_Object`?


what does "valid" mean ? does it mean "relative" ?


Mówiłem o tym na ostatnim Quake'u w Techspec'ie. Różnice miedzy css i
xpath'em są. "Osobiste preferencje" w programowaniu zwykle oznaczają, że z
dwóch możliwości rozwiązania problemu, z których jeden jest 'dobry' a drugi
'wystarczający' ktoś wybiera 'wystarczający'. Zwykle dlatego, że nie
potrafi powiedzieć dlaczego coś jest w danym przypadku dobre a coś
wystarczające. Polecam też zapoznać się z taką ideą jak semantyczny html.
Co to za webinary?

On Fri, Sep 18, 2015 at 1:33 PM szwendacz <notifications@github.com> wrote:

> Ostatnio brałem udział w webinarze na temat wyszukiwania elementów i jeden
> z tematów miał odpowiedzieć na pytanie co jest lepsze - xpath czy css. W
> skrócie stanęło na tym, że różnice są tak mało znaczące, że w ich używaniu
> można stosować pełną dowolność w zależności od osobistych preferencji.
> Rozumiem, że Ty jesteś fanem cssów?;)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/szwendacz/base/commit/a5c94653b25144721dace4b860eebb051d0df5ba#commitcomment-13308550>
> .
>


Here's how my transactions look:
https://github.com/Peerapps/Peerapps/blob/master/blockchain_func.py#L117

Change goes to vout[0], with op_return after that - which means it should be fine with the above, right?

Note that in the current implementation, nodes are not propagating the transaction and I haven't been able to drill down to why yet.

I agree with mably on this though - we should try not to diverge from bitcoin core if at all possible.


@locutus2 maybe this test will give better results using 8moves_v3.pgn to increase chances of the outcome being decided in the endgame.


This should probably be 'Point', right?


They are essentially the same, `bquote()` uses `substitute()` in it's implementation.

```r
function (expr, where = parent.frame())
{
    unquote <- function(e) if (is.pairlist(e))
        as.pairlist(lapply(e, unquote))
    else if (length(e) <= 1L)
        e
    else if (e[[1L]] == as.name("."))
        eval(e[[2L]], where)
    else as.call(lapply(e, unquote))
    unquote(substitute(expr))
}
```

Withr could have used `bquote()` as well with a very small change

```diff
diff --git a/R/with_.R b/R/with_.R
index f0be3e7..01be4bc 100644
--- a/R/with_.R
+++ b/R/with_.R
@@ -39,9 +39,9 @@ with_ <- function(set, reset = set, envir = parent.frame()) {

   set_call <- as.call(c(substitute(set), called_fmls))

-  fun <- eval(substitute(function(args) {
-    old <- set_call
-    on.exit(reset(old))
+  fun <- eval(bquote(function(args) {
+    old <- .(set_call)
+    on.exit(.(reset)(old))
     force(code)
   }, list(set_call = set_call,
           reset = if (missing(reset)) substitute(set) else substitute(reset))))
```

I always explicitly pass a list of names I want to substitute using the `env=` argument.  `bquote(where=)` is the equivalent for `bquote()`.  I think it is both safer and easier to see the intent.

However it is more essential for `substitute()` than `bquote()`, as you are already limiting the substitution to only what is in `.()` expressions.

I guess the safest method of all is to use `bquote()` _with_ `where=`

```r
  # memoised_function(...)
  init_call_args <- setNames(f_formal_name_list, f_formal_names)

  memoised_function <- f

  memo_f <- eval(bquote(function(...) {
    hash <- digest(.(list_call))

    if (cache$has_key(hash)) {
      res <- cache$get(hash)
    } else {
      res <- withVisible(.(init_call))
      cache$set(hash, res)
    }

    if (res$visible) {
      res$value
    } else {
      invisible(res$value)
    }
  },
  list(list_call = as.call(c(list(as.name("list")), f_formal_name_list)),
       init_call = as.call(c(as.name("memoised_function"), init_call_args))))
```

But in the end it is really just personal preference.  After going through this I think I will modify withr to use `bquote()` just because it is slightly more explicit and safe.


"Validate" (PEP 0257 style for new code) and raises->raise


put the ) on the next line to be consistent with new style


1 space after periods


put ] on next line


didn't see this but incorporated and updated these changes


no, they are all individual bits
<code>
#define PAGE_NOACCESS          0x01
#define PAGE_READONLY          0x02
#define PAGE_READWRITE         0x04
#define PAGE_WRITECOPY         0x08
#define PAGE_EXECUTE           0x10
#define PAGE_EXECUTE_READ      0x20
#define PAGE_EXECUTE_READWRITE 0x40
#define PAGE_EXECUTE_WRITECOPY 0x80
...
</code>


I don't get why you implement two different solutions (strip the leading \; add a leading .)


I am still updating

Mr Perez
On Sep 18, 2015 7:44 AM, "Rodny" <notifications@github.com> wrote:

> @carolstars1 <https://github.com/carolstars1> missing "to" in this
> sentence. Students will learn how "to" use control flow statements.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/carolstars1/nsbe-site/commit/be521f2da2ebd4035d52fec332bf992080533e29#commitcomment-13308740>
> .
>


Add docs for the new validator in `docs/ref/validators.txt`?


It would be nice to see a peek of your mysterious .com concept. It's been years in the making, no? ;)

Seriously, though, I kind of like the single column for docs, and just position figures, when needed, right or left. I think when you increase the font size, which is needed, and a few images are added, it will look really good.

The thing I'm really starting to dislike about two-column layouts on "desktop" views anymore is the long wasted space under the sidebar when the main content is much longer. And in this site, that's always going to be the case. I'm not suggesting change your grid for all the Txp platforms, but it's warranted to consider form against content on a platform by platform basis. Otherwise it's the same ol' problem of shoehorning content into a specified box size. That's backwards.

But, enjoy your vacation and think about it.


// the item causes the compiler make unneeded allocations.  Also, since
-->
// the item causes the compiler **to** make unneeded allocations.  Also, since


model field check


@kscherling This still needs documentation; it renders on the index for now. Can take a look at this when you get a chance to make sure everything looks good? I'll get documentation sorted in the meantime.


This commit is being reviewed as a part of review issue #65.


Agreed.


Right, then I'll push a fix later today or you can do a pull request (you
can edit directly in github I believe).

On Fri, 18 Sep 2015 14:05 mrgreywater <notifications@github.com> wrote:

> no, they are all individual bits
>
> #define PAGE_NOACCESS 0x01
>
> #define PAGE_READONLY 0x02
>
> #define PAGE_READWRITE 0x04
>
> #define PAGE_WRITECOPY 0x08
>
> #define PAGE_EXECUTE 0x10
>
> #define PAGE_EXECUTE_READ 0x20
>
> #define PAGE_EXECUTE_READWRITE 0x40
>
> #define PAGE_EXECUTE_WRITECOPY 0x80
> ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/x64dbg/x64dbg/commit/eac21d6a3b142b1916ff62e26c1d5c54e8e14ccb#commitcomment-13309092>
> .
>


In case the story is not found, we print a warning.


`toCommonStories` could not handle `nil` in the story list.


css is not processed because this is purely a render and **only** the content is sent back.  If you want to preview as would look on your site, you would need to load it via the frontend. Header variables should be processed though (like markdown extra).


 +// fromHex converts the passed hex string into a byte slice and will panic is
--->
 +// fromHex converts the passed hex string into a byte slice and will panic ~~is~~ **if**


We tried the directory and it won't work because all links, assets would be
broken. I will amend the prefix and down case filenames when I get home.

--

*José Valimwww.plataformatec.com.br
<http://www.plataformatec.com.br/>Founder and Director of R&D*


I think at the very least ``_search`` requests should have their body sorted, and perhaps an optimization can be made that sorts only if we're actually making a cacheable search.


that's it? adding "translate" to the class? *grmbl if I knew..* :+1:


**semi**: Missing semicolon.


Darn, I must have already had that artifact built when I tested my changes to the redhat branch.  I'll go fix it.


 // errors in the source code can bet detected. It will only (and must only) be
--->
 // errors in the source code can ~~bet~~**be** detected. It will only (and must only) be


Why don't you put this feature in utility::TmpFile so as to avoid deriving it here ?


I firstly tried but it didn't work.


This is good @carolstars1 but you might want to simplify the code by using a MySQL database. You should create a database called "nsbe-site" with a table called "events". This table should have the following fields:

- **id**. The primary key of the event. *Int*, *AUTO_INCREMENT*.
- **Name**. The name of the event. *Varchar*.
- **Start Date**. The date the event starts. *Date*.
- **End Date**. The date the event ends. *Date*.
- **Start Time**. The time the event starts. *Time*.
- **End Time**. The time the event ends. *Time*.
- **Location**. The location of the event. *Varchar*
- **Description**. The description of the event. *Text*.
- **Max amount of participants**. The maximum amount of people that can sign in. *Int*.
- **Current amount of participants**. The amount of people that have signed in for the event. *Int*.
- **Active**. A boolean that denotes if the event is active. This allows the event to be displayed or hidden if it is not active. *Int*.
- **Date Created**. The date and time the event was added to the database. *Datetime*.
- **Date updated**. The date and time the event was updated. Meaning, when any changes was made to the event such as: Description changed, date end date changed, etc... *Datetime*.

By Using a database you can take advantage of PHP and use a loop instead. This allows you to remove repetitive code. In addition, it also allows you to easily make any changes to an event that will be reflected easily without the need of changing any code.

Still you will need a table to store the information of the users as they sign up. How would you implement that? also, how would you know who is signed up for which event? Some homework. 😉


I felt obliged to extend from `Mage_Core_Model_Abstract` as I am accessing it through `Mage::getModel()` which is documented to return that type.

Going forward, alerts are likely to be the things that we store in a table so this could become more useful in the future.


`no idea how to test this ._.`
try it with Applied Energistics, its kind of prone to create strange behaviour on malicious storage implementations


I no longer have access to the email address referenced in the file, but I agree to the relicensing.


Thanks for clarifying. I did not look into the implementation of `bquote` before.

I think another feature of `bquote` is that there is an error if the contents of `.()` cannot be evaluated in the `where` environment. So to me it looks safer indeed.


This should probably be in a separate commit.


@Quetzacoalt91 this line does not translate. For the other 2 files (ES, DE), we don't have translation yet and they show English text only. But the French does not translate with this format. Could it be bug in this Prestashop dev functionality? Thanks.


First question we should ask is: who does what? I see the failsafe handler as the top level handler in case of a failsafe event. The auto-landing procedure is simple and integrated in the failsafe handler itself, while RTH is a more complex and independent procedure.

When RTH handler gets the command to activate, and at some point it is unable to proceed, it can go to a specific state like `RTH_OFFLINE`,  to reflect that. This is different from a check via `canActivateForcedRTH()`, because it also covers failure *after* a command has been given. The reason why i implemented the switch in line 256 is to cover this growing number of states, as we become aware of them.

It is always the exceptions that make it complicated. Like: what to do if RTH is already in progress (via aux switch) when a failsafe event occurs and selected procedure is 1) RTH or 2) auto-landing? This one is not hard to handle but it still must be implemented.

The RTH handler must be aware if it was triggered via aux switch (user request) or by failsafe handler (system request), so that it may go to different states. For instance `RTH_OFFLINE` state may only be used when triggered by system request. RTH handler must be completely self supporting when triggered by user request, which is the reason why the failsafe handler should only trigger and observe RTH progress. Only when RTH handler indicates that it cannot progress should the failsafe handler force an auto-landing.

As a first step i think we should define more states for the RTH handler, and describe what they mean, so that the failsafe handler knows what he is looking at. I think that a specific state like `RTH_OFFLINE` is enough for the failsafe handler if we give it the meaning: "RTH cannot proceed, please take over control". This is of course apart from making the RTH handler self supporting, which should be done first.


Missing period at the end.


Good point!


Modificación de ejemplo para conectar a MySql.


je l'utilise dans patanet : https://github.com/patacrep/patanet/commit/ca96b5008a56917fb2cdd98621dd15e46f686b08#diff-e0c9a856e5a7323a457f70d236527bbdR8


"Можно не указывать". Я не указываю, т.к. не вижу смысла плодить лишние символы/код/аннотации.


We will need a test checking this new functionality.


Any tip how I can easily test this?


Ок. Теперь ты и потренировался и узнал про стандартные валидаторы (полный список есть в документации к hibernate-validator, советую ознакомиться). Теперь можно заменить самописные валидаторы на стандартные.


Is this to avoid taking a backup every time? Then can you rename it to something such as: `done_backup` (in this way it is more obvious the meaning).


You might be using version 1.4.0, which had some issues in the configuration files that were uploaded to GitHub.

Please make sure that you use version 1.4.2, available on our website:
http://www.bq.com/gb/support/prusa

If you are building your own version, be sure that you are using the latest sources and that your configuration file (available in config/hephestos) does not contain any changes that might cause this issue.


I got node/io running as a shared_library on non-rooted android, baked into an repl app. I'm working towards a v4.0.0.0-rc merge.

I aim to release with:
1. unix domain sockets, fs-based or abstract (done... with issues);
2. sensors streaming through the aforementioned sockets (done... with issues)
3. logcat (done);
4. remote repl over http etc. (done)
5. in-app repl (WiP)

[Stay tuned.](https://github.com/Buggaboo/io.js/tree/v4.0.0-rc-android-shared-library-support)


Hi, I was wondering why objects only get frozen when in development mode. That is how I found this commit and now I am wondering, if the code works as intended. Since the commit message "Only freeze and ban properties if in *prod mode*." does not fit the actually change of banning properties and freeze objects in *dev mode*?


As we discussed, next should receive `err` object as first parameter.


Аннотация называется, `@ComponentScan`, насколько помню.

>Я же обозначил HomoDao как @Repository. Спринг по идее должен сообразить и создать синглтон бина. М?

Когда сканирование включишь для пакета(ов) в котором у тебя эти классы лежат, тогда да, так и сделает.


Sync


I think `Returns all the public games.` is a better description.


As we were musing IRL, it would be cool to log a warning when rec is actually None. I guess this was what you stashed before :smile:


Here's the correction, Philip. It's got a different GitHub icon next to it on the "commits" page (https://github.com/phutchins/chef-sar/pull/3/commits) -- do you know why that is?


Done. https://github.com/x64dbg/x64dbg/pull/392
The online editor added a newline at the end of the file sadly


Stop being a troll
On Sep 18, 2015 8:11 AM, "Rodny" <notifications@github.com> wrote:

> Missing period at the end.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/carolstars1/nsbe-site/commit/be521f2da2ebd4035d52fec332bf992080533e29#commitcomment-13309247>
> .
>


+// complex operations to ~~to~~ maintain balance.  Search, insert, and delete


Thanks :)
I forgot about it :)


Or should the docs be changed instead?


Хороший вопрос :) По идее это подсказка, что в рамках твоей транзакции будет только считывание инфы и БД ты править не будешь. Не знаю насколько Spring это использует и не зависит ли это также от БД с которой работаешь. Но я добавляю, в т.ч. и для документирования/отображения своих намерений.


It's so inefficient that we first default initialize (in arrayLiteralTX) and then assign the values again. I added an uninitialized allocation function to druntime for the dup implementation.


Thanks, merged it!

On Fri, 18 Sep 2015 14:18 mrgreywater <notifications@github.com> wrote:

> Done. #392 <https://github.com/x64dbg/x64dbg/pull/392>
> The online editor added a newline at the end of the file sadly
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/x64dbg/x64dbg/commit/eac21d6a3b142b1916ff62e26c1d5c54e8e14ccb#commitcomment-13309381>
> .
>


Coś takiego:

http://blog.testuj.pl/2015/08/25/zaproszenie-na-darmowe-webinarium-w-tematyce-automatyzacji-testowania-oprogramowania/


I will look into this.

Currently using google forms to get info from the sign ups and give the
list to professor at lehman.
On Sep 18, 2015 8:09 AM, "Rodny" <notifications@github.com> wrote:

> This is good @carolstars1 <https://github.com/carolstars1> but you might
> want to simplify the code by using a MySQL database. You should create a
> database called "nsbe-site" with a table called "events". This table should
> have the following fields:
>
>    - *id*. The primary key of the event. *Int*, *AUTO_INCREMENT*.
>    - *Name*. The name of the event. *Varchar*.
>    - *Start Date*. The date the event starts. *Date*.
>    - *End Date*. The date the event ends. *Date*.
>    - *Start Time*. The time the event starts. *Time*.
>    - *End Time*. The time the event ends. *Time*.
>    - *Location*. The location of the event. *Varchar*
>    - *Description*. The description of the event. *Text*.
>    - *Max amount of participants*. The maximum amount of people that can
>    sign in. *Int*.
>    - *Current amount of participants*. The amount of people that have
>    signed in for the event. *Int*.
>    - *Active*. A boolean that denotes if the event is active. This allows
>    the event to be displayed or hidden if it is not active. *Int*.
>    - *Date Created*. The date and time the event was added to the
>    database. *Datetime*.
>    - *Date updated*. The date and time the event was updated. Meaning,
>    when any changes was made to the event such as: Description changed, date
>    end date changed, etc... *Datetime*.
>
> By Using a database you can take advantage of PHP and use a loop instead.
> This allows you to remove repetitive code. In addition, it also allows you
> to easily make any changes to an event that will be reflected easily
> without the need of changing any code.
>
> Still you will need a table to store the information of the users as they
> sign up. How would you implement that? also, how would you know who is
> signed up for which event? Some homework. 😉
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/carolstars1/nsbe-site/commit/be521f2da2ebd4035d52fec332bf992080533e29#commitcomment-13309200>
> .
>


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for _onError


**no-unused-vars**: changeInfos is defined but never used


Why is all that code commented out? I think we just need a better API.


@vilchik-elena LGTM


Refs https://github.com/getgrav/grav-plugin-admin/issues/187


In overlay/frameworks/base/core/res/res/values/config.xml lines 51, 224 and 225 make build error! Why you make merge before check what that do??!!


I would use an ``elif`` here.


Thanks to #189 it was needed to do this through a Python script.
This was not the alternative I was hoping for but at least I did not yet have to re-compile MyData, which was not a good idea right now. With this I can close #188, as the function is right now not needed. Perhaps in upcoming projects things can be different on this department, but that remains to be seen. Before I close #188 I first want to see if things still work the way they should (and see if I did win some speed in the process too).


Capital B?

You can also add yourself to the NEWS files as contributing to the release.


This commit and the one before it are just to put the current state of new-integration on the integration branch through a merge and a reset.  We cannot force push the new integration branch onto integration without breaking mirroring.  The actual changes in these commits are to change new integration to the contents of integration, by a merge, and then change it back.  We are really only interested in the new-integration branch.  We probably could have done this better, with a single merge commit that ignored its left parent.


But I have to let the user edit the cars of a person, add/update/remove cars from person.


Problem ?
AbstractEList<EObject> list ??


Why introduce the word matrix here when this is *not* a matrix in either the mathematical or R sense of the term?


What is with the include path? I was trying to compile it with FreeBSD-10.2-RELEASE and it fails because the header file for libevent isn't found.


Yes, it looks like this could have been one of the issues. :+1:


Yep, it's exactly that. I will rename it


java.lang.NullPointerException
	at org.bimserver.emf.SharedJsonDeserializer.processRef(SharedJsonDeserializer.java:333)
	at org.bimserver.emf.SharedJsonDeserializer.processObject(SharedJsonDeserializer.java:241)
	at org.bimserver.emf.SharedJsonDeserializer.read(SharedJsonDeserializer.java:82)
	at org.bimserver.client.ClientIfcModel.processDownload(ClientIfcModel.java:298)


By the way, 'Student' shouldn't be allowed to see all the games.


I'm stuck to the version on Github, because my board was shipped with a faulty ATmega. The step signal for the extruder driver is floating and therefore the extruder doesn't work. Now I use the E1 port instead E0, to operate the extruder motor and for this I have to change six lines in the source code and can't use the official firmware.
Is the source code for 1.4.2 released yet?


Same 8 lines of code exists in the put as in the get function. Smells like a refactor is in order.

+		// Traverse left or right depending on the result of the
+		// comparison.
+		compareResult := bytes.Compare(key, node.key)
+		if compareResult < 0 {
+			node = node.left
+			continue
+		}
+		if compareResult > 0 {
+			node = node.right
+			continue
+		}


write a Type=forking and RemainAfterExit=yes unit, that invokes a bash script that does three times "sleep 9999 & disown" and then exits.

That way you get a forked off process in that cgroup that is neither control nor main process. as long as it is around "systemctl kill --fail" should succeed on it, but as soon as the three processes are gone it should fail.


[string]$mac = '00:00:00:00:00:00' #address of the network card (MAC address)

$string=@($mac.split(":""-") | foreach {$_.insert(0,"0x")})
$target = [byte[]]($string[0], $string[1], $string[2], $string[3], $string[4], $string[5])
$packet = [byte[]](,0xFF * 102)
6..101 |% { $packet[$_] = $target[($_%6)]}

$UDPclient = new-Object System.Net.Sockets.UdpClient
$UDPclient.Connect(([System.Net.IPAddress]::Broadcast),4000)
$UDPclient.Send($packet, $packet.Length) | out-null


miau


This field is quite strange. What about inlining it in the different db-specific methods, even if they're similar ? In this case the field would be ```tableName```. SQL code in various methods would be more readable.


Should the `$res = sendgrid->send($email);` calls on lines 264, 274 and 283 have a **$** in front of sendgrid, like `$res = $sendgrid->send($email);`


use `bargraph()` here to avoid unnecessary `tally()`


Warum hast du die Prüfung nach Module, Module + Controller rausgenommen?


On Thursday, 17. September 2015 19:21:49 Michael M Slusarz wrote:
> Would rather see optional parameters be added to an array, rather than as
> a separate parameter, to allow for further extensibility.

I'll look into that. I first need to fix some other Kolab stuff
and will then return to this topic.

A new function getParam() like in Base.php also makes sense.
We don't want PHP warnings on undefined array indexes.

Thomas


"they" refers to "names" but isn't to clear. Suggest to change:

    and what menu each name represents.


que haces con eso del dia?


@mikeNG  is vendor/oppo still required when building for bacon?


Actually do you even need to export the files? You could also directly read the tarballs which are part of the system description, when you don't extract them you don't even need a place where to write files.

The right place to implement it, would probably be the `ScopeFileAccess*` classes, because they are supposed to encapsulate the details of how the files are stored.


No need for `tally()` here and the output is better if you omit it.

Could also consider using `vcd::mosaic()`


Newline at end of file?


Minor feedback: inlining these constants sounds more readable IMO.


I like it even less with Find in capitals. Also, "find" the noun != "search" the noun.


I've fixed this in spiders by doing something like this for every influenced spider

```python
@classmethod
def from_crawler(cls, crawler, *args, **kwargs):
    spider = super(BaseSpider, cls).from_crawler(crawler, *args, **kwargs)
    crawler.signals.connect(spider.spider_opened, signals.spider_opened)
    crawler.signals.connect(spider.spider_closed, signals.spider_closed)
    return spider
```

WDYT, is it valid way or there should be a better way of doing this?


Use a wildcard on /test/dali-test-dispatch-* because it changes each time.


I completely agree that RTH handler must be self supporting and capable of handling all kinds of mishaps during RTH process (including being capable of autolanding in absence of any altitude sensors, using same approach as current failsafe - force angle mode and set throttle to failsafe_throttle). If RTH handler is self supportive and can deal with all cases on its own, I don't see a case when RTH_OFFLINE state might be triggered **in process** of RTH.

However the navigation system might be incapable of initiating an RTH if home position is not set or GPS fix is lost. In case of user-initiated RTH system simply does nothing and pilot remains in control. Failsafe is different - pilot is likely out of control and if the machine is incapable of returning it should be able to execute another variant of failsafe. Your suggestion - `RTH_OFFLINE` state - is a more generic approach. Failsafe system will attempt to activate RTH, but then it will receive `RTH_OFFLINE` state and initiate autolanding.

Nevertheless, first of all a normal RTH sequence must be debugged and proved working. I think at the moment this commit should be enough as we can improve things after getting them to work.


Exceptions should be used for system critical failures and not for errors. Maybe python and django missunderstood exceptions...
If we define the missing admin user as system critical, we should already throw an exception on system start. If we do not, it's not important enough for an exception.
We will discuss this face2face next week.


referring to columns by number is cryptic and error prone.  Use the variable name instead.


Same here. Node traversal direction is determined with the same 8 lines of code that is also repeated in the Get function. Smells like a refactor.


Use `head()` here?


Use named column rather than number.  (Or use `select()`)


the respective ==> their respective


`mutate()` here?


this is the group working repo for the IY group A.


You're right, it's hard to understand this field as it is.


have ==> open, display


You're right, I was trying something but it doesn't bring much value.


Probably safe to ignore /debian/*.debhelper and /debian/*.debhelper.log

In fact, *.log and *.trs is probably safe, and will make the list a lot shorter.


Hello,Thank you for your configuration , but I download and install the newest configuration,When I open the python file I can't complete the code , it warning that I never run the python process .I it a bug ?


import


This is fixed upstream in 9a2660f9395e9af253407226d6dcaf1c5a874dd7.


a command


android:text="哈哈哈哈"/>


android .util.log


//all the scripts are a model, so you can implement it as you want. Only tested scripts.


@vilchik-elena The 2 calls to EXPRESSION() after the AS token are probably too permissive: the current PHPGrammar uses FOREACH_VARIABLE.


We use tableFormatter liberally with lots of Elements.
Do we need to update all Element creation or just those in a tableFormatter?

Our calls are still
tableFormatter: function(arg) {
  var e = E('span')
...


Would it make more sense to put this with the `launch=` line higher up in this file?


Since you have a paragraph titled something that insinuates the difference between elements and nodes are described, I would move the last sentence of the node type paragraph to its own paragraph to define what elements are.


Hi,

I'm glad you like it. Where did you find the example Travis file? I'm
curious to know who is using Buildtime Trend. :)

Kind regards,

Dieter

2015-09-17 18:29 GMT+02:00 Igor Canadi <notifications@github.com>:

> Tnx for building buildtime Dieter! I found buildtime on an example travis
> file so decided to try it out. It gives us nice stats :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/facebook/rocksdb/commit/2b676d5bbefc974f747e2d7eb62b757a760fa535#commitcomment-13292309>
> .
>

--
Kind regards,

Dieter Adriaenssens


1: M111 unrecognized component name: docs


we must be able to look at the backtrace to see where the problem occurd? this seems like a hack


I am a nice comment


Good call! Moving...


Yes... simply put, @germonprez and I discussed the licensing and determined that both my interests, and his (i.e. the University's) would be better served with GPLv2 versus Apache 2.0. Specifically, we wanted to prevent sublicensing while still keeping the software free.

@germonprez, feel free to add anything.


Our plots look like they are the same. I would suggest adding a PNG of the plot into the folder if you could. I know the problem doesn't specifically ask for them, it just makes it easier for those reading through your code not to have to get the raw data. I like how in line 34 you named the different categories for the s_true variable. I personally did not know you could do that with Python.


Everything looks right, that is the same thing I did.


Addressed comments in commit https://github.com/bondar-pavel/infoblox-client/commit/f8887173d1670200a88c7891631f0adacd948af5


lepiej takie info trzymać w ENV Variables, w pliku application.yml, który jest w .gitignore :-)
Potem wyciągać jako ENV['zmienna']. Możesz do tego użyć gema figaro.


Shouldn't this be `solib`?


Are you sure about this? Here is the folder list from my device. There is no qcom,gpubw.39 folder:

```
root@piccolo:/ # ls /sys/class/devfreq/
1c00000.qcom,kgsl-3d0
qcom,cci.61
qcom,cpubw.62
qcom,gpubw.59
qcom,mincpubw.63
```


Files.readAllBytes(Path path) does this for you =).


it was really very hard to work with 3K+ lines file


Btw. strange folder names anyway. Where do they come from?


I'd rename file to path and create a Path if you decide to use Files.readAllBytes (see next comment)


Requires https://github.com/kevinweber/inline-comments/pull/3


Also with `=~` ?


Or EnderIO; if the Remote Awareness Upgrade and Remote Inventory Panel can see all of the contents of the silo you've done it right (for 'all of the contents' above one stack)


Commit is under my name, but we did this together with Kacper :)


FWIW, I'd leave it the way it is. That paragraph is just two sentences and the proposal would make an awkward two 1-sentence paragraphs. The entire section is just 3 paragraphs/4 sentences—there's not much to "scan".


Probably this property should be included in the error message actually. In this case it can be used as is, without [''].


@cdaversin That is to reproduce the test case in `Parallel Numerical Solution Of The Time Harmonic Maxwell Equations In Mixed Form`


The labels are all messed-up in the form - took me a long time to work out what was being seen...I suggest trying without the bootstrap formstyle (we're not using Bootstrap in this template & so don't have the requisite CSS to match that markup)


Hi,
addcslashes will be done in javascript.tpl.

regards
andré


Any way to check if the device lock is not held and throw an exception?


I'd once again rename file to path


Roadblock on the way to Herdla :angry:

>I thought dir, base and ext would always be pointers because util_alloc_file_components(...) will only change the content of that pointer?

The `util_alloc_file_components()` accepts a pointer to a pointer of characters, so when called as:

```C
// Initially path points to a random location in memory
char * path;

util_alloc_file_components( input_path , &path , NULL , NULL)
// Now the util_alloc_file_components() function has updated the value of the path - variable, i.e.
// it now points to a particular location in memory.
```
If the input path did not have a particular component (i.e. `path` or `extension`) the corresponding pointer will be set to NULL. Now I *thought* that `free( NULL )` would blow up hard - but that was wrong. `free( NULL )` is a perfectly legitimate no-op.

Merging!


@vincentchabannes I do not remember: have you said we have to use `_` or `-` for options ? I guess I did it wrong, can you confirm ?


I am a nice comment


The AddResourceLink isn't showing because you're not passing it into the formstyle.
The 'help' is the field.comment which is the 4th element in each row...but you are passing "" instead:
https://github.com/web2py/web2py/blob/master/gluon/sqlhtml.py#L815


Just a side note: this commit causes a bell / alarm on every space, backspace and Return for me.

I've been using zsh 8931e47 (tags/zsh-5.1.1~10), upgrading it fixed it.

I've not investigated - might just have been some regression/issue with Zsh, but maybe there's something that could be improved here.

It seems like just the following would trigger it:

    (( $+YANK_ACTIVE )) && () {
    }


Just create copy and put it into the db, that's how you can work with immutable entities :)


Should error be Error Deactivating Device?


:+1: (je peux garder le nom de la fonction, ou est-ce qu'il vaut mieux que je la nomme `iter_` ?)


This fails the build. That's because the build needs API level 22, not 23.


I was thinking about your suggestion – I chose “Helligkeit” as this is more day-to-day usage related. Whereas “Intensity” determines a stronger scientific background. Both expressions are linguistic correct and will be understood well in terms the related typical and it's desired functionality. In terms of word-length’s there is no big difference.

So I’d like to leave it to you, which one to choose finally. Both expressions will do fine.


Well I skipped the entire section looking for something elements-related, probably given that I do not know upfront the exact difference (and that elements are considered a small subset of nodes). For end users I think elements are the thing they care about the most.


Is only changes with new kernel (check email)

They come from kernel dts part.


Highly recommend you to read [AutoValue's README](https://github.com/google/auto/tree/master/value) and use it if possible!


Yes I have seen that, where do we have left build 22?


To debug the inline create I'd need to be running the code.
Use Firebug to see whether the JS has the correct option:
https://github.com/flavour/eden/blob/master/modules/s3/s3widgets.py#L6713
If it does then use Firebug to set a breakpoint in the code & step through.
If not then use Eclipse to set a breakpoint in the MultiSelectWidget


Thank's a lot Seh, inference works flawless now it seems, I am progressing fastly due to this now. :)


Build 22?


Yes, good catch, thanks! I've fixed them.


Did not rearrange photo templates. Actually rearranged photo routes


Just seen the mail, thanks for the info. Will test!


I meant API 22. We advanced dev on 23, so somewhere (in Gradle?) we still require 22?


I explained that on the other ticket. There is no reference to API level 23, except the project.properties (which are not used any more except for Eclipse).


This was not a typo. :-)
https://en.wikipedia.org/wiki/Memoization


As noted earlier, deciding node traversal direction in the Put, get, and Delete functions can be refactored out to a helper function. 8 lines of code gone. Readability improved.


This is IMHO less readable then the former code


Then how it requires 22 and not 21?


```
+	if _, err := devices.lookupDevice(hash); err != nil {
+		return fmt.Errorf("Error loading device metadata file %s:%v", hash, err)
 	}
```
Is this the correct error message?


Should "while L and M and the UUID pair of the owner" mean "while L and M are the UUID pair..." ?


Good point. Should we just call it a "data frame".


Style guide man


why the span not on one line?


Relates to WL-4052


It's defined by android:targetSdkVersion="22" in AndroidManifest.xml.


I've found the issue. Something about the way the Clear Colour button works is causing a crash, replicates for me every time. Can you see if it is crashing when you hover over the Clear Colour widget for you?


I think I made a mistake for fix another issue, now had been revert, sorry for that.


Add space between if and (


1. В окне "Настройки" теперь нет кнопок "Сохранить" и "Загрузить", которые сбивали всех с толку. Они вынесены в отдельный `$alert`, вызываемый по кнопке "Глобальные". В этом алерте я более подробно расписал принцип действия глобальных настроек, дабы ни у кого не возникало вопросов, зойчем они нужны.
2. В окне "Настройки" появляестя кнопка "Файл", которая вызывает `$alert` с сылкой на сгенерированный текстовый файл, содержащий информацию о настройках всех борд, включая глобальные. Также там есть поле для загруки ранее сгенерированного файла. После удачной загрузки конфигурационного файла он применяется, и происходит релоад страницы.


I suppose it looks sudden on GH but this was considered for a while. The short answer is that we certainly wanted to keep the software open source but also wanted to make a stronger claim to our work. DoSOCS is the first production-level piece of software that we've produced in the lab and the Apache license didn't serve our future focus in this regard. There is a longer answer in here.

Happy to hear your thoughts


Is it verified that errors (which can be ignored by force) like "this is used as devel package elsewhere" are still catched?


Thanks for the contribution! This block can just be:

```
dt = duparse(s)
if dt.time():
    return dt
```


+ add/code-challenge


Likewise, this block can be:

```
dt = datetime.strptime(s, f)
if dt.time():
    return dt
```


See c8b8c5181f9c5931bfa74e08b8ab1ffcd3143446. I just noticed in addition you also have overloaded a method in build.gradle.


inline if/else would be way too big (don't wanna break up the markup)


It still says falthandler though :stuck_out_tongue:


I would suggest this modification:
```
Elements are nodes of type C<tag>. Other possible node types are C<cdata>,
C<comment>, C<doctype>, C<pi>, C<raw>, C<root>, and C<text>.
```


Not on Debian Wheezy, which is what we're running at the moment.


Eerste probleem gevonden! De package java.time bestaat pas vanaf java 1.8, dus als travis deze op 1.7 runt gaat het sowieso fout.


TODO:
1. Потестить на всех браузерах (проверял работу только в Лисе)
2. Прибавлять имя домена к имени файла для браузеров без глобального хранилища.
3. Прибавлять дату к имени файла.
4. Запилить импорт/экспорт Избранного, Скрытого. Или даже *всего сразу* - генерировать файл Конфиг + Избранное + Скрытые треды + Whatever else


**no-unused-vars**: changeInfos is defined but never used


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for _onError


@retrospekt yo, you gotta make sure to indent after something like:

```
content: |
   lorem ipsum get sum
```

also any content with a `:` in it needs to be wrapped with single quotes

also, sorry. screw YAML


OH wow yes it actually assert in BeginTooltip->Begin within Render. Oops.


Argh. Thanks. :frowning:


I am a nice comment


Описание проблемы - https://github.com/ideals/Ideal-CMS/issues/403


J'ai tendance à utiliser `iter_` pour des itérateurs, mais je ne sais pas si c'est une convention personnelle ou si c'est répandu… Fais ce qui te plait le plus…


Ahhhhhh thank goodness for me, I was worried it was isolated to me. Sorry about that!


Merge


It is not a good idea to move specific stuff into a generic model. In that way the package model will become way too large because we could put almost everthing inside it.


@boite Should be `"%s@scanme.nmap.org"` I think. Fixed this and a bunch of others in r35253. (9840973)


Damned !
C'est pas du tout ça que je voulais :( Argh!!


Coursera


I was playing with this a little more and to be truly safe you _have_ to use an environment with `parent = emptyenv()` to `where=`.  The reason is the `where` argument is passed to `eval()`, but there is no way to set the `enclos=` argument to `eval()`.  The default value of `enclos=` for lists is `parent.frame()`, therefore if an object is not found in the list, it is looked up in the calling environment, which in this case is `bquote()`.

So you can get very funny results if the variable you are substituting is not found in the list.
```r
# objects defined in the global environment are used
rm(set)
fun <- function() bquote(.(set), list(set2 = 1))
fun()
set <- 'hi'
fun()

# `unquote` is defined in bquote()
bquote(.(unquote), where = list(set = 1))
# function (e)
# if (is.pairlist(e)) as.pairlist(lapply(e, unquote)) else if (length(e) <=
#     1L) e else if (e[[1L]] == as.name(".")) eval(e[[2L]], where) else as.call(lapply(e,
#     unquote))
```
Using a `new.env(parent = emptyenv())` fixes this issue, but is quite cumbersome to write :frowning:.
Defining a function like
```r
env <- function(...) {
  args <- list(...)
  stopifnot(!is.null(names(args)) && all(names(args) != ""))
  e <- new.env(parent = emptyenv())
  Map(assign, x = names(args), value = args, MoreArgs = list(envir = e))
  e
}
```
Allows you to write
```r
bquote(.(unquote), env(set=1))
# Error in eval(expr, envir, enclos) : object 'unquote' not found
```

I kind of feel the `bquote()` behavior is a bug, I may post to r-devel and see if I can get the implementation changed to `eval(e[[2]], where, NULL)`, as that is much safer


The assert you gave me was the wrong one, it is the assert in Begin() that was triggernig not the one in EndFrame(), hence my confusion.


Mind undoing this change?


It wont break anything, as you mentioned in README "npm install" command will install all the node modules.


We must be able to define separately the target and the compile version, they are two different things.

Gradle does not use ```project.properties``` or manifest versions.
So in current ```build.gradle``` target 22 (not compile) along with build tools 23.0.1.


Looking good!, starting to take shape....


This Py_DECREF gave an error ```Error in `python3': double free or corruption (!prev): 0x094a34f0``` on large (more than 5000 symbols) strings.


Yeah that's my fault, my apologies. The assert I sent you was just the one it printed out to the console as an error with. Woops!


Without this line most of the shortcuts are broken and you can't use a single key as shortcut.


Thank you!!


@iyzsong: Thanks!


It's going to live update from the stored events list, so from the perspective of the user it's dynamic content.


Fixed https://github.com/ocornut/imgui/commit/08bfe9bc7c5ff37047f2c4ffc74247b3963720ec


Could not find any in "sync" package. If there is one, I will be happy to use it as there are quite a few places where I want to make sure that a certain lock is held.


好任性，这么多commit


Can't you create a patchinfo model which is derived from package class and move the specific stuff there?


I'm not sure if what you want is supported by the Gradle Android plugin.


Yeah, I thought the same. :smile: I wonder how it looks, when a pull request is opened


and THEN if there's single quotes in the content itself, you have to differentiate them via doubling them i.e. `''` or just use the (I think technically more proper) curvy quote thing: `’`


Thanks!


Did you move @dervondenbergen?


also screw YAML


Could you add some comments on what these parameters and the following actually do?


Is this dead code? Can we just remove it?


@vincentchabannes @prudhomm @romainhild #560
the one that use `u.load(..., _type="hdf5")` will face a crash at this point.
It would be easier to return an error code, leaving the vector empty, to let the user know the `load` function wen wrong.
It would be nice to be allowed to use something like
```c++
if(!u.load(.., _type="hdf5"))
{
// Do whatever I need to recompute u
}
```
What do you think about it ?


return a pointer to the newly created obj


no, but realized only now, that my location was very random choosen in vienna, not the actual place


Most of the classes in core use org.slf4j.LoggerFactory. Do we now "officially" prefer log4j?


Typo! + pass single pointer


Hmm that would be inconvenient.. I'll check it and hope not having to revert dev totally on 22 just for Travis.


Still congratulations!


between create() and connect(): set user, pass, willingness and other parameters. Implement those functions. If the mqtt obj is already connected, these function will return an error


Could you please change the signature of the function to:

void Main::start(int /*tid*/)

That should remove the error as well.


recv what? :)


1: M111 unrecognized component name: docs


Its not incorrect as this happens during boot time and file will be loaded from disk and device will not be found in hash map. But I think I can change it to something like "Failed to lookup device %s".


y->row x->col so a bit confusing to use xcen,ycen names here


lol, thanks, altough i didn't move :D


have you tried to call the package `fiddle` or something else (than `main`)? theoretically it should compile without a `main()` function.


For this part I took the Javadoc almost verbatim from the official Android SDK Javadoc, I think we should not change this in order to avoid confusion. Specifically:

_This method is called when the BroadcastReceiver is receiving an Intent broadcast.._


Thoughts on just putting fuse into yokozuna.app.src?


Si c'est utilisé uniquement dans patanet, et qu'il existe un filtre `replace` (ce qui n'est pas le cas si je ne me plante pas), ça pourrait être bien de déplacer cette logique dans patanet : `chord.key|replace('&', '♭')|replace('#', '♯')` (je sais que la syntaxe est fausse). Sinon, ça n'est pas grave…


deactivation and removal are being used interchangeably in the code. As original error message is "error removing device", I retained it. I guess I can change it.


return a ptr to a new message, or null if error. This basic function should only set topic and mqtt_data for content. Other parameters of the msg will be deafult, use helper functions in between create and publish for other options (QoS, Retain,  ...)


Thanks for the report!  That's tracked as issue #200.


Should the same BUILD_REPOSITORY_PROVIDER check be implemented around line 50 for the Work Items?


I've one worry here, which is that `produce()` can still enqueue new messages while this loop flushes the queues, and those would then be dropped.


I tested the program using Valgrind:
```shell
valgrind --tool=memcheck --leak-check=full --show-leak-kinds=all python3 repeatings.py 100
```
and got the result:
```
==5630== LEAK SUMMARY:
==5630==    definitely lost: 0 bytes in 0 blocks
==5630==    indirectly lost: 0 bytes in 0 blocks
==5630==      possibly lost: 0 bytes in 0 blocks
==5630==    still reachable: 367,502 bytes in 2,540 blocks
==5630==         suppressed: 0 bytes in 0 blocks
```
From the [Stackoverflow.com](http://stackoverflow.com/questions/3840582/still-reachable-leak-detected-by-valgrind):
> In general, there is no need to worry about "still reachable" blocks. They don't pose the sort of problem that true memory leaks can cause. For instance, there is normally no potential for heap exhaustion from "still reachable" blocks. This is because these blocks are usually one-time allocations, references to which are kept throughout the duration of the process's lifetime. While you could go through and ensure that your program frees all allocated memory, there is usually no practical benefit from doing so since the operating system will reclaim all of the process's memory after the process terminates, anyway. Contrast this with true memory leaks which, if left unfixed, could cause a process to run out of memory if left running long enough, or will simply cause a process to consume far more memory than is necessary.

> Probably the only time it is useful to ensure that all allocations have matching "frees" is if your leak detection tools cannot tell which blocks are "still reachable" (but Valgrind can do this) or if your operating system doesn't reclaim all of a terminating process's memory (all platforms which Valgrind has been ported to do this).


OK it should be all set in the redhat branch now.  Sorry for the delay - I wanted to make sure there wasn't anything else problematic.


Show. Vários cenários de teste.


The [libstemmer_c.tgz](http://snowballstem.org/dist/libstemmer_c.tgz) and [libstemmer_java.tgz](http://snowballstem.org/dist/libstemmer_java.tgz) links currently point to 404 pages. The same for [download.php](http://snowballstem.org/download.php) page that is linked from snowballstem.org. Can you please fix that?


is changed to proxy in a later commit


ah I thought it was a class, perhaps would naming it "people_array_t" more clear


i will move this change to a new decorator inside summit module
regards


r+


@dtkaplan likes to use "data table", although that can be a little confusing because there are objects of class `"data.table"`.  Also, it can get confusing when summary tables are produced.

My preference had always been to simply call them data frames.  The tricky part now is that Hadley's tools produce things that are data frames "plus" and behave differently.  Calling them tbls and tbl_dfs aloud sounds dumb.

This has become an annoyingly awkward thing.


```
> bquote(.(unquote), as.environment(list(set=1)))
Error in eval(expr, envir, enclos) : object 'unquote' not found
```


i think we must decide if we prefer having the ability to use single keys as shortcuts or to always have focus on the chat. @Daenyth ?


The issue arises because we declare as compile version the target one in Gradle, I'll push a fix.


You are my hero. Thanks.


org.bflow.toolbox.hive.libs wurde nicht von mir zu den required bundles hinzugefügt, aber wenn ich es entferne werden in 3 Klassen Fehler angezeigt (OriginalColorSchema, BflowConfigurator und MessageProvider) Wobei diese sicherlich behebbar sind, weil das alles nach normalen Dateieinlese bzw. verabeitungoperationen aussieht. Die auch ganz normale Java-Klassen leisten können. Sollte ich das also auch versuchen zu ändern?

Bei den Attributes weiß ich jetzt gerade keien schöne Lösung. Sollte ich vielleicht versuchen mir  die Attribute selber aus der geöffneten EPK Datei zu parsen? Oder kennst du noch eine andere Methode die das leisten kann und die bereits existiert.


What the file?


@jgarboza813 This is one of the best solutions I've ever seen. :+1:


At this point, `produce()` will start enqueueing on the newly setup brokers, but it will still take us until after L187 to re-queue all the existing messages. That means we'd violate message ordering (the re-queueing here doesn't increase the `attempt` counters).


@jgarboza813 DWMR. Good work here.


Travis has nothing to do with this issue. If you'd remove API level 22 from your developer machine (or Jenkins) it would fail too.


não é preciso fazer isto, por padrão `int` é 0.


I'm guessing that it was because the feature didn't work on 'release' branch, but could be wrong.  Agree that the const fn's can be useful.


Looks good.


Gostei, ficou limpa esta solução


Ah, du coup `directories.insert(0, songdir)` ne fonctionne plus.
Je vois 3 possibilités:
* je garde l'implémentation actuelle
* j'appelle `list()` sur le générateur avant de le passer à `search_file`
* j'utilise `itertools.chain` dans `search_file`

Laquelle te semble la plus élégante ? (ou alors il existe encore d'autres possibilités ?)


I'm guessing that it was because the feature didn't work on 'release' branch, but could be wrong. Agree that the const fn's can be useful.


Good call! I had tried list2env(), but it still gets objects from `.GlobalEnv` by default, didn't think about using `as.environment()`.


r+


só cuida para manter a consistência, em alguns ifs vc utiliza `{}` outros não. Mesmo não precisando de `{}` para uma instrução, fica inconsistente e perigoso..


É que eu queria enfatizar bem :P kkkk


@jgarboza813 DWMR. Nice work here, too. Good. Press on!


Yes Travis just showed our issue.


Wow
I found N times kernel panic during boot.
Good job!


By the way, why are you trying to target such a high API level anyway? If I were you, I'd target API level 10 because we want to check if it still runs on Gingerbread.


também poderia ter feito `retorno *= -33;`


Does passport have a single `redirect` property in which they can be merged?


Please use pull requests (or, at a minimum, validated merge) when pushing to the `master` branch.


Not following these? What are we trying to do here, throttle a bit? You could use a Request, which is serial in sending since it waits for a response. But if you are testing performance of the encoder, you want it running as fast as it can.


th


Another classic:

```
> eval(bquote(.(setNames), as.environment(list())))
Error in eval(expr, envir, enclos) : object 'setNames' not found
> eval(bquote(.(setNames), list()))
function (object = nm, nm)
{
    names(object) <- nm
    object
}
```

I didn't know about `list2env`... Both call an internal or primitive at some point. My head is spinning...

Bottom line is perhaps: Use an environment for `bquote` :-)


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.57.52d4fa2b73fca196fda81cbefe3f5e3c041158d7](http://build.palaso.org/viewLog.html?buildId=63415&buildTypeId=bt2) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:50


Actually, this is removed entirely in e1e8349.


👌Cool, except extra `app/Root.jsx~` file


Actually, this is removed entirely in e1e8349. It's not necessary anymore with a treeview because plugins are never added before its proxy (due to the hierarchy).


oh ok ich hätte den Kommentar wohl vorher lesen sollen :D Also ist die Lösung einfach diese Kalsse in das attribute-plugin schieben?
Aber muss ich dann nicht wieder hier in dem Plugin etwas von hive.attributes importieren, weil die Policy in den entsprechenden Editparts (ColoredConnectionEditPart und ColoredNodeEditPart) registriert werden müssen.


it seems like changed sorting of imports in comparison what really changed in code.


Looks fine. I'm not sure that this is really necessary or correct to update the date (see http://stackoverflow.com/questions/2390230/do-copyright-dates-need-to-be-updated/2391555#2391555), but that's a different matter...


Why changing the name? Either we put "<country> - Accounting" or "<country> - Chart of Accounts" but we must use the same for everywhere. cf 4f09d136d08dddd924f2cac173cf12a114c58ccf


Hi, I am Anwar and I open your project in unity and make a build for iphone audio recorded and play .
But I import your package in my project then audio voice is missing .So please have any for that reply me.
Thanks.


add a publish_retry() as discussed


I think there is a little bug in this commit.

The fullscreen icon is only added, in case settings.show_map and album.show_map is active. (For album.show_map at least one picture with GPS coordinates is required)


Not clear what's the impact of this disable... also: why comment and not just delete line? please delete line and provide more info on this impact


It seems like the tag for this release is missing


огонь


Thank you! :)


This should be `Tenant email domain not updated`


@Dwar3xwar DWMR. Good progress here Eric. Let's make sure we talk about jobs and interviewing a bit next chat.


This should be `The tenant email domain could not be updated.`


This should be `Tenant host not updated.`


This should be `The tenant host could not be updated.`


This should be `Tenant name not updated.`


This should be `The tenant name could not be updated.`


other preconditioners options use  ```-```   and  ```.```
I would prefer to have an homogeneous style.


Is this TODO comment required?
The ewk_view_user_media_permission_callback_set() is called in InitUsermediaCallback() function already.


imagine: `@DefaultStringSet({"a", "b", "a", "c", "b"})`.
my result: `{"a", "b", "c"}`

so i prefilter the values to be contained in the set


@cehallen DWMR. Press on!


r+


@cehallen DWMR. All the comments are ideal. We can discuss the benifits and opinions of comment when we chat. Press on!


I agree that the `bquote` behavior for lists is somewhat undefined. I think your suggested implementation would solve the problem. Let's see if R-core agrees :-)

Should we perhaps also use `enclos = NULL` (for the substitute() approach), or an environment (for bquote()), in withr?


I am fine with your choices, it just felt a tad sudden on the receiving end.
My Python code is usually Apache-licensed or use some attribution-style license and this usually makes it easier to combine libraries together and is a common approach in the Python "ecosystem".  But your choice is your choice. Thanks for the clarification!


The configs max_size of 5242880 is in conflict with the default in the readme and the app file of 10MB (1024 * 1024 * 10)

The max on a default install is 5MB at the moment ie config takes priority over app


Done.


So what is up with this patch? Is it in mainline yet?

I would really like to see this fixed as this breaks ninja usage in Qt Creator pretty hard.


I just noticed that the macros directory has a `tests/metadata.js` file. Should this file be in `/tests` instead?


shoudn't these be `AtomicBoolean` fields?
there is no guarantee there can not be concurrent access to this class


While reviewing this commit, I had a hard time remembering that PluginDescriptor is just a sequence of PluginDefinition.

I'd call this PluginDefinitions or at least PluginsDescriptor, because it can define more than one plugin.


LGTM


Again this is not mentioned in HACKING (the next line remark)


s/implementors/implementers/


Anytime ;)


-@import "bourbon"
-
 /*==========  Desktop First Method  ==========*/

 /* Large Devices, Wide Screens */
 @media only screen and (max-width : 1200px)
 	/**/

 /* Medium Devices, Desktops */
 @media only screen and (max-width : 992px)
 	/**/

 /* Small Devices, Tablets */
 @media only screen and (max-width : 768px)

 	/*Disable Animation on Mobile Devices*/
 	.animated
 		/*CSS transitions*/
 		-o-transition-property: none !important
 		-moz-transition-property: none !important
 		-ms-transition-property: none !important
 		-webkit-transition-property: none !important
 		transition-property: none !important


Esta macro puede traer problemas según el uso que se le de.
Y definiría tres macros.
1 - una para el rango de tensión en mV (3300) LM35_ADC_RANGE
2 - otra para el número de cuentas (1024) LM35_ADC_COUNTS
3 - otra para convertir de ºC A mv (10) LM35_CELCIUS_TO_MILIVOLTS

Entonces en el código te quedaría:
tempLM35 = (readingLM35*LM35_ADC_RANGE/LM35_CELCIUS_TO_MILIVOLTS) / LM35_ADC_COUNTS;
Que termina siendo lo mismo que hiciste vos, pero cn mayor flexibilidad y dejando bajo el programador la responsabilidad de hacer las multimplicaciones y divisiones en el orden correcto.


I would just escape the inner backquotes. Not everyone has a posix shell. :-p


FWIW, (but I am not a lawyer... and this is not legal advice) the LGPL licenses and other limited copyleft licenses may have the same effect wrt. sub-licensing and allow for more combination possibilities with other libraries using attribution, copyleft or commercial licenses.


indeed


yeah. the check is a leftover of older code i had during testing


r+


vfvgzd


暂未通过SPOJ测试, 还没找到什么原因 :-(
原题链接：http://www.spoj.com/problems/CMEXPR/


Sorry, best regards.


Just updated withr to use `as.environment()` https://github.com/jimhester/withr/commit/3f32d5b3343c9b80491c40fe5fd02cc80ef89d4c, thanks for the reminder


r+ nothing I can really review here


dsad


Well it is a type. And I'd use the same convention for all types.
Besides that I don't like `the_under_score_naming_convention` as it is very length and looks ugly IMO. However I'd be ok with adding a convention for "shortcuts" to be suffixed by `_t` --> `PeopleArray_t` similar to the `uint32_t`.
An argument against is: It doesn't really matter what kind of type PeopleArray is. Only thing to know is, it is a type for an array of people(counts) (maybe `PeopleCtArray`would have been a better choice...) And actually the class containing this should not know, how to serialize this. All this Push/PopXXX should be Push(x) and Pop(x) or even more generic and the serializer checks the actual type on how to handle it and if it has an own (de)serialize function etc.


`from_crawler` is the standard way to do this, this method is supported by all components that load middlewares, extensions and spiders. Even core components like scrapy.core.scheduler.Scheduler use it.

In any case, the backward compatible import for pydispatch is a good idea


@EricWittmann awesome. Thanks man!


Too bad there is no documentation of the public methods of this class, that would demonstrate a clear understanding of behavior and provide a comprehensive definition for anyone (including the code reviewer and the future ourselves) of what is expected of this class. It would also drive the unit test writing.
Bonus, this documentation could be on an interface.


Fixed throughout. No changes past 500.


Si ya están todos los tests, quieren unir las clases del has_parameter al mismo archivo del módulo has_parameter.rb y tirar pr?


degisiklikler tamam


could use `Preconditions.checkState`


Project Red seems to have support for DSUs as well. I'll test this stuff later unless someone of the usual suspects here breaks it before I get to it.


Should have an exclusion for `org.sakaiproject.rsf` or RSF should have a different package name.


dto creation could be a method, this code is just noise from the submit method point of view


libsqlite3-0.dll is still not included in nightly builds by buildbot...
Would be great if issue #5011 could be fixed!


Please remove double negation, as there is no need to care about about type of `data`

Also there is a potential bug at the beginning of this function (https://github.com/jsdoc2md/ddata/blob/master/lib/ddata.js#L452): if `options.data` is undefined then following assignments of `data` properties will cause `TypeError`. Could you please fix this as well with appropriate comment.


`modules` as always defined, so you don't need for first check. Also please remove double negation.


There's no need to do casting to ServletContextHandler and access it via the sch.getObjectFactory()

This whole method could be simplified to ...

    DecoratedObjectFactory decObjFact = (DecoratedObjectFactory) context.getAttribute(DecoratedObjectFactory.ATTR);
    decObjFact.addDecorator(new WeldDecorator(context));

of course, you could check for null from the getAttribute() call, that would tell you that you are not running on Jetty 9.3+