ignoreされるファイルを列挙する用途なのにわざわざ、 `〜を含めない` と記述するのは、あまり意味が無いと思います。


Tránh dùng goto vì khó kiểm soát flow, code khó đọc


OK (though I disagree :) )

Related to my other question, can you give me some clue ?

> It would be great to document what values need to be changed depending on what
> you want to do (countThreads, selectThreads and websocketThreads) with your
> server. As of now, I don't know what I need to chage to scale my service up.


No I'm wrong sorry, I'll try to find what's wrong...


@ridiculousfish: I'm not sure I understand this - it affects "\cw" i.e. Ctrl+w bindings, not meta-backspace (and I can't get meta-backspace to do _anything_, neither in fish nor in bash).

\cw is also bound to backward-kill-word above, which matches the documentation, but then re-bound here.


msg -> message


dấu = lệch nhau


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20960/testReport/) for this commit**


thiếu dấu cách trước và sau &&


Public methods removed at minor release?
It would be nice to mark methods as deprecated before removing them.


sai indent


> könnte man vermutlich ganz gute Resultate erzielen. bendiness * speed

Also ich würde bendiness sowieso immer mit dem original 'weight' multiplizieren, und das original weight macht ja `time=distance/speed` d.h. man braucht eigentlich speed un distance nicht mehr nur noch luftliniendistanz

> Die hätte er bestimmt nicht alle erzeugt, wenn es pro Datei länger als eine Stunde dauern würde (was natürlich immer noch ziemlich lang ist).

Also wir reden hier wahrscheinlich über Sekunden :)
was aber fürs routing wenn man es im produktivsystem verwendet viel zu lang ist.

> Ich werde innerhalb der nächsten Tage mal https://github.com/adamfranco/curvature auf meinem
> PC zum Laufen bekommen. Um direkt sehen zu können wie lange die Ausführung dauert.

Da das python ist kann man das nicht gut mit der Laufzeit Java vergleichen...


return at new line


remove parentheses


I'll have a look.


Combined with supplying the authentication header in every single request, as described by @cnoon in #785.

```
private let authenticationHeaders = ["Authorization": "…<your authentication>…"]
…
let request = Alamofire.request(.POST, …<your URL>…,
            parameters: …<your JSON>… , encoding: .JSON, headers: authenticationHeaders)
```


Second Try :
I am wrong to say that it is plf2015 reform that I reintegrated in my file that made Travis to Crash ? I taught that @cbenz solved the issue ?


Ok, seems doable.


CONST 'reserve'


constants should be named with all caps and underscores separating words
`final int TRIGGER_LEVEL = 300;`


So [this comment](https://github.com/jbavari/cordova-plugin-video-editor/issues/24#issuecomment-141758600) fixes the build _locally_, and I've worked out how to get that added to the `AndroidManifest.xml` on PhoneGap Build too.

What I did, in `config.xml`:

1. To `<widget>` add the attribute: `xmlns:tools="http://schemas.android.com/tools"`

2. Within `<widget>` add:

```xml
<gap:config-file platform="android" parent="/manifest">
    <manifest xmlns:tools="http://schemas.android.com/tools" />
    <application tools:replace="android:icon" />
</gap:config-file>
```

They'll be merged into the manifest.

**However**, it still fails with the generic "Oh geez. Your build failed. Sorry, but a problem occurred on the build server" message.


Looking at Notify, it seems that we extract the data there, so we don't need to extract it here...all we need to do here is send the 'message'


Стараюсь переучиться... :)
У меня во всех программах куча закомментированного кода, для варианта мало-ли что....


why is nextPageLink() extracted into a method, but this is formatted inline? Seems inconsistent.


use spaces between operators

`Motor mot1 = new Motor(MotorPort.A);`


If you assign `@mailbox`, you don't need `mailbox` anymore.


it would be nice also to be able to write something like this:

````java
    public MyApp(Injector injector) {
        webServer = new WebServer()
                .withCountThreads(2)
                .withSelectThreads(1)
                .withWemSocketThreads(8)
                .configure(routes -> addRoutes(routes, injector));
    }
````

but `start` is inside the `new WebServer()`


IsFalse


IsTrue


missing space after `while`


No need to export.


One more general question about this - and apologies if this is not relevant - this code is new to me:

So the general approach here is to start the new process, close all handles on fork, work around stdout/stderr on windows by piping them separately to disk and pick them up on exit.

All we really want to do is to make sure port 9000 is closed for the child process. Right?

Could we instead just fork the process - like we did previously - before websockets, and then close port 9000 as the new process starts up? Not sure exactly how to implement this, but imagine a pretty crude approach where you just passed a flag to the calling process to tell it to close the port?

A slightly different approach I guess - not sure which one is better as I am not too familiar with the shotgun desktop IPC paradigms. But maybe it's good to cleanly close *all* descriptors on handover anyways? To avoid leakage over time. Just wanted to throw it out there :)


Сейчас не вспомню.
Сейчас всё 1.8


remove extra lines


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20961/testReport/) for this commit**


Как ты писал - "интернеты".....


Если поменять адрес в настройках, то перестанут работать виджеты. Логичнее, если адрес будет настраиваться на клиенте. Кроме того, для работы клиента нужно возвращать конфигурацию шлюза, а наш API этого не делает. Мобильные приложения nooLite (единственные существующие сейчас клиентские приложения для шлюза) все равно не смогут работать с нашим API.

Поэтому предлагаю не писат ьв системе лишний код и не заморачиваться с настройками адреса.


what is `aux`? use more verbose variable names


Of course that's probably all nonsense as the responses to those messages are actually fired at the GUI... Wasn't thinking that through.

So, maybe just a simple `ENV` var which it's up to the user to specify will have to do.


statements inside case should be idented


Do we know that SevenZipHelper is thrad-safe?


missing spaces
`if (aux < triggerLevel && aux > 0)`


provide documentation about what these functions do. Also name them better than `far` and `near`


A short one-line description of what it does is better than referring to 5th assignment


extra line is not required


The `assertEquals` is not execute in the JUnit main thread, if wel let it failed this will not stop the test cases. (just failed transparently)
So to move the clientRawDataChannel, I should also move the local variable `decryptionFailure` as an attribute.
I don't know if this is better.


use curly braces for if-else even if the blocks are only one line


are these constants? If yes, make them `static final int`


Nice to Know my report have been fixed :+1:


here still a problem is


we really need a formatter, so we will be able to use the eclipse format on save option :)


update


the indentation in this file seems to be wrong


use spaces between operators `int tmp = 0`
use more verbose variable names. What is `tmp`?


Yes makes sense. Will require a new PR though..


what does this variable name mean?


Парсить команды с учетом регистра некорректно, т.к. в URL может прийти корректная команда в другом регистре и клиент будет ожидать от сервера корректный ответ, а сервер не сможет распарсить команду.

Парсить команды без учета регистра тоже некорректно, т.к. на стороне сервера варианты в разных регистрах - это разные значения enum-а.

Нужно либо определить корректные правила передачи строковых команд, либо выпилить этот функционал вообще. Когда я говорил, что он не нужен, но, если он останется, нужно будет тратить время на его поддержку, как раз имел в виду подобную ситуацию. Поэтому предлагаю удалить.


prefix logging statement with ringpop


I see, you're totally right. That wouldn't work. However, do we need to make this check in every test case? What is it that we want to ensure with this assertion with regard to the overall intention of the test case? Would the test case be less effective if would simply omit this check?


ohh.. it is unused.. my bad. i will update and ask you again.

Sent from my android phone!
On 21 Sep 2015 10:46, "Philip Potter" <notifications@github.com> wrote:

> why is nextPageLink() extracted into a method, but this is formatted
> inline? Seems inconsistent.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openregister/presentation/commit/639ec0a7f4b970cc6059ead7ba7b15906fe2d6f2#commitcomment-13337868>
> .
>


Yes.

Imagine this :

Bob is running a James server for him and Alice. He knows Alice loves kitten pictures. Far too much. He decides to fix her a 5 Go quota.

About Bob : his use of e-mail is compulsary, if he can'tread its e-mail, he start being nervous, and his skin turn red in matters of second.

Now, time is passing. Bob start falling in love with Alice. He want to please her. He buy some more storage, or kill grand ma (who also used the server) so that he can extend Alice storage quota.

Now, imagine this :
 - He choosed inmemory quota backend as he don't want to deploy a memory hungry, one node unsafe cassandra on his server.
 - He does not have a that eavy load so recalculating quota should be Ok.

If this object is immutable :
 - He has to reboot the server to change Alice Quota. But remember : phobia !!!

If  using the current implementation :
 - He modify config file for effect to take effect after reboot
 - He uses CLI for direct effect.
( See JAMES-511 )

I am deeply convinced maximum value for quota should be mutable.


I couldn't agree more :-)


This is a hotpath (during membership fluctuation). And I'd prefer if underscore not found its way in them. Can you benchmark this vs. a for-loop just to see how much we're losing.


Железо тут ни при чем. Естественно, при изменении API адаптера нужно будет обновить HTTP API. Вопрос был: каким образом будет происходить гарантированное обновление HTTP API при изменении API адаптера?


prefix with ringpop. I know it's annoying. But we don't have subloggers and Ringpop (in all/most cases) is using the application logger.


A ok variable name... Get it.


Indeed. I see now I was too naive in assuming that publishing and consuming should also be part of the benchmark.


legit


Нужно поменять тип переменной brightness с *int?* на *int*.


1) You misspelled it as well
2) Don't be a fucking grammarnazi on my commits.


I left a few nitpicky type comments. We're nearing the end here!

On Mon, Sep 21, 2015 at 3:01 AM, benfleis <notifications@github.com> wrote:

> lots of cleanups from @jwolski
>
> use/fix the proper store
> improve tests via mocks
> update membership.checksum.update event
> bug fixen
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/uber/ringpop-node/commit/3f2a3c93dd857a7f9efb42cdd92972a2a37c7007
>


I would like to be sure that Encryption/Decryption was correct, but maybe this is not really needed as the handshake challenge was successfully done. Do you prefer I remove this checks in the 3 tests ?


No it won't.

You can query again the QUotaManager and get an up to date quota.


> because _execute_source() assumes it's running one line of code

Oh, interesting, may be worth a follow-up bug if we can make that better.


GaugeVec ist 'ne Liste von Gauges, aber unterschieden durch ein Label. Ich habe also identische gauges, die die gleiche Metrik exportieren, aber einmal annotiert mit "configname=localhost", einmal configname=uni etc.
Das benutzt man dann quasi wie 'ne Map `mygauge["localhost"].Set(foo)` und kann im Code dann beliebig viele davon definieren. in dem Moment, wo ich ein noch unbekanntes label reinwerfe, wird direkt eine entsprechende Gauge erzeugt. So kann man die gleichen Metriken sehr einfach für verschiedene Szenarien monitoren.
Ebenfalls 'n Anwendungsfall ist sowas wie `http_requests` und dann als Unterscheidungslabel den Returncode nehmen.
Nach dem Scrapen kann man die einzelnen Gauges/Counter/whatever im Vektor, wenn man will, dann auch wieder aufsummieren.


I applied your patch for the CMakeLists.txt and renamed the contrib/backport/boost-1.58 folder to boost-1.56. Please have a look into the build log.

https://bpaste.net/show/4c212ba72d04


tests are failing due to unrelated reason, there is a ticket for that: https://wikia-inc.atlassian.net/browse/PLATFORM-1495


Thank you, works great now.


Type, will fix this before submission.


closes #407


Yeah, except chat from 0.12 won't because the packets are dropped due to
BufferUnderflow. 0.12 gets chat fine though.

On Monday, September 21, 2015, RandomAltThingy <notifications@github.com>
wrote:

> Does chat work then now?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RedstoneLamp/RedstoneLamp/commit/2def8e121f2c287cd343ba7ba0a3f724193dac96#commitcomment-13345487>
> .
>

--


The url to use for anaconda docs is https://rhinstaller.github.io/anaconda/boot-options.html


I'm actually much more concerned about prepare(). Nearly all valid()'s start with something that reject "wrong type" very early. But some of the prepare()'s are **very** poorly written, if we talk performance.


Prometheus tackert bei Histogrammen automatisch einen "größer als upperBound"-Bin hintendran, in dem alles landet, was zu groß für die definierten Bins ist, ergo ist das unproblematisch. (und man hat bei []float{ binsize } zwei bins)


I think the gem summary needs to be "It's Showtime, mothafucka."


I think the first arguments of these two `strtok_r` calls need to be swapped (first `s`, then `NULL`).


Ah I just realized, you were the one who chose the term "Render". It works out rather nicely now, although you may want to rename "renderscripts" into "videoscripts" or "videorenderscripts".


very good point, das wäre sehr zu begrüßen, den Code hier schöner zu machen, ich muss da nochmal ran


I think we should follow the fold_*/noop_fold_* pattern for idents, it seems reasonable that someone might want to change the context as well as the name itself.


@zazaian That's an illegal name in Ruby, Mike.


- I can confirm, `Save as` displays GeoPackage as output format here. It probably depends on the GDAL/OGR version QGIS links against (I'm on Ubuntu 14.04, GDAL/OGR v1.11.2).
- And it works as well ;), I can see all but geomcollections geometry types icons.


das mit den Ints hatte bei mir auch nach mehreren versuchen nicht funktioniert, vermutlich hab ich elegant den korrekten Weg, es zu machen, umschifft....


Ferking ferking ferk.


TeamCity pull requests :: netty [Build 236](https://garage.netty.io/teamcity/viewLog.html?buildId=1537&buildTypeId=pulls_netty&guest=1) is now running


How about just and ASCII image of Martin Landau doing jazz hands?


will haben :D
evtl. brauch ich da 'n pointer, das hatte ich glopsch noch nicht versucht


Could you move this into a separate commit?


hm, auch 'ne Idee, muss ich mal ausprobieren.


This should probably be `char *s`, because the string potentially gets modified.


yup, das ist noch auf der Roadmap. die `//fmt...` sind quasi als Lesezeichen noch drin


Add a trailing slash here (I know there wasn't one before, but it is allowed by the C standard, and makes it easier to add/remove things in the future).


You love the ternaries! haha You can achieve the same thing here using:

```javascript
init = (typeof (init) === 'boolean' && init);
```


```
    <ProjectTypeGuids>{82b43b9b-a64c-4715-b499-d71e9ca2bd60};{F184B08F-C81C-45F6-A57F-5ABD9991F28F}</ProjectTypeGuids>
```
which translates to Extensibility,VB.NET which is correct but something thinks the 2 VB files are C#

The vsct file includes "C++" .h files and the comment says it is (usually) the C++ preprocessor don't know if that matters.


@Djspaceg 's first comment could be fixed with this commit
-Clicking on the slider while the video is playing makes the slider only animate to the click position, but it immediately bounces back to the current position. The video is unaffected. The video needs to jump-to that position and continue playing.-


Details designed


ist dieser dead code sehr unelegant? ich würde ihn sonst als Kommentar drin lassen, damit ich beim lesen weiß, "*eigentlich* steht da ein wg.Done(), aber das braucht man halt nicht".
Falls ich mal auf die Idee komme, das for zu breaken (SIGTERM oder so)


I really like your insight here into the key role of technical writers in preserving technology. I agree that it is critical that individuals have a solid understanding of technology in order to be an effective technical writer. From reading your posts, it seems like you have a strong understanding of modern technological tools and movements.


These need the "brief" flag, e.g.  `/// \brief The ... `


Ah, didn't realize this file had other constants -- good thing we moved this to the top.

Suggest changing to SUGGESTION_STATUS_NEW etc. to differentiate.


My idea is "but it also makes the current request available in the template". Are there additional considerations you meant by "provides a reference"?


add spaces around '='


... and are thus not explicitly verified in tests.


I'm not a huge fan of the names `needle` and `haystack`. Maybe `identifier` or `value`?

Also, I think for now, you should just do a `strcmp` until you implement quote handling.


Great! Thanks @DavidUM. Do you think this method will need `this.inherited(arguments);` to also run other tap rules?


Each invoice record looks something like this.

615005-2:
          DATE OF EVENT                            DESCRIPTION AMOUNT HOURS/UNITS SUBTOTAL DISCOUNT  TOTAL
23  2015-10-16 00:00:00                            On Broadway    255           3      765     None    765
24                 None                                 Atrium   None        None     None     None      0
25                 None                      Jingletown Lounge    145           3      435      0.5  217.5
26                 None                            OMI Gallery   None        None     None     None      0
27                 None                          Meridian Room   None        None     None     None      0
28                 None                                 Uptown   None        None     None     None      0
29                 None                               Downtown   None        None     None     None      0
30                 None                           East Oakland   None        None     None     None      0
31                 None                           West Oakland   None        None     None     None      0
32                 None                    Set Up & Break Down     75         2.5    187.5     None  187.5
33                 None                           IHO Staffing     40         5.5      220     None    220
34                 None  Standard Janitorial Fee/Waste Removal    350    Flat Fee      350     None    350
35                 None                         A/V Technician     40           1       40     None     40
36                 None                        Coffee Service    None        None     None     None      0
37                 None                               Security   None        None     None     None      0
38                 None                                   None   None        None     None     None      0
39                 None                                  Total   None        None   1997.5     None   1780


Let's call this `apply_rules`.


In response to your last comment: my suggestion would then be to handle both creation and retrieval in this method, and to make the name of the test more explicit. E.g. in this method you could create a suggestion for some other exp_id and thread_id that wasn't covered in setUp().


Remove the space before the parens.


The VSCT is completely separate from all normal compilation.
Create a new VB VSIX project and compare the project files.
Also, make sure your project is a `vbproj` and not a `csproj`.


:+1: how timely :wink:


hey, good commit! Are you interested in adding this to `acts` as a couple of files in a `contrib/` directory?


My idea was to remove SessionAuthenticationMiddleware in Django 2.0 (hence the "Will be RemovedInDjango20Warning" comment as a reminder) without a deprecation path as I don't see much value in the overhead of a deprecation given that it'll have been a no-op for several versions at that point. I'll enhance the release notes as you suggested.


Module `dialyzer_callgraph` is not listed among modules to be compiled natively in [`dialyzer_cl`](https://github.com/erlang/otp/blob/59911612aec5f18b099dbc518089dd3ce48fdd97/lib/dialyzer/src/dialyzer_cl.erl#L506-L513) hence I do not add `dialyzer_race_data_server` either. Not sure it is correct though.


This function is not used.


@Snaipe, thanks! Is there a dependency on gnu_cxx? When I run:

```sh
cd ~/projects ; rm -rf Criterion ; git clone https://github.com/Snaipe/Criterion --recursive ; cd Criterion ;
cmake . -DCTESTS=ON ;  cmake --build . ; cmake --build . --target criterion_tests ; ctest
```

on FreeBSD, it throws the following and continues:

```csh
Scanning dependencies of target redirect.cc.bin
[ 87%] Building CXX object samples/CMakeFiles/redirect.cc.bin.dir/redirect.cc.o
In file included from /root/projects/Criterion/samples/redirect.cc:2:
/root/projects/Criterion/include/criterion/redirect.h:40:13: fatal error: 'ext/stdio_sync_filebuf.h' file not found
#   include <ext/stdio_sync_filebuf.h>
            ^
1 error generated.
samples/CMakeFiles/redirect.cc.bin.dir/build.make:54: recipe for target 'samples/CMakeFiles/redirect.cc.bin.dir/redirect
.cc.o' failed
gmake[3]: *** [samples/CMakeFiles/redirect.cc.bin.dir/redirect.cc.o] Error 1
CMakeFiles/Makefile2:1899: recipe for target 'samples/CMakeFiles/redirect.cc.bin.dir/all' failed
gmake[2]: *** [samples/CMakeFiles/redirect.cc.bin.dir/all] Error 2
CMakeFiles/Makefile2:105: recipe for target 'CMakeFiles/criterion_tests.dir/rule' failed
gmake[1]: *** [CMakeFiles/criterion_tests.dir/rule] Error 2
Makefile:193: recipe for target 'criterion_tests' failed
gmake: *** [criterion_tests] Error 2
```

And test score is 89%.


Hygiene pay layout
^₤{[}<^}}¥£¥±§§±


Oh no !


Could use an object here.


You should check if this returned `NULL`.

Usually the technique I use for things like this is to "unwind" using error labels.

In this case,

```c
error2:
	free(action->needle);
error1:
	free(rule);
error0:
	return false;
```


thanks


result.source_filename으로 확장자를 찾는게 좋지 않을까요?


Delete wgarcias_  non personal project


From history of Slider.js, it does not need super call.
When you implemented vertical slider, you just changed handler name.
https://github.com/enyojs/moonstone/commit/9b3c30987b8c8b7303d1a4f55e59b310c081448f


This should've been merged with 'addNamedItem' with the method name changed.


file editted


I guess he assumed you could add the same item multiple times with varying quantities.


@grayjay OK, if the test suite passes for you on Windows, I'm satisfied this is the right thing to do. Could you make a pull request?


Wished he used his subtotal here.


This isn't what the output of "range( )" is in Python 3 - try it.


5 – No menu, ao lado da opção para cadastro de um veículo, deve estar sempre visível a quantidade de veículos existente no cadastro.   segue minha parte e do samuel


segue a outra 6 – No menu, ao lado da opção para venda de veículo, deve estar sempre visível o valor total em veículos vendidos no dia.
Observações Importantes:  1º) Deve-se utilizar lista de encadeamento simples ou duplo.  2º) O programa deve apresentar um menu ao usuário contendo todas as opções disponíveis para o usuário.


Because we are processing xml inputs I want all fields to be NULL-able (i.e. objects).  That way the service writer can tell the difference between a value that is 0 and one that was not provided.

That being said a user can set defaults for parameters and not have to deal with NULLs if that want to.


esto es comentario


Diógenes - Vou fazer a inclusão do veículos


Fortress maximum sys
Forgeries stasis


Actually this whole file isn't needed.  I changed the name to esdl2java_srvbase.xslt and forgot to get rid of the old one.  Deleting it now.


Evaluate errors demand


It needs improvement but at least users have something to play with.


Eu e Samuel iremos agilizar o resto


Coresub


The dependency can be removed, but needs to be replaced by a filebuf synchronized to a std::FILE*, which <ext/stdio_sync_filebuf.h> provides.
What compiler are you using ? Both GCC ang clang should be able to compile that.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 680](https://teamcity.labkey.org/viewLog.html?buildId=273390&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:25:00
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 23 more failed tests, see build details
```


Done.


psst, the other pom references 0.13.0 (should bump to 0.13.1 when you get around to it, due to bug with subscriptions)


>What compiler are you using ?

```sh
root@fbsd-pc:~/projects/Criterion # clang -v
FreeBSD clang version 3.4.1 (tags/RELEASE_34/dot1-final 208032) 20140512
Target: x86_64-unknown-freebsd10.1
Thread model: posix
Selected GCC installation:
```
Should I upgrade to clang37?


Mauricio. Vou fazer a questão 3 – Valor total. Criar função para exibir o valor total em veículos cadastrados.


I created a new VB extension project added a Menu Item and get identical errors. I filed it with details under Roslyn project.


remove those spaces


This broke stuff for us.  Perhaps stick with "latest release" as per https://github.com/clojure/clojurescript/releases to be save.

Current latest release is 1.7.48


i am going to negate this commit since no one appears to be using this updated codebase of ix coin and if they decide to we can discuss protocol changes that would kick older clients off the network at that time.


I didn't realise you implemented part of the encoder until right now when I was about to push, I've quickly integrated your tests with my encoder, I think that's the best of both commits. Thoughts?

I will continue working on "chat new" (that's why I had to implement the encoder first).


changed label


TeamCity pull requests :: netty [Build 236](https://garage.netty.io/teamcity/viewLog.html?buildId=1537&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5602, ignored: 21 Build time: 00:37:15


Try adding -stdlib=libstdc++ to the CFLAGS?

Replacing ext/stdio_sync_filebuf.h will be done nonetheless, but I'm curious on why clang would not provide a FILE*-to-stream bridge.


This for Vizio will not work when
 MediaInfo = true is on at same time
So one or the other has to go
Their will be no folder tree if both are enabled


Will move this to next line before submission


Need to write the matrix multiply functions still. The rest are working.


The default virtual server has no name, and server->name is NULL.  Printing (NULL) for the name is confusing.


can we do this once per test run instead per test suite? I can't see a scenario where the jars would ever change from test suite to test suite


I would transform the for loop to `Object.keys(item.queryParams).forEach(function(ppty) {...`, then you can simplify the check to `if (!queryParams.hasOwnProperty(ppty)) return false;`, since `Object.keys()`is already guaranteed to only iterate over `item.queryParam`'s own properties.


Is this the code CEX/f2pool requested?

Sent from my iPad

> On Sep 21, 2015, at 5:43 PM, cinnamon_carter <notifications@github.com> wrote:
>
> i am going to negate this commit since no one appears to be using this updated codebase of ix coin and if they decide to we can discuss protocol changes that would kick older clients off the network at that time.
>
> —
> Reply to this email directly or view it on GitHub.
>


I don't think this tests anything related to your change, so I'd remove it


We can place this number in an external config. Let me handle that.


New line at EOF la.


Why you've moved redux-devtools to production dependencies? o O


General comment: Please add class level comments as well as comment the important methods.


btw in general you should pretty much always use `===` over `==` in Javascript to avoid type coercion


<img width="364" alt="screen shot 2015-09-21 at 5 51 16 pm" src="https://cloud.githubusercontent.com/assets/5726560/10008884/65cb4748-6089-11e5-805e-5f9f23e13854.png">


Same here: rather than `!=`, use `!==`


@AhmedMustafa, please is this translation correct? Thanks in advance.


this has probably no effect. we should watch this anyway!


Absolutely, that's why they're there, best of luck!


This method does 2 things at one time. Should we further refactor that into validation and wrong epoch response.


cc @ManrajGrover


Need to update this to remove fit4mom logo from this new company


Since this will be subtracting size bytes, should there be a check for availableShared >=0 ?   I am not quite sure what's supposed to happen if this value drops below 0 at this point...


If some intermediate malloc() failed, there will be garbage in result[i].
Should it fail here instead of continue?


Comments as to what these are for.


result is not zeroed. If we continue here, what would be in result[i]?


Looks good to me!


live :http://aquafeed.cleverapps.io/


Separate this in to a factory.  This case statement is the perfect place to implement the factory pattern, which you can read about in the begining of the PPP book


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1880 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Good behavioral change here.


Need comments to explain this as well.


Good stuff


@saraswatayu, can you run this and add an actor? It looks like something else is wrong with this step. According to this node (https://www.udacity.com/course/viewer#!/c-ud325-nd/l-3600449243/m-3602689628), this step should have a working but not persistent version of the app, I believe.


Cool


First of all, I really enjoy how you've formatted this information.

I like that you chose to summarizes Hansa's video. I did not realize that I was supposed to summarize the video as well. Anyways: I think you do a good job of summarizing the main points of Hansa's video and I like your example of how intricate the process can become. The idea of something as simple as a square having a very intricate painting process reminded me of something I recently learned in my data analytics class about how even the simplest of text documents can be a high dimensional problem--Green Eggs & Ham is a 50D problem. This theme of seemingly simple objects involving much more complex background seems prevalent across all sectors of technology.


The same as below.


I agree! The layout is fantastic. You make an interesting point about the layout following websites, but it's incredibly accurate.  Visually the book is very aesthetically appealing and I like the way the information is broken into snackable chunks. In terms of the actual text, I find the wordings and the way in which Duckett sets up background information before introducing new concepts to be incredibly helpful.


I think there are some extra spaces before the closing ")"


extra space


it looks like this test covers all the cases. did the previous ones uncover bugs that this one doesn't catch? if not, I would remove the others


same comment as the aggregation test. do we need all these cases or just the last query?


Good idea, but it will be great to delete file Results.txt or add a warning if file existing when enable_log is updated to False to avoid that users get some links from google ... :

Eg:
keekoob.fr/modules/paypal/api/Results.txt
villalebosquet.com/modules/paypal/api/Results.txt
esmaltespermanentesbluesky.com/modules/paypal/api/...
magicoque.com/modules/paypal/api/Results.txt
modesavenue.com/modules/paypal/api/Results.txt
nutricosmeticshop.com/modules/paypal/api/Results.txt
funlyrics.fr/modules/paypal/api/Results.txt
jemni.de/modules/paypal/api/Results.txt
...

#ECP15


Need comments to help understand this.


same question about this test. do we need all these queries or just one of them?


put whitespace changes and the stylistic change below in a separate commit


Good Job!


It feels weird that the game class knows about how to print specific parts of the board.  The 'view' is too coupled here to the business logic.  A great heuristic is to keep the view logic as far away from the business logic as possible.


I'm glad that you quoted this analogy as I found it particularly interesting in light of last week's conversations about Haas and Keim and  technology not following a linear sequence. It's fascinating because, as you imply, older technologies often supply the skeleton for new technologies to be fleshed out on. Sure, our sites have evolved far beyond the sophistication of sites back when HTML was first being dreamt up, but cars have also evolved since the Model T and they still use engines and wheels. The core features remain more or less the same.


Sorry, Adam.


ababababa


This is a very clever way of returning the coordinates, I had to reverse engineer your pythonic function to figure out how you did it!


Each time a dependency is used, it should be required at the top of the file that the class is created in.  These kind of 'require farms' are a bad practice to get in too for 2 reasons.
1 -  you don't know what the individual file depends on easily
2 - it is likely you require too much.  There may be classes not required depending on the path through the application.


These are the defaults I would pick.  If you think it should be different please let me know (or change it).


Палишь пасс! :) Выложи бинарник NibDecompiler'а если не сложно)


Input should be injected in the constructor and saved as state.  Otherwise you will have an arity mismatch on the get move classes when trying to use them polymorphicly.


make this a separate rule like columnReference instead of handling the `base == null` case in the `ASTBuilder`


Is This commit apply to 'Preferences > Text Eitor' and 'Preferences > Code Editor' options?


I think it would be better to use a separate rule for this case. See my comment in the grammar file


Looks great.

J.R.

On Mon, Sep 21, 2015 at 6:17 PM, HoesLeaguesharp <notifications@github.com>
wrote:

> Sorry about that! check now
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jayblah/Hoes/commit/bb2ac4d34814abb295974d094fd0263732c66169#commitcomment-13354516>
> .
>


I also noticed the nice layout of the textbook. It's almost designed like a  PowerPoint presentation, which makes it easy to follow. The use of color to differentiate the parts of the elements is an effective communication tool.


You could chain function calls since jquery always returns de element. It's a good practice when you are changing single attributes in the element.  Also, when you use `css()` jQuery's method, you are setting inline style. It's ok in this exercise, but remember that is better to add a css class dinamically.


For some reason I could only get this to work with ng-include=' "todos-list.ng.html" ' (reversing the order of ' and ")

Not sure if this is just because of my specific version of Chrome


It's a good starting point. Don't be disapointed ;-)


Added Hello2


@levity the alignment is not correct but actually removing these two lines fixes the issue in my computer running Linux Atom 1.0.14, Linter 1.6.0. Please advise.

Buttons properly aligned:

![screenshot from 2015-09-21 22 15 57](https://cloud.githubusercontent.com/assets/2621975/10009126/73e092f0-60ae-11e5-8a2d-066b0e733398.png)

Buttons alignment issue:

![screenshot from 2015-09-21 22 15 20](https://cloud.githubusercontent.com/assets/2621975/10009127/73e84fe0-60ae-11e5-9aca-a2be875a639b.png)


What is this supposed to be testing, if we're no longer adding `zips` to the local DB? Same goes for the `count` on the following line.


also look at LengthFieldPrepender class.


@gabmontes I am on it already :)


I think the default is `-stdlib=libstdc++`. Adding `  set(CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS} -stdlib=libstdc++)` to CMakeLists.([before line 40](https://github.com/Snaipe/Criterion/blob/1c42bf8de0df2ff9362b4a58488c540eefcc3b1e/CMakeLists.txt#L40)) had no effect.

Some related findings:

```csh
root@fbsd-pc:~/projects/Criterion # ls /usr/include/c++/
4.2     v1

root@fbsd-pc:~/projects/Criterion # ls /usr/include/c++/4.2/ext
pb_ds

root@fbsd-pc:~/projects/Criterion # ls /usr/include/c++/v1/ext
__hash          hash_map        hash_set
```


What is going on here? I would have done this like: blalba


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1876 of 1883 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


# This commit makes me curious.
![Image of wat](http://media2.giphy.com/media/FiGiRei2ICzzG/200.gif)


how is this used? it looks like it's used to tell whether this deref "is a" QNR. I don't think you can tell that without context from the analysis though, for example "table.column.field" will look the same as "schema.table.column"


From Pilgrim's article it seems that the developers of XML were not as concerned about accessibility and usability. I can understand their being perfectionists and not wanting broken web pages, but a catastrophic failure and error messages would make using the web frustrating for most users. It's good that most developers were more concerned about usability than about having perfect web pages.


Good try !

But it would be safer to use the following
since this will be reinitialized many times with different values,
you want to be absolutely sure that you cancel the previous value.

if (r >= 1.5)
            Reductions[pv][imp][d][mc] = int(r) * ONE_PLY;
else
            Reductions[pv][imp][d][mc] = 0 * ONE_PLY;

And while being there, you can use just one loop.

for (int mc = 1; mc < 64; ++mc)
 256  +              {
 257  +                  double r = K[pv][0] + log(d) * mc_tune[(int) (mc/8.0)] / K[pv][1];
 258  +
 259  +                  if (r >= 1.5)
 260  +                      Reductions[pv][imp][d][mc] = int(r) * ONE_PLY;
                                 else
                                     Reductions[pv][imp][d][mc] = 0 * ONE_PLY;

 261  +
 262  +                  // Increase reduction when eval is not improving
 263  +                  if (!pv && !imp && Reductions[pv][imp][d][mc] >= 2 * ONE_PLY)
 264  +                      Reductions[pv][imp][d][mc] += ONE_PLY;
 265  +              }


@librehat https://github.com/shadowsocks/shadowsocks-libev/blob/master/src/server.c#L530


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Good job with the indentation here!


Use the IOC container for this, `\Core::bindShared('concrete/translation/repository/manager', function() { ... });`


This needs a better name like `TranslationRepository`


Yea, I just wrote that quickly :)


Looks good to me!


Instead of doing:
``Select all tags that match filter``
``Select all volumes``
``Subtract filtered set from all volumes``
We can use the AWS built in negative filter.  e.g. try searching for ``tag:Name : !foo`` to find volumes in the region that do not have the name ``foo``.


Don't advocate this

```php
return array(
    'placeholder_text_multiple' => 'Select Some Options',
    ...
);
```
Notice that that string isn't translated. I don't think these strings should be translated here, this set of objects only manages the strings to be translated, it doesn't manage translating.


All of these files new newlines


I'm sure that there is another clear way to do it.


Yes, that is what is meant.  Yes, it would be nice to fix.  I left the corresponding issue open because I do not consider this done.  As discussed in [issue #104, comment #3](/dxx-rebirth/dxx-rebirth/issues/104#issuecomment-113016590), the problem is that the game window logic flushes all inputs whenever it is activated.  If this is removed, then all the individual sites that need input to be flushed would have to be found and modified.  Modifying them is not hard, but inventorying them is time consuming.


you should add blank line between methods, and the `private`

like..
````
end

private

def markdown_body
```


Where should they be translated?


This shouldn't happen here, this object is only a repository for translatable strings. The controller will manage how these are outputted.


no need to check this in.. you didn't make changes here.


This is where we should be managing translating and outputting the strings


They all extend this, thats just the base/default implementation


Remember that this line is executed when the script it's loaded. If you need to reach a dom's element it's a good practice to include this line inside of `ready` event callback method.


RE: your question about `@post` vs `post`, here you dont need the `@` since `post` is a local variable defined above on line 10.


I learned when making the sample web page that Duckett suggests that it isn't necessary to use Notepad. A word processor works too, but you have to save as text with an html file extension. When I told the word processor to save as html it gave me a page with a nice rendering of the code I wrote.


Here you are correct that you do need `@post`, since `@post` comes from the controller.


I feel like that would increase the memory usage, you store an array with key => untranslated-value, then loop through that array and t() each time (and possibly store the translated array as well). I understand why, but I think there might be a minor perf hit.


```php
\Core::bindShared('Concrete\Core\Translation\TranslationRepositoryManager', function($app) {
    $manager = new TranslationManager($app);
    $repositories = $app['config']['core.translation.repositories'];

    foreach ($repositories as $handle => $repository) {
        $manager->addRepository($handle, $app->make($repository));
    }

    return $manager;
});
```


Thanks a lot @marcosramirezaranda ! One line of code that fixes the problem. Awesome!


We should not be adding anything to this bootstrap file, everything should be added as service providers. We can register this one first.


Function "wp_localize_script".
For some reason I changed the function name to "a". :P


I don't think we need an alias for this. We can just use the `\Core::make`


I think we should wait for some more input on how this should work. We might replace all of these localization routes.


Why don't we add OptimizationLevel.DebugFriendlyRelease (or DebuggableRelease)?


Yea, the plan is to remove all of the above routes, I just haven't gotten there yet.


Ok, go ahead. Also add some basic doc string around how this param should only be used with a sorted model, and we'll make a new release.


Perfect!!!


Yes.


This class is organized incorrectly, this default repository should allow adding translatable strings:

```php
\Core::make('Concrete\Core\Translation\TranslationRepository')->addTranslationString('My translatable string', 'Some additional context');

// Or depending how we go with it

\Core::make('concrete/translation/repository/javascript')->addTranslationString('Some string', 'some context');
```
We shouldn't require every person using this to implement their own repository.


initial commit done.


> sometimes its necessary

it's


I don't claim to know English.


@jaanumahe Please delete this whitespace.


Ill add a default repository, Concrete.translations.default sound good?


Once again, I'm impressed by your python coding skills, I had to unpack your one-liner to understand how you did it. My only question is - is it faster to do this way then say take the transpose of measurements and store it in 3 vectors. I was curious so I timed your code using the function that we used in class today (timeit) and it took ~7.9 µs per loop (100000 loops, best of 3: 7.9 µs per loop). I then ran using the transpose option and it took ~1.34 µs per loop. So your function took roughly 7 times longer but this could be because of python overhead, just thought it would be interesting to investigate.


sick commit yo


Yes, as long as you understand the issue and are comfortable with the risk, this is fine.

The risk:  I consider it somewhat risky to enable format_raw and format_all at the same time (which is why format_raw is not included in format_all).  This is because it short-cuts the error handling:  a slightly-damaged tar file, for instance, might be claimed by format_raw (because it's not recognized by the tar module) instead of leading to an error for a malformed file.

I recommend that you enable either format_all or format_raw but not both at the same time.  Of course, this requires that you have some other way to determine which format is expected (such as filename extension).


testing comment


Unclear what you mean here. The key isn't being changed, the value is. And it's not about the key being mutable, it's about whether the value is wrapped with the UnsafeProxy class or not.


Ignore this update, I didn't realize that Andreas had already done this. I don't know why it pushed it to the github since it never completed automatically merging. Just look at the next commit


SRP requires that each class have a single responsibility, this class is in charge of keeping a list of strings to be translated. It already has a responsibility, it shouldn't also need to render and output this stuff.


This repo is a fork of the original wiic which is hosted on Sourceforge:
http://sourceforge.net/projects/wiic/

This specific commit was made 4 years ago by the creator of wiic, Gabriele
Randelli. You may want to try to find and contact him if you want more
details about this. Sorry if that isn't too helpful.
On Sep 21, 2015 8:18 AM, "André Willik Valenti" <notifications@github.com>
wrote:

> Hello,
>
> I'm having memory leak issues with WiiuseJ, a wiiuse wrapper for Java. I
> don't know if its caused by WiiuseJ or wiiuse itself. Did this commit fix a
> memory leak issue present in wiiuse? Or was an issue only on your library,
> WiiC?
>
> Thank you!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/casallas/wiic/commit/e6427bab98425e340d9df099bf1c6d8142947256#commitcomment-13345392>
> .
>


how is:

```php
$strings = array('1','2','3');
$strings = array_map('t', $strings);
```
more of a memory hit than
```
$strings = array(t('1'),t('2'),t('3'));
```
? Why would we translate this list more than once in a request?


This change will make nodes that don't sign messages to the sender skip verifying messages from that sender. That is not good. A node that require signatures, must verify ALL messages. Not just messages from nodes that also require signatures.
The GW should not behave like this though. I have to look up what has happened to the special case of the GW but this change would affect both GW and nodes.


On the motivation for this validation ...

@michaelklishin Could you please explain why the ```handshakeTimeout``` needs to be lower than the ```connectionTimeout``` ?

I understand ```connectionTimeout``` is used as the socket connection timeout, that is used to establish the connection.
And ```handshakeTimeout``` is the socket soTimeout, that is used only when the socket is already connected, to signal if the socket is silent. It's set to this value only at the very beginning of the ```AMQConnection``` ```start()```. Then, the heartbeat is used to compute a new soTimeout (```heartbeat * 1000 / 4```) for the socket, so the ```handshakeTimeout``` is only used for a very short time.

So I don't see a relation between ```handshakeTimeout``` and ```connectionTimeout``` that requires ```handshakeTimeout``` be lower than ```connectionTimeout```.


Ok, now I am more in sync. Did not see this change before. I will still see where my original change went to handle this because it was supposed to be like this already.


page_size 会不会好些？


:cry:  后面的体检格式化了


Better to move `checkArguments` and `forOwn` funcitons to different modules so they could be reused (when it will be needed).


@Nadahar oh, cool. Feel free to update it to 1.8 and remove the notes, if you want


@maxkfranz should we merge this?


@YannRobert fair enough, it can be something that only makes sense to us because we have "too deep" an understanding of the implementation. I'll remove the validation part.


the bug was actually in `separate()`


Would it be simpler here to remove the `if @user_signup.errors[:email].size == 1` and just use this line for either case?

It'd be nice to have a more descriptive name for `x` - `error` ?


体检？？？


@Nadahar it will probably be in the weekend so if you do it on Thursday you should be pretty close


per_page 比较通用吧？


well we could mock `sys.stdout`, I thought that capture is doing something like that


提交。


I'm sorry for having caused confusion about the contrib folder. Actually I renamed the boost-1.58 folder to boost-1.56-1.58 , but must haved missed the boost_1.55-1.56 folder. Anyway, I cloned the full repo from master and your fork as well, made a diff to isolate the commit 82a5bb1762a0cbcda28d21a7b1d35cb32a4996ec and applied it.

this is what I get as a result

[ 18%] Building CXX object libsiedler2/src/CMakeFiles/siedler2.dir/ArchivInfo.cpp.o
/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.5/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib/gcc/x86_64-pc-linux-gnu/4.8.5/../../../../lib64/libboost_filesystem.a(operations.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
/usr/lib/gcc/x86_64-pc-linux-gnu/4.8.5/../../../../lib64/libboost_filesystem.a: error adding symbols: Bad value

for the complete build log have a look here https://bpaste.net/show/9d3dcb824dd7


@maxkfranz should we merge it into master?


Тут ошибка. Теперь /Problem/Create не работает, так как вьюшка не знает как заполнить Required-поля


I think we should probably make this translatable:
`<%= submit_tag _('Sign up'), :tabindex => 50, :data => {:disable_with => _("Sending...")} %>`


Fixed bug<bug
And added new getSprites <feature


Oh there should be a bug in my brain. Apparently I should add the checking before this line. Thanks @uaalto !


You should probably not commit Makefiles generated by automake and .Po files in .deps directories.


@skeptical that sounds good to me, it would be cool if you can update the tests for the change if you have time too


I am recompiling boost-1.56.0 with additional -fPIC cflags right now, but I am not sure what this may break elsewhere on my system. Is it possible to work around it somehow?


Note: this is the hash of the release-2.4.0-rc3 HEAD.


About the second question: I believe the type of `print_string` could be strengthened to have a weaker effect `IO` instead of `ML`. But I don't know what's the status of the `IO` effect and what would be the impact of strengthening the signatures of functions in FStar.IO. I think that's a very good question to ask at FStarLang/FStar.


"reset event" reads a bit too technical for regular endusers I think. The effect for the enduser is the same as before, isn't it? So old labels would still match from a endusers point of view even if it's handled differently internally?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21029/testReport/) for this commit**


哦哦，sorry :sob:


Looks like that. Thanks for the hint! I'll do a patch and check for more occurrences of missing checks.


commit 579dbf4cacd8bdfac34c3b7cef538587d09c4a33 can be reverted now


@dcarley That got pointed out to me the day after - I didn't realise this was anything more than a test repo. Sorry!


> 2.2.3 is the one used by smart-answers currently.

How do we know that Smartdown is using Ruby 2.2.3?


Probably a more elegant way to do this is to use an abstraction on top of the 2d array which can then be constrained easily with a wrapper. Let me demonstate:

```java
interface LocationRow extends Iterable<Location> {
}

interface LocationGrid extends Iterable<LocationRow> {
}

class ArrayLocationRow implements LocationRow {
  private Location[] locations;
  Iterator<Location> iterator() {
    // ...
  }
}

class ArrayLocationGrid implements LocationGrid {
  private LocationRow[] rows;
  Iterator<LocationRow> iterator() {
    // ...
  }
}

class BoundedLocationGrid implements LocationGrid {
   private ArrayLocationGrid delegate;
   private int offsetX;
   private int offsetY;
   private int width;
   private int height;
   // ...
}
```

Then to create your adjacent coords it's one line:

```java
return new BoundedLocationGrid(this.locationGrid, loc.x - 1, loc.y - 1, 3, 3);
```

This will be more generic and can be applied for other uses.


<!doctype html>

<title>xgqfrms's github blog</title>
<meta charset="utf-8"/>

hello world !


Ignore me. Now that I've re-read your comment I see that it's because Smart Answers is using 2.2.3.


Typo here.


@summerblue 你英文比较好，我菜鸟，你看看哪个词比较好，我感觉per page 好像表示不了**每页的大小**，反而只代表 **每页** :laughing:


Darn.


Done in https://github.com/UniversalMediaServer/UniversalMediaServer/commit/23a41ca194d8d6a5a1b88a1893692158c0df623b


I think it should just say Configuration API, without "Module"


Thats Great


Should this not stay as a timeout, based on the comment above?


On this line: https://github.com/fleinze/MySensors/commit/518ed6af7c71fafc8198801c47036f6e74872222#diff-957e773aa509ae0ea23a62fad74212a4R673
the logic to handle GW signing requirements is handled.
It works like this:
When the GW receives signing request form a node (sent at node startup) it will reply with it's own requirements.
If the GW require signing, it will tell the node that it does so and that should cause the node to sign messages to the GW.
However, I see now that in the GW case, it would still require signed messages from all nodes it seem. This is the problem you see, right?
Your fix should solve that case I believe.
The change would mean that now, when a node receives a message, and it require signatures, it will do signature verification if it is not a gateway or it signs messages to the sender, and that is in line with the documentation.


如果不是 binary，encoding 应该不要设置


$templateProcessor->cloneBlock('BLOCK', count($testData));


#5 closed.


`hasOwnProperty` aren't optimal way to understand that `restrictions` has `restrictionKey` as property.

![2015-09-22_1306](https://cloud.githubusercontent.com/assets/4028472/10015951/1bfb0c54-612c-11e5-8ef3-06c25eaca6bf.png)


@whiskeyfei Hi, I think a series of tutorials will only need to add one, like [Android Studio系列教程]. What do you think?


δεν είναι και πολύ `.css` αυτό το αρχείο :eyes:


`stateToJS(store.getState())`?


AAAAAAAAARRRRRrrrrrrght!!!!

IT IS PISS RAINING AND NOW I HAVE TO GO FOR WIENERBROED!!!


@JorgeFerrer, yes, you are right, I was thinking on before when we had Module Configuration. It should be only Configuration

CC: @sez11a


Take a look at [this article](http://phrogz.net/death-to-hasownproperty)
In other words: you don't need to check everything for hasOwnProperty anymore.

Take a look at the following snippet:
```js
var a = { b: 2 };

for(var i in a){
  console.log(i);
}
```

Console output won't have a hidden properties that are related to object's prototype.


If a Door isn't open, then an Actor can't walk through it.


Spotting the race condition in the example above is left as an exercise to the reader (hint: `get_try()` is called `get_try()` and not `get()` for a reason)


Just a styling advice

```js
if(types.hasOwnProperty(condition)) {
  return types[condition](value);
}
else {
  throw new Error('Error type');
}
```

are same as

```js
if(types.hasOwnProperty(condition)) {
  return types[condition](value);
}
throw new Error('Error type');
```

but second example are easier to read.


I'm commenting


Hms, I disagree with this commit but it is a bit late. I dont clearly understand why it is removed in first place. It could be that it can be in connected state when gui is opened. This kind of functionality is why we have a gui. I want to give my own url which I was already using to test with different urlled livres ( where you can set your zeq schema ). How will it be possible now. I hope not command line ?


Is an O(N) search for users really a good idea? With hundreds of thousands of users, and hundreds of simultaneous battles....


I am going to manually merge only Teensy commits, please resend RTC STMF4 changes. Thanks for understanding


"old_version" problem still exist while trying to register phone number.


Lets not hard pin like this.  Any point release won't work.  The issue is in ``1.7.0`` So lets ``<1.7.0`` this.


Our author data could be rewritten to:

```YML
- name: "Graeme McCubbin"
  bio: "..."
  image: "..."
- name: "Paula Stepinska"
  bio: "..."
  image: "..."
- name: "Tom Sabin"
  bio: "..."
  image: "..."
```

Removing the need for us to duplicate the name in the list.

We can also use [Enumerable#detect](http://ruby-doc.org/core-2.2.3/Enumerable.html#method-i-detect) to pick an element out of the array:

```RUBY
def get_author(article_author)
  author = data.authors.detect { |author| author["name"].downcase == article_author.downcase }
  author.nil? ? raise('No author found') : author
end
```


i would have done this - but:
a) there is only 1.6.0 in the 1.6.x serires
b) i wasnt sure what the min version is


For CSV format we need to split using `,` instead of `;`.


These change the Python 2 behaviour.


Why do we need this since jodconverter supports a system property (office.home)?


Sorry
> ~~why the ```handshakeTimeout``` needs to be _lower_ than the ```connectionTimeout``` ?~~

I meant why the ```handshakeTimeout``` needs to be ***greater*** than the ```connectionTimeout```?

@michaelklishin Do you mean that even if the code does not enforce the validation (because you'll remove it), you recommend to still use a ```handshakeTimeout``` that is greater than the ```connectionTimeout```?

If so, why? My point is really to understand.

Is there any problem to use for instance ```handshakeTimeout = 10000``` and ```connectionTimeout = 20000```?


Hi N,

Account tab now gives **Cannot read property 'length' of undefined**, and no user entries in table.
Meteor 1.2 & all packages to latest and greatest.

Do you kno the fix?

Regards, J*


I think this should be pulled out into a separate PR and discussed with @threedaymonk, @SteveMarshall & @EGiataganas as to whether or not they are happy to add this in.


How do you think about to add any configuration checks if your software depends on specific features from the GNU implementation around program termination?


OK, When you update new code, please notify or comment in here, i will check and test, i like your code, but your effect not smooth like hellomonday.com (I was just read code it, and i see they calculate matrix different like you

Thanks.


i.e. If I collapse a cube and get the value of a textual, collapsed coordinate it will now be an instance of `numpy.unicode_` instead of an instance of `numpy.string_`. User code doing `isinstance(value, str)` will fail.


I don't think it matters what the min version was. pip will try the newer one given the constraints provided (`<1.7.0` in our case).


I already use containsKey() in the parseMap() method to make sure the txt file doesn't have any invalid symbols.

How would you go from char to enum using the constructor?


Ah yeah thanks -- good catch!


It's make more sense.
i will revert my last commit and merge it on Thursday.


not really. now there is no dependency to player, hence there is nothing to pause. assume you switch refresh rate for picture viewer.


Car avec l'ascii ça passe avec les accents :
Le test est ici : https://github.com/OpenZWave/python-openzwave/blob/master/tests/api/test_node.py#L90


Dear joergoster,

If this fails, try something like this:
delta += delta / 3 + Value(log(depth) * 2);
I doubt that any depth-based behaviour is linear.


Heh .. good job guys


Shouldn't it be non-(getter/setter)-methods instead of none?
none = keine
non = nicht


Would it be appropriate to omit line breaks within such an URL?


It is the response in case of clicking the cancel button when trying to authenticate.


I don't think you need the `:data` key: http://api.rubyonrails.org/v3.2.22/classes/ActionView/Helpers/FormTagHelper.html#method-i-submit_tag


的的的的


Seems likely.

On 22 September 2015 at 19:23, Ruslan Prokopchuk <notifications@github.com>
wrote:

> I checked out mentioned revision of WR, and tried to do subsequent `lein do
> clean, cljsbuild once` for ampere with different versions of cljs. After
> that I've repeated building process while changing cljs versions in WR. All
> builds were successful. Couldn't test with Windows at the moment, but a
> little bit later I will check, may be it is really Windows-specific error
> (may be one which is fixed here
> https://github.com/clojure/clojurescript/releases/tag/r1.7.58 ???)
>
> вт, 22 сент. 2015 г. в 12:09, Oliver George <notifications@github.com>:
>
> > Strange. Any chance I'm seeing a windows specific issue? How did you
> test?
> >
> > On 22 September 2015 at 18:45, Ruslan Prokopchuk <
> notifications@github.com
> > >
> > wrote:
> >
> > > Okay, I just tested against c86fc8a of WR and see that CLJS version in
> > > ampere doesn't influence to WR build. But I also have successful build
> > with
> > > 1.7.28, 1.7.48, 1.7.122 in WR's project.clj. May be it was weird
> caching
> > > issue? Try again with lein clean or even manual deletion of target and
> > > generated js.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/condense/ampere/commit/e7d96f159e2c1276026f073834b3a3f795743150#commitcomment-13361496
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/condense/ampere/commit/e7d96f159e2c1276026f073834b3a3f795743150#commitcomment-13362031
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/condense/ampere/commit/e7d96f159e2c1276026f073834b3a3f795743150#commitcomment-13362314>
> .
>


The system property "office.home" is not a valid environment variable. It's a java system property and it's hard to set only when the functional tests run.


I've created #29 :revolving_hearts:


эти файлы сами генерируются


эти тоже


See: http://stackoverflow.com/questions/2821043/allowed-characters-in-linux-environment-variable-names


Forgot to say that I have removed the module for methodlength for checkstyle,  this is because some of the methods cannot be shorter due to JavaFX. <configuration


Dude "\"  is used when you want to add new line to same block of code (if you want to add new item in list)


This `presenter_for` method looks somewhat similar to `SmartAnswerPresenter#presenter_for`. Did you consider using that method? Does that even make sense?


jo, durations sauber zu parsen wär schon much more awesome :)


**All URL is used prefix localhost:8080/rest**


fair point - ive removed


@jread-usgs I change some settings in the 'glm.nml', Now, it works. Thanks!


At some point I'll have to open pull requests for all these bastards living in the `patches` directory.


Ups, sorry, a "lapsus"


For fun, here is a race free version -- but I need to figure out how to invoke when_all instead of busy waiting for the answer ;-)

    #include "stlab/future.hpp"
    #include <iostream>
    #include <vector>
    #include <thread>

    auto schedule = [](auto f) { std::thread(std::move(f)).detach(); };

    // trivial transforms
    auto x2 = [](auto x) { return 2*x; };
    auto p1 = [](auto x) { return x+1; };
    auto print = [](auto x) { std::cout << x << std::endl ; return x; };

    int main() {

       std::vector<std::function<double(double)>> stack = { x2, p1, print, p1, x2, p1 };
       std::vector<stlab::future<double>> futs;

       auto first = std::begin(stack);
       futs.push_back( stlab::async( schedule, *first, 2. ) );
       while ( ++first != std::end(stack) ) {
           futs.push_back( futs.back().then( *first ) );
       }

       // is there a better way than polling to get the result?
       auto result = futs.back().get_try();
       while (!result) result = futs.back().get_try();
       std::cout << *result << std::endl;
    }


commenting on added file commit


should be pt-BR


Ok, but I still think the wording is too technical and nobody will understand what a "reset event" is. If it's ok with you I try to find a little more user friendly wording for the description. If you don't want to be bothered with that stuff now, just tell and I'll fix labels after your changes are in (or during PR phase in one go)


It doesn't look like `%{i_dont_exist}` has been added elsewhere. Presumably this wasn't being used by these tests?


Mistake in Line 120? -> 2.


superfluous include


this can live in detail


The URL is plain too long. The limits are: not more than 80 chars in the code and not more than 70 chars in the long description of the commit. Who really wants to see this, browses through the main home page or puts some search words into a search engine.


actually it's better if you assert first before doing any work by checking idx_+1 <= pack_->size()


Ok, that's up to you but you could just say that walking through a door implicitly opens it if it is not locked and then you don't need to worry about the additional complexity.


Gör variabler för width och height istället bror.


for this you can just change it to :
#if defined(FREEBSD) || defined(__DragonFly__)

the version is always > 7 so it doesn't need to be checked.


:shipit:


удалил абзац(тест)


If `Terrain.forSymbol` returns `null` then the symbol is invalid.

This is what your constructor should do:

```java
private Terrain(boolean traversable, char symbol) {
  isTraversable = traversable;
  terrainSymbols.put(symbol, this);
}
```


102867486-FixRectangleShapeTest-5173 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1345 of 1345 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.28%25-green.svg)


I think your solution is better anyways: while mine creates two unnecessary temporary arrays (one as a result of `group_by`, and one as a result of `map`), yours just create one resulting hash.


Ändrat design. /Sebastian


**.mp3    diff=astextplain


interesting hacking stuff going on


why did you remove the accents? can't we deal with unicode?


You could use the following to support both versions:

    local timer = (type(timer) == 'table' and timer or require("gears.timer"))


`PKGDES` => `PKGDEP`


No. You need boost libs with fPIC compiled. Should not cause any trouble.


It was an alias for QtCreator installs downloaded from http://qt.io . Why has it been deleted?


It does look similar. I did contemplate using it or extracting it to a factory method on `SmartAnswer::NodePresenter`, but I wanted to keep the change as small as possible for now. I will consider that refactoring in another branch that I'm working on.


第一


```
path = begin
  URI.parse(@repo_url).path
resuce
  @repo_url[/^.+@?[\w\d\.-]+:(.*)$/,1] ||
end
path.sub!(/\.git\Z/, '')
path.gsub!(/\W/, '_')
```

but make it as helper method in cached_repository.rb


Done in 6dbf90e40641f361c3fba25a43ad6e6646655bac.


You could use a wrapper function, and do what you're doing currently there, if `delayed_call` does not exist yet.

Apart from that, the README says that `master` is meant to work with awesome's `master`, so it could be also used as-is here.  But I'd still suggest supporting both versions in the same codebase, if it is possible.


If I have both an A record mapping for the naked domain as well as for the 'www' subdomain (using a CNAME record), then github complains each time the site is rebuilt. Not sure what the correct way to do this is.


Well, I don't agree :-)

CFLAGS="-march=core2 -O2 -pipe -fPIC"  for boost is compiling.
CFLAGS="-march=core2 -O2 -pipe" for boost is not compiling.

reproducable for 100% percent.


This method should be moved to the end of the file


Thanks, I forgot to commit this!


You are right, my fault


This is redundant now.


You don't change calendar in this test, so there's essentially the only way to hit both switch cases: run test twice under different locales. Please mock `+[GLDateUtils Calendar]` and add at least two test cases, one for US case, one for other.


And I think you still need to check if `f` is not None.


Great, merged :shipit:


I don't see any difference with previous test (file_have_no_new_debt_ratio_if_scm_dates_are_all_before_snapshot_dates)


can `f` ever be `None`? This would be an error. Perhaps `if f: f.close()`


#This commit made me feel like a Happy Cat.


@damianog , thanks for the help. I'm now working on the signatures for all angular filters and will commit something soon.

Only problem is with the generic ```$filter(name)```. If I let it default to a generic ```IFilterFunc``` then type safety is lost. I would rather define it as ```<T>(name: string>: T```. This means one has to create interfaces for custom filters, like this:

```typescript
interface MyCustomFilter {
    (val: string, something: boolean): number;
}
$filter<MyCustomFilter>('myfilter')("test", true);
```


Seems similar to unit_test_files_have_no_new_debt_ratio()


Of all the libraries, this one we definitely want to be getting over HTTPS (although the checksum should still provide security even if we did have to switch to FTP).


# This commit made me feel like a Happy Cat.


@corristo mmm, make sense!


always use std namespace, otherwise the resolution can be ambiguous.


Missing tests on computation on module and directory


this is not needed in this context, isn't it?


@YannRobert handshake includes a TCP connection — that's one way of looking at it. In practice I guess the least confusing way to go about it would be to use the same value for both. But I can see how some may want to use a high TCP connection timeout and a relatively low handshake timeout.


# This commit made me feel like a Happy Cat.
![Image of Yaktocat](https://octodex.github.com/images/yaktocat.png)


This line is never reached by test, seems like a unit test is missing when there's no variation for a given period


Hello, warning
``code
/root/ovh.d/dr/src/server/scripts/Custom/ArenaSpectator/arena_spectator.cpp: In member function ‘virtual bool npc_arena_spectator::OnGossipSelectCode(Player*, Creature*, uint32, uint32, const char*)’:
/root/ovh.d/dr/src/server/scripts/Custom/ArenaSpectator/arena_spectator.cpp:616:27: warning: NULL used in arithmetic [-Wpointer-arith]
      if (playerName[i] == NULL)
``


Thanks Leon for letting us know and for keeping this project up to date!


Really? You added the "+" too?
Well, that's not going to work... ;-)


No test reach this line.


No test reach this line


# This commit made me feel like a Happy Dog.
![Image of Yaktocat](https://octodex.github.com/images/yaktocat.png)


This overload of `singleShot` was added in Qt 5.4. I think we should keep compatibility with Qt 5.3 for now.


Great, merged :shipit:


Nah, I am joking. English is my main language.


Not sure how this function is going to be used, but both values 1 and -1 evaluates to true:
```c++
if (checkGhostNode(42))
    // do something special to ghost node.
```


Thank you @michaelklishin


Thanks very much for adding this splitter. I appreciate your effort


Your second proposal seems good to me.


Typo in the error message.


I'll have a look into it and get back to you once I've figured out the best way of doing this.


lgtm, merged


Good catch ! I will add a method using the dbSession.


I know... but thought we don't stick with the 5.3 any more.
No problem, I'll change it ... but let's first check if this fixes the deadlock/timeout.


Indeed, it's a common pattern for startup task in SQ


Yep, no problem.


I remove profit_center/assigning directory because it is not used, it was a a copy of cost_center/assigning


:cool: merged


I mean this for Debian Stable. @agaida what do you think?


Usage and/or prototype for `plot` method:

```r
data(pineneedles)
fit<-fit_litter(time=pineneedles$Year,mass.remaining=pineneedles$Mass.remaining,
                model='neg.exp',iters=1000)

boot1 <- bootstrap.parameters(fit,nboot = 5000)

dens <- density(boot1[,1],bw = 0.005)
plot(dens, main="Bootstrap distribution of k")

# stolen from stackoverflow
#http://stackoverflow.com/questions/3494593/shading-a-kernel-density-plot-between-two-points
qfs <- quantile(boot1[,1], probs=c(0.025,0.975))
x1 <- min(which(dens$x >= qfs[1]))
x2 <- max(which(dens$x <  qfs[2]))
with(dens, polygon(x=c(x[c(x1,x1:x2,x2)]), y= c(0, y[x1:x2], 0), col="gray"))
abline(v=mean(boot1[,1]), col="red", lty=2)

```
![rplot01](https://cloud.githubusercontent.com/assets/1643942/10016927/b815194c-612a-11e5-89ae-758b8775f79a.png)


Is this supposed to be included in this commit?  Seems unrelated to the PR.


Yes - it was intentional. Don't worry I'll clean this up :smiley:


:yum:


now looks better, merged


Hm... do you believe that lxqt will ever be backported to current stable == jessie?


Detta är inte dyslexi firendly det är fan #2


Merged, It will be 3.1.0 version (that would be released soonish).


I can't relate the change to the message.


ops, thanks for reporting. Will fix.


I've just checked Gradle's source:

* `DefaultIvyPublication::getDescriptor()` won't return `null`, and
* `DefaultIvyModuleDescriptorSpec::getExtraInfo()` won't return `null`.

So I'll leave it as it is.


DuracanGyne


I noticed that sometimes (not on the small integration tests) the tasks has not enough time to wait for the Importer correct respone (especially if GeoServer is running on a machine without resources).
I can also put this on a separate issue if you think it is a good idea.


Certainly, if you'd like.


Amended the commit log and merged it.


You want to return from window_ride_construction_construct after a successful placement if network mode is client - otherwise it executes all the code that you put in the callback twice. This might be causing your issues.


Maybe, should we? I'll change that =D


Suggestion---FillGaps-ComponentMatrix-in-docs (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1881 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi,
I think your suggestion is better choose. I will update the codes. Thanks


Yes, I checked the DAG in the Spark UI and it does remove a shuffle stage.

Before:
![distinct](https://cloud.githubusercontent.com/assets/85085/10017069/7c1985f6-6123-11e5-9503-4771976ce4e2.png)

After:
![aggbykey](https://cloud.githubusercontent.com/assets/85085/10017081/866e958c-6123-11e5-9ab8-791fa3afe5a1.png)


test


hello


Damn. I have worked on this but forgot to mark in progress :(


Сделать заголовок h2


I think, this should be replaced with an anonymous function


由于buffer是从bufferpool中取的，会残留之前的数据，因此这两个字节就会不为0，mysql客户端和mysl-jdbc驱动是没有问题的，但是有些客户端（js客户端）会强制校验这两位，报错。


Names are now `a`, `b`, `int`, `int1`, which looks uneven


What is this api supposed to do? is this generic user search  or only searching currently logged in user? You are not passing any search term to the API. Why are you passing the gcm registration id "API_registration_key" to this API?


I've commented in the jira issue. Thanks


Reverted in 43fba1d1ebc0d8fe3d44c051bba26aa33ebec59e


![screen shot 2015-09-22 at 9 17 19 pm](https://cloud.githubusercontent.com/assets/693487/10017144/64999c62-616f-11e5-8d4b-ca527ffc1172.png)


Merged :smile:


The previous code (```endswith('16')```) could deal with unsigned 16 by calling cv_bridge. By not converting to ```mono16```, I just don't know how ```astype``` casts to ```uint8```: does it truncate ? does it saturate ? If you have a Python reference for it, I'd be happy to see it (and have it added to the commit).


Definitely put it in a separate PR. As for adding it: I've no objections if it's opt-in for the rest of us.


Other rubocop changes from #20 came (back) in


It looks like it should be possible by creating both:

+ `A` record to `192.30.252.153` & `192.30.252.153` ([source](https://help.github.com/articles/tips-for-configuring-an-a-record-with-your-dns-provider/))
+  `CNAME` record from `www.openab.org` to `openab.github.io` ([source](https://help.github.com/articles/tips-for-configuring-a-cname-record-with-your-dns-provider/#configuring-a-custom-subdomain-with-your-dns-provider))

The content of the [`CNAME`](https://github.com/OpenAB/openab.github.io/blob/master/CNAME) file will then determine which domain will be used and which will be redirected from.
i.e. if `CNAME` contains `www.openab.org` then `openab.org` will automatically redirect to `www.openab.org` (the canonical domain).

**Source**: [Configuring a `www` subdomain](https://help.github.com/articles/tips-for-configuring-a-cname-record-with-your-dns-provider/#configuring-a-www-subdomain)


As you've already set the same font family on the body you don't need to set it on the child elements unless it differs


Suggestion---FillGaps-ComponentMatrix-in-docs (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Broke pam_u2f: http://hydra.nixos.org/build/26131582


Indeed it should. I'll make an issue on it.


Well yeah the Filters system might be a bit overkill, although it has some nice features (lazy evaluation, automatic memoization). That said that part might not be necessary just to generalize things like the script chain etc.

Generalizing Filters would mainly be useful to make things like a script which converts audio to video, or some other combination.

Also I think most people would understand if you started calling AudioScripts and RenderScripts, "Audio RenderScripts" and "Video RenderScripts". That would also be a good excuse to move them to their own category in the settings dialog, at the moment their locations seem a bit 'random'.


RIght, gotcha


Make sure that the many newlines do not conflict with our checkstyle agreements.


@naghizadeh update your code, its working


It is, indeed.  I wouldn't try to force a formatter on anyone.  I've pulled
it and will add a separate PR in a mo.

On 22 September 2015 at 12:19, Steve Marshall <notifications@github.com>
wrote:

> Definitely put it in a separate PR. As for adding it: I've no objections
> if it's opt-in for the rest of us.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ministryofjustice/prison-visits/commit/d71f769c416155b23eec9b15c3c49ba3f344b492#commitcomment-13364453>
> .
>


You're right. It doesn't have KF5 anyway. Keep it.


Did you mean to add this file?


Yep, since you updated the version that works, but seems that they don't keep the old versions available there via https.

Anyway, I closed this PR. I didn't expect that you also have a develop branch since you make tagged releases :)


Broke pysvn: http://hydra.nixos.org/build/26068738


oh, not sure... i just thought it was intentional for some reason,

![screen shot 2015-09-22 at 7 22 12 am](https://cloud.githubusercontent.com/assets/370259/10017245/b930aff6-60fa-11e5-9192-139949149941.png)


now it doesn't fail.  Merged


You are doing two double nested function calls  in the same line!! Please don't do it like this.
HeldService.getService().searchUser(PreferenceHelper.getInstance(getCurrActivity()).readPreference(getString(R.string.API_session_token)),   PreferenceHelper.getInstance(getCurrActivity()).readPreference(getString(R.string.API_registration_key)), new Callback<SearchUserResponse>() {....

Take the preference helper in a separate variable.

PreferenceHelper myhelper = PreferenceHelper.getInstance(getCurrActivity()) and then use it in your calls

HeldService.getService().searchUser( myhelper.readPreference(getString(R.string.API_session_token)),   myhelper.readPreference(getString(R.string.API_registration_key)), new Callback<SearchUserResponse>() {....

If the preference helper is being used frequently then just make it a class variable and initialize it once in the onCreate.


If you want to merge change from forks, just do like this:
First click the compare button on the top left corner (The green button)![2015-09-22 19 17 49](https://cloud.githubusercontent.com/assets/9316590/10017172/d3323e88-615e-11e5-8f09-76c81e9a82a4.png)
Then select the base branch you want to merge to and the head branch you want to merge from,and if you want to merge cross forks, you have to select compare across forks after changing base branch or head branch.![2015-09-22 19 18 44](https://cloud.githubusercontent.com/assets/9316590/10017173/d3364988-615e-11e5-9492-18b28f427de1.png)
AND I'm not a Her, I just uses a girl in my favorite comic as the avatar.


Right. This is what I meant: You **NEED** fPIC for boost.
But **ADDING** fPIC to boost will not cause any trouble.


why are these methods removed?


True.


Add database with dummy test in MainActivity


I've created an issue on it: https://github.com/DBCDK/dbc-node-openagency-client/issues/1


Or do you mean that `final_cause` got changed underneath and therefore multiple clauses would be true?


Did you mean `</a>` at the end of this line rather than `</path>`? (We never open a `<path>`, and you're missing a `</a>` so I'm guessing that's what you meant)


cannot there be another check in the rule that from ".java" creates JavaSourceFileModel?


Do you know how to set as default to only boost cpu 1, instead of beeing all 4?from what I see on the code it gives a general value to all cores.  Thanks!


:+1: merged


It's shard.yml :wink:


**General**
- Good commit message body. Though perhaps you could have listed the items with hyphens.


Thanks


Here 'tis.

First, I tried putting letter_opener in the dev group without restating `:group => dev` but I put that bit back in after it didn't work.

Second,  I created the task "pick_winner" by watching a Railscast about scheduling tasks! That's why it is currently named that odd thing.

Third, I wonder if the versions of Launchy and Letter Opener are the issue. Launchy was installed when I did `bundle install` on letter_opener.

Good morning, @Brit200313


Chicken?


@damianog , @vvakame , can you guys have a look on this fix https://github.com/borisyankov/DefinitelyTyped/pull/5948 ?


tell me which part throws an error ?


this version contain Movies Table only , will add most-pop,fav and vote.desc later


Please see comment above


Cool! I'll be happy to take a look later today.

Good morning as well, @snugthejoiner


Yeah, locally my tests are failing without it.


you've removed quite a few methods here. Are you sure they were not used anywhere?


I am glad you don't see it immediately, because I was somewhat embarassed myself :D

In the old version, assume final_cause to be 'canceled' - that triggers the second 'if'.  But then the last  if/else is still tested, and goes to else, which sets, `FAILED`.  The first two if's should not fall through, those should be if/elif/elif/else all the way, so that the 'else' only applies if final_cause is unset or unknown.


один перенос строки сделай


Why have we removed these methods? they seem to be related to paging. Have you tested that paging is currently supported?


этот файл не нужен


I nästa version:

![nx-nby_w_66yzeh88m090dc3u2rwqhrlpr4_tc3djmy](https://cloud.githubusercontent.com/assets/3618525/10017407/4f0f8938-612e-11e5-9d2d-41585e23c2fc.png)


много пробелов после =>
выровняй до минимума


Ah wait, the diff doesnt show all the context. I see now!


Hi Pat

Thanks for that I was not sure and I will make the changes on the file now.


не хватает отступа


teams.show
go to (entity) then (function) then (create team) it will through NotFoundHttpException
the team will be created how ever it through exception ; so teams.store toke place but not teams.show
I think the problem is that it doesn't pass the objects


конкатенация с мини не нужна


QA+1 this is serving beacons correctly and stores ok on local storage


Sorry, do you think I should revert this?


тут новый метод из абстрактного надо заюзать


looks better :)


тоже левый файл


No I don't, that's why I said "the next time"


good catch. I really wanted to put there this condition, just somehow forgot


The broker router currently manage several topics.
MetadataResponse metadata is for one! or more topic.

i need to chack what the MetadataResponse is returning in this case:
topic A has Broker 1 and Broker 2
topic B has Broker 1 Broker 3

you right it messing remove but it may need more complex condition.

look on https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-MetadataResponse


This commit is a bit opinionated. I guess a simple flat file structure fits better in a module with multiple entry points.

I’ll rebase it out if you want though @KenPowers.


nice, merged


Has this been merged into pandas master or develop?


sure go ahead and find something better. much appreciated.


About the authentication, please make it support more methods because poly1305 is not included in current stable botan library. Therefore I highly suggest we use [HMAC](https://en.wikipedia.org/wiki/Hash-based_message_authentication_code) (more specifically, HMAC-SHA1) as the default auth. It has been used within IPSec and TLS as stated in wikipedia, which should prove its security strength.

Again, I don't see the necessity to add CRC check for payload. If you do believe there may be such a need to check the request, please make CRC and auth independently optional.


You're going to upset pep8 by deleting the extra blank here


**Functionality - Nitpick**
Good that you are using `namespaces` this time. Just make sure that you give them meaningful names. For instance, it's a common practice that you start with `<vendor>\<sub-namespace-if-any>\...` The vendor here ideally could be `Burayani`, etc.


@xatzipe why exposing Resource to global?


https://github.com/w3c/webappsec/commit/e1a3289011f6303d45f72d93f79dfb7812ce6472 ?


**Comments - Awesome**
Good attempts at docBlocks.


That's a nice way to ensure there's no typo in `__all__` class names.


- This fixes #95
- Once this fix is deployed, all S2AB bucket queries must be revised! (find details in #95)


how can be the source file already there? Didn't we just decompile it there?


`ifr.element.style.width` already set before `fixIosResponsiveIframeBug` is called


Sorry for the double posting, feel free to discard this commit


Suggestion---FillGaps-ComponentMatrix-in-docs (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (807 of 807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.54%25-green.svg)


Имя вендора менял, чтобы подключить свою версию в зависимости. Переключаюсь на ваш репозиторий :)


typo


I am very sorry!  Thank you for all your help.


Thank you


This commit is being reviewed as a part of review issue #97.


**Test Coverage - Awesome**
It's good your tests covered up to the data structure of the _dictionary_.


**README - Nitpick**
Correction punctuation could be `Composer, get it here.`, etc.


Added.


removed.


Why?


Shouldn't it be `quotes` instead fo `jsx-quotes` in `.eslintrc` ?
I got an ESlint error with your file.
I use: `"quotes": [2, "single"]`


what is meant with server commands?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21034/testReport/) for this commit**


Fixed in https://github.com/AurelienLourot/build-info/commit/348c3b45d2081559251e748c04effb140af41c00


@tsg Perhaps we have to implement a switch here in python for the different environments?


No compile
``
Linking CXX static library libscripts.a
[ 99%] Built target scripts
[ 99%] Built target worldPCH.cpp_dephelp
[ 99%] Built target generate_worldPCH.cpp
Linking CXX executable worldserver
../scripts/libscripts.a(arena_spectator.cpp.o): In function `arena_spectator_commands::andleSpectateResetCommand(ChatHandler*, char const*)':
arena_spectator.cpp:(.text._ZN24arena_spectator_commands26HandleSpectateResetCommandEP1ChatHandlerPKc[_ZN24arena_spectator_commands26HandleSpectateResetCommandEP11ChatHandlerKc]+0x28e): undefined reference to `SpectatorAddonMsg::SpectatorAddonMsg()'
arena_spectator.cpp:(.text._ZN24arena_spectator_commands26HandleSpectateResetCommandEP1ChatHandlerPKc[_ZN24arena_spectator_commands26HandleSpectateResetCommandEP11ChatHandlerKc]+0x429): undefined reference to `SpectatorAddonMsg::SendPacket(ObjectGuid)'
collect2: error: ld returned 1 exit status
src/server/worldserver/CMakeFiles/worldserver.dir/build.make:205: recipe for target 'sr/server/worldserver/worldserver' failed
make[2]: *** [src/server/worldserver/worldserver] Error 1
CMakeFiles/Makefile2:1350: recipe for target 'src/server/worldserver/CMakeFiles/worldsever.dir/all' failed
make[1]: *** [src/server/worldserver/CMakeFiles/worldserver.dir/all] Error 2
Makefile:117: recipe for target 'all' failed
make: *** [all] Error 2
root@ns371447:~/ovh.d/dr/build#
``


Remove this comment as well


Fixed in https://github.com/AurelienLourot/build-info/commit/7c1b295505244c27fa2fc4b3d7659e2b362ae31a


So the request chuck contains only one hash value instead of one hash value for every 128 bit data?

I'm okay with the methodology but not with the hash function. BLAKE2b is way too new for lots of security libraries. Please consider a more stable and mature function.


n é public class MateriaDAO implements DAO<Materia> {    ?


It looks like a bug: insertAt 0 instead of i; (and would be better to move the detection of "insertAt" into a upper level of code, instead of detecting it in each class with a vector).


how about in semester_view

```
courses = semester.course_set.exclude(state='new')
courses = prefetch_data(courses)
```
?


Yeah, this should be removed.  From the docs, (http://celery.readthedocs.org/en/latest/reference/celery.app.task.html#celery.app.task.Task.apply_async) it doesn't seem like that kwarg would resolve your problem.


And I guess let me know if the way this would be handled would be a rake
task and a crontab or if there's likely some gem etc that could handle
sending scheduled emails. I need to do a lot of work at the day job today
On Sep 22, 2015 7:29 AM, "Brittany Martin" <notifications@github.com> wrote:

> Cool! I'll be happy to take a look later today.
>
> Good morning as well, @snugthejoiner <https://github.com/snugthejoiner>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/snugthejoiner/theusthread/commit/e00aac57f46e42d1cf3aa1d5586dbe9abd05072d#commitcomment-13364638>
> .
>


will have his subscription active


hiii


By construction you know that such case would never happen. Why then adding it?
Moreover, I'm not a big fan of using a switch to do that.

why not simply:

```
if (tree.is(Tree.Kind.IDENTIFIER)) {
  check((IdentifierTree) tree);
} else {
  check((ClassTree) tree);
}
```


Use map and reduce for more declarative syntax. [Reference](http://danmartensen.svbtle.com/javascripts-map-reduce-and-filter)


Please open a task item on http://foswiki.org/Tasks/WebHome describing in more detail how to reproduce the error and what this is a fix for. Thanks.


see https://github.com/ufz/ogs/pull/580/files in PR #580, which assign a sign of negative or positive to the global index.


I have used the guava method twice because of performance concerns.
We don't do that on SQ, but I wonder if making a facade with all the methods we use is useful, like we did for logging. Shouldn't we strive to be libraries independent ?
Then, we could look in our own classes to see what's available. I know the idea has its limits.
Using apache-commons or guava would be transparent from the rest of the application.


Follow a common style convention. Spaces on both sides of '=' and ':' and things like that. Recommend you use [this](https://github.com/Flet/semistandard). It'll take care of all javascript style and syntax.


I used firstNonNull from Guava twice


Same comment as before. I would simply do:

```
if (!tree.is(Tree.Kind.IDENTIFIER))  {
  shouldCheck.removeFirst();
  issues.removeFirst();
}
```


Sure thing, right after I change the macro name.


It has been defined in samsung qcom-common


Parameters may not have a schema!


バステアイコン画像の作成 #91


what is iqr? use more descriptive names. If its a common terminology describe in comments.


`>=`

I'm pretty sure we want to allow managers to add a new registration even when the limit has been reached.


well spotted


Thanks !


That would be the whenever gem => https://github.com/javan/whenever

I also need to hustle at the day job so I'll talk to you later!


`jsx-quotes` is a new rule in es-lint: http://eslint.org/docs/rules/jsx-quotes


Use functions to achieve these things to make the code more [declarative](http://latentflip.com/imperative-vs-declarative/). And more descriptive names. This can be refactored as
firstHalfArr = getFirstHalfOfArray(values)
fullArr = values
lastHalfArr = getLastHalfOfArray(values)


Avoid imperative code


これくらいだったらいいよ、むしろ車輪の再発明感。


これクラスメソッドにするかなー


Why toString? GetName is usually easier to read and use.


Remove windows-only backslash.


特にやる必要ない


I was thinking that we maybe should release this 5th RC as 0.9.0.
The goal for 0.9.0 was to be a fully working port of the original internal projects, and I feel it is.

So my suggestion is that we release 0.9.0 now based on the 0.9.0-RC5-tag.

I am working in the akka_2.4 branch to make ut compatible with akka 2.4 (there is breaking changes in akka, but not in the akka-tools api).

I'm also working on akka-tools-camel which should maybe included in 0.9.1.

What do you think?


get -> gets


この辺もわざわざやる必要ない


RSET LGTM


Det är denna som är texten där uppe som du ville fixa. Den andra nedanför är ju den blåa texten mitt i din bubble.
Och för att ändra den så skriver vi i css filen under .menu ul li  background:red;


Use [map](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/map) here instead


Lägg till: background:red;


Glöm inte semikolon ";" efter denna raden


Use [map](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/map) here


いいでしょう、ただ複数モデルで全く同じメソッドなので共通化したら3倍うれしいｗというのを別のモジュールかませたりして作ったりもする。


TeamCity Colore :: Main Build [Build 98](http://tc.sharpblade.net/viewLog.html?buildId=633&buildTypeId=colore_mainbuild) is now running


Too much duplicate code. kv.EncodeKey(encodeInt(1))


Can I know why this is needed?

I have to disable it for the project I using swift-sodium too, in order to build.


scope　のほうがよかった


@flavour Does this look okey? Created the subclass of S3AddResourceLink?


@flavour Since FTP repository belongs to a particular user? So updated to accommodate the realm_entity?


@flavour How can I be able to show only the ftp repo belonging to that user, in the dropdown of Multiselectwidget? the ftp_rows  https://github.com/biplovbhandari/eden/commit/de5aaed1f422dded708d50f846ec1fe0869a21e4#diff-8b02f3a5c97483e605769a048020941cR396 contains the id and the name of the repo? The __call__ method here https://github.com/flavour/eden/blob/master/modules/s3/s3widgets.py#L6645 accepts the field but not sure, how to extract those field. Any pointer?


@flavour this is the default for the form when it is loaded first time. It is used here https://github.com/flavour/eden/blob/master/modules/s3/s3widgets.py#L6645 option value, that is the currently selected value. If I put None (as of now) it shows a extra dropdown with no label, which is wrong. If there is no value of repo_id, it should not show any dropdown? I am not sure. Did you get what I mean? What do you think will be the good solution here?


TeamCity Colore :: Main Build [Build 98](http://tc.sharpblade.net/viewLog.html?buildId=633&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:1:52


Почему стек у тебя не generic?


Hmm. In what way do you want to customize the default exception mappers and why?


@ghorn this explains why you saw a speedup with parallel jit even though we don't implement it:
jit was not actually being run


I wish I had made this change 6 hours ago before submitting a release to AMO.  If it gets accepted, an update will be put in the beta channel there.


Thanks for that refactoring, it's much better:  75e450e


numerais de Church


"numerais de Church"

fonte: https://pt.wikipedia.org/wiki/Codificação_de_Church

http://DavidDeharbe.github.io

2015-09-21 20:42 GMT-03:00 Diego de Azevedo Oliveira <
notifications@github.com>:

> Adicionado um termo para o dicionário (necessita tradução)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DavidDeharbe/sf-pt_br/commit/5cbb2392db57e3f7f20d2b4774ec48c90dfdefb5#commitcomment-13355977>
> .
>


Hey zaclimon, just a question. I'm using your touchboost.c and touchboost.h up-to-date files, but I'm getting this warning using a gcc5 compiler: "drivers/input/touchscreen/touchboost.c:38:9: warning: 'last_input_time' is static but used in inline function 'get_input_time' which is not static"

The thing here is that I'm using extern inline, so I'm not sure why the warning is still appearing. Any idea?


Мы задали размер стека? Весьма неожиданно однако)