New name: PitchFilter
Rename "energy" -> "pitchConfidence"
Rename "wrapNegativeEnergy" --> "use absolute pitch confidence"

Update documentation:

This algorithm corrects the fundamental frequency estimations for a sequence of frames given pitch values together with their confidence values (e.g., by removing non-confident parts and spurious jumps in pitch, and applying octave corrections). They can be computed with the PitchYinFFT, PitchYin, or PredominantPitchMelodia algorithms. The algorithm can be used for any type of monophonic and heterophonic music.

The original algorithm [1] was proposed to be used for Makam music and employs signal "energy" of frames instead of pitch confidence.

If you use PredominantPitchMelodia with guessUnvoiced=True, use wrapNegativeEnergy=True flag.


remove const from ret val (didn't I say that already?)


`RHManageRegformBase` and it should have a `_checkParams` that sets `self.regform` (pretty much exactly what we do in `RHManageSurveyBase`)


Hi friend, thanks so much for your time on this! I have only glanced through what you have done so far, but here are a few things I would like to point out:

* Personally, I'm not fond of the places where I see `this.Contact = ...`. It feels less than idiomatic to assign a constructor as a member of an instance. Perhaps we could avoid this.
* Subclassing `Contact` seems to be the right way to go to keep things DRY
* Right now the `Transport._send` method takes a port, address. Maybe it would be better to pass it a contact instead and let the transport handle checking if it's the right type of contact.
* Another option is to leave Contact with IP and port and use the PeerJS server for those values and simply overload the method that assigns the nodeID.

All in all, I like what you are doing and I think that this functionality would be incredibly valuable to the project. You don't need my blessing to march forward, but you certainly have it. Once you have the transport working we can circle back and tackle any of the details together if you like.

Why don't you open a PR and preface the title with "WIP" so others can contribute to the conversation and we can tighten the feedback loop?

Again, thanks for your time and effort on this!
@changetip send @omphalos a beer!


Yes, those should be purged. This is strange as I did git reset --hard on
submodules today. Later I did upload another package and those 2 were
uploaded along with it.

2015-09-02 15:58 GMT+02:00 mfonville <notifications@github.com>:

> @NicholasBuse <https://github.com/NicholasBuse> yes, they should be
> purged. If you could handle this Nick, that would be nice.
> Cause could probably be that the commits were still somehow in the (a?)
> local git repository and not pushed at an earlier moment?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opengapps/arm/commit/10b809a96936389c4cafea5644bd4dba7daf8186#commitcomment-13023798>
> .
>


I messed up the commit message: should be added WebSockets as suggested by @draggett and agreed in the TF-AP call


Hi @omphalos, @gordonwritescode sent you a Bitcoin tip worth a beer (14,932 bits/$3.50), and I'm here to deliver it ➔ **[collect your tip](https://www.changetip.com/collect/890896)**.

**[Learn more about ChangeTip](https://www.changetip.com/tip-online/github)**


I'm not entirely sure you want to use `gsub!` on this line.


the comment has a copy/paste error, this isn't KDSoapMessage here


alv が 1 -> 0 に変わった場合に、現象


why remove space here


Is valueMsg necessary? Why not work on message itself directly?


thath TODO seems outdated


Grant is Classy fellow.


Rename all occurrences of "energy" with "confidence"


In the past, at least one person modified PumpTweet to work with GNU Social.  I haven't heard from them on that issue in quite some time, but it's possible this merge could break their link shortening.  If that comes up, I'll take another look.

It is quite possible to use Twitter for link shortening when posting to Twitter and ShortURL for link shortening with GNU Social.  But it would clutter up the code, so let's wait and see whether anyone requests it.


Did you commit this on accident?

Also, this seems to blow up Travis FWIW.


I think this is a rare use case, but it does not seem like this is handled.

```
Alternatively, a string of up to 8 characters (from c(1:9, "A":"F")) may be given, giving the length of line segments which are alternatively drawn and skipped. See section ‘Line Type Specification’.
```


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (760 of 760 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.47%25-green.svg)


It was already strange, if it's strange after all. I suppose the important point is that when setting a new `base.href`, that URL shouldn't be resolved against the old `base.href` if there was one, or any other. If so the text is accurate, it's actually not just *other* base elements. Please merge if you see no problem here.


I still think that there's a huge overlap in the meaning of the two variables, so you're basically just duplicating information here. But whatever, doing it your overly-verbose way works too.


from the msg log: "KDSoapClient is now have" ... that's not proper English ;)


change it to `\cs{break}, \cs{linebreak} or \cs{newline} etc.` and I’m happy with the text.

But it made me think of the content again. `\linebreak` is used to suggest TeX where a line should end, which sometimes must be done to optimizes the typesetting result. Now I read p. 147 and see why we can't use it, so I’d add a note referring to this section. The full paragraph should then be

```latex
% Note that you \emph{can not} use paragraphs (e.g. blank lines or
% \cs{par}) or line break (\cs{break) inside of notes, when they are
% set to \texttt{paragraph} arrangement!\footnote{See \reff{nobreak} for
% further information.}
```
 And then that’s it … I hope :-)


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.948.6b53af2040795781ae0301e43eebbbe0c18bdf45](http://build.palaso.org/viewLog.html?buildId=62536&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:02:40


i think it would be better to use id of the token as the key, instead of the full string?


"List all registration forms for an event"


no alphabetic sort for these?


Vachement original ! XD


no, but nobody cares in previous review ^^


@karschsp @stevekarsch hey man i merged your changes in. That way the root user isn't the one installing drupal with drush. Thanks. This is getting some traction...  cool!


    regforms = (self.event.registration_forms
                .filter_by(is_deleted=False)
                .order_by(db.func.lower(RegistrationForm.title))
                .all())


It could just be replaced by using DbfCard.SellPrice, no?


I have no clue what `(<?>)` is. Maybe add a note to the intro saying "assuming familiarity with parsec... refer to hackage if you don't understand the parsers... etc."


do you actually use the event inside regform_list.html? if not don't pass it here


thX~


ご指摘の通りです。修正します。


this has to stay `postgres`


Do we (still) need this class?


don't pass the event unless you need it (i.e. have a `__init__` where you pop it from kwargs)


Ok - This now passes the Python 3.2+ tests. However Python < 3.2 simply does not support
````
yield from xxx
````
and will therefore throw a syntax error. I have seen a few instances in cement where python version checking is performed but am not clear as to best apply it in this situation. Might be that the entire function in question needs to be separated into a standalone file - one for each version and imported into the rest depending on what version of python is running?


@ReneMoraales sentí que me faltaba un ejemplo de integración de lo que presentas. Después fui a ver el README de https://github.com/platanus/angular-push y me pareció muy claro. Quizás podrías poner un link  a https://github.com/platanus/angular-push#how-to-use como para que cierre todo el cuento.


Thank you revolunet! we also have the same issue here!!!


this is gonna cause a merge conflict since this got fixed by a previous issue


you can already use event_new here. both Event and Conference have suitable locators. but at some point in the future we need to check all places that use `self.event` so using `event_new` where possible is better.


The styles were not inlined in that particular case. From the readme `By overriding the #roadie_options method in the mailer you can` __disable__ `inlining in certain cases`


Ok:
https://github.com/linagora/james-jenkins/pull/5/files


`event_new` should work for the kwarg (the positional one needs the legacy one though)


`DataRequired()`


yeah thats why there is `unless` in example


event_id, title


Do we have to go through /bin/sh here? How about calling hoogle directly:

```
(start-process
               hoogle-server-process-name
               (get-buffer-create hoogle-server-buffer-name)
               "hoogle" "server" "-p" (number-to-string hoogle-port-number))
```

?


i'd also go for `regform` here


Test


and where do you write it ?

Le 2 sept. 2015 � 16:08, Tobias Weh <notifications@github.com> a �crit :

> change it to \cs{break}, \cs{linebreak} or \cs{newline} etc. and I�m happy with the text.
>
> But it made me think of the content again. \linebreak is used to suggest TeX where a line should end, which sometimes must be done to optimizes the typesetting result. Now I read p. 147 and see why we can't use it, so I�d add a note referring to this section. The full paragraph should then be
>
> % Note that you \emph{can not} use paragraphs (e.g. blank lines or
> % \cs{par}) or line break (\cs{break) inside of notes, when they are
> % set to \texttt{paragraph} arrangement!\footnote{See \reff{nobreak} for
> % further information.}
> And then that�s it � I hope :-)
>
> �
> Reply to this email directly or view it on GitHub.
>


commit msg: s/avahai-discover/avahi-discover


", none" is implicit


@karschsp @stevekarsch what is php70w-m$ i have never seen that before


I'd link to the coala bug, so that it can be tracked.


As mentioned in another reply, the code duplication here is *intentional* for performance reasons. This part of the code is executed millions to billions of times when iterating over an image domain, hence every saving counts. By duplicating this code here we avoid the creation of an Index3D object and a function call to IndexToPoint method zillions of times.


I'm sorry for that! I adjusted my .vimrc.


@kristophM Just had a thought - it may actually be that it does *not* need to be a valid CSS selector with `click_link` - I think it assumes its an id - I got that wrong, sorry about that - try without the `#` like you originally had it!

```
click_link "item-#{item.id}"
```


Youe mean where to put it in the manual? Id say l. 1546 and following.


no.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 485](https://teamcity.labkey.org/viewLog.html?buildId=269672&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:34
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Done


I mean, yes, that is a bug.


Dan, I didn't know you know what GitHub is?


LGTM.


Oh well, there's some 10-fold difference, but only on the order of 100 ms (vs 10 ms). Is this too insignificant? It does cater well to the argument that Unix is generally faster. :smile:


indeed


ok, I didn't understand. 5c7f273


Commited


need to add sudo -u stack otherwise will fail here


This is okay for me :-)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.557](http://teamcity.monogame.net/viewLog.html?buildId=9965&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:28:51


:+1: can we backport to 15.09?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.558](http://teamcity.monogame.net/viewLog.html?buildId=9969&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@jread-usgs - here's the code using the suggested packages RCurl and XML. I also added help text to make it a little bit clearer, and the related changes to the Description file are in a different commit within this PR.


merge https://github.com/Imgur/incus/pull/63 then? ^^


yea. cool story. eventlircd changes should herhaps be reverted now. too.


nit /openstack


I was googling this and some forums had mentioned it was fixed in the latest release:

![screenshot 2015-09-02 10 06 15](https://cloud.githubusercontent.com/assets/1210933/9633420/d389ae84-515a-11e5-91c4-2a7346ca2d0d.png)


Can you point me to the relevant part of the documentation? I can't find anything on that.

This program compiles:
```
class testme {
  public static void main(String[] args) {
    try {
      throw new RuntimeException();
    } catch (Exception e) {
      e = new Exception();
    }
  }
}
```
Whereas this one does not:
```
class testme {
  public static void main(String[] args) {
    try {
      throw new RuntimeException();
    } catch (final Exception e) {  /* final declaration added here */
      e = new Exception();  /* Error: final parameter e may not be assigned */
    }
  }
}
```


Thanks, it now compiles like a charm!


This is a test


Ещё вот в этих местах стоит использовать новые типы:
```
~/test/ALGORYTHMS/DYNAMIC/PIVOT$ grep -n 'vector.*size_t' *
autotest.cpp:11:void check_result (size_t pivot_to_cut, vector<size_t> test_result, dynamic_db pivot_obj)
autotest.cpp:14:    vector<size_t> result = pivot_obj.print_result();
autotest.cpp:28:    vector<size_t> result = pivot_obj.print_result();
autotest.cpp:58:    vector <size_t> prices = {0,1,5,8,9,10,17,17,20,24,30};
autotest.cpp:71:    vector<size_t> test_result1 = {1,6};
autotest.cpp:78:    vector<size_t> test_result2 = {2,2};
autotest.cpp:91://    vector<size_t> test_result2 = {2,2};
cut_method.h:16:            std::vector<size_t> plan;
cut_method.h:24:        dynamic_db(const std::vector<size_t>& price_tab) : price(price_tab) {}
cut_method.h:45:        std::vector<size_t> print_result() const
pivot_cut.cpp:10:    vector <size_t> prices = {0,3,5,8,7,9,14,26,18,20,24,25,26,27,28,29,30,31,32,33,34,35,36};
```


@danh-arm @achingupta

Dan, Achin did you get time to review this PR?

On Fri, Aug 28, 2015, 9:44 PM Varun Wadekar <varun.wadekar@gmail.com> wrote:

> Thanks Soby. Will wait for more comments from Dan or Achin before pushing
> a new PR.
>
> On Fri, Aug 28, 2015, 9:22 PM soby-mathew <notifications@github.com>
> wrote:
>
>> @vwadekar <https://github.com/vwadekar>
>> The code looks good to me. Probably Achin might take a look in the
>> following week.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/vwadekar/arm-trusted-firmware/commit/d6e77ed3f710930f579a8fccb27707c8017063f1#commitcomment-12950845>
>> .
>>
>


ah yeah good point


It's not so much about compilation but about covering all the known cases. If later we decide to add 'xyz' type, but it is no covered by this code, it should thrown an exception, not just be processed by the fall-through code. It's just safer programming to limit the options.


Qual a diferença?


nice. OK, so you just put those two packages in suggests, and do this thingy here. I see you skip any `importFrom` for those packages too. Thanks!


Typo: take -> takes


good improvement! more readable/updateable.


Cool


I found some references, not sure if it's this exact class though. Let me check a bit more.


#Git clone /vendor/pittpatt/models/recognition/face.face.y0-y0-22-b-N/full_model.bin


@lucaswerkmeister : This change might have broken the FindNodeVisitor for some cases ( see ceylon/ceylon-ide-eclipse#1455 ).

Could you explain more precisely the use cases in which the result might be different *after* this change ?


LOL


OK cool. I think those last two paragraphs could be written a bit more clearly though.


Keh


O.o


@hshiozawa what are you trying to do?


oh many thanks, right now i'm studing the code and the old wiki to made updates to the documentation..


Simpler to just make the last line
echo "$CONFIG_LOCALVERSION$LOCALVERSION"


I changed it to that, it's in the 20150902094252 migration. But I'm cleaning up the database soon, there's some outdated stuff.


yeah, turned out to be pretty easy.


Git clone /system/


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 58](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191400&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 58](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191400&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:02


`else if` -> `elseif`


In my opinion they should be also inlined in development env, because it's easier to make changes when you see them :). For tests it doesn't make any sense. In this configuration the tests will run a little bit faster


Git forge


In the case of
```ceylon
print(loop(1)((a) => a<10k then a*10 else finished));
//    |-- selection (inclusive)                 --|
```
there shouldn’t be any change, since there are no whitespace tokens next to the selection. However, I could me mistaken.

In the case of
```ceylon
print(   loop(1)((a) => a<10k then a*10 else finished)   );
//    |-- selection (inclusive)                       --|
```
the selected node would now still be the argument, whereas previously it would have been the argument *list*.


`true === $valid`


I wonder if `manyTill` is meant to be used infix?


It is nice when I have checked case using with a fresh build. Thanks for the efforts.


but right now you only enable that on tests :)
```ruby
super if Rails.env.test? => super unless Rails.env.test?


ok this little check are a nasty hack for now..

in the right way, what must i have to enable this on some ports, by example, for olders androits can be done? (i already know u have also a older androit device je je)


Reading through the code... very impressive!  Can't wait to give it a try.


Hi Konrad,

  I've got XiaoYi Sports Camera, not GoPro, but share the same Ambarella A7L chipset, and has the similar t command.
  I found "t ia2 -ae off" works with video same as "t ia2 -exp lock"
  But from the firmware log, t ia2 -exp set [mode][agc][shutter][iris][dgain] has no effect at all.
  e.g. t ia2 -exp set 0 192 1031 0 4192

  Hope you can figure out how to set these values

  or maybe should use: t cal -me [mode][agc][shutter][iris][dgain], -me: manual exposure ?

  Thanks in advanced !


What's the advantage of moving this here? This check will be executed for every addon (but for most it will fail because there are very few repositories compared to addons).


Yes, this is a quick solution, but not appropriate enough.  @ldoktor's solution seems sensible. I'll close this PR.


#4952-VRF-hard-crash-if-terminal-unit-list-error (rraustad) - x86_64-MacOS-10.9-clang: OK (1798 of 1799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Should file a pull request against these changes so master can be updated :)


true, it was useless.


@mfonville,
I did the two reverts, but should I rebase and reorder the mis-commits and the reverts down to the *.17 commits for squashing?


If this is a bug report please use a ticket or just create a pull request. Thanks.


Ah OK, so it should have been even better then before ;-)


Vote up for this, merge please, would be useful to not have keyboard open in a state when two panels are visible at the same time.


Why the additional conditions? The method name `GetRepository()` doesn't indicate that only repositories that have already been refreshed are returned.


yes, we should.


yes, that's what I was thinking off. One problem though: won't this return a Python dict now? Ie don't you need to call ``as_list`` somehow? If the tests don't catch that, they should be improved.


Are these in CF already? Otherwise they should go in cf-enhancements instead, since they wouldn't be overriding any values. Though better would be to open a PR in CF directly instead.


@palamago @danielpadula
Acá deberia ser `form = PreviewForm(request.GET)`.


haha - thanks a bunch Konrad ;)))

---

Best regards,

John E. Kroll

Architect MAA

Photographer IVRPA

V i r t u a l W o r k s . d k

I n t e r a c t i v e 360 T o u r s

Tel. +45 7021 4181

kroll@virtualworks.dk

www.virtualworks.dk

Lyngby
Denmark

On Wed, Sep 2, 2015 at 4:29 PM, luckylz2git <notifications@github.com>
wrote:

> Hi Konrad,
>
> I've got XiaoYi Sports Camera, not GoPro, but share the same Ambarella A7L
> chipset, and has the similar t command.
> I found "t ia2 -ae off" works with video same as "t ia2 -exp lock"
> But from the firmware log, t ia2 -exp set
> [mode][agc][shutter][iris][dgain] has no effect at all.
> e.g. t ia2 -exp set 0 192 1031 0 4192
>
> Hope you can figure out how to set these values
>
> or maybe should use: t cal -me [mode][agc][shutter][iris][dgain], -me:
> manual exposure ?
>
> Thanks in advanced !
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/KonradIT/autoexechack/commit/df0b946b1420aeacf5dbac78ad82f319abab945d#commitcomment-13024669>
> .
>


Should we remove this change? It does nothing


Are you working on Sheer Drop and Coastal Discovery also? I can get them otherwise.


We should mention this is required due to  mutableUsers = false


@javierpajaro El form parece requerir el parametro `visualization_revision_id` pero en el momento de create, cuando la visualizacion no existe, es cuando queremos hacer el preview. Por que?


We haven't hit this in prod in ages (we can double check with Splunk) should we also just remove this?


Fixed in ebaefc1.


Be sure to review as we bring this feature over. See [this old issue](https://github.com/jamoma/JamomaCore/issues/19).


what do you think if instead of checking response type it checks the for response instance identity.

I mean, create a Response object in test case scope, return it from `process_request()` and check it is the same response with `self.assertIs()` in this line.


Maybe it would be worth adding a painfully obvious comment here and on the other parsers:
```
-- | Consume comments (from a '#' character to the end of the line) and return nothing.
```
Depends who you're pitching this blog post for.


Gitter and ScudCloud icons are not works:

[Desktop Entry]
Name=Gitter
Comment=Where developers come to talk
Exec=/opt/Gitter/linux64/Gitter
Icon=/opt/Gitter/linux64/logo.png
Terminal=false
Type=Application
Categories=Utility;
X-Desktop-File-Install-Version=0.22

#!/usr/bin/env xdg-open
[Desktop Entry]
Version=1.0
Terminal=false
Type=Application
Categories=Network;Chat;
Name=ScudCloud
Comment=ScudCloud is an open-source client for Slack
Keywords=slack;chat;instant-messaging;collaboration;
Exec=/opt/scudcloud/scudcloud
Icon=/opt/scudcloud/resources/scudcloud.png


I really like this dedup patch :)


@micdijkstra no more templating in Stencil?


Oh, that's what you're talking about. Rethinking this made me realize that I forgot to clear the ROUTINE_USED flag in Free_Routine, a fix is coming.

The flag is at the end of the struct, so Free_Node will not overwrite it, BTW.


How is that getting the required configs separated by a comma? I think it should've been `cart_cfgs.split(',')`.


Do we rely on the repository updater job to display some kind of visual feedback or do we need to add something here (like the busy dialog)?


This commit broke the iterator functionality! Instead of iterating over the rows one after another (generator), it now loads THE ENTIRE database into memory. Will revert.


Enable what? I don't understand... the runner is another standalone port, it's not a "feature".


@micdijkstra stencil compiler  :+1:


No you can go for there implementation.
Thanks.


что записываешь\читаешь с карты?


Nah, given that !mutableUsers is not the default, the users who have it presumably know about it.


it looks good!


El form entonces no deberia requerirlo como obligatorio, o en el
PreviewForm directamente no estar incluido el atributo.

2015-09-02 11:32 GMT-03:00 Gastón Avila <notifications@github.com>:

> @javierpajaro <https://github.com/javierpajaro> El form parece requerir
> el parametro visualization_revision_id pero en el momento de create,
> cuando la visualizacion no existe, es cuando queremos hacer el preview. Por
> que?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/datal-org/datal/commit/ba109b5b7f7031d2e7a1007174748a38bfde2e79#commitcomment-13024784>
> .
>


hm, why not use the creation date directly instead of the PK-surrogate?


Not sure about merging this commit, because while it provides some logical improvements (no messy extra data left behind in the backing array buffer), it also will be slightly slower in the worker due to the need to instantiate a new typed array (though the old one will be put into the pool for reuse). And with transferable objects, there should be no additional cost to sending the larger array buffer to the main thread, because ownership is directly transferred rather than copying the contents of the buffer.

Going to keep it around and benchmark/think about it more.


you could make an argument either way, but you have to draw the line somewhere.  I'm not too attached to any specific rules though!  At my last company there were many arguments about it, but actually after we got all the code to similar strict requirements it was a lot easier.  However it's a shame it's so hard to apply standards to variable naming etc.


I'd just call it `whitespace` (no caps).


Remove this mtime too please.


add assert that check if package url is set properly


This has to do with #1


ok - i'd rather have lint-less builds.  Its not a big deal


This functions (addWarning, addAlert, addToList, deleteFromList) should be in a new controller (data for example because is used in the data view) and not here.


This was from an older commit. I was about to style that div using the class reference instead of writing it with my HTML.


I was reading (http://www.doctrine-project.org/2015/08/31/security_misconfiguration_vulnerability_in_various_doctrine_projects.html) that the mask is configurable by doctrine. This doesn`t look like it.


why is this `Task` returning as you are only reading from in-memory? Do you plan to have other implementations of `ISlidingConcurrentCache` which might store the stuff somewhere else that requires I\O to retrieve?


1: M111 unrecognized component name: travis


curl -Lo ~/bin/gerrit-cherry-pick http://review.example.com/tools/bin/gerrit-cherry-pick /system/build.prop


what I should have said is if you think it's worth the time the team discussing some rules feel free to raise a PR and open it up to the team.  however personally I'm not sure it's worth the hassle (from experience!)


修改git忽略文件


i'm reading now, but i refers how a user can build this port, due this are some quite new, to make some documentation.. i'm reading the site of lodepng but i'm not a developer i'm electricits je je je


I'd just phrase this as: "We have to remember to strip whitespace from the beginning of the file when we write the top-level parser." I don't think the example below is necessary.


Typo: chich -> which


Thank you. I'll try to be as consistent with the comments as possible.


This is temporary change until we merge https://github.com/NativeScript/node-xcode/pull/5.


develop (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


you have just imported header file


> Alternatively, it looks like there's a single routine that handles exceptions thrown by the user-defined functions

So are errors from user-defined functions are already handled? The error result is only supposed to stop a query, not return a value to the OCaml program so, if the current mechanism stops a query on an error, maybe we don't need to extend `Data.t`.

Although, if this is the case, I'm not sure why @mmottl accepted the push request. So I must be misunderstanding something.


But it has some bad bugs:
You've lost additional optional parameters for setInterval and setTimeout:
+TimeVirtualizer.prototype._setInterval = function(func, delayMS) {
+    return this._setIntervalOrTimeout(func, delayMS, true);
+};
+

From MDN: window.setInterval(func, delay[, param1, param2, ...]);
window.setTimeout(func, [delay, param1, param2, ...]);
setInterval shouldn't work if delay param is not provided.
--------------------------------------------

You provide
var timeout = new Timeout(
-        this._reals.setTimeout, this._clearTimeout,
+        realFunc, this._clearInterval,
-        false, delayMS, func, funcParams);
+        isPeriodic, delayMS, func, funcParams);
+

 this._clearInterval as "virtualizer kill me func" both for periodic and not periodic timer.


LG


The runner port is kind of special, it's made to do unit tests. It's not really meant for end users.


こちら文面修正致しました


This was also from an older commit. It was rectified in the commit after it.


I would put this after the bootstrap CSS so that it can override anything if it needs to.


When compiling the solodem application, I have :
```sh
Linking CXX executable feelpp_ms_3D_saddle
CMakeFiles/feelpp_ms_3D_saddle.dir/ferromagnetic.cpp.o: In function `~sp_counted_base':
/home/u2/huber/feelpp/feel/feeldiscr/operatorinterpolation.hpp:51: multiple definition of `Feel::operator<<(std::ostream&, Feel::interpolation_operand_type const&)'
CMakeFiles/feelpp_ms_3D_saddle.dir/magnetostatic.cpp.o:/home/u2/huber/feelpp/feel/feeldiscr/operatorinterpolation.hpp:51: first defined here
CMakeFiles/feelpp_ms_3D_saddle.dir/ferro_postpro.cpp.o: In function `~FunctorDomain':
/home/u2/huber/feelpp/feel/feelpoly/dubiner.hpp:788: multiple definition of `Feel::operator<<(std::ostream&, Feel::interpolation_operand_type const&)'
CMakeFiles/feelpp_ms_3D_saddle.dir/magnetostatic.cpp.o:/home/u2/huber/feelpp/feel/feeldiscr/operatorinterpolation.hpp:51: first defined here
CMakeFiles/feelpp_ms_3D_saddle.dir/ferro_utils.cpp.o: In function `~Projector':
/home/u2/huber/feelpp/feel/feeldiscr/operatorinterpolation.hpp:51: multiple definition of `Feel::operator<<(std::ostream&, Feel::interpolation_operand_type const&)'
CMakeFiles/feelpp_ms_3D_saddle.dir/magnetostatic.cpp.o:/home/u2/huber/feelpp/feel/feeldiscr/operatorinterpolation.hpp:51: first defined here
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```

If I comment this operator, I have no problem.
I have not found/investigated the reason.

/cc @cdaversin


If I do that, then it will add some additional styles (which I could only find in boostrap's `@media print` section) and they will override all of my styles. I'm not sure it should work this way.


Please don't move lines of code around if the reason for this is just stylistically.


Nice path Dimitri! I'll test it tomorrow


Would you mind adding the unit tests to the main VAST repo? We're currently trying to consolidate the code there, because the SWP15 Repo has quite diverged from the main development process. You can push them to `topic/http`, where I pushed [an adapted version of your HTTP request parser](https://github.com/mavam/vast/commit/24a36e5383c5b7d690c7aedb1e7825e669c99d97).

A small style nitpick: [only macros should be in CAPS](https://github.com/mavam/vast/blob/master/CONTRIBUTING.md).


Do you have the .desktop file names? I'll add them to the [hardcode-fixer](https://github.com/Foggalong/hardcode-fixer) :)


Oh…well…

That takes care of *that*, then!


When compiling CasADi from source from this branch, I can do the following:

    import casadi.tools as cat
    import casadi as ca

    ntauroot = 3
    nsteps = 10000
    nx = 2

    Vars = cat.struct_symMX([
            (
                cat.entry("X", repeat = [nsteps, ntauroot+1], \
                    shape = nx), \
            )
        ])

    a = ca.MX.sym("a", nx, ntauroot+1)
    b = ca.horzcat([sum([a[:, r] for r in range(ntauroot + 1)])])

    fcn = ca.MXFunction("fcn", [a], [b])

    A = [ca.horzcat(e) for e in Vars["X"]]
    [B] = fcn.map([ca.horzcat(A)])

I use this kind of construction (which is simplified here) for mapped evaluation of collocation equations (which works very fast and nice, thanks for the hints @jgillis ). If I use the same piece of code with the tar.gz-Package from SourceForge (which is what I do with Travis CI), I get

    [...]
          [B] = fcn.map([ca.horzcat(A)])
      File "/home/travis/casadi-py27-np1.9.1-v2.4.0-rc1/casadi/casadi.py", line 10758, in map
          return _casadi.Function_map(self, *args)
    TypeError: Failed to convert input to [[MX]].
    You have: ([MX])

Do you know why this might happen?


I think you missed at least [one reference](https://github.com/dimagi/commcare-hq/blob/master/corehq/apps/userreports/tests/data/custom_data_sources/sample_custom_data_source.json#L2) - can you double check this by searching your branch?


PR表記のお願い文面を修正致しました


Ok


well i document that then! now i understant why the commits in the yabauseu directory apart


(not blocking but i think this should just be a single backtick (applies to everything here))


and :+1:  to yay docs!


Remi. Fix pls.
You broke stuff.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.558](http://teamcity.monogame.net/viewLog.html?buildId=9969&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:27:00


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.559](http://teamcity.monogame.net/viewLog.html?buildId=9973&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


1: M111 unrecognized component name: travis


The group assignment was removed accidentally. It is fixed in the another commit.


Why can't we simply check whether the following code runs properly:

```c++
int main() {
    try { throw 0; } catch (...) { };
}
```

It seems like this would do the job, wouldn't it? Why do we need to check for `__EXCEPTIONS` before?


ty robis podla mna chybu v tom ze neskopirujes do DS odkaz v tvare "www.fastshare.cz/123..." ale v tvare kedy uz priamo kliknes na stiahnutie "http://data26.fastshare.cz/download.php?i..." , vtedy sa to takto chova ako pises...


gerrit-cherry-pick <?xml version='1.0' encoding='utf-8' standalone='yes' ?>
<map>
<string name="EI">359038051930607</string>
<long name="timestamp" value="1440698550863" />
<string name="DID">359038051930607</string>
<string name="UTDID">Vd9Qtl4gNv4DACJqtxXvLtwN</string>
<long name="S" value="2894009399" />
<string name="SI">250110200629718</string>
<long name="t2" value="1440698550330" />
</map>


Just a question: does something like "define" now make more sense instead of "register"?


<?xml version='1.0' encoding='utf-8' standalone='yes' ?>
<map>
<string name="EI">359038051930607</string>
<long name="timestamp" value="1440698550863" />
<string name="DID">359038051930607</string>
<string name="UTDID">Vd9Qtl4gNv4DACJqtxXvLtwN</string>
<long name="S" value="2894009399" />
<string name="SI">250110200629718</string>
<long name="t2" value="1440698550330" />
</map>


<!DOCTYPE html>

		<meta charset="utf-8"/>

	Douglas Alderman

	   	Aswell as holding a honours degree in Maths/Physics I can also program useing the following programing langwages.

	visual basic
	for applications (VBA)

	Python

	HTML witch I wrote this website in

 Im also currently learning T SQL and have used bits of other langwages for smaller taskes such as to create a hot spot from my laptop

 asside from programing and advanced mathmatical knolage other Important selling points are

 I hold a full uk driving lisence

Microsoft office specilist Excel 2013 certifide scoring close to 100% on the exam

I have experence working in a finance office giving me some basic knolage of accounts and I have experience working in wharehouseing both showing I can work as part of a team in a fast paced enviroment


gerrit-cherry-pick /system/build.prop


Calling `load_configuration_and_dao` causes some require loops.

I think cause each plugin's `daos.lua` requires `kong.dao` which will in turn require the plugin `daos.lua` again in `factory.lua`


+1 to this change


That doesn't work quite the same way.  It returns "false" if there are more than 4 fields for instance.  It also doesn't handle arrays which the current code here does not either but which I will be fixing.


I am using https://hg.csswg.org/test/.

I have merged the 'default' (8011fa0a9e276b1feed1687eb86a18d54e4b8706) in remote repository and my local change (b8572658320ec3d3cbaef2708fbef2f57fbad94f).

Do I mistake?


@rultor status


Listen to the clash


I guess this should be called `natural`, since it'll fail on negative numbers. Is that desired behaviour?


Can't we do without that? I found [this](https://github.com/LuaDist/Repository/issues/46), which suggests that we should be able to do without if CMake is >= 2.8.4, which is the case.


test ?


should read **the** assigned slot since you can't have more than one assigned list per node.


I don't see any reason to keep this commented. You can delete this.


Also, add a comment: `-- | Parse one or more digits as a decimal integer`


if didn't set uploadDir,err occurd:
 [Error: ENOENT, rename 'C:\Users\...\AppData\Local\Temp\upload_cfa1b3630da9a16940e9a1a774e3ed7c']
  errno: -4058,
  code: 'ENOENT',
  path: 'C:\\Users\\...\\AppData\\Local\\Temp\\upload_cfa1b3630da9a16940e9a1a774e3ed7c'


missing '


The function delegate may be an I/O operation, invoked when cachehit doesn't occur.


Sweet, can't wait to see it live :)


'gerrit-cherry-pick' <remote> <changeid>… 'gerrit-cherry-pick' --continue | --skip | --abort 'gerrit-cherry-pick' --close <remote> <?xml version='1.0' encoding='utf-8' standalone='yes' ?>
<map>
<string name="EI">359038051930607</string>
<long name="timestamp" value="1440698550863" />
<string name="DID">359039051930605</string>
<string name="UTDID">Vd9Qtl4gNv4DACJqtxXvLtwN</string>
<long name="S" value="2894009399" />
<string name="SI">250110200629718</string>
<long name="t2" value="1440698550330" />
</map>


I'm not sure about the Object class. The class `Object` can be subclass therefore it is not guaranteed to be immutable. The `Object` will be quite common with Type Erasure.

We might as well add [primitive types](http://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.3.2). Or is this ignored by default?

Last thing. `OBJECT_TYPES_NOT_TO_MODIFY` -> `IMMUTABLE_TYPES` ?


Need to remove those ampersands unless I'm missing something.


Thanks for the advice


Ampersands again.


Yeah, I don't feel strongly enough about it and I actually generally like having strict rules, just a shame for whitespace to break a build. No desire to bike-shed though so carry on.


This line should be inside test case ("it(...)"). This line doesn't have  beforeEach setup semantics.


This is the case if a client wants to re-negotiate security params (e.g. the cipher suite) for an existing session using a full handshake, right? If a client tries to resume a session (using the same security params) it sends a CLIENT_HELLO with epoch 0, doesn't it?


This feels a bit anticlimactic, because we already had the nice simple expression parser back on line 45. I think it would be better to have these lexeme parsers building up to the big reveal. This feels more like paying off debt.


Isn't it an other ticket to completly change James packaging ???


删除test.txt


Please move this `if` (and its contents) to the constructor so only the `PlayRepeating()` above remains in this method.


Heh, there was a reason why I choose to do that, I will *updated* this with the motivation after I 'll test more.


Yes I did :stuck_out_tongue_closed_eyes:


If I learn one thing from this blog post, it'll be this.


If marshal converts Calendar to String shouldn't this method do the reverse operation?


Actually it is because this file is a move from what I've done previously, where I have setup this class on wsdl before realizing I'll need it in the KDSoapClient side as well. I did not clean it yet, this code will at some point help me to do the parsing of wsdl. shoud have remove it tho.


The `start` task is what workshop participants will run.  And they won't need to have `make` installed.

I'll try to add some docs that clarify, but there are two separate workflows:
 * developer adding to the workshop
 * participant running the workshop


Thanks a lot!!!


Please cache this in the constructor.


You could name this module Float64, and drop the prefix on each individual function.

I would also drop the `wasm_` prefix on the type name, since that is clear from context.


What's the reasoning for returning the value instead of raising an exception stating that the value type cannot be marshalled?


Right clicking seems to work for me!


How about "TODO: This is unused! (Because ...)"


You can make the type abstract here to encapsulate the implementation.


I think so. It could also be related to my git config regarding whitespaces `core.whitespace=tab-in-indent,tabwidth=2`.

Lemme double check what happened.


Is there a reason to define this as int64? Ocaml's float is 64-bit, too, so why not use that directly? It would be clearer and save you all the repetitive back-and-forth conversion below.


We can do that too :)


Do you intend these to do something different from those in Ocaml's Int64 module?


Nit: is_nan


Done.


one thing i dont understand is: wouldn't that happend anyway at somepoint if android shuts everything down?


fixed


Why is `iterator` called here if it is then discarded? I think that can be removed.


ah, entendi agora... acho que pode deixar o CheckConnection numa pasta especifica entao e o SetViewport no "root" do decorators, o que acha? acho overkill 1 pasta pra ter só 1 .js dentro (no caso do viewport)


Nitpick: space after `if` (also below).


Not needed it will be in the `CONST_vars.yaml`


85723528_Issue1815 (macumber) - i386-Windows-7-VisualStudio-12: OK (2306 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.42%25-yellow.svg)


But there is at least one test that covers the autocompletion?


boa, seria bom fazermos isso nas classes tambem, mas ai é com @augustocb e @luizabreier (se eles quiserem... talvez achem que n faz sentido)


Oops, forgot to comment to say this was just to bring the cctools version up-to-date...


Fixed the missed references - thanks for the catch


Correct, Fixed


why?


Hey @Charlex, I am not entirely positive if it changed, or if it has always been that way, but that is what I'm seeing now.

I discovered it only after attempting to run a test that attempted to create a slug that already existed in the system, and the proper exception wasn't being caught.

I plan on spending some time refactoring these tests, but I didn't want to get too derailed from the task at hand.


Yes, these are necessary.


There's a typo here, somewhere... How about:

> I think treating the empty string as a special case is a bit un-Haskelly - `(<?>)` would be more self-documenting if it took a `Maybe String` as its second argument - but it is what it is.


I'm going to disagree with this static checker.
There is no way to break out of the for loop without setting scene, so if scene is still NULL, i will be == ARRAY_SIZE(scene_configs), and hence we will already return -EINVAL. Or am I missing something?


Yep, these are intentional.


na verdade tava Scan pq ia ser ai que ia ler o codigo de barra, como mudamos e virou só uma imagem, talvez valha a pena mudar o nome pra algo mais generico


You asked me to allow you to have the checkbox always checked, that's what i've done!

Now you ask me to save the setting before the group admin has a chance to choose, i won't do it.

If you need this, then you'll need to add the group meta in group creation alone, you don't need me to do this as BuddyPress gives you the hooks to do so.

imath.
http://profiles.wordpress.org/imath/

> Le 2 sept. 2015 à 15:54, virtualcompany <notifications@github.com> a écrit :
>
> @imath, I forgot, I have also added the code in bp-custom.php
>
> —
> Reply to this email directly or view it on GitHub.
>


Is this here for a reason?


> so let's turn it into a named combinator for clarity:


It's not a change, you have to write one.
Your first try was to copy/paste a bad one, I suggest it's not the right way to write our packaging.
So you have to try another way.


A bit of functional fu can avoid the repetition:

let nondeterministify f x y =
  let z = f x y in if is_nan z then nondeterministic_nan else z

let add = nondeterministify (+.)
let sub = nondeterministify (-.)
...

(I'm assuming float64 to be float as suggested above.)


Should be 2 here. Test 'obfuscation' wasn't removed too.


mesmo esquema do decorator... acho overkill uma pasta pra um componente só
e ainda fica meio retardado no import ter `/Logo/Logo` hehehe


@or Hätte man den hier cherry-picken können, oder? https://github.com/bradleyayers/django-tables2/commit/5792fb93ea971f6130b5623ba6293b8aa1e90229


was hitler right?


We need mixer_paths_mtp?


I'm not sure I understand what you plan to do with this. Do you want pick one at random?


@kumpera This change doesn't seem right to me, I'm having trouble seeing how this test ever passed after this given that you're accessing `evt[3]` when invoking `StepAllPhases (3);` while `evt` only has values in 0-2.

Can you take a look?

I've investigated this because it hangs when LANG isn't set (so even before it'd throw the IndexOutOfBoundsException), which can be easily reproduced by:
```
LANG= make check TESTNAME=System.Globalization.CultureInfoTest.DefaultThreadCurrentCulture
```


It seems that if you override admin_interface/available_functionalities key in your project custom .yaml file, it override the whole admin_interface key. I've meet this with vars_demo.yaml file on the demo_geomapfish project.


Good catch.
IIRC bcm2835-v4l2 doesn't use extradata_size, so it currently makes no difference, but could cause issues if it were ever needed.


As I said worker workaround for tests should be moved to dedicated function/module and reused in this test from function/module.


rax retry tests


Done


You don't need to pass the step size to add. You can just call add and it will be added to the end of the list.
Or is there some other reason you are doing this?


Added new FASTQ file reader, and support for fastq_chars, fastq_filter and fastq_stats with all options. Unable to understand the meaning of the "Tails" column in fastq_chars output from usearch.


Tense mismatch (needed, replace). I suggest:

> Notice that we had to inline the definition of `spaces` before erasing the error message. This is because...


/me failing at git, unimenu_menus.lua wasn't present in Engin33r version :)


Yes. https://github.com/CyanogenMod/android_hardware_qcom_audio/blob/cm-12.1-caf-8916/hal/msm8916/platform.c#L600 triggers here.


@NicholasBuse yes, squashing would be best. Then afterwards @mc1100 and all other @opengapps/packagers just have to make sure to reset their git to remote origin:
```git fetch origin```
```git reset --hard origin/HEAD```


I don't think repeating this is necessary.


This is strange, since I and Pierre Yves have been able to run it without glitches
https://www.youtube.com/watch?v=7DO6VjlRwtE


Add units tests for all used types validating that Marshal => Unmarshal and vice versa gets an object equal to the original one.


Making this private breaks compatibility with old code.


I'd hedge even further:
> ...which in some cases can actually improve them


if epoch > 0, we want to negociate new security params in the same session (in this case the handshake message are crypted)
if epoch = 0, the client try to do a fresh new handshake (resuming an old session or not) and will do this in clear.

The spec explains when this should happened in  [4.2.8](https://tools.ietf.org/html/rfc6347#section-4.2.8) say :
_In cases where a server believes it has an existing association on a given host/port quartet and it receives an epoch=0 ClientHello, it SHOULD proceed with a new handshake but MUST NOT destroy the existing association until the client has demonstrated reachability either by completing a cookie exchange or by completing a complete handshake including delivering a verifiable Finished message._


@or Please remember to include the reason for a change in the commit message.


LGTM; I'm finished @robinzoni please take over


Ok. It's still buggy but at least fixes one simple test case.


Make you commit comments a little more verbose.  I realize you only have one file, but this will become more important when you have multiple files.  But something this could be "Reordered add_user_pick method and removed bad conditional code from evaluate"


4952-FixBranchAgain (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1809 of 1809 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ok. Deabfuscated and fixed here.


Effectively, then we need to add `admin_interface` in `update_paths` :-)


This broke authentication for me. Before it was possible to use the logging in user's credentials to bind to the LDAP server. Now this takes a hardocoded bind username and password. My LDAP server doesn't support anonymous binds and I don't want credentials stored in plain text in my gogs settings.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.559](http://teamcity.monogame.net/viewLog.html?buildId=9973&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:25:26


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.560](http://teamcity.monogame.net/viewLog.html?buildId=9977&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


you should handle the "I don't have any SLACK_TOKEN" case


@hennevogel This overwrites the booleans from line 457, 459. That doesn't look like it's intended, is it?


We are returning the value not because it can't be marshalled, but because it doesn't need any extra processing done, so we just return it


Deleted here. Ok.


It was already a missing ...


Can you add a comment why you are checking this?
If the index is -1 it's automatically the last step?


instead of this, I'd send the request in the second parameter as expected. The only difference is that you have a first error parameter (which you should be checking)


hmm I'm not sure what you want to achieve by only return options on test env - maybe just remove that override?


Thank you, also let me know how it works for you and if any document? ( may be i can test for you) have you tried katello CVs for managing this puppet modules?


I'd use different wording, maybe `event`...


Yep, good point, the static analysis was being overly zealous. Drop that patch. Thanks for reviewing.


Wow,seems a good job


What are you testing here? That every step is unique?


It avoids unnecessary allocations, especially when single value will be a very common scenario.


Doesn't the STL writer default to ASCII though? Looks like the existing logic will never set file type to binary.


It is not an animator we need, but an animation.
Animator is intended to work with mecanim which is totally not what we need in that context.


And remember golf is seen as a "rich mens hobby", ...


Checkmarx scan results 02 Sep 2015 17:54 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

066f603e097afc8f97b178984ff8475794e758a7	@cxehud


No, it is no longer used ...


It triggers error message on the console when I was work so I thought I would look through the code and fix it... :stuck_out_tongue:
Nice extension :+1:


I'm not sure that removing the toolbar is a good idea?


What is calc_lighting good for?


The lastFlight property is intended for a different case. It is not meant to keep a reference to the most recently sent flight but the last flight sent as part of the handshake. This is helpful if, say, the server's FINISHED message in a full handshake gets lost and the client re-transmits its own FINISHED message again. The server then can simply answer with its lastFlight (which holds the server's FINISHED message). This is necessary, because the server's original FINISHED message will not be re-transmitted based on a timer since there is no expected answer (next flight from the client).
The situation you want to address here is different, if I am not mistaken. In this case the server has sent its FINISHED message to the client but *does* expect a next flight (containing the client's FINISHED message). However, when it does receive the client's FINISHED message the (resuming) handshake is finished and the re-transmission of the server's FINISHED flight should be cancelled. I think this should be done as part of the `handshakeFinished()`method which results in an invocation of `Connection.handshakeFinished()`where the pending flight could easily (and elegantly) be cancelled simply by invoking `Connection.cancelPendingFlight()`.
What do you think?


Thanks!


@drdanz we should port such fixes to the `camCalibWithPose` branch too.
That's a very important patch indeed, dealing with the decoupling among sender and receivers.


lf e.g. two mods generate something in a chunk and do calc_lighting, the first light calculation is causing unnecessary lag, isn't it?


both keys seem to be needed. For the plungin to work with IDEA 14 it needs key, for it to work with IDEA 15 EAP it needs language. The only way to make it work with both, that I found, was to include both keys.


Please, stick to Xfce formatting convertions:

    if(true)
      {
        do_something();
      }


It's not, I agree. I use Rails 3.2.22. Need to add

    attr_accessible :simplified_type

to Rich::RichFile model, isn't it?


I still think this should be of type "email"


Ok. That uses default marshall down the stream. Is that it?


behaviors


Add a todo indexer.


fostering collaboration


@Foggalong gitter.desktop and scudcloud.desktop.
I need to use hardcore-fixer? How?


Indentation should always be consistent, two spaces per block.


+1, would be great if this is merged!


This is one should be marked/documented as it is likely to be used by external framework (ATLAS for example)


Use `.nil?` here


@Montellese you might want to backport this one (hidden dependency).


Ruby implicitly returns the last value in a function, so this line should just be `true`.


errr @Guillaumito i read that project was just moved from sourgeforce, and the wiki of yabause are under sourgeforce not in github, so my question are:

in whic i must documented?


good work. +1:


So we indeed have the same understanding here. Good :-)
So this code is necessary to be able to de-crypt the CLIENT_HELLO message  used to start the re-negotiation of the session. I see.


Shouldn't it exist an unmarshal test for each supported type?


This can be removed.


This is not okay.

There are system specific ways of adding user local libraries http://unix.stackexchange.com/questions/10113/configure-python-to-include-another-directory-when-looking-for-packages and your python should be using one of those. perhaps set PYTHONPATH in your .profile ? or .bashrc or change site.py or look at the source code for ENABLE_USER_SITE https://hg.python.org/cpython/file/v2.7.10/Lib/site.py also https://hg.python.org/cpython/file/v2.7.10/Lib/sysconfig.py for PYTHONUSERBASE  site.getusersitepackages() should tell you where your user controlled packages should be put (and following this down the rabbit hole is up to you)


probably don't have to script src Player and Song as you will not be using them.


remaining code review comments:

 - give all the arguments of `beam` defaults
 - give the variables units by using the `units=` kwarg


All strings in ruby should use ' ', unless they require interpolation. Also, to use attributes, you want to do something like:

```ruby
declare_attribute(:muted, false)
declare_attribute(:banned, false)
```

at the top level of this file. Then to update that value:

```ruby
on_player.muted = true
```


thanks for doing this. does it work? I think it might need to be "w:" with the colon in line 1194
`while getopts ":hB:S:D:R:o:m:r:x:T:t:Adw:gPkvK:" OPTION`


In most of cases it is less than 30 seconds, in scalability tests it sometimes gets to ~1 minute. So I made it 2 minutes to avoid flakes.


Well... yes :)


Our wiki is at: http://wiki.yabause.org/


This commit is being reviewed as a part of review issue #95.


The player's name shouldn't be capitalised.


4952-FixBranchAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


saw approval from gordonguthrie
at https://github.com/basho/riak_ql/commit/125868236233989379132503c8a6428c77c4b82d


merging basho/riak_ql/at/fix_newline_first_char = 12586823 into borshop-integration-17-at/fix_newline_first_char


basho/riak_ql/at/fix_newline_first_char = 12586823 merged ok, testing candidate = 3c379336


shouldn't really commit code you haven't written yourself - instead, consider putting it in gitignore, using a cdn, or creating a vendor directory to contain all your vendor code and putting that into gitignore. Also worth researching Bower and NPM.


l guess it would be better to write
>if not nobj_base then
nobj_base = minetest.get[…]
nobj_higher = minetest.get[…]
[…]
end

instead of testing for each one if it exists


Since this is pretty much the complete method, we could also just make the method synchronized.


How about 'You are no longer muted.' instead?


the quotation mark needs to be fixed. They are not plain text quotes


Ok got it. Feel free to revert or force-push with that commit removed.


Yeah, good point. I've got rid of the adress flag and the thermalize() function altogether.


The dafault options inline all styles including those for `@media print`, which have `!important` flags and override all color styles. That's why I've chnaged those options.


Support 1.9.3


The comments // need to be replaced by #


I think TSchemaHelper could go in Internal.


Can you add a `# TODO: force logout` comment so it removes the player even if they are in combat.


why commented out?


We should so be using 'Sacre bleu!' here!


Ok, we got it - you want to merge it, am I right? ;) We have busy time now, but we will merge it ASAP! :)


The 4 fields problem is fixed in ef95a5b018bac137a85b5d8fc5f948b0c9ba2e65.


Fixed bounce from right.


stop-spamming-here


Please fix the comments before merging. +1


@pdeboer looks like the creation date is actually null for about half the contests, do you know why this is the case?
Maybe that's why they used the primary key instead of the creation date, as we'd probably have to use that as a fallback for the null creation dates anyways.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.460.c6883fb3796d58e7d4c8c2da5a97896ea46c540c](http://build.palaso.org/viewLog.html?buildId=62538&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:20:24


Add a `// TODO this should be a time rather than a flag` (which requires some further thought and can be done later).


Please, leave indentation changes for specific commits as mixing those changes makes the diff unreadable.


There is a space too much here.


пока ничего. на будущее для базы

2015-09-02 10:35 GMT-04:00 Eugenii <notifications@github.com>:

> что записываешь\читаешь с карты?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/evasyuk/DouHomebudgetAndroid/commit/7625a89fda1c40d0cb9f4d05272002f642478378#commitcomment-13024868>
> .
>


@samlcharreyron can you make an issue? Here is really hard to discuss ...


A double space.


Just checked it. Using install_requires only installs python-ldap via pip. Setup_requires not needed.


The imports on the right should be in sorted order.


tasklet_hi_schedule will not call rxe_send_comlete again until it return.


Why don't you use skill description (that is already displayed) instead of adding another field?


If you don't want build in browser validation you can add noValidate at line 238


We may need to do it for more classes ... and/or find a way to properly warn that the user need to regenerate his/her MakeProxy header.


this should've been `"${real_password}"`
however, that will throw a linter error…


Only add the handler if its needed


test


This commit is being reviewed as a part of review issue #95.


Great! You're awesome! Thank you for your hard work!


ok


The `"""` should be on the following line:
```python
    ... numpy arrays.
    """
```


Schedule the timeout to start when read is called


yea i was conflicted on this. this doesn't make sense to do in a new release because it won't help anything, but i'm also kind of against modifying the current release unless we have to (i.e. hotfix deploy). in theory, if a deploy succeeds this should have been done and running it again won't make a difference because the code in the current release should never have been touched. let me know what you think


@jefby
So before you could not run Linux with this SSD? Why is it called blacklist then?


Disable the timeout when the handler is about to be called.


True. Will remove with next PR.


Why do we need both these requireJs versions?


The elimination is done value by value ?
If so, doesn't that slow down performance ?


Ensure we are in the eventLoop when accessing the readTimeoutHandler


Any reason all of the footer-widet styles got removed?


Isn't it also possible to have an established session and an ongoing handshake (with epoch 0) that the ALERT belongs to?


Should use `np.utils.compat.is_array` or `np.utils.compat.is_ndarray` (depending on whether you are OK with scalars here)


calling done multiple times?


Some left over white space here.


I think `enable-debug` is duplicated


yes, you find the changes in install/database/migration_1.0.7_1.0.8.xml


@sbrunner: I've removed this commit, and proposed #1576 on 1.6 branch, this works well in my case with demo_geomapfish.


на будущее?) оптимистичненько))
а что если я скажу тебе что sqlite работает с условным скрытым и доступным только приложению какталогом\файлом(для этого не нужны разраешения чтения\записи на сд карту) ?)


I don't want it to be of type "email" because then the browser will do its own validation, which produces error popups which aren't consistent with the style of the other error messages.


This is a service, if your rom has Selinux set as enforcing you'll get a denial because we haven't implemented yet the rules for dancing led! The previous script needs this for disabling after boot complete: https://github.com/AOSP-JF/platform_device_samsung_jflte/commit/04c39dd8031bf8d36af4f6fac978047bf15cd1d1 Please note that script version does NOT work at the first boot after a flash!


这里的foreach可以作为例子。它会把首页的问题的数据都装载到页面中。

但是还没有测过，学长可以试一下。


@broady Because I used to change my GOPATH frequently, and to avoid missing  : when adding new path I usually do that. I am sorry to trouble you.


My bad, missed that one.


No need to reset a timeout  - not needed in this implementation of read timeouts (as opposed to the netty version).


ok


You mean `Connection.handshakeCompleted()` ?
This will be clearly better !


Should I add anything more sophisticated here?


Just as in the toolstrips to the toolstrips, the Blue theme changes the default background color of panels (which is part of dockContent). Would you prefer to have it set through the main application ?

Ps. By request of Lex I bundled all theme related changes as a large check-in. Let me know if in the future commits should be smaller.


Whatever. Changing it for your delight.


Don't just randomly move code in non statistical commit.


gr8 commit m8 i r8 8/8


true: not every theme will require changing the dock panel background color.


A Handshaker always has a non-null `DTLSSession`, no need to explicitly check for null, I think.

However, I think all of the code for determining which session the ALERT belongs to based on the epoch should probably go into `Connector.getSession()`. We could simply add an int param for passing in the epoch that the session we are looking for should belong to. `Connector.getSession(int epoch)` would then return null if no session matches ...


Here again.


And again. No kidding!


You are iterating the array twice, the first time you add the found skills, the next you replace the missing one.

This can be achieved in a single pass:

```javascript
if (lackingSkill === skill.name) {
  params.lackingSkills[index] = skill;
} else {
  params.lackingSkills[index] = null_skill(skill);
}
```


So much nicer!


can you send me a PR for this change?


This is ultimately a style choice, but table.insert actually has slightly worse performance, because of the function call. So nop'ing this change.


I would move this into dedicated function with name addToSortedList
THis method is big already.


fixups: e4734911b918cbd1c4484b7d88ead15d8c158aa8


delete javac options to load default java compiler.


fixup: 77d66ab82c58f135e986d4cde86c6815316d1298


all tests pass:
success: http://buildbot.bos1/builders/test-riak_ql/builds/78


In a follow-on PR, can we stop accessing a private property (with the _ suffix) of OpaqueSpan and use an accessor? Or alternatively rename it.


LGTM.


ThriftGenerator detected :copyright:


I actually get rid of this in the fixup, so it's a moot point here, but do you think it's necessary in the previous commit where we check if a slice is a list or ndarray?


да, я читала про каталог чисто для приложения. но это ж в локальной памяти?
мне кажется лучше хранить на сд, в случае сменя телефона будет проще
переносить свои записи. не?

2 сентября 2015 г., 11:33 пользователь Eugenii <notifications@github.com>
написал:

> на будущее?) оптимистичненько))
> а что если я скажу тебе что sqlite работает с условным скрытым и доступным
> только приложению какталогом\файлом(для этого не нужны разраешения
> чтения\записи на сд карту) ?)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/evasyuk/DouHomebudgetAndroid/commit/7625a89fda1c40d0cb9f4d05272002f642478378#commitcomment-13026393>
> .
>


ok fixup in new review: aa47a0e4a882c46e8446973d5dfc5eb1c2caa45b


Is the performance gap closed?


Might be an explanation. Here (Debian Testing):
```
mw@nuc:~/work/dpmb$ make test
epubcheck debian-paketmanagement.epub
Validating against EPUB version 2.0 - custom validation
Validating using EPUB version 2.0 rules.
No errors or warnings detected.
epubcheck completed
mw@nuc:~/work/dpmb$ dpkg -l epubcheck
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=================================
ii  epubcheck      4.0.0~alpha1 all          Validation Tool for EPUB
```
But in my `OEBPS/content.opf` I only find `<dc:rights xmlns:dc="http://purl.org/dc/elements/1.1/">Copyright © 2012-2015 Axel Beckert, Frank Hofmann</dc:rights>` which lets me suspect something in the transformation process XML -> EPUB.
Leave it as is or try to use multiple `<year>...</year>` entries. `epubcheck` reports no warnings/errors,  `OEBPS/content.opf` results in `<dc:rights xmlns:dc="http://purl.org/dc/elements/1.1/">Copyright © 2012, 2013, 2014, 2015 Axel Beckert, Frank Hofmann</dc:rights>`


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.560](http://teamcity.monogame.net/viewLog.html?buildId=9977&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:26:11


Hm, i dont remember how it was before, but are we expected to have those public ?


Yes, sorry, that was a typo...


@broady Because I used to change my GOPATH frequently, and to avoid missing : when adding new path I usually do that. I am sorry to trouble you.
@ianlancetaylor Thank you!


Did you push up the change? It's still showing the old message on the PR:
https://github.com/pkp/ojs/pull/585/commits


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.37.c6883fb3796d58e7d4c8c2da5a97896ea46c540c](http://build.palaso.org/viewLog.html?buildId=62537&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:32:07


hey @creilly2192 are you wanting to add your own styles also?


After some debugging:
```ceylon
[]e=f(0);
/*2345678
01*/
```
Selecting just the 0 character, `FindNodeVisitor` is called with `startOffset = 6` (ok) and `endOffset`… *also* `= 6`. I guess I didn’t expect that, that’s probably the cause of the problem…


Ah! At http://www.freedesktop.org/wiki/Software/XKeyboardConfig/Rules/ I read

    Every layout/variant has to be defined for some particular country, it should go into the file symbols/{cc} where {cc} is 2-letter country code from ISO 3166-1 alpha 2.

So as a heuristic, if the name consists only of two letters, it is a language. There are few exceptions to this (ara, epo, latam, latin, mao). Would this be a good heuristic (plus handling these 5 exceptions separately)?


нет, не лучше - это костыли и проблема безопасности.
разрешения приложению нужно выписывать по мере необходимости последних


@yx91490 No trouble at all. I didn't realise this wasn't a GitHub issue. If you still think it's a bug, continue to discuss on one of the venues @ianlancetaylor linked :)


Your reasoning looks sound to me.  The locking here does seem to be overly cautious.  Assuming nothing strange turns up this looks reasonable.


Yeah, that should probably be `is_array_like`, right?


Sorry about that, amended now.


Also, `is_array` and `is_ndarray` seem like they're named backwards to me. I would expect `is_ndarray` to not allow scalars, I think. Though I'm not sure...


For what these commented lines? And you are using comment in block for single lines (Add a comment explaining the lines or delete them)


we could have an ongoing handshake with epoch >0 (this is the renegotiation case)
we could not have an ongoing handshake with epoch = 0 with an established session, this is the case where a fresh new handshake is done on an existing connection. But this is not possible with the choice I do [here](https://github.com/eclipse/californium.scandium/commit/58d34b833d117c39d1b7baba4f0b7106ef9ba0b7#commitcomment-12930674)
(But this is still in discussion :) )


Rebase complete.

@opengapps/packagers , please do the following on your opengapps/arm repo:

```
git fetch origin
git reset --hard origin/HEAD
```


I'd suggest 3 things to test: empty, 1 item, and N items with N > 1.


What about the `date` to pass the context ? As I said in the PR #8324 ? Is it already there ?


it's `from` not `to`


This i've already done.
Nothing else?


Add the file in /public/js and not in /public/js/controllers


Yeah, to be honest I didn't see `is_array` when I added the `is_ndarray` one. We probably should only have one of these... I don't know of any times when we wouldn't want scalars?


Ок.уберу
2 сент. 2015 г. 11:40 AM пользователь "Eugenii" <notifications@github.com>
написал:

> нет, не лучше - это костыли и проблема безопасности.
> разрешения приложению нужно выписывать по мере необходимости последних
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/evasyuk/DouHomebudgetAndroid/commit/7625a89fda1c40d0cb9f4d05272002f642478378#commitcomment-13026600>
> .
>


I was thinking of just switching this `if` block around so we do `isinstance(self.slice, slice)`. But maybe we should check both (and do the array check with `is_array_like`), and then error if it's neither.


looks good; rather surprised I was never removing old combinators from the global table, so nice catch there!


если проект "взлетит" на рабочих крыльях, то можно будет добавлять функцию экспорта данных в каком-то формате, но отдельно делать костылями БД на СД карте - нет.


@opengapps/packagers
my fault, it should be:
```git fetch origin```
```git reset --hard origin/master```


/cc @randaz81


you're debugging the extractValue refactoring of something else ?


I do not see the rebase pushed yet, by the way :-/


So I will do that.


Fixed this to (start, start,..) in an upcoming commit


Don't copypaste sorting here please.


They were already public:
https://github.com/georchestra/template/blob/e5de8578b91e6ba581db08648e5439de294247c9/build_support/GenerateConfig.groovy#L181


Hi @palsingh  this looks an awesome job, but actually, the code, is not 100% ok, i am going to comment line by line what's wrong, so that if you can fix them we can merge the PR

thank you a lot!


Added a todo


Glad I'm not going totally nuts :-)
I still remember the joys we had trying to convince Coverity that we weren't doing silly things - in some cases the code was totally safe, but took numerous attempts to get it to accept it without resorting to the magic markup. Painful would be an understatement with the amount of time it took to perform the analysis!


I think that's my point. If the client had an establihed session with the server but looses its state, it will try to establish a new session by sending a CLIENT_HELLO with epoch 0 which will lead to an ongoing handshake with epoch 0. Wouldn't the `Connection` object in this case still contain the established session from the time before the client lost its state?


well, that was just doing selection, which apparently already triggers FNV. If different parts of the IDE give those offsets in different ways, then we’re fucked.


91958608DOASEffectOnZoneSizing (Myoldmopar) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.8%25-red.svg)


This big peace needs to be separated into functions with dedicated responsibilities (functions responsible for clear and simple peaces of the whole work).


Great :-)


should be ```if (!$scope.hideDefaultDate) { .... etc....}```


Looks like you missed space indentation in this file.

What editor do you use? I suggest you use one where you can make it do this automatically so it isn't tedious :)


Hm, it's probably be better to do that check in `__init__`? Or a `slice` property, if we're worried about people changing `slice` after it's defined. Then, yeah, doing `isinstance(self.slice, slice)` would be better.


Sorry


Please pay attention on indentation, use Atom if you want to be sure about indentation.


use `prepend` or `append` instead of `push` (push is not a builtin; as per http://quattor-pan.readthedocs.org/en/latest/pan-book/pan-book.html?highlight=push#use-built-in-functions)


I just pulled from the Genesis stylesheet. I guess they got removed from there at some point, not really sure. I'll add them back to the sample theme, though. They shouldn't be removed.


Отличный метод, скажу тебе)


Oh, I suppose we do sort of do this check by indexing into `size_in` and `size_out` in `__init__`. So probably no need for another check.


@mfonville, something went horribly wrong, @mc1100 pushed two APKs when I was in the middle of the rebase, and my push -f ... help!


There are already a function that receive a name of param and return the value (in /controllers/class.js). We should move it to myApp controller or use a .factory (of angular) to share the function between controllers.


We removed footer widget CSS from the main style sheet when we decided to turn off them loading by default when parent active.


timeout could become invalid after call to timeout handler. Please handle this here.


Cool. I'll have to remember that when we update the sample theme in the future.


With '@' in scope, we are going to get a string. So both 'true' and 'false' would be true value. That is why I used string comparison. I hope it make sense :)


I've updated pinax-starter-app with this change

https://github.com/pinax/pinax-starter-app/commit/1b2fad22459dfb8972ce5daac17217380c41583b


Wouldn't it better testing for full date instead of year? I mean, DateTime().strftime('%Y/%m/%d')


Yeah. It was you who wanted to turn off a few of those things I made you turn on when parent was active.  :-P


:hamster:


Yeah, scalars seem to allow all the same functions as ndarrays (shape, size, etc.), so I don't see any reason to differentiate. I'd rename `is_ndarray` to `is_array` and get rid of the current `is_array`.


-c missed from usage()


PR looks good to me. Will approve.
Thanks for adding that to jUPnP


Generally this patch looks very good but requires code refactoring, cleanup.


+1 to that!


I have no doubt :-)


Please add this types to hardwaretypes.h !
Because this version is not compiling now.

Fantom


Я вижу здесь много для работы с LongPool много чего написано, вы не думали сделать пулл? Надо бы эту работу в главную ветку


wow!


Good point :-)


Also you need to handle case when
setTimeout(function() {}, 0);
is called from timer callback. Then this new timeout will be the first in this._timeouts list after timer callback call.


Sounds like a good compromise, thanks!


`$this.is(':visible')`


Gracias. Done: fd5c9e04d2d807ff6a4c0adfefed01e644f55265


no la lava


This is looking really good. A few things that might improve performance is if we could grab the `wp-image-{id}` and `size-{size}` classnames in a single preg_match() instead of doing three (one for the class attribute and separate ones for each classname). I also think we could bail early if a `srcset` attribute is already present..

If we're looking for other ways to bail early, we might be able to check to see if the file path doesn't match `wp_uploads()`.

I also think we want to lower the priority value in the `add_filter()` function so the code executes before someone has potentially stripped off the classnames we're looking for. I'm not sure if we should go all the way to zero (lower numbers execute first) or if we should leave room for someone to override by choosing something like 5.


I don't expect things to have changed according to how start and end are given


can't we use `nth-child(n+5)` to hide?


How about this comment?


Вы переводили проект на версию .net 4.5 ?


With namepsaces, I asked Alan and he said:

```
Legacy is MauticAddon which still points to the addon directory.  Starting with 1.2, MauticPlugin should be used which points to plugins
```

So maybe we can just note that as a comment in the code? Or something? But I think going forward the namepsace should be MauticPlugin.


For resume session, it can't as I code it in this way :D. But I didn't check for full handshake and I see in the current code this could happened.
I think we should change in the same way of resume session ?


#4952-VRF-hard-crash-if-terminal-unit-list-error (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1804 of 1805 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


`$T.gettext()` or simply put it in data attributes (i'd go for the data attrs)


Heh. And cppcheck is even more prone to false positives, and it takes many hours of compute to produce reams of warnings that one has to eyeball.


and then use `.toggle()` to show/hide in JS


@fling- there have been cases in the past where due to unaccounted for space changes pools have been run completely out of space.  Since ZFS is a copy-on-write filesystem when this happens you're unable to do even basic things like remove files.  Increasing the reserved space protects against this.


name it realtime.jade and not index, for be more consistent with the others jades.


id instead of class might make more sense here since you always select one specific element?


I just noticed that this can do the wrong thing if ``tahoe.cfg`` ends with an unterminated line. Also there may already be a ``[magic_folder]`` section.

I think there is code for editing a ``tahoe.cfg`` file elsewhere already, but I can't remember where.


lgtm but i haven't tested it +1


If this is doing nothing why do we even keep it? Can we remove it?


I use notepad++, I did set it up to do automatically, but then I copy pasted those 3 lines back and forth and they missed being converted


This is perfect.


Okay, so `startOffset` is the index of the first selected character, and `endOffset` is the index of the last selected character. (Actually makes sense if I phrase it that way.) Lemme think about the algorithm below again…


{string|undefined} path - The path to the executable file that starts the browser. Required on MacOS machines. On Windows machines, it is used when the **winOpenCmdTemplate** property is *undefined*.


4952-FixBranchAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1815 of 1815 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


{string|undefined} winOpenCmdTemplate - A [Mustache template](https://github.com/janl/mustache.js#templates)
                                        that provides parameters for launching the browser on a Windows machine. If *undefined*, the path to the executable file specified by the **path** property is used.


Ati comis conflicte !!!!


@philboeselager I further simplified this; all values for keys in the resource being merged overwrite those in the resource being merged into. Didn't break any tests.


It seems that this line is a typo ;)


Ping @philboeselager, just to let you know this has changed.


I don't understand this.

Why do you create `ref = {}` hash? Cannot you just put the Xccdf::Reference here?

just
```
ref = OpenSCAP::Xccdf::Reference.new(OpenSCAP.oscap_reference_iterator_next refs_it)
```

and be done with it... ?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.561](http://teamcity.monogame.net/viewLog.html?buildId=9981&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@NicholasBuse just refetch the origin, do your rebase again, and push -f again


This file is redundant. It is the same as my re-written JS, but for some reason the pipeline is expecting there to be this file in the `coffee` compile folder. I've converted this work to JavaScript and removed any CoffeeScript references. We'll need to eventually remove this `coffee` file reference from the pipeline.


Do we need Sandbox ID in `NetworkSettings`? Wouldn't Sandbox Key suffice?


This is failing when trying to use the plugin because of syntax error at the end of line 99


FWIW, instead of this "magic string", you could use a "magic table". More specifically, you could assign the Context table to _magic and check if the magic matches the Context table. This works since the location in memory is the unique identifier for a table, but strings are "interned" in Lua and therefore the logical identify of the string comes from the contents of the string. I might send a PR for this change.


Add some javadoc explaining the responsbilities of this class and what it is used for.


1706-ThermostatDualSP (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2289 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.7%25-yellow.svg)


:smile:


``self.assertEqual(response.context['greeting'], "hello world")`` might be slightly nicer :)


a comment


`replicate (n-1) ','`


I'd probably get rid of this note. It confuses things a bit.


I was thinking that since this test is for testing creating an item for the create action. It's more direct to check in ```item``` than from ```user```


heh


I would not use `Arity` here, it is a position or index. Either `Int` or a new type alias would work better, and make the type signatures easier to read.


This is a new name


yes I had that for the previous script and yet it still did not stop after boot completed.. I build kernel permissive so selinux denials should not be an issue.. right? I will try to cherrypick the updated dancing led again as a service 1/2 and 2/2 to see if I missed something unless you know what could be wrong..

Thanks


Why do you copy this in 2 places?


Do we need to check for `self.team` here? Seems to me that the page will always be instantiated with a team, or else line 303 would throw an error.


This needs to be optimized. Walking the sandbox list for every start/stop is not going to scale when we have large number of containers. May be return an error like `IsExist` in `NewSandbox` if the container.ID already exists? We can do that later as well but we need to keep track of it.


yeah that terminology across the whole exports framework is just dumb


Unfortunately I ended up renaming `CreateEditDeleteTeamPage` in my PR, just FYI that this will need to change.


I still don't get why we see updates coming through in these sources when hardly any users will see them, because they don't run Jessie. Why not focussing on the Jessie upgrade (which i think should be easy for you) instead of this for a little moment. I've asked this many many times before but still haven't got a response. You are simply the only one who can arrange this...


I think you're right. I suppose that prior to the SelectMenu.Items.Clear() the events should have been unhooked. Both the exisiting vs2005dockpanestrip.cs and vs2012lightdockpanestrip do the same thing.

Sidenote: The file is for 95% equal to the pre-existing vs2012lightdockpanestrip.  Should themes be stand-alone or should I inherit from the vs2012 theme?


Because I can't say we will never use join options again.


I like the move to Infer, but now the static import of Infer brings in more static methods in the global namespace not sure how that will work out with e.g Type.


Why do we need the extra new lines?


this didn't work -- settings need to be added to `public_interface/context_processors.py` to be able to pass them in as settings.  I'll take care of it.


1. Will fix.
2. it was the only way I could figure out to get rid of an annoying warning in my intellij


Ahh, that makes more sense. I didn't realize invitations were deleted. If the overall idea of the Invite object is just a temporary token & email address then it probably makes sense to keep it that way.

The reason I'm sort of focusing on this piece is that the person using this form is putting data into it, and then if they come back to look at it later some of that data has vanished mysteriously. And I could see that being jarring or unexpected.

I mean, I think it's fine as is right now. As you say, the people who disappear from the invite list end up on the orders list, so nothing is truly being lost. Also, it probably makes sense to not put too much effort into this feature unless people are clamoring for more transparent reporting.

But! That being said, I had some ideas that might be improvements while also being minimally invasive (but also are totally outside the scope of this issue).

1. Make orders know whether they are the result of an invite. Then you can still list who has ordered alongside the outstanding invites.
2. Have some kind of Event Feed on the summary page that lists new happenings like people ordering. Then it's possibly more obvious what's going on with the invites that are sent out.
3. Put the form to send new invites (and the list of outstanding ones) and the attendees/order list in the same place. Conceptually these are related to each other and then it's easy to see when invites move between lists. This idea is kind of along the same lines of what @harrislapiroff said about having a separate form for event creation and event stuff in general. I could see having invites (which are an optional yet somewhat complicated feature) being off in its own little area.

So, just some ideas!

It might be possible to


changed


indeed it can. changed


I think we can remove all the methods.
They were added to avoid considering the parameters as tainted. Now that immutable type are ignored, these method with query as `String` will not cause problem.
I don't know if they serve a different purpose now...


my "push -f" succeeded, but with the changed HEAD, it put mc1100's 2 pushed down at the bottom, and mis-rebased others...


Also, this will end up with a double slash, maybe I should add a method to `item` that computes the URL with `urlparse.urljoin`


Yes we do, it's the only way container can retrieve its sandbox. SandboxKey is not sufficient as many Sandbox can share the same sandbox key.


RoomAirflowNetwork (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1810 of 1810 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


this injects arrays into an array and will result in `[body, [..], [..]]`. Just checking if this was intentional, if not, perhaps replace `<<` with `+=`?

If the above is the case, you can simplify this to look like:
```ruby
parts = [body]
parts += Array(nodes).map { |node| "#{node.kind}: #{node.title} \n\n #{node.body}" }
```


Yeah, you'll need to use the hardcode-fixer to correct the app icons :) In the [latest commit](https://github.com/Foggalong/hardcode-fixer/commit/c4b3293b29378f5bb1230916a88ef6fe0dd27426) I've added fixes for both of them. To use the script just do the following:

```bash
wget https://raw.githubusercontent.com/Foggalong/hardcode-fixer/master/fix.sh
sudo bash fix.sh
```


Webpage


awesome, great job


If you guys think it is better  to remove it, I am not against it. I can remove it,


The dist directory seems not up to date. The #930 have been merged before this tag but the `$cordovaLocalNotification` mock is not available


I'm curious about that too. The place I added is the one I saw the kernel actually look at.


You  mean to immediately replace the existing `Connection` object in the `ConnectionStore` with a newly instantiated one?


And there too ? https://github.com/Wisembly/tapestry/commit/25ac6df6e49e923b07aed8fa04b53270c2606301#diff-2f8b2e5e5622fb52fa1e32fda597a230R1673
:crown:


I've gotten a cross-compile VM set up.  I notice two things:

First, I get a warning for each source file that `-fPIC` will be ignored because PIC is the default for the Windows target architecture.  I don't know how to exclude this flag (in `configure.ac`?) for only the Windows target.

Secondly, we are not linking `gregorio-resources.rc` and `gregorio.ico` into `gregorio.exe` in the first place.  I can modify the scripts to do so, but I can't test the resulting executable.  Should I make this change?


Javadoc explaing what this class does/ what its responsibilities are.


Readme


4952-FixBranchAgain (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (761 of 761 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.43%25-green.svg)


1706-ThermostatDualSP (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Do an empty string as encoding and None mean the same thing? Can I convert `None` to an empty string?

ie:
```python
>>> x.encoding = None
>>> x.encoding
''
```


Why do you need to use `setattr` here?


@gontard That's interesting. We have another build coming out soon, so I'll generate an up-to-date one for this version as well.


I needed when debugging. Forgot to remove it. Thanks.


They were handled in the sense that the library didn't crash and returned the generic message `OCaml callback raised an exception`.  However, there was not a mechanism to say how or what went wrong like `sqlite3_result_error` generally allows.  I still contend that this feedback is very important otherwise there's no way to tell the user which function failed and why on a complicated query.


Are you sure title assignation in any of the initializers is not used to do anything fancy, e.g. to generate a slug or similar? It's just odd to me that title used to be assigned explicitly before. Worth double-checking :)


:laughing:


I believe this is already handled by a commit of the same pull request:

https://github.com/vintasoftware/ably-python/commit/90b116d6d264280c886a293469e7a338924ebd08


Thanks. For consistency with the rest of my code, could you please change it to this:

    options = (!options || _.isFunction(options)) ? {} : options;


This toolbar not attach anywhere.


Well, we still don't use the comprehension, but removing it was my first thought too, so I can amend the commit.


Waf is distributed, that's why the build depends on Python being installed.


why not using your atOffset function


yes, those work for me.  Those are generated makefiles, but they have all
the information I need to create a nice readable version.  There are some
includes missing in what you sent, so I assume they are in your directory
tree.

there are a number of make fragments scattered throughout.  namely

src/utility/subdir.mk

src/test/subdir.mk

src/nrf/subdir.mk

src/modules/subdir.mk

src/mesh/subdir.mk

src/base/subdir.mk

src/subdir.mk

subdir.mk

../makefile.init

../makefile.defs

if the subdir.mk files are deleted along the way thats ok, I have most of
what I need for those steps anyway.  I could use the makefile.init, and
makefile.defs though.  Do you see those?

Thanks,

Tim

On Wed, Sep 2, 2015 at 2:41 AM, Marius Heil <notifications@github.com>
wrote:

> Hi,
>
> I've just had a look at the Debug folder and found some generated
> makefiles in there, they might help you. If they work for you, I'll add
> them to the repository.
>
> http://www97.zippyshare.com/v/QvwzxkIR/file.html
>
> Marius
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mwaylabs/fruitymesh/commit/45b932a0c7eb9fff6bd907b235e3e903abf027fc#commitcomment-13016766>
> .
>


`.ModalHeader-btn` pour rester consistent ?


Test Commit Comment


I admit I don't know what's the best way to deal with the flags... about gregorio-resources.rc, do you have windres? (on my system it's `i586-mingw32msvc-windres`) Do you mean that the test for it in `configure.ac` is wrong?


Why did you use the `GetSetMethodNormalizer ` and not the `PropertyNormalizer` here?


Nice work!


prueba comentario


I already return an error in NewSandbox() if a Sandbox for that contaienr ID already exists, but internally it does the same thing.

But how would it help here ?
Here I need to build the option and attempt a create. Assume the create fails because already exist. Then I have again to walk to retrieve that existing Sandbox.

If you guys think it helps readability (and merge-ability...) we can add a API in Controller `SandboxByCID(string)` though I do not like it. This way we can handle the future performance improvements in libnetwork.


This causes failure in FreeBSD. SaltStack configuration files are stored in `/usr/local/etc/salt/`, just as all other configuration files not included in the base OS. The only OS-specific check is for Windows. The `else` condition needs to be an `else if` or a series of `else if`s with conditions for each operating system that Vagrant claims support for.


Is there a particular reason why newWord is public? Generally speaking its not usually a good idea. This variables represent the state of the object, if this is public other classes can change the state with no control from this class, which depending on how this is used could cause issues. If this was made private and you had a getter/setter method for this you can control how other classes interact with the state of the hangman model.


Will do. Are there any guidelines for picking the IDs or should I just start from the middle of an unused range?


Fixed #14


We don't need it. It was like this in one of the pentaho projects. I pasted this here and didn't revisit this properties afterwards. Should we keep only the full version then?


method level javadoc needed


Wouldn't this better fit into the new `CRepositoryUpdater` as well?


I think those exceptions you see are just ones that are inside a try/catch somewhere in the entityframework dll.  They went away when I turned off "Exception Messages" in debug output options

![image](https://cloud.githubusercontent.com/assets/2430748/9637037/6044511a-5153-11e5-871d-1241b83d12c0.png)


Gracias,  se me fueron.


Also, note that Microsoft Edge truncates the window title to the hostname if `document.title` contains only a URL ( e.g. `document.title = http://localhost:1337/page` gives `localhost` in the window title).

So, you need to add some characters before the URL in order to bring it to the window title.


same as previous comment


And it seems ANTLR Tokens have the same behavior; a token of length 1 has the same `startIndex` and `stopIndex`.


It seems the intent here is to use a larger type to hold a smaller type, I'd recommend using int64_t instead since JACK appears to define jack_nframes_t as a uint32_t.  long is not guaranteed by the C standard to hold anything larger than a 32-bit value.  long long on the other hand probably would be large enough to guarantee this, but since they are using sized types, I'd probably go with int64_t.


Creo que tengo problemas con continúa :P, gracias por las correcciones.


Yup. In retrospect, I should've made this into a PR instead of just throwing it on master...

The advice I got in the last JSoC meeting was to just manually inline things that weren't auto-inlining, since Base's inlining heuristics frequently change and shouldn't necessarily be relied upon for performance-critical code.

See commit 03bfa6bc43c37846c9bd218446b4aa1fdcb00607 for the most relevant changes. The performance problems were fixed once I inlined `Tuple`-related code and the arithmetic code that calls `Partials`-related methods.


Microsoft Edge truncates the window title to the hostname if `document.title` contains only a URL.
So, you need to add some characters before the URL in order to bring it to the window title.


testing comment


Should have space both sides of `+`, right?