We're cranking up the warning levels on our code base and the extra prototype triggers `-Wredundant-decls` warnings. What about `SUITE_EXTERN(NAME);` instead of `_DECL`?

(Actual patch written by my co-worker Mark who doesn't have a GitHub account. :+1: )


Hey, @djfarrelly! I've made a couple of commits today highlighting a few changes I've made to the overall namespacing as well as starting to flesh out a few of the components a little more. :) I've been working on designs for HQ a lot lately and it spurred me on to move forward and continue work on the Style Guide! :D I think we might be at a point now where it makes sense to start building out more React components for things such as headers, buttons, etc. and I'm more than happy to jump in and do this if your bandwidth is a little stretched! Perhaps it's worth having a sync-up on this? :)


Open up separate issue as I expect this will be discussed a lot. Want to merge this one quickly as it has no side-effects nor design changes.


To be fair, at the moment the way the API is designed we are not getting the output of the process before it is terminated, so that ingest app wouldn't be able to stream any results back to the caller in any case at the moment. However, if we're talking about an ingest app here I would suggest that given the current API the win32 workaround is actually the better solution since the output is flushed to disk instead of kept in memory.


Почему пустой?
Label - блочный элемент?


so we should restart here for now?


typo, register


Why not simply

    [[$docReference.name>>$docName]]

?


`xr` ? what about `deadlog` ?


Yes, I think we can live without it (at this place and the other two occurrences). Same holds true for the check at the server side, right?


Great, thanks!


that if GetElementData is not by me, it's how it came with slothbot.


@YannRobert unfortunately the order is important when two values are interdependent. How would you suggest should the setters work for your test case to pass?


I like the concept of wrapping several operations in a single log. Would be a good place to add an operation identifier that's added to all logs in this function, for tracking.


Here it is, L


Tu peux aussi dire : bien loin des allégations rabat-joie telles que "c'est la crise..."


Although I would agree that a better name is setShutdownWrappedOrb


right. I remove this (server side too)


C'est vrai c'est assez génial Git-Up !


INTEGRATION TESTING_2015-09-21 15:45:42


INTEGRATION TESTING_2015-09-21 15:45:45


@SubJunk I'm sorry I didn't come back on this sooner - I don't think it's an issue anymore as I rewrote the code that failed when compiled as Java8.


```<joke>```Would be too easy? :)```</joke>```

Fixing... Thanks!


Hey, das sieht doch schonmal ganz gut aus


Don't know what I was thinking, thanks for pointing it out.


Caught me copy pasting, didn't you?


I might have missed something. Is this schedule to run regularly to do cleanup, or one time thing at startup?


we should rather add optional param into `base.download_packages` to don't add pkgs into tempfiles. There should be change just in DNF.


增加weight欄位


done reviewing 802843d


I personally find TimeUnit.MILLISECONDS.toNanos(...) more readable than using convert with fixed arguments.


Maybe you can play a bit with the fractional part to perfectly align it. Since the logo and the header pictures are the nearly the same height this should do it.


It is good practice to quote variables like: `test "$var" = "yes"`


It seems this commit revert previous one (65707be09ad657e71cadb14fad79d74ed2f94506) in addition to is_visible feature for dropdown.

I don't chery-pic and redo completly (authorship will not be keeped)


The unicoded string should be already in DownloadError. Convert it in DNF, please.


А, теперь вижу. Просто форматирование не очень и поэтому показалось, что это один тег с пустой строкой строкой внутри.


INTEGRATION TESTING_2015-09-21 15:47:59


INTEGRATION TESTING_2015-09-21 15:48:02


Ok, once this is done I think we're good to go. Be my guest to re-base and commit on master then ... :-)


That nullifies my previous comment about expiry.


`const` ?


@SubJunk Please notify me when you're ready to tag, as I want to wait as long as possible to pull the translations from crowdin. This is because translations and corrections keep coming in, and I'd like to include as recent a version as possible.


Nice catch!


Sorry ... I stupidly commented on this in my own fork of Sigil. Not certain if you'll receive notification on it that way, so I'll place my question in the "proper" Sigil repo. ;)

Hey Kevin... just checking if you purposely made these changes to the PPluginWidget.ui form when you updated the Sigil documentation epub in this commit, or if something weird happened. I just noticed those symbols showing up in the Manage Plugin preferences widget the other day and tracked it down to this commit.


only 拿掉喔


By the way, I haven't seen anything complaining about it. Shouldn't this kind of check be enforced?


Are CQ_QUERY and CQ_LISTENER really any operations (used for statistics), or are those just identifiers for slaveState? And the CQ_ prefix seems to me superfluous.


groussac authored ???? i am dreaming..
Why ask to make PR if for you assign?
https://github.com/PrestaShop/PrestaShop/pull/3928
This is how you destroy the community spirit, guy...


Some of these checks aren't working correctly due to multi dimentional array being passed to isValidDomain method, i'm having a look into these now.


Would be great to get this published.


In that case, SUITE_EXTERN(NAME) sounds perfect. Would you mind retargeting the pull request at the develop branch? I'll merge it to master during the 1.1.0 release.

I'm going to be traveling this week, so apologies in advance if I don't get things merged in punctually.


Baita iniciativa @iagodahlem

Sugiro que você e outros colegas elaborem mais este documento aperfeiçoando a sintaxe Markdown dele. Existem vários editores online de markdown por sinal, tipo o dilliger:

http://dillinger.io/

:+1: :+1: :+1:


done reviewing c741cb3


@valib I've notified you on crowdin that there's new strings that need Czech translation, but I don't know if you have notifications enabled there.


r+


Thank you @vahidshirvani :)


Ah, thought it's part of your own script. In that case, try and test it.


Oi @maxrib,

Pq vc comparou o nome com "Leprechaun" ?


r+
... but rebase--... all these should be one commit for the review


A comment to explain that this is equivalent to:
```c
if (parallel_filter.input_subspace.offset <= dim &&
    dim < parallel_filter.input_subspace.offset + parallel_filter.input_subspace.n_dims)
```

would be good.


No unit test ?


What a pity!


It's the file name, without the path, of the report generated on the server. Currently, the Web UI uses this file name as "suggestion" for the end user. Should I mention this Web UI behavior on this description here? Or just specify where this value come from ?


If the Query is reused in multiple traits, it probably shouldn't be inner interface anymore.


@grayjay  We faced this twice already in [2489](https://github.com/haskell/cabal/issues/2489) and [2398](https://github.com/haskell/cabal/issues/2398), but my memory is foggy right now. Let me double-check; but I think `createProcess` does block if not compiled with `-threaded`.


Interesting!

You should also additionally test for own pieces/pawns which block the king in line 697 to cover more cases.

if (!(ei.attackedBy[stm][KING] & ~(ei.attackedBy[~stm][ALL_PIECES] | pos.pieces(stm))))


propose: `"%v %.0f  fetched results from %v commands", r.EntityName, r.Action.ID, len(results)`


Essa abordagem de criar `setQuantidade` é perigosa, pois aí estamos permitindo a mudança da quantidade para qualquer valor só pq em algum momento essa quantidade pode aumentar 1000. EU prefiro a abordagem de criar um método no item que aumenta a quantidade para 1000, de forma fixa.


Isso


Also, I think that you should add another argument specifying the cache name (null for default) to enable CQs on non-default caches.


you're welcome :) will update the `podspec` shortly


Hm also ich cha no beliebig viel expens-items hinzuefüege ohni irgendem error...? wo wird denn die exception genau gworfe (welli zile)? und wie gseht s'date value us?


Hi,

Loool, I did the job for you as you did not make your PR on the good branch and you do not ssem to react or understand.

Shoudl I revert your PR then ?

LOL


Shouldn't it be different WWNs than in pv-1.yaml?


thanks I have removed it @jsor


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8322/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20975/testReport/) for this commit**


We prefer two step converting to save git history:
1) rename *.java -> *.kt & commit
2) convert java to kotlin & commit


Ah thanks.. I'll look into it. That part was hard to solve, indeed nobody seemed very sure on how to do it...


Даже вот так Collections.<GrantedAuthority>emptySet();


Да-да, я так делал в другом проекте. Здесь не стал из-за простоты приложения.


We so far followed the unwritten rule that global variables directly parsed out of command line arguments is usually prefixed with the "arg_" prefix... We should do that here too, I guess.


@amar59 DWMR. Thank you for the sustained effort.


Какая-то IDE на автомате так делает.


Done. BTW there already was similar PR like this in previous version - https://github.com/este/este/pull/405


This treatment of phi-Nodes is slightly wrong (in weird corner-cases). The issue is that all phi-instructions at the beginning of a block are meant to be executed simultaneously. Here's an example that illustrates the problem:
```
he@aristophanes:/tmp$ cat foo.c
int nondet();

int main() {
        int a = nondet();
        int b = nondet();
        int c = b;
        while (nondet()) {
                b = a;
                a = c;
                c = b;
        }
        return a + b;
}
he@aristophanes:/tmp$ /usr/bin/clang -emit-llvm -O0 foo.c -S -o foo.bc
he@aristophanes:/tmp$ /usr/bin/opt -sroa -constprop -instcombine -gvn foo.bc -S
; ModuleID = 'foo.bc'
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
target triple = "x86_64-pc-linux-gnu"

; Function Attrs: nounwind uwtable
define i32 @main() #0 {
  %1 = call i32 (...)* @nondet() #2
  %2 = call i32 (...)* @nondet() #2
  br label %3

; <label>:3                                       ; preds = %6, %0
  %a.0 = phi i32 [ %1, %0 ], [ %c.0, %6 ]
  %b.0 = phi i32 [ %2, %0 ], [ %a.0, %6 ]
  %c.0 = phi i32 [ %2, %0 ], [ %a.0, %6 ]
  %4 = call i32 (...)* @nondet() #2
  %5 = icmp eq i32 %4, 0
  br i1 %5, label %7, label %6

; <label>:6                                       ; preds = %3
  br label %3

; <label>:7                                       ; preds = %3
  %8 = add nsw i32 %a.0, %b.0
  ret i32 %8
}

declare i32 @nondet(...) #1
[...]
```
Note the following two lines:
```
  %a.0 = phi i32 [ %1, %0 ], [ %c.0, %6 ]
  %b.0 = phi i32 [ %2, %0 ], [ %a.0, %6 ]
```
Here, %b.0 should be assigned the value of %a.0 that it had when coming into the block, not the one that was "just" assigned.
To achieve this parallel assignment, we could assign the fresh values to %var__temp (not touching the actual program vars) for all phi instructions, and then add a set of %var := %var__temp instructions. T2 should then be able to simplify these things when parsing it.


Why we need to remove it from DOM?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20976/testReport/) for this commit**


@hpatoio

:+1:


Bai, I think you may want to e-mail to TP Coord *and* zh_CN Coord to get your name on the team member list so you can send them yourself.


oui hein :+1:

**PS: c'est GitHub :octocat: **


Any special reason for sorting by "Description"? It may take more time than sorting by "Name" or "ManagedBy".


Path should always contain at least one slash, so it's `../hammerhead/


Simply using *PostScript 1* is acceptable and probably more fluent, since Adobe remove the word *level* for simplicity in PostScript 3.


Arch\* means Architecture paper sizes; consider 建筑。


What is the point of this?


Comment on 5e600fd


so I am going to move one scale and add another (otherwise I can not make a
standard mbox.)

and add one more transform and test it.

BTW The toolbar function is very helpful when testing the layout.

On Tue, Sep 22, 2015 at 12:20 AM, carbuncle grim <mclarekin@gmail.com>
wrote:

> So what we have is  a mandelbox extended with :
>
> menger sponge
> spherical offset
> box offset
> rotation2 relocated
> relocated scale to follow spherical offset
>
> so it works as a fully functioning mandelbox set-up when the menger
> sponges are not enabled.
>
>
> cheers
>
>
>
>
> On Mon, Sep 21, 2015 at 5:01 PM, carbuncle grim <mclarekin@gmail.com>
> wrote:
>
>> added in Spherical offset  (works as expected )
>>
>> added in DE calc for scale (it seems to work well, I do not fully
>> understand the maths???)
>>
>> added in DE adjustment for spherical fold (seems to work)
>>
>> will try two more new transforms then will probably call Menger Sponge -
>> Extended completed.
>>
>> Cheers
>>
>>
>>
>>
>> On Mon, Sep 21, 2015 at 1:06 AM, carbuncle grim <mclarekin@gmail.com>
>> wrote:
>>
>>> Nice image.
>>>
>>> On Mon, Sep 21, 2015 at 12:42 AM, Krzysztof Marczak <
>>> notifications@github.com> wrote:
>>>
>>>> Nice formula
>>>> [image: extended_mandelbox_001]
>>>> <https://cloud.githubusercontent.com/assets/11696990/9980779/bbb63f1c-5fa5-11e5-9f32-b002ee6fe645.jpg>
>>>>
>>>> —
>>>> Reply to this email directly or view it on GitHub
>>>> <https://github.com/buddhi1980/mandelbulber2/commit/939d835f6cbff3c7be2d1e13c16089ff31ab4c5e#commitcomment-13329393>
>>>> .
>>>>
>>>
>>>
>>
>


I forgot to fix it before push the code. I'll refactor. Thanks for pointing it out.


Ah tks will remove that.


Yeah, certain things need descriptions, but some don't. I have been setting those that don't need them as empty strings, but I missed one or two.


Single line while block without {} please...

Also, and more importantly, you keep closing the same fd here over and over and over gain...


In fact, what is the need to add a "is_visible" field in dropdown.
I don't understand the feature


爱普生相纸（定页撕纸），似乎叫这个，Google 一下看看吧。


Because after parsing the meta becomes unnecessary.


use `p->fd = mfree(p->fds)` here...


long time no see, @hoholee12 lol thats alot of deleting, i dont think the script will run properly ;-;


Consider 灰。The char 色 brings extra redundancy.


Since `ContentCharset` now is not just a bunch of utility methods it has nothing to do with the utils and should be moved to `pipeline` I guess.


e.g., from 'E' to 'A'


Je nachdem öb d'signatur ahzeigt wird oder nid isch showSignature false/true.


Reword needed.


im alive too :3


'A' through 'E'


this was fixed and pulled last week. why do we still discuss it?


I think we should turn off wrapping in POEdit.


Hey, can you publish this to Atmosphere? :smile:


done reviewing 0ba9cb9


(where no symbol means no update was made)


Duplicate spaces in msgid! Suggesting bug report.


r+


It can be named just `charset` since it's in the `contentInfo` object


These schemas are used solely by jsonschema2pojo-maven-plugin. They are not directly used at runtime. This `required` declaration is rather for docs purposes.


With Markdown you have to be careful, removing all the trailing spaces removes the intended line breaks.


Two-spaces probably need to remain


Have you ever tested only add #engineList treechildren but not #blocklistsTree treechildren? I think this will work for 43- versions.


How about 灰阶? I don't have much training data for this.


Two-space remains


recommend `0700`, some actions might contain sensitive stuff


Two-space remains for all these lines


just challenging a bit the name : sslr-testing-harness is an existing artifact. Not sure testkit is really that great...


Maybe the bug occurs because this commit check all `<script>` tags of the document not only the one inside the `<body>` tag:

[`document.body.querySelectorAll(selector)`](https://github.com/rails/turbolinks/commit/fba3ed6d04278ff964630886d544a47b9ee64af2#diff-e22d8501903061f6a402898e881d83cdL211) was replaced by [`document.querySelectorAll(selector)`](https://github.com/rails/turbolinks/commit/fba3ed6d04278ff964630886d544a47b9ee64af2#diff-e22d8501903061f6a402898e881d83cdR211).


Keep trailing spaces


Why provided ?


Hmm, why keep `fd` separate outside of `fds`? Why not just make it the first element of the array?

If we keep multiple fds here, wouldn't it maybe make sense to store them in an `FDSet` object, that we already use for purposes like this elsewhere? Might be nicer to use than an fd array...

If there are really reasons to keep the one configured fd separate from the other ones, I'd prefer if we'd make this clear in the naming, i.e. rename `fds` to `auxiliary_fds` or so?


Here and in all other places: using `charset` instead of `contentCharset` is just fine


Keep two trailing spaces


new SimpleStackElementFactory... -> static class


This commented code is left here for a specific reason?


You're not using any method from the mixin so it's not needed anymore. Just add `isLoading: false` as a safe default.


**EDIT**: Let's use `charsetDescriptor` instead


I merely rebased an old branch.
To see if the change is still worth it.
Or do you already think it's good?
Then I'll change it and open a PR.


as this is not standard at all, it requires ever a big readme to document it in this project, and/or (better IMO) something configurable when instantiating the JavaCheckVerifier (with a default value eventually... )


what about adding a function of the runner results struct to write it to a target location?
`rr.ToFile(path)`
`rr.FromFile(path)`


This fixes a bug introduced in an earlier patch, might be better to not introduce the error in the first patch...


SiCKRAGETV/sickrage-issues/issues/2477
Hey @jonathanendersby I found it!


I think you can come up with a slightly less generic commit comment ;)


`rr.Remove()` ?


consider using `_cleanup_close_` for the fd, like we usually do...


Ибо <strike>заебало</strike> надоело


**EDIT**: Let's rename it to `ResourceCharset`


This must be initialized to NULL, otherwise will explode if we exit early with ent never initalized.


ltns to you too @DiamondBond xD

trust me it will run just fine
'it' == errors xDD


一直在用，谢谢


as the `out:` label just does `return r` anyway, we might just want to do that directly here...


OK, that maybe explain. The workflow has been reinjected on Monday, while the fix came on Tuesday. Sorry, I miss this merge PR.


On 2015-09-21 05:38:29 -0700, Michael Schroeder wrote:
> But should "/foo/@nonexistent" really evaluate to true?
>
No, but "/foo/@existent or /foo/@nonexistent" (the "or" is
the xpath or operator) should return true.
"/foo/@nonexistent" still returns an empty node set/"false" :)


yay all three are alive :3


Instead of monitoring a specific reslist, you could just to this stateless but walking the `inflight` directory.


a comment from amanda :dancer:


you want to return `-errno` here, not the return value of `scandir()`


It is a custom widget based off the button widget.  I couldn't get a native HTML toggle widget to style like the rest of the buttons, probably simply my ignorance of CSS, so for the time being I recreated a new widget.  https://github.com/roma0104/gsd5/blob/master/plugins/gsd5/core/modules/widgets/toggle-button.js

I have been working somewhat on some documentation but it has been a crazy last six months.  I haven't scheduled time to sit down and work on GSD5 like I want.  It is my plan to start devoting some more time to it soon.


didn't add the code but I guess it's to remember the currrent working dir before changing it. ```pushd /var/lib/rabbitmq``` would be clearer I guess.


Add new line before comment


ep is leaked here on failure...


if that happens, should the action be processed at all? isn't there a risk to process an action twice?


Use new lines to separate object and array properties to achieve better formatting.


I don't like this implementation. It assumes way too much


havent been in irc for quite a time now too xD
i got my new macbook over a month ago btw xDD ;-:


Just a NIT, but is this ever possible, and if so should we perhaps display it anyway (the other fields may have values) ?


Great catch @tortuetorche! Thanks.

Fixed by eac0a3e43a69b341abdd55ef1bc45d1d4cfaf8a9.


Since we have a class now, make them `static` methods


`checkBOM` for what?


hehe, yeah. Does nothing for my score ;)


Esto no va a cuadrar con el EDIT porque cuando vuelva tendremos que interpretarlo. Hay que hacerlo en el componente de la tabla.


Also, k should only be incremented after `ffs_address_create()` returns successfully, otherwise we might end closing an uninitialized fd...


We don't use underline notation for the class fields


`setCharset`


`getCharset`


Dear Shaoguang Guo,

The current version is now v0.9, but we are testing it internally before releasing it to the rest of the world.  Please note that it is not intended for VLBI data, it is very specific to e-MERLIN data due to the way our observations are performed and how our data files are written.

Best regards,
Megan


Oops!  Of course you guys are right.  These are the same thing.  (I'm
assuming here that \sigma is known.)

There has been a pervasive typo throughout our spacing paper (probably
initiated by me) that squares the norm in the denominator of the
orthogonalized variable in question.  But this square shouldn't be there.

SORRY GUYS!

I've gone ahead and erased the mode argument for FS, and pushed.  (Fixed
the man docs too.)  A few notes

- Now normalize=TRUE has no purpose in fs(), since it is already scale
invariant.  I've kept this option, just for consistency with other
functions, but explained this in the man files.

- Sometimes the current fs() does not match Trevor's lars() function with
type="step", though it does seem to always match the return value of my
dad's old function, and Josh's function with groups of size 1.  So what is
the lars() function implementing???

- We need to resubmit to CRAN again ... sorry dad.  I guess we can do this
in coordination with Josh's group functionality.

- Jon: vreg is the v that gives you regression coefficients at each step of
the path, for the variable to enter.  Its purpose is explained in the man
doc, under the return value for the fs() function.

On Mon, Sep 21, 2015 at 3:25 AM, jonathan-taylor <notifications@github.com>
wrote:

> Can you tell us what I should think of when I read vreg? More expressive
> variable names can help people reading the code, at least it helps me.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/selective-inference/R-software/commit/08fb66fe32b06acee642e695e1e4d0cc369a380c#commitcomment-13335349>
> .
>


Just be more polite in error messages and I will be ok with that commit :-)


done reviewing 64345fa


i think it would be a good idea to make ep a variable declared inside the `for()` loop and marked with `_cleanup_free_` so that we don't have to take care of freeing...


By setting a fixed `max_age` don't we risk that a browser is using an old version of a document even though a newer is available? Wouldn't it make more sense to use `etag` (e.g. the version number) and/or `last-modified`?


use `mfree()`...


*DNSRBLHandler* was not initialize, then this assertion was not good as we were checking the *AuthRequiredToRelayRcptHook* handler, not the expected one described in the test name.


isn't this the same as not having a plugin to parse the results?


First of all, we already have a built-in json marshaling support.
Second, assuming there's some issue you can across which cannot be solved, you shouldn't create the mapper more than once.


1: M111 unrecognized component name: dojson


no added, already fixed in 0.83/bugfixes and master


Bitte nutze vernümpftige Namen für deine Commit messages


@published_surveys …まあいいかなあ


why change the type here?


Is this in use?


> I did not know this either. Is this feature already documented somewhere?

I'd say the GUI is the preferable way to show how cfg files work. I want to show all options and features there. It is currently possible to add configuration for std::string::find.. but I think the user has to guess how it's done.


Hmm, ok. merging. Lets see what breaks ;)


spuriosu whitespace change...


`isFromBOM`


`parseCharsetFromBOM` - > `fromBOM`


`fromContentType`


Do I get this right? if only one setting is specified, this should be considered an error?

if so, i think we there should be an explicit check in `service_verify()` with a warning printed...


`fromURL`


I do understand that tests are usually more verbose than the code but hey here we have a fix of 3 lines for 50+ lines of test.  So just maybe I am in my right to frown just a bit ;-)


`fromMeta`


Remove it please


インスタンス変数にする必要あったっけ？


为什么不做成static+extern函数的形式。。。


No hay problema. Pasenlo donde consieren. Otra pregunta que tengo sobre el codigo, no seria mejor tener una clase map extendiendo chart? Veo varios metodos mas tipicos de un mapa, que se mezclan con los otros y confunden.


Since you can't extend nested selectors in Sass, I created a placeholder with the tooltip styles that I could extend to both instances of the service-description class (one in the desktop view and one in the mobile view) so that none of the styles would have to be repeated. Is there an easier way to go about doing this?


Nice Idea.
Btw i switch of Wither make block damage in the Overworld after Careface messed up the whole base.


Solid commit!


Sure ! :) It was error messages taken from goblint


We don't use functional expressions. `charsetTestFunc` -> `testCharset`, `callback` -> `done`


done


What does `charsetTestMatch` mean?


好吧。。。我看了神杀新框架，原来可以直接用tr()。。。


thanks


Perhaps this name is a little misleading?  What is the expected behavior if a non-LDAP security manager is enabled. For example htpasswd allows user authentication, but no other features.


No. Tenerlo en el mismo model permitiria cambiarte de un chart a un mapa por ejemplo. Eso hace que sigas teniendo las propiedades ahi.


Hi, api_base_path is used to populate the "basePath" of the returned swagger json. It's not currently used on the swagger front end but it could. Let me know if this is something you need and I will work on it.

Great to hear that this is useful to someone else :D, you can help by creating pull requests, features requests or event by spreading the word. I'm always happy to add new stuff that might solve other peoples issues.


`getExpectedStr`. BTW I find it quite hard to parse this method. Please, refactor it.


It's `noop`. Search in other files how it defined


nil にならない？大丈夫？というのと、 |id| はなんか嫌だな


For debugging only. Have removed it.


Use full URL's instead of concatenation, e.g. see proxy test


It is used in ProtoCompareGenerated in order to normalize string tables for proto data.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20979/testReport/) for this commit**


`scriptTestFunc ` -> `testScriptEncoding`


I think this might be -Thine Thy ___- wish where the middle one might be -own-?


credit @JoeClarke12


remove spasces


Promisify request and use promises instead of nested callbacks (seems like you can test url in parallel).


changed names for consistency


Shouldn't this be set to the value in the request?


`testResourceCharset`


Pero ese es un esceario real ¿? Por ej ?

2015-09-21 10:25 GMT-03:00 Gastón Avila <notifications@github.com>:

> No. Tenerlo en el mismo model permitiria cambiarte de un chart a un mapa
> por ejemplo. Eso hace que sigas teniendo las propiedades ahi.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/datal-org/datal/commit/0d50b71aff90a501e8e3f4687c947d383a78906f#commitcomment-13342264>
> .
>


そもそもnewしてsaveする必要。createでいい感。

あと、一括登録できるといいって言ったけど嘘。
bulk insert するとコールバックとか働かないからいろいろと不都合が起きそう。
ここのcreateは頻繁に呼ばれるものではないから、answerの数だけcreateが呼ばれてもいい気がする。


ok, where is it?


done


I know that working on documentation, even if slim, will have a lot of things pop up too, so... take your time


nop, but a nice IT :)


It's should be move to the `charset` tests. And shouldn't we test other parsing scenarios, e.g. meta's?


ちょくちょく params[:user_id][:user_id] みたいなしっくりこないものを見るけど、paramsの形が気になる わかればいいっちゃいいけども


Right @rlaj, what say you? Would like to get this changed before anyone starts using it.


@benzonico Indeed, but I intend to squash all the commits from that PR eventually.


fixed issue #949 Sqlserver 解析如下语句出错 EXEC test_SP @P0 OUT
增加对参数类型的识别


@rfxn is there a good reason to use an absolut path for pidof? It maybe not installed in this path on all systems ... on Debian for example its "/bin/pidof"


I love ASCII art unit tests.


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


Just for completeness, I suggest 3 different timings instead of 2.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20980/testReport/) for this commit**


P. ej. El usuario decide cambiar un chart que es BAR chart por un mapa porque se lo pide su jefe. No necesita de esta forma cambiar los metadatos, solo cambia el tipo y la seleccion de datos.


s/Procedd/Process/


В очередной раз предлагаю открутить строковые команды, т.к. пользы от них никакой (это просто функционал "на всякий случай"), а геморроя много. Если они понадобятся, всегда можем их прикрутить.


Really sure? :D


suppression couleur du lien


I forgot to mention but it's fixed.


No special reason, low priority, only because its there !


This broke all the altcoints and other stuff:
http://hydra.nixos.org/build/26117023
http://hydra.nixos.org/build/26127256


Can you please raise that as well in your issue? My `native` Redux stack returns in that if statement and it works w/o any issues so I think we will need to switch it anyways.


Since buffer_len is checked before to decompress a buffer: https://github.com/glongo/suricata/blob/dev-decompress-swf-v1.2/src/detect-engine-hsbd.c#L331
Could be 0 there?


SqualeNewMeasuresVisitor -> SqaleNewMeasuresVisitor


fixed


es que no veo en la practica un cambio tan dramatico. es un caso borde que
nos ensucia el codigo.

2015-09-21 10:35 GMT-03:00 Gastón Avila <notifications@github.com>:

> P. ej. El usuario decide cambiar un chart que es BAR chart por un mapa
> porque se lo pide su jefe. No necesita de esta forma cambiar los metadatos,
> solo cambia el tipo y la seleccion de datos.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/datal-org/datal/commit/0d50b71aff90a501e8e3f4687c947d383a78906f#commitcomment-13342465>
> .
>


See https://getcomposer.org/doc/faqs/how-do-i-install-a-package-to-a-custom-path-for-my-framework.md


I vote for adding something like this to the message:
```
String msg = String.format("Could not export JDR on resource [%s]: %s", resourcePath, JBossASClient.getFailureDescription(opResp));
response.setMessage(msg);
```
You never know what the failure description will be like. The prefix should give the user some kind of a context that helps him to understand what op on which machine failed.


It turns out this actually didn't turn out too bad.


Well, the function is never called with own pieces (because then we would have to check that the pieces can't move either, and it would become too slow).

But you are right about own pawns, thanks !


:ok:


Could be better to return the buffer?


here it should be `(doub (fast-mult-recur a (halve b)))`


wut?


Minor quibble: there should be {} around this 1-line block.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20981/testReport/) for this commit**


in this stm32fx config file why is there reference to beagleboards and ti?


@rfxn you did remove the default docroots here. It there a reason for this? I'm using (and extending) this in my Debian package:  https://github.com/waja/maldetect/blob/7c040b951fa8e6e1216a2aafae153b23d4f5de39/debian/patches/0002-12_maldetect-cron.daily-documentroots.patch


Se debe devolver $resultado en la respuesta (se supone que $resultado ya contiene el código de estado al ser devuelto por el servicioOMMFCM), por lo que no tenemos que devolver un número en el controlador, sino el resultado que nos de el servicio


When thinking of it again, given that the operation can take tens of minutes, it could be practical to add the time when the request was received - just for the case that the user was not patient and killed the client and started a new one, not knowing which of the two parallel request failed.


Should these names indicate plural, ie OnUsersQuery ?


again beaglebone info in stm32 code.


s/resourcePath/resourceId/ and I'd agree with you :)


That method is... let's say nicely.. not very pretty.


The ssl issues(https://rollbar.com/phuibonhoa/Experts/items/5379/occurrences/7763961232/) that I was getting on the local machine were resolved by running
```
rvm reinstall 2.2.2 --disable-binary
```
see context in https://github.com/alexreisner/geocoder/issues/850


gumstix and beagleboard references


Este caso está bien, así deverían devolver el update y el destroy.


beagleboard reference


@DiamondBond heyy m8! So long time bro...
@hoholee12 such hipster lol


I'm not a maintainer so I can't publish. :) cc @Dignifiedquire


Cause I need to do that later on `data = RegistrationData.find_one(registration_id=registration.id, field_id=field.id)`


If this should be used as a "save as..." hint by the UI client, should it not be `response.setFileName(reportFile.getName());` ?


field (not feild) here and in code below


Thanks Tim!


I tried getting the right side of the footer to text-align left but because I used the footer li { text-align: right; } I am unable to force only the right part to the left. I will keep trying, but if any ideas come up, feel free to change the above.


Does this need to change with the # of uarts used or initialized?


@vladan-m I'm not sure how, but you managed to create this migration file while solving a merge conflict...


erro de nome do campo lbr_nfbmodel , corrigido no commit b4efdc0f70a39f701e7ae73c3cb5b5eeaabf3641


use portlet.xml


@meip Would you place this code in WP_SUAPI class? Or probably an own class around shortcodes?


Oh, I didn't thought about that! I Like the idea!


Thanks for working on this - I squashed your commits and added some more to wrap at 79 - wrapping is good but:

- 79 not 80
- better in a separate commit - as you did it blurs the transition from optparse to argparse which would be nice to have
- (mostly done) but because help was wrapping pretty thin I had to add a local method. Still a WIP

https://github.com/wrye-bash/wrye-bash/commits/200-argparse

I would like you to test this - see the TODOs in https://github.com/wrye-bash/wrye-bash/commit/fffa5866f3f2aac3f9f2bdc44d3a25bffe41c85e - cloning the branch in your repo would be the easiest way

Are you comfortable with git rebase ? Do you use Pycharm ?


Any chance of adding some documentation here?


It's actually tested there too: https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-tests/src/test/it/org/xwiki/administration/test/ui/CreatePageTest.java#L120-120


Dada a implementação desta classe, esse construtor é desnecessário.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1346 of 1346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.3%25-green.svg)


add the classes dir to your gitignore file


I've been out of the loop a while, but is KADM5_TL_DATA supported by all API versions? Do we need an ifdef check there?


yeah I know, that's why I added the TODO above :P I had to come up with something quick at that time and I added a note to reconsider and make sth better.


Thanks @evidens for going through these.


I'd perhaps use plural `attrs` here as it's set of attributes (labels/envs).


Any chance of adding some tests for the changes?


You can join the table explicitly and filter by it.
```
data = RegistrationData.find_one(RegistrationData.registration_id == registration.id,
                                 RegistrationFormFieldData.field_id == field_id,
                                 _join=RegistrationData.field_data)
```
If you are going to access `.field_data` in the code where you query it, also add `_eager=RegistrationData.field_data` to the `find_one()`.


Oh, okay. Sorry :)


just saying so we don't accidentally leave this around


начинается.... с этой штукой надо подробно разобраться. я считал, что другое возможно только на 16- разрядный системах, надо понять почему ассерт у тебя не выполнялся. Обязательно напомни мне в среду


why?
Implementation wise both seems to be correct, only difference seems to me is calling `doub` on the function will make this part of the tree, truly recursive (no chance of TCO).


I see it's already published, though.


LGTM


Perhaps the default type of {% button %} should be "button". Otherwise it becomes a submit button.


what differentiates recursive method from iterative method is preservation of state. here we are preserving the state.


changed to use the autofocus Z feature


the last three words of this line look like -find a tomb- the -f- in find looks like PBS's other -f-s elsewhere so I'm pretty sure about that word. The hard part is the beginning of the line...I would guess that it does start -I- but the second word looks like it begins with an -L- not an -h- looking at his handwriting.


To PRE.


If we change that then we should check where/how this is used.  I guess it is also used in some places where a button should be used?


To PRO.


But I agree - using "a" is the safer option, so also the better one.


I don't remember now – yes, must be like that - thank you!


Maybe also add `btn btn-default` as default class (if `undefined`)


Can you fix unlocalisation name tritainum_spine to tritanium_spine


Is it really necessary to include anything from swing? Seems like this JButton is not used here.


pyramid or pry amid? PBS doens't seem to have trouble connecting words when they should be (unfortunately for us because it makes his writing that much more difficult to read) which makes me think that there should be a space here.


Consider using CInterfaceOf template, to avoid double inheritance
class CSecItemIterator: public CInterfaceOf<ISecItemIterator>


Not needed if you user CInterfaceOf


Oh my. It was just an idea for a free new token. Cannot use it anyway I believe. There are not many Keyword:: users, but still.


Hi @phstc,

I create a PR because ``shipit -v`` print only Capistrano version. I'm on Ubuntu vivid 64bit.
#4375


Just like the extension, R# 10 postfix templates won't work without R# intellisense, right?


This seems to lead to an html form. Don't you have a public url to the vcs repository ? This is useful if people want to hack on the system e.g. by doing an `opam source menhir --dev-repo` or test current trunk with `opam pin add menhir --dev-repo`.


We really should do this the right way from the beginning.  Secrets should never be committed to git or pushed to public services, even temporarily.


-Rest thy bones-I think


Take a look at `0.13.10`


Thanks you, i will take a look at it later today.
Am 21.09.2015 2:29 nachm. schrieb "Matthias Krüger" <
notifications@github.com>:

> It's in the log:
>
> $ make checkcfg
> ./test/cfg/runtests.sh
> Checking test/cfg/posix.c...
> Checking test/cfg/gnu.c...
> ./test/cfg/std.c:15:19: fatal error: uchar.h: No such file or directory
> compilation terminated.
> make: *** [checkcfg] Error 1
> The command "make checkcfg" exited with 2.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/danmar/cppcheck/commit/3d0cc38d908b968c595613db1b93fa28906bd157#commitcomment-13340826>
> .
>


Can you elaborate on this decision?

I compared two things: current 0.8.1 internal approach (the one in this commit) and manual import. I see that 0.8.1 does +2 queries for every batch.


A malformed flash might cause FileGetFlashDecompressedLen to return 0, thats what I'm worried about.


@snicolet I would only return draw value, because a stalemate immediately ends the game.


Thanks!


minor, no need to use string.format here


This kills uwsgi discovery in the case of running uwsgi from a virtualenv without having activated it (which was possible earlier and should definitely be supported).

The earlier line

    uwsgi_executable = "{0}/uwsgi".format(os.path.dirname(sys.executable))

was totally fine and should be used again.


Interesting. I wonder why we don't see this problem with the other calls to py_exec...


Are you sure that if port is set to '0', mysqli change to 3306 ?
If parameter is not provided, i think so, but what about if parameter is provided to '0' ?


No, it is in the original pull-request xapi-project#2272: see the list of commits at https://github.com/xapi-project/xen-api/pull/2272/commits and the commit in the master branch: xapi-project/xen-api@0264a6ee7920838688b18c8ad87b1c4fd539729b

So it does seem to behave correctly without the type definition, but I think if we want to fix the ugliness we should do it by removing the obsolete power states from the `power_to_string` function (and while we're at it, settling on just one of `power_to_string` and `power_state_to_string` in `Record_util`, since one is just `String.lowercase` of the other.)


I think this should be exposed over some REST endpoint....


This does the opposite of fix the submodule. extras/ should be kept a submodule.
Also, you should not commit .map, .sym, or .o files.
I also have no idea why you have .asm~ files.


Okay, thanks. Was pushed shortly after my comment.


good idea to make this virtual


This was an implicit invitation that you can continue styling.


Sorry, missed the text. Please advise. "119 Извлечённая форма сигла не была найдена!" on ""119 Извлечённая форма сигнала не была найдена!" =)


No I have not. However, the extra code I added for a better alignment of the items text with the header would work with #blocklists and did not need the #engineList.  I think that is for elsewhere, unless we are taking about different tables!  I am referring to the table to "Change Block List" under the "Tracking" section in the "Privacy" options.  Perhaps this affects something else and I should make the selector to the other rule I added more specific to avoid an unexpected side effect elsewhere; the max-width for the #SelectionCol should probably only affect #blockListsTrees?!?!  Or I should add the other, I need to add another selector for the  rule regarding -moz-margin-start to include #engineList.


@jonludlam says:
> Why does the local case need to know the existing size at all. Can't we rely on the local-allocator's errors in the response?


Yes we can.


Fixes #24


“MIME type is definied as "text/html" or "content type," and it is noted in this reading that the web runs on MIME types.”

Close. For a web page, MIME type may be defined as a content type of ’text/html’ if the webpage is in HTML. An Audio file may have a MIME Type of ‘audio/mpeg3’, as that is the content type.


“There have been many times where I forgot the closing tag for my codes, and yet the web page was portrayed like normal.” I think that’s why XHTML was so unpopular. Because you sometimes can’t see when a webpage isn’t properly coded, a lot of the internet is ‘broken.’ I don’t want to lose a valuable, informative website simply because someone didn’t close a paragraph tag.

Is there any specific questions you have about this article? The group might be able to clarify.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20982/testReport/) for this commit**


Missing colon in commit message.


Yea I'll do this tonight. Sorry about the console log :/


:-1: No...


I'm not sure I understand this correctly, but shouldn't read permissions be enough to find a document?


just curious why this support was removed?


내가 실수함


Done.


Yes the 10*VAL_EPSx seems to be widely used to cope with rounding errors and
a practical precision. I didn't follow the comment regarding 1.E-10 being
"so low" when the new eps is much smaller.

10x faster is impressive.  How does it compare with the SLA SVD routines?


@serkanpektas the runtime feature to make this work isn't going to be fully ready by the time we ship v1.


Removing < is probably typo.
Or > should be removed too.


Yeah, just make a class for `.service-description` outside `.plan-breakdown` and `.plan-beakdown-mobile` with the shared styles, then override them as needed inside the mobile. Basically change `%service-decription` to `.service-description`, then remove the `.service-description` inside `.plan-breakdown` which has nothing but `@extend` anyways. Leave what is in the mobile one and it should be good.


As long as the script is called with a fully qualified path this is fine.


Ah, I was wondering why I hadn't noticed that notation before. Sorry about that.

Is there any particular reason we haven't moved to VS 2015 yet? Because I quite like a couple of C#v6's features.


no need to do this


I put it there as:
 1. if the server is TLS version intolerant, then it will print a lot of info, unrelated to previously printed information
 2. the PFS-sigalg scan also prints a lot of info that is unrelated to this


 I just checked with a hardcoded zero in my configuration file and got absolutely no connection problem. Of course, more testing is welcome to avoid any regression.
Do you think a default value of 3306 would be safer?


This added .DS_Store file from osx.


keep in mind that there are other 2 styles which need the change (polished, offwhite)


Nice pull request :+1:


trivial, but "== RF_RT_FILE_SCOPE_FILE" isn't needed here and in following


we should at least log something here


Awesome, thanks!

Made the change locally and will push the fix as soon as I get the updated tooltip content.


It might be worth asserting here. It is a developer error if this happens.


Working in C/C++ for XNAFileDialog has "spoiled" me.


This was supposed to be 8.5a version release


Fixed @ https://github.com/dittos/graphqllib/commit/526fb6015187d7863022217b30e1e76c1bbe9d74


copy and paste :laughing:

Yeah... it does not make you justice :stuck_out_tongue:


Thank you very much.

Regards Andrew

Sent from my big almost new phone.

> On 20 Sep 2015, at 20:34, Michael Gorski <notifications@github.com> wrote:
>
> I will take a look tomorrow and give you feedback
>
> —
> Reply to this email directly or view it on GitHub.
>


I have a method in my repository SchoolRepository annotated by @RepositoryRestResource
```
List<School> findByType(@Param("t") OUType type)
```
and call it like this
```
http://localhost:8080/api/school/search/findByType?t=3
```
parameter t converted to URI and in GenericConversionService
```
public Object convert(Object source, TypeDescriptor sourceType, TypeDescriptor targetType){
...
GenericConverter converter = getConverter(sourceType, targetType); // returns UriToEntityConverter
...
}
```
after that
```
public Object convert(Object source, TypeDescriptor sourceType, TypeDescriptor targetType)
```
throws ConversionFailedException because my uri lenght less than 2

is it correct?


Not sure if I understand your question,
scaled_dname_set_marker is a set of string, the element inside this set can be safely erased. There is no invalid pointer issue for this case.


One more thing: the call to `list` is not required here. The other modules are using it because of `get_paged`, which returns iterable that is not serializable by `json.dumps`.


It makes the normal output look ugly. Maybe we should tabulate the tolerance details, if any, to indicate they are related?


Noted. Will be corrected in next commit.


Yes, but we don't do anything with that class. We could have used void * but it's less type-safe.


It seems this code (see also line 112) can be extracted:
```
private fun String?.setOrClearProperty(propertyName: String) {
    if (this == null) {
        System.clearProperty(propertyName)
    }
    else {
        System.setProperty(propertyName, this)
    }
}
```


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1880 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Does it return the number of segments requested?


the crossed out word is -living-  clearly an edit since he then wrote -of living-


GroundDomainUpdate (mmatts) - x86_64-MacOS-10.9-clang: OK (1866 of 1875 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.svg)


pull


it can be fixed more easily by changing RIGHT_STRING_SIZE to 5 since now there might be a buffer overflow from the function that calls this function.


dfdgfdsfad


xvfvcx


Fixed now. Strange merge-behaviour that must have led to that.


test


Merged, thanks. (I changed `...(RhBug:11259650)` -> `(RhBug:1259650)`)


```php
$n = (int)Tools::getValue('n', Configuration::get('PS_PRODUCTS_PER_PAGE'));
```

should be

```php
$n = (int)Tools::getValue('n', $product_per_page);
```

right ?
Because this fix seems kinda useless in its current state.


IDE shows the following warning at this place:
Cannot resolve symbol `matchChecker`.


The absolute_import wasn't being used anywhere.


I think, this can be just "return argument;"


Oh gosh...I have no idea...I don't even know how many words are here...breaking it down letter by letter I get something like this:

Did_ _ _   pi_d  m_d_otre thu??!!?!


This throws a PHP notice because you never explicitly check if it's defined before trying to access it.

http://cl.ly/image/3l02080k2g1b


лучше писать вот так:
```javascript
if (imageHeight < imageWidth) {
    sizeValue.max = imageHeight;
}
else {
   sizeValue.max = imageWidth;
}
```
читать проще


should be `_x params ["_vehicle", "_hSCount"];`


Right, thanks for correcting.


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yes, so we can ignore the failure in the the case when the parameter of the error is `0` which will preserve the current idempotency but we will have some "wastage" in the unnecessary communication to/from the local-allocator. Maybe we don't care?


Static import


That's my bad. I accidentally ignored all falsey values. Can you add a bug
to the bugs list?
On Sep 20, 2015 6:22 PM, "Marius Kintel" <notifications@github.com> wrote:

> I'm still having problems with this, Example:
> { command: "PANEL-SET", data: {stripId: 0, panelId: 0, intensity: 0,
> color: "white"}}
> This creates "PANEL-SET white" - ignoring any falsey arguments.
>
> We could use default args, but then:
> { command: "PANEL-SET", data: {stripId: "[34]"}}
> ..would create something like "PANEL-SET [34] 0 0" which is not a valid
> regexp.
>
> See also buildDisk(), which ignores the DISK command sent from the Arduino
> causing us to swallow any DISK move commands.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/anyWareSculpture/sculpture-client/commit/5ca8863ec7d2bc90991ee320714cc13f3857b30d#commitcomment-13332210>
> .
>


I removed the mingw wrapper example in distro/windows too


**no-var**: Unexpected var, use let or const instead.


**no-unused-vars**: type is defined but never used


**no-unused-vars**: builder is defined but never used


**no-multi-spaces**: Multiple spaces found before 'require'.


**semi**: Missing semicolon.


Use `PrestoException(NOT_SUPPORTED)` since I think this is the error users will get when they try to write a struct


смотри - если оффсет задать размером с картинку и сайз тоже размером с картинку - то  в итоге изображение вывалится за край - надо чтобы сумма размера и смещения была меньше картинки

подумай как поправить :)


This shouldn't be undefined for you or anyone.

If you have a fix, pull requests are welcome.


Dear Jread,
       I run the Win32GLM on my win32 PC, and it works well. I think it's the problem with 'glm2.nml'. I will try again. Otherwise, there is other problems in modelling, hope to keep in touch with you always.
Best regards,


Hi, how is this being tested?


hmm, true, I basically always run with `--sigalg --curves` so didn't see that

lets continue in #99 since there's a bug in line below that needs fixing


See discussion on 2f23420c0712a743a358e805f5c0593c5186c96a which is an old version of the same change, from before I made a whitespace-only change to a preceding commit.


@ckunkel The demonstrations export code should be the same. Could you give me some more details on the issues?

I can also get reports via this url, http://dev-cbl.node0.slate.is/cbl/exports/competencies?students=section+ENG1-001&content-area=ELA. Could you send an example of one your hitting?


1: M111 unrecognized component name: tests


i think the length on the second volk_.*() call is wrong here.
Shouldn't it be:
    volk_32fc_32f_multiply_32fc(&dst[0], &in[offset], &d_window[offset], d_fft_size-offset);
?


If there is a need to log at debug level, you should wrap it in an if (log.isDebugEnabled()) {log.debug(...)}.
The same applies to the previous log.warn


For "low", read "high" :-)

I've been checking my stuff against the GSL SVD routine. I've not compared it to SLA, but it will be much faster as SLA is not multi-threaded.  My figure of "an order of magnitude" assumes you've got ~10 processors. On my 12 core machine, the CPU usage gets up to 1100 % in the new SVD code.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20983/testReport/) for this commit**


I think the second volk call is wrong.  See in-line note.


This should be extracted to a private method where it retrieves the scale


No. See my [comments here](https://github.com/x64dbg/x64dbg/issues/396#issuecomment-141792873).

The length of RIGHT_STRING_SIZE is fine, the problem is that the previous strcpy_s overwrite the whole buffer with 0xFD, meaning Rights[4] at line 436 is the only 0 termination, and it gets overwritten. Using another strcpy_s makes sure that

1.) it will be zero terminated and 2.) if somebody decides to reduce the size of RIGHTS_STRING_SIZE, it will not result in a buffer overflow, since strcpy_s makes sure it has enough room to fit the string and fails otherwise.


Instead of adding this comment, I would do something like this after line 59 (pseudocode):

    assert(split.length==3) // This should throw exception if the condition isn't met
    rowKey = split[0]
    columnFamily = split[1]
    qualifier = split[2]


goof are you trying to break rnd? also people can make this roundstart lock behid illegal tech 2


this one should also be extracted to a private method named according to what it's doing.


> "annoytation"

Is that a Freudian slip? ;)


lock behind illegal tech


This path is identical to another path. That's bad.


I've just submitted this my pull request which will probably conflict with this pull request.
> https://github.com/blackgate/bg-splitter/pull/20

I think scope.$broadcast makes more sense, because it's the children of the splitter that needs to handle the resizing - not the parents.. at least in my case.


mode not used.


Noted. Will be corrected in next commit.


-tombs-


would be nice to do the [!fileIdontWanttoInclude] in editorconfig


ご連絡ありがとうございます。ご指摘の件、承知しました。（失敗したのが、よりによって自己紹介だとものごっつはづいですね...）

2015年9月19日 19:00 Yuka Kato <notifications@github.com>:

> 今↑に書いてくださった内容を、そのまま /members/junna.md に追加して、コミットを作っていただければと思います [image:
> :pray:]
> （↑にやっていただいたのですと、ファイル自体には変更は加えられておらず、単に GitHub のしくみでコメントがつけられているだけなのです）
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/yochiyochirb/meetups/commit/0f2dcbd392146d4018f3ca281294bbe5b80ba6ec#commitcomment-13324465>
> .
>


I suggest introduce constant in CompileDaemon object:
```
private val LIMIT = 1 shl 30
```
and use it instead of 1073741824.


I agree, it is not good to break this, so maybe I should revert this
change until a solution is found.

On 9/21/15, Pavel Kalian <notifications@github.com> wrote:
> Sean...
> http://www.scratchpaper.com/ is where the Unicode NSIS lives.
> I'm not against moving forward with the version needed. But I have a little
> problem with the fact that after your changes there is basically no version
> available for a normal user that would work...
>
> Anyway, I will try to have a look at the problems visible in 3.0b2 and see
> if they can be fixed.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/OpenCPN/OpenCPN/commit/d6803862edd41043cfeb2c03f33098c8e021aa26#commitcomment-13340387


Can you clarify that this is a slowdown of 5-10% for this operation, but for a full model, it will be much less then that.


What if there are (theoretically) multiple providers for a given backend? This should iterate through provider names.


This commit breaks production for me. Before those changes, my log looked like this (the first line only appears once!):

    16:28:07 jobs.1 | ## Set TWITTER_OAUTH_KEY and TWITTER_OAUTH_SECRET in your environment to use Twitter Agents.
    16:28:07 jobs.1 | Twitter stream stopped ...
    16:29:07 jobs.1 | Queuing event propagation
    16:29:07 jobs.1 | Queuing schedule for every_1m
    [...]

now it looks like this for eternity:

    16:28:07 jobs.1 | ## Set TWITTER_OAUTH_KEY and TWITTER_OAUTH_SECRET in your environment to use Twitter Agents.
    16:29:07 jobs.1 | ## Set TWITTER_OAUTH_KEY and TWITTER_OAUTH_SECRET in your environment to use Twitter Agents.
    16:30:07 jobs.1 | ## Set TWITTER_OAUTH_KEY and TWITTER_OAUTH_SECRET in your environment to use Twitter Agents.
    16:31:07 jobs.1 | ## Set TWITTER_OAUTH_KEY and TWITTER_OAUTH_SECRET in your environment to use Twitter Agents.
    [...]


why remove the space?


Thanks for the clarification about `domain` vs grades!


I want a divorce....


other than that it looks pretty good.
+1


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.489.d0977ba58a6fc6fb1217ef8e9e5f5adc84f7f99e](http://build.palaso.org/viewLog.html?buildId=63504&buildTypeId=bt322) outcome was **UNKNOWN**
Summary: Canceled Build time: 00:00:03


maybe replace with https://docs.python.org/2/library/tempfile.html ?


Apparently, manually adding an effect  resolves this issue. For example
```
val foo2: unit -> Tot (unit -> unit)
let foo2 a b = ()
```
works.


Nitpicking mode On. Why is this line and the 3 following it not indented like the rest?


FIxed it.


Fix: This doesn't work


```
else
    throw cRuntimeError(...)
```


:+1:  David Mohs gave approval to merge


Other than the fact that the code should iterate through provider names for a given backend, the general idea looks good. Please make this little rework, thanks!


conning


PackageProvider.logger.info


This viewhelper didn't work with 6-2. Would be very nice if this feature works with 6-2.


For testing was needed change a time, it remembers filenames. Just forgot about whitespaces


Haha!


> Godeps/_workspace/src/k8s.io/kubernetes/pkg/kubelet/server.go:494: req.URL.Query.Get undefined (type func() url.Values has no field or method Get)

Looks like it should be `URL.Query().Get()`


That makes sense. I was confusing grade with domain, but changing the name is very simple.


Why don't you simply prepend your result to the comment string and save the custom draw code here


this is much broader than the algorithm actually needs, isn't it? Is this copied from in-tree somewhere?


Since this is pretty much an easter-egg feature I think it could be added in, like, the about dialog or something?


I don't see any unit tests. Are there any requirements/specs for this new code?


It seems this commented code can be deleted.


cambio


`         = nullptr`


jslint is a very outdated tool. It does not support even config files thus it is not possible to define a general code convention using it.


@davidfowl the IServerAddressesFeature is created in ServerFactory.Initialize, so this can't be moved any earlier without being moved into Initialize. The alternative is to move kestrel's default from Initialize to Start, but then it won't be observable to the app in Configure. I suggest moving this into the ServerFactory.


I don't really want to test this. Any objections to taking the algorithm as is?


@madhuracj With this commit, data.version is always empty in PMA_current_version(). Can you confirm?


I feel we should specify the form of the HBase dump a little bit more. I would add "The dump has a custom format (as exported from Info Space) and is enclosed in a sequence file."


We should talk about using a branch, other than master, for doing development.


ook


Hi Doug,

If you mean adding the Greater than or Equal to char (>=) symbol in from of the fields for setting the Plugin Engine, then yes, I added those when I thought we were going to go with Python 3.5 and wanted to make it clear that any Python 3 >= 3.4 should work here.  They appear just fine on my Mac.  If they mess anything up, please feel free to remove them.

Take care,

Kevin

On Sep 21, 2015, at 08:22 AM, Doug Massay <notifications@github.com> wrote:

Hey Kevin... just checking if you purposely made these changes to the PPluginWidget.ui form when you updated the documentation in this commit, or if something weird happened. I just noticed those symbols showing up in the Manage Plugin preferences widget the other day and tracked it down to this commit.
—
Reply to this email directly or view it on GitHub.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.510.d0977ba58a6fc6fb1217ef8e9e5f5adc84f7f99e](http://build.palaso.org/viewLog.html?buildId=63503&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:09:52


Just `self.form_items` will do the job. Explicit length checks if you just care for "not empty" are overkill. SQLAlchemy fetches the objects in the collection in any case.


Thanks for trying out `CSV#foreach` with `reduce`. It's likely I was making a simple mistake, but I wasn't able to successfully use `reduce` with `each_with_index` which is normally possible with enumerable collections.

Also `each_with_object` is :+1: I thought about using that here, but wasn't 100% sure about possible performance implications (I haven't dug into that with `each_with_object` and `reduce`), so opted to keep it as straightforward for this challenge. I do enjoy not having to return the object as the last statement in the block. Having to do so often feels awkward. Thanks for digging in and trying it out!


Why not just `was_regform_submitted`? It still sounds terrible buy not as bad as `was_user_registered_to_regform`


member variable among the member functions


I guess what they (Bloc) wanted you to do, was to implement a `Rating#update_rating` method that would actually do this:

``` ruby
# app/models/rating.rb
class Rating < ActiveRecord::Base
  # …

  def update_rating(rating_string)
    if rating
      rating = Rating.create(severity: rating_string)
    else
      rating.update_attributes(severity: rating_string)
    end
  end
end
```

And you would call it in the controller like this: `Rating.update_rating(params[:post][:rating])`.

That way, you wouldn't "clutter" the controller with code that's dealing with the attributes on a model.


Please create a new ticket...


An `has_ended` check would be nice... I think that case deserves a clearer message than "is closed".


"Registration is closed" sounds better IMO


What do you think @michielbdejong ? Our first specs? :)


This name was confusing when I first read it. How about `readTable`?


Is it safe to skip this step?


I believe I missed we already had the target ready.
I'll remove this and change instructions on the README file.


This is awesome! Thanks for making the change :+1:


This could be `OptionalInt`


throw cRuntimeError("Unknown gate");


Yes, that should fix the bug where we were sending in internal feed data
that the engine adds for the sole purpose of adding conversion rate
information for portfolio value calculations.

Unless there's something else here I'm missing?

-Michael

On Mon, Sep 21, 2015 at 4:38 AM, Stefano Raggi <notifications@github.com>
wrote:

> This commit
> <https://github.com/StefanoRaggi/Lean/commit/4799b363a3857df9f93ac5dcfe52786971609081>
> should fix the bug.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/QuantConnect/Lean/commit/f7d6ae6d5ef7fc7d7fc9b5468a3e63397fb417d4#commitcomment-13336515>
> .
>


I think you are correct. More importantly it looks like I didn't properly cover this if/else branch with my QA code additions. Nice catch!


The code above is basically an "update or create" logic. I believe there is a method named `update_or_create` in ActiveRecord, [but it's private](http://apidock.com/rails/ActiveRecord/Base/create_or_update) and not available in the public API. It's quite easy to implement one though:

``` ruby
# For instance, in app/models/rating.rb; one could also reopen ActiveRecord::Base and add it there.

def self.update_or_create(attributes)
  assign_or_new(attributes).save
end

private

def self.assign_or_new(attributes)
  obj = first || new
  obj.assign_attributes(attributes)
  obj
end
```


This is protection from the wither effect damage, not from wither projectiles


I *think* (it may have been a bad build) I saw an issue that should be impossible where we attempt to invite a peer when our session is null.


It would be better if this kind of access control was handled in a more generic place and this specific state could be flagged as "admin only" in some way. `fsa-pre-built.js` already does this with authentication.


@Smotko OMG. Not sure how it's happened. It didn't show me that file in a list of files that are added to a commit. Can we delete it.


I guess it turned out (as the following code shows) this cache is not needed.


Would it make sense to log an unexpected value here?


@Thibaut :sunglasses:, my problem is gone now!


Ups.. My mistake.
Now it was compiled, but was not good. :-( Function normalize() is not required. It created folders instead of expected files.

Sorry! I would remove them now. I was disoriented because of 0.4.6's line 163.

if (typeof each.data === 'function') {
                    target.append(each.data(opts), {name: each.filename});
                } else if (each.src !== undefined) {
                    target.file(each.src, {name: '' + each.filename});
                } else if (each.data !== undefined) {
                    target.append(each.data, {name: each.filename});
                } else {
                    target.append(null, {name: each.filename});
                }


Could we use `Messages.UNAUTHORIZED` here too?


Q related to #96: Is the `alpha="1"` channel here what would make the border actually translucent? would the following make it 15% black then?
```
red="1" green="1" blue="1" alpha="0.15"
```
![d01cc3c6-5c72-11e5-9fb0-8af0b7bdca5e](https://cloud.githubusercontent.com/assets/1379822/9994930/da76446c-607f-11e5-84f7-cf134165ca93.png)


closes few crashes ?


Usually we have an empty line after statements with `return`.


No worries.

> but how do I overcome setting a height on the element without the text inside the element flowing into the the section below?

It's actually the other way around.  The text won't naturally overflow at all unless you set a height.  If you set a height that is too small the `overflow` will be `visible` by default and will look like it is running into the other element. I've deliberately set a height of 20px on your `.container3` and attached the image below.

![fixed-height-overflow](https://cloud.githubusercontent.com/assets/1712153/9994662/af3f420c-60c1-11e5-9d87-9fa39b01c089.png)

If you set the `overflow` to `hidden` then only the 20px dark blue bar will be visible.  The other alternative is to set the `overflow` to `scroll` which will mean that if the content inside the container is too big then you will get scroll bars on the side of the container.

I suspect that you set a height on the `.container3` to prevent whitespace (see image below) caused by the `margin-bottom` on the paragraph.  If you set the `margin` on the `p` inside to 0 and bumped up the `padding-bottom` you'd achieve the desired effect.

![rexalr-landing-whitespace](https://cloud.githubusercontent.com/assets/1712153/9994902/d3a482be-60c2-11e5-9656-45922fe677fa.png)

Hopefully that helps to illustrate it better.  Note that I've not mentioned `clear` or `clearfix` here as none of the elements are floated.  The name of the game with this exercise was to control the box around the elements with `margin` and `padding`.


All in all, what you did is correct. It does not abide by the convention of having "fat models, skinny controllers" (although [some may argue it's a good idea to begin with](http://blog.joncairns.com/2013/04/fat-model-skinny-controller-is-a-load-of-rubbish/)), hence my comment above, but tbh it's just a detail.


Hi Doug,

Pull those extra chars out if they mess up anything.  I only added them when I thought we were going with Python 3.5 when our engine said 3.4.

Also, I just made one commit to the Sigil-Ebook tree.  I removed the references to Python 3.5 in the ChangeLog.txt and replaced them with Python 3.4.  I haven't touched any of the code.

Kevin

On Sep 21, 2015, at 08:49 AM, Doug Massay <notifications@github.com> wrote:

Sorry ... I stupidly commented on this in my own fork of Sigil. Not certain if you'll receive notification on it that way, so I'll place my question in the "proper" Sigil repo. ;)
Hey Kevin... just checking if you purposely made these changes to the PPluginWidget.ui form when you updated the Sigil documentation epub in this commit, or if something weird happened. I just noticed those symbols showing up in the Manage Plugin preferences widget the other day and tracked it down to this commit.
—
Reply to this email directly or view it on GitHub.


```else
    throw cRuntimeError("Unknown time type");```


Thanks


does the section id provide any value in the field name?


**Warning:** I did not do this change because it happens after Firefox 42a2 (2015-09-21).  It could create problems in releases prior to Firefox 43.  But, if every file that includes search.css also includes preferences.css then that may not be a problem.  (I do not have the answer nor the time to look for it now.)


It seems this line should be in `{` ... `}` (see also lines 45 and 47).


It sounds like the problem is with RuboCop.


interpolate


Asking questions in the middle of an already merged commit is not a good environment to deal with issues. Can you post your question on stack overflow and tag it with spring-data-rest and spring-data-<datastore> (jpa, etc.)? In your question, if you can show as much of your code as possible, it will make it easier to try reproducing your problem on our end.


Yeah, they disabled it by default: https://github.com/bbatsov/rubocop/commit/44af76481851dd62a71e7fd8429bf04bf576d23b.


use `cRuntimeError(...)`


1: M111 unrecognized component name: BibDocFile


Nótese que prácticamente calco la explicación de @pbaeyens en #3.


I'm not sure if that closes some crashes, but at least will prevent core from running in a bad state, as ASSERT is not enabled when not in debug mode but abort is always enabled


Pretty cool.


throw cRuntimeError(...);


Hi, When I run a worker, it fails because job class could not be found.  My job class lives in the Shell folder.  Wondering is there is something wrong with my path?

Thanks


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.490.d0977ba58a6fc6fb1217ef8e9e5f5adc84f7f99e](http://build.palaso.org/viewLog.html?buildId=63505&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:16:23


You can simpilfy this code a bit by omitting `(` and ')' about last argument for `fold`.


1: M111 unrecognized component name: tests


Nice refactoring.


We may add this later if someone asks for.


I took a different approach on this one: I assigned the info template to the graphics layer itself. In this way, when graphics overlap, the info window handles the paging through the multiple features and users can see their attributes. And I completely removed the if (this.infoTemplate) statement.
```javascript
this.featureGraphics = new GraphicsLayer({
       id: this.topicID + '_FeatureGraphics',
       title: 'Attribute Feature Graphics',
       infoTemplate: (this.infoTemplate) ? this.infoTemplate: null
});
```
Just an idea.


I didn't want to assume that the rows of the domain order CSV file would be in order. In order to determine what the next domain row is for a given domain, I pass the `domain_order` structure into the `next_domain_row_for_target_domain`. I reasoned if we aren't making assumptions about the order of the rows, that means the next domain row might be before the current row, so having the entire structure became necessary. It's hard sometimes in these challenges to know what is safe to assume vs what is given, so I opted to not assume as much as possible, realizing that this creates a slightly more complex solution. If it is safe to assume the next row is the correct row in all cases, then this would simplify this logic considerably.


选择SCLKMPLL_USER_T为UART时钟源，SCLKMPLL_USER_T时钟是800Mhz


[Seems like the `autosave` option is automatically enabled](http://api.rubyonrails.org/classes/ActiveRecord/NestedAttributes/ClassMethods.html) for relations you allowed nested attributes for, so you could reduce that down to just the second line.


Ah, I didn't see there was an extra commit on that pull request. I think I assumed that one had only my commits.

> So it does seem to behave correctly without the type definition, but I think if we want to fix the ugliness we should do it by removing the obsolete power states from the power_to_string function (and while we're at it, settling on just one of power_to_string and power_state_to_string in Record_util, since one is just String.lowercase of the other.)

I'd be nervous whether this would be backwards incompatible with users of the CLI but maybe it's worth some investigation.

Since the commit is in master we should probably backport it to the LCM branch anyway.


Job classes should probably be namespaced ?


These public properties need XMLDocs otherwise build warnings...


Uncaught (in promise) TypeError: Cannot read property 'data' of undefined(…)

It seems like data is not defined here. Do you have to pass data as a parameter in componentWillMount function?


That's a great point, and I agree. Things get dense in these few lines of code.


Nice! :) r+


We should store UUIDs, not titles...


The same as before: template expansion via `Tab` key is available. Unfortunately, there is no other options in the case R# code completion is disabled.


@TechnoSophos, if you are planning more Gluster posts, please add your RSS feed that only contains posts with a "gluster" tag. Thanks!


Turns out proxied_count can't be used since it's only useful when one or more sub-plugins are enabled. A proxy that has no enabled sub-plugins has a zero proxied_count and cannot be separated from normal plugins this way.


GroundDomainUpdate (mmatts) - i386-Windows-7-VisualStudio-12: OK (1872 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.svg)


If I recall, this line was also changed to return 404 instead of 410; do we care / can that be overridden in the new way as well?


The same name has been used in many other places. I do not want to change them (including UI code).


设置SCLK_UART=SCLKMPLL_USER_T/(13 + 1)=57Mhz


add tested


no


No need for newline


This code is too dense, IMHO. I suggest using standart formatting:
```
    class Accumulator(it: Iterator<LinePattern>) {
        val iter = EndBoundIteratorWithValue(it)
        var lineNo = 1
        var lastMatchedLineNo = 0

        fun nextLineAndPattern(): Accumulator {
            iter.traverseNext()
            lastMatchedLineNo = lineNo
            return nextLine()
        }

        fun nextLine(): Accumulator {
            lineNo++
            return this
        }
    }
```


Well, it's fine for me! Well done, that was a tough assignment. I'll try to have it reworked, in a way that makes it more obvious what the differences are with the relationship set in the checkpoint itself, for the assignment is not using a join table; and the need (or absence of need) for such a table is not made explicit.


dynamic_cast ?
if use `check_and_cast`, the `if (datagram && live)` always true, or runtime error occured in `check_and_cast`


Do you mean the `domain_transition_map` and the `domain_order_map`? I attempted that, but wasn't able to find a solution that did not require some hard coded assumptions about the order of the rows. I think if we know, for example, that the domain order CSV file is always in the correct order, then it would be possible to construct both arrays in a single read. I didn't assume that, and that meant I needed two iterations (the first to setup the `domain_transition_map` to then allow the correct parsing of the domain order CSV file for the creation of the `domain_order_map`).


This should never happen. But, I check it here just in case.


DIV_VAL = (SCLK_UART/(bps*16))  - 1
                = (57 * 10^6) / (115200 * 16) - 1
                = 29.9244791666


not remove


Noted. Corrected in https://github.com/Paradigm4/SciDB-Py/commit/f86a4a1b6aa1b66b1f13590bb902867a400a23b8


It still has TLD :D


Headers would have been awesome :+1:


Ah, then I guess there was a bug at line 2356 in the previous version, which should be "if (client->id)"? Otherwise, "if (client)" was always true at that point, so client_id was always client->id.


Does this work with 3.0+? I thought I changed it because some of the new meta types were breaking with v1. Maybe the exception handling I added is allowing it to succeed with errors.


Those names follow the traditions, such as onWUQuery, onDFUQuery, ...


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20984/testReport/) for this commit**


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (807 of 807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.54%25-green.svg)


This, again, is wrong. This script is installed by composer, so it's supposed to be managed by him.
We agreed to set includes as the vendor path for composer so this is to be expected.
Removing the file from here inhibits composer from managing it and will make composer reinstall it next time it runs.
I don't want to rub your feelings the wrong way because I want our composer integration to be successful. At the same time, I think you should sit for a minute to learn how it works and what its benefits are.
I'm available almost anytime if you want to discuss it.


I will change it.


ok


That's a pity. Hope you'll get R# intellisense improved soon. Postfix Templates make me want to enable it actually.


This is existing, but shouldn't this be `assertEquals()`? The data will always read and write in order.


FWIW, you shouldn't need to add the whitespace trivia. The formatter should add that.


Same comment about `assertEquals`


We should probably have a rule about this in the style guide as well.