Instead of calling the `_syncPopoverContent` function here, you could pass the correct value on line 273, inside `_createPopover`. That would be less expensive than having to find the element and repaint the text when it's wrong.


Thanks for adding the tests! Could you just add one more, where the `pagesQuantity` changes dynamically instead of being given in the constructor?


I'd add an additional comment that references the details of why we are doing this. For example:

```
// disable the splash screen from loading its own splash image.
// this prevents a quick flicker between the native splash screen and the fake splash screen
// displayed by the Cordova splash screen plugin.
// see: https://github.com/phonegap/phonegap-app-developer/issues/349#issuecomment-141577196
```


is there any benefit of the `rpmkey::rpmkey` type over the native ruby `rpmkey` type?


Why was adding Solaris 12 reverted?


Though it's still inconsistent, we tend to move to lower case commands and mixed case functions


I guess this will force the user to define a `source` even on `ensure => absent`


What about

```ruby
@raw_json['files'].any?
```


yeah we could.  but this worked, and we have bigger fish to fry, so I'd rather just move on.


Can you wrap this conditional in `{}` for consistency.

Also, do we want to return 0 and exit successfully? This hook is running only for WP. If we cannot open the `SplashScreen.cs` then either the Splash Screen plugin failed to install or it has change the file name. If we exit successfully, we may reintroduce the splash screen flicker bug.


nested conditionals make baby jesus cry :(


dependencja selenium na rspec'a 2.99 jest na 'development' a my go tylko używamy


just seemed superfluous - the comment isn't explaining anything that can't be seen by reading the code.


@lesliehebb and I discussed this in the Hangout yesterday and thought you must be downsampling the out-of-transit data because the flux isn't changing quickly there. Wouldn't it be more computationally efficient to down-sample there?


Will clean this.


yes.  We used to be passing a single sid into this test, so we'd have one position.  But now we're passing 2 sids in, so two positions.


develop (evanweaver) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


У меня везде токены вручную добавлены в форму. Я потестил и понял в чем причина двойного токена:
Если у формы `action` указан обычным образом или не указан вобще - нужно добавлять токен самому.
Если у формы `action` указан через `th:action` - токен добавляется автоматически.
Добавлю себе в issues.


isn't this the equivalent of just saying
```ruby
create_resources('rpmkey', $rpmkeys_real, { ensure => present })
```
so without the need to go over a defined type?


No kurcze blade. Może ja coś źle robię, ale otwieram sobie konsolę w Operze -> Elements -> CTRL + F -> wyszukuje element po cssie. Czy robi się to jakoś inaczej?;)


OK - so I assume we want it back?


@AnriShitko


Are you sure that it is "-2*qt_b_mod_s.."?

It seems to me that it is "+2*qt_b_mod_s.." [1].

[1] http://www-sop.inria.fr/act_recherche/formulaire/uploads/phd-425.pdf
     Eq. 3.8, p. 101

@francesco-romano @traversaro @gabrielenava


I also liked this way @matugm !


Hah! The `nodoc` was added in a separate commit, so the only thing this commit does now is add the documentation. But I don't care enough to amend the commit and change the description... :wink:


Or find a better way - since this does not work on CoreClr as far as I understand.


The return statements may need to be updated to `process.exit(1);` since it is running as a standalone script and not a node module.


@thewisenerd noted. thanks mate :D


О! Это многое объясняет и я этого не знал. Спасибо, в очередной раз научился от тебя!


else { return error? }


Forgot to mention the changes on the datebase config - simply change the constants rather than editing the string variable in the SQL call.

Also made changes to the API loader, likely will use something similar for the datebase config - JSON or XML?


Could you add a small Usage() to describe behavior of '+' and '-'?


@moozzyk Yes, we need a better way.


TeamCity pull requests :: netty [Build 262](https://garage.netty.io/teamcity/viewLog.html?buildId=1598&buildTypeId=pulls_netty&guest=1) is now running


This check in has issues. We do not use CBA1 anymore (have not used it for over a year)


Just normalized to what's most common in the file.

Probably should Beautify the whole collection.


Please add a link to your github account inside readme.txt


There's a varargs version already. Why is this needed?


This needs a better commit message


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1354 of 1354 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi,

Sorry about this. There's a bug filed for this #5855 and a pull request that will resolve the issue in your case. The more generic case still needs fixing, which I'll have to find some time to...


/cc @BillHiebert


@Xephi hey, sorry for writing here, but how can I access getCountryCode and getCountryName method in the latest version? I am updating a plugin which has AuthMe as a dependency, and the methods seems to be removed in 5.1.


myślę, że robienie tego w jakikolwiek automatyczny sposób jest nieoptymalne. Równie dobrze, opera mogłaby zwrócić ścieżka tysiąca node'ów zaczynając od samego body.
W xpathie używasz atrybutu klasy a w css używasz odwzorowania struktury dokumentu


Should be ---


Is this because the test source sets up 2 sids by default?

We could change the setUp of this test to preserve the existing answers, which I think has some value with so much changing.

```
trade_history = factory.create_trade_history(
            1,
            [10.0, 10.0, 11.0, 11.0],
            [100, 100, 100, 300],
            timedelta(days=1),
            self.sim_params,
            self.env
        )
self.data_portal = create_data_portal_from_trade_history(self.env,
                                                                                self.tempdir,
                                                                                self.sim_params,
                                                                                trades)
```


Thanks !
I will backport for Isengard 15.2 too.


I'd do this in `ExpressionUtils.binaryExpression`


This should probably be "IDE", not "IDEA"?


Can use net.SplitHostPort here.


That's why in the Terms section I referred to the SDAM spec... The naming should be flexible as that spec states but I should add an additional note on that.


Should this not have a `defer`?


Thanks


Created... or got from github/gitignore?


You already wrote this on line 32? The screenshots also look very similar. And what happened to the compile-line that was already there?


Thanks much!


Ммм... что то я задумался что тут можно поделать. Это строка берется из шаблона. Может туда повесить `th:lang`, а значение брать из моего куки с локалью?


We should probably use contextmenu instead of "contextmenu"


Будет сделано.


@kangarko in the Utils.class I move it there. o.O that was not the part of API


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21116/testReport/) for this commit**


@milythael may want to default to active_year field on plan instead?


OH MY GOD WHAT IS THIS


HelloWorld.java (or change code example to "class Main"), at least they have to be synced :)


language-java


It looks like iOS9 `loadFileURL:allowingReadAccessToURL:` allows loading local files:
https://developer.apple.com/library/ios/documentation/WebKit/Reference/WKWebView_Ref/index.html#//apple_ref/occ/instm/WKWebView/loadFileURL:allowingReadAccessToURL:

...but not from the app bundle:
https://github.com/wkwebview/load-fileurl-app-bundle
https://github.com/shazron/WKWebViewFIleUrlTest

Being able to continue to use `file://APP-BUNDLE` for the launcher app's own "reader.html" would restore the security fence that UIWebView implicitly provided (assuming this undocumented "exploit" still works in WKWebView).


Do we still need the (TDev.isBeta) test? Now which editors are shown is controlled by the website, so there's not much harm in enabling them everywhere -- they just won't be accessible via the UI.


We might want to open an issue on the NSIDC search project so it's on their backlog


@jadb I ain't lazy like you :stuck_out_tongue:  Test added in next commit.


BTW, this was fixed later in the feature branch: https://github.com/readium/readium-sdk/commit/41d0770bceaa2e63c6ce511f8a76289d9f551e85


Well, there are a whole bunch of other mass-rebuild triggering changes in
staging so we don't have a clear cutover for 15.09. Maybe we should make a
release-15.09 staging.

On Wed, Sep 23, 2015, 09:08 Vladimír Čunát <notifications@github.com> wrote:

> Hmm, do we pick this to 15.09 now or wait a while in case another
> mass-rebuild change appears? This is stdenv-changing, I'm afraid.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/453b986d2f1061dd04f7a2f198c4e5276ddc8d8f#commitcomment-13394992>
> .
>


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21117/testReport/) for this commit**


Конечно просто так ) Признаюсь, всегда лень писать эти заглушки.


I believe you meant to use the `-n` flag in your example, instead of the `-o` flag.


Actually it's :arrow_up: `1.2.0` :grin:


add a description


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21118/testReport/) for this commit**


Replace `it's` with `it` perhaps?


Absolutely, and I don't think you'd see any real change in the behavior of the starspot solutions. However, as you noted in your first comment, *what* factor to down-sample by is an open issue


Ship it!


@jread-usgs Yes, I've done this, here is the link:https://groups.google.com/forum/#!topic/aquaticmodelling/CHmehSc36-M. Because no answer,  so I try to seek help on the Github.


Odoo Server Error
Traceback (most recent call last):
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\http.py", line 537, in _handle_exception
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\http.py", line 574, in dispatch
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\http.py", line 310, in _call_function
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\service\model.py", line 113, in wrapper
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\http.py", line 307, in checked_call
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\http.py", line 803, in __call__
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\http.py", line 403, in response_wrap
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\openerp\addons\web\controllers\main.py", line 952, in call_button
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\openerp\addons\web\controllers\main.py", line 940, in _call_kw
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\service\model.py", line 113, in wrapper
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\openerp\addons\web\controllers\main.py", line 939, in checked_call
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\api.py", line 241, in wrapper
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\openerp\addons\base\module\module.py", line 719, in install_from_urls
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\api.py", line 241, in wrapper
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\openerp\addons\base\module\module.py", line 651, in update_list
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\http.py", line 1310, in load_addons
  File "C:\Program Files (x86)\Odoo 8.0-20150917\server\.\openerp\modules\module.py", line 80, in load_module
  File "C:\Users\Administrator\AppData\Local\OpenERP S.A.\Odoo\addons\8.0\woocommerceerpconnect\__init__.py", line 22, in <module>
  File "C:\Users\Administrator\AppData\Local\OpenERP S.A.\Odoo\addons\8.0\woocommerceerpconnect\model\__init__.py", line 22, in <module>
  File "C:\Users\Administrator\AppData\Local\OpenERP S.A.\Odoo\addons\8.0\woocommerceerpconnect\model\backend.py", line 23, in <module>
ImportError: No module named woocommerce


Hmm, I strongly disagree. I was always taught to not use "the" when the subject is a name. For instance:
> Red was used.

"Red" is the subject in that sentence and it is also the name of the color, so it is referenced directly without the preposition. If I wanted to use "the", it would have to be in this way:
> The red color was used.

because while "red" is still a name, in here it is an adjective, while "color" is the real subject.

There are nuances and special exceptions, but the general rule I was always taught to follow is this: if sentences can lead to questions like "the ... what?" they are generally wrong. Such as:
> The red was used.

If I didn't know what we were talking about, I could be left wondering "The red what?". Whereas with the first example logic dictates red is a color so the name must refer to the color, and the second example is self-demonstrating of course. (<--- This very sentence could be one of the exceptions. I could have used "the first" and "the second" without the word "example", because they appeared after it was clearly established in the conversation to what they refer.)

The preference string is trickier of course, because the user will only know that name is a preference after being familiar with the add-on, so you could make the argument for leaving "the ... preference" in, but since we're in a preferences dialog, logic dictates it has to be a preference somewhere in there. Despite this, I believe the grammar principles I described above still apply.


Т.е. ,видимо, я изначально не корректно понял идею. Верная логика такая: ВСЕ параметры, для которых указан `th:` должны ОБЯЗАТЕЛЬНО иметь свои обычные значения. Так?


else cmd.cert is expected to have contents of the cert as a string: -pem-cert=$(cat foo.crt)
(m.SetCertifcate will return an error if the contents are invalid)
I suppose it might be more useful to expect a file name in that case?  In any case, I'll clear this up in the usage.


new one


Yup! Can't commit the change yet bc the image scraper is occupying my mac


LMAO yay nice typo...


@kswedberg Could you please take a look at the 1st sentence on this line? I'm thinking it may be clearer to start the sentence with "When the right button of the mouse is clicked on an element, and before the context menu is displayed, that element receives the contextmenu event. Or is it best to keep it in the passive form? Also should we use "and before" or "but before"?


on 2nd thought, do we really want this to be a bson.ObjectId() instead of a string?

wont that more tightly couple us to the mgo libs? @dnem

i realize the hypocrisy as we have lots of these dependencies sprinkled around the code ... my bad :)


А в чем преимущество ?


Should this be "without an argument" or "without argument" ? cc:@kswedberg


I don't really agree with this implementation. This requires that you set a `time_line` property for every RP in the arc, while you might only want to rearrange one or two.

I was thinking that you might instead have a `sort_date` field, the same way there's `start_date`, and that field could be used for chronological ordering. Stuff is out of order? Change the `sort_date` so that it's in the right place relative to the things that are. That way you only have to edit one file, even if you have to check against some other ones to see when they started.

Then it would be okay to leave it blank, too.


I don't think there should be any YAML entries for the two outcomes - the labels for these are probably just being generated from the node names (assuming there's no ERB templates for them).


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21119/testReport/) for this commit**


Hyphenate Right click to Right-click


As YAML can be confusing, an example block might be a nice idea?


Над этими строчками ковырялся долго, мне самому не нравилось. Но я так и не смог засунуть в `th:if` вот эту конструкцию `sec:authorize="hasRole('ADMIN')"`


Problem with net.SplitHostPort is that it returns an error if the string doesn't have a ':', which is likely the case as we leave it to the http package to choose the default port.  But I can change this another way to support IPv6 addresses.


@aslakhellesoy I changed the "if"-statement a bit. There's no need to check if the input is a string and then check if it exists. Just make the input a String (#to_s) and then just check if this exists. For all other things (strings, io, ...) this will be "garbage" not exist in filesystem.


@AurelioDeRosa I have reviewed your PR. I've left some questions for @kswedberg as I am not sure about a few things...


Sounds good!


Can we change to IBM Bluemix Deployments?


I brought this up before. Stuff that comes out of a service shouldn't
expose a bson.ObjectId() because that's tier bleeding and exposes that IDs
are coming from mongo. The public API of a thing should be consumable
without any knowledge or dependencies on the private API of a thing.

On Wed, Sep 23, 2015 at 1:40 PM, John Calabrese <notifications@github.com>
wrote:

> on 2nd thought, do we really want this to be a bson.ObjectId() instead of
> a string?
>
> wont that more tightly couple us to the mgo libs? @dnem
> <https://github.com/dnem>
>
> i realize the hypocrisy as we have lots of these dependencies sprinkled
> around the code ... my bad :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pivotal-pez/pezdispenser/commit/63cb1a2dd7916cf84d88794766decabab8997d8f#commitcomment-13396954>
> .
>


@mattheworiordan Nope, it's on purpose - it only guards `c.isActive()`.


it doesn't seem random :-)


In some of the other subcommands you call `cmd.Usage()` before printing an error and exiting. Perhaps the same should happen both here and in the next if block?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21120/testReport/) for this commit**


+ integrated with Slack ....


box


+ slack


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1354 of 1354 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.27%25-green.svg)


Is this needed?  If we haven't selected to perform a memory analysis, no memory dump should be created in the first place.


Prefers to use capital letter for values of an enum and when a enum is not inner a class or a namespace named, prefix values of your enums by enum initials or enum name
Ex :
AS_MENU or APPSTATE_MENU


code is duplicate of /bin/install-wp-tests.sh  function install_db


looks good, can't test under MrMC as python has been ripped out.


Well, even stdenv hash between master and 15.09 has diverged already. There shouldn't be many mass-rebuild changes for 15.09, so creating another jobset and branch for that seems an overkill to me. Moreover latest 15.09 is an unlikely base for nixpkgs development, and users can use the channel instead.


i mean whoever extends this class will be forced to have "users" property (and define it for `super.__init__`) even if it's not used. Imo it should be defined only in MemoryUserManager, and `__init__` of abstraction should take only loop and timeout args.


xswdd


fonction must be const


Remember that the `new`ing of the dialog should also be inside the if-statement.  Otherwise, memory leaks!


Oh, right.. I didn't think of that. Hm, I suppose at least check for .Contains("UnitsNet.") with a trailing dot? Just trying to avoid some trouble down the road.


For example, you might have a link to CK script. The edit button would be disabled/enabled depending on whether the editor is disabled/enabled.


@minhchau273 cai nay. khi nao build to device no se lai hoi em va update cua em vo. danh ok vay


If I am not mistaken this will test how the class behaves when the `$rpmkeys` parameter is explicitly passed to the class. This does not test the `priority` lookup or the `merge` hiera lookups.

So in order to test the real hiera behaviour we should probably do something like http://rnelson0.com/2014/12/31/puppet-rspec-tests-with-hiera-data/


@incanus The `[publish binary]` string triggers a node-pre-gyp build [here](https://github.com/mapbox/mapbox-gl-native/blob/master/scripts/node/after_script.sh#L15).

We usually bundle this string with the commit that bumps the version field  `package.json` but I missed it this time around.

 In response to this commit, I opened #2365 to suggest another node-pre-gyp triggering technique. Would you prefer something more in line with the iOS publish trigger? (e.g. `[publish node-v2.0.0-pre.7]`)


Thanks!  (At the next version bump, we'll have to switch it to the
Apache license:)

http://lists.jitsi.org/pipermail/dev/2015-June/024439.html


Also possibly add dependency on latte/latte to require in composer.json


The reason why git does not acknowledge my gitignore is because git will continue to track files it is already tracking, unless you explicitly tell it to stop. Which I will soon.


GLFW_KEY_SPACE case has no reason to be pushed, not used by the player, remove it


You are probably right.. I've only ever written modules without providers and for that purpose used defines.
Maybe I do not need to create a define for this just call the rpmkey provider instead.
Now when I think about it does seem like I wrote a wrapper for your provider.. which is probably not needed...

I will rewrite it tomorrow and see if it works the same way without the define.


I check the user manual (v2.0), and find that in equation(28), there is heat flux (qw) from the water to the ice when ice melting. However, in surface energy budget equation(6), there is no such heat flux (qw). Actually, based on the buoy data, every time ice melting, the surface temperature should drop a bit. Could it be possible that lack of heat flux (qw) in equation（6）leads to the unusual rise of surface temperature when ice melting.


```ruby
BOOLEAN_ATTRIBUTES = %i(autofocus checked disabled readonly required)
```


Probably not, I just did not understand that providers == defines


@eskfung, this was just for fun


the board should be painted only in play mode


Well, although I'm not sure this fact, but I accept your point of view.

Incidentally, I think now this extension have many unnecessary explanatory text, the software with a detailed manual is not required. Maybe we can write a online manual (html) or otherwise, and it may not need to be localized.


TeamCity pull requests :: netty [Build 262](https://garage.netty.io/teamcity/viewLog.html?buildId=1598&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:29:10


just uncomment a line that i commented:D


btw i didn't use this patch ..and i don't have high battery draining with LTO & Graphite ... so maybe this is the cause of battery draining in your kernel.


draw text like: "press P to play"


Yes, this will force a user to have a source defined.
I assume the source is not needed when deleting a key so I can make sure that source is not necessary if ensure if absent.


@agcolom I think the first sentence is fine as is. The second one is confusing to me, though. @AurelioDeRosa, when you write "In case," do you mean "If"?


commented code, remove it


I'm sure you can use AMD APP SDK with any modern x86 CPU. You can check on
AMD APP SDK website.

I think those OpenCL headers from repo are just old.
23 wrz 2015 15:03 "Daniel Murray" <notifications@github.com> napisał(a):

> I'm using the opencl-headers package from debian version 1.2-2012.04.18a-1
> which supposedly is 'as published' by Kronos, although that's clearly not
> true :)
>
> I can't just use the amd/nvidia sdk because this is just a little netbook
> that I'm testing things on. I was hoping I could target just the cpu for
> testing. I can compile and run with a dummy icd ( again from the deb repos
> ) just fine provided I define the inclusion of that symbol.
> On 23 Sep 2015 11:39, "Jakub Szuppe" <notifications@github.com> wrote:
>
> > What kind of OpenCL SKD do you use? Because it's really weird cl.hp
> file. #ifdef
> > CL_USE_DEPRECATED_OPENCL_1_1_APIS does not occur in original one from
> > Khronos website https://www.khronos.org/registry/cl/api/1.2/cl.h.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/boostorg/compute/commit/c882466dbd2a3d9f3d8132075cf92d06f557930a#commitcomment-13387532
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/boostorg/compute/commit/c882466dbd2a3d9f3d8132075cf92d06f557930a#commitcomment-13390074>
> .
>


@agcolom: "an argument" works.


In the '/home/qwerty/.oh-my-zsh/themes' directory


Yeah, this is what I did:

http://stackoverflow.com/a/1139797/1626192

I was hoping it would fix it for everyone else to, as soon as they pulled. But maybe not?


This functionality is needed for retrieving prorated charges on a subscription.


Where would that code be plugged?


@AurelioDeRosa, looks good! Just a couple quick edits. See my replis to @agcolom above. Thanks so much!


modeMap[mode][squareValue] return an empty string if square value > 2048


This commit still mixes a bugfix with a feature.

Peronally I'd continue using git and set the version number to the date of the commit (YYYY-MM-DD). I think there's a better chance that git is already in the nix store than subversion (less building / smaller closure).


>  Would you prefer something more in line with the iOS publish trigger? (e.g. `[publish node-v2.0.0-pre.7]`)

Yeah, exactly — I think this would be cleaner and clearer.


why mode numeric is an exception ?


Essentially yes, when the scheduled task runs, it should check that the packet was processed or expired and interrupt if needed. This can obviously be re-worked, but the objective remains to prevent a deadlock caused by a packet.


please publish it


Thanks @josiasds !


Arent I setting it to 0 in the constructor?  How will the if-statement work then if its set to 0, the if statement won't start? I thought thats why I had to put the   new before the if-statement.


actually, for this we already have `Graphlib.postorder_traverse` and `reverse_postorder_traverse`. It is recommended to use reverse postorder for a forward problems and postorder for backwards problems. So it can be encoded like this.:
```ocaml
let g = Block.to_graph ~bound entry in
let order = if direction = rev
   then Graphlib.post_order_traverse ~rev:true
   else Graphlib.reverse_postorder_traverse in
traverse (module Block.Graph) ~start:entry g
```
This also assumes that in case of backward analysis your entry node is actually an exit node.


@davidsh, @SidharthNabar Nit: ... enable secure network communication between endpoints?
I'm a bit confused by "between applications and hosts" since applications are usually running on a host.


Do we need to check here (yet another query), or can we let the DB constraint validate it (`CREATE UNIQUE INDEX payment_methods_external_key ON payment_methods(external_key, tenant_record_id);`)


Agreed.


ok for this C++11 syntax but is it volunteer ?


This text that was used here in this PR was copied verbatim from the current NuGet package description.

Feel free to propose revisions.  We can revise again if necessary.


Fixed. It is, it's the slot's blend mode for the setup pose.


not used remove it


@jeffyuchang What do you think about comparing hibernate dialects with substrings "h2", "mysql", "db2", "oracle", "postgres", "sqlserver", "sybase"? Dialect can be assigned dynamically and it can cause some problems, e.g.
``` java
"org.hibernate.dialect.MySQL5InnoDBDialect".indexOf("MySQLInnoDBDialect") == -1
```
=> No dialect will be chosen in this case.


Oh cool, I didn't know you could do that with rspec... will be fun to learn. thanks for the tip. Will probably create a new PR for those changes.


It works only for those that do a first-time pull of the rep with updated .gitignore. Others like you and me have to remove them from git cache.


Prefers a enum name which begins by a capital letter: ModeEnum ( like class Name)
use capital case for enum values : NUMERIC, ....


it seems like we shouldn't need this code. shouldn't everything be QNRs at this point?


Uhm, sorry, I didn't pay enough attention to the diff. Now that I had a second look, what do you mean with "use svn to get version string"? The urjtag version string is still 0.10 afaict.


Ah makes sense. I hope this is the last change to .gitignore :-)


Minor suggestion for future improvement:
Since we're always checking the same value, use the "Follow the steps for the value of <var>distinctive identifier consent status</var> from the following list:" pattern.


I see your point, but I prefer the test testing positions in multiple assets.


yeah, i thought that was strange too.  I'll suggest this or do a merge request


So far nobody complained about battery drain after reverting graphite. Maybe it's due to the fact I use linaro,  and graphite handling is different in GCC 5.2 and Linaro GCC 4.9.2.


rename your variable like "appState_"


Due to the width of the editable textbox forcing column widths to match, adding the 3 additional columns for length, height, and width to the Product Options page requires a window width of 1246px or greater to view without a scrollbar, whereas the original layout needed only 925px or so.

If, for whatever reason, it is desired to maintain the previous minimum window width, one solution would be to reduce the width of the textbox, at least on this page.

Given that '99999999999.99' (13 digits plus a period) can fit in the current textbox width (106 px) without overflowing, it seems reasonable that even reducing the width by 50+% will not hinder usability for the vast majority of use cases, especially if limited to this page only.

This would allow the 3 columns to be added with only a marginal increase in minimum window size (about 50-60px extra required, rather than approximately 320).


yes I think so, everyone that tracks those file need to do that.


I understand what you mean, I know it is a big bother having so much to translate (I also do the portuguese locale, it takes me large chunk of time sometimes to do it as well). I really appreciate you going through all the trouble, as I'm sure do many chinese users! ([over 4000 users by the way](https://addons.mozilla.org/firefox/addon/findbar-tweak/statistics/usage/languages/?last=30))

The thing is, on the one hand, the Addons.Mozilla.Org homepage needs to be well documented, as it is a requirement for an add-on to have full review, but especially for featured status. So those strings are necessary at least. On the other hand I always used to get a ton of e-mails with questions about the basic functionality I describe in most of those help texts, and those e-mails have drastically decreased in the last couple of months, so the texts are helping.

For these reasons, at least the current "amount" of text is necessary, and I already try to keep it as succinct as I can.

I did think about making an online manual, and I'll probably create one sometime. But it would have to still be localized somehow as not everyone understands english. For instance, I know a few people in real life who use program in portuguese (not only Firefox, I'm speaking in general terms), but their english skills are very poor. Localized documentation of any sort helps them a lot; I know because when that documentation isn't enough I'm usually the one who helps them. In cases like these, online documentation only in english wouldn't really help at all.

Again, I know it's a big bother having so many strings to localize sometimes. I really do appreciate your effort. But for now at least, all of those strings are necessary. :(


@vedi, possible code reduction:
`if ((new string [] {
        GateStorage.getKeyGatePrefix(),
        ....
    }).Where(s => key.StartsWith(s)).Count > 0) {`


but they also have to remove the cache at the same time, I think. as is shown in your link:
git rm -r --cached .


I think the current description isn't correct and doesn't make much sense: the class isn't meant to connect the application to it's host.
MSDN has a better description:

_Provides a stream used for client-server communication that uses the Secure Socket Layer (SSL) security protocol to authenticate the server and optionally the client._
https://msdn.microsoft.com/en-us/library/system.net.security.sslstream(v=vs.110).aspx


i think, it's a bad habit to name you function like class ( starts with a capital letter)
prefers to name like this: checkValue( ... )


This is a problem.  It causes `make android` to put the `.so` in `libs` and not `jniLibs` which causes the the library not to be able to find it at runtime.


Are you setting the currency here just for testing?


Using ```gpii.firstDiscovery.attachTooltip.renderer``` grade will help to get rid of this listener.


<bug


remove useless comment


74564912Issue4347BBRadConvHW (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1888 of 1891 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


write  the test


Cool, yeah makes sense.


1. Needs doc here as users need to understand they can override this and perhaps provide quick example in the trait doc of how to override param to create custom app.
2. "param" is too generic (param of what?) . Perhaps rename to appParams, or appArgs.


@christianharke Hey man, nice work on that other fix and this one, would you mind submitting them as a PR so I can fix upstream too?  Thanks!! :)


Looks good! (As an FYI, we're going to be completely redesigning this page soon, which is why we're dropping the most up-to-date info in the Slack room.) The content in the Slack room will eventually make its way back to the Hub.


@EugeneButusov, you're right. Can you elaborate the code?


create a function to do it in achievement class


Ich habe um meine Tabs getrauert, da ist mir das nicht aufgefallen. ;)

Eigentlich sollte der compiler auch vor sowas warnen, habe vor dem Reformat aber nichts gesehen.


Add a period.


I feel like the language is pretty overloaded here since we are using "group" to mean pwos with identical urls and also to mean pwos with identical title+domains


use " " for include, it's a file located in the same module


In /admin/sources/products.index.inc.php on line 65-66:
    //Need to remove these in some cases to stop SQL errors
    $records = array('product_id', 'product_weight', 'stock_level', 'stock_warning');
I'm not sure to which SQL errors that refers, but given that 'product_weight' is listed, we may need to add 'product_length', 'product_height', and 'product_width' as well, so it looks like this:
    $records = array('product_id', 'product_weight', 'product_length', 'product_height', 'product_width', 'stock_level', 'stock_warning');


I'm not sure the note below (line 625) says what you intended. There at least seems room for misinterpretation.


suffix your variables by an _


Agree in principal with Kevin.  Happy to make a change, if desired.  I also
am not worried about it.  We are going to be our only api consumer (at
least initially) and we are tied to mongo by design.

On Wed, Sep 23, 2015 at 1:44 PM, Kevin Hoffman <notifications@github.com>
wrote:

> I brought this up before. Stuff that comes out of a service shouldn't
> expose a bson.ObjectId() because that's tier bleeding and exposes that IDs
> are coming from mongo. The public API of a thing should be consumable
> without any knowledge or dependencies on the private API of a thing.
>
> On Wed, Sep 23, 2015 at 1:40 PM, John Calabrese <notifications@github.com>
> wrote:
>
> > on 2nd thought, do we really want this to be a bson.ObjectId() instead of
> > a string?
> >
> > wont that more tightly couple us to the mgo libs? @dnem
> > <https://github.com/dnem>
> >
> > i realize the hypocrisy as we have lots of these dependencies sprinkled
> > around the code ... my bad :)
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/pivotal-pez/pezdispenser/commit/63cb1a2dd7916cf84d88794766decabab8997d8f#commitcomment-13396954
> >
> > .
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pivotal-pez/pezdispenser/commit/63cb1a2dd7916cf84d88794766decabab8997d8f#commitcomment-13397027>
> .
>


I just mean that this is how you can solve your TODOs (copying the code)


very well organized and done. good comments throughout the program, makes it very easy to read. Ran well for me except the slot game, but that is minor considering how well done it is. Good Job!


Aren't we supposed to make an interface and that the abstract class implements the the interface? And then we have the subclasses of PlayerFish and EnemyFish? <organisation


Perhaps just sasy run msbuild from the tests directory, since that's where the .csproj files usually are.


The line that converted the currency parameter to upper case is important, there are some instances where the backend sends a lower case version of the currency code, which breaks some of the APIs. I don't remember which ones had that issue, but you should still do the conversion just in case.


It won't likely matter in practice, but denial should probably take precedence over consent and thus the order of these two steps should be swapped.


This should call super.beforeAll() (same for afterAll).  In this particular instance, it doesn't matter as the super class has an empty beforeAll, afterAll.  However, if someone changes the hierarchy in the future by adding an intermediate class, it will be hard bug to spot.


Or do you think simply removing and repulling will solve it for all?


Fixes #401 !


What was the bug? If we have to add a dependency to wbi then perhaps it male more sense to use the new i DynTree classes.


I see, then go ahead and leave it.


The following lines break the compilation when `ENABLE_SYNC` is not defined. They should be surrounded by `#ifdef ENABLE_SYNC`


rename the function or remove this function : this function don't create a popup


74564912Issue4347BBRadConvHW (wfbuhl) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I thought you meant removing the cache.


@XhmikosR pushed 0.8.0 (since there's new functionality and i'm trying to conform to semver)


it's not used by the public part of this class:
move it into .cpp


Sure, I'll add that.


Maybe we should revise the 'SSL' word and also add 'TLS' instead of (or in addition to)?


Проверить)


It depends on how their personal email addresses are set up. It's possible to associate them with other email addresses I think. Anyway, just for the sake of consistency, it might be good just to sign the CLA with your current GitHub name. It takes less than a minute to do. :-)


using std::pair don't make the code easy readable, prefers to use a struct


Agreed. It's better to have a single global object, since they're related. If we were using the timestamp for other things then it would be good to have it separate.


@jprichardson that would be caught here no?


Yes but i was afraid we would forget it.


Do you think that this might be better in a method? <organisation?


comment


Is this what you want to save?


Ah gotcha, thanks.


`ido-ubiquitous` may be a hammer, but it seems useful enough (I do use it). Another option is `icomplete-mode`, for example. Or `helm`.

What would you rather do, make each package choose which completion system to use, in an ad-hoc fashion? I'm not sure I'd like `robe-mode` to concern itself with it.


In general, since this is an open source project and other people will be working on it, we should sacrifice conciseness for being easy to understand. Give your variables descriptive names within reason (two or three short words in camelCase are good).


The onBlur doesn't trigger when the user selects a date since the onBlur is called when the date widget is displayed. So you don't get the "blur" effect validating that field at all. This is the easiest and probably most practical way to resolve the issue.


I had to add figaro so that the Facebook ap ID and secret key wouldn't be exposed to the public. Only problem is that every time I try to do a git push, I get a "Permission denied (public key)" message. Can anyone figure out what I'm doing wrong?


Я сделал вот так: https://github.com/php-coder/mystamps/blob/master/src/main/webapp/WEB-INF/views/site/index.html#L2


`models = model if isinstance(model, (list, tuple)) else (model,)` seems to be more readable.


lol


I have reviewed the pull request and left some comments. I have already fixed some checkstyle warnings on the method of grow. The rest seems fine to me. Nice fix by the way on the image of the fish. <layout, organisation, bug


That won't work with older Django, right?


just store the achievement get into a map like this
std::map<int,bool> achievementGet_;
if the achievement is not in the map, return false


Seems suspicious.. why should it pass?


That's a bit of a hack...


Opened a issue to track this https://github.com/mapbox/mapbox-gl-native/issues/2402


Details on the tests used.

Merge Shawn Wells branch:
`git checkout -b shawndwells-ospp-build master`
`git pull https://github.com/shawndwells/scap-security-guide.git ospp-build`

Running `make` compile the content with no errors.

Validated the profile with an `oscap` scan:
`oscap xccdf eval --profile ospp-rhel7-server --report ~/git/ospp-report.html ./dist/content/ssg-rhel7-xccdf.xml`

Validated the XML content with `make validate`
No XML errors but we do have OVAL errors.  This is fine and should be considered passed.

Validated the tables compile correctly:
`firefox ./output/table-rhel7-nistrefs-ospp.html`


Can this fix be back-ported to 0.30.6 so we can get a stable release of Atom out with it?


@robobenklein I understand. Yes, I think we have to add it back.


@Traumflug I noticed some more missing newlines after the recent change(?) to gcode_parse handling.  And then I fixed them and pushed them to this commit.  I didn't bother to make a new issue for it, but I gather from some recent emails that's what you'd like to see.  Is it?

Anyway, wanted to draw your attention here in case you rebased around it and dropped it.


Поймал :) Я погуглил и оказалось, что в JavaScript разницы никакой. См. http://stackoverflow.com/questions/242813/when-to-use-double-or-single-quotes-in-javascript


The combination of removal of statics here and the flight code changes is a little confusing.  The commit message only refers to the change in InitialiseFilterDynamic.  Not a big deal.


Just wanted to see how the merge works hehe
On 23 Sep 2015 19:26, "Mike Cole" <notifications@github.com> wrote:

> lol
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/robashton/crowdsourcedhomepage/commit/36fe7b26c7f34712fadd2b5b9a031eaf6a485aa3#commitcomment-13397900>
> .
>


Any reason your executables are larger in size than normal? Your compiled PuTTY 0.65 vs mine (2.05MB vs 632KB).  Also, the putty application looks different with the buttons and text boxes.
Not a big deal, just curious is all.  See attached image for comparison.

![putty comparison](https://cloud.githubusercontent.com/assets/2837391/10054548/980902be-61ff-11e5-9cf9-0577adaf8a24.png)


Не обязательно. Это же зависит от того как нужно, чтобы работал макет.


I think if you can do something to the index file within .git, you can make it work for all.


In my patch I dropped the geometry and projection constraint on the geometry column, but this is still in this file. I had issues with the AGOL provider when using the constraint, so I think it should be dropped in the merge as well. My code at line 1147 would be:
var props = ['id SERIAL PRIMARY KEY', 'feature JSON', 'geom Geometry', 'geohash varchar(10)']

Furthermore, this merge introduces the constraint of 100char at the hosts column again, which I was not very happy with, so maybe you can fix that as well :-)


what is this camel-case blasphemy


r+


We removed the default text and added a link to `test_path`.

`test_path` comes from the static_pages controller; run `rake routes` to see it (you'll just see "test", but you can add "_path" to any of those.


@PeaceNlove I'll correct the host column.

I don't agree that the geometry constraint should be in this PR. That's a totally separate thing functionally. Would you mind rebasing that portion and adding it as a new PR?


Thank you for your reply and understanding.

AMO... I was surprised, the editors surprisingly require these strings.

I understand, but I have some doubts and worries, the users does not have enough interest and patience to read these descriptions. For my part, no the interested to read a lengthy description. It may also be related with copywriting and translation, I can not find any unknown or interesting facts on the inside.

Just a general way I see, many softwares provide a manual (CHM or online, and some screenshots), and improved UI and labels, no detailed description text in UI, because read and understand they are a heavy burden.


use an Impl class for your private datas


@bjornfor The version string revision tag embedded in the binary comes from svn.

If built from svn:

    $ jtag --version

    UrJTAG 0.10 #2051

If built from git:

    $ jtag --version

    UrJTAG 0.10 #

Also, with svn we don't need to download the `web/` subdirectory because svn supports partial repository clones.


SInce all of the cases where socket errors can occur there is an associated boost promise, I think that a more appropriate approach is to use `some_promise.set_exception(...)` or `some_promise.copy_exception(...)`. That way all errors are handled in a homogenous way through the futures.


move this include in the .cpp


Строчный вместо блочного)


Spelling: 'Snoop Dogg'


@rvonstange DWMR (done with my review). `return @"Looks Good";`


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/2c9735ee6996c57b44f5611e8b7340391fbb285f


merging MonsieurNicolas/stellar-core/logRootSeed = 2c9735ee into auto


MonsieurNicolas/stellar-core/logRootSeed = 2c9735ee merged ok, testing candidate = b288c508


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21124/testReport/) for this commit**


remove this include


@rvonstange DWMR. Press on!


### ['token'] is better written in dot notation.

```
$http.defaults.headers.common['token'] = token;
                             ^
```


Hm, ok, so we have users in server init. When it is not subclass of AbstractUserManager we think that it is list of users and make instance of MemoryUserManager, and think that it is inctance of SomeUserManager else. Am I right?

On Wed, Sep 23, 2015 at 8:52 PM, Roman Sichny <notifications@github.com>
wrote:

> i mean whoever extends this class will be forced to have "users" property (and define it for `super.__init__`) even if it's not used. Imo it should be defined only in MemoryUserManager, and `__init__` of abstraction should take only loop and timeout args.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/pohmelie/aioftp/commit/8b3028cc9cf2a95dfe80ba4b0fbe00e1cb6df28a#commitcomment-13397179


yes


lastNumAchieve is not used, it's just a value modified and stored, never tested


You don't want parseInt here, as written it will turn 1.153 into 1.

If the concern is floating point accuracy, there are various ways to fix that.

If you just want to make sure the value is a number, and not a string, Number(price) should do it. Unless there's a reason to use parseInt instead?


weird.. why it should drain more power ... it's just code optimization :S


Вот цитата с сайта (https://github.com/thymeleaf/thymeleaf-extras-springsecurity):

>The #authorization object can be used in a similar way, normally in th:if or th:unlesstags:
>
>    <div th:if="${#authorization.expression('hasRole(''ROLE_ADMIN'')')}">
>        This will only be displayed if authenticated user has role ROLE_ADMIN.
>    </div>

Соответственно, я бы попробовал что-нибудь типа

```
<td th:colspan="${#authorization.expression('hasRole(''ROLE_ADMIN'')') ? '4' : '3' }" th:text="|#{show.totalPersons} ${personList.size()}|">size</td>
```


Straightforward :)


So the problem with proxying `akamaihd.net` is that all video delivery will carry across the proxy, which is not what you want.

Are you sure this is actually needed to make these services work?

-- ab1


@pekohl DWMR. Good work here. The fact that it varies from the video - or any other possible solution (of which there must be 10,000!) - matters not. Ship code.


@sindresorhus: maybe you could cut a new release?


Why shouldn't it be there? If you continue without this, you will get issues with AGOL, because it will try to insert polygons and multipolygons, but your column only supports one of them.
besides, you need to migrate your existing data before you can let your existing systems work with this new code, because your queries will use the geometry column, which needs to be populated.
You can drop the geom column and recreate it without constraints in this process of migrating the data.


Kathy Shiao tested - push.


Which thing are you asking about, Hauxir? Window.btcTimeStamp is used.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21125/testReport/) for this commit**


sorry for this random note/question… you can have a tag that is *only* a class and not any sort of HTML object at all otherwise?? I'm just really interested in this. How does that work? Not knowing that was possible, I would have added the class to the h1…


Does this mean that PHP 5.4 is no longer supported for this library?


miss achievement.cpp added to sources into cmakelists.txt


It's somewhat surprising that Visual Studio accepts this change, because there is still a problem in the copy constructor:
```
MassMail(MassMail const& massmail)
: m_protoMail(const_cast<MassMail&>(massmail).m_protoMail), m_sender(massmail.m_sender)
{
}
```

Despite the hack to be able to take ownership away from a const object, this will not work because unique_ptr is not CopyAssignable (it is MoveAssignable though).

So I'm suggesting to remove the copy constructor entirely - getting rid of the const hack in the process is a nice bonus! - and use a default movement constructor instead. See evil-at-wow/cmangos-wotlk@403d0febbb. Could you agree with that, @namreeb?


@cehallen DWMR. Nice to see you put comments in. Keep that up.


@alexweber Thanks, sure I'll do that. But keep in mind that I switched the browser to PhantomJS, I like that one more because there's no GUI app launching while running the tests.


These are all set in InitialiseVariables.  Good change.


Why? Does a later commit add this functionality?


remove commented code


remove include


@christianharke The only reason I wasn't using PhantomJS was because I couldn't get it to run in the first place! :)   I'll probably end up leaving both options in there because they each have their merits...  Thanks!!


You don't need public inside interfaces...does this change anything?


Just remove the client stuff.


In general we want to break up weights into as many factors as possible, because the dependencies exposed in each factor is our data-flow graph and we like having precise data-flow information. That can go in the opposite direction of what "simplify" tries to do, so this additional line comes after the call to simplify. There's also all the expand/product/exp business before the call to simplify. Any help to achieve this better would be appreciated. I hope it can be isolated inside simplify_assuming.


That's some crazy AI


remove commented code and create an Impl class for your private datas


Price is the key for the object where the average price for each currency is stored in line 120, isn't it?


Yes, I'm only supported PHP version that are still getting security updates. https://secure.php.net/supported-versions.php

In all likeliness it will continue to work but it is no longer officially supported.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21127/testReport/) for this commit**


Of course, Maíra.


omg dat code ....


we need summon dalek


This is ok, unless I'm reading it wrong btAve is a single value, which won't require modification to the code calling this function (and that's good).


Спасибо! Я поэкспериментирую.


@cehallen DWMR. `return @"well done here!";`


new key is not a good message to explain what have you fixed in this commit


thank you so much for updating this so quickly :)


### Missing semicolon.

```
}}]);
 ^
```


This didn't work for me - on the latest, anaconda-mode is still written to `~/.emacs.d`

<img width="626" alt="screen shot 2015-09-23 at 1 48 02 pm" src="https://cloud.githubusercontent.com/assets/877908/10055067/db76232a-61f9-11e5-9c0e-90cfca06c482.png">


**semi**: Missing semicolon.


Sure thing Vanessa. Please see attached.
Thanks!

On Tue, Sep 22, 2015 at 9:45 AM, Vanessa Hamer <notifications@github.com>
wrote:

> Hi @dimroc <https://github.com/dimroc> -
>
> Thanks for contributing to a CartoDB project.
>
> We are doing some housekeeping, and we realized that we didn't have you
> sign a Contributor License Agreement (CLA) prior to your first contribution
> to the software. Basically, a CLA is a protective measure for both of
> us...it is license giving us permission to redistribute and use your
> contributions, while making clear that you retain ownership of those
> contributions.
>
> Here is some information on how it works: http://cartodb.com/contributing
>
> And here is the CLA for you to sign and return via email (to
> cla-support@cartodb.com) when you are ready:
> http://libs.cartocdn.com.s3.amazonaws.com/cartodb.com/static/docs/CartoDB%20Inc%20-%20Contributor%20License%20Agreement%20v1_2%2020150811.pdf
>
> Would you take a look and let me know if you have questions?
>
> The doc is designed so that you can sign as an individual (if your
> contributions were made on your own time) or have an employer or client
> sign as an Entity (if your contributions were made as work for hire in some
> way. If you're unsure, let me know the situation and I can help you decide
> which is best.
>
> Happy to answer questions you may have, and thanks again for contributing
> to this open source project.
>
> Vanessa (vhamer@cartodb.com)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CartoDB/cartodb/commit/f4f7f6effd353616f4a376639ead4f26d271d9be#commitcomment-13367464>
> .
>


ok


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/81830399


Ok thanks, I will make it easy to add new settings


fine with me. installs which still have dropbear, need to manually uninstall then.


Comment


Another comment


Die "Ganzer satz beginnend mit identifier" Regel gilt für alle godoc-comments, auch für member und Variablen und so :)


why Life manager is an inner class of application ??
move lifeManager_ member into impl_ class


Nicht documentiert


Good change, we should be using a constant dt.  The code's a little confusing but it seems like ahrs.update() is called at _ins.get_sample_rate() (i.e. 400Hz).  I trust Paul's thought about the filtering.


move lifemanager in his proper .h and .cpp


d


That's because you already have it as part of Encode
https://metacpan.org/source/DANKOGAI/Encode-2.77/ucm/cp1252.ucm


cos some men just want to watch the world burn.


it gets removed in another series for other reasons, would rather not use it here.


Der Kommentar unmittelbar vor der definition eines identifiers sollte dazu gehören (godoc würde ihn als doku des identifiers anzeigen). Also Leerzeile hier


Unused parameters were removed


Currently I rely on the update method to modify my shared instance of TAAE. I initialize my shared TAAE with `initWithAudioDescription:inputEnabled:useVoiceProcessing:outputEnabled:` and then in certain View Controllers I need to turn `inputEnabled` on and change the `audioDescription` so I use the composite update method. That said, looking closer at my code I think the streamFormat isn't actually changing.

Is there a reason for removing this method besides clean-up though?


remove boardView parameter ( not used)


Issue [#141](https://github.com/stcr/subscribe-to-comments-reloaded/issues/141)


ok, please make sure all the others are correct though! we won't be that fortunate (@MatthiasRo spotting it) next time round.


As I mentioned let's just double check with Natasha that the server will accept this format (I think iOS is only sending the 'xx')


Es gilt immer noch [MixedCaps](https://github.com/golang/go/wiki/CodeReviewComments#mixed-caps)


We could.. I was mainly going for minimal changes here, but that may make sense to consolidate things.  We could then conceivably make a way to query the failure info the mon has (what *would* it mark down if it could)...


See issue [#141](https://github.com/stcr/subscribe-to-comments-reloaded/issues/141)


Let's start with this tho?  Or do you think we need that too?


You are right, I misunderstood this, good solution that doesn't require modifying the calling code.


move the callback into Application::Impl_


Note https://github.com/AvisoNovate/rook/blob/master/CHANGES.md


I also propagate the `onlyMaster` parameter.


Comment to the first line


All PCSX2/Common exception inherit from the BaseException class. So it catches all possible exceptions.


could be good to add in a line to check that the sourceType exists, before setting it with

if([UIImagePickerController isSourceTypeAvailable:UIImagePickerControllerSourceTypePhotoLibrary]) {
    picker.sourceType = UIImagePickerControllerSourceTypePhotoLibrary;
}


remove debug messages ^^


Ja, ja, ja und ja :-)
Ich habe vor einiger Zeit eine Änderung gemacht die dafür sorgt das fliegende Bewacher nur noch von anderen fliegenden Bewachern aufgehalten werden können (Was Bewegung wie auch Treibe oder Plündere betrifft, Plündere wird normalerweise auch durch bewache verhindert).
Damit kann das entweder ganz raus, oder man Checkt ob der Bewacher fliegt und greift nur in diesem Fall an.


If `this._optionsFilterString1 is preferred to `event.target.value`, why not replace the `setState` call below as well?

https://github.com/JedWatson/react-select/commit/4f33b4899388dc0165ae0577b789f7a49dfb9428#diff-2fa4fdc2688b935716731b28ae92da06R601


"salt" als salt ist nicht fürchterlich sicher. Der salt sollte Zufallsgeneriert pro passwort sein (sonst erlaubt es salt-spezifische Rainbow-tables). Und die lib wirkt auf mich suspekt. Sie ist zumindest mies dokumentiert. Was ist "magic" und warum?


## This is a markdown


##This is a Markdown


useless function


@wenzhixin Hey! I already added expandRow/collapseRow documentation


Maybe you want to change this to `assert(ret == -1)`, because even if we remove the `!more` assert, the `zmq_send` call will fail due to the closed recipient.


return directly the value of your test:
return condition1 && condition2 && ... ;


not used remove it


It's called just above, line 120.


If it catches "all possible exceptions", then shouldn't the `throw()` specifier be removed? and shouldn't the macro also have a `catch(...) {` part to make it 100% hermetic?


This commit is a merge which brings the changes from the `develop` branch into this `tmcdb/static-pages` branch. The title of the commit message is given by Git by default, but it's not what you might expect.

If I had merged directly from the `develop` branch into this feature branch, I might have seen conflicts and that could have become messy. In stead what I do when I want to bring a feature branch up to date with another branch is I branch off the feature with a name of the format `tmcdb/merge-<branch_name>-into-<branch_name>` and resolve any conflicts there.

If the conflicts become confusing or I make a hash of it late at night, I can happily abandon that merging branch and try again without worrying about backtracking and accidentally losing code along the way. Then when I'm satisfied I hop back to the feature branch and merge in the merging branch with a guaranteed _fast-forward_.


74564912Issue4347BBRadConvHW (wfbuhl) - i386-Windows-7-VisualStudio-12: OK (1888 of 1891 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


I'm doing it to be equal to the flixel code convention


write a better message for your commit


You should use parenthesis or change the docs to reflect the example as used here:

> You should see the following output:
> ```java
2015-06-22 13:55:47.688  INFO 71932 --- [main] hello.Application    : Quote(type=success, value=Value(id=5, quote=Spring Boot solves this problem. It gets rid of XML and wires up common components for me, so I don't have to spend hours scratching my head just to figure out how it's all pieced together.))
```

and yes, I'm finicky :P


We could but I'm worried that if the plugin doesn't return something sensible (i.e. unique), the `addPaymentMethod` call will always fail if no external key is set.


remove debug message


74564912Issue4347BBRadConvHW (wfbuhl) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (817 of 817 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.67%25-green.svg)


This commit breaks every other platform. Why was the const removed?


klm3952, your RunVoting.in violates the rules of the input, candidate limit is 20.


This fixes #173.


I really like that report output :+1:


@Snaipe, FreeBSD build was failing, until I applied this patch:

```diff
- int mib[2] = { CTL_HW, HW_AVAILCPU };
+#if defined(__MACOSX__)
+  int mib[2] = {CTL_HW, HW_AVAILCPU };
+#else
+ int mib[2] = { CTL_HW, HW_NCPU };
+#endif
```

Then build with `-DCTETST=ON` and `--target criterion_tests` succeeded.

However, running `ctest` failed 1/77 test. Here is a salient snapshot on how it transpired:

```csh
root@fbsd-pc:~/projects/Criterion # ctest
[...]
77/77 Test #77: criterion_unit_tests .............***Failed    0.01 sec

99% tests passed, 1 tests failed out of 77

Total Test time (real) = 106.96 sec

The following tests FAILED:
         77 - criterion_unit_tests (Failed)
Errors while running CTest

root@fbsd-pc:~/projects/Criterion # test/criterion_unit_tests
[----] /root/projects/Criterion/test/asprintf.c:63: Assertion failed: The expression (cr_asprintf(&actual, "%")) < (0) i
s false.
[FAIL] asprintf::invalid: (0.00s)
[====] Synthesis: Tested: 9 | Passing: 8 | Failing: 1 | Crashing: 0
root@fbsd-pc:~/projects/Criterion #
```


Sorry, I misinterpreted your comment so please disregard my previous comment. I think clamp is the wrong word which threw me off. Perhaps a better word is to "freeze" the integrator when roll is above TBD angle. If the integrator value is always in the same direction, which I suspect you're right about, then resetting will not be necessary.


@lowfatcomputing: Thanks for explaining. Consider putting such info in the commit message. Pushed to master (23ed438d5a474ff17593693213c94d71826fce3f and parent), with modified commit message.


I already have another pull request open for fixing this. #5948


Hi Xu,

Even if I use the return type as file it still makes no difference, I still get the error

Exception in thread "main" io.swagger.client.ApiException: can not deserialize Content-Type: application/octet-stream

actually the return type was immaterial for file fownload, in my case the generated stub used to have return type string and then I could call getBytes() and get the byte content. The key thing was that the application/octet-stream was supported for the response and I can see that in your change for the deserialize() method only application/json is supported, I think this is what is causing my code to break.


Is javascript:signup() set in stone for the auth0 blog? Will this work in the future?


This check is not necessary as `file_node.delete` will check for you


use a 403 here


i no rite, 2nd place in the grand tournament

On Wednesday, 23 September 2015, Jeremie Lasalle Ratelle <
notifications@github.com> wrote:

> That's some crazy AI
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ffortin/berlin/commit/b3f09e4cf3fc148b0cbf3c694df927162fafc293#commitcomment-13398293>
> .
>


Just so you know, this will result in any meteor version previous to 1.2 won't be able to use 1.0.3 or later of this package.


Update CSS


Yes, but wouldn't it need to be called like so: btcAverages[currency].price?
The former implies price is a string variable that holds some value, doesn't it?


`self.checkout is not None` or `bool(self.checkout)`


You want screenshots here?


I do see it is because you're calling `getAssetPath()` below and that isn't const. Still, it breaks every other platform. :)  I don't think it is a good solution, it would be preferable to keep the const (or add it to `getAssetPath()` although that is involved).


maybe `is_checked_out`? No strong feelings


There's also `get_post_type_object( $post_type )`, which might be a bit more efficient.


problem:
can return invalid coordinates if pos is not contained by boardRect
manage the case or assert if xpos and ypos is contained by boardRect


For example, in `wamp_session::start` we should probably just wrap the sending/receiving of the handshake in a try-catch block. If an exception is thrown we should do this 'm_handshake.set_exception(boost::copy_exception(e))'. Then return `m_handshake.get_future()`. Make sense?


Why this change required ?


you are right, it's used. Is there a reason for btcaverages to be global though?


be more descriptive with the filename!

@protocol SocialMediaViewDelegate <NSObject>


@rahul1aggarwal what's the purpose of this change?


:-1: You asked for it :-) Let's do it i a small clean-up-rebase when we finished.


Now, `textTransform` can be applied to all buttons (both `FlatButton` and `RaisedButton`), only `FlatButton`, or only `RaisedButton` on a theme-level.

Here is how:

```js
let newMuiTheme = ThemeManager.getMuiTheme(LightRawTheme);

//override theme variable for button
//this override will apply to both FlatButton and RaisedButton
newMuiTheme.button.textTransform = 'none';
```

```js
let newMuiTheme = ThemeManager.getMuiTheme(LightRawTheme);

//override theme variable for only RaisedButton or FlatButton (substitute accordingly)
newMuiTheme.raisedButton.textTransform = 'none';
```

`textTransform` corresponds to the CSS `text-transform` property and can take any valid value that the CSS property can take.


Did you think about using `docker-py` instead of running subprocesses? I know we do it this way right now, but that was mostly due to the lack of time, maybe we should fix it with the rewrite. What do you think?


You may want to include additional information about the file here, name or path or something? Just so users will see a nicer error message, nice but not required.


This change seems worth separating from the rest.


`return`


It didn't work. Oh well


This method is actually used in the UPMC code [1], we need to take care that everything continues to work after this modification (perhaps it was a bug that corrupted also their results).
cc @rlober

[1] https://github.com/ocra-recipes/ocra-wbi-plugins/search?utf8=%E2%9C%93&q=getQuaternion


Thanks, Dimitri...but I think the attachment didn't come through. Would you please try to resend or email it to me at vhamer@cartodb.com?


js for actions


I don't understand why jquery-ui was removed just based from the commit message. could anyone explain why it became unnecessary.


@remh Only downside with this is that nested is not available in contextlib in Python 3+


I don't think that functionality exists today, but I would welcome a patch adding support for it.


Yep I agree. I just grabbed the headers ( no libs ) to see if things would
compile without linking and hit this so thought I'd point it out. If you
don't think its worth supporting this version of the header then that is
fair enough. Future head-scratchers might appreciate this dialogue. Thanks
again.

On 23 September 2015 at 18:58, Jakub Szuppe <notifications@github.com>
wrote:

> I'm sure you can use AMD APP SDK with any modern x86 CPU. You can check on
> AMD APP SDK website.
>
> I think those OpenCL headers from repo are just old.
> 23 wrz 2015 15:03 "Daniel Murray" <notifications@github.com> napisał(a):
>
> > I'm using the opencl-headers package from debian version
> 1.2-2012.04.18a-1
> > which supposedly is 'as published' by Kronos, although that's clearly not
> > true :)
> >
> > I can't just use the amd/nvidia sdk because this is just a little netbook
> > that I'm testing things on. I was hoping I could target just the cpu for
> > testing. I can compile and run with a dummy icd ( again from the deb
> repos
> > ) just fine provided I define the inclusion of that symbol.
> > On 23 Sep 2015 11:39, "Jakub Szuppe" <notifications@github.com> wrote:
> >
> > > What kind of OpenCL SKD do you use? Because it's really weird cl.hp
> > file. #ifdef
> > > CL_USE_DEPRECATED_OPENCL_1_1_APIS does not occur in original one from
> > > Khronos website https://www.khronos.org/registry/cl/api/1.2/cl.h.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/boostorg/compute/commit/c882466dbd2a3d9f3d8132075cf92d06f557930a#commitcomment-13387532
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/boostorg/compute/commit/c882466dbd2a3d9f3d8132075cf92d06f557930a#commitcomment-13390074
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/boostorg/compute/commit/c882466dbd2a3d9f3d8132075cf92d06f557930a#commitcomment-13397297>
> .
>


Empty method?


? I wanted to avoid defining another function which just opened a file and called the original `saveModes()`, since this latter was used only for saving the settings and was just a few lines long. How should it have been done in your opinion?


Does GroupId actually exist here?  I thought it was in urlMetadata


Or I guess this is a convenience method.


Issue [#119](https://github.com/stcr/subscribe-to-comments-reloaded/issues/119)


Why not use `_cleanup_free_` ?


@c-rack sure, my bad.
I've fixed this one.


this should be `|version|` for sphinx to replace


PMD: website.frontrow.board.Enemy defines clone() but doesn't implement Cloneable, BAD_PRACTICE, High
<organisation


Why the cast?


Should be `http://localhost:9080`


PMD: website.frontrow.board.Player defines clone() but doesn't implement Cloneable, BAD_PRACTICE, High
<organisation


Removed redundant code and refactoring for better performance on ARM


74564912Issue4347BBRadConvHW (wfbuhl) - Win64-Windows-7-VisualStudio-12: OK (1888 of 1891 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


This line assumes V is column major, which it may not be.


PMD: website.frontrow.board.Bubble defines clone() but doesn't implement Cloneable, BAD_PRACTICE, High
<organisation


That should be part of the `else` clause above, no?


This doesn't quite solve the problem of making pipelines fully relocatable: external resources like input files and init models which won't move with the pipeline must be specified by absolute path, but we don't yet do this.


Should be "Independent expenditure"


No reason, will revert.


Ack.


Is that a stray `\` ?


Better name in WEB Interface is "IP Blocking" than "IP Blocking Recordings"....
Maybe you change it ?


:D Thanks!


Please, use the logger format of: [CLASS_NAME]\t[Additional Note if applicable]\t<"Message">
<naming,organisation


The test is most probably failing because of the underlying vsnpritnf implementation not returning something less than 0 for an invalid format string -- I had the same issue on Windows.

I'll probably have to conditionally disable the test on anything other than linux and OS X.


Типа первый комент


@kswedberg Thank you so much for checking this :-) and @AurelioDeRosa for the PR :-) :+1:


@azturner There's a section [here](https://github.com/SparkDevNetwork/Rock/blob/74cb7efed1b0d1edb9355099f6988708821b2e14/Rock/Web/UI/RockPage.cs#L657) to automatically SetContext based on query strings, but I can't seem to get that to work.

@edolyne is troubleshooting a block that displays info based on the Group context, but passing GroupId=XXXXX in the URL doesn't change the context. He has to add the Group Context block and manually change for the cookie/context to update.


This is overly verbose, I don't think it necessary to always explain what everything is (e.g. explaining what a payload manifest is).  Anyone using the library will probably have some idea of what different things in the bag are and what they're called.  It should suffice to just say "return a list of payload `Manifest`s".  This goes for the other `get*Manifest()` methods here


Empty method?
<bug,organisation


See comment above


That `else` is unnecessary, but that's a nit.


should be wrapped in quotes `"|version|"`


```ruby
auth_ids.map do
  #...
  solr_doc.root
end

```
Would be nicer than

```ruby
docs = []
auth_ids.each do
  #...
  docs.push(solr_doc.root)
end
docs
```

(I know this was probably copied from another harvester that does it the `each`/`push` way...)


ci:retest


Зачем нам загружать к себе в память полностью всю apk-шку? Тут нужно просто весь поток из urlConn.getInputStream перевести в resp.getOutputStream. Для этого можно использовать IOUtils.copy


delete


Good luck today


I don't think this was necessary. See: https://github.com/mongodb-labs/mongo-php-driver-prototype/commit/12265c816f23314df393659689e5b5cabe5cd886


the method compare_group_name in the base class RGWAccessControlPolicy always returns false which leads  to the user with id "anoymous" to be NOT considered a public user and hence was considered as an authenticated user and so even with authenticated-read ACL on a bucket, "anonymous" user was able to list the bucket. The RGWAccessControlPolicy policy object should be created according to the type of the request.


Thanks!

1. How do I build the app using Gradle from command-line? I ran gradlew (from Android Studio) in nogotofail/clients/android and it failed as follows:

* Where:
Build file '<SNIP>/nogotofail-github/nogotofail/clients/android/app/build.gradle' line: 1

* What went wrong:
A problem occurred evaluating project ':app'.
> Could not create plugin of type 'AppPlugin'.

2. Please update the BUILD file so that Bazel builds continue to work. Because this change is moving the source tree to a different location, the paths in srcs, resources_files, and manifest parameters need to be adjusted accordingly.


got it
but why it pushes r3, r4, r5 instead of r3, r5, r6 in the beginning?


When using context, the block may have a setting that needs to be set to specify which context (unless it's hard coded in the [context] parameter, and the page has a setting for the context parameter. Has he set both of these?


Indentation looks wrong, there should be a line break after the `{`.


yeah that one was for testing. remove.


Yuck. Works, but I'd love a better solution!


This was amended in a later commit.

< review


Is there a way to disable this? I want to test the onbeforeunload method. However, whenever I call `window.onbeforeunload()` I received the error message.


Also here, the `else` is not needed, but it doesn't harm either.


You should always fix the code if you propose the changes.
Do it. #程式碼是拿來改的


This one looks good to me.


nice. that makes more sense now.


imports were deleted, need to restore


I keep getting an error when i place my method advTime into main I've tried a million different ways all the same -__-


[should be in the air right now, but flight turned around as we hit a bird.  Yay.]

I fully understand why you have added this code, it makes sense.  It is the method of achieving this aim which is hackish.  I'll try to think of a better way to do this.  Unfortunately, nothing specific is coming to mind right now...


This is the attempt to bring local vars from the blocks that make up the proof to the generated rule. For some reason this does break the JS in rendering. Also it does not take into account free vars and/or scopes.


:shipit:


This isn't right.  see [`AbstractBag.getBagFile(String filepath)`](https://github.com/alangho/bagit-java/blob/master/src/main/java/gov/loc/repository/bagit/impl/AbstractBag.java#L341).  This method returns the `BagFile` object that corresponds to the given filepath.  Again, unless totally sure, you should always verify with the concrete implementations that the javadoc matches what is actually being done.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.978.75564b6da49127811f9c90dfd41d41df7cba1a52](http://build.palaso.org/viewLog.html?buildId=63698&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 516, ignored: 6 Build time: 00:07:24


Using {} as 3rd parameter crashes the form on submit


Again, overly verbose imo.


First of all, thank you so much for improving Mosby github pages. Unfortunately I haven't had enough time for.

Yes `getData()` is missing in sample. I thought not to add `getData()` since it is something `LceViewState`related. I didn't wanted to make things to complicated in the getting started section and cover that in the ViewState section.

What do you think?


créé le 23 septembre


Don't we need always to subtract one from `i`? `entry` should be inserted between the old entries `jumps[i-1]` and `jumps[i]`.

 So for `i=1` entry should be placed between `jumps[0]` and `jumps[1]`. But after `jumps[0]` is removed and `jumps[1]` is moved into its place, entry is placed after the old `jumps[1]`.


Seems redundant.
<logic


Mach die Leerzeile oder mach sie nicht, aber sei halbwegs konsistent :)


Wut?


It's less a new issue, it's more the wish for a different or new branch to allow reviewing before it hits experimental. Not crucial, though.

This commit: well spotted and excellently fixed! Thanks.


It's getting key: currency, key: price.

Though it would be more clear to use [currency]['price'] since in this case currency is a variable, but price is just the string 'price'.


we upgraded to the newest fullcalendar, which does not require it. You are right though. it should have been done in a different commit.


I suppose this is related: http://hydra.nixos.org/build/26209088.


It needs to be stored, so if the timestamp is less than 15 minutes old, the stored values can be used.


`Inputstream` should be `Outputstream`.  Also, javadoc should read something like "ouput stream to write manifest to" or something along those lines


This will create different tables for different elections with redundant headings!
I suggest you to either add this information along with `large_button` above, or remove `large_button` altogether & make the "Name" column link to respective election. I prefer former :smiley:


`InputStream`->`OutputStream`


Alright, then that's fine.
<review


remove this constructor


I'm back man! :D


Le 23 sept. 2015 � 18:18, VoyagerOne <notifications@github.com> a �crit :

> One idea I had is to apply draw detection in SEE.
> Example:
> White has 1 pawn, 2 knight.
> Black has 0 pawns, 2 knights.
> Black captures the pawn and white captures 1, or even 2 knights.
> White has a positive SEE, but the position is now dead draw.
> White could have promoted the pawn and win.
> .........................................................

I'm not an expert of SEE, but this sounds like a good idea!

Now we just have to code and test it :)


strings.Join([]string{name, token, timestampstr}, "-")


I'm ok with propagating exceptions up via promises but I think there are a few cases where there isn't a promise for this. For instance when a session is running after all registrations/subscriptions have been made, it is waiting on an async read from the socket. What happens when during the receipt of a new message at the session layer we encounter a receive error from the socket, indicating that the connection has been severed?


Warum ist eigentlich payload von fixer Länge? Das wirkt auf mich… komisch. Vor allem, welche Funktion erfüllt das Token, wenn es offenbar beliebig lang sein kann?


miss a display of lives for the user


@gilbitron I'm guessing this is a WIP? I still see lots of `GP::$user` stuff in the codebase.


Das geht kaputt, wenn `contentLength < len(name) 2 len(timestampstr) + 2`.


From looking at the [`AbstractBag.getChecksums(String filepath)`](https://github.com/alangho/bagit-java/blob/master/src/main/java/gov/loc/repository/bagit/impl/AbstractBag.java#L593-L612), the original javadoc (in red) is correct.  This method gets the checksums for a file from all the manifests.


agree with you


On what OS you test it?


Still need to wrap the returns as a vector or matrix. matrix_matrix_multiply does not work. Hoping to spend more time on that part later.


Thanks for the pull request. Haven't reviewed fully yet but I have a couple of comments from a cursory look.

You guys added new parameters "durable" and "autoDelete". Just curious what the need is for varying these from the defaults?

You're catching Throwable at one point. I think it's preferred to catch only Exception, because we probably don't want to catch java.lang.Error, should one arise.


Again, if you're unsure, please verify that the javadoc you write coincides with the implementation.


This is the instance I am talking about. What happens if the socket is closed unexpectedly by the remote end. I assume we should try to reset the session to a disconnected state such that future calls will fail as there won't be a valid session.


@dominikhajduk
in the each test we should be able to indicate AAA parts (arrange, act, assert), IMO here it's difficult to do


IMHO: Ersetze das Token durch eines fixer Länge. Dann kannst du das alles ersetzen durch `fmt.Sprintf("%s-%s-%d", name, randString(tokenLength), unixtimestamp)`.


Surprised you were able to resist the temptation to make the regex `/\v<E80[23]>/`, saving ___uncountable___ bytes.


(und kannst randString auch gleich ersetzen durch `generateToken` :)


paintEvent (remove the capital)


@rahul1aggarwal does this mean that when accessing the object through swift we'll get different behavior?


In this case, like:
```java
addToLog("[GAME]\t[LOST]\tYou just lost this level.");
```
?
> review


The point of the if-statement is to stop your program from creating a new dialog every time it enters this function (memory leak).  It would be more appropriate to use:

```c++
if (!optionDialog_)
    // do stuff
```


Thank you so much! We're all set.


the 'b' in `BagPartFactory` should be capitalized


Nearest:
![wormhole_nearest](https://cloud.githubusercontent.com/assets/9447478/10056232/84a2990c-623a-11e5-94a0-3f3f7f7ab23b.png)

Nearest linear:
![wormhole_nearest_linear](https://cloud.githubusercontent.com/assets/9447478/10056233/853017dc-623a-11e5-9d5e-957ed315dba5.png)

Linear:
![wormhole_linear](https://cloud.githubusercontent.com/assets/9447478/10056231/8478576e-623a-11e5-992b-215b5f0f95b6.png)

(BTW, those pillars were black once. What happened to that?)


What is being done here?


Wouldn't it be easier to simply forward the logs of every running docker image to a central location? Something like logsprout that forwards to a central logstash instance?


TeamCity Gribble ORM :: Deploy [Build 1.6.132.0](http://build.mikeobrien.net/viewLog.html?buildId=2469&buildTypeId=gribble&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 412 Build time: 00:02:41


Und hier sehen wir ein Beispiel dafür, dass Kommentare und Code immer irgendwann divergieren.


display a text for the user to explain what is this number


This has nothing to do with the solo mining bug.  It's a json decode issue.


@yehudasa
RGWAccessControlPolicy_SWIFT does not override compare_group_name, so the behavior for swift will still be same


I wanted someone to test it because it's the only change in the first non working release which is not in cuda algo code.


To be consistent with other modules in this repo, please use mergeOptions, like in [this file](https://github.com/scottnath/pattern-library-utilities/blob/clone-pattern/lib/gulp-tasks/clone.js#L66):

`var options = mergeOptions(getDefaultOptions(), projectOptions);`


Awesome - thanks !


to keep code dry, please re-use existing functions. Get options already exists here:
https://github.com/pattern-library/pattern-library-utilities/blob/master/lib/get-options.js#L19

once the [clone system](https://github.com/pattern-library/pattern-library-utilities/pull/14) is in place, this will point to [merge options](https://github.com/scottnath/pattern-library-utilities/blob/clone-pattern/lib/get-options.js#L24). This will also help in removing `lodash.merge` as a requirement of this file.

Please rename this function to `getDefaultOptions` to return the default options, which can be used with mergeOptions (see above). In other files, getDefaultOptions is located near the top of the file.


original comment for this is correct.  `visitTag` is called for each tag file separately


duplicated code ! move it in drawutils file for example


note: doc for `startTags` *is* correct


The GroupContext block context scope is for the Page.  I don't see a Context option in Page Properties though.
<img width="427" alt="screenshot 2015-09-23 15 43 58" src="https://cloud.githubusercontent.com/assets/1210933/10056630/f0524f70-6209-11e5-8667-22631f6c17d8.png">

Is there an example block where you're using the query string to set context? Something like
http://localhost:6229/dashboard/guestservices?CampusId=2&GroupId=285294


awesome thanks


Like above, original for this method seems better.


duplicated code create a class which generates a color


@zimme Right, just changed to 1.2.


@mdawaffe good one, didn't thought about using it. If you want, you can check project again now since I've started implementing the revisions slider. You can see how they're fetch in JS console.


function not used (remove it)


This should simply work well. If not, there is a chaos in chess engines' tuning.


TeamCity pull requests :: netty [Build 263](https://garage.netty.io/teamcity/viewLog.html?buildId=1599&buildTypeId=pulls_netty&guest=1) is now running


not used, remove it


thank you!


Warum übergibst du hier eigentlich eine Map? Warum nicht einfach einen Channel übergeben und den lookup in der main machen?


@rahul1aggarwal will be the same as the base class, not the same as S3, right?


lotsa merge errors got in here


`api.versionsFrom(['1.0.3.2'. '1.2']);`
will make it work with old and new versions


move include in .cpp


Parses otc log file, rather than the (thousands of) subproblem files themselves.


Weiterhin: Du nutzt nur c.Name. Ich glaube, du kannst auch einfach name übergeben?


Wait wtf. That should be a non zero exit code.


ok that makes more sense, thank you.

On Wed, Sep 23, 2015 at 1:42 PM, Darren Hunter <notifications@github.com>
wrote:

> The point of the if-statement is to stop your program from creating a new
> dialog every time it enters this function (memory leak). It would be more
> appropriate to use:
>
> if (!optionDialog_)
>     // do stuff
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dleacock/XPSDisplay/commit/dbb136a7ba0c07a816aafb0325e46908bed5f0af#commitcomment-13399528>
> .
>


great job !

is this working ?

And what about wakelock issue that the phone can't enter in deep sleep after dt2w was activated one time ??


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21129/testReport/) for this commit**


Addresses https://github.com/deanius/meteor-promise/issues/4


Can you add a docblock with only a description here, just like the register method


Can you make the new helper method create the exact same temp file (name and path) as the original code?
That we we reduce the chances of introducing new bugs. :)


Adding this to libcollectd_la_LIBADD works. Cool!


Ok, I got it. I think this change has a good reason.
Right now, our sample is only twinkle twinkle little star. But, in future, we may get more samples as self-study materials. In such a case, having "core" and others will be a good project structure.


Вопрос такой, а как теоремы и утверждения предполагается оформлять? Спасибо =)


You might want to add "4" while you are at it :-)


Read it again.


We are always in a receive state on the socket. So in the case where it is
closed unexpectedly we should allow that exception to propagate on its own
and let the application deal with the exception accordingly. Any further
usage of the session to make wamp calls will run into the problem of trying
to write to an invalid socket and should then receive an exception
propagated by the corresponding future.

On Wed, Sep 23, 2015 at 3:41 PM, Nicholas Wiles <notifications@github.com>
wrote:

> This is the instance I am talking about. What happens if the socket is
> closed unexpectedly by the remote end. I assume we should try to reset the
> session to a disconnected state such that future calls will fail as there
> won't be a valid session.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stopthatcow/AutobahnCpp/commit/99a25e4e2373dfe96b6c3bdddbc2b450b5253536#commitcomment-13399517>
> .
>


The id from the route is "1" or "2", or whatevever, basically it's a string, so you cannot "dec" it in open function. That's what it means by java.lang.String cannot be cast to clojure.lang.Number or something like that. You can use read-string to get the number out of id.


create a function to generate this array from mode enum values


@yehudasa
yes, same as the base class i.e the current behavior
I have not used the swift api with anonymous used id, may be the issue will still exist with the swift api.
Is it better to compare with "anonymous" in the base class method itself and always create the base class object like in the current code ?


The docker logs do not contain the complete LogService logs, only logs that (also) go to std out afaik. The logsender is registering itself as LogListener to LogReaderService, and sends all LogEntrys over a Socket to a configurable central Logstash instance (which in turn parses the log, saves it in Elasticsearch, which is accessed via Kibana web UI. I added a ELK pod in a separate branch in the k8s cluster and a ELK docker-compose configuration to demonstrator workspace)


change mode to currentMode


"documentation is completely inadequate. Compiler errors range from confusing to actively hostile. Support is maintained by a team of, what, five? At most. In many respects less elegant than the platonically ideal form decoded from martian transmissions two years ago. STAY AWAY."


I can't get through the tutorials, so, this is best guess


Was I suppose to use getters and setters to initialize the public instance variables in the Patient class via user input - then display them via the method, or use the argument in the multi-argument constructor? Either way works...but what is the preferred way?


remove the default value for mode


Ich habe gerade diesen code verstanden. IMHO sollte es möglich sein, dass mehrere Mails gleichzeitig in-flight sind. Es ist doch irgendwie etwas unterschiedliches, ob eine Mail ne Stunde später erst ausgeliefert wird, aber sonst Mails durchgehen, oder ob gerade *gar keine* Mails durchkommen, oder? Aber für dieses design sieht das doch gleich aus, oder?


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 694](https://teamcity.labkey.org/viewLog.html?buildId=273781&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:28:03
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

##### there are 23 more failed tests, see build details
```


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.979.e42322bd54bf053badf2861bc256c1b7d97b67e5](http://build.palaso.org/viewLog.html?buildId=63703&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 516, ignored: 6 Build time: 00:07:43


Und als feature-request: Wenn Mails nicht vernünftig zugestellt werden können, die Mail ID mitloggen. Das wäre für mich eine condition auf die ich alerten würde und dann will ich direkt alle Informationen haben die ich brauche, um das Problem zu beheben.


Ugh


Der Kommentar sollte mMn nicht `$(…)` enthalten, das wirkt komisch auf mich. Ich würde einfach MonitoringInterval schreiben, in dem Verständnis, dass Leute, die das Lesen, den Identifier greppen können.


It's good you pointed it out. It made me think again about this problem with different OpenCL versions.


Ok, so if we threw an exception on bad receive it should get propagated to caller of the io_service::run() fn?
Where we could handle it there?

> On Sep 23, 2015, at 12:54 PM, davidchappelle <notifications@github.com> wrote:
>
> We are always in a receive state on the socket. So in the case where it is
> closed unexpectedly we should allow that exception to propagate on its own
> and let the application deal with the exception accordingly. Any further
> usage of the session to make wamp calls will run into the problem of trying
> to write to an invalid socket and should then receive an exception
> propagated by the corresponding future.
>
> On Wed, Sep 23, 2015 at 3:41 PM, Nicholas Wiles <notifications@github.com>
> wrote:
>
> > This is the instance I am talking about. What happens if the socket is
> > closed unexpectedly by the remote end. I assume we should try to reset the
> > session to a disconnected state such that future calls will fail as there
> > won't be a valid session.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/stopthatcow/AutobahnCpp/commit/99a25e4e2373dfe96b6c3bdddbc2b450b5253536#commitcomment-13399517>
> > .
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/stopthatcow/AutobahnCpp/commit/99a25e4e2373dfe96b6c3bdddbc2b450b5253536#commitcomment-13399796>.
>


Just realized we did not do matrix addition or subtraction for W2 D1 assignment, so they aren't in here. Need to go write those functions and add them to both W2 D1 homework and this homework.


hmz. Ich finde auskommentierten Code immer noch blöd.


@MarinaSD В отдельную тему переместитесь, пожалуйста, - не надо все вопросы в одну кучу.
https://github.com/AndreyAkinshin/Russian-Phd-LaTeX-Dissertation-Template/issues/62


Using public instance variables with info from the setters to be displayed via the method.


I thinks you should remove this class if you don't use it


I don't think you should set the validity range to just the date a calibration was taken.  Biases and flats are often shared for an entire observing run.


so true, but to note: Sidetiq doesn't work with Sidekiq 3.5 so I wanted to lock it to `< 3.5`


I don't think you want to specify validStart and validEnd individually for each calibration set.

And how do you avoid overlaps?


Don't think you need to pass in width and height. They seem to be unused in the Full function


@biyeun i think this is pretty hard. most of our site uses knockoutjs and people will have to know to set this in order to get knockout to load. also, this bumps our knockout version from 2.3 to 3.1 and i know that there are backwards incompatible changes (in particular TF breaks on 3.1). personally feel like the barrier to entry should be as low as possible


Every solution seems unfit for commercial use, I am going to stick with base `slick-carousel`.


You should add this to the interface so that this method can be used


LGTM


Thanks， PR accepted..


Maybe these checks should be moved to the subsequent thumbfile commands. There should be some type of input validation for custom, square, circle, and thumb types.


test


I don't think the references to nunit are necessary here


Should this be `if (schemaObj.validate) callback(null, schemaObj.validate);`? That way compileAsync always calls the callback with a validator function rather then sometimes a validator function and sometimes a schemaObj.


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1851 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.41%25-yellow.svg)


i'm unfamiliar with the casting behavior of go still - does casting nil -> int make 0 or nil? if it casts to 0 we shouldn't even have to check, it will just return a 0x0 image


Hi @spcui ,
I guess ldoktor means we can disable/enable legacy/modern for every device.
if it's in the loop it will be disable/enabled at the same time.
get out of the loop will make it more flexible.


并稍微使用一些明确的使用期 ->
并稍微使用一些显式lifetime的高级用法


Ok, obrigado pelo feedback, vou tomar cuidado com isso.


"This method has a constructor name", you should remove the word woid to make this a constructor of the class


atualizado!!


This may require the EKF noise parameters to be retuned as it changes the gain from attitude error to quaternion correction