I investigated a bit. clang not working is a Fedora 22 issue. I tested my OpenSUSE VM (clang 3.5.0) and it compiles fine there. On my Fedora VM it manages to reach the `__builtin_va_arg_pack` stuff when it's not supposed to.

SSE2 compiles fine without this commit. Native build (AVX2 in my case) without this commit fails with (at least since 3.5.0, I don't have earlier versions to test):
```
error: expected expression
return extract<i / 4>().extract32<i & 3>();
                                         ^
```


#16 But using -v will cause the coverage tool not working, so maybe it's a better idea to have several scripts.


It is usually a bad idea to change history in a public repository; it forces everyone that did a pull before the forced update to do git fetch && git reset origin/master --hard


@chrisroos: While that assertion would currently be correct, if any flow names were duplicated between smartdown and smart answers, it would no longer be correct. And as such I think it would be misleading. I think I'd go with `any` or even just assert that the method can be called without an exception...


lol yep. that's what happens when I don't have enough coffee. :smile:


Oh noes. If I were you I would add a huge disclaimer on top of your README files that says that it swizzles everything to shit.


Shouldn't we always use braces for the `catch` clause even if empty?  This looks weird to me without any braces.  I would prefer to have something like this:

```c#
catch (ObjectDisposedException)
{
}
```


Looks like it fixed the issue.
One last thing:
```rebol
  length? read/binary http://itineror.com/books.zip
;   134770512
  length? read/binary http://itineror.com/books.zip
;   208702657
  length? a: read/binary http://itineror.com/books.zip
;   208702657
```
2 and 3 are reporting correct size while 1 not.
I did have low network in the first case, so it may have timed out.
Wondering if you could add a check to compare returned data size
with size (if provided) reported in the response header, and raise
an error in case they mismatch.
Thank you!


I would expect to see a `DefaultConvert` call in here.


No problem.  I had thought about implementing it that way, but thought that by having 3 * !=, it will stop at the first != and return true, whereas with your suggestion it needs to evaluate all three.  I'm sure it doesn't matter, but that was my logic behind doing it that way.


Special Content Page


His coffee made him to track validus common
So to fix he need beer 🙌🙌🙌


`	if err := s.DefaultConvert(in, out, conversion.IgnoreMissingFields); err != nil {
`


> Картинки рендерятся везде, кроме Chrome.

Это `localStorage` браузера надо сбросить. Помнишь как в контроллере каналы загружаются? Если каналы есть в `localStorage`, то берутся оттуда, иначе из заглушки в коде. Соответственно, все изменения в коде идут лесом, пока что-то можно взять из `localStorage`.

Стоит выполнить

```Javascript
localStorage.clear()
```

из консоли разработчика и картинки рендерятся везде!


The `DefaultConvert` would make this unnecessary.


Ok, thanks. I have cleaned it out in i3, too.


`DefaultConvert` might work here too.


thanks! :)


`in.Metadata` should trump `out.DownwardAPI`


#4402-VRF-outputs-and-multiplied-floor (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-58.79%25-red.svg)


For some reason git merged here while I wanted to merge in a branch with the same name on my account. I'll try to revert this.


No, you made a great point, leave it as is.


spelling error


ok


Should we add a warning at the comment of this method that the return value *must not* be modified. I know that this approach is against "Item 39: Make defensive copies when needed" of "Effective Java", but for the sake of speed, it's OK IMHO.


Probably. Yes we are using 5.x for all builds.
Newer versions require newer Mac OS versions which will break XMLVM so we can't just upgrade without breaking compatibility for some older apps. We'll do it eventually but right now 5.x is the target.


Good catch.


Looks like an accidental `=` was added here


Where did you find all those updates?
It seems to be more updated than https://gitlab.com/mkretz/vc/blob/master/cmake/OptimizeForArchitecture.cmake


I'm merging this, but it's also good to remember that we could mock an empty ```fs``` module to avoid having the actual ```fs``` module go through the minifier, dead code eliminator etc.


Thanks!


Honestly, I was aware of this name mangling before and that is why I had tested this more than once. According to pgAdmin, the constraint name looks exactly like you said - it is truncated accordingly. I will check it one more time tomorrow morning and I will let you know.


finished README


Yeah, it might only have been clang? I guess it depends on when it runs the semantic checks; whichever part of the compiler figures out that miblen is a const, would suppress the error.


I don't know exactly how subscription-manager works in the container, but removing subscription-manager has also the effect of removing ```redhat.repo``` from ```/etc/yum.repos.d``` (even though I can just link it back from```/run/secrets/rhel7.repo```).  Can it be re-created by subman later?  If so, then probably removing subman will prevent it.


It's good to remember that we could mock an empty ```fs``` module to avoid having the actual ```fs``` module go through the minifier, dead code eliminator etc.


the MacBook is mine, the rest is taken from here
https://github.com/tunabrain/tungsten/blob/master/cmake/OptimizeForArchitecture.cmake


#4402-VRF-outputs-and-multiplied-floor (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Actually, this just looks like a funny diff. The braces are there, and the clause is not empty (it contains the `ErrorCode = (int)errorCode;` statement below).


Yay


tabs https://code.google.com/p/kappa-ui/logo?cct=1392068040


I guess I can filter it out in CrossJoinBuildOperator, before the PageSource is built?


Fixed. Good eye! :eyes:


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1346 of 1346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.27%25-green.svg)


@kofalt Thanks!


Hi5 is 100 range, you can say no, but it's 100, I tested it on several servers OFF.I did even a video to show it


I had one thought, any concern about a conflicting Vine shortcode already being defined? I know the official Vine plugin uses the same shortcode tag, but with different params: https://wordpress.org/plugins/vine/, but there are probably others.


Thanks for saying so, it's fixed now.


You are not able to do this because you have insufficient Rift Crystals.


**Eslint**: 'return' outside of function


Ah, didn't know that function existed, will try that soon.


Misspelled coconut


Ok, yes I'm nit-picking, but since the change is from `stash` to `bitbucket server`, shouldn't the maven properties `bitbucket.version` and `bitbucket.data.version` be `bitbucket.server.version` and  `bitbucket.server.data.version` ?

I'm envisioning a future where the plugin is compatible with `bitbucket.cloud` and `bitbucket.server` ;-)

Thanks again!


> I had one thought, any concern about a conflicting Vine shortcode already being defined?

Not super concerned, as our shortcode can be disabled. For Fusion, we'll be overriding any shortcodes defined by Jetpack.


This commit lost a lot of capitalization, that should be restored to the capitalization conventions in use.  E.g., eHub -> ehub, ANY -> any, masterSampleData -> mastersampledata


@cdent: GitHub doesn't render this correctly, but it should work according to http://sphinx-doc.org/markup/inline.html#ref-role - if I read http://stackoverflow.com/a/19543591 correctly, that's just a GitHub bug and should render fine with Sphinx?


what's the issue with LPC?


Capitalization comment throughout.


OK.  That will make things a little harder.

On Tue, Sep 22, 2015 at 10:14 AM, codenameone <notifications@github.com>
wrote:

> Probably. Yes we are using 5.x for all builds.
> Newer versions require newer Mac OS versions which will break XMLVM so we
> can't just upgrade without breaking compatibility for some older apps.
> We'll do it eventually but right now 5.x is the target.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/codenameone/CodenameOne/commit/7a1187ffc268d0ab77ad3e74e81bbff06ddd34fb#commitcomment-13372921>
> .
>

--
Steve Hannah
Web Lite Solutions Corp.


Hm, I remember getting an error when trying to drop something with a mangled name using the unmangled one. But maybe it was changed in a more recent PG version?


For now, we can add a comment:
"Update the PATH to point to where you have your Android Standalone Toolchain"


#4402-VRF-outputs-and-multiplied-floor (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-70.7%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


Не вижу изменения логгера


Just tested the latest betaflight on a tricopter, it was awesome!

Just wondering why was the yaw P term filtering added, only for quads I presume? I think it is not needed on a tricopter and I will remove it on my fork.


this is not enough -- what if S contains X' free?
this is why i suggested using the locally nameless library


Explain the prefix path in comments as well?


this is incorrect, personal measurements can't be entered by inherited leaders or admins. I'm centralizing church edit permissions in another branch and will correct the logic there.


Hi Xu,

My spec is like this,

"/file":{
"get":{
"description":"",
"produces":[
"application/octet-stream"]
,
"operationId":"downloadFile",

"parameters":[
 ....... query params .......
]
,
"responses":{
"200":{
"description":"Success",
"schema":{
"type":"string"}
}
}

I did not have to do any hack for file download, even though I had to make a change in the generated ApiClient to make file upload happen as multi part form data.


Not for flexbox, that's all I'm using this for.  A quick look on caniuse.com say no for the other properties as well.


You're right, the minetest.hash_node_position function is about 3x faster than my custom function, so I replaced my function with minetest.hash_node_position.


you can stick destination in a `const` here. (mostly for minification purposes later)


Thanks for checking out the code :-) I was just following the plugin upgrade instructions published here: https://confluence.atlassian.com/bitbucketserver/how-to-update-your-add-on-779302412.html

They just use `bitbucket`... it probably wouldn't hurt to use `bitbucket.server` but I think I will keep it as-is to be consistent with what Atlassian is doing.


I was thinking Bichon Frise, but sure, we could do Bear in honor of Robert Frost. The world has room enough to make a bear feel free. http://www.poemhunter.com/poem/the-bear/


Previous mapStateToProps. We just refactored away custom logic and used idiomatic Redux way so we are fully compliant and its just easier to follow Redux docs :)


<testing,bug


We can just use Path.Combine here.


Note there is already a prototype featExtractor generic function in R/biocMultiAssay-classes.R - that is the more Bioconductor S4 way of doing things.  Add, for example, equivalent sampleExtractor generic functions for matrix, ExpressionSet, SummarizedExperiment, grl.  These functions are very simple and limited in scope, and have no if/else statements.


It gets better: you can use `minetest.get_position_from_hash(hash)` to turn the hash back into a position again, when needed somewhere.


I tried adb push into system/app also . What else could be wrong? With the renderscript support library & Build Sdk version to less than 21 , it was working fine.


(this comment should have been under subsetting by sample, but same type of comment here)


Wouldn't it be better to just subclass `ExtractorError`?


GetFolderPath returns an empty string if the path doesn't exist, not null.


becausw I looked to logs of many quadcopters and it was always too noisy
and preventing us to increase P.

I have no tricopter experience with it.

If you say its better to not have it on tricopter I may add a condition
check for mixer type or something like that.
If tricopter than no yaw filtering for example.

Can you make some traces/logs from your tricopter with and without yaw
filter?
Op 22 sep. 2015 19:28 schreef "lkaino" <notifications@github.com>:

> Just tested the latest betaflight on a tricopter, it was awesome!
>
> Just wondering why was the yaw P term filtering added, only for quads I
> presume? I think it is not needed on a tricopter and I will remove it on my
> fork.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/cleanflight/commit/85855425a8c4195c265bbb3d8c0b64b912d34b62#commitcomment-13373229>
> .
>


#4402-VRF-outputs-and-multiplied-floor (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-42.54%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


The `switch` here should be converted to an `if` since there's only one case left.


This fixes #111


   ##              1. set the matrix
        ##              2. get the matrix
        ##              3. set the inverse
        ##              4. get the inverse


yes, agreed.


I would feel better if we left this assertion in.


from where did you get that translation..?


Path.Combine


File.WriteAllText?


'own computer' is confusing - this should probably be 'saved on your own JuliaBox' or 'JuliaBox account'? :)


No, this is a regression. To my knoweldge Flask-PyMongo 0.3.1 does not support pymongo 3.0 yet. Thanks for reporting.


Woah is that not the dopest thing ever

Like for real you keep finding these awesome things I didn't know were this easy


We don't need to ignore case here (and generally shouldn't when comparing paths)


Typo...Last one should be "- Disable Bitcode for iOS 9 running"


Why remove this?


Yes, _null_ are allowed here more by habit, because I use Objective-C a lot more than Java and I usually try to avoid exceptions... This check can be removed of course, and I can rename _string_ to _text_.


Does not really matter if it's not supposed to be caught.


Yes I'll do a comparison later, need to tune the yaw first. I will do it on a custom firmware though that has some improvements for yaw performance. We should still see if the filter makes any difference. Cut hz of 30 shouldn't add too much delay.


emphasize


added description for readme file


97668326-WholeBuildingLoad (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


![img_9131 - wirachmat](https://cloud.githubusercontent.com/assets/10752131/10026425/e49cd1ba-618b-11e5-8a74-dab30d146627.jpg)

~ $ git add --all
~ $ git commit -m "initial commit"
~ $ git -u origin master


Thats good solution. :laughing:


@pmoulon  Actually I was asking myself where these `Vc_*` definitions were coming from, now that I see that link above, I think these checks can be removed unless you are also planning to reuse his checks in the `CMakeLists`


That's not how `assert_attributes_equal` works. It takes, as a first argument, an object, and the remaining kwargs are the attributes you want to check and what value you expect. So you'd do something like:

```python
assert_equal(top_contributors.count(), 3)
assert_equal(top_contributors[0], second_contributor)
assert_attributes_equal(
    top_contributors[0]
    translations_count=16
    translations_approved_count=5,
    translations_unapproved_count=9,
    translations_needs_work_count=2,
)
```


I'm very sorry! Let me change that


Doesn't the move imply that the binary is rebuild every time you make?


Thanks for the tips. I'm generally quite bad at finding existing libraries. I'll take a look at them for the next upload which is normally when this gets a facelift (or gets bloated, depending on how much time there is).

And you could never intrude since you are always welcome, *hint* Stockholm *hint* :airplane:

Blad (and yes why in English?)


MPL


@klightspeed Hopefully i understood you correctly, and this looks OK to you :)


replace "releasing them" with "releasing it" or "providing it"? (or leave as it is)


Commencing New Job Training Challenge


m


Between step 2 and 3 you will need to grab the xml file (located
somewhere?) and pass that as a list into the scheduler class.
On Sep 21, 2015 22:08, "Andy Y" <notifications@github.com> wrote:

> Hey Guys:
>
> Can you let me know if I understand the workflow correctly. To retrieve
> the active list of tasks in memory, I have to do the following.
>
> 1.) Create a reference to the Core class in the pageMain page.
> 2.) Create a Scheduler object - Access GetScheduler by going through
> Core.GetScheduler()
> 3.) Assign a list object that is filled by the Scheduler.GetActiveTasks
> Method
> 4.) This list is used to populate the ListViewer control on pageMain.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lobstermobster/AndroidSchedulerApp/commit/5a0b22e08dc314cfe5694e1cd4adc1d5237c2b88#commitcomment-13358315>
> .
>


Actually that happens on step 2 when you create scheduler class.
On Sep 22, 2015 11:46, "York Kwan" <yorkwan12@gmail.com> wrote:

> Between step 2 and 3 you will need to grab the xml file (located
> somewhere?) and pass that as a list into the scheduler class.
> On Sep 21, 2015 22:08, "Andy Y" <notifications@github.com> wrote:
>
>> Hey Guys:
>>
>> Can you let me know if I understand the workflow correctly. To retrieve
>> the active list of tasks in memory, I have to do the following.
>>
>> 1.) Create a reference to the Core class in the pageMain page.
>> 2.) Create a Scheduler object - Access GetScheduler by going through
>> Core.GetScheduler()
>> 3.) Assign a list object that is filled by the Scheduler.GetActiveTasks
>> Method
>> 4.) This list is used to populate the ListViewer control on pageMain.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/lobstermobster/AndroidSchedulerApp/commit/5a0b22e08dc314cfe5694e1cd4adc1d5237c2b88#commitcomment-13358315>
>> .
>>
>


I managed to get it working, it was due to a flag you aren't using but I was;) I will delete the other commits and this one too to keep your github clean. Thanks anyway for your quickly anwers


I prefer to see the enum listed in numerical order in the source code.  That helps us quickly determine that we have set some enum for the "0" value. Intellisense in Visual Studio might present them in alphabetical order, but in general, the guidelines for most code is that enums are listed numerically.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21058/testReport/) for this commit**


Yes, it was an nested function in __repr__() for the Param class. I've moved it to a top level function in python/param.py and imported. Not sure about the algorithm; I was using it as-is.


Yes, tabs instead of spaces on Line 232 - 237.


quiz 1


@edolstra This breaks the Darwin build of `nix`, since `--build-id` is an unrecognized option there.


could we instead do this as a dictionary of

'pxe': 'Intel(r) AMT: Force PXE Boot',
'hd': 'Intel(r) AMT: Force Hard-drive Boot',
'cd': 'Intel(r) AMT: Force CD/DVD Boot',

And then pass pxe/hd/cd as the boot param? The long strings passed as params have the likelihood of getting a type in there and things going weird.


101163020-SetpointOutdoorAirTempOneDirection-4627 (rglazer2) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-70.9%25-red.svg)


Because of `’`, this line causes a failure on my puppet runs with `Error: Could not retrieve catalog from remote server: Error 400 on SERVER: invalid byte sequence in US-ASCII at /etc/puppet/modules/docker/manifests/init.pp:1`.


`readelf` is not an available binary either.


Only the leader CAN DO THIS


Can you make the above change before merge?


These changes look good to me.


Should be fine, you can check it yourself with:

```
$ make docs
$ open docs/build/html/format.html
```


This code was also only in python/Param.py; I'm not sure why I just copied it. Good catch. Moved to constants.py.


Why not change the body of these methods instead of removing them alltogether? That is the reason we put them there in the first place: to be able to change the way in which they manage their functionality.

>review
<review


This needs tidying up.  See the git commands in your "GCSE Computer Science" folder on Google Drive, and let me know (ideally right here) if you're stuck.


Nice one :)


On the top level, these are all symbolic links into `_build/` (this is how ocamlbuild works - the real binary is `_build/host/main.{byte,native}`); so only a new symlink is created on the second run and never again after that. We could use `cp` instead of `mv`.


:+1: this is messing my import scripts too


Reviewed with Natalia. Looks good.


I had to revert the whole commit to enable `nix` to build again.  More is broken on Darwin than just the above two points.


Ouch.


I think it's considered better form to use the `NSURL` APIs to build the path rather than doing it manually; you might want to convert the path to a URL as soon as possible. That is:
```
let docsDir = NSURL(fileURLWithPath: dirPaths[0])
let dirPath = docsDir.URLByAppendingPathComponent("pdfs")
```


TeamCity Colore :: Main Build [Build 102](http://tc.sharpblade.net/viewLog.html?buildId=637&buildTypeId=colore_mainbuild) is now running


ack


TeamCity Colore :: Main Build [Build 102](http://tc.sharpblade.net/viewLog.html?buildId=637&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:0:59


TeamCity Colore :: Main Build [Build 103](http://tc.sharpblade.net/viewLog.html?buildId=638&buildTypeId=colore_mainbuild) is now running


I think it should be `copy`, thanks for catching :smile:


Is it wise to have it bound to a generic name like `DEBUG`? I feel like there might be some unpredictable behavior that might come up.


Here's a patch I made that I think addresses some readability issues.  You can feel free to judge/discard the font-family on it's own merit:

From 529f244d5b27d53781247144e8d8a2372fd494ba Mon Sep 17 00:00:00 2001
From: William Dizon <wdchromium@gmail.com>
Date: Tue, 22 Sep 2015 10:52:04 -0700
Subject: [PATCH] additional css updates

---
 html/css/custom.css | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/html/css/custom.css b/html/css/custom.css
index 8d3ff0f..f5bc4c9 100644
--- a/html/css/custom.css
+++ b/html/css/custom.css
@@ -30,14 +30,15 @@ table tbody tr a {
 }

 .console-inner {
-    height: 450px;
+    height: 60vh;
     overflow-y: scroll;
+    font-family:monospace;
 }

 .console-inner .table td {
     border-top: none;
-    padding: 0px;
-    line-height: 15px;
+    padding: 0;
+    line-height: 1.25;
 }

 .console-input {
@@ -48,13 +49,13 @@ table tbody tr a {

 .console-input label {
     position: absolute;
-    padding: 4px 6px;
+    padding: .45em .6em;
 }

 .console-input > input[class*="span"] {
     border: none;
     background: transparent;
     box-shadow: none;
-    margin-bottom: 0px;
-    margin-left:15px;
-}
\ No newline at end of file
+    margin-bottom: 0;
+    margin-left: 1em;
+}
--
1.9.5.github.0


Thanks. Sorted.


Ouch (2)


TeamCity Colore :: Main Build [Build 103](http://tc.sharpblade.net/viewLog.html?buildId=638&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:0:58


101682488_EvapCoolPrimaryAirSizing (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1854 of 1887 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.25%25-yellow.svg)


Ok, so this does **not** work:

```
(function (smoothScroll) {
  'use strict';

  // Support RequireJS and CommonJS/NodeJS module formats.
  // Attach smoothScroll to the `window` when executed as a <script>.

  // RequireJS
  if (typeof define === 'function' && define.amd) {
    define(smoothScroll);

  // CommonJS
  } else if (typeof exports === 'object' && typeof module === 'object') {
    module.exports = smoothScroll();

  // <script>
  } else if (typeof window === 'object') {
    window.smoothScroll = smoothScroll();

  // Do not initialize smoothScroll when running server side, handle it in client:
  } else {
    return;
  }

})(function(){
'use strict';

// We do not want this script to be applied in browsers that do not support those
// That means no smoothscroll on IE9 and below.
if(document.querySelectorAll === void 0 || window.pageYOffset === void 0 || history.pushState === void 0) { return; }

// ....
```

.. with the server complaining about `ReferenceError: document is not defined`, so I'm thinking something like this (which does compile correctly):

```
(function (smoothScroll) {
  'use strict';

  // Support RequireJS and CommonJS/NodeJS module formats.
  // Attach smoothScroll to the `window` when executed as a <script>.

  // RequireJS
  if (typeof define === 'function' && define.amd) {
    define(smoothScroll);

  // CommonJS
  } else if (typeof exports === 'object' && typeof module === 'object') {
    module.exports = smoothScroll();

  // <script>
  } else if (typeof window === 'object') {
    window.smoothScroll = smoothScroll();
  }

})(function(){
'use strict';

// Do not initialize smoothScroll when running server side, handle it in client:
if (typeof window !== 'object') return;

// We do not want this script to be applied in browsers that do not support those
// That means no smoothscroll on IE9 and below.
if(document.querySelectorAll === void 0 || window.pageYOffset === void 0 || history.pushState === void 0) { return; }
```

Does that work for you or would you prefer something else?


Done.


Run grunt package first please.


lol


Subscription manager has plugins that yum uses that are external to the /etc/yum.repos.d directory as I understand it.


shipit


Same here re: URL paths. And since you already have the `pdfs` path above, I think you could reuse it:
```
let filePath = dirPath.URLByAppendingPathComponent(lastPathComponent)
```


Hm, that's why i didn't spot it -.-'''


97668326-WholeBuildingLoad (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1844 of 1882 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.98%25-yellow.svg)


out of curiosity, why was this change needed? Shouldn't they mean the same thing?


TeamCity Colore :: Main Build [Build 104](http://tc.sharpblade.net/viewLog.html?buildId=639&buildTypeId=colore_mainbuild) is now running


TeamCity Dirigo Edge :: Deploy Pull Request [Build 80](http://tfs2013:8081/viewLog.html?buildId=806&buildTypeId=DirigoEdge_DeployPullRequest) outcome was **SUCCESS**
Summary: Running Build time: 00:00:03


Fixed, for regular paragraphs, _underscores_ will mark as italics.   This just renders in monospace, so this was was easy to fix.


TeamCity Colore :: Main Build [Build 104](http://tc.sharpblade.net/viewLog.html?buildId=639&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:0:58


TeamCity Colore :: Main Build [Build 105](http://tc.sharpblade.net/viewLog.html?buildId=640&buildTypeId=colore_mainbuild) is now running


TeamCity pull requests :: netty [Build 240](https://garage.netty.io/teamcity/viewLog.html?buildId=1557&buildTypeId=pulls_netty&guest=1) is now running


Why did you make this change to subset gcc_data in the melted version? I agree that we currently don't need the data, but was there actually problem without this when the N.percent and O.percent variables were passed along?


Mh is it supposed to be fixed? I still get errors locally:

```
./test/cfg/runtests.sh
Checking test/cfg/posix.c...
Checking test/cfg/gnu.c...
Checking test/cfg/std.c...
Checking test/cfg/std.c: __STD_UTF_16__...
Checking test/cfg/std.c: __STD_UTF_32__...
Checking test/cfg/std.cpp...
"test/cfg/std.cpp:2877:information:checkLibraryNoReturn:--check-library: Function find() should have <noreturn> configuration"
Makefile:246: recipe for target 'checkcfg' failed
make: *** [checkcfg] Error 1
```


I'm not sure what you mean


@Rubenoo should be working in c49d88d
give it a try.


TeamCity Colore :: Main Build [Build 105](http://tc.sharpblade.net/viewLog.html?buildId=640&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:0:59


I got the syntax wrong.  If you use a lambda with no function params, you have to give it a name instead of empty parentheses.  I figured it would just be cleaner to revert it back to the normal function syntax.


I would recommend keeping addScore, and removing setScore unless setScore is absolutely necessary.

1) This makes the score attribute less accessible, there is really never no need to completely change the player score, only to add or remove from it by a certain amount. Forcing the caller to use setScore instead of addScore makes them responsible for more things that Player should be able to handle himself (namely, the addition). This is visible in the code because you will always have to do a call to a method of the player (getScore) before you can get the right arguments to provide to setScore.

2) This makes the code perform better. Method calls via object references are expensive and in this case, it would be faster to get the current value from within the Player with this.points rather than from somewhere else with player.getScore()


I'm pretty sure this depends on whether the shell has already printed the prompt before detaching/being put to sleep.


We seem to be doing exactly the same on lines 346-356 and lines 360-367


"ValueError: unknown locale: UTF-8" sigh - let's deal with that another time though. If this works for you and the documentation is otherwise acceptable, feel free to merge. (I intend to improve upon it later; #91.)


Oh, nvm. One is reverting and one is updating. I missed that


I know I fixed this for 2015, can't rmeember if I backported the fix to 2014 or not.  Have to check


Sysos for developing is easier of course, but while you are at it, add it to the logs :)


I think I would probably leave this one as synchronized for now, and leave those comments in.  The comments on the class definition have probably been overtaken by events, though.


data.FlushBits(); missing?


You have subclasses, make this method abstract and let the subclasses define what they need in order to activate themselves on the player.


This one will take more research on how to fix, if possible. It's a code block that shouldn't be interpreted for markup.  I might have to look into converting into a regular block of monospaced text and escaping what ever should be interpreted.  Github's asciidoctor won't be the final renderer, I'm not sure what exactly is being used on the site. I've only seen a few previews of staging.


Looks so pretty to me! Thanks, @SammyK


I didn't mean an actual revert, I mean that auto-generated commit that just does the opposite of the commit you're reverting.


Hi, I don't think it does break backwards compatibility. Can you double check my thinking?
If someone has already set up a call in their code to cbHAR where they have not set an options.port value, or want to call it in the future without an options.port value, then 'this.start' will be called with 'undefined' and the callback.
The current functionality of start(port, cb) can cope with this by setting cb to the callback, and ignoring the first parameter as it's typeof(port) will be 'undefined' rather than 'number'.
So I don't think existing calls to cbHAR will break?


Previously I added `--skip-lock-tables`, but in reading it seems that is nothing more than a band-aid around other, real problems. I think the [`--single-transaction`](https://dev.mysql.com/doc/refman/5.1/en/mysqldump.html#option_mysqldump_single-transaction) flag could be a worthwhile addition down this path as well. My guess is that performs better with InnoDB that the implicit `--lock-tables` added by `--opt` here, but no easy way to infer that and don't want to clutter up the source of this project with that kind of logic anyway.


I the line above still true? ^ L9


believe you have apache and nginx mixed up here......

![image](https://cloud.githubusercontent.com/assets/13522424/10027121/fc7efb0c-612a-11e5-86dd-a0f12441ea37.png)


Does this fix the issue "The SMTP host was not specified." that is occurring with the latest NuGet released version?


That is a key for the templating system, which won't show in the final output.


大括号写上面一行去


Are we trying to get rid of this method?


We should note that these have defaults and are potentially optional.

Also, may be worthwhile to introduce the addon_short_name concept early on


The sanitizer is clean and straightforward. I think it would be good to have an option in the sanitizer function to include or exclude stopwords because there may be cases where stopwords are important


more log potential

>review
<review


So, my OCD keeps kicking in when I see these comments that you're fixing up WITHOUT adding ending periods and yet you have many other comments where you explicitly are adding periods at the end.

Just wondering if you were aware of this difference.


@JorgeFerrer , @jkappler I think this tutorial should list the conditions required for a configuration to be registered in the Configuration Admin portlet in the Control Panel. Do you know what these conditions are?

For example, I created a simple project to test this tutorial (https://github.com/jrao/liferay-docs/tree/LRDOCS-1873/develop/tutorials/code/com.liferay.docs.exampleconfig). After deploying the portlet, I was expecting to be able to use the Configuration Admin portlet to configure the portlet. But the configuration did not appear in Configuration Admin.

I had to add a ConfigurationAction as in the blade.configurationacton project (https://github.com/rotty3000/blade/tree/master/gradle/blade.configurationaction) in order to be able to configure the portlet.


On my 300-module use case, that last commit has no effect, but seems marginally cleaner.


Examples include 'Documentation', 'Storage', 'Citations', and 'Other'


Hi,

Would you mind making a Pull request of your modification ?

Thank you. Regards


It seems inconsistent to have both 0x1 (hex) and 1 (decimal) in the same enum definition.  Can't we just use decimal and be consistent?


Do we want to encourage people to use these methods? Shouldn't WB handle this?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21064/testReport/) for this commit**


TeamCity Colore :: Main Build [Build 106](http://tc.sharpblade.net/viewLog.html?buildId=641&buildTypeId=colore_mainbuild) is now running


`RealDonalTrump` is a fake account ;) -- gotta have two ds in Donald


That'll be the same problem you were getting before: some kind of conflict between miscellaneous locale settings in either or both of environment and the terminal application (whether Terminal or iTerm).

I'll merge later tonight.


This is awesome!


TeamCity Colore :: Main Build [Build 106](http://tc.sharpblade.net/viewLog.html?buildId=641&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:0:57


TeamCity Colore :: Main Build [Build 107](http://tc.sharpblade.net/viewLog.html?buildId=642&buildTypeId=colore_mainbuild) is now running


Shouldn't be `.toList().addAll`? Notice the two dots.


Yep. It's the same. But I've decided to drop the lodash`s dependence. It's not the same as cloneDeep 'cause nested objects are still copied by reference, but I think it's okay for a while.


OK


* this only works on views the the node_id arg


Nice.


TeamCity Colore :: Main Build [Build 107](http://tc.sharpblade.net/viewLog.html?buildId=642&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:1:0


What do you think about putting the index name in the environment variables?


ha you're right!  don't know what I was thinking :) thanks!


@tomwayson I wasn't aware of `$parsers` before; check out this blurb in a recent ng 1.4x [migration doc](https://code.angularjs.org/1.4.6/docs/guide/migration#select), and specifically the code in the 2nd gray well just above the "Templating" subsection.  Just some food for thought.


^ can we tell people not to use Rubeus?


Why doesn't this section of code break our builds?
https://github.com/codenameone/CodenameOne/blob/master/Ports/iOSPort/nativeSources/IOSNative.m#L4799-L4821

It uses the property
https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIViewController_Class/index.html#//apple_ref/occ/instp/UIViewController/popoverPresentationController

which is iOS 8 or later.

Do we have iOS 8 SDK installed on the server?

I've installed iOS SDK 7.1 locally (still in Xcode 6) and am trying to
build stuff against it and am running into quite a few errors.

On Tue, Sep 22, 2015 at 10:27 AM, Steve Hannah <steve@weblite.ca> wrote:

> OK.  That will make things a little harder.
>
> On Tue, Sep 22, 2015 at 10:14 AM, codenameone <notifications@github.com>
> wrote:
>
>> Probably. Yes we are using 5.x for all builds.
>> Newer versions require newer Mac OS versions which will break XMLVM so we
>> can't just upgrade without breaking compatibility for some older apps.
>> We'll do it eventually but right now 5.x is the target.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/codenameone/CodenameOne/commit/7a1187ffc268d0ab77ad3e74e81bbff06ddd34fb#commitcomment-13372921>
>> .
>>
>
>
>
> --
> Steve Hannah
> Web Lite Solutions Corp.
>

--
Steve Hannah
Web Lite Solutions Corp.


Looks like your search/replace added a space to statements that already had it.  If you follow this up with a replace of `[sp][sp]{` -> `[sp]{`, I think it'll get you back to uniform spaces.


Sorry, see that this was addressed in a later commit.


test comment


Yeap, I think it's okey too.

I'm just curious is there any real difference with `Object.create()`. Last one seems to create new object and inherit only prototype, which seems ok to me.

Anyway, your solution and `Object.create()` has same performance, so it's really just about number of lines


You didn't meet the party requirements


Small if else block that could easily be made into a private method, keeps the update method clean and short

>review
<review


Thanks Nada, good catch. I was wondering what's the use of the LN library. I'll study the library and use it in the formalization of system F(and probably rewrite STLC as well).


The comments that don't receive periods have been fixed mechanically. I'll try to do a better job of catching this.


Sure--I'll make the change.


Ive tested it from installing to trying to launch exploits. it did everything good until trying to launch exploit. it said launch failed . by options it went blank. then i selected payload and it crashed
samsung galaxy s5 android 5.
logcat  https://gist.github.com/Rubenoo/9aab40e6cee31d8ab7cd


Of course, in Python3 range() is a generator so you have to do

    $ python3 -c 'print(list(range(3)))'
    [0, 1, 2]

My point is that the numbers in the output were wrong.


Hi @jrao, there shouldn't be any extra conditions for the configuration to be registered in Configuration Admin. I'll test tomorrow and let you know


This is the new, Ember 2.0 compatible version of the library. The current dochub build is using commit number https://github.com/macroplant/EmberDroplet.git#dea57d7fb2b6facec097d19db7ca9f7734b7af6f


TeamCity Colore :: Main Build [Build 108](http://tc.sharpblade.net/viewLog.html?buildId=643&buildTypeId=colore_mainbuild) is now running


What does the :tshirt: t-shirt icon mean?


要習慣不用 Console project, 改用測試專案 :laughing:


Bonsoir Benoit,

The feature is working already, although I didn't check yet what all the possible responses can be.

This Slack API call "users.admin.invite" is not documented by Slack as it is still under development and can change any time as stated in this issue on github: https://github.com/slackhq/slack-api-docs/issues/30

So, it's up to you if you want to include it already or not. :)  I can send you a pull request.


OK


With all the subclasses, you might consider simply making a complete new entry in the collision mapping for exactly that class with Player.
final CollisionHandler<Powerup, Player> playerPowerupHandler = game, powerup, player) -> {
This also saves you the need of manually casting the classes.


I would like to see some discussion of ExternalAccount and some of the abstraction introduced w/ AddonOAuthNodeSettingsBase. Mendely, Zotero, and Dataverse are the current examples of this. We can talk more about this if need be.


TeamCity Colore :: Main Build [Build 108](http://tc.sharpblade.net/viewLog.html?buildId=643&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:0:58


97668326-WholeBuildingLoad (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (808 of 808 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.54%25-green.svg)


Test data... OK


curse the java side of me when I initially wrote this.   Can you add rdoc string above the method that is being deprecated.

```# DEPRECATED: Please use this other method instead instead.```


This line looks like is was uncommented inadvertently.


Thanks--that's definitely more clear.


6跟7怎麼來的？並沒有在需求中看見這兩本。


Well I'd guess only developers have `DEBUG` usually set and they might expect some additional output. So it does what one would think it does. Anyway I can change it to whatever else, eg. `AVOCADO_DEBUG`.


Thanks @jkappler


The commit message is supposed to say that this is NOT conclusive.


I'd say it's just
final float yArrow = y1;


I'm assuming these changes are expected. I kind of expected a new block to be added here (new dumps).


Do we maybe want to make this `#define NOOP` more global?


hi there,
I noticed that you have this commit to add semicolons to the end of each template?  Is that included in the latest npm package (v0.1.8)?  I am using this awesome tool on a repo that includes jshint as part of the compile process, and it's being a jerk about requiring semi-colons.
Thanks!


tisk tisk tisk. the question is supposed to be favorite vacation spot :smiling_imp:


測試程式中不該出現邏輯，這樣是強制寫 code 跟邏輯來達到目的。
這一段測試程式會很容易不 stable, 因為需求一動，這邊要改的機會就高，而且會使得閱讀跟維護這段測試的成本增加。


Makes sense to focus only on the dump itself.


Thanks, fixed.


Do you know what would happen if this trigger call also raises exceptions? Will this eventually cause stack overflow?


OK


Please update to 23.0.1


Use of RNG without initializing it.


This is indeed the correct path: https://github.com/Polymer/font-roboto/blob/master/roboto.html. Thanks!


Can you explain that it's useless because we do a bulk index after import of all resources? Otherwise it's not clear why we're avoiding this indexing


More dumps, OK


I actually tried and it seems I don't need OAuth account. I just provide API_KEY in the header and I can get the correct response. Did I miss anything? Is there a flag I need to turn on to enable it?

Yes, this is the authentication piece missing right now and I mentioned in the description. However, I'm not familiar with this area. So someone with better knowledge of edx authentication has to implement it or help me with the implementation.


Misspelled the commit message. Too lazy to amend.  ¯\_(ツ)_/¯


Actually we may want to add something similar for GitHub Provider too, there we would like to use `use-login-as-username`, so something similar for Google provider would be: `use-email-as-username` (well, actually we use only part before domain, but that's implementation detail).


因為一次把測試案例寫完，再一次想辦法把 produce code 改完通過所有測試案例。這樣其實就少了TDD透過 test case 來達到 incremental delivery，以及透過 baby step 跟單一測試案例來限縮 product code design 複雜度的好處。

這樣跟一次完成一個完整的需求，再一次把相關測試案例補齊一樣，是達不到 TDD 的效果的。


package com.amazon;

import java.util.InputMismatchException;
import java.util.Scanner;
import java.util.TreeSet;

/**
 * To sort N(1<=N<=5000) strings in ascending order by removing the duplicate strings.
 * Each string should be of length 1<=length<=100
 * @author Karthikeyan S
 *
 */
public class SortingProblem {

	/**
	 * To get integer from the user - count of strings to be feed by the user
	 * @param scanner
	 * @return countOfString
	 */
	private int getStringCount(Scanner scanner)
	{
		System.out.println("Please enter the number of strings need to captured(1 to 5000) : ");
		int n = 0;
		//To get an integer from user
		try{
			n = scanner.nextInt();
		}catch (InputMismatchException  e) {
			System.out.println("You had entered an invalid integer.");
		}
		scanner.nextLine();
		/**
		 * Check whether the integer is satisfies the condition(1<=N<=5000).
		 * In case of invalid number, get the valid integer from user.
		 */
		if(!(n>=1 && n<=5000))
		{
			System.out.println("Please enter a integer number from 1 to 5000.");
			n = getStringCount(scanner);
		}
		return n;
	}

	/**
	 * To get n number of string
	 * @param scanner
	 * @param n
	 * @return sortedSet
	 */
	private TreeSet<String> getListOfString(Scanner scanner, int n)
	{
		//Treeset holds the elements in sorted order without duplicate entry
		TreeSet<String> treeSet = new TreeSet<String>();
		System.out.println("Please enter " + n + " Strings : ");
		String str = null;
		//To get n string
		while(n>0)
		{
			str = scanner.nextLine();
			//To check whether a string satisfies the length condition(1<=length<=100).
			if(str.length()>=1 && str.length()<=100)
			{
				n--;
				treeSet.add(str);
			}
			else
			{
				System.out.println("Please enter a valid string which has a length 1 to 100.");
			}
		}
		return treeSet;
	}

	public static void main(String[] args) {
		SortingProblem sortingProblem = new SortingProblem();
		//Scanner to get the integer and list of string
		Scanner scanner = new Scanner(System.in);
		//To get the count of string
		int n = sortingProblem.getStringCount(scanner);
		//To get n strings and sort them in ascending order by removing duplicate
		TreeSet<String> sortedStrings = sortingProblem.getListOfString(scanner, n);
		//Close the scanner
		scanner.close();
		System.out.println("Sorted string after removing duplicate elements :");
		//Print the entries
		for(String entry : sortedStrings)
		{
			System.out.println(entry);
		}

	}

}


semicolon


Since you added the XSD and XSL grammars under the Atom Beautify XML language (see below) you actually should not add them here. The language name you would receive here will be `XML` for XML, XSD, and XSL now.

Does it work without this? If so, please remove :smiley:. Thanks!


Die Zeile können wir entfernen


@axon-qubes great stuff- thanks for doing this :+1:  :smile:


I thought the former custom prop entry may have been from https://github.com/PolymerElements/paper-styles/blob/master/typography.html, but it looks like it wasn't. Change here LGTM (but Frankie would know better).


@sarina This is the base class implementation, and a subclass overrides this method where different functionality is needed.

@xcompass The docstring for this should explain that.


CPUID[0] EBX, ECX, EDX changes are expected: it's the CPU vendor name, changing from GenuineIntel to AuthenticAMD. The previous dump was collected in an Intel host, and now we have a dump from an AMD host.

The CPUID[80000008h].EAX change below is the physical address space limit, and RHEL6 QEMU uses the host limit, so different hosts report different bits. It is expected too.


CPUID[80000008h].EAX is the physical address space limit, and RHEL6 QEMU uses the host limit, so different hosts report different bits. It is expected too.


haha


Wondering if there is a way for Priiloader to use the custom meta.xml file to say use IOS248 instead of 249 per GAF's tutorial found here http://gwht.wikidot.com/d2x.  I configured the Will to boot directly to CFG USB Loader using Priiloader, but I get the 'IOS249 is a stub' error that way.  If I launch CFG from the HBC, it reads the meta file and uses the correct cIOS.  Any help is appreciated.  Thanks!


It's a judgment call. This is probably fine, I guess.


custom*


I have a special case where I need more like a global pointer to a last registered process for a key ( {error,taken} was the issue for me). I needed a fast write/update for a key that is assigned to a process.

I just overwrite the key with the last one.  It turns out to be an exact fit for what I wanted.

I can create a pull request if it sounds useful?


TeamCity Colore :: Main Build [Build 109](http://tc.sharpblade.net/viewLog.html?buildId=644&buildTypeId=colore_mainbuild) is now running


Fantastic work! Glad to hear Github is working again for you.


It doesn't work with nunjucks v2.0.0. I don't know the accurate reason, but tests fail with `Object.create` and the new nunjucks. Seems it doesn't find props in object's prototype anymore (somethings has changed under the hood).


Awesome :+1:


I think this is supposed to be

```
aurelia.use.globalResources(...resourcePaths)
```
see following issue [here](https://github.com/CharlesPockert/aurelia-bs-grid/issues/48) and also the [docs in templating section](http://aurelia.io/docs.html#templating)


This is the default implementation in the base class. SAMLProviderConfig is its subclass and is overriding it with a different implementation. E.g. prepending the IdP_Slug.


OK


With this change the cube can rotate on 2015 browsers with "toggle spinning" button


On slide 4 please mention that this is a simplified version of the original Android demo code. Perhaps add a link. Is there also a way to make that statement "Picture is *usually* stored at..." a little more deterministic?

Otherwise looks good.


TeamCity Colore :: Main Build [Build 109](http://tc.sharpblade.net/viewLog.html?buildId=644&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:1:18


`is` prefix should be used only for `boolean` type.


Are we still using this `#ifdef`?


Changes in overview.xml are missing. Make sure you can load the new tutorial from a local HTTP server (as described in the README).


@xcompass As far as I know, all that this does is set `request.user` based on OAuth credentials that are supplied. If no OAuth credentials are supplied, it still lets you access the API view/method, but `request.user` will be either `None` or an `AnonymousUser`. So in other words, this takes case of authentication, but you still need custom code for authorization.

And as I say below, we won't be allowed to give out an `API_KEY` to UBC, so you will need to be able to use OAuth for this. I included sample code in the comment below, though I haven't tested it or worked with OAuth for APIs very much myself.


So awesome.


`(or (null urltype)...` would be better

instead of expanding the file name here you could just do it in the directory part of the pcase statement since it's not needed anywhere else

also...

```cl
(if (and (or (null urltype)
             (string= "file" urltype))
         (file-directory-p urlfile))
```


Could we do this change without reversing the order of the `if` branches?  It makes the diff hard to review and doesn't really add any value to the code.


Ah, OK, that makes sense. Thanks!


passing a filename as a string here causes test failures under jruby versions.  Potential fix is PR #1355


![screen shot 2015-09-22 at 2 35 45 pm](https://cloud.githubusercontent.com/assets/350048/10027862/483c8080-6137-11e5-83bc-0a7495f5b469.png)
![screen shot 2015-09-22 at 2 36 44 pm](https://cloud.githubusercontent.com/assets/350048/10027876/60d36014-6137-11e5-873d-3779f8ae558f.png)


If there is no content, the link should be removed


oh yes!


TeamCity pull requests :: netty [Build 240](https://garage.netty.io/teamcity/viewLog.html?buildId=1557&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 5603, ignored: 21; compilation error: Compiler (new) Build time: 00:35:41


This bullet is redundant with the preceding paragraph.


This should come in handy: https://github.com/circleci/circle/blob/master/src/circle/util/mongo/plan.clj


"flexible enough to handle"?


immutable?


joa kein problem, passiert ;-)


do the following instead `this._view.changeDetector.ref`


Hm, interesting... I my case tests passing...

![2015-09-22_21-37-31](https://cloud.githubusercontent.com/assets/4460311/10027923/38b924ca-6172-11e5-951d-0e01e33f4948.png)

Maybe it have something to do with Node version? I'm using `4.1.0`


Ooof. Feeling like a doofus here. Apologies. Please try 2.0.3.


An alternative to @t1mmen's above, I remember I kept his defensive check in the wrapper like this:

```javascript
(function (smoothScroll) {
  'use strict';

  // Do not initialize smoothScroll when running server side, handle it in client:
  if (typeof window !== 'object') return;

  // Support RequireJS and CommonJS/NodeJS module formats.
  // Attach smoothScroll to the `window` when executed as a <script>.

  // RequireJS
  if (typeof define === 'function' && define.amd) {
    define(smoothScroll);

  // CommonJS
  } else if (typeof exports === 'object' && typeof module === 'object') {
    module.exports = smoothScroll();

  // <script>
  } else if (typeof window === 'object') {
    window.smoothScroll = smoothScroll();
  }

})(function(){
'use strict';

// We do not want this script to be applied in browsers that do not support those
// That means no smoothscroll on IE9 and below.
if(document.querySelectorAll === void 0 || window.pageYOffset === void 0 || history.pushState === void 0) { return; }

...

```


New line after the ```


Bumped with additional comments.


New line before the ```


Unlikely. I'll remove this.


Approved!


<bug


yes, that works for me, thanks.


You have to use DirectiveResolver here. If you do it like this, the syntax sugar (e.g., property decorators) will not work.


These last three are not really about Scala idioms, nor are they new features.  Perhaps change the paragraph preceding this list to something like:

     This new Scala driver required much more than a simple wrapping of the Java driver.  Here are some of the highlights:

And I'm not even sure that the first sentence is necessary.


As discussed, this can be removed.


I also like the structures of the chapters. It makes the book easy to read and also easier to learn the material.


no comment at this time


@yaniaular I've a doubt about what does '__prodlot__' stands for, it is __Productions Lot__ or __Product Lot__?


The main server will never run a local ladder; this is for side servers.

I don't know how many users side servers get, but in theory not enough for O(n) search to be a problem. It's not like it's O(n^2). Especially since I'd hope the biggest side servers would develop better local ladder implementations.


great test case for describing scenarios! You got my point!


OK


Azure SQL Database WingTipTickets demo and hands on lab These files comprise a hands-on-lab that demostrates an Azure SQL Database and Azure Search based sample application used to selling concert tickets There are two Word documents, one that describes that HOL setup, and another that describes all of the scenarios that can be used. Go through the Demo Script Final Draft.docx to finish the 6 scenarios.


launch AI logic


Do we have to attach it to the real DOM or can we use something similar to DOM.createHtmlDocument()?


Sure.


Not that it is worth re-doing, but for future reference... keeping all of the code for a particular robot in one repository (which is well tagged) means that if you take THAT repo to competition, you have EVERY version that ran on that robot.  Assuming it is up-to-date (an easy check), you're sure you've got it all & can get back to any point offline.

If you split into multiple repos, you have to manually make sure you get them all, they're all up to date, etc.  A single repo is just easier.  Use branches to do your refactoring.


status


Leaking the entries' strdup()s?


LOL it failed cuz of your lint error xaa


What's that? Why do we expose a token here? Also doesn't look like it belongs to the commit...


Mon premier commit !


looks good


This should be localizable as should all errors in this class. Please extract all messages in this class into the message bundle available here:
https://github.com/pentaho/pentaho-kettle/blob/master/plugins/pdi-pur-plugin/src/org/pentaho/di/repository/pur/messages/messages_en_US.properties


There were certain parts of week 3 that were definitely encouraging moving forward. One was the idea to take reading the HW assignment meticulously as serious as possible.
The info we've learned in week 3 regarding CSS was, for me, a great comfort, b/c we are dealing with very layout/ shape/ user interface elements, etc..
Possibly the most confusing part of the week was trying to understand how to manipulate the spatial
relationship between any of the given objects/elements of the page


Ditto.


但是 TDD 的過程，建議是完成一個測試案例時，就要去調整 production code，這樣才會有增量式產出的效果。

最大的好處是，你一次只需要用到一點點腦容量，只需要用最簡單的方式，通過眼前這一個失敗的測試案例即可。而不是一次把所有需求都思考進去。

一旦有了通過測試的 production code, 因為你用最簡單的方式、最少的程式碼去調整 production code，所以重構起來的成本相當低，因為你有測試保護，所以重構起來風險趨近於0，即使你是大範圍重構。

因為你眼裡只有眼前這一個需求，所以你會避免 over design。因為你先寫測試，為了要在測試專案通過編譯，所以你在寫完測試程式時，就會把 production code 的骨架長完，除了增加生產力以外，還會讓你的 prod code API 設計地更好用、易讀、抽象，因為是站在使用的角度來看、站在抽象而非實作的角度來看、站在需求的角度來淬煉 domain model 的意義與命名。


101163020-SetpointOutdoorAirTempOneDirection-4627 (rglazer2) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-70.9%25-red.svg)


I was about to say if you were using some Werror flag but looks like you got it sorted! :)

I don't mind if the comments are there, it can always be possible to delete them.


一次完成通過所有測試案例的 production code 是複雜、容易 over design、容易出錯的。

目前這樣寫法的唯一好處，只有確保程式寫的跟想的一樣，在寫的過程不至於寫出不符合需求的 production code，但其實跟 TAD ，也就是先寫 production code，寫完馬上補測試程式，效果差不多。

TDD 好處我補到 issue 裡面了。


nope, as far as I could see, ```sol_vector_clear()``` does ```free(v->data)```


This commit broke my code again :|. Please master @Steveice10 give us stable realeases.


Since you're changing the method and `user.miq_groups` returns a CollectionProxy, what do you think of this?
```ruby
def set_owner_group(user)
  return unless (group = user.miq_groups.where(:description => get_option(:owner_group)).first)
  user.current_group = group
end
```


@sarmbruster and @graemerocher Does this make any sense to you?


xxx


huuum, now I'm doubtful, checking it out.


Dictionary would be more efficient than switch cases, because Dictionary almost O(1)


next steps: remove AR from gemfile, remove config/database.yml and add config/initializes/rom.rb see [here](https://github.com/rom-rb/rom-rails/issues/49#issuecomment-140071104) for a sample


I think it might be concated to the rest of the html eg.:
```html
<input name="foo" checked>
<input name="foo"checked>
```

But perhaps we should return the object:
```js
return (a === b) ? { checked: 'checked' } : null;
```
*not 100% if that works - but something to tryout*


TeamCity pull requests :: netty [Build 241](https://garage.netty.io/teamcity/viewLog.html?buildId=1558&buildTypeId=pulls_netty&guest=1) is now running


@jackvsworld There is! Take a look at https://github.com/atom/atom/blob/master/CONTRIBUTING.md#git-commit-messages


test comment


I liked the introduction to the book because it is not everyday you think about what is happening while you are using the internet. It is just a mundane activity but a lot goes on behind the scenes to connect you to each website you visit. On a side note, I have heard of Opera before, it is a good web browser and the reason a lot of people have not heard of it before is mainly due to their lack of consumer advertising.


I prefer the pattern of `raise NotImplementedError` in these cases, where the base class is just providing a stub that subclasses must override - unless there's an extremely compelling reason not to.


This looks nice. Do you plan to have `separateDebugInfo` by default for important libraries at least, so it would be in the binary cache?


101682488_EvapCoolPrimaryAirSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1852 of 1887 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.15%25-yellow.svg)


Concerned about a loss of functionality here. Before, if the validation failed, it would throw an exception, recognize it couldn't continue and blow out with the exception (continueOnError=false). However, if validation passed, but the writer.write( xxx.getXML() + Const.CR ) caught an exception, continueOnError would be "true" and only an error would be logged. In the code shown here, if an exception is caught during the writer.write, the message will be logged, and will unconditionally throw the exception (killing it right there).

That is a regression of functionality that is not mentioned anywhere in the JIRA case this code is being committed for. For this reason, we cannot process the PR in this condition.


We should probably delete this junk


? hardcode path?


Shouldn't this be "#set_owner_group" and live in "spec/models/mixins/miq_provision_mixin_spec.rb"?


hehe thx for the hint :grinning:
unfortunately I need AR in another branch, learning repo for a rails student :D


Thanks! I deactivated a test case in test/cfg/std.cpp that cases the
trouble. It can be activated after our configuration is capable of handling
function-name overloading, such as realized with std::string:find().

2015-09-22 20:02 GMT+02:00 Matthias Krüger <notifications@github.com>:

> Mh is it supposed to be fixed? I still get errors locally:
>
> ./test/cfg/runtests.sh
> Checking test/cfg/posix.c...
> Checking test/cfg/gnu.c...
> Checking test/cfg/std.c...
> Checking test/cfg/std.c: __STD_UTF_16__...
> Checking test/cfg/std.c: __STD_UTF_32__...
> Checking test/cfg/std.cpp...
> "test/cfg/std.cpp:2877:information:checkLibraryNoReturn:--check-library: Function find() should have <noreturn> configuration"
> Makefile:246: recipe for target 'checkcfg' failed
> make: *** [checkcfg] Error 1
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/danmar/cppcheck/commit/f2fae9836b86eb7d8e85ac7e7cf37fcb8948a42a#commitcomment-13373991>
> .
>


Well, like I told you, it shouldn't crash. Just fail to perform some ABEM-specific tasks.


I think we should allow for, say, 12 block reorgs. (Why not?)


Could we instead make use of the version of six included with Django? `from django.utils import six`


Хорошо, что есть юнит-тесты.


This is not a case where subclasses must override it though - some subclasses will want the default behavior, so it makes sense to implement it that way in the base class.


I can't believe it took me this long to see this commit.


sure. I can have the undolog track up to 12 past blocks (it's not much storage at all). any reorg beyond that just fails gracefully and requires a full reparse


The $rule_classes hash will not change make it a readonly hash.
!exists($Rules::CLASSES{$params->{'rule_class'}})


101682488_EvapCoolPrimaryAirSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Well, meant comment, but what to do^^


I like the name of this commit :)


# This commit made me feel like a Happy Gorilla.
![giphy Happy Gorilla](http://media.giphy.com/media/mSXU6YW5rIASI/100.gif)


Wat


Ugh, accidental addition, I'll revert.


Could I get a Signed-off-by line please?


This broke things for me.  First, previously:
```
$ git checkout 184c56b
...
HEAD is now at 184c56b... don't throw a warning for deprecated bindings when --depwarn=no
$ rm -rf deps/srccache
$ make -C deps get-libuv
make: Entering directory `/home/sabae/src/julia/deps'
git clone -q --mirror --branch julia-uv0.11.26 git://github.com/JuliaLang/libuv.git /home/
sabae/src/julia/deps/srccache/libuv.git
make: Leaving directory `/home/sabae/src/julia/deps'
```

Now:
```
$ git checkout f6665b12
Previous HEAD position was 184c56b... don't throw a warning for deprecated bindings when --depwarn=no
HEAD is now at f6665b1... more robust git-externals implementation
$ rm -rf deps/srccache
$ make -C deps get-libuv
make: Entering directory `/home/sabae/src/julia/deps'
make: *** No rule to make target `/home/sabae/src/julia/deps/srccache/libuv.git', needed by `get-libuv'.  Stop.
make: Leaving directory `/home/sabae/src/julia/deps'
```


i think for the variables, it's like... height: $height... ?


I waited patiently.


@AnriShitko


It seems that this may lead to duplicate Uris in the final ArrayList (ones added in `getData()` and from `clipData`). Can you update `uris` to be a `Set` and then convert it into an `ArrayList` before calling `startService()`?


___Attention___ : sauf erreur de ma part, votre approche ne prend pas en compte qu'un accusé de réception n'est un lié qu'à une tranche de 160 caractères du message. Du coup, par exemple, pour un message de 165 caractères (2 accusés), suivit d'un message de 10 caractères (1 accusé) au même destinataire, vous recevrez 3 accusés au lieu de deux pour le même numéro. C'est la limite principale de l'approche par pile "aveugle" (sans id ou timestamp désignant le message précédemment envoyé).

Pour contourner ce problème, de mon côté, j'ai ajouté un champ "slices_to_confirm" (tranches à confirmer) qui est renseigné dès l'ajout du message à la table sendeds avec le nombre de sms qui composent le message (Cf. modulo et division entière).
Ensuite, à chaque accusé concernant le destinataire, je décrémente le champs "slices_to_confirm" et quand il arrive à zéro, j'en profite pour passer le message en "Delivered". Mission accomplie. Je me suis même permis le luxe de gérer les accusés de réception "Failed" et plus particulièrement quand, dans le flot de sms de 160 caractères, il y en avait un qui foirait ("Failed"). Résultat, je décrémente toujours le champs "slices_to_confirm" mais si par malheur j'ai un "Failed" dans le lot, je passe directement le message en "Failed" et ce dernier ne sera plus mis à jour.

On était au coude à coude, ce soir. ;)

reposez-vous bien !


The github provider already does this automatically and uses the github login as the username.


測試案例寫得很清楚，但建議一次先寫一個測試案例。

剛好這個例子可以一次把所有測試案例完成，因為用到 target 的部分都一樣，只有傳入的參數不一樣，所以只是剛好這例子不會有太大差異。

否則，如果是每一個測試案例都需要新增一些 target 的 property, 那就會因為要讓編譯通過，而使得 prod code 提前長出來眼前測試案例不必要的東西。如果都沒錯、不需要調整，那就沒問題。但實務上很常通過一兩個測試案例後，回頭改 API，這時就可能會重工導致浪費


Agree with Braden. If the backends don't need support multi-IdP, then there is no need to override it. They can just use the default behaviour. And there is no need to force subclass to implement it.


If we're never going to use requester_id, should we delete it and update the callers?


hmmm, ya! none of my jenkins caught that!


We're getting rid of the old server, so I made a simple page to link us to the facebook page.
Doteasy has also been updated


oh wait... my branch has this properly commented out...


thank you for contributing. Good to see a test too.


This condition should be `publishDataAtJobLevel` to cover the other three cases than the one that returns true.


Should this be rmdir?


The force is strong in this one. :raised_hands:


Cool, thanks for confirming @warmdev - it appears to work, I'm going to deploy and set it up on our prod server soon.


Just curious but why did the Droplr cask get removed? URL still seems to be working fine.


*any characters


Wrong version 3.3.2?


On 9/22/15 12:09 PM, SpencerA wrote:
> oh wait... my branch has this properly commented out...
oki, perfect!

m.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/h2oai/h2o-3/commit/57bb932a667c74534e12e8d97903159758bc0a1c#commitcomment-13375479>.
>


hmm nope.


Hmmz, the Parser is still needed, we still need to parse the original Metadata into the Form. Same goes for the Validator below.


This is a test project only.


**Suggestion:** Not a big deal, but you should use the `UIView` class instead of `UIScrollView` for doing animations in the future.


97668326-WholeBuildingLoad (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1846 of 1882 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.09%25-yellow.svg)


LGTM other than the only comment.


No.  Also, you are using a QList for storing the scans (the correct choice), not a QVector.

On Sep 22, 2015, at 9:24 AM, David Leacock <notifications@github.com<mailto:notifications@github.com>> wrote:

Arent they the methods used to add/delete from vectors?

—
Reply to this email directly or view it on GitHub<https://github.com/dleacock/XPSDisplay/commit/4f6f85f7ab519a4a2efea7a5d4c25040cd74335d#commitcomment-13370080>.


Would have been nicer to split the commit and the consistency; now I’ve got nasty merge commits.

What is this option for, anyway? Why would I want to use it?


@warmdev I was able to fix this without modifying rewrites or binding it to an external IP by editing the "Server web context" field at /deployr/administration/server/

You can now see an example of the luxe.R outputs from running the script at

https://deployr.comses.net/deployr/r/project/directory/download/PROJECT-fb19a8e2-d5b0-4f76-8021-956e9ca18dcd/figure1.png

https://deployr.comses.net/deployr/r/project/directory/download/PROJECT-fb19a8e2-d5b0-4f76-8021-956e9ca18dcd/ProjectWorkspace.rData

Can you verify that these were created properly whenever you get a chance?


Default should be shell env


:+1: thanks for the clarification, & clarifying the docstring


I think we're gonna get and endless loop here, PRE_LOAD -> PRE_LOAD. Let's figure this out together tommorow.


Is this line intenionally duplicated?


Thanks! 🙌


Could you use member `empty()` from std::string instead


that was much readable https://github.com/ResurrectionRemix/android_vendor_resurrection/blob/lollipop5.1/CHANGELOG.mkdn


Suggestion: would it make sense to make the creation of the `.json` file be sorted when it is outputted? That way, the diffs will be cleaner (it will be easier to see what has been modified). I guess the `.php` file is the master but nonetheless.

Also, if you have a URL source for where the data has been taken from, that would make sense to add to the `.php` script methinks.


This ought to validate the whole URL and not just the parts (_ref_ Issue #6)


:smile: You are the best!


Can you also fix this? :-)


題外話，跟作業沒直接關係。

CalAmount() 這樣寫有滿足需求了，但以程式的可讀性來說，還有重構空間


:clap: :clap: :clap: :clap:


I see. I was wondering why it doesn't seem to work.

Regarding the API_KEY, I understand we (UBC) won't be able to use API_KEY. But there might be a need for EdX support to map users right now. (We have a few students who used shibboleth to login but put in wrong email and they can't activate their account. We don't know their usernames, only remote_id.) So this is an internal usecase.


Same thing, now on website
Looks fine here
Later will be one more file to only show latest version changelog, that will look fine on mobile


ok :+1:


Thanks for the code snippet. I think I know how to implement it now. I'll give it try!


Shouldn't `.finalize` be called when structs go out of scope too? It would be consistent with classes.


I had these tests in here in case the "whammy" makes unexpected code changes to the pipeline's structure. You're right, it does seem like overkill tho. I'll remove them.


Thanks for fixing the hound issues.


Best code ever!


Done.


97668326-WholeBuildingLoad (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1346 of 1346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.29%25-green.svg)


ye needs to be flushed


Of course not :) Just fixed it, thanks for the check.


Where's the `'use strict'`? :santa:


Well written, nice documentation and white space. Made it very easy to read. If I may make one suggestion, I might have chosen different names for the methods, something more specific to the task. This would allow you to more easily rearrange the menu in the future is you desired.


Is the reference cited in the body text?


Why?


no.  I can add that to the figure caption if you'd like.


Hello Uladzimir ,

I have implemented your code changes but i still have the same issue : When i click on Save and Deploy the change on the Layout dissappear. Is there any additional step needed after the change? ( i have executed a quick repair )

Thanks!


Yes that's much better. The only edge case would be when it is used to popuate the `class` attribute which would be an odd thing to do anyway.


# This commit made me feel like a Happy Dog.
![giphy Happy Dog](http://media.giphy.com/media/6km2RSXMSKzw4/100.gif)


Ok great. BTW edX devops can just use the Django admin to view those shibboleth remote_ids, which is simpler than using the API. So I'm not sure there is an internal use case.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 683](https://teamcity.labkey.org/viewLog.html?buildId=273524&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:24:59
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

##### there are 23 more failed tests, see build details
```


You are not copying the file but renaming/moving it.


Да все так, просто в логах довольно тяжело искать определённые сообщения. Для тестирования неудобно, откатил локально себе


it was overly hopeful


It doesn't look like you need to return `values` here, right?


I believe so


@alee Yes I can see the graph. Also can confirm that the rData file contains the R objects created during the run.


This should be "ILinePlot"


re: the added `$`, I usually try to give the context *outside* of the code block, like this:

> You can run unit tests on tota11y by running the following in your terminal:
>
> ```
> npm test
> ```

It makes copying easier, plus I've seen a few GH issues created because "the command in the README doesn't work!"

That said it's super common and I don't feel strongly about it.


TeamCity pull requests :: netty [Build 241](https://garage.netty.io/teamcity/viewLog.html?buildId=1558&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5603, ignored: 21 Build time: 00:35:56


Oh good point. I'll do exactly that.


Typo? *PASSED* vs *PAST* (or is *BELOW* better?)


These methods specify how addons show up in the files grid.


I think the intention is for it to be timeout in the end, I just don't think Daniel had a chance to change it yet.


:+1:
thanks a lot !


Tää vois olla niis setup-komennois ittessäänki mut menköön tällä ny


You have to have an extra newline in between to make this text appear on the next line.


Nice touch adding the menu to a method. Further allows the program to be spilt up and worked on as a group. Like the slot machine game, didn't get to run the code but looks cool.


Should this also be cached?


It's still required for add-on roots


I think that is a phenomenal idea. Let me make the change.


a nit here that you can ignore if you want but this could be written as:

    pre := []byte{byte(ca.Prefix)}
    pre = append(pre, randSlice...)
    serialHex := hex.EncodeToString(pre)

The `%s%s` makes me look at the code harder for bugs and mutter about string allocation that could just be a `+`. This change would also, by accident, remove some of allocations and the locking around the Sprintf format buffer.

Even just doing a `+` between them might be nicer.

I could hear no if you wanted.


Lol. So... what's his real account? I was just making some tests that I knew would be around for a while. :) Maybe twitter.com/twitter is a better one? (Not sure if that account exists).


Well, at least do the `+` and I would understand if you didn't do the `append`


Done.


Just realized that the commentaries should fit a 70 (not 71) character line. Some of them still appear with breaks in the LaTeX. I think I won't fix it.


The ones that used to be
`<Revolution custom library|custom library>`
need to be changed to
`<LiveCode custom library|custom library>`
so that the text remains as 'custom library' but the link is to the `glossary/l/LiveCode-custom-library.lcdoc` file.

Similarly the
`<Revolution|LiveCode's>`
needs to be
`<LiveCode|LiveCode's>`


Goal of this action:
If user defines an `initialize`-Function:
- until now, he needed to call the parent `initialize` for CollectionView to be set up correctly.
  [NB: at least `sortable` worked without it!]
- with these mods (2 commits), the user-provided `initialize` is called as well as our code (and as well as `Backbone.View`'s setup code) without the user explicitly calling parent's (=our) initialize.

This may be the expected behaviour in our context, since Backbone classes work like that.
Modded implementation: we don't "use up" `initialize`. Just let it for the user. `Backbone.View` does the rest.

(Backbone details):
  default in prototype: [`initialize: function(){},`](https://github.com/jashkenas/backbone/blob/master/backbone.js#L426)
  in constructor: [`this.initialize.apply(this, arguments);`](https://github.com/jashkenas/backbone/blob/master/backbone.js#L404) (thus the user-provided one, if any, instead of that NOOP)


I know this is a work in progress, but before this gets merged can you please add a descriptive commit message?


TeamCity Colore :: Release Build [Build 76](http://tc.sharpblade.net/viewLog.html?buildId=646&buildTypeId=colore_releasebuild) is now running


@alee Also, the result seems to be generated from the default `sdu2` and `sdb3` values. Can you try the query with sdb3=0 (and sdu2 with the default 0.3). You'll get a graph with almost all cells in red color.


Context can be used to load the properties file from /WEB/INF folder


This looks quite good. If I am not mistaken I think that you are making the layout a bit more responsive? I will check it out later tonight when I come home from work to see what it does! Thank you for this :)


Merci Baptiste pour tes remarques. Je vais intégrer le PR.


TeamCity Colore :: Release Build [Build 76](http://tc.sharpblade.net/viewLog.html?buildId=646&buildTypeId=colore_releasebuild) outcome was **FAILURE**
Summary: Skipping master branch Build time: 0:0:25


But...

```crystal
def foo
  builder = LLVM::Builder.new(...)
  builder2 = builder
  # builder and builder2 go out of scope, should we call their destructor twice?
end
```

Maybe we can override the assginment operator and make the memory move between them, and then preventing `builder` from being used. Or track lifetimes, like in Rust.

No... we don't want to become a complex language. Want to hook to the GC? Declare it as a class. We can later optimize the GC, do some escape analysis, etc. We want to keep the language simple.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1349 of 1349 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The about dialog inherits from the gtk dialog, so I don't think we should add to that. I suppose we could make it a hidden configuration option, but I kind of like it under Tools.


Opening link in new window.


Nope. I may improve it in the future though.


I've rebased and Travis seems to be happier but I'm still having to pass @unittest.expectedFailure due to a ``isTimeAmp`` error on the Tek, exceeding the APS1 waveform memory, and the fact I haven't created the APS2 test waveform for Travis to use.  Otherwise things seem to be working.


I see. Makes sense.


@eins78 doch da geht etwas, die exception is mutable und ich kann etwas an die message anhaengen


lgtm!


*read up to content-length header value without blocking
see more:
http://stackoverflow.com/questions/534964/why-is-the-end-of-the-input-stream-never-reached-using-java-sockets


TeamCity LabkeyModules15.2 :: CDS postgres 9.4 [Build 19](https://teamcity.labkey.org/viewLog.html?buildId=273522&buildTypeId=LabkeyModules152_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 22 Build time: 00:35:55
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

```


These need to be renamed `glossary/l/LiveCode.lcdoc` and `glossary/l/LiveCode-custom-library.lcdoc` - it's fine to just rename the file (and correct the Name: field) for now, at some point we can possibly re-add Revolution with a note that it is what the language used to be called.


Prefer to use the [management command output vs. print](https://docs.djangoproject.com/en/1.8/howto/custom-management-commands/#management-commands-output).


The comment is misleading here: `SetPath` sets the `URIPath` attribute and not as stated.


Here you should only need the include part.


An interesting idea. I have to do some experiments. But first i test a lower weight to get a feeling of the possible range.


101682488_EvapCoolPrimaryAirSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (813 of 813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.59%25-green.svg)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21068/testReport/) for this commit**


Oh, that's fine then. I'm now testing my changes, I managed to get it working with gcc5.2 toolchain. When I upload it to my github I will tell you


@justinmk I disagree. I like that default because now I do not have to jump through hoops when copying stuff from inside vi.

In any case, commenting negatively (i.e. without any constructive suggestion) on a change that has been merged into `master` for ages (in terms of Git for Windows, 5 months *are* ages) is a bit counter-productive.

Do you have any constructive idea how to fix this without breaking things (such as my expectation that the clipboard is now shared between Windows and vi)?


Hey @azturner, can I ask why you're using WITH (NOLOCK) on these? I was always told that this can cause inconsistent reads, and not just with uncommitted data in a transaction (I found an article that articulates what I know about NOLOCK: http://sqlmag.com/database-development/quaere-verum-clustered-index-scans-part-iii)   I'm not trying to question you, just want to understand why we need NOLOCK here.  Thanks!


Why `Default` trait was dropped?


done.


I hadn't seen this :(


``` c++
data << uint32(0);


thanks, forgot about the tags!


This needs to be removed


@pjakubczyk What do you think about using RxJava for delivering data from http and database to ui?


The new shader seems to have some problems with the shadows (shadows of flipped sprites work, shadows of non-flipped sprites don't?)
It will also render both sides of the sprite, which might make it a dirty fix.


Oh thanks.  They agree now.  :)


I found out that you don't actually need this line, so you should probably take it out to make it clearer.


this check probably needs to be more explicit. for example:
```go
drainLoop:
for {
  select {
    case _, ok := <-config.Updates:
      if !ok { break drainLoop }
    default:
      t.Fatalf("Updates chan should be closed after shutdown")
      break drainLoop
  }
}
```


Would it be a little faster to use strncpy() instead?
Most of files names are much shorter than 256 bytes. So should we copy always 256 bytes?
But, sure, this is a minor speed-up.


Agreed. Release scheduled for later this week, Friday 25th at the latest.


tested and working


Code is a little bit messy now, but I wanted do it ASAP


This is the same as the `remainder` method above ... shouldn't this say something like this?

     return instance(modulo(value, modulus.value);


you could make this an `async` closure and then just return null, either way though.


I know I did this before, but I went back and I don't think it's a good test. Because we control the return value. So a better test would be to check if a get request is called.
`stub = stub_request(:get, 'https://na.api.pvp.net/api/lol/static-data/na/v1.2/champion/13' + '?api_key=' + API_KEY)
@champion_api.get_champion(champ_id: 13)
expect(stub).to have_been_requested`

Something like that is a better test. It tests what the method should be doing. This is a my bad on my part. But you should also make sure your other tests are "good" tests. Testing what the method does.


good catch. Done was always empty, Updates is not.


This can be taken off


Update test


Блоки лучше искать с помощью [методов](https://ru.bem.info/technology/i-bem/v2/i-bem-js-dom/#Поиск-экземпляров-блоков-в-dom-дереве) i-bem.


:100:  :+1:


TeamCity Colore :: Release Build [Build 77](http://tc.sharpblade.net/viewLog.html?buildId=647&buildTypeId=colore_releasebuild) is now running


These are the changes from https://github.com/maximebeck/mod_bmx/commit/77710b1edb61b9f2b6f6452ae728e64fd0bea87a that still need further discussion (and no typos or formatting changes, preferably).

Statics are extremely dangerous in threaded code, and avoiding this would be useful.  Will look for a threadsafe mechanism to recover the top server from httpd itself.


@rachelweissman you should probably swap the order of this and the previous line. Do you see why?


Yea, sorry - still learning the ropes.


For me it's the server-buffer variable from server.el.


Why?


@flavour How do I apply the component filter  from the sync_resource_filter to the resource here?


@flavour Should the push method be implemented this way?


And I guess here would be better `modulus <= 0`?


@flavour removing S3UpdateResourceLink and renaming S3AddResourceLink to S3ResourceLink to accommodate both create and update? This requires modification in every file in the eden, which uses it? Does not this break workflow for any deployments currently running? I believe pull shall do the trick?


tested and working


@flavour Differential Permission? This however expose all the repository to all the user in the dropdown of the S3MultiSelect Widget regardless of the owner_by_user field? Or am I missing something here?


@flavour updated owned_by_user?


@flavour I tried hiding the option but the subscription_id default being None (while the form loads) means even if I do not select anything it gives error because it defaults to the empty dropdown? Apologies for poor explanation. This appears as http://i.imgur.com/Fnlyukt.jpg


@flavour not sure the tablename for the sync_resource_filter for location selector should be cap_area_location or gis_location?


TeamCity Colore :: Release Build [Build 2.2.0.77](http://tc.sharpblade.net/viewLog.html?buildId=647&buildTypeId=colore_releasebuild) outcome was **FAILURE**
Summary: Tests passed: 111; exit code 1 (new) Build time: 0:3:10


it feels like this more belongs in the code comments so it gets picked up in godoc, rather than in this readme...


The order of your import blocks does not match the ImageJ code style. You can check in Preferences ▶ Java  ▶  Code Style  ▶  Organize Imports. The order stated in the ImageJ preferences file is alphabetical: com, java, javax, org.


lol


( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)( ͡° ͜ʖ ͡°)


If some items can be skipped by filter, then how nItems could be i+1?
And why we assign new item to [i]?
I suppose:
result[nItems++] = filter_r;


I have a weak preference for:
```java
if (foo) {
   // do the foo stuff
}
else {
  // do the non-foo stuff
}
```
over:
```
if (!foo) {
  // do the non-foo stuff
}
else {
  // do the foo stuff
}
```
Especially when the flag itself is a negative (`nonCirculant`).


this might belong in the godoc as well, and should be put in the comments rather than the readme


поправила и вроде бы ничего не сломала


What sort of review is needed? By whom? Is it worth filing an issue?


gitignore these coverage.out files


This makes me think of how I've heard newspapers themselves are starting to look more and more like websites.  Personally I don't think that's a bad thing.  If how websites are formed and function is what makes them easier to use, and attracts more users, then by all means newspapers and magazines should do the same thing.  It's why we're here, those of us studying to be technical writers- to better bridge the gap between writer and reader.


Just a reminder, calling the static function GetCore will construct a static instance of the Core class. That aside, the proposed workflow looks fine.

Date: Tue, 22 Sep 2015 10:47:41 -0700
From: notifications@github.com
To: AndroidSchedulerApp@noreply.github.com
Subject: Re: [AndroidSchedulerApp] Update README.md (5a0b22e)

Actually that happens on step 2 when you create scheduler class.

On Sep 22, 2015 11:46, "York Kwan" <yorkwan12@gmail.com> wrote:

> Between step 2 and 3 you will need to grab the xml file (located

> somewhere?) and pass that as a list into the scheduler class.

> On Sep 21, 2015 22:08, "Andy Y" <notifications@github.com> wrote:

>

>> Hey Guys:

>>

>> Can you let me know if I understand the workflow correctly. To retrieve

>> the active list of tasks in memory, I have to do the following.

>>

>> 1.) Create a reference to the Core class in the pageMain page.

>> 2.) Create a Scheduler object - Access GetScheduler by going through

>> Core.GetScheduler()

>> 3.) Assign a list object that is filled by the Scheduler.GetActiveTasks

>> Method

>> 4.) This list is used to populate the ListViewer control on pageMain.

>>

>> —

>> Reply to this email directly or view it on GitHub

>> <https://github.com/lobstermobster/AndroidSchedulerApp/commit/5a0b22e08dc314cfe5694e1cd4adc1d5237c2b88#commitcomment-13358315>

>> .

>>

>

—
Reply to this email directly or view it on GitHub.


Method names should be smallCamelCase. (I know, this wasn't added in this commit. But I notice it here. ;-)


Same here, use `modulus <= 0`. Otherwise we get later a division by zero error, or a result of infinity or NaN, which confuses things even more.


The **required** validator makes sure that the object is not in the list of 'empty values':

**FALSE_VALUES = (None, '', *False*)**

But I'm not quite sure about the 'False' value being really false. :)

I have the following validation rule:

**('supports_something', gl.required, g.type_(bool))**

Seems valid enough: I require that 'supports_something' attribute is present and is set to a boolean value.

But the **required** validator will fail with the 'missing value' error for 'False' values because 'False' is in the **FALSE_VALUES** list.

I'd rather remove it from the above list as I cannot quite imagine the scenario where False value indicates a missing value...


I was just wading through the same error, while trying to use Tony's msvc script. Possible fix:
```
index 5b89213..a35baf7 100644
--- a/deps/Makefile
+++ b/deps/Makefile
@@ -257,6 +257,12 @@ endef
 #   dirname/file_from_download:
 #   distclean-dirname:
 #
+# see above for definitions of:
+# ^ LIBUV_SRC_DIR OPENLIBM_SRC_DIR OPENSPECFUN_SRC_DIR OPENBLAS_SRC_DIR UTF8PROC_SRC_DIR LIBGIT2_SRC_DIR
+# ^ LIBUV_SRC_FILE OPENLIBM_SRC_FILE OPENSPECFUN_SRC_FILE OPENBLAS_SRC_FILE UTF8PROC_SRC_FILE LIBGIT2_SRC_FILE
+#
+#   $(eval $(call git-external,dirname,VARNAME,file_from_download,file_from_compile,SRCDIR)
+#                              $1      $2      $3                 $4                $5
 define git-external
 include $(SRCDIR)/$1.version

@@ -274,6 +280,7 @@ $5/$1/.git/HEAD: | $$($2_SRC_FILE)/HEAD
 ifneq ($5,$$(BUILDDIR))
 $$(BUILDDIR)/$1:
        mkdir -p $$@
+$$($2_SRC_DIR): $$($2_SRC_FILE)/HEAD
 $5/$1/$3: | $$(BUILDDIR)/$1
 endif
 $5/$1/$3: $$(SRCDIR)/$1.version | $5/$1/.git/HEAD
@@ -808,7 +815,7 @@ clean-libuv:
        -$(MAKE) -C $(BUILDDIR)/$(LIBUV_SRC_DIR) clean
        -rm -rf $(build_libdir)/libuv.a $(build_libdir)/libuv.la $(build_includedir)/libuv.h $(build_includedir)/libuv-private

-get-libuv: $(LIBUV_SRC_FILE)
+get-libuv: $(LIBUV_SRC_DIR)
 configure-libuv: $(BUILDDIR)/$(LIBUV_SRC_DIR)/config.status
 compile-libuv: $(UV_SRC_TARGET)
 check-libuv: $(BUILDDIR)/$(LIBUV_SRC_DIR)/checked
```


Variable names should be smallCamelCase. Although in this case, I do think `fft_n` reads nicely... hmm...


This version was old and there’s no direct link to the new version. It’s a Mac App Store-only app.


im guessing this should read "when the message is wrapped with One"?

lets change this so we are clear on the behavior we are testing


(comments at top added to reduce the WTF-ness of having `LIBUV_SRC_FILE` and friends exist in only *one place in the whole file*: where they are used)


Since you write `if (log != null)` below, I assume you want the `LogService` to be optional? In that case, write:
```java
@Parameter(required = false)
```
Otherwise, if the context doesn't have a `LogService`, it will crap out when trying to inject this object later.


I did sync. But still build failure.

-          heejae

From: Balaji Krishnan [mailto:notifications@github.com]
Sent: Tuesday, September 22, 2015 9:42 AM
To: dotnet/roslyn <roslyn@noreply.github.com>
Cc: HeeJae Chang <Heejae.Chang@microsoft.com>
Subject: Re: [roslyn] Move ReferencePathUtilities out of Workspaces (59c3eac)

@heejaechang<https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fheejaechang&data=01%7c01%7cHeejae.Chang%40microsoft.com%7cbd1e0c6e9fa04837f08f08d2c36caf2a%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=hdBWBEG2p0eNm4W7BkJn6I3d3mt533t1f7fhOktGJPA%3d> you probably need to sync closed as well? I made a corresponding change to closed. PR 172 in internal repo

—
Reply to this email directly or view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fdotnet%2froslyn%2fcommit%2f59c3eac3af2fa4a2e0d20b450dce73559157dd62%23commitcomment-13372218&data=01%7c01%7cHeejae.Chang%40microsoft.com%7cbd1e0c6e9fa04837f08f08d2c36caf2a%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uIHO7ZmMNj2JetiryTd1CjnPnogck%2bH%2fxO9tQ%2bB8h20%3d>.


tested and working


same here... lets be sure the behavior is clearly defined


I must admit that I don't quite understand how your "darkPromSquare" boolean is working... Are you sure it does what you want? Could you describe it with a numerical example?

Here is a more pedestrian way :-)

Square promotionSq = make_square(file_of(s), relative_rank(Us, RANK_8));
int penalty = 0;
penalty += pos.count<BISHOP>(Us)   == 1 &&  opposite_colors(promotionSq, pos.square<BISHOP>(Us))   ? 1 : 0;
penalty += pos.count<BISHOP>(Them) == 1 && !opposite_colors(promotionSq, pos.square<BISHOP>(Them)) ? 1 : 0;

Hope this helps,
Stéphane


Thanks, wasn't aware they moved to MAS only. That's a shame.


I would suggest `log.debug` instead of `info`... although we should probably have some stated guidelines somewhere about when `info` is OK. I guess I see `info` as a "low-volume" thing. Printing one line per iteration might be OK, depending on how many iterations there will be...?


@Zarel it may still be a good idea to implement my version or an adaptation of my version as although some private rooms do not have modjoin and anyone can technically join it and see roomauth, people usually get banned if they are not supposed to be in the room thus shouldn't be able to see the roomauth.


@permcody, it's a simple 5 step process to add a new test dependency.


Lol


say it aint so...
delete me
delete me
:)


spelling mistake


At what point will these go away? Should we file an issue?


`firstSelected` could be `undefined` here causing the following line to crash on `firstSelected.data.provider`


I'm seriously considering just removing all usages of this function in nrepl-client. It's only used in a single line to kill the clients when the server hangs up, but I'm not really sure we want go around killing (and thus erasing) REPL buffers everytime the connection drops or something like that.