Is having this `Services` module for service lookup a pattern which has been used elsewhere? Currently in the app I think things like this as made available as globals (bleugh!) and I've had it on my list to do something better. It would be good to know if this is a standard/recommended GDS approach and we can then try to adopt it more widely.

I'm always wary when introducing a new way of doing something without changing all the places which use the old way.


I'll look into it. It may require some refactoring though, so I'll just add a TODO here.


so, does this mean v4 will be returning roles of admin and inherited_admin now?


salm b hame


Hi Enrico, I added the three js for en-route SU and updated the index but did not update the right nav. bar with the two h3 in traffic. Maybe it is easier to show to CRCO what we mean. At the end of the en-route SU section we would need to include the link to Denis' site.


I meant to ask about this in your first PR. Is this pattern of having PORO service objects in `app/services` a standard/recommended GDS approach? If so, it would be good to reference any info about it in the commit note.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 57](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=194&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:31:22


You have to base those changes on the master branch, not on your bpm plugin branch. As is it includes both plugins.


can be inlined


0 is a valid status (draft).

You should use
```php
if ($search_status != -1)
```
or
```php
if ($search_status >= 0)
```


I don't know, @Eilon @muratg ? We have resource support now so we should probably schedule a pass through to localize strings. Maybe even get P-Loc builds so we can verify localization.


These two lines can be deleted I guess?


Subjective: This reads a bit weird to me i.e. passing in the flow presenters as parameters to the constructor. I'd have thought that a publisher service could exist without the presenters and these could instead be passed in via the `#publish` method.


This isn't specifically related to claims. This field is a reference to an actual `kapi.Service`. For example, if Bob creates a service "foo" in his namespace "bob" and decides to publish it to the catalog, the `Target` field would point to his service.


Also, set the `json` to `"target"`


References #11, references #19


This call is coming from the wrong thread, current context is the UDP Listen thread, need to set a flag and have the main thread check it


I prefer the idiom:
  key == null ? null : key.intern()
this avoids the !=


Got rid of optional.


I've just noticed, it looks like you repeat "vpc_security_group_ids" argument description in Argument Reference section.


:joy:


Good :)


@sm4rty89 when i try to convert mp3, original mp4 files not deleting.

Here is debug:
```
Download Result:success
File downloaded, and converted to .mp3
URL:https://www.youtube.com/watch?v=QXb8WkFsHVg

Show Debug
Run Command:
youtube-dl -i 'https://www.youtube.com/watch?v=QXb8WkFsHVg' -o "%(title)s.%(ext)s" --get-filename
Run Command:
youtube-dl -i 'https://www.youtube.com/watch?v=QXb8WkFsHVg' -o "/home/user-data/owncloud/guven@atbakan.com/files/music/.ytemp/%(title)s.%(ext)s"fileLocation: /home/user-data/owncloud/guven@atbakan.com/files/music/Ahmet-Kaya--Merhaba.mp4fileName:Ahmet Kaya - Merhaba
/home/user-data/owncloud/guven@atbakan.com/files/music/Ahmet-Kaya--Merhaba.mp4
Run Command:
for z in /home/user-data/owncloud/guven@atbakan.com/files/music/.ytemp/*.mp4; do avconv -i "$z" -vn -y "${z%mp4}mp3"; done
Run Command:
rm -rf "/home/user-data/owncloud/guven@atbakan.com/files/music/Ahmet-Kaya--Merhaba.mp4"
```


Subjective: I know we're doing it elsewhere, but it feels a bit brittle to me to use a WebMock stub in a unit test. Why would we not stub `GdsApi::PublishingApi#put_content_item`?


Så elakt. Nu blev e-man ledsen.


Correct, we don't plan on exhaustively searching the negative set.  We don't know how far we will get.  The criterion for not using a sample is if it is correctly labeled as a negative by the previous stages (i.e. we're training a given stage on incorrectly labeled or "hard" negatives).


We can obtain good signals the 50% of the times with all the indicators.
I think this rule is valid (in the long run) for the most part of the indicators: 50/50!
Mainly, the profitability of a system depends from two variables:
1) The number of times that the signal is correct (in percentage).
2) The average of pips gained for every transaction.

(!Basically the expected value!)
Therefore is better to start with one indicator and understand where is the optimal balance to gain more points, cause whatever indicator we r gonna use, we need to pass from this point for sure!
This means that we can obtain even a percentage of 15% of profit operations, it doesn't matter..
D'you know what I am referring to, right?


In this case you can use /*  */ to make a multi line comment


And a shout-out to http://www.math.ku.dk/~m00cha/ too for providing the basis for this 'frontpage' setup!


Thanks, opened as #27370.  I describe both this issue and a comorbid problem with pkg.group_install's skip option possibly not working as documented, but I don't have enough experience with it to be sure.


Nice non-existing strings ;)
Her er dit sidste forsøg https://imgur.com/fKxTz8Z :P


So, before changing it, I'm curious to know why we have encrypted-media-respec.html and index.html. Can we just move encrypted-media-respec.html to index.html to simply things?


Something like `json:"type" description:"the published service's claim type"`


This utility looks confusing to me because it does some magic, incompatible to `DeclarationDescriptorWithSource#getSource`. So I propose to keep it private in the only place it's used. In general please also keep utilities out of `DescriptorUtils` because this class also ends up in `kotlin-reflect.jar`


How will the new rake task be invoked on every deploy? I think it would be useful to explain in the commit note.


`json:"description" description:"user-defined description of the published service"`


You are right.
On Sep 24, 2015 16:36, "Shiraji" <notifications@github.com> wrote:

> Are you sure OptionsItemHandler creates onCreateOptionsMenu? I only see
> it creates onOptionsItemSelected.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/shiraji/androidannotations/commit/e3e8f6888348a09033974757161593be08bea388#commitcomment-13416656>
> .
>


Absolutely agree! 110%


@floehopper re the `Services` module.

I've been on a little silent crusade to move away from globals and the `AppName.services(:api_name)` pattern (still used by [collections](https://github.com/alphagov/collections/blob/master/config/initializers/services.rb) for example).

It's now used in a bunch of apps:

https://github.com/search?utf8=%E2%9C%93&q=%22self.publishing_api%22+user%3Aalphagov&type=Code&ref=searchresults

Everyone seems to agree, so I say this is on it's way to become the "standard" way.


See https://w3c.github.io/navigation-timing/ for example. It appears in the spec headers.

... and it now looks like I have a bung of specs to change to capitalize the 'H' (you're the first one to report it :)


We're getting ~10k of memcache misses without set each hour:

```
           10,000.00    wikicities:sql:cache:SitemapPageModel:getWikiTitles:*
```

Let's pass `$cacheEmpty=true` to `cacheGlobal` to cache an empty result from DB.


list of catalog services


Renamed to loadMetadata


Interesting. What about extending it to allow any symbol?
```php
$f3->format('{0,number, currency}', 12.99);// $12.99
$f3->format('{0,number, currency, int}', 12.99);// USD12.99
$f3->format('{0,number, currency, €}', 12.99);// €12.99
$f3->format('{0,number, currency, CHF}', 12.99);// CHF12.99
```
That would allow decorrelation between number format and currency.

NB: this implies to drop the call to `money_format`.


I think this is probably no different than what you'd get if you set the host compiler to be 'foo'.  I'd suggest simply deleting that line to avoid the implication that we support building the host compiler with cray-prgenv-cray (which I don't think we really want/need to do).


A bit too hasty maybe. `getservent()` and `endservent()` are used in tcpdump. I've used these libpcap's functions in windump. So now tcpdump should add a `Win32/src/getnetent.c` instead.
Similar to tcpdump's `Win322/src/ether_ntohost.c` where the `"%SystemRoot%/drivers/etc/<file>"` is retrieved by `etc_path()`. Maybe these 2 file could be put into one file?

I've something almost ready.


I am having to create an aribrary tagged file resource:

  file { "splunk_etc_system_local" :
    ensure => directory,
    path => "/opt/splunk/etc/system/local",
    tag => "splunk_server"
  }

to avoid:

Could not set 'present' on ensure: No such file or directory - /opt/splunk/etc/system/local/inputs.conf at 86:/etc/puppetlabs/puppet/environments/cxp_clp01/modules/splunk/manifests/init.pp

I'm not sure where you're expecting the file resource to actually be coming from?


What code branch is this against?

V2.3 checkpatch should have caught breaking strings.

I'm sort of guessing this is not a V2.3 patch...

Frank


@sergiogonzalez In the JSP, the values of the language keys aren't shown--just the key name is shown. Any ideas?


:+1: :trollface:


Shouldn't need to ever reference xs, with the framework being mobile-first


Is this a pattern that's been used for other GDS apps? If so is there some documentation/code you can reference?


Par "Provide a short memo of what you have done to complete 1" j'en ai
déduis (avec un doute) que cela se referait à la première étape qui
consiste à mettre en place le repository GitHub.

Je vais rajouter dès que possible une section dans le README.md
correspondant à l'installation de Galaxy.

Cordialement,

2015-09-24 13:39 GMT+02:00 Christophe Antoniewski <notifications@github.com>
:

> Is it the memo about Galaxy installation/running/customization ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zakrapovic/ARTbio-demo/commit/70f9cdb7ad87a76c8e3d70962f750bcfd39ad2fc#commitcomment-13412560>
> .
>


Having POROs in `app/services` is pretty common across GOV.UK I believe.


The ID should be "http://jsonapi.org/schemas/1_1/create.json". That would need to be changed in each of the schemas.


Weird, I thought this worked on Ubuntu, for my machine at least. Maybe a CMake version difference?


Is that the input/field type? Should this really be in the versioned data (or changeable at all)?


Is there a better, more descriptive name for the res mixin? Like we changed fs to font-size to prevent ambiguity


Jeg kan btw ikke se shackleshot?


I've just noticed, it looks like you repeat "vpc_security_group_ids" argument description in Argument Reference section.


is your commit message right? `aws.Volumes` is not here :)


I'll do it.


@jmcarp Will this only come up for groups, or will it display for individuals as well?

Chatted with the amazing @lindsayyoung about this. Would love her thoughts and yours. How about something like:

"No data found.

This can happen for a variety of reasons. For example, the FEC may not have finished processing a filing. Additionally, this group might not have filed yet or might not be active."


`frontend.java` is what's shared between command-line JVM compiler and IDE. This implementation (and `ModuleVisibilityHelperImpl` above) doesn't look like it's needed in the IDE, so I propose to move it to the `cli` module. You'll have to provide empty implementations somewhere in the IDE, please look how those are done for other services if there are any


`not self.is_section` - you could put this property in the subclass that's used for actual fields and thus avoid this check


Storing the address as string here adds overhead to every single scribe instance. I would instead prefer a lazy approach, using a `virtual string addr() const` member function that creates this address on-the-fly. This pays the cost of allocating heap storage and system calls only if explicitly requested by the user.


Yes, it should be deleted.


Works great , tested with fedora 22,.......... thank you.
I like the idea to use it as toggle button to switch between 2 workspaces.
@flexiondotorg
Can you please merge that to master and 1.10 please.


@aleffert fyi


Yeah, I actually agree with that. Updated.


Yep you're right sometimes I forget that


@kostya I just made [this commit](https://github.com/manastech/crystal/commit/90b5c938ab86fab8ad3253126e602a16661bb484) that fixes it.It might look like a had, but those are fundamental methods that should always be inlined. For some reason the new way we compute backtraces makes llvm decide that in some cases they shouldn't be inlined, but we don't know why, there's nothing strange with our code. Could you check that this change improves the performance on your side too?


Nice! lot's of people asking for this.


oh damn, quotations in slots aren't stack checked until they are run.  good find.


Based on the [Space Telescope Science Institute schema guide](http://spacetelescope.github.io/understanding-json-schema/structuring.html#id), you could change the `$ref` to:

```
"$ref": "request.json#/definitions/request"
```

The advantage here is that you won't have to update each reference when creating new versions.


The try..except is not really needed anymore now that it doesn't come from a signal


Ah! Thanks for pointing that out


Ok, I'll move it.


You are adding this twice, but not to the model


defer.resolve(); is never called after the change in src/angular-oboe.js


canola oil is crap


shouln't this go to sterr?


How do you think about to delete any trailing (double) underscore here?


我更新到 0.8.1 android 还是返回没处理信息


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21161/testReport/) for this commit**


For making this feature orthogonal, `acceptor` should offer the same functionality.


If there's nothing to reference, I think it would be good to explain a bit more about it e.g. why does it sub-shell out (if that's what's going on with the parenthesised statements). Incidentally what would happen if the checkout failed? Would the script as a whole fail?


Kind of agree with you but I "pragmatically" prefer a webmock stub here to be sure the publishing-api is called correctly. If I stubbed `GdsApi::PublishingApi#put_content_item` I would feel inclined to make an integration test as well.


Because these two lines are exactly the same in both implementations of `ModuleVisibilityHelper`, I guess you could move them to `isVisible`. After that `DescriptorUtils#isInFriendModule` will have only one usage and will be able to be inlined. This implementation will be empty, so it'll be easier to make it an object with the name `Empty` and make a nested class of `ModuleVisibilityHelper`


Updated commit message.


What makes `SCHEMA_GIT_COMMIT` available? What consumes `GOVUK_CONTENT_SCHEMAS_PATH`?


Hi joshhornby, can you please explain your changes? why is it necessary?


In which case would this be an empty string? I guess it's NULL for a section/static-text entry but an empty string doesn't seem very useful.


This creates a cyclical dependency between request.json and response.json. You noted that this is the "base schema", so `meta` should be defined here and referenced in response.json.


We aren't storing camelcased data in the DB, right? If we do let's change this :)


Je crois que ça pose problème de passer à rgeo 0.4.0, il caste les objets en CAPILineString au lieu de FFILineString... je vais investiguer


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#RdFkDMznSTOxV-DR-iuyow


cmake version 3.0.2 here, updating to the latest now. Weird indeed..


Done.


Please use `ModuleXmlParser#TYPE_TEST` instead, btw another reason for this class to be located in `cli`.


Worked for me also with 3.3.1.


On the line immediately below.


Good catch. Fixed.


I don't know much about it, but it feels as if there might be some duplication here between `FlowRegistrationPresenter#paths` and/or `#prefixes`.


There's similar but not identical logic in equals. It would probably be better to unify them. I'll make it so.


deleting the line ...


Still having an issue, with 12 datapoints all being 0:

CALayerInvalidGeometry', reason: 'CALayer position contains NaN: [2 nan]


Too bad we don't have [PEP-448](https://www.python.org/dev/peps/pep-0448/) yet... it cCould make this a bit nicer ;)


What I was proposing to do is bind completing-read-function to our own variable robe-completing-read-function when it's the -default. That's very conservative and if the c-r-f is set to something else permanently (which is *hard* to make work properly), assume the user can manage it.

I have a couple of problems with the idea of ido everywhere. One is that I don't actually *like* ido in many situations; it's visually overbearing and harder to use when it *doesn't* stand a good chance of having the eventual result in the first few matches. For example, I don't use ido for find-file, but use it for recentf.

The other is that completion is pretty basic in emacs  (think M-x and describe-stuff) and I don't want e.g. ido-ubiquitous heuristics at that level. It's no fun repairing an emacs session with something that basic gets broken.


What about circular dependent modules like our idea and j2k, where idea depends on j2k-production, but j2k depends on idea-test?


Say What?


whee!


@sergiogonzalez I'll take a look at how the other portal settings JSPs are doing it.


hello


the panic is mostly an assertion because if we're in this situation, and the replica actually attempts to execute the command, it should never fail. So we want to ignore all errors which can happen before execution. It would probably be better to use the IndexedError information for that: if there's an index, it means the request was tried but failed (in theory: in practice, you find out you're on the wrong range when executing the first request, but we could have that checked earlier).

Probably good to replace the TODO(tschottdorf) with a comment outlining the above.


70-80 characters perhaps? Sampling a line on our service I get 72 characters with max-width of 30ems and 19px.


Minor: I know you renamed the `registerables` to `flow_presenters` in a previous PR, but I think there might be some possibility for confusion in that there are at least four presenters for a flow:

* `SmartAnswerPresenter`
* `FlowRegistrationPresenter`
* `SmartdownAdapter::FlowRegistrationPresenter`
* `GraphPresenter`

I think the ones in this class are supposed to be instances of `FlowRegistrationPresenter` or `SmartdownAdapter::FlowRegistrationPresenter`, but I can imagine that people might think you mean the first one in the list...


Done.


Passive?


>-bool AP_SerialBus_SPI::sem_take_blocking()

You should split whitespaces fixes in a separate commit for clarity purpose.


I wonder if this should have a heading and id so we can point people at it. We could then have a bit of justification along the lines of 'long lines reduce legibility, so...'


This was meant to be ``pinned`` not ``recursive``. Fixed.


Victoria


createLabel


Should be `if (target == Platform.WINDOWS && PlatformHelper.hostPlatform != Platform.LINUX)`,
unless mingw is also available on osx?


I think you are not following eslint rules here and in other places, is npm run lint passing?


Why not `ModuleBuilder`?


Am I right in thinking that `FlowContentItem#base_path` only needs the flow to have a `name`? If so I think it might be clearer for the stub flow not to have `content_id` set.


coding style:

while ... ; do

;)


@gkellogg Can we release these sort of changes (removing predicates) as a major version in the future. This was a breaking change for us.


Hm, I guess I would use `'€ {0, number,decimal,2}'` in such a case.


fixed


Less code, less bugs.


Python propose le mécanisme suivant pour ouvrir et fermer implicitement les fichiers :
```
with open("/mon/fichier", "w") as file_:
    file_.write("string to write")
# here file_ is implicitely closed
```

Sinon, pour la base en particulier, on peut éventuellement utiliser sqlite qui est inclus dans la distribution standart de python, et qui gère la base de données dans un fichier (exactement comme tu cherche à faire ici)


@eritiro I replaced .save! with update_column, gonna test.


Could we please use "contributing to" instead of "hacking on"?


I think we should move this component among the general components, is not a viewer specific component.


Oh, I remember what I was thinking. The NAPTR records have an IP address in the name. But this check is all sorts of wrong. I think it would be best to either whitelist the types that can be changed, like A, AAAA, CNAME, etc. or blacklist NAPTR. Thoughts?


what ? fdfsfgdsf it's a joke


wow, 15 min! any ideas what specifically makes it slow? are there any things that are proved repeatedly and that could be factored out?


I don't think that bootstrap styles work on buttons created by button_to. An alternate implementation would have been to wrap this is a form, make this button into the submit button, and the no button a link_to. We can cover that today.


This is a generic placeholder and would apply to many tables (independent expenditures, electioneering costs, candidate and committee filings, etc.). The language above makes sense for filings, but probably not for electioneering or communication costs. If necessary, we can write different text for each table, but it would be simpler to use a single generic message.


I would use "project" rather than "component"; it's better positioning for the Hawkular Metrics.


hmm... would not change this to be able to grep for variable use..

e.g.: git grep \${mode}


nice ;)


Updated commit message.

Other apps: https://github.com/search?q=user%3Aalphagov+%22rm+-rf+tmp%2Fgovuk-content-schemas%22&ref=searchresults&type=Code&utf8=%E2%9C%93

`SCHEMA_GIT_COMMIT` is made available from CI, `GOVUK_CONTENT_SCHEMAS_PATH` is consumed by `govuk-content-schemas`.


Put PTR on the blacklist if you make one. http://stackoverflow.com/questions/26832337/google-cloud-dns-ptr-record-error


It seems in this case chunk will contain all circular dependent modules, so this method should return in line 75 for internal descriptor from any of these modules.


Sure


What is this?


Since this message is known to happen under some cases, I would rather make LogDebug() rather than LogInfo.

Also, you should only skip glist_add_tail if the item is already on the list. In other words, you should still execute the max_headers code.


Indentations are 4 spaces, no tab!


crush2 doesn't perform well on longer regularity conditions of the form stp G [] T T for some reasonably big T (e.g. the final resulting type), and there are quite a few of those.


@tsr-thulio could u pls move all inline styles from this file into a proper external stylesheet? tks!


How about "Hawkular Metrics is a Hawkular child project, so top level conventions ..." ?


Нужен ли этот див?


Space missing after "if" (conditional statements must have a space around the parenthesis


You could initialize it to zero using { 0 } or { false }:
```
bool swig_override[%d] = { 0 };
```


Extra newline.


What kind of duplication do you see?


subproject


Might be also `list(self._obj.Seq())`


Заголовком?


Do you really need a fix, including a release, until (inclusively) tomorrow?


PTR should be okay since it is a FQDN. The name in that article, `"xxx.xx.148.146.in-addr.arpa."`, has a `.` at the end.


And what about shipping bro and any other fees?


Would it be faster to derive wf_tp G [] T and then convert to stp G [] T T?


Yes, it seems more appropriate. I'll use it.


done


I didn't know about the others. What is the difference between a `Flow` and a `SmartAnswer` then?


Would be nice to explain in the comment why this `true` is in fact a lie but shouldn't affect anything


What changed? Mostly, it was a re-serialization using the prefixes for pplan and fcrepo4. Any other changes happened at the source vocabulary level, AFAIK. Is the issue that the source vocabulary changed in a way you're not prepared for?


¿y dónde quedaron?


Only change in Windows\CertModule.cs is the chain.Build check before and the  chainStatusArray check towards the end


@sdougbrown for future, need to bump the version number in bower.json before doing the release/tag. You can also just run `bower version patch` and then push it, it takes care of everything for you.


It wouldn't install v1.0.5 for people because it didn't match with the bower.json file


@tsr-thulio I don't think it's necessary to specify the timestamp field on this composite index spec. Can you please verify?


I think this should be named something else. By convention, member functions called "toSomeDataType" convert the object with that member function to that type. This isn't for converting a MetadataManager to a ByteArray.


Why do you need both this and the return inside the catch block?


Frank, this will go into 2.3 but Swen did against 2.2 (actually IBM branch!).


The fix is wrong. return true if sourceFrame == targetFrame


I think both "b" and "in" should be given more descriptive names.


I'm going to go ahead and fix this. I think we decided not to do qthreads or muxed with cray-prgenv-cray in this release, due to a lack of enough time to test (and maybe a lack of stable platforms to test on?).


I mean, timestamp is not part of the query condition statement, it's just and order request. Remember that for every index definition two tables (desc, asc) are created? So without it it should satisfy your query perfectly.


The fact that it's a service loaded by `ServiceManager` which is used only from another service loaded by `ServiceLoader` will surely blow someone's mind :) I propose to add a comment explaining that the `ServiceLoader` service is needed to abstract compiler and reflection, and the `ServiceManager` service -- to abstract compiler and IDE.


Ack.


Since we have wf_tp anyways, would it make sense to use it uniformly for regularity? I mean basically replace stp T T everywhere?


You're right. Removed the `content_id`.


Do not free returned string resources will get freed when lsm_system_record_free is called.


Ссылка на главную


The default deepClone from FObject should be fine.


On Thu Sep 24 17:15:42 2015 Mihai Moldovan <notifications@github.com> wrote:
> Do you really need a fix, including a release, until (inclusively)
> tomorrow?

Nope, I am providing a fix via nightly builds...

Mike


I think there are only a couple of method which are delegated to the underlying state object. If that's correct, I think it would be better not to use the "magic" of `SimpleDelegator` and declare or implement the delegation more explicitly.


I used templates when I had more than 3 functions to write (to remove the multiple declarations) in multiple places, but in this case it's not that useful, I'm considering writing everything that was templated to explicit overloads, maybe that will be easier to read when discovering the API for the first time, I dunno.


http://lebra770.github.io/Lucas-NHA-Fall-HW1/projects.html
Broken images.


@vadz have you tried this test on windows? On Windows7 64 bit this produce syntax error. Just wondering if it issue with my configuration/driver or it just unsupported...


Not yet, but the plan is to be able to reuse some of these components in the editor, so might as well make sure they are set up right.


Awesome! It's so good that you keep these benchmarks up to date :-)


The scan failed.
Included commits

Commit ID	Owner

9872989bd39d3dd5979d62e853474ea3c26087cf	@BearSpace


Looks like it breaks 007.phpt...


good choice


Nice one


There's a lot going on in this commit. I think it would be clearer to split the commit into two parts i.e. (1) the introduction of the `OutcomeDecision` class; and (2) the moving of the question.


Why's this change needed?


Ok, thank you for your attention! I'll try to contact him.


I expect that may happen (this is not an error condition), as the loop line 443 will retry until *total* timeout expires afetr which we throw Service Unavailable.


But the commit you pushed yesterday that forces symlinks to be created re-opens the 32bit bug that was supposed to be fixed by this new logic.


Maybe we should stuff this in some file and load it from there?


Hm, actually it is correct. But still wrong. the check for the empty chain must be removed altogether.


Swen, either you or I misunderstood your fix as it has other noise in it! Let me try to explain:

Old code will call enable_log_facility or set_default_log_facility unconditionally. It should. This is the right thing to do.
Your code calls one of the above only if "facility" does NOT exist already. This is wrong.

Existence of a facility doesn't mean it is enabled (in your test case yes, not true always).


Cheating accepted !


Have you considered using Page here?
( Abstract class for type hinting (accepts WikiPage, Article, ImagePage, CategoryPage) )
see WikiPage.php, L#3


No, I didn't test with Access, I don't have it. If it doesn't support SQL `NUMERIC` type, this test should be skipped for it...


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Add post-message-io


My bad. It was a typo, you are the first one to interpret it in literal sense ;-)....


I think you need to make it `Disposable` and clear this list in `dispose`, but not entirely sure


hm, how did this become a new commit in the rebase even though it's in master?


Make this a named constant and a power of 2 (probably 16 * 1024 is appropriate here).


There should be spaces like, "new Property[] { remote..."


well ... that's why I added a second commit https://github.com/code-couleurs/chamilo-lms/commit/efd075ea8b668daec3d050f7b3985a668219f0a7


Yeah, but need dtors to avoid leaks, must be another fix ...


could you include a testcase in this file testing what happens if the user requests spelling for an unsupported/nonexistant locale? Important corner case IMO.


ให้ทำการ Initialize  ข้อมูลก่อน


Add check for LSM_IS_SYSTEM before using the sys pointer.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21162/testReport/) for this commit**


I might use a `next_node_calculation` block to do this assignment (if that will work), not because it's better, but because it's more consistent with the rest of the code.


Yes, the source vocabulary was versioned.  In 0.8.4 it rdf-vocab shipped with the http://fedora.info/definitions/v4/2015/02/04/repository version and 0.8.5 shipped with the http://fedora.info/definitions/v4/2015/07/24/repository version.


Yeah!


Такое поведение "поставить значение, сделать рекурсию, убрать значение" является характеристическим для бэктрекинга, именно поэтому он и называется бэктрекингом, и не обязательно это стыдливо прятать в контекстный менеджер, хотя это на вкус и цвет, конечно.


On Thu Sep 24 17:25:15 2015 Mihai Moldovan <notifications@github.com> wrote:
> But the commit you pushed yesterday that forces symlinks to be created
> re-opens the 32bit bug that was supposed to be fixed by this new logic.

I thought so, actually, as well. I will provide a more genuine fix for it tomorrow.

Mike

--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976148

GnuPG Key ID 0x25771B13
mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de


Hello,

I've contacted @casallas on this thread - https://github.com/casallas/wiic/commit/e6427bab98425e340d9df099bf1c6d8142947256 - regarding a commit about fixing a memory leak. He said that that commit was yours.

I'd like to know if that memory leak was fixed on wiiuse's original code or on new code from WiiC.

I'm asking that because I'm having a memory leak issue on Windows with WiiuseJ, which is a wrapper around wiiuse.

Thank you!


If I'm understanding correctly, the being affected Jacobian by changing the EndEffector's relative transform is the EndEffector Jacobian but not the parent BodyNode Jacobian nor any descendant BodyNode Jacobians (including their possible EndEffector Jacobians). That being said, we don't need to update the BodyNode Jacobian due to the change of the relative transform of the EndEffector.


There's a use of private on line 220: "... When a symbol is declared as private, however, such access is not permitted ..."


Because there's so much going on, I found it hard to be sure it all makes sense, but as best as I can check it, it seems ok - and the fact that the integration test (and presumably the regression test) still pass means that I think we can have a high degree of confidence that this is doing what we want.


a = new int[10];


@winstonf88 faltou adicionar o link da issue no final do arquivo.


@vtikha


Yep that's from another topic, I just committed all previously non-committed .jars


This was *fun* to run into at 2:40am after I pulled the update and rebuilt my local installation and suddenly ran into a fatal error :wink:.

Sadly the options to handle this sort of thing are relatively limited, particularly since passing `--with-http_spdy_module` to `configure` on the devel/head builds is a fatal error rather than a nice warning.

The separate options would have encountered the problem that everyone doing reinstalls/upgrades/etc who had previously used this module would have retained the `--with-http_spdy_module` flag that kills configure, so wanted to avoid that situation given a lot of `nginx` users stick to the devel line.

We don't really do aliased options well at this point, but it's part of the longer term "to improve" list.


this is a regression
when we create a text, it just shows an empty white box
reverting to GL_SRC_ALPHA solve the issue


Dashes for the name of a form are not honored in angular.  Had to change the form name to camel case.


div is the default if no tag is given


oh no!! Nice catch.


kOS prefix not needed here, will leads to double kOS: kOS: according to Logger layer of KOS itself.


Should this be using boost::noncopyable if C++11 offers similarly verbose `delete` for copy constructors/assignments?


That's correct.

Putting the ``notifyJacobianUpdate()`` call in ``BodyNode::notifyTransformUpdate()`` was just to make the code look consistent between the two classes, and not for any functional purpose.


hihi


Réel pour moi sur A2, observé sur Chrome/Safari/Firefox Mac.


Victoria


Yes, you could use `a IS NULL` during index selection, though I wasn't planning to do so initially.


thanks! I have added this branch to my branch


spacing


Add a bio file for zhungtm


oops, that's some leftover of my experiments. Thanks for the notice.


Der gefällt mir immer noch nicht. Du brauchst den owner nur, um den Super-Constructor aufzurufen und die relative Position zu setzen. Ich würde den owner deshalb als Parameter übergeben.


Sure. Added. This is just the general approach of expression analysis. If we don't know or care to handle an expression, we replace it with `true`. This allows `a = 1 AND b IS DISTINCT FROM NULL` to be simplified to `a = 1` for analysis.


No idea why you removed the space. Some would argue that the proper form for empty elements is to leave an empty space before the trailing "/>".


It s a good point. Not sure what the preference is. I can change it if you feel strongly about it.


Why is there slice? Lineclip is immutable.


do we need a similar check along the lines added in https://github.com/php/php-src/commit/0e843a45820941345d1b1695040ab699cf3a0b2a ?


простой рекурсивный бактрекинг вылюядит так:
solve(game):
    if (game board is full)
        return SUCCESS
    else
        next_square = getNextEmptySquare()
        for each value that can legally be put in next_square
            put value in next_square (i.e. modify game state)
            if (solve(game)) return SUCCESS
            remove value from next_square (i.e. backtrack to a previous state)
    return FAILURE

А эвристики просто дают getNextEmptySquare() в нужном порядке


First Step


Should use properties and dependencyManagement for versions.


Wie bei ScheduleDataEntry, Konstruktorparameter statt static Field mit Set-Methode verwenden


What I meant, `EndEffector::notifyTransformUpdate()` also doesn't need to call `notifyJacobianUpdate()` in it.


Hi,

you should provide me with more information about how to reproduce this memory leak, under which circumstances it manifests. Do you have any log file of the output? Please, take into account that WiiC is a very old project not anymore maintained.

Cheers
Gab


Hey team - just so we are aware, we still need a flash message to let a user know that they have added a donation to their cart. In addition, we get an error page if our cart is empty. We should still render the page but say "there is nothing in your cart at this time" or something along those lines.


I'd suggest replacing all `forEach` with a simple for loop for performance.


Why so?


That's fine - I don't object to the approach. The trouble with silent crusades is that if a bunch of people are on different but conflicting silent crusades and nobody else knows about them (because they're silent!), then the code can easily get into a real mess.


How do you suggest we handle these types of things? The practice before releasing a new release is typically to look for updates to included vocabularies. Maybe tools that have specific dependencies on particular vocabulary versions should include their own version of the vocabulary they can manage independently?


В бэктрекинге deepcopy не нужен


OK. I'll make a note to change all the other occurrences.


here you could just do `lineclip(line, bbox, lines)` instead of the inner `forEach`.


At least there was in this version . . .


@flexiondotorg
Commit doesn't apply on 1.10.2 tarball, so i can't test it.
IMO, it should be merge, if it cause regressions we will see it in 1.11 dev releases.


I think it's be nice to build a `LineString` if `clipped.length === 1`.


Neat!


Excellent!


Tabs.


use subprocess to fix shell injections, no os.system() call please.

your fix wll not work when you have a group name like this

mail$(thunderbird)

or this group name

list`gedit`


I'm not convinced, but since we're already taking this approach across the codebase and we already have a Trello card to change the approach, I'm happy for this to stay as it is.


It calls its own ``EndEffector::notifyJacobianUpdate()`` because if the relative transform of the EndEffector is changed, then its own Jacobian needs to be changed.

Also, @mkoval and I have discussed the possibility of allowing a ``Node`` to be a child frame of another ``Node`` that is attached to the same ``BodyNode``. In other words, you could have an ``EndEffector`` whose transform is defined with respect to another ``EndEffector`` instance (as long as they are both attached to the same ``BodyNode``). In that case, the ``EndEffector`` would need to call ``notifyJacobianUpdate()`` to make sure that any dependent child ``JacobianNode``s are also updated.


spaces around `===`


Very cool !!!!


La clase `Situation` contiene todos los datos de entrada necesarios (un `TaxiAgent`, la carretera o `RoadMap`, y todos los `Request`s) para resolver el problema. La idea es crear una clase `SituationSolver` o algo así que genere como salida la ruta del `TaxiAgent`, es decir, un `ArrayList` de `Position`s que representa la solución del problema.


The new commit note looks good - thanks.


What does `order_by('id')` do here? If you're doing it in this order to process parents before children then you should add a comment about this.

Also, what if the command fails halfway through? Is it possible to wrap this in a transaction?


> `saveModesFile(QString)`

i think what you mean is `QucsTransCalc::saveModesFile`. that would make a good workaround (if it makes use of `saveModes (QTextStream&) const;`. the point is: `QucsTranscalc` should not implement file i/o...

i do not know exactly, what the code is doing, but my guess is, that `QucsTranscalc` is one extension of many. extensions should share the same interface, but not all implement file i/o individually (for example).

> Regarding const unfortunately I'm not (yet) used to pay attention to that

don't worry, there's a lot of work to do (beyond the scope of this PR, obviously). just trying to point out a rough direction.

thanks
felix


这个只是当初随便写的，Erlang无需自己处理粘包。通过{packet, N}，每个Packet前面自动加上了消息长度，底层为你处理好了分包。MsgId是完全的临时性方案。后续有时间会重新写一个基于集群的Erlang服务器。思路参见 http://wudaijun.com/2015/08/06/erlang-server-design1-cluster-server/


@wlbragg Do you need any textures for it? If you want I can try to come up with some shiny metal texture such as the one you posted in the photo above.


Don't think I meant to remove this!


cool, line 39 could be removed though (purely optional :))


Can't we just update instead of delete+create if key values are unchanged ?


There appears to be other code that adds the leading forward slash:

* https://github.com/alphagov/smart-answers/blob/master/app/presenters/flow_registration_presenter.rb#L29
* https://github.com/alphagov/smart-answers/blob/master/app/presenters/flow_registration_presenter.rb#L25

Whether or not it's doing it for the same reason - I'm less sure...


@DAB0mB `document.load` looks good as well. But you didn't answer why we need a `processIndex` to parse user's index.html to add that script? We can just add html file with this importing script and avoid index.html.


Thanks. I'm always sloppy about trailing spaces. I'll do better.


`value.strftime("%e %B")`?


since Turf works with GeoJSON, this should say `[minLon, minLat, maxLon, maxLat]`


@latobarita: retry


I guess this should be an equivalent transform, but it is not. This is one example where it matters:

```rust
fn foo() {
  x[x..x]
}
```

This does not parses when `index_arg` is inlined. When it is extracted, it parses correctly. I've met the similar problem in my parser.

It may be a bug in Grammar kit, but I am not really sure


Perhaps. That distinction in postgres does not seem useful. I'll add a TODO.


Add post-message-io


We should also mention that it can introduce degenerate edges on bbox boundaries.


This 'print' statement should be removed


hahaha


Not much. I guess a flow can be either a Smart Answer flow or a Smartdown flow. However, I haven't managed to come up with a better name, so probably ok to leave it.


Are you setting text color? I believe if you set the color with alpha as in "model text color 1 1 1 0.9" it will show fine.


How about win-64? :) On your [binstar channel](https://binstar.org/jschueller/pandoc/files) as well! :)


Nope, in that commit the vars are local and the function immediately returns, so there's no risk those vars to be reused. Thus one can spare that.

Thanks for the checks )


:yellow_heart: This was a good attempt at checking the data type of the `searchKeys` argument. Unfortunately, `null` and `{}` would pass the type check because all three have the same type: `object`. You'll need to implement a more robust check.


Добавлю номер туриста)


TeamCity pull requests :: netty [Build 277](https://garage.netty.io/teamcity/viewLog.html?buildId=1661&buildTypeId=pulls_netty&guest=1) is now running


It can happen due fundamental flaw in ash architecture.

ash.vim request diff first (ash run and exit there, storing diff in the
file you edit; it's "mine original" version). Then you make your changes
(creating "mine" version) and run ash again. Ash downloads new fresh
version of the diff (it's "theirs" version, which can contains new
comments) compare it with your edited version (lacking that new comments)
and consider that you deleted new comments.

ashium uses 3-way merge to overcome this issue by comparing not only
"theirs" and "mine" versions, but also "mine original" version.
On Sep 24, 2015 1:52 PM, "Egor Kovetskiy" <notifications@github.com> wrote:

> how ash.vim can delete comments?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/seletskiy/ash/commit/2a58db282dad6b8137bc56c154653bc76050b633#commitcomment-13408649>
> .
>


:yellow_heart: It's useful to specify what the delimiter is in a `join` call even if it is the default delimiter.


There should be a config permission for this because other servers might not want this command or want to limit it. Such as: Smog Tours.


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/2c9735ee6996c57b44f5611e8b7340391fbb285f


merging MonsieurNicolas/stellar-core/logRootSeed = 2c9735ee into auto


MonsieurNicolas/stellar-core/logRootSeed = 2c9735ee merged ok, testing candidate = 22aa352e


Final dot.


I'll check why it fails. It would be a hell-lot easier to grasp such changes with test-cases being fixed.
One small ~~party~~ test never killed nobody.


Shamow!


hai raffik how are,,,


@tadast: I think we'd need a separate `MonthAndDayQuestion` & presenter to do that wouldn't we? Also if we did go down that route, it would be good to add it as a new *named* date format to `Date::DATE_FORMATS`.


this makes installing this package via bower incredibily slow and painful. bower now downloads a shittton of files TWICE, because dependencies are going to be installed anyway via dependency resolution...


Почему нельзя откомментить строчки выше? там будет figure c картинкой и ссылкой)


I wasn't clear enough, the index.html will be optional, it can still be defined though, and each tag will be appended accordingly. Do you think we need to completely omit index.html? I think we still need to support it


we should move the complete PVR else-if-block to the top to not check HasPVRChannelInfoTag twice.


Oh man, thanks for adding the braces.


I suppose we could call ``EndEffector::notifyJacobianUpdate()`` in ``EndEffector::setRelativeTransform()`` instead if that would be preferable.


or if someone alter the checks he don't have to double check which one is also used in the PVR block.


I did, but I think there is something wrong with Github, I can't merge ed5c73b.


Because it wasn't compiling. I have no context on the tests, just greening up the build, your suggestions seem reasonable.


Pu reproduire sur a2 sur une autre discussion.  Envoyé un fix à l'aveugle:  https://github.com/ImaginationForPeople/assembl/commit/54c2e1e1da5a42149208e88aae77a1e5abb2ad4a , on verra ce que ça donne.


Does the latest version of pocket mine work with php 5 or does it _HAVE_ to use php 7


bacon to cake?


:red_circle: You should not create an instance of the `Index` in the source file. This will be done in the test.

The `invertedIndex` file should only contain the definition for the Index object.


Full name?


Can you use `MissingTitle.for_title_field`?


ok


Looks good to me.


Is this a preference file or a code style file?


Is this exception caught anywhere? I don't see a try/catch in iCheckbox. If so, shouldn't it include some meaningful message?


which specifies


I think I put there because was somehow "required" by the exercise instructions hehe


shit why is this in master


unfortunately no, need to develop ourself, does it worth?
http://codereview.stackexchange.com/questions/30846/zip-like-functionality-with-c11s-range-based-for-loop


But you weren't using it!


Mind creating a pull request for this? I'd love to use this from the official repo...


Again, "which specifies"


No hometown entered.


Is this addition actually necessary here? Where is it used?


Nope, this was an exception for debugging purposes that I never got around to removing. Good catch!


Yup, that's my full name.  I use an alias at work.


Ok, I'll make an extra effort to put ...
![rjkzp](https://cloud.githubusercontent.com/assets/5313226/10078683/0cefc8f6-62e6-11e5-874c-08fe92eeb1eb.jpg)


So we expect this to only be called on the formals of _fn?  That expectation might be worth documenting


This method needs to be address by GUIL


I guess it is used for packaging Phonemetadata.java so that maven could understand what it is


Thanks a lot for your fix. One question - shouldn't the line `outb (0x8900, *p);` be located in `for` loop, instead of `outw (0xB004, 0x2000);`?


Right, since the relative transform of the `EndEffector` is changed, `EndEffector::setRelativeTransform(~)` should call `notifyJacobianUpdate()` instead of that it's called by `EndEffector::updateTransform()`.

Putting `notifyJacobianUpdate()` in `EndEffector::updateTransform()` and, for consistency, `BodyNode::updateTransform()` would also work anyways. However, this would introduce unnecessary cascading calls one from `BodyNode::notifyTransformUpdate() and the other from `JacobianNode::notifyTransformUpdate()`.

As mentioned above, the Jacobian computation is dependent on its parent Jacobian and the relative transform (not the world transform). So, in order to avoid unnecessary cascading calls, `notifyJacobianUpdate(~)` should be called only when the relative transform of its parent BodyNode; the child BodyNode's Jacobians will be get dirtied by  `notifyJacobianUpdate(~)` itself.


Refactoring


default=1000?
copy and past  is evil !


Sorry for that, that code was "Lost in translation" from one file to another


Go style would be `metaFull`


new comment


Rename the variable name to dataFilePrefix.


I think `o.metaFull["X-Object-Manifest"]` should be sufficient here


I tend to avoid one-character variables as much as possible even if they're use for "dummy" loops.
But for you I can reduce it to "pos" only


zzzzzzzzzzz da


> I suppose we could call EndEffector::notifyJacobianUpdate() in EndEffector::setRelativeTransform() instead if that would be preferable.

Yeah, it would be better not only for the preference but also for the performance by not introducing two cascading function call waves (it should be one).


all these need to be updated in Transifex--almost blew the translations away... fixing them now...


Didn't realize it was publicly viewable! Sorry!


is this intentional - singly indented instead of with 2 spaces?


It's on the way, along with miktex & inkscape packages.
That way we can use nbconvert on windows.


ok


Please don't parse the compiler output, it's much more difficult to change this regex than just to update test data when something changes (just dump the output to a .txt file and compare with `assertEqualsToFile`)


Thanks, and you think <.jumbotron><h1> is better than <h1 .jumbotron> as good practice?


one more


@DAB0mB Lets make it clear one more time together. What do you want to add in ng_html_handler.js?
I guess, you want to add the following code
````html
<head>
   <script>
    document.load(function() {
      System.import('client/app')
   })
   </script>
</head>
````
Right? My question is do we need to parse user's index.html to add this code? Why not just add index.html file to this package, thus, keep it simple i.e. avoid parsing anything.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/81991923


So you mean, when working with characters, do a deepEqual to better checking?


sorry test


shouldn't we use the same QucsSettings implementation throughout the whole project?

why not put this code into `QucsSettings::QucsSettings(const sometype& settings)`?


LGTM


@ncw swift/swift.go:406: invalid operation: o.meta_full["X-Object-Manifest"] (type *swift.Metadata does not support indexing)


Ok, my bad :stuck_out_tongue:


Stupid IDE...


How about a test on an `internal` member in a `public` class?


Would a ticket in tracker be better than an email? I'm just wondering if people reading these docs will know who to send the email to.


new comment


I think you're possibly adding this to too many places. Is it necessary everywhere, or is there some minimum number of places where this can be added?


We should not need ARCH_PPC right as this is for zLinux


Convert to maven project


Rename variable names to DATA_FILE_PREFIX & CATEGORY_DATA_FILE_NAME.
OR
Have a single field "CATEGORY_DATA_FILE".


On second thoughts, `metaFull` should probably be just be swift.Headers named `headers`.


I use the px4console to compiler the code , it tell std have no strtoull . how can i fix this problem?


@idgserpro obrigado, não tinha visto.


Support for multi process o: ?!


Or is it copied from somewhere? In that case, please reuse instead of copy


So this should become `o.headers["X-Object-Manifest"]`


unneeded line?


some ppl recommend to always use === when comparing things, specially if could be fals-y


ditto


one more


@ncw when I tried to use one headers object then I had a wrong headers writes (broken headers names, etc)


The scan failed.
Included commits

Commit ID	Owner

9872989bd39d3dd5979d62e853474ea3c26087cf	@BearSpace


Why are these lines changes, we should just be able to have the addition for 390


Note that the mnemonic is 'When applied, this commit will {commit summary}', which means this is 'When applied, this commit will When applied this will create the ChiefAG bio doc.'... :)


Yes for the flash message! Do ya'll want to look into that today or should we handle it?

Good call on the error message, we can build out a test to check for that and fix the bug if you want us to.

closes #15 closes #16


No. I just kept the structure how it was


Grr this was meant for ceylon/ceylon-js#632


align the comment here


fast-forwarding master to auto = 22aa352e


I wrote the recursive code in my standard way (1. Out condition // 2. Rest of code) and then I added the rest of workaround code to make it work hehe, so I never revised.
Now I know you'll be looking to way of doing it simpler.
Thanks :+1:


There wouldn't really be two cascades, because after it cascades once, it will be cut off the second time by the shortcut check. But it would save a virtual function call, which is non-zero overhead.


Works great, thank you.
Fixes those warnings:
```
(mate-appearance-properties:19766): marco-CRITICAL **: meta_gtk_widget_get_font_desc: assertion 'gtk_widget_get_realized (widget)' failed

(mate-appearance-properties:19766): Pango-CRITICAL **: pango_font_description_get_size: assertion 'desc != NULL' failed
```


I suggest that on this pull request we should stick to uploading only and worry about deleting later


there is no need to do aside#notifications, page should have one id with this name to prevent errors


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Aside from all other comments, I think this class deserves another one, on why this stuff is needed at all (i.e. because of a lack of module infrastructure in the compiler)


@mike-north this broke the travis builds with a bizarre error. was trying to get the build passing again and switching from `false` to `null` it worked... jscs docs say otherwise, but alas.


Thank you


It seems I have to revisit falsy values to get its adavantage.
No comments on ```prepend``` refactor :sob:


A simple vector of float seem to be sufficient regarding the next loop and it is not useful to the the index in a Pair like you propose to do.


@fnando is safe when the key and iv are the same?


r+


@McDrakon123  Yes it's. If you use the latest version of Pocketmine-MP such as #32(PocketMine-MP_1.6dev-32_php7_0bcf639a_API-2.0.0.phar)with php5. You will get the notification 'You must use PHP >= 7.0' and 'Please use the installer provided on the homepage'.So I think it have to use php7.


for-loop,method


I don't think so.


Hmmm, shouldn't we leave `id_type` in place for at least one or two releases before removing it?


If the download is interrupted, then the file segments that had unload, will be preserved and will remain in storage space. We must do a good service and experience with our applications, is not it? ;)


what is this path where the uploads are happening? is this fixed always?


inverse <- NULL
set_inver <- function(solve) {
inverse <- solve}
get_inver <- function() inverse

}


remove this commented line


hmm with value gets casted?
Is this behaviour derivated from "falsy" values?


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/37da003c600e29d0e00fc7455f03f6957b2624b2


merging graydon/stellar-core/dh-based-mutual-auth = 37da003c into auto


graydon/stellar-core/dh-based-mutual-auth = 37da003c merged ok, testing candidate = fdf7b073


asdasd


typo


why are you checkin all these entries of infosys etc on git, please make these address etc on the config file and then pass it through the ConfigurationManager settings


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/18419/testReport/) for this commit**


This should not be necessary.  But if you do this then you should also populate the new pid column for previously existing results at upgrade time.

It's an ugly hack but this is not the time to hold up certification. My main question is, who will clean it up later?


Do you also need the equivalent for s390x ?


Coming soon @chrismcv!


as long as your secret key is save, no problem. But you can create your own encryptor and have two different strings for this (maybe passing a string like `key:iv` and splitting in your own encryptor.)


+1
Disclaimer: didn't test and/or have familiarity with gpio.


My fault - the javadoc says that any exceptions that occur while reading the stream are propagated - please re-throw e here.


OUTPUT_DIR and OUTPUT_FILE are variables, not literatls, please concatenate them (I should have been more clear, sorry!)


you should update your production master branch to include this. just an idea.


You're correct! I found that it checks whether it's already dirtied and just returns if so.

Let's save overhead when we can. [Here](https://github.com/dartsim/dart/commit/50e8788b9a987ffd2cdeb5a7d3d2ee8963a863db) I pushed the changes that I'm thinking.


I know I implied that there could be null pointer dereference if tokens is NULL.. but this ternary op looks redundant to me. if tokens is null then this code is not reached.


I thought that in this scenario:
```
var myObject = { 1: "uno"}
myObject.length // returns 1 because size of object is one property
```
Did I just invented this affirmation?


Thanks Nick.  From what I've seen, adding the ContextAware block only allows for one EntityType (yes/no?)

We're evaluating Campus as well as Group, so we've added the Group and Campus context setters to the page, then using this method in our custom block:

var campus = RockPage.GetCurrentContext( campusEntityType ) as Campus;
var group = RockPage.GetCurrentContext( groupEntityType ) as Group;


This should be:
```
hpx::async(action_type(), locality, std::forward<Ts>(vs)...);
```
You can think about this as invoking a member of the locality.


remove this from here and add in config making sure to name it as testendpoint and then use it here


1.顺序按字母排序，如前面字母相同可以按后面字母排序
2.后面带的链接应该指向带有改音标的页面 在此可以是https://en.wikipedia.org/wiki/Git_(software)
我会完善说明的 谢谢


TeamCity DNN JavaScript Libraries :: CI [Build 95](http://teamcity.engagesoftware.com/viewLog.html?buildId=368&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 95](http://teamcity.engagesoftware.com/viewLog.html?buildId=368&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:8


szaf


This is unfortunately necessary for right now.


maybe for readability it is better to have this line before line: 2003?


rax retry tests


You have to upgrade to XCode 7 & iOS 9


@dcs619 yes, I believe that is true. Hmmm...


Good work! Notice time metrics in Linux and Windows are different. See the original project code. Try to guarantee coherence.


What do you propose we call it? The page linked says "This API is often referred to as CommonJ". I guess we could call it "Oracle & IBM"?


Ups, didn't think of that


@cearley Take note of this minor change in the v1 plugin.We want to wrap a try/catch around the code that injects into the pipeline. If there is an error, then we invoke the exceptionHandler on the readstream this ensures that the Channel managing the stream will get the exception. If this happens with this v1 implementation, the entire kafka stream gets shut down. Not ideal for v2, but the v2 changes already deal with this. At least now we'll see these errors and they won't get swallowed. This is the root/root/root/root/root of my debugging over the last day.


Yeah, I know :stuck_out_tongue:


@Tolsi just use `headers *swift.Headers` as the type.

This could replace the use of meta too - there is no need to store the headers and meta since one is easily derived from the other.

Note that meta is a pointer, if it is `nil` it doesn't exist and you need to fetch it. The same would apply to headers.


The four lines "subnets:private"read", "subnets:private:write" , "subnets:shared:read" and "subnets:shared:write" are obsolete and should be removed from the polcy.json.


asdfdsf


asdasdasd


I think it's because when you click the checkbox the browser itself marks it as checked, so you don't actually need to data bind it. Maybe we could just remove this code.


remove this line you do not need a Designer


you can delete this


That way (with recursion) is way better and cleaner than our aproaches (david and me)


delete and see


This line should always be done - it is what creates the fully qualified tag. So, move it about line 16 (the if split_qualified_tags? line).


fixed by #14499


new comment


wrong signature, consider only a set of matches for ONE image-pair


@HAIL9000  you got it right, only one small thing to correct


please give a proper namespace to use instead of using App_GlobalResources


TeamCity pull requests :: netty [Build 277](https://garage.netty.io/teamcity/viewLog.html?buildId=1661&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5603, ignored: 21 Build time: 00:36:24


The TODO's never should have been there. Loc is post-v1, so it's up to you whether you want to use a resx now or not.


:yellow_heart: You should not assume that the `files` argument is of the correct data type.

I'd recommend that you restrict the `readTexts` method to processing JSON data only.


This needs to check if headers is nil, and if so then fetch it.

I would change `readMetadata` to read the headers.

To access a value of a pointer to a map you need to indirect it `(*o.headers)["X-Object-Manifest"`


Have a ruler drawn and do not write code more than 120 words in one line


Please fix the following typos in this commit:
* `realTime` should be `real_time`
* `Theis folder` should be `This folder`
* `THe software` should be `The software`


What if the container doesn't exist? We should probably create it.


Please remove the green code, no need to have the same


:yellow_heart: The variable name `grab` does not tell me what the object does. You could use a more descriptive name or write a comment above it.


Hook to modify notifications? I do not have any case *yet* but maybe it will be nice to override notifications for specific controller, `Hook::exec('actionOverrideControllerNotifcations', array('notifications' => $notifications, 'controller' => $this->context->controller));`


Can't we just skip the extra var? If we're not interested in the return value Q_UNUSED(chown(...)); should be enough.


Collaborator:
Review for this commit was created. [Link to review](http://localhost:8080/ui#review:id=2042)


![rjmre](https://cloud.githubusercontent.com/assets/5313226/10079321/a41f0ad6-62e9-11e5-82c2-8752181651fd.jpg)

"don't do [] and then array.push(val) => [val]"   :+1:


This should probably be `isManifestFile` so it isn't exported.


I think you can do this without code by changing the shortcuts associated with an extension in the bottom right corner:

![screen shot 2015-09-24 at 09 25 13](https://cloud.githubusercontent.com/assets/1192590/10079335/49908e3c-629e-11e5-906c-adc23db12d2a.png)


We can actually just leave this at any arbitrary version--it is never used since we'll never publish this test/CI-only npm package.


I'd actually like to do some git spelunking to figure out what component actually cares about these whitespace mungings, and move them there. Cuz html don't care. Maybe iCal cares?


Corrigé pour moi.


This information is also already included in the five lines above this in the readme. Did we really need to add it again?


Some sort of troll-defensive code for myself


Good stuff :+1:


Yes, 0 == '0' and 0 !== '0'. Look here: https://jsfiddle.net/aqs87s95/

It's not related to falsy values, 1 == '1'.

== is bad for strict comparison because it tries to cast the values to the same type and causes strange situation. That's why === is preferred. === is not a deep equals, just a 'same-class' equals.


No, to maintain back-compat you have to actually replace the MQ.  It's observable in the OM.


You should never catch "Exception". Try to catch as specific exception as possible.

There could be IOException while trying to read the file. Why would you fallback to "en" in that case ?


break after default


Yes, invented: https://jsfiddle.net/23srLcvd/


exit here


Are you sure.
I am looking into table into production and fields exists. And more, field is a not null field, so i got error saying can't insert into table if you remove this field ?


dsds


@nairdo @azturner We've added a cookie method to the ContextSetter blocks to check for the existence of a query string (see #1253).  PR forthcoming


inverse <- x$get_inver()\
if(!is.null(inverse)) {
message("Getting the cache data")
return(inverse)
}
data <- x$get()
inverse <- solve(data, ...)
x$set_inver(inverse)
inverse


It's because you update your own master and now it's diverged from the upstream.  You really shouldn't do this unless you want to have to deal with messy merges all of the time.

The right way to support an upstream project is to leave master alone.  Create branches for each of the features you want to add.  Whenever upstream is updated, you can pull master down and rebase all of your branches, squashing conflicts as they arise.

To give a real use case here, say you want to help work on the refactor branch.  You'll fetch from upstream, and then make a new branch from the upstream refactor branch.

Assuming your master branch hasn't diverged from upstream (you haven't committed any of your own changes to master), it basically goes like this:

% git fetch upstream
% git checkout master
% git pull upstream master
% git checkout -b myrefactor upstream/refactor

You'll now have your own branch sitting off of my refactor branch (called 'myrefactor').  You can make commits to this branch, and then push them to 'origin' (your fork):

% git push origin myrefactor:myrefactor

I can then merge your changes into my 'refactor' branch.

If we both make commits around the same time, you have to respect upstream and rebase your branch before your push:

% git checkout myrefactor
% git fetch upstream
% git rebase upstream/refactor

Resolve conflicts, and then push to your branch on your fork:

% git push origin myrefactor:myrefactor

If you're working on a branch by yourself (i.e., not branching off an upstream branch, but branched off of upstream master), it's basically the same process, but you'd rebase against master.  Since your own master should be pristine, you can pull in upstream master to your local copy and rebase against your local master:

% git checkout master
% git pull upstream master
% git checkout mycoolbranchivebeenworkingon
% git rebase master
% git push origin mycoolbranchivebeenworkingon:mycoolbranchivebeenworkingon

You'd essentially do that any time you want to push anything up for a pull request.  If enough time goes by before I get around to your PR, I may ask you to repeat the above.

If you have any questions, just ask.  I know git takes a bit to wrap your head around, but the general rule of thumb is, make branches and make them often.  They're cheap (quick) in git and is generally the right way to start working on anything.


Ohhhhh - this is a side effect of a last-minute change I made in 1.2 that I for some reason didn't think could change anything. My mistake, we'll fix this in 1.2.0.2.


:+1:  If I'm honest I don't know why I did that


what if args[0] is string or float


But then you loose the benefit of the `currency` modifier, which is to print prices according to the chosen locale.


Heh I don't blame you. I'm actually a little uneasy about this method extraction, as well. Because it feels like I'm monkeypatching a core type, even though I'm not, technically.


s/inseted/inserted/
@sbeaver-netgate  I don't think you caught this one yet.


throw UnexpectedServerException after logging.


add try catch for IOException


use a python `set`


:red_circle: The `createIndex` method is being called by an instance of the `Index` prototype. This means that the instance also has the `readTexts` method. In the `createIndex` method, the instance should be referenced via the `this` keyword.

You should use `this` when calling the `readTexts` method as it ensures the `readText` method will be called from the same instance.


you should use a dict here


not used debug


Instead of hard-coding "en", use Language.ENGLISH.getCode()


a function called `get_foo` should return foo


Just saw that there's a dupliction https://github.com/xbmc/xbmc/blob/master/xbmc/GUIInfoManager.cpp#L1673

Maybe it's better to remove the block here an don't rearrange things?


Hi, thanks, just added few comments


Throw UnexpectedServerException after logging.


:green_heart: This is an excellent comment. You could use the `docblockr` extension in Atom to help provide a library-style comment for the method. Look up `Docblockr` for Atom.


ideally this would allow for new users


nice check


Thanks Master Namer


hmm, we have an issue here, this breaks on 5.4 as I intentionally haven't back ported DOMDocument change there.


Line 4 [link ](https://github.com/Whats4Dinner/JavascriptDonuts/commit/8224d4bc86aa5f6d5f1246592d815e72d0d8906a)


dmidecode to 5.4 version will be a greate tool for hardware inventory


you can use a `Counter` here

E.g., `self.users_called[user] += 1` (defaults to 0 if user doesn't exist)


You are first appending and then splitting it again. You could have used a different data structure or used the same while loop (instead of two).


Uff this one-line / two-inline-boolean check is not easy to read at first sight, at least for me


Also, if you're nervous doing this before I've pulled all of your changes in, you can just temporarily make a new fork just to work on the refactor stuff for now, and delete it when we're done.


Im aktuellen Master lässt sich meine aktuelle Lösung incl. Bendiness "bewundern". Ist noch nicht perfekt. Das Ergebnis sieht ganz gut aus. Code Qualität ist noch relativ Prototypisch :D. Ich route jetzt auf jeden Fall fast nicht mehr über Autobahnen. Nehme ganz nette Sträßchen. Hier und da verpasse ich noch eine schöne Abzweigung.

Komischerweiße kommt bei mir manchmal raus, dass eine Straße kürzer ist als die Luftlinie zwischen den beiden Knoten. Keine Ahnung ob ich die Distanz richtig berechne?

>Also ich würde bendiness sowieso immer mit dem original 'weight' multiplizieren, und das original weight macht ja time=distance/speed d.h. man braucht eigentlich speed un distance nicht mehr nur noch luftliniendistanz

Das habe ich jetzt etwas anderst gelöst. Ich habe mir noch dieses klasische Weighting ausgerechnet, aber die Geschwindigkeit deutlich weniger gewichtet:
`roadLength / Math.log10(speed/2);`
Das ganze Multipliziere ich jetzt mit der Bendiness:
`distance / roadLength`  <--- Distance ist hier Luftlinie
Die Bendiness quadriere ich noch um diese stärker zu bewerten. Naja hier muss man noch an den Parametern optimieren.

@karussell
Wie ist eigentlich der Entwicklungsworkflow? Aktuell benütze ich die graphhopper.sh um das Projekt zu bauen. Diese braucht auf meinem Rechner aber schon ein bisschen zum Starten. Insbesondere, wenn man nur einen Parameter ändert und dann testen will ist das etwas kompliziert. Gibt es hier einen besseren Weg? Z.B. Hotdeploy, Debugging aus der IDE etc?


@Moser2010  In quicksort, remember to slice your array so you have a copy to work with. There are lots of ways to do it, but one way is to take your pivot and then put all the elements less than it into the left array and everything greater than it in the right array. Then call quicksort on both of those arrays and concatenate the results into a single array that you return.


sounds good.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/81996289


The title of this section is "Adding users (lab admins)". Do you think we need to clarify what that means? Any suggestions?


comment line 7


Yes, I agree. I tried a solution based on multiplying the sign of the step but it was too complex. But 2 loops doing the same is strange.


Dangit.


This needs to be removed as well.


:yellow_heart: You need to remove the debugging statements from the code.


honestly I don't know what should be correct organization as that library implementation is joined result of both these organizations. But I would say Commonj is not an organization ;). Could we have there CommonJ framework even it is not organization?


This block would read more concisely un-nested as:
```
if {...}
else if {...}
else {...}
```


Needed to merge the remote changes for the git push to work.


Yeah, I was considering that. I think I'll make that change.


common comment


I think I should read more about this, because I don't get clear when is recommended to use == and when ===


Good call, I'll fix it.


This is just a human readable description. I think that whatever name allows the user to understand the provenance is good enough.

This is one of the reasons that we changed the name away from "Vendor" to "Organization" though. It is hard to come up with a good term to describe the thing that originated this source code for all cases.


if(input.length != 2 && input.length > 0) dont quite understand the logic here


:red_circle: The `beforeEach` each declaration should be used only within test suites (`describe` blocks).


add exit pls


For example, farther down, you see organizations like "HypersonicDB" and "Sourceforge".


Not sure I completely understand what is not working, but don't both the campus and group contextsetter blocks already have methods to save a cookie value specific to the page or site? Which is then available to any block?


Intentare enviarles un ejercicio para que tally lo haga y nos explique


:yellow_heart: This is a nitpick.

`toBeTruthy` is the more semantic way of writing `toBe(true)`


fast-forwarding master to auto = fdf7b073


Ok, so === checks not only if  "values" are equal, but if both parts of comparison are from the same class.
Right?


Thanks for the input. If I knew what they were specifically trying to do, I
could probably help to avoid this. If this goes in, though, remember to
also update the database.sql file.

On Thu, Sep 24, 2015 at 9:16 AM, Rod Roark <notifications@github.com> wrote:

> This should not be necessary. But if you do this then you should also
> populate the new pid column for previously existing results at upgrade time.
>
> It's an ugly hack but this is not the time to hold up certification. My
> main question is, who will clean it up later?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ensoftek/openemr/commit/8c3936b030c1414b471e0acbbc5c4d9181f592a4#commitcomment-13419149>
> .
>


imo player title and videoplayer title are different, or aren't they?


This is defined twice. I recommend going with the "rule:admin_only". Delete the other one.


Any reason to not make this a synchronous function? It doesn't do anything asynchronously inside - it should just be setting a variable.


I Disagree


I DON"T LIKE


My attempt at Lazy SMP for Stockfish. This implementation starts all threads immediately but uses an "additionalDepth" variable to set a different target depth for each thread. Some results for different values are below. The main thread is used for sending moves to the GUI.
MultiPV is disabled, because it kept crashing for some reason. Also, I'm not sure if Skill works properly, have not tested.

During development and testing I used this version: https://github.com/official-stockfish/Stockfish/commit/7f300a769848c695fb28da444b0c3f4c1d919945

Local testresults vs "normal smp", Conditions were 3 threads, 15+0.06 (close to 12+0.05 fishtest time):

  th->additionalDepth = (Depth)th->idx;
	Score of dev vs base: 120 - 165 - 575  [0.474] 860
	ELO difference: -18

  th->additionalDepth = (Depth)th->idx/2;
	Score of dev vs base: 107 - 299 - 622  [0.407] 1028
	ELO difference: -66

  th->additionalDepth = (Depth)th->idx + (Depth)1;
	Score of dev vs base: 203 - 271 - 925  [0.476] 1399
	ELO difference: -17

I have now merged my changes with a newer version of master and have tested with some 2+0.05 games to make sure the engine doesn't crash or hang.
     Score of dev vs base: 48 - 78 - 148  [0.445] 274
     ELO difference: -38

This is my first attempt at understanding threads and mutexes in c++, and also the first attempt at SMP. I'm sure the implementation is not optimal.


se usa la libreria CustomStepper y se agrega uso de un laser en el pin 6 al momento de finalizar el apunte, se trabaja automaticamente.


`np.zeros(len(hotels))`


I am unable to compile tests at the moment :(


@Student007 I don't quite understand what you are doing here. If the `TESSEL_AUTH_KEY` is, for example, `~/.tessel/id_rsa`, you will be `exec`ing `cp ~/.tessel/id_rsa~/.tessel/id_rsa.pub`


Yes, == tries to cast. === compares that the value and the type are the same.

== is dangerous with truth-y/fals-y values, look for example: true == 1 (!!!!)


Decided not to use that because the migration should be self-contained and in the future we may change `MissingTitle.for_title_field`


@agocke agree it's not available but my expectation is on CoreCLR it just returns `null` as this change does.


ok


The easiest way is to have two for loops. You can guarantee any single dimensional array will be sorted by passing through the array n times, n in this case being the length of the array. So your current for loop looks fine and the logic inside should be ok too, but you're only passing through the array once. You need that loop to be inside another loops that continues until the array is sorted.


I agree that this method could have a more accurate name like `hasProvisioned` or something.


ups ;)


:yellow_heart: It is recommended to use the index lookup method to check the value stored in an attribute if the attribute is a string. For example:

```javascript
expect(indexRunner['into']).toEqual([1]);
```

The reason you should do this is to cover for the possibility of the string representing an invalid variable name.


if an error occurs its better to reject the promise so whatever is calling the promise can handle errors properly.


>> What does order_by('id') do here? If you're doing it in this order to process parents before children then you should add a comment about this.

Will do

>> Also, what if the command fails halfway through? Is it possible to wrap this in a transaction?

I do not think it is a problem because the update of a description path is idempotent as long as the title does not change.


FWIW, I think this command is super weird :smile:


@kblees could you have a quick look to ensure I don't do anything utterly stupid?


yep, still better to reject when an error occurs.


By 'adding index.html file to this package' I meant
````
api.addFiles('index.html')
````


Confundes tareas con subobjetivos. Voy a comentar sobre el texto. Por lo pronto, no cierres.


Hi, @cyberium
I feel the old loot system work fine on this point. When npc died we get a initial timer on Unit::SetDeathState(). After we looted, the timer will be set as (m_respawntime / 3). After corpse skinned, the timer will be 0.
Anyway, there is another issue.Changing the loot method after the npc died will not work. For example, if loot method is free loot before npc's death. Then we kill it and then change the loot method to "master give", the actual effect of method is still free loot.


Cool.  That way we're all bound to see it, emails get lost easily.


### What does it do ?
i added some rows of code in the file /manager/assets/modext/widgets/resource/modx.tree.resource.js, that disable recycle bin icon and set correct tooltip.

### Why is it needed?
In the resource tree panel, after empty Trash action the icon is still available and shows wrong description.

### Related issue(s)/PR(s)
No.


@Student007 I think this is headed in the right direction. I would make `setDefaultKey` to be synchronous because there are no async operations inside of it.


I would say - use resx even if we won't localize this in v1


Hmm, maybe a section defining our different levels of access?  Isn't that just: lab user (internal), lab user (community) and admin user?


why GRAPH_API_URL ? why not GRAPH_API_2p2_URL or GRAPH_API_2p4_URL ??


Good to hear! The cat error I'm not going to address right now since recovery methods are unique depending on what browser/tool you're using. It'll just stay as a shortcoming of this tool for now... ;;


I can dig it.


Merge


@bgoodri Before this commit, a model like

    stan_lmer(mpg ~ wt + (1|cyl) + (1|gear))

will include parameters

`b[(Intercept) 4] b[(Intercept) 6] b[(Intercept) 8] b[(Intercept) 3] b[(Intercept) 4] b[(Intercept) 5]`

without it being clear that the first three are for `cyl` and the second three for `gear`. In fact the `b[(Intercept) 4]` for `gear` won't even be included by the `print` method because the `print` method uses `setdiff` to remove `'log-posterior'` and that will only retain one of the `b[(Intercept) 4]` parameters (in this case the one for `cyl` because it's first).

With this commit these names are now

`b[(Intercept) cyl4] b[(Intercept) cyl6] b[(Intercept) cyl8] b[(Intercept) gear3] b[(Intercept) gear4] b[(Intercept) gear5]`

I'm not sure that this is the best way to format the names, but we should at least have the names of the variables somewhere.


Consider making it the responsibility of `IsPrime(...)` to take care of the `number = 1` case. '1' isn't a prime after all :wink:


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 708](https://teamcity.labkey.org/viewLog.html?buildId=274011&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 34, passed: 9 Build time: 00:25:41
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

##### there are 24 more failed tests, see build details
```


Why are we commenting on commits? Please comment on PRs instead. Almost impossible to follow threads here...


Oops.


I'll do some more investigation here, as well. Who actually is passing an Array to `Event#start_time`? Maybe we can move this knowledge to that component, etc. Who knows, it might even turn out that nobody is. ;)


Ok, I just saw my TODO in code. About this:
   //       Do we end up using use more and more memory??
The answer is, not according to ksysguard. Memory usage was the same after 1000 games.


wrap it in int64ToIntS() to avoid truncation warnings


Thank you Russell
It works like a charm!!!
now no mather if the video is taken landscape or portrait the thumbnail is set correctly
Tested in iOS 9.0 with iPhone 5s


I guess there isn't a way to support both the HTTP Fetcher and Session fetcher, the spec has to pick one, and support it?  Because ideally it would be better to let the developer pick based on their min os version or other dependencies in their app.


I agree, I'll fix it.


Take a look at [meteor-angular-socially's index.html](https://github.com/Urigo/meteor-angular-socially/blob/master/client/index.html). It seems very complicated. How are you planning to implement this with Meteor-Angular2 if you want to omit the index file? I think we need to have a base index.html in our compilers, and then add custom html contents defined by user.


Ah, this explains the failure I was getting on `invenio-grobid`: https://travis-ci.org/inspirehep/invenio-grobid/jobs/81371136...


I believe the `identifier` here must be different to the `identifier` of the preceding line, else the `versionIdentifier` will never be considered.


``from monrsa.crypto import _serialize, _unserialize``   ?

Mais a priori tu ne les utilise pas par la suite :s


you can also do:
`var stack = error && error.stack || req.response.stack;`


these calculations can theoretically overflow as you need a total of 31+61+8 (100) bits intermediate values. probably won't happen very often but would be nice to keep it in mind somehow


Replace method with `return reference.endsWith(".2bit")`


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 22](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=195&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


* Replace `$prerender` with `$render` because it's not used anymore.
* Spelling fixed in duplicate quote query
* Moved `menu.php` include to proper location


You mean tables or columns? Because table name is provided as parameter so it is not hardcoded.


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 22](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=195&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **SUCCESS**
Summary: Running Build time: 00:00:44


My idea was to adjust the results to respect the requested category representation


Remove this and add a short class description.


Commit all the binaries!


In the future, feel free to make all the imports on the same line.  We're following that trend for the entire project.

<organization


@azturner Both of those blocks do, but the cookie is set when you make a selection from the dropdown, and a page refresh is needed to update the context based on the cookie.  So when you add a query string to the url like ?groupId=XXXX the page context doesn't update until you set the new cookie and refresh the page again.  So the solution that we have working in develop right now set's a cookie value based on a groupId query string value if it exists, and checks if the cookie is either null or has a different value from the current groupId query string, if that passes as true, it then sets the new cookie, and context cookie, then refreshes the page.  All of this happens on init so we are catching it very early on in the process of loading the page so it doesn't extend the page loading time too drastically.


Duplicated method.


ack


@stuartwdouglas

Thanks for the update, I haven't tested it yet, but glancing at the code the following may still be problematic:

    if(isValid == null) {
        isValid = createJASPIAuthenticationManager().isValid(messageInfo, new Subject(), JASPI_HTTP_SERVLET_LAYER, attachment.getApplicationIdentifier(), new JBossCallbackHandler());
    }

The problem is that this will likely never be null when request#authenticate is called for this first time. The SAM will always be automatically called at the start of the request, and therefor will always set the "valid" property.

If I'm not mistaken org.wildfly.extension.undertow.security.jaspi.JASPIAuthenticationMechanism will only be called following a call to request#authenticate (and not automatically at the start of the request), so therefore the first call to request#authenticate will always find a non-null here and will not work.


@thomasvl You could put each behind a subspec, such as `gtm-oauth2/http-fetcher` and `gtm-oauth2/session-fetcher`, and then have the default subspec be the preferred integration (session-fetcher). Then in each subspec add a preprocessor definition which would choose the appropriate code path within gtm-oauth2 for the chosen dependency.


That's an odd coincidence! Two fixes of the same bug posted with 18 minute interval...


@DAB0mB How do I want implement what?


This needs to be fixed properly (in another issue is OK).


TDD! :smiley:


you need to count categories after ranking and truncating.  Otherwise you'll end up with the same category_counts every time, even if all the results returned are in a single category.


not `BaseException`?


The reaction I just fixed was the only reaction in the CoreModelTemplate that was unbalanced. The protonation and/or charge of the ferridoxins could have been adjusted, but this would have had a knock-on effect on the ~150 reactions that utilize the same compounds.

A summary of the remaining unbalanced reactions in the other templates:
      4 GramNeg CPDFORMERROR
      5 GramNeg CI | MI
     10 GramPos CI
     88 GramNeg CI


@mourner just sort of a disclaimer like:

> Takes a Feature and a bbox and clips the feature to the bbox using [lineclip](https://github.com/mapbox/lineclip). May result in degenerate edges when clipping Polygons

?

Should we link to something that describes what degenerate edges are? Like this:

![](http://1.bp.blogspot.com/-fZ_UJe7aP6g/UrF8DyBeEaI/AAAAAAAAApQ/uJJyhcEh4aU/s1600/sutherland.png)


super ! vdaka


FWIW? That remark is worth zero :smile:


This is very true. I blame it on Photos.app because I couldn't deal with finding one in there and used this one to be a place holder. _sigh_


Question (for my education).  Is it necessary to include the version both times?  If we left off the version under "extension" would it just use the version from the dependency?


if `fgets()` fails `linebuf` might be uninitialized.  Either check the return value or initialize `linebuf = {0}` (or equivalent).


:heart:


ack


good catch


This filtering step that we added in our branch should be restored.


LGTM


ok sorry lets go through this again, you don't want me to add a `<app>` tag to the body, it means the user needs to define it manually. If so, how are you planning the index.html file to not be required by the user?


Looks good. There are a few minor things to fix, then I think it can go in (after #911).


fix #1.


If you meant implementing this file, not sure how doesn't it relate to importing 'client/app'? that's the only reason as I see you parse index.html in the processIndex.


__mul__ now checks for vector or scalar as the multiplier. Also changed magnitude to use dot product.


Solucionado el problema, aparte se ejecutara automatica mente el main()
Nota: Para poder acceder el archivo primero guardarlo en la carpeta de python27 luego acceder a la consola con el sigueinte comando: from Ejercicio12P import*


Such an apropos commit message to start this app. Installing it now. :smile::beers:


So could you tell me the reason why you split index.html into the head and body and then re-add them to two other files?


and suddenly it is not passing LTC anymore


I'm unsure that adding additional inheritance complexity to save ~2 lines of code in other files is something we want to do. Especially considering once transpiled it adds 2-3 lines of code to import the type in each file, as well as 3-4 lines of code to export the type from it's own file, and then all additional transpiled module magic in the global output. There's also an additional `super()` call for each inherited class upon creation, as well as class assertions.

... I guess I'm saying I don't think we need this.


Is pointer needed here, or is it getting overwritten by hand?


To make this clearer, it could just be `Observable.never()`, also the test name should reflect that it's testing `never`.


why is this `lib_major()` and not `major()`


can we move `Observable.empty()` up above the `expected` var like in other tests?

```
var e1 = Observable.empty();
var expected = '(x|)';
```


this and your other comments here are addressed in bf5c194


Sure, that's fine.


Got point. I also had bit doubt since code is small and it introduces another inheritances. I'll clear up changes by removing it.


Sure, will do.


This change shows dynamically all supported SASL mechanisms available for client to choose from. It's been suggested (by lavrin) to create atom dictionary in escalus and not to use binary-to-atom conversions. But this is a syntetic test so why not...?


So there are two types of error tests to add:  "error" and "throw"... the difference is subtle:

```
// error
"---a---b---#"

// throw
Observable.throw('bad');
```

We should test both, and the names of those tests should reflect that it's testing either "throw" or "error". Does that make sense?


Hi-

OK - I think I got it this time ;)

Thanks-

Daryl


I read that different browsers use different names, so you need both.

On Thu, Sep 24, 2015 at 10:06 AM Kamerynn Harrah <notifications@github.com>
wrote:

> Is pointer needed here, or is it getting overwritten by hand?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hmfoster/Otto/commit/cb3c1f3fb518a6783bf3d7d0285af894b6f2b3ad#commitcomment-13420229>
> .
>


@stuartwdouglas

At a closer look (still not actually tested), but the code as it's now likely never works.

Since attachment.getValid() returns a boolean, it can never be null. Therefore the following can not be true in any situation:

    if(isValid == null)

Additionally, it will almost surely throw a NPE the second time request#authenticate is called, since a null will be attempted to be unboxed to a boolean.


Oops, realized I was commenting on an "error thrown in predicate" test... So not *quite* applicable here, but still generally applicable.


change to the last argument seem good indeed.  Was it like that before only because it used to pass `plugin->cb_data` and update was missed, or was there another reason?


Hmm, I don't know xD.


No it's a mistake I need to fix, they are actually just html contents which are appended to the dom, they are not files and they are not restored anywhere, I need to remove this. I splitted them so if you define an index.html like so:

```html
<head>
  ...
</head>
<body>
  ...
</body>
```

The head tag will be appended to the head section and the body tag would be appended to the body section, it gives you more flexibility.

An addition, I want the following tags to be appended to the dom:

```html
<head>
   <script>
    document.load(function() {
      System.import('client/app')
   })
   </script>
</head>
<body>
  <app></app>
</body>
```


this doesn't work if hotel_temp is an object or a dict... you need to do `output_hotels.append(hotel_temp)`


Parece muito bom, mas talvez antes de dar merge podemos tirar os testes do script_bb ou talvez mover para outro arquivo?


@DAB0mB Yes, but why should it be called index.html? it could be app.html or nameofmyapp.html or wharever.
We'll just mention this in the tutorial like this "please create file whatever.html with content as follows <body><app></app></body>".


Este cambio causa un error por referencia durante la activación del captcha en el login (fallar un login para que se muestre el captcha) adjunto imagen

![captura de pantalla de 2015-09-24 12 11 10](https://cloud.githubusercontent.com/assets/12191804/10080466/6b4823ac-62b5-11e5-801d-2f8032b621e9.png)


Excellent!


Warum hast du das hier entfernt?


I'd add `("Unsupported OS variant: %s.\n Supported variants: %s" % (params.get('os_variant'), os_text)`. It helps people to understand from where the judgment came from.


Committing directly to master *and* adding a "fixed cast" change? Tut tut :P


Le minimum requis pour pouvoir soumettre et valider l'exercice


hotel_temp and score_temp are lists... this is not clear from their names


Yeah. Though it enables implicit conversions.


I didn't , but it doesn't mean that we have to set it to 'false'


FYI: this change as well as the others below should have been in a separate commit,

this one is named "Remove irrelevant files" and these are not such a change.. ;)


lol, oops


ack


When I format a price according to the chosen locale, but than put a currency sign from a different locale infront of it, isn't that like pushing squares throught round holes? I thought a currency should be displayed the way it is formatted in its origin locale. And if you mix up multiple different currencies in one table on a page, you probably want them to be formatted all the same. That's why I thought the decimal formatter would be fine for that. But I think I understand what you mean. You want any currency formatted according to the chosen locale (with different symbol) and not from its origin locale. Is that "allowed" in the ICU formatting rules?


I like that :)


new-feature-doc-fix (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


why are maintaining self.preferred_categories?


I think it is worth using access: [USER_ROLES.superuser] for this url.
Let's discuss if you have any concerns.


Cool! :+1:
by the way, "Add an Input Layout" button is not reachable in landscape mode in current upstream master.


I think "consists" was better (the 3rd word in the sentence).  but that would need @elextr checking :)


This seems like it could potentially confuse, as I would not expect a transform that adds data to each read to filter some out.  This operation feels like it should act more like an OUTER JOIN.  Or perhaps demand mapped reads?


Hello?


A new package needs to be checked out!


We have a directive 'access' to hide and show functionality for different roles. Please use it.
If you have any concerns about using 'access' directive, please let me know.


this is at least 20% faster


I think we can use 'access:' parameter here


Agreed. May as well get to the point where all we need are the translations.


в строках `apiCommand = 6` и `apiAddr = '/api/noolite'` нет операций, кроме операций присваивания, поэтому эти значения лучше вынести непосредственно в вызов getJSON


This is not the correct place, the operator is not created here, so why adding this here?.


I would say not. Especially since this is shared source.


@DAB0mB Before Meteor 1.2, Meteor itself collected all headers and bodies across files and added them into one header and body. Does it change in Meteor 1.2?