There's no need to construct a string here, because `getName()` returns an InternedString (pretty much equivalent to OIIO::ustring if you're familiar with that). InternedStrings are really fast to copy and compare for equality and have a `const std::string &string()` method too, so you'd never want to make a string from one.

But, regardless of that, I think it's far better to avoid using names of any form in the logic below, since we can use the ImagePlug child accessors for better run-time performance and also to get some nice compile-time checking.


Levels not implemented


Naming of variables and classes is not according to PEP-8 standards.


Uncomment. As for u2020 forerunner we should have the same features. Maybe even switch from imgur to github API as an example


Very good consideration. No idea if this can be done to OS X, too? It would be great to be able to forget about this...


docstring missing for all Classes


After thinking your next comment through I am wondering if we shouldn't actually use an hash of the BID assertion directly because otherwise we won't validate the BrowserID assertion when reading credentials from the cache.


Methods defined do not have docstring with them


Probably MTWRFSU, but the more I think about it the less I like moving from the bit fields.


wondering if thread.messages could be a Set ?


Many variables are unused. (Total 6)


This is interesting, shouldn't the tokenserver do that in that case? (settings by default the credentials duration to the BID ttl?)
Also this remains me that we could ask a sync with a wrong BID and a valid Client-State and get the cached credentials. I have opened issue #31 for that.


That is what I am after. Cause as you see from github profile I am one of the authors of kodi's VAAPI implementation. We got HEVC 8 bit implemented recently and now try to get a working "driver / hybrid solution" to also do 10 bit HEVC which will be used as DVB-S / DVB-C future content and also as the default format for UHD content.

We are already in contact with Sean of your (?) team and hope to find a solution here. When I saw that you already used HEVC10 in your libyami code I thought a new driver release will be upcoming.

Thanks much again
Peter


Really good point, I have opened #30 for this.


Inherited things not required, improper inheritance.


I don't know where and how did you search, but first Task in our list, `grunt-autoprefixer` does it.

It can happen if you've done typo in `src` path. That message will help you to understand where problem comes from


I wrote the above thinking that this should just be `input == inputImage->sampleOffsetsPlug()`, but now I'm confused. Won't this have already been done by the `outputs.push_back( outPlug()->getChild<ValuePlug>( inputName ) )` above?


Should remove the actual method as well.


I did not do much yet :)
I didn't try the volume slider yet.

--
Debüt album TRUTH / LIES out NOW!
http://www.despite.rocks/

On Sun, Sep 27, 2015 at 8:49 PM, LordMyschkin <notifications@github.com>
wrote:

> I love your work - thanks.
> the localvolumeslider does not work - @parabelboi
> <https://github.com/parabelboi> had it removed in the version i used to
> run.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SuperBFG7/ympd/commit/cb82047228d891095e6575e2b63ea71b3830bac0#commitcomment-13458148>
> .
>


Oh, you are right. I didn't think about that. Thanks!


FunctionalIterable* Iterable*


we don't really need the actual ids, we merely need a boolean "hasDeletedSomeMessages"; maybe using a reduce with a boolean as value could be as good here. But this is really a nit, please keep filter if you prefer.


static size_t OnWriteData(void* buffer, size_t size, size_t nmemb, void* lpVoid)
{
    std::string* str = dynamic_cast<std::string*>((std::string *)lpVoid);
    if( NULL == str || NULL == buffer )
    {
        return -1;
    }

    char* pData = (char*)buffer;
    str->append(pData, size * nmemb);
    printf("%s", str->c_str());
    return nmemb;
}


No wait, I get it. Sorry! But I still think we should ditch the usage of the name, and compare against `inputImage->channelOffsetsPlug()` for the reasons I stated above.


Thanks Sir,
why that error is coming in eclipse 3.8  in lwm2mclient.c
![client](https://cloud.githubusercontent.com/assets/14104387/10135907/110a3abc-660f-11e5-88dd-716829678c69.png)

and lwm2mserver.c
![server](https://cloud.githubusercontent.com/assets/14104387/10135915/2401697e-660f-11e5-85cf-a5d58b88cfd0.png)


Thank you.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.626](http://teamcity.monogame.net/viewLog.html?buildId=10351&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:20:03


Yup - I thought I'd caught all of the Merge comments, but this one slipped through the net.


Missing doc-strings.


BUG found : fireballs not falling down the stairs and also from plateforms instead going in air.


Since we aim to remove this method, it seems a pity to introduce another thing relying on it. Any reason we couldn't implement things without it? Presumably it'll mean a bit more work to do a perfect (equal hashes) pass-through in the hash* and compute* methods, but nothing impossible I would have thought....


tests have to be run; let us know when you finish.


It seems it only is used on card elements in material design lite. But it is meant for use on other types of elements according to the original [intention](https://github.com/google/material-design-lite/tree/dc9276439dcbf5662d1c01c4ff824b5b3cd5a8ed/src/shadow).

I'll remove it from this branch and add it in a separate pr.


To be honest, I'd preferred to know if Task iterates over non-existing files, since sometimes it may be unclear why it does nothing.

However, to do it we have to make additional loop through `file.origin.src`, which probably won't worth it


Yup - I get it - will do.


Movement of fireballs is hardcode. No random movement of fireballs


No problem.


Ah. Late night coding error. Thanx. Will fix.


Bad whitespaces. (PEP-8 standards)


@flavour could not get you here...
single instance: s3task = current.s3task. Where should I create this?

The "sync_synchronize" requires repository_id https://github.com/flavour/eden/blob/master/models/tasks.py#L618 (for each repo this should be called?)


Now it's fine for me. Thanks for the explanation!


can't say that `cyan` looks better for me, since it not obvious where it comes from. In such case it should be named as `chalkkCyan`. I'd stay with `chalk.cyan`


done


After winning the game i.e after taking queen, game ends automatically.


Levels not implemented.


This is the wrong requirements file, I think.  This stuff gets installed in developer environments.  You want `requirements.txt`, which defines what's required to run the software.


@fmikulasch


I've removed this whitespace change from the commit and regenerated the checksums accordingly in my local version of the branch.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 22](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=224&buildTypeId=XbimEssentials_XbimEssentials) is now running


Why was this change made?  This doesn't make any sense.  Now you can't set a data context around a `#ionTab` component and have the route set correctly by iron router.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 22](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=224&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:00:46


`image.full_name` might be better than `repr` here.  The "full name" format is unambiguous and also the de facto standard for string representation of image names.

My ideal representation would be something more like `image.items()` but I'm not sure Eliot lets you serialize fields to anything except a string.


Code Smell: DuplicatedCode, can be used one import statement instead of many, Should avoided to maintain code size.


    = {
        DBIO.sequence(elems.map(save))
    }


I must agree that probably it didn't worked as I expected. I've wanted to explain some tricky or non-obvious places and make clear what and why happens in code. I propose to make separate PR afterward with fixes to those comments


Code Smell: Modularity not implemented


Probably worth keeping this `100` in mind for future performance tuning.  We probably want the maximum cache size to be right around the total number of images that are frequently used for containers on a single node.  If that number is much less than 100, I doubt having a cache size of 100 will make any noticable difference (it's a small amount of memory to waste).  If that number is larger than 100 (or whatever we pick), there's a chance we'll have constant evictions that will negate the performance benefits of a cache.

This is something to tune later on when we have more information, though, just wanted to make a note of it now.


BUG found : player is climbing when there are no stairs in path,when the position of player is above just above the stairs.


Let's use `ImageAlgo::empty( validBound )` here, to make the meaning clearer, and avoid any "now then, does that Imath method do what we expect taking into account our conventions?" doubts.


ERROR: The following variable contains invalid characters: Patient ID card

Why does a space cause an error?


For the same reason as below, let's use `ImageAlgo::intersection()` here.


`image` is a unicode ID in the callable here though, as things stand atm.


new_list[i + 1]はnew_list[i]に統一したほうがいいです。このままだとセットされないnew_listの要素が存在することがでてきます。


like `static const int SOLUTION = 42;`


This reads a bit more like the description for the `image` field than for the `LOG_CACHED_IMAGE` message.  Reading the code, this log message is for the cache hit case.  So I'd say "An image was retrieved from the cache.".


in fact, it helps to avoid unneeded checks, so I  don't see problems with additional `if` block.

It also more logical then present check for `preprocessData` and suddenly not presented for cloning loop


BUG : player is passing through the plateform not collecting coins and when hit by a fireball it does not loss any life or blood or something.


You don't need to instantiate the class as it's done already the one & only time needed, here:
https://github.com/flavour/eden/blob/master/models/tasks.py#L658


`original_list[c4] == c2`なので、これは要らないのでは?(`c5`も同様)


This is just ugly, especially since you recalculate it again right below this. `labelNum` should be the current one, not the previous one!


Code Smell: Classes with too much code, can be refactored by making new classes.


Sometimes player does not die on hitting fireball.
In case player dies it start moving from same position not from initial position.


For now you could sync *all* repos in the onapprove - since all will be to do with notify.
If you want to get fancy, you could restrict thsi to all which are of type FTP


but why would this be more readable than the character values themselves?

especially as I want to mimic this kernel code:

```
/**
 * audit_string_contains_control - does a string need to be logged in hex
 * @string: string to be checked
 * @len: max length of the string to check
 */
int audit_string_contains_control(const char *string, size_t len)
{
        const unsigned char *p;
        for (p = string; p < (const unsigned char *)string + len; p++) {
                if (*p == '"' || *p < 0x21 || *p > 0x7e)
                        return 1;
        }
        return 0;
}
```

--
Bazsi

On Mon, Sep 28, 2015 at 3:13 PM, Tibor Benke <notifications@github.com>
wrote:

> like static const int SOLUTION = 42;
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/balabit/syslog-ng/commit/df5841225bb730a981441042c13bc761ef1fbede#commitcomment-13468114>
> .
>


I think this is a more general issue, so I'm going to leave this unchanged for now and add a Trello card to capture the general issue.


Can this be moved inside the conditional below where it's used, so we don't compute it unnecessarily? And made const to make sure we don't accidentally do anything daft with it?


`self.bar`の更新を忘れてます


Code Smell: Encapsulation done nicely


If there are no keys passed in we should do a remove all, don't you think?


A* path

29 29
29 24
29 19
28 15
26 12
23 10
19 9
15 9
10 8
6 6
3 3
1 1
0 0


I think it might be easier to introduce it similar to the other global counters: just initialize it to 0 when `axesContainers{end}` is created and increment it here unconditionally.


easy !


Proper Comments are not provided for the code.


> Signed-off-by: Yuchung Cheng <ycheng@google.com>

I guess, it is a Chinese name.
Good job.


BTW: Je pense qu'il faudrait enlever les fichiers pyc du repo ...


Code Smell: Class with too many Functions, can be refactored to balance the class load.


Okay, that's cool. I can wait! But I'm definitely eager to create a whole new set of levels for Rockbot X!


**Inverted Index - Critical**

Common words in the phrases should not be indexed. Words like `and`, `the`, `so`, `but` etc.


Have we tested how well these changes adapt on our target devices?


The view can be null in cases of FXMLModel :)


yes, `reject()` should skip to `catch`, but for some reason in my case it didn't happen — in case of `--force` code continued to execute further literally, which means write errors and so on, while it had to skip to `catch` block and start iteration for another file pair


According to the review, the spacing should only be changed on the front page.

This means: 24px on the front page and 16px on all other pages.


Can we use `result.insert( result.end(), samples.begin(), samples.end() )` here? It makes it clearer what the intention is, and also gives the container a chance to provide an optimised implementation.


Code Smell: Classes with too much code, can be refactored


Sometimes coins float in air.
Random function for coins positioning not implemented properly.


**Test Coverage - Nitpick**

Review the description of this checkpoint and more  tests.
You should different words in different scenarios, varying the inputs, but valid and invalid so as to get the pertinent output.


Same problem here.

```
28 09 2015 15:14:57.576:WARN [reporter.junit]: Cannot write JUnit xml
        ENOENT, open '/Users/Jean/Developer/Projects/ovecc/doc/test/junit/Opera_32.0.1948_(Mac_OS_X_10.10.5)/Chrome_45.0.2454_(Mac_OS_X_10.10.5)/Firefox_40.0.0_(Mac_OS_X_10.10.0)/Users/Jean/Developer/Projects/ovecc/doc/test/junit/Opera_32.0.1948_(Mac_OS_X_10.10.5)/Chrome_45.0.2454_(Mac_OS_X_10.10.5)/Users/Jean/Developer/Projects/ovecc/doc/test/junit/Opera_32.0.1948_(Mac_OS_X_10.10.5)/karma.xml'
```


do we need "switchToShadowRoot" to (1) access the button, or (2) tap it, or (3) both ?

if (1), maybe you can do it in the getter for `headerActionButton` instead. If (2) or (3) then don't touch anything :)

Same comment for conversation/accessors obviously.


Have not tested on any physical devices, only desktop browsers and emulators. Auto-Prefixer also takes care of converting this for `-webkit-`.

It’s better than before in any case. Anything else you’d like me to check?


I meant that Promise here "encapsulating" async Nunjucks `render()` and waits until it will be fully finished


Very true - it was a straight copy from Merge, but I'll get it working without.


Yup - I've been getting a little confused over that. Some Imath functions do seem to apply exclusive, and others inclusive.


Hello-world


Mongoose populate?
http://mongoosejs.com/docs/populate.html

Even if they do not use populate, callback can be called before finalizing all async queries :)
Can do "IN ids" and call callback after query


@avigad : in line 361, the apostrophe breaks code mode in the PDF version. (It prints =R'=.) I made it a backtick but forgot to leave comment on that. Not sure what the simplest solution is.


I think I always planned on doing this, and it slipped my mind.


这个不需要用Long，int就行了，int的范围足够了


Code Smell: Classes with too many instance variables


Sure - that feels much cleaner


@kxepal: Would you mind updating the test suite https://github.com/apache/couchdb-couch/blob/master/test/couch_doc_json_tests.erl#L151


should we have a default behavior ? maybe throwing ?


Зачем?! о_О Рисковый ты человек.

(Я просто побурчу здесь, но, возможно, что тебе нужно самому несколько раз с этим столкнуться.) новые версии любых компонетом могут быть опасны :) А новые нестабильные версии опаснее вдвойне. Поэтому жеалательно не обновлять рабочие проекты до альф-бэт-релиз кандидатов и прочих снапшотов.


Yeah, I thought that pass the user is unnecessary, since I already have the id before the method call..


You know what, let's just add a \todo next to it, make sure we have a unit test for perfect pass-through and then deal with it later. Let's not complicate the implementation more than we have to at this initial stage.


LGTM


note that this would likely throw anyway, when the code would try to call "then" on undefined.


Dammit. That should be db_socket    :(


Code Smell: Good Class


Exactly! Thanks for the reminder, I wrote this code yesterday evening after a tool long day...
I will perform a deep pass related to this aspect by refactoring management of FXMLModel, SimpleModel & Model to avoid such pitfalls


**Code Quality - Nitpick**

As suggested in the other comment, Class names should begin with a capital letter, and named relative to its purpose. An instance of the class should be named as such but beginning with small caps.

For example:
```
function Car(name, model) {
  this.name = name;
  this.model = model;
}

Car.prototype.drive = function() {
  //
};

var car = new Car('Koeinesegg', 'SRV');
```


I looked at the ~300 or so new commits in the 3.0 branch and:
https://github.com/wxWidgets/wxWidgets/commit/6cf902b407f7391faa393dbedc8abf6e049eb145

was the only one that stood out. The other commits for W10 and VS2015 already got backported into our repository. There are others interesting commits but they are for fixing some warnings in VS2015 or are for fixing stuff in code that we don't compile and don't include in the 3rdparty folder. I could have missed some stuff since there are ~300 commits after all. Not sure when 3.0.3 will get released (it could be soon) but it would not hurt having some of those fixes in 1.4.0.

The current changes.txt (subset of all the changes) has:
```
3.0.3: (released 2015-??-??)
----------------------------

All:

- Fix wxFileName::MakeRelativeTo() for directory relatively to itself.

Unix:

- Fix wxIPaddress::Hostname() failing if /etc/hosts contained very long names.
- Fix wxDateTime::ParseRfc822Date() for some TZ/DST combinations.

All (GUI):

- Fix hang when deleting columns from wxTreeListCtrl.
- Allow requesting modern (3.x+) OpenGL version in wxGLCanvas (Fabio Arnold).
- Allow using Ctrl-dragging to add to selection in wxGrid (Knut Petter Lehre).
- Fix several floating point rounding bugs in wxPropertyGrid (Artur Wieczorek).
- Restore support for wxFD_OVERWRITE_PROMPT and wxFD_FILE_MUST_EXIST in
  wxGenericFileDialog which was accidentally lost some time ago (Carl Godkin).
- Fix handling of fast consecutive clicks in wxRibbonBar (atobi).
- Fix updating nested window scrollbars in some cases (sbrowne).
- Improve wxLIST_AUTOSIZE_XXX support in generic wxListCtrl (Kinaou Hervé).
- Fix wxPGChoices copy ctor (Snoits).
- Fix wxPixelData<wxImage>::Offset() for alpha (Markus Rollmann).
- Fix bug in wxImage::ClearAlpha() for shared data (Markus Rollmann).
- Accept wxALIGN_CENTRE_HORIZONTAL in wxStaticText XRC handler (David Hart).
- Fix appearance after updating a wxGrid with hidden rows/columns (iwbnwif).

wxGTK:

- Fix infinite sizing loop with GTK3 when using wxScrolled with a non-default
  target window.
- Fix crashes in wxGTK3 when running with non-X11 backend (Marco Trevisan).
- Fix coordinates of wxSetCursorEvent propagated to parent windows.
- Fix GTK+ warnings when refreshing wxListCtrl items (Scott Talbert).
- Fix using wxHTTP and wxFTP from worker thread.

wxMSW:

- Fix compilation with g++ 4.9 in non-C++11 mode.
- Fix regression in accessibility support (Leland Lucius).
- Fix regression in wxDC drawing with bottom-to-top y axis (Artur Wieczorek).
- Fix compilation with C++Builder XE compiler (Nichka).
- Fix best height of wxSlider with labels but without ticks (Artur Wieczorek).
- Fix initial text value of wxSpinCtrlDouble (Laurent Poujoulat).
- Fix best size calculation for bitmaps with buttons (Artur Wieczorek).
- Fix flicker when resizing windows with status bar (Artur Wieczorek).
- Fix size of the icon returned from wxFSVolume::GetIcon() (troelsk).
- Fix autosize after expanding/collapsing items in wxDataViewCtrl (ciglesias).
- Fix inserting tools removed from wxToolBar back into it (sbrowne).
- Fix disabling submenu items in the menus (Artur Wieczorek).
- Fix wxEVT_TREE_STATE_IMAGE_CLICK generation (Antal).
- Fix wxDV_ROW_LINES in horizontally scrolled wxDataViewCtrl.
- Fix RegisterHotKey() with negative IDs (troelsk).
- Fix event object type for wxEVT_SPINCTRL events.
- Fix bug if wxToolBar tool was deleted from its own handler (Artur Wieczorek).

wxOSX:

- Compilation fix for wxWebView under 10.10.
- Fix conversion of wxBitmap to wxImage in 64 bit builds.
- Fix length of text in wxTextDataObject.
- Fix using wxHTTP and wxFTP from worker thread.
- Fix wxFileDialog::GetFilterIndex() for file open dialogs (phsilva).
- Fix wxSearchCtrl appearance under 10.10 (John Roberts).
- Fix handling of "Cancel" button in wxSearchCtrl (John Roberts).
- Generate correct events for WXK_NUMPAD_ENTER (John Roberts).
- Fix handling of WXK_NUMPAD_ENTER in wxTextCtrl (John Roberts).
- Don't show wxDatePickerCtrl as being disabled when it isn't (John Roberts).
- Generate wxEVT_TEXT_ENTER for wxTE_PASSWORD controls too (mj_smoker).
- Send wxIconizeEvent when a window is iconized/restore (Rob Krakora).
- Use correct colour for disabled wxStaticText (sbrowne).
- Fix too large top and left margins inside wxStaticBox (sbrowne).
- Fix bottom margins sizes for several controls (sbrowne).
- Fix initial position of controls with layout insets (Tim Kosse).
- Don't allow pasting rich text in non-wxTE_RICH text controls (Tim Kosse).
- Fix printing all pages non-interactively (John Roberts).
- Fix custom paper support (tijsv).
- Return false from wxSound::Create()/IsOk() if the file doesn't exist.
```


such wow! so innovative


I've decided to leave this until @tadast is back from holiday, because I'm not sure I have enough context to make the change I'm considering. I'm happy that the current implementation is OK to deploy, but it would be good to address my concern as soon as possible.


Ну я в прошлый раз именно поэтому и не стал подключать нестабильные версии - остановился на 2.1.4. Ты же мне написал, что ALPHA побыстрее будет - вот я и решил посмотреть. Для себя понимаю, что это в учебных целях.


:+1: nice work


The prefixes are not needed; see #4394.


That's a good point, but what are we going to do about other operations such as `filter` or `foldLeft`? In some cases you want to know when the current value is `None`.


Ээээ... да, правда, я это говорил к тому, что скоро будет релиз и есть чего ждать :)


Bug: Player keep on climbing the stair even after end of stair.


BUG: Player doesn't move.


Where? It didn't seem to work when I tried it.


А что за странное название для переменной `show`? Что там такое? Я бы переименовал иначе сходу неясно что она содержит.


Umm, and sirius allows us to make a request with unlimited count of items? Because afaik there is a default limit.


@mstembera please run a sprt test on this.
@lucasart Yes, I think it will.  The 40k of lines are living in their own folder.


Ok, Mr. Mongoose, I'm not used to working with mongo. :P


this should use ctx.generate
http://guides.rubyonrails.org/rails_application_templates.html#generate-what-args


Whoops, `getPackage` doesnt take a second argument. :smile:


> would be good if the volume rendering provided a method like ValidateInput

:+1:

@sankhesh What do you think of @pieper idea ?


it is a bitwise or.. It will be the unique key of the two items. :)


are you sure that this will generate deploy/staging.rb ?


Looking at [Issue #40 and Issue #44 no backup to iCloud and remove files/ prefix](https://github.com/phonegap/phonegap-plugin-contentsync/commit/5b99bb162c556c37310184dc88427e77ec3ae090)
we can see that there is an implemetation to not backup to iCloud.

While I was testing my application for submission to Apple Store I realize that its still get my extracted folder to iCloud. I'm using the folow configuration for ContentSync:

```js
var sync = ContentSync.sync({ src: metadata.url, id: 'GVM', copyCordovaAssets: true });
```

So, I changed it to use the `unzippedPath` instead of the `path` which I think is for the zip path.


Bad white-space.  User a space after comma.


Code Smell: Unnecessary nested if-conditions (can be made into one if instead to optimize code size).


Bad white-spaces. (PEP-8 standards violated at many places.)


import 'choice' not required as it is not used


Unused import 'sys'


use a white space around the operator.


Well, it doesn’t, that’s why we should properly use pagination, not just strip events over default limit.


from `1.5` or `1.6`?


Let's use `if( !getInput() ) { continue; }` here, to avoid an unnecessary level of indentation and therefore make the rest of the loop more readable. Same in `hashSampleOffsets()` too.


Proper Comments not provided, difficult to understand the code.


Thank you !
Any idea when a 8.0.4 will be able to be released ? We are still using the SNAPSHOT version in our development process (cause of blocking problems in 8.0.3) and would like to release our projects soon. This version seems to be stable enough for us (just a last point to check tomorrow).


Согласен, не совсем хорошо. Вообщем идея была такая, что бы группировать сообщения в messages.properties согласно имени представления в котором они должны отображаться - в данном случае show.html. Быстро понял, что это бред, но часть сообщений так и осталась.


Used a lot of bad-whitespace and mixed indentation


BUG: Game doesn't exit when 'Q' or 'Esc' pressed.


Class docstring missing for all classes defined.


Modulation is absent


wild card import.


Encapsulation,polymorphism is absent


Mmm, I think (1). I can hide ```this.client.switchToShadowRoot(this.accessors.header)``` inside ```headerActionButton``` getter, but I'll have to call ```this.client.switchToShadowRoot()``` here after I tap on the button to go back to the _main_ DOM and thought it would be better to have this switches in one place, so that it clearly visible where we enter shadow DOM and where exactly we leave it.


In the package. It's fixed in the latest release.


Mixed indentation according to pylint! (PEP-8 standards violated)


А зачем внутрь `div`-а? Тогда уж в самй конец, перед закрывающим `body`. Или в чем смысл?


If I recall correctly we call this method first before we collect gender
from the user. If dob > female_yougest_dob then we tell the user they're
too young, because neither female nor male users qualify. Then later in the
process we check again for male users only. Sorry if it doesn't make any
sense, I'm replying from my phone without looking at the code :)

On Mon, 28 Sep 2015 at 12:45, James Mead <notifications@github.com> wrote:

> It feels a bit weird that this defaults to gender = 'female'. I think it
> makes sense in the context of FEMALE_YOUNGEST_DOB being later than
> MALE_YOUNGEST_DOB, but it doesn't feel as if it is generally correct.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alphagov/smart-answers/commit/16a8dd5fc815e2aede122ebeac64ba6642242fe9#commitcomment-13464346>
> .
>


An IllegalArgumentException should probably do it too, but to be sure this is fine


It should be ok now. Plz let me know. Thx


Yes, under "/config/deploy" folder, plus "production.rb"


I think this line should just be:

```js
formattedHelp.append("  " + line + "\n" );
```

where you modify `JSAPArgsParsingCommandPlugin` to strip the indent that JSAP automatically adds.


AFAICT, this method will break the indentation of commands that don't extend `JSAPArgsParsingCommandPlugin`. For example, if my command outputs this help message:

```
A
  B
    C
```

then we would expect this to be displayed like this in the terminal:

```
Help:
  A
    B
      C
```

whereas it will actually be displayed like this:

```
Help:
  A
  B
    C
```


2 kinds of jump functions should be there,but only one is written.


1.6 :-)


Code Smell: Inheritance not implemented, necessary condition of assignment.


Добавь как тут http://docs.oracle.com/javase/7/docs/api/java/awt/Color.html


Is it necessary to wrap the loop into a try ... finally block in case there is a error when calling bytestring to make sure memory gets freed? I think doing it would be a performance killer so I would leave it as is, what do you think?


My bad, will do!


**Code Quality - Nitpick**

 - You should keep your code [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself), you repeat the XHR request in all your methods, you should call it once per instance of your Class (Only called when the class is initialized).

- You should avoid using synchronous XHR, it's a deprecated feature and should be implemented asynchronously only.


этот `div` исчезает в следующем коммите ee1c3576fb605d1278e7d62821d721f7d557c504


PEP8 violation: Use of wildcards in import statement.


If developers see the constants they don't have to look up their names in an ASCII table. But if they want to check it they have to look it up... Let's keep it as it is.


CouId create a different class for same functions of player and Donkey.


Не надо присваивать руками RGB, надо использоваться http://docs.oracle.com/javase/7/docs/api/java/awt/Color.html


Thanks :-)


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


okay


Возможно, это и не имеет большого смысла, но я все URL-ы в т.ч. и для CSS/JS вынес в константы в `Url` класс. Кстати, может быть полезно если придется менять адреса.


@mbootsector
If a test got terminated early for any reason...you simply press the "modify" button to bring it back to the queue.


Dashboard ?


getPosition(), checkWall(), checkCollision() and collectCoin() function not present.


Agree, I think it's the only comment I have for this PR, good job @fitolandia!


unused import as reimported required same in line 5


fireball randomisation is missing.


Frame rate is so high,game becomes slow after some time.


Indecent Exposure. Every item has made public. Not specified,  public , private or protected.
Encapsulation Concept not used.


Report for Hw1


No levels implemented


PEP-8 Violation: Invalid constant name "lives"


I fixed it in `develop`. Thanks guys


The example I gave did work. How are you trying?
Simply providing `spring.datasource.x` properties should be enough, etc. This is looking at `org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration`


Which brings up an interesting point - how to make this testable both ways. Test will pass when there is `delete p;` in `basic_test` and there is no delete i; in `f(int*)`. But how could one (a) leave it without `delete p;` or (b) put `delete i;` in `f(int* i)` and ensure that the tool catches the problem but not terminate test run or even print error.

To clarify what I mean, here's an example with exception calling intentionally something that will throw and making sure it does or else test fails:
```
try
{
  f(); // must throw
  FAIL();
}
catch(std::exception&)
{
}
```


serve.js is Not used in this project. Commented in gulpfile.js


Думаешь стоила овчинка выделки?


Since the method inside the  `map` inside the Hash returns an array of array:
ex: `[ ["a", 1], ["b", 2] ]` The Hash[] will transform it to hash: `{"a": 1, "b": 2}`. I used it because the CI of the official rollout repo have testes with ruby versions < 2.0 and the `.to_h` method was introduced on 2.0.0 =/.
Maybe I extracting it to some methods like you said will be more clearly :D


global jj is not defined. It returns error


My question was essentially, can we do this in the accessor:
```javascript
switchToShadowRoot(header);
var elt = waitForElement(accessor);
switchToShadowRoot();
return elt;
```

If it's not working then I think it's better to do like you did. If it's working then I think it's better to hide this in the accessor. (I could even imagine a function `elt = withShadowRoot(header, accessor)`). But I guess it doesn't work otherwise we'd have this in waitForElement (for example). Can you check though ?


Small correction: URL = Uniform Resource Locator.

If you're curious, you could look up the different types of resource representations: URI (Uniform Resource Identifier), URL  (Uniform Resource Locator), and URN (Uniform Resource Name).


Missing docstring module.


Я бы их на строчки разбил, а то слишком много элементов в одной строке получается.


**Comments - Critical**

You should add comments that explain the methods, procedures, as well as the tests written in your module.


Player never dies , it eates the donkey when it gets in contact with donkey.


`p` is always set, so `sanity` or `full` are not taken into account. I would prefer having only the `-l` option and drop `sanity / full`


bug in stair case functionality.


А как ты эти массовые замены делаешь? Надеюсь, что не руками?


I'd remove EC imports (here and other classes) and let the Unicorn's users choose EC they want by making it an implicit parameter to methods that need it.


Lives of player never decreases.


:heart:


PEP-8 Violation:  Missing module docstring


Ooooo. It looks nice! :) The animation to 0 looks perfect! Do you need to do anything special with the new icons? I'm still seeing the old one on my phone. And I think that the drop shadow is supposed to be at 90º instead of 120 or whatever it's at now - and just a tick closer to the text, so that you don't start seeing the opening of the o in the shadow.


Ah, you meant this:
```
switchToShadowRoot(header);
var elt = waitForElement(accessor);
switchToShadowRoot();
return elt;
```

I suspect it won't work, but I'll double check and let you know :)


42:1: I201 Missing newline before sections or imports.
180:9: E126 continuation line over-indented for hanging indent
187:9: E126 continuation line over-indented for hanging indent


PEP 8 : invalid name for constants.


Thorny Forest -> Thorn Forest

(sorry :P)


How so?


but I used the `map` method. The `collect` is only the variable name


Maximum Line length exceeded PEP8 standards violated
https://www.python.org/dev/peps/pep-0008/#maximum-line-length
> Maximum Line Length
>>Limit all lines to a maximum of 79 characters.


@simonbrandhof thanks to review this commit


Для второго файла - однозначно. Мне читабельней, а строки короче. :) Для первого файла, наверное и не имеет смысл.


I worded out that the extra rows have been added because `TOPUP_END_DATE` changed from `2017-04-01` to `2017-04-05` and the date of birth in the responses falls on `YYYY-04-05` in all these cases i.e. they moved the other side of a threshold. This now all makes sense to me and I've amended the commit note on my local version of the branch to explain.


Code Smell: Modularity not implemented


Classes and modules don't have docstring .


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 61](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=225&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Code Smell: Inheritance not implemented, necessary condition of assignment.


@jcfr @pieper Each render call, `ValidateRender` is invoked that does a bunch of checks (input data exists?,  number of components, etc.) to make sure that the mapper can render the dataset. What are the conditions that cause the crash described here?


Это имеешь в виду ?:

```
<a>
    <button></button>
</a>
```


Different levels not implemented.


Да.


Change to `else if`


Size of player is smaller than that of coin.


I have minor improvements to push, so I can plan a release at the end of the week if you don't raise big problem between now and then.
I would like to sync it with JRebirthTour v2 that I will use during SoftShake Conference


ccscxc

[CodeBook.txt](https://github.com/MAbdullah47/CleaningData2/files/3603/CodeBook.txt)
[ReadMe.txt](https://github.com/MAbdullah47/CleaningData2/files/3604/ReadMe.txt)

[run_analysis.txt](https://github.com/MAbdullah47/CleaningData2/files/3607/run_analysis.txt)


These are additional copies


日付は登録日付だったので、そこだけ修正したファイルをこちらでマージしました。ありがとうございました。


js/bundle.js は git add したらあかん


Jump is not properly implemented, on ladder player stucks.


Thanks! This seems good to me. Please send a PR.


Added but wasn't used? Commit looks useless in this case.


WHY MAN WHY!?1!?/1


+1 Since this is now a per-binding property, and bindings are already unidirectional, we do not need to qualify the name of the property and obviously we only need one property per-binding. This has the added benefit of aligning more closely with what would be expected as a property for a MIME-type value, since "Content-Type" (or "contentType") is the commonly used header name.


```
var sketch = new Sketch('sketch');
```
でいいよ


ってか、元に戻すだけやったら、コミット取り消せばいいのに


Be sure to make 2 different repos for these 2 different versions of your bio: one with a framework, one without.

Also, note how you haven't provided the file type: .html for your 2 files.

Finally, each HTML file is named index.html, since they are the main page in your dedicated directories (see Duckett, chp. 4).


Maybe. I just made the opposite change in `fanoutHeartbeatResponse`, to pass the request instead of just the pieces that we need. I was thinking it would be better to centralize the knowledge of which fields are used in the `fanout` methods instead of spreading that logic between `fanout` and the (single) caller.


@posita i have added code with original version, now you should be able to see the difference. Also i have added test script for unit testing of functionality using QUnit. Please use "index.html" to execute the test case and see results. Also i have integrated Bower for installation of required packages.
Installation steps is given in README.md.
Attached is screenshot of testcases and results.
![testcase_results](https://cloud.githubusercontent.com/assets/1762853/10137046/3a7a4134-6615-11e5-8f66-cb86e309f395.png)

As i committed, i will also update the better version / way of same code and will update you soon.


too many Unnecessary comments. Can refactor the code, so don't have to use comments.
you're writing comments for people, not machines.


test


BUG : Player can move beyond the gameboard.


 Line too long , more than 79 characters.
PEP-8 standards violated.


deneme


Увы, руками. А причина, как я тебе писал, некорректная работа IDEA  в связке Thymeleaf+Spring MVC. IDEA не видит контекст переменных в html-файлах. Соответственно, не работает автодополнение, автозамена... Беда.


nothing to commit


the election could be over and our the local node just not aware of it. I don't think it's worth changing.


Как правило, советуют не писать в одну строчку и добавлять curly braces даже там, где они не обязательны.


bug in coin collection.player is not collecting coins while moving backwards.


Take another look at the "Getting Started" page, so you can verify the correct method to link to the pure-css framework: [http://purecss.io/start/#responsive-grids](http://purecss.io/start/#responsive-grids)


works for me.


ooo missed that one. :+1:


Conditional Complexity :  Too many if-elif  conditions.
could use alternative OOP like decorate etc.


Предлагаю попробовать посмотреть на `sed` для простых случаев и связку `diff`/`patch`.

Ты под Windows или нет?


С большой буквы потому что публичный метод


As far as I can tell this test wasn't testing what was intended. The test name says "Show rate for 65", but the date passed into the method under test gives an age of 64 not 65 (c.f. the "Show age of 64" test in the "check lump sum amount and age" context above this one. Anyway, I'm going to leave it unchanged in my local version of the branch.


After hitting fireball ,player is not going to starting position.


I was under the assumption that it was a requirement for it to fail if it was under the wrong protocol. My bad, will fix it!


Am I reading this correct that the `Table` component essentially gets a closure passed to it for accessing a particular row? What advantage does this provide over just passing in the row itself? Since this is represented as state for the `DQA`, wouldn't the table elements re-render each time the state changes anyway?


Looks incredibly good.


hm looks like this change broke the exec path. I've configured `bundle exec rubocop` as executable, this worked as expected, but with the latest version I get error: `Failed to spawn command bundle exec rubocop. Make sure bundle exec rubocop is installed and on your PATH`


This looks great on 7 threads and STC but it seems like we have two problems. Lower threads tests consistently give bad results and ttd values are increased at higher depths. So far, we didn't confirm that the second one loses elo but on the other hand we also cannot test this in the framework.

Maybe we can try this: we test on "hard to find the best move" kind of positions(lots of them) and compare the results. If lazy smp finds it at lower depths and relatively faster than the current faster, then we will have an opinion whether lazy smp causes regression on higher depths or not.


Согласен, мотаю на ус.


Too large class. Could be broken into smaller.


cook


Да, под Виндой.


One last suggestion... Since you already have `R2` itself here, a more succinct way to do this test would be:
```assert R2 in components```


Throwing in some Font Awesomeness, I see. :+1:


Same suggestion here as on line 40 above.


merge


Mike


Интересная идея. Может быть мне тоже стоит ее принять на вооружение, на один класс меньше станет. Я так понимаю, на скорости это никак не складывается?


encapsulation not implemented.(private and public variales).


@tadast: Yes. That does make sense. I just think that it relies on the fact that the female and male cut-off dates are in the order that they currently are.

Anyway, please don't feel the need to reply to any other of my other comments - **YOU'RE ON HOLIDAY**!


It'll work if you set the executable to `bundle` and additional argument to `exec rubocop`. It's kinda gross, I'd like to remove both of those options and just have `command`, where you can put whatever you need to and it should just work.


Just looking through the differences now.. as far as I can see, most of what you had is in official now (with proper node links too, since nodes are now customizable by the user).

Main differences are:

* I dropped the "HD Movies" link by default, primarily because the playlist itself is included in the skin, so re-creating that shortcut is pretty simple for the user (it shows in the shortcut action list).

* Music Videos isn't linked under Music, because Music Videos has its own main menu shortcut.

* Global Search isn't on the main menu by default.  I'm considering adding them in as separate shortcuts under each category's submenus though.  I think I'll remove the Logoff mainmenu shortcut too, since it's under Shutdown submenu and I prefer to keep the mainmenu as close to the 'standard' mainmenu by default.

* FileManager is there and linked under Settings mainmenu shortcut's submenu.

As far as I can tell, everything else is basically the same.  Let me know if I missed anything.

Pretty sure I've gotten all of the widgets in there too, at least the ones supported in Helix.


Does this allow for `minSearchLength` to be null (i.e. not enabled)?


Мне больше первая форма нравится -- больше ясности, меньше возможных ошибок в будущем.


On a perdu blablalol :'(


@punit121 You don't need to add `navbar-fixed-top`. It will work when you add this directly in the navbar element, as an inline class

cc @uagarwal744 @hitesh4 @NeerajUnnikrishnan @vinaychandil   @aniarya82


Визуально я, конечно, не заметил  замедлений. Возможно, стоить измерить.


if a solution does not exist yet it should also be added of course. ^^


no actual implementation of inheritance and polymorphism.


Maybe these observations should be written on the issue instead of the commit. See [https://github.com/karma-runner/karma-junit-reporter/issues/65](https://github.com/karma-runner/karma-junit-reporter/issues/65)


Lol :-)


MacBook Airからコメントを加えます。


Enter div-inception! #bootstrap :-)

Also, note your indentation for the div rows (cf. line 25). Unless, you're demarcating content distinction? Even still, I'd align and maybe use comments to do that work, if needed.


Там тоже можно, если установить Cygwin или Babun (http://babun.github.io) какой.


Actually this way it would also catch a weird case like `components['R2']` being a Rule, but the *wrong* one.


Oh, sorry, I thought it was a typo on my part. Thanks for fixing it. I'll see if I can think of a better solution.


Я с тобой согласен. Здесь скорее целью было "поиграть" с различными тегами `thymeleaf`.


LGTM


I think for 3.4.X kernels is better workqueue 3.7 with some fixes because if you apply 3.9y or 3.10y workqueue then your will must change "queue_delayed_work to mod_delayed_work" on all system,hotplugs or governors to be succesfull and efficient.
I hink this.

;)


note the double-quote.


What is inherited from the ZencoderAdapter?  It looks like all of the methods have been replicated here.


bug in juump functinality.jump functionality should involve 4 stages but tthere are only 3 stages.
Attach files by dragging & dropping, jump function should involve 4 stages but tthere are only 3 stages.


Maybe it works outside of a chroot?


Yeah, why not :)


Uncaught ReferenceError: computedStyle is not defined


Я только не понял, а  зачем это все?


I have not abandoned the idea of extracting my solution for parsing font shorthand, but I felt a need to push for a 1.0 of Trim Line Height before I consider that.


Even if he does so, the denom will be set for the nick "Herecomethedrums". Presumably Buffy will change his name back to Scully or whatever, and then .denom Scully will still fail to find the denom.

Maybe I should add an override where an admin can set a denom on a particular nick to cover special cases like this.


Looks like your indentation scheme is a bit inconsistent. Be sure to set up your text editor to maintain consistency. Typically, it's either set up for tabs vs. spaces. From there, check if your editor automatically does 2 vs. 4 spaces.


@neomindryan I removed the `+`. Folks were reporting that email apps were failing to correctly read the email with the `+`


Nice character code! :+1:


Which block has this property :S?


why do we need this again?


Oooo. This is an interesting error. Check it out and see what you dig up.


I don't think that's it, because master fails for me on my personal machine too. I'll dig into it as soon as I get some time. Probably worth me updating it to use the same mechanism as your auto-update uses now that you've made that work, too.


:D


other then my comment, everything seems to be working fine.


Just move the free() out of the if block.


I was thinking about this too, let me check if it's easy to do.


is this a special notification? seems like we should change whoever's posting it to do so on the main queue. if we actually need this notification, we likely won't remember to `dispatch_main`, as the convention is to have notifications delivered on the main thread


The new proposal looks much cleaner. Perhaps it would be good to also "explain away" the magic number 15 by putting it in a variable with a descriptive name?


I noticed this is needed now in a project of mine as well, so it seems a regression. Do you have any idea why we now suddenly need `type=submit`?


This works


Все это что? Cygwin/Babun или их установка?

Сами программы позволяют в Windows окружении использовать Unix-овые утилиты.

Зачем их использовать?
1) будет проще находить и исправлять кучу copy&paste
2) станешь более продвинутым в плане использования *nix систем


Personally, I would name this method is_topic_private?(topic), only because it always returns a boolean. What you did is fine, just letting you know what's considered normal in this circumstance.


Need to remove this `System.out` I didn't spot on the first pass.


Code Smell: Unnecessary nested if-condition (code length increases)


fixes #2


saw approval from gordonguthrie
at https://github.com/basho/riak_kv/commit/e815bc5899c89a6f0811cb995bd3764020e1a41d


merging basho/riak_kv/feature/fix-eleveldb-api = e815bc58 into borshop-integration-1190-feature/fix-eleveldb-api


basho/riak_kv/feature/fix-eleveldb-api = e815bc58 merged ok, testing candidate = 8cd78a47


Ух. Не, стало немногим лучше если вообще стало. Насколько я помню, названия стилей не должны отображать их стиль, иначе при изменнии оформения нужно будет и названия стилей менять. Они должны отображать их назначение.


@OutOfYourMind is this fine?


ХитрО :)


hum... did you try to do the low-level send directly? Should be simpler than to replicate all high-level cases here.

I didn't test, but something like this should work:
```c

const struct sol_flow_node_type *type = sol_flow_node_get_type(node);
const struct sol_flow_port_type_out *port_out = sol_flow_node_type_get_port_out(type, 0);
const struct sol_flow_packet_type *packet_type = port_out->packet_type;
struct sol_flow_packet *packet = sol_flow_packet_new(packet_type, last_value);

return sol_flow_send_packet(node,
      SOL_FLOW_NODE_TYPE_SWITCHER_BOOLEAN__OUT__OUT_0 + mdata->out_port_index,
     packet);
```


Code Smell: Well documented program


You'd better free the vector like you did in the generator.


Forgot to update commit message.. (only `.git` folder)


I wonder whether this should  be `throw` or `DBIO.failed` with `flatMap` above


Code Smell: Classes with too many instance variables


remove


Add all files.


Добавить цветов? Или я не так понял вас?


Were you going to separate this CSS into its own file? If so, I'd suggest making an "assets/css/style.css" location.

Also, currently, this version doesn't utilize the Pure CSS grid framework. Be sure to play around with it. This exercise was suppose to help you drum up some initial insights into how using a framework reconfigures your writing of HTML/CSS.


Err, right. I wrote this at one in the morning after a week of not much sleep.  I think I inherited and copy & pasted. I'll fix.


why the hardcoded IP?


or `DBIO.failed`?


See: https://github.com/sparkleformation/sparkle_formation/issues/69


Most places in background.js use wpt.LOG.info. Can we use that?


these hardcoded IPs seem problematic, unless I'm missing something?


Code Smell: Too many if-conditions slows down the program, can be refactored to if-elif conditions to make code fast


The abs patch is cosmetic. In case the calculated path includes ".." somehere, the resulting path is shorter and the commandlines becomes shorter and easier to read. Thats all. On Windows all my calculated paths are absolute and so the commandlines are long enouth to wrap many times.


what about this date: "2015-09-20"?


repeated code, should be placed in a separate function, doesn't follow DRY principles


If we can verify on the N5, N6 and iPhone 5/6 before landing that would be great.


There should be space before and after a comma( , ) operand.Not following pep8 standards.


similarly to what I said before regarding a generic `send_packet`, I believe that you could save specific code by duplicating the packet and keeping the duplicate instead of individual code.

```c

const struct sol_flow_packet_type *type = sol_flow_packet_get_type(old_packet);
void *mem = alloca(type->data_size);
sol_flow_packet_get(old_packet, &mem);
struct sol_flow_packet *new_packet = sol_flow_packet_new(type, mem);
struct sol_flow_packet *previous = sol_ptr_vector_get(mdata->last, port);
if (previous) sol_flow_packet_unref(previous);
sol_ptr_vector_set(mdata->last, port, new_packet);
```

this should work for all types.


typo in ServiceProvideer


Yes, I do find enormous semi-relative paths hard to read as well.


xyz


Documentation not provided. (Player move with 'W-S-A-D' instead of 'w-s-a-d'; should have been made clear at the start of the game)


+1 and this should change to "contentType" based on the comments below


Code Smell: Good level implementation.


#sapporo-nerv なるチャンネルがslackにありますがここでいいでしょうか


Why do you have to replace and prepend?


Seems like something went wrong with the tabs here.


you still need `eutils.eclass` for this


It is testable already. owner<> has no runtime behavior, so the test will never throw an exception (or terminate) regardless of whether owner leaks or not. owner is used as a "marker" to help compiler-like tools determine whether or not the code is valid and testing them is a different problem.


この辺の言い回しがまずくないかのチェックをお願いします


something wrong with tabs here too.


言い回しチェックお願いします


There should be space around an operand like " = " . Not following pep8 standards


Could you figure out what's really necessary and split it into `doexe` and `doins` calls?


This feels like one overload too many - since the other arguments are all about one particular tile, it seems outside of the scope of this function to then introduce global coordinates. I don't think we'll lose any clarity at all by doing the `globalPos - tileOrigin` operation at the call site rather than in an overload.


We don't actually need the sampleOffsets argument here do we? If so I think we should remove it to avoid confusion.


縁の例を書くと良さそう

- 就職
- 出身
- 学校に通っていた etc


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 61](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=225&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:32:09


Something like this?
```ruby
advertisement_length = pack_type.size + 15
"%04x# service=%s\n0000" % [advertisement_length, pack_type]
```


Could you optimize the code please, I can't run the game at my job's pc, 'cause the browser freezes.


I'd love a patch or PR, but I don't have a lot of time to spend on this
particular issue; sorry :disappointed:


ooooooh


Thanks for the PR, we will look into it! (Especially interesting case for zarafa-search)


未処理の申請


Hi,

no idea.
Please provide more information how the client and server is started.
May be, if you copy the terminal text instead of including screenshots,
it would contain more necessary information.

Mit freundlichen Grüßen / Best regards

Achim Kraus

Bosch Software Innovations GmbH
Communications (INST/ESY4)
Stuttgarter Straße 130
71332 Waiblingen
GERMANY
www.bosch-si.de
www.blog.bosch-si.com

achim.kraus@bosch-si.com

Registered office: Berlin, Register court: Amtsgericht Charlottenburg, HRB 148411 B
Executives: Dr.-Ing. Rainer Kallenbach; Michael Hahn

Von: ravikasyap1717 [mailto:notifications@github.com]
Gesendet: Montag, 28. September 2015 15:03
An: eclipse/wakaama
Cc: Kraus Achim (INST/ESY4)
Betreff: Re: [wakaama] Merge pull request #57 from eclipse/fix_observe (69a32cf)

Thanks Sir,
why that error is coming in eclipse 3.8 in lwm2mclient.c

and lwm2mserver.c

—
Reply to this email directly or view it on GitHub.


The code within this IF block should be simplified as well when changing the binding properties to have a single "contentType" property.


Check out this blog:
http://www.snee.com/bobdc.blog/2013/08/semantic-web-journal-article-o.html


のか？


Also forgot to add this statement. It has to return false since at this point the line segment hasn't been discarded(return true).


申請のある場合のnortice表示をスクショで貼ってもよさそう


But how much bigger is the executable? From 1MB to 4MB?

In addition TCEC has its own syzygy so its pointless there.


The name `pixel` seems a bit inaccurate here - maybe `sampleOffset` would better communicate the meaning?


why do we need this change?


I don't like the name starting with "setup" here since that collides with "set"-ters. Perhaps `configureMessageConverters`?


@kcristiano Quick note: `$upload_dir[basedir]` should be `$upload_dir['basedir']`


Block comments must start with # and a single space.


I tried to use the `expect` syntax. But when I change it, I receive:
```
     Failure/Error: expect(@rollout.collections.size).to eq 2
     ArgumentError:
       wrong number of arguments (1 for 0)
```
A look into the rspec-expectations 2.10 documentation, and it shows to use the `should`.
http://www.relishapp.com/rspec/rspec-expectations/v/2-10/docs. Different from the actual one that shows to use `expect` http://www.relishapp.com/rspec/rspec-expectations/v/3-0/docs/.

This `expect` syntax was included on 2.11.
http://rspec.info/blog/2012/06/rspecs-new-expectation-syntax/
Maybe we can upgrade it. What you think?


Hmm, I don't think this is needed. Nobody can modify `undefined` and even it does, it shouldn't. :grin:


this method could probably be combined with the above method once the single "contentType" property is available


This has been there for a long time, nice catch, turns up tests passes because that value is not passes forward. Will change that value to False and make sure that if it was called with `skip_auth=True` it would be passed forward.


jia sekalian ngetes kmaren, dganti lgi kah?


"ListRunning" is a duplicate of the outer Describe here. Lower-case "invalid response", please.


Body needn't be capitalised.


we either need an instanceof check here or higher up the stack change a method signature to accept only `AbstractMessageChannel`


https://gyazo.com/278a5164819723345394711e341ebc53
ここmarkdownが展開されてなさそう

```
※ミーティング予定がある場合
今月△日に全体ミーティングを開く予定です。
```

```
※ミーティング予定がない場合
現在全体ミーティングの予定は決まっておりませんが、Kawazでは毎月ミーティングを開催しておりますので、定期的にイベントページをチェックしてみてください。
```
みたいな感じで分けるとよさそう


Another duplicate description word


I dont understand. In my opinion 'description' is more informative than name.
Inside description we can specify what exactly can given right do.


use a white space around the operator.


Do you mean the last two lines in this commit, or the last two commits in this pull request? I think at least ocf:pacemaker agents and the tools for updating attributes make sense to remote nodes, right?

Is it possible for remote baremetal nodes to host containers and manage resources inside them? ;-)


Any reason this isn't in the medic github repo?  Is it temporary?


我也这么想。。   能否 python 只做核心登录  其他所有一切都走 插件http 回调， 这样应该轻松点


What does 'env grp' mean? Please don't abbreviate in these descriptions. Also, remove the trailing space.


Those number changed because width of word 'description' is bigger than width of word 'name'.


@graemerocher looking at the changes, does this mean readOnly dataSources are again regarded transactional (which is correct, imho) and as such this fixes https://github.com/grails/grails-core/issues/651 - right? thank you!


P.S. Вынеси версии в `properties` чтобы не было дублирования.


Hey Paul, thanks for your PR. Do you have any use case for this static method? I would just remove it.


定例ミーティングだけでなく、レクリエーション的イベントも不定期にあるからお気軽に参加してみましょう的な文言あってもいいかも

> 顔合わせや、Kawazについての説明、すでに動いているゲーム開発プロジェクトへの参加などのために、なるべくご参加ください。

「Kawazで動いているプロジェクトについて知ったり、すでにいるKawazメンバーとの親睦を深めるためにも参加してみましょう！」かな

「なるべくご参加ください」だと窮屈な印象


TeamCity Engage Booking :: CI [Build 7](http://teamcity.engagesoftware.com/viewLog.html?buildId=370&buildTypeId=EngageBooking_Ci) is now running


TeamCity Engage Booking :: CI [Build 7](http://teamcity.engagesoftware.com/viewLog.html?buildId=370&buildTypeId=EngageBooking_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:29


I find "pixel ID" a bit confusing - perhaps "Returns the samples for the pixel with the specified sampleOffset"?


Kawazの精神ｗｗｗ
基本的にgeekdrumsの意思が尊重されるけど、困るようなら #nerv チャンネルで相談 かな


Maybe better to disable QTKit capture in ffmpeg instead? Can be done by adding '--disable-indev=qtkit', to build_ffmpeg.py. At least I am having issues building with ffmpeg removed:

Undefined symbols for architecture x86_64:
  "media::FFmpegDemuxer::FFmpegDemuxer(scoped_refptr<base::SingleThreadTaskRunner> const&, media::DataSource*, base::Callback<void (media::EmeInitDataType, std::__1::vector<unsigned char, std::__1::allocator<unsigned char> > const&)> const&, scoped_refptr<media::MediaLog> const&)", referenced from:
      media::WebMediaPlayerImpl::StartPipeline() in media_blink.webmediaplayer_impl.o


:+1:  Thanks!


@maethu updated


I tested the swift tool locally, and actually it produces timestamps like "123456789.123456" on my machine, so different to the documentation!


具体的に誰か書くといいね @miio @Clpsplug @raa0121 @tunacook

今いる人も永久にいるとは限らないから、変更があれば都度修正だが


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2409


 <nav id="menu" class="navmenu navmenu-inverse *nav-menu-fixed-left* offcanvas portfolio-menu" role="navigation">
must be
<nav id="menu" class="navmenu navmenu-inverse *navmenu-fixed-left* offcanvas portfolio-menu" role="navigation">


「長時間のため参加者がダレやすくなるので」といったように目的を書くと良さそう（必ず、とあるので）


dsdf


And did you like it?


必ず決まっているわけではないがだいたいこの時間、と書くと良さそう


Okay, great.


Missed a rename of the method parameter here `totalTries` would be more consistent with everything else.


「夜まで行うため土曜が多いが、曜日は臨機応変に」と書いた方がよさそう


free is a not very good name for a variable.


I checked and it work properly even for nested tuples. I think this is an improvement for the language. Thank you for listening


Добавить


No we should not. If you specifically pass us a non-null value then it should delete what you told it to delete. Without this behaviour it was deleting things that it should not be deleting in the scoped cache clients.


FUCK IT I'M LIVING WITH THIS


N6 verified.

@addyosmani @sgomes Can either of you check out the other devices? Otherwise I’ll do it myself next week :)


ここらへん、スクショ撮っておいてあげたほうが親切かも（stgでダミー申請するとか）


This is how the article is updated if a newer version of the article is cached.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 23](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=226&buildTypeId=XbimEssentials_XbimEssentials) is now running


looks good @pcambra ...


Thanks @phil-davis. I tested it and it is indeed @, not &


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 23](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=226&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:00:47


"can not get fstat....."


new bee? do you mean newbie?


private void terminate() {


it was - starting to feel a bit permanent though


No its not special - we can post on the main thread if we want. Its not really convention though.


Nice, I wanted to do this the other day


no other problem found at review.


but it reverts presetting resolution. we really need to split action handling from render thread


thats ok


@plugz actually postRun was called via slotEndOfStream


Minor: Did you consider defining a new date format and using that instead of the `gsub`? A problem with the current implementation is that both the `gsub` and the `zero?` check further down are coupled to the use of `0` as the default year.


; one of them being a Web NFC record
one of which is a Web NFC record?


A bit brute force, but benefits of lazy updating would also need to be
shown. 👍🏻

On Mon, Sep 28, 2015 at 10:29 Corey Floyd <notifications@github.com> wrote:

> This is how the article is updated if a newer version of the article is
> cached.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wikimedia/wikipedia-ios/commit/6783645f900eda96c044850ab8984c1efbd82db4#commitcomment-13470105>
> .
>


Yup, it's much faster than Vim terminal and can do async stuff. Planning on switching completely but didn't make time to fix some missing pieces and I have a hard time learning LISP :smile:


Expected Result

![screenshot_1](https://cloud.githubusercontent.com/assets/4029811/10138432/1411bd78-6607-11e5-96f6-05eba65d6ac9.png)


How to add client folder to web shared hosting and point to my server?


specially consisting of .. ?


This one is not redundant, but GHC cannot see it because of the `unsafeCoerce` in the definition.


This enables ?


Will future ones do that? Make it a note?


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 62](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=227&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


font-awesome icons should really have `.fa` as well as `.fa-iconname` (where iconname is the icon's name, as specified in <http://fontawesome.io/icons/>) — this CSS ensures that it's automatically added in the CSS, even if it isn't added in the HTML


This one is not redundant, but GHC cannot see it because of the unsafeCoerce in the definition.


Expected Results

![screenshot_2](https://cloud.githubusercontent.com/assets/4029811/10138478/55093d38-6607-11e5-97ce-c39ae94090a3.png)


Public keyword  useless


in index.html nav-menu-fixed-left must be navmenu-fixed-left


why two spaces?


In the end I think it would make the code a lot clearer if we added new question type or added an option to this question type to explicitly model the concept of a question only needing day & month, not year. But it doesn't need to be part of this PR.


The comment can be kept for a better reading


Typo: GeoShape should have been GeoCoordinates. Subsequent git pushes address this (messily!)


Thank you, but I believe the plan is to re-write a new boost.asio implementation, as discussed here: http://cmangos.net/thread-7206.html


Isn't AddObject enough?


Expected Result

Wrong input doesn't highlight

![screenshot_3](https://cloud.githubusercontent.com/assets/4029811/10138531/9d81db4c-6607-11e5-9adb-ea4345c1f0f0.png)

Correct input highlights as below

![screenshot_4](https://cloud.githubusercontent.com/assets/4029811/10138545/afcb2b50-6607-11e5-8167-5ddec5a818c9.png)


fast-forwarding end-to-end/timeseries to borshop-integration-1190-feature/fix-eleveldb-api = 8cd78a47


Maybe you should drop the member `sequence` on `int_validator_data` as well.


@mbootsector Impressive and consistent result so far.


Please mention that this is a fix for IE 8 (and 9?).


Is it useful ?


Changed to void in a05c190616f295ee5b66ed595a836e3b2f6eb5e6


in index.html class nav-menu-fixed-left must be navmenu-fixed-left
in index.html class icon-social-twitter must be ion-social-twitter
in index.html class icon-social-dribbble-outline must be ion-social-dribble-outline


toJointDataDense must be tested or not ?


Removed in 44347f17fd36216d35df9c8fd886ab72606e34b1


I don't think so. See the interface comments and the LRU implementation. If anything, we can leave just `PromoteObject`, not `AddObject`


I am going to add this to my code base, and then fix all of the formats that fail.

I then think we should get a pull request done, so this logic also is put into the bleeding formats.c logic.


This promoteObject will only be called on new(ly written) parts if an already downed part is used no promotion will be done for it. I propose that we only add the part here (as this is the place we add it to the storage) and promote it in a more general place.


I do not really like the term jointConfigSpace. I would rather suggest something like: jointConfigSelector jointConfigPosition. Same for the other getters jointTangentSelector ...


Do you have a PR to chef master?


OK, having read up about what shared pointers do, I guess the assumption is that the only place a pointer to all the recordings is held is in this map, so when the map is cleared, the memory associated with the CPVRRecordings is released auto-magically (All clear() does is clear the complete m_Recordings map).
See:
https://github.com/metaron-uk/xbmc/blob/209bc86e9a67943839dd788a9254c918877ca58c/xbmc/pvr/recordings/PVRRecordings.cpp#L479
and
https://github.com/metaron-uk/xbmc/blob/209bc86e9a67943839dd788a9254c918877ca58c/xbmc/pvr/recordings/PVRRecordings.h#L41

Probably what is needed therefore is a RemoveDeletedRecordingsFromMap() function, which removes pointers for those recordings which don't exist anymore on the backend from the map, rather than wiping it completely and then re-creating it which is computationally expensive, especially as any EPG associations will need to be re-created each time a client requests a recordings update.

There seems to be a CEpgContainer::RemoveOldEntries function (https://github.com/metaron-uk/xbmc/blob/0d5f5cdce5a5d229f2e4b1eff01fe7a43353d2f4/xbmc/epg/EpgContainer.cpp#L478) so I'll look at creating a corresponding function for Recordings and calling it after line 57 below.


I have no idea, must be some js code?  @ArthurClemens maybe you have an idea?


nulstilling


Gustavo, esa estructura se corresponde con la idea original de Mariano de hacer un listado de nodos I2C esclavos al inicio del sistema. No llegue a hacer esa implementación, puedo eliminarlas o poner un #if 0, que opinas?


this should be reverted imo


Hmm, you are right - the promotion should happen somewhere else (the smartreader probably). But it also may need to be here. A user request can be handled 2 ways: by `carbonCopyProxy()` (when we don't know anything) or by `knownFull()/knownRanged()` when we know the metadata. In the first case, I think this code is the only place where we can promote the object parts.


FWIW this did not fix #1488.


After a closer look I believe QTKit is actually already disabled in Chromium's ffmpeg, I'll enable ffmpeg and see if it works.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.983.31245292bb7dfed887b1e27da70e94b31a4c076f](http://build.palaso.org/viewLog.html?buildId=63822&buildTypeId=bt431) outcome was **FAILURE**
Summary: Compilation error: Glyssen\Glyssen.csproj (new) Build time: 00:00:54


can't find the issue with previous implementation... what was it?


.Did you actually delete this table in this PR?


dependency on batch


Actually maybe part of UpdateFromClient (https://github.com/metaron-uk/xbmc/commit/ad0cd8e306200e9b83752d2ae6d18e336e32b3a6#diff-821f9fc69b834bb338f060b8fcb6e838R486) would be better!


I don't have the source code pulled up at the moment, but I believe `math.Pow` takes arguments `Pow(x, y float64)` – maybe it doesn't optimize for y being an int like JS engines do?


what is self.msgs?


Hi,

did you obey my (first?) e-mail answer?

"So If your lwm2mclient.c reports that error, I would guess you did setup Wakaama as "one large project".
If you instead setup Wakaama as several project (e.g. server, client, unittests), the error should be only reported in the "unittests". If you want to use them, install the "cunit" library. If not want to use them, just don't create a project for them.

By the way, Wakaama uses the cmake build system. Ensure you get familiar with that.
Otherwise I'm not sure, if you will be able to build Wakaama successfully."

Your errors result from the fact, that eclipse can either be setup for the "server mode"
or "client mode", which would result at least in two projects or two configurations.
The setup is done via C-defines (see the CMakeLists.txt files, LWM2M_CLIENT_MODE and LWM2M_SERVER_MODE)

Mit freundlichen Grüßen / Best regards

Achim Kraus

Bosch Software Innovations GmbH
Communications (INST/ESY4)
Stuttgarter Straße 130
71332 Waiblingen
GERMANY
www.bosch-si.de
www.blog.bosch-si.com

Tel. +49 711 811-58139
achim.kraus@bosch-si.com

Registered office: Berlin, Register court: Amtsgericht Charlottenburg, HRB 148411 B
Executives: Dr.-Ing. Rainer Kallenbach; Michael Hahn

Von: ravikasyap1717 [mailto:notifications@github.com]
Gesendet: Montag, 28. September 2015 15:03
An: eclipse/wakaama
Cc: Kraus Achim (INST/ESY4)
Betreff: Re: [wakaama] Merge pull request #57 from eclipse/fix_observe (69a32cf)

Thanks Sir,
why that error is coming in eclipse 3.8 in lwm2mclient.c

and lwm2mserver.c

—
Reply to this email directly or view it on GitHub.


@flavour Is this good for merge?


dependency on integration


Subí el ejemplo y vemos si hace falta usarlo o lo sacamos.


Why is it still a boundary?


why is this here?


На всякий случай стоит проверить: `assert(matrix.size() >= 2);`.
И в других местах, где есть индексирование вектора.


row(s)?


I will leave this one as it is. In general it is RFC3986 URL, but we use a special subset of those: which are composed of this and that.


And .gitignore file


columns?


> It is especially useful on the bebop when killing the regular autopilot that uses
iio drivers to access the imu because else we would need to manually unbind the
driver in an init procedure.

I think this is fixing the issue in the wrong place, although checking the return code is indeed good.
If you just use `I2C_SLAVE_FORCE` you are not forcing the other driver to stop talking to the sensor so bad (hidden) things might happen.  Wouldn't it be better to just not load the other flight stack and/or driver (you could blacklist the related modules).


thank you very much


I overlooked it. Thanks. I'm surprised I was even able to compile it. I thought Truffle complained about boundaries on methods that take a `VirtualFrame`.


I think that `AddObject` is unnecessary method and can be removed. We can make it not-exported method of the `lru` and make sure to mention in the interface that promoting non-existing object means adding it to the cache.

And yes, `PromoteObject` must be called somewhere else as @na-- suggests. We just have to make sure that no more than one promotion is done on a object part per request.


Можно начать с `i == 1`: `for (size_t i = 1; i < matrix.size(); ++i)`.
Тогда строки с 18-й по 21-ю включительно будут не нужны.


So you are delibarately inconsistent. That is not a good thing, especially not for a programmer. Please fix the line of code in question. It won't hurt, would it? ;)  Thanks. :)


Well, the normal Scala way is as I understand that null/none values are to be skipped, so that you can do those operations freely. At least that is the way Option works. But having versions with the Option content preserved would be a bonus here.


hey, are these changes supposed to enter in the project?


ИМХО, объявить только внутри цикла где она используется, а можно вообще обойтись без неё.


On the other hand `PromoteObject` adding to the cache is quite strange side effect hm... What do you think about it?


I'd like to have the errno value in the error message, so we can check what's happening... %m could work, but I'm not sure if we end up clobbering errno later in this function.  In case it doesn't work, strerror().


It is already a note. IMO we should just state we don't use it at the moment. The future is open :).


Reverted. I'll look into it more when I get back from NL, maybe it's a non-issue.


I think we should leave it as it is and retrink the interface when we implement a new cache algorithm.


Hi Eberhard,

this won't work I suppose:
898 +			free(p)

Regards

Frank


We're going to continue diagnosing the issue this week, you'll hear more when we have more info. It is a bit of a strange one, where several threads like the one above get blocked on sk spinlocks. If you do a full dump of all tasks when this happens, you can also see other threads in `rtl_pci_flush` but we haven't yet determined their degree of stuck-ness.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.984.489393e13b856960895d318dd884d970ac491488](http://build.palaso.org/viewLog.html?buildId=63823&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:03:00


The idea is to have the standby redis become the new master in a failure
case and then have rtpengine start up, reading the data from this redis
instance. The other redis instance (which previously was the master)
would then be restored as the new slave and be the new standby redis.


In this example used iterator. Find modified version that has used foreach loop: https://github.com/AlexMuriithi/XLSForm-Standard/commit/3fd5c0d562fac291f53eda5b5e96c6e059200049


agreed


I have pushed another new version of the code.  I apologize for all the amends.  I decided I needed to expose some of the RocksDB options for configuration and then had to tweak how the the Benchmarking tool could be configured to set them (and any other options the user might want to set).


ИМХО, вместо нуля `numeric_limits<size_t>::max()`, тогда не нужно будет проверять на нуль.
ИМХО, лучше сделать имя по-проще: `min_sum`, `memo` или `table`, например.


I have that fix in one of my PRs. Depending on which PR gets approved first, the other will have to be rebased.

https://github.com/avocado-framework/avocado/pull/802


Yes, that detection seems to only work in DSL nodes, and even then it's sporadic.


@christianwach Thanks, I thought I found all of those...  Grumbles...


how did all this code end up in the master branch?


Excellent catch


ИМХО, стоит объявить эту переменную пряно здесь, внутри цикла, где она используется: `size_t tmp_min_sum = min_...;`.


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4067/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


ИМХО, `min_sum_tab_tmp[low_matrix][high_matrix] = min(min_sum_tab_tmp[low_matrix][high_matrix], tmp_min_sum);` если использовать `numeric_limits<size_t>::max()` вместо нуля.


../capi/libcxl/libcxl.h:221:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
 int cxl_mmio_install_sigbus_handler();

I get those things too ...

int cxl_mmio_install_sigbus_handler(void);

helps to cope with my different compiler warnings/complain levels.


ИМХО, `min_sum += raw * colons * matrix[i];`.


OK


Try sending yourself an IX with the old implementation, then run gettransaction on that hash. I was getting a segfault, I looked at it for a couple hours and couldn't find the cause, although it's reproducible.


ИМХО, `uniform_int_distribution`, http://en.cppreference.com/w/cpp/numeric/random .


@lmr let me know what you think of https://github.com/avocado-framework/avocado/pull/805 (https://github.com/clebergnu/avocado/commit/a86cc33a1332fca46dbd4be393ab21fe636a1ecf), as IMHO it looks like a better fix for the same issue you fix here.


Хочется видеть тут проверку, что результат ожидаемый – сравнение с посчитанным независимо значением.


r=cbiesinger


ИМХО, стоит хотя бы напечатать аргумент `srand()` при котором тест не прошёл, чтобы было легко репродуцировать ошибку.


LGTM


This apparently does not come back always as text, but as possibly html.


putIntoRange seems a strange name for this.


Все еще лишние скобки


Never mind - that "optimization" can fail if the size of the fold is greater than the UTC offset.  For such a trivial thing, it's endlessly amazing how annoying it can be ;-)


Same concern as above.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/18522/testReport/) for this commit**


1. yes , i have my own laptop.
2. it is DELL E5-500 lattidue model and its specifications are 2GB ram ,250 GB hard disk and intel core 2 duo processor with os type 64-bit.
3.still i have work only some in Netbeans
programing answers
1. steps :+1: we need to get the files
                     get a while  and for loop
                     give the files as inputs and get them till loop over for loop still reaches the end file
                      use while loop and compare each file with strings and use pipe to get the matched files to save seperately .
                       now try to end the program and save the new files.
2. i have been installed ruby on rails ,python , c , c++ by g cc  ,and Java , mangoDB.
3. it would take a half a day and still i have no experience on automation on it.
programming languages:
1. still i have not done any codes as 1000 lines i have work in some projects and i have done only upto minimum of 500 to 600 codes lines.
2. i have learned ruby and some were python and c++.
3. the program will be sent to you with in as soon as .(please kindly permit me to do )


OK, although you could have removed the aexpect import.


True. Although I think if the change is exact the same, git will properly handle it at merge time.


Put it into a new PR & then Dominic & I can both have a look :)


Guys do your authoring on the XML files, not the TXT files.
E.g.: https://github.com/Dstepler/ENGL668K/blob/master/transcription/TEI/hu-hm2177-fb045v.xml