Cool. I'll remove this one from the set, but only once we've finished all
the open review threads on the PR.

On Tue, Sep 8, 2015 at 10:23 AM, Hubert Kario <notifications@github.com>
wrote:

> yes, the sigalg is expected to not be accurate, but we do collect
> sha256sum's for the certificates which then land in json and those are
> *very* important
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jvehent/cipherscan/commit/b1ba6dbbb64fb3648d945c3430942643f79d4155#commitcomment-13117730>
> .
>


note for me: fixed


Could you please add a note to the 1.9 release notes under "Database backend API" about the new feature flag?


You are right.
But there is no problem, this magic value is not used as a some data tag, this value is only for non-null check pass.


Should this be "CFPB front-end development team"?


Shouldn't this also be MvxCachingFragmentCompatActivity?


newline


It's not needed because we no longer have the "native capture mechanism" modules check for other capture mechanisms, we have the table in pcap.c, so I just removed the #include in d2a74fef0d6ae5bb5dc649212e667d8e64383c86.

I fixed the uses of `p->md` in pcap-tc.c in 615b65f7ac1e6f280442dbdf7dfa0b03f0da6e61.

AirPcap is handled inside pcap-win32.c and packet.dll, so it should work.  (It arguably *should* be handled as a separate pcap module, but that's more work, and people using packet.dll directly might expect it to work; I'd like to get people to *stop* using packet.dll directly, but that could take some time.)


Sure, I'll accept a PR for that. Thanks.


ненужный метод, он уже есть в application хэлпере, и может использоваться по всему проекту


I did indeed. Thanks for the constructive comment. Again, PRs accepted.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.501.390a557cd11a85c4021d6a2cc1df6f05c42d4eea](http://build.palaso.org/viewLog.html?buildId=62877&buildTypeId=bt223) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 3317, ignored: 140 Build time: 00:10:56
### Failed tests
```
Palaso.Tests.dll: Palaso.Tests.Progress.ConsoleProgressTests.LongRunningMethodUsingConsoleHandler_ProducesLog: <no details avaliable>

```


WTF??? O_o


Actually, I think I can wordsmith this to be flexible....


rebased


Good catch!


ok. no veo mal que se use solo la capa de transporte siempre que se respete la secuencia
ciaaModbus_transportTask()
ciaaModbus_transportRecvMsg()
ciaaModbus_transportSendMsg()
Creo que si se usara todo el stack, se podrían aprovechar otras funcionalidades. Por ejemplo mapear en holding registers información de la placa para saber cuál es, etc
Si quieren lo seguimos charlando por mail o hacemos un skype :)


displays*


but then we just checked in changes from `[]` to `[[ ]]` as they are more lenient towards simple mistakes... so by which rules do we play? :)


Gobs are cheaper than a full on DB.


I did so there is naked data on first run.


These two commits reconcile the new FromXML() functions with duplicate loading code in FlxUI:

https://github.com/HaxeFlixel/flixel-ui/commit/5f72c45390822889c7d04bcf0203339fae538cc6
https://github.com/HaxeFlixel/flixel-ui/commit/3d837b0c13609d169b5edca733632bf54c7810a5


r+


Splitting this commit on four smaller ones (one for each item listed in commit message) would be useful.


если добавлять валидации, то заодно нужно добавить валидацию мин колв-ва символов и можно формат указать (запретить использовать спец символы)


Actually Jack built out the CSS for this, I'll make sure he gets the message.


@jgravois I noticed that the === keeps getting back in there.  There are cases where this needs to be == or it won't work.


Actually we shouldn't be needing this anymore, as it is coming from CTP.


AddStuffToUI2 (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-NA-red.svg)


until it passes -> to see the traceback of the failure?


Good call (I think? I have no idea, I do DevOps not FE stuff.)


I can only do so much in each pass. The script has to continue working
after every single commit. [ to [[ is higher priority than [[ to ((, so it
happened sooner.

On Tue, Sep 8, 2015 at 10:29 AM, Hubert Kario <notifications@github.com>
wrote:

> but then we just checked in changes from [] to [[ ]] as they are more
> lenient towards simple mistakes... so by which rules do we play? :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/e98ff1024b69a6da07448a796aa5f60ac07df816#commitcomment-13117867>
> .
>


Зачем этот метод, если ты его не используешь и что за Full_name??? O_o


Yooooo nice


Instantiation requires passing username and password separately, instead of part of the URL.


k.  semistandard is throwing an error, so we'll have to throw in an eslint ignore or something more surgical.


why !


spacing


delete these views until u use them


Commented out code behaves differently. So I have attached a very simple code snippet with the working streams example.


u already have resources :events bra


Is there a specific section in the pickle docs to refer to for the "more information"?


So it does. Thanks for catching it. See PR #1


Makes sense to me. Updated.


alwasy space above expect's


No, as you know on my Linux dev box, I manually manage the dependencies instead of using the build script, and I am always using fairly recent versions of FFmpeg. I have to as part of MLT maintenance.


Thanks for spending your first week letting us all know how insecure you are about sitting two chairs down from me. Would love to talk about doing code reviews of some of my other side projects when you get in today. Cheers!


А если не найдёт?)


А если не проапдейтит?)


It's true that `#present?` is semantically different, although that's irrelevant here as data will never be `nil`.

Also it seems the main escape clause is the `break` a few lines down...


You basically get two different types of responses. One initially containing multiple hits, and later containing one single _source.

See this code I have written elsewhere on handling both cases for reference:
function processStreams(response, callback) {
      if (response.hits) {
        for (var hit in response.hits.hits) {
          // console.log(response.hits.hits[hit]);
          callback(response.hits.hits[hit]);
        }
      } else {
        callback(response);
      }
      return;
    }


Try creating a new component and passing it into the Comment class instead of just passing in a string.


Делает ничего :)


spacing and should just use Event.new not make a factory


Zasada jest taka, że pomiędzy funkcjami nie w klasach i klasami 2 linijki odstępu, a pomiędzy metodami w klasach 1 linijka. Pycharm bardzo ładnie podkreśla i podpowiada, że jest coś nie tak.


youre good, there was another one besides this, but Ill let it slide this time..haha


again remove all this random stuff u aren't using


Why not set this same object as the associated data, thus avoiding the need for `instanceof` check?


cool, disregard a lot of my comments then from the last assignment!


Jako parametr przekazujesz design_situation_id, a potem próbujesz wyciągnąć z design_situation (którego nie dostajemy w parametrach) id.


@FilipeMaia uncommenting this method causes the `simple_index.py` test to fail. Any feedback is appreciated.


Interesting.  Is it better to crash or to show extra sections?  The one will produce an automated report -- which I assume is actionable -- while the other is more likely to get a meaningful human report.  Is `assert` a code-base standard?


Thanks for pointing out.


@Ruined1 oh, I thought you were working on stubborn app removal (e.g. Cortana, Edge, Feedback, Customer Support)


**Eslint**: 'return' outside of function


You're right. The skip not supported platforms https://github.com/spark/firmware/blob/f381b65a5b2cc06513eaa338b03b9351bf468e8d/modules/makefile#L22 could return a designated code that we could catch.


Why would they be useless? Why couldn't you make pine or acacia our of their tree nodes?


```
from the source
```


Visible is actually an indication of the page should be shown in the navigation. http://learn.getgrav.org/content/headers#visible

The page collection should already take into account *routable* which means the page is available to route.  Also FYI, setting `published: false` is the preferred way to make a page not show up temporarily.  This will make the `Page->routable()` return `false`.


ERRORS i INFO są globalne. W związku z tym wystarczy dodać, nie trzeba tego zwracać.


Готово.


What do you mean by useless? Do you want me to remove furnaces?!


To już właściwie niepotrzebne, więc wywaliłam.


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-MacOS-10.9-clang: OK (1832 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Having "index" in the name, but not containing integers, is misleading.  Just "toggles"?


I presume the removeAllListeners() is to emulate `once()`.


r+


@DiegoUA Yep, we know about that problem and @Ruined1 says he's onto something, we might have a fix out soon. As for the onedrive thing, it's already done through the registry with DisableFileSyncNGSC


Имя вьюхи table подразумевает под собой, что она будет содержать таблицу подобной инфы.
С помощью current_user ты показываешь текущего залогиненного пользователя. Не думаю что количество будет превышать больше чем 1 пользователь.


O, właśnie tu przekazujemy konkretne id.


shit
look at dis
https://github.com/Queuebe/Queuebe-server/commit/3cce0a8c8838f4557dad85a32d4f019acf9d3417#diff-9b387009a2c792a208b434ffc00f3252R81
I couldn't spell back then


в конце файла новая строка


Consider a better name.

"Refusing to send outgoing request on connection that is draining"


It seems that the only thing that changed is whitespace. In this case commit message is irrelevant, and the commit probably can be dropped.

Also author name differs from other commits in this PR (`ligee`, while others `Ilya Chernikov`).


Check comment function


показывает тоже что и метод index (только в методе show не реализовано ничего)


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.479.549c1cad9d577108751ddb541318fbce0c37240e](http://build.palaso.org/viewLog.html?buildId=62879&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:08:47


r-

you're inverting the logic here for cipher_data[9]


How do "Browsing data", "Cache", and "Offline website data" differ?  Can we clarify?

Perhaps Android or Desktop has set a standard?


Am I crazy or is the current code already in place there on `Statement.php`? :-)


Is this now correct and complete @taldcroft?


update использует POST, ты никогда не попадёшь на эту страницу


это пробел можно убрать


r+


Resolves issue #15 - forgot to do in commit message.


Is _logger defined?


That variable isn't used at all anywhere though. What the hell was I doing


Hrm, I didn't push the correct branch. Thanks, will fix.

On Tue, Sep 8, 2015 at 10:41 AM, Hubert Kario <notifications@github.com>
wrote:

> r-
>
> you're inverting the logic here for cipher_data[9]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/e4e1ddd3bf7eb62ec8015c29e35eaf92f4263386#commitcomment-13118140>
> .
>


Why do we need this change?


@wesleycho @dabos-GFI Removing the display: 'block' on the tooltip css breaks the popover implementation.  Bootstrap starts with a display: none on the popover style.


Its more of a [Heroku Buildpacks](https://devcenter.heroku.com/articles/buildpack-api#buildpack-api) / Git Hooks thing.

Buildpack images inherit from [buildpack-base](https://github.com/spark/buildpack-base) which [calls them on execution](https://github.com/spark/buildpack-base/blob/master/scripts/run.sh#L15). This allows [smaller and more reusable images](https://github.com/spark/rfcs/blob/feature/compiler-dockerization/services/cloud-buildpacks.md#docker-images).


@lieuwex


LOL

On Tue, Sep 8, 2015 at 12:36 PM Bobbilee <notifications@github.com> wrote:

> cool, disregard a lot of my comments then from the last assignment!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/voltaaage/Blocmetrics/commit/5181961fe34f854c749f125a4311611002926a38#commitcomment-13118031>
> .
>


:crocodile:


Aha, I thought those are pictures. Turns out not. Will update them next time by myself


Ah, silly me. Need to find the app


Since it looks like these tests pass without any code change, are the two tests above sufficient?


This change broke some code of mine. That's fine, but I wonder if this is the best fix.

In my case, I have an AR model that uses Mash to capture random attributes that are not actually columns in the database. I use `method_missing` to implement setters and getters on the random attributes to set things in the Mash. With this change, all first-time assignments are now blowing up because `!key(key)` is (correctly) true, and `respond_to_missing?` and thus `respond_to?` return true. I can no longer tell the difference between what is a method and what is not.

I suppose I could change my `respond_to_missing?` to return false on a actual method -- but does that get tangled up too?


I see, fixed in next commit. Thought I was in a PR.


That makes sense


will we be using SEMVER going forward?


r+


Ah, they all got brought in with the 'rails g controller' command


I would not allow a reduction of resolution. Some users prefer lower refresh rate with higher resolution. Operating the gui at 2160 makes no sense anyway. Users can watch 50i at 1080 and tv would switch to 4k when they play 4k@ <= 30.


`levenshtein()` does not return false but -1 on failure
also what about introducing `Strings::findClosest($s, $items, $maxDistance)`? I even have PR for it, just didn't sent it because there was terrible internet on Nette camp.


This feels incorrect. Should we check state === Initial.

I believe we do not want to terminate streaming requests that are ongoing.


Tu tylko kosmetyczna poprawka, żeby zawijać linie dłuższe niż 79 znaków.


To zrozumiałe.


Did not know this - can you investigate what else is needed so it works well for both?


nitpick: decrement indent to match `if` and closing `}`


LGTM


And corrected dates


We only log the missing node and respect the return value in one Ledger ctor. Is it safe to assume the exception will not occur with other calls such as setImmutable? One alternate possibility is to have setup log upon it throwing and not miss an opportunity to record a missing shamap node.


It was primarily made because my setup kept crashing or failing, which left the send in a non-finished position. Only option would have been to start over from scratch, but that's not an option when there's terabytes of data already sent!


No dobra, to jakoś brzydko mi przeniosło.


This line adds JQuery as dependency


add: "instead of defaulting to multiprocessing.cpu_count. You can't use both options together."


What's the motivation for draining this connection instead of closing it ?


You have a type here :D


yes, I guess so :)


link "parallel" with `:djadminopt:`


chop "However"?


I would prefer that we do not rename modules. I know that it is more work renaming in the whole file then `template` to `base` but I think it will make a cleaner code in the longer run.


W tej linijce wyżeh jest sr_max, którego nie ma nigdzie wcześniej i to będzie pierwsze miejsce, gdzie nam się będzie program wywalał.


I'd squash the documentation with the implementation of the feature.


Do we need undrain() ?

It doesn't look we test or use it anywhere.

YAGNI ?


Add standard header.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.43.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62872&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:35:28


Yup, already done :)


Weird that this made Travis fail - works fine on my machine. Anyway, I went back to putting strings here and that apparently fixed whatever the problem was...


chiripi envia segundo commit


Ale może i dobrze, bo jest tu asw_prov, którego nie ma nigdzie wcześniej i jest to drugie miejsce, gdzie nam się wywali.


I trzecie miejsce, gdzie się wywali: ssq_prov - nie ma tego wcześniej.


Couldn't have done it without Serj's support.


For development builds, I'd argue that crashing is more useful since we get the immediate feedback with a stack trace. For production builds, it'd be safer to ignore the error instead of bringing the whole browser down for a relatively minor issue. `assert` gives us the best of both worlds since [it's ignored for optimized (release) builds](http://swiftdoc.org/swift-2/func/assert/).

We do use `assert` in a few places throughout our codebase now, though not enough IMO.


I guess the point is: If I make `respond_to_missing?` answer true for setters I want to honor, I will always get an exception now. This seems to make `method_missing` impossible to use.


the idea is revert this commit when the next release of microhttpd happens. This commit will be reverted and the release version will be set as minimum required. I still can put a comment there, but i really don't want to ifdef this code.


fixed


Oh. Sorry. Indeed. Next time will try to read full code before making any judgements :D
Thanks for clearing this out!


section na razie nie jest wykorzystane, pamiętasz o nim?


r+

(also: man shakes fist on intuitiveness of bash syntax.jpg)


Ok.. this is what I have till now after updating everything from Git and trying to run the app:

Sony Tablet Android 4.4.4 FrostWire was installed and is running as usual.

Samsung S3 Android 4.0.4 FrostWire cannot be installed :(

*Waiting for device.
Target device: samsung-sch_i535-761b386a
Uploading file
	local path: /Users/Erika/frostwire-android/build/frostwire-android-debug-1.6.3-b202-basic.apk
	remote path: /data/local/tmp/com.frostwire.android
Installing com.frostwire.android
DEVICE SHELL COMMAND: pm install -r "/data/local/tmp/com.frostwire.android"
pkg: /data/local/tmp/com.frostwire.android
Failure [INSTALL_FAILED_OLDER_SDK]*

so I guess only Android 4.1 devices in advance will be able to use the app, Am I wrong??


I don't have a solution, but that's exactly the consistency problem I was referring to in the google group. If a tiddler is modified by the ActionSetFieldWidget, there needs to be a mechanism, that invokes "save" hooks too. From my point of view, a plugin author should not need to deal with "different types of tiddler manipulation".


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.502.549c1cad9d577108751ddb541318fbce0c37240e](http://build.palaso.org/viewLog.html?buildId=62882&buildTypeId=bt223) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3317, ignored: 140 Build time: 00:12:43
### Failed tests
```
Palaso.Tests.dll: Palaso.Tests.Progress.ConsoleProgressTests.LongRunningMethodUsingConsoleHandler_ProducesLog: <no details avaliable>

```


Can you submit a PR for this to be added to @kylereicks source project?


Tu nieco wyżej jest fyd, nigdzie nie wykorzystane.


I don't feel strongly about what scheme we use for version numbers. I do feel that we should basically never break backwards compatibility.


what happesn if I `return null` or `return {}`


:+1: Perhaps PR this if you've tested and implemented 3.x ?


Tu wyżej jest asw_prov i ssw_prov nigdzie nie wykorzystane.


You are right


remove space


technically speaking we're still expanding an array without an index

but it does get rid of a single assignment

r+


Powershell script for determining OS language and then downloading version of Beyond Compare :+1:


There are problems on Windows:
```
Traceback (most recent call last):
  File "c:\Users\Tim\.virtualenvs\django35\lib\shutil.py", line 381, in _rmtree_
unsafe
    os.unlink(fullname)
PermissionError: [WinError 32] The process cannot access the file because it is
being used by another process: 'C:\\Users\\Tim\\AppData\\Local\\Temp\\django_36t
zyz7k\\tmpdgbnud1l'
```
However, I believe this problem precedes this change. Old error: "Failed to remove temp directory: C:\Users\Tim\AppData\Local\Temp\django_cluai9g6"

Just mentioning off hand in case you have ideas. If not, we can create a ticket.


Although a RLock is surely more performance friendly, I would suggest either:

1. Use just an `Lock` to avoid any potential issues down the road (e.g. forgetting to unlock).
2. Make use of a closure function so that you can utilize `defer r.RUnlock()` and separate these two portions of code.


You want to call this after the `each()` or it emits drain immediately.


I just recently also had stability issues with threadirqs and XHCI (quart- or mid-way through 2 TiB of data) - not comparable with your and other enterprise amounts of data but it's still annoying when after hours of transfer you have to re-start from scratch,

it's not the same like when we finally having full support to resume interrupted snapshot sends but it comes pretty close to it :+1:


PLACEMAKER for ongoing review.


1579840-GroundTemps (mmatts) - i386-Windows-7-VisualStudio-12: OK (1839 of 1849 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.46%25-yellow.svg)


That was a use case from the the forums: @MattDevo for examples runs his rig at 4k@30 gui wise and would like to prefer to switch to 1080p50 for the LiveTV.

I am open to either solution.


if we do want to use semver, than this is really 0.0.3, as I guess it's not actually adding functionality


sure, and thank you for doing simple patches that do change one thing

I'm not exactly convinced, I'll let Julien decide


I had once been in the same project. And I want to join the group again. Eilo does not answer in Skype.


had some free time during school :P


We should probably plan to audit all code that interacts with views and ledgers. All transaction logic and RPC logic should already be wrapped. That leaves pathfinding, NetworkOPs, and LedgerMaster as places to look closely. But this patch fixes this particular constructor, which was a definite regression. (The constructor takes pains in other places not to throw and code relied on the constructor not throwing.)


Absolutely correct that this wouldn't be validated otherwise. But it would be slightly more efficient to do:

```
if Event.objects.filter(organization=self.organization, slug=self.slug).exists():
```

esp. since used_slugs doesn't get used elsewhere?

I'm also a bit confused about returning an empty list if slug is empty. It's a mismatch in return types... I'm guessing these two things might be related / artifacts of an earlier implementation?


As best as I can figure --

Non-arithmetic Bash operators aren't commutative - can't just swap LHS and
RHS and have it continue working. They're not mathematical comparisons, so
they don't have to be, technically. No one has trouble with "$variable =~
value", because we're all accustomed to =~ being LHS variable and RHS
value. So == and != follow the same rules.

Arithmetic operators ARE commutative, though. (( a == 1 )) and (( 1 == a ))
are equivalent.

 - R.

On Tue, Sep 8, 2015 at 10:53 AM, Hubert Kario <notifications@github.com>
wrote:

> r+
>
> (also: man shakes fist on intuitiveness of bash syntax.jpg)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/0cbd032252340271e3fc0cc411d46d6b3859b5e3#commitcomment-13118404>
> .
>


Looks like you may have renamed or extended fRequest with vRequest at some point in your code and used that inadvertently in this pull request.  That said, I wouldn't have a problem fixing and merging in as it seems useful, but I'm curious as to whether or not you're maintaining a very distinct fork or just have a few extensions?

This is mostly a longer term concern, because if other additions rely on your custom fork, obviously they'd not work in the mainline branch.


@feiming Please don't directly push to any of the saltstack-formula repos. Standard procedure for all contributors is to open a PR against the repo so we can get someone to review and then merge it.


I am skipping return value 0, i.e. when $item === $value.


"Browsing data" should actually be "Browsing history", I think -- thanks for catching this. I agree that "Cache" vs. "Offline website data" is confusing, though we don't have any additional clarification on this setting for Android/Desktop, so I don't think that's something we should worry about here. Maybe a good follow-up bug for UX to investigate.


Should be a pointer.


1579840-GroundTemps (mmatts) - x86_64-MacOS-10.9-clang: OK (1833 of 1843 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.46%25-yellow.svg)


Should be a pointer


@HBMDDS
Did you remove the matlab code?


Nope, $result is a string:

```
          result="$cipher $protocols $pubkey $sigalg $trusted $tickethint
$ocspstaple $pfs $current_curves $curves_ordering"
```

On Tue, Sep 8, 2015 at 10:56 AM, Hubert Kario <notifications@github.com>
wrote:

> technically speaking we're still expanding an array without an index
>
> but it does get rid of a single assignment
>
> r+
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/f36e52a50a8456d2edccd7945f19e351078648cc#commitcomment-13118452>
> .
>


No, it isnt


All integers internally should be int64


Add descriptions to all these


Nice.


I'm confused why this exists?


Hata hi deta??


Removed a not so fun fact.


I just realized we could speed up `HessianNumber`/`TensorNumber` calculations by writing them like the above (e.g. manually constructing the lower-order `ForwardDiffNumber`s instead of falling back to `f(gradnum(h))` ([here](https://github.com/JuliaDiff/ForwardDiff.jl/blob/master/src/HessianNumber.jl#L304)) or `f(hessnum(t))` ([here](https://github.com/JuliaDiff/ForwardDiff.jl/blob/master/src/TensorNumber.jl#L364))).

Writing the code like the above allows more reuse of the derivative calculations. It would save a single extra derivative calculation for HessianNumbers, and save 2 extra on top of that for TensorNumbers. I'll play around with this and make another PR if it pans out.


No i na koniec pytanie za 100 punktów: skąd się wzięło tak dużo parametrów do zwrócenia? DO tej pory były tylko: vrdc, vrdmax, ERRORS. Dorzucamy do tego INFO i lekko modyfikuję widok (compute_punching w views,py). Tak ta funkcja jest wywoływana i zwracane są dwie wartości vrdc, vrdmax wrzucane w wyniku. Ok, z tego, co pamiętam, tam ma być jeszcze jakaś dodatkowa tabelka z wynikami - czy to to? Jeśli tak, to proszę o taką informację, a dodatkowo pytanie: czy te wartości mają się zapisywać do bazy? Bo jeśli tak, to trzeba wprowadzić kolejną (niewielką) rewolucję w modelu. Bo jeśli człowiek będzie sobie chciał wyświetlać swoje stare obliczenia, a w nich te wszystkie wartości, to dobrze by było je faktycznie do bazy zapisać. @szaparenko , przemyśl to proszę :) to zadanie zakończmy na tym, że jest to zwracane po prostu, a w kolejnym zrobimy wyświetlanie tych pozostałych wyników w tabelce. Dobrze by było mieć jakieś przykładowe wartości do obliczeń (później napiszemy testy), żeby sprawdzić poprawność wyników, jak już nam wszystko ładnie zadziała :)


you also have to declare it so that its there for when you compile...


You may want to allow selection on complete jobs.


spelling mistake


Jobs do have a status resource?  You should add the status subresource now rather than leave this open.


unused self?


tab tak commit message mein pahuch chuka tha :P

On Tue, Sep 8, 2015 at 11:31 PM, Prabhjyot Singh Sodhi <
notifications@github.com> wrote:

> Hata hi deta??
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/h4ck3rk3y/goBudget/commit/74b7328b8ba1e07d4bc90f25bee6044d33097caa#commitcomment-13118577>
> .
>


Here is the quote from the forum (by MattDevo):
```
Kodi runs at single fixed output resolution, only the refresh rate can dynamically change. I have more than one customer who prefers 4Kp30 to 1080p60 since everything (including the main UI) looks better. Properly designed skins have no issue at 4K (confluence doesn't).
```


I was just thinking that inside `[[ ]]` globbing is always disabled... man learns whole life...


Thanks, and now I know were to create a pull request if I run in to something else that could be updated.


rax retry tests


again, it makes absolutely no sense running the gui at 4k. I am not aware of any 4k skin and we don't have any quality upscaling for the gui. feeding the tv with lower res and have it upscale is much better.


i like this pattern. maybe remove `Grumble` from the function name.


The variable **previous** is declared twice.


The only suggestion I would have is to only include ```<payment_collection_method>``` when the value is defined, to reduce the request size (if it's already default), and to let the default do it's thing.


tooltip and popover styles both end up with display: block, so my proposed fix should be all that's needed.  I will submit a PR shortly.


great!


@dannyroberts Is this an appropriate handling of datetime conversions, or should I be using an internal library for this?


@martinstreicher You should open an new issue maybe even with a spec? cc: @marshall-lee


Don't tell me :-)

I just implemented what I found on the forums. I can change that commit easily.

What I really wanted to know: Is that code at the right position and are you find with such a setting? Then I would inlcude it an PR it to your master branch.


102817062_MultiSpeedFan (Nigusse) - Win64-Windows-7-VisualStudio-12: OK (1838 of 1838 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


manually created comment


I would also love this to be merged.


@thomaswhyyou: I think we will probably need a Dockerfile.dev at some point for local dev and testing tools. For now, rather than commenting it out, try creating one that is just based on the production Dockerfile.


Does "Copyright 2015 Google Inc." make sense here?


AddStuffToUI2 (kbenne) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-0.0%25-red.svg)


I think you had it right, `0.1.0` is technically where we should start..

> The simplest thing to do is start your initial development release at 0.1.0 and then increment the minor version for each subsequent release.


The test also wants us to verify the picker is closed.  Should we verify that here as well?


looks really good. I like that you are writing a lot of clean code and that you're doing a lot of refactoring on the fly :) if you ever have the chance to review my code please be quite critical :D


Can we just do this in ansible?  In ``playbooks/includes/proxies-redirects.yml`` perhaps?


The trie assumes that there is at least one input version at each branch point. Using NonEmptyMap enforces it. Although the lookup code doesn't directly rely on it statically, it ensures lookup will never fail due to an empty inputs map - which is a malformed tree.


Thanks!


You broke the Eclipse-build. Can you please bring the .project-file back?


I think we said we would not; but I'm not sure, I'll ask @Ombridride.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 550](https://teamcity.labkey.org/viewLog.html?buildId=270758&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:23:00
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

##### there are 20 more failed tests, see build details
```


I'd suggest to document the environment variable option too. Sometimes I work on a laptop with 2 cores and it's a bit annoying if it stops responding while running the tests in the background, so I think I'd like to make it default to 1 without specifying the command line option all the time.


No me gusta mucho la idea de usar una parte de la implementación de modbus. Si bien está pensada para que viendo las interfaces uno no tenga que ir a ver el código (al menos esa era la idea :), creo que es va a a ser mucho más conveniente usar todo el stack. Además veo que no estás previendo llamar a la función ciaaModbus_transportTask()


No, we can use it for decoration. But if it was removed intentionnally in the first place then tell me please.


This is meant to address Issue #28


yes, good name!


This was meant to address Issue #28


i have some bad experience with these kinds of code :D


Thanks. Just for my own edification, is there a reason to prefer
```
if foo
   return x   # or error(), or throw()...
end
```
over
```
foo && return x
```
?
The latter provides better code coverage stats which is why I started using it, but if there's a disadvantage, I'm all ears.


Thanks again, that's helpful!

I assume that this rule also applies on functions that accept error-first callback, so this is the best I can do:

```js
var error = new TypeError('You\'re wrong');

if (typeof cb === 'function') {
  cb(error);
} else {
  throw error;
}
```


ah okay, I did not know that manuel solved it that way. Hmm, I would rather overwrite it, in case that the ribbon is wrong. This seems more robust to me


Typo in commit comment: "tranform" should be "transform"


fixed in bcb72e3128be5c5edcfa495149cf61172e45397d


thanks for the patient commends, very useful. i reviewed it and it is ready to merge.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.467.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62886&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:17:09


Perfect, thank you :)


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 551](https://teamcity.labkey.org/viewLog.html?buildId=270760&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:31
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


Hi @gvanem I see them both declared on the latest openssl version
https://sources.debian.net/src/openssl/1.0.2d-1/crypto/x509/x509.h/
and
https://sources.debian.net/src/openssl/1.0.2d-1/crypto/asn1/asn1.h/
ASN1_INTEGER_set and X509_get_serialNumber are both there..

I don't understand why it fails to use them... @koeppea do you have any clue?


"Torch" needs to be **unbreakable**


@ryantrinkle
Forget this branch
------------------------
I prefer the approach I'm taking in https://github.com/diagrams/diagrams-svg/tree/svg-options


Agreed, I'll refactor that


But lookup doesn't really need this invariant. assocs might.
On Sep 8, 2015 21:10, "Noam Lewis" <notifications@github.com> wrote:

> The trie assumes that there is at least one input version at each branch
> point. Using NonEmptyMap enforces it. Although the lookup code doesn't
> directly rely on it statically, it ensures lookup will never fail due to an
> empty inputs map - which is a malformed tree.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sinelaw/buildsome/commit/6d5e2fa5b789c914269cd705ad3da6d0f1e60227#commitcomment-13118734>
> .
>


The ```this == o``` and ```o == null``` checks are redundant. ```Objects.equals()``` performs them as well.


Yes I agree about the "weird" control flow when writing code in the catch block. Using hasProposalContestPhaseAttribute is the best alternative IMHO. I think I don't really get your last point.
Concluding I would use the method hasProposalContestPhaseAttribute, or did you have some doubts in your last sentence?


Return full status object here


Good but we also need to test throwing exceptions in the following patterns:

Method -> Enter try/catch/finally -> Call sub method -> Enter try/finally -> Throw exception
  -- This should check that both try blocks enter, both finally blocks and the catch block

Method -> Enter try/catch/finally -> Call sub method -> Enter try/catch/finally -> Throw exception :::> Enter catch block and throw a new exception within it
  -- This should check that both try blocks enter, both finally blocks and both catch blocks


The former gives more specific line coverage results since we haven't resolved #11802 yet. The latter's a little shorter and maybe more "idiomatic" depending who you ask, I personally prefer the `if` version since it's more obvious to people who've never seen short-circuiting control flow before.


Nice goin!


The doc comment didn't get updated. The comment's lack of creffing also points to several other things that are wrong.


> Although a RLock is surely more performance friendly

As a side note, using a read-write mutex is only faster than regular mutex in specific situations (https://www.google.com/?q=reader-writer+lock+performance). It's a more complex primitive that may be slower for simple uses. I still prefer to use RWLock sometimes just for readability/expressing my intent better (when the performance isn't a large concern).


What does this method even do? Clearly not answer "IsEndOfLine". Can you add a comment to why this change was necessary?


I added the ability for single line and comperator strings

_sry for reformatting the code beyond_


https://github.com/fritsch/xbmc/commit/a99c93b7ebffcfc695d49daf6c7bb35595a21e00 (as said I don't care and I am fine with either).


org.hawkular.alerts.actions.email.default.from  ?

Not sure if you intentionally left out the ".alerts" segment.  I am OK as-is if that is what you want, I am just making sure it is intentional in this and other property names.


I see little inconsistency in this line.
Maybe you were trying to save some characters and make the line shorter...

Anyway, in line 40 you use explicit syntax to check that pointer is non-null:
```cpp
   while (current != nullptr) { ... }
```
And in this line you use implicit syntax which is in essence
```cpp
  while (current) { ... }
```
Both constructions are valid and have the same effect.
As always, there is no preferred way, it depends on styleguide in codebase where you're working.
The only thing to remember is: **Be Consistent**, use the same syntax everywhere.
This largely simplifies reading of your code by reviewers because they don't spend additional time to parse simple but unexpected constructions.


Could the value ever be 0? in that sense you would be missing this case


Change seems unrelated?


**const**


Same consistency problem. Here and in code below.


Git tip: if you want to edit that commit's title to fix the typo, you may have a look at the [`git rebase --interactive` command](https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase-i).

If you want to try it out, I'd suggest you `git checkout -b dummy-branch` first (off of `convert-to-react`), just in case you mess it up.


`y` on that line is sitll `nil` ;)


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.503.549c1cad9d577108751ddb541318fbce0c37240e](http://build.palaso.org/viewLog.html?buildId=62890&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:04:33


In fetchAll() you looking for:
\PDO::FETCH_ASSOC,
\PDO::FETCH_BOTH,
\PDO::FETCH_COLUMN,
\PDO::FETCH_COLUMN|\PDO::FETCH_GROUP,
\PDO::FETCH_CLASS,
\PDO::FETCH_FUNC.
So, if i use something like this:
$result = $stmt->fetchAll(PDO::FETCH_NUM),
the result will be NULL without errors or \Exception.


Why did you do that? I just bricked my router :(.
It worked fine for me and many others.
Do you have a log of the serial output?
How is the config for tftp flashing?


Oh My! All that configuration a nice, gentle generator could have brought you… ;) ;) ;)


It's obviously good knowledge to build upon though.


OrderedSet supports union know :)


I'm confused why last_sync = now, but assuming that logic is correct, the way to convert from utc server time to display formatted for user (in user's timezone) is `ServerTime(server_time).user_time(tz).ui_string()`.


Wouldn't it be better better, more efficient to do,

```java
return timestamp == that.timestamp && Objects.equals(value, that.value)
```
since timestamp is a primitive. Calling Objects.equals results in autoboxing the values which I don't think is necessary.


I think the real utility would be for running the GUI at 1080p50/60 (and outputting 50/60 i/p content as such), but allowing for dynamic switching and upscaling to 2160p24/30 for all content <= 30fps (or at least for 2160p content)


It would be nice to move this testcase into separate function.
It's pretty big and independent. And most importantly it's **parameterized** (guess what is a parameter here?).
So after moving it to function you will be able to run it with different parameter values in a blink of an eye.


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - i386-Windows-7-VisualStudio-12: OK (1838 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


please provide a code piece showing how exactly you subclass `Mash`.


We need to test more than one field. Use 8 fields of variables sizes with non-repeating bits patterns (i.e. the values they are set to don't result in a repeating bit pattern in memory). This will allow us to test properly for accidental/mistaken memory overwrite.


closing the wormhole now. thx.


Thanks for the feedback. I guess since there's no strong reason to prefer one over the other, I won't go changing all my code yet :)


> I assume that this rule also applies on functions that accept error-first callback, so this is the best I can do

I don't think there's any agreement when it comes to user-errors in callback-style function. I tend to prefer to throw on user input error and pass the error in the callback on other errors.


Thanks!
Could you please run your test code with cuda-memcheck, if you haven't already?
After I merge this, the next thing is to try to modify the convolutional code (start in nnet2) to use the batched operations instead of a for-loop.
Dan


Correct Kernel:Main to the actual ClassName:MethodName


I think we can keep dark ambiance. It's short and breaks game rhythm (sorry)


Have somebody reviewed that?


"declaired" should be "declared"


Euh. Vous avez vu que j'ai fait deux commits ?...


I have no issue with that.


@farfadet46 ...


Change these values so they use large numbers with non-repeating bit patterns. At the moment this test won't actually properly determine if fields are overwriting one another.


Ok, i think it's a nice addition


Ah I see how my last sentence is confusing, I used 'this method' to refer to the first method i mentioned, not the last :P
What I meant to say is this:
I think that `getProposalContestPhaseAttribute` should only be used when you want to use the attribute after getting it. In this case, the exception will be a sign that something went wrong, rather than a means to control flow.
If we want to find out whether an attribute exists, we should use `hadProposalContestPhaseAttribute` instead.

So no doubts. I'll go ahead and implement the `hadProposalContestPhaseAtttribute in the `ProposalContestPhaseAttributeLocalService` and use it here.


Please, extract passed value to a variable named `expectedKey` and put it on `given` section.


synchronization needed?  I don't think so, but just mentioning.


brew install gtk+3 vte3.rb

/usr/local/Library/Homebrew/formulary.rb:252:in `loader_for'
/usr/local/Library/Homebrew/formulary.rb:197:in `factory'
/usr/local/Library/Homebrew/cmd/update.rb:204:in `block in report'
/usr/local/Library/Homebrew/cmd/update.rb:190:in `each_line'
/usr/local/Library/Homebrew/cmd/update.rb:190:in `report'
/usr/local/Library/Homebrew/cmd/update.rb:24:in `update'
/usr/local/Library/brew.rb:124:in `<main>'


Address the cstyle issue.  Also throughout the rest of the code base we've used `((void)0)` for this case.  Technically it doesn't matter but I think declaring them as void makes the header more readable.


Should the file here not changed to `$TRAVIS_BUILD_DIR/resources/browscap.ini` too?


Thanks - I haven't actually changed the error message, just included a description for it here as an example.


Maybe it is worth having the parameters back


J'ai mis des accents car il y en avait plus haut. Je pensait qu'on pouvait désormais :)


am i doing this right?


I am using them. This is to make it easy on you and the user, i'm hiding and then autofilling drop downs when there can only be one choice.


:+1: Going to merge this and pull on verf.


hello humans!!


Okay, that seconds what @FernetMenta says. Then I will implement it as that.


Google monopoly? CM wouldn't exist without the presence of Google. I will relish seeing all of their attempts to pull themselves away from AOSP snap right back and hit them squarely where it counts once Marshmallow is released and they're left scrambling to fix their ludicrous API.
1. They've force pushed countless build-breaking changes through their gerrit because it seems the concept of actual code review has become alien to them. A direct example of this can be seen in the CM gerrit over the last day or so (f2fs tools). Code review is more like skimming the commits to see which sound the coolest and +2, Verify, Push... and point the finger at the submitter when all hell breaks loose.
2. The number of ignored commits that actually accomplish something useful... something, say, as 'controversial' as kexec, or 1440p image recording quality, get ignored and eventually forgotten (though thankfully not by many others).
3. Regarding our ROM being '99%' derivative of CM, get real. I've made it a point to diverge from CM's repositories whenever possible. Case in point: I'm moving away from the CM device tree to a CAF-based tree courtesy of sultanxda, which fixes a lot of those 1+1 bugs people who affix themselves to CM still agonize over. You will find NO cm hw services here, NO live display, NO CM Theme Engine, File Manager, Performance manager, CM superuser (including those annoying icons), WhisperPush, etc. etc. etc. Sadly, the only reason we even bother to use CM device trees for our ROM is because they're pretty much the only game in town... but I'm thinking that's likely to change very soon.
And finally, the commit is reflective of the biggest problem I have with CM.... the overwhelmingly high probability that when we do use a CM repo in our manifest, that it will break sometime before the next release.


cool thanks


good job. sorry for nitpicking but I still have some comments regarding the refactoring.

1. The extracted class is not only used for the task of AutoPromotion. i.e. the method promoteProposal in ContestPhaseLocalImpl is calling a method of the AutoPromoteUtil. Encapsulation could be improved a bit :)
2. One should avoid using too many static classes. This has the advantage that invoked methods do not carry a long list of passed attributes for each method call. Attributes can just be passed to the constructor. i.e. you could instantiate a AutoPromoter object by passing the current date.

I do understand that implementing 2. is not so easy since public methods of AutoPromoteUtil are a bit "mixed" (pure auto promote methods and promote helper methods). One could solve this problem by extracting common public methods from the AutoPromoteUtil to the so-called "ProposalPromoter". Here you could also initialize the object with the current ContestPhase.

Please do note that these comments were just made on-the-fly. feel free to apply some of my thoughts if you want. I don't want to withhold you from other important tasks though.

Your refactoring already contributed to much cleaner code :)


Another good and more expected scientific names would be **source** (**src**) and **destination** (**dest**).

P.S. But I usually also use **from** and **to** during competitions :)


Did you do object arrays as part of Object tests?


Was this causing issues on `Swift`?


Yeah I'm -1 on that. WARN was a good thing IMO.


We should test even more in this case: it should not only call dao but also return a value that dao has returned.

See this test as example: https://github.com/php-coder/mystamps/blob/master/src/test/groovy/ru/mystamps/web/service/CategoryServiceImplTest.groovy#L264


AddStuffToUI2 (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2302 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.5%25-yellow.svg)


int? Why wasting space?


Added tests which:
 - Pass a struct as an argument
 - Pass more than one parameter - use 6


Why have you renamed all of the shouldNotXXX tests to shouldXXX? The former method names are clear IMO in terms of specifying allowed behavior. Maybe doAllowXXX or doNotAcceptXXX is more clear than shouldNotXXX.


ah okay, clear now. thanks :)


Just in case a new enum is added I like at the end of a switch:
  default : throw new IllegalArgumentException(d.getType().name());


How about range-based for here? Seems like a perfect use-case.


^beautiful haha. that's what I get for not rtfm


oh nice


very good


For readability, maybe use switch( conditionEval.getType() ) {...


I actually asked Daniel to fix those,

Just replace it with
```
{{ '${ui.message("adminui.purge")}'.replace('{0}', visitAttributeType.name) }}
```


DVCS-2 #comment adding a comment on the commit


I addressed your issues in reverse chronological order (from top to bottom), which was a mistake.  But yes this looks right now.


5110_stdbaropress_sealevel (mjwitte) - x86_64-MacOS-10.9-clang: OK (1813 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.91%25-yellow.svg)


is this just clearing this value?


so awesome he is my favorite.


Why is this <= 12 now?


I'm not sure that it will work because `TestObjects.createUsersActivation()` creates new instance each time. Instead you could assign activation from `TestObjects.createUsersActivation()` to a local variable, after that stub DAO method to return that activation and at the end compare them with `==` operator.

If they don't implement `equals()`/`hasCode()` properly, it doesn't matter for us because we may compare them by reference.


Why do we need a synchronized map? Why just make it immutable?


This has broken the aggregate builds.

[ERROR]   Missing requirement: tern-feature.feature.group 1.0.0.201508302102 requires 'minimatch.java 0.0.0' but it could not be found


This name is a bit vague. It's not obvious what it refers to and function is pretty long.
I would go with **requiredEdgesNumber** and **generatedEdgesNumber**.


Really quick work! Thanks again!


Yes, absolutely. Sorry for missing that.


QString() not QString::fromUtf8("")


This doesn't seem to fix it.


return QFile::exists(d->user->iconFile()) ? d->user->iconFile() : QString();


# Marlin RAMPS
Firmware for Prusa I3 Mendel 3D printer, with support for RAMPS Board v1.1 and above. Multilanguage firmware with several axis settings.


Just replace it with
```
{{ '${ui.message("adminui.retire")}'.replace('{0}', patientIdentifierType.name) }}
```


This may be a bit too specific.  It currently fails on my computer.


We already thought about that but also want to support those two specific signatures at this time.
Besides that, I'm not sure if we want to officially support 32-bit builds but I think it helps to not break them on purpose.


We should stick with ImmutableMap here. As this [stack overflow post](http://stackoverflow.com/questions/22636575/unmodifiablemap-java-collections-vs-immutablemap-google) explains, an unmodifiable map can still be changed. An ImmutableMap however results in a new copy of the original map that really is immutable.


Done https://github.com/MinetestForFun/server-minetestforfun/commit/3a2598c400b301b0bdd5d9fb04d702c8f5fc23c3


This line is unnecessary.


AddStuffToUI2 (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


This can be simplified with range-based for or with function std::find from STL
Minimal example:
```cpp
   std::vector<int> v = {3, 1, 5};
   if (std::find(v.begin(), v.end(), 1) != v.end()) {
     std::cout << "1 found!" << std::endl;
   }
```
Details here: http://en.cppreference.com/w/cpp/algorithm/find


Closes #21


The leniency is not coming back. I don't care how people feel about it. This has security implications.


go for this atm. later we need the sledgehammer anyway :) that part of the app is a very good example for the typical xbmc/kodi spaghetti code. refresh rate switching is deferred: player configures renderer with the parameters of the content. At this time everything is clear and could be set up properly but:
- player continues player
- rendermanager instruct renderer to configure
- renderer thinks about a resolution
- some time later rendermanager checks if renderer wants some change in resolution
- graphicsContext is instructed to change the res
- player could be paused upon a stupid setting
- resolution switches and hw decoder may fail on the event
- HDMI audio has no fun either
- finally resolution has switched and playback starts with some stuttering after decoder has recovered

that was only scratching the surface. in real live it is even worse.

why not taking the easy way: player needs to configure video/audio rederer. It stops playback, does the configuring, waits until completed, continues playback.

you see, lot of work ahead :)


bridge.js is set as the phantomScript in tasks/htmlSnapshot.js (https://github.com/cburgdorf/grunt-html-snapshot/blob/d4591e240c27fbbfaea99e791a41967acd748b13/tasks/htmlSnapshot.js#L104). Therefore, you do not need to run this script manually. It will be ran whenever you start the htmlSnapshot task.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 552](https://teamcity.labkey.org/viewLog.html?buildId=270782&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:10:41
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


TeamCity pull requests :: netty [Build 186](https://garage.netty.io/teamcity/viewLog.html?buildId=1223&buildTypeId=pulls_netty&guest=1) is now running


Yes you are right! I'll fix this soon


Maybe some constants for the supported context properties to make it clear what props are supported/processed?


In the ticket, I proposed specifying the retention as a string that in the format handled by Converter. Rather than ```[gauge: 45, availability: 30, counter: 13]``` we would have ```[gauge: "45d", availability: "30d", counter: "13d"]```. The reason I suggested that is it gives us a way to easily add support for durations while reusing existing functionality.


Solution: https://github.com/jbosstools/jbosstools-jst/pull/522


Hurry up Trent


Even if not supporting 32bit builds, I think uint64_t would be more explicit as sized type than size_t.


You have Voltage Control?


Hehe - I sent you a PR. Thanks for that insight.


Oh yes, thank you for finding it out! 😭


Update generateUniqueID to conform to the spec length. Spec here https://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf
> 1.3.4 ID and ID Reference Values
> This requirement MAY be met by encoding a randomly chosen value between 128 and 160 bits in length.


Comparing a pointer 'qtc_temp_ptr' against an integer (0) is wrong.
And how can the pointer be less than zero. That makes no sense.


@10se1ucgo Yes, including that :smile: no problem, I'm sure we can easily merge them if necessary. I'm working on the registry issue currently, I think I almost got it (so that we can edit the WD regkeys finally)


I had fixed this on my branch.


I think, this is still incorrect. `_.escape` is also needed, because `string` is escaped. The correct version should be `new RegExp(_.escapeRegExp(_.escape(link.text), 'g')`


Fixed on my updated branch.


@rafabene : Do the WildFly quickstart POM files now include the repositories? If not, this link is incorrect.


@geoffscott: Understood. I've just added Dockerfile.dev now, that is identical to the production Dockerfile for now as you suggested.


Do you think it is worth being a bit more explicit about the type of exception or the message we expect?  My fear is this kind of blanket catch could in future catch other exceptions and we'd never know it was broken


**Eslint**: 'return' outside of function


Some weird indentation / tab issues going on from this point forwards


Do you think this message will be helpful in the future?  I think we are too verbose with a lot of our logging, so if you don't think it'll be useful in future debugging then I wouldn't log anything here.  Also you misspelled "Invalid".


Let's use python2.7. I can't install progressbar for python3


Hm that's an interesting question. `currentProposalVersion` can't be null, as `countByProposalId` returns a converted primitive type int, which is automatically wrapped in a Long. But since it's a count method, it should be zero when the proposal isn't found, not < 0.
In summary: you're right, I'll make it <= :)


If opening the QTC_META_LOG failed in line 56 which sense does it make to write to that fp - it contains a NULL ?


kkk


I didn't notice until reading this thread that underscore is common in Monocle, but I guess it is.
I've always used no underscore; the `@Lenses` macro can prefix with underscores (as in the examples) but the default is no prefix.


@ericmandel: I was too keen at decoding bites. I've added a boolean ``decode`` option to ``self.get`` to be able to decide where to decode the output of xpa* functions or not. Usually it should be decoded, except when you want to get arrays or fits files: in that case the decoding is done by numpy and astropy.


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (lgu1234) - x86_64-MacOS-10.9-clang: OK (1833 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This is a bit broken -- there's no `else` case to define `bins` when `libname is None and not is_cygwin`.

```

    if libname is not None:
        # Use basename here because Python returns full library path
        # on Mac OSX when using ctypes.util.find_library.
        bins = [os.path.basename(libname)]
    elif is_cygwin:
        bins = ['cygusb-1.0-0.dll', 'cygusb0.dll']
>   binaries = _resolveCtypesImports(bins)[:1]  # use only the first one if any
E   NameError: name 'bins' is not defined

..\..\..\..\..\documents\pyinstaller-git\PyInstaller\hooks\hook-usb.py:47: NameError
```


The NUOVERSION should be set to 2.3.1.14, this variable is used to grab the nuodb package (check line 28/29).


@andreshp Comprueba que no haya machacado mucho el párrafo, lo he hecho principalmente por juntar las dos primeras frases.


If nbyte is 0, write() will return 0 and have no other results if the file is a regular file; otherwise, the results are unspecified.

from http://pubs.opengroup.org/onlinepubs/7908799/xsh/write.html

i think we need an explicit ftruncate here.


test from curl


preferably with a revision bump, so users get the update dependency


this broke the exporter because `constants.AREA_LIGHT` is still referred to in https://github.com/mrdoob/three.js/blob/master/utils/exporters/blender/addons/io_three/exporter/object.py#L112


I don't think we need this file in our repository.


Yay~~~ Also you didn't used the right texture, that one was the IDSU one, the AESU one have a third slot were you can configure the output, but you can always add that in the black box ^^


Why do you need **this** here?
Inside member functions you can access class object fields without using **this**.
Possible cases when you probably need to use it are:
1. You have variable name clash (collision) between say function parameter and class object member **data**.
2. You want to store pointer to **this** in some external object.
3. You want to resolve some ordering based on address of your current object.


Still, please use tab characters instead of using spaces.


test from curl 3


We should document the Elasticsearch native APIs, not our wrappers.  Also the states for check_state are incorrect, I suspect that method needs revising


Right. I'll have a look at all your comments on `equals` methods tomorrow. I haven't touched their implementation IIRC, only reformatted.


One nice trick from my olympiad past: you can eliminate **memory** variable and replace this construction with
```cpp
   value /= 10;
```


test from curl 5


two changes actually:

-use THCudaTensor_data(self) and THFloatTensor_data(src) instead of this, otherwise this call will crash when attempting to copy to/from an empty tensor
-the stream that is being used in this call is for the current cutorch device, whereas I think the copy should be ordered wrt the stream on the device that `self` is on. Should get the device form self if any (could be an empty tensor) and use that stream instead.


It doesn't include. Any tips what link should I use here ?


test from curl zang


I think this might be an issue with filling out form fields. I made [some changes here](https://github.com/learningequality/ka-lite/commit/5566f7c5f51d909ab0198282aaa6a7b03c681eaf#diff-bde37810880ca8c8ffa2df6c7ca804d5R88) to try to shed light on why this fails. Seems like sometimes the input destined for one field is sent to another instead, for reasons I have yet to determine.

Perhaps the changes you made [in this commit](https://github.com/rtibbles/ka-lite/commit/ed86d12c8d17da233129857bd9e393da2123b393#diff-7e821e9889f854110c6afd69917ef7daR44) could apply also to `fill_field` here? Basically we want to make extra sure the input is being sent to the right field.

I also suggest cherry-picking that commit.


similarly here


@dotupNET this is probably a problem with an older CMake, what does ```cmake --version``` say?


This breaks subtitles playout and as far as I can see doesn't solve anything. I prefer the have old youtube ids in the filename as you can alway go back to original video.

If you prefer some sort of clarity after the download just add `--co` flag and your files will be sequenced at the end of the download.


zlonk sock


My mistake, didn't see the flag being set on first item found. The logic isn't the easiest to follow.


I removed the 3rd slot because the buttons were in the way. How was it done in old GT?


I wonder if repoman could help with such things, e.g. it could check if global scope variables are unused (either in the rest of the global scope or in function scope).


It's a mistake. It should be `unmodifiableMap`


rax retry tests


Nice program I like how you organized your if statement. I would have personally used the switch function, but the program works and does what it needs to do.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 553](https://teamcity.labkey.org/viewLog.html?buildId=270787&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:22:55
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 20 more failed tests, see build details
```


Okay! Done in https://github.com/openmrs/openmrs-module-adminui/commit/c2568ef14f482a49b17df36edfaf274de163cbb6


Thx for alphabetizing. Is the deletion of the cellprofiler/cpmath/build exclusion intentional?


Причина, почему приходится это делать: http://web.archive.org/web/20120718183019/http://devedge-temp.mozilla.org/viewsource/2002/table-inherit/

Альтернативно, можно использовать решение, предложенное по ссылке:
```css
/* Rule to fix quirks-mode inheritance behavior */
table, caption {
  font-size: inherit;
  font-weight: inherit;
  font-style: inherit;
  font-variant: inherit;
}
```

Не знаю, что лучше, если честно.


Fixed in https://github.com/openmrs/openmrs-module-adminui/commit/edb4845015eeca87a490f8a919845134bedecef6


LGTM


Better and cheaper replacement for TextExpander.


I don't see a testcase where
```cpp
   headIsCreated == false
```
Moreover, remember that function variables may be initialized with some random trash values from stack if they don't have constructors. And in your case pointer type has no default constructor.
It's always safer to initialize pointers with **nullptr**. Not so difficult, right?


Used it here: https://github.com/openmrs/openmrs-module-adminui/blob/master/omod/src/main/webapp/resources/scripts/metadata/manageVisitAttributeTypes.js#L26


@joerg555 nice one, however i am trying to get a "clean solution" that inlines both on msvc and gcc... i am giving it a try here: https://github.com/acplt/open62541/commit/61c155f1f850b639424b9657013d1356bf2d3d01


in the old GT you had 4 more buttons with a +64 +1 -1 -64 eu packets option, though it would be nicer if you could simply type in the number you want from 1 to 2048 ^^


This looks wrong.  The default uri is now the bulk endpoint, even if isBulk is false.  Am I missing something?


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.44.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62896&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:34:31


This is likely to suffer from the same issue as the previous test


I thought MONO_API did handle that.

Won't other API entry points suffer from the same issue?


1579840-GroundTemps (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1839 of 1849 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.46%25-yellow.svg)


So player will be able to keep maximum 10 different types of each item?


These tests are difficult to read. Try some logical formatting, for example:
```cpp
  CHECK_EQUAL(
      ListToNumber(SumListsAsNumbers(
          CreateList({9, 9, 9}),
          CreateList({1}))),
      1000);
```

No one cares about the number of lines. Readability matters!


```cpp
  #include <cmath>
```


Oops the ```i``` var should be set to -1 instead of 0


Yes Peter, I will do that as soon as I can spare some time, but no later than Sunday this week.

Thank you for letting me know.

Date: Mon, 7 Sep 2015 03:55:12 -0700
From: notifications@github.com
To: pdns@noreply.github.com
CC: tripivceta@hotmail.com
Subject: Re: [pdns] Fix boost detection on SunOS (thanks @UX-admin) (4c8049e)

We need to move this discussion to a ticket so we don't forget it. Can you do that please?

—
Reply to this email directly or view it on GitHub.


not used


This one couldn't be also `inline`?


si usan modbu deben usar la capa superior, no la mitad nadie asegura portabilidad a futuro si usan la mitad. la interfaz que gustavo promete a partir de diciembre como estable y version 1.0.0 es la capa superior. NINGUNA capa intermedia esta asegurada a largo plazo... :(


This has been fixed. I still have a few magic numbers but i'd like to get this merged. Will fix the rest next week.


Without calling this twice there is a 20 deg/s offset still present


What about having operating system here?


Status should be the last column.


Related doc update: https://github.com/NetLogo/NetLogo/commit/5c70b496ff9feea59af2ba212afef059e2d0249d


TeamCity pull requests :: netty [Build 186](https://garage.netty.io/teamcity/viewLog.html?buildId=1223&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:29:47


We're getting `Uncaught TypeError: Cannot read property 'superProperties' of undefined` with this change.  I assume this is because `indentify.integrations()` returns something falsey above.  So `opts[this.name]` is `undefined`.


Can inherited classes access *not protected:* members?


This line shouldn't be in there ;)


Read status bit, so wiring of DRDYG wire not required


@montefra Great, we're now on the same page about the problem ... that said, I hate to force the user have to remember to set decode to false when calling get() on "fits" or "array". Do you think we should add to get() a list of access points for which the decode would be turned off? Otherwise, it's guaranteed that users will forget to do this, and accidentally end up with changed pixel values -- without knowing that it has happened. Since the "binary" access  points are known, we can just do this automatically and avoid any confusion.

The list would be: "fits", "array", "mosaic", "mosaicimage" ... but I'd have to ask Bill Joye to make sure.


Read status bit, so wiring of INT1XM wire not required


You're right - fixed and pushed.


I think we should only be using a single row of text in the listing before we open a panel.


Read status bit, so wiring of INT2XM wire not required


QDataStream stores primitive data types in simple BigEndian byte order and can be optionally set to LittleEndian. There isn't used any proprietary encoding.


I think perhaps a second tab for "Capacity" information would be good. It's a separate distinct sort of information.


Aha, ok, I know what you mean now. I had some problems with with template functions and classes when I used `( )` brackets.


Add SI Range procedure


We need to put all the status details, more information about the address, and the version info. I can try and mark the things here that we should include:

```
                "conditions": [
                    {
>                        "type": "Ready",
>                        "status": "True",
>                        "lastHeartbeatTime": "2015-09-08T19:20:57Z",
>                        "lastTransitionTime": "2015-09-08T14:26:22Z",
>                        "reason": "kubelet is posting ready status"
                    }
                ],
                "addresses": [
                    {
>                        "type": "LegacyHostIP",
>                        "address": "127.0.0.1"
                    },
                    {
                        "type": "InternalIP",
                        "address": "127.0.0.1"
                    }
                ],
                "nodeInfo": {
>                    "machineID": "00536f8268d34e818bf3276a862cc67a",
                    "systemUUID": "",
                    "bootID": "d28cb3ec-9caf-4359-bf7e-dad6787797de",
>                    "kernelVersion": "4.1.6-200.fc22.x86_64",
>                    "osImage": "Fedora 22 (Twenty Two)",
>                    "containerRuntimeVersion": "docker://1.7.1.fc22",
>                    "kubeletVersion": "v1.1.0-alpha.0.1588+e44c8e6661c931",
>                    "kubeProxyVersion": "v1.1.0-alpha.0.1588+e44c8e6661c931"
                }
            }

```


Should annotations be a separate tab (when present)? We would need to be consistent between all of the different kinds of panels. What do you think? Or is underneath Labels the right place on all the panels?


@vsergeev thank you very much. Glad to hear you're enjoying using profanity, the new release will be out soon, just a bit more testing and documentation to complete.


@alexcrichton aha! thanks for fixing my typo.


Fixed and pushed.


Add a new column to the container databases for expiration date (better to be specific)


no problem :smirk:


This while/condition looks wrong as seq doesn't change in the loop.


This line can be deleted. set_user_pass calls update anyways.


Why is the logic here in the `PaymentsAdvanced.pm` class?  It seems like something that only the FromSilentPOST class should know how to do, not the parent class.  It seems like we're breaking encapsulation..

Is it because we don't want the `::PayPal` and `::CreditCard` methods to inherit this method?  Maybe there should be a factory class here?


> Enjoy new better "Shadow Labyrinth"

The changes look very promising! Thank you for all your efforts (and TBC love)!


@alikins I was workin on this already :(


This is a broken link


This looks like a change which only modifies white space. I generally don't accept changes that only modify white space because they make it more complicated to read the changes later.  Could you remove this white space only change?


You're both right. I haven't done a good job at giving consistent example. As @refried pointed out, if there is a default, it should be no underscore since it what `@Lenses` use.


> We already have "comments" that have semantic value elsewhere in the protocol. It doesn't seem such a stretch to me.

Not really, or at least I never considered directives to be comments.

> What other outputters have indented child tests?

Current Test::More alpha seems to allegedly an outdented comment, @exodist should know more.


iojs rather.


Update endpoint in QueryDocumentAuditLog.properties file to point to DQ. Currently it points to DR ActiveParticipant_Dest.@UserID=http://localhost:8080/Gateway/DocumentRetrieve/3_0/EntityService/EntityDocRetrieve


in the account database.


MONO_API is for shared libraries, the test tries to look up symbols in the runtime executable which runs it.
So its not a common use case.


How does this work if your password contains an `&` ?


Autsch :-( I'll fix this fix immediately.


it won't send a DELETE- it weill just delete it. i'd mention how slow auditor passes means you will have extra data in your system until they get processed.


ugh


makeRunFilenameRegex could probably be rewritten as parseFileName, which returns data class with port, name, etc

Passing group as function parameter and matching on them is error prone, I think.


LGTM


Don't we already prevent `.json`?


TeamCity pull requests :: netty [Build 187](https://garage.netty.io/teamcity/viewLog.html?buildId=1224&buildTypeId=pulls_netty&guest=1) is now running


An assertion "port in range(START_PORT, END_PORT)" could be useful.


LGTM, if it works.


No point in logging the hash if its zero. Consider moving inside the if statement and adding an assert or using a different message if its empty.


Here's another case of us duplicating the logic that should be encapsulated in the class


We should also recalculate the requirements for ram, since obviously it uses MUCH less then that. CPU seems pretty good.


Once the new feature is in place, you could just allow the existing daemon to just run its course and when the .expiring_objects account empties, just stop running it. However, a migration script will be provided (probably) that will populate the new column in the containers with the expiration dates.


4695_hpwh_equip_seq_num (mjwitte) - x86_64-MacOS-10.9-clang: OK (1833 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Done https://github.com/MinetestForFun/server-minetestforfun/commit/4a3c583194c28000e7d19f379ab4dcfcf8ed8227


Should I be using @post.comments.new here? I'm having trouble with 'Save' on this form as well. I can't save a comment.


Yeah but I've had it for a while


I believe, it's good to use full names for parameters. I can guess that `ts` is `timeStamp`, and `esc` is escape, but not sure.


:+1: for ugh


contains spelling mistake


 Three changes:
1- Changed naming convention to non-underscored private class fields
2- Removed Setter for BlurAmount property (it is never used)
3- Changed approach of getting value from configuration PropertySet: Now uses TryGetValue() instead of ContainsKey().


>typecasts
>uses colon anyway

AAAAAA


the `if (time)` conditional probably doesn't do what you think it does. It doesn't do what I thought it would do:

````
[matt@imac27] ~ $ node
> var t = setTimeout(function () { console.log('timed out'); }, 30 * 1000);
undefined
> if (t) console.log(t);
{ _idleTimeout: 30000,
  _idlePrev:
   { '0': [Function: listOnTimeout],
     _idleNext: [Circular],
     _idlePrev: [Circular],
     msecs: 30000 },
  _idleNext:
   { '0': [Function: listOnTimeout],
     _idleNext: [Circular],
     _idlePrev: [Circular],
     msecs: 30000 },
  _idleStart: 163561681,
  _onTimeout: [Function],
  _repeat: false,
  domain:
   { domain: null,
     _events: { error: [Function] },
     _maxListeners: undefined,
     members: [] } }
undefined
> clearTimeout(t);
undefined
> if (t) console.log(t);
{ '0': null,
  _idleTimeout: -1,
  _idlePrev: null,
  _idleNext: null,
  _idleStart: 163561681,
  _onTimeout: null,
  _repeat: false,
  domain:
   { domain: null,
     _events: { error: [Function] },
     _maxListeners: undefined,
     members: [] } }
undefined
````

Moral of the story: the `if` does nothing, and you might just as well always call clearTimeout.


`a single or multiple objectives` sounds a little weird because of the `a`.  It's probably grammatically correct, but it would be more idiomatic to do `one or more objectives`.


OK thanks, now I get it, how much is Arastta different from stock opencart software and what about installing outside extensions and mod, bothe vq and ocmods will it run without any issues and main thing why I asked this question in the first place, is the curl problem solved in this Arastta edition.
Thank you for your time.


AddStuffToUI2 (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2317 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.14%25-yellow.svg)


from **the** manufacturing industry


@VladimirMangos A gentle reminder: the issues are in a separate repository these days, so you need to write cmangos/issues#741 to have a working link.

No big deal, I forgot this a few times too in previous commits, so this serves as a reminder for myself too :smile:


Out of curiosity, was this core update needed for some new API?


either `capabilities have` or `capability has`


5110_stdbaropress_sealevel (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1819 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.91%25-yellow.svg)


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.957.c8360421d1954385a3ccc7fabe72ba56da4f7160](http://build.palaso.org/viewLog.html?buildId=62904&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 504, ignored: 6 Build time: 00:05:31


you should initialize this in __init__, otherwise you'll get an AttributeError, right?


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 554](https://teamcity.labkey.org/viewLog.html?buildId=270796&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:23:02
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

##### there are 20 more failed tests, see build details
```


Noted.


Probably want the base class to implement fetchone, even if it just raises a NotImplementedError


I'd make all three items in the list of the same form, by changing `with the X as Y` in the first one to `the X is Y`.  So now they all read the same way and it flows a bit easier for the reader.


Ok


Done.


What is a "permutation route"?  Ignore this if I'm just dumb and your audience would know :)


There could be the case of the slope is null and there is still an intercept.
I would put this second condition at the first level as well.
You should deal with the space that should be added if this.slope is not null.
If this.slope is null and this.intercept is null ... y(x) = 0 should be displaced I think


No, it slipped through in the commits actually, but I do tend to try and track the LTS releases.


> ASN1_INTEGER_set and X509_get_serialNumber are both there..

That is not the problem. The problem is that in OpenSSL's current version, the `X509_extension_st` is hidden away in [crypto/x509_lcl.h](https://github.com/openssl/openssl/blob/master/crypto/x509/x509_lcl.h). (`X509_EXTENSION {aka struct X509_extension_st}`).

We're supposed to use the opaque structure and not access the `value` inside it. Ref:
`typedef struct X509_extension_st X509_EXTENSION;` in a recent [`openssl/x509.h`](https://github.com/openssl/openssl/blob/master/include/openssl/x509.h).

What OpenSSL is sources.debian.net? Doesn't look official.


WTF tabs


I get what `extend` does---somewhat similar to Ruby's. What I am asking is to maybe (unless this is idiomatic JavaScript) into something with better variable names (at a minimum) or even with named functions defined for the different cases... this is minor for now and I wonder if others reading this statement feel it could be more legible. Thanks.


Whats the error/issue you see?


Nice. Thanks for update.


I'd remove the first comma, `Note that once an operation is started it must be completed uninterrupted, i.e., pre-emption is not allowed.`


Shouldn't it be...
(add-hook 'completion-at-point-functions 'ess-filename-completion nil 'local)


But what does it mean the sample rate is incorrect? Can audiotools not work with some sample rates?


@samphippen please don't use my handle :) thanks!


Nope. I just saw a new button and was curious as to what would happen if I pressed it. :)


I'm not 100% sure what "sequence dependent set-up times" are.


Props to @tschaub for finding this. Just chiming in that the incriminating line is likely `opts = opts[this.name]`, because the previous `var opts = identify.integrations() || {}` is handling falsy values and guaranteeing an object.


First commit!


Done! I thought the .project was mine only and shouldn’t be there. Isn’t it something IDE related?

Abel

From: Volker Stolz [mailto:notifications@github.com]
Sent: Tuesday, September 8, 2015 8:12 PM
To: abstools/abstools
Cc: Abel García Celestrin
Subject: Re: [abstools] Update Contract Inference for Deadlock Analyzer (774cff4)

You broke the Eclipse-build. Can you please bring the .project-file back?

—
Reply to this email directly or view it on GitHub<https://github.com/abstools/abstools/commit/774cff442247955ed895154c825343fe1b3d513a#commitcomment-13118748>.


Could this be related to this bug? :)
http://haxeflixel.com/forum/?place=msg%2Fhaxeflixel%2Fj3RnXYFPTuo%2F5yooPGDgeUIJ


remove the `then`


Hmmmm I was planning to use these in the master's implementation of JNLP3:
https://github.com/akshayabd/jenkins/blob/e9f5caa13fa1a3d1bf602ec9d67dac75f3310889/core/src/main/java/jenkins/slaves/JnlpSlaveAgentProtocol3.java

It needs access to constants in Jnlp3Protocol, JnlpUtil & the Ciphers (since it needs to create them as well).


Hi Stephanie,

thank you very much for pointing me in the right direction.

I implemented Kahrs version in Java. Here is the current result:
https://github.com/javaslang/javaslang/blob/master/src/main/java/javaslang/collection/RedBlackTree.java <https://github.com/javaslang/javaslang/blob/master/src/main/java/javaslang/collection/RedBlackTree.java>

An existing Haskell implementation by Kazu Yamamoto helped me regarding the delete method (see Haskell version of Stefan Kahr's algorithm <https://github.com/danieldietrich/llrbtree/blob/master/Data/Set/RBTree.hs>).

Sincerely,

Daniel

> On Aug 11, 2015, at 3:27 PM, Stephanie Weirich <notifications@github.com> wrote:
>
> Hi Daniel,
>
> I have found Matt’s implementation of delete simpler to understand than Kahrs (though see Andrew Appel’s version of Kahrs too (https://www.cs.princeton.edu/~appel/papers/redblack.pdf).) Part of that is due to Matt’s clear write up of the algorithm in his blog: http://matt.might.net/articles/red-black-delete/
>
> However, Matt and his student benchmarked both his version and the Kahrs version and found the latter to be more efficient. See: http://matt.might.net/papers/germane2014deletion.pdf
>
> Best,
> Stephanie
>
>
>
> > On Aug 10, 2015, at 6:50 PM , Daniel Dietrich <notifications@github.com> wrote:
> >
> > @sweirich Hi Stephanie,
> >
> > thank you for sharing the delete algorithms for Red Black Trees. I'm about to implement a Red Black Tree in Java 8. However, the delete method is still missing.
> >
> > Please let me ask one question: Which solution for delete do you recommend, the one from Stefan Kahrs or the one from Matt Might. Both, conciseness and efficiency, are important for me. In Java, we cannot take advantage of GADT's.
> >
> > I'm about to give the algorithm of Matt Might a try but am also curious (without having dived into it, yet) how Stephan Kahrs algorithm does compare to it.
> >
> > A little hint would be great.
> >
> > Thanks in advance,
> >
> > Daniel
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/sweirich/dth/commit/b888942f33425a871d46105862683e8950d15b23#commitcomment-12640115>.
>


I'd say "**The** starting time" here.  What you is correct, but it's a little jarring because "starting" is also a verb and I started parsing the sentence in that sense and had to start over once I realized my mental stack was borked.  English is an awful language.


Right. I think it makes sense though to keep `unmodifiableMap` calls when creating JAX-RS model classes because it avoids unnecessary copies (we know the lists or maps built by Jackson won't be used anywhere else so an unmodifiable view is enough).


Hey @FooBarWidget , can you tell what exactly was enhanced, and how can I benefit from this improvement? Thanks!


the case without slope is handled in the `else` just below. There is a testcase with constant y for it. The same code path should handle y(x) = 0.


My merge deleted the change I made to this after I spoke to you. Updating now.


Updated with a one line of code implementation.


Indent


Indeed sorry, just not the way I do it usually.


Not needed?


Here the printing should have a preceding new line so that the output matches the regular 'ls' output.


Consider:
          closeTime = replay->closeFlags_ & sLCF_NoConsensusTime ?
            0 : replay->closeTime_;


I think `all_of` should still short circuit on the first non-space?


Consider:
closeTime = replay->closeFlags_ & sLCF_NoConsensusTime ? 0 : replay->closeTime_;


I don't know if the allow daemon running is a valid solution considering the objects could be expiring a long time out from when the object expirer's pass is occurring. I foresee the script being the more optimal solution.


This is a fix for https://github.com/linode/docs/issues/282


Le 08/09/2015 20:52, jsanda a écrit :
> In the ticket, I proposed specifying the retention as a string that in
> the format handled by Converter. Rather than |[gauge: 45, availability:
> 30, counter: 13]| we would have |[gauge: "45d", availability: "30d",
> counter: "13d"]|. The reason I suggested that is it gives us a way to
> easily add support for durations while reusing existing functionality.

Sorry, I totally missed that part.

I won't be able to reuse the converter because converters work only with
JAX-RS header/query/path parameters. It shouldn't be too difficult to
add a Serializer/Deserialize though.


These are just using our API, we'd need to move the native stuff to the ES section, under the examples there. Which are currently non-existant.


The second sentence here is a fragment, you could combine the two with a comma or parens:

> Construction heuristics are designed in such a way that it limits the search space in a logical manner, preferably without excluding the true optimum.

or:

> Construction heuristics are designed in such a way that it limits the search space in a logical manner (preferably without excluding the true optimum).


Hurr durr. Yes, you're right.


Here are some examples:

1. Sinatra:

  ```ruby
def options
      warn "Sinatra::Base#options is deprecated and will be removed, " \
        "use #settings instead."
      settings
end
```

2. Rails:

  ```ruby
def symbolized_base_class
      ActiveSupport::Deprecation.warn('`ActiveRecord::Base.symbolized_base_class` is deprecated and will be removed without replacement.')
      @symbolized_base_class ||= base_class.to_s.to_sym
end
```

  with a whole deprecation framework of course, but the default `Deprecation.warn` is implemented as `$stderr.puts(message)`.

3. Thor:

  ```ruby
def invoke(name = nil, *args)
      if name.nil?
        warn "[Thor] Calling invoke() without argument is deprecated. Please use invoke_all instead.\n#{caller.join("\n")}"
        return invoke_all
      end
      ...
```

4. Mail gem:

  ```ruby
def register_for_delivery_notification(observer)
      STDERR.puts("Message#register_for_delivery_notification is deprecated, please call Mail.register_observer instead")
      Mail.register_observer(observer)
end
```

I vote for a simple `warn` call (a-la Sinatra or Thor) when the file is required (I hope we don't have any of those experiment code traces in the main files like hamster.rb / enumerable.rb etc).


You probably need to modify the old instructions here: https://github.com/jboss-developer/jboss-developer-shared-resources/blob/master/guides/CONFIGURE_MAVEN.md.  You probably also need a settings.xml file like we had in the JBoss EAP quickstart directory.

Do you know what repositories they need? I can try to create something locally for this.


What happened here?


Right ...I'm saying I don't think the public ES API is fully correct atm, I wouldn't document it until it is.  And anything that can obtained via the native ES API we should have folks use native instead (trying to avoid the issues we've had with MongoDB CRUD in APIv1)


just wondering if it should be `y = ` here...


I expect this to be a little controversial, but some of those variable names
were far too cryptic for my tastes. Even if this patch isn't the final answer
(and I expect it won't - making compromises is something I'm expecting), I was
starting to be bothered by symbols that were mangled words.


Because the check for calendar->get(ERA) == era was moved before the call to calendar->add(MONTH, 1).

Before, the code would special case Jan 1, and short circuit.  But now we are doing the ERA check at the beginning of the loop, and adding the month at the end of the loop.  This means in order to cover the whole month of December, we need to iterate 13 times (i==0 for Jan 1, i==1 for Feb 1, ..., i==10 for Nov 1, i== 11 for Dec 1, i == 12 for the following Jan 1).


That I don't know---someone will need to do a little more digging into the library to diagnose exactly what's going wrong. As far as I can tell from the documentation, this should always work as long as the RG instance is created with the same sample rate as the audio file, which we do.


Entry point changed for image to work. it was giving exception below

System.InvalidOperationException: Unable to load application or execute command 'project.json'. Available commands: web, kestrel.
  at Microsoft.Dnx.ApplicationHost.Program.ThrowEntryPointNotfoundException (Microsoft.Dnx.Runtime.DefaultHost host, System.String applicationName, System.Exception innerException) [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.ApplicationHost.Program.ExecuteMain (Microsoft.Dnx.Runtime.DefaultHost host, System.String applicationName, System.String[] args) [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.ApplicationHost.Program.Main (System.String[] args) [0x00000] in <filename unknown>:0
--- End of stack trace from previous location where exception was thrown ---
  at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw () [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Runtime.Common.EntryPointExecutor.Execute (System.Reflection.Assembly assembly, System.String[] args, IServiceProvider serviceProvider) [0x00000] in <filename unknown>:0
  at Microsoft.Dnx.Host.Bootstrapper.RunAsync (System.Collections.Generic.List`1 args, IRuntimeEnvironment env, System.Runtime.Versioning.FrameworkName targetFramework) [0x00000] in <filename unknown>:0


Exposed 5001 port as well


Travis is currently reporting 2.0 branch instead of the master branch.


I was having trouble, but I think I figured it out. Merging for
combinations can be tricky. Especially when "experimenting" results in
program-crashing mistakes.

On Mon, Sep 7, 2015 at 9:41 PM, mpinsky <notifications@github.com> wrote:

> Let me know if you run into trouble. I know you've put in a bunch of time
> already, so I will take it on if this starts to eat up even more time.
> Thank you for working on it.
>
>
> On Mon, Sep 7, 2015 at 9:40 PM, Malin Pinsky <malin.pinsky@gmail.com>
> wrote:
>
> > Yes: create a new object. You could even write it to a csv file, but
> > that's probably not critical.
> >
> > On Mon, Sep 7, 2015 at 8:16 PM, Ryan Batt <notifications@github.com>
> > wrote:
> >
> >> OK. Working on this.
> >>
> >> Once I create the data set with the 0's, where does it go? Do I add the
> >> 0's to dat, or do we create a new object with the 0's? If I remember
> >> correctly, I just want to create a new one that Lucas will use, right?
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/mpinsky/OceanAdapt/commit/5488fba14d8aafd5ab9db1ecffc6e53ca751cfc0#commitcomment-13102643
> >
> >> .
> >>
> >
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mpinsky/OceanAdapt/commit/5488fba14d8aafd5ab9db1ecffc6e53ca751cfc0#commitcomment-13103075>
> .
>


I think it's not necessary to keep old code as comment. You can always see old code with Git and old code make current code being messy. How do you think?


Is 4k working?


Las variables deben comenzar con minuscula, por ej: estadosDeLosRenglones.


@mtotheikle For lack of a better place to say this – sorry it's taking me so long to get organised! New namespace and simpler name is great. We'll get this in for beta 3.


El nombre de la variable podría ser: renglonCargado


Fixed! <3


The eternal question. Do we write a **guard** or an **exception**


Sounds great! No worries!


umm, i don't see any input prompt when i run by the command above. Should i just type in dropbox for the client?


AH ok, well nice find. I had never used font size in settings but I indeed am getting an fc in there now with my clock size different, will take a look soon. I literally would have never noticed


102867486-FixRectangleShapeTest-5173 (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1829 of 1838 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.51%25-yellow.svg)


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.51%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


I think using `require "rails/generators"` will access the specs for testing generators. Not sure if it will be usable to that point.


Assuming this is mutable default value paranoia, couldn't you avoid this check by using `frozenset()` as the default value?