We improved throughput for the whole HTTP action dispatching. All operations will slightly benefit from this, regardless of whether they use Foxx or not. Apart from that, we optimized some locks that assigned V8 contexts to threads. This will improve the throughput for Foxx-based actions.

Foxx actions are slower than their native counterparts because native code will be faster in many cases. V8 compiles JS to native code, but it simply cannot guess the "correct" data types for variables etc. So it has to assume something and compiles code speculatively. This will lead to code recompilation in many cases. It's somewhat unavoidable. Apart from that, Foxx actions run in JS and require JS-compatible variables. We cannot simply pass the HTTP request data to V8, because V8 has its own type system. All values need to be copied into the V8 space again. This takes some time, and is not required if the native handler can serve a request. Additionally, JS strings are UTF-16 and not UTF-8, so a lot of string conversions are involved when working with JS. That's also unavoidable to some degree.


我也遇到过这种情况


resolveu meu problema


**Eslint**: 'return' outside of function


**require-jsdoc/require-jsdoc**: Missing @jsdoc for facetClickAction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _groupFunction


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for orderAction


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for selectionAction


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for groupAction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _orderFunction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _selectionFunction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _onInputChange


Good point, that check on line 696 should be moved up (and the similar line in iteratorInternal()). This is done in commit #848001d.


Good idea :D


NB predictions were not output'ed due to this bug, please fix on any other local copy of this function too.


I am not sure about the location of this...


Eliminates #1


I actually don't think that we can export libraries that have been marked as imported in CMake, instead I believe the accepted way is to re-find the packages and let them import themselves. This is done so that the Config.cmake files are relocatable.

Now if we don't care about being relocatable...


If you're tracking kind, why bother tracking these separately? They can all use target internally.


True. I'll make the change.


Is "5000" the default from upstream? Are we sure that's what we (DCE) had it set to? I was thinking it was more like 30 seconds, but I could be wrong. I can check our historical stats if it's hard to track this down otherwise.


@glebus переимену плиз на:**loadCachedMessagesWithDialogID:completion:**


Magic number "5" should be commented


You're absolutely right. No optional version requirements in RubyGems! Otherwise we'd put the constraint on the activerecord gem and this'd just work.

Please do take a look at adding gem requirements to the generator! It supports gem names only currently, but should definitely allow for more. See `gem_for_database` in Railties: https://github.com/rails/rails/blob/master/railties/lib/rails/generators/app_base.rb#L163-L167. Provide version requirements also and it'll Just Work 😁


Make sense. I will make the change.


Yes, but the context of discussion is not always strictly limited by the section title (sometimes when discussing one type of object it's useful to compare its behavior to another; e.g. under "Aware Instances" below you discuss naive instances). So I think it is still necessary to be clear in the text.


Would it be neater to have this as an inner class on SortOptions?


I don't understand your suggestion.  The point I am trying to make is that timedelta is neither a "duration" nor a "period."  It is just a knob to move the hands of the clock.


tarea PR de  md


i wasn't sure if we were going with the whole streamlined feel, do everything on the install

@madeofpeople ergo we can add it in if you wants


This isn't 100% accurate right now as we don't send the host name in this field if it is not present. Though we should be able to add this relatively easily.


hello,kungge 201509091136


Thanks for fixing this. When will this be added to a new tag? 4.1.1 was June 9, 2015.


I like the new explicit syntax, but won't this break existing configurations that use patterns?


"0" magic value can be commented


Только все таки нужно использовать логер


Ограничивай только со стороны производителей.


Are you still enjoying yourself fucking the girl I married? I heard you've got a rash on your cock. I don't appreciate you giving her your sexually transmitted diseases. I expect you've done this many times in the past. I hope you drown you filthy old man. You are old enough to be Tetaina Hogg's father. She'd never have met you if it weren't for the difficulties we went through to be together. Then you have the audacity to go on holiday and meet her family, Were you fucking Tanya in her parents house you filthy scumbag.
By the way, GlobalKeith sounds ridiculous, I think GlobalScum would be more appropriate for you.

![7](https://cloud.githubusercontent.com/assets/8083791/9766413/9a3b1c6a-5710-11e5-8750-34f5b78a530e.jpg)


saw approval from hmmr
at https://github.com/basho/riak_ql/commit/439df931857d3918b0844981273c241e27e0db6c


merging basho/riak_ql/ddl_dist2 = 439df931 into borshop-integration-20-ddl_dist2


basho/riak_ql/ddl_dist2 = 439df931 merged ok, testing candidate = 94378076


I just pushed a quick syntax fix as well as a config fix for an outstanding
pymongo issue (there's a new 3.x version that installs automatically with
the old setup which is incompatible with our usage [we should look into
updating though, pymongo 2.x looks to have some pretty cool features]).
Could you check if I have an account on monitor, I feel like we've been
through this, but I can't log in and I need to restart the UNIS instance
there.  Unfortunately I need to go to class, so it will have to wait until
this afternoon though.

Jeremy

On Wed, Sep 9, 2015 at 11:25 AM, Ezra <notifications@github.com> wrote:

> This is invalid syntax. Also, you should abstract out the ABAC details
> from the PPI handler like we do for gemini. The current setup doesn't allow
> gemini and your filter to work at the same time without separate abac
> stores.
>
> You can put all the ABAC auth-specific routines in auth.py and avoid the
> conditional here altogether. Perhaps put all the ABAC-specific routines in
> auth_abac.py and import it from auth.py as appropriate. periscope.auth is
> then only included when ENABLE_AUTH is true in app.py
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/periscope-ps/unis/commit/435fdb53be23bcea2574d64c04716e3d2ec7a01c#commitcomment-13139298>
> .
>


Since SMTK is installing them, shouldn't they be hardwired? I thought we had decided that any third-party packages that SMTK builds would be installed in smtk/thirdparty rather than at the system level. Then we would not `find_package(MOAB)` but `include(${SMTK_MODULE_DIR}/thirdparty/MOABConfig.cmake)`


here is me


Looks Good


I would not nest Section tags. Each section must have an H1 relationship. See http://stackoverflow.com/questions/7041283/nesting-html5-section-tags


What's the reason for this default value?


It's all obvious until `fold` is introduced.  And that's when the fun begins.  This whole section is a preparation for the next not yet written.  I want to get the reader to the state where it is *obvious* that there is no alternative to the "classic arithmetic."


ahh, the opposite place, this is the part of the code which is triggered when the user makes a change and the code which you wrote (which is correct!) is for place where a patch comes in from other users


Yeah, I'd forgotten this is ultimately coming from bootstrap, so you're stuck either copy-pasting bootstrap styles or editing bootstrap files, neither of which is great. I still think it'd be a slight improvement to move these styles from vellum to HQ, but I don't think there's anything else worth doing here.


Oh, right. I saw aggregate and read attribute-.-


人人


/and and/


We rejected the precedent when we made a new tool instead of extending knife. We've learned a lot from our experience with knife and we intend to use that knowledge to make a better experience in new products.

For example, the single level command list is partially driven by a desire to make shell completion easier, and that is now implemented (via `shell-init`) in master for bash, zsh, and fish.


Changed clean_file_name with sanitize_filename of security helper


We only enforce a minimum version for `pg`; maybe we should do likewise for `mysql2`?


+1 warn. FWIW RSpec does a similar thing (we have some fancier knobs that aren't necessary here.)


Производитель событий и Получатель  и место регистрации Получателей это 3 разные сущности (разных класса)
У получателя не должно быть ссылки на производителя.

Упускаешь важный факт, этот паттерн программирования позволяет добиться слабой связанности. Т.е. каждый класс не обладает информацией лишней, которая к нему не относится.


i think this might fix it


May be wrapped in object


Лучше пусть производитель пуляет определенное кол-во


@RamiroV Leí todo, sentite mal


@jmazzitelli, it will not work here as hawkular-avail-creator.war is not available in hawkular-agent-itest-dist https://github.com/hawkular/hawkular-agent/tree/master/hawkular-agent-itest-dist
I should probably add a dummy war to hawkular-agent-itest-dist just for testing. WDYT?


@thinkyhead -- Just trying to understand what this really does.  Rather than being an issue with timer wrap-around, isn't it the case that the ISR is taking too long and the next interrupt should occur at a time in the past?  This patch gets around much of the "stuttering" because it causes the next interrupt to occur "right away" rather than waiting for the 16-bit counter to cycle all the way around. Although time is being slower down a bit, the motion remains smooth because all of the steppers experience the same time warp and still move proportionally relative to each other.

 It seems to me that if the timer were 128 bits, wrap around would not be an issue. Because the interrupt is reenabled too late, it would never (within our lifetime) occur.


@jaykayone I agree. I wanted to update the project to typeahead 0.11.1 because https://github.com/camptocamp/ngeo/pull/283 forced us to migrate (because of the change to `ngeoCreateGeoJSONBloodhound`). And the Schweizmobil team wanted to use typeahead 0.11.1 because that versions fixed other problems for them. Complex world. Collaborating and sharing have a price.


@jmazzitelli, I am getting `"undefined"` - is that really expected?


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1308 of 1308 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.16%25-green.svg)


@jmazzitelli, the server sends the `auth*` back - is that expected?


it is 4.9 and not 4.8


VS-equipment-issues (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1834 of 1841 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.62%25-yellow.svg)


I don't see it's working...


Use bundles here


@jmazzitelli any other comments about `testExecuteOperation()` ?


@b0rengar Could you provide a screenshot before/after of our modification? Some like that https://github.com/jenkinsci/build-pipeline-plugin/pull/81 Thanks.


token(ContinuationToken) ?


use @Url.Content here instead of hard coded pathes


I think the original purpose of the `active` property was established before I introduced the distinction between the _established session_ (which corresponds to _active = true_) and the _ongoing handshake_ (which corresponds to _active = false_ regarding the `DTLSSession` object the handshake is operating on).

Thus, I feel that the `active` property indeed is obsolete and we should simply remove it. Its semantics has been replaced by the fact that we maintain separate `DTLSSession` objects in the `Connection`.

I think I do not understand the purpose of having a `Connection.toResumeSession()` method. Can you explain that a little further?


From what I understood in the docs it said that this is the minimum interval you can use and it by default only compacts on application startup.


very short test.
Seems, i get the problems in BOTH ways now. Sorry.


I think the Sundown authors should have `role = c("aut", "cph")` since the sundown library is fully embedded in the package.


Allowed


`create!` is preferred in this case, normal create will not notify you on validation error and will be silently ignored.


The fields of a URI are restricted to the authority (i.e. name of the bag), a path and a fragment.


Yeah, this is just related, not a real fix.


I would recommend to use `= image_tag video.small_cover_url` here its more succinct.


Doesn't cherrytree already require ES5? Is there a desire to still support IE8?


Keep local references to these fields for participation in equals().  I don't trust the URI equals method implementation.  This is much simpler.


Good job!


```sh
set -e
```


Can you guys accompany these version bumps with actual git tags?  Git still thinks this repo is at v0.5.4...


:clap:


This creates all 7 routes. Make sure you only limit it to what you handle - otherwise its security risk.


Able to return a java.net.URI that will be guaranteed to be a syntactically correct bag uri.


yes, this is true. see the full commit diff https://github.com/OpenMS/OpenMS/pull/1595/files#diff-9bade601508560dd0174f7f9b40b5221R862 where I fixed it


Some examples of code review & comment with GitHub.


has the `TaskCreationOptions.HideScheduler` any effect right now?


10987 not working

log

apply patch oscam-emu.patch
patching file CMakeLists.txt
patching file config.h
patching file config.sh
patching file cscrypt/md5.c
patching file cscrypt/md5.h
patching file csctapi/cardreaders.h
patching file ffdecsa/CMakeLists.txt
patching file ffdecsa/COPYING
patching file ffdecsa/Makefile
patching file ffdecsa/ffdecsa.c
patching file ffdecsa/ffdecsa.h
patching file ffdecsa/fftable.h
patching file ffdecsa/parallel_032_int.h
patching file ffdecsa/parallel_064_long.h
patching file ffdecsa/parallel_128_sse2.h
patching file ffdecsa/parallel_generic.h
patching file ffdecsa/parallel_std_def.h
patching file ffdecsa/stream.c
patching file globals.h
Hunk #1 succeeded at 420 (offset -1 lines).
Hunk #2 succeeded at 834 (offset -1 lines).
Hunk #3 succeeded at 964 (offset -1 lines).
Hunk #4 succeeded at 1650 (offset 23 lines).
Hunk #5 succeeded at 2117 (offset 32 lines).
Hunk #6 succeeded at 2297 (offset 36 lines).
patching file Makefile
patching file module-dvbapi.c
Hunk #1 succeeded at 1221 (offset 12 lines).
Hunk #2 succeeded at 1248 (offset 12 lines).
Hunk #3 succeeded at 3958 with fuzz 2 (offset 133 lines).
Hunk #4 succeeded at 3996 (offset 145 lines).
Hunk #5 succeeded at 5357 with fuzz 2 (offset 166 lines).
patching file module-dvbapi.h
patching file module-emulator-dre2overcrypt.c
patching file module-emulator-dre2overcrypt.h
patching file module-emulator-osemu.c
patching file module-emulator-osemu.h
patching file module-emulator-st20.c
patching file module-emulator-st20.h
patching file module-emulator-stream.c
patching file module-emulator-stream.h
patching file module-emulator.c
patching file module-newcamd-des.c
patching file module-newcamd-des.h
patching file module-stat.c
patching file module-webif-tpl.c
patching file module-webif.c
Hunk #2 FAILED at 123.
Hunk #3 succeeded at 947 (offset 5 lines).
Hunk #4 succeeded at 1378 (offset 5 lines).
Hunk #5 succeeded at 1819 (offset 5 lines).
Hunk #6 succeeded at 2376 (offset 5 lines).
Hunk #7 succeeded at 2403 (offset 5 lines).
Hunk #8 succeeded at 4083 (offset 5 lines).
Hunk #9 succeeded at 4603 (offset 5 lines).
Hunk #10 succeeded at 6033 with fuzz 2 (offset 8 lines).
Hunk #11 succeeded at 7506 (offset 8 lines).
1 out of 11 hunks FAILED -- saving rejects to file module-webif.c.rej
patching file oscam-chk.c
patching file oscam-config-global.c
Hunk #1 succeeded at 803 (offset 1 line).
Hunk #2 succeeded at 1083 (offset 1 line).
patching file oscam-config-reader.c
patching file oscam-config.h
Hunk #2 succeeded at 61 (offset 5 lines).
patching file oscam-ecm.c
patching file oscam-emm.c
patching file oscam-string.c
patching file oscam-string.h
patching file oscam.c
Hunk #5 succeeded at 1845 (offset 4 lines).
patching file reader-common.c
patching file readers.h
patching file webif/config/menu.html
patching file webif/config/menu_streamrelay.html
patching file webif/config/streamrelay.html
patching file webif/files/menu.html
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file webif/files/menu.html.rej
patching file webif/files/menu_softcamkey.html
patching file webif/pages_index.txt
Hunk #1 succeeded at 80 (offset 1 line).
Hunk #2 FAILED at 116.
Hunk #3 succeeded at 181 (offset 2 lines).
1 out of 3 hunks FAILED -- saving rejects to file webif/pages_index.txt.rej
patching file webif/readerconfig/readerconfig_emubit.html

+-------------------------------------------------------------------------------
| OSCam ver: 1.20-unstable_svn rev: 10987 target: mipsel-unknown-linux-gnu
| Tools:
|  CROSS    = /simplebuild/toolchains/mipsoe20/bin/mipsel-unknown-linux-gnu-
|  CC       = /simplebuild/toolchains/mipsoe20/bin/mipsel-unknown-linux-gnu-gcc
| Settings:
|  CONF_DIR = /var/tuxbox/config
|  CC_OPTS  = -Os -ggdb -pipe -ffunction-sections -fdata-sections
|  CC_WARN  = -w
|  CFLAGS   = -fexpensive-optimizations -funroll-loops
|  LDFLAGS  = -Wl,--gc-sections -Wl,-rpath,/lib -Wl,-rpath,/usr/local/lib -Wl,-rpath,/usr/lib -L/simplebuild/toolchains/mipsoe20/mipsel-unknown-linux-gnu/sysroot/usr/lib
|  LIBS     = -lpthread -ldl -lrt
|  UseFlags =
| Config:
|  Addons   : WEBIF WEBIF_LIVELOG WEBIF_JQUERY TOUCH HAVE_DVBAPI READ_SDT_CHARSETS IRDETO_GUESSING CS_ANTICASC WITH_DEBUG MODULE_MONITOR WITH_LB CS_CACHEEX CW_CYCLE_CHECK CLOCKFIX WITH_EMU
|  Protocols: CAMD33 CAMD35 CAMD35_TCP NEWCAMD CCCAM CCCSHARE GBOX RADEGAST SCAM SERIAL CONSTCW PANDORA GHTTP
|  Readers  : NAGRA IRDETO CONAX CRYPTOWORKS SECA VIACCESS VIDEOGUARD DRE TONGFANG BULCRYPT GRIFFIN DGCRYPT
|  CardRdrs : PHOENIX INTERNAL SC8IN1 MP35 SMARGO DB2COM STAPI STAPI5 STINGER
|  Compiler : mipsel-unknown-linux-gnu-gcc (crosstool-NG 1.15.2) 4.6.3
|  Config   : build/mipsel-unknown-linux-gnu/config.mak
|  Binary   : ../archiv/oscam-svn10987-mipsoe20-webif-oscam-emu-patched
+-------------------------------------------------------------------------------
HOSTCC	webif/pages_gen
GEN	webif/pages.c
GEN	Compressed 393108 template bytes into 164534 bytes. 228574 saved bytes (58.15%).
CC	cscrypt/aes.c
CC	cscrypt/bn_add.c
CC	cscrypt/bn_asm.c
CC	cscrypt/bn_ctx.c
CC	cscrypt/bn_div.c
CC	cscrypt/bn_exp.c
CC	cscrypt/bn_lib.c
CC	cscrypt/bn_mul.c
CC	cscrypt/bn_print.c
CC	cscrypt/bn_shift.c
CC	cscrypt/bn_sqr.c
CC	cscrypt/bn_word.c
CC	cscrypt/mem.c
CC	cscrypt/des.c
CC	cscrypt/i_cbc.c
CC	cscrypt/i_ecb.c
CC	cscrypt/i_skey.c
CC	cscrypt/md5.c
CC	cscrypt/rc6.c
CC	cscrypt/sha1.c
CC	csctapi/atr.c
CC	csctapi/icc_async.c
CC	csctapi/io_serial.c
CC	csctapi/protocol_t0.c
CC	csctapi/protocol_t1.c
CC	csctapi/ifd_db2com.c
CC	csctapi/ifd_mp35.c
CC	csctapi/ifd_phoenix.c
CC	csctapi/ifd_sc8in1.c
CC	csctapi/ifd_sci.c
CC	csctapi/ifd_smargo.c
CC	csctapi/ifd_stinger.c
CC	minilzo/minilzo.c
CC	module-anticasc.c
CC	module-cacheex.c
CC	module-camd33.c
CC	module-camd35-cacheex.c
CC	module-camd35.c
CC	module-cccam-cacheex.c
CC	module-cccam.c
CC	module-cccshare.c
CC	module-constcw.c
CC	module-emulator.c
CC	module-emulator-osemu.c
CC	module-emulator-stream.c
CC	module-emulator-st20.c
CC	module-emulator-dre2overcrypt.c
CC	ffdecsa/ffdecsa.c
CC	module-csp.c
CC	module-cw-cycle-check.c
CC	module-dvbapi-chancache.c
CC	module-dvbapi.c
CC	module-gbox-helper.c
CC	module-gbox-sms.c
CC	module-gbox-cards.c
CC	module-gbox.c
CC	module-ird-guess.c
CC	module-monitor.c
CC	module-newcamd.c
CC	module-newcamd-des.c
CC	module-pandora.c
CC	module-ghttp.c
CC	module-radegast.c
CC	module-scam.c
CC	module-serial.c
CC	module-stat.c
CC	module-webif-lib.c
CC	module-webif-tpl.c
CC	module-webif.c
module-webif.c: In function 'send_oscam_files':
module-webif.c:6037:24: error: 'MNU_CFG_FSOFTCAMKEY' undeclared (first use in this function)
module-webif.c:6037:24: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [build/mipsel-unknown-linux-gnu/module-webif.o] Error 1
make: *** [all] Error 2


Done. Thanks!


Same as I commented about videos - make sure you limit this only to the actions you use.


:clap: Yea ES5


@TetsuyaHayashi61 `pma_`で始まるテーブルはこのサービスでは使っていないでしょうか。可能なら、今のサービスで使っているものだけに絞れると良いですね。おそらく同じdatabaseに複数テーブルが入っているためにこうなったと想像しています。また対面でも確認させて下さい。


all tests pass:
success: http://buildbot.bos1/builders/test-riak_ql/builds/104


s/unsigned/bool/


Should be after public members


To someone coming from a timeline way of thinking, emphasizing that "we can make any change using a single microsecond knob" will cause them to nod and say, "Ok, then it's a duration." Whereas your goal is to point out that even though it can all be boiled down to microseconds, they are microseconds that correspond only to the configuration of the clock hands, not necessarily to physical time.

But on further review, I think you cover that point clearly in the next paragraph, so this wording is probably ok as-is.


Should this be an 'enum' or should we make it a class, so that people can extend this and define additional roles?


crfD


More examples of a PR and code review.


I think this should be:

```hbs
{{input on-input=(action 'setName' model) value="target.value"}}
```

right?


10987 not ok

apply patch oscam-emu.patch
patching file CMakeLists.txt
patching file config.h
patching file config.sh
patching file cscrypt/md5.c
patching file cscrypt/md5.h
patching file csctapi/cardreaders.h
patching file ffdecsa/CMakeLists.txt
patching file ffdecsa/COPYING
patching file ffdecsa/Makefile
patching file ffdecsa/ffdecsa.c
patching file ffdecsa/ffdecsa.h
patching file ffdecsa/fftable.h
patching file ffdecsa/parallel_032_int.h
patching file ffdecsa/parallel_064_long.h
patching file ffdecsa/parallel_128_sse2.h
patching file ffdecsa/parallel_generic.h
patching file ffdecsa/parallel_std_def.h
patching file ffdecsa/stream.c
patching file globals.h
Hunk #1 succeeded at 420 (offset -1 lines).
Hunk #2 succeeded at 834 (offset -1 lines).
Hunk #3 succeeded at 964 (offset -1 lines).
Hunk #4 succeeded at 1650 (offset 23 lines).
Hunk #5 succeeded at 2117 (offset 32 lines).
Hunk #6 succeeded at 2297 (offset 36 lines).
patching file Makefile
patching file module-dvbapi.c
Hunk #1 succeeded at 1221 (offset 12 lines).
Hunk #2 succeeded at 1248 (offset 12 lines).
Hunk #3 succeeded at 3958 with fuzz 2 (offset 133 lines).
Hunk #4 succeeded at 3996 (offset 145 lines).
Hunk #5 succeeded at 5357 with fuzz 2 (offset 166 lines).
patching file module-dvbapi.h
patching file module-emulator-dre2overcrypt.c
patching file module-emulator-dre2overcrypt.h
patching file module-emulator-osemu.c
patching file module-emulator-osemu.h
patching file module-emulator-st20.c
patching file module-emulator-st20.h
patching file module-emulator-stream.c
patching file module-emulator-stream.h
patching file module-emulator.c
patching file module-newcamd-des.c
patching file module-newcamd-des.h
patching file module-stat.c
patching file module-webif-tpl.c
patching file module-webif.c
Hunk #2 FAILED at 123.
Hunk #3 succeeded at 947 (offset 5 lines).
Hunk #4 succeeded at 1378 (offset 5 lines).
Hunk #5 succeeded at 1819 (offset 5 lines).
Hunk #6 succeeded at 2376 (offset 5 lines).
Hunk #7 succeeded at 2403 (offset 5 lines).
Hunk #8 succeeded at 4083 (offset 5 lines).
Hunk #9 succeeded at 4603 (offset 5 lines).
Hunk #10 succeeded at 6033 with fuzz 2 (offset 8 lines).
Hunk #11 succeeded at 7506 (offset 8 lines).
1 out of 11 hunks FAILED -- saving rejects to file module-webif.c.rej
patching file oscam-chk.c
patching file oscam-config-global.c
Hunk #1 succeeded at 803 (offset 1 line).
Hunk #2 succeeded at 1083 (offset 1 line).
patching file oscam-config-reader.c
patching file oscam-config.h
Hunk #2 succeeded at 61 (offset 5 lines).
patching file oscam-ecm.c
patching file oscam-emm.c
patching file oscam-string.c
patching file oscam-string.h
patching file oscam.c
Hunk #5 succeeded at 1845 (offset 4 lines).
patching file reader-common.c
patching file readers.h
patching file webif/config/menu.html
patching file webif/config/menu_streamrelay.html
patching file webif/config/streamrelay.html
patching file webif/files/menu.html
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file webif/files/menu.html.rej
patching file webif/files/menu_softcamkey.html
patching file webif/pages_index.txt
Hunk #1 succeeded at 80 (offset 1 line).
Hunk #2 FAILED at 116.
Hunk #3 succeeded at 181 (offset 2 lines).
1 out of 3 hunks FAILED -- saving rejects to file webif/pages_index.txt.rej
patching file webif/readerconfig/readerconfig_emubit.html

+-------------------------------------------------------------------------------
| OSCam ver: 1.20-unstable_svn rev: 10987 target: mipsel-unknown-linux-gnu
| Tools:
|  CROSS    = /simplebuild/toolchains/mipsoe20/bin/mipsel-unknown-linux-gnu-
|  CC       = /simplebuild/toolchains/mipsoe20/bin/mipsel-unknown-linux-gnu-gcc
| Settings:
|  CONF_DIR = /var/tuxbox/config
|  CC_OPTS  = -Os -ggdb -pipe -ffunction-sections -fdata-sections
|  CC_WARN  = -w
|  CFLAGS   = -fexpensive-optimizations -funroll-loops
|  LDFLAGS  = -Wl,--gc-sections -Wl,-rpath,/lib -Wl,-rpath,/usr/local/lib -Wl,-rpath,/usr/lib -L/simplebuild/toolchains/mipsoe20/mipsel-unknown-linux-gnu/sysroot/usr/lib
|  LIBS     = -lpthread -ldl -lrt
|  UseFlags =
| Config:
|  Addons   : WEBIF WEBIF_LIVELOG WEBIF_JQUERY TOUCH HAVE_DVBAPI READ_SDT_CHARSETS IRDETO_GUESSING CS_ANTICASC WITH_DEBUG MODULE_MONITOR WITH_LB CS_CACHEEX CW_CYCLE_CHECK CLOCKFIX WITH_EMU
|  Protocols: CAMD33 CAMD35 CAMD35_TCP NEWCAMD CCCAM CCCSHARE GBOX RADEGAST SCAM SERIAL CONSTCW PANDORA GHTTP
|  Readers  : NAGRA IRDETO CONAX CRYPTOWORKS SECA VIACCESS VIDEOGUARD DRE TONGFANG BULCRYPT GRIFFIN DGCRYPT
|  CardRdrs : PHOENIX INTERNAL SC8IN1 MP35 SMARGO DB2COM STAPI STAPI5 STINGER
|  Compiler : mipsel-unknown-linux-gnu-gcc (crosstool-NG 1.15.2) 4.6.3
|  Config   : build/mipsel-unknown-linux-gnu/config.mak
|  Binary   : ../archiv/oscam-svn10987-mipsoe20-webif-oscam-emu-patched
+-------------------------------------------------------------------------------
HOSTCC	webif/pages_gen
GEN	webif/pages.c
GEN	Compressed 393108 template bytes into 164534 bytes. 228574 saved bytes (58.15%).
CC	cscrypt/aes.c
CC	cscrypt/bn_add.c
CC	cscrypt/bn_asm.c
CC	cscrypt/bn_ctx.c
CC	cscrypt/bn_div.c
CC	cscrypt/bn_exp.c
CC	cscrypt/bn_lib.c
CC	cscrypt/bn_mul.c
CC	cscrypt/bn_print.c
CC	cscrypt/bn_shift.c
CC	cscrypt/bn_sqr.c
CC	cscrypt/bn_word.c
CC	cscrypt/mem.c
CC	cscrypt/des.c
CC	cscrypt/i_cbc.c
CC	cscrypt/i_ecb.c
CC	cscrypt/i_skey.c
CC	cscrypt/md5.c
CC	cscrypt/rc6.c
CC	cscrypt/sha1.c
CC	csctapi/atr.c
CC	csctapi/icc_async.c
CC	csctapi/io_serial.c
CC	csctapi/protocol_t0.c
CC	csctapi/protocol_t1.c
CC	csctapi/ifd_db2com.c
CC	csctapi/ifd_mp35.c
CC	csctapi/ifd_phoenix.c
CC	csctapi/ifd_sc8in1.c
CC	csctapi/ifd_sci.c
CC	csctapi/ifd_smargo.c
CC	csctapi/ifd_stinger.c
CC	minilzo/minilzo.c
CC	module-anticasc.c
CC	module-cacheex.c
CC	module-camd33.c
CC	module-camd35-cacheex.c
CC	module-camd35.c
CC	module-cccam-cacheex.c
CC	module-cccam.c
CC	module-cccshare.c
CC	module-constcw.c
CC	module-emulator.c
CC	module-emulator-osemu.c
CC	module-emulator-stream.c
CC	module-emulator-st20.c
CC	module-emulator-dre2overcrypt.c
CC	ffdecsa/ffdecsa.c
CC	module-csp.c
CC	module-cw-cycle-check.c
CC	module-dvbapi-chancache.c
CC	module-dvbapi.c
CC	module-gbox-helper.c
CC	module-gbox-sms.c
CC	module-gbox-cards.c
CC	module-gbox.c
CC	module-ird-guess.c
CC	module-monitor.c
CC	module-newcamd.c
CC	module-newcamd-des.c
CC	module-pandora.c
CC	module-ghttp.c
CC	module-radegast.c
CC	module-scam.c
CC	module-serial.c
CC	module-stat.c
CC	module-webif-lib.c
CC	module-webif-tpl.c
CC	module-webif.c
module-webif.c: In function 'send_oscam_files':
module-webif.c:6037:24: error: 'MNU_CFG_FSOFTCAMKEY' undeclared (first use in this function)
module-webif.c:6037:24: note: each undeclared identifier is reported only once for each function it appears in
make[1]: *** [build/mipsel-unknown-linux-gnu/module-webif.o] Error 1
make: *** [all] Error 2


Ainda é pouco... :P


Use @Url.Content here instead of hard coded values


```make
ifeq (,$(USEMODULE))
$(error Something bad happened.)
endif
```


よくあるのは IDに使うカラムの名前を `id` で統一します。それほど影響が無さそうなら修正したいですが、そこそこ大変かもしれないので委ねます。学びとしては「そういう慣習があるのだ」と把握しておいて戴ければ良いと思います。


You should include these scripts using bundles


I think you should use a more portable encoding, like keeping original bytes and encoding them is base64. Anyway Json values should be utf-8.


ここは `htmlspecialchars`いらないところですが、まだ概念を理解していないと思いますので今後の課題としましょう。


I like the code. Seems like it could have possibly been used in a case selection as well. Works both ways. Very Nice.


Thanks for the info @inetbiz.
Actually, a section needs a H* element not only an H1 according to W3C (http://www.w3.org/TR/html5/sections.html#the-section-element).
We will modify our structure.


please document the params


Nicely done, BTW!

I put curly braces around your loop and updated the indenting. That ends up making the code a bit more readable. I'm a huge fan of readable code.


is the second param private?


@westcripp  lol yes it's mine, no worries. I'm over all this nonsense that goes on around github, you guys do a great job so I don't mean you AT ALL, I'm sure you know exactly what/who I speak of :D


This is not needed. You can access all videos from each category as you ll iterate over the `@categories` collection.


ok I see and agree

> On 9 sept. 2015, at 17:43, Éric Lemoine <notifications@github.com> wrote:
>
> @jaykayone I agree. I wanted to update the project to typeahead 0.11.1 because camptocamp/ngeo#283 forced us to migrate (because of the change to ngeoCreateGeoJSONBloodhound). And the Schweizmobil team wanted to use typeahead 0.11.1 because that versions fixed other problems for them. Complex world. Collaborating and sharing have a price.
>
> —
> Reply to this email directly or view it on GitHub.
>


Use _Layout.cshtml for this markup.


It seems you never really test what you are doing. I think we should have an example of what is token and what is a signature in the test classes.


Very nice!


93653360-ResetVarsAtEndOfWarmup (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (1822 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.4%25-yellow.svg)


I think it would be useful here (to someone coming from a "timeline arithmetic" assumption) to use a specific example with a DST transition to clarify your implication. Without a specific example, it is too easy to skim through and assume that what you are reading matches your existing assumptions. Here's a quick draft of a sample addition, edit as you like:

> In other words, operations on aware datetime instances take effect in simple local clock time, not real-world physical time, thus they don't care about wrinkles in the timezone. If you add four hours to 1am in any timezone, the result will always be 4am in that timezone, even if Daylight Saving Time starts or ends at 2am on that day.

I see that perhaps you're trying to first describe the current state without any reference to folds or gaps at all, but I'm not sure that will be as effective as using distinguishing examples to clarify throughout.


Ok, we are agree about `active` property :) !
About `toResumeSession` :
When we do the `Connector.forceResumeSessionFor()`  we want to force session resumption next time the client will try to send data. To do that we need to retrieve the session to use. You could have a look [here](https://github.com/eclipse/californium.scandium/blob/resume_session/scandium-core/src/main/java/org/eclipse/californium/scandium/DTLSConnector.java#L860) in the current code, maybe this could help.


@omefire please review


Fix #6


Hey Hi jumping on this commit @mciparelli @leongersen. I think we should not put this in the module automatically.

It's very easy for the npm user to do this on his own:

```js
var css = require('nouislide/distribute/nouislider.min.css');
```

And use the required browserify transform/webpack loader (raw loader) to then make the require work.

Putting it as we did inside the library puts a dependency on:
1. using browserify (or makeing require fs work with webpack)
2. having brfs as a dependency (or merge #487)

Which is not so good in term of portability. What do you think both?


Same here: I think you should test with real tokens, instead of tokens you generate.


ここ、エラーになってしまうかも？


@Fetz

Please see my comment in #45 about this. This change broke SpotX Ads and I'm pretty certain this does not follow IAB Spec.


this was intentional?


Add username information


I guess the backticks were not so "gratuitous" after all. ea79566441839c2e2d8b1c0a88c9331486dab2db


Should be checked by isValid, no?


I don't understand this sentence. It seems like perhaps you are equating a timeline view with one clock magically transforming itself into another, but I don't think anyone, even someone with a timeline view, would phrase it that way. I think the reaction to this sentence will be "Of course not, why would it? What does he even mean by that?"


you attached this class to div.col-xs-12. That's a bad idea because you rewrite bootstrap classes. better don't use margin for this class. Create one more div to wrap your content or use padding


`button` nie jest zdefiniowany wewnątrz tej funkcji.  Może `a.target`?


Nice work


Tough when a point release actually breaks stuff, though. We could go `~> 0.4` as a middle ground, cover up to 1.0.


If you change ContinuationToken.SEPARATOR your test will still pass but won't test anything.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.471.3fd04293f9034b95c013ae5d4f6827dcde22e7be](http://build.palaso.org/viewLog.html?buildId=62987&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:19:01


Note: This fixes GetCube but get_next_product_id (called by tv_register_product) still blows up here:

```
File '/software/ndm/ckanext-stcndm/ckanext/stcndm/logic/common.py', line 100 in get_next_product_id
[Wed Sep 09 10:48:46 2015] [error] [client 10.205.161.42]   raise e
[Wed Sep 09 10:48:46 2015] [error] [client 10.205.161.42] IndexError: list index out of range
```
I am investigating now.


これらの処理を書けたのは素晴らしいです！そして「より良い方法」を今後学びましょう。


It seems that this property doesn't make any sense outside of OpenWire.. it's protocol specific, so maybe this should be out of here?


You should probably have this back


Hey @patrick91, I like the design of "The Art of Ping Pong" but there's no user interface to showcase here :worried: I'm going to close this one for now, but feel free to update the pull request if you add components of user interface in the website (e.g. login form).


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2301 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.46%25-yellow.svg)


This sentence doesn't make much sense to me either. "Matching the hands configuration on the two clocks" might make sense, or it might not, depending on what your purpose is, and you haven't stated any purpose here. Of course nobody would think that 3pm occurs at the same time in Budapest and Newcastle, so it hardly seems necessary to clarify that. But it still might "make sense" (for some use case) to want to have both clocks show 3pm in their respective local time. So it just seems wrong to assert that it "does not make much sense" -- you need to clarify what hypothetical purpose you have in mind for which it doesn't make sense.


It's surprising that this doesn't make any Tamarin tests pass.


So I'd added this here instead of putting it in the individual tests as an easy way to hide the `apiKey` from appearing in the list of args.  When we call ` spec.executeTest("testBQSR-" + params.args, this);` it logs the args as the test name.  This is good, except we don't want to put our key in our public logs.  If some tests can't handle the key, we need to change the parameter to `executeTest` so we're not dumping the key into our public logs.   (and we need to revoke our current key and replace it.)

Could you update so it doesn't leak the key?  Maybe add an `includeKey` parameter to BQSRTest that toggles including it in the command line.  Or use whatever solution you think is most elegant.


xvczxvzczvcx


erwwrewre


dfsafdsa


merge this file with Styles.css.


Why is `|| echo -n ""` here?


Where is the compression / decompression happening at the message conversion?

Also: I don't see any tests validating multiple protocols... you need at least one test sending OpenWire compressed, consuming the message on Core or AMQP. Can you do that please before we can merge this commit?


I don't think we do this consistently at the moment. Will this enforce anything?


Thanks for the info! Fingers crossed for type annotations / sound script, which should allow for "static" typing in JS in the future. Although... there are typed arrays, are they significantly faster because the data type is known and static?

Do you know of any performance gain or loss due to the buffer changes mentioned in below changelog of iojs?
https://github.com/nodejs/node/blob/master/CHANGELOG.md#notable-changes-4
Or is that purely node/iojs related?

I wasn't aware that JS uses UTF16. Converting back and forth to UTF8 sounds like a costly operation, and happens a lot for JSON, which is supposed to be UTF8.


Good point! Actually, what's your plan current plan to switch between data and MC submission? By toggling where the symlink points to? In this case we probably have to read the data/MC flag by opening the file. Alternatively we could look at the name of the dataset the job is given to process. Do you have any preference?


idであるなら、パラメータ名は `old_`は不要かもしれませんよ。


**Eslint**: 'return' outside of function


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for selectionAction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _orderFunction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for facetClickAction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _selectionFunction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _groupFunction


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for groupAction


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for orderAction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _onInputChange


Yes, that is also what we think. That interpretation does not have broad agreement yet. The proposal is not approved on the wiki. Even if it gets approved, some time will be needed until people actually fix data and add all the foot=no, bicycle=no where needed. Where they today just slapped access=no to disallow all access. So until that is done (years?) OsmAnd can't switch to that interpretation.


I recommend don't use class selector for body tag. You can write just
body {     }
For admin you will have another _Layout file. There you can include sb-admin.css


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.960.b125a9a11d713b76b1a7f569898f44ac224a152f](http://build.palaso.org/viewLog.html?buildId=62992&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 509, ignored: 6 Build time: 00:03:43


@TetsuyaHayashi61 何点かコメントしました。確認してみてください。


I have no clue why it complains about this static method but it doesn't complain from the ones in `FacetOption` and `PriceFormatter`... Any idea?


Super buggy, super WIP. Eventually this extra tab will be able to show the user separate graphics layers (BG, WIN, OBJ) and all the user will have to do is hover and the tile will be highlighted (with an enlarged version to the right). Eventually, users should be able to select multiple tiles, or be able to dump the entire screen at once.


The code is set up for Dr. Price's code. He told me to push it up because
he said his code would be done in time to absorb my changes. But you're
right, I will fork it.
On Sep 8, 2015 11:01 PM, "peggylind" <notifications@github.com> wrote:

> This commit doesn't run when I try it on my local machine.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DataAnalyticsinStudentHands/DataMaps/commit/457aaeaa292029b7fb16deaf3e402d3e46135f9b#commitcomment-13127273>
> .
>


OKです。セキュリティに関しては今月はまだレクチャできないかも知れませんが、来月までには伝授していきますね！


@dchambers It's now testing properties the whole model properties rather than just a subset (the test changes were largely ported across from CT since it already had these changes). It should probably verify both `oNode.children.properties()` and `oNode.properties()`.


Shouldn't that be:

`return  AnalyticsJobHierarchy.Group.ALL.equals(existingHierarchyGroup) ||
            AnalyticsJobHierarchy.Group.ALL.equals(job) ||
            existingHierarchyGroup.equals(AnalyticsJobHierarchy.fromEventType(job.getEventType());`

(We could also add the `existingJob.getAccountId().equals(job.getAccountId())` but by construction that should always be true.)


hg commit returns a 1 which causes make to fail when there are no new changes to commit.  Echo returns 0 allowing the make to proceed. `echo -n ""` was used so that a newline was not printed.  That could be removed if you still want it to fail out there instead of proceeding.


You could just use the method sortedArrayUsingDescriptors on NSArray.
Also if you ever want to convert an NSArray to an NSMutableArray, all you need to do is call mutableCopy on it.


can example_nodeset be now generated with amalgamation on?


You don't need to convert it back to NSArray either since NSMutableArray derives from NSArray


rax retry tests


Yes, the drain event is meant to be one-shot:
- (presumably) one thing requests a drain, and maybe provides a callback
- the drain finishes, and we notify


Can you please take out the DK1 from the log statement.


develop (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


You could simply do

    return [newArray count]>0;

since that is already a boolean expression.


The first time I read this sentence I assumed "more complicated" meant "more complicated than what I just described" and wondered what additional complication you were about to introduce. It took me a double-take before I realized that you were just re-stating and summarizing the above. Here's a possible re-wording:

> Note that this definition of difference between times in different time zones is much more complicated than (and implemented in terms of) the definition of difference between two times in the same timezone. Although conceptually intrazone and interzone comparisons and subtraction are completely different, Python uses the same operators ``==`` and ``-`` to spell them.


If the custom concurrency limiting one is in use yes? Imagine if concurrency is set to 1 and the user does s task.run in a hander, that would deadlock I think?


Please remove the DK


Remove this commented out line.


What's a categproe?


remove DK from here


remove this commented line as well as any other commented line that is not relevant.


If we are switching from attempting to open the file to stating the file, we should check to see whether we have read permissions on the file.  Otherwise, if the file permissions are set otherwise, we will get an error later when we try to open it.


Oh and wait there is another issue: It only makes sense to look for the job with a higher recordId when the `AnalyticsJobHierarchy` group is the same.

I think the decision should be:
* If there is a future or in-processsing job with a higher `AnalyticsJobHierarchy` group than me, i should not run
* If there is none, then use existing logic based on higher recordId.


i don't think this will compile.


@JoelTroch

I appreciate your feedback. Glad to see that this is going on the right track.

>  if people are using addons (Metamod, AMX Mod X), it may cause conflicts

Indeed, you are correct. I derived the eagle laser from the RPG laser class to avoid messing with the original source code. This is something you will notice in many of my implementations.Sadly, I did not take any additional 'mod' compatibility into consideration, I was unaware of AMX, Mod X, along with the others.

I currently do not have the time to check this out, due to personal stuff. Until I find more spare time, I encourage anyone interested in this project to check this out. If you can adjust this, make a pull request and I will merge it once I check it.


`display: inline-block;` было всегда. И до сих пор у вас вопросов не возникало.


- 9/7 分をすっ飛ばしてしまいました。失礼しました。既に辿り着かれていたのですね。そちらにもコメントを入れておきましたのでご確認下さいませ。
- SQLファイルはそのやり方です。中身がちょっと想定よりも多いのでそれも相談しましょう。
- 一つ追加で調べてみて欲しいのですが、 `require`という機能があります。これを使うと何度も書きそうな内容をファイルに外出しして書いておいて、何回も使うことが出来ます。今ですと、DBの接続部分がまさに対象としてピッタリですので、一度調べてみてください。

引き続きよろしくお願いします。


I don't think you will achieve getting most readers to that state, because I think that's a wrong assertion :-)

Unless there was an implied addendum "... while maintaining backwards compatibility with the current behavior of the datetime module."


...until there is *no* remaining data.


А, да. Действительно рапидорашивает. Щас посмотрю, что можно сделать.


In this case, the point release did NOT break stuff, apparently. According to this fix, mysql2 0.4.0 works fine -- it just wasn't allowed with the 'optional dependency version specification' in the mysql2_adapter.

I think changing the entire way 'optional dependencies' work in AR is probably out of scope here -- apparently AR doesn't want to express explicit dependencies on underlying database gems for each of it's possible databases, or this would indeed just be in the gemspec.

So I have no idea what the right answer is, except that one or the other, remove the upper bound from the 'optional dependency' in mysql2_adapter, OR change the generator to generate the same version specification. I guess I'd lean towards the first, because a generated version spec in your Gemfile is going to be something a lot of people never change, and get locked into old versions without realizing it.

Also out of scope here, probably, is discussing why the heck the `mysql2` gem is still on a pre-1.0 version number -- when it's widely used in production -- instead of being on post-1.0 and committing to semver. If it did that, it would at least make things less confusing.


add  requirements and docs
and change parameter name.


In other words, I think the best you can hope for here is to convince readers that classic arithmetic is internally consistent and useful. (You are not helped in that task, of course, by the fact that datetime's implementation of it is not consistent, since it spells both "timeline" and "classic" operations using the same operators.) You will never convince a reader who has accustomed themselves to a timeline view (and used it successfully in real applications) that there is 'no alternative to the classic arithmetic.'


Double tab indent here. Please fix in all locations. Also please use mson instead of Mson.mson. We made it available through proxy methods in the MassiveCommand.


I'm all for a faster, more correct implementation. But dB's right in that we need -- at a minimum -- an upgrading paragraph. Ideally, we'll find a correct, non-breaking implementation.


If it is the case, the current [`dependencies`](https://github.com/BrowserSync/browser-sync-client/blob/3ff1868bf964a8365c42406e26aa7746cc7fb502/package.json#L59-L62) are really needed?


That trailing space after the dot. Please remove it. In all locations?


but that limit then only applies to reading from the queue, not message processing?


`main` file is excluded now. Or, "main": "index.js" is wrong?


That is a good question.

Currently when we install SMTK we get
```
lib/cmake/SMTK/SMTKConfig.cmake
lib/cmake/MOAB/MOABConfig.cmake
```

I could look into patching MOAB so that it does the following:
```
lib/cmake/SMTK/SMTKConfig.cmake
lib/cmake/SMTK/MOABConfig.cmake
```


Close #11


partially fixes #2


5110_stdbaropress_sealevel (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1819 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.91%25-yellow.svg)


Yellow color directly here please, instead of below.


> А в чём там вообще проблема с display: table;, вроде ничего визуально не меняется?

Вы правы. `#de-win-reply { display: block;` можно убрать. А вот окно настроек от форчановского `display: table;` портится. Я сюда добавил чисто на всякий случай. Как оказалось, зря.


@nick22891 as much as I am an advocate for shorthand coding, in the case of this project I think it would be best practice to not do it.  Instead try the standard convention:
```javascript
if (<condition>) {
    //do something
} else {
    //do something else
}
```

Justification:  I have noticed that browsers each have their own javascript engines, each with specific ways of treating carriage returns and whitespaces.  Sometimes shortcut methods can make this more difficult.  This is immediately noticeable with other languages like python when code is ported from a linux machine to a windows one.


Thanks. I'm still seeing the same behavior, though:

```
pkg <- disposables::make_packages(aa = {}, imports = c("rpart", "dplyr"))
> devtools::dev_package_deps(file.path(pkg$lib_dir, "aa")) %>% as.data.frame
     package   installed available diff
1 assertthat         0.1       0.1    0
2         BH    1.58.0-1  1.58.0-1    0
3        DBI  0.3.1.9008     0.3.1    1
4   lazyeval 0.1.10.9000    0.1.10    1
5   magrittr         1.5       1.5    0
6         R6       2.1.1     2.1.1    0
7       Rcpp      0.12.0    0.12.0    0
```

Should `rpart` and `dplyr` be present in this data frame?


Ok cool, added that. Thanks!


that is true, but the proxy method is not static (yet) ;)


I thought of it but I concidered continuationTokenManager responsability should be to tell whether or not a token was validated by this server.


See [React document] (https://facebook.github.io/react/tips/dangerously-set-inner-html.html) on `__html`.


@schiesbn - Is this enough to enable encryption?
Travis doesn't complain, but locally, I get this as soon as I try to add a file to the user's folder.

> [OCA\Encryption\Exceptions\PrivateKeyMissingException]
  Private Key missing for user: please try to log-out and log-in again

So, I'm not sure who to believe...

Enabled apps
```
Enabled:
  - activity: 2.1.2
  - encryption: 1.0.0
  - files: 1.1.11
  - files_external: 0.2.3
  - files_sharing: 0.6.3
  - files_texteditor: 0.4
  - files_versions: 1.0.6
  - gallery: 14.0.0
  - provisioning_api: 0.2
```


Ok


Am I correct in saying this change should apply also to the new Schedule constructor that @pcaspers  implemented?


`data` is used everywhere.  But do you really know what each `data` is for?  Try changing the variable name in different places to get the hang of it.


That was a mistake, reverted.


another bug found. excellent!


The other advantage are
 * to allow the reordering of the shader (however the dx part must be done too, and potentially some hardcoded value that I miss)
 * to quickly find the shader effect


Might as well just set `mini` to zero, or do away with it entirely?

```python
plt.plot(demand_profile[0:maxi])
plt.plot(availability_profile[0:maxi])
```


5110_stdbaropress_sealevel (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Will look to refactor to OO approach as it is redundant.


Commit de prueba


I think there's a lot of good material here, and it's an effective and clear description of the existing behavior. I'm not sure if this approach (strictly confining yourself to describing Python's current behavior) will be effective in helping someone accustomed to a timeline view understand _why_ classic arithmetic is useful and a reasonable alternative (in other words, it's an effective description; I'm not sure if it's an effective apologia). I think for the latter, it would be more effective to clearly outline and contrast both possible models (the timeline model and the classic model), so they can recognize their own perspective in the one description, and then see how the other model is also useful.

But perhaps your goal is only description, not apologia. I do think the clock/knob metaphors used here are very effective for clearly describing the classic model.


Not really. TaskScheduler current will be set to the limited scheduler. Therefore all Task.Run etc would by default run on that one if spawn off inside the pipeline and ultimatively in the user code


Commit inicial


This is incorrect.  You have not added a new attribute to the demand.  Instead you have created a new key:value member to `de_met_amount`.  Please review and make the adjustments to the following line:

```javascript
de_met_amount: {type: Number, default: 0, de_notes: String}
```


r+


참고 http://ralf79.tistory.com/189


I don't particularly like this solution, skipping filters has let to a lot of problems in the past and almost anything other than overriding the "Optimize" function causes a lot of problems.

There's also the problem that it's hard to tell if "m_SourceFilter" is used by any other filters (for instance by calling ConvertToYuv()). I fear this is already causing bugs.


Hello , there should be URLInfo.URL.fileURL ? It is return false on offline


Seems to be a compilation error here because the used signature does not exist. See http://ci.xwiki.org/job/xwiki-platform/1818/console


Canolla should be canola.


, e.g. ..., or


Oops. Disastrous typo. >_< My bad. Not sure how that slipped by me...


101884090--NewVenting-Availability-Schedule (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1834 of 1834 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I am moving to revert these changes as the access control of the TRN should be handled by the API.  The web application should be loosely coupled with the web API.


@julesle123456789 Make a ticket about it.


saw approval from jedmccaleb
at https://github.com/graydon/stellar-core/commit/8b7c3ea08b645fcf7ef9b904107886a2abd9a228


merging graydon/stellar-core/base-fee-zero-ok = 8b7c3ea0 into auto


graydon/stellar-core/base-fee-zero-ok = 8b7c3ea0 merged ok, testing candidate = 3a661988


I haven't followed this, but are you sure that it is not a disposables issue?


fixed #129


Whoopsie my bad. It should be isFileURL(). Correcting this ASAP.


ok


where?


수정


Fixed in cca3241ac686b54e54e04beac18d59d023c57201.


Fix robustness analysis to reflect new methods of minimisation and maximization


testy


@gaborcsardi: No, `disposables` is not to blame here. This is what I get for `devtools` itself:

```
> devtools::dev_package_deps(".") %>% as.data.frame
    package installed available diff
1        BH  1.58.0-1  1.58.0-1    0
2      brew     1.0-6     1.0-6    0
3      curl     0.9.3     0.9.3    0
4    digest     0.6.8     0.6.8    0
5  jsonlite    0.9.17    0.9.17    0
6  magrittr       1.5       1.5    0
7      mime       0.4       0.4    0
8        R6     2.1.1     2.1.1    0
9      Rcpp    0.12.0    0.12.0    0
10  stringi     0.5-5     0.5-5    0
11  stringr     1.0.0     1.0.0    0
12     xml2     0.1.2     0.1.2    0
```

`httr` is a direct dependency (among others), but not listed here.


In line 97 `site_url` is already set to `siteUrl`. Just curious, why didn't you change the URL in line 60 instead?


@julesle123456789
https://github.com/MassiveCraft/Factions/issues


@paradoxxjm please confirm that the default state is `true` for a new buyer being entered into the system.


@yehudasa AWS4 needs to read the body of the request in order to hash it when it exists. It happens when you create the canonical request as part of the signing process. See http://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html

With the current signature version (AWS2) the body of the request is not part of the signature process so RGW just needed reading once the body. Now, with AWS4 in place, you need to read twice the body (as part of the AWS4 signing process early and as part of the use case later)

You need to read/cache this content in some place with the first reading (the deployed civetweb version lacks of a read-and-preserve interface/API). Reading and caching the body content in the auth step resolve one issue with embedded servers not supporting the read-and-preserve interface, while handling AWS2 and AWS4 signatures in the same way (no major changes in the current tested codebase)


Checkmarx scan results 09 Sep 2015 12:34 UTC -04:00

High
Medium
Low
Info

New
2
4
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

549d113ba6b69c54670a2ee2d3c2587765eb3081	@virginiacc


подключение бд и вида


Wasn't the idea here to be visual with a buyer being verified on the system (kinda like the blue tick on twitter if you have been verified by them) @paradoxxjm ?


The default state is false. Buyers may start the registration process with the call into the centre, but have to be verified later by the JAS. Ultimately the admin is the one that makes the change to verified.


As you are working on extending the squirrel interface towards AI, you might be strongly interested in this topic:

http://forum.simutrans.com/index.php?topic=14785.0

I would be glad if you could join the discussion. After all, we should not do the same work twice in parallel.


Can you explain why you need all these changes in pom.xml?


:facepunch:


This commit adds the `Modelica.Icons.Package` icon to packages that didn't have them before. I didn't add it inside `SimplePlanarMechanics` package, since that is more or less stand alone.

This commit also removes some empty lines.


thx


This revision is clean.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.48.3fd04293f9034b95c013ae5d4f6827dcde22e7be](http://build.palaso.org/viewLog.html?buildId=62990&buildTypeId=bt2) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 734, ignored: 45 Build time: 00:57:16


How do you pull changes @dkayiwa ? This merge is equivalent to this commit https://github.com/openmrs/openmrs-module-adminui/commit/ecd286a06acbabfa40d054e2b38811f99ddf477b
Seems like you used git merge instead of pull --rebase


You're awesome! Thanks a lot!


Makes sense.


has comentado a freddy y a isaura? porque?


Did you try an interspinx ref?
```
:ref:`python:pickle-picklable`
```


A remplacer par &


What's the problem with 0.2.4?


Is there a dependency between `stack` and `pcre` ?

See this issue : /https://github.com/commercialhaskell/stack/issues/531

> But aside from that, stack shouldn't need libpcre. Did you build your stack binary yourself? And, if so, how? There was a brief period when the master version of stack did require it due to the ignore library using it, but now we use a newer version of ignore and set the without-pcre: true for it.

```
@arch-docker ~ > ldd /usr/bin/stack
	linux-vdso.so.1 (0x00007ffc681b5000)
	libpthread.so.0 => /usr/lib/libpthread.so.0 (0x00007f4e1f69d000)
	libpcre.so.1 => /usr/lib/libpcre.so.1 (0x00007f4e1f42d000)
	libz.so.1 => /usr/lib/libz.so.1 (0x00007f4e1f217000)
	librt.so.1 => /usr/lib/librt.so.1 (0x00007f4e1f00f000)
	libdl.so.2 => /usr/lib/libdl.so.2 (0x00007f4e1ee0b000)
	libgmp.so.10 => /usr/lib/libgmp.so.10 (0x00007f4e1eb79000)
	libm.so.6 => /usr/lib/libm.so.6 (0x00007f4e1e87b000)
	libc.so.6 => /usr/lib/libc.so.6 (0x00007f4e1e4d7000)
	/lib64/ld-linux-x86-64.so.2 (0x00007f4e1f8ba000)
```
Cheers,


This is probably not the docker command you want: `RUN python morgenbot.py`
Also you should use the Python onbuild image.


Not sure if this check is entirely necessary - gonna do some research later and find out


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20357/testReport/) for this commit**


@tremainebuchanan just curious... why `"Buyer Report" + " " + "-" + " " ` as opposed to `"Buyer Report - " + `?


I've got my side ready - I think - there's something weird on the "add".
In any case, I couldn't figure out how you were thinking about the call to
the database populating the specific pages. We might have to sit down with
it.
Dan

On Wed, Sep 9, 2015 at 11:06 AM, lumpyspacecoder <notifications@github.com>
wrote:

> The code is set up for Dr. Price's code. He told me to push it up because
> he said his code would be done in time to absorb my changes. But you're
> right, I will fork it.
> On Sep 8, 2015 11:01 PM, "peggylind" <notifications@github.com> wrote:
>
> > This commit doesn't run when I try it on my local machine.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/DataAnalyticsinStudentHands/DataMaps/commit/457aaeaa292029b7fb16deaf3e402d3e46135f9b#commitcomment-13127273
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DataAnalyticsinStudentHands/DataMaps/commit/457aaeaa292029b7fb16deaf3e402d3e46135f9b#commitcomment-13140289>
> .
>


should this file be here?  just want to make sure this wasn't an accidental commit.


Gabriele, I think this commit messed up Mdsconnection.java. It no longer compiles.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/79505807


Ok. I'll make the change.


but the limited Scheduler only limits reading from the queue, right? With Task.Run + HideScheduler, message handlers can be executed in parallel (even when the concurrency is set to 1)? Just for my understanding.


a


I managed to salvage this from a fork. Going to mirror it and then re-add.


Hello Debbiswal

I noticed that you are using this fix inside your SE.Redis client. However, this has not been merged into the official repository, since I decided to close the pull request associated with this change before it got merged. The reason i closed this pull request was that i found a bug in the SE.Redis behavior after applying this change when the user specify only a single endpoint in the ConfigurationOptions. I did not get a chance to find the root cause of this failure because of my change. After reverting back the change above, SE.Redis was able connect successfully to the cluster with a single endpoint configuration. So I would advise against using this fix

Thanks


A lot of this also applies to the include from options-argument which is used in all the shorthand animation methods like `fadeOut` etc. I haven't tried to resolve that, I suppose this could be turned into an include as well and dropped into all those files.

Perhaps another possibility would be to eliminate all the ugly un-DRY documentation in the shorthand method files and just give the equivalent `.animate()` call, pointing them to `.animate()` for more info? It seems unfortunate that it takes so many XML files to document [11 lines of JavaScript](https://github.com/jquery/jquery/blob/250a1990baa571de60325ab2c52eabb399c4cf9e/src/effects.js#L604-l615).


Checkmarx scan results 09 Sep 2015 12:42 UTC -04:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
2
4
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

549d113ba6b69c54670a2ee2d3c2587765eb3081	@virginiacc


It is already public (default visibility has been changed).


Commit was reverted


0.4 is so damn good. Really happy for this.


That is cool, thanks! We needed that!
On the other hand, from a strictly logical point of view, wouldn't be better to move it as a single function somewhere else inside the library (resection?, sfm) so that it can be called without passing through the localization class (eg it could be now used in Sequential_SfM after the resection of a new view, it will improve the encapsulation of the code and the readability) I know, it's static, but still it seems to me that is a kind of "fundamental brick" that is not necessarily linked to the localization class. What do u think?


Yes we can, but in case someone used say 'visible 0' after the update gets nonworking script.


fast-forwarding master to auto = 3a661988


I cannot remember where I read it belongs in the plugin section...
I am back at home in about an hour, can you post some logs to verify it? :)


good use of a package


The npc always displays the vendor menu but has gossip menu data:

```code
[1] UpdateType: CreateObject1
[1] Object Guid: Full: 0x1C15A00000007AC000002900005D388D Creature/0 R1384/S41 Map: 0 Entry: 491 Low: 6109325
...
[1] Object Type: Unit (3)
[1] UNIT_FIELD_FLAGS: 512/7.174648E-43
[1] UNIT_FIELD_FLAGS_2: 2048/2.869859E-42
[1] UNIT_FIELD_BASEATTACKTIME: 1500/2.101948E-42
[1] UNIT_FIELD_BASEATTACKTIME + 1: 1500/2.101948E-42
[1] UNIT_FIELD_BOUNDINGRADIUS: 1050455048/0.306
[1] UNIT_FIELD_COMBATREACH: 1069547520/1.5
[1] UNIT_FIELD_DISPLAYID: 3342/4.683139E-42
[1] UNIT_FIELD_NATIVEDISPLAYID: 3342/4.683139E-42
[1] UNIT_MOD_CAST_SPEED: 1065353216/1
[1] UNIT_MOD_CAST_HASTE: 1065353216/1
[1] UNIT_FIELD_MOD_HASTE: 1065353216/1
[1] UNIT_FIELD_MOD_RANGED_HASTE: 1065353216/1
[1] UNIT_FIELD_MOD_HASTE_REGEN: 1065353216/1
[1] UNIT_NPC_FLAGS: 4739/6.640753E-42

ServerToClient: SMSG_QUERY_CREATURE_RESPONSE (0x0EDB) Length: 116 ConnIdx: 1 Time: 08/26/2015 23:44:04.031 Number: 9114
Entry: 491
Leader: False
Name: Intendente Lewis
Type Flags: None (0)
Creature Type Flags 2: 0
CreatureType: Humanoid (7)
CreatureFamily: None (0)
Classification: Normal (0)
[0] ProxyCreatureID: 0
[1] ProxyCreatureID: 0
[0] CreatureDisplayID: 3342
[1] CreatureDisplayID: 0
[2] CreatureDisplayID: 0
[3] CreatureDisplayID: 0
HpMulti: 1
EnergyMulti: 1
QuestItems: 0
CreatureMovementInfoID: 0
RequiredExpansion: WorldOfWarcraft (0)
FlagQuest: 0
Title: Intendente

ServerToClient: SMSG_GOSSIP_MESSAGE (0x0E0A) Length: 72 ConnIdx: 0 Time: 08/26/2015 23:47:26.000 Number: 12822
GossipGUID: Full: 0x1C15A00000007AC000002900005D388D Creature/0 R1384/S41 Map: 0 Entry: 491 Low: 6109325
GossipID: 4107
FriendshipFactionID: 0
TextID: 5010
GossipOptions: 1
GossipText: 0
[0] ClientOption: 0
[0] OptionNPC: 1
[0] OptionFlags: 0
[0] OptionCost: 0
[0] Text: Me gustaría comprarte algo.
[0] Confirm:
```


Yes, you are right. I will stop the test.


This fails for me `assert(ret OP_EQ 1): 0 vs 1`


This also fails for me, with `assert(ret OP_EQ 1): 0 vs 1`


Perhaps useful, rather than `while 1` we currently do `while stack_making_progress()` and that function is:
```
def stack_making_progress(stack_name):
    stack_status = get_stack_status(stack_name)
    return stack_status.endswith('IN_PROGRESS')
```


Hey @tremainebuchanan is there a reason you are changing so many file permissions in this commit?


true, it can be 0 for the root directory.  And if the root directory has an error we should indeed still throw an error to the user instead of deleting all the data on the server.


Some experiments on node labeling.


develop (kbenne) - i386-Windows-7-VisualStudio-12: OK (2316 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.1%25-yellow.svg)


Oh wow!!!  How long before codegen rewrite can go in the new 0.5.0-dev master?  Really impressed by all the stuff done to make 0.4 wonderful that I've seen in the < 6 months since I started with Julia.


Hi Sbhat7, thanks for the update!


we should, this was just a hotfix to make sure we can roll out a good version asap.


Can this stuff go in the https://github.com/OSVR/OSVR-Android-SDK/tree/master/NDK/osvr to simplify?


environment variable


Provided facebook ID doesn't match with any user


>  `return  AnalyticsJobHierarchy.Group.ALL.equals(job)`

I don't think so because we want to find if an existing job overlaps `job`. If `job` overlaps an existing job, we want to schedule it.


I think this goes off and prints lots and lots of junk? You might do something like this to avoid printing super old messages from the last time you did an update stack? Just a suggestion, not a requirement.

```
            if datetime.datetime.now() - e.timestamp > datetime.timedelta(30):
                # don't start off the event tail with ancient events. 30 is
                # arbitrary.
                continue
```


Think at the time the hyphen was too close to the buyer report text.


`osname` should always be part of the deployment variant I'd say, so g_assert_not_reached or something in `else`?


for i = 3 ? Not 2?
Looks like it is better to have test for this.


Why the caps on the method names?  I don't think that's normal.  Also some comments on the method could help.  The way I read it right now it looks like PyJmultiMethod only supports at most two methods with the same name?


Support for running tests in parallel and the --parallel option were added.


Could we just convert the .md file to .rst manually and include it in the repo?

The approach in this commit adds quite a large dependency just for the conversion. It also breaks install on windows:

C:\Users\Mike Croucher\GPy>python setup.py install
Traceback (most recent call last):
  File "setup.py", line 90, in <module>
    long_description=read_to_rst('README.rst'),
  File "setup.py", line 18, in read_to_rst
    return read(fname)
  File "setup.py", line 10, in read
    return open(os.path.join(os.path.dirname(__file__), fname)).read()
IOError: [Errno 2] No such file or directory: 'README.rst'

To fix this, I'd need to install pypandoc which would require an install of pandoc.


This should clarify

> For .NET 4.5, we introduced the TaskCreationOptions.HideScheduler and
TaskContinuationOptions.HideScheduler values.  When supplied to a Task,
this makes it so that in the body of that Task, TaskScheduler.Current
returns TaskScheduler.Default, even if the Task is running on a different
scheduler: in other words, it hides it, making it look like there isn’t a
Task running, and thus TaskScheduler.Default is returned.  This option
helps to make your code more reliable if you find yourself calling out to
code you don’t own.

http://blogs.msdn.com/b/pfxteam/archive/2012/09/22/new-taskcreationoptions-and-taskcontinuationoptions-in-net-4-5.aspx

and we don't own the handler code and potentially also not the code inside
the user provided behaviors.


So the ClientContext object typically also handles lifetime management (automatic closing) so storing it here in a raw pointer negates that. Perhaps a `std::unique_ptr`?


101884340-Crash-with-missing-AirflowNetworkMultiZoneZone-object-#5029 (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1833 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


> Oh and wait there is another issue: It only makes sense to look for the job with a higher recordId when the `AnalyticsJobHierarchy` group is the same (because two jobs are not equivalent).

Yes, isn't it taken care of by `findScheduledOverlappingJobs` above?


More robust to just do `if (!ctx)`


method should be renamed to the actual case that `resultHasErrors()` returns false


Copy-paste and the same 3=>2 bug?


Thx!


I've been coding recently in vim so it's not like I'm running a formatter....but some spaces would be nice.


updated


TeamCity ChameleonForms :: Continuous Integration [Build 252](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3650&buildTypeId=bt20) is now running


on miui it saves 100-200mb ram oO :D


maybe add either the size of the mempool, or the band number or multiplier or something here?


Done 25d294f55e782c93ecfa0db046f095549ac5b960


Two ifs with the same check close to each other.
Merge 2 ifs into 1 please.


Absolutely right. Though, the use of sql reserved words wasn't ideal either (probably my fault years ago as well...)


Shouldn't have to wait for a JointClientKit, but anyway, can check `gClientContext->checkStatus()` in both this and the normal usage.


indeed.. resolved now, thanks


This is not a big deal, but the convention in Jep is PyJlowerUpper, e.g. PyJmultiMethodObject and PyJmultiMethod_Type.


> I don't think we do this consistently at the moment

That is true, two files ( [`entities-legacy.inc`](https://github.com/whatwg/html/blob/d862a6bf6c0ae094a4bbfe0db08739edb6786c37/entities-legacy.inc) and [`404.html`](https://github.com/whatwg/html/blob/24aab83274e8a5fd98666d50a3ffd02ccf19cce4/404.html)) do not currently respect that indentation size. For those 2 files, we can either fix the indentation, or make some changes in the `.editorconfig` file.

I proposed this change because while editing the `.htaccess` file I was a little bit annoying: since no default (or a file specific) indentation size was specified for any of the files except `source`, vim just defaulted to the size I have set by default (4 spaces).

>  Will this enforce anything?

I do apologize, but I don't really understand what you mean by that.

It will basically make editors which know about the `.editorconfig` file use 2 space as the indentation size without requiring the user to (re)set anything.


Is there a missing space at the end of this error message line?


I didn't because I wasn't sure how to do implement it before. I think I have an idea about how it should be done now, but maybe that should wait until everything else has been fully reviewed.


I would argue less linuxy is not always good :) but I guess you mean more windows friendly.

I would change mgmt to "connection" as that would be the ansible lingo. But some home "Connection Port" does not really sound good.

So maybe "Ansbile Connection Port" ?


Värdelös commit! Ta bort.


could also use `nullptr`, which is more, well, C++11ish. =)


This reminded me of some free's I very recently committed, fixed in d8137a2


You only want `skip_before_action :verify_authenticity_token` on your API controllers, I suggest using a base api controller that has this line instead of disabling it for ALL controllers.


Can you change the namespace by Kpdz\FaceBookRestServerBundle\Security on all the project please?


If by chance something in the app does use cookie based sessions, and is not using the API to fetch user related data.


because as the PR suggest, this allows the code to run on any *nix system, obviously the exception would be windows


I don't think PyJobject should be doing the Py_INCRED on cached and pymethod.  I think the pyjmultimethod_new() should handle that as that's what's actually going to hold the reference, right?


New warnings here for cooling coil when MaxCoolAirVolFlow is 0 and SA flow method field is none or blank.


New warnings here for heating coil when MaxHeatAirVolFlow is 0 and SA flow method field is none or blank.


@Vowstar, you put the exta line in the wrong ROMtable. It should have gone in `wifi_ap_map` at line 1129, say.

Having repeated entries in a ROMtable screws up the `next()` function and therefore `pairs()`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20358/testReport/) for this commit**


Just a note that the Mission bucket length is not 16 like Bounties is. IIRC, it's now 8.


Relaxed logic where the other coils air flow will be checked and if autosized, then use autosize for the coil that does not have an air flow rate input field.


Here are two codepaths that need to be updated to get 0 fees working:
https://github.com/stellar/stellar-core/blob/master/src/transactions/TransactionFrame.cpp#L345
https://github.com/stellar/stellar-core/blob/62b505004ef8c9db4cdfc7d9fc42ac1ea34b98a1/src/ledger/LedgerManagerImpl.cpp#L685


Add @throws on PHPDoc please.


I'd suggest a time-based wait here, something like:

```c++
using clock = std::chrono::system_clock;
auto timeEnd = clock::now() + std::chrono::seconds(2);
while (clock::now() < timeEnd && !gOSVRDisplayConfig->checkStartup()) {
   gClientContext->update();
   std::this_thread::sleep_for(std::chrono::milliseconds(1))
}
```


Thanks for your point of view.
Will try to see what it could implies if it moves to the sfm module


Maybe we should throw an exception here instead of just returning false?


injecting an anonymous function is not something we would ever do. The problem is you functions like getManifest, onGetManifest, etc can not be overridden in subclasses, and can't be extended. Generally we use factories to perform DI so we can define factory method to return an instance of a controller. You can see examples in the ref app. For example SpiRef.BaseController.newInstance.


Didn't change them explicitly. The only thing I remember doing to them was uploading the svg files to a site that converted them to png. The js files I think was changed when I used another laptop to develop.


These changes reflect the mining functions and code changes needed to get the coil air flow rate inputs from the child components. Not much to see until my next comment, but feel free to critique.


beech


Similar lifetime concerns apply with the `DisplayConfig` as with the `ClientContext`, though at least here, if you fail to clean it up, the client context shutdown will clean it up.


Ok that makes sense.


same note here, don;t get into the habit of using anonymous functions


Yes indeed.


hey @caijun I see that this test failed on firefox on my machine. do you think we can run this test on travis? it seems to me like we should, since it does not involve any fancy server stuff like the shiny tests.

```
1. Failure (at test-save-separate-chunks.R#214): save separate chunks for non-spatial geoms with repetitive field, multiple vars selected, and NAs
no.chunks not equal to 52
52 - 53 == -1
```


Quanto sugere então Uirá?


I checked in game- Mission is on the Inventory screen and has 10 slots.


yay


We should be able to refactor these with something like

```ruby
get 'revision_analytics/:controller_action', controller: 'revision_analytics', action: controller_action
```


That's what we had it set to in our config for the previous version of this plugin. [Upstream](https://github.com/polimediaupv/paella/blob/paella3.0/config/config.json.default), the default config is very sparse and doesn't including this plugin. Yes, it would be great if it was easy to tell what it should be from the historical stats.


This function is redundant, remove


you really should be using them as svg though.... why are you changing to png?


new folder


5110_stdbaropress_sealevel (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (775 of 775 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-18.75%25-green.svg)


lololol


Comparing the expected and actual location and query string should also be extracted. The way of doing it seems a little redundant. I suggest using a function that returns both the parsed URL *without* the query string and the parsed query string separately as an array?


ok I got it now, the option only applies within (not including) the started task. Makes sense. just forget everything I wrote. -.-

+1 for merge :D


@rauchg This change doesn't seem to be included in the latest `master`. https://github.com/socketio/engine.io/blob/8705870ed7b73e3454840fc7e79113bc6cdbccda/package.json#L29


remove


well you get the multiplier by the fee required..


Change made for Coursera


Yes! But not with `.add`, but with `.update()`. `check_methods` is a tuple.


Should actually be fixed now


@kirbyfan64 This is why I code Java...


Could we obsolete the comment by using a super descriptive variable or method name?


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0+025](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3650&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 3009 Build time: 0:0:0


typo


TeamCity ChameleonForms :: Continuous Integration [Build 253](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3651&buildTypeId=bt20) is now running


You're reviewing WDTK commits? :)


this should something bigger than 2000


@alk No worries, I'll rewrite the commit message and re-send a pull request.


empty in-line comment


single quotes instead of double quotes


We needed to have png files for emailing the buyer report. The svg files did not upload when I was using the sendgrid api.


Awesome work guys!  Arraymageddon here we come :)

On Wed, Sep 9, 2015 at 12:47 PM, Scott P. Jones <notifications@github.com>
wrote:

> Oh wow!!! How long before codegen rewrite can go in the new 0.5.0-dev
> master? Really impressed by all the stuff done to make 0.4 wonderful that
> I've seen in the < 6 months since I started with Julia.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JuliaLang/julia/commit/54165680c979d510f80d0322accd1126f407fbfa#commitcomment-13141066>
> .
>


I assume the 404 is because this doesn't match the route. Take another look at `routes.rb`.


@mart-e this indentation will cancel the price_unit values returned by the if...else clauses , did you mean it ?


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 48](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=148&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Per the comment and the commit log 0.2.4 failed to build. Once 0.2.4 is fixed or someone has time to develop and get a fix merged the older version will be used. It is usually preferable to not do such a stop gap but at times it is necessary to keep this layer in a working state.


how am i supposed to remember what min relay fee i started up my node with


Stephen has gas, lulz


I'll push this to heroku. Good catch.


Thank you. I forgot to commit DBIxIntrospector. Should be fixed by 8d5c2ade4952cc85791fefc1b0d7cc2515836d56.


I think there should also be `ACC_SUPER`


what's the difference here?


serviceディレクトリ配下のファイルをspec_helper.rbでrequireしてるからL3に`include Oishinbo`って記述すると`Oishinbo::XXX`って書かなくて良くなる


I don't see `quirks_mode` as a valid option key [in the docs](http://ruby-doc.org/stdlib-1.9.3/libdoc/json/rdoc/JSON.html#method-i-parse). What on earth does that do?


I'm learning so much!


If we decide to remove exceptions hidding here, I will fix it.


Does this compile? Looking at the PEG, it should only accept uppercase letters and `*` as values for a course section.


you stop with this ?


The difference here is that the shell command is going to run on the buildbot master, which is an Ubuntu machine, rather than on the slave, which is a windows machine.  The windows machines are having HTTPS connection problems, I believe because of some kind of security setting that is too strict, but which neither I nor the Openstack guys have been able to figure out.  My next step is to recreate the `status.julialang.org` certificate, but until we get that actually done (and that requires Stefan's attention, which won't be available for another couple of days) we need some way to tell the world about these builbot's hard work.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20362/testReport/) for this commit**


Is this just some debugging code? If so, let's remove it.

It also looks like it is working with two different request parameters: 'equation' first, and then 'equation_id' second. Was that intended?


Ah. I saw this  in an example, but maybe it's not real anymore. The problem I was trying to solve is accomplished by the gsub, so this can go.


Don't you want to use the new Work Table formspec ? It's far better now.


You have lots of cases with overflows.
(Btw, unlike most of the other acceptance tests in the public code repo, you actually have the right answers for these test cases :+1: )


@tseaver First, thanks for cleaning up.

Removing the double colon has as effect that the url on the next line is treated as a real url, instead of being shown literally and not clickable. Since the url is `http://zopeserver/my_stuff/externalEdit_/document` there are two problems with that:

1. It is not a link that anyone browsing PyPI should follow, as it points to zopeserver.

2. It gives an error parsing the ReST: Unknown target name: "externaledit". This is because the `externalEdit_` part of the url annoyingly get treated as a target name... Yes, it is sneaky. :-/

Anyway, fixed in b78a505333b69a13e1755e036baf40482ee6ce06.


It doesn't seem to parse, which is probably good.

although, it should spit out a better error message than `SyntaxError: Expected "&", "|" or end of input but "." found.`


This doesn't appear to be used anywhere…?


A minor point on whitespace consistency: let's have a single character whitespace between braces and keywords, and between parentheses and keywords. That is, "if (typeof..." and "} else..." rather than "if(typeof ..." and "}else".


Not quite, this overwrites the existing config with the command line arguments. Otherwise you wouldn't be able to overwrite the host using cli arguments.


This was purely to make @gamingrobot happy by getting rid of the move.py file. As far as I'm concerned movement is currently in the same place Physics was before all the recent updates. A placeholder with effectively zero functionality. That naming and everything will catch up when the implementation is actually written


Copied-and-pasted from an old BSD version (I think the current BSD versions do locale-dependent comparison, which is exactly what I *didn't* want - I want "i" and "I" to be treated by this routine as equal everywhere, including Anatolia).


細かいけどこの部分は毎回呼ばれるのでインスタンスの生成を最小限にするためにメモ化するべき
つ メモ化

` @service ||= GurunaviApi.new`

これは ` @service = @service || GurunaviApi.new`と同じことで@serviceがnilの時だけオブジェクトが作成されるのでオブジェクトの生成を最小限にできる


sounds good, will fix tonight.

On Wed, Sep 9, 2015 at 8:22 AM, Steven Chambers <notifications@github.com>
wrote:

> On this fragment, it would probably make more sense for the user to select
> weather or not they are a student or a teacher, then if they are a student
> they are asked for their name and student id and if they are a teacher they
> are just asked for their name. Generally its not expected for anyone
> besides the phone owner to be using the owners phone, so using password
> authentication feels strange.
>
> This step is mainly just to establish what kind of user the user is, get
> the relevent identifying information from them, and present them with the
> proper interface.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/colegarien/SDDTermProject/commit/e5012dd1d62dd6050a18d019c8e613c791c9185a#commitcomment-13135962>
> .
>


"onmessage" handling semantics is completely unclear for code reader.
Why you run 1000 ms real timeout before test case. And you don't check that 1000 real ms has passed.
You really had to create function with human readable name such as applyTimeVirtWebWorkerJasmineWorkaround that just says "Ok, time virtualizer web worker would work in tests thus timeVirtualizerWould work".


What does POO mean?


Have you verified that this name change works with earlier versions of the standalone server JAR file?  There likely will be cases where people update SeleniumPlus but keep using an older selenium-standalone-server JAR file.


this is incorrect: this is the balance of account [n]

the balance doesn't need to cross winnerVote, what needs to cross is
sum(i=0..nbAccount-1, balances[i])

fix is probably adjust nbAccounts to something bigger so that the sum crosses the threshold.


Overflow cases


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0+025](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3651&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 3009 Build time: 0:0:0


no pb ;-)


I think a clash is possible for sources with the same short name and in the same package but with different facade names, isn't it?


TeamCity ChameleonForms :: Continuous Integration [Build 254](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3652&buildTypeId=bt20) is now running


@klemens-mang I was about to commit then when I had a thought: what if the proposal at hand is a winning proposal? In that case it would have a "wrong" ribbon, as it's either a "judges choice" or "popular choice" ribbon, rather than a finalist ribbon. Maybe that's why Manuel ignored existing ribbons? I think it's probably safer to keep that behavior.


</html>


I'm not sure why MdsConnection.java was changed at all but it looks like a section of the code was just indented and the leading:

   if(message == null || message.length == 0)
   {

line was omitted leading to the compile errors.


Admittedly one large commit, it includes the following:

- added dialog before urgent automatic `downloading` and `install`
- added scheduling for install at shutdown
- added `last_check_urgent` in `status` to have multiple check times for different priority levels
- added (as comments for now) different check time for urgent priority
- fixed spelling in `apt_wrapper`
- renamed `restart` view to `finish` and css to reflect reboot/shutdown behaviour


¿Cómo así pc? ¿Aún con el copy+paste?


Nice :+1:


Your .out file does not match the .in file


This could just be `revision.update_attribute(:report_url, url)`. That would call `save` automatically.


The port should be 15994


Where are the specs to confirm that these methods behave as expected? How are these methods being tested right now?


@wluyima i did a pull and forgot to add --rebase


Why do you decrease the dependency?


@jpcummins if you do something like `">=0.7.1"` I would kindly merge this :)


We discussed this in person last week, I don't entirely understand why it works with and without the `syntax-local-introduce`. The original use of `syntax-local-introduce` here was an attempt to fix a bug that ended up being unrelated.


I would vote for keeping it src/checkstyle/* as we do for findbugs, etc.


Sorry, it's OOP (oriented object programming)


Si lo hice fue por algo no cree ? uno tiene comentado el procces data y el otro no, intente enviarlo por uno solo pero se dañan unas cosas del foro


I would have called this variable `ms` due to the plural name.


They are only in my mind at the moment...

Should I just create a spec that tests each of the model methods?


3.0.2 has been released. It's important for French users at least


Looks like I've seen similar patch before :)


Ah! ¡Que chevere que estamos reutilizando cogido! pero  pues no entiendo cual era la necesidad de hacer un POST2, PUT2, ¿con un parámetro booleano no es suficiente?.
¡Esto me ahorró mucho trabajo!


What do you think about the idea of `HancockRecipient#update` not only updating the remote recipient (at DocuSign) but also the locally cached (i.e. in-memory) version? Alternatively, we could be even more conservative and call out to DocuSign to retrieve the latest attributes for this recipient?

Either way, I'm thinking about cases where code calls update on the `HancockRecipient`, then continues to use the in-memory recipient, which now has attributes that don't match the actual DocuSign recipient.


#4672-AirLoopHVACUnitarySystem-with-heating-coil-but-blank-heating-supply-flow-fields-does-not-heat (rraustad) - x86_64-MacOS-10.9-clang: OK (1825 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.56%25-yellow.svg)


Thanks


No map shown, but can submit to cloudant


+1. Thanks for enabling the FB publishing!


ps pongalo yo no le veo problema con tal de q funcione pa mi esta bien

El 9 de septiembre de 2015, 12:22, Aslhey <notifications@github.com>
escribió:

> Ah! ¡Que chevere que estamos reutilizando cogido! pero pues no entiendo
> cual era la necesidad de hacer un POST2, PUT2, ¿con un parámetro booleano
> no es suficiente?.
> ¡Esto me ahorró mucho trabajo!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/degreeworkunivalle/Front/commit/49a8d021270f6209ead9d71b055edb014b353d72#commitcomment-13141795>
> .
>


To compile I needed to install the package: qttools5-dev-tools


Please clarify. What does it mean "Timeout object is less then another Timeout object?" We haven't provided any comparation operator on Timeout objects.


Why not just `target = fallback`?


lol, I had clashes and when did pull --rebase, my commit went away.  You suck :)


K awsm thx


Ok, Thank You for explaining this to me, I apologize if I have broken any part of the Licence, I hope to never do it again.

-ManUtdPlaysMC.


@oleg-nenashev 2.16 does not work fine excluding `target/generated-sources/**/*.java`. I'll investigate it in a different PR.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 48](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=148&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:18:44


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 15](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=149&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


Shouldn't this default to `null` if it is going to be doubling as a state flag?


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 15](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=149&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:49


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0-PullRequest128+027](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3652&buildTypeId=bt20) outcome was **SUCCESS**
Summary: Tests passed: 2617 Build time: 0:0:0


too?


TeamCity ChameleonForms :: Continuous Integration [Build 255](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3653&buildTypeId=bt20) is now running


OK, it was definitely on a 30s timer. Here's an example event history from a session back in July:

```
"history" : [
{
"action_type" : "HEARTBEAT",
"ts" : "2015-07-12T20:26:32-04:00"
},
{
"action_type" : "HEARTBEAT",
"ts" : "2015-07-12T20:27:02-04:00"
},
{
"action_type" : "HEARTBEAT",
"ts" : "2015-07-12T20:27:32-04:00"
},
{
"action_type" : "HEARTBEAT",
"ts" : "2015-07-12T20:28:02-04:00"
},
{
"action_type" : "HEARTBEAT",
"ts" : "2015-07-12T20:28:32-04:00"
},
{
"action_type" : "HEARTBEAT",
"ts" : "2015-07-12T20:29:02-04:00"
},
{
"action_type" : "HEARTBEAT",
"ts" : "2015-07-12T20:29:32-04:00"
},
{
"action_type" : "PLAY",
"ts" : "2015-07-12T20:29:40-04:00"
},
{
"action_type" : "PLAY",
"ts" : "2015-07-12T20:29:40-04:00"
},
{
"action_type" : "PLAY",
"ts" : "2015-07-12T20:29:42-04:00"
},
{
"action_type" : "SEEK",
"ts" : "2015-07-12T20:29:49-04:00"
}
]
```


Fixed my accidental deletion of a file.


hmm...good point. These checks do seem unnecessary. If `fallback` isn't passed in, it'll just naturally be `undefined` which is what I was ultimately getting at.


There is one in rar code.  I would like you to look at that one.  It is at bottom of function, there are 2 MEM_FREE calls just 4 or 5 lines up.

Now, I am not 'sure' why free was wanted here. Possibly we wanted a libc_free() (or whatever we called that wrapper), to actually get down to the 'normal' free without the memory wrapper stuff.  I did not touch that one.


Nice, thanks.

Why have you added the dialog twice in the download function? It looks like if the status is NO_UPDATES the dialog will be shown twice

In https://github.com/KanoComputing/kano-updater/commit/93daac8349427559c7a9b14f942b385ceea12592#diff-ca199486a265a2fd8f6260918d0bcf19R514
 you could make use of https://github.com/KanoComputing/kano-toolset/blob/master/kano/utils.py#L166


Thanks for this! And for the googles, the error I was encountering with this as reported by ansible:

    failed: [1.2.3.4] => {"failed": true, "name": "mygroup"}
    msg: pw: -g expects a number


A spec for each model method would be good.


Claro que lo ví. Igual, para mi si hay manera de evitar ese c+p.
No tiene porque molestarse, si no quiere aprender nada está bien, no vuelvo
a hacer comentarios (cuando el código funciona).

El 9 de septiembre de 2015, 12:21, donberna <notifications@github.com>
escribió:

> Si lo hice fue por algo no cree ? uno tiene comentado el procces data y el
> otro no, intente enviarlo por uno solo pero se dañan unas cosas del foro
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/degreeworkunivalle/Front/commit/49a8d021270f6209ead9d71b055edb014b353d72#commitcomment-13141769>
> .
>


@oleg-nenashev I used the current location. The file was in the project root folder. I used to use `src/main/config` this folder was design for these things. But I see that the Standard Directory Layout [has changed](https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html)


@oleg-nenashev Updated!


Ok. Good. Timeout object defines its behavior now.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 49](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=150&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


Was supposed to be 2 commits, but somehow when I had to rebase, it merged into a single one.

This was an enhancement to the unify_case code within format.c   And then there is a non-associated change to media-wiki to have the 'pre-init' split function to properly unify case in all code pathways.


Ok, fireTSMS has ordering.