Using VectorCommunicationCache with dynamic networks could cause a segfault on some edge cases.

The value of the 'receptionInterval' pointer is used as the criteria for deferred removal, but it was not initialized until first use. A radio that never used its cache yet could have its entry incorrectly erased on removal of an unrelated radio.

These edge cases were simulated normally if MapCommunicationCache was used instead.


Що за прикол? Кавичка відкрита


It might be an idea to also add the extra fields to the standard pop-up. But the standard pop-up is IMHO much to cluttered for adding sender or delivery addresses as is needed for Intervlag, which really just need the address fields.


I don't get it. Why not using a class like : public JobIDTaskID(JobId jid, TaskId tid) ?


so something is not working well when mvn zanata:pull-module and mvn replacer:replace -N
so we have to revert this


I think it's better than keeping a counter


And for that purpose I also need the related company and the address type to be readonly.


@alwey: Thank you, but Marco is pretty right about everything. I hope that
I'll prove that I'm not an enemy.

On Tue, Sep 15, 2015 at 11:03 AM, alwey <notifications@github.com> wrote:

> @mcostalba <https://github.com/mcostalba>: Perhaps it is not the best way
> to shout at newbies like this. I'll take some of the blame, because my
> local testing hinted at positive results for longer time controls. This
> will have encouraged Ivan to skip the 60s+0.05s and kindly ask for the
> permission for an extra long TC test. Also, the approver might have seen it
> earlier and have asked Ivan to stick to 60s. What Ivan did make wrong is to
> stop his first tests early without decisive results. But he already
> promised to stick to the rules.
>
> Regards, Alfred
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/IIvec/Stockfish/commit/bf3023f13b50ac02808d51e6e50c29917004defb#commitcomment-13232100>
> .
>

--
IQ World <http://www.ultimaiq.net/>


OK, I can create an external script to write the switching results in a file and import this results to do the tests.


Plus, your code doesn't ensure that it is the last call that sets the elements


Example:
https://DOMAIN.api-us1.com/admin/api.php?api_key=API_KEY&api_action=graph_interaction_rate&api_output=json


I think for these we need to use the the rails helpers, because of the asset pipeline caching:

```erb
<%= tag('link', :rel => 'apple-touch-icon', :sizes => '57x57', :href => image_path('apple-touch-icon-57x57.png') %>
```


I'll do this :)


I'd keep things simple and just remove the `if` statement; the need for `isMainFrame` looks very specific to Chrome's reader mode use case.


It's not enough, because a user can have no role set


@KonstantinKo : Braucht es diesen commit eigentlich?


It works fine and no issue found when setting up 10 Dbs with 2.000.000 records and insert + iterator through 50.000 records


For someone who is just learning Wordpress, this seems confusing. It would be awesome if you can give some examples. Thanks.


@behrad, i'm not sure about the regeneration - my guess that it atomatically happens on the first access to the Kue's UI, but i might be wrong. And yes, that file was auto-generetad from the *.styl files, except for a minor fix i did for .context-menu li a:active -- it was generating color constant on its own line before all the "background" values.


but only the contributors have the user_type == user, right?


Looks nice so far, I'm really excited if you will get a usable NDS emulator :D
Inspires me to write a debugger for my emulator, I scrimshanked (hope this is the correct word lol) myself about that until now. I can do some debugging using breakpoints and writing some extra checks, but it's  not very comfortable and smart.


## This is a markdown file


This causes the build to fail: Trailing whitespace

Also this doesn't make sense to me. When building in release mode `idx` isn't declared causing line line 206/207 to have an error right?


shouldn't we match the layout used in node.properties. I don't know where this pattern is used honestly.


Keine Ahnung ob der fixture gebraucht wird, aber wenn es nen neuen Filter geben soll dann sollte der auch im IDENTIFIER array stehen, ja.


Get rid of the debug statement and hard-coded e-mail addresses in the JS.


with a clean project : for sure.

In LimeSurvey, it seems that there is a lot of js and css loaded every where in the project : from controllers, views, helpers, etc. It's very hard to say which file will be loaded and in which order. For example, this bug I corrected yesterday:
https://github.com/LimeSurvey/LimeSurvey/commit/bdca02357a751a61fba1a14c7f5c42e8e87e1964

wasn't making any problem in ls2.06 because jquery was loaded first somewhere else. In the 2.5, it was making problem.

So, to focus on the UX dev, rather than in the css and js library dependencies, to avoid to get some piece of css or js overwriten by some other calls, I put all the js and the css in the header.php.

So I'm sure that my code is overwriting any other CSS or JS. So, I can focus on the important tasks.

The re-factoring / debuging of the new CSS/JS will be done in only one cycle : at the end, when I'll have a complete overview of the admin code. It will be an easy, long and repetitive task. It's more efficient to do it last.

Of course, for a new application, it's better to start immediately with css/js packages using assets manager.


Remove footer


Change title


I'd drop bug id from here.


We can get a performance boost if we modify the regular expression to begin its search at the beginning of the string instead of searching the entire string.

What do you think?


How to manage ACLs.....


Sure! Why not :)


Do you have a strong opinion one way or the other on changing ```queryTopics``` to ```query```?  I'm thinking that would make all the factories consistent in naming and how they function.  Plus, you are already in a "manage_topics" file so it seems a bit redundant.


<img width="1191" alt="screen shot 2015-09-15 at 12 33 37" src="https://cloud.githubusercontent.com/assets/11146524/9874418/25d1451c-5ba6-11e5-9989-aac3b9f6807d.png">


not require anymore


E.g. this commit could have "Contributes to JB#30556" on the commit message.


you should copy `phpunit.xml.dist` to `phpunit.xml` ;)


> i'm not sure about the regeneration - my guess that it atomatically happens on the first access to the Kue's UI, but i might be wrong

can you test that?
Is this really fixing your injection claim or the problem will still be there?


Nice discovery. For those interested in further reading – [http://www.w3.org/TR/html-markup/syntax.html#void-element](http://www.w3.org/TR/html-markup/syntax.html#void-element).

Helpful examples include: ```area, base, br, col, command, embed, hr, img, input, keygen, link, meta, param, source, track, wbr```.

I recognise a range of 6 element tag names I doubt I've ever or will use.
Fascinating find. Thank you @r7ay


check using get_place(12.9667, 77.5667). Aru ami city buli column eta dibo lagibo nki rey places table khon't?


Yes, mistake. I already removed it.


ok, fino a ieri "turno" era un oggetto di tipo Game e non di tipo Quantum prima delle modifiche di ieri (e quindi turno.setupPartita() era illegale). Grazie per la spiegazione perché effettivamente non era chiaro che turno corrispondeva al gameSystem centrale.

Le interazioni tra le classi che stanno nella cartella engine sono un po' confuse in generale.


To use exceptions we should have a exception policy and other code should be modified outside this plugin to catch exceptions in a consistent way. If you agree, I will commit the modification to use null.


Can we go to a single ```getAll``` function that takes an ```options``` object argument.  This way you only need the one function that is flexible enough to cover the search case too.  You can just default the options if not provided.


In release mode the entire logging line below is not compiled (`LOGD` takes everything out in preprocessor), so it doesn't fail.


@Aestu I don't mind having this, currently we have no consistency anyway.

For LS3 however there are clear interfaces and as long as you obey them it's fine.


Il est maintenant importé depuis extensions. Je n'ai plus de problème d'imports.


<img width="1191" alt="screen shot 2015-09-15 at 12 33 37" src="https://cloud.githubusercontent.com/assets/11146524/9874525/be5207b8-5ba6-11e5-81f4-0a37013beaab.png">


Nice idea! Wish you success for testing.


so cool,but when i receive a memory waring,the pics reload from flash memory ,i can not find the reason.


Well actually, I think it does. Besides, I cannot access to restangular there. For all I know, the fetch method my not even use it. I cannot consequently cancel the method unfortunatly.


I think it is worth looking into the Zanata system to make sure the error is not directly there (before trying to fix mvn zanata:pull-module)


Thank you very much!


Any reason for this change?


J'ai laissé la fonction qui fait rien à la ligne 99 - 100 du coup


@cyrilf the use case is when you call fetch consequently, for instance if you watch a filter that change values very quickly (typing, or other).

Before this, the update method was setting the list element to the one send back by the last method that *responded*. So if you call myList/fetchA and then myList/fetchB and fetchA ansewered after fetchB, the list had the result of fetchA.

This was, in our case, causing the weird refresh behavious when searching quotes in the big input.


OK!~


nice code


En fait, je me demande si ce n'est pas une erreur de faire ça. Si le deposit plante, on ne le saura pas, puisqu'on sera redirigé...


shouldn't it be named findBuildConfigurationSet?


started


sdagfsag


Bah on le laisse dans la fonction appelée si succès et c'est tout


Fixed.


Yo


I agree, mentioned it. Feel free to suggest a better wording.


thats not all, scroll down


Нам это не нужно проверять


請問可否加回字型編碼對應的選擇，例如 KaiGenGothicTW 在 Windows 上只有"西歐字母" "日文"選擇。

謝謝


OK, it'd be nice to put here a note... (to avoid someone simplifying it in the future)


Voilou, on peut éventuellement mettre une alert dans le navigateur avec "echec depot cheque" avec le console.log :)


It is not needed anymore. Dependency has been removed many years ago, see d02d54b0f6044a18d49be48e25d3e42ff581bbf8


Don't push to master! We use a pull-request based design. Now I have to revert your commits and put them to a seperate branch.


Is the suffix behind ``Word`` and Omnigraffle intended ? It resolves in the final build text as
![screen shot 2015-09-15 at 11 50 02](https://cloud.githubusercontent.com/assets/2478303/9874725/598e2bfa-5ba0-11e5-8445-cb4763529303.png)

(the screenshot taken from the present help.o...y.org site, so this is what the users see - intended ?)


requires to be alphabetised


Nice to see the test backing up the code change.
:thumbsup:


@aaronang


This Regex is not quite proper; for example it allows every two digit combination for hour and minutes (like 42:12). Should I change it to be more restricted?


Why do you check for null, when ``toBCSet`` doesn't return null?


The client may inform the user, the specification talks about ignoring the STS advertisement which is the correct thing to do since it haven't been verified in those cases. Whether or not the client generates a warning in those cases is up to the client.


@pwalczysko - yes I think we do need the Registered Trademark symbol with these mentions.


With regards to the error behaviour of `find`, and in case you've not encountered `find_by`, you can use it when you want to avoid raising an error which sometimes happens:

```
# Item with id 987 doesn't exist
Item.find(987) # raises RecordNotFound error
Item.find_by(id: 987) # returns nil, no error raised
```
Docs for other available `find*` methods: http://api.rubyonrails.org/classes/ActiveRecord/FinderMethods.html


@Ilvec: I never assumed neither you nor Marco being an enemy ;-)


This should probably be translated to English...


Thanks


Remove the reduntant dot(.) in the params


@eirslett  This change seems wrong, no? Shouldn't it be ...

```java
if ("v4.0.0".equals(nodeVersion)) {
    return nodeVersion+"/win-x64/node.exe";
}
```


5194_fix_failing_unit_test (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (799 of 799 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.28%25-green.svg)


And same in the code following it.


Thank you.


Yeah


The messages all look well documented. I think what we need to document now is what the different languages send for different syntax, and what things like the Java interop will send. On the Ruby side the protocol is currently very fragile. I'll start documenting how Ruby responds to messages and the messages it sends.


broken :(
```
The following build commands failed:
	CompileSwift normal x86_64 {SRCROOT}/Carthage/Carthage/Checkouts/swift-sodium/SodiumTests/SodiumTests.swift
	CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler
(2 failures)
{SRCROOT}/Carthage/Carthage/Checkouts/swift-sodium/SodiumTests/SodiumTests.swift:98:48: error: missing argument label 'key:' in call
A shell task failed with exit code 65:
```

xcode 6.3


Yes exactly, this doesn't claim anything like that. The point of the framework was to make a more formal way of *co-operatively* disabling client functionality than the somewhat prolific "block codes" which were very common a couple of years back. Basically client-side mod authors would have their mod watch for a carefully crafted MOTD (usually with a bunch of colour codes in it) and disable certain parts. For example Rei's minimap supported block codes to *enable* the entity radar (disabled by default in multiplayer) and Zombe's mod used to use them to let servers disable flymode and noclip.

The issue with block codes was that they were a nuisance to administer and weren't very granular, and also limited you to a handful of permissions per mod before the sheer number of codes became unmanagable. The idea of `ClientPermissions` is that it's a replacement for block codes that ties the client mod permissions directly into the server-side permission framework (originally into bukkit perms). This means that server admins simply need to define the client mod permissions along with the rest of a group's or user's permissions and let the framework take care of synchronising everything.

That's all it is, just a replacement for block codes that's more flexible and easier to administer, it's not meant to be in any way secure (at least no more secure than block codes were) but it is meant to be easy to use. If you want to read more about it you can see the DBO page [here](http://dev.bukkit.org/bukkit-plugins/clientpermissions/) which has a demo video as well.


```"Phones": "Phone"```, also missing from OBJECT_NAMES,

Was about to submit a similar pull request and saw this


Лишний файл судя по всему.


Right, you can enable Weapon Recoil Pitch in Crispy Doom and it will slightly tilt the pitch as you are shooting. You'll have to implement view pitch support the whole way through for this, though.


tabs vs spaces struggle continues


Тоже лишний файл


This line should be kept, lint npm script will run eslint, which is unrelated to karma


keep this line for linting guidance


Alright, I see the use case now. And I do understand the code too.


this one as well, for linting setup


Leaving the label unfortunately breaks on Xcode 7 and Xcode 7.1 :(


Not DRY. `.bind(keys, handler)` repeated.  I'll add here a wrapper function similar to the scope event binding.


I think we should use unified approach here. Let's always use prefix, no matter which browse we use. E.g.:
```js
document.title = 'browser-id:' + document.location.toString()
```


Not sure these paths are correct?


did you test this is not needed? will this gulp task fail when some karma tests fail? If not, then it is ok to remove the comment above too.


Comment is unnecessary


Oh, I thought it was a function ;)


It's inconsistent with the README, where we recommed to add `title`-prefix


Not sure these paths are correct


I'm not sure if it's a good idea to do these kinds of language specific things from depending on which language is run:
In this case, we want to tap on

..but this element is in the way:

For ltr, there is a spot to tap on on the right side and for rtl, there is a spot to tap on on the left side.
So you could check for the position of label id="menuItem-enableStorage" and if it has the same position as label class="pack-switch", tap on the right hand side. If it doesn't have the same position, then tap on the left hand side.


\r-


原文: Those happen to pop up in Scala world as well. You’ve probably heard at least one of them before. There is also a lot of ignorance as well. Have you ever wondered how lambdas are implemented or how Nothing is represented in the JVM? How did they manage to create traits in the single-inheritance environment?
訳案: 同じことが Scala の世界でも起こっています。（…）今まで不思議に思ったことはありませんか。ラムダや Nothing は JVM の中でどのように表現されているのか？ 多重継承のない環境で、どうやってトレイトをうまく実現しているのか？


no they aren't - I had to change the paths and forgot this file, they should be ```assets/mstile-70x70.png```


@chris-grove  Thanks, there were two commits (035c008 AND 0ebbde3) because I edited the Author or the commit while trying to linking my git repository identity to my ebi git checkout identity.........teething problems ;)


This is great- thanks! I vaguely remember them saying they'd eventually expose the reference like this, but suggested hacking around it by using that `adapter._getRef()`. Glad to be rid of that logic.


Such validation is a good candidate for a unit test for the function producing the time. Here I think, what we have right now is good enough.


Decorators should be in `src/reporters/errors/decorators


In terms of efficiency, you guys could pass in both the age and name variables into a single prompt function. Instead of having two separate functions.


You're right : we don't have actually consistance on CSS


Update


fixed at https://github.com/bcosca/fatfree-core/commit/f442d7255050e3c8bcfbd329f35601a3e496113f


go has a simpler method called len, to do length.


Could this fix be backported in 8.0 branch? Having "Quantity Available" column showing forecasted quantity is very confusing.


#coding=utf-8
__author__ = 'root'
import jieba
import jieba.analyse
import math

class ContentBasedRecommend:

    def get_news_words(self,m,address):
        news_words={}
        for d in range(1,m+1):
            news_words[str(d)]={}
            address1=address+'/%s.txt'%d
            f=open(address1,'r')
            text=f.read()
            f.close()
            for j in jieba.analyse.extract_tags(text,10,True):
                news_words[str(d)][j[0]]=j[1]
        return news_words

    def get_user_behave(self,url):
        user_behave={}
        f=open(url,'r')
        text=f.readlines()
        f.close()
        for i in range(1,len(text)):
            text[i]=text[i].strip().split(':')
            if text[i][0] not in user_behave.keys():
                user_behave[text[i][0]]=[]
            user_behave[text[i][0]].append(text[i][1])
        return user_behave

    def get_single_similarity(self,news1,news2,news_words):
        w=0
        w1=0
        w2=0
        for word1,weight1 in news_words[news1].items():
            w1+=weight1*weight1
            for word2,weight2 in news_words[news2].items():
                w2+=weight2*weight2
                if word1==word2:
                    w+=weight1*weight2
            similarity=w/(math.sqrt(w1)*math.sqrt(w2))
        return similarity

    def get_similarity(self,news_words):
        S={}
        for news1 in news_words.keys():
            S[news1]={}
            for news2 in news_words.keys():
                if news1==news2:
                    continue
                s=self.get_single_similarity(news1,news2,news_words)
                if s==0.0:
                    continue
                S[news1][news2]=s
        return S

    def single_recommend(self,user,user_behave,S,r_num=10,k=5):
        r={}
        for i in user_behave[user]:
            sor1=sorted(S[i].iteritems(),key=lambda x:x[1],reverse=True)
            if k>len(sor1):
                for j in range(len(sor1)):
                    c=sor1[j][0]
                    if c in user_behave[user]:
                        continue
                    if c not in r.keys():
                        r[c]=0
                    r[c]+=S[i][c]
            else:
                for j in range(k):
                    c=sor1[j][0]
                    if c in user_behave[user]:
                        continue
                    if c not in r.keys():
                        r[c]=0
                    r[c]+=S[i][c]
        sor=sorted(r.iteritems(),key=lambda x:x[1],reverse=True)
        rec={}
        if r_num>len(sor):
            for x in range(len(sor)):
                rec[sor[x][0]]=sor[x][1]
        else:
            for x in range(r_num):
                rec[sor[x][0]]=sor[x][1]
        return rec

    def recommend(self,m,address,url,r_num=10,k=5):
        recom={}
        news_words=self.get_news_words(m,address)
        user_behave=self.get_user_behave(url)
        S=self.get_similarity(news_words)
        for i in user_behave.keys():
            recom[i]=self.single_recommend(i,user_behave,S)
        return recom

# m=500
# address='/home/zlx/下载/news/dataset'
# url='/home/zlx/下载/news/user_behave.txt'
# r=ContentBasedRecommend()
# recom=r.recommend(m,address,url)
# print recom['1']


There is no check for projection system. Area will be measured, but with wrong result using WGS84. The notification here is to explain that the result will not be in square meter but the same as the unit of the spatial reference system.


For each light (max. 3) you can assign an area (left, center, right).

I'm working on improvement to resolve this issue, see the develop branche.


Yes, both Linux and Windows.


Does it build ok with musl?

On Tue, Sep 15, 2015 at 8:39 PM, Dima Krasner <notifications@github.com>
wrote:

> Major efficiency improvement in printcols.
>
> Aggressive buffering, use of arrays instead of conditions, less atoi() and
> parsing only up to the highest field index specified make printcols much
> faster. This speeds up 1download, especially the incredibly slow "first
> pass" thingy.
>
> And yes, printcols is one of the ugliest pieces of C code I've ever seen.
>
> @mavrothal @01micko - the x86_64 and ARM binaries need to be rebuilt too.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/puppylinux-woof-CE/woof-CE/commit/224fcf160d7f943c9df2909a442adac3d85e9266
>


danke


Trying to remember why we did this. I think it was something about filtering out presences whose ties had been cut somehow to their user. I don't think that should happen going forward, but not sure. Also, I think if the presence has an underlying user id set, `presence.get('user')` will be a promise (truthy) but it might resolve with `null`.

In short, seems ok to me :smile:. We can revisit if we start seeing weird presences in the chat.


Je vais regarder ça.

2015-09-14 18:51 GMT+02:00 Cesar Leblic <notifications@github.com>:

> Point light pass optimized
>
> @paulbaron check that ! Ca te semble okay ? Meilleures perfs (50%
> meilleures) et aucune difference visuelle.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Another-Game-Engine/AGE/commit/9ff162dffbd786db6700af9e8d5efba6cfe98ac8
>

--
Paul Baron


I'm using the old ``choose-swank-loading-method`` branch of slime and merging from the master every now and then. I'm maintaining a [toolkit](https://github.com/code-iai/ros_emacs_utils) which helps Emacs users who program with ROS (Robot Operating System) and / or Common Lisp; the Lisp part is based on slime and the users got used to it, it's been like that many years, so I'm being conservative about switching to a different fork and everything. It's not like we have so many users (it's really not that many) but still...


Actually, @garethrees do they need to be rails helpers too?


This discards the message given and the messages hard-coded in CoreLibrary, is that not a problem?


Aah yes, you're right! I missed that!


Fin titel


This messes with things, when installing from npm:
```
> git submodule update --init --recursive && node-gyp rebuild

fatal: Not a git repository (or any of the parent directories): .git
npm ERR! Darwin 14.4.0
npm ERR! argv "node" "/usr/local/bin/npm"
```


I noticed that the body element has a data-ready="true" attribute. Perhaps, that does what it implies and we can use that to check if the Ringtones app is ready to use?


Yes, sure. The x86 binaries I uploaded were built against it.


Looks like a stray character here.  If you don't have a chance to fix before I pull this in, I can do so in my copy after and push it back up.


See previus commit "Fixed 11.4 Economy". Changes where overwritten by later push.


FYI added this to get some dev dependencies that were thrown out with the wash, probably during ember cli upgrade. I wish they'd make it easier to merge new dependencies with old instead of wanting to just overwrite your package.json...


all relevant points are mentioned and properly explained :+1:


101280704_lowTempRad (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1857 of 1872 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.2%25-yellow.svg)


I'll agree that it needs to be in the issue tracker. But I still think that any file requiring collaboration should be source controlled. Of course it should also be properly organized and not directly inside the code source tree. Plus I didn't want to host the images in a separate place.


cool

On Tue, Sep 15, 2015 at 9:25 PM, Dima Krasner <notifications@github.com>
wrote:

> Yes, sure. The x86 binaries I uploaded were built against it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/puppylinux-woof-CE/woof-CE/commit/224fcf160d7f943c9df2909a442adac3d85e9266#commitcomment-13234580>
> .
>


THANK YOU


5194_fix_failing_unit_test (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1335 of 1335 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.21%25-green.svg)


@dan-palmer nice work! :+1:


Here it should use `Nan::To<int>` again. It goes for all instances of `->XXXValue` and `->ToXXXX`.


What about if we compile at build time so we don  carry binaries?
If not I can do ARMv7 but I think we should do ARMv6 (that I do not have)


It seems you forgot to remove ```if (tfw_connection_put(conn))```


ACK. I'll also add the "test" script field again.


nice


fetch data from excel file and put into sqlite3 database


That's a possibility, but it's nice to have a static binary, because 1download and PPM run printcols for every package. It's the accumulated inefficiency (and the overhead of starting a dynamically-linked binary) that slow things down.


101280704_lowTempRad (Nigusse) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Этот метод разве называется `isProjectExist()` ? Возвращаемое значение надо инвертироват обратно.


lel, way to go.

Would break if they introduced a `forceRebuild` to derivations, though. :P
How about using a random hash instead of `true`?


Yeah, I figured this out as well, should be fixed along with my latest PR, branch feature/optimization


You're right, 400 is the right one.
And you can even lock this to specific methods directly in routing config. But it will require additional handling of unknown route exceptions and stuff which is beyond the scope of this task.


Очень может быть, что от була надо отказаться в сторону перечислимого типа. Потому что есть три состояния
- создали модель визардом
- не создали модель
 - потому что проект уже существует
 - потому что что-то пошло не так (у тебя три ретурна из метода initializeProject)


Для этого было отдельная таска https://github.com/aurusov/rdo-xtext/issues/69


test method names should start with test*


See comments here: https://github.com/readium/readium-shared-js/pull/174#issuecomment-140359908


done!


When adding padiing top or bottom ...Nicescroll do not scroll to bottom.

**Need to change also this**
```javascript
        this.getContentSize =
            (self.ispage) ?
            function() {
                return {
                    w: Math.max(document.body.scrollWidth, document.documentElement.scrollWidth) ,
                    h: Math.max(document.body.scrollHeight, document.documentElement.scrollHeight)
                }
            } : (self.haswrapper) ?
            function () {
                return {
                    w: self.doc.outerWidth() + parseInt(self.win.css('paddingLeft')) + parseInt(self.win.css('paddingRight')),
                    h: self.doc.outerHeight() + parseInt(self.win.css('paddingTop')) + parseInt(self.win.css('paddingBottom'))
                }
            } : function () {
                return {
                    w: self.docscroll[0].scrollWidth,
                    h: self.docscroll[0].scrollHeight
                }
            };
```
**into this**

```javascript
        this.getContentSize =
            (self.ispage) ?
            function() {
                return {
                    w: Math.max(document.body.scrollWidth, document.documentElement.scrollWidth) + (self.opt.railpadding.left + self.opt.railpadding.right),
                    h: Math.max(document.body.scrollHeight, document.documentElement.scrollHeight) + (self.opt.railpadding.top + self.opt.railpadding.bottom)
                }
            } : (self.haswrapper) ?
            function () {
                return {
                    w: self.doc.outerWidth() + parseInt(self.win.css('paddingLeft')) + parseInt(self.win.css('paddingRight')),
                    h: self.doc.outerHeight() + parseInt(self.win.css('paddingTop')) + parseInt(self.win.css('paddingBottom'))
                }
            } : function () {
                return {
                    w: self.docscroll[0].scrollWidth,
                    h: self.docscroll[0].scrollHeight
                }
            };
```


Yep. Fixed in https://github.com/mysociety/whatdotheyknow-theme/commit/bbe14d36b3d51626f7c33b1aa7889d176de1dde5


This has been merged and is available in version 0.5.0


Is this by intention? You calculate 3 different values and all assign it to the same array index 0.


Brilliant thanks


TeamCity pull requests :: netty [Build 205](https://garage.netty.io/teamcity/viewLog.html?buildId=1368&buildTypeId=pulls_netty&guest=1) is now running


There should be allMatch


Guess it's up to JL. I see no problem depending on qt >= 5.4.


All is well that ends well and if you still consider me a friend it is a good ending. We both benefited from this. My code is better now too.


01-js-intro-and-jquery/Topic 1: JavaScript Intro and jQuery/index.html

In English please :)


Is this true? We tend to provide our means when we need a feature that the data store does not support, but we rely on the feature of the data store if possible.


This is good stuff. But it seems a check for `getopt.h` + `getopt()` is missing. Needed in the `tests/` programs.


01-js-intro-and-jquery/Topic 1: JavaScript Intro and jQuery/js/script.js

try to write for future cases the function definition like `function () { ... }` not like `function(){ ... }`


Please refer to the current version of README.md for requirements & installation instructions. You should use the version from master, not the latest release.


IIUC ignoreErrors was jest-specific (it's not in the karma docs). So the comment can go away as well. However, I think I'll change the gulp task a bit, using the gulp-karma runner, and add a watch task as well.


Not my idea...


Same here, also try to use a full name for the parameter to be more detailes, we have no issue with long names (except for some cases, whenever you do not exceed 120 characters it's just fine :) )


fdg


Try to use an `.error` class instead of inline styles.


I was wondering if we shouldn't switch to new signal->slot connection syntax available in Qt5. It has some cons, but I believe it's still worth it. (see: https://wiki.qt.io/New_Signal_Slot_Syntax)


Typo Delete ;)


Exactly. One cannot conclude anything with so few games.
The best illustration I have is when we look at the different workers in the fishbench results.
After 1000 games each, all the possible ranges of results are usually exhibited, from -30 to +30.

Even with a  +20 after 100 games, there is no reason to be excited.
I would reserve the word "promising"  to a test which has fully passed a SPRT at slower time control.


Thanks for reviewing. I guess, I should not generalize. The only place I could find access to e.g. MongoDB aggregation was a custom query.


As a general comment is a good practice to avoid anonymous functions and trying to define the functions into a variable and use them into the needed places, just to do what we've talked into the meeting we had.


Please don't push thid to "stable", forget this release, and update to 1.3.9.


Nice, thanks!


Well, only if give your OK on renaming gtkui/qtui sections into something like 'ui' or 'interface'.
Keeping the default values for parameters in sync between plugins is OK, but the list of parameters will probably differ.

I didn't check myself, but let's imagine the following situation. GTK UI sets some parameter into non-default value, so it gets written to config. Then Qt UI is started which doesn't use that parameter in the same section. Will that parameter be deleted after Qt UI use? Or will it stay there?


Is it for sure for both `values` and `values-v21` folders? I don't see it for `values-v21` folder here:
https://github.com/NativeScript/android-runtime/blob/release/build/project-template-gradle/src/main/res/values-v21/styles.xml


**Code Quality - Critical**

You have a missing semicolon here.
You should end all variable assignment and function calls with semicolons. Use sublime text plugins next time to avoid such mistakes.


ありがとうございます！この内容で修正しますー！


**Code Quality - Critical**

You should use `===` when comparing values as its a more painstaking comparator than `==`.


You should open the branch from master and not from the branch for topic 0 maybe you should copy the files and try to re open the branch only with the changes from the topic 1. Take a look :) will talk about this today on the daily meeting


idk why this did nothing but I'll figure it out another time


Gut. Jetzt noch das gleiche für normale Box-Titel.


And then, after renaming the section for GTK, users will be surprised getting unconfigured GTK UI. Is there a section renaming func somewhere?


This assert is peculiar, and causes a failure when e.g. only node.js is present on the system. This test does not require two different engines to run?


I just wanted to be awake when the test would be run, so that I could cancel if clearly worse after 10 M games. But the test started anyway, and finished with possible ELO>0, but not much likely.


Ups, yes, this is a python style I always forget exist, but it's way nicer.


please return the value as well


Thanks. Then we can leave it as it is today.


lel... Stupid me confusing strings and integers


Забыл в info.php закомментировать/удалить ссылку на опции - появляется две ссылки. В общем, нужно удалить:

```php
'options_url' => getinfo('site_admin_url') . 'plugin_feedburner',
```


Looks good. Merging.


Actually, marked down https://github.com/kripken/emscripten/issues/3776 directly.


We probably haven't found a way to integrate that feature yet, but it doesn't mean that we aren't going to do it.
Some features aren't easily mapped with the current API, but we tend to provide a solution when we can find one. Or when we have time to implement it.

> Thanks for reviewing

Thank you very much for doing this.


The current docs seem to use "unapply" in the context of migrations whereas "roll back" is mostly used when it comes to database transactions.


I like the idea of having a deferred in the mocked class, I will explore it.

BTW, self.receiver.sleep is not an sleep it's actually a callLater.


keypoint -> goal (to not confuse with keypoint == features)


ignorance は、文脈からするとストレートに「無知」と訳して良さそうな気がします。folklore は民俗学でいうところの[「伝承」](https://ja.wikipedia.org/wiki/%E3%83%95%E3%82%A9%E3%83%BC%E3%82%AF%E3%83%AD%E3%82%A2)ですね。あまりうまい訳が思いつかないのですが、ここでは「民族的伝承」というよりは「都市伝説」みたいな雰囲気なんですかね（urban legend は folklore の一種であって厳密には別物だと聞きますが）。


solution by doing an exhaustive testing


will change to gerrithub/openstack-packages/ to avoid confusion where to push


6 point => 6 point"s"


munch => much


TODO add all git commands


outiler => outlier


> Needed for _WIN32?

If it was needed, maybe it should be moved into libpcap's `"bittypes.h"`? Which gets included via `"pcap-stdinc.h"` and via `"pcap/pcap.h"`. Or maybe not since IMHO the include-files are *so* confusing for libpcap programs on Win32. E.g. there is the gcc-generated dependencies for print-ah.c:
```
$(OBJ_DIR)/print-ah.obj: print-ah.c config.h netdissect-stdinc.h \
 ../../libpcap/Win32/Include/bittypes.h \
 ../../libpcap/Win32/Include/net/netdb.h \
 ../../libpcap/Win32/Include/net/paths.h ah.h netdissect.h ip.h \
 ../../libpcap/pcap.h ../../libpcap/pcap/pcap.h \
 ../../libpcap/pcap-stdinc.h ../../libpcap/Win32/Include/IP6_misc.h \
 ../../libpcap/pcap/bpf.h ../../libpcap/pcap/dlt.h extract.h
```
As things are now, one needs 2 `INCLUDE` directories in a libpcap program on Win32.
I think it would be best to somehow drop `$(LIBPCAP_ROOT)/Win32/Include`. It can be simplified. E.g. the stuff in `$(LIBPCAP_ROOT)/Win32/Include/net/paths.h` has no place in a Windows program.


~~,in our software,~~


software -> solver


git push -u gerrit rdo-liberty


@kergoth: this commit was intended to fix preferred provider conflict between libgbm and mesa-gl. However, this commit is not required since we already have mesa-gl_%.bbappend in meta-mentor-glsdk addressing the same problem. Will be sending PR to bring that mesa-gl_%.bbappend back. Thanks!


correspondances => correspondences


6 point => 6 points => 6-point => must choose only one solution... perhaps with a latex macro...


using System;

class Program
{
    static void Main(string[] args)
    {
        bool stillRunning = true;
        int choice;
        Game myGame = new Game();

        while (stillRunning)
        {
            choice = ShowMenu();
            switch (choice)
            {
                case 0:
                    stillRunning = false;
                    break;
                case 1:
                    myGame.Timeleft();
                    break;

            }
        }

        Game.Start();
    }
    static int ShowMenu()
    {
        int input = 1;
        Console.WriteLine("1. Search for player");
        Console.WriteLine("2. [Placeholder for later use..]");
        try
        {
            input = Convert.ToInt32(Console.ReadLine());
        }
        catch (FormatException)
        {
            Console.WriteLine("Wrong input");
            input = 1;
        } // end try
        return input;
    }
    public class Game
    {
        public static void Start()
        {
            Console.WriteLine("En spiller er fundet.");
            LightsOff();
            SoundOff();
            BeginGame();
            Console.WriteLine("Tryk på en virkårlig tast for at afslutte spillet...");
            Console.ReadKey();
        }
        private static void LightsOff()
        {
            Console.WriteLine("Lys slukkes.");
        }
        private static void SoundOff()
        {
            Console.WriteLine("Lyd slukkes.");
        }
        private static void BeginGame()
        {
            Console.WriteLine("Spillet starter.");
        }
        public void NoResponse()
        {//Når timer udløber kaldes denne metode
            LightsOff();
            SoundOff();
            ButtonInput();
        }

        int findPlayer = 0;
        bool test = true;

        public void ButtonInput()
        {

            while (test == true)
            {

                if (Console.KeyAvailable)
                {
                    test = false;
                    findPlayer++; //Denne værdi skal bruges i Activation

                }

            }
        }

        public void Timeleft()
        {
            for (int a = 10; a >= 0; a--)
            {
                Console.WriteLine("Søger efter flere spillere... Tid tilbage: {0} ", a);
                System.Threading.Thread.Sleep(1000);
                if (test)
                {
                    //start();
                    break;
                }
            }
            NoResponse();
        }
    }
}


Again no comments on code @prakashn27


noise-free / outlier-free ?
filetered => filtered


:+1:
Now, SimpleAuth and PurePerms fixed..


you're aware that @pqwy replaced it with a shell script [over in nocrypto](https://github.com/mirleft/ocaml-nocrypto/blob/master/postconf)!?!


I suggest pointing to https://github.com/ARMmbed/uvisor/issues for the time being.


How about we add that later once it's populated? It's frustrating to click on a link that contains no information.


101280704_lowTempRad (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (802 of 802 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.33%25-green.svg)


Could you look if the `README.Win32` file requires an update?


This is not O(n) its O(n^2) ... string.replace is O(n)


yup, but it is a complete list we can correct the identifiers later but gives us a starting point for the default price file


a few duplicates in there too i notice, must have been some typos by keen ?  or just the plurals..


I'm wondering if we want the format to be an array for `prepareVersion`? After all, the [`version_compare`](http://php.net/manual/en/function.version-compare.php) method works perfectly fine with strings like `2.1.10` without the need to blow out as an array. Thoughts @serbanghita?


It's necessary add explicit annotation for app using strict DI


訳案: 「JVM バイトコードに対する Scala 開発者の迷信と無知のヴェールを剥ぐ」

意訳し過ぎかなぁ。。*demystify* ってよく見る表現ですけど


I would compare against the actual class since this is really what we want:
`$this->assertNotSame($newInstance, MobileDetect::getInstance());`


I'm not sure which one is the best option :-)


this is still fairly inspecific. What strange symbols? Why not just give an example?

(also, symbols, not simbols)


Grammar


> (Or _alloca() with a #define, if compiling with MSVC.)

My MSVC `<malloc.h>` has this:
```
#if !__STDC__
    #define alloca _alloca
#endif
```
But an extra `#ifndef alloca` wouldn't hurt.


Not sure why we have this method to begin with. Did you mean to implement [`__destruct`](http://php.net/manual/en/language.oop5.decon.php) method instead?


TeamCity pull requests :: netty [Build 205](https://garage.netty.io/teamcity/viewLog.html?buildId=1368&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:30:25


I tried to add some examples with languages I knew (e.g. Java, C, possibly JavaScript) into the Truffle documentation. Do you want to have your own document (pros: you control it, cons: nobody finds it) or would you consider to add the sample Ruby code into the Javadoc of Truffle?

NetBeans has a concept of non-normative sections in Javadoc (like [createAndOpen](http://bits.netbeans.org/8.0/javadoc/org-openide-filesystems/org/openide/filesystems/FileObject.html#createAndOpen%28java.lang.String%29) and [addRecursiveListener](http://bits.netbeans.org/8.0/javadoc/org-openide-filesystems/org/openide/filesystems/FileObject.html#addRecursiveListener%28org.openide.filesystems.FileChangeListener%29)). It tries to explain how some API concept are really implemented in parts of the system that don't have their own API/documentation, but are essential for understanding how the API behaves.

Maybe it would be beneficial to include the Ruby samples next to the Message elements (pros: instantly ready for API readers, cons: hard to keep them in sync)!?


Please proofread the comments and strings in this commit. Seems kind of rushed.


хаха, вчера добавили, а сегодня всё удалили))


I think isValid should not be a function argument. I think you should refactor its usage to outside code


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20694/testReport/) for this commit**


this test name tests the opposite of what's in the actual test. I've pushed a fix in cda96cb04e2840db137cf7608e34ea46806698d7.


I believe this logic should be the exact opposite — only if the item *doesn't* exist in the boringEvents array, do we want to log it. Perhaps `boringEvents` should have been better called `ignoreEvents` or something :)


As some people may run it from fresh clones
git review -s


Will check.


HI


`.sample(1).first` is equivalent to `.sample`, which returns a random element when passed no argument.


Wow, I really shouldn't write commit messages while jetlagged


Yeah possible. See also internal JIRA ticket IOTDEV-558.


**Index Functions - Critical**

You should refer to `.getItem` from the class itself using `this` the current instance, not from an external instance created.

This line should be written like so:
```
index = this.getItem(term);
```

Replicate this change in other places required.


I have also tried to move the geom attribute (or declared_attr method) to the Waypoint model, as you suggested it. But with no more luck.


No warning is ok, since the declaration of *dostuff()* is unknown right? For *void dostuff(int)* there should be one?


Saltstack 2014.7 doesn't support json for auth to my knowledge, however,
1.2 releases of the plugin works.


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: demosite


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: fixtures


1: M100 needs more reviewers
1: M101 signature is missing


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: requirements


1: D100 Missing docstring in public module
19:1: W391 blank line at end of file


1: D100 Missing docstring in public module
4: L102 copyright year is outdated, expected 2015 but got 2014


24:1: I100 Imports statements are in the wrong order. from invenio.ext.assets should be before from invenio_base.bundles


40:1: F401 '_PACKAGES_EXCLUDE' imported but unused
41:1: I101 Imported names are in the wrong order. Should be RECORD_KEY_ALIASES, RECORD_PROCESSORS
41:1: I201 Missing newline before sections or imports.
45:1: I100 Imports statements are in the wrong order. from collections should be before from invenio_records.config
142:4: E131 continuation line unaligned for hanging indent
169:54: E261 at least two spaces before inline comment
169:55: E262 inline comment should start with '# '


`.menu` を以下のように書き換える

```sass
img.menu{
	width: 80%;
	margin-top: 20px;
        animation-fill-mode: backwards;
        -webkit-transition: 0.2s ease;
	&:hover{
		-webkit-transform: scale(1.2) rotate(-7deg);
		opacity:(0.8);
	}
}
```


`s/mkidr/mkdir/`


Are you sure this performs the same operation?
What provoked this change?


@kwwii the 4 and the 25% are aligned with the images. that's it


Please add new line at the end of the code.


(where new instance will be provisioned)


I see now, `libvips` is expecting a `double` for sigma and `int` for radius argument in `7.40.x`. I think casting it is enough for the `radius` param, so good point.


good idea! done 3f328918cb741333be899437354e36371001d332


to the instance


typo in comment :)


This part is a bit unfortunate...
Perhaps make a function to resolve the variables...


@ccx-testerbot runtests master


>> On Tue, Sep 15 2015 03:07, Martin Mächler wrote:

> If the default is
> "as before", the new behavior is very non-controversial as only those turn it on
> who hear / read about it, and do it consciously.

I think this is the case. The problem was that the UI wasn't decided yet. But I
think with the cycling M-q even the UI is settled now, so we are really safe on
this one.


:yellow_heart: There's no need to install `jasmine` as it was provided in the project files.


The idea is to have singular class responsible for persisting, retrieving, creating tasks on one given entity.
Not only this adds a useful layer of abstraction, it also reduces code duplication as well. And improves extensibility.

For example, imagine the case when you have more than 1 source of comments/posts/whatever.
Or when you decide to switch from ORM to ODM or vise versa.

It's not like i am so evil asking you to do strange things and refactor what already works, it's just what has to be done by default. When you develop stuff alone  -- it's fine, nobody cares, but when it comes to teamwork you gotta keep the possibility of other devs reviewing/working with your code in mind. :dancer:


@josevalim I think this is becoming a smell. We agreed to keep all the comments in the `:comments` field of a translation so that we didn't have to categorise them and the such, but right now comments like `#:` or `#,` are just noise in the translation maybe. The thing is, when we'll have fuzzy matching we'll have a place where we'll add the `"fuzzy"` flag to a translation (`update_in(translation.flags, &Set.put(&1, "fuzzy"))`); most likely we won't touch the comments there, so first problem is that they get out of sync.

IIRC, we agreed to keep all comments in `:comments


Thank you for the request. It has been added to the queue (id: 89). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/89) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


please return the value as well


Now play backgound music on your android
http://blogiapps.com/play-background-music-android-home-screen/


Would `Array#flat_map` work here rather than `reduce(:concat)` ?


now visit and look up best apps http://blogiapps.com/category/android-apss/


$invitation is not set, use $invitationId instead


needed to get Spark::defaultRole()


Please try (after the for-loop):

```python
import transaction
transaction.commit()
```


<img width="767" alt="screen shot 2015-09-15 at 14 21 06" src="https://cloud.githubusercontent.com/assets/11146524/9876278/1bd1373e-5bb5-11e5-8025-a569bd1bf805.png">

@F3PiX wdyt?


Since the Javascript API expects a token field on the invitation object, it cannot be hidden.


Sure, I'll make a new proposal.


....nom means npm


Nitpick: So far I kept the enum name close to the kernel name, i.e. maybe call this CGROUP_CONTROLLER_NET_CLS here?


Closes #11


These two `augaddsub()`s differ only by type in `dynamic_cast<...>`. Can be coalesced to a single method by using `boost::mpl::if<>` producing `self_type` or `scalar_result_type` depending on `U`.


the ids are 32bit, right? Should be uint32_t here then, no?


fast-forwarding feature/az/fetch-qry-results to borshop-integration-1184-gg/integration/timeseries = a9ad08ca


意訳しすぎな気もしますねぇ。
訳案: 「信じられてきた迷信と JVM バイトコードに対する Scala 開発者の無知のヴェールを剥ぐ」
長い・・・。

> folklore は民俗学でいうところの「伝承」ですね。
本当ですね・・。ありがとうございます！


I don't think it's a problem. We were already ignoring it in half the specializations (note: I probably wrote those, so that may not be a fair assessment). For whatever reason, Rubinius seems to build up its own error messages that sometimes aren't as detailed as the system-provided ones. While there is potential to maybe miss some context or a special-formed message that's easy to grep for, I think the trade-off of a single specialization that uses the same error messages consistently has value. This new approach always routes through jnr-constants, which uses `strerror(3)` to get the error message.


I needed to test the system as if it were written for the minibot, but with
the motor names of the big robot.


Can you update nuget package with this changes ?


thank you!


@dregad The second part is the portuguese version of the first, the same text =)


I'd not enforce this I must say. I'd just warn about the range conflict...


:red_circle: There's trailing whitespace here and on several other lines. These should be removed.


Doesn't this change the semantics if `o` is `nil` or `false`?


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 23](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=177&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


Nitpickish idea:maybe we should introduce HEX_STR_MAX() similar to the DECIMAL_STR_MAX() we already have? Would make this more explanatory.


This will overwrite the @topic from line 30. I don't think you want to do this...


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 23](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=177&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:55


How do I get a `Local` to an `int` using `Nan::To`? Doesn't it always return a `Maybe` or `MaybeLocal`?


the commit breaks AT reverting


Is dis real lyf


Fix ordering and grouping for these imports.


Virtual Hugs! \o/


is dis ril lyf


This `friend` produces a warning; i see no way avoiding it except eliminating the `friend`-ship altogether, but this would require making read access to the result's and jacknife's bins public.


Indentation...


Are the additions to .gitignore intentional or accidental?


Thank you for reporting this bug. I'm not sure if the provided fix is the right solution though. Could you give me an example that triggers this bug? I suspect the bug is somewhere else.


I'd personally not send this sort of details along with the main announcement. Another mail with the technical details for packagers would make more sense IMHO.


The "+ 1" looks wrong to me.


Hmm, thinking about this: you echo this into the attribute in hex, with the 0x prefix... but when one dumps the cgroup attribute you get it back as decimal anyway, so maybe we should just write this in decimal too, to avoid confusion?


This change removes `generate_location_rule` from the list of exported symbols, breaking the ABI of the `libpengine4` library from Pacemaker 1.1.12 to 1.1.13. As `pengine/utils.h` is an internal header, I guess this was an inadvertent export and the `generate_location_rule` symbol is not expected to be used by external code, so this removal shouldn't cause any breakage (otherwise the SO version would have been upped). Right?


Yes you're right, it would :)


In the 'CustomOutput' test, there were some outputs defined as 'SYMBOLIC' but they were not part of the source files, so the old code did not consider them as symbolic, and it failed the test.

The `GetSource`function iterates on the makefile sources and tries to `Matches` them with the input string.
I guess using the `Matches` built-in function is better than comparing the full paths, but I don't really know.


>I didn't check myself, but let's imagine the following situation. GTK UI sets some parameter into non-default value, so it gets written to config. Then Qt UI is started which doesn't use that parameter in the same section. Will that parameter be deleted after Qt UI use? Or will it stay there?

It will not be deleted, I have tested it with the statusicon plugins and the command
```sed -i 's|"statusicon-qt"|"statusicon"|g' statusicon.cc```


Fixed.


Remove `const` in the method signatures here.


an OSM


Why this check? isnt the netcalss id a valid one to assign fixed?


Yes, `Nan::To<T>` returns a `Maybe<T>` when `T` is a primitive and a `MaybeLocal<T>` when `T` is not. You need to unwrap it with `FromJust` or `FromMaybe`, as appropriate.


Thanks fixed it :)


The geometry must be


sounds like a good idea to me. Thanks for fixing that.


Please read ST_Transform if ...


Nitpick: instead of using LIST_FIND_HEAD() I'd probably use hashmap_get() to find the head of the list, after all, that's O(1)... Not that this would ever matter though....


Pourquoi pas l'IUT de VANNES ;-) ou CONLEAU


? Make similar change in the other `operator()`-s?


I'd really initialize this one in manager_new(), really.


Vi borde diskutera igenom pratiska saker, så som indentation osv.
Men vi kan ta det på torsdag.


Aha, most likely they were not in the target source files then.
As that appears to be the main difference in this change (previously the
scope of source files was only the target)

On Tue, Sep 15, 2015 at 10:33 PM, Packadal <notifications@github.com> wrote:

> In the 'CustomOutput' test, there were some outputs defined as 'SYMBOLIC'
> but they were not part of the source files, so the old code did not
> consider them as symbolic, and it failed the test.
>
> The GetSourcefunction iterates on the makefile sources and tries to
> Matches them with the input string.
> I guess using the Matches built-in function is better than comparing the
> full paths, but I don't really know.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/packadal/CMake/commit/4632c398158e6574df98eaec8e525c44841aae3e#commitcomment-13235848>
> .
>


not neede


not needed


should point to git.apache.org instead


Test with patch, error no longer exist.


Dòng 8, 12 giữ nguyên nhé.


Hmm, I recently moved allocation of a couple of hashmaps in Manager to be lazy, i.e. done when we need them, instead of any earlier. I think this should be done like that too, given that there's a good chance we never need that...

I.e. just use `r = hashmap_ensure_allocated(&m->cgroup_netclass_registry, &trivial_hash_ops)` when you start adding entries to it. Note that the hashmap and set code is written in a way that the NULL hashmap is actually considered the empty hashmap. Hence you need to call `hashmap_ensure_allocated()` only when you *add* something to the hashmap, but never when you read from it, iterate trhough it, and so on...


We should take all comments that we are handling ourselves out of the comments list. We will be fine as long as we emit them in the same order.


The test suite finished running the test files. Below is a summary of the test results:

| Report name | Tests passed |
| ----------- | ------------ |
| _Broken | 15/15 |
| _DVB | 5/5 |
| _DVD | 3/3 |
| _DVR-MS | 2/2 |
| _General | 24/24 |
| _Hauppage | 3/3 |
| _MP4 | 2/2 |
| _NoCC | 10/10 |
| _Teletext | **20/21** |
| _WTV | 13/13 |
| _XDS | 34/34 |
| _Options | **83/87** |
| _DTVCC | **0/14** |
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the [results](http://ccextractor.canihavesome.coffee/reports/89) page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.


You must add the compile step before, a simple mvn package -am -pl container/cassandra-guice will do


maven 3.3


hey @dfernandezii, I see that you removed the link to the stylesheet. Is that intentional? Were you going to replace it with another link to another stylesheet, or perhaps the default one?


This is not "potential" bug, it's quite real:
> man strncpy
> In the case where the length of src is less than that of n, the remainder of dest will be **padded with null bytes.**

(counterintuitive and new to me)

```
[alexander.petrossian@rhel6-build ~]$ cat t-strncpy.c
#include <stdio.h>
#include <string.h>
int main(){
	char a[]={'0','1','2','3','4','5'};
	strncpy(a, "012", sizeof a);
	printf("a[5][%c]\n",a[5]);
	return 0;
}

[alexander.petrossian@rhel6-build ~]$ make t-strncpy
cc     t-strncpy.c   -o t-strncpy
[alexander.petrossian@rhel6-build ~]$ ./t-strncpy
a[5][]
[alexander.petrossian@rhel6-build ~]$
```


you can remove this


Thanks Andy; this bug has hampered us for quite some time.


I'm using the [zenburn](https://github.com/bbatsov/zenburn-emacs) theme ([its helm face customs](https://github.com/bbatsov/zenburn-emacs/blob/eeed1d3fd090862d321692c0281abe028af9b606/zenburn-theme.el#L516)), this added line makes it looks odd:
![2015-09-15 8 33 34](https://cloud.githubusercontent.com/assets/4550353/9876536/639dfc08-5be9-11e5-804c-d1df81df47a2.png)

its original look:

![2015-09-15 8 37 52](https://cloud.githubusercontent.com/assets/4550353/9876577/b7a9d808-5be9-11e5-9fef-55d3a77bf1ff.png)

I don't know how this happened and how to fix it, any idea?


Strictly speaking, UTF-8 (and other 8-bit string encodings) can only correctly be represented using "unsigned char" arrays in Standard C, because -128 may be a trap representation. Granted, the vast majority of C implementations use two's-complement where -128 is not a trap representation (it isn't even clear whether any of the other options in Standard C would be consistent with POSIX), but I recommend using "unsigned char" anyway.


Dette hører neppe hjemme i EntityResource ...


Hey @otherholli, you don't need an 'end' at the end of this file.

Can you please remove it then just add, commit and push the changes (they will join your pull request)


So far we kep hashmaps that nap cgroup stuff to units in the manager code rather the cgroup code. (For example `manager->cgroup_unit` is managed in manager.c. I'd really do the same for this case.

Also, `hashmap_free()` returns NULL, so you can ake the if block one line.

Also, the "delete" if check sounds wrong. It is simply passed to indicate whether we should delete everything in the cgroup tree in the file system. However, our own resources should be unconditionally freed here.


I'm sure many of us would like to see this project
updated ... thanks.


Let's see how snicolet test will go.
Another idea will be to weight differently the p based on relative number of strong side pawns and no strong side pawns, or possibly some count of possible levers.

Or use an exp function. The biggest change should be around 5-6 pawns..


Type ``ogsInt`` is added in order to handle the different integer  types used to define index in PETSc and OGS.


Gtk.Widget.GdkWindow' is obsolete: `Replaced by Window property.' in Gtk3
And on line 229 and 239

var currGdkState = Window.GdkWindow.State;

The default value of Windows.GdkWindow is null and fail on Gtk2 and Gtk3


It changes to the vanilla biome so yes, it should. Please report back.


@mjwitte Thanks for letting me know that it is not my problem. Since CI machine results show green, I am going to merge it in develop.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20696/testReport/) for this commit**


well it's only for that example


Sorry didn't notice the English text was above.
Maybe it's just me but I find it a bit confusing to have multiple languages within the same file. What's next, adding French, German, Chinese... ? ;-)


should this be `synchronized (replicatorsInProgress)`?
If not then what is the point of synchronizing on `replicator` as I don't see any other blocks that synchronize with it?


We provide a sample-configuration folder with needed files to run James. You can start by copying it and modify these files according to your needs


Maybe WindowState property need to be implemented in separate  WindowFrameBackendGtk2.cs and WindowFrameBackendGtk3.cs files


Should be "QEP"


I'd probably downgrade this to warning... we usually log things as errors, when we actually fail due to them. In this case the function just proceeds, so this should be a warning


Thanks for the catch @peterjc, was wrapping things up very quickly at the end of the day and forgot to thank you for the catch in the commit message.


`"%" PRIu32`


Ah. Got your point.
That was only in this context:
```c
            if (c && c->peer_host && c->peer_port) {
                assert(i == 0);
                strncpy(msst_actual->hostname, c->peer_host, MCS_IDENT_SIZE);
                msst_actual->port = c->peer_port;
                msst_actual->fd = -1;
                msst_actual->ident_a[0] = msst_actual->ident_b[0] = 0;
            }
```
and here msst_actual->ident_a has MCS_IDENT_SIZE, so extra 100 bytes  that strncpy zeros out actually land over port/fd/ident_a, which we initialize anyway.

So really no harm done.


Right. As far as I know if you are using the server option BrowserSync will always open to localhost:port with no ability to deviate from localhost.

This is a problem (albeit small) if the application you are working on utilizes url information and requires the user to manually change the url.


Oops,  we should run "pstoreoops-harvest" test on rhel-7 too.


Do you still use that feature ?


run java -Dconfiguration.directory=<your configuration directory> -jar target/james-server-cassandra-guice-<version>.jar


I think the filename for instance should be shown on ENOENT, which is not the case anymore:
```bash
$ jt ruby -e 'File.open "notexist"'
.../ruby/core/rubinius/common/exception.rb:389:in `errno_error': No such file or directory (Errno::ENOENT)
BEFORE:
$ jt ruby -e 'File.open "notexist"'
.../ruby/core/rubinius/common/exception.rb:389:in `errno_error': No such file or directory -  notexist (Errno::ENOENT)
```


@CrossLuna 這兩道題的題解和程式碼都有點問題，剛才修正了，繁體部份可能也需要更新


Ahh, I guess I should have looked at more context. I guess that explains the `case 1`, too. I realize you're not the original author, but I think this spec is a bit confusing. Having a comment as to what's really being tested would be helpful.


what do we need to compile to run this ? does it run right from the command line (without docker)


done - the error is in the Zanata project - David sends a mail to the translators


"recursive-ignore" does not exist in distutils. This should be "prune", I think.


Is this left over from debugging?


Okay. I can roll some of these back. I'd still like to go with the general approach. The feedback loop of adding one sys error at a time is getting a bit cumbersome otherwise.


what Rev now? z2695 ??? or official z2681?


The `+1` makes sure the last byte of the substring is not overwritten when terminating the cstring with the nullbyte. As you see in https://github.com/idris-lang/Idris-dev/commit/066e890a685f4f6c286cb863e2b9e86f852425b5#diff-8f7d4fd3a2bcdf31d0f89fcf1956bc94R600 there is an extra byte being allocated to create space for the nullbyte.


I think it doesn't make sense at all to have this ```check_realpath()``` call here in ```efivars_write()``` (```fopen()``` will just fail if ```path``` is invalid) but it's ok for its read counter part to leave as is. I would just drop the check here and  include a ```sol_util_strerror()``` to the SOL_WRN() in the fopen error check.


Window.GdkWindow is only null before the widget is shown. It's correct that it has been deprecated in Gtk3 but it should still work. Doesn't the Windows example (the "Show borderless window" button) work for you?


git init


Please, re-add "python-bindings" test to the test order. We forgot to add it to the test_order.rhel7 file.


Chris,

Just got this email.

Great idea!  Yes.  It would be better to not update the labels each time.
Did I miss something in the checkpoint?  If not, I could try to implement
it.

My first thought would be to simply fill the entry field with the current
values.   In the assignment, I made the current Rating the default for the
drop-down box.  This would quick, but dirty.

My second thought would be to display the current tags, neatly formatted as
they appear when being displayed (little blue boxes), with an "Edit" button
next to them.  It would be great if they could be edited "inline" without
leaving the current page.  Would this be a place to use AJAX -- a form
within a form?  (Honest question in that I do not know AJAX)

Rob

On Mon, Sep 14, 2015 at 11:55 AM, Christopher Beck <notifications@github.com
> wrote:

> Interesting. So you are updating the labels every time someone updates a
> topic. Can you see a time in which you wouldn't want to do that on a topic
> update? Just asking.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/robrieba/bloccit/commit/f330853af71d24a91e30482a761858e98b3943dd#commitcomment-13216688>
> .
>


The specdoc would ideally be enough :smiley:
But indeed it's not trivial and we need to redefine === otherwise it would just go to the `else` case.
A mock does not work so well as we need to make the method private and private singleton methods are a strange concept.


I'd prefer to have a whitespace between `+` and `1` here. Looks more like a binary operator than and keeps the code in-line with the rest.


created python calendars


So like, `int delay = Nan::To<int>(info[0]).FromJust();` ?


Using PHPSTORM integration to make immediate changes to this file. It's all making sense and is very easy now!


I added this and removed it again


TODO AM: make separate PR, make configurable (possibly via resource.cores_per_node)


I added this and removed it again also


you are already inside the execute loop, no need to reenter (this causes the stack overflow I think)


感謝回報，參考至 issue #5。


It's already Command. Doesn't make sense to cast here or I'm missing something :)


It won't fail if the path is not invalid - it will create a file on an invalid location, or read a file that is not supposed to be read. Don't know if we really should care about it, but if property is called `../../../../etc/passwd` it will end up writing to this file, and this looks a problem (not that it couldn't do the same when using filesystem storage, that's why I have mixed feelings about this).


`dfp = DockerfileParser(code_dir), cache_content=True)`
should be sufficient
https://github.com/DBuildService/dockerfile-parse/blob/master/dockerfile_parse/parser.py#L59


```FLOW_NODE_TYPE_PERSISTENCE``` must depend on ```USE_FILESYSTEM``` and/or ```USE_EFIVARS``` - not sure which one - I didn't see the details on your code shift.


And here we need to cast to a proper Command.


Calling execute is only needed when you signal an event from the external world. Then you need to start the interpreter loop somehow, but from inside the loop (i.e. event callbacks) it is disallowed (maybe I add an extra flag and check for that).


So just remove that line.


same here


102966118-HeatRecoveryBypass-4568 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1866 of 1869 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


since this kicks off the loop, this line should stay


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20697/testReport/) for this commit**


I would like to see a sample in ```src/samples/flow/```  using these changes.


oops! nevermind, I see you are just using the skillcrush styles


a sample/test for this also applies.


maybe the same :)


I don't fancy option 2 either. Otherwise, I would indeed like being able to do something like ```importedComponent->setSource()```, this using either of the three signatures mentioned in David's latest comment.


@ingalls Is this correct? Was the decision made to change from adding "city_of_" to adding "_county" when appropriate?  As most of the sources are county sources that seems strange to me.


It kind of depends on both, but depending on nothing. It will use (via `#ifdef`) what is available.


Hello,

the rgb_pwm_led_test2 is missing in the git. Where can we find it?

Thanks in advance.


close #11


Hello,

the buttonTest is missing in the git. Where can we find it?

Thanks in advance.


Dear Pham Duy,

1) Duplication of clauses is allowed. Then indeed there is no relation between n and m. However, you can still give bounds on the the approximation ratio in terms of n. For example, the algorithm trivially never sets more then n variable to TRUE. Moreover, OPT is of course at least 1. Hence, the algorithm is a c-approximation for c=n. But perhaps it is a c-approximation for some smaller c. The question now is: can you prove a tight bound on the approximation ratio c? (You would do this by first showing that ALG/OPT \leq c for all inputs, and then giving an example input for which ALG/OPT = c.)

There is no need to convert the set of clauses to a hypergraph. (Hint for part (ii): use an approach that is similar to Algorithm 2 in the course notes.)

2) For A.II-3(iii) you should give an example where the integrality gap (the ratio between the optimal value of the relaxed LP and the optimal value of the 0/1-LP) is as large as possible. Hint: in the last lecture I gave an example showing that the integrality gap for the LP for vertex cover is 2-2/|V|. This example was a complete graph: the optimal value for the relaxed LP was at most |V|/2 (put x_i=1/2 for every vertex), while the optimal value for the 0/1-LP is |V|-1. Hence the integrality gap was (at least) 2-2/|V|. Try to come up with a similar example for the LP for this exercise, and compute the resulting integrality gap.

With kind regards

Mark de Berg


wrong move


Ok, I'm not sure it this should be a "WON'T BE INTEGRATED..." patch, I think it should be converted to something usable by the test suite and stick to it so we can always make sure this thing is not broken.


it is published, now that bower has cleaned its pipes))


The ``substr`` method is defined only in the optional Appendix B of the ECMAScript standard ("When the ECMAScript host is a web browser the following additional properties of the standard built-in objects are defined."). It would be better to use ``substring``; this would also avoid the need to use ``Math.max`` ("If either argument is NaN or negative, it is replaced with zero; if either argument is larger than the length of the String, it is replaced with the length of the String.") ``Math.max`` was unnecessary in any case for the length argument.


102966118-HeatRecoveryBypass-4568 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


<img width="1116" alt="screen shot 2015-09-15 at 15 03 59" src="https://cloud.githubusercontent.com/assets/11146524/9877132/49e58c82-5bbb-11e5-9b78-b48e1ee11c56.png">


Окей, але пострибав у Вас код.

Повинно бути відформатовано так:
```
public class FirstApp {
    public static void main(String[] args) {
        System.out.println(1+2+3+4+5);
    }
}
```


Yes it should! Fixed in 56c2d35.


It has to be before Cassandra, else you will get an exception in Eclipse when running tests.


having read your commit msg, I think ```val_only_storage``` would be a better naming.


really ? wow, that's broken !


Hello,

it this import important for other architectures? By default, it doesn't exists on my raspbian image.
Remove this import ant the associated line 15 (bus = smbus.SMBus(1)) makes the programming running as expected.

Note: the same problem is present in Clock27.py. Removing the import ant the bus assignation correct the problem too.

Have a nice day.


Definitely, I'm not sure if this work will be done on this very PR or it will be a matter for a new one =D


A test with a nonempty input string and negative length would probably also be good.


"as an argument", since it only accepts one, not several ? (Or simply remove "as arguments")?


Fixing #81


You can put this outside $(document).ready, doesn't need to be nested.


Same here (arguments)


You don't need to declare 2 $(document).ready.. blocks, you con put all your code into one block.


There are also some basic Infernal component updates as well.  Changed Infernal to use HMMER3 instead of HMMER2, and (TODO) support the multi-seq pipeline option.


@tbonfort I might suggest changing lines 2618-2620 to:

    if(map->outputformat && MS_DRIVER_MVT(map->outputformat) && map->scaledenom == -1) {
      msCalculateScale(bbox,map->units,map->width,map->height, map->resolution, &map->scaledenom);
    }

So you'd only compute a scale if it wasn't explicitly set through some other mechanism.


Going to commit - need to make some changes - framework4 is already installed by the Metasploit module and theres no direct framework4 package. Looks good and appreciate it!


No worries here about copyright but I would like to appear as an author in the git history (log/blame/etc). It's one of the currencies of open source :grin:


Well... these ones:
![image](https://cloud.githubusercontent.com/assets/9112818/9877223/c91486e8-5bbb-11e5-99ad-c8ca651b6d73.png)

That's what happens when I bind Ctrl to a key. Which one would be the best way to document it?


try


I think this will still be a memory leak when in high resolution mode. You'll need a separate if (isPortrait) delete frameImageFile;


It was intentional.  I believe i made that change just to prevent myself from accidentally checking in netbeans project files.  I don't use git often so there maybe better ways of doing that.


Da geht es doch eh nicht, oder? Verbatimtext als Argument.


if this project is to be continued (as part of releases, etc) then it should be added to the parent POM as other modules.
If it is has been deprecated, because it seems it hasn´t been updated for long time, then probably we should note this (or even remove it).


如果 nameLen 不大于 128 时，但整个 rtmp 包长度大于 128 时会如何？


On Mon, 2015-09-14 at 12:20 -0700, Ian Denhardt wrote:
> @doctormo, can you explain to me what the len(text) > 2 is for?
>
It says if the query is less than or 2 it won't search.

Martin,


all is well


请将 Tab 转换成 Space，保持代码一致性。


are you sure you need to do the when case stuff here? Doesn't a count of a filter with extractedsources just work?


[/home/travis/build/mapnik/python-mapnik/mason_packages/linux-x86_64/mapnik/3.0.0 not found, please install first](https://travis-ci.org/mapnik/python-mapnik/jobs/80400301#L2977)


note that you can also do `self.extractedsources.filter(extract_type=0)` since we also created a backreference between the tables.


Now I think about it, I am pretty sure that "quick wins" is not hyphenated, and it should probably be "There are some quick wins" rather than "There's".  To be honest, I think semi-colons are correct in that paragraph, anyway, because it is a list of things rather than a clause separating a single idea.


Lovely - nice and simple to use :)


`indexof` -> `indexOf`


And https://github.com/babel/babel-eslint/issues/124


Could this be the reason I'm seeing duplicate content (posts) when running the stylex-barebones example locally?
https://github.com/darrenmothersele/stylex-barebones/issues/2


I have following in the `pcap-stdinc.h`
```
#if defined(_MSC_VER)
#  if _MSC_VER >= 1600
#    define strdup    _strdup
#    define isatty    _isatty
#    define fileno    _fileno
#  endif
#  if _MSC_VER < 1600
#    define snprintf  _snprintf
#    define vsnprintf _vsnprintf
#  endif
#endif
```

`alloca` can be added also


You should change the api.md document in other places where "id" is supposed to be "ID". This can be done in a subsequent ticket if needed.


The base URL should be `/` which is the root of the server's domain address, as we discussed yesterday.


This paragraph looks like it is duplicated. Is this right?


But now the tests are not good anymore! To do: fix these tests.


This is almost perfect! The only issue that could arise is while you are looping to get to the required property. In case one of them is `undefined`, and you try to loop again, you will get a `TypeError: value1 is undefined`. Try to fix the `for` loop so that, in case one of the two values is `undefined`, it keeps it as undefined rather than try to dig deeper into it.


Doch das geht so: `\lstinline+\\documentclass+`.
Siehe Folie am Anfang.


If so, they could have manipulated mapper/prettyMapper directly. There is nothing to prevent that.


@XWB the alpha2 changelog is also quite incomplete, and the date was missing. The list of commits should be checked before releasing to be sure they are all in the changelog


Is `_name_()` a typo? Shall I send a PR?


please see fixup


Ah, sehr schön. Erledigt in 7c21ff1c30e11d5814f2b4d7da008abf5b714d1c


Agreed, I'll send first part now and follow up with details in a separate email.


I don't know much of that API. Do you know why was that previous code there? Btw. can that behaviour be tested somehow? I have added a small test suite and would be nice if you could extend it to test that.


Yeah, there was a lot of uncommitted changes made long time ago. Thx for your tip!


Hi,

This patch does 3 separate things and according to the workflow guide[1] you need to split it into 3 separate patches preferable in the following order

- modify profiles
- update libgaminggear
- update to 3.6.1

would you be able to do that?

after that, I will merge this PR. Thanks

[1]: https://wiki.gentoo.org/wiki/Gentoo_git_workflow


`miki<#{ENV['MAIL_TO']}>` だと mikityの名前から来る感じになっているので、 ENV['MAIL_TO'] だけにしておくと良いですよ。もしくは`お問い合わせフォーム <#{ENV['MAIL_TO']}>` とかにしてもいいかもしれません。


I have left the version intentionally blank since some of the items there are intended for 1.4.5. Should we start splitting commits to patched vs devel (in R speak)?


请教下，这个是说，正在迁移中，禁止再次迁移？ 保证迁移的唯一性？


Typos fixes : ca21b6e44f71cfb4a26dbf322cb544a3555c078d


потолок


Fixed typos : ca21b6e44f71cfb4a26dbf322cb544a3555c078d


еще
![1442323584213175646667](https://cloud.githubusercontent.com/assets/10360419/9877604/4e52b652-5bd7-11e5-9241-cf6878ecd5d3.jpg)


Good idea. You could also move all external resources to your webspace and include them from there. To manage the dependencies you can use http://bower.io/ to which I recently [switched to](https://github.com/ypid/opening_hours.js/commit/777299de445f5cc754e108ce543ea077b8e1937d) and which works quite nicely.


@geobrando Yeah I think this decision was made over on the slack channel? Hopefully I'm remembering correctly. @migurski of @iandees might remember the context. I have no preference either way.


Yup, thanks.


@vitorgalvao awesome, thanks!


Чем оно всем так понравилось? Напоминает ДОС :/


They're 3 patches, I.e. 3 commits. Is it not what is said in workflow?
15 сент. 2015 г. 14:25 пользователь "Markos Chandras" <
notifications@github.com> написал:

> Hi,
>
> This patch does 3 separate things and according to the workflow guide1
> <https://wiki.gentoo.org/wiki/Gentoo_git_workflow> you need to split it
> into 3 separate patches preferable in the following order
>
>    - modify profiles
>    - update libgaminggear
>    - update to 3.6.1
>
> would you be able to do that?
>
> after that, I will merge this PR. Thanks
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dpisklov/gentoo/commit/f38a69280b6b54c0e83c61081fcca0228c70a35f#commitcomment-13237017>
> .
>


OK


Tests with nonzero start and negative length would probably also be good.


Nice, but I would propose to use this one: `[\w\u0410-\u042F\u0401\u0430-\u044F\u0451]` which matches any Russian char https://regex101.com/r/fF4xH3/2


I think 893d10b4b65ab09c29551faf9e6c6f8e4c483945 strikes up the balance we're looking for. If you find another case that's not quite right, please let me know. That commit more closely matches what Rubinius does.


Seçimi 3-D resme doldur. \n\nBaşka bir renk için oka tıklayın.


:cake:


Ah you mean separate lubgaminggear from roccat-tools.. But that doesn't
make much sense, as they don't exist separately. We always updated then in
one shot...
15 сент. 2015 г. 14:28 пользователь "Dmitry Pisklov" <dpisklov@gmail.com>
написал:

> They're 3 patches, I.e. 3 commits. Is it not what is said in workflow?
> 15 сент. 2015 г. 14:25 пользователь "Markos Chandras" <
> notifications@github.com> написал:
>
>> Hi,
>>
>> This patch does 3 separate things and according to the workflow guide1
>> <https://wiki.gentoo.org/wiki/Gentoo_git_workflow> you need to split it
>> into 3 separate patches preferable in the following order
>>
>>    - modify profiles
>>    - update libgaminggear
>>    - update to 3.6.1
>>
>> would you be able to do that?
>>
>> after that, I will merge this PR. Thanks
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/dpisklov/gentoo/commit/f38a69280b6b54c0e83c61081fcca0228c70a35f#commitcomment-13237017>
>> .
>>
>


Ja, det er mega nice. MIG MIG MIG :)


пробел лишний


сделай красивые отступы :с


the license must not be excluded. It would violate the license if you don't ship it


Im not sure on how to do that in idris, but what about adding a test that shows the substring does skip about invalid characters, like the C code does?

Likely such a string can be made from packing Word8 values into a string.


document.getElementsByTagName('body')[0]; --> document.body


What's the difference between `dataset` and `dataLoader`?
`dataLoader` is a *global variable*.
`dataset` is `return`-ed by the script, but never used, since in `donkey.lua` you simply `paths.dofile('dataset.lua').


пустая строка должна быть самой последней всегда


Does `/dev/stdin` work on all systems?


The interest of using it as an external resource is that if it was loaded from another site using the same URL, it will still be in browser cache, so not downloaded again.


Your issue is when you're passing parameters back to the super-class, since you're not using name-values:

This is the correct order:

```
group=None, server_type=None, instance_type=None,
                 environment=None, ami=None, region=None, role=None,
                 keypair=None, availability_zone=None, security_groups=None,
                 block_devices=None, chef_path=None, subnet_id=None,
                 dns_zones=None, ingress_groups_to_add=None,
                 ports_to_authorize=None, classic_link=False,
                 add_route53_dns=True
```


Why do you use `paths.dofile()` instead or `dofile()` or `require()`?
Any specific reason?


My mistake. Thanks


get


@mvarshavsky Please review our changes. Thank you.
Please let us know if you have any questions.


конкатенация под равно должна быть, если с новой строки


looks good :)


unnecessary space


не хватает параметра


Update to `dnd-core@1.2.0` must have been a breaking/major change. Also see https://github.com/gaearon/dnd-core/pull/21#issuecomment-140296164


Thanks for the screenshot. I suppose QKeySequence isn't really intended to handle non-combined ctrl keypresses.

Suggested alternative:
`/**
  * Given a key code, return the key name.
  * @note This function is conceptually similar to QKeySequence(key_code).toString()`, which however returns gibberish strings for modifier keys (e.g. Ctrl). Hence this function provides special cases for these keys."


I think that's *exactly* the same that I wrote (but without `/i` mode). Without escaping that means `А-ЯЁа-яё`. Does this variant have any pros?