develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1291 of 1291 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I have done the changes? Hopefully it is alright? I may have missed some changes? I am very much out of my depth here, so any help would be much appreciated.


This is just my 2nd version of my rough draft- I still need to add the other items requested in the assign. ex:
how this relates to my IY experience. more to follow


I felt that we don't even need a separate method here as this is the only case where we need to provide default Copiers. So Th though that moving that bit of code here would make it much more explicit.


User is not agent user - it should be taken from fabric.api.env.user. Otherwise if agent user is 'agent' and manager user is 'manager' it will try to put the file as 'manager' in /home/agent/ directory what will fail because of lack of permissions.


can you explain why? preferably in the commit message itself


Различия в использовании i18n с bem-bl и bem-core


I should probably fix my aapt as well then

djalik@djalik-VirtualBox:~/opengapps$ which zipalign
/home/djalik/Android/Sdk/build-tools/23.0.0/zipalign
djalik@djalik-VirtualBox:~/opengapps$ which aapt
/usr/bin/aapt


во время исполнения ЧЕГО? уточнить контекст юзкейса, о котором идет речь


This seems to be kindof complex. Why is a regex needed here, and expensive escaping of special characters? Just convert both strings (search and node) to lowercase and remove the diacritics and perform an exact compare, would that work too? Should be faster and safer.


«в реальном времени» — неточно, речь идет о чем-то другом, наверное, должен быть runtime, а не realtime


I like this, haven't tested functionally, if it works we should go for it.


@kashike might have some ideas, maybe the staging server is doing some magic somewhere?


djalik@djalik-VirtualBox:~/opengapps$ aapt v
Android Asset Packaging Tool, v0.2
djalik@djalik-VirtualBox:~/opengapps$ ../Android/Sdk/build-tools/23.0.0/aapt v
Android Asset Packaging Tool, v0.2-2166767


In this [zip-file](http://www.basement.ethz.ch/services/test_cases/v2.5/H_BP_4.zip) is an example; the spec could be found [here](http://www.xmswiki.com/wiki/SMS:2D_Mesh_Files_*.2dm).


We don't do anything with the resulting connection, we don't wait for connection to be added to perform any action, so at this point we probably don't. I'll remove it.


это лицензия на текст или на код? если второе, то она не на месте (и год прошлый)


again, please say in commit message the "why" the change


dott. Stacchiotti non le sfugge nulla! avevo dimenticato di copiarlo.
pero' forse le era scappato questo ;-)
https://github.com/perrozzi/cmg-cmssw/commit/2e3dc31c93383695de822ea6d7b02419168ff6dd


Thanks for the reply we fixed the issue.


I believe you don't need to parse dates nor read the source code to use `long getDateHeader(String name)` and `setDateHeader(String name, long time)`. The main improvement here: writing valid HTTP date headers.
You can take a look at the [original issue](https://jira.spring.io/browse/SPR-11912) for more background on this.

Is there something missing here?


@tanmaykm, thanks for explaining. The refactor you propose makes a lot of sense.


@nuwang: Thanks for the bug report!
What do you mean by "running spnEff"? Installing or executing the tool? Which Tool Shed repository is this exactly?

Thanks!


why? `top1m` scan is more likely to be run on platform which do have `timeout`, not `gtimeout`, and those are the ones that are most speed sensitive...


Then there has always been an off-by-one error in regidx_parse_tab(): https://github.com/samtools/htslib/commit/5b98adcd6c52cdabcf6f71877ca94d370edf5eb6#diff-4c586c60b9d10f6ed80a870fecf70fe7R291


просто для порядка: Пакет enb-bem-i18n


Thanks, for makefile. I've started on creating debian/* and rpmsepc for st2debug and st2exporter, so I will need these makefiles. So if something missing in this makefiles I will push it here.


Quei plot ti servono anche per madNoCorr.
Devi ricordarti di impostare `correctToMadgraph` a 1 anche in quel caso (magari scrivilo sul `launch_analysis` così non te lo scordi).


слово «сервисы» здесь — привет из Яндекса? лучше заменить на нейтральное «проектов»


Ah! Yes, it's transparent now :)


Done.


это же повтор — уже было  в README? может быть, оттуда тогда можно убрать, чтобы разгрузить README от лишних технических подробностей?


ok so `long getDateHeader(String name)` is an alternative, but it is a breaking change as `String getHeader(String name)` now returns the formatted string, I assume this has been added to some upgrade notes somewhere?


Personally I still use the Ubuntu built-in aapt, since it suffices for now. But there are indeed some small changes between the versions, that @NicholasBuse for example did already experience when processing aapt's output within the scripts.


@bors r+


Works on master, but not on release-15.09 branch. Any idea why?


Если она служебная, значит в норме пользователь не должен ее напрямую вызывать? Если да — тогда зачем она первая в списке, убери ее в конец.


Thanks @aericson, all looks fixed, good to merge


копипаст из README, см. там замечание по формулировке. А вообще копипаста лучше избегать, наверное, здесь или там можно убрать.


This commit wasnt needed if you guys know what your doing instead of copy/paste everything.
You guys copy/paste so many commits that you even don't know what you even pull and also don't even know your own source. The original buttons made by hyde would have worked without any issues on bliss source as the "sync status bar signal cluster code with AOSP" commit was already present in the bliss source . So instead of stealing this commit and the main qsbar commit out of our (Cyanide and Fusion) private repo's thru Jacob McSwain. And just pulled it from hyde then you only had to modify a few little things to get it to work on cm based roms. (Only 5 minutes work) But you need to know what your doing!! You guys proved multiple times that you all don't know what your doing. So to get a nice feature that you guys want and cant port/make yourselves then steal or copy/paste it from all REAL devs that do the actual work and spend many hours of work on such features, ports or fixes.

Also the comment in the main qsbar commit is total bullshit. like i said just had to pull it from hyde, then
you could have written own comment to it, if you got it to work by yourselves on cm based roms.

Happy copy/pasting in the future and be happy with this.


**_ALSO_** I have to re-submit my outline.
It was good to do these again for practice but, I have to say it almost acquired a new level of difficulty b/c of all the replacing of existing files with **_Mulligan_** files.
I will now submit another PR for these small changes...hope this is _correct_
Slowly the fog is lifting...my git hub confusion at this point is for the most part just knowing which file to work from, depending on the verbiage of the HW questions. _**ps**_ I'm using .md now.!!   see you soon!!


Also, since `buffer_time` is set independent of `period_size`, there could be the case, where only available period size is 80 ms. If buffer size will be set to 80 ms also, ALSA will ask for new data when buffer is empty or almost empty, which will break sound beyond repair.

That's what I had in mind when I wrote previous version of the code.


Unicode::Encoding
ってのを追加したら治るかも。


The `requirements_prod.txt` does not look correct: it does not have version numbers attached to it (see django) Did you use `pip-compile`?


別途 cpanm install Catalyst::Plugin::Unicode::Encoding する必要もあるかも。


s/значение языка/двухбуквенный код языка (по ISO-что-то там)/


s/специальная директива/директива/


He visto el código,  y en vez de

.cajaicono:nth-child(3){...} debería ser .caja1:nth-child(3) .cajaicono{...}, ya que quieres que cada caja1 tenga su fondo.

Recomendación: Puedes eliminar cajaicono del código y meterlo en caja1 el fondo, y al texto le das el padding de la altura de la imagen, así te quitas una estructura html y se reduce mas.


94006714-MultipleTowers (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (760 of 760 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.41%25-green.svg)


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1815 of 1815 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


But maybe that doesn't matter, and that values and the way they're set are OK.


mucho english silvous plais senore


Ok, I think my main point was: make what is important stand out more :stuck_out_tongue_winking_eye: I might have been a little confused as to what is actually important *coughs* :wink:

But asking user feedback and making it pretty later sounds like a great idea as well :+1:


It was fixed sometime later then, cherry-pick of hts_parse_decimal change revealed the difference
https://github.com/pd3/htslib/blob/de6c60a15e4fbdb17ed2d2451f5b9a7329704c1a/regidx.c#L345


`metadata["phase"]` would return `nil` if there wasn't a value, so I don't think we gain anything from using `#fetch`


In that case, all `get_period_size` family calls are unnecessary.


Description has a few spelling errors. It should be:
`Whether built-in GTK+ scrolled windows will use overlay scrolling. Overlay scrolling hides and reduces the size of the scrollbar until it gets focus.`


Maybe some go rework only present in master?


@sapieneptus

Something went wrong here.  This is supposed to be a git submodule, not a file belonging to this repo.

We need to correct this or I need to be corrected.


Thanks, you are right


In that case I made the right decision: this is new code, so we'll just run it through `indent`.


It also worth to squash all commits into one.


name of the class should be with upper case!


@yavor87 can you explain what happens if for say the HTTP request to Ably fails for time?


Why is this being removed?


name of the class fields should starts with lower case =)


yes


何か怪しげな


test comment


таргет — жаргон. имя цели или значение указанное в параметре target


Checkmarx scan results 03 Sep 2015 13:22 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
1
1
2
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

066f603e097afc8f97b178984ff8475794e758a7	@cxehud


Good question. I have taken into account this for the connection management.


I'll add this [here](https://docs.spring.io/spring-framework/docs/4.2.x/spring-framework-reference/htmlsingle/#_testing_improvements_3).


A stream source does not hold onto past values.  See [here](https://github.com/Hopac/Hopac/issues/47#issuecomment-71085016) for a note on the connection between streams, stream sources and CML multicast.  So, basically, unlike streams, stream sources are "safe" to hold onto.

Note that you can also have streams of streams.  In particular, consider [Stream.tails](http://hopac.github.io/Hopac/Hopac.html#def:val Hopac.Stream.tails) and [Stream.tailsMapFun](http://hopac.github.io/Hopac/Hopac.html#def:val Hopac.Stream.tails).  These allow you to "tap" into a stream at a later point in time without exposing a mutable stream source.  For example,

```fsharp
Stream.combineLatest someDrivingStream (Stream.tails someAuxStream)
|> Stream.???
```

combines `someDrivingStream` with tails of `someAuxStream`.  The `???` part is likely to create new streams that combine an element from `someDrivingStream` and the current tail of `someAuxStream`.


Yep we should. And add some of the common use cases for why people used to need to use it, and alternatives for those


1. «они» тут не на месте — как будто нужно выбрать суффиксы из уже имеющихся директорий.
2. не совсем ясно, что в данном случае входит в понятие «дальнейшей сборки», желательно конкретизировать


commit with 3 types of chart creation and Gem graph_form_sql


Точно не нужно никакой вводной к примеру?


then i don't think this is necessary.
or do you see a use case where oplk_init and oplk_serviceInit will be called from same application?


Oh, I didn't notice you *did* test the new TeX.


Which encoders do work?


图片怎么看不了？？


It this related to there apparently being two ways to specify positions in .bed files?
See the comment in samtool's test.pl here:
https://github.com/samtools/samtools/blob/develop/test/test.pl#L749


yes.


I see the IE table fix also got squashed in here, to fix issue https://github.com/BrewPi/brewpi-www/issues/51

Great, will merge it into develop


css также подключать embedded-ресурсом, как и js?
Вообще, он тут на правах костыля, вопрос окончательной вёрстки ещё не решён.


No, because then the headers on the repo would need issuing as well.


No we do have special top-level PGDs for both fixmaps (atomic mappings - fixmap_page_table) and pkmaps (permanent mappings - pkmap_page_table).

And as we discussed at least pkmap_page_table is used in common mm/highmem.c.


:+1: looks much cleaner


А есть штатный способ замены assemblyinfo?
Здесь пришлось удалить его из проекта и drag'n'drop-нуть его из сосднего.


I merged the different types into one sum type in 8a627e67bc8cc987042c70982b4e269187a15b43, now the resolve function can be called once and filtered on later. Let's see if this fixes it.


Destroy cluster
____________

  $ ./bdutil -P tajo_cluster -e tajo delete


Hey @jbalsas,

I can't test this, so could you check if changing the regex to something like this would work:
```
return content.replace(/\r?\n|\\r/g, '');
```

Thanks,


Why have you re-added the ```chunk.h``` to ```os/src/server/ram_fs/```, duplicating the code? I somehow suspect that this is an intermediate step. In the end, you'd like to completely remove the ram_fs, right?


This may fix #905.


8d801cfd4e784ae742f9df11a5ae275d5fbc037f

thx


I would move this to user, also maybe there is something like `has_roles?`?


Using Open-gl


fitler added


add proper methods to commit like:
```ruby
commit.passed?
commit.rejected?


This looks like a OSX-specific addition, why not put it inside the "Darwin" block below?

`readlink` is part of `coreutils` since before RHEL-5 (which is too old for us to support)


What's this protecting us from?


do you use locales? it would be great if all text were in locales


> Why don't you namespace your functions then? malabarba/le-func

Just because `org/insert-checkbox` is shorter than `malabarba/org-insert-checkbox`.

> Also, with the release of your nameless package will the names package be actually of no use? Are there still some benefits one gains from the names packages that the nameless pacakge doesn't provide? (practically they are the same right?)

For the most important functionality (hiding symbol prefixes) they are pretty equivalent.
Names is a bit more versatile in that it allows absolutely any prefix, while Nameless requires that the prefix ends in a `-` (so your current usage wouldn't work).

Names also has some secondary functionality like generating `defgroup` and a couple other tricks.


In case of the firmware update tool and the demo applications you are right, then it is not needed. But by mistake in some customer's application this could help.
Do you think it would be enough just document that only one of these shall be called?


But according to the code below, `autoyast2` only will be installed if `files` section is present. So, if `files` is missing, `autoyast2-installation` never will be added. Is that correct? Maybe we must add always `autoyast2` package when the 2nd stage is needed. Thoughs?


Fixed. 👍


@hupili Certainly.


you could also add another factories for commit like pending_commit etc.


Not sure if I'm commenting in the right place but I still have an issue with inline radio:
http://www.bootply.com/g5jI8kUDD2
Maybe an issue with right-margin?


while this makes it work in bash3, we have different places which require the regex syntax from bash4, so I don't see what we're gaining...


Change commit message to include constant name


Out of interest, why is this RawCapability instead of just Capability?


@koistya fair enough... just really weird looking seeing a const declaration inside of a method.


r+


0) The possibility of apt-get fails is close to zero. And even if it will ever happen we will see related info in the build log. (Just for a note: we use similar trick in EiskaltDC++ project during more than a year without any problems.)

1) The main reason of this change: packages from Ubuntu 14.04 are signed by new gnupg keys which are not available in ubuntu*keyring* packages from Ubuntu 12.04. I have tried to update ubuntu-keyring package but it caused another issue:
https://github.com/qxmpp-project/qxmpp/commit/7dca142
https://travis-ci.org/qxmpp-project/qxmpp/builds/78126611

2) I have not tried yet to import all necessary new Ubuntu gnupg keys by calling apt-key command directly because of point 0) and the feeling that such "hack" will look even more ugly than current one. In current state this shell script is short and simple.


Would it be safer to separate changes for different issues?


I believe getChannelData(self) is covered by the kvDevice class.
```python
import kvDevice
dev = kvDevice.kvDevice(ch=0)
print dev
```


`grep` is slower and much more resource intensive than the compare, so why use grep?


@yorikvanhavre: the code looks OK and seems to work as expected.

However, I doubt that this function can be used for the autosave as it is because for bigger projects the saving can already take 20-30s and this would be annoying to have to wait that long every few minutes.


> Don't all patches in the rebase-apply directory have the from line?

Not when applying patches that were created using `git diff ... > the.patch` or `diff` even. I don't remember exactly but I think `am` can apply such patches.


TokenParams does not have a `KeyName` field. See https://github.com/ably/ably-java/blob/8a11affa1272e1dd168b7dbe33595a9cd464ebf2/src/io/ably/rest/Auth.java#L204-L245 and TK1, TK2* of https://github.com/ably/ably-java/blob/8a11affa1272e1dd168b7dbe33595a9cd464ebf2/src/io/ably/rest/Auth.java#L204-L245


Perhaps our notions of PGD / PTE is not clear. PGD in my book refers to Page Directory (all of it not a specific entry) and same gors for PTE (it refers to full table). And per current code pkmap_page_table (as ane suggests) is a 2nd level table not PGD. However the way we are lookign them up in tlbex.S is as if they are first level. Is that understanding correct ?


Hey @ipeychev

Yes, that will do it :+1:

Could you make the change and release a new version? I'll update the build scripts to use it afterwards.

Thanks!


With existing implementation after the firmware update, the application should exit the stack and close connection to driver to avoid system crash during the device reset.

So, we should document this also.


I use only the SDK, and built with no issues yesterday after the zipalign issue was fixed.


...or we could just run `openssl s_client` with `-help` option, collect the return code and see if it's not 127 or if it runs, collecting the data needed to autodetect features?

also, the error message should be printed to stderr


Can you move this stub to a subdir with a proper .c + .h + README with the license details?


r+
good idea!


@nsoranzo  Sorry, a poor description on my part! I sent an email to the mailing which is only marginally better. Basically, the problem is that package_snpeff_4_0 (rev: 792d8f4485fb , owner: iuc) doesn't install properly. Since this is a dependency for both snpEff and the snpeff_data_manager, neither of these work correctly as a result. We noticed that the problem only occurred after upgrading to Galaxy 15.07, and tracked down the issue to this specific commit. The error message displayed during installation is the one I mentioned above. Let me know if you need any more info.


Updated to make a single call to etcd.

On Wed, Sep 2, 2015 at 9:44 PM, Clayton Coleman <notifications@github.com>
wrote:

> Still not one atomic call... When I say atomic, I mean we dispatch exactly
> one call to etcd to write the object. Which means you need a method on the
> REST that allows you to save both spec and status at the same time. That
> method would only be used from this code path, but it allows you to bypass
> the normal protections on spec and status (when called within the same
> codebase).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kargakis/origin/commit/b81fed79921e429b5428f94bab3510bc3ff355e0#commitcomment-13031997>
> .
>


r+


Why unset it here when you are going to set it below?  If `a.RequestToken` now failed, the existing token would be gone even though a new token was not issued.


### Missing semicolon.

```
return "Hello, World!"
                      ^
```


### Expected an identifier and instead saw '=='.

```
if (bla. == null) return;
         ^
```


### Unreachable 'return' after 'return'.

```
return "Hello, World!"
^
```


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1812 of 1813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Can we put an error message in here saying "Basic auth is not supported of insecure non-TLS connections"


### Use '===' to compare with 'null'.

```
if (bla == null) return;
        ^
```


Używanie tutaj `<br>` zamiast diva to napewno nie jest dobry pomysł ;) `<br>` powinny być używane tylko do przełamywania tekstu wewnątrz np. elementu `<p>` https://developer.mozilla.org/pl/docs/Web/HTML/Element/br


Are zh-Hans and zh-Hant the supported languages?  Or are they cmn-Hans and cmn-Hant still?  Similarly - is it actually just nl now, or is it still nl-NL?

In making a new app with all the languages supported in iTunes Connect, my output was:
```
[[06:55:29]: Successfully downloaded existing metadata for language da
[06:55:29]: Successfully downloaded existing metadata for language de-DE
[06:55:29]: Successfully downloaded existing metadata for language el
[06:55:29]: Successfully downloaded existing metadata for language en-AU
[06:55:29]: Successfully downloaded existing metadata for language en-CA
[06:55:29]: Successfully downloaded existing metadata for language en-GB
[06:55:29]: Successfully downloaded existing metadata for language en-US
[06:55:29]: Successfully downloaded existing metadata for language es-ES
[06:55:29]: Successfully downloaded existing metadata for language es-MX
[06:55:29]: Successfully downloaded existing metadata for language fi
[06:55:29]: Successfully downloaded existing metadata for language fr-CA
[06:55:29]: Successfully downloaded existing metadata for language fr-FR
[06:55:29]: Successfully downloaded existing metadata for language id
[06:55:29]: Successfully downloaded existing metadata for language it
[06:55:29]: Successfully downloaded existing metadata for language ja
[06:55:29]: Successfully downloaded existing metadata for language ko
[06:55:29]: Successfully downloaded existing metadata for language ms
[06:55:29]: Successfully downloaded existing metadata for language nl-NL
[06:55:29]: Successfully downloaded existing metadata for language no
[06:55:29]: Successfully downloaded existing metadata for language pt-BR
[06:55:29]: Successfully downloaded existing metadata for language pt-PT
[06:55:29]: Successfully downloaded existing metadata for language ru
[06:55:29]: Successfully downloaded existing metadata for language sv
[06:55:29]: Successfully downloaded existing metadata for language th
[06:55:29]: Successfully downloaded existing metadata for language tr
[06:55:29]: Successfully downloaded existing metadata for language vi
[06:55:29]: Successfully downloaded existing metadata for language cmn-Hans
[06:55:29]: Successfully downloaded existing metadata for language cmn-Hant
```


Test


this looks nice


Looks like [`isFinite(this)`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isFinite) would do the same thing


不是   只是用JAVA写的一个DOS程序  那个是java的配置文件  这个程序只是初步的  仅仅实现了小部分 还在修改中


Not sure if I'm commenting in the right place but I still have an issue with inline radio:
http://www.bootply.com/g5jI8kUDD2
Maybe an issue with right-margin?


Was this an oversight in commenting this out after the change?  Or is there an issue with the deliver of keywords?


Hey @iamtakashi
Oh, I missed chance to get the contributor list of WordPress core. Thanks for completing my incomplete PR.


Zrób tutaj `extractMethod` czyli z `$stations = $this->get('cocoders.trm24.parser')->getDockingStation()` można zrobić `$stations = $this->parseDockingStations()` albo coś podobnego


Эти методы, как правило, используются как конструкторы


This is good, however the returned type from a URL can a be TokenDetails, or simply a TokenRequest which in turn is used to get a token from Ably.  This is more common in fact as it means a developer can issue token requests from their servers without communicating with Ably, and then the client library is responsible for communicating with Ably using a signed (trusted) TokenRequest to get a valid token


Hi Garand,
I´d like to know if the effect can stop working when it reaches a certain resolution, for example 991px. Thank you and sorry for my english.


Would it be more readable to replace these three lines with below?
```ruby
 next unless information && information[language] && information[language][:keywords]
```


освобождаются


I changed the callback signature to account for errors. The same pattern exists in other parts of the library.


I was getting bored of not having PocketMine docs on jekins.pocketmine.net, so I made them myself, using Doxygen


@alexsdutton Should this be:
ensureAccessTokenLifetime: function(millis) {
...


101884090--NewVenting-Availability-Schedule (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1814 of 1814 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:clap: :clap: :clap:


No worries. The development isn't finished :)


Yes you are right, I'll add this to documentation.


I'm looking into this.

On Thu, 3 Sep 2015 11:33 Vladimír Čunát <notifications@github.com> wrote:

> Maybe some go rework only present in master?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/6e1bee84d36e4f32f920dda6321719c5576f6588#commitcomment-13043950>
> .
>


I don't think the two are mutually exclusive, just because a Token is defined, it does not impact upon whether a new Token can be issued if a valid Key exists.


It is done.


There is no off-by-one error in this code in samtools/htslib.  So all is well.

(pd3/htslib@ de6c60a15e4fbdb17ed2d2451f5b9a7329704c1a was never proposed for the samtools repo, and the breakage was introduced to your repo when you cherry-picked https://github.com/pd3/htslib/commit/3d3d7787e16307f1f38b024afa3bff64eb205454#diff-4c586c60b9d10f6ed80a870fecf70fe7L347 without accounting for this.)


Смотрите также


can you say when this can happen?

r+


Fixes #4


the error message needs to go to stderr


r+


When there is an error, the result is Null, and the error is passed on to the caller


Awesome! Thanks a lot! :blush:


When the request succeeds, the result is passed on and the error is null.


see: https://github.com/KrauseFx/deliver/commit/0017714754ad756257aed5bc62cd9b958d8f4f41#commitcomment-13044338

If you _don't_ make this change here, then the supported languages would be the "zh-" version, right?  (Although I'm assuming this was the only way to work around the issue listed in that radar...)


Is this really needed or you added it just in case? In real project modules will be usually disposed only when project is closed, so this actually won't fix memory leaks.


public JMenuBar getProfileMenu() {
+        return profileMenu;
+    }

-	   		+    public void setProfileMenu(JMenuBar profileMenu) {
-		+        this.profileMenu = profileMenu;
-		+    }


cool


Missing :return and :rtype.


101884090--NewVenting-Availability-Schedule (lgu1234) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yes. See also https://github.com/JabRef/jabref/pull/137#issue-104056056: The actual problem was, that the "toogleToolbar" command was defined on the basePanel (which only exists if at least one database is opened). So if no database was opened the command could not be resolved. To solve the issue I moved the hide/show functionality directly into the JabRefFrame.java (see l.316-324) where it is executable regardless whether a database is open or not.


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 61](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191832&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


Yes. I make this mistake a lot :/


Why not dispose on RuntimeException as well? Probably it would be better to catch Throwable and use handy method ExceptionUtil#rethrowUnchecked.


Closes #12745 (I messed up the commit message).


1. Yeah you should use `$this->container->get('session')->getFlashBag()->set('notice', ['Available bikes NOT refreshed! Please review docking station repository.']);` and probably extract that to separate private method.
2. That is not big problem - https://en.wikipedia.org/wiki/Rule_of_three_%28computer_programming%29


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 61](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191832&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:18


test


Missing :raises and info about what is done if location does not match with KNOWN_LOCATIONS


These globs are extremely simple, and I'm missing many pattern quirks that makes the correct filtering of parent directories extremely complex :sad:


All these finals on local variables aren't necessary here and just add noise.


Does `client.post` URL encode the name of the channel automatically?


I'll probably be making a new release this coming weekend.


That can be problem when first docking station will be added and second is invalid... and flash problem is related with that...


Right. Yeah I did a diff, the only difference is that you only have the windows config header instead of all of them, which makes sense.


Thanks guys.  I think the only logical progression for liblacewing would have been to keep the API but use libuv as a backend.  Then we would get the clean API with good docs, and all of the support and stability of libuv.  But I'm done here, for now at least...


Noticed in fastlane_core that it mentions nl-NL, cmn-Hans, and cmn-Hant -- https://github.com/fastlane/fastlane_core/commit/87a9a733eb2ae57209a86f1ec5b3329aaede3f6b


make it happen!


You don't add anything to result so the empty list is always returned. The return value of this method is never used so actually it doesn't break anything but still.


good job!


94006714-MultipleTowers (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1290 of 1290 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.01%25-green.svg)


Looks good, thanks @yavor87


Insert filter for jump ddt elements that has sub lots assignements (use cancel state for them?)


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 62](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191841&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 62](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191841&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:08


I personally would prefer ``this._transformers["idschema"].length == 0`` but I don't know if JavaScript programmer does agree :)


No prob
On Sep 3, 2015 7:19 AM, "RadiumBot" <notifications@github.com> wrote:

> Settings: LockscreenColors: Remove icon
>
> Thanks @BDogg718k for pointing it out :P
>
> Signed-off-by: Team-Radium <teamradium2015@gmail.com>
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Team-Radium/packages_apps_Settings/commit/3296325c8be8cdc31a41f0af1aefd8d97655128c
>


Was heißt den "Log ooo"?


Not yet publicly available, I plan to add it soon to METADATA.jl


I'd stick to hex values unless you need the alpha channel.  No biggie just code readability is all.


You may also want to add https://github.com/JuliaLang/WinRPM.jl and https://github.com/JuliaLang/Homebrew.jl/ here.


`style`-Attribute sind auch verpönt, besser dem Element eine entsprechende `class` oder `id` geben und dann in entsprechenden CSS-Dateien stylen.


Is the name of this method just a typo? `getPropertyFromCache`?


Test


Gefixt in 64dfe6f


Для единообразия просьба выбирать названия классов для определений виджетов, чтобы они заканчивались на "WidgetDefinition". Например "SwitcherWidgetDefinition". Название плагина ("NooUI") не нужно дублировать в названии класса.


The original regex is clearly not correct but I am confused: how did the files listed in your commit message *ever* match that pattern?

You have:

```
 "substitution failed for '/etc/swift/container.builder'"
 "regex substitution failed for '/etc/swift/container.ring.gz'"
```

How do those match `"/etc/swift/*.conf*"` in order to get into the `file_list` in `do_path_regex_sub()` and then cause that error to be logged?

I think we need to see some more data and analysis here to understand what is actually going on - those error message come from a pretty broad exception catcher and I am afraid we may be papering over real problems with this fix.

I am also very concerned to see binary (`*.gz`) files cropping up in these lists - if there is any chance these might contain secrets we must exclude them as we have no way to search and replace within compressed files.


In order to maintain consistency and fall inline with best practice it is best to dash separate your words e.g. align-right instead of alignright.  You have done it below so with the button classes.


Hi,

Please can you show how to restrict to a specific domain.


@wsnipex I'm trying to add libbson to depends, but the Makefile throws an error when I run `./configure`. The error is:

```
make: Entering directory `/home/garrett/Documents/kodi/tools/depends/native/libbson-native'
cd ; ./configure
/bin/sh: ./configure: No such file or directory
make: *** [/.libs/libbson.a] Error 127
make: Leaving directory `/home/garrett/Documents/kodi/tools/depends/native/libbson-native'
checking for LIBBSON... no
configure: error: "libbson not found"
```

It looks like `$(PLATFORM)` isn't set. I copied this from the other depends, so I'm not sure why.

Also, on windows I added the entire source because I couldn't figure out how to add a CMake project to the VS solution.

I'm pretty lost and not sure what to try next. Are there other libraries in the depends system that could serve as examples?


Thanks for the pull request. The change on line 300 however should not be there. Can you change it?


@nstaeger is it better now? :smile:


Is `update?` strict enough?


I think the point is that nixos-version should correspond with git describe.

With that said, because we already have this

```
$ nixos-version
15.09.75.76d7b9f (Dingo)
```

it means the tag should be made at "channel~75" (75 commits before current channel). So in a way, because of the way we manage release numbers, the release _has already been made_ (IMHO). Sure, we can _create_ the tag later, but the commit the tag must point to is already set. (Or we can update "nixpkgs.revCount - 67824" after tagging, but that's ugly.)

For reference (myself in particular), here is a way to figure out the release branch split commit (currently 75 commits older than the channel):

```
$ git merge-base origin/release-15.09 origin/master
977731f6c2227bc48ff2f9f628a30e3e38e09b4b
```


Да, нужно положить в ресурсы и добавить для плагина атрибут [CssResource] с параметром *AutoLoad = true*. Файл со стилями автоматически подключится на страницу.

[пример](https://github.com/dima117/thinking-home/blob/master/ThinkingHome.Plugins.Microclimate/MicroclimatePlugin.cs#L34)


This is a bug and renders your CSS invalid.  Get in the habit of running your code through the CSS validator [https://jigsaw.w3.org/css-validator/](https://jigsaw.w3.org/css-validator/).  You'll get vendor prefix errors which can be ignored but the syntax errors can be problematic depending on the browser.  What you are looking for here in order to achieve parity with the Visual Design is the

    font-style: italic;

in addition to the

    font-weight: 300;


I recommend going back to the `scope` method implementation that Pundit generated for you. The `record.class` implementation was in the Bloc foundation to simplify the introduction to Pundit.


#497
Lucee Beta testing is added into Travis parallel testing now.
https://travis-ci.org/cfwheels/cfwheels/jobs/78557486
main:
      [get] Getting: http://stable.lucee.org/rest/update/provider/express/5.0.0.65-BETA
      [get] To: /home/travis/build/cfwheels/cfwheels/target/lucee.war
    [unzip] Expanding: /home/travis/build/cfwheels/cfwheels/target/lucee.war into /home/travis/build/cfwheels/cfwheels
     [copy] Copying 1 file to /home/travis/build/cfwheels/cfwheels/WEB-INF/lucee
Just edit the travis.yml if you would like to test later version of Lucee.
https://github.com/cfwheels/cfwheels/blob/master/.travis.yml

    - PROFILE=jetty,lucee PARAM=luceeVersion=http://stable.lucee.org/rest/update/provider/express/5.0.0.65-BETA


I'd have dispensed with the surrounding section and used the `header` off the bat


Thanks!
Any idea how this should look like?!
![image](https://cloud.githubusercontent.com/assets/1010467/9657250/a9505286-523f-11e5-9790-94a41a49d1e5.png)

looks suspicious, but not inherently wrong.


Что это вообще?


этот абзац кажется избыточным


Always use "type" attribute in script tag.


I'm not sure this check for `show?` is protecting private sketches as intended. Could you clarify?


лучше BEM.i18n?


необходимых — лишнее слово


...pls correct line 1179 to set removefstab=no


Note `values_list()` doesn't return a QS, but a list-like `ValuesListQuerySet` object.


:heart_eyes: :heart_eyes: :heart_eyes:

![image](https://cloud.githubusercontent.com/assets/677704/9657287/9c978242-5237-11e5-985d-b78f79d37a2e.png)


yes it does.  Cool, that's easier. :)


What are you thinking about how to DRY this up?


что имеется в виду под «финальный» — лучше выкинуть либо уточнить


ok.
Hay varios archivos que no lo tienen, quizás deberíamos hacer una issue y agregarlo a todos?


I think this line is a reason for #2113


текст повторяется, см. замечания по формулировкам выше


Why there is additional copy of each file.
Also, always use "type" attribute for script tag.


101884090--NewVenting-Availability-Schedule (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (760 of 760 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.67%25-green.svg)


Wäre besser, wenn das zwei commits wären, aber okay jetzt. ;)


Nice use of the `q` tag.  Just to nit pick I'd use HTML escape codes for double quotes (`"`) in order to comply with best practice.

Additionally I'd use a `div` instead of a `section` for the testimonial to avoid the HTML validator warning.


tnx!


Sorry I didn't realize this yesterday - RESTful `resource` routing isn't going to be able to give us the paths we want.

Here's a starting point to help with the GET routes:

```ruby
get ":username/:sketch_slug", to: "sketches#show"
get ":username", to: "sketches#index"
```


Assignment is incomplete and not meet the requirements mentioned.


Пример иллюстрирует определенный порядок работы с данными переводов, но сам этот порядок словесно в документе нигде не описан (либо я не осознал по описанию, что это он).


test comment1


Excellent!


Whoops, need to take this out of an if. :)


Точно не нужна вводная к примеру?


cc @7c6f434c @ttuegel


^ What language is that?


Tess passes even if we replace this part with the code below. Is it OK to replace?

```swift
if (!path.isEmpty) {
    components.path = path.hasPrefix("/") ? path : "/" + path
}
```


Great test cases :+1:


Is this entirely necessary?


@kopischke `:plug` should still be treated as a command keyword (the keyword should be added to the generated vim syntax file... I imagine, because I can't make it work locally :/), the rule I added simply highlights the command argument as a whole. I used `String` because it's consistent with the way the `{*Plug/*Bundle}` commands are highlighted in plugin managers, where the spec is passed as a string. This should, of course, be extended when the fuller proposed argument syntax is supported.


Thanks for the Homebrew link.  WinRPM.jl is already listed.


When you don't have the link url it is better to put in `#` which will bounce to the top of the page, i.e. it is a bookmark.  You can target different elements on the page with the `id` where the following would jump to a location in the page with the `id` of "bottom"

    Go to bottom


you could name it mkRange too.


This changes the default query options. IMO it's better to explicitly add the MULTI_STATEMENTS flag where it's required.


The question was "to convert temperatures from Celsius to Fahrenheit or vice versa", not to convert a given number to Celsius or to Fahrenheit.

For the problem #5, you needed to read the character, not the string "boy" or "girl".

Read the problems carefully before jumping into the code.


on_connect_dbの行を消して、mysql_enable_utf8 => 1,  を追記したらいけるかも。


:+1: thx


You can specify the response status code as part of the call to `render`, eg.

```ruby
render json: ..., status: :forbidden
```
would respond with a 403 HTTP status code http://httpstatus.es/403


Adding `flags: Mysql2::Client.default_query_options[:connect_flags] | Mysql2::Client::MULTI_STATEMENTS` only sets the flag for this client instance, not globally.


Always use "type" attribute of script tag.


Yes, and the `current_user.destroy` fix you implemented works well.


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 63](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191870&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 63](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191870&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:05


Don't just use script tag. Always use "type" attribute of script tag.


Veeery good! Omnomnon coming soon!


On 03/09/15 21:41, Cecron wrote:
> We follow the CANlib API which states to return the id_.

???

I mmean that id_ (the second parameter) is only an input to
canReadSpecificSkip, not an output?

Even in the C api it is not a "return parameter", it would have to be
POINTER(c_long)

self.dll.canReadSpecificSkip.argtypes = [c_int, c_long,
                                                     c_void_p,
                                                     POINTER(c_uint),
                                                     POINTER(c_uint),
                                                     POINTER(c_ulong)]

        self.dll.canReadSpecificSkip(self.handle, id_, msg, dlc, flag, time)
        # Why is id_ returned here? It is a constant.
        return id_.value, msg[:dlc.value], dlc.value, flag.value, time.value


test comment2


Needs to be an expectation:

```ruby
expect(page).to have_content("........")
```


Debugging can be removed.


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1289 of 1289 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi Joel—Can you find a way to simplify the two null checks and have just one?

Also, alerting is okay as a way for us to understand what's happening. But we still haven't gotten rid of the errors when the parent element is null. Can you `return null` instead of alerting?


/bin/[ spawns a process each time it's used. [[ is a bash built in. This single change probably will save hundreds of execs per run.

> On Sep 3, 2015, at 03:19, Hubert Kario <notifications@github.com> wrote:
>
> can you explain why? preferably in the commit message itself
>
> —
> Reply to this email directly or view it on GitHub.
>


Line 40 can't fail, needs expectation
```ruby
expect(page).to have_content(....)
```


You should have solved the problems with basic functionalities. No needed to use this.form object and at. el.


ENCODING     => 'utf-8',
を追加したら治るかも。


The feature specs currently don't run any JavaScript, so the AJAX destroy functionality you wrote won't be run in this test. You'd see this same error if you disabled JavaScript in your browser and clicked the delete link.

We can make changes to the project to run JavaScript in selected feature specs in the next call to avoid this error.


Ahh sorry about that @por.  I'm working on one project with a couple changes to React Native to compensate for unique networking issues, so changing the version to test is a pain.  I added in exactly the line you provided, and published to npm `rn-redux-mixpanel@1.1.5`


Good


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 64](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191885&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 64](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191885&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:12


ありがとう！気づかなかった！


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


LGTM


название раздела и текст ссылки разъехались (и название якоря тоже)


gitignore


Great, thanks! :beers:


I think whitespace is significant in the places changed in this file. See 6bdd3840be63582531c3125a26cd00294e6f8346 for a way to work around this.


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 65](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191888&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


rip this diff


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 65](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191888&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:11


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 66](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191889&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 66](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191889&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:06


Localisation strings?


That's awesome, thanks!

I see that all tests passed too :)


Add descriptive note


Ciężko mi wyjaśnić skąd to się wzięło... :)


This method isn't being used anywhere, correct? If so please remove it.


Sounds good.


```repository.getDefaultBranch``` does not exist. How are you compiling the project?


Да, всё правильно, это и есть штатный способ: удалить из проекта и добавить ручками ссылку в csproj.


Please if possible merge this commit with the previous one.


toastr, bootstrap, font-awesome & jquery can all be installed/maintained with bower and be remove dependencies files from the repo


On Wed, 02 Sep 2015, Viktor Szakats wrote:
> @druzus: Przemek, this patch may not be correct here, as `nRead` will have `uiRest` added to it, so it won't match `FS_ERROR` in case of an error.

You are right, thanks for the info.

> See my patch for it: https://github.com/vszakats/harbour-core/commit/31fb998b7e64271a049e37acaeff2593faf869c9#diff-9af7df3fac6eaae66b9c58fa1065d386

It's rather good place for hb_fileResult().
It's possible that in the uiRest part are
next records which should be processed yet.
I'll commit fix in a while.

Best regards,
Przemek


ZoneHVACBaseboardRadiantConvectiveElectric-UI (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2308 of 2332 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.97%25-yellow.svg)


The suggested solution has one drawback: the default connection flags are changed. This can be avoided by adding a `flags: ` parameter when creating the `Mysql::Client` object.
If the class should be refactored, like suggsted here, the `flags` parameter must be passed to the `create_mysql_query_client` method.


This method does return a Queryset, but it makes 2 calls to db

I couldnt think of a single call way of doing it although im sure there is one


Better:
I have /many/ commands, but more are unlisted. Here are the most useful.


Does it make a difference if this is rewritten into a single pair of brackets?
```bash
if [[ ! -z "$previous_cipher" && "$previous_cipher" != "$current_cipher" && "$current_cipher" != "0000" ]]; then
```


removed: 3f1e737eb3084b9ce27ae4f75f378fc03bfab61b


Better:
I respond to messages both in chat and in private.


de-indent to match left-edge of condition =


Remove extra space before And


You're right, I misread the last lines.


Hey Aida :D Do the changes I commented in-code, and resubmit.

Making my own future commits is gonna be annoying o-o Still many major changes, after moving to Python.


Probably makes more sense to refer to the system than the planet anyway...


tag = "planet" but scope selects a system


stratified_tank_docfix (nmerket) - i386-Windows-7-VisualStudio-12: OK (1818 of 1818 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


If you use [ ] &&, it does because you're spawning [ twice. If you use [[, it doesn't.

> On Sep 3, 2015, at 04:59, Julien Vehent <notifications@github.com> wrote:
>
> Does it make a difference if this is rewritten into a single pair of brackets?
>
> if [[ ! -z "$previous_cipher" && "$previous_cipher" != "$current_cipher" && "$current_cipher" != "0000" ]]; then
> —
> Reply to this email directly or view it on GitHub.
>


Note: browserify does not support karma preprocessors.


It might be a good thing to use eslint (or something similar) to automatically detect this type of things. What do you think?


I'll lend you a hand late today. Don't worry


*typically


*Changelog


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1812 of 1813 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Of course, thanks. See 0cf9574eff.


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


There's actually disagreement about that between gecko and gaia code style. I'll use == then :)


dfvfv


sdvcsd


Out of curiosity, why was this changed ?


ServiceExtensionManager.start() and CallManager.start():
  No need to register the intent listener in a bg thread? Registration itself can be handled on the same thread I think to ensure that it is fully registered when the start() method is completed.

SupportedExtensionUpdater.run() and LocaleManager.start()::
  Try to avoid the deep indentation in the for loop by utilizing logic-inversion and "continue" command...

PublishManager() and SubscribeManager():
  Why was initialization of mAuthenticationAgent moved from constructor? Then you can not set it to final...

ServiceExtensionManager():
  In this constructor you initialize mUpdateExecutor directly but that is not aligned with AddressBookManager where you do the same in startAddressBookMonitoring() only. same as in the start() method of LocaleManager class..

ImsModule():
  Looks not like constants then: SipManager.TIMEOUT etc... if they are actually assigned in runtime they should be m-prefix and not uppercase....

Overall:
 a) Why not keep the same naming convention for the initialization methods in different classes... Now some is called "initialize", some is called "start" and some is called "start
 b) As a convention we normally shorten specifically a context variable to "mCtx" or ctx depending if it is a member or not.


Tried to fix it with ec28d3691644c64a73fd5940ff1d96881fa1fa23, can you see if that works...?


empd (jdwoods21) - i386-Windows-7-VisualStudio-12: OK (1792 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


赞，正在看抗战胜利70周年文艺晚会。


Toda, wercker gave me the error `/pipeline/git-push-f718fa43-11a6-4dbe-9aef-fb37219c06f3/run.sh: line 5: getAllStepVars: command not found`. Is this change related to that error? Do you mind sending a pull request to the upstream repository (perhaps without the other unrelated changes)?


I say lets do it.


This should say `$E();`


Due to my internal version issue I missed out the variable rename commit.  I now corrected that in the next commit. Thanks.


@nuwang Thanks for details! I think this may be fixed by PR #689.


Small typo: "caling" -> "calling"


Ok. I agree with you. So I'll do the same with call to _pwm_write, that was always returning -EIO too.


the man page says in "CONDITIONAL EXPRESSIONS" section that both the "[[" compound command and `test` and "[" are builtin commands.

And indeed, `strace` doesn't report that any processes were spawned by `if [ ... ]; then`:
```
cat > test.sh <<EOF
#!/bin/bash
a="test"
if [ \$a == "test" ]; then
    echo yes
fi
EOF
chmod +x test.sh
strace -f -e trace=process ./test.sh
```


I think `FOO_I_Cb_Ptr` in PHP is the callback for `foo_T<int>` in C++ so it's just a question of whether to use C++ or PHP names and I just decided to use the former. I definitely have no objections whatsoever if you want to change it to use the PHP names.


r+


流程图画得不错，思路清晰。


On 03/09/15 22:50, Cecron wrote:
> I believe getChannelData(self) is covered by the kvDevice class.
>
> import kvDevice
> dev = kvDevice.kvDevice(ch=0)
> print dev

Maybe so, but not supported on linux (my dev environment)

However, it is not of much importance to me, so
feel free to drop it.


@andytimes :weary: 可怜我等苦命少年还在撸代码


My AnkiDroid crashes when i try to look at the version:

```
E/AndroidRuntime(21565): Caused by: java.util.MissingFormatArgumentException: Format specifier: 3$s
E/AndroidRuntime(21565):        at java.util.Formatter.getArgument(Formatter.java:1111)
...
E/AndroidRuntime(21565):        at java.lang.String.format(String.java:1777)
E/AndroidRuntime(21565):        at com.ichi2.anki.Info.onCreate(Info.java:140)
...
```


Correct me if i'm wrong, but i don't think that this scenario could happen, because rxe_drop_all_mcast_group called from rxe_qp_cleanup when the last reference to the qp is dropped.


Hm, Pluralform von Schmelzer ist Schmelzer... eventuell kann man es auf Schmelzöfen abändern? Kenne aber den Zusammenhang nicht, bzw. ob was man sieht.


I'll have to think about this a bit.  Support would be easy to add, but providing a clean and concise configuration interface is what I need to figure out.  I have some other projects planned as well and would like to generalize things a bit to support those.  I'm thinking probably higher level configuration modes, like "pixel" and "serial" that present different UI's to the user based upon the mode its setup for.  I'll chew on it and see what I can come up with.


It would be good if PRs let you edit the file being reviewed inline, which would create a new commit on the PR branch


Excellent news, I will retract.

> On Sep 3, 2015, at 05:10, Julien Vehent <notifications@github.com> wrote:
>
> r+
>
> —
> Reply to this email directly or view it on GitHub.
>


No.  Github saw these two files as a conflict and I had to do a manual
merge of the two (which took forever because i had to compare them line
by line) and in the end the only difference was space on the bottom.  If
you look on github you'll actually see every line as having been removed
and every line having been added back in.

-Eric

On 9/1/15 10:54 AM, apquinn wrote:
> Are you just making fun of me with this?
>
>
>
> > On Aug 31, 2015, at 4:39 PM, Eric <notifications@github.com> wrote:
> >
> > The only change between these two files was removal of blank lines
> on the bottom.
> >
> > —
> > Reply to this email directly or view it on GitHub
> <https://github.com/johns996/NMU-Zen/commit/596a0e0a95880cd61a893ecd446bd0283c4af77d#commitcomment-12984938>.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/johns996/NMU-Zen/commit/596a0e0a95880cd61a893ecd446bd0283c4af77d#commitcomment-13001226>.
>


empd (jdwoods21) - Win64-Windows-7-VisualStudio-12: OK (1792 of 1797 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg)


LGTM!


Owwwwkeeee, I have some remarks :smile:

* you declare a `member` route, but never give an id on the url? (I would even assume it would not work or route correctly). I would declare it on the `collection`.
* The indentation of the routes (in my github view) is off. This is minor but I consider that important. If it looks good on your screen, you should configure your editor to always use spaces instead of tabs.
* the `:get` is really troublesome. A `:get` should be safe, meaning it will not change data. You should use `:put` (which is considered unsafe--it will change data, but doing it twice in a row will have the same result). It should be as easy as replacing the `get` in the route by `put`.
* I prefer to use the path-helpers. Run `rake routes | grep switch_phase` to see which you need to use. I guess it will be `switch_phase_orga_seasons_path()`
* why do you define a `helper_method :switch_phase` ?


no capitals and no closing >
:-)


lgtm


I think that's due to an error in the release generation actually, the
version string wasn't generated properly due to missing a module after
fresh install of ubunutu.
Sync isn't working either actually. I'll try release a new alpha today

On Thu, Sep 3, 2015 at 9:12 PM, ospalh <notifications@github.com> wrote:

> My AnkiDroid crashes when i try to look at the version:
>
> E/AndroidRuntime(21565): Caused by: java.util.MissingFormatArgumentException: Format specifier: 3$s
> E/AndroidRuntime(21565):        at java.util.Formatter.getArgument(Formatter.java:1111)
> ...
> E/AndroidRuntime(21565):        at java.lang.String.format(String.java:1777)
> E/AndroidRuntime(21565):        at com.ichi2.anki.Info.onCreate(Info.java:140)
> ...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ankidroid/Anki-Android/commit/ae14952f88c9d2efa51cff66ec5d58d469fcdee1#commitcomment-13045643>
> .
>


:clap: @perkovich


Should be `tests.js`.


This commit is to increase build idle time

[1] http://docs.travis-ci.com/user/build-timeouts/


I think it's an older behavior that may still exist on macos though. It doesn't hurt to merge it.


This should be `test-styles.css`.


Fixed.


Yes I think we can immediately replace  the old connection in the store when a new handshake (full or resume) is started (epoch =0)  if :
1) the cookie exchange is ok
2) the peer address was the same than the previous connection.


It's not the prettiest piece of code, but I've tried this successfully with another application:

https://github.com/fiedl/your_platform/blob/d3de8d21826b4f4f56127f537e9c40a3800087e5/app/models/received_post_mail.rb#L48L70

Actually, the first bit of code, I took from brimir :)

The additional code, basically, changes the image references to the already uploaded attachments via regex.

```ruby
post.text = post.text.gsub(/(<img [^>]* src=)("cid:[^>"]*")([^>]*>)/) do
  attachment_counter += 1
  attachment = post.attachments.find_by_type("image")[attachment_counter - 1]
  image_url = Rails.application.routes.url_helpers.root_url(Rails.application.config.action_mailer.default_url_options) + attachment.file.url
  "#{$1}\"#{image_url}\"#{$3}" # "<img src=...>" from regex
end
```


Checkmarx scan results 03 Sep 2015 15:20 UTC +03:00

High
Medium
Low
Info

New
1
1
2
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

066f603e097afc8f97b178984ff8475794e758a7	@cxehud


Do we really need this abstraction? Can cache implementation just to `Thread.currentThread().getId()` if it really needs to?
It is not very important but might make types and cache usage slightly simpler.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.952.6c00caa4bb0eedf80743572d5dca285103ce0702](http://build.palaso.org/viewLog.html?buildId=62621&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 501, ignored: 6 Build time: 00:04:27


Support for resize-grip is removed from gtk+ since 3.14 .


coding style


I don't understand your change. Are you suggesting that gtimeout is better than timeout?


This commit has misleading comment: max_* parameters set the maximum allowed percentage of the maximum speed set by the driver, not the maximum allowed speed of the AR.Drone.


As mentionned in slack, all processors are now LifeCycleAware


Hi Pat,

Thanks for the feedback! I was trying to set the image as a background but
was confused as to where I would reference it, in the html or in the css.

From what I know I can use the <img src=""> in the html.

But is that necessary, or can I just reference the image in the CSS by
using background: url("../images/background.png"); ?

Hope that makes sense.

Thanks for your help,
Pari

On Mon, Aug 31, 2015 at 10:55 AM, Patrick Nolan <notifications@github.com>
wrote:

> Not sure what you had in mind here, when you have the background set to a
> url it is expecting an image name and extension e.g.
>
> background: url("../images/background.png");
>
> would set the background to an the image background.png in the images
> directory one level above.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PariBilimoria/ga-fewd-19-assignment-1/commit/b2f2e70c3d65e3c9618f9b94ab4ac1246e2ce85a#commitcomment-12967984>
> .
>


This commit has misleading comment: max_* parameters set the maximum allowed percentage of maximum speed set by the driver, not the maximum allowed speed of the AR.Drone.


I think this are two problems.
One is here. I just checked out 0190126, rebuild (with a clean, and a deinstall) and tried again.
With that i can see the version (2.5alpha51) when i go to Prefs/Advanced.¹
It crashes only *after* i touch that line.

The other one is the broken sync and the non-display of the version number. I wanted to complain about that next O_o .

¹Odd, at the moment it looks like i can’t change the app language. I translated back from German.


This could be:
```
self.assertHTMLEqual(
    str(SubclassMeta()),
    """<tr><th><label for="id_name">Name:</label></th><td>"""
    """<input id="id_name" type="text" name="name" maxlength="20" />"""
    """</td></tr>"""
    """<tr><th><label for="id_slug">Slug:</label></th><td>"""
    """<input id="id_slug" type="text" name="slug" maxlength="20" /></td></tr>"""
    """<tr><th><label for="id_checkbox">Checkbox:</label></th><td>"""
    """<input type="checkbox" name="checkbox" id="id_checkbox" /></td></tr>"""
)
```
(actually it looks like one ' would be fine instead of triple "), at least in this case.


`[[ ]]` is more robust against unset variables, so sure, we can merge it just because of that - but putting this information into commit message will make lives of our future selves easier :)


101884090--NewVenting-Availability-Schedule (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1288 of 1288 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.02%25-green.svg)


This constant is not used


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.953.91c05f6078e84d7ca18059ede60070d7de444a28](http://build.palaso.org/viewLog.html?buildId=62622&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 502, ignored: 6 Build time: 00:03:04


For me xD Not for aarch64 devices lel


I'm with @floatingatoll on that one. RHEL is not the only target we support, having checks for availability is nice and doesn't cost a thing (ran once at startup).


Probably better to use constants for these fields. Are the btw related to constants in `RelationshipRecordCheck`?


Updated pull request to use boolattr vs a property.


ghjyt


Yep :3


I think using @value and @pin here is a mistake.


@feltnerm this breaks the following URL again... http://engineering.widen.com/2015/08/27/AWS-Lambda-Runtime-Configuration/

You should leave /blog/ out of this permalink, as it was not included at the time of publishing...


inconsistent coding style


s/discoverd/discovered/


This is true... Another problem to solve at some point... Thanks for looking anyway!


Correct, for now we will add it to the TODO file.


Only seen for patterns with two targets,

*or*

Only seen when patterns have two targets,


Is it official?


This seems wrong at first glance. The title and message are already exposed to a screen reader as a text, why would it get a label with the same value? See the MDN example for how it's supposed to be used: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-label_attribute#Example_1.3A_Multiple_Labels


That may be because due to the permissions issue (file locking) I have to copy, delete and then rename the copy back to the original. In that case maybe I ended up not needing to make any changes. I had that issue again yesterday. Very annoying.

Sent from my iPhone

> On Sep 3, 2015, at 8:14 AM, Eric <notifications@github.com> wrote:
>
> No. Github saw these two files as a conflict and I had to do a manual
> merge of the two (which took forever because i had to compare them line
> by line) and in the end the only difference was space on the bottom. If
> you look on github you'll actually see every line as having been removed
> and every line having been added back in.
>
> -Eric
>
>
>
> On 9/1/15 10:54 AM, apquinn wrote:
> > Are you just making fun of me with this?
> >
> >
> >
> > > On Aug 31, 2015, at 4:39 PM, Eric <notifications@github.com> wrote:
> > >
> > > The only change between these two files was removal of blank lines
> > on the bottom.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > <https://github.com/johns996/NMU-Zen/commit/596a0e0a95880cd61a893ecd446bd0283c4af77d#commitcomment-12984938>.
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/johns996/NMU-Zen/commit/596a0e0a95880cd61a893ecd446bd0283c4af77d#commitcomment-13001226>.
> >
>
> —
> Reply to this email directly or view it on GitHub.
>


Don't you need that to display the "no items" message when there's no waiting add-ons in the queue?


Коли ставлю параметр 1 -- вибираєтся 3-ій в масиві, коли 0 -- перший...


@Galadirith You are never using this function :)


OK


We have to restart in order to disable the plugin.


1: M111 unrecognized component name: babel


23:1: I201 Missing newline before sections or imports.
24:1: I201 Missing newline before sections or imports.
26:1: I100 Imports statements are in the wrong order. from babel should be before import six
27:1: I100 Imports statements are in the wrong order. from contextlib should be before from babel
27:1: I201 Missing newline before sections or imports.
28:1: I101 Imported names are in the wrong order. Should be _request_ctx_stack, current_app, g
28:1: I201 Missing newline before sections or imports.
29:1: I201 Missing newline before sections or imports.
32:1: I201 Missing newline before sections or imports.
33:1: I100 Imports statements are in the wrong order. from .errors should be before from .selectors
90:5: E266 too many leading '#' for block comment


You are allergic to spaces before and after brackets :)


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (761 of 761 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-10.25%25-green.svg)


DS/Assignment2/Queue and counseling System/College.java

Default constructor made.


you need to run ./autogen.sh instead of configure.
Two questions:
1. is this really a _native_ depend, i.e. not cross compiled?
2. why do you add the full bson source?


DS/Assignment2/Queue and counseling System/Queue.java

Instance removed


Very true! So (x\/a)/\x = x is another absorption rule (by -a = y and your derivation), which I believe is in the code already.


Default constructor made and both constructors shifted to top.


Please, add `@since: 2.3.0` here.


>Both `set_buffer_time_near` and `set_period_time_near` will use uninitialized value in `dir`.
The same is done in the official tutorial, because dir is used as an output. `set_buffer_time_near` sets a value at the address, `&dir`, but never uses this value before it is set.


Instance removed.


Same as above, `@since: 2.3.0`.


Name changed.


Nitpick: rather keep it, and add Python 3 too. :stuck_out_tongue_closed_eyes:

[Long list of classifiers](https://pypi.python.org/pypi?%3Aaction=list_classifiers)

I don't know if many people actually use them for filtering or anything on PyPI, but today I noticed there are a couple ones I haven't seen that are cool too:

```
Programming Language :: Python :: 2 :: Only
Programming Language :: Python :: 3 :: Only
```

Though we won't need those. This one is useful:

```
Programming Language :: Python :: 3
```

Since it'll mean the package will come up if people click on [Python 3 Packages](https://pypi.python.org/pypi?:action=browse&c=533&show=all) in the sidebar's links on PyPI.


Ah OK, it doesn't crash in the English version, I'll do a push/pull to crowdin


91958608DOASEffectOnZoneSizing (Myoldmopar) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.8%25-red.svg)


Maybe, I thought about that but
1) I'm not sure that a `Connection.getSession(int epoch)` make sense out of this context.
2) Currently, the `Connection.getSession()` is only used twice. One in `processAlertRecord`, another in `terminateConnection`, in `terminateConnection` case I not sure we will be able to give an epoch.


yes, RHEL is not the only target (I just mentioned RHEL-5 as an example of a very old but still supported distro), my point was that those checks are useless for Linux in general

they do add up for `top1m` and Nagios runs

so on Linux the performance is more important as it's rather unlikely that you'll be running the `top1m` or a Nagios probe on OSX


How about this?
```
g_dbus_method_invocation_return_error (invocation,
                                       STORAGED_ERROR,
                                       STORAGED_ERROR_FAILED,
                                       N_("LVMCache not enabled at compile time.");
return TRUE;
```


we


C'est juste que `$('.main-content').find('h1,h2,h3,li,p')` + `$(this).html(...)` c'est coûteux. Et je pense pas que ça en vaut le prix...


Please, use STORAGED_DAEMON_CHECK_AUTHORIZATION macro instead.


It seemed to me that since gtimeout always works, while others require further testing and checks to see which args they take, that using gtimeout if present was the simplest first case to check.

> On Sep 3, 2015, at 05:23, Julien Vehent <notifications@github.com> wrote:
>
> I don't understand your change. Are you suggesting that gtimeout is better than timeout?
>
> —
> Reply to this email directly or view it on GitHub.
>


what about:

~~~ {.c++}
auto stringRange = mkRange(input);
auto blackboardRange = mkSizedRange(begin(mBlackboard), input.size()).offset(uiOffset);

write(stringRange, blackboardRange);
*(blackboardRange + 1) = '\0';
~~~

(btw, you could overload `mkSizedRange` and have a `mkSizedRange(Container &, size_t)` that creates a range from begin to begin+size; then you can write: `mkSizedRange(mBlackboard, input.size()`)


Instance removed


I did not realize that this bash script was a high-performance endeavor.

> On Sep 3, 2015, at 05:39, Hubert Kario <notifications@github.com> wrote:
>
> yes, RHEL is not the only target (I just mentioned RHEL-5 as an example of a very old but still supported distro), my point was that those checks are useless for Linux in general
>
> they do add up for top1m and Nagios runs
>
> so on Linux the performance is more important as it's rather unlikely that you'll be running the top1m or a Nagios probe on OSX
>
> —
> Reply to this email directly or view it on GitHub.
>


Perfecto,  gracias por la ayuda, hoy lo hago, muchas gracias.

Unai
El 03/09/2015 12:31, "ISuriv" <notifications@github.com> escribió:

> He visto el código, y en vez de
>
> .cajaicono:nth-child(3){...} debería ser .caja1:nth-child(3)
> .cajaicono{...}, ya que quieres que cada caja1 tenga su fondo.
>
> Recomendación: Puedes eliminar cajaicono del código y meterlo en caja1 el
> fondo, y al texto le das el padding de la altura de la imagen, así te
> quitas una estructura html y se reduce mas.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jabrena/I24K_website/commit/28ec6da779f8bce291a20b5316ae78f2ab1f6040#commitcomment-13043913>
> .
>


OK. Je revert ce commit et on laisse l'issue en suspens en attendant de trouver une meilleure solution.


It is perfectly fine for a random number generator to return the same result twice in a row... How would you test that ?


Try to use "translatable" string literals. Eg.: N_("Error converting volume: %s")


It's not, but if running the `top1m` takes over 2 weeks on quite beefy hardware, you do start to care for every fork and hard disk access as it may easily mean you finish the scan a day early...


Null check


So it is not needed? I am afraid that I am not into ARIA.


the crash should be fixed now if you compile from source

On Thu, Sep 3, 2015 at 9:25 PM, ospalh <notifications@github.com> wrote:

> I think this are two problems.
> One is here. I just checked out 0190126
> <https://github.com/ankidroid/Anki-Android/commit/0190126554c5b9042529e7306c43dfcd502d28c7>,
> rebuild (with a clean, and a deinstall) and tried again.
> With that i can see the version (2.5alpha51) when i go to Prefs/Advanced.¹
> It crashes only *after* i touch that line.
>
> The other one is the broken sync and the non-display of the version
> number. I wanted to complain about that next O_o .
>
> ¹Odd, at the moment it looks like i can’t change the app language. I
> translated back from German.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ankidroid/Anki-Android/commit/ae14952f88c9d2efa51cff66ec5d58d469fcdee1#commitcomment-13045841>
> .
>


No worries Pari it's cool.  Basically when you want a background image you don't put the `img` tag in the html.  Typically you'll have a `div` with a `class` in you HTML and then reference that class in your CSS setting the `background` property. e.g.

HTML

The most basic example of a background image

There is no image here in the HTML it will be applied to the parent div with the class sky-bnkng.
        "bnkg" just being shorthand for "background" but could be anything as long is it matches up in the CSS.

It is also common to set a height in the CSS as the div will only expand in height based on it's children

and in the CSS

    .sky-bkng {
        background: url("http://dreamatico.com/data_images/sky/sky-8.jpg");
    }

Check out this [code pen](http://codepen.io/patnolanireland/pen/vNEKVy) for a visual.  It may take a few seconds to load as the image is huge.


Let's find a balance here. We have tons of users on OSX, maybe even more than on Linux. What's the right behavior to make sure cipherscan runs perfectly on both systems, without eating up too much cpu?


wew


This was necessary, because make always said that integrate was "already up to date" and stopping execution, because the target and folder name were identical.


r-
Bash 4+ is a requirement, and we'l have to live with that. Plus I find that *"STRING"* syntax a bit ugly :p


`gtimeout` is not present on Linux boxes, and using it doesn't remove the check for busybox anyway


Done.


Great, but would be more elegant to create a mapping {codec: encoding} at the top of the file, then:
```
for codec, encoding in codec_mapping.items():
    if text.startswith(codec):
        return encoding
```


Just released `v0.4.1`, thank you for your help


and thanks to @leomelzer as well! ;)


Aside from the usual grep vs bash discussion, is there a functional benefit to this change?


I think you forgot to remove a dot here.


This is ok but, it would be better to have the URL in a plist or some other form of persisted data.  For this assignment this is fine, just information for the future.


Yup. Fixed.


I get an email every time you rebase this. Can you remove the @ from the commit message please?


@tomato42: agreed, it's a better approach, but until #72 is merged, this patch seems an acceptable workaround.


Why is this unreachable?


@eherot what the hell does pinning do then?


hide rave planned date


@leipert Ahhh :D Thanks so much catching that, I wasn't careful enough with inspecting `markdown-it` [`4.4.0`](https://github.com/markdown-it/markdown-it/blob/4.4.0/lib/rules_block/heading.js) and [`master`](https://github.com/markdown-it/markdown-it/blob/255d62d39122694872ddce840e2141379ac3deca/lib/rules_block/heading.js), between which this [method was introduced](https://github.com/markdown-it/markdown-it/commit/b2aee1a9789c74e5eba16ac71d6a7b256fc61067#diff-b4b0934b2e6d9937d31c7a9c979fd34fL31).


OK, are you proposing convention that fields are always singulars even if they contain a list? I am OK with that, just asking, so that we can indeed adapt everything in general.


Does this test make sense any more?


Looks good.  Go ahead and merge.


you need to run those checks only on OSX because only it has the very old userland by default. No Linux distro new enough to have bash 4 will be missing `readlink` or `timeout` from `coreutils`.


It only shows up with pio2.

On Wed, Sep 2, 2015 at 10:26 PM, Robert Jacob <notifications@github.com>
wrote:

> Was this restart bug present for any case? Since the first version of cime?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jedwards4b/cime/commit/5e5c25a7f54c4626638b956ee75add8aa9244954#commitcomment-13039049>
> .
>

--
Jim Edwards

CESM Software Engineer
National Center for Atmospheric Research
Boulder, CO


I think the POSTREAD sync can be moved out of the if to shorten the code.

Also, I think the PREREAD sync is not required.   This is only does anything on certain non-cache coherent architectures, and even then only when the contents of the target buffer are dirty in cache.  Since we know that we cannot possibly be dirty in cache, I think this can be safely omitted


I removed the scope "meta.function-call.without-arguments.js" as it seemed overkill. To fix https://github.com/gandm/language-babel/issues/57 I changed the parsing to use a begin/end clause to trigger a flowtype parse. This was the quickest way to fix the issue which used flow typing within object functions with the call passed over many lines. I try to be flowtype aware rather than just blindly annotating pairs of K:V without knowing they are flow types. Hope this helps?


Looks good I will pull it and run it.


I think you're confusing the mechanism for determining the max blocksize limit, with the limit itself.  Dropping the top 20% refers to a part of the mechanism.  The 1MB floor just means that the limit cannot go below 1MB, regardless of what the mechanism determines..

Check out the open pull requests on this proposal, and you'll see some more clarification on these mechanism rules.


Perhaps top1m can override all autodetection logic with environment
variables, which if set indicate the correct binaries to use for openssl,
readlink, and timeout. I assume that the script is being called from
scratch one million times, so that should diminish needless work somewhat
without a more significant rewrite.

On Thu, Sep 3, 2015 at 5:46 AM, Julien Vehent <notifications@github.com>
wrote:

> Let's find a balance here. We have tons of users on OSX, maybe even more
> than on Linux. What's the right behavior to make sure cipherscan runs
> perfectly on both systems, without eating up too much cpu?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/4c9514228e0353e8d4ff2771880c8872fbfdc068#commitcomment-13046278>
> .
>


:ghost: :slot_machine:


Sorry, I was looking at the wrong line. You're right, I agree, why do the function return id_....


We lose the logging when not using Cheetah here. I suppose we should fix that.


If File's encoding is set to ANSI, it works without error.


Nice!  This saves you the cache miss you'd otherwise have when doing the mtod() on the mapped mbuf.


When I built it, the `provider :mlh` does not get recognized from `OmniAuth::Strategies::MLH` and the fix should be to rename the class to `OmniAuth::Strategies::Mlh`


Yep


No, it should be deleted.


Probably by running it a large number of times, putting the results in a list, and using some mathematical function for verifying the distribution of the values. Just guessing, though!


What is a native depend? I stuck it there because there were similar libs in native/

Some of the headers need to be generated via cmake, but none of the other libs use cmake so I couldn't figure out how to integrate the cmake step into the VS project


It's really more intended as a way to get packages from a particular release type (e.g. unstable, dev, etc.). The ability to add a "version" flag seems to have been an afterthought or side-effect.

https://wiki.debian.org/AptPreferences#Pinning


Note how there is no mention of "version" on the wiki.


What about other usages of this constant?


Well alright then. Thanks for laying it out.


I will retract the patch.

Note that, for top1m purposes, someone will need to benchmark =~ STRING,
 == *STRING*, and =~ "STRING" to see which is most efficient at 1 million *
N iterations.

On Thu, Sep 3, 2015 at 5:48 AM, Julien Vehent <notifications@github.com>
wrote:

> r-
> Bash 4+ is a requirement, and we'l have to live with that. Plus I find
> that *"STRING"* syntax a bit ugly :p
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/e285473fac49940e33007c19fae535e965e13555#commitcomment-13046285>
> .
>


Should this also control e.g. curl/wget verbosity and other commands?


```js
 if (cache) cb(null, cache)
else cb(null, []);
```
poderia ser reduzido para
```
cb(null, (cache || []));
```


None that I can defend, retracting.

On Thu, Sep 3, 2015 at 5:49 AM, Julien Vehent <notifications@github.com>
wrote:

> Aside from the usual grep vs bash discussion, is there a functional
> benefit to this change?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/3fa0e075ea756ed75fcc0d496cd270fcc68378d7#commitcomment-13046313>
> .
>


I don't need this until #72 is merged, retracting.

On Thu, Sep 3, 2015 at 5:51 AM, Julien Vehent <notifications@github.com>
wrote:

> @tomato42 <https://github.com/tomato42>: agreed, it's a better approach,
> but until #72 <https://github.com/jvehent/cipherscan/issues/72> is
> merged, this patch seems an acceptable workaround.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/d7a826d3d5ed705289041f98fde6d83ee3df1197#commitcomment-13046333>
> .
>


LGTM although when we move .cldr-data to a directory that is not the same as the directory html-build source goes in to, this will of course change.


Yes, it probably should. Will update it to do that.


Yeah that's what I was thinking too, but it looks like this would take longer than implementing these classes :)


This test is failing for me. Can you recheck that?


Nope, it will never fail. Retracting.

On Thu, Sep 3, 2015 at 4:04 AM, Hubert Kario <notifications@github.com>
wrote:

> can you say when this can happen?
>
> r+
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/973bf212c0b51a60f87037c63edd07f846603304#commitcomment-13044465>
> .
>


PREREAD: Hans said I need it for internal state keeping, I'll remove it.


>Also, since `buffer_time` is set independent of `period_size`, there could be the case, where only available period size is 80 ms.

Could you mean `period_time`?  `buffer_time` is set independent of `period_size` even in the original code, while in the original code we have:

```unsigned int buffer_time = 4 * period_time;```

Which may be what you're referring to.

Or maybe you mean that `buffer_time` was set and `period_size` was retrieved in a different order, as originally the calls were made in the order `set_period_time_near`, `get_period_size`, `set_buffer_time_near`. With my commit, they are ordered `set_period_time_near`,  `set_buffer_time_near`, `get_period_size`. The official tutorial uses the order   `set_buffer_time_near`, `set_period_time_near`, `get_period_size`.


shouldn't overflow


In principle I agree. However, in this case, there is also an argument to keep indentation as is. In all directly accessible files (public/* and admin/*), all code is enclosed by some if ($proceed) bracket. This is a transparent way to ensure code is not executed after some condition is not met and the page is supposed to be redirected. (A less transparent way would be to use die() at these places.)

The reason for this change here is a very special case of the enrolment page, in which $proceed is not only used for discontinuing after redirection, but also to separate enrolment steps. This resulted in a problem with not showing the footer on the enrolment page. The fix proposed here is just a quick fix for the bug, a proper fix (to be supplied later) will replace $proceed on the enrolment page with a different variable. When that happens, the if ($proceed) statement removed here can be put back. So not removing the indentation keeps the changes minimal.


Yup. Will update it correspondingly then


These constants will be used in subsequent commits. Of course, these changes could be added to the following commit.


This is fine but I prefer wait until all the issues are fixed before we starts to move the docs inline. Mainly because it's much easier to find and fix the docs if they are all in `helpdb.jl`


I'd say it's normal for tests to take a while to write.


Should we mention svn is a dependency? Does it still come by default everywhere?


It should be `val > dead_zone || val < -dead_zone`.


It could, but I'm not exactly a fan of hidden options in applications... Besides, taking care for the general case also benefits the general case as well as the top1m case


@raphink They are indeed! We just haven't had time to dig through everything that needs to go upstream and put together PRs that remove our SIMP-specific material.


Done.


1579840-GroundTemps (mmatts) - i386-Windows-7-VisualStudio-12: OK (1808 of 1824 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.12%25-yellow.svg)


This fixes the Trebuchet crashes.


In general our dependency docs are not very complete... e.g. we need perl with some XML::Parser package apparently.


We might want to change this a little so that there is no difference in the datetime value between ``date_testing`` and ``date_pushed``.  As written, there will be a microsecond difference between them.  I don't see any way that could cause a problem with other things as they currently are written, *but* someday someone might write some code to check ``if update.date_testing == update.date_pushed`` for whatever reason.. and it'd be nice if they were the exact same value.

Could write:

```python
now = datetime.utcnow()
if self.request is UpdateRequest.testing:
    self.status = UpdateStatus.testing
    self.date_testing = now
elif self.request is UpdateRequest.stable:
    self.status = UpdateStatus.stable
    self.date_stable = now
self.request = None
self.date_pushed = now
```


Not Happy with the Variable Name


yeah it would be good to itemize the dependencies thoroughly/systematically (later)

svn doesn't come by default everywhere afaik; do we should definitely mention it. And curl too—for now at least (because the perl script calls curl to download the demo stuff)


r+


@aszlig @edolstra `virtualbox.host.enable = true` doesn't work, falling back to `virtualboxHost = true` works for me on `15.09` branch


Would be cool to show this as a new value in the update html view.  Perhaps in the table on the left?


FourPipeBeamAirTerminal (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1822 of 1822 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


After autoprefixer was:
```css
  .col-xs-1 {
    -webkit-box-flex: 0; /* no width, it breaks down a markup */
    -webkit-flex: 0 0 8.33333%;
    -moz-box-flex: 0;
    -ms-flex: 0 0 8.33333%;
    flex: 0 0 8.33333%;
  }
```

after changes:
```css
  .col-xs-1 {
    -webkit-box-flex: 0;
    -webkit-flex: 0 0 8.33333%;
    -moz-box-flex: 0;
    -ms-flex: 0 0 8.33333%;
    flex: 0 0 8.33333%;
    width: 8.33333%; /* fix */
  }
```


hi this is for testing


I have removed this patch from the patchset. If greadlink support is
desired, it can be added separately. I assume top1m performance bypass for
autodetection would be tracked in a separate issue, so I'll defer to that
issue instead.

On Thu, Sep 3, 2015 at 6:04 AM, Hubert Kario <notifications@github.com>
wrote:

> It could, but I'm not exactly a fan of hidden options in applications...
> Besides, taking care for the general case also benefits the general case as
> well as the top1m case
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/4c9514228e0353e8d4ff2771880c8872fbfdc068#commitcomment-13046560>
> .
>


no... it's reachable


What does this line do?


False alarm, prefix changes from `services` to `virtualization`


```java
assertThat(flow.getLanguages(), contains("eng", "fre"));
```


Would it be an idea to perhaps use an integer instead?  That way we can set no gravity (0 as dy), minor gravity (5 as dy), normal gravity (9.8 as dy), and heavy gravity (15 dy)?


Ah balls, sorry rushed through my lunchbreak


Nope we are not using locals and we are not intending to add languages support for now. Good thought though.


Thanks. That one works again.
(I guess i’ll have to translate a few strings again, now.)


Octree (DeadParrot) - i386-Windows-7-VisualStudio-12: OK (1818 of 1818 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Sorry. If you were to remove the import of kvMemoConfig and kvmlib, and don't call memoOpen(), memoClose(), readConfig(), writeConfig() and memoReadEvents() it should be fine.
Perhaps we should move the import into those functions, or just ignore the ImportError, until we get Linux support?


r+


this change is wrong, should be done with  "configure --with-curl=/usr/local/lib"


I actually like the idea of bypassing a number of checks if the `-unsafe` option is given to cipherscan. And not just for top1m: we use cipherscan in the TLS Observatory where it would be nice to bypass a number of checks we know are going to succeed.


fixed errant [ https://github.com/sallyom/docker/commit/48badd2a2e3a6712baa6fce1e97e87e1feb3dc38#diff-92db8b4a4ee2e2b29e80bf21321aebf1R162  and squashed, thanks.


Esto lo deberiamos incluir dentro de un Git Ignore para evitar tener que renegar a la hora de debuggear


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 67](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191973&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


Any specific reason for keeping these (since ret is already zeroed)?


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 67](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191973&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:12


int(val)?


I never noticed before - why did you remove the python scripts? Those were there to serve as a reference and be something to build on top of later for automated testing.


FourPipeBeamAirTerminal (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This is wrong because the lifts come after all of them. The forms return should be an "update forms" function that takes the final offset


Счетчики постов в Избранном больше не перебрасываются на строку ниже.


I think the gravity strength is best defined as a general property in the class implementing gravity behavior, for all gravity affected elements will be affected in the same way. I can't see why one element should be dragged down with a different force than another element. I suggest we keep it simple.


Ah ok now I see you did change allocation of both tables in kmap_init().
Then I would suppose we need to use kernel PGD in LOAD_FAULT_PTE macro for both pkmaps and fixmaps.
As of today we always use task's PGD.

So that piece of code should look like now:
```
#ifdef CONFIG_HIGHMEM
	and	r1, r2, PGDIR_MASK
	cmp_s	r1, PKMAP_BASE
	mov	r1, init_mm
	ld	r1, [r1, MM_PGD]
	bz	01f

	and	r1, r2, PGDIR_MASK
	cmp_s	r1, FIXMAP_BASE
	mov	r1, init_mm
	ld	r1, [r1, MM_PGD]
	bz	01f
#endif
```

Agree?


:+1: to `--unsafe` - then we could even add sanitization of options passed to openssl - e.g. adding options ike `-no_tls1_1` or `-curves P-256` to script will cause unexpected results


This link is broken because urls.py still has a capitalized "MPL"
`page('MPL', 'mozorg/MPL/index.html')`


Definitely see the follow-up "FIXUP" commit. This was just left here for clarity, but should instead be squashed. :]

The `sum()` in the line _iterates_ over the `map` object so that the exception is raised if conversion is impossible.


Dne Thu, 03 Sep 2015 05:49:19 -0700
Claude Paroz <notifications@github.com> napsal(a):

> Great, but would be more elegant to create a mapping {codec: encoding} at the top of the file, then:
> ```
> for codec, encoding in codec_mapping.items():
>     if text.startswith(codec):
>         return encoding
> ```

Indeed using loop here seems cleaner, I've rewritten the commit.

--
	Michal Čihař | http://cihar.com | http://blog.cihar.com


もうpackageの実体を置く必要が無くなったので


Seems referencing urls have been updated to lowercase. So this needs to be updated too.


nope, just didn't get them all; thanks!  let us know if you find more.


Should this alembic script try to go through all the existing updates and set values smartly for ``date_testing`` and ``date_stable`` (by scraping the old comments or just by using the value from ``date_pushed``)?


Sure, added this as a new commit as the end of the series (as this anyway gets reworked later on).


@gpedro blz, valeu pela dica man!


The "banned" flag is serialized within the attribute system so unless attributes are somehow deserialized earlier or banned players are saved separately (which Major didn't want) I don't think there's a way to do that.


1579840-GroundTemps (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1808 of 1824 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.12%25-yellow.svg)


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 68](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191983&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 68](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191983&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 128 (new) Build time: 00:00:07


:joy:


haha nice.


I can't use --verbose parameter for status
I execute
gradle status -PliquibaseCommandValue=--verbose

What do I do wrong?


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 69](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191985&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


Nesbox


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 69](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191985&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:06