If you use rack-test and include the rack test methods you don't need to use Rack objects directly like this.


Inheritance can be used in Doctrine in many ways: http://doctrine-orm.readthedocs.org/en/latest/reference/inheritance-mapping.html, so from the user side there won't be any difference with single table.

But if someone use this entity as a base class for custom driver (like we do) then all this github fields should be added into the table, moreover hardcoded `github.com` can't give us an ability to use this features for our internal system. sigh...

Of course, it's only my feeling about that )


minor typo: implement`a`tions


CNAME域名绑定


yep,  that's exactly what the tag does when disabled.


Try using more descriptive names. Abbreviation can be difficult to follow and generally frowned upon.


I wonder if there's a way where you could not have to declare the headers each time.


`Appled`? never took you for a fanboi


It can +`be` :stuck_out_tongue:


The [CARE Decode table batch specs](http://www2.mhmr.state.tx.us/655/CIS/Training/files/decode.pdf) have the abl values as the following:

### ABL
  * 0 Not Retarded
  * 1 Mild
  * 2 Moderate
  * 3 Severe
  * 4 Profound

What do you think about making the radio labels match the decode specs?


What's the purpose of this change? Assigning to nothing it's like just doing nothing... The previous code assigned it to sails.services


I guess `Room 1` could be "fetched" from the props of the room wrapping the `MessageBox` itself. Just a wild guess, I didn't check the code yet.


Should be bit 32-63


This has created two blank entries in the explorer which looks weird. They should behave the same way as the card back face and not appear at all.

![screenshot00287](https://cloud.githubusercontent.com/assets/2443519/9791492/323da70e-57d3-11e5-9163-36cb9da30dd3.png)


Evolution of mean w.r.t. iteration
![Evolution of mean](https://cloud.githubusercontent.com/assets/3079749/9791525/f49a468a-57ca-11e5-8928-e243a2a98217.png)


Is there any difference between using 3 or 4 backticks, as long as the closing ones use the same amount?
It's normally just 3, but 4 are actually easier to type on a German keyboard...


Unused import? And I can't find it on PyPI.


@wsnipex: what variables should i use for gcc and ar? also, what's the replacement for `$(MAKE) install` that will copy `libunqlite.a` to the right place?


First shot at making a cidr range calculator for both ipv4 and ipv6. Certainly not the nicest code i've written, but it works.


That's a valid question, if possible maybe You can check it from jekyll code that if this field is mandatory? If not, then removing it is a good idea, one thing less to check when merging PRs. Time is quite pointless there anyway.


感觉不能这么修改吧, 这样修改会发生错误的


I checked, and I feel like you could either store the *current room* in the state of the `ChatController` component, or store that information in the, well, application's store. That way, you could avoid duplication of hard-coded strings like `"Room 1"`.


**Eslint**: 'return' outside of function


Disaster Recovery/safehaven-manually mapping disks in 3.0.md

typo: CONTENS should be CONTENTS
Also, are you sure you want all caps?  Selective caps or bolding may be more effective.  Just a thought.


not working. Public ip is 93.186.75.74. Chek the links

config_local.json
http://igrice-auta.com/config/config_local.json

client/js/config.js
http://igrice-auta.com/js/config.js


Oops sample_output.txt content cleared on exit. Example here https://raw.githubusercontent.com/jezard/fit/349bbea3d81bfe65165092e398e1ca9fef9a6b10/sample_output.txt


I broadly agree with this change. Just a note, the `match` statement will later be put into a conditional, like this:

```rust
if think { // currently _ in the function signature
    let formatted = format!(...) // number of lines / which line is irrelevant
}
else {
    let formatted = match lines.len() { ... }; // no change here
}


I wonder if we should generally prefer the following syntax: `*[*]*`
It should be equivalent to `<i>[\*]</i>`, but doesn't require HTML tags, and `*` should be easily understood.
Better would be a working markdown parser of course, that would allow `*[\*]*`, although I find the `*` variant still slightly more readable.


@moollaza Please double check that this is the right check. I noticed I was still using the [citi_bike_nyc check](https://github.com/duckduckgo/zeroclickinfo-spice/blob/master/share/spice/bike_sharing/citi_bike_nyc/bike_sharing_citi_bike_nyc.js#L20) in my code.


@switchhax Okay, cool, I will make a direct commit to fix that


`ImmutableList.copyOf(Splitter.on(SEPARATOR).split(input))`
Because `ImmutableList.reverse()` is fast and String.split() does regex (not a good idea)


This seem fine to me howewer it not resolve sln creation on windows.
As i can understaind its not the purpose and the fail is due to ACE.

So did you tryed to compile it with gcc or travis?

If yes please push this we need to have boost asap :)


deklarasi `dest` seharusnya bisa langsung digabung saja kan menjadi seperti ini:
```Javascript
var dest = program.destination;
```


vendor/cmsdk/cm/lib/main/java/org/cyanogenmod/platform/internal/PartnerInterfaceService.java:237: error: cannot find symbol
            packageName = mAudioService.getCurrentHotwordInputPackageName();
                                       ^
  symbol:   method getCurrentHotwordInputPackageName()
  location: variable mAudioService of type IAudioService
Note: vendor/cmsdk/src/java/cyanogenmod/profiles/ConnectionSettings.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
1 error


An alternate (and IMHO better) fix would be to encode the copy threshold (default MHLEN) in the ring.   When closing, re-set the threshold to 0, to disable the copy optimization.   You could also add a sysctl to set the copy threshold to allow for easy tuning


:+1: Good choice of license


I guess here, you may extract the `convertedMessages` computation in a function, sibling to `render`:

``` js
var MessageList = React.createClass({
  convertMessage: function(m) {
    // …
  },

  render: function() {
    return (
      <div className="message-list-wrapper">
        <div className="message-list">
          {this.props.messages.map(convertMessage)}
        </div>
        <div className="message-scroll"></div>
      </div>
    );
  }
});
```

Keeping things separated like that is usually a good idea: `render` does only the "rendering", `convertMessage` is responsible for preparing data prior to that rendering. It makes it easier to test the latter behavior independently, as well.


I believe @pluma added support for collection names (double @) to aqlQuery, not sure if it's available everywhere however. Would be good to mention it.


It is not function parser directly, but the libMesh ```ParsedFunction``` class (see libmesh/include/numerics/parsed_function.h).


It's nice to see the application coming to life component by component like that :)


Tidak perlu ada spasi setelah `!`
```js
if ( !dest ) {
```


Done, please verify. I made it a sub-section, because a new user should read about backticks/native first, *then* read the trade-off.


Nice!


Fixed.


do we need sth. like an exploit first until we fix this? thats very bad handling of security. :-|


That breaks the bulleting (you get one bullet point per line). I left it as-is.


Jekyll's fine with removing it, so I removed them.


I've made those changes to the branch separately, but thanks.


why are we deleting these migrations?


The Great Dive.


It works because it was fixed on commit https://github.com/bdilly/soletta/commit/4ada4158da43255b3a34d0d1894a3ebeaf51738f

Probably I've used 'fixup' in the wrong commit =/


looks good to me :+1:


adding methods to an interface requires a major version bump


Thank you for adding NaNs, indeed I can see that would have been more
elegant if I did it directly. I wrote a slightly longer note on this in the
corresponding git issue https://github.com/schoffelen/MOUS/issues/87 "Left
and right-branching load were added as new fields below each word. Trees
were updated by changing the depind of each word.". I wasn't sure whether
you would rather read the commit message or git issue or both.

On Thu, Sep 10, 2015 at 4:43 PM, schoffelen <notifications@github.com>
wrote:

> Yes, indeed. And inconsistently so, because the word list words don't have
> them. Which in principle is to be expected, but this caused my lower level
> code to crash. I added NaNs if missing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/schoffelen/MOUS/commit/dc586c5f03ce09df29061539f821c54ac0d5bf08#commitcomment-13161534>
> .
>


Nice, thanks!


I'd lime this to be enabled only in multiplayer if at all possible. It should at least never work for hosts (single player)?!


I have seen this swap idiom, but I think the assignment looks cleaner. Is there a reason to prefer the swap over the version I used? In any case, I think this is just a horribe C++ design decision because it's incredibly unintuitive.


Hi Pengfei,

I had an error in the Resp charge fitting process after input the command line
"MCPB.py -i 4WG2.in -s 3b".
The output is:

***Generating the 1st stage resp charge fitting input file...
***Generating the 2nd stage resp charge fitting input file...
***Doing the RESP charge fiting...
Traceback (most recent call last):
  File "/Users/lizhe/amber14/bin/MCPB.py", line 596, in <module>
    premol2fs, mcresname, 1, chgfix_resids, g0x, lgchg)
  File "/Users/lizhe/amber14/lib/python2.7/site-packages/mcpb/resp_fitting.py", line 468, in resp_fitting
    chgs = read_resp_file('resp2.chg')
  File "/Users/lizhe/amber14/lib/python2.7/site-packages/mcpb/resp_fitting.py", line 24, in read_resp_file
    chgs.append(float(i))
ValueError: invalid literal for float(): -0.742655-10.639205

It seems to be caused by the congestion of the two numbers "-0.742655-10.639205" in the file resp2.chg. I am not sure if this is only a small bug in the program or a two-digit number such as "-10.639205" should not appear here? Thank you.

Here is my resp2.chg file:

  2.216275 -6.597141  2.216275  2.216275 -0.134049  0.082364 -0.415700 -0.113689
 -0.024900  1.143142  6.146710 -1.326579 -1.326579 -2.336562  0.597300 -0.567900
 -4.065199  2.949320 -3.564031  1.559970  1.559970  1.559970 -0.007796 -4.000934
 -1.154978 -1.036486  4.371899 -4.856783  0.058608  0.301517 -1.625513 -0.375309
 -2.373024 -2.240860 -4.002299  0.317773 -4.395177 -1.064403  1.112252 -0.030639
 -0.742655-10.639205 -4.600871 -3.990088  0.939039  0.915688 -0.304825  1.787373
  1.397101  2.507536  7.727419 -0.014341 -2.700399 -2.314635  1.178161  0.936923
-10.172273  1.215045  2.840944 -2.580298  9.269629  1.290459 -2.074242  3.442288
  2.335666 -0.101468 -0.101468  0.070537 -0.026244 -0.791319 -0.791319 -0.418522
 -0.418522  0.624450  0.624450  1.254970  1.254970 -0.885796 -0.885796  1.872325
 -1.707551 -1.336228 -0.392426  1.333452  1.333452  1.333452  3.271100  3.271100
  3.271100  1.779419  1.779419  1.779419  1.672887  1.672887  1.672887 -1.392352
 -5.817102 -0.537772  1.386956  0.450305 -1.261183 -1.201162  1.886074 -2.557181
 -1.251732 -4.434978 -0.797377  0.271498  1.401290 -0.445985 -0.796364  1.872801
  1.218128  1.218128  2.298221  2.298221  1.917806  1.917806  1.917806


:smile:


I really like the fact that each new "feature" has its own little commit. Very easy to follow what's going on in the project.


Doesn't it also speed up the update query notebly? Or is that a side-effect of being less memory consuming?
http://stackoverflow.com/a/31919182/2044940


>  All of those except for pcap-npf.c would declare "find all devices" and "create" routines ..

That would make sense and be cleaner.

> ... install NetMon or Message Analyzer in order to use an application using WinPcap doesn't
> strike me as an advantage, unless whatever driver they install can do things that our driver can't.

I'm just starting to experiment with NMAPI. I've made a little test program based on some Japanese C++ project! Both the older *MS Network Monitor* and *MS Message Analyser* has some cool features libpcap based programs doesn't have. One can filter traffic based on **program-name** etc. I didn't find a video on exactly that, but [here](https://www.youtube.com/watch?v=Ip7TZOrx9Q4) is a good intro for *Network Monitor 3.4*.


Same idea as with `convertMessage` in the other commit, I'd probably extract the data handling stuff in its own function, just to keep things separated.


I would remove the comments.


Why do we perform any sort of version check here?  This is redundant.


`ImmutableList`


No, ```i == _nvar``` only at the conclusion of the nested loop below. The highest number used for indexing is ```_nvar-1``` (```_gdim*_gdim == _nvar```).


What is this, no more POSTs?  This breaks lots of things.


While reading the code, I was wondering whether `openRoom` would be a slightly better wording, as I would expect either open/close or create/destroy, not a mix of those. But I'm no native speaker :)


Looks pretty good to me!


It's more like a rearranging/reconfiguring of stuff with a few things added. The chapter is a mess and I will continue rearranging over the next few days/adding a few more things until it flows and makes sense.

The chapter should be ready for editing and revision by Monday!


**Eslint**: 'return' outside of function


Just as a point of interest, you could already do this with #add_category which recommends against adding categories on the fly, and there is now no way to prevent accidentally training categories that you didn't mean to. At the very least we should consider reusing #add_category


good catch


Thanks!  What branch should I be looking for with the alpha-4.0 release?

We've been tracking develop to get bug fixes, but will start cherry picking
those after the 4.0 cutoff.  We're ahead with database migrations (using
develop) so we can't switch back to hotfix-1.3.5.

On Thu, Sep 10, 2015 at 8:13 AM, David Turner <notifications@github.com>
wrote:

> This does require that any custom tables/models that inherit from Entity
> (in any plugins) be updated as well. This is a SQL script I found helpful
> to generate the sql needed in the plugin migrations...
>
> SELECT '
>             Sql( @"
>     DROP INDEX [IX_ForeignId] ON [dbo].[' + [name] + ']
> " );
>             Sql( @"
>     EXEC sp_rename
>         @objname = N''[dbo].[' + [name] + '].ForeignId'',
>         @newname = ''ForeignKey'',
>         @objtype = ''COLUMN''
> " );
>             Sql( @"
>     ALTER TABLE [dbo].[' + [name] + '] ADD
>         ForeignGuid uniqueidentifier null,
>         ForeignId int null
> " );
>             Sql( @"
>     CREATE INDEX [IX_ForeignKey] ON [dbo].[' + [name] + '] (ForeignKey)
> " );
>             Sql( @"
>     CREATE INDEX [IX_ForeignId] ON [dbo].[' + [name] + '] (ForeignId)
> " );
>             Sql( @"
>     CREATE INDEX [IX_ForeignGuid] ON [dbo].[' + [name] + '] (ForeignGuid)
> " );'
> FROM sys.objects
> WHERE [type] = 'U' AND [name] LIKE '_org%'
> ORDER BY [name]
>
> This assumes your custom tables begin with '_org'
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SparkDevNetwork/Rock/commit/ce250dff763c6b4bb93eb8501d232ea00797cb8d#commitcomment-13158110>
> .
>


Current behavior is that the Golang client in master is not sending the payload anymore when the payload to be sent is over the max payload threshold and just returning an ErrMaxPayload error, meaning that the server would not be sending the `-ERR` message since not getting it: https://github.com/nats-io/nats/blob/master/nats.go#L1161

In order to test that the server does send `-ERR` when receiving a `PUB` control line with a reported size over the max payload size, I had to create another simple client which tries to do this because there was no way of doing it with the Go nats client since now rejecting to send the message if over the max payload.


Atualização realizada. Nova regra adicionada e modificações feitas.


Yes, 1MB is what we currently set as the default `MAX_PAYLOAD_SIZE` and we set 10MB for the `MAX_PENDING_SIZE`:
https://github.com/nats-io/gnatsd/blob/master/server/const.go#L28https://github.com/nats-io/gnatsd/blob/master/server/const.go#L28


This looks like some find and replace error. Same for line 8 (`geos-config`/`pdal-config`).


@micdijkstra :point_up:


Please add timezone info for "00:00 and 12:00"


Why -strcmp if strcasecmp == 0? Is there a reason we should put lowercase above uppercase?


Please change to `bike_share_indego_phl` to match the IA Page: https://duck.co/ia/view/bike_share_indego_phl.

FWIW whatever your `id` is, should be the same as what you pass to `Spice.failed()`


It was just a note. The assignment is ok too.
The clear statement is not clear, since the capacity is not changing... they though about memory allocation speed... and not occupied memory.


test


Use [es6 template strings](http://tc39wiki.calculist.org/es6/template-strings/)


Ok. I'll remember this.
I updated the PR


Already updated :-p


`vm.graphic.tag === vm.data.tag` ?


Well, that's not what worries me since addresses on modern OSes are all aliased relative to the procedure's address space via page tables.

My main concern is the potential for unknown issues in underlying VB internals, given the somewhat haphazard use of Int vs UInt vs Long in various underlying OLE functions.  (e.g. SafeArray functions)  I assume there's no way to know if any VB functions check pointers using something like ">=0", except by enabling the flag and seeing what happens...


```javascript
const link = `${githubRoot}/tree/master/mod`;
```


Develop branch is where development takes place for version 2.0.0 iirc.


Your tuned (Rank)Seed values will certainly deserve a test alone (without the BonusFile)


That's a good point. Can you file an issue and we'll fix is before the next release?


`GenericStack` uses `if flash || cpp` around the `@:generic`. I wonder if I should add `!display` or start/search for the underlying issue.


Jim, if you could change that to CONTENTS it would be greatly appreciated. Also, yes I want this in all caps (perhaps bolded as well if you feel it will be impactful, as I had a customer improperly follow these directions and ended up overwriting their production D drive with their Production C drive and it was an enormous, time consuming disaster to recovery from (luckily they were running 3.0 where there is a local cache, the 3.1 version they would be SOL).

I can make the change if absolutely necessary but can’t edit the branch without resubmitting, so if it isn’t a huge deal to you it would be greatly appreciated! I am just about to submit another SafeHaven article in that DR folder so hopefully it will now appear.

Please let me know if I can do anything or be of any assistance.

Thanks!

Jake

Jacob Malmad
Sr. Cloud Architect
CenturyLink Cloud

Mobile: 203.844.0516
Email: jake.malmad@centurylink.com<mailto:jake.malmad@centurylinkcloud.com>

www.centurylinkcloud.com<http://www.centurylinkcloud.com/>

From: Jim Phillips [mailto:notifications@github.com]
Sent: Thursday, September 10, 2015 10:52 AM
To: jmalmadclc/PublicKB <PublicKB@noreply.github.com>
Cc: Malmad, Jake <jake.malmad@centurylink.com>
Subject: Re: [PublicKB] Added warning about manual disk mapping/further explaination (e27fd2f)

typo: CONTENS should be CONTENTS
Also, are you sure you want all caps? Selective caps or bolding may be more effective. Just a thought.

—
Reply to this email directly or view it on GitHub<https://github.com/jmalmadclc/PublicKB/commit/e27fd2fcde5d5d06779e2d5816c8cce758530360#commitcomment-13161772>.

This communication is the property of CenturyLink and may contain confidential or privileged information. Unauthorized use of this communication is strictly prohibited and may be unlawful. If you have received this communication in error, please immediately notify the sender by reply e-mail and destroy all copies of the communication and any attachments.


I believe you still want the `proxy_cache_valid`. That tells us to cache the API response for 15 minutes (the default is 24 hours).

the `spice is_cached` tells us to remember the API call we made for the query given. So if "indego phily" is search and we hit "api.indego.com/stations.json", the next time we get that query we'll just make that request.

More details: https://duck.co/duckduckhack/spice_advanced_backend#caching


Want me to just send a PR for it?


@JordanCheney can you post-commit review?


I can test this but I'm not sure where to look to see if there'd be any problems.


Did our indentation settings change somehow?


Good catch. I'll update that in a sec.


Oops, should we add a test for Model._latex()?


Are there any methods now in CommandOperationHelper that can either be removed or made private, in order to avoid the possibility of this happening again inadvertently?


Sadly, I still don't have inter-ESP name resolution working, but it's getting very close!


@etiennestuder The _org.eclipse.buildship.core.test_ plug-in still uses Guava 18 and slf4j 1.7.10 in the libs folder. Should I change these?


FYI, it's better to use `.endswith()` here.


These were actually in 1.x anyway, took them out for 2.x and then changed my mind, but @hannesvdvreken is right, this is a major version bump.


My retail character can send messages up to 120 characters, so its not that


We've had a 'policy' discussion on `w` arguments: they really should not be followed by any other arg spec. (We've going to 'let off' `\exp_args:wN` as it's been around for so long and is quite tightly defined, but really should just be `\exp_args:w`.)


Witam, mysle ze wkoncu bedzie tego efekt dzieki za pomoc dziekuje


Equals method with hashcode issue: Don't know if needed to fix.
Visibility modifier: Could anyone tell me more about why, instead of maybe cleaner, it would be better to put in in a method instead of the way I did it?
Linelength of 128 instead of 120 in Spawner class: Could the line length be upgraded to make this pass (it is a line of code)?
FileTabCharacter: I don't know how to fix these, I think they are gone, but apparantly not...
Thanks, NH


In general right now - recreating all sections. A lot about how this will refresh and when is up in the air on the product side and we don't have technical requirements because of that. So for now - just reloading everything.

Nearby I treat special - because it really is different with subscribing to the Location notifications and such. Even here on the product side there is much to be decided about how we actually refresh, so once again not really tackling rebuilding the section based on moving a certain distance or after a certain time because we don't have technical requirements yet.


done


Or maybe it is better to use:
```
  Background:
    Given the "nexteuropa_webtools" module is enabled
    and the permission "view bean page" is assign to "anonymous user" role
```
to initialize the environment ?


Ah: this I did not know. I'll adjust our code.


You could also extract this with a regex.

```javascript
const [_, githubRoot] = this.props.commit.url.match(/(https?:\/\/.+)\/commit/)
```


That would be lovely!


This should be `const`


Ah yes, thank you..


looks much better!

need to fixup my latest, then will merge


Got it..


nothing which impacts you right now


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 573](https://teamcity.labkey.org/viewLog.html?buildId=271247&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:23:15
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 20 more failed tests, see build details
```


Don't forget to add *normalize.css*. ;)


Can i ask why these kind of commits are necessary?  Renaming columns makes virtually any sql modding tools and scripts for custom content utterly redundant.  I lost two months in project time after the last changes to this table (about 2 months ago), and now, just a day after I fixed everything you go and rename them all again.  Why?


Same condition twice? Here and on line 11.


openshift_url -> url


They have changed over time.  I no longer have `align when multiline` on - I believe that changed a long time ago - as you can see below on line 180.


It didn't work.


any need to extract a function?


what about
`elif 'os-release' in cmd:`


right - didn't look at which branch this was ;)


1749_fix_SPM_icon (mbadams5) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2295 of 2337 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.2%25-yellow.svg)


Maybe we can change the threshold to something a little higher, say `> 150`.


Thank you
I go the deleted.


Damian?
Tu email viene con simbolos coreanos o japoneses, no se, en el remitente.
Gracias por el dato de todos modos!

2015-09-10 6:16 GMT-07:00 ジョセフ·ダミアン·ガリード <notifications@github.com>:

> acá el title tiene problemas ya que este debiese ser encapsulado entre
> doble comillas (") para poder usar la comilla simple (') en el titulo
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ciudadanointeligente/nebe/commit/84d3a0c5e27fe22aca0b5453f41f8fd4358911db#commitcomment-13159392>
> .
>

--

----
Viviane Castro Salinas
Cel. +1-604-652-1226

*"Our lives begin to end the day we become silent about things that
matter."*

*--Martin Luther King Jr.*
A smile is a powerful weapon; you can even break ice with it.
~Author Unknown


@dmiedema fixed here https://github.com/ClementPadovani/Alcatraz/commit/61635afd836ec0878aaffae75978cbec19e49c8b


A new PR will take care of the empty array problem.


Already submitted by the way.


I remember seeing a discussion in some other PR whether we should use accessors of the form XXX() or getXXX(). Currently, I think we mix both. I personally prefer the shorter ones. Do you have any objection to calling this method ``modified`` and the one below ``created``.


@acapola Interesting, do you have a link to this docs ?

@andreyloktev Mirror.c should be rewrite in one hit and with one style of coding :smiley: I am not against using std.
Even dokany code should be updated.


Students/Bologa M. Marius - Vasile/Zoowsome/src/javasmmr/zoowsome/controllers/MainController.java

My mistake!


Does expected.element_not_enabled not work here?


@hongsudt this should definitely be set to 'false' by default, right?


@lindamartin I would name it `modifierTokens`


Do you use this import? I don't see it anywhere.


cool


@houmark @gpopovic I have a PR which fixes this on the demo site. Any chance you could test it to see if it resolves your issues as well?


Same here, does an expected.element_enabled check not work here?


Doesn't this constant also require a trailing period?


side note: this problem was already used by some troll which killed at least one game with it.


Does an expected.element_enabled check not work here?


ES6 trick: This is can be shortened to `this.setState({step});`. When the key name and the name of variable for the value are the same, you only have to write it once.


Huh? Didn't appear to work for me. Is this specific to a version?

Would it be safer to get users to create new file then parse said file through `php`?


Here, you may have used `git add -p` to split the commit in two (one commit for the `author` edit, one commit for the `flux` dependency).


Yes, that's precisely why. It came up pretty quickly while implementing the changes.


If such a case presents itself in the future, why don't you give that command a shot :)


Single line of code doesn't seem like worth te be extracted as a function.


actually, late last night I realized this is the same as is_enabled().  will change. thanks for the reminder since I forgot about it until now.


NO.IT.IS.NOT

You are putting a texture pack into a mapgen mod. Also, you seem to be the only one responsible of this choice and I don't think @Gael-de-Sailly was aiming in making new textures for default blocks.

"they only take 1.7M total". You're adding some useless and off the subject stuff. It is not part of valley mapgen mod, so it shall not be on valley mapgen mod project. POINT. Keep this on your computer if you use it, but do not add it on that repository. If you want to add it, for now, try to contact @Gael-de-Sailly (I know he is actually in a hard-working period).


@jandre,
I wanted to notify that your code would probably break on next pull.
I've added the new 'Get' version and named it 'DownloadFromContainer' and so i apologize as we had to change your 'Put' func's name to match it. The reason for choosing different name is to be more clear and also not confused by the ExportContainer vs something like GetContainerArchive (which should have been the twin if being consistent with the 'PUT' name)
So sorry again


I am looking for feedback on this approach. Once we agree this makes sense I will search the existing modules for strings.


Didn't work? What happened?

No specific version, nothing special happening there.

> Would it be safer to get users to create new file then parse said file through php?

What do you mean?


Ignore me ^-^ I'm wrong! Should be viewing this in the markdown viewer for help.


Hey Travis, we're bumping out Finagle deps to 6.27 and noticed this. 3.5.0-alpha seems a bit risky?


Reminder : i'm here at review.


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 11](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=158&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


Not to mention that IE9 isn't ES5-compliant either, only IE10+ is. The same applies to Android Browser <4.1.


define local fun with var


I sure will, hopefully later today! I had missed that PR as well.


This one was super awkward to refactor. We may need to make couch testutils and postgres testutils


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 11](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=158&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:23


Haha ok, no worries :)


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 12](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=159&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 12](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=159&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:17


Review done. I think there are still a few exercise to cover (2.3 Specificity topic, practice with styles overriding, 2.4, 2.5 and 2.6, where you can also push changes from our feedback) but this looks really good! Keep working like that! :D


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 13](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=160&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


This library doesn't do much so we may just want to write this ourselves but it pulled it in to save time.


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 13](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=160&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:14


i < end :)


Do we want these as devDependencies instead?


Sure.
On Sep 10, 2015 8:24 AM, "Steve Nolen" <notifications@github.com> wrote:

> @hongsudt <https://github.com/hongsudt> this should definitely be set to
> 'false' by default, right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stevenolen/ohmageServer/commit/a38dd4cf099f1a6f7ecba0012d63ec9007d46d63#commitcomment-13162551>
> .
>


1749_fix_SPM_icon (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Just curious: what is "ARM"? (I looked through https://en.wikipedia.org/wiki/Arm_(disambiguation) but couldn't find anything obvious.)


This is really annoying and not ideal but I coudn't find another way to do it.


LGTM


@bgerstle

> I think this name (and the comments) are a bit confusing.

the comment is wrong, which I will push in a bit… but the intent is that it does the same thing as `wmf_arrayByTrimmingToLength`, only starting at the end instead of the beginning. So it seems to me they should be named the same way.

> What do you think of: wmf_subarrayFromIndexToEnd(index:)? Similar to -[NSString substring(From|To)Index:].

I don't like the "index" part… because the purpose here is to specify length - not an index for using in the desired way. This would be similar to proposing that we rename `wmf_arrayByTrimmingToLength` to be `wmf_subarrayToIndex` which is ok, but pushes some +1/-1 math to the user of the API instead encapsulating that logic within a more purpose built method.

So TL;DR
1. Not opposed to a rename
2. New name should still take length as a parameter not index to reflect actual use case
3. Should be similarly named to `wmf_arrayByTrimmingToLength` (which could also be renamed to stay similar)

I actually thought it made sense… other names I thought of seemed less obvious in intent and more clunky.
- so I'm not sure what to rename it to in order to make it less confusing for others - but if you have a name that would fit the above requirements I'd be happy to rename it.


When I initially decided that `dbaccessors` shouldn't be refactored my thinking was that it didn't make sense because those functions were too close to Couch. But looking at it again, it may be nice to have that same interface via postgres. Let me know what you think


can we `mock_docker()` only `if MOCK:` ?
and perhaps run it before `tasker = DockerTasker()`, because that'll be needed after (if) merging #310


What does that force do anyway?


What about testing all of the get methods and delete?  The code is so simple that maybe this not needed, but its something I thought of while looking at the code.


@bgerstle Doesn't line 39 obviate the need for the safe method? Or better yet can you write a failing test?


@lindamartin May be `classModifierToken`?


it used to be set to false, and all autohost owners changed it to true, because they prioritised ingame join above this issue.

The problem isn't in this specific setting, it's the fact that spring's security is either "everything is open" or "everything is blocked".
In other words there should be a different solution.


Automatic Resource Management


I added the change to https://github.com/hongsudt/server/pull/5 !


= !!network?


Thanks !


Nice! Maybe also add `'xmax': 100` as it's a percentage axis?


@daggerrz This is an update to match our internal third-party dependency configuration, where we've had this set to `3.5.0-alpha` since the beginning of August (and I believe we've been using 3.5.0 in some places internally for much longer than that).

I don't have a lot of context for the update, so it might be worth a quick question to Finaglers or the Gitter channel.


Sure


parseInt


Do you intend to create a pull request?


thanks. I guess you should now uncomment the swig_this lines in the runme files in the test-suite (that I carefully commented before)...


Nice try, but this seems wrong, mostly because of the code you started with.  :-/

The update function reads raw_error, and writes master_increment and slave_increment.

The sample function reads master_increment and slave_increment (both multiple times), and writes raw_error (potentially multiple times).  For safe multi-thread execution, I propose:

In the update() function:
=====
* The writes to master_increment and slave_increment members need to be combined into a single atomic 64-bit write, or there is the potential for the sample() thread to see an inconsistent view of the two values.

In the sample() function:
=====
* At the start of the function, read the master_increment and slave_increment values using a 64-bit atomic read into a local variable.  Use these cached local values for the rest of the function.
* Instead of modifying the raw_error member several times during the function, accumulate the changes in a local variable then atomically update raw_error at the end of the function.

I think that's enough to make this safe regardless of thread scheduling and multi-core operation.


Also note we don't use the safe method in `wmf_arrayByTrimmingToLength`


get rid of second push


See https://github.com/ezsystems/PlatformUIBundle/pull/327


As far as I understand this, it statically detects linked libraries using ldd right?

I have a tool, [ReproZip](https://github.com/ViDA-NYU/reprozip), that can find *all file requirements* using dynamic tracing (ptrace) then generate a Docker image from that.
I always intended it to run on your host machine and "dockerize" (or "export") your app or software experiment, but if I follow your example and run it on an existing image, I would effectively be shrinking it :open_mouth:

(came here from your [blog post](http://blog.librato.com/posts/docker-images), but couldn't comment there, so here we go)


newIndex is changed on the next line


^buil-in^built-in


@lindamartin Don't you want to merge these two children to one separate interface?


@houmark Awesome, thanks! Please make sure to ping me when you respond. I sometimes miss e-mails, but I really want to hear your feedback on this one :-)


I don't understand this. Why there are no brackets and why we first use (?) it (`getstatusoutput`) and then mock it ?


http://sprunge.us/djii Here you go, with code: http://sprunge.us/jUWH

It seems, everything is nicely off after some time :-)


@lindamartin When there is no "implements" does this list contains 0 elements or is it null?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20428/testReport/) for this commit**


Thanks, fixed!


Thanks, also fixed.


I reduced it to 3 backticks. Using 4 was unintentional.


Sharing db structure between branches makes more easy to develop tools for all branches.


Goede splitsing, kudo's


hm, should we include this for jquery as well?


DB要砍掉重練囉


Correct, @pluma added support for that. Usage of collection objects in `aqlQuery` is now also mentioned in the documentation.


@pkourany this doesn't really tell me much as a beginner. What is this suppose to mean?


Oh, I missed the increment down at the bottom.  But it raises the question of why you would do this instead of triply-nested for loops.


I'd say `^familiar^aware` ... running this command once isn't really correct imho!


Here is a better log, with both location more nicely formatted: http://sprunge.us/XiaK


Speedup is likely a side-effect of the query requiring less memory, but it can't surely be predicted if there will be speedups. At least the change shouldn't make anything worse.


40 lines above we `workflow.tag_conf.add_unique_image(), could these two be done on one place ?


lol - almost too good of a Cocoa name…


This change broke various test for property that still are located in <meta>, given the method name it should probebly be reverted and put your code in a new method.


I mean the filename VTK_impl to vtk_impl


Huh?! Why would I need a triply nested loop here? That would be a totally different logic.


Ok, sounds good.


You should put some names here


Comma here?


Use this cdn: http://cdnjs.com/libraries/nvd3


Should we be avoid product names?


Remember to remove 'test' from the route


4385-CondenserLoop (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (1834 of 1834 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Whether is "seq"  one of the default emacs packages? ……


Yeah, we don't. Despite the errors, the half cooked third_party libraries would still "make" MLDB through.
It's that boost is used and missing from third_party_core. So I used make third_party_all, which leads to building blas and errors. And I just mark down the problem here.


Don't forget to format this file.


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 14](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=161&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


hello world in go 02


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 14](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=161&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:31


@davidfestal you beat me to it :)


OK, the ones commented out here: 8fc108f4efa58143a21426683875dd6e06f2506e, right?


In case you're interested here is my 1.43.03:
http://aldostools.org/temp/test/webMAN_MOD_1.43.03.rar

Changes:
* Added support for _hold / _release parameters in /pad.ps3 (for faster/better response in virtual pad)
- webPAD GUI for PC support this in "Game Mode"
- http://st.aldostools.org was updated to also support "Game Mode" using keyboard
- A new theme GUI: http://st.aldostools.org/pad.html
* Updated the libraries in "vsh" and "lib" folders (Mysis & 3141card)
* Fixed a couple of compilation warnings


Aye, I did too
On Sep 10, 2015 11:22 AM, "Frédéric Césart" <notifications@github.com>
wrote:

> Thank you
> I go the deleted.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Fred6681/android_kernel_samsung_golden/commit/c4654ff5d8e26a8cfa4e7713d9b092dc5f4fde56#commitcomment-13162489>
> .
>


Cái nồi gì đây


Nice work tracking down this bug.


@lindamartin May be `ClassDeclarationTree`?


Yes. Sorry about that.

From: Joel Andersson [mailto:notifications@github.com]
Sent: 10 September 2015 16:47
To: jaeandersson/swig <swig@noreply.github.com>
Cc: Thielemans, Kris <k.thielemans@ucl.ac.uk>
Subject: Re: [swig] [MATLAB] Implemented swig_this (dab27fe)

OK, the ones commented out here: 8fc108f<https://github.com/jaeandersson/swig/commit/8fc108f4efa58143a21426683875dd6e06f2506e>, right?

—
Reply to this email directly or view it on GitHub<https://github.com/jaeandersson/swig/commit/dab27fe46c0b56b7ac720a2aa12b9b50398c2e85#commitcomment-13163121>.


I actually had to look up the meaning of `*`. My HTML times are gone too long. But I don't mind, we can use either as long as we agree on one working variant. Can you confirm `*[*]*` is actually working? I can then replace all the occurrences of the other form.


You could actually use the wildcard `*/` alone, if I'm not mistaken.


Thanks for catching this. I've added boost to third_party_core.

On Thu, Sep 10, 2015 at 11:45 AM, YuWeiren <notifications@github.com> wrote:

> Yeah, we don't. Despite the errors, the half cooked third_party libraries
> would still "make" MLDB through.
> It's that boost is used and missing from third_party_core. So I used make
> third_party_all, which leads to building blas and errors. And I just mark
> down the problem here.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/daiwei89/third_party/commit/1b10457cfe6ffb0a8999fde1e2ebb1416e9c247e#commitcomment-13163088>
> .
>

--
David Dai
Ph.D. Candidate
Machine Learning, School of Computer Science
Carnegie Mellon University
http://daiwei89.github.io/


@kennethlimcp, the function will not work as expected for the Serial port.  In fact, it does nothing.


@moollaza Changing the id  on line 30 to bike_sharing_indego_phl kills the css.  Can I just change the Spice.failed to indego_phl instead.


This is weird. ```pi``` does not work. It gives me an error: ```Unable to find function 0.1*sin(2*x/10*pi)```. In parsed_function.h I see ```fp.AddConstant("pi", std::acos(Real(-1)));``` so... WTH?


1.大写英文字母不能用
org.mobiletranin.StudentSalculator

Application windows are expected to have a root view controller at the end of application launch

2.三目运算符 简化代码

3. NSArray *pe=[NSArray array];qertwyuyuiop

4.警报
 Ordered comparison between pointer and integer ('NSInteger *' (aka 'long *') and 'unsigned long')

解决办法：去掉*

5.self.account.attributedPlaceholder = [[NSAttributedString alloc] initWithString:@"邮箱/手机号码" attributes:@{NSForegroundColorAttributeName:[UIColor whiteColor], NSFontAttributeName:[UIFont systemFontOfSize:19]}];

6.navigation 导航条高60

7. NSLog(sender.on ? @"打开" : @"关闭"); switch  sender.on  //三木运算符


`bower cache leaflet-draw-drag` might help..
On Thu, Sep 10, 2015 at 8:57 PM Alexander Milevski <notifications@github.com>
wrote:

> I just did, but I guess bower registry cache is playing all weird, still
> pointing to your repo. I hope it will refresh at some point later.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sonnygauran/Leaflet.draw.drag/commit/8bb51add2d007b585bb20c08371525282ade48a6#commitcomment-13158964>
> .
>


20150911　風林火山 極　追加


Closes #171


@lindamartin Why this Tree in Declaration part?


This revision is clean.


@lindamartin May be just `token`?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20429/testReport/) for this commit**


**no-unused-vars**: operationList is defined but never used


**no-alert**: Unexpected alert.


**Eslint**: 'return' outside of function


**require-jsdoc/require-jsdoc**: Missing @jsdoc for action


**no-unused-vars**: nextProps is defined but never used


**no-unused-vars**: Dropdown is defined but never used


@lindamartin `varIdentifier` is a bit confusing, like it is `var` keyword itself


Apologies for the useless line ending diffs on this one. Conflicting settings somewhere :(


Rather than this commit, I would drop `www/docs/gadget/guardian` and anything that only it uses (which would be this expenses code).


Oh, I see. That;s great. The default function stuff in ```FEProblem::getFunction``` does _not_ use ```ParsedFunction```, but uses ```FunctionParserBase``` directly!


Interesting. We can all do this (serve a page) with many other programming languages. Looking forward to more. Be great to see alternative routes also. I for one will be adding some notes for my tutorials. Thank you @eddiejaoude !

Looking forward to actual coding or change of title from "introduction to a said language" to something more correct? Eg. "Hello Greener World with PHP". That was a joking reference and thank-you to the "Author" of PHP, [Rasmus Lerdorf](https://en.wikipedia.org/wiki/Rasmus_Lerdorf).


could be an `uint64` =)


radix' forgotten


This bitch, what the hell


@lindamartin there are a lot of differences in this interface and USE_DECLARATIONS from grammar, like semicolon, commas, absence of useToken and useTypeToken. Why so?


Copy paste? (sane as line 40)


One other thing to consider? Use repository name that keeps codebar's URI clear. See mine for example! ^-^


@lindamartin There are a lot of children which type is general `Tree` and you limit it by documentation. WDYT can we make this limitation by implementation?


thanks,
i edit php.ini file and display_errors = on :

http://s5.iranxm.com/up/13fd63d76c8a.png


**no-alert**: Unexpected alert.


You don't need this piece (keystore, lines 42 to 51)


Nice 👌 👌 👌


Its causing me pain.  And the claim of it's documented does not help..  I've been trying to get newer versions to do an apt-get for a few hours now.


fixed in 346d1d3da8efe2387d17d85e704486832387f6ba


Do we still need these changes.
These tests are now passing fine with `godep go test` and `sudo make`.

I don't think the local store changes need this test change.
Can you please rebase to latest and check whether this test changes are still needed ?

Thanks.


keyStore is not needed, you can remove this line


Usually I would say *yes*, but those browsers are much better to develop with as they have tools to help. I can remove if people are really against it.


works on 10.9.5


I'm glad it's useful to you, but I played around with it, and my assessment was that it kind of half worked, but there were major problems that I couldn't readily fix (see [this comment](https://github.com/takluyver/terminado/issues/7#issuecomment-75887573)), and if it was merged, I'd be forever fielding bug reports. I'd rather just say it doesn't work on Windows than provide something that works badly.

Cygwin might avoid some of those issues, but probably not all of them - and in any case, I don't want to provide a Windows solution that relies on Cygwin.


Where does `@color/primary_material_dark` come from and why is it not just inlined here?


This is just test code, in case you want to touch it, be aware there is no longer need to cast the ids to strings.


OK, thanks!


@danilaml Yep, rewriting that part anyways.


I'm thinking that other countries may also have other browsers and that these words may have issues being translated or being used there.

Side note: Browser – Web or Internet Browser. I perhaps the later?


I reworded this


acknowledged


Are you planing on adding this to all files, or why did you start adding it here?  Just wondering since I don't see any non-ASCII characters in these files so it shouldn't really make a difference.


I initially just thought you forgot to remove them and they were from an older iteration of the code.  On their own, I don't think they suffice as documentation.


@Ian-Stewart-Binks It would be great if you could change them.


Hi, I don't understand the meaning of this commit. It introduces unwanted failure when I upgraded vibe.d dependency from 0.7.23 to 0.7.24 in my project. I have used the option for setting an empty path to cover both http://localhost/whatever and http://localhost/whatever/ cases. Could you please desribe the rationale behind this change? Thank you.


would be easier to read if you logged the diff:
diff = added / samplerate - (time elapsed - delay)

if all goes right, diff should be constant.
given this equation you can calculate delay and compare with the value you get from PA. then use the calculated value to smooth the PA returned one.


I don't remember what that's for. :-) Anyway, as `getstatusoutput()` is implemented on top of `Popen` we can just remove that code.


Well, this has to be the last match variant anyway so I would prefer no comma. Dunno what rustfmt thinks.


インデントが欲しいです！
```css
div#left_menu {
  width: 180px; /* ナビゲーションの幅 */
  font-size: 80%;
}
```


Ok


This should be abstracted out into a generic results class which can be appended to all JSON responses.


Might be good to do some sanity check on the settings, just to make sure that the apikey and interval are not left undefined.


ここもインデントが欲しいです！
```html
<html>
  <body>

  <link rel="stylesheet" type="text/css" href="menuber.css">

  <div id="left_menu">

    <ul>
      <li class="law"><a href="#">法文学部</a></li>
      <li class="kan"><a href="#">観光産業科学部</a></li>
      <li class="edu"><a href="#">教育学部</a></li>
      <li class="sci"><a href="#">理学部</a></li>
      <li class="med"><a href="#">医学部</a></li>
      <li class="eng"><a href="#">工学部</a></li>
      <li class="agr"><a href="#">農学部</a></li>
      <li class="etc"><a href="#">附属図書館</a></li>
      <li class="etc"><a href="#">附属病院</a></li>
    </ul>
```


update


Thank you for your documentation. I start to unterstand my code now.


If people want to customize their forum, they should make a new theme, not just edit the css files.


Yeah that's the correct behavior. `\` at the end of a line drops any newline characters, along with any subsequent whitespace.


Sure, I updated it and removed the product names


sadly i can only repeat bibim (i hope i understood him correctly):

spads adds lobby spectators ingame as players and so a password check can be done.

@Yaribz is that true?

i don't have a spads configured, so i can't easily test that.


No worries! I can update my project accordingly.


nice one! but I'd say it's `bool.__or__`
I can't give example with `string_types`, because they are 1-tuple in PY2 & PY3, but for example
`integer_types = (int, long)` and `1` is integer type if it is instance of `int` *or* `long`, not *and*


I'm happy to merge this change but (unless I missed something) it looks like it's just moving the exact same code to a separate function, without changing the time parameter handling logic (which I believe already handles the case where no time parameter is passed, by defaulting to Date.now() there https://github.com/cloudfoundry-incubator/cf-abacus/blob/master/lib/aggregation/reporting/src/index.js#L195 for example).

Was there a specific issue with the time parameter that you were trying to fix here?

Thanks


rax retry tests


This check is probably not needed, It'll always be true.


Why include `Immutable` right into `module Hamster`?


Uh oh.


We should probably something like:

NOTE:  `Serial.flush()` via USB is not available and does nothing when called.


Victor Rolim Costa


$(CC) and $(AR)

install:
cp $(LIBDYLIB) $(PREFIX)/lib
cp unqlite.h $(PREFIX)/include


Oh yeah... :-D


Of course I did. That's why you actually have to be in a subdirectory of tools/basecurve/ for .. to work. And since you already created such a directory without using it I thought it would be handy to cd to that.


adfdafdsf


If you want to change the example to use `#add`, you should edit this sentence as well.


> extra 'ms'

О, как я не заметил. =\


cd $(PLATFORM); ar rcs $@ unqlite.o


Getting fancy with the for-else, ey?  : )
Nice one.


Are you sure? If a function failed to get the conf value, what will happen?


Will we ever have a Remove and Update Change for the same mod?


I can't see how a search & replace can take 2 months. Anyway, I can't make guarantees but the latest name changes aren't supposed to change anymore since most of the field names are blizzlike


Честно говоря я тоже. Это в куклотреде подсказали.


Looks fine.


PLACEMAKER for ongoing review.


This feels a bit redundant.


I hear you. I'm using cygwin bash and it does seem faster than git's. Also I am able to run vim albeit keyboard input is a but messy.

I've patched the code slightly, added SIGHUP and isalive support. I've also added some functionality to search for bash in the path. If it's okay, perhaps you could merge them into this branch?


Vat do i look like mad? im simply saying too ;)


More or less _not_ constant :-)


mpv's renderer is not guaranteed to be lossless in any case.

This is also not the only part of opengl-hq that introduces a low-pass filter, in fact opengl-hq already runs a low-pass filter on the input by default, even for 1:1 reproduction.

opengl-hq is not about 100% accurate reproduction, it's about reproducing a high quality result. I've noticed that the default recommendation for “high quality video output” seems to have become ```vo=opengl-hq:source-shader=deband.glsl```, rather than just ```vo=opengl-hq``` (which is sort of the point of opengl-hq to begin with).


Yeah, I think so. We already declare `es3` in `.jshintrc`. I don't think we'll drop IE9 and Android 4.0 any time soon so this will be necessary for some time.


@cehallen DWMR. Persistence. Success. Good. Keep it up!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20431/testReport/) for this commit**


@sophokles73, is it more clear now ?
(Sry to insist but I think this is the last point we need to discuss before I finished this feature :))


Trakt?  Copy paste?


Nice


`'4.0'` => `'4'`


I changed it to modified() and created().


Кстати, я почти допилил фикс к https://github.com/SthephanShinkufag/Dollchan-Extension-Tools/commit/4e3c93bcb855bdda8d6a4f3564e5a8935fc81d6d#diff-3ffdccae365c029e209bbfa4211be3e6R12474. Скоро выложу.


#45 Has the goods


jacob you will need to pull from master again before you continue working I added a bunch of files

:-) - cory


Здорово. Скрипт потихоньку избавляется от диких CSS-костылей.


Do you want to push your commits to your own fork of this repo? I'll take a look at them, but I'm reluctant to merge things into this branch in case people get the impression that I'm working on it again.


Fair enough


TeamCity ChameleonForms :: Continuous Integration [Build 258](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3656&buildTypeId=bt20) is now running


That's because I don't know how to make rake variables. I don't think we should create an instance of this every time and I don't think that pass it through the functions is a good option


They are supposed to be read in context of the specification, which uses similar names for the functions; think of it as the "C" implementation, and the other one as "Assembler" implementation. If one day the javascript optimizer gets good enough, my manually inlined version may get obsolete.


Interfaces are always static, so there's no point in explicitly declaring them as such :wink:


 > m_upscale_multiplier = theApp.GetConfig("upscale_multiplier", 1)

> int GSdxApp::GetConfig(const char* entry, int value)
{
	return GetPrivateProfileInt(m_section.c_str(), entry, value, m_ini.c_str());
}

It will use 1, which is it's default value in case if it doesn't find the key name. https://msdn.microsoft.com/en-us/library/windows/desktop/ms724345%28v=vs.85%29.aspx


102966118-HeatRecoveryBypass-4568 (mjwitte) - x86_64-MacOS-10.9-clang: OK (1831 of 1834 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


Not needed if we use the vagrant user.


If you happen to like all this, thank @lunaryorn, not me. :-)


There is no need of variable isTokenUpToDate, we never use it later.
So we can check this

```
if (isTokenUpToDate(taskManager.accessToken)) return;
```


Or was it for the "Järfälla" in the tests?


Maybe but we are passing a user to make the operations where we have a "class" method for it. I don't see the benefits of pass the user in all the functions parameters.


It should be `ansible_ssh_user=vagrant`.


I didn't do a comprehensive review, but at a minimum, it doesn't talk about how to extend CheckerFrameworkTest to create a new test set.


Use `sudo: "yes"` in every role.


Weird, tests passed locally. Thanks for pointing this out.


Use `User vagrant`.


https://github.com/raj454raj/wheresmydialogue/issues/1 solved


This file is not needed if we are going to rely on `vagrant`.


Specifica secondo me è meglio.


I'm a little confused by this patch.  The TOKU_MUTEX_INITIALIZER is wrong, yet the patch seems to leave it in.


The `getLayoutInflater()` method is not really part of the public API of `Fragment`, even though it's exposed in the support library. Therefore, it would be best to get the `LayoutInflater` using the `LayoutInflater.from()` method.


why?


```
Problem Dimension                             BDR  Min. 1st Qu. Median  Mean 3rd Qu.  Max.
j.rnd     10x10          Shortest Processing Time 20.38   41.35  50.28 50.92   58.99 94.20
j.rnd     10x10               Most Work Remaining  3.37   17.48  21.52 21.89   25.98 47.78
j.rnd     10x10 SPT (first 10 %), MWR (last 90 %)  5.54   17.55  21.35 21.64   25.14 44.47
j.rnd     10x10 SPT (first 15 %), MWR (last 85 %)  4.76   17.82  21.76 22.16   25.98 49.86
j.rnd     10x10 SPT (first 40 %), MWR (last 60 %)  8.55   23.81  28.12 28.96   33.46 57.21
```


This could probably be done more generally within the `concat` function

```
if len(dfs) == 1:
    return dfs[0]

test_...
    assert pd.concat([df]) is df
```


Nice.  I like the plugin structure and the tests (and the mocking).  Not really sure if the package_id is always enough to determine the provider, but I like the simplicity of having it like this.


4385-CondenserLoop (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


example comment


4385-CondenserLoop (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (1840 of 1840 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Audio/Video ?


ok, thanks - that really helps

that is pretty much the same procedure I used in stepgen

 (workflow is fine. btw one can directly comment on a diff line by clicking on the '+' when hovering over the line numbers , see line 301)


I wasn't sure about that so I made them match what's on CMBHS right now.
On Sep 10, 2015 9:47 AM, "tim" <notifications@github.com> wrote:

> The CARE Decode table batch specs
> <http://www2.mhmr.state.tx.us/655/CIS/Training/files/decode.pdf> have the
> abl values as the following:
> ABL
>
>    - 0 Not Retarded
>    - 1 Mild
>    - 2 Moderate
>    - 3 Severe
>    - 4 Profound
>
> What do you think about making the radio labels match the decode specs?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/txace/icd10-sql/commit/09fc735d4c8f5823b6d3339aed1d01004b6e1858#commitcomment-13161675>
> .
>


rustfmt prefers the trailing comma IIRC.

> On Sep 10, 2015, at 12:05 PM, Antti Keränen <notifications@github.com> wrote:
>
> Well, this has to be the last match variant anyway so I would prefer no comma. Dunno what rustfmt thinks.
>
> —
> Reply to this email directly or view it on GitHub.
>


Maybe it means "Game Directory, Game Data" or something else?


Did mention it in the commit message, but wasn't sure. Would be nice if someone could confirm it on a real PS3 somehow.


@topherfangio Yeah, sorry for that. I forgot to mention you on the last one. I really hope I get to this one today, but since been a few weeks since I tested the last time with HEAD, I might hit other blockers overall before I can get to this one so...


What is the purpose of catch - re-throw exception?


Ok, the core achitecture is pretty complex and I followed here the standard implementation suggested in Angular documentation. But let's try make it better and go closer to a more dynamic approach. Here I try to pass an instance of HomeMediator using a factory to the controller. Looks better? Can I do the same with the services?


I was wondering about this already, thx :)


I'm going to merge this change, as changing from seconds to hours in the reporting is a good idea.

About using Bytes vs GB for memory, the initial idea was to have the original memory measurement be GB too (as configured there https://github.com/cloudfoundry-incubator/cf-abacus/blob/master/lib/config/resource/src/resources/container.js#L12) so we didn't need a conversion from Bytes to GB in the metering, but now that I'm looking at this again, it looks like CF (and most container services) reports memory usage in MB...

So if you guys are OK with that, at some point I think we should use MB instead to be consistent with the CF app usage events, and then convert these MB to GB in the reports. I can make that change later and also adjust the various test cases if that helps.

Thoughts?


It's not in `<head>`, it's in an HTML5 element called `<header>`.


@sipa is this correct?


I think the `this.getActivity()` can be replaced with just `getActivity()` here; there is no ambiguity to be resolved.


Well, not really, just made it that way.
Also, I guess most people would like sorting method to be alphabetic by default.


The same catch-rethrow exception here. It'd be more readable to use
```
String missions = EntityUtils.toString(response.getEntity());
```
here and handle exception later. So we can get rid of ```assert```


Ok.


调整链接


We'll let you know when we branch, but it will be "Release-1.4.0" when we do.


Since all packages are updated in their own thread, do we know what happens if we call Plugin.say() on two different threads on the same time?


maybe `assert int(output['filesize']) > 0` ?


Too bad, I liked that one :)


TeamCity ChameleonForms :: Continuous Integration [Build 2.0.0-PullRequest91+026](http://ci.robdmoore.id.au:8010/viewLog.html?buildId=3656&buildTypeId=bt20) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 3007 Build time: 0:0:0
### Failed tests
```
ChameleonForms.AcceptanceTests.dll: ChameleonForms.AcceptanceTests.ModelBinding.ModelBindingShould.Function_correctly_with_checkbox_and_radio_lists: Test(s) failed. TestStack.Seleno.Configuration.Interceptors.SelenoReceivedException : {"errorMessage":"Unable to find element with link text 'Model Binding Example with lists'","request":{"headers":{"Accept":"application/json, image/png","Connection":"Close","Content-Length":"64","Content-Type":"application/json;charset=utf-8","Host":"localhost:62598"},"httpVersion":"1.1","method":"POST","post":"{\"using\":\"link text\",\"value\":\"Model Binding Example with lists\"}","url":"/element","urlParsed":{"anchor":"","query":"","file":"element","directory":"/","path":"/element","relative":"/element","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/element","queryKey":{},"chunks":["element"]},"urlOriginal":"/session/ac763a90-57d8-11e5-94bd-2fd13b0b4e44/element"}}
  ----> OpenQA.Selenium.NoSuchElementException : {"errorMessage":"Unable to find element with link text 'Model Binding Example with lists'","request":{"headers":{"Accept":"application/json, image/png","Connection":"Close","Content-Length":"64","Content-Type":"application/json;charset=utf-8","Host":"localhost:62598"},"httpVersion":"1.1","method":"POST","post":"{\"using\":\"link text\",\"value\":\"Model Binding Example with lists\"}","url":"/element","urlParsed":{"anchor":"","query":"","file":"element","directory":"/","path":"/element","relative":"/element","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/element","queryKey":{},"chunks":["element"]},"urlOriginal":"/session/ac763a90-57d8-11e5-94bd-2fd13b0b4e44/element"}}
   at TestStack.Seleno.Configuration.Interceptors.CameraProxyInterceptor.Intercept(IInvocation invocation) in c:\ConsoleBuildAgent\work\f035b8dd08e41a61\src\TestStack.Seleno\Configuration\Interceptors\CameraProxyInterceptor.cs:line 52

ChameleonForms.AcceptanceTests.dll: ChameleonForms.AcceptanceTests.ModelBinding.ModelBindingShould.Function_correctly_with_default_form: Test(s) failed. TestStack.Seleno.Configuration.Interceptors.SelenoReceivedException : {"errorMessage":"Unable to find element with link text 'Model Binding Example'","request":{"headers":{"Accept":"application/json, image/png","Connection":"Close","Content-Length":"53","Content-Type":"application/json;charset=utf-8","Host":"localhost:62598"},"httpVersion":"1.1","method":"POST","post":"{\"using\":\"link text\",\"value\":\"Model Binding Example\"}","url":"/element","urlParsed":{"anchor":"","query":"","file":"element","directory":"/","path":"/element","relative":"/element","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/element","queryKey":{},"chunks":["element"]},"urlOriginal":"/session/ac763a90-57d8-11e5-94bd-2fd13b0b4e44/element"}}
  ----> OpenQA.Selenium.NoSuchElementException : {"errorMessage":"Unable to find element with link text 'Model Binding Example'","request":{"headers":{"Accept":"application/json, image/png","Connection":"Close","Content-Length":"53","Content-Type":"application/json;charset=utf-8","Host":"localhost:62598"},"httpVersion":"1.1","method":"POST","post":"{\"using\":\"link text\",\"value\":\"Model Binding Example\"}","url":"/element","urlParsed":{"anchor":"","query":"","file":"element","directory":"/","path":"/element","relative":"/element","port":"","host":"","password":"","user":"","userInfo":"","authority":"","protocol":"","source":"/element","queryKey":{},"chunks":["element"]},"urlOriginal":"/session/ac763a90-57d8-11e5-94bd-2fd13b0b4e44/element"}}
   at TestStack.Seleno.Configuration.Interceptors.CameraProxyInterceptor.Intercept(IInvocation invocation) in c:\ConsoleBuildAgent\work\f035b8dd08e41a61\src\TestStack.Seleno\Configuration\Interceptors\CameraProxyInterceptor.cs:line 52

```


very good!


why did you remove uuid? its used on line 33.


Я вот думаю, может все кнопки перерисовать в векторе? Например запихнуть их все в единый `svg`, а для обращения к отдельным элементам использовать `id` спрайта. [Опера 12.1 имеет поддержку](http://caniuse.com/svg-fragment) фрагментированных SVG, так что должно работать везде.

Преимущества: чёткие изображения на всех дисплеях, их можно вставлять при помощи `<img src="<blob-url>#hide-button">`. Ну и текстовой формат подразумевает лёгкое редактирование.

У тебя есть векторные исходники кнопок скрипта?


**valid-jsdoc**: Missing JSDoc @returns for function.


**no-var**: Unexpected var, use let or const instead.


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _handleClearRequests


**no-unused-vars**: messageId is defined but never used


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _handleRequestsUpdate


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _getStateFromStore


**yoda**: Expected literal to be on the left side of <.


**no-multi-spaces**: Multiple spaces found before '='.


**space-infix-ops**: Infix operators must be spaced.


cool!

I'm still stumped by not being able to get that pwm_init working in the mean time :)


odd, caf has it after on their latest branch: https://www.codeaurora.org/cgit/quic/la/kernel/msm/tree/sound/soc/msm/qdsp6v2/msm-compress-q6-v2.c?h=LA.BF.1.1.1_rb1.26#n630

but we have it twice. i've removed the first one to match caf: http://review.cyanogenmod.org/#/c/109105/


a


There is no need to split declaration and assignment of ```discussionPanel```


Your comment needs to be specific.  Don't put a blanket warning at the top of the file saying it's all out of date when most of it is actually correct.  That is sloppy and makes the documentation more confusing and less helpful -- even though your goal was to make it better.


Lunghezza di codifica, wot?


lol - I should have known that CARE and CMBHS wouldn't match.

So I guess it makes most sense to leave with the CMBHS values since that is more outward facing than the batch specs.

for the record labels like this drive me a little nuts: value = 1; label = 0 - Mild


why `expect` instead of `allow`? b/c we are testing that their file calls `gets`?


I just decided to check out, and maybe I was right!
I just opened "PARAM.SFO" and i saw it.

http://puu.sh/k6yKU/f4674d4521.png
http://puu.sh/k6yLH/8f4697c315.png

(Yeah, DG is Disc Game, maybe...i'm right?)


I think we should enable it. My main computer has a bug where after a fresh boot the vsync doesn't work until you go into the settings, change the OpenGL version, then change it back. It's a tedious process but I have actually gotten used to doing it because the splitting bothers me so much.


**valid-jsdoc**: Missing JSDoc @returns for function.


**no-var**: Unexpected var, use let or const instead.


If we are making the type for this more generic, then the `new_course_content` type should also be changed to be `View`. Similarly, the `facePileContainer` type can be changed from `LinearLayout` (which is implementation-specific) to `ViewGroup` (as we have defined it as a container).


スキル候補修正＠風林火山　極


@fenix008 Yep, you're right. Will force-push once I have also fixed license areas.


Can we rename this field to be "hostname"?


@Scytheria

tools development is one of the most important reason of this backports since, as @Aokromes said, it is easier to develop tools if all branches database schema are as similar as possible.

I'm working on several tools for TrinityCore too, and now I'm going to update them according to these changes.

By the way, @Scytheria  what tools are you working on?


Rispetto rispetto.


:ok:


when do we need to call `run_file`?


Do these leading hashes not change ever?


:ok: :1234:


frc *


How should these two be written?  I don't want to expose compressed variables in `sjcl.hash`.


Hmm, afaics this would mean after discovering the files already we'd forget where we found them, and then let unit_file_get_state() search for them again, no? This sounds redundant?

There might be more code to share here, but I have the suspicion this would make things needlessly slow, no?


Fixed in 2cc8680b88f1198fd4ea471572d450d2f2e377fb.


In case the link above doesn't work (log was not shown for me this morning, I've run the build again), here is a raw version: https://api.travis-ci.org/jobs/75983413/log.txt?deansi=true


I don't think the order has any functionality to it but I saw it was put twice, I made that pull request, which I guess can be deleted. But it's fixed now. Sorry if I came off blunt!


I agree with Mike, make the comment concrete.
There is a section on "Writing tests for a new checker or with different command-line arguments" which gives details on how to do this. It doesn't give the concrete code, but references an example to use.


This line change addresses #44


To be switched to the latest released version.


let's add a small unit test for this one


4385-CondenserLoop (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1840 of 1840 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Adding update right now in #9.


**no-unused-vars**: messageId is defined but never used


**valid-jsdoc**: Missing JSDoc @returns for function.


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _getStateFromStore


**space-infix-ops**: Infix operators must be spaced.


**no-var**: Unexpected var, use let or const instead.


**no-multi-spaces**: Multiple spaces found before '='.


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _handleClearRequests


**yoda**: Expected literal to be on the left side of <.


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _handleRequestsUpdate


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 50](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=162&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


this file is pretty well unit tested, can you add some coverage of the element support + click and touchcancel support?


@scambra HI, I tried to build the gem with your latest commit but failed. I had to update Gemfile and was able to build it. But did not manage to run the specs. Are you able to run the specs?


No lol. You seem to be a demon :3 XD
Joking :p


I couldn't find out why that was needed, but it broke the textile previewing in edit mode


good eye, fixed


Look like i can do some coments like this


The mouse performs better with it disabled. It is hard for me to tell, but
I'm pretty sure.

Hugh

On Thu, Sep 10, 2015 at 10:34 AM, Colton DRG <notifications@github.com>
wrote:

> I think we should enable it. My main computer has a bug where after a
> fresh boot the vsync doesn't work until you go into the settings, change
> the OpenGL version, then change it back. It's a tedious process but I have
> actually gotten used to doing it because the splitting bothers me so much.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GalliumOS/galliumos-base/commit/041a0f9fae3e7bd81a250bad614dcf214d863ebb#commitcomment-13164132>
> .
>


I'm not sure if your intent here is to privatize this method, but if you ever wanted to override it in a subclass and be able to call super you'd be SOL.


looks really good

________________________________
From: Jorge Solis <notifications@github.com>
Sent: Thursday, September 10, 2015 9:27 AM
To: SiliconPublishing/HTML5CandidateTest
Cc: Dorian Smiley
Subject: Re: [HTML5CandidateTest] Version of the RESTapi using Angular for client side (b83face)

Ok, the core achitecture is pretty complex and I followed here the standard implementation suggested in Angular documentation. But let's try make it better and go closer to a more dynamic approach. Here I try to pass an instance of HomeMediator using a factory to the controller. Looks better? Can I do the same with the services?

-
Reply to this email directly or view it on GitHub<https://github.com/SiliconPublishing/HTML5CandidateTest/commit/b83face934bb387fa4b333d3337e883b0fc78d51#commitcomment-13163996>.


What is the change at line 1497 of xspress3Epics.cpp for? It will break the status check if there is an error.
Why have you duplicated the loop that sets the scalar PVs?


And I'm pretty sure I saw it disabled in ChromeOS

Hugh

On Thu, Sep 10, 2015 at 10:46 AM, Hugh Greenberg <hugegreenbug@gmail.com>
wrote:

> The mouse performs better with it disabled. It is hard for me to tell, but
> I'm pretty sure.
>
> Hugh
>
> On Thu, Sep 10, 2015 at 10:34 AM, Colton DRG <notifications@github.com>
> wrote:
>
>> I think we should enable it. My main computer has a bug where after a
>> fresh boot the vsync doesn't work until you go into the settings, change
>> the OpenGL version, then change it back. It's a tedious process but I have
>> actually gotten used to doing it because the splitting bothers me so much.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/GalliumOS/galliumos-base/commit/041a0f9fae3e7bd81a250bad614dcf214d863ebb#commitcomment-13164132>
>> .
>>
>
>


Tienes razón, creo que no debería de hacer caché. Lo que yo quería era brindar la posibilidad de asignar un valor a "total" y no calcular siempre. Por ejemplo, al leer de un archivo xml, me interesa que el total sea el que dice en el archivo, no el que se calcula. En ocasiones el cálculo coincide pero no siempre, sobre todo si se tienen retenciones y traslados o si la tasa cambia para algunos impuestos.

Voy a cambiar el método para que no haga caché y simplemente devuelva el valor, si lo tiene, o el cálculo, si es que no se ha asignado el valor. Lo incluyo en el siguiente PR.


I would look at this also, since would it make more sense if ave cost (quants on hand) not all. I cheated with this:  # quants should be in WH/STOCK or same move location - was adding in all locations?
                domain_quant = [
                    ('product_id', 'in',
                     product.product_tmpl_id.product_variant_ids.ids),
                    ('id', 'not in', move.quant_ids.ids),('location_id.id', '=', move.location_dest_id.id) ]


Can we add a note that this has power and CPU implications?


Hi,

I don't understand where is the problem before ? What change is made here ?

Tested with
````
<strong>Test</strong><p>
A long string here
</p>
<script>console.log("toto");</script>
````

Same result  (and viewHelper::flatEllipsizeText can be fixed)

Seems to have a bug https://bugs.limesurvey.org/view.php?id=9870 with remote control.


Note: The associated screen shot will need updating also, once someone has a build of this running.


Well the BrowserQuest server runs on port 8000, and if I connect to 93.186.75.74 on port 8000 then I end up on something other than BrowserQuest which is the reason why the client can't connect to 93.186.75.74 on port 8000. You'll need to either shut down what's on port 8000 on 93.186.75.74, and then have BrowserQuest server be available on that port instead. Once you do that, the client should work to connect to it. The other option is to change the port that the BrowserQuest server runs at (you can find the config files for that in the server directory), and then change the client to use that port as well instead.


Thank You


Your menu choices are very clever! I also liked your use of the the choiceCounter variable.


Why not use `vo-defaults` so you can combine debanding with the smooth profile for instance.


That works.  I guess the absolute paths aren't that big a deal since it's unlikely we will add anything that uses autoconf to core hb.


Really? Well, if I ever manage to get it installed I'll mess around with it a bit.


don't need to hard-code, since the generator knows how to name these


yes ok oscam-emu-pvu-aud-sub-tracks-inc-10980.patch


u know i luv u guyz :p


Is dump file suppose to be opened or I'm doing something wrong? When I try to open it I get dumped.exe is not a valid win32 application.


Yes, I know it is strange. Yeah, please confirm that I'm not crazy.

Hugh

On Thu, Sep 10, 2015 at 10:50 AM, Colton DRG <notifications@github.com>
wrote:

> Really? Well, if I ever manage to get it installed I'll mess around with
> it a bit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GalliumOS/galliumos-base/commit/041a0f9fae3e7bd81a250bad614dcf214d863ebb#commitcomment-13164457>
> .
>


!fix node_mods is the correct path


Thanks for the comments.  I'll go over these (merging in your case fixes and re-running the tests), and leave clean those other commits.


Please change <username> to "fedora".  That way it is tagged properly and the other images can build off this base image.


We do not need this check. ```checkCancelled``` should be performed prior to some action, not afterwards


@vcunat: As for the `lib` output, this is for `.dso` files that are required at runtime other than the `$out/lib` directory that's needed for compiling against `hxcpp`.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1315 of 1315 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Yo alex
Yo the teacher
Teach yeshwant all this shit lol


I did talk to someone on #xorg-dev and he told me that vsync can make a
difference for mouse driver acceleration algorithms.

Hugh

On Thu, Sep 10, 2015 at 10:51 AM, Hugh Greenberg <hugegreenbug@gmail.com>
wrote:

> Yes, I know it is strange. Yeah, please confirm that I'm not crazy.
>
> Hugh
>
> On Thu, Sep 10, 2015 at 10:50 AM, Colton DRG <notifications@github.com>
> wrote:
>
>> Really? Well, if I ever manage to get it installed I'll mess around with
>> it a bit.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/GalliumOS/galliumos-base/commit/041a0f9fae3e7bd81a250bad614dcf214d863ebb#commitcomment-13164457>
>> .
>>
>
>


Please change \<username\> to "fedora", that way it's tagged properly and the kubelet can build off this.


This `if`clause without braces is **not** compliant with HHVM's coding style. See [Statement](https://github.com/facebook/hhvm/blob/master/hphp/doc/coding-conventions.md#statements) and fix.


Are we using this only for the rocketbar launch?
If yes can we do it a less elegant way where we're not causing a reflow for each click on this element?
Maybe a poor-man hit testing based on window.innerWidth + the statusbar height then a querySelector to get the correct app statusbar element.

If no, I guess it's not that big of a deal :)


Why not use a `li` directly for `i.s.b()`?


OK


Да, просто закидываешь ее в нужную директорию. Но это только для списков картинок учеников.


:+1: Is Alan making good on that promise to enforce source control on these projects?


4385-CondenserLoop (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (1840 of 1840 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Since we support suspend/resume on offline contexts, this sentence needs to be removed.


When you use a compositor for vsync, I don't think it actually composites the mouse pointer, so that shouldn't be a problem if we use a compositor.


Not big deal. I just prefer not to blindly apply `deband` filter to any video I want to watch. It's mostly personal preference.

Also see my comments under https://github.com/mpv-player/mpv/commit/97363e176d180f4f1bbc1e67e3e513c493ce31ed


Yeah, we are. Compton is setup for vsync.

Hugh

On Thu, Sep 10, 2015 at 10:55 AM, Colton DRG <notifications@github.com>
wrote:

> When you use a compositor for vsync, I don't think it actually composites
> the mouse pointer, so that shouldn't be a problem if we use a compositor.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/GalliumOS/galliumos-base/commit/041a0f9fae3e7bd81a250bad614dcf214d863ebb#commitcomment-13164562>
> .
>


This is for issue #168


Yeah, this should have been `--dryrun`. Thanks for catching this Xu.


Is "Rocket.Chat" from a copy paste?


let's pair and see if we can eliminate the need for this file. it's extra complex that there's one magic file with types that are exposed to users but not used anywhere in angular's compile


For me, it is not some times, but all the time! :)


avoid https://github.com/jenkinsci/docker-jnlp-slave, I prefer to get slave.jar from jenkins master and avoid passing secret


Considero que se debe tener una posibilidad para que el valor se asigne desde afuera y no siempre se calcule. Por ejemplo, cuando se lee de xml, el total y subtotal deben ser los del xml, no los calculados.

Una opción rápida podría ser:

```ruby
def subTotal
  @sub_total ||calcula_sub_total
end
```

Así, si ya se asignó desde afuera, se regresa el valor asignado, en caso contrario, regresa siempre el valor calculado, sin hacer caché. ¿Cómo ves?


Creo que borraste de más, porque es una asignación. Creo que por esto están fallando las pruebas.


"Odoo lint checks are still in beta: they won't affect your build status for now."


I dont think this is needed since you usually pass authentication in redisOptions...


yes ok oscam-emu-pvu-aud-sub-tracks-inc-10980.patch

 Latest oscam-emu patch for oscam (10980)

    My latest patch.

    Includes:
    Increase powervu stream relay total combined audio and subtitle tracks to 16 (limit was 4 previously.)

    Plus:
    a few possible resource leak/memory leak fixes (thanks to tanaseiv)
    some compiler warning fixes
    adjustments for clean patching of latest oscam (10980)

http://linuxsat-support.com/showthread.php?t=91620


Okay, I'll remove the top text and add a cross-reference in the "Writing tests for a new checker" section.


this is not that obvious, right?


You know, git has an --amend option. You should use it to avoid commits fixing code from the previous commit.


Good idea. Can be more graphic that way too. Splash some blood around.

I'll make that change on the next PR.


:sob:


have a feeling i'll be putting lots of dollars in lots of jars


There is no reason to store project and task as fields. Action usually gets everything from it's context.


unsigned


pretty much. did he not with you guys?
On Sep 10, 2015 12:54 PM, "Sean Allred" <notifications@github.com> wrote:

> [image: :+1:] Is Alan making good on that promise to enforce source
> control on these projects?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/awhittington/GDD/commit/e9d907e79387006ce9466edac27b1995bb3f91ee#commitcomment-13164536>
> .
>


Add ` if pr_errors:` before the print statement?


r+


102966118-HeatRecoveryBypass-4568 (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1837 of 1840 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


Oh no worries, I appreciate it. Didn't realize you had a pull request (I can't actually merge those though, it all has to go through gerrit)


sorry about the confusion. This should be `bike_sharing_indego_phl` and above you should have `Spice.failed("bike_sharing_indego_phl")`.


Thank you for request. We know about this, but its absolutely not critical... This function from original skin, but we make to big work with refactoring current code.


http://uibuzz.com/2015/apple-swift/alert-panel-with-text/

http://rshankar.com/uigesturerecognizer-in-swift/

http://www.raywenderlich.com/76020/using-uigesturerecognizer-with-swift-tutorial


ok we gonna stop spamming boss's mail else he will kill us lol


@lisachenko entity inheritance is a performance killer in Doctrine and should be avoided. thus, if you have only 1 child entity, there is no point using inheritance


Nit: Do we need this isBool check if asBool is an optional and will return false if it's not a Bool anyways?


See https://github.com/Fyrd/caniuse/issues/1822#issuecomment-132830797 - @dstorey from the Edge team has confirmed they're going to update the "12" going forward. I've already seen `Edge/13.10532` in the wild. Also it's much more readable and friendly than the build number.


good


Yep! Thanks for noticing!


btw, this codebase is the Packagist code base, which is not meant to be reused for anything else than Packagist.


I tried to leave your source as unchanged as possible, jshint had other ideas.


Nit: Same note as above


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/bc88f9232d13eb99eea2013eee0e177307c1a62c


merging MonsieurNicolas/stellar-core/libUpgrades = bc88f923 into auto


MonsieurNicolas/stellar-core/libUpgrades = bc88f923 merged ok, testing candidate = 225f12e5


:smiley:


Should we backport this?


Should StereoPannerNode be added here?  It's not 3D, but relevant to panning.


It's already boxed so leave it.

final Map <Enchantment,Integer> enchants= is.getItemMeta().getEnchants();
Integer level = enchants.get(Enchantment.LOOT_BONUS_BLOCKS);
if (level != null) {


As something nice to have, remember to check about video support (some formats are not supported and we can implement fallbacks). There's further info [here](http://diveintohtml5.info/video.html).


nope, it isn't :)
how does it look like with only a single output?


Hum, maybe, what if you set 0 in the ini file? Maybe it is useless but it is surely safer this way. An extra check doesn't hurt.


Нет. Все рисовалось в пеинте.


SpatialListener, right?


parabellum


Nit: I don't think you need these breaks because by default switch is not fallthrough unless explicitly mentioned like it is above


yes


That's done now. The fork can be found here.

https://github.com/bsdz/terminado/


4385-CondenserLoop (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (776 of 776 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-18.9%25-green.svg)


Let's remove the mock sample underneath


Good job on the first commit!!!!


We need to move this button a bit


Varias pruebas se rompieron. Voy a tratar de corregir y hago otro PR, con el cambio de enfoque en el caché, como te sugería.


Oh, I see this was intentional. Reverting.


@ivermac you could try this 1-line patch for the styling issue #310 (without upgrading the rest of enketo express at least until #313 is fixed)


oh, so does that mean that things loaded on localhost:7777 can never access 7778?
do we really need the file system to be accessable? could we get by with just the blob store?


https://github.com/chunying/ais3_final_2015/blob/master/gagb/gagb.py#L10-L17
```
def genall():
    return [ "%.4d" % i for i in range(10000) ]
```
would be better and more efficient :smile:


Должно быть
```javascript
} else if (settings.secondUrl && settings.secondUrl != '') {
```


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/79697744


I'd perhaps specify which command actually failed, like `"rpm -qa --qf: exit code %s"`


The advantage of JSDoc is, you can use templates and define how it shall look like. If we are lucky, maybe we will find a template which exports wiki syntax. On the other it should hopefully not be such a big task to change an existing one.


@greatislander glad you figured this out ... it was driving me crazy on our install! i thought maybe a Chrome extension of mine was causing it, didn't think about possibility of a Chrome update causing it


This is really not reliable, because we will forget to update it, and even if we do, people will not update their local.sh's when they upgrade to a newer version.

Instead, how about we have `server_package.sh` and `server_deploy.sh` write a new line into `settings.sh` with the version, since it knows the version from grepping `version.sbt`?

Also, we should factor the common code in `server_deploy.sh` and `server_package.sh` into a common shell script.


@Ninikitos DWMR. :+1:


Thanks @marshall-lee. Aside of the wiki page, can we (by we I mean @martinstreicher :) help document what this means in UPGRADING? I am not sure what it looks like but the words in there should have explained this change in a way where you, @martinstreicher would have understood what's going on without us having to discuss it. Just to help the next person!


Is this safe to explicitly unwrap the array and string? I think you're missing a childrenAreValid check here.


All credit goes to @connerbw.


These variables should probably be bound with `let`


It was a bit outdated :)


Same, can leave it boxed.


Is this ``id`` meant to be used? If not, you can remove it. We try (as a good practice) to not use IDs unless it's necessary.


do we need to import the .SRCINFO ? AFAIK this is auto generated


Nit: can we name it "NewTab:UpdatePages" just for consistency? :)


haha


ditto


> Hum, maybe, what if you set 0 in the ini file?

In this scenario, , m_upscale_multiplier will be 0. that check would be useful at these scenarios, agreed :+1:


@jenrana DWMR. :+1:


Yes.  When the null check is removed, opening the editor crashes hard, at least on Windows.  I looked at all the data, and while there is probably a bug underneath it all, p really is null, at least according to the debugger.

We should probably flag this as a bug for further followup; either confirm it is working properly, or fix it so the null check can be removed (or, perhaps better, converted to an assert).


the rpm spec has a more descriptive text for pkgdesc, I think we should copy that due a consistence matter


This is >10x faster because of the expensive catch.


Looks like HOCON was smart enough to parse it.


I'm not sure this *file* is used (or has ever been used). To my knowledge, there is no way of giving a score to the actions done in the dropbox... :-)


Lookup what priority Citadel hooks at and make the priority higher then Citadel. This modifies the environment directly instead of updating the event so we need to give Citadel a chance to cancel beforehand.


We'll need to update the calls in the file below too.


what about using pkgver=master ? or head? I think it doesn't make much sense to have this pkgver, but I haven't consulted the common practice for that.


That actually _is_ a single output, just one Network Sink. But, here is with internal device: http://sprunge.us/GUce


does it make sense to have pkgrel for a git package?


why?


I would go with arch=('i686' 'x86_64')


This is a very nice change, the implemented interfaces were really hard to read before this change.


is depends mandatory?


Weren't the keys in the test just being created as `google.cloudSQL.regions.toComputeRegionus-central`? Was the actual config file able to be parsed correctly?


Maybe safety check the material matches for these subsequent item stacks?


The line `$('.codecov:not(.btn)').remove()` caused an issue with clicking Back button then Forward button in Firefox. Changed the method to only remove safe content.


parse_line_into_words fixes #1


whoops, this was supposed to be pushed to to a branch...Git let me down...


creation de la fonction d'interpretation, de traduction et de recherche de fonction


Shall we torment them with alphabetic order? :P


Due to the length of this raise error it seems like we should instead use it inside of an `if` statement instead of a trailing if


Cancel as soon as you know that the event should be cancelled. Defense against an unforseen exception causing a dup bug.


Ooops. Sorry. Fixed in 6aaf55c.


from now on, troll comments moved here, the mechanism still under testing for multiple trolls such as the thing on Legacy theme lol.

move this as troll.json is not a problem though :sweat_smile:

ps: there's no need to complete all the term like english one, only to replace some terms to make it funnier. don't make the joke is overused or too dull. 'w')b


Yeah, it sounds like a bug somewhere else.  Removing the branch here is also probably a relative performance improvement because `Rect` is called a lot (I think)


Fixed. Using `li` with `(i.s.l() & UINT8_MAX)` to avoid do another cast back to uint16_t.


Fixed.


_.merge is a destructive operation, so in this case the assignment was unnecessary (though it does tend to make it clearer).


in a general sense the patch looks good but I would also do something to generate both the ```soletta``` and ```soletta-git``` from a common descriptor and merging only the differences, a ```gen-archlinux.sh``` to do ```cat common_desc >> soletta-git/PKGBUILD && cat git_spec >> soletta-git/PKGBUILD``` would be enough. What do you think? we don't even need to commit the PKGBUILD itself, just the script and descriptors and have it noted in the Readme file.


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 50](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=162&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:40:20


La herencia suena a muy buena idea aquí, pero  por el uso de la variable `@cadenaOrignal` a nilvel de clase, no es posible hacerla correctamente porque en `Comun#to_h` no encuentra los valores de `@cadenaOriginal`.


ok, we don't need to keep this files history now since we're first integrating it over, so we can squash it into a single commit. But it's fine for a review purpose :)


TOKU_MUTEX_INITIALIZER is wrong, it must be ZERO_MUTEX_INITIALIZER.  You aren't going to easily get this codebase to run with -Wmissing-field-initializers, but if you want to try, you've got to fix up ZERO_MUTEX_INITIALIZER.  It is wrong to use TOKU_MUTEX_INITIALIZER because it's initializing the underlying ptherad lock with PTHREAD_MUTEX_INITIALIZER, and then we invoke pthread_mutex_init(), double initializing it.  Furthermore it's wrong since you cannot use PTHREAD_MUTEX_INITIALIZER on a non-static variable.  In this case, it's an auto variable (on the stack, with function scope).


It's not needed. If you try running the pr you will see.


Indeed, it is autogenerated. It is required to commit & push it into the new git-based AUR, but we do not need to control versions of it in Soletta's packaging repo.


Did you try using just ``header`` and ``footer`` without a child selector (``>``)?


Did you try not using a child (``>``) selector and see if it works?


Which is?


Minor -- it's NuGet.Config (note capitalization). Will be important on Lunux:anguished:


Is this new blank line intentional?


It is automatically done.