We decided on Friday that we should remove the plugin from OJS for now. Generally speaking I'd like to move plugins into their own repos, optionally with submodule registration in OJS for the sake of testing and package building.


in my opinion, seems like more work and extra promises than is worth offering.


updated to throw IOE
```
if (multipleOutputs == null) {
  throw new IOException("MultipleOutputs has not been initialized.");
}
```


Nice


i wouldnt have clue how to compile, if it was simple as edting a line in  ini i could do


Want to share the error?


dfdf


it was added as a part of stick cal, and removed after the disagreement


learning to use git


@kbenne Will this make it so any object that is translated will have it converted to "Temperature"? Basically, shouldn't you be checking if the field is empty and if so then making it "Temperature"? Or maybe I am missing something about how version translation works.


Yes but we should encourage the use of stats separate from the article
level metric service.
On Aug 31, 2015 5:00 PM, "Alec Smecher" <notifications@github.com> wrote:

> We decided on Friday that we should remove the plugin from OJS for now.
> Generally speaking I'd like to move plugins into their own repos,
> optionally with submodule registration in OJS for the sake of testing and
> package building.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pkp/ALM/commit/f3bbd133861a974b29b5c5d49e965465e20e06c1#commitcomment-12988017>
> .
>


Can one change the layout of the menu.


Hmm, I'm confused about what we decided. @jmacgreg, do you have a sense of what our hosted journals in particular are using?


Unhandled Fundamental Failure


yeah this is useless code I'll get rid of it


agreed


Shouldn't we generate a nice warning here?


@Fadi5555 Hello! It's pretty much useless to try to install this, because it will just crash when you try to anything. (and it's also currently hardcoded to run a specific homebrew file called "starfield.dol") I've pretty much lost interest in continuing to work on this port because of problems related to how iOS handles memory and other problems related to Dolphin's memory layout and fastmem design. The recent changes were just some minor clean up of the files because someone is interested in helping out.

Sorry to disappoint, but hopefully progress will be made and Dolphin will be able to run on iOS in the future.


Actually, my first thought was to use a for loop after prompting for the word. Then I remembered we hadn't gotten to loops yet in this class (just read about them in PHP/SQL class). So I backed it up to what was in the chapter. :-)

I'll save all output to the end.

I got to these comments following a link in the email. How do I get here in Github after I login? In other words, where the heck am I?


Uh... Didn't I address just that right [above](https://unmethours.com/question/10810/openstudio-merged-surfaces-inside-a-thermal-zone-to-internalmass/). Entirely possible I have made a mistake.


바꿨습니다. placeholder 좋네요~


Ok, this seems to be more correct.


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


아니에요 '이렇게 하면' 이 뭔지도 잘 모르겠어요ㅜ


Does this contain all the values in the app in terms of widths, heights, margins, padding ?


87382760-VAVTerminalUnitSchedule-Issue4285 (mjwitte) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


87382760-VAVTerminalUnitSchedule-Issue4285 (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


os.Exit(fetchCheats(url, c.String("dir"), c.Bool("verbose")))


ioutil.TempDir("", "cheat")


use filepath instead of path


double close. if you want to return err of d.Close(), remove defer like above. Or not, return nil here.


91958608DOASEffectOnZoneSizing (wfbuhl) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@nerdondon how is this possible?


Unhandled Fundamental Failure


ah, I see, you didn't pull.


TeamCity pull requests :: netty [Build 160](https://garage.netty.io/teamcity/viewLog.html?buildId=1029&buildTypeId=pulls_netty&guest=1) is now running


91977808_LBNL_NewVRFModel (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


merge pull


The short answer is that changing the design of the `ReadView` infrastructure is far beyond the scope of this PR.

A longer answer is that we need a pointer (or reference) to this polymorphic base class so that when we call the virtuals on it, they behave correctly.


You are looking at a specific commit on your repo I get here by clicking on the link for the last commit on your branch but when we get to doing PRs you will be able to get to these easily by looking at the pull request.
![screen shot 2015-08-31 at 20 14 13 pm](https://cloud.githubusercontent.com/assets/159591/9593473/e45bde38-501c-11e5-9d1a-eeb11f25d7e8.png)

You will notice the little conversation bubble next to the commit we are on


Corrigir nome do autor no git config.


Yes and no.  I looked into it, and failed to improve it.  This is no longer an open issue.


91977808_LBNL_NewVRFModel (rongpengzhang) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


If we have enough tests to provide complete coverage, I guarantee you we would worry about how long the tests were taking to run. ;-)


93651760-RowPerObjectReport (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Answered.


Ah ha! Found it! Thank you!


Seems like there's a possible race condition here?  Could be that a borrower is able to pull an instance out of the `live_queue` after the `size()` is computed, so we might end up blocking on the `takeLast` call forever because that borrower will end up putting the instance back into the `locked_queue` rather than the `live_queue`.  Would it be better to do `pollLast() != null` in the loop, round-tripping a non-null return into a `locked_queue.putFirst()` call?


@cehallen DWMR (done with my review). `return ICE-ICE-BABY` :+1:


mutating the [[Prototype]] of an object will cause your code to run very slowly; instead create the object with the correct initial [[Prototype]] value using Object.create


to this point of optimisation, you should cache the result of the first `_item` in a local variable


The only piece of advice I will leave you about this repo is you should try and only include the src files and not the whole project. But that is just something to keep in mind. I look at this as a starting point so we can all get on the same level fast


here also, cache `_bytelen` in a local variable


fixes #110


could use default args here e.g. `elastic(bounciness = 0)`


side effect of your `sed`: `new__bytelen`, with 2 underscores


Did you seriously just check in a file named \ ? Wow. That is awesome. And kind of scary.


TeamCity ReOpenLDAP :: devel-2.4 [Build 185](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=261&buildTypeId=ReOpenLDAP_Devel24&guest=1) is now running


you should cache `_last_byte` as you no not want a new access each step


double underscore


cache attr access in local varibles


Yes indeed! For some reason I thought STRV_FOREACH would make it more readable but now that I reworked I see it's about the same...


yes, it works. Updated


var nit = oit


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-70.93%25-red.svg)


93651760-RowPerObjectReport (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


1. ZStack可以部署在一台独立的Linux机器上，也...
2. 另外最好做一个 全局替换，Zstack -> ZStack。 发现有个别的地方用的是Zstack。


Ok, just the .java file and email you the link to my repo that it's in.


I know, what am saying is that retired items are not getting the strike-through on devtest02 or 01 because in your commits you are putting the class on rows instead of columns e.g. as seen [here](https://github.com/openmrs/openmrs-module-adminui/blob/master/omod/src/main/webapp/pages/metadata/patients/patientidentifiertypes/templates/list.gsp#L14), can you fix all the list.gsp pages you have added? Because they are all broken


“编制”可以不要。


101884090--NewVenting-Availability-Schedule (lgu1234) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We will cover the pattern for the rest of the semester on wednesday

On Mon, Aug 31, 2015 at 8:24 PM, Sharon R. Tinkey <notifications@github.com>
wrote:

> Ok, just the .java file and email you the link to my repo that it's in.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/srtinkey/A1-ValueofaWord/commit/4ad8bff83cc812996fbe1a69a0d82e90e0b91612#commitcomment-12988256>
> .
>


Unhandled Fundamental Failure


“Python代理程序（Agent）”
python的p要大写，另外对于可能产生模糊理解的词，可以加一个英文的注释


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I'm able to manually set nativeDialogs=true or false on both my windows, arch linux, and ubuntu 15.04 machine, and I can see the reflection in the display of the file dialogs.  I think should revert this commit.  Apparently PR #240 says "native dialogs cannot be displayed on unix due to qtfiledialog api limitations" but I'm not sure that is true currently, but I can't really find any information online backing up either case.


RoomAirflowNetwork (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


test


File should not be over commented. Code should explain most of the stuff.
In the case of import statements, if you think about it, they don't need line comments.

__Following comment is redundant:__
```python
import socket               # Import socket module
```
You can explain in your __doc__ about the usages of certain packages which you import though if you want.
Like following line of code is self-explanatory and does not require comments.
```python
host_name = socket.gethostname()
```
Also, whenever writing comments, write it before the action line, not in front of it.

__Not quite right__:
```python
my_port = 12345              # port number of this server
```
__Right__:
```python
# port number of this server
my_port = 12345
```
Note the use of clear variable names which make the code self explainatory.
Look at the whitelines between doc, coding and import. Also notice I am using indentation of 4 spaces(not tab) instead of 3 spaces you used. 4 spaces is standard style in python community.

Edited server.py file:

```python
#!usr/bin/env python
#-*-coding:utf8-*-

__doc__ = """
    This class provide server side access to application.
"""

import socket

# port number of this server
my_port = 12345

# Create socket and listen for eternity...
server_socket = socket.socket()
host_name = server_socket.gethostname()
server_socket.bind((host_name, my_port))
server_socket.listen(5)

 # Now wait for client connection.
while True:
     conn, client_address = server_socket.accept()
     print 'Got connection from', client_address
     conn.send('Thank you for connecting')
     conn.close()
```

### Always take lot of time to think about variable names. Make them interesting. Never use s,a,b,c,.


wtf is 's' ?


seriously ? I don't need your comment that explains this imports socket, code already does that. Also how you can be so sure that socket is a module and not a package ? :package:


would xrange be better?


1810-osversionfail (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2301 of 2332 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.67%25-yellow.svg)


Can you also move this global variable to another file, like stage.js? I don't think it belongs here anymore (and maybe never did), and may be part of the reason it was overlooked when the close button was added. My guess is that other files/classes will be interested in this list (and potentially other global state structures) in the future as we add more stuff.

BTW, thanks for making this change!!!


Not a major one, but did you think about inverting this? I.e., ```else if (!this._sites) {<<set this._stites>>} else { return this._sites}``` removes the need for returning `this._sites` twice.


This is upstream. If we move to 2.25 we can drop this patch.


What is this 5 for ? Why value is exactly 5 and note 4, 8 or 10 ?


It's fine. I opened the Windows Event Viewer and saw the error.

I fixed it and already tested it with VS2015 (no error in the Event Viewer). I'm compiling it with VS2013 and unless something unexpected happens the fix should be up soon.


This is in the upstream package. I will submit a patch to buildroot to move to the newest kexec-lite version.


I will submit upstream


1.tens of thousands 是数万服务器，上万感觉是1万多：）
2. 或者数以十万－》和“数十万的虚拟机（云主机）” 国内通常把虚拟机称为云主机的也比较多。
整个句子倒装一下可能会比较好：
通常一个独立的管理节点可以处理数万条并发的API访问请求，这可以满足同时管理数万台服务器和数十万台虚拟机（云主机）的需求。


@larogers123 Projections are now done, I believe, and ready for analysis. The key file is data/biomassavemap_testK6noSeas.RData, as it has the projected species ranges by 20-year time periods (ensemble model averages). The raw files are on our scientific workstation since they are quite large, so let me know if you need access to them (I can get you an account).


1810-osversionfail (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2289 of 2332 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.16%25-yellow.svg)


                                                                                Noted. Will go through the appropriate channels next time.                                                                                With the spoon of determination in the hand of faith you can carve a tunnel of hope through the mountain of despair.                                                                                From: Mark StorySent: Monday, August 31, 2015 7:54 PMTo: cakephp/cakephpReply To: cakephp/cakephpCc: destinydrivenSubject: Re: [cakephp] Prevent NULL value on NOT NULL column when value is an empty string (MySQL) (22b0275)Issues are better than commit comments for reporting problems.

—Reply to this email directly or view it on GitHub.


@hjanetzek I am not sure why you converted all colors from uint32_t to Color. But to me it makes sense that StyleParam stores uint32_t for color values instead of csscolorparser::color. I have made the necessary changes here.


I think 10 is not enough. The problem is that the ports are sometimes hung for a long time which fails other tests. ```MAX_ATTEMPTS = 120``` will gives the test up to 2 minutes in order to use a the port. In my local testing, this has completely eliminated the bind failures, without noticeably increasing the test time.

If there are leaked sockets which happen more often as we increase this ```MAX_ATTEMPTS``` parameter, then we'll just have a greater likelihood of making those problems surface, so they can be fixed.

Sounds win-win to me (:


@idgserpro node.js tem bloqueado o download desde o Travis


Sadly its not possible to hide them from the public interface in any sane way


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


added parts in the bottoms

ALU and Memory is only a part of what makes CPU. Many more machines are interconnected to make up a computer. Instruction register, memory address registers and other units make up the datapath. The arrows connecting all of them are like highways connecting a city to another city.

In the next chapter, we will look into the Random Access Memory more closely to see the parallel between computer architecture and urban space.

Also, numbered references and updated the link
![screen shot 2015-08-31 at 8 44 30 pm](https://cloud.githubusercontent.com/assets/683107/9593780/fdbc1826-5020-11e5-99ee-c0cc8fc7c877.png)


TeamCity pull requests :: netty [Build 160](https://garage.netty.io/teamcity/viewLog.html?buildId=1029&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4763, ignored: 21 Build time: 00:29:54


My comment was only about putting `b++` / `++b` on the same line instead of its own line, I wasn't expressing a preference for pre-increment or post-increment.


Why isn't `this.__active` set to `false` here?


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-71.0%25-red.svg)


Missing a texture?


queue up to 5 requests. It's just a basic code i was trying out.


これって xcode で挿入するんだっけ? clang-format とか使って機械的に除去するのが良いと思う。


Or the vertices aren't aligned


No I'm just test it


This doesn't seem to be used anywhere. If that's the case, I'd remove it. Also, BasicQueryInfo is meant to be an implementation detail of QueryResource, so it's not a good idea to depend on it outside of that class' package.


“ZStack管理节点和Ansible被安装在所有的Linux服务器上；”
加一个限制比较好：“ZStack管理节点和Ansible被安装在所有的Linux管理服务器上；”

”而后者会从用户那里分发请求“
而后者会分发用户的访问请求。

一个小建议，一行不能太长，否则不利于自己的修改和别人的comment ；）


1810-osversionfail (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Could do the `pollLast() != null` here as well but I think what you have here should work because only the original write lock holder thread should be accessing the `locked_queue` at this point?


ZSTack -> ZStack


一下－>以下


Why is this not part of the presto-client module? It seems like a natural extension to the functionality of the client API (maybe with some refactoring to make it "fit" better)


ZStacks -> ZStack


As Kanye West said:

> We're living the future so
> the present is our past.


Remove this since we now have GCEOptions


Fixes #17


TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.28](http://pixelated.design/build/viewLog.html?buildId=109&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:08


I think you should use an
`<addr>` element here instead.


Maybe appropriate this to set the defaults on GCEOptions instead of GCEOpts. (Did I miss the defaults getting set somewhere else?)


add 'something'


add`something`


volume snapshots 应该是卷快照


hooray


Can be solved by Floyd Cycle detection algorithm.


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (751 of 751 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-7.9%25-green.svg)


挂载 比较好， 挂载／卸载。 detach就是卸载。例如，一个集群可以挂载一个或者多个主存储和L2网络


@BanzaiMan Websites need this feature, as they have custom endpoints but normal regions. :frowning:


I like


I'm removing the "resolved" tag from this issue. Comments do not follow Eiffel's convention. Routine's description should follow its signature. For example:

set_value(new_value: INTEGER)
                -- Changes the value of the account digit
    do
     ...
    end

Also, the comment inside the body of the routine is unnecessary. Please remove it and correct the comment.


LGTM


defaults are set by the cobra in cmd/kola during option parsing


This comment does not follow Eiffel's convention. Description of the routine goes immediately after the routine's name and signature:

routine (params)
        -- Class creator...

Please correct this issue. Thanks!


@OatmealDome thank you so much for replying.
All what you have done it so far it's really appropriated a lot.
Please this is my request for you (please don't lose your interest about it. You are our hope to run it. Please don't give up try I know always there is a solution for any issue)

Other thing: it's our pleasure to join with is to enhancing and help other people there.
Believe me we all need you for the project which is called (Play!) this is ps2 emu for the platforms like android / iOS. I know you gonna help us a lot to developing it more and more. I know you are interested in iOS port and that's make me more happy about that. I'm sure if you join to us it will helpful for all.
Also you could continue developing your amazing project (dolphin for iOS) because the creator of it is super genius about emulations as well as other people there. And if you need anything they will give you what ever you want to know. Also you can see the codes there and how was it goes specially on iOS port of it.

Sorry to make long. Anyway this is the link of the project:
https://github.com/jpd002/Play-
Also this is the same project with different link from the one who is called (LoungeKatt) this guy is also super interesting of iOS port of ps2 emu. Here is the link
https://github.com/AbandonedCart/Play-

Please come and join with us. As I told I'm sure you will gonna help us a lot as well as you will find a many solutions for your (Dolphin on iOS) because of the pretty same codes.

I told you all that because I'm believing in you and in your amazing knowledge of this stuff.
Waiting for you.
Thanks...


"Decrease Defense" sounds more natural than "Weak Defense".
"Weak Defense" sounds like a name for a skill that decreases your own defense


So now that we have stripped the prefix from the "toc", do we need to add it back when extracting sosreports?


Problem with this: a lot of people never use sdist, so we can't assume that this is going to be accurate.


You didn't need this anyway, it was registered in the base registry.


uh, @simontegg you sure this is right?


Hello @valevalorin , I didn't mean that you should get rid of ng-app for background. I mean you should remove ng-app for soundcloudify.core (as this is just a module)


wow if you'd look I didnt looks for these commits. I just did it based off of the newer stuff for hammerhead. never seen a working voltage control for falcon


great to hear one less thing wonder about cause of OCD about checkin event viewer I have.


haha :) thanks


no


@simontegg how do you feel about `import` / `export`? i prefer the simplicity of `require` / `module.exports =`.


87382760-VAVTerminalUnitSchedule-Issue4285 (mjwitte) - x86_64-MacOS-10.9-clang: OK (1777 of 1807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.34%25-yellow.svg)


so because I know how to do things my self instead of looking for a probably broken cherry-pick that I'd have to fix up I'm using someone elses work. seams legit. get off my git with your bullshit


Oups wrong commit for the wrong workspace :-)


@niketanpansare @deroneriksson Yeah, this was fixed in commit https://github.com/SparkTC/systemml/commit/2462ba5defafbfe967799029739ddf6c8986967e.


it might be easier to use [`smokestack`](https://www.npmjs.com/package/smokestack).

also `babelify` should be in `browserify.transform` so it applies to the module whenever bundled, at least until we have app-level transforms and tests.


Where were string interpolations?


I'm just playing with ES6 here. Can do require / module.exports.


wonder how to get aaround it


@bsuvsmluhs787 ...get around what?


I tend to dash separate my words in CSS in line with best practice.  The general consensus is that it is easier to read.


i'm pretty sure it's the opposite, i.e. we want [what is in master](https://github.com/holodex/app/blob/master/src/node_modules/config/index.js), as this would revert those pesky bug fixes.


Ok you caught me. I ran 'rubocop -a'. All those double quotes. Version, gemfile. It's just good practice to use single quotes where you are not trying to eval something inside the string ;)


ok


just a minor thing again around readability, a space between the last character and the curly brace helps scan the file more rapidly.


it's cool, not sure how consistent we want to be so letting you know i'll be using require / module.exports in my ES6 code, happy with what you do.


你测试过吗？没有异常？
Xposed里的log没有exception？


Sorry for the long reply, I don't want to introduce a java 7 dependency, and that doesn't sanitise the filename completely.


You sir, are a commits-smith.  A bard among committers.  Thank you.


I just translated what the Korean counterpart says. ;)


    .widht-620 {
        /* reads a little easier */
    }


Me parece que no tiene sentido commitear los moc files. Éstos son autogenerados con cada compilación según sea requerido.


You could dispense with the id selector here and just leave it as a `h1`


Why is this not in https://github.com/jenkinsci/packaging/blob/master/branding/jenkins-stable.mk as `…/changelog-stable`?


コードに変更があったのは、GetAttributeメソッド（187行目）のみとなります。
それ以外の変更は、フォーマットの違いによるものです。


instance offering，可翻译成实例方案，disk offering，可翻译成磁盘方案


I know this isn't touched by your PR, but can we fix the potential memory leak in the clock at https://github.com/mojotech/helios/commit/d024b711ff317d29646ab42f579a78bf5992a93a#diff-ff6594eaf340c4bf680d340ddc98b77fR30


Why do we have to differentiate?  No wait and pod deleted are different
scenarios.  But the outcome of both is the same state (nothing to show).  A
user controls NoWait=true

On Aug 31, 2015, at 6:50 AM, Michail Kargakis <notifications@github.com>
wrote:

It is but there are two cases where we get a 204, either when we don't want
to wait for the logs (NoWait = true) or when the deployer pod is deleted
(complete deployment) and we have to differentiate between the two here.

—
Reply to this email directly or view it on GitHub
<https://github.com/kargakis/origin/commit/da3d03a8703821c35277820d0287bfce3566f371#commitcomment-12973347>
.


Sounds reasonable.


Yes.  Don't make me repeat myself unless I'm providing meaningful
clarification.

On Aug 31, 2015, at 8:39 AM, David Eads <notifications@github.com> wrote:

@deads2k <https://github.com/deads2k> why do I have to specify both
metadata.name and roleRef.view?

It seems reasonable to distinguish between a rolebinding name and its
roleref. Different categories of users with the same permissions come to
mind.

You're saying you'd like to have one default the other?

—
Reply to this email directly or view it on GitHub
<https://github.com/smarterclayton/origin/commit/0815afcf147897063cce4ee7564677edd5516319#commitcomment-12975006>
.


test


In the Australian market(97.99%) you can get away without vendor prefixes and most of the world to be honest.  Check out [http://caniuse.com/#search=border-radius](http://caniuse.com/#search=border-radius).  Good that you know they exist though as some properties do still require prefixing.


Consumers of the platform package that aren't cmd/kola will miss out on the these defaults though. This way the platform can set their own defaults or correctly error regardless of the binary that uses the package. cmd/kola can just provide overrides.


Nice display of knowledge on the attribute selector on the `img`.


3 line module! Got to love npm :)


@BibMartin What is the `0.01 * 17`?


Hehe, I did not check the Even Viewer before so that OCD helped. It should be fixed now so grab the new version whenever the build bot finishes and hopefully it works for you.


Rename this to abi. (record selector can still be abiHash)


Then create a variable request_queue_size or max_requests and use that.
Declare it where port is declared. I have updated my comment below with new code.
```python
request_queue_size = 5
```


Be mindful of your choice of tag.  `section` will bite you as invalid when it doesn't have a heading `h1-h6` underneath it making it technically invalid.

If the `section` doesn't use have a heading to provide context use a `div` instead.


Same as previous comment


`encoding` only makes sense when using Ruby 1.9 or older.
The current default encoding is already UTF-8 :smile:


This change causes Hugo to stop building.


Interesting, thanks


@jonafato - Thank you :)


We should really try not call `static` methods/properties from within an instance method -- this design leaves this class completely coupled to the static implementation, meaning it may as well be a static class. Use constructor injection to inject dependencies into this class e.g.

`public ModelFactory(ILogger logger, IViewModelFactory viewModelFactory)`

This approach allows for maximum flexibility and the use of common Dependency Injections patterns


There should be a space after comma in case of method arguments.
```python
def search_User(self, user):
```


We need to come up with a more suitable package name that adheres to the CRAN/Bioconductor conventions! For now `devtools::install_github("jasdumas/GEO-AWS")` does not work and returns an error for Malformed Package name


Please use /dimen, /string, /color


I would be happy if it is 2 minutes in total. It is 100 milli + 200 milli + ... 2 minutes

which is 7260 seconds or 2 hours. whcih is rather very very high for a test to fail :(


IIUC, this will this break "make cts" after "make"? Could you remove this change from the PR for now? I'd like to postpone this change until the discussion in b/23685536 finishes. (same for https://github.com/danw/kati/commit/87417414fa9d6384f75f325fcebb18ba769caacc)


91958608DOASEffectOnZoneSizing (wfbuhl) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-81.78%25-red.svg)


Why are you using 6 space indentation ? User 4 spaces indentation for all your code.


LGTM


Nice work @j-tweed @liuguofang.  Still some stuff to iron out, but getting there.

I think we're all learning as we go, so I'm not 100% that I know the proper work flow, but @j-tweed when you're ready to merge your branch into master, make a pull request.

Also we should probably use issues a bit more to identify problems and discuss potential solutions.  Fun to learn this stuff!


Didn't know that!! thanks!! I pretty much only every use Divs, so i'm
trying to branch out!!
Is there any downside to mainly using divs?

On Tue, Sep 1, 2015 at 11:20 AM, Patrick Nolan <notifications@github.com>
wrote:

> Same as previous comment
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rachadrienne/homework-landingpage/commit/4446c161ec026562ea5d01e720657ff9cc42b070#commitcomment-12988844>
> .
>


asdfasdfas


The entire `ModelFactory` class appears to be little more than a wrapper for the `ViewModelFactory` class -- may I inquire as to the reason for this class instead of just renaming `IViewModelFactory` and its methods?

Also I commented inline -- the use of the static default implementation makes this class completely coupled to that one implementation. Modern DI frameworks make constructor injection easy, so we should use it :bowtie:


I meant having one rule that groups together all rules that compare two graphs with one another (is isomorphic to, is subgraph of, ...). This is assuming you can come up with a clear way to write the rule.


It is best practice to dash separate your words in your CSS and keep it all lowercase e.g.

    #button-blue {
        /* Your styles here */
    }


That seems reasonable, given you don't want to throw errors if you can help it.


Looks good to me. @brian-c can you deploy please?


Are you really trying to target a paragraph with the `id` of "benefit" here?

Remember that if it is the other way around i.e. the paragraph is a child of `#benefit` then it would read

    #benefit p {
        /* Your style here */
    }


Same goes for the rest of these selectors too


Have you ever thought about helping out the trinitycore repo?


たったの一行かよ・・・と書いてみた


I see I was mistaken. The image can not be resized. But it's format can be changed - which would be bad if the frame is being used by multiple threads.

Sometime we should discuss how to handle video scopes for GPU and non-GPU modes. It would be a shame to implement each scope twice.


Just curious — what's the reason for this check? Was it returning `string.Empty` unexpectedly and causing issues?


It looks like you didn't update the class repository on GitHub.  The font-sizes were updated based on Aarons observations.  They are all doubled.  In this case

    font-size: 48px;

Which looks exactly like the Visual Design file.


lgtm


LOL, I was wondering if you would catch the infinite logging loop.


This scene does not have constraints on the plunger of the needle


Why was all the XPM stuff commented out?


might as well, just inline this above.


I'd use a hyperlink (`a`) tag here instead of a `button`.  Then I'd style it using the following

    display: inline-block;
    width: 300px;
    height: 60px;
    border-radius: 5px;


valdators -> validators


#Fixes 23


call this `instanceName`


아 "도메인을 넣어서 호출하면"  무조건 CORS으로 동작해.


`instanceNameParts`


从08年至今，感谢大神为互联网自由曾经做出的贡献！


91977808_LBNL_NewVRFModel (rongpengzhang) - x86_64-MacOS-10.9-clang: OK (1811 of 1815 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


从08年开始翻墙，就用的GoAgent，感谢大神为互联网自由做出的贡献！


spaces around operators


Activation context generation failed for "D:\My Documents\Emulation\pxsx2\Pcsx2 Git\pcsx2.exe".Error in manifest or policy file "" on line . A component version required by the application conflicts with another component version already active. Conflicting components are:. Component 1: C:\Windows\WinSxS\manifests\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.10240.16384_none_3bccb1ff6bcd1849.manifest. Component 2: C:\Windows\WinSxS\manifests\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.10240.16384_none_f41f7b285750ef43.manifest.

error on boot/reboot of system PCSX2 hasnt even been started


`id` should be unique within the page.  You defined an element with the same `id` on line 25 so your HTML is invalid.  Please get in the habit of validating your HTML [https://validator.w3.org](https://validator.w3.org)


81211464-LinkInfiltrationAndReturnFlows (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1276 of 1276 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.96%25-green.svg)


Again duplicate `id`.  The `id` is unique and the `class` can be used as many times as you like.


Always use `{}` when you have an `if/else`


Why do this?


宿主的资源如果不是0x7f开头会有问题，不信自己读Android源码


saw approval from ksauzz
at https://github.com/basho/riak_cs/commit/827143ff3b3fb5fb397b239dbe5116695fef3a93


merging basho/riak_cs/bugfix/cfishy-riak-test-gleaning = 827143ff into borshop-integration-1231-bugfix/cfishy-riak-test-gleaning


basho/riak_cs/bugfix/cfishy-riak-test-gleaning = 827143ff merged ok, testing candidate = 1643c8d2


yes, that was the intent. The comments are updated accordingly


Yeah, I needed to get a patch into hostboot first before we could move to 2.25 - now that that's in, I'd plan to move to 2.25 as soon as possible.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.540](http://teamcity.monogame.net/viewLog.html?buildId=9887&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Afte Nick Montfort's comment that this part of binary digit is not clear...


This should change to bit compute only, should not combine with value compare.


Awesome. We should possibly even bless kexec-lite as 1.0 and move to it, that'd look a bit better than random git commit + v0.0.2 or whatever it says :)


Since there is a possibility of race condition and tasks can come and go from original Set we need to protect making copy of the set. Same for other "getter" methods


@garbas please notify me about such things. Because I need to apply this to https://github.com/jagajaga/vim-addon-vim2nix/tree/master/additional-nix-code to make automated updates.


Làm cái gì ở đây vậy?


Merging upstream


是修复在 LSceneNode::Load 里 没有把子节点 (75 行和83行) 指向父节点的 bug.
I'm take a mistake. It's fix bug in LSceneNode::Load which not lead child node potint to parent node(line 75 and 83).


注释里说错了.
commit.md is wrong.


I'll test it out once the servers are back online.


then pr it


More merging?  Not sure why this isn't merging the entire upstream/master


dojo.byId('repeatField')に含まれているので不要


Guess you didn't pick up on the sarcasm ;) ...


i think you shoul uncomment this too


updated the comments


Can you add Give too? [Give](https://wordpress.org/plugins/give/)


@sindresorhus ping :)


Yes indeed. I was trying to translate the previous version of the code without making larger changes than I already had to, but you are absolutely right. I'll clean these up.


Test


OK, will do.  I wasn't sure of the rules for externs but it clearly ought to be in arc's header since that's where it's exported from.


akong gi-change akoa, hahaha pero kani akong gamit kay mas sayun
```java
import org.springframework.validation.Validator
```
ang javax validation kay lisod haha


Could you use enumerate here or zip the py_section and js_section together so you can do:

for py, js in zip(py_section, js_section):
   ....

and get rid of all the [idx] accessors?


...and generally it is questionable whether unapproved records should appear in reports even if the user has review-permission - that would produce numbers which do not match the "official" situation, and could lead to misinformation and confusion. Needs to be discussed.


Yes, and that is by intent.  The quality of the CCDs vary somewhat, so we want to make sure that the code is sufficiently 'bullet-proof'.  I intend to follow up with some commits to add the necessary safety code - this is the framework.


What about SCHOOL_MASK_HOLY?


@jelledevleeschouwer please do not use stdlib functions in picoTCP.


알고리즘이 정교해지고 낭비를 덜 하면 훨씬 빨라져요


Добавлена функция показа хеша определенного файла.
В дальнейшем проще будет сохранять хеш файла, а не каждый раз его хешировать.


Honestly, I'd make these a hyperlink to the code, then they can't possibly be incorrect.


Issue #19


@JasonSymons heads up, userFTPUrl isn't assigned a value anywhere in the code.


Tomer met ārā Notice: Undefined offset: 2 in ...
vajag šādi:

if(@$response['birthday']){
	list($year, $month, $day) = explode("-", $response['birthday']);
}


The only problem I have is calibration. For this daemon must be started in foreground and then kodi from which calibration is done.


C99?  game came out in 2003.  why do we need support for so old compilers.


ik weet niet zeker of je beide delen nodig hebt voor de belasting, maar het lijkt me wel goed om in de administratie erbij te hebben staan.

De eerste dus niet correct ? ik snap niet waarom. Je hebt 121 uitgegeven. 21% daarvan is 25,41, dat bedrag wil je hebben voor de belasting.


I think we need to work out why the `just-this-one` argument needs to be set, because it's usually bad form to use it. Is there a timer running that's causing the problems in #53?


It would be nice to add "examples" or "help lines" to question creation form.


GitExternal.cmake should also be updated


Yes, this works for SAMBRO.
It doesn't yet have the deployment_setting to limit to single-record methods


This commit seems to do more than just add the new test data?


101884090--NewVenting-Availability-Schedule (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (760 of 760 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.67%25-green.svg)


Hi @eviltnan,

Looking forward for it! :)

Thanks,
Eko


fix travis


> to get

Could this read better as:

> to produce

?


Agree with filtering from Reports


Which default download would u put for linux? Theres already the src link.

On widnows and mac u get the native package installers

> On 01 Sep 2015, at 11:08, Maijin <notifications@github.com> wrote:
>
> Is intersting but imho clearly not réserve to be in on the index
>
> —
> Reply to this email directly or view it on GitHub.
>


ayy


> at which point you can fix it

Does this work any better?

>  at which point you can select your desired property.


I didn't like this change. Change back!


Probeer maar, neem een bonnetje van de AH en probeer de juiste bedragen terug te krijgen.

Ik heb hier een bonnetje waar op staat:

- totaal bedrag: 33,39
- btw: 21%
- netto: 27,60
- belasting: 5,79


I see, that makes more sense, I'll have to read on rresult but I'll
implement your suggestions.

On 1 September 2015 at 11:58, Hannes Mehnert <notifications@github.com>
wrote:

> I'd suggest to use a either return value... similar to what we do in tls:
> interface
> <https://github.com/mirleft/ocaml-tls/blob/master/lib/reader.mli#L24>,
> the actual implementation
> <https://github.com/mirleft/ocaml-tls/blob/master/lib/reader.ml#L431>
> might throw/raise, but is protected by a catch
> <https://github.com/mirleft/ocaml-tls/blob/master/lib/reader.ml#L27>.
>
> thus, a caller of the parser does not need to check for potential
> exceptions, but has to check and handle the different result types
> explicitly (instead of using a monad, certainly rresult
> <http://erratique.ch/software/rresult> could be used).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/haesbaert/charrua-core/commit/5a27b06656e073bab0662e245e50378cecf15a66#commitcomment-12994864>
> .
>


> While on the subject, you can delete a declaration (the property + value) by hitting backspace in either the property or value field and then hitting enter.

Could instead read as:

> To delete a declaration (which includes a property and value) use the backspace key in either the property field or the value field and then hit enter.


Should be reported with medium priority


Unless you see some problem with it, I think we can keep it the way it is by either passing an array with all the layers' names or by ignoring the filter when the String[] is null. I'd probably stick with the second option as it also prevents potential null pointer exceptions.
If you're right with any of those fixes, I can take care of it.


Should be fixed now, thanks!


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.487.28d143f52451feae12a93e5643c87bc3cfab80f9](http://build.palaso.org/viewLog.html?buildId=62435&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:07:34


I think that for now we can add it to the cover letter or to the TODO file.


Ok, rozumiem to rozwiązanie w połączeniu z JsonIgnore wydawało się prostsze i czytelniejsze, oczywiście poprawię.


服务端就那样了，客户端等我这里Release直接用吧


Correct, Fixed.


lgtm


Yes


> you get autocomplete for these, it makes it easier to discover query types and their corresponding values. The values which autocomplete will exist in your current network recording.

Is this any better?

Auto-Suggest values appear for valid query keys such as `domain`. This makes it easier to discover query types and their corresponding values. Auto-Suggest values always exist in your current network recording.


@Mangatome thank you answer, what can i see real data in device.Forexample use API? by the way i found Unity Editor Profiler Memory size about double relation with your caculate .


web으로 접속시 index.php를 무조건 거치도록 하는 상수.

다른 php파일에서는

if(!defined('__XE__'))
{
	exit();
}

아래와 같은 소스로 직접접근을 막는다.


niceme.me


额。。。。。。。。。。不要在改代码的时候改编码规范~


dirname(__FILE__) = 현제 파일(index.php)의 경로 = __DIR__

http://php.net/manual/kr/language.constants.predefined.php


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.35.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62425&buildTypeId=bt2) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 733, ignored: 45 Build time: 00:57:55


It gives the user tangible visual clue about the progress - without it,
everrything would happen instantaneously. I think that most people aren't
used to this, it feels more natural (at least to me) if installing
something takes a very short moment. It's also slightly easier for me to
parse lines appearing one by one rather than all at once.

But maybe i'm overthinking this :-)
1 wrz 2015 11:26 "Mikołaj D." <notifications@github.com> napisał(a):

> why sleep?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/janek-warchol/sensible-dotfiles/commit/01c13e20a0ef37242ba49076085a94ab8d756485#commitcomment-12994220>
> .
>


This is redundant. Maybe extract the conditions into a method?


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8105/testReport/) for this commit**


shouldn't here be `self::NO_REDIRECT` instead of 0?


: [CORRECTNESS] new IllegalArgumentException(String) not thrown in hm.orz.chaos114.android.androidsaddlersample.MainActivity.onCreate(Bundle)


额。。


Again, you seem to have changed some dates in `visitor_mailer_spec` and friends here?


Could you please give an example of what is needed to be checked or cleared in the udata.


注意：所有的小改动 我都是堆叠起来
在升级的时候附带提交的
这样可以避免增加过多无谓的commit 弱化每一个commit的主要目的


I know, "somebody else" introduced that, but we could increase readability by replacing double with single quotes.


oops, sorry you were right, the initial rand() function doesn't round its result, I've overread my code :/
Can you put back your other helper randInt, please?


Oke, ik ging de logica voor mezelf opschrijven, en ik snap nu wat je bedoeld :
Een bedrijf heeft een product. dat kost 100 euro. de overheid zegt, voordat je dat verkoopt aan iemand moet er 21% bij. 121 is de prijs die dan betaalt wordt door de gebruiker van deze tool. Deze gebruiker krijgt aftrek en wil dus 21% weten van het bedrag wat betaald is.
Maar dat is dan niet dezelfde 21% als het origineel. dat is waar. maar dat kan iemand dan helemaal niet bereken.


E_NOTICE  , E_DEPRECATED  , E_WARNING (, E_STRICT) 의 오류보고를 하지 말라는 의미.
http://php.net/manual/kr/function.error-reporting.php


Test Comment


제로보드 시절의 잔재 소스


xe의 버전 상수.
http://blogs.technet.com/b/koalra/archive/2009/07/27/beta-rc-rtm.aspx


Using [Descriptor class](https://github.com/poparteu/openMVG/blob/voctree/src/openMVG/features/descriptor.hpp#L28) should be better for a cleaner code. Like this :
```c++
typedef openMVG::features::Descriptor<float, DIMENSION> DescriptorFloat;
```
Also we talk about descriptors no features here so using `FeatureFloat` is a bit confusing.


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1816 of 1816 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Another observation - for streams with multiple periods the timeline displays only the currently playing period instead of all the periods. As a result it is not possible to seek to the next/previous period.


NAK. No secrets in (new) options please; see the debacle with e.g. RHEV and postrgres password passing. You need to do this in an environment variable so that it is not exposed in process listings.


Existing code is not entirely consistent in terms of spacing but maybe stick to `if (` etc in all code added here? Other parts would be changed later.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19927/testReport/) for this commit**


@rtpHarry This one too..Once your contribution and has been accepted and integrated


The /tellraw and /title commands are vanilla minecraft, so why not in glowkit?


Ik heb even zitten rekenen. Ik snap wat je bedoeld. Het percentage wordt genomen van het voor de belasting bedrag, dan kan je niet zomaar pakken van het betaalde bedrag. in ieder geval niet van door het percentage te bereken.


Ooops. Thanks for the fix!


You are right. On a fresh installation it works, but after the upgrade of an existing database I cannot edit linked elements and also if I add new content elements I can edit them only if they have only 1 field.
In Firebug I get a not very helpful message
> (For each linked element) TypeError: $(...) is null
>	`<!--[if IE 7]><link rel="stylesheet" href="http://HOSTNAME/themes/admin/styles/original/css/ie7.css?v=1.0.8" /><![endif]-->`

And the edit-window will not open (for content element with more than 1 item).


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


好的，多谢！


CONFIG_CC_OPTIMIZE_FOR_SIZE is enabled in your defconfig, so this change should make no difference.


This means the nav bar overlaps the editor:
<img width="1019" alt="screen shot 2015-09-01 at 12 31 59" src="https://cloud.githubusercontent.com/assets/660805/9602023/8b98dbdc-50a5-11e5-8c37-14c7a8de8399.png">


`self::NO_REDIRECT` instead of `0`


Minor - those two should be flipped.


OK.


Thanks, great. Yeah, translations are huge work especially if starting relatively new. Very appreciated!


Сие не совсем ок, если твой билд будет запущен так:

```sh
somedir/program
```

pwd по идее будет выше уровнем. Надежне так:

```go
_, filename, _, _ := runtime.Caller(1)
directory := path.Dir(filename)
```


101789044_gridviewFilters (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2303 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.29%25-yellow.svg)


Ack. Fixed in a5c426e126c75bd73fa3670af1898a3e4ab50885


The way that @caymard is suggestion would be a nice start.

But I think the best would be to use the Region concept that it is the generic concept to embed feature/descriptor association.
https://github.com/openMVG/openMVG/blob/master/src/openMVG/features/regions.hpp#L23
Since Scalar_Regions && Binary_Regions exists it would allow to extend later the VOCtree to work on scalar and binary descriptors.


Имеет смысл тогда идти иерархически

1. текущая папка
2. папка бинаря
3. хомдир
4. etc


Java 8 is `required`, not `recommended`.


undefined $var22


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.467.28d143f52451feae12a93e5643c87bc3cfab80f9](http://build.palaso.org/viewLog.html?buildId=62434&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:31:04


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8106/testReport/) for this commit**


Color.txt needs for creating nodeclass


This is worded rather strangely.
`Sponge requires Java 8 at this time. Java 6 and 7 are incompatible.`?


what is this AZMQ?


@simon816 If I remember correctly, the main reason for changing from `Subscribe` is because Guava has an annotation with the same name, and there have been issues with people using it instead of Sponge's.


This should be `contents` not `content`. Last CI is failing on builds.


Неверно проставлена скобка, надо с новой строки.
Это относится ко всем объявлениям методов и классов. If, foreach и прочие конструкции внутри методов пишутся в строку.

Как должно быть:
```php
class BlogController extends Controller
{
    ...
    foreach($a in $b) {
        ...
    }
    ...
```


Test Comment


@KozhinM - yes, the old stream exhibits the same issue, I thought that's why you were updating ;-)
It's likely there's an issue with the stream, but note that there is also the somewhat similar https://github.com/Dash-Industry-Forum/dash.js/issues/735 which regresses in development (and is harder to detect).


Changed in next commit. This is now as a variable.


Hey @jomo,

after looking in the source of the backend, I have to revise my previous statement. I changed the url in 358dfde.

Thanks for your effort


Magic


This TODO should be removed.


I do, however, think there is a better name that can be used here.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19929/testReport/) for this commit**


Why comment here? The title command is definitely in Glowstone++. Other commands that are not there are because we have to code them ourselves, and we haven't yet.


I actually observed the problem in ch11ng/exwm#53 before (in another form though), but did not set out to solve it until that issue was reported. In essence, the problem was that a call to `accept-process-output` was interrupted and never returned. Or in more detail:

1. Some event handlers were executed after a call to `exwm--make-emacs-idle-for` was issued in `exwm-workspace-switch` when EXWM is initializing.
2. One event handler called `xcb:-+reply` where there is a call to `accept-process-output`.
3. The code was interrupted in `accept-process-output` and the context switched back to `exwm-workspace-switch`.

So it seems Emacs did something in `accept-process-output` that caused the problem. Since the intention of `accept-process-output` here is merely waiting for replies to arrive, I think it's okay to accept outputs from that certain process only, and it solves the problem.

Of course, if we remove `exwm--make-emacs-idle-for` there then those event handlers won't get called. But I'm not sure if something else (perhaps in the future) will trigger those event handlers as well, or if this problem happens in other handlers.


Did you consider simply setting the `box-decoration-break` property to `"clone"` to achieve this effect in a single span? That ought to work additionally when there are line breaks that are not authored with `<br/>` elements, i.e. when the user agent wraps the text itself.


Лишние пробелы после скобки и перед скобкой
Нужно так:
```php
    if ($form->isValid()) {
```


Here there are two task within one script.
1) Login with valid username and password. Result: User should get login successfully.
2) Login with invalid username and password. Result: User should get error message,should not get logged in


@oroce if child loggers have the same serializers, data gets transformed twice, which is not intended (but it's a valid usecase that the child loggers have other serializers)


@mastercoms I comment here because this is the file I'm ranting about


Looks like this is not used.


Oh whoops should've made a line note


Ohhh i see


Test Comment


Maybe use get_rest_client without parameters?


I do not see why this should be changed !?


use `!==` instead of `!=`


We need to schedule that tasklet in case of there is more than entry in the queue to avoid running the requester for the same QP in parallel. Do you want me to add it in the comment also ?


test


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19930/testReport/) for this commit**


@Destroy666x Any progress? We need a fix as soon as possible.


Looks good to me :+1:


Het kan wel, alleen de berekening is iets ingewikkelder.


saw approval from gordonguthrie
at https://github.com/basho/riak_ql/commit/9c7abf9b7ab856efcca43010e9b96c92d0512587


merging basho/riak_ql/rts252_binary_field_names = 9c7abf9b into borshop-integration-15-rts252_binary_field_names


basho/riak_ql/rts252_binary_field_names = 9c7abf9b merged ok, testing candidate = 30b92f23


Because in pyprophet/config.py it's called semi_supervised_learner.use_best.


Just curious, is this `cleanup` only for test purpose, or it might be used in somewhere? Because I can't think of any scenario we'll really need to clean up all the BCs.

BTW, it's also another small question about requesting mobileMessageClient, Although we will not really establish the client if it's existed already, is it really necessary to checking the client existence every time while calling shim method? Since BC is unlikely to be affected by other BC's once we have appInstanceId here. Or the another though: If we will check/establish client while calling shim method, do we still need appInstanceId?


@brezza27 : error here,
"Illegal double '1.79769313486232E+308' value found during parsing"


ha ha


But it means that the unit tests can have random failures and you wont' know in a an automation situation whether the failure was because of new code or if it just hit a CCD it didn't like... I think unit tests should be 100% reliable and stable..


> I think this is due to periodic rtimer use

A description of of how to repeat the problem would be nice...

> And (TBCCTL6 & ~COV) is the same as !(TBCCTL6 & COV)

Not really. Let's say COV==1 and TBCCTL6==3.

      (3 & ~1) == (3 & 0xfffe) == 2
      !(3 & 1) == !(1) == 0


please add time (hh:ss) of the end of the break


@tallytalwar yes, makes sense :+1:


I didn’t consider that at all, since I didn’t know it existed, but I’ll have a look at if we can do a combination of the things I’ve done and box-decoration-break = clone to get a better line breaking in the case the user writes a very long text (row) that gets wrapped by the browser.


if no longer needed, feel free to delete this. Git will keep track of your old functions for you in your history.


This will keep me busy for a while.


@Flameshot Can you give me your email address or SKYPE account number?


css maps should not be part of source control, since it's not very human readable, feel free to add a guide how to produce them to a README.md


Haha, can you s/opertation/operation, please? :)


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.468.28d143f52451feae12a93e5643c87bc3cfab80f9](http://build.palaso.org/viewLog.html?buildId=62444&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:17:15


hello?


Hei Dina,

I have some issues understanding this part and jscs detects an error, can you rewrite it in a different way ?

We do not rely on the indentation so if you have nested `if`, it's better to use blocs `{}`. Also if you use `return` in a `if`, it's better to not use a `else`.


It's interesting. ;-)
I like to use `/` for functions in my personal configs just because it makes it easy to identify them.
But in packages I release I prefer to just stick with `-`. It's the official style and there's no reason to prefer anything else.


Oh I see, Is the idea that items that override UseItemFrame should not use vanilla useStyles at all and do everything manually? If so, I've been going about  my mods wrong.

If that is the case, shouldn't that return statement be two lines lower then? So that all code paths would return before accidentally calling ItemLoader.useitemframe?


Hi Juerg,
Your patch work well but unfortunately it doesn't ha


@narcoticfresh Sorry, I forgot to change the parameters.yml.dist... See 724a2c7


omitted ;)


Can [the tool "Automake"](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Libtool.html "Libtool usage") help you eventually?
With which script details do you struggle at the moment?


Could you also add the names of the nodes?


Я клаустрофоб :) Глазу легче читать.
Но понял, что принято без пробелов и с переносом фигурной скобки на новую строку.


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (760 of 760 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.47%25-green.svg)


I read on the Bootstrap site that Glyphicons are being removed.  Now I cannot find that info anywhere...


Thank you and good luck!


My mistake. This commit is about fixing issue #1620.


rename class to `ImgReader2*` rather than `ImgReaderWithoutInput` and `ImgReaderTable` respectively.


Let's name it `LocationAccessorsInstrumentation`


This still needs some improvement, which I hope to normalize before bumping that major.


Let's name it `MethodCallInstrumentation`


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.36.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62438&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:39:13


Technically it's correct, no? For example, `require "spidey/version"` tries to first interpolate the string, finds that there's nothing to do here and moves on, no? I actually don't know the internals of Ruby to say for sure what it does differently at runtime when you do `"string"` vs. `'string'` (I hope not much), but I suspect @nobu you do?


I would write (*args, **kwargs)  here


Or even better `DocumentLocationAccessorsInstrumentation`


https://github.com/twbs/bootstrap/pull/17021

**Remove Glyhpicons**
- Add instructions for implementing Font Awesome
- Add instructions for implementing Octicons
- Add instructions for implementing a third option, if there is one?


@r4vi the pleasure was all mine


`PropertyAccessorsInstrumentation`


ah, I forgot that we use this for search filtering.  Can we add this field to the elastic index?


Correct, Removed it.


Also, `if (Number.isInteger)` returns always true because you do not call the method but check the existence of the method.


Since this is present in dependency sectiion, stating dependency again in comment is unnecessary. Along with saying what it is also mention its need.
For example for 'Volley' below, HTTP services can be called from native android sdk - this is required for async - Lets add a #TODO - Review before shipping. (so that we can remove this if not used)


Yes, i obtain :

```css
.columnComponent-header{...}

/*# sourceMappingURL=app.map */
/*# sourceMappingURL=ColumnComponent.scss.map*/

.columnComponent-sizeNorthManager{...}

/*# sourceMappingURL=app.map */
/*# sourceMappingURL=ColumnSizeComponent.scss.map*/
```

But it will be a big plus for Fly ;)


I would add another field, like BLUEPRINT_ID='a_bp_id' and use it in the cli_runner line + assert in the get() method


I'll have a look and make sure to fix this in the next minor.


Add assert blueprint_id == self.BLUEPRINT_ID


Couldn't find an issues spot, so I'm putting this here. Try dividing by 0 ;)


A different ZMQ wrapper. It is written in a way to nicely integrate with boost asio


No secrets will be exposed via the options, just filenames with SSL certs. An example:

    sosreport -o qpid -k qpid.ssl-certificate=/etc/pki/katello/certs/java-client.crt -k qpid.ssl-key=/etc/pki/katello/private/java-client.key -k qpid.port=5671

would call (among others):

    qpid-stat --ssl-certificate /etc/pki/katello/certs/java-client.crt --ssl-key /etc/pki/katello/private/java-client.key -b "amqps://localhost:5671" -q

but the certificates content wont be exposed anywhere.

Does your concern apply also here?

(btw I see one subtle issue with the patch: sosreport would collect files from commands with _huge_ name, like:

`sos_commands/qpid/qpid-stat_-q_--ssl-certificate_.etc.pki.katello.certs.java-client.crt_--ssl-key_.etc.pki.katello.private.java-client.key_-b_amqps_..localhost_5671`

. Supplying there some shorter name would require to break `self.add_cmd_output` of list to a list of individual `self.add_cmd_output` calls with `suggest_name` option)


yes


General Note:
-> We should definitely consider lowering the size of the apk file. We will try to fit in about 500 KB for an APK.
http://stackoverflow.com/questions/11079835/minimum-size-for-a-valid-apk-file


TeamCity Jarvis Framework :: CI-GitFlow [Build 44](http://build.prxm.it:8811/viewLog.html?buildId=3917&buildTypeId=CqrsFramework_CiGitFlow) is now running


@kshelton I believe this comment should say "Amazon Web Services" instead of "Google Compute Engine".


@paulvi it is in master.


Another General Note:
https://github.com/shashankreddy509/Bullian-Tracker - Create a README.md file

https://github.com/icefox/git-hooks - see this for example and how the description for the project is displayed per the contents in README.md


I agree that moving this stuff to some method would make it nicer. Maybe also setting `$showArchived` to `true` or `false` at the very beginning would make those conditions even easier to read.


Then I'd suggest mentioning 'path' or 'file' in at least the option description if not the name: "client SSL private key" sounds like it could easily expect a key string.

For long file names that's your current option: either single calls to `add_cmd_output()` with suggested names or bulk calls that accept the default mangling.

Patches are welcome to introduce more control in command output naming but it needs to be an interface we can support in the long term.


@s-block you weren't thinking "Why didn't Ravi just use a django form", because I am now :cry:


You are. :)


101884090--NewVenting-Availability-Schedule (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1288 of 1288 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.02%25-green.svg)


method name is 'getCurrent()' but are returning void.
also, can we rename this method to 'getLatest' instead.

void comment also applicable here.


What do you mean by "bracketing the loop" ?

Calling the same function (`write_str`) here and in other places where we emit to stdout is really the thing to do. We don't want different behavior in `log_*` functions and here. Now, I'm not 100% convinced that my `write_str` function does the right thing. Currently it tries to use the system's locale (so that the output of `git_multimail.py` gets a chance to display properly on e.g. a latin1 system) and falls back to UTF-8 when it can't, but perhaps doing all-UTF-8 would be better. In any case, if `write_str` is broken, then it should be fixed, but we should not use different ad-hoc solutions to write to stdout in different places of the code.

Writing some strings to stdout and some to stdout.buffer, and calling `flush` to fix the side effects seems backwards to me: why not just avoid the problem instead of working around it? What is the benefit of this `if is_ascii(line)`?

>  I've never seen that problem before.

I have no idea why I get it in some circumstances and sometimes not, but I did get a failure, and it was a funny one ;-).


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.2.0-unstable.10+10](http://build.prxm.it:8811/viewLog.html?buildId=3917&buildTypeId=CqrsFramework_CiGitFlow) outcome was **FAILURE**
Summary: Tests passed: 124; exit code 1 Build time: 00:03:35


'repeatCondition' param missing here?


Rename the class please. -> to QuandlCurrencyDao


This breaks building go packages for me on Darwin.

Can we do without the procps?


where? It's field...


Or make it optional?


thx, done :)


all tests pass:
success: http://buildbot.bos1/builders/test-riak_ql/builds/72


I think the "_may_qualify_for_affordable_warmth_obligation.govspeak.erb" partial should've been added as part of the previous commit.


Same as 'News' project - this must return something and not 'void'


To udlændinge, amerikanske Tyler og en islænding, spiste med, men blev ikke bogført. Derfor skal dette commit rettes.


Why is this 'mContext' and 'jsonArrayData' required?


As far as I can tell, these changes shouldn't change any of current results from other projects, because they were all using the values of a_p1, a_p2 returned from the hyper-parameterisation function, which overrode the defaults.


Thorkil Værge <notifications@github.com> writes:

> To udlændinge, amerikanske Tyler og en islænding, spiste med, men blev ikke bogført. Derfor skal dette commit rettes.

Det har du min tilladelse til at gøre.

--
\  Troels
/\ Henriksen


What's "CS" stand for in "CS point of view" in the commit note?


yup, looks like that to me.


@r4vi that did cross my mind but hopefully this wont have to change again :smile:


why is this not private static final String
a static final variable is a constant and it should be in all caps. lets rename to:
'QUANDL_EXCHANGE_RATE_ENDPOINT'


Fixes #310


We don't need these lists,
we should define appropriate java types (classes) to store this data.


Ja, de wiskunde lessen komen weer terug spoken in mijn hoofd. ^ ^
Ik ben met de tool uitgegaan van, hoe automatiseer ik wat mijn gebruiker nu met een rekenmachine doet. In plaats van, wat doet mijn gebruiker, uitzoeken hoe je dat (goed) doet, en dan hoe automatiseer ik Dat.

Ik heb wou gaan googlen hoe je een percentage berekend als je het originele bedrag niet weet, maar ik wist niet goed hoe ik dat moest formuleren. Dus ik heb gegoogled hoe je btw berekend, ik ben niet de enige die zo'n tool heeft gemaakt, dus ik heb via 'inspect element' gekeken hoe zij de berekening maakte, gecheckt, en de berekening overgenomen in mijn tool :)


Du glömde en titel


Solves issue https://github.com/ErasmusMC-Bioinformatics/edger_galaxy_wrapper/issues/1


Shouldn't we throw an exception when a table contains ``null`` values, but the column has a non-optional type?


I would suggest a much larger buffer size -- say 16KiB. The chances are the OS buffer is at least 4KiB big.


Why is Dao updating the labelsDashboard?

and whatever that DashboardDao is - why is it a Dao?


Должно быть вот так
```php
"action" => $this->generateUrl("book_create")
```


I think it's OK to modify the tests as you are doing. In theory it's cleaner to have each test check one thing, hence we should have separate ones for "Gerrit" and for "Gerrit with non-ascii", but:

* The testsuite is already a bit slow, minimizing the number of tests helps keeping it not-too-slow
* There's nothing really fancy in GerritEnvironment, so we're unlikely to see a breakage that would be hard to debug because of non-ascii characters.

That said, I'd keep one call with accents and one without, to check that we still work with pure-ascii. My test changed the first line, it would actually have been better to change the second (to test simple things first).

Can you send a PR with this test and the fix (iterating over strings fields of `options` or a predefined list of fields to recode)?

Thanks,


Why not make this `while len(open_fds) > 0`? With that you can remove the condition at the end of the `while` loop.


This can potentially be removed (see above comment).


This change was made due to certain demands imposed by printing/alephprint. It introduces the need for a slightly different template for html emails, because these won't work with absolute paths without a host.


If `wait` didn't succeed, will it throw an exception? I kinda doubt that Python will ever let `returncode` be `None` (but I might be wrong).


I see that you check the output length internally in do_mmap_info. Looking at the code I don't see you reading from the udata anywhere, so you can check that the input length is zero. If I missed something you do read then check the length is that.


So it's already expired?


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.457.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62449&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:25:53


Don't store the udata pointer. The pointer itself points to the uverbs stack. The buffer it points to belongs to the user, and after the command returns to the user, they are free to change its content. If you must, make a copy of the content of the udata.


Computer Science :dancer:


Okay.


Принял.


Thank you!

It must be better now

On Tue, Sep 1, 2015 at 1:03 PM, Antoine Pultier <notifications@github.com>
wrote:

> Also, if (Number.isInteger) returns always true because you do not call
> the method but check the existence of the method.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dapaas/grafterizer/commit/da94c3c9a5e1b2325d0f92fedfe2be9757e1d390#commitcomment-12996025>
> .
>

--
*Regards*,Dina


Asserts is considered a bad practice atleast in java - although it can help during development.
Read this for more info: http://programmers.stackexchange.com/a/137163

also think of what happens when labels is null? What happens when an assertion fails? - Application crash? Error reported to user? if an error is reported, what error is reported.

Exception handling is one of the very very important aspects of Programming/Software development - Proper exception message can help you debug the problem.


Maybe add some more asserts, like "Test input" in returned description?


Почему здесь сразу ```php flush``` ?


@abonas ding


fast-forwarding develop to borshop-integration-15-rts252_binary_field_names = 30b92f23


What exceptions are you handling here?
do you know even a ClassCastException will be swallowed here? - should you log and error? - what do you want to return when there is exception.


I think, personally, that we don't need to mention about Fedora on Arduino boards. Otherwise we should describe a bit how to do it. At least as a reference


Нужно использовать camelCase, т.е. должно быть так:
```php
$deleteForm = ...
```


Please come up with some other name for input - it's a build-in in Python.. ;)
maybe simply bp_input ?


For use of volley we can come-up with a better app - for this app, I don't think we need async call-backs.


What is the exact scenario when the task is run twice concurrently? Checking the queue length without any locks to make sure no other task is running doesn't sound right to me.


Hi! Nice to see you on GitHub. If you have plans to develop SWAPY further, I would like to invite you to our team: https://github.com/pywinauto

We have SWAPY repo imported from Google Code with full commits history. Wiki markdown is also imported at separate branch: https://github.com/pywinauto/swapy/tree/wiki
We have still changed nothing in SWAPY although there are some thoughts.

BTW, mid-term plans include UI Automation API support in pywinauto.


remove these two methods in favor or above methods return types.


Correct, thank you for seeing it :+1:
I fix this asap


We handle the rpi2 flaqgs from retropie - so this is not needed.

I would like to see the other C flaqgs actually make a difference too - from my testing they didn't (did you check gcc -Q --help=optimizers - to make sure what is set and not set) ?


Why is this not private final?


Ce n'est pas une solution !
Cette élément n'a pas besoin d'être en flotaison..
Il faut clearfixer les élement au dessus (programmation) pour corriger le bug
Il faut mettre un

 juste après la


Кривые отступы, 4 пробела, а должен быть TAB


do  we need this? we can call the Dao if these are needed.


Perhaps you already answered this somewhere else, and I forgot, but why not have a single socket for all QPs?


Хм, а ```Assert`` по коду нигде не используется. Он точно здесь нужен?


Sure, will move it to utils!


Hi @BohdanTkachenko can you publish this change to npm? Thanks


When we started development we froze all our dependencies so we are sticking to our older version, with minor addition and changes where we really need them. We are not going to switch to a new version for now.


@xiaojun1604 Right, then I'm not sure where the difference comes from. The computation code was written by HandCircus and as far as I can tell the math is similar to the theoretical values Unity Editor displays for a texture. So you should probably treat the values as theoretical.


Okay, please add it to the TODO file.


Instead of OS I would like to use a system. OS could be Windows, iOS. E.g Red Hat and Fedora releases?


Добавились файлики `*.php~`, этого происходить не должно.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8107/testReport/) for this commit**


Could I request you create a pull request for this so I can merge?


Ups!


Shouldn't it be within `modules` https://github.com/ncjones/editorconfig-eclipse/blob/master/pom.xml#L14-L18


semi-colon not required at end of namespace. iirc this causes a compiler warning in some compilers. In this case, if there's no warning from clang and everything works, it is probably fine!


strictly speaking, should be `BasicString( const char* )'` (no whitespace between `BasicString` and `(`, but as this is a test file, probably not the most important thing!


LGTM


This is a pretty nice document at all. It helps a begin packagers. Cool and thanks.
It contains all thinks from scratch to repository.


See these:
http://www.oracle.com/technetwork/java/codeconventions-135099.html
http://stackoverflow.com/questions/16537620/class-name-convention-in-java

Class names should be nouns, in mixed case with the first letter of each internal word capitalized. Try to keep your class names simple and descriptive. Use whole words-avoid acronyms and abbreviations (unless the abbreviation is much more widely used than the long form, such as URL or HTML).

This class must actually be 'QuandlCurrencyDao' and interface must be 'CurrencyDao'

Quandl is very specific implementations - lets say, they shutdown their website, you can still write a new implementation for 'CurrencyDao' interface.


haha


Ha :-) I'd assumed it was something to do with overseas passports.


should be GoldDao - use correct return types.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.458.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62453&buildTypeId=bt323) outcome was **FAILURE**
Summary: Tests failed: 130 (130 new), passed: 732, ignored: 54 Build time: 00:12:17
### Failed tests
```
LibChorus.Tests.dll: LibChorus.Tests.FileHandlers.image.ImageFileTypeHandlerTests.LargeFilesWithSupportedExtension_ShouldNotBeInRepo: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.sync.UsbRepositorySourceTests.SyncNow_AlreadySetupFauxUsbAvailable_UsbGetsSync: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.sync.UsbRepositorySourceTests.SyncNow_OnlyABlankFauxUsbAvailable_UsbGetsClone: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.sync.UsbRepositorySourceTests.SyncNow_UsbGetsBackwardCompatibleBareCloneWithReadme: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.VcsDrivers.Mercurial.FilesInRevisionTests.GetFilesInRevision_MultipleRevisionsInRepo_GivesCorrectFiles: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.VcsDrivers.Mercurial.FilesInRevisionTests.GetFilesInRevision_OnlyOneRevisionInRepo_GivesAllFiles: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.VcsDrivers.Mercurial.HgResumeTransportTests.Clone_LocalRepoEmpty_ReposAreIdentical: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.VcsDrivers.Mercurial.HgResumeTransportTests.Pull_BundleInMultipleChunks_Success: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.VcsDrivers.Mercurial.HgResumeTransportTests.Pull_BundleInOneChunk_Success: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.VcsDrivers.Mercurial.HgResumeTransportTests.Pull_GetRevisionServerResponseServerNotAvailable_NotAvailableMessageAndFails: <no details avaliable>

LibChorus.Tests.dll: LibChorus.Tests.VcsDrivers.Mercurial.HgResumeTransportTests.Pull_InitialServerResponseServerNotAvailable_NotAvailableMessage: <no details avaliable>

##### there are 120 more failed tests, see build details
```


Makes sense. It's not like there is many things going on anyway.
Maybe this commit would interest you, improves Vector performance a bit: https://github.com/d-gamedev-team/gfm/commit/4197a510d1c6fdfbf734bedcf65cb08a446be614


Please use <> instead of "" for external headers
Also, if possible, please keep tiff/ folder in the include statement, which is generally more clear, especially if sometimes we have to add other headers that do not have the tiff suffix in the name


this must be javaDocs -
/**
 * This content will be available when hovered over the method.
 */


`href="../show/{{ id }}"` очень непривычно, лучше так не делать. Плюс лучше не отталкиваться от структуры url. Лучше генерить.


we don't need these lists, we can call Dao when required.


Will do.


@donho  , I've just find a regression (it was supported on my original  PR)
I created an issue and pushed a PR  #830 #831


Overall, who are you doing this app for?
Did you get the Design/UI reviewed? by sharing screen-shots (or) the APK file?


Кривой отступ


Not in WildFly. The GWT module used for EAP still has the IE8 permutation.


Пересмотрю туториал.


LOL


Ok.


This revision is clean.


It's done.
It's my first experiencie with a pull request. Do i need repeat the pull
request?

Thanks.

On Mon, Aug 31, 2015 at 12:51 PM, Jason Turim <notifications@github.com>
wrote:

> Can you clean up the formatting of this code
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rburone/lvlDragDrop/commit/77f2f2984cc7d40c9a010c973545f410b8e0ea23#commitcomment-12979193>
> .
>

--

Ricardo
Daniel
Burone

rdburone@gmail.com


Hi It is a superb proposition.
Now I am moving SWAPY's UI from WX to Tkiner.
You will not believe it but I am also planning add MS UI Automation basen on this prog - https://github.com/zerg-rush/pyuiautomation
Amazing, but it works easily with python(even faster than pywinauto).
Accepting your prop, believe together we make UI automation easier.


efefewfewfwef


вамым


As there are two options here, please split up the documentation to show explicitly what is and is not allowed for each option


@bognix no need for extra brackets - just `new Object().toString();`


Will change to <>
Cannot keep tiff/X since ${TIFF_INCLUDE_DIR} is already pointing to the right path.
=> See https://github.com/cdcseacave/openMVS/blob/develop/libs/IO/ImageJPG.cpp#L19, it's the same case, already pointing to include/jpeg...


А как же:
```
   /**
	* @ORM\Column(type="string", length=150)
	*
	* @Assert\NotBlank()
	* @Assert\Length(min=2)
	*/
	protected $title;

	/**
	* @ORM\Column(type="text")
	*
	* @Assert\NotBlank()
	* @Assert\Length(min=5, max=500)
	*/
	protected $description;

	/**
	* @ORM\Column(type="integer")
	*
	* @Assert\NotBlank()
	* @Assert\Type(type="integer")
	* @Assert\GreaterThan(value=0)
	*/
	protected $pages;
```
?


sasd
sadsa
d
as
ds
das


В боевом коде никогда не используй DQL/SQL в контроллерах. Для DQL/SQL есть класс репозитория. Для каждого нетипичного запроса делай отдельный метод и там пиши DQL/SQL. Для справки: там уже есть find(), findOne(), findAll(), findOneBy(), findBy() и всякие такие часто используемые запросы.


Is there a trailing newline on this file? I can't tell with GitHub's interface


Salidas: Menú actualizado en la pantalla del Oculus


"Не должно" - имеется в виду: в репозиторий не должны падать бэкапы файлов?


I haven't included it in the main build because it's too slow. The readme describes how to run the functional test suite. Are there any specific issues you are experiencing?


¿De verdad podríamos llegar a esta condición?


java.util.Map does not implement Serializable but some implementations do.
To comply with the rule, we must declare the type of concrete (like HashMap, TreeMap, ...).
By doing this, we violate rule S1319.


Объект для обработки xml файлов


I would say that it would be useful, yes. The one that would definitely be good to be able to set with a colour picker would be Offset, but I think it'd be a good guideline for all colour-based plugs to be Color3f


Sure, I'll change that. :)


> Just curious, is this cleanup only for test purpose, or it might be used in somewhere? Because I can't think of any scenario we'll really need to clean up all the BCs.

Yeah, it's just for tests and I'm not proud of this :( Will think if I can avoid that.

> BTW, it's also another small question about requesting mobileMessageClient, Although we will not really establish the client if it's existed already, is it really necessary to checking the client existence every time while calling shim method? Since BC is unlikely to be affected by other BC's once we have appInstanceId here. Or the another though: If we will check/establish client while calling shim method, do we still need appInstanceId?

Well, if I understood your question correctly: we use ```MozMobileMessageClient.forApp``` in service that is hosted inside SharedWorker, so it's shared between two app instances. Every instance can call any of the service methods at the same time. So we have:
```
window1--(unique MessageChannel)-->SharedWorker--(window1 bound BC)-->iframe_inside_window1;

window2--(unique MessageChannel)-->SharedWorker--(window2 bound BC)-->iframe_inside_window2;

```

So we have one SharedWorker service with 2 simultaneously connected clients and when window1 requests some data, SharedWorker service should request this data from iframe_inside_window1 - that's why SharedWorker service maintains two connections to different iframes and should choose which shim client to use. So if window1 dies together with iframe_inside_window1, then window2 continues to use SharedWorker-->iframe_inside_window2 connection.

What is your proposal?


I think it should not. withFilter call should be followed by map, flatMap or foreach. It's a good idea for another inspection though. I created an issue:
https://youtrack.jetbrains.com/issue/SCL-9107


Zapytanie zbudowane jest poprawnie. Chodzi mi tylko o to, że nie ma potrzeby używania operatorów zakresu dla interfejsów, w interfejsach wszystko jest publiczne.


Actually, yes it is json. See `stringEncode` above; It's using a standard json_encode method for this. It just so happens it looks a lot SIMILAR to php arrays. :)


¿Para que se utiliza el Trim?


`@JsonIgnore` - ok, ale unikajmy definicji kolumny w bazie danych, zmienimy silnik i może nie być to kompatybilne.


El botón es B


`is part of` -> is an ECMAScript 2016 (ES7) proposal.


I mean str.format.("Loop-condition %s ...", repeatCondition).


@niktrop okay, I remove this test


Вот так? ``Show created product``


Bardziej tutaj chodzi o to, abyśmy wiedzieli co jest zwracane, nie są to na tyle skomplikowane obiekty, aby tego nie ustalić.


Si esto no se logro hacer funcionar, hay que borrarlo.


fondo*


As a minimalist sample, I think this works fine. You could expand it to also cover an example of how this pattern was handled in ES5. i.e what is mentioned in the Motivations section over on https://github.com/tc39/Array.prototype.includes#motivation. This would let you show the before/after view of what this gives you.


¿Esto no provoca que los menús se salgan de la pantalla al ir navegando?


Może tyle wystarczy: http://stackoverflow.com/questions/12166956/understanding-jodatime-datetime-parsestring-formatter


da sollte definitiv nicht Informatik 1 stehen. vgl. 7e96432f8226345d7b6e32f1e2dd0c347d7cf55b


7.4a.001から7.4までのurlが直っていませんね。


thx


Нет. Так не взлетает.
```
An exception has been thrown during the rendering of a template ("Some mandatory parameters are missing ("id") to generate a URL for route "ProductBundle_product_show".") in ProductBundle:Product:created.html.twig
```


The unit is not specified. It looks like it is MB, but it should be explicit.


I still don't see an implementation for `fail`


Yes thank you it's better. I had to made few changes to make jshint happy though but it was better :)


Hi Josh,

My bad, I ddin't pay attention to your comment. I have updated the code using the IViewModelFactory instead of the IModelFactory.
please review the code.


I am new in GitHub, it seems like you should add me to the team pywinauto


Good job! Very subtle fix.


Эти моменты уже ускользают от меня и начинанется магия.
``DQL/SQL`` - это про ``$em->createQueryBuilder()``?


So a user who copies and pastes will succeed ...


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1289 of 1289 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-69.98%25-green.svg)


Это можно заменить на
```php
if (!empty(...))
```


Ah — smart! I'll review that soon. Thanks for the quick response.


AllowOverride All  should not be needed but "DirectoryIndex index.php" should be added


Thanks! 直しました。


Students/Bologa M. Marius - Vasile/Zoowsome/src/javasmmr/zoowsome/controllers/MainController.java

I am very curious what this statement is supposed to do!


@JKE-be thanks for pointing that out! I had misunderstood these decorators.


It's a honor. Thanks @akhilnarang


101789044_gridviewFilters (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2306 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.42%25-yellow.svg)


Your `load()` method returns an array list. In order to use what is returned, you should be doing:
`List<Animal> animalList = abstractAnimalRepository.load();` - simple as that


<code>@Column(...)</code> to nie moje dzieło.


Can you replace `<->` with some better description and add `BETTER` keyword to the bullet point? Thanks


fixed. ee3ecf70f5111bb394fab395c34bdda2fffd0c05


skype: wowb-zone @danqu


Or you could save yourself a lot of effort by
```ooc
getSliceInto: func ~indices (start, end: Int, buffer: This<T>@) {
    this getSliceInto(start .. end, buffer)
}


why moving the tray icon?
it creates multiple tray icons on my system


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


I would strongly recommend doing a release using the older core baseline which includes #58, as this seems to be a critical fix for many users. You can always bump up to a latest-and-greatest core baseline for subsequent releases.


limitForm -> LimitsForm


Что за юмор с минусом?


Писать без {} можно, но не принято.


вопрос снят.


а ты уверен, что это случайные числа у тебя? посмотри в дебагере что оно складывает.
И почитай каким образом получать псевдослучайные числа. (идея была правильная)


typeof checkedLimit


This PR works for me!


¿Por qué Larry y no Harry?


придумай условие цикла, чтобы не было if


add a fixme ? Why is it a pointer ?


опять же не подходит... ты удаляешь подряд... это хорошо будет и легко проходить для некоторых реализаций, но не правильно.
Тут тебе нужно подумать и так же удалять случайный индекс в мапе, подумай как. (почитай про оператор остатка от деления)


```criteriaValue.length === 0 || !criteriaValue``` -> ```!criteriaValue || criteriaValue.length === 0```


Thank you


:)) опять же не честно, нужны случайные числа


Should this method be public maybe? Would a user care to know if it was enabled or is it an implementation detail?

Also, this method takes an `IViewModel` object as an argument but doesn't appear to actually _use_ it. Instead, this method is referencing the instance field `contentData`. Ideally this and the other private methods should be made `static` with no references to instance fields/properties/methods.

Lastly, what do you do if `model.ModelData` _isn't_ `IEmbeddedFields`?


применяй автоматическое форматирование предварительно к файлу.


clonePolicy -> clonedPolicy


Смысла делать так нет. Скорее всего конструктор вызывается и тогда когда ты вытаскиваешь из базы. То есть $dateCreated будет меняться.


This seems wrong, we already do this a few lines above.


Oh disregard this please! I see that it's been updated in the next commit... my bad


I think @laugre is the chosen one for this task as he made the Websocket plugin.


single quotes


@ahmedaljazzar FYKI


I don't know if this was the intended result, but please revert the multiple icons.
We don't want one tray icon per window, that is abusing screen real estate


Дополнительный вопрос, посмотреть реализацию в нескольких мапах и рассказать как оно сделано внутри и почему так быстро работает :)


FYKI @ahmedaljazzar


Looks like this commit introduced a timeout on mono/tests.
https://jenkins.mono-project.com/job/test-mono-mainline/label=debian-amd64/2347/console

I did run it on my end and this is the original timeout error:
```
running tests timed out:

436
delegate2.exe
=============== delegate2.exe.stdout ===============
Test.F from delegate: 1
Async Callback STATE1
received exception ... OK

=============== EOF ===============
=============== delegate2.exe.stderr ===============

=============== EOF ===============
```


What about PLAYER_FIELD_MOD_TARGET_RESISTANCE / SPELL_AURA_MOD_TARGET_RESISTANCE?=


I don't like this change. What happens when you log group guids? this just makes it more complicated to check logs imho. They only place that you should like to know the roles is just when the compatibility for roles is checked and it is already logged when those are not compatible. "Guids: (%s) Roles not compatible%s" <--- with the list of guid:roles of all members being checked.


ferferf
r
f
erf
re
f
erfre


Ooops! I just pushed a fix, thanks!


@ipernet - if you find time, could you test this latest on Android and Firefox on Win? Thanks.


Error: cannot initialize plugin labels
Traceback (most recent call last):
  File "/home/voegtlin/electrum/lib/plugins.py", line 90, in init_plugins
    p = loader(name)
  File "/home/voegtlin/electrum/lib/plugins.py", line 58, in <lambda>
    loader = lambda name: imp.load_source('electrum_plugins.' + name, os.path.join(pathname, name + '.py'))
  File "/home/voegtlin/electrum/plugins/labels.py", line 23, in <module>
    from electrum_gui.qt import HelpButton, EnterButton
ImportError: cannot import name HelpButton


Use the method parameter `model.ModelData` and not the instance field `contentModel` _OR_ simply remove the `IViewModel` parameter from the method signature since it's not actually being used to return a result.


ATTENTION!
This feature require modification to iis config file: "ELib\.vs\config\applicationhost.config" :
Add next lines to section "sites/ site(name="Elib.WEb(1)") /application "  like on this image:
![screenshot_1](https://cloud.githubusercontent.com/assets/13640378/9603931/9da07954-50bc-11e5-860b-fffe2eb8b226.png)


:point_right:  :door:


Testing +2


add new line


Sorry, my bad.


Something like `@EventHandler` or `@EventListener` sounds better to me


A general comment — we should consider making all the "helper" private methods `static` per MS recommendations. Of course this is a rather minor improvement, so its low on the priorities.


Testing


De ce nu check-ui daca is definite variabilele astea, iar daca nu, sa exit-ui scriptul cu o eroare.


Use the method parameter model.ModelData and not the instance field contentModel OR simply remove the IViewModel parameter from the method signature since it's not actually being used to return a result.


this if can be greatly improved


Done.


The condition is defined in benchmark configuration in a structured way... no, I don't think it should be logged here.


Only to bad he doesnt tell you how he got it all, these little children steal and dont give proper credits to
the real devs. Thats why he's happy you pulled his commit and not from aicp or other source where brett rogers and me pushed it to. All other devs removed siracuervo his commit as he stole alot of the code from me and brett rogers. also its less complete then our code. We've spend many hours on this, and he want to take credit for it. if you want proof look at aicp source, or i will give you access to our private repo.
So dont be happy there are people like him who share their stolen work.

Best regards,
BlackDragon


rferferf
er
f
erfer


Sorry! the game was in revision in amazon, now it's online

2015-08-31 18:25 GMT-03:00 Nilsen Filc <notifications@github.com>:

> first link doesnt work, please update (
> http://www.amazon.com/gp/product/B014Q1O43C)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/joackobengochea/openfl.org/commit/de5a7d319f9d0e5cc7ef561b34b2ad85cddd4b7e#commitcomment-12985828>
> .
>


pai de ce nu folosesti `os_RELEASE` si `os_UPDATE`,m care sunt deja definite si popiulate? Paractic faci verificarea de distributie din nou ... Uitete la linia 130...