 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


No space after `:` please.


some times we need to make changes


I think there should be a break in success case


The same here.


If it's important to performance, you may use short statement and provide multi-line for loop in the comments to show which statements are equivalent.


Success case should have a  break.


I've read the post on Ragezone, the problem is 4 bilion troops bug, but why split the variable in 5 variables and then reassemble them into a single variable? Sorry for my bad english


could you tell my why you are doing this?


TODO: refactor

  1- case class instead of (String, String)
  2- override toString
  3- use mkString on the collection


My old photos can't load from your new method,beacuse the path not correct。
in front of a default


@Christopher83 should we use vfp instead of neon in here? not sure but ı heard neon is also enabling vfp thats why ı used neon...


Thanks! Updated in German as well!


Guys it my bad I'll get it fix


Yea, I just discussed that with peter and proposed to make a demo to evaluate it.
I just found one thing that we would be missing with this logik.
How would we be able to make selection state based modification
like adding a class with this approach?

@peter Is that still possible?
@OrKoN do you see issues with this?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20180/testReport/) for this commit**


Minor: Now that there are more than 2 possibilities, I wonder whether a case statement would be clearer/terser here...?


A more elegant solution would be blacklisting.  For example for my software [relax](http://www.nmr-relax.com), here is the blacklisting of a test:

http://www.nmr-relax.com/api/3.3/test_suite.gui_tests.general.General-class.html ([Python source code](http://www.nmr-relax.com/api/3.3/test_suite.gui_tests.general-pysrc.html#General.__init__)).

And the skipping framework:

http://www.nmr-relax.com/api/3.3/test_suite.relax_test_loader.RelaxTestLoader-class.html ([Python source code](http://www.nmr-relax.com/api/3.3/test_suite.relax_test_loader-pysrc.html#RelaxTestLoader.loadTestsFromTestCase)).

The licence is GPL3, so unfortunately the infrastructure cannot be copied.  It may be a little too much for the current git-multimail unit tests for now.


ZigBeeNodeImpl -> ZigBeeNode ?
to be consistent with other methods


- generic a tag styling removed and styled by class.


no case for `class \Ilowercase`?


GetBoolArg sounds expensive for something called as often as AcceptTo*


this change isnt tested yet by me so @K_TECH and @nilac8991 can you guys test this change if possible please?
not sure but this shouldnt break anything


это что еще за херота? :)


same change can be applied on ariesve as well


It would be better in terms of efficiency because it would avoid an IPC call to telephony, but otherwise the API works fine in read-only mode for guests or non-owners, it will only fail when writing.


Curious. I wonder if I need to do something special to indicate that it's a command line program and should no be detached from the shell. Thanks, I'll investigate further tomorrow.


ACK :+1:


discovered -> updated


Not yet, but I guess this will eventually come when I run into this case while converting code from ceylon-ide-eclipse ;)

> Le 7 sept. 2015 à 15:40, Lucas Werkmeister <notifications@github.com> a écrit :
>
> no case for class \Ilowercase?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ceylon/ceylon.tool.converter.java2ceylon/commit/09aba83e2a82bc89a68e9c10ae5f922494d4f10c#commitcomment-13097244>.
>


It's funny because this cron job didn't even --force ? :p
just noticed this


Why cannot it be set?


I have discussed this with @vanthome over skype, and we agreed that I'll try to make the `select` component based on this (on a branch) and we will see how this behaves / if it makes sense to migrate from the mixin to this component.


Thanks you, I will use `==` instead of `!=` :+1:


Ah didn't see your answer ;)
@vanthome hmm you think adding some other information besides "true/false" right?


Thanks! I'll have to look into to-vfile.

I just use replace because it's clearer to me that I'm removing the period.


they are rejected.


Oh, nice. I'll update this. Thanks!


To Create "Campaign View" Test case Please review "ViewDetailsPage" and "ViewFormPage", you should extend your "View campaign" pages from those, because those already have behavior


Minor: Maybe use a case statement?


__used is define local the pkg project.  Its used in quite a few different places.  Maybe you are thinking of __attribute__ ((unused)), which is what __used expands to under gcc.


How is this related to $subject ?


please make this localizable with __() function; textdomain is ADVADS_SLUG constant


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 533](https://teamcity.labkey.org/viewLog.html?buildId=270604&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30 (2 new), passed: 9 Build time: 00:22:42
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

##### there are 20 more failed tests, see build details
```


Thank you. This looks great. I had GameRequestDialog in my TODO list. I will check it and then merge.


Propose.


Random 함수 오류 수정전.


true/false would be enough, but I must be able to get this state in the sub-component and I don't see how this is possible if you keep the selected ones in a separate list.

@piotrpalek


I don’t mind if you change something in other files too, but please make a different commit so that I can see which issues are related to each other


I added more tests in my branch that are going to make this new code fails, please rebase

```haskell
it "doesn't allow more than one allowed value at the time" $
        recommendations (Map.fromList [("PermitRootLogin", [["no"], ["without-password"]])])
          (Map.fromList [("PermitRootLogin", ["no", "without-password"])])
          `shouldBe` ["permitrootlogin should be [[\"no\"],[\"without-password\"]], found [[\"no\",\"without-password\"]]"]
```


This is a side effect of disabling IPv6. The default entry is "inet_interfaces = localhost", which includes ::1, so postfix will try to bind to the IPv6 interface and fail to start if we do not change the config file.


Everything I read on security is how to not allow hackers to do bad things - once they get in.  I never hear anything, and maybe I'm off base, putting a Bouncer at the front door.  IE.  SSH only allowed by a small list of IP's (very small).  My system(s) do NOT contain the words: admin, wp-[xxxxx], home, pass, etc.  When my web server detects any banned word - Oh look someone is attempt to hack the system - append "deny from x.x.x.x to .htaccess and 'tarpit'.  And a couple of other "no the Dallas pizza shop doesn't take delivery orders from Moscow (firewall) ...


Hi guys, you renamed run.exe to DisableWinTracking.exe, but didn't change it in Intstruction section, i still can see there run.exe


@tinevez This is based on git commit history... Is this correct?


In TV, "$NAME" is used as placeholder instead of "$C". The scroll speed of the text could be faster. Twice as fast to be precise. It feels kinda slow. Or is it just me… (?)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.582](http://teamcity.monogame.net/viewLog.html?buildId=10105&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8292/testReport/) for this commit**


twas a typo, try again (also this is older code)


Do you mean something like this? https://github.com/ember-vcl/meta-list/blob/master/demo/example/application.hbs#L6


I get a recursive load error when starting up Emacs… I'm guessing this is because this line is run at load time, and invokes `org-journal-format-string->regex` which is autoloaded but defined further in the file ?


According [documentation](http://docs.spring.io/spring/docs/current/spring-framework-reference/html/mvc.html#mvc-ann-modelattrib-method-args) looks like it is expected behavior


I am against the duplication of code, too but.
I do not see easy way to reuse the code. On the one hand we should be able to find a window having only `application` instance (at the beginning). On the other hand when running `window.IsActive` we have no link to the `application` instance. So we cannot run something like this `window.app.active_`. Moving the code to `handleprops.py` also not a good idea, since `application.active_` uses `find_windows` method


I have been thinking and will continue doing so... maybe create a bikeshed issue for it


`--strip` will remove debug information from the resulting binaries on `darwin` and `linux` systems.


discovered -> updated


I'm not sure this is necessary. When I added the `get_due` method in aa12b9d5ac5a6e37c68a98fd06bf298be14d5c1a, I also added the ability to update the `is_funded` and `due` fields of the `payment_instructions` table via the `current_payment_instructions` view (reusing a pattern from the old `current_tips` view). It doesn't reset `due` (or `is_funded` on non-current payment instructions, but that's not strictly necessary anyway (right?).


If this only creates ssl_setup.sh, there could be also README.txt left in /root, describing remaining manual steps?


It wouldn't change to anything else.

You should also double check the behavior of nano proto to the default keyword. I remember for normal protos, default values are not stored in the proto, but implemented in the getter only. I suspect nano proto might not even support the default keyword given it doesn't output getters by default...


This will default to downloading the binary from GitHub. If no binary could be found (which is the case right now) it will fallback to compile.


Fixed


We will almost never change this.


Why? The message is just sent to the authenticating player if cancelled?


**Eslint**: 'return' outside of function


**valid-jsdoc**: Missing JSDoc @returns for function.


@Toke this is a rough 1st go at increasing debug output and directing it somewhere where we know to find it later (I believe this might be helpful if we ever get this into another distribution with different logging than openwrt). The next step I want to include is redirect all additional normally silenced command output conditionally into the same log file.


- theme updated to latest v2 hotgraphic changes.
- icon width and height updated - should remain as just variables to stay consistent with other elements using icon variables.


Good spacing, and followign coding style!


`@return self` + `return new static` It looks wierd (just sayin').


@Vincent-Michael

I'm trying to backport this table structure change from 6.x to 3.3.5, but I don't understand how the old field 'id' is replaced by the 2 new fields 'BlobIndex' and 'Idx1'. Can you explain that?


@piotrpalek

Exactly. If that is possible and potentially also for multiple items, I'm fine with this approach.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20181/testReport/) for this commit**


I've cleaned this up a little.  This file seems to be written in the ansi C so we all declarations must be at the top of the function, right?


I've cleaned this up.


Hmm i don't know, i'm building right now the last release of RR for ancora


I went back and checked: our test suite does exercise this functionality:

 - Modify `update_payment_instruction()` to return early or otherwise not do its work.
 - `make test-schema`
 - Run the `test_billing_payday.py` tests.

I see three failures.


Pro!


@maxsite спасибо за добавление ссылки на MaxHub!

Может имеет смысл добавить ссылку ещё в виджет «Ссылки» на официальном сайте движка? Такое чувство, что народ просто не замечает, что есть удобный архив плагинов и место для задания глупых вопросов...


http://www.nooooooooooooooo.com/

Basename должен быть без указания локали :)


You should also pull https://github.com/KappaAnalysis/KappaTools/commit/3737ca669de50ce833d7463f00cd5550bd42ef3e.


Minor (subjective): I'm not convinced about the indenting of `locals:` or spreading its value out over 3 lines. I feel marginally more strongly about the latter than the former. I'd probably write:

```erb
      <%= render partial: "three_day_residency_requirement.govspeak.erb",
            locals: { country_name_lowercase_prefix: country_name_lowercase_prefix } -%>
```

Are there some Rubocop constraints at work here?

If you do change this, remember that there are quite a few occurrences that would also need changing.


Correct the code style mistakes and send another PR.
- line 31 in `arrays.php`
- line 10 in `array_function.php`
- clear empty lines 84 to 117 in `array_function.php`


Oh! This is in `Participant.set_payment_instruction`, and not during payday.


Thank you.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20182/testReport/) for this commit**


Your pull request has been merged.


Is there a need to treat these as one?

I'm not entirely convinced having a double Get call cause an error is a good idea.


Minor: I can see why you've done it, but it looks slightly odd to have the `You can then book an appointment...` sentence on the same line as the closing ERB tag.


I must concur!


I wasn't sure how clearly this classifies as a "bug" and how as a "UX improvement". And it introduces slight changes to the API (although improbable to break anything). If it wasn't for that, I would backport it immediately.


Why define check here and then call it when you could just call the function directly with the parameter?

self.python_output_is_same_as_javascript(testfile=prefix + filename)

?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20183/testReport/) for this commit**


This change is causing latest Emacs (built from commit 066b26d6c47d1384d5ed3ce09c6379a9df350256) to start with a warning message:

Warning (bytecomp): reference to free variable ‘rectangle-mark-mode’


@vanthome it is possible (just as shown in the example), btw. the demo is working so you can also test it locally if you want.

The things to keep in mind are that this component only stores true/false information on the meta object. So we can add multiple arrays, let's say `meta: { selected: [...], active: [...] }` and the attributes will be available on the yielded `meta` property as `meta.selected` and `meta.active` with values `true` or `false` (depending on if the items are in the arrays or not). And I am not sure if/how I could extend it to store some more complex information (for eg. objects) but I also didn't think about that case yet.

Also the 2nd thing is for now the _whole_ meta object must be replaced, otherwise the list isn't recomputed with the new values. So for now you can't do something like:
```
this.get('metaObject.selected').pushObject(1)
```
Instead you have to do:
```
this.set('metaObject',  { selected: [1] })
```
But I think that can be fixed by adding array observers and running `notifyPropertyChange` when the arrays change.


Хаха)) классная ссылка. Я кажется понял суть. В след. раз пристрели меня если ошибусь )


Minor (unrelated to change): Should this say "3 full *working* days"? Also the example seems surprising to me i.e. if you arrive on Thursday and post notice on the following Monday, it feels as if you will only have been in the country for one *full* working days i.e. if you arrived on Thursday one assumes you didn't arrive at midnight and one assumes you would need to post notice before the end of Monday. Thus only Friday would be a *full* day in my book!


cc1plus: warning: command line option '-Wno-pointer-sign' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wno-pointer-sign' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wno-pointer-sign' is valid for C/ObjC but not for C++
cc1plus: warning: command line option '-Wmissing-prototypes' is valid for C/ObjC but not for C++
please fix bug


No está suficientemente testeado. Tampoco has modificado el README.md.
Reject :D


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20184/testReport/) for this commit**


It makes sense, yes. I'll fix it asap.


Thanks for adding those! It's great to see those!

I was wondering if ZDaemon Dehacked Extensions could be added either? Those were existing either in older zdoom versions and who knows where else.
There are Heretic and Hexen codepointers and some specific ones.

There is some DeHackEd sample showing how long those lists can get : http://pastebin.com/MaZ1GAQk


A good point, to my shame I just copied the generated test case.  These test classes were only intended to be ephemeral as the tests therein are included within the `SampleCCDATests` so I could fix a specific issue without waiting 160s to see the outcome


class


is there a reason, why not enabling the redirects for all ip addresses (by omitting the `-d` flags)?

I am creating ssh tunnels into some of my machines for exposing them on my developer machine for easier consumption, but by restricting the ports to `${HOST_IP}` and `${KEEPALIVED_VIP}` doesn't work for port `80` and `81` with the ssh tunnels... :-(

if I remove the `-d` flag it works as expected...


*here


The faction change is wrong, as players having access to this quest are friendly to this faction wowhead.com/spell=40216 only the faction of the peon with 40735 [Defiant and Enraged] must be set to 14 when he's disobedient, and changed to 62 on spell hit.


Thank you for the logfile. Are those all errors? Of the 4 events with errors, two are connected with deserializer phase jumps.

1) channels 2/3 of the same event. Data seems ok. Maybe the error actually occurred earlier?
2) DTB deserializer phase jump 38->18
3) Very close in time to the previous dump. Can not see anything wrong with the raw data.
4) DTB deserializer jumps, this time from 18 to 38.

The "first readback marker after 15 readouts" errors could actually be caused by something that happened 16 events earlier, so it is hard to say. If the penalty is negligible it might be worthwhile to increase the logged depth.


Hmm, couple of points:
- You can use `if [ -n "$SOMETHING ]` instead of `if [ ! -z "$SOMETHING" ]`
- No need to touch the file first; redirecting the output will create the file if it doesn't exist.
- `$SQM_DEBUG_OUTPUT_FQN` is a meaningless variable name IMO (what's FQN?). I'd just call it `$SQM_DEBUG_LOG`; and use the $SQM_STATE_DIR as the parent of the debug log file, i.e. `SQM_DEBUG_LOG=${SQM_STATE_DIR}/debug.log`.
- Alternatively, it might be a good idea to make the debug logging a per-interface toggle? So instead of having the `$SQM_DEBUG_LOG` variable with a file name, add an `$SQM_DEBUG` toggle which will enable the debug output if set, and stick that in defaults.sh; then make the log function output to something like `${SQM_STATE_DIR}/${IFACE}.debug.log` if that is set? That way we can also expose the toggle in the GUI if we later feel that is worthwhile?

Also, my github handle is tohojo, not toke... ;)


Doh! I just realised that the example does make sense i.e. Friday, Saturday & Sunday are the full days. I wonder whether there's an example which would avoid the confusion that I had. Probably not important though.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8293/testReport/) for this commit**


ok jimy


ops! Still not working: Blender doesn't crash but nothing happens: it only adds a transform strip but it doesn't allow any transformation


I commented out this line, and did find a failure in our test suite. I wanted to make sure we're exercising this functionality.


Do not do naked except clauses. Add the exception you expect.


This design assumes varargin is always an axis property. For `limitPrecision` we will need a multiplier to tune the aggressiveness of the rounding. Even if we hardcode this multiplier in `limitPrecision`, this whole generalization is to potentially  keep other data manipulation tasks within this framework.

I think doing it by axis is a logically more intuitive approach (and easier to read) and would have `varargin` as additional inputs to `func` (consistent throughout Maltab with the e.g. optimization functions), rather than a workaround for collecting properties.


It's just a treemap lookup, where the tree is normally empty. Why do you think it'd be expensive? Compared to the rest of this codepath I'd expect it to be lost in the noise.


Please do not commit empty lines. This will not help use in this case on the visual side.


Thanks for the fix, and sorry for the delay. This seem to be working fine now!


You should use a constant for this. Django doesn't make it easy, but you can do something like:

```
from django.db.backends.base.operations import BaseDatabaseOperations

BIGINT_MAX_VALUE = BaseDatabaseOperations.integer_field_ranges["BigIntegerField"][1]
```


what are you up to? ;)


Yeah, thanks for breaking my code _and_ composer!

I understand your concerns with autoloaders but the PHP ecosystem is moving forward with [PSR-4](ww.php-fig.org/psr/psr-4/) and modern libraries are designed to work with it and do not provide any other mechanism for importing them.
The new design using namespaces and composer declared libraries vastly mitigates any problem old autoloaders had.
Also, if you look at the PSR4 autoloader code, it does _not_ include anything random, it includes declared and installed libraries which are part of Dolibarr.
Please also note that I didn't randomly use the autoloader. I used it because this is the recommended and *only* way to import the library I need to provide that feature.

In a nutshell, please take some time to think about it and rehash your old feelings that are not justified today!

Anyway fix PR incoming…


why did you Revert this?


Please do not commit empty lines. "//" is used for commenting lines but that is best inside a method. For a method level, you can use /* */


Do you have an example where this is used in the way am supposed to use it?


As I said, the `app.request` call must be removed.


Nitpicking, please use consistent quoting (cf CONTRIBUTING.md, double quotes).


Oh, that's bad. I'll look into it immediately.


Looks like this commit actually REMOVED the menu button support (at least on all Samsung devices I have tested so far, he device's hardware menu button now has no effect anymore?). Worked previously - menu did toggle the drawer menu.

Thx - Hardy


Move the return out of the try/except block.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.582](http://teamcity.monogame.net/viewLog.html?buildId=10105&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:26:22


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20185/testReport/) for this commit**


too much empty lines - format your code


This doesn't follow the XWiki code formatting style. Moreover, this commit introduces many "empty" lines with white-space. You should format the code before committing.


Hi Wolfram,

no, this was just an excerpt. The full logfile is at
pc11740:/home/l_tester/prod/pxar-prod11/data/d2114/pxar.log. There is
another one at pc11740:/home/l_tester/prod/pxar-prod11/data/x2114/pxar.log
(which convinced me that the timing test was reproducible, to the extent
that is possible with a statistics of 2).

In this particular module with exceptionally many errors, the complete
fulltest logfile with DEBUGAPI is 7.5MB. I think it is absolutely no
problem to increase the logfile size for problematic modules.

Cheers,
--U.

On Mon, Sep 7, 2015 at 4:10 PM, werdmann <notifications@github.com> wrote:

> Thank you for the logfile. Are those all errors? Of the 4 events with
> errors, two are connected with deserializer phase jumps.
>
> 1) channels 2/3 of the same event. Data seems ok. Maybe the error actually
> occurred earlier?
> 2) DTB deserializer phase jump 38->18
> 3) Very close in time to the previous dump. Can not see anything wrong
> with the raw data.
> 4) DTB deserializer jumps, this time from 18 to 38.
>
> The "first readback marker after 15 readouts" errors could actually be
> caused by something that happened 16 events earlier, so it is hard to say.
> If the penalty is negligible it might be worthwhile to increase the logged
> depth.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/psi46/pxar/commit/6ba81791076042e07061c40d7e4f9d49d00de01c#commitcomment-13097814>
> .
>


True. But many of my beta testers report to me in person that they see no
reason or benefit why we decreased the font size which they had been used
to for years,, and I guess they may have a point. :-)

On Mon, Sep 7, 2015 at 10:27 AM, vshcherb <notifications@github.com> wrote:

> I actually increased for Drawer to 16sp, which we found a good compromise
> between guidelines (14sp) and readability. To be honest I get used to
> stable drawer menu pretty fast and now I don't read full text, just
> recognizing icon and remembering position.
>
> I agree about night theme icons.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/osmandapp/Osmand/commit/c63a7cc488b8b0b683eb0c343ade3b5117b15178#commitcomment-13092017>
> .
>


ok I will :) not today but I will


The name of the commit is not really matching what's inside here :)


I think the command recommendation is sys.stdout.write()


10 (see Player.h), i will maybe change but now it's 10


watch the spacing here; this probably works but you might get weird errors in other cases


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20186/testReport/) for this commit**


Nice!


that's odd, if I don't miss anything here you pass `&p->public` (aka `inferior`), but below `inferior->priv` (aka `p`).  Not really a problem but it makes things really weird to read.
`p` local variable actually seem unnecessary.


Could you add an zip function into thunder's rdd, just like spark rdd's zip function? Sorry for my poor english...


hatInventory is an array of Hat*,
so temporaryHat take the value of hatInventory[hatPosition], which is a Hat*


Would be much more helpful to know when the user last logged in.  As that could give a clear indication if this is an active user.

Knowing if they as a superuser/admin user would be helpful.


I think, it's better to follow readability concerns here than 20+ years old standard. @bapt , what do you think?


HI levak !
Warface viet nam Update!
Launcher Update !
![2015-09-07_21-13-32](https://cloud.githubusercontent.com/assets/12555146/9718417/a00b513a-55a5-11e5-9efc-09eb580e308a.jpg)
line change 'http://account.goplay.vn/fastlogin'  to  'http://authen.goplay.vn/fastlogin'    to working


I can see you're organizing your rules by "topics" (positioning first, then dimensions, then colors, etc.) That's nice, I do it the same way. Some people choose to have alphabetical lists of rules. As long as you're consistent, that's OK.


suggest you change this to:

```
def raiseLimitExceeded(errorClass, value, limit)
  raise errorClass, "Value #{value} exceeds limit #{limit}"
end
```

...and pass the value & limit from the ```validate_compare``` method


@Vorspire  sending you a pm on servuo


:100: Works like a charm :gem:


it's the same as srand(time(0));  (to set the rand() function)
but nullptr is better in c++11


When I use this patch, image+ is working fine again, but a MIGX TV doesn't show the extra fields. When converting back to 'OnTVInputPropertiesList', a MIGX TV is showing all fields again.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20187/testReport/) for this commit**


They might want to use merge_user and purge_user to perform parts of the cleanup.


主函数


@aschnell Ok, thanks. I'll try to figure out and I'll ask you for confirmation. Thanks!


commit title too long?


Nice.


height: 300% :O


Please take in consideration the default naming convention on methods https://en.wikipedia.org/wiki/Naming_convention_(programming) -> in this case the method should be called: openViewMenu()
"Methods should be verbs in lowerCamelCase or a multi-word name that begins with a verb in lowercase; that is, with the first letter lowercase and the first letters of subsequent words in uppercase."


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8162/testReport/) for this commit**


`module` is not initialized yet


good job!


This fixes #9, although I forgot to put that in the commit comment.


It's a pity we don't support setting this on creation, because most of the cases we create a double call here.


`<a>` missing in some places? e.g. "listed here" line 110, blog posts referred to in line 122, etc, feel like they should be linking to somewhere. Worth a complete check against whatever the source document for this text is.


Quick tip about your commit messages: you can see on GitHub that it has been "truncated". It's because there is a "convention" of limiting commit titles to 80 characters, and providing any additional information in the so-called commit body. You may enter a body only when using `git commit` (without the `-m "this is the title."` option):

```
This is the title.

And here are some insights about the commit's content:

- it does this
- and that
- and it's complete

Ask X for further details.
```


If you want to know more about that: http://chris.beams.io/posts/git-commit/


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20188/testReport/) for this commit**


actually the whole `module` variable is unused


I've collected a bunch of release notes generator [here](https://allmychanges.com/help/changelog-generators/), but not sure if there is something which is able to generate a CHANGELOG file and to write GH Releases simultaneously.


This probably shouldn't be done here, as it only makes sense for the GModule loader


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8294/testReport/) for this commit**


Maybe add the description from the readme?


Hi Toke,

On Sep 7, 2015, at 16:10 , Toke H�iland-J�rgensen <notifications@github.com> wrote:

> Hmm, couple of points:
>
> 	� You can use if [ -n "$SOMETHING ] instead of if [ ! -z "$SOMETHING� ]

	Thanks, will change.

> 	� No need to touch the file first; redirecting the output will create the file if it doesn't exist.

	My idea was to use the existence of the file as condition to actually log:
[ -f "${SQM_DEBUG_OUTPUT_FQN}" ] && echo "$@" >> ${SQM_DEBUG_OUTPUT_FQN}
will only add if the file exists already, The preceding:
[ -f "${SQM_DEBUG_OUTPUT_FQN}" ] || touch ${SQM_DEBUG_OUTPUT_FQN}
was just the first point at which to create the file. Ideally somewhere in start-sqm or so the file gets deleted and recreated to avoid the unfortunate �eat all available /tmp space" issue the current implementation has.

> 	� $SQM_DEBUG_OUTPUT_FQN is a meaningless variable name IMO (what's FQN?). I'd just call it $SQM_DEBUG_LOG; and use the $SQM_STATE_DIR as the parent of the debug log file, i.e. SQM_DEBUG_LOG=${SQM_STATE_DIR}/debug.log.

	FQN = fully qualified name ;). You are right, $SQM_STATE_DIR is a better default location for that file.

> 	� Alternatively, it might be a good idea to make the debug logging a per-interface toggle? So instead of having the $SQM_DEBUG_LOG variable with a file name, add an $SQM_DEBUG toggle which will enable the debug output if set, and stick that in defaults.sh; then make the log function output to something like ${SQM_STATE_DIR}/${IFACE}.debug.log if that is set? That way we can also expose the toggle in the GUI if we later feel that is worthwhile?

	So I am not sure that making this per interface has too much value (the interface sections are processed in order and there should be enough pointers in the log which section is currently active). I guess to help a user I would want all debug output not jus the one the user that needs help deemed relevant ;). The simpler and the fewer options it had the better will it be suited to help people who need help most, novices ;)
	I could re-use the trick from activating the "init section� and auto-activate a lll debug check-boxes once a single one is activated, a dedicated user could still deactivate the sections they want to stay private.

	Thinking about this for a bit, I guess just having a debug output check box in the GUI would be the easiest on novice users. Then the condition for actually logging to the file would be [ -n �$SQM_DEBUG� ] and the same toggle will un-silence all uses of "> /dev/null� by replacing with �>> $SQM_DEBUG_LOG�. (In the end this un-silencing really is a big part of the motivation for the whole exercise). What do you think?

> Also, my github handle is tohojo, not toke... ;)

	Oops, sorry, will try to remember in the future.

Best Regards
        Sebastian

>
> �
> Reply to this email directly or view it on GitHub.
>


You mean copy from the readme?
On Sep 7, 2015 5:29 PM, "Eran Harel" <notifications@github.com> wrote:

> Maybe add the description from the readme?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/outbrain/ob1k/commit/35ef8d2825288a2467f50563c55df9629010b396#commitcomment-13098183>
> .
>


In my opinion most of the time having all declaration at the top of the function is more readable. But when it obfuscate the code like in this case, the variable to be declared in the proper block.


You know this code looks pretty odd right?


Надо ревернуть


"and", "or" are handled like all other operators in CasADi.

It's a bit complicated, but here is the recap:  CasADi has several different expression classes and to avoid code duplication, this functionality is moved to a base class using the "curiously recursive template pattern" idiom in C++. That is, an expression class `SomeClass` supporting operator overloading would derive from e.g. `GenericExpression<SomeClass>`.

In `GenericExpression`, the "operator&&" and "operator||" are friend functions (non-templated). This allows automatic type conversion of either argument. I'm convinced that this is the "prettiest" solution on the C++ side and works fine. Unfortunately, SWIG is not able to wrap this code (not a problem with SWIG-MATLAB, but with the SWIG front-end). So the solution we came up with (having tried different approaches) is to add a non-templated base class `GenericExpressionCommon` to `GenericExpression<SomeClass>` and use macros and SWIG's "%extend" capabilities to add all possible overloads as static functions in `GenericExpressionCommon`. These functions are however treated as non-static methods in MATLAB using the "nonstatic" feature in SWIG-MATLAB. This works fine and also correctly handles typecasting of e.g. `A + B` where A and B are different classes and (1) A can be converted to B, (2) B can be converted to A or (3) both A and B can be converted to a third type C. For `and` and `or`, you in addition have to use SWIG's renaming capabilities of the static methods that was added to `GenericExpressionCommon`. For more details, feel free to look at CasADi's source code.


register_legacy_plugin() is implemented in this file where "Plugin *" is passed around commonly.

p_geany_load_module() is a pointer to plugin code, on the other hand.


this is called unconditionally in `plugin_new()`, so either this check is redundant or there should be one in `plugin_new()`.  IMO it doesn't make much sense to allow not to have an unload function (and proxy plugins are probably not gonna be common enough to really save anyone much work if really one don't need it)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20189/testReport/) for this commit**


Under the `D ELEV for 100m DR` find the number that matches your ELEV and compensate (Example: if you're 200m above your target multiply the number by 2 and add it to your ELEV).


@dscho I cannot find f87f2bc in https://github.com/git-for-windows/msys2-runtime.

OOC: What is the code base for this new version?


Indeed

However, plugin->module is replaced entirely in the next commit(s) I can't do a fix-up commit (i can fix with a rebase though).


Because the 'key' is a string. Which means its deep-copied in the constructor of std::string, then there are two lookups (which really is bad code anyway..) in the table based on that string-key and a atoi parsing of the value in that map.

I don't think its a hotspot, but it certainly isn't cheap.


Hear hear. Judge code by quality not contributor.


and the rest of my changes? :stuck_out_tongue:


In pkg we do use __unused because it is a freebsd a usual macros (cdefs.h) we do define it locally for portability.
I this particular case I think key can just be nuked I'll check


Returns*


Noted


`tmp` is never a good name :)


:trollface:


probably should be guint (I didn't double check tho)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20190/testReport/) for this commit**


agreed


The new validation, after the whole where block


@thavel I found a coffee script implementation https://github.com/JimRobs/syno/tree/master/src/syno  Looks like they already reverse engineered VideoStation ( https://github.com/JimRobs/syno/blob/master/src/syno/VideoStation.coffee ) and VideoStationDTV ( https://github.com/JimRobs/syno/blob/master/src/syno/VideoStationDTV.coffee ) APIs.  So it might just be about copy pasting (with proper authorship).

See also the related wiki page https://github.com/JimRobs/syno/wiki/Video-Station-API


the `min` makes either of them optional, i.e. shorter or longer (not sure why that would be a feature, but still) parameter list


no need for an UTF-8 variant, no ASCII bytes can appear naked in an UTF-8 string unless they actually stand for the ASCII character.  That's one of the beauty of UTF-8: it's ASCII-compatible :)


**Eslint**: 'return' outside of function


Nanoproto doesn't have getters by default. If we want to generate the .java file with setters we need to use a non-default option, and this adds bloat to the class so we need to be sure it's necessary. (see "Nano version" at https://android.googlesource.com/platform/external/protobuf/+/master/java/README.txt ).


The only problem is it starts with `if ceremony_country == 'turkey' && resident_of == 'uk'` up on line 80. There is also potential for future changes of this kind to have additional conditions related to variables other than ceremony_country.


Hello gimmeitorilltell . Sorry for irrelevant question here.
I built CM12 with your sources, and everything works fine except HOME button.
In fact, the device I'm currently testing on it is not 100% Same as quincyatt.
It's kind of a variant model of quincyatt which are sold only in Korea. Furthermore, It has some differences and one of the major thing is Hardware Key. And because of this, I changed some configs in kernel and also switched off S2W config which made some build errors for the device.
And I got CM12.1 which has broken Home key function. The rom and kernel log(kmsg) seems to recognize the key, but it works weird like arrow keys(?) that of hardware keyboard.
I even not sure whether if why it works like it. It could be kernel, or rom, or both.
So I'm asking for your help. Or, at least, do(did) you have problems like this in your build?
Thanks you.


Well, for building KLEE, one currently depends on the sources of LLVM. Therefore, either `lit` is accessible as `llvm-lit` inside the LLVM build directory or KLEE was built against packages which provide needed build artifacts (see changes in Ubuntu/Debian packages).

If you just want to use KLEE, you probably won't execute the test files either. In that case, there is no need for `lit`.
Anyway, I would suggest to use  `lit` provided with LLVM, to be feature complete with the LLVM version you're compiling against/ linking with.

But, please feel free to open another PR to add `lit` via `pip` as a third option.


this can introduce some hard to debug errors (we've had some of these), the order should therefore be enforced


yes

On Mon, Sep 7, 2015 at 5:30 PM, Guy Marom <notifications@github.com> wrote:

> You mean copy from the readme?
> On Sep 7, 2015 5:29 PM, "Eran Harel" <notifications@github.com> wrote:
>
> > Maybe add the description from the readme?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/outbrain/ob1k/commit/35ef8d2825288a2467f50563c55df9629010b396#commitcomment-13098183
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/outbrain/ob1k/commit/35ef8d2825288a2467f50563c55df9629010b396#commitcomment-13098204>
> .
>


That's a nice feature, is it meant to be used internally somehow or by the QtOpenGL loop functions?


There is no g_strrchr() or g_ascii_strrchr(). I don't like to use plain strrchr() on gchar *, but can do if you prefer.


instead of throwing an exception we will just ignore the call to "viewDidLoad" until the VC is in correct state so that the VC has a chance to call viewDidLoad again instead of crashing.

This is what happens with 3rd party keyboards in our app, viewDidLoad seems to be called twice for the VC of the keyboard.

Indeed, viewDidLoad seems to be called for the VC of the keyboard while the view has not been prepared yet, then it calls it again when the view has been loaded.


Gotcha
On Sep 7, 2015 5:38 PM, "Eran Harel" <notifications@github.com> wrote:

> yes
>
> On Mon, Sep 7, 2015 at 5:30 PM, Guy Marom <notifications@github.com>
> wrote:
>
> > You mean copy from the readme?
> > On Sep 7, 2015 5:29 PM, "Eran Harel" <notifications@github.com> wrote:
> >
> > > Maybe add the description from the readme?
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/outbrain/ob1k/commit/35ef8d2825288a2467f50563c55df9629010b396#commitcomment-13098183
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/outbrain/ob1k/commit/35ef8d2825288a2467f50563c55df9629010b396#commitcomment-13098204
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/outbrain/ob1k/commit/35ef8d2825288a2467f50563c55df9629010b396#commitcomment-13098317>
> .
>


Did this pass with 0.75 when it was changed? Seems to be (barely) too strict now, loss comes out as 0.752 on my machine and travis, causing the test to fail.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20191/testReport/) for this commit**


:+1: interesting code :) - apply also reformat


Possible wording suggestion:

> To activate the "Stream to Papertrail" plugin, visit <Stream Settings> and set a Destination.

.. and then on the Stream Settings page, a way to get a destination for folks who don't yet have one.


DIRECTORY_SEPARATOR is needed ?


+jias0001 I don't understand what you mean by the behavior to the default keyboard. According to https://android.googlesource.com/platform/external/protobuf/+/master/java/README.txt - "Nano version",
```
How fields with defaults are serialized has changed. Because we don't
keep "has" state, any field equal to its default is assumed to be not
set and therefore is not serialized. Consider the situation where we
change the default value of a field. Senders compiled against an older
version of the proto continue to match against the old default, and
don't send values to the receiver even though the receiver assumes the
new default value. Therefore, think carefully about the implications
of changing the default value. Alternatively, turn on accessors and
enjoy the benefit of the explicit has() checks.
```

So nanoprotos are aware of the default value and the way to check that a field is set to see that it's different from the default. Strings default to "" unless the .proto file specifies a different default. Currently the .proto file doesn't specify a default. If it ever does, we can't check whether the proto "has" a field using nanoprotos (and backward-compatibility fails).


Okay, did you check that `Application.active_()` returns the same as `HwndWrapper.GetActive()`? If so I think moving `GetGUIThreadInfo()` logic to handleprops.py is really good idea. Method `Application.active_()` would also use handleprops.py that is faster than `find_windows()`.


You completely ignored that part about efficiency. Populate `IGNORED_NETWORKS` with already constructed `IPAddr` objects instead of creating them every time you want to check IP address against them.


old code used to compare caseless, which is probably a good idea (especially on Windows)


This seems to break the test, loss comes out as 0.752 on my machine as well as on travis.


@calumhalcrow I was talking about this line


This test should pass


moeller0 <notifications@github.com> writes:

> My idea was to use the existence of the file as condition to actually log:
> [ -f "${SQM_DEBUG_OUTPUT_FQN}" ] && echo "$@" >> ${SQM_DEBUG_OUTPUT_FQN}
> will only add if the file exists already, The preceding:
> [ -f "${SQM_DEBUG_OUTPUT_FQN}" ] || touch ${SQM_DEBUG_OUTPUT_FQN}

But since that is directly preceding it, what you're actually doing is
unconditionally creating the file anyways.

> was just the first point at which to create the file. Ideally
> somewhere in start-sqm or so the file gets deleted and recreated to
> avoid the unfortunate �eat all available /tmp space" issue the current
> implementation has.

I think it's less confusion to separate those things: let the logger
just write the file, then put a check somewhere to truncate the file if
it gets above a certain size.

> FQN = fully qualified name ;).

A fully qualified name is a DNS term in my world ;)

> You are right, $SQM_STATE_DIR is a better default location for that
> file.

Cool.

> Thinking about this for a bit, I guess just having a debug output check box in
> the GUI would be the easiest on novice users. Then the condition for actually
> logging to the file would be [ -n �$SQM_DEBUG� ]

Or rather [ "$SQM_DEBUG" -eq "1" ], then put in a default SQM_DEBUG=0 in
defaults.sh.

> and the same toggle will un-silence all uses of "> /dev/null� by
> replacing with �>> $SQM_DEBUG_LOG�. (In the end this un-silencing
> really is a big part of the motivation for the whole exercise). What
> do you think?

Yes, this was what I was thinking. And since the GUI configuration is
per-interface, having the switch be per-interface also makes most sense
IMO :)

> Oops, sorry, will try to remember in the future.

Well I get the notifications anyway; but I figure Thomas is tired of
getting weird notifications whenever you use it. Though maybe that's
only fair since he is so shamelessly using my name ;)

-Toke


This change It doesn't compile for me even when I add -std=c++14 -std=1z
I have this error
feel/feelvf/integrator.hpp:4962:38: error: out-of-line definition of 'evaluate'
      does not match any declaration in 'Integrator<Elements, Im, Expr, Im2>'
Integrator<Elements, Im, Expr, Im2>::evaluate( std::vector<Eigen::Matrix<T, M,N>> const& v ) const


This adaptation shouldn't really change anything other than eliminating a redundant setting in BoardConfig.mk. All the exact same parameters are being supplied to mkbootimg. The only change is that the --dt parameter is being supplied before the other two, but that shouldn't matter. It works fine for me. You can try modifying the line to not hide the command and then checking what is wrong in your setup. Which kernel are you using? Are the BOARD_RAMDISK_OFFSET and BOARD_KERNEL_TAGS_OFFSET defined in your BoardConfig.mk?  Are you able to build the dt.img by itself?


a testng class by convention should have "Test" suffixed to class name. In this case we should have MultiplicationTest.java


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20192/testReport/) for this commit**


Maybe something like this, not sure yet
.
![image](https://cloud.githubusercontent.com/assets/330847/9718810/666af906-557f-11e5-88cc-899a3ed75cce.png)


Fix indentations.


Sounds good, delete it please. It's confusing in this change.


This broke the ability to return a null cstring for null strings.


good catch, will change that


I see.  Yes, that is more complicated than most typical SWIG applications.  Does my implementation break CasADi?  Is there a simpler, more elegant approach to supporting these operators “out-of-the-box" without having to use %extend or %rename (these are required for the double() cast operator because SWIG typically does not support the C++ equivalent operator)?

> On Sep 7, 2015, at 10:31 AM, Joel Andersson <notifications@github.com> wrote:
>
> "and", "or" are handled like all other operators in CasADi.
>
> It's a bit complicated, but here is the recap: CasADi has several different expression classes and to avoid code duplication, this functionality is moved to a base class using the "curiously recursive template pattern" idiom in C++. That is, an expression class SomeClass supporting operator overloading would derive from e.g. GenericExpression<SomeClass>.
>
> In GenericExpression, the "operator&&" and "operator||" are friend functions (non-templated). This allows automatic type conversion of either argument. I'm convinced that this is the "prettiest" solution on the C++ side and works fine. Unfortunately, SWIG is not able to wrap this code (not a problem with SWIG-MATLAB, but with the SWIG front-end). So the solution we came up with (having tried different approaches) is to add a non-templated base class GenericExpressionCommon to GenericExpression<SomeClass> and use macros and SWIG's "%extend" capabilities to add all possible overloads as static functions in GenericExpressionCommon. These functions are however treated as non-static methods in MATLAB using the "nonstatic" feature in SWIG-MATLAB. This works fine and also correctly handles typecasting of e.g. A + B where A and B are different classes and (1) A can be converted to B, (2) B can be converted to A or (3) both A and B can be converted to a third type C. For and and or, you in addition have to use SWIG's renaming capabilities of the static methods that was added to GenericExpressionCommon. For more details, feel free to look at CasADi's source code.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/dcb210/swig/commit/9ef94d49431de5bdaea1459a3fdb4d3c4dd693cb#commitcomment-13098217>.
>


* masfmkd'k


Maybe put `Plugin` somewhere in the name


TeamCity YaccConstructor :: YC.Core General Build [Build 492](http://teamcity.codebetter.com/viewLog.html?buildId=198880&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


unused?


For this example you can use a DataProvider http://examples.javacodegeeks.com/enterprise-java/testng/testng-dataprovider-example/ not required at this time to change. but just FYI


+jias0001 We need to be sure that it will never change. If there's any doubt, we can generate a hazzer (hasNationalPrefixForParsing()). Otherwise a change in the default will break clients who persist the old proto.


#12 #13 #14


why you didn't use already existing solution?


Thanks


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20193/testReport/) for this commit**


Плохая идея не логировать ошибки. Они либо должны обрабатываться, либо хотя бы логироваться.
Получается что твоя реализация не отказоустойчивая, дак еще и умрет по тихому.


Foe Git testing


`so` might not be a great name as it loads any type of dynamically loadable module GModule can handle (and that has the symbols we require).
Maybe name it `internal` or `gmodule`?


Bold works for me.


(or `builtin` as below)


Two application_controller files? Delete one of them.


为什么，这个版本比官网的还要详细？ 你是上地的吗？已离职


trailing underscore is weird, maybe `builtin_so_proxy_plugin`?


You are completely correct. Should be fixed now.


Т.е. я могу создать объект Евента и выполнить у него executeEvent? (кстати, тавтология)
Ты тут ничего не попутал с иерархиями классов? Подумай.


The same problem as above.


name doesn't really make it clear it's a list of PluginProxy


if not used a DataProvider, it's best to add assertion, for example after line 33, just assert the result.
If everything from line 31 to line 46 will fail (the error is not captured, this "multipleOperation" method will just test that negative (res) is -6. If something from 31-46 will fail - it will be harder for you to debug.


Можно просто слипать... тут пока без разницы. Просто передавая количество миллисекунд.


add the analytics at the bottom with other scripts


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20194/testReport/) for this commit**


I guess it'll come later, but here unloading the proxy doesn't unload the sub-plugins


Hi Toke,

On Sep 7, 2015, at 16:42 , Toke Høiland-Jørgensen <notifications@github.com> wrote:

> moeller0 <notifications@github.com> writes:
>
> > My idea was to use the existence of the file as condition to actually log:
> > [ -f "${SQM_DEBUG_OUTPUT_FQN}" ] && echo "$@" >> ${SQM_DEBUG_OUTPUT_FQN}
> > will only add if the file exists already, The preceding:
> > [ -f "${SQM_DEBUG_OUTPUT_FQN}" ] || touch ${SQM_DEBUG_OUTPUT_FQN}
>
> But since that is directly preceding it, what you're actually doing is
> unconditionally creating the file anyways.

	Yes, this basically was my preparation for finding a better spot to clear the file and start over fresh, before I figured that was hard and went shopping ;)

>
> > was just the first point at which to create the file. Ideally
> > somewhere in start-sqm or so the file gets deleted and recreated to
> > avoid the unfortunate �eat all available /tmp space" issue the current
> > implementation has.
>
> I think it's less confusion to separate those things: let the logger
> just write the file, then put a check somewhere to truncate the file if
> it gets above a certain size.

	Certainly an option, but to do this we still need to find a place to do the check, my gut feeling is once we found that place we can unconditionally truncate there ;)

>
> > FQN = fully qualified name ;).
>
> A fully qualified name is a DNS term in my world ;)

	I guess if the suffix is not understood by you, no one will so it will be gone in the next iteration...

>
> > You are right, $SQM_STATE_DIR is a better default location for that
> > file.
>
> Cool.
>
> > Thinking about this for a bit, I guess just having a debug output check box in
> > the GUI would be the easiest on novice users. Then the condition for actually
> > logging to the file would be [ -n �$SQM_DEBUG� ]
>
> Or rather [ "$SQM_DEBUG" -eq "1" ], then put in a default SQM_DEBUG=0 in
> defaults.sh.

	Good point.

>
> > and the same toggle will un-silence all uses of "> /dev/null� by
> > replacing with �>> $SQM_DEBUG_LOG�. (In the end this un-silencing
> > really is a big part of the motivation for the whole exercise). What
> > do you think?
>
> Yes, this was what I was thinking. And since the GUI configuration is
> per-interface, having the switch be per-interface also makes most sense
> IMO :)

	Nah, not most sense, it will fit most naturally with how we set up the GUI, but for user support really a single check-box for all interfaces would be best… But since the per interface placement will at least be consistent with all the rest I admit this is the way to go… But let me first get the underlaying machinery functional...

>
> > Oops, sorry, will try to remember in the future.
>
> Well I get the notifications anyway; but I figure Thomas is tired of
> getting weird notifications whenever you use it. Though maybe that's
> only fair since he is so shamelessly using my name ;)

	Ooops, sorry Thomas, but at least this explains why github happily expanded @ T o k e (I hope this last one will not)

Best Regards
	Sebastian

>
> -Toke
> —
> Reply to this email directly or view it on GitHub.
>


Do you really need all these comments? Delete them.


Can this change get deployed to pypi please? Without it the library fails after a set amount of invalid dates being processed.


the --with-gnutls is passed inside the string parameter for --with-unixodbc


Or this.set(args);


Класс явно перегружен логикой, тут не должно быть и упоминания о создателе событий, как и самого запуска. Как и функции main.
Просматривать материалы до полного понимания реализации одного из паттернов программирования:
https://www.google.ru/search?q=%D0%BF%D0%B0%D1%82%D1%82%D0%B5%D1%80%D0%BD+observer&ie=utf-8&oe=utf-8&gws_rd=cr&ei=QqTtVd7oOMyNsgGPz524Cw


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20195/testReport/) for this commit**


No, my point was that you access the same memory in various ways: `&p->public == inferior` and `inferior->priv == p`, but you use both.


What kind of commit is this? @andela-nmartin is this yours?
We have Finishes, Fixes, Chore, what's OS X Stuff?


In the end it's that proxies can't be unloaded if any subplugin is still alive (active).

That's not set in stone but was easiest and safest to implement.


- [ ] masfmkd'k
- [ ] masfmkd'k
- [x] masfmkd'k


@JDutil I wonder if the check can be removed, any way it can be done without accessing the database during the initialization?


ok, don't bother just yet (esp. as it probably doesn't actually have any nasty effects)


Right, should use p below.


Ohh My God!!!


なるほどね。こんな感じか。


Перед тем как ты все переделаешь, я бы хотел тебе предложить создать только быстрые события и несколько миллионов, посмотреть на сколько медленно оно без задержек будет работать.
Очень плохой подход не использовать executor services, так как при увеличивании количества потоков рано или поздно начнет уходить много времени на переключение контекста.


Не плохая попытка, но нужно перееосмыслить задание.


Merge from master


shouldn't TRE be in `@throws` section


I do, because it has the same behavior but is faster (well, `g_utf8_strrchr()` could be optimized for this case, but probably not)


Ok mate then are you compiling RR with this change included right? İf there is a issue on wifi on new build then we can publish a kernel with reverted this change as a hotfix to the users


looks good


okay, fine either way, so long as there can't be references to unloaded code


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20196/testReport/) for this commit**


@ryon categorically hiding all tree arrows shouldn't happen at the SASS layer. If you want useArrows to default to false use an override in the theme. Doing it from SASS blocks the arrows when useArrows is set to true. Customizations like this should at least be scoped to a particular grid. Remove this and instead set useArrows: false on any grids you don't want having arrows


We know, nothing we can do about it right now.


Pro level MAXX!


To stop the propagation on the parent node, when child element is clicked, use `bubbles=false`
http://guides.emberjs.com/v1.10.0/templates/actions/#toc_stopping-event-propagation
Nice feature :+1: provided by ember :smile:


@czardoz won't you need to change Line 40 in swagger_aws.json as well?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20197/testReport/) for this commit**


I don't mind either style, I'm just following conventions already present in the file that I believe @chrisroos has introduced when converting this smart answer. I don't think we have rubocop rules for erb.

Talking about subjective things, I'd prefer to use the shorthand syntax e.g.
```
 <%= render "three_day_residency_requirement.govspeak.erb", country_name_lowercase_prefix: country_name_lowercase_prefix %>
```
that would eliminate the need to break it into multiple lines in a lot of cases :)


`strrchr()` here too


this string manipulation is kinda dangerous (+1 on potentially NULL string)


too much empty lines :)


Where is the site?


`module` variables becomes totally unused :)


TeamCity YaccConstructor :: YC.Core General Build [Build 492](http://teamcity.codebetter.com/viewLog.html?buildId=198880&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 236 Build time: 00:18:11


:+1:
@regislebrun  ?


no need for this two additions -> format your code ALT+SHIFT + F


Just incase you didn't know, in vanilla when you tap a block with a sword or tool (Not sure about items, I will test it) in 0.12, what you could do is when block is tapped it sends an AnimatePacket which shows the animation. I believe this animation is not in 0.11 though.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20198/testReport/) for this commit**


please review your code and if you see this type of noise, remove the tabs or spaces.


this method is not needed. We already have one @BeforeMethod in place on CalculatorTest.java that will handle this.


add one empty line here, as github suggested


@ryon @themightychris Fixed. https://github.com/SlateFoundation/slate-theme/commit/5d272a07a7803748a2f6b28edf842536006330ac


You can add it as @author too ;)


Yeah of course :+1:


Hi and sorry for the late reply. The original commit is made by astro75 as well as the comment. I have just cherry-picked it so you may ask the author for more details


IMHO These really should be in your local ignore file ($GIT_DIR/info/exclude), not she shared one.


why do you ask renderer for de-interlacing mode if de-interlaing is handled by decoder?


To be honest, I thought I was the sole contributor here.
Maybe I am wrong? Can you point me to the history you are mentioning?


ideally this would only be in the failure paths (although it probably doesn't change much)


the ids like jj, etc. are already used by the WordPress publishing date and should not be used again.


@werdmann: the thing with the readback markers is not completely clear to me in terms of the severity.
However, when again reading my code I just discovered a minor flaw:

whenever a ROC header is missing, I set a `readback_dirty` flag to ignore the following readback cycle. However, my current logic would only keep this flag until the first ROC went through a full cycle - while it should be kept until *all* ROCs went through their cycle, since with a missing ROC header we don't knwo which ROC it was.

I now changed the code to flag the current readback cycle for all ROCs invalid, this should suppress most of the warnings - which mostly come with a missing ROC header as far as I observed.

Code is in master, see 3b679bfd5f19973531fab7b62cb81cf7b3edc222


reformat your code


Ah cool :) Do we also get a timestamp in the log statements?


综合了原先版本里的参数说明、各位网友的补充，以及自己的试错得到的结果。我现在住在上地，已离职是什么意思……


unnecessary prototype, and should at least be surrounded by blank lines


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20199/testReport/) for this commit**


Great points, yes you're totally right.  Travis is a very good place to kick off the tests.  Thank you!


> Does my implementation break CasADi?

No, not really. In CasADi, the base classes will be shadowed anyway. The main problem is in my opinion that you define the operators for all SWIG-classes, for which `and`/`or` might make no sense. The same could however be said for subsref and subsasgn. The cleanest solution is probably to move these functions from `SwigRef` to the classes deriving from `SwigRef` and only enable them with some SWIG feature. This will result in some more code duplication, but on the other hand, better encapsulation.

Another, separate issue is that of type conversion. I am not sure how to get something like `4 & x` working automatically (with 4 being typecasted to the type of x). For CasADi, this works fine... but using the approach described above.


Stato iniziale di Laravel 5.1.


References #8 and #25. Possibly even fixes.


why move this here?


Yes, I've just checked - the same results. It seems like you are right. It is possible to move `GetGUIThreadInfo()` logic to `handleprops.py`. The `procced_id` can be an input parameter. It exists in both objects `HwndWrapper.ProcessID` and `application.process`.


I find it a bit confusing... why not just the below? its short and to the point

The location of the user might indirectly be determined by knowing the physical location of the NFC tag which is being read.


It needs the else block :P


Cambiare il namespacesdell'applicazione da "App" a "CodeCommerce"


Anyway, to sum up: I'd leave it like it is now for now. But consider moving it to the classes deriving from `SwigRef` in the future, despite the fact that it will result in some code duplication.


adding new page: Contact


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8295/testReport/) for this commit**


This probably should have resulted in a version bump for the framework as well.


checking


perhaps `$( (stty size || tput cols) 2>/dev/null )`?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20200/testReport/) for this commit**


ummm...? what?


lgtm


problem 58


Wouldn't (registerHttpProtocol)[https://github.com/atom/electron/blob/master/docs/api/protocol.md#protocolregisterhttpprotocolscheme-handler-completion] be more useful?

I think e.g when launching Cumulus from a browser script this would make checking for success more logical.


p->filename can't be NULL and is N absolute path. I don't agree it's dangerous


Ok, In this case I expect a short list of `wait_for` conditions, so will change to more readable `for` statements.


Delete it from file


1,2,6번째 타입들은 기존 테스트 케이스에 포함되어있어 별도로 추가하진 않았습니다.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20201/testReport/) for this commit**


Needs to be fixed


do we really need a global here?  couldn't we simply check if the the newly loaded plugin is a proxy directly in the loop, like I don't know, `p = plugin_new(...); if (p && p->proxy_cbs.load) proxy_added = TRUE;` or something?


Useless line


formatting


N -> an. Writing on a smartphone can surely suck


Doesn't actually resolve #17 and #18 - resolves #15 and #16


That seems to be how it's done. E.g. VideoPlayer with software decode enables deinterlace through the ffmpeg decoder:
https://github.com/popcornmix/xbmc/blob/fernet/xbmc/cores/VideoPlayer/VideoPlayerVideo.cpp#L548
I believe that software yadif for example is done as a post-process stage of decode, rather that as part of renderer.
I imagine I can avoid going through renderer though. I'll look into it.


again


and here too


also this


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20202/testReport/) for this commit**


this one too


Fixed in https://github.com/kardianos/govendor/commit/db257bd0af653dbd92a58911c1b6dfe73654cc9d


no wildcards


This us a preparatory commit. Hence this and also the prototype above


See #43647.


These declarations need to go above the constructors and above all methods


missing a blank line


name the event reference `event`, not `e`


also, fine to add test scripts in package.json -- or any other obvious place.  Since end users won't interact directly with the test you should just do what is easiest.


Is something like this would be ok :
```
    measureComputersHolder.setMeasureComputer(new MeasureComputer() {
      @Override
      public MeasureComputerDefinition define(MeasureComputerDefinitionContext defContext) {
        return definition;
      }

      @Override
      public void compute(MeasureComputerContext context) {
        org.sonar.api.ce.measure.Measure ncloc = context.getMeasure(NCLOC_KEY);
        org.sonar.api.ce.measure.Measure comment = context.getMeasure(COMMENT_LINES_KEY);
        if (ncloc != null && comment != null) {
          context.addMeasure(NEW_METRIC_KEY, ncloc.getIntValue() + comment.getIntValue());
        }
      }

```


why the eval?


event


See also https://bugzilla.mozilla.org/show_bug.cgi?id=1201635


Also, spaces.  This should be
```
converted_entry="`echo $entry`"
```


From other module only? What about compiled part of current module?


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _onInputChange


```
> echo `echo '$PWD'`
$PWD
> echo `eval echo '$PWD'`
/Users/mark/Desktop
```


* 避免在`<a>`标签中嵌套`<div>`等块级元素，部分模板解析引擎会误解析。如果样式需要可使用`<span>`等标签代替然后通过`css`来控制样式


初步检查没有问题


Why we map values to parameters by order? Mapping by name looks better.


so, not using `'` but `"` is not an option?  :)  I am inclined to use eval as little as possible, really, as it is too prone to side effects (IMHO)...


C switches can do everything ;)
```c
switch (ret)
{
	case PROXY_MATCHED:
		return proxy;
	case PROXY_MATCHED|PROXY_NOLOAD:
		return NULL;

	default:
		g_warning("Ignoring bogus return from proxy probe!\n");
	case PROXY_IGNORED:
		continue;
}
```


What do you mean with "spaces"?


this commit is almost 3 months old now. you can initialize the cache with empty path in your case:
```
[[SDImageCache alloc] initWithNamespace:@""];
```


it's a little odd `NOLOAD` is a flag as it seem to only make sense together with `MATCHED`, but that's no biggie


The '=' after the word verbose looks strange to me.  What else (besides the credentials) is in your activities block?


> so, not using ' but " is not an option?

Correct.


```
$ A='a  b' # note: two spaces
$ B=`eval echo $D`
$ echo $B # note: one space
a b
```


Your screenshot is of the grib plugin correct?  So the problem is with
the grib plugin then?

I never implemented current arrows, maybe you did (I was just at sea
for 3 days from rodrigues to maritius)

Sean

On 9/2/15, didier <notifications@github.com> wrote:
> With opengl wind arrows head are sometime 'blocky' or truncated, at least
> here.
> Current arrows are beyond repair, cf image.
>
> I have added current arrows to weather routing, sort of, it's using wind
> arrows.. It's really useful.
>
> ![capture du 2015-09-02 11 27
> 06](https://cloud.githubusercontent.com/assets/12138026/9628699/3f66221a-516d-11e5-82e1-069f49ed1fc1.png)
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/did-g/weather_routing_pi/commit/49525595e2b9ddef8892f8d72397f28b2be51386#commitcomment-13019534


@aharley40 did you ensure useArrows is set to false on the people groups grid that I imagine this was originally intended for?


naming; should it perhaps be named `createAsyncCallback`?


Sure, it's not a difficult task, and we shouldn't have to re-generate the wrappers often.


Thanks!)


some of image text is missing


Hey, I'm guessing you meant to post this as an issue on my extension, right?


:+1: yay :D
Thanks!


I've decided to change it later as I foresee some merge conflicts with other branches pending review.


You can add the double quotes if you want, I dont think it changes the semantics here. Please test before you do so though.


But only with ints, and constant cases :-(


Fixed, also added a test with aeb5cf12cc7976c13027188f8a0f0c6057038fee


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 534](https://teamcity.labkey.org/viewLog.html?buildId=270607&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30 (2 new), passed: 9 Build time: 00:25:30
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

##### there are 20 more failed tests, see build details
```


I find mine reads better


Hi, @noaneo. I will not be editing the structure of Twenty Fourteen from my child theme that was created to integrate with an eCommerce system. There really is no need to do that, especially considering it's a child theme that I do not push out updates for.

That means you are 100% free to do this yourself in your copy of the child theme. It will never be overwritten by an update. You don't need me to make the edits. You can simply make them yourself in your child theme based on your own preferences.


Okay, the AutoInterlaceMethod was trivial, so no need to go through renderer: https://github.com/popcornmix/xbmc/commit/f15e2f50f1bf0cf59a5a5a6a755c1170de011aec


@Surbma
Thanks for putting this together. I'm so sorry I missed it until now. I was wondering what you meant about the 2.3.0 version in that issue the other day. I haven't been watching this repository, so didn't get email notifications (they are on now).

I won't be able to merge this because it uses multiple files. It's important that we keep everything in one file so it's still usable as an mu plugin.

Localization is a great idea though. With it being a utility plugin, it's not something I considered, but now that an admin page is available it might be handy. I'll open an issue for this.

With this holiday weekend I've had a bit of spare time to update things, and it's been submitted to the wordpress.org plugin repo. I've also decided that with the rename, I'm going back to version 1.0. I'll tag the release once WordPress.org approves it (in case a few alterations are needed).


should we have some sugar for scheduling callbacks that bundles these 3 lines into something that is easy to use?


@RandomAltThingy if you were blocked from one account, you are conceptually the same blocked even with another account. Please stop this.


This was just to add 1 line at 388... not sure why the diff has not worked correctly:
                       SearchField = "Read Me",


**Eslint**: 'return' outside of function


I raised exactly the same question when FCO suggested the change and I suggested to use an example that spans over a weekend to make sure it's clear that we're talking about any days, not working days :) If you can come up with a copy that is less confusing we can talk to Holly and make it a thing :)


I have a few questions.

- 1a. When implemented in libavfilter, can the filters still be assigned to key bindings?
- 1b. Can you give an example command for what would be put into input.conf for a filter?

I'm not sure what "useful" means because af_center, af_extrastereo, af_karaoke, af_sinesuppress, af_sub, af_surround, and af_sweep were removed for being "useless" and it didn't sound like they were meant to be implemented in libavfilter.

- 2. Can those filters above (and <i>all</i> filters that are not obsolete/broken) be implemented into libavfilter too?

Our concern is that some filters are being removed due to being viewed as unnecessary, but that's difficult to determine because the use case for every user currently and in the future is unknown. I think it's better to keep as many filters as possible, unless they are problematic.


Format changed to "bookname_2015-08-17_12-25-14.pdf"


10.4/10.5 means OSX?


In most case it makes to sense to go through renderer. One more reason why I am doing those changes. Mainline code for vdpau and vaapi looks like this: renderManager asks renderer, renderer asks decoder. Now with Support methods belonging to VideoPlayer it can ask decoder for deinterlacing supported by decoder and renderer for the others.


merged


Merging


merge


yeah, clearer in the context of the bug report though...


first


a esto hay que meterle i18n.
Y los links hacerlos agnosticos de idioma mejor, no? https://www.mozilla.org/firefox redirige al idioma correspondiente a tu navegador


Surely you could use [0, 4] for this?


Simon,

the more I look at this, the more *artificial* the separation between `ClientHandshaker` and `ResumingClientHandshaker` seems to me. Wouldn't it make more sense to simply have a `ClientHandshaker`class that has a field `fullHandshake` that we use to adapt the handshaker's behavior accordingly? In the end, the things to do when receiving the *SERVER_HELLO* or the server's *FINISHED* message are pretty much the same so it doesn't seem too awkward to simply check `isFullHandshake()` before doing things that are not necessary in an abbreviated handshake.
However, what feels very strange to me is the *on-the-fly* switching to the superclass' implementation of handshaker by means of the `super.doProcessMessage()` invocation.
I think we can merge the two classes into a single `ClientHandshaker` and re-arrange some of the field initialization logic in order for it to work in both cases in a clever way and we are done.

What do you think?


> eg if you arrive in the country on Thursday, the earliest you can post notice is the following Monday (with Friday, Saturday & Sunday being the 3 full days in this case).

Maybe...?


Sorry guys for this rename but I like the new name better and it is still not too late to change this.
@robertodr @miroi


Line 7 could be vulnerable to a directory traversal attack (see https://www.owasp.org/index.php/Relative_Path_Traversal)


hmmmm ...... damn, that's puppet DSL any ruby mixed :-) Won't work ..


I put the text nested a level deeper than the tag because—in my experience—students tend to favor putting everything on one line. When the text is very long the trailing tag ends up way off the screen. I think that this makes the HTML harder to work with, and would encourage the default to be nesting test one level deeper.


Hashbang URLs :disappointed: - http://danwebb.net/2011/5/28/it-is-about-the-hashbangs


Hi, @SDavisMedia it is not for me, I tell you to add this code in your child theme, but for all your users, I do not need your help.

People who have a low screen resolution does not realize the theme of the Twenty Fourteen bug. Make the theme is centered, does not hinder the purpose of your child theme, on the contrary, it makes it more pro.

In style.css, line 19
add the code
.site {margin: 0 auto;}

in two seconds it's done, not complicated.


We could get away with not using this if there was a nested div inside of `info` and `lectures` divs. Explaining `box-sizing` might be harder than having unexplained `<div class="content">`?


3am code.. I'll change it. I was debugging and I forgot to remove the experimental code, thus the repitition. #caffeineEffect lol


Typo in filename: `_partner_probabbly_needs_affirmation_affidavit_callout.govspeak.erb` - "probably" only has two b's not three!


this css file was composed using sublime text 2.
cut and pasted the functionality of colors and text do not seem to be working.