I don’t follow. What needs to change?

On Tuesday, September 29, 2015 at 5:56 PM, danoc wrote:

> @tomgenoni (https://github.com/tomgenoni) – Just a heads up that there's two small things to update.
>
> —
> Reply to this email directly or view it on GitHub (https://github.com/optimizely/lego/commit/b107b510a04e8467883456a7d1e17bad906843f5#commitcomment-13507117).
>
>
>
>
>


@web2solutions, thanks for the submission. A few questions:

1. How does one easily see the specific changes to the original code? Right now, one has to check out the repository and do a manual `diff` between `id.js` and `id-fix.js`. Is that the best use of the tools available, or can we do better?
1. Does `resource` work now with your changes? How would someone else be able to tell?
1. I see you have `test-id.html`, but what does it test?


Мокап не отражает то, описано в документе. Доработайте, пожалуйста!


@catalin-oancea use css classes instead of adding style properties to tags. For example, the class .right, defined in resources/static/css/style.css does exactly what you needed.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.634](http://teamcity.monogame.net/viewLog.html?buildId=10423&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Does ``pip install mccabe`` help?

The problem with doing this by default is that the tox route is preferred and there tox  manages the installation and sourcing environment for ``flake8``.


Why do cards with EFFECT_UNIQUE_CHECK need to be destroyed seperately?


previously we had a much richer development history as seen here:
https://github.com/mamedev/mame/commits/5d1376e27ebadb5ced8a6879c3e15bf2006ba871/src/mess/drivers/ibmpc.c

So, it means the history is not "lost" at all. But it is certainly hidden now :-(


I already checked it out. It does not do what this function does, unless you'r asking me to refactor that function :P


@catalin-oancea you could define your own class for this. Also, since the value 1 represents logical true here, you should use that instead.


This regex will not work https://github.com/kangax/compat-table/blob/gh-pages/build.js#L684


You should be able to keep using try-with-resources on the original stream (it's OK to not call `RateLimitingInputStream.close()`, I think).


I'm not sure if queue will be used to render animations. Even
cKeyframeAnimation and cFlightAnimation classes are not prepared to render
in separate thread (background process in GUI mode)

2015-09-30 19:24 GMT+02:00 Sebastian Jennen <notifications@github.com>:

> each item in the queue consists of
>
>    - the filename to load
>    - the type of render to execute (to distinguish between still / flight
>    / keyframe)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/buddhi1980/mandelbulber2/commit/86d74d9e6d021343ecca67bfacecde55ac6080d7#commitcomment-13523595>
> .
>


Sweet!


@catalin-oancea Use {% trans ... %} for strings.


- [ ] 「sessionスコープのBeanの状態をクリアし、注文済みの商品をカートから削除する」といった表現の方がわかりやすそう。


No change, previously:

```
$ pip install flake8
...
Successfully installed flake8-2.4.1 mccabe-0.3.1 pep8-1.5.7 pyflakes-0.8.1
```


comments as what these metadata types mean ?


@catalin-oancea don't put css properties on tags. In this case maybe a bootstrap class might help


"Internet connection" doesn't fit into functional requirements section. Ok on everything else.


@catalin-oancea don't put css properties on tags


It would be nice to move output generation into a template, and make it multilingual, but this does get the job done.


@catalin-oancea don't put css properties on tags, use true instead of 1


Nope désolé. J'ai plus Altium.
Oui, je sais. Maintenant j'ai appris et j'utilise KiCAD :p


can this be fixed for vs.2013 as well?


It looks like newer versions of skinshortcuts have per widget properties, depending on how well this has been implemented, we might be able to use both orientation and always-display as a setting from skinshortcuts menu even if Kodi never does support it.


Must not be available under Python 2.6 for some reason.

```
Successfully installed flake8-2.4.1 mccabe-0.3.1 pep8-1.5.7
% flake8 --max-complexity 11 planemo tests
%
```


Why not do this in a `finally` block?


Just FYI this totally broke a project I was working on since the npm version number wasn't bumped. I think we are just going to fork it to prevent breaks in the future.


Same here, in `finally`


Partial updates is a thing that's supported? Really? But only the permissions field can be left out? That seems... unnecessarily special.


gotcha, that makes sense.

long term we should come up with a better solution than eval + a regex, but it's clearly not worth breaking right now. thanks for the fix!


Nice :+1:


@catalin-oancea be consistent with coding style and, preferably, try to use {{ variable }} instead of {{variable}}


the rate limit is three, and we fill the initial querychanthing with up to K peers. They get sorted as they are inserted, so when we get here, we will get the next closest peer.


Off the top of my head, I think you're missing some escaping in the strings that go into the XML file.


В разделе "функциональные требования" по-прежнему  нет функциональных требований.


`close()` doesn't throw exceptions


@catalin-oancea indentation really helps when it comes to nested for loops (and html in general)


Added a comment. Make's default is sh but updating the path requires bash (unsure why)


Make a look at : git log --follow  src\mame\drivers\4004clk.c

All is there. GitHub interface is not doing follow but you can do it
locally.

On Wed, Sep 30, 2015 at 7:27 PM, Felipe Corrêa da Silva Sanches <
notifications@github.com> wrote:

> previously we had a much richer development history as seen here:
>
> https://github.com/mamedev/mame/commits/5d1376e27ebadb5ced8a6879c3e15bf2006ba871/src/mess/drivers/ibmpc.c
>
> So, it means the history is not "lost" at all. But it is certainly hidden
> now :-(
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mamedev/mame/commit/1fc48ce120a376c288daeeed98daccecf1b60d7b#commitcomment-13523643>
> .
>


Some files saved on our computer are better referenced with absolute paths, and others are better referenced with relative paths. A system configuration file that won't be getting moved is best referenced absolutely; a file that is part of your project, though, would lend itself to a relative path. Why?

Suppose we move our project directory. Maybe we just rename it, maybe we move it into the sibling of its original parent directory. What would happen to all the absolute paths in our project that refer to other files within our project? On the other hand, suppose we used relative paths. Would we have to update them if we move our entire project directory elsewhere?


inside spawnWorkers, otherwise we run into the issue where we pull everything out of the sorting queue immediately, and just hang right here until the rate limiter lets us in.


I don't think this is used.


Liberal use of the Smarty `|escape` modifier suggested.


@catalin-oancea don't put css properties on tags, use true instead of 1


@catalin-oancea don't put css properties on tags


working on docker on RH7...


is there a reason behind using the non-streaming versions of reading files/(un)marshalling json/snappy compression? it adds unnecessary buffering


this gives "err" is undefined. the value of err should be checked against nil and "Unknown" returned when so.


These styles have been deprecated. This works, but staying up to current coding standards would mean moving this into a grid.


Method


These ":=" should be "=" as we do not want redeclaration here.


FYI, @olivierdemunck @fvogel


if what f is opening doesn't exist that except and f won't exist and f.close() will except.


you can not use a undefined variable in comparison ... you can check it type (and check if it defined).

The NAMESPACE variable is not defined at this point. You could to define it early, but does not make sense to declare and imediately checks if is is null.

check the type here, is enough


For current coding standards, I'd suggest extending AjaxFormHandler and putting the javascript for this template in there as well.


like, adding it to bitswap? Yeah, might be good to finally do that.


@themightychris I'm not sure what to do about either of these request.

The sql script that returns competency completions gets it by competency. I don't see any logic for getting child ID's and using it to show that info. Any idea how this would happen?

I also think I have to redo the mysql script that returns demonstrations logged to add the needed functionality stated by Christian.


Sorry dat het zo rommelig is, heb hoofdpijn dus kan niet helder nadenken lol.


FYI, a convenience method has been added to the master codebase: `PKPTemplateManager::fetchAjax`. This can be used instead of templates that just load an AJAX component. See e.g.:
https://github.com/pkp/pkp-lib/blob/167eded451a2990b1aa0588ba559f921950396a2/pages/dashboard/DashboardHandler.inc.php#L118

(This isn't available outside of the master branch just yet.)


BOOOOOOOO


It would be nice to have all text localized. Also, I'm not sure what the paging code here is doing; is it something the grid paging code can't handle?


> English, do you speak it?


Some dead code.


No, it is related to code validators, like Lint and Hint ... it is not a programming error, just a convention

if you test your code against Lint, it will throws a warning message: too many vars .... it means, inside a function scope, you should to have just one var statement


You did beat me again by a few seconds :-P


This isn't exactly equivalent to what you had before; don't you need to filter out blank strings as well?


I can guarantee that the 3rd assertion will never be triggered, since the status code is set in `buildResponse()`. The only purpose for the assertion is to avoid that I (or you :-) make stupid mistakes. And this is the typical usage of [assertion](https://en.wikipedia.org/wiki/Assertion_(software_development)).

The assertions are for xwebview developers (to catch internal error) instead of users (to catch misusage). I agree that it's better to have a message. We can add comments in code or use the Foundation's `[NSAssert](https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Miscellaneous/Foundation_Functions/#//apple_ref/doc/uid/20000055-173105)` macros.

[Exception is very heavy](https://en.wikipedia.org/wiki/Exception_handling#Exception_handling_implementation), on compilation time, frame layout needs to be saved in image, on runtime, stack unwinding will be performed while raising. I prefer to throw exception in public obj-c methods if wrong situation is caused by bad input from caller.


Документ на "отлично". Мокапы не нашла :(


wtf is this file lol


@catalin-oancea use data() instead of dataset
https://jsperf.com/dataset-vs-jquery-data


Je vais voir si je peux le faire ce week-end. Mais faut me dire quels pdf tu veux.


hmmm... good to learn that! Thanks :-)

GitHub should definitely change that behaviour, though...


@AnriShitko


@tombentley @chochos please review this, thanks!


Answers posted. The first one about essential skills list my personal needs as well as the expected answers from the textbook.


Doesn't this prevent proper expiration of existing sctp connections?


Remove this line.


many nested loops codesmell


@catalin-oancea the == 1 part is redundant and could also be confusing. Switch 1 with true or remove it altogether.


This commit should have a better commit message. Since you already have a refactor commit though, just squash it into the previous one


Shit. Sorry, I was being rushed when I pushed it.


web conexinas


Having same problem on 3.3.5. The code is a little different:
  Dropdown.prototype.toggle = function (e) {
    var $this = $(this)

    if ($this.is('.disabled, :disabled')) return

    var $parent  = getParent($this)
    var isActive = $parent.hasClass('open')

    clearMenus()

    if (!isActive) {
      if ('ontouchstart' in document.documentElement && !$parent.closest('.navbar-nav').length) {
        // if mobile we use a backdrop because click events don't delegate
        $(document.createElement('div'))
          .addClass('dropdown-backdrop')
          .insertAfter($(this))
          .on('click', clearMenus)
      }

      var relatedTarget = { relatedTarget: this }
      $parent.trigger(e = $.Event('show.bs.dropdown', relatedTarget))

      if (e.isDefaultPrevented()) return

      $this
        .trigger('focus')
        .attr('aria-expanded', 'true')

      $parent
        .toggleClass('open')
        .trigger('shown.bs.dropdown', relatedTarget)
    }

    return false
  }

I tried commenting out the document.createElement('div')... item with the if statement, which is basically the same thing, but it didn't have any change. The menu closes up immediately on clicking the dropdown and it never displays the dropdown choices.

How could this still be  a problem so many years in a row?


Hi,

1 - I could to comment the lines with bug and provide some clarifications .. then you shouldn't need to make a diff

2 - yes, it works! You can fork the repository and run locally. Please open the file id-fix.html and check the browser's console. Please see the code: https://github.com/web2solutions/Veritaseum-proof-of-concept/blob/master/id-fix.html

3 - please just ignore the text-id.html ... please just test id-bug.html(with your original JS module) and id-fix.html (with the fixed JS module)


Whats with my bio, dude?


d'oh!


Интернет соединение - не функциональное требование (это вообще не требование, Вы же его не разрабатываете). Всё остальное - Ok.


@PCMan  I'm aware that it uses `XDG_DATA_DIR`.
The issue with `LXQtPlatformTheme::xdgIconThemePaths()` was `XDG_DATA_HOME` not being used. After testing it again..... `XDG_DATA_HOME` is used now.


Fixed with 39726740 - thanks!


Technically we don't need to protect this but I'd prefer to leave it under the lock which I find makes the function more readable.


Went the easy route: f8c45d89


Good catch.


:neckbeard:


youre telling me youve seen nanosecond precision clocks, clocks based on the tick-rate of the CPU, return the same value from two separate calls, on the same machine?

> The assumption that signature value is good enough is not sound (under multiple key algos)

How is that not? Its a value computed from the hash of the entire record, if two records have different signatures, they are different records, if they have the same signature, they are the same record.


@krispo I believe that this should fix the issue at https://github.com/krispo/angular-nvd3/issues/40

However I still have that exact problem after reinstalling angular-nvd3 with bower today (1.0.2). lineChart is not adjusting to full with of bootstrap column before resizing viewport/browser window. Anything I'm missing?

When loading:
![Before](https://dl.dropboxusercontent.com/u/15833598/graph_before.png)

After resizing:
![Before](https://dl.dropboxusercontent.com/u/15833598/graph_after.png)

I'm using these custom css modifications:

```css
.nvd3.nv-lineChart .nv-x.nv-axis line { stroke: none; fill: none; }
.nvd3.nv-lineChart .nv-y.nv-axis line { stroke: none; fill: none; }
.nvd3.nv-lineChart .nv-y.nv-axis .domain { stroke: none; fill: none; }

svg text {
    fill: #eeeeee;
}
```

And this is my chart options:

```javascript
$scope.options = {
	            chart: {
	                type: 'lineChart',
	                height: 450,
	                margin : {
	                    top: 0,
	                    right: 30,
	                    bottom: 40,
	                    left: 30
	                },
	                x: function(d){ return Date.parse(d.timeframe.start); },
	                y: function(d){
	                	return d3.round(d.value);
	                },

	                color: [
				      /* '#1f77b4', */
				      '#ff7f0e',
				      '#d62728',
				      '#9467bd',
				      '#2ca02c',
				      '#8c564b',
				      '#e377c2',
				      '#7f7f7f',
				      '#bcbd22',
				      '#17becf'
				    ],

	                transitionDuration: 300,
	                useInteractiveGuideline: true,
	                clipVoronoi: false,
	                showControls: false,

	                xAxis: {
	                    axisLabel: false,
	                    tickFormat: function(d) {
	                        return d3.time.format('%d. %b %y %H:%M')(new Date(d));
	                    },
	                    showMaxMin: false,
	                    staggerLabels: true
	                },

	                yAxis: {
	                    axisLabel: false,
	                    tickFormat: function(d){
	                        return d;
	                    },
	                    showMaxMin: false,
	                    staggerLabels: true
	                },

	                lines: {
	                	interpolate: 'linear'
	                },

	            }
	        };
```

And thanks for the awesome work!


These instructions aren't going to make a lot of sense until we actually cut a release and publish artifacts.


Don't use absolute paths!!!


@catalin-oancea use jQuery methods whenever possible. For example, you could've used $(this).html(...) here.


Ibidm.


What about the case where I inadvertently declare something as global, but forget to add it to the `var` list? Will jslint (or something else) catch this for me?


Колеги през вижуал студио пак може да се комитва. Гит се е конектнал по някакъв начин


In a pattern `_ => t` is translated to `[? x] x => t`.


Worked for me. Running global change test passes now:

apps=couch tests=global_changes_test_


Looks good, @CFanselow, and it's great to see you working with the grid tools and other new elements of the code. This would be a great inclusion in the plugin gallery, and now that it's packaged in a separate git repo it's just waiting for us to be ready.

There wouldn't be much work involved in making this plugin OJS 3 compatible too: using `$context = ...->getContext()` instead of `$press = ...->getPress()` is most of it. That's where plugin tests start to become important, because it's tiresome to test manually in several applications and maybe several versions.

- Plugin changes: I'm making some minor changes to the plugin API that will require some work in plugins too. This won't be major. I'll write up a blog post about it soon.

Thanks!


Fuzzy 该去掉的赶快去掉，别以后忘了到时候一看“写这么好开 Fuzzy 逗我呢”。


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.635](http://teamcity.monogame.net/viewLog.html?buildId=10427&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.634](http://teamcity.monogame.net/viewLog.html?buildId=10423&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:20:52


Actually this is fix for second tab. Problems: Empty fields. No open hours.


Роман, отличное замечание!

Александр,обратите внимание на раздел "Функциональные требования" - все то, что Вы там перечислили не является функциональными требованиями!


I'm surprised this went unnoticed for so long, but your absolutely right and the patch looks good.


@khanson679 That sounds like a good idea to me. Fixed in c3e8845d85d8d77fbf8e80f7e0e99fa531279d3f.


a better approach here, would be:

window['NAMESPACE'] = {};


@catalin-oancea the way jQuery works, you don't need to use a for loop to apply something to a set of elements. Also, instead of using $(...).style.display = ... for hiding / showing, use hide() and show() methods instead.


TeamCity pull requests :: netty [Build 338](https://garage.netty.io/teamcity/viewLog.html?buildId=1889&buildTypeId=pulls_netty&guest=1) is now running


@catalin-oancea use html() method


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.516.4459218b9b76ab67bdd041f86751874adc366af6](http://build.palaso.org/viewLog.html?buildId=63913&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:05:51


TeamCity pull requests :: netty [Build 338](https://garage.netty.io/teamcity/viewLog.html?buildId=1889&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:00


I'm sure you've mentioned this before but why does opening brace get it's own line only in the where-clause case?


single letter variables are ugly.


DVDAudio.h:76:10: error: 'double CDVDAudio::GetDelay()' is protected
   double GetDelay();

Lol - thanks much :-)


I came 2 minutes too early - now repackaging for OE :-)


yes, certainly. but it will depends of your personal settings which is being used to validate your code on Lint. You may to set up a more restrictive test and a very flexible(negligent) test


"like"


web.IsNode64bitAvailable is still referenced in nvm.go, so this will not compile


Remember syncing with upstream/master!


> 1 - I could to comment the lines with bug and provide some clarifications .. then you shouldn't need to make a diff

Is this the best use of the tools and practices available for showing your changes?

> 2 - yes, it works! You can fork the repository and run locally. Please open the file id-fix.html and check the browser's console. Please see the code: https://github.com/web2solutions/Veritaseum-proof-of-concept/blob/master/id-fix.html

Does it work *as intended*?

What is the purpose of `_all_ids`? Does it serve that purpose as written?

What does `.close()` do? What *should* it do?

> 3 - please just ignore the text-id.html ... please just test id-bug.html(with your original JS module) and id-fix.html (with the fixed JS module)

Perhaps the recommended testing procedure should be part of the `README`?

Are your tests easily automated?


Nice. :+1:


in this case, a right approach would be to declare the global var as a new property of window object (if you are on browser)

window['NAMESPACE'] = {};


Is `window` portable?


WARNING! I am going to do some edits on wine. Use `git pull --rebase=preserve`. @lmy441900


the use of the 'strict' pragma is a good idea too


codesmells,no actual purpose of classes


And if you are not in a browser context?


Здесь не критично, обязательно писать при работе с сетью


browser.touch triggers for me in chrome even though I'm on desktop, making this not useful on desktop


On terminating the game the terminal turns blue.. Control to the terminal is not returned properly.


I though it was necessary to get debug to run, but it looks like maybe not.


> the use of the 'strict' pragma is a good idea too

Care to add that to your code?


It was breaking the PHP installation because the `mbstring` extension wasn't installed and (I'm totally assuming here) your bio had multibyte characters in it. Either way, [the fix was to require the mbstring extension](https://github.com/purplapp/purplapp/commit/3ad846fb156988f34afc80db3bc7ba9156890890#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780R29) not this commit (tho this commit makes the code a lil cleaner)


I'm currently implementing this, have to work on it a bit more to get it clean, before committing. In my opinion this could make `smrt orthologize` obsolete; an `orthologize` method could be part of `MarkersAndTaxa` and which is called in `bbmerge`, taking the unmerged list of alignments, as `smrt clademerge` does. Do you think this is a good idea or should user interaction with the merged alignments still be possible?


Thanks!


The above is a no-op. Probably even optimized away.


This is just a carryover from Windup 1.x. You are probably right, but I'm not sure that we should address it until we are ready to actually support xhtml pages.


@ccx-testerbot runtests master


Yeah it's not playing nicely with [react-router](https://github.com/rackt/react-router). Some of my Td's contain links to go to the individual page for that row item. I've tried manually passing in context via props to my child Tr's. I've tried passing in the context to the Table. I've tried specifying `getChildContext` to include the router. I've tried changing it to `(new child.type(child.props, child.props.context)).render()` when I pass in the context props. This is the error that comes up: https://gist.github.com/jimfb/0eb6e61f300a8c1b2ce7 . The owner is the table (I think, it might not actually have an owner), and the parent is my component which holds the `Table`. They differ and it's currently taking the owner context.


@bughit,
Yes. It is one of many techniques to achieve the same end effect. In this particular instance, it is only adding an instance method, but I could potentially add class methods later on (as I have done in some of the other mixins). It is really consistency of technique.

Unless this becomes a real drag on performance (which it should not), then it seems OK to me. However, I am not dogmatic about this. If you think this there is a better alternative, I can certainly merge that in, if the tests pass, and the alternative is provably better.


TeamCity pull requests :: netty [Build 339](https://garage.netty.io/teamcity/viewLog.html?buildId=1890&buildTypeId=pulls_netty&guest=1) is now running


@catalin-oancea if #toggle_groups and .toggle_groups have different functionalities, you shouldn't point that out by making one an id and the other a class. Use a class for both if they share css properties, or else use ids.


@catalin-oancea do not use for


@catalin-oancea use html()


Thank you for the request. It has been added to the queue (id: 99). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/99) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


On Wed, Sep 30, 2015 at 08:40:16AM -0700, Ben Martin wrote:
>    Adding this code fixed my compilation problem on 5.8.8. Thanks!
>
>  #if defined(PERL_IMPLICIT_CONTEXT) && ! defined(tTHX)
>  #  define tTHX PerlInterpreter*
>  #endif

Great. Thanks Ben!

Tim.


Can you explain?  This code was duplicated on line 941 (branch 1) and very close on line 958 (branch 2).  The original branch 2 code was where the exception occurred, since it was a compound conditional, and sctpConn was null, causing an NPE later.

I believe the only code that makes changes that might not run is line 933, attempting to get the Endpoint.  I don't see any side effects of calling getSctpConnection.


@catalin-oancea use hide() or show()


How long did you wait for setup to complete?


For the situation where the developer waits in a loop for a query submitted in a previous frame, if the first iteration of the loop returns "false" for the query's availability, then no, the loop must not complete. Essentially, the query's availability must be "latched" the first time it's fetched in a given frame, and return the same value throughout the frame.

I think this spec text already states this. "Repeatedly fetching...without returning control to the user agent...must always return the same value."


Thank you!. I have been looking for something like this hopefully it will help all the struggles I have atm.

Thanks again for sharing.


For a tool that is likely going to be frequently updated (and not distributed through package management) we may just want to document extracting it to local directory (and leaving adding to path as exercise for user)


Critical sections inside spin locks should be as small as possible. I could have made this slightly smaller in-line with that principle by moving the spin_lock call inside the switch, but decided against it because there would be a readability lost and moving one branch out of the critical section is of minimal benefit.

This might be splitting hairs, but moving a function call that does an atomic increment outside of the critical section just barely meets my gut instinct for a beneficial change. Given that this function is small, I do not believe there is any difference in readability.

I found this when doing a partial audit of our critical sections where preemption is disabled after hearing a somewhat stale criticism (pre-0.6.5) in IRC that we are not as preemptible as we could be that someone who does realtime audio made to p_l.


If tar is available on osx, maybe use same format for all releases.


I like what you did here.


Thanks, @foghina!


there's still a hole somewhere that makes audio pts jump ...


@catalin-oancea use data(), and use a more appropriate toggle, like 'not'.


I think of an (angry) email I wrote last weekend :-) concerning Audio PTS ;-)


Ahh thanks for the info.  If theres anything I can do to help inbetween working let me know.


About a minute? 45s?


buf.writeAll(typeArguments.map((t) => t.linkedName), ', ');


@catalin-oancea Good work on this, but for the javascript part you should always check the documentation before. And remember, it's javascript, not C! Use methods where appropriate.


Ah, you're right. I designed this against the old style of API. I'll switch it over tonight


I had the same problem in the  past with quaternions in Ogre3D. The normalized quaternion for rotating 180 degrees around Z axis is (0, 0, 0, 1) = (w, x, y, z), if Z is the up axis in cyphesis.


I'll require it in an initializer so we don't have to do that


When the player is in contact with the ladder and the bottom floor if you press the down arrow the player goes into the wall


With the original code, buffer->used ended up right, but not now.


Looks like this sentence is missing a "the" >> "We assume that THE waypoint is rendered within at most one scrollable container".


Will it? I didn't see it in my `autoload_paths` so I assumed I had to add it. You might be right


While `/scripts/avocado run --loaders ?` results in:
```
Loaders: ['@file']
Types: ['NOT_A_TEST', 'MISSING', 'SIMPLE', 'BUGGY', 'INNER_RUNNER', 'INSTRUMENTED', 'ACCESS_DENIED', 'FILTERED', 'BROKEN_SYMLINK']
```

`./scripts/avocado list --loaders ?` results in:

```
Traceback (most recent call last):
  File "./scripts/avocado", line 31, in <module>
    sys.exit(app.run())
  File "/home/cleber/src/avocado/avocado/avocado/core/app.py", line 64, in run
    return self.parser.take_action()
  File "/home/cleber/src/avocado/avocado/avocado/core/parser.py", line 103, in take_action
    return self.args.dispatch(self.args)
  File "/home/cleber/src/avocado/avocado/avocado/core/plugins/test_list.py", line 167, in run
    test_lister = TestLister(args)
  File "/home/cleber/src/avocado/avocado/avocado/core/plugins/test_list.py", line 35, in __init__
    loader.loader.load_plugins(args)
  File "/home/cleber/src/avocado/avocado/avocado/core/loader.py", line 120, in load_plugins
    % (names, self._test_types.keys()))
avocado.core.loader.LoaderError: Loaders: ['@file']
Types: ['NOT_A_TEST', 'MISSING', 'SIMPLE', 'BUGGY', 'INNER_RUNNER', 'INSTRUMENTED', 'ACCESS_DENIED', 'FILTERED', 'BROKEN_SYMLINK']
```

I'm reporting because probably either `--list` is not intended to support `--loader ?` or the traceback is not intended.

Also the red color in the output doesn't go along other similar output. Red has, so far, denoted errors in Avocado, while blue is common on some other output.


@behlendorf In all fairness, this is something that would not be caught by the analysis tools that most of us use and we had many bigger bugs to catch.


Maybe this should join on the current locale, or perhaps the context (press) locale? In any case the English locale shouldn't be hard-coded.


do you not want to include the case where message starts "@nick ..."?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.635](http://teamcity.monogame.net/viewLog.html?buildId=10427&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:19:16


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.636](http://teamcity.monogame.net/viewLog.html?buildId=10431&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Since you're constructing a custom return array, it would be useful to provide some documentation of the returned structure.


Done.


Good catch! And yes, they can be reversed. I'll push an update.


m: Numeric representation of a month, with leading zeros(01 through 12)
M: A short textual representation of a month, three letters(Jan through Dec)


Obj2E_ChkEggman:			; XREF: Obj2E_Move
		addq.b	#2,$24(a0)
		move.w	#29,$1E(a0)
		move.b	anim(a0),d0
		rts			; Eggman monitor does nothing

You don't need any of the stuff besides the label and rts. It looks like you duplicated the code under MonitorTypes. Obj2E_ChkEggman and Obj2E_ChkS can also be replaced with Obj2E_ChkNull.

You should tack another Obj2E_ChkNull onto Monitor_Subroutines so the Goggles Monitor doesn't cause a crash.


It looks like the commit message ("with AssertionError") doesn't match the exception that loader is raising:

```
...
except loader.LoaderError, details
...
```


Oh, yeah, good remark on the colors, and I haven't tested it with list.


Better to use `$request->url` (or `$dispatcher->url`) to construct URLs into OMP.


thats what i wanted to make work here because it didnt before,
not sure if it worked before or i simply failed at refactoring


@timperrett Could you please publish a new release? :)


Using `$request->url` or `$dispatcher->url` would make this unnecessary.


won't you leak this str?


I'll move and doc it, fair point.


[latest release] isn't an actual link


 Fix little typos in start_services.sh
Delete one extra whitespace character. Write timemachine in one word not in two.


@jeremy : Suggest that the following message be changed:
```
DEPRECATION WARNING: Accessing mime types via constants is
deprecated.  Please change:
  `Mime::JSON`
to:
  `Mime::Type[:JSON]`
```
to
```
DEPRECATION WARNING: Accessing mime types via constants is
deprecated.  Please change:
  `Mime::JSON`
to:
  `Mime::json]`
```
based on the above commit 5ba4e4a


Not fully working just yet, but it's close
On Sep 30, 2015 1:01 PM, "Anthony" <notifications@github.com> wrote:

> Thank you!. I have been looking for something like this hopefully it will
> help all the struggles I have atm.
>
> Thanks again for sharing.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/xboxfanj/device_oneplus_bacon/commit/89fa4a098480efa8c803bab130a3bdfbb02bd76b#commitcomment-13524468>
> .
>


@joolswills why did you remove hciconfig hci0 pscan? If more than one controller will be paired it is necessary to enable pscan for every controller again. If this line is removed it is not possible to pair more than one controller at a time.


Das wäre dänn s'spring bean config file. D.h ich müesst da s'mapping property hinzuefüege?


@jgranick The cffi test is now failing since this commit. See https://travis-ci.org/HaxeFoundation/hxcpp/jobs/82775643#L1561-L1573


> Is this the best use of the tools and practices available for showing your changes?

We can use differ solutions, but there are different approach, like the software DiffMerge ... the github by itself will show you all the changes made on file based

> What is the purpose of _all_ids? Does it serve that purpose as written?

_all_ids holds a collection of resource IDs. For the currently module, it does not make any effective sense, because this collection is inside of the constructor scope, it means it will not store any new ID on same scope. Then no, it does not serve the purpose of having a collection of resource IDs.

althoug, declaring it outside of the scope, it could provide support for storing a collection of resources if you need to list registered resources on any part of your application.

> What does .close() do? What should it do?
It is being deleting the stored resource id from _all_ids collection. It also sets a flag that is not being used on any part of your code.

Well, if the programmer intention is to have a collection of resources, it should to delete the resource id from it, the problem is, how I mentioned before, the implementation has fail in terms of scope when declaring _all_ids.

> Perhaps the recommended testing procedure should be part of the README?
Sure! I'm sorry. You just mentioned "what is wrong with the code?" ... I could be more pro active .. I'm sorry

Are your tests easily automated?
Yes, the pattern used on this code is easily automated


Still getting a couple compile errors, since I haven't used a tree like
this in awhile, but it'll get there.
On Sep 30, 2015 1:10 PM, "Jake Weinstein" <xboxlover360@gmail.com> wrote:

> Not fully working just yet, but it's close
> On Sep 30, 2015 1:01 PM, "Anthony" <notifications@github.com> wrote:
>
>> Thank you!. I have been looking for something like this hopefully it will
>> help all the struggles I have atm.
>>
>> Thanks again for sharing.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/xboxfanj/device_oneplus_bacon/commit/89fa4a098480efa8c803bab130a3bdfbb02bd76b#commitcomment-13524468>
>> .
>>
>


make a defensive copy


Thanks, @CFanselow. FYI, we've been speaking a bit with Smithsonian about what I think is a similar feature, but don't have much information on yet; when we get more details I'll pass them along to you for some comparison. It might be worth integrating into OMP itself if there's enough overlap in requirements.


Coins at the rightmost place are coinciding with thee wall and the ladder
![screenshot from 2015-09-30 23 39 16](https://cloud.githubusercontent.com/assets/14835842/10202071/c4b1d96c-67cc-11e5-9416-9e666ac3e793.png)


this change has no effect


proposals/Strange Loop/2016/How to Conference.md

I suppose I was guilty of this at Strange Loop this year. I talked to a lot of locals quite a bit. Perhaps that's a clue that a lot of us are introverts, or at least uncomfortable with talking to people we don't know.


Yes victory! :-D


```type``` is a python reserved word, please avoid using.


additionally we can test for classes (companion objects, objects) too


I skipped last year. I tend to go to a conference a few times, then stop going, because the returns diminish over time. The reason I decided to attend this year is that a lot of people I know only from online were coming in and giving talks. I got to meet a few of those and have some deeper conversations with them.


Pretty much just makes the places that use it easier to read and encapsulating the logic (even though I don't see this changing any time soon). I could inline it if you think it's overkill.


`g:fzf_command_prefix` isn't yet working on `:History`


@limptwiglet Yes, please send -- also, the test project would need to be available at a public URL -- if not, you can drop the test file into it's own directory in `./backstop/test`.   Thanks.


finish() didn't have any user-visible side effects until now. Chrome's implemented finish() as a flush() for some time now in order to avoid performance problems with applications incorrectly using finish(). (finish() was left in the spec to avoid deviating from OpenGL ES.)

I'll try to write some more text describing when the "frame counter" is incremented.


Why? The recusion leads the better (easier to debug) stack trace, which may be quite important.


@lehni There is one mistake in my comment in line 1801. We are not looking for the smallest, but for the highest curvature.

So it should be
// Select extremum with highest curvature. This is always
// on the loop in case of a self intersection.


Great :D


I was going up to Philip Wadler during a break at RacketCon. He was having a conversation with Matthias Felleisen about types. It was interesting to be a fly on the wall for that conversation. I wish I'd been able to hear more of that conversation.


Hm. Takes me much longer, and I can't reproduce the bug. Do you have anything else in the cur directory?


Meu primeiro programa


can't remember - but I guess because it wasn't needed or didn't seem to be. You were also not around to consult with :) Are you saying that it doesn't work to pair a second controller now but re-adding that one line solves it ? In which case please submit a pull request.


Still amazing work so far. Hope you get there in the end.


@dbmeneses you've replaced fileData.needBlame() by fileData.revision() != null, but it's false : if a file need a blame, it's because it's hasn't a revision.
Because with current implementation, you're always sending SCM info in the report, but replacing != by ==, it's only send when needed.


You wrote this?


I wonder if this change is actually needed - keeping it as a static variable saves memory if the HID_ class is instantiated more than once (though I guess that will never happen, making this a bit of a non-issue of course).


Commit message was wrong, should be "Adds code to avoid moment.js deprecation warning"


RacketCon definitely felt like I was an outsider looking in at the community. But I took it as a chance to get a glimpse into the community. And perhaps as something I'd like to join in the future.


The schema needs to be its own class, `Schema`, as I put in the code:
```python
[...]
self.rels = self.relationships
self.schema = Schema(api=self._api)
```


Yes of course, will fix it!


This looks good!


Note: in PHP 7 you can use anonymous classes.


ready to merge.


This will not have the expected effect and in addition seems to be incomplete regarding ..plugins-ugly, ...plugins-good, ...plugins-base etc.


Yes, critical sections should be as small as possible.  But my gut tells me that in this case you'd have a _very_ hard time actually measuring any kind of impact from this change.  And even if you could it's most common use is when setting an ACL which is fairly rare.  This change would also cause our implementation of this function to differ from the kernel's equivalent which calls `posix_acl_dup()` under the spin lock.  I stand by leaving it as is.


Note there were a bunch of changes made to the script including some additional checks, so it might have been accidental.


This `properties()` needs to be in the `Schema` class and be a regular Python `@property` with *getter* and *deletter*.


Alex created a Slack instance for Strange Loop this year. It was pretty popular, and would help make those kinds of connections more easily. But this kind of thing will always be difficult, as people are all over the place going to their hotels and making last-minute decisions, or missing each other.


@heaversm What version of Chrome are you using? Do you have the Touch Emulation turned on, or are you using it with a touchscreen device?


Nope, I did a git clean before and I get the same thing. The error is in stlc.rkt in examples/


So simple and yet it would be difficult to use PHP 7 anonymous classes here.


@behlendorf I am fine with being consistent with the mainline kernel, but now I am likely to send a patch to mainline. Could we revisit this if/when the mainline kernel changes this?


I actually intended it without "the". I think it is fine either way. I'm going to merge this as is, but if you feel like we should change it, then change it! :)


"as explained in the README" ... will a reader who sees this comment on http://package.elm-lang.org/packages/evancz/elm-markdown/latest/Markdown know what is meant by "the README"? Isn't it better to provide a link?


The test suite finished running the test files. Below is a summary of the test results:

| Report name | Tests passed |
| ----------- | ------------ |
| _Broken | 15/15 |
| _DVB | 5/5 |
| _DVD | 3/3 |
| _DVR-MS | 2/2 |
| _General | **23/24** |
| _Hauppage | 3/3 |
| _MP4 | 2/2 |
| _NoCC | 10/10 |
| _Teletext | **20/21** |
| _WTV | 13/13 |
| _XDS | 34/34 |
| _Options | **83/87** |
| _DTVCC | **0/14** |
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the [results](http://ccextractor.canihavesome.coffee/reports/99) page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.


tools: attributes only apply on the visual editor within the IDE and are used to have a sane preview of what the screen will look like with content; android: on the other hand is the real deal.
It's safe to remove if you want us to get rid of the xxxx string. It was just handy during dev to quickly check spacing changes :)


@ryao specifically I'm surprised because this sort of thing is usually caught quickly by kernels with CONFIG_DEBUG_ATOMIC_SLEEP set.  This causes might_sleep() to make a lot of scary noise on the console when things like mutexs are used under spin locks.  So why wasn't this noise ever reported?


I don't get why people include that shit in their projects.


How does the "Require Valid JIRA Issue(s)" work when a developer has made multiple commits to his branch locally  and not all commit messages include the JIRA ID? Will it be rejected? Or will they be able to merge the branch back to the master, even if each and every commit message does NOT have the JIRA ID, as long as one of the commit messages has a valid JIRA ID?


@birdage you didn't define this function


Missing module docstring.


Translation to Spanish


How does the "Require Valid JIRA Issue(s)" work when a developer has made multiple commits to his branch locally and not all commit messages include the JIRA ID? Will it be rejected? Or will they be able to merge the branch back to the master, even if each and every commit message does NOT have the JIRA ID, as long as one of the commit messages has a valid JIRA ID?


subtle: `[]error` gets interface-converted to `multiError` in `Add()`. I was going to suggest adding another test using `multiError{errors.New("something-else")}` but maybe that's overkill?


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.62.57b5203f9edbe6463438e82381868fd9fb698ca7](http://build.palaso.org/viewLog.html?buildId=63915&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:32:50


thank you, it really works! I've managed to connect my Rails 5 --api app with Ember.
One question: is it possible to send only IDS in base model without nested models? Example:

class PostSerializer < ActiveModel::Serializer
  attributes :id, :title, :content
  has_many :comments
end
That would generate:

{"posts":[
  {"id":1,"title":"First post","content":"Post 1 content","comment_ids":[1,3]},
  {"id":2,"title":"second post","content":"Second post content","comment_ids":[2]}
 ]
}
As you can see, there is no "comments" section. It would be very useful with Ember {async:true} associasions.


Yes, but the link you provided would not have gone anywhere. It was `#code-blocks` which would look for that within the current page, which is a dead end.

It'd be fine to say "in the README [here](...)" if we can provide a reliable link.


@ccx-testerbot runtests master


Code smell: Too many if else statements. Loop has very high cyclomatic complexity.


@ropilz  hey man. my ios app recently faces some odd issues. it just exists when I tap the icon. I am using the 0.1.2 version and when this happens I get no notification, reinstallation of the app fixes the issue for a while. (i mean starting app for the second time which then it crashes again!!)
I tried to inspect the log but as far as I go it didn't turned out anything. the IOS crash report says it is a "Exception Type:  EXC_CRASH (SIGABRT)" type of crash which is related to some bad behaviour of the app logic like divide by zero or something like that. I strongly suspect that it relates to my parse plugin.

i tried to use the
<gap:plugin name="medlei-parse-push-plugin" version="~0.1" source="npm">

version but then I get this error.

Building status: error (Ld build/ApplicationTemplate.build/Release-iphoneos/ApplicationTemplate.build/Objects-normal/arm64/ApplicationTemplate normal arm64
(1 failure))

can you help me to explain whats going wrong?


nit: re-aligning a struct makes more sense when there's lots of them in memory, or in other niche use cases. if we're doing it here just to shut up the linter then perhaps we should adjust the linter to not complain about something trivial like this.


last time that I walk to the cafeteria to get lunch...


> if they have the same signature, they are the same record.

Incorrect. You're assuming that all keys used to sign henceforth cannot produce the same signature value for different output.

- two different keys from the different or same algorithm, signing different values, might produce the same signature value
- two different keys from different algorithms, signing different or same values, might produce the same signature value
- two same keys from an unexpected algorithm might produce the same value.

You cannot assume that (a) under multiple keys, (b) under multiple key algos, the values are guaranteed to be different.

---

note that the records themselves point to the keys, so you don't even know the record is the same unless you compare the record value (or the _hash of the record_). But not the signature value. You _could_ end up with the exact same signature value.

---

Also, the reason to use _the record itself_ and not _the hash of the record_ is that you may be comparing records arrived at by _different_ hash functions. for example,
- i make record R.
- i link to it with sha2 as "Rsha2" -- producing `Qmfoooo...`
- i link to it with sha3 as "Rsha3" -- producing `8tfooo...`
- `Rsha2 != Rsha3`
- you would have to build in an assumption about what hash function to use.
- you have the bytes, why not compare them. it's faster than hashing it again.


Hmm, gonna have to think about that. At Strange Loop, I suppose I mostly started out talking to people I knew. I guess that greased the wheels for me to make it easier to talk to people I didn't know, like when I stepped up to a table to eat lunch.

One thing I did at Windy City Rails was to purposely jump from table to table to talk to more people. (I didn't really know anyone there.) I also had (by accident the first day, and on purpose the second day) a bug St. Louis Cardinals cup. That caused people to come talk to me about St. Louis. (Everyone mentioned how cool the City Museum is.)

Another probable factor is that I know my current contract will end in 2 months, and that I'm trying to move to Chicago or SF later next year. So I'm trying to find out what I want to do career-wise in the future. Talking to more people helped me make progress in that quest.

But I suspect the biggest part is that I've been working at it and the practice has started to pay off.


why don't we want to check for formatted code?


Thank you for the request. It has been added to the queue (id: 100). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/100) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


Because everything is non-static, you can now instantiate PluggableUSB_ multiple times. I presume this is not going to happen? One disadvantage of non-static members is that they are a bit less efficient: Whereas a static member has a fixed (known at compiletime) location in memory, non-static members always need to referenced relative to `this` (and the compiler doesn't seem to be smart enough (yet, even with lto) to recognized that a class is singleton and optimize the member references). This mostly translates in slightly slower code, but also bigger code.

Having said that, using non-static members is the most idomatic way to solve this, so perhaps that would be ok. Perhaps you could compare the code size before and after this change?


Was also kind of surprised this was in here at all.  It might be good for drastic measures but I didn't expect it to be commonplace.  In addition, this file doesn't show up until you make an adjustment to the logger.  Anyone who goes in here right after installing might be confused.  That being said, I wasn't going through editing logger...I was just correcting the path:P


Nope, strndupa uses the stack.


Well how this could have passed through review. It's not PHP ^^


Done.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.636](http://teamcity.monogame.net/viewLog.html?buildId=10431&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:20:17


I will change that. ty.


ouch... didn't it was dup**a**, disregard :)


encaptur**e**as


You right this can be fix that's way as well but I didn't want to change the message status spaces because I did not know all the implications. But now that morpheus suggested to not display the notification in case of status error I can get rid of this altogether.


You should write a tool to fetch lunch for you ;-)

Or instead, a crontab job that runs apk-crawler all the time and sends a push message to your phone to ask permission to upload :-P


This code should not need to be scattered so far around in the file, and $inf as a variable name is not particularly informative/descriptive.

It's also kind of hard to follow.  Not sure if $dobcheck is true when the DOB is valid, or invalid...

Would like to see a cleaner implementation, or at least some additional comments before bringing this into the official codebase.


Thanks for this, the 2.0 newline behavior was really bothering me too.


OK, i was thinking the user pushes all kinds of jobs into the queue. When he presses  "process the queue" the queue autopilots the GUI (or no gui) and renders the still / keyframe / flight.


string representing the current word in window in SAX notation or nil if the word is incomplete


Actually it is only necessary for XWebView target (main target). XWebViewTests target should be set to `NO`. Some dependency managers may crash build if it is enabled for test target (aka Carthage).


Your idea is good. I am not against but we have to keep the NtStatus. The goal of moving to NtStatus is to give to opportunity for the dev to return whatever they want to the driver.

Your enum is good :) ! But if I can propose, we should add at least all of this
https://github.com/dokan-dev/dokan-dotnet/blob/master/DokanNet/NtStatus.cs#L349
I checked all `/*VERIFY*/` and they are correct !


:+1:  I stared the link


Лишняя пустая строка в конце.


I guess I should also point out that the other addition in this commit is the stamp_coordinate variable in each star: now if possible each pixel on a star has a coordinate where it should be the case that moving one pixel over = adding one to the coordinate. This is needed if you must both (a) ravel a 2d star to 1d and (b) apply some operation that depends on the distance (in 2d) between two pixels.


Check the commit message :)


We can, but I really don't think there's anything to be gained here.


Oops.


Code Smell: God object: main() could have been modularized. It knows too much and does too much..


[distribuicao uniforme.py](https://github.com/facciolo/Ciencia-dos-dados/files/5437/distribuicao.uniforme.py)


Ooops. this is defined twice, I'll remove the redundant one for the release.


code smells:duplicated code


Don't need to change just for this comment, but this can be `check.NotNil` now.


Glad to be of help ;-)


better avoid hard coding for a good game.


Lazy class / Freeloader: print_board() is not necessary. It does too little. Could have been a part of the  bard class


Too many parameters.


:cry: :sob: :sob:
This is a scripting language, :wink:, let's do a for/while loop


For packageServices


I think we should consider break BC here and ignore type of default value entirely in PHP 7+. It was always bizarre behavior very few people have really known of.


Right. I guess `../#code-blocks` should be a reliable link. Because at that point the current page is something like http://package.elm-lang.org/packages/evancz/elm-markdown/1.1.5/Markdown, so `../#code-blocks` will point to http://package.elm-lang.org/packages/evancz/elm-markdown/1.1.5/#code-blocks. Which should be what we want. (For example, at the moment http://package.elm-lang.org/packages/evancz/elm-markdown/1.1.5/#basic-usage exists, and with the current content of the README on GitHub the anchor `#code-blocks` instead of `#basic-usage` will also exist.)


Not that i care too much, more for my understanding:
1. Can we have that instead `final Class<StaticLoggerBinder> staticLoggerBinderClass ` ?
2. Can we have that instead `final StaticLoggerBinder staticLoggerBinder = (StaticLoggerBinder) staticLoggerBinderClass.getMethod("getSingleton")`, and avoid the reflection?


> And if you are not in a browser context?

You may use global or GLOBAL on node

> Care to add that to your code?

I'm doing it right now and write a more explanative README too


TeamCity pull requests :: netty [Build 339](https://garage.netty.io/teamcity/viewLog.html?buildId=1890&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5610, ignored: 21 Build time: 00:36:44


code smells: long function


I think this also needs a trailing newline


I forgot to add the #ifdef __cplupls here.
I will add it.


Hmm, er du alle russer?


reason for catching this `ReflectionException`?


Code Smell: Downcasting: Person depending on Board  is a type cast which breaks the abstraction model.


@behlendorf Good question. My guess is that the zrl is rarely held when we enter this code path, such that we skip the lock:

https://github.com/zfsonlinux/zfs/blob/master/module/zfs/zrlock.c#L81


the test is called `...OneFileChanged` but two files changed? :)


Done.


@ccx-testerbot runtests master


I'll add it.


I'm monitoring the code size during each "refactoring", the increase in size you mentioned is biased by removing the `modulesCount` field as I've anticipated (I'm still finishing up the commit it will come in a couple of minutes).

Here the results:

6132 / 236
6148 / 242 (virtual methods in PUSBListNode)
6098 / 242 (PUSBListNode all initialized through initlist)
6056 / 243
6090 / 244 (removed static fields)
6140 / 243 (no static fields/methods in Pluggable USB)
6082 / 242 (removed modulesCount)

so you're right, removing static fields leads to a sligh bigger code, but in the end the balance is positive anyway.


No comments that can explain what is happening there.It is better to write comments such that any user can understand easily.


Thanks for this, I did this manually and it fixed the problem. Why didn't this get pulled into the main Jerffrey vagrant repo?


updated my name


What is the assignment?  Description?


One file with non-private changes,


Why initialize capacity here? Also, why make it 0?


Prototype: the difference between `new MyRouter({enableRouteData: true})` and `var MyRouter = Backbone.Router.extend({enableRouteData: true})`. You're likely going to want this on a class level, not an instance level (otherwise your handler methods will get confused about what arguments they should take).

Let's experiment with removing the array parameters. I think parsing to an object is much nicer.

You raise a good point about regular expressions though. Currently they're not an issue since [we just treat all](https://github.com/jashkenas/backbone/blob/7f757696cc84aa23e0242eeb292addaba29a1eb8/backbone.js#L1528) matches as an array of arguments. We could just give you an array of matches on the params object if they're not named.


I think you mean capacity.


Xu,

Thanks for the fix and I can see that the fix has been pushed to the online generator.

Tom.


Thank you for the request. It has been added to the queue (id: 101). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/101) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


the `class...` dir contains tests for pacakge, is it ok?


Changed this section a bit. Thanks


`!frameState`?


still yet about the close method ...

I told it is deleting the resource if from the _all_ids collection ... the problem is, the delete keyword shall to be used with associative arrays ... for the currently  _all_ids array, we should use something like split


typo


Well if we use static, we can then switch to normal c functions, without a class. This should be tried at the end of all refactoring since we now remove the modules count etc.


Code Smell: Excessive use of literals. These should be coded as named constants and should be externalized into separate resource files/scripts.


> I would lose the order of param names if I used namedParam and splatParam separately

The splat always comes at the end. It doesn't make sense for a named parameter to go after a splat. (I don't even think you can interchange splats and named parameters without some nasty bugs).

> But then I'd need to do `paramNamesRegExp.exec` multiple times on each route till no matches left

Are you sure about that?

```js
var routeStr = 'foo/:bar/:baz/*splat';
routeStr.match(namedParam); // [':bar', ':baz']
routeStr.match(splatParam); // ['*splat']
routeStr.match(namedParam); // [':bar', ':baz', '*splat']
```


the newline gets added when the error is printed


It seems it is better to create new directory for these tests. I'll do it.


wording


issue on that define
Not working on RH6


Don't use fmt and %.


there are a few cases in the CI output where a newline is missing, not sure exactly where it should be though


@LuiNova is this the same function that draws stars in the detail page? If so, you can move it to a utils file and reuse it everywhere.


Please see https://github.com/magnumripper/JohnTheRipper/issues/1792   Your input would be appreciated, since you are the one who has put so much work in on this issue.


This would be better run as a separate fabric task as the mesosbox user.


Oops! Thanks for removing that :)


Agreed, this changes has no effects for now, because private top-level val's are public static constants in JVM bytecode. So this commit is a little premature. I'll delete it.


Im pretty sure you mean "LocalBroadcasterManager", not "LocalBroadcaster manager"


Great stuff!


The test suite finished running the test files. Below is a summary of the test results:

| Report name | Tests passed |
| ----------- | ------------ |
| _Broken | 15/15 |
| _DVB | 5/5 |
| _DVD | 3/3 |
| _DVR-MS | 2/2 |
| _General | **23/24** |
| _Hauppage | 3/3 |
| _MP4 | 2/2 |
| _NoCC | 10/10 |
| _Teletext | **20/21** |
| _WTV | 13/13 |
| _XDS | 34/34 |
| _Options | **83/87** |
| _DTVCC | **0/14** |
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Please check the [results](http://ccextractor.canihavesome.coffee/reports/100) page, and verify those files. If you have a question about this report, please contact @canihavesomecoffee.


An error occurred while running the tests. Please check the [status](http://ccextractor.canihavesome.coffee/test/101) page, and correct the error. If you have a question, please contact @canihavesomecoffee.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.495.50c2db794dfd1923f8a64b3b54d4c942c803c99c](http://build.palaso.org/viewLog.html?buildId=63925&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:06:13


@JanTvrdik :+1:


Ouch, turn around.


@lehni Introducing `c1p1x` etc. at the beginning is a good idea, I was thinking about this.

So far all your changes make sense to me. But you do not want to catch cases where `param` is `null` or `undefined`?


> I want the worker to skip these static directories. If I give it a default value it will fail if the directory does not exist.

Is this a response to something else?

My thought is that if you pass an empty queue name to boto it will crash anyway, so might as well provide a reasonable default or fail-fast here.


`private @Self() cd` doesnt work?


I find this label rather odd: the whole page is 'Show Alerts', not this filter?


@ccx-testerbot runtests isdb


Nothing to say here, very clear code, that removes the bad (but very common) habit of using the double pipe to execute the second command when the first one returns false. We can probably do *checktools realpath* too before setting *TOP*.


Yeah it still doesn't work if it's the very first word. Could you just use `(^|\s)@?`?


Thank you for the request. It has been added to the queue (id: 102). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/102) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


I assumed a very wrong use of the _all_ids array ....

first at all, it does not store any resource id ... it stores a value to be associated to _expensive_resource ...
although, there is no public method which let you tho provide a value for _all_ids[ id ] ...
then, the statement if (_expensive_resource == null) always will be true!!! .. in this case, the array _all_ids is not necessary, then you can simply return _expensive_resource = { value: "I'm a very expensive resource associated with ID " + id  };

btw, the delete keyword on close method, is not right. The _all_ids still being unnecessary, then you dont need to delete it ... the NAMESPACE._closed flag still not being used


SLAM


Why is it possible to have `NgControl` without `control`?


May I ask you to edit this to:

`libKeyFinder` uses [`qmake`](http://doc.qt.io/qt-5/qmake-manual.html), which is distributed with Qt, to generate `Makefile`s.

Otherwise this pull request looks great; I will merge once this change is made. Thank you!


ewwww. I think some parentheses would be really nice here. → `b = (te instanceof…)`


It would be good to have a object that represents an entire card:

card : {
name: "King",
value: 10,
suit: Suit.HEARTS
}


It seems like this would include all keys in Redis.  Probably including keys that manage other resources like `REDIS_LIST`.  Possibly [HSET](http://redis.io/commands/HSET) is what you're looking for?  Not sure about the values being lists though, may be possible.


Oops.


Is there an extra space after the `else`? :space_invader:


nope, tried with `((?:^|\s)@?)`


If we continue sourcing this from github, probably should version against a tag/release.


Adding a separate object with 'constants' is pretty standard for something like this.

var Suit = {
HEARTS: "hearts",
CLUBS: "clubs",
etc..
}

Doing this makes it clear that you are using constants and helps promote reusability and reduces bugs


Looks good. An example `info.rkt` might be useful, or a link to POP-PL / another project you guys own & keep covered.


**Code Quality - Nitpick**

 - You should remove redundant new lines from your code base, also found in lines _67_, _10_ and _37_
 - You should adopt our code style for condition statements i.e.
```
if (……) {
……
} else {
……
}
```


> ... the github by itself will show you all the changes made on file based

Can you paste the github link that shows the diff between the original and your changes?

> all_ids holds a collection of resource IDs ... it will not store any new ID on same scope. Then no, it does not serve the purpose of having a collection of resource IDs. ...

So it should be fixed, no?

> althoug, declaring it outside of the scope, it could provide support for storing a collection of resources if you need to list registered resources on any part of your application.

Can you think of a way to to provide the intended functionality of `_all_ids`, but without exposing it to the global namespace?

>> What does `.close()` do? What should it do?

> It also sets a flag that is not being used on any part of your code.

Is that flag used anywhere? Should it be?

> ... You just mentioned "what is wrong with the code?" ...

From <https://gist.github.com/posita/f17a3aadea82aa6bfc06> (***emphasis*** added):

> ... figure out what's wrong with [`id.js`]. [¶] ... Send a link to your repository that has ***well-commented fix*** ...

One's response to the exercise largely depends on one's interpretation of what comprises a sufficient "fix" (hint, hint). :wink:

> Yes, the pattern used on this code is easily testable .. but I didnt write any test .. I can do it using javascript or even perl + phantom on server side

What are some benefits to submitting tests along with bug fixes, especially to someone else's code? You mentioned `phantom` as an alternative. Is there anything about this code that *requires* browser functionality?

> still yet about the close method ... the problem is, the delete keyword shall to be used with associative arrays ...

This is probably deserving of a fix as well, isn't it?

> ... in this case, the array _all_ids is not necessary, then you can simply return _expensive_resource = { value: "I'm a very expensive resource associated with ID " + id };

Are you sure? What if `_lookupOrCreateExpensiveResourceById` takes several seconds to create/allocate the expensive resource? Consider the following:

```js
var rsrc1 = resource(42);
var rsrc2 = resource(42);
```


Great work!


Missing else statement


this should work, the regex as-is matches everything i want it to match, so not sure where the problem is


Does the review group need to have reviewers to exist?  wondering about the "one, two, three".


Group items that naturally go together into objects (or better yet, classes).

var player = {
hand: [], //array of Card objects
chipstack: 1000,
bet: ""
}


**Code Quality - Critical**

Your indentation is offset here and breaks its consistency in your code base.


An error occurred while running the tests. Please check the [status](http://ccextractor.canihavesome.coffee/test/102) page, and correct the error. If you have a question, please contact @canihavesomecoffee.


var shuffle = deck; //on line 22
deck = shuffle
What are you trying to do?


version should be 1.0.3


Should this be `major`?


always use === in JS, you want to be comparing without type coercion


Yup, but not any more - squished in 1bae868.


For functions, the difference is probably smaller - non-static members have a (hidden) `this` parameter, but are otherwise equal to static methods or functions (the latter two should be completely equal). But since functions also constitute the API to this code, I wouldn't want to optimize this at the cost of a less clear API.


@ccx-testerbot runtests isdb


yep!


This is a little kinda confusing. Given that we're documenting AWS, maybe we can be explicit about route53 config (and if user wants a diff registrar, it's still pretty clear what needs to be done).

Also, replace "external DNS name" with `externalDNSName` to explicitly match the var in the cluster.yaml.


examples/Arduino Zero + WiFi101/quickstart/QuickStart.ino

what is the current firmware?


It will return all unacknowledged documents.  I believe the only technical limit would be based upon the maximum message size specified in your WCF endpoint.  Our guidelines expected the client to make a call to GetDocuments() at least once every 3 days.

From: davidbsanderson [mailto:notifications@github.com]
Sent: Wednesday, September 30, 2015 11:58 AM
To: azavar/SST-API
Cc: Steve Snively
Subject: Re: [SST-API] Added API function definitions (a15cdd5)

When using GetDocuments('U',null,null), will it return all unacknowledged documents, or is there a limit to the number of documents retrieved in each call? I'm trying to determine if multiple GetDocuments() calls may be needed per day.

Thanks.

—
Reply to this email directly or view it on GitHub<https://github.com/azavar/SST-API/commit/a15cdd5b102be686b4fc5d51d657857bb272d922#commitcomment-13523066>.


@rpless an example repo is probably a good idea.


BUG: Parabolic Jump has not been implemented...


By the way, if you use hangouts, add me:xboxlover360@gmail.com
On Sep 30, 2015 1:11 PM, wrote:

> Still getting a couple compile errors, since I haven't used a tree like
> this in awhile, but it'll get there.
> On Sep 30, 2015 1:10 PM, "Jake Weinstein" <xboxlover360@gmail.com> wrote:
>
>> Not fully working just yet, but it's close
>> On Sep 30, 2015 1:01 PM, "Anthony" <notifications@github.com> wrote:
>>
>>> Thank you!. I have been looking for something like this hopefully it
>>> will help all the struggles I have atm.
>>>
>>> Thanks again for sharing.
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/xboxfanj/device_oneplus_bacon/commit/89fa4a098480efa8c803bab130a3bdfbb02bd76b#commitcomment-13524468>
>>> .
>>>
>>


You could create a shuffleDeck method that would randomize the order of cards in the deck and that way every time you need a card you just pop one off the array (so you are essentially using the array as a stack).  That would remove it from the deck and allow you to put it in a player's hand.


import com.l2jserver.gameserver.network.serverpackets.*;

Importing all classes? Desnecessary no?


Popraw formatowanie, żeby było:
} if (...
a nie:
}
if (
:)


Thanks for pointing this out. This is fixed in the dev branch ^^


To PRE.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.517.eef8be776327858821d73a379c9c2877456dd039](http://build.palaso.org/viewLog.html?buildId=63926&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:05:48


Thank you for the request. It has been added to the queue (id: 103). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/103) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


yep, this will prevent the creation of empty review teams. I'm thinking there isn't a use case that makes sense for an empty list.


I don't really understand what's going on here. Can you elaborate in this comment a bit more on what the bad scenario is that you are (crudely) preventing?


It is generally a good idea to separate data creation and user input.  Have a method for generating an initial hand that you can use for the player or a computer.  Then once the objects are created have a different method for handling the user input.  When you combine data creation and user input you make it hard to fix one if something isn't working.


Noe not allowed. The string can be "null" and it could be the users input.


That sounds right, but make sure it uses the phrasing I suggested, I want people to be able to find the info even if the link breaks.


please, add folder Operations to your project.
transfer all operation classes into this. Dont forget to ajust namespaces


Think about how similar this method and dealerHand are and try and pull out common code into a single, reusable method.


Would it be worth throwing a comment in here?


s/handful of names/internal Kubernetes service name/


No cambió con el tercer commit? En principio sí lo tengo con un linear y un relative más
PD. A ver si me preparo un cuestionario para que me digas mañana como empezar a programar las cosas...

El 30/09/2015, a las 15:48, Felipe Corral escribió:

No le metas margins ahi, tienes q hacerlo con layout_weight

—
Reply to this email directly or view it on GitHub<https://github.com/gonzaloiv/learning_android/commit/de1449f2e55d0ecec2152a98cf4401aca33b0a2f#commitcomment-13518053>.


must be === null


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.496.eef8be776327858821d73a379c9c2877456dd039](http://build.palaso.org/viewLog.html?buildId=63927&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:08:29


Will you add the brand new deps on ``soletta-git/PKGBUILD.spec``?


@eugenesan Can you please explain the rows from 94 to 102?


return new HelpOperation()  --> Execute() method shows all available operations


@jasnow Definitely. We haven't changed this in Rails yet, though.


The rest seems fine.


Why have you removed `apply()` from `GettableDeclaration`?


Антон, активность зафиксирована, предложение не такое уж "необходимое" :)

Павел, хорошая работа!


Yes. Intelij formatting...


Good catch!


Code Smell: Duplicated code: identical  code exists in more than one location. Bananas instead of coins, great idea!!!


Now I'm curious


An error occurred while running the tests. Please check the [status](http://ccextractor.canihavesome.coffee/test/103) page, and correct the error. If you have a question, please contact @canihavesomecoffee.


===

Similar to my recommendation for Suits you could have an Actions object with stay, hit, double.  This is a good example of why having the constants is good; instead of doing a string comparison where it might be "stay" or "Stay" or "STAY" if you compare action === Action.STAY then you won't have to worry about how you capitalize something.

Also, you want to do some sort of sanitizing of the user's input. toLowerCase, maybe a trim to get rid of white space, etc.


@jirikuncar indeed what was the final purpose of this line? to be able to convert to JSON? Because otherwise an intbiset could be serialized to a string. Finally it all depend on the code that is going to reload this. (Referring to inveniosoftware/invenio-ext#16.


Mola lo de los comentarios estos por cierto!


good.

well, talk about "welcome to programming". I just got excited that I was able to reproduce the error locally.


fixed


600 should it be hard coded ?


indentation is messed up


I am talking about a single small jump when starting playback ....


Operation can be (and should be) any user command (and non-math too).
Please, add ClsOperation which doesn accept any arguments and which Execute() method does just Console.Clear()

But! Incapsulation of PrepareOperands() is a very good decision.
You can inherite another abstract class MathBinaryOperation : Operation which will contain  PrepareOperands() method (which I'd rename into ParseNumericOperands)


No problem. Thanks for sending the pull request.

On Wed, Sep 30, 2015 at 9:44 PM Alex DeJarnatt <notifications@github.com>
wrote:

> Oops! Thanks for removing that :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/erans/pysnowflakeclient/commit/19fb827237509ee478e3e08f1bfc322bcea0b743#commitcomment-13525599>
> .
>


I asked more info on some rows, since I'm not sure about the behavior of the commands, but is a big improvement, with sufficiently fast and large swap memory (or more RAM obviously).


Better !== null


@jtabach I don't know if you have notifications set up, but enjoy the comments


>>  ... the github by itself will show you all the changes made on file based

>>> Can you paste the github link that shows the diff between the original and your changes?

In this case I can't, because I didnt make a commit exactly when I cloned your original file and started to change it

>> all_ids holds a collection of resource IDs ... it will not store any new ID on same scope. Then no, it does not serve the purpose of having a collection of resource IDs. ...

>>> So it should be fixed, no?

Yes, I was very wrong about it use. It does not store 'resource ids'... I provided more explanation o the prior explanation

>> althoug, declaring it outside of the scope, it could provide support for storing a collection of resources if you need to list registered resources on any part of your application.

Same mistake here It does not store 'resource ids'.

>>> Can you think of a way to to provide the intended functionality of _all_ids, but without exposing it to the global namespace?

No. no functionality

>>> What does .close() do? What should it do?

>> It also sets a flag that is not being used on any part of your code.

>>> Is that flag used anywhere? Should it be?

Should not, even why it is public. Certainly you may use it as public property

>> Yes, the pattern used on this code is easily testable .. but I didnt write any test .. I can do it using javascript or even perl + phantom on server side

>>> What are some benefits to submitting tests along with bug fixes, especially to someone else's code? You mentioned phantom as an alternative. Is there anything about this code that requires browser functionality?

>> still yet about the close method ... the problem is, the delete keyword shall to be used with associative arrays ...
>>> This is probably deserving of a fix as well, isn't it?

necessarily, this line should be deleted .. in my point of view, _all_ids is completely unnecessary on this code


It was a joke. Did you log out the very first PTS you get? Too different from inited value?


I'm not sure about this, maybe @iamvery has some insight into what keys could possibly be in this redis instance?


I did not quite understand for creating a new method for this ?


cloud-provider isn't replacing flannel?


removed - this is atavism of original development


Never use protected or public fields. It breaks incapsulation principle.
You can do such a thing:

private double _field;
protected double Field
{
    get { return _field; }
}


Change error message so that it tells that "cpu" is accepted for "device".


Unfortunately, we cannot, as it either triggers a `ClassCastException` at Runtime (wrong classloader) or the wrong `StaticLoggerBinder` is pulled (the logback one, from the WebAppClassLoader) which later triggers a `NoSuchMethodException`. Tricky... :-)


Ouch rewrite


It is common practice to use shorthands to c# primitive types:
float for Single
double for Double
string for String
int for Int32
...


Fixed, thanks.


The printing here is strange.


Rename?


date should be `Wed 30 Sep 2015` and permalink `2015-09-30` and the filename should also be changed accordingly


@sklum Added this so that color images can be propagated through dlib.


after you add HelpOperation there will be no null return


Code Smell: Very High Cyclomatic complexity. Too many if else statements.


And an empty string is also accepted for `init_gpu_device`.


I'm actually not sure if API version should be bumped here or in the other struct -- 1.0 has not been released yet.


I don't think we ever use "bug" in the UI because Bugzilla lets you customize the label IIRC. Not sure if we can query the values set in Bugzilla's `template/en/default/global/variables.none.tmpl` though. Maybe change the text to `Nothing to display.`, `No results.`, or something else generic?


thanks for putting all this in one commit :+1:


@ccx-testerbot runtests master


iirc, you can have the `<script ..>` just once in the file (doesn't need to be added for each embedded tweet), so this line can be removed.


Hm, is this a good idea with respect to the goal of reducing closure sizes? I mean, how many users need to render Chinese characters in the default configuration?


You should also check the css at line ```https://github.com/cuneytsenturk/arastta/blob/editors/admin/view/template/common/header.tpl#L21``` and load only if required.


Dobott project


Why removing that check here? Did you move it elsewhere?
We do not want to allow a user to specify "device=gpu0,init_gpu_device=gpu1", or worse, "device=gpu,init_gpu_device=cuda1".


This block, and the block under self.errors are very similar and just begging to be converted into a function.  This will especially help should we need to add additional quit behavior.


Thank you for the request. It has been added to the queue (id: 104). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/104) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


Very important:
in some cases (very often indeed) you may not know whether some operation will execute successfully or it will fail.
In case of DivisioOperation you can just check whether divider is not zero. But there are more compicated scenarios where you simply cant know if operation will fails and crush all the application.
Please, read about try/catch blocks and add one here.


> The splat always comes at the end. It doesn't make sense for a named parameter to go after a splat. (I don't even think you can interchange splats and named parameters without some nasty bugs).

Here is the [router test with 3 splats](
https://github.com/jashkenas/backbone/blob/master/test/router.js#L288):
```javascript
// route "*first/complex-*part/*rest"
location.replace('http://example.com#one/two/three/complex-part/four/five/six/seven');
Backbone.history.checkUrl();
equal(router.first, 'one/two/three');
equal(router.part, 'part');
equal(router.rest, 'four/five/six/seven');
```
* Looks like multiple splats are allowed
* Based on the current test, would `*first/complex-:part/*rest` also be a valid route,where second param is a named param?

If all splat params should be at the end, I could definitely `.match(namedParam)`, then merge the result with `.match(splatParam)`. Which I think is probably slower than single regexp for both.

> But then I'd need to do paramNamesRegExp.exec multiple times on each route till no matches left
> > Are you sure about that?

I must have misunderstood your question. I thought you meant to extract the param names directly by capturing the name, avoiding string slicing to get rid of * and :


ToString() is not neccessary here


Not necessary for most types, although for strings that's required as their values are allocated and must be freed.


yep, I also need to take a look at anselmo's last patch and see how we go with that...


@corentindms, readByKey should always return an item and not a list.
readByKey on TestCaseCountry should tak as input test, testcase and country and return an AnswerItem.
This function should be called readByVarious1


Adding bellow line 743: npc.setIsImmobilized(true);


return too
just skip it


and here...


		else if (npcId == TIAT)
		{
			world.tiat = (L2MonsterInstance) npc;
			npc.setIsImmobilized(true);
			for (int i = 0; i < TIAT_GUARD_NUMBER; i++)
			{
				addMinion(world.tiat, TIAT_GUARD);
			}
		}


I've changed lines 56 and 62 to a RegularDeuce status finishes in 'W'


Related to #109


> What's the benefit of that? This structure already exists and it makes it easier to see what is going on if we look at items on the AWS dashboard.

To reverse the argument, what's the benefit of using attributes?

I'm not convinced they are necessary, since the only advantage to using them is that data is displayed as a table in the AWS console (I question how useful this is). Something else to consider is that "By default, no arbitrary message attributes are returned when requesting messages" ([source](http://boto.readthedocs.org/en/latest/sqs_tut.html#reading-message-attributes)).

Not sure what the best practices surrounding SQS are, but I'm in favor of just using plain old JSON objects in the message body, since that seems like the simplest solution.


>> Are you sure? What if _lookupOrCreateExpensiveResourceById takes several seconds to create/allocate the expensive resource? Consider the following:

    var rsrc1 = resource(42);
    var rsrc2 = resource(42);

the 'answer' for getExpensiveResource will be equal in both cases:

I'm a very expensive resource associated with ID 42.

For the end user, it may be confuse.

But in terms of code, both rsrc1 and rsrc2 are very different instances of NAMESPACE.resource

it means, it would not face any conflict inside object scope.


It's 14M, could we compress it to `.woff` or something similar?


Not necessarily 2. May be 0, may be 27.
Let in be List<string> with dynamic length.


Some versions of pep8 seem to dislike this.


In the generic bootstrap scripts we moved this into /etc to survive reboots. I think if this is user-data, leaving it in /run should be fine, but this is the referenced change: https://github.com/coreos/coreos-kubernetes/pull/48

Also, this can be more easily overridden soon (depending on release): https://github.com/coreos/coreos-overlay/pull/1544


arguments


an infinite loop


This is good so far


Shouldn't this line be sameersbn/gitlab:8.0.3 in stead of -ci?


> So the EMR job will write directly to the queue, yes?

Yes. Actually, one of the arguments we hand off to the EMR job should include the name of the queue to post messages to.


Please, Add operation that summs dynamic array of numbers:
summlist 1 2 4 -4.3 4 7 -9


An error occurred while running the tests. Please check the [status](http://ccextractor.canihavesome.coffee/test/104) page, and correct the error. If you have a question, please contact @canihavesomecoffee.


better leave it in...


ok


There's a "better" way to do this (in so far as it's more consistent with what we're doing elsewhere)

https://github.com/ubc/ubc-use-template-shortcode/blob/master/templates/education/programs.php#L48


Is that correct? Should we really always use float32 here?


@ccx-testerbot runtests isdb


you can add ExitCommand()
it will be more consistent with present architecture


Hola Pablo.
Me parece que este commit nos va a traer problemas al querer hacer el merge. Ya que cuando lo quieras hacerlo nos va a decir que hay conflicos ya que se modifcaron en las dos ramas.
https://github.com/ciaa/Firmware/compare/master...feature/multicore
Si haces un merge del master te traerias esos cambios, pero antes tendrías que deshacer este commit :)


> Prototype: the difference between new MyRouter({enableRouteData: true}) and var MyRouter = Backbone.Router.extend({enableRouteData: true}). You're likely going to want this on a class level, not an instance level (otherwise your handler methods will get confused about what arguments they should take).

Thanks for clarification! It definitely makes more sense to have it a class level, instead of each router instance having it's own way of callback handling.

> Let's experiment with removing the array parameters. I think parsing to an object is much nicer.

Do you mean to not have the option at all, and always pass `routeData` object to handlers? And we won't need to worry about backward compatibility?

> You raise a good point about regular expressions though. Currently they're not an issue since we just treat all matches as an array of arguments. We could just give you an array of matches on the params object if they're not named.

Sure, I don't think there's any other way since the regexp route won't have any param names to it.


In my fork I just shipped the entire `stubs/` directory instead of enumerating versions. Since @JukkaL is MIA and not merging critical fixes, perhaps we should collaborate to maintain a fork of mypy.


Where's the closing `</div>` tag?

The idea for this plugin is to try and encapsulate all functionality from within the post editor into a template, that way it's simple to look at in the editor


Why is it needed?
If you are going to assign `vt`, you may as well reuse it on the following lines.


Damn -1 keeps re-appearing! Somehow I think the fetch isn't working when I get updates merged


We should use `Buffer.RESIZE_MULTIPLE` here.


I would just remove it.


Can you please make separate pull requests for each of these templates? I could have accepted the iso-custom-modal-launch-btn.php template and put that onto verf, but as it's all one, I can't as I have questions/comments about the other two.


May I ask how you knew s8000 mapped to Samsung, and s8003 mapped to TSMC please?


en estos casos se debe usar un cherry-pick, si el codigo es 100% igual puede que no se enoje el git :) sino como dice gus no se puede mergear.


Please check this commit:

https://github.com/web2solutions/Veritaseum-proof-of-concept/commit/860e456118b910b6fde33d56ab928ef8031bc81f

I removed the dependence of _all_ids array, turned on the  strict pragma and properly declared NAMESPACE variable as global considering an browser environment


Thank you for the request. It has been added to the queue (id: 105). To see the progress you can go to the [status](http://ccextractor.canihavesome.coffee/test/105) page. Please note that depending on the current queue, it could take a while before any results will be visible. In each case I will report back here once the tests are done.


why do you need to reset the variable data ? More out of curiosity.


structural nit: rather than requiring all commands to be in main, might be cleaner to have main add various commands to cmdRoot, and main just imports the command package. e.g. rather than a child adding itself to parent, parent adds children (all in one place).


We have learned a better way to achieve this: Array.map


So this isn't obvious, but if you're redirecting, then the return type is actually: `\Illuminate\Http\RedirectResponse`


Missing a return type.


For params we use:

- `int`
- `string`
- `array`
- `bool`
- `mixed`
- `null`

If a method returns multiple values, depending on a condition then you can use `int|bool` for example.


I think you're looking at an outdated diff @mcwhittemore. Take a look at the final diff [here](https://github.com/mapbox/mapbox-gl-js/pull/1526/files)


Status isn't actually a model in this case, it's an `int`.


Remember than `if` and `else` have braces on the same line.


Let's set this to `1f / 3f` for clarity, and then let Java decide the number of decimals


Remember about including the namespace, like `\KieranSmith\Facebook\Models\User`


Should probably also test the new cases added by this commit, when a global admin can't :change_role for a space admin and when a space admin can :change_role for another admin.


Since `$person` is a model, we'd be better off with `$person->fullname`.


did you find out where it overflowed?
If running without Graal unfortunately Fixnum#+ never splits so it is very likely to happen :(


Hmmm, it would be nice to support all languages out of the box. Maybe smaller, more compact font? Probably needs more discussion, I agree 14M is a lot compared to the whole closure.


I lost the images. :cry:


Let's add an overload that takes a `@FractionRes` int as well


@jeremy - note the change from  `Mime::Type[:JSON]` to   `Mime::[json]` in message.


There is can be some problems with DsBattery.Full state. When battery is charging with USB cable - battery has status DsBattery.Charging. When battery is fully charged, but stays connected with USB interface - battery status will be DsBattery.Charged. And if you connect Pad with BTH and battery will be fully charged - only than battery state will be DsBattery.Full. Thats why DsBattery.Full is implemented only in BthDs3.cs. So I think there should be

    case DsBattery.Charged:


@andreyvit This was crashing our newsfetch cronjob.


Is tmpfs a vfs? Because I keep getting this error every other restart, "ERROR: ScanOnAccess: Could not watch path '/tmp', Success".


change this line,please.


I just split it and left things the way they were before. If there's anything that can be done better, feel free to change it. I won't be able to code till Saturday night.


"package facade" is deprecated term


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.485.57b5203f9edbe6463438e82381868fd9fb698ca7](http://build.palaso.org/viewLog.html?buildId=63939&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:18:34


No need to declare the result?


i'd say package or package members or package declarations


Since we have two `me` routes, it may be worth grouping these together.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 738](https://teamcity.labkey.org/viewLog.html?buildId=275191&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **SUCCESS**
Summary: Tests passed: 9, muted: 34 Build time: 00:25:56


Very well done, I really like how you made up the car one.


@smcmahon remember to enable package on travis


can't stop won't stop


ok


@Brit200313 OK doke.

```
Updating b440027..7bde0f5
error: The following untracked working tree files would be overwritten by merge:
	public/assets/application-902dd86852118fcde207d2d3a9f61355b4c50b8d61e86f09cee92a2cfccdb1a6.js
	public/assets/bootstrap/glyphicons-halflings-regular-13634da87d9e23f8c3ed9108ce1724d183a39ad072e73e1b3d8cbf646d2d0407.eot
	public/assets/bootstrap/glyphicons-halflings-regular-42f60659d265c1a3c30f9fa42abcbb56bd4a53af4d83d316d6dd7a36903c43e5.svg
	public/assets/bootstrap/glyphicons-halflings-regular-a26394f7ede100ca118eff2eda08596275a9839b959c226e15439557a5a80742.woff
	public/assets/bootstrap/glyphicons-halflings-regular-e395044093757d82afcb138957d06a1ea9361bdcf0b442d06a18a8051af57456.ttf
	public/assets/bootstrap/glyphicons-halflings-regular-fe185d11a49676890d47bb783312a0cda5a44c4039214094e7957b4c040ef11c.woff2
	public/assets/the_us_thread_logo-a98b0c9ef0c8fbc7831daeedddcd04bfb4fbce80b05bcd8c40ee457c4ed86857.png
Please move or remove them before you can merge.
Aborting
```

I saw that there were problems with assets. I looked here: https://www.digitalocean.com/community/questions/rails-app-deployment-we-re-sorry-but-something-went-wrong and noticed these settings suggestions:
`application.rb /config.assets.initialize_on_precompile = false`

`production.rb/config.assets.compile = true`

The first one is missing, BUT I did add the following when I created my validator:
`config.autoload_paths += %W['#{config.root}/app/validators/']`
Which I thought simply ADDED that path to autoload

The second one is set to false.

Any thoughts?


Well, this was based on the fact that you bumped SOL_OIC_RESOURCE_API_VERSION and SOL_OIC_RESOURCE_API_VERSION, so I thought you might have missed this one.


i'd fixup it to commit where the case fixed


And why not having a module by API version (in order to have the appropriate testng dependency and have compile time check), load the appropriate facade by reflexion depending on the version and produce an all in one jar with all facade? A bit like what surefire is doing.


Good catch. I'll make sure `register_resource()` won't accept repeated contexts/resources.


I'll rename it.


@florence yeeeeeaaaaahhhhh, just as soon as I have some free time.


Again my fetch is not properly updating my local repository


This is a no-op


syncing


"Lower is smoother" is a bit unclear.


I'll do it.


see issue #346


Test new AI! https://gist.github.com/maneco2/a7e1f311cdace26bff0d


Since this is constant for the whole tileset, could we pull this condition out of the loop?

The gen1 games do a /lot/ of paying for gen2 features :(


I wouldn't be very confident in the correctness of the comment, I don't fully understand the UUID types but found that this matches what the BLE GUI was querying for


Ew, but ok.


Some PEP8 stuff here (spaces around the *)


I think that's worth a comment.  It'd be good to at least document where they're from and the uncertainty.


Can't you handle it the same way you handle default: ?


Testing GitHub-Slack integration


Thanks!


:+1: Good stuff here Ryan


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.63.57b5203f9edbe6463438e82381868fd9fb698ca7](http://build.palaso.org/viewLog.html?buildId=63932&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:37:02