Maybe seekbar cannot be used on such? I am now gonna try listpreference instead.


I getting the font from the asset every time this function was called. Apparently this is a very slow operation. It made the app lag every time it was opened.
Moved it to loadLangugeFromSettings (I guess this is the most relevant place it could be moved to) and now the lagging is gone.


Note that this is necessary for any query with selections, and also if we start pushing everything before the first shuffle into Postgres by default per @mbalazin's suggestion (e.g., all joins on identically partitioned existing relations would miss this optimization). Agree it's OK to defer on the first pass, though.


LGTM mod comments above.


yo no rompo cosas :c #elchicoblancolastimamissentimientos


/**
 * The function `reverse` computes the reversal
 * of a given `String` (don't copy-pasta!)
 *
 * @param {String} S to reverse
 * @return {String}
 */
function reverse(S){
    // YOUR CODE HERE: NO INTERNET COPY-PASTA!
}

console.assert(reverse("") === ""); // Really?

console.assert(reverse("A") === "A"); // Jerk.

console.assert(reverse("cat") === "tac");

console.assert(reverse("ward") === "draw");

console.assert(reverse("books") === "skoob"); // Rokey, dokey...

console.assert(
  reverse("we don't want no trouble") === "elbuort on tnaw t'nod ew"
);

/**
 * Function `encode` accepts a `String` and produces
 * the appropriate ROT13 "encoded" version, i.e. every
 * character in `phrase` is "rotated" ahead by 13 characters.
 *
 * @see String.prototype.charCodeAt
 * @see String.prototype.fromCharCode
 * @see http://en.wikipedia.org/wiki/ROT13
 *
 * // Start with just `phrase`...
 * @param {String} phrase to encode
 * // Add `N` in part 2!
 * // @param {Number} N rotation to apply, default 13
 * @return {String} encoded with ROT13
 */
function encode(phrase/*, N */){
    // YOUR CODE HERE... EMPHASIS ON **YOUR**
}

/**
 * Function `decode` accepts a `phrase` and `N` and
 * decoded it appropriately, i.e. every _word_ character
 * in `phrase` is rotated backward by `N` characters.
 *
 * @param {String} phrase to decode
 * @param {Number} N rotation to apply, default 13
 * @return {String} decoded by ROT-N
 */
function decode(phrase, N){
    // YOUR CODE HERE
}

// Produce more examples, please...
console.assert(encode("hello") === "uryyb");
console.assert(encode("uryyb") === "hello");

console.assert(encode("hello", 2) === "jgnnq")
console.assert(decode("jgnnq", 2) === "hello")


Since a new option was added to the app letting the user change the app language and some languages are RTL like Persian and Pashto, this changed  the app layout automatically when you chose that language.

The layout change affected the about page too which is not good because the about page is all in English. It's got the licence and stuff which is practically not good to be translated to other languages. So it should be kept LTR.

This  change fixes that problem.


- 400 is magic number. Plz see https://en.wikipedia.org/wiki/Magic_number_(programming).
- Response code is written as String type, not number. Because response code is code, not number.
- It's better to write response code in other shared file. You can use it other class and method and if the code will be changed, it's easy to update. Plz ask Nguyen Tuan. I gave him same advice.


I think I just found the issue man


Hello txt


Can you explain what this scope is doing?
`ordered_by_reverse_created_at` should sort the `created_at` date in reverse (descending) order


Octree (DeadParrot) - x86_64-MacOS-10.9-clang: OK (1819 of 1824 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.73%25-yellow.svg)


No need for this commented line


102817062_MultiSpeedFan (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1826 of 1830 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg)


Change your preference from PREF_FONT_SIZE to PREF_CLOCK_FONT_SIZE, the first is already being used by settings captioning


whats that?


oh


:+1: for making it a util!


No you need to put in the arguments. Are you running it locally? And are
you definitely running my code?

On Monday, September 7, 2015, Jacob Ho <notifications@github.com> wrote:

> umm, i don't see any input prompt when i run by the command above. Should
> i just type in dropbox for the client?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cs4278-2015/assignment2-handin/commit/6b7851264160980d527183978d3b29ce8c875797#commitcomment-13103224>
> .
>


Paulinho, quando passarmos para o projeto principal o ideal é que não coloquemos estlos dentro das tag´s. Todo estilo deve ficar dentro do arquivo CSS :D


Yea LOL, like I said just pure bad luck because this is settings the preference for that with a seekbar it doesn't support. This is just a guess but nothing else is wrong anywhere so guessing/hoping that's it until I can look further


It was thus said that the Great Philipp Janda once stated:
> Yes, 1.2.4-2 installs cleanly on my Ubuntu box now. (The _VERSION string still says 1.2.0, though!)

  Arg!  I don't have a good way of updating the version string from git (I
have a way of doing it for a program, but not for a library).  Anyway, new
version uploaded with a proper version string.  Thanks again.

  -spc


`let` would be nicer here, no?


Yep, was just a copy pasta from the old location. Will fix, but tons of places from pre-ES2015 code still need to be ported.


Depois da uma olhada na propriedade "padding" do css. Vai te ajudar a resolver esse espaçamento que voce fez com o "<br>". Qualquer coisa da um toque.


I'll try now,


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-44.12%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-0.0%25-red.svg)


yeah. I made a mistake in the running command so it didn't work. I figured it out so no need to worry. It does show add delete commands.


Is this a 64 bit or 32 bit machine?


It should work, since on oppo find7 it's.
But I can't test now, until cm solves f2fs compile problem. (I use f2fs, so, I can't disable it)


I like de-referencing, however there would be no need to ever override `Element`, so
```javascript
const Element = window.Element;
```

might be the better choice.


`let` :)


Use HEAD here. LuaRocks 2.2.2 does not have the cmake fixes for x64 bits you need.


Hi Manish,

I will joining late by 15 min.

On Mon, Sep 7, 2015 at 8:00 AM, Phani Kumar <phaniwithu@gmail.com> wrote:

> hi, i will be joining in 10 min
>
> On Sun, Sep 6, 2015 at 10:23 PM, Phani Kumar <phaniwithu@gmail.com> wrote:
>
>> Hi,
>>
>> I made a commit to add phones for emp, please check at below
>>
>> https://github.com/phaniwithu/Manish-Angular/commit/f018c6584999839e36a65867b1ea714136f9f352
>>
>> we can discuss more tomorrow
>>
>> thanks
>> Phani
>>
>> On Sun, Sep 6, 2015 at 6:57 PM, manishagarwal7 <notifications@github.com>
>> wrote:
>>
>>> phoneArr is getting pushed with count. Not actual numbers.
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/phaniwithu/Manish-Angular/commit/4c051c451429eab0b0c9c71c11317ecb059788f5#commitcomment-13086252>
>>> .
>>>
>>
>>
>


That's just going to give the same console errors, I am probably going to make it listen for these things instead.


CM has a f2fs compile issue? Hit me up on G+ man


三年来一直使用它，感谢作者，祝好


Uma dica:Pra evitar conflitos com caminho de pastas, tu pode partir do local atual. Para voltar uma pasta, basta usar dois pontos (../)

Por exemplo, se a imagem estivesse fora da pasta "teste" era so fazer "../cidade.jpg". No caso, apenas o nome da imagem deve funcionar..


결국 이미지 하나당 캔버스 하나 새로 만들긴 했다.
* compress를 누르고 나서야 이미지 리스트를 돌아가면서 캔버스에 그려야하니까 느릴 것 같았다.
* 원본 사이즈를 보존하기 위해서 숨은 캔버스가 이미지를 가지고 있어야 하는 거 아닌가도 생각했는데, 그건 Image객체도 잘 가지고 있으니까 상관 없음.


hello world!


That's a good point. I'll do that.


Thank you for instruction.
Then do I need to make commit messages for each changes in the sublime?


test


We might just need to change this to use 2D textures which are 1px wide - this is legal so there probably won't be an issue.


preview


Nope. Same issues


Noted.


Beginning repo for Coursera Data Science coursework


If we're important pytest, do we need to pull these functions in? The naming convention for new assert functions is assertSomeProcess. So a new TestCase base class with self.assertTestHolding(...) for example is what I'd expect to see instead of test_* methods which is the naming convention for the actual tests themselves.


Merge conflict I see ;)


バージョン番号書き間違えた^^;
version:"1.10.4" --> version:"1.10.5"

add ccchart.deep property deep: yes | no (default)yes http://ccchart.org/test/deep/test.htm  http://ngw.jp/~tato/wp/?page_id=3619


Paulinho, como vamos passar no validador do W3C é melhor já irmos sempre fazendo os testes durante o desenvolvimento e corrigindo pra evitar retrabalho. No caso da tag "b" o ideal é que use um titulo hierárquico, no caso poderia ser um "h3" e depois formatar o tamanho no CSS.


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-60.19%25-red.svg)


Hi! Now the github rack version is `2.0.0.alpha`, but gem is `1.6.4`. How can I use it with `rails 5.0.0.alpha`? Because it will be broken when `bundle update`.


Paulinho, não precisa fazer essas alterações no arquivo de teste. Deixei os comentarios aqui apenas pra não esquecer quando aplicarmos no projeto principal. :+1:


You'll want to move this inside the `if` below, or you'll be sad.


Don't like this, maybe this should just call a different function.


well damn, ok when I get home I will pull a real log through adb and then take a look. Makes no sense with carrier and weather working fine, that's what doesn't make sense to me at the moment


Had to move this up because the gamepad support code can yield indefinitely if the new controller menu isn't being used


```
git clone git@github.com:rails/rails.git
cd rails
railties/exe/rails new --edge ~/path-of-my-application
```


Sure. I will be waiting :)

On Mon, Sep 7, 2015 at 9:23 PM, phaniwithu <notifications@github.com> wrote:

> Hi Manish,
>
> I will joining late by 15 min.
>
>
> On Mon, Sep 7, 2015 at 8:00 AM, Phani Kumar <phaniwithu@gmail.com> wrote:
>
> > hi, i will be joining in 10 min
> >
> > On Sun, Sep 6, 2015 at 10:23 PM, Phani Kumar <phaniwithu@gmail.com>
> wrote:
> >
> >> Hi,
> >>
> >> I made a commit to add phones for emp, please check at below
> >>
> >>
> https://github.com/phaniwithu/Manish-Angular/commit/f018c6584999839e36a65867b1ea714136f9f352
> >>
> >> we can discuss more tomorrow
> >>
> >> thanks
> >> Phani
> >>
> >> On Sun, Sep 6, 2015 at 6:57 PM, manishagarwal7 <
> notifications@github.com>
> >> wrote:
> >>
> >>> phoneArr is getting pushed with count. Not actual numbers.
> >>>
> >>> —
> >>> Reply to this email directly or view it on GitHub
> >>> <
> https://github.com/phaniwithu/Manish-Angular/commit/4c051c451429eab0b0c9c71c11317ecb059788f5#commitcomment-13086252
> >
> >>> .
> >>>
> >>
> >>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/phaniwithu/Manish-Angular/commit/4c051c451429eab0b0c9c71c11317ecb059788f5#commitcomment-13103353>
> .
>


@bklare :p


This is an image


import web

urls = (
    '/hello', 'Index'
)

app = web.application(urls, globals())

render = web.template.render('templates/')

class Index(object):
    def GET(self):
        return render.hello_form()

    def POST(self):
        form = web.input(name="Nobody", greet="Hello")
        greeting = "%s, %s" % (form.greet, form.name)
        return render.index(greeting = greeting)

if __name__ == "__main__":
    app.run()


Grayson, could you give me a test command for testing ignore files? I tried
dropbox --d1 dnode://test-data/folder1 --d2 file://test-data/folder2 --i //test-data/folder2/test2.txt
but seems like the argument is not read.


f f


@mythodeia
OK


When one changes display font size in Display settings, the clock font size is change too by default. Thus explains the connection.


its ok. as long as it doesn't add complexity to the code, its a good feature to add in LINQ. btw its not a good reason to remove this feature from LINQ4ES2015. its a handy feature to use with order methods and its so easy to use. I just think LINQ is incomplete wihtout it.


For what it's worth, I think the background event should fire all the time, and you can either pass in a Boolean stating if app is awake or not or just let the developer check themselves if the webview is initialized.

With that said, it should be consistent across all platforms too, and I don't recall how the iOS behaviour was implemented.

—
Sent from Mailbox

On Mon, Sep 7, 2015 at 7:20 AM, Tomasz Subik <notifications@github.com>
wrote:

> I've just committed quick workaround possibility for you. You can check `GeofencePlugin.webView != null` in your receiver. There should be better way to do it, though. Like try to find main activity and if there is no activity running it means app is closed, that's just my guess.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cowbell/cordova-plugin-geofence/commit/3ece9e289b8fe71a4f80cc453dbf07c7b6cb7454#commitcomment-13094848


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Dear, thanks for your warning. However, I will use this code in the future. I comment it to test my function without authentication. At this time, I didn't make authentication feature yet. In the next time, should I use a Todo comment for this situation.


Thanks for your suggest. I will try to refectory my code.


Indeed it would, just not sure why they are connected without being at my pc. My font size in settings fc at the moment so had no clue. Well at least that tells where to look


Pytest will treat any function called `test_*` at top-level as a test; there's no need to wrap it in a class (or use the `unittest` module at all) when you're using it. The convention with pytest is to just use the `assert` statement, as I have here.


Thanks, merged.


New file for assignmnent


マージOKです。


Looking at that command I'm not sure what could be the issue. I used a single '-' but the issue must be elsewhere in the processing of that input. I had it working but I cheated when I was debugging by adding inputs in the method where the file comparisons occurs. I might have messed something up in the reception of that argument.


I am a bit worried this update may break the theme for non Windows OS.


早起膜拜一发 =v=


Ok, @fdaciuk


Resolved.

The issue is SeekBarPreference

Change it to listpreference resolved both statusbar font size as well as display font size FC issues.

If you have a better idea to modify SeekbarPreference to be compatible then It will be better.


サーバ停止を下記のように実装などはできますでしょうか？

https://github.com/daikikohara/enotify-slack/blob/master/main.go#L103:L110


This should accept JSON as request and generate response as JSON. So I recommend to use Jackson for this. https://spring.io/blog/2014/12/02/latest-jackson-integration-improvements-in-spring


@daikikohara

よく見るので参考にさせていただいておりますm(_ _)m


@mikepetersonccv does the TIFF resize fail because it doesn't meet a minimum of 1024x768?


would be good use LogManager.getInstance().addErrorLog(this.getClass().getName(), "message", e);


Never use `extract()` \o/


@rafaelfranca Is this the only way? I had created a rails `5.0.0.alpha` project in this way one month ago. Now, I just want to `bundle update` it.


@fdaciuk Feito.

Não entendi isso aqui, não sei se era para corrigir.

///
>  /*
>  Utilizando a estrutura de repetição `while`, mostre no console todos os números
>  pares entre 10 e 20, inclusive esses 2.
>  */
> -console.log( 'Números pares entre 10 e 20:' );
-1
Os console.log que já estiverem no código, pode mantê-los. Quando for mostrar algo, use outros console.log. Isso vai facilitar a correção ;)

///


Octree (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1825 of 1830 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.73%25-yellow.svg)


👍🏾 for fixing sbt console. Although, at least `-Ywarn-unused-import` I consider a bug in SBT, I’m happy to have a workaround.

Also, could we potentially add more imports to `initialCommands` rather than disabling `-Yno-imports`? Not that you need to change it for this PR, but I’m curious if that would work, or if the problem is before we even get to `initialCommands`.


@sadayuki-matsuno

Godepとかの依存管理ライブラリ使ってないのとテストがないのが気になりました(><)


- fix typo
- remove `let(:infra)`. because `let(:infrastructure)` is already defined.
- remove `let(:dish)`. because dish is unnecessary.
- fix get method. syntax of get method is `get :ACTION_NAME, PARAMS: PARAMS_VALUE, ...`

`should_be_success` is passed by this fix.
But I didn't fix `should assign @serverspec_results`


Eu inverteria a lógica desse parágrafo.
Tendo em vista que o guia é para quem está iniciando em _frontend_, acredito que faça mais sentido explicar que:

Antes do CSS3, muitas coisas como sombras, gradientes precisavam ser feitas com imagens e fazer o recorte dessas imagens tomava tempo do desenvolvedor além de deixar os sites/aplicativos com mais arquivos o que resultava em mais _megabytes_ e requisições "desnecessárias". Isso resultava em mais recursos consumidos dos servidores e mais lentidão para os usuários. Da mesma forma, antes do CSS3 o trabalho de selecionar elementos que deveriam receber estilos muitas vezes tinha que ser feito com javascript já que os [ CSS3 Selectors](http://www.w3.org/TR/css3-selectors/#selectors) não existiam e isso acabava por tornar o carregamento das páginas mais lento e consumia recursos desnecessários da máquina do usuário.

Desde que os recursos do CSS3 se tornaram acessíveis, muita coisa melhorou na vida dos desenvolvedores _frontend_ já que com esses recursos renderizados de forma nativa pelos navegadores foi possível reduzir o número de _assets_ usados na interface e melhorar significativamente a performance e manutenção das aplicações.


so, this queues the download?


I'm trying another method.


Ah I see. I'm not used to these conventions and I'm not sure what to think about non-object based test methods. Does it work with `python setup.py test`?


github.com/raspilot/ardupilot pr-raspilot-support


Do we delete old repost images automatically?  I assume that all images (post/repost/etc) have a lifetime field and we delete them when they've expired?


10/10

Must fork this commit

:P


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1826 of 1831 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.73%25-yellow.svg)


No, it is not the only way but the easier. You can look the list of edge dependencies here https://github.com/rails/rails/blob/master/railties/lib/rails/generators/app_base.rb#L219-L224


IPとかは、

https://github.com/vrischmann/envconfig

などを利用して外出しするのがいいっすね。

面白いのがあったら共有ください！


@sellout I removed `-Yno-imports` because it does not even load the repl. so the `initialCommands` are not initiated.


Catch section should be used to display info about error so user can know about the problem.


セッションオープンは毎回実施しないとダメでしょうか。

コネクションプール的なものや、`getColData.go`をPG立ち上がり時のみに初期化するなどの実装は難しいでしょうか。


was there a reason to leave out: "Rails.application.config.assets.precompile += %w( optimizer.js )"?

I had to add it to view the home page.


Ok, I'll create a pull request and you can see if it works for you


Always a pleasure to help. :+1:


It is not good practice have commented  code


Thanks, I don't know what comment you're referring to but I understand now.


Should this be an error condition, like an assertion instead?


No special opinion.y(x) is more rigourous. y= seems more usual.
Excel put x=
https://www.ncsu.edu/labwrite/res/gt/gt-reg-home.html


Type can be omitted


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 555](https://teamcity.labkey.org/viewLog.html?buildId=270801&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:25:18
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

##### there are 20 more failed tests, see build details
```


TeamCity pull requests :: netty [Build 188](https://garage.netty.io/teamcity/viewLog.html?buildId=1225&buildTypeId=pulls_netty&guest=1) is now running


AddStuffToUI2 (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2305 of 2339 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.55%25-yellow.svg)


Private values after public members are confusing


@namreeb @cyberium @stfx

I'm sharing this for review, before actually pushing it. It was the best I could come up with. One of the goals was to avoid duplication of CMake related code for different CMake based projects. Or in other words: have the CMake projects use the same set of basic functionality (like compiler settings). Using CMAKE_SOURCE_DIR is troublesome in general because this directory depends on the project that gets build, and the contrib projects are in a different location than the servers (we could change that in theory, but sooner or later the problem would return anyway).

So the idea here is that each CMake project first includes, via a fixed and known relative path, a ```common.cmake``` file, which sets up a variable containing the repository's root. From that point on, we can use that variable to include other files, because everything has a fixed location relative to the repository's root.

One valid remark from stfx was that ```Common.cmake``` should be renamed to ```common.cmake```, so I'll change that before I push this. Please add any other remarks you have (or +1). And feel free to ask other CMake experts or devs to have a look too.


And AFAIK violate our code style


This goes back to when there was only one response class and I think I had to handle things a bit differently.  At this point it's more of a convenience wrapper, so it's fine to change it.


@mhugent @3nids unfortunately this is a big step backwards. Check out http://youtu.be/iiAKI0W8mgI for a demonstration of node deletion in 2.8 vs master. In 2.8 you could select a node, and then hit the delete key multiple times to progressively delete nodes in a sequential order. Now, you can only delete a single node, then you have to manually select the next node using the mouse, hit delete, select using mouse, etc... It's a big regression and will make editing quite painful.

I think a intermediate "selected but not moving" state needs to be added. So deleting a vertex makes the next vertex selected and ready for keyboard interaction (deletion or navigation using < > ), but NOT currently being moved. If you want to move the vertex you could then manually click on it to begin the move.


Thanks, I pushed a slightly different change.


Or
    uint32_t closeTime;
    auto replay = ledgerMaster_.releaseReplay();
    if (replay)
    {
        // If we're replaying a close, use the time the ledger
        // we're replaying closed
        closeTime = roundCloseTime(replay->closeFlags_ & sLCF_NoConsensusTime ?
            0 : replay->closeTime_, mCloseResolution);
    }
    else
    {
        closeTime = roundCloseTime(mOurPosition->getCloseTime(),
            mCloseResolution);
    }


TeamCity pull requests :: netty [Build 187](https://garage.netty.io/teamcity/viewLog.html?buildId=1224&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:29:39


TeamCity pull requests :: netty [Build 189](https://garage.netty.io/teamcity/viewLog.html?buildId=1226&buildTypeId=pulls_netty&guest=1) is now running


Wow!


Because of `synchronized` on `release`, `acquireLockFile` I would have guessed that  `FileBasedLock` can be used in multi-threaded environment. If so, `locked` should be `volatile`.


#5067-CoilCoolingWaterToAirHeatPumpVariableSpeedEquationFit-inside-AirLoopHVACUnitarySystem (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1838 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Thanks for the PR!
For naming consistency, I'll split this in 2 API methods:
- getCurrentViewedItem
- getCurrentViewedItemIdx


Hello,

I'm hoping I can get some more information about what results you are seeing with ComputeIdentityFilePath.  On our current build environment (win 7, VS 2013 update 4, x64 target) the tmpnam_s function creates a name that starts with a backslash.  As written, your update to this function will break the tests for us since, by itself, that's not a valid filename.  So you must be seeing different behavior when you run the function.  Can you decribe to me exactly what's in s_tempName after you run your version of the function?.  For example, I just ran the existing function and got ".\\s8cc.", ie tmpnam_s generated "\\s8cc."

What are you using as your initial cmake command line when setting up for VS2015?

We may need to end up conditionally compiling on the VS version if the runtime has changed behavior.

Thanks for your help!


With items there is different problem, they are clipped the same way the solid objects do (like walls). If you ignore that type of objects in tracing, you also ignore walls, and that would lead to invalid shields.

One solution would be to just ignore one object (that can be done), and hope that there wont be 2 items in way.

Another solution would be to not create shield at all, and return item to the owner. But owner would already hear the sound previously, that way it would be a bit strange.

Even another solution would be to just drop the shield as an item on the ground if something like that happens :)


So after this change, the -test-full=0 should not issue a PASS for formats which should or should not have the FMT_SPLIT bit, with no 'white-list?'


Yay John!!


This change [breaks `gcloud.python`](https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/79351464) now that `oauth2client` 1.5.0 is being used.

What guarantees that `webapp2` as a top-level import will be available?


Do we need to mention which module CalcAirFlowSimple belongs?


Fixed in d3270862855


выход?


I don't think HttpClient and related code should know about the existence of "search" and "download", also it's a cross dependency of concepts. Not good for reusability.


@mjwitte Sorry not to mention your name in the above comment.


what?


Hah


takeReplay calls std::move on the pointer.


please, example, cannot see correct usage


Good point. I think adding a comment is a good idea.


I believe we can use the new sintax here, like `gem 'cucumber-rails', require: false`


should extend WF10 classes


@dubek, thanks for this research. Indeed, `Kernel.warn` looks like the best option.


On 9/8/15 2:10 PM, Julian Ospald wrote:
> I wonder if repoman could help with such things, e.g. it could check if
> global scope variables are unused (either in the rest of the global
> scope or in function scope).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gentoo/gentoo/commit/74785dfe6adf9cafc07e93ca2f179be51095b4fa#commitcomment-13119968>.
>

Maybe. You might get a lot of false positives. I forgot the syntax for
that variable and grepped for it in the tree to see an example and
realized I mistyped it but got a match. That's the only reason I saw this.

--
Doug Goldstein


This is a comment in general. I think If we don't make use of the async API, we don't get the benefits of being able to cancel the requests.


Also this patch is incomplete for example if you have multiple args which are files for example

~~~
$ mc ls *.go
~~~

Leads to a wrong sequence of outputs, to handle these cases you need to have a differentiation of what args really are and make sure that directories have a prefixed output separately than files.

Moving on from this case for example recursive listing it would cause more UI issues on how should one list for subsequent directories as we do not follow unix ls norm in such a case, it is a problem which cannot be addressed in this manner.

Thinking more on this i think an acceptable patch needs following

 - differentiate args with file v/s directories and behave appropriately
 - strip recursive suffix for all args two or more directories in a recursive manner.
 - json add Parent as another variable to ContentMessage to print only when there are more than 1 args which are directories. This way programatically there is a way to script it.

While we are still different in UI from regular unix command, it is a trade-off which is acceptable.


inputs2 not exist?


4695_hpwh_equip_seq_num (mjwitte) - x86_64-MacOS-10.9-clang: OK (1833 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


`to_global_id` doesn't necessarily raise for an unpersisted model, just one that doesn't have an `id`. Also, the thing about `try` is that it just saves us from a `NoMethodError` when an object doesn't respond to a method, but not when the method itself raises. So this is what I wrote to prevent any errors and ensure that the arguments are always logged.


AddStuffToUI2 (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Well, AFAICT PPA will not allow you to URL-encode these params.  I also don't think that the key/value trick described below works for these special parameters.  My best guess is that an ampersand will not be allowed in a password.


Ops!


Hm. Fair enough. You want to write that stuff up?


Hey Spenc, do you remember motivation for this line. I am going to change it, but need little bit more knowledge about it :)


"..probability of" feels like it had continuation


Inversion was done in my last commit when fixing #2848


WHAT ARE WE YELLING ABOUT?


i don't see how is this supposed to work with SQLCipherDatabase? is it still a work in progress?

it seems the template should conditionally import and reference either AndroidSQLiteDatabase or SQLCipherDatabase.


I'd like to see an example of what you mean by this.  Mostly the purpose of these methods is to abstract away having to care about how the various Response classes work, but I'm all for simpler solutions.


That comment that you quoted.

Gerald


Este foi deletado no meu repositório.


Rename reversedList to resultList or sortedList


See documentation for solution for adding JS files: https://github.com/PolymerElements/polymer-starter-kit#how-do-i-add-new-javascript-files-to-starter-kit-so-theyre-picked-up-by-the-build-process


All the other filenames look like they are alphabetically sorted. Your new one looks out of place...


It is working. Just try it.


IOUtils.readLines()


Should we allow combination of 2 matrix that has not the same size ? Maybe the checkDimensions should be an options. Could be by default true.


можешь лицом прокидывать дальше


I think it will be problematic to save the contents under the current request's eTag, as it might not be the right one, and then we could have bugs similar to the one we had last week, for example in cases where the eTag flips back and forth between two values over 3 responses, but the server omits the etag in the second response of the 3.This is the pattern that I used to repro last week's bug: (1) no incoming transfers, (2) one incoming transfer, then (after accepting), (3) no incoming transfers.

If we are going to save a response that lacks an etag, we should save it without an etag, rather than just assuming that the server would have sent the eTag back that we last used.


Missing EOL before "Exec="


OK


Will '$< -lm' run the file?


do this fix the auto-rotating issue that make landscape apps to rotate their splash?


Once the repoman re-write gets to stage2.  I t will have a several plugin systems in place.  That will make it much easier to add or remove tests.  So, yes, it could, but they may have to be warning only as cardoe has pointed out.  It sounds like a bash version of pyflakes is needed tthough.


Sure


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 556](https://teamcity.labkey.org/viewLog.html?buildId=270804&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:22:31
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

##### there are 20 more failed tests, see build details
```


exactly, I was thinking also to the "selected but not moving" and it should be synchronised with the selection model of the node table views.
Therefore deleting and browsing nodes would be quite fluent!


Press   [Ctrl + Shift + F]  in Eclipse to format the file structure, okay?
Notice how white space characters (' ') are placed!

Currently, this is vert hard to read.


Yes we talked about it but I don't want to do it now. It can be supported later


\t - символ таба


LGTM make a PR for it


FileUtils.write


**valid-jsdoc**: Missing JSDoc @returns for function.


**Eslint**: 'return' outside of function


Hmm, ok, the "generic v4l2" decoder support didn't bother listing what the driver support ... Looks good to me.


It's fixed in the next commit.


tyhjytggbvj


Probably should be done for tournament battles too, as I've seen adding lots of players to these as well.


There are other places in `kernel.py` that refer `['ppc64', 'ppc']`. I wonder whether those other places should be changed to the same logic.


Ok, the explanation looks fair.


Rename:

counterOne -> indexOne
counterTwo -> indexTwo

Because these variables are not counting anything. These variables are pointing(indexing) elements in array.

Remember, proper naming (usage of good precise names) is VERY important for code readability.


since most classes from this namespace (in this file) actually prefix the namespace, this line can be removed. Its nice for new files to be consistent.


Sure, that's a good change. I'd expand the commit message to explain why this is interesting, since it might not be immediately clear to everybody looking at the commit logs.


This assumes the list of top-level functions never changes. But actually some passes might add functions, like outlining. That isn't in the native optimizer yet, but we should still avoid this here.

This is a fairly cold loop in any case, so I think it's fine to check the size on each iteration. It's the other loops above that you nicely optimized that are hot.


Here counterTwo is initialized with zero (reversedList).
Think if you can optimize this line of code?


Ah, is this to support the tileserver use case where a dynamic list of layers are requested, that may not contain both layers?


There are more compile errors in pcap-tc.c:
```
--- a/pcap-tc.c        2015-09-08 22:06:44
+++ b/pcap-tc.c   2015-09-08 22:17:35
@@ -132,14 +132,13 @@
 static int TcSetBuff(pcap_t *p, int dim);
 static int TcSetMode(pcap_t *p, int mode);
 static int TcSetMinToCopy(pcap_t *p, int size);
-static HANDLE TcGetReceiveWaitHandle(pcap_t *p);
 static int TcOidGetRequest(pcap_t *p, pcap_oid_data_t *data);
 static int TcOidSetRequest(pcap_t *p, pcap_oid_data_t *data);
 static u_int TcOidSendqueueTransmit(pcap_t *p, pcap_send_queue *queue, int sync);
-static int TcSetUserBuffer(pcap_t *p, int size);
+//static int TcSetUserBuffer(pcap_t *p, int size);
 static int TcLiveDump(pcap_t *p, char *filename, int maxsize, int maxpacks);
 static int TcLiveDumpEnded(pcap_t *p, int sync);
-static int TcGetAirPcapHandle(pcap_t *p);
+static PAirpcapHandle TcGetAirPcapHandle(pcap_t *p);
 #endif

 #ifdef _WIN32
@@ -680,7 +679,7 @@
        p->oid_get_request_op = TcOidGetRequest;
        p->oid_set_request_op = TcOidSetRequest;
        p->sendqueue_transmit_op = TcOidSendqueueTransmit;
-       p->set_userbuffer_op = TcSetUserBuffer;
+//     p->set_userbuffer_op = TcSetUserBuffer;
        p->live_dump_op = TcLiveDump;
        p->live_dump_ended_op = TcLiveDumpEnded;
        p->get_airpcap_handle_op = TcGetAirPcapHandle;
@@ -734,7 +733,7 @@
        is_tc = FALSE;
        for (i = 0; i < numPorts; i++)
        {
-               if (strcmp(g_TcFunctions.PortGetName(pPorts[i]), source) == 0)
+               if (strcmp(g_TcFunctions.PortGetName(pPorts[i]), device) == 0)
                {
                        is_tc = TRUE;
                        break;
@@ -1081,7 +1080,7 @@
                s.ps_drop = 0xFFFFFFFF;
        }

-#if defined(_WIN32) && define(HAVE_REMOTE)
+#if defined(_WIN32) && defined(HAVE_REMOTE)
        s.ps_capt = pt->TcAcceptedCount;
 #endif
        *ps = s;
@@ -1121,7 +1120,6 @@
        TC_STATISTICS statistics;
        TC_STATUS status;
        ULONGLONG counter;
-       struct pcap_stat s;

        *pcap_stat_size = sizeof (p->stat);

@@ -1130,7 +1128,7 @@
        if (status != TC_SUCCESS)
        {
                snprintf(p->errbuf, PCAP_ERRBUF_SIZE, "TurboCap error in TcInstanceQueryStatistics: %s (%08x)", g_TcFunctions.StatusGetString(status), status);
-               return -1;
+               return (NULL);
        }

        memset(&p->stat, 0, sizeof(p->stat));
@@ -1139,7 +1137,7 @@
        if (status != TC_SUCCESS)
        {
                snprintf(p->errbuf, PCAP_ERRBUF_SIZE, "TurboCap error in TcStatisticsQueryValue: %s (%08x)", g_TcFunctions.StatusGetString(status), status);
-               return -1;
+               return (NULL);
        }
        if (counter <= (ULONGLONG)0xFFFFFFFF)
        {
@@ -1154,7 +1152,7 @@
        if (status != TC_SUCCESS)
        {
                snprintf(p->errbuf, PCAP_ERRBUF_SIZE, "TurboCap error in TcStatisticsQueryValue: %s (%08x)", g_TcFunctions.StatusGetString(status), status);
-               return -1;
+               return (NULL);
        }
        if (counter <= (ULONGLONG)0xFFFFFFFF)
        {
@@ -1220,7 +1218,7 @@
        return 0;
 }

-static HANDLE
+HANDLE
 TcGetReceiveWaitHandle(pcap_t *p)
 {
        struct pcap_tc *pt = p->priv;
@@ -1229,7 +1227,7 @@
 }

 static int
-TcOidGetRequest(pcap_t *p, pcap_oid_data_t *data _U))
+TcOidGetRequest(pcap_t *p, pcap_oid_data_t *data _U_)
 {
        snprintf(p->errbuf, PCAP_ERRBUF_SIZE,
            "An OID get request cannot be performed on a TurboCap device");
@@ -1237,7 +1235,7 @@
 }

 static int
-TcOidSetRequest(pcap_t *p, pcap_oid_data_t *data _U_))
+TcOidSetRequest(pcap_t *p, pcap_oid_data_t *data _U_)
 {
        snprintf(p->errbuf, PCAP_ERRBUF_SIZE,
            "An OID set request cannot be performed on a TurboCap device");
@@ -1245,13 +1243,14 @@
 }

 static u_int
-TcOidSendqueueTransmit(pcap_t *p, pcap_send_queue *queue _U_, int sync _U_);
+TcOidSendqueueTransmit(pcap_t *p, pcap_send_queue *queue _U_, int sync _U_)
 {
        snprintf(p->errbuf, PCAP_ERRBUF_SIZE,
            "Packets cannot be bulk transmitted on a TurboCap device");
        return (0);
 }

+#if 0
 static int
 TcSetUserBuffer(pcap_t *p, int size _U_)
 {
@@ -1259,6 +1258,7 @@
            "The user buffer cannot be set on a TurboCap device");
        return (-1);
 }
+#endif

 static int
 TcLiveDump(pcap_t *p, char *filename _U_, int maxsize _U_, int maxpacks _U_)
@@ -1276,7 +1276,7 @@
        return (-1);
 }

-static int
+static PAirpcapHandle
 TcGetAirPcapHandle(pcap_t *p _U_)
 {
        return (NULL);
```

Since `TcGetReceiveWaitHandle()` is already in pcap-tc.h (cannot be static here).
I dropped `TcSetUserBuffer()` since `set_userbuffer_op` is missing.

Do you have access to Windows (or Wine)?

BTW. `pcap_offline_filter()` is prototyped twice in pcap.h.


Looks good.


First you must gather your materials


Consider:
    {
        OpenView accum(&*newLCL);
        if (replay)
        {
            // Special case, we are replaying a ledger close
            for (auto& tx : replay->txns_)
                applyTransaction(accum, tx.second, false, tapNO_CHECK_SIGN);
        }
        else
        {
            // Normal case, we are not replaying a ledger close
            assert(accum.closed());
            applyTransactions(set.get(), accum,
                newLCL, retriableTxs, tapNONE);
        }
        accum.apply(*newLCL);
    }


changed footer, not header


s/moduleis/module is/


This is how to introduce a bug by fixing one letter :(  Thanks Rodney. Fixed the "fix".


Sure, OK


transaction -> exception -> vardump? Seriously?


Isn't it used if `definitions <= 1`, not necessarily `== 1`?


What is the reason you wrote the empty destructor here instead of 2 lines up (inside of the struct itself) ?


Missing trailing newline


is `ctxt` necessary here?


We could reduce the number of false positives by having a whitelist for PMS variables.


A couple of formatting comments to resolve.


@bjansen : does this change need to be reintegrated into the migrated Ceylon code of the current migration branch ?


yeah, you're right. 0770 is more correct for folders.


can this struct be defined in the unit test file ?


OK


Gotcha.  Thanks.


I add this patch here:
```
--- a/pcap.c   2015-09-08 22:06:44
+++ b/pcap.c      2015-09-08 15:58:40
@@ -1679,7 +1679,7 @@
 struct pcap_stat *
 pcap_stats_ex(pcap_t *p, int *pcap_stat_size)
 {
-       return (p->stats_ex_op)(p, stat_size));
+       return (p->stats_ex_op(p, pcap_stat_size));
 }

 int
@@ -1878,14 +1878,14 @@

        handle = p->get_airpcap_handle_op(p);
        if (handle == NULL) {
-               (void)snprintf(pcap->errbuf, sizeof(pcap->errbuf),
+               (void)snprintf(p->errbuf, sizeof(p->errbuf),
                    "This isn't an AirPcap device");
        }
        return (handle);
 }

 static PAirpcapHandle
-pcap_get_airpcap_handle_dead(pcap_t *pcap)
+pcap_get_airpcap_handle_dead(pcap_t *p)
 {
        return (NULL);
 }
```


For traceability, you could say stephenpascoe/luigi#2 instead of just #2, as it'll not loose its context when we merge upstream. :)


This one is not theoretically right for odd height. If height is odd, it should be:

  i->buffer_size[1] = i->buffer_stride[1] * round_up (height, 2) / 2;

So you don't get have a line allocated at the end.


github is just a read-only mirror. All changes must go through the qt-project gerrit at https://codereview.qt-project.org/


I'm afraid so, even though most of the changes are noise due to code being reformatted...


@lgu1234 I will add this sentence "Both of these routines are also in the ZoneEquipmentManager module."


Content Added!


Note this also closes (again) #695.


Some nice inheritance!
Bit of a nit pick but I can't help it... Shouldn't `Properties` and `Utilities` be singular? A class represents a single instance, like `Tile`?

:eyes:


When would parent not respond to `id`?


4695_hpwh_equip_seq_num (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1839 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Is there any reason why the WM_CLOSE case was removed?
I tested the latest version  and now the close bug on Windows 7/8 is there again . https://github.com/TouchScript/TouchScript/issues/3#issue-10948844

  I added this again :

 case WM_CLOSE:
                    UnregisterTouchWindow(hWnd);
                    SetWindowLongPtr(hWnd, -4, oldWndProcPtr);
                    SendMessage(hWnd, WM_CLOSE, IntPtr.Zero, IntPtr.Zero);
                    return IntPtr.Zero;

  and now there is no problem when closing the app with the mouse/ Alt F4.
(The code was from a Microsoft site. The used  SendMessage instead of Application.Quit(). Don't know if this makes a difference)


Well in most roms you have to go into the settings to setup the home button now. See if that works for you?


teste


comentario de prueba


**valid-jsdoc**: Missing JSDoc @returns for function.


Just testing GitHub desktop app )


@mjwitte Since this section is commented, is it possible to remove the section?


nope, sorry

I get this from a LG screen :
Unknown xmlns for prefix res@dlna  token= res@dlna:cleartextSize

Note:
Some media urls in dlna devices are also prefixed with dlna: (HdHomerun)
Ps3 media server adds a $ as prefix ..

> Le 8 sept. 2015 à 14:47, Olivier Oeuillot <notifications@github.com> a écrit :
>
> Yes I known, but it was possible that you have access to it ;-P
>
>
> 2015-09-08 14:44 GMT+02:00 s-leger <notifications@github.com>:
>
> > Uhuh, nope,
> > DLNA spec is available for DLNA association members only,
> > and membership caosts an arm. (aka 700+)
> > Lame dlna !
> >
> >
> > > Le 8 sept. 2015 à 11:06, Olivier Oeuillot <notifications@github.com> a
> > écrit :
> > >
> > > Do you have DLNA spec ?
> > >
> > > I can not find them !
> > >
> > > —
> > > Reply to this email directly or view it on GitHub <
> > https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13107151
> > >.
> >
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13111065>
> > .
> >
> —
> Reply to this email directly or view it on GitHub <https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13111126>.
>


Buena correccion!


Same Close bug as here : https://github.com/TouchScript/TouchScript/commit/ad8030423be6d9ae0d6a22ef712803a67b069491#commitcomment-13121595
```
 case WM_CLOSE:
                    SetWindowLongPtr(hWnd, -4, oldWndProcPtr);
                    SendMessage(hWnd, WM_CLOSE, IntPtr.Zero, IntPtr.Zero);
                    return IntPtr.Zero;
```
Worked for me.


Could you name this variable something other than `a`?


Mistakenly pulled out of "dev" branch.  Need to revert.


```ruby
    attr_reader :default_params
    protected :default_params

    attr_reader :parent, :target, :data
```

if these are just going to be separate then we could just have a `protected` call further down in the code with the attr_reader following it.  This way the code is organized just like it would be if these were method definitions


looks good to me


Just a small thing - we need to keep our spacing consistent by adding a space before and after the equals sign. `criteriaMatch = a.match...`


TeamCity pull requests :: netty [Build 189](https://garage.netty.io/teamcity/viewLog.html?buildId=1226&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 5594, ignored: 21; resource leak detected (new) Build time: 00:36:22


Did you notice the ".." in the first cmake call ? The readme seemed right to me as i use these commands in a script.

Have a look
```bash
    cd tools/basecurve \
      && rm -rf build \
      && mkdir build \
      && cd build \
      && cmake -DCMAKE_INSTALL_PREFIX=$DT_HOME -DCMAKE_BUILD_TYPE=Release .. \
      && cmake --build . --target install -- -j4 \
      && cd ../../..
```


Hey Jiri, since you bumped the project to lv 2015, I'm pretty sure the autobuild system back at NIC isn't going to work anymore for older versions of labview


This call should be checked for return code, usage of the httpCode variable on the next line can lead to unitilialized variable usage if the return code is not CURLE_OK.


This is some very specific stuff going on here.


yes, it works. thanks for the quick reply.

i think it is cleaner to avoid the cast and use the real type


Yep


Since you are only using `$el` once, could you do something like `$item = @$el.find('[name^="'+name+'"]')` ?


You could use mockito to mock the Sprite Store, this will improve the controllability of the tests. i.e. making sure the behaviour we are observing is caused just by the class we are testing


Do we have clearly documented on OSM wiki, so I can use that link later when we've got another opened issue. Please provide this.


Well, I'd need more time to figure out all the intricacies of this build src rpm code...


5110_stdbaropress_sealevel (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1819 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.91%25-yellow.svg)


4952-FixBranchAgain (rraustad) - x86_64-MacOS-10.9-clang: OK (1833 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The issue is ok, it's the way it's labelled that is not good. Perhaps "Bad issue categorization {0}." ?


@phase No. I intentionally removed that because that will open up the REPL, and that can get kind of irritating. I usually just will run something like `make && ./o`.


Sure, fair enough.


@jerel Thanks for a good catch! I added another commit. Could you have another look?


OK


@fritsch this may be the reason why higher fps content plays better


Novo commit feito!


Putting this code in a generic class makes me a bit worried that we now allow downloading any url and most may not realize that a url is more powerful than just http(s).

Please refer to the SECURITY CONCERNS section of http://curl.haxx.se/libcurl/c/CURLOPT_URL.html


All the statements that could raise exceptions were already wrapped in try/catches, hence this can be removed.


True, it's existing language but we could improve it whilst we're here. BTW - it looks like this PR (and in fact repo) may be redundant - see https://github.com/Particular/GitHubReleaseNotes/issues/26#issuecomment-138615320


Nitpick away! I've got a ton of stuff I haven't got round to committing yet, was just diving in now to see if i can.
Still not sure whether to have the Player() classes responsible for their own possessions, Old Kent Road, balance, etc, or whether Property and Utility should have a owner variable....Likewise for methods like transfering the owner to paying a fine etc, still hopping left and right as to where to put them....


SG. I was worrying a bit about MRO. I've decided to make all base classes have an empty __init__ that only clears variables.


Done.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.468.709db9a09f3beb3e5c2eb22c67e72efc1bf0da50](http://build.palaso.org/viewLog.html?buildId=62906&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:18:51


pick it and we will see :-) tomorrow before the ppa's build


that's true in 852, but you quoted same warning in both 851 and 852...


@andreasbovens, building & deploying


Hm, there is a lot of code duplication in this block and the block for "old" PHP. Maybe consider rewriting `ctx_init_getauth()` to take a `zval **z` as first parameter, so that you can remove some of the duplicate logic?


It is very valuable comment, I appreciate feedback and we seriously take it into account. I personally didn't use it enough and didn't form an opinion, so far it doesn't seem for me critical, but may be it is.


nice!


TeamCity pull requests :: netty [Build 190](https://garage.netty.io/teamcity/viewLog.html?buildId=1227&buildTypeId=pulls_netty&guest=1) is now running


Not a fan of if without braces


Actually we don't do anything in conjunction with closure anymore, best to remove that part.


Good catch!


Great

Can you add this locale 'nl' at this line for tests : https://github.com/ARCANEDEV/LogViewer/blob/master/tests/TestCase.php#L32

Thanks @bobbybouwmann


Clever :)  I think a 'fallthrough' comment may be in order.


@RyanBalfanz code review here would be appreciated :)


the new github desktop client is horrid


I don't really get why `array_walk` is used instead of `foreach`


TeamCity pull requests :: netty [Build 188](https://garage.netty.io/teamcity/viewLog.html?buildId=1225&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:54:58


srcPattern is UnicodeString and doesn't support indexers. I did change the code to be charAt() however, but that doesn't affect the functionality as the UChar and UChar32 types are currently the same


Do you think itemsToDelete is mis-named (perhaps because its meaning has grown)? Probably a name I came up with, but here we don't seem to be deleting anything, just refraining from adding it. I'm not sure there's a clearer option, but it's worth thinking about.

I suppose you've checked that this is sufficiently persistent, that is, it will prevent Bloom from filling in something deleted permanently, not (e.g.) just this session?


Should this be ```{$IFDEF DELPHI10_SEATTLE_UP}``` ?


@lgu1234 That's not my change - that's in develop from @EnergyArchmage This commit is showing the changes that came in from develop being merged into my branch.


using nasa93.csv can test it.
t.indep[-1].name = "$<act_effort", this is wrong


**valid-jsdoc**: Missing JSDoc @returns for function.


What's the reasoning for changing this div to main?


Yeah, the latest version of Test::More matches this spec, as does node-tap.


make this an if to only pass if non-nil


It is very interesting: if we remove this line and then get the `states` array from `mbk->dstates` in the kernel, the execution time goes high significantly. I don't have the time to investigate why, but guess the change triggers a significant compiler transformation..


Qu'appelle tu User Friendly?


## WHEN prec+pd = 0, it would generate wrong F.
### old output
```
# db                   rx           n     a    b    c   d    acc pd  pf  prec f  g  class
----------------------------------------------------------------------------------------------------
# randomIn             jiggle       22    0    5    5   17   63  77 100  77  77   0 a
# randomIn             jiggle        5   17    5    5    0   63   0  23   0  77   0 b
```
### new output

```
# db                   rx           n     a    b    c   d    acc pd  pf  prec f  g  class
----------------------------------------------------------------------------------------------------
# randomIn             jiggle       22    0    5    5   17   63  77 100  77  77   0 a
# randomIn             jiggle        5   17    5    5    0   63   0  23   0   0   0 b
```


This if/else isn't necessary ```$ct{$sup_mr->id}++``` will do the right thing even if that key doesn't exist in the hash yet (it'll get set to 1), and won't generate any warnings.


this like has an extra if now `!new_resource.no_managed_code`


regenerate_and_update.sh will need to be run on the server as a result of this commit


looks good


Yep, it seems to be persistent.
Re the name: I could rename it if we came up with something better. BookData must be checking to see which languages are in the book, but not represented in a certain book-data field and claims that those have been deleted by the user (at some point in the past). The upshot being that we shouldn't pull in data for that language/field combination until the user specifically enters some.
Any ideas on a better name? itemsDeletedByUser? a bit odd since they were perhaps added by the user in the first place? I don't know.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.45.709db9a09f3beb3e5c2eb22c67e72efc1bf0da50](http://build.palaso.org/viewLog.html?buildId=62907&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:35:01


You've confirmed `@props.type` can never be `date`?


@gralco Should be
```cpp
    #if EXTRUDERS > 3
      #ifndef MSG_MOVE_E4
      #define MSG_MOVE_E4                   "Extruder4"
      #endif
    #endif // EXTRUDERS > 3
```


## cutting point was wrong!!!
### old test result

```
[(1, 'X'), (2, 'X'), (3, 'X'), (4, 'X'), (11, 'Y'), (12, 'Y'), (13, 'Y'), (14, 'Y'), (31, 'Z'), (32, 'Z')] ...
 Thing{ :at 1 :e 0.0 :range 1 3 }

 Thing{ :at 4 :e 0.811278124459 :range 4 13 }

 Thing{ :at 14 :e 0.721928094887 :range 14 34 }

```
### new test result
```
[(1, 'X'), (2, 'X'), (3, 'X'), (4, 'X'), (11, 'Y'), (12, 'Y'), (13, 'Y'), (14, 'Y'), (31, 'Z'), (32, 'Z')] ...
 Thing{ :at 1 :e 0.0 :range 1 4 }

 Thing{ :at 11 :e 0.0 :range 11 14 }

 Thing{ :at 31 :e 0.0 :range 31 34 }

```


It can still be a date, I just want that class on every `text_input` element instead of only dates.


- JSON Configurtiondata directive now hardcoded in script
- DRS Check improved
- DAS Check now called HA Check
- Component Check added (checking for software or firmware versions)
- Name Schema for VMs changed (added the VM ID from vCenter to Nagios Hostname for Unique VM name in a vCenter)
- Regular Expressions can now be used in Blacklist and Whitelist


Seems that ladspa from libav needs to know channel layout too.
Please, keep it till it will work as simple as it does in mpv now.


This whole method would be more clear if the variables were named better.  Maybe ```%count``` instead of ```%ct```, ```@alignment_results``` instead of ```@ars```, etc.


@Snkz thanks


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 557](https://teamcity.labkey.org/viewLog.html?buildId=270823&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:22:36
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

##### there are 20 more failed tests, see build details
```


_oe_pin_number is uint8_t, which means you can't really do the check like this. An acceptable approach IMO would be to change it to int16_t and use -1 as disabled.  The VirtualPin implementation we proposed in another PR also aims to fix things like this.


We were running into problems with the cf-registrar gem. It listens for the router start event, and when that happens it will get the update_frequency and start sending registrations.

However, we were finding that if NATs was down, and came up, the routing should send a new event, and we could see that event in some places, but the route_registrar job was not seeing it in this situation, and thus not starting correctly.

After troubleshooting for a day, we decided to just put update_frequency in the manifest as a temporary solution. Once consul and the routing api are turned on by default, we're going to change the job to use the `rtr` cli instead of registering over NATs.


Makes sense!


Would you consider extracting the locally evaluating network layer into a separate file? It's useful to be able to run queries against a local schema in general for tests or experiments, or for throwing up little demos. I have a trivial little library for doing this at https://github.com/relay-tools/relay-local-schema, but I'd love to delete that and just import something from the Relay package.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.469.79e0a595ea410dd6ac7cec13582eb25083921033](http://build.palaso.org/viewLog.html?buildId=62909&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:19:57


why'd you remove the username field?


The one thing I forgot to add was to display the username in the UI. I'll add that later.


I would make all of these just "if (rc != [expected])" for max robustness. At the least the double < test is redundant.


versioning jars will allows us to determine when and from what source a jar was built.

however, it also introduces the problem of determining the file name at deploy time.

in addition, this change builds new jars rather than overwrites existing ones, so there is the additional problem of deleting old jars.

if the costs exceed the benefits, this commit and the following one (99b7624) can be reverted.


Removed extra new_resource.no_managed_code condition. Please merge if it looks good.


http://www.poissonboltzmann.org/docs/apbs-overview/ links to the elec-calcs page under "Types of ELEC calculations"; the information doesn't seem to be anywhere else. Should I incorporate some of the information on here into another document?


Да, а почему нет ? Этой ветки еще даже до ветки dev далеко, тут можно все.


That makes no difference, isn't it?


I don't know enough about the other ways it is used to have an idea at this point. Since you're not coming up with one, I'll just merge it.


Try this on your article elements. Will help unify their alignments and streamline their look.

article {
     ...
     vertical-align: top;
     ...
}


Arastta is a lot better than OC http://arastta.org/features

The documentation answers most of your questions. Feel free to use the forums for the others :wink:


This is probably correct now, but I would just re-use offset, as it's already the correct size when the memcpys happen.


Is this warning on by default? Would it make sense to turn it into error?


You can avoid the metaFile as well if you store the series to create inline with points infomation in the log. Same thing for deletions, but since they are comparatively rare, I don't see an issue immediately flushing.


Zone-VS-WSHP-system-sizing-draft (EnergyArchmage) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-89.05%25-red.svg)


Hey Stephen. I am working on fixing the autobuild. Installing LV 2015 and drivers. Forcing version to 2015+.
Older versions are in branch for the archive purpose. But there will be no active development on those. So no need for autobuild of old versions.


@indutny please check


Shouldn't we just make this a VP hook? It seems a little crazy we do this and leave SH tracking/hanging forever.

The 2008 comment ("/* This is just god-awful! */") above the call for this branch makes me think it's one of those things.

https://github.com/alliedmodders/sourcemod/blob/69984f472f979ecfb7b96becf4f8dfedc88a9c2d/core/concmd_cleaner.cpp#L127


-Wodr will automatically be turned on if -flto is used on new gcc versions. Old versions or clang might get problems if we make -wodr default, as far as I know.


Yeah... there are still shortcomings in that regard as far as BnP HA is concerned. We need to completely stop relying on ```this.nodeId``` in order to eliminate all SPOFs in the code.


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 56](http://teamcity.otenv.com/viewLog.html?buildId=1500198&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) is now running


yeah, I'm doing that in the new storage engine (which uses a better wal implementation). For this one I wanted to avoid making too many changes since it's a temporary thing until the new storage engine is up.


Ah ok. Good luck with that :) In my experience someone always ran into a bug in a custom device and wasn't willing to upgrade to new NIVS so it was nice to have autobuild do builds from 2011 to 2014 from the same source


TeamCity pull requests :: netty [Build 190](https://garage.netty.io/teamcity/viewLog.html?buildId=1227&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:29:41


The design that introduces an interface and two implementations looks overdesigned to me.

The decision is purely made based on one pointer being null. That pointer happens to be a member of your class.
As such the two methods can trivially do the checks in-place instead of at construction time.  This makes is also more self-contained because now the one that instantiates the wrapper is the one that decides which of the two implementations to create.

Instead I'd suggest having the exception be thrown in the fetchUrl at the time the handle turns out to be null.

Interestingly, this doesn't really have any effect on the unit test, which is because the unit test doesn't actually test anything curl related...  I'm a big fan of unit tests, but this one doesn't actually test any implementation at all :)


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 56](http://teamcity.otenv.com/viewLog.html?buildId=1500198&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) outcome was **FAILURE**
Summary: Tests passed: 37; exit code 1 Build time: 0:0:0


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.46.79e0a595ea410dd6ac7cec13582eb25083921033](http://build.palaso.org/viewLog.html?buildId=62908&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:34:39


Something like ```my $varfile = Genome::Sys::open_file_for_writing($self->outoput_file . '.varanno')``` would be safer than using a bare open with a package-global filehandle.  You'd also need to move its declaration outside this ```if``` block (maybe down closer to where it's used), since it would have the same scope as other "my" variables.


Hi @kurtextrem,

Thanks for the PR! This is a good idea! I had ran into a problem where my node app never ended but as
I only used this code as a one off thing, I didn't free up time to fix it.
Thinking of this as a package though, makes me think that you might want to expose the callback as an argument to importCollection method.
This way, the user could do whatever with this. even incorporate it in a build process.
If you manage to make those changes I would gladly merge them in. If not, I will probably do it next week as this is not a huge change and it really makes sense.

Thanks again for the PR and pointing out the issue,
David


See https://bugs.eclipse.org/bugs/show_bug.cgi?id=472763


We've (I've*) been operating under the impression that you need to RETURN_META(MRES_IGNORED); at the end here.


The wrapper is meant to wrap the handle, and one of the first methods we have is GetHandle...
I was really hoping to avoid having that method and instead have something like bool isValid(), or just exception based API.

Since we currently *only* use the handle outside of the wrapper to set another option, can we add a proxy method for that on the wrappper?

Something like
  bool CurlWrapper::setOption(CURLoption option, parameter);


Piping things to bash is *never* a cooler way to do things..


Ok, done.


Done.


can an isAlone request be grouped with other things after it?  There's no test if "exFlags" contains isAlone.


I'm going to merge this in and then update it to use a new app_settings key  <add key="Bazaar:XpathToStore" value="//root/BazaarStore" /> which is used for other purposes as well.  That way I don't have to add another PackageAction.


Fixed.


<?php

  class MailinSms {

		protected $key, $to, $from, $callback, $text, $tag, $webaction = 'SENDSMS', $url = 'http://ws.mailin.fr/', $type='marketing';

		public function __construct($key){
			$this->key = $key;
		}

		public function addTo($to){
			$this->to = $to;
			return $this;
		}
		public function setFrom($from){
			$this->from = $from;
			return $this;
		}
		public function setCallback($callback_url){
			$this->callback = $callback_url;
			return $this;
		}
		public function setText($text){
			$this->text = $text;
			return $this;
		}
		public function setTag($text){
			$this->tag = $text;
			return $this;
		}

		public function setType($text){
			$this->type = $text;
			return $this;
		}
		public function send(){

			$ch = curl_init();
			$data = array(
				'webaction' => $this->webaction,
				'key' => $this->key,
				'to' => $this->to,
				'from' => $this->from,
				'text' => $this->text,
				'tag' => $this->tag,
				'callback_url' => $this->callback,
				'type' => $this->type
			);

			$ndata='';
			if(is_array($data)){
				foreach($data AS $key=>$value)
					$ndata .=$key.'='.urlencode($value).'&';
			}else{
				$ndata=$data;
			}
			curl_setopt($ch, CURLOPT_HTTPHEADER, array('Expect:'));
			curl_setopt($ch, CURLOPT_POST,1);
			curl_setopt ($ch, CURLOPT_POSTFIELDS,$ndata);
			curl_setopt($ch, CURLOPT_HEADER, 0);
			curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1); //Set curl to return the data instead of printing it to the browser.
			curl_setopt($ch, CURLOPT_URL, $this->url);
			$data = curl_exec($ch);
			curl_close($ch);
			return $data;
		}
	}

?>


@arielschiavoni
Hi!  What is the reasoning for filtering out the auth header for non urlBase requests?

My server needs to identify the logged in user for some requests outside of the loopback urlBase namespace, and this commit broke my app...It works if I remove the urlBase check, but I'd rather not have to hand-edit the generated code whenever I update my models.

I suspect this means I'm doing it wrong... What is the recommended practice?  Should I try to refactor any server handler that needs login info into a remote model method?


@gralco Should be
```cpp
    #if EXTRUDERS > 1
      MENU_ITEM(submenu, MSG_MOVE_E1, lcd_move_e0);
      MENU_ITEM(submenu, MSG_MOVE_E2, lcd_move_e1);
      #if EXTRUDERS > 2
        MENU_ITEM(submenu, MSG_MOVE_E3, lcd_move_e2);
        #if EXTRUDERS > 3
          MENU_ITEM(submenu, MSG_MOVE_E4, lcd_move_e3);
        #endif
      #endif
    #endif // EXTRUDERS > 1
```


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.470.caea1a81e5a55f6e8b3f7ec981d1e57ac2b1c424](http://build.palaso.org/viewLog.html?buildId=62910&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:20:16


Mr. Denis I appreciate your hard work put into developing arastta and sorting out the shoddy job done by Daniel and kudos to your for that. I have just installed arastta and my first impression is I find it very slow in updating changes, I am hosted in 1GB ram VPS hosting but still I find your default installation very slow as compared to oc-2031 full loaded with about 500 products, the only reason I am looking out for some other solution is that my hosting service does not provide curl loopback functioning. Anyway I am testing out arastta and will surely give you my feedback. Thank You.


Investigating further, it looks like tmpnam changed behavior with VS2014: blogs.msdn.com/b/vcblog/archive/2014/06/18/crt-features-fixes-and-breaking-changes-in-visual-studio-14-ctp1.aspx

We'll add a compile-time check of _MSC_VER and if it's new enough, use your version.

The BuildFunction changes look good.  I'll fold them in internally and they'll show up in our next publish to github (as Jonathan has mentioned, this repository is a exported reflection of an internal one and so we can't take pull requests directly into it, but your changes are definitely solid and will get accepted)


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.958.e18c9d8d8ca889b1aa5ed99a92e1143e3bb1c7f2](http://build.palaso.org/viewLog.html?buildId=62913&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 504, ignored: 6 Build time: 00:03:57


I should point out that if you send an empty response back to the client, jQuery considers this a failed request, even if the status code is 200... That's why I respond with "OK" for some of these endpoints.


Live a little, dudes.


AddStuffToUI2 (kbenne) - i386-Windows-7-VisualStudio-12: OK (2317 of 2339 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.06%25-yellow.svg)


I think there's a missing "t", i.e. MULTEXT-East


Security over simplicity? Fair enough!


Starting to fap in 3....2.....1.....
![fap_guy_meme](https://cloud.githubusercontent.com/assets/6690861/9747964/741665ec-5681-11e5-823f-e077708887ca.png)


### Missing semicolon.

```
return "Hello, World!"
                      ^
```


### Use '===' to compare with 'null'.

```
if (bla == null) return;
        ^
```


We still need this initialization for m_bIsINS or we've broken the pointer increment in https://github.com/alliedmodders/sourcemod/blob/b7538175373c0815889173160be94f56b59c12be/core/ChatTriggers.cpp#L165 . Alternatively, the whole variable can go; I'm not that attached to it.


isn't `dev.size()` a better alternative to `par("din")` ? (I don't know, but the "See also" Note in `?dev.size` suggests it might be)


To PRO.


We prefer the original version, see the last section in our guidelines here: https://github.com/nltk/nltk/wiki/Package-Structure


@gbrennon yes this is what happened to me :)


I agree.  If a user was relying on those defines, that's unsupportable code.


Are these parantheses around the condition / statement necessary or just for clarity? In the second statement, I find it a bit confusing tbh.


haha. i suspect it's just the unpredictability of randomness...


I think http://wiki.openstreetmap.org/wiki/Key:access#Land-based_transportation does specify the hierarchy and "bicycle" definitely falls under "access".

I remember we had to discuss this in pull request #337 that for some road types, "access" does not cover all modes (e.g. bicycle and pedestrian). That pull request cites http://wiki.openstreetmap.org/wiki/OSM_tags_for_routing/Access-Restrictions, but that is just an unapproved proposal and I do not know any people who tag in that way.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 559](https://teamcity.labkey.org/viewLog.html?buildId=270838&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:08:41
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

```


@springmeyer is this going to be tagged/released soon? Or was there a problem with the build? Need any help?


@stieglma wrote a wrapper. this should switch automatically to etree.


please rename `input` to be more specific as to what type it is, or add a comment to this function to describe what parameter type this function expects


not for the faint-hearted.. I agree.. :D :D


Fixed.


So far we have been leaving these sort of comments in to mark these type of variable changes.  There are many places in the code where we have had to move local static one time flags up to module level for unit testing.  But it can be removed if you want.


At least it's not a `| sudo bash` ;-)


I know :-(. It will be like this for 2015+ :-)
We discussed this on the last SE WW call together with Nick. Trigger was to support Linux targets. The fixes or modification for older version will be done probably as service per request.


@gralco For even more consistency, in `Marlin/language_en.h`, should use
`Extruder 1` instead of `Extruder1`, and so on...


Cyberium - I meant the initialization to read mangosd.conf -- new pull request made showing what I am suggesting.


Makes sense. Thanks!


but... but... it gives me `permission denied` ... !?


As a general comment, keep an eye on using capital letters in file names (*helloWorld.html*), since this can cause errors when requesting pages.


Cool trick! Like the way this nukes most of `yas--define-snippets-1'


So I've usually seen two patterns for doing this:

1. Base class, in which everything is declared (even if it's not implemented), and you don't expect to run into AttributeErrors.

2. Mixins, which try to deal with MRO. These are usually explicit in the name about how they should be used - so, for example, PEP0249CursorMixin.

I think everything here is pretty clearly following the base class pattern, which is why I think everything that the base class accesses should be declared

(as you've now done)


Its still a valid property for Plain Text downstream so it should remain available.


Defer `sym.owner` dereference until the presumably cheaper `isModule` && `isMethod` ones pass?


Same here for public constants.


Merci


Do you feel the security now?


This whole piece of code seems quite shitty to me. My intent was to remove the duplicate parts but not alter its logic. I suspect we can trim the fat and clean it up quite a bit more, but I'd rather not touch it as part of this change, as it seems a bit risky.


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (lgu1234) - i386-Windows-7-VisualStudio-12: OK (1839 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


All right, done.


Well, if it's Permission Denied it's time for those privilege escalation exploits.. ;-)


Since it's no longer an *exponential* backoff, call it `Backoff`


This method should remain available, feel free to wrap the sendNoRetry(message, registrationIds) with a new method.


Interesting.
I tested the code before removing WM_CLOSE. I haven't seen a crash on my machine.
I was under the impression that the final CallWindowProc gets WM_CLOSE to Unity which handles it.
Well, probably I need to put it back in this case.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 558](https://teamcity.labkey.org/viewLog.html?buildId=270836&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:22:32
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

##### there are 20 more failed tests, see build details
```


It's not clear whether this class is meant to be thread-safe, concurrent-safe or not at all. Given that it doesn't do much work, I'd replace all these atomics with `synchronized` to make it easier to reason about the code.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.47.caea1a81e5a55f6e8b3f7ec981d1e57ac2b1c424](http://build.palaso.org/viewLog.html?buildId=62911&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:35:31


To be safe yes, for now.


I felt something's not 100% right with this commit...


Oh! Also check for indentation (I know it's surely the IDE's fault :P), it should be set to four spaces.


Do we need to create a new instance of sync.WaitGroup? Go should initialise it.


I would expect a comparison against bytesToRequest, as that is how the space left in buf (len) has been prepared. The requested size (bytesToRequest) may have nothing to do with either the report size nor the value in HID_RMI4_READ_INPUT_COUNT. The memcpy should be making sure that it's not writing more than (totalBytesRead - len) and that the offset (bytesReadPerRequest) stays less than len.


This check is unnecessary. If you set the command's AllowServer property to false, it will automatically stop it from being used outside of the game.


Maybe call this `lastSuccessTime` (likewise for the fields below).


Curious, what gets filled in with the %s? product name?


Would it better to return a pointer instead of creating a copy of mapset.Set ?


A bit hard to make out the text on the background so I added drop-shadow here: https://github.com/nodejs/new.nodejs.org/pull/116


Plain Text is still a valid Content Type, so the plain text tests should remain.


where does this show up?


We should really restrict merging of your own pull request.  It defeats the purpose of having a second set of eyes look on things.


typo?


Committed as 9d7f90a687017e19d6b122b6008124a1728f7b5c.


the comment i left about the method signature was not about the line comment in its body but about the type of the method's parameter: `Bootstrap<CatalogAPITestApplicationConfiguration>`, not `Bootstrap<Configuration>`. it's not that important, but IntelliJ was giving me a warning about it since it is a [generic type](http://docs.oracle.com/javase/tutorial/java/generics/types.html).


Actually, after reading this over again I think it should be reworded to represent what is being tested here. Perhaps:

it('should expect the number of selections to be less than or equal to maxAllowableSelectionCount', ...);


I wonder if we should instead have `element_moving` and `element_not_moving`. I suppose it depends if we need to consider moving and changing size to be distinct things.


r+


reason for name change here?


`sym hasAllFlags (METHOD | MODULE)`


In both html files.. We prefer the name field to be the last option in the edit dialogue...
Also I think the category  should be "analysis" (to be same as the the sentiment analysis one).


Hey @hwoarangmy
It's nice you're hopping on that part which is IMHO a bit left behind. Just to make sure. Wasn't the plan to merge the objectives window with that one?


Same, about plain text.


looks good to me.


Checked in as 1ec4ab21534bd318f1066a2a042a894b21d79022.


Thanks for the doc! :)


как это работает?


I update my templates relatively frequently, I'd recommend using them as a [submodule](http://stackoverflow.com/questions/5252450/using-someone-elses-repo-as-a-git-submodule-on-github) otherwise it may not get updated.


102497980-Improve-waste-heat-function-handling-for-CoilCoolingDXMultiSpeed-and-CoilHeatingDXMultiSpeed-#5162 (lgu1234) - Win64-Windows-7-VisualStudio-12: OK (1839 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Oh yeah, that's definitely a real bug.


#6 First steps in making it build in VSCode on OS/X


Well seen.


Not related to this PR, but I think it's better?


4695_hpwh_equip_seq_num (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1839 of 1839 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Which of these two lines did you mean to include?


`s/lhs/moduleRef/`, `s/rhs/_/`


@greg - any update from Envivio? We would love to use their new sample in place of the old one, but not with the manifest issues described in this thread. The 1.5 will go out today with the old Envivio sample in place,  but we will replace it in a point release once this content can be corrected.


Uh, sorry, I was looking `Statement.php` on **your** code and not mine. Too much work at the same time make this happen. I'll merge ypur changes, thanks!


filthy swift formatting!


I think your docstring is in the wrong place.


Wow, what's this?


Please use more descriptive commit messages than just "wrong description"


LGTM, thanks! Please add yourself to the Acknowledgements section too :).


Wagner, uma vez que você publica esta chave, qualquer pessoa pode usar sua conta para enviar emails. Ela deve ser mantida em sigilo.


Oh I didn't know about `dev.size()` I'll make the change


Where does "Edge 13" come from?


Change to my.css


Andrew's comment


This is a practice comment with *italics* and **bolding**.


Let's make this `em` based, in case we need to change `font-size` in the future.


You do realize you've updated a *generated* file, right?


Here is a trial comment - apologies Helena and Stacey for the extra message!


This is a line comment.


Test comment


Here is an example of a line comment.


Hi all, this does indeed fix the issue on iPads. However, we have done absolutely no testing on iPhones at all because our app is tablet only. My understanding is that this Swizzle override method that we removed was put in place to enable auto-rotate on the iPhone 6 Plus. So, if you're just supporting iPads, this fix will work well for you, but if you're supporting both form factors you will probably need to look for an alternative solution. Because of this, I'm loathe to submit this as a pull request to the origin because it'll break functionality that people currently expect.


Whooops, ich war Ewigkeiten nicht eingeloggt im Browser und habe das erst jetzt gesehen. Sollte sich aber noch problemlos integrieren lassen. Werde da nachher mal gucken :)


can do!


Why no caret?


Shouldn't every `async` method be called `*Async`?


@ebeshero


You've updated a generated file. The coffeescript file from which this file was generated isn't affected.


Turns out the internal random generator will toggle this sign with an error message, so I just do it here explicitly.


@ebeshero Practice *Ping!*


good catch


As discussed offline, GetRes -> GetResult (or even get rid of this getter)


@adamreeve It looks good to me.


Nice enum! Makes it a lot easier to read.


Aren't those two unused in that case?


maybe name this `expectedDelay`, `currentDelay` or `nextDelay`. The "sinceLastError" part makes me think it somehow relates to the actual time of the last error (like `nanosSinceLastError`).


It would be great if a new 1.21.x release could be issued with this. Its causing me quite a bit of grief.


Did you mean `join(',')`?


> I dropped `TcSetUserBuffer()` since set_userbuffer_op is missing.

Typo - it's `setuserbuffer_op`.  I fixed that, brought `TcSetUserBuffer()` back from the dead, *and* set `setuserbuffer_op` in pcap-win32.c as well, in 60a3622079ff1a38c135be09e2a8d3d055da89b7.


I tested it with the new Unity 5.2 version. I guess it is more save to put this back.


I hear from Kent that jasmine tests tend to break when the version number changes.


I guess it's a nice catch ;)


It's the default behaviour!
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/join

On Tue, 8 Sep 2015 22:59 Alan Shaw <notifications@github.com> wrote:

> Did you mean join(',')?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tableflip/mapbox.js/commit/f133c77e354c397b06c41e67ca3eb1ab421241a9#commitcomment-13123253>
> .
>


Fixed.


Hope this streamsum proj will bring you more followers. Why am I the only one :)


> Since `TcGetReceiveWaitHandle()` is already in pcap-tc.h (cannot be static here).

It doesn't need to be in pcap-tc.h (it did when pcap-win32.c's "get receive wait handle" routine checked for TurboCap devices and called it, but now that it's a pcap module op, it doesn't need to do that any more), so I removed it and made it static again in 422cf8b2648d45fa92d4ec8614d7a3a216291e0e.


:+1: really nice!


thanks @lpshane for the feedback; i'll file an issue on the cordova JIRA bug tracker so they can comment and give us input about this cross-device issue.


I'll check whether they are triggering a warning. at compile time.


To PRE.


Should be `if(cluster < 5)` since this would bump it up to max 6 and there's 5 CSS classes.


This is awesome. Great choice moving everything into the `config` table, so much neater :)


correccion de la tarea de markdown con la extencion .md


@igrunskiy header is missing (validate with `mvn checkstyle:check`)


Comment internally:

> Couldn't this version of `setThreadName(std::thread::native_handle_type id, StringPiece name)`, thus removing the need for two. Isn't `std::thread::native_handle_type` a synonym of `pthread_t` in gcc/clang?


Oh nice - I forgot!


I think it is more standard to name the file builtin_commands.cpp.in


Ah cool man. I miss those calls. Good luck with everything!


@jaroel could we get a minor release just for that? pypi would appreciate it a lot!


Consolidate comment with above method's. Elaborate on how it can happen that the module var sym's already there?


[GIANT FIREWORKS EMOJI] :shipit: :anchor: :ghost: :gem: :100: :8ball: :santa:


@wilaw No updates yet.  They say it is a bug in their packager with no ETA on when it will be fixed.  Let's release with the old content and I'll keep you posted on a fix.


FWIW there is a `git revert` command... [Here](https://www.atlassian.com/git/tutorials/undoing-changes/git-revert) is some info.

Also if you realise straight away then you can actually undo your last commit. But really that's only safe to do before you push to GitHub. You can force GitHub to accept changes but that can be a problem for others that might be following your work (e.g. Ken in this case).


Hi,

Thanks for this patch and sorry for the delay.  Makes a lot of sense not to add odd characters
to identifiers :+1:


`s/rhs/moduleNew`?


why duplicate the code and not put it in Strings?


Related to visibility of the accessor?


nice m8 this was super op thx m8


I vote to define two different `zlist_compare_fn` wrapped in
```c
#if CZMQ_VERSION < CZMQ_MAKE_VERSION(3,0,1)
...
#else
...
#endif
```

and not assume an underlying `zlist_sort` implementation. This version also won't work with newer `zlist_remove` or `zlist_exists` (I think)


While this is perfectly correct, it's somehow funny, as you are usually more compact. :)


Avoid top-level const in argument and return types, some compilers may warn on this.


> BTW. `pcap_offline_filter()` is prototyped twice in pcap.h.

I removed the duplicate prototype in 7f93c753684d6fa42cbf3500adc8553765d2407f.


I have the same issue. Have you ever consider open a PR?


No conversion macro needed, input is const char* and output is std::string.


dig bick chocobos


This was an error in commit message. I actually removed burger menu class, etc.


The application wasn't being prestarted when Passenger Standalone was started with --ssl. It also wasn't being prestarted when Passenger Standalone was started with --engine=builtin. Both issues have been fixed.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 560](https://teamcity.labkey.org/viewLog.html?buildId=270851&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:23:05
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

##### there are 20 more failed tests, see build details
```


probably one file per test page, so rename 'spec.js' to 'simple-map.js' and then add 'basemap.js', etc.


@leoetlino the 'observe-sequence' package already has that dependency, so I guess we don't need that.
Even more, I think we can remove the `minimongo` dependency because that was in `observe-sequence` as well until the change..


Thanks @filkaris! Have a great night.


@igrunskiy TXReplicationEvent contains events originated from the same server. Always.


Thanks for noting that comments should be added properly. I would like to merge it,
but your solution is not quite correct as far as I can see.  A single quote is used for one line
comments and a multiline comment should start with /' and end with '/

Also, I think formatoptions should not be set here, but rather be up to the user.


Thanks to [Stack Overflow thread](https://stackoverflow.com/questions/18108591/expressjs-invalid-json-when-data-is-just-a-string/18108807#18108807)


Pass struct as argument added.


> Do you have access to Windows (or Wine)?

I have a Windows 7 VM, complete with command-line Git and VS 2013 (the joys of working on multi-platform software - over half my hard drive^W^Wflash storage is VMware Fusion VMs, and there's a bunch of less-frequently-used VMs on an external hard drive).  What's the best way to do command-line builds?  I'd prefer not to have to fire up VS in its full GUI glory, although if that's the only alternative....

BTW, [WinPcap](https://github.com/wireshark/winpcap) is moving to or has moved to MSBuild, which, I infer, supports both command-line and GUI building from the same project files (I guess that's like xcodebuild and the XCode GUI on OS X).


@igrunskiy those check only complicate the code. User is expected not to provide "rubbish".


@igrunskiy can be removed if ignoreTables/ignoreHosts act as "setters".


Is this change confirmed with sniffs? i'm wondering why we had wrong values here


@rhiannonlynne @stevechesley  @mjuric @ivezic
File n747/n474_dets.txt contains MOPS output of detections created for fields on night 747.


@igrunskiy I think you meant "Set"


Yeah, that makes sense! Thank you!


For reference: the assignment was to "overwrite the title of every fifth instance of Post with the text "CENSORED"."

Even though your implementation works, it introduces overhead. Each time a user will access /posts (a GET request handled by the `index` action above), all the posts will be looped over, which can quickly become a time-consuming operation; on top of that, most of the time, that looping will be unnecessary for the list of posts wouldn't have grow by 5, resulting in useless calls to `censor` on posts you've already taken care of.

A better strategy would be to apply the `censor` computation upon saving, in the `create` action. For a new post is going to be appended to the existing list, you could check what's the size of the list before appending the new one, and whether the new one is going to be closing a "fifth-in-a-row" sub-list:

``` ruby
# Let's count the number of existing posts, add one to account for the post to be saved soon,
# and check for the "modulo 5".
if (Post.count + 1) % 5 == 0
  # should call censor
end
```

That will take care of new posts. To make that retroactive, you could also [generate a migration](http://edgeguides.rubyonrails.org/active_record_migrations.html), which content would be similar:

``` sh
$ rails g migration CensorOldPosts
      invoke  active_record
      create    db/migrate/20150908220956_censor_old_posts.rb
```

``` ruby
# db/migrate/20150908220956_censor_old_posts.rb
class CensorOldPosts < ActiveRecord::Migration
  def up
    step = 5
    Post.all.drop(step - 1).each_slice(step).map(&:first).map(&:censor)
  end

  def down
    puts "Cannot undo censor"
  end
end
```

The `up` computation is a bit tough, but that's on purpose :)


for anyone who has the repo installed please delete your `node_modules` and also run `npm update`


that must have hurt typing this up


Thanks! Sorry took me a day to notice. This is more idiomatic that what I have in https://github.com/circuithub/elm-html-shorthand/blob/master/src/Html/Shorthand/Event.elm#L21 I think.


maybe add a note about updating test config as well?


We haven't validated $args[ 'id' ] yet


This code is buggy.
It checks for exact match with first page of pkmap / fixmap 2M range. So for faults of rest of 255 pages, it falls back to current pgd.


More than 1.4k effected, I cannot check them all.
Just an example: npc=233 has the flag on 6.x DB but not on 335.


You are not all done!! need to make sure that they are numbers!


I confess, I only did this one for completeness. Will revert.


l'interface n'est pas conviviale  ;-)

mais heureusement elle reste assez simple d'utilisation (enfin dans ce que je connais ^^)


hmmm, maybe it's better to remove `observe-sequence` and just use `mongo-id` and `diff-sequence`.
`minimongo` is important for other reasons