- http://flowplayer.blacktrash.org/fp6/dash.html#sintel (your first)

With proper MP4Box -profile option:
- http://flowplayer.blacktrash.org/fp6/dash.html#live-profile-enc (live profile)
- http://flowplayer.blacktrash.org/fp6/dash.html#on-demand-enc (on-demand profile - does not work in Safari - can maybe be fixed in dash.js)

This reminds me of HLS on Android: might vary from device to device and OS version to version, plus on some devices Flowplayer now pretends to be live ...


We should not be posting JSON objects, we should be setting the encoding and sending stringified JSON.  Whilst we do support JSON in the body, we only provide this as a fallback.


Хм... а зачем этот swithcher? Почему не две раздельные функции?


This commit broke the URL to gecko profiler add-on at https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Profiling_with_the_Built-in_Profiler . Is src/geckoprofiler.xpi still conceptually the same file after the move (i.e. the source of install), or is there something else to consider?


Каждый раз, когда ты просто в коде пишешь цифру или текстовую константу или переменную, тебя должно это настораживать, правильно ли ты делаешь.


Shouldn't the `List` function be rewritten, so that it actually works everytime, not just in this one place? Or, if you don't control `client` code, then create a wrapper around `Iterate` that returns all the stories.


I probably don't understand what `raw_data.encode('ascii')` does, but shouldn't this be a base64 encoding instead?


cool! :+1:


Makes sense...


`minetest-icon.svg` had to be renamed to `minetest.svg` in addition to changing `minetest.desktop`. That's why this commit broke Minetest's icon. I did some improvements on @sapier's commit and issued a pull request #3134 . The new changes makes Minetest's desktop and icon files follow [freedesktop icon naming specification][freedesktop], the standard for Linux desktop. This in turn adds icon theme compatibility to Minetest's desktop entry! :-)

  [freedesktop]: http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html#guidelines "Link to Freedesktop Icon Naming Specification"


@yx91490 That has the effect of your GOPATH being:

```
["/home/user/go/3rd", "/home/user/go", ""]
```

`""` is not an absolute path.


@godfreym, corrected here


Why is the static removed?


You should check that the encoding field is empty in these tests as well.  Also, we need to have failure tests i.e. using an encoding that is not supported.


i have see you push two commits whats the different


ok


@manstis Isn't this line duplication of code? Method loadContent() is called in class org.uberfire.ext.editor.commons.client.BaseEditor on line 149. In the same file on line 117 is called baseView.shoLoading(). And the baseView and view used in loadContent() are the same I think?

Or I have missed something?


Note that I have isolated the issue to the audio "AdaptationSet" of your MPD file. If I remove the audio from drive-on-demand.mpd, the playback works.

FYI, http://demos.flowplayer.org/videotest/canplay.html returns on my Android:

![image](https://cloud.githubusercontent.com/assets/1324566/9630277/77f33fb2-5179-11e5-87af-4867b327d236.png)

So I still feel this is not a codec issue for now, but I'll figure out.


@aericson you should be using a submodule here instead of duplicating the contents from https://github.com/ably/ably-common/tree/master/test-resources


Lets shelve this for now as we dont have a clear use case.


I'm on it. There's not so much to do !


Omg why keep a binary here?


isn't this bascially disabling the autocomplete function?


tą linikę zamienić na ```for (; i < A.length - 1;) {```
chodzi o to, że jak w tablicy A masz {-5,-4,-2,3,4,5} to powinnas szukać (i napisz to linike wczesniej) dopiero od dodatnich, więc przyda Ci się coś co idzie do dodatniego elementu, np tak
```int i = 0;
while(A[i]<=0) i++;```
to powinno ustawic na pierwsza niezerowa, a zaraz potem powinnas miec sprawdzenie czy pierwsza niezerowa liczba jest wieksza od 1, bo jesli jest to zwracamy 1


Had some cases where i needed to pass a method to a component. This method would run inside an angular that is (ofcourse) already inside an apply.


S3 better


where exactly?


Maybe I'm blind but `implemented := act != nil` would work as well.


This will lead to duplication of the module name for methods that are already fully namespaced.


Yea, should be "field".
On Sep 2, 2015 18:27, "Josh" <notifications@github.com> wrote:

> Is "firled" a typo?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/websanova/js-url/commit/559e98b9f4c5462b9b5a21fd66867b1c42a90d4b#commitcomment-13020566>
> .
>


i have find the diff  great work!!!!


I think I can't.


There's a typo: should be `${@ teaserModel}`


Why to use both fields?

Example:

```csharp
public StringValues(string value)
{
    _values = new[] { value };
}
```

I mean, if when we have only a value we store it in an array, the implementation could be simpler (I am talking about `StringValues` internal implementation, I am fine with the abstraction).


With --pregenerate_update flag, devserver fails to start with below error. Making legacy_image optional for GenerateUpdatePayload method.
```
~/trunk/src/scripts $ sudo start_devserver --pregenerate_update --image ../build/images/amd64-usr/developer-latest/coreos_developer_image.bin --port=8082
[02/Sep/2015:17:14:33] DEVSERVER Using cache directory /var/lib/devserver/static/cache
[02/Sep/2015:17:14:33] DEVSERVER Data dir is /usr/lib/devserver
[02/Sep/2015:17:14:33] DEVSERVER Source root is /usr
[02/Sep/2015:17:14:33] DEVSERVER Serving from /var/lib/devserver/static
[02/Sep/2015:17:14:33] UPDATE Pre-generating the update payload
Traceback (most recent call last):
  File "/usr/lib/devserver/devserver.py", line 709, in <module>
    main()
  File "/usr/lib/devserver/devserver.py", line 692, in main
    updater.PreGenerateUpdate()
  File "/usr/lib64/devserver/autoupdate.py", line 503, in PreGenerateUpdate
    self.static_dir)
TypeError: GenerateUpdatePayload() takes exactly 5 arguments (4 given)
```


Maybe Android in that case does not support HE AAC. As stated on the page the codecs parameter is _not_ indicative of whether playback actually works. The only situation where it matters I found so far is in generic HLS, where incompatible codecs are ignored.
There was a similar situation when Firefox introduced MP4 support: at first HE_AAC did not work (video only), and then, 2 or 3 versions later, it worked.

Can you test:
- http://demos.flowplayer.org/videotest/mp4.html
- http://demos.flowplayer.org/videotest/hls.html

(both use HE_AAC)


ok, hold on :-)


NAN is a GNU extension and not available on all machines or not enabled by default by all gcc versions. Adding -std=gnu99 in the Makefile CFLAGS solves the problem.


Você prefere manter os arquivos gerados no git? Eu acho confuso.


Could someone approve and merge it ?


I can confirm this is working for me in 1.3.1. It's possible that the logging is throwing you off. I have it spit out the parameters you pass in as console output _before_ doing the variable replacement. Is that what you are seeing?


DefinedMeasureComputer ?


done


For completeness there's now
http://flowplayer.dev/fp6/dash.html#bs-switching
full profile without `-bs-switching 'no'` which gives the same (dash.js bug?) error in Safari as http://flowplayer.blacktrash.org/fp6/dash.html#on-demand-enc even though for the latter the option _is_ set (https://github.com/Dash-Industry-Forum/dash.js/issues/734).


Looks like a formatting bug.


ok


@secretdataz Ah, yes, I've tried that before, and it didn't work. :(

I feel I may have done something wrong.

Check out my fork of the Jbeat repository, I made some changes to it that so it can allow me to patch the binary without using Files.


As `pprint-eval` is CIDER functionality, we should move this out of `nrepl-client` completely.


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


Build is broken again. Please submit the latest commits to fc.


yep


There are 4 options:
1. pcap is build WITHOUT REMOTING and user is using WinPcap WITHOUT remoting
There is no issue so far as pcap_stat does support REMOTING. And pcap_stat_ex returns size of the struct.

2. pcap is build WITH REMOTING and user is using WinPcap WITHOUT remoting
pcap_stat does not access REMOTING fields. pcap_stat_ex returns larger size than user requires. So far so good.

3. pcap is build WITHOUT REMOTING and user is using WinPcap WITH remoting
pcap_stat does not refer REMOTING fields. pcap_stat_ex returns size less than expected. User code should track this case.

3. pcap is build WITH REMOTING and user is using WinPcap WITH remoting
pcap_stat does not refer REMOTING fields. pcap_stat_ex returns structure with expected size.

So far so good while user checks size of the struct returned.


wait before merge plz, some doubts


> Secondly, what you're doing here is modifying the OP tree at run-time (some value of run-time anyway). That's safe on a perl without threads (like the one we use at work). But since OP tree structures are shared between threads, this can lead to nasty crashes on a threaded perl. I recommend not caring about it, but it's useful to be aware of the limitation. (There is NO safe way to manipulate OP trees on a threaded perl, alas.)

Actually, the only potentially unsafe optree operation performed here is restoring op_ppaddr; it might be unsafe because of 1) tearing, 2) potential concurrent modifications by another nasty module

I think 2) can be ignored/documented; 1) is trickier: it would (almost surely) be safe if the ops were allocated by malloc() [1], but I don't know which alignment is guaranteed by the op slab allocator

[1] not safe as per C standard, but safe in modern architectures


@blacktrash

 * http://demos.flowplayer.org/videotest/mp4.html => Playback works, with sound
 * http://demos.flowplayer.org/videotest/hls.html => Playback works, with sound


This is a bad solution. What about UTF-8 files without BOM? Default system encoding have nothing to do with encoding that we want to use.
I belive that better solution is to use something like this:
http://stackoverflow.com/questions/1025332/determine-a-strings-encoding-in-c-sharp/12853721#12853721


Nope why?


As I said, "Fixing it to handle remote capture is going to be a fair bit of work", and that's what's "[fixing] the code as it should be" means.  I'm trying to come up with some short-term changes that don't suck too badly (and that don't introduce ugliness that can't be removed, as doing so would *definitely* suck too badly) for now; removing the code seems to be the "least sucky" short-term solution.


:heart:


Was heißt `ksdflsdkflöskfsd`?


Почему только российские номера?
имхо взятый с [хаба](http://habrahabr.ru/post/110731/) вариант не годится для использования по всему миру


@ipernet - so it seems like HE_AAC is only _not_ supported in MPEG-DASH on Android (or your device).


If $course_id is provided, then $_course should depend on $course_id, not on the current environment!


Yeah, maybe I will fix it in the lib itself... Then I can remove this change :D


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.550](http://teamcity.monogame.net/viewLog.html?buildId=9937&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.549](http://teamcity.monogame.net/viewLog.html?buildId=9933&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests passed: 538, ignored: 6; exit code 1 (new) Build time: 00:26:21


I've reported the user as a spammer, hope he is banned from Github


@mfonville,  I got an unseen (by me) warning message from git when committing chrome:

```
Do you want to commit these changes as Chrome arm 21 45.0.2454.84 (nodpi)? [y/N]
y
Committed app/com.android.chrome/21/nodpi/245408401.apk
Nicholas Buse (1):
Chrome arm 21 45.0.2454.84 (nodpi)
Do you want to push these commits to the arm repository? [y/N]
y
Counting objects: 30, done.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (7/7), 28.98 MiB | 1.36 MiB/s, done.
Total 7 (delta 2), reused 0 (delta 0)
remote: warning: GH001: Large files detected.
remote: warning: See http://git.io/iEPt8g for more information.
remote: warning: File app/com.android.chrome/21/nodpi/245408401.apk is 52.26 MB; this is larger than GitHub's recommended maximum file size of 50.00 MB
To git@github.com:opengapps/arm.git
```

I'm sure it is fine, I probably just have not committed a file >50MB before...


Besser

    unless currentRank

oder

    if not currentRank


thanks!


If you're updating the function anyway, it would be nice to add an optional $courseId=null parameter so get tabs can be requested for another course than the current one (for additional processing by other functions)


well, that's kind of the point. there's a max number of warnings that we treat as a fatal threshold. in ui-build, we tolerated WAY too many warnings and as a result we have projects like web-search with 150 some-odd warnings and the code looks like crap :)

swig-lint has been this way for some time. let's triage the real problem, rather than turning off a useful feature.

:-1: on this one I'm afraid


This shows up a lot during the runtime tests on Linux now for me (which afaik should default to coop disabled, right?)


It's always nice to provide a `@deprecated <explanation>` in the javadoc as well.


Einrückung


Same thing here, but with $userId=null


Ok, great!

As I don't have access to the feed, I have no idea what the input is. Probably you can put a description of the source in the docstring, like I did here: https://github.com/certtools/intelmq/blob/master/intelmq/bots/parsers/spamhaus/parser_cert.py
The descriptions of currently existing bots are not descriptive and the input format is nearly never described. This should be gradually improved and takes some time.


Hier fehlt ein Leerzeichen. ;)


If both the cert and the key specify a file they should both state this in their description. It's fine to not have it in the names since these should be short and easy to type, e.g.:

```python
    option_list = [("port", "listening port to connect to", '', ""),
                   ("ssl-certificate", "Path to file containing client SSL certificate",
                    '', ""),
                   ("ssl-key", "Path to file containing client SSL private key",
                    '', ""),
                   ("ssl", "enforce SSL / amqps connection", '', False)]
```


Fixed


@mbellotti I am not sure the change {% set step = data.data.current_step %} -> {% set step = data.current_step %} is good. I know it might be a bit confusing as it is not the same as code above this change, but the information is kept in different way. I am not sure why you changed that part as it is from onboarding.


Would be nice to define $userId=null as optional param and base $_user on this


Yes, it seems so!


@ErikZigo jeste bych pridal test na prenastaveni PK. Tzn. nejaky je nastaveny a ja ho chci nastavit na jiny


Du hast natürlich Recht, aber der Name ist bereits vergeben worden, als die Meldung nur für wolfhowl benutzt wurde, und ich wollte da nicht unnötig Namen ändern. Mich hat neulich schon dir cerrdor->cerddor Umbenennugn unnötig gebissen, ohne das ich das vorhergesehen hatte.


Posting a link to a small example application that fails in the way you describe - that could get this issue some attention from mspsim developers.


$_course MUST be generated from the $course_id param if defined.


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 45](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191250&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 45](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191250&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:02


Autodesk_Performance (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (760 of 760 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-9.38%25-green.svg)


rename to hasInvalidFormAction


What's wrong
?


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 46](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191252&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 46](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191252&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:01


maybe you find a better name for this :) What's a firstExclusion?


Shouldn't this be in its own section that's guarded with something like ``#elif defined(__GNUC__)``?


I wonder if we should store the base64 encoded image into the Assets table instead of the question itself and reference it directly (no more base64). This is going to make future debugging much easier


Thank you ! It helped me debugging an issue I had with Transit.
I actually had to cancel the propagation so the children can't bother the parents :-)
        if (bound) {
          if (event) { event.stopPropagation(); }
          self.unbind(transitionEnd, cb);
        }

Can be useful


<img src="https://github.trello.services/images/trello-icon.png" width="12" height="12"> [Github](https://trello.com/c/VdBVm3yu/47-github)


@ElectricMaxxx This introduces a bug I tried to fix in #259.


códigoa actualizado


ouch formatting, will update sec


i've had tacos on the moon and find then far superior to earth tacos.


> organization


> Organization


do we need allForms?


Any benefits of using an ArrayList over LinkedHashSet which would not require the contains check?


that's not real english :) choose better name. Also, it's not clear what this method does by reading its name


same here


Why, what happened? Should not this translation be in another file like README-DE.txt or something like that?


Hey etx thanks for your work on adding read functionality to cordovarduino. I'm having problems with this and wonder if you have any ideas. Details here: https://github.com/xseignard/cordovarduino/issues/35 any help really appreciated as been stuck on this for a few weeks now. I've tried removing cordovarduino to check the UI code and it works ok. Thanks in advance!


yes it's an error. Has been reverted :)


Oh, sorry. Thanks digital.


clang 3.7 was released today. Do you really need to depend on a specific version?


Ah, missed that.


This appears to be working! Thanks for your responsiveness!


So the plugin change I reported can't be correct because we were not using the same streams. I feel you should revert any specific android change if any and use an "as much as compatible" dash stream on the official page (Desktop/IOS/Android). Sorry for that!


better name: "makesOtherSnippetsRedundant"


Why do you need this? Since it's set in all matrix entries, these should have preference.


wait, this method doesn't really disable any other methods, it only checks if the answer is Y? Then the name is completely wrong ^^


ping @thundercw, ping https://github.com/cockroachdb/cockroach/issues/2298


>Is it possible for last_sample.get to return anything other than a Gst.Sample or an Exception-like object?

It shouldn't
I guess it's for symmetry's sake, but as you say the return statement below does already assume that it's a `Gst.Sample`.  Maybe I'll make it like this:

        if isinstance(gst_sample, Exception):
            raise UITestError(str(gst_sample))
        elif isinstance(gst_sample, Gst.Sample):
            self.last_got_sample = gst_sample
            return gst_sample
        else:
            raise RuntimeError(
                "This should never happen: Pulled a %s from the queue but was "
                "expecting either a Gst.Sample or an Exception")

Or maybe I won't bother

I suppose the pattern matching schemes you see in more functional languages appeals to me because the symmetry makes it easier to inspect and see if you've missed a case.


Updated above.


Ah, didn't notice it was a book too. Nice. And what I meant to say was "but not too much to **not** be original." (i.e. it's fine). Maybe you could somehow use the logo as a spinny loading indicator? Not sure how well i'd work though.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.550](http://teamcity.monogame.net/viewLog.html?buildId=9937&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests passed: 538, ignored: 6; exit code 1 (new) Build time: 00:15:59


Looks like a good plan.  :) Awesome.


Is this so that you have an empty hash if nothing is already there? You can set a default in the constructor... e.g
```
Hash.new({})
```


I didn't refactor anything but needed to do something since this caused tests to fail. I'll try not to get in your way any further for refactoring this.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.551](http://teamcity.monogame.net/viewLog.html?buildId=9941&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Win10) Build time: 00:00:20


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.552](http://teamcity.monogame.net/viewLog.html?buildId=9945&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Win10) Build time: 00:00:07


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.553](http://teamcity.monogame.net/viewLog.html?buildId=9949&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Win10) Build time: 00:00:20


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.554](http://teamcity.monogame.net/viewLog.html?buildId=9953&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I prefer to think he was testing GitHub Markdown rather than being a spammer.
I see on with his [feed](https://github.com/magidkabir?tab=activity) he were doing a git tutorial and he has removed some comments but others remains untouched. Let's hope he wont disturb us.

No one mess with @voiser no one!
![http://i.giphy.com/9qMIBqOJrtvfW.gif](http://i.giphy.com/9qMIBqOJrtvfW.gif)


after reading the method, that's wrong too. I'd rename it to "answerIsYes". Also, again, can you create a method that returns Some(yes) for YES-YES, Some(No) for YES-NO and NO-[NO] and then reuse this method for such causes?
(Please reply to this comment)


Yeah I know. Their absolute maximum is 100MiB, so we are still fine. And I'd rather not use their 'large file storage'-solution, since it would complicate things. And I am sure Google APKs will not get above 100MiB soon, since the Play Store itself also has limitations on APK size.


Consistency is key. `last_privacy_updater` should be `last-privacy-update`. Fix!


oh yeah :+1:


I think we should use RHEL instead of Redhat since we are using SLES instead of Suse.


can it ever happen that there is no 4th string after "/"? Because the whole application would crash if that was the case for 1 element


Can we change this to

"The support statements refers to hardware control, operating system (os) provisioning, and general purpose system management where we do not see any obvious problems with the indicated combination"


Oh, I was wrong. When you submitted new commit to fc, please remember to update graphene as well to refer to correct commit of fc.


Actually... 3.7 and 3.8 SVN work and I'd prefer to use them, but I have not yet found a way to use them in their Ubuntu Precise machines. 3.6 is the latest then, so I prefer to use it because latest versions include newer warnings. Without C++14 enabled the code works down to 3.4 though.


you've reverted that to process.portal I reckon :)


I still don't know whether we should write this.....  Unless we indicate the combinations that will definitely work and has been tested by development/testing teams.


Fix the class name here also


ok este to skusim takto otestovat a uvidime .
ja som len stiahol ten zip subor
pod linuxom som v adresare kde som rozbalil zip spustil prikaz make.
vysledok bol fastshare.host a ten som cez menu synology naimportoval do download station.
V nastaveniach som zadal meno a heslo a ked som rucne vlozil link.
Par sekund to nieco robilo a výsledok error ako som posielal na screenoch

> ** Wed, 02 Sep 2015 01:40:28 -0700 - "feixm1/fastshare.host" <reply@reply.github.com>, "feixm1/fastshare.host" <fastshare.host@noreply.github.com> **
>
> Abych uvedl věci na pravou míru - já sám to nemám kde vyzkoušet. Synology nemám. Plugin pro Fastshare jsem dělal pro kamaráda, který Synology má a poprosil mě, zda bych mu plugin nevytvořil. Od něj mám potvrzeno, že mu plugin funguje. Pokud to nejede, potřeboval bych získat z nějakých logu Synology více informací, než jen "error".
>
> Plugin je udělaný tak, že by měl jít otestovat i ručně, z linuxové konzole. Stačí otevřít v textovém editoru soubor `host.php` a v něm asi dva řádky od konce doplnit libovolný funkční odkaz na fastsharu, své uživatelské jméno a heslo. Pak na konzoli zadat příkaz `make test`.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/feixm1/fastshare.host/commit/a2f38f103bf5d0e2c84253c471c3b32bd86a5c2a#commitcomment-13017744


@justiniac 1.2 is getting pretty old but 1.7 may be too new. Enlive doesn't use any modern feature and the stated Clojure deps was meant more as a "minimal system requirement" than anything else (since the user clojure version takes precedence). So two things: bumping to 1.6 ok and maybe adding a comment to the README or to the project itself to state that teh clojure dep is just a minimum version.


`fixme` should be `fix-me`


Or...
```
Hash[attrs]
```


Sadly there is always an extra "default" entry added regardless of the `matrix: include`. I plan to use this later for generating documentation, coverage and other single-run maintenance triggers. For now it's just a normal run with some default options.


Do you really need to build llvm from source? Are there no prebuilt packages you can use?


Good point, thanks!


Bzdurki.


hmmm tak to sa mas ... mne to chvilu nieco robi a potom to vypise error ...

> ** Wed, 02 Sep 2015 02:23:19 -0700 - "feixm1/fastshare.host" <reply@reply.github.com>, "feixm1/fastshare.host" <fastshare.host@noreply.github.com> **
>
> Tak vytvoreny host funguje, po vzoleni do DS a vyplneni prihlasovacich udajov mi v pohode stahuje...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/feixm1/fastshare.host/commit/a2f38f103bf5d0e2c84253c471c3b32bd86a5c2a#commitcomment-13018411


Suggest:

"For diskless mixed cluster support, the initial diskless image must be created on a node running the target operating system version and architecture.   See :ref:...  "


We don't need this key.... defender actually uses the default User model that is set in `config/auth.php` file

https://github.com/laravel/laravel/blob/master/config/auth.php#L31


thanks, this solve the issue on iOS<8.4... can you please issue a pull request to original plugin ?


`bet_radar_sport_id` ? Might be easier to read....


Why is there an empty class here?


Bravo, @meh! :clap:


I like this comments :blush:


Why do you have an empty class and style here?


Replace all occurrences of `fixme` with `fix-me`


Thank you for giving valuable comments on it.

I'll look into them and come up with an updated version later.

> Should I do that and at the same time try to understand this code?

I appreciate it if you would do so.  That's very helpful to me, too.  Thanks.


I believe you might be able to ``cmake --build . --target cxx cxxabi install``. In any case, shouldn't the build output go to ``/usr/local`` instead of ``/usr``?


pewpew


ilgfhdisgf


@jomarko Looks like your analysis is correct. Did you want to submit a PR removing this duplication?


It doesn't strictly matter here, but the preferred idiom is:
```
t1['a'] = Column([1, 2, 3], unit="s")
```


According to this [bugzilla report](https://bugzilla.redhat.com/show_bug.cgi?id=213716), arping had ipoib support since 2007 (at least on RedHat). I don't know if it is upstream. Why not just run it and ignore errors if they occur? What kind of problems did it cause?


Well, it's a **C99** addition, as is `isnan()` which is used in a few places.  There's C99 all over this code… are you compiling with a C90 compiler and having a problem with `NAN` but not with other C99 code in bcftools?

In any case, this is the only instance of `NAN` in particular, and this code can easily be recoded to avoid it.


Sadly not for the standard library. Fortunately this is a thin module that takes little to build. Boost.Hana uses a similar approach: https://github.com/ldionne/hana/blob/master/.travis.yml
On the other hand, we could consider using Mac drones for Clang in the future if this becomes a significant problem, but for now having all tests in a single platform still outweights the costs IMHO.


Let there be a space just before the opening curly brace


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 47](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191265&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 47](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191265&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:05


Why do we have an empty class here?


Because the exact name is given, but not the sub string. Well, we might check autocomplete also elsewhere, but why this change?


@ipernet - quite to the contrary: the change finally told me, as a side effect, how to get rid of the cludgy seeking in paused state workarounds when autoplay is set.
As for "official" streams: there are so many which have other problems, about half of those on dash.js don't work in their own implementation, nevermind in google's dash player, and vice versa. So I'd like to find out what works in most circumstances.

In that sense, for cross-checking, here's a full profile dash with AAC_LC profile: http://flowplayer.blacktrash.org/fp6/dash.html#aac-lc


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 48](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191277&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 48](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191277&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:01


Add tests of `meta`, `description`, `format` column attributes for completeness.


A later commit changes the code to not install it, so we can avoid `sudo` and use the docker-based Travis infrastructure: https://github.com/AbletonAG/atria/commit/b72bdc14a67809301bce4bbe72446ff110a1d996
The problem with running `install` is that it depends on all `llvm`, triggering a too long build


Great stuff


Thanks. Btw, it looks like the latest version of the oauth client uses Guzzle 6, which is using PSR-7 and isn't currently EOL.

@sherryl4george: Can you take a stab at upping this dependency?

https://github.com/thephpleague/oauth2-client/blob/32e0fec0b792ac880097116619b22f2930544432/composer.json#L9


Sounds plausible, but I'm not sure what - could you try and see if a `bundle install` fixes it (presuming that your branch is based off `develop`)?


You should remove `(copied TOS)`


thug life \:D/


I think you can move the tests here into the previous test and just check all table and column attributes in one test function.


Yeah I wanted to ask @aalecs about this one actually. I changed it because a nosetest in hdx_org_group kept failing with the error "string has no attribute 'current_step'" (or something to that effect). If nosetests are passing for everyone else I can revert the change.


Look over your stylesheet and if you aren't using any of the styles, you will need to remove them like `tos-wrapper`


correct, I want paket.lock in source tree


Yes, I will do, because I have currently PR with test, which have revealed it. I will include fix to this PR [1]

[1]
https://github.com/droolsjbpm/kie-wb-common/pull/74


![Thug Life](http://i.imgur.com/Qo8xs7Wl.jpg)


How is this supposed to work exactly? `tls.connect(options)` when `options` are undefined?


@jbo-ableton: if the `#else` section is empty, then you can remove the `#else`. Or there should be default `ABL_DISABLE_WARNINGS` and `ABL_RESTORE_WARNINGS`.


This commit is being reviewed as a part of review issue #61.


To follow convention, `documentDescription` class should be `document-description`. I believe we only use camel-casing in JavaScript code.


@wimnat Is this line leftover debugging code? This currently causes the following for me:
```
TASK [aws-vpc : configure public route table] **********************************
An exception occurred during task execution. To see the full traceback, use -vvv
. The error was: AttributeError: 'NoneType' object has no attribute 'keys'
fatal: [aws-vpc-hbi16058]: FAILED! => {"changed": false, "failed": true, "parsed": false}
```


This commit is being reviewed as a part of review issue #62.


I double checked in code, and we should not change it as onboarding will not work anymore. We need to adapt or change the nosetest.


will do


Note that the plugin actually checks for AAC_HE support: https://github.com/flowplayer/flowplayer-mpegdash/blob/master/flowplayer.mpegdash.js#L24 - but, as I said, unfortunately that is rather meaningless most of the time.


Okay will revert


The statement is fine, you can just put it on multiple lines:

```python
vars = card_class, rarity, card_set, craft_cost, de_cost, gold_craft_cost, gold_de_cost, pk
connection.execute("""UPDATE dbf_card SET
    class_id = ?,
    rarity = ?,
    card_set = ?,
    ...
 WHERE id = ?""", vars)


You should be able to use the `load_file_fixture` method here.


hm `regform` looks better.. mostly a matter of taste though


That's irrelevant now; PHPMailer no longer has a direct guzzle dependency.


`set -e` ?


looks like there is a side effect of theses changes on iOS < 8.4 + landscape ... splashscreen si rotated and the app too... this fork fixes it : https://github.com/EducationPerfect/cordova-plugin-splashscreen/commit/49bee9f86623361ef84415025ea08ea38835f387


Not really sure what went wrong, the jenkins job had run but it failed and I couldn't see any error message. Anyway, just re-ran it and it seemed to work.


`RegistrationFormForm`? the same form will be used to edit it so "Create" doesn't fit well in there


:monkey:


:+1:  :)


@cehallen DWMR. Good work here. Thank you.


at this point, I'll do it on after local merge, next you can test directly InstanceBuilder in InstanceBuilderTests or Parser in ParserTests

why put this test in ParserResultExtensionsTests? as name said is for ext. methods of ParserResult

anyway thanks for catching the bug! :)


Maybe a comment would be welcome? an `.ico` file in the sources looks a little odd... also, maybe it would fit better in EXTRA_DIST of the main Makefile.am?


Long lines aren't great. Using the gorm struct syntax would probably help.


Same here


Make this a fallthrough to default.


Just saw that it moved to "suggest"... thanks :+1:


i think you forgot the switch field to enable/disable the limit


@wimnat Looks like in `ensure_route_table_present()`, `vpc_conn` was renamed to `connection`, but it didn't get renamed in this line.


The entire switch statement duplicates code so much. You should just have a value map and not switch at all.


check edit_survey.html (you can reuse the same template for create/edit)


> Organiazation


This commit is being reviewed as a part of review issue #61.


:+1: thanks a lot.


This namespace shouldn't be in the div. The div is empty, so do we really need it there at all?


We can't use `ifname` as a key, since there can be thousands of different names.  I think we need something like:

    if ifproto no in d:
        d[ifproto] = []
    d[ifproto].append({ "ifname": ifname, "ipaddr": ifip })

Which results in two known key names, `ifname` and `ipaddr`, so that we don't get a different field name for each possible `ifname` encountered on a system.


Ignore blank lines in comments.


@mbernat The actual fix can be found here: https://github.com/salsita/go-pivotaltracker/commit/7799627c23148442ef4715e86bc8c86fb79b411b


> Organization


Thanks for pointing that out! Addressed in 67ecebbe9fb07e550557e23bf13dbae983291a58


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 49](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191290&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 49](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191290&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:02


This div is empty. What is it used for?


We should be able to get al list of all formats we support from the SCIFIOGateway. Would that help?


I am on the latest version on git master and my `emacs-major-version` value is **25** and `emacs-minor-version` value is still **0** and I have the `save-mark-and-excursion` macro defined in `simple.el`. The docstring says "25.1" because this version will be released as "25.1" when released as a stable release.

With this commit, the `expand-region` package will end up redefining `save-mark-and-excursion` macro for all emacs versions out there, stable + git master.


That's what I thought initially, but I think it does make sense to give the displayed contests some kind of order (this order is preserved in the map and therefore in the selection box that's displayed) and the primary key actually acts as an indexed surrogate for the creation date in this case.


heh. you can probably use `sys.argv[0]` instead of `script.py`. The file isn't named `script.py`, is it? ;-)


exit code 0 is commonly understood as success. Use something non-zero. Like "1".


I commented on this in your previous commit, but I see you caught it. Nice work.


Thinking about this, it should actually be a dependency in `src/Makefile.am` so the executable is rebuilt if it changes.  Let me see if I can figure out how to do that.


Run 'sudo python manage.py collectstatic' in my_geonode first to sync static js script.


beru zpet, nechame to takhle


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 50](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191297&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 50](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191297&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **SUCCESS**
Summary: Running Build time: 00:00:02


https://github.com/ujhs7380/Project_JJK/commit/4db4b5e8fc03551d539e6922b7048ea91e60aefb
이렇게 속성(Property)로 접근하는게 좋을것 같아.


It's just a coincidence, there two things are not really related.


@hbun DWMR of assignment and checkpoints - both are concise and well done. good work - thank you.


Glad it turned out to be understandable :)


Neat!


private 이니까 _conn 으로!


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.555](http://teamcity.monogame.net/viewLog.html?buildId=9957&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.554](http://teamcity.monogame.net/viewLog.html?buildId=9953&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:32:30


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 51](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191301&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 51](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191301&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:02


var connBuilder = new MySqlConnectionStringBuilder();
'var' 를 사용합시다.


Почему +7 и почему +8?


Thanks man! :smile:


INFINITY is C99 but NAN is a GNU extension: http://www.gnu.org/software/libc/manual/html_node/Infinity-and-NaN.html
I'm having this issue on the relatively old CentOS 5.11, compiling with gcc 4.8.2. A quick google search shows this is not an isolated issue: https://github.com/bsdphk/Ntimed/issues/1


띄어쓰기는 필수!
int a = 0; (O)
int a=0; (X)


@manstis reviev #74 please.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1286 of 1286 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I think you could put it in the same place as `../windows/gregorio-resources.rc` ? By the way, I think `gregorio-reources.rc` should also be in the tarball, I don't really understand why it worked without it for Akira...


@wimnat Not sure why this was changed. `ensure_propagation()` needs the whole `route_table`, not just its `_id`. This change breaks `ensure_propagation()`.


It *is* in the tarball.


GOOD!!!
Parameter 쓴건 아주 좋았음!


New version: this particular line is removed but in the existing code I hesitate that we change it and make the extension depend on 7.1M1


Tested with .net 4.0 and 4.5. Needs further testing in .net 3.5, 3, and 2.


тебе не нужен последний else.
Пожалуйста форматируй код. (поищи hot keys для форматирования)

Думаю, что  лучше кинуть IllegalArgumentException


comma (,) 뒤엔 항상 띄어쓰기 한개!
id 앞에 띄어쓰기 넣어줘.
"INSERT ...", id, name); (O)
"INSERT ...",id, name); (X)


hum, that is not related at all with #402. And this break compatibility for people who add \par inside \Xfootnote and does not use the parapparatus option. I am hesitating.


As this is not the autocomplete test I want to avoid running into javascript problems. And autocomplete autocompletes no matter if you give it the full string or sub-string :-)


쓰지도 않는 i 왜 있지?
안쓰는건 커밋하기 전에 지워주세염.
그리고.. 음 아래에 적겠음.


@blacktrash http://flowplayer.blacktrash.org/fp6/dash.html#aac-lc works well!

I'll open a bug on Chromium/Chrome bug tracker and see!


Okay, I've tidied it all up, finished it off, and created a PR: https://github.com/dbsrgits/sql-translator/pull/68

If you'd rather the ```size``` parameter changed to something else then just let me know.

Thanks, Andy


This looks like preparing lot of configuration. Can this be renamed to ZuoraConfig?


Плохая идея передавать обрабатываемые переменные через внутренности класса.
Так можно делать, но если есть возможность избежать и передать через параметр метода - лучше так и сделать.
Почему? - Так лучше понятно от куда появляется параметр и где он меняется и что на него влияет.
А так же уменьшает количество проблем при многопоточности.


[아래에 적겠음] 의 이야기
i를 while loop 안에 선언 했는데, i++이 있으면 아무 의미가 없지.
다시 loop 돌 때 i는 사라졌다가 다시 선언될테니까.
0 이 되겠지.


Missing licensing on these files; merging.


`replaceWith()` is private, so I cannot directly test it.


(504f92d) The title of the commit doesn't respect guideline ("type(scope): title (refs #<number>[, ...])")


Values<blah>


선언과 초기화는 같이합시다.
string row = Reader.GetValue(0).ToString();
이렇게 합시다.


Oh, sorry.


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 52](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191308&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 52](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191308&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:01


disorder: 24,30,26


1579840-GroundTemps (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1802 of 1824 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.79%25-yellow.svg)


Just because the GNU libc manual says something, doesn't mean it's true :smile:; trumped by C99 §7.12/5.  Anyway, it can be avoided.  I trust your elderly CentOS machine doesn't complain about `isnan()`?


What is the easiest way to set up something so that I can test cross-compilation to Windows?  Since these sections are macro-ed away, I really have no idea if what I'm doing for the dependency is actually correct.


_paq.push(['setSiteId', 1]);
_paq.push(['setSiteId', <?php echo $piwik_id; ?>]);

var u=(("https:" == document.location.protocol) ? "https" : "http") + "<?php echo $piwik_url ?>/";
var u=(("https:" == document.location.protocol) ? "https://" : "http://") + "<?php echo $piwik_url ?>/";


Use `described_class` instead of `Api::ApiController`


I think for loops over gui.windows should be avoided; this lacks encapsulation.


Separate every 3 digits in the integer portion of a number with underscores(_).


The first argument to describe should be the class or module being tested.


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 53](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191316&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 53](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191316&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:01


The `act` actions are for "Mark story as implemented". Please explain to me again how it's unrelated?


slet variabel


Should have done this on dev. mob_grab.dm was one big merge conflict and I can only hope I successfully sorted it out.


This reads a bit strangely. Should it say "thus, the base href attribute isn't affected by *other* base elements" or something?


ta ty viesssss


so no more Preconditions?


ok


이건 우리 프로젝트에서도 마찬가지지만..
멤버 변수로 string _connectionString 말고,
MySqlConnectionStringBuilder 가 있었으면 좋겠어.
그래야 뭔가 코드 상에서 connection string 을 바꿀 수 있잖아.
당장 필요하진 않지만 코드의 유연성을 위해서!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/19999/testReport/) for this commit**


This can go in `consul.json`. That would keep all of the configuration variable in a single location.


Тут тоже pivot_list_t.


Ehh, not too worried about a loading indicator. That can wait for now. When I get a bunch of free time, (probably not for a few months yet, due to moving) I'll refresh and re-do most of the UI and extension systems. (Likely will base it on muon.)


no


I just hope this "ideally" really holds in current nixpkgs :-)


Will this change on other enviroments? staging or production?


also, the display in the status bar is broken


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.946.7b1e6b71e7e48ce82f90264d84609a168c3e384c](http://build.palaso.org/viewLog.html?buildId=62526&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:04:18


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20000/testReport/) for this commit**


함수는 대문자로 시작하고, 단어 연결도 대문자로! (파스칼 케이스 라고 부름)
AddTable 이렇게 해줘요.


역시 파스칼 케이스로.
InsertData


It would be good to know why this never came back?


comma(,) 뒤엔 공백 추가
(int id, string name)


изменен тип приема галса, переделан вид судна


Looks like Ubuntu may be the easiest way to go.  I'll set up a VM to try this out.


good point. That'd actually make it a lot easier for the script to parse, as well.


that line has been lost:
 -        self.win.history_list.setColumnWidth(6, 120)


dashes please :)


The problem is `findAndReplace()` is private and there're no reasonable usecases where a replacement string would contain a `{something}` pattern.


These were changed Iterator.range in further commit down the PR


Indeed... Yes, `isnan()` is defined on my CentOS 5.11 machine.


In my tests it is … my changes make an error occur. But if this will break compatibility leave it as is. But you may add the notes to the manual …


by _sub_ I meant _dub_... :angry:


do we want to enable it by default for meetings or lectures? i guess most don't even use the participants system?


Autodesk_Performance (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1288 of 1288 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.01%25-green.svg)


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 54](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191322&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 54](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191322&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Will fail Build time: 00:00:05


Actually, Bash's configure script calls /bin/sh. But this miraculously still works because /bin/sh is a bind mount of the bash executable rather than of the symlink to the executable.


What is the speedup of this complication here? Is this really needed? What proportion of time do both variants of encoding detection take in loading the file?


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 55](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191324&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 55](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191324&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Will fail Build time: 00:00:03


I don't know Gentoo enough to advise you something... under Debian it's as easy as under Ubuntu (apt install mingw32)`


new line?


Reference above is wring, it had to refer to #74


@mkoryak could you publish new version to npm ASAP please? thx!


DB 작업할 땐 DB 작업만 했으면 좋겠어.
Console.WriteLine("success for create + {0}", tablename);
이거는 로그 남기는거니까.. 그럴수도 있겠는데,
아래 Console.* 두 줄은
AddTable 호출 한 부분에서 하는게 좋을것 같아.
다른 사람이 AddTable을 사용할 수도 있으니까.


oh wait, it was correct.... Oh, what am I doing?


띄어쓰기도 신경씁시다.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20001/testReport/) for this commit**


Plugin error
Traceback (most recent call last):
  File "/home/voegtlin/electrum/lib/plugins.py", line 118, in _run_hook
    r = f(*args)
  File "/home/voegtlin/electrum/plugins/exchange_rate.py", line 317, in history_tab_update
    tx_list = wallet.fx_tx_list
AttributeError: 'OldWallet' object has no attribute 'fx_tx_list'


Reference is wrong. It had to be #74


아래 부분에서 탭, 공백 이 섞여 있는거 같은데..
이런건 잘 맞췄으면 좋겠어.
다른 사람이 코드 읽을 때 힘드니까..


@ipernet - good, thank you.
I'll add a note to the demo (builder is still broken), the reason for suggestion to prefer generic HLS if available changes from Safari (the timeline issue is about to be fixed in dash.js) to Android AAC_HE.

Main thing: imho the plugin has improved as a side-effect. Thanks for your patience!


Add the `//NOTE:` prefix


불필요한 공백은 지웁시다.


let suppose you have written

\Afootnote{toto \par titi} in a previous, but didn't use parapparatus option. You will have error, that you haven't in the past.

We can break compatibility, but only when it is very need. Is it in this case? I don't think.


`act` is for rolling back changes. True, it will be `!= nil` iff `implemented` is true. But I don't see how using this kind of correlation is not utterly horrible. Functions can return an action and it doesn't say in general anything about other return values. And imagine `implementedDialog` changes in the future and the correlation is gone. It will be very easy to forget to modify `implemented := act != nil`.


what about the footnote in https://github.com/tweh/ledmac/blob/f74ca9a2f30031f0f412bf6253c0330346e21b2f/reledmac.dtx#L1537 ?


No it isn't … I guess a comment in the manual would  suffice :-)


Maybe the whole `/bin/sh` thing should be done in a different way, e.g. a plain symlink to `stdenv.shell` or something...


I would encourage you to make changes to pkp-lib if you think they are needed.  If the complexities of git submodules are a blocker, we can help navigate.

On the other hand, would a simple and best-case solution be adding a "password reset" date to the user in the database so a full expiration check can be done?  I do think your critique of non-expiring reset hashes is valuable.


1706-ThermostatDualSP (kbenne) - Win64-Windows-7-VisualStudio-12: OK (2303 of 2343 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.29%25-yellow.svg)


in case of error rebalancing flag will be true.


this is sexy af


1: M111 unrecognized component name: plotextractor


//creating table 처럼 구역에 설명을 쓸때는
#region
#endregion 을 쓰는게 좋아.

#region creating table
Console.Write("Please enter tablename to create table,excepting table list :");
string tablename = Console.ReadLine();
Console.WriteLine(tablename);
DB.Addtable(tablename);
#endregion

이렇게 쓰고 숨기는거지. (visual studio 텍스트 에디터 왼쪽에 - 버튼이 생길거야)
취향에 따라서 #region #endregion 사이에 공백을 한줄씩 넣어도 좋은것 같아.

#region creating table

Console.Write("Please enter tablename to create table,excepting table list :");
string tablename = Console.ReadLine();
Console.WriteLine(tablename);
DB.Addtable(tablename);

#endregion

이렇게


Now this error means that both `path` and `winOpenCmdTemplate` params are not set. Please discuss with a tech writer maybe we should correct this error


Damn I was too quick :smile:


Let's keep the test file names and groups matching the files it is testing (so this test should be in test_connection_edge.c)


This seems excessively strict, no?


Weird indent here.


Blame VIM?


@ryantrinkle
hmmm after coding this up i realized we already had the module:
https://github.com/diagrams/diagrams-svg/blob/master/src/Diagrams/Backend/SVG/Attributes.hs
perhaps then I don't need the above changes? Honestly I forgot why we need some of them.


local 변수는 소문자로 시작합시다.
int number (O)
int Number (X)


Which comment ? could you revert this commit and write the comment ?


Maybe `getWinOpenCommand`? We everywhere here use this abbreviation


단어 연결은 대문자로!
string idValue (O)
string idvalue (X)


Should we do the check for conference/meeting/lecture here to define if it's enabled?


it's the default value that's used if no event features have been changed yet

so you could `return event.getType() == 'conference'` here


Ele falou cocótinha poh...


Good catch


Uhm. Ugh. I don't think this is a good way to do it. =/


Ahh … I remembered that i read it but could find it when searching. Thats why I added my text. And I’d say that having a note in the main text is better since a footnote is likely to be over read

So I suggest: Keep my text and move your footnote to the end of l. 1548 … but it’s sour decision.


sorry for the premature code review :)...

https://godoc.org/golang.org/x/tools/cmd/goimports

if you hook the above tool into whatever editor you're using it will automatically format your code using standard golang rules. it will also auto add imports, and auto remove them.

i like to just hook it into the file save, so imports automatically get added/removed and the layout gets adjusted with each save. Really helpful to promote consistent practices across the team.


How to used it!


I do not see explanation of "or next block" , true to say I do not understand that


Why `getWinOpenCommand` and 'getMacOpenCommand' are async?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.555](http://teamcity.monogame.net/viewLog.html?buildId=9957&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:26:19


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.556](http://teamcity.monogame.net/viewLog.html?buildId=9961&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


ng-disabled


I mean the comment thats already in by a commit and that we are discussing [over here](https://github.com/tweh/ledmac/commit/f74ca9a2f30031f0f412bf6253c0330346e21b2f#commitcomment-13022783)


please avoid "alone" work there as we have a mode with such name, and you do not use "alone" in main description


semicolon in the end of the string required. Did you check the code with lint?


I think you missed the `Sanitizer.sanitizeForHtml(...)` part...


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 56](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191334&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


`:user_id` war hier glaube ich schon richtig, oder?

Wenn ihr allerdings tatsächlich mal etwas nach `:id` durchsuchen wollt, geht auch

    Rank.find(some_rank_id)

Außerdem hat diese Änderung nichts mit der Formatierung zu tun. ;)


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 56](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191334&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:09


No need to change tokenCommen in this case, could be the same old code here


did you test this? you'll have a None/NULL title. so you might want to explicitly set it to an empty string here


IIRC, this was just a fix to the documentation.  The 3rd argument had always been there.


Ah, thanks, mustve gotten distracted while writing this


Bitte konsistent sein. Entweder ihr benutzt die Variante `find_by_attribute(value)` oder `find_by(:attribute, value)`. Eventuell ist sogar eine davon deprecated. Jemand recherchiere das mal.


ups.. a typo


Thanks for the feedback!  I've updated code and added a simple test.

If this looks OK I'll add the other option next.


Holy moly, wo kommen diese `article` und `comment`-Sachen auf einmal her? oO


@JoeVogel Calado!


i think you need to keep `title=''` here, too


Warum wurde diese Zeile gelöscht?


I removed the constraint for title in sections, so it doesn't fail. Do we still want to set it to empty string?


I think, we should change the name to `WindowBorderOnScreenFlags`, because we have several `borderOnScreen` flags but no 'bordersOnScreen' flags.


(it was not my footnote, but I think your text is clearier. No one use directly penalty. And the note does not mention blank line).


Wie gesagt: Bitte macht weniger Änderungen pro commit und Pull Request. Wenn ihr mehrere Eisen im Feuer habt, benutzt branches!


Hum, your comment is about paragraphed notes. And this commit (e9805de) is about notes in general, with paragraph inside. It is two different thinks. But I don't think it need any comments.


Hi @imath, I made all the changes and it does not work :( I have to save changes to take effect, and should work without saving changes. Excuse my English, I'm from Spain and I am translating with google.

Changes:
ADD CODE:
if ( is_null( $activities_template ) ) { return $can_do; }
AND
$request  = apply_filters( 'alt_public_group_ctrl_users_request', groups_get_groupmeta( $group_id, '_altctrl_request', true ) );

DELETE CODE:
$request  = groups_get_groupmeta( $group_id, '_altctrl_request', true );

RESULT
![captura grupo](https://cloud.githubusercontent.com/assets/643599/9632143/ad56f0f2-5185-11e5-97e3-d474e3e6cca0.JPG)


Hm, not a big fan of having sometimes `None` and sometimes `''` for the same thing. If you want to unify it, set the default to `''' again and  change the check constraints to ensure an empty string instead of NULL


:-) Then feel fee to use my text … can you use a single commit from my pull-request?


It sounds like consensus is to have a single LB interface and force the logic about what is supported there (e.g. multiple protocol LB isn't supported in GCE) into the providers LB code instead of have it at the interface level.  When I get a chance I will rework this (and split off the host tagging).


Yes, I've checked, and there is no errors. Yet another lint bug :(


You’re right …


Looks Good


I didn't do it any time, but I could try ;-)


hi thanks. is it iOS only ? if so, I'd write it, cause it's important most of these are at least supporting iOS and Android


please check it. Maybe we should create an issue


This all looks awful, spacing-wise. This is nothing like what it looks like in my own editor. I'll check out that tool.


OK :-) let me know if I must do anything (e.g. a new request) or simply copy the line by hand to your branch …


1. In your test `TestPatternSearchReplace` you make use of `ErrorLogger::ErrorMessage` to set the different strings in `findAndReplace`.
2. I could follow your argumentation "there're no reasonable usecases" if you would use this argument to argue for a simpler solution. However, you use this argument to argue for an if-else-condition in your code where you do something special and more complicated to do something wrong for a "non reasonable usecase".
3. From my point of view there is no need to extend the tests for this "non reasonable usecase". So the test could be kept unchanged. But this is not my decision.


Fix name here.


Do not hardcode 1hour. Instead take the value from {credential_validity_in_seconds}


That looks good! Thanks!


We should be asserting something here


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1289 of 1289 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


static variables normally have upper case names. I did not want to change it to upper case as it  would create to many changes hiding original intent, so I've just removed static. Not entirely perfect, but fulfils the goal


Does it create the same directory structure in the target WAR that you looking for with this?


Why isn't this commit part of `master`?


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1289 of 1289 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


No, see https://github.com/phpseclib/phpseclib/pull/798#issuecomment-137063199


As the request states "showing the real expiration time instead of assuming 1h", please use the value supplied by the AFP instead of assuming 1 hour.


Hi,

I would like to try it if you have beta version of it...

Thanks
Shaminda


Almost

however, keep note that PHP variables always need $ in front of them
$armour = armour + 123 doesnt work
$armour = $armour + 123


it's provisional, we'll use unix sockets, although maybe can be easier to work with TCP in development and use unix sockets only in production.


@blacktrash you are welcome, I'll follow the HE-AAC+MPEG-DASH bug at https://code.google.com/p/chromium/issues/detail?id=527411


also note that $target->getAdaptiveArmour gives $this->damageClass as a parameter, while getAdaptiveArmour function apparently expects $gamedata in the functions parameter.
Better reword $gamedata to $damageClass


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1816 of 1816 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


There is one stack answer.


Hi! Its Profile 111 and includes iOS and Android.


missing ```return -ENOENT```


Hi, does MCPB.py support the modelling of Fe 4+ like the Fe(IV)=O moiety in the catalytic cycle of P450 enzyme?
When I assign +4.0 charge to Fe, an error shows as:
       File "$AMBERHOME/lib/python2.7/site-packages/msmtmol/gauio.py", line 159, in write_gau_mkf
           vdwradius = IonLJParaDict[i + chg][0]
    KeyError: 'Fe4'
I guess this is because there is no parameters for Fe 4+ in this element.py module. How to solve this problem?
Thank you.


typo: binding


Sorry, to be more specific, the spec should go along the lines of:

```ruby
# Given some bad data
invalid_utf8_log = load_file_fixture('exim-bad-utf8-exim-log')
done = MailServerLogDone.new(:filename => "foo")

# good_data = ???

# When I pass it to MailServerLog.load_exim_log_data
# The result should look like _this_
expect(MailServerLog.load_exim_log_data(log, done)).to eq(good_data)


Thanks for the re.compile() tip. Reading about that now - very interesting!


What does *asdasd a* mean?


@mc1100, I'm not sure how you commited these older versions, but you updated Docs arm 16 1.4.332.16 to 1.4.332.17 for 160 and 240 3 days ago (4d54152 and 2d213e8)

Should we expunge this one (10b809a) and the 160 one (4092085) from the repo?

/cc: @mfonville


test


I fixed it in the merge commit.


Strange, but we don't have semicolon rule enabled in .eslintrc. I've added the rule and it works now.


An der schema.db haben wir eigentlich nichts geändert Oo
Mit dem nächsten Commit haben wir dort eine Zeile abgeändert, aber dieser comments-/ und articles-Kram ist uns auch neu... Merkwürdig.


don't forget the license header (I just always start from an existing file)


We use the `browser == "applicationframehost"` check twice here, I suppose we should move it to the separate function `isMSEdgeWindow`. And we can separate the comment. The first part stays here, and `//Edge is an Universal Windows App and managed by process 'applicationframehost.exe'.` moves to the `isMSEdgeWindow` funciton


Since you released the ```snap_lock``` up on line 2143 -- the ```it``` could have been invalidated while the lock was released.  Therefore, you will need to find the record again here while you are holding the ```snap_lock``` for write.


and add the `NOTE: ` prefix to the comment


RoomAirflowNetwork (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


looks good


not enough


Also set ```ictx->snap_name = dst_name``` if ```ictx->snap_id == src_snap_id```


thanks


remove please the unnecessary line #277 https://github.com/AndreyBelym/testcafe-browser-natives/commit/6f8be8d3acaa5a3bb74cebd586435fe8ffe80923?short_path=88333ba#diff-2112a6afe0f6726856e6a8ff549dc10cR277


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.947.6b53af2040795781ae0301e43eebbbe0c18bdf45](http://build.palaso.org/viewLog.html?buildId=62534&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 486, ignored: 6 Build time: 00:03:08


Brand new review: https://github.com/linagora/james/pull/11
I will answer here each comment


tried cherrypicking this along with 1/2 and put both in jf common folder but I can't seem to get it to work.. I did however get the old 01led to work but it wouldn't shut off after boot completed.. am I missing something?


@mtaylor: better? :)


Please raise issues on the issue tracker (https://golang.org/issue) and please ask questions on the mailing list (golang-nuts@googlegroups.com).  Comments on github commits are seen by very few people.  Thanks.


please check all the strings with a tech writer before creating pr.


/r-


rendered


it's probably a jar


I’d say `\break` should be `\linebreak` …


You should be congratulated just because you use Haskell! :laughing:


Yes, that works.


james-server-core should come before james-server-data-api


? why you have this class name `StdImgIOException`


Ok, I gonna stop with the flattering stuff.


test scope


typo "stabilizing"


@acabunoc The following file is not needed: paper-badgers-widget.js -- this can be deleted.

Should just have paper-badger-widget.js (in public/widgets) -- with all latest changes.


hmm, you want a felix bundle ? (:


and @xsfour the test is failing.


I before E, except after C. :)


type "renamd" should be "renamed"


Hi,

I have a question in regards to this commit. I have a use case where preconfigured (J)Ruby installation is shipped in a MSI package in combination with a preconfigured GEM_HOME directory. This change leads to the behavior that this is no more possible because the full path is now set/created while gems are installed into the given GEM_HOME directory. The issue is that the location of this directory may change in the future because it is installed via MSI somewhere else.

I agree that the code change improves the situation generally, but: What can I do to re-establish a behavior which works for my use case?


@makrusak Thank you!


One of these packages should be marked as `lowPrio`.


Looks in a way similar to what `ExecutableArchiveLauncher` does, except that there it's copying the URLs of  the ThreadContextClassLoader, so I guess it's OK, conceptually. The first thing that comes to mind is whether we should isolate this for the cloud profile only, but then again, it is atypical to include class paths in the general case, anyway.


I guess, this made it working; strange because if you compare it to the current cookiecutter .travis.yml: https://github.com/audreyr/cookiecutter/blob/master/.travis.yml


the two exist, but \linebreak is more commun (try \meaning\break)


The system.xml file is missing (you can not change the log_active setting from the backend).


This breaks the plugin, since the cachename returned by "_cachename" will almost always be the same - and not have anything to do with the actual ditaa code.


Also this change here to generate a xml


Done: https://github.com/rouazana/james/commit/e360afd73d452adc95861f1d8b18c5373ee17cc8


Such code doesn't belong into the client library at all.
ParserContext is in kdwsdl2cpp only - because this isn't runtime code at all, it's WSDL-parsing code.

For the next step you'll need to parse these WSDL elements, store the settings (i.e. extend kdwsdl2cpp/wsdl/) and generate code that fills in the KDSoapValues correctly at runtime, for this class to send these values.

But don't confuse yourself too much, forget all about WSDL for now, and imagine someone writing code that uses KDSoapClient directly - what should they do in order to send WSA headers.


NOTE: Working version with configuration and 2 players per room, without tie game and of-course with UI glitches.


No, I just didn't remember about LinkedHashSet when I made the change... :-) Shouldn't make a big difference; ArrayList is even more compact than a HashSet which is a HashMap.


I'd need a refresher on what exactly does `classLoader.getURLs()` return for a normal apploader, but I think that we should still add the extension CL as parent, to avoid things like Xalan/Xerces not found on the CP.


It *is* just a plain symlink, right?


É porque tinha ficado a pasta Style no assets, só com os 3 css do CheckConnection


What does this achieve?
If I have just learners connected, but no data, the method names are still not shown...
_update_stats_model returns quite quickly if self.data is None (it just removes all rows)


`AdditionalConfiguration.php` is part of the instance configuration. This file imo shouldn't be added to .gitignore.


cf bc50489


this line is confusing


better commit: https://github.com/rouazana/james/commit/e360afd73d452adc95861f1d8b18c5373ee17cc8


typo "to ouse" should be "to use"


Acutally I never heard of or even used `\break` is it plain TeX? I’d say in the manual it should be `\linebreak` and/or `\newline` (both are not the same though)


Previous test whether the desired date was after the current moment was VALID


ok


Fixed ruby one-liner execution.


Make this into a github dependency instead with e.g. `git+https://github.com/arteria-project/arteria-core.git#egg=arteria-core` or similar so that we can pull in the lib without having to install it manually each time for every product.


This is now happening in membership-common 'MemberService'


Why is `AdditonalConfiguration.php` added?


lgtm


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.557](http://teamcity.monogame.net/viewLog.html?buildId=9965&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.556](http://teamcity.monogame.net/viewLog.html?buildId=9961&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 538, ignored: 6 Build time: 00:27:33


What I meant was:

    if os.path.isfile(basepath):
        trace_name = os.path.splitext(basepath)[0]
    else:
        trace_name = os.path.join(basepath, "trace")

    trace_txt = trace_name + ".txt"
    trace_raw = trace_name + ".raw.txt"
    trace_dat = trace_name + ".dat"


indexToPhysicalCoordinateTransform is a private[scalismo] method that needs to remain an AnisotropicSimilarityTransform as it is also used when dumping Nifti to retrieve the parameters defining the domain.

IndexToPoint method is the method to be used by library users and it is already optimized.


@azturner Are you planning to merge this into develop?  I'm wondering if it'll fix some of the EF exceptions we see when starting RockWeb for the first time.


\break is latex, but not used, because \linebreak is more more sofisticated. I will also \newline.


It is unclear whether $dbh->last_insert_id() runs an additional query. $results->last_insert_id is cached in the results object, like in mysql where it's cached in the $sth. It's up to you what you want to use here.


@ReneMoraales "reigstrar"


ok didn't test neither for too bad json value: I'm not testing jackson
added some tests about unicity: https://github.com/rouazana/james/commit/a3517c058652b426f56791379653b269ce8451e4


This needs to also send the other stuff, metadata and parameters.

I guess writeAddressField should be instead a method that applies to the whole endpointReference - and then you could actually move that method to EndPointReference instead.


Please pull this out into a named constant that can be easily tuned. And can it be shortened? How long does it usually take to succeed?


cf a609840


ok


On line txmempool.cpp: 230 you do an if() before the remove() which means that an evictRandom may not do anything.
That would mean you can exit this method while pool size still being higher.

Maybe the 'if' here should be a 'while' ?


The big one, I guess?


@imath, I forgot, I have also added the code in bp-custom.php


Have you changed something in the database too? So i could try to add the changes to my version.


Preferably the non-big one. :smile:


why? UsersRepository.test() should return true or false. To be unable to have an answer is an error, isn't it?


ok, reworked


Maybe you can have the comment state that the 'random transaction id' doesn't have to be a known mempool ID. Just a random 256 bit number.


a full command of "dimangle" seems to be conformal with other dimension commands, with a prefix dim-

looks like we should add code to detect command collision.

Could you please also add commands for "dimension radius", "dimension diameter"?

Thanks!


:-) actually for nix-env installation, I suppose we should prefer the big one. Another option is to change the name, similarly to ffmpeg-full #9602.


Typo: on -> one


the develop branch was actually already updated to EF 6.1.3 back in June: (https://github.com/SparkDevNetwork/Rock/commit/d9066061dd01bfec2c7879b367ae830d7d5645d7). What type of EF exceptions are you seeing?


Ok, saw it :+1:


Ok, the message is misleading then.


Please validate this .info-file. I do not see a reason to include all these dependencies, except webform and strongarm.


Typo: lets -> let's


@ReneMoraales "maneja **ls** diferencias"


Is it necessary to keep it? The constructor requires to put FixedTupleListAdress so it has to work always with AdResS. It could be even confusing when one will set adress=false and then thermostat will do nothing.


@NicholasBuse yes, they should be purged. If you could handle this Nick, that would be nice.
Cause could probably be that the commits were still somehow in the (a?) local git repository and not pushed at an earlier moment?


Nice catch. Thanks!


use the other methods of that class, too ;)


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 57](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191339&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) is now running


TeamCity mobile-music-automatization :: PR_BUILD_CONFIGURATION [Build 57](http://teamcity.mobile.dev.yandex.net/viewLog.html?buildId=1191339&buildTypeId=MobileMusicAutomatization_TestBuildConfiguration) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:02


See https://travis-ci.org/dpmb/dpmb/builds/77715348#L4759 for the build failure. http://www.w3.org/TR/NOTE-datetime does not seem to allow it:

```
$ make test
epubcheck debian-paketmanagement.epub
Epubcheck Version 3.0.1

Validating against EPUB version 2.0
ERROR: debian-paketmanagement.epub/OEBPS/content.opf(2,2400): date value '2012-2015' is not valid as per http://www.w3.org/TR/NOTE-datetime: 2012-2015 class java.lang.IllegalArgumentException MONTH

Check finished with warnings or errors

make: *** [test-epub] Error 1
The command "make test" exited with 2.
```

Maybe it's the older `epubcheck` in Ubuntu 14.04 (3.x vs 4.x or so).


This does not feel right to me. From [RFC 4120](https://www.ietf.org/rfc/rfc4120.txt), chapter 6.2.1:
> The principal identifier for a server on a host will generally be
> composed of two parts: (1) the realm of the KDC with which the server
> is registered, and (2) a two-component name of type NT-SRV-HST, if
> the host name is an Internet domain name, or a multi-component name
> of type NT-SRV-XHST, if the name of the host is of a form (such as
> X.500) that allows slash (/) separators.  The first component of the
> two- or multi-component name will identify the service, and the
> latter components will identify the host.  Where the name of the host
> is not case sensitive (for example, with Internet domain names) the
> name of the host MUST be lowercase.  If specified by the application
> protocol for services such as telnet and the Berkeley R commands that
> run with system privileges, the first component MAY be the string
> 'host' instead of a service-specific identifier.

To be more specific, we have a service principal, thus `service/host@realm`. If you stay with UPNs, it would be almost correct: http://web.mit.edu/kerberos/krb5-1.5/krb5-1.5.4/doc/krb5-user/What-is-a-Kerberos-Principal_003f.html

What do you think?


Should m_buffer(0xFF) be m_buffer(repeat)?


Ok, I’ll manage this in the evening.


Merge


Right. :)


Fixed Issue #3


(I still don't see the point in that)


Merge from Parent


+1. Matt, I'm liking this "progressive enhancement" of READMEs.


Not totally sure this is obsolete? I think it's for when static files seem out of sync, you can re-run just this to see if that helps.


`regform`


@jfinucane !


Git clone


that's not the url style we use everywhere else


Gerrit installation


Does my edit make it read strangely or was it already strange?


Any reason this and the string below capitalize `Party`, `Chat` and `Guild`?


if `__init__.py` doesn't contain any real code it should be empty. anyway, add `RHManageRegistrationsBase` in here. and rename it to `RHManageRegistrationBase`


I guess I could make it say that. Perhaps also "base's href attribute" with 's.


Whether the request was allowed / denied


well done finishing on the PDO conversion