This is file containing FunctionFS descriptors, i.e. what we should write to ep0 file to configure a function. And yes, it is specific to FunctionFS. Maybe I should extend this description to be more understandable.


(Optional)


It you mean System V semaphore, I think it's a bad idea. You can use pipe(), it will be simpler and faster.


Please make this less indented. it's fine to do
```start, stop = _find_prefix_range_bisect(
    self.trees[i], ...
```


This should just be taken off as I do not think it will ever change. Remove


For consistency I ought to have done this as the `text:` option as done on line 18. Oops.


I'm sure about this variable name, feel free to change it.


Yep, sure thing, in next call?


nice. why wasnt this merged?


Hi @schelhorn,

I used to have `--polyA`` in there, but I think the `--polyA` option has been deprecated in the newer versions of Sailfish, at least it throws an error when I run it and it doesn't look like it is used in the code at all:

```
https://github.com/kingsfordgroup/sailfish/search?utf8=✓&q=polyA
```

`--threads` is a good catch. I added that in to the code.

I have part of kallisto support added but I'm not done yet, Salmon will be added too. I'm hoping we can replace the standard pipeline with one of those super fast ones for most standard experiments.


Is this creating a new object? Or returning an existing one?


@juanpaucar What's the difference in use between `[["no"], ["without-password"]]` and `["no", "without-password"]`? Will the list of lists be used for something else later?


hmm, i think you are right. Will make the change.


Quote the HTML tag for this, otherwise easily misinterpreted as the page title H1


Algusto, please, don't use == to compare strings, instead use === ok?


What about the ALT text for this img?


`babel/bbl_dat_sjis_euc.d(74): Error: cannot modify read-only constant [0u, 0u...`
別に変更しているわけでは無いのだが・・・


@Alis-lang Hi! Thanks for the recipes!  Please note the changes I made above.  You will need to include a section above the post in order for the information to render. I have also updated the filename with dashes so that it can be redirected as part of the URL.  Also included the image tags so it can show in the view.


:+1:  nice one


ETags returned by the tripapp rails server are based on the content of the response body, so having multiple servers doesn't factor in. It shouldn't be directly serving up files from disk so won't have an inode to work with, although there's less of an upside to etags in that case (the server by default has to do nontrivial re-rendering work to know if the etag is valid).


Right, not sure what was I thinking there with the semaphore :sweat: pipe is a good idea.


Minor thing but I think I would just keep it as `.loop`.


Took me about 4 attempts to get my license file right in the package I just submitted. So confusing.

Are umlauts allowed in DESCRIPTION? Certainly CRAN package front pages don't often have special characters, but I'm not sure if they are removed.

e.g. [here](https://cran.r-project.org/web/packages/cate/index.html) there are no special characters but author spells Sanchez [with an accent](http://www.ime.unicamp.br/~ra133513/)


Some distros* use tmpfs for /tmp, i.e. store it in system memory. It's not persistent across reboot and most importantly, it's usually not very large.

*) At least Fedora, CoreOS, AFAIK also Debian


The links should be relative so shouldn't change? Maybe the images are the only thing as the images filenames should be relevant


Maybe it would be useful to use FpgaHost instead of object? At the moment I'm looping over all x-engines in my function and can't use threaded_fpga_function. Atm I'm getting "AttributeError: 'FpgaXHost' object has no attribute 'xx'" Opinions?
@amartens
@paulprozesky
@brickZA


It will be interesting to move PhpUnit as a composer dependency, removing all sources from repository.


Should be relative? or is this (Optional) as the user could specify somewhere else other than the default success.html?


(Optional)


What's the easiest way to use this? Will it hit the main repository?


2005 -> 2015


Optional


why do we need cobra-winldpt added as dependency ?


No, we don't. We need to write deny. You need to write deny to setgroups only if you don't have the CAP_SETGID capability.


What do you mean by (Optional)?


Remove


regUardless -> regardless


Thanks!


hi


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 544](https://teamcity.labkey.org/viewLog.html?buildId=270721&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:22:50
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

##### there are 20 more failed tests, see build details
```


Okay let me correct that


@jonludlam Switch to oclock as suggested, code simplified too.


and add here something like
__init__(self, host, katcp_port=7147, boffile=None, connect=True, config=None):
FpgaHost.__init__(self, host, katcp_port=katcp_port, boffile=boffile, connect=connect)
or is it going to interfere with x-engines some how since x-engines host b-engines?

@amartens
@paulprozesky
@brickZA


That's interesting.  I am running FC22 and my /tmp dir is persistent across reboots.  Are you suggesting I shouldn't implement a simple HostPath Creater this way?   This is meant solely for development and testing.


Done. :)


Rather than having the user do this HTML content whole process twice, we could group the changes to something like 2 tasks in a row:
'Set the HTML <head> <title> for index.html'
'Set the HTML <head> <title> for success.html'


Ye I'd like to extend a bit on this and put some more information, e.g. how many states were merged, maybe some timings as well. Will have a look at how to do logging in rust


Even the exception handlers in BaseRestController?


Can this be done relatively so that it's not needed here as a task?


@hnakamur is the string in a valid JSON API format or should we be doing something like:
``` py
elif (isinstance(error, str)):
    errors.append({
        'detail': message
    })
```


Maybe list the Hex colours inline here for ease?


Okay I shall remove it


I am very much for this as a checked item, but I think the idea of this sign-up template is that you _just_ go in and edit the things in the list.  Therefore no changes to the semantics and tags is done.  This is a thing to be checked once only on the template and then taken for granted when duplicating for each industry


As above, I think this is a test only done once for the template and not needed for each industry.


ни в коем случае ничего не клади в $_POST


There is a variable for this that you can use.


Can you also assert that the count has reduced by one?


```golang
func newImage(language string) string {
	const imagePattern string = "coduno/fingerprint-"
	return imagePattern + language
}
```

image -> coduno/fingerprint-javaut


I don't think we need internal logging. And I think a `-v` switch would probably best be in a new branch.


The var name `suspend_level` is a bit vague. Why not use 'max_off_lvl' like the C file?


Does it mean the gitbook-editor is now closed source software?


@wtaferner , I hope its perfect then v8-odoo will consider this.


There should be no problems, it was introduced and immediately removed in virt-test: https://github.com/autotest/virt-test/pull/2270


I agree - this makes a lot more sense. I'll pass in the private state along with the notification and check where record the local visit.


I know it doesn't really matter, but typo: `minstry` -> `ministry`. Same typo on L67.


While you are in here, this could be added to the _variables.scss file as well.


serch should be search


Ya this will be a lot cleaner and reduce the #availability cruft.


Oh yea, I meant to ask if there is some sort of constant or enum for this, I was unable to find one. I'll change it to a class-level constant for now :)


add here if found

remove the line https://github.com/Yabause/yabause/blob/master/yabause/src/qt/CMakeLists.txt#L29

and if found added here


:+1: Looks good

If this all works, let's remove those ``subpage_urls`` for good


this cuase and error in some setups, please set only iof found, proposed code in line below


That's not entirely true, there is a difference in creating a shared library that statically links against phobos and a shared library that links against a shared phobos library.
We should use the latter as default, not sure whether the former is needed (but it should be possible by manually specifying `-defaultlib=libphobos2.a`).


Not good. Will the language dropdown on app Display Java?


No, if you look in `BuffCalculate`:

`if not unit.Buffs.Affects[affectType] then return initialVal, bool end`

It returns the base value.

But this makes me realize another error I've made - doing it this way will apply the blueprint value twice. So this probably should be handled in `BuffCalculate` instead.


As you've changed the semantics of this, suggest changing to `max_off_lvl` here (and in all the upstream SPD handlers) as well.


For Testing


Does this need to be one level up (top level of your `:devcards` build config?


I don't think you need this - from the HTML spec:

`A button element with no type attribute specified represents the same thing as a button element with its type attribute set to "submit".`

http://www.w3.org/TR/html-markup/button.html


Ya I was running into a problem where it was failing to delete previous files. Since it was an explicit try!, it would hard crash. I believe this was being caused by not having any files present from a previous test run.


redirect to https://github.com/keghani/libphonenumber/commit/cb93ef78a32b91f1f983f824407a7dc9fb3ccb4d


redirect to https://github.com/keghani/libphonenumber/commit/ce44538b97a0de5e89c88540042a1687ecf1ec53


How did that work when dub.selections.json specifies `"vibe-d": "0.7.23"`, but vibe-d 0.7.23 fails to build with 2.068.0?


redirect to https://github.com/keghani/libphonenumber/commit/7acd8cdaa39a76abfc27ec2f4a5c6ce039ca17e6


redirect to https://github.com/keghani/libphonenumber/commit/417343cc16bb3208c91e34b2ece8c2ac730250b2


Nice!


Reviewed


Since we are using formresource, i feel that formresourcedata flows along better than clobdata.
Though the internal implementation is using clob, the API user doesn't necessarily have to know about it. :)


yep, plus there is a known bug in pylint under virtualenv :smile: https://bitbucket.org/logilab/pylint/issues/73/pylint-is-unable-to-import


`does not exists` -> `does not exist` in the summary line. I'd do something like `virttest.bootstrap: Skip downloading non existent assets`


need to write a migration to undo this.


we do indeed not to run the delay job creation in a thread. merged into 2.6 and master branch (adding a tag in subject)


Error strings should start lowercase and not end with punctuation.


I think this icon change should not be here


finally it can close itself


Shouldn't the shebang be `#!/usr/bin/env python3` if python version 3 is required?


Put this to Datastore.


:+1: I was going to ask for this after spring one.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 545](https://teamcity.labkey.org/viewLog.html?buildId=270724&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:23:17
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

##### there are 20 more failed tests, see build details
```


fhdjks


Rebased and fixed.


Why did you remove the Java8 example ?


Good eye! I only found this error when it crashed :)


Damn! Thanks for spotting.


@mauro-oto You should move this out of the block, so that it does it only once.


redirect to https://github.com/keghani/libphonenumber/commit/43681a3a2ed938cc6777a40bebdaddf474701dec


![uhm how should this work?](http://replygif.net/i/1518.gif)


@HenryLoenwind was this line supposed to be there?
I can't get the game to load because this "foo" Exception is thrown. (register was false for me, tested by substituting throw... with System.out.println...)


redirect to https://github.com/keghani/libphonenumber/commit/e1c3c8c0a2a8240b19cb7cad2f9657a852d40f8b


Oh and it no longer requires promises either.


But it doesn't seem this invariant is used/useful.

Maybe if you had toList that created a NonEmptyList but I'd say this module
isn't worth it in any case.
On Sep 8, 2015 17:05, "Noam Lewis" <notifications@github.com> wrote:

> It provides no external way to create an empty NonEmptyMap
> So to users of the module, NonEmptyMap is always non-empty.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sinelaw/buildsome/commit/6d5e2fa5b789c914269cd705ad3da6d0f1e60227#commitcomment-13112819>
> .
>


@mauro-oto Wouldn't it be better to just use `true/false` instead of a string?


It's probably fine for testing, but it should be clearly marked so in documentation.


@tulcod, Thanks, fixed in c6f06b2.


redirect to https://github.com/keghani/libphonenumber/commit/610bff8ee7609d15fcc5870df05096458ec19e3a


@mauro-oto You should use `elsif` here.


make a requirements.txt yaar


I am over writing, changes kar doonga


Agreed.  Docs needs to clearly say HostPath is solely for development and testing only.


1579840-GroundTemps (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Oh no I've done my fix and submitted a pull request.


Over write did not happen :)


arg, debug breakpont. thx!!


If I well understand we are  agree on that now (see [comment](https://github.com/eclipse/californium.scandium/commit/03dba55697efd7977dc529f2b3cf000e7d4fbc63#commitcomment-13099625))
Good :)


don't know what happened. accidental commit.


Hmm, this fails on travis. Should I worry? https://travis-ci.org/nomeata/gipeda/jobs/78670056


@excaliburnan  Shouldn't this log an info message instead of error message? (same for the last else case)


[The runner does not care.](https://github.com/coduno/api/blob/master/runner/javaut.go#L19)


Hi !
Thanks for your report.

Yes, it's a mistake !
And even if i'm using `virtualenv`, there is a symbolic in `venv/bin/python` to  `venv/bin/python3`
So, i will update the shebang soon.

thanks !


Fixes #1858


in init your defining it globally, then else where you reference the global (sabnzbd) scope


stack([a, b], axis=1) is missing


Is this option used anywhere? If not, we should remove it


doble punto y coma al final de las sentencias.


Please include the default in the documentation


Dumb question: should we also extend ('2f', '2F', '3f', '3F') to ('2f', '2F', '3f', '3F', '25').  I found some urls with %25XX in the path and those were also removed by the unquote function.


you're right


The problem is that install-ats will override those `*.config` file, so I have to copy files after that.


It's quincykt. Its model name is SHV-E160K. And are you going through the issue same as me?


@jimi-c Thank you for explaining, and for making me look smarter than I actually am in the git commit history! :smile:


With logging I meant stuff that only prints with the `-v` arg


I am not sure. but why all of this is showing as new code?


Awesome!!!
--
Zach McCormick
317-443-2799

On Mon, Sep 7, 2015 at 2:47 PM, Max Shenfield <notifications@github.com> wrote:
> Updated brigade details page with graphs and info a la @zachmccormick using static data
>
> Created additional graphs outlining meetup attendance, github projects, and other information. These graphs are the same for every brigade, as they are loaded from static JSON objects in the brigades.controller.js.
>
> Also added additional header information about the brigades, and changed the detail formatting to mirror the mockup @zachmccormick grabbed in the inline.
>
> Additional fix - updated Contributors in the Projects to not display a trailing ",".
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/code-for-nashville/brigade-pulse/commit/153c7e9dcb65fe858e7adb584ca8b67eb9085a4d


We should remove the `#` links -- it can add `#` to the URL when you don't want it


I missunderstanded your point. You're totally right so I fixed this in commit bb364c255ba760f232f233649326196580627260


:+1: :)


It looks like Spring does that for us - Closing the session

Link : http://stackoverflow.com/questions/8724259/spring-hibernate-session-lifecycle


Move this to the bottom of the struct to avoid holes.

Also, please either comment that this is a hack to work around older MHD, or `#ifdef` if MHD offers version checking macros.


It was useful for Ruby 1.8.7, but I don't feel very strong about it, what about @ares, @jlsherrill, @stbenjam ?


@mgrauer the way you did some restructuring all of this is showing up as new code. I would have preferred to see changes. What am I missing?


Not yet - it's on the todo list! I'm planning on implementing it now.


i thought we need docker-api


Brilliant. Excellent choice.


I fact I can `install-ats` at the very beginning, then copy the `template_files`. But I choose to not do that because it mixes two different sets of files, which is not clear enough.


```
    <argLine></argLine>
```


As discussed here: #504


Great arguments. :+1:  Will bring it back! :)


Sounds good; when implemented please add to the docs too and swap the label to `ready for review`


這邊的inputName有辦法透過參數傳到
submit後的 success function裡嗎？
我不知道怎麼傳所以這邊用全域變數，覺得這個作法不太好


Ich glaube GitHub Desktop macht einen Auto-Sync beim start. Da bin ich mir jetzt aber nicht sicher. Jetzt habe ich bei der Arbeit auch wieder Internet und einen halbwegs funktionsfähigen Rechner :) leider darf ich trotzdem nicht an unserem Report schreiben :/ setze mich gleich nach Feierabend auf der Bahnfahrt und zuhause wieder dran


Still have to test but :)


Hey, why was this reverted?


wat for?


I have observed that update method throws DataAccessException which is a run time exception and as far as I have read, this doesn't need to be handled specifically as it is already doing the job required

Link : http://stackoverflow.com/questions/10673048/where-to-handle-spring-dataaccessexception
http://stackoverflow.com/questions/27869710/dataaccessexception-vs-sqlexception


fixes #84


Apparently, a form won't submit in IE 6 or 7 without `type="submit"`. I don't have a VM to test on unfortunately.


Does it make sense to keep these unit tests and move them to a a file CSUtilsTest.java?....


Glad to see someone using [capistrano-chef](http://github.com/cheapRoc/capistrano-chef). Feel free to send me a PR and/or let me know if I should include this.

Thanks!


`slackMessage` still point to global test variable


Nope.  This gets printed when you don't have a NewtonSolver regardless of whether the user set require_residual_reduction or not.


this is unused variable declaration


Hm putting something I want to happen in the catch block feels a bit weird to me. Another way to do this would be to simply put a "continue" after the call to `getProposalContestPhaseAttribute`, but I think that's also not very good for readability.
I'm not very used to using exceptions to control flow, so maybe it's just me, but one improvement I could think of is to create a `hasProposalContestPhaseAttribute` method in the service that simply returns true or false. Personally I think this method should only be used when you want to use the attribute after getting it and then the exception is a sign that something went wrong. What do you think?


@oligriffiths  See https://github.com/composer/composer/pull/4327


Signals<->slots is not fast solution for performance sensenitive things. Global static pointer is a simpler way to provide shared access to working level scene. In the engine is disalowed to have multiple level scenes anyway. Is possible in future have two working scenes (title+level) but not two level scenes. Alternate way is a giving scene pointer to object while constructing (like other objects).
What are you think about? All objects which uses that pointer are destroying together with level scene and doesn't existing after. Also with this way will use less to "NumerOfItems * sizeof(LevelScene*)" bytes. Usually in a game are 1000...40000 elements. However are still exist lots of 512 MB RAM-based PC's, but minimal requirement to video memory is 256 MB because OpenGL textures are loading into video memory (anyway dynamic loading of textures gives able to use less RAM, because in the memory will be used textures only).


why suffix with Header?


1579840-GroundTemps (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1787 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.49%25-yellow.svg)


It's snaking the `position: relative` that is set in `oae.base.css` on the same CSS selector, but probably shouldn't. I've moved that rule here and below instead


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 546](https://teamcity.labkey.org/viewLog.html?buildId=270727&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:25:15
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

##### there are 20 more failed tests, see build details
```


LGTM


This local `error` can be dropped then.


It's kind of confusing when you see `... errorDir...`


These math.Pow's can be replaced with the consts defined at the top of this file.


not used? :)


You are removing the restricted item part of this item, therefore i have to decline

The correct syntax would be
(Rating * 4)R


Sweet, thanks, makes sense


this is nice. i wonder if we should make this generic as part of the definition of connector and then have arrow perform this check?


Wrong spelling in your function!..Didn't you run this to check if there were errors. You see why tests are important?


maybe we can change the name then... something like `path-to-error-logs`


The internal repo is not generally accessible.  You need a repo with the MQ jars available as they are not in any public repositories.  Come on, IBM!


Remove empty destroy function


Good point, I called it `associateProposalsWithCompletedPhase`, as this is not a generic method that could be used somewhere else. It is specific to associating proposals with the last phase, as it "finalizes" their versions. I think the new name removes that ambiguity.


Since it's only in the additional license file, it doesn't appear in the manual or on the package's CRAN splash page.

Here's an example of a package with the correct setup for this type of licence: https://cran.r-project.org/web/packages/protr/index.html

can't be bothered to search for one with an accent though!


why 2.4.0?


I think it is sensible to escape 25 too, can you provide an example url and even better a fix ?


Give space between line 139 and 140


Give space between line 142 and 143


Although you might are true about that, it is still very static.
You have to think about these points:
* What about multiplayer (maybe multiple scenes)
* What about multiple scenes in general?
and much more things....
Here you can read about it: http://www.michaelsafyan.com/tech/design/patterns/singleton
And talking about performance, we still using C++ and it is still better than what SMBX gives us.


forgot this part for buyingstore


not done


no re: tests coverage


Okie dokie.


@ismailmo I am going to merge the feature/derahm with the develop branch. That should fix your issue


So I do in commit fbc6974391e047e66c41fbab7ba19f5ca97fc290


This closes #3


You forgot to delete the item from iKDE_UNRELEASED in eclass/kde5.eclass


Promoted 8/9


@RandomAltThingy Can you please not comment something unless it is useful to the commit. It causes spam.


Here is an example url

http://schools-wikipedia.org/wp/m/Maxwell%2527s_equations.htm

On Tue, Sep 8, 2015 at 3:57 PM Daniel Graña <notifications@github.com>
wrote:

> I think it is sensible to escape 25 too, can you provide an example url
> and even better a fix ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/scrapy/scrapy/commit/0d3e4b4c43711c4b02db6813ebad99933ee8858d#commitcomment-13114145>
> .
>


We need the destroy function for later use. That's where we are supposed to do all deletions on chops.


one-line method: return priorityQueue.Contains(item);


the same one-line method


@gdachs Can tell me what is this conversion? How do I convert other command types or am I supposed to just send cec-o-matic codes without any conversion?
''' echo "1b 10 6c" >/sys/devices/virtual/amhdmitx/amhdmitx0/cec

''' This would correspondent to a cec message that looks like "10:44:6c"


nit: "...as efficient...", not "...a efficient..."


Alright. Just take into consideration that you'll implement soft delete.


Is buffer.characterIndexForPosition(options.bufferPosition) not giving us a UTF-8 character offset?


That do not have the hidden attribute. Why? Because the hidden HTML attribute is overidden by the display css attribute like ````display: flex````


Please, bump version on rubygems too.
https://rubygems.org/gems/zabbixapi


I'm not aware of a more appropriate place for these Image IDs. What do you think, Dallas?


@PhilipShilling I've seen isaku do it but alright.


WowReanConvocatorias team is dead?


@josevalim not sure if this test (and the associated `empty.po` file) are necessary, I added just to be sure that `parse_file!/1` doesn't raise. Wdyt?


hm, I'm not sure I understand. Currently, it checks if there is *any* ribbon, and if so, doesn't overwrite it. So if the right ribbon is already assigned, it won't be overwritten (which I think is what you mean, right?).
If the wrong ribbon is assigned, it isn't overwritten either. Should that be the case? (behavior copied from Manuel's ribbon distribution tool that Patrick referenced)


Eu até tentei alterar a propriedade com o set_preference, mas não funcionou.

O melhor é eu abrir uma issue e detalhar a situação atual. Fiquei com um certo receio de fazer isso, mas não tem como explicar sem.

Obs.: O request em si é valido até certo ponto (e.g. status code 200), mas não é valido como requisição para o link dinamico, ou seja, o objeto relacionado a ele não é enviado. (eu vou detalhar na issue)


Thanks for the fixes.  Before integrating, could you provide some more details regarding the problem fixed by  adding `strstream.setf(ios::fixed,ios::floatfield);` and removing the extra space ? Simply adding a before and after examples would be sufficient.

Ping @finetjul


their? :)


@jessetilro I've created a class variable for the image of the player, called playerSprite.


@jessetilro You can see that I assign the image to the playerSprite here.  This is meant for tracking, and that's where I'm stuck.


this is a very expensive operation (especially in this domain since there are so many users). is there any way to cache or improve performance somehow?


what exactly do we need the SelectableLinkData for?
I mean what happens with the selected property?


same comment as above


at a minimum seems all reminders should share the same function and have that be cached (and hopefully memory optimized as well)


Bad stack memory alignment: 8, 4, 40 and 24 bytes are allocated. It's better to place them like 4, 8, 24, 40 to minimized 8-byte alignment


Ah cool


@jessetilro Here I paint the initial position of the playe,r that works fine.  Now, I need you to try to make a way to translate the x/y depending on the movement.  Use the key hooks I've made.


Tá... Tenta alterar a linha do jeito que eu falei e testar de novo. Porque
aqui foi...

[2015-09-08 12:05] Alexandre:

> Eu até tentei alterar a propriedade com o set_preference, mas não funcionou.
>
> O melhor é eu abrir uma issue e detalhar a situação atual. Fiquei com um certo
> receio de fazer isso, mas não tem como explicar sem.
>
> Obs.: O request em si é valido até certo ponto (e.g. status code 200), mas não
> é valido como requisição para o link dinamico, ou seja, o objeto relacionado a
> ele não é enviado. (eu vou detalhar na issue)
>
> —
> Reply to this email directly or view it on GitHub.*
>


Just make sure parse_file! does not raise, yeah


> I am currently doing some thing in this area

I was hopeful once more, but this probably won't be done anytime soon. So I have reverted this commit now.

But in the long run the ability to share buffers between repositories will probably be removed.


I just noticed – I had incorrectly inserted the changelog entry to 0.9.3 (not to current 0.9.4)...


I think you could use `values_list` to get the product names in a single query


Which data exactly and where can be concurrently accessed that we must protect it with the lock?
There is also client value double check.


I don't understand. The selection _is_ updated by the code above, so the event can be triggered.

I have to dig to understand why it's triggered twice.


@octoploid fixed, thanks!


temporary variable, string, it can be empty
lastModified has type time.Time


Can we make a new queue for these? I'm concerned by how slow they might be and don't want to block the periodic queue. alternatively, we could use the background queue.


1. I agree with you on this point.
2.
3. I agree with you on this point. It's good to keep the login status block the user from logging in again once he/she has already successfully done so.
4. I have another idea of fixing this but I haven't tried it out yet. I think that every time I call connect on a client a it tries to call connect on the local done and thus making multiple connections. I will try to set a flag in the *sync-client* so that when the *server* object is already populated by *remote*, I will stop it from calling connect again.
5. I don't think other commands will work before the user logs in, only that it will print out messages when the execution bumps into an object that has not been initialized by the connection yet. It would be nice to print out better error messages but I don't think it's a pressing issue at this stage. Thanks for the suggestion though.


We're doing 3 now, right?


Can I? Thanks


@esoergel this seems like a legitimate bug. @kkrampa can you PR just this commit to master now so we can fix it?


First spec! :santa:


Do we really want poop oil?


can we also move these to a different queue?


I like the alterEnrichedEvent pipeline


Anus xdxd


I think "registration forms" makes more sense than "registrations forms".


Perfectly chosen example for an easy to understand error message. Just out of curiosity - what was this error message before? I assume something more cryptic :-)


ok


I think it was a typo,.


yo
why cm-11.0 :v @Anik1199


1579840-GroundTemps (mmatts) - x86_64-MacOS-10.9-clang: OK (1781 of 1827 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.48%25-yellow.svg)


Sweet, thank you. Perhaps you could add something on the requirements of Bcbio adapter/polya trimming for the kmer-based approaches once that stuff is stable. Regarding supporting disambiguation (my pet function) I am not sure how these approaches fare with that. Perhaps that will still require alignment. Salmon at least can eat pre-aligned BAMs and just apply quantification. The others do everything in their own, so disambiguation looses our.


Wouldn't `drain` be quicker than doing a lookup followed by a `remove`?


Yes, I basically copy and paste the code from other website so I didn't remember this stuff. =D


I don't familiar with the testing/main repository. You can use testing package like this: https://github.com/tsing/docker-stunnel/blob/master/Dockerfile

This is useful too: http://wiki.alpinelinux.org/wiki/Alpine_Linux_package_management#Packages_and_Repositories


Invalid XML!


The EPG refresh rate setting is the interval at which the pvr service will ask add-ons for epg data. Although, this add-on should keep track of how hours/days of epg it previously loaded and work to suit, it doesn't. This was just quickly added to reduce needing to restart kodi or toggle 'tv enabled' just to get the epg to update (1. before this commit, it was required. 2. for times when kodi just sits open for days at a time) . So, for now as long as the EPG refresh rate is set reasonably it's fine imo. So, other than at startup, it only downloads the epg again when kodi asks and the last load time was more than 10 minutes.


1579840-GroundTemps (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (771 of 771 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-10.63%25-green.svg)


Maybe \<unitid\> but I think \<odd\> also works just fine, and either of them are better than \<extent\>


```journa``` -> ```journal```


I tried drain, but it wouldn't work. Causes the tests to fail.


You should probably delete this comment before PR to their repo


@sanderjo globals are defined at the lowest level (so at the top of ```__init__.py``` in this case).
In function you need to say
```python
global EXTERNAL_IPV6
...
EXTERNAL_IPV6 = func()
```
Or use this:
```python
sabnzbd.EXTERNAL_IPV6 = func()
```
One quirk of Python is that you can *read* a global without special scoping, but as soon as you want to write to a global, you need to declare it. If not, a new local variable is instantly created, obscuring the global. That's what I forgot when I wrote that statement.


@josdejong so can I assume you are talking about the customs.loginUser() ? This is just the setUp of the unit test(because we need to obtain the session id for the unit tests afterwards), but it does not test the loginUser method itself. Does it make sense to you ?


* multiplayer ways:
 * standalone multiplayer games uses same level scene but each player has own camera - vizible area which shown as part of screen. At same time may be played one level (such a cooperative). Multiple level scenes means than is able to different players play different levels at same time in samew game.
 * In network way each player has separated copy of client with one level scene. All scene contents must be syncronized between theme selves via network "room" organized by server part. Server is a communicator/broadcaster only which doesn't modeling game process.
* about Singleton, yea, MainWinConnect is a same Singleton. I has no things why needed to have multiple mainwindow copies in same editor? If we are wanna make GIMP-like MDI, the way is a making opened files as separated free-flyght windows and MDI area will be hidden (menubar and toolbar will be shown). But thing is ability to has better usage of multiple monitors where you can move different file and use that to visually compare different files or draw new with usage of opened example, etc.


Are we actually using this?


@josevalim there you go, so we're sure empty or whitespace-only strings are tokenized (thus parsed) correctly. I don't think we need a `parse_string/1` or `parse_file/1` test for this as well, right?


Did you delete the `remove` line too or leave it in? I'm fairly sure that `drain` should work.


Where is it reported?


happens to the best of us...
which PR was it??


Is there not an existing bootstrap style you can use for this?

Also, please don't reference things by your name or initials (unless it's a hack or a temporary thing and someone needs to know who to contact).  It would be much better to use descriptive names.


Sorry, i've forgotten.

Now it's done.


@FernetMenta: What do you think?

Usecase: 4k@30 TV but user wants to watch 50i content.
Solution:  Switch to the highest resolution with the best match, e.g. 1080p50 in that case


Ah, I think I forgot that.


yeap


Just to differentiate time-based from item-based intervals, can we rename this to something like ```rbd_journal_commit_age```?


This will always warn if you don't have a NewtonSolver.  Not having a NewtonSolver is not a crime and should not generate a warning.  What should generate a warning is if the user doesn't have a NewtonSolver *AND* is trying to change require_residual_reduction.


纠正：修改的是MainActivity中的PlaceholderFragment类 而非NavigationDrawerFragment类


Yes  - that was my point :) I changed it to use short rather than your suggest to use "byte". It is now consistent I think...


Its projectatomic/atomic/issues/150, using just '-e DATADIR' is fine, but '-e IMAGE -e NAME' won't work.


These should now be fixed.  Let me know if I've missed anything.


OK, let's try that; if it works, I think it'll help future readers of the code.


Thanks for suggestion. Fixed in 947441d .


BUT, MainWinConnect is SHIT.
You know why?
Because you can't design your own GUI because the LevelScene-Layer depends on the GUI-Layer. This is one of the WORST anti-pattern you can do. I am sorry that I didn't notice that early enough :/.

So you might ask yourself, why do you need that. Just think about an alternative GUI for Andriod.


@elemoine I try to fix the search issue on the beta.
Maybe I'm wrong but I think if you revert this value, you also have to choose a ngeo version that is still using the old version of typehead.
Which version of ngeo could I use ?


Thanks! Have a good day :)


Nope, that's what I did. Test fails because the stategraph has less states with drain for some reason.


XXX for delorean


@myint did you mean to make this into a PR?


Sorry, you are right; there is no type in this case.


you can use now %py2_install and friends :smile:


Again, tfw_connection_link_to_sk() is just a 8-byte assignment. What do you synchronize?


Probably it was merged time ago and we didn't clean the branch. Doing it
now.

On Tue, Sep 8, 2015 at 3:35 PM, csobier <notifications@github.com> wrote:

> @iriberri <https://github.com/iriberri> , Is this stale branch still
> applicable? I know it says it was created to fix a typo but this question
> does not even appear under FAQs anymore. Please advise.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CartoDB/docs/commit/6682df02bd5c6bf988af2393afb02cee07bf7b6c#commitcomment-13112178>
> .
>

--

*Carla Iriberri*

*CartoDB—Map Your World's Data*
C/ Eloy Gonzalo, 27, 3, 28010, Madrid, Spain
W: www.cartodb.com


I am aware that my wife has sexually transmitted diseases because of your inappropriate behavior. You are old enough to be her father. How dare you GlobalThug.


I think drain clears all elements and returns them in an iterator. Even though we only look at one element of the result, the whole set still has been completely cleared.


*.egg-info

Please read my PR to doc, as it could use issue with delorean builds
https://github.com/redhat-openstack/openstack-packaging-doc/pull/27


The journal also has flush age and max flush bytes in case you wanted to expose them all.

Right now the settings are applied at a per-object basis, so if you have a splay-width of 2 -- each journal object needs to have X number of writes, not X / 2.  Should we somehow note that these apply per splay-width journal object?


hello, i wish to test for my pc, opensuse 13.2 kde4.14.9
for testing with korganizer (kontact) and my friend ' RapFan89' did open report bug to kde team:
https://bugs.kde.org/show_bug.cgi?id=325224

that said is FIXED, so i want to try update my pc but my YAST (opensuse control center) package libical version is 1.0-5.2.2 date : 2014-10-08 it's old version, but how i can update for opensuse?

yast package libical:
libical1 - Un'implementazione dei protocolli di base iCAL

/usr/lib64/libical.so.1
/usr/lib64/libical.so.1.0.0
/usr/lib64/libicalss.so.1
/usr/lib64/libicalss.so.1.0.0
/usr/lib64/libicalvcal.so.1
/usr/lib64/libicalvcal.so.1.0.0
/usr/share/doc/packages/libical1
/usr/share/doc/packages/libical1/AUTHORS
/usr/share/doc/packages/libical1/COPYING
/usr/share/doc/packages/libical1/ChangeLog
/usr/share/doc/packages/libical1/LICENSE
/usr/share/doc/packages/libical1/NEWS
/usr/share/doc/packages/libical1/README
/usr/share/doc/packages/libical1/TEST
/usr/share/doc/packages/libical1/THANKS
/usr/share/doc/packages/libical1/TODO
16 file in totale

maybe github latest commits will release binary for opensuse? RPM or copy and paste in /usr/lib64/ and /usr/share/doc/packages/...?


Also it seems there is nothing to synchronize


1579840-GroundTemps (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1787 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.49%25-yellow.svg)


вапвап


Isnt the if statement already checking that ?

On Tue, Sep 8, 2015 at 10:24 AM, roystgnr <notifications@github.com> wrote:

> This will always warn if you don't have a NewtonSolver. Not having a
> NewtonSolver is not a crime and should not generate a warning. What should
> generate a warning is if the user doesn't have a NewtonSolver *AND* is
> trying to change require_residual_reduction.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vikramvgarg/grins/commit/0b5067dea59dc98f8c5ebabba8d53d66b49cbf22#commitcomment-13114903>
> .
>

--
Vikram Garg
Postdoctoral Associate
Predictive Engineering and Computational Science (PECOS)
The University of Texas at Austin
http://web.mit.edu/vikramvg/www/

http://vikramvgarg.wordpress.com/
http://www.runforindia.org/runners/vikramg


ugh? what kind of errors do you expect here?


TODO comment no longer needed


Ah, OK, that kinda makes sense. Maybe `let state_i = todo.iter().take(1)` and then `remove` then?


#1164, but was merged direct from git


I am happy to verify the steps in the UI and apply our documentation
style.  Just assign it to me :-)

On Tue, Sep 8, 2015 at 11:27 AM, Carla <notifications@github.com> wrote:

> Probably it was merged time ago and we didn't clean the branch. Doing it
> now.
>
> On Tue, Sep 8, 2015 at 3:35 PM, csobier <notifications@github.com> wrote:
>
> > @iriberri <https://github.com/iriberri> , Is this stale branch still
> > applicable? I know it says it was created to fix a typo but this question
> > does not even appear under FAQs anymore. Please advise.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/CartoDB/docs/commit/6682df02bd5c6bf988af2393afb02cee07bf7b6c#commitcomment-13112178
> >
> > .
> >
>
>
>
> --
>
> *Carla Iriberri*
>
> *CartoDB—Map Your World's Data*
> C/ Eloy Gonzalo, 27, 3, 28010, Madrid, Spain
> W: www.cartodb.com
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CartoDB/docs/commit/6682df02bd5c6bf988af2393afb02cee07bf7b6c#commitcomment-13115016>
> .
>

--
*Christa Sobier*
Technical Writer

*CartoDB—Map Your World's Data*
143 Roebling St 2A, Brooklyn, New York, 11211, USA
T: +1.917.463.3232
W: www.cartodb.com

Live sessions to learn CartoDB <http://cartodb.com/webinars/>


wei...


should I fix and repush it?


No, ti is fine. Ship it.


Thanks for the follow up!


The th & uk files are not in the cache-file, correct?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.956.15ddef65a76131df1b806aac650b12c5782c3e40](http://build.palaso.org/viewLog.html?buildId=62855&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 502, ignored: 6 Build time: 00:03:55


By the way, why do you acquire sk_callback_lock for writing here?


I couldn't figure out how to access headers any other way.. had to make this changes to access rate limit headers.

I was not thinking how easy it will be for you to upgrade TwitterOAuth.


Maybe something like https://github.com/sstephenson/bats/pull/119 ?


This is exactly that I was thinking about this one. This should be similar to specifying the node engine version in appc.json file.


You do like `take` but it still returns an iterator. :D

I tried `let state_i = todo.iter().next().unwrap()` but it results in an endless loop.


This `.class` is not `ValidationError`; it is `StandardError`.  This change only introduced a new constant.


I think my comment describes it good enough. Just add 1b in front of the cec-o-matic message and omit the sender address.


Looks like `loadDraft` is only called in one place that already has the store, so we don't need the container lookup:  https://github.com/discourse/discourse/commit/f887637935261de260158babbce72707a8eaa28c


Oops, sorry. I see you fixed it and I did a follow up commit.


OK, I give up :)


:ok: :1234:


Percent


@sensescape I found that this was trying to use a style, `pois_text`, that doesn't exist. This whole section will probably be replaced anyway, but I removed the reference for now because it was generating errors.


[RFC 7159] (https://tools.ietf.org/html/rfc7159#section-1.3) is also a good read. It intends to supercede [RFC 4627] (https://www.ietf.org/rfc/rfc4627.txt) as well as higlights inconsistencies and interoperability concerns.


@dubek, do you think the "deprecation" should consist of just writing some code comments saying "this is deprecated", or inserting some code which prints a warning to the console when the files are `require`d?


yeah css these breaks put things into divs.


Rename variables "id" and "i" to something more meaningful


lose this space.


wait, adding that template and altering the load order overrides ***everything*** which is not what was required, reworking


LGTM


sorry, I mean, how to process messages in queue, did you build some server to process it or just simple pop by pop?


I think these should look like this:

```ruby
class ValidationError < StandardError; end
class ExcessiveResourcesError < ValidationError; end
```


@dcs619 I didn't find out exactly why, I just noticed that some worked and some didn't, so I put in some safety dance code.  I did see something about 'multi-page' tiffs, which couldn't be converted to bitmaps.  Are your check scan tiffs uploading and displaying correctly now?


Hi,

The idea looks good but I will have a closer look on it this evening. We should share a part of this code with the matrices if possible.


SMIX don't work any more in this release.
Each servo can only use the first rule.
They simply are ignored If more is added.
in stable rel from 2015.07.11 it still works.


this is the unreadable cousin of `strlen`, right?


these still working on ideas. pulling it down on my computer again the changes. will report back


not 100% sure that using a google dns server is a good idea per default


So is this commit really fix /workaround those warnings? And kernel compile properly with warnings?
Last question: are those flags really so good to bother?:)


I just tested in IE7 on a VM and you're right, it needs `type="submit"` to work.


Starting w/ Infernalis, RBD parameters should be stored as variables within ImageCtx so that they can be overridden with the RBD metadata feature (i.e. rbd image-meta set <image-spec> conf_rbd_journal_commit_interval 1).

This commit applies to the other new config items as well.


I was thinking of doing a simple pop by pop.
Actually I now notice that this package doesn't allow to do a blocking pop - i.e. wait until there is a message in the queue in case it is empty. It's probably because mongodb does not allow such "event triggering" (though polling won't be too bad in my case).


should this be a more specific catch instead of a catch all?

could swallow important exceptions..


not unreadable, but yep. :-P


What default would you recommend?


@tsegismont have you checked that version.org.jboss.jboss-dmr and version.org.jboss.msc and others above do not need to be changed?


Yes, this will change once we have logic to parse `/etc/resolv.conf` and the Windows config for that.


Right, micro-optimization.


"Failed to send request"?


It should not throw an exception at all IMHO (in cache)… we'll look at that later.


This shouldn't be a try / catch at all, caches shouldn't throw on cache miss, it's not exceptional.


Fine. :-)


Nitpick: parens after `NotImplementedError` should be consistent (WRT previous example).


great! :dancer:


no idea what's faster with PHP 7… but I didn't touch that code here^^


LGTM
Very happy to see this!


1579840-GroundTemps (mmatts) - i386-Windows-7-VisualStudio-12: OK (1787 of 1833 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.49%25-yellow.svg)


You'll want to keep WebPerformanceTest out of the default task because it is not a part of the private build that should run locally on a developer's workstation every time.


closes #157


agree, should default to whatever the OS default DNS is configured for.


On Tue, 08 Sep 2015, Serg G. Brester wrote:

> [1]#1164, but was merged direct from git

that one is an issue, and not a PR.  Please submit that change as a PR
(and fixup the changelog then ;) ) -- I have forcepushed previous state
to master now

I would prefer such changes to go through PRs so we could get
testing/visibility of what is to be changed in the codebase


fast-forwarding hotfix/2.0.6-2012.08.25 to borshop-integration-545-hotfix/check/force-index-ok-and-wait-for-kv = 7cab8db4


That's a lot of releases in one go! Have you noticed any changes?


@jessetilro What was the reason to remove the timer handling for the GUI buttons?


can we make this FuncDef to be consistent with func used in language itself? thanks


I dont think this is a hot path, so I would vote for the most readable version here.


Because Travis doesn't support such a "modern" version of Maven, I lowered the minimum requirement in `parent/pom.xml` to 3.2.5.  So This should say something like

```
+ [Maven version 3.2.5 or newer](https://maven.apache.org)
```


Ты наверное подумал что это обмен ресурсами, а это всего лишь измененная лотерея с новым интерфейсом и более честными условиями


@alexdowad My first hunch was just comments; but I'll go look at some popular Ruby gems to see what people usually do (maybe there's a Ruby ecosystem "expected behaviour" which would be good to follow).


photo가 seed 파일로 저장이 안됨 nil로 들어가 버리네...


Oh my! that looks so much nicer!


Really? Seems to work in-game...


This range includes overflow values


yes, they are not used at the moment


I'm away from the console right now so I can't be sure, but I remember there would be a problem when libiconv was installed from Homebrew.  Even if /use/include/iconv.h was missing the shared library would still be there since it is part of OS X, so when Homebrew installs iconv headers the build process will pick libiconv.h from Homebrew and the libiconv shlib from the system, causing linker error due to incompatibilities.  I'm on the iPhone so I don't have a reference right now.  Sorry.


I did.


> So is this commit really fix /workaround those warnings? And kernel compile properly with warnings?

It doesn't fix vmlinux.o warnings and so far we don't have a solution for this. Those warnings doesn't see to cause any downsides, though, it's not very nice to see 100500 warnings in the end of kernel building. So far I only managed to suppress these warnings: https://github.com/ChronoMonochrome/Chrono_Kernel-1/commit/aac6325e1a67d7d955028b3e877d8d920b62b529.

> Last question: are those flags really so good to bother?:)

I did a few tests that I suppose are saying for themselves https://github.com/ace2nutzer/Samsung_STE_Kernel/commit/2e11402d440045ca9940dbe548a60d0aa1dfbaa6#commitcomment-12939877 .


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.477.c246b4ddeecbbc83a4e6c4fa45bd5ff6ec8377d1](http://build.palaso.org/viewLog.html?buildId=62856&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:10:05


There probably should be static classes. There data structures don't access outer class instance.


You should specify the directory the user should be in when issuing the `mvn` command.


The four failed files are due to change in object name. "COIL:Heating:DX:VariableRefrigerantFlow" instead of "Coil:Heating:DX:VariableRefrigerantFlow,". Merged the latest develop into this branch to correct name diffs. The CI machine is expected to come clean.


right, we just need a default in case we find no default in the OS (like unknown distro etc.)


Thanks :blush:


Things may have changed in recent Xcode setups, so if removing the tweak and simply dropping support for old Xcode version were to work, that'd be fine.


Looks good to me!


I used that to have easier way to have access to main window (I think, you know than was it is NOT worst anti-pattern, before I found usage of static pointers, I had this dumb shit:
in MainWindow:
timer which runs "checkEvents()" func each 1 ms.
boolean in a source class "eventHapened" which usually false
to call function under "eventHappened" I must set that "eventHappened" to true and then timer will detect that and will execute a function.)

I understood you and then I has idea:
how you see, almost all functions of MainWindow are marked as SLOTS. I can make the class MWController with similar signals functions. that signals will be plugged to mainwindow and then I can use that signals to communicate with mainwindow. So, same MWController can be used to control another thing which even has less control things, but we are can hook that easily (via inhering of MWController with "connect ...." things, etc.). BUT, main question is an access too .... dockWidgets which now are separated singletons which has pointers inside mainwindow. From that docks I calling to mainWindow via "mw" pointer which I hooked from "parent" QObject. Anyway I should make "transports" to provide direct access to dockWidgets via signals-slots.
At start plan will be:
* making a dummy MWController with signals which will be as BaseClass
* making the inhered MWcontroller specific for a desktop version of MainWindow and apply to LevelScene:
 * construct that controller separately, connect all signals-slots (in constructor which will have pointer to MainWindow arg)
 * make setController() in the scene to install your just-made controller class into level scene to grand access to main window., etc.
At fist will be used both MWController and MainWinConnect while migration wasn't finished.
about replacement of GUI you gave me awesome argument to has special Interface instead of a direct pointer to the class. Android should have different GUI, because regular desktop way on Android is true hardcore where impossible to make something without strong effort. However it gives possible to make SMBX level on the smartphone, and it should has special, optimized especially for touch screen, GUI


These ranges include 763675, which is an overflow case.


we could hard stop / throw in case of the OS doesnt provide a setting and the user didn't define one programmatically either. no need for a fallback?


Yes, well remembered, thanks!


I think it is better and easier to use QDataStream object to parse binary data instead of reading it byte by byte and do bitwise operations.


* Since there is a block named scripts inside body, I see that you have to **rename** this guy to be `{% block content %}`
* Please be accurate with **spaces** too, `{% block body %}` not `{% block body%}`!


@technorama Right now if you pass a block with `&block`, it will create a Proc object, possibly creating a closure and allocating memory. To avoid this, you should do:

```crystal
ret = max_by_internal { |value| yield value }
```


This should presumably say class "git-diff"


Thanks for the heads up, completely missed that one


Also, we would need alignments for fusion detection, so let's keep the standard pipeline around for a while. But having a second, fast pipeline for quant sounds fantastic.


thanks, that was it, https://github.com/darwin/plastic/commit/39ba6f909e4c32d27255a936f542731e4ddb2de0


Isn't this strictly redundant with the below?


came out on the google play dashboard, but I hid it after I fixed it. Check "Show hidden"


Shouldn't this say "git-diff" too?
Have you tried this code on the examples in your documentation?


Is `jumbotron` a part of the body?! What about putting it in a layout instead?


Yeah, exactly-- for standard stuff like just quantitating the genes/transcripts present, the fast stuff will go. For anything more complicated that needs alignments, the whole deal will run.


doesn't sound very user-friendly… and what's the issue with googles public DNS? If it ever would be unavailable, it just fails after that. And you (developer) can see that then.


Oh, I see now that some places you have class "git-filter" and some places "git-diff".
I'd say "git-diff" is better.


saw approval from hmmr
at https://github.com/basho/riak_core/commit/38b8f8fe41079ec6c366af49158d05842f95b9bc


merging basho/riak_core/metadata_callbacks = 38b8f8fe into borshop-integration-778-metadata_callbacks


basho/riak_core/metadata_callbacks = 38b8f8fe merged ok, testing candidate = ae8fa34e


**Change** `{% block mettags %}` to `{% block metatags %}`


doesn't it need to change to  repository, either?


I already fixed it in #1838


It's a bug, which causes the game to instantly pause after initial start. The actual timer handling is a few lines further, in the event handler.


warum das?


Your rangeOfString call should also use " cheese" (with the space in front of it). And then you need to use the result (in your case cheeseNameRange) and use it to replace that string with an empty string.


We will read any document 😆 we will  rake you  😎👆


These actually evaluate the message every time rather than on failure. According to https://code.google.com/p/guava-libraries/wiki/PreconditionsExplained

*This advantage is also why we recommend continuing to use checkNotNull over Objects.requireNonNull introduced in JDK 7.*


Is there a "like" button for commits? ;)


yes, it's not religiously adhered to, but if it can be limited it should. and this is a very long line

doing a 3 way merge on code that is wider than 80 columns requires wider screen that I usually have access to...


This is just a JBT component name. Could be much shorter: "hibernate" or something like that.


hello world


Hi @malaguna
Looks like this creates a circular dependency. The project now depends on itself


Move these to the assignments


Move to assignments


OK, you've convinced me. It's always option to copy or if
concerned one can always double check git log or git fetch
summary to see whether hooks have been updated. 19a99f8


TeamCity pull requests :: netty-tcnative [Build 2](https://garage.netty.io/teamcity/viewLog.html?buildId=1219&buildTypeId=pulls_netty_tcnative&guest=1) is now running


+1 to consistency


Good point. Do we want to keep using this one form of checkNotNull then?


[ ] Add a space after `body` so it will looks like this `{% block body %}`


TeamCity pull requests :: netty-tcnative [Build 2](https://garage.netty.io/teamcity/viewLog.html?buildId=1219&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:53


There is always :+1:


oldId is only used in the assertion, we should likely move it into the second arg, that way it is stripped correctly.


Can you add a test variant where the file is present but empty?


r+


Is also could be achieved with:
GRANT ALL PRIVILEGES ON 'democo'.* TO democo@'1.1.1.1' IDENTIFIED BY 'PASSWORD!';


cc @paul_irish


Cool, thanks!


SET PASSWORD FOR


@Brit200313 will do. thanks


Why not directly connect the mainwindow slots with the scene signals? I don't understand the issue here. And for the dockWidget you can make a function "connectSlotsWithScene" and pass the scene pointer to it.


Please can you change title to:
"enquos - building an app for Quantified Health"

(note: enquos with lower case 'e').


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 547](https://teamcity.labkey.org/viewLog.html?buildId=270735&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:22:21
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

##### there are 20 more failed tests, see build details
```


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.497.c246b4ddeecbbc83a4e6c4fa45bd5ff6ec8377d1](http://build.palaso.org/viewLog.html?buildId=62858&buildTypeId=bt223) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3317, ignored: 140 Build time: 00:25:49
### Failed tests
```
Palaso.Tests.dll: Palaso.Tests.Progress.ConsoleProgressTests.LongRunningMethodUsingConsoleHandler_ProducesLog: <no details avaliable>

```


Almost. You want to return this string, though. And not "cheese".


QDataStream is using Qt proprietary data encoding. I don't expect that SI guys even know about Qt & QDataStream.


- [ ] You should **move** this to *home.html* since Font Custom is not used in every project page!


It's really guite  👻


If you get a string called "Restaurants" into this method, it could mean two things:

1. Either you accidentally pass the "category" property instead of the "color" property
2. You accidentally assigned the category string to the color property.


please reformat so that it is shorter. It's a second-longest line in script now


all tests pass:
success: http://buildbot.bos1/builders/test-riak_core/builds/1731


Yeah, it was a bad idea in the first place.


Or replace oldId with this.id completely (unless that's what you mean)


Created circles3.java and make changes.


I do not like this.


static private / private static


Yeah, probably a good idea to mark the test helper functions as such.


patches welcome
On Sep 9, 2015 00:42, "EmilsPa" <notifications@github.com> wrote:

> SMIX don't work any more in this release.
> Each servo can only use the first rule.
> They simply are ignored If more is added.
> in stable rel from 2015.07.11 it still works.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/multiwii/baseflight/commit/b6a002e945841b64ac163a1de8c9ca0320c85271#commitcomment-13115484>
> .
>


background-color: @blue75;
border: 1px solid @blue;

Make sure the border-box is on and that there is a space between them blocks - it wasn't happen for me when I was editing in browser. Screenshots please :)


fixed issue #2


That would work great with newer versions of Arrow. But it won't warn you against older versions. Is that alright?


Yes... so Template is also an UmbracoNode which has a `Path`, so we know it's hierarchy for parent/children. It's unfortunate that this same property is used in the other File models for the file Path.


Remove space before colon, add one after it


LGTM


- [ ] **Move** its contents outside the block so you will not call `{{ block.super }}` every time you add a link


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.466.de275939eed03371b4e82440214b2abb96f02201](http://build.palaso.org/viewLog.html?buildId=62861&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:16:12


Makes it so they can be `overflow`ed for scrolling super wide tables.


code


Schedulers should make a decision on plain unmodified request, so the scheduling should be done before any request mangling.


there are lots of nice libraries that can do stuff like this for you, e.g. https://docs.python.org/2/library/csv.html (though you might want https://pypi.python.org/pypi/unicodecsv/0.13.0) for `csvToDict`

https://pypi.python.org/pypi/iso8601 for `isoDate`

etc

for `addOrIncrement` you might want to look at https://docs.python.org/2/library/collections.html#collections.defaultdict or even `Counter` in the same module

hope i'm not intruding with these suggestions, just happened to see it fly by and glanced over

löv (why am i writing in english?)


This renaming breaks the management API, and I don't think it's necessary to do that.


Do you know when this commit will be updated in the npm registry? Currently I keep seeing 'undefined' files created, as I gather npm hasn't been updated with this commit yet - even though it was done back in January.


I would create the following event type instead:
newConfigurationEventType = new UsageEventType(
"hibernate",
UsageEventType.getVersion(HibernateRuntimeCommon.getDefault()),
null,
"new configuration",
"Hibernate runtime version");

Then report it as:
usageReporter.trackEvent(newConfigurationEventType.event(hibernateVersion));

It will generate the following event:
PAGE:
Component: "hibernate"
Component version: <the current version of org.jboss.tools.hibernate.runtime.common plugin>
EVENT:
Category: "hibernate"
Action: "new configuration"
Label: <runtime version>


yes


This should be `_callback.Reset(info[0].As<v8::Function>());` The current code leaks a persistent reference due to the `Nan::Persistent<>` constructor.


This file is built using `gulp build`
A linter must have added an empty line to the build file? I can merge that in once you remove it.


Don't leave commented code in; if we want to go back, we've got git history.


Needs to be removed it EXTRUDERS == 1, per https://github.com/MarlinFirmware/MarlinDev/pull/143


Is the command line overriding the xml or vice versa?


Having the proxy speeds up reinstalls by orders of magnitude; it would be nice if we could have it back.


In general, the kind of validating going on here should be done in the management op handlers, and not the parsers, as the handlers can be invoked directly by the user.


@jameskoster This line causes this blank button to show for me:
![image](https://cloud.githubusercontent.com/assets/5774447/9740828/09b71eaa-5657-11e5-8443-34f1943b838f.png)


Nice


Too much abstraction for a trivial hasmap.


is this an alt github account for you @colegarien?


This commit is causing render issues on page /rhn/admin/multiorg/Users.do . There is a link which should not be escaped. Please check it.


Np :)

On 09/08/2015 10:58 AM, Gavin Leith wrote:
>
> Thanks for the heads up, completely missed that one
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cs371p-fall-2015/collatz-tests/commit/2d0229162daf712fc9e04a9b1760e4a09627447c#commitcomment-13115869>.
>


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 548](https://teamcity.labkey.org/viewLog.html?buildId=270738&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:23:16
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

##### there are 20 more failed tests, see build details
```


r+


重寫default.ctp，所以還是一團亂的狀態XD


Nope. Not anymore. I will delete this


This team is only for a newbies trys. The real is a private rep :)


my bad. I will make sure it doesn't happen again


This can't be right. If `empty(a:0)` is true, `a:1` doesn't exist.


I am sorry, I know this is not stackoerflow or anything like it, but since this commit perfectly illustrates my concern *and* the right people are listening, I would ask:

How to learn *proper* error handling? When shoud my code `throw` and when it should not? I feel very sad about the fact that I don't know that and it's better to learn now than after I wrote tons of bad code.

May be a good article or something? «Go f*ck yourself n00b» is also a valid answer.

Thank you.


Because I don't want to mix different stuff parts


TeamCity pull requests :: netty-tcnative [Build 3](https://garage.netty.io/teamcity/viewLog.html?buildId=1220&buildTypeId=pulls_netty_tcnative&guest=1) is now running


TeamCity pull requests :: netty-tcnative [Build 3](https://garage.netty.io/teamcity/viewLog.html?buildId=1220&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:42


为什么在 `multi()` 没有什么操作的情况调用 `exec()` ？


yeah i think so.


Does this selector need to be updated with the `applicationDidFinishLaunching:` => `xcodeDidFinishLaunching:` name change?


@lieuwex lol no these edits are of LONG ago. I just opened the github application for once and saw randomly that this folder had uncommitted changes. So I committed them. :P


@itayma can you explain this a bit more, or how to replicate the issue you're having. I don't see why thumbnail need to be adjusted if `containerWidth` is `0`.


If the maxAllowableSelectionCount is one, it'll be a button, so this error won't pop up. I'll write a comment for this in the code :)


Huh, does the ModelForm not handle this automatically?


Cool, thanks. What about aTHX vs aTHX_? Does the same apply here?


Hey, your tests have lots of overflow cases


Same holds for https://github.com/tomsmeding/treetree/commit/4264b4caa582d152541c84cb18ffe5ea0f48f133 and https://github.com/tomsmeding/MarioLANG/commit/ee1b532b4d96848ef3624265056e2deff21bf2b9


Fixed in ab6f3876523be9d40788d42997365a0e099f6339.


:exclamation: The first and last lines should only be included if `settings.DocumentationRules.XmlHeader` is true.

:exclamation: There should be exactly one space between `//` and the copyright text.

:exclamation: The copyright text may have multiple lines. You need to split on `\n` and add `// ` to the beginning of each line (but don't add the space before blank lines).


although i'm also wondering is this should be something we should enforce somehow in the registry as part of doing the list for the version as well.

in other words, the CLI would send the current CLI and arrow version (as part of it's request to get component list) and we could then use this to filter against the component model.

I think an incremental change is in order. First, we do the check in Arrow/ORM and Second we also apply it at the registry/CLI level.

That way in the future, you can't possibly get a component that doesn't match if we do it correctly.


Totally valid question. I didn't know either with promises, so I asked on Twitter: https://twitter.com/sindresorhus/status/638640688230301696

The correct answer is: https://www.w3.org/2001/tag/doc/promises-guide#always-return-promises

More: https://github.com/mattdesl/promise-cookbook#handling-user-errors


made, waiting for tranvis now...

BTW: of course I got testing before I merged it (you can do it if you comits in a new branch) and after travis was successful has merged it. I want to save a PR for 2 lines changes... But, OK now.


r-

it's not pointless - we don't know we're connecting to same host over and over, a load balancer can put us to a different machine every time. Moreover, if you're connecting with and without TLS extensions it's very likely you'll get to a different virtual host as then you can't send the SNI. Finally, in SSLv2 you won't get an intermediate CA certificate, and you want to know which one you get


收到 :)


こちら漏れていたようなので修正お願いできますでしょうか？

```html
<li v-repeat="user in users | filterBy searchText in 'name'">{{name}}</li>
```
https://github.com/vuejs/vuejs.org/commit/2b3e0ad11bc2b711a599941155410e7b2aa5c292


From what I've found, it only validates it if both `unique_together` fields are in the form, which organization is not. Maybe someone with more Django prowess knows a better way?


margin-bottom: 1px;


hi


These output values are incorrect


.availability-grid-slot-name {
   line-height: 29px; >> 30px;
   padding-left: 15px;
 }


Should this be ```!v.isSelected```?


Looks like you are using spaces for tabs. It would be better if you can use tab characters.


@danielweck
Oh yes, I forgot this was auto generated. Thank you for taking a look at this.
I added this when I was integrating a new test framework for readium-js: https://github.com/readium/readium-js/blob/feature/intel-contrib/spec/reader/reader.html
In that bootstrapper it uses a "no optimize" configuration. I ran into an issue that when this file is shimmed by requirejs it wasn't capturing the exported variable properly, adding it as an explicit window property fixed that.

In retrospect I might not have hit that issue if I had the same script block from what you pointed out here: https://github.com/readium/readium-cfi-js/blob/master/dev/index_NO-RequireJS.html#L7


This makes the json file invalid. That's not how to do comments in json.


I guess that makes sense, since there's no way for the form to know what field the error should be displayed on. Cool. Good work!


r+


you're reading in my mind :)
(I was just looking at code that was using `ALLCIPHERS`)

r+


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _groupFunction


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for groupAction


**Eslint**: 'return' outside of function


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for orderAction


**require-jsdoc/require-jsdoc**: Missing @param description in the jsdoc for selectionAction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for facetClickAction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _selectionFunction


**require-jsdoc/require-jsdoc**: Missing @jsdoc for _orderFunction


this is not necessary, the method using this only needs to worry about applying the coupon code not asserting discounted total


Yay for this!


they can be used by inherited classes


Here you are using 2 spaces as indentation. While at line 46 there are 4 spaces, even for generated C code I would suggest using consistent coding style:)


OK, I'll rename it back.


TeamCity pull requests :: netty-tcnative [Build 4](https://garage.netty.io/teamcity/viewLog.html?buildId=1222&buildTypeId=pulls_netty_tcnative&guest=1) is now running


Sorry i was really fucking tired :p


Isn`t this a duplicate of the code below it?


TeamCity pull requests :: netty-tcnative [Build 4](https://garage.netty.io/teamcity/viewLog.html?buildId=1222&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:42


Good catch


r+


please disable it here only, and keep it enabled in the kernel config, just for people that want to tweak their phone. having a choice is good right :D


This was responsible for the missing towers outside of phi ~0. The previous cellreco was good for the old hcal - the new hcal versions (inner and outer) need the PHG4HcalCellReco cellreco.


Good addition!


looks like you have `DOWN` in this object twice, just fyi :beer: :beer: :beer:


Command line should override the XML. In the case of ignoreUnusedConfigurations, the value is being used here to try and constrain the values. As you pointed out, this isn't a good place to do this, so I'll move this out of here.


Because it's sending everything to Google then. Having a hard stop is IMO preferable, but may cause issues. We'd need that config to be global, because adding an option to every library doesn't sound like a sensible solution.


102817062_MultiSpeedFan (Nigusse) - x86_64-MacOS-10.9-clang: OK (1832 of 1832 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


all of your lines works
Yes you can use { } for all initialisations
You don't have to do it, but it's better (to avoid many bugs)


rip.


Screenshots:

v0.12.0.x UI

Standard Wallet Interface - http://screencast.com/t/zU1PqnmTu9m
Standard Wallet Interface / Watch Address - http://screencast.com/t/9VSRxtvU5q6X
DRKBLUE Wallet Interface - http://screencast.com/t/cuGfTnW61
DRKBLUE Wallet Interface / Watch Address - http://screencast.com/t/damduoW7A

v0.12.1.x Updated UI

Standard Wallet Interface - http://screencast.com/t/LR2PpQukupc
Standard Wallet Interface / Watch Address - http://screencast.com/t/U1fmUnrizQ
DRKBLUE Wallet Interface - http://screencast.com/t/EkESrd1rx
DRKBLUE Wallet Interface / Watch Address - http://screencast.com/t/R14urcKmbtwh


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 549](https://teamcity.labkey.org/viewLog.html?buildId=270741&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 30, passed: 9 Build time: 00:25:39
### Failed tests
```
org.labkey.test.tests.CDSMeasureStoreTest.testDemoMeasureStore: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 20 more failed tests, see build details
```


So I built the current ARM-22-Stock package with Drive reverted.  After flashing, I don't have any noticeable issues (running the older APK on the newer database/settings).


We don't really need the auto-generated file comments here, instead we could go look at git history for those information.


mhm


This function for some reason was repeated when I rebased, I've removed it in the last commit of this PR.


Forgot something?


Tu coś będzie zmieniane, jak mniemam? :) Jak będziesz zmieniał, to zrób nowego komita z daszkiem, to będę wiedziała, że trzeba go wciagnąć do tego komita.


We don't really need the auto generated comments here, we could instead look at the git history for those information. Looks like each file contains those information.


I will do it after the code won't change anymore.


Oooo, widzisz, jak ładnie?:) Chyba tak będzie czytelnie, powstanie taka mała dokumentacja.


![0e6c12e42465076d0afce605098fc4aa](https://cloud.githubusercontent.com/assets/618246/9741428/b9cfa534-565a-11e5-9cbd-e8bb38826416.jpg)

r+


The comment at the end seems a little redundant. The code is very self-explaining already.


Minor: can we rename this to ```rbd_journal_default_object_pool```?


Okay. Note that this means that the signature algorithm displayed at the
conclusion summary, after the cipher list, is not guaranteed at all to be
accurate - is that a known/accepted thing?

On Tue, Sep 8, 2015 at 9:36 AM, Hubert Kario <notifications@github.com>
wrote:

> r-
>
> it's not pointless - we don't know we're connecting to same host over and
> over, a load balancer can put us to a different machine every time.
> Moreover, if you're connecting with and without TLS extensions it's very
> likely you'll get to a different virtual host as then you can't send the
> SNI. Finally, in SSLv2 you won't get an intermediate CA certificate, and
> you want to know which one you get
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jvehent/cipherscan/commit/b1ba6dbbb64fb3648d945c3430942643f79d4155#commitcomment-13116718>
> .
>


:+1: :+1: because one is not enough.


**Eslint**: 'return' outside of function


No, the computer I was using when I pushed had the git user.name set wrong
I have since fixed the problem


Minor: missing space before "for journal data"


Redundant comment.


This is Jon's code. This is a bit weird, because I'm actually passing him the list of mappings, don't know why he's not using it.


I think its fine, certainly works to avoid the post-filtering shenanigans, and not that hard to grasp once you read the code.


r+


All the .js is Jon's, so the honor is his :)


Jeez. Thanks.


Discussing two Epochs here. Can we just say the input can be a "unix timestamp", with all that implies about epoch? In a separate statement we could mention the encoding about 2^31... or leave it out all together and refer to the protocol spec.


el archivo de configuración de modbus ahora se llama ciaaModbus_Cfg.h para mantener el mismo criterio que con el RTOS
Fijate que en el submódulo modbus hay un ejemplo.
https://github.com/ciaa/firmware.modules.modbus/blob/master/inc/ciaaModbus_Cfg.h.sample


Can we move this to librbd/Journal.cc?


LGTM


It's correct, but why change it? just to make lines a single character shorter?


Well, it is a backport of the driver from oneplus one.
So it is not really my credits in a way ☺


I see, thanks! :)


You can use ```stringify(m_header_ioctx.get_id())``` to convert the pool id to a string


pExpr here seems like an expression enclosed in parentheses to me. But it is really just an expression since the parenthesis is generated in the template. Might be better just call it "expr" or "expression":)


I tried reverting this change to see how the new tests fail without it, and they actually pass.  So maybe this is working as expected even without this fix.

I think the reason this actually works is due to com.mongodb.connection.DefaultConnectionPool.PooledConnection#close, which releases the pooled connection like so:

      pool.release(wrapped, wrapped.isClosed() || shouldPrune(wrapped))

And since wrapped.isClosed() is true, the underlying pool will removed the connection from the pool.


it's correct, but why change it?


qué hace esta función?
Agregale el comentario en doxygen.
Si es algo matemático que se pueda reutiizar podría ir:
https://github.com/ciaa/Firmware/tree/master/modules/libs/


This works well to secure the password from the Chef standpoint but we still need to modify the permissions of [`graphite.local_settings.py`](https://github.com/bloomberg/chef-bach/blob/f7b616a1f73361c2920d59af7fda1c4eaa9bb0a0/cookbooks/bcpc/recipes/graphite.rb#L147) to be something more restrictive than 644.


same: why?


why?


I believe this logic is wrong but there isn't a gherkin case to prove it.


These should get added to the restricted names list.


This Go code needs to be `gofmt`ed.


size_t is the same as uint32_t in 32bit builds. In that case, uint64_t would not be available. Why don't you use a template parameter for the iterator?


Numeric comparisons should be done using the numeric (arithmetic) context,
which is what if (( ... )) does here. Input validation is also slightly
more strict on ((, for instance:

```
if [[ "" -eq 1 ]]; then echo yes; else echo no; fi
no
```

```
$ if (( "" == 1 )); then echo yes; else echo no; fi
-bash: ((: == 1 : syntax error: operand expected (error token is "== 1 ")
no
```

On Tue, Sep 8, 2015 at 9:58 AM, Hubert Kario <notifications@github.com>
wrote:

> It's correct, but why change it? just to make lines a single character
> shorter?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/floatingatoll/cipherscan/commit/e98ff1024b69a6da07448a796aa5f60ac07df816#commitcomment-13117191>
> .
>


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.498.c246b4ddeecbbc83a4e6c4fa45bd5ff6ec8377d1](http://build.palaso.org/viewLog.html?buildId=62865&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:05:54


upload website files from previously expired DNS


I'm having trouble understanding this -- does it mean "after first accessing them to ensure they exist."?


Непустая строчка, с одними пробелами.


Hi Roman, i'm not running the paper.remove() function when I'm tearing down my paper, however i'm still getting the issue with the sourcePoint being undefined.  I'm attaching a simple diagram which i've built trying to implement the jump lines.   I'm also including the error i'm seeing...

![turbopatent](https://cloud.githubusercontent.com/assets/1252780/9741727/d600a59a-5610-11e5-8468-43bd5b06a785.png)
![turbopatent](https://cloud.githubusercontent.com/assets/1252780/9741755/082b18fc-5611-11e5-972d-6807786fb2e5.png)


@themightychris Yup, we set that to false and verified it works when we make testing builds. We did verify that seeing it in development is funky and still needs to be looked into.


I think we could/should replace the animation with a css-only animation, in case we want to keep it


It is the first version of Blue Rex android application.
It feature
- Bluetooth device searching
- Bluetooth device pairing
- Bluetooth connectivity

Lags UI optimisation. Needs proper Front End UI designs, which will be added in the upcoming versions.


This renders as "Changed in Django 1.9: " so I usually simply write "In earlier versions, ..."


You're right, you increment in the ```else```. Reading comprehension++


Nice!  how much slower does this make the benchmark? just curious.


Perhaps, use this instead:

> Awesome, but before you [report it to us](https://github.com/black-screen/black-screen/issues/new), make sure you [check whether this hasn't already been reported before](https://github.com/black-screen/black-screen/issues?q=is%3Aissue). If so, you'll need to gather some information by following these instructions:


@jedfoster Looks like this isn't updated on the Web site yet? The code is minified, but I still get this error on the Web site when attempting to view the demos in IE8. Within my own project, I get no errors running the latest, but in IE8 the "read more" link seems to do nothing...


r+


Si, pero la rama del bootloader usa todavia la version vieja. Falta hacer un merge pero le voy a pedir a Esteban que me de una mano.


A release note for this commit could be appropriate.


sure why not


I have questions on the two commits here @wibeasley.
[x] Did we do this commit from the excel directly? Or did you right the code on R?
[x] Do the changes made here automatically corrects for mistakes on the excel and vise versa?
[x] You need to explain this commit to be though i have an idea whats going on here.

Thanks


Ok, great :-)


I have questions on the two commits here @wibeasley.
- [x] Did we do this commit from the excel directly? Or did you right the code on R?
- [x] Do the changes made here automatically corrects for mistakes on the excel and vise versa?
- [x] You need to explain this commit to be though i have an idea whats going on here.

Thanks


What are these hooks for?


@stefanpenner minor cleanup we could have done is add `Set.union` so these two loops become
```js
new Set(aKeys).union(bKeys).forEach(function (key) {
  setKey(result, key, a, b, options);
});
```


This seems dangerous to ignore the build exit codes. How we will know when the build is failing?


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.478.390a557cd11a85c4021d6a2cc1df6f05c42d4eea](http://build.palaso.org/viewLog.html?buildId=62866&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:10:03


In case you didn't realize, this is a reference for "Ensure we pass in unicode" that was moved in your earlier commit to `atexit.register`. Seems a bit out of place to remove it in this commit.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.500.9afc07fd5da3a1293350f1df95a254e5641c71a7](http://build.palaso.org/viewLog.html?buildId=62868&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:05:10


Cuál es la idea, usar solamente el transporte de modbus o todo el stack (master, slave y transport)?


I've run into this "problem" a couple of times - thanks for addressing it!


**Eslint**: 'return' outside of function


This isn't really specific to the CASS_DATE encoding. :)


I still don't get it. You should probably call this 'All invoiceable lines' to make it clear compared with the next option.


nfghgjxhj


fgGfd


Can someone explain to me what good these `inline` decorators does on a function prototype? The actual functions are coded in ec_packet.c. So how can these end up being inlined? TDM-gcc 5.1 warns on this:
```
./include/ec_packet.h:113:26: warning: inline function 'packet_destroy_object' declared but never defined
 EC_API_EXTERN inline int packet_destroy_object(struct packet_object *po);
                          ^
```
 Just drop them IMHO.


Specifically, they need to define an appender called APPS.


That's @rstata's line, but I think he meant ODP Platform.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.499.390a557cd11a85c4021d6a2cc1df6f05c42d4eea](http://build.palaso.org/viewLog.html?buildId=62867&buildTypeId=bt223) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3317, ignored: 140 Build time: 00:14:14
### Failed tests
```
Palaso.Tests.dll: Palaso.Tests.Progress.ConsoleProgressTests.LongRunningMethodUsingConsoleHandler_ProducesLog: <no details avaliable>

```


I would squash this into the commit where it's used. Do you think it's a candidate to be documented at some later time?


According to [this](https://golang.org/doc/go1.5#net), DNS changes were made in go1.5. However, it says that windows behavior shouldn't have changed.


Usa todo el stack del lado slave, pero como capa de transporte para un protocolo de nivel de aplicación.


Both headers appear to be unused.


102817062_MultiSpeedFan (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1838 of 1838 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I love auto! However, g++ doesn't have a good history of resolving loop variables with auto correctly. We should probably make this size_t


@abarisain Could I please get a review for this? I don't want to rebreak RTL and I really have no idea what I'm doing =)


Please add documentation what happens in redis when the message has been received via IPv6


102817062_MultiSpeedFan (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1838 of 1838 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Iet's talk about this on gitter (or skype or whatever) :-)


In my opinion, if it is necessary for a class to have certain methods or constructors that shall only be callable from inside the library, one can forward-declare an opaque struct, usually aptly named `struct internal_use_only;` where the body (which is empty, as in `struct internal_use_only {};`) only occurs inside the library code and not in the library public include header. This way it is not necessary to workaround null pointer checks, where there is a chance where `0xEEEEEEEE` might actually be a legitimate input value.


`while data.present?` and `until data.empty?` are not the same.
`present?` exists on `Nil` and `String`. So, the more correct version would be:

``` ruby
while data && !data.empty?
```


the jsoncpp stuff is a third party dependency so we don't want to manually change it, we'll likely repull from the jsoncpp project. Was this a compile error or style change.

Also was the QueryString stuff style or was this a build error you were fixing?


En el bootloader solo se usa la capa de transporte. No pierdan de vista que el bootloader es una application que ejecuta en la CIAA unicamente cuando se quiere hacer una actualización, y que tiene por misión únicamente recibir y grabar la imagen.

> On Sep 8, 2015, at 14:15, FrancoSalinas <notifications@github.com> wrote:
>
> Usa todo el stack del lado slave, pero como capa de transporte para un protocolo de nivel de aplicación.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ciaa/Firmware/commit/c56f696533ef777010515f6c9188aefb915f2fc6#commitcomment-13117574>.
>


This file fails to compile here with a recent OpenSSL:
```
src/ec_sslwrap.c: In function 'sslw_create_selfsigned':
src/ec_sslwrap.c:1107:13: error: dereferencing pointer to incomplete type 'X509_EXTENSION {aka struct X509_extension_st}'
          ext->value->data[7] = 0xe7;
             ^
```
I think it's been some time since one could directly access a `X509_EXTENSION` structure like that.
Even with `OPENSSL_USE_DEPRECATED`. What could be done with that?


Is the name "SerializeTo" adequate?


Oui en effet c'est à mettre au masculin


**Eslint**: 'return' outside of function


**valid-jsdoc**: Missing JSDoc @returns for function.


Looks good. Don't know why this is all in a linear layout, but it's ok, it matches _port :)


I'm hesitant to specify how because I'm concerned about limiting the potential here.  For example, if this spec is covering stuff like Windows, then it might a registry sending.


Set a useful default for OpenShift - 30%


It would be great to add a note about this to `docs/internals/contributing/writing-code/unit-tests.txt`.


A comment would be useful. Also extra space after "(".


Set a useful default for OpenShift: 90%


Oui on fait ça depuis un an.
Mais peut être que depuis le support de l'UTF-8 à été amélioré suffisemment pour ce le permettre.

On va tester comme ça en jeu, on corrigera s'il y a des soucis, sinon, on mettra des accents partout :)


Looks


I am not sure, whether the profile is invalid without firstname. It should be valid. Does the test pass? :scream_cat:


Not noticeably actually 😎


this function should be static, unless used outside of rgw_client_io.cc, in which case should be named differently (at least prefixed with `rgw_`)


why is this here?


nope :)


:url not all caps


For a local build where the application is outside the repo. See https://github.com/spark/firmware/blob/develop/docs/build.md


Woke


rename column


yes, the sigalg is expected to not be accurate, but we do collect sha256sum's for the certificates which then land in json and those are *very* important


spacing


note for me: fixed.


You need to change obj.taskName to obj.taskId here too.


delete all these randoms...


remove space :)


proposal: `return os.environ.get('DJANGO_TEST_PROCESSES', multiprocessing.cpu_count())`
If we agree on that (open to name changes), we can add `export DJANGO_TEST_PROCESSES=2` to the pull request job.


That’s what I originally thought too. However, from the article you linked to:

<img width="760" alt="2015-09-08 at 6 22 pm" src="https://cloud.githubusercontent.com/assets/296432/9742179/91e960ea-5656-11e5-8326-f8e8674523b2.png">

In other words, relying on submodules isn’t possible when using the "deploy to heroku" button, which the mechanism this whole repository is based on. Unless something has changed on Heroku’s end since Dec 2014, we can’t put this in a submodule. :frowning:


@jmunhoz I'm confused about this commit. Why do we need to read content in advance?


add: (this is all the built-in backends except for Oracle)


убрал \


What is consuming these hook scripts though? AFAIK this isn't a Docker thing.