I'm not sure if this is useful, the below call to `this._page.base` since to be enough on my browser but maybe `basePath` is used for compatibility with old IE?


nice


this should be in the database.sql and in 4_2_0-to-4_2_1_upgrade.sql


Yeah, no problem. I will circle back round and take a look at it later.


This should be facility information


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - i386-Windows-7-VisualStudio-12: OK (1878 of 1880 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


needs to have the standard copyright header


Again this probably needs to be facility information and is this file really needed


这行不对，你应该用 `outIntensity.set` 去赋值，你这样只会产生一个新的指针


Needs translation echo xlt('Something went wrong');


why not just f.setType(ctx.type())?


then else clause is not needed really


This information seams to lack relevancy to OpenEMR


Fixes #28


seems like these ctors should be converted to subclasses if we need to distinguish. this plus code in enterBlock seems much too complicated. i wonder if there is a way to have a single ctor here for any local block.


can't have a local scope nested within global. Only func is nested in global, right?


i like having the scope here :)  is it depth or unique scope number?  Not sure which is better.


why isn't it symmetric? `if ((x == 0) || (x == 1)) {`


comma splice; consider replacing with semicolon

love this comment by the way, spot on


Is this used in the credit card processing


or, any even non-dependent functions


Translation


semicolon or period


For indentation we use spaces instead of tabs. Please replace these tabs with spaces. Then I can accept your pull request.


because ctx.type() gives a context, not a type.


Can this be combined into one file with some of the other smaller files


deleted


No problem actually, the property is public anyway. It can be tweaked.


Facility information


What exactly does this feature do?

If you look in [the script](https://github.com/rfkrocktk/docker-puppetmaster/blob/develop/scripts/12_generate_puppetmaster_keys.sh), we generate keys based on this environment variable by default. What does adding this line to the configuration do that isn't already covered?


test


I was asking in Slack whether we should have WBlock extends WFunctionSymbol, that way we can have a single ctor.


Our grammar allows local scope within global, because statement can be a block


I will take a look tomorrow and give you feedback


Can this take into account other currency types. May be needs to come from Globals using the Currency Designator


It is the unique scope number here.


(I did that.)


(Done.)


Removed template, and passed the rest explicitly.


OK, that's better.


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1878 of 1880 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg)


I have a few questions:
Why is anything spam checking at this point?
You replaced m_LastSpecialTime with m_LastMobSkillTime so I am wondering what the diff is / what necessitated both existing?

I have to ask because I am sh** with stuff in core for the most part. :frowning:


Yes this will fix most problems with the aspect ration but MPEGTS is slow on Vizio ;)
I usually use PS because it works fast and well but force

KeepAspectRatio = true

Fixes both on my Vizo


#4298-Recurring-error-with-Heat-Exchanger-when-using-cycling-fan-system (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


weird indention here, no?


Translations


Can this config file be placed with others so those who come later won't go hunting for them


Fix for msys installation script break due to syntax.
![1442799612](https://cloud.githubusercontent.com/assets/13444519/9984130/477643dc-5fe0-11e5-9fa5-8054a8d64461.png)


Is this the full interface definition? I think it would be useful to have it here if it's not too large


To keep the core simplier.

Form generator is only used when you bootstrap a form engine in dev. No need to use it on prod. So it's now extracted, we probably should do the same with the engine generator.


“Omit the protocol portion (http:, https:) from URLs pointing to images and other media files, style sheets, and scripts unless the respective files are not available over both protocols.” - from https://google.github.io/styleguide/htmlcssguide.xml?showone=Protocol#Protocol

The resource has to be available over both protocols and //sfpc.io is not available over https.


I added that because the build breaks if you have git installed without the .git/ folder


Depending on versions from `master` which may change in incompatible way is very dangerous, especially when this applies to regular dependencies. Why can't all those packages be published and regular versions be used?


Hello. Well, I believe with the welcome controller created in this commit I could simply add a line to the routes.rb file as follows: get 'home' => 'welcome#index'


No it is not


This is still under development and will be removed because it is an out of date SDK.


This is why I don't push commits at 2:30am. Accidentally put the :wq command from vim in the commit name. :(


@myechuri does apply_profile kick off during the creation of a volume? Should we keep login in create_volume?


@RandQalan what do you mean by "fast"? If that setting transcodes slowly, you can try:

TranscodeVideo = MPEGTS-MPEG2-AC3


cool


android程序员前排留名←＿←


Thanks! I think this blog post may signify my mind changing on equality if this sentence is any indicator :)


Will move to new location


I suggest doing this check in python rather than in javascript, by adding a `try: except:` to the statements built up in `code`:

```
    code = "try:\n  " + code + "\nexcept (KeyError, AttributeError):\n  ...set the result to js.undefined..."
```


So there is a bug where if a mob has tp moves but can't use any of them (onMobCheck fails), then it will go into a continuous loop trying to use it's skill, this will crash the server. So I put in a delay that slows this down and fixes that issue.

There was an other issue with despot spamming tp moves, so this had a side effect of fixing that issue too.

`m_LastSpecialTime` is used to track the last special action done, this could be a ranged attack, jump, call beast, cannon ball etc. These have delays that should be independent of regular mobskills. So I decoupled them, you should to use a mobskill and then shortly after possibly respawn your pet if you were a bst.


Thanks Ben.


Not the transcodes but the menu on Vizio is slow it takes awhile to load into or out of folders

whenever TS is in use

with what I posted takes only seconds to load the menu and runs them fine but yes H264 has higher quality but the time to just load on video is worth the little lose


This array comes after the charge has been processed. Will more than likely remove since not really needed.


Ok Edgleyson vou clonar o repositorio p/meu PC e trabalhar nele.  Bons estudos.


Why have you included composer.lock in the project? This way it does not install everything needed because it presumes it already has them.


А вообще, если есть ```Nulable<type>```, оно проверено на null и нужно получить значение ```type```, используй свойство Value, например ```brightness.Value```


Caraca, eu tava pensando em fazer dese jeito, mas não sabia como hahaha valeu K3y!!!


Упс, про изменение типа переменной - некорректный комментарий - перепутал с номером канала.


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1872 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.svg)


close #1


Already did.  tmpvar/jsdom#1241


A good idea! But this should be 33.33% shouldn't it?


Why? you won't be able to work with this diagram any more


Лишний импорт?


PS: adds 72 bytes to occupied flash on AVR


Да, ты абсолютно прав, я проверил - из-за переводов строк "EN | RU" переносится на другую строку. Моя ошибка - исправлю.


Таблицы в БД обычно называют в нижнием регистре (и используют `_` для раздления слов).


fixes #18


TODO: improve these regexs, using the following stolen from PHPCI (sorry Dan!)


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


LGTM


@jpcaruana regarding your problem, I must say I have no clue. I'm going to investigate to see which thread pool causes the problem.

Regarding your fluent api, it is a good idea, however not all underlying http server implementation will respond to this api. It's really a simpleframework thing.


believe me


@meip: no filter here?


Недавно на StackOverflow нашел вот такой трюк:

```
    <a href="${enLocaleUrl}">EN</a><!--
    --> | <!--
    --><a href="${ruLocaleUrl}">RU</a>
```
Благодаря комментариям там не должно появляться пробелов и должно работать. Это я тебе для информации сообщаю, какой вариант выбрать решай сам.


# BulaqCMS  بۇلاق مەزمۇن باشقۇرۇش سىستىمىسى
BulaqCMS بولسا ئۇچۇق كودلۇق مەزمۇن باشقۇرۇش سىستىمىسى. خالىغانچە ئىشلىتىشكە بۇلىدۇ.
**ئورگان بەت ئادرىسى: [http://www.bulaqcms.com](http://www.bulaqcms.com)**


fix typo: please delete one " l " (ell)


1) Ok, these informations were not public.

2) Both `>=` and `==` and have their justification, but different use cases. Use exact versions for reproducible environments, like deploying apps on heroku. You can't control what versions might be available in other environments -- don't set any restrictions unless you must (i.e., if you know that it doesn't work before a specific version) e.g., put yourself in the shoes of a package maintainer for a distribution: it might be useful to know (e.g., by visiting CI site) what exact versions are tested 1.9.0 but it is best if your package supports the current/future stable versions i.e., six>=1.7 is ok.

Slightly adapted from: https://stackoverflow.com/questions/32680603/python-package-requirements-usage-of-version-specifiers-and?noredirect=1#comment53212703_32680603


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 54](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=181&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:30:52


fix space please


> regarding your problem, I must say I have no clue. I'm going to investigate to see which thread pool causes the problem.

ok. Maybe we will need more logs. I'll activate debug level and retry.

> Regarding your fluent api, it is a good idea, however not all underlying http server implementation will respond to this api. It's really a simpleframework thing.

maybe a builder class would make me happy (trying to write one)


Не сразу, конечно, понятно зачем комментарии, а идея прикольная.


@Tratcher There's a problem with this change. This port needs to be added before going to the server. The problem is that the server will still try to bind to a default port if none was specified. This leads to failures when multiple instances of the app is launched (even with different HTTP_PLATFORM_PORT values)


1st Comments


В комментариях хорошо бы указывать для чего ты делаешь это изменение, какая у него цель. Иначе может быть не ясно стороннему читателю. Ну я-то хотя бы помню, что ты так XSS пытался побороть..


maybe add print with user-friendly error to indicate what went wrong?


А `@NotBlank`-то за что удалил?


> I have to say that I don’t like the effect. It’s blurry and not the way I remember Doom in the 90s (at which feeling Doom Retro aims). On CRTs there was no blurring. I can change it so it’s not some kind of game breaker, but I would run some test on more people before setting it to the default value. If it was the only option I guess I would change source port. And so some less experienced players, and without more complex settings in game, might feel the same way.

You do make a good point. And maybe I will end up keeping the "nearest" filter the default. But, can I ask what resolution are you using? A few tweaks have been made since the last beta - can you try the following and see if it's any better for you?

https://www.dropbox.com/s/m1lhitbweft0n7t/doomretro-1.9beta3-win32.zip?dl=0

> Personally I would replace the graphics quality toggle with a cvar. And in its place put a scaling option to switch between the three and applying them on the fly so the user sees the change with one keypress. It's harder to do from the console since the available options are not listed.

I still want to keep the options menu as vanilla as possible. Everything else goes through the console.

> Who the hell uses 320x200 in this port?

I know at least one user does. They had an issue with one of my commits that would have changed the low detail mode slightly.


1) ok
2) so, lets keep with ==


up


Yes, amended and pushed.


great info.. thanks cocolino


fix typo: `holdes` -> `hold`


test


could a std::set provide any benefit compared to std::vector ?


:fr:


В итоге, по логике нам нужно сделать время жизни куки как можно дольше. Я думаю один год (3600*24*365) будет нормально?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20963/testReport/) for this commit**


Would something like that do the trick?

```java
public static class ScalableWebServer extends AbstractWebServer<ScalableWebServer> {
  private int count = 8;
  private int select = 1;
  private int webSocketThreads = 10;

  public ScalableWebServer withCountThreads(int count) {
    this.count = count;
    return this;
  }

  public ScalableWebServer withSelectThreads(int select) {
    this.select = select;
    return this;
  }

  public ScalableWebServer withWebSocketThreads(int webSocketThreads) {
    this.webSocketThreads = webSocketThreads;
    return this;
  }

  @Override
  protected HttpServerWrapper createHttpServer(Handler httpHandler, WebSocketHandler webSocketHandler) {
    return new SimpleServerWrapper(httpHandler, webSocketHandler, count, select, webSocketThreads);
  }
}

new ScalableWebServer()
      .withCountThreads(2)
      .withSelectThreads(2)
      .withWebSocketThreads(1)
      .startOnRandomPort();
```


Should it be "have been renamed and now all start" without the "to"?


Here what you want to use is `isPlainObject`, not `isObject` -> otherwise arrays are included.


Что-то совсем страшное тут произошло с форматированием.

Классно, что ты нашел `HtmlUtils`, но это решение все равно не очень красивое, хотя бы потому что такие эдиторы нужно будет много где добавлять вручную -- в каждом контроллере.


What does `w/` mean? Maybe typo?


If order is not needed, it's more efficient to use `std::vector`, as `std::set` guarantees an order that adds little (not needed) overhead.


The GUI I'd slot is for a per-session uuid. Imagine a future where multiple users will connect to a given server with the same client code. We need a way to disambiguate clients. :)


Should be one more space and `$params`.


Thanks! Didn't know this one :)


I'm not sure that's backwards-compatible? Config history diff view had lots of issues with timestamps vs. file names to begin with.


The official client generates a new uuid on launch which it uses for all OSC comms.


yes ! (I was writing the same class...)


Should one more space between `array` and `$matched`.


std::unordered_set then ?


Should two more space between `array` and `data`.


Becuase $city has not been initialized, you need to declare $city = ... (something) before than use it


I assume there is a reason for this, but I don't see at the moment. Why don't we just iterate over the edges, e.g.

```
for (state_i, sym) in sg.edges.keys().iter() {
    match sym {
        Terminal => Shift,
        Nonterminal => Reduce
```
This way we don't have to check every possible symbol for every state.


2) For the REQUIREMENTS file, I don't object. For setup.py I do, as it defines minimal requirements, see https://packaging.python.org/en/latest/requirements/#install-requires
So I am for a revert of 1183c2799e4efdec45e19e9dbfd4f8ccc58ed705 I'm unsure about eb98fd9f490ab30097a49b9267d56d956382c060


@marcelmueller82
Looking good so far!
Thanks for taking time to understand the DataContainer (we need to make this more simple so its easier to understand for folks who are new to the plugin) and results handler stuff.

A couple of insights into the plugin design.

1) Perhaps dont use the IJ.log to output status messages, because we are outputting results data into there, and the status message would be weird in the middle of all the numerical results.
Perhaps use the IJ status bar instead?
Later, when we convert everything to ImageJ2 data structures, we wont use IJ.log.... but rather IJ2 text results window or something more appropriate.  Our use of IJ.log for results was a quick and nasty hack for patch processing, but I need to do it properly and stop abusing the IJ.log

2) I am no expert... but perhaps imglib2 allows you to nor have to make arrays by yourself, as imglib2 already treats the image data as arrays???? Maybe it saves a little work? I could be totally wrong here...

3) In several instances you need user input variable.
a) Do there tend to be any general sensible defaults for those, or does it always depend on the input data?
b) for now we can just add those as text input fields, like the Costes PSF parameter, in the Generic Dialog in the Coloc_2.java input GUI.  We are going to totally re do the input gui at some point... with swing and tabs and imageJ2 @ parameter fields and all kinds of goodness to make this stuff nicer.
Watch out: Make sure whatever you put in the Generic Dialog is macro recordable... eg. don't put "" in the text labels of the fields.

4) General things like the variance calculation would be a nice addition to, perhaps,  imageJ ops. Maybe you can even reuse or enhance:
https://github.com/imagej/imagej-ops/blob/master/src/main/java/net/imagej/ops/stats/IterableVariance.java
I don't know the details... its just a thought ;-)


After some delays over the summer we have finally started to run our IT support classes again.   At the moment we are using laptops but i the near future we will be changing to tablets!! Cant wait.  We will be posting an update on this page once everything is in place.


Meiner Meinung nach können wir die defekt-Funktion nicht so lassen.
Das Problem ist, dass wir in der Funktion nochmal extra den Vektor Ax anlegen müssen, was zusätzlich Speicher verbraucht und nicht zwingend notwendig ist.
Kann sich das nochmal wer angucken?


dit kan natuurlijk niet he


Good point. I've added some tests around the behaviour of `NodePresenter#error` in 230ea831955d5127000e9ce58a4107ef26af19b6 and updated this commit message accordingly.


If you think there is a better solution than "if (url == normalizeRoot(''))", tell me! Thx.


fix typo: `$file` -> `$files`


Because really, you are not using this class (NotFoundHttpException) inside any action of this controller


"==" Fixed in the next commit.


Good point. Let me give it a go.


Agreed. I've made this change locally.


Of course. I think I screwed up as a consequence of merge conflicts and kept the old paragraph instead of the most recent one.


This commit is being reviewed as a part of review issue #66.


Needed to move `CurrentBranch` into another package to break an import cycle.


This piece of code is not working. I'll see if it can be done


I am curious why you haven't configured std::string methods etc yet. You do know you can, don't you?

For instance std::string::find can't take an uninitialized variable..

    <function name="std::string::find">
        <arg nr="1">
            <not-uninit/>
        </arg>
    </function>


Ah, I see why I can't do it in this branch: there's no sane way of saying "give me all the edges for this state". But in the GC branch, I can do that easily. So I suggest we temporarily ignore this comment (for this PR). Once the GC branch is merged, I'll do another PR that integrates the change you suggest. OK?


両方あればOKかしら…？


Although I just realised then we still need to iterate over all states anyways for the reduce. Because reduce is not contained in the edges. So we need two loops, one over all states for Reduce/Accept, and one over all edges for Shift/Goto


fix typo: `occured,` -> `occured.`


Right :)


Там, есть -1, вроде бы, чтобы было долго. Я не уверен, что год это хорошее значение. Не забывай о безопасности :) (См. также https://www.owasp.org/index.php/Session_Management_Cheat_Sheet#Expire_and_Max-Age_Attributes)


Let me fix that.


Merged via https://github.com/couchbase/go-couchbase/commit/3b77a41676c2fbcbd0d1e6c3ed49c533a28ac067

Thanks for your contribution. Next time you want to push commits to go-couchbase please do so via gerrit.


done


I would choose the second one, fixed https://github.com/aitboudad/symfony/commit/805acc90478aaba80dbba4e15961b2fb29efa6c7


Ah, I see! no, the dirty flag is not stored at compile time. we could do that though if needed.


Sorry, missed the text. Please advise. "119  <WaveFileNotFound>Извлечённая форма сигла не была найдена!" on ""119  <WaveFileNotFound>Извлечённая форма сигнала не была найдена!" =)


Ah, then I *think* I can do that in the current branch. Let me try.


Although I'm not sure I understand why we have to say "give me all the edges for this states" as all of them are contained in `sg.edges.keys()`, but I'm happy for you to do this in the other branch, if you say it's easier.


I have a feeling that `38768.0f` is not the correct constant here.

I suspect you want `32768.0f` otherwise you will get large amounts of clipping.


@vecna i was looking into the integration of the db support into devel but would first need to understand a bit.

can you clarify me:
- last_repetition_date: what is this? if the idea is to have only one log entry but updated the log_date will log the last_repetition_date withouth the need for this field in all entries. right? so i think we can remove this.

- subject/subject_id; here i think you mixed few things;
if i'm not wrong in case of itip the subject_id contains the tipid
its to me not clear what it does contain when it is admin/receiver.

what is not clear is how this table can allow a single receiver to view only things related to his tips (maybe that that with 'receiver' intend 'rtip'?)

the one you called admin i think i would call them 'debug' cause the role of accessing won't be embedded in this subject variable but the subject should clarify the type of log.
e.g. admins maybe will be able to see debug log plus itiplogs etc.

an other change i would do is making different the name between subject and subject_id as not all the subject would have a subject id associated (e.g. the 'debug' defined above); so i would call them 'type' and 'ref_object_id' cause all log entries will have their type needed to understand what log entry it is and which priviledge is needed to access it based on a priviledge(type) function, while the ref_object_id will be present eventually only for some types.


Can't you just change the type of `posMatrices` in `struct XFMemory`?


Oh, does it work for non-static member functions already? I did not know that either.


There are a problème with your commit:
The service "twig" has a dependency on a non-existent service "knp_menu.menu_manipulator".
Why knp_menu.menu_manipulator public=false ?


Thank you for your fast update to swift 2.0, i was just looking at it and wondering if i should try to update it myself, without really knowing how its done :+1:


You have to `close(ch)` after the Wait, like that the goroutine setting the map will stop also


TeamCity Jarvis Framework :: CI [Build 100](http://build.prxm.it:8811/viewLog.html?buildId=4039&buildTypeId=CqrsFramework_Ci) is now running


Please, update eblob version in dependencies.


Yep vary fast pass! Let's hope for LTC.


making a service private does not forbid to reference it as a dependency. It forbids to get it dynamically from the container at runtime.


Hi,

Thanks for reporting this issue.
You're right indeed.
I've just committed a fix for that.
I did not merge your merged request as I preferred to fix it another way in order have more generic error handling at initialization time. I applied the same logic OCI_LIB_CALL_ENTER/EXIT to OCI_Initialize() that you could find in all other public calls.

Thanks again.

Vincent


However, the id of the service is indeed wrong


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20964/testReport/) for this commit**


http://docs.spring.io/docs/tmp/com/interface21/web/servlet/i18n/CookieLocaleResolver.html#setCookieMaxAge(int)
Как раз наоборот: (-1) - это non-persistent cookie, действует опять же до закрытия браузера.
Про безопасность я понял что имелось ввиду, но, думаю, куки о том какая у пользователя локаль не представляют ценность и никак не компрометируют его.


Так нельзя. id инфоблока нужно сохранять


what happen if there is a filter set by the user on participant-phone, will this default filter still stays in the conditions?


TeamCity Jarvis Framework :: CI [Build 100](http://build.prxm.it:8811/viewLog.html?buildId=4039&buildTypeId=CqrsFramework_Ci) outcome was **SUCCESS**
Summary: Tests passed: 135 Build time: 00:02:22


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 610](http://build.prxm.it:8811/viewLog.html?buildId=4041&buildTypeId=Jarvis_DocumentStore_CI) is now running


Update не возвращает ID инфоблока, только true или false


very bad code


fix typo: `connction` -> `connection`


Ok. I have simplified it up a bit. The documentation of indentation changes was too detailed.


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (807 of 807 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.59%25-green.svg)


fix typo: `th` -> `the`


Да, ты прав.


I think you need to use just the value of `mSwitchIsInOnPosition` in all of these clauses, as otherwise when the switch is on but has been moved to the off position, `mSwitchIsOn or mSwitchIsInOnPosition` evaluates to true and so it will be drawn in switch on state.


With commit 1f75c6843c343c8af023998cca1d3b06e82f9970 you should be able to write such builder.


fix typo: `remove` -> `remote`


Thanks for your comments I will make the codes better the next time.

*José Carlos Mayoral Baños*
*Student in Autonomous Systems Master*
*Hochschule Bonn Rhein Sieg*
Phone: +4915258191228

On Mon, Sep 21, 2015 at 11:54 AM, Santosh Thoduka <notifications@github.com>
wrote:

> what does this variable name mean?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jcmayoral/LEGOHW2/commit/97e8db1c6ded8fb89057c4604d6a25b6911729e9#commitcomment-13338045>
> .
>


I don't know why this works, but "dynamically" loading './webui/logic.js' resolves the issue of uninitialized fields in Google Chrome.


Only add Roger Clark ( STduino ) Core


Да, все правильно. Не там откомментировал.


Good idea.


That's exactly how I imagined it. :+1:


@Arthur2e5 @Mingcongbai

Got it. I will not proceed before you get it right.

BTW @Arthur2e5 DO NOT ALWAYS THINK THAT EVERYONE KNOWS SO MUCH LIKE YOU. Use polite words.


Extremely minor, but the `isFunction()` checks could be done inside `setValidIdentifierCharacter()`.


Thanks for PR. Instead of comparing PHP versions the better approach would be to check if `getExtension` method exists like so:

````
if (method_exists('SplFileInfo', 'getExtension')) {
    //
} else {
    //
}
````


@lukasinko:
- Choose one naming convention for log messages and use it. I can find three different conventions in this pull request: "..was't found", "was not found", "not found". Use either the second or the third variant.
- Log messages should be the same for all containers. You can create shared method which will test the result (e.g. getLogDir + getLogDirInternal)? Do not define error message for each container.


Then you can simply add "virtio_ports =" in guest_os.cfg.


Perhaps just move this import into `JenkinsTestServer.__init__`? That way it's explicit where it's being used.


Really neat idea Rocky & Stefan


I wonder if we could find a better name, because reading the current name, I expect to literally set the characters (e.g. an array of valid characters); but I'm not good with names anyway :)


Likewise with pymongo, redis and rethinkdb.


You should put this in the `Performance` test category.


erfwfew


Nitpicking: Single quotes for consistency (here and below).


origin :v1.2.0


@lukasinko Put both reader and writer into one [try-with-resources](https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html) block. Do not close them manually!


The cov behavior (`npm run cov`) is not the same:
- before: remove the coverage directory AND execute isparta
- after: execute isparta

Is this a mistake?


fix typo: `sersver` -> `server`


Hi Dominic, thanks for sharing!
But can you explain what I should do with this files? Just I have an index.html already in game folder... and when I try to merge this files, analytics works but the game no... Only 2-3 words more in description about how to use it...


INTEGRATION TESTING_2015-09-21 13:46:52


fix typo: `anser` -> `answer`


This app is helpful in understanding following:
- How to capture an image
- How to obtain location using Google's Location services
- How to convert longitude and latitude in an address.

Note: This app doesn't update location rather uses the last known location. Will fix this soon.


this file deserves better


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 610](http://build.prxm.it:8811/viewLog.html?buildId=4041&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 291 Build time: 00:12:04
### Failed tests
```
Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_password("v2").verify_tika_job_with_password: <no details avaliable>

```


TeamCity Jarvis Framework :: CI-GitFlow [Build 46](http://build.prxm.it:8811/viewLog.html?buildId=4042&buildTypeId=CqrsFramework_CiGitFlow) is now running


@SherwoodCH I would prefer to have shortcodes instead of a general filter hook on the_content. Can you refactor your code to use the shortcodes API?


This commit is being reviewed as a part of review issue #67.


Should be `===` or `empty(get_option('permalink_structure'))`?


Only `!` is used as a comment character in modern syntax.


I don't think that this compiles on all platforms. According to the Python doc ( https://docs.python.org/3/c-api/init.html ) you should use https://docs.python.org/3/c-api/sys.html#c.Py_DecodeLocale instead. An example how to use the function have a look here: https://github.com/python/cpython/blob/829b49cbd2e4b1d573470da79ca844b730120f3d/Programs/python.c#L55
But there is one minor remaining issue that we have a memory leak here.


:DDDDDDD


_"we would always have to calculate `codePointAt`"_ and _"another function call should be slower than an if"_ were convincing enough. Let's leave it as is :)


let the world see


fix typo: `functon` -> `function`


btw nice indentation boi


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20965/testReport/) for this commit**


When trying to build hxcpp I get the following error:
```bash
neko run.n Build.xml -Dmac -DHXCPP_M64 -Dstatic_link -Ddebug project/
Called from sys.FileSystem::$statics line 1
Called from RunMain::main line 98
Called from RunMain::executeHxcpp line 92
Called from neko.vm.Loader::loadModule line 132
Called from sys.io.Process::$statics line 1
Called from BuildTool::main line 1212
Called from BuildTool::$init line 28
Called from a C function
Called from BuildTool::new line 154
Called from BuildTool::include line 1595
Called from BuildTool::parseXML line 1481
Called from haxe.xml._Fast.AttribAccess::resolve line 56
Uncaught exception - set is missing attribute value
#### Error building neko -Dmac -DHXCPP_M64 -Dstatic_link -Ddebug
```

I can build the [previous commit](c347d191c1e4ac9ac72ff90bd56cdb4a41702def) with no problem


Use ImmutableMap builder to initialize map and pass it to newHashMap():

http://stackoverflow.com/questions/7345241/builder-for-hashmap


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.1.1](http://build.prxm.it:8811/viewLog.html?buildId=4042&buildTypeId=CqrsFramework_CiGitFlow) outcome was **SUCCESS**
Summary: Tests passed: 124 Build time: 00:03:58


id.getClass() called two times. Extract to variable.


> This piece of code is not working. I'll see if it can be done

Now I remember (I erased my short term memory during the week end...), that's why I proposed this PR.

> With commit 1f75c68 you should be able to write such builder.

OK I'll test it. Thanks.


oye dónde esta el @mod o mejor lo binarizo yo??


We probably need to return something more meaningful to null command IDs. We want nulls being visible in data.

How about "NULL"?


fix typo: `autoloder` -> `autoloader`


@lukasinko Do not use apostrophes. Use e.g. "Failed to write container standard output"


Tune this 8 values with SPSA. I think this is a very promising.


This class must be a part of CommandId infrastructure. Move it to Commands utility class.

We don't want to couple Entity class with the rest of the system.


Move this class to Events.


>> I think you should only test the messages that match the actual case: Since matcher doesn't match the code, only the failure message is relevant here.

I don't follow - we set both messages together. In fact, they are tied together, so why does it matter? What kind of test do you have in mind?


Yeah you need to rename that variable to `cancel_orders`.


@lukasinko Add abstract method getBasicCommand returning String or NULL (use javadoc). If not null, check it, otherwise skip it. Logic should be shared. This cycle is duplicated in WildflyContainer now.


Manually?


oke. thx


jep. ischmer de au ufgfalle :)


ja. sorry


@lukasinko Naming convetions... Use either "container was started" and "client was connected" or "container started" and "client connected".


in view-expense.tpl.html wirds auno brucht :)


ini jangan diapus


More precisely, you can use only 4 values.


Most likely command time and event time will overlap significantly. There will be few events that span over a day, or event a minute.
So, we will reduce the amount of text, if we record only the difference for event time.
There should be special separator that tells that we're recording on top of command time.


---
title: "Reproducible Research"
author: "Azizah"
date: "September 21, 2015"
output: pdf_document
---

This is an R Markdown document. Markdown is a simple formatting syntax for authoring HTML, PDF, and MS Word documents. For more details on using R Markdown see <http://rmarkdown.rstudio.com>.

When you click the **Knit** button a document will be generated that includes both content as well as the output of any embedded R code chunks within the document. You can embed an R code chunk like this:

```{r echo=TRUE}
library(knitr)
opts_chunk$set(echo = TRUE, results = 'hold')
library(data.table)
library(ggplot2)
```

Loading the data
```{r echo = TRUE}
if(!file.exists('activity.csv')){
    unzip('activity.zip')
}
activityData <- read.csv('activity.csv')
```

preprocessing the data

```{recho = TRUE }
activityData$date <- as.Date(activityData$date, format = "%Y-%m-%d")
activityData$interval <- as.factor(activityData$interval)
```

```{r}
# Transform the date attribute to an actual date format
activityData$date <- as.POSIXct(activityData$date, format="%Y-%m-%d")

# Compute the weekdays from the date attribute
activityData <- data.frame(date=activityData$date,
                           weekday=tolower(weekdays(activityData$date)),
                           steps=activityData$steps,
                           interval=activityData$interval)

# Compute the day type (weekend or weekday)
activityData<- cbind(activityData,
                      daytype=ifelse(activityData$weekday == "saturday" |
                                     activityData$weekday == "sunday", "weekend",
                                     "weekday"))

# Create the final data.frame
activity <- data.frame(date=activityData$date,
                       weekday=activityData$weekday,
                       daytype=activityData$daytype,
                       interval=activityData$interval,
                       steps=activityData$steps)

# Clear the workspace
rm(activityData)
```

What is mean total number of steps taken per day
```{r echo = TRUE}
stepsByDay <- tapply(activityData$steps, activityData$date, sum, na.rm=TRUE)
```

Make a histogram of the total number of steps taken each day
```{r echo = TRUE}
# Compute the total number of steps each day (NA values removed)
sum_data <- aggregate(activityData$steps, by=list(activityData$date), FUN=sum, na.rm=TRUE)

# Rename the attributes
names(sum_data) <- c("date", "total")
```

Make a histogram of the total number of steps taken each day
```{r  echo = TRUE}
hist(sum_data$total,
     breaks=seq(from=0, to=25000, by=2500),
     col="blue",
     xlab="Total number of steps",
     ylim=c(0, 20),
     main="Histogram of the total number of steps taken each day\n(NA removed)")
```

Calculate and report the mean and median total number of steps taken per day
```{r echo = TRUE}
mean(sum_data$total)
median(sum_data$total)
```

What is the average daily activity pattern

```{r echo = TRUE}
mean_data <- aggregate(activityData$steps,
                       by=list(activityData$interval),
                       FUN=mean,
                       na.rm=TRUE)

# Rename the attributes
names(mean_data) <- c("interval", "mean")
```

Make a time series plot
```{r echo = TRUE}

# Compute the means of steps accross all days for each interval
mean_data <- aggregate(activityData$steps,
                       by=list(activityData$interval),
                       FUN=mean,
                       na.rm=TRUE)

# Rename the attributes
names(mean_data) <- c("interval", "mean")
```

compute the time series
```{r echo=TRUE}
plot(mean_data$interval,
     mean_data$mean,
     type="l",
     col="blue",
     lwd=2,
     xlab="Interval [minutes]",
     ylab="Average number of steps",
     main="Time-series of the average number of steps per intervals\n(NA removed)")
```

Which 5-minute interval, on average across all the days in the dataset, contains the maximum number of steps?
```{r echo = TRUE }
max_pos <- which(mean_data$mean == max(mean_data$mean))

# We lookup the value of interval at this position
max_interval <- mean_data[max_pos, 1]

# Clear the workspace
rm(max_pos, mean_data)
```

Calculate and report the total number of missing values in the dataset

```{r echo = TRUE}
rm(max_interval)

# We use the trick that a TRUE boolean value is equivalent to 1 and a FALSE to 0.
NA_count <- sum(is.na(activityData$steps))
```

Devise a strategy for filling in all of the missing values in the dataset.
Create a new dataset that is equal to the original dataset but with the missing data filled in.

```{r echo = TRUE}
# Clear the workspace
rm(NA_count)

# Find the NA positions
na_pos <- which(is.na(activityData$steps))

# Create a vector of means
mean_vec <- rep(mean(activityData$steps, na.rm=TRUE), times=length(na_pos))
```

Create a new dataset that is equal to the original dataset but with the missing data filled in

```{r echo=TRUE}
# Replace the NAs by the means
activityData[na_pos, "steps"] <- mean_vec

# Clear the workspace
rm(mean_vec, na_pos)
```

Make a histogram of the total number of steps taken each day
```{r echo = TRUE}
# Compute the total number of steps each day (NA values removed)
sum_data <- aggregate(activityData$steps, by=list(activityData$date), FUN=sum)

# Rename the attributes
names(sum_data) <- c("date", "total")

# Compute the histogram of the total number of steps each day
hist(sum_data$total,
     breaks=seq(from=0, to=25000, by=2500),
     col="blue",
     xlab="Total number of steps",
     ylim=c(0, 30),
     main="Histogram of the total number of steps taken each day\n(NA replaced by mean value)")
```

Calculate and report the mean and median total number of steps taken per day.
```{r echo = TRUE }
mean(sum_data$total)
median(sum_data$total)
```

Create a new factor variable in the dataset with two levels – “weekday” and “weekend” indicating whether a given date is a weekday or weekend day
```{r echo = TRUE}
activityDataImputed$dateType <-  ifelse(as.POSIXlt(activityDataImputed$date)$wday %in% c(0,6), 'weekend', 'weekday')
```

```{r}
head(activityData)
```

Make a panel plot containing a time series plot
```{r echo = TRUE}
# Clear the workspace
rm(sum_data)

# Load the lattice graphical library
library(lattice)

# Compute the average number of steps taken, averaged across all daytype variable
mean_data <- aggregate(activity$steps,
                       by=list(activity$daytype,
                               activity$weekday, activity$interval), mean)

# Rename the attributes
names(mean_data) <- c("daytype", "weekday", "interval", "mean")

```

```{r echo=mean_data}

```

```{r echo=TRUE}
# Compute the time serie plot
xyplot(mean ~ interval | daytype, mean_data,
       type="l",
       lwd=1,
       xlab="Interval",
       ylab="Number of steps",
       layout=c(1,2))
```

```{r}
summary(cars)
```

You can also embed plots, for example:

```{r, echo=FALSE}
plot(cars)
```

Note that the `echo = FALSE` parameter was added to the code chunk to prevent printing of the R code that generated the plot.


ID case may have its own delimiter. It's 'AT' for the cases when we record time. In other cases, it should be something different.

See my note regarding storing time delta for event IDs.


Yes the routing issue has been fixed. I've opend a new issue about the mysql table: (#1)


hei


Please squash this commit to the previous.


Which assignment is unused?


Can you please add one of the test script using util methods, config,  etc... So it will be helpful for better understanding.


base64로 인코딩(텍스트)하고 그대로 binary(이미지)압축을 해서였다.
new Image() 과정을 생략한 게 화근.


Yes, good point.

But actually I'll drop this commit. It's too confusing and too long to talk about, for no real benefit.


Getting now a Error with this Commit because im on a new Installation without any Drivers.

```javascript
TypeError: /gameservers/pcars/fa_meisterschaft_live/views/User/profile.ejs:37
    35|                                   <label class="col-sm-2 control-label" for="race_count"><%= __('race') %>:</label>
    36|                                   <div class="col-sm-10">
 >> 37|                                       <input class="form-control" disabled id="race_count" type="text" value="<%= user.drivers[0].race_count %>">
    38|                                   </div>
    39|                               </div>
    40|                               <div class="form-group">

Cannot read property 'race_count' of undefined
    at eval (eval at <anonymous> (/gameservers/pcars/fa_meisterschaft_live/node_modules/ejs/lib/ejs.js:237:14), <anonymous>:29:2374)
    at eval (eval at <anonymous> (/gameservers/pcars/fa_meisterschaft_live/node_modules/ejs/lib/ejs.js:237:14), <anonymous>:29:3711)
    at /gameservers/pcars/fa_meisterschaft_live/node_modules/ejs/lib/ejs.js:250:15
    at Object.exports.render (/gameservers/pcars/fa_meisterschaft_live/node_modules/ejs/lib/ejs.js:288:13)
    at Object.exports.renderFile (/gameservers/pcars/fa_meisterschaft_live/node_modules/ejs/lib/ejs.js:318:20)
    at module.exports [as engine] (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/ejs-locals/index.js:85:7)
    at View.render (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/express/lib/view.js:76:8)
    at Function.app.render (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/express/lib/application.js:523:10)
    at ServerResponse.res.render (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/express/lib/response.js:827:7)
    at ServerResponse._addResViewMethod.res.view (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/lib/hooks/views/res.view.js:237:16)
    at /gameservers/pcars/fa_meisterschaft_live/api/controllers/UserController.js:18:13
    at wrapper (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/node_modules/lodash/index.js:3602:19)
    at applyInOriginalCtx (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/lib/waterline/utils/normalize.js:421:80)
    at wrappedCallback (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/lib/waterline/utils/normalize.js:320:18)
    at _normalizeCallback.callback.success (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/node_modules/switchback/lib/normalize.js:33:31)
    at _switch (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/node_modules/switchback/lib/factory.js:48:28)
    at returnResults (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/lib/waterline/query/finders/basic.js:180:9)
    at /gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/lib/waterline/query/finders/basic.js:91:16
    at /gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/lib/waterline/query/finders/operations.js:77:45
    at wrapper (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/node_modules/lodash/index.js:3602:19)
    at applyInOriginalCtx (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/lib/waterline/utils/normalize.js:421:80)
    at wrappedCallback (/gameservers/pcars/fa_meisterschaft_live/node_modules/sails/node_modules/waterline/lib/waterline/utils/normalize.js:320:18) { [TypeError: /gameservers/pcars/fa_meisterschaft_live/views/User/profile.ejs:37
    35|                                   <label class="col-sm-2 control-label" for="race_count"><%= __('race') %>:</label>
    36|                                   <div class="col-sm-10">
 >> 37|                                       <input class="form-control" disabled id="race_count" type="text" value="<%= user.drivers[0].race_count %>">
    38|                                   </div>
    39|                               </div>
    40|                               <div class="form-group">

Cannot read property 'race_count' of undefined]
  path: '/gameservers/pcars/fa_meisterschaft_live/views/User/profile.ejs' }
```


curl --ftp-pasv -T $file ftp://$user:$pass@$host/


@FroMage It's an argument, not a parameter.


Does it mean we don't have fields in the message?
If so, passing such a message as an ID looks like an error. We need to throw IllegalArgumentException in this case.


Testdata.xlsx is missing. Can you please add?


I've checked the config history on my end and didn't see any issues, the names of the backup files shouldn't matter as long as they start with config-* (and end with .xml).

The history page uses $configObject->getBackups to get a list of backups and searches for the revision time (string) to get the actual name... it should work :)


Because they shouldn't be in this branch


@SubJunk The reason I'm asking is because I understood this discussion was about adaptation to a certain renderer, but when having to turn of mediainfo that points to a weak server hardware rather than a renderer issue as I understand it. That should be considered when choosing what should be the default/official setting for a given renderer.


Note `precov`


Use utility factory methods for things like this.


@mvz https://github.com/troessner/reek/commit/1a4cf2a0e450a511a9827956e0eaaf1e465c4c29
That's what I had in mind. Looks significantly better to me.
If ok for you as well, I'd squash.


Ah right.


@meip: Okay you are right, shortcodes seems better.


@localheinz yes, better organized. Ok ?


Could you please push it to clojars?


How about TimeUtil.add()?


>You do make a good point. And maybe I will end up keeping the "nearest" filter the default. But, can I ask what resolution are you using? A few tweaks have been made since the last beta - can you try the following and see if it's any better for you?

My laptop’s resolution is 1600x900.

I let you know once I run beta (might not be today). But everytime I play, I compile a new version from latest commit. So although I comment here (as I started here and then), I’ve been playing also later version.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20966/testReport/) for this commit**


... я понял, что это будет работать на все объекты класса String
Проверю


Ca va je change bientôt de projet. Dis mois si un jour tu va faire un event
chez xebia. Meme du mobile ca peut etre cool. Je vais essayer de faire un
peu d'Android.
Le 16 sept. 2015 4:10 PM, "ArnaudPiroelle" <notifications@github.com> a
écrit :

> Yep toujours.
> Ca va et toi?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/girardot/dagger-fruit-shop/commit/a96245101e9cba7bd7416232d90125fd1526c1ec#commitcomment-13263187>
> .
>


火前留名


AFAIK, this was the only place where we were actually testing the "Wanted Links" functionality.


Typo :) I meant ** logic ** and sounds good.

How will volumes update their profile after creation? I assumed apply_profile would do this in the future ?

-Ryan

> On Sep 21, 2015, at 2:44 AM, myechuri <notifications@github.com> wrote:
>
> does apply_profile kick off during the creation of a volume?
>
> @wallnerryan : there was no need for apply_profile as far as EBS is concerned. i kept it around in volume creation workflow so that i can confirm that none of the other backends need it. Will follow up on that after hack day. Thanks!
>
> Should we keep login in create_volume?
>
> i am sorry, do you mean caching login information in order to access storage backend? EBS does a new connection on every storage driver call, so, i did not think of caching. If ScaleIO caches (which means potentially other storage drivers could cache as well), we will have to revisit create_volume - attach_volume coupling. Thanks!
>
> —
> Reply to this email directly or view it on GitHub.
>


Проверь, но насколько я помню, биндер локален для каждого контроллера.


`if self.quotes is None:`


I would provide parse() method that would restore an object from its String representation. And use the restored object for equality check with the original object.

This way make the test independent on the actual format of the string. We just ensure that the format is workable for our purposes.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20967/testReport/) for this commit**


See #210. Better for me to do PR to master or development? Development I assume...


Why not use ternary expression?


Replace `param` with `paramSafe`. Param raises if parameter is not found.


Development yes


This was also indirectly testing the template providers administration UI. AFAIK we don`t have anything else to replace it.


We need to solve the null ID matter in general.


@jmchilton Is there a pull request/plan to merge this  feature?


Maybe we can test this in a (single) separate test, e.g. in `givenAnEstablishedSecureSession()`? I would like to reduce code duplication and keep the scope of a single test case as small as possible/necessary.


I did not know this either. Is this feature already documented somewhere?


It would be better to register the converters dynamically as corresponding ID classes or utility classes are loaded.

We need to save on startup time especially when working under App Engine.


What is the speed comparison now between Capybara and WebdriverIO?


@mobaig @alext wdyt?


Why do we have ProjectId here?


Really?


Completly rigth really miss this error. Thanks


Have CR in the end of files. It may be of importance for some text headers. That's why GitHub complains about it.


Awesome work Kate.


You can see the problem removing ```hidden-xs``` from this line, making a comment in a need or adding a need in a project and checking from other user's view the "my projects" view of that community.

In small screens, the new pad and new message icons are not fully displayrd as you can see in the following image:
![captura de pantalla de 2015-09-21 13 17 25](https://cloud.githubusercontent.com/assets/7475584/9990652/39288c9e-6063-11e5-8a35-de7cc8e95250.png)


Don't know if get_option returns same type? Let me test.


Ничего так рефакторинг )


testtest


But so the map has a common class across all types of widget?


I noticed a few mistakes:

1. You're not reporting the version number to the user.
2. For meta tags, the field `meta` should be used instead of `html` whenever possible.
3. Dots inside a character class (square brackets) don't need to be escaped.
4. You're not closing the non-capturing group.

Fixed version:

	"meta": {
		"generator": "Redaxscript ([\\d.]+)\\;version:\\1"
	},

Also, a hint for the future: if you've made a mistake in a commit and it hasn't been merged yet, using `git commit --amend` and then `git push -f` (force) will amend the previous commit instead of creating a new one, which results in a cleaner commit log.


Ok, but I think this needs to be modified too... https://github.com/opnsense/core/blob/master/src/etc/inc/config.lib.inc#L347-L350

Also need to make sure that going from time() to microtime() the new backups are still known as "newer" so the backup order is still intact. :)


LGTM


That looks good to me.


yes, I still needed to remove the timestamp in the old code.... the new code is already handling it now.
The order looks good, but I will double check to be sure.


You can't constructor inject everywhere ( it happens I constructor injectd this one after my rework but I can't do it for each of your comments ) => circular dependencies ;-)


Ah, this may be why the SDK JS runtime tests hang on `[ceylon-test-js] running: test.ceylon.collection::ArrayListTest.testOccurrences`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20968/testReport/) for this commit**


Summary of changes:
- replaced setInterval / setTimeout with rAF;
- setup AudioContext and Oscillator instances on callback from getUserMedia so they can be reinstated after a stop command;
- stop AudioContext and Oscillator instances and clear rAF with new `doppler.stop()` method;
- renamed `doppler.init()` to `doppler.start()`
- added rudimentary support for event handlers `doppler.on(event, callback)`:
  - use `doppler.on('sample')` for reading bandwidth deltas (this replaces `init(callback)`);
- added `MediaStreamTrack.stop()` to release stream from getUserMedia;
- renamed `handleMic()` getUserMedia success callback to `onStreamSuccess()`;
- moved getUserMedia error callback to new `onStreamError()` method and log error;
- simplified `readMic()` to use arguments within closure (avoids needless param passing);


this commit is having busybox change as well the commit message says its openssl change.


I think it should be ```container_format: :bare``` and ```disk_format: :qcow2```


Ok, I didn't know. However, when can you fix the problem with the id's service ?


> I let you know once I run beta (might not be today). But everytime I play, I compile a new version from latest commit. So although I comment here (as I started here and then), I’ve played also later version

Oh, so the link above won't make any difference then. When you have the time, could you please post a screenshot so I can see how it scales at that resolution?


Возможно стоит наложить ограничения на наименование элементов enum'a?

По результатам тестов, enum перебирается по индексу, и возвращается первое значение, совпавшее по имени, поэтому старшее значение можно вызвать только по номеру. Поэтому, ничего особенно страшного в таком раскладе не произойдёт, а за создание элемента enum'а, отличного только регистром - бить всё равно надо (если его номер будет выше, что почти гарантировано, он ничего не сломает, но и работать не будет)

Ещё парсер умеет распознавать команды, данные через запятую, и возвращать их бинарное или, что или даст проблем при фильтрации, или сделает её бессмысленной.

В итоге идея красивая, но концентрация костылей вокруг всё возрастает, что нехорошо. Но если делать универсальный API - вылезут всё те-же проблемы.


I have a error comming out when compiling dune-grid-howto using

./dune-common/bin/dunecontrol --module=dune-pdelab-howto all

http://pastebin.com/rXqRSsB8

it is found to be repeatable among several linux boxes


Maybe use the shorthand getter from above here? IMO makes the logic more clear.


This will not work. These files are auto-generated. Please see http://otrs.github.io/doc/manual/developer/5.0/en/html/localization-translation-mechanism.html.


这种问题在1.4.6上面需要修复吗，我看提交记录里只改了1.5分支的~~


Please change the unmaintained `PIL` to the maintained `Pillow`.


got it


take a look at lines 561-565 to set O3 either direct or through defconfig


@Robotaxi : No problem. That's called collaboration :-).


yea... it's just a test commit


It doesn't look like you use this `topic` anywhere in the test, so you could probably remove this line.


Yes and no. Idiomatic implies following common usage, which has the consequence of being more maintainable by other people.

In any case, it looks like let blocks are actually functional and do the equivalent of ``pushd`` of the previous value on entry, which makes ``let`` and ``let*`` preferred over ``setq`` in the general case. Here it's a side-effect to a function arg, so it doesn't matter.


The comparison of constants here is a bit hard to grasp, this seems to be here to automatically adapt to changes in the constants? Maybe leaving the old constants or expliciteby setting both to `false` here would make things clearer, then catch accidental changes of those constants in tests with comments there?


Renamed `_mesh` to `_surface_mesh`.


Ah. Ignore the question on the PR. Didn't see this.


Mente at den gjør at render IKKE går tregt ;)


fixed https://github.com/opnsense/core/commit/19a5fc38c9f76b255e953060090e809a5fc4fa21


Unneeded `inline`


Thanks :)


Consider using a `before` block to remove duplication of a test setup. eg.

```ruby
describe 'GET /:id' do
  before do
    get :show, id: my_topic.id
  end

  it 'returns a 200 status code' do
    expect(response).to have_http_status(:success)
  end

  it 'renders the #show view' do
    expect(response).to render_template :show
  end

  it 'assigns the correct topic' do
    expect(assigns(:topic)).to eq(my_topic)
  end
end
```


arrow function expressions are cool, but maybe a bit early to use them? it's breaking builds for those who aren't set up to use es6 features


will do this afternoon
On 21 Sep 2015 12:06 pm, "Dmitry Dzhus" <notifications@github.com> wrote:

> Could you please push it to clojars?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/benedekfazekas/clj_manifest/commit/8e10c69932df60d11d554427027c6bbc74c850a0#commitcomment-13339466>
> .
>


awesome


I see what you did there :D


I wish there were a way to mark a comment as a todo or issue so we can track it.


ok


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1345 of 1345 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.29%25-green.svg)


A "genius idea" @hoholee12:
First hybrid run download busybox with AM & move to /data/local/HybridMod/ and "install" like:

for i in $(busybox --list); do
	eval alias ${i}=\"busybox ${i}\"
done

And then download standard.sh with WGET, what think about? :P


It was not removed, line 42-45 was moved to line 30 so that the sound can be blocked when the script Iterates through the list of blocked tasks.

Is there a way i can change it to localPlayer? I'm kinda new to github


@srimanob this is it


That horrible find command in the INSTALLED_PACKAGES array is due to the inability of `npm` to list a simple flat list of installed packages without dependencies.


I did not mean to bury them bu You have a couple of config files , I just thought they could be combines in to 1 config file.


do not use inverse logic: use #ifdef WIN_RT and appropriate code here


Is it just me or does this fail to null-terminate the string?


Это-то зачем? git сам знает про свой каталог и игнорирует его.


MVC works, but legacy gives me this (in Chrome):

<img width="214" alt="screen shot 2015-09-21 at 13 43 22" src="https://cloud.githubusercontent.com/assets/1915288/9991041/cfe8c8da-6066-11e5-9bc3-9fa63fd773b3.png">


add comment "// WIN_RT" after #else and #endif


you don't have to overwrite templates in the theme 'default'


Больше нигде такого не было? В LoginController разве не надо удалить?


@bsuttor never mind; a new release is ready!


Isn't this unicity handled by XML config ?


As Django 1.9 sets Oracle 11.2 as the minimum version it supports, the comment doesn't seem necessary.


deindent this line


`= default` is a good alternative.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20970/testReport/) for this commit**


remove spaces 49-51


include a trailing comma so if more items are added later, we don't have to modify this line again


`console.log(text)` was intended or was meant for debugging purpose only?


Please remember to add upgrade scripts when changing initial installation process. Added in 4ba6373341c9e78d5aabdb363448b9bb344c9ef8 for you :+1:


it was there while debugging this code and containerd a cout, guess I forgot to default it


I think you forget the `amcharts/` folder


ывапав


1: M111 unrecognized component name: WIP


Yes of course, I wrote you about that in email. It was only proposal. No matter, we will fix it on another way as you has suggested.


выаыва


1: M111 unrecognized component name: dojson


@wonder-sk heck yeah!!! Thanks!!


Yeah, that was a pain too, but we already solved it by following this path: https://github.com/ongr-io/FilterManagerBundle/commit/3a7da7aeefccfd09ff67c082e6851aeb9d021aca


Same type?


@wonder-sk @nyalldawson agree, very important feature! Thanks to all that made this possible.


I don't think `are checked that` is grammatically correct, I'd rephrase this as `If this flag is set, we check that $apply projections are applied to higher-kinded types.`


Because amcharts has also release the plugins, I think we can add these plugin as individual libs.
- [amcharts/responsive](https://github.com/amcharts/responsive)
- [amcharts/export](https://github.com/amcharts/export)
- [amcharts/dataloader](https://github.com/amcharts/dataloader)


@esoergel ...
I looked at this a bit on the plane last night. One particularly hairy thing that we didn't do is query for the particular app we are looking at. If you have 2 different apps with the same version numbers, I'm pretty sure our query will return errors for both. I didn't see an immediately obvious way of getting around this...

In other news, I added the popup modal with the list of errors to the UI.


use drupal_hmac_base64 which is url safe: https://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/drupal_hmac_base64/7


This indentation does not follow the Able styleguide :-1: @blim8183


@vilchik-elena Minor: could we name it statements (with a final s)?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20971/testReport/) for this commit**


It looks like I accidentally remove a </a> tag... it should be fixed with the last commit :)


@pynicolas I've added fixme for this


I'd actually argue that having it here is better because it'll remove some races.

Usually the order is clear resolved -> set status. If a resolve call gets in between these two it will remain set and not cleared even though the unit is not going to be in an error state anymore.


self.opts.grp_specs contains leading @ char, but env_group_install does not accept it as a valid group.


test


Зачем? В LoginController для зарегенного пользователя в модель добавляется список людей для вывода.


@pynicolas that's a good question (actually not so minor one). I prefer singular, to remember that this list contains only one statement in case of standard syntax (without colon).


Hi Simon,

I think what I would really like to do is to compare the output of
PACKAGE_VERSION with the output form describe. This allows to catch
cases where the checked-out (present) files disagree with the compiled
files.

I think it would be useful to have the "dirty" in PACKAGE_VERSION (not
for the comparison, but in general). If you do add it there, would it
be possible to change from

v2.5.1+41~g0f1b84b

to

v2.5.1-41~g0f1b84b

? That would simplify a bit the comparison. (But I don't know whether
you specify the format for the PACKAGE_VERSION string somewhere and
this is simply a git inconsistency?) I can change the - into + for the
comparison myself, of course, but maybe it's quicker in
PACKAGE_VERSION.

Cheers,
--U.

On Mon, Sep 21, 2015 at 12:26 PM, simonspa <notifications@github.com> wrote:
> Ah, I see! no, the dirty flag is not stored at compile time. we could do
> that though if needed.
>
> —
> Reply to this email directly or view it on GitHub.


А, стормозил, ты про dto...


I'm new, too, so I have no idea. I'd just change it, make a pull request and see if it works.


Yay!


By global state you mean it should do the whole going through api, state and back to the remotestate watcher?


Pourquoi passer "c_string_encoding"=**utf8** plutôt que **ascii** ?


Sorry for the inconvenience, but this was very necessary change. We are preparing core foundations to avoid that kind of changes.


````
	var/obj/item/weapon/gun/MFCS/P // Declares but does not instantiate a variable or create the object.
	if(src.isKinetic)
		P = new obj/item/weapon/gun/MFCS/projectile(loc) // Previously declared variable refers to this object.
 	else if(src.isEnergy)
		P = new obj/item/weapon/gun/MFCS/energy(loc) // As above, different path, shared parent type.
	P.modChassis = src.modChassis //etc
````


INTEGRATION TESTING_2015-09-21 14:59:25


@vilchik-elena I realized that the issue is in fact in ElseClauseTree#statement() which returns a list. It looks strange to me.


Cool


:+1: I might reuse that in other places


ass_utf8_put_char() does.


PS: you're the second one who pointed this out. I can make it more explicit if needed.


Yes, now it's empty instead


Sorry, I had forgotten that already. :(

Am 21.09.15 um 13:49 schrieb S7 Design:
> Yes of course, I wrote you about that in email. It was only proposal. No
> matter, we will fix it on another way as you has suggested.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/s7design/otrs/commit/046f0c6b4fd4cbc2a079106b2b2a24e2df8a708a#commitcomment-13340105>.
>

--
Martin Gruner
Team Lead R&D

OTRS AG
Bahnhofplatz 1a
94315 Straubing

T: +49 (0)6172 681988 0
F: +49 (0)9421 56818 18
I:  www.otrs.com/

Geschäftssitz: Bad Homburg, Amtsgericht: Bad Homburg, HRB 10751,
USt-Nr.: DE256610065
Aufsichtsratsvorsitzender: Burchard Steinbild, Vorstand: André
Mindermann (Vorsitzender), Christopher Kuhn, Sabine Riedel

Mobile Kommunikation und transparente Prozesse mit der OTRS Business
Solution™ 5 - Preview auf der IT&Business vom 29.09.-01.10.2015 in Stuttgart
Registrieren Sie sich hier für eine Freikarte:
https://www.otrs.com/meet-otrs-it-business-am-29-09-01-10-in-stuttgart/?lang=de&utm_id=140


Maybe add a 3rd argument with the level `debug`, `info`, ... ?


@vilchik-elena ALTRNATIVE_IF_STATEMENT should be renamed to ALTERNATIVE_IF_STATEMENT


Теперь я это знаю ))


typo, will fix


De user will en expense printe wennsie signed isch und ned scho printed.. denn gheit sie eh usem dashboard is archiv. usserdem würi em user namal d view mit em expense zeige bevorersie druckt. De state wäri denn signed. @davefromthecave chasch du das im back-end au na so umsetze (state signed nach to be signed by financeadmin und vor printed)


I would doubt that you want to really print out errors like this:

```
# dnf dadsa
usage: dnf [options] COMMAND
Command line error: argument COMMAND: invalid choice: u'dadsa' (choose from u'upgrade', u'update', u'group', u'groups', u'grouplist', u'groupinfo', u'groupinstall', u'groupupdate', u'groupremove', u'grouperase', u'help', u'autoremove', u'updateinfo', 'foo', u'kickstart', 'playground', u'repolist', u'reinstall', u'needs-restarting', u'clean', u'provides', u'whatprovides', 'distro-sync', 'distribution-synchronization', u'install', u'download', u'history', u'repository-packages', u'repo-pkgs', u'repo-packages', u'repository-pkgs', u'repoquery', u'builddep', u'list', u'downgrade', u'reposync', u'upgrade-to', u'update-to', 'copr', u'config-manager', u'info', u'search', u'check-update', u'makecache', u'remove', u'erase', 'debuginfo-install', u'mark')
Otherwise it could be a DNF plugin command, try: "dnf install 'dnf-command(dadsa)'"
```


@PCMan something like this?:
```diff
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 87daa36..26fbf0b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -10,6 +10,11 @@ include(LXQtTranslateDesktop)
 install(DIRECTORY graphics DESTINATION "${LXQT_SHARE_DIR}")

 # startlxqt script
+if(${LXQT_DATA_DIR} MATCHES "/usr(/local)?/share")
+       set(XDG_DATA_DIRS_EMPTY "$XDG_DATA_HOME:/usr/local/share:/usr/share")
+else()
+       set(XDG_DATA_DIRS_EMPTY "$XDG_DATA_HOME:${LXQT_DATA_DIR}:/usr/local/share:/usr/share")
+endif()
 configure_file(startlxqt.in startlxqt @ONLY)
 install(PROGRAMS
     "${CMAKE_CURRENT_BINARY_DIR}/startlxqt"
diff --git a/startlxqt.in b/startlxqt.in
index 3dc42c3..8c8666b 100755
--- a/startlxqt.in
+++ b/startlxqt.in
@@ -15,11 +15,7 @@ if [ -z "$XDG_CONFIG_HOME" ]; then
 fi

 if [ -z "$XDG_DATA_DIRS" ]; then
-       if [ "x@LXQT_DATA_DIR@" = "x/usr/local/share" ] || [ "x@LXQT_DATA_DIR@" = "x/usr/share" ]; then
-               XDG_DATA_DIRS="$XDG_DATA_HOME:/usr/local/share:/usr/share"
-       else
-               XDG_DATA_DIRS="$XDG_DATA_HOME:@LXQT_DATA_DIR@:/usr/local/share:/usr/share"
-       fi
+       XDG_DATA_DIRS="@XDG_DATA_DIRS_EMPTY@"
 else
        if ! contains "$XDG_DATA_DIRS" "$XDG_DATA_HOME"; then
                XDG_DATA_DIRS="$XDG_DATA_DIRS:$XDG_DATA_HOME"
```


It's working fine with this last commit.Thanks !

Will you include ScalableWebServer (maybe under a different name) inside of fluent-http ?


Sean...
http://www.scratchpaper.com/ is where the Unicode NSIS lives.
I'm not against moving forward with the version needed. But I have a little problem with the fact that after your changes there is basically no version available for a normal user that would work...

Anyway, I will try to have a look at the problems visible in 3.0b2 and see if they can be fixed.


Actually, this should only be for arXiv IDs and not the other report numbers, so you can move the logic to return empty dict when no value in `c`.


Spaces after `,`. Sorry for nitpicking, but this is a guideline after all :)


Ah, I see. Maybe the ass_utf8_put_char interface is simply too unusual and should be changed.


@vilchik-elena LGTM


Why is it Parent?


I think the only other place would be the commit wrapper. This does seem more obvious at a first glance because we know the operation has succeeded at this point.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1875 of 1882 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.63%25-yellow.svg)


Didn't it just get reverted by the container changes?


see #283


Ahhh ok, now it makes sense. I will amend the commit later evening or
tomorrow then! Cheers!

2015-09-21 14:05 GMT+02:00 Jan Åge Lavik <notifications@github.com>:

> Actually, this should only be for arXiv IDs and not the other report
> numbers, so you can move the logic to return empty dict when no value in c
> .
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ioannistsanaktsidis/inspire-next/commit/674516db49ccd83f6d6311f83e5a2cd00f420e1f#commitcomment-13340390>
> .
>


`x`, `n` and `m` should be renamed to be explicit


nit: if you use `append()` on the slice, there's no need to make it ahead of time.


Also it looks like you've been looking at an old version of this. The new one is here: https://github.com/bogdanteleaga/juju/commit/1f9fee5c8563ac3c2030e684ad4ec9b7ec5a5dc0

I can also give you a diff: http://sprunge.us/SjeO

The only parts that really changed are this one and the apparition of a new onprepare wrapper.

Instead of returning ErrHookFailed below and catching it in the upper loop, I just caught it up here.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


> not all underlying http server implementation will respond to this api

that's the part I don't understand.

````java
public class WebServer extends AbstractWebServer<WebServer> {
  public static void main(String[] args) {
    new WebServer()
      .configure(routes -> routes.filter(new LogRequestFilter()))
      .start();
  }

  private int count = 8;
  private int select = 1;
  private int webSocketThreads = 10;

  public WebServer withCountThreads(int count) {
    this.count = count;
    return this;
  }

  public WebServer withSelectThreads(int select) {
    this.select = select;
    return this;
  }

  public WebServer withWebSocketThreads(int webSocketThreads) {
    this.webSocketThreads = webSocketThreads;
    return this;
  }

  @Override
  protected HttpServerWrapper createHttpServer(Handler httpHandler, WebSocketHandler webSocketHandler) {
    return new SimpleServerWrapper(httpHandler, webSocketHandler, count, select, webSocketThreads);
  }
}
````


propose: `plugin '%v' does not have executable permissions. skipping it.`


Gracias por el aviso, ya subí un tablero con las posiciones corregidas, había que invertir letras o nros


This seems to be a cleaner way to exit, also it seems like if a user doesn't enter anything, it would usually be because they don't want to

But C-c also works, I guess


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20972/testReport/) for this commit**


PEP8 checker error: E501 line too long (88 > 79 characters)


stylistic nit:
```go
np := public{
   name: n,
   path: ppath,
}
```


Das isch duplicated code oder?

globalMessagesService.confirmInfoMd("[...]", "[...]").then()['finally'](function() {
});


nit: `return` alone is better. it will return err which is nil


Nice work :+1: :)


call the package `github-demo`


@ylxdzsw fork吧.... 别直接提交了


Does anybody know why travis fails?


*a* sample ;)

But I agree it's a sample not an excerpt.


You are right, it's makes little sense. I meant this code can't be in `AbstractWebServer` but it could be in `WebServer`


## This is a README ... ...


shouldn't you break here?


that's not exactly what I meant: you can format the s3 import string in python and pass it as a single argument


Hm wieso?


lol Ok i did but it created another commit. I wonder if the new would merge into this 1


Show PDF


ok then I understand


so you end up with `COPY github PARTITION (month_partition=?) FROM ? WITH (compression='gzip')`


Any sanity checking, for example to verify that `pent.path` hasn't been removed since the plugin was loaded? Or maybe catching errors back from `exec.Command` is enough.


Chasch der mal die aktuelli implementation vom http interceptor aluege? Es wird jetzt i jedem http fehlerfall en allgemeine fehler azeigt. Zum das i usnahmefäll zverhindere chamer de error function im then am 1 argument es attribut errorHandled =true hinzuefüege. Denn unterbindisch de allgemein fehler (sinnvoll für de check eb en user en signatur het oder ned aber ide meiste fäll bruchts kein spezielle error handler meh, will en http fehler ned setti passiere.

Das isch denn velech nützlich wenn de rest call machsch..


would be nice to have a select that enforces a max exec time, like the one we have in mig-agent


Spring don't deal with circular dependencies ? really ? Wow, I just checked and that's true ! Poor Spring users ...


Please keep the formatting of this method in line with the rest, namely: 2 spaces indentation, 100 cols line limit.


This comment is wrong.  `git` correctly honours config options without a value as existing.


@grabbou  Yeah, I have stupidly forgotten "git add". No more commits at midnight next time.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20973/testReport/) for this commit**


### hi this is a test for issure


This name is illegal:

The ReplicationController "monitoring-influxDB-grafana-v2" is invalid:metadata.name: invalid value 'monitoring-influxDB-grafana-v2', Details: must be a DNS subdomain (at most 253 characters, matching regex [a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*): e.g. "example.com"


Ok, I reverted that part. I think it's missing tons of conflicts, though.


Yes it is, and that's the problem : part of the behavior is encoded in java code, another part in the xml. @Singleton makes it clear to people reading the code what to expect from this class. As a reader, you don't want to jump to the xml definition to know this kind of information


two nits about logs:
1. would be nice to generate an ops ID and log it to make it easy to grep logs that are related
2. maybe some of these are debug logs and shouldn't be printed in prod


Hum, I can't reproduce my issue....

```
Concurrency Level:      500
Time taken for tests:   5.809 seconds
Complete requests:      5000
Failed requests:        0
````


So what we have is  a mandelbox extended with :

menger sponge
spherical offset
box offset
rotation2 relocated
relocated scale to follow spherical offset

so it works as a fully functioning mandelbox set-up when the menger sponges
are not enabled.

cheers

On Mon, Sep 21, 2015 at 5:01 PM, carbuncle grim <mclarekin@gmail.com> wrote:

> added in Spherical offset  (works as expected )
>
> added in DE calc for scale (it seems to work well, I do not fully
> understand the maths???)
>
> added in DE adjustment for spherical fold (seems to work)
>
> will try two more new transforms then will probably call Menger Sponge -
> Extended completed.
>
> Cheers
>
>
>
>
> On Mon, Sep 21, 2015 at 1:06 AM, carbuncle grim <mclarekin@gmail.com>
> wrote:
>
>> Nice image.
>>
>> On Mon, Sep 21, 2015 at 12:42 AM, Krzysztof Marczak <
>> notifications@github.com> wrote:
>>
>>> Nice formula
>>> [image: extended_mandelbox_001]
>>> <https://cloud.githubusercontent.com/assets/11696990/9980779/bbb63f1c-5fa5-11e5-9f32-b002ee6fe645.jpg>
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/buddhi1980/mandelbulber2/commit/939d835f6cbff3c7be2d1e13c16089ff31ab4c5e#commitcomment-13329393>
>>> .
>>>
>>
>>
>


Das isch falsch. Edit expense cha en user nur mache wenns im draft zuestand isch oder rejected. Das isch denn genau d create expense view, womer so wiederverwednet hend. Ide view-expense chamer nüme bearbeite.


getDomainList actually returns
```
array(1) { [0]=> array(1) { ["domain"]=> string(8) "test.com" } }
```

This check fails for valid domains


better use [strptime](https://docs.python.org/2/library/time.html#time.strptime)


I tried some heavy load and I couldn't reproduce it either.


With this commit `<form>` with jQuery UJS (`form remote=true`) send double (or more) post.
If I use this version: https://github.com/rails/turbolinks/blob/6d4f600b38f4ebd34409a19ba24917ec868d6fc6/lib/assets/javascripts/turbolinks.coffee
I've no problems...


Guets...?


-o /Users/Shared/jenkins/workspace/IOS-ATV2/build/Kodi.build/Debug-iphoneos/Kodi-iOS.build/Objects-normal/armv7/DarwinUtils.o
/Users/Shared/jenkins/workspace/IOS-ATV2/xbmc/osx/DarwinUtils.mm:258:19: error: use of undeclared identifier 'NSAppKitVersionNumber'
    hasLeakyVDA = NSAppKitVersionNumber <= NSAppKitVersionNumber10_9 ? 1 : 0;
                  ^
/Users/Shared/jenkins/workspace/IOS-ATV2/xbmc/osx/DarwinUtils.mm:258:44: error: use of undeclared identifier 'NSAppKitVersionNumber10_9'
    hasLeakyVDA = NSAppKitVersionNumber <= NSAppKitVersionNumber10_9 ? 1 : 0;
                                           ^
2 errors generated.

Needs a #ifndef/#define for older SDKs.


:-)

So you mean Guice can handle something like this ?

public class A {
private final B b;

@Inject
public A(B b) {
  this.b = b;
}
}

public class B {
private final A a;

@Inject
public B(A a) {
  this.a = a;
}
}


Veto


I am not removing anything from search.css because that is very likely to cause problems with Firefox versions prior to 43.  That code was incorporated some time ago and it should stay like that unless having good reasons to break compatibility with early Firefox versions.  This is certainly not possible now because it would likely break compatibility with the current official version (40) and the current release candidate (41rc).  Thus this change should close the issue that called it.


Hey Kevin... just checking if you purposely made these changes to the PPluginWidget.ui form when you updated the documentation in this commit, or if something weird happened. I just noticed those symbols showing up in the Manage Plugin preferences widget the other day and tracked it down to this commit.


I don't think you should have anything hardcoded in here like the URL, amber user and password and the properties file.


诶，分branch也不行吗。那我fork吧


Same as above comment.


is the goal to have one storage dir per day?
possible confusion with this is that servers in PDT timezone will switch their results folder at 1700pst because UTC time moved to the next day, regardless of what timezone the local system uses. I'd recommend `not` to use `UTC()` for this and just let the admins decide (they should use `UTC()` but we can't enforce it).


I'll do them tonight


If you name file "r" and map it to the R file type this code results in java.lang.StringIndexOutOfBoundsException: String index out of range: -1

By the way, what is the reason for this change?


git clone https://github.com/plusjade/jekyll-bootstrap.git Alvin-Z.github.com


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20974/testReport/) for this commit**


I had some failed request, but it's SSL related. I use nginx as a load balancer / SSL front

````
SSL handshake failed (5).
````

so maybe this was a nginx issue.

````
Concurrency Level:      1000
Time taken for tests:   46.619 seconds
Complete requests:      50000
Failed requests:        4
   (Connect: 0, Receive: 0, Length: 4, Exceptions: 0)
````


Not, slothbot, zombie. getElementData(source,"zombie"). Also, you don't need "== true", that's double redundancy. Simply "if getElementData(source,"zombie") then" is enough.


Du hesch en zwoite state gmacht für edit-expense wo uf createxpense linked? Ja das isch eigetli e gueti idee, chasch min comment vom andere commit ignoriere^^


Of course it can, for ages. It creates proxies.


Tell me if this (9dabc3632de918605fbd076b9efc4370cd5b3b32) is what you wanted, and I cut a release.


Hi Pat,

Thanks for your feedback. This may be a silly question.. but how do I
overcome setting a height on the element without the text inside the
element flowing into the the section below?

On Sun, Sep 20, 2015 at 3:33 PM, Patrick Nolan <notifications@github.com>
wrote:

> You could be more descriptive with your naming and dash separate the
> names. When I see container1 container2 etc I get worried and it doesn't
> help when trying to read the code.
>
> Another thing is that you are setting the height on all the containers
> which is generally not what you want as if the content grows then you will
> have to deal with overflow and potential scroll bars on the elements.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PariBilimoria/ga-fewd-19-assignment-2/commit/7d0c2902b15a6469b681ae28c8567d1b691d7572#commitcomment-13328103>
> .
>


nit: if you have a build version, it's worth appending it to the user-agent.


这个是由于在 IE8 中 respond.js 无法处理从外部加载的 CSS  的 mediaqueries,导致的显示不正常


`randomString` is not secure enough. try `sha1(drupal_random_bytes(16))`

https://api.drupal.org/api/drupal/includes!bootstrap.inc/function/drupal_random_bytes/7


Yeah, I did, didn't really see that you relocated it.


`.json` ?


Looks like this rule is hiding the activity feed of watched repos and followed users on https://github.com


@michaelsuo we don't want users like @bencomp to see profanity in their server logs: http://irclog.iq.harvard.edu/dataverse/2015-09-21

If necessary, we can add this to the style guide we're working on: http://guides.dataverse.org/en/latest/developers/coding-style.html


INTEGRATION TESTING_2015-09-21 15:25:40


llvm2kittel should exit here / skip the next steps, as everything afterwards will fail if the output file couldn't be open


Tá bacana. Tenho uma dúvida nos métodos adicionar e remover item no dwarf. Talvez apenas a classe inventario devesse ter esses métodos. Q vc acha?


Addressed comments on this change in https://github.com/google/ExoPlayer/commit/4eae2ad91fcb2332cddd50e55fa0b7be1e98d78e. Both can be viewed together in the pull request: https://github.com/google/ExoPlayer/pull/808/files


Yes. I just put it in to be *really* explicit to be honest. It can be cut if people aren't bothered.


I actually prefer jslint which I've been using on both projects on the fly.

Sent from my iPhone

> On Sep 21, 2015, at 1:23 AM, Alexander Elgin <notifications@github.com> wrote:
>
> I noticed that JsHint is not configured in the project at all i.e. no code convention was defined. I think feca16a is the correct solution of the problem. Now we have code convention defined by the set of JsHint rules. Please, do not leave errors and warning in files that you include into commits. We can supplement or modify the convention upon agreement changing the rules.
>
> You can configure your WebStorm to apply the rules "on the fly" as I did.
>
> I also added a grunt task with nice reporting:
>
> grunt jshint
> Do not forget to execute
>
> npm install
> before
>
> —
> Reply to this email directly or view it on GitHub.
>


There is not so much duplicated code here :
```
clientRawDataChannel.setProcessor(new RawDataProcessor() {
			@Override
			public RawData process(RawData request) {
				// check we decrypt correctly the message
				try{
					assertEquals("ACK",new String(request.getBytes()));
				}catch (Error e){
					decryptionFailure.set(e);
				}
				return null;
			}
		});
```
This is verbose (because of java) but there is not so much logic, the idea was to verify that after a session resumption the encryption/decryption was still ok.
But if the handshake is ok this means that challenge in Client_Finished message was well encrypted/decrypted. So we don't need to retest it and remove this code.
Does it sounds good for you ?


I'd remove this special case


same nit as before: when `append`ing, no need to `make`


Setting the messages together is an implementation detail in this case.

For the negated failure message, I'd pick a matcher that matches (so matcher.matches must be truthy), like so:

```
     let(:smelly_code) { 'def dummy() y = 4; end' }
     let(:matcher) { Reek::Spec::ShouldReekOf.new(:UncommunicativeVariableName, name: 'y') }
```


Great :+1:


It's in the log:

```
$ make checkcfg
./test/cfg/runtests.sh
Checking test/cfg/posix.c...
Checking test/cfg/gnu.c...
./test/cfg/std.c:15:19: fatal error: uchar.h: No such file or directory
compilation terminated.
make: *** [checkcfg] Error 1
The command "make checkcfg" exited with 2.
```


my tests run fine with this commit, so this is great. Thanks.

But since I can reproduce my "scaling" issue, I won't tweek WebServer unless I really need it. Anyway, this is always nice to leave to the user more ways to use your software.


Wouldn't a better name be setWrappedOrb() as it might be useful elsewhere?


@ejoncas I just finished adding support for other headers and request line. I have not merged it but in case you want to try https://github.com/shashiranjan84/kong(not yet merged to release branch)

Now its based on https://tools.ietf.org/html/draft-cavage-http-signatures-00, so there is slight change in format.


Could you explain what's happening here? `5s` is a short time, is that the max exec time of the plugin? Can it be made configurable?


Not sure if and how much we are consequent in this, but I personaly prefer camelizing also acronyms. We already have `AddJdbcDriver*.json.schema` rather than `AddJDBCDriver*.json.schema`.


C'est quoi system(e) ?


@tortuetorche please open an issue with example code (or app) to reproduce


Is there really a `feedId` somewhere in this schema?


I am only aware of a documentation for namespaced functions - since I edited that part of the manual recently.


there is no need to overwrite get/setEnvs if you delegate it to super()


Ótimo. Cara, muito show.


Or does it try to fill up the reslist slice and if results stop coming in for 5 seconds, goes into the next part of the code?
If so, recommend you add an upper limit to exit the select if, for example, 100 results have been fetched.


commit not added in master, already fixed


perhaps s/is to execute/has executed/ ?


Done (forced a push). Now, also an xpath like
"./foo/@existent or ./foo/@nonexistent" yields the correct result (true).


Much better!

But my question remains: Why not just do
```
def failure_message
  # something, something, something
end
```
?


Sit dine date format changes funktioniert expense item hinzuefüege nüme, sdatum wird döt im falsche format zruggä. InvalidDateFormatException


We should consider allowing sort by "Description"


> the only thing we can check is, that the actual argument cannot be a constant.

That sounds useful to me. It would've caught the assertions this commit addresses. Anyone interested in implementing that in a tool?


@Thibaut OK, I'll try to do it this evening or tomorrow.


Can we have `Opt.short 'o'` as well?


The name of the test is wrong (copy / paste !)


I think that this needs to be handled differently. There are promises that need to be taken into consideration when a send fails. For example, when calling *send* from the *join* method. If we simply ignore the fact that there was an exception we will never satisfy the promise and whoever is waiting on the join future will be blocked forever.


This should be an error. If you call `elm make --output myfile.cpp` it should not fail silently.


You don't really need `oldres`, you can delete an entry from a slice using
```go
reslist = reslist[:i+copy(reslist[i:], reslist[i+1:])]
```
https://github.com/golang/go/wiki/SliceTricks


This is probably just the file name without any folders, right?
This is just a proposal generated by the server that is not binding for the client in any way, right?
It is just a string that the UI could use to save the download, right?
Could the above points be noted in the description if they are right?


Oooh, right. Thank you.


Es mejor binarizarlo por qué así siempre tendrás la última versión

Enviado desde mi iPhone

> El 21 sept 2015, a las 12:52, singlop <notifications@github.com> escribió:
>
> oye dónde esta el @mod o mejor lo binarizo yo??
>
> —
> Reply to this email directly or view it on GitHub.
>


Ok, I give up, anyone able to get my regex correct :/


Should not `resourcePath` be required?


is this used by any other component of MIG or should it be a struct internal to mig-runner?


"work" -> "working"


The only interface for using the `TransferManager` to download asynchronously involves pushing the downloaded file to disk and then reading it. I'm wondering if this is a worthwhile improvement since maybe synchronous-and-in-memory is faster than asynchronous-and-on-disk.


This part is strange.
According to commit log, removing the item_add hook seems a regression.


Yeah `battleonly` was my first idea but then I saw `joinbattle` but didn't realize mods/drivers had it too.


should be policykit or logind secure query, as support for `last' cam be disabled in systemd. Has a SIGPIPE/SIGBUS handlers been installed, and handled correctly?


nice catch


Modifications on this file could have been done in another commit


@Noor-Ahsan, I've split the commit. Kindly review. Thanks!


This argument validation is causing an issue

It may break existing user code, depending on the order the properties are set, and which values are set.

The order the properties are set should not be important.
What's important is that the state is valid when the Object is actually used.

Please consider the following gist for a Test Case
https://gist.github.com/YannRobert/f1d6a90803888df7fc3a


specifiedValue variable name is a bit suspicious for workingDirectory =)


should not spawn lsb_release, but should parse /etc/os-release, /usr/lib/os-release in that priority order.


Nevermind, now I see that `Nothing` makes the opt parser fail.


already cleaned on master


lgtm.


But should "/foo/@nonexistent" really evaluate to true?


done reviewing commit 20c8a2c


No APKs ;)


First review round finished


not really, we try to keep it up-to-date :-)


INTEGRATION TESTING_2015-09-21 15:38:55


The very last thing, let's make it `state = initialState.merge(state)`. Although return is generally more idiomatic, let's follow Daniel conventions, otherwise he will get pissed off :dash: :


Will im then und im catch sgliche staht..


r+


But Twitter is not returning basic information like gender,age etch . can anyone tell me how can I get ?


INTEGRATION TESTING_2015-09-21 15:39:56


@SubJunk it introduces a bug too (try opening a rendererpanel) :-):
```logtalk
08:35:16 INFO  Exception in thread "AWT-EventQueue-0" java.lang.NullPointerException
08:35:16 INFO  	at net.pms.util.UMSUtils.normalizeDurationString(UMSUtils.java:238)
08:35:16 INFO  	at net.pms.util.UMSUtils.playedDurationStr(UMSUtils.java:266)
08:35:16 INFO  	at net.pms.newgui.PlayerControlPanel.refresh(PlayerControlPanel.java:329)
08:35:16 INFO  	at net.pms.newgui.PlayerControlPanel$17.run(PlayerControlPanel.java:359)
```
Can you be more specific about the bug you're trying to fix here? On the renderer panel (and in bump), we're intentionally using the shortest possible time string for simplicity and space reasons, e.g ```1:23 / 4:56:78```


Well it is a incremental backup system with no limit on the copies of an individual file (sort alike Apple TimeMachine).
But thanks for the fix :+1:


Ok, no worries, thank you!


Finally automatic brightness is OK :yum:


Actually some people had asked about it already and it's nontrivial; I just added this document in case someone might be interested in experimenting with that.
https://github.com/google/gemmlowp/blob/master/todo/error-diffusion-experiments.txt


propose: `"failed to parse cron expression '%s': %v", e.Configuration.Schedule, err`


INTEGRATION TESTING_2015-09-21 15:41:37


I'd rather change the style in the remaining reducers to return immediately. What do you think?


Allowing the user to set the wrapped orb is risky and we need to control that.

This OrbPortabilityEnvironmentBean#setShutdownUnwrappedOrb is to tell the orb portability layer not to shut it down when the orb portability layer is shutdown (in method ORBBase#shutdown below). In my earlier attempt at the fix I created ExternalORBWrapper instead but that fix was no good.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (808 of 808 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-21.78%25-green.svg)


Splitting GetContacts into two methods - with/without arguments seems okay, but I'm not completely convinced to implementing "PassAlllContactRecordFilter". If we assume filter is just selecting (not ordering) items from list passed as argument, then "PassAllContactRecordFilter" would be doing exactly nothing.

If there is no misunderstanding, I would propose this solution:
```
        public List<Contact> GetContacts()
        {
            var contacts = new List<Contact>();
            using (var db = new PhoneBookContext())
            {
                var contactRecords = db.Contacts.AsNoTracking().Where(contact => contact.Owner == Owner)
                    .OrderBy(contact => contact.LastName)
                    .ThenBy(contact => contact.FirstName)
                    .Take(PageSize);

                foreach (var contactRecord in contactRecords)
                {
                    contacts.Add(contactRecord.MapToContact());
                }
                return contacts;
            }
        }

        public List<Contact> GetContacts(string searchTerm)
        {
            var contacts = new List<Contact>();
            using (var db = new PhoneBookContext())
            {
                var contactRecords = db.Contacts.AsNoTracking().Where(contact => contact.Owner == Owner);
                // using IContactRecordFilter passed via constructor (SoundexFilter)
                contactRecords = ContactRecordFilter.Filter(contactRecords, searchTerm)
                    .OrderBy(contact => contact.LastName)
                    .ThenBy(contact => contact.FirstName)
                    .Take(PageSize);

                foreach (var contactRecord in contactRecords)
                {
                    contacts.Add(contactRecord.MapToContact());
                }
                return contacts;
            }
        }
```