Hi, not sure this is the best place to comment, sorry about that..

I use play-slick module and was looking to have a inMemory database for tests.

I guess I can't use Databases.inMemory() because it's in play-jdbc, should I include play-jdbc module and use it anyway or there is a better way ?


No need for this as it will take fields name with uppercase by default


Thank you - its working!


I saw your comment on another commit, so ignore this.


css в разметке :(


You certainly want to set this string as translatable.


use `_()`


Nice work. Looks great.


ok I found it far away in the other commit.


Another `_()`


next time you can use this  parser wowhead http://wowsource.info/parser/


This has been fixed on 29d988554ab2c9de83e21d8480a29cfcf216f2b8. We actually don't need a timeout, it was there for a debug that I was performing a long ago. We can just return the notification that comes from the IPMB Layer.


i have my parser, but i use it with others work


The update command still works, wondering why should one remove from the readme?


I will need to see what I did wrong - thanks for your attention.

Bob

Robert (Bob) Knothe

> On Sep 4, 2015, at 5:58 AM, Peter Dave Hello <notifications@github.com> wrote:
>
> But it's strange @BobKnothe, in ajax/libs/autonumeric/1.9.31/autoNumeric.js, the version in comment is 1.9.39?
>
> —
> Reply to this email directly or view it on GitHub.
>


every time i need something i use that one and if is required  small  adjustments  np it can make your life easlier


This won't work with multiple networks. Command below seems to expect `--networks net1 --networks net2` etc, but here you feed it with `--networks net1 net2`.


use strdup plz this is pure mess(R)


use r_str_newf() here, all those complicated lines can be done in just 1


Move all contents to a method in `octane.util.env`


redundant `!`


`call_args` are logged anyway in `call` method.


use calloc instead of malloc+memset


use R_NEW0


Yeah, I didn't invest much time into fixing the formatting. in 90% of this commit, it is as I found it.

What typos? Did I introduce them?


Could make it a `CHECK_EQ(util::Status::OK, ...)`.


This is the dual unit of measure option. This option is made for a very special use case when you need to sell products in units incompatible with the storage units (for example weight vs volume). Check this forum answer: https://www.odoo.com/forum/help-1/question/how-to-sell-products-in-different-units-of-measure-3934#answer-3939

Product cost price is defined in terms of the product default unit of measure defined in the information tab.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20097/testReport/) for this commit**


Hi guys.
Just stumbled over it during some "homework" with the DuellKit. This is a breaking change and needs to be a new major. It breaks at runtime on iOS. Can you please fix this?


I would let the 1.5 be configurable. To hard-code it is too arbitrary.


ICC generates invalid code vectoring parts of `jemalloc` & `webgl` components building with __-O2__ or __-O3__ works without issue.

this removes this message from *about:memory*
```
WARNING: the 'heap-allocated' memory reporter does not work for this platform and/or configuration.
This means that 'heap-unclassified' is not shown and the 'explicit' tree shows less memory than it should.
```


boot receiver could  just use PreferenceManager.getDefaultSharedPreferences(context);
not really needed for that settingsContext stuff


BTW if u wanna do self::$instance you need to define it.


'administer dibs email settings'


This is actually an older branch.  The latest code is at https://github.com/projectatomic/rpm-ostree/tree/daemon.


So locking might be bad. Consider using an sqlite/sql database backend from which you generate the local reservation file after each reservation.


Смотри по примеру остальных адресов. Все адреса начинаются с типа (webapp - файлы веб-приложения; api - файлы, возвращающие данные; widgets - файлы виджетов). Дальше идет название плагина, дальше идет путь к файлу внутри плагина (если в плагине мало файлов и все лежат в одной папке, то это будет просто название файла).
Адреса виджетов в этом плане отличаются от остальных адресов. Виджет должен иметь уникальный идентификатор (это строка, которая указывается в параметра атрибута [Widget] - не может быть двух виджетов с одинаковым идентификатором). Поэтому название плагина в адрес указывать не обязательно.

Т.е. адрес виджета будет /widgets/unique-widget-key.js, где "unique-widget-key" - идентификатор виджета, который совпадает с названием js файла в ресурсах.


Ok.


'Recent unusual DIBS reports'


I mean upload it here.


How does it break? We can revert it and push it on the major release that we're making at the end of next week.


TeamCity Jarvis Framework :: CI-GitFlow [Build 45](http://build.prxm.it:8811/viewLog.html?buildId=3951&buildTypeId=CqrsFramework_CiGitFlow) is now running


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1822 of 1823 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


what for?


maybe make the backend configurable?


The rootview is set in opengl 5.0.0+, but the public duellkit is not updated yet and still on 4.0.0+


Can you use the `nil coalescing` operators instead? For example:

```objective-c
return _takePhotoString ?: kTakePhotoString;
```


BTW I tried now with my patch to create a Delivery order and invoice it and everything is OK in the journal entries and stock valuation accounts, but I will double check and if it's not working with DO invoicing I will modify my patch to:
- keep original code to work with stock moves invoicing
- change the else clause that have standard price to have my code for SO invoicing
- may create another else clause to set unit price to standard price for any other case.


    self.fds_PF_files_directory_ids.mapped('name')

would do the same.


Ok


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


@alhashash I don't have this special use case - this is normal for most business to buy in bulk and sell in smaller units.
ex. by in Ton and sell in Kg .


@danqu how can i help you? Tell me your problem and i´ll decide if i can help you ;)


Yes looks like there is enum34, but like you said it needs to be installed. If it's just for style reasons it's probably keep the version with no dependencies.


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.2.0-unstable.10+10](http://build.prxm.it:8811/viewLog.html?buildId=3951&buildTypeId=CqrsFramework_CiGitFlow) outcome was **FAILURE**
Summary: Tests passed: 124; exit code 1 Build time: 00:03:27


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20098/testReport/) for this commit**


It looks that this has suddenly broken for me:
```
sed: 1: "s/
$//": unterminated substitute pattern
EXPECTED value GOT EOF
```
And the only thing was upgrade to OSX 10.11. But if \n can be used as a newline symbol, and intention here is newline+$-sign sequence, then this should work as well.


Nice work! Looks fantastic! I'll give it a test run ASAP and also add some basic axes tests on a new branch. Could you then add some tests to this branch? Thanks for your contribution!


Please rename this `dir` variable as it is a builtin function, it could hide for exemple that `dir` is not defined.


Same here don't use `dir`


thank you @rande


@wasdmovement this is a test


Can you make a PR for this? We can work together on that. Cheers


Its works good but you need the next android adapt commit that make it great. Notice that this patch was for 3.10.y kernel tree and i made few changes to adapt to my tree hlist structure. So if you need clean patch just find it in google. Then apply the next commit for this. I get 30mb sharred and 350mb scanned and merged.


`dir` to rename


@VoyagerOne: why did you put this test at priority -1 ?
http://tests.stockfishchess.org/tests/view/55e3c9f70ebc595da9433a7d


Alles klar! So I will revert it and put it on a branch.


Do not use this construction 'isScript && el.charset'


Then, you do not need to activate this option. You just need the option above it (titled "Manage different units of measure for products")


Here: https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#includes


Right? /cc @niksedk


IIRC Apache doesn't recommend mixing cert and privkey in one file. I'd change it to self-explaining

```
SSLCertificateFile /etc/apache2/ssl/server.crt
SSLCertificateKeyFile /etc/apache2/ssl/server.key
```
and remove all comments around.


Is this really what you wanted to do?


This broke Gtk, with the error
```
ERROR: LoadError: LoadError: cfunction: type signature of gc_unref does not match specification
 in gobject_ref at /usr/local/julia/julia-packages/v0.4/Gtk/src/GLib/gtype.jl:406
 in unsafe_convert at /usr/local/julia/julia-packages/v0.4/Gtk/src/base.jl:1
 in push! at /usr/local/julia/julia-packages/v0.4/Gtk/src/layout.jl:221
```
`gc_unref` has signature `gc_unref(x::ANY)` and it is passed to `cfunction` as
`cfunction(gc_unref, Void, (Ref{T},))`.

I'm not clear on whether the fix needs to be here, in `ccall.cpp`, or in Gtk. I have verified that changing the signature to `gc_unref(x)` fixes the problem.


misspelled canola


tag: https://github.com/MrAlex94/Waterfox/issues/2


Its also off by default. Need to start it after boot. Or its will delay boot by using cpu when we need it for booting...


"whatBS_INDENT" is a typo.


Why 'charsetAttrValue'?


Is this even possible given just a bare, base (non-developer) OS installation?


@rumpelsepp Tell me about it. Turns out they do some magic with symlinks in $GOPATH which is explicitly forbidden by the Go toolchain, hence cleans and stuff don't work correctly and builds break left and right. Goodbye CircleCI :cry:


Thanks!
Yes. Makes more sense. Changed and pushed.


s/information**s**/information (it has no plural form)


move that import at the top of the file. (python convention)


The `CR` variable is completely unused now, isn't it?


1579840-GroundTemps (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1303 of 1303 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.12%25-green.svg)


Can be removed


I literally just copied and pasted from the druid module (Mark of the Wild). So I figured that was all that was needed.


Was hei0ßt KJ huh? Wer ist dieser Kerl?


s/bankStatment_id/bank_statement_id

Please don't use camel case for attributes, use it for class names


Still someone should look for the broken "question" element in this learning module...


I took another look at the entire file, and I think we can simplify this:

- Because `dialWithoutProxy` is calling `netutil.CanonicalAddr` as its first operation, I think the only place we need to get the canonical address in `dial` is for the value we pass to `Host` in `proxyReq`. Rather than modify `req.URL.Host`, perhaps we should just create a new var `targetHost := netutil.CanonicalAddr(req.URL)` and use that for `proxyReq`'s `Host`. WDYT?

@liggitt @ashcrow


Thanks!


Do you mean account ID? or simply account?


Because it is inconclusive.  Look at the residual.  It is just burning up resources...
In addition, it should be tested against the soon to be merged SMP patch.


This duplicated code is sad. It can be refactored, but it's okay if it's not done now. I would leave a TODO: for that, though.


Usual key work fork end of workflow is 'done'


Consider splitting up this file. dhcpd.conf should be as static as possible, and should include another file(s) with host entries.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20099/testReport/) for this commit**


Kindly avoid spelling mistakes, they are probably the worst of all coding errors :)


Use `_()`


aww, but understandable


consider using a more capable template engine.


What's the reasoning behind Caps? Functions as types?


:tada:


If you have only one record in your record set, you can write it's state by doing:

    self.state = 'draft'

It will even call ensure_one before calling value assignation


also changed package name for testing


@ncdc WFM. Will update.


Getting the canonical host up front sounds good to me. Not sure if we need to do the same for the proxyURL... (what happens if they set `http_proxy=https://foo.com` with no port?)


audio/wav 48kHz 16bit works well enough for me. Onkyo specs says FLAC should be supported as well but as you see not according to data above. audio/mp4 with (lame encoder) works also well but I prefer use something lossless. audio/L16 is not working, at least not with:

```
cvlc -vvv pulse://alsa_output.pci-0000_00_1b.0.analog-stereo.monitor --sout \
'#transcode{acodec=s16l,channels=2,samplerate=48000}:standard{access=http,dst=0.0.0.0:8080/PulseAudio.wav}'
```


why not define this as a list in the conf?


Yes, I agree. Thanks!


@imobach Would it be possible to add a test case comparing the difference between old and new TargetMap?

We have these new bugs:
* https://bugzilla.suse.com/show_bug.cgi?id=944431
* https://bugzilla.suse.com/show_bug.cgi?id=944492

and @aschnell thinks (IIUC) that it `might` be related


ohm` đúng, để suy nghĩ xử lý.


I wish i could. Probably not for the next time. ;-)


@liggitt to connect to the proxy, it also calls `dialWithoutProxy`, so if `proxyURL` is https://foo.com, `dialWithoutProxy` will get its canonical form and dial foo.com:443.


Same as above


You might want to send a _logger.warning() ?


I'm very worried about this.  I agree that this makes it slightly easier for users, but by removing the repository/dataId concepts and replacing them with physical filenames I worry that we will encourage difficult-to-provenance workflows.

Your "lsst reduce" command overlooks potential difficulties when we version camera geometry, electronic properties, and other time-dependent calibration information besides just a few master calibration images.

Our "tract/patch" skymap based coaddition process and presumed template storage seem tricky to reconcile with your "lsst diffim" and "lsst coadd" command lines.


я в самом начале главы пишу:
Функция `i18n` может использоваться:

* [в JavaScript](#В-javascript)
* [в шаблонах](#В-шаблонах)


It seems like there should be a call to contactService.getContactById and then an assertion that the contact was returned.


Here too.


They're not (explicitly) registry-based; they're repository-based.


The actual calls to contactService.getContactById in the tests are removed, which is not good. The test can also be improved by adding assertions checking the results of contactService.getContactById.


Since ```dialWithoutProxy``` does it's own call to ```netutil.CanonicalAddr``` then this should work ...

(diffed off this commit, will replace it)
```diff
diff --git a/pkg/util/httpstream/spdy/roundtripper.go b/pkg/util/httpstream/spdy/roundtripper.go
index 1a7151a..dfd94a7 100644
--- a/pkg/util/httpstream/spdy/roundtripper.go
+++ b/pkg/util/httpstream/spdy/roundtripper.go
@@ -73,21 +73,19 @@ func (s *SpdyRoundTripper) dial(req *http.Request) (net.Conn, error) {
        if err != nil {
                return nil, err
        }
-       // ensure req.URL.Host is canonical
-       req.URL.Host = netutil.CanonicalAddr(req.URL)

        if proxyURL == nil {
                return s.dialWithoutProxy(req.URL)
        }

-       // ensure proxyURL.Host is canonical
-       proxyURL.Host = netutil.CanonicalAddr(proxyURL)
+       // ensure we use a canonical host with proxyReq
+       targetHost := netutil.CanonicalAddr(proxyURL)

        // proxying logic adapted from http://blog.h6t.eu/post/74098062923/golang-websocket-with-http-proxy-support
        proxyReq := http.Request{
                Method: "CONNECT",
                URL:    &url.URL{},
-               Host:   req.URL.Host,
+               Host:   targetHost,
        }
```


Yes, the comma needs to be in the debug block. It otherwise dangles.


It would be nice if Swift had Scala's implicits

```scala
class SocketIOClient {
  implicit val logType = "SocketIOClient"
  Logger.log("Creating SocketIOClient")
  val engine = new SocketEngine
}

class SocketEngine {
  implicit val logType = "SocketEngine"
  Logger.log("Creating socketEngine")
}

object Logger {
	def log(msg: String)(implicit logType: String) = {
		println(s"${logType}: ${msg}")
	}
}

object Main extends App {
  val socket = new SocketIOClient
}
```


kappa.


У нас уже есть метод sleep в GenericMethods, используем его зедсь


Please don't use tabs in your XML files


Demo


Не понял для чего метод?


One big initial question: does the end user need/want `eups` at all?  Would a totally non-`eups` installation be acceptable or desirable?


It's a class function – seemed right to me at the time. Can't explain why.


86139842-AddAutoSizing (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1793 of 1824 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.3%25-yellow.svg)


Удалить пустую строку


there is no need to do this. You can define a start and an end IP from a range to allocate. For example, given the subnet:

192.168.1.0/24

you can define a range starting from:

192.168.1.20

and ending at:

192.168.1.200

leaving you with the first 19 and the last 54 usable IPs to do with as you please.


Sorry. The panel is still using msn fb 7x30 header. I need to change it to the newer msm fb header.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20100/testReport/) for this commit**


Should the proxy be responsible in vetting whether or not the request body is valid? I say no, that should be left to the responsibility of the proxied service.

The request body should pass through the proxy without modification.


yes sorry, I was using the correct one here, just opened the wrong PR on github


@arter97 @temasek

Apparently the TARGET_UNOFFICIAL_BUILD_ID is not defined when this line is executed :
https://github.com/temasek/android_vendor_cm/blob/cm-12.1/config/common.mk#L300

Any ideas where I should define this variable ?


Сделать из этой конструкции метод getElementText(By locator) - поместить его в GenericMethods


I have the GitHub for Desktop app. I have a folder named GitHub on my computer, and if I put filed in, they go onto GitHub. Btw, I'm using CodeHub for IOS to post this :P


Floris, please add your last name.  Both for checkstyle and administration's sake!


86139842-AddAutoSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (764 of 764 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-10.42%25-green.svg)


這邊搜尋加上去會搜尋不到東西


Do you have a suggestion as to what functionality is useless from LightblueResponse?  I could guess, but I would probably not be right.


I mean files not filed... I can't edit comments on here XD


Arguably, I should have squash this branch, since ObjectMapper showed up on the first commit on this branch, but was then removed in the second commit (per my note on the expense in pull request #16).


Заменить на проверки assertThat


Wow... Desktop github I have, but how to sync these? Geez, your so good.


I tried to parse the caller out of `NSThread.callStackSymbols` but I didn't get a proper result.


remove this


Now I can comment on a line of your code! Yay!


Удалить пустую строку


Nothing here needs to change?


Lol :D I'll tell you more when I'm back on the computer (tomorrow)


  	public boolean hasError() {
  	public boolean hasDataErrors() {
public Error[] getErrors() {
  	public DataError[] getDataErrors() {
  	public int parseModifiedCount() {
  	public int parseMatchCount() {
  	public JsonNode getProcessed() {


После этого клика, вставить ожидание пока js отреаботает, ждем пока менюшка выезжает.


Ah I see it checks first to see if it exists before extending.


Oh, and what is your computer OS? OSX/Linux/Windows


Всегда тольео private!


So this is bad. The whole thing. Consider using:

https://pythonhosted.org/netaddr/tutorial_03.html


s/allow/allows


Do you mean It can be refactored to the var?


commit message typo


you mean use your like instead of
L21 to L25?


Can you put an english text and put this in translations please?


I can roll with it :+1:


Suggest to use save an iterator returned by find and reuse it instead of repeating find() calls.


Попробовать спрятать эту конструкцию в EntryLogic в метод:
checkSuccessEntryCreationText


more tabs to anihilate


LGTM


Doesn't this make the lines below dead code?


Please order your import to have first the python libraries and then the openerp imports


IMHO that's a bad idea to update profile inside a conversion method, such side effects might be dangerous.


How was this auto-generated?


Actually I would not be surprised if ```SetTargetMap(GetTargetMap())``` already ruins the data since the stuff is so fragile.


s/check and download/checks and downloads


Eh, that was an artifact from a previous fix I tried and forgot to fully remove. I think I got rid of it in another commit.


Этот тест есть в классе UiTest - здесь можно удалить


They were taking 2.3 seconds on my Mac Pro :/


Suggest to check ss for NULL prior to dereferencing


Перенести в UiTest


Because here is transmitted the ```charset``` attribute only


s/was/were


Found a better solution.
Use ` __FILE__` instead of `"SocketParser"`


Ahh I see. Make sure to handle 'conflict' stream errors send to the *new* session in case the server is configured to behave so on resource conflicts. OTR and multi session/client is an unsolved problem, which hopefully will be solved with the OMEMO XEP using axolotl (which will be soon published as far as I know). Would be great to see support for this in Xabber too.


just noticed that this is an id and not a class oO


opps :) I'm sure there will be lots of there... work in progress I say.


This is the same as no default, to remove


@cehallen DWMR. The comments here are idealio!


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1814 of 1817 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.83%25-yellow.svg)


I just dislike the idea of trying to get the caller at runtime. Since it's something that's easily provided at compile time.


Сделать проверку локаторов еще на одной странице


In your cm.mk file


Thank you !


Создать класс TestBase в пакете tests


Ah.


Fixed in d8ccd99


I don't see a point in using __FILE__ for SocketParser


I think the final / should be removed.


OK, seemed to have worked now


There is no postfix removal here - thus currently one will receive "encoded" data


And when I compile I2cRReadRegBytes.c, I2cWriteRegister.c, InsertSQLite.c, mpl3115a2d.c and ReadSQLiteTime.c like this : pi@raspberrypi ~/Desktop/Mpl3115a2d-master/src $ gcc -o MAIN I2cRReadRegBytes.c I2cWriteRegister.c InsertSQLite.c ReadSQLiteTime.c mpl3115a2d.c

 below message occur :

/tmp/ccYcgtWc.o: In function `InsertSQLite':
InsertSQLite.c:(.text+0x50): undefined reference to `sqlite3_open_v2'
InsertSQLite.c:(.text+0x70): undefined reference to `sqlite3_errmsg'
InsertSQLite.c:(.text+0xa8): undefined reference to `sqlite3_close'
InsertSQLite.c:(.text+0xcc): undefined reference to `sqlite3_prepare_v2'
InsertSQLite.c:(.text+0x104): undefined reference to `sqlite3_bind_text'
InsertSQLite.c:(.text+0x124): undefined reference to `sqlite3_errmsg'
InsertSQLite.c:(.text+0x190): undefined reference to `sqlite3_bind_double'
InsertSQLite.c:(.text+0x1b0): undefined reference to `sqlite3_errmsg'
InsertSQLite.c:(.text+0x204): undefined reference to `sqlite3_step'
InsertSQLite.c:(.text+0x224): undefined reference to `sqlite3_errmsg'
InsertSQLite.c:(.text+0x264): undefined reference to `sqlite3_errmsg'
InsertSQLite.c:(.text+0x29c): undefined reference to `sqlite3_finalize'
InsertSQLite.c:(.text+0x2ac): undefined reference to `sqlite3_close'
/tmp/ccWpq5ET.o: In function `ReadSQLiteTime':
ReadSQLiteTime.c:(.text+0x80): undefined reference to `sqlite3_open_v2'
ReadSQLiteTime.c:(.text+0xa0): undefined reference to `sqlite3_errmsg'
ReadSQLiteTime.c:(.text+0xd8): undefined reference to `sqlite3_close'
ReadSQLiteTime.c:(.text+0x104): undefined reference to `sqlite3_prepare_v2'
ReadSQLiteTime.c:(.text+0x12c): undefined reference to `sqlite3_step'
ReadSQLiteTime.c:(.text+0x14c): undefined reference to `sqlite3_errmsg'
ReadSQLiteTime.c:(.text+0x198): undefined reference to `sqlite3_column_text'
ReadSQLiteTime.c:(.text+0x1ec): undefined reference to `sqlite3_errmsg'
ReadSQLiteTime.c:(.text+0x22c): undefined reference to `sqlite3_finalize'
ReadSQLiteTime.c:(.text+0x23c): undefined reference to `sqlite3_close'
collect2: ld returned 1 exit status

I've installed sqlite3 and move "sqlite.h" file into my compile directory which is src.
Do you know why it is saying "undefined reference" ??


We need to research what information format is needed in the List returned by getFieldOrder().  Simple initial reads of the JNA Structure JavaDoc does not provide enough information as to what the types and format of the Objects in the List should be.


Win 8.1 for my school PC.


Since this is a test, maybe we should be setting play_context.prompt=True  and trying it, then setting play_context.prompt=False and trying it.


Not clear for me why we propagate profile here. Instead we should probably return applied compression method ( taken from profile?) to the caller.


ErrorPermission and errorSFTP to capitalize or not to capitalize? I know it's not displayed but ...


Cool.  Although, that bit of code is still in the latest branch and I don't know where the daemon is relying on `$PATH`.  @petervo, do you remember?


Addressed in 00e2fb62e05e1a433bcfae8a7023838c2089d079.


Please start using folder different from "erasure-code" for compression plugins


K, I have Mac OS 10.10, on my home computer


does not look like a dict to me


Will there be additional commit with RM-driven prefix?


Do you know where this code work? I know we are using Sel+ for setfoucs, do you know other engine?


sd


s/download/downloads


asd


You can use it everywhere. SocketParser was just an example

__FILE__ seems to be created as by compile time. It is some kind of macro


_logger.warning ?


It’s already there - the PMIX_SERVER_TMPDIR envar

> On Sep 4, 2015, at 7:06 AM, Artem Polyakov <notifications@github.com> wrote:
>
> Will there be additional commit with RM-driven prefix?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/open-mpi/pmix/commit/4f6270d947eac7470ba603e513d446682e0b372e#commitcomment-13070257>.
>


Oooo...


Gracias narvaes


TeamCity pull requests :: netty [Build 171](https://garage.netty.io/teamcity/viewLog.html?buildId=1135&buildTypeId=pulls_netty&guest=1) is now running


Initial Commit


return {opt['opt_name']: opt["opt_value"] for opt in dhcp_options}


You already have fds_account. browse return you a record set so it's the same.
fds_account_id variable should be renamed as it isn't an id.


s/proxyURL/req.URL/


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1822 of 1823 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


No.  But I did now find this:
http://twall.github.io/jna/3.5.1/javadoc/com/sun/jna/Structure.html

"Structure fields corresponding to native struct fields must be public. You must define getFieldOrder() to return a List of field names (Strings) indicating the proper order of the fields. When dealing with multiple levels of subclasses of Structure, you must add to the list provided by the superclass getFieldOrder() the fields defined in the current class.

In the past, most VMs would return them in a predictable order, but the JVM spec does not require it, so getFieldOrder() is now required to ensure JNA knows the proper order)."


Please remove the space before `;`


mnmnmmn


This is not a new issue with this patch, but I'm wondering if we shouldn't switch to `a{sv}` to allow ourselves some extensibility here.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20101/testReport/) for this commit**


That's not I the thing I was talking about. I think that we need to provide RM ability to add usock filename prefix, i.e. append jobid to make it cluster- and time-wide unique.


@mrb-twx looks promising. Once you open a PR I will have a closer look. thanks!


Use become_user here please.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8138/testReport/) for this commit**


you read my mind, but i done the same thing!


For example:
instead of naming usock "pmix-<PID>"
call it "pmix-<JOBID>-<PID>.


Not sure employee is the good term as we want a user and not an hr.employee


I'd consider obtaining compression description string along with actual compress call rather than using separate API call and/or introducing direct profile usage.


Any reason why we have these functions in link:?  Is that the best practice?  Just wondering why they couldn't be in controller: ?


Mac Mini with 16gb of ram, flash storage, idk how many cores, and a 4K monitor attached :D


@arter97 @temasek

What do you think of having the possiblity to compress the kernel ramdisk  with lz4 algorithm ?


rax retry tests


To set translatable


should we take into account $PREFIX here?


Los mixins no son instancias de clase, entonces estarías diciendo que los mixins son instancias y después al mixins le estarías pidiendo la singleton_class lo cual no sé si esta muy bien, no sé que opina el resto @ezebor @RamiroV


Hey, so I started implementing the preview function along these lines since it does seem cleaner, but it introduces a few problems when using an AJAX request to render.  First, its nice if the `previewRender` function has direct access to the `preview` element so that it can set it to "Loading..." right away, and then fill in the details when it has it.  More importantly though, with an ajax call, there's not a way to return a value since the ajax success callback runs asynchronously.  The ajax callback needs to set `preview.innerHTML` itself whenever it runs, so it needs access to the `preview` element.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20102/testReport/) for this commit**


Urgh - so you want to modifer server_init?? Why isn’t putting it in a separate directory enough? Usually, there is a tmpdir assigned to the daemon that is unique and gets cleaned up at boot or shutdown. Putting the rendezvous file there should ensure uniqueness and cleanup, I should think.

Just changing the filename won’t ensure cleanup.

> On Sep 4, 2015, at 7:11 AM, Artem Polyakov <notifications@github.com> wrote:
>
> That's not I the thing I was talking about. I think that we need to provide RM ability to add usock filename prefix, i.e. append jobid to make it cluster- and time-wide unique.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/open-mpi/pmix/commit/4f6270d947eac7470ba603e513d446682e0b372e#commitcomment-13070387>.
>


CvISXSUB appears to have been introduced in the development cycle for Perl 5.10, so this breaks builds on Perl 5.8 (at least for my 5.8.8 builds anyway) due to missing symbol CvISXSUB. The following patch fixes this for me:
```
--- Identify.xs
+++ Identify.xs
@@ -4,6 +4,10 @@
 #include "XSUB.h"
 #include "ppport.h"

+#ifndef CvISXSUB
+#  define CvISXSUB(cv) CvXSUB(cv)
+#endif
+
 /*
 get_code_info:
   Pass in a coderef, returns:
```


Sounds good. I'll try to pick from Google later and then cp your Android commit. Thanks a bunch!

------------------------------
On Fri, Sep 4, 2015 9:35 AM EDT Yuri.Sh wrote:

>Its works good but you need the next android adapt commit that make it great. Notice that this patch was for 3.10.y kernel tree and i made few changes to adapt to my tree hlist structure. So if you need clean patch just find it in google. Then apply the next commit for this. I get 30mb sharred and 350mb scanned and merged.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/dorimanx/DORIMANX_LG_STOCK_LP_KERNEL/commit/6cef6daf1ee182427293fd1e8c53350e1fc377a0#commitcomment-13069613


I would move this to template logic


`distort()` here uses double precision and normalized coordinates for input. Both are requirements for the Newton's method. This function here is only used as part of the Newton's method in `undistort()`

Would you like it if I move these two functions to `Registration` as `distort_accurate()` and `undistort_accurate()`. It seems the original `kinect2_undistort()` is replaced with reverse pixel mapping which is faster but less accurate. `kinect_undistort()` used a simpler numeric method.


I didn't activate dual unit option - only different units of measure .


same as above.


DONE


Thanks.. I'll look into it.. I have been working on other projects, but this is next on my list.. Going to look at a few significant upgrades for speed and performance. I'll put that bug on the list.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20103/testReport/) for this commit**


It won't ensure cleanup but it will ensure absense of conflicts.
In slurm I don't create the directory, though it's easy to do so...
Ok, let's move that way.


@rogersb11

I added full 14 variants of the fonts but need to overcome the ArrayIndexOutOfBoundsException. Ideas?


why is a signal sent on the leader chan here? the leader may not have changed


I don't understand this comment. Shouldn't it say:
# So if the lockscreen is displayed, we should switch to the system frame (which we already did)
?


Let's discuss this commit as it's being over-engineered.


OK.

```
//8192: a power of two scaling factor, perhaps used to reduce floating point error
//6250.0/3: the constant DepthPacketProcessor::Parameters::unambigious_dist
```


If this is tested, then I see nothing wrong of compressing it with lz4.
I personally uses lzo.


This doesn't help :(


http://stackoverflow.com/questions/13510975/jnawhat-is-the-purpose-of-getfieldorder-in-structure-class

To be explicit:

protected List<String> getFieldOrder() {
    return Arrays.asList(new String[] { "xxx", "yyy", "zzz", "www" });
}


Looks much better!


Never bricked one device. you're all full of shit. you are all wanna be devs who are entitled to there opinion. but you really do not have a leg to stand on. no kang here. so quit wasting my time get back to kanging cm or better yet. do the world a favor quit deving and find a better hobby. might I suggest cliff jumping without a parachute


@rudij7 @h2o64 @YoshiShaPow @Thecrazyskull


I don't think we are relying on it anywhere in the daemon


I actually already added this AND fixed the issue LOL. You also have to arrays mixed up condensed italic and condensed bold, they do the opposite. I already did weather with this as well lol. As for out of bounds look at your arrays, you delete >5< so the list goes from 4 to 6. I will push weather before long to you, just gotta eat some lunch first


Look good. I'll add some tests. Thanks for the effort!


Please validate config before any operation.


thanks, will simplify it


No, I'm just trying to avoid a crash in the next line if `local_error` is somehow `NULL`, but also be noisy about it.


OMG TYPO!


Not sure why the reloadSignal and "periodic loading of DNS state (pull from Master)" was removed. this is pretty critical in order for mesos-dns to receive updated state information from the mesos masters. you must add this back (either here, or elsewhere) - it cannot simply be deleted.


Nie zostawiamy nieopisanych komunikatów debugowania!


j.w.


done https://github.com/perrozzi/cmg-cmssw/commit/5fb15dc8a2efd8fc9e02b240f46350b50e6b7ccd#diff-ae5787e3ff04997a80cd89e48fc02a66R846


this looks good!


So, if you will be using a database backend for state, make sure you begin a transaction before you fetch used IPs and decide to reserve a new one.


Hi @caglar10ur. Thank you for posting your patches to hound publicly. I am trying to find solution to exactly the same problem. I intend to use hound in my project, but lack of proper branch support in remote repositories is a deal breaker. I am writing to you in hope that you still care about this project. :smile:

But since your patch, the main hound repository got some enhancements as well. One of important ones is configurable "base-url" for custom links to source code. I was trying to merge your changes with updated upstream, but failed due to lack of Go skills.

Would you be so kind as to rebase your nice patch against current version of etsy/hound? It would be even better if you could post it as a pull request for etsy. I bet that more people would be happy with this feature.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20105/testReport/) for this commit**


Merge updates from jmcnamara


Ohh really? Are u the same guy who went mad over my git and talks bullshit behind my back. You need to grow up kid!


LOL!! I just got lucky and saw it when I pulled it, you had just pushed I think so figured you would notice and if not I would mention but you beat me to it


Why do we assume that masters[0] is the leader here? I don't believe that is true in all cases.


Basic game controls mentions, will be changed/updated in the future.


I did a double check with below scenarios:
- invoice on delivery
- invoice before delivery
- invoice on demand

and all stock valuation, sale / purchase and AP/AR entries working fine with this commit.

So there's no need to make my previously suggested modification.


ah .. I think I see. mc.masters[0] is set in the leader detect func. whereas masters is set here. got it.


Instead of editing your answer (sales tab -> information tab)!!!!, you could just mention the misunderstanding and provide a clear example of a test case. Answers are usually based on the original comment which Github sends to participants by email.


Yes, it can be changed in the Marlin config.


I believe this is how we need to map the array of properties.@jvalkeal Could you confirm if this is ok?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20106/testReport/) for this commit**


How stupid is this? The condition is never true, but this turns format from not working, to working like a champ. Surely some optimizer bug that is mitigated. Unfortunately it did not work quite as well for oldoffice above but it seems to be a similar problem.


@cannondalev2000 omg you just fork tons of things from the rom you call out to kang @h2o64
https://github.com/cannondalev2000/AOSParadox


Right, had it backwards =)  Makes sense.


Makes sense to me.  So it would actually be `a(a{sv})` since it's an array of deployments.


Yes, this is much better wording.

In general, I've been trying to go back and reduce the length of my sentences.


indeed it is related to the unit test failed, just refactored that part


Yeah, but only one (random-ish) test case. The others were fine. Waiting on the fix referenced in the comment above.


Don't think this was meant to stay here.


Wait, this doesn't seem right either... will just merge and then go back and fix this manually


TeamCity pull requests :: netty [Build 171](https://garage.netty.io/teamcity/viewLog.html?buildId=1135&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:28:37


No, I meant codebases, although I like thinking of a "universal Codebase" of all code every written.


I note that you added support ".../extra/MicrosoftWebDriver.exe", but I have not seen that EXE being added  to the dependencies/selenium path in the repository.  Is that coming soon?


I agree, this is clearer


Ugh, figured I'd miss something somewhere!  thanks


I mentioned issue #271 in the commit message, but I mean to mention #249.


and yes we got a true dev here
https://github.com/cannondalev2000/kernel_motorola_msm8226/commit/cf49b3e2c155866f54d4133eb7ccbc94523d39e2
enabling cortex a15 flag on a cortex a7 device, yes that is gonna help quite alot!


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20107/testReport/) for this commit**


Current sources allows lzo compression ? There is also lzma available also ?


Ok


Nice :-)


Not sure this'll work


@rogersb11

Thanks again! Because of 1 typo......MERELY 1 typo I kept scratching my head! Now all is good.

Cheers bro!


I don't build kernels with android build environment.
I build it, combine with ramdisk separately.
On Sep 4, 2015 11:41 PM, "Maxime Poulain" <notifications@github.com> wrote:

> Current sources allows lzo compression ? There is also lzma available also
> ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Khaon/android_build/commit/0baa95e2c0be1ef0b140e1f995de1cd7b73f4afa#commitcomment-13071202>
> .
>


hola


Hey dipshit @Thecrazyskull  cortex a15 and a7 have the same feature set and actually perform better in a lot of instances when optimized as cortex a15 instead of a7. know your facts before blatantly calling a change out like that


That's also correct, and more clear. I'll change it. Thanks


I don't understand the meaning of this phpstorm warning:

*Unnecessary fully qualified name less... (Ctrl+F1)
Reports on fully qualified class names which can be shortened. The quick fix for this inspection will shorten the fully qualified names, adding 'use' statement as necessary.
Argument PHPDoc missing less... (Ctrl+F1)
A number of parameters, their names or types (if any) in PHPDoc comment do not match the ones in respective function or method declaration.*

I'm trying to fix it, but :sweat:


The data for gram positive model template was generated by:

1. Running the Print_ModelTemplate_from_Workspaces.pl script to get the biomass and reaction data from the current system
2. Converting the data in the ModelTemplate_Biomass_Components, ModelTemplate_Biomasses, and ModelTemplate_Reactions files generated by the script to the format in the corresponding files in this folder

In the Reactions file, reactions are sorted first by type and then by reaction ID.  In this first pass, the compartment for all reactions is set to "c0|e0" even if the master reaction only uses one compartment.


You can look at this http://events.linuxfoundation.org/sites/events/files/lcjpcojp13_klee.pdf

It is a interesting article comparing different compression algorithms for the boot time


jiff ^_^


это стандартная опция, она необязательная. --save-dev записывает зависимости в devDependencies.
Если кто-то делает npm install вашему пакету, то npm подключит те пакеты, которые указаны у него в dependencies, но не в devDependencies.
.


Are you at 'master'?  And not the other temporary branch you recently created?
I'd also wonder if it is a file size issue.


this version actually worked


@amuniz do you have an idea why this test fails after upgrading the dependencies?


The data for gram positive model template was generated by:

1. Running the Print_ModelTemplate_from_Workspaces.pl script to get the biomass and reaction data from the current system
2. Converting the data in the ModelTemplate_Biomass_Components, ModelTemplate_Biomasses, and ModelTemplate_Reactions files generated by the script to the format in the corresponding files in this folder

In the Reactions file, reactions are sorted first by type and then by reaction ID. In this first pass, the compartment for all reactions is set to "c0|e0" even if the master reaction only uses one compartment.


that's right, I deleted this line. But I still don't know how to get of rid of it in  Matlab, where the CR channel name is used to find the corresponding AWG (see below).


okay you might be right @cannondalev2000 (kernel is not my territorium @desaishivam26 please confirm) but mind commenting on the reason why you forked a part of a kanged rom.
also i really do appriciate the word dipshit you know :)
and before talking about "dev work" do check my github before telling me that i dont know shit ;)


Silly question, we only need this for cake currently? So could we build this as a static binary with all libs linked in that is called something silly as tc4cake or so? That way we can combine this with openwrt's default tc, and all other package dependencies on tc stay happy? Or is this simply crazy talk?
        If this is possible I will teach sqm-scripts to try to prefer tc4cake over tc if it goes and configures cake. Ideally cake would hit mainline an iproute2 repositories sometime in the future, but then we can always remove the crude hack (or simply supply no tc4cake binary anymore).

Best Regards
        Sebastian


> -> we have duplication of the list of module between tests and production
No, you will you override, it's not duplication
> -> I can give to the server exactly what I want. Wasn't the idea to compell the server to use only modules that are made to work together ?
The problem is that you see the CassandraJamesServer as the thing that glue everything together. It's not. It's actually CassandraJamesServerMain.


"If this is tested, then I see nothing wrong of compressing it with lz4.
I personally uses lzo."

I will test this and fix any potential error than I'll submit a pull request then


Seems like it should be possible to get `cfunction(gc_unref, Void, (Any,))` to work, but AFAICT it doesn't yet.

There is a conflict between getting a specific c-compatible signature with `cfunction`, and asking that the argument slot not be specialized. It makes sense that you can't have both, so the workaround is fine for now.


Don't think you need the `+` here


is this really acceptable? that 0.0.0.0 becomes the new leader? why not `""` instead (as in the first case)?


you still missing some lines of the last_kmsg
https://github.com/charles1018/kernel_sony_msm8974/commit/2d12a9046bd4d5a3b324b765b353637f8e339874
P.S.: very thanks for your awesome job and great sources


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1820 of 1823 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1820 of 1823 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


`_dict.values()` returns a list, which is not iterator, so `next` will throw an exception "TypeError: list object is not an iterator". Since `code` was set, why not just let the function continue.


Hmm… I wonder why that wasn't picked up…

We should write a test for that.


You want to use BEFORE keyword for project internal include dirs, so they're not mixed with system ones


Again, ```include_directories(BEFORE```


this.data = this.field.val() ? JSON.parse(this.field.val()) : [];


#define?


oh and you'd like to call me out for kang. I know for a fact this is not your commit.


The options appear in the top left when a file is dragged onto the canvas. See attached image.
![image](https://cloud.githubusercontent.com/assets/13452181/9686353/9d341016-52f1-11e5-96db-ba56b1a07d84.png)


Bel lavoro!
Il nome del job è un macello sufficiente che di sicuro non greppi altra roba per sbaglio.
Non capisco perchè le parentesi quadre non ti piacciano, ma tanto è uguale.

Non so quanto sia costoso controllare questo migliaia di volte, alla peggio `job_running` lo costruisci una volta sola quando inizi ogni sample.


do we really need the `id` here?


Isn't this off by one? Your sequence will always include `null` as the last element because you're checking `current` here, not its next/prev sibling.


The data for gram negative model template was generated by:

1. Running the Print_ModelTemplate_from_Workspaces.pl script to get the biomass and reaction data from the current system
2. Converting the data in the ModelTemplate_Biomass_Components, ModelTemplate_Biomasses, and ModelTemplate_Reactions files generated by the script to the format in the corresponding files in this folder

In the Reactions file, reactions are sorted first by type and then by reaction ID. In this first pass, the compartment for all reactions is set to "c0|e0" even if the master reaction only uses one compartment.
Also, the files were renamed to use the .tsv extension instead of .txt to be consistent with other files.


Where is tadamm?


All Lobster font have been change to Josefin bold


Josefin bold is actually JosefinSans-Regular.ttf in the font folder make sure to change that HERE


Reverse the mentioning of the function params here, to match the new order.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20110/testReport/) for this commit**


hd: is intended to be used only with a .iso file in the directory.  We don't support the exploded tree method.  See also 54dc9b1478ceaebed753bb517c4ae6edd8e12eda.  This commit would need to be updated in light of that.


I am in master and I only work JNA on my p- branch


ok. not pretty but let's stay consistent in that case


If `<h:head/>` is not present, Primefaces theme will not be loaded.


All #5EC8BE colors have been changed to ------> #1D718D.


please remove any empty lines. <b>Hint:</b> you can type CTRL+Shift+F in eclipse to auto format your code.


Why?


we will use TestNg, so this import library is not required. <b>Hint:<b>Ctrl+Shift+O - will auto organise all imports that are not used. Always take a look on the Problems tab in your IDE and fix the exclamation messages displayed if any.


I would start optimizing this class with selecting a better data structure for lineMappings.


Added the compartments file for the three bacterial model templates.


Should I apply this everywhere I use `this.options["..."]`?


DONT CARE ABOUT THE .SVG FILES JUST REPLACE THE assets/img FOLDER


First I'd like to understand why we're setting `PATH` there in the first place.  Needs a comment.


you should static import FILE and SUBVIEW for better readability


Intente trabajar un método equals() desde cero pero no me resulto, con lo cual busque uno implementado en algún ejemplo, lo estudie y lo adapte a las variables de la clase, resulto que el test funciono de esta manera!!!, pero aun me falta estudiar un poco el funcionamiento. La info la saque de este link: http://stackoverflow.com/questions/9791931/remove-equal-item-from-java-list


You can already create these with xml right? If so, doesn't this mean this introduced a lot of redundant code?


it is


i just kanged the commit message from faux


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


same all colors '#3E4147' have been replace with '#121415'.


81211464-LinkInfiltrationAndReturnFlows (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1815 of 1816 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.94%25-yellow.svg)


Please format the code
Hint: Ctrl+Shift+F


Intentional for this test. Trying one thing at a time.

Steve
--
Stephen Beaver | +1 (512) 646-4100;239 | sbeaver@netgate.com | www.netgate.com

> On Sep 4, 2015, at 10:55 AM, Phil Davis <notifications@github.com> wrote:
>
> @sbeaver-netgate <https://github.com/sbeaver-netgate> this has also changed back the "emanresuptms" stuff.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/pfsense/pfsense/commit/13b514b5e9be46a0b81bb64437cab06530a121b8#commitcomment-13071517>.
>


Alpine seems to ignore the hostname provided by the initrd and instead grabs it from what I assume is DHCP.


it would be better to test aggregation with a PROJECT_VIEW as a child of VIEW
nice to have is an empty SUBVIEW or SUB_SUBVIEW


We should be consistent with the ordering of this tuple, and I think I’m actually inclined to the old one.

1. it matches the `key -> value` structure of a map and
2. it matches the “annotation comes first” approach of Writer and Cofree.


@nulani good catch, it's certainly the cause of #10


I put it so I won' t break the existing code.


86139842-AddAutoSizing (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1295 of 1295 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.02%25-green.svg)


This change is Ubuntu specific. This commit should probably be change or reverted.


first file


Bullshit. This commit was made about a day after I did OC a few months back. also. this does not work. you missed half the commit. -.- dont call me out for kang when you do it your self you piece of shit


What happens when you completed the last level?


Well, it's going to break things if the uuid field is called `id`. If we have legacy code depending on this, let's keep the old one around (with the old name, and a big fat comment on top that it's deprecated) until we got rid of the legacy code and simply use the new one without having to worry about backwards compativility.


But it's marked as `@PathVariable`, how come it thinks that it's a part of DTO?


@michaelcahill, do you remember why you made this change?

Obviously, the change was to avoid testing that `mod->mod_split_txn` is visible in some case.

In the current system, `__wt_page_can_evict` is called, with the `check_splits` flag set to 0, from two places:
* `__wt_evict_file` (the `WT_SYNC_DISCARD` case),
* `__evict_review` where we're doing the final check for eviction.

First, I think `__evict_review` should perform this test before evicting a page. (I don't think it's a bug, because all of the paths leading to `__evict_review` have already called `__wt_page_can_evict` with `check_splits` set to 1, but I'd like to change `__evict_review` out of sheer paranoia, and to avoid future problems.)

Second, I think that `__wt_evict_file/WT_SYNC_DISCARD` should perform this test before discarding a page, because if we don't pass this test, then I think it means something pretty bad has happened, and we should not be discarding this page.

If both of those are correct, then I think we should remove the `check_splits` argument from this test.

@agorrod, this is the discussion related to your comment: https://github.com/wiredtiger/wiredtiger/commit/3f3c3a5#commitcomment-13066937


Wenn ich das richtig sehe ist das für Fälle gedacht in denen Organisationen (zB. ein Verkehrsverbund) im RIS der Stadt als solche geführt werden, aber - aus welchen Gründen auch immer - selbst auch ein RIS mit OParl Schnittstelle haben.

Auch denkbar ist in Berlin zum Beispiel, dass zusätzlich zu den Bezirks-RIS-Instanzen noch eine für die ganze Stadt entsteht, die dann alle anderen referenziert.


could using a test specific implementation of `MeasureComputersHolderImpl` (as a Rule, maybe) save all this hardly readable purely technical code? (by saving on creating a MeasureComputerWrapper for ex.)


Plese check with the online site ( http://destination.geo-solutions.it/siig/ ) that the same layers are used.


in events dictionary instead


better move this to the end of class


FYI @peter-fogg


Ok, regarding `const char *rvalue`, that means the final `!isempty(...)` check needs to move here. Should I return -EINVAL in that case?

I'm really wondering whether logging should happen here instead and this should get a prototype closer to the one in the `config_parse_*` ones with all the information about the file and line where it was found...

The alternative would be a more or less generic message: `Invalid syntax` which would not indicate whether it's not a number, trailing garbage, etc. but given we can *show* the example, I think something general might be enough... (Though will that still be true when we accept more complex sintax, with dashes between numbers, special `*` for all CPUs, etc.?)

Thoughts?


Authored on Apr 26th. old commit. you did kang and realized it never worked. I am the only person to have ever had working overclocking on falcon.


Oh I see, that was actually pre-exising (in `config_parse_cpu_affinity2`) but I'll make sure I update it.


Outsider perspective... it's not clear to me what/where the components are. I *think* you run the distil-hq as a server process but the client app is running... somewhere? This could be more clear.


haha oops. I am the whitespace king LOL. How do you find them? I try to make sure I don't add them but sometimes still do even without using tab. Those are old and my fault, I just copied ALL my arrays for this and pasted instead of just the needed ones since I already fixed the order


In the older branch @petervo commented
> I don't think we are relying on it anywhere in the daemon

I say just remove it.


Out of alignment with the rest. :)


Why the package is not imported ?


Y que tal **createFrom(:abc:)** ? entiendo que quieres ser semanticamente correcto


parameters, variables, method names


What motivated the switch in syntax / REST methods used here in the tests? From getForObject() to exchange()?


LOL how dumb+overconfident are you, you just kanged faux's original commit which added the oc steps but it didnt actually work.
Also moto hardlocked our frequencies to 1.2ghz so oc will never work with moto kernel (cm).
OC is indeed possible with a caf kernel and our device didnt have it back then.
And also accept my hangouts chat invite :)


Why do we need a map at all, given that the mapping is completely dense? Why not use an int[] and reallocate it as needed?


current is next value returned by next, bad naming.


So the BeagleBone is trusting the user based on the shared secret (code) but how does the user know that the beaglebone is legit? i.e. seem like the user is trusting that the beaglebone is authentic merely by connecting to it.

If you aren't considering the threat of spoofing a beaglebone, then you should acknowledge that in your assumptions.


Ah ok, the key to your comment is `return 0` on failure to parse, just log that it's ignored and not really propagate the failure. Got it, will update on the next push.


ok


isn't commit title too long?


also here is the commit from which i "kanged" my commit message:
https://github.com/faux123/moto_g/commit/8578ee9902db39b76ee4b0d83bd9b39c77ccd5a3


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20113/testReport/) for this commit**


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 598](http://build.prxm.it:8811/viewLog.html?buildId=3959&buildTypeId=Jarvis_DocumentStore_CI) is now running


qe


I don't think that anything will break if the uuid is called `id`. The `id` you see here is only used to create the `_item` (which is later added in the `self.info` list). The `self.info` list is used in the case of having forms that are not WTForms (like in the call for abstracts, where we add abstract fields). So this `id` does not affect the surveys.
Do you want me to put a comment on top still?


Put these in variable constants. i.e. `User.GENDER = { ... }`


@darkxeno Could I help you somehow with this? I really what this to be merged


Because it's unnecessary. `private` is implied for enum constructors.


Can we move this to the https://github.com/chef organization?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20114/testReport/) for this commit**


@jklontz LGTM


I think "valid Content Security Policy" needs to be a reference of sorts, because it very much looks like the name of the specification and is not really explained from first principles. Otherwise this seems fine.


works now


I think we should also check if the `connection.getEstablishedSession()` is active or not. maybe `getEstablishedSession` should return session only if it is active ?


@tmcw is this another detached DOM thing? This is a valid element within the component:

```js
const HSVTab = TestUtils.findRenderedDOMComponentWithClass(colorpickr, 'cp-mode-hsv').getDOMNode();
```

But calling `TestUtils.Simulate.click(HSVTab);` on it returns:

```
not ok - e.nativeEvent.stopImmediatePropagation is not a function
```

Note that the function attached to the `onClick` handler is called it just doesn't recover from `Simulate.click`.


Не вижу разницы до и после. Где-то что-то ломается?


OH, well yea those are easy lol. This is sweet, I was looking at fonts last few days, trying to figure out exactly what I need to add my own so I can change the default to the one I use in my theme. With these for the clock I love being able to use bold italic finally


Ahh sorry i have been so busy. Let me try to check this weekend what we
could do together at least to have the actions covered by the test. I will
send you another email this weekend. About the whole system testing that
will take much more time and i will be leaving for holidays in a few days,
i will try to continue with it after my holidays, next month.

And thank you for your interest.
El 4/9/2015 5:09 p. m., "Sergey Lapin" <notifications@github.com> escribió:

> @darkxeno <https://github.com/darkxeno> Could I help you somehow with
> this? I really what this to be merged
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/darkxeno/redux-devtools-gentest-plugin/commit/d287b2006aced5f33f5d062a4782c9f887ad8622#commitcomment-13071886>
> .
>


Why you need to filter these values? What is the bug?


Yup. We will create some optional packages to extend jmccc, like resource downloading.


Any chance we can make this language agnostic? I reallllly like this reading! and it doesn't look like it *needs* to be ruby specific. Need to change the `.learn` as well


So, I'll change the description of these methods to something like "look in the <superclass name>".


Will do.


По умолчанию стоит `flex: 0 1 auto;`
Вторая цифра означает можно ли уменьшать размер элемента, чтобы его вместить во родителя, если родитель слишком мал. Чем больше число, тем сильнее можно сжимать элемент, по отношению к другим. 0 означает, что уменьшать размер элемента нельзя. Если не играться с размером панели, то разницы не будет.


oh, it's info, not data. in that case it's fine. then there's no need to deprecate the thing


Because we had an agreement to use FQN in modules. I don't know is it required for now.


Die Formulieren des Satzes verstehe ich aber leider trotzdem noch nicht


Hi,

I still use traceur compile to CommonJS in my project, it means the angular2 node module needs `exports.__esModule = true` in every file.  Since you removed it, is there other ways to do it? (without typescript compiler)

More info on `__esModule__` flag: https://github.com/esnext/es6-module-transpiler/issues/85


Don't worry, it's in parallel with CyanogenMod
And all stuff needed for p31xx/p51xx is moved to espresso-common


Now the timer is the simple-list structure(O(n)), need to be optimized with other more efficiency way.


Damn, didn't work out: mono does always return false for Environment.UserInteractive .. WTH


@dprince I've added a new param in f0b4735 called 'initliaze_host', which can be used to specify which host to use for replicaset initialization.

Lmk if that works for you :)

Cheers
Gav


Sanjeev, im a Grad student at WCU and this is the last class im taking before i graduate, its been very challenging this far. i was hoping if u had any tips or midterm/final questions that you would want to share with a brother. Thank you


Win win situation....


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 599](http://build.prxm.it:8811/viewLog.html?buildId=3960&buildTypeId=Jarvis_DocumentStore_CI) is now running


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 598](http://build.prxm.it:8811/viewLog.html?buildId=3959&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 290 Build time: 00:13:12
### Failed tests
```
Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.DocumentControllerIntegrationTests("v1").verify_de_duplication__not_delete_original_blob_before_15_days: <no details avaliable>

```


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1820 of 1823 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


CSC 530


Timezones are mainly going to be an issue if we go back over 100 years, then we start getting weird time differences and no real time zones (e.g., Utrecht is a few minutes ahead of Amsterdam). This will also be good for checking boundary cases, like what time it is in London when it is one minute after midnight on January 1 in Amsterdam.


Looks good!


first comment


Yes, but I figured it would be good to include?


Great, I just want to make consistent progress that you already made. After that I have some ideas for future development of this project.


nm I see that you changed that later


Thanks. https://github.com/JuliaLang/Gtk.jl/pull/168


The jsoup jar is needed by Errai, so it can not be in test scope. Fixing that now.


Thoughts @quartzjer?


No it isn't, and this change is irrelevant in the context of your PR anyway.


These lines only relate to sql-sync, and do not affect bootstrap. It is undesirable to have 'root' and 'uri' here, as these values would interfere with the selection of the site specified in the site aliases provided by the command arguments.


Old code did not produce issue, but fixed anyway.


@jasontedor thanks, replaced.


nit: new name


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20115/testReport/) for this commit**


-> https://github.com/mapbox/react-colorpickr/blob/63dc6f3d1b2912931730d416898ea43a7f31c615/index.js#L162

I don't think that TestUtils.Simulate will have the nativeEvent property, since they are simulated events.


same


The tool tip was adjusted by window's offset only. In this case, we are further offsetting by <body>'s offset.


wait nm nm no you didn't


Reverse order of parameters h and w


My understanding from chatter in slack was that filament.com would run an email api via e.g. sendgrid (https://getfilament.slack.com/archives/ext-andyet/p1441126309000365)


@vangheem TODO: RawHTMLTile should apply plone.outputfilters during rendering to convert UIDs into.


Update this link?


Oops need to switch this off.


什么


Further taking in the consideration of body width and height. If they are smaller than window's, overwrite window's by using body's.


to avoid such comment, other test use constants for the component refs, eg. `DIRECTORY_1_REF`, `DIRECTORY_2_REF`, ...


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1822 of 1823 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


Try to replace magic numbers like "3" or "9" with proper constants, do the same in other lines


Ты хочешь сказать, `#de-panel-info` наследует `flex` от `de-panel-buttons? Инспектор говорит, что наследования нет. То же самое и с кнопками.


Don't forget to tag the release, @bunkat.


:heart:


The one ". ' '" is not necessary, but that's just a tiny nitpick


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8140/testReport/) for this commit**


Can we both use bitcore instead? I'm using bitcore-p2p and bitcore-p2p-browserify for the network code.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20116/testReport/) for this commit**


Good work with `find_posts` to remove duplication.

The method name `find_posts` implies the method will return multiple `Post` objects. The method returns a single `Post` object. What's a method name that will make this clear?


The code to use exchange() when adding HTTP headers was used in the [Github collector](https://github.com/IDMWORKS/Hygieia/blob/master/GitHubSourceCodeCollector/src/main/java/com/capitalone/dashboard/collector/DefaultGitHubClient.java#L193), l just brought that in mostly unchanged, then updated the tests accordingly.

I looked briefly at the getForObject() overloads to see if there was an obvious way to add HTTP headers to the request, but didn't see any.


Damn, it worked for me earlier.


Happy to take advice/suggestions on this :) for hq-running-in-node crypto performance/availablity should be fairly good.


:+1: from reading, just one tiny nitpick


and fix for https://github.com/libasys/contactsplus/issues/54 preparing contacts+ for birthday calendar on calendar+! bump version to 1.0.6


Can you limit the exception handling to the first line, something like:
```python
try:
    revision = Revision.objects.get(pk=pk)
except Revision.DoesNotExist as exc:
    log.error('Tidy was unable to get revision id: %d. Retrying.', pk)
    tidy_revision_content.retry(countdown=60 * 2, max_retries=5, exc=exc)
else:
    tidied_content, errors = tidy_content(revision.content)
    # etc
```


This should have come up in review, or in the TODO-culling step. I don't think this is necessary - and even if it is, it shouldn't be here, after the code has been merged to master!


Same as before, bitcore also has a base58 encoding library. See https://github.com/bitpay/bitcore/blob/master/lib/encoding/base58.js


Did that so scripts won't be loaded when they aren't needed. Are you using this for form validation?


Ha, you're right, friday I guess ;)


This fix is wrong, those two symbols are always available on mono. See utils/mono-threads-coop.c.


This shouldn't produce an exception: pick_val(range(10), 100000000) should be 0. Rewrite your test to reflect this.


Yes, validating forms when logging in and signing up. Otherwise console throws an error about jQuery not being found.


I see a lot of stuff here I'm not familiar with, I'll open an issue to talk about dev libraries and testing.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8141/testReport/) for this commit**


97215920---Fill-Gaps-in-HVAC-Components---Initial-Code (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


lgtm


Это просто значение по-умолчанию. Как у `div` значение `display` по умолчанию `block` (хотя ты этого не видишь в инспекторе), так и у любого дочернего элемента `display: flex` или `display: inline-flex` значение `flex` равно `0 1 auto`.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8142/testReport/) for this commit**


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 599](http://build.prxm.it:8811/viewLog.html?buildId=3960&buildTypeId=Jarvis_DocumentStore_CI) outcome was **SUCCESS**
Summary: Tests passed: 292 Build time: 00:12:54


true, wrong place - can i add it above the TODO step above, or just leave it out?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20117/testReport/) for this commit**


ok because I don't see any agreement documentation in the class javadoc about that.


Consider breaking up this logic into smaller functions. It's difficult to tell at-a-glance what any of this does.


This is a little strange to me -- I would think this is either not needed or could be replaced by `list(manager.all())` if the `QuerySet` returned by `all()` truly does need to be converted to a list here.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8143/testReport/) for this commit**


From my standpoint it looks okay.


Задал фиксировано малую ширину для `#de-panel`, кнопки размер не меняют даже с `.de-panel-button { flex: 0 1 auto; }`


Is there an issue with the lasts commits ? I can't "make" anymore with 3.12 or 4.0.2...

>swan@vm-swan:~/geneweb_master$ make
cd wserver; make opt
make[1]: entrant dans le répertoire « /home/swan/geneweb_master/wserver »
camlp5r pa_extend.cmo q_MLast.cmo -o pa_macro5.ppo pa_macro5.ml
ocamlc -c -I "`camlp5 -where`" -impl pa_macro5.ppo
File "pa_macro5.ml", line 103, characters 10-20:
Error: Unbound module Bytes
make[1]: *** [pa_macro5.cmo] Erreur 2
make[1]: quittant le répertoire « /home/swan/geneweb_master/wserver »
make: *** [opt] Erreur 2


@tristil I did. The spec for `add_polymorphic_constraints` now expects an error. ActiveRecord raises that exception on 4.2, and we raise it when foreigner is being used.


Consider re-wording this conditional from

```
if (!x) {
    ...
} else if (x) {
    ...
}
```
to

```
if (x) {
    ...
} else {
    ...
}
```


I would like to add a commit message explain why we now need this.


How about:
```
+- [ ] **Submitter**: Review code comments; remove done TODOs, create stories for remaining TODOs
```


i'd rather see this in the culture repo :-p


Значит ширину кнопки уменьшить невозможно. Я добавил просто так, тащем-то. Чтобы просто наглядно видеть, что я от разметки хочу.


Consider re-wording conditional (same as above). It just makes it clearer to see that all cases are handled when there is a trailing `else`.


#4854-ZoneHVACOutdoorAirUnit-does-not-autosize-child-objects-correctly (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (764 of 765 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.87%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-10.44%25-green.svg)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20118/testReport/) for this commit**


Ah, I didn't think about that. I'll work on a hybrid function that can either use a return value or a callback. Or I'll make a new option for async calls.


I had seen the nice image of a top-left corner menu that was supposed to appear in Grasshopper but I couldn't get it to happen before.  It works now though. Strange. :)


The fabfile handled running tasks inside the VM. I would like to add a commit message explaining why we no longer need that.


lgtm


Я тоже просто разбираюсь, что к чему.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8144/testReport/) for this commit**


Null is a valid value, probably a default value is better here?


How could you DRY up the common code in the `if` and the `else` blocks of the `UsersController#update` method?


Here is where your postgres setup should be.


I see now. Yeah I was looking at that expectation but I didn't understand how it was the same thing I was talking about.


`%` and `'` are not part of the reserved character set, according to [RFC3986](https://tools.ietf.org/html/rfc3986#section-2.2). I would like to keep the function as correct and RFC-conforming as possible.

However, that doesn't mean you're right about escaping them. I believe the correct algorithm should be: "escape reserved chars and common [data characters](https://en.wikipedia.org/wiki/Percent-encoding#Character_data), and everything that's not unreserved". Would you agree?


Is this an edit that should have been made earlier? Did something change in our dev or CI environment that requires this?


I'm quite proud of this one :)


Make sure this is not what you are using in production.


I would like to add a commit message explaining why we are setting this to True.


This logic is now duplicated with `visitSource` and may break if changed only in one place


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20119/testReport/) for this commit**


Started reviewing from the last commit, i.e. this test – this is awesome :-)


It's `ERR` not `ERROR`. Apparently two extra characters would be too much :)


Разница будет наглядно видна, если поставишь `flex: 0 0 auto;` в `de-panel-buttons` тогда при уменьшении кнопки будут сначала обрезаться и только потом переноситься на новую строку, когда при `flex: 0 1 auto;` они сразу будут переноситься, если им недостаточно места.


81211464-LinkInfiltrationAndReturnFlows (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1821 of 1822 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


The next commit touching these lines probably would be named "Simplify code". I think it's worth adding that it's there for performance reasons


I did the plugin upgrade on our system and it worked without issues.

I did not test a downgrade.


This was not in the change log.


http://stackoverflow.com/questions/8622497/why-can-constructors-within-an-enum-in-java-be-declared-only-private

I don't want to put every little thing I change in a different PR... that would only clutter the PR page.
I already separated the commits by concern.


Hehe, BPF is sort of write-only, but if you agree with the inline comments "Sender Hardware Address must be different from our own" etc, that's good enough for me.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20120/testReport/) for this commit**


Why starting the version of a new module from the version of the features it replaces?


This merged a bunch of unresolved conflicts into master.


Do you prefer signal names over signal ids ?
I always put all catchable signals when I use trap, just to be sure :-)


Should this have been `tags->'state_capital' AS state_capital`, or should we add `state_capital` to the osm2pgsql style file?


I couldn't see it, so please let me know if you remember....


Only if you think this will make the code easier to understand, consider refactoring this so the primary model object (`@topic`) is very clearly fetched in the controller actions mentioned on line 2.

(You may recognize this is similar to the refactoring you did in the PostsController to remove the `before_action`.)


I'd say "By default ..."


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8145/testReport/) for this commit**


These look awesome! I would add:

* Explain the purpose of the $routeProvider in Angular
* Explain the purpose of templates in Angular
* Explain the purpose of services in Angular
* Compare/contrast the components of angular to OOJS / Backbone.js


Since `App.projectNumber` is set in `projectCleanUp`, it looks like it actually represents the previously-loaded project, right? Consider adding documentation for this variable. Referencing the original github issue # could also be helpful.


@cornae Thanks! Less is less. They only asked for less...


I should have been clearer with my first comment. I didn't see that phrasing near the end of the line. I was talking about changing "to store your data close to Compute Engine" to "to store your data close to a Compute Engine".


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.490.d4e498413f74967b26f9b9c2bdee47feb3adbd16](http://build.palaso.org/viewLog.html?buildId=62702&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:18:40