 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


could use `Preconditions.checkState` or a method to avoid ugly if statement stacking


no log (DEBUG or TRACE) if an attempt to cancel an unknown task was performed?


I did escape the quote, can you merge?


**README - Awesome**
This now looks good.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.479.641b38f5d00c0b766145a17ba93f1eff77b10ed7](http://build.palaso.org/viewLog.html?buildId=63416&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:18:11


When entering an email address and entering `,` straight away (e.g., enter "foo@googlemail.com"), the last letter of the entered email address is sometimes lost. (e.g., it will generate an item for "foo@googlemail.co"), presumably when the search request hasn't finished yet. We should make sure that we take the full value of the field when a termination character is entered.


P.S. См. также: http://stackoverflow.com/questions/1614139/spring-transactional-read-only-propagation


Reviewed PR and good with merge.


from http://grammarist.com/spelling/cancel/:

> In American English, the verb cancel is usually inflected canceled and canceling—with one l.


i could skip the `Array.asList()` by using `Collections.addAll(collection, array...)` but not sure if that is necessary.


useless `String` in `String.format`, `format` is statically imported


Since the commit was amended, the previous comments can be found [hidden here](https://github.com/andela-bkagia/php-checkpoints/commit/dd885eee694f807a1e242df744394d614a1239ec)


hi how are you


I'm aware of this, but I'm not going to use them before initialization... is it still dangerous? Okay.


So, I don't see a game_spec` on this commit.


Thanks for the link to the blog article. An interesting thing here is that the new XML output seems to work independently of the `testInstrumentationRunner` you set in `build.gradle`, and the output seems to be generated by [XmlTestRunListener](http://grepcode.com/file/repo1.maven.org/maven2/com.android.tools.ddms/ddmlib/24.2.3/com/android/ddmlib/testrunner/XmlTestRunListener.java/) which has been around for a long time. I really wonder why Google did not implement XML output earlier then.


i tested again with the newest version and timer works correctly! no idea how i broke that yesterday..

i noticed that as a masterlooter you can give items to players that ported away, i dont remember if thats blizzlike but i think they have to be in the same map to receive items


putting this `queueStatus` specific code would really help understanding what the remove task does


Shouldn't this check for entityname in root now instead of modelname?


could you rebase without this commit so I can merge the PR?


Je l'ai mis dans patacrep, car je pense que ça puisse servir à patagui (ou dans un template personnalisé en texte brut par exemple)


Заменил.


I usually trust @floatingatoll when it comes to bash best practices, so :+1:


This was a bad bug and must have affected the tower evaluations. I've developed a process for testing the evaluations for correctness under multiple collisions and with lots of secondaries. I'm on a search and destroy for other things like this...


I spoke with your client today.  He's happy with the overall design of the screens.  One thing to take into consideration is on the Reservation screen.  You will want to add a button that allows the user to leave the form without making a reservation.  Your user may decide not to make a reservation and they should have an easy way out.


useless line return


@kohsuke This broke the PR builder: https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core/3152/ (CC @jglick)


done


I think we can actually use a built-in validation here:
```validates => email, uniqueness => { case_sensitive => false }```
According to http://apidock.com/rails/ActiveModel/Validations/ClassMethods/validates#1064-case-insensitive-uniqueness


A lot of nice clean ups! I have one minor comment though. Please consider using the same spacing as the rest of the file. I.e 2 spaces. (multiple occurrences)


Looks like a copy-and-paste remnant?


A mi me faltan subir unos test, hoy a la tarde los cierro, subo y les aviso así mergeamos.


Die passieren jetzt im WebUser.


Temporarily maybe in development, but in repository (where the apps are build for the public) we could target the latest API for activating new features (e.g. Material).
During compilation the SDK levels can be checked through tools like Lint, etc.

(I pushed the ```build.gradle``` improvement)


`ngx_small_light` takes on C89 style. So move the variable-declarations (uint32_t webp_magic1, webp_magic2) to the top of function, please.


TeamCity DNN JavaScript Libraries :: CI [Build 80](http://teamcity.engagesoftware.com/viewLog.html?buildId=352&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


@adrianschroeter Yes, that would be ideal.

As for right now we have
- a package model which is ActiveRecord
- a patchinfo model which is Active XML based
- each patchinfo is stored as a package instance, which contains a '_patchinfo' file. That's an xml file
- as for right now the patchinfo model is only concerned with the xml that the backend consumes.

In other words, I can not simply rewrite this in a single pull request. Current situation is that patchinfos are handled as packages. Thus I believe the method belongs to the package model.

But I definitely agree that split concerns better.


implementing `org.picocontainer.Startable` would replace this comment with strong benefit, imho


I did ldd on /usr/bin/keepassx and couldn't find it being linked to any library connected to qtconcurrent. Am I thinking of this wrongly?
````````
        libQt5Widgets.so.5 => /usr/lib64/libQt5Widgets.so.5 (0x000000335ac00000)
        libQt5Gui.so.5 => /usr/lib64/libQt5Gui.so.5 (0x000000335a600000)
        libQt5Core.so.5 => /usr/lib64/libQt5Core.so.5 (0x000000351b600000)
````````


TeamCity DNN JavaScript Libraries :: CI [Build 80](http://teamcity.engagesoftware.com/viewLog.html?buildId=352&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:19


Quote 'Void' for haddock?


Thanks for the fast turnaround! For posterity, the PR is https://github.com/borisyankov/DefinitelyTyped/pull/5880.


Alright, I'll remove the change from this PR


wow, thanks @PeterBengtson, great work.


Fixed.


YAY :+1:


А удалить отсюда бин с дао не забыл?


It returns:

0 *
@
@
@
@
1 *
@
@
@
@
2 *
3 *
@
@
@
@

0 -
#
#
#
#
1 -
#
#
#
#
2 -


please update the commit message with something more relevant


README.md


Use C style comment (`/* ... */`) instead of C++ style comment (`//`).


+1 on x11!


Tim,
     This is interesting.  If I remember correctly, Visual Studio has a way of creating a model of the data so you can see the relationship between the tables in graphic form.  Having that would probably be of benefit to your team.


Не жалей пробелов, `nullable = false` выглядит читабельнее же.


I think it's probably worth specifying the text of the actual error we're looking for here.


:+1:  (fix commit message)


Fair point.  I'll refactor it out.  The result of the compare is used in on the cases so the func will need to return that as well.


Ok,I understand.Thanks!


Is there any way to get `Already have an account?` a bit closer to the `Sign in` link ?


@adrianschroeter Where did you get this specific error message from?


Could you open a bug and assign it to me next time.
Restoring old code is completely breaking composer and making not only my work useless but also a big mess of the source code.
Besides I had segregated each composer integration in a commit so we could easily revert one rather than doing what you did.
I'm committed to maintaining it if necessary.


Refer to my explanation in https://github.com/phonegap/phonegap-plugin-push/issues/117


I will in a bit, I have to fix some other things with the `build.rs` first that I didn't have time to finish last night.


What about other GameRules?


This spec passes whether or not the new code in the user model is available - because the errors on a particular attribute will be an empty list if there are none - so it is never nil. I think it's worth converting this spec and the one above to look for a specific error message.


good one


Good point. My bad. Since the PR is now closed I'll change it back the next time I create a PR for this module, probably in the not so distant future. @qdp-odoo I hope you're OK with that.


added. Will push the update ebuild once the qtconcurrent runtime thing is solved.


The `href` should be removed


Здесь возможна XSS-уязвимость. Прочитай про нее обязательно и поправь.


No it doesn't


nice tests!


Cool, thanks for checking


uhm ok... I guess it uses some header-only functionalities of QtConcurrent then...


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.480.641b38f5d00c0b766145a17ba93f1eff77b10ed7](http://build.palaso.org/viewLog.html?buildId=63419&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:15:08


I've narrowed it down to cancancan acting up because it overrides the loading of resources


<gap:plugin name="org.apache.cordova.battery-status" version="0.2.11" />


You're welcome!


Good catch.


Откуда берутся эти коммиты с мерджами? По идее их быть не должно? Поди ты правишь файлы через редактор гитхаба, а потом не делаешь `git pull` перед тем как сделать новый коммит в своей локальной копии?


I would use 'Canceling' or `Canceled`, maybe a matter of taste


Please add some comments about why this logic is needed


Уже много-много лучше. Я про атомарные коммиты.


Why can't we move this event handler to props and bind it to actionCreator with @connect?


I get an error:
```java.lang.NullPointerException: Attempt to invoke virtual method 'com.pushtorefresh.storio.sqlite.operations.get.PreparedGet$Builder com.pushtorefresh.storio.sqlite.StorIOSQLite.get()' on a null object reference```
in ```PersonCarsFragment.java``` at line 113


@emmett9001  I think this change is pretty neat, because it removes the uncertainties with how quickly the threads end, and it still does this without wholesale blocking the producer. There are still two gotchas, noted inline above.

I was just trying to imagine how you could fix those (without just grabbing all the OwnedBroker locks, which would be my lazy solution). So I have two ideas, one of them maybe very crazy - let's just see what you think :)

The first idea would be to make `OwnedBroker.stop` trigger a forced sending of all the remaining messages, so that is, you don't try to re-queue them but try to get them out, and the messages to some brokers will fail, and be re-queued by `_send_request`, which deals with all the `max_retries`/`attempt` logic already.

To prevent ordering issues, the only other thing needed for that is that you could already start queueing any new messages on new `OwnedBrokers` but making sure their worker threads don't start until the old workers are done sending everything.

The second idea is probably too crazy because it changes a lot of stuff around, but anyway: what if the messages were queued directly into partition-specific `MessageSets`, not owned by the `OwnedBrokers`? So basically `Producer` would gain a list of `MessageSets` (one for each partition in the topic, and each with its own lock), and the `OwnedBrokers` basically just hold a list of which partitions they lead, and a `messages_pending` counter? (And so that means a `_send_request` locks the appropriate `MessageSets` and swaps them for empty ones, then sends them out.) Then, when a cluster update occurs, you can leave all the messages where they are, but you tell the `OwnedBrokers` to start using a new list of partitions (and you'd have to correct `messages_pending` accordingly).

I'm sure both of these have further issues which I'm not seeing. Maybe just grabbing a bunch of locks, getting this merged, and then trying these ideas later is more expedient?


`!!` is not required here


Before we discuss this, please read up on how exceptions are used in Python. I'm not having another basics discussion, it is a python specific idiom, and we really should getting used to using idiomatic python, not independent of our school's teachings ;-)


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.59.635415b751bf8b1235da203f1e55e7a8e9890b99](http://build.palaso.org/viewLog.html?buildId=63418&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:34:26


@baghaii good catch!


It's a bit weird that this signature says noting about what types are appropriate for the function arguments. I mean if someone is going to use int or std::string as the type, who is responsible for it? :) Will he get an error only during the actual run of the function?


Unchanged methods:

1) Undo (for adding a task, deleting a task and changing a variable in a task)

2) Adding a task

3) Deleting a task

4) Changing  a task's variable except comparisonValue (7 variables applicable)

5) Searching for tasks given a search term, which must be one of the variables of a Task except comparisonValue (7 variables applicable)

6) The method for sorting task lines in the schedule .txt file, by date and starting Time (using comparisonValue in Task.java). This method is called only for adding a task, deleting a task, and changing a variable in a task.

7) Exiting the program

New methods:

1) Able to show a given week's task, given the starting date (in the correct format)

2) Able to display all tasks with the user input command Strings starting with the word "show",
and able to sort and display tasks according to the 7 variables in Task.java (meaning excluding comparisonValue, which is the 8th variable in Task.java).

Note: For priorityLevel, tasks with priority levels which are purely numbers, will be sorted from negative to positive, while this is not the case for tasks with priority levels that are not purely numbers.

Group/team members, if there are errors after testing, or code you want to improve on, please attempt to change them first, and push them to this repository. Only if you have problems with the coding, then please let the rest of the group/team know. Thank you.


shoudln't this class be a `ServerStartHandler` so that it runs only when server has successfully started?


ho yes, i wasnt't aware of that mart-e. sorry


missing `Objects.requireNonNull` to enforce getter contract


Do you still need anything from me?


You can edit file manager - it's opensource software)


shouldn't you rather call this?


 @bananaGator thanks for your effort man. actually I get the parse installation id in my app. it means the devices registers in parse. but then when I use parse push panel or when I use it's rest API, it says, push sent but Nothing shows up in the phone notification panel. other devices which has a version of app with a different parse-push-plugin receive mentioned notification.
by the way I have only the register function right now. do you think that not having window.onNotification function would affect receiving the notification to the device?


Довольно оперативно! Работает в последнем palemoon.


I usually add `@Nullable` on the argument


I think we should be binding all events explicitly via props to outside world, and then using @connect to connect with action creators.


This breaks the build.


Ich schätze mal nicht.
Wenn ich die Exception jetzt hier einfach werfe, dann müsste ich noch 2 andere Klassen verändern, einmal IComponent, weil die init-Metohde von IComponent hier überschrieben wird , somit müsste die MEthoden Signatur um "throws IOException" erweitert werden und noch die Protocol.java, weil dort der Code ausgeführt wird und  spätestens dort die Exception behandelt werden muss.
Sollte ich dann in der Protocol.java die Exception erst loggen und dort dann die weitere Abarbeitung abbrechen und vielleicht sogar eine MessageBox für den Nutzer erzeugen, mit einem Hinweis, dass es leider auf Grund von Schreibrechten oder so nicht Möglich ist das Prologprogramm auszuführen?
Sorry habe mich leider bis jetzt noch nie so wirklich mit sinnvoller oder praktischer Exceptionbehandlung auseinandergesetzt :(


I say nothing :)


自适应屏幕


lgtm thanks Andrew!


Jo, jag vet! Det kommer, är inte säker på om jag ska använda denna eller inte..


(When you're working on HAML, you really should do so when running a local server and add it as a pull request, to ensure you do not break building, as it checks*.)

_\* …or if it doesn't, we can talk with Michael and make sure it checks that it builds. We have it set up for ManageIQ, and it prevents problems._


Actually after starting to refactor it out, I don't think it really improves readability, and it certainly sacrifices a bit of performance, because in all cases it does something special if the key matches the node's key and continues otherwise.  Putting it into a function would mean doing something like this:

```Go
	// Traverse left or right depending on the result of the comparison.
	node, compareResult = chooseNode(node, key)
	if compareResult != 0 {
		continue
	}

	// Key matches, do stuff...
```

As you can see from above, it also means another if statement to compare the result for the case when the key is equal on every node traversal.  Also, it adds the overhead of another function call.  Given this will quite literally end up being called hundreds of millions of times, extra checks are non-trivial.


加入自适应屏幕代码


separating `CETaskSubmit` into `PreparedCETaskSubmit` (contains only uuid field) and `CETaskSubmit` (contains all fields) would allow having immutable beans, close the door to doubt about where setters might be called and enforce close control on lifecycle of these objects


A lot of magic numbers used here. All primary constants should be refactored into variables. E.g. we can have a basic constant `$u = 12px;` and then use stuff like `margin: $u 2*$u;` etc.


We might want to make this a style in `oae.base.css` as I can't see any reason not to apply this everywhere


Can you change this to capital `A` ?


missing `Objects.requireNonNull`


missing `@CheckForNull` because bean is mutable (urgh!)


Same goes for colours: all colors must be declared as constants, e.g.:
```
$red: #ff0000;
$color-primary: $red;

.selector {
  color: $color-primary;
}
```
You get the point.


Hi Jonathan,

I think youve missed out the core definition in the machine (unless im blind, which is always possible)
I also dont think we need the edge id on the routing tables. I might be wrong, but a table isnt assoicated with an edge, its its own thing.

for completeness (thou i note our discussion said id do it) missing partitionable graph.

I think we'll also need to see about our other constraints from pacman and see if they can be mapped to constaints. but ill do that when we finally get there next week.

Apart from that, i think we're doing ok. good work.
Alan


This method takes time O(n) and space O(1)


When we alter the workflow, `(above)` can be removed


in addition, I can not tell which fields are actually mandatory when submitting a `CETaskSubmit`


I might say something like:
"This case study focuses on the Pyrite3D Client implementation and demo application.  You may benefit from first reading the overview case study, [Vizualize.... ]"


The broken air control of bots bounced off by jumppads was caused by a sv_fps value of 60.
Not related to bot_thinktime. (reverted/fixed in https://github.com/KuehnhammerTobias/ioid3-engine/commit/ade6fd818b14418bf6b2198835c0fc43918b1369)
Check why a sv_fps value of 120 will not cause this bot issue.


+1 to the alteration.. I didn't have issue with the original, but the alteration does add further clarity. :)


lol :100:


@adrianschroeter and it's not a generic model. The "Package.transaction do" block was there before and is there for a reason;-)


Great! I hope LTC passes (fast) too.


Fixed in b7ace0ccbaed4b8f4e22ec9df78937e162384599


I know ssl check on default centos 5 and 6 with directadmin and csf firewall can give ssl error's.
I know its easy to fix but allot of newbee's quit when they see a error.


Why?
@dimaip I can't see any relation between margin-top-bottom nad margin-left-right


The changes in here need to be applied to the other widget i18n files


Maybe more formal: ```.. are an important tool in many industries, and it is becoming easier and faster... ```


IMHO, this 'CE' prefix is useless and I'm not so found of `Submit`. What do you think of `Request` instead?


Unchanged methods:

1) Undo (for adding a task, deleting a task and changing a variable in a task)

2) Adding a task

3) Deleting a task

4) Changing a task's variable except comparisonValue (7 variables applicable)

5) Searching for tasks given a search term, which must be one of the variables of a Task except comparisonValue (7 variables applicable)

6) The method for sorting task lines in the schedule .txt file, by date and starting Time (using comparisonValue in Task.java). This method is called only for adding a task, deleting a task, and changing a variable in a task.

7) Exiting the program

New methods:

1) Able to show a given week's task, given the starting date (in the correct format)

2) Able to display all tasks with the user input command Strings starting with the word "show",
and able to sort and display tasks according to the 7 variables in Task.java (meaning excluding comparisonValue, which is the 8th variable in Task.java).

Note: For priorityLevel, tasks with priority levels which are purely numbers, will be sorted from negative to positive, while this is not the case for tasks with priority levels that are not purely numbers.

Group/team members, if there are errors after testing, or code you want to improve on, please attempt to change them first, and push them to this repository. Only if you have problems with the coding, then please let the rest of the group/team know. Thank you.


IDEA did that >.<


another idea to avoid the mutable pitfall:
Make `CEQueue.prepareSubmit` return a `TaskRequestBuilder` and submit take a `TaskRequest` argument


`toolObject` is unused


HTML and `scope` should probably be passed in


I think `Resend Verification` and `Resend Invitation` can become `Resend verification` and `Resend invitation'


Nice work! However, the file you want to modify is `src/js/animsition.js`.
Can you please pull request by after the modified it?


Maybe also
```
overflow: hidden;
text-overflow: ellipsis;
```
can help to avoid horizontal scrolling on small screen.


wrong input
`  * Vector to align the coordinate system with <ARRAY>`


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.481.635415b751bf8b1235da203f1e55e7a8e9890b99](http://build.palaso.org/viewLog.html?buildId=63420&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:16:44


just noticed all these new class are directly in package `org.sonar.server.computation`, why not put all this queue/task related code into package `org.sonar.server.computation.queue` or `org.sonar.server.computation.task` for clarity?


There can be some space between the input box and the yellow box. Because they both have rounded corners, putting them against each other is a bit odd.


Absolutely, go for it.


>has outstripped **the** rendering performance

maybe something like:
>Below I describe our approach to constructing a client to consume this data, and discuss the challenges we faced


This is slightly tricky - the change here doesn't preserve the logic exactly - it allows an 'user already exists' mail to be sent for an invalid user - I think although it will be less elegant, we need to check that the rest of the user object is valid (it ought to have one and only one validation error - the uniqueness one on email) in order to go down this branch.


You're welcome! I currently have quite a bit of time to devote to ocean-dynamo, so expect further developments quite soon.


Maybe we should consider using a different method name: https://github.com/bbatsov/rubocop/issues/2260


missing `@Immutable`, isn't?


Yes, because arma is too unreliable. I'd rather have this slightly unrealistic "hardcore noob mode" protecting people and allowing them to slam into the ground at full speed, than the current system where new players repeatedly make multiple landing attempts, and due to no fault of their own die. During high wind, a random gust kicking up at the wrong time can ruin an otherwise perfectly executed landing.


Line too long.


> decodeURIComponent

А это точно нужно?


![Have some bananas](https://farm3.staticflickr.com/2876/9681688504_b5e8689026_z.jpg)


Yea, changed my mind: https://github.com/middleman/middleman-guides/pull/511


@al-martinez DWMR. Good job getting this done. Starting over is often the best path to shipping code.


Otherwise it will leak information - an ill-intentioned person could see that a registration attempt with a particular email address but a missing name results in the confirmation page (as the 'you're already registered' email has been sent) and therefore conclude that the email address is already registered.


This change should not have been made. `PROFILE_VISIBILITY` still exists as a key


Looking at the `user_controller.rb` logic, I couldn't figure out how, if there is already a user with the email address, execution could get to the point where it tries to create the user without falling into the `user_alreadyexists` branch. Looking at the errors we've received, it looks like most of the time it's because the `params[:user_signup][:email]` value has a trailing space. I think we should probably add a `strip` call to `User.find_by_email` to handle that case so that users get sent the 'already registered' mail rather than getting a validation error. It looks like there were a few instances where there was no trailing space - I wonder if those were double submissions - we could disable the submit button after submission (as in https://github.com/mysociety/alaveteli/commit/ce8cb9ea92d43002262099e765cccd064d7ea522) to mitigate against that.


aggiunta riga


Please use const ptrs in places where buffer is not supposed to change.


I will list some things that could be changed. What ever is long hanging fruit can be fixed in this pr.
- [ ] Title should be Branches rather than Projects (you could perhaps include the project display name).
- [ ] The currently selected branch could be grayed out or something that indicates that it is selected.
- [ ] Double clicking a name should open the branch and close the dialog.
- [ ] Open should close the dialog.
- [ ] Unless we display and use more info, it's probably unnecessary to refresh entire list each time on a CONSTANTS.CLIENT.STORAGE.BRANCH_HASH_UPDATED (in the future if we make use of this, we should map the data to the branch-item for this event).


> I think youve missed out the core definition in the machine (unless im blind, which is always possible)

Yes and no ;). This falls under the partitioning problem so I'd err on the side of putting that information along with the other partitioning files. (After all, since the rest of the machine description doesn't have an explicit concept of a core it would make sense to make this seperate. Just a "cores.json" with "core_resources" as a dictionary of resources and values would be sufficient I presume?

> I also dont think we need the edge id on the routing tables. I might be wrong, but a table isnt assoicated with an edge, its its own thing.

Oh boy! That was stupid of me! Good catch! D'oh!

> for completeness (thou i note our discussion said id do it) missing partitionable graph.

See above :) your contributions in that space are welcome. As I say; after thinking long and hard about the issue I came to the opposite conclusion that partitioning was application specific and thus have not attempted to generalise the problem into something which can be easily passed on to another algorithm.

> I think we'll also need to see about our other constraints from pacman and see if they can be mapped to constaints. but ill do that when we finally get there next week.

Definitely. That said, am I correct in thinking the remaining constraints are for key allocation? (I.e. I think we managed to work out the other tricky bits for place/allocate/route constraints).

> Apart from that, i think we're doing ok. good work.

Excellent :) I'll fix up my stupid error and then hopefully this is good to go for now. Thanks for taking the time to discuss all this :) So far so good!


Может забить на оперу 12 и использовать `blob`-url?


Tá bacana. Já revisou o getNumeroSorte pra eliminar uma possível redundância?


We guarantee POSIX shell availability in the install script header, so you can't install the package if you don't have one (see https://github.com/cfengine/buildscripts/blob/master/packaging/common/script-templates/pkg-script-common.sh, Solaris is the only offending platform, but it has one installed by default). POSIX shell functionality is used extensively throughout CFEngine (for example in init script), so certainly we rely on it.

In any case this is Linux-only, so certainly they will have a POSIX shell.


"sqlalchemy" looks like a typo?


I think given that case insensitivity is important, we should probably have a test to demonstrate that it's working.


Sorry, I have been really busy. Should have a chance to look at this within the next few weeks


Indeed, will address shortly.


What happens in this case? Is a partial buffer used?


I know I asked the `PROFILE_` prefix to be removed, but it's probably worth adding it back to `PRIVATE_DESCRIPTION`, `LOGGEDIN_DESCRIPTION` and `PUBLIC_DESCRIPTION` to avoid confusion with other widgets


"Mr Malformed" is probably a bit misleading in the context of this spec - "Mr Duplicate" ?


Whats this UINT64_MAX?


Ясен пень, забыл ((


Essa variavel resultado vc pode apagar, pois nao ta usando ela aqui


done.


Style: indent 'cases'


put this `try`  and the next in methods, save on this uninitialized variable hanging around and keep code clear and short:

```
Optional<CeTask> task = getTask();
if (task.isPresent()) {
  runRask(task.get);
}
```


vida nao pode ser negativa, logo, nao pode ser <=10...


this is the common case, so it should be first for performance


Hey Pau,

The second part of the patch looks suspicious though. Here the intent is to really have unsigned as bitshift is involved? Does it not work using only the first hunk?

Koen


No rush. Just wondering if you still needed anything from me. Thanks.
Sent from my Andriod smartphone

-------- Original message --------
From: jbowyers <notifications@github.com>
Date: 09/18/2015  9:15 AM  (GMT-06:00)
To: kmd1970/chartinator <chartinator@noreply.github.com>
Cc: kmd1970 <kmd1970@hotmail.com>
Subject: Re: [chartinator] Update chartinator.js (177cdf4)

Sorry, I have been really busy. Should have a chance to look at this within the next few weeks

—
Reply to this email directly or view it on GitHub.


tu pode alterar esse if pra nao deixar ele sem nada e o else com algo dentro...


Rather than having a long selector, it might be easier to just give the button an id and use that


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.58.641b38f5d00c0b766145a17ba93f1eff77b10ed7](http://build.palaso.org/viewLog.html?buildId=63417&buildTypeId=bt2) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 734, ignored: 45 Build time: 00:57:04


>To understand the benefits provided by leveraging a streaming client solution, it is helpful to understand the data pipeline and where Pyrite3D adds value.


Ça me va.


In fact, i'm not a big fan of already filled message. I planned to not use the messages sent by ajv for several reasons (localization, composition). In most cases, end user error messages will be a localized templates (http://userguide.icu-project.org/formatparse/messages) filled with given params.

Currently i use `error.keyword` as a key to retrieve the localized message and `error.dataPath` as params to feed it.


Some leftover.


Exit on malloc failure during traffic handling is forbidden. Error needs to be handled correctly.


@pynicolas Thanks, I've added fixme here


Yeah, I agree about actions, but before it we should replace all actions to actions folder .
It was an old variant and I didn't touch him.


@lukasinko Use capital letters for constants please (`STDOUT_LOG_FILE_NAME`) and move it before non-static properties.


Why not to just user `member1` and `member2`? Is there something wrong with ordering?


`theFile` не используется внутри замыкания.


My code is essentially a prototype and might break some behavior. There also some hacks and dirty places. Of course, I can send a pull request to you if you are really interested.


@pynicolas priority now is the same as in old grammar


There's also running a script to update lang-en.json, and then waiting for that to be imported by Transifex, but yeah mostly.


redundancia no getNumeroSorte?


Depends on traffic, so can be 0 AFAICS


if `dir` does not exist, no need to instance a useless `ArrayList`, return `Collections.emptyList` instead


Which can lead to 0 byte allocation here.


Why not move validatePassword to a specific class? Like PasswordValidator or similar. OpenmrsUtil has a name so general that you don't know what's its purpose.


No exits allowed here.


I do, but I figured we could as well use the `?id=` system in production (makes it easier on Android etc) and generated a new one with Syncthing.


This is causing the email icon to no longer be vertically aligned on a mobile device

<img width="524" alt="screen shot 2015-09-18 at 15 21 14" src="https://cloud.githubusercontent.com/assets/109850/9961538/e8ea1fb4-5e18-11e5-953b-092d1f58d69f.png">


Yeah. The toggle for that is below, so that's handled.


sorry...my editor did it...


@pynicolas fixed in af0dcc13f47c5970ceaed836ed1ec738659079cf


hello


I think we should allow it anyway. If nothing else then for testing and stfinddevice.


For readability put buf_len - offset in ()


Can we comment these tests?


Can we also:
```
+        ('${V}', 'v')
+        ('${V}-foo', 'v-foo'),
+        ('$V-{foo}', 'v-{foo}'),
```


Reverting?


Oh, a compile time optimization. OK.


I don't understand this comment.


asList is OK.


We have `seo.tests.factories.SeoSiteFactory` for this, I think.


@akhilnarang no


I guess we should be more clear that 3d reconstruction is a type of mesh, etc.

>Here we will focus on one of the most common ways large meshes are created, from a 3D reconstruction  process known as "Structure From Motion".  While specific steps and technologies used may differ, the process can be split up into discrete stages: capture, process and consume. The following sections describe these in more detail while giving examples from the test data sets we used for Pyrite.


I don't think supporting shortcuts that don't include a modifier key
is worth the chat focus inconsistency. I say we prioritize focus and
require shortcuts to have some modifier (ctrl/cmd/alt/altgr/whatever)

On 9/18/15, ctrlaltca <notifications@github.com> wrote:
> i think we must decide if we prefer having the ability to use single keys as
> shortcuts or to always have focus on the chat. @Daenyth ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Cockatrice/Cockatrice/commit/4c6b543cbe34ad54d21c7deeaac2dc5f8d4c0bc3#commitcomment-13310685


Does this make sense? Should this just be a link to the file and rely on the user saving it to the right place?


are these the right attributes to permit for a topic?  look on lines 24 and 39 to see what attributes you were using previously.


Instead of
> We worked primarily with 2 samples meshes

maybe
> Our demo application leverages two sample meshes


This class is a very bad pattern which causes a flood of the processingQueue, I had to fix it to make Views ITs run

Hard to explain by comment, let's talk about it


Move brace to the linve above.

## before

```
} else
{
```

## after

```
} else {
```


Yes indeed, thanks.


And
>One **is** a capture of Nashville.... the other **is** of a small


I would say that you improved std.cfg, not testing of std.cfg...


`ch_valid` is confusing name for me. It's used only when we find matching '}', so `if ch == '}'` works for me as well here.


No problem, eventually JSONObject will call toString() on ClobElement:

https://github.com/douglascrockford/JSON-java/blob/master/JSONObject.java#L1618

Although the put() method javadoc says the object argument must be one of a few specific classes, so although it makes no difference in practice the change makes the code conform to that javadoc.

https://github.com/douglascrockford/JSON-java/blob/master/JSONObject.java#L1276


I'd probably just drop the last sentence ```here are some of the specific details relate to the captures``` -- they'll discover that on the next paragraph.


Instead of this SCRealloc, just move the regular SCMalloc here. (plus also to the zlib case).


Hm, exactly the code I wrote. Let's merge it :)
<review


Tá show. Ali no ehBissexto precisa usar o operador ternário pra atribuir o valor?


@rahij Why was this commented out? o.o


Do a /health-endpoint


Please enclose in parentheses.

```
if (...) {
    ...
}
```


I know they use the term MAV, but unless we introduce that we should probably called it a ```manned aircraft``` or just ```an aircraft```


Maybe it's better to write like this:
```go
select {
    case s.output <- message
    default:
         s.melody.errorHandler(s, errors.New("Message buffer full"))
}
```
?


Why another alloc? Why not alloc this earlier and fill this allocation in the decompress functions? You can pass that at offset + 8.


comment on this commit
这里只是评论吗  可以在这个版本上在commit吗


@hbun DWMR. Good work here. You have gotten that coffee? French Press is it? Press on! See if you can get the foundation work done this weekend.


Shouldn't it be "A user" ?


继续评论


merged into https://github.com/cproc/foc/commit/23f465c2c34de7ef543d14b32e2ea671d9df0849


**no-undef**: "before" is not defined.


**no-undef**: "TestUtils" is not defined.


**no-undef**: "it" is not defined.


**no-undef**: "expect" is not defined.


**no-undef**: "sinon" is not defined.


**no-undef**: "describe" is not defined.


**react/display-name**: TestComponent component definition is missing display name


看来这里只是在改版本 评论


I have an idea why this change might be needed but commit message doesn't explain anything.


I don't know what a cross range is, so probably no one else will.  I'd just drop this line and include 18MP inline with photo count below.


For a11y purposes, it would be useful to have `sr-only` spans inside of these that explain the column purpose


In addition to the other issues, this patch needs additional work:
1. split the flash logic and the decompression logic into separate files
2. remove all exits and output (SCLogError/SCLogWarning) from the packet paths. Instead, events should be set.


Do we still need this script?


773 Images at 18MP


Hm, this seems a strange way to split a string. Maybe n = sscanf(*veth, "%s:%s", &iface_name, &iface_name_peer); ?


you shouldn't have to call that


Was there any problem with `Platform.current().pathSeparator.toString()`?


I guess it would make sense to only run this if it is at the start of the buffer? This function can also be called on partial data later in the stream/body.


no output


Am I reading this right that you are passing a vector of strings, but only using the first string in the vector (so if someone configures several veth pairs, only the first one will be created)?


Please keep this list sorted alphabetically.


Yes, it did not compile with the stable release of Rust at the time.


Merge


This and following lines make the code in this "else block" unreachable - none of the following line will ever trigger. It might be better if the code was removed altogether than blocked in this way.

See https://github.com/Automattic/babble/blob/develop/class-taxonomy.php#L417-L445


I think this can be done more cleanly than using a goto


I've once noticed them inside the station name HISTORY HD (Sky Germany). The name was crippled to HIST[strange char]ORY HD or something like that.

What's the magical problem with AutoTimer anyways? I've a lot of auto-timers running and zero problems.


Where is the opus URL? I just see https:


fixed


resolved #23


>... from the capture and builds a 3d mesh and texture using a process called Structure From Motion.  For our captures...

Your the expert, just tell them how it is :)
> This is a ~~somewhat~~ resource intensive process that ~~usually~~ requires ~~relatively~~ significant  time and processing power.


Same here.


- Đoạn code hiển thị là đoạn code nào hả anh ?

- Em đang nghĩ là lỗi do tất cả các tile mà bị loại ra khỏi lru không được lưu hết vào db.

Em định thêm một trường revision, lưu số lần cập nhật, khi lấy từ db ra thì mình kiểm tra lại revision có bằng revision hiện tại không thì sẽ biết xem cái tile bị loại khỏi lru có được lưu xuống DB không


Can you maybe do a line of docs to explain the reverse ?


dang


terza modifica


Harish wouldn't approve.


OK, i improved std.cfg and addeed a test case.


Hm, probably not.


Ok, thanks :+1:


According to https://www.quora.com/Is-it-an-user-or-a-user you are correct Thomas. Thanks. I though it was the vowel rule.


You could just make this `$('#editprofile-modal', $rootel).on('shown.bs.modal', showMainPanel());


and here.


Here we overwrite the callers buffer pointer. That seems like a very high risk of memory leaks.


LGTM! Maybe mention the compiler is also fully binary compatible, to encourage fully cross-versioned projects to publish since it should be 0 hassle.


Testes bacanas. Revisou os nomes dos dois primeiros testes, digo, faria sentido declarar um método como void e nomear ele insinuando que retorna algo?


Maybe ```Our post processing data-sets were as follows:```  - not sure what is best.


buffer pointer is overwritten on success, I think we just lost the original memory


Q: Why are the webkitImageSmoothingEnabled lines disabled?

I had blurry canvas problems in safari, and editing the compiled js file to add imageSmoothingEnabled lines beside the webkitImageSmoothingEnabled ones fixed the problem.


see comments above


I think it is OK to round these, and add commas.  10,000,000 and 20,000,000, etc


I think code style is broken here


`File.pathSeparator` is already used in this file and it's usage in this place can eliminate one import.


Consider keeping the same units of MB, 1,500MB and 791MB


I don't see why this is static.  That means it's not thread-safe.

It's also not clear to me what the purpose of this patch is.


Comment on 5e600fd


Raw type?


Finally. Thank you very much for this fix.


There is different IRQ for line 3(pin3), you are using EXTI15_10_IRQn


For more safety, I would always check if isset ['deep'], and isset['classes'] and is array['classes']. You don't how badly this "tc_anchor_smoothscroll_excl" filter can have been filtered before... :)


really nice results


>In the case of our data, even ~~simple~~simply viewing ~~of~~ the generated meshes ~~proves to be~~ is a difficult task.


D'oh, I suspect he was "Mr Copy-and-Paste"


赞


>A popular open source tool for viewing large meshes, MeshLab, takes several minutes to load our Nashville mesh on typical desktop hardware, and fails entirely at loading the texture data.  Attempting to navigate the mesh is virtually impossible.


Looks good to me. This is the only line which is a bit "dirty". We should find a more sweet syntax with something like unreformed = True or use_reform = False. What do you think ?
Or rename reference to base for simulation and keep reference for a pure reform/reference context.
We may also make a distinction between extensions and reforms.
What do you think @cbenz @eraviart


I'm afraid of logs that can be generated in mass by bad HTTP requests.
No real opinion. +0.


não entendi muito bem na verdade aueheu


Oh sorry, I thought and changed this line by considering only this `js` file.

Please refer my new commit.


TeamCity DNN JavaScript Libraries :: CI [Build 81](http://teamcity.engagesoftware.com/viewLog.html?buildId=353&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 81](http://teamcity.engagesoftware.com/viewLog.html?buildId=353&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:8


TeamCity DNN JavaScript Libraries :: CI [Build 82](http://teamcity.engagesoftware.com/viewLog.html?buildId=354&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


Good catch. I remove this one at the same time: https://github.com/SonarSource/sonarqube/blame/feature/ce-monitoring/server/sonar-server/src/main/java/org/sonar/server/util/AbstractStoppableExecutorService.java#L55-55 :-)


Well, pragmas in macros are only possible with `_Pragma()`, which is available in [C++11](http://en.cppreference.com/w/cpp/preprocessor/impl)/[C99](https://gcc.gnu.org/onlinedocs/cpp/Pragmas.html) it seems (so :+1: for #73). It would look like:

```cpp
# define ROBOPTIM_ALLOW_DEPRECATED_ON	 \
  /* Disable deprecated warning */       \
  _Pragma ("GCC diagnostic push")        \
  _Pragma ("GCC diagnostic ignored \"-Wdeprecated-declarations\"")

# define ROBOPTIM_ALLOW_DEPRECATED_OFF \
  /* Re-enable deprecated warning */   \
  _Pragma ("GCC diagnostic pop")
```

Then:

```cpp
ROBOPTIM_ALLOW_DEPRECATED_ON;
// Do deprecated stuff
// ...
ROBOPTIM_ALLOW_DEPRECATED_OFF;
```

gcc/clang seem to be accepting that without any complaint on Arch. I don't know if the same thing can be said for older versions (e.g. the ones on Ubuntu 12.04).


TeamCity DNN JavaScript Libraries :: CI [Build 82](http://teamcity.engagesoftware.com/viewLog.html?buildId=354&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:7


TeamCity DNN JavaScript Libraries :: CI [Build 83](http://teamcity.engagesoftware.com/viewLog.html?buildId=355&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


Yes this is a more elegant way.


TeamCity DNN JavaScript Libraries :: CI [Build 83](http://teamcity.engagesoftware.com/viewLog.html?buildId=355&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:8


TeamCity DNN JavaScript Libraries :: CI [Build 84](http://teamcity.engagesoftware.com/viewLog.html?buildId=356&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 84](http://teamcity.engagesoftware.com/viewLog.html?buildId=356&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:8


Kallen silly, you have access to my git :]


TeamCity DNN JavaScript Libraries :: CI [Build 85](http://teamcity.engagesoftware.com/viewLog.html?buildId=357&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


Demo’ing git to someone learning it.

> On Sep 18, 2015, at 10:35 AM, Chip Eyler <notifications@github.com> wrote:
>
> Harish wouldn't approve.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/croz1007/PG_Crew_Scraper/commit/6624087f6a9cf15a8305574f898f8407802a579c#commitcomment-13312412>.
>


TeamCity DNN JavaScript Libraries :: CI [Build 85](http://teamcity.engagesoftware.com/viewLog.html?buildId=357&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:7


I see. You may want to use the approach in [ajv-i18n](https://github.com/epoberezkin/ajv-i18n) and to extend it with your own messages in any language (in a fork). Or to simply use `{ i18n: true, messages: false }` options in ajv instance - it will remove standard messages and add `params` to errors that can be included in your own error messages.


Just checked your fork, it's my bad, please remove `finally` block from the `PersonGetResolver`, it's not required since `ThreadLocal` stores `WeakReference` :)


yep, it was long time ago CRAB3/PANDA stuff..


 @Override
  public boolean equals(Object obj) {

É um método da classe DataTerceiraEra que serve pra comparar dois objetos, assim possibilitando o assertEquals(object a, object c);


 Нет, правлю в IDEA, потом Commit and Push. Иногда почему-то спрашивает про Merge, соглашаюсь.
Почему спрашивает - хз, что-то в гите мне пока не доступно.

>Пятница, 18 сентября 2015, 6:54 -07:00 от Slava Semushin <notifications@github.com>:
>
>Откуда берутся эти коммиты с мерджами? По идее их быть не должно? Поди ты правишь файлы через редактор гитхаба, а потом не делаешь git pull перед тем как сделать новый коммит в своей локальной копии?
>—
>Reply to this email directly or  view it on GitHub .


this has been bugging me for months...

you forgot the closing parenthesis after the customers email address. line should be:
`$user_string = esc_html( $user->display_name ) . ' (#' . absint( $user->ID ) . ' – ' . esc_html( $user->user_email ) . ')' ;`


glaub ich habe hier dir logik geändert oder?

bei mir gibts nur eine NICHT leere response, wenn year UND month definiert sind....


Manda um PR :+1:


fast-forwarding master to borshop-integration-411-feature/bch/upgrade-tox-3.4.3 = 1bbd0813


1: M111 unrecognized component name: legacy


1: D400 First line should end with a period (not 'k')
3: L102 copyright year is outdated, expected 2015 but got 2014
22:1: I100 Imports statements are in the wrong order. import os should be before import sys
24:1: I100 Imports statements are in the wrong order. import cgi should be before import re
29:1: I201 Missing newline before sections or imports.
30:1: I100 Imports statements are in the wrong order. from six should be before from six.moves.urllib.parse
31:1: I100 Imports statements are in the wrong order. from wsgiref.util should be before from six
31:1: I201 Missing newline before sections or imports.
34:1: I101 Imported names are in the wrong order. Should be DONE, HTTP_INTERNAL_SERVER_ERROR, HTTP_NOT_FOUND, HTTP_STATUS_MAP, OK, SERVER_RETURN
34:1: F401 'HTTP_INTERNAL_SERVER_ERROR' imported but unused
37:1: I101 Imported names are in the wrong order. Should be CFG_DEVEL_SITE, CFG_SITE_LANG, CFG_SITE_SECURE_URL, CFG_SITE_URL, CFG_WEBDIR, CFG_WEBSTYLE_HTTP_STATUS_ALERT_LIST, CFG_WEBSTYLE_REVERSE_PROXY_IPS
37:1: I100 Imports statements are in the wrong order. from invenio.config should be before from invenio.utils.apache
43:1: I101 Imported names are in the wrong order. Should be after_this_request, request, session
43:1: I100 Imports statements are in the wrong order. from flask should be before from invenio.utils.datastructures
57:5: E266 too many leading '#' for block comment
64: D103 Missing docstring in public function
70: D203 1 blank line required before class docstring (found 0)
70: D204 1 blank line required after class docstring (found 0)
70: D205 1 blank line required between summary line and description (found 0)
75: D102 Missing docstring in public method
80:1: I101 Imported names are in the wrong order. Should be BaseResponse, CommonResponseDescriptorsMixin, ResponseStreamMixin
80:1: E402 module level import not at top of file
84: D203 1 blank line required before class docstring (found 0)
84: D400 First line should end with a period (not '`')
84: D205 1 blank line required between summary line and description (found 0)
92: D203 1 blank line required before class docstring (found 0)
92: D204 1 blank line required after class docstring (found 0)
92: D205 1 blank line required between summary line and description (found 0)
99: D102 Missing docstring in public method
114:9: E266 too many leading '#' for block comment
125:20: E261 at least two spaces before inline comment
125:21: E262 inline comment should start with '# '
134: D102 Missing docstring in public method
137: D210 No whitespaces allowed surrounding docstring text
137: D401 First line should be in imperative mood ('Return', not 'Returns')
148: D102 Missing docstring in public method
151: D102 Missing docstring in public method
154: D102 Missing docstring in public method
157: D102 Missing docstring in public method
166: D102 Missing docstring in public method
184:21: E266 too many leading '#' for block comment
186:46: E261 at least two spaces before inline comment
186:47: E262 inline comment should start with '# '
187:25: E116 unexpected indentation (comment)
187:25: E266 too many leading '#' for block comment
192: D102 Missing docstring in public method
199: D102 Missing docstring in public method
202: D102 Missing docstring in public method
210: D102 Missing docstring in public method
213: D102 Missing docstring in public method
216: D102 Missing docstring in public method
222: D102 Missing docstring in public method
225: D102 Missing docstring in public method
228: D102 Missing docstring in public method
231: D102 Missing docstring in public method
234: D102 Missing docstring in public method
236:16: E126 continuation line over-indented for hanging indent
250:98: E502 the backslash is redundant between brackets
251:98: E502 the backslash is redundant between brackets
252:100: E502 the backslash is redundant between brackets
258: D102 Missing docstring in public method
263: D102 Missing docstring in public method
266: D102 Missing docstring in public method
269: D102 Missing docstring in public method
272: D102 Missing docstring in public method
277: D102 Missing docstring in public method
309:17: E266 too many leading '#' for block comment
315: D102 Missing docstring in public method
321: D102 Missing docstring in public method
324: D102 Missing docstring in public method
327: D102 Missing docstring in public method
330: D102 Missing docstring in public method
336: D102 Missing docstring in public method
342: D102 Missing docstring in public method
345: D102 Missing docstring in public method
348: D102 Missing docstring in public method
352: D102 Missing docstring in public method
357: D102 Missing docstring in public method
360: D102 Missing docstring in public method
364:13: E266 too many leading '#' for block comment
365:13: E266 too many leading '#' for block comment
366:13: E266 too many leading '#' for block comment
367:13: E266 too many leading '#' for block comment
370: D102 Missing docstring in public method
373: D102 Missing docstring in public method
376: D102 Missing docstring in public method
381: D102 Missing docstring in public method
384: D102 Missing docstring in public method
387: D102 Missing docstring in public method
390: D102 Missing docstring in public method
397:13: B901 blind except: statement
401: D400 First line should end with a period (not 't')
401: D205 1 blank line required between summary line and description (found 0)
413: D102 Missing docstring in public method
440:1: E302 expected 2 blank lines, found 1
440: D400 First line should end with a period (not 'e')
440: D205 1 blank line required between summary line and description (found 0)
451:13: E266 too many leading '#' for block comment
453:43: E261 at least two spaces before inline comment
453:44: E262 inline comment should start with '# '
458:1: E302 expected 2 blank lines, found 1
458: D200 One-line docstring should fit on one line with quotes (found 3)
462:5: E266 too many leading '#' for block comment
473:5: E266 too many leading '#' for block comment
489:47: E128 continuation line under-indented for visual indent
500:9: E266 too many leading '#' for block comment
514:9: E266 too many leading '#' for block comment
515:9: E266 too many leading '#' for block comment
520: D401 First line should be in imperative mood ('Return', not 'Returns')
520: D200 One-line docstring should fit on one line with quotes (found 3)
533:1: E302 expected 2 blank lines, found 1
533: D401 First line should be in imperative mood ('Return', not 'Returns')
533: D205 1 blank line required between summary line and description (found 0)
546:1: E302 expected 2 blank lines, found 1
546: D401 First line should be in imperative mood ('Check', not 'Checks')
546: D205 1 blank line required between summary line and description (found 0)
571:1: E302 expected 2 blank lines, found 1
571: D200 One-line docstring should fit on one line with quotes (found 3)
583:9: E266 too many leading '#' for block comment
586:13: E266 too many leading '#' for block comment
587:32: W602 deprecated form of raising exception
588:9: E266 too many leading '#' for block comment
589:9: E266 too many leading '#' for block comment
590:9: E266 too many leading '#' for block comment
593:13: E266 too many leading '#' for block comment
594:13: E266 too many leading '#' for block comment
595:13: E266 too many leading '#' for block comment
596:13: E266 too many leading '#' for block comment
597:13: E266 too many leading '#' for block comment
601:17: E266 too many leading '#' for block comment
602:17: E266 too many leading '#' for block comment
603:17: E266 too many leading '#' for block comment
617:26: E127 continuation line over-indented for visual indent
649:28: W602 deprecated form of raising exception


1: D400 First line should end with a period (not 's')
29:2: E114 indentation is not a multiple of four (comment)
29:2: E116 unexpected indentation (comment)
30:2: E114 indentation is not a multiple of four (comment)
30:2: E116 unexpected indentation (comment)
31:2: E114 indentation is not a multiple of four (comment)
31:2: E116 unexpected indentation (comment)
32:2: E114 indentation is not a multiple of four (comment)
32:2: E116 unexpected indentation (comment)
33:2: E114 indentation is not a multiple of four (comment)
33:2: E116 unexpected indentation (comment)
34:2: E114 indentation is not a multiple of four (comment)
34:2: E116 unexpected indentation (comment)
35:2: E114 indentation is not a multiple of four (comment)
35:2: E116 unexpected indentation (comment)
36:2: E114 indentation is not a multiple of four (comment)
36:2: E116 unexpected indentation (comment)
37:2: E114 indentation is not a multiple of four (comment)
37:2: E116 unexpected indentation (comment)
38:2: E114 indentation is not a multiple of four (comment)
38:2: E116 unexpected indentation (comment)
39:2: E114 indentation is not a multiple of four (comment)
39:2: E116 unexpected indentation (comment)
40:2: E114 indentation is not a multiple of four (comment)
40:2: E116 unexpected indentation (comment)
41:2: E114 indentation is not a multiple of four (comment)
41:2: E116 unexpected indentation (comment)
42:2: E114 indentation is not a multiple of four (comment)
42:2: E116 unexpected indentation (comment)
43:2: E114 indentation is not a multiple of four (comment)
43:2: E116 unexpected indentation (comment)
44:2: E114 indentation is not a multiple of four (comment)
44:2: E116 unexpected indentation (comment)
45:2: E114 indentation is not a multiple of four (comment)
45:2: E116 unexpected indentation (comment)
48:1: I100 Imports statements are in the wrong order. import time should be before from wsgiref.headers
49:1: I100 Imports statements are in the wrong order. import re should be before import time
50:1: I100 Imports statements are in the wrong order. import cgi should be before import re
51:1: I100 Imports statements are in the wrong order. import cStringIO should be before import cgi
53:1: I101 Imported names are in the wrong order. Should be BuiltinFunctionType, ClassType, ListType, MethodType, TypeType
54:1: I201 Missing newline before sections or imports.
55:1: I101 Imported names are in the wrong order. Should be HTTP_BAD_REQUEST, HTTP_LENGTH_REQUIRED, SERVER_RETURN
60:1: E302 expected 2 blank lines, found 1
60: D101 Missing docstring in public class
63:5: E301 expected 1 blank line, found 0
63: D102 Missing docstring in public method
72:1: E731 do not assign a lambda expression, use a def
77: D101 Missing docstring in public class
79: D102 Missing docstring in public method
87:23: E202 whitespace before ')'
100:28: E721 do not compare types, use 'isinstance()'
106:37: W602 deprecated form of raising exception
124:1: E302 expected 2 blank lines, found 1
124: D203 1 blank line required before class docstring (found 0)
124: D400 First line should end with a period (not 't')
124: D205 1 blank line required between summary line and description (found 0)
137: D202 No blank lines allowed after function docstring (found 1)
137: D400 First line should end with a period (not 'n')
137: D205 1 blank line required between summary line and description (found 0)
149: D401 First line should be in imperative mood ('Thi', not 'This')
149: D201 No blank lines allowed before function docstring (found 1)
149: D400 First line should end with a period (not 'e')
149: D205 1 blank line required between summary line and description (found 0)
165:5: E303 too many blank lines (2)
165: D401 First line should be in imperative mood ('Provide', not 'Provides')
165: D201 No blank lines allowed before function docstring (found 1)
165: D202 No blank lines allowed after function docstring (found 1)
165: D400 First line should end with a period (not 'r')
165: D205 1 blank line required between summary line and description (found 0)
192: D102 Missing docstring in public method
194:33: E127 continuation line over-indented for visual indent
214:1: E302 expected 2 blank lines, found 1
232:1: E302 expected 2 blank lines, found 0
232: D401 First line should be in imperative mood ('Set', not 'Sets')
232: D400 First line should end with a period (not 'e')
232: D205 1 blank line required between summary line and description (found 0)
247: D400 First line should end with a period (not 'n')
247: D205 1 blank line required between summary line and description (found 0)
263: D103 Missing docstring in public function
289:1: E302 expected 2 blank lines, found 1
289: D101 Missing docstring in public class
290: D102 Missing docstring in public method
310: D102 Missing docstring in public method
311:48: E251 unexpected spaces around keyword / parameter equals
311:50: E251 unexpected spaces around keyword / parameter equals
325:35: W604 backticks are deprecated, use 'repr()'
327: D102 Missing docstring in public method
329:33: W602 deprecated form of raising exception
338: D102 Missing docstring in public method
341:1: E302 expected 2 blank lines, found 1
341: D210 No whitespaces allowed surrounding docstring text
341: D203 1 blank line required before class docstring (found 0)
341: D204 1 blank line required after class docstring (found 0)
341: D400 First line should end with a period (not 'h')
341: D205 1 blank line required between summary line and description (found 0)
354: D300 Use """triple double quotes""" (found '''-quotes)
360: D102 Missing docstring in public method
363: D102 Missing docstring in public method
365:33: W602 deprecated form of raising exception
371:35: W604 backticks are deprecated, use 'repr()'
373:1: E302 expected 2 blank lines, found 1
373: D101 Missing docstring in public class
375: D102 Missing docstring in public method
379: D102 Missing docstring in public method
389: D102 Missing docstring in public method
393: D102 Missing docstring in public method
397: D102 Missing docstring in public method
401: D102 Missing docstring in public method
405: D102 Missing docstring in public method
409: D102 Missing docstring in public method
413: D102 Missing docstring in public method
417: D102 Missing docstring in public method
421: D102 Missing docstring in public method
425: D102 Missing docstring in public method
429: D102 Missing docstring in public method
434: D101 Missing docstring in public class
436: D102 Missing docstring in public method
458:32: W602 deprecated form of raising exception
487:32: W602 deprecated form of raising exception
493:52: E261 at least two spaces before inline comment
494:13: E266 too many leading '#' for block comment
514:36: E231 missing whitespace after ','
519:52: E201 whitespace after '['
601: D400 First line should end with a period (not 'r')
607: D102 Missing docstring in public method
617: D102 Missing docstring in public method
641:54: E701 multiple statements on one line (colon)
652:54: E701 multiple statements on one line (colon)
663:54: E701 multiple statements on one line (colon)
667: D102 Missing docstring in public method
678: D102 Missing docstring in public method
684: D402 First line should not be the function's "signature"
688: D102 Missing docstring in public method
691: D102 Missing docstring in public method
694: D402 First line should not be the function's "signature"
704: D210 No whitespaces allowed surrounding docstring text
704: D400 First line should end with a period (not 'd')
711: D210 No whitespaces allowed surrounding docstring text
711: D400 First line should end with a period (not 's')
718: D402 First line should not be the function's "signature"
718: D209 Multi-line docstring closing quotes should be on a separate line
718: D400 First line should end with a period (not 'e')
718: D205 1 blank line required between summary line and description (found 0)
723: D102 Missing docstring in public method
729: D102 Missing docstring in public method
733: D202 No blank lines allowed after function docstring (found 1)
754:1: E302 expected 2 blank lines, found 1
754: D202 No blank lines allowed after function docstring (found 1)
754: D400 First line should end with a period (not 'e')
754: D205 1 blank line required between summary line and description (found 0)
775:35: E231 missing whitespace after ','
803:5: E129 visually indented line with same indent as next logical line


1: D200 One-line docstring should fit on one line with quotes (found 3)
28:1: I101 Imported names are in the wrong order. Should be CFG_DATABASE_HOST, CFG_DATABASE_NAME, CFG_DATABASE_PASS, CFG_DATABASE_PORT, CFG_DATABASE_SLAVE, CFG_DATABASE_USER, CFG_LOGDIR, CFG_PATH_GZIP, CFG_PATH_MYSQL
29:29: E126 continuation line over-indented for hanging indent
35:1: I101 Imported names are in the wrong order. Should be get_connection_for_dump_on_slave, get_table_names, run_sql
37:1: I101 Imported names are in the wrong order. Should be task_get_option, task_get_task_param, task_init, task_low_level_submission, task_set_option, task_update_progress, write_message
37:1: I100 Imports statements are in the wrong order. from invenio.legacy.bibsched.bibtask should be before from invenio.legacy.dbquery
38:45: E126 continuation line over-indented for hanging indent
44:1: I101 Imported names are in the wrong order. Should be escape_shell_arg, run_shell_command
45:1: I201 Missing newline before sections or imports.
52: D400 First line should end with a period (not 's')
52: D205 1 blank line required between summary line and description (found 0)
61:1: E302 expected 2 blank lines, found 1
61: D400 First line should end with a period (not 'E')
61: D205 1 blank line required between summary line and description (found 0)
74:1: E302 expected 2 blank lines, found 1
85:1: E302 expected 2 blank lines, found 1
94:1: E302 expected 2 blank lines, found 1
102:1: E302 expected 2 blank lines, found 1
110:1: E302 expected 2 blank lines, found 1
110: D205 1 blank line required between summary line and description (found 0)
120:5: E266 too many leading '#' for block comment
124:13: E266 too many leading '#' for block comment
126:9: E266 too many leading '#' for block comment
128:13: E266 too many leading '#' for block comment
134:78: E502 the backslash is redundant between brackets
135:68: E502 the backslash is redundant between brackets
136:72: E502 the backslash is redundant between brackets
194:29: E502 the backslash is redundant between brackets
195:25: E502 the backslash is redundant between brackets
196:41: E502 the backslash is redundant between brackets
197:46: E502 the backslash is redundant between brackets
198:41: E502 the backslash is redundant between brackets
199:42: E502 the backslash is redundant between brackets
204:31: E502 the backslash is redundant between brackets
213:89: E502 the backslash is redundant between brackets
214:47: E502 the backslash is redundant between brackets
215:44: E502 the backslash is redundant between brackets
222: D400 First line should end with a period (not 's')
222: D205 1 blank line required between summary line and description (found 0)
236:76: E502 the backslash is redundant between brackets
237:19: E128 continuation line under-indented for visual indent
258:32: W602 deprecated form of raising exception
350:34: E502 the backslash is redundant between brackets
351:25: E127 continuation line over-indented for visual indent
352:25: E127 continuation line over-indented for visual indent
353:25: E127 continuation line over-indented for visual indent
353:40: E502 the backslash is redundant between brackets
354:25: E127 continuation line over-indented for visual indent
354:44: E502 the backslash is redundant between brackets
355:25: E127 continuation line over-indented for visual indent


45:1: I100 Imports statements are in the wrong order. import StringIO should be before import time
45:1: E402 module level import not at top of file
47:1: F401 'subprocess' imported but unused
47:1: E402 module level import not at top of file
49:1: E402 module level import not at top of file
51:1: I100 Imports statements are in the wrong order. from functools should be before from flask
51:1: E402 module level import not at top of file
53:1: E402 module level import not at top of file
54:1: E402 module level import not at top of file
56:1: I100 Imports statements are in the wrong order. from itertools should be before from invenio.ext.sqlalchemy.utils
56:1: E402 module level import not at top of file
58:1: E402 module level import not at top of file
59:1: E402 module level import not at top of file
61:1: I100 Imports statements are in the wrong order. from urllib should be before from six.moves.urllib.parse
61:1: E402 module level import not at top of file
63:1: E402 module level import not at top of file
65:1: E402 module level import not at top of file
152:1: E402 module level import not at top of file
156:1: F401 'pyparsing' imported but unused
156:1: E402 module level import not at top of file
158:1: I100 Imports statements are in the wrong order. from flask_testing should be before import pyparsing
158:1: E402 module level import not at top of file


Does it take a while for this 1.0.3 package to show up in NuGet or has it not been pushed quite yet?


We have to be careful with e.g. `$V}` though (and I'll add a test for that), but we can use `if braced and ch == '}':`.


LOL..just trolling you.


@beaesguerra, @cheunggg. This is an example of how you can add your own edits to an existing pull request. You edit the pull request by pushing to the same branch. Assuming you clone'd the repository, this would be done by **_git push origin DesignDoc_** (Note that the syntax is git push \<remote destination\> \<branch\>, for clarification, we are pushing to DesignDoc **branch**, not the file). After you push something to it, people can review what you changed, and if people don't like it, you can have a discussion here.


@churkin Why the `dispatchTouchEvent` is not a static method of the `EventSimulator` class (like others: `_dispatchKeyEvent`, `_dispatchMouseEvent` ?


I get your point but I need your help. How would you do ?


**func-names**: Missing function expression name.


**no-loop-func**: Don't make functions within a loop


**semi**: Missing semicolon.


The original intent, I believe, was it make it mesh with the textbook, which introduces this sort of structure in Ch. 1 as a data matrix. @DavidDiez, @mine-cetinkaya-rundel : where did this term come from? Do you think it's reasonable in a future edition to shift to calling these things data frames or is that too R specific?


That deserves a coffee break!


Looks like a good addition. Will merge.


***THANK YOU*** :+1:


I do, otherwise the function is not reentrant.


TeamCity pull requests :: netty [Build 221](https://garage.netty.io/teamcity/viewLog.html?buildId=1466&buildTypeId=pulls_netty&guest=1) is now running


Well and this change as well ... I'd like to just have the ``if`` in the diff


This is a quote from MSDN. If it is not clear enough, please buy microsoft and make them fix msdn.


Better to include 'at ' in the at_part created by the if/else. That way you will messages ending with 'at '.


I see the method return a boolean, which could be use to write log at a higher level, so, not necessary
nevertheless, I don't see how this method could be directly linked to an HTTP request without any sort of control which mitigate that risk of log flood
let's not add the log anyway


if @model.mode.nil? would be the idiomatic ruby way to do this


Yeah I meant to ask you about this wrt galsim conventions when shifting the PSF center to the right subpixel location. Prob easiest to discuss this over slack in real time.


See #232 before continuing development here!


Two different coercions (line 16) could be done just once


You're right for the builder/immutability proposals.
Changing structure of packages was planned. I didn't want to do it right now.


It is factorized in a further commit. Will swap commits.


Effectivement, tout ne peut pas être parfait :

- soit la fonction n'est pas un itérateur ;
- soit on l'utilise comme `for directory in itertools.chain([songdir], directories):` ;
- soit on l'utilise comme `for directory in [songdir] + list(directories):` ;
- soit on utilise `list()` avant de passer l'option à `search_file` (ta proposition).

Pas de préférence. Je te laisse choisir…


Maybe just call the message `inveniomanage bower/collect/assets` for the sake of harmony with earlier `inveniomanage database create` messages.


I like this


Sim. Acha que eu poderia mudar alguma coisa?


Still todo tests for the describe views.
Test describing different number of sounds (including a number of description rounds), test for describing sounds that already exist (md5 check), test for describing sounds that do not exist on disk, test that tickets are created accordingly.


I have quite generic EXTI driver in my `local branch. I am working on porting it bach into CF, but it will take some time (IO handling is redesigned).
For testing, it would be probably enough to hardcode EXTI3_IRQ and fix it later.


Programatically this works, but using an include? on a list of numbers around a turnery is incredibly confusing to understand what is going on.


Beleza. Vou ajeitar aqui
Valeu :D


@ace2nutzer hi mate, I'm trying to build kernel for JB (using cocafe sources) but I'm stuck at samsung s advance logo, can you paste your build script? In the kernel i've just disabled spi_crc and set interactive as def governor..anything else


Can you direct me to a tutorial on how to make commits?


Too long horizontally, break it in to multiple lines


TeamCity Chorus :: chorus-precise64-master Continuous [Build 1.5.482.57b5203f9edbe6463438e82381868fd9fb698ca7](http://build.palaso.org/viewLog.html?buildId=63433&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 862, ignored: 54 Build time: 00:17:21


frameworks/native/data/etc/android.hardware.consumerir.xml:system/etc/permissions/android.hardware.consumerir.xml \

This line breaks the rom... It will build, but not boot.


I was able to reproduce this issue. Thanks a lot for your fix! Unfortunately, it didn't work in my case because the avatarUrl returned in the JSON response from Stash contained the context path of Stash, which led to the following URL (watch out for the duplicated context part):

{'avatarUrl': u'/stash/users/mrueegg/avatar.png?s=64}

base_url = https://MY_IP/stash

concatenation resulted in https://MY_IP/stash/stash/users/mrueegg/avatar.png?s=64

I'm nor sure why Stash yields a relative URL including the context path.

Anyway, I'll fix this issue with the next release. Thanks again.


I like this, expecially the name of the module being GameConstants.  Very straightforward


@adrn @eteq - the page is empty now :-/

http://data.astropy.org


I was thinking of a basic refactoring:

```java
      CeActivityDto activityDto = new CeActivityDto(queueDto.get());
      activityDto.setStatus(status);
      updateQueueStatus(status, activityDto);
      remove(dbSession, task, queueDto.get(), activityDto);
```

and

```java
 private void updateQueueStatus(CeActivityDto.Status status, CeActivityDto activityDto) {
    Long startedAt = activityDto.getStartedAt();
    if (startedAt == null) {
      return;
    }
    activityDto.setFinishedAt(system2.now());
    long executionTime = activityDto.getFinishedAt() - startedAt;
    activityDto.setExecutionTimeMs(executionTime);
    if (status == CeActivityDto.Status.SUCCESS) {
      queueStatus.addSuccess(executionTime);
    } else {
      queueStatus.addError(executionTime);
    }
  }
```

Good thing, this emphasis that if dto has no `startedAt`, the task will never be compted as finish.
Is it even possible (null `startedAt`)? If so, this deserve at least a log, maybe a stop SQ server error.


What exactly happens with various settings of ``use_latex``? (I assume you are using qtconsole with LaTeX unavailable.)


PSR-2:

> Lines SHOULD NOT be longer than 80 characters; lines longer than that SHOULD be split into multiple subsequent lines of no more than 80 characters each.


Yeah - thank you. Just found out too that i should use EXTI3_IRQn :) .
As i said - i´m not that familiar with stm32 programming but it makes sense.

EXTI15_10_IRQn means Pins 10-15


Can you add a DocBlock here?


first commit on the new repo


avoid this call

```
 	if (len == 0) {
 #ifdef _SC_GETPW_R_SIZE_MAX
 		long int sc_len;

 		sc_len = sysconf(_SC_GETPW_R_SIZE_MAX);
 		if (sc_len <= 0) sc_len = 1024;
 		len = (size_t)sc_len;
 #else
 		len = 1024;
 #endif
```


Yes, seems so. Previous approach would have broken if the dimension was made up of arrays?


are you kidding me?

(but I think the rest of the PR does deserve an IRL talk)


@posita I assumed the following scenario according to the code structure and committed my new changes and are follows:

````
* The `id` function will hold the passed `id` param value on `getId` variable and the status of the delete operation.
* Since `_all_ids` array is empty always, I assume that the array should be passed from somewhere.
* The `close` function finds the passed id available in the array and removes from the array, then update the status of the closed value.
* To trace the status of the deletion process, `_closed` should be returned.
* NAMESPACE.id will hold the passed id value and status of the deletion process.
````

Please let me know if you need anymore details.
Thanks


请问decode key 是如何获取的?是否在playLongSource里面,怎么获取.


just noted that an 'e' is missing


go it? Least one call.


Changed and all works. :-)


This commit reverted fix applied by aafac4b54ba34ca2c78cc55b1f7b36eca92ac5df (https://github.com/jxcore/jxcore-cordova/issues/61). Was this intentional or perhaps some branch merging side-effect?


no, I really think the way to write good and consistent logs deserves a meeting with the team.


I need to revisit this and figure it out


This can be removed. It's relic from old versions.


Nice work!


Just a few & signs were missed inside the querystrings.


I'm not sure you intended to commit that part :smile:


I moved this into it's own space, since it was all related.


What is the best practise if a new person should also have cars? I want to create+save person AND all cars.


Do you still get this:
> Using sympy.init_printing(use_latex='matplotlib'), however, it automatically reverts to unicode printing, if matplotlib fails.

I have not tried to verify that ipython would use plain text if ``None`` is returned but that did seem probable.


Because all spacing in this file follow a certain module, namely 5px, and it should be expressed in an idiomatic way, bringing more consistency to code and design. Also latter these constants could easily be changed in one place, if needed.


I just fixed the crash :)


> We should probably be having this conversation somewhere else. It is buried in here, and I don't know how to find new comments easily. I have to scroll through and look at the age of the individual comments.

Agreed. Comments during a pull request are one thing, but if we're having entire conversations or spawning additional Issues, then I think we should open dedicated issues to continue the conversation and provide the reference back here; otherwise we might have good discussion here and then it gets lost because no one turned it into an Issue.


Initial Commit of buiildingpermit.php


In the API files, none method has a DocBlock.


You don't even need to echo.


All the coding challenges are done in JavaScript. And the question source is Coderbyte website: http://coderbyte.com/.


здесь обнуление можно удалить


Curl will provide exit code?