A pull request? Go to the full code and press the pencil button. Then make your changes and scroll to the bottom. There should be an option for a pull request, and you should click that and I will add it.


Code Smell: Cyclomatic compelxity, since too many conditional statements are used.


The `force_frac` parameter is tested when you call `format_currency` with the `currency_digits` parameter set to `False`


Long method


Code Smell: class Fireball is a Feature Envy class ( too much use of methods of class Board).


@TommyByrne, did you bring this in or is this just part of a new Rails project? I've never seen it before.


I didn't create logic of setting the variables. I've only modified the proposal made in lxde/lxqt-common#24 to be in conformance with legacy `sh`.


Yes that was me, but I did revert it in a subsequent commit? 8db4a9450c3db8264f70aeb26756df40097d80e1


Unnecessary function. Not being called anywhere. levelUp is doing the job instead.


@darioizzo This will leave the ``m_order`` member initialised to an undefined value.


Code Smell: Inappropriate intimacy. Class Fireball depends on board.


while文のなかで新しいゲームオブジェクトをつくると、前のゲームが動いているまま新しいゲームが無限に生成され続けるのでオーバーフローする。
ゲームオーバーしたらループを抜けるように設計したほうがいい。


Error comments should be deleted.


Code Smell : class Player is a Feature envy class (too much use of methods of class Fireball).


The detection of the end of the iteration could be simplified:
```diff
diff --git a/src/nvim/ex_getln.c b/src/nvim/ex_getln.c
index 200f51c..d4d2223 100644
--- a/src/nvim/ex_getln.c
+++ b/src/nvim/ex_getln.c
@@ -5133,18 +5133,13 @@ const void *hist_iter(const void *const iter, const uint8_t history_type,
   if (zero) {
     memset(hiter, 0, sizeof(*hiter));
   }
-  hiter++;
-  if (hiter > hend) {
-    hiter = hstart;
-  }
-  if ((iter != NULL
-       && hiter == (hlast == hend
-                    ? hstart
-                    : hlast + 1))
-      || hiter->hisstr == NULL) {
+
+  if (hiter == hlast) {
     return NULL;
   }
-  return (const void *) hiter;
+
+  hiter++;
+  return (const void *)((hiter > hend) ? hstart : hiter);
 }

 /// Get array of history items
```


I put this in here for debugging; should take it out.


Class Board not implemented.


Too many unused stuff from state.py


@TommyByrne, where did this file come from? I think only `rails_helper` is being used. Can we get rid of this?


Too many parameters in the function checkCollision.


Use a white space around operator


この行は消す。


Oh, never mind, I see it is being required. Perhaps we could move this config in to `rails_helper.rb`, though.


не заголовок точно


Encapsulation not implemented.


line must not contain more than 79 characters


@legoboy0215 HELP


Inappropriate intimacy; class Person depends on class Board.


code smell: Contrived complexity in function jumpright


Polymorphism not implemented.


Too long function. Split the functionality into various small ones. If they don't exist create new ones.


Too many nested - if's must not be used


??? https://gist.github.com/automenta/f5ba348c8d5f6aba5c59

On Sun, Sep 27, 2015 at 4:29 AM, patham9 <notifications@github.com> wrote:

> Oops sorry, I meant <<$x --> bird> ==> <$x --> animal>>, <tiger -->
> animal> (variable_elimination2). Any ideas why this one fails?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opennars/opennars/commit/24a8f7fcb848b3e378981de16adbb2f248e52d9c#commitcomment-13455215>
> .
>


code smell: Contrived complexity in function jumpleft


Code Smell: Large Class


In the game, coins are not generated randomly.


Too many blank lines between the code must not be present


Letst test if i can do a pull request with a simple change


That should be named differently. I don't care about that name at all.


Board is not generated randomly


Blank line must be present after the function definition


There are no broken stairs. (We were asked to implement some broken stairs)


code smell: function move is a long method


Bad indentation on too many lines. Don't use vim again :P


Yes - one moment:

See: http://sprunge.us/PcDP

Thread 1 wants to do CloseFile, while Thread 2 is waiting for the response that refreshrate switching has already happened.

These twitch streams are HLS, therefore a lot CloseFile happens before the real content is found.


comment is outdated


When a player loses a life, he is not penalized as asked in the question.


code smell: function jumpright is a long method


There is no clear story on logrotate on atomic hosts. I do that in a multi-purpose container on the host. If there is a canonical logrotate container on atomic, we should surely use it.


Found a God object! StateLevelOne() knows too much and does too much.


The game does not start when the player reaches the floor of the princess.


Yes, ````<<$x --> bird> ==> <$x --> animal>>``` and ```<tiger --> animal>``` don't seem to be selected together in order to derive ```<tiger --> bird>```


code smell: function jumpleft is a long method


Хорошо использовать общий стиль объявления переменных. Т.е. var dateLifeCookie, вместо var DateLifeCookie


Exactly one space required around assignment. not according to PEP-8 standards


The donkey is not throwing fireballs, instead they are moving independently on each floor.


Regarding validation of installed packages. One can use `rpm -q` in plays, which is kind of ugly, but works. For now all atomic hosts include etcd-2.*.


Why change the name/author @305engineering of the original code/fork?

Now we probably get two forks which do roughly the same, as we should work towards one better tool, not 10 forks.. which each have minor functionality  differences... at least in my opinion?


The fireballs are not falling from the stairs or from the floor.


ack


code smell: Cyclomatic complexity in this else block


Line length : 103 characters.
PEP8 standards violated


The fireballs do not eliminate at the player's spawn position.


reack


examples_base in #etc is clearly not fhs compliant. /usr/local/share/openshift/examples is possible.

NB: that should be origin in all cases, right?


Oh. Haven't noticed that. Thanks for fixing.


ok ack then


Line length : 102 characters.
PEP8 standards violated


time to change `PusherTxn` to non-nullable?


Line length : 84 characters.
PEP8 standards violated


Different levels are not implemented.


code smell: cyclomatic complexity in this else block


Duplicated code, the code from lines 34-42 and 45-43 are similar, only one block with more conditions could be used to avoid duplicated code.


remove this check (it's already in `InternalAddRequest)`


Has someone reported upstream? If yes - we can just revert - or what was
the value of updating libusb again?

Which part of OE / usecase needs it?

2015-09-27 13:18 GMT+02:00 Peter V. <notifications@github.com>:

> This patch allows building in parallel again: http://pastebin.com/aH6crMv9
> Doesn't work on Haiku OS.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenELEC/OpenELEC.tv/commit/d98f05a7be2ddc92bea745cabb24ebceb558c897#commitcomment-13455689>
> .
>

--
                   Key-ID:     0x1A995A9B
                   keyserver: pgp.mit.edu
==============================================================
Fingerprint: 4606 DA19 EC2E 9A0B 0157  C81B DA07 CF63 1A99 5A9B


Imports should be on different lines. (PEP 8)


code smell: duplicated code(similar code with function jumpleft)


there should have been exactly one space after a coma.


Fixes #1


2 lines should be left blank between Class and first method.
PEP8 standards violated.


code smell: duplicated code (similar code with function moveleft)


@futhr Could you please merge this fix into 3-0-stable?


Does `taskdctl` anything else than start or stop the service? Because we already have `systemctl` for doing that.

But nevertheless, I'd make this completely optional with a `enableTaskctl` option if it is *really* necessary.


This class (Coins) depends on the structure of the board, which shows inappropriate intimacy.


To run the openshift commands I see three possibilities:
 * set `openshift.common.client_binary` and `admin_binary` to use `docker` (maybe more cleanly done somewhere else)
 * install some wrapper scripts in `/usr/local/bin` on the host that use `docker run`
 * modify every occurrence in the roles to not call `openshift.common.client_binary` but e.g. `{{ openshift.common.runner }} {{ openshift.common.client_binary }}`. That's kind of ugly though.


code smell: duplicated code(similar code with function moveup)


It does not look like the right spot. I don't know how to get the to deployed version here.


I can't `new SearchBar(this)` here. `searchEditText ` will be `null`. [In `SearchBar` class, mSearchTextEditor is created in `onFinishInflate`](https://github.com/android/platform_frameworks_support/blob/master/v17/leanback/src/android/support/v17/leanback/widget/SearchBar.java#L182).


avoid white space immediately inside parentheses


Keep in mind that this will lead to errors if `${cfg.dataDir}` contains spaces.


Excessive use of literals, more constants could be declared for better readability and easier modification later.


Regarding `openshift_master_ha`, it's the same story as logrotate: No canonical container to use for the packages.


give argument more meaningful names so that the code becomes readable. Also separate them by comma in definition of a method or a function


This doesn't actually break the API.  And I think providing this kind of backward compatibility makes it harder to maintain.

In my opinion, adding a `None` key would be accepting that the bug in the CLDR parsing script as turned into a feature.  Maybe @mitsuhiko could advise here.


Code Smell: Very similar code in the conditional statements.


I will add quotes.


Block comments must start with # and a single space.


It does not make sense to install a `.kube/config` on atomic hosts, because the docker wrapper does not use them anyway.


Keep module names more appropriate . I mean its better if they reflect the functionality of the module. Then it ll be more easy for someone to understand the relationship between modules


No spaces allowed during argument assignment of a function.


Method definitions inside a class are surrounded by a single blank line.
PEP8 standards violated.


I think it does nothing more.

Will implement the option as soon as this service is running. Thanks for mentioning, though!


That's a left-over from having a separate runner. Won't show up after a rebase.


this was to actually enable scaling on iphones and smaller devices. With 767 width constraint it wouldnt scale the background which often left iphones and other devices out in the dark and not displaying the background, you dig?


Code would be easier to read if it was split into different files.


Bad Whitespace.


When Player hits fireball sometimes the fireball is not detroyed and remains at position of collision


Subject and body changed as qq's suggested


Too many parameters.


Lmao... Not quite sure how I didn't catch that.  Thanks @ralphtheninja


No use of modules.


Hardcoded values, will make it very hard to port the game for different resolutions.


variable name used is not good. try using variables that make some sense and are atleast 3 characters long.


Wrong hanging indentation.


Each and every functionality is implemented


Constants should have been declared outside the class.


@etanol @mitsuhiko won't read this unless you ping him on IRC.

Then I'm fine with this changeset as it is.


ack


The floor_gap attribute of the method has not been used.


Code Smell : Large Class


clock.tick(20) limits the frame rate, faster computers won't be able to take advantage of higher processing power.


Excessive use of literals.


Missing module docstring


Wrong Indentation in all program further on. Double spaces than PEP8 found


should include person class


Added.


I think this fix is OK in last 2.05.


test


Too many attributes in the constructor.


Imports should usually be on separate lines.
PEP8 standards violated.


No methods for classes.. Better include some methods for each classes so that it actually becomes useful and meaningful


Karas 1995k


Class's methods donot have docstrings. It is a good practice to add them.


' if __name__ == "__main__": ' needed, so that game won't immediately start when imported as a module.


Use PEP standards to Name classes.https://www.python.org/dev/peps/pep-0008/#class-names

>Class Names:
 >>Class names should normally use the CapWords convention.


1-Bad White space.
2-Too many loops (Code Smells)


Chris - why is the HasJQuery() function an extension instead of being directly on the Session object?


remove


there should have been exactly one space after a coma. Same thing has occured beyond in following lines.


Use PEP standards to Name methods . https://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables
> Method Names and Instance Variables
>>Use the function naming rules: lowercase with words separated by underscores as necessary to improve readability.
>>Use one leading underscore only for non-public methods and instance variables.


this actually makes the graph overlap here, and i think it will in most cases for undamaged batteries, as the recent rentries should have ~90% battery capacity still. my rationale in throwing it in the lower left was that we care less about the actual battery usage from long (bottom left) ago than the current battery health (on the right, possibly on top).


Extra Bad Lines


Too many classes in the file board.py .
Avoid it and try separating classes into different modules.
Modularity not implemented.


Split these kind of senetences into multiple ones so that code becomes readable


The code has many hard coded values.


PEP8 violation: Use of wildcards in import statement.


Bad Whitespaces


why you change package name from pulutalauncher.event to pulutalauncher.evnt?


make this "Node.Batch" like you did elsewhere


Excessive use of literals, in the following


Good coding Practice : No global variables used.


variable name is too small. it could have been more descriptive and atleast 3-4 characters long.


手痒


Unnecessary ( and ) with if


Snapshot version -> snapshot version


Repetitive code, should be placed in functions and reused


or use this check to avoid doing any work entirely


Use 4 spaces per indentation level.
PEP8 standards violated.


Karas.


Le cache est éphèmere. Si ton instance meurt ou si le cache appengine n'est pas dispo, alors il va tout remettre dans le datastore.
Tu ferai mieux de rajouter un algo du style :

* si cache alors return cache
* sinon
  * si données en base, alors lecture pour créer le cache, return cache
  * sinon insérer les données à partir du spreadsheet, lecture pour créer le cache, return cache

en écrivant ça, je me demande pourquoi on a besoin du datastore ? comment savoir si les données du datastore sont cohérents par rapport à ton spreadsheet ? faudrait-il ajouter un numéro de version quelquepart pour savoir si ton spreasheet est plus à jour que ce qui est stocké dans le datastore ?


this commit message looks wrong - all i see here is the test being changed to avoid the bug described and some miscellaneous cleanup.


Nice touch.


Fireballs not Implemented.


Class names should normally use the CapWords convention.
PEP8 standards violated.


According to PEP-8, max length of a line is 79 characters; violated at some places.


Use Pep8 Standards to write comments https://www.python.org/dev/peps/pep-0008/#inline-comments

>Inline Comments
>>https://www.python.org/dev/peps/pep-0008/#inline-comments


Hi Anders,

Line 2831 gives me an error because of inexistant variable "rtags-autostart-diagnosetics". Is it a typing error?

Regards,


remove this, then you can use `reply, pErr := rng.AddCmd(..)`


Could you log the caught exception, like [here](https://github.com/SpongePowered/SpongeCommon/blob/master/src/main/java/org/spongepowered/common/data/processor/common/AbstractEntitySingleDataProcessor.java#L137)?


Same here.


The following lines of code could have be contained in a class.


No method descriptors of class.


unused imports:
os,re,math are unused


The following errors were detected in the code below :
1. Excessive use of literals: these should be coded as named constants, to improve readability and to avoid programming . A simple for loop could be used to generate the pattern


Coins placed
![screenshot from 2015-09-27 18 48 56](https://cloud.githubusercontent.com/assets/9111606/10122986/a33eb808-6548-11e5-91aa-cb16a44d6119.png)
 where user can't reach them


PEP8 violation: Use of no whitespaces around assignment operator


Anyone know why this is set to ignored? There's nothing private in the file, and staging/production will write their own versions with our private settings (key base, airbrake key, etc).


Function names should be lowercase, with words separated by underscores as necessary to improve readability.
PEP8 standards violated.


global variables must not be declared inside functions.


PEP8 standard errors:
1) Mixed indentation everywhere{including spaces and tabs}
2) Trailing whitespaces
3) Class names should be in CamelCase
4) method names should be underscores


PEP8 violation: Use of no white spaces around the comparison operator ==


Jumps in the last direction moved in, which was not in the question


m <- NULL
  set <- function(y) {
    x <<- y
    m <<- NULL
  }
  get <- function() x
  setmatrix <- function(solve) m <<- solve
  getmatrix <- function() m
  list(set = set, get = get,
       setmatrix = setmatrix,
       getmatrix = getmatrix)


The following errors were detected in this module :
1. Lazy class / Freeloader: a class that does too little.


Too many files in main directory, Resources like images and audio should be organised and placed in seperate folders. Many of the resources are never even used in the code.


Wrong continued indentation
or(event.key == K_a)


Ok, let's keep all source and compiled stuff in the git repository as WordPress ecosystem in general does not support any compliation/release stage, the repo as such must therefore contain all binaries and minified/concenated files ready to run..


Both global and local variables have been declared as global variables. Variables declared in functions should not be global. Many variables have been redeclared.


add the code below to support `redis.Multi` instance
```js
bluebird.promisifyAll(redis.Multi.prototype);
```


Right. I renamed the constant.


It's new for 4.2 http://www.justinweiss.com/articles/the-lesser-known-features-in-rails-4-dot-2/


Too many if-else. Try to reduce that by improving game logic.


Exactly one space required after comma.
PEP8 standards violated.


unecessary parenthesis after elif


PEP8 standard errors:
1) Bad whitespaces
2) Exactly one whitespace after every comma
3) No module docstring
4) Lines are too long


@palinek  yeah I know that. Just wonder why we need to add XDG_DATA_HOME to XDG_DATA_DIRS. From the spec I don't see any obvious reason to do so.


Improper white spaces at many places.


The following methods and blocks of code could have been included in a class.


BUG: Gives error, when player collides with stairs while jumping


Multiple attributes have been defined outside __init__.
__init__ not properly defined


PEP8: Have spaces between operators.


I know right!


Exactly one space required around assignment.
PEP8 standards violated.


invalid variable name 'x'


This code snippet could have been made more readable by introducing multi-line comments and better line-spacing.


pfft i compile all scrublord


invalid variable name 'y'


Hardcoded Layout could have been loaded from another file, keep the logic separated from the data.


All OOP principles implemented (Inheritance, Polymorphism, Encapsulation, Modularity)


PEP8: Leave a space before and after an operator.


We could think about adding some tooling in form of composer scripts. But then again we need to be sure that the client system has all the tools available like gulp or msgunfmt. We could use travis for creating releases in Wordpress.org


Yes, but do you enable the areas selection set in hammer scrublord?


Do not write if statement and corresponding code in a single line . Split them . it increases readability


Jump of player implemented.


code smell: Cyclomatic complexity in this elif block


@TommyByrne can you change the name of this file to `database.yml.example`, then add `database.yml` to the gitignore? That way for folks that need their own usernames and passwords, etc. specified for this configuration can do so without having a git battle royale with the changes back and fourth.


Only 1 level implemented


The following errors were found in this function :
1. Excessively long identifiers: in particular, the use of naming conventions to provide disambiguation that should be implicit in the software architecture.
2. The code could be made more readable by introducing multi-line comments and better spacing between the lines.


Code Smell:
too many instance attributes.


Better to split this function into multiple functions and refactor them .
Like drawing all onto the screen can be a function etc .


Exactly one space after comma and no space before comma.
PEP8 standards violated.


All necessary functions implemented. (except checkWall, since player can move through the walls)


Does not even show scores, mostly because it clears the screen


There are the following issues in this class :
1. Excessive use of literals: these should be coded as named constants, to improve readability and to avoid programming errors .


unused import sys


Use PEP standards to name functions https://www.python.org/dev/peps/pep-0008/#function-names

>Function Names

>>Function names should be lowercase, with words separated by underscores as necessary to improve readability.

>>mixedCase is allowed only in contexts where that's already the prevailing style (e.g. threading.py), to retain backwards compatibility.


Yea, good job.Thanks.


Hey @mortada, I guess you removed numpy because requiring pandas already implies requiring numpy. That makes sense.

What about the shee-bang and encoding though? what's the rationale to remove it?


Fireball does not fall down from the wall they fall from ladder only


PEP8 Error:
mixed indentation using tabs and spaces.


You definitely should not be drawing inside `post()`! Use `pre()` or `draw()`. In your case, register a `draw()` method, since you're... drawing.


1. Search 1st move with all threads( already in master).
2. Search upto movecount 4 using with 4 slaves(same as master)
3. After 8 moves bump up the max_slaves to (1 + depth/2) and don't split to at lower levels until parent reaches slave limit.

based on my some statistical analysis of current SF master:
86% of cutoff happens in first move
11% of cutoffs happen in next 3 moves
only 3% of cutoffs happen after that.


Code Smell:
Too few public methods(0/2).Use tuple or dictionary instead.


There is an issue with this return function :
Excessive return of data: a function or method that returns more than what each of its callers needs.


unused variable 'i'


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


Excessive return of data: This returns way too many data values .


@ccschmitz @TommyByrne having both `spec_helper.rb` and `rails_helper.rb` is the new normal. Though `spec_helper.rb` should remain largely unchanged, and all end-user rails-customization should go in the `rails_helper.rb`.

It's a little more than that even too... `spec_helper.rb` is for "non-rails" tests, and `rails_helper.rb` (which requires `spec_helper.rb`) is for tests that go through rails.

And example is that you probably don't need to load all of rails to test a service object. It's just a PORO, so pass it it's dependencies and evaluate the result. This will make those kinds of tests much faster.

https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files


Should have used a setter function instead of changing the coordinates manually each time.


Bad Indentation, used tabs instead of spaces, PEP8 not followed


dsdsd


PEP8 Error:
One whitespace after every comma


Missing module docstring


PEP8: Global variable names should dont use the CapWords convention


This commit breaks the build locally for me (boost 1.55 installed):

```
/usr/include/boost/python/detail/caller.hpp:223:13:   required from ‘PyObject* boost::python::detail::caller_arity<0u>::impl<F, Policies, Sig>::operator()(PyObject*, PyObject*) [with F = std::basic_string<char> (*)(); Policies = boost::python::return_value_policy<boost::python::reference_existing_object>; Sig = boost::mpl::vector1<std::basic_string<char> >; PyObject = _object]’
/usr/include/boost/python/object/py_function.hpp:38:33:   required from ‘PyObject* boost::python::objects::caller_py_function_impl<Caller>::operator()(PyObject*, PyObject*) [with Caller = boost::python::detail::caller<std::basic_string<char> (*)(), boost::python::return_value_policy<boost::python::reference_existing_object>, boost::mpl::vector1<std::basic_string<char> > >; PyObject = _object]’
src/mapnik_logger.cpp:86:1:   required from here
/usr/include/boost/python/detail/invoke.hpp:75:82: error: no match for call to ‘(const boost::python::detail::reference_existing_object_requires_a_pointer_or_reference_return_type<std::basic_string<char> >) (std::basic_string<char>)’
     return rc(f( BOOST_PP_ENUM_BINARY_PARAMS_Z(1, N, ac, () BOOST_PP_INTERCEPT) ));
                                                                                ^
In file included from /usr/include/boost/python/object/function_handle.hpp:8:0,
                 from /usr/include/boost/python/converter/arg_to_python.hpp:19,
                 from /usr/include/boost/python/call.hpp:15,
                 from /usr/include/boost/python/object_core.hpp:14,
                 from /usr/include/boost/python/args.hpp:25,
                 from /usr/include/boost/python.hpp:11,
                 from src/mapnik_logger.cpp:35:
/usr/include/boost/python/detail/caller.hpp: In instantiation of ‘static const PyTypeObject* boost::python::detail::converter_target_type<ResultConverter>::get_pytype() [with ResultConverter = boost::python::detail::reference_existing_object_requires_a_pointer_or_reference_return_type<std::basic_string<char> >; PyTypeObject = _typeobject]’:
/usr/include/boost/python/detail/caller.hpp:240:19:   required from ‘static boost::python::detail::py_func_sig_info boost::python::detail::caller_arity<0u>::impl<F, Policies, Sig>::signature() [with F = std::basic_string<char> (*)(); Policies = boost::python::return_value_policy<boost::python::reference_existing_object>; Sig = boost::mpl::vector1<std::basic_string<char> >]’
/usr/include/boost/python/object/py_function.hpp:48:35:   required from ‘boost::python::detail::py_func_sig_info boost::python::objects::caller_py_function_impl<Caller>::signature() const [with Caller = boost::python::detail::caller<std::basic_string<char> (*)(), boost::python::return_value_policy<boost::python::reference_existing_object>, boost::mpl::vector1<std::basic_string<char> > >]’
src/mapnik_logger.cpp:86:1:   required from here
/usr/include/boost/python/detail/caller.hpp:102:109: error: ‘struct boost::python::detail::reference_existing_object_requires_a_pointer_or_reference_return_type<std::basic_string<char> >’ has no member named ‘get_pytype’
         return create_result_converter((PyObject*)0, (ResultConverter *)0, (ResultConverter *)0).get_pytype();
                                                                                ^
error: command 'c++' failed with exit status 1
```

Any clue? :)


Atleast two spaces must be given before inline comment and a space must be given after #.


missing class docstring


wtf u talkin about scrublord

http://i.imgur.com/ycghsPd.jpg


missing module docstring


No docstrings!


:joy:


Hardcoded values make it hard to port to different screen resolutions. Also, configuration based code should be separated from game logic.


Doesn't build on hydra.


two lines must be left blank after class definiton.


many unused imports  from random like shuffle,random,randrange,choice,getstate etc


unused import 'sys'


Should have used private variables instead of protected for posx and posy.


for test


PEP8 error:
1) mixed indentation using tabs and spaces
2) exactly one space required after comma


I still greatly prefer sass vs scss.


Cyclomatic complexity: too many branches or loops; this may indicate a function needs to be broken up into smaller functions, or that it has potential for simplification.
The terms such as "PLAYER","COIN","LEFT_LADDER", etc could be put into a list and then iterated over a using a simple iterator . A lot of redundant code is present over here.


Right side in the selection set out liner, click the eye next to Areas... Scrublord


This is a submodule that Git created. Probably because I already have hangman saved to Github as a separate repository.


Have to press enter to move, really slows the game and its experience.


Code Smell:
Too few public methods to call(0/2).
Instead use tuple or dictionary to define variables


Very long function. Bad practice.


mixed indentation .. Do not use it . Follow PEP standards to indent


Invalid variable name pr,d1,ch,fi etc-violates PEP-8  standards


Module pygame has no init member


Local variables used in the function are too short and not so descriptive.


表示されている文字を入力時に削除する.htm

onloadイベントハンドラのfunction内部に入れてましょう。
この利用方法をクロージャーと言います。


Different components of code should be kept in separate files to make it easier to read.


Donkey, Person, Player and Board classes not implemented


module pygame has no init member


Class has no method descriptors.


I consider it not particularly idiomatic as I've been writing Perl both commercially and in open source projects for years and wasn't familiar with it, and it took me a while to figure out how the hell it worked.  On the other hand, it's a clever little trick that I've just learned thanks to you - so cheers :)  I'm still a little uncomfortable that it's a litle "too clever" - I tend to try to code in a way that someone not intricately familiar with Perl could still understand/maintain it - but a simple comment mentioning that it's the "enterprise operator" could be enough of a pointer for that.


Missing module docstring


Missing class docstring


this is java test for British Gas


Exactly one space required around assignment.
PEP8 standards violated.


Note to self


検索サイトを選択して検索.htm

クロージャーで閉じましょう


Code Smell:
too many methods in one class{GOD CLASS}


Missing method docstrings


You forgot to set nr of threads for your test. It is set at 1 thread.


getPosition(), checkWall(), checkCollision() and collectCoin() function not present.


The functions that are have to be present in the code compulsorily, such as :
1. getPosition()
2. checkWall()
3. checkCollision()
4. collectCoin()
are absent .


Very long function . Bad Practice according to PEP Standards


Very-Very Large class. Bad coding practice.


Line length : 85 characters.
PEP8 standards violated


brokenladders_hit = pygame.sprite.spritecollide(self,self.level.brokenladders1,False)


PEP8 violation:
exactly one space required after comma


Bad Indentation in many lines. use a better code editor


検索サイトを選択して検索.htm

出来ればオブジェクトインスタンスを作成する際に、初期化で入れたほうが良いよ。
でないと要素番号等の入力間違いが発生する可能性があります


Hardcoded values like 79 and 78 should be replaced with variables so that, in the future, if the values are changed, they only have to be changed in one place.


@charlesw It's just that paket is easier to use, and NuGet doesn't provide facilities for editing the csproj file outside of VS. Which means I'm stuck manually editing csproj files. Also nuget doesn't allow compilation against multiple frameworks in one go. Also, there's no 'add package' command for nuget to a project file from the command line. Finally, there's no way to ensure all packages are at the same version in nuget, expect scripting in PowerShell and I don't have that on OS X. Also, NuGet produces the wrong timestamps on built nugets, and they just don't fix that bug despite me reporting it a long time ago.

As for MsBuild; this PR still calls into MsBuild... I've worked extensively with MsBuild when I did Castle Transactions, and I found it lacking in expressiveness. It was quite often I would spend hours trying e.g. to formulate the right incantation to create and export an array or something, then filtering that array. With rake it's `%w{a b c}.keepIf { |x| x == "a" }` and DONE, with MsBuild it's something with `@(...)`. I also never really got my head around the scoping of variables in MsBuild and they all seemed global to me. I've also run into the case where I want something to happen after something else in MsBuild and whether it does, depends on the *order* that I use XML to declare things, meaning it's actually executable XML. The other issue with MsBuild, which I've had when working with this project is that it's both supposed to be declarative, (but it's not, see above) so that IDEs can use it. But when it's changed to accommodate project specific configuration, this is what it looks like:

<img width="317" alt="screen shot 2015-09-27 at 15 43 07" src="https://cloud.githubusercontent.com/assets/193115/10123084/80dd0338-652e-11e5-8a6a-9bd80cbd2471.png">

Also, I couldn't make intellisense work in the Playground project, because the Tesseract project had been so customised...

These things are friction to me, and I prefer to avoid friction. I can say that I have given MsBuild an honest shot, but there are good reasons not to use it.

If you'd come over to Albacore, I'll help you support it; but it's really transparent so there's not much support going into it.


yes I fixed that thanks! (always do that mistake!!)


Cyclomatic complexity: too many nested conditions. The following block of code could be simplified for better understanding and readability.


lines 115-117 bad indentation.


PEP8 standard violation:
lines are too long
length of a line should be less than 79 characters


Class has no Method descriptors.


Code Smell:
Too many if else statements together.


Line 314-316 : Maximum length of a line should be 79 characters.
PEP8 standards violated.


Code Smell:
The class is too long and does too much work{GOD CLASS}


Line length : 104
PEP8 standards violated.


PEP8 violation:
Missing method docstrings.


この様な定数を作成方法はアウト。
なるべく初期化する際に入れましょう


In this function there are Too many parameters: a long list of parameters is hard to read, and makes calling and testing the function complicated.


Modularity has not been implemented in the code.
All the classed have been stacked into one module.


PEP8 standard violation:
Mixed indentation used everywhere.{tabs + spaces}


Hardcoded data should be kept in separated file


変数を作成する際は必ずvarで宣言しましょう。
varを省略しても問題はありませんが、万人に受け入れられる可能性が低いです


Line 178, 179, 183, 184, 189, 193 : length = 85 characters
Maximum length of a line should be 79 characters.
PEP8 standards violated


PEP8 standard violation:
trailing whitespaces


unecessary parenthesis used after if-else blocks.


Good!


PEP8 standard violation:
Bad Indentation:
found 40 spaces,expected 20


Too long function. could have divided the functionality into smaller functions.


Bad name, not PEP8


Class names should normally use the CapWords convention.
PEP8 standards violated.


Too many if-else conditions in the function.


Hi. Thanks for your comment. I changed name and author of the fork to distinguish these two version as the original one is more CNC oriented, and this fork is mr beam laser cutter engraver oriented.

If you have a better solution, don't hesitate to give it :)


Bad Indentation:
Expected 8 spaces,found 12


PEP8 Error:
Expected one space before and after assignment statement


Duplicate code : Similar function present in other classes.


ツリー構造リストサンプル作成.htm

出来ればグローバルに変数を宣言するのはオススメしません。
ifreamで違うページに挿入する際に親フレームで弄られる可能性を考慮しましょう。


The game does not restart after reaching the queen, score is supposed to be incremented by 25 and game should be restarted.


Class name has to be in camel case conventions. PEP8 violation.


No classes implemented.


Unused Imports:
A lot of unused-wildcard-imports.It increases the processing time and slows down the program


in function getDeclaration, this function detects the timestamp and passes it to the query which as a result returns declaration from table "civicrm_value_gift_aid_declaration".

The timestamp that was getting passed to the query for declarations created by webform was a second less than the timestamp that is saved in the record. As a result the query was not returning anything, making the contribution invalid in the batch export page.


Oh wow ... I didn't mean "make drier", I actually meant "DRY".


FINAL SCORE{USING PYLINT}:
-56.47/10


blame alcohol


Missing module docstring


@nfedyashev Or you could simply add a ruby generator for mail-checker and use it there.
Since **we** update very often our code-base with new disposable email domain names, that way you won't have to copy/paste we what do each time... :)


Please revert, the system openssl should be used if possible.


Will be removed in the next commit


code smell: moveright is a long method


Old style class defined


Game doesn't work.


CODE SMELL:
Too few public method(0/2).
Use a tuple or a dictionary instead to define variables.


ok, i'll just fix it for myself later :joy:


No constructor for class


Instead of separate MoveLeft and MoveRight for player and a separate MoveDonkey. A simple MoveHorizontal in Person class could have been implemented and used by both player and donkey.


Too many blank lines left.
PEP8 standards violated.


Code Smell:
the class has grown too large{LARGE CLASS}


No classes used, all of this should go into constructor.


Bug detected, going fast across a fire ball does not decrease the life. When the collision with the fire ball is detected the player does not re-spawn at the bottom left corner corner.


Please could you check the correctness of two methods putOptimized() and takeOptimized(). My goal there was to escape the usage of notifyAll(), because it wakes up all the Customers and Producers at the same time. This leads to bad performance.

With these two methods i tried to reach the goals:
1. Separate waiting sets for Producers and Consumers, so i can avoid waking up Producers, wenn i need more Customers.
2. Use notify() instead of notifyAll(), so instead om multiple threads only one will wake up.


This class should have a file of it's own.


Exactly one space required around assignment.
PEP8 standards violated.


getPosition(), checkWall(), checkCollision() and collectCoin() function not present.


PEP8 standards:
invalid method names.Method names should not be CamelCase or surlyCase.
two words should be separated by underscore.


I figured it was just a brain fart ;)


Lots of Global variables used, bad practice.


I do not see any profit of using nose tests  and adding this dependency to library.


@laurens The `master` branch is very diverted in commits from the `3-0-stable` branch, with failing specs etc. You welcome to help out by cherry-pick from `master` to make the branches add up correctly and submit a PR with these updates to `3-0-stable` branch.


Exactly one space after comma and no space before comma.
PEP8 standards violated.


> @ericpromislow Agreed that we should put these programs outside vcap-common. OK if I reuse the name 'staccato-common', which was a go repository in gitolite and deleted Nov 2013?

`ApptailRegistrar` is only used in our dea_ng, so should reside there. That leaves `Stackato::LogHelper`, which is used many places for logging timeline events. Maybe that can go under `src/timeline_reporter` and change the class name from `Stackato::LogHelper` to `TimelineReporter`, so it's clearer what it's doing.


Instead of hard code values like 80, 30, etc keep those limits as variables in the class so it ll be readable and can be easily modified


Functionality Errors:
Jump not implemented.


组长：王乙闲 学号： 1501214324

组员：程权     学号：1501214333

组员：林雄辉  学号：1501210381


Functionality Errors:
Fireball not implemented


check the latest commit, i broke some things as a result of cleaning up all
mention of index and termlink type etc. but the code is simpler now and may
lead to fixing other condtiions

On Sun, Sep 27, 2015 at 8:51 AM, patham9 <notifications@github.com> wrote:

> Yes, `<<$x --> bird> ==> <$x --> animal>> and <tiger --> animal> don't
> seem to be selected together in order to derive <tiger --> bird>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opennars/opennars/commit/24a8f7fcb848b3e378981de16adbb2f248e52d9c#commitcomment-13456074>
> .
>


The score of the game should never of negative, but after user dies the score goes into negative.


Main game flow should be in a class of it's own, in a different file.


What if the script just checks if command msgfmt exist and if not, then error complaining that gettext must be installed for translations to work? Or maybe just forget this, it is low priority.


Functionality Errors:
Fireball not implemented.


Excessive system utilization : The game becomes slow when the player resets after a death .


Should be split into different files.


Doesn't take advantage of classes.


thats instead coveralls


Too many nested loops and conditions .
Bad Code Smell.


Functionality Errors:
Climbing through ladders is not implemented.


Oh, I missed the actual change.


@FGRibreau
first of all, thanks for your work with mailchecker!

Speaking of what would be easier to make it usable in ruby projects, I believe that improving existing gems/packages is better than adding generators to third-party(non-ruby) projects and reinventing Bundler package manager and its dependency management mechanism.

There is a separate pull request that semi-automate the process of pulling updates https://github.com/lisinge/valid_email2/pull/33


replace one dependency on another :-)


According to the problem statement, the game should exit when 'q' is pressed. This feature is absent in the game.


Duplicate code : Similar function present in other classes.


Functionality Errors:
Donkey is not there nor is the queen.


Lazy class


Hardcoded values make it hard to port to different screen resolutions. Also, configuration based code should be separated from game logic.


done


Hardcoded values should be replaced with variables so that if the values are changed, they only have to be changed in one place.


Jumping bug. Steps to re-create :
1. Go to corner of the screen with the player.
2. Jump.
3. Hold the arrow key in the direction of the wall .

Expected result : Player falls down.
Actual result : Player remains stuck in the air.


more-eng-ref-corrections (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Moved here #86 and here #87


The function definitions are not present in a class .


@marbre you are right. That line needs to be added again. I can't remember why I removed it.


LGTM.

Nit: I would align the two = signs, e.g.

int is_qsv_available = hb_qsv_video_encoder_is_enabled(HB_VCODEC_QSV_H264) ? HB_VCODEC_QSV_H264 : 0;
is_qsv_available    |= hb_qsv_video_encoder_is_enabled(HB_VCODEC_QSV_H265) ? HB_VCODEC_QSV_H265 : 0;


Should have made program components independent, so that you don't need to use global variables.


Invalid variables name x,y,s,etc...


Ah, this one looks better


Test


As you want, I did the same with MailChecker https://github.com/FGRibreau/mailchecker/commit/fa5a8dd6f99b80ee9fe9333b5f5361171e6398a9 ^^


Dont shout

You don't know git yet - you 'll get to love it ;)

I updated the post in the wiki with screens for your branches:

https://github.com/wrye-bash/wrye-bash/wiki/%5Bgit%5D-Syncing-a-Fork-with-the-main-repository

but I can't teach you git (and moreover how to use a gui) - do your homework.

I expect you to post me a screen with your cleaned up branches. I can help you do an interactive rebase of your tasks branch on dev


Importing modules is faster than executing and can be compiled.


This module could be made more modular by breaking it into smaller different modules.


Public and private variables have not been used in the definition of these classes.


I was thinking of implementing your change, but then I found this:

*Alternative solution for your change*
```
colorscheme kalisi
highlight Normal ctermbg=NONE
```
It's important to load the colorscheme before the ctermbg settings in .vimrc because they need to override the same ones set by the colorscheme. This also means you can't switch colorscheme while Vim is running and expect it to work.
Found here:
http://stackoverflow.com/questions/4325682/vim-colorschemes-not-changing-background-color
by cptloop

If this doesn't fix it, then here's another hint:
If your term doesn't change its bgcolor back after closing vim, then I think you have a terminal configuration problem. At least my zsh inside mintty (xterm-256color) reverts back after closing.


Ben, can we stick to using curly braces in all control statements in future? Otherwise it is something difficult to follow the logic. Will not comment on indent (which is tab), since we plan the make a big style fix anyway.


The following errors have been identified in the code snippet below :
1. **Cyclomatic complexity**: too many branches or loops; this may indicate a function needs to be broken up into smaller functions, or that it has potential for simplification.


I'm glad you found it useful. Credit goes to @lisinge


All the relevant text files, i.e. "X_test.txt", "y_test.txt", "X_train.txt", "y_train.txt", "subject_test.txt" and "subject_train.txt" should be saved in a single common folder.


Modularity , Inheritance , Polymorphism , Encapsulation not implemented.


Big sentence split it using backslash('\')


2. Could be made more readable by proper indentation and by better line-spacing.


There is a fair amount of complexity in the conditional statements below.


Absence of data abstraction : Class data members not divided into private and protected.


The following lines of code till 158 should have been included in class.


You should start considering syncing with the upstream repo.


Bad Whitespaces


@flavour
I setup a FTP server in my machine to test. Everything seems to work fine. I get the .cap file in my ftp folder.
However:

1. I get S3LOG DEBUG: S3Sync: cap_alert PUSH error: which is coming from https://github.com/flavour/eden/blob/master/modules/s3/s3sync.py#L458 and that does not update the last_push field. But I get the .cap file and everything seems okey?

2. I am not sure if the component filter, like in this use-case, the filter on component cap_info and cap_area_location (gis_location) to filter the record works or not because here https://github.com/biplovbhandari/eden/commit/5425527b65d185c0e3d8a8737933e6816f7ec7bc#diff-b907c08233116b4fdbdcbf7f9914e87bR142  ```if filters and tablename in filters:``` tablename would be cap_alert which is not in filter? Does this handle the component filter itself?


Nice new logo Raul, I love the style... just added the new style changes to my style. When this version is submitted I can start using that ;) And update every new submitted version, thanks again for keeping this up-to-date


Missing Doctring


You should start considering syncing again with the upstream repo.


Missing Docstrings


Excessive use of literals, variables could be used for better readability and easier modification of the code.


Removing `time.sleep` all together (reducing the annoying delays during the request drops (e.g. if WAF)


Redundant Code


Thanks David, read the last PR. ;)
https://github.com/phpBB-Spain/IDLaunch_Fresh/commit/3d23b14d6dec0ffa5948fc4b5a79d92fc12ad633


Too many nested conditions .
Conditional Complexity.
Bad code Smell.


Ok,
Use this
git remote add (name) (repo)
git fetch (name) (brunch)
git cherry-pick (commits)

EX:
git remote add khusika https://fortunave3gxx/android_device_samsung_qcom-common
git fetch khusika cm-12.1
git cherry-pick 918be87b6247bae477213945c2e91bdd4811e097


Redundant Code, used in many places, should have used a function instead


The following methods should have been included in a class.


"a few more tests break but i think these should be easily fixable."
Work locally and do not commit until the NAL-testcases which already worked work.
Thanks. I may revert this later in case that its still broken if it gets into my way.


that post was from 2007, and only applies to TWClassic, not TW5


Ben, since there is a diff, I do not think it is a good idea to mention line number in commit message. I would rewrite it as "Bigfix: tagsets/email: Check cc list for content before using in iteration."

Also, I guess there is no possibility of $email['headers']['cc'] being a scalar? If so, then line 63 in your new code can be rewritten as:
```if (!empty($email['headers']['cc'])) {
    ...```

And again, I suggest to be strict about curly braces use (in foreach in this case), the code is much easier to read and follow.


Another LMK-related thing that might be of interest. After decreasing minfree (leaving adj as-is), oom_adj numbers of killed processes are higher. It follows that the present minfree settings are too high, killing too-essential processes. See:

<pre>
<6>[15844.411498,2] lowmemorykiller: Killing 'le.android.keep' (19338), adj 764,
<6>[15857.823920,2] lowmemorykiller: Killing 'viders.calendar' (19747), adj 1000,
<6>[15893.980899,3] lowmemorykiller: Killing 'd.process.media' (20124), adj 1000,
<6>[15900.720612,3] lowmemorykiller: Killing 'm.spotify.music' (20348), adj 764,
<6>[15912.752416,1] lowmemorykiller: Killing 'd.process.acore' (13253), adj 1000,
<6>[15915.020804,0] lowmemorykiller: Killing 'oid.apps.photos' (13529), adj 823,
<6>[15925.822866,3] lowmemorykiller: Killing 'om.skype.raider' (20409), adj 764,
<6>[15926.376953,0] lowmemorykiller: Killing 'droid.apps.maps' (20391), adj 764,
<6>[15930.155082,0] lowmemorykiller: Killing 'le.android.keep' (20285), adj 1000,
<6>[15955.436362,1] lowmemorykiller: Killing 'd.process.media' (20617), adj 764,
</pre>

Previously it killed processes even with adj below 200. The minfree values I've arrived at:

> 4608,5760,6912,8064,9216,11520


Too long line


Thanks for submitting this! Will commit this and deploy soon :)


OOP principles, such as Encapsulation,Modularity, Inheritance are not implemented.


it looks like a good cleanup though. but I am not convinced yet since it broke essential things.


BUG: Do not remove the player when a person finishes. Thus, there are more than 1 player in further levels


The functions getPosition(), checkWall(), checkCollision() and collectCoin() not present.


组长：赵虎  学号：1501210806

组员：徐鑫  学号：1501210748

组员：任慈阳  学号：1501210975


Я в двух местах создаю `new TrieNode()`. Нужен либо пустой конструктор без аргументов, либо создавать через `new TrieNode(null)`


** Cyclomatic complexity ** : too many branches or loops; this may indicate a function needs to be broken up into smaller functions, or that it has potential for simplification. The following snippet has a lot of redundant code that can be reduced.


I think you might be hitting a limitation of type inference with overloaded method. When I was working on `compose` I try to capture the issue in a snippet: https://github.com/julien-truffaut/Monocle/blob/master/example/src/test/scala/monocle/ComposeIssueExample.scala

see also: http://stackoverflow.com/a/7847406/2356120

It would be awesome if we could somehow find a workaround!


Doesn't the Opal week start at 4am, not 3am?


@benzakour Attention aux noms des attributs, méthodes et instances, la première lettre doit être en minuscule: `Locked`, `Hidden`, `IsLocked`, `HD`, `Door.isLocked()` :stuck_out_tongue:


@flavour Guess I am returning error here: https://github.com/biplovbhandari/eden/commit/5425527b65d185c0e3d8a8737933e6816f7ec7bc#diff-b907c08233116b4fdbdcbf7f9914e87bR273
Should return None I guess?


Large class: This class has way too many functions in it and has grown too big.


Yes, for sure you are in trouble with dangling references.

Maybe I'm missing something obvious but I don't see how setting
```python
        self.graph_attr.handle = self.handle
        self.node_attr.handle = self.handle
        self.edge_attr.handle = self.handle
```
is a correct solution.


Thanks, I've already seen that edit and I deleted it out of my version as well.


I'm not entirely sure if this function is 100% correct, I should check this


Ah ah...my test lasted longer ! But not much :(
I'm doing local testing now with no Q threat at all. It provides a nice speed up.

Might run this with my implementation, or as a simplification against master.
Will wait, because much more important tests are running now.


MSB first, so 2048 at the left, 1 at the right, 12-bits of temperature reading ( 4095 is the max, being 1023.75 degrees )


Redundant code, bad spaces, too long line. Should have used a function instead


Readme is very small
Add Following :
1. Details about Modules and their inter module relationships
 2. Features you have implemented
3. Prerequisites required to run it (if any .. just like installing pygame module in this case)


Also not entirely sure if this is correct yet, setting the CS pin low, high, low... it does give me better results than doing it other ways, but the delay might be too long or too short for the chip to perform a conversion cycle?


take first twelve bits after skipping the first one (that's a dummy sign bit)


How did this sneak in?
The branch should be protected :/


Redundant Code, use function


Ah I see. Okay it's fine I guess, but I have no idea how to get it working
again. :D

2015-09-27 16:02 GMT+02:00 automenta <notifications@github.com>:

> check the latest commit, i broke some things as a result of cleaning up all
> mention of index and termlink type etc. but the code is simpler now and may
> lead to fixing other condtiions
>
> On Sun, Sep 27, 2015 at 8:51 AM, patham9 <notifications@github.com> wrote:
>
> > Yes, `<<$x --> bird> ==> <$x --> animal>> and <tiger --> animal> don't
> > seem to be selected together in order to derive <tiger --> bird>
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/opennars/opennars/commit/24a8f7fcb848b3e378981de16adbb2f248e52d9c#commitcomment-13456074
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opennars/opennars/commit/24a8f7fcb848b3e378981de16adbb2f248e52d9c#commitcomment-13456554>
> .
>


Oh,  lame.
If the CI checks have passed for a commit that exists in a PR,  **and** then you accidentally push, it will be successful because that commit is classified as accepted.


Redundant code, use a function


в py можно вот так:
arr[0], arr[1] = arr[1], arr[0]


No Fireballs


5.9.26 update


ok, thanks


more-eng-ref-corrections (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1896 of 1896 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Reference to #51


如果原本是用 nodejs 0.10.x 開發的人，整進這個 commit 會有錯誤，因為 dependecy 的關係會無法正確 build bundle.js，可先退回 commit 89d55d8db34650b2d023d67730ec11a503539348 運作正常。

Error Message:
Your current PostCSS version is 4.1.16, but autoprefixer uses 5.0.8. Perhaps this is the source of the error below.


• getPosition()
• checkWall()
• checkCollision()
• collectCoin()

not implemented


Forward and Reverse Motor, Control by using relay module .
This source code based on Example on Arduino IDE .

/*
  Forward Reverse Motor Control by Arduino Uno

 By using arduino and 2 channel relay module.
 Uno can trigger signal to the relay module by using digital pin 12(Forward),11(Reverse) and 10(Stop).
 Recomended to use momentary switch to control this motor.

 The circuit:
 * LED_FORWARD attached from pin 12 to ground
 * LED_REVERSE attached from pin 11 to ground
 * LED_STOP attached from pin 10 to ground
 * pushbutton_FORWARD attached to pin A0 from +5V
 * pushbutton_REVERSE attached to pin A1 from +5V
 * pushbutton_STOP_FORWARD attached to pin A2 from +5V
 * pushbutton_STOP_REVERSE attached to pin A3 from +5V
 * 470 resistor attached to pin A0 from ground
 * 470 resistor attached to pin A1 from ground
 * 470 resistor attached to pin A2 from ground
 * 470 resistor attached to pin A3 from ground

 * Note: on most Arduinos there is already an LED on the board
 attached to pin 13.

 created 2005
 by DojoDave <http://www.0j0.org>
 modified 30 Aug 2011
 by Tom Igoe
 modified 27 Sept 2015
 by akueajim <@akueajim>

 This example code is in the public domain.

 http://www.arduino.cc/en/Tutorial/Button
 */

// constants won't change. They're used here to
// set pin numbers:
const int buttonPinForward = A0;     // the number of the pushbutton pin
const int buttonPinReverse = A1;     // the number of the pushbutton pin
const int buttonPinStopForward = A2;     // the number of the pushbutton pin
const int buttonPinStopReverse = A3;     // the number of the pushbutton pin
const int ledPinForward =  13;      // the number of the LED pin
const int ledPinReverse =  12;      // the number of the LED pin
const int ledPinStop =  11;      // the number of the LED pin

// variables will change:
int buttonStateForward = 0;         // variable for reading the pushbutton status
int buttonStateReverse = 0;         // variable for reading the pushbutton status
int buttonStateStopForward = 0;         // variable for reading the pushbutton status
int buttonStateStopReverse = 0;         // variable for reading the pushbutton status

void setup() {
  // initialize the LED pin as an output:
  pinMode(ledPinForward, OUTPUT);
  pinMode(ledPinReverse, OUTPUT);
  pinMode(ledPinStop, OUTPUT);
  // initialize the pushbutton pin as an input:
  pinMode(buttonPinForward, INPUT);
  pinMode(buttonPinReverse, INPUT);
  pinMode(buttonPinStopForward, INPUT);
  pinMode(buttonPinStopReverse, INPUT);
}

void loop() {
  // read the state of the pushbutton value:
  buttonStateForward = digitalRead(buttonPinForward);
  buttonStateReverse = digitalRead(buttonPinReverse);
  buttonStateStopForward = digitalRead(buttonPinStopForward);
  buttonStateStopReverse = digitalRead(buttonPinStopReverse);
  int status_pinForward = digitalRead(ledPinForward);
  int status_pinReverse = digitalRead(ledPinReverse);

  // check if the pushbutton is pressed.
  // if it is, the buttonState is HIGH:
  if ((buttonStateForward == HIGH) && (status_pinReverse == LOW)) {
    // turn LED on:
    delay(1000);
    digitalWrite(ledPinForward, HIGH);
    digitalWrite(ledPinReverse, LOW);
    digitalWrite(ledPinStop, LOW);
  }

   else if ((buttonStateReverse == HIGH) && (status_pinForward == LOW)) {
    // turn LED on:
    delay(1000);
    digitalWrite(ledPinReverse, HIGH);
    digitalWrite(ledPinForward, LOW);
    digitalWrite(ledPinStop, LOW);
  }
  else if (buttonStateStopForward == HIGH) {
    // turn LED off:
    digitalWrite(ledPinForward, LOW);
    digitalWrite(ledPinStop, HIGH);
  }
    else if (buttonStateStopReverse == HIGH) {
    // turn LED off:
    digitalWrite(ledPinReverse, LOW);
    digitalWrite(ledPinStop, HIGH);
  }
}


Jump functionality is fluid !!


Thanks


Thank you random stranger


Actually, the mistake is that I am missing the link to the kernel changelog. The backslash is to escape the `(` so that it is not used as the target of the link.


what is a compuper


[Project (Regression Models).pdf](https://github.com/AnneGH/Project-Regression-Model-/files/3135/Project.Regression.Models.pdf)


Extremely long, un-readable code.


Yay!

BTW, how's that fast grade working for you?


Too many if,else conditions.Code smells bad.


|bad-whitespace
invalid-name
trailing-whitespace
missing-docstring
line-too-long
global-variable-undefined
global-variable-not-assigned
too-many-statements
too-many-branches
superfluous-parens
unused-variable
unused-argument
too-many-locals
super-init-not-called
old-style-class
duplicate-code
too-many-arguments
redefined-outer-name
multiple-statements

Many such instances


Lazy class, no functionality of the class queen


It took 10min :/


This is an very big class and could be made shorter.


No rush from my perspective.  I'm inclined to just include this with the next tagged release.


BUG: Donkey does not kills the players, sometimes


Hola @adurandt que bueno que te gustó. Hay una carpeta con los scripts para products y customers aquí => [scrips](https://github.com/juanitodread/e-commerce-rest-api/tree/master/scripts) solo es cuestión de que los importes con la herramienta *mongoimport*


Those objects were all initially created with the *old*, now closed and invalid value for `self.handle` (they store a reference to `AGraph`s `self.handle` in their own `handle` attribute). They need to be updated to have the *new*, correct, open, value for `self.handle` (if that doesn't happen, the process segfaults). That's what that code does. Those objects have no other instance attributes that would change---they delegate everything to their own reference to `handle`---so it is safe and effective to update them in place as far as I can see. (They do have two instance variables, `type` and `encoding`, but `type` is a constant passed at creation time and it doesn't change, and encoding is determined based on `handle` or a default and I don't *think* that should change either.) Updating them in place is also the only way to be backwards compatible to any code that is storing a reference to these attributes and using `clear` (not that such code worked correctly as it was, given the crashes; I have to think that either `clear` is a rarely used method or these attributes are rarely used).

As far as dangling references go, even if it was necessary to set `self.graph_attr` and friends to new `Attribute` instances, I still think it would be necessary to at least set the old `handle` values to `None` before releasing them (`self.graph_attr.handle = None; self.graph_attr = Attribute(...)`); it's not polite to leave around objects that will crash the process if someone happens to access them. But it doesn't seem necessary or useful to me to create new objects since they have no state separate from `handle`.

If this doesn't answer your question then maybe I'm missing something obvious: I don't understand what part of the solution would *not* be correct. It certainly does solve the crashes and all of the tests continue to pass. Perhaps you could elaborate on what looks incorrect.


Can we have it `npm publish`-ed? :)


Issue : Use of global variables.


No es bueno.


The methods and blocks of code from here on should have been included in a class


Have to try to fix that...


Too much of hard code, makes it tough to find errors.Code smells bad.


These methods could be placed within a main class.


This is an excessively complex conditional statement. It can be broken down into simpler nested statements for better understanding of the code.


Oh wait... That was just the first build since the cache had to be rebuilt. The ones after took less than 2 mins.


Modularity not implemented.


meteor doesn't come with ejson built in. You have to manually add it in order for the Routing code to work.


It is important that function is in a **Class**, which it isn't.


Delete


Too many parameters: a long list of parameters is hard to read, and makes calling and testing the function complicated.


more-eng-ref-corrections (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (822 of 822 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.31%25-green.svg)


Wrong attribute name


Too many parameters: a long list of parameters is hard to read, and makes calling and testing the function complicated


[Project (Regression Models).pdf](https://github.com/AnneGH/Project-Regression-Model-/files/3137/Project.Regression.Models.pdf)


Assignment


hou ma gowd!


No docstring


No doctring


Causes the score to go into negative, which should not happen.


Ten kod nie powinien być wysunięty.


Bad name


Invalid names


So it seems to work ok...


No classes like DonkeyKong class,Fireball Class,Person Class were used.


Unwanted, long print function. It could be made into simpler multiple print statements.


should have used range(1,4) instead


What do you want me to do? STORE IT IN A FILE? I WONDER HOW TO DO THAT...


The problem with this setting is that git will not normalize CRLF-s back to LF-s when checking in. So, for example when you edited the README and saved it, all the line endings changed, git didn't normalize them, and now the whole file appears changed.

What is the problem that Cygwin was having with the line endings? Perhaps there is a more targeted way to fix it?


Ez az elrejtés egyelőre ideiglenes, elismerése az ismeretink hiányosságának, de ezen elismerés nem szégyen!

A legtisztább és legegyszerűbb az lenne, ha rájönnénk végre, hogy a live másolás végén hogyan lehetne felszabadítani a használat alól a cél gyökérpartíciót , majd eltűntetni a dev/mapper/live eszközt,
és újra elővarázsolni a /dev alá az átmásolt adatokat tartalmazó, gyökérpartíciót tartalmazó eszközt.
Ekkor már legeneráltatható lehetne chrootban a jó grub.cfg. Amit a fiúk gányoltak eredetileg ennek a problémának kikerülésére (write_grub_boot_device_config), nekem egy szükségmegoldásnak tűnik, mely esetleg működhet egyes esetekben, de többnyire nem.

Ha már végképp nem megy a Live módban a /dev/mapper/live miatt a normális grub.cfg generáltatás, akkor jó lenne azért legalább meghagyni valahogyan az automata partícionáls lehetőségét annak a felhasználónak, aki UEFI laptopra szándékozná feltelepíteni, vagy hajlandó egy teljes merevlemezt feláldozni, vagy nem tud partícionálni.

Az eredeti elrejtetlen Easy módban jól működik tapasztalatom szerint ez a partícionálás, tehát, ha a w('nb)->set_current_page(0) lappal indul a telepítő.
Csupán a partícionálást végezné az Easy mód, majd utána ugyanazt csinálhatná a telepítő, mint a normál/haladó módban, csak a már létrehozott cél partíciókat használva és nem a felhasználó által kijelölteket.


Bad Names


Inheritance,Polymorphism,Modulation,Encapsulation not used.


Maybe buying a cupboard would help...


Donkey gets stuck after reaching under the queen, fireballs not implemented.


This function could be places within a class and it is recommended that you do so.


Dead Code, not used once


This class should have a file of its own.


Large Class


Long Line


Poza wcięciami wszytko ok


should be 8080?


Why did you remove them @gabizou ? It was comfortable to have the folders right away after cloning this repo. Now, https://github.com/SpongePowered/Sponge/blob/master/README.md#running has to be changed because the table says "./run/server (Included in project)". Or did I missed anything?


h3h3, h4x0r


@HackerDM
It should work....I haven't tried but it should!


beautiful


Fixes #2


Use communicative variable names.


@woloski I'd like to keep the return, so it has the same behavior as the delegated auth0.js method


too aggressive?


lgtm


Polymorphism and Encapsulation not implemented.


Excessively redundant code. The same could be easy implemented with the help of a map or a list that iterates over the given data and generates the given requirements.


Hi @elmotec yes `numpy` shouldn't be listed there because `fredapi` doesn't refer to `numpy` at all, it's just a dependency for `pandas` and there's no reason to list all dependencies of `pandas`

As for the shebang, these files in my opinion are not meant to be executable files, they are source code or test code that can be loaded. I'd say it shouldn't be considered a "script". For instance, `nose` would by default ignore a test file if it is actually executable.


Code Smell : Lazy Class


Code Smell : Lazy Class.


Its pretty cheap, don't see why not.


Try reducing the number of nested if's.


Absence of data abstraction : Class data members not divided into private and protected.


The following lazy classes could be integrated into one single **Board** class.


The classes below have almost minimalistic functionality.


Miss global surrounding parenthesis


This is hardcoded. :(

I'd suggest instead to use a regular expression to match with "TOTO/" as well. ;)


Fix spaces


Used Global Variable in wrong class. The constants could be defined in a separate constants module which could then be imported here.


Need fixing


Line ending must be a new empty line


very good


logo


promo-block


*by* defining


Эту обертку уберем


blog-intro


Excessively long identifiers: in particular, the use of naming conventions to provide disambiguation that should be implicit in the software architecture. ( brokenladders_hit)


blog-intro__title модификатор не понянял зачем тут


@flavour Solved 1 :)


Only one level, hardcoded maps, no donkey, no fireballs


параграф с классом blog-intro__text


параграф


The functions getPosition(), checkWall(), checkCollision() and collectCoin() not present.


независимый блок tags


Hard-coding Y co-ordinates make it hard to port to different screen resolutions. Also, configuration based code should be separated from game logic.


No Docstrings


This functions could be reused by other modules. Maybe put them into modules.Utils or at least on the same level as format_output.


модификатор эктив только у первой ссылки)


Indentation


@benzakour Un caractère bizarre s'est glissé dans la classe LockedDoor, peut-être une incompatibilité entre Windows et Linux...?


What do you think about simplifying this line by using [union](http://ruby-doc.org/core-2.2.0/Array.html#method-i-7C) and [strip](http://ruby-doc.org/core-2.1.5/String.html#method-i-strip)?:
```ruby
result_emails = (existing_emails | remote_emails).map(&:strip).sort
```


should be on different lines. Not PEP8 standard


At least, I can get people mad at other people :laughing:


No new lines at the end


тут еще ссылка внутри на удаление


Thanks. Committed.
https://github.com/apmuthu/LimeSurvey/commit/c9717e1432c851c0925f1755c3b07c9e663b570a


Mixed indentaion


Lényegében ezért van az elrejtés a kidobás helyett.
Őszintén szólva viszont többre értékelnék egy netinstallt, mint egy live-t.
Amúgy az új repóból használva az installert, működik?


Too much dead code->Code Smell


This could be improved by making a array **block** instead of having so many objects of the Block class.


нужен, для логики и белого фона


Most likely it will BuildRequire (for build tests) and Requires python-dateutil module


No new line


No new line again


features-row


Indentation not perfect.


Wildcard import, not PEP8


feature feature--icon feature--icon-house


удалить


feature__title и дальше feature__text


Global constants could have been imported from a single module, and not initialized in every file


I think that some of these issues may have aleady been fixed.

The default window size can easily changed and is remembered between sessions.  If the window is bigger than the screen size then resizing it can be difficult.

Screen resolutions have been discussed before.  I suggested introducing a laptop mode, but it didn't get much support.

Please revert this change.


Line 105-140
Hardcoded values should be replaced with variables so that if the values are changed, they only have to be changed in one place.


Good .. 哈哈


features-row--with-columns -> features-row--gray


Bad whitespaces


повтор независимого блока blog-title


Two blank lines must be left between the class and it's first method.


Bad whitespace


Этот блок чать поста ниже


Use communicative variable names.


This class should have a class of its own and should not be in main.py


close #69, close #99, close #78


Thanks!


There are many mixed-indentation, bad-whitespace, line-too-long, bad-continuation, missing-docstrings, invalid-name, unused-wildcard-import, bad-indentations, unused-wildcard-import.


для ссылок тоже класс


Don't quite get you, I kept this method available and signature remained the same. Do you mean that we need two implementations of this method — plaintext and JSON based?


thanks


а классы? тут и для вложенных жлементов


Too many parameters: a long list of parameters is hard to read, and makes calling and testing the function complicated.


одной картинкой


Nice thumbs.db


The following lines of code till line 294 has been hard-coded. Would be hard to modify the code. Using loops and variables could have made the code more readable.


These should be present within a main function .


> Can't we just run with -fwarn-unused-imports when we want to do that?

I don't think so. The output of  `-fwarn-unused-imports` is GHC version dependent. Let's suppose that when Agda will remove its support for GHC 7.8.4, Agda supports GHC 7.10, 8.X and 9.X.

If I use `-fwarn-unused-imports` with GHC 7.10 for removing the unused import with GHC 7.8.4, how I know that the reported unused imports are not required by GHC 8.X or 9.X.


There should be space around an operand like " = " . Not following pep8 standards


Hi,

please stop the test, is broken on linux machines.


от сюда и до 73 строки просто теги без классов


Does not clears the screen when starts the game


Line 146-219 :
Duplicated Code.
Code Smell.


Added a link to the Web Things model and its corresponding implementation.


OOP principles not implemented at all


Thanks!


Are you guys going to use domain objects as DAO as well? It's not the best idea: dao and domain objects serve different purposes, just like dto vs domain.


Player can jump up on broken ladders. This is against the proposed problem statement.


A live installt már sikerült meggyűlölnöm.
A netinstall nekem is nagyon hiányzik, de ki az aki meg tudná csinálni?
Még nem próbáltam az új repóbéli installert, de, amint hozzájutok megnézem.
Egy telepítési próba normál módban majnem egy óra, live módban fél...
Amúgy fel is lehet telepíteni próbaképp a telepített rendszerre és megnézni, hogyan indul, nem muszály telepíteni vele. Az elrejtést is így próbáltam ki, a glade2 -vel meg a glade fájl működését néztem és derítettem ki vele a handlereket.


Too much dead code-> code smell


The functions getPosition(), checkWall(), checkCollision() and collectCoin() not present.


Player and fireball can be present on the ladder at the same time without causing any damage. This is a major bug in the game.


@abnero DWMR.  Press on!


Yes!  I will fix it and resubmit it.  Had some gigs the last two days but after the Titans game, I am back in!

Ty
> On Sep 26, 2015, at 9:58 AM, Christopher Beck <notifications@github.com> wrote:
>
> should this be == ?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/tupeloTS/bloc-jams/commit/39647591db396c5abe8764c073302a940059ba05#commitcomment-13451953>.
>


Use communicative variables.


Too many if's try to reduce them.


Game is buggy and causes the player to get stuck *Inside a floor block*.


Person Class should contain movement methods which should be inherited to Donkey and Player.


is there no package that does this kind of stuff? would be cool to have


actually, I guess @gkz's https://github.com/gkz/type-check or other things already exist..


Unfortunately I had to stop this test since it was crashing linux machines.  I like this patch/idea, please keep working on it and find what causes the crash.


Actually this belongs to:
 Support any kind of configuration at TS3 #540


removed 3 accidentally pressed  keys


Code Smell : Cyclomatic Complexity
 Too many branches or loops; this may indicate a function needs to be broken up into smaller functions, or that it has potential for simplification.


any reason to use parens here?


@help3r You can find Compiled versions of 1.73 and 1.5 on the MineTexas Website: http://www.minetexas.com/minecraft-civcraft-download.html

1.74 will be out soon with support for localization and some other bug fixes.


I guess that's Om-like :P


Suggestion: Remove `const` from the declaration of `difficulties` and, if it's empty (ie, in this `if` statement), iterate through the `child_range("difficulty")` and `push_back` each one's `define` into the `difficulties` vector. (If it's still empty after doing that, _then_ `return ""`.) Then you can also uncomment the code below.


さんきゅう!!特に問題ない!マージしてもok。タイミングはお任せします!


Code Smell : Large Function
Can be broken down into small functions.


The game doesn't work like its supposed to
- Jump functionality not present
- Images are mixed up
- Can't lose, no fireballs, or damage inflicted by donkey


@cehallen DWMR. The total row height seems to be affected by the 'real' height of the image. I say this becuase each row has a quite tall blank space below the comments.
![screen shot 2015-09-27 at 11 29 13 am](https://cloud.githubusercontent.com/assets/9028552/10123571/0089bcbc-650b-11e5-9964-3c65de9c32d9.png)


Code Smell : Large Class (God Object)


Nice catch! (I must admit I haven't touched tänzer in awhile, but it seems like the right thing to do now, so...)

I shall merge this summarily. Thanks!


Why did you switch from GL3 to GL?


Oops.


Cool stuff! Keep it up!


Suggestion: Go through all this (from `difficulty_opts` to here) only if `current_level().data().child_range("difficulty").first == current_level().data().child_range("difficulty").second` - though probably save the child range in a variable instead of repeating it three times). Then you can also convert it to a config (be sure to declare that config in the same scope as the dialog) and pass the child range from the local config instead of from the campaign data.


TypeError maybe.


@jgarboza813 DWMR. Thank you for the effort. Keep pressing!


ReferenceError


Code Smell : Large Function
It can be broken down into smaller functions


KIpróbáltam.
(uhu-installer:1218): libglade-WARNING **: unknown attribute `swapped' for <signal>.


これは今はエラーになるのでコメント化しています


Player's motion is not constrained.lt's a bug.


初期化忘れています!!


この書き方素晴らしい！！


`success: this._success.bind(this, uploadId)`.


extlibs/include/GL3 does not contain glx ! And it's normal, https://www.opengl.org/registry/ only mentions the specification not the file. A bit like #include <windows.h>.


![device-2015-09-27-170921](https://cloud.githubusercontent.com/assets/3715409/10123580/8fff6428-653d-11e5-8240-691052600703.png)

I will also add this to Manga View, if I finally find out how this internal database stuff really works.


dto will conform dao

2015-09-27 18:19 GMT+03:00 Olexiy Myronenko <notifications@github.com>:

> Are you guys going to use domain objects as DAO as well? It's not the best
> idea: dao and domain objects serve different purposes, just like dto vs
> domain.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kalexi/MailBot/commit/ba1c787edf8de990d4697dacfad38126a0733d4d#commitcomment-13457016>
> .
>


I assume this'll be updated soon, right?


There should be space before and after a comma( , ) operand.Not following pep8 standards.


What was the bug here?
It looks to be a performance issue (one copy when it is not required), am I right?
If I am correct, the "problem" is that the reference type may be use in std::functions so incorrect type_traits still have an impact no?


Code Smell : Duplicated Code
Could have used a function or a loop.


あと
```java
if(!errFlg){
   break;
}
```
追加でいけると思う。こっちでやっておく


Score function is implemented.


Still needs support in `[message][option]` for this new syntax, which may be a little harder since it's entirely possible to have some options in the old syntax and others in the new syntax, all within the same `[message]`. Also the Lua `show_message_dialog` will need to be updated, as it currently accepts only a list of strings.


ここも上と同じく


Coins function is not implemented.


Donkey class not implemented.


Use of Global variables should be avoided.


Wouldn't it still be `true`?