#823
В окне `Видео` появляются кнопки `>` перед каждой ссылкой. Клик по кнопке скроллит к посту, содержащему ютуб-ссылку.


deriving clauses on same line with the `}`


If you want to make writeable just the sources, why not chgrp /opt/app-root/src ?


ja hat nicht halt genervt, soll es wieder rein? ^^ :D


I'm referring to the author of this git commit ranting in the commit message! :)


Если тег уже стоит то не важно когда пушить, если его еще нет, то исправьте и потом поставьте/запуште.


Можешь дать этим div'ам и span'ам классы? А то такие селекторы замедляют работу браузера.


Yes, but the thing I tried to point out is that you basically compare configurations in pipeline.xml with configurations in dpu.xml, so basically you compare configurations between two files in the same ZIP archive prepared by single export process. So is it even possible that the configuration differs?


Our convention is usually to avoid the above one liners :)


auch das, damit ascii, cd, zih texte immer auf einer aufgeschlagenen Seite sind


This is what it looks like:

>Compatible with Windows XP -> Windows 10 Appveyor Kvirc continuous integration system provides automatic builds from Git master and they are kindly offered for download at d00p.de

Remove the list of compatible Windows versions (we are just compatible with all of them), you don't really need to explain that we use Appveyor or what it is, and *KVIrc* is written like that, respecting the caps


How was auto wiring failing here?


Скажи спасибо, что не `#de-info-table span:first-child { flex: 1 0 auto; }\`
:D


Missing NonEmptyList


Atualizar upstream e tentar novamente.


Oups. Thanks to notice that!


My Gosh! :100:  I am so used to code this way! I guess I am gonna have to be more careful when working on rest module. :smile:


No customView touch events passed


Only. Took. 4. Hours.


fml @AKlepac


Help please! @jojoe77777???


Хотя, такой селектор бы не сработал, ліл.


Awesome!


Thats a better review. fixed in 10. 9. 8..


Unfortunately I didn't find time to figure out why that happens but the reference was always null when I used autowiring


uhh hmm


all tests pass:
success: http://buildbot.bos1/builders/test-riak_ql/builds/98


*slowly walks away*


Why not make it a `Monoid` and just `mappend` the fromExecutionLog into the tree?


If the backing indexes are now NSInteger rather than NSUInteger, we should document it somewhere since this probably changes the max element count.

I mean an implementation note in COMutableArray and something more geared towards the framework user in COObject (like the max element count in ordered collection is not NSUInteger.max but NSInteger.max).

May be we should detect indexes bigger than NSInteger.max in -replaceObject:atIndex: and similar COMutableArray methods (the ones from NSMutableArray class cluster API).


Yeah, good point. Having a reproducible output when we do automated testing is the way to go. But on the other hand, this bug will only be triggered by real humans using their browser, so we need some kind of integration testing one step higher to test that.


Hi,

In the third step I am not able to login with the ldap user i.e. wbush
I have followed steps 1 and 2 correctly and everything works fine in those steps.

The AEM sign in page throws a 403 error. I am not able to understand why such an error is thrown even after following the steps correctly.

Please let me know how to resolve this issue.

Thanks


This seems too similar to FullStatEssence, and lacks the distinction between files and directories (where we want different subsets of the Stat stored). Is it correct? Can this be moved to the FileDesc module where it can make more sense?


Hi.

i'm think - it would be nice have the same thing but on a home computer from x86 processor and compile it all much faster ?
I'm think this need very simple changes.. or you have this variant?


Hi

Sorry, if I omit the @address, the ssdp is still not broadcasted through
the interface I need it to. Same behaviour as if address is replaced by
'0.0.0.0'.

Best regards
Espen Ljosland

2015-09-08 12:50 GMT+02:00 Eelco <notifications@github.com>:

> Thanks a lot for making the PR. If you omit @address the OS should try to
> listen to all addresses. Can you try that?
>
> I'll look at the rest of the PR later.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/slasktrat/node-upnp-device/commit/4f761f86a171fb662ba9730dec0ac45737451110#commitcomment-13109094>
> .
>


Do you just wanna keep quiet about the above? :)


I think it's ugly that ExecutionLogTree has its types/invariants encoded here, and then the implementation on top in a different module.

Would make more sense to have ExecutionLogTree module live underneath and be imported by Db.hs altogether.


Ah. Sorry.  Well I found this weird. What's your opinion regarding cm trying to create a separate android? I think is very good to start removing Google monopoly over this. They control everything on information regarding their stuff which become really annoying. Perhaps this small change will make things improve at Google. Thanks


@PEMapModder? `@jojoe77777 gets shot...`


Thanks, this was added upstream!


Ty!
On Sep 7, 2015 10:35 PM, "Josh Klontz" <notifications@github.com> wrote:

> @bklare <https://github.com/bklare> :p
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/biometrics/openbr/commit/6b9acbbd7a587c14dfc71f26ac60c4e1afc6deb0#commitcomment-13103430>
> .
>


I got a warning from gmail saying that this comment might steal personal
information... Lol.

On Tue, Sep 8, 2015 at 9:47 PM, legoboy0215 <notifications@github.com>
wrote:

> Help please! @jojoe77777???
>
> —
> Reply to this email directly or view it on GitHub.
>


Can you post the errors you receive?
On Sep 8, 2015 12:40 AM, "LUO Yun" <notifications@github.com> wrote:

> It seems the version1.0.0 cannot compile successfully on both linux and
> mac os.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/biometrics/openbr/commit/6b9acbbd7a587c14dfc71f26ac60c4e1afc6deb0#commitcomment-13104189>
> .
>


:P


If the code is copied, please try not to add the same error !
In this case, follow the same changes as on this https://github.com/paulbrodner/desktop-automation/commit/ca5afeb71fa85ffe1aa2ead6269c1e2e249694a7#commitcomment-13107889


Should be enclosed in { }


should be set automatically


also aupdate images


Line is too long. [118/100]


Line is too long. [112/100]


Line is too long. [133/100]


Same line as `(`


Yes I think I do otherwise every time getReverence() is called when attempting to create a new resource it will fail. Besides if the formresource does not have a clobdatatype associated with it it won't hurt telling the user so instead of throwing an exception. In fact it took me so much time to figure out the exception was thrown  by the getter in FormResource class and I still don't understand why form resource metadata can not exist without having the resource associated with them?!


appUserRole = 'GFM_APPLICATION'
revision = getGitCommitHash()
...
liquibase {
    activities {
        main {
            changeLogFile changeLogFile
            url dbUrl
            username dbUsername
            password dbPassword
            changeLogParameters(['liquibase.appUserRole': appUserRole, 'git.committedHash': revision])
        }
    }
        runList 'main'
}


Looks like this commit broke build.
Please see http://ci.cgeo.org/job/c-geo/4023/console to remedy the problem.


How about using `repr(value)` instead?


You pointed out something that was not correctly implemented : the task class was actually a workitem and task, epic, story are types of workitem.
I did a big change in the code to handle that.
EPIC1/EPIC2 here are actually states of epic workitems.
The code should now handle these, though there is room for improvement with different classes etc. I did it the quick way for now.


The rest of buildsome avoids the weirdly-typed Control.Arrow functions. Just define it on-the-spot as needed (2 lines including type decl instead of 1 import line, but clearer).


Why a commit with commented out code? Just add it later if need be? Or add it unused here?


Fixat.


Comment about throwing out the reason here


Redundant parens. (.) is infixr 9 and "almost" as tightly binding as prefix application, so that it can avoid parens in almost all situations


Haha, so this was just plain unnecessary?


That log is from `Rectify`?

We were previously using different named variables for logging, which I found confusing (should I be using `hLog` or `fLog`?), and it doesn't seem to fix the issue you have identified anyway? (nothing stopping `hLog` and `fLog` both setting the same key?)


Redundant parens


This is a VERY weird function! I think it'd be better to directly use "maybe" combinator where it is used instead.


seems fine, I just wanted to log the initialization info at the beginning so the user knows everything is working with the correct config... will be bad if he waits for 2 hours and then finds out the wrong config


Avatar `https://avatars2.githubusercontent.com/u/14075024?v=3&s=200`
![14075024](https://cloud.githubusercontent.com/assets/4997583/9734343/7893aec6-5632-11e5-9b4b-a4b0e2d193a0.png)


The `template` and `templateprovider` parameters are not one and the same.
* The `templateprovider` specifies the template to use and any restrictions on the space where you can use it.
* The `template` parameter specifies just the template document to use.

Look at the code you`ve removed above:
```
    #else
      #if ($template != '')
        ## if a template is set (to allow to get the create form from a template directly, without having to choose
        ## the template provider), use that template
        <input type='hidden' id='template' name='template' value="$!{escapetool.xml($template)}" />
      #else
        ## finally, if none of these are set, put an empty template provider
        <input type='hidden' id='templateprovider' name='templateprovider' value='' />
```
...this should still be kept.


What's this commented out code?


Also, I'm not sure why the `np.float32` condition is necessary. A quick test with numpy 1.8.2 on Python 2 and Python 3 shows identical str output for a np.float32. The same applies for repr.


We will know if nothing out there explodes loudly...


Redundant do and thus redundant indentation


In new modules, can we move to indent=4 (internally consistent inside these modules)?


Would be prettier to use case (inputDesc, mStat) of ...  instead of a nested case here


I don't know how to deal with that.
The initial code should have done the job.
Which version of python-requests are you using ? I guess it helped on an older version of requests. On my debian python-requests-2.4.3-6, it's working  but on erwan's old 2.2.1, neither my version nor yours work.
I'm committing you patch : this will work for you and me at least :)


Больше классов Богу Классов.


If you throw out a reason, it'll be nicer to use _reason  instead of {} here.


@gonengar  What do you mean?


Did i see a ticket comment about renaming clobdata to formresourcedata?


Use repr? i.e. `'GeogCS({!r})'.format(self.semi_major_axis)`


Redundant indent in all these cases


Either "x86/x64" or "32/64 bit".


I'm Australian :P


Mac -> OS X


`all id` = and


IK. I was just boring,... ^_^


`maybe` combinator can be clearer here rather than a full-blown case


You forgot the `break` at the end of the case. Not having that makes opening new windows/files/tabs all sorts of visually unhappy!

Also, since you are just setting `setTitleWithRepresentedFileName` both times in the if and in the else. you can set that before the `if` and on the result of the file not existing, change the representedFileName.


These 3 cases are similar enough that they can use a local `where` clause to remove repetition?


No lazy IO please :)


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


No `-Wall`? No type sig?


:question: :grey_question: :question: :question: :+1:


Мне лень коммитить, потому напишу прям сюда:
```js
getTable() {
	return this.getData(false).map(data => `<div class="de-info-row">
		<span class="de-info-name">${ data[0] }</span>
		<span>${ data[1] }ms</span>
	</div>`).join('');
},
```


it looks like it still re-renders the entire list with this?


che la otra excepción que había creado la pedía el enunciado, con ese mensaje: 'Wrong number of arguments (0 for +1)'


Have it take a `stat` rather than `mStat`. Then if you use `traverse inputLogFromStat` you get the current function.


Remove this


```
return $ Just InputLog
   { ...
   }
```


you really like this include...


`t.last_checked_at` returns start-of-day, which makes `time_ago_in_words` confusing in the view. Temporarily removed.


LGTM.


Code looks fine to me if I don't nitpick about needlessly removed empty lines e.g. in source/render/Gui.cpp ;) This PR has seen enough git learning, let's try to get it merged.

I'll test the feature again in the evening.


insert: @Id
    @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "sq_beacon_id")
    @SequenceGenerator(name = "sq_beacon_id", sequenceName = "SQ_BEACON_ID", initialValue = 1, allocationSize = 1)


I'm confused, these 3 fields are supposed to represent the kind of access that was done on the file, not the kind of data we available from the file system..?


Yes this still works like before, I added it to support `this.get('metaObject.selected').pushObject(item);` instead of having to do `this.set('metaObject', { selected: [item]});` but the rest works like before


I think we can try this approach (but old one w/o observer) on more complex examples like the select or dropdown component? @piotrpalek @vanthome


This was removed for to use the same behaviour for middle buttons as for left and right


You don't really want filterM which always pays the full price. You want to stop at the first match. Can use a custom `whileM` combinator, or maybe `EitherT` to break when found.


the json result for unknown users is ```{}```


indeed, HACKING lacks info about this.  and yeah, we have some of those, AFAIK they come from some Glade2 generated code.
Anyway, don't worry too much about style, IMO it should be fixed so it's more uniform but it's totally trivial and of low importance.


Ahhh jaja la sque pq me aparecía un montón de veces y yo pensaba que era de
ruby, me volvi loco hasta que me di cuenta que era una custom xD Volvele a
poner así si lo pide el enunciado.
On Sep 8, 2015 09:09, "Federico Cano" <notifications@github.com> wrote:

> che la otra excepción que había creado la pedía el enunciado, con ese
> mensaje: 'Wrong number of arguments (0 for +1)'
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/marvelek/tadp-2015c2-tp-metaprogramacion/commit/e190eda33558aeccd135db2229d2aaf07cd0e480#commitcomment-13110466>
> .
>


Any idea why this `id` attribute hasn't changed? (It changes in the other CML files which makes sense - the ID depends on the str of the coordinate system.)


The code is partially bottom-up, partially top-down. Can you use consistent ordering? I prefer bottom-up (so I can read it without encountering names I do not know yet).


Предлагаю вместо `de-info-column` использовать `de-info-stats` и `de-info-log`. Вместо `.de-info-column` писать `.de-info-stats, .de-info-log`. А этот стиль перенести в `scriptCSS`: `.de-info.log { overflow-y: auto; border-left: 1px solid grey; }`.


Before this the system just accepted unknown users and displayed them as if everything were alright.


Could you explain why this should be added? The need to escape characters makes it difficult to understand, and since punctuation (from what I gather, meaning everything non-alphanumeric) is not to be taken into account when checking for a palindrome, the string amounts to `0000`.


You have not used the files I sent you. So, it probably still doesn't work.


I think you are wrong about this : the public version of unregisterMBean is supposed to remove the bean from the list.
You have problems because you try to use this method for another purpose.
You have two solutions :
1/ use a LinkedList, quote from LinkedList :
> The iterators returned by this class's iterator and listIterator methods are fail-fast: if the list is structurally modified at any time after the iterator is created, in any way except through the Iterator's own remove or add methods, the iterator will throw a ConcurrentModificationException. Thus, in the face of concurrent modification, the iterator fails quickly and cleanly, rather than risking arbitrary, non-deterministic behavior at an undetermined time in the future.
2/ split mbeanServer.unregisterMBean call into a private method and call it directly from destroy()


Is `msum` correct here?? It'll just take the first IO action that didn't throw an exception, regardless of the `Maybe` inside!


Somewhat at a tangent, presumably we could do with updating `Coord._xml_id()` so any attributes are converted with `repr` instead of `str`? i.e.

        for k, v in sorted(self.attributes.items()):
            unique_value += (str(k) + ':' + repr(v)).encode('utf-8') + b'\0'


you should have a synchronized on destroy()


Instead of `map (second...)` you can just use `fmap` (or `Map.map`) before `assocs`/`toList`


![Uploading Mr.killer.png…]()


Where are the tests ?


The information from pipeline.xml is incomplete. While you have info about the template from which is the instance created, there isn't info about the template parent template
So to have the complete info, you need to do: pipeline info from pipeline.xml + parent template info from dpu.xml. So yes, I compare the configurations from the same zip and i'm relying on the fact they have their config identical


Comment about throwing out the reason?


they could if you didn't know for sure `&builtin_so_proxy_` will *always* be present in the hierarchy -- and that you handle those in a special way.

But yeah it'll work just fine as it is, and whether it's best or not is probably very subjective.  Keep it like it is if you prefer


shouldn't we pin the vagrant-wrapper version on the Gemfile itself?


maybe we can indeed change it, since IDs are used in other places of the image..


@knu - This check came up in #1345. Is there something we could be doing differently to find iconv.h? Why aren't we using any of the mkmf directives to do this?


It was just a suggestion and I responded that I don't think it is a good idea since clob data is meant to be generic. That is it can be used for things other than form resource.


More weird commented out code..


4 Choix widgets


Base segment D will be super useful for 4L HW!


have you submitted this to Jules as a fix?
otherwise as soon as we update Juce again, this is going to return as an issue....


Sorting is a bad idea...


It'd be better to place the member near from ``msg_qlock``` to avoid unnecessary memory holes due to alignment.


Redundant parens.. {} binds even more tightly than func-application


Yes

On 8 Sep 2015 at 14:17:42, Mark Harris (notifications@github.com) wrote:
> have you submitted this to Jules as a fix?
> otherwise as soon as we update Juce again, this is going to return as an issue....
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Eigenlabs/EigenD/commit/08c5fc289b7097f4e35e9fb4a8cfc791a904756d#commitcomment-13110607


Instead of error, output some warnings


Choix widgets 1


:+1: for both :smile:


LinkedList does not solve this bug.


Can you squash this?


Make that 13 lines. Still better than nothing.


Commented out code isn't a great way to have debug prints (it's not even type-checked). Maybe have a dynamic flag to enable it instead?


Remove these


Any reason for not having sub classed BaseRestController?


First, you don't reply to the right comment, second, you are supposed to elaborate


use case ? these calls under darwin should never fail.


You can use `JvmCodegenUtil#getDirectMember` for this stuff


insert @Pattern(regexp = "^([0-9A-F]{2}[:-]){5}([0-9A-F]{2})$")


<!DOCTYPE html>

    <meta charset="UTF-8">
    <title></title>


This should test the exact number of spaces. Right now the test would even pass with the old approach.


Are we using journald for logging for these components on RHEL? Just curious as to whether we are expecting to find the data in the `journalctl` output or the `/var/log/sahara` scoop?

Either way: I would like to see the `/var/log` collection tightened up and subject to size limiting although it's not urgent (it was there before this PR and it's fine to fix later but we should probably file an issue if it's not going to be done right away).

Ack to the patch for this pull anyway.


insert: @Column(unique = true)


还是用脚投票肉身翻墙吧


Maybe but one can always pull those bits back and reuse them. I'm certain that the existing arch will not fit into their appliance model anyway.


So if only the SRQ holds reference over the RQ, why not destroy the RQ in rxe_destroy_srq?


On the one hand I think ~PAGE_MASK looks better than PAGE_SIZE - 1 (which I would parenthesise out of habit), but on the other hand with PAGE_SIZE on each side the relationship between the two sides is clear.

Good catch.


it breaks go1.4.2


haha, 10 hours of repeated start/stop and the random startup crashes have vanished.
I think the key bits were with tracking area.


Hello,
        I want to install 'IIB Maven plugin' in my IIB toolkit; however it doesn't find the plugin. I am trying to do from 'Install New Software'. Is there a site link for this plugin?
Please help.
Thanks
Anand


With this refactoring, the logic to handle duplicates looks much cleaner :)

btw… Shouldn't this logic be moved up to COMutableArray?

We disallow duplicates for multivalued relationships but not for multivalued attributes. I'm wondering whether we should disallow duplicates for multivalued attributes too by default. We probably discussed this in the past, but I forgot our conclusion.

For ETStyleGroup.styles (ordered multivalued collection of ETStyle objects) in EtoileUI, I need to support duplicates. This support is now broken, since relationships now require to be stored in COPrimitiveCollection instaces and not anymore in plain Foundation collections due to the dead reference support I added.
I was thinking I could tweak CO(UnsafeRetained)MutableArray to have an extra property 'allowsDuplicates' I could override just for my use case in EtoileUI. This would be clean enough. What do you think? Any pitfalls to be aware?


LinkedList does not solve this bug : I am able to reproduce it while using them.
I think "register" and "unregister" method visitility should be private ( I see no point of having them protected ).
I am going to not use unregister call in destroy.


cool.
btw, what do you think about moving to using submodules... rather than this copying of iuce into this repo.
would allow much easier upgrading of juce, rollbacks etc.  on another project I collaborate on its done this way and its much better.

(if you need to do code changes, then you simply fork the repo whilst necessary and link to your fork, and then go back to the 'master repo' once your changes (or appropriate alternative fix) are integrated)


I would write "Align output of `machinery config`" instead so it is clearer what was changed


Ммм. Тогда можно поудалять правило `flex-flow: row nowrap;` из скрипта. Оно же по-умолчанию стоит.


I don't remember specifically, I think it was just something I noticed in the middle of a different change and wasn't sure about. Glad it worked!


Yup that was the plan, I'll make a branch for the dropdown, select should (probably) automatically work then. Also I'll revert this commit then.


So we've heard. Is there a reason you can't upgrade to go 1.5?


related, others also had the super call in updateTrackingAreas while apple's example did not. go figure.


Looks good to me, please fix tests.


we could transform it as a note section


Ok, I finally got it but I had to explicitly save the files with only LF's.  Is this the intended setting for all files in Emby?


I'd rather not, it was a drag when we did that initially. I don't really want to research the current state of sub modules and the pros/cons, ...


OK but I think you could just do:

```
$(EDK2_PATH)/Conf/target.txt:
        cd $(EDK2_PATH) && $(BASH) edksetup.sh
        $(MAKE) -j1 -C $(EDK2_PATH)/BaseTools
```


Adding the uuid label in the message above will make it clearer.


You should also change the compliance level of Spoon in the class constructor. It's a property of the environment object.


Same here


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/20244/testReport/) for this commit**


Same here, simpler with multiple commands I suppose


LGTM.


need to store data before sending into manta, because data can be passed with offset, and manta does not support Content-Range header


Thanks Daniel!!

Just made a comment on line 113 (there's a "senha" remaining in there :P)

Best regards,
Daniel


go1.4.2 uses go tool 6l when building on AMD64,  go1.5 is ok


The word "senha" is still there :P


Hi,

Sorry for my delay in keeping up with the discussion. Does this unit test fail what https://github.com/cmprescott/ansible-xml/pull/21 shows to fix? I might try to fix up issue's PR along with some others this week and trying to get a census of where issues are at.

Thanks!
Chris


Hi guys, tried the latest version, got everything successful, except of this:
![2015-09-08 16_33_54-console output](https://cloud.githubusercontent.com/assets/14163350/9734852/0dd4c77a-563f-11e5-8a73-af0d72e7922e.png)


Oops xD
Thanks man, I'll fix it!


@joni2back Firstly, thank you for your great work!

Actually, I think the form changes/will change too many aspects of the upstream repo:
I made this fork primary for our Everbase product (Next gen file server). Some important necesseties for Everbase Fileserver UI are:

* Make it to work with websockets (autoupdate)
* Support promise-based communication
* Introduce strong linting (eslint & jscs,  our cpmpanies standard)
* Make it work with plain Angular *and* with Ionic (e.g. use Ionic provided popups)
* Write in ES6
* optionally (introduce async-await syntax)

Thats much but I think many point are really great, or?

Generally I think that an event driven architecture makes sense: You subscribe from your host app as a listener to this plugin and  provide data and handlers yourself (default could be the current ones).

E.g plugin sends out only message 'copy' with params  to all registered functions:

```javascript
// host app
filemanager.subscribe(filemanager.filetransaction.enum.copy, fnListener)

// plugin; triggered when copied
Promise.all(registry.registeredCopyListeners.map((fn) => fn(file, targetCopy))
```


Sorry about that, just [pushed](https://github.com/HubSpot/dropwizard-guice/releases/tag/dropwizard-guice-0.8.2.0) it :)


If you referring to readme name its been like that for years.


fp (file pointer abbr) was copy-pasted from registry/storage/driver/filesystem/driver.go


I've showed this to Holly, she'll think about it when she has more time.


Adding the uuid label in the message above will make it clearer. Instead of just the uuid value.


copy-paste


Я вот тоже хотел спросить, но думал, тебе надо.


Thank you! This commit fixed the build. It was broken since http://ci.cgeo.org/job/c-geo/4023/


This is a potential NPE, when ```obj``` is null. If ```this``` and ```obj``` are switched, the NPE is prevented.


fixed. Should really rename the MacOS.txt file here as well but its been like that forever and none complained about that.


Use Map of character and list instead of performing string concatenation.


modifying the commit message


I am not sure I am following.


I don't think so. If the index == #patients then the last patient has been indexed already (line 145) and thus needs to go back to 1 again.


Да мне всё равно как-то. Я только знаю, что в IE10 если не написать правило `flex: XXXX`, то он по-умолчанию применяет `flex: none;` когда остальные браузеры `flex: 0 1 auto;` Правда там нужен префикс `-ms-`.


Reboot method should be implemented in moulinette first !!


Temp hack to work around global destruction crashes. this hides the real problem but since global madness is on the hit list, I'm ignoring that fact.


Something like: "No form resource with uuid"


Hello people, I don't know how to participate in a existing project on github. I sow this changes need to be applied to qtwinmigrate and qtpropertybrowser too. I made this changes but I cant send it. What is the best way? Need I create a fork?
Best regards.


we might want to run something like clear() here


use list of int to hold indexes of characters found in String.


Drat... I knew I forgot something. :-/
Will do.


@pgo-eea-sk Once again, this is quite a big change, please do not commit directly to DEVELOP. Thanks! Everyone else is able to follow the development workflow, please follow it as well and prepare pull requests which are assigned to me. Thanks!


Not sure what code style applies here, but if I remember correctly, there should be no spaces around parentheses.


we might want to run something like self.clear() here


No Need to create separate class for only main method.


Isn't a better approach to let the tests broken while generator is not fixed? Or aren't any plans to fix the generator soon?


OK, let me pull it again and check


Uhuh, nope,
DLNA spec is available for DLNA association members only,
and membership caosts an arm. (aka 700+)
Lame dlna !

> Le 8 sept. 2015 à 11:06, Olivier Oeuillot <notifications@github.com> a écrit :
>
> Do you have DLNA spec ?
>
> I can not find them !
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13107151>.
>


I am using a newer version, as:
python-requests                       2.7.0-3


AFAICT, no, it's [used to sort the `plugin_list` GList](/kugel-/geany/commit/e1e8349658b14dc1ae889ed0e5f3ff7ae87daa49#diff-315e8720481183cf75b604b969f170d6R1168).  IIUC it's so that when building the tree the parent comes before its children, which makes sense indeed.  But if I understand the sort function correctly, it'll sort all plugins of the same proxy at the same level (makes sense), but otherwise a bit randomly.  And comparing 2 native plugins is unstable BTW, although it might not be very problematic.

But if I may suggest, what about a simpler (IMO) comparison just using the proxy indirection count?
```c
gint da, db;

/* compute both plugin's depth (proxy indirection count) */
for (da = 0; pa->proxy != NULL; da++)
	pa = pa->proxy;
for (db = 0; pb->proxy != NULL; db++)
	pb = pb->proxy;

return da - db;
```


name of list should be starts with lower case letter


I'm curious about this. Why aren't you using @PersistenceContext ?


测试


While I still do not have a compiler in my head, I think that this ```Collection``` should be giving out the "raw type" warning.


Choix widgets 2


this should be else if instead of else


xDD no problem!! :D


okay.  well, it's true that it's not very problematic and aren't even warnings, just infos.
would be nice to avoid it but no biggie either indeed, I didn't properly realize what it was about.


Please add comment that TfwConnection can live longer than underlying TCP connection, for example in connection failovering case. This is important design point which means that TfwConnection could be alive and valid, while ```sk``` member in it fully unusable.

Meantime TfwPeer is the property of TfwConnection and it's always the same for the same connection, i.e. TfwConnection has no sense w/o live TfwPeer and can't change its peer.


Why this method in not used internally if it is created.


Yes I known, but it was possible that you have access to it ;-P

2015-09-08 14:44 GMT+02:00 s-leger <notifications@github.com>:

> Uhuh, nope,
> DLNA spec is available for DLNA association members only,
> and membership caosts an arm. (aka 700+)
> Lame dlna !
>
>
> > Le 8 sept. 2015 à 11:06, Olivier Oeuillot <notifications@github.com> a
> écrit :
> >
> > Do you have DLNA spec ?
> >
> > I can not find them !
> >
> > —
> > Reply to this email directly or view it on GitHub <
> https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13107151
> >.
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/oeuillot/upnpserver/commit/0cee30a505a497d7548845c9f32099ede3bba563#commitcomment-13111065>
> .
>


why null is passed here??


И вместо `flex: 1 1 auto;` писать `flex: auto;`. Да и `flex: 1 0 auto;` на него можно заменить для ясности, в существующих случаях сжатия и так быть не может.


In other words, if the user isn't using NewtonSolver, then we die with an error?

No; in that case we want to just continue (or better, emit a warning if the user isn't using NewtonSolver but require_residual_reduction was manually set to false).  There's currently no code in the GRINS library for replacing NewtonSolver with PetscDiffSolver but we don't want to break if an app does so manually.


Посчитай отступы еще раз. Уверен, что там не такой шлак, и есть какая-то логика. + если ты пишешь все отступы, то зафигачь в короткой записи: padding: top right bottom left;


Mention why LinkedList is used here??


TeamCity Zimbra-Community :: python-zimbra :: Test Py2.7 [Build 18](http://ci.blueocean-net.de/viewLog.html?buildId=36&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy27) is now running


TeamCity Zimbra-Community :: python-zimbra :: Test Py2.7 [Build 18](http://ci.blueocean-net.de/viewLog.html?buildId=36&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy27) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 62 Build time: 00:00:25
### Failed tests
```
tests.test_genrequest.TestGenrequest.test_genrequest_batch_invalid_xml (Create a batchrequest only using the Communication-object,): <no details avaliable>

tests.test_genrequest.TestGenrequest.test_genrequest_batch_xml (Create a batch-request only using the Communication-object (): <no details avaliable>

tests.test_genrequest.TestGenrequest.test_genrequest_check_response_batch_xml (Create a batch-request only using the Communication-object): <no details avaliable>

```


The m_pageControl, m_svrCtrls, and m_returnedCtrls are not member variables.


Ok I understand the issue, each iteration of the loop adds to the existing log, will fix :neutral_face:


> И вместо flex: 1 1 auto; писать flex: auto;

Нее. `flex: auto;` == `flex: 0 1 auto;`. Тут можно сократить до `flex: 1;`.


Size check of queue should be handled in queue isself.


Do you need to free the m_pCookie after this call?


TeamCity Zimbra-Community :: python-zimbra :: Test Py2.7 [Build 19](http://ci.blueocean-net.de/viewLog.html?buildId=38&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy27) is now running


Also, i don't know if it's useful or not, for OneDrive, there is a possibility to disable it's usage in the group policies, so it can prevent storing files in OneDrive in future if somebody accidentally installed OneDrive back. The path is: WIN+R > gpedit.msc > Computer Configuration > Administrative Templates > Windows Components > OneDrive
![2015_09_08_16_50_42_prevent_the_usage_of_onedrive_for_file_storage](https://cloud.githubusercontent.com/assets/14163350/9735160/6f7ce47e-5641-11e5-9c9d-a20bf047bbd8.png)


It reproduces every time when you use changeLogParameters in your Activity
Without changeLogParameters property everything is ok


TeamCity Zimbra-Community :: python-zimbra :: Test Py2.7 [Build 19](http://ci.blueocean-net.de/viewLog.html?buildId=38&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy27) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 62 Build time: 00:00:40
### Failed tests
```
tests.test_genrequest.TestGenrequest.test_genrequest_batch_invalid_xml (Create a batchrequest only using the Communication-object,): <no details avaliable>

tests.test_genrequest.TestGenrequest.test_genrequest_batch_xml (Create a batch-request only using the Communication-object (): <no details avaliable>

tests.test_genrequest.TestGenrequest.test_genrequest_check_response_batch_xml (Create a batch-request only using the Communication-object): <no details avaliable>

```


Нет же, https://drafts.csswg.org/css-flexbox-1/#flex-common


good catch!  will pull


>  `flex: 1 0 auto;`

Можно сократить до `flex: 1 0;`.


I am not using any feature provided by those classes. If you have noticed this is kind of custom implementation to handle file uploads.


Is there a way to return some information about exception?


Error handling should be there for indexoutofbound exceptions.


It surprises me that this assertion passes, as the first call to Stream.readAsync should not be guaranteed to be done from a thread that's in an event loop.


Ah, it's this compare function. I was confused.

You are right, but it's also no problem, the alphabetical sorting for the PM dialog is somewhere done elsewhere. I explicitly added a comment at the g_list_sort() call that you linked, that should answer your question.

But your sorting looks better indeed. Except that the indirection cound is already available in p->proxied_count and doesn't have to be computed.


I dont want break out from loop when function couldnt find public posts


Im not a Makefile expert, but I tested this and it is working fine. And it looks correct to me.


Hello all together

This commit does somehow brick my device, it is not able to boot any more after applying this patch.
I did make sure I updated spm_devices.c and lpm_levels.c.
If someone knows what I could do or if this is device specific etc, I would be really glad for some help. Thank you! :+1:


For some crazy reason, I didn't get the notification about your comment :-( Sorry, pull request is coming... :-)


liquibase {
activities {
        main {
            changeLogFile changeLogFile
            url dbUrl
            username dbUsername
            password dbPassword
            changeLogParameters('some' : someParameter)
        }
    }
        runList 'main'
}


<template is="dom-if" if="{{isSingleChallenge}}">
     <p>{{challenges[0].Name}}</p>
</template>
<template is="dom-if" if="{{!isSingleChallenge}}">
    <select items="{{challenges}}" on-change="_setChallenge">
        <option value="{{item.Key}}">{{item.Name}}</option>
    </select>
</template>


instead of doing this you can have a

```html
<template is="dom-if" if="{{isSingleChallenge}}">
     <p>{{challenges[0].Name}}</p>
</template>
<template is="dom-if" if="{{!isSingleChallenge}}">
    <select items="{{challenges}}" on-change="_setChallenge">
        <option value="{{item.Key}}">{{item.Name}}</option>
    </select>
</template>

```


Looks like this commit broke build.
Please see http://ci.cgeo.org/job/c-geo/4025/console to remedy the problem.


This logic is all handled in `NettyStream` - it makes sure only talk to the `ReadTimeoutHandler` in the eventloop. See: https://github.com/rozza/mongo-java-driver/blob/j1934/driver-core/src/main/com/mongodb/connection/netty/NettyStream.java#L356


replace `candidate.Removed === undefined` with `(candidate.Removed === undefined || candidate.Removed === false)`


@piotrpalek @vanthome How about this approach? https://github.com/ember-vcl/meta-list/tree/test same principle, based on mutable metaObject, no entire list re-renders. Will it be harder to maintain/extend?

Notes: https://github.com/ember-vcl/meta-list/blob/test/main.js#L35 metaKey needs to be passed to _metaObserver (selected is hard-coded at the moment). Probably, observers needs to be tracked/removed whenever new metaObject is set or component is destroyed


**valid-jsdoc**: Missing JSDoc @returns for function.


**Eslint**: 'return' outside of function


Hi @FrozenSouL


On lines 2946, 2956 I seem to have changes not done by me. Possible merging issue?


While you are consistent with your naming which is good it is conventional to use "snake-case" i.e. dash hyphenated names.


answered in IRC but for other poor souls coming across this:  i wanted to put as much content as possible under user control.  some images put config/etc off /opt/app-root.


What is the reason for making this a weak reference?

Why would you make it possible for the page to not be fully able to iterate through its elements? If you want to make sure the underlying iterator isn't "leaked", I'd set the `wrapped` to null once it's been iterated through and/or make Page `Autocloseable` with the `close()` nulling the wrapped reference is a better solution.


@did is there a new best way to do this? I'm thinking about adding a middleware that merges my custom drops into `env['steam.liquid_assigns']`. Does that sound right to you?


Just curious why use a `h6`?  Have you already gone 5 levels deep in heading hierarchy?


> What compiler checks are you refering to?

`printf()` format (`-Wformat-nonliteral`/`-Wformat`).

> Your suggestion has a flaw: "\nOther plugins depend on this. Disable them first to allow deactivation.\n" would be displayed without markup (instead , would be printed verbatim. That's the reason for complicating like I've done.

Darn it, of course you're right.

Tho, yours is dangerous if one of the plugin name, description or details contain a `%`. (hence how nice GCC is to be able to check that :))

Hum… an acceptable solution might be to simply always have the markup and just leave it empty if not needed, if it doesn't introduce UI glitches:
```c
g_markup_printf_escaped("<b>%s</b>\n%s\n<i>%s</i><small><i>\n%s</i></small>",
            p->info.name, p->info.description,
            can_uncheck ? _("\nOther plugins depend on this. Disable them first to allow deactivation.\n") : "",
            details);
```
Otherwise, it'll have to be split in 3 (prefix, uncheck str and suffix), and concatenated afterward.  A bit annoying but it works
```c
gchar *prefix = g_markup_printf_escaped("%s\n%s\n", p->info.name, p->info.description);
const gchar *uncheck_str = can_uncheck ? _("\nOther plugins depend on this. Disable them first to allow deactivation.\n") : "";
gchar *suffix = g_markup_printf_escaped("\n%s", details);
gchar *markup = g_strconcat(prefix, uncheck_str, suffix, NULL);
g_free(prefix);
g_free(suffix);


> https://drafts.csswg.org/css-flexbox-1/#flex-common
> >Editor’s Draft

На черновички лучше не ссылаться. Там может быть много отсебятины. Но ты таки прав.


Int enums start at `0`, so leaving that out makes it easier to re-arrange the sections, if we do so again.


-1 for the `WeakReference` for the same reasons as above in the `Page` class.


Var bare endring i line-indenting....


you don't have to change this now, but can take advantage of the enum to get the section count.


-1, again.


Reviewed


Weekend push without proper oversight.  This is for [#2863].


With respect to the `href` if you don't have a valid location to link to just use `#` it will book mark to the document itself and prevent the validator from raising an error.


okay..., but a class isn't needed since this function isn't used outside of swift.


Any development on this?


This can be just a `Runnable`. No need to create a whole new thread object.


@dmo-odoo : Not reviewed by @apr-odoo, and not a good idea according to @qdp-odoo,

I reverted it at 2fe11b18b50d68fe9c1a1ed44ecee4eccb903bce


Урааа ;)


Yes!


This was from the M preview.  I have reverted and squashed.


Thanks for review Enrique, was just gonna ask somebody :).

It's because we want to set datasource JNDI name dynamically. We want that so that we can run two application instances on a single server using different DS (testing and production instance).

Other ways to achieve that could be deployment overlay, or running the testing instance on separate AS.

When I think about it, I start to like deployment overlay more. Do you have any opinion on that?


Do you know btw if downgrading drive is going to hurt the app's data/settings?


Done


Oh, wow: https://github.com/chilts/mongodb-queue/issues/6

Are you going to push an update to npmjs soon?


@tomsmeding you still work on this? D:


In general though I disagree with Effective C++ here on the "must initialize all members explicitly". I find it clogs the code up too much with unnecessary verbiage. I personally believe it's totally fine to rely on the no-args constructor of complex types (e.g. unique_ptr<>) to initialize themselves into a consistent state.


I think this would be clearer as:
`$this->readUserVars(array('blockContent', 'privateBlock'));`


Yeah, so then there is possible to write inicialization in class
declaration. I can rewrite it.

On 09/08/2015 03:06 PM, Matt Godbolt wrote:
> In general though I disagree with Effective C++ here on the "must
> initialize all members explicitly". I find it clogs the code up too
> much with unnecessary verbiage. I personally believe it's totally
> fine to rely on the no-args constructor of complex types (e.g.
> unique_ptr<>) to initialize themselves into a consistent state.
>
> — Reply to this email directly or view it on GitHub
> <https://github.com/Shin-nn/seasocks/commit/f1185a722b3bbbc4539af1e1e5502a5023f1a07f#commitcomment-13111545>.
>


Why create a method for that ? There's only one line the method.


Ha - ha!


Looks nice, and works with no rendering :+1:
I hoped ember would figure this out itself (through the key property) but it seems it doesn't work automagically.


But there's no need to initialize them at all: that's what the no-args constructor is for. The change you made is fine; but I'm now looking through the remaining warnings and almost all are ones that can't be avoided (the JsonnedString deriving from std::string), or else they're initialization of no-args constructor'd objects.


Paulo, realmente agora ví!
Me desculpe...
Nunca usei o GitHub, não entendo muito !
Aliás, gostaria de uma ajuda se possível. Como posso falar contigo ?

Obrigado


But you are true... Nevertheless I consider the other check of -Weffc++ positive (I am too lazy to add all it's extension it start on my own)


You should move the declaration of this enum to the end.


That can never happen can it? You're already checking above if the type is correct


what about http urls?


Agreed completely. I'm a little disappointed I can't remove the
member-initializer test without losing the others; it seems GCC has lumped
all these useful checks together and placed them in one option only.

On Tue, Sep 8, 2015 at 8:10 AM, Tomáš Černík <notifications@github.com>
wrote:

> But you are true... Nevertheless I consider the other check of -Weffc++
> positive (I am too lazy to add all it's extension it start on my own)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Shin-nn/seasocks/commit/f1185a722b3bbbc4539af1e1e5502a5023f1a07f#commitcomment-13111615>
> .
>

--
Matt


Hum, actually your comparison function will probably do (mostly) the same, as the least deep plugin will hit `&builtin_so_proxy_` first and be sorted before.  I was just confused by the logic, but it indeed should work.  Sorry.

Only thing is that the as is comparing two toplevel plugins will be unstable (e.g. `cmp(a, b) == cmp(b, a) == -1`), which might (or might not) confuse the sort algorithm.  But it's easy to fix, just move the `if (pa->proxy == pb->proxy)` before the other checks so 2 toplevels also return `0`.

> But your sorting looks better indeed. Except that the indirection cound is already available in p->proxied_count and doesn't have to be computed.

It's inverted (highest count means lowest level), but indeed.  So it's even only a matter of comparing 2 integers :)


I am going to implement a dummy enum class when the import fails. I need some time to work on this.


TeamCity Zimbra-Community :: python-zimbra :: Test Py3.2 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=40&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy32) is now running


Style: When using Ruby 2.0-style hashes like this, where the value is a symbol, I find it slightly easier to read if you fall back to old-style hashes (`:with => :exception`)

Not worth stopping your pull request though, this is more for future reference


`$isUserLoggedIn` includes *readers*, which the [original request](http://forum.pkp.sfu.ca/t/custom-block-plugin-for-registered-logged-in-users-only) excluded, I believe.  To take this all the way, you might make `$privateBlockOption` a user-selectable bitmask of the roles:
https://github.com/pkp/ojs/blob/ojs-stable-2_4_6/classes/security/Role.inc.php#L17


TeamCity Zimbra-Community :: python-zimbra :: Test Py3.2 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=40&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy32) outcome was **SUCCESS**
Summary: Tests passed: 65 Build time: 00:00:38


TeamCity Zimbra-Community :: python-zimbra :: Test Py3.3.6 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=42&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy336) is now running


fast-forwarding develop to borshop-integration-19-gg/timeseries = 6511cbd4


I think that using |ListenUSBFunction=|, as you suggested, would be a
good solution. Shortening it to |ListenUSB| could lead to
misunderstandings in the future, as these files are specific for FunctionFS.
And I will definitely remove the abbreviations.

On 09/08/2015 01:19 PM, Lennart Poettering wrote:
> What does the "FS" in "FunctionFS" stand for? "File system"? If so, that
> sounds like an implementation detail of the Linux USB stack, and should
> not be exposed in the settings, name. Maybe |ListenUSBFunction=| (or
> even |ListenUSB=|) would be a better name?
>
> Also, I don't like the abbreviations in |ListenUSBFFSEndpoint=|. First
> of all "FFS" is again is suboptimal, since I think the "fs" part is a
> Linux-specific implementation detail. I also don't like that we
> abbreviate things as "FFS" where the earlier option used the
> non-abbreviated name "FunctionFS". We should stick to one spelling, not
> a mixture of sometimes abbreivated and sometimes not. Also, we should
> generally be careful with abbreviations unless they are very common
> knowledge. The abbreviation "USB" is pretty commonly understood. But
> "FFS" is one I have not heard before. In fact, I think apperviating
> "Endpoint" to "EP" would be more common than abbreviating "FunctionFS"
> to "FFS"...
>
> Long story short: I think these should be called |ListenUSBFunction=|
> and |ListenUSBFuntionEndpoint=| (or even |ListenUSB=| and
> |ListenUSBEndpoint=|.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pszewczyk/systemd/commit/69676422bb4cb93143d4eceb5b928cedb595e5c0#commitcomment-13109630>.
>


Great, I was just wondering if it had been forgotten.
So the interface will stay the same, good to know.


I like it but, no thanks


TeamCity Zimbra-Community :: python-zimbra :: Test Py3.3.6 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=42&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy336) outcome was **SUCCESS**
Summary: Tests passed: 65 Build time: 00:00:52


TeamCity Zimbra-Community :: python-zimbra :: Test Py3.4.3 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=44&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy343) is now running


direct push ?


Hello Rajeev,

This is already into Arastta so there is no need to make any change.

Regards


TeamCity Zimbra-Community :: python-zimbra :: Test Py3.4.3 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=44&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy343) outcome was **SUCCESS**
Summary: Tests passed: 65 Build time: 00:01:22


TeamCity Zimbra-Community :: python-zimbra :: Test Pypy2.6.1 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=46&buildTypeId=ZimbraCommunity_PythonZimbra_TestPypy261) is now running


Did not forget :) We had a 3 day "weekend" this week because of labor day. I am just coming back to work.


TeamCity Zimbra-Community :: python-zimbra :: Test Pypy2.6.1 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=46&buildTypeId=ZimbraCommunity_PythonZimbra_TestPypy261) outcome was **SUCCESS**
Summary: Tests passed: 65 Build time: 00:00:38


TeamCity Zimbra-Community :: python-zimbra :: Test Pypy3-2.4.0 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=48&buildTypeId=ZimbraCommunity_PythonZimbra_TestPypy3240) is now running


It only happens on OSX with clang. It's fine on windows and linux with gcc and mingw.


And only for the long tag


if that is the case we do need the return?


PRs welcome.  And maybe a flake8 extension.


I do not think this message is necessary.


I did forget about that :).


TeamCity Zimbra-Community :: python-zimbra :: Test Pypy3-2.4.0 [Build 1](http://ci.blueocean-net.de/viewLog.html?buildId=48&buildTypeId=ZimbraCommunity_PythonZimbra_TestPypy3240) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 64 Build time: 00:01:23
### Failed tests
```
tests.test_admin.TestAdmin.test_admin_xml (Creates a new account, authenticates as this account and deletes): <no details avaliable>

```


Sure, this is optional and can be removed if desired.


Angular is spelled wrong :cry:


Not sure why either. Other users are reporting it takes 5 for them too...also with the latest kernel commits I have the panel issue again...maybe it's fast charge or something... :|


It doesn't matter if it's stable sort or not (it wasn't sorted at all before this patch). Is the comment not clear enough?


It could be caused by converting the library to a shared one


Can you remove this please ?


https://github.com/marinmitev/smarthome/issues/35 - unit tests for RuleEngine class


yeah it's clear enough when you read the whole sentence.

Maybe something like this?
*Plugins available through such a proxy are also called sub-plugins or inferiors, in reference to the intermediate layer between them and Geany.  They however are first-class citizen to Geany, just like native plugins.*

But it's probably already good enough, I just had a weird impression reading it at first, probably because I was reviewing so tried to put a little too much meaning behind each word :)


nit: I would rename this (along with `adminLog`) to uppercase as it is a common naming convention for constants


Shouldn't this be:
```
#ifdef HAVE_TC_API
#include "pcap-tc.h"
#endif
```


@alexandre Você tentou adicionar o tipo do arquivo no "browser.helperApps.neverAsk.saveToDisk"?
Aqui parece que foi fazendo isso. Em outras palavras, modificando [essa linha](https://github.com/okfn-brasil/esiclivre/blob/add-pedidos-preprocessor/esiclivre/browser.py#L90) para:

    tipos = "text/csv,audio/wav,audio/x-wav,image/jpeg,application/octet-stream"


nit: you don't need for else branch since you have `return` inside of `if` statement


Só complementar: isso usando o Selenium, não requests.


Line 324 - trailing spaces.


Instead of modifying MTM with an boolean that essentially disables everything that MTM does (which is what this does as far as I can tell), why not simply configure a SSLContext that does trust all certificates? Smack even provides https://www.igniterealtime.org/builds/smack/docs/latest/javadoc/org/jivesoftware/smack/util/TLSUtils.html#acceptAllCertificates(B) for this.


如果没有空行，就像latex一样成一段了


It's a bit confusing to say that we're trying to predict the *number* of Republican votes (an aggregate quantity) from *one's income level* (a quantity pertaining to an individual).


126 - trailing spaces.


I have some trouble finding proper place to do this. We need to get rid of these temporarily created socket ports when stopping socket, but when exactly it should be done?


기범이와 짝코딩, 2시간


FWIW - this is exactly what I tried, and worked just fine with one of my yubikeys but not the other (hence why I'm pretty sure that one has a hardware issue; they are the same version & firmware)


It ended up being committed later - you can view it on master


it is, but apparently I ain't :)
I'm not worried about the final ordering, just a little about how the sort algorithm will cope with conflicting sorting order; but that's probably silly and all sort algorithm will do just fine.


效果图：
![selection_001](https://cloud.githubusercontent.com/assets/3974108/9735831/220adac8-5670-11e5-953d-eada210f8c7d.png)


##Hello

This is a `test`.

You can write with Latex math symbol like
$x^3=9$

You need write the markdown,[here]
(http://daringfireball.net/projects/markdown/) is  the markdown syntax document.
And you can also write code here.

~~~~{python}
print 'hello world!'
~~~~

Enjoy it !


comment: this line is crap


可以到我这里看效果：https://github.com/seisman/SAC_FORTRAN_interface/tree/readme-patch


I think this is not a good change.
This leads to many forbidden routes.
If OSM data is wrong, it should be corrected, but we should not ignore access/vehicle=agricultural/forestry for bicycle routing.
I really don't think it would be good to be forced to add bicycle=agricultural/forestry to OSM data if there is already access/vehicle=agricultural/forestry.
In fact we had a clean-up campaign, where many users removed redundant access tags, because it is senseless to have combinations like this, just to make sure that every "special" routing/rendering engine gets it right:
access=agricultural
vehicle=agricultural
motor_vehicle=agricultural
motorcar=agricultural
motorcycle=agricultural
bicycle=agricultural
foot=agricultural
horse=agricultural

access=agricultural includes them all.
To simplify this we have the access hierarchy in OSM.

The goal is to have correct OSM data, not to tag for a special router or renderer.
One of the important instruments to make people aware that the data is wrong (so that it can be fixed), is to strictly follow the access rules.

Also the rendering on osm.org is getting stricter to make people aware of mapping mistakes, so that the quality of OSM data improves.


not sure, I can try a twrp/tibu backup then install and downgrade (with safety net).


The same as with tfw_connection_send - double variable check on main path.


JSHint 5:5 'Property' is defined but never used.


Got it. Fixed!


Mmmmmkay.  I don't like proactive changes like this, but well, it's not really a problem.


Do you need ats installed before you copy these files over, or is it the other way around?

By the way, I think you could have probably just appended these files to the template_files above.


Hmm, I am not sure about using this setting from options, this basically allows anyone who adds video to track it with own analytics account, is that correct?


m_pCookie is set each time you make this call, and used in subsequent calls to ldap_create_page_control which occurs the next time you call this method. Therefore its value needs to persist until the next call to this method or until the paged control object is destroyed


oops, nevermind, I already have it upgraded.


Hi @ozomer , I've forked and updated this one for tests only, but you can use my version to be sure it works with the latest mongodb npm, however how do you manage the "server" side, did you build some simple server to get queue and execute it?


Mmm… let's say maybe.

BTW, on Windows are we sure we'll see a `G_DIR_SEPARATOR` in it, as both `/` and `\` can be separators?


I thought preparatory commits are generally considered good practice.


This certainly doesn't happen on my Fedora system. What's the OS and python version?


s/Megparsec/Megaparsec/


OK


cat /etc/redhat-release

Red Hat Enterprise Linux Server release 6.6 (Santiago)


向大牛cw致敬！保重！


Yes, but IMO they need to make sense by themselves, and in the context of this commit e.g. adding the prototype doesn't look like it makes sense.

Anyway, it's not a big deal.


Thanks, what you proposed is far more elegant than my current solution. This will also spare some other problems, e.g. second socket type for endpoints other than ep0 won't be necessary.


Your correct, i forgot to add them to git, will fix it now


I just saw another PR from @ldoktor that has a similar patch. Apparently some versions of `distutils` don't import the `dir_util` name. I'll decide on which PR I'm going to merge to fix this.


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


> I don't even know how you test font-lock :P

Just take a look at the existing tests. They are pretty simple.


I don't think these patch specifications rendered how you wanted them. Asterisks italicize text in Markdown. Try escaping the patch identifier, like `SR*3*177`.


> But, just to be clear, this PR does not highlight the code in doc buffers.

It'd definitely be nice to have this in doc buffers, though.


I would make it clear that what you're referring to as a coefficient is the mean (because you could also use the median, or any other point estimate). Also 95% is a common interval to use, but it's just as valid to pick any other interval. We don't want them to think that 95% is the **right** answer in any sense, just that it can be a useful summary.

Also, the **empirical** estimates are what they are. Once we've observed them there's no uncertainty about what they are. It's the underlying **true** (so to speak) effects that have a 95% probability of being in the interval given the model, data, assumptions, etc.


@iriberri , Is this stale branch still applicable?  I know it says it was created to fix a typo but this question does not even appear under FAQs anymore. Please advise.


Feel free to use own copyright on new files, as per https://docs.moodle.org/dev/Coding_style#.40copyright


TeamCity Zimbra-Community :: python-zimbra :: Test Py2.7 [Build 20](http://ci.blueocean-net.de/viewLog.html?buildId=50&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy27) is now running


"made need to be made", I assume you meant "may need to be made"


#4
#10


Missing space.


@gentilkiwi Where did you get these values from? I'm doing an enumeration but some of the TrustTypes are blank...


As it is, this means we'll install ats every time we apply the Salt config in this machine.  To prevent that, we could add an `- unless:` clause to this state.  Is there a reliable way to tell whether the install was successful?  What about adding `set -e` at the beginning of the script and adding something like `touch /home/lantern/ats_installed` at the end?  Then we could add `- unless: "[ -e /home/lantern/ats_installed ]"`.

Anyway, it's probably OK to have it like this as a first shot.  We can refine this later.


TeamCity Zimbra-Community :: python-zimbra :: Test Py2.7 [Build 20](http://ci.blueocean-net.de/viewLog.html?buildId=50&buildTypeId=ZimbraCommunity_PythonZimbra_TestPy27) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 62 Build time: 00:00:46
### Failed tests
```
tests.test_genrequest.TestGenrequest.test_genrequest_batch_invalid_xml (Create a batchrequest only using the Communication-object,): <no details avaliable>

tests.test_genrequest.TestGenrequest.test_genrequest_batch_xml (Create a batch-request only using the Communication-object (): <no details avaliable>

tests.test_genrequest.TestGenrequest.test_genrequest_check_response_batch_xml (Create a batch-request only using the Communication-object): <no details avaliable>

```


Thanks for you help. I'm fixing this.


Trailing spaces lines 34,38,41


Maybe we can use a protocol which is used for netlink messages? We have the library for Go and it's very easy to parse it from C.


So the installer installs some init script to make this a service, right?


Well, then this test will fail for me. =/


Hi, the easy-rsa 3.0.0 is added to aports(testing repo).
I think it might be useful to you.

http://git.alpinelinux.org/cgit/aports/commit/?id=6ed61c49c3b95465de786e73ade9c75a97c2877c


Thanks! Fixed!


I don't understand what you mean by "server" side. I just need a simple queue to push and pop messages. I am using the update mongodb npm package.


I would also feel free to submit a PR to @fffw's branch for those changes
@aranhoide
On Sep 8, 2015 6:36 AM, "aranhoide" <notifications@github.com> wrote:

> As it is, this means we'll install ats every time we apply the Salt config
> in this machine. To prevent that, we could add an - unless: clause to
> this state. Is there a reliable way to tell whether the install was
> successful? What about adding set -e at the beginning of the script and
> adding something like touch /home/lantern/ats_installed at the end? Then
> we could add - unless: "[ -e /home/lantern/ats_installed ]".
>
> Anyway, it's probably OK to have it like this as a first shot. We can
> refine this later.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/getlantern/lantern_aws/commit/238478da065e7fc166262191aff1c0236d89aa41#commitcomment-13112206>
> .
>


Missing docblock for class. https://docs.moodle.org/dev/Coding_style#Classes_3


I really like this list of things that must be done for a VA release, but to meet the intent of this document, I think we should also include some tips on how to actually add/modify features in the patch. For example, in the Java section, we described the directory structure so that future developers would know where to find the files they need to modify. (I'm not sure what would be useful to a future VistA developer.)


IMO, this even should only be triggered when the selection actually updates and not when it is simply clicked, otherwise it's misleading.


Maybe "because we've set it up to use the lowest level as the reference category for comparisons"


These files do not exist yet. This would not be necessary if additional descriptors were stored in separate list, as you proposed below.


I suggest `corr` or `correlation`. The name `corref` is confusable with coreference.


there is no such package anymore


Won't one of these buffcalculates fail whenever you don't have both types of buff? In other words, does buffcalculate return 0 when the buff doesn't exist?


Linear on the logit scale


Actually, an empty "templateprovider" and hidden input is added by [create.js](https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/src/main/webapp/resources/js/xwiki/create.js) when the form is submitted.
I see no reason to add it in the velocity template too.


it's not valid for ajax validate


https://github.com/keghani/libphonenumber/commit/ce44538b97a0de5e89c88540042a1687ecf1ec53 is better, see that.


Done


@owenbarritt, thanks for commit. There are many style issues, I have commented on some of them, but there are some more, have a look at if/else statements in eventlogger.php for instance. Please fix them all and I will give it another go.


I used the same approach. Wouldn't this be more of a O(n*m)? where n = number of cyphertexts, and m = length of each cyphertext / 16. I convinced myself this was not (un)acceptable conditions :lemon:


https://github.com/keghani/libphonenumber/commit/cb93ef78a32b91f1f983f824407a7dc9fb3ccb4d is cleaner, see that.


`eutils` seems unused


https://github.com/keghani/libphonenumber/commit/ce44538b97a0de5e89c88540042a1687ecf1ec53 is cleaner, see that.


Lol - i missread your commit message like "Fixed memory leaks that nobody cared" ... i don't care for the results of course ...


If you make `install-ats` depend on `ats-files` as I suggest above, then you need to change this to `- cmd: install-ats`.

If you don't need those files in order to install ats, I suggest making this depend on having ats installed, *in addition* to depending on the files.


Thanks!

Linking the commit: https://github.com/ivaldi/brimir/commit/fc688cc54bc29e28bbbd618537030c893aaf195a#diff-b154b050a7eec4d400f15c1c4a689468R42.


I'm not sure I understand this `panic`. Shouldn't this just `return false`?


This code will run during _configuration_ phase. But a user could create a task that creates `config/checkstyle/checkstyle.xml` during _execution_ phase, in which case we'd ignore it. This would be wrong.

Instead, you need to use a convention mapping or similar mechanism to defer this check until the Checkstyle task is executed, rather than doing it eagerly at configuration time.


Also, it seems that this event is being triggered twice, for some reason (did not look deeper in the select widget`s code). I`ve noticed this on the create UI.


https://github.com/keghani/libphonenumber/commit/417343cc16bb3208c91e34b2ece8c2ac730250b2 is better, see that


using a method because its name allows to express the intent


o.O weird
something must be broken


Here afaict those ldap props/settings came from config-security/config-security.properties in a standard gn3 install (and database configuration from config-db/jdbc.properties)


LGTM


Hm, yeah, definitely I think `install-ats` should require `- cmd: ats-files`, rather than the other way around.  (Sorry for the repetition; I'll edit some of the comments above once I'm done reviewing.)


Massa essa linha


Couldn't this `let` and `for` be something like `let state_i = todo.drain().take(1)`?


Kill the commented line.


@Parbhat can't we make this more generic if we did not call the modal content class `person_modal_more`. I'm thinking is that this could work on events.
After all your put it in `base.html`.


"allow" means "enable", doesn't it?

setgroups should be disabled only if a container is started by an underprivileged user.


So ``by overrides`` doesn't quite make sense in context here.

The table reads:

- total updates ``<N>``
- by status
  - X
  - Y
  - Z
- by type
  - X
  - Y
  - Z

So, the "by <whatever>" text implies that you're referring to updates.

How about doing something like this:

- total overrides:  ``<N>``
  - active ``<M>``
  - expired ``<O>``


Hello,

Can you describe me how to I integrate Zenpayroll in my application.

and how to I create client_Id and secret_key at zenpayroll.


I think it isn't cold at all!


Could you explain this hunk?


Should be `assert_eq!`.


I agree, huge problem.


I like the changes.

In addition to a few things I pointed out in the line comments there are a bunch of small grammatical things that you'll probably catch if you read it out loud. If you take care of those and the formatting issues that you mentioned then I'll take another look before you send it. There are probably some other things I'll catch when I read it again.


Probably a getter method will be better.

PD: PHPUnit has the method `assertAttributeEquals`


No that would require them to add the google analytics JS code to the page, which the average user can't do (none of the account stuff is set in the filter settings, it's all done at page level - the filter settings just control what data JWPlayer passes to the google analytics JS api).

The ga.idstring and ga.label options just control what strings JWPlayer passes to google analytics to record (either file, mediaid or title - see http://support.jwplayer.com/customer/portal/articles/1417179-integration-with-google-analytics )


Ah, I kinda see why not. Then it might as well be an `assert`, because if this ever triggers, there must have been an internal cockup somewhere previously.


Ah, ok, will update that shortly.


commite?>


Let's delete all the commented stuff.


what the fuck, commy?


Je reviens a la charge désolé :)
 mais "quelque chose" est bien masculin du coup ne devrions nous pas dire "fatal" ? "quelque chose de fatal" et pas "quelque chose de fatale"

https://fr.wiktionary.org/wiki/quelque_chose :3


*KVIrc and `to download`


1: M111 unrecognized component name: travis


Ah, I see. Thanks for clarifying this.


*off the press


@chrisdev yes we can name it anything, while building I was just focusing on person. This can work on any page, we just have to choose class name and add a click event in jquery.


you must really like every colour!


They are more related to service than socket. Descriptors and strings contain configuration of a function, which will be created and handled by service.


Please comment that `depth` is scalar, `bin_queries` pertaining to a single query but through different hash functions /  trees...


I wonder if the `!=` might be better as `||`? They're semantically equivalent, but I think `||` might make the intent a little clearer (in a sense this line is a guard that ensure that the later `unwrap`s are safe).


`"javaut"` as a language? Is this correct?


You need to wait while the parent process sets uid_map and gid_map


I *think* (but might be wrong) that you can just say `if item_la != other_la { return false;} ` instead of manually writing out the `for` loop.


Hmm. In that case I'm not certain what the best solution is. This is probably something that should be discussed on the [gradle developers list](https://groups.google.com/forum/#!forum/gradle-dev). Basically, we need to answer the question of:
1. Is it a good idea for Gradle to provide a default set of checks for checkstyle
2. Should we use checks provided by the Checkstyle jar, or should Gradle define it's own.
3. What should we do if the Checkstyle jar doesn't provide any default.
4. Should we provide a way to use standard conventions like 'google', 'oracle', etc


TIL :+1:


so now it is good also on the faces ?


yes


What are you trying to do here?
It looks like you are waiting 5 seconds, then forcing a topology change. Why?


Ah, I might be wrong, since I think you're only comparing that the same dotted item exists?


this indentation seems wrong


What are you trying to protect here?
Note that this is synchronized on the instance level, so calling this concurrently with AddToTopology (safe) would be allowed.


Is this automatically transactional? We shouldn't confirm the user and then throw an error.


`j` isn't used later, so this doesn't need to be an `enumerate`, I think.


Nice, I didn't know about this `creates` thing!  Yeah, this is a nice shortcut to the `[ -e ... ]` trick I suggested before.


tralala


Doesn't that also compare the lookahead values? They don't have to be equal. I only want to check if they have lookahead values, I don't want to compare the values.


tian's test


But `"javaut"`is not a language. `"java"` is. Why do we use this value here?


@eliotsykes I'd like to go over this.


Yeah, the `\` were my last resort after trying a few different ways to arrange the expression for pep8. They ended up being the cleanest and easiest to read for me. (I tend to :cry: as much about expressions wrapped `(` `)` to stretch across lines.)


No, that's not right. Say we've got a prefix index corresponding to the first 3 bits. Then when `depth = 1`, if start was `_prefix_index[0]`, stop would be `_prefix_index[4]`. For `depth=2`, they would be 2 apart, not 4.


You could just use `creates` here too?


Uhhh...isn't this supposed to use tabs? Or is GitHub's Android website just showing them as spaces for some reason?


Please add a javadoc link to `addEventListener` here, too. :)


Instead of method 'getList' or something like that, I thing that it is more convenient to implement iterator.


Yes. An assert is fine I guess. I just wanted to put this sanity check in to see if it fires on the python grammar to make sure the weakly algorithm works as intended.


Yes, you're right -- and I'm wrong!


@eliotsykes how is this file generated?


Yeah, forgot about this.


thanks for clarifying. please submit to mainline.


You don't need to `require` it if you already `watch` it.


Can I still add stuff do the todo list within the loop when using drain? I thought drain blocks todo mutably.


OMG, I just noticed that this is wrong, it should be:

return new ArrayIterator($this->backups); :( will fix it, sorry ...


if i remember correctly this is because setsid only makes sense when we requires a consolefd. Setting TIOCSCTTY without setsid will fail with EPERM.


OK


+1 for removing the Mutable* / experimental classes (= deprecating them in v1.1 and removing in v2.0).


Ok. I thought it might be worth while to keep it to know what's going on or to later test things without weakly (in case we find a bug somewhere). But I'm find with removing it as well.


Notice the `drain` is followed by `take` so the drain only lasts for that line.


A lot of logic is same for all destinations, so it is more convenient to have a prototype class in order not to have copy/paste code.


Hello Guys, If I want  to build something with this open source, how can I compiler this package?
there are no the third party libraries but which are request in the android.mk.
like:
LOCAL_JAVA_LIBRARIES := javax.obex telephony-common mms-common

and others


Ah sorry, I thought the drain was in the while condition. My bad.


That's what we have a revision history for :) As a good rule of thumb, we should almost never commit commented-out code.


add redux-form


@myleshorton yeah I'll do that if necessary once I'm done reviewing.


Kill commented line.


Why is the `<` transformed into a `!=`?


Right, this should be deny.


setsid() makes sense without condolefd. consolefd doesn't make sense without setsid().


translatable?


We should delete this line before merging (though I wouldn't be averse to adding a `-v` switch to `lrpar` which prints out stats after it's run like e.g. how many states there are).


Put it on your server, mark it as executable (`chmod +x aws-blocker`), and run it as often as you'd like (`./aws-blocker`). I have it in my cron so it runs automatically every day.


see above


Start using Atom commy, no more worries about stuff like this!


Please ignore this one


OK, that's fair enough


I don't see much benefits from it.


Вот это очень несимметрично и выглядит криво, плюсик слишком высоко и близко к краю плеера.
Лучше `margin: 0 -16px 0 4px; vertical-align: 6px;`.

Но вообще предлагаю совсем убрать его оттуда, сделать каким-нибудь квадратиком и поместить в центре между кнопками навигации по ссылкам, а кнопку скрытия/раскрытия списка вынести на правый край в квадратные скобки и как раз сделать минусом/плюсом. Так будет наиболее логично и интуитивно понятно - плюсик не будет означать и уменьшение окна плеера, а кнопки управления плеером и кнопка управления списком будут сгруппированы и разнесены по разным местам.


yes, the test is ok now.
Are you agree with this? it's similar to your previous commit.
But I think the name of the function localDofInElement in DofTable is quite ambiguous with the function localDofInElement in FaceDof (equal to boost::get<3>(...) above).
I am not sure but if I well understood, the first one is a unique id for all component and the other one is a unique id for only one component.


OK


And it doesn't need to be ```sabnzbd.EXTERNAL_IPV6 = False``` ?


In Terminal, run `bundle binstub rspec-core`


Cool I didn't know you could do that kind of syntax. I like that a lot better.


It provides no external way to create an empty NonEmptyMap
So to users of the module, NonEmptyMap is always non-empty.


right. Do you think using a semaphore here is a good choice ?


How do i replace it in my project


che eto takoe?


It should be optional. We can't always deny setgroups().


erwgre


I was trying not to add too much unrelated stuff on the branch - otherwise I'd have set this up too for faster tests. Ideally this would also be installed in the project: https://github.com/jonleighton/spring-commands-rspec


Hmm, yes that's actually a good idea so we dont have to use a home-rolled protocol. Do you have an example of parsing netlink stream from C ?


I'm a bit worried of side effects with this one.


Why are global statics still a thing. It is a huge anti-pattern.


It is not really common use (same instance for prod and test) but I guess it cannot be helped.

Variable substitution functionality provided by jboss as is not going to work either in this particular use case.
You cannot specify variables for the application during deployment AFAIK (that would be cool).
The overlay thing is probably the only way to achive this, but it is something you need to specify during deployment. Not really sure if you can do that automatically.

Makes sense what you did.


Why can't you use the new method here?


nope


Is it H2 or H3? Let's just refer to the element and id directly here as that'll make setting the HTML easier


Hmm I thought that if user want to write to gid_map, we need to write deny to setgroups first ?


Fixed in latest commit :+1: thanks :smile:


What's the id of this part? We should try to be specific


(Optional) ? I think that was the plan. We'll need to get a default one so that there is an option to leave it.  Like the sign up form background