I'm not sure what this commented section is. If it's useful to keep around for debugging, that's fine; just add a comment explaining why it's useful. If not, please delete.


fixed in 480f0ca


PEP8 standards violated.
2 blank lines should be left between class name and first method


Hardcoded. Must have done something else


why?


@kugel- here's a version based on yours that fixes the crasher, doesn't require defining the iterator variable outside of the macro, won't name-clash with 3rd party libraries, and works for GSList, GList, and GQueue:

```c
#define geany_foreach_link(T, link, head) \
  for (T *link__ = (head), *link = NULL, \
          *next__ = (head) ? (head)->next : NULL; \
       (link = link__) != NULL; \
       link__ = next__, next__ = next__ ? next__->next : NULL)

#define geany_foreach_list(link, head) geany_foreach_link(GList, link, head)
#define geany_foreach_slist(link, head) geany_foreach_link(GSList, link, head)
#define geany_foreach_queue(link, queue) geany_foreach_link(GList, link, (queue)->head)
```


Solr 5 version is not working for those examples.Pleas provide advice for executing these examples for New SOLR version.


BUG: Player does not die when Donkey collides with it, only dies when Player collides with Donkey


tratteggiare


Please add a comment saying that this is for biber citations.


PEP8 standards violated.
Found indentation with tabs instead of spaces.


use ignore instead of ban


Unnecessary spaces and white lines used . Readability of code is less


The problem is that Sys_Script takes arguments from user, so passing them directly to system(3) without filtering is not best idea (as it potentially may contain special shell characters like pipe, backticks etc.)


Use comments to make your code more readable!


Proper Comments not provided, difficult to understand the code.


You could write this in a more elegant way by using a vector and than checking the index of `langname` in the vector.


:+1: nice to see a test!!


[anarcat]
> this actually makes the graph overlap here, and i think it will in
> most cases for undamaged batteries, as the recent rentries should have
> ~90% battery capacity still. my rationale in throwing it in the lower
> left was that we care less about the actual battery usage from long
> (bottom left) ago than the current battery health (on the right,
> possibly on top).

Is there a way to make the placement dynamic, to a free space in the
drawing?

But I would like the graph to look good for me with my data set, so I am
reluctant to change the default. :)

--
Happy hacking
Petter Reinholdtsen


Bad Code Smell
>Long Method
>>All other things being equal, a shorter method is easier to read, easier to understand, and easier to troubleshoot. Refactor long methods into smaller methods if you can.


Here's an indentation missing.


On Sun, Sep 27, 2015 at 08:42:12AM -0700, pbrunet wrote:
> @jfalcou Does it is implemented in a later version?

Just to be more accurate : boost::simd::native<...> does not implement
inplace operator when first parameter is a rvalue, and it wreaks havoc
in the type inference.


On Sun, Sep 27, 2015 at 08:37:31AM -0700, pbrunet wrote:
> What was the bug here?
> It looks to be a performance issue (one copy when it is not required), am I right?
> If I am correct, the "problem" is that the reference type may be use in std::functions so incorrect type_traits still have an impact no?

The bug was that iterating over an ndarray returns a raw poiner as
iterator, and taking ::reference from a pointer type is a non-sense.
Turns out that the simplest way to fix this was auto&&


Просто нужно исходники пересохранить в UTF-8. И писать комментарии по-русски


Hmm. I find this surprising. Could you add a comment explaining why this is the right thing to do for biber?


Unexpected Indentation


yeah it may have good "checkers" but we need good granularity here — I mean detailed explanations what went wrong. So not much of a help I guess


I assume there should be a `{` at the end of that string?


I see what you are trying to do, but I am not sure why you use header-header- in some places and header- in others. Is there another patch that moves the icons to a new directory?


Position of donkey king absolute not relative to the layout


bad indentation  : PEP 8 convention violates found 12 spaces but expected 8.


Говнокод.


TeamCity pull requests :: netty [Build 319](https://garage.netty.io/teamcity/viewLog.html?buildId=1779&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 4788, ignored: 16; resource leak detected (new) Build time: 00:10:34
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testQueryMx: <no details avaliable>

io.netty.resolver.dns.DnsNameResolverTest.testResolveAAAA: <no details avaliable>

```


forse specificare, per es. quali tecniche compositive?


Should be easier for the Garbage Collector to pick up on then.


Sometime Coins float in air i.e not on any ground surface


when did the icons get copied into a new directory? didn't see that in any of your patches.


Деструктор по-умолчанию делает то же самое, но не занимает ни одной строчки


Interesting. Does biber not use kpathsea?


Look, this is a very messy file that needs to be cleaned up. We should remove the ranks and add an admin chat tag area in saconfig.


Might as well move the

```
if outbase is None:
    outbase = auxnames[0][:-4]
```

here and simplify the logic in _execute a bit.


Multiple coins get accumulated at same position.
Error in random function


Note that the endianness of the VLT files is backwards compared to this, so a "4578704E" here is actually "4E707845" if you're looking at the files in a hex editor or something.


А такой конструктор точно нужен?


Comments are not adequate!


I'm not sure I understand this change, since it seems to be mostly undoing stuff that was done in the previous commit. Does this also work with biber 1.9? Should this just be squashed in to the previous commit?


If you look up at the read, you'll see it's reading a blank int16, however just a plain 0 here is treated as an int32, hence the need for a cast.


Bad white-spaces at many places. (PEP-8 standards)


In the following lines x and y are unused variables.
Also x and y are excessively short identifiers, hence their functionality is not understandable.


I think there is a missing `}`


Nice, seems to work as intended on Cygwin, Ubuntu and OS X


Import not at the top of the file


Thanks!


Please add "Fixes #18." to the body of the commit message. Also, based on the next two commits, it looks like this adds basic biber support, but not quite everything. It would be good to call this out in the commit message.


line too long


i got it after 3.4.44


I'll keep this in mind when we begin testing the Oanda implementation. I'm not entirely familiar with their API yet, maybe @kaffeebrauer can comment on the choices made here.


Instance of 'movable' has no member 'dj'
Looks like j = self.j + dj intended


it'll show top 10 slowest tests every time or this flag only set the number of slow tests to list?


Duplicated code, since surface, fireball, ladder, ladder2, princess call convert, all of them could be added to a list and then iterated over and call the convert(), hence making the code more readable and understandable.


Why not just call `setEndLine` in parser?


Using variable 'G' before assignment.


can't we move this code to `rails_helper` or `rspec_helper`?


Скорей всего нет. Но мы везде добавили конструкторы по умолчанию. Будем смотреть


Hi Ramesh,
Unfortunately the book has been published and written before Solr5.
Although I think there should be a way to execute those examples, I
wouldn't follow that way. Why do you need that? The examples are there just
to illustrate a concept, regardless the Solr version. You can follow them,
Solr will be downloaded automatically and the container will be started;
again, the focus is on the example, not on Solr.

However if you want to use them with Solr5 you can start a Solr5 that
points to the solr-home folder of a given example.

Best,
Andrea
On 27 Sep 2015 20:31, "Ramesh" <notifications@github.com> wrote:

> Solr 5 version is not working for those examples.Pleas provide advice for
> executing these examples for New SOLR version.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/agazzarini/apache-solr-essentials/commit/8b5afd9a481ee071bdf0152477539966c9c681ce#commitcomment-13458048>
> .
>


Modulation not implemented, good for better understanding of code


I love your work - thanks.
the localvolumeslider does not work - @parabelboi had it removed in the version i used to run.


I saw the commit earlier. (I follow them with everlasting curiosity.) I am happy because I believe it’s better option.

And as for pillar in beta4—they’re black.


Yes!


Seems like a standard practice to separate them whenever possible.  Probably a good thing, in all honesty.  Helps avoid a giant monolithic helper


Also, add a #TODO here, so we can track this easier


Real buggy Game.
Nothing implemented as required


To explain in ActiveRecord::Relation terms, `results.order('duration DESC').limit(10)`


This belongs in the docstring for the initializer


There are unused arguments


```'taggers/averaged_perceptron_tagger/...'```


Player getting four lives.


Follow the Java naming conventions strictly.


please specify types as well, e.g. `list(str)`


Shouldn't this just be a "case" of its own? I.e. `case '--*'`?


Initial fireballs not thrown by the Donkey.


I've found if this returns true, at least for entities, it shows the name above it like you've given it a nametag


Indentation error.


Please put demonstration code in the module docstring, where it can be tested by our CI server.


Javadoc missing from file.
Get it done asap.


Why is this another function?


I'm not sure it needs to be a mark, as this will complicate the implementation... I would be happy with just `testdir.wants('xdist')` or `testdir.requires('xdist')`


Hi.
Is it really necessary to add those @ signs in the commit? Because I get notified every time.


Use new hash sintax.


Excessively small variable names, could have been bigger and more explanatory for better readability and better understanding of the functionality.


Translate and escape:
``````
<td><b><?php echo xlt('Active Issue Codes'); ?>: </b>


Proper Comments not provided, difficult to understand the code.


Maximum length of a line should be 79 characters.
PEP8 standards violated


Code Smell :
Large Class (God Object)


Nop
Une grosse maj arrive bientôt avec Envoûtements et Sorts passif


Duplicated code, the lines of code in the following two for loops could have been method, which explains the functionality, and called be by both the loops.


Be more aggressive on the html escaping:
``````
echo "listBoxOptionSets[" . attr($akey) . "][listBoxOptionSets[" . ($akey) . "].length] = new Option('" . attr($dispCode2) . " (" . attr(trim($codeDesc2)) . ") ' ,'" . attr($dispCode2) . "' , false, false);\n";


I agree with that monolithic files are bad, but creating a 4 LoC file that would be a single line in another file seems a little over for me :P


Be more aggressive on the html escaping:
``````
echo "listBoxOptionSets[" . attr($akey) . "] = new Array();\n";


IMHO `try!` with `map_err` will look better


Modulation not implemented, good for better understanding of code


IMHO this must be in error text


This seems rather complicated. Why not just

```
depth = 0
for i, c in enumerate(string):
    if c == opening:
        depth += 1
    elif c == closing and depth > 0:
        depth -= 1
        if depth == 0:
            return i
return -1
```


Yes fillchaim. It also works with find5 16GB version. Also check the xda thread http://forum.xda-developers.com/showthread.php?t=2608337&page=12.


Super cool feature and tests well. Will plan to commit your next revision (with above minor fixes) to the codebase.
-brady


PEP8 standards violated.
Found indentation with tabs instead of spaces.


code smell: long class


i get that internal server on my wamp setup with 2gb ram
and awesome that is good to know :)


Excessive use of literals, named constants could have been used for better readability.
Also modifying their position would have been easier if named constants were used.


Be more aggressive on the html escaping:
``````
echo "listBoxOptions2[" . attr($akey2) . "] = listBoxOptionSets[" . attr($modeIndexMapping) . "[" . attr($akey2) . "]];\n";


code smell: lazy class


Using completely random number of white space.
Here 3 white spaces are used and at other places 4, 6, 8 white spaces are used
PEP8 standard violated


Oh thanks you. :+1:


Life is not decreasing when gets in contact with a fireball


Био - добавка


But actually it does need requests 2.7.0; because otherwise you get the python error:
```
Traceback (most recent call last):
  File "/usr/bin/cloudprint", line 5, in <module>
    from pkg_resources import load_entry_point
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources.py", line 2829, in <module>
    working_set = WorkingSet._build_master()
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources.py", line 451, in _build_master
    return cls._build_from_requirements(__requires__)
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources.py", line 464, in _build_from_requirements
    dists = ws.resolve(reqs, Environment())
  File "/usr/local/lib/python2.7/dist-packages/pkg_resources.py", line 639, in resolve
    raise DistributionNotFound(req)
pkg_resources.DistributionNotFound: requests>=2.7.0
```

python-requests is just not available in Debian and Ubuntu stable: https://packages.qa.debian.org/r/requests.html


I'll update this patch


nsToSwiftFloatString != swift.TimeToFloatString, nsToSwiftFloatString creates timestamp string like "123456789.123456", but [swift tool](http://docs.openstack.org/developer/swift/overview_large_objects.html) creates "123456789.12"


code smell: cyclomatic complexity


Trying to access protected member __go_lefts of a client class.
PEP8 standard violated


Calculations within JTable means that numbers from first and second column are added end the result appear in third column.


Thanks for the clear explanation.  I see what was confusing me - I forgot that the default attributes handle is the same pointer as the graph pointer.  So your fix makes sense and I think we can include it.


Version 2.9.0 of this library was revoked shortly after being released: https://twitter.com/JSHint/status/639564453852356608

You can expect this fix in the next release, which will be published on npm, documented on the project's website, and announced on Twitter all at the same time.


Super init not called. Improper inheritance


use openrc-run instead


Én is ránézek, most van egy órám egy kis kényszerszünet után.


PEP8 standard violated
Used multiple statement in same line


To link a level and a platform list to fireball, two way linking has to be done. Fireball to level and level to fireball.
Every time we create a fireball and link to a level , we have to link the level to the fireball separately. This does not follow divergent change.
Bad code smell.


Yeah ça marche !!

En revanche, le déploiement ne marche pas mais pour un autre problème : il me dit :

remote:        I, [2015-09-27T19:05:45.958486 #426]  INFO -- : Writing /tmp/build_5d5866ce103dea0d45d4e55af0599856/public/assets/star-off-140170877dc69d0fdafc4d3981e385da.png
remote:        I, [2015-09-27T19:05:45.960393 #426]  INFO -- : Writing /tmp/build_5d5866ce103dea0d45d4e55af0599856/public/assets/star-on-6424b2f9123fb6d672b99ed6953dc66e.png
remote:        rake aborted!
remote:        ExecJS::ProgramError: Unexpected token: operator (<) (line: 15766, col: 9, pos: 453626)
remote:        Error

Puis un peu plus loin :

remote:  !     Precompiling assets failed.
remote:  !     Push rejected, failed to compile Ruby app
remote: Verifying deploy....
remote: !       Push rejected to mysterious-island-1047.

Les star off and on sont celles que j'utilise pour le stars rating (j'ai vu ton commentaire me disant que celui s'appuyant sur bootstrap était bien trop tard...). Je cherche l'erreur sur SOF mais si jamais tu vois comment résoudre le problème facilement, je suis preneur ! :-D


sys reimported. Not required


* $rootScope holds currentUser --> could be optimized


@krytarowski, @paulolieuthier, @luis-pereira ?


Good catch, thanks for pointing this out. This code compiles as strrchr takes const char* and returns char *. AFAIR I've done this change as previously it was used with same in/out argument. Building qwdtools is additional, so I haven't noticed that I missed COM_StripExtension calls there, mea culpa. I've just pushed patches to fix const issue according to JoakimSoderberg@ suggestions and changed calls in qwdtools, however qwdtools seems to be broken anyway (missing defines in code, broken makefiles etc.). Fixes are here: https://github.com/akat1/mvdsv


Code smell:
Unused variable prev


Ok got it, seems to be fine then. I need to be kind of suspicious because writing unit test for this kind of lib is very complicated :worried:


'mandar' not a good variable. Can't understand what it is.


Code smell:
Unused import Player


Unnecessary import of copy. Not used


So many lines doing the same assignment


Mixed Indentation.


I approve this commit


Exactly one space required after comma.


PEP8 standards violated.
2 blank lines should be left between class name and first method


Class has no 'init' method.


TeamCity pull requests :: netty [Build 316](https://garage.netty.io/teamcity/viewLog.html?buildId=1776&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new); tests failed: 3, passed: 3788, ignored: 12 Build time: 01:30:21
### Failed tests
```
io.netty.handler.codec.ReplayingDecoderTest.testSingleDecode: <no details avaliable>

io.netty.handler.codec.ReplayingDecoderTest.testLineProtocol: <no details avaliable>

io.netty.handler.codec.ReplayingDecoderTest.testReplacement: <no details avaliable>

```


Unused import 'Player'


I think `GlobalNotification.success` might be a better fit.


PEP8 standards violated:
Line is longer than 79 characters.


Too many branches and redundant code.


I think you should implement a type assigner in Gallina which either returns the type of the expression or some error message, and prove a lemma saying that if it returns a type, then there exists a corresponding typing derivation. With this, proving examples like `paper_list_cons_head` becomes trivial and is also very fast: It's just applying the type assigner correctness lemma and then `simpl`.

Right before leaving for the internship, I implemented such a type assigner. There are two versions you might want to look at:

*    In a [first version](https://github.com/samuelgruetter/dot-calculus/blob/e7bbad4b4912a235b586f7bcc0e61c03c0936f2f/stable/stable_typ-precise-gDot.v), I implemented a wf-ness checker, subtype checker, and type assigner for gDOT, and proved them correct. It worked quite well, and the only problems were that 1) the cofinite quantification style is not easily compatible with how a type assigner would deal with fresh variables and 2) LibLN uses non-constructive (and thus not calculable) logic to turn Props into booleans (eg in `If a = b then ... else ...`), but we crucially depend on all expressions being calculable for this approach to work.
*    In a [second version](https://github.com/samuelgruetter/dot-calculus/blob/303c571771bc070da6497d45464da2f723eeb329/dev/mylib/experiment.v), I rewrote the relevant parts of LibLN so that they don't use any non-constructive magic, and could confirm that evaluating the type assign function inside proofs works very fast. I also updated the type assign function (and the functions on which it depends) to a monadic style, which makes them quite concise and nice (however I didn't have time to update the proofs accordingly).

Unfortunately, what I'm writing here is the only piece of documentation about this; this work didn't make it into my report because it's too unfinished. But let me know if you need explanations of something.

In this `dot21.v`, you're not using LibLN or other classical logic, so a lot of the hassle I had with this approach is gone, and it should work quite nicely.


Excessive use of literals, (255,0,0) could have been a named constant, also 10 could be a named constant.
This would improve the readability and understandability of the code.


I'd like to maintain consistent names with the existing foreach macros. I didn't export it so changing the name is fine later on.

Why does your code include "T *link = NULL"? It's shadowing the passed link param. You can remove it because link will be assigned in the condition


This method could have been a function as there is no self use.


PEP 8 violated
Invalid variable name fl


This 4-man really helps.  I am getting an average of 1 ply deeper and it is clearly stronger.


Instance of 'Player' has no 'love' member.


Since this code relies on the fmailbox class (tagsets/class.fmailbox.php) which I did not write, I am rather safe then sorry here and check whether the supplied var is an array. Per interface definition it should be one (so I am not interested ion the value when it is a scalar, no matter what the value. empty() would return true in the latter case.


Please see https://github.com/ethanselzer/postcss-trim-line-height/commit/da8175870fa2daab067a82568413f3775c8370ac


Too many arguments.


Please see https://github.com/ethanselzer/postcss-trim-line-height/commit/10f189affe7479068361472eb2f30cc7ea15b25d


Please see https://github.com/ethanselzer/postcss-trim-line-height/commit/c3c9870093d94455c8f7678c7fa2d192ea57d69d and the fixup for it https://github.com/ethanselzer/postcss-trim-line-height/commit/cf7b17b1277879b2657fdb878c18bf76df835f55


I have two reason for creating default linebox adjustments: 1) Provide a “best effort” solution that lowers the bar of entry for new users. The new user can experiment with the plugin without needing to create custom linebox adjustments for their typefaces. 2) At some font sizes there may not be a difference between the default and custom adjustments. I say this because, in my research, Chrome utilizes a rounding strategy, not a subpixel strategy, for resolving values of less than one pixel.

The default values represent an average that will be close in most cases and exact in some cases. In the future I would like to include custom linebox adjustments for common fonts, this would increase the effectiveness of defaults for a wider range of font sizes.

This approach introduces a possible side effect of unexpected “fall through”. I plan to address this issue in our code base by introducing a small suite of tests that verify all our custom linebox adjustments are being applied and there are no “fall through” cases.


Hmm, IN_TranslateSDLToJKKey should not be affecting charevents O.o

https://github.com/JACoders/OpenJK/blob/master/shared/sdl/sdl_input.cpp#L262-L268
https://github.com/JACoders/OpenJK/blob/master/shared/sdl/sdl_input.cpp#L789-L834

This seems to work just fine for me on Windows with SDL2.


#11 All the spec fails are fixed except one which is failing only with `Rubinius`
```ruby
it "logs ArgumentError exception" do
        expect(logger).to receive(:crash).with(
          anything,
          instance_of(ArgumentError))

        subject.process(:something, :one_argument_too_many)
        sleep 0.001 # Let Celluloid do it's async magic
        sleep 0.1 if RUBY_PLATFORM == "java"
end
```
With `Rubinius` logger isn't receiving any crash. @digitalextremist any idea about it?


Please see https://github.com/ethanselzer/postcss-trim-line-height/commit/98488569a38bd04b3cdc096becfc358f1f46dd2e


Ok, will fix.


Indeed :(


Excessively short variable, could be more longer for better readability of the understandability of the code.


Mixed Indentation.


Great project is about to come out as I see, good luck in developing that one.


Usefull one, good luck in web-designing!


Fix #111


Nice catch.
However I've tried and I see that result is even longer in my case:
```
>>> len(generate_password_hash('test'))
66
```


Redefining prow,pcol from outer scope.


Postions of coins are fixed.


Awesome - thanks I was but my elm skill wasn't sufficient - I look forward to checking out the updated elm-d3.


Неплохо было бы сделать под Windows.


Number of coins are fixed


Hello Brady,

Thank you! I will update the code with your suggestions and re post.

(I have fixed Patient Portal and Past Appointments (recurring appts))

Regards,

epsdky.


Too many arguments.


How possible that your authored code have same comments that in my old boost convertion?
https://github.com/VladimirMangos/mangos-boost/commit/25800733ec31400eb2f922ae4e6e325d87d3a523 I not say that all code exactly same but...


self.chances not used.


Are you running python2 or python3?
Also, are you running using the requirements from pip?


Levels not implemented.


Instance of int has no members - checkCollision(), killDonkey(), donkeyWalk()


Levels not implemented


Jump feature is not implemented


Awesome! Thanks.


I'm sorry, that was an oversight.  The Threading.c/.h files are taken from whatever previous work was done.


The score is not visible on the game window rather on the terminal which makes it impractical to see the score while playing


Polymorphism not implemented


Mixed indentation and bad whitespaces problems.


Global variables undefined at module level.


Unused argument 'array'


Hello, I only upgraded from Mavericks to Yosemite today, going straight to 10.10.5. As I have a late 2011 MacBook Pro 17 inch, the Helvetica font in Yosemite looks pretty awful. It is just too small for me. I found your Lucida Grande patch and installed version 1.3 immediately. After the restart, however, nothing is happening. I de-installed and tried again. When I re-install the app says that it's already installed. Can I do a manual install, by manually replace the font in the bowels of the system?
![image](https://cloud.githubusercontent.com/assets/14863040/10124823/e9fe7ba4-655f-11e5-88e9-2817e9f6bc12.png)


BUG: gravity is disabled while the player is on the ladder. So if the player is on the broken ladder he doesn't fall down instead he stands in air.


Method could be refactored to a function.


Inte dåligt! Jag försökte fixa till en databasi SQL idag, men mitt onedrive krånglade hela kvällen så jag kom aldrig åt våra eml. Jag har dock skapat själva databasen, men det kanske du med gjorde?


BUG: Doesn't work on different resolutions


You are right... BTW, there are a few more related changes in Loqui IM for coseme, but I haven't created PRs for these yet as there doesn't appear to be much interest in integrating them (at the moment...)


Redefining from outerscope - maxstairs and maxt.


Directions of movement of fireballs is fixed. So player can wait for the fireball to pass and then move accordingly with jumping


@pbauer the at tests still fail randomly. See last 5 builds:

http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3043/


Too many arguments.
Too many branches in method.


Now that I look at this, do we even need `unsafe-inline` on scripts?  I know we need it on styles for things like cover images, but can't we disable it on scripts?


The creation of ladder doesn't happen in the ladder class instead it happens in the level class


isn't [this](https://github.com/ironsmile/nedomi/commit/a313662b9bfae5b958d9c83a801450508a34414d#diff-73599f69b4f30a3ff9b7ec4053873f43R105) sufficient ?


We need it for the snippets from Facebook, Twitter, Segment, etc. (unless I'm mistaken).


This is not the commit responsible for adding `$XDG_DATA_HOME` to `$XDG_DATA_DIRS`. It was d4409715f792e0df3ed36faca7c76240850e39d0. So let's wait for @luis-pereira's input. While that, here is some useful notes from the spec:

* If `$XDG_DATA_DIRS` is either not set or empty, a value equal to `/usr/local/share/:/usr/share/` should be used.
* There is a set of preference ordered base directories relative to which data files should be searched. This set of directories is defined by the environment variable `$XDG_DATA_DIRS`.
* Other specifications may reference this specification by specifying the location of a data file as `$XDG_DATA_DIRS/subdir/filename`. This implies that:
    * Lookups of the data file should search for ./subdir/filename relative to all base directories specified by `$XDG_DATA_HOME` and `$XDG_DATA_DIRS`. If an environment variable is either not set or empty, its default value as defined by this specification should be used instead.


If renaming "scenario" array to "steps", rename here too.


Pour appeler le constructeur avec le paramètre "hidden", il faut faire :
```java
public Exit() {
     this(false);
}


Here is another picture…
![image2](https://cloud.githubusercontent.com/assets/14863040/10124841/7d3ac846-6560-11e5-9ec7-2fe49b6b00c6.png)


Ah yeah that seems likely.  If it's possible to make them not-inline, we could completely ditch the `unsafe-inline` and basically disable all XSS vectors


Used a lot of bad-whitespaces and mixed-indentation


According to MSDN, they are both enabled by default since at least VS 2012.


Might be possible to put them into a vendor file and import it so it works with `'self'`, worth a try.


Which libva version out there does support this?


authToken is no longer used, see auth_store.js in Ember implementation and switch to a configurable cookie as well.


The existing names suck, why add to the problem? Also, with above, it doesn't clash with them so you could leave the old ones in place for compatibility. But ok, if they're not going in a header (where they're automatically exported, since they're nasty macros), we could change the name later.

The reason for the `link = NULL` is so that the caller doesn't have to do:

```c
GList *my_thing;
foreach_queue(my_thing, the_queue) {...}
```

But instead, it's properly scoped in the loop and automatically defined so you use it like:

```c
foreach_queue(my_thing, the_queue) {...}
```

The reason it's assigned `NULL` instead of `(head)` is, as you mentioned, it's assigned in the termination check.


Ditto here, abstract the auth token mechanism somehow, maybe.


Done


nice catch!


@stewie27 you need to edit your httpd.conf in there change the document or www root to www/jenkins

DocumentRoot "c:/wamp/www/jenkins"

and also <Directory "C:/wamp/www/jenkins">


quit redefined while importing in line 1 and 4


There is no method of creation of a coin in the coin instead it is in the level class which is wrong.


Thanks for the updates! I need to spend more time reviewing this, but what happened to extracting out some of these things into separate node modules, as discussed in Slack? I wasn't sure if it was somehow more complicated than that and perhaps I'm still not sure, but I created [`parse-css-font`](https://github.com/jedmao/parse-css-font) and I'm working on [`postcss-font-helpers`](https://github.com/jedmao/postcss-font-helpers) right now. I need these for other purposes as well, so it's very important they are separate concerns.

BTW – look at the dependencies list for [`parse-css-font`](https://github.com/jedmao/parse-css-font) and see that the keywords are in separate packages as well. I think we can come together on  [`postcss-font-helpers`](https://github.com/jedmao/postcss-font-helpers) when it's complete and perhaps reduce a large chunk of this code down to it's individual concern.


To be fair, I took *my* idea from @spudowiar after he told me he managed to minimise the number of dotfiles in his root home folder. So he deserves the credit!


Unused Import board


Should be used in main function


Unused import pygame


Why did you replace `[\w\d-.]` with `[^\x07\x2C\s]`? What does the last one mean? Seems more cryptic (if you consider regexes aren't cryptic in the first place...)


BUG:Position of coins is hard coded which causes the coins to be in air and embedded in the walls because of which some coins cannot be collected no matter what.


The real tricky one for me was the font-variant btw.


Class has no __init__ method.


This should be redirect(url_for('login')), other-wise browser will show /home with login page which is not correct


The commit has been updated.  Also, on the broader topic of giving recognition to people, we need to decide how to do that.  The series of commits switching to C++11 was broken up from one or two commits that had a list of people who had contributed, but I don't know who contributed what.

I am inclined to simply add a list of contributors once we have 'completed' the C++11 transition, and removed ACE.


unused variable block_size


How is addFirm part of AuthUser class ? It has nothing to do with authentication ?


afaik using `env UGLIFY=1 ....` is more portable


@spudowiar have a ${snack of your free choice} and thanks for the inspiration r.e zsh


1. Invalid constant name "score"
2. Spaces before comma is not allowed .  Corrected -> start(1, 3, 0)


I'm, of course, not sure about all the details here, but if that's the case I would love an option to turn this feature off. Perhaps `useDefaultLineboxAdjustments: boolean`.


No comments in code


Variable 'out' not used anywhere


Okay, I’ve updated it.


Unnecessarily imporing wildcard.


#Creates a special "matrix" object that can cache the inverse of matrix 'x'


Lacking, git commit -A && git commit --amend :no_good:


There is no navigation to go back to home page


Missing


@sebirdman need full setup


Found indentation with Tabs instead of spaces which results in MixedIndentationError  as in some places indenatation by space is used.


Solo mas lindo con shared memory jajaja
Hay que sacar todos los printfs de los transport :P


This should be redirect(url_for('login')), as just rendering will show login page contents with 'logout' in the browser address bar


Thanks :)


import should be in different lines
PEP-8 standards violated


The makeCacheMatrix and cacheSolve functions both documented with explanatory comments.
2 points: Both functions have corresponding explanatory comments in the R file


2 kleine Sprachliche Fehler ausgebessert


Thanks Andrea.The book is really awesome. I enjoyed reading that.


Ausserdem bei der Doku das Bild mit dem Fehler ausgetauscht.


I agree, this is at least a compiler warning. You're not honoring the `const` of `str`.... and if I search for uses of this in all files at this commit I get places where the old usage is still there. So have you even compiled?
https://github.com/deurk/mvdsv/blob/605385faba3458222208f2f9f4ab753366bb0b29/tools/qwdtools/source/init.c#L602

Also this then assumes it is ok for all code calling `COM_StripExtension` to rewrite the existing string, compared to returning it in another one like before while still preserving the original.
Example of where it is returned to another string:
https://github.com/deurk/mvdsv/blob/605385faba3458222208f2f9f4ab753366bb0b29/tools/qwdtools/source/tools.c#L798

I'd say the old API was bad, writing something to a string of unknown size is always bad. But this change makes no sense. If I remade it in any way I'd change it to work like this:

If the use is to always just overwrite the existing string.
```c
char *COM_StripExtension(char *str)
{
   char *p = strrchr(str, '.');
   if (p) *p = '\0';
   return str; // Unecessary really.
}
```

So it can be used like this (I know the return is unecessary but I think it makes the point clear that the intention of the function is to overwrite `path` when written like this):

```c
path = COM_StripExtension(path);
```

If instead the intent is to keep preserve the original:

```c
void COM_StripExtension(const char *in, char *out, size_t out_size)
{
  char *p = strrchr(in, '.');
  size_t len = 0;
  if (p) len = (strrchr(in, '.') - in + 1) :
  if (len > out_size) len = out_size;
  strlcpy(out, in, len);
}
```

bla bla bla, rant and so on... but yea, to me it seems this code won't even compile (haven't tested) :)


You've said


Thanks! I tried "v0.4.0", 0.4.0 and 0.4.0-rc2, but not 0.4...


It's cause i rebase the branch and squash commits, but I can edit out the mention


thank you


return self.__sync(options)

No need for ";"


I think I may have mentioned it in the rc1 announcement on the mailing list, it's sort of hacked in by manually putting the rc's in place as "0.4-latest". Once releases are final it will be pulling the latest 0.4.x release, for now it's pulling the latest rc.


Have you got this booting? None of the combinations I have tried allow me to boot the kernel on stock. It just reboots at the unlocked bootloader warning screen


My bad, didn't see it. Tests passed with `0.4`.


Subject of the commit message should not start capitalized and not ends with a dot. It should be more detailed. Something like:

fix status code on failed sync

Return value set to 1 if error is thrown. Otherwise set to 0 if successful.


Very good. Thanks for tracking this down. Looks like it's close to working.


Oh and please sign your commit.


There's probably something in Control.Arrow that does this but whatevs


update per biovisualize master.


I agree with you Nick, and though long before changing the initial settings as at the moment the experience for small screen users is already broken[1] and alot of Gramps dialogs don't conform to that recommendation (which should probably be documented in the developer documentation (note to self [ ] add it)) but this middle no mans land means that the initial experience for people with screens larger than that sucks; as they have to immediately adjust the size of the main window and settings I've chosen allow for the largest filter sidebar to be shown with no adjustment from the user.(see the screenshots)

What I can do is set up a VM with the lowest resolution mentioned[1] and document/review the experience probably in the new year?

What would you like to do?  Should I revert on Gramps 4.2, and leave on Gramps master?

I'm only trying to improve the usability of Gramps.

--------------------
Old defaults.
![initial-size-defaults-500h_x_775w-gramps-42](https://cloud.githubusercontent.com/assets/8924713/10120788/514030cc-6511-11e5-9c44-465dd4c27e27.png)

New defaults
![updated-initial-size-725h_x_1090w_defaults-gramps-42](https://cloud.githubusercontent.com/assets/8924713/10120787/4d2212a8-6511-11e5-8077-830bf5df05e7.png)
----------------------------------------
[1] Feature request: []4737: feature: support for 800x480 resolution]
https://gramps-project.org/bugs/view.php?id=4737

0008400	Gramps 	Too large windows [768x1366 ]
0008798	Gramps 	Buttons not visible in dialogue box
0004128	Feature Requests 	Display in netbook - problem with navigational activity using 1024*600
0002731	Feature Requests 	Decreasing of size of the "Edit Person" dialog [was event] editor
0008446	Gramps 	Report windows too large!! Locking/unlocking [1366x768]
0005076	Gramps 	Left side of screen cut off
0001769	Gramps 	Bugs with family editor window size - window stays very big in some cases
0005939	Gramps 	Impossible To Create a New Citation on a screen with a resolution of 1024 x 600.
0008414	Gramps 	Person tabs unpractically wide


I think these names are clearer:

    dependsOnLibrary1 => dependencyLib1
    dependsOnLibrary2 => dependencyLib2


Already have your skype added :+1:


Remove this as Android Studio only uses jcenter... don't think we should need anything else:

http://blog.bintray.com/2015/02/09/android-studio-migration-from-maven-central-to-jcenter/


I think most libraries will have test and they should be executed. See comments on prior PR.


This is a pretty clean program.  Code review attached.
[Code Review.docx](https://github.com/LbKStudios/Branwen/files/3072/Code.Review.docx)


As a noob, I wondered why the event handler here was on `Template.task` and not `Template.body` (as it was in the previous)... of course, it is on `Template.task` 'cause the HTML elements are part of the `task` template not `body` template (as authored in the HTML file).


Done in later commits :)


How do you leave a poll thing?
(you told me about this on khan academy)


non booting issue is around in 3.4.5x to 3.4.4x


Nice


oh my word!!! @mattstauffer the day is here! It actually happened!


Bug type: Fishing rod abuse. I have been using this, but it is in alpha for a reason. So its pretty easy to do, when a fish is on the line, if you mash the hell outta right mouse button it will give you around 10-15 fish and will also give you the xp associated with that. i have a t4 rod already cause of this.


I strongly disagree. Most libs have lots of tests. Examples for joda-primitives:

https://github.com/JodaOrg/joda-primitives/tree/master/src/test/java/org/joda/primitives/list/impl


Require at least one test... or maybe just use the default which is the same?

testMinExpectedTests 1


`Session objects are always available on Apple Watch.` て書いてあるからWatch側では`isSupported()`のチェック不要かも？
ref: https://developer.apple.com/library/prerelease/ios/documentation/WatchConnectivity/Reference/WCSession_class/index.html#//apple_ref/occ/clm/WCSession/isSupported


See prior comment


Is joda-convert a dependency of joda-primitives? Not sure why this file is here.


LGTM - this is the ideal example where there is minimal code for adding a new library.


We replace a game creator for characters, here's a few start-ups that are already for importing yourself into a virtual character for video game play.  If you can mod these games so that your virtual character can play, if not there might be a great way to work-around the problem by having the already present character creation engine to help create the character to look like a "twin -sister" in resemblance since the technology is very similar.

We need another fork for income opportunities.
 I've found some here:

Income opportunities being endorsed should use the banner/ad is a billboard concept that are used by several of the most popular games.
Fork . Seasme.Open.MostPopularGames.BannerAds.Fork Something

<! I'm passing a variable after social login so that the game instance will run from the user profile and then get the permission from the database. The aspect that is used here is a simple adaptor.  The user profile variable is transformed and the language is being placed onto the bulletin.  I think TWIML might actually become a part of AT&T after this concept because twimil will become an essential resource public utility, without it, it would be a problem for the city to function since its so easy, its not the only sytem but it's already in place and it's got a programming  work around so of course it's going into mods.   We will fork some of those mods.  In the city, I want for those people to invest in AT&T for this demo, the AT&T virtual micro-hedge instance should be worth something, maybe a cool T-Shirt or something if we can get those guys to giveaway anything for new sign ups or fixing your service in exchange to owning a microinstance, then we have a gaming concept.


姐姐


good


why are you complaining when its not done "originally" by me?? its @myfluxi's find..anyways thanks for your fix..


.l.


i think i merged this so if it needs correction, PR once more. i think it works for now though?


A chained ternary operator? Thank you, Captain Readable!!!


FYI, I tested the latest `_mktime` on Windows 10 using my system zone (US Central) exhaustively across every second in 2015.  No problems.  The 3600 fold times were correctly distinguished; the 3600 gap times each returned "an hour later" with `fold=0` and "an hour earlier" with `fold=1`; and all the rest got the (unique) right result regardless of `fold` value.  And every line of `_mktime` was executed.

Most importantly, that's the only zone I care about ;-)


Classes not implemented.


Some spaces here :)


Modularity not implemented.


import 'choice' not required as it is not used


Unused import 'sys'


Mostly to maintain consistency with the JavaScript reference parser: https://github.com/jgm/commonmark.js/blob/master/lib/blocks.js#L748


getPosition(), checkWall(), checkCollision(), collectCoin() not implemented.


This might be part of the docker-compose suite.

I did not package python application in its own container because of a lack of python skills. I think I understand it better now, python server should be included as well.

I created #27 for this.


Not sure I get the purpose of this.  I also fear you get the `User-Agent` header twice if you use this,
no?


Proper Comments not provided, difficult to understand the code.


And here


Modulation is absent


1. Relative import for should be done as "from folderName.filex import filey" but found just "from filex import filey"
Example :(Line 2) from 201402162_assign1.intro import intro


Encapsulation,polymorphism is absent


What's the `_id: true` for?


Kunne af en eller anden grund ikke reverte :( :camel: :boom: :8ball:


¿Esto fue generado a partir del sistema que están usando los usuarios? Es decir, desde el servidor.


Used a lot of bad-whitespace and mixed indentation


CLion should be warning you that b==NULL is always false. you are using b->size right before this.


@tisto it may very well be my suspicious sysadmin mind, but all failing builds seem to be on Node4, and the succesful ones on others.


let's make this print to stderr and only #ifdef DEBUG is on.


Agreed! I think i just do these in the heat of the moment. I'll try to put more focus in the future.


you might factor this line out to right after the if-then-else.


Basically zero automated. There is an out of date list of things to manually check under /tests; there's also some irrelevant tests dealing with the wiki, IIRC.


Ok, this feature needs to be added to the "vote" section of the inventory with a little definition text

Maybe this order should be great :
- Vote
- Skip
- Register


code smell: lazy class


it should be chunk not chuck ;)


oops, forgot this one #5


code smell: complicated complexity


this is dead code.


Hi Vivek,

Thanks for your responses.

> In the code i have put "Vivek :" where ever i have made changes along with comments if you want i can explain you in Skype call as well.

Is this the best way to use the tools available to show one's code changes? Can you think of some best practices you might use here?

> Also code is fully functional and following are the test cases which i performed with test results. Please check the attached doc where i have shown the testing.

Is this the best way to use the tools available to repeatably demonstrate testing and correctness? Is your approach easily automated? Can you think of some best practices that might apply?

In one of your e-mails to me, you wrote:

> ... I still feel that there is a better way to do this task and i would like to share that with you tomorrow. ...

Were you able to make those changes? I only see one commit here.

Thanks, and I look forward to hearing from you.


Seem like at least needs to be https://github.com/rejectedsoftware/vibe.d/commit/72aa57d84b7a9f0031e290a1d3d814d14cf4ccca for linkFilter.
Also I guess those versions only work when locally adding a git repo, right?


you can avoid the next def by using `Free_Header *chunk = bin[size-1];`


Ah, OK then, I was not aware that array is populated by third-party library, keep it as it is then.


@polyester Good observation. I purged the egg cache on node4 and started the AT build 10 times:

http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3053/


CC @rsrock


Already defined funtion ladder in line 259.


This is the main file, this file is run or called from your html/php.


There are three out of the ten builds that run on node4:

http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3046/
http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3047/
http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3048/


vertical-align: baseline;


@JockeTF - thanks for the info, btw.

I realize now what I wasn't understanding about the caching - `_filter_instance_cache` is a class attribute, so it's shared across instances. Mucking with the filters would definitely would cause things to break.

I've made another commit that removes the caching, since it doesn't seem necessary anymore. Related filters are expanded only as needed when evaluating the queryset, so there shouldn't be an explosion in filter count. As a result, FilterSets should be much less expensive to instantiate now (probably?).

If it's convenient/possible, could you run your tests against the latest in [this branch](https://github.com/rpkilby/django-rest-framework-filters/tree/fix-filter-complexity) to check? Any difference in test execution time?


actually `./gradlew build -S -i` would be better.


doesn't that need a `;`?


PEP8 standard violated. Used multiple statements in same line.


the hell?


If I understand this expression correctly lazy loading should only be performed if the `lazyLoader` is set. In this case the naming of the variable might be misleading.

How about calling it e.g. `lazyLoadingRequired` and moving the null check to the front?


Varför sätter du längden till 255 här?


Update


polish comment?


Varför skapar du `created_by`?


:) I had no idea anyone actually used this old crap. :+1:


Varför skapar du `created_by_name`?


Class docstring missing for all classes defined.


If you use old network code convertion then also add credits to Ambal ( https://github.com/VladimirMangos/mangos-boost/commit/5ab79c6b882e5c29ffe5a24750e5bac2da85a43c )
I think you can just add to description reference that commits base at original code and nicks list in first convertion commit or each. Not important how you make credits but important do its if your code base at code another author.


Class docstring missing in all classes defined


Felaktig formattering


1. Bad screen resolution . The game will not run on many PC's as it uses a hard-coded screen resolution . Rather the code should extract the screen resolution from the system and then should display the game
2. The file name is bad for a executable .It should rather have been main.py or run.py which gives user the hint which file to run.


cool var: rottenCache ;-)


Excuse my ignorance, but does this mean that 1.3.x is no longer acceptable as a dependency? At least that's my understanding of the interpretation of semver...


неплохо было бы  предоставлять информацию пользователю, о расписании кабинетов и больниц, а также осуществлять поиск по врачам


This is due to the fact that is has not updated itself to Bootstrap 3, remaining compatible only with Bootstrap 2


thought about the same :P


Class docstring not defined for all classes


probando


Screen resolutions should not be hardcoded . They should be rather extracted from the system using python system calls.


Calling setUsername(core->getUsername()) and same with status message would have avoided some code duplication here.


Unnecessary comment, everyone knows what split is doing...


Formatteringen i hela den här filen stämmer inte med din övriga formattering. Rätta till det.


Frame rate is too high. Not preferred.


Пересохраните в UTF-8


Many unused variables results in excessive hard-coding.


This test would be a perfect match for Mockito.


I think that previous one was more meaningful. Anyway I would remain to something like `IsIpLocalhost` or `IsIpLoopback`


no need for else here


magic pushbutton. Смешиваете оконный код и бизнес-логику


лишнее копирование


:thumbsup:


Do we need to implement the lazy loading in the model element? That looks a bit strange to me as this is usually a UI feature.


Class docstring missing for all classes defined.


Huh... I did copy the files before deleting the icons folder, but did it as another branch. Hold on a sec...
--
I am currently away from my computer, my desk and all associated conveniences. Please excuse my brevity and any typos.
www.devinulibarri.com

On September 27, 2015 2:38:05 PM EDT, Walter Bender <notifications@github.com> wrote:
>when did the icons get copied into a new directory? didn't see that in
>any of your patches.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/pikurasa/musicblocks/commit/0acd85d5bbac90d17ef5b8f203798cbb6d993bcd#commitcomment-13458098


Modulation not implemented, good for better understanding of code


Proper Comments not provided, difficult to understand the code.


Another node4 build:

http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3056/


@hentaiphd Don't you want to call this in the ContactListener, so it affects all collisions?


What in case if db is not on the same host? Maybe it's better to create field with allowed hosts in config file?


Class docstring not defined for all classes


> Is the next macro going to be like #define foreach_index(arr, ind) ...? :)

We actually have foreach_c_array(arr, index, len) already :-)

> The existing names suck, why add to the problem?
Because I feel it's out of scope for my patch set. foreach_* macros have a tradition in Geany and I'm not here to challange it. I know you want every other patch set to start a revolution in one way or another :-)

> The reason for the link = NULL is so that the caller doesn't have to do:
By avoiding the need to declare the cursor variable beforehand you take away the ability to use the cursor after the loop, e.g. in scenarios where you use foreach_* to find an item. It also risks unexpected shadowing where one has declared it (perhaps in the hope to use it afterwards).

I considered this actually but discarded the the idea for the above reasons.


Hehe, why not use the much better version he provided? :)


> Is the next macro going to be like #define foreach_index(arr, ind) ...? :)

We actually have foreach_c_array(arr, index, len) already :-)

> The existing names suck, why add to the problem?

Because I feel it's out of scope for my patch set. foreach_* macros have a tradition in Geany and I'm not here to challange it. I know you want every other patch set to start a revolution in one way or another :-)

> The reason for the link = NULL is so that the caller doesn't have to do:

By avoiding the need to declare the cursor variable beforehand you take away the ability to use the cursor after the loop, e.g. in scenarios where you use foreach_* to find an item. It also risks unexpected shadowing where one has declared it (perhaps in the hope to use it afterwards).

I considered this actually but discarded the the idea for the above reasons.


getPosition(), checkWall(), checkCollision() and collectCoin() function not present.


Too much position hard-coding.


'''
for (int i=1; i < str.length(); i++) {
'''


Thank you! I went ahead and followed the instructions in the thread
manually.

William Wiklund
On 27 Sep 2015 21:02, "Naresh" <notifications@github.com> wrote:

> Yes fillchaim. It also works with find5 16GB version. Also check the xda
> thread http://forum.xda-developers.com/showthread.php?t=2608337&page=12.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wolverine2k/O-Tools/commit/78e3773d8d6db01bcd71579c780da83461ee4e1e#commitcomment-13458206>
> .
>


that node4 seems to be failing on rather random stuff. Zope, selenium, whatever


I took node4 offline and started 10 more builds: http://jenkins.plone.org/job/plone-5.0-python-2.7-at/3065


may as well use this->ForEachPlugin(ke::lambda<>) ? or is this for external use?


maybe `value: data.globalExcludes` instead of `get: function() ...` would work?


You're right, I think it's a very bad idea to rely on text-based exception message matches. In PR #241, I didn't modify this code, just kept the existing code. I'll be a good sport and submit a separate PR with your recommended change, though.


better add space between operators.


In the model it is the single point to implement it. we have also the headless runner without gui, that loads a structure by name and the related elements by the lazyloader.


You're welcome. I'm very happy to hear that ;)


true. it was pasted line from my other project.


or maybe `IsLocalhost`


Maybe qTox on windows 7 crashes because of the deletion of the property 'text'
It could be repaired like that?
```` .xml
<property name="text">
 <string></string>
</property>
````
Same for status.
```` .xml
<property name="text">
 <string></string>
</property>
````


Не имеет смысла, потому что в этой ветке у сокета неверный дескриптор.


As I said I have never looked at a qws script, but I guess it's actually just a shell script of some sort, or?

In that case this forces them to have a shebang line since it's not the shell executing it.

Hmm, haven't thought about that but, again, I guess it all depends on how a script looks like. If it actually is a shell script then it doesn't make any difference unless setuid'd :-)

> On 27 sep. 2015, at 20:32, Mateusz Kocielski <notifications@github.com> wrote:
>
> The problem is that Sys_Script takes arguments from user, so passing them directly to system(3) without filtering is not best idea (as it potentially may contain special shell characters like pipe, backticks etc.)
>
> —
> Reply to this email directly or view it on GitHub.
>


This is a very happy moment, as I finally used the Random Forest algorithm.


I undid this anyway. It restricts tajaran and stuff when it shouldn't.


According to problem statement player should be given three lives. Found : one.


Actually no, system calls /bin/sh with arguments while exec* executes the given binary, no shell involved.

> On 27 sep. 2015, at 03:38, Joakim Söderberg <notifications@github.com> wrote:
>
> system is just a short hand for doing the stuff this code does (that is, fork, and then exec the command line using /bin/sh.
>
> So the code does the same thing. However, this code gets rid of the weird "cd %s ... cd .." business. Maybe that's the reason for the change? If I wrote this code, I would do it like this, and not use system if that helps :)
>
> —
> Reply to this email directly or view it on GitHub.
>


> We actually have foreach_c_array(arr, index, len) already :-)

oh lord...

> Because I feel it's out of scope for my patch set. foreach_* macros have a tradition in Geany and I'm not here to challange it. I know you want every other patch set to start a revolution in one way or another :-)

Once this PR is merged, we won't be able to change it without breaking the API and ABI, which is why I think it's important to do it now. It's not a revolution, it's just good coding standards to not spam plugins' global namespace with unprefixed macros (especially common names like `foreach_...`).

> By avoiding the need to declare the cursor variable beforehand you take away the ability to use the cursor after the loop, e.g. in scenarios where you use foreach_* to find an item. It also risks unexpected shadowing where one has declared it (perhaps in the hope to use it afterwards).

Ok, makes sense, but by doing it your original way, it takes away the ability to put the variable in the "proper" scope, which is probably what you usually want (it's often a code smell to use a loop iterator outside of the loop). There's no risk of (unintentional) shadowing since the scope of the variable is inside the loop and the caller provides the name.


Also it appears now that for some reason input direction isn't working.... I didn't change anything in that though so I am not sure why. It might have something to do with the forks.


Number of coins in each row are fixed


Run command
```
php artisan route:list
```
The result:
![bearberry-la table](https://cloud.githubusercontent.com/assets/3900509/10125078/e0fe4036-6535-11e5-8e9d-e660db06f6d6.PNG)


Last one is actually a reply to Cokeman :)


Proper Comments not provided, difficult to understand the code.


Which is the purpose of having a app.jar file in the public repo? Reconsider unless there is a strong reason for it.


+1 ;)


Or you have deleted it with this commit. If so, I excuse me!


On 09/27/2015 02:36 PM, Walter Bender wrote:
> I see what you are trying to do, but I am not sure why you use
> header-header- in some places and header- in others. Is there another
> patch that moves the icons to a new directory?
If it says

header-header

in some places, I must have made a mistake. See my latest pull request
for the steps I took to get to that particular pull request.

On a superficial level it works, despite gandi's server having the icons
folder reserved.

http://play.musicblocks.net/

Devin

--
Devin Ulibarri
(505) 379-6253
www.devinulibarri.com


the partitionObjects does not always contain unique values. It is a internal state of the relabeling algorithm and contains some old partiton ids and their mapping to the real ids. This is why you sould never access it.


@sonnygauran, sorry, I will not publish this on bower.

I prefer NPM over bower
this article explains it nicely: http://gofore.com/ohjelmistokehitys/stop-using-bower/

However, you are free to fork it and publish it yourself

R


I am doing tests with automatic deployment to Heroku, so I am changing my repo in order to test it.
Sorry for the inconvenience.


why are you combining smaller widgets into larger, single file widgets? It's unnecessary and is likely strictly less modular than the alternative


Don't give the player access to the paritions grid. Simply give it access to the player statistics. Cyclic dependencies are bad in that they make testing harder.


You missed recording could be deleted and so no longer transfered. Here we have to clear container before filling because deleted recording (by others frontend too) will no longer transfered.


Good idea!


Remember that anybody should be able to do the same once your solution is merged, so please add as many guidance as possible!


Cool, thanks. Also using it in [timdp/winston-aws-cloudwatch](/timdp/winston-aws-cloudwatch) btw.


What is this array for? How can you be sure there is no ArrayIndexOutOfBounds?


Don't store the index, store the value.


The submitUser code and such is unnecessary for the tutorial, though the faucet will have to get used


Extra space.


> Once this PR is merged, we won't be able to change it without breaking the API and ABI,

Or can it be put inside `#ifdef GEANY_PRIVATE` to hide it from the API? If so, I really don't care how it works or is named (as long as it handles empty queue).


Player will remain in the air after alternate jumps.


Unnecessary parens after 'if' keyword (superfluous-parens)

Bad code smell, Should be avoided for readability.


wierd


why not


This is more options. I don't know how it will be used exactly...


Awesome!! So somebody's about to start writing again :+1:

 ._config.yml.swp is pushed to the repo though..a .gitignore file would solve such problems.. I have also added the blog http://theremotelab.io/blog on jekyll theme itself but haven't made it public yet/

You might want to add _tags which is my next step as well.


i want s6 edge +


The failure you see is caused by this version requirement defined in setup.py. pkg_resources is using the resulting egg info to determine what modules are needed. Drop the version from setup.py and the failure goes away.


@jcoyne: I updated the vocabulary definition as indicated above, but it didn't change any vocabulary defs. Perhaps you want to use a different version?


Nope. Imagine the following setup: a storage with partsize of 10 bytes, a file with length 55 bytes (the full file on the storage will have pieces 6 pieces in total: 00-05).

If the partwriter receives bytes 23-51, the first and last pieces will not be complete and should not be written to the storage. This TODO is just a reminder to implement that logic for the last part, like [this](https://github.com/ironsmile/nedomi/blob/tests-and-cleanup/handler/cache/part_writer.go#L68-L72) implements it for the first part.

Soon I will fix the cache handler to optimize most range requests to the upstream by aligning them to the the part boundaries. In the above example, if the client requested bytes 23-51, we will request bytes 20-54 from the upstream. But the PartWriter should still be smart enough not to write incomplete parts.


Unable to compile, Error randomlayout not found


Fireballs are not implemented


Poor Frame Rate


On 09/27/2015 04:38 PM, Devin Ulibarri wrote:
> If it says
>
> header-header
>
> in some places, I must have made a mistake.
I see the header-header stuff in index.html file. I think it happened
when bluefish crashed the first time (it crashes kind of a lot). I
thought it did not save the file the first try, but apparently it did.

Devin

--
Devin Ulibarri
(505) 379-6253
www.devinulibarri.com


Can use loop to make table and Exactly one space required after comma

Bad code smell for code understanding and readability


Hi Brady and epsdky,

Here are the changes as per Brady's  comment -
https://github.com/arnabnaha/openemr/commit/a6cc135f33776ab2053ae3c4dda320f14c40f56f


copon


Donkey's position is buggy. After some time ,  the donkey is moving  in air.


Ok, will try that :)


Jump feature is not implemented.


I would argue that in the setup you provided the change I linked will make it so that the last (non-full) piece will not be written to the disk, as well as any flushing prior to having enough data for a full piece will be a noop. The test from the same commit checks exactly that. It also checks that a non full first part is not written.

I agree that an optimization will be good - maybe even with a small amount of configuration(how much of a percentage of piece does need to be request for it to be cached).


Too many while loops: Can use a function for doing same job.

Bad code smell, should be refactored (maybe by using a function).


Lel


While climbing the stairs , player can pass through the floor tiles.


Levels are not implemented


Error randomlayout not found. Maybe you changed files name later but not updated in files.


Donkey doesn't move.


Error Coin_layout not found.


Long parameter list. Bad code smell


This PR has problem: `elfi` after `fi`. This is cause:

```
/Users/closer/.oh-my-zsh/plugins/sublime/sublime.plugin.zsh:43: parse error near `elif'
```


Practically very hard to jump over the fireballs.


Player never dies,even on hitting with donkey


Do I win the T-shirt? Nah, not unless I could fix/explain why node4 is having the hiccups. But these results seem at least less random.


Coins are also generated in air


Hello Brady,

[here](https://github.com/epsdky/openemr/commit/9020447805fe735d9ea2de430317b56ef373650a) is the update


Így már jó az indulási kép és csak Haladó/Normál módban lehetséges a telepítés.
A glade2 progival módosítva valamiért telenyomódik az elhíresült "swapped" figyelemjelzésekkel az egyes handlereknél és még  egy csomó új cuccal is.
Ezért kézzel raktam most bele a lényeget.


Submission for Programming Assignment 2


Bad code Smell :- Too many functions in same class.

Load of class can be distributed by refactoring (maybe by making new class for load distribution)


Hello Arnab,

The changes I made were slightly different.


All the functions of have an argument grid which has a fixed value. Shouldn't be an argument.


Hi epsdky..

Thanks...sure...that will be better...


Player on reaching at the end of platform does not drops on  lower platform


Jump function for player not implemented.


You are right, it will work and the TODO is wrong. I will remove it tomorrow. And :+1: for the overlap percent in the configuration.


TODO: check digest matches contents


Improper inheritance, super init not called


I see... Thanks for clarify.


Thanks!  US/Central is not a bad test case with 5 different abbreviations (CDT, CPT, CST, CWT, and EST) and over 100 transitions before 1970.  I believe ignoring system mktime and probing localtime ourselves is the way to go.  I am still puzzled why GNU libc mktime needs up to 6 probes.  We seem to get away with 4 in the worst case.


remove this when you're done or you will break other packages


Lives of a player are not displayed which was a essential feature.


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4061/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


Unused arguments 'row' and 'column' passed to function


Need andy_bot.py and game_bot.py to play the strategy bot. andy_bot.py contains the class and subclasses. game_bot.py runs the game bot. random_bot.py runs a random bot.


No boundary implemented which covers the game window which results in player moving up in the air.


I think we would want to mark the state with a different variable here. This Tessel is still authorized, the connection just got closed. Perhaps we should make a `.closed` boolean property on the connection and set it to true here. We'll also want to check that property at the beginning of `exec` to ensure we don't try to run a command after the connection was closed.


"Do you want a reminder if you haven't backed up your settings in the last thirty days, bby? :ballot_box_with_check:  check :+1: yes or :-1:  no.


lines too long.


Global variable 'p' , 'r', 'b', 'd'  undefined at the module level


No comments in entire code.


Mixed indentation.


@Student007 does this event get called instead of `ready`? Could it be called after `ready` if, for example, the network drops out? Fortunately, Promises natively restrict `resolve` from being called twice but it would be nice to have some clarity on the order of operations.


Ah, so @creesch level verbosity?


`-x` is flag rather than option waiting for an argument so this colon here is buggy. Please, remove it.

Consider [getopt documentation](https://docs.python.org/2/library/getopt.html#getopt.getopt):
> (...) with options that require an argument followed by a colon (':'; i.e., the same format that Unix getopt() uses).


When does `end` get called as opposed to `close`?


haha yup keeps it fun :)


Yeah, sorry for that, I'm used to JavaScript, and did not write C# since almost 10 years :)


I recommend: 'Tessel has closed the remote connection." Also, it seems like this should be an `logs.err`, right? It's not recoverable.


Variable 'd_x' not used anywhere else. Not required


Fix for bbc/microbit-extras#1725


Variable 'd_y' not used anywhere else. Not required


Tests Fail!


As a Dutch man, I think he'd approve.


docstring for methods are missing


That did work. Was that cached information that was on my pc only, or is that something that (still) has to be changed in the package?


There isn't a right/wrong way. I'm just a control freak. :)


> And every line of _mktime was executed.

This by itself does not prove that we tested all possibilities.  It does not look like a hard combinatorial problem, but it is not obvious to me how many different situations are possible here.  It looks like what matters is the relative position of t, t -a, t - b and the transition location u and points at ±shift from it.  This makes 6 "interesting points" and therefore up to 6! = 720 relative placements.   If you note that the u and u±shift points always come in the same order, you are left with 720/3! = 120 combinations.   This is still a lot and I am not sure whether all of them are realizable.


With this change how I define the RGB values?


Exactly one space should be provided after comma.
PEP 8 standards violated


I'm so proud!


Screen resolution is hard-coded. Should use sys module.


I like this! There might be something the shell did JUST before the native binary exited, so `$?` is now poison.

Ref: http://stackoverflow.com/questions/10666035/difference-between-and-lastexitcode-in-powershell


Fixed in 05d719a72792b9d19d331867256077910f8e6614


 Found indentation with tabs instead of spaces.
PEP 8 standards violated


Mixed indentation, bad-whitespaces and trailing whitespaces nearly in whole code.


does this work for you with switch


Yes, if you run the sync functions, they will complete before the function exits.


first add

[ProgrammingAssignment2_cachematrix.txt](https://github.com/ZhenyuSong/Coursera_R_Programming_Assignment2_cachematrix/files/3191/ProgrammingAssignment2_cachematrix.txt)


@ovatsus  - How critical is this cache?  It seems structurally wrong to cache provided types in a global and retrieve them from later type providers - logically speaking this in turn holds handles to all referenced assemblies (these assemblies were previously reflection assemblies, but #875 replaces them with AssemblyReader-backed assemblies. These consume memory and should really only need to live as long as the ITypeProvider instance to which they are related - but this cache means they live on longer).


validate_on_submit() added


There's a more efficient way to do this. Check the answer.


Used global for 'width' and 'height' but no assignment is done, violating PEP8 standards


Line too long,greater than 79 characters.
PEP 8 standards violated


Actually I suppose `omdoc:imports` be:
```perl
 DefEnvironment('{importmoduleenv} OptionalKeyVals:importmodule {}',
 '<omdoc:imports from="?&GetKeyVal(#1,"load")(&canonical_omdoc_path(&GetKeyVal(#1,"load")))(#2)">'
```
Since if the path is provided, then `#2` doesn't need to be present right? Let's use `gimport` as an example since it also has the same string interpolation problem. Given:
```tex
\gimport[transitive] %transitive is in the current directory
\gimport[smglom/numberfields]{naturalnumbers}
```
we should get:
```xml
<omdoc:imports conservative="false" from="smglom/sets/source/transitive" xml:id="transitive-closure.imports3" about="#transitive-closure.imports3" stex:srcref="smglom/sets/source/transitive-closure.tex#textrange(from=3;0,to=3;22)"/>
<omdoc:imports conservative="false" from="smglom/numberfields/source/naturalnumbers" xml:id="transitive-closure.imports5" about="#transitive-closure.imports5" stex:srcref="smglom/sets/source/transitive-closure.tex#textrange(from=5;0,to=5;46)"/>
```


Sorry for bothering then ;)


Unused import


Я не знаю какой именно месяц имелся ввиду, но 9 в джаваскрипте - это октябрь (http://www.w3schools.com/jsref/jsref_obj_date.asp) месяцы устанавливаются с 0 до 11, такая вот особенность =)
Тем не менее все выполнено верно =)


For routes that aren't ordinary REST routes, cancancan doesn't standardly know how to do authorization. I think it will try to authorize the `:toggle_public` action, which I guess will fail.

By the way @bartkamphorst, I can't get the AJAX-toggle to work. Should we make it AJAX though? In the repositories settings view the public-switch looks like it's part of the larger form, so it's not really obvious that clicking it will toggle `public` even if you don't submit the form.


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4062/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


Wrong hanging indentation


No ezt hogy csináltad? a swapped pl. már nincs is benne...


ack


Ah, but there's a reason I used US/Central for 2015:  this _is_ my time zone, and Windows doesn't store historical transitions.  So the only thing I can ever test on this box with the native `localtime()` is current daylight rules for the relative handful of zones Windows knows about.  And I'm sticking to US Central because I'm afraid to change the system zone ;-)

About GNU `mktime`, did you ever instrument it to count the number of probes?  As I read the code, 6 is just the maximum number of times the main loop can call `ranged_convert()`.  The latter does its own binary-search flavor of probes.

Then, after the main loop finishes, if the `is_dst` value doesn't match the requested value, there's yet another loop calling `ranged_convert()`.

So I have no idea how many probes it may require.  Perhaps it doesn't assume any minimum distance between transition times?

About "This by itself does not prove that we tested all possibilities", of course not.  It just proves that there's no **dead** code remaining - it's all needed just to handle US/Central in 2015.


What do you mean with 'switch' ?


Comments missing, difficult to understand code


Cool stuff!
Just some detail nit-picking...

- Add more detail to commit messages. What was the non-conformant behavior?
See here for an (over-the-top) example commit message: https://github.com/torvalds/linux/commit/30927520dbae297182990bb21d08762bcc35ce1d
- Please don't mix topics in one commit. Fixing python and fixing the client could have been two topic commits, imho


Nifty :)
It's amazing how you use small tipps to make such great things!


Right that's true. There will be slightly different behavior...

However in the previous version as @akat1 mentioned, an example would be to name a `.qws` file `. ; rm -rf / && touch bla.qws` which would make this: `"cd %s\n./%s.qws %s &\ncd .."` become:

```
cd whatever
./. ; rm -rf / && touch bla.qs whatever_args
cd ..
```

With `exec` those will not be executed by a shell, but rather simply passed as arguments to the new process :)

Not at all very likely, but yea...


Desde allí fue generado...
Sólo tenemos una duda con los SP, como se sacan desde el servidor?
Enviado desde mi BLU Android Smartphone

Luis Manuel Deras <notifications@github.com> wrote:

¿Esto fue generado a partir del sistema que están usando los usuarios? Es decir, desde el servidor.

---
Reply to this email directly or view it on GitHub:
https://github.com/hllanosp/proyecto-ciencias-juridicas/commit/538595a5ad8db1b6882fe5c5a72e59a7f8a0d382#commitcomment-13458573


Since this is being handled here, we can remove the code that does this in `thread.Continue`.


Check again if the collisions do exist. If so, then give one example.


There's an follow up in the problem.


nmnm


Positive: Good function and variable names


Coin randomly generated on the board results in the coin overlapping problem.


Yeah but if a qws script is a shell script (is it?) then we both know that you can just put those commands/characters in the script instead :-)

Since the .qws is executed directly it would imply its a binary or a script of some sort with a shebang line :-)


Когда ты используешь синтаксис доступа к свойству через квадратные скобки, то это намекает на то, что вместо статического свойства может быть переменная. Это не тот случай. То есть в данном случае `review.author.name` будет более читабельным вариантом, чем `review['author']['name']`.


@Student007 if you want to know if a Tessel is `provisioned`, you can just check the `.authorized` property. The `isProvisioned` method is poorly named but is meant to check if the local computer has keys already. It's primary purpose is to not overwrite those keys when you run `provision` multiple times.

There is currently no task to review security because it's pretty much the exact same security model as SSH. If someone has physical access to the board, you can assume security is compromised.


What if s1 = "aaaa", s2 = "aa"?


Hm... are you saying I should push a vector instead of a child_range iterator to tcampaign_difficulty? Or should I pass an iterator over the vector.


A player can take a coin from a floor which is just above his current floor. This is a bug as player's collision with floor tiles should not be allowed.


PEP8 standard violated. Used multiple statements in same line.


That line is not correctly intended


The drums are not falling down from the ladder which is against the problem statement.


If we're using this colour in a few places it should be a variable.


Sorry, looks broken ;P


Nice, thanks Lee


Comment should be explicit for this library:

    // joda-primitives doesn't provide a test-sources.jar (checked for version 1.0)


A la hora de generar el archivo debería de haber un checkbox que diga algo relacionado con procedures o functions.


There's a more efficient way.


// joda-convert doesn't provide a test-sources.jar (check version 1.7)


Does this need to be debounced or throttled maybe?


No broken ladder are shown as there should be as per the problem statement.


// joda-time doesn't provide an external test-sources.jar (as of version 2.8.2)


The good old, doing evil stuff the simple way you say?! I prefer to do it the Dr. Evil way *pinky next to mouth*

BUT! how about the `fs_gamedir` variable??? That is at least setable: https://github.com/deurk/mvdsv/blob/86488dd5f2809df6672474ba00a2ac15a8260b7e/src/sv_ccmds.c#L1641

So if that is set to something evil! Everyone will die using `system`! :)

And if that can ever be set by someone clientside = omgz!... But I don't know if that's the case :)


// gson doesn't provide an external test-sources.jar (as of version 2.3.1)


that has to be connecting  + checking


:clap:


Player cannot climb some of the stairs .
Example : The left most stair on the second floor.(Taking Ground Floor convention)


I can't compile SE with this code, I don't have git tool

![capturar](https://cloud.githubusercontent.com/assets/7856897/10125356/bbf9a266-6568-11e5-89de-87006b18f47b.PNG)


When i == m -1, does this work?


No modularity, No OOP structure implemented.


Kézzel írtam bele a /usr/share/uhu-installer.glade fájlba a változtatásokat.
A lényegi változtatásokat meg az uhu-installer.glade fájlt beolvasva a glade2 progiban végezvén lehet kitökölni, hogy melyik gombhoz mi tartozik. Ott a az illető tulajdonságát megváltoztattam, majd kimentettem a fájlt más néven. A csak engem érdeklő részeket meg beszerkesztettem a /usr/share/uhu-installer.glade fájlba és egyből kipróbáltam, persze telepítést nem csináltam, mert azt nem is lehet a telepített rendszerről.

A swapped -eket nem tudom, miért rakja bele az újabb glade2, az biztos, hogy az eredeti glade fájl jóval régebbi glade2-vel készült.


Large class = code smell


Stop to free up resources...if you disagree just modify it to bring it back to the queue.


these actually aren't equivalent, `I` is unsigned and `i` is signed


Hehe, quite funny dicussion when looking at the "security" overall, couldn't agree more :) I just get curious when I can't make sense of things :D

So speaking of things, got any time to help out make ezq3.0 releasable? :-)


https://docs.python.org/2/library/struct.html

i.e., it will break for large unsigned integers


Extremely redundant code. Duplicated code = code smell


@paulirish Looks like your screenshot is missing the deleted line here:

![](https://www.evernote.com/shard/s534/sh/e519576f-1187-4def-8c29-8ad09be6aea8/d0356edaf68f850759a0701f0480d1f2/res/f47cf618-e273-4886-96ee-1693fc64e6cb/skitch.jpg?resizeSmall&width=832)

Is this intentional?


Inavalid names of methods according PEP-8.


Layout is hard coded, hard to debug.


You need to check and store whether the 1st col and 1st row has 0 before using them as indicators.


Modulation is absent


Cool


Encapsulation,polymorphism is absent


Layout is fixed instead it should dynamically be created randomly.


You say "All rights reserved" and then immediately contradict that with a permissive license. Pick one or the other - not both ;)


Miss follow up question.


I forgot to remove


Unused import choice from wildcard import.


@UltCombo I saw that too. I wonder if it's an error or if it's due to the subtle change. @paulirish ?


**applies his stamp of approval*


Although it's not a big problem, you better write your solution in a dedicated function instead of main.


@UltCombo it seems that is a changed line, not a deleted one. On that line changed the GlassPane() arguments.


indent


Well not really, got so many projects going on afk right now. But do you have something specific in mind?


not sure why we have a extra line there


@gerzenstl yes, but take a look at how the other changed lines are handled in the [screenshot](https://cloud.githubusercontent.com/assets/39191/10000682/8e849130-6052-11e5-9bd9-bd4505cd24d6.png). There's a pink line for the old line and darker pink highlighting the changed characters.


In a line, please :-)


Had to install `gnu-sed` from homebrew to get this to work. For zsh users, change `bash` call to `zsh` and add `strip_diff_leading_symbols`, etc to `.zshenv` (see [here](http://unix.stackexchange.com/a/126961/78833)).


Arff. Apparently these types are then heterogeneous. i4, I4, i4, i4


Fireballs hardcoded


You don't need to consider whether the length is odd or even. There's a better solution.


Hi @hcf and @amolenaar

I added this test page with this UTF8 test: FitNesseRoot/FitNesse/SuiteAcceptanceTests/SuiteSlimTests/SlimSymbols/NamingConvention

Think this should cover the required testing
and in addition provides the documentation to the community that this new feature has been added.

I am a big fan of "Eat your own dog food" and prefer adding wiki tests then Junit tests.
And I think this is a nice example that wiki tests can be more efficient than Junit as it takes less lines to express the feature in a wiki page than in Junit.

If you see any feature not covered than let me know and I can add it.


# HelloWorld
## This is a markdown file


There are 2 different styles here.


thats impossible


:-) Thanks for all the feedback!


Perhaps we should factor `get_insertion_point_for_layout` into a trait that is shared between textarea and input elements, to avoid this duplication. What do you think?


not sure there is a nice solution, maybe struct was more elegant here. What do you think Eric?


Better convert it to String.


IMAGE SIZE BUG :
1. The player inside the sprite sheet is not appropriate . It covers a lot of space which results in collision even when the player is far above the drum("Fireball").


yes it was.
So it's fixed?


this was just a commit before I merged your changes from develop.


consegui fazer uma parte, porem ainda está com erro


This is a very general routine that maps a byte index to a character index and doesn't really have much to do with insertion points per se. Perhaps this should be in `util::str` (if it's not already part of the Rust standard library)?


Hi there! I don’t know if this is my place to say something, but I would recommend that you use `.xz` instead of `.lzma` as the filename suffix here, since `lzma.compress` results in the format used by `.xz` (aka the LZMA2 format).

This may not make a huge difference, since a lot software for handling `.xz`/LZMA2 files performs auto-detection of the input format, but should there ever be any problems wrt the compression format, using `.xz` might help clarify things a bit.


Thanks.


1. The game has no restarting option after it ends.
2. Game does not end when we press 'q' as was proposed by the problem statement.


Miss the follow up problem.


oh, ok


i understand. :)

there seems to be about a zillion ways to place legends. there is a good [legend guide](http://matplotlib.org/users/legend_guide.html) available...

i don't know if we can guess if there is an overlap however, it seems the [standard solution](http://matplotlib.1069221.n5.nabble.com/Stopping-Legend-From-Overlapping-the-Graph-td22228.html) is to move the legend outside of the graph, simply. it can be put on the side, above, below, etc...

i could implement something like this, or you could try as well! :)


```
for (int i = 0; i < a.length(); i++)
```


Practically difficult to clear the game.


Modularity missing. Too many classes in game.py


Do you have to use map? A set is good enough.


Hard coded board.It should be created dynamically.


The question says "enough space" instead of "suitable space".


there shouldn't need to be a static_cast to U64 here since the count function call will actually do the conversion of the duration for you.


I am not sure what is going on.  Is this a comment on an old commit, or is
it a commit in your fork?

John

On Sat, Sep 26, 2015 at 6:19 PM, gajennings <notifications@github.com>
wrote:

> Pending problem DBsection corrected in later commit. Should be Traces,
> contours, and level sets
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openwebwork/webwork-open-problem-library/commit/b21a2ea83070376dcca0702966328a946b80db39#commitcomment-13453655>
> .
>


The 50 move draw thing turned out to be Little Blitzer going an extra ply before adjudication.  Perhaps it does not adjudicate at all.  Not sure yet.  Stockfish plays the wost 50th move possible because of move ordering.  It would be nice to change this.


What happened when we have "aabaa" as input?


This is a very good opportunity to make a separate "DeviceRenameDialog" class.  There is a "dialogs" package already made, so try defining all of this over there and only calling it here.  I'd like for MainAcitivity to stay as small and neat as possible.


I don't think there is a coding style using "x ++".


We might consider ```np.fromstring(s, dtype=('>i4,>I4,>i4,>i4'))[0]``` as a solution, it looks more verbose but actually it returns the correct types whereas the replaced struct function only returned ints.


Using flag is not a good idea because it makes code hard to understand. You can swap a and b according to there length.


![test2](https://cloud.githubusercontent.com/assets/6691874/10125443/8bb325c4-6585-11e5-91c4-8fa3c784b123.png)
Происходит перекрытие тулбара с формулой


Abstraction done only for text. The important attributes like velocity,state,coins,life are public


Можете завтра спросить из-за чего так может происходить?


Hello Toleda, backup process failed with msg

```cp: /System/Library/Extensions/AppleHDA.kext is a directory (not copied)```

Below run just fine for me

```sudo cp -XR $gExtensionsDirectory/AppleHDA.kext $gDesktopDirectory/audio_ALC$gCodec-$gSysVer/AppleHDA-orig.kext```


I mentioned that it's a good idea to stick to Material Design colors, https://www.google.com/design/spec/style/color.html#color-color-palette, these may already be part of android's built-in color references, but if they're not they could go nicely in like <color name="Red500">#F44336</color>.


Please read the question again.
It doesn't always return the new string.


Bugs related to broken ladder:
1. The player and fireball can fall down from the broken ladders.


new line.


Made the lower set of changes manually. Upper change is to a quote. Recommend holding off on chapter 4 for a bit more.


## This is a markdown file


* [The Official Project Page, including source code](https://sando.codeplex.com/)
* [The Tool on the Visual Studio Gallery](https://visualstudiogallery.msdn.microsoft.com/06f39a31-20ce-408c-afee-8a02b484db1c)
* [A Video of the Tool](https://www.youtube.com/watch?v=SDTPDpleOcM)

In this repository, for ExampleTool you will find:


We should make a better distinction between the different usage of the word "Mapping", instead of an almost automatic find and replace. I think that in most uses of "Mapping Expression", it refers to what we agreed we should call "Transformation Rule" (not "Transformation Expression" ! ).

It is not quite clear to me, how to make a differentiation between a "Transformation rule", (which contains the spreadsheet name, range of cells and a comment, as well something that was previously called either "Mapping expression" or "DSL mapping expression") and the expression itself that is contained in the translation rule. One solution would be to keep calling the "DSL mapping expression" a "mapping expression", and the more complex statement that encapsulates it, and which is the main entry of the JSON file, a "transformation rule". Any thoughts on this?

Related to the buttons that load/save the transformation rules from the JSON files, I would rather label them with "Load rules"/"Save rules" instead of "Load Expressions"/"Save Expressions" ("Load Expressions"/"Save Expressions" are even less meaningful than "Load mappings"/"Save mappings").


Has better solution.


* [The Official Project Page, including source code](https://sando.codeplex.com/)
* [The Tool on the Visual Studio Gallery](https://visualstudiogallery.msdn.microsoft.com/06f39a31-20ce-408c-afee-8a02b484db1c)
* [A Video of the Tool](https://www.youtube.com/watch?v=SDTPDpleOcM)

In this repository, for RUBRIC you will find:


Code smell : Long parameter list


miss follow up question.


实现了 cpu 版本。 gpu 版本尚未实现。


Gratz, @krakjoe!


you aren't on cake's repo

what are you doing in my fork


one thing which might be useful to point out in the spec: 'completed' iceTransports should be counted as 'connected'. You seem to have done this.

https://gist.github.com/fippo/ca60f7b593170dddea50 shows our variants are reasonably equivalent but yours is ... not ugly :-)


Tényleg belerakja a glade a swapped-et mentéskor. Fura.
Már csak egy éles próba kellene, ha úgy is jó, akkor release + ez kerül az iso-ra.


原来的是对的，不该改。


Code smell : very long methods


Too many invalid constant names.


Divergent change code smell because of hard coding the screen layout


pq apareció 28 días desp???????


Calculate the new length by counting spaces.


Removal of `const` modifier annoys me, because we assign to string literals and I'm a fervent user of `-Wwrite-strings`, which gives me endless warnings like those:
```gcc
parsers/c.c:307:15: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  { TRUE,  'c', "class",      "classes"},
               ^
parsers/c.c:307:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  { TRUE,  'c', "class",      "classes"},
                        ^
parsers/c.c:308:15: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  { TRUE,  'd', "macro",      "macro definitions"},
               ^
parsers/c.c:308:24: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  { TRUE,  'd', "macro",      "macro definitions"},
                        ^
```

Is it really necessary?


This change is generating errors on my side, with Laravel at `master`. Fixed it by replacing `$_ENV['APP_ENV']` with `getenv('APP_ENV')`. Could you give us more details as to why you switched it?

Appreciate it, and thank you for the amazing work!


Step 1:
a) Combine label data (activity) using y_test.txt and y_train.txt
b) Combine subject data using subject_test.txt and subject_train.txt
c) Combine features data using X_test.txt and x_train.txt
d) Cbind all data above into a whole dataset

Step 2:
Extracts only the measurements on the mean and standard deviation for each measurement.

Step 3:
Uses descriptive activity names to name the activities in the data set.  Instead of doing it after step 2, it's done along with step 1.

Step 4:
Labels the data set with descriptive variable names.

Step 5:
From the data set in step 4, creates a second, independent tidy data set with the average of each variable for each activity and each subject.


s/:hand:/:thought_balloon:/g

:sleeping:


Well done mate! Zeer nette en korte functies. Zou je alleen nog the System.out.println() weg kunnen halen en Image_Util kunnen veranderen in ImageUtil?


No modularity.


Encapsulation implemented nicely.


Fireballs not implemented.


improper imports : Should import the file as from directoryName.FileName import FlieClass
Did like : from FileName import FileClass


# FSE-2013-RUBRIC

This repository is contains information related to the tool RUBRIC presented at Foundations of Software Engineering, 2013. The tool was originally presented in [this paper](http://dl.acm.org/citation.cfm?doid=2491411.2494591).

This repository is not the original repository for this tool. Here are some links to the original project:
* [The Original Project Page, including source code](https://sites.google.com/site/rubricnlp/)
* [A more recent version of the project, renamed RETA, that is compatible with JDK1.8 and Gate 8.1](https://sites.google.com/site/retanlp/)
* [A Video of the Tool](https://youtu.be/5zIn8scJgRs)

In this repository, for RUBRIC you will find:
* :x: The Source Code (not available)
* :white_check_mark: [The Original Tool - RUBRIC](tbd0) (available)
* :white_check_mark: [A slightly modified version of the original tool](tbd1) [Sarah Elder](https://github.com/seelder) got working (available)

This repository was constructed by [Sumeet Agarwal](tbd3), [Vineela Boddula](tbd4), [Sarah Elder](https://github.com/seelder),  [Shrenuj Gandhi](tbd4), and [Alex Valkovsky](tbd5) under the supervision of [Emerson Murphy-Hill](https://github.com/CaptainEmerson). Thanks to Chetan Arora et. al, for their help in establishing this repository.


Also improved readability in partition function


The number of arguments inside the add function of listOfWalls class is too much.


To see the application working please visit
http://www.chasbeen.frih.net/SurveyData/


Player can lose only if he volunteers to do so because the donkey just oscillated a little bit.


Polymorphism not implemented.


BAD CODING PRACTICE : The code is too big. Should have been divided into classes.


Code smell : Very ;arge clas


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4064/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


Wasn't the problem - the underlying problem was tps2d3d changing.


Trying this with zsh, getting `zsh:1: exec format error: diff-highlight`, any ideas?


Code smell : very large funtions


If I may speak frankly, I don't like the accumulation of such a heap of unrelated status codes into a single `NTStatus` enum type when the expected results of a great number of method calls typically fall into a very small subset of all those values. My example are the methods in class `DokanNet.DokanOperationProxy`. None of these will ever return, say, one of the,  `AbandonedWaitX` values, still they are defined in their return type. If I'm wrong with my guess about `AbandonedWaitX`. just pick another example - you'll still get the idea.
The present situation makes it very difficult for an implementer of an extension module to determine which status values are expected by the Dokan driver or will typically be returned by different parts of a .NET implementation.
I'd much prefer to see NTStatus split into different enums that map to typical usage scenarios.

And apart from my personal preference, I think the overlapping declaration of

    // Informational
    Informational = 0x40000000,
    ObjectNameExists = 0x40000000,

is most likely an error.


Yeah, I know, what bothers me is having those slow tests being listed on every run… :/


So many unused imports


When we have 300 tests you'll be glad it's there


Bad code smell : Declaring the colors and other variables again and again in the different files does not make sense.
Use a separate file which contains all the declared constant variable and import the file everywhere.


TODO?: add hidden setting cfg->fail_on_shred_miscount and add --fail-on-shred-miscount to nosetest settings;
if(session->cfg->fail_on_shred_miscount) {exit_state |= RM_SHRED_MISCOUNT;}


it wants to call : install.packages("TR8",dependencies=TRUE)


Sorry this is confusing. I accidentally deleted it then readded it. Hence the two similar commits.


Too much hard coding of positions.The program would not display the contents properly on different systems with different resolution.