I was wanting to drop the "twindad" and switch to using "msunderwd" if possible (see line 28).  If you need to retain the "twindad" for historical purposes, I (or you) can copy the information from the "msunderwd" entry.  Please advise.


+ pirscatherine20@mail.ru-activation


It doesn't hurt, there aren't that many in the system and they could be useful in the future (ie. logging or if we need need a specific component).

But now that you mention it, topology_matches() should be using the separate fields and it explains why CTS is currently failing.


Update


What's the motivation for this? IIRC I deliberately chose not to use cover_as_data to avoid excessive memory usage when sending lots of books at once.


README


Ah right, I had removed this as part of 8b494641b, probably should have left it in.


I agree that `debanding` could improve visual quality for almost all anime content, but it really does more harm for video with heavy film grains. It's not about improving quality, it's just not the **correct** way to do video rendering.

The `deband` shader is essentially a low pass filter, and tends to smooth the gradient for reasonable parts. But no matter how great it works in practise, it's still a smooth filter and will remove/weaken details here and there.

Here is another scenario, suppose I rendered a short CGI video and stored it **losslessly**, I'm sure there is no banding caused by video compression or post-production. In this case, a default setting will simply bring degration.


I was wondering, perhaps always forwarding any given parameter would be better... Something like:
```javascript
var command = process.argv.slice(2);
command.unshift(pkg.config.ghooks[hook]);
return command.join(' ');
```
The usage withing `package.json` remains the same. This way the only code that knows anything about given parameters would be the final script interested in parameters.
Does it make sense (or even work)?


Because I blindly copied the code from the other function :)


@rauchg current master 7e77dd511ec764c489f0fce065cdee6f06387ccf loses dependency `"base64id": "0.1.0"`, `v1.5.4` has this. https://github.com/socketio/engine.io/blob/6032a13cbeb45641cf0321c7fdf48d6e2ecec757/package.json#L27
This brings failed test on `engine.io-client` https://travis-ci.org/socketio/engine.io-client/builds/79565709


The changes in this commit seem unrelated to the rest of this PR. Would you mind moving these changes to their own PR with a good description?


@ThomasBurleson I'm also interested to know why change from attributes to classes. Don't really mind the change, just curious.


Please check this out, @casey-collab


Because test was taking too long and build was failing. @caspg is working on it


Minor: Since this Hash is pretty short, I'd probably keep it all on one line.


`web.xml` относится к сервлетам и всему такому прочему. Его действительно можно заменить (не все, но бОльшую часть) на джава конфигурацию -- нужно реализовать интерфейс `WebApplicationInitizlizer` (как-то так). Spring предоставляет базовые и удобные реализции этого интерфейса, например, `AbstractAnnotationConfigDispatcherServletInitializer` которые ты и использовал.


thanks!


(y)


@plaindocs this is unrelated to #354 - I'll follow-up there :)


hab den adminbereich glaub letztens auch nciht mit gepusht.
war grad dabei es so wie du zu machen, bin nur zu langsam :-1:
nur das ich dort noch Avatar und Datum ausschalten lasse.
werde es bei deinem ergänzen :)
ein Fehler hat ich bei mir sogesehen... hab nicht dir config tabelle dafür genutzt, sonder eine cfg_comment angelegt... deine Lösung ist da doch besser :)


I would use a method for all these DefaultIssue creation these days, feels it improves readability a lot


Why did we say this?
[test]


I think the commit message and new test name aren't quite right, because the change is to restrict the classes of exception that are rescued; exceptions other than `InvalidResponse` are not **re-raised**, they are just no longer **rescued**.


Okay das wusste ich nicht ;) sry
und ja wir nutzen die config anstatt für alles eine neue Tabelle anzulegen


Since you are touching this code, could you please move to using the new hosting api? I'd like to remove the obsolete ExecuteAssembly interface soon and dnx is the only remaining user of it.
The change is pretty straightforward, the ExecuteAssembly is effectively split into coreclr_initialize / coreclr_execute_assembly / coreclr_shutdown, each taking portion of the parameters that the original ExecuteAssembly was getting. See this:
https://github.com/dotnet/coreclr/blob/master/src/coreclr/hosts/unixcoreruncommon/coreruncommon.cpp#L204


Попробуй использовать `query()` вместо `queryForObject()`.


misses javadoc and "@throws IllegalStateException if the holder is not initialized yet" with implementation


misses javadoc and "@throws IllegalStateException if the holder is not initialized yet"


Item has been implemented.


Ok, to olewamy. TODO zostawię, może potem dodam jakby mnie zaczęło to irytować przy używaniu.


Thanks, didn't know that existed.


I think it would be worth explaining why you no longer need the "Please enter a complete date" exception message. I believe it's because the exception message is never surfaced to the user - it's supposed to be a key used to look up a "translation" for the error.


Hi Brad,

There's a spurious semi-colon in:

    #define TRACEANGLE 0xC000000;

Doesn't cause any issues at present since it's only used at the end of a line....

Jeff


if "end" variable is zero - "finish" should be empty


 redef/patron-client/views/index.hbs change should have been separate commit...
it fixes the labels on patron-client items


How are the keys separated? With spaces? What happens if they is a key number like 1161 or 2116? This would then match, too?

Shouldn't this be "116 *|* 116|116" or so?


format should now be duo:format


Where'd that come from? Thanks Jeff! :grin:


I have implemented this code on my localhost and got this

"The specified member name is either invalid or empty."

I have no idea what going on wrong with the code that you have mentioned.

Please help me ASAP.


this is different operations with their own errors


well, just drop a full and a damaged graphite electrode into the AE system and see if you get them both out again in certain orders of insertion and extraction to be sure :)

i would do so if i where home XD but i remmeber that you can not get an IC2 turning blank out of the AE once you inserted a few, because the item shown and the item in your system are technically not the same as AE supposes  only short values as damage values, but you return the double value on getDamage


I've just updated mine to use a #define, so you can see the history!


I have just checked out the previous commit and add a cout at line 78 to print the size of both pitchFiltered and modifiedPitchConfidence. modifiedPitchConfidence ended double the size of pitchFiltered and the first half was all zeros.

I'm not good at C++, so I cannot give a better answer.


do i need to get involved here or is it you and lea?


This feature hide the subscribers and preview tab in the Campaign plugin.


The default in autotools is not to strip executables when doing make install, but only when doing make install-strip. Not doing that confuses a lot of automated build systems like source based package managers or tools that build packages automatically. It would be very nice if you could pull this.


You should review the PR instead of this commit.

https://github.com/aspnet/dnx/pull/2665/files

I think that's alrady been done.


ok


Tak, i nie za bardzo ma być. To taki temp-ficzer żeby było widać, że działa. Jak dorobię jakieś aplikacje (np. prosty shell) to będą same się bawiły w odpytywanie o stan klawiszy i pisanie po ekranie. Nie ma sensu tego poprawiać jak i tak zaraz to wyleci z kodu.


Не, короче. Я понял, дело в сигнатурах. Ты можешь использовать либо метод `T queryForObject(String sql, Map<String,?> paramMap, RowMapper<T> rowMapper)` тогда надо `Map` сделать типизированным) либо `T queryForObject(String sql, SqlParameterSource paramSource, RowMapper<T> rowMapper)` (тогда надо мапу обернуть в `SqlParameterSource`).


`query()` с данной сигнатурой будет возвращать list, а не объект. Я разобрался в чем проблема. Вот верный вариант:
![image](https://cloud.githubusercontent.com/assets/13660819/9785783/6f1345a0-57bd-11e5-8c32-8ad5bed12c13.png)
Но код значительно увеличился, добавился `RowMapper`, неужели это стоит того?


It might be easier to handle this in a mode where `topicgroup` elements are ignored.


P.S. Общее правило -- всегда старайся использовать типизированные контейнера/структуры (никаих `Map` или `List`).


Well, it was already possible with beforeSend event.


Zgadzam się, ale wygląda na to że tak jest przesyłany print screen (patrz osdev: http://wiki.osdev.org/PS/2_Keyboard). Ciekawi mnie czy jest sytuacja w której może któraś z tych połówek kodu polecieć osobno i czy ma jakieś znaczenie. Ale pewnie nie może.


I also don't see much point in blinking. People are used to refiling in general, and it never blinks. I think, we can safely remove this option altogether. If it's not by default, I doubt anyone will be ever activating it. Then what's the point?


why the reorder?


Wow you're a machine! :) Thanks man!


Did you push this change to widgets?


排版乱了..


> @vspinu finally got the chance to finish this!

Great. Starting trying right away.


I can see you did.


missing `requireNonNull(component)`, in current state NPE stacktrace will include `componentToKey` Function call, not so much clean


Ах, я не заметил, что ты еще и интерфейс не параметризовал. Как так получилось вообще?


@achingupta

Thanks Achin. Looks good to me. Once this gets merged would push the TLK PR again.


well I expect people will try refilling calls and it won't work well because point is inside a small continuation. So they may think the function does nothing.

I'm probably overthinking this ;) I will remove the blinking


Isn't it invalid to forward declare a type that's being returned by value? I think including this file will fail if mwworld/ptr wasn't included first.


could use FluentIterable to return an ImmutableSet and remove a loop from your code :)


I dont fully understand this but it sounds right.
Also tested and it works great


We already have `unit_name_template()` doing exactly this, no?


"for the specified" => "and the specified"


Indeed. it's bound to `r` in magit btw.


获取翻译结果


using FluentIterable, you would return an ImmutableSet and remove a loop from your code :)


I'm sorry - it looks like you're right. Good catch!


See CODING_STYLE: we place opening bracket on same line as function name.


Ну... вот  как-то так получилось :) Главное нашел в чем проблема.


you can inline call to requireNonNull

```java
this.key = requireNonNull(key, "key cannot be null");
```


The signal handler does not need to be a member function.
Please reuse a “plain old function” (with C linkage) here.


@stevenheidel @williamboxhall Sorry, I pushed this directly to master by mistake. Please let me know if you have objections. The travis build will continue building for 2.10 and 2.11.


`path_exists()` should just be `access(..., F_OK)`, no?


>Но код значительно увеличился, добавился RowMapper, неужели это стоит того?

IMHO увеличился он не сильно. Стоит или нет решать тебе -- ты можешь попробовать использовать `BeanPropertyRowMapper`, как и раньше, но имей ввиду, что `this class is designed to provide convenience rather than high performance. For best performance, consider using a custom RowMapper implementation`. Т.е. он удобный, но не самый быстрый. Впрочем, скорее всего скорость здесь и не так важна.


single-line if blocks without {} please, see CODING_STYLE


Thank You Sir,
  When I change  return value,
  [[self.DLDataArray objectAtIndex:index] float Value];
 Slice  showing round of value like 77.69 it show 78 and 22.3 to 22,How to set exact float value .?


commit message does not explain why making the class an interface is required, would be nice


@emilyrose can you confirm this fix is good to go?


This tool needs to be able to add entries to the metadata table as part of the process.


missing `@CheckForNull`?


forget it, it's there, just not right above because of the diff display


missing javadoc, what does this implementation provide compared to a production implementation?


这是md源码。。。。你得去看最终样式。。。。

2015年9月10日星期四，linzuxiong <notifications@github.com> 写道：

> 排版乱了..
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wandoulabs/codis/commit/b5038cccbe0982d69cc26935d306128dac3c4d09#commitcomment-13156176>
> .
>

--
Best Regards,
杨哲


Puts, sério? Você tentou deixar o `tipos` **exatamente** assim?
`tipos = "text/csv,audio/wav,audio/x-wav,image/jpeg,application/octet-stream"`
Será que é diferença na versão do FF? Seu último código está comitado? Posso testar de novo como ele.


Misspelling?


In this commit message, I had said:

```
- removes SSH access from transition-logs-1, which I think I'm wrong about,
  since I reckon it needs to be in there as the machine will exist in
  Carrenza, I think.
```

In reality, I was right, since transition logs aren't a thing that will exist in Carrenza; only in Skyscape.


same issue


# also cab be the comment


same


Nice edits!


Есть еще вариант все эти `RowMapper`-ы вынести в отдельный класс и вообще заменить на методы. См. для примера:
- https://github.com/php-coder/mystamps/blob/04a82400da9c8423ef57ebbc86de55cffb62adf1/src/main/java/ru/mystamps/web/dao/impl/JdbcSeriesDaoImpl.java#L121
- https://github.com/php-coder/mystamps/blob/04a82400da9c8423ef57ebbc86de55cffb62adf1/src/main/java/ru/mystamps/web/dao/impl/RowMappers.java#L72


Done


missing override of method `before` or `after` from `Resource` which resets the state
this rule would not work with `@DataProvider` for example


@dkatzberg You have to set `"index" : "not_analyzed"` in order to set fields to not analyzed. No analyzer means standard analyzer!


Goed bezig!


could use `Preconditions.checkArgument`


@Jenselme thanks for this. Any chance we can add a unit test to ensure this works over time?


Decided it should be an error if sortOrder is provided but sortBy is not.


2.3.5 is minimal, but 2.4.0 contains some useful fixes


MUSIC doesn't depend on Boost, does it?


Первый вариант IMHO был лучше.


Space inside } missing.<br>Space inside parentheses detected.


А зачем скобочки добавили? Ведь и без них работать должно.


Should add a toString() method here to aid debugging and so that any test failures will have useful output.


Зачем конструктор по умолчанию? В данном случае, можно не указывать.


2.4.0 has bugs and blockers for users usage


you should be able to add `getAddedRawRuleMeasure(Component, String)` to the Rule


lgtm, I'm not sure if "narrow" is the right expression for that. Though I don't know anything much better, the examples make it very clear.


ae


의미를 알 수 있는 변수 이름을 쓰는 것이 좋겠습니다.


test


>> On Thu, Sep 10 2015 03:16, Lionel Henry wrote:

> I will remove the blinking

I have just tried it and it doesn't look bad with my theme.

So indeed, if it can create confusions then maybe we should keep it. Similarly
how we keep blinking during the evaluation. Sometimes the evaluated portion of
code is not what the user intends to evaluate. If this is similar, let's keep
it.


No use of flag as you are returning location as -1 if not found and index if found.


> On 9 Sep 2015, at 21:46, msunderwd <notifications@github.com> wrote:
>
> I was wanting to drop the "twindad" and switch to using "msunderwd" if possible (see line 28). If you need to retain the "twindad" for historical purposes, I (or you) can copy the information from the "msunderwd" entry. Please advise.

This file needs to know the SourceForge username (in your case twinned) and to map it to a name and email address (not to a GitHub user account). Please update your working copy and submit a pull request to incorporate your change into the JMRI/contributors project.

Randall Wood
Alexandria Software
202.683.8604
randall.h.wood@alexandriasoftware.com
http://www.alexandriasoftware.com


The license is GPL


raah! I so much hate this xml files!

Impossible to know what is the setup for this test without looking at a hard-to-read-and-maintain external file


Who is John Doe?


Wrong project


In that case, you can ignore this file entirely. It's only relevant during the migration.


Maybe you can try SHA1withECDSA.


Зачем 2 базы данных? HSQL нам не нужна.


AddStuffToUI2 (kbenne) - i386-Windows-7-VisualStudio-12: OK (2323 of 2342 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.19%25-yellow.svg)


Атрибут `commandName` устарел, используйте `modelAttribute`.


Check out the updates to the LED driver and HAL on my GitHub. Blink support should be working.


why this line return?


`language="java"` указывать не нужно. Абсолютно бесполезный атрибут.


Заголовок не указан.


I tried using the LNX.LA.3.7.2 camera stack and camera HAL but it still didn't work. Do you have an idea what's wrong with that?


Пустое содержимое. Пока не ясно зачем эта пустная страница нужна.


I specifically set this to the materials tab for a reason.


Надо настроить IDEA, чтобы добавляла перевод строки в конец файла.


A `!` got lost here, no?


Per the build output this is already done for us:

WARNING: Dependency commons-logging:commons-logging:1.1.3 is ignored for debug as it may be conflicting with the internal version provided by Android.

I can make it explicit to avoid the warning though.


This one seems unnecessary...


`language="java"` не нужен.


Why final, I want other blocks to have tooltips as well, the grate for instance.


just installed the beta of El Capitan and I can report that El Cap is stating `to run java on the commandline you need to install a java developer package`. "More Information" button is now redirecting to http://www.oracle.com/technetwork/java/javase/downloads/index.html

This is an improvement at least...


Так конечно писать можно, если вам платят за количество строк кода :) В жиизни же смысла не много -- лучше в одну строчку и без лишних `{`/`}`.


Write test case if element not found


This needs to check the status code


Here are a couple of issues (not sure if these were not deliberate).

```

ind <- df[, list(N = .N,
                 Ncntr = ulen(country),
                 Nuniq = ulen(get(secondary_id)),
                 cad_mean = mean(cad, na.rm = T),
                 cdur_mean = mean(cdur, na.rm = T)),
          by = primary_id]
```

with C-u will be refilled into

```

ind <- df[, list(
    N = .N,
    Ncntr = ulen(country),
    Nuniq = ulen(get(secondary_id)),
    cad_mean = mean(cad, na.rm = T),
    cdur_mean = mean(cdur, na.rm = T)
),
          by = primary_id]
```

I think refilling should not insert new line after opening delim if it's not already there. Also the new line before last `)` is questionable. The last line `by = ..` is not automatically indented after the refill.


Style nitpicking: `if( exts == NULL )`


Done


Why did you get rid of this method?


Style nitpicking: `while( exts != NULL )`


I appreciate the effort, but I'd like to do this myself.


See f946016cc87c0e3b8a7654431dd80aa84cbcf617


Possibly should log result here


А зачем здесь делать `Integer.valueOf()`? У вас поле `age` объявлено как `String` что ли? Объявите его `Integer` да и все.


Style nitpicking: `return( mbedtls_x509write_crt_set_extenstin( ... ) );`


Now I see the mistake I made. I put PackageConfig under CMake/common/ instead of CMake/, so it wasn't commited in my previous fix.

The file that I originally added has this content:

    mark_as_advanced(MUSIC_PACKAGE_VERSION)

    set(CPACK_PACKAGE_VENDOR "www.incf.org")
    set(CPACK_PACKAGE_CONTACT "Mikael Djurfeldt <mikael@djurfeldt.com>")
    set(CPACK_PACKAGE_LICENSE "GPL3")
    set(CPACK_RESOURCE_FILE_LICENSE ${PROJECT_SOURCE_DIR}/COPYING)
    set(CPACK_RESOURCE_FILE_README ${PROJECT_SOURCE_DIR}/README)

    include(CommonCPack)
    include(OSSCPack)

With the extra variables there's no need to add a LICENSE.txt file. The added file is redundant because the GPL license is already in COPYING.

However, if we're not going to build any deb or rpm packages I think it's even better to not include this file and only include CommonPackageConfig.cmake.


Нет смысла делать `else` после того как выше делается `return`.


{} is true for ```#empty?``` so there's no need to check ```item``` against both values:

```reject { |item| item.empty? }```

is enough.


copy is supposed to work on all projects types, but it's tested only on PROJECT and FILE, there is holes in the UT raquette


I have fix notice issue and add version_compare function


Hi Juan,
OK, thanks for the info.

>Important: If you have made changes to your modules, please commit them
>to the PCL GitHub repo now. This way I'll work with the most recent
>version of your code.
Yes I have made some changes. I added  a new INDI mount module to support INDI mount devices. It contains a graphics control for a simple sky map to show the position of the teleskop at the sky. This might be also relevant for your  high-dpi displa adaptations. I'll commit those changes as soon as possible

> I am looking forward to the first release of your modules. When,
when? :)
;). I think I have a pre-release now. One thing I would like to add is a possibility to dump a stack trace to the UnsixSignalException class in case of crashes. I noticed that with the current compile settings I only get a pop-up in case of a crash without any details about the crash, which is not good for supportability reasons. But I think this would require changes in the UnixSignalExceptionhandler class ...

A second problem is related to the distribution of the modules. I fear that distribution by source code will lead to low adaption. I started to configure automatic deployment of linux and macos libraries from travis ci to github releases, but this will only be possible for the gcc version which are available on travis ci service. Therefore I like your idea with jit compilation of modules within PixInsight...

Thanks,
Klaus


Try to give detailed description for a class and it's methods.


UT should set manual measure on the PROJECT the PROJECT_VIEW references and make sure they are copied to the PROJECT_VIEW, isn't?


I find I have pushed it already. You could pull again. The commit log is following.

commit 48c6c491ff557eb6a8984bb4e8dc8f056c474ebc
Author: fgao <gfree.wind@gmail.com>
Date:   Sat Sep 5 09:44:01 2015 -0700

    Fix the network down issue when up and down imq interface


Ah, je pense qu'on mélange barré et décalage le long du manche.
Et du coup, il faut peut-être ajouter 1 au base-fret...


1. Implementing `method_missing` and `respond_to_missing?` without calling `super` looks bad. It simply deactivates `Mash` implementation `method_missing` and `respond_to_missing?` so in this point your class is not a `Mash` anymore :)
2. Simply adding calls to `super` doesn't solve the problem (rspec results are the same) but you should always call `super` in these methods. Don't forget about it.
3. Example itself seems strange, not the behavior of `SafeAssignment`. Example just doesn't look real. For example, `x_name` and `x_name =` do the same thing — they return `true`. You say it's just an example for tests but you know one could write many more *strange* examples that may make look ugly anything :)
4. And now (it's just my guess) how your example should really look like:

```ruby
   context 'method_missing' do
     class MashWithSafeAssignmentMethodMissing < Hashie::Mash
       include Hashie::Extensions::Mash::SafeAssignment

       CUSTOM_READER_REGEX = /^x_([[:alpha:]]+)$/
       CUSTOM_WRITER_REGEX = /^x_([[:alpha:]]+)=$/

       def initialize(hash = {})
         regular_hash = {}
         hash.each do |key, value|
           name = key.to_s
           if name =~ CUSTOM_READER_REGEX
             very_custom_writer($~[1], value)
           else
             regular_hash[key] = value
           end
         end
         super(regular_hash)
       end

       def method_missing(method_name, *args, &block)
         name = method_name.to_s
         return very_custom_reader($~[1]) if name =~ CUSTOM_READER_REGEX
         return very_custom_writer($~[1], args.first) if name =~ CUSTOM_WRITER_REGEX
         super(method_name, *args, &block)
       end

       def respond_to_missing?(method_name, include_all = true)
         name = method_name.to_s
         return true if (name =~ CUSTOM_READER_REGEX) || (name =~ CUSTOM_WRITER_REGEX)
         super
       end

       def []=(key, value)
         name = key.to_s
         return very_custom_writer($~[1], value) if name =~ CUSTOM_READER_REGEX
         super
       end

       def very_custom_writer(key, value)
         # TODO: implement your writer
         puts "custom write [#{key}] = #{value}"
         true
       end

       def very_custom_reader(key)
         # TODO: implement your reader
         puts "custom read [#{key}]"
         true
       end
     end

     subject { MashWithSafeAssignmentMethodMissing.new }

     specify 'does it work' do
       expect { MashWithSafeAssignmentMethodMissing.new(x_name: 123123) }.not_to raise_error

       expect(subject).to be_respond_to(:x_name)
       expect(subject.x_name).to be_truthy
       expect { subject[:x_name] = :eh }.not_to raise_error
       expect { subject.x_name = :eh }.not_to raise_error

       expect { subject[:initialize] = :eh }.to raise_error(ArgumentError)
       expect { subject.initialize = :eh }.to raise_error(ArgumentError)

       expect { subject[:zip] = :eh }.to raise_error(ArgumentError)
       expect { subject.zip = :eh }.to raise_error(ArgumentError)
     end
   end
```

The key point here that since you expect `x_something=...` and `[:x_something]=...` work the same then just do it! You forgot to implement custom `[]=` too. `Mash` doesn't know anything about that your intention.

The problem here is that implementation is a kind of cumbersome. But I did it intentionally to demonstrate how it exactly works: you should care not only about accessor methods but about `[]=` and `initialize` too. Okay, lets improve it:

```ruby
     class MashWithSafeAssignmentMethodMissing < Hashie::Mash
       include Hashie::Extensions::Mash::SafeAssignment

       CUSTOM_REGEX = /^x_([[:alpha:]]+)$/

       def method_missing(method_name, *args, &block)
         name = method_name.to_s
         return very_custom_reader($~[1]) if name =~ CUSTOM_REGEX
         super(method_name, *args, &block)
       end

       def respond_to_missing?(method_name, include_all = true)
         name = method_name.to_s
         return true if name =~ CUSTOM_REGEX
         super
       end

       def custom_writer(key, *args)
         name = key.to_s
         return very_custom_writer($~[1], args.first) if name =~ CUSTOM_REGEX
         super
       end

       def very_custom_writer(key, value)
         # TODO: implement your writer
         puts "custom write [#{key}] = #{value}"
         true
       end

       def very_custom_reader(key)
         # TODO: implement your reader
         puts "custom read [#{key}]"
         true
       end
     end
```

So to bypass `ArgumentError` for `x_*` names just override `custom_writer` and that's all.


OK


isn't this commit a fix for the email you sent and which @teryk will think tomorrow he has to fix?


Even more style nitpicking: why not use `MBEDTLS_ASN1_CHK_ADD()` here and below?


ok


indeed


hmm... This was intentional. The intent is to go from normal refilling, indented with `ess-offset-arguments`, to the kind of refilling that would be indented with `ess-offset-arguments-newline`.

The thing is that it depends on the coding style. The current C-U behaviour is great to work with the dplyr DSL for example. We should think about a consistent scheme to customise this.

> The last line by = .. is not automatically indented after the refill.

Ah yes maybe I should check the surroundings and reindent the whole region. But where should we stop? At top-level? I think it would be confusing to have a large area of the buffer reindented when the user only wants to refill a small section. What do you think?


dac


awesome


In which case, we can make it just `reject(&:empty?)`!


cool :)
This is from the migrations I ran, so idk


> We should think about a consistent scheme to customise this.

That could take the form of a list of symbols describing the kind of action desired for each prefix depth.


Ok, I was expected this feedback as I've tried but didn't success :). I'll try again and ask you to help me if needed.


All these specs pass fine for my original implementation and refactored one:

```ruby
       expect { MashWithSafeAssignmentMethodMissing.new(x_name: 123123) }.not_to raise_error

       expect(subject).to be_respond_to(:x_name)
       expect(subject.x_name).to be_truthy
       expect { subject[:x_name] = :eh }.not_to raise_error
       expect { subject.x_name = :eh }.not_to raise_error

       expect { subject[:initialize] = :eh }.to raise_error(ArgumentError)
       expect { subject.initialize = :eh }.to raise_error(ArgumentError)

       expect { subject[:zip] = :eh }.to raise_error(ArgumentError)
       expect { subject.zip = :eh }.to raise_error(ArgumentError)
```


oh ok !


indeed !


This question is not relevant to the pull request, so I would suggest to move it out, so we can get this pull request done, and discuss the question of scope naming separately.


Офигенно! Достаточно будет запихивать картинки и они автоматом подцепятся?


Ignore this comment - didn't realise `abspath()` involves `normpath()` anyway...


did you consider using http://api.rubyonrails.org/classes/ActionView/Helpers/DateHelper.html#method-i-time_ago_in_words ?


Done


If it makes testing easier maybe you could maybe also rename the method to something like `set_system_locale`.


This isn't cool..


Thanks for pointing this out, fixed in cf7585f79bb337e1b2ad9d49754cb17093e94dc4


In fact it was not required, I've done it only for the beauty :).


**Notes regarding this commit**
If it gets compiled as usual symlinks pointing to binary `lxqt-sudo` don't get created (regarding the man pages they do). Unlike with c5a129f the problem described in lxde/lxqt#777 can't be seen any longer. Still can't get it to play nicely with PCManFM-Qt, in fact no GUI comes up whatever is set in Preferences - Advanced.
Using sudo as backend the time a password is valid per shell session as defined by sudoers option timestamp_timeout (default 5min) isn't respected any longer and the password has to be filed upon each launch from the same shell session.

**Some findings independent from this commit while at it**
Using su as backend there seems to be some confusion regarding $HOME. E. g. if `lxqt-sudo --su juffed &` is invoked settings are saved in `/home/<user>/juff/juffed.ini` but `~/.config/juff/{session/*,juffed.log}` are modified in `/root`.
auto-completion of the command invoked by lxqt-sudo, e. g. `lxqt-sudo juff` + `Tab` doesn't work.


In fact it was for consistency for other classes (Issue, Component, Rule, etc.)


Hmpf, I don't like this check, neither here nor in `start_special()`... At first it wasn't clear to me at all what this is about, and it took me a while searching around in git to figure out what this was about.

Could you rework this to become more verbose like this:

```
if (r >= 0)
        return r;
if (IN_SET(r, -EOPNOTSUPP, -EINPROGRESS))
        /* Reboot/shutdown operation is not supported by the system/logind, or already in progress */
        return r;
/* On all other errors, try via the low-level operation */
```

This of course does not change anything, but through the comments and splitting up of the if checks makes this far more readable. The same comments should then be addded to the start_special() invocation


This bloody file...


А почему так хитро вызываешь метод класса? ` RowMappers::forSeriesInfoDto`


This implementation bring nothing compared to production, but as it's used in the View plugin, I prefer to have a dedicated class in case the prod code evolve and would force to update the View plugin.
Having a rule should prevent such update.


> CMAKEMODDIR may be changed CYGCMAKE_ARGS, this seems to be be easier than patching

Thanks. I'll fix it.

> I don't understand why's lexical_cast chunk needed: before it used std::to_string which is as I know not available on some compilers; however now it uses very basic std::string construction and concatenation which doesn't even require c++11

I misunderstood. I'll fix it.


*this value can be set to* **false** *to automatically...*


indeed !


What the point ?


yep


ok,continue


Apart from the one minor comment about the Javadoc, these changes look good to me


I named them

  rbd_journal_object_flush_interval
  rbd_journal_object_flush_bytes
  rbd_journal_object_flush_age

Do you like these names and the description?


 >>  We should think about a consistent scheme to customise this.

>That could take the form of a list of symbols describing the kind of action desired for each prefix depth.

What prefix do you mean?

These sort of things can get hairy very fast. Maybe have multiple prefixes C-u, C-u C-u, ... in increasing agresiveness? Then have a list of  allowed modification for each level.

> Ah yes maybe I should check the surroundings and reindent the whole region. But where should we stop?

Code should be eventually reindented anyways. Earlier we do it, less burden on the user. This is why blinking could be handy. It blinks only the refill region, but the indented region could be much bigger.


Yes, I know, I was too lazy to refactor it...


This implementation is problematic because the default class will match any String that's not something else registered.

I think you should go with something like
```
private static String NULL_TYPE = "__null";
// ---
if (type == null) {
    type = NULL_TYPE;
} else if (NULL_TYPE.equals(type)) {
    throw new IllegalArgumentException();
}
```


...and here do nothing.


Same answer as previous comment...


@Brit200313 Here's the latest...

Thanks for your help


No, it's not the case. Custom measures are not copied on project view, it's not required for the moment.


Which one ? I've only updated the uuid of the project from PROJECT1 to PROJECT


Do not know, was already there, I can remove it


ОК
Буду подчищать лишние разбиения на строки


The recommendation is definitely to update this.

Does the regexp on line 124 in /tools/pirus_pingbackd need this adding or will the current one pick it up even without the dx?


Add comments to the sections of this test


No, I've send an email as the ui display the menu to add a custom measure.


instead of sticking that to `$('.assignments-datatable')`, maybe you could just add `datatable` class to the container and the same thing would be applied automatically? see `data_tables.coffee` file


There are no `_CPPFLAGS` for those because `PKG_CHECK_MODULES` only set `_CFLAGS` (the `.pc` file only have one setting for `CFLAGS`).


Для вывода проброшенного значения


abstract protected function request();

Seems like it should be public, because otherwise how it will be called?


Ah indeed, you've found a typo. A patch fixing this is in now in review.

Regarding impact, I don't think this had the potential to break the sensor powerup. But anyway, the fix should hit github soon.


Sounds good.


userEmail property  in newWords model shouldn't be public


I was not aware about this functionality! Done. Also, I renamed options like rbd_journal_default_order to rbd_journal_order (removed 'default' part): it was ok in config option names, but in image metadata i think it looks confusing.


but its working when its private) and its private in basic class, but in extending classes its public..


@jameskoster I was on 4.2.4, updating to 4.3 hides the button indeed.
Might be worth adding a line of CSS for that.


Sure, I can take a look. I just wanted to make sure it was not something
expected to behave differently.

On 9/10/15 3:01 AM, Ola Bini wrote:
> Both of these failures are quite hard for me to debug since they work
> fine in a linux environment and I have no Mac to test.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/twstrike/tor/commit/b0501b7be7774878b9ee31e3fa82260d0b90717b#commitcomment-13153677>.
>

--
*Reinaldo de Souza Jr* | Software Developer
*Thought*Works Brasil


На версии с тегом n6_corrected - уже выводятся данные, хотя заголовок страницы так и не заполнен.


It is possible to set request headers through the beforeSend event, you're right.  However, this would effectively set the same request headers for every request.  This would not be desirable if you need to set different request headers for different requests.


Я так понимаю, что просто забыл. В нетбинсе шифт+контрл+i делают импорты правильными.


At this point the only maintenance I'm doing is moving this horribly shitty code around to make sure it still runs on server without crashing too much. I could rewrite the whole project so it works properly and it'd probably take me much less time than what it took us in the first place but if I had time for projects like this, I have few in the pipeline that could actually bring me some coin.


Немного странное решение. Лучше следующий и предыдущий оставить налами (null)


After changes simulation output is consistent with the output before modifications. Commencing addition of electron module.


получается, что в пустом списке у тебя уже есть один элемент, хотя и не содержащий значения. Но он так и останется пустым навсегда.


I was using this script as `extension:translate bixie/formmaker` and that worked great. Could you restore that?


Это method reference из Java 8: https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html


You should restrict to create protected request method in child class.
Because in that case it can't be called.

http://php.net/manual/en/language.oop5.abstract.php


Any package can use `-D` switches in it `CFLAGS`, and pkg-config will pass them to us.

You said this change is needed because of some change in GObject introspection tools? Is there a commit I can look at?


**ВАЖНО!** Нельзя выводить значения, введенные пользователем как есть. Их нужно обязательно экранировать, иначе будут проблемы с безопасностью. См. материалы по XSS в интернете, можешь начать изучение этого вопроса с википедии: https://ru.wikipedia.org/wiki/%D0%9C%D0%B5%D0%B6%D1%81%D0%B0%D0%B9%D1%82%D0%BE%D0%B2%D1%8B%D0%B9_%D1%81%D0%BA%D1%80%D0%B8%D0%BF%D1%82%D0%B8%D0%BD%D0%B3


Still figuring out quite how to git...

Whenever I merge dev into master, the dev shows up as being behind because of the mergecommit. Attempting to fix that seems to have done this. Hrm.


В header.previous у тебя уже лежит header. Причём, так будет инициализироваться каждый узел! То есть все они будут указывать на header в своих полях next и previous. Причём на сам узел никто не будет ссылаться. Это значит, что он будет удалён сборщиком мусора!


feel free to change it


А вот это правильлно)


Now I save both the checks with and without comment/text. Only comments with text will go to mailer.
Saving the checks without comment/text, allows us to treat them equally in the view, so we don't bother the user with the difference.


Why are there two http servers? Also, I notice they take a servefiles option, and then toggle whether or not to serve files. why not just have one server that does both? (or even simpler, just put the files in the blob store and then load them by hash)


:shipit:


В чем смысл такого обилия переводов строк?


Это не обязательно, но по моему мнению `PeopleDao` выглядел бы лучше.


А уж названия пакетов-то точно лучше писать в нижнем регистре.


Сравнивать ссылочные типы нужно через equals. У этого метода есть шанс вернуть правильный результат бОльший, чем у ==. Если не совсем понимаешь почему - скажи, объясню. Можешь у Олега спросить сегодня


Unrelated to changes: I found it confusing that the [_legalisation_and_translation.govspeak.erb partial](https://github.com/alphagov/smart-answers/blob/master/lib/smart_answer_flows/marriage-abroad/_legalisation_and_translation.govspeak.erb) only has a heading in it. I think it should probably be inlined even at the expense of duplication. What do you think?


Пробела не хватает перед `{`


version changes must go in a separate vesrion bump commit, as this breaks rebasing. I use `git stash` because it makes it easy to undo the reversion with `git stash apply`


Добавь пробелов вокруг `=`, не скупись.


обнулять ссылки здесь необязательно


Для мапы из одного значения используй `Collections.singletonMap()`


Закомментированный код можно удалять.


implicit declaration of array


понимаешь, что с учётм проблем создания новых элементов, это будет верным на первой же итерации


*latitude


*slaves


*slaves, *figured out


Если без него никак не обойтись, то используй `Collections.emptyMap()`.


Молодец


I though default was 10MB? Is it 1MB?


эту строчку вообще не понял. В чём была задумка?


*queueing


Right. Thanks for spotting.


Лучше не использовать звездочку и явно указывать необходимые поля. Поможет не вытаскивать лишние поля в будущем, когда таблица будет меняться.


Why do we need all of this versus just looking at the string of the err from above like it did previously?


Shouldn't the "EKF warmup" message be visible when there's no failure and 10 seconds hasn't passed? It seems to me that only happens if there's never a failure, if one happens the previous failure message will be displayed until 10 seconds has passed.

Wouldn't this be better?:

```c++
if (gpsVelFail || numSatsFail || hAccFail || yawFail) {
  lastGpsVelFail_ms = imuSampleTime_ms;
} else {
  if (lastGpsVelFail_ms == 0) {
    // first time through, start with a failure
    lastGpsVelFail_ms = imuSampleTime_ms;
  }
  hal.util->snprintf(prearm_fail_string, sizeof(prearm_fail_string), "EKF warmup");
}


That was for uniformity. Okay, I'll drop this hunk.


Если id элемента находится в конце быстрее будет обход в обратную сторону


Okay, I'll split the checks.


Похоже, что вы забыли закоммитить эти самые скрипты..


Euh :-) je vois. Mais tu sais c'est surement pas fait pour les gens habituer aux interface graphique comme nous
C'est pour x il y a ghitub tu peux faire tous ce que tu fais avec git rien qu'en cliquant sur des bouttons pas besoin de l'invite de commande.
Bien qu'avec l'invite de commande x a l'air plus cool plus geek ;-) dans le genre pas de la rigolade


neat idea!


Shouldn't this be `>=5.2,<5.3` ?


I force-pushed this to fix the message.


:-1:  please enhance commit message


`>=5.3` ?


Кажется, оба должны быть `final`.


В `mxCell.getValue()` не обязательно находится `Node`. Нужно вставить проверку и возвращаться из метода, если это не так.


Думаю, стоит определить две локальные для цикла переменные (например, `xPosition`, `yPosition`), и задавать им значение в зависимости от `i`. А вызов `graph.insertVertex()` сделать один.


would deserve a better commit message :+1:


Search.php sets its own `searchstring`, then calls `search()` in Normal.php which sets its `searchstring` to the same thing. So whilst this code change makes sense to do anyway (and should also presumably alter the code to not bother setting searchstring more than once to the same thing), I don't think it actually changes any functionality – pid is being passed through on the live site fine, as far as I can see on e.g. http://www.theyworkforyou.com/search/?q=the&pid=10001 .


Hi Feng

now i build new image with this changes and run in test server
Machine work great for moment i wait one day and move to high load machine to test them.
after 2-3 day i write you status
m.


Just to confirm this branch does work on Windows and it's worth merging into Master. Although I had to change my bash.exe path to the one in cygwin (ie. r"C:\cygwin64\bin\bash"). I also had to comment out the assert to allow this branch to work in Jupyter on Windows. Thanks!


the problem here is that now also 'check-dictionary' is a target dependency (which is naturally good) but with the '$^' in the sed command it tries to output all target dependencies to sed which fails as there is no check-dictionary file.
$^ needs to be replaced with $<
I'll write a patch, thanks for your time and reply! :)


А зачем это? Т.е. с одной стороны это похвально, что вы сделали немного больше чем было в задании, а с другой не так хорошо, потому что  а) не было в задании и б) потратили время и отвлеклись.

Советую придерживаться задания и сосредоточиться именно на нем. После того, как все сделаете, сможете делать любые улучшения, а пока можете их записать себе, чтобы не забыть. Советую с самого начала развивать навык "делать то, что просили". Это очень поможет на работе. А потом уже, можно будет переходить к следующим стадиям типа "предлагать что-то о чем не говорили, но, возможно, нужно".

Еще раз повторюсь, что это нужно не мне, а хороший навык для вас. Чем больше отвлечений на что-то что хочется, но чего нет в ТЗ тем больше шансов не успеть сделать вовремя или полностью то, о чем вас просили. А это отражается и на репутации, и на отношении, и на настроении, да и на оплате тоже может.


Я думал вам потом дать подобную задачку, но на прикручивание веб-сервлета..


Ok, I need your help :)


Hi Klaus,

 > I think I have a pre-release now.

Then if we could release it, through the normal update repo or through
update-devel, at your option, it would be fantastic. Let me know!

 > But I think this would require changes in the
 > UnixSignalExceptionhandler class ...

If you want to make such changes, please feel free. A back trace
functionality would be great.

 > A second problem is related to the distribution of the modules.

So far I build all modules for all supported platforms, test them, and
distribute them as binaries from our official update repositories
(update.pixinsight.com, etc). The integrated C++ compiler will provide
truly multiplatform C++ development, which will be very nice. In the
meanwhile, we'll have to continue with centralized binary builds and
updates, as usual. FYI, I have updated all of our development machines
to Redhat EL 7.1. After some benchmarking with GCC 4.8, 4.9 and 5.2, I
have decided to use the default RHEL7 GCC version, which is 4.8.3, for
the official distribution. However, the next Linux version of PixInsight
1.8.4 will be compatible with binaries built with any GCC version from
4.8.x to 5.x.

Juan

On 09/10/2015 12:42 PM, kkretzschmar wrote:
> Hi Juan,
> OK, thanks for the info.
>
>     Important: If you have made changes to your modules, please commit them
>     to the PCL GitHub repo now. This way I'll work with the most recent
>     version of your code.
>     Yes I have made some changes. I added a new INDI mount module to
>     support INDI mount devices. It contains a graphics control for a
>     simple sky map to show the position of the teleskop at the sky. This
>     might be also relevant for your high-dpi displa adaptations. I'll
>     commit those changes as soon as possible
>
>     I am looking forward to the first release of your modules. When,
>     when? :)
>     ;). I think I have a pre-release now. One thing I would like to add
>     is a possibility to dump a stack trace to the UnsixSignalException
>     class in case of crashes. I noticed that with the current compile
>     settings I only get a pop-up in case of a crash without any details
>     about the crash, which is not good for supportability reasons. But I
>     think this would require changes in the UnixSignalExceptionhandler
>     class ...
>
> A second problem is related to the distribution of the modules. I fear
> that distribution by source code will lead to low adaption. I started to
> configure automatic deployment of linux and macos libraries from travis
> ci to github releases, but this will only be possible for the gcc
> version which are available on travis ci service. Therefore I like your
> idea with jit compilation of modules within PixInsight...
>
> Thanks,
> Klaus
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PixInsight/PCL/commit/0fe65bc60a7175b622c41cc0127398f87557d3df#commitcomment-13156604>.
>


I'm not fond of crating a fake static lib. If the goal is to remove duplication, then CATCH_HEADER should be defined in the top-level CMakeLists.txt

:-1:


Похоже, что вы случайно закоммитили ненужные импорты..


Thanks to https://github.com/whatwg/html/commit/9d4276a62d0191b98f6bceaf9e0451e478ae8b47.


Непараметризованный `Map`. Ох... ведь из каких-то интернетов, наверняка :)


aye sry didn't double chek the diff. checkout "git add -p" it's awesome ;-)


Help please !


I didn't really look at minimal version requirements yet, but you're right.


Test Comment


Checkmarx scan results 10 Sep 2015 14:17 UTC +03:00

High
Medium
Low
Info

New
36
31
37
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1fbcf9bd4a6eaff174d49ebbc626913fb0d9236e	@dudug


In case of vpc CsAddress.process is being called even before the nic was plugged in,  which i thinks should not happen. However added the additional code changes so that we skip the ip configuration if the nic is not plugged in.

Ran the tests
component/test_vpc_routers.py
component/test_routers.py
component/test_vpc_redundant.py
smoke/test_vm_life_cycle.py

test_vpc_redundant.py is failing due to a test error, all the rest of the tests passed.

nosetests --with-marvin --marvin-config=/marvin-config test/integration/component/test_vpc_redundant.py
do_vpc_test (integration.component.test_vpc_redundant.TestVPCRedundancy) ... === TestName: do_vpc_test | Status : EXCEPTION ===
ERROR
Create a redundant vpc with two networks with two vms in each network ... === TestName: test_01a_create_redundant_VPC | Status : EXCEPTION ===
ERROR

======================================================================
ERROR: do_vpc_test (integration.component.test_vpc_redundant.TestVPCRedundancy)
----------------------------------------------------------------------
TypeError: do_vpc_test() takes exactly 2 arguments (1 given)
-------------------- >> begin captured stdout << ---------------------
=== TestName: do_vpc_test | Status : EXCEPTION ===


**ВАЖНО!** Использовать нечто, что пришло от пользователя как часть SQL-запроса нельзя! Это очень распространенная ошибка, ведущая к печальным последствиям. Почитайте про SQL инъекции, например, в википедии: https://ru.wikipedia.org/wiki/%D0%92%D0%BD%D0%B5%D0%B4%D1%80%D0%B5%D0%BD%D0%B8%D0%B5_SQL-%D0%BA%D0%BE%D0%B4%D0%B0


I do not understand, maybe this is a bug in github frontend, from here it looks like you replaced the single empty line in the files with another single line...


Good idea. Done in 073128384880d9080f41164f00fc3dc4456f0ea7.


Interesting idea.  U can save a divide and get a small speedup by writing like this
```c++
  Value v =   mg_value(score) * int(me->game_phase()) * (sf + SCALE_FACTOR_NORMAL) / 2
                + eg_value(score) * int(PHASE_MIDGAME - me->game_phase()) * sf;

  v /= int(SCALE_FACTOR_NORMAL * PHASE_MIDGAME);
```


Здесь потенциальный Cross Site Scripting aka XSS.


o


> You're saying such things should be fully handled in pcap.c + pcap-win32.c?

No, such things should be handled within pcap-win32.c (which we might rename pcap-npf.c), pcap-ndiswan.c, pcap-dag.c if the DAG API is the same on Windows and various UN\*Xes or pcap-dag-win32.c if it's not, pcap-airpcap.c, and, if we ever use the NetMon driver, pcap-npfim.c.  All of those except for pcap-npf.c would declare "find all devices" and "create" routines that would be in the table of those routines in pcap.c, and pcap-npf.c would define `pcap_create_interface()`.

I.e., they'd be handled the same way that, for example, Bluetooth and USB capture are handled on Linux.

> The latter seems dead now; The *Microsoft Network Monitor* has been superseded by *Microsoft Message Analyser*. I have no idea if there is any SDK for that.

I think it might use some built-in Windows event mechanism rather than its own driver.  If not, I'm not sure how interesting it is - requiring people to install NetMon *or* Message Analyzer in order to use an application using WinPcap doesn't strike me as an advantage, unless whatever driver they install can do things that our driver can't.  I think there were some places in the Windows networking stack that knew about the NetMon ("BloodHound") driver, so there *were* things its driver could do that a third-party driver couldn't.

> Hence my desire for something that could extend libpcap more easily; a .DLL plugin feature that Dustin Johnson once started.

A ".DLL" plugin feature is of no interest, as that doesn't extend libpcap on systems that have .so's or .dylib's or .sl's, all of which we support.

A *general* plugin mechanism would be of interest, as long as we had a way of making sure that privileged code only gets to run *trusted* plugins.

If we arrange that all code that needs elevated privileges - such as code that opens BPF devices or Linux PF_PACKET sockets - runs in a separate process that doesn't load any plugins at all, that would allow the applications that use libpcap/WinPcap not to have to run with elevated privileges, which is a Good Thing as long as we can arrange either that only programs "trusted" in some sense can use libpcap/WinPcap or that, at least, the user has to give permission for the separate process to be run with the appropriate privileges (which does potentially suffer from the [dancing pigs problem](https://en.wikipedia.org/wiki/Dancing_pigs).

Yang Luo, who did the [Npcap](https://github.com/nmap/npcap) stuff, said that, at least on Windows 7 or later, Npcap can work that way, opening the capture device in a helper process run with elevated privileges; the user gets, I think, a UAC prompt to authorize that.  OS X has similar ways to authorize running as root with a GUI prompt, and some of the free-software desktop environments might have something like that, too.  I guess sudo or something like that can be done through the command line, although some Apple document says that requiring a GUI prompt is a *feature*, because it makes it harder for a malicious user who's ssh'ed in to get elevated privileges, or something such as that.

Anyway, the whole ops-vector-in-`pcap_t` and private-data-pointed-to-by-a-pointer-in-the-`pcap_t` I added is intended ultimately to be used by plugins; the goal is to arrange that the stuff in a `pcap_t` that would need to be accessed by a plugin remain at a fixed offset into the structure on any given platform, so that we can offer a stable ABI for those plugins.  The pcap core would have code to load plugins and get pointers to the routines they offer, using `dlopen()` and `dlsym()` (and `dlerror()`) on most UN\*Xes, `shl_load() and `shl_findsym()` on 32-bit HP-UX (64-bit HP-UX supports `dlopen()` and `dlsym()), and `LoadLibrary()` and `GetProcAddress()` on Windows.

I.e., built-in pcap modules and plug-in pcap modules would use the existing mechanisms, with a plug-in loader being added.


haha nice. better than booting into windows so i can run tortoisegit's patch viewer


Need to write tests


I've hopefully fixed that in b0cb4f7d4ebe443b87e19db80770af7198f90499


yep even more helpful in your case :-)

On Do., 10. Sep. 2015 at 13:33 Garrett Brown <notifications@github.com>
wrote:

> haha nice. better than booting into windows so i can run tortoisegit's
> patch viewer
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/a1rwulf/OpenELEC.tv/commit/b015d9b257777643c6692da5d551b980ed0967b1#commitcomment-13157428>
> .
>


Yes, that makes sense. The logic in line 177 was a bit confusing but I see now that `transport` cannot be `null`. I was seeing this NPE as well so I've taken your change and compiled locally -- how likely is it that a new build would be pushed to maven? I see it has been a while since the last release.


`this` is inconsistent here


For #1


Wrong title of course, should be android-5.1.1_r13 -> android-5.1.1_r14


Seems to be great, thank you :)


Not all resource loaders will be able to implement this method.  It's not appropriate for this level of abstraction because directories are directly not used by modules for resource loading.


No just us testing.
C

On Thu, Sep 10, 2015 at 12:09 PM Claire Camus <notifications@github.com>
wrote:

> do i need to get involved here or is it you and lea?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rustyb/entsoe_conf/commit/25f3080971ab938125287692317294165182ed97#commitcomment-13156088>
> .
>


한글이 더 좋겠네요


#2  @HwangYeJi  가 해야해요


@arrowrowe maybe we should add a guide for standard git workflow and how to contribute to other people/org/company's projects on github, or give a link. Github should have a link for those I guess.


table inheritance ? In MySQL ?

And sotring this in a separate table and then doing an extra join in all queries loading packages is not worth the extra work IMO. Being pragmatic is better here IMO


Great!

On Thu, Sep 10, 2015 at 9:34 PM, Michal Čihař <notifications@github.com>
wrote:

> I've hopefully fixed that in b0cb4f7
> <https://github.com/phpmyadmin/website/commit/b0cb4f7d4ebe443b87e19db80770af7198f90499>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/phpmyadmin/website/commit/f751b2625d55d93d6d4b61d384c5657578614dc6#commitcomment-13157443>
> .
>

--
Thanks and Regards,

Madhura Jayaratne


obla


:)
грешен!
Смотрел примеры  *http://www.mkyong.com/ <http://www.mkyong.com/>*

10 сентября 2015 г., 14:28 пользователь Slava Semushin <
notifications@github.com> написал:

> Непараметризованный Map. Ох... ведь из каких-то интернетов, наверняка :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AleksSPb/Spring-demo-App1/commit/0ad081ec6e14ab1ef9fb8c66f87c4e56936c0360#commitcomment-13157355>
> .
>

--
Всего наилучшего, Пархоменко Александр


1 and a 2 and a 3 macarena!


So I see how get_search_url when called from generate_pagination doesn't have access to any searchstring, but `pid` is still passed through okay as it's present in the session vars. Further discussion elsewhere.


<img width="990" alt="screen shot 2015-09-10 at 13 38 10" src="https://cloud.githubusercontent.com/assets/11146524/9787234/447b3344-57c1-11e5-85cf-068b8254c84a.png">


Just realised this should be a big if that also MCValueReleases the t_mutable copy if it fails. Sorry, maybe wasn't worth it...


did you rebase onto my branch?
because I wanted to do some cleanup of thos branch when most of the things
workout like expected.
On Do., 10. Sep. 2015 at 13:32 Wolfgang Haupt <haupt.wolfgang@gmail.com>
wrote:

> yep even more helpful in your case :-)
>
> On Do., 10. Sep. 2015 at 13:33 Garrett Brown <notifications@github.com>
> wrote:
>
>> haha nice. better than booting into windows so i can run tortoisegit's
>> patch viewer
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/a1rwulf/OpenELEC.tv/commit/b015d9b257777643c6692da5d551b980ed0967b1#commitcomment-13157428>
>> .
>>
>


You're welcome.
I'll try to design the leather & reinforced armors (used for Hunter classes).
currently, they're just invisible (both 3d & preview), we just see the model in inventory while in hand and the small inventory picture.


amand


`getAliveFlagPath` can be made `synchronized`, then aliveFlagLock can be removed


amand line


> Maybe have multiple prefixes C-u, C-u C-u, ... in increasing agresiveness?

I think, an even better UI would be repeated refil. So if I press `M-q` multiple times in a row I will get the refill cycled through the preconfigured levels.

We need to settle on the UI before the release.


Retirando os alerts


а ну ок. лишь бы работало;)


OK, I think I understand... SF username "twindad" mapped to real name "Mark
Underwood" and GitHub-associated email address (msunderwd@gmail.com)

I tried again... let me know if this is correct.  Sorry for all the churn.

- Mark

On Thu, Sep 10, 2015 at 6:31 AM Randall Wood <notifications@github.com>
wrote:

>
> > On 9 Sep 2015, at 21:46, msunderwd <notifications@github.com> wrote:
> >
> > I was wanting to drop the "twindad" and switch to using "msunderwd" if
> possible (see line 28). If you need to retain the "twindad" for historical
> purposes, I (or you) can copy the information from the "msunderwd" entry.
> Please advise.
>
> This file needs to know the SourceForge username (in your case twinned)
> and to map it to a name and email address (not to a GitHub user account).
> Please update your working copy and submit a pull request to incorporate
> your change into the JMRI/contributors project.
>
> Randall Wood
> Alexandria Software
> 202.683.8604
> randall.h.wood@alexandriasoftware.com
> http://www.alexandriasoftware.com
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/msunderwd/contributors/commit/51be80bbc3ca306752548a2314df0199a6e9e3fc#commitcomment-13156424>
> .
>


How does it look with 2 or more teams?


This doc seems like it might be inaccurate, since this *takes* an environment.


@do3cc   the problem lies from the fact that these files are minified and quite large
![tinymce-prototype-change](https://cloud.githubusercontent.com/assets/152852/9787266/f84b81aa-57c9-11e5-8933-9e4352fb4cfd.png)
I am attaching a meld diff which shows what's change.
The only way for you to see this change is if you fork my repo and to pipe git show | meld -

Given the fact that the code is all on one line github diff as well as "kompare" linux tool sees the diff change as one line changed.


Thanks @peti!

To be clear, it looks like it's been obsolete for about 3 years :)


hmm... how to implement this? check if the filling region is the same as before? That won't work if there is more than two levels.


i cherry-picked some random commits. i'll wipe the slate so you can PR against a clean branch


The phrase "a Compute Engine" sounds a little off to me. This is the closest phrasing I can derive from the tooltip in the Developers Console UI (I removed the App Engine references and tweaked the wording slightly):

"You can use this setting to store your data close to Compute Engine services hosted within a particular zone. This will reduce latency and improve availability for services in the preferred location you choose. You can either store your data in a Compute Engine zone or choose no preference."

Does that sound ok to you guys?


This is not normal, this armors was working perfectly before the merge...


perfect thanks for your effort
On Do., 10. Sep. 2015 at 13:46 Garrett Brown <notifications@github.com>
wrote:

> i cherry-picked some random commits. i'll wipe the slate so you can PR
> against a clean branch
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/a1rwulf/OpenELEC.tv/commit/b015d9b257777643c6692da5d551b980ed0967b1#commitcomment-13157668>
> .
>


nothing


我


Why not assign null here?


данный код взят из готового коммита  учебника discover meteor


One thing also is refilling of things like the new ggproto classes. They need to be:
```r
ggproto(name, parent,
  member1,
  member2
)
```
This would require specifying how many parameters should stay in the first line. I'm hoping that it's possible to parametrise a "depth prefix" (how is this really called?) with a numeric prefix, something like C-U C-U 2 *refill*, but I haven't looked into it yet.


If the data items will never change, use a plain JavaScript array. Note that modifications to the array will not be reflected in the grid.


Did you push the change?

Because git is distributed, a commit involves no network activity—it is merely a record of a change in your working copy (which can be awesomely convenient if you are, for example, working on code while on a train with spotty and slow networks). After committing the change, you need to push it to the repo(s) that should receive it (in this case the repo is https://github.com/msunderwd/contributors.git).

> On 10 Sep 2015, at 07:42, msunderwd <notifications@github.com> wrote:
>
> OK, I think I understand... SF username "twindad" mapped to real name "Mark
> Underwood" and GitHub-associated email address (msunderwd@gmail.com)
>
> I tried again... let me know if this is correct. Sorry for all the churn.
>
> - Mark
>
>
> On Thu, Sep 10, 2015 at 6:31 AM Randall Wood <notifications@github.com>
> wrote:
>
> >
> > > On 9 Sep 2015, at 21:46, msunderwd <notifications@github.com> wrote:
> > >
> > > I was wanting to drop the "twindad" and switch to using "msunderwd" if
> > possible (see line 28). If you need to retain the "twindad" for historical
> > purposes, I (or you) can copy the information from the "msunderwd" entry.
> > Please advise.
> >
> > This file needs to know the SourceForge username (in your case twinned)
> > and to map it to a name and email address (not to a GitHub user account).
> > Please update your working copy and submit a pull request to incorporate
> > your change into the JMRI/contributors project.
> >
> > Randall Wood
> > Alexandria Software
> > 202.683.8604
> > randall.h.wood@alexandriasoftware.com
> > http://www.alexandriasoftware.com
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/msunderwd/contributors/commit/51be80bbc3ca306752548a2314df0199a6e9e3fc#commitcomment-13156424>
> > .
> >
> —
> Reply to this email directly or view it on GitHub.
>

Randall Wood
Alexandria Software
202.683.8604
randall.h.wood@alexandriasoftware.com
http://www.alexandriasoftware.com


@hariharan-uno thanks dude pointing out , fixed and pushed :)


вновь код учебника discover meteor
но буду иметь ввиду


Fixed data array


Mutable data array


Опечатка в имени ветки `activitis` -> `activities`


读属性直接引用属性名就可以了，`read_attribute`是重载了那啥之后要跳过重载直接整属性用的，即便那样，也可以
直接 `some_fucking_record[:some_fucking_attribute]`
另外，写 hash 直接
```ruby
{
  id: id,
  device: device,
  size: size
}
```
就可以了...

最后呢，`some_fucking_record_instance.attributes` 直接就会给你属性数组，和你这个方法得到的结果大体上一样的


Would it make sense to condition the behaviour of this kind of refilling on the type of `ess-offset-arguments`? If it's set to `open-delim`, there is not much point to refill like this.

Meh, this gets complicated. I think I opened pandora's box again :)


Because that situation most probably mean some problems accessing temp, so we don't want to repeat attempts any more, it may lead to various bad situations.


the path to copy the authorizables.json is not displayed after configuring the IDP. Please let me know to which location should i place the  authorizables.json  file inside project .
![newpic](https://cloud.githubusercontent.com/assets/10218812/9787463/ae9d92ac-57e0-11e5-9c2c-4bc96b874964.jpg)


Перенести данный и похожие скрипты типа demo. Например этот скрипт должен быть в public/register/validation.js


meow


Перенести данный и похожие скрипты типа demo.


Hola, Cesar.

Sorry if the demo was unimpressive. We're still in early stages of being to show the power of it properly.
I'll help you with everything personally. What website would you like to build? :)


This step works on my local environment, but not on continuousphp:
```
 And the response should contain "load.js" # /home/cphp/data/container/b5556093-b5a5-4e57-a3cd-59aaea9be754/workspace/tests/features/webtools.feature:21
The string "load.js" was not found anywhere in the HTML response of the current page. (Behat\Mink\Exception\ExpectationException)
```


为啥不是 `@variants` ...


On 2015-09-10 12:39 AM, Chung-chieh Shan wrote:
>
> Is it safe to delete all the calls to TestHakaru in NewSLO.mw now?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hakaru-dev/hakaru/commit/cd3acc6649dcfa1ebe75437551ec1bed403ef3f5#commitcomment-13151311>.
>

Yes.


Удалить не используемые скрипты


其实吧，`format.json { render json: @variants }`，Rails 就会自动帮你逐个 `variant.to_json`, 然后输出 json 数组了


It would probably make more sense to simply have a field for the name.


(上接 line#9)
就像这儿这样


Thanks for the update.  I forgot to update the assembler include.  You copy/paste from the C include path.  For the FPU thing, I'll add build target to have both with and without FPU.


Удалить мертвый код


I don't think this should be a part of the core API.  Being able to create a sub-JAR resource loader is fine for JARs because it's a special case for single JAR modules; I don't see why this core API change is necessary for WildFly though, given that WildFly needs its own deployment resource loaders anyway.


это что такое


No problem, something was anyway needed to be done in case any error occurs, as we shouldn't return an invalid `StringRef`.
Just pushed a new commit


There's a word missing here.


James' keys are RSA ones. I can use an other set of keys - but isn't it complicated ?


Hmm, nice catch!

One trick we could use here instead is to change all the hyperlinks to be `/pbench/...`, dropping the leading `https://distributed-system-analysis.github.io` prefix, which would allow the links to work when deployed off of the DSA git hub site, or off of someone's personal site.

E.g. `http://distributed-system-analysis.github.io/pbench/pbench-agent.html#sec-4` becomes `/pbench/pbench-agent.html#sec-4`


Empty spaces :grin:


>Then if we could release it, through the normal update repo or through
>update-devel, at your option, it would be fantastic. Let me know!

So the procedure is: I send you the binaries and you put them on the update-repo?

>If you want to make such changes, please feel free. A back trace
>functionality would be great.

OK, I'll give it a try ;)...

>After some benchmarking with GCC 4.8, 4.9 and 5.2, I
>have decided to use the default RHEL7 GCC version, which is 4.8.3, for
>the official distribution.

Thanks for the info. Travis comes with the gcc 4.6.3 and I have even an older gcc ... I've to upgrade my systems  ;)....

Klaus


It fixes the undefined.


Используй репозирории


See #930 as I think it's better to look for the layerOptions in leafletLayers instead of newOverlayLayers.
There's a bigger chance the layer won't even be in newOverlayLayers as the entry point for this if statement is if it is not defined.

The only way it would exists is if the doRefresh is true, however the layer would also be in leafletLayers in that situation.


@fsabbah The method `get_winner` is pretty long. You could try to refactor this method and extract similar code (the 4 `@game_array` iterations) into smaller methods. What do you think?


Warum kein Datentyp für $doBibleRangeSearch?  Alle Argumente sollten *immer* einen Typ haben.


I added this patch to my experimental fork of obmenu called obmenux. The old version didn't reconfigure for me. (Lubuntu starts openbox without the path that "which openbox" returns.)


- Name the package where you put the java code, not use the default package
- The structure of exercise 2 looks very good :+1:
- The structure of exercise 3 looks good :+1: , you could use Builder pattern instead of set methods (GeneralHospital, ChildrensHospital, Clinic)


Vad är detta? O.o


С этим надо что-то придумать. Сообщения надо цеплять из validation.php


Good start, but...

a) I think you forgot a pawn_push(Us) somewhere...

b) Just in case you want to avoid penalizing twice,
    you may use the following order:

backward = (b | shift_bb<Up>(b)) & theirPawns;
if (!backward) e->backwardCandidates[Us] |= s;

c) in evaluate.cpp, you can shift up all at once
const Square Up = (Us==WHITE : DELTA_N : DELTA_S);
b = shift_bb<Up>ei.pi->candidate_backward(Us);

d) maybe exclude the pawn as blockers ?
if (pos.pieces(Them)^pos.pieces(PAWN, Them) & s)
     score -= candidateBackwardBlocked[relative_rank(Us, s)];

e) and now that s refers to a hole in front of a pawn, you would have to shift your index too.
const Score candidateBackwardBlocked[RANK_NB] = {
    S(0, 0), S(0, 0), S(33, 21), S(33, 21), S(22, 14)
 };

Good luck !


I think so... I clicked "submit a pull request" ...

https://github.com/JMRI/contributors/pull/14

???

On Thu, Sep 10, 2015 at 7:51 AM Randall Wood <notifications@github.com>
wrote:

> Did you push the change?
>
> Because git is distributed, a commit involves no network activity—it is
> merely a record of a change in your working copy (which can be awesomely
> convenient if you are, for example, working on code while on a train with
> spotty and slow networks). After committing the change, you need to push it
> to the repo(s) that should receive it (in this case the repo is
> https://github.com/msunderwd/contributors.git).
>
> > On 10 Sep 2015, at 07:42, msunderwd <notifications@github.com> wrote:
> >
> > OK, I think I understand... SF username "twindad" mapped to real name
> "Mark
> > Underwood" and GitHub-associated email address (msunderwd@gmail.com)
> >
> > I tried again... let me know if this is correct. Sorry for all the churn.
> >
> > - Mark
> >
> >
> > On Thu, Sep 10, 2015 at 6:31 AM Randall Wood <notifications@github.com>
> > wrote:
> >
> > >
> > > > On 9 Sep 2015, at 21:46, msunderwd <notifications@github.com> wrote:
> > > >
> > > > I was wanting to drop the "twindad" and switch to using "msunderwd"
> if
> > > possible (see line 28). If you need to retain the "twindad" for
> historical
> > > purposes, I (or you) can copy the information from the "msunderwd"
> entry.
> > > Please advise.
> > >
> > > This file needs to know the SourceForge username (in your case twinned)
> > > and to map it to a name and email address (not to a GitHub user
> account).
> > > Please update your working copy and submit a pull request to
> incorporate
> > > your change into the JMRI/contributors project.
> > >
> > > Randall Wood
> > > Alexandria Software
> > > 202.683.8604
> > > randall.h.wood@alexandriasoftware.com
> > > http://www.alexandriasoftware.com
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> https://github.com/msunderwd/contributors/commit/51be80bbc3ca306752548a2314df0199a6e9e3fc#commitcomment-13156424
> >
> > > .
> > >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> Randall Wood
> Alexandria Software
> 202.683.8604
> randall.h.wood@alexandriasoftware.com
> http://www.alexandriasoftware.com
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/msunderwd/contributors/commit/51be80bbc3ca306752548a2314df0199a6e9e3fc#commitcomment-13157761>
> .
>


Klassen, die später nicht generiert werden, jetzt ausgelagert in API-Lib
Also: refering to #84


Sollte das eingecheckt sein?


it 'should allow admin to delete profiles' do  could be added ...

:yum:


If I want to insert images to the Wiki, then I need to use the Wiki as a
repository as well. I had to try different things to make it work, and this
commit is the result of it. Please do not care about the commits you do not
understand. The important ones, related to the development, will be clear.

2015-09-10 11:02 GMT+02:00 Stefan Schlager <notifications@github.com>:

> What is that about? Could you please make understandable commit messages?
> What is the tiff about is this an accidental commit?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/RDFBones/RDFBones/commit/60c0ee6c286f420bcfc418b57667c172c1270c44#commitcomment-13154731>
> .
>

--
Üdv,
Dávid


That did it. Thanks.

> On 10 Sep 2015, at 08:03, Mark Underwood <notifications@github.com> wrote:
>
> I think so... I clicked "submit a pull request" ...
>
> https://github.com/JMRI/contributors/pull/14
>
> ???
>
>
> On Thu, Sep 10, 2015 at 7:51 AM Randall Wood <notifications@github.com>
> wrote:
>
> > Did you push the change?
> >
> > Because git is distributed, a commit involves no network activity—it is
> > merely a record of a change in your working copy (which can be awesomely
> > convenient if you are, for example, working on code while on a train with
> > spotty and slow networks). After committing the change, you need to push it
> > to the repo(s) that should receive it (in this case the repo is
> > https://github.com/msunderwd/contributors.git).
> >
> > > On 10 Sep 2015, at 07:42, msunderwd <notifications@github.com> wrote:
> > >
> > > OK, I think I understand... SF username "twindad" mapped to real name
> > "Mark
> > > Underwood" and GitHub-associated email address (msunderwd@gmail.com)
> > >
> > > I tried again... let me know if this is correct. Sorry for all the churn.
> > >
> > > - Mark
> > >
> > >
> > > On Thu, Sep 10, 2015 at 6:31 AM Randall Wood <notifications@github.com>
> > > wrote:
> > >
> > > >
> > > > > On 9 Sep 2015, at 21:46, msunderwd <notifications@github.com> wrote:
> > > > >
> > > > > I was wanting to drop the "twindad" and switch to using "msunderwd"
> > if
> > > > possible (see line 28). If you need to retain the "twindad" for
> > historical
> > > > purposes, I (or you) can copy the information from the "msunderwd"
> > entry.
> > > > Please advise.
> > > >
> > > > This file needs to know the SourceForge username (in your case twinned)
> > > > and to map it to a name and email address (not to a GitHub user
> > account).
> > > > Please update your working copy and submit a pull request to
> > incorporate
> > > > your change into the JMRI/contributors project.
> > > >
> > > > Randall Wood
> > > > Alexandria Software
> > > > 202.683.8604
> > > > randall.h.wood@alexandriasoftware.com
> > > > http://www.alexandriasoftware.com
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > https://github.com/msunderwd/contributors/commit/51be80bbc3ca306752548a2314df0199a6e9e3fc#commitcomment-13156424
> > >
> > > > .
> > > >
> > > —
> > > Reply to this email directly or view it on GitHub.
> > >
> >
> > Randall Wood
> > Alexandria Software
> > 202.683.8604
> > randall.h.wood@alexandriasoftware.com
> > http://www.alexandriasoftware.com
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/msunderwd/contributors/commit/51be80bbc3ca306752548a2314df0199a6e9e3fc#commitcomment-13157761>
> > .
> >
> —
> Reply to this email directly or view it on GitHub.
>

Randall Wood
Alexandria Software
202.683.8604
randall.h.wood@alexandriasoftware.com
http://www.alexandriasoftware.com


Considering I use mpv for anime most of the time, I don't mind that deband is a default option.

However it's true that the deband shader does not necessarily apply to all video content and could simply be removed from the default opengl-hq alias. People would then simply add :deband when needed.
Even if it is left as a default people that don't want it, can always negate it in their vo string with :deband=no

Either way the good thing is that it's now native and maintained within mpv.


По хорошему принял, провалидировал отдал в репозиторий


@laruence see a followup PR: https://github.com/php/php-src/pull/1514


Debug code sollte normalerweise nicht eingecheckt werden, oder gibt es da einen Grund den ich nicht verstehe?


Надо бы вынести в репозирорий


Debug-Code bitte nicht einchecken.


what about putting reference of the executor in a field? Then we can invoke methods without accessing the nodeEngine again


Репозиторий


Ok


Sorry, I hope you don't mind my commenting on things I find here.
`p2` parameter should be by-name, otherwise SOE for infinite (or large) appends.
e.g. `def as: Stream[Task, Int] = Stream.emit(1) ++ as`


ISLANDORA1350 :smile:


Lazy here too.


This has just begun - see the notes in the readme of the repos, e.g.
dstore / https://github.com/SitePen/dstore
_"Note: The master branch of dstore has been reorganized to facilitate conversion of the package to TypeScript for Dojo 2, and as such will be in a state of flux for the near future."_
https://github.com/SitePen/dstore/blob/master/src/QueryMethod.ts
You should also be aware of https://sitepen.github.io/mayhem/ ...

And just btw and especially if you speak german - just started this: https://github.com/redaktor/nlp


忽略我之前对这行的bb吧


ahem, once you merge this branch, the clutter will be included as well.
And: I care about EVERYTHING here, as you obviously pushed a wiki image into the code repo.


Объединить два роута. Передать массив ссылок наверное можно


I am not sure what the `[\s\S]` bit does, it seems it will match anything.


Убрать все лишние


Closed Visual Studio Online Task [vso#4345](https://azurecom.visualstudio.com/DefaultCollection/ACOM/_workitems#_a=edit&id=4345): 'This is a test usersnap task submission'

VSO State: Done


这个缩进好。用上 ruby 1.9+ 的 hash 新语法就更棒了。语法习俗在 https://github.com/bbatsov/ruby-style-guide ，批判吸收。


should just return "unknown" in this case? (could log at WARN level as well, but exception seems harsh)


Maybe add:
```js
else {
    return bgs[0];
}
```

That way, if `topic.defaultBackground` is not defined and bgs is empty we will have the same behavior as now (getBgByTopic which returns `undefined`), but if `topic.defaultBackground` is `undefined` and `bgs` has at least one layer, this will avoid no layer to be displayed.

It would also be easier for us as we rely on the order of the layers in the `bgs` array to get the default bg layer. Since both order and layers change with our topic, it would avoid us to defined a new variable `defaultBackground` for each topic.


- Name the package where you put the java code, not use the default package
- Structure of excercise 2 looks very good :+1:
- Structure of excercise 3 looks good :+1:, could use builder pattern instead of set methods in (GeneralHospital, ChildrensHospital, Clinic)


看到这儿，越发想问，您图啥呢？


runQueryButton selector needs to be more specific - there can be more elements on page with ".fa.fa-play" classs. Please add container selector to this.


This will work, but it would be nicer to put it in MDSRank::handle_mds_map  (where whoami != MDS_RANK_NONE is implicitly true)


@sonnygauran, hey man, appreciate your effort but you could've just asked me to publish it on bower, no problem.
Now not only I cannot do it, cause you took the package name, but you also signed it as your own work


Here a complete array should be taken instead of taking one by one element.


Your ternary if statement reads a bit awkwardly here.  This would be better written as:
```javascript
var index = this.model.has('_tempUserAnswer')
  ? this.model.get('_tempUserAnswer')[i] + 1
  : this.model.get('_userAnswer')[i] + 1;
```


@dcs619 , We're using the ForeignId field with all of our sync scripts


And that was the problem I was running into.  newOverlayLayers did not have layerOptions, so an error was thrown  - and my layer was not removed.

safeRemoveLayer checks on whether layerOptions is defined, so I just assumed that this was a reasonable way of skirting the issue.


- Wrong comment


Checkmarx scan results 10 Sep 2015 15:00 UTC +03:00

High
Medium
Low
Info

New
36
31
37
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1fbcf9bd4a6eaff174d49ebbc626913fb0d9236e	@dudug


This does require that any custom tables/models that inherit from Entity (in any plugins) be updated as well. This is a SQL script I found helpful to generate the sql needed in the plugin migrations...

	SELECT '
				Sql( @"
		DROP INDEX [IX_ForeignId] ON [dbo].[' + [name] + ']
	" );
				Sql( @"
		EXEC sp_rename
			@objname = N''[dbo].[' + [name] + '].ForeignId'',
			@newname = ''ForeignKey'',
			@objtype = ''COLUMN''
	" );
				Sql( @"
		ALTER TABLE [dbo].[' + [name] + '] ADD
			ForeignGuid uniqueidentifier null,
			ForeignId int null
	" );
				Sql( @"
		CREATE INDEX [IX_ForeignKey] ON [dbo].[' + [name] + '] (ForeignKey)
	" );
				Sql( @"
		CREATE INDEX [IX_ForeignId] ON [dbo].[' + [name] + '] (ForeignId)
	" );
				Sql( @"
		CREATE INDEX [IX_ForeignGuid] ON [dbo].[' + [name] + '] (ForeignGuid)
	" );'
	FROM sys.objects
	WHERE [type] = 'U' AND [name] LIKE '_org%'
	ORDER BY [name]

This assumes your custom tables begin with '_org'


yes that makes sense.


OK! I was going to ask you about what should I do with packages. I'll keep that in mind.

If you check exercise 3, you'll see I wrote three factory classes (GeneralHospital, ChildrensHospital, Clinic) and one builder class (PublicHospitalBuilder) to try and use both kinds of patterns.


Wrong comment


Nice


so basically, the priority of reading the terms.json is...
`troll/terms.json` (if enabled, and the key is exists)
`<language>/terms.json` (default)

i guess KC3Meta.term functionality prioritize and everything....


The first time I see it. Thanks for the comment :)


With Mercurial you can use a multitude of different workflows. This page shows some of them, including their use cases. It is intended to make it easy for beginners of version tracking to get going instantly and learn completely incrementally. It doesn't explain the concepts used, because there are already many other great resources doing that.


@FernetMenta: This fixes all my issues. GetCacheTotal does not incorporate transport time and sink hw delay that PA server reports, which might easily result in values we don't expect.


Nice catch! Thanks!


Wellicht een mogelijkheid om meerdere transports te ondersteunen, in plaats van simpelweg rsync vervangen door _plain text ftp_? Waarschijnlijk zal Iris de meest gebruikte target zijn voor uitrollen, hoewel dit niet altijd zal opgaan.

Een enkel protocol ondersteunen brengt weliswaar minder dependencies met zich mee; helaas is FTP nu niet bepaald ontworpen met veiligheid in het achterhoofd.


> Meh, this gets complicated. I think I opened pandora's box again :)

Yeh. This is stuffy. Can we do something simple, like refill only long lines and re-indent?  It's already a big improvement over what was before. Having refill not messing your code is a big thing.

> hmm... how to implement this

This should be easy. You have to check if the `last-command` is the same as `this-command`.


@lynxis "detected duplicate packet" is by olsrd6 only and also happens without the patch (meshing only).

Who uses AP+adhoc? Kathleen uses it all the time...? Or do you mean what hardware needs it? The Nexx WT3020, for example, which several people have bought - I got several requests for firmware images with this patch.

The description is just honest. If you look into detail, AP+adhoc is probably severely broken on ath9k as well. There's probably a reason that this interface combination isn't supported by the standard ath9k module but has been patched in by OpenWrt. ;) Of course it'd be good if someone looked into that, but for the time being it works well enough. As discussed on the mailing list, all this might be one of the reasons of switching to AP+mesh, as that is supported without patch.


I just noticed this.
@aancel could you rename the file in lowercase ?
filenames are(well they should) always lowercase in feel++.
thanks in advance


It is possible to implement all this outside of jboss-modules project.
But in that case I need access to JarFileResourceLoader constructor with
relativePath parameter. ATM this is not accessible via public API.
How about introducing ResourceLoaders.
createIterableJarResourceLoader(final String name, final ResourceLoader loader, final String relativePath)
method?


For what is this interface? Why it is empty?


It also creates some real problems, cause I want to maintain the project and publish the new versions, and you know how bower works, git tags and so on.
I'd suggest you unregister your fork and let me publish it myself


why ? not all features are implemented ?


name should be inputList


Någon form av php databas class skapande Java program. Förstod inte riktigt vad det handlade om man Mogge ville att jag skulle lägga det på github.


Нужно оставить что-то одно, сейчас у тебя две эквивалентные проверки


no use of above 4 params as class members


you may interest in http://yardoc.org


zusätzlich Einfluss wirkend auf: #83 und #86


OK, I'm taking it.


Why not to use KDoc comment here?


I tried `([\[\]\(\)&|]{2}|\[\s|\s\][\s\S])` and it failed to match the closing bracket when there were characters next to it, this seems to work just fine though.


Pourquoi ne pas permettre le changement de EPSG en sortie pour les shapefiles ?


Build 850 done.

@mibby We changed NCP to run without any Spigot/CraftBukkit/nms dependencies by default, at least with Eclipse (see readme.md), it would use the cbreflect compat module then. Does it still not compile with NetBeans, due to the Bukkit dependency !? Would putting the spigot repository first work?


I share just a not clear and minimize idioms:
https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Clear-and-minimize


useless comment


A bit of explanations.

We can already do:

let x := fresh "heq_" plus in intro x.

which probably leads to a hypothesis named plus0. The "plus" above is interpreted as an identifier, not as the constant plus.

But we cannot do for example:

x: nat
h: plus x x = y
=======
...

match type of h with (?f _ _ = _) => let x := fresh "heq_" f in intro x end.

Because f is bound to the constant plus and this is not supported. This patch aims at supporting constants (and other named stuff) as argument of fresh.


It seems to be the case. With gcc 4.9.2, there are compilation problems,whereas with gcc 5.1.0, I end up having linker problems instead.


what does this comment mean?


exactly. Thx


I think the problem here is, that GetCacheTotal is not designed to change after first Initialization ... normally it should return GetDelay(), too in the pa case, where the buffers can change ...


@evil-at-wow do we have these commits in 3.x version? (sorry if my question is stupid, but I don't remember seeing this being pushed to master)


For the Bukkit-API we should switch to the official Spigot repo (not md-5.net)


Instead of getProduct, could be better something like getBuilding or getHospital


Hi guys! This is blocking us as well - we'd really appreciate the merge. Thank you :)


You need collection_naming_regexes too.


> This should be easy. You have to check if the last-command is the same as this-command.

oooh


Why has `(?<!\\\\),` been changed to `(?:!\\\\),`?


This is a copy of function coerce_var_to_ident above, maybe pointless here. I am not competent.


Thanks.


En PHP on évalue les conditions de gauche à droite. Je crois que le empty devrait aller à droite.

J'ai une question sur le fonctionnement attendu. Est-ce qu'on veut exécuter le contenu du if() si :
$auth = array(); ?
$auth = array('pass'=>''); ?
$auth = array('pass'=>'password'); ?


- Name the package where you put the java code, not use the default package
- Exercise 2 looks good :+1:
- Exercise 3 is not so good, you should imporve the application of builder and factory pattern


I see your point, but I'm normally not using uppercase in this section (except for the possible names given to the exporter by the user), or did I missed something ?
Do you want me to force the lowercase ?


Checkmarx scan results 10 Sep 2015 15:11 UTC +03:00

High
Medium
Low
Info

New
36
31
37
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

1fbcf9bd4a6eaff174d49ebbc626913fb0d9236e	@dudug


added THE ability, крыса ты необразованная


:+1:  :+1:  :+1: Great idea, I didn't think about using "only", but that's what I wanted to say! Thanks!


:+1:  :+1: Thanks!


je vais décommenter la partie du "exportOutputFormat", car il me le faut pour notre service à l'interne et sa ne dérange pas Ogre d'avoir ce paramètre en trop.


Mon erreur, dans ma tête les shapefiles étaient comme les gpx juste en lat/lon mais après vérification, ce n'est pas le cas (on voit que je connais ça...). Tu peux le remettre.


Instead of this, you should a condition to return one type or another, pay attention to this: "A factory class instantiates and returns a particular type of object based on data passed to the factory"


Checkmarx scan results 10 Sep 2015 15:13 UTC +03:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
36
31
37
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

19a974971b960a93fd9db110981376e4a81c8bfb	@dudug

948dce02756851f17200c602899c81d7e1ab4e99	@dudug


@nataliagrybovska Okay -___-


Very well done. I have to learn how to use "as" and "although"


Il me semble avoir eu des problèmes avec ça de mon bord c'est pour ça que je l'avais mit en commentaire. Réactive le et je verrai ce que ça fait. Sinon on ajoutera un paramètre dans le config.xml pour l'outil afin que ça s'active ou non.


this commit fixes #1033


Not being that knowledgeable about (u)pTeX, I'm not sure why this second test is required. What's the reasoning here?


Wat


i have a doubt..i want to create a table in piwik dashboard..please help me sir..


Why


sorry can't remember. Could it be that root is string instead of pathname?


definitely need tests :)


Please fix so that each patch compile on travis.


this going to affect on the consumer?


I was like hey when did i make this commit?


Is there no findASIO.cmake ?


Ogre ne peut exporter quand Shapefile. est-ce que c'est en choisissant un autre type de fichier que Shapfile que sa plantait ?
je vais ajouter dans la config.xml, un paramètre pour permettre de définir les formats supportés pour l'import et l'export.


Not working !!

I have disable scrolling and make viewport as 100%

I also updated new library, but still wheel scrolling not working.


That would be a nice change, except in current README on github, it won't point to the gh-pages then, don't you think?


useless parentheses around `argv[2]` ?


I am suggesting that Vsync can be turned on/off in engine options.


> Yeh. This is stuffy. Can we do something simple, like refill only long lines and re-indent?

you mean having something simple for the release and figure out the interface for other kinds of refilling later? Or we could simply mention that only the normal refilling is stable and that the details for the other kinds are still experimental and susceptible to change.


.ui-grid-viewport {
    height: 100% !important;
}

Wheel scrolling not working


I changed the endpoint URL to pull from Coinbase's v2 API [Show current user Endpoint](https://developers.coinbase.com/api/v2#show-current-user).


I always recommend wrapping calls like this in a ``try: except KeyError: `` block so the site doesn't break in between restarting the client and running the upgrade. This is only necessary for registry values that are new.


Already presented:
Engine menu:
* Options
* Display settings
* Enable V-Sync
If V-Sync enabled, TPS will be calculated from monitor refresh rate. If disabled, player can define custom TPS to fit into best render speed


刚检查了取 all:all:all 的 variant 没问题了，更多的条件匹配还没查，中间好几个 commit 跳过了没看，马上还有别的事儿，明天继续看。


Thanks Seth!


I like this infrastructure. Thanks Yuri.

Have a good day.


well `.getReportAttributes().getRef()` is just noise


`#include <asio.hpp>`


Why not
```kotlin
assert(it.second in COMPILE_DAEMON_PORTS_RANGE_START..COMPILE_DAEMON_PORTS_RANGE_END)
```


Je viens de comprendre le fonctionnement de obtenirChaineConnexion(). J'avais mal vu. Je crois que obtenirChaineConnexion() devrait retourner false si il n'y a pas de chaîne de connexion.


主要是想在里面加上资源的 url 地址。
其次，一开始不想暴露model所有的attributes。


This is my classical "dealing with an enum" pattern. This would only happen if the lib introduced new values.

I wish there was an annotation / compiler directive to fail compilation if not all values covered..
I agree this may be a bit harsh in that particular case


Sure no problem @w8r. :) That would be much preferred and highly appreciated. :)
I just happen to use bower more often than npm, as npm takes forever to retrieve packages.

```
~# bower info leaflet-draw-drag
bower ENOTFOUND     Package leaflet-draw-drag not found
```


Indeed, pawn_push(Us) is missing!
There are many variations possible. Thx.


So you mean to have a getAddedRawRuleMeasure(int, String) not a getAddedRawRuleMeasure(Component, String).


`#include <asio.hpp>` (since this class' methods receive asio objects as references, it is not guaranteed they are defined)


Why removing the MySQL version check? It was part of the issue, right?


 > So the procedure is: I send you the binaries and you put them on the
 > update-repo?

No, the procedure is: you tell me that you want to release a module,
then I get your code from GitHub and build the binaries on our
development machines (Linux and OS X are physical ones, Windows and
FreeBSD are virtual). Then we test them and release an update with the
binaries.

 > Thanks for the info. Travis comes with the gcc 4.6.3 and I have even
 > an older gcc ... I've to upgrade my systems ;)....

Yep. GCC 4.6 doesn't have good C++11 support. You need GCC 4.8.2 at
least (4.8.0 and 4.8.1 are buggy). You can download any version of GCC's
source code and build it. This is what we do with GCC 4.9 and 5.x.

Juan

On 09/10/2015 02:01 PM, kkretzschmar wrote:
>     Then if we could release it, through the normal update repo or through
>     update-devel, at your option, it would be fantastic. Let me know!
>
> So the procedure is: I send you the binaries and you put them on the
> update-repo?
>
>     If you want to make such changes, please feel free. A back trace
>     functionality would be great.
>
> OK, I'll give it a try ;)...
>
>     After some benchmarking with GCC 4.8, 4.9 and 5.2, I
>     have decided to use the default RHEL7 GCC version, which is 4.8.3, for
>     the official distribution.
>
> Thanks for the info. Travis comes with the gcc 4.6.3 and I have even an
> older gcc ... I've to upgrade my systems ;)....
>
> Klaus
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PixInsight/PCL/commit/0fe65bc60a7175b622c41cc0127398f87557d3df#commitcomment-13157909>.
>


Hi Philip, what is the '-E' meaning in the VTS-E PID ?

My DLC adapter cable has arrived finally, so I can get some more Honda tinkering done again on the weekends...


主要是想加上资源文件的访问url。。。


Because in this context the result will be the same, and "non-capturing group" is simpler concept than "independent non-capturing group". So to reduce the confusion in the future the simpler variant is used.


I'm not convinced about this method name; I prefer getSubcomponentsXMLNames or similar: because they're the same subcomponents, named differently.


Ok, will investigate.
Thanks for the reply :+1:


@blomquisg @Fryguy
so this will potentially do a lot of db queries, will it be better to rather get it in one.

This allows the filesystems include custom_attributes in the hosts.yaml


👍 幸苦了


CacheTotal is no term in the calculation of sync error. What you do here is just clipping the error of PA's getDelay.


This could be considered redundant; if you call `map {getName($_)} getXMLSubcomponents();` you'd get the same result. Possibly this and the following method could be elided


AAARGH..


Basically it seems that AE has issues if I return a delay larger than 500 ms.


- Is this list comprehensive?
- Why is it all uppercase?
- Since this is 'private' it should be prefixed with `_` to make it clear it's not part of the public API