we use expect notation instead of should ```expect(@rollout.collections).to have(2).elements```


"image cat-manifest": wrong comment


I would not put it directly in the System namespace.


2 chars?


On reusing the Push-task: It'd make sense to reuse that task, but I don't like the solutions when you have mixed packages. I'd only do that if we can come up with a better solution for that. If not, I'd just leave it as is.

The dependencies was originally because it was a solution package IIRC. Now that it isn't, it's actually better to add the dependency.

Not sure about the test doing too much. It still does one thing: test. I agree that the task is probably quite big, but in the end I just want to say pt test, not pt unittest, jstest, acceptancetest because then the process will be different for every app


ok a


```ruby
expect(@rollout).to be_active(:my_feature, 101)
```


I am pretty sure we don't skip optional brackets.


@bybai , Thanks again.  I updated Docs.  if you don't have further comments.  Can we merge this doc?  we can always add/update this docs after merge to upstream.


Ok I guess the test should search for `:test_throw_commoning`.


closes #1


```ruby
expect(@rollout.ids_from_collection(:beta_testers)).to contain_exactly(%[101 103])
```


While making use of this drop-through is clever, at first glance it reads as a mistake. In this case I'd argue that repeating yourself is the cleaner alternative.
Why is `NULL` necessary here anyways?


Can you report a bug about that?


sorry, missed that...


Looks good. Did you have any tests (specs)?


similar issue was previously discussed on https://github.com/coreos/rkt/issues/1297#issuecomment-132813801


we pad the block with spaces ```{ |arg| dosth... }```


Hi Richard,
i'm glad to see the suggestion i gave to the RH support in the official documentation! :smile:
You can also point to a vCenter by using this syntax:
`ovftool  --noSSLVerify vi://[USER]:[PASSWORD]@[VCENTER-HOST]/[DATACENTER-NAME]/vm/[VM-NAME] /path/to/file.ova`

For an Active Directory-aware authentication, you have to express the @ character in the form of its ascii hex-code (that's to say %5C):
`ovftool  --noSSLVerify vi://[DOMAIN]%5C[USER]:[PASSWORD]@[VCENTER-HOST]/[DATACENTER-NAME]/vm/[VM-NAME] /path/to/file.ova`

For ex.:
`ovftool  --noSSLVerify vi://EXAMPLE%5Cuser:password@vcenter.example.local/DATACENTER/vm/V2V-RHEL5 /mnt/export/V2V-RHEL5.ova`

Hope this helps other people to save time instead of spending it on Google :smiley_cat:
Thanks for your hard work and keep on rockin'.


I would pass a string explaining the limitation (missing Environment.Exit) to FailFast.


@pynicolas ha... indeed :) fixed in 1ae853ebe67630c6c0b36b0b2d7a97c0563dfdf0


Ahh, I searched for something like that when I built my install path patches, but somehow missed it. Thank you for your effort. :)


better :+1:


nice use on the fonts!


can't u use [find](http://apidock.com/ruby/Enumerable/find)?


should tags be a static constant too - `requiredBookmarkArrayFields` to maintain consistency?


@kargakis yep, this is what I was expecting.  Thanks.


@latobarita: retry


oops ^^


@bughit,
The primary reason is modular design. Rather than put all the methods into the main Tree class, and make the file-unit complex and long.


Note about this being deprecated?


> What about checking that out.Metadata is nil?

The internal version of the struct doesn't have `Metadata` at all.


I've had a brainfart and I forgot how to switch vim tabs now..


Correct.  In contrast, for the `for` on the next line, there's only the `[`.


Why is it ref not out? And in general, I am not sure it follows the Try pattern.


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/7e7499e19d6e9489447b045b64ed66ff4ad671c2


merging MonsieurNicolas/stellar-core/trustLine0fix = 7e7499e1 into auto


MonsieurNicolas/stellar-core/trustLine0fix = 7e7499e1 merged ok, testing candidate = 74413b7f


The internal version doesn't have Metadata.


maybe you could do
```ruby
ids = ids.map(&:to_s).reject(&:empty?)
```

what do you think?


> Note about this being deprecated?

That would belong in upgrade.md as well.


Este "exit" tiene alguna finalidad dentro de esta funcion?, cuando agrego o edito una survey se crea o se edita satisfactoriamente pero no me retorna correctamente a la pagina de survey (se queda en blanco)


Whoops -- deindent the `for` by four spaces here, since it is outside the tuple parentheses.


Think this must be done in a plugin. A lot of user don't really need it and this take again and again more operation for some user (and more and more bug to fix in next years).
A plugin to add content in existing content on every admin page is really needed. The "save in DB" can be done in afterPluginLoaded (but need a better event). I don't think adding an event to add content to each admin page is a big change between 2.06/2.5.

This can added in core plugin, but can be deactivated/activated when we need it .


Please update the -help information :)


maybe its not a good idea


The reason why they appear btw. are new predicates like union(A,B,R) where result gets "unified" or instantiated by the predicate itself, so after derivation there are no leaks. Our backward inference mechanism is rudimentary so far, here leaks can be expected since the predicates stay the same. I will restrict it as soon as I totally understand the relation between backward inference and the precondition predicates, before there is no need to work on that.


The `NULL` check is used as a bit of error checking in case you provide an empty string (which gets converted to an empty char).

I believe the use of the drop-through is correct.  It is useful to tie the handling of `MISS` and `NULL` together.  What if this example was more complex and there were several lines of code in this block?  Copy pasta could result in errors of `MISS` having one behavior and `NULL` having a slightly different behavior.


I would not return empty. Makes it hard to debug. Why not return "NIY" or something like that?


in the error message? the error is supposed to tell you "don't worry about it, just don't send a Key". What would you include?


As long as "The Tox Foundation" or "The Tox Project" is not a copyright holder either, we're all safe.


@simonbrandhof thanks to review this commit. It adds the permissions/template_users WS to list users of a permission template for a given project permission


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21233/testReport/) for this commit**


I can't speak to this change.  I would let @jmorra respond.  I would guess that he wants to guarantee compatibility with java 1.6 but I'm not sure.


```expect(@collection.user_ids).to be_empty```


Looks good here.


Preparations was the word I searched for. ^^


contain_exactly with expect


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.615](http://teamcity.monogame.net/viewLog.html?buildId=10307&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:20:19


to have(2).elements


zostawilbym id, bo i tak jak beda pytac o status to musza klienci znac id.


expect with to include


just the key itself; this error is just for us, it won't ever face a user, including the key might help find the cause


expect syntax =/ sorry


Is this block duplicating the block from lines 79-83?


That's what code review is for :D
<review


Should we make this not a warning (but info, or suppressed) if the diff is negligible?


To be consistent this probably should be NAME=Plugin 1

?


Fixed in latest commit.


Can this fail?


Mark as deprecated


I made this commit to make clear what exactly i have done in my previous commit, where i didn't wrote a good description.

> Am 25.09.2015 um 16:12 schrieb Swoorup Joshi <notifications@github.com>:
>
> What is fixed here? Some print statement?
>
> —
> Reply to this email directly or view it on GitHub.
>


なんでこれで直ったのかわからない


this should not be fixed here but in the missing TaskFormatterTest. Being fixed.


Actually.... Plugin 0? Confused.


The formats are different on purpose. It shows you don't have to follow a strict form, it's just an arbitrary string.


Yes, for projects that I'm currently using this for I need to maintain compatibility with 1.6. I don't think it'll change much cause the java layer is pretty small.


Nested if's don't make this more readable. I found your first version (or mine) more readable ;-) another possibility: a separate function.


Add an assertion that Downward API is set as you expect.


look at openrc.sh

> On Sep 25, 2015, at 7:54 AM, Mangirish Wagle <notifications@github.com> wrote:
>
> Thanks for the suggestion Professor, will do the required changes.
> Could you please provide me some more info on 'sh' format, how it should be?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/cloudmesh/client/commit/bd12381f1c03db6f88a4c2d98b923637bc405675#commitcomment-13440243>.
>


Java 6 EOL passed 2.5 years ago, and Java 7 was EOL'd 6 months ago.
http://www.oracle.com/technetwork/java/eol-135779.html


Added deprecation notes in both v1 and v1beta3, updated UPGRADE.md


Perhaps I should just make the included settings.ini as an example configuration with sTracker and MinoRating on the same machine.


get_ prefix is misleading here, as to me "get" implies that it will return an object of some sort. How about num_open_kprobes()?


:exclamation: coding style


Looping over indexes of a GF looks like a very frequently-used operation.
We need to supply an iterator to make it easier.

Also, the loop here is over the integer point indices; it may be better to make it over mesh points themselves, then there would be no need for conversions `MESH1::index_type(i)` and `MESH2::index_type(j)`.


Okay, fair enough.. A matter of a dedicated PR anyway, I suppose.


You are making an argument for putting the methods in a module, that's fine, but not what I asked about.  My question is about how/when you are defining these methods.

Instead of defining them in the module directly:

```ruby
module Mod1
  def foo
  end
end
```
you are defining them in the included hook which gets called every time the module is included, thus potentially redefining them if the module is included more than once.
```
module Mod1
  def self.included(other)
    def foo
    end
  end
end
```
What is the point of this?


:exclamation: CS


done


While I agree that's it's an old version we still use it a lot here and if
this change were to be committed it would require a lot of code changes on
our end. We are currently upgrading to java 8 but until that is done it
would make my life a lot easier to be at 1.6.
On Sep 25, 2015 8:31 AM, "marko asplund" <notifications@github.com> wrote:

> Java 6 EOL passed 2.5 years ago, and Java 7 was EOL'd 6 months ago.
> http://www.oracle.com/technetwork/java/eol-135779.html
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/marko-asplund/vowpal_wabbit/commit/afe94ffaf79aa89447f5d299f77eb50e49dd2c50#commitcomment-13441120>
> .
>


@terrajobst, could you also build a package and publish it to myget (the prototyping feed)


I guess to further add, If I did break it up, I would assume that they do different things (until closer inspection) whereas there is no mistaking in this instance that they do the same thing which in my opinion makes the code more readable.


@ahsonkhan, once there is a package for this, please replace the custom command line parser in dotnet.exe with this one.


cos ahai fatto @cosmavito


can you explain? always an empty line before the return, even in a 2 lines method?


Yeah but didn't you implemented the slim way some times ago?


I love guard statements so much


PrepForRelease (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-71.73%25-red.svg)


@h2o64 Nope, i reverted it because it caused errors. Still working on it.


> Any idea of the top of your head how they do it?

Unfortunately not, sorry.


This logic was pretty tangled, so I opted to not touch it (apart from reindenting it for the loop, obviously). The table mechanism is one of the areas that'll get the most cleanup from revising/replacing the SwiftData interface, so I'd like to leave further work until then.


稳健医疗集团


>  it's pre-argonaut.

oh, then nvm =)


Yeah unless the return is alone, you need to add a blank line, no ?


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/82172753


Question: why export this type? Are there any consumers of it outside this file?


Agreed in principle. But what would be the right CSS for this? For now this should format similar to what the RFC Editor's text output is (indentation-wise).


It does not sound right to me to clean outside directories during `make clean`. I don't say I disagree with it completely, it serves the purpose.


This may be made looking this way:
```C++
typedef two_index_gf<double, MESH1,MESH2> gf2_type;
//....
for (gf2_type::mesh1_type::index_type i(0); /* .... */ )
//  ....
double c2=g_omega.tail_or_0(1, gf2_type::make_index[i][j]);
```

The idea is to furnish every GF type with a (`static const` member?) `make_index`, which has `operator[](index_type)` such that `make_index[i][j]...[k]` returns an object that can be used to address the GF. Something resembling `extents` in boost::multi_array.


Works Great!
![image](https://cloud.githubusercontent.com/assets/2160436/10104941/4a72aff6-637a-11e5-8e11-ed4db52402a1.png)


should also use .id


Fix => Group by date configuration from the Displayer Editor UI causes the generated SQL to non have the proper alias in the GROUP/ORDER BY statements


riak_kv_pb_timeseries uses it directly.


I got a ton of NPEs here, like this one: https://gist.github.com/matklad/68bcc3d91e73f07b1750

I can "fix" it with String? and ?. operator, but I don't know if this is correct.


should also use id


I rather go for the 1Kth's! :-)

etournay <notifications@github.com> schrieb am Fr., 25. Sep. 2015 12:01
nachm.:

> Well, I let you do the 200th !
>
>
> ----- Mail original -----
> De: "Holger Brandl" <notifications@github.com>
> À: "mpicbg-scicomp/tissue_miner" <tissue_miner@noreply.github.com>
> Cc: "etournay" <etournay@mpi-cbg.de>
> Envoyé: Vendredi 25 Septembre 2015 11:53:15
> Objet: Re: [tissue_miner] removed margin cell in get_cell_properties
> (3857c76)
>
> I wanted to to do the 100th commit! Good work anyway. :-)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mpicbg-scicomp/tissue_miner/commit/3857c76695f71629745a541d9802fbbde62a8c4a#commitcomment-13434404
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mpicbg-scicomp/tissue_miner/commit/3857c76695f71629745a541d9802fbbde62a8c4a#commitcomment-13434534>
> .
>


raising assertion only to catch it in the next step? Do you have anything against if?


quel correction de merde, dimy la victime


@pynicolas actually this rule represents USE_STATEMENT but this is already fixed in https://github.com/SonarCommunity/sonar-php/commit/6b2ebf7cba86d1792a4568a185802b2aca1f57bd


yes


Oh ta mère toi


You mean check if in.DownwardAPI.Items[0].Path != "./test/api-to-v1beta3/conversion" ?


fast-forwarding master to auto = 74413b7f


@nateabele  here's your url matching that allows same-name path params in subsequent child states


tu as rien corriger boloss tu mériterais un livre <3


Ah I see now; just needed to pull.


Fair enough.


will fix feature height as part of bug 532


Rather than plugins (really dirty way to push some code in controllers), I'd rather like components (true MVC with their own database) and modules that could be assigned to pages, like in Joomla. Eg : in the list of survey page, we could load the module without the last visit, or a module wit the last visit.
But that would rather be for LS3 or further.

The plugin way of extend the code could lead us to a anarchic code in the "drupal 7 style" (idk about Drupal8 code); rather than a clean code as Joomla 3.


TeamCity pull requests :: netty [Build 281](https://garage.netty.io/teamcity/viewLog.html?buildId=1687&buildTypeId=pulls_netty&guest=1) is now running


You should probably modify this in tools-iuc instead of here I think @peterjc.


OK, I'll downgrade.


Just remove the Readme.md file to keep these commits in order.


@pynicolas  LGTM!


We need to raise an issue or something to track these correspondences. This is the least obvious part of the design, and could hide problems.  Rather than an AssertionError, can we log this  anomaly and return unknown?


Why do you say the horizontal menus were unusable with them always visible?  It was supposed to hide the widget if the user pressed down to access the submenus -- did that not work for you?


This will come handy when looking for the troublemakers. The one think I'd probably change is I'd use `__name__` as prefix (well `"avocado-" + __name__`, to be precise). That should help looking for the file that caused the problem.


PrepForRelease (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (822 of 822 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.31%25-green.svg)


no worries. I have also fixed it in my fork which has the unit tests in. There are a few other things which I think are wrong which the tests show up as well.
-----------------------
On Fri, Sep 25 2015, carlos Alonso Gabizón wrote:

> Thanks for that. I made the change and commit to my fork. Will be available next time we merge

> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/emoncms/MyHomeEnergyPlanner/commit/16f647c530a898517377588d93de98420be5d903#commitcomment-13440481


@haijieg Do you have the list?


$location is also wrong, it should be:

```
run(["$rootScope", "$state", function($rootScope, $state) {


AH, thanks god.

OK, you mean testing via rspec?


すごく細かいですけど、インデントとかは揃えておきましょう！


saw approval from hmmr
at https://github.com/basho/riak_pb/commit/3e62ae2b20926db30b756c19c3c1351a595d8ce6


merging basho/riak_pb/feature/export_ts_rows_type = 3e62ae2b into borshop-integration-132-feature/export_ts_rows_type


basho/riak_pb/feature/export_ts_rows_type = 3e62ae2b merged ok, testing candidate = 446d86fd


TeamCity pull requests :: netty-tcnative [Build 6](https://garage.netty.io/teamcity/viewLog.html?buildId=1688&buildTypeId=pulls_netty_tcnative&guest=1) is now running


I would like the call/compensate action in the deploy() method body to be a one-liner, or at most a two-liner. This is probably Java, but it would be nice to make it easier to read.

Is this sort of general abstraction really necessary when it's only used once?


Couldn't we have a default value and then use the mobmob (in mob_family_mods.sql if it must be by family, though I have doubts about it being by family as well) to accomplish same thing? I can't imagine that many mobs have widely varying range. I'd not be saying anything precept for having seen you remove this from a different table very recently, and putting this in families at  time when I thought we're trying to get rid of any extraneous mob family entries.

Just seems to me like its possible it could have stayed where it was, if it had to be a column of its own and you basically did your work twice `¯\_(o.o)_/¯`

But you prolly have a reason that just isn't readily apparent to me. If you feel like enlightening me I'll be around this afternoon.


Yup!

http://stackoverflow.com/questions/19983221/actionmailer-testing-with-rspec


TeamCity pull requests :: netty-tcnative [Build 6](https://garage.netty.io/teamcity/viewLog.html?buildId=1688&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:52


But Rollbacker, or whatever it is called, needn't be public.


Sont know. But I guess yes. Fixed


Don't web processes time out after 30 seconds? If this is a rare problem that doesn't come up on an intermittent basis we should just error out and do this in a management command instead.


Good catch, let me add a call to `sys.stderr.write`.


right


lastbooting tested


It did, but I would press down to get to the widget because I could see it, and get the submenu instead.  At least with an option everyone can be happy.


Actually I'm wondering, when is this object deleted. I thought it's just when it's first called (because it set's the attribute of the object), but in my trial it was cleaned on exit:

```python
class LazyProperty(object):
    def __init__(self, f_get):
        self.f_get = f_get
        self.func_name = f_get.__name__
    def __get__(self, obj, cls):
        if obj is None:
            return None
        value = self.f_get(obj)
        setattr(obj, self.func_name, value)
        return value
    def __del__(self):
        print "Dying"

class B(object):
    @LazyProperty
    def workdir(self):
            print "workdir"
            return "foo"

a=B()
a.workdir
del(a)
```


TeamCity pull requests :: netty [Build 282](https://garage.netty.io/teamcity/viewLog.html?buildId=1689&buildTypeId=pulls_netty&guest=1) is now running


Boost.Python does support Python 3. See [this project](https://github.com/Kitware/sprokit) which supports Python 2.4 through 3.3 with it.


where is the configuration option? I can't find it.
I updated to version 3.0, it stared to build everything!!!


@jeremyandaya is this the code you were looking for?


@jmesnil Looks like you managed to get sorted.  I've pushed change anyway with this removed.

Yes, as you mentioned in IRC the trick is to use jms/topic/<address> for MQTT and just <address> for JMS.  They will both resolve down to jms.topic.address.

The reverse doesn't work yet, as there are some message properties that are expected on the message.  Such as the message Quality of Service.  The JMS Producer would need to set a message property for this, which would get translated internally.  I should probably also a default.  It's not a major piece of work, should get to it soon.


I don't really understand why I need this negative lookahead here, but without it expressions like `1 >> 1` are invalid. Parser firmly insists on seeing a comparison expression there :(


removed! :D


# 岂有不膜之理


One other note.  Retain functionality will not work with JMS.


This will conflict with #248.
This method wad removed


Yes! That would be yet better. But since the script was not doing it originally, I did not care about that. Do you want me to add this validation? A similar problem exists at:

https://github.com/objectcomputing/quickfast/pull/130/files


Push not possible


Also, something is wrong with skinshortcuts and kodi 15, it builds very wrong menus for me, kodi 16 builds them fine.  Specifically it removes the live tv and music menu items if you have no music library items yet, thereby leaving you no way to add them.


This can also be changed to by.css()


Missing quotes around the updated string string.


No, it was just an idiom that was on my head yesterday.


This was not intended to be pushed up... I will fix in a subsequent PR


This task is listed twice.


Hmm, that's a good idea actually. I'll implement it on version 2.


you mean that `tempfile.mkdtemp` would stop creating directories? That would impact everything and would be probably caught pretty quickly ....


I don't how to make you understand what I want.
With your solution I have :
- 1 Harware device (Fibaro Wall Plug)
- this device has 4 logical devices :
.     1 switch S : it is OK
.     1 Usage/Electric UE1 for the power needs by the device itself : it is Ok, it show you what you want the Power for 3 years
.     1 Usage/Electric UE2 for the power needs by the electric device connected to the plug : it is Ok, it show you what you want the Power for 3 years
.     1 General/kWh GWH for the Energy consumed by the electric device connected to the plug : its KO, it shows you in the day graph the power of UE2 and it shows you Energy in week, month and year.

What you want is displayed by UE2 but what I want is nowhere because you put UE2 values in usage of GWH and you change the philosophy of the General/kWh device : to show Energy. If you want to see power display UE2 not GWH.

Maybe you want to display both values in the day graph ?


btw that's something I want to use in the future logging refactor...


Nope, that's not what I meant


This is the call sequence that I find rather onerous. It makes this method hard to read. I'll see if I can suggest an alternative.


gframe/event_handler.cpp
I think the alias of magic/trap card needs s parantheis, just like the monsters.


It didn't store my comments in a proper way (the overall and the first function description don't appear in the right place)


all tests pass:
success: http://buildbot.bos1/builders/test-riak_pb/builds/173


What about changing to
else if (sp->depth < minDepth)
This should almost always guarantee 2 different split points ...


Thanks!


Demo links miss `http://`, e.g. `https://github.com/dmvaldman/samsara/blob/master/samsara-navigation-controller.s3-website-us-west-2.amazonaws.com`.


django-reversion==1.9.3 ?


`utils_path.init_dir` creates intermediate directories missing. So if for some reason tmpdir is deleted, `utils_path.init_dir` would recreate it. This is definitely not what we want for temporary directories in any shape or form, given that it's a security breach.

So the idea is to check if some code deleted this directory before going ahead and create the subdirectories. By doing that we ensure there's no re-creation of tmp directories.


not for any reason I can think of, feel free to turn it on if you want


This should be a separate commit / PR


Just updated to the latest version and Explorer has a couple of strange entries. I don't think the AllCardNames files supports comments at the moment, assuming that was intended, although not even sure why you would want to add these as comments anyway?
![screenshot00327](https://cloud.githubusercontent.com/assets/2443519/10105568/4a63881e-63a7-11e5-97ac-3bdf3d6d93a5.png)


as you can see also from the zwave documentation, power = watt, energy is the counter


If you argue then that `utils_path.init_dir` should not be used in this function, I guess it accomplishes a similar goal, although it's less clear in case of failure (strange errors on directory creation tend to be pretty opaque to debug).


Верно


Why have the STARTED check at all, then?

In general using asynchronous interfaces, a pre-check is _stale_ by the time the "protected" operation is performed.  It is better to do the operation and check for failure afterwards.


Assuming inline style is temporary until we figure out how to properly size the images, LGTM.


why didn't you just replace the whole block with a simple:
output = mongo_eval("printjson(#{command})")

since we already have mongo_eval method in mongodb.rb ?


@pynicolas let's keep following convention for FIXME and TODO
```// FIXME (<name>) : content```
so that we could quickly understand who created this todo.
btw i've already added your name in this place.


Класс написан верно, однако расширение файла должно быть .java


I assume you're planning to treat gadgets in the same way as rich-text components and have all of their individual testing done directly in editorAndPlayer.js?


GHX_Vert_IDD (mmatts) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.04%25-red.svg)


Looks good


Why are you allocating a second ZMQ context?

To quote The Guide:

    ZeroMQ applications always start by creating a context, and then using that for creating sockets.
    In C, it's the zmq_ctx_new() call. You should create and use exactly one context in your process.
    Technically, the context is the container for all sockets in a single process, and acts as the
    transport for inproc sockets, which are the fastest way to connect threads in one process. If at
    runtime a process has two contexts, these are like separate ZeroMQ instances.

Is there a benefit to running two separate I/O threads, one for beaconing and one for submission?  If so, please specify in the code, since this is an unnatural pattern for ZeroMQ.


On trying to download the images for 230 unimplemented cards...
```
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/54.jpg [Adverse Conditions.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/138.jpg [Akoum Firebird.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/139.jpg [Akoum Hellkite.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/140.jpg [Akoum Stonewaker.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/222.jpg [Aligned Hedron Network.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/228.jpg [Ally Encampment.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/18.jpg [Angel of Renewal.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/208.jpg [Angelic Captain.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/19.jpg [Angelic Gift.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/1.jpg [Bane of Bala Ged.jpg]
java.io.FileNotFoundException: http://magiccards.info/scans/en/bfz/127.jpg [Barrage Tyrant.jpg]
...
```


OK, done: https://github.com/galaxyproject/tools-iuc/commit/f1ddb48c5fb0b1140934b1c5e434745c8b1c985b

Is there any formal policy on how ``planemo_etc/*`` is kept in sync with upstream sources?


Looks like a nice simplification...


note there should be a comma after the key


Why did this code get moved?


doh -- I have screwed up and not pushed to origin but to my clone before ... please merge current master -- there will be minor conflict(s) and push again


Power is Watt
Energy is Watt per hour
The counter is Watt per hour
The counter is not a sum of power

The electric counter device of your home display kWatt per Hour.


This is a bit silent for when a single instance might have gone away while you were  looking. Can we do better?


you mean there shouldn't be a comma, right?


no e in 'milliseconds'


Power is a "speed"
Energy is a "distance"


does this work?


Sorry, should have put this note here.  `Undoer` shouldn't be public.


I would expect it to go in profiling, not timing. What is the error?


yep, now you also understand !

we keep it like it is.... i know you have a different view how you would like to see the graph, but i bet most users (like i) want to see it like it is now, and that is now a value an hour, but direct behaviour


it'll fail a transaction, so it'll be clear where the problem is (and the key is always that of the transaction). Going to leave as is (we also don't include debug information in the other errors around here).


Can we make ProductionExperiment a subclass of experiment?  The main difference between SimpleExperiment and Experiment is that the former implements a logger that writes to a file and does minimal exposure log caching checks, both of which are generally not desirable for any production experiment.


@xhaggi ping


I meant "should be a comma", and now there is none... i.e. should be

```@book{FrackowiakFristonFrithDolanMazziotta1997,```

also please add those new files within a test which currently would fail.
Also I think tests should have picked up this omitted comma now and failed (didn't look at what travis has complained about).  Just run tox to see


Is this sufficient? We probably want to make sure the transaction id stamped on the `versioned_value` itself is indeed **this** transaction.


Thanks for contributing back to the reference implementation @rawls238 -- I think this will be really helpful for bringing PlanOut up to speed with HubSpot's improvements!


thanks! it's **much** more informative now :+1:


@akbertram it's not clear how this converter works, sample:
1. 01/11/15 - parsed 1 November 2015
2. 01/13/15 - parsed as 12 January ?

It leads to import validation issues AI-1230


We also need to lock here; `RBTreeInternal::find_any()` not thread-safe. Our `erase` should never really "erase" a node then, even after the transaction commits -- we need RCU garbage collection.


KML Track


KML tracé


> lol! that's kind of magic, but I liked it. See: https://github.com/djc/couchdb-python/blob/master/couchdb/client.py#L378

nice... would you mind to add a comment line above, just to let innocent minds like mine know that there's a side-effect under the hoold , due to it being a property that will put the doc etc?


No working in case of 0 vehicle, I don't know why.


also, this is an interesting point to document that it's bound to a blocking call, isn't it?


TeamCity pull requests :: netty [Build 281](https://garage.netty.io/teamcity/viewLog.html?buildId=1687&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4769, ignored: 21 Build time: 00:30:16


TeamCity pull requests :: netty [Build 283](https://garage.netty.io/teamcity/viewLog.html?buildId=1690&buildTypeId=pulls_netty&guest=1) is now running


Umm downgrade from 84 to 82 wot o.O


Should be "^1.0.0", no?


Huge refactor occurred in this update.


Why not define a `final static Runnable NoAction = ...;` and avoid the need for a `withNoParticularUndo` method? You would write `.andUndoBy(NoAction)` instead.   (`...` could be `null`.) Of course you are free to rename `NoAction` or `andUndoBy` to make it read better.

In Java 8 this could read a whole lot better anyway, I guess, using closures.


heh good call ;)


https://github.com/AirOne70/packages_apps_Settings/commit/977085aa9da212f73f80dae94b94421a1892cc3f ;)


Can you elaborate on the behavior that `--reconnects X` controls?  It seems like it provides a maximum number of "oops beacon is down, reconnect" before exiting entirely, but that doesn't seem to be constrained by time.  I.e. if I have a single beacon failure once a week, after X weeks dbolo will just give up.

I hope this is wrong, and just needs documentation.


Acá te agarré @danielpadula, este cambio cambia la condicion!


Original files not yet modified


logical_file_name and run_num can be a string too. If lfn is a string the len(logical_file_name)>1 will be true, the run_num still can be a list.


Hi Marc-Andre,

I get an error here, setCurrentProject is unknown on my installation. Was it added after Mars release?

Martin


for?


This one is listed twice as well.


Removes manpage generation to remove a2x (asciidoc package) as dependency. Also adds static compile option and linking to missing (from liblua) libdl.


looks ok to me


mayb const char *


Hello @mhussainm , we have seen your commit now sorry :( , the plugin has advanced since then. Want to contribute?


I forgot to think about the case of gzipped fasta... Need to first unzip it in this case.


looks good!


GHX_Vert_IDD (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.04%25-red.svg)


que tiene que verrrr ? es un pep8


@gilbertohasnofb, look at the float.png I committed in this branch at https://github.com/Juanvvc/c172p-detailed/commit/debd9415ad2ad0f428c7eaf3a95520c12c6a4b9e
Is the black space where I put you textures being used in any of the liveries?


Looks good!


I've checked a few - those were reasonable.


Ah, ya vi. Limpie mal


Removed man page installation, as man pages aren't generated anymore. This now compiles on TVS-1291-RP FW 4.0 ( with the needed ipk packages ).


I don't understand this filter?

why does the milestone column care about closed issues?


close enough just wanted to point that one out.  preparing = gerund, "to
prepare" verb as a noun.  preparation = result of preparing, also a noun.
preparison is not english but anyway it resembles enough to be
understandable.

On Fri, Sep 25, 2015 at 11:27 AM, patham9 <notifications@github.com> wrote:

> Preparations was the word I searched for. ^^
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opennars/opennars/commit/04298862dbb501ffec13db6071bdae38b4977b83#commitcomment-13441019>
> .
>


is this even necessary given that we use `new URI(...)` ?


deja pasar una exception que no es instancia de `DATALException`, https://github.com/datal-org/datal/issues/28


@wlbragg That black space is not being used AFAIK. Once the plan of what to do with the texture files is done then I can add them to all other liveries as well.


coding style


PrepForRelease (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-71.73%25-red.svg)


probably you could use uniqptr to handle the pointer an prevent leak above


this commit passes `to_select` on to the selectize selector string. (recall that `to_select` is the original selector string passed to `animint`)

test-knit-print.R tests work on my machine using firefox:

```
> tests_run(filter="knit")

processing file: /home/thocking/lib/R/library/animint/examples/test_knit_print.Rmd
  |........                                                         |  12%
  ordinary text without R code

  |................                                                 |  25%
label: safety (with options)
List of 1
 $ echo: logi FALSE

  |........................                                         |  38%
  ordinary text without R code

  |................................                                 |  50%
label: plot-1-top
  |.........................................                        |  62%
  ordinary text without R code

  |.................................................                |  75%
label: plot.1.bottom
  |.........................................................        |  88%
  ordinary text without R code

  |.................................................................| 100%
label: boring

output file: test_knit_print.md

testthat results ================================================================
OK: 21 SKIPPED: 0 FAILED: 0
>
```


We don't want archive issues in milestones either


this leaks relativeURI  & baseURI


These type of rules are the key to backward inference. Will finish this this weekend and then I will go on with NAL6.


Please do, that way, we can document setting environment as the first
workaround.

On Fri, Sep 25, 2015 at 10:57 AM, Montoya Edu <notifications@github.com>
wrote:

> Yes! That would be yet better. But since the script was not doing it
> originally, I did not care about that. Do you want me to add this
> validation? A similar problem exists at:
>
> https://github.com/objectcomputing/quickfast/pull/130/files
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/montoyaedu/liquibook/commit/8c8d7762849b8ff9905c449812c10232eb58003f#commitcomment-13441707>
> .
>


How many bits do you need ?  32 or 64?

This line (and the same bug some lines above) confuses them. If you need 64, you need toLongLong(), and I suggest using qint64 for easier compatibility with Qt4 instead of int64_t.


If you are using `CLOCKS_PER_SEC`, `clock()` etc. you need the corresponding headers.


name it configurationUri and remove comment?


 GCDTool *tool = [[GCDTool alloc] init];

    //全局队列  异步
    [tool asyncGlobalQueue:^{

    }];

    [tool asyncGlobalQueueBackgroundPriority:^{

    }];

    [tool asyncGlobalQueueHighPriority:^{

    }];

    [tool asyncGlobalQueueLowPriority:^{

    }];

    [tool asyncMainQueue:^{

    }];

    GCDTimeTool *timetool  =[[GCDTimeTool alloc] init];

    [timetool gcdAfterTime:^{

    } time:2];

    //如果用到定时操作 这个必须用到 强引用
    [timetool gcdTime:^{

    } timeNumber:1];

    self.timeTool = timetool;

    GCDOneTool *oneTool  =[[GCDOneTool alloc] init];

     //执行一次
     [oneTool gcdOne:^{

     }];


GHX_Vert_IDD (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Oh, yeah, good point about closing the stream. :-)

PR is on it’s way.

> On Sep 25, 2015, at 2:21 AM, Achilleas Anagnostopoulos <notifications@github.com> wrote:
>
> I think you should also make sure that _basicReturnStream is closed inside the _close() <https://github.com/rajmaniar/dart_amqp/blob/7dfee359e8b22e929d2466475a445c804bed9d89/lib/src/client/impl/channel_impl.dart#L199> method.
>
> Other than that, it looks great. Please add some tests for this feature and submit a PR.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/rajmaniar/dart_amqp/commit/7dfee359e8b22e929d2466475a445c804bed9d89#commitcomment-13433711>.
>


I understand.  I don't use the horizontal views personally, so I don't care that much how they work :)  I'll look at what you did.

As for Kodi 15, I think it's due to a PR that was backed out for Skin Shortcuts for Isengard.  I don't think it's currently functional.. which honestly makes me a bit nervous, since we're now very dependent on that script.


This is still allowing tabs through... (`/^[\x00-\x09\x0E-\x1F\x21-\x7F]*$/.test('test\ttest')` returns true)


This breaks Yoshi's Story


I wouldn't test against the nightly yet. I think there's going to be a ton of breakage for the first couple months that would be counter-productive to follow in lock-step until it stabilizes a bit, so failing PRs based on 0.5 compatibility would only yield false positives for now. (I'm all for moving to 0.5 compatibility mid-release-cycle, though.).


Great. And what are your thoughts about thegravelpit site? Can I move forward on that without issuing PRs?


Are tabs a problem? They don't have any special meaning in the HTTP protocol, as far I'm aware. I'll fix it.


编译器控制台打印警告信息


ah, thanks


Magiccards.info hasn't caught up yet - If cards already have an image there will be no prompt to override them.
Instead of linking them all to currently available images then re-doing them all, I thought that having them already ready for the link when the are available would make more sense.


Yup, I assume that site is yours. Do whatever you please but try to use the principles I taught you.


i should be able to continue starting on 27th. including many updates to gui

On Fri, Sep 25, 2015 at 12:30 PM, patham9 <notifications@github.com> wrote:

> These type of rules are the key to backward inference. Will finish this
> this weekend and then I will go on with NAL6.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opennars/opennars/commit/9171932d5552f4fe2a86757cf2fad43fb064741c#commitcomment-13442379>
> .
>


Huh... okay. I never even thought to try this because I didn't imagine the HCL parser would allow it. I'll make a note to go study the HCL parser and see why this works. :)

Thanks for the fix!


Should this just call Find if relpath[0] == '/'?


Checking merge


Is this something that should be?  If so, please add a TODO


Just a couple questions in the comments


Ok, checking it out (haven't looked through the code yet, just pulled in your change to see it in Kodi), couple things to note:

1) I don't want the widgets hidden on Home1, ever.  They should be always visible.
2) I don't want the weather widget to be handled specially.  In Home2 and Home3, it should only be visible if the widget is focused, just as it is for the other widgets.

I suspect you managed to get the overlay text visibility condition working right simply because of #1, where you hid the widgets on the Home1 screen.  But this isn't what I'd like.


bla


The plugin way move function on own system , I don't know drupal code or joomla code. Know better spip and it's easily extendable/adaptable when we know plugin devloppment of Spip. The default of plugin system of spip is to use a lot of specific part (framework part). For us : we already have a framework.

Drupal or WP never have this success if it include a lot of plugin .... too complicated ....


Yeah, it'd be good to at least have some basic coverage of this in this repo.  Maybe just two fairly simple ones would suffice:

1. Verify write lock held count is zero, call 'with-lock', then from inside of there verify that the write lock is held, then let that exit and verify that it's zero again.
2. Same as #1 but throw an exception from inside of the with-lock body forms to validate that the lock is released even if an error occurs.

(You'll probably have to dip your toes into the reflection stuff that I mentioned on the ticket in order to make that happen.)  I think that would probably be sufficient in my mind for now; the other tests that currently live in pe-p-s-e will probably be partially or completely migrated down into OSS in the future when we have a story for FOSS atomic code deploys, and since nothing in OSS is acquiring a write lock for now, I'm not sure what else to test?

Maybe it wouldn't hurt to also just have a couple of super-basic tests that validate that the counts are updated correctly when a register/borrow/return occurs?


Questi sono legati a OperandMemory, non vanno inseriti direttamente nella classe astratta!


Looks good, but X11 version seems too hook into gui-private. Did you port it manually?


Now that I think about it roam distance could just have a default value and be removed from `mob_families_system` and `mob_pools`. Maybe even all the new columns could be removed and replaced with default values. The default value can then be overwritten by a mod mod. I'll think about it some more.


Evita le stringhe, come ti dicevo per mail


Yes, this is quite bad.  I think that I actually meant to test `end_idx`, not `idx`.  Sigh.  Turns out that this lacked tests entirely.  Corrected it and added tests.  Thanks.


Aqui pode ser assim:

```python
TEMPLATE_DEBUG = DEBUG
```


Hello, good luck with your tests!

Could you post a message in the forum to explain how your lazy smp algorithm works?

Stéphane


Mudou somente para definir um prefixo para as variáveis de ambiente?


Questi hanno senso soltanto se li utilizzi come riferimenti ai registri (nel qual caso è meglio utilizzare la sottoclasse OperandRegister). In tutti gli altri casi, non hai accesso direttamente dalle microoperazioni, ad esempio, a immediati o ad aree di memoria.

Oppure, forse, li stai confondendo con la sorgente e la destinazione delle microoperazioni, ma si tratta di tutt'altro in quel caso.


This is happening with compute?


Code should be formatted properly. (too much white spaces)


Indeed.  Thanks!


Thanks!


Thats perfect!


utilizza "istanceof" anziché equals() su getClass()


closed #3


Hum, you have one bad worker (currently 40W 0 L) which is crewing up the results.


> P.S.: Falls das ganze in den Master gemerged werden soll wie, wie hättest du es denn gern?

Also sehr gerne und als pull requests mit ein paar unit tests. Ich würde das CurvatureWeighting vom PriorityWeighting erben lassen (oder wie du es hast) und per default aber nur bei motorcycle enablen via encoder.supports(CurvatureWeighting) - siehe in der [GraphHopper Klasse](https://github.com/graphhopper/graphhopper/blob/master/core/src/main/java/com/graphhopper/GraphHopper.java#L939))

Also die Änderungen immer möglichst minimal mit maximalem Impact ;)

> Zusätzlich kann man noch optional eine .kml mit schönen Straßen angeben, die mit den KMLs von AdamFranco übereinstimmen einbinden.

Das würde ich erstmal als separaten issue und sehr wichtigen Issue sehen, wo man custom Daten importiert und darauf im Weighting zugreifen kann. Da fände ich den Ansatz über eine API Schnittstelle sehr gut, so dass man das auch live ändern kann, wie bei den [Traffic Daten](https://graphhopper.com/blog/2015/04/08/visualize-and-handle-traffic-information-with-graphhopper-in-real-time-for-cologne-germany-koln/)


Não. As configurações estavam todas hardcoded. Buscando essas variáveis no ambiente torna mais fácil manter um único repositório tanto pra produção quanto pra desenvolvimento.


On try edit layout designer

SQLSTATE[42S22]: Column not found: 1054 Unknown column 'region.duration' in 'field list' Exception Type: PDOException


TeamCity pull requests :: netty [Build 283](https://garage.netty.io/teamcity/viewLog.html?buildId=1690&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:29:46


TeamCity pull requests :: netty [Build 284](https://garage.netty.io/teamcity/viewLog.html?buildId=1691&buildTypeId=pulls_netty&guest=1) is now running


Tutti questi check li dovresti fare nei costruttori delle varie istruzioni. Primo perché è più pulito, secondo perché così stai dicendo che un'istruzione è fatta di una sola microoperazione. Ricorda che devi usare il metodo addMicroOperation() della classe astratta Instruction, come ti dicevo, per aggiungere una microoperazione all'istruzione corrispondente, durante la fase di assemblaggio!


Entendi, mas nesse caso foi meio redundante. O dj_database_url, já oferece o `DATABASE_URL`. Se setar nesse nome, ele pega automático.


this could be a guard statement too.


Remove commented out sections


utilizza le istruzioni in minuscolo, perché così le passa l'assemblatore


I suggest not to use negative numbers.  Something like this:
S( 20,  20), S( 10,  10), S(5, 5), S(0, 0)


OK, I thought that System.getenv() will get all the variables in the context even if they not start by taulia_component. Like JAVA_OPTS for example.


Maybe as part of a release we could add a file (in resources) that contains a list of images that should be updated. Instead of having to update each script. This could also be used to update LQ images to HQ once they become available. In lieu of a non-functioning HQ image updater.


remove commented code


Also, I meant for the horizontal widget to be a separate widget type that can be selected per shortcut, not a global option to convert all of them to horizontal.

Prior to Skin Shortcuts, Metropolis used vertical lists for all of the widgets except Addons and Weather.  It's fine to allow the option for vertical lists for Addons, but I'd like the option to use horizontal icons as well.


guard?


The other two `Exclude` parameters that we have in the default configuration are in `default.yml`, so maybe it would be better to keep them all in the same file.


This is probably one of the weirdest line I have written in some time.


closes #39 (sorting, scrolling if more files). Keeps showing DOS 8-chars names.
Need to test it on real hw tho


@jch : I’m currently gathering more info on how that security problem is widespread. I’ll probably tell more about it next Monday. A part of it can be done shorter if you would tell @mastahyeti to check his e‑mails more often.


int x, y = 10, z = 5, ten, five, coin;


FANTASTIC!


looks good


It'd probably be fine if the "Always show widgets" option only applied to Home1, and defaulted to True.


Reference #806


Added a paragraph for the MuleSoft Certified tier.


This code contains several dimensional charting (dc) methods


En realidad este test es malísimo pq no prueba nada, pero funciona, si en vez de hacer redirect_to(instance2) se hace redirect_to(instance) o sea a si mismo, la salida es This is a crazy method o sea que ejecuta el inject y el redirect_to (que ahora no falla pq le puse el unless).

Una vez que esté mergeado me pongo a full con los tests


ack :)


The duration of this layout not processing the duration of the feed, when life is marked by item.


Add a test for this


Add test for htis as well


pls


It would be good for maximum clarity to comment that the app_dev parameters are mandatory only in the context of dev_env being true.


Good point! Missed that one...

Thanks!


Same comment as above.


PrepForRelease (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1360 of 1360 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.36%25-green.svg)


I overlooked the imagePickerControllerDidCancel method on my initial version of the project.


This was **unecessaary**, the checking can be done outside. and `mysql_` function is **deprecated**. To use `mysqli_` we need an object of `mysqli_`, this is available only inside the classes.


@thiliA License file is missing.Please add


I took the latest qxt version and copied it into the source tree.
IMO it has to hook into gui-private to get access to the primary screen. I think that was the problem of the former version - there was no such call. If you know a better way... :)
(I am so glad it runs at last)


You are distributing Suning copyrighted material. NewEBuy-master must be deleted immediately. If not done in a timely mater, we will take legal actions.

- Suning Administrator


Submenus should also not be visible until focused for Home2/Home3.  The extended text from the media overlay can run over it if the label text is long enough.  We can't just reduce its width because we now have customizable submenus, and thus cannot guarantee it won't overlap.


Yeah. This makes sense now.


doh, will fix


Just out of curiosity, what was being thrown that wasn't a RuntimeException? An actual Error?


I agree these should be thrown, but with no way to catch and explicitly handle, you might as well be throwing Exception with a generic message. Also doesn't look like they are ever being used outside of the context of a throw.


This looks right to me.


Выбранная тема является на мой взгляд весьма востребованной.
Строгих замечаний не имеется.
Есть предложение. Можно помимо обычного перевода из одной системы счисления в другую, также показывать ход решения, или например алгоритм перевода в отдельном окошке. Это было бы неплохим дополнением (пояснением) для пользователей (студентов).


This is essentially to support both instance and class methods, using the `self.included` and `extends` mechanisms, from the same Module.

The `tree\utils\json_converter.rb` is a good example of this.


That worker also gave unrealistic results for some other smp test before, but I don't remember which one since it was purged. It was something like 2:1 win:lost ratio, but this one is even ridiculous.


I'll pull this in with a few conditions:

1) "Always Show Widget" option should only apply to Home1 and be enabled by default,
2) Submenus should only be visible when focused in Home2/Home3,
3) Weather Widget visibility should match the others (hidden until focused, unless Always Show is active on Home1),
4) Break out the horizontal widget stuff.  It doesn't really belong in this commit.


Good to know.


because I am dumb.


GHX_Vert_IDD (mmatts) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.04%25-red.svg)


shouldn't this strip the scala-VERSION prefix?


This breaks testing.


makes sense


instead of [double-checking for NULL](https://stackoverflow.com/questions/4190703/is-it-safe-to-delete-a-null-pointer) actually *stetting NULL* after delete is the better way doing that.


Just delete this please.


I think that after messing a lot with my buffers, I introduced a very rare stream corruption and I thought about blaming these indexes(more optimized = less buffers in rotation = more likely to trigger such a thing)...so it's interesting for me to see such a change and pull it.


I'm not sure.
Qt 5 provides `QX11Info` in `x11-extras`, see http://doc.qt.io/qt-5/qtx11extras-index.html
Hence, check at Line 36 at `src/libqxt/qxtglobalshortcut_x11.cpp` seems to be placed invalidly. It forces to build agains `gui-private`, which is worse than `x11-extras`.


error C2143: syntax error : missing ',' before ':'


Yup and it also eliminates method "mongorc_file" from this file


add return type


I do plan to. I've been keeping it in (and enabling/disabling as needed) so I can test the refactoring.


won't this do funky stuff in the bazel uses a different Java than the one under /usr/bin/ ?

Not something to fix in this change, but could use a comment.


#include<stdio.h> -> #include <stdio.h>


Where does qxt live now? Can you send me the link to a latest repo so I could report it and maybe fix?


Brazos


Thanks for the heads up.  I changed the license in 3bfa796.


this is good. update readme.txt to include this in the template section and we'll merge!


We might want to be careful with putting images we don't own the rights to in a github repository.


That's


its


This is slick


That's have some shit to do with recovering options.


Generally you'd want to set up bower to download libraries like Materialize and jQuery and then ignore them in the .gitignore


Hey hursty!! You goal is 3.10 on rcu?


Needs tests and some documentation.  Can't wait to see it running live!


forgot to change this


sdfghjkl


This is the proper string. Please revert to this one.


shouldn't this specify strip_prefix ?


final


nupe


JSONConverter only calls `base.extend(ClassMethods)` in the included hook, which is perfectly reasonable, it does not define any methods in the hook.  I am asking about this module where you do:

```ruby
module Mod1
  def self.included(other)
    def foo
    end
  end
end
```
So again, is there a good reason for this?


get rid of that annoying delete call, let it clean up itself.


because im a nitpicking retard


Better squash those types of commits.


This should probably be atomic in regards to the decrement


run check-style


The point is to stay as close to Rust source grammar naming as we can to preserve 1-1 matching (except for trivial conversions like `ty` -> `type`). If your suggestion is consistent with it, then i see no other bars.


I would like to have the advice of the others users.


Drop that line, egg _metadata_ should be preserved from upstream, see https://github.com/openstack-packages/python-os-testr/commit/70039d8fac0c558632ec5e8bc37f4efff4b7af8d


error C2143: syntax error : missing ',' before ':'


And developers


Brauchst du dann die 'oc2.h.js.php' noch? So wie ich das Überblicke nicht, die eine Funktion kann ja in die 'onlinecodex2.js' wandern, was denkst du?


we should document the purpose of each test


Cheers, I've used a solution.


That worker do not report losses :) 78:0 so far.


PrepForRelease (Myoldmopar) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-71.73%25-red.svg)


That's the way to go.


Oh guys !

The retexturing phase is not so near.
For now, we can distribute the skis as a single texture file for all liveries.

When the cut will be made, i guess that independent parts will be fixed by the old ctrl-c ctrl-v in gimp.

The issue is more related to the fuselage and interior, what is changing shape.

Gil. The panel is up now. A lot of relocating. All external models (instruments) and all rotating peaces (buttons, etc) needed that the center be declared on the xml file.

Now, i ask.

(1) About the instruments, ok that the external model exist, and we can just grab then. Bu why not just import it into the blender file ? Realocating things will be much more easy ;

(2) There is a lack of a relative_rotate in the code. Ever you need rotate, you also need to inform the center of the rotation into the xml. Most of the times, this center is exactly the center of the object. We should just inform other things into xml file, and, if center was not informed, the rotate code should use the center of the object.


In RDO we have Django 1.8 - is this missing there too?
Which support for tests did you mean, is there rhbz# to track this?


I also removed the console.log lines. probably speeding up the script a tiny bit


Yes, it is listed in the jar metadata in the overview.


Yes, it does! But even right now (without this change) that's the case, so you can reference `JAVA_OPTS` in typesafe already. The difference is that it would now be `JAVA.OPTS`, but I don't think that would have any impact as the dot-notation is just in typesafe


I'm working at this moment in tests for those ext methods. I'll make a new PR for that. Thanks a lot!


Das 'make' Command auf die 'main.php' kann auch entfallen


Rather than testing here, how about just resetting the callback?
Something like:

```c++
static void http_reject_request_cb(struct evhttp_request* req, void*)
{
    LogPrint("http", "Rejecting request while shutting down");
    evhttp_send_error(req, HTTP_SERVUNAVAIL, NULL);
}
```
(Assuming the http functions work like typical libevent callbacks, there should be no need to dispatch to the main thread since this is running from a callback)

Then in InterruptHTTPServer() add:
```c++
evhttp_set_gencb(eventHTTP, http_reject_request_cb, NULL);
```

IMO that's more straightforward, as it means that the interrupt logic doesn't depend on app shutdown logic


บน mac รันไม่ผ่าน

```
fatal error: 'conio.h' file not found
```


Can the `NamesIn` class be unified with `GetDefs` in `Agda.Syntax.Internal.Defs`.  Maybe a parametrized common traversal.


Oh, nvm, libqxt seems to be dead.


@mrunge I see you have been messing with python-selenium http://koji.fedoraproject.org/koji/packageinfo?packageID=18089
What's missing to get it on EL7 ?


Looks like OSDMap (full and incremental) hit v 6 before v0.35.  The only way we could realistically see such a map is for an upgrade from v0.34->argonaut->bobtail->firefly->hammer quickly enough that the v5 maps from v0.34 aren't trimmed.


TeamCity pull requests :: netty [Build 284](https://garage.netty.io/teamcity/viewLog.html?buildId=1691&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4765, ignored: 21 Build time: 00:29:43


TeamCity pull requests :: netty [Build 285](https://garage.netty.io/teamcity/viewLog.html?buildId=1692&buildTypeId=pulls_netty&guest=1) is now running


คำสั่งนี้มีไว้ทำอะไร?


to fix #4


Still, might as well fix the decode.


This component renders the banner of a team and also displays a team title.


Nit: boost::lock_guard would be lighter for these.


GHX_Vert_IDD (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (803 of 804 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.88%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-20.79%25-green.svg)


Ah - autoprefixer will need to become a production dependency as well then.


Remove commment


s/bannerObj/bannerObject/


一部の翻訳を変更
  -魔「導」制御ベルトを魔「動」制御ベルトへ
  -Thaumarhia発生時の文章（warp.text.1）を変更
  -「不明な知識」を「未知の知識」へ変更
多くの未翻訳の英文がen_US.langと食い違っていたため修正
「研究」の一部を翻訳


Repeat of number 3?


As written, element is pointing to a DOM, not a jQuery object. This is why adding classes to 'element' didn't work. To convert into jQuery object, add the jquery constructor: $().


@thevirtualfer Hey man, thanks for the update.

> The retexturing phase is not so near.

I know that there are tons of things you want to improve in the 3D model, but have you any idea of when we may have a relatively stable version of it here on our repo? As of now, any work on the 3D model (as well as damage models), instrumentation and texture will have to be readapted (or lost) once you finish your work, so basically only programming things have a green light right now. This means that the whole visual side of the project is kind of frozen until you finish.

> The panel is up now. A lot of relocating.

I'd love to see a screenshot of that! :smile:


Overall:
* please create rpm-master and drop master branch
* drop %changelog https://www.rdoproject.org/packaging/rdo-packaging.html#_differences_between_master_and_rawhide_packaging


This was just copied from the tuskar-ui spec. it was moved from later in the file to earlier at the request of someone.


tlp-banner


Que dijimos de las migraciones? hahaha


I have not. I copied tuskar-ui's spec as per a suggestion and those comments were all part of it to begin with.


Is it really -catalogG ?


k. will do. thanks for reviewing.


Line 64 is redundant. I already know that the current element is pointed to 'this'. Use 'this' to access its index. Delete line 64 and change line 65 to: index = $(this).index();


Indeed so. Thanks.


how do you remove a name?


this doesn't seem durable, what if the process crashes or reboots? it wont republish names anymore. ipns republishing needs to be durable.


When using TH, on existing tables, if the table name and one of the columns is the same, it'll blow up as it tries to create both a function and an accessor of the same name.  In that case, prepend the accessor with an underscore.

Also if your table has any columns which start with numbers, that's invalid in haskell, so in that case also prepend with underscores.


Want to indent these lines with 4 spaces to conform with the rest of the code?

Looks good overall, maybe you can add a Changes attribution?


public static function getRouteDestination($route = null, $filter_vendor_app = null)
ligne 143  return $result; ==> return nothign and not declared
normal ?


TeamCity pull requests :: netty [Build 282](https://garage.netty.io/teamcity/viewLog.html?buildId=1689&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 3406, ignored: 12 Build time: 01:30:18


Awwwwwww


Nice idea.  Good point about multiple workshops


TeamCity pull requests :: netty [Build 286](https://garage.netty.io/teamcity/viewLog.html?buildId=1693&buildTypeId=pulls_netty&guest=1) is now running


@azi Add a simple spec to see if the markdown renders correctly.


TeamCity pull requests :: netty [Build 285](https://garage.netty.io/teamcity/viewLog.html?buildId=1692&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4783, ignored: 16 Build time: 00:10:14
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testResolveAAAA: <no details avaliable>

```


what's new?


oops


integer vs numeric?


I just tested the basic functions of the updates.  For the CustomValue module  I used the sample usage code documented in the module along with the $msg = $elk->readAllCustomValues; and then just the main message loop as updated in the Command.pm sample usage.  If there is a more formal way to do testing or for documenting tests let me know.  (I'm a hardware guy that just dabbles in software).
Also someone pointed out to me that ElkM1::Control is failing with ArmStatus messages from at least the 5.3.0 firmware of the M1.  It is sending AS messages with a bad checksum.  I plan on updating ElkM1::Control to just ignore bad messages instead of croaking.


also, why not use "between:0,4"?


should be createdAt


Correct, there is intentionally no 8 or 9. You'll find pvr.wmc is exactly the same for this, and several other of these nitpicky things :)


Попробовал. Может я что не так делаю.
 org.hibernate.validator.constraints.
javax.validation.constraints.

Не работает, также как и {min}, {max} и т.п.
Запушил вариант messages_ru.properties

25 сентября 2015 г., 13:41 пользователь Slava Semushin <
notifications@github.com> написал:

> Давай улучшать:
>
> Во-первых, добавим полные имена классов. Вернее не классов, а ключи для
> локализации. Например, для вместо NotBlank должно быть
> org.hibernate.validator.constraints.NotBlank.message.
>
> Во-вторых, вместо {0} и {1} начнем использовать более внятные названия.
> Кстати, сходу не знаю чем заменяется {0}. Если узнаешь -- расскажи :)
>
> См. также
> http://docs.jboss.org/hibernate/validator/5.1/reference/en-US/html/chapter-message-interpolation.html
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AleksSPb/Spring-demo-App1/commit/8385b82a3a93088ea605af25ae2168e3ea493534#commitcomment-13435082>
> .
>

--
Всего наилучшего, Пархоменко Александр


excelente tenia el mismo problema y el parche funcionó a la perfección


there are issues here
if (documents?.Count != fileBytesList?.Count) . I just removed the ? ?
But also what is "nameof"

Already merged this. So we need to fix ASAP
@Patman0021 please advice


technically there should never be two elements with the same `id` on the same web page, and that causes problems when running tests under phantomjs-1.x, so I propose to use class instead of id.


Lol this is fixed on the following commits with StyleCI :)


This should be changed back to `==` after the last_sale_price for positions is implemented, correct?


all variables in our code need to be camelCase as per PSR-2, all variables in views and models should be snake_case, coz fuck PSR-2, lol


I'd like @mrunge  to review this, we should have common guidelines/template for all Horizon UI plugins packages.
Is there any guidelines @mrunge ?


What are you using, VS 2010?


> instrumentation and texture will have to be readapted (or lost) once you finish your work

There will be no loss of functionality. And i can't think in an instrument that will be affected by the retopo. Maybe there is. Hehehehe !

> This means that the whole visual side of the project is kind of frozen until you finish.

I understand. But we can continue changing the visual of the plane.

Only the parts that changed shape (fuselage, wings, tail and cabin) will be strongly affected. All other things like tires, damages, shadows, etc, will be fixed in a shot, i guess.

We need not frozen anything.

> I'd love to see a screenshot of that!

Oh !

I will put some dumb texture and show. But be warned. It will lack something for now, because the UV mapping.

Cheers, bro.


thanks


lol I just did it to be consistent, in that case we should rename all of these https://github.com/cachethq/Cachet/blob/3f8471d8da3edaf5158436551dac3a3fc193b749/app/Commands/Metric/AddMetricCommand.php#L42


Ja das `make` auf die `index.php` kann anscheinend weg.

Die `oc2.h.js.php ` würde ich gerne drin lassen, da man damit Daten zur Compiletime einbinden kann. Aber deine `initArmeeDialog()` würde ich vorschlagen in die `onlinecodex2.js ` zu verschieben um möglichst wenig Logik (JS) in der Präsentation (HTML & CSS) zu haben.

Wenn ich es mir recht überlege könnte man denn gesamten Scriptblock dahin verschieben.


Also the validation rules should be in camel case, if not our validator won't find them


openstack-dashboard requires p-d-horizon so it's not needed explicitly
Same for python-django and *client


> Only the parts that changed shape (fuselage, wings, tail and cabin) will be strongly affected.

Fuselage + wings + tail + cabin basically equals the whole plane, doesn't it? :smile:

> I will put some dumb texture and show. But be warned. It will lack something for now, because the UV mapping.

Sure, you can show some untexturized version, I am curious about the 3D model of the panel, particularly how the top part looks like now.


How many times are you going to make this commit, it notifies me every time .-.
You don't really have to mention me in the description, it's just a badly written update packager.


Teste


Replace these lines with `cb(err)`


meh, maybe we should leave it then


ditto


Guru _/\_


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#OFkT0S_fSr6ZRGn_7MS9UA


typo. welcome


Added this line to clear the DGrid when Clear graphics Button is clicked.


just means we're inconsistent with styleci - that doesn't matter so much - just something to remember when we work on them both in the same day, lol


Upstream question, but anyway, I wonder iIs there any registry for Horizon plugins i.e. how are collisions under /etc/openstack-dashboard/enabled/ are avoided?


Should we just remove this if it's commented out?


Maybe set a low http timeout first?
```c++
if(eventHTTP)
    evhttp_set_timeout(eventHTTP, 2);
```
Not sure if that's retroactive or not, but it would at least help with the post-shutdown rejection requests I think?


+1 for feeding hungry children


```php
$this->app['nut.commands.add'](function($app) {
    return [
        new Nut\AccountCreate($app),
        new Nut\AccountDisable($app),
        new Nut\AccountEnable($app),
        new Nut\PasswordReset($app),
    ];
});
```


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#cpM4QJxfQ7mokhQUg3UgeA


:smile:


Whoops, I actually need those.


New line.


Your key deletions are showing:  musetic/settings/base.py


Keep empty %changelog
e.g. https://github.com/openstack-packages/keystone/blob/rpm-master/openstack-keystone.spec#L240


Should we just delete?


Actually, I don't, removing now.


Ok, the decode is actually fine.  The problem is that without the PGID64 or OSDMAP_ENC bits, we encode using encode_client_old which isn't a complete v5 encoding, it doesn't have the extended section which I guess clients didn't get in v5.


I don't know.
This setting should be set to 'true' to minimize bugs


So `home()` (`process.env.USERPROFILE` on windows iirc) is not involved at all when it comes to npm cache folder? This should be a separate node module imo. Maybe it even exists already? :)


Do we need to reply to specific message? Can't we just send a message to that number and dismiss the notification?


There's a registry here:
http://docs.openstack.org/developer/horizon/plugins.html

There isn't a collision mechanism defined. :/


Please change the function name and also.. module two should be in its right place


No. ok. thanks.


done


lol :stuck_out_tongue:


Maybe `NodeFactory`


Thanks for reviewing.


You're right. This probably breaks things when trying to update an existing recurring recording. My focus was on testing they all get created, but less so on checking they could be later edited.


Ich seh grad `oc2.h.js.php` kann auch das `make` weg. Aber lass das mal bitte alles mir (alos das mit dem make). Erstmal stört es ja nicht weiter.


- https://github.com/rails/rails/blob/3e36db4406beea32772b1db1e9a16cc1e8aea14c/activerecord/test/cases/connection_adapters/merge_and_resolve_default_url_config_test.rb#L18-L23

- https://github.com/rails/rails/blob/3e36db4406beea32772b1db1e9a16cc1e8aea14c/activerecord/lib/active_record/connection_handling.rb#L47-L60

basically, Rails doesn't can't and doesn't parse `config[:makara][:connections].last`, so I just have it parse `{ url: config[:makara][:connections].last[:url] }` and ignore the adapter from that output and remove `url` from the config.

`mysql2_makara` is not a valid protcol, so if that were in the url, it would fail parsing with an invalid uri error


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#cMyYsfLfQSiWt7_r0EQLEQ


@veloce this simple commit fix everything!
![screen shot 2015-09-25 at 19 40 41](https://cloud.githubusercontent.com/assets/1011289/10107778/970568e8-63bd-11e5-918a-4e364f19d030.png)


Why were the animated banners removed from the list?


I can only find once reference to `'google-signin-aware-offline-success` here. Would it be possible to add some docs for the event?


I'll make those changes, and post the commits tomorrow sometime.


I am having trouble pulling my new improved copy of Quiz 1 where I added the two comments - they are stated below


optimization of what?


Jojo, aber die eine Funktion ist schon längst bei mir alles in der onlinecodex2.js. Waren ja nur die ersten Versuche.


//Karel starts to pick up the things


Updated README.md


//Karel starts to put down the things


We appear to be relying on ES6 Promises here. As the signin element doesn't include a Promises polyfill itself, would this limit us to evergreen browsers but cause issues for IE10 and IE11? Edge is the first IE that includes Promises support IIRC.


r+


Are you doing it both ways... I was reviewing the docs.. and if you are doing it one way it would be nice to do it the other way as well... so if you are receiving the message.. you could have the value set.


we would need some javadoc here saying what this is... this could eventually be useful on other protocols.

It could be said as an optional field to determine the mime-type of the message-body.


Looks good to me.


TeamCity pull requests :: netty [Build 286](https://garage.netty.io/teamcity/viewLog.html?buildId=1693&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 4783, ignored: 16; resource leak detected (new) Build time: 00:22:20
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testResolveAAAA: <no details avaliable>

```


com


Hiera?  Looks like this isn't a [template issue](https://github.com/puppetlabs/beaker-template/blob/master/bin/beaker-template#L30).


Solange es nicht im Repo ist existiert es nicht.


the only difference between this method and the `facter` one above is the name of the command being used.  Refactoring these methods into a helper could be a nice win, but I can understand if you want this move to be as 'low touch' as possible.


Thank you!  This is one of the main issues I had when setting up my repository.  I could not figure out what Kodi was looking for as far as zip file naming convention.

Would something like 21.09.15 work?  I'd prefer to just use date for my versions to keep it straight in my head, although for increasing versioning numbering system, MM.DD.YY would make more sense.


Relative imports are much more robust than global constants.

The `public` folder let you separate what is publicly exposed (`index.php` and static resources) from the application code. I would not recommend to put the `vendor` there.


indeed, much much nicer! LGTM :+1:


This tree is only for compiling TWRP .. For cm .. the tree is unstable ,,and not booting


Please remove this pr_debug() it would be too noisy for regular traffic.


Rename to `addContentNode`, don't use shadow dom terminology here...


You didn't have to remove the target, you could have simply removed the scheme which was a lot simpler to integrate back in later.


we dont really have a need for removing a name yet. but when we do it will be another three line function like this that calls `delete(rp.entries, id)`


There should at least be a vagrant host file in the nodes folder, since this can be used by the community.

Feel free to just copy over [the template hosts file](https://github.com/puppetlabs/beaker-template/blob/master/acceptance/config/nodes/vagrant-ubuntu-1404.yml) if you'd like.


Ah, I see.  It's moot anyway since another solution was merged :)  Thanks for explaining.


These are two screenshots when the sim just starts.

The original one (wrong textures)
![screenshot from 2015-09-25 14 39 43](https://cloud.githubusercontent.com/assets/10703842/10107912/7a398c36-6394-11e5-86f3-e3373c1b18cb.png)

Reallocated one (wrong textures)
![screenshot from 2015-09-25 14 39 43](https://cloud.githubusercontent.com/assets/10703842/10107936/abaee0a4-6394-11e5-9660-e1541197ea7e.png)

To get the feeling of the difference, import the images to different layers on gimp. Then, play with show/hide layer and judge by yourself.


TCP_SKB_CB(skb)->dss[1] is the len of the TCP option. When would this one be 1? What exactly is the test doing here?


I'd suggest updating this comment to state that the VersionID will only be returned if the bucket is versioned, and will not be set if the bucket isn't versioned


Please remove this pr_debug as well.


this should probably be set to the vagrant hosts file that should be included (see comment on that below), because we want to make sure that acceptance testing works from the Rakefile by default no matter what (meaning it should work for community members too).

I'd be down for a similar rake task that defaulted to this hosts file, to make it easier for internal peeps though.


Simply do TCP_SKB_CB(copy_skb)->path_mask |= ~(mptcp_pi_to_flag(...));


Same for this pr_debug.


Remove return type, do a `return null` where it is needed.


I have confirmed this resolved that error for me in three different environments (sandbox, test, production).  I am not familiar with creating pip packages.


Not if it's durable.

—
Sent from Mailbox

On Fri, Sep 25, 2015 at 1:54 PM, Jeromy Johnson <notifications@github.com>
wrote:

> we dont really have a need for removing a name yet. but when we do it will be another three line function like this that calls `delete(rp.entries, id)`
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ipfs/go-ipfs/commit/29304ab953640fe3f92f5de3e04aa4ca366504d1#commitcomment-13443854


this method is called during node construction. I'm not sure what situation youre concerned about.


I'm not sure what we are testing for here. end_seq should never be smaller than snd_una. And if it may be (please explain in which case it could), the test should be done right at the beginning, not inside the loop. Or may it be that skb->end_seq != copy_skb->end_seq ? I don't see how this could happen.


Oh my goodness, this looks so much better. :clap: I know this is still a work in progress but I'd like to make just two little comments (feel free to ignore them if you already thought about this): 1) the compass must be moved upwards as well, 2) the "walls" around the plane (i.e. fuselage thickness) seem to me to be still too thick, see this image here:

![image](http://i.ytimg.com/vi/y0A8849h1Uo/maxresdefault.jpg)


Hmmm, this might be wrong, are those separated by ';' on Windows?


I don't understand why we would send reinjected segments redundantly as well. Because, when a segment is reinjected, it already has been scheduled once on a subflow. Thus, it also has already been scheduled for redundancy once as well.


what? I think we're on different pages about how this works...


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21237/testReport/) for this commit**


TeamCity pull requests :: netty [Build 287](https://garage.netty.io/teamcity/viewLog.html?buildId=1700&buildTypeId=pulls_netty&guest=1) is now running


Hehehehe !

It is a "working in progress", dude. Take it easy.


Highlight looks good when I select the URL bar, but if I start typing something and the domain is autocompleted, it still uses the light blue color.


GHX_Vert_IDD (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1339 of 1340 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.93%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.23%25-green.svg)


Doc_Cleanup (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1896 of 1896 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Excellent!


See #1293 .


we need artifacts and plugins to pull files out of the container. Not sure if that would still work.


it happens every time we get a full map in the normal case.  that doesn't happen taht often since we usually deal with incrementals, but i can happen if there is a map discontinuity (osd was down for a long time).  in any case, it'll be well logged elsewhere.


TeamCity pull requests :: netty [Build 288](https://garage.netty.io/teamcity/viewLog.html?buildId=1701&buildTypeId=pulls_netty&guest=1) is now running


Thanks! The reason I rearranged was so the function variables are declared and defined in a single location. This seems cleaner and clearer to me (and my OCD).


I just wanted to thank @josevalim and everyone in the core-team and contributors, for putting so much effort and dedication into doing something as beautiful an amazing as what Elixir is today.
:green_heart: :green_heart: :green_heart: :green_heart: :green_heart: :green_heart: :green_heart: :green_heart: :green_heart: :green_heart: :green_heart: :green_heart: :green_heart:

_really well done_


> I know this is still a work in progress but I'd like to make just two little comments


delete last line


:facepunch: :dizzy_face:


int x, y = 10, z = 5, ten, five, coin;


TeamCity pull requests :: netty [Build 287](https://garage.netty.io/teamcity/viewLog.html?buildId=1700&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4676, ignored: 16 Build time: 00:09:15
### Failed tests
```
io.netty.handler.codec.http2.DefaultHttp2RemoteFlowControllerTest.unstreamableParentsShouldFeedHungryChildren: <no details avaliable>

```


TeamCity pull requests :: netty [Build 289](https://garage.netty.io/teamcity/viewLog.html?buildId=1708&buildTypeId=pulls_netty&guest=1) is now running


Doc_Cleanup (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


จัดเรียงโค้ดใหม่


ya know the modals.  In modals.py. They interface with the viaws in viaws.py and render into html by the tamplatats


excellent!


You should put this in a global gitignore (https://help.github.com/articles/ignoring-files/#create-a-global-gitignore) , not in the project


This is in conflict with our documented coding standards which allows:

```
x === undefined
```

What is the recommended way of comparing against undefined? And how can I skip optional parameters?


This is awful.


You should probably apply all of the vulnerability patches instead of just
2 of them.

http://www.linuxfromscratch.org/patches/blfs/svn/pcre-8.37-upstream_fixes-1.patch

On Fri, Sep 25, 2015, 04:25 Vladimír Čunát <notifications@github.com> wrote:

> That commit is contained in master already, so I guess we should also kill
> the 8k jobs in there, too? However, I don't know what to have on master now
> instead of that...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NixOS/nixpkgs/commit/3a472db679c90fcfc515c62afa367c60c509042b#commitcomment-13435727>
> .
>


Yes the create() of the the following modules:
linear regression
logistic classifier
svm classifier
pagerank
label propagation

On Friday, September 25, 2015, Ping Wang <notifications@github.com> wrote:

> @haijieg <https://github.com/haijieg> Do you have the list?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dato-code/userguide/commit/924de25b61ee3e3f7feefdb50f03034cf97baf01#commitcomment-13441503>
> .
>

--
Sent from Gmail Mobile


Just for reference. A handy docker file to run this locally:
```FROM 1science/sbt:0.13.8-oracle-jre-8
RUN apk --update add git
RUN cd && git clone https://github.com/scperkins/play_test.git
RUN cd && cd play_test && sbt compile
CMD cd && cd play_test && sbt run```


and here. The odd thing is that the test passed without icu hehehe. But I'm going to change it anyway thanks!


Looks awesome!


Thanks to this gist: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd


I think the rename is no longer required. Check: https://github.com/bitcoin/bitcoin/pull/6116. It's included in 0.11.


You'll see when it actually returns the types supported, it uses TIMER_MANUAL_ATTRIBS | TIMER_REPEATING_MANUAL_ATTRIBS


We need to find a way to avoid duplicating these URLs so that they're only mentioned in one place.

I'm thinking we should add a public static IEnumerable<string> GetFederatedIndexUrls() that returns those two strings. Then invoke authentication where we try to download from those URLs.

You can do this as part of this pull request or let me know if it should be separate. Then I can accept this one.


LGTM


This will be more stable. Looks Good.


That's not true... It's not a dependency at all. I thought I replaced it with core-js implementation.


Unable to submit cachematrix.R to COURSERA


Good extended coverage.


Maybe I just forgot to remove it.


Super comment.


I should've done a once-over of my commit message, because it's worth pointing out that the save prompts should be appearing if the user attempts to close the editor without saving their changes.

:grimacing:


Doc_Cleanup (mmatts) - i386-Windows-7-VisualStudio-12: OK (1896 of 1896 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This get isn't necessary here, since you already have the job returned from createJob, besides you'll be getting "fresh" copies in the Poll function.


This causes options to not get passed into packager.sh. Please revert. For example, running the following officially stated start command:
(JS_DIR=`pwd`/ReactComponent; cd Pods/React; npm run start -- --root $JS_DIR)

results in this executing:

./packager/packager.sh || true "--root" "the_JS_DIR_from_above"

rather than

./packager/packager.sh "--root" "the_JS_DIR_from_above"

This ends up ignoring the desired root directory and only searching the main default path the script figures out on its own.


[`iteritems` was removed in Python3](https://wiki.python.org/moin/Python3.0). This breaks the `sendgrid` library for all Python 3 users. This has been reported in GitHub Issue #126


Passive voice! "Class outline:"


Era una prueba


TeamCity pull requests :: netty [Build 289](https://garage.netty.io/teamcity/viewLog.html?buildId=1708&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 4783, ignored: 16 Build time: 00:10:30
### Failed tests
```
io.netty.resolver.dns.DnsNameResolverTest.testResolveAAAA: <no details avaliable>

```


TeamCity pull requests :: netty [Build 290](https://garage.netty.io/teamcity/viewLog.html?buildId=1710&buildTypeId=pulls_netty&guest=1) is now running


via Marconi, not guest network


I thought I was being careful about that stuff by importing things explicitly.. oh well. Fixed by 50d142912.


AH, ok thank you for the response, save me some time. If I had the device I would try to get it working but was only going to build blind for a friend


This is dead code. The comment was moved to the code that now does this a few lines further down.


Be careful. Copying it from pvr.wmc does not automatically make it right for NextPVR, but I know nothing about NextPVR - maybe it's just a clone of WMC (honestly, don't know)?

Yesterday I just did a quick review on nitpicking things (basics like indentation etc). But today I concentrated on the code logic and found that your current code still contains serious bugs. See my other comments and don't just throw them away as "nitpicky things" ... and please don't feel offended by the amount of review comments. Take it as a chance to learn how this project works.


TeamCity pull requests :: netty-tcnative [Build 7](https://garage.netty.io/teamcity/viewLog.html?buildId=1715&buildTypeId=pulls_netty_tcnative&guest=1) is now running


TeamCity pull requests :: netty [Build 290](https://garage.netty.io/teamcity/viewLog.html?buildId=1710&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:04


_you_ are using (see below for details).


Heh, no.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.616](http://teamcity.monogame.net/viewLog.html?buildId=10311&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


I don't believe this method needs to exist at all. Polymorphism takes care of it.


TeamCity pull requests :: netty-tcnative [Build 7](https://garage.netty.io/teamcity/viewLog.html?buildId=1715&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:45


You'll notice that when I return the type it's actually TIMER_EPG_ATTRIBS | TIMER_REPEATING_EPG_ATTRIBS.


I'm not specifically aiming to support keyword searches in this first build I'm merging. I'll do a later pull request to add that.


Change var name from expanding to something else (changing...animating...etc)


There's a diff out to fix it by passing the options down.


No, it's used by postcss.


@SubJunk Then I've transferred the translations from crowdin in af0c48e. It seems I was in time?


Set the expanding attribute in the start callback of the animate function to more couple it more tightly


Bug #18809 : Changed personalized text message


No, I'm not so sure.

OTOH, Users will see a very timid message in the middle of their output and, even if we put a warning in the release notes for the next version (yes, I'm planning on writing release notes this time and I would love to receive help with this), I'm *sure* that many people will not read anything. Example:

```
$ ./coursera-dl --on-demand -n --aria2 -- ml-foundations
--on-demand option is deprecated and is not required anymore. Do not use this option. It will be removedin the future.
Downloading class: ml-foundations
Starting new HTTPS connection (1): class.coursera.org
404 Client Error: Not Found
Starting new HTTPS connection (1): www.coursera.org
Logged in on coursera.org.
Downloaded https://www.coursera.org/api/opencourse.v1/course/ml-foundations (52967 bytes)
Parsing syllabus of on-demand course. This may take some time, be patient ...
Gathering video URLs for video_id <iyhctVgPEeWVGAoAtDnZOw>.
Proceeding with download of resolution 540p of <iyhctVgPEeWVGAoAtDnZOw>.
Gathering subtitle URLs for video_id <iyhctVgPEeWVGAoAtDnZOw>.
Gathering video URLs for video_id <KlmwTFgQEeWwsAoexZR4lQ>.
Proceeding with download of resolution 540p of <KlmwTFgQEeWwsAoexZR4lQ>.
Gathering subtitle URLs for video_id <KlmwTFgQEeWwsAoexZR4lQ>.
Gathering video URLs for video_id <FdFtAVgSEeW7ehKhJ-vBVQ>.
Proceeding with download of resolution 540p of <FdFtAVgSEeW7ehKhJ-vBVQ>.
Gathering subtitle URLs for video_id <FdFtAVgSEeW7ehKhJ-vBVQ>.
Gathering video URLs for video_id <_EBC1VDEEeW9uQ44CNOOxw>.
Proceeding with download of resolution 540p of <_EBC1VDEEeW9uQ44CNOOxw>.
Gathering subtitle URLs for video_id <_EBC1VDEEeW9uQ44CNOOxw>.
Gathering video URLs for video_id <teDj3VgVEeWwsAoexZR4lQ>.
Proceeding with download of resolution 540p of <teDj3VgVEeWwsAoexZR4lQ>.
Gathering subtitle URLs for video_id <teDj3VgVEeWwsAoexZR4lQ>.
(...)
```

And there are so many more lines coming out of this. IMVHO, deprecation messages for user-facing options should be almost hysterical and conspicuous, so that they can't really be missed. The amount of output that is generated with "Gathering foo" etc. just makes the deprecation message "invisible".

To be honest, I don't know what is the best course of action and I am open to suggestions.


Quite possibly. At a glance they differ in that DeadCode needs constructors and names used in QName literals, and doesn't need to worry about metas.


Hi Brendan, I see you're working on adding libiio support, is there any new plan regarding IIO since our discussion in #59?

I'd be glad to participate if there's anything I could help with :smiley:


saw approval from fadushin
at https://github.com/basho/yokozuna/commit/e679a22f6374d75bc9fb1cb04d0712c252d49dd0


merging basho/yokozuna/hotfix/2.0.6-2012.08.25-solrq-per-index-updates+fuses = e679a22f into borshop-integration-561-hotfix/2.0.6-2012.08.25-solrq-per-index-updates+fuses


basho/yokozuna/hotfix/2.0.6-2012.08.25-solrq-per-index-updates+fuses = e679a22f merged ok, testing candidate = 05ed40e3


Great. Two things on this page:

1. Can you link to the Scicomp docs?
2. Make sure that people can copy and paste into a terminal.


Bug #17145:
Changed Generate Rewards Message to Please wait while your award(s) are generated


So we just had our first ICEUpdater failure. It said it received 5 posts instead of 4. I was just looking over the code once more to try to understand why this might happen. With the TestHarness launching several jobs at once and everything going on during the test procedure this has to be rock solid. If you think of failure modes in parallel or threaded runs let me know.

@aeslaughter - correct me if I'm wrong but the calls to the various parts of the Outputs system _aren't_ restricted to just the root process are they? If in parallel each rank is posting, that's going to be a problem. Please advise.


Okay, I'm looking into this more now again. I'm seeing some faults arise after the initial selection.

Also, just pulled down the latest PyART with your ```exclude_gates```. I think I'll convert the code to use this instead of the current method. It's a cleaner approach.


Great, thanks! A couple notes before I can merge this in;

- [ ] When you have a title *attribute*, you can use `the_title_attribute()` rather than `the_title()`.
- [ ] When you have an href attribute, please escape it with `esc_url()`
- [ ] Please ensure your code follows the WordPress coding standards. (it nearly does, you just need some spaces after parentheses on line 18, 19 and 26 and a space before the opening curly brace on line 18)
- [ ] This is my fault, not yours, but please include a URL in the comments at the top of the file where this template is used so we know where to test it


I just rechecked all the recording types, and they all seemed to offer the parameter I expected, and all the expected recordings in NextPVR. I tested one-off from the guide, recurring custom timer from the guide, one-off manual recording, and recurring manual recording. Is there a particular type of recording you didn't think would work?

I suspect it was the or'ing of attributes returned that confused you?


Sorry, but these slides are still not going to get a ton of love from me. We are here to teach them the technical aspects of doing bioinformatics. References to a vague notion of "art" don't seem to add anything.


TeamCity pull requests :: netty [Build 288](https://garage.netty.io/teamcity/viewLog.html?buildId=1701&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 4676, ignored: 16 Build time: 00:23:59
### Failed tests
```
io.netty.handler.codec.http2.DefaultHttp2RemoteFlowControllerTest.unstreamableParentsShouldFeedHungryChildren: <no details avaliable>

```


Doubt most people know changes = chord changes.


Okay, overlooked this. This is especially funny as this is basically a copy of what I wrote myself for pvr.hts.


s/the first/any?


fixed.


Okay, then.


## Se realizará una función que mantenga una función en la memoria caché


Awesome. Thank you.


Next write


s/(no excel/docx)/(your scripts "speak" plain text natively; xls/docx much harder)/


We could not use `exclude_gates` for a while, to avoid increasing minimal pyart version, we update later.


Now that there is another signal in this func, I would suggest that the `this.destroyed` flag be moved to immediately precede `this.emit('destroyed')`, so that it is not set until it is considered actually destroyed.

TChannel even goes so far as to have .listening and .listened (or something like that), which could be applicable, but is probably overkill here.


This will go right over everyone's head.


@hejun-lyne what version of Node are you using?