Yeah I did somewhat regret naming it render script when I started working on AudioScripts. But now that everyone is used to the term, I might just leave them as they are. We can still name them `AudioRenderChain` and `VideoRenderChain` in the extensions framework though.

I think there's no need for IFilter at all as AudioScripts are really quite simple at this stage - it always works on a fixed size buffer and there's no need to "optimize" a filter chain. But it may be easier to generalize the video/audio scripts if we do. You probably have a better idea of how it could be done. Anyway the `AudioChain.Process()` method is how the audio scripts are chained together at the moment. If anything is the audio type of TTexture, I suppose it's `MediaSample`?


Estoy de acuerdo con tu "propuesta de cambio", así que lo añadiré a la versión final. Gracias por el aporte. Saludos.


The length of `long` may vary on different platform, it is safer to use `uint32_t`.


It means `0.x`. Works like this. https://travis-ci.org/deoxxa/duplexer2/jobs/81523511#L83

> ```
> $ node --version
> v0.12.7
> ```


Why also 0.10 in this case?


Ahh ... yes ... seems that I need to avoid kids sitting and reading code of other people at same time! :-)


Oh, I understand. Thank you


How about this one:
```csharp
return nums.Count() != (new HashSet<int>(nums)).Count();
```
Actually same thing.


@jdtournier This OK with you? Realistically it makes bugger-all difference to the calibration result, just spent a while hunting down issues and thought it was worth having it 'as right as possible'.


first Commit


@bolinfest  Not sure what is going on. Even if I have only any one require removing all the others the package load time is still 150+ms on my CPU.
![image](https://cloud.githubusercontent.com/assets/2313237/10011528/868ca1ce-60f3-11e5-89c8-792b849dea03.png)

![image](https://cloud.githubusercontent.com/assets/2313237/10011531/94b41886-60f3-11e5-9198-621e8d3a3565.png)


Just a copy & paste from `add_ha_repo`: this is used to disable the test repo for HA, afaik.


Haha, yes I want to drop supprt of such an ancient version honestly, but some people are still using Node v0.10 [as you know](https://github.com/postcss/postcss-nested/issues/30), and we should keep checking if this module works correctly on v0.10.


What exactly goes wrong with O3?  Does it produce faulty code?


Sorry, it turns out I was commenting on the wrong line.

I was surprised by the change of `#failure_message` and `#failure_message_when_negated` from methods to attributes.

But .. I also incorrectly assumed `#matches?` and `#failure_message` and `#failure_message_when_negated` were independent, which they're obviously not. So now instead of surprised I'm just generally curious about the reasoning behind the change.


 name = fields.Char(string="Customize Name")
     channel_id = fields.Many2one('mail.channel', string="Channel")
     repository = fields.Char(string="Repository")
-    webhook = fields.Char(string="WebHook ID")
+    webhook = fields.Char(string="WebHook ID", help="test")


Yup, we can override that too.  Will push a fix.


It was pulled [here](https://github.com/tessel/t2-docs/blob/master/hardware-api.md) and linked to in `t2-start` by @Frijol.


Need to work on the loop indexes to figure out whats going on for size and remove


I think it's time to release 1.0.0. With semver will be much easier to maintain browserify deps, I think.


I think we only want to show sign up when the "allow local account creation" config flag is set to true.


In progress for fixing #11


This can only be shown when local account creation is allowed


bahaha I missed the other one


I'm not sure I trust timecop. Never seems to show any coffeescript files being compiled even though I removed the cache!


Hello! Any reason for switching from Sass to Stylus? Sass has a much wider acceptation in the front-end dev community (source: http://ashleynolan.co.uk/blog/frontend-tooling-survey-2015-results#q1-preprocessors)


solr start script requests is: "Please install lsof as this script needs it to determine if Solr is listening on port 8983."


#5167-ExampleFile-VariableRefrigerantFlow_FluidTCtrl_5Zone.idf-Warnings (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1345 of 1345 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.28%25-green.svg)


nothing more yesterday? feels like every day is a baby step, let me know if I can help to get this done :)


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I would prefer different name in config, that is not linked to ssh, may be "induce-username-from-email" or some such.


Invertiste el orden de la llave para que el primero sea el ultimo?


Timecop can be skewed by the other packages you have installed. For
example, I think you may have a dependency on lodash. If you have another
package that also depends on lodash, then whichever one gets loaded first
is "assigned" the cost of loading lodash (assuming both packages load the
same version).

So the best way is to disable all of your packages except for the one you
are measuring.

On Monday, September 21, 2015, Graham <notifications@github.com> wrote:

> I'm not sure I trust timecop. Never seems to show any coffeescript files
> being compiled even though I removed the cache!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gandm/language-babel/commit/e03c01bb628dee4ba62b1f642918f37ae07cf5f2#commitcomment-13359013>
> .
>


@rwaldron true, I was just trying to being consistent in case we added other flags later. I'm happy to remove in a separate PR.


@amanwriter I don't think the parenthesis are required, should be

``` python
del self._pingers[node_id]
```


Thanks Hoang!!


@rwaldron I don't recall exactly what happened but I believe I got an error that the result of that function didn't have a `version` property. I was in a car on the way to the hackathon so it was kind of a blur. Will go back over these changes this week.


Gah - perhaps it makes the most sense to just revert this change.


Do we need migration docs/script to add the new column? When I ran this on my existing data set, I got:

```
[2015-09-22T05:48:36.889Z] ERROR: oae-cassandra/75577 on Nicolaass-MacBook-Pro.local: An error occurred executing a cassandra query
    HelenusInvalidRequestException: Unknown identifier countryCode
        at onReturn (/Users/Nicolaas/Desktop/ApereoOAE/Code/oae/Hilary/node_modules/helenus/lib/connection.js:420:23)
        at client._reqs.(anonymous function) (/Users/Nicolaas/Desktop/ApereoOAE/Code/oae/Hilary/node_modules/helenus/node_modules/helenus-thrift/lib/thrift/connection.js:80:11)
        at Object.CassandraClient.recv_execute_cql3_query (/Users/Nicolaas/Desktop/ApereoOAE/Code/oae/Hilary/node_modules/helenus/lib/cassandra/Cassandra.js:8331:12)
        at /Users/Nicolaas/Desktop/ApereoOAE/Code/oae/Hilary/node_modules/helenus/node_modules/helenus-thrift/lib/thrift/connection.js:83:37
        at Socket.<anonymous> (/Users/Nicolaas/Desktop/ApereoOAE/Code/oae/Hilary/node_modules/helenus/node_modules/helenus-thrift/lib/thrift/transport.js:74:11)
        at Socket.emit (events.js:107:17)
        at readableAddChunk (_stream_readable.js:163:16)
        at Socket.Readable.push (_stream_readable.js:126:10)
        at TCP.onread (net.js:538:20)
    --
    query: UPDATE "Tenant" SET "countryCode" = ? WHERE "alias" = ?
    --
    parameters: [
      "BE",
      "cam"
    ]
```


I am getting the below error due to this commit. Basically the file in question is frappe/patches/v6_1/rename_file_data.py
http://pastebin.com/aVCq6ZmG


is it removed ?


nope ..added enter after that


Hi! Because I just like it :)
It's a development tool, we haven't decided yet what the starter theme with ship with in the end . Probably sass yes.


aaa


Given that this library is 250k minified, should we try to not include it and just paste the list of countries and codes into our JS? I'm assuming we'll want to do that anyway once we make them i18nable.


We try not to do capitals in ids. Something along the lines of `reatetenant-country-select` would be better.


Should we rename these to `country` instead of `countrycode`?


mBridgeContext is null in the else section?


You're right in that it's less a hot path than, say, a ping path. At steady-state, this path is a non-issue. Holistically, I'd like to take less of a dependency on underscore rather than more.

No matter, if we know we can go faster with some code that is a bit less concise, then why not? Otherwise, I feel like we only continue to accrue more and more perf debt.


Sorry, I'm a bit confused. Does this relate to #354? I'm assuming it doesn't, but then I'm not sure I understand the rationale behind these changes... In what way would this make the calibration 'right'? Is the idea to somehow 'sharpen' the distribution to be used in the calibration, so that the calibrator will suggest increased density of sampling during tracking? If that's the case, I think I can see why this might be a good idea. The situation you'd be using to calibrate is going to be a fairly common occurrence, and would lead to a sharper distribution - especially for large step sizes...

Does this reduce the incidence of calibrator failures...? And does it impact performance? I'd expect increased sampling density would have an impact on speed of execution... But if it helps improve the validity of the sampling, then that's that...


I've added a test for the scope in f54135f5464ee62744937ab9ce8365187fbe8802.

I could not find a clear way to test rake tasks. Everybody seems to have a different opinion on that matter so I'd like us to have a look at it during our last call.


I've removed all requires in transpile.coffee. Makes no difference!


Given that we need this in multiple places, we'd probably want to paste it in a small new module


Unhandled Fundamental Failure


generally speaking, every statement from ringpop should have a ringpop prefix. much easier to filter in ELK.


That plugin can do the i18n and the sorting


#4402-VRF-outputs-and-multiplied-floor (rraustad) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The existing message feature is only between users. Once a message is deleted, it deletes the whole chain.


closes #262


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Can we do this as an HTML template?


Can you add an `@see` to where this is documented?


compiling errors pasted below:

Scanning dependencies of target ttcp_muduo
[ 42%] Building CXX object muduo/net/protobuf/CMakeFiles/muduo_protobuf_codec.dir/ProtobufCodecLite.cc.o
[ 42%] Building CXX object examples/ace/ttcp/CMakeFiles/ttcp_muduo.dir/ttcp.cc.o
/home/wangke/codes/github/muduo/muduo/net/protobuf/ProtobufCodecLite.cc:30:7: error: ‘{anonymous}::dummy’ defined but not used [-Werror=unused-variable]
   int dummy = ProtobufVersionCheck();
       ^
cc1plus: all warnings being treated as errors
muduo/net/protobuf/CMakeFiles/muduo_protobuf_codec.dir/build.make:62: recipe for target 'muduo/net/protobuf/CMakeFiles/muduo_protobuf_codec.dir/ProtobufCodecLite.cc.o' failed
make[2]: *** [muduo/net/protobuf/CMakeFiles/muduo_protobuf_codec.dir/ProtobufCodecLite.cc.o] Error 1


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The change to file editlist.php fails due to $tables not existing. This seems to be caused by including that file from within a function in connect.php, therefore the file is no longer in global scope.

Original problem reported in the user forums https://discuss.phplist.org/t/database-error-1064-while-doing-query-version-3-2-0/880/1


97668326-WholeBuildingLoad (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Fix issue #3 and #2


comment


Fixed issue #2


It looks like we're doing these advanced updates twice


Does this definitely remove a shuffle?  I was talking about this with Sandy, and we thought that bc the same partitioner would be used, it would count as "narrow dependency" and not perform an additional shuffle for the groupby.

Though still, I'm guessing the aggbykey does map-side combining.


I was a little hasty to comment without testing this thoroughly. The rest of huggins components are in fact working. I was just expecting messages like `Queuing schedule for every_1m` one minute after starting huginn, which won't be the case. However, after waiting for some time, `Queuing schedule for every_10m` will appear. I guess that's because the lowest frequency I set some of my workers to is 10 minutes, and you changed the behaviour to adapt to that? Just a wild guess.


Unhandled Fundamental Failure


んーこれは微妙。
やるなら @re_user = @corporation.representative_user でとれるようにすればいいんじゃないの？クラスメソッドにする必要性がわからない。


Looking at Data::Dumper, it seems like Config will only be *require*d on perl versions earlier than 5.8. A simple test invocation without having Config present indeed seems to work here. Did you run into some situation where Data::Dumper *require*s it regardless?

You're right about the missing perlbase-bytes dependency though.


前排膜拜大神


:smile:


I'm juste curious, what's the build problem you get with gcc 5.2 and sunxi 3.4 ?


101682488_EvapCoolPrimaryAirSizing (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:+1: on this commit


damn ive change the name alot


They both came about from the same experimentation, but not 'related' per se.

The whole theory behind the calibrator is trying to capture the sharpest possible transitions in the data, so that you can estimate an upper bound from limited samples. But previously this was done assuming a delta function at every point along the length of the sampling arc; in reality, different arcs are going to sample different tri-linear data due to traversing different points in space, and this has the potential to increase the differential in amplitudes. By _not_ taking this effect into account, your calibration data is smoother than the sharpest possible transitions in the empirical data, which is what I'm classifying as 'not right'.

For default parameters, number of calibration directions doesn't change, ratio barely changes. Don't think the calibrator failure instances changed much, but that was dominated by the effect targeted in #354 (currently getting ~25% calibrator failures in the SIFT phantom).


102867486-FixRectangleShapeTest-5173 (mjwitte) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The gist is: fatal error: linux/compiler-gcc5.h: No such file or directory
I can get the complete error log if you wish.

A better long-term solution would be to back-port the fix for this to sunxi-linux... I'm looking into this too.


the wave effects do not work without js


Thanks :)


102867486-FixRectangleShapeTest-5173 (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks so much Oli! Nice find :)
Will bear this in mind in future.


Do I get a trophy? Bug fix of the hour!

On Tue, Sep 22, 2015 at 7:19 AM, Sunil <notifications@github.com> wrote:

> Thanks so much Oli! Nice find :)
> Will bear this in mind in future.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/srpatel/Spaceheist/commit/667afd33275783e7c0908130649e15efa9e87925#commitcomment-13359327>
> .
>


Since we're here: I'm not convinced that applying the standard 0.1 threshold on the calibrator paths is appropriate. It's possible for there to exist a path within the range of possible paths that exceeds this threshold, but none of the calibrator paths do so. This is primarily what I was tinkering with today, but I think I need to address #354 before I can properly assess this effect.


double reverses the array, once at start, and again at the end.


Fixed issue #1.


Hi Juliemr, has there been a fix for calling browser.get or navigating to a URL in safari, I cannot seem to make this work ?


I blindly copied that line from `main.py`, thanks for noticing!


Definitely.

On Tuesday, 22 September 2015, tann <notifications@github.com> wrote:

> Do I get a trophy? Bug fix of the hour!
>
> On Tue, Sep 22, 2015 at 7:19 AM, Sunil <notifications@github.com
> <javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:
>
> > Thanks so much Oli! Nice find :)
> > Will bear this in mind in future.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/srpatel/Spaceheist/commit/667afd33275783e7c0908130649e15efa9e87925#commitcomment-13359327
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/srpatel/Spaceheist/commit/667afd33275783e7c0908130649e15efa9e87925#commitcomment-13359334>
> .
>


Ow sorry, I am not looked correctly, I was only looking how that function
on Github work, sorry :-/
Am 22.09.2015 01:23 schrieb "Akronix" <notifications@github.com>:

> Note that the url generated via omdb.com/title/.. doesn't work, you have
> to use the previous imdb.com instead.
> For instance, if you query for "Matrix", you get:
> http://www.omdb.com/title/tt0106062/ which is a 404 response, but
> http://www.imdb.com/title/tt0106062/ does work.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Benjarobbi/UzzBott/commit/fa0af7b9e4a317b8eee1e8110190b2e4ad6fdb0f#commitcomment-13355728>
> .
>


Fixed issue #2.


Should probably be a GUID, otherwise might conflict.


Just making a note here: This seems to have caused php bug 70279


sudo **python** ./setup.py install

The missing "python" will drive you crazy if you don't know that you need it. :|


thanks


@jtsoi FYI. Build was failing due to the previous version not existing anymore...


Wow, early morning work!


This function takes only the data of ONE double column. The data of one double column can be for e.g. the ENABLE mask, thus describing one bit setting for each DC pixel. At most the data has as many AR / VR to describe the 5-bit TDAC settings for each DC pixel. The ARs count up, thus detecting another bit data can be done by splitting the addresses at decreasing address values (line 398). A sanity check is done to check if this function was called with the data of one DC only, thus there can not be more address jumps than 5 (TDAC data). That's the reason.

In your case I think the FE-I4 sends broken and too much data, thus the data cannot be interpreted. We could think about raising a RuntimeError instead or just aborting the interpretation for this DC and set all pixels of the DC to fail.

TL;DR: It fails because of bad FE data that cannot be interpreted. The error handling/message should be changed to be more clear.


Can you have a look at this @markmcd? I'm getting a partially instantiated PlaceDetails object as a result and I'm too rusty on this lib to make heads or tails of why.


Why not remaining the secure distribution and the 'all' package? Don't you need the data within 'all' package?


Why two channel reads?


```csharp
public class Solution
{
    public TreeNode LowestCommonAncestor(TreeNode root, TreeNode p, TreeNode q)
    {
        var queue = new Queue<TreeNode>();
        for(queue.Enqueue(root); queue.Count > 0; )
        {
            var curr = queue.Dequeue();
            if(curr == null) continue;
            if(curr.val >= Math.Min(p.val, q.val) && curr.val <= Math.Max(p.val, q.val))
                return curr;
            queue.Enqueue(curr.left);
            queue.Enqueue(curr.right);
        }
        return null;
    }
}
```


Okay, I will downgrade. Could you elaborate which kind of problems have been arisen? And it's strange a little bit, because project's clojurescript dependency must have priority over library's one, and `:scope "provided"` should give additional guarantees of it. Could you confirm (using `lein install` on specific checkout) that this commit broke stuff?


Hi sir


Just make it more general. "There is probably a hurricane around. YMMV." if (summertime)


I don't understand this change. zh_CN and zh_TW are the standard codes use for simplified and traditional Chinese. Is there a reason for changing that here?


Can't we just move the MAL importer into a gem?


Please, keep this. The BlobWriter API is designed to mirror BlobBuilder. Eventually it will be moved to System.Reflection.Metadata as public API.


And just let it run all year!? Not bad, mr. Ward!


This patch fails to build since libelf is in elfutils not elfutils/0.153. Remove the 0.153 from the path.


maybe "one or more hurricanes"? lol You guys doing alright out there in the middle of the ocean?


iOS 9 多余的文件，http://stackoverflow.com/questions/31584297/xcode-7-ignore-xcscmblueprint-in-repository


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1346 of 1346 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


97668326-WholeBuildingLoad (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-71.37%25-red.svg)


动态库的方式引入 AVOSCloud.framework 所以大小变小了，但因为动态库最低支持到 8.0(仅仅是 LeanChatExample)。


Thanks for bringing up this issue. There are two orthogonal problems: (1) this call to checkForTemporaryFiles does not actually check the scratch_space (what it is supposed to do) - it would be good to fix and rename this generic method in testutils, (2) wrt to isolated parallel test execution, I would recommend to only check for the process-local temporary directory, i.e., something like that
String suffix = File.separator+Lop.PROCESS_PREFIX+DMLScript.getUUID();
String pLocalDir = config.getTextValue(DMLConfig.SCRATCH_SPACE) + suffix;

If this does not work out, I'm fine with removing the test - however, unless there is a good reason, I'd like to have a test that checks for proper cleanup.


放行七牛的一个域名，因为 IM 产生的一些图片在七牛上。


Hm, this commit could be easily amended into the commit before. Would make things concise.


Isn't spring included by default on Rails 4.1+?


换成github 的头像：）


no no, this is for importing MAL list backups.  Not something gem-worthy.  If it were a MAL scraper I'd say differently.  I'm thinking we should use the PHP API wrapper written by that one major third-party app


Aesthetic reasons..? I tend to use assembly-style mnemonics for standalone operators to make it look more uniform.


shouldn't this be  strcoll ? see


YES! :D


Agreed in both cases.  A lot of them were poorly written under the 'assumption' (misguided, yes when there are huge input files), that speed was not critical, since it was done one time at program load.


Only in the sense that the `rails new` command generates `bin/`stubs with it and includes it in your `Gemfile`


Better names?


Dude, can you make PR?


But I doubt there are very many places where I can improve time 10000x like here, LOL, but there may be a few still hanging out.


97668326-WholeBuildingLoad (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


No


bottom* oops


```
@questions.map{|g| [g.id, g.question_choises.map{|c|[ c.content, UserAnswersCheckBox.where(question_choises_id: c.id, user_id: @users).map(&:user_id).count]}]}.to_h
```
→ console で打ってみた？冗長だしうまくいかないと思う。

メソッドに分割してみた例を以下（命名がちょい雑かも、代替案あればぜひ）
```ruby
# (controller)
@check_box_chart_info_indexed_by_question_id = @questions.check_box_question_choices_and_selected_user_count_indexed_by_question_id(users)

# (models/question)
def self.check_box_question_choices_and_selected_user_count_indexed_by_question_id(qustion_method, users)
  self.map{|q| [q.id, q.user_selected_choices_and_count_hash(question_method, users)] }.to_h
end

# (models/question)
# questionについて、各選択肢をkeyに、それを選んだuserの数をvalueにもつハッシュを生成
def user_selected_choices_and_count_hash(question_method, users)
  question_choices.map { |qc| [qc.content, qc.user_answered_choices_count(question_method, users)] }.to_h
end

# (models/question_choices)
# ある選択肢に対し引数のusersに含まれるuserのうちその選択肢を選んだuser数を返す
def user_answered_choices_count(question_method, users)
  # question_method は Symbolで渡す (:check_box)
  # send ~ 以下では、 引数に応じて user_answers_check_boxes / user_answers_select_boxes / user_answers_radio_boxes を動的に判別している
  # かなりの応用テクニック。question_method で case when で場合分けしてもOK
  (self.)send("user_answeres_#{ question_method.to_s.pluralize }").where(user_id: users.map(&:id)).count
end
```


I'm a failure, whoops


How could this call work given the following method signature from utils/titles/series.py:

def name_to_re(name, ignore_prefixes=None, parser=None)


readonly


I'll write that down to the comment


@jone This is now merged


:+1:, this looks consistent with what I most commonly see.


Basic UI for log-in page. Still requires a lot of work.


bug修复:用户浮层不居中（丢了一个百分号...）


Ok, didn't know that :)


Вечером посмотрю


Basic UI for log-in page. Still requires A LOT of work.


ここも実は場合分けせずに

```
<%= bar_chart @"#{ question.question_method.to_english_name }_chart_info"[question.id] %>
```
みたいな感じで書けば (上のメソッドはquestion_method_idについて select_box / radio_box / check_box の文字列を返すもの)、統一化できる
そこまでする必要ないが


Yes, this is to be expected


I find your wording "too many return statements" questionable in this commit message.
How do you think about to amend it?


Because connecting the Chinese script variants with specific countries is wrong, see #630 or RFC 4646.


Is it possible specify an alias do something like:

List<Car> resultList2 =
		 auditReader.createQuery().forEntitiesAtRevision( Car.class, 1, "c" ).createCriteria( "owner", "o" )
		.add( AuditEntity.or( AuditEntity.property( "c.make" ).eq( "..." ), AuditEntity.property( "o.age" ).eq( 20 ) )
		.getResultList();

Is there some other way to accomplish this without using aliases?


いや、上のは通らないわ。 class_eval とか使えばかけるが、メタプログラミングだからそこはなしでｗ


Can (and should) probably be merged into the root `.editorconfig`


Is another unchecked return value left over here?


are you sure the sum is correct? I would have imagined `sum_{i=start}^{end-1} w[samples[i]] * y[samples[i]]`


This should probably also be in the root.  I'm figuring linter and tooling configs ought to be at the root in case we have auxiliary JS or Ruby files (like maybe a root-level Gulpfile or Rakefile or something)


Does Travis have a way to run multiple `.yml` files in a build matrix?


LGTM


@Sunilkumarr create a method inside MobiComUserPreference isLoggedIn and move the check for userId inside that.


Nope! We're Apache, not MIT


Nope, I don't think so, unless they've added it since I last looked.

We also run into the problem of needing nodejs 0.12+, and their default is 0.10 with no support for multiple languages.


N+1 がこのままだとヤバいので、
```
@surbey.questions.includes(question_choices: [:user_answers_check_boxes, :user_~~, :user_~~~])
```
として eager_loading


@Sunilkumarr move "ConverstationFragment" to some constant


@Sunilkumarr code formatting!


@Sunilkumarr move "capturedImageUri" string to constant


Решил все-таки таблицы называть с заглавной буквы?


Global value `HYPER_ROOT` is set in this function, it should not delete.


Umbrüche und die eine < eingefügt
https://www.transifex.com/metamodels/metamodels/translate/#de/$/53694428?qt=SELECT%20id


"Registrations are closed" is what I went for in management. It fits with what it's usually used in big events.


I'd suggest renaming this value to something like opaque_type and then having a separate definition below for each of TLSCiphertext.opaque_type and TLSCiphertext.fragment.type. Having various similar fields with the same name causes confusion, similar to the state of the version fields prior to the changes in this document.

Alternatively, you could drop the appearance of meaning to TLS 1.3+ and replace both this first type and the record_version with just:

opaque compatibility_prefix[3] = 0x170301;

And also add a note explaining the meaning and rationale for keeping it.


Do not generate a box plot of the scores. Plot the actual scores with some transparency (alpha).


У тебя же вроде логин уникальный должен быть.


А, вижу, что сам уже поправил.


Unix Timestamps sind für mich eine Serialisierung von Zeit, wenn überhaupt. Der Vorteil an time.Time ist, dass es Zeitzonen, Schaltsekunden und alles korrekt handled. Und dass es einfach der richige Datentyp ist, um Zeit in einem go programm zu managen :)


Много лучше результаты чем вчера, вижу, что собрался и стал внимательне. Приятно удивило, что с первого раза хорошо сделал чейнджлоги для liquibase, отлично!


I removed it once issue was solved. Agree it would be useful to expose BuildAgent version.


Okay, das macht es klar :)


ok no bad


When running on iOS7 this guard's else clause will execute and it's a fatalError


What you will learn about the Butterfly Effect.

Wikipedia refers to the Butterfly Effect as a chaos theory, whereby the butterfly effect is the sensitive dependence on initial conditions in which a small change in one state of a deterministic nonlinear system can result in large differences in a later state. The name of the effect, coined by Edward Lorenz, is derived from the metaphorical example of the details of a hurricane (exact time of formation, exact path taken) being influenced by minor perturbations such as the flapping of the wings of a distant butterfly several weeks earlier. Lorenz discovered the effect when he observed that runs of his weather model with initial condition data that was rounded in a seemingly inconsequential manner would fail to reproduce the results of runs with the unrounded initial condition data. A very small change in initial conditions had created a significantly different outcome.

What I'm referring to is the Butterfly that's located within your neck.

The information is not complete, by any means, however this is a start and wanted to get comments on what your thoughts were about the site and it's staging.


Ich hab dir ja ein Beispiel gegeben, womit das funktioniert :) Und womit insbesondere auch time.Durations funktionieren. Finde das die korrekte Art und Weise, das zu konfigurieren, die Einheit einfach mit anzugeben im config-file, statt da ein int zu haben und die Einheit wissen zu müssen :) Bekommst du schon noch hin, irgendwie :)


TaskCluster, Authorization Failed ```{
    "info": "None of the scope-sets was satisfied",
    "scopesets": [
        [
            "queue:*",
            "docker-worker:*",
            "scheduler:*"
        ]
    ],
    "scopes": [
        "scheduler:create-task-graph",
        "queue:create-task:test/test",
        "queue:define-task:test/test",
        "queue:claim-task",
        "assume:worker-type:test/test",
        "assume:worker-id:test/test",
        "queue:report-task-completed",
        "queue:resolve-task",
        "queue:route:tc-treeherder-test.*",
        "queue:route:tc-treeherder-test*",
        "queue:rerun-task",
        "assume:scheduler-id:*",
        "queue:route:test*",
        "queue:resolve-task",
        "scheduler:*"
    ]
}```


@dopcn thanks, yea hmm it's becoming evermore difficult to support iOS 7.0


ok


Ok, that's more or less what I'd gathered. Sounds like a good idea to me, go for it.

Also agree that we don't need to apply the cutoff threshold when calibrating. Feel free to go ahead and remove it.


i can remove it here, but need it in the other test, as the mailbox will only be cleared after each test.


Really? https://en.wikipedia.org/wiki/Return_statement


Not exactly, just like you had mentioned before, each field has its own unique id. However, it could be useful for example in case of searching for all fields within a section like `$( "input[name^='field_1']" )`.


yes, I have tried to use ```registry.access.redhat.com/rhel7.2``` and it failed as ```registry.access.redhat.com/rhel7.2/rpmostree-toolbox-lmc``` is not a valid name.

What example do you have in mind?  I have tried the following cases:

foo -> foo/rpmostree-toolbox-lorax
foo.org -> foo.org/rpmostree-toolbox-lorax
foo.org/bar -> foo.org/bar/rpmostree-toolbox-lorax
foo.org/bar.com/baz -> foo.org/barcom/baz/rpmostree-toolbox-lorax
foo.org/bar.com/baz-6.4 -> foo.org/barcom/baz-64/rpmostree-toolbox-lorax
7.1 -> 7.1/rpmostree-toolbox-lorax


It would be great have a method without filters, just packageName.


Also fixes #9


Meine Meinung dazu ist: Nimm die WaitGroup komplett aus dem Code, wenn du das noch nicht hast. WaitGroups sind dazu da, auf eine Gruppe von Goroutinen zu warten. Wenn du nicht wartest, hat es auch nichts im Code zu suchen. *Wenn* du wartest, wirst du diesen Code an der Stelle eh nochmal anfassen müssen (um die Endlosschleife umzufaktorisieren in eine select-schleife und so) und die Gefahr, dann zu vergessen, auf die neu hinzugefügte WaitGroup zu wartene, seh ich nicht.

Wenn du unbedingt einen reminder brauchst, würde ich hier ein `// TODO: Signal exit once clean shutdown is implemented` o.Ä. hinmachen. Auskommentierter Code gehört jedenfalls nicht submitted. :)


oh right, that's inside a helper. well then, please remove it here.


Sidenote: Es ist völlig normal, dass eine go Funktion einfach dokumentiert "nie returned". Siehe z.B. `http://godoc.org/net/http#ListenAndServe`. Vielleicht ist das eine Ermutigung, einfach aufs Warten zu verzichten und einfach (for now) zu dokumentieren, dass das ewig blockt.


It has been introduced in another commit 2534808604b15a33fa4342b3832f26cd9e22c8ba


Cool, this is a valid solution. Just that I'm not sure if BFS would be the best solution, since BST is kinda designed for DFS (that's what I think, correct me if I'm wrong:D)


Do you remember exact reason why you had to call observeChanges in a non-reactive context?


when using `refresh_from_db` this error occurs: `AttributeError: Direct state modification is not allowed`. seems like this method just tries to update all individual fields which doesn't work with the state. what do you say?


Зачем `LIKE`, если мы знаем точные значения? К тому же `LIKE` может при откате удалить и другие похожие значения.


done


Well you probably want some kind of threshold; if it's an appropriate point at which to terminate, you'd prefer to terminate based on the calibrator rather than draw 1000 further samples before giving up. I was going to just apply the calibration ratio prior to applying the threshold, but that ratio applies to the probabilities, not the FOD amplitudes. And there's no unique path probability that corresponds to the FOD amplitude threshold. So not quite sure what to do about this just yet.


Use `fail` instead of `raise` to signal exceptions.


cool, I think it's a good alternative solution, and it's only one line, so yeah I like it!


Probably better to keep it there, as the finally is there anyway. Done in 8c5fcdbedd249b00181377d7e075121a260204b8.


just a quick comment: you can use `DS` instead of `DIRECTORY_SEPARATOR` in Q. It's one of the predefined constants found [here](https://github.com/AndreyTepaykin/Platform/blob/master/platform/Q.php)


@maikelvdh, good point, I didn't write this myself, it has been generated by `./gradlew wrapper` when I changed the version to `2.1` in `build.gradle`. I'll check if I can change to `https` and `all`, and most importantly if I can get the `wrapper` task to generate that properly in the first place.


Ну как - сделал... Содрал безжалостно :-)
--
Отправлено из Mail.Ru для Android вторник, 22 сентября 2015г., 09:55 +0300 от Slava Semushin < notifications@github.com> :

>Много лучше результаты чем вчера, вижу, что собрался и стал внимательне. Приятно удивило, что с первого раза хорошо сделал чейнджлоги для liquibase, отлично!
>—
>Reply to this email directly or  view it on GitHub .


Just one more quick comment ... please try to name your commits like this "Fixed xyz" or "Did xyz" instead of "Fixes xyz" or "Does xyz"... just to be consistent with my style of commit messages.


Yes. Once the SRP is merged, I'm going to refactor this a bit. After 10+ years the code around evolved quite a bit.


No, setting a system property potentially change the behavior of all other tests.
In this case, you are supposed to inject a class that provide the directory location


yeah that's true, i even documented this :) https://github.com/kmmbvnr/django-fsm/pull/91

then i'd like to ask you to replace this by Course.objects.get(id=course.id), otherwise one might think it's a different course at first sight


97668326-WholeBuildingLoad (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (794 of 794 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-19.84%25-green.svg)


Intial commit for testing the GitHUB


now i dont no it is free or not :(.


not sure it works in all case, how do you know what is the working directory ?


>> I was surprised by the change of #failure_message and #failure_message_when_negated from methods to attributes.

A matcher object has it's error messages as attributes - feels right, at least to me ;)
That was the only reasoning.


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-42.57%25-red.svg)


What was the initalization bug, I get this error from this change:
TypeError: Cannot use 'in' operator to search for '/here/is/the/path' in null


:+1: Should be in `cider-common` or something like this, as I mentioned in the PR.


In theses instances (directly assigning the result of checkNotNull), it'd IMO be better to just drop the text altogether:
```java
register = Preconditions.checkNotNull(result);
```


update database connection string.


In the previous commit you opted to move similar functionality to `cider-util`, so I find this move a bit confusing.


See comment on line #118


Maybe I'll fix all `catch (IOException)` to provide `InnerException`.


It was the WR develop branch which broke.  Rechecking...

1.7.28 dev cljsbuilds and app loads fine
1.7.48 dev cljsbuild fails with "java.lang.IllegalArgumentException:
character to be escaped is missing"
1.7.58 dev cljsbuilds and app loads fine.
1.7.122 dev cljsbuilds and app loads fine.

My report was confused with what seem to be an unrelated, but very odd,
error which I couldn't see a cause for.  Check out c86fc8a on the bitbucket.

On 22 September 2015 at 16:29, Ruslan Prokopchuk <notifications@github.com>
wrote:

> Okay, I will downgrade. Could you elaborate which kind of problems have
> been arisen? And it's strange a little bit, because project's clojurescript
> dependency must have priority over library's one, and :scope "provided"
> should give additional guarantees of it. Could you confirm (using lein
> install on specific checkout) that this commit broke stuff?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/condense/ampere/commit/e7d96f159e2c1276026f073834b3a3f795743150#commitcomment-13359423>
> .
>


Just wondering can this cause a NPE?


Where's the shadowed var exactly?


Ночью всяко лучше писать, когда никто не дергает :-)


1: M111 unrecognized component name: dojson


If you want to make it backwards compatible you can choose to mimic the old constructor and pass the default null value for extraInfo


А может, прически "полысее" захотелось...:-)


Yes I realized that last night too and hoped I'd get it fixed before you'd notice. You're too quick :p


@cblichmann I will change it in my commits


Yes. I recall a bit what was the idea years ago. But the code went slightly different way. Now it looks less encapsulated, but as you said, it's less complex now. I have another shuffling in my head, after the SRP.


Good point but aren't you personally against default values? At least in python you don't like them if I remember correctly.


Not quite sure about this. As it's nREPL specific it should go to some nREPL-specific place (e.g. `cider-nrepl-client` or whatever). We don't have it right now, so this move might be OK in the short term.


<documentation> Extra comments zijn niet nodig hier?


If fold_ident is restored as a part of Folder, then it would make sense to restore visit_ident in Visitor as well.


Is this a value object or a service?


good catch!


Why did you replace the `enum` with these constants?


Now that we don't have anything called `cider-jump-` anymore, we should probably rename this alias.


Hello Romain,

I see the following problems with your patch which need to be solved:

- When using cmake-gui you get a drop-down field to select the driver. Therefore you can only select one driver. If we support multiple drivers we need to change the CMake file to be able to select multiple drivers also in the gui. I think the only solution would be to change it to separate on/off options for each driver instead of a sing CFG_POWERLINK_EDRV.

- You can clean a single driver module (e.g. make module_82573mn_clean) but I'm missing the old module_clean which should now clean all drivers.

- If we change the build system in this way we need to adapt the documentation.

Best regards,

Josef


Oh actually the NPE I had in mind is another one. I'll check this one too, thanks.


unexpected token tCOMMA<br>unexpected token tRPAREN


Could be just `m_id` since the class name already indicates what type of "thing" this is.


OK I understand. But this is just a check for TDAC, which is 5bit. Other Pixel DACs, which have less than 5bits, are not fully covered by this check?


Fix: https://github.com/netguru/access/commit/d08f0e24dcc48e2f8f923e8c7574fc4903e6f726


That would also be more in line with my refactoring branch where there's a base class which contains the `m_id` parameter. No need to change this at this point though unless you feel like it.


is this also published on the artifact, not sure if you want to inherit the set of the pulblication? I think the tokens can be an entirely different set as the publication itself


Waarom wil je deze veranderingen mergen? Er zou dan uitgecommente coden worden toegevoegd. Of je haalt de code weg of je houd hem er in.


@pilif thanks for the noticing, should be fixed now


RouteIdx in routing ?


Running: roo> help
doesn't actually tell you much about gvNIX being installed.  You really have to search for any reference, and then it is very minor.  The instructions in the 2.0 ref docs (section 3) has a better suggestion of running:
roo> addon list
This gives you a much better indication that gvNIX is properly installed - not to mention makes you feel like you are getting a LOT more from gvNIX.


There's no need for that. Its too costly.
if (alps_process_bitmap(priv, f) == 0)
fingers = 0; /* Use st data */

Use this instead:
if (fingers == 1) { //touchpad reports 1 instead of 0 after *multiple* fingers have been lifted
fingers = 0; //set fingers to zero since there's no touch
f->x = f->y = f->z = 0; //flush coordinates to prevent initial pointer jump after switch to single touch mode.
}

tested and working reliably on my V3 pinnacle. (On Mac OS X)


As SpIdx


just a side note: this was not a auth header only bug, but also related to other headers. see example scripts in https://bugs.php.net/bug.php?id=70279


http://www.divine-pride.net/database/item?Name=cria&function=&find=Search
Not sure if this is 100% acurate though


kgk


Your wording is better. Thanks.


I thought it was a nice idea as it comes for free and there are no extra info on [IvyArtifact](https://docs.gradle.org/2.7/javadoc/org/gradle/api/publish/ivy/IvyArtifact.html). Since it's all about user-defined tokens, I think this is unlikely to lead to an unintended behavior.


menue


I don't think these need to be defined here


same here


bad indent here


ACK


please don't add extra dependencies at the `parent` unless strictly needed


Maksudnya apa ya ini ?


lol so ships might sunk if set to two?


I find the name 'visitor' used alone as here confusing


And actually I'm pretty sure we will need this ourselves, as we will want to publish both `ivy.xml` and our artifacts to `[organization]/[module]/[platform]/[revision]...`. Although for the artifact we could also use `classifier` instead of a user-defined token.


Можно было б и зацепить


why remove 'measures' here when it's left in other places (eg. "Compute duplication measures")


존나 노답이다www


Названия комита не понял
Поясни


What do you suggest ?


如果你看了 gitbook 的使用方法，就知道SUMMARY.md 是用于写目录的。


bad indent


Connard


Логотип у нас должен быть ссылкой на главную. + в теле ссылки мы можем написать Sedona)


Because others are about functional measures. Here using measures is a technical structure for a complex data that should be stored elsewhere.


A me sembra leggibilissimo invece! :P

2015-09-20 0:16 GMT+02:00 Seiseisei666 <notifications@github.com>:

> Ti prego rinomina quell'enum che "doveDisegnoWidget" nunsepo' legge!! :P
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Seiseisei666/Quantum/commit/8adeb1f0aade97c757af19acf02a6a5f923bd802#commitcomment-13326952>
> .
>


Потеряли пробелы перед `href`


Как вариант, так тоже можно, не пробовал.


Yes, I noticed that link was broken.


Красота


Исправляй косяки отступов, здесь табуляция стоит вместо пробелов


Есть правило в css, лучше его использовать, чем в лоб соблюдать регистр


test commit


This should be reverted! Causing issues: https://github.com/poole/lanyon/issues/140

Explanation: http://downtothewire.io/2015/08/15/configuring-jekyll-for-user-and-project-github-pages/


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 681](https://teamcity.labkey.org/viewLog.html?buildId=273428&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:27:18
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 23 more failed tests, see build details
```


I'm not fundamentally against defaults, but I'm against 'arbitrary' defaults :-)
In this case it doesn't cause any unexpected behaviour and it does provide backwards compatibility of this class interface, allowing you to change less code in this PR


Need to update this per changes in #13348


yes thanks.  That works for me, I have pushed a fixup patch to the series.


To be removed ?


2 comments about this file:

1/ It looks like a raw copy of: https://github.com/mrdoob/three.js/blob/master/examples/js/controls/OrbitControls.js
It is not possible to distribute this file as GPLv3 (slurm-web licence) since this file has no clear licence and Three.js is distributed under the MIT licence.

2/ Is it really related to walls? If not, this code must be added in a separate commit.


why ?


Почему строчные элементы?


Good work on testing the scope. Chat soon.


How about `attributes[name].present? ? name : nil` or `attributes[name].blank? ? nil : name` if you fear the empty string?


ok


У всех заголовков нужны одинаковые классы разве??


I'm not against extra info on the artifact itself, I'm just questioning if we would want to have exactly the same set of extra info on the publication as on the artifact.


Just putting comments here so they don't get lost:

* We should keep using dispatch to trigger events up the parent hierarchy. See flux and https://facebook.github.io/react/tips/communicate-between-components.html If you want to switch to someone's implementation of flux I'd be glad to check it out
* Let's not convert everything to `camelCase`. It's highly likely a lot of these react components will be brought back to the main site, and I'm don't want to switch coding styles :)

Also not sure what you meant by:

   Also pretty sure passing '@state' to a child component as its props is an antipattern

Are you referring to the places where `extend` is used to copy the state into the props of the children? I don't see any issues with that


MIT is a good license :) «free of charge»


I agree, I'll do that.


The wording in the comment has to be changed.. to "host"


```
 return array_key_exists($name, $this->parameters);
```

Ver https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/HttpFoundation/ParameterBag.php#L174


shouldn't that throw an exception?


Tack kamrat :+1: :feelsgood:


This still overflows the width for me. Does it work for you?

E.g. when 'stty size' says '54 211', the header separator looks like:
```
-------------------------------------------------------------+------------------------------------------------+-----------------------------------------------------------------------------------------------------
```

It's 212 characters long.


It is fine to delete .swp


could you take a look at https://codecov.io/github/python-babel/babel/babel/numbers/_spelling/locale_hu.py?ref=8fdc750feaa82dda88e839fcc0007134e4cc1d2f and add a few more asserts to cover the missing lines?


you have an exception for that, right? Simply returning a string that is of no use to the user is wrong here IMO, don't you think?


In fact, it is not linked. To see if it is linked you can use the LinkPlugins. You can also link using it, just make sure to select first SelectRegion and second Display, then it works.

I have also thought in that, but it is trick. We definitely don't want to merge the two plugins, so how to communicate. It must be a shared variable (that will also need linking), may be Vpoints or Vmask. Anyway, it is trick, so unless some one has a good point on how that would be important, I would let GateFilterPlugin out side of it.


Usually this would be written
```
(flexmock(osbs.cli.render)
    .should_receive(...)
    .and_return(...)
    .once())
```
i.e. enclosing the whole thing in parentheses and not using continuation backslashes.


Could this be a bitmask? I think it'd be more useful that way, since with the other way a lot of things will have to check for `state == Tidy || state == Flat`, since the enum itself doesn't make it clear that Flat _is_ Tidy.

```
enum State
{
     Sorted = 1,
     NonOverlapping = 2, // Note no underscore!
     SingleSample = 4,
     Tidy = Sorted | NonOverlapping
     Flat = Tidy | SingleSample,
};
```

Does that make sense?


почему строчный?


@sils1297 I lament in the code about this. Finally I decided not to throw exceptions in cases like this as spelling out numbers is usually not extremely important, so a somewhat funny textual message is better than an exception. I wanted to add Warning in cases like this and maybe a switch to control the behaviour.


If the `TablePrinter` could be told where to send its output we could test it doesn't overflow. ;-)


Shouldn't this go to the config?


we keeps data about updates in cache. Method of getting this data used by different places. To prevent often mp-server requests we ask him one-per-day. But in case with updater admin page i think we need to ask it once page opened. That's why cache clearing placed here.


`lang="ru"`


testing


This needs to be done on prepare, because the hook might fail again and we don't get to update the version, resulting in continuous retries.


I'm wondering what the use case for the additional constructor argument is? If we don't have a compelling one, my preference is to leave it out (and always construct flat).


I'm pretty sure this would only call one wrapped operation, while the old one called an arbitrary number of them. Not really the scope of this commit, but worth a notice


These files are never static. They get updated time to time. Mostly with a new **systemd** release **systemd-bootx64.efi** changes. Same goes for the **efi-shells**. But there it is not so frequent: [Shell_Full.efi](https://github.com/tianocore/edk2/commits/master/EdkShellBinPkg/FullShell/X64/Shell_Full.efi), [Shell.efi](https://github.com/tianocore/edk2/commits/master/EdkShellBinPkg/MinimumShell/X64/Shell.efi).

However, I think the **gummiboot** file might work for a while, longer as we think. Keep it as you like it, as long as it don't break.


TypeError:  Cannot read property 'upload' of undefined


Этот код можно уже удалить, я так понимаю он был временным и теперь перехал в main()


where we block this?


I think we can just say `new IECore::FloatVectorData()` here, rather than explicitly say that we want to construct a new vector, fill it with exactly no zeroes and then copy it.


If op.Operation is an onCommitWrapper, the Commit call above will call its onCommit callback. Previously it would run each embedded one twice because of that.


There's nothing that seems obviously wrong here and I do like moving the logic inside the resolver. I'll give it a spin


You wouldn't want to have the same extra info on publication and artifacts, as then the info would be duplicated across the `ivy.xml`'s content.
However, I think usually the "directory" where to find an artifact is a subdirectory of the one where to find the `ivy.xml`. Which means that in this case, the artifact pattern's set of tokens is a *superset* of the publication pattern's set of tokens. (So not *the same set*, to answer your question precisely.)

Thus I do think this makes sense to inherit the publication tokens for the artifact resolution too as, as said, the artifact path is likely to contain the publication path. I do nothing more here, especially I don't put the extra info on the artifact (i.e. I don't write anything to the `ivy.xml`).


А теперь представь, что ты не видишь кода, запускаешь программу, а она говорит тебе "NO". Не очень-то информативно. Может хотя бы "No solutions"?


> Errors should never pass silently.

I don't see any advantage of not throwing an exception here. We don't want this message to reach the user anyways because it's useless to him.


Can you remove the extra spaces?


Числа типа double лучше инициализировать не x = 0, а x = 0.0
Так сразу видно, что это не целые числа. Да и в сравнениях тоже


@ata update the readme bro, the overidden keybindings masih ada. Ganti aja dengan yang default so orang baru bisa tahu keybinding yang penting.


Thanks, good catch. I'll update.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21017/testReport/) for this commit**


(apart from that this line is untested)


What if state is null?


Выражение b * b - 4 * a * c используется 3 раза (в строках 34,36,37). Можно вынести его в отдельную переменную и один раз вычислить, а потом использовать.


After merging testing to master, the log shows the latest commit is "Change the date of New Year’s Day to 01/02", not " Change the date of New Year’s Day to 02/02"


Yeah, but I might wrap it twice right?

a = {originalOp, func1}
b = {a, func2}

Then b would only call func2 here


From "ant tests-all":
    [junit] Testcase: test[examples/PeerToPeer.abs, null] took 0.152 sec
    [junit]     FAILED
    [junit] DivisionByZeroException
    [junit] junit.framework.AssertionFailedError: DivisionByZeroException
    [junit]     at abs.frontend.typechecker.TypeCheckerHelper.getDefinedNames(TypeCheckerHelper.java:336)


why this dependency here?


Ну про вывод я уже писал. В этом месте тоже вместо вываливания на пользователя двух чисел можно же написать например
printf("Equation has 2 squares: %lg and %lg.\n", x2, x1);
И да, об этом самом "\n". Это перевод на новую строку чтоб вывод не сливался друг с другом и с тем, что будет после него.


Nvm, got it


I think it would be better if moveq size set to 0
as moveq is only from 8bits value or register, dest is always 32bits
moveq.b make no sense either


Вот вынесенный отдельно ввод это хорошо.


Yes, I am amending the test coverage.


Since this isn't static, it is going to run every single time flatTileSampleOffsets() is called, even though we should be doing nothing after the first call. It'd also be nice to use boost::counting_iterator to more concisely initialise too.


tgfjkfvfj


А отсюда лучше все-таки вытащить вывод либо в main() либо в отдельную функцию.


connard


conard 2


use what UE send in uplink channel as data source of D2D channel


ceci est un mail


Просто совет:
#include <stdio.h>
читается лучше, чем
#include<stdio.h>


Fixing window height/width if maximize


hardcode freq


Makes sense, but:
To whom is this question related?


The trailing whitespace removed here is significant, it inserts a line break.


对于测试用例的编号规定，请看：https://github.com/heweneayun/EayunOS-testcase/wiki/%E6%B5%8B%E8%AF%95%E7%94%A8%E4%BE%8B%E7%BC%96%E5%8F%B7%E7%BA%A6%E5%AE%9A


Please revert this change. It needs to been kept in our **livecd-overlay** folder, or what do you try to achieve here?


You're right, `#present?`, "#empty?" and `#presence` are provided by Rails, so not applicable here.


Agree, the question is is this really an error. In this specific case I inclined to agree with you, but there are other cases. What if the number is too big to spell (e.g. the language itself is unable to address the spelling) is that an error or we should state the fact textually?


hardcode freq: 18100


И сам не знаю зачем так написал. По невнимательности. Я думаю что загруку данных нужно из csv сделать. Одобряете?


Просто совет: если после include поставить пробел, то читаться будет лучше


还是用回中文吧


hardcode d2d rb


Je te merde
Le 22 sept. 2015 10:07, "Maitre-Hiboux" <notifications@github.com> a écrit :

> ceci est un mail
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cbourree/CFM---Mindstorms/commit/ad6965dc61960c0c06f57c4b74c9e57d1b3bf263#commitcomment-13360783>
> .
>


Странно, зачем функция объявлена как double solutions(...), если она по факту ничего не возвращает?


This needs to be scoped inside ImagePlug.


I wonder if we should make this a hard exception, with potentially an option to disable it for places we haven't fixed yet/needs it. In the last year we have been slowly making things more strict and not ignore unknown fields.


Hey, in case I didn't say that yet, this stuff is really cool and well appreciated!


Same code as we use with the map cards. We could put it both a partial if you prefer it.


Check the last commit in manjaro-tools devel, i've put it there. Unless you build the iso with a previous manjaro-tools, we don't need to revert this.


作为代码规范，自己的缩进都没写好，这可不行哦！


It'd be nice to also bind emptyTile() etc, including the missing blackTile()/whiteTile() bindings.


Файл без расширения?


这里要省略大括号，而且里面的代码要缩进啊


change:
`log.Errorf(c, "Teams, cannot find team with ID=%", tID)`
to:
`log.Errorf(c, "Teams, cannot find team with ID=%v", tID)`


i'm with dmukhin01 i have no idead what all those mean...
can we get a short video of this?


was there to force re-computation of the duration (```gf_isom_update_duration()``` should have been called instead)


А почему инициализируется имеено d? Чем она лучше или хуже других переменных?


Styly 是什么意思……


Let's move this to just above the sampleRange() function, so people don't have to hunt for it.


> What if the number is too big to spell (e.g. the language itself is unable to address the spelling) is that an error or we should state the fact textually?

Same, we gain nothing by stating the fact textually. Essentially what we're doing is:

1. Programmer says to you "spell this number to my user!"
2. You tell the user "I can't spell this"
3. User is confused because this doesn't fit into the generated sentence, i.e. there is no proper error handling.

If a function cannot do its task for some reason that should definitely throw an exception.


全角符号左右不要有空格


I think I initially missed the difference between gf_isom_close and gf_isom_delete, and that we can revert 8114b98c43a41fec7916fd31450d7a8c0cc4ff6f , what do you think?


@yfwz100  it can't be that case. state is generated by React itself.


缩进有问题


删除括号中不必要的英文


I believe both DFS and BFS work for this question. IMHO,they should have same time complexity in terms of worst case(i.e. the big O notation). However, in terms of average case( the big theta notation) BFS beat DFS in this case.

FYI, both DFS and BFS are designed to solve graph problems. Tree including BST is just a subset of graph.


Это можно было поставить пораньше, еще до вычисления d.


CoffeeScript 的注释符是 `#`


For information, locustio 0.7.3 works also with gevent-1.0.2 (tested on WIndows 7, gevent-1.0.2-cp27-none-win32.whl downloaded from [Christoph Gohlke's webpage](http://www.lfd.uci.edu/~gohlke/pythonlibs/)).


五个缩进是什么情况？


Можно и из CSV, я не против, потренируйся.


А разве для уравнения вида bx+c=0 вообще стоит вычислять d? Может это исловие надо вынести из под if-а в 26 строке?


I don't think spelling fractional numbers as ordinals makes sense so an exception is the right way to treat this.


此条可删除，不符合我们团队的风格，两种风格都不反对


OK, convinced, do the modification and the test coverage right away!

Thanks for the appreciation, it is always welcome, but I doing it "for the
greater good" and happy to have others to help me with that!

On 22 September 2015 at 10:12, Lasse Schuirmann <notifications@github.com>
wrote:

> What if the number is too big to spell (e.g. the language itself is unable
> to address the spelling) is that an error or we should state the fact
> textually?
>
> Same, we gain nothing by stating the fact textually. Essentially what
> we're doing is:
>
>    1. Programmer says to you "spell this number to my user!"
>    2. You tell the user "I can't spell this"
>    3. User is confused because this doesn't fit into the generated
>    sentence, i.e. there is no proper error handling.
>
> If a function cannot do its task for some reason that should definitely
> throw an exception.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/blagasz/babel/commit/ac0a41200eb91b648276955b8c2ece6c645f7a93#commitcomment-13360872>
> .
>


You can directly checkout this commit (just add my repo as a remote and fetch from it)
You need the full commit, not only the CMakelists. and in backport there should to boost folders (of style *1.x-1.y) no boost-1.58 or boost-1.56.
So just checkout this commit and all should be fine.


Лучше писать классы всегда первыми, что бы не путаться потом. + значения атрибутов для однообразия маленькими можем сразу делать) + action по спецификации не должен быть пустой


You haven't handled the exception correctly. If an exception is caught here then you will get an exception on line 69:

```java
new Location[rows.size()][rows.get(0).length()];
```
to handle this exception you should use:

```java
throw new RuntimeException("Error parsing map", e);
```


> 除非是插入到另一段现有的字符串中（类似于字符串插值）。

括号外的是废话，要改为 `除非是字符串插值`


I'll make a full footer view later on which contains the copyright too so I can cut down on the hard coded markup in the main page view


Is this actually respecting the blur radius for you? I can get it to respect it once if I restart systemui but once I lock the screen it's back to the default value regardless of what I have set


删除后面无用的英文


This change is breaking a test where I check multiple classnames, e.g. `scryRenderedDOMComponentsWithClass(root, "classA classB")`. imho we should split className into an array and loop over into its elements.


> Targets where the native virus checker finds pcap and pcapng files with those link-layer header
> types and removes them immediately? :-)

Ah yes, offline sniffing. I wasn't thinking about that case.


`请参考这里：` 应该在链接外面，应改为：

```
请参考这里：[关于注释那点事](https://github.com/Jisuanke/tech-exp/issues/4)
```


А тут точно нужно условие d == 0? Может этот случай рассмотреть еще до вычисления d?


We may want to have this more explicit, since `opt_extrapolate` is a `boolean`. The above works, but only because the default is `false`. An alternative would be sth. like:

```javascript
var extrapolate = opt_extrapolate !== undefined ? opt_extrapolate : false;
```


Do you think an overload taking V2i (coordinate within the tile) could be useful? And is there an argument for pixelId being an iterator within sampleOffsets instead? I think I'd suggest keeping this function out of the initial pull request, and adding it when we later add an algorithm that needs it - at that point we'll have a better idea of the best form for it.


@SteamShon review change plz


Parsing a map is a separate responsibility. You should create a MapParser class for this.


You should inject the file name so you can test the class.


@mosra you will have to remove this workaround now it seems Appveyor has updated their image somehow


@Rich-Harris can you publish a new version please?


Кажется пропущен случай a*x*x+c=0 (a != 0    b = 0    c != 0)


Also one more design question arise:

What if the number could be spelled but needs rounding for that? Should it
be a specific error or a warning?

For my use I would really appreciate from a multi-language library to give
me readable messages for all cases that fits somewhat into context (if
loosely still), because that would help me to develop applications in
languages I don't really speak. Sometimes the context makes it hard to do
that, but we should at least try as a modul option. So I make error message
and also catching them if the option is active in the modul.

E.g.:

123,2 -> 'hundred twenty-three point two'
123,199987564723 -> 'approximately/rounded to hundred twenty-three point
two'

What do you think?

On 22 September 2015 at 10:15, Szabolcs Blága <szabolcs.blaga@gmail.com>
wrote:

> OK, convinced, do the modification and the test coverage right away!
>
> Thanks for the appreciation, it is always welcome, but I doing it "for the
> greater good" and happy to have others to help me with that!
>
> On 22 September 2015 at 10:12, Lasse Schuirmann <notifications@github.com>
> wrote:
>
>> What if the number is too big to spell (e.g. the language itself is
>> unable to address the spelling) is that an error or we should state the
>> fact textually?
>>
>> Same, we gain nothing by stating the fact textually. Essentially what
>> we're doing is:
>>
>>    1. Programmer says to you "spell this number to my user!"
>>    2. You tell the user "I can't spell this"
>>    3. User is confused because this doesn't fit into the generated
>>    sentence, i.e. there is no proper error handling.
>>
>> If a function cannot do its task for some reason that should definitely
>> throw an exception.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/blagasz/babel/commit/ac0a41200eb91b648276955b8c2ece6c645f7a93#commitcomment-13360872>
>> .
>>
>
>


Thanks @taylordowns2000, good spot. I'll add the functionality this week.


@mattmb see my commit comment about why I changed this.


Maybe just `channelData.begin() + sampleOffsets[pixelId]`? From my understanding, `boost::next()` is useful for types (non-random-access iterators) where that operation isn't available, so by using it here we're implying a limitation that doesn't exist for our type, and making the code harder to follow.


I'm confused, is 1.7.48 stable or problematic?


This is constant a different case than in `VirtualRouter.java` (where it is all capitals).


Okay, i think i could try with WR by myself.


Boolean fields should not start with "is", otherwise your getter will be called "isIsOpen".


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 682](https://teamcity.labkey.org/viewLog.html?buildId=273444&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 33, passed: 9 Build time: 00:25:04
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridColumnSelector: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

##### there are 23 more failed tests, see build details
```


`router` is spelled incorrectly here, but this doesn't appear to get used anyway?


@uucidl thanks for the notice, seems to be fixed in the September 20 update: http://www.appveyor.com/updates/2015/09/20


Ok, even better. However if you now use **0.9.12** it might not work. But hey, only we developers know what is really going on here ;)


empd (nmerket) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


wtf...


97668326-WholeBuildingLoad (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1329 of 1329 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.2%25-green.svg)


Change "description" and "detailedDescription" to "title" and "description".


Have you seen the `ol.isDef` function that @tschaub added?


I think the performance will get better if move this line out of loop.


Tämä kelpaa päivitykseksi!


I can not get this to download on my computer, because of the security issues, and I can not download it to my Android either, Could you please let me know how to fix this?


@sils1297 here's an idea:

I do it both, error messages as default, but also returning (sometimes maybe empty) strings if the modul option ``suppress_errors`` is set to True. This would make it professional and also in some cases more usable for non-speakers.

What do you think?


So state is always a list?


:ok: :1234:


I thought about it. accepted syntax by most amiga compilers are moveq.l and moveq so I wasn't sure which one to pick here but we can go for zero also.


What about calling this "slotsNeeded"?


What's the purpose of this method?


Maybe we could try similar to `(14 - p + ( K-p) * pos.opposite_bishops())` to say that opposite bishops are all the more drawish when there are fewer pawns left ? (with a value of K to be chosen carefully, taking K=12 would actually say that opposite bishop with a lot of pawns actually helps the attacking side, which may be true in some cases: https://en.wikipedia.org/wiki/Opposite-colored_bishops_endgame ).


> approximately/rounded to

Actually now that you say "approximately", this word is way better than "rounded to" don't you think? E.g. if I'm using

```
print(_("I have {spelled_number} things to do.").format(spelled_number=spell(1.0002)))
# Expected output: "I have approximately one thing to do."
```

That's way better than "I have rounded to one thing to do."

> What if the number could be spelled but needs rounding for that? Should it be a specific error or a warning?

From the perspective of the user of this speller (i.e. the programmer who wants to express something with spelled out numbers),

1. I would love to be able to tell the function what precision I want to have spelled.
2. I would expect it to throw an exception if it cannot meet my demands.

So we would ideally be able to do `numbers.spell_number(some_number, precision=...)` and if the number needs rounding for the given precision that's ok. If it doesn't it's ok too.


Working in both Eclipse & Maven.


it doesn't seem like an optimisation as you unnecessarily create an array, instead of simply manipulating strings


Ah - that was updated/fixed in the following commit!  I switched the code to be compatible with slightly older versions of ruby...


Use consistent naming. How about "slotsUsed"?


"totalSlots"?


Yeah, will use it now when we test for an actual boolean. See my comment on the main PR


Ok


This comment block does not match the config.


Let me test this change. I think we are almost ready for **0.9.13** by now ...


Is it a typo????

```php
new Response(new RedirectResponse($seriesUrl, 302), 401, array('WWW-Authenticate' => 'Basic realm="Resource not public."'));
```


I probably had used the wrong term "DFS", I was trying to refer to my solution, turns out the solution I provided was not DFS, but a binary search. And obviously, for most terms, it provides much better time efficiency than BFS solution, the higher level the solution at, the less efficient the BFS is.
For example:
```
                    30
            /                 \
         15                 45
        /     \             /      \
     7       23        37     53
    /   \     /   \      /   \     /   \
  3   11 19 27  34 41 49 57
```
if you are looking for the ancestor of 49 and 57, binary search solution took 2 turns, and BFS took 6 turns.
I would say, the worst case time complexity for binary search solution is O(logN), and BFS is O(N)


Rename to "items" and don't use `ArrayList` because it's an implementation detail:
```java
List<Item> getItems();
```

BTW, you normally don't add an access modifier to interface methods (they can only be public).


I've already tested this in kde-minimal.
If you test too, please test also that "journalctl" produces some output.


**Code Quality - Nitpick**

The callback can be invoked directly, what purpose does the `setTimeout(...)` serve when it's executed after 0 milliseconds.


ccc


Why would you want to suppress errors? You want to handle them. Let's summarize the error cases:

- You're unable to spell the number. Programmer should know this, user shouldn't be bothered. -> Exception.

That's the only exception to worry about. It's totally usable by anyone who knows what an exception is.


网易彩票简单实现


See #1419


**Code Quality - Nitpick**

The variable `word` doesn't need to be redefined, it could be re-assigned easily like so:

```
word = word.toLowerCase();
```


`paren` should not be here


Decoding terrain symbols is a separate responsibility. Move it to the map parser.


Where is the Terrain class?


这里keyScan_Task的优先级应该低于Key_HanderFun的优先级。为什么？？就是让一旦检测到按键被按下，则立即执行按键处理任务，这可以提高按键中断响应的实时性。


<br>'ки удаляем!)


awesome!


Move to own compiliation unit.


Ayos! hehe


shouldn't the test message be updated accordingly?(to use 'OUTERS')


maglalagay ako ng mga tanong


@xcompass Note that the line above should give you OAuth support for this API automatically, though it will only ensure that a user account is valid. As we discussed on the design doc, you will need to add some other mechanism to tell which user accounts are allowed to access which provider IDs (i.e. a new permissions model linking IDs to providers).


I suppose, when dumb crap like this happens, it would be better to revert the entire thing, and then commit a proper version. I mean, with the way this instance has been handled (cherry-picking the commit this one reverted), the only diff of my changes available is this mess.


Yes, looks like Config isn't necessary for Data::Dumper. I've updated this pull request.

(However, I found that perlbase-essential requires Config:
```
root@OpenWrt:~# perl -e "use lib"
Can't locate Config.pm in @INC (you may need to install the Config module) (@INC contains: /usr/lib/perl5/5.20 .) at /usr/lib/perl5/5.20/lib.pm line 4.
BEGIN failed--compilation aborted at /usr/lib/perl5/5.20/lib.pm line 4.
Compilation failed in require at -e line 1.
BEGIN failed--compilation aborted at -e line 1.
```

Do you have any comment on this before I create a pull request for this?)


Comment


yuuyuuyuduydjuf


Agree with you. Binary search should be faster.


a


Make this private and add method:

```java
public static Terrain forSymbol(c) {
...
}
```


Forgot tag. <documentation


Unhandled Fundamental Failure


Seems I used too much search these days..The first idea I came up eighther DFS or BFS..


Yes, true. Thanks.


input_clusterset_id should only be set if "use_notung"  is set, but that's something I've already fixed in master. No need to change anything here on the update_pipeline, but I wanted to mention this


You may be right. This file comes out of the box from c2cgeoportal (and this function is not used yet). In c2cgeoportal uuid strings are inserted in the URL to make sure new versions of the files are taken into account. See for instance http://geomapfish-demo.camptocamp.net/1.6/theme/Transport
Ditto for c2corg v5.

For the API we won't have those uuids so your suggestion probably makes more sense.


Still getting a few problems on this one bro...

8 July 1991

What did the customer buy?
 "menu" for menu

menu

{"Television"=>1200, "Laptop"=>1500, "GPS Watch"=>200, "Keyboard"=>50, "A Life"=>"You shall never have one...."}
What else?
 "exit" to exit
GPS Watch

new_app.rb:315:in `<main>': undefined method `+' for nil:NilClass (NoMethodError)
Mikes-MacBook-Pro-2:customer_service_app mike$


**Code Quality - Critical**

You have a missing semicolon here. Refer to our Javascript Style Guide referenced in the Checkpoint Rubric.
You Javascript code blocks should be written to standard so it stable in all environments (production, strict, es6 e.t.c).


ArrayList is implementation detail.


1: M111 unrecognized component name: tests


Adding a test would have been useful.  But better fixing something that nothing ;)


Okay, I just tested against c86fc8a of WR and see that CLJS version in ampere doesn't influence to WR build. But I also have successful build with 1.7.28, 1.7.48, 1.7.122 in WR's `project.clj`. May be it was weird caching issue? Try again with `lein clean` or even manual deletion of `target` and generated js.


b


This method is weird. Can you explain why you need it? There's probably a better way to solve whatever problem it is solving.


this seems redundant with what the "if" below is doing


I think that req is nil if there is an error in NewRequest, thus if you try to access the Header, it might segfault. It's probably hard that it fails, because it doesn't involve the request actually being sent, but still if the error return is there it might happen.


@gregg031827 Rename mo ung SUV at CRV pre, wag acronym tpos naka camel case


You don't need to repeat the type parameter. It is inferred:

```java
List<String> rows = new ArrayList<>();
```


The reason why it could be useful is that these errors are somewhat
language specific and after the programmers receive an error they might not
know what to do to create a language specific message form that. For
example you make a website that has Hungarian numbers spelled on it. What
if you have a number that is too big to spell. You receive an error
TooBigToSpellError and how do you proceed without knowing Hungarian. OK, I
understand that in most cases making a Hungarian site should involve
somebody who actually speaks the language, but one of the purposes of the
babel project is to help develop multi-language and multi-local
applications for those who actually does not speak the language.

Being able to provide precision= and maximum= as an option to speller is a
good idea and a more generic approach would be to receive an error or a
readable string describing the nature of the error depending on your
settings (maybe even both)

I need to think about this a little more, maybe even start implementing to
see what would be the best solution. Being able to control the behaviour of
the speller through optional function parameters is a good idea, but I
really think the user would appreciate a text message for every possible
input that is not ruled out by the given parameters.

On 22 September 2015 at 10:35, Lasse Schuirmann <notifications@github.com>
wrote:

> Why would you want to suppress errors? You want to handle them. Let's
> summarize the error cases:
>
>    - You're unable to spell the number. Programmer should know this, user
>    shouldn't be bothered. -> Exception.
>
> That's the only exception to worry about. It's totally usable by anyone
> who knows what an exception is.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/blagasz/babel/commit/ac0a41200eb91b648276955b8c2ece6c645f7a93#commitcomment-13361328>
> .
>


Gerhard, I very much agree that we should hide these details from the user by providing convenient abstractions, and using existing frameworks as much as possible. OTOH, I ended up looking at this  by remembering the multi-threaded C programs I wrote with pthreads - not a pleasant experience until you realise that you want objects that hide the message passing from the programmer. Still, it is necessary to be aware of what happens behind the scenes in order to use and reason about the objects that provide the convenient abstractions...

I have to prototype a few threaded things in C++ to see if these guys got it right... ;)


**Code Quality - Critical**

You should use strict comparison in your conditionals i.e `===`.
When comparing truthy or falsy data types, you don't need to equate them to `true` or `false`, and if that were the case (when type and value is required) `===` is to be used.

Here's how this line of code should be written:
```
if (arguments.length === 1 && !Array.isArray(arguments[0])) {
……
}
```


>> I'd like to collapse and move the minimum necessary contents of
>> $(WINPCAP_ROOT)/Win32/Include/<bittypes.h> and
>> $(WINPCAP_ROOT)/Win32/Include/ip6_misc.h into $(LIBPCAP_ROOT)/pcap-stdinc.h.

> +1

My bad. It seems to be `$(WINPCAP_ROOT)/Win32/Include/bittypes.h` that gets used. The dependencies for `print-bt.c` (`gcc -MM` generated) are:
```
$(OBJ_DIR)/print-bt.o: print-bt.c config.h netdissect-stdinc.h \
 ../../libpcap/Win32/Include/bittypes.h netdissect.h ../../libpcap/pcap.h \
 ../../libpcap/pcap/pcap.h ../../libpcap/pcap-stdinc.h \
 ../../libpcap/Win32/Include/IP6_misc.h ../../libpcap/pcap/bpf.h \
 ../../libpcap/pcap/dlt.h ip.h extract.h ../../libpcap/pcap/bluetooth.h
```
We should be able to collapse this into:
```
$(OBJ_DIR)/print-bt.o: print-bt.c config.h netdissect-stdinc.h \
                       netdissect.h                \
                       ../../libpcap/pcap.h        \
                       ../../libpcap/pcap/pcap.h   \
                       ../../libpcap/pcap-stdinc.h \  << ! add more Win32 stuff here
                       ../../libpcap/pcap/bpf.h    \
                       ../../libpcap/pcap/dlt.h    \
                       ip.h extract.h              \
                       ../../libpcap/pcap/bluetooth.h
```

Maybe rename `pcap-stdinc.h` to `pcap-win32.h` and keep some empty `pcap-stdinc.h` + `ip6_misc.h` for backwards compatibility? (with a `#pragma message("No not use  me!")` inside).


Thanks, that looks better :)
Is `recall` a standard lemma for aliasing?
Second question: right now it's impossible to call `print_string` and have some assurance about the state after the call, hence the initialization after printing `"Client sending: 10"`. Should we consider changing the type of print_string? I/O should not affect any of the "visible" state from the caller's perspective.


- camelCase please
- test case!


It looks like there is a special call to newick_format() that skips branch lengths in case of "raxml_parsimony". Why do we need this if ?


**Code Quality - Nitpick**

Javascript recommends came cased variable names (and object keys where feasible) as opposed to snake case.


Done.


:heart: I like api_reference, it better describes what this documentation is.


Revert lagi :cry:
Gara-gara menemukan shortcut yang cocok untuk buffer fuzzy search.


:ok: :1234:


Couldn't we have this piggy backing be the behaviour of `forceCheckPoint` and remove `tryCheckPoint` instead. What's the use case for having this `forceCheckPoint` behaviour over that of this new `tryCheckPoint` one?


@xcompass I don't think we can merge this PR without fully implemented OAuth support. The `EDX_API_KEY` cannot be given out to third parties such as other universities, so is not very useful in this case.

I think what you need instead of the above two lines is something like:

```python
if not ApiKeyHeaderPermission().has_permission(self.request, self):
    try:
        ThirdPartyAuthApiPermissions.objects.get(user=self.request.user, provider_id=provider_id)
    except ThirdPartyAuthApiPermissions.DoesNotExist:
        raise exceptions.PermissionDenied()
```

where `ApiKeyHeaderPermission` is a new model that links user accounts (or even better, OAuth2 clients) to provider_ids.


This fixes the issue. Thanks!


リングスさん、度々横から失礼します。
この部分のコードをsingleページのhtmlに追加しないと、変更が反映されない気がします！
ご確認よろしくお願いします！


Can you uppercase the SQL statements while you're in this file?


Git er noe forpult drit


@bbatsov I'm with you. I'd be sad to see these "documentation variables" go.


When you define multiple constructors you should delegate:

```java
public LockableItem() {
  this(null);
}
```


ok, I don't know until now :)


a return is missing here


**Code Quality - Nitpick**

Consistency in Javascript is very important. When creating strings, you should adopt either the double quotes or the single quotes.

Single quotes are employed here (highly recommended), and double quotes are employed in line _5_.

Be sure to use a single format throughout your code base.


The fact that fresh succeeds in more situations may lead to incompatibilities, but probably not frequently (of course this pull request is for trunk).


I removed `git_push_url` as it wasn't actually used after all (it comes from `build_conf`), and also removed `**kwargs` as they aren't used. Does this sound right? We want that API call to fail if provided with a keyword argument it doesn't know, don't we?


Sure, `index.rst` is still needed.


TBH I inherited this from code already existing for tests. It was weird to me as well, but I kept it in order to mitigate code-style differences between existing code and _my_ code.


@vrabaud what do you think about that ?


아이고 모르고 private으로 추가를.....


102867486-FixRectangleShapeTest-5173 (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1872 of 1881 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.52%25-yellow.svg)


1: M111 unrecognized component name: BibDocFile


Thanks!


It creates some micro-form of delay which when the callback is invoked, the file will have been read completely. It is a trick I learnt online. Without it the "then" method invokes the callback function with no waits or delays. The miniscule scale in delay caused by the setTimeout function ensure the callback will run late, thus will have found the json file was already read. Emulating the promise javascript pattern.


**Code Quality - Nitpick**

Javascript recommends using literal patterns as opposed to instantiating classes in the cases of `Objects` (`Array` and `RegExp` are not recommended either but have to be instantiated based on use case).

This is what the line of code should look like:

```
expect(typeof index).toBe(typeof {});
```


My prediction work.


I looked through the SP-CBF ICD and the information I first thought was a duplicate is not in reality. From the doc:

Multiple, simultaneous beams are supported (initially one for each of the two polarisations). It is
intended that each beamformer’s output will be routed to separate SPEAD receiver(s) and so no
attempt was made to keep variable names globally unique. All beamformer-applicable metadata is
reissued to each receiver’s network port using the same SPEAD Item IDs and variable names.


After performing a Pkg.update() with v0.3.11, attempting to perform `using ProfileView` resulted in the following error thrown at this line:

```
julia> using ProfileView
ERROR: AbstractFloat not defined
 in include at ./boot.jl:245
 in include_from_node1 at ./loading.jl:128
 in include at ./boot.jl:245
 in include_from_node1 at ./loading.jl:128
 in reload_path at loading.jl:152
 in _require at loading.jl:67
 in require at loading.jl:54
 in include at ./boot.jl:245
 in include_from_node1 at ./loading.jl:128
 in reload_path at loading.jl:152
 in _require at loading.jl:67
 in require at loading.jl:54
 in include at ./boot.jl:245
 in include_from_node1 at ./loading.jl:128
 in reload_path at loading.jl:152
 in _require at loading.jl:67
 in require at loading.jl:51
while loading /home/andy/.julia/v0.3/FixedPointNumbers/src/fixed32.jl, in expression starting on line 42
while loading /home/andy/.julia/v0.3/FixedPointNumbers/src/FixedPointNumbers.jl, in expression starting on line 46
while loading /home/andy/.julia/v0.3/Colors/src/Colors.jl, in expression starting on line 5
while loading /home/andy/.julia/v0.3/ProfileView/src/ProfileView.jl, in expression starting on line 3
```

Can AbstractFloat be properly handled by adding an `@compat` here, as well as lines 47 and 60?

This topic seems to have been discussed in [Compat.jl issue 121](https://github.com/JuliaLang/Compat.jl/issues/121)


@anrishitko


I'd make this class `final` instead; would that remove the need for an explicitly-defined virtual destructor ?


**no-unused-expressions**: Expected an assignment or function call and instead saw an expression.


**no-undef**: "TestUtils" is not defined.


**no-undef**: "ReactDOM" is not defined.


**no-undef**: "it" is not defined.


**require-jsdoc/require-jsdoc**: Missing @jsdoc for onChange


**no-undef**: "describe" is not defined.


**no-undef**: "before" is not defined.


**no-undef**: "expect" is not defined.


**no-undef**: "sinon" is not defined.


**no-debugger**: Unexpected 'debugger' statement.


This by default renders `canvas`, I'm pushing a commit to render `svg`


102867486-FixRectangleShapeTest-5173 (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


An actor should _have_ a container. It should not _be_ a container. In general we call this rule "Prefer composition over inheritance".


Fixed.


I think we should roll with this: it's more correct than before. We should, as NPG policy, only put UTF8 compliant stuff in the header. The spec actually says (approx interpretation) 7-bit ASCII only. Only concern is if we have some existing headers which contain non 7-bit are Latin1 characters rather than UTF8 (but don't think that should block this change).


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21022/testReport/) for this commit**


This should probably be called "ItemContainer" and it should probably be a concrete type.


From the SDP side, this is definitely our expectation. As with subarray
visibility data, no attempt is made to prevent namespace collision, since
each stream or beam will be sent to a separate receiver.

Simon

On Tue, Sep 22, 2015 at 10:58 AM, Monika Obrocka <notifications@github.com>
wrote:

> I looked through the SP-CBF ICD and the information I first thought was a
> duplicate is not in reality. From the doc:
>
> Multiple, simultaneous beams are supported (initially one for each of the
> two polarisations). It is
> intended that each beamformer’s output will be routed to separate SPEAD
> receiver(s) and so no
> attempt was made to keep variable names globally unique. All
> beamformer-applicable metadata is
> reissued to each receiver’s network port using the same SPEAD Item IDs and
> variable names.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ska-sa/corr2/commit/2e73de07fc9274fae31ec41c5f6d090a1a154d1d#commitcomment-13361765>
> .
>


Is this safe?


The person who introduced this :)

I now see that this merge is to master, and not the stable-dist branch, which makes DBC commits a part of this merge.
I'll address this to DBC.


**Test Coverage - Nitpick**

The data type of a new Array in javascript will return an object, it's more direct to check that it's an instance of the Array class.

Currently if `invertedIndex.searchIndex("alice")` returns `null` or `{}` the test will pass. See below how it should be written.

```
expect(invertedIndex.searchIndex("alice") instanceof Array).toBeTruthy();
```


it is a hard exception in #getParser


I realised that the table encoding for the header is latin1. I am going
to change it to utf8

Marina

On 22/09/2015 10:01, dkj wrote:
>
> I think we should roll with this: it's more correct than before. We
> should, as NPG policy, only put UTF8 compliant stuff in the header.
> The spec actually says (approx interpretation) 7-bit ASCII only. Only
> concern is if we have some existing headers which contain non 7-bit
> are Latin1 characters rather than UTF8 (but don't think that should
> block this change).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mgcam/npg_qc/commit/5eb91f6d094ca243818bb2e56d9cfb160d67fdea#commitcomment-13361868>.
>

--
 The Wellcome Trust Sanger Institute is operated by Genome Research
 Limited, a charity registered in England with number 1021457 and a
 company registered in England with number 2742969, whose registered
 office is 215 Euston Road, London, NW1 2BE.


Thank's you for this new feature Robin.

But for compatibility reason, I would add some code in the callback defined in contextmenu in order to keep the simple ajax code when the zone parameter is not bound in the tapestry component.
I have in mind something like https://github.com/got5/tapestry5-jquery/blob/maint-3.3.x/src/main/resources/org/got5/tapestry5/jquery/assets/mixins/bind/bind.js
I mean
	if ( specs.zone) {
                             var el = $('#'+specs.id);
	                     var zoneElement = zoneId === '^' ? $(el).closest('.t-zone') : $("#" + zoneId);
                             zoneElement .tapestryZone.tapestryZone("update",{url : u.url});
			   } else {
						$.ajax({
							type: "POST",
							url: u.url});
				   }

Also may i suggest you to add another example that use the zone parameter in test page?
the java classe is https://github.com/got5/tapestry5-jquery/blob/master/src/test/java/org/got5/tapestry5/jquery/pages/JQueryContextMenu.java

Best Regards
François


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8465/testReport/) for this commit**


missed it. ++


Use hexadecimals please :)


If you can't have "previous" or "future" locations then you probably don't need to qualify the actors "location" with "current".


All targets that generate documentation should depend on `reference`, not only `html`.  Either that or we drop them all.  I think it's better just to make them all depend on it.  Supporting all these targets is almost for free.  I don't think we will use most of the targets but I'm sure @derkling will appreciate the `applehelp` target, given how well versed he is with AppleScript :stuck_out_tongue_winking_eye:


`margin: auto 1px;`


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21023/testReport/) for this commit**


better to style on class than element type


This could possibly in the constructor...


Shouldn't this go into the config? /cc @hrmoller


**Comments - Awesome**

Your comments are pretty concise and consistently styled.
However, you should remove the commented-out lines of code you do not need anymore.


Why do you need to manage the "open" state?


IMO, ```No tablespace handler for URI scheme '%s'``` is a more appropriate message, but it still looks not intuitive for users. How about ```'%s' storage is not supported```?


Should be:
```java
private final Door door;
```


Yoho!


you could've used the `filter` or `reject` function of ember array – would be more idiomatic


ArrayList is implementation detail.


If you want to prototype using the soon-to-be-standard C++ primitves, you could start from https://github.com/stlab/libraries -- and then use the 'trivial scheduler on top of threads' as that library abstracts the 'executors'  behind a single 'schedule' function, i.e. you create you callable, and then you throw it at 'async' which then turns it into a packaged_task and future,  and it will push them into 'schedule' once they become runnable.... So I think that is the right model, and this should work on top of most other runtimes such as TBB and HPX, and there is another 8 line example on how to run it on top of lib dispatch (aka Apple Grand Central Dispatch).


A location can have actors as well as items.


I would expect

````
if (!hasAlreadyBeenExecuted()) {
 [...]
```

or

```java
if (!hasAlreadyBeenExecuted()) {
  return;
}
[...]
```


I think this space was nice. You should have kept it in.


or the method name could be changed