I would be interested in comments regarding:
1) Exposing the RocksDB options.
- Are there others that should be exposed?
- Has anyone tried varying the defaults defined in the current code.
2) Benchmarking tool.
- Do other people use local mode?
- Is there a preferred tool for evaluating storage engine performance.
I am getting some strange results with the Benchmarking tool in local mode.  Writes can be very expensive with RocksDB.  The results don't seem to line up with my "non benchmarking" test results (loading a large store into RocksDB using fetch/update).


When trying to create a custom build with this change, the build is successful, but the install fails due to missing dependency. Is there something else I need to do?


Forgot to mention that `&` is a restricted character in XML. Encode it with `&`


This would change behavior. Your new line 18 set jQuery to an empty object if it's not loaded. The next 7 lines that run if jQuery is undefined and load the library will therefore never run.


This whole branch should probably transfer, I think it's not so interesting to compile the write+read if we transfer for the loading anyway.


Should we? Seems like it could be useful?

On Monday, September 28, 2015, Mior Muhammad Zaki <notifications@github.com>
wrote:

> Should remove the actual method as well.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/framework/commit/dee4e0c80a1a376be27695c3bbc9a46eb9541a53#commitcomment-13467858>
> .
>


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 62](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=227&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:31:01


We had problems where a {% button %} was used on the page, and because it was automatically set to `type="submit"`, a page connection was dropped. So `type="submit"` was not a safe default. Better to set it explicitly.

I have updated quite some templates, so I may have missed one or two.


It was just to have a more convenient way of creating them.
Having to do
```
$attribute = new Attribute();
$attribute->key = $key;
$attribute->value = $value;
```
every time seemed a bit vebose. But sure, we can drop it.


I think I'd better pass it as ```deletedMessageIds``` property of ```deleted``` event argument [1], and will fire ```deleted``` event all the time if at least one message is deleted - at least it will be closer to what happens in reality :)

[1] http://mxr.mozilla.org/mozilla-central/source/dom/webidl/MozMessageDeletedEvent.webidl#21


@poupotte coffeelint is configured to warn for empty params list


I am not a huge fan of requiring the user to do that separately in some wrapper code, if we can find a better solution.


@poupotte printit is required at the start of this file. Maybe you should use it here


it's available [here](http://repo.jenkins-ci.org/simple/releases/org/jenkins-ci/plugins/aws-java-sdk/1.10.16/), so it seems you don't have maven well setup


A few questions:
Why did you remove the toggle_ programs?

The way you added the pixie.cfg file to the cmake any changes to pixie.cfg in the exec folder will be overwritten by a make install. I doubt this was intentional. I had not added this previously as it is custom tuned for different setups.


Godzilla is in town.


TeamCity DNN JavaScript Libraries :: CI [Build 97](http://teamcity.engagesoftware.com/viewLog.html?buildId=371&buildTypeId=DnnJavaScriptLibraries_Ci) is now running


TeamCity DNN JavaScript Libraries :: CI [Build 97](http://teamcity.engagesoftware.com/viewLog.html?buildId=371&buildTypeId=DnnJavaScriptLibraries_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:0:13


Doesn't this need an `!IsPlane` check then?


I was looking at a way to add a `ConditionProfile` on this, but wasn't clear on who would own the profile reference. I guess a straight transfer would do about the same thing.


It's protected method, don't sure if it's useful since none of the available code uses it.

Could make it public, but need to be clear with what the different between `fresh()` and `refresh()`.


spec for it? :)


why is it like this?


> should we have a default behavior ? maybe throwing ?

Sure, will throw, just to be on the safe side


I'd make user error messages uniform: `Option "--inner-runner-chdir" requires...`


Commit tagged in METADATA as v0.11.13 (JuliaLang/METADATA.jl#3555).


Great tutorial. I felt like there was a simpler solution to improving the vote state reset, which involved only modifying `vote-client/src/reducer.js`. Compare the old state to the new state; if the vote pairs are different, then reset the vote on that transition.
```javascript
function setState(state, newState) {
  let mergedState = state.merge(newState);
  const oldPair = state.getIn(['vote', 'pair'], List());
  const newPair = mergedState.getIn(['vote', 'pair'], List());
  if (mergedState.get('hasVoted') && !oldPair.equals(newPair)) {
    return mergedState.remove('hasVoted');
  }
  return mergedState;
}

[...]

export default function(state = Map(), action) {
  switch (action.type) {
  case 'SET_STATE':
    return setState(state, action.state);
  case 'VOTE':
    return vote(state, action.entry);
  }
  return state;
}
```


thanks for you quick response. I indeed got a step further, now the problem seems that the execustion path is relative to the file, not project. error:

```
Error: Could not locate Gemfile or .bundle/ directory  at /Users/rngtng/.atom/packages/linter-rubocop/index.coffee
``


One possible idea is having a dedicated wrapper somewhere in the runtime that we can import in generated flowgraphs. Users could still just run top_block.py or they could import the existing wrapper. I'm not sure if this is really a better solution though.


Test comment :+1:


Hello Github !


right, i already made all changes.. it just experimental work for own use and for reference for stable version.. getting higher benchmark, but got some some deadlock in 24 hours...


Shouldn't this be using `ModelUtil.isConstructor` instead of just checking with `instanceof Constructor`?


oh dear. I guess we'll need to remove Error from our responses to make bugs like this one impossible.


@designbyjake I think this should be outside of the `li`?


You should write these folowing conditions with a switch case


I think the name here is a bit too generic, perhaps `eventsListing` or `eventsByDate`? Also I miss the context a bit and don't know what the two date levels mean.


NOTE, this code may not be valid.

Take for example HDAA.  In there, you lc the whole string.  Then complain when the value $GET$ gets changed to get but not 'corrected', or if user names with up case get set to lc, but the format does not 'fix' them.   The HDAA format has alreadfy been properly corrected. There were 3 hex fields.  They all use proper ishexlc() function in valid.

The only things which SHOULD be converted are hex strings.  Literal stuff MUST be maintained.  Unfortunately, just because a set of bytes 'appears' to be hex, does not mean that it is.

However, I think if we want to find 'more' failures, using code Like I wrote before, then we should scour the input hash, looking for strings of bytes that are 'hex', that are of certain fixed sizes. If we find these 'sized' strings, then we case them.  I would say we first search for the return of binary() and return of salt()   If we find them we are pretty sure they ARE hex. Otherwise we look for string taht are:

16 bytes    (8 byte raw data)
24 bytes   (12 bytes raw data)
32 bytes   (16 bytes raw data, very common)
40 bytes
48 bytes
56 bytes
64 bytes
72 bytes
84, 96, 112, 128   And then really long even length hex strings, say > 128 bytes. These would often be file blobs, or encrypted data.

Those are probably semi safe to assume that we could mangle the case, and either valid would fail, OR split should revert them back to some default.

Jim.


If you make that change, be sure to include the value of `storeID` in the error below (and in other equivalent errors)


this is a comment


this is a second comment


@poupotte it feels weird that `quota` is an absolute space and `warning` is a percentage.


Just a comment on the commit message:
The title should be a sentence in the imperative (as an order), e.g. "Update Maven pom", under 72 columns

You can then skip a line and add a more verbose description under.


I grepped and updated everything I found. Also ran through the workflow a couple times and nothing seems broken.


Fixes #33


I guess `assert inner_runner is not None, 'Inner runner test...'` seems like a more natural construct. Or even using the `self.assertIsNotNone()` function of the base avocado test.


@poupotte `pourcentage` is french ;-)


huh. I'll try removing it.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#JhA41BrYQjONgQa-EM9TYQ


Hast du dich nicht gewundert, dass min über mean liegt? ;)


this is looks to be a count of events, perhaps the name should resemble that better


Hey, feel free to rewrite it, as long as the SDK compiles I'm fine :)


Commit message: no period at the end


@toobulkeh did you mean to update the image here?  this is just for the photographer profile, not a specific appointment


@drbparsons this adds some space to nested lists. I guess they don’t always need the added vertical space?


btw why don't you set `self.tmp_dir` to `None` during `__init__`? It'd be IMO the cleanest solution.


:D


@poupotte there is no space before `:` in english


I just copied the wrong code, it should just be `@profile.image`


@poupotte s/use/used/ ; s/size/space/


Correct me if I'm wrong, but this sanity check would be after the NPE location (https://github.com/jenkinsci/jenkins/blob/44d1d2b75fd4df1ab93ee33648ba645a0d4a3680/core/src/main/java/jenkins/triggers/ReverseBuildTrigger.java#L111), which traces from ```trigger.shouldTrigger(r, listener)``` on line 238.

In ```shouldTrigger``` there's a sanity check for ```jenkins```, so I presume the NPE occurs because ```job``` is null.

Changing ```if (trigger.shouldTrigger(r, listener)) {``` to ```if (trigger.job != null && trigger.shouldTrigger(r, listener)) {``` (instead of this change) would fix it.


I think there's an MRI test, but I'll add a spec :-)


Min, max


This if blocks skips triggering jobs that not required, see 2 lines below. If job is null that trigger shouldn't be run.


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4068/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


the gutter size looks to be halved and quartered a lot, perhaps it's not the de facto size anymore and we need to consider a smaller one?


I think this one is just an oversight. After all, we wanted to query all stores here, it's just that we were being sloppy on checking which store was actually the right one (or that the assumption was that one of the requests would succeed).


should assert e


Did you intend to include this in this commit?


:+1: bar the comments. squashing helped a lot to see the remaining bit that needed review, thanks!


@designbyjake but the way it’s nested at the moment the styles would only apple to:

```
<ul>
  <li>
    <ul>...</ul>
  </li>
</ul>
```

rather than

```
<ul>
    <ul>...</ul>
</ul>
```

Or am I confuddled?


we should start using more descriptive variables: `err` instead of `e`


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 42](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=228&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


### Felicitazioni
Congrats on your first commit, man!
That's definitely should be celebrated somehow.

### Git flow
To make first steps easier, there's a great introductory course here
https://www.codeschool.com/courses/try-git

### And one more thing
btw, it'd be useful to follow the general tips for making your commits silky smooth https://github.com/blog/926-shiny-new-commit-styles


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 42](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=228&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:00:41


TeamCity Xbim :: Xbim Analysis :: XbimAnalysis [Build 15](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=229&buildTypeId=Xbim_XbimAnalysis_XbimAnalysis) is now running


The levels are "grouped by month" and then "events grouped by day"


TeamCity Xbim :: Xbim Analysis :: XbimAnalysis [Build 15](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=229&buildTypeId=Xbim_XbimAnalysis_XbimAnalysis) outcome was **SUCCESS**
Summary: Running Build time: 00:00:20


Oki Feng no problem.
m.

On Sun, Sep 27, 2015 at 3:16 AM, Feng Gao <notifications@github.com> wrote:

> Ok. Wait me for one or two days.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gfreewind/linuximq-HighPerf/commit/2fb440f1b70c86841489663e9fbd1b00f488df73#commitcomment-13454011>
> .
>


Yes - let's call the App Messenger Rewriter @Paxxi :-)


複数の拡張子にマッチさせるの、こう書けば出来るんですね。
分からなかったので2行書いてました〆(・∀・＠)


om iki trakhir mbok update opo? kok cdm e male gaiso tak buka


@drbparsons ooo, is that valid markup? ¯\\\_(ツ)_/¯ I thought you had to nest the `<ul>` within an `<li>` for it to be valid.


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 43](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=230&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 43](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=230&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **SUCCESS**
Summary: Running Build time: 00:00:43


Bug


please rename to what the test demonstrates:  `save$ can save id when set on id$ property`


One `osx_image` should be enough :wink:


ah - good spot. back to the drawing board!


Wow, I was here to PR this same thing. :thumbsup: You did already!


That's definitely not how it should be!
We **don't** create global styles programmatically.
Why do you do this?!


ups 👍


well it compiles, but it doesn't run...


Mmmm... yes it's true but have a percentage (and not a size) for `warning` allows to modify only `quota` if you want increase user space.


You win... please ignore my invalid html requests... 😝🔫

http://www.w3.org/wiki/HTML_lists#Nesting_lists


Keep it in this pr but pull it into a separate commit  (and attributes.js)

Thanks for the work btw :)


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I think your edit was very valuable.  Good job!


sx


should start using strict comparison


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 16](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=231&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


But of course test case will prove everything :)


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 16](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=231&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **SUCCESS**
Summary: Running Build time: 00:00:21


TeamCity pull requests :: netty [Build 322](https://garage.netty.io/teamcity/viewLog.html?buildId=1794&buildTypeId=pulls_netty&guest=1) is now running


I missed the dependency is now on another plugin and not a set of jars. After installing the AWK SDK plugin, everything installs as expected.


...i recommend you to change this back


NDEBUG shouldn't be a concern after 2c2c86178ae1d604971d41651d25bcc63c0ecae4


I'm not sure -- all examples I saw used a closure -- I will look into this.


I have a similar issue in chapter 6 where =obtain y H, from H1,= isn't printed as code because of the trailing comma. Is there a way to work around this?


Awesome! :+1:


Ah, right, I forgot to test that, well, I'll let you fix it then :)


result with PR

```cmd
c:\lab\react-component-template>npm run build

> react-component-template@1.0.0 prebuild c:\lab\react-component-template
> rimraf lib example build

> react-component-template@1.0.0 build c:\lab\react-component-template
> parallelshell -w "npm run build:lib -s" "npm run build:example -s" "npm run bu
ild:bower -s"

src\Component.js -> lib\Component.js
src\index.js -> lib\index.js
Hash: a64fb6c37360b5188cc3
Version: webpack 1.12.2
Time: 1443ms
                          Asset     Size  Chunks             Chunk Names
    react-component-template.js  3.13 kB       0  [emitted]  main
react-component-template.js.map  3.21 kB       0  [emitted]  main
    + 3 hidden modules
Hash: 691877f4066bdd521306
Version: webpack 1.12.2
Time: 2715ms
        Asset       Size  Chunks             Chunk Names
    bundle.js     607 kB       0  [emitted]  main
bundle.js.map     735 kB       0  [emitted]  main
   index.html  185 bytes          [emitted]
    + 154 hidden modules

c:\lab\react-component-template>
```


Ist `File` absichtlich groß geschrieben ?


Update opo yo, kapan kae tau ngedit cdm durung tak puss tapi wes tak pull
karo nggone sampeyan sing anyar terus tak push, mari kuwi lagek gak iso
dbukak mas
On 28 Sep 2015 22:23, "shulhankhairy" <notifications@github.com> wrote:

> om iki trakhir mbok update opo? kok cdm e male gaiso tak buka
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/shulhankhairy/hotelku/commit/fa676196cec09732c774b8dfe9576d7637dbe130#commitcomment-13471541>
> .
>


@mbootsector This is fantastic, especially considering that
    rootDepth + (Depth)(((th->idx - 1) / 2) + 1);
is just a first try. I'm pretty sure that a variant exists that will also do well with many threads.


@flavour I initialized the scheduler_task here and running here: https://github.com/biplovbhandari/eden/commit/4dfdb2d757767303933207a3d857b91cd008e94a#diff-4a10b6925357b1b4aa8215107048b7adR258

However this only seems to run once and then stop even tough the status and next_run_time is changed. If I put repeats=0, it runs every interval .

What am I missing here?


Hi

i using livestreamer with your modification.its possible to update with latest version.?

thanks


Fix for issue #2


BUG: player goes out of game window


Fixed ldap page (using the separator only on non-ldap page) to have the expected margins:
![screen shot 2015-09-28 at 17 31 43](https://cloud.githubusercontent.com/assets/978461/10140246/df9195c8-6606-11e5-924d-04cd9b4d895d.png)
![screen shot 2015-09-28 at 17 30 41](https://cloud.githubusercontent.com/assets/978461/10140245/df8c73d6-6606-11e5-8d6a-ce4af4b133fc.png)


The fonttools idiom we use is to call tobytes().


A hostname is "resolved" a redirect is "followed"? Or at least that's the way my brain works?


BUG : Not falling down the platform instead  locked the moves when it is near the edge of a platform.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.627](http://teamcity.monogame.net/viewLog.html?buildId=10365&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Yeah, it throws with famous ```StaleElementReference: StaleElementReference: The element reference is stale. Either the element is no longer attached to the DOM or the page has been refreshed.``` :/


@gartung , may be we can change the logic here so that it does not exit on first failure but checks all the transients classes and fails at the end if any of them were not marked as transient?


@psiemens totally your call to accept this or not since it's a straight up rewrite but I feel it's more clear


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 25](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=232&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


1. refactor bad implementation of "pool of constants" (make abstract class with private constructor)
2. make method static cause of using only static method in it.


The reason of using `php -r ...` instead of `cp ..` is because of compatibility (with windows)?


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 25](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=232&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **SUCCESS**
Summary: Running Build time: 00:00:52


why did you change this to Hashtable? you should depend on abstract. change this back
if you want a threaded-safety map, use ConcurrentHashMap, it's more efficient than HashTable.


it's probably better to make a CP than have two nested if statements


here we have at least 2 tests with the same title; and it does not look very readable.

How about something like this:
```javascript
var tests = [
  { delay: SECOND, name: "1 second" },
  { delay: MINUTE - 1, name: "less than 1 minute" },
  { delay: MINUTE, name: "1 minute", l10nId: 'late-arrival-notice-in-minutes' },
  ...
];

tests.forEach(({ delay, name, l10nId }) => {
  var testTitle = name + ' delay';
  testTitle += l10nId ? (' displays ' + l10nId) : ' does not display late notice';
  ...
});
```

Just a suggestion, tell me what you think.


topic 4 con addfriends


testGithub


Thank you all. :)
I've scheduled an LTC run, and reduced priority of the STC run.


I (just inherently) dislike this mode. Will disable it with ```set cinoptions-=(0```

- When you change the length of first line of function title, reindenting will edit all following tail lines;
- Inserts spaces after tabs. I cannot find this place in CodingStyle now, but it states that spaces mustn't be used for indentation.


@poupotte s/use/used/ here too


also, change this back to List.


There's a great thing for that. You can place README.md file in the root of you project, where `.md` stands for Markdown. Markdown is awesome.

For instance:
```
# Heading 1
## Heading 2
Silvio `inline code snippet` Berlusconi
- uno
- due
- tre

### And the special one for formulas:
![equation](http://latex.codecogs.com/gif.latex?E=M*C)
```
becomes shiny formatted

---
# Heading 1
## Heading 2
Silvio `inline code snippet` Berlusconi
- uno
- due
- tre

### And the special one for formulas
![equation](http://latex.codecogs.com/gif.latex?E=M*C)

---
See? As easy as pie!


app messenger is completely useless because its primary purpose is to execute something on the main thread. exactly the opposite of what is desired here.


nit: if we use my proposal, you can do `if (l10nId) { ... } else { ... }` (and inverse the 2 blocks).

otherwise you can do `if (dataL10nIds[index]) { ...} else { ... }` and still inverse the 2 blocks.


thank you! sage.


One option is to guarantee that the label checker always runs first, then
you wouldn't have to check here?

On Sat, Sep 26, 2015 at 2:18 PM, Eric Paris <notifications@github.com>
wrote:

> That's an option, but, we only have 5000 calls per hour and one loop
> through the munger takes about 2000 calls...
>
> Double removing things like labels doesn't hurt. But double printing the
> message that we are going to remove kind of stinks...
>
> I'll give it some more thought.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/eparis/contrib/commit/54be11da0b637a1867c49b9e92cbc01caf2ff5a5#commitcomment-13453390>
> .
>


Nice! You just missed the variables `shootCooldown` and `splitCooldown`, these are undefined in the script - although I think in your case there shouldn't be any cooldown at all.


exactly


You're right, this is much better. Where are the tests though??


yeah, I wasn't quite sure on the phrasing here (which might explain the missing period :flushed: ). IIRC I wanted to avoid the passive "followed", that seemed weird somehow, but whatever. Feel free to change.


Changed Priority to -1.  As the results seems inconclusive and don't want to burn through resources...


`errno` is a static variable, same for every TA. We should take care to protect, using mutexes, this variable when in multiple TA (that should come soon). @jenswi is it ok?


okay... but at least with plugged charger + playing music will work without any issues ??
Tonight had also faced many wakeups.. phone was most of time awake ... also i had too high cpu freq ... (max freq)


@atfornes Why changing `communityId` for `comId`? It is more cryptic


Vamos a implementar de una vez
https://github.com/mashpie/i18n-node
Y lo configuramos con Transifex.com


whoa, you have eyes like an eagle!


Apologies--thanks for the clarification!


PEP 8 violates : invalid method name "collectCoin".


OK. I will work on something. Should I submit a new pull request to the main repo?


@atfornes why did you change it for tab? It broke other links, such as the link from project list needs


This format is support by Transifex via JSON Key-Value
http://docs.transifex.com/integrations/nodejs/


@mjdetullio maybe you are right and check need to be before. Do you want provide a test case and a fix? Then i will be happy to not do this work :)


I would prefer to exclude the use of inappropriate "assertions". There is no need to fiddle with the detail "`#undef NDEBUG`" then.


Addressed in https://github.com/behdad/fonttools/commit/a5968458015b519bc415f3ca7d882a428f45c347


The hint for your `README.md`:

```markdown
# Предметная область
Емкость рынка в денежном выражении

Формула расчета емкости:
![equation](http://latex.codecogs.com/gif.latex?E=M*C)
> M — количество проданной продукции, штук
> С — стоимость единицы товара, руб
```

---
# Предметная область
Емкость рынка в денежном выражении

Формула расчета емкости:
![equation](http://latex.codecogs.com/gif.latex?E=M*C)
> M — количество проданной продукции, штук
> С — стоимость единицы товара, руб


Since `output` already has a value `testtock`, YAML parser doesn't like the nested syntax for `contentType`


please ignore, just missed that you inlucde it somewhere else :-/


@feejin Is there a reason `vertical-align: super/sub;` isn't used?


I really have been out of the loop. If "is rw" is illegal, does that mean every parameter is treated as a reference instead of a read-only copy?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1360 of 1360 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hi Sankhesh -

Things are describe here:  http://www.na-mic.org/Bug/view.php?id=4054

I didn't save the stack trace but Slicer4.4 will crash the same way if you
try to volume render a multivolume node.  Something to do with the lookup
table.

It may be related to the VolumeRenderingReplacements, which may not have
all the fixes of the upstream versions -- someday we should revisit if
these are required.

Thanks,
Steve

On Mon, Sep 28, 2015 at 9:42 AM, Sankhesh Jhaveri <notifications@github.com>
wrote:

> @jcfr <https://github.com/jcfr> @pieper <https://github.com/pieper> Each
> render call, ValidateRender is invoked that does a bunch of checks (input
> data exists?, number of components, etc.) to make sure that the mapper can
> render the dataset. What are the conditions that cause the crash described
> here?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Slicer/Slicer/commit/97b5d3086fa710985962999154012b76bf7b3d8c#commitcomment-13468837>
> .
>


@jameskung @m943040028 `is_tee_file_exist` is going to the REE. That means another TA may run while we're in the REE, meaning `errno` may be changed by this other TA. Should not we have some kind of protection here?


This is a left over debug statement. Thanks for spotting it, deleting.


Of course we wouldn't expect any of our code to supply some other negative number besides -1 however this could could be more crash proof it the outer **if** block logic were something like:

  if (index >= 0 && index < _jointStates.size()) {


Personally I'm avoiding this kind of cast, we have ARG_UNUSED etc when we need such functionality. In addition it gives the wrong hint to the compiler in this case, because we are in fact using the return value as we should, even if we are only doing it in DEBUG mode. In the future the cast can be forgotten after some code refactoring and create trouble.

What do you think about changing `assert()` to `CF_ASSERT()` for these cases?


looks good, but make proper ref to issue # commit title so that issue autocloses when accepting the commit ;)


Nein, ich habe bloß den Teil davor gelöscht und vergessen, den Buchstaben klein zu schreiben. Danke für den Hinweis!


Minor: It looks a bit weird that this (and other accessors added in later commits) are all on separate lines, but `:tax_credits_award_ends_on`, `:accounts_end_month_and_day` and `:taxable_profit` are all on a single line. I think it would be good to split them all up onto separate lines.

See also:

* https://github.com/alphagov/smart-answers/commit/f0713583a9acbe3610c025025cb36089fcc0de69
* https://github.com/alphagov/smart-answers/commit/ae57d87216766360debafbb34344a5fc39e2745c


Thanks


Because of the way Borg works, it doesn't make any difference really. Maybe only visually because it's more common. But if we go that route, we may just as well use the Singleton pattern. @lmr what do you think?


You could also use 'enum class' here if it's supported by targeted compiler versions.


Yeah, I initially had Visual Studio configured to use tabs ... Fixing it.


Cyclomatic complexity : too many if and else condition.


I think as long as you are using more than just destination, you cannot have the shortcut. In other words use the following:

```
spring:
  cloud:
    stream:
      bindings:
        output:
          destination: testtock
          outputType: text/plain
```


That should do it! Let me know if there's anything else.


As discussed, `this.props.transformData ? this.props.transformData(this.props.data) : this.props.data` would probably be better.


I updated this to use the capabilities object rather than reaching out for user agents in the view: f734a07


QUEUED just means QUEUED - it doesn't say 'run now'
repeats = 1 to run just once (0 is indeed unlimited as you can see in the field.comment in appadmin)

Maybe a better approach than this is not to create any sync_task records at all during setup...in onapprove we can simply read the list of repo_ids & current.s3task.async() each of them.
This will create the necessary repeats=1 sync_task records


You can remove this is you add the ternary up there.


oh, yeah; I forgot about that :-)


Shouldn't it be LOG_TRACE level instead ?


Not sure why again here? (it works)


@szaghi :D \o/ :+1:


You can remove this if you remove the ternary down there.


Please change this to 2.0.0, since that's the version that will be next released.


new api takes care of this?


Subjective: I'm not a big fan of this kind of assignment-equals-sign-alignment, unless there are quite a few very similar assignments.


I don't think the error will print properly here. Perhaps you want

log.Println("Failed to start TAS: ", err)


If you add the ternary in `Template`, you can remove all references to `identity` here.


Here's ~~hummus~~ pull request for you #1
Just press `merge` and it'll merge in your `master` branch


Ah yes to avoid the identify that I did not wanted but then I want? lol :dancer:


what about site settings? They would change the top menu settings and such right?


why are you hardcoding the processor to 10?


Code smell: large class.


Hehe...it passed ! Congrats !

I think it should be committed as is, despite the obvious overlap, and some simplification will eventually be found.

On one hand, we have a base score made of psqt, shelterweakness, and stormdanger
On the other hand, some attackunits are cumulated and then added as a score after the following
transformation.
![2015-09-28_11h18_17](https://cloud.githubusercontent.com/assets/8949638/10139848/e34d8d18-65d2-11e5-8e00-58bb3ff871e0.jpg)

And now this new patch which adds to the base score...

We tuned attackunits many time since this original zamar tests (this was 2 years ago !)
https://groups.google.com/forum/?fromgroups=#!searchin/fishcooking_results/Small$20bonus$20for$20being
and still this idea had a good effect !

This shows that despite all the tuning, you will never get the exact same vertical translation effect and benefit.

Therefore, if we are to try some simplification, it seems that it will be to
- do not compute safe checks as attackunits,
- but only, directly, as score bonus. An average attackunits translate to a score of S(6, 0) +-4
  so this will be easy to convert.

The ability to deliver a safe check is a sign that the King pawn shelter + pieces has some holes.
It would make sense to score this only as a score as we do with shelterweakness and stormdanger.


Unresolved vars


Yes it does. But the revision was for 7.0, and in this release it wasn't the case


Don't forget to remove "world_india_deccan" and "world_india_bengal" from "world_india".


Autoedit


Could you create an issue for that? @steelbrain we'll need to be able to set the cwd of the process `atom-linter` spawns to make `bundle exec rubocop` work.


Unresolved


Matches the import


Exception: CommandException not found :)


If `template` is `undefined` here, we should probably throw an error since it means neither the default template nor the template were given, which should not happen.


This is just a little bit of refactoring. The initial code was inlining json as a string instead of using a JS object. Since I changed that code to server different URLs I did it ""correctly"".


yeah I did it this way just for simplicity, less boxes to open up to figure what is going on


Got this during interview discussion: if we synchronize against the private "queue" inside the not synchronized public method of BlockingQueue - we avoid that any other Thread will lock all the synchronized BlockingQueue methods by calling synchronize(instanceBlockingQueue){...}


well right now, I only want one way however let me try this approach and see if everything breaks or not :)


@caseywebdev we already support `cwd` as an option


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21272/testReport/) for this commit**


Set CNANE


I pinged someone a while back but never got a response, I will see if I can get some eyes from anyone


Love it!


Could you remove this? It seems this line has got duplicated somehow.


Hello,

As a fork maintainer, I would like to say a few things about this proposal.

First, I think it is a wonderful idea if someone else takes over this project, since the owner no longer can maintain it. However, I'm not so sure if the ownership of this project should be given to a commercial entity as  a2800276.

Indeed, creating an organization of this project sounds like a wonderful idea, since the ownership of the project will belong to the community (one with a lot of forks).

I (myself) would be more than happy to maintain this community and review every incoming pull request. QuickPay can be given write access to this community since they have been good contributors.


Oh, perfect


That's a good point. That would be much more straightforward. I'll change that.


@sundar02 You have to fork this repo. Add your answers inline to the questions. and send a pull request. Check out http://try.github.com incase you are not familar with git. I am gonna remove yours answers from your comment so that, future candidates don't see it.

Also regarding answer 3, i want the commands for it, OS specific. If you use linux, commands from the command line to achieve this.


we have no tests for anything and it's Not A Good Thing!


Got it, good catch!


I think this addition and the one at line 51 are just whitespace changes, but if you could remove them while you're removing the duplicate line it'd help keep the changelog clean. :)


Imath has two methods for Boxes, which mean slightly different things.

isEmpty() means "can be considered a null box. max is less than min"
hasVolume() means "has pixels inside"

There are Boxes where ! box.isEmpty() && ! box.hasVolume() can be valid - a box where either min.x == max.x or min.y == max.y

ImageAlgo::empty() is more like the inverse of box.hasVolume() at the moment, which is fine for my use here, but I think that there are places where a method called something like isNullBox() which returns true if min < max in any dimension would be good.


Why is this rule set for `#eventlist` and why is it called `$success-color`?


useless


@VickiG DWMR (done with my review). Good job here. Keep going!


Subjective: I think it would be nice to extract the `ends_on` value passed into `DateRange` into a local variable c.f. the way `begins_on` is extracted in 5e893eb700703e86f04a3455af4fb1ae79f9a22b.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.627](http://teamcity.monogame.net/viewLog.html?buildId=10365&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:19:56


By changing the select, I can also get rid of the if statement and just assign the Vgatefilter and Vradar.


No LOG_TRACE level currently in FFmpeg, keep LOG_DEBUG for the moment.


An attack exist -> An attack exists
Consistency with off-line first instance, later offline.


Same here, on OS X I had to install gnu-sed, add it to path, and use sed -E. Thanks for this @paulirish!


I'd be interested in getting a pull request when you are done testing.  My fork is going to be working on this module soon due to changes in ffmpeg and it would be good to get a clean pull.  I'd point out that in the MY section of the codecs, you may want to consider just using the H264 specification instead of H265 for the versions less than 56 of libavformat.  The H265 may not have existed for those really old versions of ffmpeg.


this is one weird tree traversal function


why is line 19 needed?


Oops no I didn't mean to add the those two **exemple** scripts. I'll remove and resubmit.


Hi Mark, sorry, I should have made my email comment here..  I'm getting used to commenting on commits


Yummy!


I actually wondered if the saveRadar should come out to a common function, maybe with a keyword for looping through Vgatefilter changes?


the atoi here isn't necessary either, you can just use string directly, it will look the same


It looks ok, though I think the removed `return false;` probably still needs to be there (will double-check). Seems it was an error that was reiterated via copy/paste. Also, seems like Coverity missed some other functions with that flawed logic flow as well.


So somehow it just enlarges the path-specific require lock to the constant resolution?


@PeterDaveHello thanks for this! Wondering how long before it shows up here https://cdnjs.com/libraries/axios


Comments anywhere are better than none! But GitHub is ideal.
We can discuss this when we talk next - until then simply press ahead with the
next checkpoint(s).

On Mon, Sep 28, 2015 at 11:57 AM, Chris Allen < notifications@github.com > wrote:
Hi Mark, sorry, I should have made my email comment here.. I'm getting used to
commenting on commits

—
Reply to this email directly or view it on GitHub .

Not using Mixmax yet?


TeamCity Safe DNN Minification :: CI [Build 1](http://teamcity.engagesoftware.com/viewLog.html?buildId=372&buildTypeId=SafeDnnMinification_Ci) is now running


@flavour But we want to insert/update the sync_job table that needs scheduler_task_id?
How about repeats = row.repeat+1 in https://github.com/biplovbhandari/eden/commit/4dfdb2d757767303933207a3d857b91cd008e94a#diff-4a10b6925357b1b4aa8215107048b7adR256


Minor: I think the above two lines are essentially the same as [these two lines in `SmartAnswer::TaxYear'](https://github.com/alphagov/smart-answers/blob/a2c013b133e2a31c99c5d654e4de978650a860be/lib/smart_answer/tax_year.rb#L10-L13). This was why I thought it would be good to extract the concept of defining a custom class like `TaxYear` which starts/ends on a given date.


TeamCity Safe DNN Minification :: CI [Build 1](http://teamcity.engagesoftware.com/viewLog.html?buildId=372&buildTypeId=SafeDnnMinification_Ci) outcome was **FAILURE**
Summary: System.Exception: Start of process C:\TeamCity\buildAgent\work\3c67cf4b03e10bf\build\tools\NuGet\NuGet.exe failed. The system cannot find the file specified   at Fake.ProcessHelper.ExecProcessWithLambdas@76-16.Invoke(String message) in C:\code\fake\s... Build time: 0:1:16


Could we make the conditional here a little more precise with clang [builtin macros](http://clang.llvm.org/docs/LanguageExtensions.html#builtin-macros) to check version number, or [feature checking macros](http://clang.llvm.org/docs/LanguageExtensions.html#feature-checking-macros)?


Yep, it messes up line spacing
On Mon, 28 Sep 2015 at 16:41, Stan Hutcheon <notifications@github.com>
wrote:

> @feejin <https://github.com/feejin> Is there a reason vertical-align:
> super/sub; isn't used?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/feejin/Silverstripe-CleanInstall/commit/e7f3e165938a928df62cdbe6c5bcae3d759d855d#commitcomment-13471927>
> .
>


Minor: I think this is the [same logic as in `YearRange`](https://github.com/alphagov/smart-answers/blob/a2c013b133e2a31c99c5d654e4de978650a860be/lib/smart_answer/year_range.rb#L4). Also see my [comment about how we calculate the end of the accounting year](https://github.com/alphagov/smart-answers/commit/50c67778875096aee83e2d3d2e559b4251013f19#commitcomment-13472443).


1) wont this randomly pick which service_alias the backend ends up being named after?
2) also what about if you have a 2 services with the same VIRTUAL_HOST and another service with the same VIRTUAL_HOST but a different port? the third service shouldn't get put in the same backend with the first two should it?


give a space after '#' in comments.not folloing pep8.


Move mergeConfigFrom() to register() method


This was a leftover debug when i wasn't sure I was making changes to Vgatefilter. It should probably be removed.


Comparisons with True are not necessary and may not work as expected


can be done - but you need to do a
```
git mv charting/Datatypes charting/DataTypes
```


@gargsarthak30
 good background....


One aspect of the success of this patch could be that it gives bonus for safe checks in the endgame too, whereas  the attack unit stuff decrease to zero for endgame. Often in endgame a check which at the same time attacks a undefended piece/pawn or importent/weak square is dangerous


Does this trigger a rebuild?


При таком вызове исключения оно не пишет в лог сообщение. Это как-нибудь чинится?
(лог выглядит как 2015-09-28 19:03:21.3799, Error, )


not this line


I'm not a fan of the utf-8 marker for several reasons: first of all it is not really part of the source code and it seems messy to me to have such information in the code. Also, most editors already should by default use utf-8. And maybe the most important reason of all: this kind of stuff is editor dependent and really shouldn't belong here. What works with `emacs` won't necessarily work with `vim` or `eclipse` etc.

https://docs.python.org/2/reference/lexical_analysis.html#encoding-declarations

```
# -*- coding: <encoding-name> -*-

which is recognized also by GNU Emacs, and

# vim:fileencoding=<encoding-name>

which is recognized by Bram Moolenaar’s VIM. In addition, if the first bytes of the file are the UTF-8 byte-order mark ('\xef\xbb\xbf'), the declared file encoding is UTF-8 (this is supported, among others, by Microsoft’s notepad)
```


Local variable (fi) not used


maybe just `INPUT/OUTPUT_TYPE_KEY`?


use a white space around a operator.


I'm not sure I get all that was going on here. We're now passing a bound Template all the way down instead of passing its parameters?


잘못 수정된 코드 ㅠㅜ


c nul


Yes, but the problem is that `flush()` is a no-op in `Channel`. I think only `StateChannel` should have `flush()`. Then we'll have two sets of operations: `map()` on `ReadStateChannel` (that supports `flush()`) and `map()` on `ReadChannel` (which doesn't implement `flush()`).


this one triggers a restart and that is enough to use both env var and docker options


TeamCity pull requests :: netty [Build 322](https://garage.netty.io/teamcity/viewLog.html?buildId=1794&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 5611, ignored: 21; resource leak detected (new) Build time: 00:37:13


what a magic number? :)


mmm, I though I've just left reply here, but I don't see it :D So will repeat --- I think I'd better pass these ```deletedMessageIds``` to ```deleted``` event and will fire it all the time if at least on message is deleted, like it happens in reality [1].

[1] http://mxr.mozilla.org/mozilla-central/source/dom/webidl/MozMessageDeletedEvent.webidl#21


use the named constant here


It did not work together with navbar_top if it was not changed.


You mean S(0, 20) ?


Submitting a scripted test via the GUI, changing url back to text resolves this.
The behavior observed is that you enter a script and it will flash the URL bar, and not submit.


怎么我的这个页面不一样~~
<?php
require_once '../lib/config.php';
$smarty->display('admin/login.tpl')
?>


Why do we need a sync_job record?
Surely that's only needed if we sync on a schedule...but hear we want to sync right away & only when a new alert is approved(or updated...tbc)


I think we can do better than this, without using mozL10n.formatValue. The problem with formatValue is that it isn't retranslated automatically if the user changes the language while the app is launched. That's why it's better to use setAttributes instead, because it sets the data-attributes that the l10n library looks for when it needs to retranslate the application.

So here is a proposal.

* `getLateArrivalNotice` returns either an object { l10nId, l10nArgs } or null if no notice should be displayed.
* here, we do before appending:
```javascript
if (l10nInfo) {
  navigator.mozL10n.setAttributes(noticeNode, l10nInfo.l10nId, l10nInfo.l10nArgs);
} else {
  noticeNode.removeAttribute('data-l10n-id');
}
```

Also you don't need to wait for the "result" promise as we don't have anything async then.
Tell me what you think ?


TeamCity Safe DNN Minification :: CI [Build 2](http://teamcity.engagesoftware.com/viewLog.html?buildId=373&buildTypeId=SafeDnnMinification_Ci) is now running


testValidOrginal -> testValidOrdinal


That commit reflects a good idea. I like it.


section was used for mydoing/crowdoing and needs/info. This caused some problems when sharing a llink.

Sorry for broken link, I will try to fix it


TeamCity Safe DNN Minification :: CI [Build 2](http://teamcity.engagesoftware.com/viewLog.html?buildId=373&buildTypeId=SafeDnnMinification_Ci) outcome was **FAILURE**
Summary: Building C:\TeamCity\buildAgent\work\3c67cf4b03e10bf\src\Engage.SafeDnnMinification.csproj failed with exitcode 1. Build time: 0:0:28


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (822 of 822 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.31%25-green.svg)


Sure.


Hello world !


sounds good to me

(save this for later:)
wondering if the red and green sections in that class method `+ (CGFloat) heightForMediaItem:(Media *)mediaItem width:(CGFloat)width` are correctly blocked out and what's going on there.


code smell: Feature envy class (extensive use of methods of another class)


This needs to be submitted via gerrithub.

Please see the updated CONTRIBUTING_HOWTO.txt

https://github.com/ffilz/nfs-ganesha/blob/next/src/CONTRIBUTING_HOWTO.txt


is there a spark way to avoid having to traverse this RDD twice: once for predicate `p` and once for `not p`?


Well this is pretty cool.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 728](https://teamcity.labkey.org/viewLog.html?buildId=274638&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **SUCCESS**
Summary: Tests passed: 9, muted: 34 Build time: 00:28:35


You are absolutely correct that this is the wrong way to "reset". Should use the ```change``` call.

You know you are correct that it shouldn't be needed. I missed the change call after event closed selection. But this should override the poly points.


@nicholasserra, can you shed some light into why we want to make sure that we have the blank fields appear in the extra_data?


updated the PR


maybe we don't need the template BTW...


fixes also #21


completed with:

`find . -path ./modules/prompt/external -prune -o -type f -print0 | xargs -0 sed -r -i 's/(^function )(\w+)\s\{/\2\(\) \{/g'`


yeah good call on this, I think the `::` approach is much more idiomatic


We should note that the host here is only internal to the docker instance, and cannot be used to contact the service remotely.


Since we need to transfer later then moving the transfer up seems like a good solution.
If the whole branch needs to be on the fast path, then yeah a profile would be needed.
But I assume this is called mostly in guards and so will be assigned on the first call so compiling the branch is not useful.


Encapsulation and Polymorphism not properly implemented


@pitr-ch please review


MaG21, it looks like you (or you guys) made a number of substantial changes. I don't think these ever came up as PR, or did I rudely ignore you at some point? There's a lot of useful functionality and great documentation in your changes...

OTOH, it seems to me that the string encoding issues we fixed aren't handled in your branch. Actually, tests are failing for any ruby in 1.9, 2.0, 2.1 and 2.2 ... (are you using 1.8?)

I think a good way moving forward would be to try to:

- find a consensus as to which ruby versions should be supported (in the release today, there's no 1.8 support)
- see if MaG21's changes are backward compatible and don't break QuickPay's code
- try to merge everything
- pass all tests (ideally add some :)

I can see TA's point in not wanting to do more work than necessary, but as there are some "competing" interests, I think the easiest thing to do is -- once we have a merged fork everyone can agree on -- create an organisation and give everyone interested access to that.


The "probably" was because I couldn't find where I copied this list from, not because I wasn't sure… anyway, updated the comment in commit fab20597


It was done to aid in some filtering stuff. This issue should shed some light https://github.com/SEED-platform/seed/issues/247


@flavour sync_job is for UI to work, as you suggested ;-)
I think repeats = row.repeat+1 works as intended. It sync right away (60 secs as given) when the alert is created


Yes, we can discuss that.  But given the apparent preference among the other developers for breaking things into small isolated commits, that change was not related to this one (especially since we would want to change that everywhere).


Minor: I know it would make things more verbose, but I wonder whether it might be clearer to make this `Hash` an optional named parameter i.e. `initial_state: {}` vs `**initial_state`. I found it a bit confusing coming back to these tests and reading the lines which call this `setup_states_for_question` method passing in the calculator.


change


Fine to merge, but I think making this its own checkAA() function, where we can simply return early instead of having repeated aaEnabled checks will be better in several ways.  (for future patch)


Yes you’re right. With a little reminder on using `expose` to do that.


@gitlsl 其实python只做核心登录 这种github上有非常多的python项目呢，如果其他一切都走http回调，那样岂不是又和现在的perl有类似的效果啦，所以我才没什么动力


:+1:   Sick.


Which public PLi Image using gst 1.x do you refer?


why is this necessary? Everywhere else you're adding `cursor` to calls to `finalizeInsert`, not `finalizeTree` (ugh, these names)


Thank you :)


Both way works to check the influence of the endgame score.
for S(20,0) it should be worse and for S(0,20) it should be better.
But from the view of passing a patch of course your variant is prefered!


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1360 of 1360 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'm still working this out, without a magic number :) CI is doing badly either way.


Please do not report issues in a code commit comment. Open a new issue...


Cool!


And need to declare props for ota
tesla.ota.version=$(shell date + %Y%m%d)


The aria-label needs to be localized as well. Fortunately it's easy, unfortunately you'll need to repeat it for every l10nId.

To localize an ariaLabel, you just need to add a key (for example) `message-lateness-seconds.ariaLabel`.

But... if you need an aria label, maybe it means that the image is not so decorative after all :) And that it would be better to add a real DOM element to hold both the image and the ariaLabel. Bonus point is: you'd need to add one more l10nId for the ariaLabel but that's all !


Thanks for changes!


done


Class names should normally use the CapWords convention.
PEP8 standards violated.


Wes gan. Sudah saya amankan wkwkw


check out


I have the following code my local and thought in my TIY-assignments online but I have to perform a Git Pull I think..
but here is my actual code I used to make the board populated with the proper name and color of each piece in its default position.

pawn=bp,wp
rook=br,wr
knight=bk,wk
bishop=bb,wb
queen=bQ,wQ
king=bK,wK

var board = initial();
applyMove: function(from, to){

}

[
["br","bk","bb","bQ","bK","bb","bk","br"]
["bp","bp","bp","bp","bp","bp","bp","bp"]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["wp","wp","wp","wp","wp","wp","wp","wp"]
["wr","wk","wb","wQ","wK","wb","wk","wr"]

]

[6, 4, 4, 4]

[
["br","bk","bb","bQ","bK","bb","bk","br"]
["bp","bp","bp","bp","bp","bp","bp","bp"]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["wp","wp","wp","wp","wp","wp","wp","wp"]
["wr","wk","wb","wQ","wK","wb","wk","wr"]

]
[
["br","bk","bb","bQ","bK","bb","bk","br"]
["bp","bp","bp","bp","bp","bp","bp","bp"]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["wp","wp","wp","wp","wp","wp","wp","wp"]
["wr","wk","wb","wQ","wK","wb","wk","wr"]

]
[
["br","bk","bb","bQ","bK","bb","bk","br"]
["bp","bp","bp","bp","bp","bp","bp","bp"]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["wp","wp","wp","wp","wp","wp","wp","wp"]
["wr","wk","wb","wQ","wK","wb","wk","wr"]

]
[
["br","bk","bb","bQ","bK","bb","bk","br"]
["bp","bp","bp","bp","bp","bp","bp","bp"]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["", "", "", "", "", "", "", ""]
["wp","wp","wp","wp","wp","wp","wp","wp"]
["wr","wk","wb","wQ","wK","wb","wk","wr"]

]


Hmm, I pulled this locally and it still worked.  Guess I thought I need it there as well; probably just a name mis-read.  I'll get that back out.

Looks like I'll be doing a bit of reordering and squashing for I make a pull request with any of these changes.


please try to follow the order and white space that is in https://github.com/necolas/idiomatic-css#declaration-order. No need to be really strict, the main requirement is to be readable, so you can use your common sense. Splitting the properties in different logical blocks helps reading the properties.


Please tab over the arguments to the function. Then leave the closing paren on the same level as the function call.
func(
    arg1,
    arg2,
)


socrata-curstor or curator?


The reason I have several iterations of this is b/c I figured that, I would have to use the same code to record a move and have it display in the view
So that move one would essentially be a link to a static board with pieces in the proper positions.


Whoops


Since these are regexes, to be pedantic, we should escape the dot so as to match an actual dot, not any character (i.e. \. instead of .)


Move this out into a config file.


I'd remove this one, unless we think QA will need it for some reason - this could expose some security risk, since people could arbitrarily decrypt values.


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1360 of 1360 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I realize this is somewhat late in coming since this has been in there since April, but ARM does have CPUID registers you can get this information from more directly than trying to process /proc/cpuinfo (might be portable on platforms other than Linux as well).  The MIDR is probably what you want to switch off of.  I'll look into providing a patch which uses these registers as opposed to the procfs parsing...


We're trying to make all `-Wall` and `-Wextra` happy for all the compilers out there: https://github.com/facebook/rocksdb/blob/master/Makefile#L167

Can you please send in a PR to fix this warning?


**no-undef**: "sinon" is not defined.


**no-undef**: "it" is not defined.


**no-unused-expressions**: Expected an assignment or function call and instead saw an expression.


**no-undef**: "expect" is not defined.


Tá show. Viu, pra testar se a lista tá vazia, pode usar o método isEmpty(). Concorda?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.628](http://teamcity.monogame.net/viewLog.html?buildId=10379&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


testing testing yessiree


> There are Boxes where ! box.isEmpty() && ! box.hasVolume() can be valid - a box where either min.x == max.x or min.y == max.y

Yes. And that's a useful case for Box3f or Box2f - it says "the box contains a single point". I can't think of a case where this is relevant for our image windows, which are about specifying a range of pixels in two dimensions.

> ImageAlgo::empty() is more like the inverse of box.hasVolume() at the moment, which is fine for my use here, but I think that there are places where a method called something like isNullBox() which returns true if min < max in any dimension would be good.

Can you elaborate as to what such a place might be? I have no problem rearranging things if we have good use cases, but right now I can't see any useful distinctions between the two cases.


That is an improvement, as it helps me to understand what the first element of the array is. But it doesn't explain what the number 15 itself expresses (or what the number 4 was in the earlier version).


Minor: Did you consciously not add any calculator integration tests (i.e. `test/integration/calculators/part_year_profit_calculator_test.rb`) in this commit? It seems slightly odd that there are scenarios in that test for when a business stops trading close to the award date, but none for when a business starts trading close to the award date. Perhaps they're not warranted, but it might at least be worth a passing comment in the commit note.


hah good catch


@rngtng This should be fixed in `0.4.3`


up  functinality not implemented.


Could be split into two methods :
```c++
void OutputFile::setupWrappingOptions( const ProfileLoader::Profile& profile )
{
	...
	catch( std::exception & e )
	{
		LOG_INFO( "OutputFile - option " << (*it).first <<  " will be saved to be called when beginWrap" )
		_profile[ (*it).first ] = (*it).second;
	}
    ...
}
```
```c++
void OutputFile::setupRemainingWrappingOptions()
{
	...
	catch( std::exception & e )
	{
		LOG_WARN( "OutputFile - can't set option " << (*it).first <<  " to " << (*it).second << ": " << e.what() )
	}
    ...
}
```


down functinality not implemented.


minus sign and bigger than inequality corrected


np man


left and right functions should be represented by 'a' and 'd' respectively,instead left and right arrows are used.


Note-1: **JointState::_defaultTranslation** is in the unscaled frame because it must be multiplied by **JointState::_unitScale**.


>because of privacy reasons
oh ... i was not thinking about that. but, definitely you're right.

>What about only updating the long/lat if updateAddress is true?
that's perfect.


Note-2: **JointState::setTranslation()** expects its input in the scaled frame because that is what **JointState::getDefaultTranslationInConstrainedFrame()** provides.


I really don't like such complicated selectors. Can you explain why you need it, and maybe we'll be able to find another way to do it ? :)


Note-3: **JointState::setTranslation()** expects the **translation** to be in the scaled frame and divides by **JointState::_unitScale** therefore **JointState::_translation** is obviously stored in the unscaled frame.


Note-4: **JointState::getTranslation()** returns a result result in the scaled frame (yes, **JointState::_translation** really is in unscaled frame).


Note-5: **JointState::translationIsDefault()** expects its argument in the scaled frame because that is what **JointState::getTranslation()** provides.


Note-6: There is a bug here: the **translation** argument is in the scaled frame but it is subsequently multiplied by **_unitScale**.  It should actually be *divided* by the scale to bring it into the unscaled frame which is the same frame as **JointState::_defaultTranslation**.


But if we're not doing schduled tasks with sync then no UI there needed


shouldn't t it be MultiFileCachingCompiler here?
Like it's said in the docs:  MultiFileCachingCompiler is for compilers whose files can depend on
each other.


I think it should be 1.5rem (and same for width/height later) because the smallest image is 15px.


did you mean getModuleName here? Did you test this PR?


score functionaity is not implemented


Did you test it doesn't not break Angular2-Meteor?


No, I was thinking about it in reference to https://github.com/pypa/virtualenv/issues/705 if it's solvable. I'm currently trying to polish up the existing codebase to at least solve some long-time issues while the rewrite hopefully moves forward.


Why do you take [1] if it's was [0] before?


this may be ok for syntactic errors, while it's too severe for semantic errors, for time being at least. For example, most people won't have declaration files for third-party libraries.
So lets keep `file.warn` if it exists or leave console.warn as before.


```c++
if( ! isValid && ! profile.empty() )
```


> okay... but at least with plugged charger + playing music will work without any issues ??

Yep, it seem to work properly now.


gotcha--thanks! I'll makes sure to keep that functionality then.


Try not to use "using namespace xxxx"

Might save time now, but incorrect library calls due to the implicit nature might pop out this way.

x years down the line some poor software guy will tear his own hair out trying to find where things might have been implicit and causing a bug.


组长：戈扬  学号1501210902
组员：曹轲  学号1501210875


Minor: Did you consider using nested contexts and shared setup to reduce the duplication in the setup blocks and shorten the names of the contexts? I think you might've told me that you did, so apologies if that's the case.


You can specify directly on the state which is the controller for it like this:
state('listDevices', {
			url: '/devices',
			templateUrl: 'modules/devices/views/list-devices.client.view.html',
                        controller: 'DevicesController'
		})


I'm still not sold on the use of flex here; that's why I asked Fang where the text should be. If it should be vertically aligned, then I think flex is good; but otherwise we can just use normal inline text IMO.


Donkey class is not implemented.


aaaa


quit functionality is not implemented.


i've just copy and paste this :+1: http://forum.kodi.tv/showthread.php?tid=142626&pid=2116306#pid2116306

it seems OK


lifes functinality not implemented.


Actually nevermind, I was going too fast and didn't read the instructions correctly.


:warning: MOV specific option !


score is not displayed


You can call initDeviceList() immediately after declaration.


#!/usr/bin/env node

'use strict';

var pg = require('../');

var argv = require('yargs')
	.usage('Usage: $0 [options] <message>')
	.describe('r', 'Specify the repository slug')
	.alias('r', 'repo')
	.describe('c', 'Specify the commit to comment on')
	.alias('c', 'commit')
	.describe('t', 'Specify a GitHub authorization token')
	.alias('t', 'token')
	.argv;

function makeComment(comment) {
	pg.comment(comment, {
		repo_slug: argv.r,
		commit_hash: argv.c,
		token: argv.t
	}, function (err) {
		if (err) console.error(JSON.stringify(err));
	});
}

var commentArg = argv._[0];
if (commentArg) {
	makeComment(comment);
} else {
	process.stdin.pipe(require('concat-stream')({
		encoding: 'string'
	}, makeComment));
}


too few comments


added more fun


Never _None_, because of options default values


Yep, told that to the guy asking me.


hi


I see, on the past, defconoi made all changes to system and all files
related. Then, he used 3.9y version but its the same as 3.10y. I will
upgrade to 3.10y and i will add changes from defconoi. If its go fine you
will can commit from me.


No classes, no modularity implemented, no encapsulation of data, in complete game


Done, thanks for the nudge.


Nice, thanks


encapsulation is not implemented(no private variables or protection modes ...).


Minor: I'm pretty sure we're no longer using this in the `PartYearProfitTaxCreditsCalculator`, so we _could_ remove it. However, I might be tempted to keep it around in case it's useful.


Player doesn't die, unable to close game


I think you've got me there. I was thinking that there was a case when we'd want to know where an edge of an image used to be, but that's just as invalid as one that has been defined as a properly 'null' box.


inheritance and polymorphism not implemented.


Hmm. Perhaps this should be `typeof window.console === 'object' && window.console.error` to avoid issues if console is unavailable which can be the case in some older browsers: http://caniuse.com/#search=console


Yes appmessenger is the wrong tool to use for running stuff off the ui thread, it'll run on the ui thread or calling thread depending on type of message.
I've been tinkering with a version of std::async that uses or jobmanager for these one off needs Paxxi@20743dc

Call it like KODI::UTILS::RunAsync([](){ dostuff... }); and capture any needed state.


`is` checks the identity of objects, ie their memory address


@todo


Take a moment to run the check-style script on your patches too, please.


I'll squash them as soon as we've finished with all comments.
On Sep 28, 2015 5:19 PM, "Tibor Benke" <notifications@github.com> wrote:

> Did you intend to include this in this commit?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/balabit/syslog-ng/commit/b265279d119d98e0f22bcf30840d763cf3355e43#commitcomment-13471471>
> .
>


The player cannot climb ladders even if implemented as the player contact with the ladder is only on right-half or left-half .


you replied below :D


Хэшбэнг принято ставить в тех файлах, которые мы запускаем. `utils.py` просто модуль, тут это необязательно.
Когда ты запускаешь `python mytodo.py`, то ты явно указываешь, что надо интерпретировать этот файл с помощью python. Для того чтобы хэшбэнг действительно имел смысл и чтобы можно было запустить программу просто как `путь/к/mytodo.py` (без python), файл должен быть исполняемым. О том как это сделать читай здесь: https://en.wikipedia.org/wiki/Chmod и `man chmod`.


it's a lollipop+ api

On 09/27/2015 10:47 AM, oaim wrote:
> This does not solve the issue on my Android 4.1.2. Why was this applied
> to lollipop+ devices?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/WhisperSystems/TextSecure/commit/cbcd53a8a048582500972a514e2f3b0f65c83fc7#commitcomment-13457776>.
>

--
http://www.thoughtcrime.org


what lol


Didn't even see that I left this here, woops! will change my API keys now.


Comme d'habitude en fait :p


No-instructions for the user whether to use arrow keys or a,s,w,d.


Didn't even see that I left this here, woops! will change my API keys now.
This can be deleted I suppose, as this is only for my local version.


lline too long.


Minor: It feels as if these constants have been named after their intended use i.e. their names closely match the questions in which they are used. I wonder whether we can come up with less-question-specific more-policy-specific names...?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.628](http://teamcity.monogame.net/viewLog.html?buildId=10379&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:19:18


Mono is throwing a nullref trying to access fields on my struct.


> Did you consider defining a new date format and using that instead of the gsub?

I've introduced the `:day_and_month` format for this purpose. You've made me realise that the `sub` should no longer be there, though. I've addressed that in a fixup commit.


Well. I think I just screwed this line up because it was too late. I will push the correct code in a minute.
`$success-color` is the name from the foundation variable so why not use it.


mmmm


mmm


Minor: With the rename of the class, I think the `TAX_CREDITS_` prefix on `TAX_CREDITS_AWARD_ENDS_EARLIEST_DATE` and `TAX_CREDITS_AWARD_ENDS_LATEST_DATE` feels a bit redundant, especially in the context of https://github.com/alphagov/smart-answers/commit/5477497fed5c651f4d244bb1fca7962ee1b60828#commitcomment-13473559.


@violetforest please keep line length short in these case studies.


Player able to move on the walls and through the walls ,
Gravity not present when player moves on walls but present when player moves through walls


Sure, but just curious-- is creating a list and then calling join better than just concatenating two strings?  E.g. '(%)' % family_name + _FONT_NAME_REGEX?


LGTM


completed with:
`find . -path *external* -prune -o -type f -print0 | xargs -0 sed -r -i 's/(function )(.*)\s\{/\2\(\) \{/g'`

closes https://github.com/Eriner/prezto/issues/2


Score and lives are not displayed to the user


Blank space left
PEP8 standards violated


these all fail, and every one of them is a false positive:  (I added the #3 to the output of this new test)

```
Testing: AFS, Kerberos AFS [DES 24/32 4K]... FAILED (should unify cases in split() and set FMT_SPLIT_UNIFIES_CASE (#3))
Testing: krb5-18, Kerberos 5 db etype 18 [PBKDF2-SHA1 32/32 AES]... FAILED (should unify cases in split() and set FMT_SPLIT_UNIFIES_CASE (#3))
Testing: cq, ClearQuest [CQWeb]... FAILED (should unify cases in split() and set FMT_SPLIT_UNIFIES_CASE (#3))
Testing: hdaa, HTTP Digest access authentication [MD5 32/32]... FAILED (should unify cases in split() and set FMT_SPLIT_UNIFIES_CASE (#3))
Testing: Blackberry-ES10 (101x) [SHA-512 32/32 OpenSSL]... FAILED (should unify cases in split() and set FMT_SPLIT_UNIFIES_CASE (#3))
Testing: LUKS [PBKDF2-SHA1 32/32]... FAILED (should unify cases in split() and set FMT_SPLIT_UNIFIES_CASE (#3))
Testing: MongoDB, system / network [MD5 32/32]... FAILED (should unify cases in split() and set FMT_SPLIT_UNIFIES_CASE (#3))
```


No comments written for the code to be understood


New features must have a corresponding set of unit tests in patchwork/tests.  If you want to generate test series for writing your tests, you can use either the mails in tests/mails or create series with https://github.com/dlespiau/patchwork/commit/daf812817c1a72444ede4bc47d7479834a1bd3d5


Blank lines left
PEP8 standards violated


Minor stuff: Here you are changing the state of the clicked button but there are 2 buttons, the user will still be able to submit through the other.(He probably won't, but he can).
I am making a change to this code and I will de-activate both buttons there.


I see how to get all records for one particular customer (say #1234). (http://server.com/api/customers/1234/)

Does the API allow for any way of using "OR" so that I could make one AJAX call and get records for two customers (say #1234 and #5678)?

I'm imagining something like http://server.com/api/customers/1234||5678/, but maybe there's a way to do this using your extends feature? (I don't really understand extends, that's why I'm asking)


bug in liives functionality. it's not working.
.


quit functionality is not working.


Thanks for your advice @AndyScherzinger,
I was fixing it when I received your mail.
Don't worry, Tranvis sends me an email when it fails and when the fail is fixed.


Player climbs the wall even he is not aligned correctly to the ladder and goes into the air sometimes by pressing the 'w' key


I would look at it form the other side, first there is lock around resolving a constant with autoload, then if it did not start autoloading yet it will lock and call require which has it's own lock around the path as you've mentioned.


I prefer to iterate 1 time only too \o


> I think it would be good to split them all up onto separate lines.

I've just done this in a subsequent commit.


The functions getPosition(), checkWall(), checkCollision() and collectCoin() are not present.


you are welcome


The logic in _buildQuery seems to solve some of the issue i had in my last push of #111.  Where is the test fix for non-watcher cases?


What browser, what script?

I tested this script and it works OK

```
navigate	http://www.bbc.co.uk/
execAndWait	document.querySelector('.orb-nav-news a').click();
```


de quien es el copyright ?


Pablo, when can u commit these to the main master? :) Thx in advance!


falta completar :)


code is hard coded.it displays same game board no matter how many times the game is played.same stair case positions.


Modularity  , Polymorphism , Encapsulation  are not implemented.


eliminar el _ inical y final


nie lepiej byłoby by:
"Ta akcja nie może zostać cofnięta" ?


la indentación no es correcta.


PLi-public is still on GST 0.1.
Thread about test & test-builds wit GST >0.1 is on http://forums.openpli.org/topic/29501-gstreamer-10/


por que anidaddas? es mas lindo si se declaran dos tipos y luegola interconeccion entre ellos. se entiende?


`contain_exactly` is not present on `rspec 2.6` and `expect` was introduced on `rspec 2.11` =/.
Maybe I can update the rspec. what you think?


I changed this to a container tag, but labeled it as Sound Recording box because it is in a separate location in a box that contains CDs from many different collections.  Let me know if there is something else that it should be labeled as.


Ohhhhhhhhh, stupid me :)


TeamCity Safe DNN Minification :: CI [Build 3](http://teamcity.engagesoftware.com/viewLog.html?buildId=375&buildTypeId=SafeDnnMinification_Ci) is now running


Insteaded of hardcoding values , variables could have been used.


level upgrading not implemented.


Hello there !!
https://github.com/inverse-inc/packetfence/blob/devel/lib/pf/constants.pm#L27


Hi sorry, i have a question, at then client.pp if you have an unique id you don't execute the agent-auth, how you can register the agent with the server?

thanks.


Good spot. I've just addressed this in a later commit.


after some testing i realize this isn't accurate. i don't really know how this is working, the negative axes always seem to be a bit (MAP_BLOCKSIZE, 16?) shorter than the positive


@lmr I lost the discussion regarding this assert. Why can't we add this into the `data_dir.get_tmp_dir` function? Plus why is it actually required? I always thought `tempdir` module always returns fresh directory, so the only problem might be when we use `data_dir.get_tmp_dir` multiple times and we should handle this in the `data_dir` module, rather than in the `test.py`.


maybe add some links to ci or dashboard?


TeamCity Safe DNN Minification :: CI [Build 3](http://teamcity.engagesoftware.com/viewLog.html?buildId=375&buildTypeId=SafeDnnMinification_Ci) outcome was **SUCCESS**
Summary: Running Build time: 0:1:40


line too long.


Fireballs are not present.


Why are we adding background images? I find they look busy without actually contributing much to the content...


Multiple levels not implemented.


Could consider swifting it up with `stackViewBounds.offsetBy(dx: 0, dy: -stackViewBounds.height)`


No line is left inside the function . Not following PEP8 standards.


Too many comments.


Comment should have started at the beginning of the line - PEP8


First and foremost, I can see images! Thanks.

Watching the logs it looks like the initialization of a single image (which is equivalent to toggling a single channel in OMERO.web) leads to ZxT TiffDelegateReader initializations.


Indentation contains tabs  - Doesnt comply with PEP8


This image is 1/2 MB! Would be very slow to download, and not very mobile friendly.


Not exactly what we need here. I don't think it should allow queuing more than a single UI user action. So actually those a synchronous calls on a separate thread without blocking the calling thread.


Kubernetes Services are backed by Endpoints, which are used to resolve the service name to an IP. For regular services, Kubernetes automatically creates the Endpoint, but for external services we have to create the Endpoint manually. It might be possible to assign a DNS name to our SQL server, but from the documentation, it looks like we have to use an IP: https://htmlpreview.github.io/?https://github.com/GoogleCloudPlatform/kubernetes/HEAD/docs/api-reference/definitions.html#_v1_endpointaddress


$default_pid or $admin_pid


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1360 of 1360 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.36%25-green.svg)


Too many blank lines
PEP8 standards violated.


Too many parameters.


it's  good way to write functionatlies using diff functions,instead of writing them under same function.


PEP8-Missing white space after ","


default !


Do not use alphabets as variables , code cannot be understood easily .


Code Smell - Line too long


With this change, the only 'known' bug is in @dynamic=  format.  There are about half a dozen false positive failures for a 2nd method of test (which I am not sure should be used). I do plan on making a 'generic' test to be run after the known-binary/known-salt tests which found so many issues recently.

I think this -test-full=0 should be used for the CI's. If (and until) @dynamic= gets properly fixed, we could simply white list it, so it does not fail for the CI's.


This sounds good.

Right now the upload-doc.sh script commits the docs to my [paholg.github.io](https://github.com/paholg/paholg.github.io) repo.

I assume that travis-cargo isn't doing that as I don't see anywhere that it's told to. Is there a way to make that happen?


https://github.com/SteveMcGregor/SoulMeet/wiki/RegistrationModel-JSON

It is a requirement of the domain. Which means it has to be committed when creating the account in the api.


Thanks, this ever work? Have they changed the JSON library at some point?


Shouldnot have hardcorded values.Should have used variables.


HELLO


@ildipo this is needed on Beaker side after deploying image resizing


PEP8 - Missing white space after ","


As the resolution of generation_time is in seconds, do we need to convert them to milliseconds?


You can now remove `cd ~/catkin_ws && ` at line 58


PEP8 - Missing white spaces around operators


Too many if , else conditions .Bad code smell.


Are you also going to change in db/pf-schema.sql?


All right, that makes sense then.


PEP8 - Missing white spaces after ","


Shouldn't this be called `ways`, `directions`, or something similar?


Code Smell - Line too long


Didn't implement modularity,inheritance,polymorphism,classes.


Something like [this](ad0483f54d831e213f613c3513bf83280c2532ff)?


Woops. Fair point. Thank you.


I don't have a test case at this point.  I'm probably not going to be the
one to fix the issue; I just checked in the small bit I had changed --
which in itself will need review, as I just copied over some boilerplate --
in a new branch that someone else can take over.

-- Dan.

On Sun, Sep 27, 2015 at 5:29 PM, Werner Dietl <notifications@github.com>
wrote:

> Do you have a test case for this change? If there already is one for Issue
> 478, you probably need to remove the skip-test annotation.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/typetools/checker-framework/commit/6cafa6f9a3ea507e910c4cfeb390f3168bbf78bf#commitcomment-13459788>
> .
>


PEP8 - Line too long


Can you elaborate exactly what problems you were having before you made this change?

I have seen problems where if I change stream URLs a few times (usually 4 or 5 times), it would not play audio any more.  I could try to stop/start/change streams as much as I wanted to after that, and it would not play any audio.


PEP8  - Indentation contains mixed spaces and tabs


Barbara Swanson asked for some background images to "help visually identify
the project". After a couple of back-and-forth emails, we agreed in the
attached mock-up. I'll check the image sizes.

On Mon, Sep 28, 2015 at 1:00 PM, Andrew Hankinson <notifications@github.com>
wrote:

> Why are we adding background images? I find they look busy without
> actually contributing much to the content...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DDMAL/cantus/commit/5aad3150453f0ced9f28619fe58982a2429b664f#commitcomment-13473893>
> .
>


Bad Code smell :  Alternative Classes with Different Interfaces.
They can be modified to share a common interface.


Shouldn't we log the exception here? In case, the collectd is not running etc, we will get to know.


should not use 2 keys for one direction .If you are not clear about what keys to be used then use any one key and write in readme.txt or another file don't represent in multiple keys


Yeah! You also can replace this old syntax by `${var}` syntax, I guess. But no worries. It is good to learn these things the hard way. You bet how hard it was to get started, with everything changed: Qt to Qt5, cmake 3 and all new variables, and lots of hidden but veeery important files like global.h.in (which are an extract, but not a copy of a Qt include file)... Took weeks to hear the first "eek" from the make files ;-)


PEP8 - Indentation contains mixed spaces and tabs


Advantage of using classes is not taken into consideration .


there is no wall.


I think this will be called before `this.state` is initialized in the constructor. Ditto for the other three below.


This one is the retry of the originally failed 2nd part, right?


Fixes #7


Updating the pf_version should be the last statement in the upgrade script


No new line at the end of the file


wtf

On Mon, Sep 28, 2015 at 9:31 AM, Rica Feng <notifications@github.com> wrote:

> np man
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dzhan008/cheshiregame/commit/81ac88c4d7652e1ac078bfaad312a26cb67bd187#commitcomment-13473175>
> .
>


LGTM! Thanks for writing tests. :D


Large code , should have been broken down into smaller functions.


I'm -1 on adding an option to save the Figure to a file.
It just saves the user a little typing and adds complexity to the astroplan API.
Having the `savefig` call as an extra line is also consistent with every plotting function in matplotib itself.


polymorphism,encapsulation,modularity not imlemented.


I see, sounds like a good recipe for deadlocks :smile:


No newline at the end of file


The functions checkWall(), checkCollision() and collectCoin() are not present.


`zipWithIndex` is very very slow to use in this method, which will be called for every row.


best. commit. message. ever. :laughing:


Yep


Can those two be defined as class member variables?


line too long


I also had this problem. I wasn't entirely sure why. I did a little online research and it suggested removing the "float" or just adding more padding to the paragraphs, but none of that really worked for me.  I'm playing with the z-index right now which specifies the stack order and I'm hoping maybe I'm onto something.


Done here: b0fdd54


Don't use a `Seq` here.  If you have a million rows, you will easily run out of memory.


Done here 47e4a3c


..

On Mon, Sep 28, 2015 at 9:31 AM, Rica Feng <notifications@github.com> wrote:

> np man
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dzhan008/cheshiregame/commit/81ac88c4d7652e1ac078bfaad312a26cb67bd187#commitcomment-13473175>
> .
>


You make an interesting point. I want to place mine side by side, but I'm struggling with overlap so I've made them simply on top of each other for now while I work out the issue. You make a good point about how placing them side by side places them on a level of equal importance.


Done here 1862850


Done here b8f6e9f


Player movement not properly constrained.


Just checking here that we're returning the base fee value in FeeUnits.  Assuming that's correct, if we were to return the value in drops (FeeUnits are currently 1:1 with drops, right?) then we could use Nik's `XRPAmount` as the return type.  That would make the returned `pair` clearer and less error prone.  What is the likelihood that the base fee unit will diverge from drops?

This was really just a point to ponder, not a request for a change in the pull request.


Should have used variables instead of hardcoding values.


q -> quit not implemented
when user presses q the program does not exit


game board is hard coded.always displays same  gameboard.no matter how many times game is played.


Yes, exactly. I assume you plan to do something with the long lines...


Its better to write a readme . Because the player dont even know what file to run inorder to launch the file.


Hmmm....  I'm surprised the key signature compiles.... and is kind of ugly  :-p

A more type safe solution would be to have a method which can detect the sort column type and call scanSegments all in one, thus the type specific code is just all in one place.   Open to ideas though.


Bug in player's initializing position after loosing a life.


Hmm, I'm not 100% sure. It's possible that I didn't add them because I didn't think the changes to the `PartYearProfitCalculator` warranted their addition, or possibly because I was happy enough that I knew how the calculator was working by this stage and didn't feel as though I needed them.


@TimGoulain J'ai essayé en local, j'ai pas le soucis. Essaie ça sinon :
http://stackoverflow.com/questions/26634545/how-to-debug-asset-prompiling-syntax-errors

Si ça coince toujours poste ici la totalité de l'output du push sur Heroku, on regardera ce qu'il dit.


This would discard links to different resources that have the same rel.


son constantes o variables?


looks great! I'll push it out


That's interesting (and great) that you were able to recall you knowledge of CSS without too many problems. I also used examples, but I turned towards the internet to find them. I think that learning a programming language is like learning a verbal lanaguage--I always learned Spanish and Italian better from watching movies and reading books in those languages. Similarly, I think I gained a better understanding of CSS from looking at examples of code and seeing how they translate into a set page.


In Readme its better if you also include details like pre-requisites required to run the game it will be better. For example installing pygame in this case


falto el All rights reseved.


I don't think save radar should be in common, it is not that central. But that doesn't change my point/question, in it is less about where code is written and more about the functionality it self.


es unpntero o un puntero a puntero? creo sobra un * y el const me parece vadel otro lado no? o de aambos lados. pero el que esta en realidad sedefine cunadose defin la variable.


when setting dimensions please all users in view  . because when your code is run on my machine i cant even see player . so put minimal dimensions or better use fullscreen option


What if verification constantly fails for a set of `Dataset`s and `shouldGiveUpVerification()` is `false`?


Player position is hard coded. Instead of that you could declare variable and use it globally which enhances re-usability  of code.


I did this as well at first. I understood the concept of a style tag much better than I understood a style sheet and the biography website seemed simple enough to function with just the tag.


en la definicion de una constante hay que si o si inicializarla, sino ya no se puede... :(


k


I think this merge is superfluous?


no seria mejor un array en vez de 3 definiciones?


Pep8 standards not followed while naming classes https://www.python.org/dev/peps/pep-0008/#class-names
 >Class Names

>>Class names should normally use the CapWords convention.
>>The naming convention for functions may be used instead in cases where the interface is documented and used primarily as a callable.


Too many blank lines unnecessarily used


I think this should be `dataset.state() != COMPLETED`.


esta parte del codig corresponde a internal dta def. por ende me parece l macro debe ir en la parte de macros arriba.


Good names given to modules. They reflect module's functionality .
Also followed pep8 standards in most of the cases


This is a great observation that I actually didn't notice. I think colors and typographical formatting are so crucial for understanding a page's organizational methods and conveying the overall message of the page. I'm surprised pure.css doesn't offer these features. If I created a page with a bright pink background and a comic sans font, it's going to have a different impact than a white background and times new roman.


player is moving even if there is no floor.


I tested it out with two historicals, one serving two segments and the other serving three without any replication between them, ran a query that hit both historicals, and didn't see any issues with the results as far as I can tell.

There's still a weird hack on line 187 of GroupByQueryQueryToolChest.java that I had to do to get outer queries on inner post aggregations to work right, but it doesn't seem to affect the results either.

For reference, here's the dataset, super contrived query, and results. I got the same results for both implementations:

Dataset
```
Timestamp				page	language	added
2013-08-31T01:02:33Z	Page1	en			10
2013-08-31T01:02:34Z	Page2	en			20
2013-08-31T01:03:35Z	Page1	en			0
2013-08-31T01:03:36Z	Page3	ja			11
2013-08-31T01:04:37Z	Page3	en			1335
2013-08-31T01:04:38Z	Page3	en			100
2013-08-31T01:08:38Z	Page2	en			0
2013-08-31T01:08:39Z	Page4	fr			560
2013-08-31T01:09:40Z	Page1	fr			123
2013-08-31T01:09:41Z	Page1	en			1337
```
Query
```
{
  "queryType": "groupBy",
  "dataSource": {
    "type": "query",
    "query": {
      "queryType": "groupBy",
      "dataSource": "wikipedia-canned",
      "granularity": "all",
      "dimensions": [
        "language",
        "page"
      ],
      "aggregations": [
        {
          "type": "longSum",
          "fieldName": "count",
          "name": "edit_count_inner_1"
        },
        {
          "type": "doubleSum",
          "fieldName": "added",
          "name": "added_inner_1"
        },
        {
          "type": "javascript",
          "name": "js_inner1",
          "fieldNames": [
            "count"
          ],
          "fnAggregate": "function(current, v) { return current + 2*v; } ",
          "fnCombine": "function(partialA, partialB) { return partialA + partialB; }",
          "fnReset": "function() { return 0; }"
        }
      ],
      "postAggregations": [
        {
          "type": "arithmetic",
          "name": "post_agg",
          "fn": "+",
          "fields": [
            {
              "type": "constant",
              "name": "myConstant",
              "value": 1
            },
            {
              "type": "fieldAccess",
              "name": "edit_count_inner_1",
              "fieldName": "edit_count_inner_1"
            }
          ]
        }
      ],
      "intervals": [
        "2012-01-01T00:00:00.000\/2020-01-03T00:00:00.000"
      ]
    }
  },
  "granularity": "hour",
  "dimensions": [
    "language"
  ],
  "aggregations": [
    {
      "type": "longSum",
      "fieldName": "edit_count_inner_1",
      "name": "edit_count_outer_1"
    },
    {
      "type": "longSum",
      "fieldName": "js_inner1",
      "name": "edit_count_outer_2"
    },
    {
      "type": "longSum",
      "fieldName": "added_inner_1",
      "name": "added_outer_1"
    },
    {
      "type": "longSum",
      "fieldName": "post_agg",
      "name": "postAgg_outer"
    },
    {
      "type": "javascript",
      "name": "js_outer_1",
      "fieldNames": [
        "post_agg",
        "edit_count_inner_1"
      ],
      "fnAggregate": "function(current, v,v2) { return current + v+v2; } ",
      "fnCombine": "function(partialA, partialB) { return partialA + partialB; }",
      "fnReset": "function() { return 0; }"
    },
    {
      "type": "javascript",
      "name": "js_outer_2",
      "fieldNames": [
        "post_agg"
      ],
      "fnAggregate": "function(current, v) { return current + 2*v; } ",
      "fnCombine": "function(partialA, partialB) { return partialA + partialB; }",
      "fnReset": "function() { return 0; }"
    }
  ],
  "intervals": [
    "2012-01-01T00:00:00.000\/2020-01-03T00:00:00.000"
  ]
}
```
Results
```
[ {
  "version" : "v1",
  "timestamp" : "2012-01-01T07:00:00.000Z",
  "event" : {
    "edit_count_outer_1" : 7,
    "js_outer_1" : 17.0,
    "edit_count_outer_2" : 14,
    "language" : "en",
    "postAgg_outer" : 10,
    "js_outer_2" : 20.0,
    "added_outer_1" : 2802
  }
}, {
  "version" : "v1",
  "timestamp" : "2012-01-01T07:00:00.000Z",
  "event" : {
    "edit_count_outer_1" : 2,
    "js_outer_1" : 6.0,
    "edit_count_outer_2" : 4,
    "language" : "fr",
    "postAgg_outer" : 4,
    "js_outer_2" : 8.0,
    "added_outer_1" : 683
  }
}, {
  "version" : "v1",
  "timestamp" : "2012-01-01T07:00:00.000Z",
  "event" : {
    "edit_count_outer_1" : 1,
    "js_outer_1" : 3.0,
    "edit_count_outer_2" : 2,
    "language" : "ja",
    "postAgg_outer" : 2,
    "js_outer_2" : 4.0,
    "added_outer_1" : 16
  }
} ]
```


Neither am I. Some wrapper in the runtime is probably not necessary. XInitThreads only needs to be called before any other Xlib function; so we might be able to move it into main(). If you want to investigate this further, please do. Any changes would be a separate issue (PR) anyway. The original PR for this is https://github.com/gnuradio/gnuradio/pull/332


Should be `__name="netmhc"`. Methods are identified via `__name`and `__version`


Interesting history--I didn't know that.


not compiled with alfa5: http://paste2.org/g7ktUJha


mejor que la variable se defina una sola vez yel conteido tenga #if, se entiende?


The game doesnot work.


no hay que usar numeros magicos, mejor usar un macro.


player can even move inside the floor basement.


You can use `shouldGiveUpVerification`.


This is maintenance branch material at least 5.2 and 5.3


C string literals are already null terminated, you shouldn't need `\0` at the end.


========== Build: 12 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========


Is this a reason for the test to fail?
```
--- FAIL: TestExecAdmit (0.00s)
	scc_exec_test.go:116: attach check: sa name should have been cleared: default
	scc_exec_test.go:116: exec check: sa name should have been cleared: default
FAIL
FAIL	github.com/openshift/origin/pkg/security/admission	0.017s
```


I would consider calling `fflush(stderr)` here


You obviously are pretty familiar with CSS and HTML. I like how  you interpret a framework, it helps me to gain more definition around what exactly pure.css and bootstrap truly are.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.491.4e0a3268d14a2bc8742d43d4b65abc7084cd76f0](http://build.palaso.org/viewLog.html?buildId=63837&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3357, ignored: 134 Build time: 00:07:12


device ya es un putero, me parece sobra el &, no?


Modularity,inhertance,encapsulation not used.


Done


classes not used.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.511.4e0a3268d14a2bc8742d43d4b65abc7084cd76f0](http://build.palaso.org/viewLog.html?buildId=63838&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3318, ignored: 140 Build time: 00:07:24


WOW! Great job so far! I'm really impressed! Thank you for so greatly improving the structure of this project. :+1:


> Is this a reason for the test to fail?

The testclient is bugged.  I'm getting patch ready for kube and for us.


I think it's better to let this method returns a `boolean` indicating if there's any throwables and let the caller decide what to do if it returns `true`.


Too much hardcoding.


Haha, jetzt wo dus sagst...


Many of the values are tested using hard coded. like if i change the dimensions you pass to constructor to Board class. your code gives me an error. Instead of using integers like that use laterals and use them every where  or add them as variables in your board class


Better remove this line if not needed.


Seems the try clause has nothing to do with this `closer`.


player climbing the ladder is not implemented.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 729](https://teamcity.labkey.org/viewLog.html?buildId=274661&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **SUCCESS**
Summary: Tests passed: 9, muted: 34 Build time: 00:25:29


Basic functionalities like jump,fireballs not implemented.


This is exactly the reason why I wrote this FIXME. So, where do we get dev string from? Command line? Are we assuming there can exist many devices for a single volume?

AFAIK it's wrong to have a few (identical) devices for a single volume, so volume:device is 1:1 mapping, and therefore we don't need to ask user for both volume AND device, and let them specify either one.


It’s actually tested with version 2.8, not version 2.4. I must have wrongly labeled it. So I guess the parse_external_result might not work now for version 2.8 ?!?


We seem to have lost this qualifier handling in the new version.


No problem. Let's assume you've called ->attach two times. Now you call detach. What's the way to find out (e.g. for ploop) how may times it was attached?


When the user presses the close button the game displays that the user has won which must not be displayed as the user wanted to exit the game without waiting for loss or win.


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1360 of 1360 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Не корректно отображались соц. кнопки хидера в IE8, решил попробовать увеличить расстояние в спрайтшите, а оказалось что маштаб в IE8 стоял равный 95%. В общем ложная тревога. ))


PEP8 - Multiple imports in one line


PEP8 - Indentation contains mixed spaces and tabs


This sounds great!


Multiple bad white spaces


Fantastic!


No new line at the end of file