@Brit200313 things are much neater now. Form validations are good. I handed making sure a PersonalEvent couldn't be before the Person it belonged to was born. Because it involved two different models, I ended up creating a custom validator;

```
class PersonalEventValidator < ActiveModel::Validator
   def validate(record)
     if record.starting.nil? || record.person.born > record.starting
       record.errors[:base] << "This date is before this person was born."
     end
   end
end
```

Coverage is at 77%. I'm not sure how much more I'll get done tonight; if you're itching to merge this branch, go for it!


I just uploaded skeleton to server, than launched php composer.phar instal
through ssh in the folder.
But actually you may have a point - can still be my fault, I have php5.5
outside this folder, so the composer somehow thought it IS 5.5, obviously.

2015-09-28 5:33 GMT+03:00 Ярослав Склабинский <jokersoft.net@gmail.com>:

> I dunno, It could be some strange issue of my strange provider likely...
>
> 2015-09-28 5:30 GMT+03:00 Ярослав Склабинский <jokersoft.net@gmail.com>:
>
>> That what I'm saying)
>> (was trying to say:))
>>
>> 2015-09-28 5:29 GMT+03:00 Marco Pivetta <notifications@github.com>:
>>
>>> @Jokersoft <https://github.com/Jokersoft> that seems weird: it should
>>> simply refuse to install, given that composer.json requires 5.5 or
>>> more...
>>>
>>> —
>>> Reply to this email directly or view it on GitHub
>>> <https://github.com/zendframework/ZendSkeletonApplication/commit/6ba430f6a2006d9f37c24b039fda3488e8681c91#commitcomment-13460315>
>>> .
>>>
>>
>>
>


wrong branch in this url


You shouldn't have a `header` inside a `header` it's not valid `html`.  Look on line 16 you've opened a `header` tag and you are still in there as a child.  It seems like it's just a mistake as you have no content in there.


High Cyclomatic complexity


My system setup provides a warning:

    warning: LF will be replaced by CRLF in t1.txt.
    The file will have its original line endings in your working directory.


@skurfer just this one I think. Since `URLWithString:` can return `nil`, the check is probably worth it.


Should the `header and `footer` not be children of the `section` and have the `div` with the content nestled in between them?


The loop has very high Cyclomatic complexity


What is `style2` going to be?  Could it not be named better?


All list items `li` must be contained in either a `ul` or an `ol`, unordered or ordered.


yes. PHP CLI same
OK, sorry for disturbance and thanx for dialogue
But i gotta go sleep few hours.

2015-09-28 5:43 GMT+03:00 Ярослав Склабинский <jokersoft.net@gmail.com>:

> I just uploaded skeleton to server, than launched php composer.phar instal
> through ssh in the folder.
> But actually you may have a point - can still be my fault, I have php5.5
> outside this folder, so the composer somehow thought it IS 5.5, obviously.
>
>
> 2015-09-28 5:33 GMT+03:00 Ярослав Склабинский <jokersoft.net@gmail.com>:
>
>> I dunno, It could be some strange issue of my strange provider likely...
>>
>> 2015-09-28 5:30 GMT+03:00 Ярослав Склабинский <jokersoft.net@gmail.com>:
>>
>>> That what I'm saying)
>>> (was trying to say:))
>>>
>>> 2015-09-28 5:29 GMT+03:00 Marco Pivetta <notifications@github.com>:
>>>
>>>> @Jokersoft <https://github.com/Jokersoft> that seems weird: it should
>>>> simply refuse to install, given that composer.json requires 5.5 or
>>>> more...
>>>>
>>>> —
>>>> Reply to this email directly or view it on GitHub
>>>> <https://github.com/zendframework/ZendSkeletonApplication/commit/6ba430f6a2006d9f37c24b039fda3488e8681c91#commitcomment-13460315>
>>>> .
>>>>
>>>
>>>
>>
>


The code should be made more modular like the file state.py is excessively large. It should be split into multiple files.


actually have no clue where this change comes from; some weirdness in Bibtex name parsing?


using System;
using System.Collections.Generic;
using System.Linq;
using Microsoft.Xna.Framework;
using Microsoft.Xna.Framework.Audio;
using Microsoft.Xna.Framework.Content;
using Microsoft.Xna.Framework.GamerServices;
using Microsoft.Xna.Framework.Graphics;
using Microsoft.Xna.Framework.Input;
using Microsoft.Xna.Framework.Media;

namespace WindowsGame1
{
    /// <summary>
    /// This is the main type for your game
    /// </summary>
    public class Game1 : Microsoft.Xna.Framework.Game
    {
        GraphicsDeviceManager graphics;
        SpriteBatch spriteBatch;
        Texture2D obstacle;
        Rectangle obstaclerect;

        private AnimatedTexture SpriteTexture;
        private const float Rotation = 0;
        private const float Scale = 1.0f;
        private const float Depth = 0.0f;
        //endo of animation declarations
        Vector2 Pos = new Vector2(250, 200);

        public Game1()
        {
            graphics = new GraphicsDeviceManager(this);
            Content.RootDirectory = "Content";

            // create the particle systems and add them to the components list.
            // we should never see more than one explosion at once
            SpriteTexture = new AnimatedTexture(Vector2.Zero, Rotation, Scale, Depth);
        }

        /// <summary>
        /// Allows the game to perform any initialization it needs to before starting to run.
        /// This is where it can query for any required services and load any non-graphic
        /// related content.  Calling base.Initialize will enumerate through any components
        /// and initialize them as well.
        /// </summary>
        protected override void Initialize()
        {
            // TODO: Add your initialization logic here

            base.Initialize();
        }

        /// <summary>
        /// LoadContent will be called once per game and is the place to load
        /// all of your content.
        /// </summary>
        protected override void LoadContent()
        {
            // Create a new SpriteBatch, which can be used to draw textures.
            spriteBatch = new SpriteBatch(GraphicsDevice);

            // TODO: use this.Content to load your game content here
            obstacle = Content.Load<Texture2D>("Sprites\\obstacle");
            obstaclerect = new Rectangle((int)Pos.X, (int)Pos.Y, (int)obstacle.Width, (int)obstacle.Height);

            // end of loading content for title page

            //load animation content
            SpriteTexture.Load(Content, "Run", 10, 10);
            //end of loading animation content

        }

        /// <summary>
        /// UnloadContent will be called once per game and is the place to unload
        /// all content.
        /// </summary>
        protected override void UnloadContent()
        {
            // TODO: Unload any non ContentManager content here
        }

        /// <summary>
        /// Allows the game to run logic such as updating the world,
        /// checking for collisions, gathering input, and playing audio.
        /// </summary>
        /// <param name="gameTime">Provides a snapshot of timing values.</param>
        protected override void Update(GameTime gameTime)
        {
            // Allows the game to exit
            if(GamePad.GetState(PlayerIndex.One).Buttons.Back == ButtonState.Pressed)
                this.Exit();
            float elapsed = (float)gameTime.ElapsedGameTime.TotalSeconds;
            //add gameState switch for title screen and game play screen
            SpriteTexture.UpdateFrame(elapsed);
            SpriteTexture.position.X -= 1;
            if (obstaclerect.Intersects(SpriteTexture.rect))
                SpriteTexture.position.Y -= 1;
            else if (SpriteTexture.position.X < 0)
                SpriteTexture.position.X = GraphicsDevice.Viewport.Width;
            else
                SpriteTexture.position.Y += 0.1f;
            base.Update(gameTime);
        }

        /// <summary>
        /// This is called when the game should draw itself.
        /// </summary>
        /// <param name="gameTime">Provides a snapshot of timing values.</param>
        protected override void Draw(GameTime gameTime)
        {
            GraphicsDevice.Clear(Color.White);

            // TODO: Add your drawing code here
            spriteBatch.Begin();
            spriteBatch.Draw(obstacle, Pos,
                Color.White);
            SpriteTexture.DrawFrame(spriteBatch);
            spriteBatch.End();

            base.Draw(gameTime);
        }

    }
}


using the just year date on purpose; The full publication date has the problem also noted for RSC that January articles appear with the preceding year.


Thanks


The while loop has a high Cyclomatic complexity.


Does this compile? What is "normal"? This should be UIControlStateNormal


same here


Very good!


Code Smell : Constant class


I'm confused, isn't the parenthetical removed in this change?


should incorporate  `git config core.autocrlf true` or something look at http://stackoverflow.com/questions/17628305/windows-git-warning-lf-will-be-replaced-by-crlf-is-that-warning-tail-backwar#


uh oh, looks like he's doing it again


I like the color name :dancer:


Ah, right.


A newline is expected after the end of the file.


The loop has high Cyclomatic complexity


Referring back to that numbered list,

All of the keys in the destructuring assignment are direclty children of the react-router object and don't pull from each other... turned out that first key in the destructuring assignment being undefined happened because there wasn't a "Router" property of the react-router object.

I also learned that you can alias those keys by using a colon as in this example:

var foo = { bar: 'pony', baz: 3 }

var {bar: a, baz: b} = foo

console.log(a) // 'pony'
console.log(b) // 3


Use the following command to remove tracking for the credentials after initially committing a blank file.
```bash
git update-index --assume-unchanged app/src/main/res/values/private.xml
```


Code Smell : Long method


Code Smell : God Class


OK. Can you file an issue to track?


Hm...

The problem's that it's not showing the fonts as I'd like them to: see, e.g. https://github.com/fredhutchio/intro-bioinformatics/blob/gh-pages/public/css/hyde.css#L254 .


If a change to the private.xml file is needed.
```bash
git update-index --no-assume-unchanged app/src/main/res/values/private.xml
```
**Remember to remove the credentials before the commit!**
Then use the command from the previous comment again, after commit the new additions/changes.


The doc-upload does exactly that.


Board Generation code should be placed in separate file.


Зачем ссылки на эти библиотеки? Это зависимости плагина NooLite, а API-плагин про них ничего не должен знать. Если хочется, чтобы в коде не было сравнения с "волшебной" цифрой (cmd == 6), то лучше сделать константу `int CMD_SET_BRIGHTNESS = 6` и сравнивать с ней.


Bad Funtionality: Not implemented game functionality, Too many glitches when playing the game (should be refactored for better code understanding and functionality)


Не вижу в описании функции намёков на необязятельность, проверить сейчас сразу не могу, ибо сижу в другой ветви.
public void SendCommand(int command, int channel, int level)


This is a link to documentation that was removed to http://www.marlinfirmware.org back in May.

We need to decide just WHERE such documentation is going to reside and make all references go to the same (and current) spot.


:shipit:


Class has no __init__ method (no-init)


:+1: :heart: :bow:


For commits like this, in the future I'd recommend doing them as `git commit --author "Ron Rock <email>" -m "Copy OSXnative.jl from Images"`. See, e.g., https://github.com/JuliaIO/AndorSIF.jl/commit/2b2b550d0a91927265717b59c92c558db87affd6


un const en un typedef solo sirve para no evitar escribir desde el codigo, es la idea?


Reviewers

@kcwire @beyelerb @millerw8 @kcwire is hero


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (822 of 822 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.31%25-green.svg)


es mas prolijo hacer la declaracion del tipo y luego usarlo... osea definir el tipo de funcion de este tipo


So in that case I should read up on `qmake`'s command line options, because I wasn't aware of that!


The Apache client is a fallback if the async http client is not compatible. I would use the default http client since it is faster and better tested.


BTW, have you guys ever considered moving away to CMake to something else? Maybe Boost.Build, Fbuild, or Waf?

Just checking. :)


It worked for me, but i had to add a new "if" block so it only unbids when there is a data-url attribute in the anchor.

The data-url and the data-ajax attributes are present when i use @Ajax.ActionLink command.

But thanks a lot for the solution !!


Bad Functionality: When player jumps from the corner then it starts from bottom of the floor (should be implemented properly)


Can this be project specific? I have a lot sphere apps and a global setting can cause trouble.


Code Smell: Too much Hardcoding (should be avoided for code uniformity)


este archivo le falta todo para tener el formato del firmware :(


Thanks @joeferraro for this great tool !


этот `switch` из двух вариантов можно заменить на `if`


`rabietmqctl` is probably a typo. As may be `RABBITMQ_RABBITMQCTL_PATHen`?


...I probably shouldn't be putting all of the `card`s into one `.row` div, should I?


Cool. Didn't know you could use $Configuration$ in .nuspecs
:+1:


Why should Enricher be responsible for doing this?. Wouldn't the same problem appear in any other component that allows a non blocking MP?. Seems to me that this should be done by the component that knows that is starting to process the response provided by a different thread.


Thanks! Sorry for this, I'm amazingly illiterate with Github...I'm slowly picking up the tricks, so there is hope :)


Missing module docstring (missing-docstring)


Ok.
Keep in mind that cw-7, with a residual of 7.348 contributed a net of 80+ wins.


Different number of spaces. Wrong indentation


Вообще, у меня есть мысли оставить тот enum, но пока для него нет подходящего места, так как эти названия команд могут быть общими для проекта - значит, они не могут быть ни в api, ни в плагине-драйвере.
А пока я считаю подобную зависимость допустимой, так как api сейчас всё равно железно зависит от плагина noolite, а он железно зависит от этих либ. А иметь несколько версий плагина NooLite для разного железа - маразм, так что мы зависим от единственной версии плагина, зависящего от единственной либы.


listview till lager, lagerhanteringsalternativ till menubar, egen aktivitet till lagerhantering


Bug: Player keep on playing even after strike with donkey and fire balls are not shown


I think this is not ideomatic, either you create a blocking sphere client that wraps your `.toCompletableFuture().join()` calls or you use it asynchronously.


Redefining built-in 'next' (redefined-builtin)


@aniket11bh @kshitijgoel007

Position estimator doesn't really require any other dependency.

Can you please verify?


Does the couchbase java-client generally work across different versions of couchbase server? Just wanted to when we'll need to upgrade the client, and which versions would be supported.


Just in an effort to simplify the plugin, took it a little too far, I am going to re-add cached and buffers most likely to the default mix


I will now have to look in Star Story if the Boundaries work the way they should (as requested in #16).
Of course, this is the same as checking if the lamp in the fridge goes off when you close the door (even harder), so I will never fully know if this works, unless errors or bugs pop up.
If they don't pop up I will close issue #16 until I have strong reasons to believe the boundaries do not work the way they should.


Hardcoded layout should be kept in separate file, to make code easier to read and debug.


Did you look into mocking the HTTP requests to SJS?


It is better to remove the article 'the'. You don't say "Defeat the Gesti" or "Defeat the Poata". They're unique entities, so it's considered a proper noun.


vim these days?


> This fails to even bind.

Agreed, `@MapKeyEnumerated` should not be there. I don't see an error during binding about this, though. The test proceeds and executes the query.

> Please show me a complete listing that reproduces this problem

That's what the changes in `testMapKeyExpressionInSelect()` are meant for. It fails with a `ClassCastException` on line 77, because the result list contains `Address` objects instead of `AddressType` objects. Also the logged SQL shows a join to the address table and not address type.


I made both :3


unused-wildcard-import


Nope, there are debhelper tools for CMake, which I use for packaging.
Additionally before moving to something else we should focus getting
PySide2 working. I won't be a good help on this task so I do the minimum
providing everything in Debian packages to give interested developers a
kickstart.
If you like you can work on this ;)


Is this considered safe? As opposed to using dangerouslySetInnerHTML?


Vale, entonces nos vemos el jueves. Y menos mal que me has avisado, es que no estoy muy pendiente de los eventos y seguro que habría ido el miércoles jaja.


Yes I did.  The problem is that the stuff that needs to be mocked lives in a different module than the actual tests.  This seemed like the simplest change that I could make.


mixed-indentation


Are you planning on doing this before merging? I think we are still caching the census on the client-side from the analyze endpoint, and sending it along to the model.


Huh.  It looks like you're using name hiding to accomplish compile-time polymorphism.  There are two `static calculateBaseFee(PreclaimContext const&)` methods that hide the `static` implementation in `Transactor`.  That's fine (as long as we don't get compiler warnings about name hiding).  But it might be worth a comment about the technique you're using.  I think it's the first time I've seen it in production code.


Method could be a function (no-self-use)


This'll need a license header.


Ditto for license header.


second commit


None missing, right?


Super minor obviously, but thought I might as well let you know about this as I noticed it when getting prspec set up.

Thanks for the gem!


Same again, re: license header.


On changing screen height, queen might come out of cage. Value should be relative with respect to screen height.


Fixed with commit https://github.com/LibreCAD/LibreCAD/commit/3b7462be1506534b1d93a63ff4237119002433fa
Maybe we have to adjust `#if QT_VERSION >= 0x050000` if needed, I found no reference, when it was introduced.
The previous enum, `QKeySequence::Quit` is available in Qt 4.8 and the next one, `QKeySequence::Deselect` was introduced in Qt 5.1, so I'm confident that it will work


I'm doing it!  I'm doing it, Simon!

     On Sunday, September 27, 2015 5:18 PM, Simon Smith <notifications@github.com> wrote:

 I'm so proud!—
Reply to this email directly or view it on GitHub.


hello


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 730](https://teamcity.labkey.org/viewLog.html?buildId=274709&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **SUCCESS**
Summary: Tests passed: 9, muted: 34 Build time: 00:25:53


:facepalm: thanks


@vanthome `insertRule` are removed by this commit. My curiosity is about `edit: { isEdit: true },`


I am not a nodejs person but why such a huge jump. What is gained by moving to 4.1.1? I am a bit ignorant on this.


Should we set a custom retry time and max retry amount?

@mmcfarland Any opinion on what our max waiting time for a model should be?


Зачем она нужна. Убрать


Для группировки кнопок используй [класс](http://getbootstrap.com/components/#btn-groups-single) `btn-group` из bootstrap. Класс `nooui-widget` нужно удалить, т.к. он содержит общие стили виджета - они должны находиться в плагине WebUI и распространяться на все виджеты.


Player wins the game without even touching the queen


No it seems like a bit of a job, because I do not already understand how all of that works.  All of the censuses are now being sent back to the client, so it should not be too hard to do.  It just seemed like it was going to exceed the one point budget for this card.


Т.е. удали, пожалуйста, этот файл со стилями и неиспользуемые классы из разметки виджетов.


Но вообще, со стороны noolitedotnet, имхо, было бы достаточно открытой функции sendInternalCommand, так как новые команды в текущем варианте всё равно потребуют переборки драйвера, плагина-драйвера и api.


unused-variables


Jees, tee vielä pull requesti tästä niin homma rokeri :)


Could use `emptySet()`


They are being set.  There is a delay of 1 second and a maximum of 20 retries.


Bah, this commit is from me. I forgot to log out of my other github account. :P


Thanks for pointing me to Eigen's own cast function, Thijs. I took your commit a little further and put it all in one line in 284f376.


This line didn't work for me until I used "app/client/app" /client/app. I'm probably doing something wrong, but wanted to mention it


score should have been a private attribute


Hi Aaron,
Thank you for generating a pull request but the documentation is correct.  The attribute is `sourceMaps` in the VSCode launch.json configuration file.  This is confusing since there is a `sourceMap` attribute in tsconfig.json.  Luckily users can rely on IntelliSense to let them know which attribute name is correct in each file.
- Greg


This '?' is actually not needed.


The proposed comment is true but not relevant until https://github.com/j2objc-contrib/j2objc-gradle/issues/465 is fixed.

With the current functionality of the plugin, the only relevant issue is that their *sources.jar* doesn't have tests in it.


The co-ordinates of the player should have been private attributes.


done


no, see above


Unused wild-card import


Closes #28


Fixing this in aeef55f86ab4ba765ec3720a56537bef790596e6.


Multiple imports on one line


Remove ending comma


I may not have a good grasp of the changes yet, but could it be something as simple as this?

```python
if census is None or current_hash != census_hash:
    job_chain.append(tasks.polygons_to_id.s(polygons, testing))
    job_chain.append(tasks.id_to_histogram.s(testing))
    job_chain.append(tasks.histograms_to_censuses.s())
    job_chain.append(tasks.run_tr55.s(model_input))
else:
    job_chain.append(tasks.run_tr55.s(model_input))
```


What do you mean here?


No encapsulation. The position of the player ,scores and life should have been private attributes


Typo in commit message sorry. It should have been:

**Add feature to WXR import to import Pressbooks' book info**

Sincerely,
The Sentence King


The word "Deserializes" is a bit weird here, given this is a Serializer.
Moreover, the description seems to be outdated, as id and timestamp don't seem to receive any special treatment (anymore?)


huh ? that's an emacs temporary file, no?

also why the LaTeX byproducts and `*.pier` etc above?


That looks similar to the code that was there before that I removed.  If it works, it takes care of the AoI census but not the censuses for each of the modification/BMP fragments (which are potentially very large in number).


Too many conditions.


```php
return parent::getLaserRange() * parent::getLaserRange();
```


А зачем хранить енум с каждым цветом ?


Please clarify this move.
Is this going to be depreciated? I will not be using something like that, if I know it beforehand. Less headaches later.


Awesome!


.DS_Store is like thumbs.db but mac and should be in .gitignore @PeterMitrano


Considering that enricher is not responsible for processing the request in another thread, it shouldn't be the one doing the resetAccessControl call. The component receiving the async response should be the one doing this call.


All tests were quite neutral, but promising because different functions give similar results. That's why I'm starting tuning 6 by 6 moves, and then 6 by 6 depths, starting from default values, until some progress will be noticeable.


Bug in Github's Atom IDE.  If you keep a file open and remove/rename the underlying directory, it recreates the directory and file :(


forgot something there?


Good!


We should not allow cw's machine to join smp test if there is a way to do so, it's just wasting resources. It should stick with 1 thread tests and not instigate smp tests.


New control changed after many failures


It is not deployed, right?


Hello,
a2800276, yes, I am afraid you are correct, I have not made any pull request back to the main repository whatsoever. This was due mostly because of the 128 bit bitmap feature and later on because of a discontinuation message posted.

Regarding Ruby, I'm using  Ruby ver. 2.2.1. Two tests cases are failing because of the encoding. Basically I did not made any pull request to the main repo, because I knew I was missing some coverage tests. Actually I'm also using a rudimentary script to test some other cases.

That said, I would love to merge some of my changes to the main repository. I can assure that those changes I made are not that invasive, though, QuickPay is using this code in production and so do I. If some functionality don't make it to the master I'm afraid I'll have to continue in a separate fork.

Nevertheless, I will make a pull request at the end of the week and hopefully the conflicts will be resolved.


access to partitionsGrid is removed


Thanks for the great cookiecutter template, Daniel. I used it for the first time yesterday. Great defaults.


@andreas-eberle supported by creating code to get the whole amount of gold. Thx!


I am, and it's intentional. I haven't seen any warnings, but if that's an issue, or if there's just plain a better way, I'm open for making changes.


I made the access to the array ArrayIndexOutOfBounds save.


Is returning ``self`` in ``_eval_evalf`` the right way to say that something went wrong? Before that I raised a ValueError, but this lead to a ugly nested traceback.


This code is removed now because it was changed by a Log(amountOfGold)/Log(2)/9 calculation which fits the original game. (I tested it)


Why do we need a list here, isn't a single character enough?


Wow... many changes, much improvement


este cambio esta bien


airdcpp\version.cpp(22): fatal error C1083: Cannot open include file: 'version.inc': No such file or directory

 Rebuild All: 10 succeeded, 2 failed, 0 skipped


Position of the ladder should have been a private attribute


Good job adding a map!


I'm a bit confused. If this parser has no public methods, what's the API?


No currently something like:
methods | color = blue | filter -name=foo | color=red would all result in a single operatornode and it could have different operators


I think this use of types to encourage calling in the correct order is really smart.  Nice work.


Lets extract this function to this file: https://github.com/Swimlane/angular-data-table/blob/master/src/utils/utils.js


Nice work playing with flex-box css!


Consider using `requests.get('url').ok` to check if the request was sucessful.

Source here: https://github.com/kennethreitz/requests/blob/master/requests/models.py#L618


hey, super gemacht :dancers:


Good progress, Francis!


Does this delete the job results from SJS cache?


@dgutierr This seems like the kind of fix we would want a unit test for to ensure it stays fixed in the future. I understand the urge to push directly for smaller fixes (instead of going through a PR which is generally desired), but we as this fixes a BZ I think it needs a test.


Done for collision check.

Also done for testMin.  Note in this case there is a test-sources.jar, but we are blocked on our own bug to support it.  Noted as such.


Hard coded and a long method : code smell


Yes, sending a delete request is supposed to terminate the job (if it is still running) and remove it from the cache.


I think it is there in the final version ? i.e. if you look at all changes


maybe this could be a good parameter instead of product and variant: http://sphereio.github.io/sphere-jvm-sdk/javadoc/v1.0.0-M17/io/sphere/sdk/products/VariantIdentifier.html


@blixtra I think we can leave it here as users can choose to ignore the events if they want.


Too many ifs and elifs.


Good point, will change to KeyValue


comment from android 1


aha, sorry, I'm looking commit by commit since I don't want to deal with the explosion that we caused at the end :D


Here I need to do more than check if the request is successful, this is actually checking the output sent back by SJS to see if the job has completed.


````
Error performing callback invocation : org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase#startUp
org.hibernate.testing.junit4.CallbackException: org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase#startUp
	at org.hibernate.testing.junit4.TestClassMetadata.performCallbackInvocation(TestClassMetadata.java:203)
	at org.hibernate.testing.junit4.TestClassMetadata.invokeCallback(TestClassMetadata.java:187)
	at org.hibernate.testing.junit4.TestClassMetadata.performCallbacks(TestClassMetadata.java:181)
	at org.hibernate.testing.junit4.TestClassMetadata.performBeforeClassCallbacks(TestClassMetadata.java:172)
	at org.hibernate.testing.junit4.BeforeClassCallbackHandler.evaluate(BeforeClassCallbackHandler.java:25)
	at org.hibernate.testing.junit4.AfterClassCallbackHandler.evaluate(AfterClassCallbackHandler.java:25)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:78)
	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:212)
	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140)
Caused by: org.hibernate.AnnotationException: Attribute [org.hibernate.test.hql.MapFunctionExpressionsTest$Contact.addresses] was annotated as enumerated, but its java type is not an enum [org.hibernate.test.hql.MapFunctionExpressionsTest$AddressType]
	at org.hibernate.cfg.annotations.SimpleValueBinder.setType(SimpleValueBinder.java:257)
	at org.hibernate.cfg.annotations.MapBinder.bindKeyFromAssociationTable(MapBinder.java:274)
	at org.hibernate.cfg.annotations.MapBinder.access$000(MapBinder.java:60)
	at org.hibernate.cfg.annotations.MapBinder$1.secondPass(MapBinder.java:95)
	at org.hibernate.cfg.CollectionSecondPass.doSecondPass(CollectionSecondPass.java:54)
	at org.hibernate.boot.internal.InFlightMetadataCollectorImpl.processSecondPasses(InFlightMetadataCollectorImpl.java:1659)
	at org.hibernate.boot.internal.InFlightMetadataCollectorImpl.processSecondPasses(InFlightMetadataCollectorImpl.java:1634)
	at org.hibernate.boot.model.process.spi.MetadataBuildingProcess.complete(MetadataBuildingProcess.java:278)
	at org.hibernate.boot.model.process.spi.MetadataBuildingProcess.build(MetadataBuildingProcess.java:83)
	at org.hibernate.boot.internal.MetadataBuilderImpl.build(MetadataBuilderImpl.java:418)
	at org.hibernate.boot.internal.MetadataBuilderImpl.build(MetadataBuilderImpl.java:87)
	at org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase.buildResources(BaseNonConfigCoreFunctionalTestCase.java:146)
	at org.hibernate.testing.junit4.BaseNonConfigCoreFunctionalTestCase.startUp(BaseNonConfigCoreFunctionalTestCase.java:129)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:497)
	at org.hibernate.testing.junit4.TestClassMetadata.performCallbackInvocation(TestClassMetadata.java:200)
	... 15 more
````


Thanks :sunglasses: :+1:


Thanks!


Do you happen to have access to the modified ramdisk? I don't think it's the DT because I repacked the image with stock zImage but my ramdisk and my DT and it booted fine.


Wow, great finds!  Did you have a tool to detect these?


I think you just fixed #870


Close #712.


+1. We need to start putting in tests to catch regressions for everything now.


@kim how about baking addons-dev.pth into the baseproject? Or do you see a benefit with this approach?


Since the `app` is getting passed, do we also want to pass `config`?  This provides callees two distinct (easy) ways to get the `config`.  Not a big deal, but I thought it was worth asking.


Player doesn't die even after colliding with the Donkey.


There is a distinction between Personal and Local measurements that is an independent concept from filtering visible MeasurementTypes for non-admins.

An admin has access to submit both personal and local measurements.


Supplied changes seems to solve the ProxyConfiguration problem, pending runtime-test will scheduled for tomorrow.


that's not a good change.  java standard should be getOptions().


Oh i see.


comment from android 1


TeamCity pull requests :: netty-tcnative [Build 9](https://garage.netty.io/teamcity/viewLog.html?buildId=1802&buildTypeId=pulls_netty_tcnative&guest=1) is now running


Looking good. I wouldn't worry adding in species names, that'll only slow you down - the main focus is isolating the catalogue numbers (if there are any), in each sentence fragment. Progress _down_ the rows is what is needed. This file is just one of many still to process...


YES


I'm pretty sure this will break Xcode 7 builds...


TeamCity pull requests :: netty-tcnative [Build 9](https://garage.netty.io/teamcity/viewLog.html?buildId=1802&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:42


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 731](https://teamcity.labkey.org/viewLog.html?buildId=274729&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **SUCCESS**
Summary: Tests passed: 9, muted: 34 Build time: 00:25:32


Bad code smell:
   Too many branches


we currently don't have a toggle on the Measurements UI, but we should show all users (including admins) that can submit personal measurements their personal measurements by default and not the Ministry measurements.


PEP-8 standards violation:
 invalid variable names a,ch


Thanks
e

On Mon, Sep 28, 2015 at 2:55 PM, Rich Mogull <notifications@github.com>
wrote:

> I cover that a little in the automation section, or you use a tool that
> supports direct inclusion of AWS or Azure via API. Check with your vendor...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Securosis/PragmaticNetSecCloud/commit/814ce7e874541ee3a5633e093fc7320657941d3a#commitcomment-13476339>
> .
>

--
Eric Grossman
Grossman.Eric@gmail.com
Eric@CruzenGrossman.com
Eric@EricGrossman.com


Warning:
  Unreachable code


TeamCity LabkeyModules15.2 :: CDS postgres 9.4 [Build 23](https://teamcity.labkey.org/viewLog.html?buildId=274707&buildTypeId=LabkeyModules152_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 22 Build time: 00:35:01
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

```


This is not documentation change so please don't do it in docrails. I'm reverting


Got it. Thanks.

I would be in favor of not modifying the functions with hooks for testing. I think it'd be worthwhile to rewrite the tests to test each of the functions in the chain rather than testing the wrapper function.


OVERLAY_MOUNTS changed to DO_OVERLAY_MOUNTS.  This looks like a bug fix so let's call it out explicitly in the commit comment or split this change in to its own patch.


Thanks. Didn't catch them there.


@rafaelfranca i'll changed and pushed again...it's wrong..!!


PEP-8 standards violation:
  Missing function docstring


Might be worth adding an enable method for this.
See [startup script](https://github.com/roboterclubaachen/xpcc/blob/develop/src/xpcc/architecture/platform/driver/core/cortex/startup.c.in#L232-L238).

Perhaps also replace the manual cycle counter in [the delay functions](https://github.com/roboterclubaachen/xpcc/blob/develop/src/xpcc/architecture/platform/driver/core/cortex/delay.cpp.in#L59-L63)?


I should have added this:
```
spring:
  profiles: cloud
```


I haven't tested this yet. I'm going to make a form on index.html and try to add employees.


 Это ты о чем?

>Понедельник, 28 сентября 2015, 13:14 -07:00 от EVAL7 <notifications@github.com>:
>
>Зачем она нужна. Убрать
>—
>Reply to this email directly or  view it on GitHub .

С уважением,
Алексей Максимкин


I think it should return None, looking at what other functions do. You want it to just remain unevaluated, right?


PEP-8 standards violation:
  Old -style class defined.


I was thinking parent::getLaserRange() * 2;

Maybe it's not clear enough?


TeamCity pull requests :: netty [Build 327](https://garage.netty.io/teamcity/viewLog.html?buildId=1804&buildTypeId=pulls_netty&guest=1) is now running


TeamCity LabkeyRelease15.2 :: CDS postgres 9.4 [Build 21](https://teamcity.labkey.org/viewLog.html?buildId=274713&buildTypeId=LabkeyRelease152_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 22 Build time: 00:36:06
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

```


Bad code smell:
  Too few public methods (0/2)


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4069/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


Bad code smell:
Too few public methods (1/2)


Please don't use inline styles of tag elements


Btw, results prefixed with w don't denote pep-8 standard violation


When the user viewing their personal measurements is a leader they need to be able to see the leader only measurements. This currently is hiding leader only measurements from everyone.


Changed energy values, new methods and forward


Loading `opal-jquery` before bootswatch does not resolve the issue in any case.


I thought about it, when I was struggling so much with the cmake quirks. But after learning enough, there was no improvement that justified such a move.

If I would change something, then I would replace the Shiboken generator. That thing ate about 75 % of my time, just hunting bugs which are hidden in Shiboken. I did almost no C++ work, just fighting shiboken.

So if somebody wants to sponsor PySide2 development, then it should be for a better Shiboken with no bugs, no limitations and no XML with code snippets.

Sent from my Ei4Steve

> Am 28.09.2015 um 22:03 schrieb Ryan Gonzalez <notifications@github.com>:
>
> BTW, have you guys ever considered moving away to CMake to something else? Maybe Boost.Build, Fbuild, or Waf?
>
> Just checking. :)
>
> —
> Reply to this email directly or view it on GitHub.
>


core cache function should be check_request not check_cache


Visual Studio 2013 wasn't found

 **ERROR: Build failed and aborted!**
Press any key to continue . . .

I have Visual Studio 2015

before this code I could compile with VS 2015


I wonder if this shouldn't actually return 0 since it's the behavior requested by the user.  That said, we want to avoid any changes in behavior if possible in the point release so it should stay 3 for now.


Does `loc.step()` encode line #? If not, just `newline` may be sufficient here. Illustrative completeness is totally cool though.


Please add a @deprecated tag in the javadocs describing that the class has been moved.


It's a bit confused me.. Is it possible to rephrase it?


TeamCity pull requests :: netty [Build 328](https://garage.netty.io/teamcity/viewLog.html?buildId=1809&buildTypeId=pulls_netty&guest=1) is now running


Minor comments to update the Javadocs for the deprecated classes to describe that the class has been moved.


Bak files could be removed from version control


nice


Bad code smell:
  Method could be a function (no-self-use)


I'm assuming the no_sleep parameter keeps mpdecision enabled when the device is in deep sleep? If so, isn't that a bit overkill? Correct me if I'm wrong, I haven't played with mpdecision.


Also besser nicht pullen :D wollte morgen mal bei wegen dem email kram


Hi, could you please make a pull request to https://github.com/groovy/groovy-native-launcher ?
We've forked the Codehaus read-only repository in the Groovy organization on Github.
Thanks


Yes, you are right. I had a look at the code that already uses it and decided to not replace it at the moment, because I did not want to risk breaking anything.
About the [startup code](https://github.com/roboterclubaachen/xpcc/blob/develop/src/xpcc/architecture/platform/driver/core/cortex/startup.c.in#L233-L237), can we just move the referred lines into an `enable` function?
What is this about: `CoreDebug->DEMCR |= CoreDebug_DEMCR_TRCENA_Msk;`
Is that needed by anything else?


PEP-8 standards violation:
 invalid variable name jj


Another option might be to just pop the two network-using function from the front of that list, replace them with one celery task to return the test data, then allow the chain to execute.


Good point. I think `config` should be removed from the `ApplyContext`. I missed that one when merging the `app` injection updates.


You need to consider the case that right == 0


This is a nice bit of cleanup and makes the code much more readable.


You can report the results of the papers them selves here. They also include baselines related to "Relative Attributes" etc.


It's passing on CI. Anything specific you're concerned about?


Breaks fonts theme


I believe for those who are using another cordova plugin that relies on googleplayservices this change will inevitable lead to the following when building:

`com.android.dex.DexException: Multiple dex files define Lcom/google/ads/AdRequest$ErrorCode``

The framework tag is the better solution here.


Should we add !Array.equals(strings, oldData.strings)?


Bad code smell:
 Too many statements(55/50)


Complete this sentence " to reports bugs.


Need a CONTRIUTING.md file


I can't remember why I commented this out. :confused:


@spyshiv
Problem of jQuery in scroller bar is not permanently resolved.We need to see this!
Color of scroller changed to black.
Sir updated my Apache-tomcat now JSP pages are perfectly working


What would be a good api design for accepting a culture? Pass it as a parameter to every Evaluate call or pass it once in constructor?


Game doesn't work. The movement happens with the arrow keys but in wrong directions


PEP-8 standards violation:
   invalid variable name jj


Hm. Even though `FeeUnits : drops :: 1 : 1`, I don't think I want to codify that by automatically casting FeeUnits to `XRPAmount` without an intervening scaling calculation, whether for load (`calculateFee` in Transaction.cpp at the tip of `HEAD`) or fee escalation (forthcoming), even if that scale works out to `1 : 1`. It could change.

I would be ok with `using FeeUnitAmount = std::uint64_t`, but I don't think that's so much necessary here.


Bad code smell:
 Too few public methods(0/2)


@andrewhr Yep :)


The output comes on the bottom left corner which is not suitable


I figured it was intentional -- you're smart that way.  I just figured adding a couple of sentences worth of comment might get someone oriented into what's happening.


I think we could do without this comment entirely now that the scripts are more tolerant of their input.  However, I'm OK with keeping it with the following minor fixes.

```
# To enable a boolean setting, set it to yes, Yes, YES (or any case combination
# thereof) or to 1. Anything else will be interpreted as unset.
```

or case -> or any case
there of -> thereof


Yes, I wan't it to remain unevaluated as I can't raise an exception in ``_eval_evalf``. The tests still pass if I return None.


Player doesn't die even after hitting the fireballs


Game doesn't end with Q


Warning:
  indentation with tabs instead of spaces


Moving the lines into an `enable()` method should do it, yes.
There is also little risk of breaking anything, a blink example with `delayMilliseconds()` should verify functionality after the change.

> What is this about: CoreDebug->DEMCR |= CoreDebug_DEMCR_TRCENA_Msk;
> Is that needed by anything else?

The Cycle Counter is part of the debug tracing macrocell, so to use it, this part has to be switched on.
The Cortex-M0 doesn't have tracing, and therefore also no cycle counter :-(


@SubJunk I don't know all use scenarios for Java, but Java 6 is a special case since that's the version Apple bundled with their OS'es. From 7 on everybody has to install themselves from what I understand, and then it's really hard to see how anyone could be stuck on 7. In Windows atleast, there's no problem to have both 7 and 8 installed at the same time for that matter. In any case, I think we should keep the "main" version the lowest version for minmal merging issues. We can't really use any of the newer features anyway, since we have to find a way to make it work in the older, so we might as well use that platform.


s/worth noticing/worth noting/


PEP-8 standards violation
262-294 Bad white spaces


Currently I have disabled connection between Power HAL and MP-Decision (here https://github.com/HealthyHoney/common/commit/5f85bed5814f628bdd3267aba465d727727f697d) so I'm testing if it could be better for battery.. It's good for custom hotplug because Power HAL doesn't throw "perf errors" :) Will report back..


How about expanding this to skip the check when you're `sudo`-ing to non-root users too? In that case, `compaudit` will often produce insecure-directory warnings that there's nothing a user can do to fix.

```
if [[ $USER != root && ( -z $SUDO_USER || $SUDO_USER == $LOGNAME ) ]]; ...
```


:) Will do.


Index out of range error if the player tries to go up a broken ladder


Maybe a test showing BOM in the middle of a file? Scenario: MyQuery.graphql and MyFragment.graphql both had BOM headers. I `cat` them which results in BOM between the two definitions.


Remember, NONE of these commits is meant to go into master! They're already present in my "Phase 2" commit. These commits are ONLY meant to for the "back port" to the 0.6.5.x branch(es)…. AND I expect those that makes it into that branch to be rebased into ONE commit. I've just separated them here into separate commits for "ease of decision"...

But I agree. This is a regression (or rather, fix of a regression :). It's a one line fix, so better to spell it out in the commit message than separating it out as a separate commit...


Looks good, but the commit message looks wrong?


sorry for anonymous commit :)
I forgot to set email in git settings at my local dev enviroment.


imho it will very duplicate code. Is it possible to keep only lists?


Yes, cut-and-past error...


It seems the early return will looks better:
```
if (upperBounds.size() == 1 && KotlinBuiltIns.isDefaultBound(KotlinPackage.single(upperBounds)) return builder;

 for (JetType upperBound : upperBounds) {
    builder.addUpperBound(type(upperBound));
}

```


Thanks, @duner!


Are there plans to publish this to `npm`?


PEP-8 standards violation:
Exactly one space required after comma


I could write an ``assume_integer_order`` decorator and use it instead of the ``if`` blocks in various methods in this file. WDYT?


Perfect thanks all!!

On Monday, 28 September 2015, Casey Foster <notifications@github.com> wrote:

> @rngtng <https://github.com/rngtng> This should be fixed in 0.4.3
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AtomLinter/linter-rubocop/commit/7ead92120c3999eb9c537300b1447a966852e31a#commitcomment-13473119>
> .
>


TeamCity Colore :: Main Build [Build 124](http://tc.sharpblade.net/viewLog.html?buildId=667&buildTypeId=colore_mainbuild) is now running


Game doesn't end even after hitting the donkey


PEP-8 standards violation:
Exactly one space required around comparison


TeamCity Colore :: Main Build [Build 124](http://tc.sharpblade.net/viewLog.html?buildId=667&buildTypeId=colore_mainbuild) outcome was **FAILURE**
Summary: Compilation error: Corale.Colore\Corale.Colore.csproj (new) Build time: 0:0:38


Maybe a test showing valid usage of strings containing multibyte unicode?


Use https://github.com/redco/redcode-currency-rate-bundle/blob/master/Manager/CurrencyManager.php instead of this


Thanks!!


So, den neuen Commit kannste pullen^^ Müsste alles gehen, hab aber noch nicht alles getestet, wird noch lückenhaft sein


Worth a commit comment since it's unrelated to the actual fix here.


Better create static helper method that will filter null List entries and then create ` .toArray(new String[array.size()])`


Ok, let me know how it is after testing :+1: Thanks!


Please add functionality for adding Currencies through the [CurrencyManager](https://github.com/redco/redcode-currency-rate-bundle/blob/master/Manager/CurrencyManager.php)


Good point !


What's going on here with $name?  This clearly is more than just removing sort.


TeamCity Colore :: Main Build [Build 125](http://tc.sharpblade.net/viewLog.html?buildId=668&buildTypeId=colore_mainbuild) is now running


BUG: On the topmost platform if the player goes right past the ladder the player gets trapped and cant go left past the ladder


TeamCity Colore :: Main Build [Build 125](http://tc.sharpblade.net/viewLog.html?buildId=668&buildTypeId=colore_mainbuild) outcome was **FAILURE**
Summary: Compilation error: Corale.Colore\Corale.Colore.csproj (new) Build time: 0:0:16


This looks great.

Will comments consume multi-byte characters correctly as well? For example, what happens if a http://www.fileformat.info/info/unicode/char/0A0A/index.htm occurs within a comment?


Isn't this checking the 'label' field against the what the json object is called:

     "F": {...
           "label": "F",
            }
works fine, but

     "F": {...
           "label": "Frequency",
            }
does not.  I seem to be getting errors all of the sudden.


This is definitely a nitpick on my part :) but this is a little redundant/wordy... why not assign visit.getStopDatetime() directly to this.stopDatetime?


Front Page Animation version1


Cool. Not totally following the plan with "pack based distribution", but if we can fix the failure when loading JSON I'm all for that.


Why that class has been copied here? Please use [CurrencyConverter](https://github.com/redco/redcode-currency-rate/blob/master/src/RedCode/Currency/Rate/CurrencyConverter.php) instead


@seto, no fix needed. it works now.


I'm assuming this revert also fixed the bug https://bugs.limesurvey.org/view.php?id=9844


ERROR/BUG:Fireballs are not working,cant climb the ladder near queen


Error: Levels not implemented


BUG: the 'H' of the ladder gets broken and gets attached on the platform


For some context, the reason I hit this is that we have raw cloudformation templates (.json) and sparkleformation templates (.rb) in the same dir. Not sure if the pack based plan will allow for that or not. If you think it won't then maybe I should just go ahead and isolate the two now.


that's ok, I'll just pull woof and do it soon.

On Tue, Sep 29, 2015 at 6:52 AM, Dima Krasner <notifications@github.com>
wrote:

> Another speedup of printcols.
>
> It should be at least 40% faster now. Profiling shows it wastes most of its
> runtime on printf() and friends (strlen(), memchr(), etc'). Replacing the
> printf() call with fputs() and putc() reduces the huge impact of printf()
> on
> performance.
>
> @01micko - the x86_64 binary needs to be rebuilt, again. Sorry for this.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/puppylinux-woof-CE/woof-CE/commit/091711d72fe17655ffb45abd99f5c886ee9da23f
>


Incidently, and I am glad I finally remembered to say this, I think this is the reason that jobs tend to fail more when there are more modifications/BMPs: because there are more censuses being done.  It is also the case (I think) that the current `mmw-geoprocessing` code does not do any caching at all, so that if you have an AoI plus a modification that covers the whole AoI plus a BMP that covers the AoI, you end up downloading all of the tiles three times.


Jump feature according to floor is implemented.Also jumping from a floor to another is also implemented


Is there any reason this has to be an int?


Actually, it's -S ("ess") and then name - "sorts by property in descending order"…

It's the same thing as sending it to sort and then reversing it there...


@jhoblitt @mjuric this table file has a lot of cruft in it.


Yep, to handle the -1 case


use zimage-dtb instead of zImage ;)


I can remove it. It sounds so petty to add it to the commit message and as you said, since this commit(s) are cherry-pick fixes, this isn't really relevant...


Is it possible to have List here ?
 ```
  @JsonProperty("Cmd")
     private String[] cmd;
```


Modules are not written,instead the code is written in 1 single file


@kylemac yeah, kinda just happened :turtle:


What about old compiler [RegisterProvidersPass](https://github.com/redco/redcode-currency-rate-bundle/blob/master/DependencyInjection/Compiler/RegisterProvidersPass.php)? I don't see any deletion of it. Looks like that class does the same thing


Yeah i thought the same, just wasnt sure :)
Btw did you manage to get a succesfull build with your samsung hw repo?
It always shits about missing imports here, didnt really look into it since i didnt have enough time but i will do when i have the time :)
Was just wondering :p


Please don't use inline styles of tag elements


From this comment it's not at all clear to me that ZFS_POOL_EXCEPTIONS and ZFS_POOL_IMPORT only apply to the initramfs script.  Let's make sure they're prefixed ZFS_INITRD_POOL_EXCEPTIONS and ZFS_INITRD_POOL_IMPORT to be consistent with the other initrd specific options.


Why the .1?


The other stray local variable update should be folded in to this patch.


You're right - that's a bug.


PEP 8 : Invalid method name "collectCoin".


This has the main menu activity and BluetoothSerialCommunication activity functioning properly.  BluetoothSerialCommunication has serial transfer of a string from the text entry box only.


missing docstrings for methods.


梗太多，能力有限，不参与了，你们加油哦～


не уверен, что я тут правильно поступаю


Okay, I see this is fixed in a subsequent commit, i'll just review the whole PR.


Per algun motiu, el rebase no s'ha fet correctament. Si et fixes a https://github.com/Softcatala/wp-softcatala/network, la branca hauria de sortir de `master`, i no ho fa.


Comment here would be helpful.


I think just calling the following will work:
```JS
.addEventListener("click", this._contentSearchController.search.bind(this));
```


Don't we typically pass a `TER` by value?  Not a huge cost either way, but could be a minuscule improvement.


this one still fails.

it only fails with ranges though

```
iex(18)> Enum.member?(5..5, 5.0)
true
iex(19)> Enum.member?([5, 5], 5.0)
false
```


The exe update found the the Mac build is only minor and thus I did not update the Windows version. I will update the Windows build once the next great update is gonna take place.


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4070/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


On it...


:neckbeard:


Instead of `sudo -s` one could also just run `su <user>` (without `-` / `-l`) to change the user without changing the current working directory. So the problem is not limited to `sudo`.

Besides this, if you remove the check for root then you can easily just remove the whole `compaudit` part again because it's not needed and OMZ can deal with it perfectly fine thanks to `compinit -i`.


+ 1


напоминалка: заменить на if


what...


Duplicate! Use [ProviderFactory](https://github.com/redco/redcode-currency-rate/blob/master/src/RedCode/Currency/Rate/Provider/ProviderFactory.php)


напоминалка: добавить пробелы  в выражении


Add comment to indicate what quantilesCol is -"This column will output quantiles of corresponding quantileProbabilities if it is set."


specify param types


Kein Stress, vor morgen komme ich da eh nicht zu, bin noch mit der Doku beschäftigt


:+1: :apple:


It all looks good but I have few things.

The first is what I just commented on the trello card. Let's have the classification be a number that we will map on our code.

The rest are just discrepancies from using my insertProduct method as an example.
1. We probably don't need a field called employeeId in the employee collection. This is because the name employeeId is kind of redundant and when we insert it into the collection mongo creates a globally unique ID of type MongoId on its own called _id. So it basically gets taken care of for us in a more reliable way.

2. When inserting the employee we should just set it to true instead of passing it in with the argument object. I pass it in like that in the products because there was a field in the .csv file with this already defined. If we are inserting a new employee, it's probably going to be active.

3. Just set the createdAt field to Date.now() in the method. Again the createdAt info was already put in the .csv file for the products so that's why I have it being passed in with the argument object.

Also unless you're going to use the console.log in the error testing thing unless you're going to use it when you are testing. I should have removed my comment on the products. I was being messy because I was rushing to get it up.


тут сделал проверку на тип к редита и в зависимости от этого вывод месячных платежей.
Смущает, что захардкодил равенство, может надо было использовать ```creditMethods.annuity```
но тогда мне бы пришлось эту переменную записать как свойсво контроллера.


Will one of these two constructors be going away in an upcoming `[FOLD]`?  Seems like one or the other should be sufficient.


Add comment to indicate what quantile probabilities is and where it gets its value from  -"This column will output quantiles of corresponding quantileProbabilities if it is set."


This just bit me in my ass.


And you left the .itemLookupCode in the employeeId field but that doesn't matter because we will probably remove that field


The changes in this file are more than the backport: i have had an issue with a user without a displayname that caused users page to not work. I could not provoke it in master, but will take it over in a new PR just to make sure its robust.


So do I understand then that you propose the save only to occur when for example starting a gatefilter script, thus starting the two plugins that modify the gatefilter currently?

The current save function in the ```menu.py``` would be used? It would still need to be extended to accommodate the potential changes to the mask and be a common save. But I think the potential to save the file is important with modified mask.


I see, ill figure it out sometime


Actually, in the "Phase 2" commit, I move the whole import section from BOTH sections into zfs-functions and this affects that code.


What is the purpose of adding ProviderChain? I don't see any point of it. Could you clarify.


Please don't use tag as a selector fo styles. If need create additional class, or build more strong selector depended on other classes or ids


Whoops, I will recommit because I’m going to show the employees on index anyway.

On Mon, Sep 28, 2015 at 4:18 PM, ijsnow <notifications@github.com> wrote:

> And you left the .itemLookupCode in the employeeId field but that doesn't matter because we will probably remove that field
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/MongooseUASoftEng/MongoosePOS/commit/68ebca998de59ba47588a9f5cfd4819e91d99515#commitcomment-13479233


It returns false here. Be sure you are on 1.2.


Are you not implementing the validateAndTransformSchema method and the experimental fitting of AFT model based on Weibull distribution?


不要乱甩锅（笑）


okay, there you see how the boost libraries should be named:

one of:
boost_filesystem-mt-1_56;boost_filesystem-mt;boost_filesystem-mt-1_56;boost_filesystem-mt;boost_filesystem

i.e
so you should have a /usr/lib/libboost_filesystem.so


I agree for most, but the employee ID was something that Dr. Phillips put on the trello card that’s supposed to be independent of the _id, something for “internal use” by our “company” or something like that.

On Mon, Sep 28, 2015 at 4:19 PM, ijsnow <notifications@github.com> wrote:

> It all looks good but I have few things.
> The first is what I just commented on the trello card. Let's have the classification be a number that we will map on our code.
> The rest are just discrepancies from using my insertProduct method as an example.
> 1. We probably don't need a field called employeeId in the employee collection. This is because the name employeeId is kind of redundant and when we insert it into the collection mongo creates a globally unique ID of type MongoId on its own called _id. So it basically gets taken care of for us in a more reliable way.
> 2. When inserting the employee we should just set it to true instead of passing it in with the argument object. I pass it in like that in the products because there was a field in the .csv file with this already defined. If we are inserting a new employee, it's probably going to be active.
> 3. Just set the createdAt field to Date.now() in the method. Again the createdAt info was already put in the .csv file for the products so that's why I have it being passed in with the argument object.
> Also unless you're going to use the console.log in the error testing thing unless you're going to use it when you are testing. I should have removed my comment on the products. I was being messy because I was rushing to get it up.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/MongooseUASoftEng/MongoosePOS/commit/68ebca998de59ba47588a9f5cfd4819e91d99515#commitcomment-13479198


Please use more specified name for classes, for ex in this case `.ua_flag`, `.lang_ua`, etc


Added the same test to graphql-js right now https://github.com/graphql/graphql-js/commit/da5c4b0814887382067dcaeaddd6fed8a76a3614


is recommended?  or is not recommended?


Ah I guess this is an enforced convention.  I just noticed it because the json files used for testing do not adhere to it.  So the GUI crashes with a dictionary key error if you try to open it with the .json files produced by test_json.py


I see. I think I don't quite get the process to generate the census (I thought we were generating one census for the AoI along with it's modifications). If you don't mind, can we go over this tomorrow in the office?


Ok, done!

On Tue, Sep 29, 2015 at 7:06 AM, Michael Amadio <01micko@gmail.com> wrote:

> that's ok, I'll just pull woof and do it soon.
>
> On Tue, Sep 29, 2015 at 6:52 AM, Dima Krasner <notifications@github.com>
> wrote:
>
>> Another speedup of printcols.
>>
>> It should be at least 40% faster now. Profiling shows it wastes most of
>> its
>> runtime on printf() and friends (strlen(), memchr(), etc'). Replacing the
>> printf() call with fputs() and putc() reduces the huge impact of printf()
>> on
>> performance.
>>
>> @01micko - the x86_64 binary needs to be rebuilt, again. Sorry for this.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/puppylinux-woof-CE/woof-CE/commit/091711d72fe17655ffb45abd99f5c886ee9da23f
>>
>
>


MIDR is only accessible from kernel mode


Please don't commit debug inforamation (alerts and console.logs)


Hey Shiv

I got a bit tied up for the last couple of days, but I'm free again tomorrow so I was planning on tidying up a couple of things (client identification and disabling takebacks) and then pushing it to the main branch for folks to start playing with and breaking, whilst I start on the last part which is the chess clock on the web page. If my sync plan doesn't pan out I'll have to rethink it.


BUG : when jump again and again on the platform first thing is the player is in air and after some jumps the game stops with an error Attribute Error: 'Point' object has no attribute 'permChar'.


I mean, the `gatefilter` plugin already have the option to save with mask, do we need the same in `SelectRegion` ?


note what happens if they are already in the desired state


Yeah, it looks like it. I get into the habit of passing `const&` for objects, and sometimes forget the enums and type aliases are simple.


Replace newvalue with '!cf_classconfigs.value' and remove the rest of the function :-) There's your built-in toggle.


@dbleyenda por favor crea un ticket en pivotal con un screenshot si tenes asi lo entiendo.


TeamCity pull requests :: netty [Build 327](https://garage.netty.io/teamcity/viewLog.html?buildId=1804&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 5610, ignored: 21; resource leak detected (new) Build time: 00:38:46


use update here.


Thank you!


> Instead of sudo -s one could also just run su <user> (without - / -l) to change the user without changing the current working directory. So the problem is not limited to sudo.

Could we use `[[ $LOGNAME != $USER ]]` or something similar to detect that case?

> Besides this, if you remove the check for root then you can easily just remove the whole compaudit part again because it's not needed and OMZ can deal with it perfectly fine thanks to compinit -i.

If all we do is `compinit -i` with no `compaudit`, OMZ never gets a chance to inform the user that some directories are being ignored, and it may produce degenerate or broken `.zcompdump` files. That was one of the main reasons for doing #3889. Reverting that might be the right thing to do, but I'd like that to be an intentional choice.


the script I gave is not a future proposal, it is functional, at least it should be in your branch.


The if-else thing is ok. This is CMake-syntax. Note that it says if-else-endif and not if-elseif-endif!
You can try cmake-gui to set new options. Just add another variable and press configure and generate (if first succeeded) This is also where e.g. the boost-option can be changed. (or use any other tool like ccmake)
Static boost libs are the default. Seems like you don't have them. Try to search for them, compile them or try the dynamic ones.


TeamCity Colore :: Main Build [Build 126](http://tc.sharpblade.net/viewLog.html?buildId=669&buildTypeId=colore_mainbuild) is now running


this comment is now out of order.. will need to fix


You mean setting this to __none__, or an empty string '' which is a special reserved values.  I'd suggest we straight  up quote the man page here.

           Controls the location of where the pool  configuration  is  cached.
           Discovering  all  pools on system startup requires a cached copy of
           the configuration data that is stored on the root file system.  All
           pools  in  this  cache  are  automatically imported when the system
           boots. Some environments, such as install and clustering,  need  to
           cache  this  information  in a different location so that pools are
           not automatically imported. Setting this property caches  the  pool
           configuration  in  a  different location that can later be imported
           with "zpool import -c". Setting it to the special value "none" cre-
           ates  a  temporary pool that is never cached, and the special value
           ’’ (empty string) uses the default location.


use table-driven tests


iBS::Uchar is ready.
Simply by putting this header in your C++ project you can have a container for a single UTF-8 char.
- Encode from an Unicode to UTF-8 formatted Uchar.
- Decode returning a Unicode as an unsigned integer.


As for ZPOOL_IMPORT_OPTS I'm all for it.  Often we need a way to pass in arbitrary arguments without hacking up the scripts.


```
$ bin/iex  (in master repo)
Interactive Elixir (1.2.0-dev) - press Ctrl+C to exit (type h() ENTER for help)
iex(1)> Enum.member?([5, 5], 5.0)
false
iex(2)> Enum.member?(5..5, 5.0)
true
```

```
Interactive Elixir (1.1.0) - press Ctrl+C to exit (type h() ENTER for help)
iex(1)> Enum.member?(5..5, 5.0)
true
```


TeamCity Colore :: Main Build [Build 126](http://tc.sharpblade.net/viewLog.html?buildId=669&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:1:28


TeamCity Colore :: Main Build [Build 127](http://tc.sharpblade.net/viewLog.html?buildId=670&buildTypeId=colore_mainbuild) is now running


do the todo


The JSON files should not be causing an issue and should be able to live happily with the ruby based templates. I'll have a PR covering #69 shortly and will get it shipped out soon so things are less annoying. I'm also going to tag an update to sfn along with it to automatically type check so it can enable/disable processing automatically since I'll just store that along with the template data inside the pack.

If you're interested in learning more about packs and their intention they are described here: http://sparkleformation.github.io/sparkle_formation/UserDocs/sparkle-packs.html


TeamCity Colore :: Main Build [Build 127](http://tc.sharpblade.net/viewLog.html?buildId=670&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:1:2


You should clear the perf collection (or better yet, create a different collection, such as perf_solr) before running the Solr job ... also, instead of prompting, just add an option that defaults to False to the task args, something like: index_solr_too=False. In general, keep in mind that we'll want to run this task in an automated fashion from Jenkins some day.

Also, please refactor the code that waits for a step to complete into a separate private function (prefix with _) so that we don't have to duplicate code each time we add another Pig step to the job.


Typo


True. Employee 1, 2, 3 etc. would be better than Employee "dhahry2615484hahfj26384"


TeamCity Colore :: Main Build [Build 128](http://tc.sharpblade.net/viewLog.html?buildId=671&buildTypeId=colore_mainbuild) is now running


That's fair.  FeeUnits seem to be pretty well established in the code base.  I would actually prefer that we *not* do `using FeeUnitAmount = std::uint64_t`.  It adds no complier leverage and obscures that we're using a plain `uint64_t`.


player can't move other than the initial line because no functions are implemented for example ladder,jump,move to the platform just below when the player is in air.


TeamCity Colore :: Main Build [Build 128](http://tc.sharpblade.net/viewLog.html?buildId=671&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:1:0


Certainly, will do.

The summary is: you need censuses of the modifications/BMPs, because you need to know what to subtract from the AoI in order to construct the modified scenario.


Hm. I wasn't planning to. I used two, even though they're similar, because the normal calling path expects a pair, but I didn't want to construct a new `pair` on the error paths, nor store and split the `pair` on the good path. https://github.com/ximinez/rippled/blob/preclaim/src/ripple/app/tx/impl/apply.cpp#L209-L226

If it irks you, I could just make the pair, _OR_ I could drop the `baseFee_` from the 3 parameter ctor and set the value to 0, since that's what's being passed in anyway.


TeamCity Colore :: Main Build [Build 129](http://tc.sharpblade.net/viewLog.html?buildId=672&buildTypeId=colore_mainbuild) is now running


Of course you could leave the loop body empty by putting `loopCount++` in the condition, but this is probably clearer...


looking very, very good!  please let me know if I can help in any way


this file shouldn't be here for now


Comma is missing at the end of this line


Well, seem to work for me so far (clua 5.1 and luajit), but you are probably right it is not supposed to work


LGTM


TeamCity Colore :: Main Build [Build 129](http://tc.sharpblade.net/viewLog.html?buildId=672&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:0:58


ignorar aluna


I think the points here is that if you want to implement this (what you did), not problem, I'm ok with that. But did you knew that you could have done the same without any line of code? if you didn't knew, that means I'm falling in showing how strong this design is.


Firstly, I tried MIDR instructions. However, I cannot run this instruction at user mode. Therefore, I use `/proc/cpuinfo`.


ГАГАГА


It works now! thank you! :)


TeamCity Colore :: Main Build [Build 130](http://tc.sharpblade.net/viewLog.html?buildId=673&buildTypeId=colore_mainbuild) is now running


Now it also works with tcl8.6. great


It's not a big deal to me.  Think about it and use your best judgement.


> Does loc.step() encode line #?

yes

> Also, if stepping over CRLF, wouldn't you step() twice for both bytes?
No, on systems that use CRLF as a line ending, that would double-count it!


TeamCity Colore :: Main Build [Build 130](http://tc.sharpblade.net/viewLog.html?buildId=673&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:1:0


TeamCity Colore :: Main Build [Build 131](http://tc.sharpblade.net/viewLog.html?buildId=674&buildTypeId=colore_mainbuild) is now running


Error/Bug:
  Use of super builitin on an old style class


cyclomatic complexity : bad code smell : too many if and else.


Bad code smell:
  Too few public methods (0/2)


TeamCity Colore :: Main Build [Build 131](http://tc.sharpblade.net/viewLog.html?buildId=674&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:0:58


The general case is trivially correct (the parser just doesn't care about Unicode and passes bytes straight through), but there is extreme messiness around handling UTF-8-encoded characters that may happen to contain one of the "bad" control character bytes that needs to be tested and fixed. Good catch.


Awesome awesomeness. I thank you, and generations of future students thank you.


I'll probably test the changes in 2-3 weeks, it can't hurt to test early (and if it fixes something, it's a bonus). I am somewhat expecting 3.0.3 to be soon based on what's written at http://wxwidgets.blogspot.com/2014/12/a-year-in-wx.html


Haven't we "always" recommended to use -d instead of -c?

This just spells out, for those that _must_ (for various reasons) that it's perfectly possible to enforce the use of a cache file instead of auto detection...


PEP-8 standards violation:
  Exactly one space required after comma-Bad whitespace


PEP-8 standards violation:
  Trailing whitespace


Thanks!!!


Technically, this PR might not be "back port material", but I added it here anyway for your consideration. It's been in "Phase 2" for quite a while...


Ok, what's the -1 case for?


I think implementations can go either way on that one. The pre-existing java and Python implementations did not do that. I think using different scopes is common, but multiple client ids in the same project is relatively unusual.


Woops, thanks for catching. I wonder how come my Kosmtik doesn't give an error message on this.


any of the OOP concepts not implemented.


> Will comments consume multi-byte characters correctly as well? For example, what happens if a http://www.fileformat.info/info/unicode/char/0A0A/index.htm occurs within a comment?

The UTF-8 encoding of `\u0a0a` is the 3-byte sequence `e0 a8 8a`, so there's no problem there. There is also no problem with `0a` ever being embedded within a valid UTF-8 byte sequence because UTF-8 is designed not to overlap with valid ASCII bytes -- UTF-8 encodings for codepoints above `7F` all have the high bit set!


I've changed this to:

```
# Full path to the ZFS cache file?
# See "cachefile" in zpool(8).
# The default is "@sysconfdir@/zfs/zpool.cache".
#ZPOOL_CACHE="@sysconfdir@/zfs/zpool.cache"
#
# Setting ZPOOL_CACHE to none or empty string '' AND setting ZPOOL_IMPORT_OPTS to
# "-c @sysconfdir@/zfs/zpool.cache" will _enforce_ the use of a cache file.
# This is needed in some cases (extreme amounts of VDEVs, multipath etc).
# Generally, the use of a cache file is recommended on Linux because it
# sometimes is more trouble than it's worth (laptops with external devices
# or when/if device nodes changes names).
#ZPOOL_IMPORT_OPTS="-c @sysconfdir@/zfs/zpool.cache"
#ZPOOL_CACHE=""
```

which should make things a little more obvious.


basic functionality required is not implemented.


Oh, I see. It's a "use whatever it currently is flag". It'd be nice to have some constants for that so it's more obvious, but it's fine.


> there is extreme messiness around handling UTF-8-encoded characters that may happen to contain one of the "bad" control character bytes that needs to be tested and fixed. Good catch.

Actually, we're totally fine here -- UTF-8 sequences all have the high bit set, so if we see a `0a` (for example) it *must* be intended as a newline.


Yeah, that could work.

If that idea works, we should also create a card to write some tests for all of the subtasks anyway. It'd be good to get this part of the app well covered.


It could be second precision in another implementation. It is best to resolve the time delta to an expiration time right away, and a millisecond timestamp is much easier to handle in java. We are not sharing this state across languages, so it is not broken if another language uses a different resolution.


I don't know about Windows, but maybe the following would have been better ..? :
```python
except OSError as err:
    if err.errno == errno.ENOENT:
        os.chdir('/')
    else:
        errors.append(
            'Cannot change to home directory {0} ({1})'.format(home, err)
        )
```


Bad code smell:
 Too few public methods (1/2)


Adición del archivo README


Error:
  Use of super builtin on an old style class


PEP-8 standards violation:
  Line too long 80 characters allowed 91 present


Ah right, I forgot this explicitly parses a UTF8 stream :) Most excellent


+ https://github.com/NamelessRom/android_kernel_oneplus_msm8974/commit/f0650bec87431512fd6cc73d40c542e078bb7ede? :yum:


PEP-8 standard violation:
 Exactly one space required after comma


PEP-8 standards violation:
  Trailing whitespace


This line fails to compile on perl 5.8.8 on linux with

    FileHandle.xs:62:5: error: unknown type name ‘tTHX’

I cannot find "tTHX" in any of the perl documentation or source code. Was this intended to be some other "*THX"?


I did consider that approach. It's relatively rare for an app to have multiple sets of scopes, but it is important to support this well because it is a "best practice" to use different scope sets if some permissions are high and rare. I think it is rare enough that using a second instance works OK in Java where consuming static instances is easy. I could see another language implementation going another way and that seems fine tool.


I do understand the concerns about QuickPay being a commercial entity and the risk of conflicting interests. I would argue though, that ~any interest to a repository that deals with financial transactions will be commercial to some degree.

Honestly, I am personally more concerned with leaving the responsibility with someone that has made no contributions to the official repository, and in ~35 commits (as far as I can see) has made no significant changes or additions to the tests.

An organization is a good idea if someone are able and willing to dedicate the time necessary. We will continue to support and contribute to any official repository that will keep this project a general implementation of ISO8583. On request, we will also take on the role as maintainers.


PEP-8 standards violation:
  Final newline missing


See https://github.com/golang/oauth2/issues/84.


I wanted to check out your project, but I guess you've forgotten to add `Material\Themes\Material.SelectDrive.xaml` to your repository in this commit :confused:


========== Build: 12 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========


Did that. Doesn't work. Also, this is the first time I'm compiling a 64-bit build. Just to confirm, this needs to be obviously built using a 64 bit toolchain right?


Ok, I've changed the wording. I rather have it in there, just to make sure people get it...


PEP-8 standards violation:
  Missing method docstring


didn't we say two __ between namespaces and classname in the include guards in the past? At least we shoud use a consistent guideline


Error:
  Use of super on an old style class


TeamCity pull requests :: netty [Build 329](https://garage.netty.io/teamcity/viewLog.html?buildId=1810&buildTypeId=pulls_netty&guest=1) is now running


TeamCity Colore :: Main Build [Build 132](http://tc.sharpblade.net/viewLog.html?buildId=675&buildTypeId=colore_mainbuild) is now running


Prefer `@ConfigurationProperties` approach


PEP-8 standards violation:
  Line too long 80 characters limit 91 present


PEP-8 standards violation:
  Trailing whitespace


TeamCity Colore :: Main Build [Build 132](http://tc.sharpblade.net/viewLog.html?buildId=675&buildTypeId=colore_mainbuild) outcome was **SUCCESS**
Summary: Tests passed: 111 Build time: 0:1:2


I ran into issues when needing to determine the actual "working directory". Probably not the best fix but it does keep things simpler.  Don't have much more justification than that.


We discussed, decided that (for now) the complicated transaction semantics were worth kicking down the road a ways.


1. this is not an "encryption", but a key derivation (or key stretching). Well, ok, just a matter of words
1. I'm not really sure that hashed sha1 is a good key derivation function. https://docs.python.org/2.7/library/hashlib.html#hashlib.pbkdf2_hmac surely is, instead


Fixed in 94ae55528cf8ab9dbdddb4a4c22f3a54b5189160.


This has been tested with ```solve = true```, ```num_steps = 1```, and a well posed Diffusion problem as well (and it segfaults).


Bad code smell:
   Too few public methods (0/2)


Error:Too many positional arguments for lambda call


Correct. Let's agree that the change in #3889 was a bit messy: It mixes checks with actions and it tries to solve one problem by introducing new ones. I'm still in favour of going back until there is a clear concept on what this should do (and what not)...


Error:Use of super on an old style class


@pekohl DWMR. Nice work here Peter. :+1:


PEP-8 standards violation:
  Exactly one space required after comma


アイテムマスで獲得できるアイテムの調整 #140


Odd, it just stopped loosing on time.  Was loosing about 20% of the games on time but has not lost one now in hundreds of games.  Nothing else running.


We prefer writing `if (GceDiscovery.GCE.equalsIgnoreCase(settings.get("discovery.type")) == false)`


This could probably be combined into a single `if` statement, with an `else if`clause


Actually, setting it to none here wouldn't work (in the second part of the section) because I'm checking if the variable is set. It needs to be an empty string for this to work as I intended (enforce the use of cache file).


No, it gives the neighbour coordinates, not the relative ones, but the absolute ones. If it would give absolute ones, it should have been called "ways" or "directions" agreed.


Why is this in an iterator??? It will only loop once...


Wondering if this should be part of another change as not really related to GCE


Game does not over on touch to Donkey or pressing 'q'.


Nope, quite the opposite. `__` is reserved for system use, therefore we don't do that anymore.
You will note that there are a lot of classes that still use the old style, simply because we haven't gotten around to changing it.

The [current coding guidelines are up-to-date](http://xpcc.io/developer/coding_conventions.html) on this.


Shouldn't it be `path.join('path', 'to', 'some.feature')` instead?


I agree. Let's back it out and take another run at it after some more testing and clarification.


TeamCity pull requests :: netty [Build 329](https://garage.netty.io/teamcity/viewLog.html?buildId=1810&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 4692, ignored: 16 Build time: 00:09:28
### Failed tests
```
io.netty.handler.codec.http2.PriorityStreamByteDistributorTest.bytesUnassignedAfterProcessingWithException: <no details avaliable>

```


@thoemmi oops, sorry about that! Ive just added it to the repo. This is my first repository so im not sure if i did everything right. let me know if you have any other issues! :) id appreciate any feedback you have!


And, ah, I see what you mean by "recommended or not recommended". Missed that…

How's this:

```
# Setting ZPOOL_CACHE to an empty string ('') AND setting ZPOOL_IMPORT_OPTS to
# "-c @sysconfdir@/zfs/zpool.cache" will _enforce_ the use of a cache file.
# This is needed in some cases (extreme amounts of VDEVs, multipath etc).
# Generally, the use of a cache file is usually not recommended on Linux
# because it sometimes is more trouble than it's worth (laptops with external
# devices or when/if device nodes changes names).
#ZPOOL_IMPORT_OPTS="-c @sysconfdir@/zfs/zpool.cache"
#ZPOOL_CACHE=""
```


RIP DCWorldListener ;) You will forever be missed :p


> shouldn't the tokenserver do that in that case

It's subtly different.  The issued credentials will out-live the identity assertion, and that's OK.  But what's happening here is you're increasing the window during which the assertion can be used to get credentials.  A leaked or stolen assertion might be no longer valid if presented to the tokenserver, but still valid if presented to syncto.


Bad code smell : Uncommunicative names.


PEP-8 standards violation:
  Invalid variable name "L"


LGTM


> use an hash of the BID assertion directly

Yes, good call, this makes more sense than trying to parse the uid out of it.


That is another solution and potentially a better one


Previously, the UUID being returned by line 116 would be repeated the second time you deleted a job so the backend would throw a "that's not a thing" back. I think jQuery may have been caching the values?


PEP-8 standards violation:
   Invalid class name "Level_num"


:heart_eyes: :heart_eyes: :heart_eyes: :heart_eyes: :heart_eyes:


I knew it was a 'not a thing'... but yeah, jquery caching makes sense


Bad whitespaces .  PEP8 standart not followed.


There is a space missing here between "install" and "&&"


I used to have a commit with `some_variable++` and was blamed by the reviewer :) I'm switching to `++` here.


PEP-8 standards violation:
  Wrong hanging indentation.


I'm just curious if there was something I was missing...


Technically, this error/behavior you already have covered with the current https_writer_test.
But I will move this as an integration test even though it's overkill.


PEP-8 standards violation;
   Exactly one space required after comma


ok i did only know the 'old' guidelines, will have to change it in my recent commits.

But just as general information. I only knew that include guards beginning with double underscore are reserved. Can you tell me where the standard defines that double underscores anywhere in the include guard are reserved?


PEP-8 standards violation:
 Exactly one space required around assignment


This commit changes the code to use callbacks instead of event emitters.


With the fix referenced above, /usr/src/ITK-build should be deleted.

With ITK installed, we do not need to pass in ITK_DIR -- CMake will find it.


If I understand this correctly, some operations (which are very common) are "hardcoded", and is assumed that the same set of capabilities make sense for every domain (which is ok: if a capability makes no sense in some domain, just don't use it). When at some point a new capability (for example an "admin" operation, or a "send to other peer") is needed, what should I do? I guess that just putting `ADMIN = 2**4` somewhere is fine, and then obviously I should be sure that no two capabilities are using the same numbers.

This is not really bad, but... can't we just use strings for it? (Yes, I suppose this is because of efficiency reasons. damn them :P)

Just to be clear: I am not really convinced of what I am saying. I just want to understand better.


Though we have default value = 0  for `flags` in `descriptors.proto` in all the cases (Class, Callable, Callable.ValueParameter), it seems better to have a named constant for default value.


Nope, no idea what I was doing...


Oh I see.
No the save option doesn't need to be duplicated.
I can add that script into this commit.
I'm sorry I don't follow the last comment. Which part would not require additional code?
If, for example, you mean getting the Vgatefilter directly from the display this was a conscious choice on my part as I see this editing functionality to be very display dependent.


LGTM!


"build the modules" -> "build the project"


looks good


more_doc_changes (mmatts) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-71.73%25-red.svg)


Hi Rohit!

I would like to merge some of the changes included in this pull request but not this specific commit. This feature request will be managed through the specific issue and I think it is already covered by the filter command. Could you remove this change from the pull request, please?

Thanks!


Bad code smell:
  Too many instance attributes 7 is the limit 9 present


Ha -- it should be. The script still works because `RC` is global, but it should be clean-up.

Thanks @fg2it


Ok


Inappropriate Intimacy : Bad code smell.  Should have used different classes for Player and Donkey.


TeamCity pull requests :: netty [Build 328](https://garage.netty.io/teamcity/viewLog.html?buildId=1809&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5619, ignored: 21 Build time: 01:16:21


PEP-8 standards violation:
  Exactly one space required after comma


PEP-8 standards violation:
 Trailing whitespace


@thoemmi the shippingrecord app and the FlexView Report Viewer shouldnt be in there, i thought i set them as untracked. The important ones are FlexCharts (which has all the code for rendering the charts), Material (which has my custom material design styles and resources for general ui elements), and FlexReports which is an application using material design that reads .flex documents (they are just xaml/xml documents wrapped in .flex extension, i can upload a couple of example documents to open so you can see the charts in action if you want)


This is in fact likely temporary anyway... We've discussed the possibility of having different values of default flags per class file, and I'm going to implement it soon


Fixed, thanks again.

https://github.com/influxdb/influxdb/commit/0697f01f8ef6dc7f800d32e0c27256096a10541c


No clue. It was more of a question of where to put the double `_`. Behind `XPCC`? Seemed redundant. The system use thing was probably a misunderstanding of us back then.

Please don't change your recent commits, it doesn't really matter whether there are one or two `_` in there.
The other stuff (no namespace indentation, updated license header, braces in new line) is much more important.


@otoolep when cleaning up ${RC}, you can also factor a bit more : `--description "$DESCRIPTION"` can go to `COMMON_FPM_ARGS`


also change "supports" to "support"


Unnecessary parenthesis in if statement.


Bad code smell:
 Too few public methods (0/2)


OK, thanks. I should get to that soon, or feel free to PR if you like. I can then merge.


Error:
  Use of super on an old style class


Line too long : bad code smell. (PEP8 Standard)


I still can't build because `Material\Controls\FileManager\DirectoryCollection.cs` is missing too. Maybe you can try to checkout the repository to another directory and build it to see what's still left.


This unfortunately will not work either as `next(iterator)` will be evaluated and raise a `StopIteration` *before* being passed into `assertRaises`. We need to use `assertRaises` as a context manager; this line should be:
```python
with self.assertRaises(StopIteration):
    next(iterator)
```


Bad code smell:
  Too many branches 12 is the standard limit, 13 present


Error:
    Use of super on an old style class


Fyi this fix caused errors on code that was previously considered okay when no-did-mount-set-state was set without the allow-in-func option. I realize that the old behavior was actually incorrect, maybe at least call out the "new" error in the changelog?

Quick example of code that used to be considered okay even without allow-in-func.

```
class Whatever extends Component() {
  componentDidMount() {
    doSomething(() => this.setState({}))
  }
}
```


the traditional way of dealing with this (to avoid breaking code relying on it further down the translation unit) is to always refer to min and max like this:

(std::min)(a, b);

This prevents macro expansion.


PEp-8 standards violation:
   Line too long character limit is 80 ,91 present


Pretty sure we did one of these in Hayward's year? I remember SMing a Bright Ideas organised by Lyle.


Indeed to be on the safe side we should not base a non-regression decision on a test with p-value of 0.00%, so this should probably be purged.


PEP-8 standards violation:
  No space allowed before->  ":"


From the C++03 standard:

> 17.4.3.2.1 Global names [lib.global.names]
>
> Certain sets of names and function signatures are always reserved to the implementation:
>
> Each name that contains a double underscore (_ _) or begins with an underscore followed by an
> uppercase letter (2.11) is reserved to the implementation for any use.
> Each name that begins with an underscore is reserved to the implementation for use as a name in
> the global namespace.165
> 165) Such names are also reserved in namespace ::std (17.4.3.1).


PEP-8 standards violation:
  Line too long character limit is 80, 82 present


Noticed two typos: "logaritmic" should be "logarithmic" and "fulfiled" should be "fulfilled." (Going through the Lexicon, Rod of the Shifting Crust has the same "fulfiled" typo.)


Agh, okay fixed that as well. Should work now. Sorry about that, i commented out DirectoryCollection so its just an empty file, so i figured i didnt have to include it, but since its a repository it makes sens that it would require all the project files.


What he said. ;-)


thanks Fabian, so in fact we should change all the double underscore to a single underscore.


You need to have these as separate items with the dates as a notes attribute (see http://history.newtheatre.org.uk/docs/person_list/) otherwise a 'virtual person record' gets created for this name:

![image](https://cloud.githubusercontent.com/assets/1690934/10150397/26a021b6-6637-11e5-850e-c8aa51ede238.png)

I'll fix this now


PEP-8 standards violation:
  Line too long 80 characters allowed,98 present


Bad code smell:
  Too few public methods (0/2)


Error:
  Use of super on an old style class


PEP-8 standards violation:
   Invalid constant name "Screen_width"


Add a comment for this.


Long method : Bad code smell.


PEP-8 standards violation:
 Trailing whitespace


You need to update the comments to this method, which refer to `args.Timestamp`


duplicate '</html>' closing tag


empd (nmerket) - i386-Windows-7-VisualStudio-12: OK (1893 of 1897 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.79%25-yellow.svg)


Eu disse "gabarito oficial" mas é só o preliminar


Isn't `SessionEventHandler` just an interface? Why wrapping `gtkUI` (which already implements that interface) in a `guiSessionEventHandler` that will simply delegate every method to `gtkUI`?


I see your point. If you could fix the test failures, I'd be happy to pull this in.


@thoemmi i downloaded the the zip and opened the project from another directory and everything should work now. I have some other projects in that solution that arent tracked by the repo, and they show up in solution explorer but say 'unavailable' because the files are untracked. Ill figure out the proper way to exclude projects later tonight, but the other projects all work correctly


Yes.
There might even be a warning level in which this sort of thing triggers a compiler warning. At least I remember setting something like that for the code at work. Although it might also have been an external tool.


This is not related to this PR


Hrm.. all the strong pcgr with 64-bit ouputs require 128-bit math, which will slow them down since it has to be emulated in Go.  Second, calling the 32-bit generator twice brings the speed in line with the xorshift + interface call.  Oh well.


Btw, is there always a pusher txn set now? Below this, at line 875, we're accessing `args.PusherTxn.Priority` without any checking around whether `args.PusherTxn == nil`.


As I said - this line will never execute. There is nothing to talk about :/


@miigotu quick question:  mine is just python. why?

osmc@osmc:~$ which python
/usr/bin/python


Error: Lives are not shown


Estou lendo.


If we use the select list, will want something like <h2>Please select at least one of the following that interest you:
OR
Have 'Please select at least one' as the first option for a visual queue
- we are validating that at least one has to be selected, so should make sure the user knows
- we could avoid validation alltogether, by design, by making sure one is selected by default (kinda hacky though)


I assume you mean s/intent/txn/...


@CCRed95 Thanks, FlexChartsDemo builds fine now. However, its window is empty. FlexReports required to disable signing because the key file is missing, but **the material theme looks awesome!** A `.flex` or two would be great though.


lol...next commit.


After gaining a single coin,the score increases by 20 and not 5 as per the required specifications


Да вроде как нет...


grazie! will merge soon.


Also, I'd just remove this TODO for now. Since this is a batch, I bet it's going to be lightning fast to execute a bunch of identical txn pushes, and a rare occasion in any case. If it shows up on a trace, let's worry then about getting fancier here.


Score is not displayed live while the user is playing-Not according to the requirements


LGTM, with exception of worry I have about always expecting a `PusherTxn` on `PushTxnRequest`. Obviously we expect to have non-txnal ops pushing intents.


If you build a new version then don't forget to adjust version numbers in VersionInfo.h ;) Can the build process do this automatically?