@RideShare-OZ-orange suggest extracting this out to a method: `Ride[] data = createDummyDataForListView()`


bullshit


Commented out code


Yes I think a struct is a cleaner way to represent the "notification" property.

The only issue in your struct is unexported (lowercase) fields of structs cannot be converted to json using json.Marshal.


@RideShare-OZ-orange extract this block out to a separate method. Keep methods concise to improve readability.


This expression expects an integer, but we don't enforce that. You could, however, add a test in the validation phase on whether these two parameters are numbers (you can use ocf_is_decimal).


The query at L167 and L174 is basically the same, except for the `TEMP` qualifier in the create statement. We could probably reduce the amount of redundant code here by conditionally inserting the `TEMP` qualifier via string substitution/formatting (e.g. `'CREATE {temp} TABLE ...'.format(temp= 'TEMP' if self.copy_to_temp() else '' ...`)


could also be extracted. Really long method


What is this sleep for?


comment probably not needed. Clear pattern.


ow so they should all be capital case? seemed to worked though?


@RideShare-OZ-orange looks like this code was possibly copy pasted. Also seems like there is duplication with another class. Suggest you create a utility class to handle URL connections


This line is not good, you shouldn't use it directly should using Util class to get this param, please update this line


What will you do on this line???


```js
data = data.filter(function(el){return el[1] !== nickname;});
```


@RideShare-OZ-orange hyper abbreviated variable names are bad for maintainability. Suggest startLatitude etc.


In this example I use the `rag_mean_color()` and the callbacks from the `RAG Merging` example in the gallery.   I did this thinking familiarity with the other RAG examples in the gallery and to keep the example code short.   Instead, would it be better to use `region_adjacency_graph()`, so will need another callback?    Similar to the original paper on Selective Search (referenced in the example) should I use other similarity measures, say based on colour, texture, fill and size?  These will make the example longer, but potentially more useful to others,  and will also need some supporting functions like `histogram_intersection` to calculate the weights.  Thoughts?


suggest `isRideOffered` and delete comment


@RideShare-OZ-orange suggest following MVC and separate view from rest of code.


I am happy to fixed this problem. i also have some installation problem in my desktop so on behalf of me ashik add it to project.


This is a local variable. Please use a lower case name and set its scope to local (i.e. local lm_pid).


@RideShare-OZ-orange overly long method. Suggest extracting out code blocks to separate methods as per Robert Martin's clean coding principles.


@RideShare-OZ-orange suggest you use command pattern


Sorry, i fixed it


@RideShare-OZ-orange possibly overly verbose. Can you convert it all to a POJO and do jsonResponse.results[0].geometry.location.lng?


А смысл этой конструкции? Зачем было создавать дополнительный контроллер, почему в роуте не прописать например root 'products#index' ?


use `sio.sockets.sockets` (or something like that)


Have switched to use `facilities.length` - seems good enough.


@RideShare-OZ-orange can we put the key in config somewhere?


I think we discussed to name the attribute `type`, instead of `engage`, so we are more flexible with future types of comments. Can you change it?


@RideShare-OZ-orange comment but no executable code?


Чисто замечание, везде в туториалах советуют отказываться по возможно от использования .all


What's the use-case for this feature?

New features should be documented somewhere, no?


The .c and .h files generated do not include the license header. The files have the table below i.e. the arguments used for the generation.


@RideShare-OZ-orange can you use an android debugger rather than sysout


sysout -> android debug


@RideShare-OZ-orange why 111?


@RideShare-OZ-orange magic number?


When will the next build come out ?


@RideShare-OZ-orange magic string? Can you make this a constant so it's more clear?


if it should only apply in qa case then check first if its a qa cloud


The data_value.flags.bytearray_length or data_value.flags.string_length might be uninitialized now at some bits. A `data_value.flags.bytearray_length = 0` might be missing between these two lines. This would be a task for `zero_value()` to call `zero_match_flags()` internally.


@RideShare-OZ-orange suggest extract this out to generateHumanReadableDate()


`if ( is_main_site() || !apply_filters( 'mus_remove_user_menu_from_subsites', false ) ) return false;` give option to show/hide user menu


And there is no readme or license file generated at all? Please share the generator output files with me via email, thx!


Is `copy_to_temp` meant to be nested within `do_truncate_table`? When used att L166 `copy_to_temp` is implied to be accessible as an instance method.


And need some fix for allowed character when saving class ....


TeamCity pull requests :: netty [Build 379](https://garage.netty.io/teamcity/viewLog.html?buildId=2107&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4777, ignored: 21 Build time: 00:30:28


@RideShare-OZ-orange duplicated code. Extract to DateUtil.addLeadingZeroIfRequired() ?


@charlesflynn unused property


if i remember correctly those addons were unprecise and just calculated a rough estimate based on damage done between % changes


ugh, sorry, it's fixed now


:ok:


You should retrieve the classes from the generators, not repeat the properties here.


@RideShare-OZ-orange will we use Dynamo DB or something similar? I've heard mongo db can be pretty hard to manage on your own especially once you start scaling


Did you try this code? At first show user menu in sub sites. Then install User Role Editor. If you change or add or remove user role in one site ( main site or sub site ) via User Role Editor only primary role is synchronized.


Hi Chenryn,

It's maybe not support [logstash-]YYYY.MM .Plz check it...

Regards,


@RideShare-OZ-orange suggest remove debug code if not required


Eeeeks.


Why?


Very cool :+1:


Assignment Branch Condition size for message is too high. [15.07/15]


Redundant use of `Object#to_s` in interpolation.


Assignment Branch Condition size for message is too high. [19.44/15]


Line is too long. [101/100]


Assignment Branch Condition size for role_changed_notification is too high. [25.26/15]


Prefer single-quoted strings inside interpolations.


Line is too long. [120/100]


@RideShare-OZ-orange indentation seems incorrect. Also naming style inconsistent. Camel case or snake case?


好了，我这边差不多也玩了，最后就是修改app/bbupdate.xml 下面的文件了，决定最终版后，就把下载链接添加进去（github 里面的release是用的亚马逊服务器，有点慢，所以还是先上传到国内的服务器上吧）


Is this used anywhere besides the test ? If not, maybe it should be moved to test-src


@RideShare-OZ-orange am unclear what this module does. Can you add a module level comment explaining the purpose of the module?


@RideShare-OZ-orange commented out code


Fixed, thank you!


#Test for Markdown
##first rule
**douple stars means bold**

##second rule
*one star means italic*

##third rule
Hi, this is sample.


@RideShare-OZ-orange what JS coding style do you follow? I find it a bit cramped not having any whitespace between operators.


@aneesh-neelam: using replace here with that regex is causing the space between the first and last name of the  student to be replaced too. That was why I didn't use it in the first place.


Why can't we use both the key of the sender and the one of the receiver as keying material (as I did with this very implementation)? Both clients should know both keys after the initial handshake, and it might improve security a little since an attacker has now to sniff two values to operate.


It is: https://github.com/webdetails/cda/blob/master/cda-core/src/pt/webdetails/cda/settings/CdaSettings.java#L292


I would not mention "CD" installer, but just "installer"


@RideShare-OZ-orange suggest this code is extracted to a method handlePassengerQuery to enhance readability


@Kail72 can you please specify the needed changes?


Hi @apollonono. Sorry for the late reply.

To use this project, you must do the following, in order:
1. Download some linux distribution for the Rpi and flash it to an SD card. You can use stock Raspbian, but you'll most likely prefer [Octopi](https://github.com/guysoft/OctoPi), as that comes pre-configured to host a web-based print server.
2. Clone this repository onto your Rpi.
3. Create a new configuration file in the cloned repository that describes your 3d printer. See the [Configuration Files](https://github.com/wallacoloo/printipi#configuration-files) portion of the readme.
4. If you haven't already wired the stepper motors/fans/heater/thermistory, etc up to the Rpi's gpios, do so and follow the pin definitions you defined in your configuration file.
5. Compile the firmware. This is also explained in the readme, and the Configuration Files portion should explain this as well.
6. Run the firmware. This is explained in the [Usage](https://github.com/Wallacoloo/printipi#usage) section of the firmware.

Sorry I cannot give you more specific instructions. Since there are so many different 3d printer models, it's hard to make a one-size-fits-all guide that's very specific.


Why... not?
Infact I tried something because the cursor is a little buggy when selecting another Pokémon than the current one.
It didn't worked, but I left it! ;D


@RideShare-OZ-orange add newline to final line


@troyliu0105
OK~ 哈哈 坐等你了就


@RideShare-OZ-orange newline at end


why "&" ? why not "&&" ??


@RideShare-OZ-orange avoid hyper abbreviating. e_lon is not immediately obvious. Suggest end_longitude

Also follow consistent coding style - whitespace between operators.


@RideShare-OZ-orange space between operators


> @hasufell nah

important RDEPEND changes need a revbump, otherwise you are not propagating the fix properly to users VDB. Please read the threads about dynamic deps.


I can't remember that far back in time what I was thinking.


@RideShare-OZ-orange inconsistent indentation. Suggest you use JSHint + JSCS to configure coding standards


MouseTackle
A Javascript Based Cool Puzzle Game
FF, IE Versions will be supported sooner...


npm install (for node-hyperplane), npm run dev, npm run demo-api, http://localhost:3000/red


The code seems good; however, to keep patches clean and easy to read we should avoid mixing code refactoring (such as variable renaming) with other operations in the same commit.

I'll merge your commits soon! Thanks @c-tek


@RideShare-OZ-orange suggest you delete comment and extract code to a method with a descriptive comment deleteTheUserFromRequest()


if we're not using `otherDelegate` this should be `_`


Pull request send that GSOD error is not possible anymore


sdasdsa


@RideShare-OZ-orange delete all commented out code


@RideShare-OZ-orange indentation


Luckly I grew the habit of encoding exact JTS revision each file was ported from, but that GEOS_JTS_PORT number is really exposed to clients (those who wants to know). Better take it back, both in 3.5 branch and trunk. Can you do that please ?


@RideShare-OZ-orange code cramped.


@RideShare-OZ-orange excessive whitespace. 1 line max imo


We should have a helper for this, it's really verbose (compared to Unsafe which is half the code).
Something like UnsafeHolder.fieldOffset() but returning a MethodHandle.


If the constant is already inside a class called computer you don't need this prefix, you could just do MOVES


Should the post-copy query/queries be executed before of after the prior transactions have been committed, or should this occur prior to the commit at L207? Similarly, if the post-copy query/queries are unsuccessful, would we want the prevent the marker-table update from occurring, as the marker-table update occurs beforehand at L206?


Thumbs up. Planned to ask u yday ab it :)


ewefewasfasfas


fsdfsdfsdfsdfs


> Why policy CMP0020 is enabled?

Again, just from reading recommendations from various places or warnings I saw when testing.

```
CMP0020
-------

Automatically link Qt executables to qtmain target on Windows.

CMake 2.8.10 and lower required users of Qt to always specify a link
dependency to the qtmain.lib static library manually on Windows.
CMake 2.8.11 gained the ability to evaluate generator expressions
while determining the link dependencies from IMPORTED targets.  This
allows CMake itself to automatically link executables which link to Qt
to the qtmain.lib library when using IMPORTED Qt targets.  For
applications already linking to qtmain.lib, this should have little
impact.  For applications which supply their own alternative WinMain
implementation and for applications which use the QAxServer library,
this automatic linking will need to be disabled as per the
documentation.

The OLD behavior for this policy is not to link executables to
qtmain.lib automatically when they link to the QtCore IMPORTED target.
The NEW behavior for this policy is to link executables to qtmain.lib
automatically when they link to QtCore IMPORTED target.

This policy was introduced in CMake version 2.8.11.  CMake version
3.3.2 warns when the policy is not set and uses OLD behavior.  Use
the cmake_policy command to set it to OLD or NEW explicitly.

.. note::
  The ``OLD`` behavior of a policy is
  ``deprecated by definition``
  and may be removed in a future version of CMake.
```


> BTW, I guess these 2 elements are kept for backward compatibility so that a XAR created with a new version of XWiki can be imported in an old XWiki version?

Yes.


I think I was thinking about this ticket -- https://trac.osgeo.org/geos/ticket/627  that's why I upped the number.  Didn't Vishal port these from JTS?  Commits so far: r3849 r3862 r3899 r3912 r3944 r3951  or how does that work.  It's my bedtime so I'm hitting the sack now.


For all I can see, the only effect this change will have, is enable git push to work in a freshly cloned riak_ql (which would otherwise require fixing git url in .git/config manually). Is there some other effect I can't see?


This has to be reverted for the demo, unfortunately.


Sorry for deleting the branch you had commented.

In your last comment, you asked me if it was possible to authenticate the user using cookie even if the domoticz server was restarted ?

Yes it is possible if you save/reload username/sessionid pairs. But if you make it you will always use the same session id, so it will be predictable.

Session Id should be used to avoid to authenticate on all resquests and to keep a user context on the server side, but it cannot be used to replace the username/password authentication all the time.

Session Id should expire shortly like a day after. Your cookies expire a year after session id creation, what is a very bad idea (it should be considered as a critical security issue).

For all users who don't restart domoticz everyday, it will be transparent because of the expiration date fixed to one year after.


This caused the misleading mistakes. Be careful!


Voronoi is actually from JTS-1.11.

To be honest, this whole JTS tracking thing is loosing his meaning as we do partial ports...


You can't use ``unicode`` on Python 2 and 3. Maybe try:

```
from Bio._py3k import unicode
```


Yup! This is the proper fix. Thanks for tackling that Jim and keeping me honest. :)


I guess right now it should track the version of JTS that was last _fully_ ported, or something like that (but then 1.12 would have been wrong as there was no Voronoi, but I should check the value of that variable in GEOS before Voronoi was ported)


You can simply write:
```
BH_LOG(get_logger(), DNET_LOG_INFO, "Loaded config from %s", m_config);
```
Blackhole will detect ```m_config``` has ```operator <<``` and will use it to make log-string.


GameFifteen.Console.Styles - 100% test coverage


this is initial from me :)


This commit looks good to me.


Also did a renaming on the project from "EmployeeOverview" to "Alzheimer"


that's wrong, working on it


Ahso, mit einem Script geht das natürlich :+1:


If you don't implement them, I will! :smile:  I think it should actually be relatively simple if you only need to worry about LibGDX, since the LibGDX implementation has a few ways to trim down an item's area and display two graphical things next to each other. Everything in the LibGDX implementation uses Scene2D (a libGDX GUI thing), so it shouldn't be too hard to just stick two SquidPanel or SquidLayer objects at different locations on one Stage (the parent of all Scene2D widgets), or in one Group that gets put on the Stage as one item. More interesting to me is the part-of-a-cell-offset for SquidPanels. I've considered using two additional panels over a normal SquidLayers, one offset a half-cell vertically and the other a half-cell horizontally, along with box-drawing characters to handle thin walls (occupying the edge between cells instead of a full cell). Panning the visible subset of a map also seems handy, and it seems to be a very, very common feature in newer tile-based games; I think only some roguelikes and some puzzle games routinely get by without it.


At first yes. But as the Blizz API evolved, I think they start sending real values. When I worked on fixing NPCs stats, I found videos with those addons were correct values were displayed, not an estimate.
Also, I don't know for sure for Classic times but currently health values are sent and displayed in sniffs.


Hi Lucas,

It took me forever to fix it (I didn't realize I need to reinstall the
library to test it so I tried millions of times hundreds of different ways
and always keep seeing the same error). Also, it have been a little crazy
as it my last week of bootcamp, I have a demo day on Friday and got a
freelance.

Now, all tests succeeded on Python 3.4 and 2.7

Let me know what you think and if is there anything I could make better.

Thanks

Victor Menezes
"Geek by nature, Linux by choice"

On Tue, Sep 29, 2015 at 5:58 PM, Lucas Connors <notifications@github.com>
wrote:

> Hey Victor, I just took a look and I think what is giving you trouble is
> that the UploadUsers method in the GitkitClient class in gitkitclient.py
> uses a map function. In Python 2 map produces a list, but in Python 3 it
> produces a generator (a map object in this case).
> This is causing the assert_called_with to fail since it is expecting a
> list, but in Python 3 it receives a map object.
>
> I see three possible ways of fixing this:
> 1. Change the unit test so that it expects a map object instead of a list
> (for Python 3). You could do this by wrapping the list in a map function
> with a lambda function that does nothing.
> 2. Wrap the map function in UploadUsers in a list, which forces Python 3
> to produce a list.
> 3. Change the map function in UploadUsers to list comprehension, which
> will produce a list directly instead of a generator.
>
> There's no performance benefit in using the generator in this case, since
> the map object will be forced into a list by a JSON library downstream, so
> we should go for what is most readable. Personally, I prefer option 3.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vmenezes/identity-toolkit-python-client/commit/1c7c80deac635bf6cc548418ffa8ba29a0521ffe#commitcomment-13504504>
> .
>


`git cherry-pick -x` please.


Good question. @tombentley?


this looks OK, but I'd rather this move to the package where it is used, and private. We don't want to create extra API surface


hehe, yes it was and then the merge was reverted to put it back in. By having those commits in the history it is possible to merge from master to next without removing wk2 again


The operator is used to log config, therefore it is not really good to use multi-line print cause this log cannot be easily grep.


Hmmm, do I understand correctly, that a registered query `foo` will appear as a global `foo()` function in Python? If so, then I don't quite like this. Can't we put the queries in a specific namespace/class? e.g. `Queries.foo()` or something?


Was an update anywhere? I didn't know. Sorry. I'd have to look at master
first.

On Wed, Oct 07, 2015 at 02:35:18AM -0700, Eelco Dolstra wrote:
> `git cherry-pick -x` please.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/NixOS/nixpkgs/commit/f2264ec42a9792091639eef1050b08403f368ff2#commitcomment-13634328


Shouldn't be >= 180?


Lesha, have you look at my attempt to create Unit Test?
Is it right approach?


having the possibility to add some css class in the different div should be a kernel feature.
most template systems do it like that (eg: most yootheme or gavickpro template for joomla).
So, I think this feature goes in the right way.
Soon I'll move to the survey template, so I'll can see in detail if there is a better way to integrate it.


So here, we should use something else, that is not the main namespace.


To use ```std::ostream``` you should include ```ostream``` instead of ```iostream```.


LGTM


@RideShare-OZ-orange would be great if you could add unit + functional tests across the board. Team Yellow included some automated tests so maybe you could ask them if you need help.


It looks weird all members are initialized in intialization list but this one is in constructor's body.


comment should refer to boolean and not numeric values


Checkmarx scan results 07 Oct 2015 12:29 UTC +03:00

High
Medium
Low
Info

New
36
31
39
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

19a974971b960a93fd9db110981376e4a81c8bfb	@dudug


What is the set of all *view* rules? I'm pretty confused and not sure what do you mean :wink:
If I properly understood, you've set some rule for **test** access level users and admin has limited view for that set, but does admin have it's own rule?


Having done the discussion of the PR this commit should be squashed with bde03ab639c23be3a0f41dd2b4d36fe6e35fa3d0


This error cannot happen because creating a trie with the empty hash is always ok.


I'm not sure I understand why this change is an improvement, maybe having both variables (`include_sentinfo` and `include_lastupdate`) would be clearer?


Same here, can't happen.


Please revert this change


I also believe that the offset features is useful. Brogue uses that a lot, and I'm doing exactly what you describe to show the inventory at (1,1) offset from the map's top-left:

![capture du 2015-10-07 11 40 46](https://cloud.githubusercontent.com/assets/634720/10334122/76520226-6ce8-11e5-8866-280b8e585828.png)


Please keep the error logging.


Interesting :+1:


TeamCity pull requests :: netty [Build 381](https://garage.netty.io/teamcity/viewLog.html?buildId=2109&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4775, ignored: 21 Build time: 00:54:34


You can simply use ```status.toString()``` rather than ```status.toString().c_str()``` blackhole will handle it.


Done in latest commit


Should this be called something a bit more specific than 'date', like 'created_at' or similar?


I found I overlapped the head node


Added modified link as that one placed me in a weird position in the docs and also copied in other attributes for quick ref.


You have to deinit inited resources here manually or you can use RAII for this purpose.


@flavour Please review


Why would not call ```stop_mongo``` and ```stop_curl``` in destructor?


which means its not valid to apply negation with non-null belief, we can probably make it a property of TruthFunction, but removing this checks is not a good idea..


Many lines break your own style guide (100 chars per line). The code blocks here on Github are not even wide enough to fit them, make it painful to read...


@obscuren This is one of the places where this change is actually useful.
Consider a full node that is at block 33000 but only has state roots starting at block 30000.
If someone requests a state value from block 20000 (for which the node doesn't have the state)
you'd rather make that visible somehow and return a proper error.


something to change?


The variable name for the json key is `GCLOUD_TESTS_KEY`.


It's better not to seed the numpy rng singleton (as it it is not thread safe to do so) but instead use your own RNG instance by calling `rng = check_random_state(self.random_state)` in the `fit` method of the estimator. See:

http://scikit-learn.org/stable/developers/#random-numbers


Changed


Does ```Discovery``` is the one object for the whole application?


Hi - really appreciate your work on this plugin. Would it be possible for you to start tagging stable versions of this plugin so it is easier for users to manage Composer stability requirements?


I think I should comment that this code is unreachable.
The program is compiled with ```-Wall```, so if we miss an enumeration value we get a warning (```-Wswitch```).


Checkmarx scan results 07 Oct 2015 11:39 UTC +02:00

High
Medium
Low
Info

New
72
61
70
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

5036e2ca99e2863a443b2404ebbe984af70ee251	@dudug


here is a space missing ;-)


You use the method that has not beed introduced yet.


change something?


Could you please provide an example line where usage of these enums is unclear?


hi, yes i didn't mean to push this also, reverting


There's undoubtedly a reason, but I don't think there's a *good* reason.


+1 :+1:  :cool:


OK, let's fix it.


it is an error in a style guide. It should be 160


Didn't I ask whether this was side-effect free?


Please revert this one.


Those videos are from when people were playing classic with the TBC client, I think.  As in, right before TBC was released.


Fetch and update is not atomic. Some other instance may pick up same jobs.


Do we want a column for comments on whether it includes audio library's etc?


Why not bring that above the if: ?


adding something?


Is it too late to change it if there's no on-purpose reason?


I don't see any need to use rows_ or row_ here
So use the more usual version


Exception thrown in one job will cause all jobs to be cancelled (?)


What is the purpose of the orderby here?
You go through every row anyway & the order doesn't seem to matter?


import inside the loop? ;)


Please restore this in flags.sh to avoid the warning on Go 1.5.


This is doing nothing but repeating what the model already has


& repeated again here?


Can we enable it if cmake version is >= 2.8.11 and use a workaround otherwise?


I separate sections of methods or data members with access specifiers. You must have noticed dozens of them in my code, don't think anybody will be confused; furthermore, I guess any of those sections fits the editor window.


@diogofscmariano we need asserts here


lgtm r+


@eneim What about the second question?


for a captcha it makes more sense to default to `required: true`


Reading through that conversation in the ticket, shouldn't it be

```
return $server->getImageResponse($this->request);
```

?


@petersgiles

 1. they were never intended to be used in downstream repos. they should really only exist in the code
 2. even in the core we found them to be too fragile since they rely on the structure of the pipeline which regularly changes.

so die they must


Primer avence del archivo de registro:
-Objetivos
-Resumen
-Justificación
[Proyecto.docx](https://github.com/kavilac/Proyecto/files/9728/Proyecto.docx)


Make a case class for the return type: case class WebsitesForSoundcloudId(soundcloudId: Long, websites: Seq[String]). And rename the argument as soundcloudIds and getSoundcloudWebsites(soundcloudIds: Seq[Long])


**Code Organisation - Nitpick**

This script should be names `utils.js`.


to review together


inline the two vals


uppercase


Lectura de archivos Fasta
[ArchivoFasta.cpp.txt](https://github.com/kavilac/Proyecto/files/9729/ArchivoFasta.cpp.txt)
[ArchivoFasta.h.txt](https://github.com/kavilac/Proyecto/files/9730/ArchivoFasta.h.txt)
[main.cpp.txt](https://github.com/kavilac/Proyecto/files/9731/main.cpp.txt)


space


done


Clearly the existing logic was wrong, but I find it strange that we don't have "Mobile bookmarks" and "Desktop bookmarks" at the same level of the tree.  There's some product decision in the mists of time, right?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21996/testReport/) for this commit**


@confile Basically, it is the same thing with updating the Adapter data. Meaning that you only need to call
```
arrayAdapter.notifyDataSetChanged();
```


@skorlir yah thanks, these don't seem to work. Various complaints from the system, assume I am doing something stupid from not knowing all these libraries. Did you run it?


Make a methods to save a set of tracks


Non il doit être au courant de "modifier sa réservation" et "faire une réservation".


Mmm, double ??.


Why is this not uniform across "Mobile bookmarks" and "Desktop bookmarks"?


Remove `type` parameter?


Oh, that's why.  Disregard comment for previous commit.  Fold this in perhaps?


Can this special label go?


LGTM.


LGTM


So what made it work now, while having problems before?


@skorlir: I think the problem is sending an array to Minimatch:

```
  self.minimatch = new Minimatch(pattern, options)
```

It chokes on an array.


Much better :+1:


build break!


Tried it with PHP 5.5.27 (cli) and PHPUnit 4.8.9 and it still failed for me :P


This should actually be corealloc.o


Oops, I'm not opposed to dropping this random line though...


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21997/testReport/) for this commit**


I'm always scared to edit this mess tbh


Yeah I have been trying to figure that out. It seems like JavaDoc doesn't show annotations? I think it might be for Android Studio warnings.


@flavour This would convert the type <list> as
```[{"prop": "priority", "fill": "FF0000", "fillOpacity": 0.4, "cat": "Urgent"}, {"prop": "priority", "fill": "FFA500", "fillOpacity": 0.4, "cat": "High"}, {"prop": "priority", "fill": "FFFF00", "fillOpacity": 0.4, "cat": "Low"}, {"prop": "priority", "fill": "222222", "fillOpacity": 0.4, "cat": "-"}]```
to type <tuple> as
```[[{"cat": "Urgent", "fill": "FF0000", "fillOpacity": 0.4, "prop": "priority"}, {"cat": "High", "fill": "FFA500", "fillOpacity": 0.4, "prop": "priority"}, {"cat": "Low", "fill": "FFFF00", "fillOpacity": 0.4, "prop": "priority"}, {"cat": "-", "fill": "222222", "fillOpacity": 0.4, "prop": "priority"}, {"cat": "test", "fill": "ffa500", "fillOpacity": 0.4, "prop": "priority"}], null]```
so I converted to string using %s?


@flavour
In sqlite and mysql this works fine because ```style=IS_JSONS3().formatter(row.style)``` gives type <str>

But in postgres, this gives me ```TypeError: expected string or buffer``` because ```style=IS_JSONS3().formatter(row.style)``` gives the type <list>, so I had done that db check previously?


Version 3.6.3


asasas


qwqweqew


It looks like `flagGoPointers` is no longer used (/ honored) as a result of this change.


So actually, I had thought of that:
  // Also, we interpret the rv value as unsigned, but let's be honest:
  //   if it is negative, that means it's huge, and just set to 0.

And then I figured I’d leave the two separate just for clarity instead of putting a huge comment there. Since I was not, in this version, going for best code generation, I didn’t think it would matter.

When looking at the code that LLVM generates, it does exactly what you said directly so I didn’t see the need to change it here:
; Function Attrs: nounwind readnone
define i64 @shl(i64 %"$x", i64 %"$y") #0 {
entry:
  %0 = icmp ugt i64 %"$y", 63
  %shl = shl i64 %"$x", %"$y"
  %.shl = select i1 %0, i64 0, i64 %shl
  ret i64 %.shl
}

The only one where it has more difficulty doing anything about it is the shift right signed. So I might go and fix that anyway ☺

Thanks for the review ☺
Jc

From: Dan Gohman [mailto:notifications@github.com]
Sent: Wednesday, October 07, 2015 4:40 PM
To: WebAssembly/wasm-to-llvm-prototype
Cc: Beyler, Jean Christophe
Subject: Re: [wasm-to-llvm-prototype] First commit of the project. (b0ef7e8)

Just a random drive-by review comment here: It's possible to eliminate the amount < 0 check here by doing the amount >= value's width check as unsigned, because a negative signed value becomes a very great positive value when interpreted as unsigned. This is also aligns with the wasm design text which describes the shift amount operand as being unsigned.

The same goes for the other shift operators too.

—
Reply to this email directly or view it on GitHub<https://github.com/WebAssembly/wasm-to-llvm-prototype/commit/b0ef7e8dcb397ad9a1e26e10686e0cbb15696755#commitcomment-13652021>.


Makefile.in is still flakey. I will tweak it. I thought the problem was the recursive dependency generator but it was totally unrelated.


Nice


Ooh. Yeah. This was *deliberately* deliberate in that case :wink: :speak_no_evil:


Consider:

    config = &Config{}


I don't know?! I guess the patch was to fix errors when events didn't have the files field yet. I can't really explain the stupidity. I would like to express my apologies and the hope that I'm not usually like that.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21998/testReport/) for this commit**


Should be fixed by https://github.com/amitava82/angular-multiselect/pull/64


Damn it feel good to be a gangsta


I tryed this but it turns our that I have to calll refresh() otherwise the cards which are currently on the screen are not removed. You can see this with my demo.

By the way I found another solution to the OOM problem. You should not use a placeholder image. It is better to use no placeholder or a color. In this case the error was gone.


Done in the next patch I upload. Now shr also generates the same:

; Function Attrs: nounwind readnone
define i64 @shr_s(i64 %"$x", i64 %"$y") #0 {
entry:
  %cmptmp = icmp ugt i64 %"$y", 63
  %iftmp.v = select i1 %cmptmp, i64 63, i64 %"$y"
  %iftmp = ashr i64 %"$x", %iftmp.v
  ret i64 %iftmp
}


a


seems like an important "TODO".   Can we enforce that the domains match and then open it up based on the policy (instead of leaving it open and then restricting it later)?


I think we could use both keys. But you should then bring this to the IETF's attention on the working-group's mailing-list.
Ultimately we will have to implement what RFC6824bis says.


sure, but this way i can check the null first.


@property (nonatomic, copy) NSDictionary *headers;


good point


Should we copy?

_headers = [merged copy];


I've implemented those changes, all good points. Thanks for the
recommendations Cyrill.

On Wed, Oct 7, 2015 at 9:47 PM, Cyrill Schumacher <notifications@github.com>
wrote:

> Looks so far good, but for directory separators (DS) you should rely on
> constant DIRECTORY_SEPARATOR which makes your code then portable to other
> operating systems which use another DS than a simple slash.
>
> For Mage::getStoreConfig('dev/minification/force_default_media_path') use
> Mage::getStoreConfigFlag('dev/minification/force_default_media_path') as
> you are dealing with booleans.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Zookal/Magento-Minify/commit/d506a5bb104b225a94c2dbfd84533c098af6d58a#commitcomment-13635451>
> .
>


Merge upstream changes


@flavour okey so I can basically do type check here as
```if type(style) is str:
        style = json.loads(style)
```


moved the `<style>` element inside the `<template>` element [as now recommended](https://www.polymer-project.org/1.0/docs/devguide/styling.html):

> Note: Prior to Polymer 1.1, the recommendation was to place \<style\> tags inside the \<dom-module\> for an element (but outside the \<template\>). This is still supported, but is no longer recommended.


Removed `<content></content>` as I don't think there's any need for it.


>don't really like the new format compared to the older ones. that parenthesis for Turbo , Unlimited and Slomo suited well :(

>I like the change of state -> slot though.

This is basically how I feel. The parenthesis used for the limiter states suited them well. Definitely better than a single hyphen with no spaces. I understand why you did it and I sort of agree that users might make an incorrect assumption on correlation but I still like how it looked before with the parenthesis. I 100% agree with the state -> slot change though. That's perfect.

>I have the feeling that quasi static information belongs to the console and not to the title bar where only frequent changing information can be displayed in-place.

I basically completely agree with this. Information like the current saved state slot is nice to have in the title bar but the only information that's *required* up there IMO is constantly changing information like usage and speed. I'm not saying I want to take everything off the title bar, I'm just saying I agree that it doesn't **need** to be there. If someone (@gregory @gabest11) can figure out a way to have GSdx have an OSD like ZeroGS does, stuff like changing save slots can be shown there temporarily. I think that's actually even better than having it in the title bar since if you're playing in full screen, you can still see it.

>I would actually only show the gsdx version (for troubleshooting), fps counter and cpu times for threads in the titlebar and move everything else into the console

So basically just remove the slot number and the frame/field-p/i indicator is what you're saying. That won't save much space.

I'm assuming by "GSdx version" you mean which renderer is being used? Sadly as @avih stated all the GSdx info is dumped in there as one unit so you can't pick and choose what to show and where to put it, at least not yet. It's just "Renderer | Native Resolution | Deinterlacing Mode" and that's it. No choice there. I disagree with what you're suggesting anyway though. GSdx renderer is not the only thing that we need for troubleshooting. Knowing the deinterlacing mode is useful at times as well. If I remember correctly, Jak & Daxter crashes if you have the deinterlacing mode set to anything but 'Off'.

>preferably show it as HUD element on the screen on change events. If you like you can have a look into zerogs. Titlebar is quite clean. All quasi-static information is in the console and as HUD element available.

If I understood this correctly, it's basically what I said above. Have all the quasi-static information show up in an OSD. There's not much to show there, just slot changes and maybe deinterlacing mode. That won't clean up the title bar much.

>In regards to the save slot, yeh remove it from the title, I don't think people really want it there for when they are using full screen it is useless anyway. What people really want is like ZeroGS where you get a temporary message pop up in the GS window telling you if you are cycling states or saving/loading.

Yep, I agree with this.

>First of all, 200% agreed that some of the info would be so much nicer as HUD or temporary OSD. Once we have a system for that, I agree we should redo the title bar.

I agree. Let's keep all the OSD talk for when that glorious day comes when we actually have an OSD implemented into GSdx (hint hint @gabest11). For now let's keep discussing what needs to be moved around or removed from the title bar.

>GSdx version isn't much use as it rarely changes, especially during development if people are using GIT builds, just saying "GSdx" at the top is fine. so the way I see the bar it should be

I think @willkuer meant renderers here, not GSdx versions. Not sure though.

>If we're running out of room, then remove the items which are least useful to most people.

What does 'running out of room' mean? Are we talking about the default size of the GS window? Because I made my window bigger (and 16:9) a long time ago so I have all the room in the world up there.

>removing save slot: I would miss it a lot at the title. I save/load and switch slots often, and it's much easier to observe at the title IMO. In fullscreen the title is invisible anyway, so it doesn't hurt anyone that it's there. But I'd be fine with moving it back to the end of bar. Also, if other than me no one finds it useful at the title and we're running out of room, sure, let's remove it.

I agree. Keep it. I'd even go as far as saying keep it at the beginning.

>[*] A possible approach, for instance, would be to add p or i to the GSdx resolution, and if i then also add the deinterlace mode. E.g. 640x480p or 640x480i (bob bff), since we only care about deinterlace mode only when the content is interlaced, but we don't care when it's progressive.

That would be the ideal solution. I completely agree with this.

>"auto" may look a bit ambiguous however, so we will need to possibly do something about that.

We could just add "auto" at the end in parenthesis so people know that the deinterlacing mode was picked automatically. So it would look like 640x480i (bob bff - auto) or 640x480i (bob bff) (auto).

>However i feel the importance is Speed > Resolution > Limiter > Renderer (although) i like this being at the start) > Usage Stats.

I think Limiter should be right after speed since they are related. Also I don't think Resolution is *that* important to the user that it would be before Limiter. It could go either way but IMO Limiter should be next to Speed.

>When in native it's of little concern to the user really, it was more useful from a dev perspective than anything else.

Yep, I think it's more of a dev thing. Although I'd argue to leave it unless we really need the space since I did find it really interesting to look at it from time-to-time. I wasn't even aware that games were able to change resolution on the fly until I saw it happen in the title bar.

>Seeing how much different opinions there are here, I think I'll try to turn it into a template where anyone could set it up in whatever way which suites him.

Cool idea! I really like it. Although I think you should find away to make sure certain things stay in the title bar no matter what, like the different usage percentages and the renderer being used. That really helps with troubleshooting other people's problems in the forum sometimes.

@avih: If you decide to keep the state of the limiter as part of the Speed section (which I would vote against, I prefer having Limiter by itself) I would change "Unlimited" to "Unbound" since technically the speed is not unlimited, it's unbound. We're not binding your speed to a certain number but it's still being limited by how much your computer can handle. Also "Unbound" is shorter than "Unlimited" :) I might be totally off here though. What do you think? I also like @refractionpcsx2's suggestion of changing it to "Max" though since that is shorter.


I saw something like a 100x-200x speedup when loading 32M salted dynamic hashes :+1:


Was it typo? Should be `phonebook_opt2`.


Yeah. I agree. Will update.


s/oveloaded/overloaded/ :)


Please improve the GIT commit messages. Read this article carefully: https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message


'patient' is masculine, thus it should be 'Aucun'.
I'm not such, but maybe 'as of' could be translated as 'depuis'. It worths we double check it.


this doesn't really matter, you are protecting a no-op with a nil check - fine to leave, but unnecessary


same, unnecessary


wait... if we don't create the _stream here, won't it be nil?  Then you are just doing initWithStream: with a nil stream?


I dont understand the issue here, dict.keys() already returns a list.


Going to show my lack of knowledge, or possibly the quantity of scotch I've had, but AMP?


addStream:associatedWithStream:


shouldn't 'depuis'  start with uppercase ?


Thanks.


Open equivalent to Facebook Instant Pages. https://www.ampproject.org/


[Rough requirements proposal.docx](https://github.com/CS410TeamOne/2016Elections/files/9748/Rough.requirements.proposal.docx)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.647](http://teamcity.monogame.net/viewLog.html?buildId=10495&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Should only provide data if we have a response.  It is invalid to call didLoadData: before there is a didReceiveResponse:


FYI: if you know the expected data length, it is more efficient to initialize the mutable data with that expected size.


Yep all oversights since this has been sitting in an overlay for a month or two.  Will be fixed on next bump.


Updated


Tester


I'm not sure, but here maybe 'Aucun patient présent' or 'Aucun patient est présent'.
Patient in singular and before 'présent'. I'm felling that it`s missing a verb here, but i`m not quiet sure if it would change the sense. It worths take a close look on this.


Yes, very much so.


Okay


I think this is going to be required for TNL to adopt SPDY push


Two suggestions:

+ This is the same code in ~3 places. Can you make it into a single function somewhere ? namespace PressBooks\SASS; is a good candidate. Example:
+ Couldn't we use `WP_DEBUG` instead of a new variable?

Example:

```php
/**
 * Write CSS to a a file in subdir named 'export-css'
 *
 * @param string $css
 * @param string $filename
 */
function debug( $css, $filename ) {
	// Output compiled CSS for debugging.
	$wp_upload_dir = wp_upload_dir();
	$debug_dir = $wp_upload_dir['basedir'] . '/export-css';
	if ( ! is_dir( $debug_dir ) ) {
		mkdir( $debug_dir );
	}
	$debug_file = $debug_dir . '/' . $filename;
	file_put_contents( $debug_file, $css );
}

// Snip ...

if ( WP_DEBUG ) {
	\PressBooks\SASS\debug( $css, 'prince.css' );
}
```


This change, adding `{` and `}` are needed anyway?

Even if you think this is needed, this is a cosmetic change from the point of view of C syntax.
We will accept consisted cosmetic changes but I want you to prepare them as separate PR or commit.
See also #451.

Of course, the best is removing "TODO" by implement adding "error (WARNINGS,..." or something real code.


Commit 64731551cb4c1a4a3344c374e3a3c3ddd5da405e is not even in my tree. It wasn't merged into master, probably an experimental branch. Where'd you find it?


Why this comment is removed? Was description fixed?


r+


Why remove this comment?


don't call these dictionaries when they are maps :)


Is it really CT2.5 confirmed?


You should likely key off the User-Agent as well at a minimum


this should be not equal to


This looks a little crazy to me. This is `O(n)` recursion and `O(n^2)` time complexity.

I would write `ValueSet unionedValues = valueSets.stream().reduce((x, y) -> x.union(y)).get()`


saw approval from graydon
at https://github.com/MonsieurNicolas/stellar-core/commit/b6ce7ab399e964f4cb591ecad7d2e8dab3b3dfd6


merging MonsieurNicolas/stellar-core/overlayVersion = b6ce7ab3 into auto


MonsieurNicolas/stellar-core/overlayVersion = b6ce7ab3 merged ok, testing candidate = f081395c


What is the need for these headVolume and volume JS functions? Why not just use the XML mapping?


This line is no longer relevant anyways. But `.stream().collect(toList())` looks like a no-op to me.


Took a while to notice, but removal of preg_match_all sems to duplicate some parameters like sCategory with car attributes, for example:

after:
`.../index.php?page=search&sOrder=b_premium+desc,dt_pub_date&iOrderType=desc&make=4&type=3&sCategory=84&sCategory[]=84`

before:
`.../index.php?page=search&sOrder=b_premium+desc,dt_pub_date&iOrderType=desc&make=4&type=3&sCategory=84`


Nit: "Controller for the exploration editor feedback tab."


@flavour which is from here:https://github.com/flavour/eden/blob/master/modules/s3/s3validators.py#L155


@nl0 fyi, something I am throwing together to power some CLI clients soon (like a slack plugin). just wanted to bring it to your attention and let you know I'm keeping it open source.


Nice poem. Very nice use of markdown as well.


It seems that a whitespace before an open paren is part of ctags coding style.
Generally I try to follow the style.

I will not reject a commit because white spaces are missig in new code.
However, I don't want to remove the existing white spaces following the orignal style.

I don't want people to spend their valuable time for styles.
Much more exciting topics are in this ctags.

A volunteer, help me to clean up https://github.com/universal-ctags/ctags/pull/394


Should there be an author tag here?


LGTM.


Weird bug on the image sources... Only image that would load online was the "res/disabled.png" aside from the initial colored images which might flash when the page is first loaded.
I removed the period <.> between the directory <res> and the slash </>.


LGTM. Thank you.


Should've caught that, you modify the return of this and broke listen :p


Sure, makes sense.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.648](http://teamcity.monogame.net/viewLog.html?buildId=10499&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Win10) Build time: 00:00:12


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.647](http://teamcity.monogame.net/viewLog.html?buildId=10495&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 539, ignored: 6 Build time: 00:18:48


Nit: var _expId = ...


@aalcesto23 I made a comment!


> ETA is July 2015

How's it going?


Since `valueSet` is never null, should we use `valueSet.equals(other.valueSet)` instead?


Since this is a data server, 'backend' seems slightly redundant. Perhaps an names could be:

reloadFromBackend -> fetchThreads
loadMessagesFromBackend -> fetchMessages

Otherwise, 'reloadFromBackend' at least needs to describe what is being reloaded from the backend.


I realize this is a fork of your personal repo, but you might want to switch to your work email for the `MAINTAINER` in this version :)


I like the sentiment of explaining why but I don't think we should be passive here.

It's not a tip or a request - it's a direction. Even more so when we're helpfully explaining why you should comment in a certain way.

"Be polite, concise and to the point so your comment is more effective.", is a start but I still don't get why it's more effective. Any ideas?


`Use AllOrNoneSet instead` to be consistent with 3 lines below.


this is auto generated


Keep this as is then.


Oh, according to the [RFC5425](https://tools.ietf.org/html/rfc5424) the `syslog` transport shoud care about '\0':
```
      MSG             = MSG-ANY / MSG-UTF8
      MSG-ANY         = *OCTET ; not starting with BOM
      OCTET           = %d00-255
```


ok, those are my comments


Ditto: author tag?


nniice.


I think +1 makes the most sense


Damn, i left gadavid there haha. my bad.


No worries :) Easy enough to fix up.


Don't you mean 1000 bytes rather than 1000 lines?


@yhuai:

In e31ed8d, I enabled TungstenAggregate for non-DISTINCT aggregate queries which contain interpreted aggregates in order to see what broke. As of that commit, there are 4 failures in each of the TungstenAggregationQuerySuites.

One of the exceptions is an NPE in merge():

```scala
[info]   Caused by: java.lang.NullPointerException
[info]   	at org.apache.spark.sql.execution.aggregate.ScalaUDAF.merge(udaf.scala:448)
[info]   	at org.apache.spark.sql.execution.aggregate.TungstenAggregationIterator$$anonfun$generateProcessRow$2.apply(TungstenAggregationIterator.scala:263)
[info]   	at org.apache.spark.sql.execution.aggregate.TungstenAggregationIterator$$anonfun$generateProcessRow$2.apply(TungstenAggregationIterator.scala:257)
[info]   	at org.apache.spark.sql.execution.aggregate.TungstenAggregationIterator.processCurrentSortedGroup(TungstenAggregationIterator.scala:664)
[info]   	at org.apache.spark.sql.execution.aggregate.TungstenAggregationIterator.next(TungstenAggregationIterator.scala:746)
[info]   	at org.apache.spark.sql.execution.aggregate.TungstenAggregationIterator.next(TungstenAggregationIterator.scala:76)
[info]   	at scala.collection.Iterator$$anon$11.next(Iterator.scala:328)
[info]   	at org.apache.spark.shuffle.sort.BypassMergeSortShuffleWriter.insertAll(BypassMergeSortShuffleWriter.java:119)
[info]   	at org.apache.spark.shuffle.sort.SortShuffleWriter.write(SortShuffleWriter.scala:73)
[info]   	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:73)
[info]   	at org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:41)
[info]   	at org.apache.spark.scheduler.Task.run(Task.scala:88)
[info]   	at org.apache.spark.executor.Executor$TaskRunner.run(Executor.scala:214)
[info]   	... 3 more (AggregationQuerySuite.scala:690)
```

The line number corresponds to `inputAggBuffer` being null:

```scala
  override def merge(buffer1: MutableRow, buffer2: InternalRow): Unit = {
    mutableAggregateBuffer.underlyingBuffer = buffer1
    inputAggregateBuffer.underlyingInputBuffer = buffer2 // <--- NPE is thrown here

    udaf.merge(mutableAggregateBuffer, inputAggregateBuffer)
  }
```

I'm pretty sure that the band-aid implement here is not the right fix. Any ideas?


small thing, but with phpdocs, you can do :

@return boolean|string

which is more descriptive of the values expected.


Ditto.


If I understand this correctly, this keeps scrolling up/down through the library if the up/down button is held down. If so, a brief comment here and on the wiki page would be helpful.

How does this work if both the up and down buttons are pressed? I'm wondering because one global timer variable is used for both directions. I'm guessing that if both buttons are held down, then one is released, rather than continuing scrolling in the direction of the one that is still held down, scrolling stops.


Implemented suggestion in issues #131 - specific exception thrown when no assertions made.


I'm wondering whether the controller should be called 'ExplorationFeedbackTab' to avoid a naming conflict with any sort of feedback tabs that may exist in other editors in the future. What are your thoughts here?


Да, но тогда начальную точку брать нужно на новой границе, или учиться рисовать в две стороны


maybe add `this._closingOnFlush = false` in the constructor?


After many tests I can´t remove that check because it could be disposed while the background task is running so I ended up many times with the browser disposed at that point.


Marc:

Are you sure you want to use ##fl= to compare elements of f32vectors and f64vectors?  I'd think you'd want to use ##eqv? for it to do the right thing with NaNs.

Brad


Why is this attached to the Wifi object? Shouldn't we have an esp8266 object for this type of stuff?


Html.link


增加注释


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/84214374


@abhi56rai kya uncle, assignment mein zero miley hain :disappointed: , I tried to implement, worked fine but had to use CYPHER queries rather than abstract ORM. bad days!


The Wire frame for A Greeting Card System is at this web address; https://wireframe.cc/ukBfJX#. still working on it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21999/testReport/) for this commit**


Why is this one commit?


Hmm, we don't do that for `_flushing` either though, which also originates from `internal/repl`.


fast-forwarding master to auto = f081395c


:+1: Professional!!


Looks cool, it's really nice that they make it so easy to set up notifications!

It's a bit annoying that you have to do all that time math manually, but that's probably a language limitation.


>  I still don't get why it's more effective

I like that. We should explain why it's more effective rather than just saying it.

What do you think about something along the lines of:

> Be polite, clear and to the point so everyone understands your comment.


Out of interest which LDAP server are you running against? I think different servers might be returning results in different ways. I am running against AD and it is returning the ldap_attribute_values as single values, not lists.
It might be better to put a check in like you did with the unique name and only try to retrieve the first value in the list if it actually is a list.


This commit is to recover the js syntax created by esandra


please make it as "// ...." , example of code should be compilable.


well, I was just thinking from the standpoint of preventing a hidden class change, but if it is already in the object from which it is inherited, then works for me


Added a license file.


Added some comments for clarity.


Fixes https://github.com/adambard/learnxinyminutes-docs/issues/1140


It's not. There were nearby changes in between, so the diff itself didn't apply cleanly.


@mgsmith1000 Did you intend to remove these htmlspecialchars() ?


Moved the throttle timer to `config.js`.  Default time is now 730ms, which allows for just under the hourly GitHub ratelimit.


module ApplicationHelper
+  def full_title(page_title = '')
+    base_title = 'Ruby on Rails Tutorial Sample App'
+     return base_title if page_title.empty?
+     page_title + ' | ' + base_title
+  end
 end


This will help during map/reduce operations.


![Image of Shame]
(https://goo.gl/Asw7lw)


Travis hated this portion. Kind of threw everything else off.

Remember: master does not have c++11 yet.


Oops, thanks!


Is reader Feig MR102 Support? how i can make it possible? how to add a new reader to RFIDIot card?


Token is required to take advantage of higher ratelimit with basic auth.


`Pio::EthernetHeader::EtherType::IPV4` → `EthernetHeader::EtherType::IPV4`


`Pio::EthernetHeader::EtherType::ARP` → `EthernetHeader::EtherType::ARP`


Points back at the repo, in case others want to contribute!


I love :coffee: :pizza:, and :dancer:.


add hobbies


`static`?


comfort: 5
completeness: 5


See https://github.com/kemitchell/smart-quotes.js/issues/1


lol at the title,

Do you know what X input as? Is it like "March", "April", "May"?

If so, why not "X 23" or for "March 23" or "X 17" for "April 17"?


There's more to it than just comprehension. I think we should focus on the benefit to the person making the comment if they follow those suggestions.


Does this *work*? I mean, the function itself does, but the amqp add_item method has a lambda function while running through, and that kinda stops my investigation as to if I have to add something to that as well.


shh


Why not simply `Objects.hash(type, bound, valueBlock)`?


I vote for "Remove blocks..."  The "unused" part isn't really needed as part of the name, whereas "remove" is, especially if this menu option is going to live among a bunch of import/export ones.  The naive understanding will be that you get to choose which blocks to remove from a universe of all blocks, which is not such a disastrous misunderstanding, and the tooltip can clarify that only unused custom blocks are included.


Why not simply `Objects.equals`?


some text are inside another text


Using this method, the about/locked page gets it's set of approve, remove, etc buttons. Should this happen? There is no harm in it, could be useful, and is there on other pages like /about/edited. :+1: or :-1: ? I say :+1:


`@Override`


ok


Although the horizontal rules above committee members are in the current UVic LaTeX template, do you know if they are actually required by library style? None of [the most recently accepted theses on UVicSpace](https://dspace.library.uvic.ca:8443/handle/1828/12) include them.


Move this a line above?


Escribelo con C o C++ :+1:


<% provide(:title, 'Home') %>


Why??


Sorry for the delay. I will have to test this myself before I can submit. Hopefully I can find some time soon. Feel free to fork the library yourself in the meantime.

Some suggestions off the top of my head are the (1) the code should be `go fmt`-ed and (2) the `Message` should hold a pointer to the `Notification` struct.

Also note that I'd prefer the library to remain similar to the Java one (see https://github.com/google/gcm/pull/80), so I agree the `Notification` struct was a good idea. :)


解耦有空再说吧，今天大概不行了


What a heck...


My bad u.u anyways this will prevent any problem in the future related to line endings once the files are updated


Please use a more descriptive variable name, for example loopLength.


appInfo.devDependencies.nw est important pour nw-builder

Si le appInfo a pas de appInfo.dependences pour cest invalid? Il va juste pas avoir de node_modules a copier qui est valide.


👌👀👌👀👌👀👌👀👌👀 good shit go౦ԁ sHit👌 thats ✔ some good👌👌shit right👌👌there👌👌👌 right✔there ✔✔if i do ƽaү so my self 💯 i say so 💯 thats what im talking about right there right there (chorus: ʳᶦᵍʰᵗ ᵗʰᵉʳᵉ) mMMMMᎷМ💯 👌👌 👌НO0ОଠOOOOOОଠଠOoooᵒᵒᵒᵒᵒᵒᵒᵒᵒ👌 👌👌 👌 💯 👌 👀 👀 👀 👌👌Good shit


HAHA!!  All the <br> tags.  I didn't think that was necessary when we were writing in github.


Removing these imports broke our project. It's probably also broken `django-fluent-comments`. See https://github.com/edoburu/django-fluent-comments/blob/master/fluent_comments/__init__.py#L16


h


k


What happens when we have two requests that hit this code at the same time?


Done. (I took a lot of stuff out that the cookiecutter created, but wasn't sure if this was needed for the module to work in Pythons 2 and 3.)


it could also be git commit -m"[comment]"


Done. Was looking at Enums, but wasn't sure if they were a pain to backport to Python 2 or not.


Done.


all of these could be null, let's have them done in a finally clause.


I'm still partial to using the name to configure it and keep the error-handling logic in this constructor. (Though I did rethink how I was passing the digest_name through and came up with a refactoring in #2.)


use function findNwVersion that I made!


Done in #2, but I still need to write a test for it. Will try to do that tomorrow.


fluxandflowcreative.com


unneeded


the hash code needs to be computed relative to the type hash of the block


if you feel that function findNwVersion works well we could remove this test task


same as above, the block equality needs to be tested with the type operation.


this doesn't override anything


:) thanks


Even better :)


没看懂，好神秘


I think they should all be independent, for now.  RegisterMachine and Systemd at least do not matter, which order yo do it in.   Maybe in the future we might need that, but I thought it might be a little hacky to require that in the beginning.  If docker asks for it, we could add it.


its a bug in mingw
> On 08 Oct 2015, at 11:27, Anton Kochkov <notifications@github.com> wrote:
>
> Same here, still valid for CYGWIN
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/radare/radare2/commit/be0538a6a80602862470af4e1d03ee87902ab01d#commitcomment-13658385>.
>


@msiv да, я буду подсовывать тебе точку на новой границе


Testing with Eve


What index failed? And why do you stop after the first index that failed?
We want to try as much as possible


Should have added a TODO/XXX/FIXME and let the IDE tell you "hey you added a TODO item, wanna check it?"


You seem to have forgotten to `git add ` the actual fix, because there are only whitespace changes here.


done


I think most of my comments  from `nodesWithMetadata()` apply here, except that RecursivePlugIterator will prune at nodes, so you'd want to use `FilteredRecursiveChildIterator<TypePredicate<Plug> >` instead.


如何使用那几种加密方式呢？默认用哪个加密？


done 4e1b9b6cb9037d395ab7b9c3d33f37e912a6e364


Если ничего нет то можно посылать пустой массив. Однако если решим (а мы это хотели) посылать несколько последних сообщений новому пользователю, то это сразу станет актуальным.


Great, if you can update the pull request I will merge it.


Also added a test for the arrow function 4e1b9b6cb9037d395ab7b9c3d33f37e912a6e364


из-за этой строчки полетела вставка из буфера. Всего одна буква и запятая!


removed the environments section and used them inline as you proposed 4e1b9b6cb9037d395ab7b9c3d33f37e912a6e364


This is useless. My fork was recoded as a runtime option and already in mainstream osrm.


Please write how to install fast-rcnn, where is installed, requirements information etc like this commit message to `README.md` where is top directory too. Usually Autoware users does not see commit log, they see README.md.


We wanted to reverse the order of the hooks.

Pre
hook1
hook2
hook3

Post
hook3
hook2
hook1

To make sure that one hook would not cause another hooks post call to fail.  There are potential problems with this, since

hooks might have been installed or removed while the container was running.  I don't think there is a good way to solve this problem.


    -t xxx
默认是 aes-128 ，推荐 rc4，速度快.


Sounds good. There is also other things which will make this branch not usable for current live data, yes, so we could need a solution to toggle this on when next semester begins.


LOL

Nice workaround. :+1:


Because it should be `a = value1 if cond else value2` :)


Uh.. thats actually a problem. The titlebar is now no reliable troubleshooting information. If people download 'perfect settings emulation hack ultimate speed'-inis from the web that are just changing the mask to a fake one it could be problematic.. People would believe they have all the time constant full speed...


Auf die Bytes kommt es nicht an. Dafür kann man als Coder besser die Struktur im File erkennen.


ah... Maybe the FT2232 is only used for configuration then? (I though it would be possible to use it in slave fifo mode but that's maybe not the case).


Wow! I don't understand how did it work before?


Why hard-coded value instead of using configuration ?


@bgoglin thanks for the pointer
@rhc54 I understand that. the main difference I noted so far is the way cache are handled
on v1.x, this is a pair HWLOC_OBJ_CACHE,level and in v2.x there is no more level but several caches
HWLOC_OBJ_L1CACHE, HWLOC_OBJ_L2CACHE, ... which makes everything easier from an ompi point of view. that being said, that might be less trivial to abstract
feel fred to browse my developKent branch https://github.com/ggouaillardet/ompi/tree/topic/no_HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM
and especially ggouaillardet/ompi@892ff1d94072fca0f468228c10d13be58a9400b2
(I will soon replace OPAL_HAVE_HWLOC_OBJ_CACHE with a test on hwloc api version)
I did not test it yet, but it already compiles with hwloc master


Вот это копировать было не нужно.


Pragmatic developer is pragmatic


Пустая строка здесь не к чему.


Fixed


Не подписано.


好的，不过听说`rc4`不安全，`aes-256`应该更好。（aes-256-cfb在我路由器上也能把带宽跑满，即使我网速不快。。）


Скорее всего это будет другой API вызов, и в нем будет attachments.


Steve, is that you?

https://www.youtube.com/watch?v=D5k73jx2mIc


Noted. fixed with https://github.com/wso2/wso2-axis2/pull/61


movableもまだ誤解があるような気もしますけどね。 障害物などがあったらその領域に移動可能であるとは言えないと思いますが、それを扱うレイヤーは別にあります。 地面の属性を表現をするという趣旨でしたらattribute(属性)という表現も使用できます。 明日のミーティングで話し合いましょう。


Layout — это слово пишется вот так )


Yes, these docs will only go live with release of 5.2


How about something like

```
	length := len(hooks)
	for i := 0; i < length; i++ {
		fn := hooks[length-i].Name()
```


Не хватает файла layout.css в проекте.


thank you, but wouldn't it be better to just take everything to the right of last `/` ?

hmm or maybe there really is some useful info in the first parts.. but `books/` seems unneccessary...

so the best would be if `books/Oracle PL/SQL Language Pocket Reference, 4th Edition.pdf` becomes `Oracle PL - SQL Language Pocket Reference, 4th Edition.pdf`

what do you think?


This is not correct, and raises the question if the documentation should be up to speed before this PR is accepted.


I think you're right that "this allows" is the correct tense for things we will do in 5.2.  But since we haven't actually used any of these features yet, it's still a future possibility.


Вы создали новую папку с вашим именем. Теперь у вас проекты разбросаны по двум папкам.


Should use `!==` instead of `==!` (this operator doesn't exist) :wink:


you can also reduce code:
```
if (TextUtils.equals(comment.userID, snApp.userId)) {
  mode.getMenuInflater().inflate(R.menu.comment_edit_delete, menu);
} else if (TextUtils.equals(post.userId, snApp.userId)){
      mode.getMenuInflater().inflate(R.menu.comment_delete, menu);
} else {
        return false;
}
return true;
```


Yes. A few regressions also appeared with the 3.9.0 version, and I'm planning to publish a 3.9.1 version in a few weeks. I'm defending my PhD in 4 days, so not so much free time in the coming days. ;)


Не правильный отступ.


Не правильный отступ и перенос.


hhhh


We'll cross that bridge when we come to it.


Всё идеально.


Please don't use global variables. Try modules and namespaces as described here:
http://www.adequatelygood.com/JavaScript-Module-Pattern-In-Depth.html


Этот ul должен быть внутри li.


И здесь.


This formula looks neutral at high # of threads but solves our little regression on lower threads. Congrats!


Why `FMDB/standalone` instead of `FMDB/standard` or `FMDB/FTS`? The later two will use the sqlite3 which ships with iOS, and FTS uses the FTS tokenizer as well.


this doesn't look right, is it? Create a todo-init.js file from where you can bootstrap your app


I think it would be a good idea to write it in ```Discovery.h```, the reason is to clarify why this class manipulates with global states.


same for global variables.


It gets hooked in using
daemon/execdriver/native/template/default_template.go


Мы договорились использовать тут ul.


are you actually using SASS?


I had tried something similar in the past: https://github.com/jcalovski/Stockfish/commit/a42d90bf803416eb8aa613fe6d3f4cbef7deb83c
Although now we have removed the Rook contacts this may well be better, good luck!


the position of the comma really annoys me.

},

initialize: function () {


Depending on how your IDE is configured, it works automatically in the background. It can be configured not to fail when a coding style rule is broken. This pretty much negates the use of it, but I will leave it for now in case you ever care to leverage it.


don't select twice the same element (This is a hint in webstorm) . Store a reference of #new-todo


(I didn't receive any notification related to your group mention, but I saw your message in the commit timeline)

Regarding the live annotation, I guess it's nice if you're going to watch an episode live and then review it for annotation. The comments I make for myself during my first pass over an episode are almost telegraphic and probably not really useful for other annotators so, if I get to tag an episode live, I'll have to up my game quite a bit.

Regarding our reorganization, I'm sorry to say I won't be one of the regular contributors. My workload has increased after summer and I've been struggling to annotate stuff lately. I'll probably shift my handmade hero watching to the weekends and, depending on the time I have, I can try annotating episodes if they somehow manage to fall through the cracks.

Other than that, I just want to thank you for your continued effort, Miblo, you mythical annotator beast.


Nicht eher `Sitzung vom 13.04.2015` ?


I wanted values to decrease as the number of checks increase, have I done this correctly Alfred?


We have talked about this, but I am not totally sure this is necessary.  But I could easily be swayed to this.

We have built to "hooks" so far.  RegisterMachine which will register a container with machinectl.
We have also build a systemd hook which allows you to run systemd within a non privileged container.  The order of these hooks does not matter, although we attempt to make sure they get applied in a stack.

Pre:
hook1
hook2
hook3

Post:
hook3
hook2
hook1

If you can come up with a use case where sorting is important, I think we can implement the SysVinit type sorting.

Yes we will need some documentation on how these hooks work,


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8478/testReport/) for this commit**


fehlende Übersetzung


Неплохо получилось)


I'm feeling like the order of the first two arguments should be reversed - "find the nodes from `root` and put them in `components`". I'm also thinking that `components` should be called `nodes`. But, I read this a while ago and have been meaning to put it into practice :

https://web.archive.org/web/20130930101140/http://cpp-next.com/archive/2009/08/want-speed-pass-by-value

So how about we return `std::vector<Node *>`?


Good luck with the PhD and see you afterwards :)


всё


Yeah, I only noticed when I was doing a new multiblock that used these. I checked their latest history and saw that some stuff was pasted wrong. No matter, easy fix ^^


Shouldn't this print a warning instead of skip the field silently?


I had to spent some time to find the place where collector cleans state after failed initialization. It's not obvious external code decides initialization is failed and finalization should be called.


ditto


Field can be converted to local


Hi Stéphane,

Great that's some useful data I haven't seen before. I guess some degree of simplification is possible although from memory I believe at least one attempt was made to remove the popcounts (without going searching for the test itself) and was unsuccessful. Maybe we can come up with something?


Can be converted to local


Tell Patrick about this. I have a strong feeling he won't like it. Is there another way to do this one line, without a macro? Or at least with a non-partial macro?


> People would believe they have all the time constant full speed...

Also, why would these people need to troubleshoot anything if they believe it runs at full speed?


As an alternative you could create some private methods without outside access and in your case only one public method the initialize. There is no need for outside access to a method like: readData


Finishes the report for the homes assignment 2


Хорошо получилось.


Well we already use this macro in DataApi.cpp and in the generated AstApi. I don't think there is an easy way around this.


Зачем реверт?


I find it quite dangerous to base your logic on jQuery bindings. I would rather create an object with a conditional and simply use one binding which could do nothing based on the condition.


This fixes #3


ul должен быть внутри li


Updated and added example of monitoring hook.  Any other ideas of potential hooks?


Зачем с большой буквы?


hello


if (event.which!=8 && event.which!=13)


It will fail:

>Failed tests:
>  ShortPatientFormValidatorTest.validate_shouldNotRejectAgainstVoidedName:306 expected:<false> but was:<true>


Best practice in Python is to use parens instead of \ to join two lines, as the \-method is more fragile.


Уже исправлено)


Added this so that RegisterMachine could differentiate between a container launched by docker versus one launched by runc directly or other tools that might use runc/libcontainer in the future.


Maybe we should keep one example with
```
Content-length: 3

foo
```


Простите, пожалуйста😬 да, я там натыкала

best regards,
Sonya Kovalski☆

> On 08 Oct 2015, at 12:53, ZakharDay <notifications@github.com> wrote:
>
> Вы сам притянули себе изменения в моём проекте. Не надо удалять папки других студентов если сами их к себе притягиваете. Если я приму ваш пул реквест, папка которую вы удалили у меня тоже удалится.
>
> Вам ничего делать не надо. Просто больше так не делайте.
>
> —
> Reply to this email directly or view it on GitHub.
>


The position of the comma is quite annoying for me. I'd rather:
},

     allClick: function () {


Alright


Merged into master as the update meant no change in code


I had to remind myself what CTI stands for as I was wondering why cti_ rather than cte_
So that's charge transfer inefficiencies (CTI) which is the output of the analysis, rather than efficiency... not really requesting anything - just a note to self :)
This bit looks fine.


Yes I was hoping someone would suggest a nice mechansim for this.  I think this is the most objectionable part of the patch, This path and the path to the hooks.d directory.  Although the hooks.d directory sort of needs to be standardized so that people could package up their hooks to ship to this directory.


maybe add some configuration to make this re-usable. For example the id of the container of your app? Maybe the number of characters accepted. add some default configurations as well and merge them. And then make only this method public (see comment above)


Далеко сдвинули.


Nice work Jay.


Много неправильных отступов.


Merge with upstream


Pushed a fix.


@burak13 : Thank you! I believe this can be improved further, but the most difficult optimization problem to me is to optimize the number of games on fishtest. I hope that I'll learn that with the help of all of you.


You can put it back if you want, but just make it catch out bogus shit.


I don't like javascript inside HTML tags :-1:


Does this mean that submitting feedback will always redirect you to the home page, rather than keeping you on the page that you are on since the feedback from is normally a panel that appears?


AAA


По кодстайлу мы не используем такой атрибут для таблиц.


li идут внутри ul


You might want to separate the css concerning your todo section from the rest of the page. Also aggregate all css regarding the todo under a single #todoapp  id


Jay is now "RELEASE MANAGER!"


Instead of putting all of this code here you should make a function called `clear`, put this code there, and call `clear()` here.


Если вы не ставите ul внутрь p, то и двигать вправо не надо.


@Ocramius I have the same experience in 2.4 and 2.5, with no abstract types mentioned.


follow us @liberislabs on twitter....


Do you ever unbind this event from your element when you remove it?


Yes maybe it's not possible, we'll see if we get the missing schematics parts.
Maybe the FT2232 is only used in uart+jtag mode :/


Ещё вправо надо сдвинуть.


Pull request time!


I don't understand why well_cells is removed. It's used 2 lines below.


Съехал.


Done, thanks!


s/db_ostr/config.metadata.jobs.db + ".jobs"/


you should use name field is email, isMale in local


What if you decide to use cursor somewhere else, you will pass ```auto_ptr``` further. It would be good to refine issues of using libraries as soon as possible.
```
std::unique_ptr<...> cursot = conn->query(...).release();
```


As mentioned before, I think this can all be much simpler. We don't need this structure at all, since there's no need to keep the pid and tty information together. Instead: we should collect the kernel consoles in an array of strings (i.e. in a "strv", see strv.h). Then, we iterate through that strv with STRV_FOREACH and we fork something on each. That's it.

Now, if you really insist on explicitly killing the children, then keep the PIDs in a "Set" object (see set.h), where we use PID_TO_PTR to convert the pid_t into a pointer (which is what the "Set" object stores). And then just kill all members of the set.

I am pretty sure the code would be much much simpler that way...


Can we do it based on category name, id is too fragile. Name would be "Page".


Could you center the platform on the sign a bit more? I know it might be absolutely centered, but it looks odd with the dent on the right side.


> Also, why would these people need to troubleshoot anything if they believe it runs at full speed? It's the ultimate placebo :)

When it doesn't feel like full speed :P Usually cos they have both the speedhack sliders on Max lol


You are right.
Changed to throw an exception (the try/catch is still there in order to leave the debug message).
(Not yet pushed the change).

Now the callers to this method are also in try/catch... but I do not know well what to do with the thrown exception yet. We need to experiment with different inputs of cloud instances to see what will be the better corrective action. So, it's not solved completely the issue but we have done a step forward with this suggestion.


DONE. Oopps!


neither amami nor togari are 5 inches...


there's a final `if (r < 0) return r;` missing after the while() loop, so that we propagate any error that the `sd_bus_message_enter_container()` might have returned...


A new line added


Looks good to me. A negative return code (instead of data size) signals error and '*err' should then contain the CURLcode for that specific error. +1 from me.


I submitted the fix already with a previous commit, but did not test it yet. This commit was after the test but I only added the blank lines. :-)


The commit message doesn't really make sense, I think you meant `"inspect running system" section`, not running container.


Una variable definida toda en mayúsculas se parece a una macro :(
Quizás sería mejor un nombre más representativo e camelcase


ComboBox tests


That's not how asprintf() works. asprintf() allocates the string on its own.

Also, note that we try to avoid the printf() family of functions if all we do is concatenate two strings. Use strjoin() in that case.

Also, you missed the OOM check here.


It is called when the object is in DEBUG mode. The goal of the method is just to leave debug messages if it sees that something with the created solutions is not going well.


Perhaps it would be useful to log hear number of failed jobs for the sake of monitoring system.


And obviously pushed the changes made to DataManagers.


I don't think we have a structure.  I am not entirely convinced that refactoring to add a structure would necessarily simplify this. What do you think?


honestly can't remember what 13 means and i am sure neither will you in 2 months, instead can you place it somewhere in the configuration of the todo with a reasonable name like var ENTER_KEY_CODE = 13;  Magic numbers: http://stackoverflow.com/questions/47882/what-is-a-magic-number-and-why-is-it-bad


@jcalovski : I'm still not completely happy with this. But I'll listen to you and start the pull request and LTC test.


> Usually cos they have both the speedhack sliders on Max

Well, we've warned them it might cause fake fps... so there's some faking for you right there :)


Why this call is placed here but not in ```Round::start()```?


best viewed with `?w=1`


My idea is something like:
```
AS_IF([test "x$PLATFORM" = "xnix"], [LIBS="$LIBS -lresolv"],
      [test "x$PLATFORM" = "xosx"], [LIBS="$LIBS -lresolv"],
      [test "x$PLATFORM" = "xqnx"], [LIBS="$LIBS -lsocket"],
      [LIBS="$LIBS"]) # maybe print info about assumption that system doesn't have libresolv
                      #or make default behaviour checking with libresolv and add bsd systems to the list.

AC_LINK_IFELSE([AC_LANG_SOURCE([
       #include <resolv.h>
       int main() {
           res_query(NULL, 0, 0, NULL, 0);
           return 0;
       }
       ])],
       [], # ok
       []) # AC_MSG_ERROR
```
Don't do it for qnx and osx at the moment, that was an example. We can add support of new systems easily. Advantage of this solution is that we don't need to check `req_query`, then `__res_query` and all future cases, because source code uses standard interface.

/!\ My example doesn't include variable PC_LIBS. Lets say, you can set `RESOLV_LIB="-lresolv"` under AS_IF() and after it `LIBS="$LIBS $RESOLV_LIB"; PC_LIBS="$PC_LIBS $RESOLV_LIB"`


Someone have minified code to share?


Hmm, I think I still don't understand the purpose of this patch.


Теперь можем бампить)


*Code Quality - Nitpick*

Your functions should be in camelCase. This function should be something like so: `testGetRepoNumberOutputIsInteger()`.

Please apply the same principle to the other functions.


ARM mbed 物聯網學堂
無法連上測試的SERVER端網址


D3.jsのサイトを見ると、この書き方だと常に最新版を使うような気がします。

そうすると、バージョンが上がった際に、予期せぬ挙動になってしまう可能性があります。
バージョンを固定して読み込めるように検討したほうがいいのではないかと思います。


... and defined already on line 619!


It didn't work because it didn't even exist in UIA branch. :) I've just merged master into UIA.

I'm thinking about `find_windows` interface changes for multi-back-end versions... There is a big food for thought.


HI
I need some how notify Beaker about each test.
1 Avocado's test = 1 Beaker's phase

I have script :

```
cat beaker_phase_notify.sh
#!/bin/bash

[ -z "$PHASE" ] && PHASE="$KVM_TEST_shortname"

[ -z "$PHASE" ] && show_help

if [ -z "$BEAKERLIB_JOURNAL" ]; then
  echo "$PROG: Do nothing. Run out of BEAKER environment."
  exit
fi

# Include Beaker environment
. /usr/bin/rhts-environment.sh || exit 1
. /usr/share/beakerlib/beakerlib.sh || exit 1

if [ -n "$BEGIN" ]; then
  rlPhaseStart "FAIL" "$PHASE"
fi

if [ -n "$END" -a -n "$KVM_TEST_test_passed" ]; then
  if [ "$KVM_TEST_test_passed" == "True" ]; then
    RESULT="PASS"
    rlPass "$PHASE"
  else
    RESULT="FAIL"
    rlFail "$PHASE"
  fi
  #rlReport "$PHASE" "$RESULT"
  rlPhaseEnd
fi
```


Hi, there should be also some check like``taskStatus.isTaskFinished()`` in a condition, otherwise we will report done on forced send task multiple times (x Destination). (Not sure, that this check will work also with gen tasks, since you don't use it in a code above before updating scheduling pool for gen tasks).


**Code Quality - Nitpick**

Your function names should follow the camelCase conventions.

Please fix here and in other parts of this Class.


:shrug:


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22012/testReport/) for this commit**


Build of fresh clone fails with `cannot find -lR3BLandDB` if this is commented.


Noted


OK


Tolle Idee, würde ich auch gerne spielen, wenn's fertig ist.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8479/testReport/) for this commit**


** Code Quality - Nitpick **

Your function names should follow the camelCase convention.


Hi @meldefon, I know this is a first pass at stuff, just remember import from libs should go on the top of the page when you are ready to submit the PR. Also check out https://github.com/kwhitehall/grab-tag-graph/wiki/Developer's-page for more details on that process


You assert ```m_jobs_timestamp``` less than or equal to ```timestamp```. Why do you check ```m_jobs_timestamp``` greater than ```timestamp``` in next line?


Thanks so much for this, @djfarrelly! I'm going to be working on this today. :)


**Test Coverage - Critical**

Currently, calling `toCurrency()` on a string without a decimal place e.g. `1000` returns `.1000`. See my test spec below:

```
it('Should return 1000', function() {
        expect('1000'.toCurrency()).toBe('1,000');
});
```

The test fails with the following error
<img width="743" alt="screen shot 2015-10-08 at 11 38 38 am" src="https://cloud.githubusercontent.com/assets/2857896/10364226/757761f6-6db1-11e5-9a39-6587f1f228ef.png">

Also, `toCurrenty()` called on a pure string e.g. `Godson`, returns `.Godson`. Ideally you should return `NaN`

**Solution**

Adjust your procedure and add test of this sort.


I'm missing immediate report of task error back to dispatcher here (again only when task is all finished). Or are failed tasks handled from outside using both methods ``onTaskDestinationError() and then onTaskDestinationDone()`` ? Doesn't seem like that to me, but I might be wrong.


Ignore the question, I should have seen the next log line first.


good job


This is so wrong. Why are you using another person's account?


IIRC I just did a `git blame` and guessed (in many cases, though not all) that the author with the oldest and most commits in the file was the original author.  My apologies if I got this wrong!

Interestingly enough, Perlpilot doesn't turn up in the blame for the `last-fridays-of-year.pl` file; only your name turns up.  Did you maybe add the file to the `perl6-examples` repo originally?  The implementation by Perlpilot on rosettacode.org uses different code to that in `perl6-examples`.  Do you maybe know who the original author was?

BTW: thanks for pointing out this issue!


In case you want to workaround this bug through reflection. Works for me on 4.2.2.

    public class ValueAnimatorMy extends ValueAnimator {

    @Override
    public void end() {
        super.end();
        resetPlayingBackwards();
    }

    @Override
    public void cancel() {
        super.cancel();
        resetPlayingBackwards();
    }

    private static Field mPlayingBackwardsFiled;
    private static boolean mPlayingBackwardsFiledUnreachable;
    private static boolean mPlayingBackwardsFiledModificationError;

    private void resetPlayingBackwards() {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.KITKAT) //tested on 4.2.2, 4.4, but not on 4.3
            return;

        if (mPlayingBackwardsFiled == null && !mPlayingBackwardsFiledUnreachable) {
            try {
                mPlayingBackwardsFiled = ValueAnimator.class.getDeclaredField("mPlayingBackwards");
                mPlayingBackwardsFiled.setAccessible(true);
            } catch (NoSuchFieldException e) {
                mPlayingBackwardsFiledUnreachable = true;
                Log.wtf("Can't find field ValueAnimator.mPlayingBackwards through reflection", e);
            }
        }

        if (mPlayingBackwardsFiled != null && !mPlayingBackwardsFiledModificationError) {
            try {
                mPlayingBackwardsFiled.set(this, false);
            } catch (IllegalAccessException e) {
                mPlayingBackwardsFiledModificationError = true;
                Log.wtf("Can't modify field ValueAnimator.mPlayingBackwards through reflection", e);
            }
        }
    }
    }


OK, much better now.


@est31 ^


Insane! Going to try this out shortly! 😁


Textadventure klingt super :)


yes, you are right


You could use asserts locally, but you should not push code with asserts to upstream because of production code shouldn't crash ever.


**Critical**

Your Copyright is attributed to someone else. Any reason why?


Textadventures sind super, bin schon auf die Geschichte gespannt ;)


Couple things here:
(1) consider playing with different number of worker processes to determine the overall impacts of the code on the computer's resources (to include memory), and provide these outputs-analytics. (We can roll these analytics into a wiki later on to guide users on the number of worker processes to choose).
(2) allow the user to choose the number of worker threads


It is quite useful to use ```auto``` in cases such this:
```
auto old = m_jobs.begin();
```


Typo, should be: zugrundeliegenden


I actually wanted to eliminate assertion and write error instead, but have lost this change in one of pull request rounds.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8480/testReport/) for this commit**


This doesn't seem to be available (anymore?) and fails with `E: Version '0.11.0.0-1~bpo8+2' for 'libgrpc-dev' was not found`. I checked and changed the version to `0.11.1-1~bpo8+1`. After that, everything's working. :)


Tolle Idee, so ein Textadventure ;)


UPDATES:
Right Click in a room
- You can examine item i.e. prints out description
Left Click in a room
- Pick up item (if it is pickable)
Inventory Items
- All pickable items can be displayed in the inventory box

BUGS:
- The item you just picked up will show up in the inventory, and will
be removed inside the room - so you wouldn’t be able to see it if you
wander around. But when you go out and then reenter the room, a
duplicate of the item will be displayed in the room again.

TO DO:
- Bounding Box for the inventory items so you can right/left click on it


Had to add these checks to make the tests work, since ``flush_events`` only works on GUI backends. I guess this is better than having no tests at all.


Given the architecture of the codebase, I think this class should be in utils.py (See https://github.com/kwhitehall/grab-tag-graph/wiki/File-structure-and-function-distribution-in-GTG for more details)


Fixed.


why?  now I can't run `make` in the root, because my virtualenv `bin` is one level up.  if you have a virtualenv, `sphinx-build` will be on your path and you don't have to specify `bin/`.


Yep, removed it, see comment below.


Textadventures sind klasse, kennt ihr noch Toonstruck? Meiner Meinung ja eins der besten neben Monkey Island, wenn auch schon in die Jahre gekommen ;)


WOWZERS! That is crazy speed improvement there!
Can you please supply stats on the use of the other resources eg memory as well?
Also, please make a PR and send so we can perform some backward compatibility tests.


**Code Quality - Awesome**

Your spacing, indentation, and styling is consistent throughout your code base.
Well done.


Remember syncing before the pull request.


**Comments - Awesome**

Your comments are concise and consistently styled.
Good job.


почему-то этот setTimeout выполняется быстрее моего... хотя количество секунд одинаковое, 0. придется его отключить.


This has the side-effect of removing the `:durable` setting from the hash, which `Maxretry` still uses, causing sad. I'd probably better open an issue with this.


Please call this find_cloud_elements and deprecate the old find_cloud_elements. That way, the API call wouldn't change for users.


Remove this.


Removing the imports isn't needed here: the new field is in the same class as the old one, so the quickfix won't make any imports redundant.


ok


Remove `self.sort_expression`.


@alombarte definetly some help would be great :smile_cat: I will begin with Exceptions


LGTM other than the comment above.


way a head of you, check next commit bro


I wanted to distinguish between map::iterator and vector::iterator. Sometimes it's hard to keep in mind all used container types. I think we should be careful to don't overuse ```auto```.


It's looking really good @meldefon!


This is not necessary an error. REDHAT_BUGZILLA_PRODUCT is an optional field.

 Also the second sentence should be printed out when you are really doing that action.


I don't think that missing `/etc/os-release` file is an error.


is mistake


Die Idee klingt toll. Ich hätte nur Bedenken, ob es in dem kurzen Zeitraum machbar ist. Wünsch Euch auf jeden Fall viel Erfolg, dass ihr das schafft ;)


At which place does it happen? Do you build with FairDB installed? I do not find usage of R3BLandDB library in any dependencies in the current dev branch (besides commondb, which is enabled if FairDB was installed previously).


True. Hard to see due to the spaghetti like code structure.


buraya göstermeyi kim ekledi lan


The shift is probably better expressed as `1 << powerVal`, since shifting 1 left by x computes 2^x.


Yep ,perfect job


can put it back


Aha, single `-p` means get the product from `/etc/os-release`. You need to document it somewhere and users must be aware of it.


Thank you :+1:


@IIvec : Congratulations, this formula with factor 3 is a significant progress for Lazy SMP at 3 threads short Tc!

Remarks: The other formula which did not work http://tests.stockfishchess.org/test/view/56158b270ebc597e4f23e691 is asymptotically approaching this formula with a factor of 4 (*log) for high idx (e.g. 23 threads) .

I would again suggest to consider a factor of 2, corresponding to q=5/3 in order to try the opposite direction.

Regards, Alfred


Perhaps ```m_new_jobs``` should also be contained as ```std::map<int, Job>```?


Ja der falsche Musikgeschmack kann schon mal ein Scheidungsgrund sein, wenn beim gemeinsamen Umzug alte Platten zum Vorschein kommen. Besser man geht da von Anfang an auf Nummer sicher. Viel Erfolg bei der Umsetzung! =)


Klingt toll, viel Erfolg dabei!


I reverted the commit.


Please create an issue with extended error message attached.


Extra closing brace here.


Hi @MPWeiner , is there a particular reason why: you didn't take the else statement into the new function?


I would prefer to [throw a dedicated C++ exception](http://en.cppreference.com/w/cpp/error/runtime_error "Reconsider exception handling") (instead of an ordinary log message) if a Pthread call failed.
Does this approach need [another look](https://github.com/01org/libxcam/issues/174 "More error handling")?


This vector only needs to be be defined for CONFIG_ARC_PLAT_EZNPS && perf just as you did below


`const` should be in lowercase.


@IIvec Works great so far with 3 threads. Congrats!


Klingt super, viel Erfolg bei der Umsetzung!


Pass `&:id` as an argument to `map` instead of a block.


Ok, I'll improve documentation of -p parameter in man page and improve the error/log messages as well.


Coding standards: Use 4 spaces for indents instead of tabs.


test


Why `layout-align` selector was removed without noticing it into changelog or mentioning that this feature is depricated in documentation for version 0.11.2?
Is there some workaround for centering the content?


Discussed in person:
this loop has incorrect behaviour due to unsorted m_new_jobs.


ttttt


xxxxx


Breaking change, see https://github.com/erikras/react-redux-universal-hot-example/pull/310


Hört sich echt gut an. Bin gespannt, wie es im Endeffekt aussehen wird. :)


Please add docblocks for each public method `/** ... */`, including a short description of the functionality, `@param` for each function argument type & `@return` for the return type. See documentation:
http://www.phpdoc.org/docs/latest/guides/docblocks.html


Should this kwarg make appearance somewhere too after disappearing here?


Build is still broken. Please see http://ci.cgeo.org/job/c-geo/4077/console
Build was first broken at http://ci.cgeo.org/job/c-geo/4051/


@llvec for LTC test pls set to 3 threads,  currently test is set to 1 threads.


Btw, you can use `git pull -r` to avoid these sort of merges (rebases your local changes on top of the latest from origin). Not a huge deal but makes for cleaner branch history.


Klingt interessant. Viel Glück dabei :)


`position` is short ```position```


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/19290/testReport/) for this commit**


The entire ENTRY/END block needs to be under #ifdef.

Break this part out into a patch of own - ezchip perf driver patch should be standalone !


The `#ifdef __cplusplus` stuff is missing...!


@emirhartato Hello, i am a beginner of learning osm2pgsql & postgis.I have some difficulties in loading osm data to postgis by using osm2pgsql.When i input command line,i get the error note:osm2pgsql svn version af61cae663<64bit id space> release notes:windows version built by Dominitk Perpeet".I really do not know where is the error and how to solve it. I sincerely hope to get your help.Thank you very much!


I think packageinstaller should not become part of Super, but probably part of Core, if it works.


Klingt toll, auch die Herangehensweise erstmal einen Teil umzusetzen und das Projekt nach PRG weiterzuentwickeln klingt für mich sehr sinnvoll. Viel Erfolg bei der Umsetzung! =)


@ajithcj : sorry, corrected!
@alwey : thank you for your suggestion. I'll try more discussion on the forum before further testing to optimize our performance.
Thank you all!


done


All issues raised has been resolved.


So u r skipping the entire generic irq call flow and calling u custom handler - i suppose it is fine since this is not a real irq after all !


Ich finde auch, dass es interessant klingt. Würde ich auch spielen :)