Sorry for the late reply and my poor english. I just saw your message after I pushed day 71 annotation.

Regarding our reorganization, I am afraid that I cannot annotate new videos. Now, I am on day 72. I don't think I have the ability to annotate latest videos. Maybe I can do something like add titles/descriptions of weeks, take notes, etc for previous videos. Still, I will try hard to catch up Casey.

If there is anything I can help, I would glad to contribute the community. Like @debiatan said, thank you very much, Miblo, the mythical annotator beast.


I guess its fine. We do not attempt to transform the processes everywhere. I guess, later, we might even only transform the processes marked as `exported` and some `main` process.


if the "message" is not an instance of MapMessage, tenantInfoBean will not get initialized and therefore here there will be a null pointer exception.


Thanks for your contribution!


Nit: several redundant parens here.


redundant initialization


I will later little busy


I'm sad that we have a `CollectionUtil` in this project. If there was any place to use Guava, it would be here.


it fixed the friendpick list, but it still doesn't tag the friends name on positive test. can you confirm?


We need some module-level documentation that describes the structure of the module. Also, make yourself an account on readthedocs.org and get your documentation compiling.


:+1:  thanks, works


It's better to remove the debug prints here and a couple lines above.


@rvonstange DWMR :checkered_flag: with checkpoint/assignment #32.


WTF is this comment? If it's on the method, why not make it javadoc?


This is related to the use of request.get_json(force=True) elsewhere - if it encounters invalid JSON, the Request class will call on_json_loading_failed and return a 400 error in plain text.

This overrides it to throw the error in JSON, but I'm not sure if this is the place to put it (it feels potentially a bit tacked onto the existing multiprocessing changes here)?


I don't see where you're actually defining the mappings for each model.


OK to push into 1.6 branch


Why not use the VersionNumber type from System? If we're going to change version number tracking in this device, that is. I'd actually prefer not to mix this change up with the change to support nulls first. Can we split those out so I can get a build with the order by fix?


This should be simplified. I don't see why I should have to think about reduction to escape strings.


I'll move it out today @diegoteliz


someone has a String concatenation problem


ok


we have libsoc debugging functions which we can make re-routable to places other than stderr in the future.

https://github.com/jackmitch/libsoc/blob/master/lib/debug.c#L6


examples


When `deleteObjectDirect` was originally modified to use `Delete2` it did not wait and close the handle. This commit fixes that for all the replaced methods but not the deprecated method itself. It should maybe be changed too.

Note that on 5.1 the handle will not be closed, I don't know if this warrants a fix there if a 5.1.5 is likely.


Wow. Starting out at 1.0. So brave. If this were node you'd have like 20 more releases to go before hitting 1.0.


For example: On Klte sprint has different NFC HW
On G3 Sprint has different NFC HW
IDK About JF on NFC, but I'm more than willing to bet (if I had money) that they included a slightly different BT chip


Tymczasowo.

W dniu środa, 14 października 2015 Kamil Kujawiński <
notifications@github.com> napisał(a):

> Potrzebujemy tego?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kkujawinski/talktoyourapp/commit/e10c3c64bb929877d5c1790668115761b2d70637#commitcomment-13769410>
> .
>

--
Marcin Najtkowski


I don’t think we should do this. Though I certainly don't like all the warnings that we get. CocoaPods isn't flexible enough for us to specify that some sources should not be built for iOS 9 which would be the ideal.


Let use real value objects from the core and see how they get saved. I think the current File.read mechanism won't work. We'll probably be best to serialise as yaml.


新建了一个项目说明，嘿嘿~~~~


Possible bug: get_default_value() for url_list options seems to be returning the current value, not the default (which is "").
I need to check whether this is something I'm doing but suspect it's a wider bug? If so, I can fix it here or as part of a separate pull request, since it's not especially serious and this patch series has taken me long enough to get out the door.


Done in 0c19835a05a374598f7035fd8b2b01f18da768da.


This produces incorrect results when handling the UNSPECIFIED_OPAQUE case and results in negative transparency values being exported (transparent.getColor().getAlpha() returns -1). When exporting Collada from Blender, only transparency is specified in the effect and transparent is not, triggering the bug.


This addresses https://trac.openmicroscopy.org/ome/ticket/12342#comment:15


@niftykins Thanks for the typo it's fix. For the folder structure, I have to follow the Meteor rules. By doing so, it only rebuild the client or the server when needed. Otherwise, it will always rebuild both and it sucks for hot reload. I like to be able to have a webpack.conf.js that is common to both and then one webpack.conf.js for server and client. It keeps the config really small and concise.


I don't see that this test provides much value. There is a default method in the interface that delegates to another method. Just test the real one.


`File.zero` - do we have a test for that? :)


I guess empty spaces could be sanitized

    In [15]: b = 'j = foo.bar.baz'

    In [16]: b.split('=', 1)
    Out[16]: ['j ', ' foo.bar.baz']


any reason why you didn't have a "base class" InfluxDbException that both InfluxDbQueryException and InfluxDbWriteException derive from...


Get these hard tabs outta here!


I hope supportsAddToFavorites as generic term. Please suggest if you have other options.


return EXIT_FAILURE here rather than exiting


Please wait my next commit before trying this...

You might try the following commands to register your testcases:

```{.shell}
# only one time per terminal
$ . ./env.sh

# I put the new test cases in new/
$ mkdir -p new
$ mv fixtures/all/{bad_,}assert.ll new/

# and these links are automatically created
$ rm fixtures/success/assert.ll fixtures/failure/bad_assert.ll

# so the main commands are:
$ cmdrsuccess new/assert.ll
$ cmdrfailure new/bad_assert.ll
```


I guess that's doesn't matter much - most client users will be only-reading or only-writing...


nit: I personally think that MockitoJUnitRunner is useless. It's clearer and just as easy to call initMock() in your setup method.


This module should be relocated to pvlib/doc/tutorials.

Then, we need a real testing module added to pvlib/test. All automated, no plotting.

Then you need to get your fork hooked up to TravisCI. Here's my fork on travis:

https://travis-ci.org/wholmgren/pvlib-python


Hm, I'm surprised this would cause conflicts otherwise.


Wow, what a good commit!


am i blind?  i see no http version.


@ShootingKing-AM  Well done :P


I don't understand these inline method level comments.


so approvals lines behave and go back to bottom of graph rather than following the flipped axes


check for groundWater data and if exists, flip it.


Сори не то


Do you guys line up your param docs like this in scar? I vote NOT to do this formatting.


flippin'


ooooh.  nevermind.  an http-specific version of this exception.


I'll expand that to include ObjectMapper.. Have a constructor that just defaults to ```new ObjectMapper()```


Also, why do we pass an ObjectMapper in here?  We're not marshaling unexpected Objects, are we?

We can just use a Jackson.newObjectMapper(), right?


I believe this is better than limiting us to one configured scan, but should we add a (configurable) limit to the number of scans held in the SCANS variable? Otherwise a long-running API instance may end up using some stupid amount of memory.


that's a lot of 3rd party dependencies.


checked?


I have some concern here. Balanced binary trees have nice asymptotic properties, but not (often) poor cache locality. So two questions:

1) Do we have any sort of performance numbers that show that this is actually a win over e.g. an array?
2) Has anyone tried to use something like a btree instead of BBST?


May not need this, the server seems to be fine. I get an error :/


@cachethq/owners lol.


@ryanbr

The cause was filter `/analytics/mbox.js` in EasyPrivacy: it prevented the resource `https://www.southwest.com/assets/v15080210/scripts/analytics/mbox.js` from being fetched, thereby breaking the rendering of the background.


If 'offline' is true, shouldn't this return rpcINVALID_PARAMS if a 'Fee' field is missing?


This is the repo for the Data Science Coursera Course


It is not "P*o*rcentage"... is "P*e*rcentage".


java8's (native) Stream seems to offer no disadvantages to Seq in this case.


I'm not sure if github sent my comment (above); perhaps if I write here it will.


ditton on error log and exit


So we're going to have to wrap every client call in a try/catch block? No way....


Is this tested?
Last time I tried using Flo Adreno Blobs I got MAJOR Underrun, although I was also using Flo GPU Drivers
This is what I did
https://github.com/TheMuppers/vendor_samsung/commit/fb2f1769952075ca1b4b69027bb4e6d69635a05b (reverted a few days later)


i'd like to see this library with only the bare minimum 3rd party deps.


I would much prefer the user had to call the init_pin_mappings manually to re-enforce that by using named gpio's they were using the config file.


Why doesn't this have a default implementation that calls ```writePoint()``` for each point?


You should use mnemonic notation instead.


Lovisa noticed that making
```javascript
```


pls convert InfluxDbQueryException to RuntimeException so you don't have to declare it everywhere and all your clients don't have to deal with it unless they want to.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.668](http://teamcity.monogame.net/viewLog.html?buildId=10609&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependency failed: MonoGame :: Develop (Mac) Build time: 00:00:00


Derived from K&R C style.


if i type in the guid, the tag friend post is success.


Need to rework on this.  System columns do not necessarily sort to the front.


remove the 3rd party dep.. you can use Collections.unmodifiableList instead


add name nattapoom


I have no idea what this is. It needs documentation.


не всё в commit внёс


Calling this method "testFOO" makes me think it will have a @Test annotation. I suggest you rename it `assertWritePoints`


accepted- thanks!


such unnecessary dependence on 3rd parties.


add name jom


Should we trim the space?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 846](https://teamcity.mesosphere.io/viewLog.html?buildId=58637&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:03:45


Since this is going open source, and others may want to support other credential mechanisms, this should probably get pulled out of this interface. You may even want to create an empty (for now) interface that this implements so other implementations can be created.


Any idea what the * is for?


MockitoUtil? :crying_cat_face:


Since scans holds a list of pointers, you would want to go through each scan and delete it before calling `clear()`.


I mean that we probably shouldn't allow that either. If the flag is disabled, they should not be able to access any file above their own verticle.


You are the english watcher. Please feel free to fix my incorrect spelling when you see ^^


lol


Use ```String.format()``` instead.


hey - cool idea...i like having access to this inside volshell. only thing i'd suggest is checking out the _EPROCESS.search_process_memory() API instead. the difference is search_process_memory() goes through VADSs (process memory ranges only) where IIRC the base scanner you used here will look at page tables and thus also access areas in the kernel that are mapped into every process.


@Oscar-Rodrigues I still override the total life value with `1.05` just so that before the first bump in the ground, there is the illusion of the border.


มันขึ้นนะ แต่มันไม่เข้าในโปรเจคอ่ะโจม


pushd/popd should also have `|| die`, they can fail like 'cd'


again, native fd's


Yes. Putting in a PR now.


libsoc_debug functions


No checked, please.


I see no reason whatsoever to have to read scala to understand this test.
A good test should show me how to use the class being tested. This should be Java if the class if Java.


parens?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.669](http://teamcity.monogame.net/viewLog.html?buildId=10613&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


should you include a codestyle enforcer?


I agree with @paulhernandez. What other transport mechanisms are there?


Вывод ошибок должен осуществляться на stderr.


An interface with one implementation is mostly useless, imho


Shouldn't this be save() ? I also think the signature is wrong... Is it the method used by the admin site to save objects?


function - башизм, стоит приучать себя писать без него :)


@fprochazka hmm, vím z hlavy jen o dvou:

- Route: removed support for #class in route mask https://github.com/nette/application/commit/9ced1ba5c4bc41da06c1e5802400b5a261170dbc
- Latte: removed support for ASP & Python syntax https://github.com/nette/latte/commit/6a62b1ab5dd3aee58ae3c7f415bf07b5db5a6d68


Friends don't let friends use checked exceptions.


All these comments need to be javadoc instead.


a few comments.


93653546-FuelGenShowingInABUPSwhenPV (JasonGlazer) - x86_64-MacOS-10.9-clang: OK (1900 of 1903 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


this executes unit tests?


sweet sweet `Seq`...


В целом ОК.


I was going to ask the same thing about the ObjectMapper. Why would want to enable the user to pass in their own object mapper and have control over the message that gets sent to the InfluxDB server. That should all be hidden away.


TeamCity pull requests :: netty [Build 410](https://garage.netty.io/teamcity/viewLog.html?buildId=2296&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4777, ignored: 21 Build time: 00:29:30


Yeah, it had this error no matter were I added it. The next tests would fail. Seems to be a bug in Jasmine.


Thanks you we caught this and release notes in reference player.   Will add steps to release procedure wiki


+1 to all of this.


Pin Name rather than Board Num?


We talked to the MCTS lady and she said it's the people from the different states who type in the data. She has no control (& probably no idea)


Here is a scary thing I saw about using Unirest, which I suggest makes it not useful
~~~
Exiting an application
Unirest starts a background event loop and your Java application won't be able to exit until you manually shutdown all the threads by invoking:

Unirest.shutdown();
~~~

http://unirest.io/java.html


Yes it does. What if missing? Please raise NotSupported in case.


The only parens I seem to be able to remove w/o error are the ones around `(snd $4)` (hah, currying).  `with` seems to have a surprisingly high precedence.  Is there something else you meant?


please


what is the benefit of these 3 different constructors?


Ok, I will change to nsec and convert in RCOuput.


Both are fine but think about a normal user. Also, remember that `chat:msg` event is triggered whenever we send a message as well from slack. Another event like `status:tampering` or `status:error` can be manually triggered by checking on the client side. It's very triggering means something is wrong and you won't even need to check for any data. It's up to you if you want to modify or not.


Added:

    Far too many to list. Over 560 endpoints are now implemented!

Removed:

    # I verified that this is no longer in the documentation, but seems to be a strange removal to me.
    def dynamic_content_item_update(self, id, data, **kwargs):

Modified (method name):

    # changes logout_delete to just logout
    def users_me_logout(self, **kwargs):

Modified (params added/modified):

    # id becomes membership_id
    def user_group_membership_make_default(self, user_id, membership_id, data, **kwargs):

    # adds optional include parameter
    def users_me(self, include=None, **kwargs):

    # data argument is added due to change in the HTTP method
    def views_preview_count(self, data, **kwargs):


I talked about that with @koshalt last night and he (rightfully, IMO) pointed out that we should display the exact same data that we were given.


Only problem with the 'touchpad_menu.xml' changes from the 'android' namepsace to 'app' is that the icons are always hidden on the action bar. But! I'm seeing this is a common issue (and hardly a deal breaker), with some fixes. So I'll merge this, and I'll fix the new issue afterward. :)

Rest of this, though, right on. Mergin'. :)


This is not an help, just the signature


Is this supposed to be package level? Also javadoc needed.


Bruh, you should only release master branch yo -- this feature branch shouldn't be relased, despite being the most up to date


I do not have a test for that yet, but it would be super sweet if this got merged today, as the hackathon problems depend on it.


I don't really get why this was necessary, unless the undocumented `switch` statement above is accidentally setting `$variables['title'] = ''` for this node type. I don't know why it would... but then I don't really know what that code is supposed to do either.


ok, wait i see... it's hidden down in `getFieldValueString()`.  why don't you just convert to string in the constructor?


No, inte godkänt


Okay. I see the Builder below.


paranoia question.
Does the tags.size() have to equal fields.size() ?

If they do, you should verify they match here or toss an exception.


You could use the javadoc ```@see```


* is  notions. That particular location is not registered but exists in
actual.

Thanks,
Abhishek
On Oct 14, 2015 10:14 PM, "Rob LaRubbio" <notifications@github.com> wrote:

> Any idea what the * is for?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/motech-implementations/mim/commit/6bf3a25e84f211473f9c72679a3d58de65e1faf4#commitcomment-13772430>
> .
>


`s` doesn't work, it decodes in ascii, breaking unicode. Please use `O` and have `psycopg_ensure_bytes()` to check if that was ok. See my changes on a previous patch of yours at 5afeee3613de284fd00c3e8b2228bdbe94d74572 for an example.


LogDebug ???


@LeaYeh, I think we don't need `title`.


Gracias por los consejos, una vez mas Victor. Lo tendré en cuenta de aqui
en adelante.

Un saludo!

El 14 de octubre de 2015, 15:07, Víctor Martín <notifications@github.com>
escribió:

> Hola Víctor, ya no da pete por el tema de las importaciones. Te comento
> algunas cosas que he visto en el commit:
>
>    - Cuando Python instancia una clase llama a *init*, con lo que no es
>    necesario que lo llames. Tampoco hace falta el return para que devuelva el
>    objeto.
>    - En los condicionales no pongas paréntesis y separa cada parte de la
>    condición con un espacio en blanco.
>    - Quita los global, puedes hacerlo pasando por parámetro las variables
>    que quieras. Intenta no utilizar esa palabra reservada.
>    - Desengánchate de Java xD
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/beeva-victorsaez/beeva-dojo-python-gae-1/commit/93acd7497f3194fbf5c7fe79fe4de2c5684214fc#commitcomment-13766393>
> .
>

--
*VÍCTOR SÁEZ GARCÍA*
*PROGRAMADOR SOFTWARE*
*+34 618725518 | victor.saez@beeva.com <victor.saez@beeva.com>*
[image: www. beeva.com]


since this class is being aggregated, you should probably implement `equals()`/`hashcode()`


Please support keyword arguments too. See the above patch again for an example


Yeah... ```tags.foreach()``` would have been just as good (better)


As you can see from the fact that github stripped it, the commit message is too long ;-).


s/commit message/summary line/


pandoc.cabal in master already allows aeson 0.10.x!


Yeah you're right, I need to update this clearly.


Again, ```@see```


Sorry, I was reading the diff incorrectly. ;)


@LeaYeh, how about using `＊＊/＊`?


Thanks!


Hahah yes update to the next release. I made a fix like 5 mins afterward sorry xD


i'm all for as much doc as possible in unit tests.  and i don't think it makes sense to upgrade them to javadoc.


Please test unicode input: my snowman friend ☃ (u"\u2603") must pass through the function unscratched and unmelted, just a bit quoted :)


fixed -> fix
使用Search_msg時，得使以用%符號來做相似搜尋，
像是'hanago'與'%hanago'不能搜尋到'xxxhanagoxxx'，
但'%hanago%'則可以。


Instead of encoding Slice(&p, 1), can we simply execute line 185 after line 182?


Should I also add m3u8 format to the new extractor or you suggest making changes to the generic extractor? I am not sure how to approach the latter as I don't see what regex can extract the flowplayer config info and other formats


Thank you for the report and the fix.
I am a bit short on time but I already have two issues to work on.
So I will look into it asap, maybe this weekend.
I appreciate your help.


New update, check again. What do you think?


Alright, the bit about dev-python/coverage is related to bumping the version, I can move that to the commit body


I'd like the readme to include an example of the http request/response.


wc_RsaKeyToPublicDer is a recent function that has been added since CyaSSL and is not in danger of being redeclared by pulling in cyassl/ctaocrypt/rsa.h . With the function not being declared in cyassl/ctaocrypt/rsa.h it was moved out of the ifndef HAVE_FIPS block.


I actually don't mind it :shrug:


operator might be inherited from CharSequence


@hrach to asi není na diskusi pod commitem. V podstatě místo verzi 2.1, 2.2 atd mohly vycházet verze 3.0, 4.0 a mít setinkovou granularitu pod security fix, což by vedlo k vydávání více verzí a s tím spojené vyšší režie, což prostě už lidsky nezvládnu.


Where can I find all these retail-like skills? I would like to help you with this job...


reasonable


Whenever possible, we like to use "for example," instead of "e.g.," for readability.


Yeah. They all need to be converted to javadoc.


Our style is to have commas inside quotes, for example, "site," "domain name," "server." etc.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 847](https://teamcity.mesosphere.io/viewLog.html?buildId=58638&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:04:06


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.669](http://teamcity.monogame.net/viewLog.html?buildId=10613&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 540, ignored: 6 Build time: 00:14:05
### Failed tests
```
MonoGameTests.exe: MonoGame.Tests.Visual.RasterizerStateTest.VisualTestScissorTestEnable(False): <no details avaliable>

```


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22203/testReport/) for this commit**


awesome*


jajaja me ganaste por 15 minutos -_-; algo mas que se necesite hacer para
/users/<username> [Perfil del usuario] + Mostar info del usuario ?


93653546-FuelGenShowingInABUPSwhenPV (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1906 of 1909 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


Can we directly put an encoded string here? In that way, we don't have to call Env in version_set.cc.


You'll get to commit scala code one day...


We don't push the even patch numbers, those are strictly for master.


Comments inline. Thanks for all the tests.


refs https://github.com/mapbox/windows-builds/issues/60


New commit in PR


Me too but what are defaults for if not the first-run experience?


Can u send for me dataset for test? My email:khiemnd5@gmail.com
I wait for u.
Thank u so much!.


@furhanshabir, a few additional questions:

* How much coverage do your tests provide? Can you think of any other ways to test this?
* What does `_all_ids` do? What *should* it do?


seems this import in wrong order


Thanks @imikushin


Why the qty is wired here? I do not get the point.


Why the qty is wired to 1.0 here?


Debating if this is needed, but I'm not too bothered about keeping it atm.


`CHANGELOG = "Update to 16.0"` is sufficient. The only reason I added the second line in the testing package was for people who had just upgraded to `-9`, so they would realise an upgrade was recommended.


No need, but I will add a separate comment on testing.


I should have looked more closely at this PR, but I had expected that `modelPosition()` would return a `vec4`. I think it would at least make sense for `modelPosition()` and `worldPosition()` to return vectors with the same dimensions.


REST web service -> web service offering a REST interface


93653546-FuelGenShowingInABUPSwhenPV (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


yes, this is the right fix. I fixed it before already like this.


You're Mr. Holmes when it comes to fixing stuff, sir!🙌

(Sherlock Holmes I meant😂)


you could also note that it is the same interface that we can use with the cloud


What is the scope of `_all_ids`?


Good question.  That particular condition is checked further downstream, here: https://github.com/scottschurr/rippled/blob/sign-for-fixes/src/ripple/rpc/impl/TransactionSign.cpp#L616-L617


where the Coveo JavaScript Search is installed -> where the coveojavascript search is served from


should not be a picture but a code snippet


@DoryZi, I have a few questions:

* How can I easily the changes you made to the original?
* Does it work? How could one easily tell?
* Consider the following:

```js
var rsrc1 = NAMESPACE.resource('048c');
var rsrc2 = NAMESPACE.resource('048c');
rsrc1.close();
// What is the state of things here? What *should* it be?
```


Approved.


not my area of expertise...


@zombiB  :-)


ok


Thank you for the honor, sir! :+1:  :D


Podle me to nemas delat ty, je to zbytecne prace pro hlavni hlavu projektu. Jiz davno jsem rikal, ze to chce zavest release managera a management:
https://forum.nette.org/cs/16449-dalsi-vyvoj-nette-organizace-rozhodovani-budoucnost#p116306, https://forum.nette.org/cs/16496-jak-to-bude-dal-s-vyvojem-nette-frameworku#p116687. Co si pamatuju, tak kdysi jsme se taky bavili o tom, ze by to Honza Tvrdik delal. Ted jsme nekolik let dal a bojim se, ze on uz nema moznost to delat (cas).


Looks great! Let's merge.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.670](http://teamcity.monogame.net/viewLog.html?buildId=10617&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


stops here ? there should be an ending...

also link to more advanced settings could be useful


this should be less necessary now that we have Glide since it will keep the generated thumbnail in cache for as long as it can. I can work that in a separate PR.


asd


I'm a bit mystified now. Here's the recipe: http://sprunge.us/NIFK
 And here is the tail of the output when haikuportering it:  http://sprunge.us/JDcd

I end up with a debug_info package, which is good. I also get an installation package that has only stripped files without ressources! If I look into the sources in the working directory, I see all files unstripped.
 Now, when exactly get the files stripped? When should I xres the ressources?


我晕啊, 严重破坏兼容性啊


Missing space `if(...`


Okay, I'll go with `#f1a`, my new favorite color :stuck_out_tongue_closed_eyes:


Shouldn't this and `last(Class<T>)` also check for a null parameter like `before(Class<?>)`


test add name


This is how you comment on a commit.


meh, i don't mind some defensiveness here.  but it does seems like you're coding around it a bit.


Removing extra whitespace after the opening parenthesis.


not one-line like `private final @NonNull String  contentType;`? Or if it's `@NonNull\n` it reads better to me with an empty line under the annotated variable.


another question about `equals()`/`hashcode()`.


the only function this serves at the moment is to transmit the thumbnail generated by ThumbnailView in the attachment drawer to the attachment database, so that the thumbnail doesn't have to be generated again down there. ideally we can move to glide managing its own thumbnail cache, so that we can just remove that at the DB level


Replacing `0` by `'\0'` to match `char` type.


the general way backend services get passed arrays is by doing   ?param=blah&param=blah2&param=blah3 or ?param[]=blah&param[]=blah2&param[]=blah3  should we follow that same format?


Заливка видео по частям


ready for presentation?


Maybe your grammer-fu is stronger than mine; refactoring welcome :)


Oh, definitely :smile:


```
Too few positionals passed; expected 4 arguments but got 3
  in sub tempfile at /home/skaji/env/rakudobrew/moar-nom/install/share/perl6/site/lib/File/Temp.pm:28
```


@BardurArantsson is this better? I don't think we need to do any sophisticated error handling here, as `sh` is quite essential to do anything.


add um espaço só mesmo pra manter um padrão


is that debugging code?


well you'd have to use apostrophes to pass it there so I think this is enough...


TeamCity pull requests :: netty [Build 411](https://garage.netty.io/teamcity/viewLog.html?buildId=2297&buildTypeId=pulls_netty&guest=1) is now running


OK, I'm not sure how to fix the problem with my name retroactively, but I've updated my git config to hopefully avoid it in the future.  Sorry.


add um espaço antes da chaves, só mesmo pra manter o padrão dos outros


93653546-FuelGenShowingInABUPSwhenPV (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1906 of 1909 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.84%25-yellow.svg)


mesma coisa


how about "Jose Molina (@votaguz)" ?


This diff looks a little weird. What happened?


Tuning looks good. :+1:


edit lastname


Should remove this comment


Comments on issue 25 https://github.com/RIPE-NCC/ripe-atlas-tools/issues/25#issuecomment-148123848


Ah I see what you did here


Authors??????

```java
/**
 * @author votaguz
 * @author gubatron
 * @author aldenml
 */
```


missing author


As variáveis deveriam ser mesmo em português?


TeamCity pull requests :: netty [Build 412](https://garage.netty.io/teamcity/viewLog.html?buildId=2298&buildTypeId=pulls_netty&guest=1) is now running


You could try `git commit --amend` to see if that fixes it, and then force push (we could all look away for a sec.)


I don't quite understand what you mean


You could check the commit details with `git log`…


EnergyCost S is a value to pass for the designer to show how much energy uses /s


105015426-DefVAVTUMinMax (wfbuhl) - x86_64-MacOS-10.9-clang: OK (1903 of 1903 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It looks to me that this marks all attributes seen as used. If so, this is incorrect - only valid stability attributes should be marked, as per the old code that did this via the `used_attrs` vec.


btw how about the name, I thought about `--vt-additional-params`, `--vt-params`, `--vt-extra-params` or `--vt-override-params`.

(extra-params is hazardous as extra_params means qemu-kvm params in virttest)


`commit --amend` doesn't seem to have changed author or e-mail.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 848](https://teamcity.mesosphere.io/viewLog.html?buildId=58648&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:04:19


Damn it, sorry! Actually, I forgot to set a variable LIBCLANG_LIBDIR at the bottom. But yeah that works of course too.


Need proper tab !!


Testing comment.


Added pausing animation


Just noticed that.  There are more elaborate ways that I've used when doing the CVS to git transition…


Also learned that saying "addresses #201" isn't the same as saying virtually any other synonym for "addresses."  (For example, if I'd said "fixes #201" that would have closed the issue automatically.  Right?


Er, I thought the Hack typechecker raised an error if you defined a PHP4 constructor. Can you file an issue about it if it doesn't?


The values are just for testing.


OK, I've got to go get ready to teach.  If you have another way for me to try to fix the mistake, let me know.  Should I manually close the issue?


Oh, nvm I see this loop is short-circuited when 'not a stability level'.


Yes, [fixes is correct](https://help.github.com/articles/closing-issues-via-commit-messages/). Yes, you could just close it, I think.


```
if r.idx.IsInFlight(*id) {
debug.Log("Repo.Save", "blob %v is already being saved", id.Str())
+		return *id, nil
+	}
+
+	// add this id to the list of in-flight chunk ids.
+	debug.Log("Repo.Save", "add %v to list of in-flight IDs", id.Str())
+	r.idx.AddInFlight(*id)


It mostly depends on the size of the array, and the access pattern. I would
say in the majority of cases yes, otherwise O(N) would rule data structures.
Unless you means sorted array, which has similar lookup complexity, but
worse insert/remove ones. This is why no known, non toy, VM implementation
uses arrays for VMA management.
RB (but mostly many other implementations as well) trees have predictable
latency.
I chose RB trees because they are the ones I used most, and because they
are used in the VM I know better (the Linux one). Which is not too shabby
in terms of scalability ☺

On Wed, Oct 14, 2015 at 9:39 AM, Dan Cross <notifications@github.com> wrote:

> I'm not sure if github sent my comment (above); perhaps if I write here it
> will.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dlibenzi/akaros/commit/2b7e6c06c689a7b386d4fed5c9613b17bf2916fb#commitcomment-13772308>
> .
>


Ok, good catch. I'll fix this.


@mseaton  lmk  if you need me to look at anything here...


Yes, we should switch to machine-readable info as soon as it's available.


this could almost be called `NullSafeCollectionUtil`.

does stab still follow the silly convention of leaving the "s" off of the name of utility classes?  because i really don't think anyone else in the world does it this way.


Well, that's not fair.  It's not just fixes:
https://help.github.com/articles/closing-issues-via-commit-messages/

But "addresses" isn't one of them.  It might be the only synonym for "fixes" that isn't allowed.  :)


:smile:


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 850](https://teamcity.mesosphere.io/viewLog.html?buildId=58659&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:03:55


> I do not have a test for that yet, but it would be super sweet if this got merged today, as the hackathon problems depend on it.

Your hacks have to be merged in order to count for the hackathon?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.670](http://teamcity.monogame.net/viewLog.html?buildId=10617&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:19:29


TeamCity ReOpenLDAP :: devel-2.4 [Build 201](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1011&buildTypeId=ReOpenLDAP_Devel24&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:41:40


This appears to set the unstable reason to the deprecated reason only when the unstable reason is None, but the previous code did that assignment unconditionally. Is that true? If so, why the change?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 849](https://teamcity.mesosphere.io/viewLog.html?buildId=58655&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:07:28


OK, short steps for fixing these mishaps (usage should be rare, I think currently not too many of us are working on top of what you just committed):
```
git diff HEAD~1 > patch
git reset --hard HEAD~1
git apply patch
git diff # check that this does the right thing
git add lobster/cmssw/workflow.py
git commit
# check everything again
git push -f origin master
```


will remove spacing


BTW, as part of the patch, I also coded a stress test. In primis to
validate the code, but also as trivial benchmark.
I will try to run it on real HW as well (I need to port my utest test case
into a trash branch off current master, to compare).

On Wed, Oct 14, 2015 at 10:28 AM, Davide Libenzi <dlibenzi@google.com>
wrote:

> It mostly depends on the size of the array, and the access pattern. I
> would say in the majority of cases yes, otherwise O(N) would rule data
> structures.
> Unless you means sorted array, which has similar lookup complexity, but
> worse insert/remove ones. This is why no known, non toy, VM implementation
> uses arrays for VMA management.
> RB (but mostly many other implementations as well) trees have predictable
> latency.
> I chose RB trees because they are the ones I used most, and because they
> are used in the VM I know better (the Linux one). Which is not too shabby
> in terms of scalability ☺
>
>
> On Wed, Oct 14, 2015 at 9:39 AM, Dan Cross <notifications@github.com>
> wrote:
>
>> I'm not sure if github sent my comment (above); perhaps if I write here
>> it will.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/dlibenzi/akaros/commit/2b7e6c06c689a7b386d4fed5c9613b17bf2916fb#commitcomment-13772308>
>> .
>>
>
>


Can u send for me dataset for test?. My email:khiemnd5@gmail.com
I wait for u!
Thank u so much!.


I'd still like to see this reverted to use `strcmp()` and `inet_ntoa()`. But I guess I can merge your PR and revert only this hunk ;-)


Oh, it looks like the old structure only supported a single reason, while the new supports both an unstable and deprecated reason. Which does rustdoc display under the new regime?


LMAO


`cargo rm non_existent_crate` should return an error like "cargo-rm: crate not found." This implementation just makes all errors a ManifestError, so the caller can't tell why the op failed.

I suggest we change the API contract for `insert_into_table` and `remove_from_table` to `Result<Option<toml::Value>, ManifestError>` following BTreeMap's insert/remove.


Yeah, you can change that default too if ya want LOL


This also needs test coverage! Looks good otherwise


this is already in this PR that have other change to debugprint:

https://github.com/nouiz/Theano/commit/c2810beb1e475cdf50d7c4befcc00ca8b45a3f30

Can you simply remove this commit?


I've notified Igor about this. If you really think this patch is a blocker for merging the whole series, then please let me know and I will remove it from the series. Now that the "-Werror" is gone from the CFLAGS/CXXFLAGS, a warning will not be fatal to the build.


and remove this one too as it is a follow up on the other one.


http://php.net/manual/de/security.magicquotes.php

There is no such thing anymore as magic quotes.


Thanks for the review! Please see my reply inline. I'd rather not remove the patch, but in the end it's your decision.


Opa Thiagão alterei a parada!


Danke, viel besser so!


```
+	if r.idx.IsInFlight(*id) {
+		debug.Log("Repo.Save", "blob %v is already being saved", id.Str())
+		return *id, nil
+	}
+
+	// add this id to the list of in-flight chunk ids.
+	debug.Log("Repo.Save", "add %v to list of in-flight IDs", id.Str())
+	r.idx.AddInFlight(*id)
```

This code is risky - think about this example of two goroutines processing the same blob concurrently:

time  | goroutine 1 | goroutine 2 | comment
------ | ---------------- | --------------- | --------------
1      | r.idx.IsInFlight(someId) == false |  -   |
2      | -                                                  | r.idx.IsInFlight(someId) == false | -
3      | r.idx.AddInFlight(someId)           | - |
4      | -                                                  | r.idx.AddInFlight(someId) | overwrites existing entry created by goroutine 1
5      | ...                                                | ... | both goroutines continue working on the same blob => leads to "pack not referenced in any index" error

Consider changing the code towards

```
err = r.idx.AddInFlight
if (err != nil) {
    debug.Log("Repo.Save", "blob %v is already being saved", id.Str())
    return *id, nil
}
```

In order for this to work, AddInFlight must refuse to overwrite an existing "InFlight" entry, just like the former StoreInProgress-method did.


Won't this also lock people out of using the current captive portal with opnsense-devel?


You serious? Couldn't find a worse way to implement this? log(n^2) for a simple router?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 851](https://teamcity.mesosphere.io/viewLog.html?buildId=58660&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:03:52


I don't like this method name. It make me thing that it take an fgraph as input.

What about cmodule_key_graph? this would mean a user graph. or cmodule_key_variables?


These new teaser boxes are expandable! The line can get a bit cramped, but other than that, it doesn't look to bad I guess.

![screen shot 2015-10-14 at 7 35 46 pm](https://cloud.githubusercontent.com/assets/115237/10492193/daf2e52a-72aa-11e5-91af-baffc7379d4d.png)


Testing comment No.2.


added some coverage. pls review


(not the end of the world, but I am curious if somebody is gonna submit a report sooner or later with this particular twist)


Hi,

1) I suspect you're asking how to look a the changes to the original..
I suspect make a branch and compare it ?
WinDiff? Fork? many ways :)

2) It does work to an extent, and by that I mean, once you work on a project you understand the full scope of things. You can use JSBin. Fiddler or just an HTML page with script, all ok to test it :)

3) In general there isn't tons of info, nor do I 100% understand the usage, but in this case I would suspect rsrc1 should be unusable (closed), but the expensive resource should still be available.
This is a classic example of a reference counted resource in C++ and other object oriented languages.
In our case that object would be deleted, but the other the other reference is still kept (you can check that in a browser). However another call to NAMESPACE.resouce('048c') would find that the object at the key is null, which is not exactly what we want, so we would need to add reference counting to make this really work.


OK, hopefully this is better now?


Is ManifestError still that empty struct? Feel free to change that to an
enum with useful values! (In my version fetch PR I already introduce
quick-error as a dependency, by the way.)

Bob Gardner <notifications@github.com> schrieb am Mi., 14. Okt. 2015 um
19:34:

> cargo rm non_existent_crate should return an error like "cargo-rm: crate
> not found." This implementation just makes all errors a ManifestError, so
> the caller can't tell why the op failed.
>
> I suggest we change the API contract for insert_into_table and
> remove_from_table to Result<Option<toml::Value>, ManifestError> following
> BTreeMap's insert/remove.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/killercup/cargo-edit/commit/44cdc9f6c0dfed1d18f4b7baae25ac23b2ba73ce#commitcomment-13773496>
> .
>


Also, when can we cut a release for this so that eraser-map can use a scene file that runs sanely on tangram-es? :)


Well, the number of redirects is ridiculous small, so it does not make any difference ;-)


The comment icon in the teaser is gone :[


I thought they always were expandable :confused:


The type annotations in `fom` and `for` are actually redundant - the variables' `number` types can be inferred from their initializer expressions.


It is small now, but the "list" will grow - not shrink


Might do another release, if you like the changes :wink:


I see your point, _all_ids is defined within the scope of the curly brackets and var states that it will be only local to this file. It looks, like the protection at the top would want to prevent it from being called multiple times (maybe the use of require or non ES6 modules?) in which case perhaps it's better to use it without the var, and make it global (which present different problems). However since this is too detached from the total scope, plus not a longer term paid work, my involvement is limited and it's hard for me to suggest the ideal path here :)


There's likely several others that can be done now too: this script is over 4 months old. :(


I ended up removing them all.


LOL three days in-a-row :dizzy_face:


done


you're right, I will try to wrap things up a bit this week and change the link as well... the new version is quite functional already, and I want to avoid loosing my local changes in this area :)


okay sure


i haven't seen you do this before either brandon.  does intellij do it for you automatically?  if not, it would be a headache to maintain.  (one of the few places where having tabs would actually help.  mostly.)


You'd also need to include those IP-related headers at the top of the file, and this would prevent the tests from passing in Windows (but I can patch it myself when I prepare an MSYS2 package).


This `user-info` field was getting added to requests in `donkey.core`, but that was removed by commit c64e3b2ad73fc78074d9c9346398f8a7f8c251e9. I'm not sure why it was removed there, but this seems like a good place to add it back in.

When I added the `csv-parser` endpoint, I thought there was an issue for converting all Donkey endpoints to lookup user info from the request params, rather than looking up the info from a global `current-user` map, but apparently this new `csv-parser` endpoint is the only one looking up user info from the request so far? :confounded:


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 852](https://teamcity.mesosphere.io/viewLog.html?buildId=58661&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:04:01


We could easily make it a user option whether to use 'Vagrantfile-directory_name' or 'id' as the hostname. Using 'id' would save second call to `vagrant global-status` to complete the round trip, but it also comes at the cost of offering auto-completion for semantically meaningless ids instead of meaningful names.

Even as obnoxious as it presently is to wait for `vagrant` to finish a second time, for myself it's better than having to memorize my box ids. Finally, we have other options for minimizing the wait, such as caching the output of `vagrant global-status` in a file which can be read back in by `vagrant-tramp-ssh`.

The reason I change the working directory is actually unrelated: it's to accommodate badly behaved Vagrantfiles. Many examples from the wild are developed and tested with the assumption that the Vagrantfile directory is the current directory, breaking when that assumption is violated. That is obviously a bug in the Vagrantfile and not in TRAMP or vagrant-tramp, but if by changing the current directory we can deliver a better user experience, to my sensibilities that's a win.

For an example of such a broken Vagrantfile: https://github.com/taigaio/taiga-vagrant/blob/master/Vagrantfile


Can you wrap the text area in a `ScrollPane` please (you'll see examples in other panel views)


If you're worried about the readibility, why not just change the IP address 1.2.3.4, so the hex conversion is easy?


The parameter generally won't be the same type as the return value. Anyway, since TypeScript has parameter types declared inline, there doesn't seem to be much reason to have {type} annotations in the javadoc's parameter lines.


:ship:


@starrynte Rather than using your own custom function to format the time in a nice human readable string, use Moodle's format_time() API: https://github.com/ucla/moodle/blob/5f5dbeb9ce5d567b9f8f91d33aadd281711c79cc/lib/moodlelib.php#L2085


不適切な表現が含まれていると思います。
修正してください :-1:


This is not my package, I merely changed the ANTLR dependencies.


This error message seems strange given the branches taken to get here. What I think the *logic* here says is that 'if we have both deprecated and stable attributes, and also an unstable reason, emit an error'. The error emitted though indicates that we saw deprecated but not stable. I think the logic is right - unstable+deprecated things get their unstable reason from the deprecated attribute - but not sure about the error message.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 853](https://teamcity.mesosphere.io/viewLog.html?buildId=58662&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:06:19


Even if you put all relevant links in it, it's still small.

Of course you're right. So what are you proposing? A hashtable sub -> array with (description, target, section, display)?
Then we have redirects in log(1), and the building of the frontpage in log(n) (however we could make the frontpage completely static, only updating the page once on a git push event).


I better get a notification about this!


@starrynte Looks great. Other than some more code improvements, such as using Moodle's format_time() API, this looks great. Please merge to the development branch after you try out the code improvement suggestion and assign to Amber Stokes for testing.


it would be either / or /v2.0


If you comment out this seemingly extra call to `GetMinFee()`, the test fails.

In `CTxMemPool::GetMinFee()` there's an edge case where, the first time the rolling minimum fee rate decays to below `minReasonableRelayFee/2`, we still return `minReasonableRelayFee` rather than 0, even though subsequent calls will return 0 (because `rollingMinimumFeeRate` gets set to 0, triggering a different code path).

I think it would be nice to clean up this edge case in `GetMinFee()` so that we don't need to put workarounds like this in the tests (I ran into this same issue working on an RPC test for this pull).  I think the minimal change would just be to check to see if `rollingMinimumFeeRate` is 0 after decay before deciding whether to return `max(rollingMinimumFeeRate, minReasonableRelayFee)` or 0.


Shit!!!!!


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 854](https://teamcity.mesosphere.io/viewLog.html?buildId=58663&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:04:01


@eregon please review


https://github.com/ymnk13/UMATracker/commit/10e0f4bd279b9c264bbc1630ab7a3b734abc8716
にて削除しました．（問題なし）


Please follow the indentation style already in the file (4 spaces, no tabs)


TeamCity pull requests :: netty [Build 411](https://garage.netty.io/teamcity/viewLog.html?buildId=2297&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4777, ignored: 21 Build time: 00:29:39


This is already done in the "RedHat.yml" and "Debian.yml".
No, we still use playbooks and not roles. Is this an problem?


AddSwig (Myoldmopar) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This commit in general looks very good. Here are some comments:

- You hardcoded the OIDs for secp256r1 and others. It would be better if you'd merge this with all the existing places where these curves and OIDs appear.
- I know it's not in the scope of your commit, but could you maybe change the magic values in `if (pub_rsa->magic == 0x31415352 || pub_rsa->magic == 0x32415352)` to something meaningful?
- in `CardGetContainerInfo` you removed the check for `vs->p15card == NULL`. Does this introduce a potential problem?
- variable naming could be better, though things like `oh` have been present before.
- parameter naming for `HashMe` could be better
- sometimes you have tabs and spaces mixed up, please use tabs only for indenting
- what stands 48 for in `pbBuffer = (PBYTE) LocalAlloc(0, 48);`? Can you use a define?
- can you use defines for the following magic values `if (dwProtocol == 0x301 || dwProtocol == 0x302`?


93653546-FuelGenShowingInABUPSwhenPV (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (835 of 835 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.31%25-green.svg)


Curious, why the change?


Perfect!


plz move to didEnterBackground instead to keep launch/resume responsive


check indentation of method declaration


Right, this accepts comma separated values


For logging, the user information needs to be in a `user-info` key. No problem with it being in the request itself, but logstash is configured to look for the json in the `user-info`key


Don't need `== true`


@skavish please take a look


Make sure you are testing with latest github source, and without modified any file.


@mhvk I've made the recommended changes


first of all this setting is deprecated, and we should rather switch to the nova auth plugin. Are you facing an issue due to that ? nova admin should be reachable via the public endpoint.  it is the default anyway:

    cfg.StrOpt('nova_admin_auth_url',
               default='http://localhost:5000/v2.0',
               help=_('Authorization URL for connecting to nova in admin '
                      'context. '

I also remember that I explicitely changed it to PUBLIC_ENDPOINT because otherwise there were tempest failures. did that change?


I confirmed that its working fine.


No método `DesignWizard.GetClass(String className)` ele sobe uma exceção caso a Classe não seja encontrada. No método adicionado, `DesignWizard.GetClasses(String regex)`, retorna uma lista vazia caso não encontre nenhuma Classe que corresponda ao *regex* passado por paramêtro. Acho que isso deveria ser informado no Doc, nâo?


I don't believe I changed the logic here, just kept what was there, moving a few things around. From what I understand, if `RUNNER_USER` is empty the script simply runs as the user who is calling it. If not, then we have to `sudo` and such.

I think the intent is for people to edit the script manually and hardcode `RUNNER_USER` for their installation, if they want to force the script to run as a certain user. Under this interpretation the logic is correct.


Was this done because these modules have not been upgraded to 9.0 yet? If so, what would it take to do this?


This commit fixes part of #3 because it avoids computing SDN stats for virtual ports (virtual ports don't see SDN traffic). Commit message does not specify this (my mistake).


nit: Date is in US format.


`Seq` does all kinds of convenient stuff.  I think there's an argument to be made that adding 3rd party dependencies introduces the possibility of putting conflicts into someone else's build.  (we've run into that problem, even with guava.)  if that's what everyone's beef is, i agree.  it would be nice courtesy.  however, there is a real benefit to not having to rewrite utility methods that someone else has already written for you.  so it sort of depends on how much rewriting you'd have to do on your own, i'd say.


I should say this solution has some limitations. All threads which would normally be blocked on a select now wake up every 500ms (too frequently), and we've also increased the latency for safe points where threads are blocked on a select to 500s (not frequent enough).


Hah awesome, thanks!


wow good programm for students, well done mate


feeling lonely lately?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 855](https://teamcity.mesosphere.io/viewLog.html?buildId=58664&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 180 Build time: 00:03:50


TeamCity pull requests :: netty [Build 412](https://garage.netty.io/teamcity/viewLog.html?buildId=2298&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 4290, ignored: 20; compilation error: Compiler (new) Build time: 00:32:45


just a follow up to the comment above, the thing that's probably screwed us up more than anything is multiple version of jackson, and i'm not sure how he's going to get rid of that dependency.  maybe make it provided?


Don't even know why this happened... I never did anything to these files, but git wanted me to merge (and create a commit in order to merge)...


I think Id should be before name. Also, it's better to have the same order in all places (constructor input, constructor code and class fields).


I agree that 3rd party stuff has it's place and can be useful. I'd rather wait for a real use case before we bring them in though.


This is one of the dumbest things I've ever heard. I've actually lost respect for the team behind this project for bringing gender issues into programming. Some idiots can't tell context and see ".bro" and think it's an attack on them and you bow down to them instead of saying "This is not a gender issue, go away"?


People who are taking this as an opportunity to slander feminist women in particular seem blissfully aware that the change was proposed by a man, and approved by other men. Leave your prejudices at the door.


nice! I wonder how it escaped us before


Should the constraint be `{= "0.9.9"}`?  Or is the idea for dependent packages to depend directly on both `irmin` and `irmin-unix`?


@mogoodrich I have a fix just need a ticket.  Working on that now


Small thing.  Should be vars["current_host"] = machine.Hostname?


this seems weird and breaks clients of the REST API. If task is `None`, I guess you expect `task` to not appear in the JSON object at all instead.


I suggest to deploy it to production, just this fix


Anyone else getting MM errors about Tantares_Engines.cfg file? It was something about using space in configuration names, can send log if needed.


I'd change:
Assume the order of gtfs stations as of scanned
to:
This method assumes the order of @gtfsStations is the same as @scannedStations.


The test in itself is a bit confusing, 192.168.0.1 is read back and checked, but not 192.168.0.325.  I tend to be picky about both readability *and* consistency.  Otoh, the Ethernet address tests use `memcmp()`.  Also, I guess I could refactor that test bit to make it better.


Let's assume that `NAMESPACE` is the only thing that should (potentially) belong in the global scope. Do you have any ideas on how `_all_ids` might be kept private, but still usable in this context?


Yep point taken, I will do that from now on :+1:


nit: redundant new line.


Or should we grab the newest version of dir_monitor from https://github.com/berkus/dir_monitor ?


I think there was a plan to modify all Donkey endpoints to look up user info from the request, but the endpoints haven't been modified yet.


ejkafcd;ofj;xflv


When is this necessary/not necessary?


@buskamuza As Matt indicated, the registration approach solves the need for the unsupported symlink method. However you will still want to either fix the symlink method that was broken with this code or remove it from this package altogether.


LGTM.


> I suspect make a branch and compare it ?
> WinDiff? Fork? many ways :)

What would be a good way to make available in this context?

> You can use JSBin. Fiddler or just an HTML page with script, all ok to test it :)

Are you suggesting that the onus is on the onlooker to pick an environment and write tests to validate your changes? Are tests in JSBin, Fiddler, or HTML pages easily automated?

> However another call to NAMESPACE.resouce('048c') would find that the object at the key is null, which is not exactly what we want, so we would need to add reference counting to make this really work.

Care to add this?


I know it ain't code, but it's in git; needs a trailing newline.


LGTM (assuming it's actually faster).


Surprised I missed that; thanks


:laughing:


@Aramiyo the team stated clearly that they themselves did not understand how it could be offensive, but choose to err on the side of caution. The change itself was proposed by a (male) dev at Mozilla Whether or not that is a wise decision has been the entire debate in this thread (except the usual trolls and contrarians, of course), but make sure you understand where the idea itself came from.


By about two minutes!


What is the problem?


looks good to me


it is kind of a 10-years-ago complaint i think.


I think this is ready for stable


Thanks to @kcropper for pointing this out in #64 — looked like a copy/paste error


I thought `TRAVIS_*` environment variables were special to travis, i.e. travis sets them. Maybe we shouldn't infect that namespace (if this works, I don't really care).


LGTM


Perhaps you should also display the gtfs station?


This should be `&& !in_array('29', $addCategories))`


The travis build system runs into [this](http://stackoverflow.com/questions/2418157/ubuntu-linux-c-error-undefined-reference-to-clock-gettime-and-clock-settim) bug.


Additional items in the log handler are sent as kwargs to the exception class.  With the exception of 'template', I pass the kwargs directly into  the attachments dict so users can easily override the rich formatting settings.
```
'slack_admins': {
                'level': 'ERROR',
                'filters': ['require_debug_false'],
                'class': 'django_slack.logs.SlackExceptionHandler',
                'color': 'danger',
                'template': 'custom_project/slack_exception.html'
            }
```


@jramos-spanning even for a test?  that's just weird.


is it a problem when two objects that aren't actually equal have the same hashCode?


This should be `&& !in_array('13', $addCategories))`


Well, I can't work on this right now, but maybe I'll do something later tonight if you haven't merged in the pull request, or merged in something that doesn't work on Windows.  The "192.168.0.325" is an invalid address so that's probably why it isn't checked.


nit: i know this was already like this, but can we refactor `displayHTML:` to accept 0 arguments, and use `self.text` instead?


nit: redundant new line.


Why?


nit: Date is in US format.


spaces


why is this on 3 lines?


Is daar dan source van?


This code is invalid.
First of all, you forgot to prepend an `x :`, so we'll end up with the empty list.
Secondly, filtering for selfReferential every iteration of the function makes the function perform even worse than it does right now.
I'd vote we revert this change.


You're right. I'll change it to `ZCTRAVIS_`. (We can bikeshed some other day if that matters.)


pausing here.  i've got a day job to get back to.


Since `'NumberOfDataArrays'` is optional:

    if self.expected_numDA is not None and self.expected_numDA != self.img.numDA:

And you'll want to initialize `self.expected_numDA = None` in `__init__` or in the class definition.


Well, as I see it even if this would be $urls[] the result would also be $urls[0], $urls[1], $urls[2]. However, I am sure it works as it is and this is not making the code slower, so let's leave it like this for better control.


bueno aca corregi el proyecto para la vercion 1.1.0 de pilas:
importe el tiempo
cambie el fondo
modifique la funcion de mono destruido
le modifique el radio de colision al mono
defini la funcion de terminar el juego


alignment


git config --global user.email "zoomzoom171@gmail.com"


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Space missing between `#` and `expected`.


This doesn't make sense. Why would we downgrade?


nit: this is basically an overly complicated map/reduce. would be nice to refactor it to use BlocksKit


What's then the difference between not accessable and not existing packages? Or in other words, why not remove one of the exceptions completely? (I would vote for UnknownObjectError)

That would basically match with ruby's [duck typing](http://rubylearning.com/satishtalim/duck_typing.html). If it walks and talks like a duck it's a duck. And if it's not accessible like a package, it's not a package, but a ReadAccessError.


probably because i've never done it that way.  not sure why.  i guess i've never seen anyone publish javadoc for a test though.


looks like a switch statement would be more appropriate here


correct. Just fixed with the last commit


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 856](https://teamcity.mesosphere.io/viewLog.html?buildId=58667&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 180 Build time: 00:03:58


TeamCity pull requests :: netty [Build 413](https://garage.netty.io/teamcity/viewLog.html?buildId=2299&buildTypeId=pulls_netty&guest=1) is now running


aside from cosmetic formatting issues, this looks good to me!


FYI - it did not actually take me 5 months to code a hi-score table! I've just been away from this project for a while... On the bright side, it's pretty much finished!


if we're gonna remove the column constants why
`" INTEGER DEFAULT 0, " + "m_id" + " TEXT, " + "sub" + " TEXT, "`
instead of
`" INTEGER DEFAULT 0, m_id TEXT, sub TEXT, "`


Nee, er zijn een stelletje idioten geweest die [hier](https://github.com/DutchCodeGeeks/MATA-PHP/) iets gemaakt hebben, maar dat klopt helemaal niet (meer)


this file has `NS_ASSUME_NONNULL`, and based on impl this should be `nullable`


Isn't Travis wonderful?


Recovered from fading memories of HK

> On 14 Oct 2015, at 04:19, Owen Rodda <notifications@github.com> wrote:
>
> +1
>
> —
> Reply to this email directly or view it on GitHub.
>


So long as two objects that are equal do have the same hash code.


not very beautiful but works :)


the impl file unfortunately doesn't have `NS_ASSUME_NONNULL` (otherwise this would've been a compiler error. can you add the begin/end macros if there aren't too many errors?


@stephen144 Not migrated indeed. I have personally not investigated what it would take to migrate to 9.0. The connector framework will have to be migrated first of course.

:+1:


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 857](https://teamcity.mesosphere.io/viewLog.html?buildId=58668&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:03:54


did you mean to only O_DSYNC when (possibly) creating the object?  it seems like a simple

<pre>
if (g_conf->filestore_odsync_write)
   flags |= O_DSYNC;
</pre>
would do it


I think depending on irmin + irmin-unix make senses (I never know which version constraint to put on virtual packages)


I think it reads clearer as to what happened


Out of interest, why is using `@DataBoundSetter` obsolete?

I understand removing `newInstance()`, but `@DataBoundSetter` was explicitly added so that developers no longer need to stuff loads of data-bound parameters into the constructor.


Tapping out of that one… out of scope


@DouweM while maintaining additional aliases doesn't _seem_ like a lot of work, let me assure you that it's cost dozens of maintainer-hours that would have cost many thousands of dollars if they had been paid for.

Given non-infinite resources, the Bundler team has to aim for the 20% of work that delivers 80% of the value to the wider Ruby community. Today, GitHub has 10 million users, BitBucket has ~2.5 million users, and GitLab has "hundreds of thousands" (by your count). I can understand that you care more about GitLab than the others, but as you point out, the "millions" of users running GitLab have their own servers. That means that they all need to set up their own `git_source` blocks to use the shortcut, and GitLab should be helping them do that if you want to help your users.

Asking us to do equal amounts of free work to support 80% of users (GitHub), 20% of users (BitBucket), and 1.3% of users (GitLab) would be very political—it would be a pointed and unfair favoring of GitLab.

We're keeping GitHub support in core because it hits the 80/20 point very nicely, and we're providing extension points so that everyone else can add a shortcut for whatever they use, whether that's GitHub's Gists, BitBucket, GitLab, or literally any other git server.

I think we've reached the end of the road here. You're welcome to reply however you like, but I'll bow out of this thread now.


Yeah, that's lame. @jramos-spanning suggested apache's http client (which I considered). Is everyone happy if I use that, instead? If not, better suggestions are welcomed.


@vdietsch `Jackson.newObjectMapper()` is a Dropwizard thing.


Looks good to me as long as it never hit the scenario mentioned in below example in future.

Example:
if someone explicitly assign a reference to a dereferenced NULL pointer, reference will be invalid:
 int *x = 0 //or NULL;
int& y = *x;


Looks like I'll need to open another PR, anyway, so it'll be included in that branch's commit(s).


why the names array? Why not just call `model.TableName()` here?


@sbidoul Is there documentation describing what, in general, needs to be done to migrate old code? Is it just updating old API calls?


`'/' + '/'.join([]) + '/'` would be good, too.


So much css


I'd be fine with this approach.


My terrible-ness with Go, mainly.  `interface{}` does not have a method `TableName`, and I made an array of the interfaces (since they're different types of objects).  I'd have to cast them to the right type.  Gorm does have an interface for something that has named tables, but it's private.  :|


same as above for column consts


Should we check if the table already exists before attempting to create it? Or are we just relying on MySQL to return an error in case it does?


This example should trigger a warning with a decent compiler.


Okay, I see. Thank you @adam3smith


Also, could we create automatically when the table doesn't exist?


I initially wasn't going to make it an interface, but InfluxDB _does_ allow writes using UDP. Not saying we'll ever use it, but I can't think of how many times I thought, "we will never have another implementation", and then someday we did.


Well, it's becoming more and more rare that people don't go for responsive in all cases, but let's just assume.
I don't see a difference in behavior until runtime, at which point it seems like the responsive / non-responsive decision can be made by the theme. Semantically, it's just a row in both cases, and it seems like the editor will treat them the same. I don't see a case where you'll have both types present in the same layout.
+1 to being able to specify breakpoints (we have that on Onestop.Layouts), but that doesn't mean separation between responsive and non-responsive: the non-responsive case is just a limit case of the responsive one, where no breakpoint exists.
It seems like to get that one right, the whole editor should be able to switch between breakpoints. In that case, the 12 rule can be maintained in desktop mode, and might actually be also maintainable always. We should take that discussion elsewhere as this looks like an entirely new, and large feature.


Recommend :file:`src/test/java` for path and file names. But minor issue.


No argument there.


broke our deploys too :(


I think I clicked "reformat code" or something in IntelliJ when I switched from tabs to spaces. I will change it.


Not sure if you removed this TODO in the other commit.


Noted. I will change the exceptions to be unchecked.


@abeskrowni-spanning I think our only convention is unconventional-ness. I'm pretty sure we do it every way, every day.


What is the impact of removing the following?


:+1: for using `exec_params`


this method name doesn't make sense to me (i had to look at where it was called). maybe insertCompletedAttachments() or something like that?


didn't we say we'd assert here? would be nice to know if we changed something about this that caused us to load the view as a side effect of changing the tweak


Why are adding the serialized form parameters? Form parameters are added to the URL when the form is submitted automatically.


align


shots.. lol

Op wo 14 okt. 2015 om 20:09 schreef Sibren Talens <notifications@github.com
>:

> Nee, er zijn een stelletje idioten geweest die hier
> <https://github.com/DutchCodeGeeks/MATA-PHP/> iets gemaakt hebben, maar
> dat klopt helemaal niet (meer)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Magister-Android/magister-api/commit/ef2eb210f17f81f5d6a522fdb01b8caa41236cf3#commitcomment-13774327>
> .
>


Is that really  supposed to be 0.35, not 0.36 which will be used for the RP part of the tutorial?


Oh you removed the braces too? I was begrudgingly ok with removing the parens but you've gone too far. You're literally a monster.


instead of checking for xfs everywhere, just go by g_conf->filestore_do_fast_sync.

if we want to only allow this for xfs, then we should do just one check for xfs vs this option in _sanity_check_fs() and error out if it's incompatible.  or warn.. it's not clear that this would work any worse with ext4.


I did it the other way around (`writePoint()` has a default implementation that delegates to this one).


@tdilo Thanks for the report. It's been fixed.


Bad, BAD


We're horribly inconsistent about it.


Probably the easiest path is defining your own interface, having it have a `TableName()` method, and then create the array with that.

@endophage for suggestions


The problem with that approach is that, since AST literals and runtime values are the same thing, any array literals specified in the AST will end up being mutated. That is the array specified in the AST node will get mutated, so subsequent runs of the same program might produce different outputs, since the value of array literals have changed. To solve this problem, I pushed arrays into the environment, and made `Array_value` an identifier. Another possibility, I suppose, is to go with `| Array_value of ast_uid * var array`, and then disallow (through well-formedness checks) `Array_value` literals, though both approaches feel sketchy to me.


You can add a static function to MainModel called getBssidMap that just does:
return MainModel.getInstance().getBssidMap();
to make these calls shorter.


Ahh. Missed that.


AFAIK there is no such documentation. If you are lucky, modules will just work with 9.0. Most of the time, views have to be adapted a little bit, but in some cases there are indeed API, algorithms or data model changes.


What would happen here if the request does not exist?

Beside the indentation is wrong


Specs for the opts parsing!  Thanks!


http://127.0.0.1:8000/admin/participants/participant/
Action: Initiate lottery call.

K.

śr., 14.10.2015 o 18:34 użytkownik najtek <notifications@github.com>
napisał:

> Tymczasowo.
>
> W dniu środa, 14 października 2015 Kamil Kujawiński <
> notifications@github.com> napisał(a):
>
> > Potrzebujemy tego?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/kkujawinski/talktoyourapp/commit/e10c3c64bb929877d5c1790668115761b2d70637#commitcomment-13769410
> >
> > .
> >
>
>
> --
> Marcin Najtkowski
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kkujawinski/talktoyourapp/commit/e10c3c64bb929877d5c1790668115761b2d70637#commitcomment-13772165>
> .
>


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 859](https://teamcity.mesosphere.io/viewLog.html?buildId=58675&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:27


I wasn't sure about the 'block' for the assert statements at the end. All the resources that I read had them in the functions/ blocks they were directly being utilized in. Let me know if I misunderstood the directions for this. Thanks
GM


TeamCity pull requests :: netty [Build 414](https://garage.netty.io/teamcity/viewLog.html?buildId=2300&buildTypeId=pulls_netty&guest=1) is now running


sorry i didn't mention this before, but afaics the odsync part is not related.. can that be broken into a separate patch too?


This is JavaScript, yo.


See https://github.com/mirage/irmin/pull/324 for a fix which seems to make irmin-go happy

Having proper release criteria/automation would certainly be nice...


I originally removed this, but put it back because I want to make sure libsnark doesn't change on us. (I filed an issue about this.) Once that's fixed I'll make sure this points to upstream again.


I'm not sure InfluxDB has any other types of auth credentials (I could be wrong). How the credentials are passed (basic auth vs. query params) can vary and is handled by the client's implementation.


@bgerstle I know we have harped on moving faster over the the past week - especially regarding code reviews - but i think we actually need to put this into practice.  This is a good example:

If you find yourself writing "nit" before a code comment just save the time and leave it out.

We shouldn't be addressing nit picks right now, so writing it only wastes time commenting on something that shouldn't be addressed… or worse, someone spends more time addressing a comment that shouldn't be fixed instead of getting to the next task.

cc @montehurd


Ik zie net dat ik een jaar geleden ofzo [de META app heb gedecompilet](
https://www.dropbox.com/s/qmb8j36qq742863/source.zip?dl=0).

Op wo 14 okt. 2015 om 20:18 schreef Max Verbeek <m4xv3rb33k@gmail.com>:

> shots.. lol
>
> Op wo 14 okt. 2015 om 20:09 schreef Sibren Talens <
> notifications@github.com>:
>
>> Nee, er zijn een stelletje idioten geweest die hier
>> <https://github.com/DutchCodeGeeks/MATA-PHP/> iets gemaakt hebben, maar
>> dat klopt helemaal niet (meer)
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/Magister-Android/magister-api/commit/ef2eb210f17f81f5d6a522fdb01b8caa41236cf3#commitcomment-13774327>
>> .
>>
>


Just in case we use a stage 0 proposal. The style guide won't break but topnotes will.


Good call.


Ta struct est pas mal. J'avait fait un test aussi coté branche ViewAbstraction pour modéliser le graphique... Fais un tour et dit moi ce que tu en penses. Ca découpe mieux et aide a la comprehension normalement.


This is temporary, for the next couple of days (for extasy users). All the
changes in ensemblemd ( with rp0.36) are in a different branch. After the
current round of testing, they will be merged with devel, master and
released.

Vivek

On Wed, Oct 14, 2015 at 2:18 PM, Andre Merzky <notifications@github.com>
wrote:

> Is that really supposed to be 0.35, not 0.36 which will be used for the RP
> part of the tutorial?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/radical-cybertools/radical.ensemblemd/commit/ade721c3167b757b275e8c070b97aee0393ce151#commitcomment-13774519>
> .
>


Damian ile sie napisałes!! mój opis to chyba bedzie 1/10 tego :D


And I forgot I ever set it to 0 in the first place!


its impossible for this to be called before the above is true


The tests are currently only against sqlite3 (they generally do create a table, there were just a couple tests that want the tables to not exist - I can just drop those instead of not creating them).  Are you saying we want to add in a test for mysql as well?


Broken dependancy: `underscore` needs to be available on the client because of [collection-client.js](https://github.com/meteor/postgres-packages/blob/master/packages/pg/collection-client.js)


Non up to speed on why we need this. Why do we call it translateOldVersion?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 860](https://teamcity.mesosphere.io/viewLog.html?buildId=58676&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:04:06


align


@fons @kpoplin made some changes.  I think it's good to go, except not sure about the product name.  Is it Scope as a Service?  or just Weave Scope?


> Нет смысла в равенстве значений разных типов, это ошибка, а не False.

Есть конечно.
```python
def is_equal(shape1, shape2):
    '''
    >>> is_equal(Triangle(1,2,3), Circle(1,1))
    '''
    return shape1 == shape2
```


No, it's fine. Just curious.


parallel mode is only used by btrfs/zfs ... this code is effectively dead.

which reminds me, the fs sanity_check should make sure do_fast_sync is only used in combination with the writeahead mode


The http versions are to provide a consistent message for exceptions that are thrown because of the response received from InfluxDB and to allow access to the status code/response body or error message.

The other reason this is separate is to differentiate itself between exceptions not related to the http response (e.g., parse exceptions, exceptions caused by some `UnirestException`).


Here's Comment #1 on Commit #1


The assertion is triggering on x86 builds while compiling the class libraries.


https://github.com/docker/notary/pull/215#discussion-diff-41933116 was the discussion this came out of.  Because there might be a race condition in which someone inserts after we check and then insert.

This function translating database errors to a generic error in which we know someone is trying to push an old version of a TUF file or timestamp.


right, just wanted to clarify this was intentional, and that you judged this (implicit) contract to not be worthy of an assertion. thinking about it some more, in this case since it's only related to tweaks I think it's fine to not assert here.


Delete


should this be checking wbthrottle_enable?

(and enforce elsewhere that wbthrottle_enable is not used in combination with do_fast_sync?)


And one more


> Нет, упорядочены могут быть не только числа.

Я такого и не говорил. Я говорил что нет смысла делать упорядоченным любой enum.

> И даже не обязательно отождествлять что-то с числами, чтобы упорядочить.

И такого я не говорил. Я говорил, что отождествив что-то с числами получаешь упорядоченность.

> Операцию сравнения можно ввести просто так.

Просто так? Тогда я могу захотеть чтобы у меня reversed([1,2,3]) был не равен [3,2,1] просто так :)


wait why can't we just put this in onRun() for the push media download job. this will return true, allowing onRun() to be called which can then choose whether it wants to change the db state to started.


Fixed as of 4c8afb5de2b094f5d530a3e18ef37b1ac6cba038 and ca6b9f210d42c7aed767947cb4f927b495d6ad3a


nit: Date is in US format.


align


See PR https://github.com/meteor/postgres-packages/pull/50


A really good first effort. Don't let the number of comments make you think otherwise. Another thought - since this is its own project and depends explicitly on influxdb, we really should have integration tests for it.

We can install a .deb into travis:
http://docs.travis-ci.com/user/installing-dependencies/#Installing-Packages-without-an-APT-Repository

Here's the instructions from the influxdb site:
~~~
wget https://s3.amazonaws.com/influxdb/influxdb_0.9.4.2_amd64.deb
sudo dpkg -i influxdb_0.9.4.2_amd64.deb
~~~


If you break this into sync_entry_fast_sync() and sync_entry_normal() then we won't have the indentation change and the diff will be readable...


thanks! :pizza:


@ahmelsayed  I think it's wrong to have double quotes around `DNX_RUNTIME` (and also `DNVM_CMD_PATH_FILE`). This causes a funny command line when we later have `call %DNX_RUNTIME%\bin\dnu publish`, with quotes in the middle of it.

Generally, the rule is that when we define paths, they never have quotes, but when we launch a command using them, we always add the quotes.


this should be a tunable, not hardcoded at 1ms


&git init
#git add
#include < stdio.h >
int main (void)
{
puts (“Hello world”);
return 0;
}


@vdietsch I think you answered your question in the response to your comment. I couldn't think of a situation where both types of exceptions would be thrown and handled in a single `catch (InfluxDbClientException e)` block.

Everyone else: I mentioned it before, but I will reiterate that I'm changing the exceptions to extend `RuntimeException`. God, I'm so behind the times.


`db.NewScope(model).TableName()`


this loop doesn't make sense to me.. you never use the it iterator inside the loop.


Yeah, hopefully in the next go, most of them will be gone.


@endophage thanks!


Steve,
  Just a general comment.  I spent over 2 hours trying to get FactoryGirl to create a Family and a Parent.  I think there is something I might be able to do with ```after :create``` in the spec/factories/families.rb file.  The "hack" above works but I am really not happy with it.  We can discuss on Saturday, I think for my seed data a parent should always be associated with a family.  BTW I know I can drop the ```FactoryGirl``` prefix in the ```before do end``` statement, is this common practice?


oh.. you assume that last_jouranl_commit_seq == applied_seq_map.begin()->first - 1 when you begin, and entries are contiguous?  in that case, you should use the iterator and not operator[] as that'll avoid traversing the map<> rbtree


@paulhernandez: I'll add some debug logging in the class.
@jramos-spanning: Will do.


Maybe you can shorten it like this:
public static final Set<String> SET_BSSIDS_A = new HashSet<String>(Arrays.asList(BSSID_STATION_A, BSSID_STATION_A_2));
Then you don't need the String[] consts.


All good points.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 861](https://teamcity.mesosphere.io/viewLog.html?buildId=58689&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:03:49


missing `|| die` (yes, at the end of this line)


CSS3 can also be removed.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 862](https://teamcity.mesosphere.io/viewLog.html?buildId=58690&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:10


I updated the width, but also optional.


Ah, yes, maybe a user should edit the file. I thought that `RUNNER_USER` was to be used as an environment variable.


Really quick thoughts because $summit :smile:

I think we will use the fetch metadata as it is against omnitruck for now. We will probably need to change it to use channel, product_name, product_version. `artifactory_urls()` function will be the place where we query artifactory and bake the map into the script we are rendering :smile:

Do not care too much about the version or which folder these live :smile:


maybe add `local size` one line above that, it's good practice, so it doesn't span across other functions


No problem... so `w` should be be scaled, so

`return vec4(SHORT(a_position.xyz) / TANGRAM_TILE_SCALE, a_position.w);`

is that right?

I partially waited to cut a release so we could make sure it was right anyway :)


So it's my code, and i'm pretty sure I want to keep the flow essentially the same :)   I've also heard back from other devs on the team that keeping this pattern is a-ok.

So, as mentioned above, i'm 100% ok with you making the code consistent wrt  ```.``` or ```?.```, or wrt ```.IsKind``` vs. ```.Kind```.  So feel free to update accordingly, and i'll review and sign off.  Thanks!


Sorry - I'm a python code these days. That's just a pep8 warning reflex. I'll get those fixed.


Using user input as a seed seems potentially problematic.


add PCM


nie pokazuje tu docx'a mozecie to spokojnie pobrac do siebie ?  Damian pisales to w notatniku czy w czym ? mi z notatnika nie czyta polskich znakow, a docx tez nie chce dzialac.


It seems like this applied_seq_map/lock/cond business should all be moved into apply_manager (or a different implementation of the same interface).


I'm not sure how much further we'll go with /etc file needs, so I'll just go with libsoc_gpio.conf for now.


Can you think of some descriptive name instead of the numbers 1,2,3? If not a short one, you can leave the variable name and add the description as a comment.


totally agree, i'm not the one that put it here. =)


I got confused and thought we were still in 1.4.2.  :)  Thanks for pointing that out.  Fixed in https://github.com/cyli/notary/commit/b5690cfc514d360c52d9d8610fb4b656526f66dd


The comment here contradicts the code.  Is strong meant to be true or false?


Thanks Chris - this is exactly what I needed!


This dependency looks weird. Usually we do not depend directly on libc at all and even if, you'd rather use `virtual/libc`. But that is guaranteed to exist on any system.


In fact, if you did that, I think you can even avoid changing sync_entry?  commit_start() will do the calculation of hte lower bound seq, which would be returned by get_committing_seq() and written out...


I agree about minimizing third-party dependencies, which is why I'll remove the jooq dependency.

But, you can't argue that:
```java
someSeq.join("\n");
```
is not simpler than
```java
someStream.collect(Collectors.joining("\n"));
```


ugh.


Actually I think I forgot the 2nd parameter (it should be null?)..
I really don't like rcLoder lib.  It seems that to be able to provide the path and filename you'd have to add another config option. Maybe not..


shouldn't need to move any of this if you move the fs check into the sanity check method


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 863](https://teamcity.mesosphere.io/viewLog.html?buildId=58691&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 179 Build time: 00:04:06


Claramente es un commit conceptual.


Just wondering what is the reason for changing jdbc-mysql to :development ?
One of the reasons for my pull req. https://github.com/archivesspace/archivesspace/pull/310 was to add mysql-connector, local config and plugins to the zip file build for a local distribution. Although, (oddly?) since I have a copy of the connector jar in common/lib, that build still seems to work without  the mysql gem being included.


...and these fields would go away


Nah, they don't have to have the same size.


Sort of fixed in 79066c3403360a164c114164568864d235320561 - this automatically creates the tables in the setup and the test that doesn't want them just drops them.

No support for testing against mysql yet, but that can probably be added.  I can look into checking the status of an existing table in MySQL in another PR (for use in creating the tables/migrating tables in a running system)


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 864](https://teamcity.mesosphere.io/viewLog.html?buildId=58693&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:04:04


I didn't even know about that, thanks!


105015426-DefVAVTUMinMax (wfbuhl) - Win64-Windows-7-VisualStudio-12: OK (1909 of 1909 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'd rename to addMatchedStations since it's 2 stations.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 865](https://teamcity.mesosphere.io/viewLog.html?buildId=58694&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:03:59


@benhoskings thanks for the fix! Yeah sorry about that, will do next time. :smile:


TIL that this exists.


the best way would have been an initial commit and then changes, but I didn't do it this way, as I offered two solutions (which again could be managed better).

Sure I can add it.


If evict( key ) was previously called then update.getValue() will return null. It seems like that is correct, but I want to confirm.

IOW, should:
```java
if (update != null ) {
   return update.getValue();
}
```
be:
```java
if (update != null && update.getValue() != null ) {
   return update.getValue();
}
```


is there a reason not to move it now instead of having a WTF comment?


Hmm,... `fieldnames()` do not exist in Julia 0.3 ... which is still *the* default julia  on most computers, notably  for people who don't work with bleeding-edge ..

So, did they really abolish `names()` from 0.3 to 0.4 ... without any deprecation area in between ??

No wonder, nobody is starting to build serious stuff with julia ((sorry, I know this is wrong ... but it seems they really don't want regular users))


It usually goes after the ```@return```


@coreyfloyd that's fair, i'll try to find a place to "cache" these kinds of non-functional concerns, and find a better way to work them into refactoring tickets w/ a tangible expected outcome. that said, i do believe that code quality & tech debt are something you need to manage continually—to some extent. maybe we can get into that groove once the beta's out, so i'll try to keep the smaller "nits" to myself until then


saw approval from jvoegele
at https://github.com/basho/yokozuna/commit/96ca5f270d52a5d98ebd2cbffa2a75d28f1b7e2f


merging basho/yokozuna/zl/handle-and-expose-solr-request-timeout-config-and-prevent-crashes = 96ca5f27 into borshop-integration-572-zl/handle-and-expose-solr-request-timeout-config-and-prevent-crashes


basho/yokozuna/zl/handle-and-expose-solr-request-timeout-config-and-prevent-crashes = 96ca5f27 merged ok, testing candidate = 9c72938a


Yeah, you can use the `after` hooks in FactoryGirl to do a lot of stuff. I'm sure we can figure out the best way to handle this on Saturday.

I leave out the `FactoryGirl` namespace on `build` and `create` methods in my tests. I know FactoryGirl lets you include those methods so they can be used without the FactoryGirl prefix, so I would imagine it's common.


What is w?


thanks!  Good addition.


the `string` module has a couple nice strings and utils in it.


I'd rename to expectedMatchedStations.


Because it's not always a `String`. The acceptable types of objects are `String`, `Number`, and `Boolean`. I decided to use factory methods to restrict the types of the `Field.fieldValue` (even though it's an `Object`).


If you rename to expectedMatchedStations then you can leave this as matchedStations I think.


Yeah , I should allow it for all the filesystem for that filestore is going for write_ahead journal. I will remove this XFS specific check.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.671](http://teamcity.monogame.net/viewLog.html?buildId=10621&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@alfredoUcar estaría bien que comitearas más poco a poco. Aquí hay mucho más que añadido de sombras :+1:


I originally was going to use spaces for the new lines but found that there appeared to be tabs on the other lines.  I then entered tab 4 times, which in the text editor seemed to show up as one tab.  After that point the diff came out weird.


looks great mate. thanks.


Ah, I get what you mean now. Just make the `Field.fieldValue` a string and convert whatever is passed to the factory method in the factory method? I think at some point, I was doing that, but it seemed like a good idea to have the actual, correctly typed value in the object instead.


I'd prefer to do it in a separate PR.  I wanted to try to leave the higher level shit as-is as much as possible, while just replacing the guts.


Was this just wrong before?


Since this function does not only check for equality but also runs the test, I'd rename it to runAndCheckResult.


Yay


Dr. Fix it


done


My rationale for fopen was purely for the convenience of the "fgets" function to read the file one line at a time. If you prefer using native descriptors, I could do something like reading the file into memory, find an EOL, temporary replace with '\0', treat buffer like a line, advance my pointers, repeat everything.

Let me know what you prefer (or suggest another option) and I'm more than happy to make a change.


Hey Toto! I see Rebecca is helping you with something right now, so I will just add my code review comments here. I will be around all day. If you have any questions let me know.


the cosmetic issues being:

* if ( not if(
* if (foo) not if ((foo))
* if (a && b) not if (( a )&&( b ))
* // foo not //foo
* if (a < b && c < d) not if ((a < b) && (c < d))
* if (a &&
      b)  not if (a
    && b)
* dout(10) << a << b not dout(10)<< a ...


Yes, I kind of did that ..In _write below I am not putting anything in the WBThrottle queue if fast sync is enabled.
But, if you want me to disable the WbThrottle thread all together , I can do that..Let me know.


good call


I'm not sure why it would need those methods, can you expand?


@claudioandre oops, thanks for noticing this, it should be gone now.


nit: redundant new line (here and in the other functions).


Added new Project AmarEnterprises.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 866](https://teamcity.mesosphere.io/viewLog.html?buildId=58696&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:08:29


I'm just going to use a plain old `java.util.List` and call it a day.


Oh wow, good catch! That's a bit embarassing, thanks for reviewing the code!


Actually it's not a `foreach` (`map`), instead it's `intersperse`/`intercalate`. So you can't (reasonably) invoke `g_list_foreach()` for the complete list. And `g_list_foreach(self->recovery_cache->next, ...)` sounds too hacky to me. Ádám agreed in this aspect. However, I did extract and refactor that part of the code. I hope you like this alternative.


To be continued and rebased..


Creo que he visto esto antes. ¿Al hacer esta `or` qué está pasando? ¿Si viene por parámetro `x` entonces seleccionará este y si no seleccionará la variable estática `X`? ¿Por qué?


please use the already-localized `main-menu-nearby` key