Hi Zacharias,

Nice implementation of a CSVWeatherDataProvider, I have had the question before and I was reluctant to include because CSV is not really a format (actually there are many versions of CSV, often locale specific.). However, I can see the advantage as well. Some remarks on your implementation
1. you should add an example of the file structure preferable in the docstring so it can be parsed by sphinx and included in the documentation. An example file helps as well.
2. in line 204, do not use exec() that can be tricky, use eval(). I propose the following:
```python
header = {}
for line in csv_file:
    if line.startswith('## Weather data'):
        break
    eval(line, {}, header)
```
use header in stead of locs[] in the remainder of the section.
3. In the _read_observations() method, you should be able to use csv.DictReader instead of parsing the header yourself that would shorten the code. Please have look.
4. The translator seems to be specific for the CSV files that come from MACSUR, shouldn't we define our own CSV format and remove the translator?


Note: defer attribute causes error in IE < 9. We need to check the browser before setting this attribute.


Why to not have a single buildModel function ?


Changed == to ===. Please review again.


what do you mean?


That's also good by me. But as it is it will probably cause duplicates.


Yes that is right, We should switch to the new settings. Should I create a PR with the new settings?
Also yes I think there was some issue reaching it via the public endpoint but don't see it now so not sure.


The signature of parseTree is not convenient. The idea is: if we provide a placementOffset or a JointModelBase, then we need to add a joint at the root of the tree. Else, we just naturally parse the file. I think this part of the code needs a revision.


at running time, error information below, please help me, thanks!

java.lang.IllegalArgumentException: Invalid [map type; class java.util.Map, [simple type, class java.lang.String] -> [collection type; class java.util.List, contains [simple type, class com.facebook.presto.elasticsearch.ElasticsearchTable]]] json string
	at io.airlift.json.JsonCodec.fromJson(JsonCodec.java:138)
	at com.facebook.presto.elasticsearch.ElasticsearchClient.lookupSchemas(ElasticsearchClient.java:301)
	at com.facebook.presto.elasticsearch.ElasticsearchClient.lambda$schemasSupplier$0(ElasticsearchClient.java:281)
	at com.google.common.base.Suppliers$MemoizingSupplier.get(Suppliers.java:125)
	at com.facebook.presto.elasticsearch.ElasticsearchClient.getTableNames(ElasticsearchClient.java:251)
	at com.facebook.presto.elasticsearch.ElasticsearchMetadata.listTables(ElasticsearchMetadata.java:102)
	at com.facebook.presto.metadata.MetadataManager.listTables(MetadataManager.java:324)
	at com.facebook.presto.connector.informationSchema.InformationSchemaPageSourceProvider.getTablesList(InformationSchemaPageSourceProvider.java:194)
	at com.facebook.presto.connector.informationSchema.InformationSchemaPageSourceProvider.buildTables(InformationSchemaPageSourceProvider.java:176)
	at com.facebook.presto.connector.informationSchema.InformationSchemaPageSourceProvider.getInformationSchemaTable(InformationSchemaPageSourceProvider.java:124)
	at com.facebook.presto.connector.informationSchema.InformationSchemaPageSourceProvider.getInternalTable(InformationSchemaPageSourceProvider.java:115)
	at com.facebook.presto.connector.informationSchema.InformationSchemaPageSourceProvider.createPageSource(InformationSchemaPageSourceProvider.java:86)
	at com.facebook.presto.split.PageSourceManager.createPageSource(PageSourceManager.java:44)
	at com.facebook.presto.operator.ScanFilterAndProjectOperator.createSourceIfNecessary(ScanFilterAndProjectOperator.java:254)
	at com.facebook.presto.operator.ScanFilterAndProjectOperator.isFinished(ScanFilterAndProjectOperator.java:169)
	at com.facebook.presto.operator.Driver.processInternal(Driver.java:377)
	at com.facebook.presto.operator.Driver.processFor(Driver.java:303)
	at com.facebook.presto.execution.SqlTaskExecution$DriverSplitRunner.processFor(SqlTaskExecution.java:586)
	at com.facebook.presto.execution.TaskExecutor$PrioritizedSplitRunner.process(TaskExecutor.java:505)
	at com.facebook.presto.execution.TaskExecutor$Runner.run(TaskExecutor.java:639)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 958](https://teamcity.mesosphere.io/viewLog.html?buildId=58896&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:03:48


Nit: Add the comment for CLCC as well, like [line#2977](https://github.com/driftersprt/platform_external_qemu/commit/d417db5d97df4bf35610836ec76695cc6a591297#diff-58bd35ac9e1da86dffbc1dd35cd1ccc0R2977).


Do you know why no question page test artefacts seem to be included in this commit? Does it matter that they don't?


Please use the convention root_joint instead of rootJoint for better clarity.


oh my...


If the string substitution can be implemented in a portable way, we should change it to consider the env var.


Ik lol.


J'ai mis à jour la version de jQuery à la 2.x. Elle supporte les version 8> de IE
C'est standard.


done


なんかたたき台に使えそうな物があればぜひお願いしますー


This particular class seems a bit convoluted to me, so I have been re-thinking about this one. There are a few options like the one you suggested. But that would introduce an extra loop, once to get all the fetchTasks and then go over those all over again to run the checks & validations. In smaller configs it doesn't matter at all, but I have been running performance test with much larger configs for create & update scenarios after making any significant change to the code. Introducing any extra loop tends to increase the time it takes per save. Anyways, there are a few ideas to solve that, so I will get back to this.


@herrwiese sorry for that. And I am with you. Next time will be saner.


I think that we are trying to use convention of joining those parts without any separators, e.g. "apiutil" or "podetcd":
https://github.com/kubernetes/kubernetes/blob/master/pkg/master/master.go

So how about Joining with "" instead?


remove this


Regarding `Also there are other references of task instanceof FetchTask all over the codebase.` - Hadn't seem the other usages. There are two other usages that I see, let me see if I can do something about them too.


Can you explain why do you replace anything here? Can those be in package names?


Контейнерная виртуализация в целом (lxc, docker, vz)


to var 'self.collection'


Thanks @iMHLv2. Yeah, absolutely correct: the _EPROCESS.search_process_memory API is much more appropriate and removes the need for the base scanner class all together. Have made that change (and some other minor improvements to the method) in the latest commit.


If I do that, it looks like this - the %-sign is top aligned and not center aligned:
![percent](https://cloud.githubusercontent.com/assets/10582167/10510034/c1f7afb6-7330-11e5-8554-85fb0ac87407.png)


check for undefined and null explicitly


Up to you, I thought your GIST was a more complete and interesting writeup.


Vale pero `X` siempre está seteado, ¿Qué hace que al hacer `x or X` tenga preferencia la `x`?

Por ejemplo: Si no tenemos `x` entonces es `X`, pero si tenemos `x`, entonces ¿`x or X` qué resultado da?


@stevenbird Sorry I was fixing the code and accidentally pressed tab+enter. But the commit should fix #1030 , I will revert and send in a proper PR.


Python magic....  neat.


Let us not do this, we can simply check for these three values. Should we check if body, query and params are neither null nor undefined.


what is left and right?


vhalla


Thanks @evil-at-wow I always enjoy reading your stuff


sure


Ευχαριστώ ευχαριστώ :smiley:


I suggest you to test this widely (anyhow -O2 always make ast crash on my computer)


.... *walks away*


Should be tested on windows, just to be sure it works


Assert the whole object rather than individual properties


@Mitsakit Γεια σου Μαρία!
:smile:


I don't care. 2010 is my current build, so I fixed the few problems that occured.


need combine with ip range on the provision page


> You must make sure that ICU is built against exactly the same version of gcc/libstdc++ (or at least abi compatible one)Show what ldd test_boundary shows. It may be the case when ICU is built against clang/libstdc++ and boost against libstdc++ of different version Note that on same tester Boost.Regex icu_example fails with 139...I strongly suspect some ABI mixed libraries related issues

Ah, it make sense. ldd shows that ICU is linked to libc++/libcxxrt and the executable is linked to libstdc++(i.e. libsupc++). I installed the ICU via pkgng, thus I should build ICU by hand using libstdc++.


Here you have `if roiCount > 0` while...


...here you have `roiCount < roiLimit` so the tootip doesn't match the usage.


<!-- PMABOT:TAB -->
This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our [Developer guidelines](http://wiki.phpmyadmin.net/pma/Developer_guidelines#Indentation) for more information.

Offending files: libraries/advisory_rules.txt


I think this would not work. The trigger is called by the function cloture so if we call again the function on trigger we will enter on an infinite loop.

The trigger is called when the user close the proposal as signed. The proposal is set to signed by the user and the order must be created automatically by workflow module.


ok


this seems to be fixed differently within the community, see:
https://github.com/chef-cookbooks/windows/blob/master/providers/task.rb#L46
https://github.com/chef-cookbooks/windows/blob/master/resources/task.rb#L32


Maybe worth adding: I used memwatch-next in the framework: https://github.com/upfrontIO/livingdocs-framework/commit/44d4a3727d2a8b73611c0bcc07a8d2242e0fae26

This could be useful for automated testing concerning memory.


link fixed in 831c77b, thanks!


Thank you very much for your feedback :)
This fix will be available in 1.6.1.2


add some words


public class wrapper{

     public string selectedSobject{get;set;}
    public List<Sobject> lstQuery{get;set;}
    public integer i=10;
    public string values{get;set;}

    public wrapper(){
        lstQuery=new List<Sobject>();
    }

    public Void doSearch(){
system.debug('@@values'+values);

        string Query='';
        Query='select name,id,Phone from account where name like \'%'+values+'%\' or Phone like \'%'+values+'%\'';

       // where name like \'%'+searchstring+'%\' Limit 20';
        system.debug('==Query=='+Query);

        lstQuery=Database.query(Query);
        system.debug('==lstQuery=='+lstQuery);

    }
}


Wrapper Class


Bug in bot, fixed in afd0cede7bb3cec5e9a5751376dfbbceb593003f


GGWEPAK


Ok, makes sense.


Ok, thanks!


assfsd


LGTM


Allocations the same, byte increase fluctuates between 0 and 8 bytes on x64 and is 4 bytes on x86. Effects on string lengths from 0 to 100 shown below.

Length	|Pre Bytes x64	|Post Bytes x64|Inc Bytes | Inc % |Pre Bytes x86 | Post Bytes x86|Inc Bytes | Inc %
------------ | -------------|------------ | -------------|------------ | -------------|------------ | -------------|------------ |
0	|	32	|	40	|	8	|	25%	|	20	|	24	|	4	|	20%
1	|	32	|	40	|	8	|	25%	|	20	|	24	|	4	|	20%
2	|	40	|	40	|	0	|	0%	|	24	|	28	|	4	|	17%
3	|	40	|	40	|	0	|	0%	|	24	|	28	|	4	|	17%
4	|	40	|	48	|	8	|	20%	|	28	|	32	|	4	|	14%
5	|	40	|	48	|	8	|	20%	|	28	|	32	|	4	|	14%
6	|	48	|	48	|	0	|	0%	|	32	|	36	|	4	|	13%
7	|	48	|	48	|	0	|	0%	|	32	|	36	|	4	|	13%
8	|	48	|	56	|	8	|	17%	|	36	|	40	|	4	|	11%
9	|	48	|	56	|	8	|	17%	|	36	|	40	|	4	|	11%
10	|	56	|	56	|	0	|	0%	|	40	|	44	|	4	|	10%
11	|	56	|	56	|	0	|	0%	|	40	|	44	|	4	|	10%
12	|	56	|	64	|	8	|	14%	|	44	|	48	|	4	|	9%
13	|	56	|	64	|	8	|	14%	|	44	|	48	|	4	|	9%
14	|	64	|	64	|	0	|	0%	|	48	|	52	|	4	|	8%
15	|	64	|	64	|	0	|	0%	|	48	|	52	|	4	|	8%
16	|	64	|	72	|	8	|	13%	|	52	|	56	|	4	|	8%
17	|	64	|	72	|	8	|	13%	|	52	|	56	|	4	|	8%
18	|	72	|	72	|	0	|	0%	|	56	|	60	|	4	|	7%
19	|	72	|	72	|	0	|	0%	|	56	|	60	|	4	|	7%
20	|	72	|	80	|	8	|	11%	|	60	|	64	|	4	|	7%
21	|	72	|	80	|	8	|	11%	|	60	|	64	|	4	|	7%
22	|	80	|	80	|	0	|	0%	|	64	|	68	|	4	|	6%
23	|	80	|	80	|	0	|	0%	|	64	|	68	|	4	|	6%
24	|	80	|	88	|	8	|	10%	|	68	|	72	|	4	|	6%
25	|	80	|	88	|	8	|	10%	|	68	|	72	|	4	|	6%
26	|	88	|	88	|	0	|	0%	|	72	|	76	|	4	|	6%
27	|	88	|	88	|	0	|	0%	|	72	|	76	|	4	|	6%
28	|	88	|	96	|	8	|	9%	|	76	|	80	|	4	|	5%
29	|	88	|	96	|	8	|	9%	|	76	|	80	|	4	|	5%
30	|	96	|	96	|	0	|	0%	|	80	|	84	|	4	|	5%
31	|	96	|	96	|	0	|	0%	|	80	|	84	|	4	|	5%
32	|	96	|	104	|	8	|	8%	|	84	|	88	|	4	|	5%
33	|	96	|	104	|	8	|	8%	|	84	|	88	|	4	|	5%
34	|	104	|	104	|	0	|	0%	|	88	|	92	|	4	|	5%
35	|	104	|	104	|	0	|	0%	|	88	|	92	|	4	|	5%
36	|	104	|	112	|	8	|	8%	|	92	|	96	|	4	|	4%
37	|	104	|	112	|	8	|	8%	|	92	|	96	|	4	|	4%
38	|	112	|	112	|	0	|	0%	|	96	|	100	|	4	|	4%
39	|	112	|	112	|	0	|	0%	|	96	|	100	|	4	|	4%
40	|	112	|	120	|	8	|	7%	|	100	|	104	|	4	|	4%
41	|	112	|	120	|	8	|	7%	|	100	|	104	|	4	|	4%
42	|	120	|	120	|	0	|	0%	|	104	|	108	|	4	|	4%
43	|	120	|	120	|	0	|	0%	|	104	|	108	|	4	|	4%
44	|	120	|	128	|	8	|	7%	|	108	|	112	|	4	|	4%
45	|	120	|	128	|	8	|	7%	|	108	|	112	|	4	|	4%
46	|	128	|	128	|	0	|	0%	|	112	|	116	|	4	|	4%
47	|	128	|	128	|	0	|	0%	|	112	|	116	|	4	|	4%
48	|	128	|	136	|	8	|	6%	|	116	|	120	|	4	|	3%
49	|	128	|	136	|	8	|	6%	|	116	|	120	|	4	|	3%
50	|	136	|	136	|	0	|	0%	|	120	|	124	|	4	|	3%
51	|	136	|	136	|	0	|	0%	|	120	|	124	|	4	|	3%
52	|	136	|	144	|	8	|	6%	|	124	|	128	|	4	|	3%
53	|	136	|	144	|	8	|	6%	|	124	|	128	|	4	|	3%
54	|	144	|	144	|	0	|	0%	|	128	|	132	|	4	|	3%
55	|	144	|	144	|	0	|	0%	|	128	|	132	|	4	|	3%
56	|	144	|	152	|	8	|	6%	|	132	|	136	|	4	|	3%
57	|	144	|	152	|	8	|	6%	|	132	|	136	|	4	|	3%
58	|	152	|	152	|	0	|	0%	|	136	|	140	|	4	|	3%
59	|	152	|	152	|	0	|	0%	|	136	|	140	|	4	|	3%
60	|	152	|	160	|	8	|	5%	|	140	|	144	|	4	|	3%
61	|	152	|	160	|	8	|	5%	|	140	|	144	|	4	|	3%
62	|	160	|	160	|	0	|	0%	|	144	|	148	|	4	|	3%
63	|	160	|	160	|	0	|	0%	|	144	|	148	|	4	|	3%
64	|	160	|	168	|	8	|	5%	|	148	|	152	|	4	|	3%
65	|	160	|	168	|	8	|	5%	|	148	|	152	|	4	|	3%
66	|	168	|	168	|	0	|	0%	|	152	|	156	|	4	|	3%
67	|	168	|	168	|	0	|	0%	|	152	|	156	|	4	|	3%
68	|	168	|	176	|	8	|	5%	|	156	|	160	|	4	|	3%
69	|	168	|	176	|	8	|	5%	|	156	|	160	|	4	|	3%
70	|	176	|	176	|	0	|	0%	|	160	|	164	|	4	|	3%
71	|	176	|	176	|	0	|	0%	|	160	|	164	|	4	|	3%
72	|	176	|	184	|	8	|	5%	|	164	|	168	|	4	|	2%
73	|	176	|	184	|	8	|	5%	|	164	|	168	|	4	|	2%
74	|	184	|	184	|	0	|	0%	|	168	|	172	|	4	|	2%
75	|	184	|	184	|	0	|	0%	|	168	|	172	|	4	|	2%
76	|	184	|	192	|	8	|	4%	|	172	|	176	|	4	|	2%
77	|	184	|	192	|	8	|	4%	|	172	|	176	|	4	|	2%
78	|	192	|	192	|	0	|	0%	|	176	|	180	|	4	|	2%
79	|	192	|	192	|	0	|	0%	|	176	|	180	|	4	|	2%
80	|	192	|	200	|	8	|	4%	|	180	|	184	|	4	|	2%
81	|	192	|	200	|	8	|	4%	|	180	|	184	|	4	|	2%
82	|	200	|	200	|	0	|	0%	|	184	|	188	|	4	|	2%
83	|	200	|	200	|	0	|	0%	|	184	|	188	|	4	|	2%
84	|	200	|	208	|	8	|	4%	|	188	|	192	|	4	|	2%
85	|	200	|	208	|	8	|	4%	|	188	|	192	|	4	|	2%
86	|	208	|	208	|	0	|	0%	|	192	|	196	|	4	|	2%
87	|	208	|	208	|	0	|	0%	|	192	|	196	|	4	|	2%
88	|	208	|	216	|	8	|	4%	|	196	|	200	|	4	|	2%
89	|	208	|	216	|	8	|	4%	|	196	|	200	|	4	|	2%
90	|	216	|	216	|	0	|	0%	|	200	|	204	|	4	|	2%
91	|	216	|	216	|	0	|	0%	|	200	|	204	|	4	|	2%
92	|	216	|	224	|	8	|	4%	|	204	|	208	|	4	|	2%
93	|	216	|	224	|	8	|	4%	|	204	|	208	|	4	|	2%
94	|	224	|	224	|	0	|	0%	|	208	|	212	|	4	|	2%
95	|	224	|	224	|	0	|	0%	|	208	|	212	|	4	|	2%
96	|	224	|	232	|	8	|	4%	|	212	|	216	|	4	|	2%
97	|	224	|	232	|	8	|	4%	|	212	|	216	|	4	|	2%
98	|	232	|	232	|	0	|	0%	|	216	|	220	|	4	|	2%
99	|	232	|	232	|	0	|	0%	|	216	|	220	|	4	|	2%
100	|	232	|	240	|	8	|	3%	|	220	|	224	|	4	|	2%


can use NULL_ARRAY here instead of -1


hmm, nie jestem do końca przekonany co do 'skórki'...
generalnie, nazwa 'skin' się już od dawna przyjęła w dialekcie e2, myślę, że jest bardziej zrozumiała i jednoznaczna niż 'skórka' ;)
(btw. podobnie mam z terminem 'timer' - każdy wie co to jest 'tajmer', słowo krótkie wszędzie się zmieści, i nagle w openwebif pojawia się 'zadanie czasowe'...)


Validated


Using `Sys.set_signal` means you don't need the `ignore`.


notFound?


unauthorized?


TeamCity pull requests :: netty [Build 416](https://garage.netty.io/teamcity/viewLog.html?buildId=2322&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4782, ignored: 21 Build time: 00:31:24


isn't it a bit too long ?
also, the second parameter is the interval between the checks of the cache. so here it could be cached for 16 hours...


This will raise a KeyError exception for new style reference fields


Very good!


> Rebase it, shall we?

No @MingcongBai

> (And by the way re-organize those update <date> stuffs)

You love neat repos?


validated


And provide a separate path to it in b2 configuration options so it would find the correct one.Alternatively you can set boost.locale.icu=off for gcc testing.

Thank you very much.
I'm going to merge the changes to master for the next release Artyom Beilis

      From: Kohei Takahashi <notifications@github.com>
 To: boostorg/locale <locale@noreply.github.com>
Cc: Artyom Beilis <artyomtnk@yahoo.com>
 Sent: Thursday, October 15, 2015 12:46 PM
 Subject: Re: [locale] POSIX backed support on FreeBSD (b7fcbdc)

You must make sure that ICU is built against exactly the same version of gcc/libstdc++ (or at least abi compatible one)Show what ldd test_boundary shows. It may be the case when ICU is built against clang/libstdc++ and boost against libstdc++ of different version Note that on same tester Boost.Regex icu_example fails with 139...I strongly suspect some ABI mixed libraries related issues
Ah, it make sense. ldd shows that ICU is linked to libc++/libcxxrt and the executable is linked to libstdc++(i.e. libsupc++). I installed the ICU via pkgng, thus I should build ICU by hand using libstdc++.—
Reply to this email directly or view it on GitHub.


ok


Puedes comitear archivos uno por uno del staging area de la siguiente forma:

    git commit -m "comentario" path/del/archivo
    git commit -m "comentario 2" path/de/otro/archivo

Y recuerda que añadir al staging area es `git add path/del/archivo` o `git add --all`

Al hacer `git commit -am` lo que le estás diciendo es que todos los archivos que vas a comitear se añadan al staging area y que todos los cambios pertenezcan al mismo commit.


Can you please merge addFile and AddFile methods?


PEP8 does not allow this.
It should be separately imported and alphabetical order should be followed..


@palinek just cherry picked this to https://github.com/lxde/liblxqt/tree/plugin-translations-loader


should be "userRequested" instead


So if method cloture() was already called, wa can just remove the test
if ($object->statut == 2)
as suggested by @rdoursenaud

Setting a status on final object before knowing if transaction will be ok or not hurt me. So i would prefer you remove the protection into createFromProposal...


**Stop working on branch `0.2.5-devel`.** `0.2.5` has been deprecated.

(But if you are still interested in it, ...)


Was that on purpose?


'''objective-c
PNChannelGroupChange *changeToSend = nil;
                    if ([change isKindOfClass:[PNChannelGroupChange class]]) {
                        changeToSend = change;
                    }
'''


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1081](https://teamcity.mesosphere.io/viewLog.html?buildId=59345&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:00


@mafintosh can't use irc (netsplit), using gitter


This semicolon does not seem necessary :wink:


No space after the `if` keyword?


@grischa thanks! Yes I'm [able to talk in the channel now](https://gitter.im/mytardis/mytardis/archives/2015/10/15). If I have any questions, I'll ask there.


Hi! I'm testing with RP2 but and a (neopixel ring) but I just can turn on the first led... did you have some recomendation? thanks in advance.
I wired the circuit following https://www.youtube.com/watch?v=0uXjyvZ9JGM
And in this link the author says that you library works perfect with RP2 https://github.com/626Pilot/RaspberryPi-NeoPixel-WS2812/issues/4


or alternatively, why do you even need changeToSend, just nil out change?


Ah I squashed 3 one-line commits together. This line is a UT fix for that assertion.


For totalDownloads, I don't think "searcher.Versions[scoreDoc.Doc].VersionDetails.Select(item => item.Downloads).Sum()." is correct implementation. If user search result only return parts of the versions, this totalDownloads should include all versions, not only the versions in search result.

Any test modified or added for this two new values?


# The following statement loads in the research data cleared of missing values on all scales
# And the 'merged' data structures (i.e. the research scales with the PDHRA variables)
#   cleanArmyData - 917 observations plus a 'site' flag from the original 1040 respondents, it's 917 because there are no missing values
# These are the 'full' data sets merged with the PDHRA (i.e. they come from the 1040, but do not contain item level variables except for the INQ/ACS/SBQ
#   merged_LastFtHood_2012_PDHRA = the final 275 FtHood participant data, which had the 2012 version of the PDHRA, plus research scales along with INQ/ACS items
#   mergedData_2012_PDHRA = combination of both FtHood and JBLM (from the original 1040) that used the 2012 version of the PDHRA, plus research scales along with INQ/ACS items
#   mergedData_2008_PDHRA = first 216 participants from JBLM who were using the 2008 version of the PDHRA, plus research scales along with INQ/ACS items
#
load(file="cleanArmyData.RData")


`watch.c` is just a test!


So the problem there is YaxLib only assigns a value to `Options` after the constructor's been called. Let me see if there's a better way to call `Chain.Initialize()` then.


I don't think this particular path has been used in a while since GCC on Android has been greater than 4.3 for a while. And I suspect the only reason we have a special case for Apple is because this has only been implemented Clang/LLVM as of 2014 so we need to support older versions of the compilers.

In the future we should be also be able to get rid of it and use the GCC builtin everywhere.


I didn't prefix any other components with "Panorama". Since the components will be namespaced within the `@panorama/toolkit` module, I don't think it's necessary, do you @sconnelley?


This pluralization logic is merely a mirror of [Symfony's implementation](https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Translation/PluralizationRules.php) for our front-end. So in order for us to change it here, it should really first be fixed in Symfony, for consistency. Can you report over at symfony/symfony?


Wut... Mixing tabs + space makes code ugly... :(


Maybe just call this `values`?


@callumlocke: one of the dependencies must be breaking node.js 0.10. I'm not using such an old version myself so I can't fix it. We can remove 0.10 and require 0.12.


@RandomAltThingy the method used here is just like old PocketMine where a switch block is used to handle packets. PocketMine also uses switch blocks but it preprocesses packets first. RedstoneLamp creates a class per packet type (request) and handle them per class.

Now, please try to read code and understand them line by line. And stop mentioning me everywhere, please.


Fixed it. Disabled it locally to speed up tests.


えと、質問の意図が良く分かりませんが、それは出力ではないです。
`/dev/tty` は現在のプロセス(shell)に割り当てられる仮想端末で、readが画面入力とwriteが画面出力となります。
`/dev/stdin` と `/dev/stdout` とは別に端末の画面を制御する必要があります。`/dev/tty` にデータを出力しているのではなく、画面の表示に使っていますね。
試して貰うと分かるかと思いますが、これを `/dev/stdout` にしてしまうと `ls | tovim > foo` とした場合に、vimが画面出力するはずだったエスケープシーケンスが foo のディスクリプタに出力される事になります。


where's the part where it filters the provinces?


The `assert` and `LogicError` are good, but I don't think the comment is quite right.  It looks to me like the LogicError will fire if someone calls `getTransactionID()` on an `STTx` that was constructed from a `TxType` and never `sign()`ed.  That's still a good thing to detect, but not as powerful as knowing whether the `STTx` was modified after its digest was calculated.

Since an `STTx` is an `STObject`, I don't see an obvious way to detect when an `STTx` is modified after its digest is calculated.  But I may not be thinking creatively enough.  It may also be an error case that we're not worried about.

If it is an important error case, one way to prevent that kind of error would be by having an `STTx` contain an `STObject`, rather than be an `STObject`.  That would allow the STTx interface to be dramatically narrowed.  But it would be a pretty big change.


oh wow - please assign the task of re-adding the model to me - I need it for my patches.


Why do we need `SortedRangeSet.none()`, `EqualableValueSet.none()`, etc? Isn't `none` the same thing regardless of whether a type is comparable, equatable, etc?


I'd really *really* recommend to just remove "Intialize()" as far as I can tell you'll lose absolutely no functionality.

The worrying part is "Reset()", which also doesn't really work at the moment. Worse it's almost impossible to detect when it's not working properly. I've been thinking of a way to solve it, the best I could come up with was somehow registering all Chains with the Script using it, but it's hard to do so in a transparent way.

Anyway I need to call it a night, see you tomorrow!


Good night!


haven't added it yet.  you were way ahead of me.  the `prov_map` is used in such a way that I'll just be able to take your filter list, mark those to be included, and null the rest.


Also redirects user to the home page with the root_path.


It wouldn't let me change the value of `change`, it complained about it not being a block variable. I could have done the thing in your first comment, but I felt this way is more clear.


what isn't a valid value?


I had some trouble installing this, and I think it has to do with the fact that MySQL-python isn't Python 3 compatible. Does this sound right? Is there an alternative we could use? We want to write the site in Python 3


hey, that was quick :) I was just about to push some stuff... I don't think this change will work below Node 0.12, because it didn't have `path.posix`

so I'm using this: https://github.com/jden/node-path-posix


ah, i remember when i had to do all this formatting inline :)


Military installation? We really need that to prevent accidental 2nd base creations.


finishing the last issue #5


Also added OverlapPlot, which only plots the real part of the waveform at this point


That is a great idea


AddAllTransitionBinaries (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1914 of 1914 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ah, sorry, I have switched to 0.12 and now 4.2.1 so I missed that. It's your call if you want to support 0.10 go with your solution.


We use `4` for the contrib pluigins but that's your call.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1082](https://teamcity.mesosphere.io/viewLog.html?buildId=59348&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:03:53


If you changed the function to pattern match for a `facet_limit` and added that new field to the `defstruct ...` on line 6 then you could just change the `facet_limit` in one place along with all the other options.
```
def facets(%{Esolr{facets: fields, facet_limit: facet_limit}) do
  "&facet=true&facet.limit=#{facet_limit}&facet.field=" <> Enum.join(fields,"&facet.field=")
end
```


@cas27 I fixed it on master and v1.0 branch? Can you please give it a try? If it works, I will publish 1.0.5.


Bummer. Catalog.m was the new Catalog class. catalog.m was a skin to provide a bridge between old catalog class and new one. Need to rollback this change. Happy to delete the skin. Need Catalog back.


#5252_TinDiscrepancyNewVRFModel (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1370 of 1370 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


AddAllTransitionBinaries (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I assumed most people would have 2.7. It's a bit annoying how there is still a division.


@lucian303 - could you provide a quick fix for it please?


@bajtos A host list *might* be useful to somebody?  It doesn't really help in my case because internal URLs don't have a hostname...`urlBase` is just a path... and I don't think I should have to list every path in my app that I want credentials sent to.  It should be the default, rather than an exceptional case...

I think a simpler fix would be to just prevent the access token from going to third-party servers...
External URLs will start with `http` or `//`...anything else is going to my server, whether it begins with `urlBase` or not.

If anybody has a use for sending the auth token to a 3rd party server, maybe it would make sense to add a host whitelist (after testing if it's an external URL).  Since the token in only valid on my server, I can't see this coming up often...and for those cases it might just be easier to add the `Authentication` header manually.


We can't actually change that one. He's special. Ask Kj bout it.


i'm brad stronger and i approve this message


Ok I'll change it back


地对地导弹


顶顶顶顶


@FokkeZB, one of the test cases failed, testing/ALOY-846.
I think there are a few places you need to modify to make this work.
1. commands/compile/index.js
2. commands/compile/parsers/Ti.UI.Tab.js
3. rename ``parsers/Ti.UI.iPad.SplitWindow.js`` to ``parsers/Ti.UI.iOS.SplitWindow.js``


TODO: split the display name with the script name

(yes, for that mob, the name in the database is the actual name that shows up in game)


The reason to keep it in DOM is maybe we shall use some of these criteria to facilitate some requirements. but if it is fixed in rails code, it is not possible to manipulate via js anymore.


Wow sometimes I'm a really poor coder :scream:


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1083](https://teamcity.mesosphere.io/viewLog.html?buildId=59349&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:08


the same reason as before... what if the requirement change to search base on time? when added to NON_RANSACKABLE_ATTRIBUTES, it become non-searchable in every fields.


The decision to turn off caches (the `false`) is what's causing the open/read/close behavior in Jetty 9.3.5.

If I remove that parameter (or set it to true) then the annotation scanning is back to 9.3.3 speeds


I like having a `sterilize(STTx const&)` function.  Good idea.  I know of one other place that sterilizes transactions: https://github.com/ripple/rippled/blob/develop/src/ripple/app/tx/impl/Transaction.cpp#L65.  I'm moving that code into TransactionSign.cpp in one of my pull requests.  I'll make a note to fix up TransactionSign.cpp after this pull request gets into develop.


Yeah, you are right, will send a new pull request.

I did the same thing to fix cache classloading before, will fix that too.

I did not remember the reason clearly, probably is I found when do serializing and deserializing they are using same context classloader as initializing, then made a quick decision.


@RandomAltThingy According to what you say, just remove the Vector2/Vector3/Permission part/Metadata Part and any other codes in PocketMine that translated from bukkit's codes and write your own code :)


Can someone with polymer experience tell me if the detail argument needs to be specified here?


This broke Android:

```
[8:04:03] System.Diagnostics/Process.cs(1103,75): error CS0117: `System.Console' does not contain a definition for `OutputEncoding'
```

Also there's no explanation in the commit message why we're changing this. Does it fix any known bug, workaround some issue?


Be careful because if it eventually calls `NetworkOPs::submitTransaction` you can end up sterilizing twice. Which means paying for an extra, needless SHA512-Half computation (and serialization/deserialization trip).


@josevalim

`iex(2)> Ecto.Changeset.cast %HasOne.Parent{id: 1, name: "Bob", child: %HasOne.Child{name: "Larry", id: 1}}, %{"name" => "Bob", "child" => %{"name" => "Mark", "id" => 1, "parent_id" => 1}}, ~w(name child)a

** (UndefinedFunctionError) undefined function: HasOne.Child.changeset/2
    (has_one) HasOne.Child.changeset(%HasOne.Child{__meta__: #Ecto.Schema.Metadata<:built>, id: 1, name: "Larry", parent: #Ecto.Association.NotLoaded<association :parent is not loaded>, parent_id: nil}, %{"id" => 1, "name" => "Mark", "parent_id" => 1})
              lib/ecto/changeset/relation.ex:192: Ecto.Changeset.Relation.do_cast/3
              lib/ecto/changeset/relation.ex:385: Ecto.Changeset.Relation.build_changeset!/4
              lib/ecto/changeset/relation.ex:376: Ecto.Changeset.Relation.single_changeset!/4
              lib/ecto/changeset.ex:462: Ecto.Changeset.cast_field/6
              lib/ecto/changeset.ex:408: Ecto.Changeset.do_process_param/8
     (elixir) lib/enum.ex:1102: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3
     (elixir) lib/enum.ex:1102: Enum."-map_reduce/3-lists^mapfoldl/2-0-"/3
`


``` sh-session
/libs/modelParser.js:68
    aObj[aKey + 'ISOFormat'] = date.toISOString();
                                    ^

TypeError: date.toISOString is not a function
    at parseDateProperty (/home/user/repo/git/OpenUserJS.org/martii/OpenUserJS.org/libs/modelParser.js:68:37)
    at Object.parseUser (/home/user/repo/git/OpenUserJS.org/martii/OpenUserJS.org/libs/modelParser.js:283:3)
    at Query.<anonymous> (/home/user/repo/git/OpenUserJS.org/martii/OpenUserJS.org/controllers/user.js:330:51)
    at /home/user/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/kareem/index.js:177:19
    at /home/user/repo/git/OpenUserJS.org/martii/OpenUserJS.org/node_modules/kareem/index.js:109:16
    at doNTCallback0 (node.js:408:9)
    at process._tickDomainCallback (node.js:378:13)
```

... during Auth As.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1084](https://teamcity.mesosphere.io/viewLog.html?buildId=59355&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 180 Build time: 00:04:17


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1085](https://teamcity.mesosphere.io/viewLog.html?buildId=59356&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 180 Build time: 00:04:25


Hi Matt,

> How can one easily see your changes from the original?

I've added comments to where I've made updates:

Lines number 1, 3, 13 and 80

> Does it work? How can one tell?

I wrote a javascript test, it's in test/id_test.js

When I first ran the test the code error'd on line 13 - the null check before undefined check.

Fixing that and the test passes.

Now we'll get into the technical weeds here a bit ... the test is simple it just runs the code.

Does the code work? That's harder to tell as this code does not export anything.

I can tell you it does not error out now, and if you console.log the NAMESSPACE variable it's a object with methods on it.

The NAMESPACE variable is in the global space., this makes it hard to run test assertions.

The code looks like it's part of a larger codebase and it needs to run in that context to see if it's working as desired.

The code, as it is, is plain Ecmascript 5 not part of any framework.

As I've suggested in the README.md file, a quick improvement would be to use the Revealing Module Pattern which will separate the Public and Private functions.

Revealing Module Pattern would be testable code as methods would be exported.


Correct, the filehandles are returned whether the program halts normally or due to an exception. This was leftover from me trying to learn more about how Python handles object lifetimes.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1086](https://teamcity.mesosphere.io/viewLog.html?buildId=59361&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:35


Hi @zappabruno, really liked your very insightful branch. I think you hit on all the important points, but if you wanted to add something extra, I think "customer-focused" is a trait of character important for hiring the right programmer. Apart from that, great job!


It is working it seems. You don't have a changeset function defined, so we don't know how to update it. :)


翔哥加油


I'm not really sure why "etag" was used here... the setup.json uses that and the contents.json uses the custom header 'X-Concerto-Frontend-Setup-Key'.  I'm wondering if we can/should use that custom header here too instead of etag, leaving the etag still in the headers for any cache busting it may be doing.  If we did use the custom header we could remove the quote removal code below also.


OK


so what do you think, just `Chart`?


@callumlocke: how about this?


Dur!!

Works, thanks so much @josevalim YOU ROCK!

`
iex(1)> Ecto.Changeset.cast %HasOne.Parent{id: 1, name: "Bob", child: %HasOne.Child{name: "Larry", id: 1}}, %{"name" => "Bob", "child" => %{"name" => "Mark", "id" => 1, "parent_id" => 1}}, ~w(name child)a

%Ecto.Changeset{action: nil,
 changes: %{child: %Ecto.Changeset{action: :update, changes: %{name: "Mark"},
    constraints: [], errors: [], filters: %{},
    model: %HasOne.Child{__meta__: #Ecto.Schema.Metadata<:built>, id: 1,
     name: "Larry",
     parent: #Ecto.Association.NotLoaded<association :parent is not loaded>,
     parent_id: nil}, optional: [], opts: [],
    params: %{"id" => 1, "name" => "Mark", "parent_id" => 1}, repo: nil,
    required: [:name], types: %{id: :id, name: :string, parent_id: :id},
    valid?: true, validations: []}}, constraints: [], errors: [], filters: %{},
 model: %HasOne.Parent{__meta__: #Ecto.Schema.Metadata<:built>,
  child: %HasOne.Child{__meta__: #Ecto.Schema.Metadata<:built>, id: 1,
   name: "Larry",
   parent: #Ecto.Association.NotLoaded<association :parent is not loaded>,
   parent_id: nil}, id: 1, name: "Bob"}, optional: [], opts: [],
 params: %{"child" => %{"id" => 1, "name" => "Mark", "parent_id" => 1},
   "name" => "Bob"}, repo: nil, required: [:name, :child],
 types: %{child: {:assoc,
    %Ecto.Association.Has{cardinality: :one, defaults: [], field: :child,
     on_cast: :changeset, on_delete: :nothing, on_replace: :raise,
     owner: HasOne.Parent, owner_key: :id, queryable: HasOne.Child,
     related: HasOne.Child, related_key: :parent_id}}, id: :id, name: :string},
 valid?: true, validations: []}
`


That's unreadable. I'd lead untouched as much as possible:

```js
return lookup(obj[key[0]] || {}, key.slice(1), value);
```


@scottschurr Yes thats a great idea. I was thinking, a new class `STFields` which represents a mutating set of fields (which can themselves be objects). Current code which modifies the `STTx` can instead build up a `STFields` object and then when all the dust settles, construct the `STTx` from `STFields`. This way the `STTx` is immutable upon construction.


What's your proposed wording for the comment?


@posita Matt, also further to this question:

> Does it work? How can one tell?

I used the mocha test framework.running `mocha` or `mocha test/id_spec.js` is how I determined if the code will run OK (as it is).

It's a super simple test, just runs the file from top to bottom.


actually I think `Chart` makes sense, it would read like `import { Chart } from '@panorama/toolkit';` which sounds right


comfort 5
completeness 5


Hi @saadahmed1, I really like your file regarding identifying and fine-tuning requirements. My comment would be similar to that of @zappabruno, but other than that, nothing else to add -- great job!


Is this posting messages in slack?


Yo man, are you sure that this should go to the interwebz?


OK, got it.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1087](https://teamcity.mesosphere.io/viewLog.html?buildId=59362&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 188 Build time: 00:04:25


有没有尝试下https://github.com/rackt/redux-router？


That is true. On the other side, it's harder to maintain (display here, hide there --> not really DRY) and if requirements change in the future, the code has to be modified anyways. When we design for every possible requirements that might arise in the future, is will be a mess.


-1. The correct way to expand path arguments is to use `encodingutil.argv_to_abspath`, which also handles `~` and supports "long" paths on Windows.


Please name this as `_getSelection` for consistency. thanks.


Name changing


AddAllTransitionBinaries (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (840 of 840 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.31%25-green.svg)


なるほど、了解です。
ちょっと気になったので…
/dev/tty分かってませんでした。


Should BaseView not implement CachableView with this addition?

Then ContentView, LocationView would not have to as BaseView already does.


tell me about it :(  no fun trying to make a script compatible with both either.


True… OK, make sense. But the date search is already a requirement. I still think it is better to keep it in HTML and hide via js. although we don’t have time to implement any more. : )

> On 16/10/2015, at 2:00 PM, Lukas Pirl <notifications@github.com> wrote:
>
> That is true. On the other side, it's harder to maintain (display here, hide there --> not really DRY) and if requirements change in the future, the code has to be modified anyways. When we design for every possible requirements that might arise in the future, is will be a mess.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/sdm15stream2/serler/commit/9c163b002c0bba910cbd722faa220eaf698628a9#commitcomment-13807000>.
>


No don't think I like `Chart`.  It should hint to D3 and not be confined to just chart visualizations because I am adding a map choropleth to the available models.


Same reply (https://github.com/sdm15stream2/serler/commit/9c163b002c0bba910cbd722faa220eaf698628a9#commitcomment-13806720). Having code for possible, future, unknown requirements does not make much sense from my point of view since it bloats the code. If requirements change, code has to be modified – that is part of the game.


That's a fair warning.  I should do an audit of the places that serialization happens in TransactionSign.cpp.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1088](https://teamcity.mesosphere.io/viewLog.html?buildId=59363&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:04:04


AddAllTransitionBinaries (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1914 of 1914 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Very cool!!


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1089](https://teamcity.mesosphere.io/viewLog.html?buildId=59364&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 192 Build time: 00:04:09


GHX_Vert_IDD (mmatts) - x86_64-MacOS-10.9-clang: OK (1909 of 1910 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


The requirement is to search for publication dates of `EvidenceSource`s (i.e. bibliographic *data*). `created_at` and `updated_at` are *metadata*.
The less code to maintain, the better. If you ask me, JS should be used for *behavior*, not for defining structure wherever possible. Otherwise, responsibilities are mixed, the code ends up messy and hard to understand.


`Catetory` --> `Category`


Thanks for the concern, @tfoldi.  This is an encrypted value that can only be decrypted on Travis CI's infrastructure, and only from automated builds triggered from _this_ repository.  Builds of pull requests from forks of this repo do not have the ability to decrypt this value.  You can read up on that [here](http://docs.travis-ci.com/user/pull-requests/#Security-Restrictions-when-testing-Pull-Requests).

Let me know if you're aware of something else that I'm missing.


em…yes, I agree. you’re right.
> On 16/10/2015, at 2:15 PM, Lukas Pirl <notifications@github.com> wrote:
>
> The requirement is to search for publication dates of EvidenceSources (i.e. bibliographic data). created_at and updated_at are metadata.
> The less code to maintain, the better. If you ask me, JS should be used for behavior, not for defining structure wherever possible. Otherwise, responsibilities are mixed, the code ends up messy and hard to understand.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/sdm15stream2/serler/commit/9c163b002c0bba910cbd722faa220eaf698628a9#commitcomment-13807125>.
>


Ehh amego


I think we should have `npm` scripts here, i.e. `npm test` or whatever?


Perhaps something along the lines of "If this goes off the STTx was constructed from a TxType and never signed."


In `setup.py` you were right to remove pyganim as an `install_requires` package (thank you!), but if we include `pygame` and `enum34` it breaks install on some systems (see: Travis-CI https://travis-ci.org/hypatia-engine/hypatia/builds/8564958).


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1090](https://teamcity.mesosphere.io/viewLog.html?buildId=59368&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:03:45


That could become obsolete if the surrounding code changes though


How about if I just remove the comment...since its misleading


Works for me.


That’s fine, but i put that assert in there to catch and correct crazy usage like this :)

Why not delete unused controls? How are these getting created without/losing the fonts in the first place? thats a condition that shouldn’t exist.

> On Oct 15, 2015, at 08:14, Jaka Kranjc <notifications@github.com> wrote:
>
> On Wednesday 14 of October 2015 19:40:27 Brad Allred wrote:
> > I stand corrected, there was a font check and return above beforehand. Still
> > I must question the value of having TE controls with no font…
> it's used in the cheat edit box, which we don't use. I'll return the return
> and add a comment, since there could be more users.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/gemrb/gemrb/commit/525b3187826d9cd9b6b00a8594afc7263e3b8c73#commitcomment-13793807>.
>


yeah I could wrap it if you wanted.


Should check if `batch` is empty.

```python
    if batch and not self.slot_available.is_set():
        self.slot_available.set()
```


no, I don't think we should call those scripts from npm, reason being they are for manipulating containers and its reasonable to expect anything thats a npm script can be run while your inside of a container.


Yes, will do.

On Thu, Oct 15, 2015 at 5:49 PM, Jimmy Lin <notifications@github.com> wrote:

> At some point, write test cases against data in src/test/resources/arc/?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lintool/warcbase/commit/cfe76f600c7d9200a3dccad3d461a0e63bc6cd8c#commitcomment-13804141>
> .
>


@borshop: retry


I honestly didn't think of `#undef`-ing them in my file.  My first thought was to turn them into default values in the `at91-sama5_common.h`.  Now you put me in the position of justifying my lack of thought :-)

I guess I prefer the idea of `at91-sama5_common.h` providing reasonable fallback defaults for the various options.

But it's not a strong preference.  So if you don't want to include this patch and set a precedent that you'll find annoying later, I'm happy to adjust my code as per your suggestion.

--wpd


Agree, we should discuss about what are the rules to determine which image should be on a card. I've started #471 for this.

@ShawnieBoy I tried to update all the cards that got bumped back to 2.5, none were updated. The most recent printings do not have any votes yet.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1092](https://teamcity.mesosphere.io/viewLog.html?buildId=59380&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:07:03


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1091](https://teamcity.mesosphere.io/viewLog.html?buildId=59379&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 186 Build time: 00:07:08


what's this?
Is it the php forms?

2015-10-16 6:13 GMT+08:00 Dennis Kupec <notifications@github.com>:

> [image: working]
> <https://camo.githubusercontent.com/e4dba71d75d677456ff915d6616547e389a9fff1/687474703a2f2f692e696d6775722e636f6d2f4c3945313277392e676966>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/composer/composer/commit/ac676f47f7bbc619678a29deae097b6b0710b799#commitcomment-13804551>
> .
>

--
顺祝：工作愉快

－－－－－－－－－－－－－－－－－－－－
Tel:18611591513
e-mail : mr.sheak@gmail.com
QQ:7830957


If `min_queued_messages` is less than 1, the producer `queue_reader` thread will run no-op loop when there is no message, it would be wasteful of CPU resources.


¿por qué quitaste el index?


ahh, I see, sorry then


@Adorfer Ah, sorry, I didn't read that you checked that the image was present in the manifest. Can you post the content of `/var/sysinfo/model`?


I have been testing this module on Puppet 4.2, and found that I got an error unless I set the variables like this for instance:

-SAMBA_START_MODE="<%= sambamode %>"
+SAMBA_START_MODE="<%= @sambamode %>"

Which seems to agree w/ the docs here:

https://docs.puppetlabs.com/puppet/latest/reference/lang_template_erb.html#variable

Not sure how this works w/ older versions of Puppet.


it looks great now!


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1093](https://teamcity.mesosphere.io/viewLog.html?buildId=59381&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:07:53


Este archivo no tenias q modificarlo, porfavor dejalo como estaba.


debes crear otro archivo, que se llama roles.sql


@rakuco the test works fine with X11 build, but if we remove this commit, the test could fail.


@darktears Yes, we can remove this commit and the test case. I will try to upstream it if it needs.


Server? :)


is the [Choosing_the_Database] an existed doc? Or you need to add a todo here.


OpenBSD ships libevent 1.4 with the base OS and which is what we build the rspamd package with. Thanks for this fix for the 1.0.5 release.


@shanemgrey
Ooops. I will check it in my atom but I didn't see any update issue after atom v1.0.


The indent is not correct. This two lines were not displayed in laterary.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1094](https://teamcity.mesosphere.io/viewLog.html?buildId=59382&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:08


Some instructions on killing SimpleHTTPServer would be good


現在用 crego.picture_url 就可以叫圖片了


Somewhat of a kludge, but at least the data will load into PostgreSQL without throwing an error.


Rather than give them the code to uncomment, I would prefer giving them a link to the function/etc. that they should use there.  The comment could explain what needs to be done (as shown in your banner comment) and include a targeted link to the relevant documentations (ex: http://pandas.pydata.org/pandas-docs/stable/generated/pandas.DataFrame.to_sql.html)


This is a `docker-compose` command tho. So it wouldn't be run inside a container.


Has does one use this 'setup magic' ?

'''~/dev/confplate/confplate$ ./confplate.py -l ../examples/cat3560.txt
  File "./confplate.py", line 161
    with open(filename, 'r') as f:
            ^
SyntaxError: invalid syntax
'''


This a and b should have indent since they are sub-items of 7.
Also recomment to use #. to replace the explict 1. 2. so that the list number can be created automatically.


一定要反斜線?


不记得了，某个服务还是网站的验证


Can you help me understand the exact consequences of PAL/platform overlap. Naively, it seems like it would not just be confusing, but also incorrect. I'm not aware of the data flow from user to here and back -- can we open ourselves up to behavioral breaking changes if we PAL out more values across different versions of the shim?


If these scripts are going to be executed directly (`./scripts/dev.sh`), we should add a shebang:

```
#!/usr/bin/env sh
# - or -
#!/usr/bin/env bash
```


Are we not returning a view?
And how is $location flagged?  We no longer have to get this?


the fact that the positional arguments are in a jumbled order between the two isn't the greatest api


No, this version no longer supports gulp4.0. Gulp4 has got a bunch of breaking updates recently.


Alright. I have found the actual problem (see this commit: https://github.com/zachsaw/MPDN_Extensions/commit/d9d998736838387d4adc0b25f0d55698b5b8ed03)

The `Preset` object in `Conditional` did not get its `Initialize()` and `Reset()` called, so `ActiveOptions` remained `null`.

>I'd really really recommend to just remove "Intialize()" as far as I can tell you'll lose absolutely no functionality.

`Initialize()` is actually used in AudioChain to get concrete classes to load their audio kernels.

> The worrying part is "Reset()", which also doesn't really work at the moment.

Hmm. Why do you think `Reset()` doesn't work?


update


pay attention to the incorrect indent


I don't have much preference. We don't save the chu, so deleting should also
be fine.


Didn't camel case endofgame


```php
echo "toto";
```


Remove `FIXME`.


Did you check the boundary cases?


Make your addReading() method clean. ´if´, ´else´ and parentheses have different indentation. With two nested try-catch blocks and if-else you cannot tell what happens in function. Remember: one function should have only one level of abstraction. building reading object, timestamp, modelAndView and try-catch are on different levels.


You can decouple these timing routines outside `q2`.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.682](http://teamcity.monogame.net/viewLog.html?buildId=10675&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


The water and grass work fine in EverythingDemo, so I'm pretty pleased with how quick and easy #91 was compared to, say, #64 . Getting android to work was on my list for a while and wasn't as hard as I thought it would be (having help with maven was great), even though it was still rather hard.


Why do you use the options here?


@Aaron1011 can you avoid the formatting changes next time. You've changed about 240 lines for the sake of changing about 8 *actual* lines of code.


Creates #17


Maybe add a Minetweaker log print here stating that this method is deprecated and the other one should be used?


- rubocop rake task + violations fix
- ArfReport < Report
- consuming arf report JSON from smart proxy
- arf reports displayed similarly to puppet reports
- no message for logs yet


Het is toegevoegd


This is a test comment.


@appleguy hi, what about task #385 for this line?


It doesn't work on ARM/Linux/GCC (ARM does not have mm_malloc.h).

I think that
- on Win32     : using _aligned_malloc
- on Unix-like : using posix_memalign

is more better way, like this commit a5228c5.


use com.intellij.util.TimeoutUtil#sleep


Also mapped the label names


Actually I was wrong, you are right, I checked that the single `facets(%Esolr{facets: fields, facet_limit: facet_limit})` function works, since both `%Esolr{facets: fields, facet_limit: facet_limit}` and `%Esolr{facets: fields}` yields the same data struct i.e. `facet_limit` is either default or defined (and mandatory).


Fixed by 6c0008f429d9dc6328075bab8667cb86b872182b

Sorry, my fault. I completely forgot about boost-from-source builds...


Why stage: 1? stage:2 should be enough. We do not want to use stage 1 features


PHP 5.4 array() -> []


I haven't setup any unit tests yet...
Everything will always pass....

Le 16/10/2015 11:55, Rocco Aliberti a écrit :
>
> https://travis-ci.org/presscustomizr/customizr/jobs/83735326#L268
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/presscustomizr/customizr/commit/a248a208462d2d0ad8cc59bbe36b0aeb50ca10bc#commitcomment-13812643>.
>


In English there is only one plural form.
However, in Russian there are two, depending on amount: from 2 to 4 it's "пакета", from 5 and more it's "пакетов"
See also here: https://dev.haiku-os.org/ticket/10755


Do you mean rerender everything instead of just the legend ?


While you're at this, you could also just support printing the crushmap in readable fashion as well... All it would take would be grabbing the crushmap from the osdmap and print it out (I think) :)


已知 issue.
1. slidedrawer 擋住的地方不能按
2. ape message 不見
找 bug 中


Fixes https://github.com/jruby/jruby/issues/3397


I'm happy to see this patch, but also welcome an idea of including only patches yellow in LTC.


And no you cannot call render instead of renderLegend inside onCrosshairChanged, as this event is triggered in render, so you have an infinite loop of function calls


第四次作业提交及说明.md

1.互感器最基本的组成部分是（绕组）和（铁芯），以及必要的绝缘材料。


这里可以使用 Double checked lock 来加快速度，不必每次都 lock。https://en.wikipedia.org/wiki/Double-checked_locking


第四次作业提交及说明.md

2.简要说明电压互感器的基本工作原理：其工作原理与变压器相同，基本结构也是铁心和原、副绕组。特点是容量很小且比较恒定，正常运行时接近于空载状态。在测量交变电流的大电压时,为能够安全测量在火线和地线之间并联一个变压器(接在变压器的输入端),这个变压器的输出端接入电压表,由于输入线圈的匝数大于输出线圈的匝数,因此输出电压小于输入电压,电压互感器就是降压变压器.


第四次作业提交及说明.md


Did you validate `A[]`?


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 618](http://build.prxm.it:8811/viewLog.html?buildId=4226&buildTypeId=Jarvis_DocumentStore_CI) is now running


Yes, I totally agree. This method was proposed @tterrag1098 and it can be easily bypassed


Why backquotes?


Listo.


Тест


:ok:


第四次作业提交及说明.md

1.互感器最基本的组成部分是（）和（），以及必要的绝缘材料。


merging dana


第四次作业提交及说明.md

绕组 铁芯


第四次作业提交及说明.md

其工作原理与变压器相同，基本结构也是铁心和原、副绕组。特点是容量很小且比较恒定，正常运行时接近于空载状态。在测量交变电流的大电压时,为能够安全测量在火线和地线之间并联一个变压器(接在变压器的输入端),这个变压器的输出端接入电压表,由于输入线圈的匝数大于输出线圈的匝数,因此输出电压小于输入电压,电压互感器就是降压变压器.


Do you think we can rely on travis when fully set-up then?


Merged as cf38366f57fc3eb0c756ecdbcf86362c9a080a88


Use `assert` instead.


It will fail, if run exclusively. This should be fixed.


Use upper case for macro definitions.


Don't put the generated `out` in GIT repository.


I was suggesting the opposite :) remove slf4j-simple


@neilsmeatom a new blog blog? Cool.


     && pos.count<PAWN>(strongSide) <= pos.count<PAWN>(~strongSide) + 1
should be
    && pos.count<PAWN>(strongSide) >= pos.count<PAWN>(~strongSide) + 1


Same here. Each spec shouldn't depend on others, but shouldn't try to validate all things.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.683](http://teamcity.monogame.net/viewLog.html?buildId=10679&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.682](http://teamcity.monogame.net/viewLog.html?buildId=10675&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:21:22


Hum, hay algo aquí raro. ¿Quién ha hecho el commit? ¿Estaba bien configurado el repo?


remove lines 32-35


Actualiza tu perfil con el nombre, uni y foto. Y por favor, recuerda que la entrega del primer hito del proyecto se acerca.


In case if you need to validate variable input, it makes sense to for-in loop each variant/result with common validation.


Thanks for that addition, works great!


@blakeembrey it's not too serious, I'm not really even sure myself. This kind of makes checking the changelog more difficult right after cloning since you can't open it in the terminal. I don't know how important that is, though.


this eliminates the congestion of packets because if packets of silent mp3 are collided it will not distort audio output and next message which is announcement plays smoothly.


@swissspidy ಠ_ಠ


l like this


:cry: J'aime bien ce "secourable"...


Nice! interesting new CSS properties!


@Mumfrey: Sorry about that - I was meaning to clean this up later.


Project is currently being reviewed by developers


OK. Let me see more this. From your comment I tried to remove both. When I removed the slf4j-api everything worked (so it was repeated), but if I removed slf4j-simple there were compilation errors.
Concretely here: org.slf4j.impl.SimpleLogger.DEFAULT_LOG_LEVEL_KEY.
Any alternative to use it? I used as a solution to see debug messages (otherwise I could see only above "info" level messages)


Very cool.


Well I only use backquotes everywhere now so that I have never to ask if I should use single or double or backquotes.

Backquotes allows you to do string interpolation at any moment (template strings):

```js
var world = ', world!';
var hey = `Hello ${world}`;
var well = `But what about ${someFunction(hey)}`;
```


![capture d ecran 2015-10-16 a 12 10 12](https://cloud.githubusercontent.com/assets/3052521/10539754/45aee640-7402-11e5-9384-2eeef780e51c.png)
test


5000 ist eigentlich "zu hoch": Die DHCP Range umfasst momentan nur 10*256=2560 Adressen.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1134](https://teamcity.mesosphere.io/viewLog.html?buildId=59525&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 188 Build time: 00:04:27


It shouldn't.

Likely wrong commit.

Level_actual can change if you change the lod of the texture when it is MANAGED.


This is not a tuning patch. It's a bug:
```
maximumTime = std::min(maximumTime, limits.time[us] / 2);
```
See comments here, on a similar patch:
https://github.com/mcostalba/Stockfish/commit/a55e31e270c83f4840c06ca9160ef3348a3d978b

The rest seems fine, even though I don't really like the `delta += delta / 4 + 4` part...


I gett this error :

device/qcom/sepolicy/common/init_shell.te:3:ERROR 'unknown type init_shell' at token ';' on line 19137:
allow  init_shell  fm_radio_device:chr_file { open read ioctl };
#for accessing fmradio device node
checkpolicy:  error(s) encountered while parsing configuration


@icatcher-at What's your opinion how I divided in this 3 methods the pattern stuff?


@icatcher-at  shoud this be configurable by options o data-* right?


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 619](http://build.prxm.it:8811/viewLog.html?buildId=4227&buildTypeId=Jarvis_DocumentStore_CI) is now running


what do you mean by fully setup ?


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 618](http://build.prxm.it:8811/viewLog.html?buildId=4226&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 294 Build time: 00:16:41
### Failed tests
```
Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_password("v1").verify_tika_job_with_password: <no details avaliable>

```


Awesome


The Group still exists, the URL has changed. @glaforge what's the new URL?


Why did you call it "first translation"?


Don't mix independent changes into single GIT commit.


what happens when you have two devices instances and allocate on both (on windows ?)

I guess it should somehow check if there is no process taking space as well.


Yes!


Propiamente no es el header, sino que lo sería ésto más la entradilla.
Podemos dejarlo así y poner la entradilla en un section.


lulz take from @MotoX2015


Mmm,
> I haven't setup any unit tests yet... Everything will always pass....
I meant, when you'll do that, can we "fully" rely on it?


change


Which task do you work for?
1. Check whether users plug out the USB-to-serial cables.
2. Check whether the USB-to-serial cable does not connect to any devices.


Here's how it looks like:

![everythingdemo-with-combined-panel-and-icoloredstring](https://cloud.githubusercontent.com/assets/634720/10539884/60108812-7403-11e5-9f06-131f5dbb5a4c.png)


oops, the regex needs work, get :blue:`:blue` here and several places.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1135](https://teamcity.mesosphere.io/viewLog.html?buildId=59529&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:20


@daskyrk this commit message is actually misleading; i realised after this that in fact jsPlumb did try to support `maxConnections` on a `makeSource` call but was failing - there was a bug. You can use `maxConnections` and `onMaxConnections` with `makeSource` (the demo still does):

![image](https://cloud.githubusercontent.com/assets/262720/10539894/ddb7e3c8-744e-11e5-8f9d-5db1f2a284d2.png)


Please follow the consistent coding style.


Check the definition of `NULL`.


@jgillis @ghorn I'm thinking that this should be the preferred syntax in C++ examples.


You might want to use `AttributeBuilder#buildPassword()` instead.


A comment needed here: it's not clear what this "backing field in outer class" means


why not using directly `id`?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1137](https://teamcity.mesosphere.io/viewLog.html?buildId=59545&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 184 Build time: 00:04:43


bummer. Personally MIT was the better choice as it is much more permissive.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1136](https://teamcity.mesosphere.io/viewLog.html?buildId=59532&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 188 Build time: 00:08:14


Fine by me :)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.683](http://teamcity.monogame.net/viewLog.html?buildId=10679&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:21:59


I am not sure if it is correlated to this fix or not.

This part of the code where we have "Did some resources become Dead or get removed from database" is a fallback executed only if the tables gantt_jobs_predictions and gantt_jobs_resources were cleaned up by hand.
Pierre told me that you had some issue with 2 oar-server that were executing concurrently. Could you check it is not the case?

Nevertheless I think we have indeed a bug in this fallback code.


We generally recommend the order of stylesheets be:
1. Reset/normalize
2. Any other external stylesheet (including fonts, frameworks, etc)
3. Your stylesheet(s) (style.css)

The reason we do this is because order matters in CSS and the things that come later have more importance. We don't want to accidentally override anything in our style.css file.


Nice work linking to the first assignment!


Looks like you misspelled "Canola"!


Can you write shorter code?


This improves the blue-blue thing:

    blue = re.compile(r"(\* CHANGE.*)\n")


TeamCity Jarvis :: Jarvis.DocumentStore :: Debug / Test / Release [Build 619](http://build.prxm.it:8811/viewLog.html?buildId=4227&buildTypeId=Jarvis_DocumentStore_CI) outcome was **FAILURE**
Summary: Tests failed: 2 (2 new), passed: 293 Build time: 00:16:23
### Failed tests
```
Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_password("v1").verify_tika_job_with_password: <no details avaliable>

Jarvis.DocumentStore.Tests.dll: Jarvis.DocumentStore.Tests.SelfHostIntegratonTests.integration_out_of_process_tika_multiple_password("v1").verify_tika_job_with_password: <no details avaliable>

```


Hi @karaenke, can you try running `otree collectstatic` then run the server again. Then email me at chris@otree.org to tell me the results, and specifically what is broken (which styles failed to load). Then I can better understand the optimal fix.


This needs to be indented so that the link works.


Yes, maybe hardcoding would look better because you will verify the results (now you're checking implementation IMO). What do you think?


lgtm


Yeah, it's on my todo list to create a new website for it :-(


just. Thankyou.


(Y)


Davide, I will redo this patch, to put the jars in the right location... regarding patches to source files, please make separate patches for code changes and formatting/whitespace changes... now, the full .java files seems changed, which makes the reviewing hard...


Use modulo operator here.


It can check both of them as I test in virtual machine. But Mr.Loi want to write a kernel module that can detect directly when the users plug out the USB-to-serial cables, it is more efficient. I think we should discuss more about this situation. Should we use 2 modules for 2 tasks or not ? My team need your suggestion.


I'm not sure I buy into this being simpler. You need to understand what `try` is doing, and you need to make the transfer from a method being called to specifying it as a symbol as parameter.

My feeling is that if this is needed often that we might use the wrong data structures and should rather have a richer object which encapsulates checking if the nested elements exist.


Someone asked me why the number of tests is different, depending on whether the docs are built or not.
With the change I made all those examples are run anyway during the documentation compilation phase.
- If there is a compilation error in an example CMake will complain.
- If some of the examples segfaults Sphinx will print out an error message.

So I don't really see why the examples should be run by `make test`...


And do not reset here. Just let it grow bigger and bigger.


is it necessary here? what about `find_by_repo_id` method. Is `repo_id` always integer?


Use the consistent coding style.


A simplified name would be `ticketsPerReward`.


Don't use hard-coded length for given string.


Did you validate `str`?


fixes #11


Shorten `smallest_character`!


This breaks git blame on files in sub-directories.


AddAllTransitionBinaries (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1914 of 1914 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Why?


globals aren't allowed. each test should support exclusive run


An alternative would be to not dispatch the `crosshairChange` from primary on every call to it, and just assign `sc.model.legendData` the value of the latest datum when the data changes (in the dataInterface callbacks in app.js).


Aren't we followingn the airbnb styleguide? https://github.com/airbnb/javascript#10.3


Did you validate `root` in advance.


Another alternative to if-statements is making a private function `checkSuperAdminRights` which throws exception if `(Permission::model()->hasGlobalPermission('superadmin')) === false`. Then you don't have to touch the other code by indenting it.


Can we just use this as the default configuration? For example, if we didn't want to show the volume here, how would we go about doing so? Would we be forced to code an enitrely new configuration?


Don't hard-code `6`.


Ok.
Indeed there is no check of the output.


all money isnt always good.


Follow the consistent coding style!


once again: please add to member class something like `default_mail` instead using `emails.first` everytime


asas


We'll have the same problem here as we had with the `blocking_get_mapped_udp_socket` function, i.e. sending to multiple peers at once shall decrease chances of creating a hole in Port and Address Restricted Cone NATs. I'm starting to think though that we've made a mistake to make this function take multiple SocketAddrs. If we do want to make multiple holes, we should do it one-hole-per-one-socket (this may not play nicely with port prediction but is improvement nevertheless).


To find the right node we can do the following. Let's say we want to find "def" in said line:
```
annot_node = self.lines[lineno-1].node # start with first node in that line (i.e. return)
while True:
    # finds the next textual node (skips indentation tokens and moves into languageboxes)
    annot_node = self.cursor.find_next_visible(annot_node)
    if isinstance(annot_node, EOS):
        break # reached end of file
    if annot_node.symbol.name == "def":
        break # this is what we are looking for
self.profile_map[annot_node] = msg
```


AddAllTransitionBinaries (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Actually in my OOP codes, I usually rename non-objects to more specific variants and reserve the non-suffixed names for the objects. I.e., `gchar *uri_string`, `gchar *collection_name`, `mongoc_uri_t *uri`, `mongoc_collection_t *collection`. Although, in this case, the TLA URI itself implies a string, while a mongoc_uri_t implies a parsed variant (perhaps `parsed_uri`?).


fix indentation of `case`


maybe lowercase "raw" instead of "Raw" ?


Don't put the implementation details in header file!


why commented out code?


If this is necessary to fix the build, maybe you should think about writing more/better tests instead.


Really great work! The only comment I have in addition to the one I left above is about the drop cap. There are basically two ways to achieve the "drop cap" effect. The first is to use a pseudo selector `p:first-letter` to apply our drop cap styles. The other is to use a _real_ selector like `p .first-letter` by wrapping the first letter in a `<span class="first-letter>`. You are doing a combination of both, which works, but is unnecessary. You could get rid of the span all together and it would still work.

BONUS! Here is a tip that may help going forward, but wasn't necessary for this assignment. It may be the case that we want to have our header and footer backgrounds extend all the way to the edge of the page. We can achieve this by changing our `#container` id styles to `.container` class and using multiple containers for our content while allowing elements like the header to be full width. Here is what that might look like:
```
.container {
  width: 1050px;
  margin: auto;
}
header {
  background: black;
}
footer {
  background: yellow;
}
...
<body>
  <header>
    <div class="container>
      <h1>My centered content</h1>
    </div>
  </header>
  <div class="container">
    <p>My main content</p>
  </div>
  <footer>
    <div class="container">
      <small>Copyright me</small>
    </div>
  </footer>
</body>
```

#FEWD Week #3 Project: CSS Layouts

---

###Description

Relaxr was really impressed by your work last week and wants you to continue development on their landing page. Starting in class, you will work to build out a more complex layout for their company site. They decided on creating a blog, and their back-end engineers will be focused on developing the blog's functionality. They want your front-end skills to style their designs using HTML and CSS so Relaxr's engineers can begin integrating. Once again, the designers have handed you a basic design file with instructions and the JPEG below to help you bring the blog to life. Submit the finished version for homework.

Student: Sophia Greenbaum

|                                                                                |                                |                        |                          |
|--------------------------------------------------------------------------------------------------------------------------------------|--------------------------------|------------------------|--------------------------|
| Technical Requirements                                                                                | Does Not Meet Expectations (0) | Meets Expectations (1) | Exceeds Expectations (2) |
| Use in-line-block or floats in your CSS to achieve a two-column layout                                                               |                                |                        |                          |
| Use the correct ```Open Sans``` Google Font typeface to style the text denoted in the design file and according to the JPEG provided |                                |                        |            X              |
| Use proper filename conventions (lowercase, .html)                                                                                |                                |                        |           X               |
| Use a single external CSS stylesheet to style all pages                                                                              |                                |                        |           X               |
| Use a background image for the headers                                                                                |                                |                        |          X                |
| Add a hover effect to all the links using pseudo-classes                                                                             |                                |                        |         X                 |
| Integrate drop caps using pseudo-classes                                                                                |                                |                        |          X                |
| TOTAL: *14*/14                                                                                |                                |                        |                          |


Can you improve your English expressions?


ok, changed here https://github.com/netguru/access/commit/526cead550bcfb1f4db66b2fb5a2181ed02e0af1


Coding style!


Erlauben Meta-Beschreibung und Meta-Schlüsselwörter per Batch-Edit zu ändern. Hier gewünscht: http://joomgallery.uservoice.com/forums/13274-joomgallery-feature-requests/suggestions/4293215-massive-meta-data-manager-plugin-or-inside-program

EN: Allow change meta description and meta keywords using Batch Edit. Here desired: http://joomgallery.uservoice.com/forums/13274-joomgallery-feature-requests/suggestions/4293215-massive-meta-data-manager-plugin-or-inside-program


Works but prints this on Ubuntu 14.04: `Gtk: Unknown property: GtkGrid.margin-start`

Possibly related, is this what the Filters tab should look like? Seems like spacing was lost or something.
![Filters tab](https://cloud.githubusercontent.com/assets/70239/10540384/79da60de-73d5-11e5-9fdb-61d9be40c788.png)


I suppose this function is applied only current file(which is in current directory). Could you tell me how to reproduce your issue ?


Why?


glad to see this project is still alive!


按钮size


done


:+1:

But we also want to see those entries in the CHANGELOG in master eventually...


Use `typedef` for `char (*fptr)(char *, char)`.


阴影 这个是垂直方向的 还有activity_horizontal_margin是水平阴影
fab_margin是中心辐射


don't you need to stringify_values?


Thx


we should probably do something with the return value of this function


I stumbled on this discussion after following my interest to find out what a bus factor would be :) I think it is very valuable what all of you have written down here, get's me thinking about solutions for the future. For now my gratitude for all of your insights and the effort everybody puts into writing and maintaining the software we all use and love.


Thanks for that looks a lot better, I'll fill in the other parameters tomorrow.


Of course the alternative would be to disallow Chains to have unmanaged resources, if you need that then you'd need to take care of that themselves somehow (e.g. through a static resources 'provider'). Not sure if any of the Chains actually have any unmanaged resources at the moment.


Depends of #59


Filder init


@binky123 I propose to better deactivate the existing scaling endgame functions in this case, because you might introduce some nasty evaluation discontinuities otherwise.


typo: "Finall"


Done


@oliverbrooks I'd try and keep functions out of the definition, that makes the format is portable across languages.


I get this error :

device/qcom/sepolicy/common/init_shell.te:3:ERROR 'unknown type init_shell' at token ';' on line 19137:
allow init_shell fm_radio_device:chr_file { open read ioctl };
#for accessing fmradio device node
checkpolicy: error(s) encountered while parsing configuration


I think he Alucard is aware of the consequences


.... c'est gentil, mais #1102


@jeffreyvh can you test building with my test-m branch

https://github.com/alviteri/device-qcom-sepolicy/commits/test-m


Also why not have multiple convertors, for example

    {
      pre: ["tostr", "unixtodate"],
      post: ["datetounix", "toint"]
    }


按下按钮的指示颜色


Warum hast du dazu keinen PR erstellt? Die Änderungen sind toll!


Yes, I was thinking about [].concat on all inputs so it can be singular or multiple.


增加属性默认值


Not unless someone requests a specific fix. Of the fixes in Core 0.11.1,

* The upnp bugfix is in 0.11D
* The low-S malleability 'fix' breaks existing software: we'll have to adopt that eventually anyway if only for consistency reasons, but if XT can help keep old software alive during the transition for longer it'll probably help users.
* The min relay fee change breaks existing wallets, is unnecessary with a proper mempool limiter and IMHO should not have been done. Again, we'll have to adopt it at some point for mempool consistency as otherwise version skew can assist people with double spending attacks. Being consistent ends up being more important than being correct :( But it's not urgent.


How exactly it obscures the intent?


Oh, there are a few other misc changes in it too, but none that appear very important.


`,` is redundant and breaks flow for no reason, Imho :-/


Another thing i suspects is that the first merge of the patch applied by Simon missing an important things :
```
# Update properties
if ($#properties >= 0){
    OAR::IO::lock_table($base, ["resources","resource_logs"]);
    # Avoid deadlock with Pg: MUST be also used in the right places (node_change_state, sarko, bipbip, ...)
    $base->do("LOCK TABLE resources, resource_logs IN EXCLUSIVE MODE") if (OAR::IO::get_database_type() eq "Pg");
    if ($#resource >= 0){
        set_resources_properties($base,\@resource,\@properties);
    }else{
        foreach my $h (@hostnames){
            if (OAR::IO::is_node_exists($base,$h) == 0){
                warn("/!\\ The node $h does not exist in OAR database. First you must add it with -a|--add option.\n");
                $exit_code = 2;
            }else{
                set_hostname_properties($base,$h,\@properties);
            }
        }
    }
    OAR::IO::unlock_table($base);
    push(@notify_server_tag_list, "Term");
}
```

The line `OAR::IO::unlock_table($base);` has been omitted and no changes was committed into resources.
I have added this line some minutes after, and resources was updated correctly.
The state between this 2 patches could have corrupted the database, what do you think about this ?
I will revert the database with a backup, and test again with the correct patch.


Hi @fkr

The reason behind this is that the GPL prevents the software from being included in proprietary applications. This seems to be an issue with Gatling at the moment, and shouldn't all software be free? But I as yet have not committed (learning Rust) so my opinion as yet doesn't account for much.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22245/testReport/) for this commit**


In my case:
  git root is: /home/alex/lsrc/qemu/qemu.git
  default-dir is: /home/alex/lsrc/qemu/qemu.git/aarch64-softmmu/
  buffer-file-name is: /home/alex/lsrc/qemu/qemu.git/target-arm/helper.c

I get (dumping args):

  Failed: 'git blame (--no-pager blame -w -L 6613,+1 --porcelain helper.c)'

Let me poke why default-directory got skewed because your right if git is in the right directory it can work it out.


Pro


Well a lot of RenderChains have unmanaged resources that need to be disposed of manually (do a search for `Reset()`).

I think the problem lies in the fact that the + operator shorthand doesn't keep track of the calling `Chain` which is meant to be the "owner" of all chains it instantiate like what PresetCollection does. Perhaps the we could just make Chain keep track of this?


Also read [this](https://github.com/madewithlove/tinkerlist/blob/develop/docs/rules_of_engagement/code_reviews.md) for extra inspiration.


Wow travis integration, cooool. We imediately know if ifcplusplus will compile on linux g++ if Fabian commits something without even need to pull his repo and the same for any pull request which is made !!!


Agreed!


need title


`a code review on code` :stuck_out_tongue:


Seems like a "thank" is missing?


Didn't quite get the message here.


本来还想用map<string,int>来进行处理，但是提醒内存超出，用这个方法反而是个正途，但是计算numStr的过程中存在大量的重复计算，可以进行改进


damn, author is @Nyeriah I combined two of her commits because the second edited the first sql file and it assigned me as author, I apologize @Nyeriah


@orangemug having an optional function pre filter sounds useful to me.  What I don't like about schemajs is having to register filters somewhere and then use them in a different file.  Adds state to the use of the module.

I guess this could be resolved if hannibal returns a generator function so you use it like this:

```js
var hannibal = require("hannibal")({
  pre: {
    doSomething: function (obj, key, value) {
      // do the thing
    },
    somethingElse: function (obj, key, value) {
      // do something else
    }
  }
})
```

Then you could either wrap hannibal with your custom definitions or pass in custom definitions when you use.


I think that this will recompile the regex with each call to `setKey` - this could be avoided by caching the compiled regex.


Vaya, pues tenemos la entradilla en la otra columna, así que no podemos incluirla. Hacemos lo que dices del section.
Otra posibilidad sería llevar la entradilla a la columna izq.


Sorry for being a trouble maker ...

But I think this option should be in ImapHostSystem... HostSystem, in my opinion is too generic, and NAMESPACE_SUPPORT applies only to IMAP test.

In a near future, I think we should introduce MPT tests for oher protocols, that will not be concerned by this option...


`therefore`, no? http://www.dailywritingtips.com/therefore-and-therefor/


And this does not change the PR that much :-)


@graemerocher : Hi, Can this commit / release 2.0-RC5 be published to grailsCentral Repo. This uses cas-client-core:3.3.3 which is what we are looking for. We are currently using the last published plugin "2.0-RC1" and we would like to use 2.0-RC5 commit on this page. Thanks in advance.

Thanks,
Sphoorti
sphoortiacharya@gmail.com


Working for you?
Just tested a build. Double tap to sleep works but notification panel acts all weird.
If i touch on my lock screen notifications, it makes notification panel fully collapse. Such an annoying bug.
Gonna revert it.
And double tap anywhere on lock screen to sleep. It isn't working for me at all :(


Reviewing **pull requests** that ha**ve**


Maybe
```javascript
    [TYPE.okAssertion]: err => dedent`
         ${getAssertionMsgPrefix(err)} failed at step <span data-type="step-name">${err.stepName}</span>:
    `,
```


he/she


I'm not really sure and asked myself the same question when writing the binding. They are really just duplicates of the doc strings for things like `command` and `encoder_polarity` and are most useful when generating API documentation.
For the Python binding, I'm not sure they are necessary at all - if you like, pull them out...


Ok, thanks. In the other forks, jena should be in the right position, and I'll make sure the formatting is right asap.


I think the original plan was actually deliberate. The idea was that a pure tone should be calculated for a short period and then looped rather than us creating a huge array for the simple tone. But if the looping mechanism isn't fast enough to get this done without ticking then I guess we need to revaluate the idea.


develop 브랜치로 commit or merge 해 주세요..


I'm porting existing project from maven to gradle. And with maven I can express this feature by adding something like this "<moduleDependencies><dependency><id>org.netbeans.modules:org-netbeans-lib-profiler</id><type>impl</type></dependency></moduleDependencies>". Sometimes its the only way to make netbeans work we know.


OS X 10.10. I switched MySQL-python for PyMySQL and it's been working. I
just has to make slight modification when SQLAlchemy spins up the db.

On Thu, Oct 15, 2015 at 11:20 PM, David J Shuckerow <
notifications@github.com> wrote:

> Ahhhh hit the send button too soon. I'll look at getting py3 compatibility
> added.
>
> What's your OS?
>
>
> On Thu, Oct 15, 2015, 9:18 PM Dave Shuckerow <djshuckerow@google.com>
> wrote:
>
> > Didn't know the target was python3 - on Mac, Python indicates 2.6, on
> > Linux it defaults to 2.7
> >
> > On Thu, Oct 15, 2015, 5:19 PM Brandon <notifications@github.com> wrote:
> >
> >> I had some trouble installing this, and I think it has to do with the
> >> fact that MySQL-python isn't Python 3 compatible. Does this sound
> right? Is
> >> there an alternative we could use? We want to write the site in Python 3
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >> <
> https://github.com/AuburnACM/auacm/commit/97e6f66a9c83a0831e1e9e0475db2f81b4da6675#commitcomment-13806471
> >
> >> .
> >>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AuburnACM/auacm/commit/97e6f66a9c83a0831e1e9e0475db2f81b4da6675#commitcomment-13808592>
> .
>


Actually thats quite nice as well because all the functions can just be stored as refs

    {
      transforms: {
        "tostr": function() { /* ... */ }
      },
      validators: {
        enum: function() { /* ... */ }
      }
    }


Feature added, thanks for the idea ;)


Hmm it will yes.  However it will only ever get called once when setting up the SPISchema object.  I could compile it in the Client class and pass it along with each schema creation instead.

Or are you more referring to the set function in general?  It is not publicly accessible so that regex will only be compiled once per object.


I think this might have been left in by mistake, it seems pretty open source already? :)


Indentation


On my end it seems that there is no need to exclude org.slf4j.IMarkerFactory nor org.slf4j.spi.MDCAdapter


We could create named values for properties. E.g.
```
polarity_normal = 'normal'
polarity_inverted = 'inverted'
```
@dsharlet said on [the same issue](https://github.com/ev3dev/ev3dev-lang/issues/67#issuecomment-99281669) for C++ bindings that the named constants have the advantage of being discoverable through IDE.


`try` is a very common thing to use in RoR applications (see http://guides.rubyonrails.org/active_support_core_extensions.html#try), I'd argue that the vast majority of ruby web developers are aware of the concept.


Thanks for the fine tuning lesson! My original pass at the problem used the more primitive technique, the modern decorators are definitely easier to read.
Nice thing about getting the API right, we can make changes like this without breaking too much...


If you dispatch `sc.model.legendData = {}` to the legend when the mouse is not on the primary chart, and test for an empty object, then we can safely call `render()` in `onCrosshairChanged()`, which is more in keeping with the procedure we currently have in place. (We should be able to run render with a timer rather than callbacks and things should stay roughly the same) .

Also would need to remove `dispatch.crosshairChange(model.data[model.data.length - 1]);`, as this is what causes the infinite calls.


Makes sense!


1: D100 Missing docstring in public module


Because I'm following this development, please prefer C++ style casts over C style ones.


imo no, as its specific to travis (~buildslave). there are several cmake flags defined in the buildbot config specfic to a buildslave:

https://github.com/spring/spring/blob/develop/buildbot/master/master.cfg#L733

i.e. when changing gcc compiler on travis,  tools/scripts/travis_* has to be changed. when its in cmake  tools/scripts/travis_ and cmake have to be changed -> imo bad


FYI there's a typo on line 15


I think that you got an accidental w in $this here.


Сделаю


Why not [0, 4]?


will update


The other thing I want to address is when should we actually call Reset()? In a standalone script such as 3DLUT it is easy - when user switches to another script, Reset() is called. However when it is used in a ScriptGroup, should we call Reset() when we switch from one group to another? Or do we only call Reset() when user switches to another renderscript? The latter has the risk of running out of GPU resources when large textures such as the 3DLUT had been loaded but is no longer needed.

Perhaps we should address this fundamental problem first before we start designing a solution?

I feel we need to Reset() whenever a chain is no longer required. If that's the case, then `ActiveOptions` and `Options` will need to be separate - the former keeps track of the current presets that have yet to be Reset() while the latter has the new changes.


Change to ```csharp much prettier ;)


Wrong commit comment, the unit tests for Formula.velocity() have been added


No worries at all


hi i am using TechNews theme but did not you help me.


Thanks Adri! But please don't use this block ;-)


Es la lógica del documento "qué es", que no necesariamente tiene porqué ser así en otros documentos.
Creo que va a ser más flexible dejar el header como tú propones y que la entradilla sea una sección.


As a guy that does not use an IDE that has no impact on me - but that does not mean I'm against the idea. Does each class that duplicates the property get its own copy? For example, `Motor` and `DcMotor` each have a `polarity` property. How does a user reference `polarity_normal`? Is it bound to the `Device` class or only the subclasses that use it?


keep use strict :-)


This code is stolen (duplicated) from CuratedContentEditorRoute.ts
Where should I put it so it can be called from both places?
@hakubo @rogatty


Не нужна промежуточная переменная


Does Objective-C not let you define the compiled regex as a constant in SPIConstants or the equivalent of a Java static variable in the SPISchema class? If not then compiling it once in the Client class sounds good... I don't know how long compiling the regex takes so maybe it is an unnecessary optimization.


AddAllTransitionBinaries (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (840 of 840 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.31%25-green.svg)


Executing animal-sniffer:check on each build seems like a waste of time. I prefer to execute animal-sniffer:check manually from time to time and before releasing a new version.


"schema" is Greek not Latin so acceptable plurals are schemas or schemata


@pickfire isn't this working in normal mode for you?

I think the problem is that this is working in normal mode and not the insert mode as you would expect.


Default page for Hello-World project


Файл ниже -
.../jni/com/mapswithme/utils/StringUtils.cpp → ...d/jni/com/mapswithme/util/StringUtils.cpp
?


Description should be Iglu not Snowplow


That is a third party library ^^


I hear you, my IDE of choice is vim :). I think `Motor.polarity_inverted` is enough. Also the Motor class (and any base class in general) is the only one that has the property values defined in the sepc.


Screenshots are not relevant


Du coup faudrait merger gh-pages dans master, supprimer la branche gh-pages et la recréer a partir de la branche mergée


Rather than just setting it to true could we somehow read value from ClusterTopologyManagerImpl?


I would namespace these to IGLU not SPI, it's much more revelant


@RandomAltThingy Then request a DMCA takedown to prove you are right.


Согласен. Но это просто перенос кода из другого места.


<!doctype html>

<meta charset="utf-8">
<title>Знакомство</title>

Максим Володимирович Порватов

Новачок в сфері IT. Магістр філології

Хочу вивчати Front-end тому, що:

Маю бажання працювати в сфері IT

Перекладати не дуже хочеться якщо чесно

А викладати тимпаче

Мій контактний телефон

093 262 66 84

Мій профіль у ВК:

 VK.com

Якщо треба, можу перекласти текст.


@jgranick, why is this still lacking? It would've been helpful when I started fiddling with this lib.


Related to #9


Solo un typo.


Comments for TriangelSquare:
1. The main point - the code is not working.
 Test data  -
int x1 = 1, y1 = 1;
int x2 = 0, y2 = 0;
int x3 = 0, y3 = 1;
Expected result is square is equals to  0,5 length of sides is 3,4142...
Real result is-
Length of all sides is 3
Square of all sides is 0.0
2. double AB
Please use names for variables only in lower case . In case when name is consisting of two word use "camel style" e.g. minValueForQuantity. But the name of variable always start with letter in lower case.
3. /* This program use method java.lang.Math.
 * Class TriangelSquare using the coordinates points and
 * take length; square. */
Are you sure that this class (it's not a program) is taking length and square? I think it's calculating them.


Java класс лежит в пакете util. Перенёс для консистентности.


Please add `platinum: ` prefix to the commit message.


TEST


So if a user by accident passes null for the cache name he could potentially switch rebalancing for all caches? A bit dangerous I'd say.


@Rikkola I think your test is in the wrong module?

```GuvnorDefaultEditorViewImplTest``` is in ```kie-wb-common-project-editor-client```


Whoops! Read too fast