@kelly-shen in the future, send changes as a pull request instead of merging it into master so we can discuss it.

@joshblum hm. i think it would be best if it works similarly to our search bar in eyebrowse that searches the query in the email AND in the listed first + last name. I also like how in the search bar, you can see the first and last name as well. In fact, why are we not just using the same API for both since they're basically the same? In base.js I see that the API end point for the search bar is /api/typeahead/.


Hi Aga,

I found a guide to git that could be helpful:
http://rogerdudler.github.io/git-guide/

D


nice nice, gg wp


Makes sense to me, although, this PR is old and no longer merges automatically.  It might make more sense to trash this PR and start with a fresh one.


Sorry if this is still WIP, but can you move this into the other commit?


Función de arrays de php Devuelve TRUE si needle se encuentra en el array, FALSE de lo contrario http://php.net/manual/es/function.in-array.php


I was intending for commit access to master to be restricted to Amy and
Josh.  I'll try to update permissions to reflect that.

On 10/30/2015 4:16 PM, Amy Zhang wrote:
>
> @kelly-shen <https://github.com/kelly-shen> in the future, send
> changes as a pull request instead of merging it into master so we can
> discuss it.
>
> @joshblum <https://github.com/joshblum> hm. i think it would be best
> if it works similarly to our search bar in eyebrowse that searches the
> query in the email AND in the listed first + last name. I also like
> how in the search bar, you can see the first and last name as well. In
> fact, why are we not just using the same API for both since they're
> basically the same? In base.js I see that the API end point for the
> search bar is /api/typeahead/.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/haystack/eyebrowse-server/commit/51b79c2bae7f0db123a800d0f545966f77416a19#commitcomment-14103073>.
>


As I was saying at http://irclog.greptilian.com/friendlyjava/2015-10-30 this added 15 seconds to the build time. I'm comparing https://travis-ci.org/IQSS/dataverse/builds/88410542 to the previous build. I can tell it's slower locally too.


we could a check of dimension


we could add the check of dimension too


Not exactly. I mainly introduced it as a convenience for myself - when making local changes to worker, it was useful to run all the worker tests and make sure that I didn't break anything. I don't have an issue with removing it from the Makefile (I could have just done a local alias too).


Missed that. Thanks, pushing fix right away. Also adding tslint modification for constructor vars


symmetry after binarization is gone! It does not make sense to save only upper triangular matrix... There is a need of saving 60k x 60k matrix efficiently. np.savetxt would take too much time...


lkhsa


I have merged this commit into my repository as p--b/icds-constitution@53698cdf083


It's ok like you did, but here is a suggestion that I already missed in other parts of the code: what do you think about a `bounded()` or `is_bounded()` function so we can reduce code like this to:

```c++
bool RC_Channel::in_trim_dz()
{
    return is_bounded(radio_in, radio_trim - _dead_zone, radio_trim + _dead_zone);
}
```

thoughts?


Are you, having a grap of me mate


Great job adding this mixin!


Try adding some functionality to your JS controllers to enhance what your website does.


Have fixed in db08249c972ff459471 - is this what you had in mind?


patch-1 (pachi) - Win64-Windows-7-VisualStudio-12: OK (2336 of 2365 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.77%25-yellow.svg)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.732](http://teamcity.monogame.net/viewLog.html?buildId=11025&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 551, ignored: 6 Build time: 00:20:18


add ` = 0` at the end of virtual functions, it removes the need to write `virtual foo() { }` in the source file


Play around and add another route here to see what happens :)


Are these namespaces *really* necessary?


What, it isn't finished? It is used by several hooks.


I've pulled in Gautam's wording as 53698cdf083ad3f7


pageSize should be a constructor parameter instead.


`override` at the end would be nice


Great!! I think is ready to merge!


LGTM


Achtung - hier ist da ein indent zu viel!


There too.


Ok. Got it.


style is to use JSONish hashes: `symbolize_names: true`


@ehsanmotamedi this trailing bracket is not needed


Mmm... the method says `set` but the implementation says `add`, so I'd leave it as `add_header(name, value)`, or just remove it because you can do `env.headers.add(name, value)` (the method doesn't add much value).

There's no way to write `header=` here because there are two values to "assign".


this whole block is indented with tabs rather than spaces


TeamCity LabkeyModules15.2 :: CDS postgres 9.4 [Build 37](https://teamcity.labkey.org/viewLog.html?buildId=281550&buildTypeId=LabkeyModules152_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 22 Build time: 00:37:32
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

```


we don't necessarily need codec and pagesize here.
pageSize can come from the constructor and codec can be looked up from codecName if necessary


abstract?


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1914 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.55%25-yellow.svg)


For now let's not merge them.

@kelly-shen can you add a pull request to search for the query in the email and first + last name as well?
also on the extension the first+last name should be shown along with username.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3082](https://teamcity.mesosphere.io/viewLog.html?buildId=66309&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:08:27


What about using a tuple

```crystal
def header=(args)
  @response.headers.add args[0], args[1]
end

env.header = {"Accept-Language", "tr"}
```


This doesn't look exclusive to PX4


can you list the manual testing steps that you did in the PR comment?


TeamCity pull requests :: netty [Build 538](https://garage.netty.io/teamcity/viewLog.html?buildId=2854&buildTypeId=pulls_netty&guest=1) is now running


Can't you just supply []?


Meanwhile headers are for request headers :smiley:


Looks good. I'll try to push out some new isos Sunday/Monday


we should only pull in headers in headers as the last resort.

Let's see whether we can avoid QObject header here.


TeamCity pull requests :: netty [Build 538](https://garage.netty.io/teamcity/viewLog.html?buildId=2854&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:58


Thank you :-)

It's good to know you're there to help when I'm fumbling :+1:


You're right, we are pushing forward on OMP 1.2 -- but it's just my experience that you'll spend double the time later trying to replay your last months of development in the correct order on a different repo, and probably getting it wrong :)


> Is ufo2ft meant to support both ufo2 and ufo3? ufo3 uses public.kern1 and public.kern2 as kerning prefixes.

Oh boy. I hadn't seen that the kerning spec was changed in ufo3. For now I'm focused on ufo2, but supporting ufo3 is a nice goal. What I don't want is two incompatible ufo2/ufo3 branches which have to be independently updated; hopefully it's possible to support both at once.

> Also I see that the kern and mark writers create fea code but couldn't they create feaLib tables directly?

I haven't looked at the API for feaLib and seen whether it provides an easy way to build binary tables without feature syntax. That would be ideal, but for now it seems more straightforward to go UFO -> .fea -> OTF.

> I guess you did test the current version on roboto already?

Yep, and some Noto fonts. I still need to do more of this. And though it was working before, last I tried with Roboto I got some kind of unhelpful segfault error from makeotf....


BytesCompressor should be abstract right?


I have merged this commit into my repository as p--b/icds-constitution@ff4785591ace


Note that you can nest the input within the label, removing the need to have the "for" attribute.


Oh...tabulation...


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity pull requests :: netty [Build 537](https://garage.netty.io/teamcity/viewLog.html?buildId=2853&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5241, ignored: 21 Build time: 00:15:15


delete new_file


Anyway i think ```add_header``` is more clearer like you said :+1:


as before, may want to set this back in a finally


This was for #4


... and close the statement somehow


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3083](https://teamcity.mesosphere.io/viewLog.html?buildId=66310&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:08:30


We should use the NoOpDecompressor instead and enforce Codec not null.


same, let's use a NoOpCompressor and simplify this code


Много измененных файлов, зачем в этом пул реквесте изменения файлов, не связанных с hw06 ?


let's remove that constructor


added comment


May you please set up a new PR for this commit. I think this must be done anyway.


Clearly this won't work if we want to do parallel tests... will need some db-side mutex there, or similar. but it should be fine for now.


Change the message to say "Add unit test for ....'


* For `excludedimports` it does not matter but it looks nice when they are printed sorted to stdout.
* For post-graph hooks order really matters in the while loop that expands graph based on hiddenimports in hooks.


I have merged in your proposed changes as ff4785591a


This needs a better commit message. What's broken? How does this commit "fix" it?


Just FYI https://github.com/mstembera/Stockfish/compare/ffbaa1c...d5b0f6e


Try adding some more SCSS (CSS) here.


Great work on implementing the adding machine!


Объдини оба коммита в один. С git rebase -i и squash разберешься?


`case-versions` appears to be unused...


here as well


Sounds like you're pretty good at implementing features using AngularJS. Try adding another route here to add more pages to your site.


Даже не знаю, я бы назвал как-нибудь типа `actual` и `expected`...


@kaithar
But "bro" wasn't reaching?

Is it only "reaching" when it doesn't agree with your political ideology? The _top voted_ result for BR is one of offense.

https://www.youtube.com/watch?v=TPJzkiPLbos


Não é necessário os parentêses


This should not be done within `candi.sh` the correct place would be the `dealii-prepare.package`.

This contribution would lead to an undefined behaviour for general projects, which I'm compiling also with candi.


Declarejs main file


Sorry, I didn't think about that.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_core/builds/1808


Hm, on Mac OS X, it works as expected. Unfortunately I can't test it on Windows. Is there any stacktrace or error? Maybe there's only missing some SwingUtilities.invokeLater(new Runnable() {...}); around some systray initialization.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3085](https://teamcity.mesosphere.io/viewLog.html?buildId=66313&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:23


Careful with this... dont normalize from an starting point that is 53 commits behind ayende:v4.0. That is a critical issue with this merge.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2647


@grydstedt published. Getting weird issues on the docs though, could you verify if it's working for you?


It sounds better like this, thank you


I was kind of thinking the same thing when I was working on some adjustments. What are you seeing here?


cc @pedrobaeza


Try having this re-direct to a different page instead of the home page.


Look at #621 if you have the opportunity (in case Igu is busy) before your rerelease something.


Modify some of the content here to customize it and make it yours :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3084](https://teamcity.mesosphere.io/viewLog.html?buildId=66311&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 173 Build time: 00:13:12


Add some custom styling here to really add some flavor to your site.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3089](https://teamcity.mesosphere.io/viewLog.html?buildId=66327&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:37


TeamCity pull requests :: netty [Build 539](https://garage.netty.io/teamcity/viewLog.html?buildId=2855&buildTypeId=pulls_netty&guest=1) is now running


Why 3 on this server ? I think it's a better idea to standardize this value between all of our servers, don't you think in the same way ?


Remove constant values from versioned API


this isn't that helpful i think i'm gonna remove this commit


I like how you re-directed this back to the home page - great job!


this should be set in individual projects and not here, right?


Hmmm, I think CAF based builds actually depend on libandroid. IIRC libandroid is disabled in AOSP based ports by disabling all the dependencies on libandroid.


Capitalize this - "None", "Allow", "Redirect" to be consistent with other constants.  Reencrypt will just be inconsistent for now.


I'm sorry I made a mistake by pushing to master yesterday! I just made a pull request to change the default to be an empty string. @amyxzhang I will add a pull request to search for the query in the email and first + last name. Do you mean that on the extension it should show both username and first+last name?


free shirt


i've totally done away with the Case and Form interface and in place i'm using abstract models


This lead me to installing the wrong branch of mavlink which did not have the extended state message thus erroring the build.  The other method is more straight forward.


How this help, and why not allow to suspend and mem reclame this workqueu? Something in kernel use that function the single thread work?


we unfortunately can't actually make this a true abstract class because you get a conflicting metaclass when you try to have `XFormInstance` inherit it. this is because jsonobject sets the metaclass as well


I think we should try to avoid creating instances of our models that aren't tied to Realm, especially on the frontend, because whenever we use one of our model instances, we should be able to assume that it is tied to a Realm. Things could potentially get hairy if we are creating objects in memory that aren't tied to a Realm.

To make it clear why this is important, imagine if someone else took over work on your project. It should read like a book and be easy to understand, but if they started looking at the SyncGroceryItem.add() function, it is likely they would assume that the grocery item had already been added to Realm because you are using a RealmObject to hold onto the data. We want to be as explicit as possible about what we are trying to do. I think there are two options here:

1. You can pass the data items in as individual parameters. ie)

    public static Task<Void> add(final String name, final ArrayList<byte[]> photoList) {}

That will get a little annoying if you go on to add more data fields to the grocery items.

2. You can create a Builder class to hold onto the data (this is a good option if you are going to have a lot of data items).

    public static Task<Void> add(GroceryItemBuilder builder) {}


I included it because I saw that they did in the example:
http://doc.qt.io/qt-5/qobject.html#Q_OBJECT

I'm still don't understand why it is optional.


No problem.
We may think about a special new fork from the recent candi only for deal.II to a new github repo.
Then we are fully able to tweak candi only for deal.II and do not have to restrict for general usage.
But let this discussion be made in a new issue.


Here, unless you really wanted to, you don't need to add both the <b> tags and the <span> tags since on your site that created two results.


this makes it way easier to do this in piece meal chunks


I think permissions are now set more safely---let me know if you see
anything wrong.

On 10/30/2015 4:40 PM, Kelly Shen wrote:
>
> I'm sorry I made a mistake by pushing to master yesterday! I just made
> a pull request to change the default to be an empty string. @amyxzhang
> <https://github.com/amyxzhang> I will add a pull request to search for
> the query in the email and first + last name. Do you mean that on the
> extension it should show both username and first+last name?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/haystack/eyebrowse-server/commit/51b79c2bae7f0db123a800d0f545966f77416a19#commitcomment-14103622>.
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3086](https://teamcity.mesosphere.io/viewLog.html?buildId=66314&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 172 Build time: 00:04:38


punting on attachments for the time being


Right clicking works. But left clicking and left double-clicking doesn't do anything (it was hiding and restoring the launcher). I don't see anything in the error log.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3092](https://teamcity.mesosphere.io/viewLog.html?buildId=66330&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:16


I lack a bit of context here, but: On OS X, it is simply not possible to set the thread affinity. This is apparently by design. Other libraries (e.g. hwloc) just punt on OS X.


Thanks :)


this almost runs all the way through, just need a serializer and a way to add dynamic props


So with sass, it's really easy to nest things. You could have tried this to get the social button hover the way you wanted:

```
.social_btn{
    position: fixed;
    left: 75%;
    top: 10%;
    color: white;
    font-size: 2em;
    text-align: center;
    background-color: #66FFFF;
    text-shadow: 1px 1px 1px #444;
    position: fixed;
    border: 5px outset gray;
    padding: 0px 5px 0px 5px;
    text-decoration: none;

    &:hover {
       a {
           color: blue;
           text-shadow: 1px 1px 1px #000;
       }
    }
}
```

I think your example of putting a hover on two things was making it so you had to specifically hover over the text of the link itself to change the color, but your color was the same anyway. What I am doing here is defining that when you hover over the social_btn, any a tag inside of it changes the text color.

Hope it works!


You should fix your import order (Java > Code Style > Organize Imports) to be alphabetical, according to ImageJ code style. This is defined in the [.epf file](https://github.com/imagej/imagej/blob/master/config/eclipse-preferences.epf) which you can import via File > Import.


What's the advantage of making the model `let` here? Don't we want to encourage the model to change?


Hahaha Pode ter certeza que sim!


@Sluchik вот эти префиксы — лишний шлак на этом этапе. Не стоит копипастить код из генераторов. Когда будет тема по кросс-браузерности, тогда да. Сейчас достаточно писать свойство по спецификации


It useful, because we allocate only a thread on cpu0 that it is responsible to do what we need!
Function is declared inside "include/linux/workqueue.h"
******************************************************************************************************************
#define create_singlethread_workqueue(name)                             \
        alloc_ordered_workqueue("%s", WQ_MEM_RECLAIM, name)
******************************************************************************************************************


@Sluchik здесь можно сократить


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3091](https://teamcity.mesosphere.io/viewLog.html?buildId=66329&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:47


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3088](https://teamcity.mesosphere.io/viewLog.html?buildId=66323&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 172 Build time: 00:09:12


Looks fine to me (along with cef79049116ae73a33919b17775c4e4f9e5671ce)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3090](https://teamcity.mesosphere.io/viewLog.html?buildId=66328&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:05:34


@zr2d2 I see what you're doing here, and it makes sense if pre is nil (that's what compact wants), but I don't believe that's what our automated scripts are doing. That is, when the version updates, this code will break, unless we make changes elsewhere.


@Sluchik семейство шрифтов и нзвание шрифта лучше задать body, там же размер шрифта и межстрочное расстояние для основного текста


fast-forwarding 2.0 to borshop-integration-792-bugfix/hashtree-delete-reopen = 8ca42d1b


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3087](https://teamcity.mesosphere.io/viewLog.html?buildId=66319&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:10:30


@garbles should I put more examples of attribute values as well that they can pass in? Was thinking it might be good to explicitly say in the markdown that this supports arrays, objects, and singleton values


sds


This fixes #2426


fast-forwarding end-to-end/timeseries to borshop-integration-1244-bugfix/bch/catch-bad-ddl-creation = 75ae0575


Merge sha f0aec65a is stale.


merging basho/riak_kv/fixes/am/fix-reversed-rows = 8614bd0c into borshop-integration-1248-fixes/am/fix-reversed-rows


basho/riak_kv/fixes/am/fix-reversed-rows = 8614bd0c merged ok, testing candidate = c3573bdb


saw approval from hmmr
at https://github.com/basho/riak_kv/commit/03d0420efe947382334f7c0dc0b80107f2bfb9c9


merging basho/riak_kv/bugfix/jrd/w1c-worker-race = 03d0420e into borshop-integration-1249-bugfix/jrd/w1c-worker-race


basho/riak_kv/bugfix/jrd/w1c-worker-race = 03d0420e merged ok, testing candidate = d89136a1


This is utterly confusing right now


The create method is where you actually save the item, not just set it up as new. You would need to do the @item=Item.new(item_params) thing here. Please review bloccit, and specifically how we created topics. Ignore any authorization stuff. If your controller doesn't have the code that's in there, then you won't be able to save it.


Since we are putting the form on the user profile, you won't need this.


Should still fit in a u8. Why this change?


This looks the wrong way round.  `tell` should `mappend` in the end, not in the beginning.  See https://hackage.haskell.org/package/transformers-0.4.3.0/docs/src/Control-Monad-Trans-Writer-Strict.html#writer


be careful, i changed my commit https://github.com/smad2005/PoeHud/commit/1f2dc8dd6106ffe918a6c35007c2c95c164d0a70 , there was a bug
RegionFree branch - it's will be finished only at december -january (there absent most important offsets)


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols. (https://github.com/bbatsov/ruby-style-guide#consistent-string-literals)


Style/AlignHash: Align the elements of a hash literal if they span more than one line.


Style/EmptyLines: Extra blank line detected.


Style/EmptyLinesAroundClassBody: Extra empty line detected at class body end.


Added Outline*


(Although I guess it doesn't matter since you remove it later)


Since we are showing our list of items on the user profile, we don't need this.


I think I prefer `debug_assert!` here in layout.


Ну не знаю, по-моему это путает. Мы ж сравниваем результат дао и сервиса, или я что-то не так понимаю?


Куда я денусь? :-)


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 767](https://teamcity.labkey.org/viewLog.html?buildId=281554&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 20, passed: 240, muted: 23 Build time: 00:42:30
### Failed tests
```
org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyParticipantCounts: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterPane: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

##### there are 10 more failed tests, see build details
```


@zr2d2 You can muck about with this to get what compact is looking for (https://github.com/concerto/concerto/blob/master/tools/release.sh#L24), but using nil in that fashion is not the best style. Though perhaps it's better than the reduce/array evilness, so there's that.


We don't really have the concept of a user show view, because we will just display the items as a list and not make them click into a show. There is nothing to an item except the name really, so no reason to have a page dedicated to that.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1035.b46f2858def7ce866adb61740e18d1ec5ab4566c](http://build.palaso.org/viewLog.html?buildId=65204&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 709, ignored: 6 Build time: 00:11:04


Look at the topics controller destroy method from bloccit for inspiration here.


TeamCity pull requests :: netty [Build 539](https://garage.netty.io/teamcity/viewLog.html?buildId=2855&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5240, ignored: 21 Build time: 00:15:21


@amyxzhang so we should just remove this method and only use `/api/typeahead` and make the case insensitive changes there


You can whack this file.


Consider renaming to `reset`.


@ayende has been informed about this and we agreed that this branch will become new v4.0 in his repository and he will rebase/cherry-pick his changes and move to a feature branch.


This causes a crash as the ref is being released when is still in use.
Setting the line before this way solves the crash and makes the analyzer happy:
id reachability = [[self alloc] initWithReachabilityRef:CFBridgingRetain((__bridge id)ref)];


I think there's a word missing in this error message.


<%= render 'items/form' %>


I'm not sure about the name `FakeElement` for this. Maybe `ElementWrapper`? I mean, this object *does* represent an element (right?); it just exposes different behavior…


@Sluchik тег h1 тут не уместен


I added that fix...
Maybe it's better to revert it back until the region free it's working...
I was thinking about how many ppl are waiting for this addon... :)
I finally fixed that corrupted area ...alone :D

Ty for info,


@Sluchik зачем здесь лишний класс?


whoops - should read "genre"


remove all of these get 'items/whatever' lines.


BE was NOT working.  There is all sorts of other BE porting in other parts of the code.  However, I think when the authors 'optimized' the interface, this must be the one area missed, and the authors never tested this 'optimized' code against BE.  The byte-byte parts fully had BE handling.  Just not this part.

I am not overly happy with the code, but I am not sure it can be done much better.


@Sluchik тоже лишний класс


> What I don't want is two incompatible ufo2/ufo3 branches which have to be independently updated; hopefully it's possible to support both at once.

It should be rather straightforward, the main difference is that ufo3 has standard kerning prefixes while the @ thing in ufo2 was just a convention amongst programs and technically any group could be a kerning group.

> I haven't looked at the API for feaLib and seen whether it provides an easy way to build binary tables without feature syntax. That would be ideal, but for now it seems more straightforward to go UFO -> .fea -> OTF.

Yea the current way of doing it is almost certainly more straightforward. I would like to add shaping support to the font editor I work on at some point, which would involve compiling the font features and holding the feaLib/fontTools object to do the shaping – I'm trying to think about how many steps this would take.

> And though it was working before, last I tried with Roboto I got some kind of unhelpful segfault error from makeotf....

haha, I can relate to this. ufo2fdk has a useful feature in that it can save a .fdk folder that contains all the files it generated so it's possible to inspect/edit them and run makeotf manually afterwards.


You are going to need destroy in there too.


kenr, your commit erased code from example_advertisement.js. Purposefully?


Roger. Was trying to merge the 3.5 changes into 4.0 and couldnt find the 4.0 branch mentioned in the mail and found this one, was surprised to see how old it was.


Да


@Sluchik `copyright`


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1036.9b50415aabcd5afd710e5515da52e6bd434af4d0](http://build.palaso.org/viewLog.html?buildId=65205&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 722, ignored: 6 Build time: 00:10:11


You run `rake` (by itself) locally before commits if you want to run tests and linters locally. Defined here: https://github.com/linuxfoundation/cii-best-practices-badge/blob/master/lib/tasks/default.rake


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3093](https://teamcity.mesosphere.io/viewLog.html?buildId=66331&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 172 Build time: 00:04:10


and no bugs?


Might be a little clearer if you moved `cur =` to the `sel.clone()` line below. Up to you.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3095](https://teamcity.mesosphere.io/viewLog.html?buildId=66334&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:28


Great job :thumbsup:


Can we use `_` instead of `false` here? IIRC that's the best practice to ensure a match


fast-forwarding end-to-end/timeseries to borshop-integration-1248-fixes/am/fix-reversed-rows = c3573bdb


saw approval from jonmeredith
at https://github.com/basho/riak_kv/commit/ff087b902c592c09f6a385a4ecea6f599252f259


merging basho/riak_kv/bugfix/zl/hashtree-cleanup-for-meta-counter+flush = ff087b90 into borshop-integration-1242-bugfix/zl/hashtree-cleanup-for-meta-counter+flush


basho/riak_kv/bugfix/zl/hashtree-cleanup-for-meta-counter+flush = ff087b90 merged ok, testing candidate = 290b35ab


This is a great comment and helped me understand the logic a lot better. Thank you for writing it :)


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (888 of 888 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.63%25-green.svg)


@ilkovich Looks good!


Why is the compact needed now?


I think this change to use Spring code produces error code now

    Cannot cast object '500' with class 'org.springframework.http.HttpStatus' to class 'int'. Stacktrace follows:
    Message: Cannot cast object '500' with class 'org.springframework.http.HttpStatus' to class 'int'
        Line | Method
    ->>  135 | $tt__loadUsers   in org.bbop.apollo.UserController
    - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
    |    198 | doFilter         in grails.plugin.cache.web.filter.PageFragmentCachingFilter
    |     63 | doFilter . . . . in grails.plugin.cache.web.filter.AbstractFilter
    |    449 | executeChain     in org.apache.shiro.web.servlet.AbstractShiroFilter
    |    365 | call . . . . . . in org.apache.shiro.web.servlet.AbstractShiroFilter$1
    |     90 | doCall           in org.apache.shiro.subject.support.SubjectCallable
    |     83 | call . . . . . . in     ''
    |    383 | execute          in org.apache.shiro.subject.support.DelegatingSubject
    |    362 | doFilterInternal in org.apache.shiro.web.servlet.AbstractShiroFilter
    |    125 | doFilter         in org.apache.shiro.web.servlet.OncePerRequestFilter
    |   1145 | runWorker . . .  in java.util.concurrent.ThreadPoolExecutor
    |    615 | run              in java.util.concurrent.ThreadPoolExecutor$Worker
    ^    744 | run . . . . . .  in java.lang.Thread


No need, all was merged today, use my branch as a base of your work till @ayende sort this out.


Unfortunately, break The Red Star
http://www.emunewz.net/forum/showthread.php?tid=3868&pid=227092#pid227092


I was wondering about that.   For some reason I ignored the IDE.  My bad I can fix it.

Nathan

> On Oct 30, 2015, at 5:03 PM, Colin Diesh <notifications@github.com> wrote:
>
> I think this change to use Spring code produces error code now
>
> Cannot cast object '500' with class 'org.springframework.http.HttpStatus' to class 'int'. Stacktrace follows:
> Message: Cannot cast object '500' with class 'org.springframework.http.HttpStatus' to class 'int'
>     Line | Method
> ->>  135 | $tt__loadUsers   in org.bbop.apollo.UserController
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> |    198 | doFilter         in grails.plugin.cache.web.filter.PageFragmentCachingFilter
> |     63 | doFilter . . . . in grails.plugin.cache.web.filter.AbstractFilter
> |    449 | executeChain     in org.apache.shiro.web.servlet.AbstractShiroFilter
> |    365 | call . . . . . . in org.apache.shiro.web.servlet.AbstractShiroFilter$1
> |     90 | doCall           in org.apache.shiro.subject.support.SubjectCallable
> |     83 | call . . . . . . in     ''
> |    383 | execute          in org.apache.shiro.subject.support.DelegatingSubject
> |    362 | doFilterInternal in org.apache.shiro.web.servlet.AbstractShiroFilter
> |    125 | doFilter         in org.apache.shiro.web.servlet.OncePerRequestFilter
> |   1145 | runWorker . . .  in java.util.concurrent.ThreadPoolExecutor
> |    615 | run              in java.util.concurrent.ThreadPoolExecutor$Worker
> ^    744 | run . . . . . .  in java.lang.Thread
> —
> Reply to this email directly or view it on GitHub <https://github.com/GMOD/Apollo/commit/84f4407e3cf5b59910778ad8c91db4445dd43981#commitcomment-14104127>.
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3094](https://teamcity.mesosphere.io/viewLog.html?buildId=66332&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:05:03


Plugins must be reinstalled via PlugInstall.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3097](https://teamcity.mesosphere.io/viewLog.html?buildId=66335&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:07


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.547.a00c460a64b62086bca89bc55483c54f29b697d0](http://build.palaso.org/viewLog.html?buildId=65206&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3337, ignored: 130 Build time: 00:08:11


Comment needs updating


Whoops, missed this somehow, thanks.
"debugcloning" mode also got removed in the merge, was this deliberate?


This is in a javascript template — the way I have it set up (using the basic lodash templating engine) all vars and functions are attached to an object before getting passed in. It's sort of a hack... makes it so that the templates don't throw an error if one of the variables is undefined, which is useful. Other (better) templating engines handle this, but we already have lodash as a dependency.


104921238_EnergyPlus_Performance_Framework (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1418 of 1420 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.86%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.37%25-green.svg)


Чому коміти однаково підписані?


Не бачу пул реквеста із мастера в gh-pages


@deads2k somehow I'm able to do the correct and the wrong thing at the same time with this in the same pull ...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3096](https://teamcity.mesosphere.io/viewLog.html?buildId=66333&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:09:02


@adcroft , this approach is certainly more elegant!

I am testing with thetao.  I still cannot get the layer average computed here in Z-space (k=1) to match tosga.

     In MOM6-examples/ocean_only/global_ALE/z:
          tosga = 18.16101
          thetao_z_xyave(k=1) = 18.15897

Any ideas?


**Code Quality - Nitpick**

Signing out doesn't require any parameter at the front end.
Just the session are the back end is invalidated.

`$scope.user` is `undefined` as well.


You are right. Thanks :-)


тут потрібний вложений список


`sender` is the more standard form the task when using these signals, according to the documentation: http://docs.celeryproject.org/en/latest/userguide/signals.html


This is deprecated, according to the documentation — is this worth changing now? http://docs.celeryproject.org/en/latest/userguide/signals.html#task-sent


TeamCity pull requests :: netty [Build 540](https://garage.netty.io/teamcity/viewLog.html?buildId=2856&buildTypeId=pulls_netty&guest=1) is now running


I think this could be rather obvious


Fixed:

https://github.com/GMOD/Apollo/commit/85b826f66a974c6ea814c8787e82e845a0020e86 <https://github.com/GMOD/Apollo/commit/85b826f66a974c6ea814c8787e82e845a0020e86>

Render / response . . . confusing myself.

Nathan

> On Oct 30, 2015, at 5:05 PM, Nathan Dunn <ndunn@me.com> wrote:
>
>
> I was wondering about that.   For some reason I ignored the IDE.  My bad I can fix it.
>
> Nathan
>
>> On Oct 30, 2015, at 5:03 PM, Colin Diesh <notifications@github.com <mailto:notifications@github.com>> wrote:
>>
>> I think this change to use Spring code produces error code now
>>
>> Cannot cast object '500' with class 'org.springframework.http.HttpStatus' to class 'int'. Stacktrace follows:
>> Message: Cannot cast object '500' with class 'org.springframework.http.HttpStatus' to class 'int'
>>     Line | Method
>> ->>  135 | $tt__loadUsers   in org.bbop.apollo.UserController
>> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>> |    198 | doFilter         in grails.plugin.cache.web.filter.PageFragmentCachingFilter
>> |     63 | doFilter . . . . in grails.plugin.cache.web.filter.AbstractFilter
>> |    449 | executeChain     in org.apache.shiro.web.servlet.AbstractShiroFilter
>> |    365 | call . . . . . . in org.apache.shiro.web.servlet.AbstractShiroFilter$1
>> |     90 | doCall           in org.apache.shiro.subject.support.SubjectCallable
>> |     83 | call . . . . . . in     ''
>> |    383 | execute          in org.apache.shiro.subject.support.DelegatingSubject
>> |    362 | doFilterInternal in org.apache.shiro.web.servlet.AbstractShiroFilter
>> |    125 | doFilter         in org.apache.shiro.web.servlet.OncePerRequestFilter
>> |   1145 | runWorker . . .  in java.util.concurrent.ThreadPoolExecutor
>> |    615 | run              in java.util.concurrent.ThreadPoolExecutor$Worker
>> ^    744 | run . . . . . .  in java.lang.Thread
>> —
>> Reply to this email directly or view it on GitHub <https://github.com/GMOD/Apollo/commit/84f4407e3cf5b59910778ad8c91db4445dd43981#commitcomment-14104127>.
>>
>


thanks:))))


Doesn't this mean you're not installing the `libutf8proc.$(SHLIB_VERS_EXT)` symlink anymore, merely creating it in the current directory? AFAICT, if you don't want to harcode the absolute path, you need to `cd` to it, and then create the symlink using relative paths.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3098](https://teamcity.mesosphere.io/viewLog.html?buildId=66342&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:20


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3099](https://teamcity.mesosphere.io/viewLog.html?buildId=66347&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:20


maybe better like, error initializing sound system + err


Just tried to reproduce the old behavior, but appearently it did only work for Windows. Makes sense, because it required the tray.dll.
On Mac, the show/hide behavior is weird, too, but can be rectified by removing the frame.setState(Frame.ICONIFIED);


104921238_EnergyPlus_Performance_Framework (lefticus) - Win64-Windows-7-VisualStudio-12: OK (1945 of 1956 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.44%25-yellow.svg)


while it has nothing to do with this code, I wonder if we could make GetComponent method simply return Component... maybe we cannot since we cannot cast this later to pointer to struct we care about?


probably not -- we'll likely never move beyond current version of Celery


same here, maybe sound error:


Hmmm... I tried that, but it didn't seem to work for the text shadow. I'll look into some of the sass nesting stuff further when I get the chance.


I think you might want to provide a fallback to the old import parsing because the purescript parser can currently only parse fully syntactically correct files... So editiing a function - adding an import - continue to edit the function won't include the new module for completion.


thanks :)))

On Fri, Oct 30, 2015 at 8:16 PM, doneykerr <notifications@github.com> wrote:

> Hi Aga,
>
> I found a guide to git that could be helpful:
> http://rogerdudler.github.io/git-guide/
>
> D
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/doneykerr/Project1/commit/a24462b8fb6d61a5125031cc0666e958e5c6e1e1#commitcomment-14103075>
> .
>


maybe better to use GoF state pattern?


@zeropv зачем это здесь?


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.525.a00c460a64b62086bca89bc55483c54f29b697d0](http://build.palaso.org/viewLog.html?buildId=65207&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3377, ignored: 124 Build time: 00:19:37


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3100](https://teamcity.mesosphere.io/viewLog.html?buildId=66352&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:16


MacBook-Pro-r-2:File_Cryptor mironenko$ du
80	./.git/hooks
8	./.git/info
16	./.git/logs/refs/heads
8	./.git/logs/refs/remotes/origin
8	./.git/logs/refs/remotes
24	./.git/logs/refs
32	./.git/logs
0	./.git/objects/info
174776	./.git/objects/pack
174776	./.git/objects
16	./.git/refs/heads
8	./.git/refs/remotes/origin
8	./.git/refs/remotes
0	./.git/refs/tags
24	./.git/refs
174984	./.git
9192	./FileCrypt_lite/bin/Debug
17904	./FileCrypt_lite/bin
200	./FileCrypt_lite/ico
288	./FileCrypt_lite/obj/Debug
288	./FileCrypt_lite/obj
48	./FileCrypt_lite/Properties
**188160	./FileCrypt_lite/Storage**
206904	./FileCrypt_lite
381992	.

Репозиторий на 380 МБ. Скачивать мучительно. Вроде в tmp решили проблему и недобавляли Storage. Почему в мастере оно появилось?


@zeropv нет такого свойства


it's already set to 3 for water ,I set same  https://github.com/MinetestForFun/server-minetestforfun-creative/blob/master/minetestforfun_game/mods/default/nodes.lua#L1367


```kotlin
var entry = entry
```
feels awkward. I wonder if this method could be rewritten in more idiomatic Kotlin..


https://developers.google.com/identity/sign-in/web/backend-auth#send-the-id-token-to-your-server

	function onSignIn(googleUser) {
	  var id_token = googleUser.getAuthResponse().id_token;
	  var xhr = new XMLHttpRequest();
	  xhr.open('POST', 'https://yourbackend.example.com/tokensignin');
	  xhr.setRequestHeader('Content-Type', 'application/x-www-form-urlencoded');
	  xhr.onload = function() {
	    console.log('Signed in as: ' + xhr.responseText);
	  };
	  xhr.send('idtoken=' + id_token);
    }

The endpoint url will be defined by @JohnRozier


What's better, defining `_GNU_SOURCE` or `_POSIX_C_SOURCE >= 200809L`? The latter, or both, sounds more portable. http://man7.org/linux/man-pages/man3/getline.3.html


Цей радіобаттон можна вибрати одначасно із іншими вище - це неправильно


@zeropv единственное место где классу `.container` задаются стили через родителя `.navigation`, в остальных двух случаях он без стилей. Вопрос: нужна ли эта лишняя оберка?


В цьому селекті має бути можливість вибрати декільки варіантів одночасно


Update this template to be passed a single context variable, `can_unenroll`. Avoid putting Python in templates, no matter how much mako supports it.


This does not fix any problem I have encountered, but it is more correct so it might fix some rare edge cases.


matter of preference but i would not inline this


upper case? CameraSystem.


Текст в інпуті має бути неможливим для редагування


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3102](https://teamcity.mesosphere.io/viewLog.html?buildId=66355&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:03


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3101](https://teamcity.mesosphere.io/viewLog.html?buildId=66354&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:35


Good job!


@zeropv в этом состоянии нужно переписывать только те свойства, которые должны меняться.


Can we hook WordBounds somewhere, like to World or somewhere? Now its unconnected.


span не підходить в даному випадку, бо span - це строчний елемент


@zeropv вот эта штука «прыгает» при наведении курсора. Подумай как можно это исправить.


took out the extra column


private methods in go are lowercased?


You can also turn off recursion temporarily by setting static Model::$recursion = false; before building any model objects. see Model::set_model_properties()


@zeropv в этом нет смысла, если задано обтекание


C6 is a test branch :P


Good note! Will change.


пустой


@zeropv `h1` тут не место


this will be fixed soon
and no, the method that is called there happens BEFORE corpse is assigned to a map so GetMapId() would return garbage


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3103](https://teamcity.mesosphere.io/viewLog.html?buildId=66356&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:15


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3104](https://teamcity.mesosphere.io/viewLog.html?buildId=66357&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:02


This commit requires a regenerate_and_update.sh run


The alternative would be:

```go
comp := entity.GetComponent("some name")
ac, ok := comp.(*AudioComponent)
if !ok {
    return
}
```

Not sure if that's an improvement.


@zeropv это должно быть отдельно


Для чекбоксів не підходить однаковий нейм, бо останній обраний тільки обробиться сервером. Тому потрібно писати або так name="spam[]" або задавати унікальний для кожного нейм (типу spam_1, spam_2 ...)


What do you propose in this case? (explicitly)


TeamCity pull requests :: netty [Build 540](https://garage.netty.io/teamcity/viewLog.html?buildId=2856&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5240, ignored: 21 Build time: 00:15:04


I would not have either; (see line 1)


Why do we have a breaking change over a typo that's not at all justified? I now have 2 projects that won't work because I updated to what I assumed was a non breaking change. Who doesn't know the difference between class and class_name? Should we change Object.class to Object.anonymous_class as well?


> For post-graph hooks order really matters in the while loop that expands graph based on hiddenimports in hooks.

But then it's easier to sort the `hiddenimports` in the while loop (assuming you mean the loop for processing the hooks in Analysis.assemble())


Let's discuss this on the bug
On 30 Oct 2015 16:48, "Makman2" <notifications@github.com> wrote:

> That's for sure no hack, it just means this editor does not need arguments
> to be invoked with. I think it's kind more of a hack to duplicate
> information here. Also I'm not convinced that the current solution is
> "cleaner", it's quite understandable what None or "" would mean as a
> value inside a dict^^
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/coala-analyzer/coala/commit/96c74b8a26a9546af7d8bd0c9a6e5d02219d2ff6#commitcomment-14097013>
> .
>


ok


Do we want to export it? I thought we weren't going to / shouldn't do so, therefore made it lowercase.

@paked what do you think? (I don't mind making it public, just saying it should be a decision we have to make)


@zeropv после названий шрифтов нужно указать тип шрифта. Гипотетически, если у пользователя не будет шрифтов `tahoma` и `arial` он увидит весь сайт в стандартном шрифте с засечками.


Ok from an accounting standpoint, but does a 100% discounted item still show on the POS receipt?


This is WIP, probably related to #35.


uppercase please.


Yes. Everything that starts with a lowercase (types, functions, etc.) are unexported / private.


Resolve o bug #34.


The issue here is whether or not §.7. (edF 1.511) ought to be included.
[§.7. "Exceptio fori dilatoria est, atque ideo in initio litis debet opponi et probari. Peremptorias autem exceptiones, ut sunt prescriptiones longi temporis, sufficit in initio litis contestari."]


`:class` and `anonymous_class` are not a valid option for users, if you used it by mistake you have to change it to `class_name`. It is only a breaking change if you are using it by mistake, but if you are using it your code is already broken.


Thanks Bob. Yeah, while @ JavaOne I had started thinking of delineated archetypes. Forge is good and something to think more about, but maven is "universal". This commit is goodness. Thanks.


I think it'd be good practice if we did this (at least for the `System`s).


Потрібно винести першу строку в thead


Review: @jayich, @aransfor, @gregllong


No, the symlink is created in the installation directory as intended. The first argument to `ln` is the target, not the path of the symlink. But given that you commented on this line, I will push a new commit that is funtionally equivalent but avoids this ambiguity at first sight.


would this even work after catch up with master? this needs to be a pointer


spelling error, I didn't know you could leave notes like this before filing my bug.


sorry my fault


It's something wrong with the healthbar...it's just randomly shows up after opening the hud. And it's still on the print text ```c# const int MARGIN_TOP = 2; ```...this should be higher then 2. And if there is a debuff icon...the floating numbers goes above the height of the debuff icon. It's like something bouncing/jumping up down...


    has_many :employees, class: User

worked perfectly before this change. Now it still works if you change class: to anonymous_class:


this returns a pointer, how come does it even work for you?


It did catch up with master, before pushing it.


where did that icon come from?


as discussed before: move route registrations to static initializer


where is that model defined?


width: ListView.view.width?


Thanks for the explanation. I look forward to hearing your results, as well as everything you intend to bring back from Daedalus.


why so complicated?


remove that please


@hlee probably not best to do this in memory?


yes but is slower :smile:


Good catch. I read the man page as well and was not quite certain. For compatibility with older GNU/Linux systems, the `_GNU_SOURCE` should definitely remain. I will push a revised commit defining `_POSIX_C_SOURCE`.


model is supposed to only exist in the else scope,this is because will be sent  as parameter of the trigger function and pushed into the this.models ..


I can guarantee you it is working by luck. We recommend you to change it to `:class_name`. `:class` and now `:anonymous_class` are internal options of the framework.


`.Cell()` returns a pointer, correct. But `NewRenderComponent` requires just something that implements:
```go
Render(b *Batch, render *RenderComponent, space *SpaceComponent)
```


@infil00p Did you intentionally change the persistent file default location back to 'compatibility'? It is now inconsistent with the documentation in README.md which says "the File plugin will use `Internal` as the default." I was working on some other bugs in this area when I noticed this.


I no cares


shouldn't the previous page pop the stack instead?


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2653


do we need this? I thought addSystem would do that.. via inversion of control (if it doesn't then maybe it should)


That looks like bad form, even if it does work.


Lets just make wrapper for events, then everything will be tracked properly and we will not need `force=True` in save.


agree, will wrap up a fix soon


... then you need to write a hook() function? I assume.


This line will always throw NumberFormatException, tokens[1] contains language name like "java" or "xml", see one line below. Only cloc supports counting of comments, SLOCCount doesn't. You should pass zero to report.add() here.


Look at that test I just posted from above it is doing exactly what I am talking about completely non "internally".


this is my software engineering homework


I think it's much more likely the issue is w/ many threads rather than just very long TC.


We are not validating the order of entries logged in DB, id =1 / id=2 condition not required. Same comment for Standard suite.


It has the `Component` stored, and all it should do is "give a reference to that object".

So it needs a place where it can store an address (a pointer).
So it needs a pointer where it can store a pointer (address to actual object).


Should update the comment NewFromJSON that currently says it's only for unit tests.


homework completed


103643052-FiniteDifferenceFluxOutput (mjwitte) - x86_64-MacOS-10.9-clang: OK (1946 of 1955 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.54%25-yellow.svg)


@joshuajlai I agree, it's very strange.  It seems like he's missing the point of the exercise.


You need to adjust the README with this naming.


Wouldn't it be a bit better to replace this with just a left margin for the label? ;)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3105](https://teamcity.mesosphere.io/viewLog.html?buildId=66364&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:40


For simpler project names like my-project.ui this will create a simple name 'Plugin'.
Also it used to have the suffix Activator. Why did you change it to Plugin?


Can't we replace this with a right margin?


We do not need 50000 delay time, 10000 is good enough


Where is that zooming button defined?


This is not restricted to HDFS. Files can be read from any supported file system.


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1913 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.55%25-yellow.svg)


Of course, this is the right way to do it.
Thank you Mick
Now fixed


Typo: CreateA -> CreateS


Not restricted to HDFS


Wouldn't the problem be better solved by using packet.createCopy()?


Good point, `AddSystem(cam)` does two things:
`cam.Setup()` and `w.systems = append(w.systems, cam)`


Ok, if you have any questions don't hesitate to ask :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3106](https://teamcity.mesosphere.io/viewLog.html?buildId=66366&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:03


should be `nnHost` instead of `nnnHost`?


(bump)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3109](https://teamcity.mesosphere.io/viewLog.html?buildId=66369&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:20


A RuntimeModule is some kind of dummy added to the Graph, so you can use it to "ignore" the module, too.

But maybe itis better to not mention it and avoid confusion,


Should be `DataSet<Tuple2<String, String>>` (second closing `>`)


In fact if you use an invalid key in rails 4.2 it will actually suggest :class as a valid key.

    ArgumentError: Unknown key: :class. Valid keys are: :class_name, :class, :foreign_key, :validate, :autosave, :table_name, :before_add, :after_add, :before_remove, :after_remove, :extend, :primary_key, :dependent, :as, :through, :source, :source_type, :inverse_of, :counter_cache, :join_table, :foreign_type

Now in 4.2.3 it suggests
    ArgumentError: Unknown key: :class. Valid keys are: :class_name, :class, :foreign_key, :validate, :autosave, :table_name, :before_add, :after_add, :before_remove, :after_remove, :extend, :primary_key, :dependent, :as, :through, :source, :source_type, :inverse_of, :counter_cache, :join_table, :foreign_type


opening `"` for path is missing.


Should be `nnHost`?


что вы имеете ввиду tmp? Я не знаю почему но говоря про Storage получилось так что после того как мы на паре это вроде как добавили оно не добавилось => пришлось добавлять самому а дома с нормальным интернетом 380 мб показались не тяжелыми.


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


In fact if you use an invalid key in rails 4.2 it will actually suggest :class as a valid key.

    ArgumentError: Unknown key: :arrg. Valid keys are: :class_name, :class, :foreign_key, :validate, :autosave, :table_name, :before_add, :after_add, :before_remove, :after_remove, :extend, :primary_key, :dependent, :as, :through, :source, :source_type, :inverse_of, :counter_cache, :join_table, :foreign_type

Now in 4.2.3 it suggests

    ArgumentError: Unknown key: :arrg. Valid keys are: :class_name, :anonymous_class, :foreign_key, :validate, :autosave, :table_name, :before_add, :after_add, :before_remove, :after_remove, :extend, :primary_key, :dependent, :as, :through, :source, :source_type, :inverse_of, :counter_cache, :join_table, :foreign_type


You'll learn :smiling_imp:


/**
 * @method Fluent first()
 * @method Fluent after($column)
 * @method Fluent change()
 * @method Fluent nullable()
 * @method Fluent unsigned()
 * @method Fluent unique()
 * @method Fluent index()
 * @method Fluent primary()
 * @method Fluent default($value)
 * @method Fluent onUpdate($value)
 * @method Fluent onDelete($value)
 * @method Fluent references($value)
 * @method Fluent on($value)
 */


is it possible that your development environment was broken because you had those git merge parts in this module?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3107](https://teamcity.mesosphere.io/viewLog.html?buildId=66367&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:27


Sorry, but this option is internal of the framework. Our tests can use internal options of the framework, but we don't encourage users to do the same. We reserve the freedom to change any internal option/method in the framework no matter of users are using them.

This exception is wrong and I'm going to fix.

What is public API of Rails is well defined, if users chose to use private APIs they will have to deal with possible changes in our code.

If you find any reference to `:class` or `: anonymous_class` in an association definition [here](http://api.rubyonrails.org/) or [here](http://guides.rubyonrails.org/) (which are the places that defines public APIs) I'll gladly revert this commit.

You have two options here:

1) Change to the public option that is documented in our official documentation.
2) Keep using the internal option that was made to be used in the framework and deal with any future change that may happen to this option.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3108](https://teamcity.mesosphere.io/viewLog.html?buildId=66368&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:45


Maybe this is combination of multiple threads and long tc. I had test with 7 threads at  STS and it failed. But when I ran  locally one game at 120+30 with just 3 threads and lazy looked visibly slower With just one game I can not be sure of course.


I don't know whether to document or not.

BTW: I changes the interface to `*names`, see 65ce801e5198f5fc1e3ce4b399b772ddc4ef71fa


saw approval from javajolt
at https://github.com/basho/riak_kv/commit/b7d9d0575a65a9d5760b7e559b2c2750798b4044


merging basho/riak_kv/cdj/dep-change/timeseries = b7d9d057 into borshop-integration-1246-cdj/dep-change/timeseries


basho/riak_kv/cdj/dep-change/timeseries = b7d9d057 merged ok, testing candidate = a1ceb1fa


saw approval from hmmr, javajolt
at https://github.com/basho/riak_kv/commit/fc4cf2808e4b7e28de2d745676b0cfe9a6df22ff


merging basho/riak_kv/bugfix/jrd/ts/w1c-worker-race = fc4cf280 into borshop-integration-1250-bugfix/jrd/ts/w1c-worker-race


basho/riak_kv/bugfix/jrd/ts/w1c-worker-race = fc4cf280 merged ok, testing candidate = 5fe54584


i can't find those favicons. have you added them?

and: can we put them into `/assets/img` instead? just for separation of concerns (`/data` is a "database" for me, `/assets` is the typical "static files & stuff" folder)


Yes, but AFAIR we decided on passing a single string.


@tymochko синтаксис


I think this creates an unhealthy dependency between `Sparkle` and `SKCommonLibrary`.
This dependency is not enforced by any configuration - the reason this works is lucky build-order.
Is it that bad if the name of the preference will be hard-coded here? Will we ever use this value from within the App?


FYI Nicole: this pulled in my b37 bullet.


@tymochko зачем здесь и ниже у каждого пункта меню свои отступы?


I guess I've just been using for the last year because of that Valid keys message above. I was super happy because it made tons of sense and I'd been hoping I could just use class for 8 years now. I'm a little sad this was just a mistake since it was an awesome one that matched perfectly with the ruby syntax of:

    2.2.1 :002 > "asdf".class
    => String
    2.2.1 :003 > "asdf".class.name
    => "String"


I think this change caused a regression which I am experiencing after upgrading from `v2015.5.3` to `v2015.8.1`. All of my `salt-cloud` requests are allocating a new elastic-IP now (and I ran out and can't spin up instances any more). I reverted this change in particular, and now it is behaving as it was in `v2015.5.3`.

In the latest documentation, `AssociatePublicIpAddress` is specifically said to NOT request an EIP. So, this `or` conditional seems to be erroneous.

https://docs.saltstack.com/en/latest/topics/cloud/aws.html


If using globs is not enough, e.g. you need to collect several, maybe nested directories, you can use helpers from the ``PyInstaller.hooks.utils`` module (see below) to create this list, for example::


hook-functions are required only in rare cases, where you need information passed by the `api` object.


The culprit is, as over here, the `indentline` plugin

https://github.com/offero/dotfiles/blob/master/vim/vimrc#L30


See the fun thing about nim is that things aren't strict!
`quit(QuitFailure) = quit QuitFailure = QuitFailure.quit() = QuitFailure.quit`!


@ChangeTip, send a coffee to @chrisaljoudi

Hi Chris - thanks for making uBlock. :)


Yes, I reviewed it before merging, thanks for adding it!


Hi @chrisaljoudi, @jqsjqs sent you a tip worth a coffee (4,639 bits/$1.50), and I'm here to deliver it ➔ **[collect your tip](https://www.changetip.com/collect/911985)**.

**[Learn more about ChangeTip](https://www.changetip.com/tip-online/github)**


That change wasn't intentional and creeped in due to when I worked on this code.  This should be changed back to internal.


@levity - I added this fix that has nothing to do with locations, just noticed it. lmk if there's an issue, or you want it in a separate PR


You're doing it right.


@isaacsloan using `:class` prior to 4.2 would raise an `ArgumentError` - this commit is effectively fixing that regression whilst still allowing `has_and_belongs_to_many` to be implemented as a special case for `has_many :through`. As @rafaelfranca said the option `:class` or `:anonymous_class` should not appear in the exception message and how we implement `has_and_belongs_to_many` should not leak out into the Rails public API.


@ChangeTip, send a coffee to @gorhill

Hi - thanks for making uBlock. :)


Not cleaning up is intentional. I don't want to force it... Sometimes there
are reasons not to. PixelWeb can automatically do this though.
On Oct 30, 2015 5:34 PM, "praeluceo" <notifications@github.com> wrote:

> spelling error, I didn't know you could leave notes like this before
> filing my bug.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ManiacalLabs/BiblioPixel/commit/8974f7b048824eb11e2de023f1687fb71b6a952b#commitcomment-14104596>
> .
>


Hi @gorhill, @jqsjqs sent you a tip worth a coffee (4,639 bits/$1.50), and I'm here to deliver it ➔ **[collect your tip](https://www.changetip.com/collect/911987)**.

**[Learn more about ChangeTip](https://www.changetip.com/tip-online/github)**


"change the distribution directory to gulp/dist" ?


I wonder if we should just wrap this more closely around the `ostree_repo_pull()` invocation ?  Otherwise I think odd things might happen if we accidentally send a DBus message etc. with the temporary one active.


@tymochko область ссылки не совпадает с видимой областью «кнопки» меню


There's a value in having this fixed, as it makes the resources used by the simulation more deterministic.
We want to provide a good balance between a powerful simulation and one that doesn't unduly taxes the system.
Having the metabolism set to work at a fixed interval makes it easier to reason about how much CPU a certain number of plants would consume.


And, by the way, our previous code had this race condition all over the place. We kept finding more and more instances of it and eventually decided that it *had* to be fixed in the coroutine code itself. Expecting all code that uses coroutines to be suspend/resume race safe was impossible.

Here's the most subtle:
https://github.com/ripple/rippled/blob/b71ff4cb88d0f28fc1c05d343bf240f63968e635/src/ripple/rpc/handlers/RipplePathFind.cpp#L116-L117
How can we be sure `jvResult` still exists when we assign to it?


Ooh, good catch.


you've just solved your first lab.


Do one can cast pointery im golang...


:+1: :+1: :+1:


Should probably mark that this is a hack. We don't want to make the code rely on a fixed type system.


Totally.


@tymochko это работает, возможно настройки монитора у тебя другие, попробуй убрать контрастность


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3110](https://teamcity.mesosphere.io/viewLog.html?buildId=66379&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:14


You should not comment out this line. There was an issue with this line but that has now been fixed by temporarily disabling FK checks. See PR #256.


Morze descriptive error Message


In fact, `libladspaeffect.so` does not belong in the `ladspa` sub-dir, good catch @michaelgregorius. I decided to just move the build statement of ladspaeffect up in the file though - instead of moving `SET(CMAKE_LIBRARY_OUTPUT_DIRECTORY …` to every sub-dir.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2655


If we're adding new API here I'd like to figure out how to allow people to do "check for updates" sanely from a simple shell script (or Ansible).  There are 3 possible return values:  `UNCHANGED`, `UPDATE_AVAILABLE`, and `ERROR`.

Something like --check-update that say returns `77` for `UNCHANGED`, `0` for `UPDATE_AVAILABLE` and anything else means `ERROR`?

The rpmdb preview might be a separate flag?

I have wanted before to write an Ansible script to tell me the update state across my hosts, and this would help I think, could use the "command" module and look at the return code.


Can we apply something like this for whole thumb?


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (1913 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.55%25-yellow.svg)


nice commit message, river

exemplary senior


A meg is pretty hefty. And we need to use a static analysis tool to figure out which functions are taking up way too much stack space. Try using the Visual Studio code analyzer, I remember it was squawking about a large stack utilization.


You likey huh?


Merged in https://github.com/smart-on-fhir/smart-on-fhir.github.io/commit/da68e29190028b9907537bbc5b96b524e72af9f2, thanks!


Also updated the readme in 0d5dd62


I'd really like to see some tests of these mechanisms, to make sure that no error creep through.
The effect would be things growing out of proportion.


Hm, so you are discovering some shadow blocks are the main culprit on slowing down web build?  Interesting!


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1426 of 1426 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.4%25-green.svg)


this change actually does not work in IE8 and IE9, navigator.AppVersion == 4 in IE8
(in fact I used IE11 with compatibility mode for IE8)


@tymochko этого не должно быть здесь.


Yeah, I got thinking about it: "hey, wait a minute..."


The problem here was that while the `plugins:` search path was used, it was empty at this point of execution, because `PluginFactory` hasn't been instantiated yet.
I fixed that by ensuring instantiation at the top of this function.


Eventually, we will only want that code to execute during a development build.

In production, we'd like that JavaScript to not execute and, ideally, remove the HockeyApp plugin from `config.xml`.


Theses are just some cleanups as this is already done in  `PluginFactory::PluginFactory` and added to the `plugins:` search path.


Thanks for the explanation @pixeltrix. It should probably be removed from the list of valid keys then. I guess that makes sense. It was a really cool step forward for the few months it lasted though. Even at #RailsConf this year it came up in a few conversations how happy people were that they could use class: Model now instead of class_name: "Model". Oh well.

I really do appreciate what you guys do and don't want to come across as negative. I was just really surprised that my favorite "new feature" of Rails 4.2 wasn't actually a feature and no longer works.


This is unecessary. No mobile will ever have an area.
And if they ever did; shouldn't that also be scaled?

Which probably makes the type check and PLANTTYPE and ANIMALTYPE also unecessary.


Ya, I'm just trying to see if I can get it to work. I'll make it nice later :P


Thanks - this seems to have fixed all kinds of recent wierdness.


Any reason you're changing `$(ECHO)` into plain `echo` instead of `$(CT_ECHO)`?


Otherwise, looks good. :-)


Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>


:trollface:
:hurtrealbad:


So tempting, this next release looks absolutely amazing. I need to figure out how to pull it in without moving all my other packages out of melpa-stable. So, to switch to el-get, or just manually install a CIDER git checkout…


@tymochko язык


@kelly-shen can you see if you can do this? There would have to be some slight modifications such as - only looking through friends for the getFriends case and looking for all people in the search bar case.


A friendly tip: when checking for null values it's better to do just
```if (box_property) {```
The reason is that you then remove the possibility of getting the comparison wrong by mistake (i.e. "==" or "=" instead).


That could have even been foled into the previous patch. But OK.

Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>


LOL, I wish all BE fixes were this easy!


@bradfitz a little late to this party, but it seems that `goos` in this case is the target OS, not the current running OS, which causes this to fail when targeting linux from OS X. Does that sound plausible to you?


commit syntax changed


you made 2 params? `css` and `customCSS` that both do the same thing? (inject a css file in the head)?


@tymochko должно быть в другом месте


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3111](https://teamcity.mesosphere.io/viewLog.html?buildId=66420&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:14


fast-forwarding 2.0 to borshop-integration-1242-bugfix/zl/hashtree-cleanup-for-meta-counter+flush = 290b35ab


book/modelo de concurrencia y event loop/pila.md

cada invocación


I believe to have found a portable solution by defining `_XOPEN_SOURCE` to 700. This implies `_POSIX_C_SOURCE == 200809L`, and avoids the non-portable `_GNU_SOURCE` at the expense of a compiler warning on GNU/Linux systems with glibc version < 2.10 that was released in 2009.


This should be OPERATION_BLOCKED instead.

I.e. we know it's a Tick operation directed at us only, so we shouldn't send it on.


este cuadro necesita una explicación


Thanks!


You only need to do this if you've actually changed some properties.


Ideally, we would also want to catch unexpected success, i.e.
a sample supposedly known to fail, but which succeeds.

However, I doubt that would be tremendously usefull to us, so

Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>

Note: it could be done thusly:

```
if $(MAKE) -rf $(CT_NG) V=0 build; then \
    if [ -e  $(call sample_dir,$(1))/broken ]; then \
        status=XPASS; \
    else \
        statux=PASS; \
    fi; \
elif [ -e  $(call sample_dir,$(1))/broken ]; then \
...
fi
```

And you'd have to handle that case in the other hun. But as I said,
do we really need this?


EconomizerIntegration (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1961 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Thanks for the PR, but this should be a data script :-)


:+1: Nice commit message!!!! (:


Experiment still has related_files so presumably they still need to be removed here? (And in skip_rows_missing_all_keys below)


@dpgeorge : It's know issue that readthedocs docs building is broken right? http://readthedocs.org/projects/micropython/builds/ . Tried to follow instructions to build locally and hit this.

> make MICROPY_PORT=<port_name> BUILDDIR=<port_name>/build html

It make sense to have BUILDDIR=build/<port_name> , why spread generated content around and mix it with sources?


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1914 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.55%25-yellow.svg)


I think this is going to break Drew's Map code. We need to undo this package changing from src.mapgui back to mapgui


TeamCity pull requests :: netty [Build 541](https://garage.netty.io/teamcity/viewLog.html?buildId=2859&buildTypeId=pulls_netty&guest=1) is now running


That's pretty smart! :-)


Good point, my brain was in copy mode when I did this.


Reviewed-by: Yann E. MORIN <yann.morin.1998@free.fr>


Adicionei formatação das mensagens conforme pedido. Isto incluiu criar uma variavel para o numero da mensagem.

Criei um metodo para editar a ultima mensagem.

Criei um metodo que devolve o numero do utilizador que escreveu a ultima mensagem.


For sure!


EconomizerIntegration (mbadams5) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


funciones


muito cuidado aqui porque ainda não aprendemos a fazer casting não sei se podemos usar...


Holy crap, use proper line breaks please!

And be more consistent in your code style. I mean, if you're going to burn my eyes, at least burn them evenly


I believe either would work fine. Happy to take a peek at a PR changing it if you have the time.


Yeah! :+1:


My opinion: if the usage of the ternary operator makes your line longer than 80chars, don't use it.

Not to mention, `style.background` is null by default, so you don't even need the true branch


Watch out for these, leftovers from uncrustify I'm sure


Here as well


Also here


Here


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3112](https://teamcity.mesosphere.io/viewLog.html?buildId=66432&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:29


Your facade classes should *NOT* implement positioning methods


Strange thing is that  large  changes of this parameter or slow mover (in several tests) do not cause sharp elo drop anymore. I think this is because of  move patch.


What exception are you catching? And why are you just printing it and ignoring it? Is this temporary code?


You're changing the API of `build_sample`, but are not changing the (single) caller.


y ahora???


I'm just going by your commit comment, and maybe I'm confused by what you're doing, but doesn't 'base_dir' already accomplish the installation of GF to a specific location?  That's how we use it (but we're on a really old forked version).


Reviewed-by: Yann E. MORIN yann.morin.1998@free.fr


Leaving doc in, maybe someday it will become real.


utilizar el termino __pila de llamadas (call stack)__ : que es donde se apilan las llamadas a las funciones en el orden que se invocaron.


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (887 of 887 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.57%25-green.svg)


This $(ECHO) should've been plain `echo` from the start, or the results of the build-all run will list all the samples without first printing whether it's PASS/FAIL/XFAIL; I only uncovered this when I started to look why V=0 build was failing. Sorry, I was lazy to go back and re-do the larger change for the build-all target - since both commits are a part of the same changeset, I think it should be ok.


__pila de llamadas (call stack)__ :


Don't know why rtd build is failing...

> It make sense to have BUILDDIR=build/ , why spread generated content around and mix it with sources?

Yes, makes more sense to have BUILDDIR=build/port


It takes three args:

https://github.com/pyinstaller/pyinstaller/blob/develop/PyInstaller/utils/hooks/__init__.py#L691


necesita mejor introducción.  Ejemplo _Es un componente del browser donde se apilan las llamadas a las funciones en el orden que se invocaron..._


That's a mistake. I will. Well seen.


mergeisdone


TeamCity pull requests :: netty [Build 541](https://garage.netty.io/teamcity/viewLog.html?buildId=2859&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 4704, ignored: 16 Build time: 00:12:46
### Failed tests
```
io.netty.handler.codec.http2.Http2FrameRoundtripTest.stressTest: <no details avaliable>

```


What exactly has changed?


poderiamos criar um metodo auxiliar para verificar se é um factor valido


Unit does not need to be defined, as it should be coming from the `stencil-variables` import above.


Just curious, is all this range-like stuff API-compatible to the range proposal?


> Yes, makes more sense to have BUILDDIR=build/port

Fixed.


- [ ] Add AKA.


Thanks for testing Beans.


gracias @josoroma, agregué algunas notas para corregir...
es buen punto de partida. Corrige esas cosas y actualiza el branch para que se actualize el pull request.
yo sé que es difícil, pero intentemos mantenerlo lo más fácil de entender y conciso posible. Para este tema utilizar https://www.youtube.com/watch?v=8aGhZQkoFbQ  como referencia.


Might want to add a weak wrapper for your timer objects in the future to ensure you don’t need to remind to setup these hoops every time. I used this in the past https://cocoapods.org/pods/TPDWeakProxy


Where was the cycle here?


It looks like the valid keys are defined here: https://github.com/rails/rails/blob/4-2-5/activerecord/lib/active_record/associations/builder/association.rb#L24

Removing it from that list removed it from the returned valid keys list. I'm not sure if that Constant is being used for something else though.


A few things about these variables:

* they should be set with `!default` so they can be overridden
* their name should begin with the name of the stencil component, i.e. `$prograss-bar__????`
* these probably belong with the configurable variables at the top of this file


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2658


saw approval from jonmeredith
at https://github.com/basho/yokozuna/commit/d95a2881948d26c7e451091e36098df36eff8116


merging basho/yokozuna/bugfix/zl/hashtree-cleanup-for-meta-counter+flush = d95a2881 into borshop-integration-578-bugfix/zl/hashtree-cleanup-for-meta-counter+flush


basho/yokozuna/bugfix/zl/hashtree-cleanup-for-meta-counter+flush = d95a2881 merged ok, testing candidate = 21e7115a


LGTM.


Please remove this extra whitespace and fix other styling issues.


I see below where files are conditionally required based on platform predicates. Can't this approach be used uniformly?


Incorrect indent!


think its better for this to be in the extractValue() method, and you return null right away if the field is nullable and the value is null.  The way it is now, i think you'll get an exception if there is a nullable array.


What I'm actually asking is, can't you define a version of the actual method in the files that are conditionally required? That's preferable, even with some logic duplication, than trying to "DRY" things up and using conditional contortions.


@sporto hey, just curious - I've been looking for a library like this which wraps immutable objects with a nice CRUD interface (.get, etc.) like you have here with Imm. Is there a reason why its discontinued? Is there a better option to use? Or should I go back to just using a normal Immutable.js/Seamless-immutable making use of something like lodash to do matching grabbing out ids?

any guidance/thoughts you have here would be awesome thanks!


We need to start commenting everything. All comments are good comments atm.


Why is this change in this pull request?


I think it may have been related to the addition of IN_TARGET_STATE, which ended up getting reverted in rust-selectors. This bitfield lives in rust-selectors now, and landed there as u16. I'll write a quick patch to make it u8 until it needs to grow.


A list of allowed values is probably better... hm.


**Code Quality - Nitpick**

There seems to be a duplication of the code block that loops and captures the search results.
This code block can be refactored so as handling the looping with a single loop code block, like so:

```
this.searchIndex = function(terms) {
    var that = this;
    // Initialise array to contain the results of the search.
    var searchRes = [],
      args = Array.isArray(terms) ? terms : arguments;

    for (var i = 0; i < args.length; i++) {
      if (args[i] in that.dataIndex === true) {
        searchRes.push(that.dataIndex[args[i]]);
      } else {
        searchRes.push(-1);
      }
    }
    return searchRes;
  };
```


Gah, accidentally pushed this into master, so no PR. :(  Sorry!


@igorid что будет если добавят новый пункт меню? копирайт не должен быть вместе с пунктами меню


hello there... can you see my Box2 ?????


trailing
nice typo


@matiwinnetou @EtienneBruines I used to get components like that example. Made me hate type assertions forever, I'd prefer to keep it the way it is.


@igorid так хедер или футер?


What is GOF?


I thought the convention was to put the tests for java parsing/typechecking in `tests/pos/java-interop/`, though that doesn't matter much.


Good idea!


add this after this  if at line 234
else{
	return 0;
}


@igorid именуй классы более понятно, нет смысла в приставке `ul`


Thank you for this, @robertzk


@matiwinnetou It can be accessed by other systems. There is no real need to make it public.


I believe @matiwinnetou meant https://en.wikipedia.org/wiki/State_pattern


The function belonged to an instance, so a reference to it (as a closure) held a reference to that instance.

Since the functions didn't refer to self, I took them outside the class.


@igorid вместо этого перепиши на `:hover`


Related to https://github.com/owncloud/core/pull/16832


@igorid этого не должно быть здесь


1) With this algorithm the lowest value out of `idle`, `max` and `actual` is selected for `clampedWidth` and `clampedHeight`. If `idle` or `max` is not passed through the constraints they default to `int32_MAX`. There is no up scaling of frames. The maximum delivered resolution is the actual screen size.

 2) To maintain the original aspect ratio we decide to scale portrait or landscape by comparing the two scaling factors defined through `clampedWidth` and `clampedHeight` in 1).


@filipmares Yes, they will be in beta4 shortly.


@EtienneBruines yes


Re: scribes wanted.


What is the sceanrio in which this happens?


**Code Quality - Nitpick**

You can use the `.toBeTruthy()` Jasmine comparator, which asserts that the test value is truthy.


Well that sounds good. I'll look into ufo3 support next and Sascha and I can discuss the possibility of building tables in feaLib without feature syntax. Thanks for bringing this up!


@igorid область ссылки не совпадает с визуальной областью кнопки меню


Good catch. It should be reverted.


The Method "protected void validateXml(String xml)"  parses xml, but does not turn on the secure parsing features like e.g.:

DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
dbf.setFeature("http://javax.xml.XMLConstants/feature/secure-processing", true);
dbf.setNamespaceAware(true);
dbf.setExpandEntityReferences(false);

This is something you may want to consider.

Additionally we ran into issues that some identity providers do not render the xml preamble in their metadata but start e.g. with:
<ns3:EntityDescriptor xmlns:ns3="urn:oasis:names:tc:SAML:2.0:metadata" xmlns="http://www.w3.org/2000/09/xmldsig#” xmlns:ns2

In this case the logic fails:

if (trimmedLocation.startsWith("<?xml")|| trimmedLocation.startsWith("<md:EntityDescriptor")||trimmedLocation.startsWith("<EntityDescriptor"))
 {

As the UAA now validates xml anyway, I think it would make sense to reverse the order and first check for http(s), and if it is not http, try parsing xml. If parsing xml fails, set the UNKNOWN flag.
From my experience with version 2.30, it is important  to have clean metadata in the system, otherwise startup may fail when the metadata stored in the DB can not be parsed.


Yes, better to put in java-interop.


Great work!


**Comments - Awesome**

Your comment are concise and consistently styled, good job.


esta me parece una mejor definición: "El ámbito de una variable (llamado "scope" en inglés) es la zona del programa en la que se define la variable. JavaScript define dos ámbitos para las variables: global y local."


@igorid какой смысл этой обертки?


Btw, what do you think about an Infobar somewhere around ...with real time resists(with respective colors), armor/eva...main skill damage...etc etc...?


@igorid что это? Макет не центрован


@brixen Come to think of it that's probably a better solution as it also would remove the need for extra namespaces (`RubySL::Socket::BSD`, `RubySL::Socket::Linux`, etc).


**Code Quality - Nitpick**

You should stick to one string formatting style, either single or double quotes. You used double quotes in  _src/inverted-index.js_.

I'll advise you stick to single quotes, as is recommended for javascript.


@igorid нет смысла задавать обтекание двум элементам, если их можно обернуть и задать родителю float right


I should add your favorite color


(You could still use a wrapper method here to do the "new TextureRegionDrawable(newTextureRegion(THING.get()))" part.)


And I can't spell. GG me


EconomizerIntegration (mbadams5) - i386-Windows-7-VisualStudio-12: OK (1961 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


normalizing over different "axis" parameters. Figure down: not normalized t-series of first 50 nodes of hcp subject 100307, middle: normalized axis=0, top: normalized axis=1


Right. I'm down.


To expand on what @apsun said:
1) One statement per line.
2) Be consistent in your bracing/spacing patterns.

I'd recommend setting up your IDE to preformat braces/spacing if it doesn't do that yet.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2659


**Code Quality - Nitpick**

Instead passing `singleword` into an array, this line on code can be replaced with code block from lines _54_ to _60_, this way, you only loop once (YOLO).


I see, thanks for explaining.


This is way too verbose. Either condense it, or use wrapper methods.


I'm not sure this is working as intended - in my test store, 'Disable initial shipping & tax estimates' is NOT checked, yet when I do not have a shipping module installed or when there is any error triggered in the shipping module, I am no longer seeing the alert-box.

If I dump the 'disable_estimates' value, I have only an empty string, which does not evaluate to true when comparing to '0'.

Perhaps changing the check to `|| empty($GLOBALS['config']->get('config', 'disable_estimates'))` would be better, unless you are expecting a non-empty value of some sort?

Apologies for all the activity, btw, and thanks for your hard work.


Ternary op.


all tests pass:
success: http://buildbot.bos1/builders/test-yokozuna/builds/1437


@igorid несмотря на то, что стандарт `html5` позволяет записывать значение атрибута без кавычек, лучше соблюдать единый стиль во всем документе. То есть, не вижу здесь профита, не ставить кавычки.


One statement per line.


Re testing: you can add a test hook -- a delegate called from the code, set from the unit test to open the file and cause sharing error


If CT_Abort is called before the work area is set up (e.g. because the CT_PREFIX_DIR contains non-allowed characters).


Hardcoded `t` and `due` should be read from the configuration.


Applied in 827b4e2a4acb18692a790f02ae3516fc92970955.


Seems that this one not work on Centos.
Only exports --tempdir .
Maybe we can make it in "" ?


Nooooo :-)


Examples:
`actual is 2560x1600
no constraints passed in
delivered is 2560x1600`

`actual is 2560x1600
constraints passed in are
width: {
          min: '500',
          max: '600'
}
height: {
          min: '500',
          max: '600'
}
delivered is 600x337`

`actual is 2560x1600
constraints passed in are
width: '800'
height: '1000'
delivered is 800x450`


No worries, glad I could help! To answer some follow-up questions:

Signals are implemented as part of Unix kernels as opposed to panics which are purely a Rust construct (e.g. a C++ exception), which means that the signal takes a higher priority. If you want to test this out, you can call `signal(SIGPIPE, SIG_DFL)` when a Rust program starts as that'll reset `SIGPIPE` handling back to the default, and your program will auto-die when it writes to a broken stdout.

The reason that this often doesn't come up in other languages is typically because stdout is heavily buffered when placing output into a pipe. When attached to a terminal (e.g. you're just running a program) stdout is typically line buffered, but when on a pipe it's somewhere around 4k buffered. The consequence of this is that if you're piping output into a program like `head`, it will basically receive all output at once, immediately closing the pipes, sweeping the underlying panic/exception later on under the hood.

Let me know if you have any other questions, though, more than happy to help!


busca o usario no banco e mostra na tela alterUser


This broke the fix you did in https://github.com/srod/node-minify/commit/5fdad442cc25c57488bfa23770e85c9bcc0096da
to Fix windows bin path #69


EconomizerIntegration (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (887 of 887 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.57%25-green.svg)


ámbito, no ambiente


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (1914 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.55%25-yellow.svg)


> les templates jinja n'ont pas grand chose à faire au milieu du code python

Si c'est ça, il faut déplacer `/patacrep/data` à la racine du projet. Actuellement (dans master), le projet ressemble à ça :

~~~
patacrep
├── LICENSE
├── NEWS.md
├── patacrep
│   ├── authors.py
│   ├── build.py
│   ├── content
│   │   └── ...
│   ├── data
│   │   └── ... LES TEMPLATES JINJA, LES PAQUETS LATEX, LES IMAGES ICI
│   ├── encoding.py
│   ├── errors.py
│   ├── files.py
│   ├── index.py
│   ├── __init__.py
│   ├── latex
│   │   └── ...
│   ├── songbook
│   │   └── ...
│   ├── songs
│   │   └── ...
│   ├── templates.py
│   └── utils.py
├── examples
│   └── ...
└── ...
~~~

Les templates, ainsi que les paquets latex (.sty) et quelques images sont *déjà* mélangées au code python. Si on veut que ça ne soit pas le cas, il faut les déplacer à la racine, mais d'une part, ils ne sont plus installés automatiquement par `setuptools` (et il faut gérer à la main comment les installer suivant l'OS), et d'autre part, ça sera de moins en moins bien rangé à mesure qu'on ajoutera des données (voir point suivant).

Je trouve qu'on mettant tout dans `patacrep/data`, c'est le désordre. Pour le moment, dans cette pull-request, on a `ast_templates img latex templates`. Maintenant, imaginons que la génération du code latex pour les fichiers latex (dans [`patacrep/content/song.py`](https://github.com/patacrep/patacrep/blob/d27a7f3c67e2b4813ca7eacb8ecbc19de4d723dc/patacrep/content/song.py#L25-L34) par exemple) soit plus compliquée et qu'on utilise des templates jinja. On ajoutera alors un sous dossier `content_song_templates`. Puis si on a besoin d'autres fichiers (par exemple inclure des images dans le rendu HTML), on va encore ajouter un dossier `ast_html_img`, et ainsi de suite. Au final, on aura dans `data` les dossiers `ast_templates img latex templates ast_html_img content_song_templates`.

Je suis d'accord que le mélange données et code n'est pas des plus élégants, mais je pense que c'est un bon compromis ici de répartir les données dans des `data` dans les différents packages : c'est à la fois simple d'utilisation grâce à `setuptools`, c'est tout de même contenu (si on garde la convention que seuls les dossiers `data` contienent des données), et c'est trié par sous-module (même si on ne sépare jamais de paquet) : un sous-module contient à la fois les sources python et les ressources nécessaires pour fonctionner, de manière (presque) autonome.

D'autant qu'actuellement, dans master, `patacrep/data` est un datadir (au sens songbook), alors qu'avec la version de cette pull-request, c'est un datadir, dans lequel on a aussi ajouté d'autres choses qui n'ont pas forcément leur place dans ce datadir.

Désolé pour le roman :smile:


Can we use this API and still have it self compile? I think I struggled with things like Environment.GetCurrentDirectory()/etc.