use checkType?


Cyclomatic complexity:
Bad code smell.


Would it be better to pass in the ibv send flags directly, rather than passing in boolean values (inject/comp) and setting the flags off those?


Sorry, seems like the fieldsets is not required after all if the order is correct.


Should display the names/uuids or display to them an ID when running the ban command and display the ID here. We should also make a new custom Logger and log all bans / pardons into it.


We should probably have the certs expire independently from the CA expiration.


Same as AsyncBan


It's my first commit in a long time, hopefully I can start contributing more in the future :)


Same as above (should expire independent of CA expiration)


this looks correct to me, but have Martin or Eric look at this method


Yup, looks like nobody is using it. Will remove it.


You might want to check your system time. The author date is 10 Oct 2015.


static import


I'd rather see you re-throw the exception if it happens here.  Right now, you're catching it and "eating" it... even though it prints out, the program continues to run because it's not rethrown.  To re-throw it after you've printed the message, just add a line: throw e;


Awesome job nesting and structuring your html elements!


Container class! Nice! :+1:


If we start validating master-->kubelet comms, we might have to update this usage to be serverAuth too.


add a test for a non-metadata-only-delete to make sure it fails with a reasonable error message


Ugh, PowerGUI... :-1: 66212b3b5d0deacf567d5bc079a46275d0617ccb


This is definitely advanced! Good just using margin auto to center your elements on the page. :+1:


Also here, you should probably throw some kind of exception.  If you don't want the method to say "throws SQLException" you could wrap it in a RuntimeException, which will still stop program flow but won't have to be manually handled.  To do that:  throw new RuntimeException(e);


it looks like the operator only outputs a single channel, so this should be a single `Symbol` instead of a `List`


Kudos for caching this.


lolz


Current interface does not support updating values in the independent column.


Unnecessary comments which increases length of code.


I can't remember off-hand if org.apache.commons.lang.StringUtils is included in Spigot, but isBlank would be great here.


spaces please :)


I decided I didn't want to do this... I figured it's actually better/simpler to do linear_solver->set_solver_configuration directly, rather than attach the configurations to RBConstruction and let RBConstruction set the configurations.


LAMP LIKES GAME


Maybe add a Ban.samePluginName() or some such so callers don't need to worry about toLowerCase() and equals(). Also String.equalsIgnoreCase() is a thing.


Hey,

I'm wondering if this commit is responsible for the following regression. Add this to ShadowAsyncTaskTest and it now fails.

Could you take a quick look Jeremy?

@Test
public void executesOnBackground() throws Exception{
  Robolectric.getBackgroundThreadScheduler().unPause();
  new AsyncTask<Void, Void, Void>() {
    @Override
    protected Void doInBackground(Void... voids) {
      assertThat(RuntimeEnvironment.isMainThread()).as("isMainThread").isFalse();
      assertThat(Looper.myLooper()).as("myLooper").isNotSameAs(Looper.getMainLooper());
      return null;
    }
  }.execute().get();


Since you have a unordered list here but no list items, the ul element has no meaning here. I would suggest adding a list item around each each anchor.


Hi Sam,
It would great if you could provide a 'how to install from latest source code' guide of your application in your installation documentation. This way I could help you test out latest commit as well.


1) Will factor, and will use setProjectEndpoint() to set host if not the default host or local host
2) Since we will still support setting the host (via project endpoint), I'll keep the defaultHost methods as is (correct me if this doesn't make sense)
3) I think I'm covered here, because I'm only adding the schema `http://` to create a valid URL (so I can check if it's the localhost).  Let me know if indeed I should be changing something regarding http/https
4) Will do


With these patches, it might be nicer to have something like

```diff
diff --git a/awesomerc.lua b/awesomerc.lua
index 6a28cf1..9067fae 100755
--- a/awesomerc.lua
+++ b/awesomerc.lua
@@ -249,7 +249,7 @@ globalkeys = awful.util.table.join(
         end),

     -- Standard program
-    awful.key({ modkey,           }, "Return", function () awful.util.spawn(terminal) end),
+    awful.key({ modkey,           }, "Return", function () awful.spawn(terminal) end),
     awful.key({ modkey, "Control" }, "r", awesome.restart),
     awful.key({ modkey, "Shift"   }, "q", awesome.quit),

```


See #17


Awesome job! Looks like you really have the hang of this!

#FEWD Week #1 Project: HTML/CSS Basics

---

###Description

For the first assignment, you will begin creating the beginnings of your first website. Take what you've learned from class and build a portfolio site that showcases all of the projects you'll be completing over the next few weeks. Build two pages - an 'About Page' and a 'Portfolio' - that link to one another. Your 'About Page' should describe your mission and value proposition and your 'Portfolio' should include descriptions of the work you [will] do for Relaxr, Startup Matchmaker, and CitiPix.

Student: Nathan Keeys

| Technical Requirements                                                                                | Does Not Meet Expectations (0) | Meets Expectations (1) | Exceeds Expectations (2) |
|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|--------------------------------|------------------------|--------------------------|
| Link both pages together using `a` tag                                                                                |                                |                        |              x            |
| Use a unique `title` and a single unique `h1` tag                                                                                |                                |                       |           x               |
| Show images using `img` tags including unique `alt` attributes                                                                                |                                |                        |               x           |
| Use an external CSS stylesheet to style your pages                                                                                |                                |                        |               x          |
| Select at least 5 elements on the page and apply at least 5 different css properties (`font-size`, `color`, `font-family`, `background`, `text-decoration`) to these elements |                                |                        |                          x |
| Use at least 6 different HTML tags (`h1`, `h2`, `h3`, `h4`, `h5`, `h6`, `p`, `ul`, `ol`, `a`, `img`) on your pages                                                            |                                |                        |            x              |
| Follow naming conventions, maintain consistency across your .html and .css files                                                                                |                                |                        |          x                |
| Indent nested elements to increase your code's readability                                                                                |                               |                        |             x             |
| TOTAL: 16/16                                                                                |                                |                        |                          |


I think this achieves the same result, but doesn't feel like the right fix. Is there someplace earlier that is failing to close the local stream? When the local side is done sending the request, it should close locally; you shouldn't be able to receive a headers frame without the local side being closed. I could certainly be mistaken though.


If expiry is immutable, maybe cache the result and just feed it back? I don't know how often this would be called.


wrong kind of quotes :)


So I tried to go back and figure out what I did. I think the sequence I followed was "get started", scroll to "build your pure starter kit", "download your starter kit", and click download. The index file, which is shown on the page under "here's what is in the downloaded zip file contains" is the file I used. I just copy and pasted my code where it says "your xxx goes here." I hope this helps.


Why wouldn't compareTo factor in hours and minutes?


You could detect the case for 3.5 and patch the underlying subpatterns method, but then you're perpetually stuck with trying to keep this code in sync with the python codebase.


TeamCity pull requests :: netty [Build 345](https://garage.netty.io/teamcity/viewLog.html?buildId=1906&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 5616, ignored: 21; resource leak detected (new) Build time: 00:37:24


first update


Yes it does. Result of fixing things in a hurry.
On Sep 30, 2015 7:28 PM, "Hannes Janetzek" <notifications@github.com> wrote:

> should the #ifdef not also check for the GL_ prefixed name?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tangrams/tangram-es/commit/1ea7a47f46b5d3990e6e5027aa5bcb62709e2875#commitcomment-13530898>
> .
>


Debug spew?


So it happens that my test string does not have `{}` but only `#{}`, so that's why it succeeded. But also found some other bug after my unit test.


This and a few other parts of this file's diff are deleting tests, are these bits already tested elsewhere?


Looks great! Ship it!


Mistakenly committed two and caused conflicts


width should be 0


are you ok sharing your access_token like that?


TeamCity pull requests :: netty [Build 346](https://garage.netty.io/teamcity/viewLog.html?buildId=1908&buildTypeId=pulls_netty&guest=1) is now running


Is there a way to test that the panic is useful? In RSpec I would do:

```
expect { Size.new(0, 0) }.to raise_error(/must not be zero/)
```

Not sure there is an equivalent in rust.


Indeed @maaku this code is a bit weird.  Over the wire, timeouts are an amount explicitly seconds or blocks; the internal conversion to locktime is a weird remanent which assumed some relative-CLTV model.  Will fix (opened PR #6).


don't think so - it's enforced by the type system well enough.


This works for me.

If we could also adjust this via a MINC2 API call that would be handy so
that in the future we can control this from tools such as mincaverage and
mincmath/calc that have a habit of using large numbers of input files.

a

On 30 September 2015 at 13:32, Vladimir S. FONOV <notifications@github.com>
wrote:

> Maybe it would be easier to have an environment variable like
> MINC2_FILE_CACHE - where one could simply specify this parameter, and then
> it will be up to the user to set it to small value (or even 0) when they
> are writing a script that is going to process lots of files in parallel?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BIC-MNI/libminc/commit/08c0124648ad1411c8cbba6ab52862db86a770a5#commitcomment-13508311>
> .
>


width not 0


Have you had anyone actually complaining these weren't available on a remote node?

Esp. Dummy and Stateful which do nothing, as well as controld and o2cb which are for cluster filesystems which cannot function on a node without corosync.  I wouldn't expect ClusterMon to be useful there either.


this implicitly executes `test_zero_size()` right? So this doesn't demonstrate anything extra because it will panic on the Size creation.


This broke the program on FreeBSD again :'(
Here is a cleaner version of my patch (if you're interested) http://pastebin.com/x9nd6xx7


```
let default_settings = WindowSettings { .... all the defaults }
let heigh_zero_window = WindowSettings { size: heigh_zero, ..default_settings }
```

That way you a) don't have to repeat the duplicated settings, and b) make it clear what the test actually cares about and what it doesn't.


给你跪了。。。


Perhaps we should use a copy of nuget.exe other than the one in the root. When somebody updates the one in root they might not know it actually affects the product.


You probably didn't mean to make these changes to the #!


... does this actually worK? I wouldn't expect just creating a struct to execute any of our code per https://aturon.github.io/ownership/constructors.html


Paging @DrTall. This addresses a decent amount of the feedback you gave. I'm still working on it though, but the tests pass again. (Although I say that and realize I didn't run them in race mode...)


Start8point5 (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1360 of 1360 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.36%25-green.svg)


@cmb This should technically be && to reverse the previous logic "if (!a || !b)" to "if (a && b)"


This should verify that the chosen_client's execute method gets called instead. The unit test should be agnostic to the existence of _send_command. The comment applies to the four cases below too.


This is a great point. The `requests` docs state the following:

```
The Session object allows you to persist certain parameters across requests. It also persists cookies across all requests made from the Session instance, and will use urllib3‘s connection pooling. So if you’re making several requests to the same host, the underlying TCP connection will be reused, which can result in a significant performance increase
```

Not sure we'll be getting the benefits of re-using the underlying TCP connection.

Now, this is fairly trivial to solve. It is the `Client` which is aware of the configuration it's received, and each `APIRequestor` instance has a reference to the parent `Client`, so we could either initiate that `requests.Session` within the Client, or do it in `APIRequestor`, and bind it in the client (I prefer the former, and having it flow down)

Of course, happy to hear other thoughts.


Would you prefer to have a global variable for that, or specify it per file ?


Good point let me check.


Ouch. Thanks for catching. Having a bad day, sorry.


Something I missed earlier, so this is my bad;

When you are outputting a link title with the `title` attribute of a link, please use `the_title_attribute()`


Whoa


Try a better opener


Could you actually add a check for the correct zlib library? I've been bitten by it before.
See #388


The red is a little bright.

Could you find a more soothing shade of red?


no class and even no comments .Difficult to understand


Actually you are right. To give more context this is a push stream and by default localSide is closed. I missed that in the code. I will revert the check for isClosedRemotely to isClosed and it should just work.


Solid clean ups


Didn't realise that per file was possible but it makes a lot of sense.

Per file would make the most sense for the API, but the ENV would set a
global default?

a

On 1 October 2015 at 10:50, Vladimir S. FONOV <notifications@github.com>
wrote:

> Would you prefer to have a global variable for that, or specify it per
> file ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BIC-MNI/libminc/commit/08c0124648ad1411c8cbba6ab52862db86a770a5#commitcomment-13531664>
> .
>


s/tzseup/tzsetup/


I noticed in previous commits functions were renamed from add_urls to addUrls, etc... Hence why sanitizeUrl was named this way?


writing a random function is better than using hardcode ince fixed number of coins identified


perhaps mark with `@deprecated`?


Well damn. You quote TAoCP... anything I say will be wrong. :)


What's with all the &references? are they needed? It makes it a bit on the ugly side.


oudfousdfhsdouhfssdhou


You don't have to help if you don't want to... I don't like mentioning it because it makes me sound like an attention whore.


Using function  is better that hardcoding


sounds good, could you create a PR with the suggestion, thanks


Could you add a doc comment explaining what kind of value goes in this field? Given we have so many different types of paths and urls, it's getting confusing.


Add charset


Bug:Donkey is not falling to down level as you move in next to edge


This message should be different: Something like `Inlining of views is only needed for tests that manipulate component metadata. Use the transformer xyz for this`.


esta ok


ok


Hi, in the stemcell test, did V-38682 and V-38691 tested which is in the list of file  bosh-stemcell/spec/stemcells/stig_spec.rb ?  It looks like the two test cases didn't work and they are missing in the final stig_test_cases. Just would like to make sure. Thanks!


wondering if we'll actually need a library name for stylesheets


Thanks for the pointer Andrew! I thought I fixed this, but apparently
didn't do so completely. I'll push a fix shortly.

Maybe I should really add the trigger code that assures the availability
of such classes and relations after project updates and creation. This
could help avoiding such problems, because it all happens without
Django.


But we still need to store information about `@Injectable`s in the reflector. Do we do this somewhere else? I.e. the new compiler does not do this...


I use the StorageClientConfig to create an ES client with all the needed env settings.


Start8point5 (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1896 of 1896 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I already answer you. There is nothing for me uneasy about.
This is my repo dude. What kind of question is this, back it up by
The whole gangs. Anyway test branch deleted.


why not use like string.format and %s


Are we using this for the angular2 tests? We should. Could you then also create an integration unit test that loads a file via a `templateUrl` in the `@View` annotation to make sure this actually works? I think right now all tests use components with inline templates...


fucK OFF
On Sep 30, 2015 6:08 PM, "Zerf" <notifications@github.com> wrote:

> why not use like string.format and %s
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DaaOtt/maestro/commit/698264f7cc839a52f6bedae28b0517dc31cd873f#commitcomment-13531839>
> .
>


nice


¯\\\_(ツ)\_/¯

It does get pretty annoying having to Allow all the time.


It has appeared!


I've rebased to use chainActive.Tip().


wouldn't this make too much sound?  iirc, this was how fire does it in the past.
maybe you should look at how fire sound is done now.


Don't declare these yourself, these are in `intrin.h`, which should already be included.


Chris: https://docs.silverstripe.org/en/3.1/getting_started/coding_conventions/#methods


How to specifically check for it? (Patches welcome, btw!)


What error was this giving you? This works fine for me.


Didn't you mean  if (wires != null) in line 67?


Thank you
我们是不会忘记你们对互联网所做的贡献的


Yes, it makes the js run correctly in some cases. The `rwmb-clone` is too general.


@tinito I think we'd all want the TILTMAX_TAKEOFF to be zero for a vertical takeoff? Or am I missing something here?


I prefer explicitly showing the length over hoping it won't overflow


The difference is between static functions and non-static functions


MSVC doesn't support the thousands separator modifier.


shit


What happens if we overshoot the altitude setpoint?


TeamCity pull requests :: netty [Build 346](https://garage.netty.io/teamcity/viewLog.html?buildId=1908&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5616, ignored: 21 Build time: 00:37:49


Why is this needed?


Because they are only implemented by-reference. Should we do by-val as well? For big matrices this could be and issue.


Leave a comment~/.gitconfig/- - global


Actually my patch is wrong. I just realized it's crashing in some cases, probably because the pointer returned by toStdString.c_str() is being freed. This one is working fine -> http://pastebin.com/EjBfv2bp


Well, I can't just do a comparison, as it isn't a fork of the main Folly repo, but one thing I can see that you did is try to build without pthreads. [GerHobbelt/pthread-win32](https://github.com/GerHobbelt/pthread-win32) is the PThread implementation I use.

Also, you added a `unistd.h` header. That's not needed, as `FilePortability.h` replaces `unistd.h` and a few other headers. The same goes for the `CPortability.h` and `SocketPortability.h` headers.

Any particular reason you've disabled the winsock include in `WindowsPortability.h`? `timespec` is defined in there.


i think what you want is minetest.setting_get instead of minetest.setting_getbool.

because that would only return true or false which both would become nil after tonumber.


See the code linked in the issue I linked.
I matched on the `_VERSION` field (both modules have it): https://github.com/daurnimator/lua-http/blob/master/http/zlib.lua#L10


You might consider adding some comments to make the code a little easier for someone else to understand.


I would think the default should probably be just hint, not full test.  Test is fast enough it's not really an issue, though.


Should this be props.kind = props.kind || ctor?


@SuperstarGamer This basically generates a new world and ignores whatever is in the "db" folder.


why not use pos?


isn't pos == pointed_thing.under?  and isn't node == n?
why not just use node?


`contentEditable` has a corresponding property so it's covered in the check at line 47.


This if-statement takes a few reads to understand.  Might be able to simplify this:
```
function cloudflare_ip_address_in_range($checkip, $range) {
   if (empty(range)) {
```


node can be use here too


Thanks! BitHub has sent payment of  $33.88USD for this commit.


finding water nearby is kind of meh,

it might be better to spawn an `entity tnt` which allow water and such to flow into it
that way, it would just need to check if the vector.round(pos) node is a water node.


@staltz the symbol ! is almost identical to | depending on the font and editor theme. Could we use another symbol? I know that this commit is on master, but it will be nice to improve readability.


Does Factor error include the strerror description?


This kinda seems to be a duplicate of Resolve(), which tries to resolve modules from a given root


Good entry Ricecoder :+1:


If El Shaddoll Winda is special summoned after Minerva, the Exalted Lightsworn and let El Shaddoll Winda battle destroy Minerva, El Shaddoll Winda can be destroyed by the ② effect of Minerva.


@DespairFactor
Open it and find "CONFIG_MULTI_CPU_POLICY_LIMIT"
https://github.com/dorimanx/DORIMANX_LG_STOCK_LP_KERNEL/blob/master/drivers/cpufreq/cpufreq.c


The game has no option to restart itself.


great job! 16/16 (points...great job going forward)


We should be using an enumerator with defined destination types. If these aren't well known, why not have the transport figure out the destination type?


Mistake in commit message: reverted 53ad90d instead of b00e5f9.


Is this recursive call necessary?  Could this be done iteratively?


Yessss...


fast-forwarding end-to-end/timeseries to borshop-integration-1200-bugfix/jrd/ts-2i-limits = 9775cb14


DFS, BFS


player not falling from edge "


LOL i'm pretty sure your account is definitely blocked by instagram by now :)


take a look at willBeginBatchFetchWithContext


To many for loops ,game takes time to load


@MajikalPayton What? I help people... You're overthinking, no one here thinks your a whore. :wink:


Not quite sure how this happened. Sorry.


Fine by me - as long as SO_KEEPALIVE is off by default.  I think it's a blunt instrument, but it's easier than coding good idle connection handling.


fromNullable(value)


fixed, thanks!


   Date: Wed, 30 Sep 2015 09:29:07 -0700
   From: F Saad <notifications@github.com>

   Think we should hear @riastradh-probcomp reasoning for this commit.

The three-second overhead of `import seaborn' just to get at
bdbcontrib.__version__ was getting in my way, and I was in a hurry to
get bayesdb-demo working for 0.1, so I didn't want to think about
think about semantic changes.

Please feel free to make the semantic changes and fix any fallout from
them -- you know better than I what the fallout is likely to be.


Closes #71


variables not declared in global


issue5221_memoryAllocation (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1896 of 1896 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


time module not used


Close #71


The value is already null if we get here, so no need to assign null


I think we can replace this function with http://api.symfony.com/2.3/Symfony/Component/HttpFoundation/IpUtils.html


@mart1ver : J'ai fait un commit pas très élégant pour mettre en ligne ce que j'ai en local.
Ça semble marcher.
C'est pas si gros si on enlève les détails esthétiques. ;p

J'aimerais bien trouver un logiciel qui gère l’indentation correctement des fichiers avec de l'html du php et du js. Mais j'ignore si cela existe.

En tout cas ça fonctionne sur Firefox a ce stade.


h1 class


promo-block


this.zkPath is the ZK container ID which is also the path for the running cluster instance.
MESOS_MASTER is totally redundant.
MESOS_ZK was set correctly in the line that you changed.
https://github.com/ContainerSolutions/mini-mesos/blob/master/src/main/java/com/containersol/minimesos/MesosCluster.java#L64


I found some that reading from `information_schema` tables may trigger scanning whole database and collect statistics. I can tune the query to avoid that but I need access to a large MySQL database to test the results.


h2 review__title


Why do that? We already know if it debug crt alloc. If there is no test, then you please add a test for it.


form-row


Not supported on chrome/safari versions


Please provide a more complete commit headline.

you may remove the "Change-Id".


I would suggest (for now) to simply rely on `vagrant` and `www-data` to be in the same group.

Otherwise, since the problem is indeed team productivity (and can be worked around) then you should ask your co-workers (you are having the issue there, right now) and see which one is the *most secure* solution.

Another thing that must be clear before proceeding is whether these warnings are currently blocking your work or if they are just noise.


why use \r? why not just position text box right in the center of the image


input type="file"


> and document the finer points of it elsewhere.

ok by me


This patch is wrong. You are working with pointers so you are not copying data but just the pointer and then you are freeing data that have to be returned. This means the methods are returning pointers to already freed memory areas, which is wrong. Moreover in both cases, there is no possibility to have a memory leak because of the scope of the variables (local).


gallery-item


You should use 4 spaces for indentation


ahahaha I see the "ok" as a wrong answer bothered you too... I kept forgetting to fix that one.


commit message: remove useless footer and add your S-o-b


reason - удалить


@mieliep The name of the classes here should be `.contact__img` and `.contact__map`. The double underscore indicates that the class is an element of `contact`, whereas the double dash indicates the class is a modifier of `contact`. These are both elements inside the container.


Found one.


reason reason--image reason--image-home


reason


for posterity, discussion conclusion was: neither date nor revision can be `null`


Ah ok great, I see it's just in the main.js now


is the text supposed to be editable? if you just need to display text, use a UILabel. Labels do a lot of magical formatting that allow the text to be centered.


reason-row--gray


> There is also the thing about shared members of native classes needing to be declared native

Indeed, I understand the usefulness of allowing that, I'm just not sure I'll be able to do that before 1.2, it might be harder than it looks (it would be the first place where we would make a distinction between members looked up in the header or in the implementation)


reason-area - удалить


I've built a similar package using jessie:backports which appears to work fine:

https://github.com/miles-no/aspnet-docker/blob/master/Dockerfile


it is late i will try to firgue out ignoreCase , it is hard to play this game when it is case sensitive lol.


just an idea (googled python so thx for the refresher heh) ;-)


Actually, not all debug crt allocations are reported as debug.

I have included a test in the last commit ``vld_main`` where startup crt allocations which are false postitives are not recorded as debug crt allocations in order to be ignored (in debug mode), and are reported as real leaks.


date check-in__date__input -> check-in__input


ok, good move


Added proper control: if processEvent fails for *any* of the events in the batch, then the shard will not be checkpointed, causing the whole batch to be reprocessed. With this in mind, we must remember that the guarantee for any event is to be delivered at least once.


a uint32_t or a std::string are no pointers so, they are collected. But skill is a pointer.


can you explain why/when this happens? seems odd that it would try to redirect an empty url, which would be a path "/" that is stripped from slashes?


haha anytime! amazing what you can find on google.


Добавить обертку post__content


Post__content закрывается


без классов


без класса


* In the context of using the Symfony, the warnings will lead to "exception pages"; that is, they are show-stoppers.
* Yes, *I can* work around this on my side.
* Others are reporting the same problem, for example in doctrine/common#381.

I have seen many other places (for example in Symfony) where they are just silencing the `chmod`. Maybe this is good for DX, maybe it's bad for security. I think you guys need to make a decision :).


It should be removed. I left it as a comment to discuss  further.
I found that in the DynamicLoader/Thread it causes to report less leaks than expected ie. 64*11=704


Shouldn't these become POD?


Yes, that's something we already said. Actually, we could also strike only when the warmup ends. But that may be complex because the target may not be in range anymore or may be dead when the warmup ends. IMHO, we should keep it simple like that.


The behavior was that we added a `redirectUri` to a page, then removed it again and the `relativeUrl` then matched the empty value. So going to the homepage resulted in random behavior.


totally! 8-)


I don't understand that last comment...


I'm not suggesting we do any more work on this for 1.2.


no


The point is that if it's bad for security (or leads to wrong chmodded files) then this is a no-go. DX has nothing to do with this sort of problem


that's much better indeed


With this PR, creatures do not have mPhyAtk or mMagAtk anymore. However, if we feel that computing it is too much (which is not very probable IMHO - we do some much CPU consuming stuff every turn), we can improve that.


@mieliep `position:relative` not necessary here.


Why wrong indent in history?


Why you need this feature?


In pseudocode:
`vhost = getLocation`
Maybe it needs a better naming.


Please ignore commit 5b85a322ae593a11f3911f9e42f2ee2e6594e841 which was using minSpareRows instead of new dragDownCreateRow. I realized I shouldn't be using existing setting that might have a different purpose.


@mieliep It might be a good idea to give the image a padding of say `1em`, to avoid the logo image from touching the edges?


I won't hold up the merge, but generally we prefer just 'from s3' not 'froms3.s3filter'
NB Pls don't send another PR just forb that fix...avoid churn so roll that in with the rest of something more meaningful


Agreed, the file had mixed tabs/spaces to begin with so i gambled :)
There are other source and header files with mixed tabs/spaces.
I would suggest to make a separate commit to convert all files to 4 spaces format for consistency and not mess up the review of actual changes.


Did you commit this intentionally?


s/Array.from/`Array.from`


What about changing the umask to make sure "others" don't have write permissions *before* creating the file and then changing it back again?


La signature de la méthode prepareUserCas20 a changé, je pense que ça ne doit pas compiler là.

```java
protected abstract void prepareUserCas20(User user, String userId, String service, JsonObject data, Document doc, List<Element> additionnalAttributes);
```

Essaye avec la branche dev à jour.


As this is an inline comment in the source, I don't think escaping with `foo` would cause it to be sufficiently syntax highlighted. Or..is there something in the setup that does that I'm unaware of? :)


Make an issue about it, not commenting the commit itself


OCD alert. Misaligned keys. `cache_key_includes_query` has one less space.


kk


Fixed in #9810


Very Good


I just wanted to say, that with the | operator it's the same as

    else if (resized && !(m_format & FORMAT_NOWRAP))

because the things after that are always true. But I think the other conditions weren't there for nothing.
There are other places in code where

    if (m_format & FORMAT_WORDBREAK || m_format & FORMAT_LINEWRAP)

appears, so it is another clue.


If you agree with the changes made for this area for identifying crt allocations in release mode, and consider them sufficient and appropriate then the option in ``vld.ini`` is not required.
I just thought it adds more flexibility to revert to the current code.


The message codes you are removing were more in line with the exception names than the ones you are introducing.


Good to know. I found a way to make it work already for this one though.


This check is unnecessary. It wil be executed double if `!is_callable($toResolve) && is_string($toResolve)` is true.


Yes, if it is not very radical changes.


We should also consider disabling the `innodb_stats_on_metadata` option when accessing information_schema but I don't have time to benchmark it right now.


Szia! ez mit jelent?


Reverted back :yum: Can't see any battery life improvements..


You right


后出场的神影依·米德拉什战斗破坏光道圣女，米德拉什会被光道圣女的②效果破坏
1f1bc353fed32c810170cfff0de63278d7cec4ca 这里应该修复了


I suggest moving the `Println`s below the `runtime.Breakpoint` to avoid actually printing


Am I right under the assumption that this checks if the control button is pressed? I am surprised that this isn't already implemented in rgtk.


@KindDragon: Review when I have more time


Thanks for the feedback, Florian. So I guess we'll at least have to target this at GCC specifically then?


sdf


xcv


Gute Idee


Will there be syncing of the entire library via Dropbox?


werkzeug is not used


for what functions you write these last 4 code and for wht you use udp & tdp plzzz explain me


 >  before creating the file

O_o


Development! one p :)


yep. that was a test


Nope, only the errno value. But you can always reconstruct the original error message from that. Maybe `io-error.` in `debugger` could be fixed to `strerror` `errno`?


Yeah, I'm slowly changing old indentation to 4 spaces.


@JoergFechner the fix has been merged, can you verify it?


Better to extract this into a method which extracts the headers. Something like

```ruby
def headers(discoverer)
  discoverer.user._get.headers
rescue ExceptionName => ex
  puts "Log the exception
end
```

Important, do not silence the exceptions, at least log something when they happen. Second important thing, when possible, try to rescue specific exceptions so that you don't catch things which would better if they'd scale up .


dito like in the headers


> I would suggest to make a separate commit to convert all files to 4 spaces format for consistency and not mess up the review of actual changes.

For now, just revert your space changes and later squash new commit with this.


You're changing the return type of the method, now it is not returning the app_resource but what `puts` returns.


Sure https://github.com/YunoHost/doc/commit/283f073896ea719ff13095ab26c5f8ced678657f :smile:


What happens if no exception happens?


I don't understand why an exception should occur here, [ImageDirectoryEntryToDataEx](https://msdn.microsoft.com/en-us/library/windows/desktop/ms680149(v=vs.85).aspx)
```
Return value

If the function succeeds, the return value is a pointer to the data for the directory entry.
If the function fails, the return value is NULL. To retrieve extended error information, call GetLastError.
All DbgHelp functions, such as this one, are single threaded. Therefore, calls from more than one thread to this function will likely result in unexpected behavior or memory corruption. To avoid this, you must synchronize all concurrent calls from more than one thread to this function.
```

There is no mention of exceptions being raised.


using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Diagnostics;

namespace beep
{
    class Program
    {
        static void Main(string[] args)
        {
            string sb = Console.ReadLine();
            string reverced = Reverce(sb);
            Console.WriteLine(reverced);
            string capitals = ExtractCapitals(sb);
            Console.WriteLine(capitals);
            string regulars = ExtractRehularLetters(sb);
            Console.WriteLine(regulars);
        }
        static string Reverce(string sb)
        {
            StringBuilder strB = new StringBuilder();
            for (int i = sb.Length - 1; i >= 0 ; i--)
            {
                strB.Append(sb[i]);
            }
            return strB.ToString();
        }
        static string ExtractCapitals(string sb)
        {
            StringBuilder capitals = new StringBuilder();
            for (int i = 0; i < sb.Length; i++)
            {
                char ch = sb[i];
                if (char.IsUpper(ch))
                {
                    capitals.Append(ch);
                }
            }
            return capitals.ToString();
        }
        static string ExtractRehularLetters(string sb)
        {
            StringBuilder regularL = new StringBuilder();
            for (int i = 0; i < sb.Length; i++)
            {
                char ch = sb[i];
                if (char.IsLower(ch))
                {
                    regularL.Append(ch);
                }
            }
            return regularL.ToString();
        }
    }
}


But if there is no real chance that this is jsp, it will take time


Dùng canvas thường là nhanh nhất, rồi đến pixi_canvas rồi đến pixi_webgl


「中村注文部分のみtableタグを適用して目立たせた」ってコミットログ、いいなぁ。


@tmmorin - feel free to change the code.


where's e3 declared?


Why would you test if processInfo responds to `processorCount`? It’s available since OS X 10.5, iOS 2.0, watchOS 2.0 and tvOS 9.0.


Did you forget to change the corresponding verifies text above?


how is this even possible


I intend to have a cache in IP to re-use the object and reduce memory (as next hop are very often used more than once).


Need to add CSS comments back in?


Assignment Branch Condition size for notify_slack_on_update is too high. [32.16/15]
Method has too many lines. [15/10]
Perceived complexity for notify_slack_on_update is too high. [8/7]


Line is too long. [104/100]


Line is too long. [115/100]


Line is too long. [109/100]


Line is too long. [111/100]


Do not use should when describing your tests.


In the meantime time however > In the meantime however


Это проверка комментария


Can we get an enum for the return code here?


This fixes https://github.com/OpenDataServices/cove/issues/98


* Исправлены недочеты прошлого коммита.
* Заменил везде SelectedOrder на ClickedOrder. Так, кажется, понятнее, что за заказ имеется ввиду.


Это начало моего проекта


I actually have code in `src2asciidoc.py` (which generates this) to merge authors - which one do you prefer?


Комментарий к изменениям


Sometimes we try patch unloaded module and exception happen


This also fixes https://github.com/NRGI/resource-projects-etl/issues/39


I still don't get it. This seems like worse solution in pretty much every way I can think of.


Alexey Nabrodov or Alexey "Averrin" Nabrodov


Why not just skip the whole svg() block if host is NULL?


Changes look good; no need to revert.


just comment


It needs to be comma separated...


Thanks!


admin hat's wieder gelöscht, hat wohl einen build fehler verursacht


@pierremtb I intentionally didn't put it into a p because now it looks odd on larger screens.


Must be the right thing to do


habs gesehen, naja dann war es das schon mal nicht :(


Захар, возникла ошибка, в файле index.html при синхронизации гитхаба, добавилсь какие-то красные поля, как буд-то гитхаб "слил" в одно предыдущию версию файла и новую, на компьютере в папке гитхаба у меня все нормально, а на сервере вот такая история. Может нельзя нажимать нажимать sync до того как нажала commit to master?


My bad. I take it back.
:cry:


I was just thinking if it would not be good to test this regex separately.. However the tests provided look good also.


Hello! Csak annyit, hogy fejlesztés közben arra juttunk még korábban, hogy nem lesz szükséges vizuális megjelenítésre (de már akkor fel pusholtam ezt a részt). Erre a mai óra totálisan rácáfolt szóval újra elő vehetjük, azt hogy a kimeneti és bemeneti értéket, két különöző grafikonon ábrázoljuk test során


Misses styles.


saw approval from andytill
at https://github.com/basho/riak_kv/commit/9e9f1befaf85a5485ff1f65b27298d4e1fafd663


merging basho/riak_kv/feature/fix/RTS-340 = 9e9f1bef into borshop-integration-1201-feature/fix/RTS-340


basho/riak_kv/feature/fix/RTS-340 = 9e9f1bef merged ok, testing candidate = 74fd24c9


Why the manage configuration thing? It's linked...


There'll be an user setting to show 'You' or username for current user.


I think ```virtualenv -p python3.4``` or ``` virtualenv -p python3.5``` would be better. virtualenv is using the python version from $PATH. If the versions stated in requirements are ***really*** required, (I tested it with python 2.7.6, because it was in my path), it would avoid unnecessary work later on.


Mode is derived from user settings.


@nvnikolov Can I revert this change?


@Papillard tu mets quoi dans le `role` ?


@lofei117  我是来围观密码账号的。


Everytime a record batch is processed, this line is triggered; and they produce too much log. Maybe the logging level may be reduced to "debug".

`2015-10-01 11:03:20,444 INFO  [com.amazonaws.services.kinesis.clientlibrary.lib.worker.SequenceNumberValidator] (pool-2-thread-10) Validated sequence number 49554382885622994945145406019474732243465818420715455842 with shard id shardId-000000000086`


Instead of using `c++ -dumpversion` (which always reports `4.2.1` for Clang, due to compatibility reasons with g++), we should use the actual stdlib used, and write a short C++ code that uses ifdefs to print out the linked stdlib.


A little note: You know in AN we now got datatypes other than object, such as textblock, text sequence, maybe we can make it a bit more generic?


I am Cheerfull Guy.
I love Singing.Actully My passion is only MUSIC & just Music...


I would use the method `chdir` instead. http://ruby-doc.org/core-2.2.0/Dir.html#method-c-chdir


Please update my poor commit message to:
```
Fix handling From/To header in new Email::Simple.

Newer versions of Email::Simple (2.104+) treat arrayrefs in headers by fetching
the first item only in scalar context. Our snapshot installs 2.102, so this
shouldn't be an issue, but we might as well bypass Email::Simple for those
headers.
```


memset(&argss->structData[0], 0, 1024); must be 2048


Oops, I'd left `oid = x509.ObjectIdentifier(oid)` in `get_ext_by_oid()`, causing it to always return `None`.


Ok, so pointers need to be deleted manually, c'est noté :)


Please contact me by e-mail at dale@dalecnc.com, thank you


Done in 6856df552 and parents.


I can't handle by SWAG!


Where's my pregulator


Is it necessary since https://github.com/odoo/odoo/commit/c3c2281a4d6a148cebf4eed2d6ab894eedbf472c ?


This should read "TTYPath=", no?


IE8 still throws an exception here if 'all' doesn't exist in the pageLst array:

    pageLst.indexOf(this.options.formatAllRows().toLowerCase())


Taxas de câmbio no período 2006 a 2012, dinamizadores ou entraves a economia mocambicana?


If you declare CreatureSkill skill;
This will be deleted automatically when it is not visible.

If you declare CreatureSkill* skill = new CreatureSkil;
You will need to delete it when you know it is not in use anymore. In C++, it is often in the destructor of the class that uses it.


why did you remove the lock around self.write()
this makes it non thread-safe


Hmm. Unfortunally they are very different data types. And combining them would confuse everyone even more, because in some aspects they can have the same type and  sometimes they need to be different...


Thanks. But do you make sure what cores are used?
You can checkout the taskset command.

mvh

taskset -h
Usage: taskset [options] [mask | cpu-list] [pid|cmd [args...]]

Options:
 -a, --all-tasks         operate on all the tasks (threads) for a given pid
 -p, --pid               operate on existing given pid
 -c, --cpu-list          display and specify cpus in list format
 -h, --help              display this help
 -V, --version           output version information

The default behavior is to run a new command:
    taskset 03 sshd -b 1024
You can retrieve the mask of an existing task:
    taskset -p 700
Or set it:
    taskset -p 03 700
List format uses a comma-separated list instead of a mask:
    taskset -pc 0,3,7-11 700
Ranges in list format can take a stride argument:
    e.g. 0-31:2 is equivalent to mask 0x55555555

For more information see taskset(1).


The size must be passed by the caller. also, please call `assertValidAccess()`.


See my comment on the issue about how to fix this on windows:

```
#ifndef WIN32
#include <cxxabi.h>

static inline std::string demangle(const std::string &name)
{
  int status=0;
  char *p=abi::__cxa_demangle(name.c_str(), 0, 0, &status);
  std::string ret(p);
  free(p);
  return ret;
}
#else

#include <windows.h>
#include <Dbghelp.h>
#pragma comment(lib,"dbghelp.lib")

static inline std::string demangle(const std::string &name)
{
   TCHAR szUndecorateName[256];
   memset(szUndecorateName, 0, 256);
   UnDecorateSymbolName(name.c_str(), szUndecorateName, 256, 0);
   return szUndecorateName;
}
#endif

```


Now that this code run from this repo, the ontology filename now makes sense - https://github.com/OpenDataServices/cove/issues/103 (and won't break for a different python directory).


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2432


not quite accurate: the size is not passed as argument but rather retrieved from the vector.


what about changing failed/success string? if that is not processed result should be empty or N/A or ?


fixed in 0fe410d


Thanks. A great help.


Just a question regarding the use of `*PacketToSend`? Why did the Italians use `PacketAllocatePacket()` + `PacketFreePacket()` in the first place? (involving a potentially expensive `GlobalAllocPtr()`) Why not just keep it on the stack? LIke:
```
PACKET PacketToSend;
...
PacketInitPacket(&PacketToSend, (PVOID)buf, (UINT)size);
```


LGTM as well ;-) keen to use this now too


@flexiondotorg: now my ```~/.xsession-errors``` contains this:
```
x-session-manager[8481]: WARNING: Unable to find provider '' of required component 'dock'
```


Correct, fixed. Thanks!


`i.T0` is undefined for me.


Well, it was in the suggestion from Tanja, and maybe it helps the user a bit in knowing where they went, so they can find the screen again.


This is a pretty standard way to iterate a linked list, looks pretty clear to me

As for needing a break (you probably mean a return like in getDescriptor?), the effect of this is wether the first or last matching module decides the return value, I guess. It's probably best to have this consistent over all methods, and first matching (so with the return) is faster.

However, I'm not entirely sure how this particular loop works - it seems to always return the value of the last module, ignoring the return value of preceding modules?


@grandinj I just set the status of Bug 93410 to FIXED. With the latest update of jurt.jar to version 5.0.2.2 (bundled with libreoffice 5.0.2) the socket connection to the background process works again. Thanks a lot.


Assignment Branch Condition size for role_changed_notification is too high. [16.28/15]


Tak jak pisałem: zapamiętywanie id wiadomości z smstools nie jest potrzebne.


Понятно, исправим.


<img width="687" alt="screen shot 2015-10-01 at 14 33 22" src="https://cloud.githubusercontent.com/assets/982072/10219654/66b0f24e-6849-11e5-9fdf-60da52e1085c.png">
Пойду в линию их ставить, пожалуй. Они же так хорошо подобраны по размеру) Просто супер)


Done. I would've done it earlier had I not been on holidays.


Возьми textarea, spin и menu. И поставь в одну линию) Потом снова расскажи зачем единый подход с модификатором size на компонентах)


Thanks @bartoszgolek. This looks pretty good to me. Are you happy with it? Does it solve the initial problem you faced with the async service call? If so I'm happy to merge it in (give me a little while, have a hectic couple of days coming up).


Thanks for the precisions :) I had somewhat learned that in the introductory course I read, but it needs practice to get registered :D


I'll try and add this in when I get home from work tonight.


Where do you Add to the WaitGroup?


The mapping is opened after changing the name. This is intentional? Feels strange.


Impacto das variacoes da taxa de cambio na inflacao em Mocambique


Liam - do we need this footer inc????


can you use commit hash here?


Commited by Pavel Sokolov


Can this get merged into the main repo?


abov -> above


Mixed tabs versus spaces.


You can overwrite java 7 providings of parent...if you like..i would say why moving to java 7.....depending on which Maven version this should support...


Gameloop() is too long. Gives rise to high Cyclomatic complexity.The method Gameloop can be broken down into multiple methods.


Should say 3.0?


yes - not sure where it came from - maybe I added this accidentally


Best not to assume a nid of 1, just grab it from the node (the db where the tests are running might have unusual auto-increment settings.)


PEP 8 violation: Mixed indentation( spaces and tabs).


@dangerouse ssshh, it's a secret!


@NilsVollmer ein leerer String evaluiert in JS übrigens zu false. ` && @category != ""` ist also überflüssig.
(Nicht anpassen, bearbeite das eh gerade im Umzug aufs modulare System)


Cool Game! Enjoyed playing it :)


Related PR #4435


Have you considered using protobuf to serialize which is much smaller than JSON? Mapbox have a JS protobuf deserialiser which makes it trivial to decode. We have examples using our own datacube format if you wish to see.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21580/testReport/) for this commit**


In https://github.com/weaveworks/scope/commit/092167f5de739c7581a5f8b969c10f8aa02b0a92


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21581/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21582/testReport/) for this commit**


que te parece de cambiar al formato que se usa en OSEK?
quedaría así:
ciaaMulticore_ipcMsgType


*that is in use


Yep, I forgot to catch the exception in `list`, fixed in the next version.

About the color, it was intentionally left as red/stderr. It's the same as with `qemu -device ?`, it also prints into the stderr as it's an unexpected output. You're running `avocado run` expecting some tests to be executed. Instead you get some additional info, therefor the `stderr` is IMO correct place. One might argue about the color, but to me it goes naturally that the tests are not executed, I want to highlight why.

If you insist on changing it, I can do that, but I believe having it highlighted (for `avocado run`) is a nice touch.


thx, fixed


템플릿 클래스의 함수는 모두 헤더파일에서 정의하는걸로 압니다.
템플릿이 링킹 전인 컴파일 타임에 만들지기 때문이라고 합니다.
참고: http://stackoverflow.com/questions/5612791/c-template-and-header-files


got low performance for this. Benchmark dropped around 1000 points.


I wonder if this might need a test...


Ascii art,cool idea! It is highly recommended that hard-coded/ named constants are externalized into separate resource files/scripts.


не разбрах точно какво трябва да се получи, изтехлих и разгледах TortoisesSvn i Git Shell


@codingberlin:
This was the missing line causing the movable to become unscheduled. It was only possible when the following circumstances happend together:
1. The first action of the movable was the "nothing to do action"
2. It was standing on a blocked or protected ground at this time (as it is the case when it spawns from a living house)
3. while another non-pushable movable (in your case the builder in the middle of its animation) was directly blocking that path.

The bug did only appear now because of your change in the SpawnBuilding. Here https://github.com/jsettlers/settlers-remake/pull/184/files#diff-a0135670b5a7d3da027212b61f2ab17fL48 you directly call subTimerEvent() instead of only returning the production period. That's why a movable was spawned before all builders finished there animation.

However, now it is fixed. Thanks for discovering.


This is hardcoded and needs an edit, whenever a new tag is released.
I would suggest to dynamically check the latest git tag out, like so:

`RUN cd /var/www/kanboard && for /f %%a in ('git describe --tags --abbrev^=0 origin/master') do git checkout %%a`


This is too fragile. Please wrap it in a type.

```go
localReport := syncReport.Copy()
localReport = localReport.Merge(...)
localReport = Apply(localReport, taggers)
syncReport.Swap(localReport)
```


wat? :)


lemme fix this..


Our convention is not to use wild card imports. https://wiki.openmrs.org/display/docs/Coding+Conventions


@matheusagcosta Foram 5 trilhas simultâneas*** :)


tool > strumento, stand-alone > indipendente


fixed in 0f540e2619d40c95501ac7c285d6bb62fecc9bea


Licence information is missing.


Gyx's Page!!!


Fixed by ea5273b :)


vai a capo altimenti non lo prende come un blocco di codice

```
ed una volta installato può essere lanciato da terminale per progetti in locale:

$ ripple-emulate --path ...
```


This commit fixes an issue where the application was failing to connect to Mongolab, due to a planned [maintenance event](http://docs.mongolab.com/20150930-maintenance-event/), where MongoDB was upgraded to v3.0


Hmm, rather `href ||` as otherwise, we see "null" in the call stack of `console.error` when running this test case:
https://jsfiddle.net/L2xacvq9/3/

Florent


e per progetti online


I see. thx for the info.


features >  caratteristiche


I like the change, but we need to ensure that we are still able to retain the CADisplayLink refresh rate. Hardcoding 60 fps is not a good idea on some older devices.


Yes I agree, which is why I initially turned it on, but I temporarily turned it off because the travis build was doing a lot of complaining. When running lint locally in my environment I see 18 errors (which I have verified are not real problems) vs 115 that Travis CI was seeing. I need to figure out why the CI is complaining about more stuff.


You're right, will fix soon :)


@hudsonsferreira eu mudei a abordagem rs


fixed old code to use for


stupid...why does this happen always when i do git pull?


framework >  ambiente

```
così da adattare l'emulatore al comportamento del framework stesso.
```
puoi toglierla o sostituirla con qualcosa del tipo "così da poter provare le varie combinazioni di ambiente hardware"


se non c'è niente di interessante puoi anche ometterlo


Method docstrings, missing..


@timrobertson100 it would be nice to have them.

I really thought about having a binary format (and somehow we [have it](https://github.com/CartoDB/CartoDB-SQL-API/blob/master/client/bin_decoder.js)) but that comes after define what are the features.

What do you think about the features?

Thanks for your feedback


@matheusagcosta aff... hehe mals...


I thought it would be nice or so, but Thomas asked this question as well so I will remove it.


Use a guard clause instead of wrapping the code inside a conditional expression.


Esta versão não faz nada do que é pedido no guião da semana 2.


Seems `<stdio.h>` needs to be included in here too. Because in a program with headers arranged like:
```
#include <pcap.h>
#include <stdio.h>
```

we get an error on MSVC v19:
```
f:\ProgramFiler-x86\WindowsKits\10\Include\10.0.10150.0\ucrt\stdio.h(1419):
warning C4005: 'vsnprintf': macro redefinition
f:\MingW32\src\inet\libpcap\pcap-stdinc.h(171): note: see previous definition of 'vsnprintf'
f:\ProgramFiler-x86\WindowsKits\10\Include\10.0.10150.0\ucrt\stdio.h(1421):
fatal error C1189: #error:  Macro definition of vsnprintf conflicts with Standard Library function declaration
```

Since `pcap-stdinc.h` has:
```
#ifdef _MSC_VER
  #define snprintf  _snprintf
  #define vsnprintf _vsnprintf
  #define strdup    _strdup
#endif
```
prior to an `#include <stdio.h>`. Hence please add this:
```
--- a/pcap-stdinc.h    2015-09-24 15:44:02
+++ b/pcap-stdinc.h       2015-10-01 13:48:36
@@ -72,6 +72,7 @@
 #include <winsock2.h>
 #include <fcntl.h>
 #include <time.h>
+#include <stdio.h>
 #include <io.h>

 #include <ws2tcpip.h>
```


test


Hello, you meant 2015-09-30 or 2015-10-01 ;)


yet one


Too many arguments! Pylint: (7/5) (too-many-arguments)


Note: don't put `kernelPatches` there like that, because that would not honor `kernelPatches` passed from `.override`.


ok


added two lines


`this_does_not_exist`. I know, it's a nitpick, but it's better to fix it now than later. A force push is fine here.


Same here


eh. it technically doesn't really matter since all of argss is bzeroed anyway


Tidy indention throughout. You have an envious editor ...


Same here. just do `s/this_does_not_exists/this_does_not_exist`


Yes, It solves my initial problem, it's even better.
I will make some cleanup (doc comments, callback namespace, folder, interface/class per file etc.) and it will be ready to merge.

Thanks for great cooperation.


:+1:
thx, i was looking into it


Ah, right. I've taken the liberty of cleaning up the gems after merging the pull request and encountered some of that as well.

    WARNING:  pessimistic dependency on CFPropertyList (~> 2.2.0) may be overly strict

That was indeed overly strict, but I think dropping the last digit was a better solution. Now it's `'~> 2.3'`.

    WARNING:  open-ended dependency on bundler (>= 1.0.0, development) is not recommended

That's true but I don't particularly care about the bundler version because that can be a pain to work around if you happen to have a different version, so that's ''~> 1'` now.

I've also added a couple of smoke tests and released 0.2.0, so if you're pulling from git now you can point it at that version instead.


Forgot to mention in the commit: in order to make the fields cloneable, AJAX updating was removed.  That that means is that the `file_advanced` and `image_advanced` fields are no longs saved automatically by AJAX; you have to save the page, which makes it consistent with all other fields.


For 7.5 compatibility


initial commit


Do you know if that made it into 1.59 ?  I had one other request for updating to 1.59 (for a Windows and g++ 4.6.* issue with Boost Fusion).


Was that a dumb suggestion?


we also have to assert the http status code in addition to the ocs status code.

we should add a second function/sentence

@Then the OCS error code should be


what a horrible idea - merging the machine drivers with arcade.


@plamut, pls review this part, I hope this is well written.


Hi, could you give us an exemple to help us understaind your code?


There's a misspell in the work canola. please let me know when it's fixed.


close #7


the existance of a user is verified via it's http status - and this is why the version above was hard coded.

I was pushing you into the wrong direction ... sorry


keeping this hard coded to v2 is required .... see below


Hi @mark-cooper, since you defined ISLANDORA_OAI_ADMINISTER_PERMISSION as a constant, then if you are going to use it here it and also in every access argument it must go without single quotes. Or you permission name will be 'ISLANDORA_OAI_ADMINISTER_PERMISSION' literal and not evaluated as 'administer oai'. I would also suggest to use something more islandora like 'administer islandora_oai' or' administer islandora oai' in the case there could be another not islandora module having the same permission, mostly as a way of stating this is only related to our islandora implementation of OAI. This last part is just a suggestion.


And could you merge this into 4.0.x, please?


FWIW, I got bitten by this the other day: Writing my own list-based response handler, I intuitively expected the `value` argument to be irrelevant there (mostly because that dummy argument seemed this-can't-be-right wrong on that end). Omitting it resulted in non-obvious errors (likely due to the surrounding test harness), so I descended down a rabbit hole for a while...


I don't know. Just trying it out for now.


Hi,
Very nice work on explaining Git.
The link already updated in this commit is however broken ... sounded interesting though!!
Since I am quite curious there, could you update that again to make the page accessible?
Thanks and best,
dmr


wrongly indented


The commit comment says
> Mac OS before 10.5 would not support [NSProcessInfo processorCount] so make this safe.

You are right, as Lumberjack requires OS X 10.7 or later.


Seems legit...


Keep me posted.  If it works and if it is in 1.59 it would be one more reason to roll from 1.58 to 1.59.


Ok, good. Thank you for taking care of it and making 0.2.0! :dolphin:


all the code is indented with spaces :crying_cat_face:


As far as I can tell, this means that by default no emails sent via mandrill_mailer are logged. Correct me if I'm mistaken:

    MandrillMailer::TemplateMailer.defaults #=> {}
    MandrillMailer::TemplateMailer.defaults[:view_content_link] #=> nil
    MandrillMailer::ArgFormatter.boolean(MandrillMailer::TemplateMailer.defaults[:view_content_link])
#=> false

This is a departure from the behavior prior to this change, and also a departure from the Mandrill APIs default behavior, as [the API](https://mandrillapp.com/api/docs/messages.html) requires an explicit `false` to disable logging:

> set to false to remove content logging for sensitive emails

We can easily work around this by setting the default to `true` in our mailers, but I wanted to make sure this change was indeed intentional.


homer?

![2180501](https://cloud.githubusercontent.com/assets/1005065/10220434/b5a8efb6-6847-11e5-9a02-2b3809d370dd.jpg)


I feel bad introducing a bug ... nevertheless I discovered it :-)
Thx for help!


Looking at it now, it's clear those patches would be replaced by
overrides. When I first wrote this, it wasn't apparent to me for some
reason. Thanks for the heads up.

On Thu, Oct 1, 2015, at 08:08 AM, lethalman wrote:
> Note: don't put `kernelPatches` there like that, because that would not
> honor `kernelPatches` passed from `.override`.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/NixOS/nixpkgs/commit/e45e777c373c14b744b2940d806cf02dad84b42f#commitcomment-13539412


Great thanks. Also I think there is something up with the NHibernateX Nuget
package, it seems to reference the wrong version of Antlr.

On 1 October 2015 at 16:27, ReverseBlade <notifications@github.com> wrote:

> I added the missing file. Sorry for the inconvenience.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ReverseBlade/nhibernate-core/commit/5faec74ad9ddcda4d6590be4b3fc8ac1a46b34e4#commitcomment-13534112>
> .
>


Ok, will change.


Will do.


This change breaks databinding and localization


Is this file necessary?


Ok, will do.


Please get used to throw-first coding.
==> Check for errors and throw the exception in the if block and continue normally after that, instead of throwing exceptions in the else block. This makes the code hard to read and unnecessarily increases intention.


@dhoer thanks a lot for your rapid feedback, if I understand well you no longer need it then :)

> The vagrant-wrapper gem is in conflict with vagrant 1.7.4 on my mac

This statement actually sounds in total contradiction with [vagrant-wrapper main goal](https://github.com/org-binbab/gem-vagrant-wrapper/blob/master/README.md#vagrant-wrapper-gem) :astonished: .

From my understanding the `vagrant-wrapper` can save your day if your Gem Bundle for some reason contains a very old Vagrant (pre-1.1) gem. But that's not the case if you install this project in a fresh new bundle.


Yay, finally! Finding your way between the two similar directory trees was a real headache...

Now, to find a new backronym for MAME. I propose "Modular Any-Machine Emulator" :-)


Realized that I can achieve the same thing without having to use of the bDHTstarted flag check or the DHT.acquiring() function check. Those things have been replaced with DHT.acquireAndWait() function.


In the **develop** branch, I've clarified which init methods are failable, made the class methods "throws" along with `startNotifier()` and updated the README. Would be great if people could check this out and test it!
Thanks
Ash


The same can be applied for the other resolve_full_local overload.


fast-forwarding end-to-end/timeseries to borshop-integration-1201-feature/fix/RTS-340 = 74fd24c9


What do you mean? I think it was applied everywhere.


Multiple Archaic Machines Emulator :-P


Sure, looks good to me.


...or even ancient, perhaps ? :-D


Line is too long. [101/100]


Line is too long. [103/100]


Will fix it.


Good point about `mode='w'`.


Estranho a ausência de invocações ao método "close" nas várias streams usadas no programa...


looks excellent go ahead :)


Apologies, I made a mistake, rat still has to be imported for ROOT to work, even though it is not used explicitly.


Also, how about merging emu/{drivers,machine,layout} with mame/{drivers,machine,layout}, and reducing the number of files in mame/drivers (GitHub can only show 1000 files per directory)


@thz pling:

i liked the LOG_ERROR much better. if the connection to critical hello-endpoints drops, i want a huge red blinking message, that the criticial connection dropped somehow.


thought, do we care to support multiple licences?


@woogerboy21 This is why we want #1615.


Now it works just like it worked in Nette 2.0. Nesting of stack trace is wrong. It worked only because of short life of requests in PHP.


joer kolega m stas joidemdo la rrepo


I think line 513 should be `this._segment2 = segment;`


Probably yes, different versions of Blosc.  That's normal.  Depending on the Blosc version, bcolz can use chunks that can vary in size (lately I was pushing for larger minimal blocks in Blosc so as to optimize the compression/speed ratio).


I think line 509 should be `this._segment2 = segment;`


I think there's an argument that the logic in `build_from` belongs in the controller, or that `gov_delivery_response = ..` also belongs in `build_from`.

Any idea why this wasn't done with `strong_params` before btw?


On 1 October 2015 at 13:09, Moritz Schubotz <notifications@github.com>
wrote:

> Import unicode.xml
>
> From http://www.w3.org/Math/characters/unicode.xml originally authored by
> @davidcarlisle et al.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/physikerwelt/utf8tex/commit/d7ba9acc5e24471fc4540c44043d9860fa5157fe
>

Hi, if you're pulling latex names from that file I'd stick to the
<mathlatex set="unicode-math"> set (or at least use that one if it is
there) those are exactly the names used by unicode-math and stix packages.
(or at least they were until Will changed a couple, I need to update again)
many of the other "latex names" are somewhat speculative going back to
before unicode had the characters and before there was any tex support for
them. (It's an old file:-)

I should note that there is movement at W3C to move spec sources to github,
I may do that with the entities spec, in which case you'd be able to
directly track unicode.xml in github rather than have a "copy by hand"
version.

David


Would this be better in the model?


ルイズ！ルイズ！ルイズ！ルイズぅぅうううわぁああああああああああああああああああああああん！！！
あぁああああ…ああ…あっあっー！あぁああああああ！！！ルイズルイズルイズぅううぁわぁああああ！！！
あぁクンカクンカ！クンカクンカ！スーハースーハー！スーハースーハー！いい匂いだなぁ…くんくん
んはぁっ！ルイズ・フランソワーズたんの桃色ブロンドの髪をクンカクンカしたいお！クンカクンカ！あぁあ！！
間違えた！モフモフしたいお！モフモフ！モフモフ！髪髪モフモフ！カリカリモフモフ…きゅんきゅんきゅい！！
小説12巻のルイズたんかわいかったよぅ！！あぁぁああ…あああ…あっあぁああああ！！ふぁぁあああんんっ！！
アニメ2期放送されて良かったねルイズたん！あぁあああああ！かわいい！ルイズたん！かわいい！あっああぁああ！
コミック2巻も発売されて嬉し…いやぁああああああ！！！にゃああああああああん！！ぎゃああああああああ！！
ぐあああああああああああ！！！コミックなんて現実じゃない！！！！あ…小説もアニメもよく考えたら…
ル イ ズ ち ゃ ん は 現実 じ ゃ な い？にゃあああああああああああああん！！うぁああああああああああ！！
そんなぁああああああ！！いやぁぁぁあああああああああ！！はぁああああああん！！ハルケギニアぁああああ！！
この！ちきしょー！やめてやる！！現実なんかやめ…て…え！？見…てる？表紙絵のルイズちゃんが僕を見てる？
表紙絵のルイズちゃんが僕を見てるぞ！ルイズちゃんが僕を見てるぞ！挿絵のルイズちゃんが僕を見てるぞ！！
アニメのルイズちゃんが僕に話しかけてるぞ！！！よかった…世の中まだまだ捨てたモンじゃないんだねっ！
いやっほぉおおおおおおお！！！僕にはルイズちゃんがいる！！やったよケティ！！ひとりでできるもん！！！
あ、コミックのルイズちゃああああああああああああああん！！いやぁあああああああああああああああ！！！！
あっあんああっああんあアン様ぁあ！！シ、シエスター！！アンリエッタぁああああああ！！！タバサｧぁあああ！！
ううっうぅうう！！俺の想いよルイズへ届け！！ハルケギニアのルイズへ届け！

英語版

Liz. Liz. Liz. Liz.
..... ..….. ah … . Lizlizliz !.
Cncacnca. Cncacnca. Suharsuhar. Suharsuhar. ..a good smell it..
… Mr. Mr.. It is ..Cncacnca.. !
as for the hair of a pink blond of the Liz Fransowarz phlegm. Cncacnca. !.
It made a mistake. ..Mofmof.. !Mofmof. Mofmof. Camicami Mofmof.
Caricarimofmof … Coming !.
Liz of 11 novel volumes … … !.
Sleep Liz phlegm that you may decide at two animated cartoon terms. .
It is lovely. Liz phlegm. It is lovely. .
It is glad for as many as two comic volumes to be put on the market … .
The comic is not a reality. .... ..encounter.. when often thinking about …
novel and the animated cartoon … Isn't Liz a reality?!.
Such unpleasant of Halkeginia a !.
This !. It stops it. Stop the reality and … Food. ?Seeing …
Is Liz of the cover picture looking at me?
Liz of the cover picture will be looking at me. Liz will be looking at me.
Liz of the cut-in illustration will be looking at me.
Liz of the animated cartoon will be talking to me. It was good …
..no Mon it who had renounced of worldly still having a long way to go...
I have Liz. It is possible to do alone Katy doing.
Liz of , ..encounter.. comic.
Shanna Vilhelmina. Ann ! Se and saver
It ..delivery.. delivers it to Liz of Halkeginia Liz my .... desire.

英語版（TOEIC980点の奴が訳したバージョン）

Louise! Louise! Louiseaaaaaaaaaaaaaaaaaaaaaaaaaaaahhhhhhhhhhhhhhh!!!
yarghh...uh...aaahah-! AaAAAAA!!! LOUISELOUISELOUISEaaaaAAAAaaa!!!
Ae...sniffsniff! sniffsniff! sssssaaahsssssaaah.. smells good.... sniff
　gasp! I can haz sniffsniff pink blonde hair de Louise Francoise?! sniffsniff! Aah!
No! I want fluffing! fluff! fluff! Hair hair fluff fluff! Scratch scratch fluff fluff... Kyunkyunnkyui!!
Louise-tan was so kawaii in vol.12 of the novels!! AaaAA...AAA...AhAaAAA!! FaaAAAnng!
Congrats on the 2nd season of the anime Louise-tan! AaAAAAA! So cute! Louise-tan! Kawaii!AaaAAA!
2nd volume of the comics were grea...nnNrAGGggghHH!! Nyaaaaaargh!! UGyaaaAAAAA!!!
Nnnnnnyyyyuuuurrrrgggghhhh!!! Comics...................... AREN'T reality!!! ?...what about the novels and the anime....
LOUISE I S N' T R E A L????? AAAAArgggghhHH!!! Uwaaaaaaannn!!
NononononoNONONONONO! EEeeeeaAAAA!!!! HGGGGrrrrruuyynnnnnNN!!! Halkeginiaaaaaa!!
You! BASTARDS! I'm quitting! I'm QUITTING REALIT...Y....huh!? She's...looking? Louise-chan on the cover is looking at me?
Louise on the cover IS looking at me! Louise... at me! Louise-chan in the pictures in the book are looking at me!!
Louise-chan in the anime is talking to me!!! Phew... reality ain't so bad after all!
Yessssss! Wheeeee!! YEAH!!! I have Louise!! I've done it Ketty, I can do it alone!!!
C..comic... Louise LOUISE-CHAAAaaaaaAAaaAAAN!!!!!!!! HyaaAAAaaaAaaaAAaA!!!!!
Ahahaah...ahahaaahhhhahaAnn! Si, Siesta!! HenriettaaaAAAAAAaAA!!! TabithaaAAAAA!!
u....uuuu..sniffsniffuuuUUU!!! May my love reach Louise!! May my love reach Louise of Halkeginia!

英語版（TOEIC980点の奴が訳したバージョン）を再翻訳したもの

ルイーズ! ルイーズ! Louiseaaaaaaaaaaaaaaaaaaaaaaaaaaaahhhhhhhhhhhhhhh!yarghh…えー…aaahah!AaAAAAA! LOUISELOUISELOUISEaaaaAAAAaaa!
Ae…かいだにおいかいだにおい!かいだにおいかいだにおい!sssssaaahsssssaaah良く匂います… をかいでください。喘ぎ!私はdeルイーズ・フランソワーズ?かいだにおいかいだにおい!haz sniffsniffのピンクのブロンド髪のAahをそうすることができます!いいえ! 私は、綿毛!綿毛!綿毛が欲しいと思います! 髪の髪の綿毛綿毛! かすり傷かすり傷綿毛綿毛… Kyunkyunnkyui!
ルイーズ-日焼けは小説のvol.12でとてもkawaiiでした! AaaAA…AAA…AhAaAAA! FaaAAAnng!
アニメルイーズ-日焼けの2番目の季節におめでとう! AaAAAAA! とてもかわいい! ルイーズと同じくらい日焼けしてください! Kawaii!AaaAAA!
コミックの2番目のボリュームはgreaでした…nnNrAGGggghHH! Nyaaaaaargh! UGyaaaAAAAA!
Nnnnnnyyyyuuuurrrrgggghhhh! コミック… AREN'T現実! ?...小説とアニメはどうです…
'ルイーズI S N'T R E A L? AAAAArgggghhHH! Uwaaaaaaannn!
NononononoNONONONONO! EEeeeeaAAAA! HGGGGrrrrruuyynnnnnNN! Halkeginiaaaaaa!
あなた! 私生児! 私はやめています! 私はREALITをやめています…Y.…えっ!、 Sheのもの…見ること? カバーの上のルイーズ-chanは私を見ていますか?
カバーの上のルイーズは私を見ています! 私のルイーズ…! 本の絵のルイーズ-chanは私を見ています!
アニメにおけるルイーズ-chanは私に話しています! フー… 現実はそれほど結局悪くはありません!
Yessssss! Wheeeee! うん! 私には、ルイーズがいます! 私はそれにケッティをして、単独でそれができます!C。.comic… ルイーズルイーズ-CHAAAaaaaaAAaaAAAN! HyaaAAAaaaAaaaAAaA!
Ahahaah…ahahaaahhhhahaAnn! Si、昼寝! HenriettaaaAAAAAAaAA! TabithaaAAAAA!u。...uuuu。かいだにおいuuuUUUをかぎます! 私の愛がルイーズに届きますように! 私の愛がHalkeginiaのルイーズに届きますように!


Ok, so you can merge it when you want, 'cause actually the other devs which require the control autofocus don't really depend on this dev, I mean apis are intact, they just won't work as expected but they will not break ;)


Any idea why the stuff in the hstore is JSON in the first place? That doesn't seem to make sense.


Надо обернуть в транзакцию два действия.


also, looks like this isn't only about github, it's got publishing things and license things..


I think this is a bit too opinionated


sengaja saya push, karena saya belum tau kesalahannya, mudah2an ada yang mau memberikan pencerahan,.. hehehe,...


Mostly just change of indent. Actual change is:
```
if form.is_registration_form() and form.is_case_list_form:
    ....

# to
if not form.is_case_list_form or not form.is_registration_form():
   return []
```


@mpdude well, how can you chmod something not existing?


This returns only the datums that are common to all forms in the module.


The package for this class should simply be "org.openmrs"


 :100:
@aathomas hopefully does not mind


The package for this class should be org.openmrs


Переименуй в `FlagOldReports` или `UpdatePreviousReports` и передавай только `SourceCode`


Помоему этот метод тоже нуждается в доработке.


Are you the one who commented out this code?


Oh I just noticed you used http://www.w3.org/Math/characters/unicode.xml eek!!!! don't use that one use http://www.w3.org/2003/entities/2007xml/unicode.xml  which is up to date with Unicode 8. The old one is a pre-mathml3 legacy file from 2003.


concatenate titles


I've got most of the proof of unite+-nat, but not pushed yet.  I'll merge and push.


- Add ways in issue data
- Report power issues only with lines


`coreM.js`


I release from the Amsterdam timezone ;)


You do get an email with these comments, right?


a variável "texto" não foi inicializada!


We no longer have activelists. Can you change the above?


OK, but I don't understand why you didn't run the perl one-liner once in the repo root and commit the result. Sounds like extra effort to do it repeatedly for individual subtrees.


No need to leave these commented out lines.


...nem "cod"...


TeamCity pull requests :: netty-tcnative [Build 17](https://garage.netty.io/teamcity/viewLog.html?buildId=1924&buildTypeId=pulls_netty_tcnative&guest=1) is now running


Kannst du bitte auch noch das css aktualisieren


We will have to use MATLAB R2015b which supports this functionality.


Given the existence of "moduleName" in sbt, introducing Module might be confusing.

If we can find an alternative we should consider using it, if not so be it.


The change seems to fix the warnings. I opted for a local change for now.
https://github.com/hadley/dplyr/commit/db176852c65751e51ebe695cbd14db8451fb9f70

Let me know if you want to promote this to `BH`.

I don't know how to look for what is in 1.59, so I'll leave this hunting to you.


@DefinitlyEvil Yes the RakNet decode error.

On Thursday, October 1, 2015, The Evil Man <notifications@github.com> wrote:

> So this fixes that problem?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BlockServerProject/JRakLib/commit/30ebe4b8284da2d4a22a825c168124020e02f3c1#commitcomment-13533724>
> .
>

--


TeamCity pull requests :: netty-tcnative [Build 17](https://garage.netty.io/teamcity/viewLog.html?buildId=1924&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:53


Why not completely remove this?


Надо добавить проверку, что факты вообще есть, а то ты обращаешься в 0-элементу, а его может и не быть. Т.е. отчет пустым пришел.


As I have mentioned in my previous response that we can protect _all_ids by making it local to some self executing block. I have committed changes related to that in 524dc000e174868c8a811cafa47814efd6a044a4 commit.
As you can see the main changes that I have done in the commit was to use (function() {})(); and make _all_ids local. So that id() function can access _all_ids but the array is still protected.


na minha opinião, `# noqa` não é uma boa ideia:

http://plone.293351.n2.nabble.com/Style-Guide-tp7573679p7574188.html


No need for allergy-api comment.


As a diff, this looks good. Some initial comments, I'd have to work with it to give more feedback.


Method parameter should be of type Patient instead of Person.


O seu programa tem uma estrutura próxima do que seria uma primeira abordagem ao problema proposto (mesmo se, no estado em que enviou não funciona! --- ter-se-á esquecido de fazer push da última versão no repositório?). De qualquer maneira, depois ainda seria preciso processar os argumentos comando, que obrigariam a algumas estruturas no código.


No need of allergy-api comment


But replace_url_params should keep any parameters in the request - that is the whole point of that method. So by adding in the sort etc into the template seems like the wrong way to go.

I think this was caused by this commit: https://github.com/datagovuk/ckanext-issues/commit/fd7aa7356da8fd7537e75d297ccde2fbfd86f5f7 which returns the url with only `new_params`, not `params` that the method did before.


Did you actually test this out?


Mantap Pak :dancer:


@vcunat: Thanks!


TeamCity pull requests :: netty-tcnative [Build 18](https://garage.netty.io/teamcity/viewLog.html?buildId=1925&buildTypeId=pulls_netty_tcnative&guest=1) is now running


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21589/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21590/testReport/) for this commit**


We do not need the activelist package any more.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21591/testReport/) for this commit**


Well this is to keep static analyser happy and i'd prefer to keep it, since it doesn't cause any harm.
If you feel strongly about it though i can remove it.


Исправил


TeamCity pull requests :: netty-tcnative [Build 18](https://garage.netty.io/teamcity/viewLog.html?buildId=1925&buildTypeId=pulls_netty_tcnative&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:01:00


Did you just forget to remove the commented out code?


All these commented out lines need to be removed.


This file should not be called active list


any reason this (and below) is not `const` and `&` ?


Its not an object that you have here. Its the prototype definition where we can create an object from afterwards.


whitespace seems off


Commented out lines should just be removed.


Usual naming conventions in JS are that you start all variables and class members with lower case (lower camel case) except a 'class' definition.


this chunk does not match the commit message it seems


this is not obviously correct to me and the commit message makes no sense to me


Do we need the allergy api module message?


The message key names should no longer have anything to do with the allergyapi module.


@SuperstarGamer It should be getNametag(), need a method in Player for getUsername().


Could somebody please test this version of bl-conky-session by just copying it into an existing install? I simplified some very questionable [[ ]] / [ ] constructs.


(But for the debugging purposes can be stack history somehow stored somewhere… Like requests.)


I'm sorry but I still don't get it.

It IS a history. It would be even clearer if we remove the special condition for `ForwardResponse` (one of many things on my todolist) and pass `$application` instance to `Response::send` (stack trace would then be App::processRequest, Response::send, App::processRequest, Response::send, …).

> It worked only because of short life of requests in PHP.

This one I do not understand at all, sorry. How would things change if the a single Presenter::run() call would take a week?


So am I merging it or not?


hello @h2o64, what do i need to add in order to make it work in official CM roms?
i already dts setting in msm8226-moto-common.dtsi
but the driver failed to locate layout and outbit.


Did you need to touch this?


First point: the controllers role here is to coordinate the various actions involved in creating a new Subscriber List. The communication with `gov_delivery` shouldn't really be a responsibility of the SubscriberList model, IMHO. If anything, a Service object should coordinate these things, but there's not really enough going on here to warrant a new abstraction.

Second point: I just made the assumption that it was because parameter whitelisting isn't much of an issue here given this isn't a public-facing API, but on second thought using strong params would be nice anyway as it (correctly) leaves params-handling in the controller. Will update.


Поправил


it's an iterator. i did not want to change the behaviour too much.


On methods like calculateCosts you usually expect that it will use its parameters, do something internally and returns the calculated result. This is actually a setter here and you should mention that in the method name. Something like setCostsByHourPrice(hourPrice, ...).

Try to improve names of the parameters. I couldnt figure in a moment what constVar2 is actually standing for.


i have to recheck the whitespace here, i noticed it too but it looks "OK" in editor.


Line is too long. [102/100]


Changes in these commit do not seem to be related to the allergyapi work in any way. You should just remove all active list classes.


I thought so. Can we require this from users?


you are right, must've done mistake somewhere...


Its like common convention that files have to end with a newline. This is not really needed but has built its way through legacy in IT. You can see that even github is complaining here. You can configure this in your IDE and then you have to never think about it again.


Ggg


Yeah, this stuff is a little weird. I figured I'd make the simplest change possible in this PR but I'll have a quick stab at working this into the model.


Use index provided by jQuery function. See http://api.jquery.com/each/


Fine, merge it.


Great. Thanks. And I fixed the problem with my RL scaling factor estimation. But for the accelerated RLL I will have to plough through the math again to see how to deal with the scaling factor properly :-(
In a first try now the RLL is not better than standard RL.
Hopefully (Hauke?) we will soon have a more detailed comparison of your results (single and multi view) with ours for precisely the same input.
The subtraction of the minimum is probably not a good idea as discussed. There is in fact an automated way of getting this right, but for that we will have to probably wait until a paper I am working on with Bernd is submitted.
Best wishes,
Rainer

---------------------
Rainer Heintzmann
Institute of Physical Chemistry, Friedrich-Schiller-Universität Jena,
Helmholtzweg 4, 07743 Jena, Germany
Leibniz Institute of Photonic Technology, Albert-Einstein Str. 9, 07745 Jena,
Germany
Tel.: +49 (0) 3641 206 431
---------------------------------

> Am 01.10.2015 um 12:12 schrieb Stephan Preibisch <notifications@github.com>:
>
> set the quotient of the Lucy-Richardson to 1 if there is no data (thanks @RainerHeintzmann)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/bigdataviewer/SPIM_Registration/commit/a252250e89a8c848cfd44d1ab10dcbab124ce05b


![warnings with react components](https://cloud.githubusercontent.com/assets/6402577/10221140/e0f3ffd2-6822-11e5-8383-6a019387340e.png)


Yes, that's fine.


The continues are not really necessary here. There is no action because its elseif. Anyway a switch statement would match this case better. There you will need the break; statements though.


@troianoandres
Andres, I'm having this warning messages while executing my app. Could you find out what the problem could be?
Thanks


Not chmod, change the umask and reset it back afterwards


Is this file in use?


Yes, I am still working on this.
I left the comments until the review process was further along.
Also webservices.rest changes is a mess, I am redoing it and will resubmit as one commit a bit later with changes following the review so far.


This commit should work out of the box if you have POWERSUSPEND in your kernel


Its best practice to not leave global variables. Though in the "main" file of your nodejs program you dont need to wrap it in a closure.


The only real arguments against recursion is performance which is irrelevant here because in real-world the depth of recursion will be (guessing obviously) 1 in 98 % cases and less then 3 in 100 % cases.


Relevant: tracy contains a panel with all application requests.


si los mensajes son de distinto tipo, ¿no se puede incluir un tipo enumerado para indicar que tipo es y luego una union para los diferentes datos que se deben enviar en funcion del tipo de mensaje?


Agreed I actually made that comment myself to biyeun when working on it and
failed to change it haha. Good call

On Thursday, October 1, 2015, Farid Rener <notifications@github.com> wrote:

> I know you didn't change this, but now that everything else looks so good,
> that 'open in a new window' should probably be "Open in a New Window" to
> follow the convention of the other button.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/dimagi/commcare-hq/commit/2fb3a752e40ac45b625bc1a1122eb354c6d5df52#commitcomment-13534777>
> .
>


Not possible, as `umask()` is thread-unsafe


Would be perfect to make these paths configurable by command line arguments that you pass to your node program.


I have a question about allergyui. It is proving to be very difficult to build the platform to test it. To test allergyui I have to have coreapps, which needs emrapi and providermanagement and they don't look like they are ready for 1.12.0.What are the options?


Boost sources are on GitHub.


odd.


node_modules should be ignored for git in the .gitignore.


As for now, just ensure that all unit tests pass after your changes.

On Thu, Oct 1, 2015 at 4:03 PM, jdegraft <notifications@github.com> wrote:

> I have a question about allergyui. It is proving to be very difficult to
> build the platform to test it. To test allergyui I have to have coreapps,
> which needs emrapi and providermanagement and they don't look like they are
> ready for 1.12.0.What are the options?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jdegraft/openmrs-core/commit/67722c20ba809baee666de70570378fdb372dc11#commitcomment-13540555>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


Address is actually a path to the file. sheetNumber is not used, try to avoid unused parameters.


Might it be better to use Ember.isEquals here?


Поправил


Переименовал


Не понял что в нем можно изменить.


Will test that that also works (probably) and change.


„Forwaring“ versus „Nesting“. Forwaring means that there is only one request and one presenter each time, nesting means that there are more requests and presenters, going deeper.

Ignoring that the number of forwards is limited by Application, with recursion there will be PHP limit of ~100 forwards because of „Maximum function nesting level“.


Modules that you include somewhere shouldnt change prototypes of other modules or even worse of global objects as here. If you want to change them make that explicit and add an own date extension module (file). Though in this case I would go for an internal function getWeek(date) in here.


This is the default ui for allergy in core, it was the only way I thought I could initially test my changes.


Hey! I see you are interested on keeping updated the site! Submit a pull request next time so we can keep everything in one place! Thanks for the contribution and interest!


Looks like you've committed debug logging enabled by default


We need to remove it too!

On Thu, Oct 1, 2015 at 4:10 PM, jdegraft <notifications@github.com> wrote:

> This is the default ui for allergy in core, it was the only way I thought
> I could initially test my changes.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jdegraft/openmrs-core/commit/67722c20ba809baee666de70570378fdb372dc11#commitcomment-13540695>
> .
>

--
If we keep uppermost in our minds the unkind and unjust acts of others, we
shall find it impossible to love them as Christ has loved us; but if our
thoughts dwell upon the wondrous love and pity of Christ for us, the same
spirit will flow out to others.


seems sane. +1


(eceaefd) The title of the commit doesn't respect guideline ("type(scope): title (refs #<number>[, ...])")


This is a very good start  @solojavier well done! What we can do in future commits is to move the tomcat and jenkins plays to their own roles, as described here: http://docs.ansible.com/ansible/playbooks_best_practices.html#top-level-playbooks-are-separated-by-role


And most importantly: I always wanted to use goto!


You do not need these doubled function names. If you have such a helper I would structure it the following:

    function addRowToArray() {}

    function convertReceivedDataToObjectsArr() {}

    module.exports = {
      addRowToArray: addRowToArray,
      convertReceivedDataToObjectsArr: convertReceivedDataToObjectsArr
    };

If you have already ES6 what node has then you can shorten the exports into:

    module.exports = { addRowToArray, convertReceivedDataToObjectsArr };

See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer for the shorthand notations.


Works OK in a default BL install in VBox.

(You will find similar noobish code in other scripts as well :( )


Yes, the change I made was more in line with the rest of the code, I left the comment until further in the review.


Can't we just set `component.color = blue`, due to commit a474e2b in Breadboard?


Also added a reference to tabletEvent in glcanvas.h. This is an unrelated bug which has been around for a while. And commented out GL1 calls in glcanvas.cpp as these are no longer needed and cause trouble for pi.


в using теперь )


Its nice when you a give a bit of information to the console output. Currently you do not know what happened after executing it. Something like: Successfuly written N new entries to FILENAME.


shouldn't it be: `return _configuration = new DataCleanerConfigurationImpl();` ?


Make paths configurable via CLI arguments.


Сделай проверку перед открытием транзакции.


Errors are used in the dialog (they are not part of the label) and the dialog itself need two more attributes from StorageSpoke -- five arguments in total. The only part that is 100% same and could be easily moved to a function is the quit part and I'm not sure it's worth it moving two lines into method.


Тут ничего страшного если сохранять нечего. Просто выйди из функции. Не надо такое страшное сообщение писать.


Its common practice to add a README.md to the project that describes what the project is about and how you use it.


Concatenate title


<vinkelparentserna> på rad 205 skrivs inte ut!


Can't do that, since _configuration is final.


Maybe this can and this should be modifed via some hook?


this kind of thing should not have the angle brackets removed, but replaced by something like `<t>`


hmm. I guess I have two ideas:

1. We could make a `<Logo>` component to go with `logo.scss`
2. We could move `logo.scss` to `config/` and it could have mixins for the header, instead of the actual rules.

What do you think?


after discussion on IRC it was agreed that this is correct, and that the commit message is confusing. do you want me to rectify the commit message?


"Set<String>" is java code; replacing it with "Set string" makes no sense


Is this running for all the barclamps ? I see some proposals dont always have a default proposal so the response for "crowbar <proposal> show default shows "No current configuration for default". If the list of barclamps is controlled somewhere. Eg: pacemaker barclamp has proposal for "data" but nothing for "default"


Сделал


This method takes a parameter, but ignores it?


@jonasschnelli The rename is still required. The app shows itself as `Bitcoin Core.app` in the Finder, but when viewed from a shell it’s shown as `Bitcoin-Qt.app`, so I’d say it’s actually worse than it was, because it’s more confusing.


gkograkoio


Try to make your commits smaller please. There is the 50/72 best practice for commit messages, I sent you a link via hipchat for that.


I think the current plan is to subdivide mame/drivers by manufacturer.  Github's 1000 file limit is indeed a pain (we were already hitting it before this, actually).


Считаю все таки его нужным, но Warning оставил


Addresses https://github.com/scotchfield/rocket-comments/issues/1.


@YuryBY can we put an abstract saveToRepo( RepositoryImportFeedbackInterface feedback ) in AbstractMeta and implement it in JobMeta and TransMeta?  Now that they have a common parent class, I'd like to start moving away from "if jobs do this, if trans do that" if possible


ToPlayer ?
error:class "unit" is dosent have "ToPlayer" member


full-ack on this. this needs to be fixed.


Great. You seem to be on the right track.


Is the plan to subdivide them in src/mame/drivers/ sub-directories?


@vitorgalvao we have decided to keep it `Bitcoin-Qt.app` (in terms of the app foldername) to not confuse uses when they "update" (copy over) the app. Renaming it to `Bitcoin Core.app` would very likely end up by having two versions of Bitcoin-Core on your system if you once did (or will) use a different source than homebrew.


Iniciando


Done, thanks!


I'm not crazy about this heredoc, but it beats the hell out of a multiline string in HAML which looks like this

<img width="554" alt="screenshot 2015-10-01 14 19 30" src="https://cloud.githubusercontent.com/assets/3686887/10221629/796f9a04-6847-11e5-9657-7e6ca0b90ded.png">

Helpers are preferable to complex views when it comes to string interpolation and logic, but I'm not 100% sure what to do with fairly straightforward, albeit long _content_. I'm only having this dilemma because I've decided to be more strict about line length for this project. :pushpin:


ты удивишься, но первая строка в textarea окажется выровнена с первой строкой в input и spin не будет выбиваться ;)

но в целом если ты не разделяешь мнения, что у уровней заголовков есть еще оттенки смысла, кроме визульного размера, я умываю руки.


should we still check we end up on the right page, or not bother in this test?


Why we need workarounds if this can be fixed in source?
Issue arise, for example, in QuickSearch when I need to filter CRUD with "like" condition on all of its columns, but I don't know in advance is there some boolean type fields displayed in CRUD or not.


Yeah, ultimately we should add examples of our components here


Hey @solojavier for this ones, it is better if we have a rebase strategy when pulling, this way you ensure there is a straight line in our commits and also avoid having a 'merge commit', more info here: https://www.atlassian.com/git/articles/git-team-workflows-merge-or-rebase/


This needs a comment

// SwiftInfo contains....


@evilhamster I have corrected the cue sheet changes so could you check that out again, seems to be woking with my test data. Not sure why you are not seeing strArtists being populated with normally tagged data, can you give an example of that.


yes please


Yes I can:

![yii_kcu_select_1](https://cloud.githubusercontent.com/assets/4319814/10221830/f274e252-6850-11e5-9804-4e9ddcc4d21f.png)


Should this move to its own file?


Add hybrid analysis results


#test1
```c++
int main(){
     return 0;
}
```


Please don't ignore the error! It might happen if the user overrides `StorageUrl` or the server returned something mad.


Are the hard-coded paths for clang really necessary?


This test checks validation so I don't think it matters that the page it ends up on is `eligible`, so long as it's a different page, which `conditionalFormSubmit` does check.


It's interesting that you don't need to publish this service to angular at all...