The SUPERADMIN has explicit "view" access set for the recordset.
If no limits set on the other access levels for the recordset the SA can browse all records. But if limit on any of the CRM access levels is introduced (SA does not have that access level set for his user) then SA can see only limited records.
Better to reproduce:
For a selected recordset add some access rule limited by field value for an access level SA does not have.


I do that, see below.


Sorry, I missed it while decomposing the pull request.


Looks good


It's now fixed, just tried it out, thanks a lot!


Well it hasn’t been in any release yet anyways, so the only people who would notice are those who use development builds of Ceylon, where breakage is expected.


This is really just a corner case, right?  Do we *need* to have it in v1.10.1?


You didn't improve it... You ***broke *** it.


Hi,my friend,Thank you very much. If you are chinese friend,you can join the QQ group, NO.60831381. Thanks.


I will reorganize all the code gradually according to your recommendations: all dependencies will be defined before their actual usage. This should become a part of a code style so I will not change it right away.


Adding a class instead of some css would be cleaner, like:
`<li class="user-xxxx is-mentioned">`


Yes, I missed it.


Yes, it is.


So... what was accomplished???


`.fixed-table-container` is a `div` surrounding a Bootstrap table so I don't see how `.fixed-table-container.table-no-bordered` will ever be reached when adding a class of `table-no-bordered` to the `table`?

Is there anyway of adding custom classes to the `fixed-table-container`?


Shouldn't we do a zend_shared_alloc_unlock() before the return statement?


Well the `suppressWarnings()` annotation itself is already variadic.


now the url looks cleaner


I dont see what is broken


Of course all errors will be caughy behind pb barrier and sent as #rpberrorresp (I guarantee :-), but nonetheless.


Yes, and for similarity with `SeeAnnotation`, `AuthorsAnnotation`, and `TagsAnnotation`, I think it would be best if this class was variadic too.


You can use setRequestHeader only after `req` has ben `open`ed. This currently breaks document submission.

Additionally, my local server still complains:
```
WARNING in flask_seasurf [/usr/lib/python3.4/site-packages/flask_seasurf.py:281]:
Forbidden (CSRF token missing or incorrect.): /api/documents_migration
```


It's the same thing. the index.htm of a directory shows up when the directory is visited


My bad. The https://dpse.cf/login/index.html isn't the same as http://thel3l.github.io/hackathon-dpse/login/index.html

Missing elements.


Ideas?


My intention was to fix the breakage that tmux has been subject to for months. This is what this commit does.

I've made the changes a revbump and sorted the deps differently (commit 0771be8c73e2a72f13137411237a17ff342dac92)


Confirmed - working on that.


ah yeah - would jenkins-agent be better?


> furthermore referred to as "The Organization"

"The Organization" feels very Orwellian to me. Maybe we could refer to it as just Open Trust, as in:

> The purpose of the Open Trust constitution (furthermore referred to as the "constitution")

and

> The purpose of Open Trust is to provide a democratized...


still need to re-add cumin


I'd rather have a generic file path. For instance passed to the constructor.


Probably part of the build process @lee-houghton


@onox (and @thevirtualfer )
If it can help, to avoid onox writing again the same things.
Here is the link where onox (patiently) explained this for me.
http://forum.flightgear.org/viewtopic.php?f=4&t=25157&start=885#p239572

Then, to create a new branch in my (dany93) repo:
http://forum.flightgear.org/viewtopic.php?f=4&t=25157&sid=5bb041e931aab9fab8fb6d95f7b832b8&p=239753#p239750
By this way, I can make my changes on the second branch without messing my (dany93) master one, and give this link for my second branch to enable every one test it.


Hi, thank you! :)
Although the project is not mine (and i don't intend it to be), i just forked from https://github.com/dennylin93/rcguard because i needed to add the new larry skin and to upgrade to the new reCAPTCHA APIv2. Since there wasn't a commit in the last ~4 years, i thought the project was abandoned so i forked it. But in the last month there were some commits. I have to take a look at them.
And also, start tagging my stable versions.


Same for the magic. I have to take a deeper look at the existing RC over uart solutions but It would be a lot better to have something that is scalable to other systems.


IMO checking for self.files is still useful, because you can avoid breaking out of the for loop if there are no uploaded files. There can be file_fields without files being uploaded. In that case this procedure would not run at all, which is what we want.


saw approval from hmmr
at https://github.com/basho/riak-erlang-client/commit/40febd0e9d54008de22e578fc7f2e54c5dcb4d2a


merging basho/riak-erlang-client/bk-timeseries-empty-results = 40febd0e into borshop-integration-237-bk-timeseries-empty-results


basho/riak-erlang-client/bk-timeseries-empty-results = 40febd0e merged ok, testing candidate = 6933d382


Finish Readme


some django storage classes dont' support .path, particularly S3 doesn't.


wouldn't this be (name, owner) ? (since we select on both together)


Lewat postman lolos dan terkirim, lewat UT dapat,
``503 auth command used when not advertised```


Testkommentar


The default (after this commit) is to include last update times everywhere, and include sent info only on the all reports page. To maintain cobrands that might not want that change (Zurich/Bromley), use that new variable so they stay the same. I'm not sure where I'd put an `include_lastupdate` variable as it would be in all uses (for the default), which wouldn't help those two cobrands. I guess those two cobrands could define include_lastupdate = include_sentinfo at the top of their files, perhaps?


OK


I'm not sure, can you create composite indices/indexes? I'm a total C* noob


I think this e5f3571 got bit worse. Could please remove tabs and replace all of them by space ?


Fixed.

Thanks for catching that [😊]

________________________________
From: Kalle Sommer Nielsen
Sent: Wednesday, October 7, 2015 3:25:54 AM
To: mattficken/php-src
Cc: Matt Ficken (Insight Global)
Subject: Re: [php-src] heap based side-step OpCache with IPC (e11b6f0)

Shouldn't we do a zend_shared_alloc_unlock() before the return statement?

—
Reply to this email directly or view it on GitHub<https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fmattficken%2fphp-src%2fcommit%2fe11b6f010be7d48ed4e29f3a758dffc9acf586fd%23commitcomment-13635131&data=01%7c01%7cv-mafick%40microsoft.com%7c3f6de0a9492a40492d4e08d2cf01b0b5%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=mz2VBdJ3kivw4cYkKkTRaorKQYdEmRj8CjaV0Srk44k%3d>.


[Okio](https://github.com/square/okio) aims to replace `java.io` and `java.nio` in order to increase efficiency. Since this project already uses [OkHttp](https://github.com/square/okhttp) and therefore Okio this introduces no further dependency. Please correct me if I am wrong.


VCard


Don't use structured expressions, please replace this with ComplexConverter (in fact inheriting from ReflexiveConverter.List) and specify the aggregation functions through @DefinitionElement


Или я не поняла, или перед выдачей эксепшина совершается три попытки и в случае пост запроса и гет. Хотя по условию тз только для админа нужны были повторные попытки.


"Private XML Storage" sounds better IMO


bruh...


The commit seems to be missing the videomode.h file


Why not make it a computed field?


Warning only has one argument, not two


@LouisGac : exporting data in CSV is a MUST have more tahn adding class to question. And exporting data to CSV is done in a plugin actually ....


What would happen without this line? (106)


@Fablab-Sevilla/gh2sap He distinguido entre componentes que realizan diferentes funciones con dos subcategorías dentro del interface de GH: system y elements. Se podría añadir posteriormente loads y analysis.


It's the form in `base`, but just the error/multiple results in `fixmystreet` (as the form was already shown higher up). Perhaps if `around_index.html` was `around/index.html` and `_index.html` was `_main.html`?


Great!  Thanks.  That didn't dawn on me.  I'll keep and eye out on 26 and start adjusting the others.

Sent by Outlook for Android

On Wed, Oct 7, 2015 at 1:23 AM -0700, "Iwao AVE!" <notifications@github.com> wrote:
Thank you @hazendaz for your work!
I made some messy commits, but found out it was the server id in the settings.xml and the deployment is working now.
https://github.com/mybatis/hazelcast-cache/commit/d9cdbb8db9a08298c4a76d1b7e3482f55fae3e0c
We may have to edit the server id again when switching to parent-26 or later.

---
Reply to this email directly or view it on GitHub:
https://github.com/mybatis/velocity-scripting/commit/f34fe0b9d6d374b2a2484b0f418e138149843516#commitcomment-13632954


I presume you moved these to the missing videomode.h file. I don't like that, as it makes the drmModeModeInfo public via libkms++ headers. Having the libdrm structs hidden was the reason for these helpers.


So, before I can go on with review this commit you should force update it. Note: you should update only this commit and next one to keep safe our discussion in the previous commits.


apparently not.  it seems to be a sequential operation on filtering, so the first one (name) selects a data set, and the second one (owner) makes a further selection. Cassandra warns of unpredictable performance.


:shipit:


We shouldn't create a class for parsing common opts. We should have a class that makes parsing cmdline options trivial. Each app may have different needs for the options. We might have use for helper functions/class(es) to parse common options, so that the apps may optionally use those.


Better do it in one step:
```
        available_quants = [{
            'quant': x.id,
            'selected': x in move.reserved_quant_ids,
            'qty': x.qty if x in move.reserved_quant_ids else 0,
            'location_id': x.location_id.id,
        } for x in available_quants_ids]
```


It is not the way it is done for the other compasses. If you want to rotate your compass as a parameter, you can use the COMPASS_ORIENTATION param. If this is something that is board dependent, you should use the same method, which is setting MAG_BOARD_ORIENTATION. I know that there are more optimal ways to do that but I'd rather not have this kind of dispersions in the way things are done.


AggregationFunction.valueOf(string.toUpperCase())?


marry me %D


Nice :). I need to test on IE8 to see if the footer simply goes back to the middle.


yes, that's what HDEPEND is about in this case :)

but there's a bit more in some other cases: Package 'B' installs only .h for c++ templates. Package 'A' installs a library and headers including headers from 'B'. Does 'A' need to RDEPEND or DEPEND on 'B' ?
If DEPEND: you can depclean 'B' after installing 'A', meaning no package can build against 'A' anymore.
If RDEPEND: you can never depclean 'B', even if it is completely useless on a production system.


Looks so far good, but for directory separators (DS) you should rely on constant DIRECTORY_SEPARATOR which makes your code then portable to other operating systems which use another DS than a simple slash.

For `Mage::getStoreConfig('dev/minification/force_default_media_path')` use Mage::getStoreConfigFlag('dev/minification/force_default_media_path') as you are dealing with booleans.


##### добавь здесь вот это
```css
outline: none;
```


Looks fine to me. Stop pushing to master!


I've been using the style that simple getter methods are called the same as the member. So for example, class has "m_hdisplay", getter is hdisplay(). If there's a setter, it's set_hdisplay(). I think this style is quite commonly used. Whether it's better than using get_xxx(), well...

And not everything is using that style yet. The older code is still using get_crtc() etc. Then again, get_crtc() might be a better name for the method, as it's not just returning the value of a field, but it's doing more complex operations.


## This is a markdown file


FWIW There is [ngStorage](https://github.com/gsklee/ngStorage) which is an existing popular angular module for dealing with local storage.


all tests pass:
success: http://buildbot.bos1/builders/erlang-client-test/builds/161


I'd use SelectExpression since it involves functions.


I'm not sure this commit is good, a `PUSBListNode` may have multiple interfaces (depending on the `numIfs` value passed on the constructor) so the `setup()` method needs the interface number that is being queried for descriptor.


I'll pick this patch already to my tree.


The rotation should be set by defining MAG_BOARD_ORIENTATION like it is done for other boards.


Ah I think see what you mean. I guess I was thinking that it was still a valid, separate "option" for this partial, even though the current uses mean that `last_update` and `include_sentinfo` are synonymous.

Could you not keep a conditional in the base `_item.html` template (and pass it through as `1` in `_list-entry.html`), so that cobrands which wanted sent info but not the last update (or vice versa) just had to override `_list-entry.html` and set the relevant variable to `0`?

I guess you're saying that since the only current instances of cobrands doing something else are already overriding the `_item.html` template there's no point in that, but I feel like it makes it easier to understand if both options are there all the time. Otherwise, if I happen across Bromley's or Zurich's template in isolation, I have to understand that `include_sentinfo` actually does something different elsewhere, but this template is (ab)using it to mean something else.


Jfyi, I think we should ignore Lua for the time being. I recently pushed a change that Lua is not compiled by default, as lua was causing annoying warnings, and I hadn't tested any of the stuff with Lua I added to python.

I think we should now concentrate on python only, and later upgrade Lua parts, if we want to support it.


According to the travis Build history this commit is the root of all evil.
@MathiasMeuleman Please review this code changes to see whether this commit did indeed cause a chain reaction of failing builds.


sir did you delete the typeform javascript ?


Thank you for the Quick response. I am using Python 3, and PyCharm on Windows 7 32 bIt. There was some problem getting installed MySQL-python. But I have managed to do it.

Unfortunately I fall into an awkward category. You can call me a newbie to python flask. But not strictly so. I can digest advanced concepts as well. I had tried to run manage.py from PyCharm and seen the Usage information. But could not figure out how to do that. May be I am missing some point. Can you please give me a usage example, how to run it from PyCharm? (On Windows) rather than from a terminal.

Unfortunately the demo on amazonaws is NOT working.

Please help me out. Thanks a lot again.


What was the difference with those two again? At least the other one should be an enum.


yeah, that's an improvement for sure


This seems redundant to me, if the `plug()` method fails the node is not even added to the nodes list so the `getInterface(...)` method is never called.

Moreover, if you really want to check if a node is plugged successfully IMHO is better to check if the `plug(..)` method returns `false`. Otherwise the effect is that the modules seems `plugged` but it silently don't work, that seems weird.


I'm not sure the amount of memory saved in practice warrants the added complexity for every findPath-related method. The only case where any of these methods make a recursive call under normal circumstances is: if Monster A finds a path to Player, but monster B (allied to Monster A) is in the cell the path would have ended at for Monster A, then Monster A finds another path but considers Monster B's cell impassable on the retry. This should happen at most once with two monsters (one already adjacent to the player), at most twice with 3 monsters (2 already adjacent), 3 times with 4 monsters, and so on until all adjacent cells are filled. In the last case, a non-adjacent monster makes 4 or 8 recursive calls (4 for Manhattan distance, 8 for any other measurement) and then tries to find another target. However, if the player is surrounded by 8 monsters for more than a few rounds, in most games the player will be dead shortly thereafter...
There are some optimizations to be made in DijkstraMap, I'm sure. I'm not sure this one has a benefit often enough to be worth the added complexity. The ArrayList initialization to the path's length is good and simple though, I like that!


I know this one, but picked [store.js](https://github.com/marcuswestin/store.js) due to strong support for older browsers and automated fallbacks.

Right now I've noticed that [localstore is supported in all browsers that are supported by angular](http://caniuse.com/#feat=namevalue-storage), so probably I'll just stay with vanilla window.localStorage that is used right now.


Preferably kmsprint should not depend on libkmstest. libkmstest should be a helper library for tests, not "proper" tools. But we can clean up that later. And libkmstest is a .a anyway, so it's not visible to the end user anyway.


Тут я тоже не поняла, где момент, когда рандомное число rand(0..6) сравнивается с 3 и уже после выполняется то или иное действие.


Up to you, but I think it'd be quite a bit cleaner if you would pass the indent as a integer. And add a, say, iprintf(indent, fmt, ...) helper function which automatically indents the string.


see: https://github.com/imagej/imagej-ops/compare/update-cached-OpEnv?expand=1

@ctrueden does this help?


It is better to give more detailed names to commits, like "fix of broken scaffolds colors"/"fix of line styles in plotter"/etc
"small fix" doesn't make sense


But then I don't see how the speed is changed to match the cps? If speed = 1, and unit = 'c', then the sample should play at a speed to fit one cycle. If speed = 2, then it should play at a speed to fit half a cycle.

This api could be rationalised, but would need to be fixed in the old dirt too if we're still maintaining that..


No this statement is correct - but with this constant okio is no more efficient than nio and using it binds us more to okhttp/okio which is not needed in this case.
Also I think StandardCharsets.UTF_8 reads better than Util.UTF_8


:green_heart: Good use of the `FileReader` constructor here.


Oh no it doesn't.


This should return an enum.


```
Class<? extends SelectExpressionElement> SELECT_EXPRESSIONS = new Class[] { Attribute.class, Count.class, Avg.class, ...
public static class ProjectionConverter extends ReflexiveConverters.ListConverter {
   public ProjectionConverter() {
      super(SELECT_EXPRESSIONS);
   }
}
public static class SelectExpressionConverter extends ReflexiveConverters.ObjectConverter {
   public SelectExpression() {
      super(SELECT_EXPRESSIONS);
   }
}
```


:question: How do you specify the locations for the map?


Hi Stefan, are you planning any more tuning sessions on PassedFile?


Добрый день!
Очень признателен за статью.
"перимущество"->"преимущество"


It seems safe to ignore in the short term, but it should be looked at again if we want widgets or something in future.
http://jupyter-client.readthedocs.org/en/latest/messaging.html#messaging


@ismisepaul you moved the i18n props for SQL injection lessons and didn't update the challenge jsp reference...?


@Fablab-Sevilla/gh2sap al hacer la asignación de vínculos de este modo, o el componente accede a los datos de los puntos de entrada como lista y es capaz de asignar un nombre único a cada punto o el usuario debe suministrar forzosamente ese nombre para cada punto o los puntos con los mismos nombres acabarán con el mismo vínculo.

En este caso, el tipo de vínculo que se especifique con el nodo final será el que se le ponga a todos los nodos.


I have already added Rails.application.config.assets.precompile += %w( ckeditor/* )
and the files are precompiled in public/ckeditor but could not find the /javascripts/ckeditor/init.js file

looks like it is related basebath I guess could not fix it yet

var CKEDITOR_BASEPATH = '/assets/ckeditor/';


:yellow_heart: We're definitely going to come up with a better way to handle the custom styles for the events. This system will not scale.


We used "get" instead of "send" because `getInterface` is referred to the host request (otherwise we should reverse the naming of all the methods in the USB stack!). Moreover the return value is used on SAM and SAMD, so we'll keep it also on AVR.


i am not ready for this change.
LMK fail to release RAM when OOM already needed badly.
global MM code should be updated up to 3.12.y and only then it's should be ok.
revert all new shrinker API back to 3.10.y.


This is a forward declaration. Function declaration (as opposed to function definition) should be in one line.


Maybe move these parts to the file header...

````
Generated on Wed Jan  9 14:34:53 2013,
 by pycrc v0.8, http://www.tty1.net/pycrc/
using the configuration:
    Model        = ccitt
    Width        = 16
    Poly         = 0x1021
    XorIn        = 0xffff
    ReflectIn    = False
    XorOut       = 0x0000
    ReflectOut   = False
    Algorithm    = table-driven
````
(because not only the function is generated, also the table above)

... and refer to the website regarding the license of the generator


:red_circle: The indentation is a little off here. I'll merge this but you need to fix it. We should be beyond minor style problems.


Had missing pop just after `_put(put);`. This was shadowed by the globally application of `lua_settop(...)` in `~Selector()`


so exporting data to CSV should be coded in the core, or as a component.
plugins in general, and the plugin system in LS, is based on the observer pattern.
https://en.wikipedia.org/wiki/Observer_pattern
It's useful in certain situation, not all situations.

I think that you and samoussa just make kind of confusion between what a plugins is for and what components are for.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21973/testReport/) for this commit**


"Could you not keep a conditional in the base _item.html template (and pass it through as 1 in _list-entry.html)" – but what would I pass through for the templates that call _item directly (e.g. `around/on_map_list_items.html`)? As they want the last update time too.

 I guess it could flip and be a `no_lastupdate` variable, so that it's defaulting to 0.


Opening curly brace should be in the same line as an `if` statement. There are exceptions, but this is not one of them.


lol at this rate, youll end up with nothing


and i'd be just as happy..

On Wed, Oct 7, 2015 at 1:10 PM, un1versal <notifications@github.com> wrote:

> lol at this rate, youll end up with nothing
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/notspiff/screensaver.matrixtrails/commit/71bcee0356f4ce0e5ddded2ac8b8f621c4645f4b#commitcomment-13635827>
> .
>


rm -rf screensaver.matrixtrails then and be done :D


Если задавать ширину через атрибут width, то единицы измерения указывать не надо - достаточно писать 100. Но лучше все оформление выносить в CSS.


What a bad idea... a read_group in a loop...


FTR, if you set @depends, i don't think it matters where in the file it is.


github seems to have vanished my comment, I commented here:

We'll likely want to show the testkit for these, as in:

```java
TestRoute appRoute = testRoute(new MyAppService().createRoute());

    @Test
    public void testCalculatorAdd() {
        // test happy path
        appRoute.run(HttpRequest.GET("/")) // TODO add Host header here
            .assertStatusCode(200);

```


It's "Comparator" with an 'a', from "compare"


I honestly completely agree, it was more so because I didn't want this to be a monopoly thing but could also be used as a template for other trusts to come on board which is why I used the generic language. What do you think, still use "The Organization" or "The Open Trust"


For loop seems to work it repl.it but not in program...review that section


shouldn't these lines
```
$validateAttributes = $model->attributes;
unset($validateAttributes['captcha']);
```
not be
```
$validateAttributes = $model->attributes;
unset($validateAttributes['captcha']);
$validateAttributes = array_keys($validateAttributes);
```
or better be
```
$validateAttributes = $model->activeAttributes();
$key = array_search('captcha', $validateAttributes);
if ($key!==false) {
      array_splice($validateAttributes, $key, 1);
}
```
Otherwise the $validateAttributes array wouldn't be correct.


Here I expose two examples that allows me to search for a desired HTMLElement. But I've a question. What's better to implement? Duck-typing? or concrete-and-hard-path to element?


The test has a number of crashes that are suspect: https://groups.google.com/forum/?fromgroups=#!topic/fishcooking/2lp52yOF2KM


Will change. Thanks for the review.


why would i do that? it works just fine, even without a single setting.. it
inherited those issues from the original, i have just hidden them. you
could easily trigger all of these on xbox as well by editing that xml file.
it had no comments explaining the settings, so i blindly added them all.
some of them was for internal configuration, some for user configuration. i
exposed too many of the first.

On Wed, Oct 7, 2015 at 1:12 PM, un1versal <notifications@github.com> wrote:

> rm -rf screensaver.matrixtrails then and be done :D
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/notspiff/screensaver.matrixtrails/commit/71bcee0356f4ce0e5ddded2ac8b8f621c4645f4b#commitcomment-13635844>
> .
>


Hey,

Do you have any further plans to enhance this project?

It's a really good example and there are a few other bits that I feel could make it really useful:

DB connection
User registration
Upgrading Angular version

I'm planning on working on this myself also, so will probably send some PRs in the near future.

Thanks!


Missing callback here


Noooooo


sdfjskfsdfsdf


Hey,
Do you have any further plans to enhance this project?
It's a really good example and there are a few other bits that I feel could make it really useful:

DB connection

User registration

Upgrading Angular version

I'm planning on working on this myself also, so will probably send some PRs in the near future.
Thanks!


No, that was a very definite merge error on my part. How annoying that we don't use enums here.


the ckeditor gem has a task to copy files, see https://github.com/galetahub/ckeditor/blob/master/lib/tasks/ckeditor.rake

anyway this is a https://github.com/galetahub/ckeditor problem, like most of the issues on this gem


You already unlocked a few lines above it.


@guyharris
Thanks, I understand now.


Firstly, You must name commits right to changes.
For example you added some fuctionality you would name it and explain.
If you make down some code review and after that refactored code - you must right about it.
Do not use such things like version in commit message. It's useless.
The best way is write name (or number) of task ( I know that we're not using track-systems, but we will soon ).


Last minute change here... Now the script will scrape the workspace file, and compile all entities, so now it's unnecessary to be limited to 1 entity per file with the same name. Also,  we can use vhdl packages :)


This commit is being reviewed as a part of review issue #70.


If you have not created this database yet, how can it be open?


Update to man page was missing - filed as #105.


Divisible amounts are always in the format `"##########0.00000000"` (decimal mark + 8 decimal places), while indivisible amounts are always `"##################0"` (no decimal mark).


Partition data: RP_0.94_20151001_dd_2_Linux-Ext4.dd.xz is to big to be uploaded here.
The actual size of that file: 224.447.936 bytes
The content of that file is a Linux/Debian file image.


Can you see me


I'd like to see this in the RCBugFix / RC


That issue was reported by Paul, and no one else complained about that.
so I am fine to have it from v2.0.0 only


Should we namespace headers in some way? If we intend to parse the side files we probably will have multiple headers (not sure though)


:) Same pattern I'll show you in Spring-MVC (for web sites)


TBH I found [your own comment](https://github.com/git-for-windows/git/commit/ddf2c1980faa4228bc126961d60f5323a0738b03#commitcomment-13546638) rather demanding. So I guess we're even and can part ways amiably. Except that you continue to benefit from my work and I don't benefit from yours. Such is life, I guess.


Could you please remove the form permission for administrator roles?


These csv's should not be in this repo - refer the user to get them from JMSML (like the import domain steps do) - we definitely don't want to have to update 2 copies of this data (one in JMSML and one here) or have this extra copy causing confusion.


Do you know that method that will return result is better than modify in class variables?


It's not needed for `omniGetBalance`, but may be needed for `omniGetAllBalanceForId`.


**no-warning-comments**: Unexpected todo comment.


Sure but now its utterly FUBAR


You can definitively remove those lines if they come form openfisca ;-)


Same thing about void.
You must understand that is very difficult to test such methods, coz they are using encapsulated state.


uuid is really a message ID, right? So I think we should rename it. Picking some nits...


Bad idea to write comment like that. It's better to use JavaDoc.


LouisGac, you are confusing the communication pattern with the goal of
plugins.

Features that can be loosely coupled or replaced should be implemented as
plugins, regardless of the way we communicate with that code.
I 100% agree that the observer pattern is not always the best choice and
where applicable LS3 uses interfaces instead.

On Wed, Oct 7, 2015 at 1:07 PM, LouisGac <notifications@github.com> wrote:

> so exporting data to CSV should be coded in the core, or as a component.
> plugins in general, and the plugin system in LS, is based on the observer
> pattern.
> https://en.wikipedia.org/wiki/Observer_pattern
> It's useful in certain situation, not all situations.
>
> I think that you and samoussa just make kind of confusion between what a
> plugins is for and what components are for.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LimeSurvey/LimeSurvey/commit/b9536e41ad325ddc9e697325f78b2bc60cb350b4#commitcomment-13635751>
> .
>


Task should be called, set themes or similar, calling it save theme and giving the script a set for edit command makes no sense.


Same about void :)


I'm wondering whether this might cause a problem? I think that when using softlinks for this type of thing they need to be relative. Otherwise they are not going to be portable.


Этой строчкой хочу добавить стиль к фильтру, который у нас хранится в localStorage и отображается при обновлении страницы. Ругается на attr. Как правильно сделать?


Oh that's a good point, I'll meditate on that for a bit.


not true


I'm confident this was an error on my part in the original patch. Thanks @vlsi for identifying it.

The only thing that surprises me is that, given this oversight, it's been working happily for so long. I validated the original batching in wireshark and with debug message tracing, and I know at least one site that's been using it.


Why the extra pass? Though I cannot claim it won't work...


I would use the new method sol_buffer_ensure_nul_byte to add the '\0' at the end of the buffer if needed.


This ("GET_PARAMETER" string) is somewhat strange - please change this to get the parameter before the call and pass it into this method to remove this strangeness & the external GetParameter dependency


Fixed in #380 by @vlsi, no further action required here


I think `url` has to be a plain string, because we don't enforce the actual use of it. While it's intended to be used with URLs, or URIs, it could really be anything.

Using `PropertyType` is an interesting idea. Not really sure..


See other comments concerning this "GET_PARAMETER" usage


No fixing that, unless we want to inject our css ourselves which impacts performance and all that.
Also, it is fine like this.


Test code in with the production code? That seems wrong. Was this meant to still be there?


It doesn't make any sense having a `local` option and still to display the timezone offset, espespecially with ISO 8601. This information gets redundant in the output.


:thumbsup:


Please remove this extra tooldata copy


It should not be necessary to specify sudo for each command - you can specify that the entire role should be run with sudo. It's not super important, so decide if you want to fix that or not, and let me know.


TeamCity Dirigo Edge :: Pull Request Smoke Tests [Build 86](http://teamcity/viewLog.html?buildId=1232&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 4 Build time: 00:00:44


Also please provide the direct link of where to obtain in JMSML (the sample folder)


attr — это из jQuery, тебе нужен setAttribute (https://developer.mozilla.org/en-US/docs/Web/API/Element/setAttribute).


This was a solution out of frustration last night, but I still have hope the `CheckBoxPreference` will actually listen to the `android:color` selector if we add the android support library v7.

According to the documentation:
# v7 Preference Support Library
>The preference package provides APIs to support adding preference objects, such as CheckBoxPreference and ListPreference, for users to modify UI settings.

The other solution is to create a custom layout just for that checkbox, which I think is absolute overkill.

So the question, regarding whether or not this will work for you @aldenml is, now that the app is compiled using SDK 16, is it possible to use the v7 version of the support library? I'm having a hard time understanding what are the requirements of these libraries, I'm not sure if the 7 in v7 stands for SDK 7, or if it is simply the version number they have, can't find anything on the documentation about sdk requirements.


thanks a lot alepore, at last it works


Whoops, good catch.


@neoatomic add that link to wiki please - if is not


I think this function shouldn't be there, should it? It seems to match exactly the method in Actor, which it is overriding. And it touches internal variables of the actor which is a bit naughty...

Ditto for the later `__str__` implementation too.


See this [pull request](https://github.com/wp-cli/wp-cli/pull/2113) why a change was necessary.


in any case I believe we should stick to this user experience.

I've noticed in videos, users were thinking that having seeding turned off, but seeding with Wi-Fi only was letting them seed, this solution will not present any ambiguities on what's possible.


default from xbox version restored.

On Wed, Oct 7, 2015 at 1:26 PM, un1versal <notifications@github.com> wrote:

> Sure but now its utterly FUBAR
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/notspiff/screensaver.matrixtrails/commit/71bcee0356f4ce0e5ddded2ac8b8f621c4645f4b#commitcomment-13636026>
> .
>


Да ё-моё) Поправила, работает!


Das `pre-up ip link add` brauchen wir glaube ich nicht mehr, das sollte dadurch erledigt werden, dass jetzt als erstes das Dummy-Interface für das Batman-Interface, dann das Batman-Interface und dann dass Bridge-Interface direkt mit dem Batman-Interface als Slave erstellt wird.

Die `post-* ip -6 rule` müssten immer noch irgendwo angebracht werden.

Das mit DAD schrieb ich ja bereits weiß ich nicht mehr, warum das wichtig war.


Agreed. Assuming it "works as advertised", we should back port it.
But I want to be cautious about back porting "features".
Before adding something to the RC, I'd at least like to have confirmation that it works, without adverse effect, in "dev".

Those who are using "dev" should be expected to be willing to work around the occasional "that feature broke ..." issues and select some other compilation of source with which to experiment. However, once we get into the Release series, we need to make sure that we are not introducing any new bugs.


Did you start working on in 2013? If not then the date range is not needed


At the moment we are not using dynamic ftrace, so we do not need mcount.
Indeed ARC won't work with dynamic ftrace since BP are more than one byte.

Noam

From: Vineet Gupta [mailto:notifications@github.com]
Sent: Tuesday, October 06, 2015 4:31 PM
To: EZchip/linux
Cc: Noam Camus
Subject: Re: [linux] tracing: Fix for non-continuous cpu ids (c58ee43)

thing is working ftrace requires mcount support etc which i don't think works completely.

—
Reply to this email directly or view it on GitHub<https://github.com/EZchip/linux/commit/c58ee43eb1dd871146deca401d3fdbf46292d57d#commitcomment-13614817>.


oh. Maybe it's my bad, but I was having trouble calling `get_pins` without arguments on either `client` or `client.me` (see screenshot).

The way I tested this was to create a short runner file that looks like this:

```
require 'pinterest-api'
require 'pry'

ACCESS_TOKEN = "MY_TOKEN"
client = Pinterest::Client.new(ACCESS_TOKEN)

binding.pry
```

and with that I got this:

![screen shot 2015-10-07 at 7 30 54 am](https://cloud.githubusercontent.com/assets/4871664/10336258/718efd5c-6cc5-11e5-8150-11e56f9bdf2c.png)


@Wackerbarth
Would you please be so kind to return to do PullRequests instead of committing directly.
I'd like to have a chance to follow your work without searching for it.


Typo in assert output. Word missing between "to" and "from".


This should be `<rsc>` as per #106.


You are doing this for all ARC cores / platforms - this needs to be EZChip only - but that's the least of my worries with this patch.
How does this help perf exception handling. In a pathetic corner case, a new perf exception can still be taken (due to some counter overflowing at wrong time) after u entrt the new exception. And that would cause a machine check due to nested exception. Plus any genuine exception could also trigger perf exception - while the handler has still not done early RTIE. Exceptions can't nest on ARC cores and making perf do an exception didn't seem like a good design to me !
BTW regarding bus errors - they are always imprecise - e.g. we saw this on real h/w in a different context. user space does a ST to invalid address, and right after does a syscall Trap. By the time bus error comes back (and cpu raises bus error exception), kernel is already starting in EV_Trap (but not yet reached early RTIE) - so again exception taken while already in exception - causing a double fault.


Thanks for adding this feature!

I've just had a 10 minute look at the change and have some remarks:
- For legal reasons, we need you to add your name to the AUTHORS file
- There is a typo in the method name: getTypeAgrumentsCount should have been getTypeArgumentsCount. Also, the local variables contain this type
- Great that you also updated the documentation and tests
- The white-space formatting and imports have also changed. To make it easier to see the actual changes in a diff, and later for tracking modifications, it would be great if you can restore the original import order and whitespace as much as possible.


Switch this to the JMSML data/path


please fix the comment


I have x64 installed (incl pyOpenSSL 0.13 for python 2.7) and errors still occur...

Date: Wed, 7 Oct 2015 03:06:15 -0700
From: notifications@github.com
To: SickRage@noreply.github.com
Subject: Re: [SickRage] Try and fix Kat searching (52e90e7)

@ArmandH I had the same problem; running on windows 8 64b with python 2.7 32b. Installed pyOpenSSL:

https://pypi.python.org/pypi/pyOpenSSL/0.13. I installed pyOpenSSL-0.13.winxp32-py2.7.msi. SSL errors are gone and SR is back up and running.

—
Reply to this email directly or view it on GitHub.


Simple fix without PR and changelog (test case only, '66.249.66.1' seems to be frequently unresolvable)


Oh ho, it fixed my problem. Thanks a lot dude....


Fixed with 5c79083bec6a57646ae830506f3a907e58ebfdde


JFYI .. I am testing DEFAULT_USE_FB_NOTIFIER = 1on yu_msm8916 and it's working fine; no reboots with ambient mode so far :)


`TitledIntEnum` probably makes more sense since we'll most likely show the status e.g. in the registration list


Hi everyone,

Thank you for the input, we will migrate the other coa asap :)


yes


Not needed any more?


This list justWords doesn't get used anywhere. It's scoped to inside the try {} block because that's where it was declared. It seems like you're going to want to use it, though. Do you need to move the declaration outside of the try block?


**no-undef**: "describe" is not defined.


I don't think we should have a default value here. I can't imagine any case where we want to create a registration without explicitly setting the state (depending on the regform config).


I gave this a quick look and the above should be changed prior to me testing this out & doing further review.  Mainly:

1. getting rid of the references to tooldata & changing to JMSML folder references
2. removing the csv files from the repo
3. updating the impacted steps.

These changes must be made prior to continuing with review/verify.

On the subject and just for clarification/background "Tooldata" is usually some configuration data required for the tool to even work (like an app.config), not the data the tool is actually acting upon (so maybe we should call this ToolConfigurationData, but this is @mfunk 's convention) - but it is important to understand this distinction with our tools.


>> I think your warning is a nice idea, but I'd rather it go further and raise rather than warn

That would fine with me. Either way (warn or raise), it would then become immediately clear.


You're on the right track. Do Maps make sense to you? Especially, keys vs values? That's important for this exercise, actually it's why I wrote this exercise.


    sa.Index(None, 'registration_form_id', 'email', unique=True, postgresql_where=sa.text('state NOT IN (3, 4)')),

(and a similar change in the model of course)


hi
i downloaded zip file and extract after that when i open udemy-dl.exe then black window open for only 2 seconds and close automatically
plz help me about this

thanks


This is to hold the appendix A related material


Merge conflict markers?


**no-warning-comments**: Unexpected todo comment.


That looks much better. Ready to merge? I will still want to you to add some docs, test of the result (a simple test which checks that the engine compues what the analytical solution says), and we will improve the interface together -- such as, I think, it will make more sense to use DemField::gravity for gravity and orientation, and only give a point on the liquid surface.


I should have tested this more thorougly -- this breaks creating new lectures by just typing their name. Expect a fix soon.


I think Lucas won't like your `'''` :wink:


这是什么东东？则么用啊


this makes things sort of usable but

Columns cannot go over 100 or below 10 at around 10 you get a very wide and very short character. Over 100 your character is tiny.
Rows cannot go Over 100 either or below 10 because it also affects width/height of character.

You also never really get the amount of rows set.

things just go weird and minuscule at anything above 100 because rows never really increases and character size goes smaller and smaller

Both rows and columns affect character size which character size should be no less than ~40 (or better value) pixels for a HD screen.

Default settings are not OK for HD screens, perhaps for XBOX but not a HTPC.


Thanks for the explanation! I did my feedback in an uninterpreted manner, without considering what `findPathLarge` does exactly. So now I understand it's a bit overkill.


Hit a couple syntax errors in views.py with this.
Unneeded parens on 48 and 65, and misindented try on 58.
Seemed to work fine after fixing those.
Seems a little too minor for a pull request so I'll just leave a comment.


Could you just change this to:

env: NUMPY="git+https://bitbucket.org/pypy/numpy.git@2.6.0#egg=numpy"

so that we know it is not a randomly selected commit but a stable release?


hfghf


replace with CompressionPluginSnappy?


jojom-7cores has contributed to about 10 crashes(even though it shows some other machine against the crash)...
I'm not able to reproduce it myself and it doesn't seem to occur on Joerg's 7-core machine.
The test is currently running at ~8 ELO so I just want to see if it sustains at that rate for longer duration even if it sees a few occasional crashes.

This is more of an experimental run. I don't intend to raise a pull request with this patch.


The struct is not public. The class is defined the same way as the rest of class containers for drm structs. However I added a declaration (not definition) for struct _drmModeModeInfo for convenience. I'll push shortly a new branch with videomode.h included.


I would love to understand these things so I could instead of complaining actually fix it.


Good catch, thanks !


CompressionPluginSnappy.cc ?


@clebergnu this wont detect the inherited `test` methods. Question is whether we want to do something with it.


then please find something suitable and send a patch. i am overworked as
hell at work, and  this nagging on top of that is becoming too much, it's
very hard to keep my cool..

the ranges for the rows/columns is specified in settings.xml.

the defaults for those non-settings are set in CConfig::SetDefaults() at
the end of main.cpp

On Wed, Oct 7, 2015 at 1:48 PM, un1versal <notifications@github.com> wrote:

> this makes things sort of usable but
>
> Columns cannot go over 100 or below 10 at around 10 you get a very wide
> and very short character. Over 100 your character is tiny.
> Rows cannot go Over 100 either or below 10 because it also affects
> width/height of character.
>
> You also never really get the amount of rows set.
>
> things just go weird and minuscule at anything above 100 because rows
> never really increases and character size goes smaller and smaller
>
> Both rows and columns affect character size which character size should be
> no less than ~40 (or better value) pixels for a HD screen.
>
> Default settings are not OK for HD screens, perhaps for XBOX but not a
> HTPC.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/notspiff/screensaver.matrixtrails/commit/270ea29dc77695cda255b5073534c0e21127a033#commitcomment-13636403>
> .
>


This seems to be great!


```python
class First(Test):
    def test(self):
       pass

class Second(First):
    """
    :avocado: enable
    """
    pass
```


don't really like the new format compared to the older ones. that parenthesis for Turbo , Unlimited and Slomo suited well :(

I like the change of state -> slot  though.


<import file>


Wow!, now i can build and tested on this project nice work.


Do you mean to move these to a file header named crc.h or obdconfcrc-generic.h; as these tables only would be used for the generic implementation of the CRC calculation. Or would you prefer to move the generated crc.h and crc.c with the MIT license to contrib/crc/ directory and use them from there??


What is the reason for this change? Is it required for newer gcc? Does it have any (negative) effect on code size?


Thanks for fixing it.


**Code Quality: Nitpick**

No semicolons in Python.


아뇨 조금씩은 하셔도 돼요 ㅎㅎ


Right, I meant declaration. I would like to keep the public kms++ headers free of drm declarations, or any other declarations that are not used by the public API. That said, the declarations don't do much harm, it's just matter of keeping it clean.

It's a bit annoying that in c++, to have class private members, you need to publish those members via the headers.


This would break compilation with JEENODE defined (status variable is used before being defined). Can you, please, move it to #ifdef to keep both variants compilable? In the future, we need some better approach, I don't like #ifdefs, but for now it's the best we have.


Not sure why we are using this one anyways and not one for example.com


**Code Quality: Nitpick**

It's best not to generalise exceptions.


I like this better. It keeps the params generic, and handles differences at the base class level.


`_scheduled` means "this greenlet is currently either running, or was running but is blocked on IO and so does not need to be restarted". I'd much rather there was a comment saying this for maintainability (unless I have misunderstood).


I updated the test with copied code snippets from http://www.chartjs.org/docs/


You probably didn't remove/move SnappyCompressor.h from src/compressor folder. Thus Git detects this change as new code insertion instead of move...


because no reverse for example.com


Thank you! :smiley:


```go
tl.getListInTab(tab)
```
でとってこれる？


Please don't add python3_3 to new ebuilds, it has been announced for deprecation.


I think that self.FAMILIES should not be defined as a single list but there should be a separate fallback family priority list for every common network family. In case when DEFAULT_FAMILY is not common, fallback list will be empty. This seems like a more versatile approach.


missind `|| die`


missing `|| die`


Small nit - I'd prefer to use `if (!resource.lastUpdate)` as more idiomatic JS.


Need to mention the new behavior of `load()` in the docs at the top of this file.


nice, i have a test now that shows that this does what we think it does


Are you sure this is needed? If you have an application/json formatter and and applications/json+hal formatter each one should do the correct thing, no? Meaning if you request application/json, this formatter shouldn't even come into play. One the  other hand I do know that people who aren't used to specifying the content type are often surprised by the response they get. I am just not sure this solution is encouraging correct behavior


Is missing "%" prefix...


bash nitpick... everywhere else you have used "real" bash syntax, as in `[[ foo == bar ]]`... would probably be cooler to be consistent


As you mentioned earlier, I should consider using JSON Schema. This should help with allowed DEFAULT_FAMILY values, I will limit possible values to socket.AF_INET and socket.AF_INET6.


bad merge, everythings fine on head


Suppressing the PRINT_NOONS and WRITE_NOS options breaks the SCF.


Note that the same `resolve` object is passed to all routes, not just the one that uses `WidgetController` - ie. the individual annotation view and the stream. That doesn't look like a problem, since they all need session state, but something to be aware of.


You probably don't need this one.


Darkness' Caress:
	The world-wide well-known on-line game.

Rpg turn-based on-line game featuring:
Live saving any progress done, so even if you disconnect suddenly, progress will be stored.
Unlock characters, armor, weapons, skins and so on.
World-wide ranking, so you know how bad you actually are.
Tutorial for the damn noobs. Everyone hate noobs.
Create your very own account, so you can add friends, stat-tracking, etc.
You can chat with people on the same instance of map, or if you add them to your group, even out of it.

The web will be able to:
Check everyones profile: including level, equipment, number of matches, etc.
Create & manage accounts.
Chat with in-game players.

Server side:
Database storage for every important data.
Matchmaking with players, or IA.
And more!


I don't think that it is necessary to add the crc.c and crc.h as extra files.

Just move the part giving information about the generation to the `obdconfcrc-generic.c`'s file header. Then we are done :)


Well, yeah, I'm not a big fan, let's say this. But it's OK given that's on triple quoted strings.


got it

2015-10-07 16:04 GMT+08:00 Jim Huang <notifications@github.com>:

> We have to compare the performance between the original and the optimized
> routines. Thus, keep the consistent main.c is critical.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/poa1006/phonebook/commit/e3b4b2e4219d54e2232584cc6b9f7e2a47e5d31f#commitcomment-13632624>
> .
>


Created new issue: https://github.com/yandex/mastermind/issues/15


Sure.

shoutbox table should be like this:

user_id MEDIUMINT(8) UNSIGNED, Not Null, default to zero
message VARCHAR(480), Not Null
timestamp MEDIUMINT(10) UNSIGNED, Not Null, default to zero
irc_print TINYINT(4), Not Null, default to zero    <===== should be
deprecated

2015-10-07 11:19 GMT+02:00 Tobias <notifications@github.com>:

> @Kail72 <https://github.com/Kail72> can you please specify the needed
> changes?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stfc2/UI/commit/a50dc259b85e3a070f5bd8d8223373201f372779#commitcomment-13633989>
> .
>


asdasd


#### asdadsasdasd


要不先改成“之前”“之后”吧。


Nope. Before methods return `void`. Let's JUnit *magic* work. Check this example http://examples.javacodegeeks.com/core-java/junit/junit-before-and-beforeclass-example/ .


gtyjryjyjyrjy


Wouldn't "Limiter: Off" be better? Saves space, and an "unlimited limiter" is a bit redundant. Also, yeah, the capitalization should be kept, because it looks messy without it.


I see!


No i am getting:
```
lib/valueflow.h:33:23: error: variable ‘ValueFlow::CPPCHECKLIB ValueFlow::Value’ has initializer but incomplete type
     class CPPCHECKLIB Value {
                       ^
lib/valueflow.h:34:5: error: expected primary-expression before ‘public’
     public:
     ^
lib/valueflow.h:34:5: error: expected ‘}’ before ‘public’
lib/valueflow.h:34:5: error: expected ‘,’ or ‘;’ before ‘public’
In file included from lib/valueflow.cpp:19:0:
lib/valueflow.h:36:44: error: ISO C++ forbids declaration of ‘Value’ with no type [-fpermissive]
         Value(const Token *c, long long val) : intvalue(val), tokvalue(nullptr), varvalue(val), condition(c), varId(0U), conditional(false), inconclusive(false), defaultArg(false), valueKind(ValueKind::Possible) {}
                                            ^
lib/valueflow.h: In function ‘int ValueFlow::Value(const Token*, long long int)’:
lib/valueflow.h:36:48: error: only constructors take member initializers
         Value(const Token *c, long long val) : intvalue(val), tokvalue(nullptr), varvalue(val), condition(c), varId(0U), conditional(false), inconclusive(false), defaultArg(false), valueKind(ValueKind::Possible) {}
                                                ^
lib/valueflow.h:36:192: error: ‘ValueKind’ has not been declared
         Value(const Token *c, long long val) : intvalue(val), tokvalue(nullptr), varvalue(val), condition(c), varId(0U), conditional(false), inconclusive(false), defaultArg(false), valueKind(ValueKind::Possible) {}
                                                                                ^
lib/valueflow.h:36:214: warning: no return statement in function returning non-void [-Wreturn-type]
         Value(const Token *c, long long val) : intvalue(val), tokvalue(nullptr), varvalue(val), condition(c), varId(0U), conditional(false), inconclusive(false), defaultArg(false), valueKind(ValueKind::Possible) {}
                                                                                ^
lib/valueflow.h: In function ‘void ValueFlow::setKnown()’:
lib/valueflow.h:74:14: warning: no previous declaration for ‘void ValueFlow::setKnown()’ [-Wmissing-declarations]
         void setKnown() {
              ^
lib/valueflow.h: At global scope:
lib/valueflow.h:78:24: error: non-member function ‘bool ValueFlow::isKnown()’ cannot have cv-qualifier
         bool isKnown() const {
                        ^
lib/valueflow.h: In function ‘bool ValueFlow::isKnown()’:
lib/valueflow.h:78:14: warning: no previous declaration for ‘bool ValueFlow::isKnown()’ [-Wmissing-declarations]
         bool isKnown() const {
              ^
lib/valueflow.h: In function ‘void ValueFlow::setPossible()’:
lib/valueflow.h:82:14: warning: no previous declaration for ‘void ValueFlow::setPossible()’ [-Wmissing-declarations]
         void setPossible() {
              ^
lib/valueflow.h: At global scope:
lib/valueflow.h:86:27: error: non-member function ‘bool ValueFlow::isPossible()’ cannot have cv-qualifier
         bool isPossible() const {
                           ^
lib/valueflow.h: In function ‘bool ValueFlow::isPossible()’:
lib/valueflow.h:86:14: warning: no previous declaration for ‘bool ValueFlow::isPossible()’ [-Wmissing-declarations]
         bool isPossible() const {
              ^
lib/valueflow.h: In function ‘void ValueFlow::changeKnownToPossible()’:
lib/valueflow.h:90:14: warning: no previous declaration for ‘void ValueFlow::changeKnownToPossible()’ [-Wmissing-declarations]
         void changeKnownToPossible() {
              ^
lib/valueflow.h: At global scope:
lib/valueflow.h:94:6: warning: extra ‘;’ [-Wpedantic]
     };
      ^
lib/valueflow.h:99:1: error: expected declaration before ‘}’ token
 }
 ^
Makefile:418: recipe for target 'lib/valueflow.o' failed
make: *** [lib/valueflow.o] Error 1
```


Wait, I didn't observe this *spilling* (huh?) error..


Yep, since the original string is in triple double quotes, I just went with triple single quotes, which are, IMHO, less ugly then escaping them.


I don't know much about git, can you give me a hint on on how to do this do correct the pull request?


It will detect *any class* that as ":avocado: enable|disable". Inheritance is not the issue here IMHO.


Yeah that did occur to me. I hacked this together to get it working quickly with little regard for good style :)


Probably c_str is inefficient operation - it has to rebuild the list of buffers to continuous data block. I suggest to find the way to feed zlib with those data blocks  stored in the input list.


Change is not avaliable on npmjs.com (Version 0.0.8 does not include it)


Alexander really cares about feedback app:)


The file header currently is obdconf.h. As the implementation for some platforms in future may change (hardware CRC support), adding it in the header would make the header non-generic.


@snikolaidis Why did this get commented out in this commit?


I can of course use void * instead. The declaration is there only to allow constructing a Videomode object from  drmModeModeInfo pointer. The same can be done also with void pointer, and the constructor can be made protected, so it can only be used from within libkms++.


testing the version control system


https://github.com/eHealthAfrica/kazana-raw-data/commit/de2d3e5cbf0a4dc15d312d56ade72728a7bde621#diff-3b5b7d85c37c8992bbfb50b3f0dee258R58
passes with this patch, fails without it


chuckster53 thanks for your interest. This is mostly finished, but still a work in progress. I am still working on getting the Sunset/After Dark functionality ironed out. Thanks for the feedback on the bug, I have corrected that and updated the file.


Yeah good point, I haven't done low level c stuff before so I kind of just hacked it in until it worked. I figured there'd be some issues like this with it.


In erasure-code bufferlist is used via c_str, but I'll see. what else I can do here.


Shit, someone's checking my code! Automated testing would have fixed this, and that's on the agenda for tomorrow, once the user permissions and signup is complete (it's hard to test code for users without users...)


@flavour Is this good for merge?


Need additional method to return compression method type


You've been going hard, I'm impressed - loving this project and github.

Might be time to implement a package stylesheet before we hardcode too much CSS.


I was planning on adding titles as we need to display them.


Yes, it is needed for the correct eeprom layout. Codesize difference is 4bytes bigger with this option, but OpenHR20 doesn't work without it on gcc > 4.7. I'm using avr-gcc 4.8.1 at the moment (debian jessie).


True! Thanks man. I'm addicted to Github. It just lets me practice my skills in a professional way while meeting people. Fun as hell.


This is a bit of a departure, a CAS loop is expected here and an early exit is not necessarily doing anyone favours. For now I would re-instate the loop and consider the fail fast option as a separate API.


Save my day too!! Thanks!


Well it is, because you must specify not only class, but also the `test*` methods. The `Second` itself has no `test` methods, thus there is nothing to run.

But when you try loading the module, you'll find out there is one `test` method, but since avocado is not loading the module, it simply ignores this test.


Agreed, created an issue: https://github.com/yandex/mastermind/issues/16


You should see the new database I implemented in the PR pictures near the bottom ;)


Don't you have a mem leak on c_out?


Void * is much worse =). If the function using drmModeModeInfo must be in a public header, then declaring it is the right way.

But I think the functionality to convert from/to drm videomode can be in a separate internal header, as it is now. Or is there something particular that requires the use of a constructor for the conversion?


I am trying to emulate how stackoverflow.com does things here.


I was following the principle of least privilege. Unless expressed otherwise, the registration has to be approved. I don't have a strong opinion here, so I could change it if you insist.


Таймаут и количество попыток указывается в вызове методов get и post.
Для админских данных в файле app/services/buying_process/admin_data.rb:
connection.post(path: '/todos', tries: 3, timeout: 3)
Для клиентских данных в файле app/services/buying_process/customer_data.rb:
connection.get(path: '/photos', params: { id: photo_id }, timeout: 3)
Количество попыток по дефолту равно 0. Таймаут по дефолту = 3


... actual results:

INSTRUMENTED /tmp/test.py:First.test

expected results:

INSTRUMENTED /tmp/test.py:First.test
INSTRUMENTED /tmp/test.py:Second.test


Wow, good notice mate! I commented the line for testing purposes! (because the dashboard was entering the woocommerce configuration all the time). One sec to remove it, thanks!


This commit makes sense. :+1:


ha


:shipit:


My mistake, I think it should be:
```javascript
forage._dbInfo.version = dbInfo.version;
```


Getting rid of the default would simply result in an error if you don't specify it. So no bad surprises can happen ;)


관련문서 : http://uwsgi-docs.readthedocs.org/en/latest/Upstart.html#what-is-die-on-term


Keep expect. Wrap these tests with mock into a separate context.


Do you mean like:
```kotlin
class A {
   val prop: (<!UNSUPPORTED!>@field:Ann<!> Int)->Unit = {}
}
```
?


Actually, there is a chance that we may want to add drm structs to libkms++ public headers: in some cases the application could get drm structs from some other library, and needs to convert them to libkms classes.

But then, we have no such needs at the moment. I'd rather do that only when we actually have a use case, and know what the circumstances are.


@hasufell thx for the review, fixed (I hope)


Android four square source code


My mistake, it should be:
```javascript
forage._dbInfo.version = dbInfo.version;
```


@*Globale ID*-Änderungen: Müssen wir jetzt in OSM die ganzen entsprechenden `ref:IFOPT` tags updaten, oder?


I have tried out `$CmderModulePath = Join-path $PSScriptRoot "psmodules/" -ErrorAction SilentlyContinue` but the error is still visible.
The cause: `Get-Help about_CommonParameters` mentions that ErrorAction parameter is ignored on terminating errors like when command parameter is empty or null :
```
The ErrorAction parameter has no effect on terminating errors (such as
missing data, parameters that are not valid, or insufficient
permissions) that prevent a command from completing successfully.
```
Could you give me an example when longer loading times will happen? What setup I should do? Because I did not find any loading speed change using my suggested modification. I have a bare PowerShell v2.0 installed without any external modules.
I would like to leave the decision to you, because I do not use PS on a daily basis, I only found this issue because PowerShell was the default shell start when running Cmder v1.2pre. So I reported it.


I tried leaving the function where it was with the extra @depends calls, and PHPUnit failed, so maybe the order does matter.


Once the SectionWho is added the is_first_visit will need mapping.

let new_returning_visits = data.article.is_first_visit.map((d)=> {
  return {
    is_first_visit: d[0] ? d[0] : 'Unknown',
    views: d[1]
  };
});


Thats cool! :+1:


Well, when the goal is not to interact with an event, but rather to bring a set of functionalities (eg: export CSV), a core update or a component suit better.


what does not work?


Сравнения этого нигде нет.
sleep(Random.new.rand(0..6)) и сам запрос connection.get(path, params) находятся в блоке, который передаётся в метод execute_with_timeout. В этом методе блок выполняется внутри конструкции Timeout::timeout(timeout) { block.call }, если блок не успевает выполниться за заданное время (timeout), то кидается исключение Timeout::TimeoutError.


I think this has the potential to now raise `ResourceConflict` errors where it previously didn't. is that known/handled?


You should make this idential. USBCore and Pluggable USB/HID. Decide on send/get but dont mix pls.


I believe you are correct that we would want to wait to commit the transaction until we are sure that all copies and queries were successful. Shouldn't we be able to just move L209-210 prior to L206? Thus if a sql statement results in an error, the touch and commit will never occur.


when you name the file xblock.py, it's unable to find xblock.core etc.


Still not 100% confident on `private` vs `protected`. What does this mean for `ChannelImpl`'s subclasses? Will they just call the parent's implementation + not need their own `eventNameToListenerMap` attribute?


Functions **clone-git-repo** and **clone-hg-repo** could be refactored. Aside from a line, the code is the same


For reference, this is old code. Please see updated commit from https://github.com/republic-analytics/luigi/commit/9787270c8457c969cd673ecdd81b8da892eca846


Good catch! This is actually a nice "feature".


`StandardCharsets` has been [added in API level 19](https://developer.android.com/reference/java/nio/charset/StandardCharsets.html). This project uses minSdkVersion 14.


a


どうだ？


I cannot specify the keys to be returned because "inventory" is a pluggable module and can be supplied externally. I prefer to specify the certain format that I expect of the returned result.


どうだ！！


Lgtm


Unknown ID is meant for requests for specific a entity w/ given ID. There should probably be added a `ERROR_UNKNOWN` constant—as these errors that occur on DB save are unknown and unexpected.


Please remember that there is also the Database repository. Any modification should be commited there.


Is it still valid?


Cierra issue https://github.com/InspectorIncognito/androidApp/issues/24


Powinno być raczej wypisanie zmiennej "Wynik", a nie "Element".


Using plugins as system extensions, is there any documentation/spec for that?


ci:retest


@eloyesp What do you think about to combine the two alternatives?
The result would be something like:

```ruby
def gravatar_url hacker
  'http://www.gravatar.com/avatar/' + md5(hacker.email)
end

def current_hacker_gravatar_url
  gravatar_url current_hacker
end
```

Because now we need the second method but maybe in the future would be usefull get the gravatar of any hacker to use it in a hacker list, or make a reference to other hacker for some reason.


Olle, there are some remnants in the wiki. If you have specific questions
ask me on skype sam_mousa.

Note that for LS3 there will be some changes to plugins (and they are in
the wiki as well)

On Wed, Oct 7, 2015 at 2:30 PM, olleharstedt <notifications@github.com>
wrote:

> Using plugins as system extensions, is there any documentation/spec for
> that?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LimeSurvey/LimeSurvey/commit/b9536e41ad325ddc9e697325f78b2bc60cb350b4#commitcomment-13637144>
> .
>


You forgot to run "grunt package" before tagging the new release so the files in dist/*.js still contains the console.log entry.


Jamie, I can not find this option! Where is it?


Nice, thanks for investigating!


The entity will fail if there are additionalProperties, but I didn't see any code in the Scala Tracker to filter out any unexpected properties. We need to either set additionalProperties to true or add code into the Scala Tracker to filter out any unexpected properties.


tweaktown.com##script:contains(adBlockNotDetected)
from wilderssecurity.com


> any reason you got rid of the capital on turbo and slomo? looks a little less correct/pretty IMO.

It looked weird to me to have two capitalized words one after the other, e.g. `Speed-Turbo: ...` but I don't feel strongly about it at all, Just let me know if you prefer both capitalized.

> don't really like the new format compared to the older ones. that parenthesis for Turbo , Unlimited and Slomo suited well :(

You mean in general? or just the parenthesis thing? If in general, give more details please. Do note that except for the removed `UI` part, you can get exactly the same information that you had before, just in cleaner, shorter, and hopefully better organized form.

As for the parenthesis, I removed them for two main reasons (other than slightly shorter length):
- It looks cleaner and less "busy" IMO.
- Displaying `Speed (Turbo): 345% (195.04)` might cause people to make an incorrect specific association between `Turbo` to `195.04`. The way I ended up with is less likely to cause people to make this incorrect association IMO.

> Wouldn't "Limiter: Off" be better?

Better than what? The current setup is that it's added to the `Speed` section, so displaying `Speed-off: ...` doesn't make much sense IMO, but `Speed-unlimited: ...` explains exactly what the mode is.

I'm 100% open to suggestions to improve it further or revert some of the changes. Just try to be specific with the concerns.


thanks for finding the patch! found a bug in the '/api/submissions/{id}' route as well


Documented it thoroughly: https://github.com/yandex/mastermind/commit/0291cb5246e6f6967fc4f74fb8c8ac70cd22f3c8


@eloyesp Oh, sorry. I didn't know about those recommendations. I think is too late for this commit message, right?


I think this is missing
> The Dog cannot shrink to a weight smaller than MIN_WEIGHT

apart from that , looks very good :+1:


LGTM


Ok, I'll add validation to tracker.


Very good!


Sounds good!


This is for bug 1211949.


Thanks. I will have to correct my answer on WS, for some reasons I concluded that simply using `||scriptscdn.tweaktown.com/adblocker.js$script,first-party` was working.


I added the videomode.h and rebased on top of your latest changes. I'll address the rest of review comments on top of this branch.


This commit is being reviewed as a part of review issue #99.


Cierra issue https://github.com/InspectorIncognito/androidApp/issues/25


This is a further comment


The [docs](https://docs.oracle.com/javase/7/docs/technotes/guides/security/doprivileged.html) for `doPriviliged` specifically say you shouldn't make a factory method for this sort of thing. If we're not concerned about that, that's fine, but maybe having a comment would be helpful for anyone else looking at it.


suggest to log error code and return unsuccessful status (independent for all compressors) instead of assertion


The repo can’t be retrieved via the http URL now that riak_ql is private.

-John

> On Oct 7, 2015, at 5:29 AM, Andrei Zavada <notifications@github.com> wrote:
>
> For all I can see, the only effect this change will have, is enable git push to work in a freshly cloned riak_ql (which would otherwise require fixing git url in .git/config manually). Is there some other effect I can't see?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/basho/riak_kv/commit/51afd8c3fa74e4c92a1166db44d078156546e3b2#commitcomment-13634194>.
>


You seem to have accidentally added `scripts/shairport-sync.conf~` to this commit.


These comments now seem redundant.


yeah, that’s expected, you need to be using `absolute_import` on all files

```
from __future__ import absolute_import
```


wtf


Makes sense; please disregard the PR then!


dont use system-specific types. ut64 or ut32, but size_t will be different on 32/64bit systems and can spawn some anoying bugs.


This is implicit, you don't have to call `super()` for empty constructors, the framework will call it for you. It's not wrong, but it's unnecessary :smile:


Ok. I've got it.


`FuzzNoCustom` wasn't getting this?


paiza.ioで試したところタイムアウトした
calcGCDに問題があるか？


What about `get_registration`? Should it return only non-dead registrations?


ok. what is the need to call this file xblock.py by the way ?


Actually, regarding `tweaktown.com`, I rather have users make use of this filter themselves if they wish, the thing to block is a message from the site itself -- I rather not have uBlock Origin's own filters block this -- it's not really a case of self-defacement or bloat.


yes, which is why I suggested adding an is_obsolete (or is_dead?) hybrid property


I would prefer to have `bin.maxstrbuf` instead of `bin.maxstrrange`. because having to dupped contiguous chars is anoying to read. and it also shorter.

Also, how to you plan to set this variable from rabin2? because rabin2 cannot touch the eval vars.


@grimbald  czekamy :)


because that’s what it is.


lfg is broken stop work every 2-3 hours


Why isn't `FuzzNoCustom` good enough here?


It does help on x64, but it helps on other architectures too. And it does work with memory protection schemes, but it works with other schemes too. It's also cleaner semantics. For inline bounds checks, one can use `base < size + -offset' instead of `base + offset < size` to avoid overflow, which can fold into a simple compare-with-immediate and branch if the implementation can use dynamic relocations to update the size after a `grow_memory`.


> it's not really a case of self-defacement or bloat

Agreed!! :)

> Thanks. I will have to correct my answer on WS

i replied @ post #1554


This is a public library. If we keep compatibility with Python 2, perhaps more people will find it useful.


Fixed by https://github.com/danmar/cppcheck/commit/2e510c873332465b5a22f1233446817d0bddaf9c


Hmm, 4 bytes are probably ok, although I think we are tight on HR20 units (That's why I picked HR25, with double the eeprom ;-) ).


I have a question about residue. In dmaengine.h the documentation for struct dma_tx_state says that residue is valid for DMA_IN_PROGRESS and DMA_PAUSED and otherwise 0. So how is one to find out if there was any nonzero residue after DMA_COMPLETE? Or will it still be nonzero despite what the documentation says and was the writer of it just not aware of DMA transfers that can stop early?

The typical case being the xilinx axidma with an s2mm where the peripheral asserts TLAST while filling the stream.

If this is not the best place to ask such a question, please advise me a better place.


This solution looks ugly and  `defaultFixity'` could generate the same problem in a different place later. Why not rename `defaultFixity'` to `defaultFixityAux` or something else?


I think it would be nice to have this bugfix for 15.09, but it can potentially be mass-rebuild'y (`glibc_multi` and `gcc_multi` are among rebuilds, but I haven't assessed further). How (and when) should I push it into `release-15.09`?


No no, I didn't mean the header file, I was talking about the file header :) Hope that the diff below makes it clear...

Diff of file obdconfcrc-generic.c:
````diff
/**
********************************************************************************
\file   obdconfcrc-generic.c

\brief  Implemetation of generic CRC calculation for object dictionary (OD).

This file implements generic CRC calculation function for the object dictionary
(OD) without any hardware support.

+ Generated on Wed Jan  9 14:34:53 2013,
+ by pycrc v0.8, http://www.tty1.net/pycrc/
+ using the configuration:
+    Model        = ccitt
+    Width        = 16
+    Poly         = 0x1021
+    XorIn        = 0xffff
+    ReflectIn    = False
+    XorOut       = 0x0000
+    ReflectOut   = False
+    Algorithm    = table-driven

\ingroup module_obdconf
*******************************************************************************/

/*------------------------------------------------------------------------------
Copyright (c) 2015, Kalycito Infotech Private Limited

......

//------------------------------------------------------------------------------
/**
\brief  Calculate CRC16 for buffer data

The function calculates CRC16 for the data in the passed buffer.
This CRC16 version is used in CANopen for SDO CRC calculation.

- Generated on Wed Jan  9 14:34:53 2013,
- by pycrc v0.8, http://www.tty1.net/pycrc/
- using the configuration:
-    Model        = ccitt
-    Width        = 16
-    Poly         = 0x1021
-    XorIn        = 0xffff
-    ReflectIn    = False
-    XorOut       = 0x0000
-    ReflectOut   = False
-    Algorithm    = table-driven
-
\param  crc_p           Initialized value of CRC.
\param  pData_p         Pointer to the data buffer.
\param  size_p          Size of data in the buffer, in bytes.

\return The function returns an unsigned 16 bit CRC value.

\ingroup module_obdconf
*/
//------------------------------------------------------------------------------
UINT16 obdconf_calculateCrc16(UINT16 crc_p, UINT8* pData_p, UINT32 size_p)

````


I am no expert either :-), but this might be what you are looking for:
http://stackoverflow.com/questions/16748115/how-to-modify-github-pull-request


@bgoglin @rhc54 removing the HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM makes cpuset handling much easier.
sockets/threads/cores not in the current cpuset are simply removed from the topology, so ompi does not need anything to handle offline or non allowed elements.
does this change look good to you ?


Maybe still "includes" -- version 5.1.0 still includes it after all?


At first glance, this looks like a generated conversion.  Can you add a comment explaining what's non-default here?  I would have guessed bugged, but you're intentionally dropping some fields?  If so, you should add tests to be sure that you drop **only** those fields or you'll start slipping on changes.


fix #1088


I don't think this causes a mass rebuild.


The new title bar is much more condensed. I would prefer parentheses for the limiter options but probably a native speaker should decide.

It belongs more to the other commit but as the discussion is here: Why have you changed the order? Is the new order preferable for troubleshooting or for higher end user usability? I guess there was some consideration why and how to change the order...


Set $count variable before if statement and check if $count !== 0


You can use http://placehold.it/209x225


LGTM.


You need to always remove comments


Let's return anonimous roleService object instead of defining and returning 'new roleService()' (like all our other services). Just for code consistency


Pieps!


Aw! Okay, sorry for the misunderstanding.. X[


I can't remember but I guess there was a good reason for setting this flag in OMPI in the beginning :) If it's needed for other reasons, you could also have two different topologies, one with and another without the flag, depending on what you want to do.


h


The version is in the past though. I assume it would actually be correct either way.


`git add -u .` is handy, as it only adds already files under version control to the commit stage.


Happy to go with your judgment. The rest of the commit looks fine.


thanks @vxsx


No issue :)


Does this work with camel case properties? E.g. `$someProp` with setter `setSomeProp()`.


This is a comment for the "initial comment".


I had a stab at running the tests with Python 2, and failed. Just tried again a bit more vigorously, and while another version of `freezegun` gets us past the install stage, the code at the moment isn't Python 2 compatible (e.g. `super()` calls).


Hi Alvaro, I've just fixed the .lower() bug.


Ah yes, of course you are right. So yes, I think your version is the one we need.

I think the API is ok, we can live with it, it doesn't cause much trouble.


This closes #2 as it takes into account joysticks equaling 0.


'macosx' -> 'MacOSX'

and it works for me now.

anyone else wants to try?


I agree, coincidentally, my very next commit, a8be9c1, was this exact change. I bet your way of doing it is also fewer computations.


Do you need the actual pointer or do you want a copy of the data?  I worry about accidental mutations leaking around.


is it possible case calling `getValue` from different threads?
If so, is it problem that deserializing `valueData` multiple times?

Same comments for `key`, `keyData` and `valueData`.


You may want to add the lock file to gitignore and remove it afterwards


Hi Mao-Lin,

no problem, I will do so. Might be a bit of a workload to collect the
data then, since there is this upper filesiz limit, but shouldn't be
difficult to fix.
And I don't know why I am not listed as contributor...

All the best,
Daniel

Den 2015-10-05 13:36 skreiv Earnest:
> Could you also add a global map of the point-wise correlation when you
> are back from your trip?
> Hope that the global pattern can help us to figure some issue of the
> script.
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/TheEarnest/Seasonal-Prediction/commit/b33ba652e294f752ecc7bb6ff1b47407f21e89a8#commitcomment-13589854


Just for the record: this happens while traversing the annotations of zopyx.plone.persistentlogger
where I am using datetime instances as keys (which is perfectly fine).

https://github.com/zopyx/zopyx.plone.persistentlogger/blob/master/zopyx/plone/persistentlogger/logger.py


Oh, found in Authentication. Sorry! Thanks! ;)


Does this commit in no way change the public interface of lib.protocol.*? E.g. I am wondering if this shouldn't be accompanied by changes to the README.


For me, this commit results in the following error during build:

`make[2]: *** No rule to make target 'package/utils/bzip2/host/compile', needed by 'package/feeds/packages/python/compile'.  Stop.`

Removing "libbz2/host" leads to a successful build.


Yes, that code was way too naive. There are a number of potential key types.


these variables never should've been removed...


Removed the following code to address the issue with a log rewrite:
http://github.com/github/git-lfs/issues/326
http://github.com/rtyley/bfg-repo-cleaner/releases/tag/v1.12.5

    # Skip files bigger than 3 MB
    if len(d) > 3145728:
      sys.stderr.write('Skip large file %s (size %d)\n' % (file,len(d)))
      continue


Erase your code


A `card.get_index()` helper would probably be helpful. I guess it's something like `player.field.index(card)`.


I think it is better to define human-readable values in app.js roles definition:
ROLES = [public: {id: 'public', name: "Public Access"},
     doctor: {id: 'doctor', name: "Dental Services Provider"},
     admin: {id: 'admin', name: "Administrator"},
+    super: {id: 'super', name: "God of DentalLinks"}]


true - you are right -then I just merge it

On 07.10.2015 14:27, Tobias Preuss wrote:
> `StandardCharsets` has been [added in API level 19](https://developer.android.com/reference/java/nio/charset/StandardCharsets.html). This project uses minSdkVersion 14.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/johnjohndoe/criticalmaps-android/commit/cfa3149d3026f95ef4fb17949322452cdb6ad6e0#commitcomment-13637068
>

--
best regards,
ligi
http://ligi.de


I fixed it


Don't you think that bitwise operators could work effectively and laconic?


This isn't just a `deepCopy_api_SecurityContext`?


I didn't notice that - must be blind :)


removed because it's more about testing the ExceptionHandler here, also there's no easy way to check if an exception has been caught within the forked process...


I don't understand how this commit will fix #259  Anyone care to explain? Many thanks!


This is a pretty surprising set of parameters, no? I think this should really be a "size_t length" value, or so, rather then a pointer to the end. (Also, the pointer should be const if at all). I think it's much more common to expect a pointer plus a length, than a start and end pointer.

Of course, this will make the patch more complicated, as this means we have to patch much further down to ensure we always keep the ptr+length bit intact.


I think it would be better to implement some developer-friendly service, that will take role ids and convert them into mask automatically, so that you don't have to know what does '2' mean.


Yes. It basically takes the key as it is and just uppercases the first letter. If you have: someprop it will be setSomeprop(), if you have someProp it will be setSomeProp().


Now the .cpp file is missing? And CMake change?


Note sure I like that the original string is patched here... Would prefer if we could leave it const, and just pass on the length...


Oh, no cmake change needed. But .cpp is nowhere.


We can include support library v7, but I rather not. I imagine that not having the color change is due to the lack of states in the selector. In any case, if you think the UX is better now, I'm fine with the add/remove.


Reverted in favour of https://github.com/manics/openmicroscopy/commit/a8bd8896a041100d478531f2884abf865a9abbd3


damn, I again inattentive :(


please do this in background. otherwise UI thread will hang


You don't need to commit personal files. Just `git add` the ones that are complete.


Hm, indeed, I see only Pipelight, VirtualBox and WineWOW (via `stdenv_32bit`) among large targets and not much others. I'll merge this into `master` and `release-15.09` then, is it OK?


not getting what's the idea


@open-net-sarl  Warning you meant `moves` not `move`


function not returning anything, Use warning level 4 in compiler options to catch these issues in future.


Add asserts


And here you certainly mean `moves.ids`


should we ignore the file?


> The new title bar is much more condensed.

So is this better or worse? Also, don't know about "much", spaces were removed in exactly two places:
- Output mode, e.g.  `Interlaced (Frame)` was changed to `frame-i`
- The part where the limiter mode is now adjacent to the `Speed` word without spaces.

> I would prefer parentheses for the limiter options but probably a native speaker should decide.

I noted my reasons for removing the parenthesis, but if most people think other than me, by all means let's return them. (not yet though, let's first make sure most, or at least many people prefer with parenthesis).

> Why have you changed the order?

The other commit has the reasons detailed at the commit message:
- More important items first
- Easier to look at, less busy to the eye
- Shorten it. A long line makes it harder to find the info you need.

- Save state slot is the only thing which people actually _need_ to see. So it goes first.
- Then most people are interested in how fast it runs, and the limiter mode, if there is one. Hence the speed+limiter is next.
- The CPU statistics is not very interesting when all runs fine, but if the speed is not sufficient, next they would want to see which part is affecting the speed.
- The output mode (interlaced etc) is technically really not interesting to users, but I left it there since I want to find an overall combined solution to how we display the output mode and deinterlace mode (if one is required and used).
- The GSdx info doesn't really have too much interesting info. It basically doesn't change and pretty much stays the way you configured it. It's nice to have though, and that's why it's there.

If you have specific concerns about ordering, or suggestion for other ordering, shoot.


should create  this array inside def push, as you did with @failed notifications


`%m`


not necessary but you may store `SerializationService` in a field of `MapServiceContextImpl` instead of accessing it through `getNodeEngine` always


@jsquyres you did set this flag in open-mpi/ompi@6557d74e01a2632bfc7671657f6d89f73b2522e0#diff-f4ec0cf4c6659e1c4af03b7a807378d8
do you remember why we need the full topology (e.g. both allowed and not allowed/offline elements) ?


Why waste 30 seconds of the user's time? I'd rather that `rtm_read` would throw on disconnection, but in the absence of that, why not ping every loop?


Поздеева Светлана


Was there a reason you deleted this file outright?


and in many place below.


Can you check the error return on gl.Init here?


Check return error?


@chelmuth: please add to staging


`$wgWikiaBotUsers` is a nested array - you need to access `username` to get the account name.

Otherwise you end up with getting the id of `Array` user :)


ConfirmaColetaViewPage was not implemented


I don't like this


Thank you @pvy-odoo, if we can be of any help, please do let know.


Can we get rid of the ``super()`` here now?


I want to correctly edit my cnpj


hasOk() is a function whose page has not been implemented


should be: So that I can keep the system updated


Why not put these lines:
```
$setter = 'set' . ucfirst($key);
if (method_exists($model, $setter)) {
    $model->{$setter}($value);
}
```
in the else above?


Line 59


Ah @vivangkumar explained it all to me. I get it now!


Nos steps referentes a GUI, ele ta chamando uma página "ConfirmaColetaViewPage" que não está implementada.


Based on https://www.opengl.org/wiki/OpenGL_Type, should we map gl.GLint to int32 explicitly?


It's generally a good idea to avoid types in constants - otherwise if you decided to change the object type you have to change all the variable names, I would use `ROCK_MOVES`.

However you're still doing a lot of repeat logic here, the idea was to see if you could just have one hash that defines the different winning moves, and not have any strings in here (that's presentation stuff that should be in the views). Maybe have an ask around how other people did the RPS challenge if they managed to use just one hash and see if you can use that as an inspiration for a refactor


On the plus side, it is nice to lose this as a dependency.


That's possible. I'm not sure if deserilization is needed. I took the code from the original pre-Andrejs implementation. I don't think multiple deserialization is a big deal.

Perhaps the fields should be volatile to make sure it will see fully initialized objects?


Well does this not give the false-positive? I tend to disagree, because when you are without connectivity, it simply skips the test and returns `0`. So unless you're really cautious and remember how many tests might be skipped, you might think everything is alright.

Anyway I agree that in terms of unittest it's the correct behavior, I just don't really agree with their logic. But we live in the unittest world, so ack.


It's not the best place to request code review :) It's ok, but lacks structure, it's incomplete


něco sem napíšu aby se udělal hook


It's great to see you extracting logic out of the controller. However if you looked at this and it wasn't your code would it be clear what is going on? Can you make this still tidier? Don't worry too much though this is the toughest bit and when you move to using databases it'll be much easier!


OK, we'll see how those tags evolve ...


that's a good idea


Some signifigant duplication here - maybe OK


In dieser Idee sehe ich großes Potential, wäre da an einer Realisierung interessiert. Partnerbörsen/Kennenlern-/Vermittlungsportale sind gefragt wie nie zuvor, rein gefühlt, ohne Quelle.
Grundsätzlich wird in einem solchen Portal eine Kommunikationskanal zwischen zwei Nutzen geschaffen, welche nach gewissen Faktoren zusammenpassen. Gängig sind komplexe Systeme, welche nicht wenige Daten der Nutzer auswerten um so ein "Match" zu finden. Nachteile sind hier einerseits die Notwendigkeit ein Profil zu erstellen, welches mit vielen Daten gefüttert die Möglichkeit bietet, sich selber in einem bestimmten Licht darzustellen. Auch gab es in jüngster Vergangenheit einige Meldungen über Manipulation und gefälschte Nutzerprofile.

Relativ neu und revolutionär und erfolgreich ist das Tinder Prinzip: Profilbild - find ich gut ja/nein - Match - Chat, jedoch ist hier einzig und allein das Profilbild des anderen sichtbar.

Und für den anspruchsvollen Partnersuchenden, welcher sich nicht von digitalen Pixelansammlungen beeindrucken lässt gibt es Loveamp.

Musik verbindet Menschen. Musik ist ehrlich. Musik ist Liebe.
Und Liebe geht durch die Ohren!

Lose Gedanken zu den Herausforderungen/Möglichkeiten bei diesem Projekt:

+ besonders die Bandbreite des Musikgeschmacks eines einzelnen Users könnte ein interessanter Faktor für die "Vermittlung" sein.

- Die Musik sollte direkt abspielbar sein. Youtube(Sperre/Qualität), sonstige Streamingportale. Lizenzgeschichten können gemein sein.


Hmm?


Nit: name is slightly misleading, as this method does not "write".  Maybe rename "FormatAsString" or something.  Not required to change before merging, but consider if you revisit this file.


Hmmm?


Hmmmmm?


Hmmmmmmmmmmmmm?


Ele chamou alguns métodos que não existe implementado no ress atualmente.


One more try (I wonder what happened). The branch has been rewritten.


Should be hidden.


I am pretty sure your browser is just showing these colors weirdly, try selecting the lines and you see that all is good...


Preferably: Correctly Edit the cnpj


Table should be compatible for screen re-sizing. One way of doing it will be making the number of rows determined by the size of the screen.


tried to create empty folder


Argh, sorry. That's a font rendering bug in Firefox.


Can we change this to:
```python
except AttributeError:
```


I wondered where that had got to, the little scamp!


Absolut Sinnvoll, denkbar wären 2 Modi:

-Virtueller Alkohol: Der Alkoholgehalt wird berechnet und simuliert. Verschwommenes schwankendes Bild oder so.
-Real World Alkohol: Für alle Trinker die zwar sehr gerne Trinkspiele spielen, sich aber ungerne unter echten Menschen aufhalten. Gleiches Spiel, jedoch ohne Betrunken-Effekt.


just checking, it seems you added an entry for tweaktown.com..


Preferably: Incorrectly edit the cnpj


minor wording tweak: "use WAGTAILEMBEDS_EMBEDLY_KEY __instead__"


Wäre supertoll, wenn gut umgesetzt. Problematisch sind hier die Latenzen, gerade wenn dieses Projekt online realisiert werden würde. Wenn da eine Lösung gefunden wird würde ich so eine App/Website/whatever auf jeden Fall testen/nutzen.


replace(' ', ''))

will not work!


I wasn't sure what to do with it.  I'll rip it out for now.


comment specific to the code.
![screen shot 2015-10-07 at 9 20 47 am](https://cloud.githubusercontent.com/assets/12473272/10338563/bbe6558a-6cd4-11e5-8638-1cc7794ace1c.png)


Würde ich spielen. Der Sound wird hier eine große Rolle spielen.


Nit: just curious why "KeyName" was replaced by "String", when these are actually key names.  I prefer "KeyName" but leave it to your discretion to choose.


This github repository has been created as a necessary tool for my first class 'Data Scientists Toolbox' presented by Johns Hopkins University by way of Coursera.


It'd be safer to use `if` here (one can import booth, avocado and Test).


The scrolling buttons buttons don't have to be part of `<table id="MainTable" border="1">` . Will make it extremely difficult to get a decent position for them on the screen  if it part of `table`.


let's get started


I like that it is more condensed and unnecessary letters are removed. I think the titlebar is quite confusing for new users so we probably don't need to avoid to use abbreviations instead of full text as in both cases they won't understand it.

Somehow I oversaw your detailed description of ordering. It mostly makes sense except for the hardware/software mode trigger f9 that can effect gsdx settings. But I guess nobody will die if he has to look to the end to be sure which mode he is currently using.

The savestate function is more like a hack and shouldn't be used that much and is unknown to some new members. So maybe first place in the line disrespects importance of elements but as you said it is the only place where the current state is mentioned. So maybe it is correct as it is. I would rather move savestates to the log console though.


Bug - Khắc phục việc phải tải toàn bộ các hàm trong `_utils` khi viết các scripts.


it implies using `continue` in the previous branch...


the inner " must go to the left of the -o expression


ResidueGeneratorEditPage's function fillCnpjField(cnpj) was not implemented

def fillCnpjField(String cnpj){
    $("form").cnpj= cnpj
}


Preferably: Correctly edit the cnpj


Can we do it when we put this patch set on LKML?
Otherwise this patch will be out of context.

From: Vineet Gupta [mailto:notifications@github.com]
Sent: Monday, October 05, 2015 2:20 PM
To: EZchip/linux
Cc: Noam Camus
Subject: Re: [linux] Documentation: Add EZchip vendor to binding list (5e2f9c9)

CC the Device Tree folks on this so you can get an ACK etc !

—
Reply to this email directly or view it on GitHub<https://github.com/EZchip/linux/commit/5e2f9c91e96dc00411f64b0d09b80982ddf4b720#commitcomment-13589612>.


test


This commit is being reviewed as a part of review issue #4.


Good instinct wanting to refactor this. Some things to think about when trying to figure out how to refactor a method:

1. How many things is the method doing? Optimally, each method would only have one responsibility. If I look at this method I see the following things happening:

* Determining if the guess correct (and off by how much)
* decrementing the number of turns that a user has left
* figuring out what message to display to the user, either keep guessing or you are done
* reseting the game

Could you start out by writing a method that simply tells you if the guess that the person passed in was one of the 5 states (way too high, way too low, too high, too low or just right)? You could then use the result of that method in another method that returns you the message and color to display if the person should continue guessing.

Can you separate the logic that determines if the person should continue guessing from the logic that tells the user that they are done because they have used all of their guesses?

This way you separate the logic that checks the guessing state from the logic that determines what message to show on the screen.

I will put together a version of my own using this as a starting point tonight to demonstrate what I am talking about in case you have questions.


and there are more {} qutoes missing


It adds self.name at the end, but that would be better handled by the qualifier, I think.