1: M110 missing component name


While typically this counting approach would work, there's a case when this would fail and cause an attempt to read from the non-existing file on line 175 further in mraa.c.

This is when iio-sysfs-trig module is loaded (not loaded by default on either of our boards, but it's the one necessary for making the buffer+trigger multi-sampling work on Edison). It creates at least a directory called "iio_sysfs_trigger" + one directory per created trigger, called "trigger<number>", e.g. "trigger0". See an example below:

```
root@edison1:~# ll /sys/bus/iio/devices/
drwxr-xr-x    2 root     root             0 Jan  1  2000 ./
drwxr-xr-x    4 root     root             0 Jan  1  2000 ../
lrwxrwxrwx    1 root     root             0 Jan  1  2000 iio:device0 -> ../../../devices/platform/bcove_adc/iio:device0/
lrwxrwxrwx    1 root     root             0 Jan  1  2000 iio:device1 -> ../../../devices/pci0000:00/0000:00:07.1/spi_master/spi5/spi5.0/iio:device1/
root@edison1:~# modprobe iio-trig-sysfs
root@edison1:~# ll /sys/bus/iio/devices/
drwxr-xr-x    2 root     root             0 Jan  1  2000 ./
drwxr-xr-x    4 root     root             0 Jan  1  2000 ../
lrwxrwxrwx    1 root     root             0 Jan  1  2000 iio:device0 -> ../../../devices/platform/bcove_adc/iio:device0/
lrwxrwxrwx    1 root     root             0 Jan  1  2000 iio:device1 -> ../../../devices/pci0000:00/0000:00:07.1/spi_master/spi5/spi5.0/iio:device1/
lrwxrwxrwx    1 root     root             0 Oct  2 11:13 iio_sysfs_trigger -> ../../../devices/iio_sysfs_trigger/
root@edison1:~# echo 0 > /sys/bus/iio/devices/iio_sysfs_trigger/add_trigger
root@edison1:~# ll /sys/bus/iio/devices/
drwxr-xr-x    2 root     root             0 Jan  1  2000 ./
drwxr-xr-x    4 root     root             0 Jan  1  2000 ../
lrwxrwxrwx    1 root     root             0 Jan  1  2000 iio:device0 -> ../../../devices/platform/bcove_adc/iio:device0/
lrwxrwxrwx    1 root     root             0 Jan  1  2000 iio:device1 -> ../../../devices/pci0000:00/0000:00:07.1/spi_master/spi5/spi5.0/iio:device1/
lrwxrwxrwx    1 root     root             0 Oct  2 11:13 iio_sysfs_trigger -> ../../../devices/iio_sysfs_trigger/
lrwxrwxrwx    1 root     root             0 Oct  2 11:23 trigger0 -> ../../../devices/iio_sysfs_trigger/trigger0/
root@edison1:~#
```


backdrop isn't working.


Should properly be 3.1.0 but too late now :D


I believe there should be spaces around the & operator here. "All non-unary operators with the precedence of + and - or less should have one space on either side"


:+1:  :+1:  :construction_worker:  :worried:


Typo at the end here 'focused group does' -> 'focused group'


:thumbsup:


given that lack of connectivity to jenkins means there's a difference in the generated kubernetes json - since we can no longer link the RC to the build that created it, I think the least we should do is log a warning. Sure we can omit the stack trace - but I'd expect to see a warning if due to network issues we were not able to properly generate all the metadata


There should be spaces around ==


For relative URLs, if the file is in the same folder, you can just do this.

`<a href="index.html">`

Example Directory Structure
```
js_apps copy.html
index.html
/foo/bar.html
```

Linking to a file in a folder!


Needs spaces around == and &&


:) just wanted to add make a pr for this doc


Hammerhead will be allow a lot of css files with 'SHADOW_UI_CLASS_NAME'. This code processes a single css file.


visual 2015 file project nó khác. làm bị lỗi.


however, I'm thinking that since we're returning a `Value` object every time, there's no byte savings whatsoever as all the properties are final. But perhaps if there were different types of Value classes, which only held a single kind of primitive, then you'd save more (with the overhead of the object)

I guess I still don't understand much how this `of` methods will be used.


The commas need to be followed by spaces (for all the params actually)


The `try` here prevents TCO for the evaluator, which is essential to run in constant space. Fortunately, it should also be redundant, since you already have a `try` around each entry point below.


1: M110 missing component name


ok


Well, semantics haven't changed with this modification. So far, we don't have support for this on client side, so it will require additional work to be done (we need an issue for this BTW, since we will definitely will need this for recorder. Please, create a separate ticket for this).


The commit message says "on upgrade", but this code gets run on install as well?


Should be:
<pre>
for (j = 0; j < yblk_sz; j++) {
  for (i = 0; i < xblk_sz; i++) {
    if (_dst[i + (j << _log_xblk_sz)] != dst[i + (j << _log_xblk_sz)]) {
</pre>


Nice one, I'm gonna merge but there is a "right" way to do localisation in c# using .resx files. I will take you code and convert it over at some point.

http://stackoverflow.com/questions/1142802/how-to-use-localization-in-c-sharp


Needs spaces after commas


IMO fit will work better that this resize.


I think this doesn't work as mymysql spec says. Pointer to value can be binded once and used on subsequent Execs without calling Bind. For such case, your patch doesn't work for pointer to value that implements fmt.Stringer, because String method is called only once by Bind call, and pointer to str is binded, not pointer to the real value.


move flag display_needaction to channel?


@IIvec About your questions.
1) I want to keep the other threads depth at some controlled distance from the master thread. With your example, the depth could start running wild because the threads finish their iterations at different points in time.
2) There is no proof that dividing by two is best. It's just something I tested on my local machine which produced a slightly smaller time to depth over some positions. The formula can be modified in many ways, and a proper TTD test takes a long time to run.


Should be
<pre>
  for (j = 0; j < yblk_sz; j++) {
    for (i = 0; i < xblk_sz; i++) {
      if (dst[i + (j << _log_xblk_sz)] != (_dst + j*_dystride)[i]) {
</pre>


1: M100 needs more reviewers
1: M101 signature is missing


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: config


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: travis


201:9: E126 continuation line over-indented for hanging indent
208:9: E126 continuation line over-indented for hanging indent


1: M100 needs more reviewers
1: M101 signature is missing
1: M111 unrecognized component name: tests


1: D205 1 blank line required between summary line and description (found 0)
27:1: I101 Imported names are in the wrong order. Should be find_packages, setup
29:1: I100 Imports statements are in the wrong order. import os should be before from setuptools.command.test
29:1: I201 Missing newline before sections or imports.


thx, I understood what it meant, but would like to learn the syntax better


Should be
<pre>
for (j = 0; j < (_m); j++) { \
  for (i = 0; i < (_n); i++) { \
</pre>


Should be
<pre>
for (row = 0; row < 0x20; row += 0x10) {
</pre>


Should be
<pre>
for (row = 0; row < 0x40; row += 0x10) {
</pre>


@taconaut will test and report back.  I also fixed the jumpy installer to be mlx-aware, so if you remove the *ums<-->ums-mlx* symlink and rerun the (same) installer it should hopefully update itself and work right this time.

PS now that you have Kodi, try test-browsing with that:
* Videos > Files > Add videos... > Browse > UPnP Devices
You can also push from UMS to Kodi if you enable upnp control:
* System > Services > UPnP > Allow control of Kodi via UPnP


nit: use `${TSD_GITHUB_TOKEN-}` to match other usage


Inspire_Default_HTML_detailed.tpl:
Extends format/record/Default_HTML_detailed.tpl
That in turn extends Default_HTML_detailed_base.tpl

I've also edited base/templates/records/base.html (to remove the detailed record tabs) that extends from:
base/templates/page.html
base/templates/page_page.html


for (row = 0; row < 0x80; row += 0x10) {


for (row = 0; row < 0x20; row+=0x10) {


this advice is generally too aggresive :(


for (row = 0; row < 0x40; row += 0x10) {


oh boy. can we please not advertise either of `-a` or `-m`?


I think you forgot to add this file to the patch?


no need for $USER since most contributors have their own fork


<pre>
for (row = 0; row < 0x100; row += 0x10) {


Which tests?  They seem to pass in travis.  This commit does't seem to have a pull or branch link for me.


this should be `git push -u myforkremotename`


For native reddit things you apply css to you probably want to work with a css class added to the body (or some other parent element) which is only there when the module is activated.


Return existed (once loaded) 'spellURLDictionary', to not load it again;
If URL is bad or file is absent - MailformedURLException should be thrown;
Default URL to raw dictionary file: https://github.com/webdizz/sonarqube-spellcheck/master/english.0


for (row = 0; row < 0x400; row += 0x10) {


Thanks for Plugin.py, I failed reading the regex by myself...


I'm confused by this. I don't see anything in this commit that would break the build and certainly nothing that would cause the specific error that's showing up in the tests (missing AccountPage), but when I look at the Travis build history, this commit is definitely the one where we went from green to red. Any idea what's going on there? I'll hopefully have a little more time to look into it at the weekend.


Needs spaces after commas.


typeof params.sqrt_detQ ist ContinuousSqrt<real_t> und hat somit die funktion:
std::complex<T> operator()(std::complex<T> input) welche continuate aufruft, um einen internen Wert zu updaten


For a hypothetical Wasm implementation that does TCO itself, this would not cause a stack overflow. Better use a call that is not in tail position.


for (j = 0; j < yblk_sz; j++) {
  for (i = 0; i < xblk_sz; i++) {
    if ((_dst + j*_dystride) [i] != dst[j][i]) {


Needs spaces after commas


I agree with the principle of retrying commands if in the case of certain errors such as unique constraint violation :+1: :-)

However, I think there are a few issues with this implementation:

1. I think the choice of whether or not to retry should lie with the command itself, rather than the event logger. Only the command knows whether a unique constraint violation would be due to a race condition (which implies that the command should be retried) or for some other reason (an attempt to perform an illegal operation which should be reported to the client). The choice of whether to retry should be narrowly focused on the code which has the race condition. My suggestion would be to rescue the unique constraint violation exception within the command implementation and to raise a different exception such as `Command::Retry` or similar to signal to the EventLogger (or command processor) to retry.

2. I think that postgres itself will abort the transaction if there's a unique constraint violation error, so it would be necessary to begin a new transaction. So, I think that as implemented this will not work because when the retry is attempted postgres will raise an error because the transaction has been aborted. Currently the unit test does not hit the database so this fact is hidden. I think the unit test should hit the database to prove that this works. It may be necessary to use `DatabaseCleaner` `truncation` strategy (instead of `transaction`) for this particular test in order to allow the transaction rollbacks to occur.


Oh, yes. I just wanted to bump the minor version, forgot to change the patch guy to 0. Oh well, I’ll not rush things next time! :smile:


Looks like it (checked Qt 5.5)


I found an old entry in a random todo list somewhere that questioned the contract system's behavior on this example:

```
#lang racket/base

(module server racket/base
  (require racket/contract/base)
  (provide
   (contract-out
    (f (or/c (-> integer? integer?)
             (-> integer? integer? boolean?)))))

  (define (f . args)
    1))

(require 'server)

(f #f)
```

I can't recall clearly, but I think that this example was distilled from someone using the contract system and getting confused about why their example didn't work. (That is, I think that this example didn't come from me .... but I'm not really sure.)

Then, Christos, Matthias, and I had a discussion about the right way to handle `or/c` in such cases. We considered several possibilities:

* the behavior before this commit
* a variant on that behavior where the error message changes to make this a contract violation of the use of `or/c` itself, but with a "delayed" reporting of the error (I think this is what the behavior was quite a long time ago, but I'm not sure)
* the new behavior

In the end we decided that the new behavior was more consistent with `or` so decided to go with it.

(The conversation also spent some time discussing why `or/c` isn't the same as disjunctions in a type system, FWIW.)

@mfelleisen  also asked for `xor/c` contract combinator, which I think would have the behavior you miss, but I didn't follow up enough to track down the precise semantics and then add it. If it really is just the old version of `or/c` but now named `xor/c`, I'd be delighted to add it, especially now that there are two requests.


for (j = 0; j < (_m); j++) { \
  for (i = 0; i < (_n); i++) { \


Goiano passou por aqui


Thanks for the reminder, just got that in motion.


like you said -v is not very standard and would be expected to set debug mode instead.


for (j = 0; j < yblk_sz; j++) {
  for (i = 0; i < xblk_sz; i++) {


Or, I guess `xor/c` wouldn't be the same as the old one, since the "only one" behavior would apply to first-order contracts too. And, if it is "only one" that we want, then xor doesn't seem like quite the right name, since n-ary exclusive or usually means "an odd number" accept it and I think the "only one" semantics is the useful thing. (Maybe?)


Actually, why check for `host !== "localhost"` at all? There may be other strings that resolve to localhost, like whatever may be in the hosts file.


<pre>
for (row=0;row<0x20;row+=0x10) {


CMRemix*.zip is also ok xD
and change log name also na


We're going to keep the current model for a little while and see how it goes. I don't think installing Ruby via apt takes very long, but we do want to optimize the time it takes to get your dev environment running.

If you'd like to discuss further, I suggest opening an issue, as these commit comments can be missed easily by the core team and are not seen by the rest of the community.


for (row = 0; row < 0x20; row += 0x10) {


I don't have have any file. But there are two files:
- https://github.com/sonata-project/SonataIntlBundle/blob/master/Locale/RequestDetector.php
- https://github.com/sonata-project/SonataIntlBundle/blob/master/Locale/SessionDetector.php


for (row = 0; row < 0x40; row += 0x10) {


You can exit quicker if you don't have `q`, meaning you don't have to have an extra level of indentation:

```
if not request.GET.get('q', None):
    return Response(...)

solr_conn = scorched... blah blah blah
```


Don't work!


for (row = 0; row < 0x100; row += 0x10) {


Needs spaces after commas


build failed.. sorry


Comments inline


ok


I think the check should really be to verify that `len` equals the amount of data left in the PACKET. We'll need a different patch for 1.0.2/1.0.1 because they don't have PACKET.


replace channel_id with channel?


brilliant hack :)


PR: RuleEngine uses now context to evaluate rules instead of outputs of modules


Line is too long. [105/100]


done

> Am 02.10.2015 um 01:14 schrieb Mark Perry <notifications@github.com>:
>
> +1
>
> —
> Reply to this email directly or view it on GitHub.
>


too much


Why remove "/symfony" ?
After provisionning I get :
````
make: *** No rule to make target `install'.  Stop.
Connection to 127.0.0.1 closed.
make: *** [setup] Error 2
````


The bad thing is that we should not have copies of the same functions, especially if these copies are in folders included in the matlab path. Any duplicate function should be renamed so that it is quite clear that the function does something else. Can we double check that this is not the case for other functions?


defensive programming: might be worth explicitly normalising the keys in `payload` (to either strings or symbols)


Wooooops, wrong copy/paste :)


Why not fat arrow?


There is nice helper `config:get_integer` for that.

On second though, is there any need to pass Body to rewrite function? Assume, I rewrite some path for attachments upload. Then this can hurt.


only in non touch mode


I've cherry-picked and pushed this one as obvious typo fix. Not sure why you didn't do that yourself but whatever :-P.


:+1: for @graywolf336 , maybe we could also keep the message in the text input instead of just ignoring it


Could this requirements file go into the main [requirements directory](https://github.com/mozilla/bedrock/tree/master/requirements)?


Hi Kevin,

On Oct 2, 2015, at 12:56 , Kevin Darbyshire-Bryant <notifications@github.com> wrote:

> Understand what you're saying and if I follow that argument then 'ether-all' should be done in the same way (I may need to add a vlan tag/s)

	I agree, and I guess all �=� should actually be "+=�.

>
> Personal view: I view these options as 'base' options to which other optionals are added. Usage instructions should specify that 'base' options need to be applied first, with optionals later.

	But if all are += then the sequence the options are given in does not matter anymore, which I believe is more new be friendly than requiring an not-yet-documented ordering constraint. The downside would be that people can request funny stuff like �pppoa-llc pppoa-vcmux�, which most likely "nobody wants because nobody needs� (to cite T. Geisel here). I would argue that it is better to verifiable fulfill potentially �silly� requests than to silently drop parts of the specified option (especially when the �dropping� also depends on the order).
	Then again this is to a large degree a matter of taste, so Jonathan should have the final say. That said I am a tad unhappy about the current state of affairs:

user@computer:~/CODE/sch_cake> sudo tc-adv2 qdisc replace dev eth0 root cake pppoa-llc ; sudo tc-adv -d qdisc
qdisc cake 8002: dev eth0 root refcnt 6 unlimited diffserv4 flows atm overhead 14
# this is fine

user@computer:~/CODE/sch_cake> sudo tc-adv2 qdisc replace dev eth0 root cake pppoa-llc ether-fcs ; sudo tc-adv -d qdisc
qdisc cake 8002: dev eth0 root refcnt 6 unlimited diffserv4 flows atm overhead 18
# this is fine as well

user@computer:~/CODE/sch_cake> sudo tc-adv2 qdisc replace dev eth0 root cake ether-fcs pppoa-llc ; sudo tc-adv -d qdisc
qdisc cake 8002: dev eth0 root refcnt 6 unlimited diffserv4 flows atm overhead 14
# the last one should be 18 bytes as well, or complain/inform that it ignored ether-fcs due to ordering constraints.

The current state of the options is certainly not optimal, either we need to document the constraints better/at all or make it ordering independent ;) I think that the second option is nicer...

>
> Incidentally, see the skbstats branches on both sch_cake & tc-adv ;-)

	Oh, that looks delicious ;)

Best Regards

>
> �
> Reply to this email directly or view it on GitHub.
>


really?


also check why search view get the focus


May be better log errors?


that's still mako syntax


:+1: :+1:


ew


@rudzboy be aware this was not really meant to be used in prod, and maybe ping your to one of us to propose your idea on slack before jumping on PR ;)


we have `alertPopup(message, title);` as a nicer wrapper for this


**partial**


Notice `{# #}`


Externí služba, jako srsly?


Here are a lot of useful checks, but can we have them on CouchDB side? Then, there will be no need to repeat them for every else query server and CouchDB can ensure that all the rewrites are valid.


@getsun 好啊 :D


This could potentially fix BSOD after a reboot, however i'm not 100% sure because i never seen a log after a BSOD so... Be careful before removing BSOD Killer! ;)


sent the changes


No problem, thanks for the report!


No, I was not able to get it working for SurfaceView.


Check RHManageRegFormBase. You can probably move the code from that class into a mixin to be used for both RHManageRegFormBase and the new `RHRegFormBase` (which I'd also put in __init__.py)


you shold be remove "from openerp.tools.translate import _" and add like from openerp import api,  fields as new_fields, models, _


Big wallpapers are cut - I'll check if fit() will fix it.


Good point. Will do it.


hmm are those usefull for anything, like most of it is for encryption i guess and DRM..


Create dummy file for new installer


This looks perfect for mirage and opam needs (/cc @AltGr). I'll try to use it in Functoria and report back.


Correct, support for floating point numbers was added to the template [here](https://github.com/DeltaSystems/dewdrop/commit/dcc7b1cc601f918450a6be4d4c0a3349b9c0357a#diff-4c907466ab3b793fa2709f594be31d7e)


BECOME-SUCCESS-ohltegtjhxeexpntufukwnjwltrxnqhp
Traceback (most recent call last):
  File "/home/openshift/.ansible/tmp/ansible-tmp-1443786071.04-269724014027489/openshift_facts", line 6013, in <module>
    main()
  File "/home/openshift/.ansible/tmp/ansible-tmp-1443786071.04-269724014027489/openshift_facts", line 971, in main
    openshift_facts = OpenShiftFacts(role, fact_file, local_facts)
  File "/home/openshift/.ansible/tmp/ansible-tmp-1443786071.04-269724014027489/openshift_facts", line 760, in __init__
    self.facts = self.generate_facts(local_facts)
  File "/home/openshift/.ansible/tmp/ansible-tmp-1443786071.04-269724014027489/openshift_facts", line 786, in generate_facts
    facts = set_deployment_facts_if_unset(facts)
  File "/home/openshift/.ansible/tmp/ansible-tmp-1443786071.04-269724014027489/openshift_facts", line 477, in set_deployment_facts_if_unset
    facts['common']['version'] = get_openshift_version()
  File "/home/openshift/.ansible/tmp/ansible-tmp-1443786071.04-269724014027489/openshift_facts", line 614, in get_openshift_version
    return version
UnboundLocalError: local variable 'version' referenced before assignment


Why /public/ ? I don't see this folder in this repository.


shold be proper name convention "recored" instread of "m"


Hello,

You're maybe right, in fact I was using one InfoWindow for every Marker and open the InfoWindow when I click on the Marker (which is I think really common user case). In my case I have different InfoWindow layouts so it's easier to create every single InfoWindow.

I tried to search some way to do that like an event that google map listen and I found many people looking for this like [here](http://stackoverflow.com/questions/4539905/close-all-infowindows-in-google-maps-api-v3) for exemple and I remember I saw few like that, not related to ngmap but google map in general so I was thinking this could be a great feature or maybe at least have a notice in the documentation for this kind of use case to say to the people to use only one InfoWindow


Why are these three configs needed in the bare-bones setup? Just a temporary thing?


php başlangıç


Use struct


@Jojo-Schmitz : Bingo! For this glyph, I just copied your data! (For the other, I copied Bravura's). Updated.

Also removed the alternate codepoints, as mscore only has the BMP


>  is there any need to pass Body to rewrite function

Yes. Rewriting req body we can, for example, re-implement stuff like couch-peruser without aside tools, only inside couchdb. Also we can, for example, allow users to self-register.

Actually, in most cases heavy inbound requests could be well checked by validate_doc_update, so they should be routed through ‘classic’ rewrite, without touching JS rewrite.


It's a really good example of how to extend the menus, it gets asked about a lot on the training course, so we now have a great place to point students in the direction of !!


hey , i am getting an error while making simple-captcha work


you need to remove those lines from
https://github.com/Stane1983/android_device_xiaomi_dior/blob/cm-12.0_new/proprietary-files.txt
if you added same but unrenamed here


No need to put this in staging. I've cherry-picked it to master.


hahaha
remove sync please
bandwidth over


What do you think about multiple craftMaps for heavy modding purpouse too ?


hey , i need some help to include this in my project .


Ahja, stimmt, gut.


Excellent, thanks for checking!


Why start counting from 1 again? There's `NAcc` above which can hold value greater than that already.


```python
# __init__
class RegFormMixin:
    normalize_url_spec = {
        'locators': {
            lambda self: self.regform
        }
    }

    def _checkParams(self):
        self.regform = RegistrationForm.find_one(id=request.view_args['reg_form_id'], is_deleted=False)

# management
class RHManageRegFormBase(RegFormMixin, RHManageRegFormsBase):
    """Base class for a specific registration form"""

    def _checkParams(self, params):
        RHManageRegFormsBase._checkParams(self, params)
        RegFormMixin._checkParams(self)

# display
class RHRegFormBase(RegFormMixin, RHRegistrationFormDisplayBase):
    """Base class for a specific registration form"""

    def _checkParams(self, params):
        RHRegistrationFormDisplayBase._checkParams(self, params)
        RegFormMixin._checkParams(self)
```


`opts.suffix ? '.' + opts.suffix.split('.').join('') : '.build'`? Rather than defaulting to `undefined` here and doing another fallback to `'.build` later, might as well set this in one go and set `path.basename` to the output. Unless I'm missing something.


Hm, good. Then may be add `<<"form">>` field as well? It's quite helpful when request comes from HTML form - no need to parse it on query server side.


If I recall correctly it's not the right place to account for packing a list of values, it should be done somewhere closer to condition construction site instead.


Bad Jeppe. Baaaad Jeppe.


Yes.


thằng nào nó commit cái file project làm conflict phải commit nó mới cho sửa đó


@mbootsector :
1) This is now completely understandable.
2) I was thinking a little bit more and with your formula you have 500
depth increase on 1000-core machine, which seems no good.
    We know that depth increases logarithmically with time, and so it
should increase logarithmically with the number of cores too.
    In this case the formula is:
    th->rootDepth = rootDepth + (Depth)(3 * log(th->idx)+1);

   I chose 3 here to be close to your formula for 15-20 cores. I now
recommend tuning that parameter with SPSA.
   Maybe we can get also better behaviour for low number of cores.

On Fri, Oct 2, 2015 at 1:35 PM, mbootsector <notifications@github.com>
wrote:

> @IIvec <https://github.com/IIvec> About your questions.
> 1) I want to keep the other threads depth at some controlled distance from
> the master thread. With your example, the depth could start running wild
> because the threads finish their iterations at different points in time.
> 2) There is no proof that dividing by two is best. It's just something I
> tested on my local machine which produced a slightly smaller time to depth
> over some positions. The formula can be modified in many ways, and a proper
> TTD test takes a long time to run.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mbootsector/Stockfish/commit/9f5c97082f4a4f2c989a7af3f8083dbd778d0c3d#commitcomment-13560298>
> .
>

--
IQ World <http://www.ultimaiq.net/>


@VinceVal nice! this worked for me


Yes André, actually I only intend to disable HTML Comments in dev environment so my HTML markup matches the production one ;)
I'll try to save some time to contribute ;)


I think that you're misunderstanding. I don't pre-pack the android's ramdisk. This one is the boot ramdisk, which extract saved android ramdisk and tweak it before starting android system.

I just made a command to add a line to the end of default.prop before initializing android system. Unfortunately, I didn't success because that line must be added to the beginning for the file.


Ok apart from the fact that the code has no comments, need to implement the comments in the future or you make reading it extremely difficult man. Software Engineering > Programming > Coding.


Replace this with `smack-java`.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21752/testReport/) for this commit**


The platforms supported by CRT that ships with VS2015 does provide `strtok_s` (works on XP-10). If the target compilers here are Cygwin and MinGW, should we test the capability in CMake using `check_c_source_compile`, `check_c_source_run` or `check_prototype_definition`? Something like:

```cmake
# .cmake/Modules/Capabilities.cmake

include(CheckPrototypeDefinition)

check_prototype_definition(
  strtok_s
  "char *strtok_s(char *, const char *, char **)"
  NULL
  "string.h"
  HAVE_STRTOK_S)
```

Then `src/config.h.in`:

```c
#cmakedefine01 HAVE_STRTOK_S
```

Then here:

```c
#ifdef VANILLA_WIN32
#  if HAVE_STRTOK_S
char *strtok_s(char *strToken, const char *strDelimit, char **context);
#      define strtok_r strtok_s
#  else
char *strtok(char *strToken, const char *strDelimit);
#      define strtok_r(str, delim, saveptr) strtok(str, delim)
#  endif
#endif
```


missing empty line between these two methods


Indeed :)


Good goood Jeppe. Bad baaaaad E-com for forcing me to do that.


Just 2015, this didn't exist before?


missing "explicit"


Can you remove the commented out code


Have you thought about instead of `json_req2_obj/2` add some `json_req_obj/4` instead where 4th arguments is a list of options or fields we'd like to toggle?

Then `json_req2_obj` could be just:
```
Exclude = [<<"info">>, <<"uuid">>, <<"id">>, <<"form">>],
json_req_obj(Req, Db, nil, Exclude).
```

And there will be no reason to repeat most part of `json_req_obj/3` body.


> Then may be add <<"form">> field as well

I removed it intentionally to
a) avoid additional parsing, that is actually not so cheap,
b) avoid doubling of body data sent to spidermonkey, that also isn‘t so cheap,
c) avoid .form JSON parse at spidermonkey process.

When I tried to imagine tricks I could do with rewrites, I discovered very few cases, where I actually need body being parsed upfront. So we better keep it a string and parse to JSON at JS process, and only if we strictly need it.

So I dropped .form for performance.


should this maybe just be merged with the next one, using const QString &address = QString() ?
Semantically, it's just an end point reference with an empty address, right?


Thanks , maybe CrudRequest need the same


thank you


Both my LDAP and local auth builds are stable here! I can now start preaching about it in the OpenStack community and hopefully find some motivated nodeJS developers. Thank you~


Actually ceylon/ceylon-spec/issues/1204.


Maybe you should use `button` tag instead of `a`nchor?


I think this should be just `function () {`


As per the guideline "demo and data xml" shold be in "data" directory not in "views" , if i wrong check on https://www.odoo.com/documentation/master/reference/guidelines.html


"Destroys", since you use "frees" in the sentence.
Destroy+free (like an order) or Destroys+frees (like a description of what it does)


nnn


Ok, sounds reasonable. Thanks!


Assigning the ivar directly breaks the abstraction layer between AM and AR. AM::Dirty should not provide instance variable is an API. It should only provide methods... at least if possible....


Replace the comma with a dot, it's two sentences.


missing \since 1.5


А можно делать разное соотношение потерь?


Why this test? Isn't it surprising that setReferenceParameters(KDSoapValueList()) is a no-op?


lack comment


should there be a qWarning if this is not the case?


Don't think having default Jython and PyYAML versions in doc makes sense when argument have them above. Also, 'Pypi' -> 'PyPI'.


const QString...


Das ist unten links im Füllungs-/Kontur-Indikatorfeld. Wenn ein Objekt mit einem Verlauf ausgewählt ist, steht vor dem entsprechenden Farbfeld ein einzelner Buchstabe, der anzeigt, ob es sich um einen radialen (R), linearen (L) oder gitterförmigen (V/G/?) Verlauf handelt.


**README - Nitpick**
Would have been better to split this into a heading and subheading, i.e. `EvangelistStatus / The developer analysis library`. And on the line below, you should have italicized _evangelism_ and also capitalized the 'G' on Github.


Hi.  Thanks for the pull request - it's actually very handy and something I pull up a repl/interpreter for.  I'm happy to merge it but I have a few suggestions I'm hoping you can incorporate and open another PR for.

Firstly, I'm wondering if you realised that the encoding function you wrote supports unicode (although it messes up the code points) and you can't actually decode back.  It outputted a `\uHHHH` code point as `\xHHHH`.  My C is hopeless and my C with unicode/wchar is even worse but I'm assuming this isn't right though.

```
// Original string
€

// C-style byte strings encoding
\x20ac
```

I think if you modified `encodeHex` to test for ascii encoding first then it should be OK.

```
def encodeHex(string):
  try:
    string.encode('ascii', errors='strict')
    return ''.join(('\\x{0:02x}'.format(ord(char)) for char in string))
  except:
    # don't do anything
    return string
```

Would you mind renaming the menu option from `Hex` to `Code Point` and `C-style Hex encode` to `C-style Hex encode (ascii)` (same change for decode)?   I'll probably add the unicode ones


I add wrong names for the remote in my repository, I pushed to origin which went upstream.


Move the writeEndElement() call out of the if/else. More symmetrical, and avoids the duplication.


Thx for contribution in our project!


你又不认真听，有人问了要不要case insensitive， 明确说了要

On Friday, October 2, 2015, Yifei (Ray) Shen <notifications@github.com>
wrote:

> 要求上没有说啊 而且protocal定的时候就是大写
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/syftalent/dist-sys-exercises-1/commit/876b3e253d56256b64ce9b29498958a9de9722e0#commitcomment-13555832>
> .
>


typo: writting -> writing.
(deja vu...)


ok lolz


Yes. If you read through the history, this is part of a continuous refactoring which will eventually lead to this code all living on AM.


Extract variable?


Too much usings?


So the assumption is that the later entry will always be the one we want?


You're, as usual, right. Probably I did it for a quick and dirty fix... that as you can see.... I left it behid.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21753/testReport/) for this commit**


Yes -- in fact, that method is supposed to fetch 'latest state'...


You should declare your form as service


Don't use a string for number. Use a int.
Is this really a number?


Thanks! Not sure the cholesky really helps  in the symmetric case... I thought it might be more stable but empirically I haven't seen much difference.

> On Oct 2, 2015, at 12:08 AM, Matthew Johnson <notifications@github.com> wrote:
>
> you can call scipy.linalg.lapack.dpotri here instead of dpotrs(L, I), http://www.netlib.org/lapack/double/dpotri.f
>
> —
> Reply to this email directly or view it on GitHub.
>


Why ? I inject nothing in this form type.


Use properties instead of variables


I implemented it in a very similar way first, but then rewrote as separate fn for these concerns:
a) when tests are more brittle then code itself, I‘d better avoid touching existing tests whenever possible,
b) since we return rather different object, and, though, need to have a name for it (at least for documentation), I supposed to name fn after object.

It‘s quite discussible, sure, and not very neat from academic point of view. So if you think after my arguments, that one fn for all is more suitable – I‘ll surely fix it this way.


"that" method?


It's for debbuging or you realy want disable the html5 validation ?


I think it's actually less stable than QR. fewer flops, but also maybe less
parallelizable.
On Fri, Oct 2, 2015 at 8:38 AM Scott Linderman <notifications@github.com>
wrote:

> Thanks! Not sure the cholesky really helps in the symmetric case... I
> thought it might be more stable but empirically I haven't seen much
> difference.
>
>
>
> > On Oct 2, 2015, at 12:08 AM, Matthew Johnson <notifications@github.com>
> wrote:
> >
> > you can call scipy.linalg.lapack.dpotri here instead of dpotrs(L, I),
> http://www.netlib.org/lapack/double/dpotri.f
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/slinderman/pyglm/commit/d73b60cd6b5fc69ee32017fdaef578a51359a864#commitcomment-13561289>
> .
>


**Comments - Awesome**
Good use of `docBlock`s!


@taconaut wow, looks like adding jumpy is an endless recursion, my debug.log was over a gigabyte after a few minutes and I had to kill mlx.  Debug.log (had to open it with a hex editor :-), is this repeated ad infinitum (with global id++):
```logtalk
TRACE 2015-10-02 08:28:45.105 [New I/O worker #3] Adding new child "Jumpy" with class "net.pms.external.infidel.jumpy.scriptFolder"
DEBUG 2015-10-02 08:28:45.105 [pool-21-thread-20] Node (net.pms.external.infidel.jumpy.scriptFolder) already has an ID (6177686), which is overridden now. The previous parent node was: root
DEBUG 2015-10-02 08:28:45.105 [pool-21-thread-20] GlobalIdRepo: removing id 6177686 - Jumpy
```


This is missing some namespacing, it could conflict with a class Relationship in an application.

=> KDSoapMessageRelationship maybe?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21754/testReport/) for this commit**


How about "As an alternative, if your collection has a field or fields that are never modified, you can use a unique index on this field or these fields" ?


It's not for debugging, The spec don't specify the html5 validation.


And why not use the `{{ form_start() }}` twig function


typo in constructor


Apparenty the static analyser is happy with the implicit test to TRUE ie ``while (allocate_more) {`` but issues a warning with an explicit test ``while (allocate_more == TRUE) {``.

So I will make them all implicit tests (which are anyway optimized by compiler) to keep everyone happy and not make radical changes.


@porcelli Want me to delete them?


No \


suppose -> supposed
to represents -> to represent


Yeah you're right! Thanks!


Copyright boilerplate.


use a ctor initialization list rather than assignments


is you can..... <3


set -> sets
("it sets")


Created new pull request to use a feature branch.


Too much usings?


looks good! =)


'that method' which contains this diff.

Yes, we probably can/should use indexes -- but, AFAIU, that has a performance penalty which I'd rather first understand...


As a point of interest we can do with without lambda as
```javascript
.reduce(Function.prototype.call.bind(Array.prototype.concat))
```
and in fact this supports arbitrarily many arguments, but it's probably less than readable.


Ah~, I have found the reason. You can command : echo has('conceal') in your vim, if it return 0. That's why you can't see the indent line. If so you can brew a new version vim which support conceal or patch this feature.


Aaargh, not like this! Revert please


Ok, fair enough. I just dont like us doing database stuff in python too much.


Hi, can you make a PR on the base repository, this way everybody can have the IFNULL function ?


q += 2


with -> with the
(It's really just like in French, if you say "le" or "la", then you say "the" in English. Only "un/une" can become no article in English.)


Would you please explain how this works? I'm just curious about it ^^


Yeah, agreed. I've changed that, and I'll just push the rewritten branch


no space after &


ᐧ
you're right, it's done!


there's something missing after Returns and before metadata, guess what ;)


We use one equal sign to assign a value to a variable, we use two equal signs to check if things for equality.


take -> takes
Qstring -> QString


Directorio de prueba


This should be in or out, but not commented out ;)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21755/testReport/) for this commit**


Got this error:

    $ brew cask install diskmaker-x
    ==> Downloading http://diskmakerx.com/downloads/DiskMaker_X_5.dmg
    ######################################################################## 100.0%
    ==> Note: running "brew update" may fix sha256 checksum errors
    Error: sha256 mismatch
    Expected: e7227ce59fee42cca395ec2db7f07b9f809492c4e02a0ad53d82deec5d77ecfe
    Actual: 69f2d57392f56fbc1fa9cccc0d1d2be57b8ff4d39bcfeb1cb6770fbf702fb3df
    File: /Library/Caches/Homebrew/diskmaker-x-5.dmg
    To retry an incomplete download, remove the file above.


absolutely... :/


remove


Provie -> Provide?
Predefines -> Predefined?


Начало проекта


Ok, sounds clear, be aware in master now this class *only* deals with html comments, so disabling use of this class will accomplish that, no need for a flag inside this class itself imho as you can avoid loading it.


Remove from "openerp.tools.translate import _" and add in "from openerp import api, fields, models, tools" this line, no need to import separately


I'm not sure that's a good idea.


leave this out until later, it's not part of this commit


Hi Jerry.
Sorry that I did not call u yesterday cos it was team outing to seafood dinner.

What I am thinking there is :
- This public class `StateItems : List<StateItem>`  is basicly working like a dictionary, so that could be a IDictionary<string,Object> case.
- Everytime someone call "Get" "Remove" "Contains" it will start a linear search using linq like
'foreach (var item in  items) { if ( item.key=="hit") yield return;  }` kind of wasting cpu if you got more items there in collection. IDictionary<string,Object > implementations works faster with that.
- There is no point if we have the instance of value and use a extra property for it's type for me.
- dynamic property gives us a easy way to access session cos `SessionState["MyValue"]`  equals `SessionStateBag.MyValue`


saw approval from gordonguthrie
at https://github.com/basho/riak_kv/commit/999f67e5d239cc783ae271c7befd35a2a346a438


merging basho/riak_kv/feature/fix/RTS-354 = 999f67e5 into borshop-integration-1202-feature/fix/RTS-354


basho/riak_kv/feature/fix/RTS-354 = 999f67e5 merged ok, testing candidate = f3ebcaa6


Thanks!


@voronianski Thanks for the quick reaction! We're good for now and will update the reference in future builds.


There is a typo in the commit message.


Please move this code `#{user.last_name} #{user.first_name}` to a decorator.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21756/testReport/) for this commit**


where  string = 'Name'  ?


where  string =  'Active'  ?


Yeah, get the package control add-on and install , sublimerepl and anaconda


where string = "Configuration" ?


where string = "Script" ?


@skeptical I would have been surpised if it had worked right away as the DLNA part is fully untested :no_mouth: I can't tell now if the issue is coming from ums base code or changes I've made. The code which probably triggers this is [pretty simple](https://github.com/taconaut/ums-mlx/blob/master/core/src/main/java/net/pms/plugins/wrappers/AdditionalFoldersAtRootWrapper.java#L76), it gets all child folders returned by `AdditionalFolderAtRoot.getChildren()` and adds them to a new `VirtualFolder`. It could also be a recursion issue!?
I'll have to find another UPNP browser to easily test this :)


Wouldn't it be a security issue to call changePassword from the cliend side?


add teammate


lack comment, and maybe it can be private


Remove semicolon


Can you add a Junit test for SubmitJobCommand to cover the changes ?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/21757/testReport/) for this commit**


remove semicolon


Удалений на самом деле нет, это глюки diff'а


I'll try the plugin this weekend


Add comment describing this if statement.


There's a method in FoodMartTestCase that does the native/non-native comparison, no need to duplicate.  verifySameNativeAndNot().


use "if self.env.context": instead of "if self.env.context is None:"


txIds -> txids


txIds <-> txids


Add comment


@dcoeurjo This introduced unused type Point.


The code actually executes on the server side to my knowledge.


``CC`` and ``${makejobs}`` should be already defined in https://github.com/voidlinux/void-packages/blob/master/common/build-style/gnu-makefile.sh


This is also the default for ``build_style=gnu-makefile`` https://github.com/voidlinux/void-packages/blob/master/common/build-style/gnu-makefile.sh


If a space ' ' follows (EE), (q[4] == ' ') command is true, which is 1, so the space ' ' is skipped because it returns 'q + 5'.


@dcoeurjo Same here


After comma need one space as per the PEP8 python standard. check on https://www.odoo.com/documentation/8.0/reference/guidelines.html


@mkambol, I know it. Unfortunately, it sets up ```EnableNativeTopCount = true``` always (https://github.com/pentaho/mondrian/blob/master/testsrc/main/mondrian/test/FoodMartTestCase.java#L437). That is why I used my own.


Thanks


@dcoeurjo Type Point is not used.


Do we see this on HipChat?


Awesome :) Right not I'm adding gobgp as dependency to FastNetMon's package :)


@dcoeurjo as before.


Rename button to other bFolder


Unusual variable assignment - save some bytes :)
if self.env.context.get('fetchmail_server_id'):
    values['fetchmail_server_id'] = self.env.context.get('fetchmail_server_id')


Use a groupBox instead of the label


Point


@cehallen DWMR of checkpoints 32 and 33. This looks really good. :+1:


Rename this button to bResize


WOW!
(Needed? ;) )


user self.env.ref instead of xmlid_to_res_id


Yes, this sounds as it should be the preferred solution.


This commit breaks the compatibility with almost all apps


Deleted


The application needs to set settings during its installation step


Account.changePassword can only be called by clientside. Like Brylie said, it is executed on the server side.


Rename to gbOutput


Keeping 'build_ids' file in the problem directory would cause attaching the file to Bugzilla bugs and that is not acceptable. We need to either add the file to the ignore list of Bugzilla format configuration files in libreport or change the code to something like this:

```
retcode=0
if $INSTALL_DI; then
   ...
    retcode=$?
   rm -f build_ids
fi

if [ $retcode = 0 ]; then
    ...
fi


What about 301?


I was only keeping them separate to not interfere with player astral flow but that's not implemented yet. I'll probably prefix player versions with "Player_" or just combine them all into one script. I'll figure it out today.


ooh good catch. forgot I had that in there. thanks for the tip.

~ Matt
> On Oct 2, 2015, at 12:02 AM, Damon Pollard <notifications@github.com> wrote:
>
> You probably shouldn't check this in. It appears to be a valid API key.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/maltepet/lightcalc-destiny/commit/b97e3e7f93f83cfdde5e259c66deed23cd6fd559#commitcomment-13555313>.
>


You only need the ``*-devel`` packages in makedepends, ``cmake`` is a hostmakedepend becaus it runs on the host architecture while cross compiling.


Does this fix the
```
conversion to 'int' from 'size_t {aka long unsigned int}' may alter its value [-Werror=conversion]
     plen = strlen(path);
          ^
```
error that I'm currently getting?


Variable declarations and record creations should be in "setUp" not in the test cases method


Please ignore this file, it used by our internal workflow tool and it needs to be in repo.


Stocking picking create twice so make one method and follow modulations


This copies the variable right?


remove " from openerp.tools.translate import _" and add into "from openerp import api, fields, models, _"


Revert this or adjust all other groupboxes


I put filter lists into separate file. I remember you objecting it, so I fixed that.


Revert or adjust all other radio buttons


Where string = "Name" ?


@codewarrior0 Is this pillow bug reported? Does it work when we restrict for testing the pillow to version 2.9.0?


I had to rename initial blocking lists to match with requested file names. Not big deal.


:+1:  feeling proud! hahaha


Where string = "Date" ?


Take a look at the ``python-Jinja2`` template as example for python modules.
``python_versions`` and ``pycompile_module`` should be defined.

https://github.com/voidlinux/void-packages/blob/a6cbdaa0a83ccd898f299c5fafeaa73abd92eb60/srcpkgs/python-Jinja2/template


Too much whitespace within the groupbox


`cbFunction` defines no argument or return types so they're inferred from the call. With a plain `operator()` a `void` return type is assumed. It's probably clear to the C++ compiler here that `negate` needs to return `bool` but is there any way for the template to know that?


/usr/local/bin/VBoxManage is on the standard system PATH, so should be available right away.
I did not have a chance to test this on a fresh Mac though.


I really meant `MBEDTLS_KEY_EXCHANGE_ECJPAKE_ENABLED` here. `MBEDTLS_ECJPAKE_C` is the non-TLS parts of EC J-PAKE (that is ecjpake.c). People might want to use that module outside TLS. On the other hand, `MBEDTLS_KEY_EXCHANGE_ECJPAKE_ENABLED` is the support for EC J-PAKE in TLS, so it's the right test here.

You'll probably notice that is is inconsistent with `ECDH_C` and `ECDSA_C`: I agree, and these should be fixed some day. But for new stuff I'd rather use the correct check.


1st Version


PS: so if you're using a minimal `config.h`, if should have `MBEDTLS_KEY_EXCHANGE_ECJPAKE_ENABLED` in it, in addition to `MBEDTLS_ECJPAKE_C`, just as the minimal config.h for NSA Suite B has `MBEDTLS_KEY_EXCHANGE_ECDHE_ECDSA_ENABLED` in addition to the base modules.


Nope, it's actually `out_msg` here. I guess you didn't pull the most recent commit in my branch, so you mistakenly reverted that fix.


2nd Version


Perhaps even better would be b'<(.+@.+)>'


Where did you learn to use a newline for array literals and not using a newline for the closing brace at the end..


This `QUERY_FORCE_DESCRIBE_PORTAL = 128;` happenes to collide with `static int QUERY_DISALLOW_BATCHING = 128;`
Was that intentional?
I'm facing degradation of executeBatch, and it looks like this 128 forces batch to be executed one-by-one


Don't enable this by default!


3rd Version


Where did the extra "QSTileHolder.java" come from???


This is already implemented in `abrt-action-perform-ccpp-analysis ` and  the tool is used in `EVENT=analyze_CCpp`. It would be better to either run the event or use the python tool,  the retracing behavior would be consistent in all our tools (gnome-abrt, abrt-cli, abrt).


Thank you for the hints. I will check it.


Can we enable it already?


The revision variable is used by voidlinux if the template file is changed. If you need another revision for the releases use a new variable prefixed with _ like ``_revision`` or just add it to the ``pycompile_module`` variable.


Should it be places here?
(Not under the fit mode groupbox?)


Just encountered this surprising construct, and dug down to this commit. I think a code comment would be welcome, something like "We are overriding query builder's methods, and the __call() magic is to allow both static and instance calls."


Whoops!  I'll create a new pull request to correct this.  Thanks for bringing it to my attention.


Is there some reason you can't just write `return new BigInteger("" + value)` for this method? Did you check the performance difference?


I'm getting this error after upgrading to 1.0.1 :

CRITICAL - Uncaught PHP Exception Twig_Error_Runtime: "An exception has been thrown during the rendering of a template ("Unable to find template "".") in "SonataAdminBundle:CRUD:base_edit_form.html.twig"."

any ideas ?


PS: oh, I see you noticed and reverted that. Sorry for the noise.


This looks a lot better but I think we can make this even simpler -- if we just pass in the set of ancestors of `toadd` to this function, we can get rid of `protect`, by just checking to see if `rootit` is an ancestor of `toadd`.  [Note that `setAncestors` is already calculated in `AcceptToMemoryPool()` before you call `TrimToSize()`.]

This way you don't need to even call `CalculateDescendants()` on things which are ancestors of `toadd` (and you don't need to modify `CalculateDescendants()` to take the extra argument).


@Mangetsu Could you try to find related issue or open a new one for that? Thanks.


Align these two radio buttons


Ah, sorry, ich hatte vergessen, dass das (noch) nicht im Gulp-Job mit drin ist. Jetzt sollte es hoffentlich passen.


Why not write `return value ? 1 : 0` here as well? In theory, that test will be faster than doing a nested method call + implicit widening cast.


In which way? It's just to prevent mistakes when trying to set a setting to a non-installed app since it will fail anyway here - but really less nicely: https://github.com/YunoHost/moulinette-yunohost/blob/unstable/lib/yunohost/app.py#L815

If it breaks something when getting a setting, I can do that check only with a *--value* argument.


olukianchikov, прошу откликнуться на адрес mtkachev@rambler.ru


Not understanding why getUIElement needs to be overridden; what's the wrapper div doing?


I would start with `uid_username = get_problem_field(prob, 'username')` and then I would try to get `username` like you do. It should avoid the confusion when dealing with uploaded problem directories.


remove if not assign in 'demo': []


You could generalize this one to `uint2(final Number value)`.


You could generalize this one to `int8(final Number value)`.


some unit test with the new fwk would be nice :)


You could generalize this one to `uint8(final Number value)`.


@irinasavchenko  Please follow the code standards


You could generalize this one to `uint12(final Number value)`.


You could generalize this one to `int16(final Number value)`.


You could generalize this one to `uint16(final Number value)`.


@danfuterman Please take a look at this commit and let me know if I'm going in the right direction. I have added some logic when updating the status of a test batch to only create deferrals for donors who have positive confirmatory test results. I'm not quite sure how this is going to fit in with the workflow changes for releasing tests.


You could generalize this one to `int32(final Number value)`.


You could generalize this one to `uint32(final Number value)`.


You could generalize this one to `int64(final Number value)`.


Declarations of variables and creations of records should be in setUp not into test case method


we should probably allow inheriting the annotation too (```@Inherited```)


code bad


Sorry. The version got lost in another branch. I fixed it.


Good one! I had this on my tree for 3.10.40


No need to keep track of the SelectedPath. There is only the need to check if the user selected a path.
So use a bool instead.


This operation doesn't actually do anything. The point of doing `& 0xff..ff` on something is to upcast the type to the next biggest thing. For example, if you have a `byte b` and write `b & 0xffff` then it becomes an `int` which has the unsigned representation of that byte. But since `value` is already a `long` here, `&`ing it with a `long` of all `1`s still returns a `long` which will still be negative if the long was negative before.


Typicaly here: https://github.com/Kloadut/roundcube_ynh/blob/master/scripts/install#L22

The app is not (yet) installed, and yet we have to store a value.
Will it fail ?


@sbe @brylie will it work if ```meteor remove insecure``` is performed ?

https://www.meteor.com/tutorials/blaze/security-with-methods


Lol


@taconaut is the resource being moved after creation, i.e. something along the lines of ```getChildren().remove(child)```?  There is a bug (which you've noted before too) involving global id expiring because ```DLNAList.remove()``` is effectively a "delete" operation insofar as global id is concerned (hence the 'removing id' message in the log), though how this might trigger recursion isn't obvious, could be just a side effect.  I have an unfinished fix for that issue btw.


See comment above.


``ImageDirectoryEntryToDataEx`` raises exception for an unloaded module, but
for ``Base = NULL`` it executes gracefully returning ``idte = NULL``.

Therefore i would suggest using the result of ``Base = GetCallingModule((UINT_PTR)importmodule)`` which will be ``NULL`` for unloaded modules in order to avoid raising exceptions, ie:
```
idte = (IMAGE_IMPORT_DESCRIPTOR*)ImageDirectoryEntryToDataEx(
            (PVOID)GetCallingModule((UINT_PTR)importmodule), TRUE,
            IMAGE_DIRECTORY_ENTRY_IMPORT, &size, &section);
```


You could generalize this one to `float32(final Number value)`.


cool :)


You could generalize this one to `float64(final Number value)`.


Yes, the resize/reposition based on guessing ("the only way to know it is detached..") needs to go.

Instead, do that when we know it's a new, detached tab opened from an action, calling positionFromModel(), which actually needs to position (as it did) and resize (which it failed to do).


Which ones? @jereksel


Revert this please. See comment above.


@Ari64 I tracked down a crash in Glover. It seems to be caused by an unneeded upper register being used in a branch delay slot.

For the moment I fixed the issue by checking if the register is actually needed before using it.

But from what I understood looking at your code, all unneeded registers should be removed from the regmap after "Pass 3 - Register allocation".

I noticed that you don't clear unneeded (upper) registers in the delay slot because branches might use them. But shouldn't unneeded registers be cleared after branch post-allocation?

```
if(r<64){
  if((current.u>>r)&1) {
    regs[i].regmap_entry[hr]=-1;
    regs[i].regmap[hr]=-1;
    //Don't clear regs in the delay slot as the branch might need them
    //current.regmap[hr]=-1;
  }else
    regs[i].regmap_entry[hr]=r;
}
else {
  if((current.uu>>(r&63))&1) {
    regs[i].regmap_entry[hr]=-1;
    regs[i].regmap[hr]=-1;
    //Don't clear regs in the delay slot as the branch might need them
    //current.regmap[hr]=-1;
  }else
    regs[i].regmap_entry[hr]=r;
}
```


This is the third implementation of `reported_to` parser :) I would add a Python binding for `read_entire_reported_to_data` [1] and use it instead of the lines below.

1: https://github.com/abrt/libreport/blob/master/src/lib/reported_to.c#L146


Should this be `SQLITE_MAX_VARIABLE_NUMBER as SQLITE_MAX_IN_STATEMENT`?


Check if the user selected a path


Don't use @api.one


worked on win7 ! Thx!


Why not to use the problem data formatting functions from https://github.com/abrt/libreport/blob/master/src/lib/problem_report.c ?


@dpo I am currently creating an improved formula for octave 4. However, I have still problems with osmesa. Maybe you could also have a look?


After you changes i got this mistakes:
```
class TestController extends Controller
{
    public function actionIndex($arg1, $arg2)
    {
        var_dump(func_get_args());
    }
}
```

output:
```
./yii test arg1 arg2 arg3
array(2) {
  [0] =>
  string(4) "arg1"
  [1] =>
  string(4) "arg2"
}
```


Change to file?


h


You can't require the ResourceLocator to implement getDispatcher(), this means that ResourceLocator is now on the hook essentially for the whole legacy api.


I'm now working on fixing this and #7 and I forgot which one it was (I think it was one of B&W) - forget about it.


Unfortunately, this was all done in a rush for the BF deadline, so this is too messy :( The other issue that stands out to me is that really the extra fields should be per-jurisdiction, not per-election, since the person edit page is not specific to an election so you have to have *all* extra fields there. I'll fix that aspect - I think that in the long run having a model representing the jurisdiction in the DB would probably be a good idea, in which case, yes, defining any extra fields there, as you say FMS does, would be possible.


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


bill tonight


This commit is being reviewed as a part of review issue #3.


Change name as mentioned earlier


Исправления к заданию:

1. Убрать лишние отступы перед внутри скобок тела функции.

2а. Переместить ```xhr.ontimeout``` и ```xhr.onreadystatechange``` до вызова ```xhr.send``` (обработчики событий назначаем всегда до возможных действий).

2в. Также, переместить вызов загрузки картинки ````templateImage.src = picture.url;``` после обработчиков.

3. Переместить ```picturesElement.classList.remove('pictures-loading');``` внутрь callback-функции перед вызовом renderPictures.

4. Переместить блок ```if (xhr.status > 400) { showLoadFailure(); }``` внутрь блока проверки ```if (xhr.readyState === 4) {}``` до этого это будет просто бессмысленно, так?

5. Сделать форматирование одинаковым (скобки, пробелы и прочее).


Thank you very much!


ABRT tools use `ask_yes_no` from https://github.com/abrt/libreport/blob/master/src/lib/client.c , so I would use the function in abrt-cli-ng too. This function is not localized and cannot be used in non-interactive mode.


Alright, cool


Sorry for the late feedback here, but I really want to avoid adding this cruft to the new form: it will really set back efforts to wean ourselves off all these builtin fields.

Can you rather add the concept of locks to the FormClass? One way to simplify things _and_ prepare us for the future would be to add a set of ResourceLocks to FormClass which looks like this:

```
class ResourceLock {
   String lockMessage;
   String lockExpression;
}
```
Then you can just add some code to GetFormClassHandler to translate the current db/form/partner locks to expressions.


this commit looks fine


Entirely empty text sounds like an error, why is it ignored?


Looks good.  Could you add a test in TestHighlightingMatcher?


linha de espaço para testar o com.


hmm that's unfortunate, but I guess its better to get working what we can in the short term and incrementally support this later


Are we using servlet 2.5 or 3.0?  With 3.0 the error code is not needed, and means we don't need multiple entries for 404, 500, etc.


Ok, lets keep legacy code away from our new structure. I will do it.


Really... 好吧被批评了。。。


What is "isBlank()"? Why not `isEmpty()`? And why use the word "blank" instead of "empty" in the message?


I will add the comment, but it should not be defined as private, because of the private methods cannot be called within Closures.


this commit looks okay


is it really necessary?


This will conflict with PR https://github.com/dotnet/wcf/pull/383 which moves to 99


looks good to me


The warning you added is on the melphalan function, so perhaps we should change that also


Thanks!


What about multi-declarations, for loops, lambdas etc?


It should say what the name in question is


Writing `? true : false;` is redundant. You can write it more simply as `return value.compareTo(BigInteger.ZERO) != 0;`


I was just going to propose this as part of performance improvement.
I was still testing it.
I have also removed the record-by-record access check in `get_records` method line 1297 as only allowed records are retrieved anyway.


Ah, danke, da wäre ich glaub ich nie drauf gekommen.
In dem Fall würde ich wohl auch zu "G" raten.

Ich habe sogar schon überlegt, ob wir statt "Verlaufsgitter" nicht
vielleicht sogar "Gitterverlauf" schreiben sollten. Ersteres entspricht
der Übersetzung für "gradient mesh" in Adobe Illustrator, wobei das
natürlich noch lange nicht bedeuten muss, dass es die beste Übersetzung ist.

Am 02.10.2015 um 14:33 schrieb Moini:
>
> Das ist unten links im Füllungs-/Kontur-Indikatorfeld. Wenn ein Objekt
> mit einem Verlauf ausgewählt ist, steht vor dem entsprechenden
> Farbfeld ein einzelner Buchstabe, der anzeigt, ob es sich um einen
> radialen (R), linearen (L) oder gitterförmigen (V/G/?) Verlauf handelt.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Ede123/inkscape-localization/commit/5b49a649b4b264b5c611d9fadabe0b1c7832131e#commitcomment-13561178>.
>


You don't need parentheses here. `return value != 0;`


No test for empty name:

``` kotlin
class `` {}
```


Better to write `return value != 0;` just like for the `long` case. This avoids a nested method call, but more importantly avoids a problem with e.g. `0.5` returning `false` instead of `true` as expected.


Too few tests for contexts: class type parameters, enum literals, local declarations etc


It doesn't really harm, because ESCAPED_IDENTIFIER always non-empty (see flex-file).


Nope, since the app is already considered as "installed" by YunoHost - which only consists of checking if a folder exists in `/etc/yunohost/apps` with the *app_id*.


Please show this commit to the author of these tests


Should this return `byte` instead of `long`?


How is this related to the rest of the changes?


I thik better way is to use `@note` or `@warn` yardoc tags


Let's take this to Dev and see how it works in other areas besides SF.


Should this return `short` instead of `int`?


Should this return `short` instead of `long`?


This is a nice change, but definitely should have warranted a minor version bump.

The rails application I am working on broke when upgrading from `devise-invitable` `v1.5.1` --> `v1.5.2`, due to the removal of `User.skip_password` -- something that should not happen on a micro version update!


I may be wrong here. Are names which contains only spaces should be allowed?


Return `BigInteger` instead of `long`.


Okay I just see how Stream and Download where put, and I think 'Visionner' instead of 'Stream' would be a better choice. ^^
I let you do the change, I'm not comfortable with Github. ^^'


Can't just do this though. We still try to require it so it will fail in the browser. You need to try catch the require and handle the function call.


I think this method can go away after changing `uint128(long)` above.


I wonder if this shouldn't return true? If it is a path, we're not concerned with anyhow, we should probably ignore it, no?


This is a lossy cast. We should do it differently. Otherwise, large exponent doubles will not convert to the expected `BigInteger` values. It might work to write `new BigInteger("" + value);`? Would need to test with e.g. `1.2345e300` and similar values.


cc @wronk I updated this, @staulu let me know if you want a different URL for your name or don't want any credit :)


I tried to estimate possibilities of such move, ended with this now:
```

json_req_obj_for_externals(Req, Db) ->
    json_req_obj(Req, Db, null, all).
json_req_obj_for_externals(Req, Db, DocId) ->
    json_req_obj(Req, Db, DocId, all).

json_req_obj_for_rewrites(Req, Db) ->
    Fields = [F || F <- json_req_obj_fields(),
              F =/= <<"info">>, F =/= <<"form">>,
              F =/= <<"uuid">>, F =/= <<"id">>],
    json_req_obj(Req, Db, null, Fields).

json_req_obj(Req, Db) -> json_req_obj(Req, Db, null).
json_req_obj(Req, Db, DocId) -> json_req_obj(Req, Db, DocId, all).
json_req_obj(Req, Db, DocId, all) ->
    Fields = json_req_obj_fields(),
    json_req_obj(Req, Db, DocId, Fields);
json_req_obj(Req, Db, DocId, Fields) when is_list(Fields) ->
    [{Field, json_req_obj_field(Field, Req, Db, DocId)} || Field <- Fields].

json_req_obj_fields() ->
    [<<"info">>, <<"uuid">>, <<"id">>, <<"method">>, <<"requestted_path">>,
     <<"path">>, <<"raw_path">>, <<"query">>, <<"headers">>, <<"body">>,
     <<"peer">>, <<"form">>, <<"cookie">>, <<"userCtx">>, <<"secObj">>].

json_req_obj_field(<<"info">>, #httpd{}, Db, _DocId) ->
    {ok, Info} = get_db_info(Db),
    {Info};
json_req_obj_field(<<"uuid">>, #httpd{}, _Db, _DocId) ->
    couch_uuids:new();
json_req_obj_field(<<"id">>, #httpd{}, _Db, DocId) ->
    DocId;
json_req_obj_field(<<"requested_path">>, #httpd{}=Req, _Db, _DocId) ->
    Req#httpd.requested_path_parts;
json_req_obj_field(<<"path">>, Req, #httpd{}=Req, _DocId) ->
    Req#httpd.path_parts;
json_req_obj_field(<<"raw_path">>, #httpd{mochi_req=Req}, _Db, _DocId) ->
    Req:get(raw_path);
json_req_obj_field(<<"query">>, #httpd{mochi_req=Req}, _Db, _DocId) ->
    json_query_keys(to_json_terms(Req:parse_qs()));
json_req_obj_field(<<"headers">>, #httpd{mochi_req=Req}, _Db, _DocId) ->
    Headers = Req:get(headers),
    Hlist = mochiweb_headers:to_list(Headers),
    to_json_terms(Hlist);
json_req_obj_field(<<"body">>, #httpd{req_body=undefined, mochi_req=Req}, _Db, _DocId) ->
    MaxSize = config:get_integer("couchdb", "max_document_size", 4294967296),
    Req:recv_body(MaxSize);
json_req_obj_field(<<"body">>, #httpd{req_body=Body}, _Db, _DocId) ->
    Body;
json_req_obj_field(<<"peer">>, #httpd{mochi_req=Req}, _Db, _DocId) ->
    ?l2b(Req:get(peer));
json_req_obj_field(<<"form">>, #httpd{mochi_req=Req, method='POST'}=HttpReq, Db, DocId) ->
    Body = json_req_obj_field(<<"body">>, HttpReq, Db, DocId),
    ParsedForm = case Req:get_primary_header_value("content-type") of
        "application/x-www-form-urlencoded" ->
            mochiweb_util:parse_qs(Body);
        _ ->
            []
    end,
    to_json_terms(ParsedForm);
json_req_obj_field(<<"form">>, #httpd{}, _Db, _DocId) ->
    to_json_terms([]);
json_req_obj_field(<<"cookies">>, #httpd{mochi_req=Req}, _Db, _DocId) ->
    to_json_terms(Req:parse_cookie());
json_req_obj_field(<<"userCtx">>, #httpd{}, Db, _DocId) ->
    couch_util:json_user_ctx(Db);
json_req_obj_field(<<"secObj">>, #httpd{}, Db, _DocId) ->
    couch_db:get_security(Db).
```

a) existed tests should not get affected by this
b) while we return different object, we also have different high level function for this, but it still based on the same internals.

What do you think?


What's the problem and on what version of OSX? On 10.9, I can build `--with-osmesa` without trouble.


@ckamm do you think we can have a unit test for the ExcludedFiles class? That would be cool.
Otherwise great!


Was it ever explained why this change was made? We had toruble with an third-party vendor's tracking scripts because of this.


lgtm


Nice, but wouldn't an extra check against null ptrs be valid for the ``sol_flow_packet_new(SOL_FLOW_PACKET_TYPE_STRING, "My String")`` case? Maybe one more ``SOL_NULL_CHECK`` at ``string_packet_init()``.


Nope. This was just made, with no explanation.


I think the test should be in TestMonitor, rather than ConcurrentMatcherTestBase?  And I don't think we need to worry about testing immutability here.


Good catch, I hadn't considered that. I was trying to catch all possible post types. Is there a function that returns the plural name of the CPT?


fixes #36


Another option altogether: wrap the URL in a filter and let theme devs figure it out from there. I've had a couple of situations where I wanted to remove the URL altogether and a filter there would have been much more convenient.


Instead of `built` I would call it `method` since it is the name of the method. But this is a nitpick; we can rename it later.


@mativs groso


Kotlin.flex: there is no way to get empty name
```
ESCAPED_IDENTIFIER = `[^`\n]+`
```
 I'll add more tests.


I think this inverted the logic everywhere, strncmp is 0 when strings are matching


Missing license header.


This won't work. Please increase the version number and check for everything smaller than the new incremented version. Otherwise git master instances won't update properly the mimetypes (the same as test instances with daily packages).


Fix issue #39


If `version.second` is `LOCAL_CACHE` it would fail but should still be added, otherwise is *shouldn't* fail. Changed it to make that a bit more robust, thanks!:)


I'll do it.


I'll change it.


Can you add spaces, like `} else {`


@skeptical [this](https://github.com/taconaut/ums-mlx/blob/master/core/src/main/java/net/pms/medialibrary/dlna/MediaLibraryFolder.java#L216) is the only remove call which could be triggered by my code, but it shouldn't as there were no changes for the set child folders AFAICT.
I'm wondering where the root in `The previous parent node was: root` comes from. It's not supposed to have been added to any folder called root before the children are being added to the `VirtualFolder` in `AdditionalFoldersAtRootWrapper`. I might have missed a piece of code when moving mlx from pms to ums, where ExternalListeners would still be added to the root folder by ums (which might also explain the two instances of Channel you've talked about before).


You don't have to cast these constants to `byte`. You can write:
```java
	final byte[] inArray = { 12, 122, 9, -6, 56, 34, 108, 1, 73 };
```


can you add spaces? `->resize(150, 150, false, true)`


It seems this commit is unnecessary now.
Without it maven build failed on agent `mps-ubuntu-v2-i-4e787a9b`.


Is it worth taking advantage of py.exe ([PEP397](https://www.python.org/dev/peps/pep-0397/)) and doing:

py -3.5-32 setup.py build_ext --inplace
py -3.5-64 setup.py build_ext --inplace

py.exe is designed to deal with finding the right python version wherever it is installed (and from 3.5 also works with venv)


See http://imagej.net/Coding_style#Ordering_of_code_blocks


Are you sure that you really build with osmesa? Even if you enable it, octave might just ignore it because it does not find gl.h.
This is the problem on 10.10 and 10.11 with recent Xquartz (beta). If I help a bit, i.e., changing "<GL/gl.h>" to "<gl.h>",  then I get `error: unknown type name 'GLAPI'`.


Inconsistent indentation detected.


@Ari64 I tracked down another crash in castlevania. It seems to be caused by an allocated temporary register that gets replaced by another register during "Pass 5 - Pre-allocate registers", leaving no temp register in the regmap (minimum_free_regs=1).

For the moment I fixed the issue by checking if there is more free regs than the minimum_free_regs value. This should avoid replacing an allocated temp register.

Of course I only fixed the issue for that particular case but I think this might happen for all ````if(regs[i].regmap[hr]<0&&regs[i+1].regmap_entry[hr]<0)``` cases.

What's your opinion?


Rename this to taskName


Javadoc is written in complete sentences. And use `@link` and `@code` each where appropriate. I.e.:

```java
 * Tests that {@link ConvertTypes} works on {@link Img} objects via {@code ops.map}.
```


Looks like I misspelled "canola"!


I copy here the include files of mesa to the build dir and change GL/gl.h to gl.h in osmesa.h. This allows Octave's configure script to compile its test and to detect osmesa. However, when making 'GLAPI' is undefined.


It should work fine with insecure removed. Which brings up the issue that we need to remove insecure ASAP. We will do so in a specific branch related to testing and removal of insecure only.


Much better; thanks!


Why not move those flags (bit masks) to  their own class where they can all be found and kept in order ?


I have no idea why this is so complicated and if it is necessarily so. I just mirrored the prepareSendingText() function.


Oh man this is funny. I love how you changed the name so `@tobi` wouldn't notice.


No, it's not. It's simply a junk file I like to keep around.


Esta forma de hacer el validateInput (especialmemte el ultimo if ahi donde revisa los argumentos) definitivamente no es la mejor forma de implementarlo..prefiero dejar lo que hice en el main, que aparte tambien extrae los paths en sus respectivas variables.


I would initialize $success as TRUE so you don't need to do the negated !commerce_payment_example_simulate_failure($donation) call, which just looks weird.


@ace2nutzer, are these delays right to fix BS bug in LPM?


Mission accomplished.


Actually, come to think of it. This commit was when we were arguing about Turbolinks vs Ember back almost two years ago in February. I remember `@tobi` told @jacojoubert to mark the fact that he'd be back to using turbolinks in his calendar two years into the future. Feb, 2016's coming up fast, lol.


fixed


comments?


Ah, indeed :( . Yeah, I guess I didn't notice it because I have all my `request` stuff disabled right now; not fast enough.


Fix #39


I'll pass since it's still present on master & don't want auto reject to block dep ;)


Fixes #440


I guess you can do directly msg.translation = translation and msg.rotation = q


I don't think the conversion to numpy array is needed


I've used this for a couple of days now and on my OSX I've noticed some inline diffs are truncated.


Hm that certainly works once the regional contests are completed (as they are now), but if in the future if the global contest is in its proposals creation phase while the regional contests are going through the selection and voting phases (which happened this year), you wouldn't always be able to select the same proposals.
This would mean that the amount of proposals you can select varies as the phases of the regional contests progress (it would gradually decrease and then suddenly go back up to its max value), which I think would be weird to understand for users. What do you think?


ble ble


How about checking the return of these `'sol_vector_get()``'s?


Very good point :)


It works, but costs O(n^2) time.


LGTM


Good point, I will also include windows and system directories last, as a last resort, since all the other paths are predefined and are more likely to contain the symbols files.


why no mac support

:-1:


Staking your ground with this project?


Actually no, off by one error. This commit is from Feb 2013. Tom Dale's always doing things a year earlier.


Why?


You can swap 2 strings according to their lengths.


Missing  comment :
                    // Show the problem immediately to the user.


make a pr including it if you want it


Oh I see. You're right. Octave silently ignores it. On my system, `osmesa.h` is located in `/opt/X11/include/GL/osmesa.h`. I'm currently rebuilding after adding `depends_on :x11 if build.with? "osmesa"` and `configure` found `GL/osmesa.h`.


Yep!  That constant looks to be gone here on master now anyway.


I kinda accounted for DW races, sorta; there's a full demographic theme spectrum ranging from DW only->DW+human slaves->DW elites/mages+human troops/slaves->DW sacreds/strong mages+human troops/slaves/weak mages->humans only, with the third being the most common, and the first and fifth the least.

PD selection also need to make sure there's an appropriate PD commander; i.e., at least #poor[magic/undead]leader if PD includes magic/undead/demonic troops.


Thanks :D


It's for tomorrow. Give me some time to push something!


Will that calloc be freed too?


Danke :) - das G ist jetzt drin. Und nebenbei habe ich auch noch git rebase kennengelernt ;)

Gitterverlauf find ich auch ok, ist dann etwas konsistenter, und eigentlich sogar leichter zu verstehen. (allerdings: Google 800 Hits für Gitterverlauf, 15000 für Verlaufsgitter - wohl dann in der Illustrator-Übersetzung begründet).
Die restlichen Fragen / Unsicherheiten sind als Kommentare drin. Ich nehm die nach Klärung auch gern wieder raus ;)  (und übersetze die 'Bedeutungs'-Kommentare, denn die sind vielleicht für Übersetzer anderer Sprachen hilfreich).


This API change is a bit confusing for me, as I'm trying to update telegram-purple to use the new API (so we can test and eventually use it).

What is the replacement for `bl_do_encr_chat_delete`? Is the encrypted chat a peer, and we should call `bl_do_peer_delete`?

And why is `bl_do_peer_delete` declared twice? (I'm sure that's a typo, but I better ask before I make a PR from that.)


I like the idea of removing the constants from index/global in favour of passing them as parameters when initializing Pico. If anyone was relying on the depreciated constants, you've taken care of that in the 00-PicoDepreciated class. I feel that this change makes Pico more modular and flexible. :+1:


Did you mean to actually do this TODO?


If your source is a text field, you probably want this to be a text field, since a `string` field will just store the literal value. This wouldn't be very good.

So you might consider changing your model to a One-to-Many relationship with a Synonyms table and storing a list of synonyms there, and then indexing it in Solr as a multivalued string field.