TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 74](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=315&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **SUCCESS**
Summary: Running Build time: 00:01:59


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 75](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=317&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


thanks, wasn’t aware of this ;) indeed I had different PHP versions access the same complied template


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 75](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=317&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:28


If you want to avoid the found/break/if (!found) structure, you could add a method returning true if found, false if not, then then just
```java
if(driverMissing(driver, databaseDriver){
    unknownDrivers.add(driver);
}
```

You don't save lines, but it's a little clearer, and I guess you didn't like it this way, given the commit message :)


Indeed it's confusing.


this newline should rather belong below line 45 :) (missing newline before EOF)


I also think that combo patches should not include patches that failed in LTC(only the yellow ones should be combined).


Por favor, no olvides actualizar tu perfil en GitHub con foto, ciudad y universidad.


Hi @diversys; I'm not able to comment as I am unfortunately not able to speak Russian.  Are you able to discuss with @Akujiism and create another pull-request or let me know the change you want to make?


I love commits like this! Thanks @petrsloup for thinking this through with me yesterday. Great job on the simplification.


Pon en tu perfil tu universidad y ciudad, por favor.


Actualiza tu perfil con imagen, ciudad y universidad, por favor.


Agreed. Will update this in a separate patch. The keys parameter should allow the user to specify the order in which the data gets painted and it should be optional


what's the reason for this test move?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1133](https://teamcity.mesosphere.io/viewLog.html?buildId=59504&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 181 Build time: 00:08:35


:panda_face: = :smile:


Seems that I was testing with `SUBJECTS_DIR` set to a sane place with a suitable `fsaverage` subject in place. In that case, `omitted_info` was initialised by the time this call came. When I chose a different dir (or none), I got the same `KeyError` as you reported. Couldn't figure out why the initialisation didn't happen in time, so patched like so.


:ok:


To put it another way, would everything work as expected if we put the function `render` here?


ah sorry, didn't read the conversation before, my fault.


Already have :) It looks like the problem is that the values here are space separated, however "Bundled"  (as in
Package Version Bundled Localization Coverage) translation here consists of two words so he had to use the underscore.


from
http://dhost.info/jkarretero/jwifiapi/install.html


Thanks for your quick response, I created an issue: https://github.com/jayway/rest-assured/issues/602
I'd prefer simply using a String constant since the UTF8 charset's name is unlikely to change any time soon.


@kaithar

*I suspect you're more likely going to need to take issue with far more than a single developer if you wish to complain about people giving "Bro" a bad image*

I highly doubt I will need to take issue with a single developer outside certain areas of the United States. As one of the Brotli devs already stated: "Even if we don't understand why people are upset from our cultural standpoint, they [i.e. certain Americans who were consulted as representative of their group] would be (unnecessarily) upset". There are two problems with this:

1. The world is a big place, filled with various cultures and value systems. To  try and accommodate all of them is probably not even feasible.

2. As I will expand on below, the accommodation here is being made at a purely technical level - a *content-type abbreviation*  - which is not even *meant* to be read by any human from the potentially affected cultures anyway.

*As developers, our job should include considering how other people might interact with our work and behaving accordingly*

I agree, and that is exactly why this particular example is so (arguably) ridiculous : you are talking about a content-type abbreviation, a string which is supposed *to be read by a machine, not an ordinary user*. The only humans who may actually *need* to see the string are typically developers, sysadmins or other tech people, and those are very unlikely to understand it as anything but what it is. They will know that it has not social or cultural connotation whatsoever - it is simply a short form of "brotli".


I think the readconfig() function should be defined because for modifications later. Ex, we can put the handler for "time to run" ?


Correction : `received`


just done strip_tags, that works as well here. ede60c58e316666e9ab1c844190ea353fcb4c349


:+1:  thanks a


Is it possible to do something about plural strings like this?


Make this a builder instead?

.withProxyConfiguration(config)
.withHttpClient(com.ft.messagequeueproducer.HttpClient)
.build()

AND

.withProxyConfiguration(config)
.withJerseyHttpClient(com.sun.jersey.api.client.Client)
.build()


Please stick to the [Google Style Guide](https://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Parameter_Ordering) for input and output parameters. TL;DR: Input parameters should be `const&` or `const*` while output parameters should always be non-const pointers.

Furthermore: References to integral types don't really make sense from a performance point-of-view, as the reference takes up just as much space as an integer and (might) introduce an indirection during execution.


@niklasravnsborg Bitte aufpassen, mit dem Commit hast du nen Bug reingebaut: Man kann jetzt keine Personen mehr registrieren, da Laravel auf `password_confirmation` zugreift. Wir können das ändern, aber dann sag vorher Bescheid oder teste es ;)


This might potentially spam the hell out of an import... if every line have more data than the header says. Don't think that's something we want. Either print how many lines had extra data at the end of the import, or just print the first occurence like `hmm, it looks like some rows have more data than the header specifies` or something.


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 17](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=318&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


Download as ZIP-File with world-file is not yet supported by QGIS Server. For me, that is not so important that I really need it - so I will probably not invest in this financially.

However, if you can think about a client-side solution - I am open to integrate it with QWC. It will probably need a separate button where the client generates the content of the world file and then the use would have to copy/paste it into a text file and save it. Doesn't sound very userfriendly to me.

Or - if it is important to you - you can hire a QGIS server dev to implement it serverside.

Or a third solution would be to have a Python WSGI script to generate this zip, getting the image from QGIS server and generating the world file and then zip the whole thing. Probably the most feasible and elegant solution for now without having to change QGIS server.


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 17](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=318&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **SUCCESS**
Summary: Running Build time: 00:00:23


This way you can remove the logic of instantiating com.ft.messagequeueproducer.JerseyClient in every producer


this needs squashing with the previous commit, that'll show also that you forgot to remove the imports you added just for the tests in the test_plural file.

I'm discussing the use of parametrize with etanol now because I do think it's better to use it, see [discussion on gitter](https://gitter.im/python-babel/babel?at=5620c82c34cd85cd6d5c53cb).


'===' instead '=='


Yeah a way to traverse the chain would indeed be nice (it's basically what I tried to do with the 'tag' system, though for different reasons). Not sure if there's any easy way we can find out the calling object, well we could do so by investigating the stack but if a static list is 'hardly elegant' then messing around with the stack is downright ugly. So we'd need a better way to keep track of the calling object.

One way would be to keep track of the 'active' chain somehow though, although there might be multiple chains active at the same time.

Alternatively we could require a Chain to be called with a reference to it's calling object, it might actually be possible to get that work nicely if we simply redefine the '+' operator.


git checkout <nom branche>


Just for test, it does not have any meaning


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 18](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=319&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


I can't leave it out. What I do is I mvn install locally first when a package is not in the oficial mV repo.

Also, the idea is not to use this as-is. The idea is for people to copy the structure here into their own git setups and customize to their needs, This project is just a template.


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 18](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=319&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **SUCCESS**
Summary: Running Build time: 00:00:27


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 19](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=320&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 19](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=320&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:17


@tstastny can you take a quick look at this point. I don't intend to make any more big changes at this moment.


No direct LDAP auth possible on OpenBSD - a local NIS server has to get info from LDAP, so the suggestion of using LDAP instead does not apply


Thanks for pieces of advice. I made refactoring of a code.


I would rename the `urlSync` option to `syncUrl`, and allow the `true` and `false` value; WDYT?


Sorry, this char is used for read() function in test code. And I forget to delete it.


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 20](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=321&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


Can explain the logical meaning of the (-ов)?


Look - I can comment on your commits!


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 20](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=321&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:18


:+1: But I thinkg true/false is already working?


Wiki updated with ``make_install` action option example.


Maybe it's not good or have some performance issue for this.


hm. As I understand, I'm already done this and my changes are in the master branch of chef-cookbooks/iis.
https://github.com/chef-cookbooks/iis/pulls?q=is%3Apr+is%3Aclosed


What is `+` ?


I see,I screwed this one up.
It queries wrong package name, will fix it.


You are forgiven :)  Jetty9 is much higher level and in that case I can understand you'd want to optimize to the extreme and have full control over what's happening at "guts level".


Oops, the commit message should have said PR #783 instead.


We want to avoid this type of ifdef. The rotation for different boards should be all together in one single place. See how MPU9250 defines a `_default_rotation` field to be set on the constructor. You can have separate fields here for gyro and accel.


develop (mjwitte) - x86_64-MacOS-10.9-clang: OK (1415 of 1417 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.86%25-yellow.svg)


I guess you have made these names exported by switching to `import ... as ...`. PEP 484 about stubs:

> Modules and variables imported into the stub are not considered exported from the stub unless the import uses the import ... as ... form.


@Tsunamical, a cleaner way to customize charger.
It's better because we can use stock healthd, and the animation is softer.

Will try now.


You're right, it doesn't. The python driver doesn't send any optargs. I just added this since it was using a function below the level that added the noreply optarg


Well, I do think you might wanna use

```javascript
fs.exists(path, callback)
```


We had agreed that the `init` method in this class derived from the `IEstimator` base class would take also as input a reference to the resource finder, but all the additional input parameters in these two `init` methods, should they appear in my base class as well? Or should I just leave them in this class as particular implementations. I don't think all the other derived estimators will have such inputs.


You can remove this commit since it was already applied and here you only have changes to coding style. Btw, here is a tip:  when you are rebasing, if there's a conflict and you know the commit was already applied in general you can just continue with `git rebase --skip` so the commit will be dropped.


I assume this will be called by the implemented `run()` of this class. Am I right?


can you show the application URL to  it


I fixed one it's / its, otherwise LGTM. Thank you!


This changes around some config nodes, so make sure you backup the config file before adding this to the server. Also, delete english.yml, german.yml, spanish.yml so they regenerate on server restart.


You want to look at `collectd.conf.tmpl`. The `.conf` is actually not the one that's used in most cases (that repo is weird and needs to be cleaned up).


As you see on my comment on the first commit, this one should be squashed there. This one is very simple and can be done with a single `git rebase -i`.


@cnathe You'll want to re-run your loadApplication ETL after syncing this.


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1418 of 1420 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.86%25-yellow.svg)


This was done poorly.


Mypy was exporting then *before* this commit, i.e. without the `as`.

Regardless of what the PEP *says*, it is my opinion that it's worth considering current implementation limitations, especially given how many broken stubs (and non-stubs) this found.

But this commit is separate so it can be dropped if consensus is against it. That said, it would be painful to maintain this as a tools-specific override.


`floatingBaseOdometryBased` seems a bit too general to me.


Custom domain


@zmLGBBM I considered that, but that would mean having to require the fs library for one line of code. I know this line is less than ideal, but I decided I'd like to minimize the libraries Terminal-Plus has to bring in.


Please, make sure your settings are correct, (visible meta, 800x600, text), Thanks


This method needs and this class needs comments. It is hard to understand the null case and the Empty case without comments.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1226](https://teamcity.mesosphere.io/viewLog.html?buildId=60043&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:06:44


Might just r github but this is messing up when trying to view in rich diff.


Yep exactly.

On Fri, Oct 16, 2015 at 6:40 PM, SamProtas <notifications@github.com> wrote:

> The error here says the consumer key on y3 is invalid or missing
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jmc856/Webpage/commit/1beb779f20e8ffc00b991ec053de5b7dca818b8e#commitcomment-13828056>
> .
>


What about having this value to `0` as it's the default ruleset, then below, setting it to `0` or `2` so we can clearly show it being modified.


I left some comments in the JavaDoc which are very specific to Read-Only. Since there's no plan to add BDB support for this in the near future, I'd say we should leave it as is. Furthermore, it wouldn't necessarily hurt to introduce the setting for BDB under a different config name later down the line (but if we really want to unify it later, then we can also change the config name later down the line, or make the RO config an alias for the general one...).


My idea was that to move the `simpleLeggedOdometry` class to iDynTree and use it both in wholeBodyDynamicsTree and here . Even by just import it locally, I think it is better to have a  `SingleLeggedOdometryEstimator` that inherits from `IEstimator` that inside has an instance of the `SimpleLeggedOdometry` class. In this way then the `init()` method of this called will be called by the init of SingleLeggedOdometryEstimator , given the configuration contained in the resourceFinder .


Yes, see previous answers for more details.


It looks like a bug in Mypy that is not that hard to fix I guess. It should respect the PEP here and shouldn't "export" imported names from builtins unless they are imported using `import ... as ...`.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1227](https://teamcity.mesosphere.io/viewLog.html?buildId=60045&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:05:15


Oh yes, of course.


Yeah... the problem is not that "the Linux kernel changed the interface for PWM". The thing problem is the standard/unified API for controlling PWM was only added on 3.11 (https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-pwm)

So... in order to use the custom-made ones before the unification we should pay attention not only on the path, but also the meaning of each field. I agree with deriving a class for that, but it won't be "use this for kernels before 3.11", it will be "use this for Bebop".


The [Travis build](https://travis-ci.org/piskvorky/gensim/builds/85786197) failed after this commit!


This patch adds a MP4FreeH264SeqPictHeaders function.
The mac macBuildReleaseLibs.sh script adds removes debugging info.  It also makes a new folder to do the build in and cleans up when the build finishes so there is not a bunch of garbage laying around to interfere when adding the new code to git.


CC variable can also contain whitespaces (although it's discouraged to do that), but it's safer to quote it as well


It certainly is much cleaner without and I don't for see any significant change in their usage in the near future so I'll leave them out for now.


I think the class_exists needs to be after the App::uses call. App::uses doesn't load anything, just tells PHP where to look for class loads.


There are a few places in which you can rely on PATH_MAX. Accessing sysfs is one of them.

Regarding the stack usage, it's prohibitive to use PATH_MAX if you are in board-independent code.  PX4 tasks run with very limited stack size (I **think** it's 8k). So clearly using 4k in a single function can't happen.

On linux-only code I don't see a problem since we have much more stack available. Currently we use 8MB if the kernel's default wasn't changed, but we will change that so we don't lock too much memory as we grow the number of threads we use.


perl is not in `@system` afais or otherwise special, any reason we don't add it to DEPEND/RDEPEND?


for the*


sorry, i'm being really stupid right now.  actuallly overworked.  you're absolutely right.  bump coming.


on another note, upstream readme says something about `ctags` being a req? https://github.com/lvc/abi-compliance-checker/blob/master/README#L17


well done.


No no no no no!!


please update copyright year... I think `repoman full` warns about this, no?


just check the return value when you are writing the file? There's a TOCTOU here that doesn't really matter, but yet we should avoid code like this.


Please don't do this, the entire meaning of that test is to show we can load dynamically directly from the Herd


"autoryzować" is a calque from English – "upoważnić" is the proper translation.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1228](https://teamcity.mesosphere.io/viewLog.html?buildId=60048&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:04:33


Ok, I'll change it.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1229](https://teamcity.mesosphere.io/viewLog.html?buildId=60051&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:04:43


@gnb: I already check, below, that the advertised key size is the same as the key we're actually looking for, so we won't allocate absurdly large arrays because of that.

@arunthirupathi: The store name is part of the file name.


There is no one "Chinese" – you need zh_TW for Chinese Traditional, and zh_CN for Chinese Simplified. :)


83811630_ReheatCoilSizingImprove (mbadams5) - x86_64-MacOS-10.9-clang: OK (1375 of 1375 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1230](https://teamcity.mesosphere.io/viewLog.html?buildId=60052&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:07:22


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (880 of 882 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.77%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.46%25-green.svg)


develop (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1418 of 1420 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.86%25-yellow.svg)


damn it ...


これでいいでしょう


Should be defined sooner, not sure if that is your problem persay but general practice


Closes #161 and #160


@jkbradley
Yes, but I thought you were going to send a PR to demonstrate the problem.
I appologize if you did and I didn't see it. It just didn't show up in this issue
As far as comparing implicit vs explicit zeros in sparse matrices I have added the following commit.
In the equals method I modified how we handle both explicit and implicit zeros by call withFilter on the iterator. The filter essentially avoids all explicit zeros in the sparse case.

The corresponding tests check an implicit zero matrix with an explicit zero matrix


Is this needed before?
Also kernel bits should be defined here


@txuki2005 are you really sure that these net commits are mandatory? Considering some of them are from Lollipop (even some from Kitkat) and weren't even ported over to Mako, I don't believe they are mandatory for the kernel in order to work properly. That said, they can be taken in order to be inline with Hammerhead.

Also the USB drivers are already present in the stock drivers, no need to put them here again. :p


WTF?


> Constructs an object of type T...

    new T(...)
> ...and wraps it in a std::shared_ptr...

    std::shared_ptr<T>(new T(...))
> ...using args as the parameter list for the constructor of T.

    std::shared_ptr<T>(new T(ARGS))

The difference is noted as...

> `std::make_shared<T>` typically allocates memory for the T object and for the std::shared_ptr's control block with a single memory allocation

...BUT...

> this is a non-binding requirement in the Standard

Taking a look in my MinGW64 headers, an allocator is used for `T` so the allocation is not single.

----------
At the end, `std::make_shared` serves as a shortcut to avoid redundancy (`T`) but with an additional assignment. It's not a better but a preferred way because the assignment (may) gets removed by the compiler - finally less to write.


hi infernoman,
i have some error same with they, i got this error

[2015-10-16 20:23:22.387] [DEBUG] [default] - Website Server Website started on 0.0.0.0:8080

/home/granatgas/unomp2/node_modules/dot/doT.js:54
                return ((typeof block === "string") ? block : block.toString())
                                                                    ^
TypeError: Cannot call method 'toString' of undefined
    at resolveDefs (/home/granatgas/unomp2/node_modules/dot/doT.js:54:55)
    at Object.doT.template (/home/granatgas/unomp2/node_modules/dot/doT.js:92:33)
    at /home/granatgas/unomp2/libs/website.js:137:33
    at fs.js:207:20
    at Object.oncomplete (fs.js:107:15)
[2015-10-16 20:23:57.751] [ERROR] [default] - Master Website Website process died, spawning replacement...

i have tested with 2 unomp from official and from your clone, in clone official run fine with no error, but if i run your clone have some error..
first unomp (official) run fine with nodejs v0.10.25 and v0.10.26
second unomp (infernoman) have some error with nodejs v0.10.25 and v0.10.26 "npm update" give a error. but success run npm update with nodejs v0.10.27

can you help me, im interest with your unomp added page :)


Yes, passing the ```Throwable``` as the second argument to the logging call will print out the whole stacktrace, which begins with the message.


@jeremyramin Yep, you're right, this works too.


So the previous code was printing the message twice.


It does look nice but there are 2 problems:

 - at the top of the editor window the error disappears under the edge of the "frame"
 - I still get the normal alt text hover as well if I leave the cursor over it long enough, getting two overlapping error hovers


I do not think that keySize == 0 should be valid, but I'm not 100% sure.

In the case of a non-optional String key, I assume the empty string can be used as a key, in which case it might have a length of zero? The same can be said of the value size.

I'd rather err on the side of caution.


they are there.  See line 183/184.


develop (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1418 of 1420 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.86%25-yellow.svg)


This returns a double optional ?? which breaks our tests. Let me know if you can find another way to make this more succinct but return Property? instead of Property??.


negotable on timing there.  it's in the milliseconds at best.


animal sniffer consistantly failed for me unless these were excluded.  if that isn't the case, then certainly you can adjust.  Everything else is verified just not these.  I'm running in windows if that helps.


Probably a bug introduced by earlier acceleration calculations. Will look
into it, thanks for feedback!


these, sir, are LOL


@txuki2005 Are you sure these net commits are mandatory? Some of them are from Kitkat era and weren't even backported over to Mako. Though it shouldn't cause problem if it's for the sake of being inline with Hammerhead.

Also these USB drivers aren't needed. They are already in the Lollipop Mako kernel. :p


Can probably remove the 3rd fireteam markers if we're commiting to the size man fireteams


> In the case where the field is empty, I expect that in the form (B) the email validator won't trigger an error as the email validator in itself should not make the field required

That’s correct

>  But I also expect the custom_AOL validator to be trigered, because it might have to trigger an error because the field is empty.

This is incorrect.

Each rule, itself, does not determine if the field gets validated or not, and does not determine if the rule will be executed.

Whether a field gets validated is determined in the `validatable()` method above. When this is `true`, all rules on that field will be executed. It’s all or nothing … and you just got me thinking about the  `required` rule. More on that in a sec.

> Furthermore, I believe that this drastically change a behaviour that has been there for 4 year and that many application rely on.

We considered this, but felt it better to have the correct (and less restrictive) behavior, rather than continuing to rely on buggy behavior.

> The suggested solution wouldn't work as making the field required would actually make it required, but that is not what we want. Or maybe I didn't understand the suggestion.

You’re right, the `required` rule would execute. This is an oversight on my part. I’m going to create a ticket to allow a “better” dynamic `required` rule. This is partially implemented but isn’t very useful in it’s current state.

This will allow something like:

```
magicFn(node) {
    return node.ancestor('*').val() == ‘magic’;
}
```

 - Form (C)
  - Email field with rules:
    - `required: magicFn`
    - `email`
    - `custom_AOL`

Would this give you the flexibility to validate your two conditional fields together?


+ actually there is ArrayDataRow class. Why you don't used that class?


seem to be UI.insert does not works in meteor 1.2


You don't modify mmappedData, so pass it const.


That outcome didn't cross my mind, sorry. The original is the only way I can think of that will for sure return `Property?` while staying safe.

It doesn't really make much sense for `valueForKey(_:)` to both throw and return an optional. It should really do one or the other.


Again, use const char *


Great, perfect. So in the meantime I can't test module imports _at all_.


Nothing here requires using strings. It would be better to store the data as numbers instead.


Yeah, that's better, now that it's broken again.


maybe those should be ';' instead of '&&'


Linearly scanning through a file to find a string is N time. There are much better ways of organizing the file that become possible once you stop storing numbers as strings in the file.


You may be right. The main reason that I have it both throw and return an optional is because it could fail because of an error or it could be that the value is nil. Both `valueForKey(_:)` and `setValue(_:forKey:)` throw for debugging purposes. For convenience I'd recommend using the subscript.


Unneeded variable


Just move this condition as the condition for the if statement following.


HFGFGHF


Fixes #5 , #3 and #2.


@terabyte feel free to improve the script


This is a constant and it is an unnecessary variable.


I am not sure if this test is doing the right thing. In the actual case the resetAllCaches gets called on UUID mismatch which in turn is triggered by getView(). I think this should not be called explicitly


Your manifest is broken.


lookupNumber


hey yes that the new version that includes your changes :)

thx for your efforts to make public relations :D

2015-10-16 19:18 GMT+02:00 ParzivalX <notifications@github.com>:

> Is this a new version? I'm going to go ahead and post this on the site,
> also making us a IndieDB page for public relations.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TurBoss/JauriaRTS/commit/99673a2dc1eb9ac02d736ac5dd0c03306aa0c10e#commitcomment-13822253>
> .
>


Good use of const on the pointer rather than the char. I suspect that you didn't write this line of code. Make sure you understand why this is correct. Const-correctness is very important.


Fuck


loadBasicConsumerSettings


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1231](https://teamcity.mesosphere.io/viewLog.html?buildId=60060&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:04:30


Not needed. In fact, both programs can be written without the need to allocate any memory on the heap.


Don't use c style casts. Use reinterpret_cast, const_cast, or static_cast instead.


Never true if this is compiled on a 32-bit system.


I don't recommend keeping this in here. It doesn't actually verify that the thing can parse optional descriptions. It only verifies that some error did not occurr.

The `AdminDomainTest` did not pass when I removed the description from one of the groups in the sample response. After my fix, it did pass again. I'm not sure this adds value, but it does add lines of code.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1232](https://teamcity.mesosphere.io/viewLog.html?buildId=60063&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:04:20


This line is really bad. You cast away constness and then create an alias of the pointer that is not const pointing to internal data of std::string. This is why it is important to use and understand const correctness.


I have ported u-boot-at91 to run on a custom board that has a 24 MHz crystal and only 64 MByte of RAM.  So I had to customize those items.

Honestly, 115200 is pretty standard for a serial port, so I wouldn't #ifndef/#endif CONFIG_BAUDRATE until/unless somebody asked for it.

CONFIG_BOOTDELAY does seem to be more likely to be changed, especially as folks want their boards to boot faster and faster.

--wpd

--wpd


These locks are actually probably not necessary at all, honestly, if you design your data-structures properly.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1233](https://teamcity.mesosphere.io/viewLog.html?buildId=60064&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:04:34


Casting to void* isn't necessary. If you are going to do it, use the appropriate C++ style cast.


Agree with you with the advantages of iterative software development. But it is true that with budget and time constraints a reality in today's corporate world, many managers opt for the fixed bid method because they feel that fixed bids allow them to have more control over the actual expenses. In the end, some managers are content with just having something developed rather than being concerned with the quality of the developed program.


nice work but use an IDE next time


Statistics stat;


Here you write a variable length for the value portion, but look later ...


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1234](https://teamcity.mesosphere.io/viewLog.html?buildId=60065&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:04:15


This seems to be a symptom of https://github.com/dotnet/roslyn/issues/6101. The reference is to an in-memory assembly image (loaded from resources). So it shouldn't matter that Mono doesn't have the reference in GAC.


I prefer "= ..." for default arguments. (And I have yet to change it in many other places in typeshed. But ultimately, that's what the style should be)


This assumes that you are overwriting what is always 1 10 char value ... not always true. If you wrote 3, 4 and then set 3, 14 after writing additional values, your program is going to be messed up. You could even get a crash.


You can do whatever you want locally, just don't push it.


typo


@RandomAltThingy  All the errors in any pull request will be fixed after merge. Other error is in the plan of coding. You are not needed to open pull request.


I know this is slightly more precise, but it seems excessive, compared to just saying "Tuple[int, ...]" below.


check return result?


Instead of useing ```Environment.NewLine``` we should pass lineBreak: "\r\n" to ObjectFormattingOptions constructor.


I did write this line, in fact, but this was just a case of my being more const-correct than elsewhere in the program.


@RandomAltThingy Well after I checked your repositories, this project is truly pointless. Your projects are amazing and the code is really concise. Really concise.


この記述があると、`npm install 59naga/npminit --global`時に、my-projectフォルダ内のファイルが軒並み無視されてしまう。

つまり、`package.json`が入れ子になっている場合でも適用されてしまうらしい（恐らく不具合だが）


Do you need this (and the next 12 lines), given that you inherit from IO?


This test has been refactored to avoid using real FS.


i solved my problem with some edited in website.js :)

can you add some sample in website page? like page this http://infernopool.com/acoin :)
waiting for next update


Cool. Well, in that case, you just need to not be lazy, heh.


How can I ensure that any given piece of data from the file that mmapget is reading is not simultaneously being overwritten by mmapset?


I was curious, about the reason for going away from rems or ems, and scaling type and spacing "down or up to be properly viewed and legible on mobile"

Can that be more explicitly clear; even better can it perhaps be better straightforwardly said whether or not Clef has a *vertical-rhythm strategy* associated with *baseline grids*?

Designers & developers who've built a lot of  empathy for 'em  (or identify also being one) would find that useful towards a consistent visual language in how content can be portrayed on the Web associated with white space.


Use ArrayBuilder instead.


IMHO, It would be better to have one stub for math.pyi, and, if necessary, wrap isfinite() into an if sys.version_info[0] >= 3.


I believe I removed this tests.


You may be able to construct your program so that it doesn't matter if that is happening. You can assume that aligned 64-bit writes are atomic on 64-bit chips.


dot.js is the method used for doing inline javascript on html pages, an example of a dot.js method is below. The miner stats page is for a multipool ONLY unless changed, Cloning this source will NOT work, and these methods are only here for a reference.
The problem lies inside of miner_stats.html

{{if (it.stats.pools[pool].algorithm == "sha256") { }}
{{if (it.stats.pools[pool].algorithm == "scrypt") { }}

https://github.com/Infernoman/unified-node-open-mining-portal/blob/master/website/pages/miner_stats.html

If your database is not setup to run a multipool, then the pool is going to crash. Like your experiencing. Contact sigwo or elitemobb, open an issue request on the official repo and they can help you setup a multipool.


Coz beech that's why


Missing MTR and ST references


On OS X, I just tried

```bash
[scottmg:~/work/sod/toolchains (master)]$ ./doit -a arm
need to specify architectures to build
ie -a arm sh
[scottmg:~/work/sod/toolchains (master)]$ ./doit -a 'arm sh'
need to specify architectures to build
ie -a arm sh
[scottmg:~/work/sod/toolchains (master)]$ ./doit -a 'arm x86'
need to specify architectures to build
ie -a arm sh
```

Am I doing something silly?


In order to allow mmapset to store pointers to values and directly overwrite the values in the file without needing to unmap and remap, I store all values in the files as 10 characters. Values that don't take up this much space are padded with spaces at the end. So, writing 3,4 and then later 3,14 works perfectly. But like you said in another comment, this whole thing is built on a Linear run through the file, which isn't as efficient as it could be.


I don't understand this change. In my Python 2.7, decimal() takes an optional second argument, "default". (Also below)


`Frame.sprites[!side]` works too


We should use Mono-specific conditional fact, rather than Windows specific. This is a difference between Mono C# compiler and Roslyn C# compiler. This should work fine on Linux as long as the assembly is compiled by Roslyn.


Oh, I see up on lines 159-162. You are correct. My bad.


thank you for answer, my problem solved. just change some line and erase it :)


lynda.com course was probably mac OS X mavericks or yosemite. With el capitan got message cannot precede with a period since it is used with system files. so nojekyll file has no .


also
https://trac.transmissionbt.com/changeset/14572

> https://trac.transmissionbt.com/ticket/532#comment:222
TR_CACHED_FILE_INIT in fileset_construct() has index_type and used_at positions mixed up, fixed by changing the order


and yes every commit name "VERSION{X.X.X}" will create a new stable version
others will go to test version in the spring server hosted games

jauria:stable
jauria:test


keep important function on top, unimportant down


Fix #7


if possible, avoid "or" "and" etc. in names. e.g. it could be "removeRemoteStream"


no need in separating remote stream prefixes across audio and video. e.g. just have `remoteStreamPrefixes`


OK.


error handling


Are you sure you can do that in Java?


develop (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1418 of 1420 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.86%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.37%25-green.svg)


The flow reset is not very easy to trace. We need to document this in some manner. So what I understood:
1. ConfigurationMaster on the client side sends a reset message to the ConfigurationMasterServer.
2. The ConfigurationMasterServer then sends messages to Sequencer and LogUnits to reset and also sets the LogId and upgrades the epoch.  There is a minute possibility of a race in that code. The message for reset is sent to the logunits and sequencer before the epoch is updated on the ConfigMasterServer.
3. Once the epoch is updated the clients connecting to the sequencer or logunit will get a wrong Epoch exception and will have to refetch the view. if the UUID of the new view does not match with the current view, the client will also clear all the caches.

Is it possible to make this comment clearer and put it somewhere that anybody trying to understand the code can easily get it from the comment.


I don't think this will work for an advanced build.


@lpirl @shyamg91 @klauszhang  Hi Guys can you use the following bootstrap icons glyphicon glyphicon-plus for adding and glyphicon glyphicon-minus for removing


Adapting this now, looks like it works!


Check whatsapp


Trying to figure it out


YAY! it worked


ok, ms pentru comentariu


also removing the #ID feature for ID<1milion


We usually don't say "English letter".


Use "alphabet" instead.


Perfect! forgot to mention the distant future! :+1:


Coding style! Please check `README.md` for details.


Looks like you misspelled "canola"!


Shorten your code.


Don't say "upload". It is different.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1251](https://teamcity.mesosphere.io/viewLog.html?buildId=60138&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:06:56


:heart:


Remember to add release to libclangmm as well


Because we do not need it. When we deploy project on Azure or other server, deployment program will automatically download the latest version of script according to the package.config


:cherries:? https://github.com/HealthyHoney/keyboard/commit/1ed9a8abb5143bd90692da16477effec0e2b3641


Love it!


but where shall we put our own scripts? in App/scripts? or you mean we don't need any script cus we are using API + Angular.js?


Это что-что я добавил


Is it ok? :ok_hand:


I think the correct one is:
```
[submodule "libclangmm"]
	path = libclangmm
	url = https://github.com/cppit/libclangmm.git
	branch = v0.9.3
```


In addition I think it's better to make at least one backup before and/or after import. This commit and above patch don't make any backup at all.


Was actually working on it:) See my previous post somewhere


Yeah, good idea. Think I'm going to make this a WIP pull request so we can discuss it more easily


Use `git rebase` instead.


It is not "photo". Usually, we call it "figure".


@hugovk

That's actually from http://phantomjs.org/download.html

> Binary packages for Linux are still being prepared. There are still issues to be solved until a static build is available (see issue 12948 for more details).
>
> In the mean time, it is recommended that you build the Linux version from source.

The warning about building from source taking a long time (30 minutes to a couple hours, "depending on your machine") appears after you start copy/pasting the commands :-)


Actually fixed time per move is handled separately from the time manager (in check_time() in search.cpp).

But this other scenario (small time left, big increment) is definitely a problem, and this will allow SF to step over the time limit.


Try avoid exceptions in such situations, rather here return empty string.


@lakiboy So copying the Encrypter removes the need for a test? ;)


addReading() improved in 6eb46ca11b1276774a96d79953e54deb981b46cc by:
-separating Date conversion logic to a private function
-adding an exception package with custom exceptions returning proper HTTP statuses
-adding an ExceptionHandlingController


@ruudk lol, true... I guess I need to copy a test too :) https://github.com/nelmio/NelmioSecurityBundle/blob/master/Tests/EncrypterTest.php


"1,218,889 downloads in the last month" !!

https://www.npmjs.com/package/phantomjs


Thanks for finding this broken link. A working one is at: http://www.stat.columbia.edu/~gelman/research/published/ramanujan.pdf


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1252](https://teamcity.mesosphere.io/viewLog.html?buildId=60139&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:04:14


minor ki hi daal di


Sometimes I see the download numbers on projects like this and am equally amazed :-)

"So many web developers, who knew!"


Yeah! Till the time it holds true!


This line still seems to long?


Some of the lines in the css file still seem to be to long.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1253](https://teamcity.mesosphere.io/viewLog.html?buildId=60140&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 185 Build time: 00:04:19


![But why](http://cdn.makeagif.com/media/5-19-2015/ZGns0a.gif)


Still segfaults for me on numbers

The following appears to work a little better
``` c
  if (!PN_IS_PTR(self))
    return PN_NUM(sizeof(PN));
  vPN(Object) obj = (struct PNObject *)self;
  if (!PN_TYPECHECK(PN_VTYPE(obj)))
    return PN_ZERO;
  return PN_NUM(sizeof(struct PNObject) + (((struct PNVtable *)PN_VTABLE(obj->vt))->ivlen * sizeof(PN)));
```


I can understand that ... but the code IS broken and should be fixed eventually.
Maybe ENU is is viable option - X going to right and Y to top is easy to imagine


C standard, section 7.4 paragraph 1:

>  In all cases the argument is an int, the value of which shall be representable as an **unsigned char** or shall equal the value of the macro EOF . If the argument has any other value, the behavior is **undefined**.


seems fine to me


read it carefully


改


Thank you.


How do you think about to use also a statement like "[`return ENOMEM`](http://en.cppreference.com/w/cpp/error/errno_macros "Better error code?")" there?


Yep, I'm an idiot lol, I'll fix that


yes, so actually do it for those fields


don't filter the entire array


Thanks justin


ありがとう！　以下でマージする際に楽ができました:smiley:
https://github.com/neguse11/cm3d2_plugins_okiba/commit/8a0b9cd594f804a01855df213342c5532c747022


thanks


It depends on how you define "broken". My definition "broken" = "not working as intended". So NEU might be suboptimal, but NOT broken.

At some point in time the code might be modified to use NED, but currently switching to a different coordinate convention will introduce bugs as some of calculations will certainly stay uncorrected. I'll stick to NEU at least until "Flyable" milestone is reached and get back to NED vs NEU vs ENU after that.


To be clear, it's not `cat` failing but bash in that case ;-P.


Some Gentoo profiles use spaces in CC, so you have to *always* quote it when passing to make. And not-quote when running directly ;-).


@thomasfinch Might want to point out that the pull request also changed your bundle ID. You'll probably want revert that.


is this supposed to be in this PR?


Remove markerShiftTemp


It's a bit different .. what you use in calculations is 3x3 rotation matrix (or it's half). So it may be possible to compute this matrix (9 elements) instead of qi*qi combinations (6 elements). With matrix is should be possible to use MAC instructions(row x column), possibly generating better code. Also rotation matrix is 'sound' mathematical concept and not mere optimization
```
(1.0f - 2.0f * q2q2 - 2.0f * q3q3)   2.0f * (q1q2 + -q0q3)                    2.0f * (q1q3 - -q0q2)
2.0f * (q1q2 - -q0q3)                     1.0f - 2.0f * q1q1 - 2.0f * q3q3)    2.0f * (q2q3 + -q0q1)
2.0f * (q1q3 + -q0q2)                    2.0f * (q2q3 - -q0q1)                    (1.0f - 2.0f * q1q1 - 2.0f * q2q2)
```

Some benchmark would be nice ... But that can be optimized later


Well, actually, given a second thought, it occured to me that switching to NED might be easier as I expected. Most of navigation code should be fine NEU or NED as long as X points North and Y - East. Currently all transformations between body/earth frames are handled by imuTransformVectorEarthToBody and imuTransformVectorBodyToEarth, so most issues would be like "HoTT telemetry is reporting reversed altitude!!!".

I've opened an issue #50 so I would not forget to do it.


Agreed, this is better


How do you think about to reduce source code repetition in the shown main functions?


They are individual program, and repetition is not too much for now.


ENOMEM is POSIX error code.  Is it designed to be used as exit status code?


Would it help to reuse an application template class there?


I think this is erroneous. now only when there is an error the callback is called


Well ... cross product is small when vector angle is 180deg, so the is small 'pull' ..
Dot product of vectors will be negative in that case - maybe checking dot product and accelerating convergence if negative will help (normalize cross product if dot product is negative).
But it may cause problems if noise is high/there is invalid reading


@MitchesD please merge fixes from https://github.com/TrinityCore/TrinityCore/commit/fbca2bfd6a2ea0c03f0e94d406650c19847d8e9f to https://github.com/TrinityCore/TrinityCore/commit/654332e94b0ef746309251b77f5658f5b6a03c62 rather than others or we will have problems with structure, its on list https://github.com/TrinityCore/TrinityCore/issues/15077 on top
many thanks


Merge Commits are evil


Esto es lo que tiene sentido, que muestre los cambios así, no que se me cargue el trabajo de una mañana


Ehi marco, has the time bug been solved?


Students/Others/Pop I. Andrei/Assignment 2 - Java/src/assignment2/Functions.java

I don't see this method used anywhere but in this class. Why keep it public?


Same for this one


No. At the moment the best approach seems to simply set the UCI time related parameters suggested by Joona for TCEC.


Great use of a regex!


GOod


Follo


Students/Others/Pop I. Andrei/Assignment 2 - Java/src/assignment2/Polynomial.java

Same here. Method not used anywhere but in this class. Why keep it public?


please don't merge yet; still checking dependency on use-flags.


Students/Others/Pop I. Andrei/Assignment 2 - Java/src/assignment22/MatrixOperations.java

Correct!


Badly formatted code, careful


@AleksCore
I hate the default settings and change them for myself, so I like this
IMO you can set gamemodeinfo and toggleable to true too

[Btw you can make files private with @](https://wiki.multitheftauto.com/wiki/Filepath), but then it's not shared between our servers though, so yeah renaming is probably best for now


Yes, indeed, yet you continue with the multiplication and don't exit/return the function. Are you sure you want that?


Well done! I am merging this.


Change readme about project


Ok, let it as is.


Consider Uninterruptibles from Guava


Students/30421/Papp - Szentannai G. Gergo/Assignment 2/Polynomials/src/main/Functions.java

I strongly discourage using __THIS TYPE__ of naming convention. It's quite a bit ostentatious :smile:


Shorthand writing:
`return a > b ? a : b;`


Remove this redundant code under comments


It looks good until now, of course you have quite a bit more work to do on it!
I will merge this pull request as it contains the first assignment as well so please make sure to create a new one after pushing new changes, thanks!


Some redundant functionality


Please change the var name to scriptPath/currentPath, ... to avoid confusion with getAppPath() which might be a different path.


Thanks, for the pull request, please make a modification of the var name and I will merge this :+1:


I thought that if one day, we have an option to refresh the logging activity (related to #3282 ?), and user has no more favourite points after the refresh, then the favbox will be kept shown...


Maybe we could get rid of this file completely. It's only there for OCaml 3.12, which we no longer support anyway (PRs welcome!).


Whenever you see such ifs which simply return a true or false, you can be sure that there is a shorthand way of writing it, for example, in this case, you could simply write:
`return ((rez1 > 0 && rez2 < 0) || (rez1 < 0 && rez2 > 0));`
It's not a big deal of course :smile:


Is it possible to avoid to create for each dc a Registry?


Would you like to [indicate an error situation](https://en.wikipedia.org/wiki/Exit_status "Description for the exit status") a bit more precise than by the value "`EXIT_FAILURE`"?


please sort all prefixes in alphabetic order


Because this commit was authored and not merged, you can check off in the list in https://github.com/TrinityCore/TrinityCore/issues/15077 for this line:

- [ ] 2fe35e5 Merge pull request #15695 from tkrokli/contrib_check_updates contrib/script: error text corrections in check_updates.sh


I'am not sure about scaling and direction of result ;-)

Cross product is |A|*|B|*sin(theta), |A| and |B| may be taken as 1 (it is cos(magnetic inclination) for magnetometer)
Your simulation is producing `halfe[] = [0,0,sin_approx(heading_error)/2];` (I may be wrong)

This has the problem that correction is decreasing when heading_error>90deg.
Using sin(heading_error/2)/2 with  heading_error normalized to [-180..180] will produce smaller correction (about half at small errors), but correction will be strongest at 180 deg (with discontinuity at 180 deg. But used algorithm should not cross this boundary)

Or just use [0,0,sin(heading_error/2)]. It will be close to mag mode at small angles (and error should be small) and work smoothly at larger ones. You may need to adjust gain factors a bit unless flying near equator ...


that is work of @DDuarte I am trying to pick only commits which are needed to finish re-guid proccess and some others to reduce branch diff, I don't want to touch such as old commits


The issues should be fixed of course, but from my point of view, certainly not reverted. It is very annoying on hi-res displays to have small toolbar (especially for people who are using touchscreen)


Are you sure you don't need a `while` loop here?
Also, maybe it's not such a good idea to start off from `0.0` and `1.0`. What I wrote for this method was something like this (slightly more complex but it worked great for me, as far as I remember)

```
	private double[] getLimits(Polynomial a) {
		double[] end = new double[2];
		end[0] = Math.random() * 100;
		int n = 0;
		// if the first randomly generated number gives positive result in
		// polynomial
		if (evaluate(a, end[0]) > 0) {
			end[1] = Math.random() * 100;
			while (evaluate(a, end[1]) > 0 && n < ITERATIONS) {
				if (n % 2 == 0) {
					end[1] = Math.random() * ((-000 * Math.random()) * 100);
				} else {
					end[1] = Math.random() * ((100 * Math.random()) * 100);
				}
				n++;
			}
		} else {
			end[1] = Math.random() * 100;
			while (evaluate(a, end[1]) < 0 && n < ITERATIONS) {
				if (n % 2 == 0) {
					end[1] = Math.random() * ((-100 * Math.random()) * 100);
				} else {
					end[1] = Math.random() * ((100 * Math.random()) * 100);
				}
				n++;
			}
		}
		// if the maximum number of operations were to be reached
		if (n == ITERATIONS - 1) {
			end[0] = INFINITY;
			end[1] = INFINITY;
		}
               return end;
	}
```

Where `ITERATIONS` is a constant integer with which you can play with. I set it to 9999 but it can be lower or higher of course.

It might be a heck of an overhead but it almost certainly finds decent endpoints to start the bisection method with.


Looks like this commit broke build.
Please see http://ci.cgeo.org/job/c-geo/4082/console to remedy the problem.


@donho Some new preferences ? :)


I see nothing else wrong with your bisection method. Tell me if my suggestion helped!


Squared Euclidean distance seems to be missing in your commit?
But thanks for the euclidean :-)


Yes, correct! But if you still work with an instance and not a class, does having the `static` keyword for each method still make sense?


Looking great so far! Keep up the good work


/Done


Well, I checked your branch or commit, I observed that the changes were not modified, I was not sure! I think, the resolution parameter was adopted from moodle which was recommended by Matt. Once the same low res. it will be ok!


So this was fixed for touchscreens then?

Wouldn't a "touchscreen mode" / "high-res mode" or alternatively a user definable tabbar height make more sense then?
I assume the current status is "still to small for touchscreen while already unnecessarily large for normal screens".


Thanks for fixing this. Obviously I over-engineered :-)


I assume the rest of ITC needs cloning? It is so rare to see `clone` in scala :smile:


This line is invalid


Na deze commit is het stuk van Senioren en Studenten niet meer responsive..


<img width="826" alt="multicolumn-method-list" src="https://cloud.githubusercontent.com/assets/5765308/10558554/f16b9f38-74d3-11e5-9b04-07b95252e6fc.png">


This commit renders my previous commit for disabling SeLinux due to conflicting code in /rootdir/cmdline.txt


teat


Check the coding style!


libWVStreamControlAPI_L1.so doesn't exist. The makfiles in the device tree still requiere the com.qualcomm.location apk too.


From the readability PoV, wouldn't

```js
typeof self !== "undefined" ? self : typeof global !== "undefined" ? global : this
```

be more comprehensible?


Will this use the the new `Redshift` component of target in the near future?


<img width="1080" alt="windows-dashboard" src="https://cloud.githubusercontent.com/assets/5765308/10558565/8e7ad83e-74d4-11e5-96f1-5f9fe837a1a2.png">


@glensc - because I did not know about the tags. I've changed it for the 1.10.1 release.


Isn't this the same as: if index > 64


@mcostalba: In fact, I don't think the time bug has yet been understood. Easy move has been fixed, and although that can only help make time losses less frequent it does not fix the problem, which must be somewhere else...

The only potential culprit that I can see is:
```
      int t1 = minThinkingTime + remaining<OptimumTime>(hypMyTime, hypMTG, ply, slowMover);
      int t2 = minThinkingTime + remaining<MaxTime    >(hypMyTime, hypMTG, ply, slowMover);
```
minThinkingTime is used here as an add-on, instead of a minimum. This code is anti-documenting, and dangerous, as it allows stepping over the time limit, if minThinkingTime is not sufficiently compensated by moveOverhead. And with the default values, we only have 10ms difference between the two...

Problem is that all attempts in fixing this were elo losses at short TC. The closest shot at it was:
http://tests.stockfishchess.org/tests/view/562033130ebc590be39e19f5
http://tests.stockfishchess.org/tests/view/5620d8b70ebc590be39e1a41

I have not been able to reproduce time losses on my machine, even in `1"+0.01"`. But Martin's machine must be much more noisy. For starters, he uses `Threads=N`, instead of `N-1`. We simply need to increase Move Overhead for TCEC, as Joona suggested. But I would not raise Min Thinking Time too much: this thing is dangerous, it's an anti Move Overhead!


Oh!Sorry~QQ I forget to install in master branch!Thank  you!


fix "$authorized_keys_file is null."


dobra robota, dzięki


OK, thanks. I saw your note about 800x600. I assume it will override mine on next fetch/pull, but will check on opening project, change if necessary.


Pardon my newbiness here as I'm not familiar with arm assembly and I haven't compiled this commit yet, but should reducing the payload size make it boot to emunand *even faster* now? Or is this just a refactoring?


there is no need to separate the groups, the RFC 5054 states:
```
   Because of
   the difficulty of checking for such primes in real time, clients
   SHOULD only accept group parameters that come from a trusted source,
   such as those listed in Appendix A, or parameters configured locally
   by a trusted administrator.
```

in other words, if the prime is good enough for DHE, it's good enough for SRP.


Probably a good idea.


thanks, I've made some more changes: https://github.com/metabrainz/listenbrainz-server/pull/64


I think the fallback shopId does not necessarily to have `id = 1`, we should use firstShop as the fallback id


Thanks for the pull-request, it looks really good :+1:


[`before`](https://github.com/JuanPotato/Legofy/blob/master/tests/image.png?raw=true) is deadlink


The old suite already has a separate test-case for this, It's better to not mix several test into one as this makes it much more complicated to spot the issue and to extend the tests.

Esp. here you are only testing `pkg_resources`, but `pgkutil` has to be tested, too. The old-suite already contains tests for both.


All fixed


I added an issue for this #1612


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1254](https://teamcity.mesosphere.io/viewLog.html?buildId=60142&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 186 Build time: 00:09:21


Not a fan of assert in production code. Asserts are removed if code is optimised ([source](https://docs.python.org/3.5/reference/simple_stmts.html#the-assert-statement), toward the end of the asserts section).


I usually do these. :p


DSL Regex


The emunand boot will be faster, but not that much... The patch phase is very very short, it's firmlaunch to be slow...

Btw, @173210 I'm happy to see you back working on rxTools :)


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1255](https://teamcity.mesosphere.io/viewLog.html?buildId=60143&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:06:50


I see, thanks. I think "runtime" as in the former commit was a good idea. I have built the project this way and it all compiles ok so it does not seem to be a compile time dependency. Some tests do fail for me though as in http://comments.gmane.org/gmane.comp.corba.jacorb.devel/7537 (running on a little laptop). I'll submit a pull request with the slf4j-jdk14 as "runtime" in demos and examples, see what you think of it.


Note: Merged changes from `master` because the MT3 support is wrongly merged. This is to prevent future merge conflicts.


Note: not tested yet; will test on Monday.


moving marks will require some additional work


@lucasart: OK, an increment is added after we play a move, and so we always have:
limits.time[us] >= limits.inc[us], that is time left is always bigger than an increment (at the beginning of the thinking time). Also, my calculation was like this:
(limits.time[us] - limits.inc[us]) * 3/4 + limits.inc[us],
that is I'm using 75% of (time - increment), and not 75% of time.

But, then I mathematically simplified that formula to read:
limits.time[us] *3/4 + limits.inc[us] / 4,
which is the same formula as above, only simplified.

So, sorry, but I do not see a problem with stepping over time here.

But, my real concern is where to put that formula in the code. I put it in the line 107, as Marco Costalba did in his test:
https://github.com/mcostalba/Stockfish/commit/a55e31e270c83f4840c06ca9160ef3348a3d978b
and I saw that some others added a new line 133:
https://github.com/mstembera/Stockfish/commit/99767281242030a1dbef150ddbc63bd23f8cf34f

What are your thoughts on this?

I would like to start one more sprt [-3,1] test (I see no reasons for elo gain here)
with 80% of time, that is with formula:

(limits.time[us] - limits.inc[us]) * 4/5 + limits.inc[us],
which simplified reads

limits.time[us] *4/5 + limits.inc[us] / 5.
May I get a permission from you, or should I write about this on the forum?

Thank you for resolving this,
Ivan


And I found this breaking change commit. https://github.com/kevva/decompress/commit/5970fb4c45af76839704a8d3cfc940c596524dd6

Now is the time to publish the next major version, v3.0.0.


Yes, that is what I did. In this case, it did work for prod-systems, as the manually set ``related_name`` is exactly the same as the one that Django would auto-generate, so the migration did not acually do anything, I just set the parameter explicitly for consistency. (Being eight months ago, I don't exactly recall why I did it.) But yes, this would not work in production if you actually want to *change* the related_name.

(However, as far as I know the ``related_name`` has no impact on the database layout, so this migration should be a noop in the model layer anyway.)


We're all responsible for stupid errors :P Especially when there's a ton of changes!


Wrong commit comment, this is the implementation of Formula.velocity()


@lojack5 I have already added the app buttons for the Fallout versions of xEdit but I was going to add BAIN Archive Tools.  I thought I would compare the lines for Misc Tools such as Fraps.  When doing so I noticed that there is a set of images and it's used when you backup settings.  There is the file name and a number such as [u'fraps16.png' : 1153,](https://github.com/Sharlikran/wrye-bash/blob/dev-fallout-patcher-update/Mopy/bash/__init__.py#L263)

Is that number arbitrary and I just choose one that isn't duplicated or do I have to run some script to generate that number?


Should the version in

```toml
 [dependencies.imgui-sys]
 path = "imgui-sys"
 version = "0.0.3"
```

also be increased?


Actually we'll need not one, but two rotation matrixes - for forward and for reverse rotation - as my code needs both. This means compute 15 values. These matrixes are reused a few times in the code so there might be some performance gain. Probably worth doing.


I have created a cloudflare config service that contains some basic logic.  See
https://github.com/aweingarten/cloudflare/blob/cloudflare-service-aw1/src/Config.php

Would it be ok to pass that here even though it's not immutable?


Nice.  Done


Thank you for fixing the translation. Looks better to me on El Capitan now!


I love this approach.  Thanks!


I'm eagerly waiting for this fix.


I did not modify the macro at line 79 because I find it much more readable and consistent as it is. I would rather add a rustfmt_skip in case that would be modified in the future.


Really nice feature!


You are right, I'll work on it monday


hh


Go lazy: crash it!
Time management is not easy (as Lucas said to me today), but it is also not a nuclear physics. We'll solve it.


Mitch?


Ok, pero la página de "qué es" pretede ser el modelo para el resto de documentos


Sorry, I missed this one. The dates in NEWS.md correspond to releases at GNU ELPA. All new changes should go under "Next".


Rotation matrix is orthogonal - just transpose it


..and set it defaulting to true, apparently. oh well


Cool. Thanks coverity ^^


lgtm


![GitHub Logo](/images/logo.png)
Format: ![Alt Text](http://phuketsittly.blogspot.com)


all the calls in _clientRSAGeneratorPremasterSecret are blocking, I don't see a point in making it a generator, this can be just a regular method call


same here, I see no reason to make it a generator


r-

also, making those new methods into methods of `KeyExchange` class, would make cleaner code and allow us to make this huge class of `TLSConnection` at least a little bit smaller


You are definitely right, I just merged this into master ! Sorry for the inconveniance !


I meant [MOTOR-85](https://jira.mongodb.org/browse/MOTOR-85), of course, not PYTHON-85.


Perché hai rimesso **usano** anziché **utilizzano**?
A me non dispiace usano, però mi sembra che l'orientamento sia quello di usare utilizzano.


checks should be separate from the calculations, this will make unit testing easier

also, I'd prefer the key sizes for DHE and RSA keys separate - 1024 DH is still marginally acceptable, 1024 bit RSA is unequivocally bad


Something like 5ef5ae7?


Oops, forgot that :)


Probably a good default for a general-purpose library intended to just Get Shit Done.


sudo cp `rospack find orne_setup`/config/icart-mini.param /usr/local/share/robot-params/icart-mini.param

この場合ですと/robot-paramsのディレクトリは無いと言われるので

mkdir /usr/local/shsre/robot-paramsを入れないと行けない気がします。


hmm :| are these compatile with unix locales?


Done so in c0c3803. Fun fact: This already was stored in the fields data object :D


kakav je sad ovo komet


I would prefer to [use a constant reference for such a parameter](http://stackoverflow.com/questions/2145147/why-catch-an-exception-as-reference-to-const "Why catch an exception as reference-to-const?").


Yup. We will revive this example at a later stage.


the IKE ID is probably not a good interface, once the negotiated DHE parameters become an established standard, we will have groups (which we should use) but which don't have those IDs (also, then we will be able to pick ordering of groups, and pick the one we like the most of the ones that client advertised)

it also probably should default to something like "the keysize of the server certificate"

so, defaultServerDHParamSize (in bits) would probably be more applicable


It definitely is related (see https://github.com/kubernetes/kubernetes/issues/13763 and https://github.com/kubernetes/kubernetes/pull/13879). Yes, we can probably drop https://github.com/openshift/origin/commit/fb014699b1c5cf428e6150aa1916a0728a92493f


You know that the code can still be acceded via the git history, right?


yawError should be normalized to -M_PI ... M_PI interval, caller may use 0 ... 2PI convention or something ...


AciD part:
http://paste2.org/9N6bgIHv


(normalization inside sin is applied too late)


I think if the comments were in this format you should be fine:
/**
 * @author ?
 *
 * @version 0.5
 *
 *          CHANGELOG: NONE
 *
 *          DESCRIPTION: TODO
 */

Trevor confirm?


gpu: ion: Sync with Aurora
This is a squash of these commits:

gpu: ion: Also shrink memory cached in the deferred free list
When the system is low on memory, we want to shrink any cached
system memory ion is holding.  Previously we were shrinking memory
in the page pools, but not in the deferred free list.  This patch
makes it possible to shrink both.  It also moves the shrinker
code into the heaps so they can correctly manage any caches they
might contain.

Change-Id: I177f587f999a5220eddbf7af94745aae736cac75
Signed-off-by: Rebecca Schultz Zavin <rebecca@android.com>
Git-commit: 072beca55150c0c0b652bbb24267da271e0bdf19
Git-repo: https://android.googlesource.com/kernel/common
[mitchelh@codeaurora.org: minor context fixups due to MSM changes]
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: Add buffer flag to skip page pooling on free
Currently, when we free a buffer it might actually just go back into a
heap-specific page pool rather than going back to the system. This poses
a problem because sometimes (like when we're running a shrinker in low
memory conditions) we need to force the memory associated with the
buffer to truly be relinquished to the system rather than just going
back into a page pool.

There isn't an obvious use case for this flag by Ion clients. The main
use case right now is to provide a mechanism for the deferred free code
to force stale buffers to bypass page pooling.

Change-Id: I724f89cc037083fe8576784363caa18a34e8705a
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: create separate heap and client debugfs directories
It can be slightly annoying to figure out which files under the ion
debugfs directory are heap debug files and which ones are client debug
files. Create separate subdirectories under ion to hold the different
types of debug files.

Change-Id: Ic773ab619ef94b9b4d0f3794def9d37645c7c212
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: don't use "vmalloc" for system heap readable name
The human-readable name of the system heap is currently "vmalloc", which
is misleading since we don't use vmalloc at all for that heap, we use
alloc_pages. Make the human-readable name of the heap "system".

Change-Id: Iefb92ea8adc8d76b8eccc504010aa9bc2fa5c50c
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: optimize zero'ing of pages
Instead of using __GFP_ZERO, vmap high-order pages for zero'ing all at
once (or in a few large chunks).

Test results show a ~25% speedup for allocations that are fulfilled from
lowmem, and ~100% speedup for allocations that are fulfilled from
highmem.

Change-Id: I57270361ff195780370e1c6f458985bdbb641efe
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: add page pooling to cached allocations from the system heap
Add a page pool for cached allocations from the system heap.

Change-Id: I6d7688026ff4ee65efa047a164652da1427e72c4
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: Add support for specifying heap type in the device tree
Currently, there is no way to swap out the underlying heap type for a
given heap ID without modifying msm_ion.c and recompiling the
kernel. This is inconsistent with the rest of Ion which is customized
through the device tree. This change eliminates the need to modify and
recompile the kernel for heap type changes (although the boot image
will still need to be regenerated).

Add a device tree binding to specify the heap_type for Ion heaps.

Change-Id: I0a2b48299c829a828764d74a1d8e3c8f97de706d
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: make sure all clients are exposed in debugfs
Currently, if multiple Ion clients are created with the same name, only
the first one shows up in debugfs. Rectify this by adding a
monotonically-increasing serial number to the debug names of Ion
clients.

CRs-Fixed: 566001
Change-Id: I000e45055d5029c7bccd88c36b238736929da3a5
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: remove IOMMU Heap
The IOMMU heap has been merged into the System heap since there was so
much overlap between the two. Remove the IOMMU heap. ION_IOMMU_HEAP_ID
will now alias to ION_SYSTEM_HEAP_ID.

Change-Id: I1cea1d97eba1488f8d5928e6a0f31a18b0fd92e5
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: Support probe deferal for client creation
Ion is treated like any other device in the system. Clients
may try to initialize before Ion is setup. If the Ion driver
has not yet probed, return -EPROBE_DEFER to try again later.
Since the flow is being restructured to support probe deferal,
also include some better error handling for when Ion returns
an error while probing.

Change-Id: I7ee6dde2c837fba8bba0ba4aaddee3af37b2fec1
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

gpu: ion: fix zero'ing of cached buffers in system heap
Currently, in the system heap we zero out buffers at free-time when they
came from uncached allocations. The reason for this is that uncached
allocations come from the page pools, which require this free-time
zero'ing. However, the assumption that a buffer came from the page pools
iff it was an uncached allocation is no longer valid since [0204b38
"gpu: ion: add page pooling to cached allocations from the system heap"]
introduced page pooling for cached allocations as well. This results in
us not zero'ing out cached buffers before putting them back in the page
pools, which is a security bug (we could potentially leak sensitive
information).

Fix this by zero'ing out all buffers that are going back into the page
pools (cached and uncached).

Change-Id: I5c51eca75c8cc3b3823df1494bb0eef295c77b86
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: kmalloc_heap: flush cpu caches at allocation time
There's currently a problem with the kmalloc heap where buffers
occasionally come through unzero'd when mmap'd to userspace, which is a
security hole. We actually are zero'ing the buffer but that data isn't
immediately visible to folks with other mappings to the memory (e.g. the
mapping set up for userspace by the mmap handler). Fix this by flushing
the cpu caches at alloc time.

Change-Id: I3895c6bc163e2d065b48cae66e99825c5c0a865b
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: system_heap: invalidate cache on cached pool allocations
We need to invalidate the cache when allocating pages for the cached
page pools to avoid the possibility of a stale cached value from a
different mapping being written back after we allocate our page.

Change-Id: I9b0ebfd143850cf4a4ef309a264f947a57abff77
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: use a list instead of a tree for heap debug memory map
Currently we use an rb tree to store information about the memory map
which gets passed to the heap print_debug functions. The reason for
using a tree instead of a simple list is to maintain sortedness as we
build the memory map. However, it can be necessary to store multiple
entries for the same address in the memory map since there can be
multiple clients with handles to the same buffer. This information is
interesting and useful but we currently can't store and display it since
the rb tree requires that the key used for sorting (the physical address
in this case) be unique. Fix this by replacing the rb tree with a linked
list. In order to maintain sorted output of the print_debug functions,
sort the list by physical address after fully building the list.

This also has the positive side-effect of simplifying the code and
making future print_debug methods less error-prone.

CRs-Fixed: 571918
Change-Id: I5b129fd809fb53c66042eab10d096238a34c2b20
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: fix locking issues in debug code
There are a few places in Ion where we are iterating over volatile rb
trees without proper locking. In some places the proper locking cannot
be added since it would require us to take locks in a different order
than they are taken in other places in Ion. Fix this by re-working some
of the debug code so that we can take locks in an allowed order.

One side-effect of the re-work is that the memory maps will now show
every client that has a handle to a particular region of memory, rather
than just showing the first one that we encounter. This will allow for
more accurate accounting and will give better insight as to who is
actually using the memory.

CRs-Fixed: 571918
Change-Id: Ia43e4dbc412cd480c828173f8c20b5095d87d858
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: add locking to traversal of volatile rb tree
In ion_debug_heap_show we're iterating over an rb tree (dev->clients)
that could change while we're iterating. Fix this by taking the lock
that is used to control access to this tree.

CRs-Fixed: 571918
Change-Id: I6832e1e98e2d2a69fc653451d3752d43ec3ef269
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: Add pooling of CMA allocations
CMA provides excellent memory utilization but at the cost of
being much slower than permanently reserving the memory. Most
clients of this memory end up needing to do allocations on the
fast path. These clients may be aware of allocations on the slow
path but may not be able to actually make those allocations until
the fast path. Add support for pooling CMA allocations and allowing
prefetching into the heap. This memory may be stored until either
allocated/freed or drained via a shrinker.

Change-Id: I2f15bc9c72e5f79ffa6edbeb454fd41121efd8fc
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

gpu: ion: Add ioctls for prefetching/draining pools
Multiple heaps in Ion are begining to pool large amounts of memory.
This gives a boost on average but clients may still take a hit
if the pool needs to be filled up again. Add an ioctl to give a
'hint' to add memory to the pool. Equivalently, add an ioctl to
drain some of the memory out of the pool to ennsure the memory
isn't hanging around for too long.

Change-Id: I2974322caa1520fd199d9cf2658f2fafceffb65c
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

gpu: ion: Add support for heap walking
Clients may wish to implement custom functions on a particular
heap ID. Add a generic interface to walk all the heaps available
and call a function on the particular heap ID.

Change-Id: I8b3de7a2de74cd9ea1873020ed00ee40100ce923
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

gpu: ion: Add support for getting the heap size of CMA regions
Currently, Ion heaps are able to allocate memory from appropriate
CMA regions without knowing the maximum size of the CMA region. New
Ion algorithms necessitate having the size of the heap available
for accounting. Add code to parse the devicetree to get the size of
the CMA region and associate it with the appropriate heap.

Change-Id: Ia9b560d496c76209c6116fa00f24f7b624c954f3
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

gpu: ion: Add support for specifying a default prefetch size
Some heaps now support prefetching memory before allocation occurs.
This currently requires a size to be given to prefetch a given size.
Clients may not know what size they need to prefetch for a given
heap. Since the optimal size may change with the target, add an option
into devicetree to specify what size should be prefetched by default.
Clients may specify a size of 0 to prefetch a the default size.

Change-Id: If15e4051d53fe284129c309101c41ee423f890f9
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

gpu: ion: Don't recursively take secure chunk lock
During allocation, the chunk_lock is taken to protect the chunk
list. dma_alloc_coherent may invoke the shrinker which also tries
to take the chunk_lock. This leads to a deadlock. If the mutex is
already locked in the shrinker, just return -1 as specifed by the
shrinker API to signal this condition.

Change-Id: I5525ecfcdc6deea61024f0008c62026103728571
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

ion: replace userspace handle cookies with idr
Userspace handles should not leak kernel virtual addresses to
userspace.  They have to be validated by looking them up in an
rbtree anyways, so replace them with an idr and validate them
by using idr_find to convert the id number to the struct
ion_handle pointer.

Change-Id: Iab5667ba6f3a73256fec3949b23a9a6f8e14a283
Signed-off-by: Colin Cross <ccross@android.com>
Git-commit: 1126d98d8e34d771afcc72ce5d1c37ad4d474402
Git-repo: https://android.googlesource.com/kernel/common
[mitchelh@codeaurora.org: conflicts due to msm changes]
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: don't use id 0 for handle cookie
ion userspace clients think that the cookie is a pointer, so they
use NULL to check if the handle has been initialized.  Set the first
id number to 1.

Change-Id: Ifb9af6029a8b08f57e41bc6160cc11e11001a2a9
Signed-off-by: Colin Cross <ccross@android.com>
Git-commit: 66df93b4c9e78cf433b76d7fe3da4cc7fd06c36b
Git-repo: https://android.googlesource.com/kernel/common
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: add new ion_user_handle_t type for the user-space token
Declare new ion_user_handle_t type to contain the token returned to user-space.
This allows a 2-step migration of the user-space code to a new kernel header
first, then will allow us to change the definition of the ion_user_handle_type_t
to int without breaking the API.

Change-Id: I4200b6600df8e56fe98cf1580a13a65cb25ec646
Signed-off-by: Rom Lemarchand <romlem@google.com>
(cherry picked from commit ebb8269bbb05b06ecedca3e21b3e65f23d48eadd)
Git-commit: 29f271de6ffdf6a96375cd244986617e87afc8d0
Git-repo: https://android.googlesource.com/kernel/common
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: hold reference to handle after ion_uhandle_get
commit 1262ab1846cf76f7549c66ef709120dbfbe6d49f (ion: replace
userspace handle cookies with idr) broke the locking in ion.
The ION_IOC_FREE and ION_IOC_MAP ioctls were relying on
ion_handle_validate to detect the case where a call raced
with another ION_IOC_FREE which may have freed the struct
ion_handle.

Rename ion_uhandle_get to ion_handle_get_by_id, and have it
take the client lock and return with an extra reference to
the handle.  Make each caller put its reference once it
is done with the handle.

Also modify users of ion_handle_validate to continue to hold
the client lock after calling ion_handle_validate until
they are done with the handle, and warn if ion_handle_validate
is called without the client lock held.

Change-Id: I56da5624fca3bed4ee24806b6ec39de903543341
Signed-off-by: Colin Cross <ccross@android.com>
Git-commit: 33a57aa073dac709bcdcba23bc4e2e7fcc6330f6
Git-repo: https://android.googlesource.com/kernel/common
[mitchelh@codeaurora.org: minor merge conflicts due to some missing
 casts since we haven't brought in the change that makes
 ion_user_handle_t an int.]
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: export a few handle-related APIs
There are a few APIs (ion_handle_put and ion_handle_get_by_id) that are
useful for implementing Ion extensions (e.g. custom ioctl
handlers). Remove the `static' to make these APIs available to other Ion
code.

Change-Id: Ice8767853f628d8178e96a36db3da02fa97f3235
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: msm: update custom caching ioctls for new handle format
The userspace API for Ion handles has changed slightly. Update the MSM
caching ioctls to work with the new format.

Change-Id: I6dee3190f5cad117a4d7059f1c7f0f01e05692c0
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: msm: fix bug with handle id handling
0 is not a valid handle id value. If we get a 0 we should try to do the
dma_buf import.

Change-Id: I2b9355a5ad65c91247c0369047f921cf02908b1c
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: invalidate cache after zero'ing buffers even if uncached
Currently, we don't invalidate the cache if we're working with uncached
buffers. However, the memory for those mappings might actually be stale
in the cache since someone else might have touched it. Just invalidate
the cache for everyone, cached or uncached.

Without this change, corruption was observed on the display due to stale
data in graphics buffers from Ion.

CRs-Fixed: 585524
Change-Id: I0037beaadfde983af15d8f45918f7798264dd3ca
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: system_heap: add support for 2MB allocations
Enable 2MB (order 9) allocations from the system heap. This improves the
performance of some heavyweight use cases. The benefit is especially
large for use cases where the buffer is mapped into an IOMMU since we
can leverage the 2MB IOMMU page table mappings.

Change-Id: I869733089b9ccba8090bbca80aac7b5f248b335e
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: remove unused function
Somehow, during [83c50939e88d0 gpu: ion: optimize zero'ing of pages] we
retained some cruft. Remove it.

Change-Id: I38f2ef5d6cd1baa3fe8a758a0bf8164695e2b657
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

gpu: ion: fix use-after-free in ion_heap_freelist_drain
The `buffer' variable is being used after being freed. Fix this.

Change-Id: Iea3471fa7dc7535bbf0620c1639fea2008d7cf19
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: system_heap: only use low gfp flags for order-0 pages
By trying a little harder to get high-order pages (by virtue of the
liberal gfp flags used for high-order allocations) we can actually
optimize performance since high-order pages seem to help a lot. Only use
the low-order flags as a last resort, when trying to allocate an order-0
page.

Change-Id: If8d8f4b1b4503b0c7546cf5a4bcdcaecd2bb5905
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: invalidate buffers before zero'ing
Currently, we invalidate the cache for buffers being zero'd *after* we
zero them. However, this is racey since a dirty cache line from an
earlier mapping could be written out to memory between the zero'ing and
the invalidation. Fix this by invalidating the cache *before* zero'ing
the buffer.

Before this change, I was seeing corruption with:

    $ cat <<EOF | ./memory_prof -e -i -
    simple_alloc,1,ION_SYSTEM_HEAP_ID,ION_FLAG_CACHED,0x100000,1MB
    simple_basic_sanity,1
    simple_profile,1
    simple_free,1
    EOF

After this change, no corruption.

CRs-Fixed: 585524
Change-Id: I1f2603604efc9be4ebf9112b06728e0aeca60ea0
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>

ion: Add missing unlock on error path
A mutex_unlock was missing for the alloc_lock on an error
path. Add it.

Change-Id: If88b72fbc2fd18504347b784d5daa2bc9170c55f
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

ion: retry during race with shrinking/allocating
There exists a race between shrinking/allocating

Thread 1:                           Thread:2
mutex_lock(&sheap->alloc_lock)
ion_secure_cma_add_to_pool()
mutex_lock(&sheap->chunk_lock)
chunk->cnt = 0
mutex_unlock(&sheap->chunk_lock)
                                    ion_secure_cma_shrinker
                                    mutex_lock(&sheap->chunk_lock)
                                    __ion_secure_cma_shrink_pool
                                    chunk->cnt == 0 for the
                                       just allocated chunk
                                    ion_secure_cma-free_chunk
ion_secure_cma_alloc_from_pool
no memory to allocate!

If this race happens, just retry adding memory to the pool instead
of BUGing out the system.

Change-Id: Ic95782db6d88a33f01dcc5248fc957ca0f378078
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

ion: Skip zeroing on secure buffers
Secure buffers are never passed to userspace and are controled
by the secure world so there is no real need to zero. Pass the
dma attribute to skip zeroing.

Change-Id: Iad870d0d7732d3dea09443418b9294cb9e05b5e0
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

gpu: ion: Add source of allocated page
It might be useful for higher levels in the call chain to know whether a
page came from the page pool or from the buddy allocator. If a page came
from the page pool we know that the page has been zeroed already and we
do not have to do that again.

CRs-fixed: 660049
Change-Id: I849591a56e5af8a5bc4340bff70f23e3702e62fb
Signed-off-by: Olav Haugan <ohaugan@codeaurora.org>
[nabrah@codeaurora.org: changes were manually merged from
 drivers/staging/android/ion]
Signed-off-by: Nirmal Abraham <nabrah@codeaurora.org>

gpu: ion: Optimize zeroing when allocating from system heap
Currently when allocating from system heap each page is individually
mapped and zero'ed in the page pool code. Under high memory pressure when
we allocate a lot of small pages this becomes a bottleneck. Instead,
do the zeroing in one fell swoop at the end of allocating all the pages
but only for the pages that are not already zero'ed and sync'ed (pages
coming from the page pool).

Test results
------------
Time recorded for allocating 20 x 19MB ION buffers from System heap with
forced 4K page allocations (all pages allocated was order-0) right after
boot to Android homescreen using performance kernel configuration.

Before change (non-cached allocations):
Run 1: 768ms
Run 2: 752ms
Run 3: 759ms

Before change (cached allocations):
Run 1: 726ms
Run 2: 769ms
Run 3: 645ms

After change (cached allocations):
Run 1: 262ms
Run 2: 249ms
Run 3: 310ms

After change (non-cached allocations):
Run 1: 275ms
Run 2: 234ms
Run 3: 259ms

Time recorded for allocating 20 x 19MB ION buffers from System heap (with no
forced page size) right after boot to Android homescreen using
performance kernel configuration. Run 1 is taken right after boot while
run 2 and 3 are subsequent runs without reboot between.

Before change (non-cached allocations):
Run 1: 181ms
Run 2: 1ms
Run 3: 1ms

Before change (cached allocations):
Run 1: 220ms
Run 2: 1ms
Run 3: 2ms

After change (non-cached allocations):
Run 1: 166ms
Run 2: 1ms
Run 3: 1ms

After change (cached allocations):
Run 1: 170ms
Run 2: 1ms
Run 3: 3ms

CRs-fixed: 660049
Change-Id: I8dcfdb4adb8d5f4480768f951523fa5c64db87b1
Signed-off-by: Olav Haugan <ohaugan@codeaurora.org>
[nabrah@codeaurora.org: changes manually merged from
 drivers/staging/android/ion. In ion_system_heap.c, in function
 ion_system_heap_allocate, the call to 'list_first_entry_or_null'
 is replaced with  'list_first_entry' and 'list_empty' as
 'list_first_entry_or_null is not supported in 3.4 kernel branch]
Signed-off-by: Nirmal Abraham <nabrah@codeaurora.org>

gpu: ion: Reduce allocation time from system heap
If we are under heavy memory pressure the shrinker might be running on
the system heap. This causes contention with the page pool lock when we
try to allocate from system heap. To ensure that allocations aren't
slowed down by having to wait for the page pool mutex we will just try
to get the mutex. If we are unsuccessful we just bypass the pool
altogether.

CRs-fixed: 687475
Change-Id: I3e92e3081355a8528438e41e74b716a2b49a3891
Signed-off-by: Olav Haugan <ohaugan@codeaurora.org>
[nabrah@codeaurora.org: changes were manually merged from
 drivers/staging/android/ion]
Signed-off-by: Nirmal Abraham <nabrah@codeaurora.org>

arm: Add option to skip buffer zeroing
The DMA framework currently zeros all buffers because it (righfully so)
assumes that drivers will soon need to pass the memory to a device.
Some devices/use case may not require zeroed memory and there can
be an increase in performance if we skip the zeroing. Add a DMA_ATTR
to allow skipping of DMA zeroing.

Change-Id: Ib78a19cb341c3c441f91d5b004c6375c80c10413
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

common: DMA-mapping: add DMA_ATTR_SKIP_CPU_SYNC attribute
This patch adds DMA_ATTR_SKIP_CPU_SYNC attribute to the DMA-mapping
subsystem.

By default dma_map_{single,page,sg} functions family transfer a given
buffer from CPU domain to device domain. Some advanced use cases might
require sharing a buffer between more than one device. This requires
having a mapping created separately for each device and is usually
performed by calling dma_map_{single,page,sg} function more than once
for the given buffer with device pointer to each device taking part in
the buffer sharing. The first call transfers a buffer from 'CPU' domain
to 'device' domain, what synchronizes CPU caches for the given region
(usually it means that the cache has been flushed or invalidated
depending on the dma direction). However, next calls to
dma_map_{single,page,sg}() for other devices will perform exactly the
same sychronization operation on the CPU cache. CPU cache sychronization
might be a time consuming operation, especially if the buffers are
large, so it is highly recommended to avoid it if possible.
DMA_ATTR_SKIP_CPU_SYNC allows platform code to skip synchronization of
the CPU cache for the given buffer assuming that it has been already
transferred to 'device' domain. This attribute can be also used for
dma_unmap_{single,page,sg} functions family to force buffer to stay in
device domain after releasing a mapping for it. Use this attribute with
care!

Change-Id: Idac6a165aacb0225aee6aa4c19cd6fb0df6772d5
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com>
Git-commit: bdf5e4871f1b41150236e2337837399109469e65
Git-repo: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

cma: Add API to get the start address of a CMA region
When setting CMA up at a fixed region, it is possible for the address
to be shared between multiple subsystems. If the address is placed
dynamically, there is no mechanism to be able to get the start address
of the region. Drivers may wish to do keep track of allocations relative
to the start address so add an API to get the start region of a CMA
address.

Change-Id: If0730c64496c876d3143064d767b22b984c6dc84
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>

cma: Allow option to use strict memblock_reserved memory
Despite all the performance optimizations, some clients are
still unable to use CMA because of the allocation latency.
Rather than make those clients use a separate set of APIs,
extend the CMA code to allow clients to keep the memory out of
the buddy allocator. Since the pages never actually go to the
buddy allocator, allocation and freeing is only based on the bitmap
allocator to find the appropriate region.

Change-Id: Ia31bb1212fd7b19280361128453c8d25369ce592
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>


IMO this should work ... just check that rawYawError direction is interpreted correctly ...


Remove unnecessary spaces.


Is there any reason we have two kube clients in our Options?


Sieht gut aus, ich würde denke ich das Füllwort "natürlicherweise" weglassen.

Gruß
Gardosen


そうですね、修正しておきます。


We should probably check here if the user has specified a container name? It seems strange that something like `oc logs bc/mysql -c ruby-container` works.


@EsDeKa filepath fixed in 485591340b613a71f4ab770523bbc5317f256e12


What if a title has a dash in it?


Ah, ok i think it doesn't, it would run the upstream logs


Schaut gut aus,

Hinweis den ich morgen auch in die README.MD einfüge:
Zeilen die mit {memo X} markiert sind, werden nach Information von Flash nicht mehr von IMCGames verwendet. Ähnlich dem "Depricated" Status bei der Programmierung.
Diese müssen also nicht übersetzt werden :)

ä, ö, ü oder ß können soweit ich gesehen habe verwendet werden. Aber man kann auch verschiedene Fonts in den Clienten implementieren. Somit sollte dies kein Problem darstellen.

Gruß
Gardosen


Hmm, it's strange behavior, right? We should error out.