TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2514](https://teamcity.mesosphere.io/viewLog.html?buildId=64983&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:42


The occurrence of `<input ... />` was a left-over, fixed it too via https://github.com/AdrianVasiliu/dojo/compare/a7893973a484c5e0f05df22c2dd037cdf081dd50...cb40a27ceb16c3442867e709c42e36044dc8f5e6.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22586/testReport/) for this commit**


Instead of all of these methods that repeat (or potentially, omit some) the same 6 items, but with different values, I'd rather see it as one big config multi-dimensional array, perhaps even stored in a `config/ranks.php` like:

```php
<?php

return array(
    'bad' => array(
        'css_class' => ...,
        'label' => ...,
        'start' => ...,
        'end' => ...,
    ),
    'poor' => array(
        'css_class' => ...,
        'label' => ...,
        'start' => ...,
        'end' => ...,
    ),
);

````
The methods here can then just pull out the keys needed from each entry and return that array. The class then becomes just the logic that can act on whatever logic, that is stored in the external config. Instantiate the class with something like:

 ```
$rank_config = include `config/rank.php`;
$rank = new WPSEO_Rank( $rank_config );
```

If you then need to change the config data, or add another value, it's all in one config file, and multiple methods in the class won't need changing.


I report back the _real_ length of the name, so it's up to the caller to handle it. But I suspect you're pointing towards strLcpy, aren't you?


aha, well then I think it makes sense, just remember to add `GitPython` to `requirements.txt`, I needed it to even run the help :)

```
(master) ~/repos_and_code/bcbio-nextgen (share) ~> bcbio_nextgen.py share -h
usage: bcbio_nextgen.py share [-h] clone init

positional arguments:
  clone       Publish pipeline metadata needed to re-run an analysis.
  init        Git init an existing bcbio-nextgen folder for sharing.

optional arguments:
  -h, --help  show this help message and exit
```


Yoda condition a few lines up, but not here. Inconsistent.


I read this, but below I check for path to end with at least ".mos", so we won't hit any differences in implementations.


DB有改


That's OK. We'll talk again once you're back from conference and fixup this API. It's just a placeholder.


@lla-odoo
as per the odoo doc refernce i will change .
please see https://github.com/odoo/odoo/blob/b9977ef5d30d98017b9f2d96bf151511b2eeafd2/doc/reference/guidelines.rst
![xml](https://cloud.githubusercontent.com/assets/10597339/10753333/5964bfd6-7cb6-11e5-945a-3405831a23a2.jpeg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2516](https://teamcity.mesosphere.io/viewLog.html?buildId=64985&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:38


lol


looks fine


Thanks @NeatElves
I updated the script. I will push this tonight (if @Grz3s won't do that before).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2515](https://teamcity.mesosphere.io/viewLog.html?buildId=64984&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:06:49


we can probably just delete these files.


Hi, the libgralloc needs to be adjusted to this commit of Android

https://github.com/android/platform_hardware_libhardware/commit/e69efbbabf26569ddd0ca12dda44d830a251a07f

I can't find any way,  thanks for your help


ok done


Once again, do we really need the space at this import?

<review


Very nice ,  lean


what u think about return json.loads({"code":"Success"})


on the data of post you can pass "register" only, not with $scope.


We definitely need to find a better name for that method.


just a gut reaction; can this be stuck inside B.mean() to hide MPI from user code? i guess it would require some changes since the parallel information is attached to the linsolver only.


If you do a feature freeze, changes like this do not have to stop.  You'd just put them in a different branch than the one that represents the milestone 2 release.  I would say that feature development should NOT stop - it's just best to put it in a different branch if a feature freeze is in effect.


This is something I really don't like. This would cause to rewrite every package and you need an deep understanding to write package files.
Why not introducing:
MIRRORS=""https://www.ces.clemson.edu/dealii/mirror/"
and building URLS within candi.sh?


@ajithcj : why not start sprt[0,4] tests on 7 cores? If successful, you can start pull request even if this 24 cores test does not finish in time. I'm more and more convinced that distribution of additionalDepths is more important than their maximum value.


@trajano It is actually a regexp but you are right that it is the "simplest" one. This comes from the docs here: https://www.elastic.co/guide/en/beats/packetbeat/current/_kibana_query_and_filter.html#_regexp_query Check the follow up link there for more details on the regexp query: https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-regexp-query.html Does this help?


req->rq_disk->disk_name, brq->cmd.resp[0]);


this will create a local directory email.secret and not a file, because we are mounting a non existing file to a directory inside the container and the file starts with ".". Better to use ./.email.secret


BasementDomainNumCounterBug (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1424 of 1424 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.4%25-green.svg)


Looks super! Thanks for that!


There should be a useful comment above the branch now, otherwise we may do not understand this in the future.


This commit is being reviewed as a part of review issue #7.


Where is this branch left? This is needed for fenics...


Probably better use `keys :key and :value` (to make sure the reader gets it should be symbols).
Also the `@note` below is probably redondant with that.

I think it would be more readable as a bullet-point list, like this:
```
 - If nil, will create a default XML node to use
 - If a REXML::Element, should be a <EnvironmentVariable> XML node to wrap
 - If a Hash, must contain keys :key and :value and optionally :enabled
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2518](https://teamcity.mesosphere.io/viewLog.html?buildId=64987&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:27


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2517](https://teamcity.mesosphere.io/viewLog.html?buildId=64986&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:38


Why HASH? We already have CHECKSUM as variable.


On Tue, Oct 27, 2015 at 02:08:44AM -0700, Arne Morten Kvarving wrote:
> just a gut reaction; can this be stuck inside B.mean() to hide MPI from user code? i guess it would require some changes since the parallel information is attached to the linsolver only.

Unfortunately B is from Eigen, so no hiding is possible. I guess that
is one of the downsides of mixing serveral backends.


You have introduced HASH and now you create a variable CHECKSUM (which is already there)...


Siehe https://github.com/redaxo/redaxo4/commit/65e62c495fde2238a05ea70fac40809182534f76


Yea, `upsert` is used in DB's to mean "update a matching row otherwise insert a new one". Still don't like it here though. How about `assign_variable`? Seems like just working around rubocop style though, and slightly less clear.

Its not quite `merge`, and not quite `<<`. If the key were specified as a separate param, it would fit into `[]` and `[]=` usage, but I'm not sure that makes sense in this case.

Maybe I'm just not modeling it correctly to cleanly map to any existing `Array` or `Hash` methods?


~~should exist~~ will be used / defined?


Instead of DEST, I would prefer something like FILE in the sense of a general "check_hash()" function.


~~should exist~~ will be defined?


I would move the lines 132-142 above 123 (above the echo "checking hash for ...")


For the original Lazy SMP commit, there were tests on 20 cores that were played for only 2000 games or so, together with complete tests for 3 and 7 threads. Something similar may be enough here as well.


If you change that to `"angular": "^1.2.0"`, they might accept a pr. :wink:


fixing here and in test_action


Oh, I have no idea whether `^` is working in bower. Maybe something like  `>=1.2<2.0` or `1.x` should work.


Looks like that here is something missing, or? The complete function package_verify() is now unused, or?


error: anonymous function at /home/travis/build/NixOS/nixpkgs/pkgs/applications/editors/emacs-24/macport-24.5.nix:1:1 called without required argument ‘cf-private’, at /home/travis/build/NixOS/nixpkgs/lib/customisation.nix:56:12


fix again...


@evert any chance to get this into the 2.1 series? THX


Done


Did you look at differences between the two files in the two repos?


This won't scale very well. Why don't you simply disable all the liquid effects for flats that come from PWADs?


@shihkai-tony-wei  If you want to support iOS 7 or earlier, then you should not specify `use_frameworks` in your Podfile. Basically `use_frameworks` means compile each pod as a framework. Without `use_frameworks`, the pods are compiled as static libraries. 3rd party frameworks only work on iOS8 and later, so if you want iOS7 and earlier, you need static libraries.


101163020-SetpointAirTempWorksOneWay-4627 (rglazer2) - Win64-Windows-7-VisualStudio-12: OK (1947 of 1956 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.54%25-yellow.svg)


Let's discuss on talk https://talk.openmrs.org/t/war-file-removed-from-reference-application-distribution/3442


It shoulda work now.


Why not just rely on existing DBUG_OFF ?


old_path could contain duplicates when site=None


I'd prefer to have something like #define assert_unreachable __builtin_unreachable

This could be outside the scope of the current work though


i don't find it good practice to run the entire script as root. looking at what is done here, there is few need for sudo.. you should split it up. and maybe use a Makefile so that instructions become
make update
make build
sudo make install
or something like that.

you are create folders in /home/linaro as 'root' which will eventually become a problem..


@kel-dev , I not understand what this function use for? Are this function will convert `jpg,png` to `['jpg', 'png']` ?


hmm @greut I am not sure I understand why having the `settings.js` only in Invenio and then the extra file in the overlay would not work. Can you elaborate on it? Thanks a lot!


ok.. i see that you fix the permissions here.. but still .. running everything as 'root' isn't appropriate.


I'd include system headers after at least the most basic MySQL ones. The latter do things like #define _LARGE_FILE_SUPPORT (sic?), may include the same system headers, which then would produce different declarations due to different feature macros being defined.


@IIvec I think max depth range also plays a role. There is a significant difference at 24 threads. So I have a logical reason why it would pass at 24 threads. At 7 threads I have no logical reason why this distribution is better than master(small difference in depth variation will add some elo. But may not be enough).

@ElbertoOne Original Lazy SMP commit gave more than 40 ELO on 20 cores. It would have passed SPRT[0,5] with that result within 2000 games. So it was any easy choice. I'm sure maintainers will not accept patches with just 2K games if it shows 4-6 ELO.


@philwhineray check this:

```sh
# firehol try
FireHOL: Saving active firewall to a temporary file...  OK
FireHOL: Processing file '/etc/firehol/firehol.conf'...  OK  (1037 iptables rules)

Your firewall is ready to be fast-activated...
If you don't continue, no changes will have been made to your firewall.
Activate the firewall? (just press enter to confirm or Control-C to stop) :

FireHOL: Activating ipsets... /usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
/usr/sbin/firehol: line 5409: -l: command not found
/usr/sbin/firehol: line 5412: [: -lt: unary operator expected
/usr/sbin/firehol: line 5418: [: too many arguments
ipset v6.20.1: Error in line 65537: Hash is full, cannot add more elements

FireHOL: Restoring old firewall...  OK
```


Given our supported platform set, let's make it an #error ?


bad variable name: should be "long". Can you fix please?


Если `n  < 0` - нужно вернуть 0 записей, а не отрезать коллекцию с конца


const THD * too ?

(maybe for later)


Unfortunately, the problem persists esettleg could someone help me?

Image:
[img]http://www.kephost.com/images/2015/10/27/ggggg.png[/img]


Сейчас `or` - дублирует записи. Нужно исправить


try searching

https://www.codeaurora.org/cgit/external/gigabyte/platform/hardware/qcom/display/tree/?h=LA.BF64.1.2.1.c1-03810-8x92.0


Can't you pass "this" as parent instead of null to ensure destruction?


WC_CMD is empty...


I think this belongs to #1323 not 323


حال کردی ما رو هم فالو کن سالار :+1:
به هر حال تو هم یک
4xmen
تمام عیاری دیگه


The name 'Cluster' collides with a class in the google maps api


wow. thanks a ton sir,
i did the suggested changes. but please let me know if i am missing something.

i have successfully connected with db
but still no mail delivered to mail id.
![image](https://cloud.githubusercontent.com/assets/15307997/10754237/6bcde084-7cbc-11e5-9758-2d316e9002a7.png)

am i missing something ?


Hi, if I can bring my help to make Hardware tests, I have many pc at my disposition :)
Again thank you for sharing your works.


@fabiangreffrath

I'm applying for a job, will need to change this magnificient gr|avatar ... didn't though it would leak everywhere ;-)


Плохо. Мало того что шило заменил на мыло, так еще и ошибок наделал.
Данный селектор у тебя матчит так:
```html
<form></form>
<br><br>
<form></form>
<br><br>
------ <button></button> -------
```


update


Just renumerate if it's reasonably safe


`Y|WC_CMD|@WC@|wc` is missing...


@ajithcj @IIvec I support the idea of testing this formula on 7 threads with [0,4] without waiting the test on 24 threads. 3 threads test was promising and 24 threads test may take more than a week to finish. This formula is a risk-free bet for TCEC-superfinal.


oh man, you're damaging this software with your juvenile coding skills


Why? I added some parentheses because Agda's grammar has changed. The change to Agda has been documented in Agda's CHANGELOG (but can perhaps be improved).


As we should anyway redesign the API because of the current exposure of data structure internals (#4), we
could also add a new return value to the rtrlib API.


Although nowadays it is more of an aesthetic matter we should decide between "0" or "null" for invalid pointers.


@a-detiste: this filename seems rather misleading, and it wouldn't entirely surprise me if the iortcw maintainer decided to release their own `pak5` at some point. Could you try with `sp_pak3_{es,fr}.pk3` please? Untested implementation: http://anonscm.debian.org/cgit/users/smcv/game-data-packager.git/commit/?h=rtcw-l10n


LGTM


like www.hotelissima.fr, we have 3 groups and want to display the name.
We want to display the 3 groups always in the same order. If we order only by display the 3 group are sorted in the order of the first item of the group.


@ciampix Because kicad-i18n is a git repository, you could also clean all with `git clean -fdx .`.

Also, it should be easy to make a clean command that deletes mo files.


fixed in 86e5de83c42b7adeb81505690587aa223ba13df1


nette idee mit dem nulluser, für mich liest sich's n bisschen ungewohnt und ich brauch ne weile bis ich die noop seh.
alternativ zu den nullobjekten: funktion, die nen user und 2 argumente (`attribute`, `value`) bekommt. macht nix wenn der user `nil` ist, wenn's n user gibt ruft sie `update_attribute` mit den argumenten auf.

sollte man den `nulluser` wenn nicht konsistent in der ganzen app benutzen? dann hätte ich `ensure_user` nicht nur in dieser datei.


101163020-SetpointAirTempWorksOneWay-4627 (rglazer2) - Win64-Windows-7-VisualStudio-12: OK (1947 of 1956 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.54%25-yellow.svg)


Je vous en prie :)

Le 26 octobre 2015 23:17, ggavioli <notifications@github.com> a écrit :

> C'est super bien pour windows facile à utiliser Merci encore
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ggavioli/GenevievexerciceOCR/commit/6d5566e846fb21213984112ef81b4326db2f1e86#commitcomment-13997174>
> .
>


@ticoann you have factored the pnn_regex out now into https://github.com/ticoann/WMCore/commit/9043a07fa8f57a2332c2327335a606e8647f7a80#diff-bf6f1117d1eafd52a7c14487c2b89307R15 so this will fail.


Oh, that's a pity. Now you need something more conforming?


And what about line 1141?


Yes I agree. Is better to have a unique formulation for computing feet position. I'll start working on it as soon as possible


@Optimusprimeums I removed the tags because I'm going to sneak in a couple more things


Yes, it's true.
But instead of just observing...why don't you act and change/fix/propose something.
As i said before merging..,the entire code needs a professional codder to check to see if something can be done better.
Thanks,


@Kantanart , I have the strong feeling that this is not correct.


@kosalaya dose this fix #55


@Kantanart , "Theme" is the correct spelling.


Ah everyday I learn something new! Nice git command thanks!


Sure we do!


TentacleAlbine in both tier 2 and 3? Did you mean to use TentacleGreen in one of those maybe?


@Kantanart , the preview image should show a preview of the theme, not the Propertyshelf logo. If there is no preview image available, keep the original (empty) one.


Ok I'll try. I'll also move the file to /usr/share/games with the other platform independant data & add two more symlinks (on for `es` & one for `fr`)


sur jirac, on utilise `command` : https://github.com/jirac/jirac/blob/master/core_functions.sh#L9


It is better..


Nice :)


sinon, `echo` intègre de base un `\n`


IIRC, wasn't there more than one case of this?


Yes & a shave too, I lost my job & the other saddest bit I can think of is that my Doom2 gamesave was on a losetup ext4 image on the NTFS partition of my laptop ...


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22594/testReport/) for this commit**


snprintf? (for later)


ça devrait être WAR_NEW et WAR_OLD dans le `clean`


$ ack assert_tag spec
[1]    4373 exit 1     ack assert_tag spec

No need for it...


It's starting to get strategic :D


thx >.<


What do I need to do with that?
Sorry, I am trying to learn more Android Developing. I'm quite new, I only made a few things.
Could you tell me step by step how to solve this error in libgralloc?

Thanks in advance


Warum keine Unterpfade? Gerade das ist doch wirklich praktisch sofern die Bilder von einer anderen Software verwaltet und evtl. gesynct werden... Könnte das nicht anders abgesichert werden?


Isn't the effect somewhat limited for a 20s cooldown spell? Same for CreatureStrength.


The most important comment would be the #include ordering one. Otherwise this looks good to go


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2525](https://teamcity.mesosphere.io/viewLog.html?buildId=65003&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 168 Build time: 00:04:17


yeah. since the option will be ['jpg,png,tiff'], this function will help to convert them to ['jpg','png','tiff']


Closes #396; Closes #404


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2524](https://teamcity.mesosphere.io/viewLog.html?buildId=65002&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 168 Build time: 00:04:44


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2523](https://teamcity.mesosphere.io/viewLog.html?buildId=65001&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:08:38


Especially for a lvl4 spell I guess, I would expect a stronger effect.


The second parameter is actually the [default value to be returned when the key doesn't exist](http://doc.qt.io/qt-5/qmap.html#value). The only reason I wanted to pass it explicitly is so I could be confident that if(!renderer) would be true when the key doesn't exist, it's probably actually unnecessary? Or have I misunderstood what you're saying (I am just getting to grips with Qt)?


Could you introduce a LOGGER for System.err.println and System.out.println?


I get the same errors.


Is there any advantage to calling the `expandedRowRender` function when it won't be used?


Indeed, I follow the existing convention in the function in this case (see below) but personally I would prefer an explicit NULL.


ok


@gharlan man könnte auch rex_img_file als pfade zulassen, insofern es pfade innerhalb des mediadirs sind, d.h. `realpath()` von rex_img_file ist ein Pfad unterhalb von `$REX['HTDOCS_PATH'] . $REX['MEDIA_DIR'] . '/'`


} else if (...) {
...
}
?


If a condition in an else changes, could you mark those lines and do a CTRL+SHIFT+f?

That turns

    }
    else if

into

    } else if


how does this map to "update" when we set the op in the transformer?


Красивое окошко, сделай Finder таким же


@envygeeks Doing `gem search` could work, but only in a scenario where Ruby and RubyGems are installed. In @jaybe-jekyll's case, he's just interested in making an HTTP API call and getting the data back regardless of RubyGems's existence (in this case, I think he's using Python for his bot). So perhaps the best way would be to fetch the latest from RubyGems.org's API as an alternative. Perhaps [this one](http://guides.rubygems.org/rubygems-org-api/#get---apiv1versionsgem-namelatestjson)?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2627](https://teamcity.mesosphere.io/viewLog.html?buildId=65191&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:27


It looks OK


@Arthur2e5 I really **DID** some QA checks ! And I check not only whether it can be packaged, but also whether it can run flawlessly under AOSC OS3. And the reason why I use PRs is that I am afraid I might get drunk sometimes and ....


I did that originally for that reason, but since there's literally no point in having an instance of GHULS::CLI without them, there's no point in having it in a separate method that has to get called on every run. If that makes any sense.


The method I write will use Gem Ruby API through a method like "Jekyll.latest_version" and "jekyll latest-version" or something like that


Please move this up so imports are in alpha order.


@ThomasBurleson This is causing an issue 'WARNING trying to load angular more than once.

It's because bower-angular and other repos use github for jspm angular dependicies and you changed bower-material to use the npm version of angular. Causing JSPM to ref and use angular from github and jspm.

I believe @guybedford is going to create a way to handle these issues. However, you should use `angular/bower-angular@^1.4.7`, etc.


@liushuyu The point is to stop using `abdist` in your packaging manifests. We have `$PKGDIR` that can replace `$pkgdir`. I would really appreciate it if you can change the part here.


Please move this new block of code left so it lines up with code above it.


Re


Ok, found it in the posix spec, every thing is fine.


Step 3 : Pour avoir un dev fonctionnel immediatement dans le fichier config/origami.php
Il faut remplacer la ligne
    'entity_path' => APPPATH.'third_party/origami/models/Entity',
par
    'entity_path' => APPPATH.'/models/Entity',


IAUHFULFUFHAIUAHFUIFHAFUAHFUAFAFA


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2628](https://teamcity.mesosphere.io/viewLog.html?buildId=65192&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:08:44


@Maureen-Hernandez Thanks for the contribution.


-Added black shadow text
-Fixed logo
-Added multisized lights + torches


No, this merely helps to instruct Vedeu on whether the terminal can handle more than 256 colours, but most modern terminals do, so the likelihood is that this configuration option is redundant and will be removed in the future.


This alters the behavior: c_w/c_h is the chroma size, but image_w/h was the overall image size.

I intentionally picked it this way to have the effective blur radius be the same for luma and chroma, because that way deband-range affects both luma and chroma equally. (Since the gradients are in the same actual place on the image)


Thank you! The code in that branch is Java! :dancer:


EventDateReplacementDataSetLoader : а чем предыдущий стиль был плох?


nice code!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2630](https://teamcity.mesosphere.io/viewLog.html?buildId=65195&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:15


Thanks


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2629](https://teamcity.mesosphere.io/viewLog.html?buildId=65194&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:51


:+1: Thanks!


Wie hast Du das nur gefunden :) ? Alle Achtung!


yeah, I put in a finally block.


Might be better to leave this line as-is for clarity. Sure, texture_w/h might be equal to vp_w/h at that point, but we are calculating based on the viewport size (src/dest rect).


I couldn't get this assert [self.assertIn('Welcome to Collections in Oppia!', response.body)] to pass. Any ideas as to what I am doing wrong?


Overall instead of a “texture_w/h” I would probably be more comfortable with a temporary “rectangle”, in the style of src_rect (and use that instead of src_rect in eg. the scaling calculations)


Homework is pull requests from others on your team, contribute a line of code, and get collaborative.


well, it actually changes how my terminal works.
without it the grey that I use in my app shows up as black.

but, in my bash profile, I do have this:
```bash
if [ -e /usr/share/terminfo/x/xterm-256color ]; then
  export TERM='xterm-256color'
else
  export TERM='xterm-color'
fi
```

if I remove that... (to my surprise) my ps1 still has the same colors.

The app still behaves the same though. Black backgrounds on my views without setting the color mode to this 1677...


105015426-DefVAVTUMinMax (wfbuhl) - Win64-Windows-7-VisualStudio-12: OK (1960 of 1960 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Can this be turned into an OPT_CHOICE that only accepts 16, 32, 64 and 128?


testdone


Ausschnitt oder Ausschneidung oder doch eher Ausschneidepfad? (s.a. weiter oben (9215, 9210)) Wenn Du Masken setzt, müsstest Du auch Ausschneidepfade setzen.


Shouldn't this be a 4-byte value? As per the patchlevel.h it should be, i.e. in the current form we only will include this code for Python verions lower than 0.3.0.


not showing on the actual branch for some reason


Is there a reason to use this old forked repo over the original/official [repo @ https://github.com/zserge/jsmn]?  The official repo seems to have updates that this one does not, including examples.

[repo @ https://github.com/zserge/jsmn]: https://github.com/zserge/jsmn


See:
https://github.com/popcornmix/xbmc/commit/f50ff5aeaad0e05abc58b7413ac3bd2e2806d71d
https://github.com/popcornmix/xbmc/commit/57371980bf0bc163ee01ea041416307639110f19
There's a problem with CDVDInputStreamPVRManager::CloseAndOpen which does Open an input stream more than once which breaks the scheme for initialising the filename in the constructor.


Vielleicht lieber Ausschneidepfad? Wenn Du oben Maske wählst, sollte das dann nicht die Entsprechung sein?


TEXUNIT_NNEDI3 probably better


We definitely are not uploading any credentials.  The S3 code looks for secret keys and access keys in /home/$USER/.aws/credentials.  Everyone needs to have their own, in other words.


can you revert this to original as its just indent changes but we lose whole history


similar here


Changed back to defaults for  'make html'. Still fails to build at rtfd


I did some more research and I don't think receiving a TTL=0 reply is a valid scenario. Let's leave the code as is.


Ok, cool.  Thanks for investigating!


The doco layer config image doesn't really match what I'm seeing in the "Publish" tab. I see it right at the bottom, not just below HTTP Settings.


Balls. I'll investigate. Could you temporarily change your rtfd pass and share w/ me? I'll take a look at the advanced config.


Ah, why did you make things executable? This shouldn't be required.


With that commit in async, the body will not be a table (simply because we dont declare that we send in a json).
https://github.com/clementfarabet/async/blob/master/async/http.lua#L155

Can you give me a small program to reproduce your issue?


@angavrilov thought the devel directory was a better place for it (at least, that's the impression I got). I could change this so devel/migrants-now is an alias instead, although it won't make a difference to most end users.


i have crash with gigaherz plugin with Ratchet and Clank PAL when i set the option to -1


Isn't react-native-overlay only available for iOS? Does this commit prevent modalbox from working on Android?


Oops...this closes #24


NIT: please end sentence in "."


I corrected the belongs_to options -- now the app hangs up and and I get
the following:

*SQL (0.0ms)*  DELETE FROM "favorites" WHERE "favorites"."id" = ?  [["id",
1]]

  * (2.3ms)*  *rollback transaction*

Completed 500 Internal Server Error in 46ms (ActiveRecord: 4.8ms)

SystemStackError (stack level too deep):

  app/controllers/favorites_controller.rb:24:in `destroy'

On Mon, Oct 26, 2015 at 10:11 PM, Felix Clack <notifications@github.com>
wrote:

> That error is because your policy is calling record.user where record is
> an instance of Favorite. The Favorite model doesn't have a user
> association currently, but it should.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jdsettle/bloccit/commit/a48ef4b4d2ec250407f5c4aa9fe7e05854a4106f#commitcomment-14000673>
> .
>

--
Jonathan Settle


> * **NOTE**: You need to set to `true` showsUserLocation

Might read better as

> **NOTE**: `showsUserLocation` must be set to `true` to follow a user's location.


This should be done in the ```else``` statement as well


Not likely; I've always run with 1.4.3 locally. IIRC, test images are already for 1.4.3, and 1.3.1 are simply using increased tolerances where necessary.


Before littering this tex_mul stuff throughout more of the code I would prefer making it a component of struct src_tex and having some function automatically take care of the multiplication, if possible.


Looks like `jekyll-paginate` is broken? What does `paginator` print?


@1ec5 Any good ideas for common use of `overlayBounds` and `intersectsOverlayBounds:` by peer classes `MGLCircle` and `MGLMultiPoint`? Both are subclasses of `MGLShape`, but so is `MGLPointAnnotation` per MapKit, which doesn't need these routines.


What's the major difference, other than the different position (inside pass_read_tex instead of pass_convert_yuv)?

Could you make it a commit on top of my version?


yes, setting to false handles delete case. Comments have been added to clarify.


@marcinkornek as we discussed today, let's avoid magic in default weback config - at least for now - and just modify what needed.

my proposition is to keep `webpack.config.js` as it was before but add `key` property to loaders so we can identify them easly later. I need to check, but it looks like there are no side effects of doing it.
Also one more small change is needed there - there should be `loaders` for jsx instead of `loader` so we can add react-hot later. After adding changes `/webpack.config.js` can look like this:
```js
var ExtractTextPlugin = require('extract-text-webpack-plugin');

module.exports = {
  entry: {
    main: ['./app/react/index.js']
  },
  output: {
    path: __dirname + '/app/assets/javascripts',
    filename: 'react_bundle.js'
  },
  module: {
    loaders: [
      {
        key: 'jsx',
        test: /\.jsx?$/,
        exclude: /(node_modules)/,
        loaders: ['babel-loader']
      },
      {
        key: 'scss',
        test: /\.scss$/,
        loader: ExtractTextPlugin.extract('css!sass')
      },
      {
        key: 'css',
        test: /\.css$/,
        loader: ExtractTextPlugin.extract('css!sass')
      }
    ]
  },
  resolve: {
    extensions: ['', '.js', '.jsx', '.js.jsx']
  },
  plugins: [
    new ExtractTextPlugin('../stylesheets/react_bundle.css', {
      allChunks: true
    })
  ]
};
```

We also don't need to change old dev mode. Standard reload could be done on rails level using for eg [guard-livereload](https://github.com/guard/guard-livereload)

This way all we need to do is extra configuration for hot reloading (`webpack/hot-dev.config.js`):
```js
var config = require('./dev.config');

var jsxLoader = config.module.loaders.filter(function(loader) { return loader.key == 'jsx' })[0]
jsxLoader.loaders.unshift('react-hot');

config.output.publicPath = 'http://localhost:8080/assets/'

config.entry.main.push(
  'webpack/hot/only-dev-server',
  'webpack-dev-server/client?http://localhost:8080'
)

module.exports = config;
```

`webpack/dev.config.js` and `webpack/production.config.js`  stays untouched :)


Test email reply

On Tue, Oct 27, 2015 at 1:48 PM, amadeusexmachina <notifications@github.com>
wrote:

> bruhhh...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Naftoreiclag/VS8C/commit/b6845103d6a0c4514f651144e817209c7916e7b8#commitcomment-14023357>
> .
>


Reverted the previous commit as it thrashed the entire project.


we cannot set the dynamic key 'ftm_' + tour_id into a javascript dictionary constructor.
http://stackoverflow.com/questions/19837916/javascript-creating-object-with-dynamic-keys


@MingcongBai It just stroke a merge conflict here ... And resolve this conflict first ...


this is to spoof what an update message from the user collection looks like.


yes


Pod watching is needed. We maintain pod IP <--> Namespace mapping (registry.namespaceOfPodIP) and this information is used for filtering service endpoints in case of multitenant solution.


Constness: code should always use ``const`` where appropriate (which also includes using ``const_iterator`` when your intent is not to write to iterators). That is, ``friends`` here should be a const value or even a reference, and ``iter`  a ``const_iterator``.

Variables: loop variables that only get used within the loop should be declared inside the loop or in the loop statement. In this case, ``iter`` is not needed outside the ``for`` loop, and it should be declared and defined in the loop start statement instead.

Formatting: we generally don't use extra spacing for control block statements (`keyword(statement)` instead of `keyword( statement )`), and we do use spacing around operators (`foo = bar; baz != bat` instead of `foo=bar; baz!=bat`).


Yes, it does. That's fixed in BDR/UDR 0.9.3.

The sources and RPMs are published, but I think the DEBs are still in
progress.


My kind are grateful for your support.


reproduced it, sending a fix.


Done.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2632](https://teamcity.mesosphere.io/viewLog.html?buildId=65201&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 194 Build time: 00:04:56


Ok but should this be EINVAL here? Since it's technically an invalid (out of range) value? I replaced `r` with `EINVAL` for now, if you think that's wrong I'll try to fix that.


An enhancement that deletes existing keys if `"$DEL_EXISTING" == "true"`.

_**Caution:**_ Not to be used on user ubuntu on AWS. (may be similar with other hosts)


Das finde ich nicht so schön verständlich...

Wie wär's hiermit (klingt einfacher, und das ist ein häufiger Anfängerfehler):
Maske / Ausschneidepfad und <b>Objekt(e)</b>, die ausgeschnitten/maskiert werden sollen, auswählen

Der Satz gibt auch im Englischen nur eingeschränkt Sinn, da im ersten Teil der clip fehlt... Maske anwenden auf ein Objekt, das ausgeschnitten werden soll...?
Die Meldung wird bei beiden ausgegeben: jeweils wenn man versucht, eine Maske/Clip zu setzen, obwohl nur ein Objekt ausgewählt ist.

(Die Meldung oben drüber wird, glaub ich, überhaupt nie ausgegeben.)


Ok replaced `r` with `0`. I used `LOG_WARNING` here since this one is not really fatal (there's no return here in this case.)


> @MingcongBai It just stroke a merge conflict here ... And resolve this conflict first ...

That's fine, take your time.


The `return -EINVAL` here suggests it's the right thing to do, especially if I want to change this to `return log_syntax(...)` as well.


develop (rpg777) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-83.3%25-red.svg)


Please use KFSConstants.ParameterValues.NO instead of "n".


I think ```getRemainingUses``` or something to that affect would be a clearer name for this function.


FlushStdOut (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (886 of 886 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.56%25-green.svg)


I was able to have the accumulator example build with this config.
The number of memory channels is the number of independent ports your RoCC accelerator will be using based on this commit https://github.com/ucb-bar/rocket/commit/6a165e8b90f09041e9dce30268da8b827d4fdc8c
The number of tagged transactions (Xacts)  is the number of outstanding memory transactions your RoCC accelerator will keep track of, using the tag field.

It seems you currently cannot set RoccNMemChannels to 0 even if you don't use any.

````
class WithAccumRocc extends Config(
  (pname,site,here) => pname match {
    case RoccNMemChannels => 1
    case RoccMaxTaggedMemXacts => 0
    case BuildRoCC => {
      Some((p: Parameters) =>
  Module(new AccumulatorExample()(p.alterPartial({ case CoreName => "AccumRocc" }))))
    }
  }
)
````

Also if you could submit questions like this as issues on github it would help us track them. Thanks.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2631](https://teamcity.mesosphere.io/viewLog.html?buildId=65199&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:10:57


Acho que seria bom colocar um ToList ai =).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2633](https://teamcity.mesosphere.io/viewLog.html?buildId=65202&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:53


Vielleicht auch 'ist nicht maskiert'?


It turns out the empty string was already producing `-EINVAL` because safe_atou would produce it... But I updated it to check for `r == 0` anyways as I agree that's a cleaner approach!


Thanks for considering. It's not important or critical to IRC://#jekyll. If there's free time to provide something permanent and appropriate we'll hook in! Thanks; community hug.


Can we use the public key instead?


what is the TODO here?


SOURCE_OF_FUNDS_TYPE_CODE is a property name - should be in KFSPropertyConstants, not KFSConstants.


'python -m frisk <opts>' was freaking out about not being able to import
tsne from .

Issue stopped when I changed permissions.

On Wed, Oct 28, 2015 at 11:19 AM, Kevin Murray <notifications@github.com>
wrote:

> Ah, why did you make things executable? This shouldn't be required.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Adamtaranto/frisk/commit/c80b70650ee48c443844910f92470c81d7009d7a#commitcomment-14027367>
> .
>


The comment from ciibot is either hilarous or creepy.  Maybe both :-).


Do this all the time rather than conditionally.  Err, if some 'rmtests' attribute is true in the config.


you left the ``` border-width: ``` blank
:hammer:


origin/master, for safety?


origin/ ?


We can also get rid of 'init' action/method in pkg/ovssubnet/controller/kube/bin/openshift-ovs-subnet and pkg/ovssubnet/controller/multitenant/bin/openshift-ovs-multitenant.


If we use origin/deploy*, we don't need to pull


s/location/path


you left the ``` border-width: ```blank
:hammer:


What is this key?

relative path (value) shouldn't begin with a slash.


Wait a sec @raoanjana I don't think these .idea files are supposed to be here. They are IDE specific files for your specific machine and I don't think they belong in the repo. We should probably git ignore and remove them.


hrm.  Maybe merge with a defaults array that specifies 'master' for all projects?


This should be in your css
:hammer:


Maybe there's a mode in which it just collects and prints all the gerrit URLs at the end of the script?


cool!


make "master" configurable if we're really doing that--otherwise, remove the config above


decimal and double/float is different type and btw double and Double is same just type alias in C#. same with other lowercase type


bah.  Or skip the aliases and we just detect the project based on cwd .gitreview


I'm not sure what a good name for this function is, but it probably should be local, there is probably no reason to ever call this outside of machine.


The 2nd die message also says 'League Spartan'.


switch is better here imho as type handling would grow, and for string type better uses varchar because text is blob type which separated from main table index which wasted for small string (varchar max length 65,535 shared in row size), therefore additional attribute might require like varchar size


well done


I dont kow if you added anything?


The 'all' value was changed in this test due to the way block-level elements are converted to spaces to ensure a more accurate word count.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2635](https://teamcity.mesosphere.io/viewLog.html?buildId=65204&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:31


void main()
{
    const int RAND_MAX=100;
    int i,j;
    srand((int)time(0));
    for(i=0;i<10;i++)
        {
            j=1+(int)(10.0*rand()/(RAND_MAX+1.0));
            printf("%d\n",j);
            }
}


Oh man, C++11! In the filesystem code!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2634](https://teamcity.mesosphere.io/viewLog.html?buildId=65203&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 168 Build time: 00:04:38


FlushStdOut (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1960 of 1960 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


en la linea 200 ya se validaba al mandar a publicar un hijo si estaba aprobado, indicando el allowed_states.

_publish_childs de esa manera no publicada ningun hijo si alguno no podia publicarse por no estar aprobado.


Thanks for the spot


Think this should be `provide(APP_BASE_HREF, {useValue: '/angular2/examples/router/ts/can_activate' })`


_childs_approved es innecesario


No, you didn't.


Surprised this actually worked given that you are the application.


r+


And please always use the regular commit title. Additional things can be added in the message body.


[user, repo, issue] = issueQuery...


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/5195d89c9923ed0d77690b904a6d50d507e0a162


merging MonsieurNicolas/stellar-core/partialValidator = 5195d89c into auto


MonsieurNicolas/stellar-core/partialValidator = 5195d89c merged ok, testing candidate = d424546a


me parece que eso hace que publique los hijos que estan como aprobados, nada más.


/**
 * The SaifeManager manages the SAIFE library and all the local classes needed to support a SAIFE NetworkShare,
 * including the PersistedObject and PersistentStore classes.
 * This also supports any other SAIFE library calls needed by the application.
 */


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2637](https://teamcity.mesosphere.io/viewLog.html?buildId=65206&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:02


I can't observe any merge conflicts (as in git terminology). Some verbal conflicts when merging maybe?


Mats shouldn't ever be `null`.  If this returns true, I'm pretty sure something in the application would crash (or more likely OpenCV would segfault).


LGTM


en realidad, lo que deberias implementar es que el dataset pudiera publicarse en caso que todos sus hijos tengan null en last_published_revision_id. eso podrias resolverlo sin crear un nuevo metodo con un query. Por ej. podrias buscar si existe algun hijo con las_published_revision_id != null, y en ese caso seguir adelante pero solo con la publicacion del dataset. _publish_childs no deberia llamarse en ese caso.


Maybe but that page is quite the rambling document and I am considering pointing to the API docs instead to reduce documentation duplication


What should I do instead?


<student>
<firstname> Kasia </firstname>
<lastname> Konopelska </lastname>
<email> kasiakonopelska@gmail.com </email>
<github> konop93 </github>
<group> KrDzIs2012Si </group>
</student>


Missing a return here?


done.


@aholler @dominicgs

I know this was a [WIP] commit but I'm trying to understand what's the next step here to get the new internal queues working with Injectors. Can you point me in the right direction please?

Best Regards,
Ben Gardiner


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2636](https://teamcity.mesosphere.io/viewLog.html?buildId=65205&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:22


removed


Actually no, it's just setting assigning extra stuff to the user JSON :P


BUG: `len(self.dataSpectrum.wls) > 1` should have parentheses surrounding it.  See issue #15


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2638](https://teamcity.mesosphere.io/viewLog.html?buildId=65207&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:09


Why do you not pass the flag here?


you should give the border a property of ```solid```  or ```dashed``` or any other property. It shouldn't be left blank.
:hammer:


said so.


使用方法


They were meant as shell comments.


Oops, good catch. Added


parâmetro de métodos é em camelCase =).


これこの書き方だと、パーマリンクページでのみこのメタタグが挿入される感じになると思うのですが、それでいいんでしたっけ？

[Creating a custom HTML theme | Tumblr](https://www.tumblr.com/docs/en/custom_themes#variable-transformations)
> `例:<title>{Title}{block:PostTitle} - {PostTitle}{/block:PostTitle}</title>`

↑の例で書いてあるような、↓みたいな感じのほうがblog全ページでog:title/twitter:titleが設定されていいんじゃないだろうか。

```
meta[name='twitter:title' content='{block:PostSummary}{PostSummary} - {/block:PostSummary}{Title}']
```


Ao invés do Any, pesquisa por Contains in array.


Agree


i moved the initialization to getStream.  if a stream is requested and its null, it will be created at that time.


Why do you need an Ember.Object here?


I prefer Grammar Nazi.


the attributes are observed in the template (like changing `isLoading` below), does a POJO Just Work™?


you could also use ```background-color: rgba(255, 255, 255, .65)``` to get the same effect, and leave off the opacity property


or it works as long as I mutate with `set`?


Atenció, això no arregla el problema, solament el camufla. Això farà que alguns `GameObjects` no surtin en el minimapa en cas de que l'`Start` del `EntityMarker` s'executi abans que l'`AddComponent<FOWEntity>` del `GameEntity`.

Des del meu punt de vista podem fer:

* Canviar l'ordre d'execució dels scripts de Unity
* Canviar el punt on es fa l'`AddComponent`, per exemple d'`Start` a `Awake`, però pot comprometre sèriament la performance
* Fer que `EntityMarker` també es posi dinàmicament en l'`Start`. Tot i que fàcil i segurament funcionaria, també pot comprometre la seguretat.
* Quedar i refactoritzar `EntityMarker` i `FOWEntity` perquè funcionin bé.


Either dashes or camelCase, not sure we use _ anywhere


sdssadasdsadsdda


たしかにそのほうがよさそうなので、twitter:titleとog:title両方変えておきます :ok_woman:


@senior7515: is there any chance  that port number will be between 32768 and 65535? int16 is not enough for keeping tcp port value


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2639](https://teamcity.mesosphere.io/viewLog.html?buildId=65208&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:31


Thanks Sebastian that is perfect, The once "bad"  combinations don't appear
to hang any more. Aghhhh, maybe it was my maths :( or may be not :],

On Mon, Oct 26, 2015 at 2:43 PM, carbuncle grim <mclarekin@gmail.com> wrote:

> ooops
>
> 2) These variations produce different orientations.  I could change the
> formulas so that the main axis of each mbulb is always on the *z-axis*.
> What do you think?
>
> On Mon, Oct 26, 2015 at 1:49 PM, carbuncle grim <mclarekin@gmail.com>
> wrote:
>
>> OoOps
>>
>> or is this better?
>>
>>   double th0  = 0.0;
>>   double ph0 = 0.0;
>> tho = mandelbulbMulti.betaAngleOffset;;
>> ph0  = mandelbulbMulti.betaAngleOffset;
>>
>> and later
>> ...
>> if(...)
>> th0  += asin(z.z / aux.r);
>> ph0 += atan2(z.y, z.x); etc
>>
>> On Mon, Oct 26, 2015 at 11:48 AM, carbuncle grim <mclarekin@gmail.com>
>> wrote:
>>
>>> 1) Thanks guys,
>>>
>>> I will chnage to :-
>>>
>>>   double th0 =mandelbulbMulti.betaAngleOffset;;
>>>   double ph0 = mandelbulbMulti.betaAngleOffset;
>>>
>>> and later
>>> ...
>>> if(...)
>>> th0  += asin(z.z / aux.r);
>>> ph0 += atan2(z.y, z.x); etc
>>>
>>> Eventually maybe the checkboxes should be linked so that only one
>>> checkBox can be enabled at one time  ( like in hybrid tab,     Boolean
>>> enabled OR Hybrid enabled).
>>>
>>> I am not sure of what I am doing with these mandelbulb variations, there
>>> are so many combinations with asin acos atan2 atan,, combined with the six
>>> x, y & z  combinations.  And then there are a lot  of even more more
>>> complicated mixtures.  For now,  I am happy to explore with the six in the
>>> group box .  But later I  may change it all to allow for  100s more of
>>> mandelbulbs  (or maybe not, as there is too many  things I have yet to try.)
>>>
>>>
>>> 2) These variations produce different orientations.  I could change the
>>> formulas so that the main axis of each mbulb is always on the y-axis. What
>>> do you think?
>>>
>>> 3) about the "nan" issues.
>>>
>>> some combinations create "nan" problems. I get a fractal image,but it
>>> hangs on a "nan".  Sometimes I see a "nan"  in  "distance of camera to
>>> fractal surface" in statistics, other times it is in the progress bar,
>>> "estimated to end: nan"
>>>
>>> SUMMARY it is a cool group box especially with two copies in the tab,
>>> mixing the formulas using different mbulb powers, addition constants   and
>>> main rotations
>>>
>>> cheers
>>>
>>>
>>> On Mon, Oct 26, 2015 at 8:57 AM, Sebastian Jennen <
>>> notifications@github.com> wrote:
>>>
>>>> what would be a reasonable init value?
>>>> th0 = mandelbulbMulti.betaAngleOffset;
>>>> and later
>>>> ...
>>>> if(...)
>>>> th0 += asin(z.z / aux.r)?
>>>>
>>>> —
>>>> Reply to this email directly or view it on GitHub
>>>> <https://github.com/buddhi1980/mandelbulber2/commit/94c91b25b96bb82347c7b288dad9432a12f3ca24#commitcomment-13973313>
>>>> .
>>>>
>>>
>>>
>>
>


BasementDomainNumCounterBug (mmatts) - x86_64-MacOS-10.9-clang: OK (1954 of 1954 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2640](https://teamcity.mesosphere.io/viewLog.html?buildId=65213&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:54


It works as long as you mutate with Ember.set.


we simply have to cast it to unsigned whenever we manipulate the value.
thrift only supports signed types, due to restrictions of dynamic languages

On Tue, Oct 27, 2015 at 9:01 PM, Igor Vasilcovsky <notifications@github.com>
wrote:

> @senior7515 <https://github.com/senior7515>: is there any chance that
> port number will be between 32768 and 65535? int16 is not enough for
> keeping tcp port value
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/concord/concord-go/commit/50726f7227cd25e90d45a20d587ec4acc64d6bec#commitcomment-14028052>
> .
>


good call - we are already working on it. there is a pull request coming for all languages in a couple of weeks for int32

- sent from my phone, please excuse my handwriting.

> On Oct 27, 2015, at 9:01 PM, Igor Vasilcovsky <notifications@github.com> wrote:
>
> @senior7515: is there any chance that port number will be between 32768 and 65535? int16 is not enough for keeping tcp port value
>
> —
> Reply to this email directly or view it on GitHub.
>


I swear there used to be `this.currentModel` maybe it went away or isn't public


Oops, thanks!


yeah, but it's a good practice to return something, as people often get trolled by doing an async thing inside a promise callback and not returning it, also makes it nicer for people chaining. Not a big deal here though


Should you maybe instead use .equalsIgnoreCase for us with shift-trigger happiness?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2642](https://teamcity.mesosphere.io/viewLog.html?buildId=65215&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:04:57


Such incredibly necessary rewrite.


Or maybe instead make everything lowercase by default.


Nm, I thought issueQuery was an object that issues queries on the first read


It looks cleaner this way :crying_cat_face:


`local p`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2644](https://teamcity.mesosphere.io/viewLog.html?buildId=65217&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:15


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2643](https://teamcity.mesosphere.io/viewLog.html?buildId=65216&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:30


And I was too quick in judgement. This change does help TeamViewer icon not to disappear completely.
But making it skipping absolutely transparent images (i.e. sum==0) doesn't help Psi either. Gotta search for some better way to solve it.


missing `|| die`


I've changed the format used for QPainter rendering to one that is more optimal according to the documentation.


Commented code doesn't really help us, might as well just delete this test. It'll show up as a lack of code coverage and will keep our sources clean.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2646](https://teamcity.mesosphere.io/viewLog.html?buildId=65219&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:57


I don't understand what this is for... keepdir below already creates this afais


Good idea - I was having this problem too.


I gitignored everything! Sorry!


данные о контактах нужно научиться извлекать из таблицы, из ее ячеек. решение не верное


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2641](https://teamcity.mesosphere.io/viewLog.html?buildId=65214&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:10:01


101163020-SetpointAirTempWorksOneWay-4627 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1425 of 1425 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.4%25-green.svg)


I've finally gotten to a test on this. The test set up is a netcdf file (WaveWatch3, 'ww3_20151023_12.nc'), and I see the entries in the GetRecords response:

```
                <gmd:CI_OnlineResource>
                  <gmd:linkage>
                    <gmd:URL>http://localhost:8080/geoserver/ows?service=CSW&version=2.0.2&request=DirectDownload&resourceId=it.geosolutions:sig_wav_ht&file=74ad90d36ec4ace5e7202ea6bea80fc176bedaf0-ww3_20151023_12.nc&BOUNDINGBOX=-0.2000000033946138,-78.2,359.8000061069102,78.2&TIME=2015-10-23T12:00:00.000Z/2015-10-30T12:00:00.000Z</gmd:URL>
                  </gmd:linkage>
                </gmd:CI_OnlineResource>
                <gmd:CI_OnlineResource>
                  <gmd:linkage>
                    <gmd:URL>http://localhost:8080/geoserver/ows?service=CSW&version=2.0.2&request=DirectDownload&resourceId=it.geosolutions:sig_wav_ht</gmd:URL>
                  </gmd:linkage>
                </gmd:CI_OnlineResource>
```

The second URL (which just resourceId based) works OK. I get back the expected file (wrapped in a zip file), and after extraction it diffs as identical.

However the first one (with the file bit and the time / bbox) doesn't produce the file - it throws a SE:

```
$ curl "http://localhost:8080/geoserver/ows?service=CSW&version=2.0.2&request=DirectDownload&resourceId=it.geosolutions:sig_wav_ht&file=74ad90d36ec4ace5e7202ea6bea80fc176bedaf0-ww3_20151023_12.nc"
<ows:ExceptionReport xmlns:xs="http://www.w3.org/2001/XMLSchema" xmlns:ows="http://www.opengis.net/ows" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="1.0.0" xsi:schemaLocation="http://www.opengis.net/ows http://localhost:8080/geoserver/schemas/ows/1.0.0/owsExceptionReport.xsd">
  <ows:Exception exceptionCode="NoApplicableCode">
    <ows:ExceptionText>Unable to get any data for resourceId=it.geosolutions:sig_wav_ht and file=74ad90d36ec4ace5e7202ea6bea80fc176bedaf0-ww3_20151023_12.nc</ows:ExceptionText>
  </ows:Exception>
</ows:ExceptionReport>
```

I tried to debug it a bit, and it got down into the GeoTools CoverageSlicesCatalog code, where there is a `it = features.feature()` call (https://github.com/geotools/geotools/blob/master/modules/plugin/coverage-multidim/coverage-api/src/main/java/org/geotools/coverage/io/catalog/CoverageSlicesCatalog.java#L406) that is returning an empty iterator (i.e. no features match the query, so the SimpleFeatureCollection in L397 doesn't have any features). I don't understand why the location filter is causing no matches yet though.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2645](https://teamcity.mesosphere.io/viewLog.html?buildId=65218&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:05:54


But the user won't add .htm to the url they will just go to localhost:8080/openmrs, so this still won't be necessary and sprint won't catch it


@bigs: go compiler doesn't allow cast i16 to uint16. We will wait for updated thrift file where port's type is int32.


Echonest-idea joutui hylkyyn koska se oli ihan susi systeemi eikä sieltä saanutkaan suoraan verrattua kahta artistia vaan siinä olis pitän kikkailla genrejen kanssa blaablaa... Artistien samankaltaisuus on nyt määritelty algoritmilla joka pisteyttää artisteja verraten alkuperäisen artistin kanssa yhteisten related-artistien määrään. olipa vaikeeta selittää.


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/87800855


Thanks for your intput. I wanted to save the work I did yesterday. Will continue work on this later tonight


@lewang just double-checking. We don't need this for anything, do we?


Steve,
I am currently lost.  Here is the article I referred to in order to create the relationship between sports and children: http://www.jeffthomas.xyz/many_to_many-relationships-in-rails/.

I thought this was pretty much the same thing I had done with families and parents and children.  Right now I do not know how to access all of the children for a given sport or access all of the sports for a given child.  I spent a lot of time on the rails console and go no where.


EMILY KRAFT!!!


not finished.


How to transform to vector? I'm noob 😁


@arunoda Since we are using ecmascript package, I think we can use for-of as it uses babel and we [support](https://github.com/meteor/meteor/tree/devel/packages/ecmascript#syntax) it.

So, it will be

```js
const elements = document.querySelectorAll('[dochead="1"]');
for (let element of elements) {
  element.parentNode.removeChild(element);
}
```


Melhor agrupar por funcionário, uma vez que pode existir funcionários com o mesmo nome.
`group funcionario by funcionario.TurnoTrabalho into`


Alright


Excellent !


101163020-SetpointAirTempWorksOneWay-4627 (rglazer2) - x86_64-MacOS-10.9-clang: OK (1955 of 1955 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The class AsyncTask implements 4 methods:

1. onPreExecute(), invoked on the UI thread before the task is executed. This step is normally used to setup the task, for instance by showing a progress bar in the user interface.

2. doInBackground(Params...), invoked on the background thread immediately after onPreExecute() finishes executing. This step is used to perform background computation that can take a long time. This is the main method for implementation of the second thread - in this case counting from 5 to 0 when "COUNTDOWN" button is pressed.

3. invoked on the UI thread after a call to publishProgress(Progress...). This method is used to display any form of progress in the user interface while the background computation is still executing. For instance, it can be used to animate a progress bar or show logs in a text field. Will not be used in this example.

4. onPostExecute(Result), invoked on the UI thread after the background computation finishes. The result of the background computation is passed to this step as a parameter.

For this example the class and methods take no parameters.

-The main thread is implemented when "COLOR" button is pressed. Every time it's clicked, the backgrounf color of the Layout changes randomly.

-The second thread (background thread) is implemented when "COUNTDOWN" button is pressed via  doInBackground(Void ... x) method. It uses for loop to decrement from 5 to 1.  Thread.sleep(1000) method is used to pause the thread for 1000 milliseconds on each loop iteration, thus working as a timer.
lable.setText(seconds + "") method actually outputs the seconds countdown, but UI methods can't be used directly with doInBackground(Void ... x), therefore it's nested into  runOnUiThread(new Runnable() method.

runOnUiThread(new Runnable() {//OnProgressUpdate - can substitute runOnUiThread - check
@Override
public void run()
      {
            lable.setText(seconds + "");
      }
 });

Below is the output:

![capture](https://cloud.githubusercontent.com/assets/14827946/10777343/dd17eb70-7cd7-11e5-8e77-bb80e078194d.JPG)

![1capture](https://cloud.githubusercontent.com/assets/14827946/10777347/e0ada234-7cd7-11e5-91d9-f450507d0c93.JPG)


to differentiate between rules that should never be broken and those that can be broken if you know what you're doing. 「決して破ってはいけないルールと、あなたがあなた自身がやっていることを理解している時には破ってもいいものとを区別するために」ぐらいの意味かな。


+//        for (int i=0; i<20*60*60; i++) {
+//            System.out.print('.');
+//            try {
+//                Thread.currentThread().sleep(1000);
+//            } catch (InterruptedException e) {
+//                break;
+//            }
+//        }


たぶん「スパゲッティコードみたいになっちゃうよ」的な意味で使ってると思う。調べても出てこなかったし、この人特有の表現じゃないかな。


What should I use instead?


@paweltin  Thank you for this.   What do you think about something more like this?  I think it might be a little bit more flexible.    If you think it makes sense it would help a lot if you could test it for me.   Please let me know.  thanks!

Starting from line 48 (removing the `--ssl-protocol` default), ending at line 65...
```
var args = [];

if (paths.engine === 'slimerjs') {
  args = ['--engine=slimerjs'];
}

if (paths.casperFlags) {
  if (/--engine=/.test(paths.casperFlags.toString())) {
    args = paths.casperFlags;
  } else {
    args.concat(paths.casperFlags)
  }
}

var casperArgs = tests.concat(args);
```


1) [ ] Foo
2) [ ] Bar


@sasairc

![ba2e4dde](https://cloud.githubusercontent.com/assets/4990822/10777447/f17769a6-7d5e-11e5-8bb3-f0f48ee5c27f.jpg)


I prefer the previous wording, I'm not sure it's a useful or accurate thing to say what "most developers will want to" do.


Hmm, so this case is that there are no active MDSes but cluster_unavailable thinks they'll be active soon? Figuring out how that happens requires a bit of jumping around. Perhaps we should change the cluster_unavailable interface to a three-case system: unavailable until intervention, unavailable but recovering, and available? And then build our choice tree here based on those values explicitly.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2647](https://teamcity.mesosphere.io/viewLog.html?buildId=65220&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:04


what are you setting here? also, the y co-ordinate needs a value. You don't want this to be zero.


つらい


OK、参考にする


The config interface should not have a getSecret(). The get() should check the helper and if not null, return the secret. But if null, return the non-secret value.  The decision on whether something is secret or not is determined by the config owner, not the code using the config.


remove the getSecret method and then it's safe to merge.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2648](https://teamcity.mesosphere.io/viewLog.html?buildId=65221&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:19


I did consider that.  However, omitting GHC makes the MAlonzo backend non-functional, and doesn’t prevent the user from trying and failing to use it.  I decided it’s better to provide a complete, working system, and give the user the choice to install a partially-broken but lighter version.


FlushStdOut (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1424 of 1424 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.4%25-green.svg)


develop (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1424 of 1424 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


o


oo


For this commit, you can probably update the commit message to just be glibc, since we removed eglibc from ct-ng.


test


Okay, so I'm getting even more confused as time passes.  This is the *only* place that `mutex_` is used.  I can't figure out what `mutex_` is protecting.  Is it preventing recursive calls to `coro_()`?  If so, then I think you get a deadlock.  I'm sure you're locking for a reason, I just can't figure out what it is...


Issue still persists again for some reason.


You can remove this check all together. HA won't load this module without it. Now it will throw an error while still working because HA will install it.


es cierto y ahora q lo dices, usando una lista al realizar varias acciones un mismo personaje lo tendria agregado varias veces incrementando inecesariamente el tamaño de la lista


Can this be called `update_db` or something? It has the same name as the manage.py command, which does a different set of things.

(This also isn't a fab command, just a helper function, and it's only called in one place; was that intentional?)


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1424 of 1424 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I was looking for code that either interpreted the new types, or one that converted the new types to the older mysql type system, which should eventually be used to build the native values from the string row values. For java, I do the former: https://github.com/youtube/vitess/blob/proto/java/client/src/main/java/com/youtube/vitess/client/cursor/Row.java#L154.
For go, I do the latter: https://github.com/youtube/vitess/blob/proto/go/mysql/proto/proto3.go#L69.


101162510-SubsurfaceOutwardAngleWarning-5016 (rglazer2) - x86_64-MacOS-10.9-clang: OK (1896 of 1906 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.48%25-yellow.svg)


FlushStdOut (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1960 of 1960 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@loooongcat , why do you filter it by **is_bound field**? Model ProductCategory only has a field **is_enabled**


Also changes to shader itself. And I'm afraid it gonna cost a huge effect to rebase them on top of your implementations now. All code is actually rewritten, except the mentioned function.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


You should clear all debug **prints** before commiting.


post[2] is prob the id number. After I finish with mongo-fying the database, it will prob change to post['postID'] since mongo uses dictionaries

They use the id number to keep track of which comments are for which post

Some of my code is already in PostsM.py or CommentsM.py if you want to see the dictionaries


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2649](https://teamcity.mesosphere.io/viewLog.html?buildId=65226&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:07:11


Neither font is used.


We do not need this file in repo. Remove it


TypeError: $table.tBodies is undefined
$tbody = $($table.tBodies[0]),

grid.subgrid.js (line 138, col 37)


I see, although it's not so obvious with a glance


After the merge, please, check the project status with **git status**. Do not commit garbage files. This file is a garbage!


Actually I left this missing line after some reverts on this PR. The only thing what really make any sense to solve that problem on this commit is on bin/setup file.


We should change it to the domain you have and port should be default 80


We should change this.


cc @jasnell


Argh, this one @jasnell


develop (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1424 of 1424 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


given a table of sports => Sport(id: 1, name: "swimming", cost: 10_000; id:2, name: "basketball", cost: 20_000)
given a table of children => Child(id:1, name: "Bruce"; id:2, name: "Emma")
now I have to create a ChildrenSport table => ChildrenSport.create(child_id: 1, sport_id: 1)
again ChildrenSport.create(child_id: 1, sport_id: 2) and once again ChildrenSport.create(child_id: 2, sport_id: 1)


101162510-SubsurfaceOutwardAngleWarning-5016 (rglazer2) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1902 of 1912 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.48%25-yellow.svg)


So you insist !
You man found the root with your foot ,
You man , Human , showed me the direction .
Right ?
So when i've found the solution , i've just followed your direction .
Right ?
But i don't blame you to be a good friend !
eh eh
Blessings ,
Ezee


será que funciona se passar um `new Cargo..` no parâmetro?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.715](http://teamcity.monogame.net/viewLog.html?buildId=10917&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Pode levar a logica de Calcular Idade para um método.


Added code to the motionHandler.
Added code to the turnOffNoDelay and turnOffDelay


so how would I see all the children signed up for swimming?  This should be Bruce and Emma.
so how would I see all sports Bruce is signed up for?  This would be swimming and basketball


Can the patch_number be const here?


In PHP there's basically no such thing as native types:

```
php > $x = "1.2";
php > $y = $x + 5;
php > echo "$y\n";
6.2
```

So there's no point in converting numbers. The only thing left is dates, but using a class for DateTime is not really standard in PHP. Often you just parse the format you're given into a UNIX time and go from there.


add check ETag and If-Modified-Since, if matched then return 304


Yep. Ich hab das für die AI schon gemacht. Da gibt es ein Direction enum mit (SE, SW, W, E,...) Die GetNeightbour2 hat auch eine sehr seltsame Reihenfolge. Die springt an einem Punkt... Solche Enums sollten generell verwendet werden. Am besten die Boost scoped enums. Da es aber so extrem viel Code betrifft, habe ich das erst mal nicht gemacht.


I think tables are supported by our variant of Markdown.


Will fix.


Yes.


avoid global variables


Won’t change this. Tests cover it well and it’s easy to read.


where is variable declaration? avoid global variables


Then I need to duplicate the line below as well.


這一步寫得很好！


If you use my exact sources, that shouldn't cause any issue because the kernel path is hardcoded.. :p


too many absolute! do proper research on it's use


Sure, I can change that.


can we keep variable names camel case please. There is an eslintrc file https://github.com/adazzle/react-data-grid/blob/master/.eslintrc that contains our lint settings. Currently we just use that in atom and is not part of the build process. I will change that soon though so that the build will fail if there are any lint errors


I haven't looked at this yet but read that there are [some issues with 1.0.1](https://github.com/francocatena/meteor-compass/issues/10#issuecomment-148034367). Knowing that [Compass <2 will never be fully compatible with LibSass](https://github.com/sass/libsass/issues/82#issuecomment-99278106) what is the aim here?

On a side note, it appears that a few people do not fully understand that meteor-compass is limited and more like bower-compass than then full library. I think this should be emphasised somewhere.


Checkmarx scan results 28 Oct 2015 11:53 UTC +02:00

High
Medium
Low
Info

New
23
11
23
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

408c3d00afe56f8930e108bec67c899587152061	@amitchen22


Do you mean the whole branch include suhorng's work or just these two commit about parser?


If you use  Symfony\Component\Translation\Translator::getCatalogue() you also need to require symfony >= 2.6 in composer.json because the function does not exist prior to these versions

see the related commit : https://github.com/symfony/translation/commit/440aff1e701250e7ae6395b8692692645f555a42


Checkmarx scan results 28 Oct 2015 11:55 UTC +02:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
23
11
23
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

8673844b465d226ec0ae208082f01972c5da4c4c	@amitchen22

c0f734e5765f4e252497e9635fbba0456c1b7913	@amitchen22

31d3691052f15e95da7759c59069edbc825d5293	@amitchen22


> 1. Drop the symbolic constants and instead add/remove the NSAlternateKeyMask from self.commitButton.keyEquivalentModifierMask.

I tried that first, was not working. I had problem removing `NSAlternateKeyMask`. I can give it another try.

> 2.

Sure.


@kichalla We need to remove the reliance on this API.


Yes.


@PeterDaveHello, thanks!


OK.


Actually the issue appears to be:

```json
{
  "angular": "npm:angular@^1.4.7",
  "angular-animate": "npm:angular@^1.4.7",
  "angular-aria": "npm:angular@^1.4.7"
}
```

which should be:

```json
{
  "angular": "npm:angular@^1.4.7",
  "angular-animate": "npm:angular-animate@^1.4.7",
  "angular-aria": "npm:angular-aria@^1.4.7"
}
```


confirmed. glew is axed in goom, but libprojectM links GLEW so no way around it there.


very minor suggestion, but also could do: if command in ('quit', 'exit'):


cafbd861df14ef0af5b816f42805b79643ed535e should fix the problem


Simple tables yes, but can you have vertical cells in markdown? About CSS, I am open to move it somewhere else... any suggestions. I usually "hack" stuff together in web pages -- not clue what is best practice.


There is problem with this commit. Very high values are reported. If statement should be: ```if d < 0```


I guess it's neater to not specify the `case_sensitive` option when it's case sensitive. Sorry it's a bit confusing.


TDD 的一個重要原則，一次只新增一個失敗的測試案例。（代表這一次所預計要完成需求的 scenario）

TDD的過程中，在正常情況下，測試總管最多只會存在一個失敗的測試案例。而且這個失敗的測試案例，一定就是剛剛加入的 scenario。也就是代表著目前 production code 要加進去支援的新功能。

只要測試總管存在一個以上失敗的測試案例，就代表異常，代表被相互影響到。


The `[self.parameters addObject:arg]`?

I thought it was an oversight that `arg` gets added to `parameters` when `arg` is `--amend`.

The `parameters` array is supposed to hold the file names and have a 1:1 with the `--status` argument, right?


Fixed all errors on latest commit. @doyonghoon


do we need to set this in  hosts.template ?


Well, it's an opt (and STL containers return a const ref as well). For impl reasons we can't return a const ref to a zerobuf obj... From a user POV it does not change anything.


Dear pierredup
You removed all code from file Util/SecureRandom.php and left only one function
public function nextBytes($nbBytes)
    {
        return random_bytes($nbBytes);
    }

But this function random_bytes works only on PHP 7.
Look at http://php.net/manual/ru/function.random-bytes.php

I'm using PHP 5.4.39 and my project was down with error after composer update

 Fatal error: Call to undefined function Symfony\Component\Security\Core\Util\random_bytes() in /site1/vendor/symfony/security-core/Util/SecureRandom.php on line 31

I'm using version 2.8.* of symfony/security-core


It's not a panel. It is just a store of tabs. `contains` is [semantic enough] (https://developer.mozilla.org/en/docs/Web/API/Node/contains).


we should use docker on lvm by default, and set at false only if we don't use it


This is getDynamicPtr, I changed the function name back to what it is in master. A dynamic by definition is a pointer, so no need to repeat the Ptr in the function name.


Why is this?


How does this actually differ from the pass_tex parameters?


Checkmarx scan results 28 Oct 2015 12:05 UTC +02:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
23
11
23
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

2cf14527522a4f76002bddc86fe5133a8c6df958	@amitchen22

4f9c474b26f872a1b46820c6c9daec8bbecedbce	@amitchen22


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.717](http://teamcity.monogame.net/viewLog.html?buildId=10935&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Signing the url requires a private key, for which simple oauth credentials are not enough. However, there actually is a private key involved when running on Google Compute Engine VMs or when pointing the GOOGLE_APPLICATION_CREDENTIALS to a json file containing a service account key.

Unfortunately, I haven't found a way using the Go libraries to extract the private key when using a service account. I know the key is somewhere inside the "TokenSource" object, but it is wrapped in a layer for private struct types. Not sure why they did not provide an easy way of getting the private key. In the Java library this is as simple as calling ```GoogleCredential.getServiceAccountPrivateKey```.


fionagruell Abgabe 28.10.2015


@xiexingguo note that
<pre>
Xie Xingguo &ltxie.xingguo@zte.com.cn> <xie.xiexingguo@zte.com.cn>
</pre>
is necessary because of the typo in the Signed-off-by in 90f1d25cd8b09454e19d9587e734a68e6ae19e4f


Checkmarx scan results 28 Oct 2015 12:07 UTC +02:00

High
Medium
Low
Info

New
0
0
0
0

Recurrent
23
11
23
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

41032b39802e86ae32b64af866e630eaf4940700	@amitchen22

d0ea32ab118052dc6749fd086b704d9a2fd1d9aa	@amitchen22

c00a7d980406dc7bae2e975c072011b86a3c6c03	@amitchen22


Following the simple schema, and continuing in a simple theme, I think this could be something like

```ruby
mixed_case = 'Mixed Case'
Items.create value: mixed_case
expect(Item.new value: mixed_case).not_to be_valid
expect(Item.new value: mixed_case.downcase).not_to be_valid
```

and of course similarly for the subsequent context


I wouldn't have expected any changes to `Gemfile.lock` if this was a simple re-ordering in the `Gemfile`. I think it would be better to avoid this upgrade to `pry` or at least do it in a separate commit.


`['!fixed']`


The IP for wdsl can be changed incode by calling serviceLocator.


what to write


TODO: replace with `yum install python-tables` (assumign the version is recent enough)


I'm not familiar how's Eclipse's `GC` work, but it might be worth moving it inside `stickToEOL` branch.


Might not need Cython anymore?


your manifest is broken.
its the 5.1.1 manifest with the branch set to 6.0.0
some of the repos dont even have 6.0.0 branch so it doesnt sync


So I should remove the scope right ?


While I'm personally happy that these `<gem>-DEV` environment variable conditions are removed, I think their removal should be in a separate commit, or at least mentioned in the commit note.


"depends" might make somebody think this gem depends on schema_plus_pg_indexes.  So maybe phrase this something like

> If [schema_plus_pg_indexes](https://github.com/SchemaPlus/schema_plus_pg_indexes)) is also in use

Or some better way.


Should be pg 9.4


Rules are fetched from here: http://docs.translatehouse.org/projects/localization-guide/en/latest/l10n/pluralforms.html?id=l10n/pluralforms

Sadly I'm not capable of knowing what the right course of action is here: Chinese is well... Chinese to me.


@epifrin This PR added the `paragonie/random_compat` library, which is a compatibility library that adds the `random_bytes` function to PHP versions lower than 7.
This has since been changed, since Symfony now uses their own polyfill library, which looks like it might not be including the correct polyfill for that function in the 2.8 branch.

Also, what exactly do you mean with `my project was down with error after composer update`? Symfony 2.8 is not yet stable, so you shouldn't be using it anywhere near a production server but only in development.


Hmm, I don't know :smiley:. For some reason I thought that the Git bundle passed `--amend` and I tried to stay backwards compatible. Now I see that it does not pass that flag.


`IByteBuffer` level functionality


minor: remove the brackets


This snippet is in every function. We should DRY our code and even better, offload this to a [authorization listener](http://symfony.com/doc/2.3/components/security/authorization.html#the-access-listener).

This function should only care about how to get the git branch of a lib. Removing this code from here will also allow us to later offload the secret API check to an external API limiter without any code changes.


Oh. Ignore that last comment. I was seeing things.


這一步太複雜了，而且有一點點自己把「多一本，折扣多5%」的商業邏輯帶進來。

並不算錯，只是兩本95折，三本9折，這一些折扣都是獨立的。


all I can suggest is to use SMTP to deliver the email maybe use https://mandrillapp.com I use that with phpmailer works great, also from this you get email reports and can track emails.


Was this forgotten? Should be a separate commit.


Assert.Fail() 沒有拔掉。


Incorrect commit comment... really closed #82


@igrekster
I moved it up here because the code on [line 351](https://github.com/vrapper/vrapper/commit/09133106d7b56bd2bfb6babede6b6cbe9e5e92f5#diff-8ccb116379971b78e2c9ba060e2cfef5R351) applies to both branches to get their EOL selection behaviour corrected.


thanks! :+1:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2688](https://teamcity.mesosphere.io/viewLog.html?buildId=65295&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:21


你會發現因為完成第二個 scenario 的寫法，導致第三個 scenario 的行為與第二個 scenario 相同。所以想用 TDD 增加紅燈的測試案例，加進去竟然是綠燈。

這不是一件好事，除非在你的定義裡面，這兩個 scenarios 的本質是相同的。（這就是為什麼上一個 scenario 我的 comment 提到，N本的折扣是獨立的，而不是有關連的）


Yeah, it's the default -- but is there any real harm in issuing it anyway?  I guess it's a question of cleaning up the code vs cleaning up the output.  I'm actually on the fence myself.

So I don't mind if you want to keep it as a separate hash, but I'd still use

 ```ruby
options[:case_sensitive] = false if has_case_sensitive_index?(column, scope)
```

(oops I forgot the `if ..` guard in my first comment!)


:dancers:


Thanks! :+1: @DavidJDJ


Looks very fishy, I do not trust that this works on all platforms/compilers. It should probably found explicitly in some way. And beyond that it should probably round to nearest (int rounds towards zero AFAIK).


chroma fix


了解～ 會在針對習慣做調整 : )


Why/what for?


Why is chroma somehow separate?


artifact ordering ?


really ?


這個 scenario 從需求上就有點奇怪了。
test method 名稱寫 100*4*0.8，竟然是等於 270。
而 expected 卻是 320。


What?


no <scope>test</scope> here


"bl**a**g" is intentional. (:


又忘記拿掉 Assert.Fail() 了


artifact ordering


@albertdev
My apologies, missed it.


This is the same code as above, duplicated?


while do you want to change assertions ?


Why, justification?


Fishtest comment is kind of misleading, since TC is not small at all with 1+1...


This is a good question that also occurred to me. This implementation only searches on the byte level, not on the char level. However, the original implementation does the same, here is why:
`strings.Index` has the special case:
```
	case n == 1:
		return IndexByte(s, sep[0])
```
`strings.IndexByte` is implemented in assembly and uses the exact same subroutine `runtime·indexbytebody` as `bytes.IndexByte`:
```
TEXT bytes·IndexByte(SB),NOSPLIT,$0-40
	MOVQ s+0(FP), SI
	MOVQ s_len+8(FP), BX
	MOVB c+24(FP), AL
	LEAQ ret+32(FP), R8
	JMP  runtime·indexbytebody(SB)

TEXT strings·IndexByte(SB),NOSPLIT,$0-32
	MOVQ s+0(FP), SI
	MOVQ s_len+8(FP), BX
	MOVB c+16(FP), AL
	LEAQ ret+24(FP), R8
	JMP  runtime·indexbytebody(SB)
```
Thus I would say that the original `strings.IndexByte` also only searches on the byte level. For the other cases there is no code that suggests otherwise.

The reason why this works is because UTF-8 was designed to be immune against partial mismatch. As long as the string's content is valid UTF-8, this will work as expected.


These changes need to be redone manually in develop, because refactoring.


Separate commit.


@flavour How can I remove the person-filter that I added as this here yet show the selected person in the S3OptionsFilter dropdown on load?


@flavour Please review


Great tip. Thanks.


Hi Eduardo

Is ready your sermepa function for new requeriments by Redsys on 23/11/2015 about migration to SHA256?


It's a pretty valid point. I've removed this part.


I'd prefer: `if (x != 0) { ...}`


I meant "Fixes ceylon/ceylon-compiler#23942"


I don't use Symfony, I just use symfony/security-csrf 2.7.* which requires symfony/security-core
and composer installs security-core version 2.8, I don't know why.


Cant merge


Isto provavelmente está errado (/api/createChallenge). Apredam Socket.io porque cada challenge será um socket e não uma simples chamada à API.


Failure happened for MSVC 18.0.31101.0.


remove


It will work automagically once we add depends/osx/glew to it then i think :)


Yes, I worked in a new version, but I have one error with url  test.
I contact with Bank for resolved the problem.


第三次紅燈，其實是 貼 Code 時候沒注意， Debug 才發現，
這次，的情況就真的是 ，老師在紅燈三 寫的 註解情況  : ）


複製之後修改沒注意 XDD


Allright. So, what's next? We will have private and public methods with name `contains`?


I've added this patch but modified it a little bit.


Compare b1 with b2


@xj90512 If you want solution configure+forget then you can use configuration file to init your shell. Just google "shell profile init"


I think this should not be in this PR. Anyway, if you want to change getAllMappings() from returning null, you'll have to adapt all callers.


Do you have something like 'minimum-stability: dev' in your composer.json? I'm not sure why else it would install a dev. As for the issue with the `random_bytes` function, I created a PR to fix this #16365


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.717](http://teamcity.monogame.net/viewLog.html?buildId=10935&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 551, ignored: 6 Build time: 00:21:10


Reading through the online content, provided resource and https://en.wikipedia.org/wiki/Chinese_grammar#Plurals it seems that `nplurals=2; plural=(n > 1);` is not so common. The currently generated code is not affected, thus it can be left as is for now.


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 38](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=383&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


Oh sorry, I remember why, if I do "options[:case_sensitive] = false", this option would come in the last of the final output. And I actually prefers putting "if" in the last><

@ronen what do you think ?


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 38](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=383&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:52


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 2689](https://teamcity.mesosphere.io/viewLog.html?buildId=65297&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:10:11


I'm not sure how to apply the fix on my end.  Do I need to download a file or new z-way-server version on the PI?


It would make sense to me to check the exact returned exception was ``AttributeError("function should be globalXX")`` (although looking at that now, the error could be more helpful - XX here means two letters, right?)


Ne, ich meine genau anders rum. ^_^ Paptrick P. hat das Wort "statement" verwendent.

Man führt jedoch einen Ausdruck aus??!
Beispiel: https://docs.angularjs.org/api/ng/directive/ngClick


I'm afraid fishtest is useless here:
* it auto purges time losses
* it does not tell you which version lost on time

The correct way to know if this improves anything, is to measure it like Joost did:
https://groups.google.com/forum/?fromgroups=#!topic/fishcooking/kPNocZQkW-4


That's a peculiar variable name that might lead to unintentional errors. Why not simply override the variable or just use a new name instead?


I undersand that but as a user when I started coding I immediatley write DynamicPtr as soon as I saw ItemPtr. No hard feelings about it but it did not feel natural.


.... jetzt bin ich auch verwirrt! :sweat_smile:


As routes referentes à aplicação em si serão para colocar em AppRouter e não em AuthRouter.


awesome! :+1:


perfect, I just wrote this exact thing today. :+1:


M-x calendar says today's the 28th.


Dette suger


I think these comments (both the OSX and nnedi ones) should be removed. The GL code didn't have a dependency on GLSL 150 before (it was just there because OSX itself didn't accept shaders with lower versions), but now that there's some code depending on up to 330, it's natural and doesn't need to be documented. Just like most of the extensions have no comment why they're needed.


Dette liker jeg


I know you love conditional expressions :smile: but in the case of operator and equals implementation, I prefer to not mix the reference checks with the value checks. It is extremely easy to get these implementations wrong and end up with stack overflows in edge cases. I want these as simple and as readable as possible, they're very likely to be copy-pasted around and the value checks may be changed in the future.


Joda, så neida


:yellow_heart: There are too many `<br>` and `<hr>` tags. There may be a better way to style this page.


:green_heart: The changes made to lines `425` and `470` are excellent.


Oh actually I forgot that the scope is included in your test for index uniqueness.  (Now that you mention it, I'm not even certain what schema_plus_pg_index's behavior would be for a multi-column index, I *think* it will do the right thing...)

I think it's OK to keep it, but I'd make that a separate context, for clarity.  That is, I'd keep the simple tests I suggested, and then add another context:

```ruby
context 'with case-insenitive uniqueness within a scope'
  ...
  create_table :scopes ...

  create_table :items do |t|
     t.integer :scope_id
     t.string :value
   end
   ...
```

Yes that makes the tests longer and somewhat redundant but it'd be clear when looking at the specs what's being tested and why.  (If the redundancy in the tests bothers you, you could DRY them up by adding a local method in the outer context to wrap up some of the common code -- but at some point that may be more complexity than it's worth.)


D'oh.... fixed!


@aleffert previously we were sending `Values.NOTIFICATION_RECEIVED` (which translated to `edx.bi.app.notification.course.update.received`) as the name of the event. Which didn't seem right as compared to other event names.

So, I've changed it `Events.PUSH_NOTIFICATION_RECEIVED` (which translated to `notification-received`). Is this correct ?

P.s.  `PUSH_NOTIFICATION_RECEIVED` string was previously sitting there in the file unused.


:green_heart: You've done an excellent job with the refactor and code style corrections.


Looks good. I'll get this integrated this afternoon.


ForeignColumnSerializer?


The right-hand of the `&&` seems redundant: if the left-hand is true, the right-hand *must* be true as well (it could be asserted).


For sure..


:yellow_heart: The commented-out block ought to be removed.


its


Don't merge this change. Works on dev environment but not in production environment. I shot too fast.


me too :)


@aleffert previously we were sending `Values.NOTIFICATION_TAPPED` (which translated to `edx.bi.app.notification.course.update.tapped`) as the name of the event. Which didn't seem right as compared to other event names.

So, I've changed it to `Events.PUSH_NOTIFICATION_TAPPED` (which translated to `notification-tapped`). Is this correct ?

P.s.  `PUSH_NOTIFICATION_TAPPED` string was previously sitting there in the file unused.


тьфу, да


OK I'll admit I sometimes get obsessive about the output too :)  In that case, I'd go with

```ruby
options = {}
options[:allow_nil] = true
options[:scope] = scope
options[:case_sensitive] = false if has_case_sensitive_index?(column, scope)
options[:if] = proc do ...
    end
```