I feel like it can be hard coded, but we just need to find a more ideal
value.
On Oct 12, 2015 9:18 PM, "tanczosm" <notifications@github.com> wrote:

> Not sure.. what I saw in the description off gaff was this:
> Since the network has distinct outputs for 61 different GFs, Gaff uses a
> RBF to set the "correct" values of the outputs. The RBF uses the enemy's
> effective bot width at that distance. This results in smoother learning
> than if the correct outputs were set to 1 and the others were switched off.
>
> So my question was what is the enemy effective bot width? My thoughts
> are that a close bot allows you a much wider range of guess factors that
> are still accurate but as you move away the range narrows greatly.
>
> In NNBullet line 80 we have the following:
>
> outputs = RBFUtils.processDataIntoFeatures(gf, 0.05, centers);
>
> The 0.05 is a very arbitrarily chosen value that seemed to work well.
> However, my thoughts are that that value needs to be calculated instead of
> hard-coded. I'm not sure of the calculation yet.. bots are 36 pixels by
> 36 pixels and are always oriented as a rectangle with no rotation for the
> hitbox.
>
>
>
>
>
> On Mon, Oct 12, 2015 at 8:54 PM, greenec <notifications@github.com> wrote:
>
> > Anything I could help implement?
> >
> > On Oct 12, 2015 8:49 PM, "tanczosm" <notifications@github.com> wrote:
> >
> > > Yep, relative to the heading of our gun. To be honest it impacts all
> > > bots.. I thought of something else though that I want to try tonight
> and
> > > see how it goes.
> > >
> > > On Mon, Oct 12, 2015 at 3:50 PM, greenec <notifications@github.com>
> > wrote:
> > >
> > > > So it's relative to the heading of our gun? How much of an impact
> does
> > > that
> > > > have against shadow?
> > > >
> > > > On Oct 12, 2015 3:45 PM, "tanczosm" <notifications@github.com>
> wrote:
> > > >
> > > > > Actually what it would be is that we'd be making accurate shots for
> > one
> > > > > movement direction only (direction is 1 or -1) under that bug..
> hence
> > > the
> > > > > gross misses for Circlingbot
> > > > >
> > > > > On Mon, Oct 12, 2015 at 2:12 PM, greenec <notifications@github.com
> >
> > > > wrote:
> > > > >
> > > > > > In that case, we would be taking the shot as if the enemy had not
> > > > lateral
> > > > > > velocity.
> > > > > > On Oct 12, 2015 2:08 PM, "tanczosm" <notifications@github.com>
> > > wrote:
> > > > > >
> > > > > > > I was logging the "Direction" stat using our own bot lateral
> > > > direction
> > > > > > > rather than the enemy direction .. =P
> > > > > > >
> > > > > > > Since we weren't moving it would be right about half the time
> or
> > > so.
> > > > It
> > > > > > > was literally a matter of changing the use of the variable
> > > > > > > "LateralDirection" to "EnemyLateralDirection".. easy to miss.
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Mon, Oct 12, 2015 at 2:05 PM, greenec <
> > notifications@github.com
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > Just a bit. What was the issue with the situation scanner?
> > > > > > > > On Oct 12, 2015 2:01 PM, "tanczosm" <
> notifications@github.com>
> > > > > wrote:
> > > > > > > >
> > > > > > > > > lol.. tried CirclingBot and got an accuracy score of
> 99.94%.
> > > > Slight
> > > > > > > > > improvement huh?
> > > > > > > > >
> > > > > > > > > On Mon, Oct 12, 2015 at 12:07 PM, greenec <
> > > > > notifications@github.com>
> > > > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Also scores roughly 2300 against WeeksOnEnd
> > > > > > > > > >
> > > > > > > > > > —
> > > > > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > > > > <
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13720564
> > > > > > > > > >
> > > > > > > > > > .
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > > —
> > > > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > > > <
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13722828
> > > > > > > > >
> > > > > > > > > .
> > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > > > —
> > > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > > <
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13722907
> > > > > > > >
> > > > > > > > .
> > > > > > > >
> > > > > > >
> > > > > > > —
> > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13722960
> > > > > > >
> > > > > >
> > > > > > > .
> > > > > > >
> > > > > >
> > > > > > —
> > > > > > Reply to this email directly or view it on GitHub
> > > > > > <
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13723039
> > > > > >
> > > > > > .
> > > > > >
> > > > >
> > > > > —
> > > > > Reply to this email directly or view it on GitHub
> > > > > <
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13724707
> > > > >
> > > >
> > > > > .
> > > > >
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13724800
> > > >
> > > > .
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13729171
> > >
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13729246
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13729523>
> .
>


que buen cambio shabo


In my environment, this change only fixes, for using find in files once. For it's original functionality also comment the line 3066.


Hi @ok-at-github if you have any time, try out this branch and let me know if you find out any issues :)

Thank you :)


You should call this something else


TeamCity pull requests :: netty [Build 404](https://garage.netty.io/teamcity/viewLog.html?buildId=2240&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5219, ignored: 21 Build time: 00:23:49


No, I think its fine. You're an idiot.
https://www.google.com/url?sa=i&rct=j&q=&esrc=s&source=images&cd=&ved=0CAcQjRxqFQoTCNekyfOovsgCFdCiiAodBSoFyQ&url=http%3A%2F%2Fwww.gifbin.com%2F981430&psig=AFQjCNEKAZPs6MkREmP3qv2dc6wW5Hj2Pw&ust=1444786937832175


Do the math buddy.. no shortcuts.  ;)

On Mon, Oct 12, 2015 at 9:37 PM, greenec <notifications@github.com> wrote:

> I feel like it can be hard coded, but we just need to find a more ideal
> value.
>
> On Oct 12, 2015 9:18 PM, "tanczosm" <notifications@github.com> wrote:
>
> > Not sure.. what I saw in the description off gaff was this:
> > Since the network has distinct outputs for 61 different GFs, Gaff uses a
> > RBF to set the "correct" values of the outputs. The RBF uses the enemy's
> > effective bot width at that distance. This results in smoother learning
> > than if the correct outputs were set to 1 and the others were switched
> off.
> >
> > So my question was what is the enemy effective bot width? My thoughts
> > are that a close bot allows you a much wider range of guess factors that
> > are still accurate but as you move away the range narrows greatly.
> >
> > In NNBullet line 80 we have the following:
> >
> > outputs = RBFUtils.processDataIntoFeatures(gf, 0.05, centers);
> >
> > The 0.05 is a very arbitrarily chosen value that seemed to work well.
> > However, my thoughts are that that value needs to be calculated instead
> of
> > hard-coded. I'm not sure of the calculation yet.. bots are 36 pixels by
> > 36 pixels and are always oriented as a rectangle with no rotation for the
> > hitbox.
> >
> >
> >
> >
> >
> > On Mon, Oct 12, 2015 at 8:54 PM, greenec <notifications@github.com>
> wrote:
> >
> > > Anything I could help implement?
> > >
> > > On Oct 12, 2015 8:49 PM, "tanczosm" <notifications@github.com> wrote:
> > >
> > > > Yep, relative to the heading of our gun. To be honest it impacts all
> > > > bots.. I thought of something else though that I want to try tonight
> > and
> > > > see how it goes.
> > > >
> > > > On Mon, Oct 12, 2015 at 3:50 PM, greenec <notifications@github.com>
> > > wrote:
> > > >
> > > > > So it's relative to the heading of our gun? How much of an impact
> > does
> > > > that
> > > > > have against shadow?
> > > > >
> > > > > On Oct 12, 2015 3:45 PM, "tanczosm" <notifications@github.com>
> > wrote:
> > > > >
> > > > > > Actually what it would be is that we'd be making accurate shots
> for
> > > one
> > > > > > movement direction only (direction is 1 or -1) under that bug..
> > hence
> > > > the
> > > > > > gross misses for Circlingbot
> > > > > >
> > > > > > On Mon, Oct 12, 2015 at 2:12 PM, greenec <
> notifications@github.com
> > >
> > > > > wrote:
> > > > > >
> > > > > > > In that case, we would be taking the shot as if the enemy had
> not
> > > > > lateral
> > > > > > > velocity.
> > > > > > > On Oct 12, 2015 2:08 PM, "tanczosm" <notifications@github.com>
> > > > wrote:
> > > > > > >
> > > > > > > > I was logging the "Direction" stat using our own bot lateral
> > > > > direction
> > > > > > > > rather than the enemy direction .. =P
> > > > > > > >
> > > > > > > > Since we weren't moving it would be right about half the time
> > or
> > > > so.
> > > > > It
> > > > > > > > was literally a matter of changing the use of the variable
> > > > > > > > "LateralDirection" to "EnemyLateralDirection".. easy to miss.
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > On Mon, Oct 12, 2015 at 2:05 PM, greenec <
> > > notifications@github.com
> > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Just a bit. What was the issue with the situation scanner?
> > > > > > > > > On Oct 12, 2015 2:01 PM, "tanczosm" <
> > notifications@github.com>
> > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > lol.. tried CirclingBot and got an accuracy score of
> > 99.94%.
> > > > > Slight
> > > > > > > > > > improvement huh?
> > > > > > > > > >
> > > > > > > > > > On Mon, Oct 12, 2015 at 12:07 PM, greenec <
> > > > > > notifications@github.com>
> > > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > Also scores roughly 2300 against WeeksOnEnd
> > > > > > > > > > >
> > > > > > > > > > > —
> > > > > > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > > > > > <
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13720564
> > > > > > > > > > >
> > > > > > > > > > > .
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > —
> > > > > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > > > > <
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13722828
> > > > > > > > > >
> > > > > > > > > > .
> > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > > —
> > > > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > > > <
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13722907
> > > > > > > > >
> > > > > > > > > .
> > > > > > > > >
> > > > > > > >
> > > > > > > > —
> > > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > > <
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13722960
> > > > > > > >
> > > > > > >
> > > > > > > > .
> > > > > > > >
> > > > > > >
> > > > > > > —
> > > > > > > Reply to this email directly or view it on GitHub
> > > > > > > <
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13723039
> > > > > > >
> > > > > > > .
> > > > > > >
> > > > > >
> > > > > > —
> > > > > > Reply to this email directly or view it on GitHub
> > > > > > <
> > > > >
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13724707
> > > > > >
> > > > >
> > > > > > .
> > > > > >
> > > > >
> > > > > —
> > > > > Reply to this email directly or view it on GitHub
> > > > > <
> > > >
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13724800
> > > > >
> > > > > .
> > > > >
> > > >
> > > > —
> > > > Reply to this email directly or view it on GitHub
> > > > <
> > >
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13729171
> > > >
> > >
> > > > .
> > > >
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13729246
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13729523
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/greenec/robocode/commit/91bfa01564fbe695760fca927f0e4c4c1fc66153#commitcomment-13729745>
> .
>


see picture


I usually expect a Foo.FromBar to create a Foo. I'm not sure I see a better option here though - and I think the overall impression is fine.


Them Tab Section trong department


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 596](https://teamcity.mesosphere.io/viewLog.html?buildId=57793&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:03:53


textureFileName没有必要提前取出。


Changed it to IPAMConfig.  and Yes, the reason it is isolated is for the Marshalling.

I couldn't define it in api/types due to an existing circular dependancy with network package.
`NetworkSettings *network.Settings` is being used in ContainerJSONBase.
So I continued with that approach of using `network` package which is common for both api and daemon package.
We can redesign these data-structures to make it more streamlined. but that is a bigger change than this PR entitles.
Does that sound okay to you ?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 597](https://teamcity.mesosphere.io/viewLog.html?buildId=57794&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:49


Are we expecting anyone else to use ITokenAccess? This doesn't feel Google-specific (due to it using the interface) - is it actually? If it's not, I guess it probably belongs in a different class... "TokenAccess" perhaps?


textureFileName应当也移动到if(flag)块中。


If I may ask. Since `@View` is now optional and it was removed from docs, shouldn't the import of it be removed as well?


So far I'm lovin it. Much better than perls bot basicbot. I think I just don't really like perl very much anymore. After using ruby and java do much, perl seems kinda eh for anything other than regex based stuff. So much line noise, and having to end your lines in a specific character is annoying.


I'd be interested in seeing an IRC bot in a less mainstream language like clojure, Haskell, etc.


Thanks for the patch dude! That's merged now.


I'll advise you to stop bloating it , you are giving people hard time trying to remove all that from your code..
;)

People are (maybe) interested in your bot..do not force them into looking at your stuff that is completely irrelevant and probably uninteresting ..

my two cents . .


Oops my bad on that lol


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/85034792


{"BQ", "Bonaire, Sint Eustatius and Saba"}


Why do we need to observer on a different scheduler? MetricsService is already async. Observers already observer events asynchronously.


The naming `hash_31` is not irresponsive to what it exactly behaves.


Looks like you misspelled "canola".


Don't leave the dead code.


full name is Google.Apis.Auth.OAuth2.ITokenAccess and it is google auth library specific (i.e. we don't expect any third party library to implement it).

ITokenAccess has been introduced into https://github.com/google/google-api-dotnet-client fairly recently and besides GoogleCredential, it allows you to UserCredential, ServiceAccountCredential or ComputeCredential from the auth library instances directly.


fast-forwarding master to auto = b2b1ae0c


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 598](https://teamcity.mesosphere.io/viewLog.html?buildId=57796&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:16


Good point, I'm adding a #error with a couple of spot checks


TeamCity Azmq :: Build (Linux) [Build 139](https://78.46.71.115/viewLog.html?buildId=615&buildTypeId=Azmq_BuildLinux&guest=1) is now running


TeamCity Azmq :: Build (Windows) [Build 169](https://78.46.71.115/viewLog.html?buildId=616&buildTypeId=Azmq_Build&guest=1) is now running


TeamCity Azmq :: Build (OSX) [Build 122](https://78.46.71.115/viewLog.html?buildId=617&buildTypeId=Azmq_BuildOsx&guest=1) is now running


Thanks for the explanation.
On Mon, Oct 12, 2015 at 6:45 PM Madhu Venugopal <notifications@github.com>
wrote:

> Changed it to IPAMConfig. and Yes, the reason it is isolated is for the
> Marshalling.
>
> I couldn't define it in api/types due to an existing circular dependancy
> with network package.
> NetworkSettings *network.Settings is being used in ContainerJSONBase.
> So I continued with that approach of using network package which is
> common for both api and daemon package.
> We can redesign these data-structures to make it more streamlined. but
> that is a bigger change than this PR entitles.
> Does that sound okay to you ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mavenugo/docker/commit/1143608a697cb8be26fcdf8855eb2afdec812ea6#commitcomment-13729822>
> .
>


Righto - if it's Google-specific, that makes perfect sense.


need to update the category to new ,  or you ccould update it later when you go through all usecases


Tell me more


TeamCity Azmq :: Build (OSX) [Build 122](https://78.46.71.115/viewLog.html?buildId=617&buildTypeId=Azmq_BuildOsx&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 28 Build time: 00:03:37


TeamCity Azmq :: Build (Linux) [Build 139](https://78.46.71.115/viewLog.html?buildId=615&buildTypeId=Azmq_BuildLinux&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 28 Build time: 00:03:50


just change ImreadMode to ImreadModes


private final ImmutableSet<InetAddress> allowedReplicaAddresses;

It would be nice do self document this code about it's immutability.
Also as far as I understand this code, this set is used for filtering out nodes, that will be used for scheduling? If so, allowedReplicaAddresses name seems a better fit.


wow thanks bro


@lindamartin  https://jira.sonarsource.com/browse/SONARPHP-558


@vilchik-elena indeed looks clearer.


sec_qun` varchar(50) DEFAULT NULL,
+  `sec_ans` varchar(50) DEFAULT NULL,
+  `rating` int(11) NOT NULL DEFAULT '0',
+  `desp` varchar(100) DEFAULT NULL,

Can you tell me the importance of these fields ?. I feel rating should not go into the user table.


I think that is too complex for such minor function. I changed it because of issue #7 (in which I still slightly doubt). Current version is good enough and will work with PHP >= 5.3.0.


@vilchik-elena indeed thanks!


Fala @DaniloAgostinho, o Daciuk vai explicar mais pra frente.
Fiz cagadinha... kkkk
Ele me avisou pra não utilizar as coisas que não vimos em aula. ;D


Why not 'root'? And $process_user same.


@vilchik-elena indeed I was afraid it would be unreadable but it's better.


Truth be told, it's only `pyBwGetValues()` and `pyBwGetIntervals()` that seem to cause segfaults with optimization.


This would be better written as:

``` bash
vado() { vagrant ssh -c "cd /vagrant && $*"; }
```


Yes, getQueryTrace will perform the request. As you noted, it's currently done by the getters of QueryTrace, but it doesn't make that much difference overall, because there is no way to access the fields of an incomplete trace (the getters call maybeFetchTrace each time, so even if you've already retrieved part of the fields they will still block until the trace is complete).
So I feel like making getQueryTrace perform the query and return a simple POJO is simpler and lends itself better to an async version.
As for mentioning that in the comments, I would wait until we actually change it, to avoid being too confusing.


Ну да, тут либо все переделывать, либо оставить как есть :) Мне все отрефакторить сразу хотелось :)


Just tested on 2.11.x.

-Dscala.shell.prompt works.

Unfortunately, welcome property does not work as expected.
There is always 'Welcome to scala version...' message whatever you put in -Dscala.shell.welcome (or -Dscala.repl.welcome)


Hey @voku I'd love to get some more varied test cases, can you open a PR ?


Would it be okay if the structure was:

`tmp/networks/<testing_ground_id (..)>/<strategy_or_not (0|1)>/<Sha256 of key>.tmp`


Yes,


We need it configurable, yes.


second question regarding this line,

I'm not familiar with cassandra setup, but is it a desired feature that list of allowed hosts to run query on is the same as the lists of contactPoints?


@vilchik-elena excellent :D


I don't think @cyberium is trying to avoid a division by zero here. From my understanding, the purpose here is to avoid to send to the client a value rounded to zero (making the client believe the creature is dead) while it is still alive server-side (HP > 0). Said otherwise: 0% is not 0 HP.


Rather than saying "To order by a custom field...", how about "To preserve the QuerySet's existing ordering..."? That way it's a bit clearer about what the parameter's actually doing, I think.


Haloween -> Halloween


I can't believe you actually spotted this, fixed it and made a pull request.
Thank you, on behalf of every OCD out there :D


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 633](https://teamcity.mesosphere.io/viewLog.html?buildId=57870&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:07:20


$termsMapping = array();


It'd be nice to have this fix on Hackage. :-)


$termsMapping[$term->getId()] = $newTerm->getId();


$newLoad->term_id = $termsMapping[$load->term_id];


I think we want to preserve unknown fields in the metadata when a file is uploaded over an existing file. (Remember that different clients of a magic folder collective may be using different versions of Tahoe, and we probably don't want the metadata written by a later version to be lost in that case. Actually, the best option would be to write a "magic_folder_schema_version" field, so that it is possible to tell which fields were deliberately written and which were just preserved.)

Nevertheless, LGTM, let's work on top of this commit.


add release info


It's being clipped, as per the text in AudioParam.


I think this one is easier/simpler. I'd even be ok with just having a comment in the function instead of the API docs.


Got it. Then, good luck.
If you somehow solve the problem with auto `get_absolute_urls` or invent other killing features, feel free to pull request!

```python
print('Thanks for md hint!')
```


Can the logger service really be `null`? It is instantiated in both the "prod" and the "dev" environment.


Sweet commit bro


I'm also seeing flickering issues using Angular 1.4.7 with an Ionic app on iOS 9.02.

[Android works fine.]


Seems like this line is causing the error as this is not a string, it's a tuple :cry:


Yes, you're right.


Nope, but I'm no make expert...


You don't need those `else`s (there's only one `if` scenario), they're extraneous.


if core is removed from those sites won't they be unable to actually install the features ?

and I honestly do not think we should tell any users (except advanced ones to use p2 sites directly). They should use marketplace or central.

p2 cannot provide the simplified layout you are asking for without exposing multiple sites to the user.


Why would we enforce it in task? In original code original point was to let Nunjucks decide.

Besides, it's better to define it here: https://github.com/vitkarpov/grunt-nunjucks-2-html/blob/master/tasks/nunjucks.js#L22

Grunt will make checks itself and merge all options


The great thing about standards... :)


Oops sorry that's the french notation, we use the semicolon here because we use the colon for decimals:

> [3,4 ; 6.7]

I'll fix this.


existant --> existent
I'd write `folder does not exist`


does it make any difference for our case? I though it's for server-side templates only

Besides, I think we should ship with Nunjucks defaults (thus, let it be undefined)


OK for me, with just a small remark about logging. The way it is currently implemented here (lines 136 and 142) will produce the following possible results:

debug level 1 and success:
looking for interface speed from syscall

debug level 2 and success:
looking for interface speed from syscall
retrieved interface speed from syscall

debug level 1 and failure:
looking for interface speed from syscall

debug level 2 and failure:
looking for interface speed from syscall

Additionaly, debug level 2 will currently also output all executed command, interlaced with previous comments, making it even more difficult to read and understand for final user.

I tried to implement a consistent way to report this generic pattern in commit 392a25b399f56e7a3be492996df78f15d77794d2 :

trying to retrieve information foobar:
- using method X: failure
- using method Y: failure
- using method Z: success

The same approach should probably used here, with or without using the dedicated functions.


@arrowrowe en


Nunjucks 2.0 defines autoescaping by default. If user dosn't define it's `undefined` and nunjucks gets `false`. It is not that user expects from default behavior.


Bugglegum beagle?


Realized this was not needed. I didn't read the question close enough


init


> I'd even be ok with just having a comment in the function instead of the API docs.

I think it's better to have in the public docs.

The downside of this approach is that `ewmh.activate` is likely to be overridden by a user's config.
That means we should have both probably?


I'm just refactoring what the existing code makes, so no difference with your appreciation


Yeah, but make it a compute field and use that field on the other method


i Own MT6592 Device With Official Lollipop And Your CTRv3.3 Boots On it, So Don't Know if My Device Lollipop Firmware is Unique Enough To Help Beta Testing Of Your Upcoming Recovery...


No reason, I put that in a while back before asking for comments and I just rebased those changes.


> Grunt will make checks itself and merge all options

I think I'm wrong. If `options.autoescape` is `undefined` here, than nunjucks turn on autoescaping by default?


Yes.


> `preparedStatement.bind("a", UNSET, "c", "d")`

That wouldn't work as-is, because `bind` would try to serialize UNSET (failing if there is no codec to convert ByteBuffer to the type of v0). Granted, we could add a special case like we do for tokens.

But overall I'm reluctant to expose `UNSET` because it's essentially an implementation detail. Things could get confusing, for example you might assume that `setBytesUnsafe(i, UNSET)` would be equivalent to `unset(i)` but it's not, because `setBytesUnsafe` makes a defensive copy of its argument.


Yeah, please.


<http>
<li>woo</lii>
<http/>


Looks good when I try *.img, *.edf and *.pgm files. Colour options appear to change as they should. For some reason I get a deadlock when attempting to open *.jpg and *.tif .


:) you didn't test it do you:) it has a bug as the object can have inherited template property, test with GMCQ for instance, it will have mcq already.


Hm. Good argument. Then I guess the other approach wins, because it always works.


In my original PR I've said that if Nunjucks gets `undefined`, it doesn't treat it as `false`, and fallbacks to it's defaults, thus your last statement is correct :)


* `<testing_ground_id (..)>`: The idea is to prevent having thousands of subdirectories under `tmp/networks` as some tools can begin to slow down in that situation. The idea was to have subdirectories each with a maximum of 1,000 cached networks inside. However, I'm not sure how likely it is that we'll have thousands of cached networks stored... maybe on production where deploys are less frequent? I think this is probably okay for now; we can adjust it later if we need to.

* Instead of `<strategy_or_not (0|1)>` maybe we could use `basic` and `features` (the graph with no special behaviours enabled, and the graph with the user's choice of features). There's no technical argument for using a word instead of `0` and `1`, but it is more easily human-readable.


Do you plan to switch go `git-r3` sometime? Especially the shallow clone thing is a benefit.


FIXME left over?


Sad to see ☠☣ go 😕


Tried making a PR myself to the Grunt Handlebars module: https://github.com/gruntjs/grunt-contrib-handlebars/pull/147


Maybe this would be better option:
`if(!object.template || object.template != name) `


SHA1 UUID code on line 100 updated. Uses LBSL identifier (busData column1) as input instead of the NapTAN ID (busData column 3). All generated UUID values are now unique.


This code looks correct, but perhaps worth a comment to say that you are checking over both IP v4 and v6. It took me a minute to realise quite what was going on here.


**Eslint**: 'return' outside of function


**new-cap**: A function with a name starting with an uppercase letter should only be used as a constructor.


**valid-jsdoc**: Missing JSDoc @returns for function.


The intention of this code is to stop ``object.template == name``  as default if a template is specified.
The better solution is to add "template": "gmcq" to the gmcq definition.


In this case, it should be like:
```python
        available_quants_ids = self.env['stock.quant'].search(
            ['|', ('location_id', '=', move.location_id.id),
             ('location_id', 'in', move.location_id.child_ids.ids),
             ('product_id', '=', move.product_id.id),
             ('qty', '>', 0),
             '|', ('reservation_id', '=', False),
             ('reservation_id', '=', move.id)])
```


Can be changed


Рисунок похож на ASCII рисунок, он хоть как то "дергается", хотя я понимаю что это написано пипец коряво=)
з.ы. программированию никто никогда не учил, что сам узнал из того и сделал=)


> The idea was to have subdirectories each with a maximum of 1,000 cached networks inside.

I understand now what you mean with those subdirectory numbers. Maybe we could this some other time.

> maybe we could use basic and features

I agree with `basic` and `features` :+1:

Thanks for your comments.


Please do publish this stable `0.12` version to CocoaPods too. Thanks @mkonicek!


see - https://github.com/adaptlearning/adapt-contrib-gmcq/pull/87/files


It's worth noting that grid.cols also isn't in common-settings - do we want/need to add it? grid.cols is currently set in verticalhome's json configuration (apps/verticalhome/build/default-homescreens.json) - will common-settings conflict with that?


Hi Holger,

thanks for your contribution!

Have You signed the OCA? (http://www.oracle.com/technetwork/community/oca-486395.html)

If not and you are willing to do that, can you please add the testcase? + ideally include the same fix in JDK client connector. If you cannot (or don't want) sign the OCA, please let me know and I'll take over and fix this properly.

Regards,
Pavel


thanks @hrajotia


My point is that the intention breaks course with the GMCQ, the fix would be not simply check if the property exist but also compare the content of the property.


Merge sha 53aa4ce5 is stale.


merging basho/riak_kv/feature/rts351_is_query_valid_checks = 4cfdefbc into borshop-integration-1211-feature/rts351_is_query_valid_checks


basho/riak_kv/feature/rts351_is_query_valid_checks = 4cfdefbc merged ok, testing candidate = 5ecdfe5f


"replicas" is a bad name for a hostname list - replica is a copy of a data chunk. I would rename all "replica(s)" occurrences with "contactPoint(s)"

s/localReplicaHosts/localContactPoints/g
s/replicaAddresses/allowedContactPoints/g


Nice remix, Murray. Well, it's an option.


Look to `core.match` module with it this code can be a bit improved, like:
```clojure
(match [color selected legal-next-move attack]
  [:white false _ true] (white-attack-move)
  [:black false _ true] (black-attack-move)

  [:white false true  false] (white-legal-move)
  [:black false true  false] (black-legal-move)

  [:white true  false false] (white-selected)
  [:black true  false false] (black-selected)

  [:white false false false] (white-default)
  [:black false false false] (black-default))
```


Yeah, and please rename this one to `available_quants` and the other variables to `quant_lines` or similar.


In fact i had to use "unit->isAlive()"  instead but after i thought about it i think it may have an impact in some situation and it require more check to use it.
So here for improvement we may have to check result of " ceil(0.0f) ' to be sure its not 1 and we can remove the if.


Better don't use names like `v` and `f` =)


@rafrombrc is it ok to do this or constantly calling `tonumber()` would be slow/unstable?

I've hit an issue when metrics were emitted with incorrect type (string instead of number).
I guess many people will have the same problem which is not so easy to spot so I've added this workaround here.

Any other suggestions on how to handle this here?


please apply the fix himanshu has listed above ^ it's not in master yet but is in the develop of gmcq.


Would be great if you can add OTA over httpclient as well
So if you are behind a firewall or have multiple devices you can let the device check for update and download and install it without UDP / httpserver


Better use:
```clojure
(mapcat #(moves-for-f % x y color chessboard) [d/move-right d/move-left  d/move-down d/move-up)
```


As i using your setting

i have some confusions

example whats mean of this

ringbuffer-size=67108864 ( 67 mb.? )
hls-segment-attempts=3 ( it will try to get segment 3 time if not then go next one.? )
hls-segment-timeout=3 ( when hls segment timeout then it abort. and go to next segment? )
hls-timeout=45 ( when hls time out then livestream abort.? )
http-timeout=3 ( when timeout then again retry to fetch after 3 second or abort )
http-stream-timeout=20 ( after 20 second its abort or again fetch )

Thanks for your help


@karlcow I tried something, but it's doesnt work. Actually, I don"t know what I'am supposed to do ;)

I undestrand 1 point: write `filter`  in `__init__.py` I have to write the same code as your example ? https://github.com/webcompat/webcompat.com/commit/7e0305e93c4dc3710b356f70f8f554fbf390c5d3#commitcomment-13728646 ?

If you can help me? thanks


yep. get back


genau:)


Perfect! Thank you!


s/replicaHosts/addedHosts/g

Is logging of those hosts worth the additional complexity off adding additional local variable?


Du dræbte urelaterede filer!

Det ligner et Windows-baseret mord.


Thanks for teaching me `$*`!


Added tests for autoescape. It works as expected, as you have said.


With `core.match` (or just `condp =`) can be simplified to something like:
```clojure
(let [move-f (match [color has-moved]
                [:black true] d/move-down-by-1
                [:black false] d/move-down-by-2
                [:white true] d/move-up-by-1
                [:white false] d/move-up-by-2)]
  (moves-for-f move-f x y color chessboard))
```


@lucasart
If you do any testing above 7 threads the easy move fix will likely start to play a significant role in time management.
https://github.com/official-stockfish/Stockfish/pull/458
Can you hold off any such tests till after easy move for high thread counts is fixed?


And what about this one?


Slight spelling error here, not sure if this has been fixed?


For most of these if I was tidying I would have replaced this:

```python
"Here are two objects, %s and %s" % (repr(A), repr(B))
```

with:

```python
"Here are two objects, %r and %r" % (A, B)
```

Using the format method with the ``!r`` conversion flag this would be:

```python
"Here are two objects, {0!r} and {1!r}".format(A, B)
```


everything works fine


Oh, also, this is a datastore setting, not a global setting - so I guess the point is moot...


0 it's not default value? It's only for debug.. Don't know who (and why) would use 1 :smile:


this cannot be generic. Think in this scenario:
You have two diffferent implementations of the issue tracker implementation. Now you invoke this method in both issue tracker you will get the issue in one and an error in the next implementation. It should detect a link and then try to retrieve. The strategy try-error I don't think is good in this case.


Det er det bedste commit.  Denne grube er ikke stor nok til os begge.


@alicja-cyganiewicz fajne pomysł dzięki, zabieram się za implementacje :)


Minor: At first glance, the way you've laid out the parameters makes me think there's something special about the first one. I don't know what Rubocop thinks, but I think I'd prefer something like this:

```ruby
permitted_next_nodes(
  :how_much_sucrose_1?,
  :how_much_sucrose_2?,
  :how_much_sucrose_3?,
  :how_much_sucrose_4?
)
```


fast-forwarding end-to-end/timeseries to borshop-integration-1211-feature/rts351_is_query_valid_checks = 5ecdfe5f


卓哥在试验`pull request`用法


@M1ke In ES6, `let` almost completely replaces the need for `var`. It behaves like `var` in terms of mutability, but it's block (not function) scoped, making it behave more like you'd expect in terms of scoping. Of course, `let` is used here over `const` because line 27 will continually modify it.


This looks plausible to me. However, I have never used sqlalchemy before (and the docs are not particularly clear), and so I think it might be worth running past somebody else who knows more than me just to be sure.


変なこめんとが。。


改行


We [don't](https://github.com/mysociety/alaveteli/blob/develop/app/controllers/admin_public_body_controller.rb#L106) allow the destruction of public bodies with info requests in the admin interface, so I wonder whether we should not specify a `:dependent` clause here to be consistent. Also, the `:order` param seems to have been removed here, I'm guessing not intentionally?


If the URL does not belong to the current IssueTracker implementation than the issue is not retrieved.  See the check on line 100, this method is not generic as it utilises the baseURL set in the IssueTracker implementation.  The NotFoundException is only thrown if the URL points to an issue that does not exist.


ほほ


@levackt Here are some tricks to make component more testable and configurable in general.


what about this alternative?

```haskell
countContexts :: Int -> Spec
countContexts i = do
        [Only contextCount] <- doQuery connPool [sql| SELECT COUNT(*) FROM contexts |] ()
        contextCount `shouldBe` (0 :: Int)
```


Since I think `permitted_next_nodes` is intrinsically connected to `next_node`, i.e. I don't think you ever want to have the former without the latter, I'd prefer that we passed the permitted next nodes into `next_node` itself or set them within the `next_node` block somehow, e.g.

```ruby
next_node(permit: [
  :how_much_sucrose_1?,
  :how_much_sucrose_2?,
  :how_much_sucrose_3?,
  :how_much_sucrose_4?
]) do |response|
  # routing logic
end
```

OR

```ruby
next_node do |response|
  permit(
    :how_much_sucrose_1?,
    :how_much_sucrose_2?,
    :how_much_sucrose_3?,
    :how_much_sucrose_4?
  )
  # routing logic
end
```


(same for `countPersonas`)


btw. my assumption was that the only p2 site we would give out to GA users are the main updatesite (not any of the internal ones)

i.e. http://download.jboss.org/jbosstools/mars/stable/updates which is how Eclipse Mars release trains work.

anyone who want a simpler/prettier/easier install setup uses the installer, marketplace or central.


should be `dev-libs/openssl:0=`


I would appreciate a more humble tone of commit messages. To err is human.

In the time he was adding the patch there were some dump directories in the `$XDG_USER_CACHE` directory but the dump directory stealing had been already gone. So the message was quite misleading.

Shortening of `paths` to `pths` looks pretty useless but it is not a bug, so you cannot "fix" it.


Should probably be ``require``


does this mean we don't need `dev-libs/apr:1` and `dev-libs/openssl` during build-time? In that case it is a bit odd that we have a subslot operator on openssl, which indicates that the package needs a rebuild if openssl subslot changes


to make things more clear we could introduce a category "* Integration Stack" that will be at the top that has the 3 or 4 top level feature groupings we use elsewhere.


Please open a Pull Request so we can review and merge the suggestion


```
if (typeof ip === 'string') {
```


@ThomS8312 nope, same can be done with lavfi's pan.


This commit changed every line in the file because the numeric fields are now quoted, where previously only character fields were.

On top of that Richard Love, who died on the 10th of October, was named, and details were added for five men who died on the 10th and 11th of October.


Shouldn't version in .toml also be changed?


see last comment?  perhaps it would even be useful to have a function that takes a table name and a number of expected rows in that table and returns a `Spec`?


I missed that one.


Sure, just name the parameters you would like to modify.  QQuickFlickable particularly is full of magic number definitions that could possibly benefit from parameterization.


I am thinking of calling "Destroy" when player quits for completeness sake so I might leave it there for now.


Typo.


As you mentioned when you chatted to me about this, the permitted next nodes in this flow look very verbose, but I think this is just a reflection of the way the flow currently works.

I'm not sure we could do it with the current state of the app, but I think a better way to implement this flow would be to have a sequence of questions in a pre-determined order each of which can be *skipped* if the user didn't check the relevant box early in the flow.

In any case, I think this is an orthogonal concern and shouldn't hold up this PR.


@levackt Some minor fixes. The `GpsdEndpoint` should start/stop `gpsd4javaEndpoint`. There is no need to double-close it from consumer. Actually this might interrupt the work of the consumer A, if you stop consumer B, while consumer A is still running.


iptable


Next time, please remember to also add the dependency to setup.cfg, so that rpm/yum will know about it. The dependency here only works for pip.


イランコメントがある。


@SteveMarshall :+1:


ほほ


Right, I see your point.
However, in case where representing a value correctly is impossible (as you've said, 3/2 in integers), is
using a UF is better that returning an incorrect value (e.g. 1) or crashing, as no value could be correct?


This is totally ok, but I have to point out an equivalent idiom:

```haskell
import Data.Function (on)
compare = compare `on` _contextId
```


@igbasov, remove HANDS UP, and the warning message


Hi, according to http://php.net/manual/en/function.iterator-count.php it is not guaranteed, that current position of iterator is retained. This could lead to some issues (eg. if called in foreach cycle, not every element can be actually iterated). Can you use "count" function instead?
Also applies to other occurences of "iterator_count".


And also what is the input and output format for this request. Is it JSON?


This function was introduced in PHP 5.3 ... I like `extension_loaded()` as a safer altenative to `function_exists()`, but we also need a version check now.


消します。


Are you sure?
To have a similar effect you need to invert the left channel and sum it to the right one so that the common part (the central voice) is nullified.
Maybe stereowiden or stereotools could do the trick.


I'm not familiar with the OpenSSL SLOTs. Can you explain to me why?


Honestly: I don't know. :(


Have been struggling with this one today. Thanks for the fix! :-)


Issue #7


This files need update. Missing the following strings:

"Don't display warning &tooltips"
"&Clear activity log"
"Activity log will be cleared. Are you sure you want to proceed?"


@isaquesb


Good point. I have now done this in master and 4.3.


missind `|| die`


the component register function is the only place in adapt where templates do not need to be explicitly declared and it's really bad for clarity. all other plugins define their templates, realistically, the components should too. giving more power to the registry function is not really the direction we should be heading in, although it does indeed solve a temporary issue.


`echo` can fail too, due to non-existing directories or permission problems, so `|| die` here is safer


Don't use the word "complete" unless your work is perfect.


**[phpUnit_trunkIntegration run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkIntegration/8512/testReport/) for this commit**


don't want to reroll nitpicking, but was there a reason to use `rm -rf ...` instead of `rm -r ... || die`?


Please do follow the consistent coding style!


Ah, I forgot.


thanks!


Entornos virtuales node.js


The message on line 998 is not enough?
https://github.com/abrt/abrt/blob/master/src/hooks/abrt-hook-ccpp.c#L998


Boom!


I've been giving this some thought and I'm certain this is solvable, either easily, or with a custom build script that can be used just for releases. VB6 uses the same LINK.exe linker as VC6, which supports the `/DELAYLOAD` switch. I have no means to test right now, but surely one could get a TLB that contains Vista+ APIs to run on XP just by providing the `DELAYLOAD` switch in the VBP linker options:

```
[VBCompiler]
LinkSwitches="/LARGEADDRESSAWARE /DELAYLOAD:User32.dll"
```

Failing that, I've seen other tricks such as creating a fake LINK.exe that passes on the extra command line switches you want: http://www.jsware.net/jsware/vbcode.php5#vdll


Apologies - I created ppp-ipv6 in the wrong location. A pull request to correct this is in pfsense/pfsense#1963.


Yep, all these small improvements will make it more enjoyable to use space :wink:


hum? The comment indicates you want empty keywords, but they are not empty


Have to fix this line. Reminding myself to use get_object_or_404 here!


I see. Exceptions in ApiControllers should be logged and they should cause the transaction to be rolled back (these shouldn't go through this method and be suppressed). So that looks like a bug. BTW this was an issue with earlier version of Orchard (can't remember exactly) but was fixed at least in 1.9.


comment on a commit


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 634](https://teamcity.mesosphere.io/viewLog.html?buildId=57874&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:07:33


:ok: :1234:


Yes, i need to fix one more thing. I am busy at work and will try to push
it today
On Tue, Oct 13, 2015 at 2:06 AM Rahul Gupta <notifications@github.com>
wrote:

> Hey Ben,
>
> Any update please... :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ben0910/ngImgCrop/commit/2d5952d5e34c4c1831407b4c0847fab365ba2b4f#commitcomment-13732313>
> .
>
--
Ben Rubin
215.776.2706


My first ever committed code on GitHub :)


if would not be needed: https://ffmpeg.org/doxygen/2.8/libavformat_2utils_8c_source.html#l03721


I think ActiveOptions should be made protected.


Tomato Changed From Cornflower


No need to change this, btw. It is fine from my ffmpeg point of view and @notspiff knows what he is doing anyways.


i would prefer line 83 to go missing entirely.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 635](https://teamcity.mesosphere.io/viewLog.html?buildId=57875&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:07:41


How about to make the message more informative. What if there is no other previous message than this one?


yo dawg. i heard you like defensive coding so i put some defensive coding
on top of your defensive coding.

On Tue, Oct 13, 2015 at 1:19 PM, Peter Frühberger <notifications@github.com>
wrote:

> No need to change this, btw. It is fine from my ffmpeg point of view and
> @notspiff <https://github.com/notspiff> knows what he is doing anyways.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/notspiff/xbmc/commit/2e122bd4df8e00614f3ba1b86a9c69630990567c#commitcomment-13737568>
> .
>


Anyway, add some details to the message please (the signal  would be nice).


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 636](https://teamcity.mesosphere.io/viewLog.html?buildId=57876&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:05


Great idea :+1:


The message doesn't seem to reflect what is printed. You print `Bind read-only user %s` and instead print the user's password. Are you sure you wanted to output the LDAP password?


i would suggest moving the asserts right after each write/read/unlink


Nice!

Did you see my comment about `noCache` below? Just to ensure that it wasn't missed accidentally...


Would this not be better named @date?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 637](https://teamcity.mesosphere.io/viewLog.html?buildId=57878&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:10


Am done.


no, this indeed binds a read-only user with password from the file. printing the password is a mistake though, user name should be printed instead.


here you're doing wrong, you should not remove lglock.o , that why you got error in building process


@geogeo-gr You're right, thanks for reminding me.
I've pushed an update.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 639](https://teamcity.mesosphere.io/viewLog.html?buildId=57880&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:03:58


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 638](https://teamcity.mesosphere.io/viewLog.html?buildId=57879&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:07:01


yeah, or `fakeDates` - will stick to that in the future


To err is human to not give a care about TODO's, FIXME's and poor code is ignorance.

I would appreciate if PR's are not merged in the instant they are created so there's no more poor code getting into this repository ^^


Wow! You really made a simulator out of it, good. One thing, the two if's are too similar IMHO, maybe you could use a function here?


Looks good except for banner doesn't work on large screen, can not see any heads.... :( Cut it in half horizontally and use the bottom bit!


By default, geofence is hosted on localhost:8280, see https://github.com/georchestra/template/blob/15.06/build_support/GenerateConfig.groovy#L67


Here you set the pc +1.
Why?


it looks like there's now the possibility of setting a blank phone number - we shouldn't set `web_user.phone_numbers` if the `phone_number` is blank


desp is the description/self information put by user while logging in.
sec_qun & sec_ans are the fields used for renewing the password if user has forgotten the pwd.
rating is something which seeker will give to a user depending upon how the connect happened. I do not see anyother place where the user rating should go. Can u suggest somewhere else?


My bad, sorry about that.


Nice catch!  #125


It seems to me that the problem is using / as a working directory by default.


After testing more properly, it turns out that `reset_queue_entry` led to the segfaults. #1795 is attempting to fix that. While it has the `reset_queue_entry` removed from `wait`, it has actually been tested to work with it.


Thanks! :bow:


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 640](https://teamcity.mesosphere.io/viewLog.html?buildId=57883&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:00


OK, that's a point. But then it should probably read more like this:
```
$.each(this.buttons['compose-encrypted'] || [], function(i, btn) { $('#' + btn.id).show(); });
```
Consider that `this.buttons['compose-encrypted']` does not exist at all and thus access to `[0].id` may fail in the first place.


Fast!

I'd change all duckduckgo calls to https://httpbin.org... I believe it's better for testing purposes.


Ok, I missed this information in the comment. Nevertheless since this piece of code would be copied into Presto codebase, I would apply all necessary changes to make it as readable as possible. Maybe I'm missing something, but after brief grepping through cassandra code base, code of the LimitedLocalNodeFirstLocalBalancingPolicy seems inconsistent with naming  conventions used in rest of the cassandra, so copying it "as is" doesn't give us anything.


Функция is_AcosFpBcosGpC должна давать ответ на вопрос "имеет ли приложение вид A*cos(F) + B*cos(G) + C" вне зависимости от дальнейшего использования, а не -2*A*cos(F/2) + A*cos(F) + C.


ahh I'm sorry, I thought I tested that! I just pushed a patch that should fix the issue and also addresses #998. do you want to give it a try?


Well, I do suggest that you configure this sort of listeners in the code. At least personally I think that way is clearer. I spent like 10 mins just to figure out where you registered the event listener in code. at least I believe xml is for more setting layout


So, if I understand well, any non empty value of the environment variable, including "False" will have the check be skipped.

Maybe we should mention this in the documentation ? There's no goot place for such runtime behaviour, I think, so by default, I'd say at the end of http://docs.anybox.fr/anybox.recipe.odoo/current/scripts.html#startup-scripts so that at least a search on check_postgres would return something.


Hi Pavel,

sorry, im not able to agree with the OCA.
Would you please pick up here.

JdkClientContainer does not handle IOException by passing it to ProxySelector.connectFailed(...). May be thats worth a new issue.

Regards,
Holger

Holger Balow-Schott

T-Systems Multimedia Solutions GmbH
Digital Business / Mobile Enterprise Solutions
Expert Software Architect
Address: Winterfeldtstraße 21, 10781 Berlin, Germany
+49 30 275833-8438 (Phone)
+49 30 275833-8838 (Fax)
+49 175 2960700 (Mobile)
E-mail: holger.balow-schott@t-systems.com <mailto:holger.balow-schott@t-systems.com>
Internet: http://www.t-systems-mms.com <http://www.t-systems-mms.com/>

You can find the compulsory statement on: www.t-systems-mms.com/en/compulsory-statement <http://www.t-systems-mms.com/en/compulsory-statement>
> Am 13.10.2015 um 12:36 schrieb Pavel Bucek <notifications@github.com>:
>
> Hi Holger,
>
> thanks for your contribution!
>
> Have You signed the OCA? (http://www.oracle.com/technetwork/community/oca-486395.html <http://www.oracle.com/technetwork/community/oca-486395.html>)
>
> If not and you are willing to do that, can you please add the testcase? + ideally include the same fix in JDK client connector. If you cannot (or don't want) sign the OCA, please let me know and I'll take over and fix this properly.
>
> Regards,
> Pavel
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/hschott/tyrus/commit/6583c1897c5825292195f78e3bd0846194071a38#commitcomment-13736845>.
>


-m Add


Should we provide instructions how to find out the version of Scala plugin here?
It seems like most people don't know how to do it and it would be useful


Thank you very much for your contribution. Yes, just using Github and yml is less than ideal for determining changes. We'll let you know if we're able to make changes to our process here. I'm deploying these changes now.


This was intended to be a pull request to my own fork..

![config1](https://cloud.githubusercontent.com/assets/12012101/10453863/982873fe-71fb-11e5-806b-5f569451c6ae.png)

![capture2](https://cloud.githubusercontent.com/assets/12012101/10453865/9b74c832-71fb-11e5-9be8-5fd2b254f2fc.PNG)

![capture3](https://cloud.githubusercontent.com/assets/12012101/10453866/9dcd334e-71fb-11e5-8f5a-25cb47559874.PNG)


Yes. Shall I commit that change?


Wir haben 16 registers, oder?
+ pc
+ memory :) Wissen wir wie groß unser memory ist?
Für unseren Entry, brauchen wir sicher mehr als nur 16 Byte.


Just an idea, you may want to put it near the top to get max attention. :)


I've had a go at implementing option 1 in 9f5bff4dd2707426b95f1eb2b6afa281fc6fc287 and 3b494c330539acb6c7e66c9f03b23a30a5ae68ce. I can't quite get my head around how option 2 would work. In particular, I'm not sure it would allow us to visualise the flow because the block passed to `next_node` is only evaluated when we're trying to work out which node to go to next. Am I missing something?


Ooh, better leave this one with me. It might take some time.


how about internet has enough spam already ??
in the jlynx page where it's explained how to install etc. let ppl donate from that page..

if someone thinks you must have their money for the bot they'll sure find that link helpful..

otherwise keep the code as light as possible , as clutter free as possible etc etc . . .

my for cents . .


Yep, good point. I'll add this info later.


- your function still return the empty string `""`. `""` is not the same as `null`. It better returns `null` or throw an exception because `if("")` is truthy. I'm ok with either null or exceptions :)

- `Check if a specific program available in PATH` => Check if a specific program is available in PATH`

- `version(posix)` => `else version(Posix)`

and with
```
else
{
    static assert(0, "unsupported system");
}
```
Example code must be exemplary :)

- you are still mixing several indentation style, don't mix tabs and spaces, and use 4-spaces indentation throughout.


> Why is this necessary? If you don't want v1beta3 to be a selected target of the mapping, it needs to be removed from the list of potential mapping options.

I think this fulfills exactly that intent, right?  The previous code would
 1.  decode a `v1beta3` object using a `v1beta3` mapping (fine)
 1. encode the `internal` type using the same mapping it decoded with (**fail**)

The new code says, "decode with whatever you can", but turns around and says, "encode with whatever you're going to use to talk to the server".

We want to be able to decode everything we possible can, but we always want to encode with what the server accepts.


Use the `apt` module?


It occurs to me that we should probably also namespace the directories based on the Rails environment. We don't want to run RSpec and have the tests interacting with cache files from the development env.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22128/testReport/) for this commit**


Hmm seems like we should look at abstracting this since it's just enabling sinon to override Dates, then removing the override after. Is this applicable for all tests?


I am on Orchard 1.9.1. I still have this problem.
Also I could not locate ExceptionFilter for Web Api rolling back the transaction.


Both filters do the same. `first-party` is just an extension to the syntax [I added](https://github.com/gorhill/uBlock/commit/48f47a6849729beb73f1bd62d19d1b28f562356d#diff-522a16ddeed280252d7c3a351261b441R1364): this does not add any complexity to the parser, and it's easier to read IMO.


What should this function do?
Here you set 2 local variables , than exit with a void.


There are some problems when you have more buttons.
Follow the steps:

1. You have 2 button.
2. Click the first.
3. Click the other.(Do not click anywhere else during this time);

Now,there are 2 buttons showing the drop down list.
`e.stopPropagation()` will make the event not invoking the `pageClick` to close other lists.


@pynicolas fixed


This is the standard api of sinon to fake timers -> this is the only way to test equality of events which include timestamps. Because otherwise the timestamps / dates are not the same and the expectation fails.

Our new BDD api for aggregates already abstracts this for us. But here it's a bit closer to the metal.
I am thinking about removing the distributed messaging api in this package anyway.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22129/testReport/) for this commit**


I set it `true` cause of prohibit to change it for user — there's no sence for server-side caching in grunt plugin


Nice, but one thing is missing. It is not possible to install wxWidgets DLL from a common source (Windows), because all files are searched in the buildwin subfolder. I used
```
FILE(GLOB wxdll_files "${WX_LIB_DIR}/*.dll")
```
to install the files from the library location detected by find(wxWidgets).


93653630-MultipleYearRunPeriodForTabularReports (JasonGlazer) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-76.3%25-red.svg)


I kept it / because of two things:
1. it is safest (umount won't work in case garbd will run from mounted fs)
2. don't want to break current installations

Maybe best would be to create it's own user (garb) with some default home directory (/var/lib/garb) and run daemon as this user with chdir to it's home dir.


This commit seems to break a transcluded directive on my own code.


@dcs619 , how come you add the "no campus text" option to the dropdown?

![image](https://cloud.githubusercontent.com/assets/548180/10454046/91d1a4ca-7166-11e5-883e-b1ff1f33d940.png)


Yes. And we could probably move this to the skin anyway using a handler for 'enable-command' event.


@flavour This gives me Record not found! error. What am I missing here?


これはupload_image.rbに書くべきでは？
typeカラムはprototypesテーブルが持つものではないですよね？


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 641](https://teamcity.mesosphere.io/viewLog.html?buildId=57894&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:03:41


Do we actually need to leave this here in Unit? I don't think we do?


(Or is there some stupid native code somewhere that keeps calling this on non-mobile units even though there's no point?)


@dg THX.


Consequences of this: if `Car` inherits from `Vehicle` and adds some more event sourced attributes, `Vehicle` also has those extra event sourced attributes


aaa


Yea, thank you for the reminder! I've realized that we forgot to remove the comment the last night while I was half-sleeping :D
Fixed in https://github.com/abrt/libreport/commit/e93bf5b280d05b8926f0a3fede75e822c51cdea4


Should treads be in MobileUnit? Isn't there a more specific subclass for units with treads?

Aircraft are MobileUnits. They probably don't need treads. Maybe we can introduce a RollingUnit class (For units that roll along the ground) that extends MobileUnit (That might shift even more crap out of MobileUnit, which is itself pretty large)


I was playing around with the new (0.2) relations too, but confused on how to *dynamically* fetch the relation builder inside the serializer. All serializer interface methods receives the `model` except for the `getRelationshipBuilder` method. Could you enlighten us a bit more please?


Isn't this called for buildings, exactly once, when you place them?

I guess you tested these changes, anyway: that'd be a pretty obvious failure.


@mstembera: ok. i will wait before running the 15 thread test.

@zamar @glinscott: can you have a look at https://github.com/official-stockfish/Stockfish/pull/458 ?


There's stuff in here talking about "Water" and "Sea". It's in a class for "All moving units"

Sounds like we can possibly split this (admittedly huge and awful) function into smaller functions spread across various classes (possibly with calls up to the superclass for common logic).


he removed it from the bot it is now only in the readme


This if, for example, sounds like it really wants to be in the SeaUnit-specific version of this function. We don't need aircraft to check if they're on the sea every time they change direction...


@nilnor Well, it seemed to have to do with clicking right as I pressed a key. :O


You might wanna add semicolon here.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 642](https://teamcity.mesosphere.io/viewLog.html?buildId=57896&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:07:20


Footfall? Isn't that specific to WalkingLandUnit?

Sounds like more splitting might be possible, then.


Contrails? That sounds AirUnit-ey. Maybe we can split this out into an AirUnit-specific override of this function.


Something something blueprint compiler.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 643](https://teamcity.mesosphere.io/viewLog.html?buildId=57897&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:03:58


Ahhh. Sorry Aparajit. Some nasty merge conflicts. I missed this one.


While you're at it, affected recipes were also:
app-misc/googlemaps_mini/googlemaps_mini-0.1.recipe
app-misc/jq/jq-1.4.recipe
dev-lang/openjdk/openjdk-1.7.u80_b32.recipe
dev-libs/isl/isl-0.13.recipe
dev-libs/libclaw/libclaw-1.7.4.recipe
dev-libs/nss/nss-3.18.recipe
dev-libs/protobuf/protobuf-2.4.1.recipe
dev-vcs/bzr/bzr-2.6.0.recipe
games-arcade/plee_the_bear/plee_the_bear-0.7.0.recipe
games-emulation/bsnes_libretro/bsnes_libretro-git.recipe


That is good!


What is the purpose of the description? Why not use the 'abstract' property? In my opinion, it would make sense to offer short descriptions for files to clarify their differences. I do not see why the handling of documents needs to be changed.


This class does not follow the vert.x interface, impl style which means that you can only use it from Java (no bindings for other languages will be generated)


Typo in compress_test line 12


Is it? I'll double check.


In general, this is a bit of an antipattern: I'd suggest we stick with calling the empty function instead of branching, unless we can show an interesting performance difference.


Function `smallest_character_recursive` is local and should be marked as "static".


93653630-MultipleYearRunPeriodForTabularReports (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-76.27%25-red.svg)


The `else` can be eliminated.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 644](https://teamcity.mesosphere.io/viewLog.html?buildId=57915&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:06:25


Instead of ConfigContants I'd suggest to use a Options object like we have for redis itself so all parsing would be done there and again conversions from Json from/to Options would be generated for other languages


doesn't csso outdated ?


null: falseは消して置いたほうがいいです。


App showcase image for PopVox


Hrm. That's unfortunate. Maybe the plugin could set that environment variable via a configuration then?


If you do a static import to `RedisCommandUtils.toPayload` then there is no need to change anything else in this class


Is this overly broad?


@rob-c `isType` is not standard python 2.7
```python
>>> isType
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
NameError: name 'isType' is not defined
```


We are already working on a all in one lib Doge


createアクションが空っぽです


This needs to moved into foreach.


You don't rely need the explicit return


The unknown host exception can be caused by several things. Might be better to switch out the excepion from e in stead of creating a new catch case


This changes the order of operations, with this removed `l` will be unlocked **after** `unlock` is relocked.


By the way, function `smallest_character_recursive` is tediously long. Fix it.


Add two Plugin's parameters: remote dictionary url and loading timeout. Both of this parameters are using in loading remote dictionary - loadURLDictionary method (also added).


Why `constant_time_size`? The size does not appear to be used anywhere


Yep got that, was just considering the abstraction. My thought was that there are multiple times in the libraries where we are doing the same setup in tests, for an event, command, and buses etc, so we could just define a test app in space:testing and call it here and all the other places


Will `publication_type` ever be nil? Presence of `publication_type_id` is validated above.


You need

```R
compact <- function(x) {
  is_null <- vapply(x, is.null, logical(1))
  x[!is_null]
}
```

I have that as a helper in lots of my packages


Probably not needed once a Options object is in place


This looks like doing the same the transformation does on redis replies, could we use that instead?


Is it not clear in the 0.2 docs? Relation methods return a builder instance, and then the model is passed into a method on that builder instance.


93653630-MultipleYearRunPeriodForTabularReports (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Can we get a minor version number bump for this in package.json? npm won't pull the fix until this happens.


Maybe we should move this to some impl package since it should not be public API


With this gone, how are waking timed-wait threads prevented from touching a gone queue?


For some reason this test is failing for me...


And these:
games-emulation/retroarch/retroarch-1.0.0.3_beta.recipe
haiku-apps/beshare/beshare-2.31.recipe
haiku-apps/friss/friss-0.8.0.recipe
www-client/qupzilla/qupzilla-1.8.6.recipe


8/8 would read again - IGN


Bummer. I try to fix it.


It is missing all the codegen annotations, here is should have: @VertxGen


Method has too many lines. [15/10]


Use a guard clause instead of wrapping the code inside a conditional expression.


Align the parameters of a method call if they span more than one line.


Assignment Branch Condition size for build_from_data_guru is too high. [15.75/15]<br>Method has too many lines. [16/10]


Use `described_class` instead of `TogglIntegration::Team`


Method has too many lines. [14/10]


all method that return self should be annotated with: @Fluent


Shadowing outer local variable - `user`.


Don't extend an instance initialized by `Struct.new`.


Looks as if there was a lot of trailing whitespace in the file. Let me know if you'd like a separate PR for that.


Well done.


was there any problems concerning the version?


:trollface:


entête


This also will lead do deadlocks as the sequence of re-locking is different from the normal sequence of locking.


Ahh, gotcha, makes sense. Will revert this, thanks for the clarification.


@pynicolas Why not verify message?


@mhartington and @penfold - can you create an issue and describe exactly how the application is set up and what actions cause this flickering?


`size` is used in `hpx::lcos::local::barrier` here: https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/lcos/local/barrier.hpp#L42


@bentglasstube why did you remove this?


What's the necessity of calling strip before replace?


Thanks !!


@kferris10 I propose that when `s_info.levels` is not set by the compiler, we do not render a selectize widget. Does that convention make sense to you @kferris10? For this PR I didn't need any help writing the code, but please take a look at my changes and tell me if you find any places where you think the code could be clarified via comments.


thought it was merged already


is this the latest fix which Harri is referring to?


westcripp - Altan

Bu satırı eklememize rağmen son güncellemede hala ingilizce olarak görünüyor. values klasöründe bulunan ilgili rr_string.xml dosyasında bu satır mevcut değil. Sebebi bu olabilir mi bilmiyorum.

<!-- [CHAR LIMIT=40] Title of dialog that is shown when performing a system upgrade. -->
 <string name="resurrection_upgrading_title">Resurrection Güncelleniyor\u2026</string>


Good :)


Тут стоит проверить, что выделение памяти прошло успешно.


@vilchik-elena because it's verified by the other test method.


We don't. The point is that once `notify_all` is called, the entry is removed from the queue anyways, so there is no point in updating it.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 645](https://teamcity.mesosphere.io/viewLog.html?buildId=57919&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:02


Что это с отступами?


I would simplify like this.

` * Fixed a bug affecting RealmConfiguration.equals().`


黑得一手好 H5


You have an extra `>` here it seems.


Is this necessary? I usually just add the PersonName to my model and reference that directly:
<c:out value="${personName}" />
The ToString() function for PersonName handles all the names (including titles, initials, etc.) automatically.


@pynicolas anyway I would add message here (it differs in threshold value).


I would consider this a bug that should be reported to and fixed by AWS, yii should not allow such responses.


Is there anywhere I can download the completed 2.9v12 taxonomy.tsv file, to test it out?

Yan


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 646](https://teamcity.mesosphere.io/viewLog.html?buildId=57920&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:10


No but npm shows on every install ``npm WARN EPEERINVALID reflux-state-mixin@0.4.4 requires a peer of reflux@^0.2.5 but none was installed.``
This commit would prevent this warning.


good ;-)


@mislav We don't like to tell people to modify system files like this as it's too easy for users to make mistakes and accidentally hose their systems. If you know enough to make these changes then you don't need Homebrew to tell you what to do.


Rework commit log as:

<pre>
llvm: Update to 3.5 version

The ARM JIT for OpenJDK 8 requires the 3.5 version of llvm or later so
this updates the recipe to allow for its use together with meta-java layer.

Signed-off-by:...
</pre>


Same here, rework commit log.


Проверка на веделение памяти отсутствует.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 647](https://teamcity.mesosphere.io/viewLog.html?buildId=57925&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:09


Let me discuss with my team.

Thanks for the patch.


Пофиксишь замечание и принято.


@vilchik-elena LGTM!


@Marthyn capistrano has a nice way of handling default values for `fetch`: `fetch(:nginx_local_ip, "127.0.0.1")`. Makes the code a bit less verbose :shipit:


@pynicolas is it good method (`without_nested_functions `) for this test?


Эта задача еще не поправлена. Замечания сверху.


I think, the name readProperties/loadProperties would be more relevant, because it would imply that you read the properties from somewhere and not just get it from an instance variable.


Принято


Are these two additions unintentional?


lgtm


I am just wondering whether a generalisation is worthwhile: I have a situation where I have written almost exactly this, but with type `(site -> Text) -> Approot site`, making it fall back in effect to ApprootMaster.  Or would the extra parameter be too obtrusive in other use cases?


ok


not ok


@pynicolas IMHO not the best name (is class declaration in this list or not?). Why not keep list of just 3 elements?


Needs to also export a [schema](http://eslint.org/docs/developer-guide/working-with-rules#options-schemas).


That's funny, I'd actually been considering a `guessApprootOr` function with a signature just like that. I think there's room for both. To bikeshed slightly on the signature, what about:

    (site -> request -> Text) -> Approot site

or

    Approot site -> Approot site

so that no generality is lost.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 648](https://teamcity.mesosphere.io/viewLog.html?buildId=57934&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:03:49


@pynicolas We should not forgot to rename all our "New..." classes at the end of migration


Any time you want to read a property you load them from a file (!). I guess you can get rid of this method completely. If you have read the properties by using readProperties then you have the Properties object and can use one directly.


It is at http://files.opentreeoflife.org/ott/ott2.9/ott2.9draft12.tgz
We should update http://files.opentreeoflife.org/ott/ott2.9/ so that this is the download link....


Added, thanks


where ?? :3


@pynicolas What was behaviour before? Also without nested?


@flavour The approved_by field is 0, which comes from here: https://github.com/flavour/eden/commit/1b8ad47896aa49344ca6d196d2617099eb62ec62#diff-490b78a7772eee613a7f16277d7ffe14R5763 but this condition https://github.com/biplovbhandari/eden/commit/a909bbfa68c90c5aea1d7cd410f48935d5d11765#diff-59bf1eeed7c39491fc28b7a977ef8b0cR1763 is true, even if the approved_by is 0, ie. it shows "Publish Alert" button, which is correct? What am I missing here?


and reflux is installed? (what version)


отступ лишний


и тут отступ лишний


@dpshelio What is this? I am confused :(


``0.3.0`` when this warning shows up


Принято, но поправь отступы.


Or course, didn't think of that. Will change it.


These would probably take less code as switch statements


Yes, that would be even better, and actually I like `Approot site -> Approot site`.


Is the `__cplusplus > 201103L` detection in the header really intentional? It doesn't match the checks in other parts of the code. It is also missing in the sample. It breaks on non-Linux non-Windows non-OSX for no good reason that I can see. Why is C++11 not enouogh?


JAAAAAAA Linus
Ich weiss dass das grad mal 2 Ziile code sind ;P


Want to PR that as well? Should be straight-forward.


OK, will do!


Is it supposed to be checking the same thing twice?


@clochix `if err` is checked twice here!


Cool!


saw approval from gordonguthrie
at https://github.com/basho/eleveldb/commit/774850425661071cfd74d9fc41f99dbe18e9bbbc


merging basho/eleveldb/feature/at/consistent_ts_types = 77485042 into borshop-integration-155-feature/at/consistent_ts_types


basho/eleveldb/feature/at/consistent_ts_types = 77485042 merged ok, testing candidate = abdb4529


LGTM


I think defaulting to `end_dt` is sensible.


@clochix with a `return` to avoid calling next twice?


это зачем?


It seems like perhaps the options schema here should be an array of objects, rather than an arbitrary number of objects.


It would be better to have a parameter name just 'fileName'. What is this prefix? Without looking into the code you don't know it, and this .properties extension is not something you have to care about as a class provider, let the client care about it.


Y, thank you.  I copied/pasted from PDFBox, but I'll add the s.


@pjdelport @jyrkialakuijala

What you are telling us, is that from now on, we should be very wary of naming technical things, because in a subset of some other culture it could offend a minor segment of the population.

Realistically, how many women, software engineers or not, would be actually offended by this name? I think it's very very few, if any. And if they do, I would question why can't they see the term is simply the first 3 letters of the product?

If this seriously would offend women, I'd be the first to speak against it, but I think you guys have gone too far here. It does matter, because it's Google, and what you guys do tends to have ripple effects across the industry.

Last thing I want is to get an angry email in the future from someone across the planet claiming insult on something which I wrote in a purely technical nature.

Lastly, I think your character assassination of calling anyone who disagrees with you: a hurt bro, seriously undermines your argument.

Do you really think a random programmer will one day find this project, see the "bro" file extension, and then go on a misogynous diatribe due to it? How many programmers do you think will actually feel identified by the term?

Those of us who are commenting in a moderate, respectful tone, are definitely not "bros". In fact, I actually hate the term in common parlance, you'll never hear me say that word to a friend. What I am here to help avoid, is the precedent that we must consult every single specific group in the planet in case we will inadvertently offend them with a simple header or file name.


Yep just used it again and this works really nice.


Принято


@dcs619  Also, it shouldn't update the querystring unless it needs to (caused problems for us when we have multiple ways of setting context on same page). I pushed a change for this, can you make similar changes to the group and schedule context setters.


Good to know.  That was for one of the two non-Apache licensed image libraries...again, a copy+paste from PDFBox.  I'll figure out which one it is and then see if we can grab it from bintray.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 649](https://teamcity.mesosphere.io/viewLog.html?buildId=57935&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 189 Build time: 00:04:02


ahh, right - `^version` is only for `0.2.x`. thx


In this particular case yes, they are really ease to edit as long as you have access to photoshop.
I just used the Replace Color tool on the default one. Its at Image->Adjustments->Replace Color.


@pynicolas Indeed it's hard to decide which visitor kind is better here: subscription is more compact but visitor is more readable and clear.


Only to i, not to z.


Ugh, those will need to be revised... But ok, this is change is entirely unrelated to the fix then, I was worried switching implementation details was a subtle necessary part of it.


That's pretty clever. I'll use that instead.


The image has been changed and it says October 15th now. That is when the publisher told me the discount code would be valid for.


Убери лишнее определение функции time.


Doesn't it also include the Debug DLLs like this, which we sure don't want to?
Patches for this stuff welcome. And please have a look  at #400, I was not able to merge part of your changes as they break our standard build system and it is not clear to me whether they are needed at all.

Thanks

Pavel


What values can `queue_` take other than the address of the member of the current instance or null?


سلام علیرضا
اگه ایرانی هستی و فارسی بلدی سوال ازت دارم به جی میلم اس بده بتونم سوال ازت بکنم ممنون
meisam.sabouri93@gmail.com


I guess I disagree (respectfully). :)
First - all of the supported install mechanisms work - JBoss Central Discovery, Eclipse p2 update sites, offline zip files (I'll even get the standalone installer to work tomorrow).  Users are instructed to install JBDS first so it's already there when they go to install the IS.  The exposed URLs are released URLs (development) and the IS is clearly marked as a development milestone Alpha2.

https://devstudio.redhat.com/9.0/development/updates/integration-stack/
https://devstudio.redhat.com/9.0/development/updates/integration-stack/earlyaccess

This is the way Luna is set up as well and I think we'll cause confusion to users who naturally use the Eclipse 'Help > Install New Software' mechanism to install Fuse Tooling or Teiid Designer, etc.  Dropping the Eclipse p2 mechanism or obfuscating it by combining it with core should at least be passed by the PMs (in my opinion).


Align the parameters of a method call if they span more than one line.


Method has too many lines. [14/10]


Use a guard clause instead of wrapping the code inside a conditional expression.


Shadowing outer local variable - `user`.


Don't extend an instance initialized by `Struct.new`.


Assignment Branch Condition size for build_from_data_guru is too high. [16.03/15]<br>Method has too many lines. [16/10]


Use `described_class` instead of `TogglIntegration::Team`


Thx.


See: 2a7992b3d8f790562be70f46639ea1ce3e3ebcc6


So, how does this deal with the waking timed-wait vs notify race?


maybe need to add something that tells the end-user when they attempt to access the /tickets-install again it tells them its already been done.. installed correctly.


Why did you change the AMD export? The export was totally fine, the new one doesn't make sense and therefore doesn't work either.


Can you teach me?


93653630-MultipleYearRunPeriodForTabularReports (JasonGlazer) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-76.27%25-red.svg)


I've updated the index page on the web site (by copying the release notes
from this PR to files.opentreeoflife.org/ott/ott2.9/ott2.9.md on the
server, and doing 'make').

On Tue, Oct 13, 2015 at 8:31 AM, Mark T. Holder <notifications@github.com>
wrote:

> It is at http://files.opentreeoflife.org/ott/ott2.9/ott2.9draft12.tgz
> We should update http://files.opentreeoflife.org/ott/ott2.9/ so that this
> is the download link....
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/OpenTreeOfLife/reference-taxonomy/commit/38aadff332ea8eeb6de4a15c018f7d5969ec2c7a#commitcomment-13739082>
> .
>


Thanks for your review.  @chrootsu  I revert the change and moved this catch-all method at the bottom of the other overloads to avoid compile error


Oops, my bad. Forgotten to regenerate the parser.


Please review this, @casey-collab


Need to remove this generated Makefile from src directory. Generated Makefile should also be gitignored.


Поправь замечания сверху


Actually, I'd prefer these to be contained in the enum definitions and to use a for loop:

http://stackoverflow.com/questions/15380243/how-to-retrieve-enum-name-using-the-id


> So, how does this deal with the waking timed-wait vs notify race?

If I am not completely mistaken, it does in the same way as it was done
before.


You've leaved copy of src files in echoclient/, echoserver/ directories.


LGTM


this->queue_ is constant, it always has the address that has been passed to it, e_.queue_ might be null or the address of the current cv's queue_.


RFC 5280 says serialNumber should fit in 20 octets (bytes), not 20 chars, you're limiting randomness in this security feature :)

or maybe it's a typo and should be random_str(20,'hex') instead.


echoclient.pro shouldn't be in src directory. it is build system file. Not code source.


2 maps were already a lot, but 3 definitively makes this call for a refactoring. i.e. something along the lines of `Map<K, ElectionModel>`, where `ElectionModel` (bad name!) would merge the actual `Queue`, the `ElectionState` and the ... `PermitState`?! Though that last one totally confuses me.


Yeah, strictly speaking you're right. I'll post a message on their forum, but I'm far from being sure that they'll react quickly.


This commit should have been split... it's way more than "only" adding a test


Yep, just fixed.
We use gulp-minify-css who use clean-css

https://github.com/Swiip/generator-gulp-angular/pull/659


This commit broke my magit setup to display magit status buffer in a maximized window: `(add-hook 'magit-status-mode-hook 'delete-other-windows)`. Is it intentional? What are other ways to achieve the same functionality?


No reason here, actually =) I'll change it.


I'm doing AQ40 now. The place looks like its been spawned by hand so it will take a little longer.

All NPCs before and first boss were all in wrong location. Of the three NPCs pathing before first boss two were missing. All fixed and gonna fix all to and including second and third bosses tonight.

I will be pushing AQ40 in sections.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22131/testReport/) for this commit**


all tests pass:
success: http://buildbot.bos1/builders/test-eleveldb/builds/476


So this change is not a functional change then, just cosmetics?


Quando programa é aberto na IDE do python, este acusa que esta com erro de endentação. Quando é feita a correção IDE continua acusando que esta com erros na endentação. Por esse motivo foram colocadas estas linhas como comentário, para que possa ser realizado testes nas outras opções.


If submitted a PR to improve the current situation:
  https://github.com/apache/camel/pull/636
@oscerd Can you review&merge that PR?

The upstream issue in OptaPlanner is being tracked here:
  https://issues.jboss.org/browse/PLANNER-468


len 是奇数怎么办


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 650](https://teamcity.mesosphere.io/viewLog.html?buildId=57939&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 189 Build time: 00:02:19
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


@meisamsaboori write english pls


Hm, cyan = (0, 255, 255)  - https://en.wikipedia.org/wiki/Cyan


Before, all queue nodes were signaled before the mutex was first unlocked. That let the timed waits know that they are not even in the queue anymore. That was the entire point of the last PR on cv.

Now it appears queue nodes are flagged as they are processed, which given the mutex unlock is way too late, and will lead to segfaults.


Missing delete ephemeral consumer node from zookeeper?
Just like this:
```python
if self._owns_zookeeper:
    self._zookeeper.stop()
else:
    path = '{path}/{id_}'.format(
        path=self._consumer_id_path,
        id_=self._consumer_id
    )
    self._zookeeper.delete(path)
```


This is very sensitive work, @malmaud.


OK, iako mi ne treba promijenjeni projekt.


8 个空格的缩进？


93653630-MultipleYearRunPeriodForTabularReports (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (822 of 822 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.29%25-green.svg)


Should this be `Symbol.iterator`?
Might look weird when converted using docdown though. (`_.prototype[Symbol.iterator]`?)


Honestly I'm not sure. Right now I am running a vanilla Madsonic server.
I haven't really looked in to it yet but hopefully there is some way to store it there.
If not I have been considering two options, either I modify the server as well or I go the easy way and create a php api with a database.


Set default margin to 0


Add new option


Obično koristimo RGB(0,255,255), čitkije je.


I ne treba više cast na HBRUSH, CreateSolidBrush vraća HBRUSH.


Option 1 looks good to me. Option 2 was only a vague thought - I clearly hadn't thought it through! I don't think you're missing anything. I think I was partly trying to make the call to `next_node` look less ugly, but it looks as if you've done that by using a local variable in 3b494c330539acb6c7e66c9f03b23a30a5ae68ce.


If `fullOverlay` is set, then watermark gets the size of the image, else it's own width/height is used.


You can do this instead:
```bash
&& mkdir -p /usr/local/go \
&& curl -SL "#{BINARY_URL}" | tar xz -C /usr/local/go --strip-components=1
```


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 651](https://teamcity.mesosphere.io/viewLog.html?buildId=57940&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 189 Build time: 00:02:20
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


测试结果，之前的ip并不完全覆盖新扫描的ip

在 2015年10月13日 下午12:34，Net XX <xxnet.dev@gmail.com>写道：

> good idea，我也正在思考这个问题
>
> 在 2015年10月13日 下午12:27，Cat73 <notifications@github.com>写道：
>
>> 对比下，说不定你这次扫到的IP在原有列表里都有呢？
>> 毕竟这次更新是过滤了一部分“坏”的IP，理应结果比以前更少才对。
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/XX-net/XX-Net/commit/ce11ece64457477dfa0d336713bade4d50487fc1#commitcomment-13731335>
>> .
>>
>
>


Sorry, I've just uploaded


Possibility to use `data` object to set the watermark image, in case of multiple images/watermarks


I verified that build is not broken and indeed I found missing definition.
I fixed it and now it is bisectable again.
I know you asked to use BROKEN but to me it seem to work at this point.
Let me know if I miss anything?

Will push it today to github


Brace on same line.


check:
- your working dir
- sonarQube resource (parent pom probably won't work)
- if sonar intellij inspections are turned on in you inspections profile
- test if hello world project works


Closes #27


`people` 干嘛用的，只出现了一次，还没 `var`


Possibility to use data object to set the watermark image, in case of multiple images/watermarks.


Alright, the point of `PermitState`is to have a "next in queue" elected Node to obtain exclusion.
Now that's interesting, cause currently you can only obtain exclusive access once. We may want to change this contract entirely, wdyt? Like:
```java
Coordinator {
  Permit exclusiveAccessIfLead(); // runs election if no leader
  void delist(); // remove from the leader queue (possibly head)
  boolean isLeader(); // tells if we're the leader
}
```

Am I missing something?


Looks good


typo in commit title - it's pep8 !


OK for me


Maybe assert that the size si not > 2G ?


Why D:


FWIW: I can tell you right now that this is incorrect - you need to remove the trailing "openmpi" after pkgincludedir as pkgincludedir includes that directory level.


I do.  For FSGroup we decided to give the first value in the range (just like UIDs).  That is probably also valid for supplemental groups as well.  Since I was waiting on the rebase of the branch I put a todo, I can fill it in now


error in download :
address page :https://github.com/telegramdesktop/tdesktop/blob/master/MSVC.md

OpenSSL 1.0.1h
https://www.openssl.org/related/binaries.html > OpenSSL for Windows > Download Win32 OpenSSL v1.0.1h (16 Mb)

this load site is error


Project1 Report 1st Version


fyi, I use README.rst so that it can be pulled into the PyPi description. My personal preference would be markdown too.


没`alt` 就算了，标签要关闭 `<img class="m-blog-pic" src=""/>`


Check ilovesona issue #10


Hello @posita

please check https://github.com/web2solutions/Veritaseum-proof-of-concept/commit/2ced9771040ab3a3f3270ab4e6d5443ae545eae8


没 `alt` 就算了，标签要关闭 `<img class="m-blog-pic" src=""/>`


Currently working on gettingspellname  and then do speedy


@meisamsaboori thanks!


assert on error ? or throw ? I do not know if it is better. I guess the plugin are using it. Thus if a exception is thrown, it should be catch in the plugin builder.


I think we should only keep a (much shorter) list of excluded capabilities (xapi-debug, blobs, vncterm) then, when we calculate the final list, we'll use Except instead of Intersect.


fast-forwarding end-to-end/timeseries to borshop-integration-155-feature/at/consistent_ts_types = abdb4529


https://www.openssl.org/related/binaries.html > OpenSSL for Windows > Download Win32 OpenSSL v1.0.1h (16 Mb)

This site was error How do I download the file


I agree, there is definitely no sense to keep it in task... my fault that I've rushed over Nunjucks options and missed that particularly this one server-side only.

But I'm trying to get why it was set explicitly to `true`, while default Nunjucks' is `false`? Didn't they mean that for non server-side should be used default value (`false`)?


I'm not generally very trusting of superglobals. Can they be manipulated? And it's a bit indirect because we don't really want to know if we're on Windows – we want to know if /dev/random is a unix device.

For now, until I come up with something better, I'm inclined to

```php
        if (@file_exists(RANDOM) && !is_file(RANDOM) && fileinode(RANDOM) !== 0) {
```

- @ silences a PHP warning or notice some people experience when filesystem read is disallowed
- if /dev/random is a device then it is not a regular file
- if /dev/random is a fraud or mistake in windows, it will be a regular file
- PHP manual says the inode number on Windows is always zero


清除浮动建议不要追加无意义的标签，给父元素加
```css
.clearfloat:after{
    visibility: hidden;
    display: block;
    clear: both;
    content: "";
    height: 0;
}
.clearfloat{
    zoom: 1;
}
```


This commit is being reviewed as a part of review issue #87.


FYI, the reason I use README.rst is so that the readme is pulled into the [PyPi page](https://pypi.python.org/pypi/python-hessian/1.0.1). My personal preference would be markdown as well.


This commit is being reviewed as a part of review issue #88.