I wouldn't recommend using PrecacheUnitByNameAsync, I've encountered a bug where sometimes models precached by this method will crash when rendered.


fixes #7


んー。
基本的に誰が見ても一目瞭然な名前のほうがいいので...
僕がprotoとphotoを見間違えて混乱した=ややこしい名前　と認定して、prototypesテーブルにしましょう！w


@deotern How's @Artide a lead developer? o.O


yes I want to say “the best man”!!!   I am sorry sorry..my English is very poor!!!!


画像のアップロードにはcarrierwaveを使用するので、今のうちから予習をお願いします！
今は特に何も変えなくて大丈夫です。


just checking will [clone](https://facebook.github.io/react/docs/top-level-api.html#react.cloneelement) help here


I don't like the duplication between the two files. I bet there are a fair number of users who will explore our documentation a bit, especially when we link to it for how to use the client. I think the duplication on adjacent pages of the docs looks bad. In my opinion, this section should either just have the important notes (e.g. "For squeeze you will need to...") or be solely on `contributing.rst`.


还


You have to use PrecacheUnitByNameAsync at some point unless you want your gamemode to load for an eternity


This seems a bit better.


@TahaTheHacker That is *sooooo* not true! :stuck_out_tongue_closed_eyes:


Perhaps all references to `letsencrypt` should be updated to `letsencrypt-auto`? Not sure what we want to do here.


今更ですが、 bitmap かつ、 supported or not を示すフィールドは、
例えば、Get group features stats は、
[“SELECT_WEIGHT”,”SELECT_LIVENESS”,”CHAINING”]
のように、文字列にデコードしてます。
面倒ですよね...


I see. It is *supposed* to be like a text editor where 1 newline ends the current line so 2 is what ought to work here for adding a space between chunks… and that does seem to work for regular text as expected. I wonder if its just the case where we mix markup with standard text. Then again maybe this is some rare situation where the line naturally wraps and the the new line is applied… I can look at the code later and see, but I thought that I had accounted for that case.

> On Oct 14, 2015, at 15:49, Jaka Kranjc <notifications@github.com> wrote:
>
> On Wednesday 14 of October 2015 13:50:43 Brad Allred wrote:
> > I dont have the code in front of me to check, but I thought it would parse
> > anything in front of the tag normally (meaning the status icon drop caps
> > are a potential issue), so i'm having trouble seeing what this empty `[p]`
> > tag is doing. wouldn't a newline suffice?
> That's what I tried initially, but we still handle newlines poorly. One
> changes nothing, two add two. Adding a paragraphed space gave the needed one
> newline.
>
> > you also removed the comment about why things are wrapped in markup.
> That workaround doesn't appear to be needed anymore, that's why. Before only
> the starting item got it, but now we're calling the function several times,
> which isn't compatible with that anymore.
> —
> Reply to this email directly or view it on GitHub <https://github.com/gemrb/gemrb/commit/439887c7a0655c5b10f064411b7e06758d45cede#commitcomment-13779043>.
>


I got stuck trying to stack the links on the right side. why is it a <ul> but not stacking?> thanks!


*why is it a list but not stacking


Is there any reason you couldn't just use the one I already wrote?


This is just temporary testing code, right? I will add a skin loader to AssetLoader later


I didn't see it


There is no way for Lua to access Actor objects!!! You should be using your wrapper class (UIWrapper<T>) instead.


rude


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 924](https://teamcity.mesosphere.io/viewLog.html?buildId=58822&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:04:08


ドキュメント側もですが、
"instruction_ids": [...]
で省略されている部分はどのような出力になるのでしょうか？
他の箇所の繰り返しでもないと思うので、
コマンドを実行するまで、ユーザはわからない気がします。


@marchof Just FYI: after brief look, this seems similar to http://www.passwordstore.org/


Use generics correctly please


`_toElementId()` 这个函数没处理参数为非字符串的情况，可以加上。

这两个函数的测试用例中可以加上对这种情况的测试。


indent here?


Well whatever, you can keep it for now. I know where you copied this code from btw ;-)


Is not used At this time ,because PushClient not have activity (or activity context) in this context.


commit more often!


Solo cambiaría ahora este nombre de variable, nCo ya no corresponde a lo que almacena, después de eso, aprobada.


Aprobada con comentarios


Build/test run logs do not help in this situation; exit status 139 on FreeBSD is terminated by SIGSEGV.

The backtrace is here.
```
> /usr/local/bin/gdb710 /home/freebsd/boost/bin.v2/libs/locale/test/test_boundary.test/gcc-5.2.0/debug/test_boundary
GNU gdb (GDB) 7.10 [GDB v7.10 for FreeBSD]
Copyright (C) 2015 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-portbld-freebsd10.1".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /home/freebsd/boost/bin.v2/libs/locale/test/test_boundary.test/gcc-5.2.0/debug/test_boundary...done.
(gdb) start
Temporary breakpoint 1 at 0x40e4d3: file test_boundary.cpp, line 516.
Starting program: /home/freebsd/boost/bin.v2/libs/locale/test/test_boundary.test/gcc-5.2.0/debug/test_boundary
[New Thread 805018400 (LWP 100090)]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 805018400 (LWP 100090)]
0x0000000000000000 in ?? ()
(gdb) backtrace
#0  0x0000000000000000 in ?? ()
#1  0x00000008033ee399 in __cxxabiv1::__dynamic_cast (src_ptr=0x8036eaa80 <(anonymous namespace)::ctype_c>,
    src_type=0x8036de780 <typeinfo for std::locale::facet>, dst_type=0x8036df858 <typeinfo for std::ctype<char>>,
    src2dst=src2dst@entry=0) at ../../.././../gcc-5.2.0/libstdc++-v3/libsupc++/dyncast.cc:72
#2  0x000000080346bd80 in std::has_facet<std::ctype<char> > (__loc=...)
    at /wrkdirs/usr/ports/lang/gcc5/work/build/x86_64-portbld-freebsd10.1/libstdc++-v3/include/bits/locale_classes.tcc:110
#3  0x000000080345fa94 in std::basic_ios<char, std::char_traits<char> >::_M_cache_locale (
    this=this@entry=0x8036e9768 <std::cout+8>, __loc=...)
    at /wrkdirs/usr/ports/lang/gcc5/work/build/x86_64-portbld-freebsd10.1/libstdc++-v3/include/bits/basic_ios.tcc:159
#4  0x000000080345fc00 in std::basic_ios<char, std::char_traits<char> >::init (this=this@entry=0x8036e9768 <std::cout+8>,
    __sb=0x8036e9040 <__gnu_internal::buf_cout_sync>)
    at /wrkdirs/usr/ports/lang/gcc5/work/build/x86_64-portbld-freebsd10.1/libstdc++-v3/include/bits/basic_ios.tcc:132
#5  0x0000000803404b91 in std::basic_ostream<char, std::char_traits<char> >::basic_ostream (__sb=<optimized out>,
    this=<optimized out>, __in_chrg=<optimized out>, __vtt_parm=<optimized out>)
    at /wrkdirs/usr/ports/lang/gcc5/work/build/x86_64-portbld-freebsd10.1/libstdc++-v3/include/ostream:85
#6  std::ios_base::Init::Init (this=<optimized out>) at ../../../.././../gcc-5.2.0/libstdc++-v3/src/c++98/ios_init.cc:91
#7  0x0000000800bf68a4 in __static_initialization_and_destruction_0 (__initialize_p=1, __priority=65535)
    at /usr/local/lib/gcc5/include/c++/iostream:74
#8  0x0000000800bf68d7 in _GLOBAL__sub_I_chrono.cpp(void) () at ../../../boost/chrono/detail/inlined/posix/chrono.hpp:118
#9  0x000000080064e7a0 in ?? () from /libexec/ld-elf.so.1
#10 0x000000080064dd17 in ?? () from /libexec/ld-elf.so.1
#11 0x000000080064c129 in ?? () from /libexec/ld-elf.so.1
#12 0x0000000000000000 in ?? ()
(gdb)
```

Hmm...


hello world


make better commit messages!

this commit shows progress, you should describe what it does.

also, each commit already comes with a timestamp :watch:


好


漏了这个文件啦from conf import const


good comments!


A Study of Data Structures.

Ryan Gens


Div 1 Easy


Typo should be typing


Very funny


This looks pretty good


update_unit_testing (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1378 of 1378 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.36%25-green.svg)


@AndrewLngdn is this mapping supposed to be this way?
the first 3 seem okay, but i cant figure out the fourth one at all.


well the next line is going to dereference it so that would be a problem, and if you examine the diff you will see that this was the case all along before i added the assert.

just checking for the font and returning seems useless since its a TE control… what is the point of having a TE with no font and therefore no way to display text? AFICT from looking at GUIMA we arent creating this ourselves like with PST so shouldnt the CHU be supplying the font!? if it is then something must be setting it to NULL some time later on.

I dont have IWD2 installed to debug this right now, but I would start by making sure all the fonts are created successfully and putting a breakpoint in TE::SetFont to check for what is setting it to NULL.

This question points out that if it is useless to have a TE with no font then shouldnt font be passed at construct time?

> On Oct 14, 2015, at 15:30, Jaka Kranjc <notifications@github.com> wrote:
>
> is this really needed? IWD2 hits it immediately upon trying to open the map window.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/gemrb/gemrb/commit/525b3187826d9cd9b6b00a8594afc7263e3b8c73#commitcomment-13778671>.
>


i will fix this


I stand corrected, there was a font check and return above beforehand. Still I must question the value of having TE controls with no font…

> On Oct 14, 2015, at 15:30, Jaka Kranjc <notifications@github.com> wrote:
>
> is this really needed? IWD2 hits it immediately upon trying to open the map window.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/gemrb/gemrb/commit/525b3187826d9cd9b6b00a8594afc7263e3b8c73#commitcomment-13778671>.
>


song


Should read "... Bounds of **tool** handled by switch default"


Is it clocked slower than PrecacheUnitByNameSync?


ok ale good boy!


__int32__ uiTextId = 0;


After digging through the golang src, I conclude that `exec.Command(…).Run()` is just a nice interface around `syscall.ForkExec()`.


first commit


show all will now show all tasks being sorted by:
1) floating, where the floating tasks with dates, will be shown first, followed by floating tasks without dates.
[Floating tasks can have "undefined" dates, "undefined" ending times, or both.]

2) deadline
[Deadline tasks have "undefined" starting times".]

3) others


file_put_contents(laravel5-backend-master/bootstrap/cache/services.json): failed to open stream: No such file or directory


Kudos to Doug Black's writeup: http://dougblack.io/words/a-good-vimrc.html


@fskinner tu não acha que vale a pena alterar o nome da variavel 'sc' para tradePolicy ou SalesChannel? quem pegar esse código vai entender PN.
No mais, está ok.


Really cool. Like X. What about Y? Here's a [fake image] example of how that could work.
![logo_fxos](https://cloud.githubusercontent.com/assets/234670/10503684/6294c334-72ad-11e5-8bca-66f6c278c95e.jpeg)


@ensonic: It turns out that the biggest performance problem was using Gee. Although the GLib collections have much better performance, the are not as vala friendly and lend themselves to crashes and memory leaks much more easily.

These changes break ABI in ev3devKit, so if there are any other breaking changes you would like to make, now is a good time to make them.


"Seems to crash a lot now. After either loading 3 different titles (having them selected once) or selecting a second title and trying to run it."
With the public git there's various Home Menu state that's left corrupted, so odd issues shouldn't be completely unexpected(unlike with my local changes regarding Home Menu state).


Both the member `err` and `cmd` are 32-bit value. I will add comments here..


@darktears @rakuco we need this commit for X-Window.

Without this commit, the title of aura::Windows is shown well under Wayland and the test case also works fine, but the test fails without this commit under X-Window:
../../xwalk/runtime/browser/xwalk_runtime_browsertest.cc:135: Failure
Value of: window_title
  Actual:
Expected: title
Which is: Dummy Title
[  FAILED  ] XWalkRuntimeTest.GetWindowTitle, where TypeParam =  and GetParam() =  (276 ms)
[----------] 1 test from XWalkRuntimeTest (276 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (277 ms total)
[  PASSED  ] 0 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] XWalkRuntimeTest.GetWindowTitle, where TypeParam =  and GetParam() =

 1 FAILED TEST
[1/1] XWalkRuntimeTest.GetWindowTitle (323 ms)
1 test failed:
    XWalkRuntimeTest.GetWindowTitle


Those two are not common, or maybe I missed something? (common is 10, 0.2)


NOTE: If a file is not already sorted, only a valid add, delete or edit(change) command can sort it in the way explained in the first comment.


@FayneAldan Do you see anything displayed before the fatal-error?


How's that.  Do I gain entrance to the pearly gates of something yet?


Oh, yeah. Those one's aren't common, but they were redundant so I removed them, too.


Oooh, I like this approach. What do you think about making these `meta.method`, `storage.type.arrow`, etc. without the JavaScript specificity?


@jadeydi  这样解决了 Issue#40 了么？


At the time, I had only enabled the most basic keys :). In windows, the value of ConsoleKey represents the virtual key code, so the implementation simply assumes virtual key code to be the ConsoleKey. However, in Linux we might not be able to implement all the keys (some for example, Applications, are windows specific), so I am planning to expose only the ones it can recognize. The list should be smaller once I am completely done :).


But I'm cool with this approach :+1: checking one extra level deep so charts work, works for me.


Should this be the size passed in? Why the constant value here?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1032](https://teamcity.mesosphere.io/viewLog.html?buildId=59204&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:04:02


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1031](https://teamcity.mesosphere.io/viewLog.html?buildId=59203&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:04:24


The line also results in a compiler warning: http://ci.ros2.org/job/ros2_batch_ci_linux/443/warnings17Result/new/


Anecdotally it is for sure - just look at a few sites you use on Android on a regular basis.  It's not uncommon to have touch handlers on the documents, very few cancel scrolling in common scenarios.  But I guess we don't have hard data on this, but we'll [get it](http://crbug.com/543611) to confirm.


is GL_READ_FRAMEBUFFER not available in the bindings? I think I have used that previously, but might be wrong. Perhaps add a comment explaining this if it's not available in the bindings for some reason.


This and the test below would be relevant if you call `make_pick('paper')` and after that checked if `expect(player.pick).to eq 'paper'` You have to redo those tests.


TeamCity LabkeyModules15.2 :: CDS postgres 9.4 [Build 32](https://teamcity.labkey.org/viewLog.html?buildId=278286&buildTypeId=LabkeyModules152_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 22 Build time: 00:35:44
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

```


more functional idiom then procedural


The max size is 3 and min is 2, so the no. of string created won't be huge. However, I will try to reduce the count.


nice one! they passed locally :) thanks @lpantano


actual code is wrong this patch fix the .map format. Yeah that is wrong from a long time...


Yes, so why did you add this? The reason I ask is that we need to step up our game and only add code that is relevant to the project.


ReadExtraBuffer() should always be called only when the buffer is empty. Hence the Debug.Assert() check before. And since the buffer is empty both startIndex and endIndex should point to -1.


idiomatic julia is procedural


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1033](https://teamcity.mesosphere.io/viewLog.html?buildId=59205&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:37


Cleaning up.


Make this sample file into a representation of an actual hex file. Use 128 bytes from 0x00 and onward


Woops. I missed that . Thanks :)


Okay, PADOPTION is just to match the enum actually. But it's true it clear enough without. Will do.


Ok.


used the wrong symbol during my commit message, : instead of #


You need to remove this file from version control with `git -rm --cached .idea/*` and then add `.idea/*`to your `.gitignore`  I'll be checking that tomorrow in all your projects. ;-)


This was just what I was suggesting when talking about absolute paths :-) Why did you removed the `decodeURI()`? That's what needed to convert `%20` to space and similar things located in the filesystem paths...


@eaquigley if you know the file id and you have been granted the DownloadFile permission you can download files even if they are unpublished.

In the scenario at https://github.com/IQSS/dataverse/issues/2645#issuecomment-148423715 the user Fiona Finch has been granted the DownloadFile permission on the "trees.png" file. She can log in and paste http://localhost:8080/api/access/datafile/12 into her browser window to download the file, even though it is unpublished.

Again, the point is that it doesn't matter if the file is published or not so I'm not sure this commit makes sense.


Just a note: it seems that Travis doesn't like when multiple sections share the same name. In this case you add an `install` section that might conflict with the builtin one. That is:

    (install)  <- builtin section start
        python scripts/dev/ci_install.py
            (install) <- custom start
            ...
            (install) <- custom end
    (install)  <- builtin section end

I've been experimenting with section naming in  a test repository, and [output](https://travis-ci.org/abusalimov/test/jobs/79153040#L454-L470) was rather weird sometimes ([source](https://github.com/abusalimov/test/blob/d50dae1d6d712a9f7acba1ee28ded14e5eab32a2/test.sh)).


I have actually changed this in the next iteration. Char 0 conflict with actual Decimal value 0. So for all special keys, which do not have a char representation, I have simply used '\0' so, this check is now keyInfo.KeyChar != '\0'.


I will change it  :)


Woop forgot that one;) I did think of all the "FIXME" this time.


Yes, I plan to do so for 4 variables, and repeat 5 times. Finally, I'll have 20K iterations, and in each repetition I'll adjust ck values to be proportional to the rates of change in the previous sessions.


Woops thanks :)


Yikes. How silly of me.


lol


Nice! PocketMine styled code! Funny, you have many of the same files as PocketMine, and mostly the same code (Translated to java). Funny how this can happen :D


Hmm, I thought I tested and pushed a version without this change.  Let me do that, this may well not be needed.


yep, I just screwed up first time. Does not change much in fact. But I knew it was there so...


This code dont exist. You can delete it


fd


<sarcasm></sarcasm>


Is there a way to get stdio passthrough from `spawn`?


> The issues with card images will probably need further discussion as they will always come down to user preference

Well since there is no preference I thought it was based on image quality. Sure if the oracle text is significantly different then update those. Otherwise, at the size we show card images in the game the LQ images are quite jarring.

> Some way of updating those images...

See my first post for a possible way to do this.


I'm in Foreman 1.9 but both versions work the same for me because I have fog patched to allow to switch pool master anyway and that's the only diff between the two versions. I'll create an issue then.


This is code repetition. The only purpose of filename expansion is to replace niimg by a list of files. The globbing logic should therefore be at the beginning of the function and let the original code do the file loading.


Can you `cgi.escape(value.get('a'), True)`?


No needed. You can deleted it.


Send pull requests if possible
On Oct 16, 2015 1:37 AM, "Txuki2005" <notifications@github.com> wrote:

> This code dont exist. You can delete it
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CallMeAldy/kernel_lge_mako/commit/964388eb03c961d640b25ec6e2e32f11fffa64e9#commitcomment-13802152>
> .
>


This created a problem for me: duplicate interface definition for class 'OVCHTTPSessionManager'... I'm stuck trying to fix this... any suggestions?


We are on mako, this is not hammerhead. ;)


What is it? XD


no needed.


hah I copies all of those functions from some guys named Miguel's blog.


TeamCity pull requests :: netty [Build 419](https://garage.netty.io/teamcity/viewLog.html?buildId=2349&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5632, ignored: 21 Build time: 01:11:49


TeamCity pull requests :: netty [Build 422](https://garage.netty.io/teamcity/viewLog.html?buildId=2352&buildTypeId=pulls_netty&guest=1) is now running


Just the reminder classes.

On 15.10.2015 15:41, Benjamin Lieser wrote:
>
> F_7 and F_11?
> The free groups? or the reminder classes?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Unlikus/FGA/commit/69b19178bca77fa83adc4ee498da526198f90cea#commitcomment-13792923>.
>


I seem to remember there being at least certain cases where we could discover alt being pressed.  Maybe not?


Is this syntax already supported? or Stage 0 Babel?


The whole logic is in PlayerCacheUtil.java. Rest of it is just metawork.


You can deleted it, it is redundancy


That's because it is ;) resources don't need to know about the manager.


Here you are supposing that a glob returning one result is a single file, but we have no idea what the purpose of the user really is.


mmmm, it is the shame as mako board...we dont need this.


Do we expect to ever hit this?  If not, should this just be an assert, or let the cast fail, e.g.
```C#
lock (this)
{
    return ((StdinStreamReader)_in).ReadKey();
}
```


This is okay.


Because oc status shows it all, and most users won't be able to hit it.

On Thu, Oct 15, 2015 at 9:19 AM, Cesar Wong <notifications@github.com>
wrote:

> Apart from q above, LGTM
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/smarterclayton/origin/commit/a680572a7c1d8f36df7098f7ea42af74eeb4b1cd#commitcomment-13792330>
> .
>


Yes, I have added its support today. What I have done is basically check if buffer matches a special key if not, then before matching the ASCII key codes, check if the buffer has atleast 2 chars and the first one is esc  and map that to alt.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1001.0948f37361d36195fb0c836e94ac31807ffb8ff7](http://build.palaso.org/viewLog.html?buildId=64404&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 675, ignored: 6 Build time: 00:16:04


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1034](https://teamcity.mesosphere.io/viewLog.html?buildId=59206&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 192 Build time: 00:03:52


I assume this is just for your own manual testing?


Kurczę szkoda że już nie będzie wspierany projekt :( A mocno z niego korzystam u siebie w domu... bo mam zrobiony TVHeadend i na smartfonie i tablecie odbieram TV.
A czy nie możesz jakoś nie udostępniać kodu a tylko gotową apikację działającą pod TVHeadend ?


For some reason the webrtc namespace appear to not have a member named 'Scaler' in namespace 'webrtc' here.

It should have one so?
http://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/common_video/libyuv/scaler.cc#18


Use an IDE to check for errors. Oh, and I don't recall "as" being in java. Copied from @PocketMine. @Shoghicp @Intyre


Perfect!


Hrm - SetOpenshiftDefaults is a hammer.  Why are you using kclient.New?
Because Origin client doesn't negotiate?

On Thu, Oct 15, 2015 at 2:30 PM, Dan Mace <notifications@github.com> wrote:

> Paging @smarterclayton <https://github.com/smarterclayton>, this is the
> only thing left here AFAIK.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ironcladlou/origin/commit/351806293465dcfcae616497dabfc7498f5f5656#commitcomment-13800271>
> .
>


Yes :)


Also shame mako board commits...no needed i think, We can test it.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 752](https://teamcity.labkey.org/viewLog.html?buildId=278290&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 18 (2 new), passed: 241, muted: 23 Build time: 00:40:37
### Failed tests
```
org.labkey.test.tests.DataFinderTest.testStudyParticipantCounts: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSearch: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilters: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterPane: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

##### there are 8 more failed tests, see build details
```


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 2.6.510.d716153eb99a555ae60b80d594ccb55c52c1fd2c](http://build.palaso.org/viewLog.html?buildId=64408&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3365, ignored: 134 Build time: 00:17:17


awesome!


Ah, ok, not a big deal.  If we can find ways to cut down on it, though, that'd be nice.


Yes @zappabruno. It is visible and open for comments.
I agree with your idea! Apart from the credentials and past projects, judging through one's curiosity and eagerness to be up to date with the evolving software development platforms would definitely be a good way to distinguish a good programmer from the rest.


Ah, ok.


Yeah, but in order to get ctrl modifier, for anything other than those special cases handled earlier, the user would have to explicitly press ctrl and the key, so I thought we could add that here to get the extra ctrl modifier.


:astonished: I will fix it tomorrow... sorry about that


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.681](http://teamcity.monogame.net/viewLog.html?buildId=10671&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:20:53


sorry, it's `__builtin___clear_cache`, not `__built__clear_cache`.  It seems to work, that's what it looks like:
```
000089a0 <f>:
    89a0:   e92d4800    push    {fp, lr}
    89a4:   e28db004    add fp, sp, #4
    89a8:   e24dd008    sub sp, sp, #8
    89ac:   e50b0008    str r0, [fp, #-8]
    89b0:   e50b100c    str r1, [fp, #-12]
    89b4:   e51b300c    ldr r3, [fp, #-12]
    89b8:   e1a03103    lsl r3, r3, #2
    89bc:   e51b2008    ldr r2, [fp, #-8]
    89c0:   e0823003    add r3, r2, r3
    89c4:   e51b0008    ldr r0, [fp, #-8]
    89c8:   e1a01003    mov r1, r3
    89cc:   eb00000a    bl  89fc <__clear_cache>
    89d0:   e24bd004    sub sp, fp, #4
    89d4:   e8bd8800    pop {fp, pc}

000089fc <__clear_cache>:
    89fc:   e92d0080    stmfd   sp!, {r7}
    8a00:   e3a0780f    mov r7, #983040 ; 0xf0000
    8a04:   e2877002    add r7, r7, #2
    8a08:   e3a02000    mov r2, #0
    8a0c:   ef000000    svc 0x00000000
    8a10:   e8bd0080    ldmfd   sp!, {r7}
    8a14:   e12fff1e    bx  lr
```
I don't get what this unwanted-symbols is all about then, nevermind.


In fact I saw Mono goes further and uses TermInfo static information for key_copy and map it to ctrl+c :). I have not gone there yet.


I wouldn't bother splitting callback into a named function, but that's just personal preference. In either case, you need to make sure `this` inside the callback is the `ResourceManager` instance, not the `Resource` instance. Either:

```
resource.on("change:level", this.callback.bind(this));
```

or if you anonymise the function, you can use an arrow function to maintain `this`:

```
resource.on("change:level", () -> {
    this.trigger("change:resource:" + resource.name)
});
```

On another note, why is this a setter? You're not setting the `resource` property of the `ResourceManager` instance; you're adding a `Resource` instance to it. Sounds like you want this to be `addResource` (or just `add`) method.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.532.14a23a763808e6186bc81e09a0a6836a3d39376b](http://build.palaso.org/viewLog.html?buildId=64406&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3327, ignored: 140 Build time: 00:09:32


![Uploading diagrama-de-clases1.jpg…]()


mi lecciones


Yeah- we're reusing the upstream `NegotiateVersion()` which works with a concrete kclient.

Pretty much everything related to the client cache and negotiation seems to warrant a huge TODO to find a way to consolidate/share with upstream.


@mcritchlow, confirmed with Gabriela, it's for both public and curator view. So I think the sign_in_developer is not necessary. Please see updates.


I guess if this was how it was before, it may also work fine for MySQL.
You could probably just do an normal INSERT followed by a WHERE NOT EXIST(SELECT TOP 1 1 FROM blacklist WHERE addonId = '%s')


Interesting.  So typing ctrl-'C' will correctly give key ConsoleKey.C with Ctrl, but typing ctrl-'J' will give you a newline?


Hi, this is a non functional change, so no need to test on fishbench.

See last section "Speed optimization" in
https://github.com/glinscott/fishtest/wiki/Creating-my-first-test


nah probably I forgot it there, I will remove it on next commit :P


Awesome @saadahmed1 thanks for your input.
I'll work on it now, and ask for your opinion again in a bit.

Bruno


Another thought about AbstractAssignor: it is basically containing the consumer protocol schemas plus this assign function which is used for cases that do not need any extra metadata (e.g. rack information). Hence I feel we can just make it as a helper function and let all assignors extending PartitionAssignor directly, and probably just keep this class as ConsumerProtocol with some additional helper functions which will work in backward compatible way (since we require this, this function should work for any future versions).


Okay, over other code... you can revert this commit, except defconfig changes and apply these commmits from hammerhead, Now we wiil have all missing code.

Commits:
NET:
https://github.com/android/kernel_msm/commit/acb8a1fe48c558893d5b6ec532c0482b8ce2df6f
https://github.com/android/kernel_msm/commit/3eea96654d57f6fcdac05b4294e956abc07eae14
https://github.com/android/kernel_msm/commit/ac35569baea26f542652fe75c330545732c1160b
https://github.com/android/kernel_msm/commit/b06845bcf3adbffd3a7b14269b10c535fa67a932

USB:
https://github.com/android/kernel_msm/commit/6b7d3cea8925aba1c8248dabce14577c5be3fa83
https://github.com/android/kernel_msm/commit/a64c01c71597f16612c76c0aa341ad43b78a7814
https://github.com/android/kernel_msm/commit/e0fd828e9e33234da0c95918de30f93f9b91250c

Have a good night, see you. ;)


Sorry for my delay, but I've gone through it and it looks like a good approach and a good start.  Thanks1


backported to 1.4 as e403682444fa08af4f3491badf2f3a10d7595699


I think this would take a little bit. I'm walking through all open issues to review and fix all pending stuff.

Meanwhile you can point to master.


Okay, as long as no old table has two of the same addonIds with different ids were safe. Otherwise brace for duplicates.


It does -- it shows both the debug so you can know the line of the editor.  I also let the triggering error continue through instead of blocking it so that you can click to view it in devtools.  Since this means there are 2 lines for 1 error, I was thinking it might be better to put a marker in the gutter and copy the msg as a tooltip.


This one was good to leave!


This, too.


That's just the size we use to create a dummy context.  The actual size is used below, when we set up the framebuffer.  I used 128x128 since I remember there being some issues with too-tiny sizes on some drivers, but we could probably use 32x32 here to avoid unnecessary memory churn.


Huh, that's weird indeed :laughing:

I changed it to `ci_install` now. The output definitely looks much nicer like this, now I wonder if I should try writing a tox plugin to hide all its environment setup output as well :wink:


A question about the code on the stm32. It appears that the code will generate an interrupt every time a byte gets received. Is that true or am I mis-reading the code?


On 2015-10-15 at 12:48 Dan Cross <notifications@github.com> wrote:
> printf("%.*s", sizeof(buf), buf);
>
> or since you know the buffer size,
>
> printf("%.256s", buf);
>
> Also, did you want a newline at the end of the print?

I didn't, actually.

I just wanted something that was a sanity check on what the server was
getting.  Using %s wasn't enough, since I wasn't getting
null-terminated strings from the telnet client when it was not in line
mode.

Barret


I didn't see a requirement for edit/update in the specifications.


WTF i propably added bad file xD


> Sorry, but I don't understnad how not calling `enc28j60_read()` would improve the situation. If the data isn't read from the ENC28J60 then its buffer will overflow and the data will be lost there. From the ENC28J60 data sheet:

> "When a packet is being received and the receive buffer runs completely out of space, or EPKTCNT is 255 and cannot be incremented, the packet being received will be aborted (permanently lost) and the EIR.RXERIF bit will be set to ‘1’."

> Flow control works by design only end-2-end, doesn't it?

I missed to mention that part. The proper fix would also require to manually control EFLOCON.FCEN (combined with MACON1.TXPAUS, which is already set) depending on EIR.RXERIF and/or the buffer pointers. Unfortunately, this hardware flow control is not automatically triggered by the ENC28J60. But note that this is not sufficient. Pausing the data flow within the MCU between IPv4 and IPv6 as I explained in my previous comment is still required because otherwise the large Rx buffers in the ENC28J60 could be filled quickly and sent nearly as quickly to `IP64_INPUT()`, which would drop the extra data that it cannot accept, and larger IPv6 Tx buffers would not be an option for obvious reasons. This is the internal flow control that I was speaking about.

Tuning the TCP MSS also helped in my case. It was set to 1000 bytes in the mist-cc2538dk configuration, and setting it to 500 bytes instead in my wireless nodes reduced the issue. Of course, there is still IP fragmentation with such a value over 6LoWPAN, but it shouldn't be an issue with proper flow control at all levels.


Hi, I was wondering if you could help me with packet sending?


```Cons1``` is like ```Cons```


It's a little disturbing that `parseUser` is called over a dozen times here too just on just one route e.g. not exactly the most efficient function usage I think.

This function is synchronous for at least `preRender` and `render` in the controllers and that presents an issue with cross getting items in multiple models... which I thought I had figured out but I took it one step further to see if I could **not** alter the models for the values parsed in multiple models but then ran into this road block.

I'll twiddle some more to see if I can work around the road block encountered here before I go after the road block itself.

Thanks for the response... more to ponder on.


Remove from .gitignore ;-)


Good point, fixed in 763e40f


Any chance you could add the F3 support to the EXTI code and make a PR?


My personal preference is for the latest version, whether due to art or frame-style.

I've been able to find an earlier version of the cardbuilder and trying to reverse-engineer the changes up to the current Magarena version - hopefully I can bet this more integrated but not implemented for the user. Then we'll only need to worry about cropped images regardless of frame or text.


Totally agreed. I was thinking a better name. :+1:


I'm going to report this project... you didn't even remove all PHP code.


Ctrl+c is different, it should result in quitting unless terminal is in ~ISIG mode. Ctrl+J would behave as you suggest. However, only on Linux. On windows we can trap ctrl key press events and that is different than pressing enter. On Linux, we are mostly just guessing.


What do you mean by "`A` is supposed to be unique for a given `S`"? We have many A's for a given S - namely tuples.


selects


That's a different thing.  Removing coveralls doesn't mean that you should not run `npm run cover`, which in turn creates a local `coverage` folder.   So I think we should keep `coverage` in `.gitignore`


Ctrl+C was a bad example.  Ctrl+'b' or Ctrl+'a' or something else like that.


Superior implementation to what I had in my old branch where it failed.  Good catch.

< review


@coandres2 asta e tot ce vad


Someone is copying PocketMine code and changing it to java and claiming as their own. Here is proof in this file. https://github.com/Nukkit/Nukkit/commit/70909429867cb67d0e415aeb485de8dc3741391a#commitcomment-13802500. Maybe file a DMCA takedown notice?


Мне думается, что статусы должны быть не строкового типа, а быть каким-нибудь ENUM типом, вариантом, не помню как это в java. Лениво гуглить, сам посмотри.


TeamCity Dirigo Edge :: Pull Request Smoke Tests [Build 105](http://teamcity/viewLog.html?buildId=1385&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 5 Build time: 00:01:04


from an `S` to all it's element**s** `A` **whose index `I` in `S` satisfies the predicate**


that sounds most reasonable. we can send the info along via postMessage to
the app form the hook you created

On Thu, Oct 15, 2015 at 1:21 PM, Geoffery Miller <notifications@github.com>
wrote:

> It does -- it shows both the debug so you can know the line of the editor.
> I also let the triggering error continue through instead of blocking it so
> that you can click to view it in devtools. Since this means there are 2
> lines for 1 error, I was thinking it might be better to put a marker in the
> gutter and copy the msg as a tooltip.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/georules/building-blocks/commit/65ffadb07cf0024f0dd40fd8026c423bd597254b#commitcomment-13802423>
> .
>

--
Ian Johnson - 周彦
http://enja.org


TeamCity pull requests :: netty [Build 421](https://garage.netty.io/teamcity/viewLog.html?buildId=2351&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5632, ignored: 21 Build time: 00:37:34


I think both PartitionAssignor and AbstractPartitionAssignor could be in the internals sub-package; my motivation is that we only expose interfaces in clients/producer and clients/consumer that are used by "users", for those "developers" who need to implement their own coordination / assignment logic, they should be OK to work with internals classes.


This looks too good to be true ! Can't wait to see if it will work at LTC too !


I'll update it in a couple of weeks. In the meantime I plan to finish Spyder testing in Travis with the new packages, which will be available at https://anaconda.org/spyder-ide.

We plan to move to Qt5 in Anaconda next year, after Qt4 support ends in December :-)


You probably need to include scaler.h.

See media/webrtc/trunk/webrtc/modules/video_processing/main/source/spatial_resampler.cc/h


I have tried to be consistent with sed -n l on Linux when matching to the ConsoleKey


OMG :D why do you want to report it? This code is already deleted


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1035](https://teamcity.mesosphere.io/viewLog.html?buildId=59217&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:28


TeamCity libpalaso :: palaso-win32-master Continuous [Build 2.6.533.d716153eb99a555ae60b80d594ccb55c52c1fd2c](http://build.palaso.org/viewLog.html?buildId=64407&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3325, ignored: 140 Build time: 00:18:02


Very clever :+1:
<review


test


Nit; Fix the naming `testGetPaymentMethodsWithAndWithoutPluginInfo `


Dude you don't understand what this means. The fact you even had this code is bad enough, and don't say you download the pocketmine source to learn or some shit, as half of this code is java and the rest php. You can get sued for this. I've already told intyre too late.


Do you need the purchase call?


Омг, Давид, что ты несешь...


What is going to happen if the value is an object?


IMHO there should be some event fired when this is finished to trigger refreshView() in MapFragment


I presume you are doing this because the group might be unsynchronized - making this copy is not good for large groups; we need a better solution.


Uhhh...this is kinda wrong:

```
ryan@DevPC-LX:~$ hy --spy
hy 0.11.0 using CPython(default) 2.7.6 on Linux
=> (defclass X [] [--nonzero-- (fn [self] false)])
class X:

    def __nonzero__(self):
        return False
=> (if (X) 1 2)
(1L if X() else 2L)
2L
=>
ryan@DevPC-LX:~$
```

I think you can just leave out the explanation of Python's truthiness and link to a page like https://www.udacity.com/wiki/cs258/truthiness-in-python.


I am guessing in that case, the result is an empty list?


I don't think we need an extra attribute for this, can't you just store this temporarily in a local variable in the GameDisplay?


There shouldn't be a comma here.


prufu commit


I thought using global vars was frowned upon, and the package seems to execute fine with global commented out.  Unless suggested otherwise, I will comment out global in my dev branch, which will eventually merge into master.


Is the array index always in a valid range? Size checker can be better IMHO.


Sounds good :)


@mikedanese maybe changing this line to

```
cp -a "${TMP_DIFFROOT}" "${KUBE_ROOT}/"
```
 will solve the problem?


What about "used for"?


Hi,
I have an error when cross compiling from debian vm for arm.

Compiling ECTag.cpp
Compiling ECPacket.cpp
Compiling ECSocket.cpp
Compiling ECMuleSocket.cpp
ECMuleSocket.cpp:33:39: fatal error: boost/system/error_code.hpp: File o directory non esistente
compilation terminated.
make[9]: *** [ECMuleSocket.o] Error 1
make[8]: *** [all] Error 2
make[7]: *** [all-recursive] Error 1
make[6]: *** [all] Error 2


Yes its a longer list :)
Den 15/10/2015 20.02 skrev "Michał Ziober" <notifications@github.com>:

> Hi, I have added "Write optimisation", turkey test does not provide
> anything new to the API so I decided to not include this. I will add some
> info about "timeparser, jdbc result writer". Probably I will do that
> tomorrow.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ZioberMichal/super-csv/commit/37eff484492cbf537a69ad6512a523237419eb37#commitcomment-13799640>
> .
>


@gilch +1 to your writing style. You worded this part REALLY well! ;)


Thank you!


lgtm


No, because `ConcurrentModificationException` on the iteration in the `removeMessagesFromGroup`.
Just because we send to the remove exactly the same collection:
```
if (!this.expireGroupsUponTimeout) {
      afterRelease(groupNow, groupNow.getMessages(), true);
      removeGroup = false;
}
```


Sorry for not pushing my version yet.
It doesn't need to be an enum, so that is another red herring.

class Issue448 {
  Object getFor(int[] ia) {
    return Arrays.stream(ia).filter(x -> true);
  }
}

Is even simpler. It works when the expression is split up into two.


Thanks for the feedback :)


What about the `getPaymentInfoPlugin` for the `paymentPluginInfoTrue ` ? Don't we want to mostly check that case?


Yes i tried to rewrite some code from pocketmine and i propably didnt save file before upload. And i think this is something like pocketmine in java. But pocketmine is opensource right?


Is a partial match (like `contao/login`) also whitelisted?


Maybe that test could be  fast test (do we really need a BD)?


Please do *not* commit solutions to my GitHub repo - that's a violation of the Coursera honor code.

Thanks,

Doug


Signed -> u32
Reverselx -> reverse_lx (same for the 4th)
Something is bugging me, how do you handle multiple pad (pad1 and pad2) conf? I don't remember well but it seems there is a single instantiation for all pads


Read the LICENSE file in the pocketmine repo. You CANNOT resirtibute it.
And its the same as porting a game, or pocketmine plugin. You need
permission. I can't just go port essentials, I need permission first.
That's how life works I'm afraid -_-
On 15 Oct 2015 21:37, "Creeperface01" <notifications@github.com> wrote:

> Yes i tried to rewrite some code from pocketmine and i propably didnt save
> file before upload. And i think this is something like pocketmine in java.
> But pocketmine is opensource right?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Nukkit/Nukkit/commit/70909429867cb67d0e415aeb485de8dc3741391a#commitcomment-13802769>
> .
>


AddAllTransitionBinaries (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1908 of 1908 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You can try it, I don't think it worked for me without 'global' but maybe that was some other issue. Whether or not you label it 'global' you are in fact using it as a global variable, so I'm not sure making it explicit makes a difference or not


Ups! Did not realize it. I am not used to white spaces in filesystem paths. I have put it back


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1036](https://teamcity.mesosphere.io/viewLog.html?buildId=59219&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 192 Build time: 00:03:54


So use an `while (iterator.hasNext()) {...}` instead of `for(...) {...} and use `iterator.remove()` within the loop (you are allowed to modify that way).


Nit: Is that only used for your new test? Do we need that new common method or can it be kept inside your test?


We could actually just bring the alias definition inside the 'def name' function, not sure it's needed anywhere else.


General note for the commit comment. Add a ```onepad:``` at the start. It really helps to search im the history.


So... we're good?


I'm sorry, I tried to get assigment two to my fork, but obviously did it the wrong way, so I cancled the pull request.


Removed year everywhere


FIXME can go away


Done


So im going to download repository before it get removed xD


It should be gone now.


Maybe link to the course description itself instead of just skillsmatter?


`iterator.remove()` isn't the way, because no guaranty that caller use `removeMessagesFromGroup` for the same collection.
Agreed: need to think more...


Hells, no needed to add on defconfig. it is better let as is. On Hammerhead is not activated from defconfig ;)


You'd better use format here, especially if you encountered an unexpected value in the *hittest.flags* field. I would write it as following:
``` python
raise RuntimeError("Unexpected hit test flags value {} trying to find checkbox".format(hittest.flags))
```
The same is about the similar line 396 below.


I included it beacause I need a paymentId for the next call.

``` java
paymentApi.getPayment(payment.getId(), ###, ###);
```


BTW: this function and `HistoryFromV1Config` should move to the distribution repository eventually. The registry will need them to rewrite manifests.


This has nothing to do with the work you are doing with the folders for content types, its for getting media items - which use the MediaType "Folder" or some variation of a folder. It's for the media library views where we need to separate media from folders for navigation


Hey Nga,

Nice catch. Fix committed. Thank you :+1:

Ha-Duong


Here we are in input line so the player levels up just by typing so ?


And nope, it does not need the full display object, I'll change that


yes.  bots are also happy as far as I can tell.


not really, if S == (Int, String, Boolean) then A must be Boolean


Please leave a giant todo on this.

On Thu, Oct 15, 2015 at 4:18 PM, Dan Mace <notifications@github.com> wrote:

> Yeah- we're reusing the upstream NegotiateVersion() which works with a
> concrete kclient.
>
> Pretty much everything related to the client cache and negotiation seems
> to warrant a huge TODO to find a way to consolidate/share with upstream.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ironcladlou/origin/commit/351806293465dcfcae616497dabfc7498f5f5656#commitcomment-13802370>
> .
>


Wow, does rubocop require that?


Hi Dante,
  that's an interesting change.
How about sending a pull request? In this way, this change will be included in the main repository.

Cheers,

D.


but I believe it is "its elements" not "it's elements"


TeamCity Dirigo Edge :: Pull Request Smoke Tests [Build 106](http://teamcity/viewLog.html?buildId=1391&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 5 Build time: 00:01:04


Is this `O(n^2)` now?


you are rith, I'll keep it in my test.


:+1: for adding comments


TeamCity pull requests :: netty [Build 423](https://garage.netty.io/teamcity/viewLog.html?buildId=2354&buildTypeId=pulls_netty&guest=1) is now running


I think it was a google service that could load an external xml feed and return it as json, but we should not in anyway use this for anything


I am finishing with IO  (local branch only now),  exti  is dependent on it,but similar to this PR.


Using `nt.schema.graph.nodes.all()` incurs in a performance problem. We should use `nt.schema.graph.nodes.filter()` and `nt.schema.graph.Q` objects. That way the filtering is done at the backend level.

Furthermore, we need to support any number of properties and their lookups.


SGTM


What's this change for?


you like empty lines, don't you?


looks good to me.


Hi,
Thanks for the update here. I just wanted to know how to do the following thing in the calling python function:
```python
...
## the param structure for xgboost is set here
...
num_round = 10
bst = None
for i in range(5):
        bst = xgb.train(param, dtrain, num_round/5, watchlist, bst );
        tmpFile = modelFile + "." + str(i)
        print ('Epoch %d: Saving model to %s' %(i, tmpFile)); sys.stdout.flush()
        bst.save_model(tmpFile)
        del bst
        print 'Loading model'
        bst = xgb.Booster({'nthread':8})
        bst.load_model(tmpFile) # load model
```
If I compile the whole of xgboost package with your changes and run the code above, I get errors like:
=======================================
...
    bst = xgb.train(param, dtrain, num_round/5, watchlist, bst );

  File "//anaconda/lib/python2.7/site-packages/xgboost-0.4-py2.7.egg/xgboost/training.py", line 65, in train
    bst.update(dtrain, i, obj)

  File "//anaconda/lib/python2.7/site-packages/xgboost-0.4-py2.7.egg/xgboost/core.py", line 526, in update
    grad, hess = fobj(pred, dtrain)

TypeError: 'Booster' object is not callable
=======================================
Any help on this matter will be really helpful (I am new to Python)


No my question is about the space at the end of `+msgstr "Courriel "`.


ditto


SoundCloud did fix the problem server side as well. However this fix is still forward compatible, seeing as x-www-form-urlencoded is the one SoundCloud themselves use in their own apps.


Perhaps add a copyright line with your name instead of replacing it?


Looks good, thanks for fixing that.


If that last messsage wasn't clear enough this is what is encountered when adding this line to `preRender` *(or any place else)* even with virtuals included.

![issue-643roadblock1 opt](https://cloud.githubusercontent.com/assets/114709/10527079/cb1efa0c-734b-11e5-8fa9-3e7735311293.png)

If I restore this line and remove the below intermediate then it comes back when logged in... so I have to find out what effects happen to your code if I do that... so far I can still GH import just fine. I understand we're a wee bit past this commit date so a few things may have changed but the _template.js usage for the user controller is busted *for future use* on this page due to this change.


TeamCity Dirigo Edge :: Pull Request Smoke Tests [Build 107](http://teamcity/viewLog.html?buildId=1397&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 5 (5 new), passed: 0 Build time: 00:02:00
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.Login: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


+1 to leaving "coverage" in gitignore


this auto update button of github is cool, but causes a merge commit, a rebase would be be even more cool, I'll squash this one out later on..


Better. While using this file, could you please make those variables follow code guidelines ?
Name should begin with m and a capital letter


OK, why did this happen? @davidfowl? This test just started failing for the StructureMap adapter. Why would you ever want to track transients? I haven't looked through the code yet, but won't this leak? Or are they tracked using WeakRefs?


ToString() always returns JSON representation of the JToken which will be a string.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.5.72.7d833d163d0e49c97166eed46c119f0019513a5b](http://build.palaso.org/viewLog.html?buildId=64412&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 874, ignored: 50 Build time: 00:31:24


Do you want to check the other params? in / out / err / tty?


Looks like Debian added cgit recently in their Jessie release, and Ubuntu subsequently imported it from there into Vivid and later.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1039](https://teamcity.mesosphere.io/viewLog.html?buildId=59227&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:21


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1038](https://teamcity.mesosphere.io/viewLog.html?buildId=59226&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:21


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1040](https://teamcity.mesosphere.io/viewLog.html?buildId=59229&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:22


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1041](https://teamcity.mesosphere.io/viewLog.html?buildId=59230&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:22


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1037](https://teamcity.mesosphere.io/viewLog.html?buildId=59225&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:21


zx


I'm not sure if this partial is needed as it is in the base theme: https://github.com/getgrav/grav-theme-bootstrap/blob/develop/templates/partials/metadata.html.twig

@emb03 did you make any modifications to it?


the ambiguity is troublesome. perhaps this should have remained open for review longer before merging.


Can we adjust it to not render `Swipeable` too, something like this

```
          {
            this.props.items.length >= 2 ?
              [
                <a key='leftNav'
                  className='image-gallery-left-nav'
                  onTouchStart={swipePrev}
                  onClick={swipePrev}/>,

                <a
                  key='rightNav'
                  className='image-gallery-right-nav'
                  onTouchStart={swipeNext}
                  onClick={swipeNext}/>,

                <Swipeable
                  key='swipeable'
                  onSwipedLeft={swipeNext}
                  onSwipedRight={swipePrev}>
                    <div className='image-gallery-slides'>
                      {slides}
                    </div>
                </Swipeable>
              ]
            :
              <div className='image-gallery-slides'>
                {slides}
              </div>
          }
```


Maybe they're the same, but this is what I need to know, 'cause I'm going to grab Group[1]


Done


Question is : Is this test useful/needed/meaningful? If so then it's probably needed upstream. If not then we should get rid of the test, if yes then it sounds to me that it's a candidate for upstream.


@danielravina this seems like cleanup that shouldn't be in this commit.


Also modified width/height to reflect the viewport size, rather than sizing statically.


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 108](http://teamcity/viewLog.html?buildId=1406&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:01:53
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.Login: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


`|| die`


@lukasbestle That's fine. I suggested it because the same syntax is used in `^content/(.*)\.(txt|md|mdown)$`


I know the kind of problem you're referring too, but those are where xpaths are involved. I'm not seeing how that's relevant here. I'm given an element, I act on the element. I can't see every element-related class getting tests to make sure the code doesn't pathologically query its parent and then go messing with other elements.


OK. ha u32 for that too?
OK too.
I don't handle it now that you say it. Can do, by duplicating struct then. Actually, is it critical? If yes, will tell @kust2708 to handle that in GUI too just. I will redo in code too.
Same time(and before I forget), I see that sixaxis_usb has no effect whatsoever for my sixaxis, is it to be expected?


Moving this outside will break the method I'm pretty sure for some usecases - exactly as in #127


Yes. Thanks for pointing that out. Done now.


We can trigger this event from any module of our aplication, only we need to subscribe it by window Oject scope:

```javascript
// publish
w.addEventListener('playTurn', playFunction);

// subscribe
w.dispatchEvent(new CustomEvent('playTurn'));
```


OK, will do that too. With the fix for two pads. Maybe tomorrow though as my eyes are really burning now.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1043](https://teamcity.mesosphere.io/viewLog.html?buildId=59233&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:04:04


You could have also written this as:

```ruby
post.title = "SPAM!"
```


Sure! I'll let you know when i start on it so you can assign it to me or something.


I'll remove these. Basic CRUD was generated when I used the scaffolding.


array index should be always in valid range as long as size is greater than 0 yep. Size can be equal to 0 though. I did get crash dump due to that( no gamepad)


The OSQA CMS automatically renders the concerned strings followed by a colon and, without such a space, they would be typeset following more English/American than French rules ("Courriel:" versus "Courriel :").


actually we need one for Cmake, placed it into cmake folder


Add `babel-core/polyfill` here since using `Array.from` within https://github.com/shakacode/react-webpack-rails-tutorial/blob/master/client/app/utils/metaTagsManager.js. Without this console would produce an error that `Array.from` was not a function and tests would fail.

Babel advanced caveats: http://babeljs.io/docs/advanced/caveats/


Sorry. I missed this "Speed optimization" section.
But can't I use fishtest to see what improvement my change gives? (My tests show it is 4-5 ELO, but I wanted to run a test for tens of thousands games.)


Was this actually needed?


to delete with my upload?


"unofficial" upload, will not work without my account


Hi there
This FB module update make apps crash on iOS.
How to reproduce :
- start from blank app,
- add "require('facebook');" to app.js,
- close app (click home button),
- reopen app.
Thank you.


We always track transients. They can be created in scopes which get disposed.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (377 of 377 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


cmake 2.8.7  have no FindLua, had to ship it with us (taken from OSRM)


I thought you were only on your phone, not on a pc :-P you cancelled my uploads again :-P


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1042](https://teamcity.mesosphere.io/viewLog.html?buildId=59232&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 190 Build time: 00:08:30


That would throw - but new `LocalDate(2000, 2, 29).PlusYears(1)` would return February 28th.

If the aim is to represent an annual event of some kind - birthday, start of quarter, tax deadline or whatever - then throwing an exception simply feels unhelpful.


Thanks mate!


Если этот шаблон в будущем будет переписан на что-то удобоваримое, надо не забыть поправить. Я добавлю TODO. на выходных.


Can we rename `initialImage` to `startIndex`.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.5-LibC++: OK (377 of 377 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


this should just be `currentIndex: this.props.startIndex` since it will be initialized at `0`.


Hi Jim (@jhinkey),

for the second question, it can be any implementation of the Java Map interface.

For the first question, it's used for HTML data-* Attributes. One use case of this would be the "data-navigation" attribute. If this is set in a link, it will create a direct link to an URL. The map that is passed contains a set of attributes (navigation, class-name, etc) and is later changed via the AUIUtil to data-navigation or data-class-name.

Let me know if this helps :)

Thanks!

/cc @mwilliams2014


Shouldn't this be in Utils ?


> Without this commit, the title of aura::Windows is shown well under Wayland and the test case also works fine, but the test fails without this commit under X-Window:

Do you mean that the standard setup (no ozone-wayland, default X11 build) is failing for you? It's passing on the bots and it passed here locally too.


Do we want or need to stay on precise?  it's pretty old.


I want to defer this into handling the error and rendering a backup image. Can you remove the `_handleError` portion out of this feature.


"artificats".  like aristocats?


```erlang
encode_rows(Measurements) ->
    [ row_for(MeasureRow) || MeasureRow <- Measurements ].
```


this is the only place in the code that we search the directory, no need to make it a function


\o/ Wonderfull :-)


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 109](http://teamcity/viewLog.html?buildId=1413&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:01:49
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.Login: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


This is really cool, thank you!


How can the drop chance be set now?


:+1: And you even remove the form after the last key is removed... That's what I call clean. Good job!


I didn't know that there existed an "anti CAPTCHA cause", I just thought you hadn't thought of it :wink: I agree that CAPTCHAs can be quite annoying when they are used in abundance, but a single CAPTCHA at registration has never bothered me.


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 110](http://teamcity/viewLog.html?buildId=1418&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:01:49
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.Login: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


Thanks that makes sense. So there's no way to know that before actually looking where it is used in the software.


No. It is a non-functional change. Please stick to procedures.

If there is a measurable speedup, we can approximate the ELO gain for you.
If there is no measurable speedup, there cannot be such a huge ELO gain.


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 111](http://teamcity/viewLog.html?buildId=1424&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 4 Build time: 00:00:46


So if you set your error action to something, then just log the errors rather than throwing an exception?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1048](https://teamcity.mesosphere.io/viewLog.html?buildId=59245&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:00


 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:673](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/include/chaiscript/language/chaiscript_parser.hpp#L673) Expression is always false because 'else if' condition matches previous condition at line 671. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:677](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/include/chaiscript/language/chaiscript_parser.hpp#L677) Expression is always false because 'else if' condition matches previous condition at line 675. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 675. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:1](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/84e2d449b9e51863db0edbe305feceb6a331e38a/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Misspelled slashes twice :sweat_smile:


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 112](http://teamcity/viewLog.html?buildId=1427&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:01:52
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.Login: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


Mega
:+1:


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-AddressSanitizer: OK (377 of 377 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Hmm. I guess I intuit `InYear()` as more like the constructor: "here, you have a month and day already, have a year and give me a `LocalDate` back".

I can see a use for what you're suggesting, but doesn't the right interpretation of this depend on the context that the caller has?

[
For fun, Wikipedia helpfully notes that, legally, "when a person born on February 29 turns 18 in a non-leap year, they are considered to have their birthday on March 1 in the relevant year", while in New Zealand, "a person born on February 29 is deemed to have their birthday on February 28 in non-leap years, for the purposes of Driver Licensing"

(It also seems somewhat odd to be able to have e.g. `monthDay1.InYear(2000) == monthDay2.InYear(2000) && monthDay1 != monthDay2`.)
]

I think maybe we need both forms?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1049](https://teamcity.mesosphere.io/viewLog.html?buildId=59246&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:06:48


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 113](http://teamcity/viewLog.html?buildId=1430&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:00:04


Yes this shouldn't be necessary, and that bugfix I don't think would have been related to this. @vvuk do you have some link error logs I could take a peek at?


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 114](http://teamcity/viewLog.html?buildId=1433&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:01:46
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.Login: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


@mathieuravaux made good progress here, specs run in the browser now. For the agressive minification issue with testing I opted for the following strategy:

1. for the unit tests, don't run closure in `SIMPLE_OPTIMISATIONS` mode which don't rename anything. Unit tests make an extensive use of private API which is renamed.
2. (TODO) write an "e2e" test, that would compare result to avro binary result, using the lib compiled in `ADVANCED_OPTIMISATIONS`, with only the "public" exported API of this.

This commit represents the diff with existing node library, result is not too scary after all.


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-clang-3.6-ThreadSanitizer: OK (377 of 377 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This shouldn't be committed yet


xgb.train's param *xgb_model* has to be the file name of the saved model, not the model itself.


Here's a commit-level comment.


And another one on the same line.


TeamCity pull requests :: netty [Build 422](https://garage.netty.io/teamcity/viewLog.html?buildId=2352&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5632, ignored: 21 Build time: 01:11:36


TeamCity pull requests :: netty [Build 424](https://garage.netty.io/teamcity/viewLog.html?buildId=2355&buildTypeId=pulls_netty&guest=1) is now running


This method was updated significantly and the doc string does not reflect those changes. The doc string still refers to the old argument name "connection" instead of the new argument name "join". It also refers to it as a tuple instead of a named tuple. I had to compare the 1.7 code and the 1.8 code to figure out what was really going on here because the doc string no longer gives any help.


It's possible to lose some notifications by the time you add the listener. I don't think it matters that much in practice though.


ok, I guess spaces can be allowed, will update


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (377 of 377 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Good suggestion. Added that to the test.


Ahh - you're right. It works if I leave out `-c` - that said if that's the case I really don't like it since that means my output would be different depending on which directory I run `postcss` from - I'll write a bit more in a PR.


Right. The issue we ran into was that some of the raw data going into ElasticSearch was malformed (fields didn't match the data mapping), which ES rejected as part of the bulk insert. The Flume ES sink currently handles this by just sending the record over and over (hoping that maybe ES will just accept it later). Unfortunately, this creates a LOT of log traffic in ES default log settings AND it backed up our flume channel, because the data isn't getting any better by retrying it.

This patch allows users to choose between 3 options on what to do when bulk insert errors occur:
1) retry until it somehow magically works (current default within apache flume)
2) log the error message, then drop it
3) drop it silently.

In our case, we just want to drop it, because losing a few records is worth it to keep our data flows moving. However, it would be better to have a more advanced option that can account for times when the ES server is down. Unfortunately, the ES client API doesn't allow for this flexibility to know the type of error, so this was the best option available at the time.


Is it possible plugin for Wordpress???


Why 64?


TeamCity pull requests :: netty [Build 423](https://garage.netty.io/teamcity/viewLog.html?buildId=2354&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5632, ignored: 21 Build time: 00:38:10


TeamCity pull requests :: netty [Build 425](https://garage.netty.io/teamcity/viewLog.html?buildId=2356&buildTypeId=pulls_netty&guest=1) is now running


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-gcc-4.6: OK (377 of 377 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


yeah, the module attribute should be global throughout the module.


Filename intended to avoid import failures.


Could we alter to not use wildcard imports?


TaskCluster, Request payload must follow the schema: http://schemas.taskcluster.net/scheduler/v1/task-graph.json# ```{
    "validation": {
        "tasks": {
            "schema": {
                "0": {
                    "schema": {
                        "task": {
                            "schema": {
                                "env": {
                                    "additional": true
                                }
                            }
                        }
                    }
                }
            }
        }
    }
}```


develop (lefticus) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.67: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg)


Hahaha :-D Don't worry, I supposed it :-) But not only spaces, but also all kind of not-url characters, including Unicode ones...


I am very sorry to say that, but this is also not the fix :-(.
First, ADC_UB_MUX is the one for battery. Your change modifies it for thermotronic, which, almost for sure, you do not use, so it should have no effect on your code. Used change is ADC_TEMP_MUX, but that does not affect battery reading.
But what's more, if you look at adc.c, function start_task_ADC, you can see a line where this define is being used:
ADMUX = ADC_UB_MUX | (1<<REFS0);
You can see that the REFS0 bit is being set here, thus selecting the right value, duplicating what you added to the define.
I am sorry, but we need to look further :-(.


I added a `FEATURE_APPLOCAL_MSBUILD` flag, which looks like it would be the opposite of this.  We should consolidate these.  I don't think I really have an opinion on which name to use.


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1050](https://teamcity.mesosphere.io/viewLog.html?buildId=59259&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:04:09


We don’t need `flac` for the dummy file, just use this:

```rb
(testpath/"file.flac").write "pseudo audio data that stays the same \x00\xff\xda"
```

and then `system "#{bin}/whatmp3", "--notorrent", "--V0", "file.flac"`.


nit: space (


@zoek1 estos métodos son bien importantes que agrega devise pues se usan alrededor de todos los controladores, se fueron por algún motivo?


@HeWhoWas @oovoo @bkreitch if anybody has a solution, please open a PR to discuss. Otherwise please wait for the redmine issue to collect information there.


btw, I'm assuming that the :retry command in phabricator doesn't add arc test (if it does, we should have it add another tag instead)


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 115](http://teamcity/viewLog.html?buildId=1440&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:01:54
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.Login: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


Actually, it's an error in test setup, not an assertion failure.  So recommend checking .exists() and if so, throwing an Exception


Same comment as above; if it's not there, there is an error in test setup so recommend exception, not a failure


Instead of "stack value" call this "native value" . We refer to the java type as the "native container type" or "java container type" (vs "sql type")


yeah! :+1:


imho we should not roll our own color solution and instead use
https://www.npmjs.com/package/chalk


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 116](http://teamcity/viewLog.html?buildId=1445&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 5, passed: 0 Build time: 00:01:53
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.Login: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


Whitespace change


Was removing this intentional?


disabling would be trivial as well :) instead of having to roll our own
https://www.npmjs.com/package/chalk#chalk-enabled


I just used what was already there.

From the linked site:
> Basically, it breaks down to: 0, None, and empty containers are interpreted as false.

Which is basically what I said. Only some kind of custom container would have a `__len__` method, so I think that's covered. Perhaps the `__nonzero__` method is worth mention. I'd rather not link to an external site like that in the docs if I can help it. It's not under our control so the link could break at any time without warning or notice.

I might make an exception for the official Python docs, since we're dependent on that anyway, but then which version?


The [spec](https://webbluetoothcg.github.io/web-bluetooth/#dom-bluetoothgattcharacteristic-startnotifications) tries to make it impossible to lose notifications if you add the listener in the `.then()` callback, by having the event dispatching go through the event loop, while the promise is resolved synchronously and goes through the microtask loop (which empties before the next event loop task is run). The wording isn't quite right, since "in parallel" things can get interleaved, but that's the goal.

@beaufortfrancois can you file a spec bug to update the example and the promise's return value? I'd like to get some more web platform folks' opinions about the return value, but having a bug will make sure we don't forget to check on this.


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 117](http://teamcity/viewLog.html?buildId=1448&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 5 Build time: 00:01:05


Actually, why not just call the method "read"?


Why not just "write"?


Otherwise the compiler complains that it's not a well-formed preprocessor directive.  I couldn't think of a way out of that.


So awesome! Thank you! Now to wait for this to be included in all the apps that use it. :)


Who is root? @hellermf ?


I built your code and ran a fishbench vs the master, its a slight slowdown for me

Results for 25 tests for each version:

            Base      Test      Diff
    Mean    1812545   1805167   7378
    StDev   81933     80509     5986

p-value: 0.109
speedup: -0.004


Well, though ShrinkWrap makes no concurrency guarantees to users, this impl swap to a blocking impl from a safe concurrent one is something I'd like @aslakknutsen and @kpiwko to also review.  I *think* it should be fine because we advise users to synchronize their own access to Archives anyway.


that was hasty, there is another `merge!` function (just below) that calls this wrapper.


True enough.  The manger.jumpToPrevResult() function was written but never exposed.  Done in 6533979


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1051](https://teamcity.mesosphere.io/viewLog.html?buildId=59262&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:03:58


the module 'leboncoin' is now ready to be used by the server ! It return directly a clean json( (without extra blank space).


I agree.  I think I prefer `INSTALLED_MSBUILD` because it feels a bit more like the other flags where we're walling off something that used to work but now doesn't.  If no one disagrees I'll replace usages with that.


shouldn't this just read ```list|handlers/list.py```?


I'm not sure which ```bin/verify.sh``` you refer here ...
Yes, there is a Travis caching approach http://docs.travis-ci.com/user/caching/ (looks like a simple change to the script above ...)


esta de la verga el cambio


Oh duh. Well I forgot if I set it executable so I included it. I guess it's
unnecessary.
On Oct 15, 2015 5:38 PM, "slowriot" <notifications@github.com> wrote:

> shouldn't this just read list|handlers/list.py?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/techkid6/MCOTelegramBot/commit/3be9e9402514ced7d79bece37bfa24d4eeb423c4#commitcomment-13803966>
> .
>


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1052](https://teamcity.mesosphere.io/viewLog.html?buildId=59264&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:06


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1053](https://teamcity.mesosphere.io/viewLog.html?buildId=59265&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:06:20


Huh...`/analyze` missed this?


Los tenia disponibles en las vistas que hacen uso de ellos sin que estuvieran aqui.
¿Los debería de regresar?


Yup, I've looked up the stuff about Feb 29th before... but I think if we want to support "roll to March 1st" for this type, we'd want to do it in calendrical arithmetic too, which makes this a much bigger deal.

I'm not sure your InYear situation is much more surprising than `date1.PlusYears(1) == date2.PlusYears(1) && date1 != date2`.

At least we're limited to Feb 29th by limiting this to the ISO calendars. Even without the Hebrew calendar system, other calendar systems would lead to similar oddities.


Please open a [new `Cleanup/optimization` ticket](https://code.djangoproject.com/newticket) and feel free to suggest a reword as a PR.


only 18 months late, but I've done that just now :)


`iterator.remove()` doesn't work because of `SimpleMessageGroup`:
```
public Collection<Message<?>> getMessages() {
     return Collections.unmodifiableCollection(messages);
}
```
for the ` afterRelease(groupNow, groupNow.getMessages(), true);` above.

I think I see the solution for the `SimpleMessageStore`...


already done outside this script, obsolete


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1054](https://teamcity.mesosphere.io/viewLog.html?buildId=59272&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 191 Build time: 00:03:59


you can do that already now, obsolete


Presumably this used to compile, right?  Is this a compiler bug?


Can you make this a bit smarter (at some point in time)?
Expect YYYMMDD: first do some validation.
Also, do prefix match - i.e., if user specifies YYYY, then match everything in year.


@schleichardt a bit too late, but why did you actually remove this method?


The plugin [`Notification`](https://github.com/getsentry/sentry/blob/ec94892f56bb93ef9f970e4e9de62b578daeda98/src/sentry/plugins/base/structs.py#L25-L39) object is similar to the digest [`Notification`](https://github.com/getsentry/sentry/blob/ec94892f56bb93ef9f970e4e9de62b578daeda98/src/sentry/digests/notifications.py#L26) (the digest implementation was added because the plugin version is not able to be pickled), these should probably be consolidated at some point.


These templates are duplicated from "Add any feature without changing the AM and CK" template.


At some point, write test cases against data in ` src/test/resources/arc/`?


@Ben-G probably should have pull requested this - does it look okay?  I converted multi-line lines into a single line, which I probably shouldn't have done...


Darn. I think I swapped the words. It should be WithScriptCompilationInfo :(


It compiled when the `#` was embedded in a string literal.  Now it's in a not-exactly-code zone because the `#if` evaluated to false.


It only finds bugs if you run it.

Running /analyze from package_etw.bat is on my to-do list. That is the best way to ensure that at least I don't create releases with embarrassing bugs like that.


Nice! :+1:
Confirmed: I misunderstood that section in dataTables documentation :laughing:


@SLaks you can ask IDocumentTrackingService to be public. if you are thinking hosting Roslyn in your own host, you shouldn't use any Roslyn Visual Studio layer code but create your own one. if there is something that is not public, it would be nice for everyone if you start opening issues in Roslyn repo so that people can start consider opening more.

in Roslyn, layers are architectured in a way host dependable components and host in-dependent components are clearly separated. but VS itself is not. but you can assume all components up to Roslyn Editor Feature layers  referencing are host in-dependent VS components (ex, editor, tagger, intellisense and etc) but ones Roslyn VS layer is referencing such as VSErrorlist/VSDocumentTracker/VSTelemetry are not.

if you try to re-use components in Roslyn VS layer, hacks like you did are probably only way. you can do such hacks for now, but it would be nice if you open issues for all those cases so that people can consider such cases and start opening up interfaces that host can plug in.


For ScheduledExecutorService, use try{} catch (Throwable t)  to capture all errors. Otherwise the subsequent run will be suppressed.


Doh...
It is the same iteration and removal bypassing `iterator`:
```
if (this.messageStore instanceof SimpleMessageStore) {
	for (Message<?> message : messageGroup.getMessages()) {
		this.messageStore.removeMessageFromGroup(messageGroup.getGroupId(), message);
	}
}
```


Sorry it got in after I did `gulp build`. I will remove it from the pull request


Also it will be nice if we can move thread execution out of constructor.


It's supposed to be "equatable" (http://www.merriam-webster.com/dictionary/equatable)


@humberos in the link posted on Alin's commit you can see on Android 6.0 Configuration

The storage_list.xml resource overlay has been removed and is no longer used by the framework. Storage devices are now configured dynamically when detected by vold.

on those targets on aosp they have some deprecated definitions but is my opinion ... maybe I am wrong


Oh maybe for backward compatibility, you are right, we should provide both means.


2 space indents


New Line at EOF


It gets added automatically to the config, if partialresume is enabled: https://github.com/hellsgod/hells-Core-N4/commit/63ecdcb21b7a642f02e6b0e04edd7648a6ccb37a#diff-9839e512d1aed24efa4fe0e423db605fR334


Can we rename this to another name to indicate that we do not allow people to change range?


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1055](https://teamcity.mesosphere.io/viewLog.html?buildId=59275&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:06:58


This is not bad, Oleg.
But...formatting of the container-tags.

               .....


Equatable


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1057](https://teamcity.mesosphere.io/viewLog.html?buildId=59277&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:34


2 space indentations


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1056](https://teamcity.mesosphere.io/viewLog.html?buildId=59276&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:02


I did already.  https://github.com/dotnet/roslyn/issues/2475


It's not really an illegal state. This exception type is correct for this scenario.


`value.getClass().getName()`


I think we can remove these exports now, right?


Use 2 space indents


Same for `Primitives.wrap(type.getJavaType())`


Yes, I missed that, fixing now


Hi,
Thanks a lot for the comment. With the change you suggested, I get the following error:
```
    bst = xgb.train(param, dtrain, num_round/25, watchlist, tmpFile );

  File "//anaconda/lib/python2.7/site-packages/xgboost-0.4-py2.7.egg/xgboost/training.py", line 65, in train
    bst.update(dtrain, i, obj)

  File "//anaconda/lib/python2.7/site-packages/xgboost-0.4-py2.7.egg/xgboost/core.py", line 526, in update
    grad, hess = fobj(pred, dtrain)

TypeError: 'str' object is not callable
```
where tmpFile is the filename of the saved model and is the same in every epoch. I am probably doing something wrong -- any ideas?


This is actually suppose to be 'save'


The id column on a model.


IllegalArgumentException


Sorry pour l'orthographe -_-


This seemed like a neat idea. Since it finished yellow at STC, instead of trying individual pieces, you might want check to see if this scales well at LTC.


Does this matter? It should be valid to do `ALL union {...}`, `ALL intersect {...}`, etc, no?


And I will report the new one. Just make your own code or ask @shoghicp to translate pocketmine code. And I don't get why you want to copy pocketmine. PHP7 makes PM like 68 times faster.


TeamCity pull requests :: netty [Build 425](https://garage.netty.io/teamcity/viewLog.html?buildId=2356&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 5632, ignored: 21; resource leak detected (new) Build time: 00:37:39


TeamCity pull requests :: netty [Build 426](https://garage.netty.io/teamcity/viewLog.html?buildId=2357&buildTypeId=pulls_netty&guest=1) is now running


LTC is needed specially the "tempo" value (20) that in LTC failed HARD!

http://tests.stockfishchess.org/tests/view/56158d6e0ebc597e4f23e694

Pls...remove tempo tuning of your patch. It will enter carried by others values in LTC.

Cheers.


This was originally changed to allow staff to join a player using '/sjoin <player>' if they are in the hub. I am working on reqriting everything, as there's a few bugs and I'd like to clean up the Stealth Join feature altogether.


see: https://github.com/ezsystems/ezplatform/pull/57


TeamCity OSS :: Kubernetes Mesos :: 5 - Smoke Tests (docker/mesos) [Build 1059](https://teamcity.mesosphere.io/viewLog.html?buildId=59283&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:35


I've rechecked and this effectively same

    pCode = *(LPVOID*)((char*)pCode + 6 + *(LONG *)((WORD *)pCode + 1));

`DWORD addr = *((DWORD *)((ULONG_PTR)pCode + 2));`
equal to
`*(LONG *)((WORD *)pCode + 1)`

    PBYTE pNextInst = (PBYTE)((ULONG_PTR)pCode + 6)
    pCode = *(LPVOID*)(pNextInst + addr);
equal to

    *(LPVOID*)((char*)pCode + 6 + addr);


ok, in the mean time i had to poke the current code around to support EXTI3 on CC3D.


Please do not use underscore but rather use capital letters to split words. But this is not blocking.


Better name ^^


I don't understand where step affects prepareRange at all.  The only place this comes into play, that I see, is in the `verifyValue()` chain.  While we're in there, is there any reason to put in guards against having a step of 0?


Difference only DWORD is unsigned and LONG is signed.
You can check this leads to the problem?


I don't quite see why the value is being modified at this point. It has already been used within the url, as it is in $_GET, and has been urlencoded.
       `        $plugintabname = substr(strip_tags($plugin->sendMessageTabTitle()),0,10);
        $plugintabs[$plugintabname] = $plugintab;
        $tabs->addTab($GLOBALS['I18N']->get($plugintabname),"$tabbaseurl&tab=".urlencode($plugintabname));
`


@jsenecal I updated this per our latest conversation


Did you use PEP8 autoformat? I think line breaks would be a little bit better for the small screen size most people are working on. Mind adding another commit to multi-line the long lines again?