Well, it's a pretty good start. Thanks for being more motivated to work on this than I am ;) I have a system planned out (well, somewhat) for what code will go where—I think I was planning to split the compilation into its own function—but I can easily rearrange this to fit that system, whenever you're done with it.


HBIRE_vector_take2 (mbadams5) - x86_64-MacOS-10.9-clang: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.57%25-red.svg)


I thought the framework is the fault?

On Wed, Nov 18, 2015 at 2:22 PM, Joshndroid <notifications@github.com>
wrote:

> While I agree with u.. If it's not working at all now u have nothing to
> lose by trying...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/temasek/android_device_samsung_hlte-common/commit/270dc53e9cd1b8a16f471381671eaed5f7758d26#commitcomment-14462935>
> .
>


yeah, I changed my mind, I'd rather this be handled in `preprocess_for_publish`. That way get_person_tags can just concern itself with the "url" property.


Add urls for trace


Missing a `+` between `char` and `']$'`, I think


Whoops, will fix in the next commit


http://www.zhihu.com/question/23378396：（不管用额）
只设置宽度: ![](./pic/pic1_50.png =100x "");

![](./pic/pic1_50.png =100x20)
注意 =前有个空格，可以只写宽度，Mou中支持;


Thanks for the bringing to notice. We'll fix the error in docs. It should be dict and description needs to be changed.

What is the value for state you are trying to set which is giving you the error.


Actually it's just an internal code cleanup, the version bump was a side-effect of my usual workflow, no need to upgrade. Sorry for that... :disappointed:


I also comment out // rePositionSliderNav(); to fix a javascript error


:+1: nice work Flet

*-- Feross from the past*


Ah, I knew that line looked a bit bare. I updated it.

> On Nov 17, 2015, at 8:02 PM, David Roberts <notifications@github.com> wrote:
>
> This line still doesn't do anything. Why dont you try setting the name to something like user.name = "lowercase bloccituser"
>
> —
> Reply to this email directly or view it on GitHub.
>


Arg, *VFS.  Sorry.

-[Unknown]


When I try to download the 2.1.0 beta1 for Windows from https://owncloud.org/install/#testing-development it goes to:
https://download.owncloud.com/desktop/testing/ownCloud-2.1.0.5634beta1-setup.exe
but I get "Object not found!"
@danimo @dragotin


Abhinav, I need this again. How do I make this work?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5652](https://teamcity.mesosphere.io/viewLog.html?buildId=77319&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 190 Build time: 00:08:44
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5653](https://teamcity.mesosphere.io/viewLog.html?buildId=77321&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:13


これは `contentScrollView` じゃなくて `contentView` ではないんですか？


urls for trace is not needed as the user already knows it. also we are not returning it to another function so storing this context in trace is not useful, what do you think?


I wrote a validation line in user.rb to check for capitalization (I believe it's for capitalization of each name). The ran rspec and the tests passed.

> On Nov 17, 2015, at 8:05 PM, David Roberts <notifications@github.com> wrote:
>
> So I like how you wrote this spec.. but this doesn't seem to match the code you wrote. Did this pass?
>
> Look at your code in User. There is no validation related to capitalization. Why you are doing though is changing the capitalization of the name so that all names saved to the database are capitalized in the same way.
>
> —
> Reply to this email directly or view it on GitHub.
>


this works. Why it is not integrated in the maser?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5651](https://teamcity.mesosphere.io/viewLog.html?buildId=77318&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:12:59


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5655](https://teamcity.mesosphere.io/viewLog.html?buildId=77323&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:12


It's a pretty simple start. Feel free to move / modify any code. Hopefully I'm not interfering too much with any plans you have. A portion of the code is borrowed from [another](http://vihanserver.tk/p/temp/JAW/JAW.js) parser that I'm writing for another language.


Please help with my code on prob 11/7 regarding an actual lesson in
codeacdemy playing the paper rock scissors game.

thanks

May Yahweh richly bless you.

*Frenchaire Andrews*

*www.frenchaire.com <http://www.frenchaire.com>*

*www.theenglishschoolhouse.com <http://www.theenglishschoolhouse.com>*

*pizzolimedia.com <http://pizzolimedia.com>*

*whoopuponcancer.org <http://whoopuponcancer.org>*

On Tue, Nov 3, 2015 at 8:25 AM, Nick Apperson <notifications@github.com>
wrote:

> @Frenchaire <https://github.com/Frenchaire> Take a look at @chattyantisoc
> <https://github.com/chattyantisoc> 's solution.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/royclay-tech/javascript-justice/commit/c82de9271eeaa3d4546dab6cb5926d11e3b70c2f#commitcomment-14155267>
> .
>


Tbh, this one has me stumped. I modified the code multiple times but couldn't get the desired result when I created a new user in the console.

> On Nov 17, 2015, at 8:01 PM, David Roberts <notifications@github.com> wrote:
>
> This isn't really how you want to use map. What is the difference between map and each. HINT: can you rewrite this without formatted_array or changing where it comes from?
>
> —
> Reply to this email directly or view it on GitHub.
>


지금은 별도의 바이너리를 사용하도록 되어 있습니다.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5654](https://teamcity.mesosphere.io/viewLog.html?buildId=77322&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 190 Build time: 00:03:10
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


LGTM


`contentView.removeConstraints(contentView.constraints)` ではダメなんでしょうか？ `contentViewLayoutConstraints` が必要には見えないのですが。


no tests !? :)


these can be a constant


`pos = shorthand[pos] || pos` <- avoid duplicate lookup


Yes. Or even a new RPC command.


timepass


It's probably better to do this checking in the form's clean function. @ironfroggy what do you think?


kahi pan naka taku


ah here are the tests ...


I follow the Quick-Start and then appear this,what is this going on?

Creating the project
Please wait while I install dependencies
/home/ynl0zq/Env/env/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/home/ynl0zq/Env/env/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Retrying (Retry(total=4, connect=None, read=None, redirect=None)) after connection broken by 'ConnectTimeoutError(<pip._vendor.requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x7ff311ef0f50>, 'Connection to pypi.python.org timed out. (connect timeout=15)')': /simple/django-cms/
/home/ynl0zq/Env/env/local/lib/python2.7/site-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
Command "/home/ynl0zq/Env/env/bin/python -c "import setuptools, tokenize;__file__='/tmp/pip-build-2lWA2G/Pillow/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /tmp/pip-nCCkrk-record/install-record.txt --single-version-externally-managed --compile --install-headers /home/ynl0zq/Env/env/include/site/python2.7/Pillow" failed with error code 1 in /tmp/pip-build-2lWA2G/Pillow
Failure occurred. Do you want to cleanup by removing /home/ynl0zq/Env/myproject? [Y/N]


You don't want a semicolon here. This semicolon closes the if statement. If you omit the semicolon, the curly braces attach to the if statement, which is what you want.


Same note here.


patience...


punctuation


TeamCity TripleA :: UnitTest [Build 147](http://188.177.191.210/viewLog.html?buildId=215&buildTypeId=TripleA_UnitTest&guest=1) is now running


TeamCity TripleA :: UnitTest [Build 147](http://188.177.191.210/viewLog.html?buildId=215&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:24


I'm unhappy with a bare assert here.  I can think of lots of things that could trigger that, and it'd give an unhelpful error message.


TeamCity Binder Android :: Binder Android [Build 135](http://192.168.1.201:8111/viewLog.html?buildId=240&buildTypeId=BinderAndroid_AndroidApp) is now running


TeamCity Binder Android :: Binder Android [Build 135](http://192.168.1.201:8111/viewLog.html?buildId=240&buildTypeId=BinderAndroid_AndroidApp) outcome was **SUCCESS**
Summary: Running Build time: 00:00:42


TeamCity Binder Android :: Binder Android [Build 136](http://192.168.1.201:8111/viewLog.html?buildId=241&buildTypeId=BinderAndroid_AndroidApp) is now running


If you remove src/wim.tlb assembly will fail.


TeamCity Binder Android :: Binder Android [Build 136](http://192.168.1.201:8111/viewLog.html?buildId=241&buildTypeId=BinderAndroid_AndroidApp) outcome was **SUCCESS**
Summary: Running Build time: 00:00:42


If it's not really a problem then I would think 500 or even 1000. It's large enough where it would appear to be unbounded for all practical purposes, yet there is a bound for exceptional cases. For estimating size, do you know how big is each undo entry?


I get a crash right here because `process.env.NYLAS_HOME`, `nylas`, and `atom` are undefined at this point in the startup initalization.

If I type `global` into the developer tools after an error occurs here and click the chevron to expand the `global` object, there is a segfault for me.


sgtm!
On Nov 17, 2015 9:52 PM, "Kyle Mahan" <notifications@github.com> wrote:

> yeah, I changed my mind, I'd rather this be handled in
> preprocess_for_publish. That way get_person_tags can just concern itself
> with the "url" property.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/snarfed/granary/commit/a4679ea39f36fa51d870574cb3adde1262996c17#commitcomment-14463138>
> .
>


not one of my virtues ;)


Also would be great to have Travis link & CHANGELOG file :)


Has 'true' => 'Yes', 'false' => 'No'
![workspace 1_020](https://cloud.githubusercontent.com/assets/14002337/11233849/b8a15e46-8d87-11e5-9506-8e3a540da359.png)

Has 1 = 'Yes', 0 => 'No'
![workspace 1_021](https://cloud.githubusercontent.com/assets/14002337/11233868/e2227e4e-8d87-11e5-9493-a8daa9a4ee8d.png)

Can't see it in html, but it works without the string because it shows up as 1 or 0
true => 'Yes', false => 'No'
![workspace 1_022](https://cloud.githubusercontent.com/assets/14002337/11233893/32c730a6-8d88-11e5-98e2-452f85710a07.png)
![selection_023](https://cloud.githubusercontent.com/assets/14002337/11233925/85e0fc4a-8d88-11e5-8c19-618244a04cb4.png)

I'm not sure which is preferred. I will change it to the last one and then if you can change it if you want.


HBIRE_vector_take2 (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.49%25-red.svg)


That is also in the asm, you just have to know how to read it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5656](https://teamcity.mesosphere.io/viewLog.html?buildId=77324&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:05:01


ok


i dont know? tema has been busy and has not specified much further


HBIRE_vector_take2 (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (894 of 894 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.19%25-green.svg)


@arturmon I'm sorry, As I mentioned it's implemented part of fix. Will deliver complete implementation soon.


TeamCity Binder Android :: Build Application [Build 137](http://192.168.1.201:8111/viewLog.html?buildId=242&buildTypeId=BinderAndroid_BuildApplication) is now running


TeamCity Binder Android :: Build Application [Build 137](http://192.168.1.201:8111/viewLog.html?buildId=242&buildTypeId=BinderAndroid_BuildApplication) outcome was **SUCCESS**
Summary: Running Build time: 00:00:31


aa


TeamCity Binder Android :: Build Application [Build 138](http://192.168.1.201:8111/viewLog.html?buildId=243&buildTypeId=BinderAndroid_BuildApplication) is now running


To jest źle, nie zwróciłem uwagi ze to do API ma być

W dniu wtorek, 17 listopada 2015 Marta Wyszyńska <notifications@github.com>
napisał(a):

> do którego to jest ticketa?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mauazua/isk2-group-project-web/commit/c826e73a46c2328966119da8324e9e17c4e4e7d7#commitcomment-14456082>
> .
>


TeamCity Binder Android :: Build Application [Build 138](http://192.168.1.201:8111/viewLog.html?buildId=243&buildTypeId=BinderAndroid_BuildApplication) outcome was **SUCCESS**
Summary: Running Build time: 00:00:27


I think the consensus was that this is best as an implementation issue (see http://bitcoinstats.com/irc/bitcoin-dev/logs/2015/11/18 ).  We should definitely mention the issue though: that implementations should use a start time internally based on their release cycle, before which they do not *advertise* the bit.  This avoids worries about premature activation based on people running pre-release code (which I think are overblown, but @gmaxwell was insistent on this point.)


In reality (not like this contrived example), you'd expect actual "service classes" to be passed to those `with:` arguments, e.g.

```ruby
CallSheet {
  map :something, with: Services::MyService,
  map :another, with: Services::AnotherService
}
```


...Me? I don't think that I have ever written this JavaDoc...


thanks for the info. A shift from 12 to 24 also does not work? (The graph shows the normal 24 hours) such as battery power is displayed in 12 hour format.
It is not clear that the test is simple, which should work and where not. ))


Yup I am
Merging caf branch is annoying so I decided just change the version XD


@arturmon Thank you. I forget to fix in battery power graph. Will do it now


Is this correct? '.plugin_access'


I think it is already clear enough to have the "else if" branch. People who have the capability will be able to understand it.


Sorry,

it was an accident, i did not realized that i clicked the wrong button.

2015-11-17 20:57 GMT+01:00 Tres Seaver <notifications@github.com>:

> Why revert? Both of those corrections were correct?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zopefoundation/zope.pluggableauth/commit/a707868c6b28e34c0f11d0365c3378b7086c4d42#commitcomment-14454050>
> .
>


I already fixed and committed this. The appropriate way is to stringify every thing in html attributes. Not doing so is undefined and unpredictable. For me, if the true/false isn't string it won't work, the fields don't update. if they are strings they update. I had this issue before actually and fixed it already (this is actually a duplicate issue in that respect). As for the 1/0 they work either way just not ternary being the issue.

The stringify rule, that was from back in I think html 3.1 or something like that. Its been the common, best practice and rule for nearly a decade now. Some browsers actually ignore non-stringfied attributes which is acceptable according to W3C standard.. now, the next question is single quote or double quote ;) I prefer single if you haven't noticed. It's easier to type for me. Both are acceptable.


I found KUBE_MASTER referenced in cluster/kube-util.sh and hack/ginkgo-e2e.sh.


А он не умеет селекторы `:disabled`.


:+1: many thanks!


I see, thx.  I also found out that the bundle identifier used in xcode is following RFC1034.
And RFC1034 does not allow subdomain name starting with a number, e.g. com.example.123app is not  allowed.

Thank you very much.


@arturmon this will make battery power to fix 12 hours/24 hours https://github.com/mycontroller-org/mycontroller/commit/b1c39de5d020ae1026a1a4e7fc9770e079f68a7a


oO <mul ?


@chken007 git is not good at handling binary files


yepyepyep


kube-util.sh is a toy to my best knowledge.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.798](http://teamcity.monogame.net/viewLog.html?buildId=11467&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Don't worry. I'll fix it from here

Sent from my iPhone

> On 18 Nov 2015, at 00:15, randaz81 <notifications@github.com> wrote:
>
> This is really puzzling me, because on my pc I see the correct capitalization on my local folder! Even more interestingly, if I try add another new file to this CORRECT folder, the commit log shows that a WRONG lowercase folder is used. I can only think that something got corrupted on my local repo, sorry...
>
> —
> Reply to this email directly or view it on GitHub.
>


@andibraeu ja, genau: und in Zeile 185 wird auf '1' getestet:
```
[ "$( uci -q get system.@vpn[0].enable )" = "1" ] || {
```


It might be worth `export` though.


no more suffer from manual edit, options annotation


Fixed https://github.com/sindresorhus/ava/commit/305fcdb4b3045924a11ca9b93e2281fdff430084


@chken007 You know this is open to public right? :sweat:


Dammit, I wish I'd noticed this before I merged the PR – renaming method names is an API-breaking change, for no good reason.


@branch-predictor , I think the logic of chain_getxattr is every reasonable. so could you pull request to ceph first?


why value is compose via concatenation instead of $value?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5657](https://teamcity.mesosphere.io/viewLog.html?buildId=77325&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:04:48


I actually don't agree :)

Reading code isn't about the capability to execute it like a computer :) It's about making intent and specific situations clear.

When I read the current version and read ```else if *enforceTableACLConfig```, I must go up again first to find out that we're in the branch ```tableAclConfig is not empty``` now and then combine that with the new condition ```is enforceTableACLConfig``` set.

Instead, my proposal would be more readable and it would make your intent much clearer: You want to catch that specific situation where the config is enforced, but it was not set. On the other hand, the ```tableAclConfig is not empty``` branch is about a different situation: It's an init block for the TableACL config. These are two different situations and therefore I would like to have them separated.

I admit it's a nit though. But you also have to admit that it doesn't hurt to change it as proposed ;-)


@cached is never set to true, so this entire change is never invoked. I think.


А почему рефаторинг повлиял на это тест?


Похоже строчка лишняя.


where were we calling parse with internal versions? should we be constructing `GroupVersion{}` there instead?


I guessed numbers up and down and found that this downloads:
https://download.owncloud.com/desktop/testing/ownCloud-2.1.0.5633beta1-setup.exe
5633 rather than 5634


ASSERT(!path.empty(), ());
?


all of field options should be added


:-1: for this change


When there is no restart count label, it should return 0 silently. While in this commit I return "" and will cause Atoi return an error. It makes a log of error log generated in integration test.


`gvk.Version`?


Давай поставим ASSERT-ты на согласованность пред условий? Например, startK < endK, endK < buffer.size() и т.д.


`parentGVK.Version`


findall rely on [regular expression], so abandon


This is a test file, I need to delete it.


kahi pn ka??


Надо бы ASSERT(!buffer.empty(), ());


`gvk.Version`


lgtm


With the addition of `def message(node)` here, it seems that calling `add_offense(nil, some_expr)` will cause  `undefined method 'parent' for nil:NilClass` in the nested case here:

https://github.com/bbatsov/rubocop/blob/b5776f72d656418b5e2167d10b4d0711bce9dd53/lib/rubocop/cop/mixin/autocorrect_alignment.rb#L37


I'm not sure if we already need this `Shell` command subclass.
Sure they are all shell commands, but can you think of any kind of command you want to execute that can not be executed on the shell as well right now?

`CLI` is also bound to the command interface at the moment.
The [error message](https://github.com/JanOwiesniak/duty/blob/038a4ec9b606fcd554499101fafc1b0b6de20acc/lib/duty/cli.rb#L178) calls `cmd`, `pwd` and `error` on the command to build up a verbose error message for the user.

This means right now every other command subclass needs to implement these 3 methods.
But does something like `pwd` make sense on other subclasses too?

If you convince me and we continue with this approach, we should unify the command error message interface so that `CLI` only makes one call to `command.error_message` instead of 3 calls to  `cmd`, `pwd` and `error`.

Convince me by naming just one other kind of command you would like to execute that is not reachable via the terminal :)


@mkodekar I didn't see :p


s/version/gvString/, as above


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.798](http://teamcity.monogame.net/viewLog.html?buildId=11467&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 552, ignored: 6 Build time: 00:20:05


Current stable version is 1.0.6 :)


Could you clarify what "may work or not" means here? Is this for Qt4 vs Qt5 compatibility? (AIUI Qt4 is always built with ```/Zc:wchar_t-``` on Windows while Qt5 is not).


When is this path possible on Windows? mingw?


额，buildToolsVersion是改错了吗？


HBIRE_vector_take2 (mbadams5) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-79.96%25-red.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-58.25%25-red.svg)


А на фига оно тебе, когда класс disabled есть?


cool!


Thanks for pointing that out, I will update the necessary attributes.


Он не мешает ткнуть в кнопку и послать запрос.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5660](https://teamcity.mesosphere.io/viewLog.html?buildId=77332&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:12:34


Congratulation for youy great work.

I need this work compatible with python 2.7. It is posible?

Thank you very much.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5659](https://teamcity.mesosphere.io/viewLog.html?buildId=77331&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:12:52


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5658](https://teamcity.mesosphere.io/viewLog.html?buildId=77330&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:13:09


А ты и то, и другое поставь.


@victorpopkov  thanks for reminding.

> In that case, we have to remove it.

I agree.


Ну это как-то вообще неторт.

Да и тут проще вернуть `a.btn.btn-default.disabled Магия` как и было.


uh... why is it in here not the `tests/` dir?


Agree. My implementation was to complex and you approach is much simpler but i think it is still not in the right place.

How about extracting the boot process into a factory method?

`duty/lib/duty/cli.rb`

```ruby
module Duty
  class CLI
    def initialize(args)
      @args = args
      @registry = Duty::Commands::Registry.boot(additional_command_dir)
    end
...
```

`duty/lib/duty/commands/registry.rb`

```ruby
module Duty
  module Commands
    class Registry
      COMMAND_NAMESPACE = Duty::Commands

      def self.boot(additional_commands_dir = nil)
        new(additional_command_dir).tap {|r| r.require_all}
      end

      def initialize(additional_commands_dir)
        @core_commands_dir = __dir__
        @additional_commands_dir = additional_commands_dir
      end
...
```


Да магию можешь вообще пока не трогать, я не знаю, зачем её понадобилось менять.


As said before: https://github.com/xbmc/xbmc/blob/master/xbmc/cores/AudioEngine/Sinks/AESinkPULSE.cpp#L542


Interesting point. I echoed the `makeSlice` for `std::vector<T>`. Open to hearing some feedback here: should we be strict here and use `std::int8_t` and `std::uint8_t`?


IRecieverを持ってるオブジェクト全てに処理をおこなう


Close https://github.com/ant-tool/atool-build/issues/4


For what it added?


I do not understand these scripts well enough yet to pass judgement on that.


SceneManagerに自分を登録。
他のオブジェクトも共通処理なので、将来的には継承するか別の手段で。


谢谢，这样写的确代码更可读


For the future I think it would be best to do without the absolute path here, in case someone creates a package and installs juci to /usr/bin instead.


Agree on this one.


增加内容


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5661](https://teamcity.mesosphere.io/viewLog.html?buildId=77333&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:08:27


demo trang web ngân lượng và tìm hiểu


I've made the change. It does no harm any way.
Yet it's likely that we cannot run e2e w/o more configuration


謝謝, 後續再一起改善後面的部分 :)


额，确实是，感谢提醒！


ack


why generic?


请问恶趣味额


Ok I've tested it with the following repo and it seems to work : https://github.com/lemelon/cozy-front. I wait for further recommandations.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5663](https://teamcity.mesosphere.io/viewLog.html?buildId=77335&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:07:23


Where did you go bro! :)


wien ich im asana gschribe han, isch s'problem dass im file PdfGenerationService bim xmlConverter s'ExpenseItemPdfDto nid im usgebende xml erschint...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5664](https://teamcity.mesosphere.io/viewLog.html?buildId=77336&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:51


can you publish the benchmark results with this change for all the queue types?


。Async和Sync 我傻傻的没分出来。很容易混搅吧
。参数可不可以再简单点，`headers`可以有重载个有默认值的
。异步我的场景暂还用得很少吧，或者再独立个类出来，而不是通过方法重载？（我随便YY，供参考）
。如果想获取`Http Code`怎么弄？
。可以有测试用例吗？

@welldragons 我们`JSON`处理准备用哪个工具？


We cannot test interfaces, and we don't want to anyway. The purpose of the unit testing is to test an implementation. Because the interface is not an implementation, thus we don't test it.
An abstract class is somewhere in the middle, we cannot test it directly unless we use some mocking library. But this one we haven't checked yet.

In the end, if we have 4 different implementation for the calculation (+,-,* and /), then we need to test them one by one, method by method (public methods normally, maybe package protected).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5662](https://teamcity.mesosphere.io/viewLog.html?buildId=77334&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:10:48


确认需要meteor add check


oh... may i mis-placing it


I'm not sure if you named this method by mistake? :)
```junior_project_managers``` and inside ```roles_between(['designer/UX']```


Someone does not want to test POJOs, or setter methods. Personally I like to test them. But there is no hard opinion on it.


Is there any public paper that can be linked? I would love to read it.


@bblackham thanks, sounds good.

I actually considered the issue with dir_exists messing up errno, but when I tested I couldn't actually trigger it (I still got "file exists").  I was just doing some quick testing though, so it is quite possible that I made a mistake.


HBIRE_vector_take2 (mbadams5) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-73.88%25-red.svg)


ummm, maybe we should change this to:
Future.collect(queries) map { results => results.flatten.distinct }


twitter-server pulls this in, i think


unfortunately, the use of this new API breaks Win7, which has a rather big installation base :/


đọc file đầu vào


Wouldn't you need the whole filedescriptorSet is?
What happens if your message has a field of type message, where that message is defined in another file?


ok. In the evening I will be tested. Suggestion: Maybe we should write more fully that the addition of comments to commit? For more accurate testing and identifying problems.


Ja da war ISO encoding. Warum auch immer, die Files habe ich ja gestern vom Fablab-Share gezogen. Offensichtlich hat jemand mal was in Windows an den Dateien geändert?


đọc file đầu vào, lấy các giá trị N vào biến N, N từ tiếp theo vào StringBuffer arr.


See a copy paste description about the Error below. but in short, the Throwable is parent of any difficulties in java. It has two child classes: Exception and Error. A quite hard rule, normally we never try to deal (catch, throw, etc) with the errors. Only the exceptions are our playground. An error might be out of memory error. We should not create such an error, the JVM should throw it when unfortunatelly needed.

"An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch. Most such errors are abnormal conditions. The ThreadDeath error, though a "normal" condition, is also a subclass of Error because most applications should not try to catch it.
A method is not required to declare in its throws clause any subclasses of Error that might be thrown during the execution of the method but not caught, since these errors are abnormal conditions that should never occur. That is, Error and its subclasses are regarded as unchecked exceptions for the purposes of compile-time checking of exceptions."


Nice cleanup.


I think it will.  I have been generating such "conflicting" functions for years now and have not had any complaints.
Maybe I am not understanding your counter example?


@arturmon Sure, I will add in detail in further commits.


so sánh lần lần lượt các từ trong arr với các từ còn lại phía sau nó.
 với mỗi lần so sánh, kiểm tra tính đối xứng,- đưa ra kết quả


spravne


Download the project.
![riyas_driving_license_india_frontside](https://cloud.githubusercontent.com/assets/574416/11234960/682870d0-8de6-11e5-9c00-17effe981c68.jpg)


kommen da noch funktionsfähige svg-files raus?


Try to have separated test file for each class. If you have AdditionOperation, then have an AdditionOperationTest class for it. Do not merge its test with others classes' tests.


test


When my browser run into this line of code, it says: '**Uncaught TypeError: this.state.records.filter is not a function**', and gave a mark of red underline under the code:
```
credits = this.state.records.filter(function(val) {
  return val.amount >= 0;
});
```

I don't know what was going on here.


我比较倾向于流式的API，headers、nameValuePair这些东西可以自由组合
现在这个比如doPostFormSync，如果我没有header只能传个null


Name naming, short, compact and clear test case. This is how a good test looks like.


you need `:format        :json` here


If Mixxx and the called code in a library share the same /Zc:wchar_t flags, you can use wchar_t.
If not, it depends on the function interface.


Nice usage of the "expected"


Yes, I wanted to keep the default behavior the same, because you mentioned memory usage in the readme. I've been setting the @cached to true when I need to, but should probably add a setter function for it.


I was using it in very custom Lua 5.3, I can't remember what was happening.


@welldragons 那现`okhttp`提供的API，我们只需要创建个工厂方法应该结束了？


LGTM


typo in the commit message


Not the golden carrot block.
On 17 Nov 2015 17:14, "ZenaGamingsky" <notifications@github.com> wrote:

> in mcpe
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/PocketMine/PocketMine-MP/commit/b758cfb2de33df277d57d13076089d541304a5d2#commitcomment-14449777>
> .
>


what about these barks?


Windows will use the first branch, unless Qt changes the size of QChar or windows changes the size of wchar_t
This condition is used inside the QT source as well.
Normally Linux will not use the first branch since sizeof(wchar_t) is four, but any distro is free to change this.


You're right! Please give pass :smile:  Thanks!


Hound doesn't handle ES6 javascript syntax :smile_cat:


我们可以深入了解`okhttp`的调优配置。
他的代码实现及API还是非常优雅的。

@spec1131 你可以深入挖掘下。
例如`http connection pool`等等。
抽空，可以给我们分享分享。


Ah, ok! :smiley:


My bad, how can i reach you


Could you please change the comments above that strings as well to reflect the new wording?


yes, this is correct.

When I was asking around and looking for Component projects to get developers feedback on Component, I saw lots of methods _inside_ the Components. This is happening because Component adds another dimension to simple namespace/function codebase primitives.

However I agree with you, and stand corrected, as this is not a valid "problem" about Component itself, but mostly about "an additional door" of accidental complexity Component opens.

The "code navigation" bit is hard to express verbally. It _is_ one of the problems though. I changed the section description. Thanks for brining it up.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5665](https://teamcity.mesosphere.io/viewLog.html?buildId=77337&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:38


Nice! Skal jobbe litt mer i morgen kveld, drar denne inn da :)


is this correct ?


Private is `__showImportSourcesDialog` not sure you understood what I meant.


Смущает то, что параметр b необязательный: можно получить "Я попал в undefined". @o0, насколько важно в этом задание отработать все исключения?


So regular, conflicting styles are quietly removed, shouldn't we raise here some warning?


Полагаю, что проверки только на object мало, так как {} тоже вернется object. Можно дополнительно проверить через Array.isArray (работает, начиная с IE9 — полагаю, что этого достаточно).


This commit does not belong to this PR. please remove it.


@MayGrass OK


// 1 – Add array of personal quotes
self.myQuotes = @[
@”Live and let live”,
@”Don’t cry over spilt milk”,
@”Always look on the bright side of life”,
@”Nobody’s perfect”,
@”Can’t see the woods for the trees”,
@”Better to have loved and lost then not loved at all”,
@”The early bird catches the worm”,
@”As slow as a wet week”
];


@Zidane Then we should rather make the nit tests output less, IMO


@YYSU OK


Looks like debug code which was committed?


服务端上传插件


@s102213038 ok


@102213043 ok


По спецификации функция должна вернуть строку в любом случае. Придумай сам сообщение, которое будет возвращаться, если переданные параметры не подходят под заданную логику.


die neue Zeile sieht aber so aus

```[ "$( uci -q get system.@vpn[0].enable )" = "off" ] && {```


esse é o segredo de funcionar o bind no c#?


@Jaywier ok


We have already a string and a max_length. What is the reason for copying it?


Fixed this by just initializing a new random keypair.


Её наработки уже залиты.


Looks good. I just feel that "damage" does not make it really clear what this is about (unless one reads this comment of course). Maybe something like "nonblockableDamage" or "absoluteDamage"?


diff from hell :sob: :gun:


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.585.53bdce57f1f1d78f7d54b9203bb23de1d3daf3d1](http://build.palaso.org/viewLog.html?buildId=66289&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3310, ignored: 125 Build time: 00:08:00


overrideTextNode --> processTextNodeContent ?


`var isBodyElementWithChildren = el => el.tagName && el.tagName.toLowerCase() === 'body' && el.children.length;`


So noted.


Тут и далее: не желательно объявлять в функции параметры, которые ты используешь, чтобы не сбивать других разработчиков. В данном случае тебе нужно только значение элемента массива, поэтому пусть будет просто `function(item) {...}`.

Так же посмотри на метод по работе с массивами reduce: он сюда хорошо впишется.


这个只是初始构建。我先放上来看看有什么槽点，找一下方向。
异步调用的可以另封装一个类。Http Code，我还没想好怎弄。直接返回Okhttp Response对象，或者自己封装一个Response对象。前者暴露了内部细节，后者比较low而且有点画蛇添足。
测试、注释会在差不多之后再搞。
Okhttp本身就是链式风格的，而且也没什么难度，直接拿来用也不错。我觉得除了它的异步调用，封装一下比较好。别的直接拿来用也未尝不可。


How about `data.length==0`? return a empty string?


Нужен пробел перед открывающей фигурной скобкой.


Нужен пробел после запятой :-).


Variables declared without `var` are implicitly global. Please make sure you don't poluate the global scope. In case you do want to declare global variables  (eg: namespaces) make sure you declare them using `window.my_varible` so your intention is clear. Please check other variables in this file.


Давай операторы (`*`) отделять пробелами.


No game//activity for checkout. I'll do screenshots and stuff early tomorrow morning.


I suspect you're right!


that said, got the blurbs written, and one mini-logic-game written. Next is making the content for it.


I will add require to maven

I just added the image for a Q&D, it is supposed to be removed or put on "etc/images" if it is keeped

Aggree to "etc" dir.


Agree. This is just how the code was.


Agree


In this line of code, as well as follows and the next section, `@state.records` is not `Array` but `Object`.
So in my browser, something went wrong here, which means `filter()` and `slice()` function cannot run.


That variable should be removed


this is a test


I think you could use `clusteredCache.putAll(cache);` for more compactness.

And we should use generics (`Cache<K, V>`) eventually, but that can go in another commit.


Yaay!


非常感谢，我第一次完全的墙外精力就是靠的goagent


Hello @panozzaj. The problem here is that I wanted to finalize the `react-blessed` version of the project before linking towards it because otherwise it could mislead people.


option 4 doesn't work with google.com
because they don't have registrant name
unless you type google.com.sa or google.com.co


s/CIRCLE/CYCLE


🍆
Op 17 nov. 2015 14:15 schreef "Jim van Abkoude" <notifications@github.com>:

> ok vriend
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/loljimmo12/PTMain/commit/8520c212684a4e93545496ecca20ea5512dec37b#commitcomment-14442718>
> .
>


Opps. Sorry It will be removed


What code style do you follow?


> to call all remaining listeners that will do nothing

That's exactly the point. You cannot be sure that they will do nothing.


Formatter sessions may not be rightfully closed on error exit.
Fixes: #13711
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>


500 or 1000 seems way too big for me, - if one wants to possibly trade in that much memory then I think it should be an explicit thing. When was the last time you needed to undo 500 times, let alone a 1000? The size of each entry will vary of course, as it depends on the operation. Large deletions/insertions will take up proportionally more space than a small operation such as inserting a single character. Also, since undos can be grouped, and each group counts a one revision towards the limit, that means the sizes can vary even more. I don't believe the meta data itself is that big.


Please put these new tests in a new test file, e.g. sequence_gp.sql/out. Because the sequence test is currently almost identical to the upstream test, and I'd like to keep it that way, to make merging/diffing easier.


Цей метод явно стосується тільки контактів. Тому небачу сенсу з нього в цьому класі і його наслідування іншими. Для перевірки належності запису конкретному юзеру варто зробити такий метод в моделі і назвати його універсально.


麻烦问下，安卓的分享或支付成功后，返回应用时，提示 应用停止运行


On [this](https://github.com/pbs/cmsplugin-profile/commit/275f61bcaa5f1243367669baede283a57fc7ec75#diff-b51ed31410a65618b2180199d937e970R475) line: Django removes the jQuery object from the global scope. Make sure you have a fallback for this : `jQuery || django.jQuery`


Maybe, this is a sign that we should continue our work on this project. :)


What's the point of this test? A comment would be nice


Das ist @xmorpheus Entscheidung


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5666](https://teamcity.mesosphere.io/viewLog.html?buildId=77338&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:26


Do you mean a generic MIR visitor that allows for mutating the visited MIR? I was already thinking something like `fold` would be a good match for something like this task.


Maybe it would be better to return after you have deleted self.data?
This way when recompiling we would not output any data for 0-contour glyphs, fixing the original issue.


See the comment about wcslen -- that's the only reason for the copy.

On Tue, Nov 17, 2015, 11:37 PM Daniel Schürmann <notifications@github.com>
wrote:

> We have already a string and a max_length. What is the reason for copying
> it?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mixxxdj/mixxx/commit/a2e6864793dc366b49202fb0aa191d2b79f0e9e4#commitcomment-14464507>
> .
>


Utilisez les relations que vous avez définies:
```php
$tournament = Tournament::with('equipes')->find($id);
return view('Pages.createGroup', compact('tournament'));
```

```
@foreach $tournament->equipes as $equipe
    {{ equipe->id }}
@endforeach
```


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.567.53bdce57f1f1d78f7d54b9203bb23de1d3daf3d1](http://build.palaso.org/viewLog.html?buildId=66288&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3289, ignored: 106 Build time: 00:27:47


I personally would like to keep the User.current.login line here, since this is by definition the current acting user. If the model is not doing it's job as expected it would be good if session[:login] would be in sync.


Si il manque des parenthèses.
Là il va te faire
nouveau suivi
ET statut clos ET statut autorisé ET statut réouvrable (ne sert à rien avec la première condition)
OU demandeur ET pas tech
Tu devrais avoir une parenthèse englobant les 2 première conditions qui vont ensmble et une pour les 2 suivantes
if (is new
    && ((in array statut clos
            && statut autorisé)
           || (demandeur
               && pas tech
               && in array statut réouvrable)))


`href="#"` et vous pouvez enlever l'attribute `style`.


does this actually work? I've had some problems with loading the translation files like this -> it was to slow at initialising


There's a typo here ("ckeck"). Didn't check if you fixed it already, though.


You most certainly can in the example of insert tags. Compare it to the route listeners. If one `->supports()` the type, then no other is asked. You need to use priority if you want to override something (and you should not use priority by default as usual).


yep, this breaks build:
CPP     xbmc/cores/AudioEngine/Sinks/AESinkPULSE.o
Sinks/AESinkPULSE.cpp: In member function 'virtual bool CAESinkPULSE::Initialize(AEAudioFormat&, std::string&)':
Sinks/AESinkPULSE.cpp:547:25: error: 'AEAudioFormat' has no member named 'm_encodedRate'
     samplerate = format.m_encodedRate;


>>    Is there a reason you didn't use $# instead of - 1?

> No reason other than them being both equally ugly constructs.

Using `$#` is better here because it means the last index, which is exactly what you want to express here.


add this to the index function as well, just in case I want to use it later ;)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5667](https://teamcity.mesosphere.io/viewLog.html?buildId=77343&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:38


@randaz81, to deal with case related issues in git for Windows, try to insert the following option in your `global` config file:

```yml
[core]
    ignorecase = false
```

It might help.


At this point, AFAICS the actual sequence has already been incremented, by the cdb_sequence_nextval() call above. That doesn't matter as far as this transaction is concerned, but I wonder if there's some global bad consequences of this. A comment pointing that out and noting why it's not a problem would be in order at least.


@contao/developers What do you think?


Looks good to me.


Це якась страшно замутна логіка. Треба переосмислити і спростити, не може парсінг контроллера, екшена і параметрів так складно вираховуватися.


Never mind. Looking at cdb_sequence_nextval(), it doesn't increment the sequence when it hits the ceiling.


A pstrdup() would be simpler than StringInfo here.

Actually, there is no need to close the relation before calling ereport() at all. Transaction abort will automatically release any locks. So you could just remove the relation_close() here, and pass RelationGetRelationName(seqrel) directly to ereport.


Err.  Right.  Though it's a bug that the earlier branch "if not self.data" doesn't do it.  But not going to touch it now.


That is actually very discussable.


But why? This file is generated by eclipse and a pre existing one always made it hard for me to have the same project on multiple machines with different eclipse setups


Not sure what @jbenet intended here, but I can't think of anything that needs to be added at the moment.


Fixed.

Would be nice to fix the other one too.  self.data lingering around after recompile results in bugs very tricky to debug.


Why is this nullable?


Missing gaveHQWater = true there.


If you want a more detailed version of the commit message:

* get_next uses faster method calling.
* size is used instead of length because of some benchmarks I ran. They showed that size was about twice as fast as length. If someone wants to prove me wrong, go ahead.
* Removed repeated method calls by defining variables like r[:full_name].

These changes, again, do not solve our bulk problem. However, it never hurts to refactor for performance. There's still a lot of work to be done for performance.


This looks great! Do you mind opening a PR for that?


CentOS 7 wasn't added for 32 bit.


啥？


I theory trim should catch more then just usual space: tab space, \n\r or \r\n and maybe some others. Users may copy past those to the field.


When someone will clone or project and import it into eclipse it's necessary to have a .project file for eclipse to find the project


@ximex there are problems with new datatables version. There is an js error and because of this no table is shown correctly.


Я б назвав ці змінні шоб було зрозуміло що це.
$controller = 'contacts';
$action = 'index';

$controller = new ucfirst($controller)();

$controller->$action($arguments);


No, they just have to import it as an existing maven project


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5668](https://teamcity.mesosphere.io/viewLog.html?buildId=77344&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:11:39


Trying to run an NPS simulation session with more than one aircraft doesn't seem to work anymore after this change.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5669](https://teamcity.mesosphere.io/viewLog.html?buildId=77348&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:48


#6 solved


Для чого змінна $variables?
Хіба екшн котроллера повертає якісь значення?


Is browser.css!!!!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5671](https://teamcity.mesosphere.io/viewLog.html?buildId=77350&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:02:26


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5672](https://teamcity.mesosphere.io/viewLog.html?buildId=77351&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:46


ack


(see https://github.com/coala-analyzer/coala/issues/1061#issuecomment-157638537)


so it really looks like the classloader does not load META-INF/* files but all other files. with jruby-9k the snakeyaml is loaded as ```require 'snakeyaml.jar'``` which means it is a different classloader.


I added this because it seemed like it was freezing on a test, and without having a consistent order, it's hard to tell which test it's on.  Turns out it was just my cellphone internet being slow.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5670](https://teamcity.mesosphere.io/viewLog.html?buildId=77349&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:09:28


Was thinking we could also do it as before for HTML and return an Array of elements. What's your suggestion here?


:+1: Scissors of Honor is just some clan my second account was hanging out in :+1:


Should add a color


ffmpeg typo


Hm.


Without knowing the history, it's not clear why this might throws such a NOTICE. Also, this doesn't actually test that the auxiliary relations shrunk, just that the VACUUM FULL ran. I'd suggest rewording:

Create some dead tuples, and test VACUUM FULL on the AO/CO auxiliary relations. (There used to be a bug where it didn't do anything, and you got a NOTICE saying a transaction is in progress instead.)


Is this really better? The file names we use are in the source document now. Seems unlikely we'll change them again.


why exactly did this break anything?


We build it using gitdown: https://github.com/imatix/gitdown

Just tried and it gave errors so something's broken. That's the normal way
though ('gitdown README.txt')

On Wed, Nov 18, 2015 at 3:43 AM, Patrik Wenger <notifications@github.com>
wrote:

> Just made a bunch of improvements in README.txt. I'm about to create a PR.
> But how to regenerate the README.md?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/imatix/gsl/commit/cf70750cce76f682bf4b7d00def41221b8630989#commitcomment-14461401>
> .
>


no need to iterate. Just: `$('.has-error, .error').removeClass('has-error').removeClass('error')`, jQuery will handle this.


good job


カンマ(,) が抜けているようですが、テストは通るのでしょうか？


あ、このあたりは未だ実装中です。


Will have a look at this... give me one day or maybe two ;-)


You have the copyright on this file


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5673](https://teamcity.mesosphere.io/viewLog.html?buildId=77352&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:32


Add some doc to explain what value is


Add some doc to explain what HostPort is


I know its only API Client and someone writes it at first. But it is so ugly "ifif  try catch nested" method that I just have to manifest my disgust here.


maybe just a driver bump
http://www.nvidia.com/download/driverResults.aspx/95154/en-us


I know it's ugly. Unfortunately `AggregateKind::Closure` contains a `&'tcx ClosureSubsts` and creating a new interned `TyClosure` was the only way I found to get a `'tcx` reference to a closure substs.
An alternative would be to store a `TyClosure` in `AggregateKind::Closure` but then you'd always have to match on it everywhere, although you already know what variant it is.
If you know of another way of getting a reference to a `ClosureSubsts` with `'tcx` lifetime, let me know.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=9)


`else` should be on the same line as the closing bracket


A VS2015 user reported this to me in the first place. They were trying to build it and were getting errors regarding those symbols. I personally use VS2013 though, so I'm not sure.


update to 304.131 will follow today, @milhouse please change PKG_VERSION to 304.131 and test


When will these files be released?


Are you sure you can assume 2.4GHz and 5GHz on all MacOSX hardware?


info about passthrough streams has been moved: https://github.com/FernetMenta/xbmc/blob/master/xbmc/cores/AudioEngine/Utils/AEAudioFormat.h#L65


It's prefered to have only one `var` keyword per scope


Hmm, tohle je zajimavej commit, prostudu dukladneji. Ale na prvni pohled, tohle funguje? ( ~test<>>p[\out]; ) Pokousel jsem se <<> nebo <>> pouzit uz nekolikrat tak aby nebyl vstup \in jako default, ale vzdy jsem to rval do kulatych zavorek jako arg pro funkci a to nebezelo. Zajimave


Working with channles only is dangerous as there are overlapping channel numbers in some countries. Are you sure you don't have frequency available?


HBIRE_vector_take2 (mbadams5) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.49%25-red.svg)


Please declare all your variables at the top of the function.


What's this? Objective C?


Should be bool? ;)


They already are in 5.0.9. ;)


Jason, what the hell is this for?


Anothe ugly nested method


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.586.1a851e802fd2a6b7dd3a2aa0f2e1a5ef1e803531](http://build.palaso.org/viewLog.html?buildId=66292&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3310, ignored: 125 Build time: 00:24:44


no need to iterate


Having `.DS_Store` files under source control is kinda strange.


Is this necessary? On Linux horst tries NOT to interfere with existing connections


Apart from that, everything else seems okay. I'll give it one more look and merge


Allow all?

What are the chances they'll start blocking apps right away and complain it's too hard since they're too many and they don't know which ones should be blocked or not, and so on.

Yes, some will go to `Menu->Settings->` but... M0r0n control


Typo here: `REOUSRCE` -> `RESOURCE`.


Good!


Please not. I explained above why we fail silently.


I would say that `evalMain` should belong to tests. It has a bunch of assumptions that aren't very general, to be honest.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5675](https://teamcity.mesosphere.io/viewLog.html?buildId=77354&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:17


What is the purpose.


I can't say that I like the notions of `MainXXX` be in the core part of the interpreter. Can this be implemented differently?


What's `Anonymous`?


なぜ＋１６にならない？roundupできてない？


no need to wrap the condition in `()`. You can however wrap the whole ternary operator expression.
`(condition ? expression1 : expression2)`


(Y)


kay! i thought my previous commit didnt work but it eventually did.. so yea, just ignore the second comment unless you guys want to read it.. lol


I don't know what the underline cause is, but IDEA needs constructor for `ModuleType` for create project action.


There were enough complaints in the Play store to change this. If this will result in more complaints I will change it back. Note that I have added upgrading as well (storing the current version), so we can now update things like settings easier. iOS does allow by default as well.


a.frames.size == b.frames.size && a.frames.keys.forall(k => b.frames.contains(k)

aren't there any setEquals(a.frames.keys, b.frames.keys)


puff


I mean for characters having the old quest "Training Center: Talk to Lisa". I think you should handle these somehow, otherwise it might result in some weird quest states.
Like ```delete from `quest` where `quest_id` = 2299;```


missing `var` keyword


OK


what happens when pair contains CssEntry & CssStyleEntry (in any order) ?


it's a long time till legion :D thank you for all your work


absolute damage looks better, indeed.


> Using $# is better here because it means the last index, which is exactly what you want to express here.

Yeah, that's true.

You know what's surprising? Using `@{$self->{foo}}-1` is between 5% and 15% quicker than `$#{$self->{foo}}`:

```perl
#!perl

use strict;
use warnings;
use Benchmark qw( :all );

my $self = {foo => [1,2,3]};

cmpthese(
    10000000,
    {
    var => sub { $#{$self->{foo}} },
    idx => sub { @{$self->{foo}}-1},
    }
)
```

```
:!perl /private/tmp/bm_lookup.pl
          Rate  var  idx
var  9523810/s   -- -12%
idx 10869565/s  14%   --
```

I wonder how `$#` is internally, looking at it through B::Concise it seems that `$#` introduces another op:

```
> perl -MO=Concise -e '$#{$self->{foo}}'
a  <@> leave[1 ref] vKP/REFC ->(end)
1     <0> enter ->2
2     <;> nextstate(main 1 -e:1) v:{ ->3
9     <1> av2arylen vK/1 ->a
8        <1> rv2av[t1] sKR/1 ->9
-           <@> scope sK ->8
-              <;> ex-nextstate(main 2 -e:1) v ->3
7              <2> helem sKM/DREFAV,2 ->8
5                 <1> rv2hv sKR/1 ->6
4                    <1> rv2sv sKM/DREFHV,1 ->5
3                       <$> gv(*self) s ->4
6                 <$> const(PV "foo") s/BARE ->7
```

Compared to:

```
> perl -MO=Concise -e '@{$self->{foo}}-1'
7  <@> leave[1 ref] vKP/REFC ->(end)
1     <0> enter ->2
2     <;> nextstate(main 1 -e:1) v:{ ->3
6     <2> subtract[t2] vK/2 ->7
4        <1> rv2av[t1] sK/1 ->5
-           <@> scope sK ->4
-              <;> ex-nextstate(main 2 -e:1) v ->-
-              <1> ex-helem sK/2 ->-
3                 <+> multideref($self->{"foo"}) sK ->4
-                    <0> ex-gv s ->3
5        <$> const(IV 1) s ->6
```

Interesting! If we added an extra assignment to an intermediary variable, as @bambams suggested, if would be even "slower" (5% on 10000000 ops/s is not exactly slow, but nonetheless). But ultimately i'm not bothered because, as i said originally, they're both equally ugly constructs the represent the same thing. It turns out the the way i chose to do it turns out to be more efficient and you could argue that using `$#` actually turns out to be *worse* not better.

I don't think any of this matters, this PR is stale any and will likely never be merged. If the owner of the repo, or anyone else for that matter, wants to tweak the PR i'm happy for them to do so.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5674](https://teamcity.mesosphere.io/viewLog.html?buildId=77353&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:16:47
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Hi! Looks OK in general, but please look at my comments above and please follow the coding style that is used in the rest of horst (spaces and intentation). If this is a objective C file maybe it should end with .m? (not sure, I dont know OSX and Objective C). Then please make a new pull request for the code changes only. If you want you can make another pull request for the complete CMakeLists.txt. I don't mind adding it if you need it.


Why do we need `Main` here?


Thanks


Given that this case class now can contain a whole range of native values, I don't think it's `Literal` anymore.


For me, both are fine.


Hmm. Where did the newline go?
That's why the tests failed?


If $this->pem_path is null or blank isn't this going to result in either an absolute path or an error


Also! I have not been javadoc-ing  at all.. lol.


I suppose that this change tests linux packaging. What about windows packaging?


Change this to be uncommented for 3G


why not take advantage of jQuery : `input.prop('checked')`


OK!


Same here : `input.val()`


why not element.val() ?


Are u still at school.
On 18 Nov 2015 7:41 pm, "Melinda Valent" <notifications@github.com> wrote:

> Change this to be uncommented for 3G
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ValentmSTEM/gps_v1/commit/2388fe4c853ba0776cf260b2abd839afe6c8650a#commitcomment-14465365>
> .
>


Alt det arduino stuff er fixet i roedtraad.


Ah probably in one of the pull requests ;/ makes me wonder what more got lost in the process


After refactoring of longpress() in text_selection.js, there is a potential timing issue could happen. Since the effenciency of longpress() has been improved, the location of dialog could be wrongly stored before keyboard popup from time to time. In this patch, we make sure to store dialog location after keyboard popup.


Thanks - will send a PR.


Thanks!


No, just putting code on Github at home….I'm not that crazy!

From: dannylaroo <notifications@github.com<mailto:notifications@github.com>>
Reply-To: ValentmSTEM/gps_v1 <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wed, 18 Nov 2015 00:42:24 -0800
To: ValentmSTEM/gps_v1 <gps_v1@noreply.github.com<mailto:gps_v1@noreply.github.com>>
Cc: valent <valentm@knox.nsw.edu.au<mailto:valentm@knox.nsw.edu.au>>
Subject: Re: [gps_v1] Create FONAtest_Adafruit3G (2388fe4)

Are u still at school.
On 18 Nov 2015 7:41 pm, "Melinda Valent" <notifications@github.com<mailto:notifications@github.com>> wrote:

> Change this to be uncommented for 3G
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ValentmSTEM/gps_v1/commit/2388fe4c853ba0776cf260b2abd839afe6c8650a#commitcomment-14465365>
> .
>

—
Reply to this email directly or view it on GitHub<https://github.com/ValentmSTEM/gps_v1/commit/2388fe4c853ba0776cf260b2abd839afe6c8650a#commitcomment-14465376>.


So basically, you say: https://github.com/FernetMenta/xbmc/commit/3f4400631ac174ec8f7e618478840c892855650d#diff-a0916ec74ca23341440a387de99c056cR61 <- this sample rate will be what I need to use in that case?


Some comments on this file:
1) Why's `JVMSignature.arguments` typed as array and not list. If you used list, you wouldn't have to define custom equals.
2) I would say that the name is kinda long. How about `JvmSig` or just `Sig`?
3) I would merge `JVMSignatureParser` and its usages into a single method in this file, e.g. `JvmSig.parse`, which internally defines the parser object and then calls it with all the boilerplate.
4) Instead of things like `false.getClass`, you could use `classOf[Boolean]` and likes.


555
On 18 Nov 2015 7:44 pm, "Melinda Valent" <notifications@github.com> wrote:

> No, just putting code on Github at home….I'm not that crazy!
>
> From: dannylaroo <notifications@github.com<mailto:notifications@github.com
> >>
> Reply-To: ValentmSTEM/gps_v1 <reply@reply.github.com<mailto:
> reply@reply.github.com>>
> Date: Wed, 18 Nov 2015 00:42:24 -0800
> To: ValentmSTEM/gps_v1 <gps_v1@noreply.github.com<mailto:
> gps_v1@noreply.github.com>>
> Cc: valent <valentm@knox.nsw.edu.au<mailto:valentm@knox.nsw.edu.au>>
> Subject: Re: [gps_v1] Create FONAtest_Adafruit3G (2388fe4)
>
> Are u still at school.
> On 18 Nov 2015 7:41 pm, "Melinda Valent" <notifications@github.com<mailto:
> notifications@github.com>> wrote:
>
> > Change this to be uncommented for 3G
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/ValentmSTEM/gps_v1/commit/2388fe4c853ba0776cf260b2abd839afe6c8650a#commitcomment-14465365
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub<
> https://github.com/ValentmSTEM/gps_v1/commit/2388fe4c853ba0776cf260b2abd839afe6c8650a#commitcomment-14465376
> >.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ValentmSTEM/gps_v1/commit/2388fe4c853ba0776cf260b2abd839afe6c8650a#commitcomment-14465406>
> .
>


kappa


Thanks, Sam! 👍


Mais non !

Comme tu le dis toi même :
suivant la Précédence des opérateurs PHP, && est évalué avant ||
-> http://php.net/manual/fr/language.operators.precedence.php

Ce qui veux dire que toute les parties entre && sont évaluées et donnent un booléen
et ensuite les || sont évalués sur ces résultats booléens

Pour exemple :
```
A && B || C && D   ===  (A && B) || (C && D)
A && B || C && D   !==   A && (B || C) && D
```

Donc je maintiens fortement que les parenthèses que tu veux ajouter **peuvent l'être pour un souci de lisibilité** (ce n'est pas mon point de vue) mais que coté logique, elles sont parfaitement inutiles.

Pour reprendre donc mon exemple :

in_array($ticket->fields["status"], $ticket->getClosedStatusArray()) // le statut est clos
&&  $ticket->isAllowedStatus($ticket->fields['status'], Ticket::INCOMING) // matrice profil OK
**// 1 - Toute la partie du dessus est évaluée pleinement**

||   **// 3 - le résultat des 2 parties est comparée par l'opérateur OU**

**// 2 - Toute la partie ci dessous est évaluée pleinement**
$requester && !$tech // seulement le demandeur
&& in_array($ticket->fields['status'], Ticket::getReopenableStatusArray()) // statut ré-ouvrable


Hmm ....
Catchable Fatal Error: Argument 3 passed to DS\Component\ReCaptchaValidator\Validator\ReCaptchaValidator::__construct() must be an instance of DS\Library\ReCaptcha\Http\Driver\DriverInterface, boolean given

?


Thank you! Fixed


if input value idx is less than -length, here you would still get an invalid non-handled negative value that could lead to problems.


I guess it is a typo ?


@Minecrell If you can figure out how to make the  currently bulk `ManipulatorTest` actually treat each registered manipulator as a single test, then that'd help. Of course, indeed throw exceptions if there is an issue for checking immutability or deserialization, but don't throw exceptions (just don't print them) when the manipulator fails because it relies on a mixin to work.


one of these commits regarding power: reset seems to have broken adb reboot recovery and bootloader commands, on my device recovery can only be accessed via vol up + power buttons

any thoughts on this?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5677](https://teamcity.mesosphere.io/viewLog.html?buildId=77356&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:07:41


typo: compout -> compound


@dwainm I recompiled this, as you had reintroduced the unescaped double quotes. You probably need to update your gulp pot script.


Thanks a lot, this clarify that I needed an ```@Import(MongoAutoConfiguration.class)``` because I wanted to invoke the Mongo client auto configuration.


Looks like cleaning C:\Documents and Settings to get some free space was a bad idea indeed. Git configuration was there.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5676](https://teamcity.mesosphere.io/viewLog.html?buildId=77355&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:01
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Выбор класса стоит вынести в отдельный метод — очень это всё запутанно выглядит.
Более того, имеет смысл переложить эту ответственность в класс Movie (потому что списку фильмов в общем-то не до того): `Movie.create(row)` — а он уже внутри метода класса create решает, какой _конкретно_ класс создать.


Sketchup2016 (macumber) - i386-Windows-7-VisualStudio-12: OK (2335 of 2370 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.52%25-yellow.svg)


Best commit EVER


В общем-то нормально и так, но лучше бы сделать это через detect (сначала находим фильм, потом задаём ему рейтинг). Потому что так — через detect — например проще будет поймать ошибку «фильм не найден». Ну и смысл действий понятнее.


Nice. I think we have some stuff in the default builder that should make *.a stamps deterministic.


it's already fixed, dropper can't longer be a string ("" in this case)


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.568.1a851e802fd2a6b7dd3a2aa0f2e1a5ef1e803531](http://build.palaso.org/viewLog.html?buildId=66291&buildTypeId=bt322) outcome was **UNKNOWN**
Summary: Canceled (Tests failed: 2 (2 new), passed: 1911, ignored: 68) Build time: 00:49:56
### Failed tests
```
SIL.Core.Tests.dll: SIL.Tests.CommandLineProcessing.CommandLineRunnerTests.CommandWith10Line_NoCallbackOption_Get10LinesSynchronously: <no details avaliable>

SIL.Windows.Forms.Keyboarding.Tests.dll: SIL.Windows.Forms.Keyboarding.Tests.XkbKeyboardAdapterTests: <no details avaliable>

```


А ты осознаёшь, что ты в этот момент изменяешь поле `point` фильма? И что при следующем вызове этого метода произойдёт что-нибудь ОЧЕНЬ СТРАННОЕ (потому что у части фильмов рейтинг уже умножился на `rand(100)*weight`)?


TeamCity TripleA :: UnitTest [Build 148](http://188.177.191.210/viewLog.html?buildId=216&buildTypeId=TripleA_UnitTest&guest=1) is now running


Can the trait not extend another trait?


TeamCity TripleA :: UnitTest [Build 148](http://188.177.191.210/viewLog.html?buildId=216&buildTypeId=TripleA_UnitTest&guest=1) outcome was **FAILURE**
Summary: Tests failed: 10 (10 new), passed: 42 Build time: 00:00:25
### Failed tests
```
CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_AddTransaction_OrderControllerAddTransactionIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_CallingAddProductOrderController_OrderControllerAddingProductIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_CancelOrder_OrderControllerClearOrderIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_CancelOrder_OrderControllerMissingAmountIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_CancelOrder_OrderControllerSaveOrderIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_CancelOrder_StartNewOrderIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_ClearOrder_OrderControllerClearOrderIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_RemoveProductFromOrderList_OrderControllerAddingProductIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_RetrieveIncompleteOrder_OrdercontrollerGetStashedOrderIsCalled: <no details avaliable>

CashRegister.Test.Unit.dll: CashRegister.Test.Unit.Sales.SalesControllerUnitTest.SalesController_SaveIncompleteOrder_OrderControllerCreateNewOrderIsCalled: <no details avaliable>

```


Hello


@FernetMenta please pick: https://github.com/fritsch/xbmc/commit/da98c9817d5514ccb643de62822ff3b36d7f6f23

Btw. I would make that very clear in the Header already that this information is only valid when we are using passthrough ... it is not obvious for developers.

@wsnipex: Does EAC3 work for you with that change? (It needed the encoded rate before which might be 44.1 khz while the samplerate is 48 khz) ...


We should not read input if r.needsMoreOutput is true. Otherwise, we risk reading more data than the stream needs, and getting a premature error from the underlying io.Reader.


Если ты не собираешься дальше по ходу менять вес, то он конечно должен быть константой класса, а не переменной.


What happens if ```read > 0``` and io.EOF is returned? This logic here seems to drop the bytes read on the floor.


Pode ser por conta da minha versao do ruby. Vou dar uma pesquisada sobre o assunto pq o editor nao eh.


я немного затронул логику вычисления на стартовом и конечном ребре. В старом коде тест проходил на границе точности и вышел из неё в результате изменений.


Thanks @takluyver @rgrp fixed! http://datapatterns.org/pattern/liberating-access-databases/


To me, you should only ever stop the propagation if you really want to make sure that only one event subscriber can be responsible for manipulating an object. The InsertTag example is a quite good one because I think people are used to the fact that when they use `{{inserttag::foobar}}` it will always produce the same output, independent of what extensions/bundles they install. No extension can modify an existing InsertTag. If they want to have other functionality, they must use a different InsertTag. To me, this would be a perfect use case for stopping the event propagation. In this case here, however, why should we prevent any developer of modifying the e.g. event preview URL?

It's a matter of what we want the developers to do or not. There's no right or wrong. It's just a decision you have to make for every event.

We could also say it's legitimate to modify an existing InsertTag and vote against stopping the propagation. I just think in the specific case of InsertTags, it's wrong. Just the same as I think in the case of front end preview urls, it's correct to not stop the propagation :)


@suomiy
Since the SharedPreferencesHelper is a created as an ebean, it does not make much sense to expose the helper methods as static ones. Also the SharedPreferencesHelper could get the instance of the SharedPreferences by itself.

So, I would imagine the methods here to look like:
public boolean isConnectionNotificationEnabled() {...


U may want to revert,  refactor and then commit and push again because I will commit or merge this to the master soon, so u may want to make the code clean.


This violation is not expected in testDefaultConfigurationOnFileWithViolations()


I expect that binary AMD drivers don't support 1.18 yet https://wiki.archlinux.org/index.php/AMD_Catalyst#Xorg_repositories I originally thought we would wait a little longer before going away from 1.17 – there's also recent 1.17.4 maintenance update.

BTW, xorg-server changes cause only a few rebuilds.


Hope this didn't break anything :<


Она уже убрана в последующих коммитах.


I don't think the EOF condition is determined by the underlying Reader, see below.


No need to do this now, I added #4 instead.


This code was used to load the Huckleberry Finn book into database.
Pre Req:  pip install --allow-external mysql-connector-python mysql-connector-python


:ok:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5678](https://teamcity.mesosphere.io/viewLog.html?buildId=77357&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:48


I believe this is the proper point that eof should be set to true. The documentation for BROTLI_RESULT_SUCCESS says that it indicates that the stream "is completely done".


> Claire

Все мелкоборды с этим самопальным движком умерли, не нашел ни одной.


I have just merged this into a testing branch ggtd-rcmcarddav. Can you confirm that this works there now?

It seems that you can either delete via the hook OR the ->delete() function.
If the hook returns 'abort' true, then the count in 'result' is taken as 'number of contacts deleted'. If 'abort' is false, the ->delete function is called and its return value is taken as 'number of contacts deleted'.

I'm not sure what the reasoning is for that, but at least with ownCloud as backend, this works fine.


Manpage was not updated for new option.


Wow, Just follow your update.It's all right., may be not the standard gt02 protocol, Thank you very much for your help.


И ещё одно: в реальной работе желательно делать каждый коммит имеющим свой смысл. То есть этот коммит, в идеале, хорошо было бы разделить на два:
1. фиксим мелкие помарки из предыдущей задачи (отступы, оператор `?:` и т.д.)
2. выполняем текущую задачу.

А так мне при чтении приходится над каждой изменённой строчкой на пару секунд зависать, пытаясь понять, имеет ли она отношение к новой задаче.


Ok.


This is not an HTML List


메시지 바꿨음.


Yes, that was so obvious for our case that I forgot to mention that memory backend was limited. That is when this bug comes up.


Также прокомментировал все костыли, которые били запилены ради одной борды, или задаются в только одном месте.


By the way, I think you should create a new release.


Ouch :fearful:


(С надеждой, что их когда-нибудь выпилят)


Indeed


靠，你都不跑一下，后面我加上travis


@FilipHarald Are we on 9gag? Is this France? I do not approve of this change


Это гарантирует условие endK < buffer.size() которые мы поставили выше.


J'avais plutôt comme idée (toujours de manière temporaire), de renvoyer une chanson vide, avec simplement l'attribut `_errors` contenant une `errors.SongSyntaxError` appropriée, pour que la compilation du carnet puisse tout de même continuer.


@cbas when user uploads an image it should render the image onto the canvas. This does not work because the `event.target.value` is an invalid URL scheme. I suppose I need to use `readAsDataURL(Blob)` but I am unsure how to do so even after reading the [documentation on MDN](https://developer.mozilla.org/en-US/docs/Web/API/FileReader/readAsDataURL).


reack


xenomorph - key


403 error


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5679](https://teamcity.mesosphere.io/viewLog.html?buildId=77362&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:37


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.131.7e2763519691e5c409e80d88011bf57149bdf405](http://build.palaso.org/viewLog.html?buildId=66296&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 939, ignored: 50 Build time: 00:37:19


Хотя давай добавим. Так как по факту проверка должна быть endk <= buffer.size();


return unless user_signed_in? && current_user.admin?


testing forks


key fingerprint:
ec:e1:7e:78:22:e2:c4:ed:23:73:d2:c9:0e:84:08:97 jesusemilioyogi@gmail.com


On peut attraper cette exception dans [_parse](https://github.com/patacrep/patacrep/blob/9afd8f7b61be3a80e0ce37e7f2a82fa6ac44db9c/patacrep/songs/chordpro/__init__.py#L31) et générer cette chanson vide.

Je préfère ce comportement pour patanet (qui appelle directement `parse_song`): si il y a une erreur fatale on interrompt l'opération en cours; si l'erreur est mineure on indique que l'opération a été effectuée après correction automatique de ces erreurs.


change method name


I think this is the only change


THANKS


why not just `return entry.mode === submoduleMode;` ?


`boolean` is a function.


name success


scope success


could these be `const` ?


Стоит использовать кодировку UTF-8, а не Windows-1251. Либо писать только на английском :)


Nope :)


Wtf?

> On 18 Nov 2015, at 11:05, Fotis Papadopoulos <notifications@github.com> wrote:
>
> Indeed
>
> —
> Reply to this email directly or view it on GitHub.
>


You don't want to add ```useful``` Yarn Spinning Machine, but you're adding Chemical Thrower ```just for fun```...
//These crazy developers)))


Норм, принимается. Хотя тут одну вещь можно было сделать проще (Руби просто временами «слишком умный» :) и прощает лишние усложнения).

Вот здесь:
```ruby
@@filters[name].call([m].concat(filter)) # ты передаёшь один аргумент-массив
# хотя твой блок выглядел вот так:
{|movie, from, to| (from..to).include?(movie.year) } # ждал три разных аргумента
# к счастью, руби «понял», что один аргумент-массив надо декомпозировать на эти три
# и всё работает (но так повезёт не всегда, если бы это был метод, а не блок, руби бы «не
# догадался» разобрать массив на элементы при вызове)
# но лучше было бы вот так:
@@filters[name].call(m, *filter)
```


Good job! Line 331 `private void helper(ListNode right, Result result) {` is more efficient since we do not change the left ListNode at all.


Wrong commit, committed the dist folder by mistake


И как это открыть?


Some comments about this file:
1) What are the `???` cases in `invokePrimitiveBinaryMethod`?
2) The rest looks okay I think


:/ the github diff sucks, line endings i guess, sorry


Why's it called `Function.args`? Shouldn't it be `Function.params`?


@cbas standard says that `Image()` is `undefined` and as such my Travis CI build is failing. How can I rectify this?


@randsina Зачем тебе это открывать?


adding FileInputStream(file) solved the problem with:
“Content is not allowed in prolog” during XML parsing with JAXB


Ну ладно. Просто я же должен всё знать)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5680](https://teamcity.mesosphere.io/viewLog.html?buildId=77363&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:55


@randsina http://www.sparxsystems.com/


next


thanks!


d


空行


My testing was a bit over the top (I don't think `vm-bhyve` gets anywhere close to using `$()` 1000 times, probably over 100 in some cases though), but this was my test -

```
#!/bin/sh

getval(){
        setvar $1 "test"
}

getvalold(){
        echo "test"
}

_val=""
_num=0

while [ $_num -lt 1000 ]; do
        getval _val
        #_val=$(getvalold)
        _num=$((_num + 1))
done

echo "${_val}"
```

The outcome showed that while `$()` was more probably than quick enough, using `setvar` was significantly faster (literally reported as 0.00s with 1000 runs)

```
# time sh test.sh
test
0.069u 0.363s 0:00.38 110.5%

# time sh test.sh
test
0.007u 0.000s 0:00.00 0.0%
```

This was all part of my effort to speed up reading guest config files which had got to the point where I was calling it a lot in `__vm_run`, and was also very noticeable in `vm list` (which of course reads several config options from every vm). I can't remember the exact figures but I ended up getting an obvious visible improvement in `vm list`.


Ping @2br0ne --> Le format devrait être bon maintenant.


lmao


Hi, "box" is short for "dialog box": in italian i could write *"finestra di dialogo %s"* or *"dialog box %s"* (which I prefer, because some foreign terms just entered the jargon and sound better than the local counterpart), but I was afraid that the resulting text would have been too long. I tried to keep the line short because of the way `argparse` organizes the help text. Thank you!


The summary line should be shorter (80 ?)
Leave a blank line and add more details if needed.


Можно не упарываться для начала. Мы заведомо не попадем в такое состояние, потому что если `true`, то второй параметр всегда будет. Задача попробовать попрограммировать, тут большая надежность не нужна, ее гарантирую я правильно вызывая функцию.


same here


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5681](https://teamcity.mesosphere.io/viewLog.html?buildId=77364&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:41


TeamCity LabkeyRelease15.3 :: CDS postgres 9.4 [Build 14](https://teamcity.labkey.org/viewLog.html?buildId=285897&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 17 (2 new), passed: 7 Build time: 00:43:58
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

##### there are 7 more failed tests, see build details
```


Is there a reason this can't be called `hasSub`?


Again, I disagree. If there is a default Contao listener for the event preview URL, and you want to override it, then use a higher priority listener. You can still not set a value in your listener if you want the default one to handle it. But letting my listener handle it and then ignore the result because is was changed again seems wrong.


OK.


Goooood Job! 你是一个代码风格很棒的人！CocoaChina+中有些类创建的比较早，那时对swift的一些特性了解的不够，代码的确有很多问题，谢谢你的PR！


Will do, just want to get the master/wip stuff in alignment first


update coverage


no this was only generated by intellij


value指定しないと初期値はいらないですか？


`User.backups` already orders by server time ... that should really be documented


Why did you change from delta to bulk? You don't need to process the whole graph in each iteration. Only the updated vertices have to be in the workset for the next iteration, like shown in the figure of #3. Am I missing something here?


if this doesn't work, i'd be fine with `git mv src/node_modules src/modules`, thus abandoning the app `node_module` pattern which would allow us to use app-wide browserify transforms, since it seems the duplication of transforms isn't worth it and it's better to pull modules out of the app then try to separate them within the app.


You are right, so as you see I thought of test case, but I forgot to update pattern and tests - will fix.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.569.1a851e802fd2a6b7dd3a2aa0f2e1a5ef1e803531](http://build.palaso.org/viewLog.html?buildId=66302&buildTypeId=bt322) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 00:41:00


just fixed


`ValueError` seems like much too general of an exception to catch. When/how will this be thrown if the student has no eligible backups?


на отдельных строках


Salut  @rGaillard , j'ai un soucis avec ta modif dans OrderController et notamment dans la méthode autoStep.
Explication :
J'ai 2 transporteurs TA et TB et 2 produits PA et PB.
Sur le produit PA j'associe uniquement le transporteur TA et sur le produit PB le transporteur TB
Depuis la version 1.5.6.3 je suis toujours redirigé vers le step 2 à cause du redirect car  $this->context->cart->id_carrier = 0.
Dans les version anterieurs ca fonctionne bien et ma commande est bien split en 2.


Perfekt! :D


文字列とシンボルの併用はできないです。
class: 'user-password'
みたいな感じにしましょう。
他もいくつかこうなっているところあるので修正しましょう！


class指定のシンボル消しましょう


= @prototype.title
の書き方にしましょう！


哈哈，  我直接用notepad++编辑的


зачем создавать переменную для одного присваивания?


Now you can simply use:
```python
from dojson.contrib.marc21.utils import split_stream`
for record in split_stream(open(source)):
    create_record.delay(record.tostring(method='html'), force=True)
```


It's thrown in mark_as_final - models.py. We can certainly throw a better exception.

https://github.com/Cal-CS-61A-Staff/ok/pull/625/files#diff-d02f16f3bcd014841c0dce3ccb83d9aeR747


.id省略できます！


ここの@prototypeってなんでしょうか？


i haven't decided if i like `redux-effects` or not, part of me does and part of me doesn't. a simpler and more standard approach is to use [`redux-thunk`](https://www.npmjs.com/package/redux-thunk), which i'd probably recommend, at least until we move to streams (node streams, reactive extensions, or pull-stream) for our async operations. :wink:


summary is too long here too


See: https://github.com/inveniosoftware/dojson/commit/8a518b90fe34541928f20acd2787ddf2027769a2


here


likes_count: :desc
の書き方にしましょう。こっちのほうが新しい記法みたいです


Not the best place to discuss this any further but you shouldn't import auto-configuration yourself either. Spring Boot is taking care of that for you.


@paulsouche Thanks!


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 57](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=491&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


it may take a while until I am able to pick it. if you want to save time, send a pr


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 57](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=491&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **SUCCESS**
Summary: Running Build time: 00:00:41


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 58](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=492&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


Looks very good , i like it !
I've seen in the parents commits that configurator replace JTBConfig , it's also more easy to understand .
Let me check if it's working ( lol ) ,
good job !


might be better using [babel `transform-export-extensions`](http://babeljs.io/docs/plugins/transform-export-extensions/)

```
export agents from 'agent'
```

and so on


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 58](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=492&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **SUCCESS**
Summary: Running Build time: 00:00:39


The code does not comply to PEP8.

*Detected by PEP8Bear with severity 1 while running section `python`.*

*The issue occurred in the lines 1 to 1.*

The issue can be fixed by applying the following patch:

```
--- a/test.py
+++ b/test.py
@@ -1,4 +1,5 @@
 import something
+

 def main():
     pass
```


The code does not comply to PEP8.

*Detected by PEP8Bear with severity 1 while running section `python`.*

*The issue occurred in the lines 7 to 9.*

The issue can be fixed by applying the following patch:

```
--- a/test.py
+++ b/test.py
@@ -4,9 +4,6 @@
     pass

-
-
-
 def yeah():
         pass

```


The code does not comply to PEP8.

*Detected by PEP8Bear with severity 1 while running section `python`.*

*The issue occurred in the lines 11 to 13.*

The issue can be fixed by applying the following patch:

```
--- a/test.py
+++ b/test.py
@@ -8,6 +8,4 @@

 def yeah():
-        pass
-
-
+    pass
```


resourcesで書き換えることはできないですかね。
できれば7つのアクション以外のアクションを作りたくないので(newestみたいな）、newestコントローラーのindexアクションを準備してやるとよさそうです！


@lpinca please can you add: ?utm_source=nodify-module-repo-readme&utm_medium=click&utm_campaign=github after the microapps link


A D-class of a semigroup can be a semigroup itself, if it happens to be closed under multiplication. So, the introduction of a method for `IsomorphismReesMatrixSemigroup` for D-classes is just an extension of the existing code In particular, this does not break anything. You'll notice that the old declaration is not deleted by this change.

You say we should discuss why this change is necessary: it is not, it is an extension of the existing functionality. It is very natural mathematically (for semigroupists at least) to want to take an isomorphism from a D-class to a Rees matrix semigroup in the case that this makes sense. Since there is now a single function where all the work happens, I thought it was appropriate to introduce this extension here.

Note that additionally, the attribute `AssociatedReesMatrixSemigroupOfDClass` (present in GAP for some 10 years or more?), returns `Range(IsomorphismReesMatrixSemigroups(D))` extending `IsomorphismReesMatrixSemigroup` to D-classes simply gives users access to the function mapping the D-class to the associated Rees matrix semigroup (in the case that it exists).


This is a light-weight authority management framework.
Any other functions can be extended AbstractAuthManager class.
AbstractAuthManager is the super of any specific manager which act the container to hold the authority of all users


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.587.06a2e2581ba20a22c71ed3c35e2f42196f983e19](http://build.palaso.org/viewLog.html?buildId=66304&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3311, ignored: 125 Build time: 00:15:13


Not any longer... The idea is to have everything where we have a local clone with changes in a repository named that way. It's not quite like that, but the idea is to have it that way. Thanks for spotting that one, though - i'd forgotten to push it, i had the change locally. Sorted now :)


You no longer need to import itertools, making this even shorter.


Can it be written Windows Filtering Platform (WFP) on first usage of WFP in manual page changes ?
Thanks.


HBIRE_vector_take2 (mbadams5) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-74.49%25-red.svg)


Yeah - but please answer my other question before, please. Is this samplerate in the case of EAC3 what we had as encoded SampleRate before?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5682](https://teamcity.mesosphere.io/viewLog.html?buildId=77366&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:06:49


I'm not sure if it is part of Google Style Guide. It doesn't say anything about catch parameters...
Anyway, it's great catch that link should be removed. @rnveach, do you have idea for a test to prohibit such mistakes in future?


Sure, will fix.


Shouldn't we declare pouchdb as `peerDependency`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5683](https://teamcity.mesosphere.io/viewLog.html?buildId=77367&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:27


wth


Add logging for the specific panels at a finer level


You are right,thanks for noticing.It shouldn't. I accidentally forgot to divide this term by rho.


Thank you for the pull request. Could you please update the documentation page as well with the details of the changes you have made so that people know how to use it ?


This is a very old code branch. Much of the code in master branch is now different; in this case, we no longer rely on a host's IP address being the primary key. The current code in master allows us to have hosts that reside on different networks but are coincidentally configured to use the same IP address.


@Turbo87 Looks like IDEA uses constructors to instantiate ```ModuleType``` through reflection inside pico container.
https://upsource.jetbrains.com/idea-community/file/aaf6027955c79807e16b5c59032862aea4ba67e6/platform%2Flang-api%2Fsrc%2Fcom%2Fintellij%2Fopenapi%2Fmodule%2FModuleTypeEP.java?nav=1562:1573:focused&line=32

https://upsource.jetbrains.com/idea-community/file/aaf6027955c79807e16b5c59032862aea4ba67e6/platform%2Fextensions%2Fsrc%2Fcom%2Fintellij%2Fopenapi%2Fextensions%2FAbstractExtensionPointBean.java?nav=2690:2726:focused&line=70


any reason not to `if (autoRename === true)` here? there's no possible other way this condition could pass


Resolved the above commented mistakes


This seems to be not a real EndNote format. `\format...` is a JabRef command for the exporter. Please input real data and test for it. `%T` stands for "title". Please use a real title.

Please do so for all other fields such as `\booktitle` etc.

You can use pseudo data such as "booktitle" or real data taken form real entries (see https://github.com/koppor/stupro-jabref/wiki/Beispielreferenzen)


ah i'm forgetting the can of worms: https://gist.github.com/branneman/8048520. lemme know if you run into issues, i'm keen to sort this out if need be.


А здесь точно сначала отрефрешить, а потом присвоить?


Just to note the behaviour of what you propose is exactly the same as the current behaviour.  Of course, it is possible that a semigroup does not know that it is finite but later learns that it is. It is only `fam!.IsFinite` that is set to `false` not `IsFinite` for the Rees matrix semigroup we are creating. You seem to say that the current set up is not correct, when I think it is.

On the other hand, what is currently written is obviously confusing, so perhaps I should change this to something more similar to what you have written.

It is only `fam!.IsFinite` that is set to false iothing is having `IsFinite` set to `false` here in the case that it does not know that it is finite


Will need this part too .. :)


I can see that you just updated it to match the new function, but this type of comment is rather useless.


Sounds sensible. I'll make this change.


I think we could reuse IDEA instance here through ```ModuleTypeManager.getInstance().findByID("RUST_MODULE")```


Yes, did that.Thanks again!


`Reviewed-by: Joakim Bech <joakim.bech@linaro.org>`


Had a look again... the linter even told me that. I'll fix it now


@beaufortfrancois You're welcome !


Minor: I would make names of people referred, and other entities clickable (hot links).


we could also hide `ModuleTypeManager.getInstance().findByID("RUST_MODULE")` behind the `INSTANCE` property in the companion object


What's with this FIXME? I don't quite understand it and wonder if it's still relevant?