mock lets me set the objects returned by a specific function call and args for N times. E.g., only return error for foo(A) but not foo(B). To do this in FakeRuntime, I would have to re-invent the wheel and implement the feature myself. FakeRuntime, on the other hand, maintains some internal states that are great for testing the actual flow without having to `mock.On` each call.

You can also compile kubelet with FakeRuntime without having to add additional code, whereas the mock may require you to explicitly specify return value for each call.

Theoretically, we can combine both for the best of both worlds, but I'll have to think about it more.


Yep, good catch! thanks


TeamCity pull requests :: netty [Build 735](https://garage.netty.io/teamcity/viewLog.html?buildId=3567&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5279, ignored: 21 Build time: 00:15:25


Hi, look at my diff! :-) Both base and test commits have the condition removed...


This has been fixed in master, long time ago


Вот:
http://htmlbook.ru/html/attr/hidden


This commit is being reviewed as a part of review issue #87.


includeDirectReferences is always true so far


You have raised a valid point when you said "language(s)" (with a plural). The possibility of conducting a course in multiple languages *is* plausible. However, since we have just agreed that no backward-incompatible change will be introduced anymore, we will need to change the description and say that this should be a single "primary" language which has been used.


So if I would use GPIO in any other library I would need check if it is a instance of Linux::GPIO and cast? Looks wrong to me, well for now GPIO have almost the same use as DigitalSource but is better keep both working without need those casts.


It's not clear what "If true, a new asynchronous job is submitted to persist the bits and the job id is included in the response." means then. In the false case there is no job-id and so no Job entity to return if `async=false`.


Do you mean to have just the extra filter expression string available in QgsRenderContext (instead of the QgsFeatureFilterProvider) ?


LGTM


Please note, that we can always introduce a new element which would support multiple languages, if need be. Such solution would be backward-compatible, whereas adding maxOccurs="unbounded" to the existing element would not.


> I guess it might sound good if your goal is to learn a framework, but some developers drive is not to learn a framework. It's to use a framework and build a product. The more the framework stays out of the way ... the better.

You're arguing that you don't want to learn more or have the framework impose a bunch of stuff for you to know, which is exactly what `render/3` solves for you. Smaller API surface area, fewer abstractions, and fewer ways to do the same thing. With an API that doesn't sacrifice clarity. And one way a framework stays out of the way is by exposing the fewest primitives and abstractions as possible to support building your product, like one way to render templates.


This causes `@:coreApi` errors:

```
/home/travis/build/HaxeFoundation/haxe/std/cs/_std/Date.hx:35: lines 35-38 : Field new has different type than in core type
/home/travis/build/HaxeFoundation/haxe/std/cs/_std/Date.hx:35: lines 35-38 : year : Int -> month : Int -> day : Int -> hour : Int -> min : Int -> sec : Int -> Void should be native : cs.system.DateTime -> Void
/home/travis/build/HaxeFoundation/haxe/std/cs/_std/Date.hx:35: lines 35-38 : Field new has different visibility than core type
```

It didn't show up before because "someone" disabled coreApi-checks.


Agreed. This question is asked in _every_ training I give. The generated
setter methods aren't documented anywhere and the inconsistency between
scalar and collection types makes it even more confusing.

I'm on the fence about using methods to add to a collection. It's pretty
ubiquitous across our API though so I suppose we should support it. That
said, it's one thing for it to be an explicitly defined method (ex.
JvmLibrarySpec.targetPlatform) and something that we just implicitly
generate for managed types. Is there some way we could allow this for
managed types but require that the methods be defined on the type?

On Tue, Nov 24, 2015 at 12:38 AM Adam Murdoch <notifications@github.com>
wrote:

> @big-guy <https://github.com/big-guy>, good feedback. I'm not convinced
> that thing value is useful and I'd be tempted to remove it. This would
> leave us with thing = value only for scalar properties, and something
> like this for collection properties:
>
> things = ['some', 'values']
> things = 'some', 'values'
> things 'some', 'values'
>
> But not things ['some', 'values'] (pretty sure this is broken).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gradle/gradle/commit/b0393411a0c0583aee975b6133b133993c6d7778#commitcomment-14580976>
> .
>
--
*Mark Vieira*
Principal Engineer
Gradle, Inc.
mark@gradle.com


I think it would be a nice addition!
Moving discussion to issue #50


It's package private.


It is undefined behavior to use an allocator type that has a different `value_type` as the container `value_type`.  I'm actually shocked this compiled everywhere (especially on libc++).  The correct syntax is:
````
    using txs_map = std::map<key_type,
        std::pair<std::shared_ptr<Serializer const>,
        std::shared_ptr<Serializer const>>,
        std::less<key_type>, test::qalloc_type<std::pair<key_type const,
        std::pair<std::shared_ptr<Serializer const>,
        std::shared_ptr<Serializer const>>>, false>>;
````


looks not good


Thanks @chchwy !
Yes, I have accepted your invitation. I will finish this debug pass on my repository and will start working from the main repository after that.

By the way, I have tried to change some settings from the preference window and now Pencil don't want to launch anymore. It crashes on the line : QSettings settings( PENCIL2D, PENCIL2D );
I guess something went wrong with the settings DB. Do you know to reset the settings to pretend it's the first launch of Pencil?

Cheers!


It's copy paste of method above.
String packageName
Log.d(TAG, "returning app package identifier : " + packageName);


We try to use java8, but only if it doesn't change things too much for when we have to back port ingest to 2.x. I think dropping the factory interface would be a too big of a change?

The reason why this was added was for the geoip and grok processors that read stuff from the config directory. Providing the config directory as a setter once felt nicer than providing it all the time as an argument. (especially since it isn't going to change at runtime).


A bit late to point this out, but why is this preferable to having a real type for this with better property names than ItemN?


third comment


Will it make sense to call this m_ruleNames, to be more explicit in naming?


ipil bro plox ;_;


Very nice :+1:


No, this broke all of our php7 builds (drupal.org). xdebug is not ready to bundle in with php-7.0snapshot.


Ditto here:
````
    using items_t = std::map<key_type,
        std::pair<Action, std::shared_ptr<SLE>>,
        std::less<key_type>, test::qalloc_type<std::pair<key_type const,
        std::pair<Action, std::shared_ptr<SLE>>>, false>>;
````


Nevertheless, if the verb is `upload` (in the `Applications` interface) then it should be `UploadApplication{Request,Response}`. If it is `uploadBits` it can be `UploadApplicationBits{Request,Response}`. :-)  I'm not deeply fussed, though: your call.


is it possible to put those changes in change.rst file?


> I don't agree. It is intention revealing because it's exactly how you render templates since the view layer existed

That's ok, I think we think about things differently. I still love Phoenix and am grateful for your work


Added Medbiquitous member logo


6 of 7 is less than 90% So you are just testing if all threads agree.  So I am not sure the 90% thing is really being tested. It would be more interesting if it was 85%


+        CGPoint location = [touch locationInView:self];
+        CGPoint previousLocation = [touch previousLocationInView:self];
+
+        LCEngine::ED_TouchCancelled* newState = g_ed_touchCancelled[fingerID];
+
+        newState->fingerID = fingerID;
+        newState->timestamp = touch.timestamp;
+        newState->tapCount = touch.tapCount;
+
+        newState->Xrel = (location.x - previousLocation.x) * contentScale;
+        newState->Yrel = (location.y - previousLocation.y) * contentScale;
+        newState->Xabs = location.x * contentScale;
+        newState->Yabs = location.y * contentScale;
+
+        LCEngine::IEventManager::get()->trigger(g_touchesEvent_pool[fingerID][TOUCH_CANCELLED]);
+    }

testes


TeamCity pull requests :: netty [Build 736](https://garage.netty.io/teamcity/viewLog.html?buildId=3568&buildTypeId=pulls_netty&guest=1) is now running


@skalk: please try following commit


Good catch, thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6574](https://teamcity.mesosphere.io/viewLog.html?buildId=80079&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:07


thanks, l don't know every time when l e.g. comment on people's commits if they like that


Did this matter?


ttt


@arose can we just use un-minimized ngl.js file?


Yeah, you are right. Let's keep it for now; it will make doc generated by godoc look a little bit better.


@Ritterbrater, Contributors are always welcome.


I think we don't need lines 42-46 but call `makeDataParallel()` from the `util.lua` script. What do you think?


good catch, thanks!


You should order the require statements alphabetically (ASC preferably).


I agree, but the 'With an API that doesn't sacrifice clarity' is the subjective part for me. This does not really screen clarity to me.

I just think the level of understanding for `render/3` is quite steep for simply wanting to render a view. As a developer, my goal is to simply show a page. Yet, I'm now required to understand at a minimum 4 other concepts `view_module` `template_name` `assigns` and `@conn` ... it's just a big chunk of code to remember for someone who is new to a framework.


Hi,

It is our statistic counter - like Google Analytics. Surely, it doesn't collect any personal data or private information.

You can check it at top.mail.ru


:+1: teamwork


we load all the content in the header?


Add a new line after this for readability purposes.


You might want to pick a different value than zero so we don't get DMA block 0 and flash handling on the same systick.


this made me smile


belongs to BUG #16


You should always use ```{...}``` for single line blocks and ```do...end``` for multiline blocks.


QSettings file is located at $HOME/Library/Preferences/com.pencil.Pencil.plist , just delete this file to reset all settings.


@christianvuerings With this change, it looks like the contents of the two `div.cc-widget-text` elements are identical. Would it be better to combine the `data-ng-if` conditions for these two; or is that condition perhaps no longer needed?


Yes, good idea.


My plan was to have the latest changes in the README if there are too many, to put them in a file called CHANGELOG. I could create such a file right away. Do you need this for a particular purpose?


Thanks. I compiled directly from your fork. Maybe the change needs to be
there in your repo as well.
On Nov 24, 2015 8:29 PM, "Faraz Masood Khan" <notifications@github.com>
wrote:

> Please make sure your build.prop doesn't have
> "ro.telephony.ril_class=LgeLteRIL"
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mysteryjeans/android_device_lge_g3-common/commit/b5746cff7e4fedfa5f145f383f81ef9b628d111c#commitcomment-14590983>
> .
>


    And one way a framework stays out of the way is by exposing the fewest primitives and abstractions as possible to support building your product, like one way to render templates.

This is obviously a balancing act. And you guys have made great decisions thus far, so I trust your decisions. I'm simply just pointing out, that as an entry level barrier ... the `render/3` function ... feels quite heavy.


Keep arguments and closing parenthesis on their own lines.


Jo, jag var bara lat. Men det går att fixa.


In `exception/1` you are calling `to_string(unit)`, so `msg/1` receives a binary, but then you are calling `inspect(unit)` and `to_string(unit)` again in `msg/1`. Can you remove those extra calls? You also don't need `inspect(similar)`, since `max_similar` returns a binary for `similar`. Sorry I didn't spot those the first time :(


There should be more than one set of violation,and may lose some reports.So we fix this and worked well.


This is a breaking change, if widget name contains a `-`, then now its alternate will be encoded differently.
Which shows the flow in the test logic as `Rename('-')` will only alter something if it contains `-`, so the `if` statement is useless, removing it makes the breaking change even more obvious.


pls. can you... remove the  .gitattributes from the patch.


@stiopaa1 guess it's safer to keep "CEPH_BUFFER_API" here? we can also put
```c++
namespace buffer CEPH_BUFFER_API {
```

see https://gcc.gnu.org/wiki/Visibility.


This line crashes if font is nil (which happened to us when upgrading to Sparrow 2.2 for a reason I'm still figuring out). Maybe there should be a fallback to a default font or something?


This really is a mess. There are no safeguards or checks for the string format or the data types or the type of `int`.

I am following a thread in the quickest and dirtiest way possible to see if it will work for parsing time and HR data and saving the result. If it works, I will go back and improve everything about this garbage.


no need to reformat this piece of code here.


@sanindya-iiitd Good work. But watch out so you don't commit irrelevant files or changes, like this log file.


You are right! I simply overlooked that. So a correct test should do even better, right?


I noticed that `FormProcessorCouch.post_xform` wasn't calling `cls.save_processed_models`. I assume that's intentional but can you explain that to me?


Can you add a doc blurb somewhere saying that now if you want to override the `schema` property you have to do it by implementing the `_schema(self)` method? doesn't have to be in the whatsnew


#anticipate


Fixed in https://github.com/mono/mono/commit/2b1d785ca4cc5758f6beeb92fcbeb0a6da4a21b3


I am not on a Mac anymore, I am on Fedora so Pencil config file is located in $HOME/.config/Pencil/Pencil.com, I found it. Thanks!


Is this not taken care of in your first commit?


You should use ```\``` for long strings.
```'Símanúmerið þitt verður ekki birt. Það er aðeins hægt að hringja á '\
            'milli 9:00 og 21:00 %{time_zone}.'```


It's generally not a good idea to lock a mutex from a signal handler. Some pthread_mutex_lock man pages mention this. Also you can see that there's a limited list of "async-signal safe functions" in the `man 7 signal` man page.

It's not hard to understand why: the same thread may have already taken the mutex, when the signal interrupts it and jumps it to the signal handler, where if it tries to take the mutex again and sleeps waiting for it to be available, it will deadlock.

One thing you *can* do here is write a single byte to a pipe. Or just let the while/sleep loop be, maybe making the sleep longer since it will be interrupted by a signal anyway.


Sure, I'll change it, it is for local use anyway and helps debugging. I use a build from NGL, so changes should go there.


is this change necessary?


Lol?


@dpgeorge I'd actually be concerned about this. flash_erase and flash_write are routines which I think take quite a bit of time (but I haven't instrumented them). By moving this from TIM3 running at priority 6 to the SysTick handler running at priority zero it effectively blocks out any interrupts from occurring while waiting for those operations to complete.


I have installed bootstrap-material-design with npm and i'm using it by including less files (as you are doing with bootstrap). Mainly because i'm using font-awesome instead of material-design-icons.


we don't call `super().__init__` here so the `_hash` never gets set.


I tested the man pages again and indeed there had been hyphens used for flags instead of minus signs. There is already a special groff compatibility mode for man pages (register .g set to 1), I will use it for this code change. If `dv` is set to 1 in `maybreak` the code behaves like before the changes. (The bug is in the man pages but since groff (and mdocml) doesn't show the bug they won't change.)


no need to have the ending `;`.


@staabm ``/usr/bin/env php`` reads the PATH variable, it does not deal with bash aliases (as bash is not involved in resolving it)


>  Do you need this for a particular purpose?

No,  I don't . I was just asking about organizing files.


Removed OSIRIS bounding boxes since they are no longer needed.

Tested load times with and without cache generation (first load of new instrument); difference insignificant:

   | Cache Gen | Cache Load
---|------------------|----------------
With BB | 12.61 sec | 0.02 sec
Without BB | 12.58 sec | 0.01 sec


Okay that didn't work, it went to the master anyways. Well I tested the GUI and it still worked so I think it's safe to say for now that nothing broke. We can always revert if there are issues.


>+static int getFingerTrackIDByTouch(void* touch) {
>+    for (int i=0; i < MAX_TOUCHES; i++) {
>+        if (g_TouchTrackers[i].touchPointer == touch) {
>+            return i;
>+        }
>+    }


i didn't know you could call `__init__` on an instance


Keep arguments and closing parenthesis on their own lines.


nickel !


ditto. no need to reformat the code here. reformatting the code could make it harder to  "git blame" a certain commit.


Question:
Why is this not documented?


> Sure, I'll change it, it is for local use anyway and helps debugging.

it's convenient for me to look too. (rather going to ngl git folder to check).


retravailler user devise edit qui vient de user view


Were there pickle tests breaking or was it just because of other changes?


@sebmck Is it possible to disable strict mode when using this plugin? We have some legacy code that unfortunately breaks when enabling strict mode, and fixing that code to work with strict mode is definitely in planned but not for the immediate future.


See 65888e2006ad5aac6d613550aecea9956562eb59.


@Soullivaneuh the issue with your proposal is that you would then always have to run ``php /path/to/phpunit`` to get code coverage rather than ``phpunit``, as the phpunit bin would also run without xdebug if it is not available in the config (or you have to create aliases for most of your PHP tools)


we have a test that does: `eval(str(expr)).isidentical(expr)`. when eval'ing the expression we need `Like` to be in the namespace. The `str` of a Like expression has the name `Like` in it.


LGTM.


Thanks for fixing this. But that way we would always test just one branch, right? I would rather see this:
```python
self.cmd.base.conf.strict = True
self.assertRaises(dnf.exceptions.Error, self.cmd._get_packages, ['notfound'])
self.assertRaises(dnf.exceptions.Error, self.cmd._get_packages, ['notfound', 'bar'])

self.cmd.base.conf.strict = False
pgs = self.cmd._get_packages(['notfound'])
self.assertEqual(len(pkgs), 0)
pkgs = self.cmd._get_packages(['notfound', 'bar'])
self.assertEqual(len(pkgs), 1)
```


ok pour merge


I feel like there was a reason that this doesn't use `repr`


In the meantime, I really miss the waypoints as they were in previous
versions (day 10-11-2015).

Can we have the simple waypoints functionality back?

I would like to set a route from A to D, then see and check where the
planned route will go, then add B and C afterwards only as waypoints (not
to stop, just to drive by), so it modifies the route.

A--->B--->C--->D

In current night builds all waypoints get added as final destinations
(waypoints only add sequencial destinations), so to get the same result, I
have to add A, B, C, D, in that order, or else I have to open the
destinations list, and reorder them all (since with the previous method, C
would be the last destination added).

Osmand was great for adding a simple waypoint to make a detour to change
the route, but now it works agains what users are used to do.

I would also vote for changing the 'blue circle with turn right arrow' for
something more obvious, like the chequered flag to set it as destination,
or the blue arrow we have for navigating.

--
Cumprimentos,
D.er Hugo Barrocas


@dhylands no, it's ok, there is very little change in the functionality: the storage_irq_handler() function is not called from SysTick_Handler, it's called from the FLASH_IRQHandler, which is triggered by SysTick_Handler.


This is not the change that was agreed in the discussion. It should be `named` and define the entity list like this:

```
    // The default entity_encoding ('named') converts too many characters in
    // languages (like Greek). Since Drupal supports Unicode, we only convert
    // HTML control characters and invisible characters. TinyMCE always converts
    // XML default characters '&', '<', '>'.
    'entities' => '160,nbsp,173,shy,8194,ensp,8195,emsp,8201,thinsp,8204,zwnj,8205,zwj,8206,lrm,8207,rlm',
   );
```


Can get rid of the extra double quotes...


cool


ah


ok carry on!


@projectkk2glider - I didn't realize all commits generated a build - I thought that was just part of the pull request process. Looks like I should check https://travis-ci.org/opentx/opentx/branches after each commit, is that right?

Is it considered bad form to push commits before they are ready for a pull request?

@kilrah - I changed the default to SBUS_MAX_FRAME_SIZE (value 28).  Is that a good constant to use, or should the default value be specified another way?


If you break a parameter list, you should keep parameter lists and closing parenthesis on their own line.
For example:
<pre>
def method_with_long_signature(
    the_first_arg:,
    the_second_one:,
    and_another_one:
  )
    # code here
  end
</pre>


Why is the thing you don't want a question, but the thing you want a statement?

dat POV push


as long as nothing breaks i'm okay with this change


TeamCity pull requests :: netty [Build 736](https://garage.netty.io/teamcity/viewLog.html?buildId=3568&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5305, ignored: 21 Build time: 00:15:10


might want to add this file to `noinst_HEADERS` and `rados_include_DATA` in `include/Makefile.am`.


Or a QgsFeatureRequest so upcoming possibilities like specifying an order by will be included for free.


Why? when the buffer goes over the size of buffer, it doesn't contain `\n` and the next should have `\n`. So  I'm thinking we shouldn't beleave the data always contain `\r`. Then I beleave we shouldn't use appendLine for `data`. But exit code line should use appendLine.


love reading


If you break a parameter list, you should keep parameter lists and closing parenthesis on their own line.
For example:
<pre>
def method_with_long_signature(
    the_first_arg:,
    the_second_one:,
    and_another_one:
  )

    # code here
end
</pre>


I believe it acts just like any instance. One note, I think I can get rid of the map here and just use args and state like before.


Untested


I just noticed that pickle was incorrect while playing with this. I did something like:

```python
d = bz.Data(1, dshape='int32')
pickle.loads(pickle.dumps(d))
```
this gives back a new expression of dshape int whose data is the the integer that is the memory address of `1`.


Thanks, this has been corrected mainstream. Please check the latest changes.


Is that right?


いっっっm


Added comments


Rephrase it to be more neutral, if you so wish


@ioannis-e Not very pretty, but it works :smile:


@stof, well xdebug is useful only for test tools like phpunit AFAIK. It's ok if I have to make 2 or 3 aliases.


я его для тебя оставил) чтоб ты понимал, что я написал, а что было)


I would actually like to keep these two comments since they refer to the documentation that describes this behavior, I really just wanted the commented out code line assigning `_loopCount` to be removed.


You can run the tarball job directly by ``nix-build -Q pkgs/top-level/release.nix -A tarball``, but beware that it takes lots of RAM (my 4GB notebook won't make it).


pizza


and confirmed the symbols generated by GCC of are the same. cool! i.e.
the symbols of
```c++
namespace buffer {
int foo();
}
```
and
```c++
class buffer {
static int foo();
};
```
are identical.


:+1: (not that I sign-off).


Still overwriting one byte here... see https://github.com/cleanflight/cleanflight/issues/1512#issuecomment-159341054


I wish I could you the `doc` macro and get rid of the `special-*` maps.
Also have a look at [this part](https://github.com/ScalaConsultants/replumb/blob/master/src/cljs/replumb/doc_maps.cljs#L156) as I added some doc that was not there (because those are macros).


Google ignores it anyway:
> We don’t use any code-level language information such as lang attributes.
https://support.google.com/webmasters/answer/182192?hl=en

But to support screen-readers, I would use the strategy that is the less work: Set the interface language on `<html lang="">` and set the document language on the block that contains the document (or on each element that contains a field value of the document).


There is a difference. If the string contains single quotes in it, the repr will use double quotes. if it contains both kinds of quotes, it will escape the single quotes.


That's an improvement.


There's `check` in `addToStdlib.kt`


Can we get a `div` with a class and some CSS to handle the spacing instead of this?


could also use anonymous namespace here.


The functions seem pretty different; can you explain how it used to work and will continue to work with no change in the calling code?


いみふmっっd


better off put an empty line before this line.


cool thx for fixing ... can you add a small regression test?


sure


@duramato Could we do the same with newpct?? The purpose is to identify without doubt results from these providers (for white and black list)


Avoid object types in names.
For example ```user_array, email_method, CalculatorClass, ReportModule```


Т.е. мы не смотрим на то что он присутствует в макете?


Let's let the tests run and reevaluate


I'm assuming this is more along the lines of what you wanted https://github.com/aries-auto/ariesautomotive/commit/0e6907b4b10cac9dd3f9a4cc9c3892ba5df591c7


>Is it considered bad form to push commits before they are ready for a pull request?

No, but try to push something that is working. But sometimes it is better to push early for others to see and comment.

And yes, you have Travis that will try to build every branch. Use it to your advantage.


On the hot paths(read(), write() and toogle()) I can agree in use pwrite(), but on the others I don't see any reason to keep opening, writing and closing by hand when we have a method to do for us.


"_0_reference_1" -- This naming convention is nice in theory, but it falls apart when it can't express things like parentheses, etc. So I have no clue reading this what it's trying to convey. It could mean "This references that" or "Foo reference (note)" or "Foo (reference note)". And if you ever made another one from this set, it'd have the same name under this convention.


なんでー


This was my plan, but it was the wrong origin :scream:


I don't think I understand the purpose of this change.


Yeah. Some of this stuff feels more like duct tape than it should.


done


No problem in passing the 80 chars limit in this scenario? Just let the _pin on the other line?


if I may ask: why? are there any plans for an alternative?


Avoid object types in names.
For example ```user_array```, ```email_method```, ```CalculatorClass```, ```ReportModule```

When breaking an argument list, keep argument lists and closing parenthesis on their own lines.


Totally agree.


The interface is ok! I will open an Issue reguarding BaseTest::run().
Merging


The publish task should include building.


Let's document the CurrencyOptions message stating that its attributes contain information from ISO 4217 standard.


Thank you :+1:


@dpgeorge - Ahh - gotcha - I see that now. In which case this is fine. Since the SysTick handler itself is doing very little.


These comments are weird. This if statement fires when it came from the *same* project


@owwls Note that we need to use a direct image link as the 'src', rather than the File page on commons. Click on whatever size is slightly larger than one we need, and paste in that url.


catch (Exception $e)
In PHP7 \Throwable parameter is going to be expected. Skipping the type declaration would be better?


I prefer NULL over the casted zero... but, I will accept the patch as is... (Anyone feel free to adjust later).


There's currency symbol for RR. Please check.


I'm sorry I got that wrong, I agree with you... :+1:


Do you intend for this commit to be mixed in on this PR or was this an accident?


Please check the symbol.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6577](https://teamcity.mesosphere.io/viewLog.html?buildId=80084&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:08


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6578](https://teamcity.mesosphere.io/viewLog.html?buildId=80085&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:07


One which works drone to drone. It's part of the same product. How do you get the data from that one?


I am all for initial values, but i here does get set in the loop 'for (i=0; ....'


@kohlhase @angerhang  This is the first commit that broke the symdef generation, and I am sorry to say it is dated June 10. In other words it must be a pretty old problem by now.

Good news is that we can blame this one on Perl being way too "black magic" so @angerhang didn't realize there was a value returned by the factor method he changed.

By default, the result of the last expression of a Perl function will be its return value. In the snippet above, the returned expression is:
```
(Invocation(T_CS('\\@'.$cs->toString.'@construct'),$variant,@args)->unlist);
```

All follow-up changes to this commit keep adding logic **after** that line, which means it now evaluates in void context and is not returned - hence the symdef is never "constructed", as the macro name implies it would.

We refactored the core of LaTeXML to always have an explicit ```return``` keyword a few years back exactly to avoid this class of errors. Perl is just too silent / permissive and it allows you to hang yourself for any oversight.

I will push a fix to the sTeX master, I also want to patch a problem with the for and about attributes I just spotted.


I got 2 warnings: see screen shoot below.. any help, please??
```elisp
js2-mode.el:7820:11:Warning: defsubst `js2-inside-function' was used before it
    was defined

In end of data:
js2-mode.el:12681:1:Warning: the function `make-js2-await-node' is not known
    to be defined.
```
![compiling-js2-mode](https://cloud.githubusercontent.com/assets/3199677/11374537/73d0d296-92ce-11e5-9ae8-ae55dd6492bd.png)


comments on commit


This pattern turns typos into silent bugs. Instead throw an exception on an unexpected value.


Formatting looks off.. fclose(fd) line.


Is the source part fine for you ? Can I merge this branch ?


[新建 文本文档.txt](https://github.com/CloudLv/cry/files/42972/default.txt)


@stiopaa1 i am a little bit concerned about the $(LIBCOMMON). seems we need  some symbols offered by "buffer.cc" now? will this break the compatibility of existing clients linked against librados?


Curious line. What exactly is this doing?


okay. thanks. :+1:


When breaking chained methods, the broken methods should be indented with 2 spaces.
Add a new line after the chain.


Wellll..

I'd prefer to have a single constructor for CaptureContext. You could use the ucrt varaible like below:
``CaptureContext(context_t &context, BOOL debug, void* func, BOOL ucrt = FALSE, UINT_PTR fp = (UINT_PTR)_ReturnAddress());``

if i understand correctly ``crtdbgblockheaderucrt_t`` is defined the same for x86 and x64 while for ``crtdbgblockheader_t`` its different, thats why you need the ucrt variable.

but, can you  explain why all those functions were removed, where they unecessary to begin with ???


pika uses the same convention of putting the (mandatory) callback first, so this is OK with me.


Just use $last_updated directly.


There is only one notification for all stack applications (https://github.com/cozy/cozy-home/blob/master/server/initializers/updates.coffee#L45). We should remove it only if all stack application are up-to-date.


@dothebart how do we rebuild the Swagger API docs? I didn't update them manually.


This file list is a bit redundant :)


In PHP7 *you* have to expect `Throwable` in order to catch both regular exceptions and the new `Error` exceptions.

For the condition that I'm handling here, `random_bytes()` throws exactly an `Exception` instance.


looks like this change make problems with the github md view.


> Forge

OK, ask Alexander

> Liteloader

It isn't popular enough

> Bukkit

You mean plugin for servers? Impossible to add GUI. And why should server owners like it?


Add new line after this block.


Indent broken statements with two spaces.


Upload Source Code Folder


This comments is useful.


New-Fan-Object (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1971 of 1971 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This is throwing an assert in debug mode if duplicate entries are found for the same object type in the policy xml


I have no idea who that might be ;)


could be. I know there are some diff in parameters between Py2 and Py3 hence https://github.com/miki725/xunitmerge/commit/28e7898d354376d6ad01ec886999e70696ea1e75. Will have to check both implementation to see what they use.

@thp did this cause issue for you?


Looks good to me.


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 45 to 45.*

```
                                                                                vvv
                                                original_source_range.start.column,
```


Line is longer than allowed. (82 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 47 to 47.*

```
                                                                                v
                                                original_source_range.end.column,
```


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 49 to 49.*

```
                                                                                vvv
                                                modified_source_range.start.column,
```


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 51 to 51.*

```
                                                                                vvv
                                                modified_source_range.end.column,))
```


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 66 to 66.*

```
                                                                                vvv
                                                original_source_range.start.column,
```


It seems that the main point of this commit is to establish "default" policy for those types that don't have any specification in the policy.xml. Is that about correct? I have a habit of always entering a policy line for things that show up in inspector so maybe that is why this has not come up before. On one hand I rather like the program asserting if there is no policy, thus reminding the developer to think about it. It seems that the bug is that the behavior was not causing a clean assert, but instead something rather nondeterministic. In any case I don't think it should crash (obviously) or assert in a release build.  I'm ok with reintegrating as is.


Line is longer than allowed. (82 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 68 to 68.*

```
                                                                                v
                                                original_source_range.end.column,
```


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 70 to 70.*

```
                                                                                vvv
                                                modified_source_range.start.column,
```


Line is longer than allowed. (82 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 72 to 72.*

```
                                                                                v
                                                modified_source_range.end.column,
```


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 83 to 83.*

```
                                                                                vvv
                                                original_source_range.start.column,
```


Line is longer than allowed. (82 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 85 to 85.*

```
                                                                                v
                                                original_source_range.end.column,
```


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 87 to 87.*

```
                                                                                vvv
                                                modified_source_range.start.column,
```


Line is longer than allowed. (82 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 89 to 89.*

```
                                                                                v
                                                modified_source_range.end.column,
```


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 97 to 97.*

```
                                                                                vvv
                                                original_source_range.start.column,
```


Line is longer than allowed. (82 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 99 to 99.*

```
                                                                                v
                                                original_source_range.end.column,
```


Line is longer than allowed. (84 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 101 to 101.*

```
                                                                                vvv
                                                modified_source_range.start.column,
```


Line is longer than allowed. (82 > 80)

*Detected by LineLengthBear with severity 1 while running section `pythoncheck`.*

*The issue occurred in the file `coalib/results/ResultFilter.py`, lines 103 to 103.*

```
                                                                                v
                                                modified_source_range.end.column,
```


New-Fan-Object (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (1965 of 1965 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Included with this commit just out of laziness


TeamCity pull requests :: netty [Build 737](https://garage.netty.io/teamcity/viewLog.html?buildId=3569&buildTypeId=pulls_netty&guest=1) is now running


How about this wording:

     Generates a new random UUID.


If $use_cookie, this should be private.


`Bob` on previous line


Changed to "The connection must be decoded in order to use encoder learning".


`#if( MYDEFINEDPARAM == 1)`


When we retrieve instance information, they are in a map keyed by a `String`. There is no indication that this is supposed to be a number, other than the name "index", and we leave it as a `String`. Should we treat _this_ parameter as a `String` also? Or should we convert from a `String` to an `Integer` when retrieving application instance stats?
It would be convenient for the user to have them as consistent types, so as to use the output from one operation as input to another.


New-Fan-Object (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


This comments is useful.


@kbenne the heart of the bug was here, if no access policy was found then these were uninitialized and then they were used down below.


1 or 2 replacements for every piece of content for cosmetic reasons doesn't sound right to me. This should wait.


i think add anther check at first line in `select do |rem|` can solve this
```
reminders = MailReminder.select do |rem|
next(false) until rem.project.present?
next(false) until rem.project.enabled_module_names.include?('issue_reminder')
....
```
Can you try this on your environment? I am not using redmine 3.2 now. Thanks a lot :smile:


s/relavent/relevant


Ok, I'll keep that in mind.


Complex code block, you could simplify things by using methods.


this should probably be `ToFastString`.


`be very fast`? isn't `is very fast` better?


Should we send a minimal HTML doc saying the URL has expired? E.g. a user could innocently retry a download URL.


JavaScript please :smile:


Replace the -1 with 1 and it should much faster.


Time to code stuff.


My goal is to make minetest better. Everyone is welcome to comment/commit changes to any of my mods. I appreciate any help as long as it improves things. Feel free to jump in and help with any of my mods.


@dmtch the function is returning garbage because ret is not set in any place dunno if the return value is later used or if it has some security issues because of it.

Review and send a pr to fix this please since you know more the code :)


Yeah, I was hoping to play with `tooBoolean` (as to optional boolean). That's where `too` came from.


You should use UUID's :P


@oveddan Comments on github commits are not an effective place to have a discussion. Please join our [slack community](http://slack.babeljs.io/) if you want to chat.


It's a good practice to initiate any variable we use.


If you a have an issue, please file an issue and we can discuss there.


@73rhodes JSLint has never, ever aimed to be backwards compatible nor forwards compatible.


Yup, you're right.  It is better for this to match as a `String`.  The reason that it's a string in the other payload is because JSON requires all keys to `String`s.  Notionally, it must be a `Number`, but the payload format (JSON) won't tolerate that.


:shipit:


Right :+1:


Maybe you could have split the changes to two commits, to explain why the intermidiary functions were removed :)


For  readability, you can use the ``` % ``` operator to format the string.
For example:
<pre>
"%d%d%d%d" % [differences[0], differences[1][-1], differences[2][-1], differences[3][-1]]
</pre>


Yes, indeed.


@gyoshev what do you think about these "CSS has loaded" tests?


@gyoshev ditto


thanks @lmangani, I've just integrated your contribution into the official documentation :)


is the enum attribute on the correct element? seems it should be line 3048 that has that attribute


I'm 100% on board with even a one line increase in test coverage. We should remove `destroy` if possible!


Want to check self-reference and direct-reference too?


Should data-via be "wrightmartin"?


I took the freedom to add a v0.7.2 tag. See comments on 1632827.


Unfortulatelly this won't work on Idea 14, _withParentEnvironmentType_ method was introduced in version 15.
There are 2 choices, drop compatibility with v14 or go back to _setPassParentEnvironment_ til it is available.


Could we rename this to to `isDockerRunning` ?

This current name makes it feel like it will restart the daemon.


TeamCity pull requests :: netty [Build 737](https://garage.netty.io/teamcity/viewLog.html?buildId=3569&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5306, ignored: 21 Build time: 00:14:41


The facebook share button seems to be sharing a facebook URL for me when I use it on a local install - is it correctly configured?


@svenjacobs Can you open up a new PR with what you currently have and paste the above comment there so we can take a look at it? Thanks.


linting should be done before bundling


This is a new commit comment


I apologize for introducing this error and thank you for the detailed explanation.

Back then, I was never cautious about the values a `sub` returns  : - |


There is somthing wrong in the way the settings are handled. Even after erasing my settings it crashes after creating the background setting. It is the function that loads the settings that always crashes. Don't know why it does that, the settings look ok.


Oops, i'm sorry, i'm try to fix that


Maybe comment this test out, since it should fail now, as far as I understand?


This commit changed the type of `#/definitions/Game/properties/platforms` from `array` of `Platform` to `array` of `arrayOfPlatforms`. In order to change the property type to `arrayOfPlatforms`, replace

    platforms:
      type: array
      items:
        $ref: '#/definitions/Platforms'

with

    platforms:
      $ref: '#/definitions/Platforms'


If you move the file (and I think its a good move), please change the include guard macro to `RIPPLE_BASICS_QALLOC_H_INCLUDED`


No need to support 'ip' and 'ips'.
Just support 'ips'


This include should come right after the include for RawStateTable.h


@mark-vieira I wonder if this change is needed after making this change: https://github.com/gradle/gradle/commit/9c1f69f0 .


No need for strings, could we just do this?

```
let setup = util.isLinux() ? setupUtil.nativeSetup : setupUtil.nonNativeSetup;
```


We can do away with the extra `qalloc` namespace, its confusing (e.g. `qalloc::qalloc`) and superfluous.


@lsamayoa I'll roll out v0.9.10 in a few hours.


Hide cursor after 100 msec when touch released
```
export TSLIB_TOUCH_HOME_TIME=100
```


Do we need to include `<functional>` and `<utility>` since we use `less` and `pair`?


Yeah `qalloc::qalloc` looks goofy.. lol


is this a clearer way of fixing the failing spec? (otherwise it might come down to rewriting to either get rid of the fixture or pick a more convenient one)


Why is it breaking change? It didn't worked before so there is no differently encoded alternate just working one.
The 'if' statement is unnecessary here, you are right.


descirbed → described


ALL HAIL THE MASTER!


Keeping both changes shouldn't hurt. This commit simply reduces the amount of redundant work when finalizer tasks share a large number of dependencies. The commit you posted makes the redundant work less overhead but I see to harm in avoiding it altogether.


I'll be passing shortly, just wanted to make sure these minor things don't cause conflicts to your code.


Faz em plain HTML em vez de ERB, para se manter a coerência entre todos os ficheiros sff.


of → if


This happens in the ReadAllConfig()

```csharp
            config.ReadFromConfigSection();
            config.ReadFromAppSettings();
            config.ReadFromEnvironmentalVariables();
            config.ApplySavedServerSettings();
```


When I say "this commit" I'm actually referring to the original PR 46f757b.


Done !


"Fixed" in c194733.


to → too


Hello @jogness,

We have a situation where we are using UART2 on the Beaglebone Black without RTS/CTS and we see a ton of overflow errors on the port.  At some time the Beaglebone completely locks up under heavy load.

The port is configured as 3Mbps and exhibits the same issue if we load it in via a device tree overlay or have it compiled into a dtb at boot.

Connected to the other end is an ARM micro controller also set to 3Mbps spitting out the data to us.

Currently running 4.1.13-ti-r33 but we've had this problem since starting as this is a new board we are making.

What info can we get/need on the lockup.  Nothing is reported in the system logs at all or on the serial debug cable console at the time of the hang.  Only a power off and back on solves it.


O.o

Date: Sun, 22 Nov 2015 14:21:36 -0800
From: notifications@github.com
To: Easy-Order@noreply.github.com
Subject: Re: [Easy-Order] Pedidos pendientes y entregados para vista del administrador y chef (2923257)

Mínimo ponle un nombre al modal

—
Reply to this email directly or view it on GitHub.


With this diff against master, it seems to loop forever at 100% CPU when running. Is this the modification you wanted me to test?

diff --git a/lib/tasks/reminder.rake b/lib/tasks/reminder.rake
index a1d2bb5..aebcc5d 100644
--- a/lib/tasks/reminder.rake
+++ b/lib/tasks/reminder.rake
@@ -5,6 +5,7 @@ namespace :reminder do
     require 'colorize'
     mail_data = Hash.new{|h, k| h[k] = Set.new}
     reminders = MailReminder.select do |rem|
+      next(false) until rem.project.present?
       next(false) until rem.project.enabled_module_names.include?('issue_reminder')
       next(false) until rem.query.present?
       print "Project \"#{ rem.project.name }\" with query \"#{ rem.query.name }\" "


You got it


This is a new commit comment, the status is: error


This is a new commit comment, the status is: success


> I just think the level of understanding for render/3 is quite steep for simply wanting to render a view. As a developer, my goal is to simply show a page.

Well, you don't need to *understand* it. It is already generated there, you can mostly ignore it if you don't care. For example, Rails uses `yield` in the layout which is not straight-forward to *understand* at all as it is a control mechanism for Ruby blocks. How does a template becomes a block given to the layout in the first place? I would say few Rails developers actually *understand* how it works. So why do we care about it in Phoenix?

We may be underestimating how simple and powerful `render/3` is. Compare this to Rails:

* In Rails, layouts use yield. Which, if you really want to understand how it works, requires you to understand ruby blocks. In Phoenix, you use `render`.

* In Rails, to send data from templates to layout, you use content_for and yield with a symbol. In Phoenix, you use `render`.

* In Rails, to render a template from another template, you usually rely on partials. In Phoenix, you use `render`.

There are at least 3 major Rails abstractions being replaced by `render/3`. Learning it is not only worth it, but necessary. And at the end of the day, compared to other frameworks, you will have to learn *less things*.

> as an entry level barrier ... the render/3 function ... feels quite heavy.

If the issue is that `render/3` feels heavy, the answer is not to hide it, but to make it clearer. Should we improve the docs? Should we have more examples? How can we make it lighter?

For example, as soon as you run `mix phoenix.gen.html`, we do use the `render/3` function. There is no escape from it. If you want to build something remotely useful, you need to know how to use it.


nit: use `const Duration` – avoid allocating a new Duration object every loop

better yet, just store the duration as a const


convinience → convenience


This is a new commit comment, the status is: failure


We should 404 here if the cookie's empty, right?


It did compile! :stuck_out_tongue_winking_eye:


@mark-vieira looks good to me.


@lighta cleaned up the source points I had in mind! Go ahead and merge it!


I'd log session id


@jogness here's @leearmstrong custom dts for the bone black:

https://github.com/RobertCNelson/dtb-rebuilder/blob/4.1-ti/src/arm/am335x-boneblack-ttyS2.dts

```
#
# Serial drivers
#
CONFIG_SERIAL_EARLYCON=y
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_DEPRECATED_OPTIONS=y
CONFIG_SERIAL_8250_CONSOLE=y
# CONFIG_SERIAL_8250_DMA is not set
CONFIG_SERIAL_8250_PCI=y
CONFIG_SERIAL_8250_NR_UARTS=6
CONFIG_SERIAL_8250_RUNTIME_UARTS=6
# CONFIG_SERIAL_8250_EXTENDED is not set
CONFIG_SERIAL_8250_DW=y
# CONFIG_SERIAL_8250_EM is not set
CONFIG_SERIAL_8250_OMAP=y
CONFIG_SERIAL_8250_OMAP_TTYO_FIXUP=y
```

```
CONFIG_DMADEVICES=y
# CONFIG_DMADEVICES_DEBUG is not set

#
# DMA Devices
#
CONFIG_DW_DMAC_CORE=y
CONFIG_DW_DMAC=y
# CONFIG_DW_DMAC_PCI is not set
# CONFIG_HSU_DMA_PCI is not set
CONFIG_TI_EDMA=y
CONFIG_TI_DMA_CROSSBAR=y
CONFIG_DMA_OMAP=y
CONFIG_TI_CPPI41=y
# CONFIG_FSL_EDMA is not set
# CONFIG_NBPFAXI_DMA is not set
CONFIG_DMA_ENGINE=y
CONFIG_DMA_VIRTUAL_CHANNELS=y
CONFIG_DMA_OF=y
```


I use haml (mthaml), there's even a *silex* extensions for that purpose. All my projects are using haml.  I'm Bolt user) Can you at least use '.haml' string as i suggested)? It's safe, it doesn't break any BC. And i want to use that feature, and.. alsto '.html' probably would be lovely (or it works already?)


From a Webpack perspective, does NODE_ENV being set to production matter when building? Or is this more for compatibility with other libs?


This can just be `I18n.locale.underscore`


and in `leaseCompileSession` too (with `aliveFlagPath`)


This project isn't using django-local-settings, so adding it to the project's requirements shouldn't be necessary.


y-you too


Is this the diff you want me to test?

```
diff --git a/lib/tasks/reminder.rake b/lib/tasks/reminder.rake
index a1d2bb5..aebcc5d 100644
--- a/lib/tasks/reminder.rake
+++ b/lib/tasks/reminder.rake
@@ -5,6 +5,7 @@ namespace :reminder do
     require 'colorize'
     mail_data = Hash.new{|h, k| h[k] = Set.new}
     reminders = MailReminder.select do |rem|
+      next(false) until rem.project.present?
       next(false) until rem.project.enabled_module_names.include?('issue_reminder')
       next(false) until rem.query.present?
       print "Project \"#{ rem.project.name }\" with query \"#{ rem.query.name }\" "
```

If so, this one loops at 100% CPU for a long time, I assume it will go forever.


Bill, This commit should have fixed the enum
https://github.com/mavlink/mavlink/commit/8598606c8c3dc8f6f47fb7b5b2e8951bb876ac7b

Is that what you're talking about?

On Tue, Nov 24, 2015 at 9:35 AM, Bill Bonney <notifications@github.com>
wrote:

> is the enum attribute on the correct element? seems it should be line 3048
> that has that attribute
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mavlink/mavlink/commit/794b5956ab20e1694f891b5591c65475f378d1ec#commitcomment-14595825>
> .
>


I totally looked for that and didn't find it :-(


Thanks @RobertCNelson, sadly I just got the lockup using this too.


Did you intend to leave the 204 "Accepted" responses in lines (146)[https://github.com/osu-mist/videogame-sample-api/commit/9c32191139990251f933050064fe0560d3cd81bb#diff-bac86ae86657c2fa2c3dd2ab26df4960R146] and (283)[https://github.com/osu-mist/videogame-sample-api/commit/9c32191139990251f933050064fe0560d3cd81bb#diff-bac86ae86657c2fa2c3dd2ab26df4960R283]?


it gives me an error if I remove that. That was the only way I could get
make to successfully complete.

On Tue, Nov 24, 2015 at 9:50 AM, Wyatt <notifications@github.com> wrote:

> This project isn't using django-local-settings, so adding it to the
> project's requirements shouldn't be necessary.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sean97140/ITS/commit/75cda9ae4cfd4de90a0513cb31625dd151d36d72#commitcomment-14596172>
> .
>


Já está alterado

On Tue, Nov 24, 2015, 17:45 André Pinheiro <notifications@github.com> wrote:

> Faz em plain HTML em vez de ERB, para se manter a coerência entre todos os
> ficheiros sff.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pluralism/ldso1516/commit/1e4236ef3fbf3ad8e36e4748dbaab9dfccd7413c#commitcomment-14596033>
> .
>


What error did you get?


Can we use variadic macros instead to test for multiple packages simultaneously? That would allow us to write

#if !defined(HAVE_MUELU_IFPACK) || !defined(HAVE_MUELU_AMESOS)
MUELU_TESTING_DO_NOT_TEST(lib, Ifpack, Amesos)
#endif


Yes, you are right -- cut-and-paste error.


Typo: itlsef -> itself?


Which new profiles are you referring to?


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1432 of 1432 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Very well written! Maybe what would make it clearer would be adding something to the `render/3` docs, or in `Phoenix.View` that explains some ways you can use render/3, and what `@view_template` and `@view_module` are and where they come from. The block for me is figuring out where those assigns come from and how to change them.

What do you think? The docs are already quite good, but adding the view_module/template explanation might clarify things a bit more?


`ActiveSupport::Inflector` for all of Rails weird string related transformations ;)!


Thanks @samccone! :100: This should make the process work.  :dancers: :dancers: :dancers:


@dpgeorge: FYI


Instead of pulling django-arcutils from github, `django-arcutils>=1.1.1,<2.0.0` should be added to requirements.txt.


Hmm, still need to turn it to a string before `.underscore` and it also removes the caps of the country code, which Adyen still wants.


I was just looking at
```
# CONFIG_SERIAL_8250_DMA is not set
```
but based on: http://git.ti.com/gitweb/?p=ti-linux-kernel/ti-linux-kernel.git;a=blob;f=ti_config_fragments/baseport.cfg;h=ce61c64de65c3daae25b133e1b333db1fb772d2c;hb=refs/heads/ti-linux-4.1.y#l13

```
CONFIG_SERIAL_8250_DMA=n
```
Maybe it's worth a test?


Yep, thx


This is wrong. By Epetra (Tpetra) it means here the Epetra (Tpetra) version of smoothers. It may have nothing to do with whether Ifpack/Ifpack2 is enabled, as those could be enabled but throw an error, or it could be a template error.


fix spacing in this file


same here spacing off


OK, it makes sense. I have updated the i18n TODO accordingly:
https://github.com/c2corg/v6_ui/issues/6#issuecomment-158468502


:laughing: :+1:


fix spacing ;)


put a space between line 22 and 23


I think anything is worth a go at this point, I've started to really pull my hair out over this and it's starting to get outside my comfort zone now too!  How do I change that?


Could not find a version that satisfies the requirement
django-local-settings>=1.0a10 (from django-arc-utilites...) thinking of it
now, since I fixed the version, it might not require that now.


Change to `Each Docker image references a list of read-only layers`...

`15:04` should probably be `15.04`.


I am unaware of a drone-to-drone transponder, this product is an ADS-B receiver which is limited by that protocol. If we have another drone-to-drone comm that is not ADSB then it needs it's own message.


This has been addressed by #264. You probably want to back this change out.


Can we make the squawk string null terminated always, it leads to less problems in implementations.
The other question is, where is it specified that the squawk/callsign is only 8/9 characters long? I was trying to find spec to confirm this part, but haven't found something to confirm or deny this


Done.


read and write iterators in sd_bus_message() are internalized. That means we can pass the message around, and that includes the read position. At the point we call machine_start() the read ptr is at the first properties element we received, hence when machine_start() calls machine_start_scope() it will still be, and the sd_bus_message_copy() just copies them over.


I suggest delaying retries on network errors, as sending too soon after the original failure may still encounter the error.
Also, we may want to increase the retry depth from 1 to something higher.


Do you still need to run this test?


The first sentence isn't quite right because you can't add files to an image directly - you create a new layer and then create a new image that uses that layer.


again, this seems very small, where can i confirm this will always be within acceptable range?


Good point. It is not strictly necessary for now but is is safer to make sure that it compiles before deploying.


put a space between line 44 and 45


Hmm in that case the gsub is probably more appropriate.


Is this intentional? This is the right way to do, but requires variadic macros.


What would be the result of the following requests?
* `GET /platforms?console=true`,
* `GET /platforms?console=foo`, and
* `GET /platforms?console=true&computer=true`?


Can't wait to see how this works out :-)


We only want to replace ``MetadataDirective`` if it is not currently in ``request_params`` correct?


Thanks for the explanation!

/cc @iaguis


:tada: :tada: :tada:


This commit is meant for issue fsprojects/Paket/issues/799


yes I think that could be another idea to fix the problem. Then, we need to
modify `util.lua` to consider the case when the input is
`nn.DataParallelTable`. Right now it assumes the input is a single column
model with `nn.Concat` container.

On Tue, Nov 24, 2015 at 11:49 AM, Alfredo Canziani <notifications@github.com
> wrote:

> I think we don't need lines 42-46 but call makeDataParallel() from the
> util.lua script. What do you think?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/e-lab/imagenet-multiGPU.torch/commit/07bd14abf7c1281199275f439e29767f19915df6#commitcomment-14594534>
> .
>


This little fix seems to have been removed in the latest version, or at least the version I have v2.5.2,

Can you confirm?


New-Fan-Object (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (897 of 897 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.34%25-green.svg)


kjhekujfh
\


Looks right. What's the rationale for not having the more concise syntax for other 'products'? Perhaps it is a matter of labeling. I'd propose 'top-level' versus 'products' if they need to remain separate for some technical reason.

Also consider this a feature request: Add aliasing so that 'http://raw.githubusercontent.com/OmniSearch/ncro/master/src/ontology/' doesn't have to be written so often.
e.g. yaml

<pre>
aliases:
 - obase=http://raw.githubusercontent.com/OmniSearch/ncro/master/src/ontology/
...

entries:
  exact: /dev/ncro.owl
  replacement: $(obase)/ncro.owl
</code>
</pre>


You beat me to the fix :)


I addressed some of your concerns here
https://github.com/cinterloper/txhaproxy/commit/732890edaf050c42339a4150d3d0470d0eab9966

to be honest, i think the call to render the template is a blocking call, so i dont think node could take any requests in parallel, but, ive sketched out some in-memory locking anyway. to guard against other programs (there should be none yet) this would have to be come fs locking and watch out for stale locks


I would consider renaming `target_arch` to `gyp_target_arch` to avoid confusion and possible errors.


> What do you think? The docs are already quite good, but adding the view_module/template explanation might clarify things a bit more?

I believe @chrismccord did add those to the documentation. But you have a really good point in that we could make a better at documenting other use cases, having a couple dedicated sections. We do have time before the 1.1 release, so PR please. :D

> Would a comment in the application layout help as well? Something simple like, "this renders the template from the connection"

I thought about this but I couldn't find a way to make it relevant. Or it would read exactly like the code (render the actual view/template passing the current assigns) or it would be too generic (see the documentation for render/3). Generic in the sense every time you see something you don't understand, you should check the docs. It is not specific to `render/3`.


I reverted this in 8183e2f833ad3e1834ac43959527ccc9d20812c3, as nothing runs with it.


It's probably best just to squash this into 80932ec76704c93d4e33c


Apparently this commit is hanging right now on AppVeyor Win64? https://ci.appveyor.com/project/StefanKarpinski/julia/build/1.0.11182/job/lk90qaw8lpemtp8t


Dan actually told me that a few weeks ago, so I felt super guilty about it still being there :-)


This is what I had envisioned from the start. The previous version fails unless you override all the functions on the sub classes which is unnecessary.


Please remove unused code.


on an x86 (for speed)

```
git clone https://github.com/RobertCNelson/ti-linux-kernel-dev.git
cd ti-linux-kernel-dev/
git checkout origin/ti-linux-4.1.y -b tmp

./build_deb.sh
(in makeconfig, enable

Device Drivers  --->
Character devices  --->
Serial drivers  --->
[ *]   DMA support for 16550 compatible UART controllers
```
A final *.deb will be under deploy directory, copy to beagle.

Before you install it via dpkg, copy your custom "am335x-boneblack-ttyS2.dtb" as it'll get overritne

```
sudo cp -v /boot/dtbs/4.1.13-ti-r33/am335x-boneblack-ttyS2.dtb /home/debian/
```

then install the kernel via:
```
sudo dpkg -i linux-image*.deb
```
and copy back the custom dtb
```
sudo cp -v /home/debian/am335x-boneblack-ttyS2.dtb /boot/dtbs/4.1.13-ti-r33/
```

Regards,


Since (as I demonstrated by my question earlier :)) it's easy to miss this helpful comment in the large diff, I think it would be good to include it in this commit message.


Yeah good points on the comment in the layout. Probably wouldn't add much value. I can try to get those doc examples in before 1.1!


oui naturellement il faut faire un commit avant d'envoyer ^^"


@maxGimeno What is that supposed to do?

With those two CMake commands, you tell CMake that there exists an imported target of type "executable", and you precise that its location is `.../example_plugin.cmake` (but that file is a CMake file, and not an executable file).

I suggest that:
  1. you remove or modify those two lines, depending on what were you intentions,
  2. you read the documentation of CMake about imported targets.


There are exactly two APIs that have and will violate the existing `AbstractSpringOperations` design.  Adding this level indirection, to satisfy one of those, isn't appropriate.  Please roll this back and confine the "special" `PUT` behavior to the one method where it is needed.


We should probably include the corresponding changes in src/res/node.rc from a6aab430936c4c2791dbb29d8adec9d9a12f9376


Thanks :)


1. Are the `Platform` properties `computer` and `console` mutually exclusive?
2. Do you anticipate any other types of platforms? For example, might you extend the API to include handheld gaming devices or smartphone apps?


yes, although it hasn't actually started running any of the changes in this PR so this should be OK to merge, while we need to keep investigating for that other issue


Remove the whole line, it'll use the system-default/user-specified `CXX` instead


If a variable has a lower bound of 0 and is in a variable cone, then the dual on that cone corresponds to a reduced cost. We're missing that here. I'm wondering if it would make sense to translate all variable bounds into linear constraints instead of sometimes using variable cones. CC @joehuchette


Sorry mcccs but I did not mean this.
@Alexander01998 You might be interested to add a patch like [this] (https://github.com/MinecraftForge/MinecraftForge/blob/master/patches/minecraft/net/minecraft/client/ClientBrandRetriever.java.patch) (of course change `"vanilla"` to `"wrust"` instead of some mod lists)


This should be from shortest to longest


There is no documentation stating that this is how non-async behaves.


Thanks so much for this, I've changed in in my fork as I didn't want to overwrite the input files. But cool!


Curious why we both log and print


     def makeNewTable: MemTable[K] = new FiloMemTable(projection, config)

There's no arg...


Completes the implementation of #7 in a first step (not all object types are implemented yet)


The couch version of `save_processed_models` is just a `bulk_save` but the SQL version has more logic (due to the split up models). Now that this is outside of the implementation this is the 'generic' way to save processed forms.

This is also closer to what actually happens during form processing.


I just thought you are actually fixing the intermittent AppVeyor Win64 we have on master... =(


So close, but we need to add git config to .travis.yml.  Something like this maybe:

```
- git config --global user.email "github-admin@google.com"
- git config --global user.name "googlebot"
```


Clean!


Good catch. Changed to ਅਪ੍ਰੈਲ.


I'm not keen on adding a type not called `Resource` to a `resource()` argument.  In addition, the only reason that the `ResourceFingerprint` name was needed was because you were worried about confusion with the existing `Resource` types.  If the original design had been used, the type would have been `UploadApplicationRequest.Resource` which would have had no ambiguity.  Please restore that design.


@velvia LGTM


I got it :)


For the Plebs


No deviations should occur in naming. Rename this to Builder.


Don't check if `_token` exists, because if it does not exist, it will return null which will still make the condition to fail, so just go ahead and do the comparison `$request->_token === $request->session()->pull('_token')`


Appreciate that Robert, I will get cracking on that.  If this fixes it could it make it into the normal kernel config for the BBB?


In colloquial Punjabi, its pronounced 'ਅਕਤੂਬਰ'. Currently agreement on Unicode CLDR is to use the same.


The macro isn't variadic -- it just takes two arguments and includes the second in the message.


Gonna continue with the dialect at home


Remove line [35](https://github.com/osu-mist/videogame-sample-api/commit/9c32191139990251f933050064fe0560d3cd81bb#diff-bac86ae86657c2fa2c3dd2ab26df4960R35) to prevent Swagger from overwriting earlier `parameter` definitions.


Will changing order of these overloaded constructors help?


Should be resettable and renamed to Builder.


Would it be clearer for `year` to be of type `integer`?


I have to recheck this one. Not sure.


It would actually be a lot simpler to implement `targetPlatform`-like appender methods "on-demand", i.e. only when the user explicitly states that they want such a method generated.

@adammurdoch mentioned that we could also just let users implement a bunch of these methods on their own. This could be a really flexible way to handle things, but this brings up another question: how can users attach behaviors like this to a managed type?

Abstract classes offer a nice shortcut we can take for now to supply implementations for some managed methods. But forcing users to use abstract classes when they want to expose nicer DSLs instead of nice, lightweight interfaces is not a good idea IMO. We need a way to attach behavior to interface types as well.


Can you test locally that creating a Widget with a name `foo-bar` and an alternate name `Widget-Name-foo-bar.cshtml` won't find the file as an alternate. If so then just remove the `if`.

Or you can just add the two alternates, the one with the `Replace` and the one without, with a comment on the one without that it is obsolete and will be removed in a major version as a breaking change.


Nvm, I see it helped now :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6581](https://teamcity.mesosphere.io/viewLog.html?buildId=80104&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:07


its look copyright yummm miyaaaa


Yeap, if it fixes i'll make it default, for newer subsystem's (SERIAL_8250_OMAP) i usually go by ti's reference config defaults.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6582](https://teamcity.mesosphere.io/viewLog.html?buildId=80105&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:08


i just chatted with a colleague at work (who used to work for Ratheon/Hughes on air traffic control systems). I think the callsign field/squawk should be separate fields. 4 octal digits for the squawk and the callsign separated (depending on the max length). Packet size is always an issue though, so understanding how that change impact that is the question?


Remove lines [170](https://github.com/osu-mist/videogame-sample-api/commit/9c32191139990251f933050064fe0560d3cd81bb#diff-bac86ae86657c2fa2c3dd2ab26df4960R170) and [176](https://github.com/osu-mist/videogame-sample-api/commit/9c32191139990251f933050064fe0560d3cd81bb#diff-bac86ae86657c2fa2c3dd2ab26df4960R176) to prevent Swagger from overwriting earlier `parameter` definitions.


I could use variadic macros, but IMO that's the same as MUELU_TESTING_DO_NOT_TEST(lib, "Ifpack, Amesos"), since the 2nd argument is just for the output message.


Great will report back once it's all compiled and installed.  I've used build_deb before and know it can take some time :-)

Will it be a case of the kernel will just use the newer driver or will we have to tell it to use it?


Agree again. Changed to ਜ਼ਰੂਰ


bc i don't like the code

you can try to patch it up if you want, i was getting segfaults. better to scrap everything than to try and figure out what is causing the problem, wasting more memory


Would it make sense to define the input type of `console` and `computer` as `boolean`?


Does this table file need to set `LD_LIBRARY_PATH` and `DYLD_LIBRARY_PATH`? This package does not seem to build any shared libraries (or at least I can't find them).


Ok, I can remove that.

Any other issues?

Will Arthur
Intel Corporation
Server Security Firmware
803-216-2101

From: Gang(Jimmy) Wei [mailto:notifications@github.com]
Sent: Tuesday, November 24, 2015 11:07 AM
To: wcarthur1/TPM2.0-TSS <TPM2.0-TSS@noreply.github.com>
Cc: Arthur, Will C <will.c.arthur@intel.com>
Subject: Re: [TPM2.0-TSS] Removed check for NULL sysContext in _Prepare. Moved this check into CommonPreparePrologue. (5da9e09)

In InitSysContextFields()
SYS_CONTEXT->rval = TSS2_RC_SUCCESS;
SYS_CONTEXT->nextData = SYS_CONTEXT->tpmInBuffPtr; + SYS_CONTEXT->rval = TSS2_RC_SUCCESS;

Above is duplicated initialization to SYS_CONTEXT->rval.

—
Reply to this email directly or view it on GitHub<https://github.com/wcarthur1/TPM2.0-TSS/commit/5da9e09207226e34de86316b30262ef784caaa4c#commitcomment-14593124>.


Remove TODO if completed.


and there it is:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/8250/8250_omap.c?id=refs/tags/v4.4-rc2#n574

```
static irqreturn_t omap8250_irq(int irq, void *dev_id)
{
	struct uart_port *port = dev_id;
	struct uart_8250_port *up = up_to_u8250p(port);
	unsigned int iir;
	int ret;

#ifdef CONFIG_SERIAL_8250_DMA
	if (up->dma) {
		ret = omap_8250_dma_handle_irq(port);
		return IRQ_RETVAL(ret);
	}
#endif

	serial8250_rpm_get(up);
	iir = serial_port_in(port, UART_IIR);
	ret = serial8250_handle_irq(port, iir);
	serial8250_rpm_put(up);

	return IRQ_RETVAL(ret);
}
```
Yeap, let me asap if fixes it. ;)


Would it be clearer for the `year` query parameter to be interpreted as type `integer`?


whitespace.


Done via https://github.com/discourse/discourse/commit/99c1aa2e85bf8137dba8691ff86afb23a30f0939


Non-dnx implementation restored.


good.


LGTM. I'm assuming you ran the e2e test app after making this change?


@sebastienros as @barthamark mentioned the alternate with dashes, although was created, never worked. There was an alternate entry for it but you couldn't actually make use of it, see the issue: https://github.com/OrchardCMS/Orchard/issues/3379


Okay it has been pushed but no modification on this side...


Hello Assil,

Please PR to develop branch in the future!

Merged this also!

Thank you!


I think the class should be named `LoginInfo` because the noun "login" is one word. As opposed to the verb to "log in", which is two words (which is why I like the casing of the `logIn` methods in the client). Apologies if this seems overly pedantic.


Good catch. It should be ਕਲ਼ੀ। Changed.


They could still be useful for 3 or more args, for instance:
MUELU_TESTING_DO_NOT_TEST(lib, "Galeri", "Ifpack", "Amesos").


ALSO ANOTHER ONE MORE THING haha ... this should likely match the $dsid passed in. Also it's possible for $document to be NULL if FALSE was passed in for the $pid? But I don't see that ever being a problem.


Yes thats fine, there is a lot to do here, and I want to be sure of the right order to do it in before getting too far.


Thanks for the fix!


So I'd just write MUELU_TESTING_DO_NOT_TEST(lib, "Galeri, Ifpack, Amesos").


IIRC I was seeing many `IOException` or `ObjectDisposedExceptinon` when using the `ReadAsnyc` and couldn't find a place to catch them so they were leaked to ambient exception list then failed the tests in `TearDown()` randomly.  So I changed to use `Read()` and later wrap it with try-catch block.


Let's do it now, it should be low-impact enough. I have plans for some larger-scale refactors that I want to wait until we're at a feature freeze to do.


Any progress on this?


Looks good


oops! I think this should still be userInputData


TeamCity pull requests :: netty [Build 738](https://garage.netty.io/teamcity/viewLog.html?buildId=3570&buildTypeId=pulls_netty&guest=1) is now running


This change is in the repo "android_device_lge_g3-common", also check that you are on cm-12.1 on both repos


I'm really not sure if this was the right thing to do. `EnableAllWarnings` generates tons of warnings in standard headers, notably a practically infinite number of C4820 ones, so it's practically unusable. And there is no way get `/W4` option any more.

Also, this is inconsistent with `gnu` as `g++ -Wall` doesn't enable absolutely all warnings neither, you need at least `-Wextra` for this and even then I think there are still some warnings not enabled even by it.

IMO the best would be to add some new `extra` value of the bakefile `warnings` to correspond to `EnableAllWarnings` and `-Wall -Wextra` but revert this change for MSVS.

What do you think?


I did not think it needs such a setting ... it has python and cython generated C code only. Is there a test I can do to be more certain?


@ThomasBurleson Agreed.


several reasons, the 'atomic' part is to ensure apps opening the file will either see the old version or the new, not a 'mangled' version in the middle of copying.  There are also selinux and other things built into atomic_move that shutil does not account for.


Updated.


nit: can you remove "for the UI" from this comment?


Thanks for the tip. I'll stop diverging now :)


This was for testing only.

I will correct it later and test it..... hopefully this evening and release for beta testing.


I think this test is backwards - it tests for `this:GetUnFreezable() ~= true`, whereas it should only freeze/unfreeze if it *is* true.


:beers:


Added an appendix, as opposed to putting the instructions for installing anaconda inline @adamhajari


Removing the use of `virtualenv` created more problems than it fixed with `omego`. I'd suggest addressing this dependency in a future PR.


I realize this is how it is in master, however "Node.js" seems like a more appropriate description than "node".
https://msdn.microsoft.com/en-us/library/windows/desktop/aa387764(v=vs.85).aspx


Sounds like just removing them is fine. Opening a SIM JIRA ticket and testing the ticket branch on Jenkins to ensure that lsst_sims builds is the best way. I'm also testing on OS X El Capitan and it will be obvious there because we need a new library path environment variable to be set for some tests to pass.


Could you use `@Bind(R.id.toolbar_bottom) Toolbar toolbarBottom;` instead? At the beginning of the class you can place it below the others. Also please change them again to one line. Android Studio changes that automatically, but it looks very ugly like that.


Perhaps there should be a check to make sure that this isn't called more than once when it is not supposed to. I'd imagine that'd be rather dangerous.


Sorry @eladnava for missing this


Fixed: https://github.com/FenneX/FenneX/commit/ee5684777d54aa138202c1f847545771556ae106


Aw; shucks. I was quite proud of that.  :smile:


Alright just a few test and I merged it


Oh, OK. I misread the code, thinking you have (lib, "Ifpack", "Amesos"). No objections then.


:+1:  on the commit.


Sounds great. Thank you!


Wir lassen es erst einmal so. So wichtig ist mir der IE9 jetzt nicht, wobei ich weiß, dass er gerade bei Unternehmen leider noch anzutreffen ist, aber die dürfen sich meistens ja eh nicht auf Facebook und Co. rumtreiben ;)


GoGetMe YouTube Link

https://youtu.be/Y3iLwElgbU0


Why again?


Please place the variables in the same line as `@Inject`


:+1: on the commit, though the line item extra expect is weird.


Ok.


Still not working. But we will get it!  Looks like you might need to use  email `sam@samx.it` and name `samccone` and possibly update `- secure: ...`


:+1: , much more descriptive.


Rahul,

1. I think wait for another day is fine. As I commented in the email thread, forcing the correct behavior is a good thing. However, this does mean that our automation setup will be affected and we likely need to modify some of the scripts to make it work once this is merged. Thats' why I think giving more time for folks to comment is prudent. BTW, backward compatible means with the new code, existing configuration still works. And it is possible and should be easy to make it backward compatible.

2. The comment line for the following seems wrong. It was there before, but might be a good time to correct it.
# Zookeeper node IP address
 DRILL_STORAGE_PLUGIN_SERVER=IPADDR1


@jjones646, I found a shortcut


все оступы и пробелы необходимо привести в порядок, чтобы этого не приходилось делать проще сразу использовать IDE, например WebStorm


Fair enough.  It isn't a `Resource`, though, is it (mumble)?


Am I missing a reason to not use `str.ljust` here?


cool!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6583](https://teamcity.mesosphere.io/viewLog.html?buildId=80108&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:07


yes


I get that it's not the same as most of the other `Resource`s in the system, but sadly, the imprecision in the CC API naming means that it is _some_ kind of `Resource`. :grimacing:


:+1: just perfect


функцию проверки лучше вынести отдельно, отлавливать надо изменение всех 3 полей, при этом лучше использовать событие oninput, которое срабатывает сразу, а не после потери фокуса


Actually, I think this is ok.   triedEpetra_ can be false only if
    1. At least one of Epetra/Ifpack are disabled.
    2. An exception different from RuntimeError was thrown at line 96, in which case no one catches it and execution probably ends badly.


i think it is an issue with the secure key... resetting


var в этом месте ошибочен, тк переменная должна быть объявлена выше


From issue #742


тут нужен var


Why would it be empty?


hello hello
test test test test


Do you have host name lookups on? If not consider doing so - will make analysis easier http://httpd.apache.org/docs/current/mod/core.html#hostnamelookups


@kriox26 @Jorch95 like this


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 117](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=516&buildTypeId=XbimEssentials_XbimEssentials) is now running


These two are not necessary. The server sends us initial lighting conditions.


@mkantor - Of course! Whatever is easiest for you. Thanks for your feedback!


TeamCity pull requests :: netty [Build 738](https://garage.netty.io/teamcity/viewLog.html?buildId=3570&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5291, ignored: 21 Build time: 00:14:59


Il faut préciser le remote.port désormais car le 22 n'est plus écrit


Hey @asakusuma doesn't this break the ```--config-file``` option? It doesn't seem to be working for me in the latest ember-cli...


The flask.session has been removed because this situation does not need any session for authorizing an user get logged in.


BoringWords и так публичный проперти :) так что можно этот метод убрать и вместо него использовать Handler.BoringWords


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 117](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=516&buildTypeId=XbimEssentials_XbimEssentials) outcome was **SUCCESS**
Summary: Running Build time: 00:01:57


The for loop above verifies that the role threshold has to be >= 1.  It seems weird for the root threshold (or even the snapshot, timestamp, or targets threshold) to be > 1, since we only generate 1 key for each role, but [the tuf spec](https://github.com/theupdateframework/tuf/blob/develop/docs/tuf-spec.txt#L232) seems to indicate that each of these roles can have multiple keys and a threshold > 1?


However, this functionality seems silly here, and there is no UI exposing it. So I'm just going to pass nil all the time.


Have you checked to make sure this is actually called?


Yeah @mkantor, I agonized on this a bit. I was considering an enum representing "regular straights", "royal straights" and "all straights" but settled on this. so if you call with no args you get all straights. If you call with true, false you get all straights BUT royal. If you call with false, true you get royal only.


Following comment by Links2004  https://github.com/esp8266/Arduino/commit/866921c54a889a7cb96cc3c24c304d6809dbb603#commitcomment-14595451 I have also noticed issues with formatting.
Please see below an example - a screen shoot displayed on freshly installed Chrome.
In IE 9 it looks the same. Both on Windows 7.

![image](https://cloud.githubusercontent.com/assets/12953787/11376710/ee301ee0-92ea-11e5-9bfa-a8783a30ad22.png)


Also, I would guess that the lighting gets calculated after the chunk has been recreated, which means that the mesh has the wrong lighting.


Have simplified this - warning relies heavily on my added spec methods being correct - so that updating `InfoRequestEvent` or `IncomingMessage` causes `InfoRequest` to update itself, which is a step in the right direction.

Is there ever a case where `InfoRequestEvent` is updated independently from `IncomingMessage`? If not then the callback on `InfoRequestEvent` isn't needed. (Asking this before trying to work it out for myself.)


Maybe extract an interface `MessageGroupFactory` and change hard references to `SimpleMessageGroup` to `MessageGroup` ?


Cool!


When opponent set a pendulum monster and sent it to graveyard, pcard->type would be zero at the time called ClientField::AddCard.


galera fiz essa modificação, porque nao estava pegando o restart.


Normally yes but I may have a bug re: the low ace case. I usually figure out the tie breaker by adding a multiplier of the high card. I need some modified code on line 215 to handle that...


Mea culpa.


Thanks for pointing out the inconsistency!  You're right, it's more readable directly comparing equality.  So I changed this to use a `switch` function instead since we're comparing integers.


I think I prefer "Can only perform encoder learning on decoded connections". "The connection must be decoded in order to use encoder learning" kind of sounds like decoding is something you can do to a connection, rather than a type of connection, as in the user should go and "decode" the connection so that they can go and use encoder learning. But maybe that's just me.

Anyway, is this the last thing this PR is waiting for? We should really get it going.


Can we remove glut from all OSX ? It actually is prohibited for the AppStore as well as it is an existing "internal framework"


>SBUS_MAX_FRAME_SIZE (value 28). Is that a good constant to use

No, SBUS has nothing to do with telemetry. Either make a new constant for that, or just use 0.


This will break if we have more than one user in the YAML file, yet the filename (`user list.yml`) and the fact we iterate over each user implies that we could add more users to the file.


The call to `fill` is unnecessary (single values will apply to all series), and if you don't need the value you can also shorten:
```
    ...
    get!(d, :markershape, :ellipse)
    ...
```


I'm happy we can simplify this!


Этот и предыдущий тесты имеют очень похожую структуру. В тест-кейс наверно не очень будет запихивать массивы, поэтому можно просто выделить общую для них функцию, которая, например, примет в себя массив исходных слов и массив скучных. И сделает, что надо)


See comment above.


what's that?


This is a slight change in behavior as we now check for being an instance of `PreampChannel` instead of just `else`, right? Shouldn't matter, though.


FAIL  tests/components/scrubberBar-test.js (0.394s)
● ScrubberBar › it enters ad mode
  - Expected: '' toBe: 'hidden'
        at Spec.<anonymous> (/Users/jmendez/repos/html5-skin/tests/components/scrubberBar-test.js:144:39)


Why do we need this `break`?


ок


@mattheworiordan
> In your last commit f2e674c it's not immediately obvious how *.ably.io is trusted, can you explain?

Here I added the exception. Like I said, Apple is forcing devs to use HTTPS but this exception is important for `ClientOptions#tls = false`.


Short for ਪੂਰਵ ਦੁਪਹਿਰ. We had a discussion at Unicode CLDR last year about it, and agreed on using ਪੂ.ਦੁ for now. May change to ਸਵੇਰ in the long run.


![C'est de toute beaute](http://madamecitronnade.com/wp-content/uploads/2014/03/tumblr_msvn33211L1sgh5zho1_500.gif)


sigh wat


```
+    return "Я попал в " + b;
+  } else if (a === false) {
+    return "Я никуда не попал";
+  };
+
+  if (typeof(a) === 'number') {
```


We need to check that the post appears on the front-end. What you're doing here is a good additional check, but I can see you visiting the from-end of the blog anywhere.


ah, yes, probably - that does look a bit odd now I come to look at it again


peço desculpas pelo equivoco, não li que não poderia alterar linha.


Agree. Changed to ਸੰਭਾਲਿ਼ਆ


Agree and changed.


@jagrit1 I've had a quick look over your code - see comments on this commit.


Ah yes it does break. Is there a specific use case where using testem's default config resolution doesn't work for you?


> but revert this change for MSVS.
> What do you think?

No — you’re forgetting about the other part of the commit’s description, that `Level0` was an incorrect value. Seems to me that `s/EnableAllWarnings/Level4/` is what should be done here instead, isn’t it?

> P.S. But for now I'd settle just for restoring the use of Level4 for MSVS.

I.e. this...


Yeah, and at least `signed.VerifySignatures` is enforcing the threshold value.

This depends on what is the goal of this PR: if the goal is to specifically detect a particular kind of user error, where the user switches a server while reusing local state, worrying about the threshold is unnecessary. If the goal is, more generally, to prohibit updates where the server can detect the user/user’s client painting themselves into the corner, a threshold which makes the server-hosted timestamp keys unusable is one of such detectable user/client implementation errors.

I am perfectly fine with "we don’t care about the more general case, this is good as it is” if that is what you want.


Yes. Confirmed. I was on revision cm-12.1 on both when I compiled.
On Nov 24, 2015 11:53 PM, "Faraz Masood Khan" <notifications@github.com>
wrote:

> This change is in the repo "android_device_lge_g3-common", also check that
> you are on cm-12.1 on both repos
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mysteryjeans/android_device_lge_g3-common/commit/b5746cff7e4fedfa5f145f383f81ef9b628d111c#commitcomment-14596930>
> .
>


Heh. Yeah, I am missing that case. I clearly need to write unit tests for this exercise...


ah, okay; didn't know that; thanks!


One more instance of `invalid valid` left.


Can we please put all man page releated cleanups in a separate patch. Some of the man page cleanups have nothing to do with problem being solved. So even if we have to revert the patch, we could still keep man page related fixes.


Would it be good to have always one version of Latest_2015_Golden_JSON.root such that an update on minor changes would happen with a git pull ? Maybe simple as softlink to a certain JSON ?


Note: there is still an issue in getstatus with SC_MAXIMIZEPOWER since the source use a timer but send an infinite timer to the client.


its like a good idea to restore (and ensure this functionality is tested)


While doing this refactoring, I learned lots about line item price setting - among them, that the price can be arbitrarily set (independent from its Variant's price). I left the extra expectation in to make it more obvious that that's actually expected behaviour.


New-Fan-Object (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (1971 of 1971 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


The old code cast this value to `PreampChannel` so anything else would have failed previously, too. In any event, these are the only two possible subclasses, so no catchall case is needed.


@jay I don't know whether anyone builds for NT 4.0 - I just know the default msys build system targets this.

Some other projects define _WIN32_WINNT to be 0x500 or 0x501 in their configure.ac files for  msys - I'm still a little uncomfortable editing the autoconf files especially on platforms I don't personally build on. Obviously I have various Ubuntu and Windows VMs for the autobuilds but rely on Marc's autobuilds to test this sort of stuff / check for errors on- the following build shows the error and can be seen in others builds from Marc that have the "link" error:

http://curl.haxx.se/dev/log.cgi?id=20151121030540-9334

Whether we want to go down that route of targeting Windows 2000 / XP I really can't say - my personal view is that if curl can build for NT 4.0 then lets leave it as such and support as many platforms as possible ;-)

Please note that the fix I implemented is consistent with other areas of curl where we use VerifyVersionInfo(). We could wrap these GetVersionEx() and VerifyVersionInfo() up into our own version check function - but my main concern was fixing the builds - especially with the next release being around the corner.

I'm just sorry I missed these errors over the summer, I normally rigorously check the autobuilds, but as you know I haven't been around much and I'm just starting to get back into curl related things again now ;-)

You'll also note from the autobuilds that I've fixed the "warning" regex for GCC based builds so a lot more warnings are now being reported - unfortunately :(


after 255 seconds, the data is so stale that it is completely worthless. in ArduPilot I am ignore this value and have an internal timestamp that times out the vehicle after 10 seconds. this is because if there is a communication problem with the hardware we don't want vehicles lingering forever


You last build was on 21st  Nov and that's working fine but this change
came after that and the problem appears in my build of today. Try syncing
your repos and building today. Since your fork is dependant on CM's, I
think your build will also be impacted. But I could be wrong. I've picked
up this stuff in the last 2 weeks only.
On Nov 25, 2015 12:21 AM, "Rajeev Kalra" <rajeev@kalra.in> wrote:

> Yes. Confirmed. I was on revision cm-12.1 on both when I compiled.
> On Nov 24, 2015 11:53 PM, "Faraz Masood Khan" <notifications@github.com>
> wrote:
>
>> This change is in the repo "android_device_lge_g3-common", also check
>> that you are on cm-12.1 on both repos
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/mysteryjeans/android_device_lge_g3-common/commit/b5746cff7e4fedfa5f145f383f81ef9b628d111c#commitcomment-14596930>
>> .
>>
>


Weird - is `errors` always defined? I didn't realize that was something `Meteor.Error` did.


Kudos go to @tvdeyen for coming up with this one.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6587](https://teamcity.mesosphere.io/viewLog.html?buildId=80112&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:11:36


Well, that's a good point about the padding. But I'd still like to fail gracefully on minor versions >= 1000 in a way that doesn't change the major version. How about this: pad numbers < 100 with zeros, then round to three decimal places? Like this:

```python
round(float("%d.%03d" % (versionMajor, versionMinor)), 3)
```

and maybe include a warning when the value is rounded?


Oops :D  Thanks!


Agree. Fixed in cafc394f352ce5660d40109c3d075bb9b05b7532


s/hroups/groups/ ?


remove the empty line


Oops! Yeah, sharp eye! :)


scan_disk_partitions() is called only if both $DEVS and $VG are non-zero. So this check will always be false and we can remove it.


Don't forget the tests as well.


why only pad numbers < 100, and not < 999?