please let me know if you think my patch is a correct fix, or if I'm missing something.


Sisi, lo trovavo solo più comodo farlo qui che con gli issue.


**README - Nitpick**
Use _directory_ instead of _folder_.


That makes sense now that the instance numbers aren't being recycled.  I had contemplated enhancing the function to re-use them but obviously that's not being done now.


I'd further simplify this to:
```
return !isLocalGitRepository(source) || !hasGitBinary
```


Lua had a rationale behind its license choice should that be expressed / linked in the new licence file?


reviewed


**README - Awesome**
Good indentation and formatting!


If it's inline, just use one back-tick.


isn't this unnecessary? i see it being added on line


MaLi: fixed "Nasz Zespół" page


It is wrong type, should be BOOL


Sure


Veoma dobor iskoristen convertView!


@Feld0 Should it be `->index()` as shown?


Is there any other way to do this?  The file is generic for any F4 and only this target needs an exception in init?


( ͡° ͜ʖ ͡°)


The modifications in this data structure should be inserted as exceptions in: https://github.com/andorp/bead/blob/master/src/Bead/Persistence/SQL/MySQL.hs#L112-L123 otherwise every time when the server start will rerun its migration process.


Ovo treba prebaciti u Movie model, napraviti metodu getPosterImage() koja generise puni url za sliku.


why is this predefined? I know there's the same issue in the code above, that all these values are predefined for specific pclk2 value.


Nazivi packeg-a u Javi se pisu pocetnim malim slovo.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4163](https://teamcity.mesosphere.io/viewLog.html?buildId=70884&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:59
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


There should be space between `{{` and `$projects->count()`


No semicolons please.


Same here, please fix the space


No need for error messages here, you can simply use !!


Yeah, don't worry about it.


This patch is wrong; that's markdown synthax.


Yay :+1:x100

On Mon, Nov 9, 2015, 2:05 AM Sebastian McKenzie <notifications@github.com>
wrote:

> cc @thejameskyle <https://github.com/thejameskyle> @hzoo
> <https://github.com/hzoo> who have asked me about this before.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/babel/babel/commit/15969a09046a50ae2ae0503725b7fb00cdd7137f#commitcomment-14268849>
> .
>


Nisam siguran da li je "MovieDatabase" bas najbolji naziv za ovu klasu, mozda nesto kao BaseResponse ili MoviesResponse.


good


You cannot return a pointer in the stack of a function. The stack address cannot be trusted when the function returns. Better API will be `void(or int status) fz_lookup_metadata_wrapper(fz_context *ctx, fz_document *doc, const char *key, char *buf)` in which the `buf` is provided by the caller of this API.


Nigdje se ne koristi. Treba izbaciti.


This is not correct. Kotlin doesn't have setter-only properties. If the property already has a getter, then your code will create a duplicate getter. You should check this and not show the quickfix if the property already has a getter.


Which timer is used for HAL tick? I recall for other devices it's TIM5. Looks like PWM was updated to TIM 9 but the line 202 states TIM5_BASE which was added one commit earlier?


Normalizing line endings b0d9ff361d8db12f06a0002ae81ce85d849b7f2f


Please remove this test, it is not valid Kotlin code.


On Fedora 22:

```
error: startswith is not defined
keys | map(select(startswith("librbd-") and
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4164](https://teamcity.mesosphere.io/viewLog.html?buildId=70885&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:17:52
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Uh, oh... I fear we cannot do it like this. strjoina() is based on alloca(), which does stack allocation. You use it inside of a stack variable definition, this is likely to explode.

In CODING_STYLE we already make clear you cannot use alloca()-based stuff inside of function invocations, but it's kinda the same for stack based variable definitions.

Just fill in the the strjoina() after the initializating of the struct and all should be good.


Why create this 20151106-test.md?  "This will be used as the customized excerpt on frontpage" What does it mean?


would be so nice to offer a  JS file allowing some changes in background with corresponding changes in text color. suggest #fdfeff, or #fff color could be red or black respectively. Could be added in an options section with some rop down menues to change the css. (then possibly remembered in the background)
while we are here a simple addition to text area and split screen would permit  a second "list" under a  different class/id that uses the same code to generate the textarea. Would give two separate lists for easier organization of material. Thank you much for your efforts.


Nije potrebno.


```
$ ./run_conflict_test.sh
Apache Jackrabbit Oak 1.4-SNAPSHOT

# IndexConflictsProvokingTes       C     min     10%     50%     90%     max       N
Oak-Mongo                          2     348     393     468     594    3200     240
Cluster Size: 2
Nodes created: 12600
Conflicts: 6992

# IndexConflictsNonProvoking       C     min     10%     50%     90%     max       N
Oak-Mongo                          2     342     385     469     541     814     255
Cluster Size: 2
Nodes created: 13600
Conflicts: 0
```


@rohanryan @IIvec : sg for example has just had succesful STC and LTC runs and now goes for an optimising effort.


Ah I might confused. I can see it all as it's large change-set, so browsing commit after commit. I found that there's a revert commit for adding TIM5 base


I've forgotten to say that I'm perfectly fine with current placeholder
implementation, but I want to make sure that the following knowledge is shared :)

Rust has modules and crates. Modules map roughly to packages in Java, while
crates are unique to Rust. A crate is a reification of the library concept at
the language level.

* Crate is a tree of modules.

* Only top level module of a crate is anonymous.

* Crate **transparently** spans multiple files. There are no differences between
  an inline `mod` and a `mod` in a separate file. That is, every crate could be
   represented by a single file.

* (Crucial point) Crate is a unit of compilation. All files and `mod`s
  constituting the crate are compiled **simultaneously**, both at the
  conceptual level and, as currently implemented, in practice.

* Leading `::` in path means the anonymous root module of the current crate.

* Paths in `use` declarations have an implicit `::` at the start.

* Leading `self` and `super` in a path refers to current or parent module.

* If path does not start with `self`, `super`, `::` and it is not a `use` path,
  then it refers relatively to the current `mod`.

Most of the above is implicitly contained in the following wonderful koan from
The Reference:

> Unlike in many languages, use declarations in Rust do not declare
  linkage dependency with external crates. Rather, extern crate declarations
  declare linkage dependencies.


Never seen calling a method in EL like this... Very strange...


Preporucujem da se ovi i slicni stringovi prebace u strings.xml ili da se napravi config.xml fajl gdje bi cuvali slicne informacije.


@jorgejcabrera si tenes que hacer un target=0 en todos los constructores de todas las entidades podes ponerlo directamente en el constructor de entidadPartida que se ejecuta cada vez que creas una entidad que hereda de EntidadPartida ;) https://github.com/jorgejcabrera/Taller/blob/master/Server/Source/Modelo/EntidadPartida.cpp#L13


you need three external libraries: mail.jar, additional.jar,activation.jar


> Hi Trozet,
> after creating "heat" file from "admin' file. I am only able to see export OS_USERNAME="admin" ( which I > did modify to OS_USERNAME="heat")
> There is no export OS_TENANT_NAME="service" to modify here. Yo meant here is "adding export
> OS_TENANT_NAME="service". Is this right ?
> Thanks you so much
>
> Thanks
> Hai

yes, you need to add the line. do not forget the 'export' in front of it!


Validator call for delete missing.


1: M110 missing component name


merge spelling


Thanks. Enabled.
Also, do check this
https://github.com/neobuddy89/shamu/commit/ce6baea567ca2269242db259cebedeadeb814be1

Maybe you missed mmc and scsi.


I'd suggest merging the :after_commit specs with the :notify_indexer spec to avoid stubbing on the instance under test.

The :notify_indexer method could also be private.


RestAdapter bi trebalo implementirati upotrebom singleton paterna. Vise o tome:
https://github.com/square/retrofit/issues/867


Are you planning to implement the GET API later ? Ideally we should have a GET API for getting all the reviews of a product.


Whoops!


You-re right. Thanks


you could use a constant for the string "defaultJMAPPort" and share it with the module


`s/Closes/closes/` @lnielsen


Ovi String-ovi su vidljivi samo u u metodi refreshFeed() bilo bi dobro da se prebace u res/strings.xml


Shouldn't this be `case hm: HashMap1[A, B1]` ?


why not @PostConstruct ?


```
local buf = ffi.new("char[?]", 256)
W.mupdf_lookup_metadata(context(), self.doc, "info:Author", buf)
metadata.author = ffi.string(buf)
```
or `metadata.author =ffi.string( W.mupdf_lookup_metadata(context(), self.doc, "info:Author", buf))` if you would like to return the buf pointer in `mupdf_lookup_metadata`.


Not really, since @Id annotation binds events to item's template (L2Item) not L2ItemInstance.


Спасибо, select я как то упустил, куда понятнее с ним.


Thanks, I'll give that a try. I'll bet that's why word and character lists
are not refreshing  until I reload the whole dialog. If that problem's
fixed I just want to make sure each list contributes at least one word to
the sample for words/chars with an override list, then I think it's done.

>


Like how you've covered all the bases here with tests on create, update and destroy.


Super, korisnik zn o cemu se radi. Samo string prebaciti u strings.xml.


Maybe scope is the wrong word.  I added debug code to output what the stack variable was within the try block (right after L193) and then immediately after the try block (L198).  The logger statement in the try block was set correctly, but after the try block it was always null.  Thus I figured it was set in the try block but is not accessible outside of it.  With this change it will actually attempt a stack update, whereas before it thought it was always a create, because stack was always null.  This fixes https://issues.jenkins-ci.org/browse/JENKINS-30819  Let me know if I am missing something in why this defect is occurring and this appears to fix it.


Bonjour et merci de partager votre connaissance.

J'essaye d'apprendre par l'exemple mais je patauge un peu... Est-ce que vous auriez un exemple de formulaire de login pour m'aider ?

D'avance merci.

Alexandre


Nije dobra praksa.


see my previous comment about defaultJMAPPort


Я проверял и убирал вывод, зачем - не знаю :)  добавил.


What is the question mark for?
This looks like a statement?
But you alter the validation below...does the validator ever run before customise_xx_controller? If so, why?


Reviewed. Please merge


It's more complex than I suggested.
I was suggesting just patching the create/update methods to use your custom controller (tweaked to handle multiple records, of course).
This approach isn't necessarily wrong...in fact it may ultimately be better...but seems like more work.


smart using cheerio instead of more brittle regex stuff!

I think I almost got how this whole thing works:
-js files are parsed first so you can store events
-then you parse html:
--cheerio attaches events as strings, which call your RT methods
--then you replace head/body/template strings with the resulting markup
--assign it as a function a property of ReactTemplate
-generate react classes/components simultaneously
-react component's render method returns ReactTemplate['SomeComponent'](component, this.data)
-this.data serves as context and is the result of parsing Blaze helpers into its keys, wrapping autoruns
-then you have access to `context` in react-regex.js to have your way with!

I previously saw how must your work now relied on the react-rejex.js map (hopefully), but I wasn't sure what its input was exactly. Now that I understand the flow I should be able to write some of those regex/replaces. That said, the remaining tokens in the spacebars to do maybe you haven't gotten to for a reason?? Maybe require more advanced solutions?

Let me know what challenges you foresee for what's remaining--now that I understand it, you can likely write me quick blurbs and I can pick up a few things. I'm pretty good with regexes myself and I like how you're combining them with runtime functions (`RT`). I just need to get one under my belt so I can pick up some momentum. If you can, provide me with the easiest next assignment possible and I'll use that to get into the groove.


On could use
```
if attached {READABLE_STRING_GENERAL} a as s32 then
    create Result.make (s32.count)
    utf.utf_32_string_into_utf_8_string_8 (s32, Result)
else
    Result := a.out
end
```


all mediaqueries should go in the end of the file, as one section:
@media (max-width: 750px)  { // all rules go here }
also, consider using 1 or 2 generalized breakpoints instead of more similars (eg 600, 650, 750px)


_nameRegex can be removed, as not used anymore


/create.php?success is not redirecting properly

the project is hosted on timetravelopps.co.uk/test/wireframer

the create script now redirects to http://timetravelopps.co.uk/create.php?success


Слишком большая строка


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 Total|||||


Hi,
When a PG is congested, a pause for each of the priorities which is mapped to it, should be generated

From: Ashok Daparthi [mailto:notifications@github.com]
Sent: Friday, November 06, 2015 5:31 AM
To: itaibaz/SAI <SAI@noreply.github.com>
Cc: Itai Baz <itaib@mellanox.com>
Subject: Re: [SAI] Modify Priority_group_to_pfc_priority -> pfc_priority_to_priority_group (9dd013f)

What was the behaviour you are expecting from this map.
Is coming packet priority to PG?
When PG congested which priority to be used to generate pause?

—
Reply to this email directly or view it on GitHub<https://github.com/itaibaz/SAI/commit/9dd013f3a7d318dd88bed0c562e5585c9355e976#commitcomment-14229528>.


In general form.accepts should be done onaccept not in postp
This can be a tablename's onaccept (can access form.request_vars or current.request.post_vars) or a custom form's postprocess


I am going to change this to

name=$(ceph --admin-daemon ... perf schema | jq 'keys | .[]' | grep "^\"librbd-.*${image}\"\$")

Or may be just abandon the idea of using jq and parse with awk?


all mediaqueries should go in the end of the file, as one section:
@media (max-width: 750px)  { // all rules go here } - it's easier to look for layout changes later
also, consider using 1 or 2 generalized breakpoints instead of more similars (eg 600, 650, 750px)


minor: there is a strange mix of tabs and spaces in the indentation here.


This commit also contained functionality to the Parser to parse DateAttributeType


How about s/`','`/`", "`/ ?


@flavour Any examples in trunk related to patching the create/update methods?


Yes, it's a better title let's merge it into main.


Which counter do you mean?
+2 looks OK to me: `std::string` + `map<string, string>`.


I was looking at patching the buttons, not the methods, sorry to use imprecise language


Yes you are right.
But for (*_)STRING_8, if we could avoid going through UTF converter .. this will be faster and use less memory.

So probably it should be

if attached {READABLE_STRING_32} a as s32 then
    create Result.make (s32.count)
    utf.utf_32_string_into_utf_8_string_8 (s32, Result)
elseif attached {READABLE_STRING_8} a as s8 then
   create Result.make_from_string (s8)
else
    Result := a.out
end

Ideally we should review smarty lib ... and update design.


Yikes, you're right, that's a flaw. And it breaks the tests. Can you look at it? I've got a lot this week.


@jorlando  en ppio no todas las entidades iban a tener target. Por ejemplo tiene sentido que una casa tenga un target? Por eso todavía no seteo el target en el constructor de la clase madre, sin embargo ahora el atributo está en la clase madre y quizás después lo pase a la hija.


@serrynaimo what exactly is  `php` ?


Do you know if it was correctly rendered before I messed with internalFormat?

About the other bug, ok, I'll have to check what the game is doing to trigger this.


test


This is how the normal Add Button is added by CRUD:
https://github.com/flavour/eden/blob/master/modules/s3/s3crud.py#L1221
So replace that in postp:
output["showadd_btn"] = xxx


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4166](https://teamcity.mesosphere.io/viewLog.html?buildId=70892&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:08
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Example:
https://github.com/flavour/eden/blob/master/controllers/msg.py#L137


Hi @stuartbrowntraining Can you be more specific on what part of London are you from?


@oscarlorentzon here you should put try/catch since that opencv_contrib it's not installed. Same for SIFT

Try cv2.error.

    try:
        ...
    except cv2.error as e:
        ...

http://stackoverflow.com/questions/8873657/how-to-catch-opencv-error-in-python


Strange, that is not what happened in my testing. This is in listRepos:
`         if type(repos) == str:
             repos = [repos]`


Modifying Action Buttons:
https://github.com/flavour/eden/blob/master/controllers/msg.py#L741


This hunk can be removed.


This hunk can be removed too.


It’d be better to place in `utils` folder.


Is it safe to be creating new instances of the FirmRepository?

The reason for asking is that the FirmRepository, in turn creates an ElasticSearchClient and when called it memoizes an HTTPClient. As the system gets used would we have dangling instances (and connections) hanging around?


One can write a more efficient code:
```
parameters.search (from_param_id)
if parameters.found then
    sfrom := parameters.found_item
elseif ...
```
or

```
if attached parameters.item (from_param_id) as l_item then
    sfrom := l_item
elseif ....
```


Is that new? That was part of the previous release, or?


Please remove space before comma.


Adjust Test Pulse amplitude Z-axis range.


1: M111 unrecognized component name: docs


Lodash already have it: _.escapeRegExp.


updated it from 26 to 27 in this PR

https://github.com/rebuy-de/rb-forms-barcode/commit/c1138dc5d0f43d9792a43c9b60c622cf8037fb43

This is the first commit in this PR.


At the beginning.


jq definitely seems pretty temperamental -- let's try the grep approach for now.


`+            .removeClass()` (line 1285 of the js file)
You remove the class `.bar` as well there. That class is used to the meter layout & positioning.

Not a big issue for me, `.strength-meter div:first-child` as a substitute


I assume you've gone with the `if` / `elsif` / `else` construction to better mirror the original behaviour. However, I'm pretty sure a `case` statement would give the same behaviour, wouldn't it? Given that part of the idea of this change is to reduce the number of ways we do things, I worry a bit that we're using a mixture of the `case` and the `if/else` constructions. But perhaps that's a job for a later commit / PR.


It all depends if the STRING_8 instance contains extended ASCII or not. If it does, maybe we want the UTF-8 conversion, no?


Eliminate the space after numbering.


better in an extracted class?


Indeed current code is the "old" way to do that.
For the time being, I prefer to leave it as it is.


Очень-очень много тестов с похожей структурой. Можно написать всего одну функцию и вызывать ее с разными параметрами. Или еще такой вариант: в шарпах в тестах есть атрибут [TestCase], почитай про него, он тебе тут поможет прибраться :)


This is interesting. I ran into a nasty bug a few years back due to methods hiding in the eigen/meta class. Can't remember the details though.

On a slightly related note, should the firm_indexer be a class, rather than a module, as we're not going to be using it as a mixin given the `self` methods?


Shouldn't you add an BOOST_ASSERT(false) or something here, to make sure that failure actually fails ?


Нет-нет, такого не должно быть. Мы наверное не поняли друг друга)


Fixes #13


What about when globalSec = now?


+核心代码：
+ String url = "http://img2.imgtn.bdimg.com/it/u=4270894670,2181503254&fm=21&gp=0.jpg";
+    ImageView imageView;
+ //展示
+        ImageLoader.getInstance().displayImage(url, imageView);
+        //可以显示图片了
+//布局文件
+<ImageView
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:id="@+id/imageview"
+        />
+//设置圆形的方式自带的不能用，兼用性不高
+    // ImageLoader是单例对象
+        //显示图片的设置
+//        cacheInMemory()     启动内存缓存
+//        cacheOnDisk(true)     启用磁盘缓存
+        DisplayImageOptions displayImageOptions = new DisplayImageOptions.Builder()
+                .cacheInMemory(true)
+                .cacheOnDisk(true)
+                .displayer(new BitmapDisplayer() {
+                    @Override
+                    public void display(Bitmap bitmap, ImageAware imageAware, LoadedFrom loadedFrom) {
+                        //设置图片为圆形
+                        Bitmap bitmap1 = Bitmap.createBitmap(bitmap.getWidth(), bitmap.getHeight(), Bitmap.Config.ARGB_8888);
+                        //声明画布
+                        Canvas canvas = new Canvas(bitmap1);
+                        BitmapShader bitmapShader = new BitmapShader(bitmap, BitmapShader.TileMode.CLAMP, BitmapShader.TileMode.CLAMP);
+                        Paint paint = new Paint();
+                        paint.setShader(bitmapShader);
+                        canvas.drawCircle(bitmap.getWidth() / 2, bitmap.getHeight() / 2, bitmap.getHeight() / 2, paint);
+                        imageAware.setImageBitmap(bitmap1);
+                    }
+                })     //设置图片展示的样式
+                .build();
+  //监听的设置
+   //下载的监听
+        ImageLoader.getInstance().displayImage(url, imageView, displayImageOptions, new ImageLoadingListener() {
+            @Override
+            public void onLoadingStarted(String imageUri, View view) {
+
+            }
+
+            @Override
+            public void onLoadingFailed(String imageUri, View view, FailReason failReason) {
+
+            }
+
+            @Override
+            public void onLoadingComplete(String imageUri, View view, Bitmap loadedImage) {
+//                Toast.makeText(getApplicationContext(),"下载完成",Toast.LENGTH_LONG).show();
+                Log.i("下载完成", "完成测试");
+            }
+
+
+            @Override
+            public void onLoadingCancelled(String imageUri, View view) {
+
+            }
+        }, new ImageLoadingProgressListener() {
+            @Override
+            public void onProgressUpdate(String imageUri, View view, int current, int total) {
+                Log.i("下载", String.valueOf(current));
+            }
+        });


I generally add `(void)` for these types of things to pacify Coverity etc.


Все, что происходит в этом цикле = метод Append(char symbol)


А вот это = метод ToTree()


Also worth commenting here briefly *why* we're ignoring errors,  something like:

```
/* In some cases the existing origin ref may not actually exist; say the admin did a cleanup, or the OS expects post-install configuration like subscription-manager */
```

?


This is the only change from this commit that is actually pushed with this pr, since you revert the rest in the next commit. Having commits that don't actually do anything, just temporary work that gets reverted immediately after, makes the commit history harder to understand, not just for a reviewer but also for anyone going through changes later. Also, the pattern is for the HISTORY.md entry to be added in the same commit that made the changes that required it. Can one of you two squash the first 4 commits?

Also, like @thiago-rocha mentioned on a recent pr @blzaugg sent him, we require prs to come with tests for the behavior that was added/fixed. So can one of you two add the tests for this? Check out http://alloyui.com/contributing/.

And also, just remember that prs should first go through @thiago-rocha now, since he'll be taking over AlloyUI soon, so we're transitioning to that :)


有些瀏覽器 CSS 支援 `transition`，
但 JS 卻仍只支援 `webkitTransitionEnd`
所以 webkit 要寫在 standard 之前~


note that we can't set all solr params  in `fq` object cause properties key must be unique, while solr works with multiple same parameters name (facet.interval.set  for example).

Also, we will have to discuss on how to manage the solr indexing suffix (`_d`).


I've tested on a Pi, and with hints.codec == AV_CODEC_ID_DTS
avcodec_find_decoder(hints.codec) returns "dca" codec and avcodec_find_decoder_by_name("libdcadec") returns the "libdcadec" codec, so all seems correct.
Note: since https://github.com/xbmc/xbmc/pull/7969 it is harder to tell which codec is being used as codec overlay shows "DTS-HD MA" whether you are using "dca" or "libdcadec".

If ffmpeg is built with --disable-decoder=dca, then obviously "dca" codec is not available, and avcodec_find_decoder(AV_CODEC_ID_DTS) will return "libdcadec" codec. That is not the default behaviour of ffmpeg built with kodi.


It does kick off requests, but then [it blocks parsing until the scripts download and execute](https://developers.google.com/speed/docs/insights/BlockingJS) :smile_cat: I think if you have a fast enough connection it might *appear* to load faster because the document you see is loaded all at once and you don't notice separate loading and instantiation of sprite and JS sorter plugin that modifies the way table headers look.

I've copied the repo to a local test server, limited speed to 11Mbps (average speed in US; `sudo wondershaper eth1 11000 11000`) and ran some benchmarks. Judging by when [DOMContentLoaded event](https://developer.mozilla.org/en-US/docs/Web/Events/DOMContentLoaded), moving only scripts to the bottom of the page shaves off 0.72 seconds off DOM load and moving both scripts and the non-essential sprite CSS to the bottom shaves off 2.32 seconds, which is 43% less than the 5.37 seconds until DOM load when everything is in the head.

Based on these results, the [suggestion to do so on Google PageSpeed](https://developers.google.com/speed/pagespeed/insights/?url=http%3A%2F%2Fmodules.perl6.org%2F), and the suggestion to do so by YSlow plugin, I'm reverting this commit and moving scripts and non-essential CSS back to the bottom of the page.

### Everything in `<head>`:
![all-in-head](https://cloud.githubusercontent.com/assets/5747918/11035157/8a3aa320-86be-11e5-945f-269a0091c6de.png)

### Only scripts at the bottom of page:
![only-scripts-at-end](https://cloud.githubusercontent.com/assets/5747918/11035168/9a2fd71e-86be-11e5-891a-061bbdcffb4d.png)

### Scripts and sprite CSS at the bottom of page:
![scripts-and-sprite-at-end](https://cloud.githubusercontent.com/assets/5747918/11035177/a29d4eea-86be-11e5-865e-2c0e8a4adea4.png)


Hmm...couldn't we simplify this whole thing by again using `ostree_repo_set_ref_immediate()` ?  Then we just ignore the error from that, and there's nothing else that could really fail, so we wouldn't need this try/catch/warning?


It hides everything other than the initial items


@monkstone maybe you can make your own pom and package locally or push a fork as your own org? @mkristian do you have any thoughts on how people handle non-Maven jars?


black -> block


Accidental imports that happened. Forgot to remove them and IntelliJ doesn't do it for me


Now that this function is such a simple one-liner, we may want to remove it and callers can put the code inline.


There is no state in the FirmIndexer only behaviour. So a module is being used to save on instantiating something that doesn't need to be instantiated.

The `class << self` thing was to save having to prefix all methods with `self` as in `def self.index_firm`. I thought it looked repetitive and also thought that the meta class thing was the idiom for doing this. Is it ok (*shrug*)?


Sorry dit is fout.... startswith bestaat alleen in python :p


Relates to #209.


Are you sure you want this public?  I like using redshift, but I keep my redshift configuration in a private repository since it has my GPS coordinates.


@envermemic  `@if(lp.getFiles != null)` moze se pisati kao `@if(lp.getFiles)`


Indeed I guess you are right.

2015-11-09 14:49 GMT+01:00 Emmanuel Stapf <notifications@github.com>:

> It all depends if the STRING_8 instance contains extended ASCII or not. If
> it does, maybe we want the UTF-8 conversion, no?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EiffelSoftware/EiffelStudio/commit/becb903b283f54175290d9283507e2fb5072a89c#commitcomment-14276458>
> .
>


**Code Quality - Nitpick**
Check out the order of importing in [PEP8 style-guide](http://legacy.python.org/dev/peps/pep-0008/), we start with standard library imports first.


I'm using the xboxdrv with genuine Xbox 360 controller on Linux. I spent some days until find that this directive doesn't make sense. When put "#if 1" the controller works like a charm. The mapping:
SDLJoyButtonMap[0] = NKCODE_DPAD_UP;
SDLJoyButtonMap[1] = NKCODE_DPAD_DOWN;
SDLJoyButtonMap[2] = NKCODE_DPAD_LEFT;
SDLJoyButtonMap[3] = NKCODE_DPAD_RIGHT;
is wrong for this controller independently on the operating system.


That's github issue, I'm afraid. Archives on https://rspamd.com are all self-contained and signed with my gpg key. You can obtain the archive by running `make dist` after cmake stage. This make target runs special script called `dist.sh` that works with submodules and other stuff properly.


This will slow down the debug version builds of the sample app.


Jonney, I'm still investigating this, but I found another possible reason why compiled .exes may not show without a manifest.  From this link (http://owlnext.sourceforge.net/help/html/d7/d56/tooltip_8cpp_source.html):

"//
   20   // This function solves a problem for Unicode builds without a manifest for Common Controls
   21   // version 6. In this case, the classic non-themed version of Common Controls is used (5.x),
   22   // and this version expects the old size of the TOOLTIP structure. Consequently, naively using
   23   // the size of TOOLTIP to initialize TOOLINFO::cbSize will cause tool tips to not show.
   24   //
   25   int GetToolInfoStructSize_()
   26   {
   27     PRECONDITION(owl::TCommCtrl::IsAvailable());
   28     static size_t s = owl::TCommCtrl::Dll()->GetCtrlVersion() >= 0x60000 ?
   29       sizeof(TOOLINFO) : TTTOOLINFO_V1_SIZE;
   30     return static_cast<int>(s);
   31   }"


 your comments seem to be not coming through...i'm not sure what your'e
referring to?

On 09/11/2015 5:44 AM, paveljanik wrote:
>
> This hunk can be removed too.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ptschip/bitcoin/commit/a0bdf9a9eb7d3ba572c527696f78a814e1075c9f#commitcomment-14276369>.
>


Ahh right, I missed that part.


:+1: for simplyfing the patching wizard code by getting rid of OEM edition


107712554-FixRefrigerationCondenserWaterCooledNotRegistering (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


1: M111 unrecognized component name: docs


Legal, mas achei desnecessario foto e matricula do usuario


fixes xibosignage/xibo#631


close() нужно делать в блоке finally


Both `boost` and `std` define a character class `[[:xdigit:]]` for hexadecimal digits (TIL).


> On 09 Nov 2015, at 14:58, Peter Tschipper <notifications@github.com> wrote:
>
> your comments seem to be not coming through...i'm not sure what your'e
> referring to?

Looks like GitHub UI is a bit slow 8)


Good point @edgarriba . I will do and also add a note in the readme regarding running the pipeline with SIFT and SURF.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4168](https://teamcity.mesosphere.io/viewLog.html?buildId=70898&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:15
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


The relevant parts of The Reference are

* [Crates](https://doc.rust-lang.org/reference.html#crates-and-source-files)
* [Modules](https://doc.rust-lang.org/reference.html#modules) (use declarations are also described in this section)
* [Paths](https://doc.rust-lang.org/reference.html#paths)


@nidalBITCamp  It would be good idea to make `student.fullName()` for mentor and student models. Those would return full name and save some coding.


What's the best practice for using `with transaction.atomic():`? Does it really need to exist twice, once outside the `try:` and once inside?


If you ran it in that form it would show that message x the amount of people opped so that doesn't work one bit.


good


I appreciate that you wanted something short, but this name is very confusing given we have an `Overlay` type.


Actually in the commit history it shows aggelos created the command.


It's true that the defaults for `linkcolor`/`citecolor`/`urlcolor` of `red`/`green`/`magenta` are unpleasant. The old Pandoc settings of `magenta`/`blue`/`blue` were established before we had the options from [`dvipsnames`](https://www.sharelatex.com/learn/Using_colours_in_LaTeX) available in the template. Would it be desirable to tone this down to `Maroon`/`Blue`/`Blue`?

@hugoroy, would you actually use the option to turn on link borders, or is that only hypothetical? (I'm not aware of anyone ever having asked for it in the past, and I wanted to make sure that you weren't just leaving it in to be polite.)

The following would implement this:

```tex
\hypersetup{unicode=true,
$if(title-meta)$
            pdftitle={$title-meta$},
$endif$
$if(author-meta)$
            pdfauthor={$author-meta$},
$endif$
$if(subtitle)$
            pdfsubject={$subtitle$},
$endif$
$if(keywords)$
            pdfkeywords={$for(keywords)$$keywords$$sep$; $endfor$},
$endif$
$if(colorlinks)$
            colorlinks=true,
            linkcolor=$if(linkcolor)$$linkcolor$$else$Maroon$endif$,
            citecolor=$if(citecolor)$$citecolor$$else$Blue$endif$,
            urlcolor=$if(urlcolor)$$urlcolor$$else$Blue$endif$,
$else$
$if(linkborders)$
$else$
            pdfborder={0 0 0},
$endif$
$endif$
            breaklinks=true}
```


Anyway it should use `CABAL_SANDBOX_CONFIG`, so `cd` is not necessary. I'll check today later, when get home :)


Let's just add a comment like:

```
/* For inline parts we are relying on per-commit GPG, so this isn't strictly necessary for security.
 *  See https://github.com/GNOME/ostree/pull/139
 */
```

?


The other mapping was contributed by someone who find it fixed his issues on Linux, IIRC. No idea what may be different...


@romainl Ou, I apologize then :) And thanks for the review again.


@nidalBITCamp  This "smells" like bug. You are using fixed value to get roles. Why have more roles if you are going to use only one? Better solution would be to make method `users.get(i).getPrimaryRole()` or even better `users.get(i).checkRole(UserConstants.NAME_MENTOR)` where logic can be contained inside the model.

Using "Magic Numbers" (in this case this would be 0) is not a best way to go. Since I cannot understand what you want to do with the code, so if you have to use it contain it inside the model.


ok. facepalm on my side. I somehow overlooked the log. and it seems. this option was not enabled. at all (it reverts back to false?!). usability ftw. I am very sorry for the noise.


@anusha-ragunathan We want to use the filesystem of where loop file is residing. So if host has xfs as rootfs, then inside the container we want to use xfs and if host has ext4, then inside the container use ext4.

File backing loop device resides on host filesystem. Loop device will be used as data/metadata device for thin pool and we will create a thin device and format that with a file system. And by default it will be same as where /var/lib/docker/devmapper is.

So using df sounds right to me. Can you elaborate more with an example so that I can understand what's the issue.


This should be `@user`?


直接以表單模型table來呈現


OK


`OverlayConn`?


@nidalBITCamp  Magic number as seen before.


Oh, I see. With the addition of the inner `atomic` block, we can remove this explicit rollback, I get it.

Are there any concerns about `continue`-ing back to the containing for loop with an active transaction, or does django handle that properly on its own?


Aside from my question above about continue inside an atomic block, there's one other small change that can be made. I'll get it up on a branch to be cherry picked.


:ok:


I'll try to find a better solution when I test at least another controller
model.

Daniel Moura
@danielgvmoura <http://twitter.com/danielgvmoura>
oxesoft@gmail.com
http://www.oxesoft.com

2015-11-09 12:07 GMT-02:00 Henrik Rydgård <notifications@github.com>:

> The other mapping was contributed by someone who find it fixed his issues
> on Linux, IIRC. No idea what may be different...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hrydgard/ppsspp/commit/746a88c23d6fcf1bb6a6f75f5433aa59b67a602b#commitcomment-14276817>
> .
>


Thanks for the suggestions. They started out as one thing but I found it easier to think about as two separate things.

The `notify_indexer` method has a clearly defined responsibility; it tells the firm indexer to look at this firm.

The `after_commit` must call the notify method on these 3 very specific events.

Splitting like this made it easier to write the tests and easier for me to think about.

`notify_indexer` is public because it doesn't have dangerous side-effects, it doesn't leave the firm in an inconsistent state, it needs to be tested and it may be useful being able to call this explicitly when working on the dev console.


yay!


Sorry, one more idea.  On Windows 10, balloon-style tooltips don't flicker if the following combination of flags is used for .uFlags of the TOOLINFO struct:

TTF_SUBCLASS Or TTF_IDISHWND Or TTF_CENTERTIP Or TTF_TRANSPARENT

I don't know if this works on other versions of Windows too, but maybe an idea...?


thank you Peter


turtleli won't like this line ;)


Temporary control, just for debug


Changed to location


I don't know for sure if is good to we raise as IrreversibleMigration.


Subsections/ES - Expressions and Statements.md

C++ 구현체에서 -> C++ 컴파일러에서


@rradczewski I think the check error messages are not very informative.

Error message when validating error messages with check:
´´´
 Exception while invoking method 'questionInsertAddVote' Error: Match error: Failed Match.Where validation
I20151109-15:05:55.533(1)?     at checkSubtree (packages/check/match.js:223:1)
I20151109-15:05:55.533(1)?     at check (packages/check/match.js:32:1)
I20151109-15:05:55.533(1)?     at [object Object].Meteor.methods.questionInsertAddVote (app/lib/collections/questions.js:12:5)
I20151109-15:05:55.533(1)?     at maybeAuditArgumentChecks (packages/ddp/livedata_server.js:1617:1)
I20151109-15:05:55.533(1)?     at packages/ddp/livedata_server.js:648:1
I20151109-15:05:55.533(1)?     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
I20151109-15:05:55.533(1)?     at packages/ddp/livedata_server.js:647:1
I20151109-15:05:55.533(1)?     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
I20151109-15:05:55.533(1)?     at [object Object]._.extend.protocol_handlers.method (packages/ddp/livedata_server.js:646:1)
I20151109-15:05:55.533(1)?     at packages/ddp/livedata_server.js:546:1
I20151109-15:05:55.534(1)? Sanitized and reported to the client as: Match failed [400]
´´´

It does not tell me that it fails because of an invalid question text. Or am I doing it wrong?

```javascript
Questions = new Mongo.Collection('questions');

Meteor.methods({
  /** Insert a new question into the questions collection */
  questionInsertAddVote: function(questionAttributes){

    check(questionAttributes, {
      questionText:String,
      lectureCode: String
    });

    check(questionAttributes.questionText, validQuestionText);

    if(questionAttributes.questionText.trim().length === 0){
      throw new Meteor.Error('Not a valid question text');
      return;
    }

    /** Check if a lecture to this lecture code exists */
    lecture = Lectures.findOne({lectureCode: questionAttributes.lectureCode});
    if(lecture == undefined) {
      throw new Meteor.Error('Not a valid lecture code');
      return;
    }

    var question = _.extend(questionAttributes, {
      author: Meteor.userId(),
      submitted: new Date()
    });

    questionId = Questions.insert(question);

    var vote = {
      questionId: questionId,
      lectureCode: questionAttributes.lectureCode
    };

    Meteor.call('voteInsert', vote, function(error, result){
      /** Display error */
      if(error) {
        return alert(error.reason);
      }
    });
  }
});

var validQuestionText = Match.Where(function(x) {
  check(x, String);
  console.log("Check");
  console.log(x.trim().length !== 0);
  return x.trim().length !== 0;
});
```


I am checking each data on this tables on production.


@nidalBITCamp I would make it so that you can say `.checkHomeworkStatus(Homework.NEW)`. I understand that values 0, 1, 2 represent status of ongoing homework but I do not know what they mean. If you would make constants as seen above, I would know what they mean e.g.
``
final val NEW = 0
final val STARTED = 1
final val FINISHED = 2
``


You could add an `if` condition at the beginning of the `grabPaddle` function. If the `controls` are not set to "mouse" then you can simply `return` from the function and don't do anything.


What "preregistration" do you refer to when saying "discuss preregistration as option, at least for some research designs"?


https://github.com/edx/edx-platform/commit/3805b87a57df5e2c0cce8454c85c8b0b50bbc323

Reference: https://docs.djangoproject.com/en/1.6/ref/models/instances/, under "Validating Objects"


Similarly here, you could add an `if` condition on `controls == "keyboard"` in the function that handle the keyboard input.


More swift way would be:

`settingDidChange?(control.on)`


@nidalBITCamp This is bad commit, you moved from constants to "magic numbers"


true

you missed a similar one in `getDuplicates` :)


it's actually 'NPE' but I got the idea.

fixing it


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 139](http://teamcity.corp.dirigodev.com/viewLog.html?buildId=1675&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 6 Build time: 00:01:26


107712554-FixRefrigerationCondenserWaterCooledNotRegistering (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@nidalBITCamp This logic should be moved to `User` model since it is too complex to be used in view


Doing `player.y = mousePosition.y` is a good start. I'd make sure this works first.

If you want to have max speed for the paddle then you should solve it more like the computer paddle. The mouse position would only determine if the paddle should go up or down and then the speed will be applied automatically through `render`, just like for the computer paddle.


TeamCity Jarvis Framework :: CI-GitFlow [Build 54](http://build.prxm.it:8811/viewLog.html?buildId=4584&buildTypeId=CqrsFramework_CiGitFlow) is now running


@nidalBITCamp You can just write `if (receiver)`


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 140](http://teamcity.corp.dirigodev.com/viewLog.html?buildId=1682&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 6 Build time: 00:01:13


비트 조작을 할때는 -> 비트를 조작할 때는


The replacement for this class cannot be in extensions api package. It should belong to mule core.


I was going to suggest

` settingDidChange: { configureActiveCrashReporter($0) }`

But then I realised that your way was actually much clearer and that clear code is more preferable to concise code.


syncing du, will take time till tomorrow morning :v after making du then tesla os will be synced


96..98 is not safe
+                                final Activity parent = getParent();
+                                if (parent != null && isVisible()) {
+                                    ((MainActivity) getParent()).toggleTabletMenu();
The first line should directly assign to a MainActivity, then it becomes null if it's not of compatible type, otherwise you might still get a NullPtr in the third line.
Also, in the third line, the call to getParent() is redundant since it (hopefully) returns the same result as from the first line, so simply reuse that.
That results in:
+                                final MainActivity parent = (MainActivity) getParent();
+                                if (parent != null && isVisible()) {
+                                    parent.toggleTabletMenu();


I had missed these ones


@nidalBITCamp Cool trick in programing is to put constant first, so you avoid `NullPointerExeception` example

```scala
if ("Done".equals(status))
```

But even better would be to have constant `Status.DONE` so you would write

```scala
if Status.DONE.equals(status)
```


Disable the effect


note: this is a new precondition which was previously implemented in a confusing way as a postcondition. as a precondition, the exclusion is factored-out to the beginning and is also more clear what the behavior means.  be aware of how and when this is added in case you get any surprises about question behavior, otherwise everything related to this is functionally equivalent as before this commit.


Structures now work in site blueprint as well.


will this value appear somewhere? If so, we should change the U to a lowercase u.


it should actually be part of mule-api but it doesnt' exist yet. I'll add a todo


spelling of yield


i mean this one: 'TaskNotQuestion'


buy -> by


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.1.5](http://build.prxm.it:8811/viewLog.html?buildId=4584&buildTypeId=CqrsFramework_CiGitFlow) outcome was **SUCCESS**
Summary: Tests passed: 129 Build time: 00:04:01


TeamCity Jarvis Framework :: CI-GitFlow [Build 55](http://build.prxm.it:8811/viewLog.html?buildId=4585&buildTypeId=CqrsFramework_CiGitFlow) is now running


My bad, did not solve the problem...


well spotted
this commit got almost empty after rebasing in master where @henryju had already made the change to protobuf


This is not what I intended. Now when you set `dontWrapGApps` you will not have the `gappsWrapperArgs` filled. The intention was to not wrap the program, but still populate the arguments for manual usage.


Mars is a great planet


你也是太不小心了……密码都被写进来了……或许你可以让这个Bot去读取一个配置文件，从中得到密码。


I think the properties of this class should be private instead of protected (I believe you're using self:: and not static:: here on purpose). I believe we've been misusing protected a lot in Windmill. Private has the major advantage that it'll allow you to update your classes later without any BC risks. A private method can't be overwritten or called from any subclass unlike a protected method. So any change to a protected method or property has the risk of breaking BC, where an update to a private method or property is not a BC break as long as the exposed public and protected methods and properties keep on working as they did.


Neither have i, the original seems correct


indentation (space missing)


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.2.0-unstable.5+5](http://build.prxm.it:8811/viewLog.html?buildId=4585&buildTypeId=CqrsFramework_CiGitFlow) outcome was **FAILURE**
Summary: Tests passed: 129; exit code 1 Build time: 00:03:05


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.771](http://teamcity.monogame.net/viewLog.html?buildId=11279&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


change favorite color from blue to green #9


This doesn't seem quite right.
It looks like it would form a loop since the clause we dispatch to sets `id_btree_state` to [nil](https://github.com/cloudant/couchdb-couch-mrview/blob/4e4383543060e267b1ab8c7118c726a6ed7c1530/src/couch_mrview_util.erl#L201).


**Functionality - Nitpick**
1. Other than hard-coding the file location, you could load it from a configuration file.
2. Use absolute path instead of relative, i.e.
```python
dir_path = os.path.dirname(os.path.abspath(__file__))
file_path = os.path.join(dir_path, "data")
open(file_path + 'allocated.txt', 'r+')
```


Good point about the FirmIndexer.

`class << self` should work fine and there is a habit/idiom for doing this in the community. There isn't usually a reason to poke methods into the meta class (from a functionality/behaviour point of view) unless folks are up to wacky stuff.


Ok ! So you just have to rename it in order to tell that you've added a ut


println


@smsm1 I've moved the task into a migration in this commit
https://github.com/cyclestreets/cyclescape/commit/7a596c9bb391d1fc0d8900aeaaa3e62e4f4c9195#diff-1b64c34ef42cb338fff4dd17d737d503R3
so now after the dups are removed the uniqueness is added stopping this situation in future.


This configuration element is false by default, so no new behaviour.
But i thought it was important to show this, as we will really depend on it in.


never mind the record name is different


console log


log


that's what I did


why did u add status if u don't use it?


idem


You should not depend directly on the Connectivity bundle. Depending on the core bundle should be enoguh. You can get the class via the interfaces classes. Additionally the new BackendManager(); will create a second backend manager, which is probably not a good idea. See the caos bundle how to get references. (blueprint.xml and the CompositionManager class)


I see. Should I do the change?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4171](https://teamcity.mesosphere.io/viewLog.html?buildId=70925&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:09
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


**Code Quality - Nitpick**
PEP8 recommends use_of_underscores for function names, e.g. `pre_populate()`


Why do you list supported types?


@turtleli will love this :p


Test the saveIfNotDuplicate for the model


how did i type `ass`


indentation


A few thoughts re: this patch...

1. Note that the Work interface already has the following method which is not symmetric with setUsername(). Is this intended?:

 /**
     * Gets the user on behalf of which this work is done.
     * <p>
     * This is informative only.
     *
     * @return the user id, or {@code null}
*/
    String getUserId();

2. Would it make sense to always capture the userId used to create/schedule the Work, regardless of whether that userId is used for the CoreSession? I could envision a Work Result, for example, being interested in such information. If you agree, then would it make sense for the Work class itself to determine if its CoreSession should be Unrestricted or based on the userId? One way this could be accomplished is for AbstractWork to expose overloaded method: initSession(String repositoryName, String username) and maybe even initSystemSession(String repositoryName). Then would it make sense for initSession(String repositoryName) to invoke initSession(repositoryName, null) to be consistent with CoreInstance.openCoreSession(String repositoryName)?


Что-то поломалось после этих изменений. Идея "We can replace group name with placeholder and then restore it. It will be something like this" видимо была реализована не до конца.

Если раньше в pattern класса, наследующего UrlRule, заходила строка `'#^(?P<route>[a-z0-9_\-]+(/[a-z0-9_\-]+)*)$#u'`, то сейчас -  `'#^(?P<a02c42079>[a-z0-9_\-]+(/[a-z0-9_\-]+)*)$#u'`, соответственно, preg_match при парсинге не работает как положено.

Или я не до конца понял идею и изменения непрозрачны для кода?


If possible, you should use the routes.controller etc


small typo!


done


@Becirr Commits should be in english


@Becirr This "smells" like bug. You are using fixed value to get roles. Why have more roles if you are going to use only one? Better solution would be to make method users.get(i).getPrimaryRole() or even better users.get(i).checkRole(UserConstants.NAME_MENTOR) where logic can be contained inside the model.

Using "Magic Numbers" (in this case this would be 0) is not a best way to go. Since I cannot understand what you want to do with the code, so if you have to use it contain it inside the model.


Thank you for the fix... sorry about breaking it...  Here are some comments to help explain this...

The original behaviour to use only the 2nd line if it was an API message.  We should probably keep the notice to the UI reasonably clean as follows:

```javascript
            // messages of length 1 are local exceptions (use the 1st line)
            // longer messages are remote API exceptions (use the 2nd line)
            let splitError = error.message.split( '\n' );
            let message = splitError[splitError.length === 1 ? 0 : 1];
```


argh


I saw you use optionals, wouldn't be better to return an optional?. Perhaps we can define a general rule about using Optionals always that null is a possible return value (except with collections)


fixed :)


@Becirr I would suggest making user method, `getFullName()` which would return first and last name. Since obviously you guys are using this a lot.


Based on the discussion we have please create a Mule jira issue and put it here so we can discuss if we will call this element connection-provider or just provider.


Well you changed the old behavior :)


I just want to know why it remove the TORecoveryModule ?


& is not needed in conjunction with the child operator. Only for class chaining.

With our new component approach to styles we should try to let _heading.scss define all internal styles. Internal styles should not add any paddings+margins as they should be set by the surrounding context. Thus padding-bottom, margin-bottom props are just fine here. font-size should probably be in determined by _heading.scss


Oops. Thanks !


@Becirr This is not good, what is value is `http://www.facebook.com/`? Should it work for http and https?


perhaps check for the prefixed `webkitMutationObserver`? Not sure if its needed anymore


Good point. That's actually copy & paste from handling of `Environment=` on line 1164, I'll also fix that one (and other occurrences I find in this file) on a separate PR.


This description doesn't seem accurate


nice, I'm a bit of a noob when it comes to coding and I've been wanting to make a survival game for the longest time. I'm glad your doing this!! this will help me greatly!


Will fix.


Hey @ryanjhodge. We're actually using "semistandard" in all of our projects now: https://github.com/Flet/semistandard. We started going down the road of using standard style, but had a hard time wrapping our heads around the lack of semicolons. No biggie, just wanted to let you know for future work.


@rommcr да, это ожидаемое поведение. Можно пример того, что поломалось из-за нового поведения?


![screenshot from 2015-11-09 15-29-17](https://cloud.githubusercontent.com/assets/1663668/11036156/0a53b370-86f7-11e5-93f5-11bd5bf16086.png)


Looks like the `HTTPClient` is memoized on the `ElasticSearchClient` instance, which is memoized on the `FirmRepository` instance. So because the `FirmRepository` goes out of scope as soon as the statement has finished executing, the whole chain of objects will be garbage collected.

I had a quick look at the HTTPClient docs, I couldn't see anything warning about having to explicitly close connections, so I'm assuming the connection is naturally closed at the end of each HTTP request or at least when the object is garbage collected.


did we actually have a test for this behavior?


Agreed.


@rommcr если можно, целиком UrlRule на Gist


I think 1.8.0 is working for me but I'm getting that issue in 1.9.0


Why do you have to ignore this test if MULE-8952 is a new feature?


Sure. I asked mainly to find if you haven't written it in the meantime.


Pushed again. Let me know if I got it right this time. :-)


If I were the author of the addon perhaps I would want to extract setting the height of the element to a single function that can be invoked from here and from the `init` method.

Something like `setWrapperHeight`


@yehudasa I couldn't find any good examples of a struct in rgw which used the json encoder which didn't also require json decode support, which clearly doesn't make sense if all you are doing is generating a json message.
I also noticed this is 'preferable' rather than mandatory, and have to completely disagree with the statement "it's going to be impossible" and would point out it's extremely simple and clear what the code is doing.  This looks like an important piece of functionality is being held up due to a 'preference'?


But it works! :)


Not sure that build time of the sample app matters. Anyway, it gives chances to detect ProGuard rules problems during working with the sample app.


> I'm on the fence as to whether or not the SaveManager class should ever deal with rate limiting. Its job is to nicely queue http requests, and perhaps nothing more.

This is a fair question- truth be told, I went back and forth on that question myself. What swayed me was that any class responsible for sending multiple requests would (realistically) have to worry about the amount of server traffic it was generating. Since this is a reusable class, it's worth asking whether throttling should be part of the reusable default package. (without requiring separate boilerplate)

And if the class handled throttling, then of course the knockout would look a bit different, just by virtue of where throttling was defined. ;) Something to consider, anyway.

Aside from that: if the call signature has a lot of options, would you consider moving them into a single argument (a dictionary)? This would avoid calls of the form `save(arg, null, null, null, true)`, in favor of `save(url, method, opts)`


But this is a **subclass** of an existing class. I agree with you on the way it should have been in Windmill, but that's for a major release...


lgtm


Original discussion with @evverx is here:
https://github.com/systemd/systemd/pull/1805#discussion-diff-44215272

Essentially this is to support a line that's broken with a trailing backslash, not ignoring all the settings that come before it, but simply the backslash itself:
https://github.com/systemd/systemd/pull/1811/files#diff-fc579f2e11e7598d1ad67fca18a9e047R714

Do you think it's better to just return on ENOMEM as before and otherwise simply warn about the error and continue as suggested by @evverx?


This yield is done at every corner of a face. This means that it would first process all vertices, normals and texture coordinates without yielding, and then yield (usually) three times at the processing of each face. I'm wondering if this is by design or was an oversight. Wouldn't you rather yield at every line? That is, reduce the indenting of this line?


Why did you remove GroupBy?


**Code Quality - Nitpick**
This was not necessary since the properties are public, but you might want to check out _setters_ and _getters_ in python, [see quick sample here](http://stackoverflow.com/questions/2627002/whats-the-pythonic-way-to-use-getters-and-setters)


Maybe the PID should be kept separate from the tag?


$viewReference not $viewReferece


такие штуки выноси в константы


Thank you :D


Thanks for this - I noticed it myself when trying to use it over the weekend. I'll push this into our review system and get it onto trunk.


107712554-FixRefrigerationCondenserWaterCooledNotRegistering (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (888 of 888 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.01%25-green.svg)


:ok:


Yes you're right, I don't know what I was thinking there.


hope this one is fine now


Maybe ALIAS_LEVELS is a better name?


这个class 好像是分类的意思吧？
我的理解是 “分类讨论”


Ran this on a c4.8xlarge EC2 instance:
```
real   90m18.074s
user  2592m3.708s
sys   118m59.436s
```


New solution


Why is this the only method that converts `kwargs` into a Dict?


Ah, these properties are already defined in the parent and you're not introducing them in the subclass, you're only setting their values. In that case they still should be protected indeed.

Just curious, any reason you're redeclaring them and not setting their values to your defaults in the register function?


'feature' точно лишнее.

все модули PEF::Front::* в данном случае -- части одного фреймворка. не уверен, что их надо указывать по отдельности, раз это будет в одной дистрибуции (когда-нибудь) на CPAN. основная проблема PEF::Front -- надо сделать "нормальную" документацию, у меня она скорее либо концентрированная, либо разбросанная кусочками, не нашёл пока времени на завершение.


I didn't find a test with the commit that added these lines. I wrote a test to help me test it manually and I looked very briefly if there would be a simple way to do this, but the solutions I read about were a bit more intricate and platform specific (win vs linux and even within linux solutions varied depending on things like X manager; I suspect there's a generic linux solution but I didn't find it with a quick search).


Thanks!

Doug


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.771](http://teamcity.monogame.net/viewLog.html?buildId=11279&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 552, ignored: 6 Build time: 00:19:33


Since all of these method definitions are almost exactly the same you may want to create these via metaprogramming


@icebreaker Freezing this breaks the push to rubygems unless you `dup` the value inside the `gemspec` file.


OK


Looks Good. :shipit: , merging it to master now.


@SilverFire

В web.php:
>                [
                    'pattern' => '<route:[a-z0-9_\-]+(/[a-z0-9_\-]+)*>',
                    'suffix'  => '/',
                    'route'   => 'site/content',
                    'class'   => 'components\routes\ContentRoute'
                ],

https://gist.github.com/rommcr/955ff899d12f7ae872ef - сам contentRoute.

На 52й строке preg_match вместо ожидаемого мной именованного `route` возвращает ключ с плейсхолдером - в итоге всё падает.

Я так понимаю, дальше следовало бы использовать `substitutePlaceholderNames`, но
а) это приватный метод
б) до этого нужно дойти с дебаггером. Если бы обновление движка было произведено на продакшене, а не на dev, было бы все печально.


Oh, my bad, sorry.


You're right, there was an issue on android where the CrashManager.register method was fired twice.. I've fixed this in https://github.com/cwannerstedt/cordova-plugin-hockeyapp/commit/4caaffadb881e80537bbd1596b760b847b93fb1f, and verified that it works.

I will create a PR and see if they wanna merge this


Why the test changes?


@wking `is_active` as a property was inherited from Django's `AbstractBaseUser`. It defaults to `True`.

You had a good idea with that migration, I didn't think about it.

The actual implementation will be a little bit different:  if `person.has_unusable_password()` then they should be inactive. Unusable password was either empty password or password starting with `$` (if I remember correctly), and it prevented users from logging in anyway.


'Encode' -- тоже лишнее, не нужно коре-модули или тем более прагмы указывать. по идее.


It seems the goal of this script is different. Namely it only finds the concepts that has potential mappings.
Am I wrong? (see below)


So only the name of the category is exported?


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 141](http://teamcity.corp.dirigodev.com/viewLog.html?buildId=1688&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 6 Build time: 00:01:11


This is a comment on this pull request.


Je suis d'accord - mieux vaut une description du champ sans consigne à l'utilisateur.


fin de ligne :p
j'vais être chiant avec ça mais une ligne de code doit se finir par un caractère de fin de ligne
http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206


Because other methods (in the subclass) might also rely on the value. Declaration of default values should be done in a property declaration in my opinion.


please, use a variable here, define it in _settings.scss and do not forget about dark theme.


ID added looks good.


This variable is not used. It is also set on line 129.


Thanks, saved me the debugging later today :)
(I also missed the switched parameters...)


Is there a reason to traverse it manually? Following should do the same (assuming AllDbCopies is a list of tuples with size 2).
```
slice_dbcopy(Names, AllDbCopies) ->
    lists:filter(fun({K, _V}) -> lists:member(K, Names) end, AllDbCopies).
```


I just tried it one more time, and upgrading vinyl-fs fixes https://github.com/gruntjs/grunt-contrib-imagemin/issues/325.


:ok:


Hi! I translated the file en_US into Russian, and create ru_RU file, but it doesn't display the translation in the correct coding. what i have to do, to make the Russian text was displayed?


Nice :trollface:


htf


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4170](https://teamcity.mesosphere.io/viewLog.html?buildId=70904&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:34


because I'm a nice guy and want to allow people to give people a good sense of what the class does with a quick read


1: M111 unrecognized component name: docs


Noto Sans Oriya
When the Oriya vowel sign I (U+0B3F) combines with the Oriya consonants KHA (U+ 0B16), THA (U+ 0B25) and DHA (U+ 0B27) it changes to the form for the preceding TA (U+0B24 + U+0B4D + consonant). This is a screen shot of all the consonants with the vowel sign I and comparing it to a font that renders these combinations correctly:
![sample 1](https://cloud.githubusercontent.com/assets/14258071/11036639/b43d4186-86f1-11e5-8b64-458c62c48276.jpg)

This is a screen shot of what the preceding TA looks like (it only takes this shape with KA (U+ 0B15), PA (U+ 0B2A) and SA (U+ 0B38)) , to compare the same looking shape:
![sample 2](https://cloud.githubusercontent.com/assets/14258071/11036644/b9efbb7c-86f1-11e5-977b-af87c1718c2d.jpg)


签名不对吗？ 如何判断签名是否正确？


This should be @Transactional(readOnly=true), and specific operations (like save) should be annotated as @Transactional


Test


この前後のコードは本家のditterのほうと照らしあわせながら確認してほしい。

`</button>` ってどこの<button>を閉じてるのか分からない。
`<?php endif; ?>` これも

インデントを合わそう。


mak可以直接刷新看有没有被封，零售的要一一验证，这部分直接用了pidkey的数据库
http://www.solidfiles.com/d/11d9502b78/


I don't use borders, I use coloured links and occasionnally hidelinks.
I'm fine with the current proposal and, if I ever use the borders, I
would probably not use the default borders (I would reduce the
thickness of the border and put

    \usepackage[hyperfootnotes=false]{hyperref}

(it doesn't seem to work inside \hypersetup{})

…to disable the border around footnotes.

But all of this can be put inside personalised templates rather than
in the general pandoc template.

--
Hugo Roy – Free Software Foundation Europe https://fsfe.org/about/roy

Please use cryptography for email: see https://emailselfdefense.fsf.org/en/
Merci d’utiliser la cryptographie pour l’email : voir https://emailselfdefense.fsf.org/fr/


Maybe make a new type defined dictionary instead?


Pushed d10b910 after brief re-testing.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4172](https://teamcity.mesosphere.io/viewLog.html?buildId=70933&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:06
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


这个是根据我本地曾验证成功的数据。或许有之后被封的，但应该不多，我试了几个没发现。


emrexResponse.xsd -> schema.xsd


What are these files? (Swarm.js and vector3dbuffer.js)  Is something in the code using them?  Or are these just local test files of yours?

Things in the .gitignore are, well, ignored by git.  :)  Usually .gitignore is for artifacts of the code we don't need to / want to version (such as build output, config files w/ passwords or keys, 3rd-party libraries, etc).


*Context*: implementing this PR in a forked version of Slick to enable lazy loading in combination with srcset.
*Question*: this code sets the src attribute first and then the srcset attribute. I'm wondering if this means that the fallback (src) gets triggered/loaded before srcset has a chance to make the browser decide.

Setting the srcset attribute *before* the src attribute might be a better way.


@Becirr You should use full named variables, such as `user, courseUser, etc ...` this is bad practice with simplified variables


Try to keep 0.4 changes separate from other changes.


I realized I could just get rid of it and use good old `String.prototype.replace()`.


@Becirr Values such as these should be moved to constants, if you need further explanation you can contact me.


1: M110 missing component name


Unused import.


Did this break the travis build on master?


src/spd/spd/static/icons/png/favicon.png does not look very spd-ish


@Becirr Good practice is to put constant name first `UserConstants.TEACHER.equals(role.getId)`


Thank you for adding this configuration file. However, I thought you will add description of configuration options to this file.  There can be three configuration options now -> URL, SSHPublicKey and SSHPrivateKey.


Can we use 'search nationally' (or similar) rather than referring to a 'main site' which will be confusing for the vast majority of people that have signed up for a particular group's area.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4173](https://teamcity.mesosphere.io/viewLog.html?buildId=70936&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:03
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4174](https://teamcity.mesosphere.io/viewLog.html?buildId=70937&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:08
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


mmm


Heh, yeah, I thought it would be a good idea to switch the parameters, to avoid breaking stuff for anyone who doesn't want to implement this


OSError at /admin/mpclorchestration/composer/add/
Couldn't retrieve schema document - status code 500
b'{"error":{"msg":"java.lang.StackOverflowError","trace":"java.lang.RuntimeException:
java.lang.StackOverflowError\\n\\tat org.apache.solr.servlet.SolrDispatchFilter.sendError(SolrDispatchFilter.java:784)\\n\\tat org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:436)\\n\\tat org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:205)\\n\\tat org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)\\n\\tat
...

I'm using jetty, when I tried it with tomcat I couldn't even load Solr Admin, and also got the same error anyway.


This is just a style question, directed maybe more at @jakebrown58: we use snake_case for some things and camelCase for others.  Is there any rhyme or reason to that?


@tagliala

> sooner or later you need to use overrides

I disagree. If "sooner" means a breaking change in a minor version, then "later" is the answer.


Please create report_Uploader.conf file (the event configuration file), add examples of the configuration options to the configuration file and create a manual page for the configuration file.


I noticed that in combat, the damage floaty text sometimes shows up in multiple locations with different numbers. ..maybe due to new floaty text code? Will need to dig deeper at some point


how about using `atom.packages.getLoadedPackage('rest-client').path/collections.json` so we keep it local to the installation


107712554-FixRefrigerationCondenserWaterCooledNotRegistering (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1426 of 1426 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.47%25-green.svg)


We will keep it simple in the Work / AbstractWork for now:
- always open a System CoreSession
- rename String getUserId() to String getOriginatingUsername() (to be consistent with UnrestrictedSessionRunner) and use it, if not null, when opening the System CoreSession
- if the Work needs to open a specific CoreSession (such as a non-unrestricted session for the given user), it will be the responsibility of the implementing Work (by overriding initSession() etc).


See, e.g., http://blog.oup.com/2014/09/pro-con-research-preregistration/
__
Dr. Frederick Solt
Assistant Professor of Political Science
University of Iowa
http://myweb.uiowa.edu/fsolt
frederick-solt@uiowa.edu

> On Nov 9, 2015, at 8:13 AM, Yue Hu <notifications@github.com> wrote:
>
> What "preregistration" do you refer to when saying "discuss preregistration as option, at least for some research designs"?
>
> —
> Reply to this email directly or view it on GitHub.
>


See src/plugins/report_Bugzilla.conf for more details.


是的，Xcode 没有正确对动态库进行签名。判断某个库是否签名，可以用一下命令：

```sh
codesign --display --verbose=4 LIBRARY_BINARY_FILE
```

如果没有正确签名，会输出相应的提示。我们之前的动态库都没有签名。除了用 Xcode 签名以外，我们也可以手动更改某个应用或库的签名，我回头会加到 UniversalFramework 的 RunScript 里面或者发布脚本中，让这个步骤自动化。


Yes, I was thinking how to do this actually, that's the best option I think.


Did this constant's name change?  If so, it's not in this commit.  Typo, maybe?


Absolutely.

(Did you already change it for iOS before? I can't read obj-c...)


Any update, @eepp ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4175](https://teamcity.mesosphere.io/viewLog.html?buildId=70942&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests passed: 1, ignored: 175; exit code 1 (new) Build time: 00:10:17


%{group} doesn't seem to be being interpolated. When doing a group search in an area subdomain the title in the HTML is:

"Search Results for %{group} - Cyclescape"


excellent. nice job :)


なんであげんの？


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 103](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=445&buildTypeId=Xbim_XbimExchange_XbimExchange) is now running


@rommcr спасибо за информацию!

Интерфейс метода `parseRequest()` не изменился, но вы получили проблему так как вы полностью переопределили метод, вместо обращения к `parent::parseRequest()`.

Тут немного спорный вопрос, так как изменение действительно может привести к поломке BC, так как меняется значение публичного свойства `$pattern`.

Чтобы "расколдовать" preg_match от `$pattern`, нужно вызывать `substitutePlaceholderNames()`. Предлагаю сделать его `protected`, а само изменение внести в CHANGES.md как возможную поломку BC при некоторых обстоятельствах.

@samdark, @klimov-paul что посоветуете?


Luquitas probamos la migracion de pasajes con diego e iban 25 minutos y no terminaba...


Could you please follow the latest version of the specification?
We intend to drop the legacy cruft sooner or later, and reintroducing the old stuff doesn't help with that goal...

Spec: http://www.freedesktop.org/software/appstream/docs/chap-Metadata.html
Quickstart Guide: http://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps


TeamCity Xbim :: Xbim Exchange :: XbimExchange [Build 103](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=445&buildTypeId=Xbim_XbimExchange_XbimExchange) outcome was **SUCCESS**
Summary: Running Build time: 00:00:44


这也是为什么如果用 CocoaPods 集成动态库，会出现无法在真机上调试的问题。因为这些 framework 在拷贝到手机上时，没有 Code Sign On Copy 这个步骤，而恰好又没有签名，所以不允许调试。


@Chandru18 - I was able to make the fork of this repo public.  Please use com.imagitas.cordova.plugins.adbmobile in phonegap build.


@oxesoft I didn't actually author the `#else` mapping, I just copied it from here to preserve how it was before: https://github.com/hrydgard/native/pull/174/files


hey brother, i just noticed you made this commit a few minutes ago while I was looking at your old code lol! I realized the same problems you just realized. I've been thinking hard about this myself. There's a few issues with what you have here and more that must be done. Here's what I've come up with:

- ISSUE: your current solution means all template "instances" share the same `this._subscriptionHandles`, `this._trackers`, etc. Now imagine you have 2+ instances of the same template rendered, they *share* these props!! (nice upgrade on your last version where `this.subscribe/autorun` was not available within created/rendered callbacks!)

- TASK: you can't do `Template.instance().foo = new ReactiveVar`. In other words, you can't refer to Blaze "state." What I think we should do is have 1 ReactiveDict `Template.instance().state = new ReactiveDict` which is transpiled to `this.state`. More specifically, if we transpile `Template.instance().foo = new ReactiveVar('val')` to `this.setState(_.extend({}, {foo: 'val'}, this.getState());`. So we transpile reactivevars to keys in the state object. If you use ReactiveDict, it also is transpiled to a key on the state object. Getters in React become: `this.state.foo` as it normally would be. However, before the transpilation code must be made you need to provide to the callbacks the create context to attach this code. You currently providing the `Template[name]` singleton, but as above it needs to represent the instance. So what this means in a callback is we have: `this.foo = new ReactiveVar('bar')`, right. In callbacks we dont transpile `Template.instance()`, we transpile `this`. Later after we accomplish this, we can make `Template.instance()` work in callbacks, helpers and events. To do this, you need to start by modifying the sideburns (well, "react-templates") events.js file: https://github.com/timbrandin/react-templates/blob/master/plugin/events.js . That file transpiles .js files. It currently is only for events, but basically we must add features to parse the expressions I just mentioned via more regexes/replaces. Then in `componentWillMount` we change `func.apply(Template[name]);` to simply `func.apply(this)`;. The context of course will be the react component instance, and the callback will have transpilations I just mentioned, so it will all match up.

 - NEXT TASK: you change `static autorun()` to be just `autorun`()`. That method no longer needs to be static. It's on the prototype of all react components now, and can be accessed in the callbacks using `this`, which is now fixed 100% ;).

I was just about to do these things, but you're farther a long than me. I'll find something else to do. If you can nail these things, all we have remaining in the current to do list is a few more spacebars transpilations + setting the appropriate context for helpers. There is likely more things after that, but at least we have reached milestone 1.


Texture is now flipped (see https://github.com/phoboslab/Ejecta/commit/26d3880172f799d8b1e92ab6f7d11c8eaee33b12 ).

There's also a new attribute `preserveDrawingBuffer`, which may help with your screenshots.
```javascript
var gl = canvas.getContext('webgl', {preserveDrawingBuffer: true});
```
(see https://github.com/phoboslab/Ejecta/commit/9641a015a178458ff331141c379f66a190511aab - this also implements antialias for WebGL)


indent of this block by intention?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4179](https://teamcity.mesosphere.io/viewLog.html?buildId=70950&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:03


Fix tag name: http://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-update_contact


Should the binds always be read/only.  I don't think we would want to allow containers to be able to write during docker build.

Are there any other flags we would to support?


Yep, see next commit :) https://github.com/cyclestreets/cyclescape/commit/faf1fb2c8956528a6131aed168460875e61ff34b


TeamCity ReOpenLDAP :: next [Build 120](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1091&buildTypeId=ReOpenLDAP_Next&guest=1) is now running


Is there a reason why you removed this?
```
13:02:53 [dotwaffle@engelbert:~] % peeringdb depcheck
  Could not find any downloads that satisfy the requirement django-peeringdb
No distributions at all found for django-peeringdb
Storing debug log for failure in /home/dotwaffle/.pip/pip.log
Traceback (most recent call last):
  File "/usr/local/bin/peeringdb", line 9, in <module>
    load_entry_point('peeringdb==0.4.2', 'console_scripts', 'peeringdb')()
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 700, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 680, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 1027, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 873, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python2.7/dist-packages/click/core.py", line 508, in invoke
    return callback(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/peeringdb/cli.py", line 99, in depcheck
    install_deps(get_deps(engine))
  File "/usr/local/lib/python2.7/dist-packages/peeringdb/cli.py", line 24, in install_deps
    raise RuntimeError("failed to install %s" % (pkg,))
RuntimeError: failed to install django_peeringdb
```
This is from a fresh install with `pip install peeringdb` so I'm imagining something is missing.


Thanks for the hint... ;-) Failure to read your instructions more carefully did cost me a couple of hours last week.


lgtm


**README - Nitpick**
This should be _How to Run_ instead, and also add something on _How to Run Tests_.


Your commit comments were excellent, @brb1031.  But I would also recommend sticking them here, as a description of the ranking system.


You could also just depend on "valac (>= 0.28)" to get this automatically built with the latest default Vala version.


@shalabhc @kirbyfan64 nailed one reproducible "bad callback" now, hopefully this was it :)

(This is not in master yet though, I aim to merge this branch soon).


reviewed


constructor innecesario. Quitalo.


@finscn
thanks .... it is okay


Instead of _Usage_, this could be called _How it Works_.


you're correct, making them read-only by default is better so the build won't be able to corrupt the host

This implementation will support what Docker is currently supporting. I think I can narrow down the list of supported options for bind mounts, or better remove it and just bind mount read-only.
Are the SELinux opts needed here?


conceptual implementation of user stream integration #2


Good point. Is there a good way to amend this? (Aside from painstakingly reconstructing history manually and doing a force push?)


Modulo the couple minor things above, I'm cool with this. :+1:


emrexResponse.xsd -> schema.xsd


Right, I will take care of that too.  Thanks!


@oxesoft the first commit that introduced this mapping is here if that's what you're looking for: https://github.com/hrydgard/native/commit/ed1f13a33fdb5a210d35ac57a4cfc59b0a67a1a4


I think this could probably be removed, the driver I based this on was using this check...  But I forgot to remove, in the end it looks like the check_fb can be removed


is there a reason this needs to be placed in *two* files?
(*could the menu and other common page components be reused by both standard and error pages...*?)


P.S.: @rommcr если честно, вы немного нетрадиционно пользуетесь UrlRule.

```php
self::$content = Content::find()->indexBy('alias')->all();

...

$content = Content::findOne(['path' => $matches['route']]);
```

При создании объекта в память загружается вся таблица контента, а потом еще и при каждой попытке обработать запрос, дергается SQL. Это выглядит крайне расточительно.


了解 :+1:


You could consider linking against libappstream[1] to generate the XML and pretty-print the result.
But for this simple case, keeping Autovala light on dependencies is fine too, I think :-)

[1]: https://github.com/ximion/appstream


Mongo associations assessment github link
https://github.com/CareyWillette/mongo-associations-assessment2. I wasn't
able to finish the assessment for a couple of reasons. 1. I need more
practice with promises (I sent a slack to Brooks that I was interested in
reviewing promises) and 2. I want to make sure I am finishing the Angular
work, and not getting behind in class.

On Sat, Nov 7, 2015 at 5:32 PM, Jeff Dean <notifications@github.com> wrote:

> Yup. Just let me know when it's up so I can review.
>
> On Sat, Nov 7, 2015 at 5:22 PM CareyWillette <notifications@github.com>
> wrote:
>
> > Will do. Can I push tomorrow?
> >
> > On Saturday, November 7, 2015, Jeff Dean <notifications@github.com>
> wrote:
> >
> > > Can you push your latest code?
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/CareyWillette/mongo-associations-assessment2/commit/8bb50fafc5d6ed73d789a921f1690387c5e7c842#commitcomment-14259307
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/CareyWillette/mongo-associations-assessment2/commit/8bb50fafc5d6ed73d789a921f1690387c5e7c842#commitcomment-14260689
> >
> > .
>
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CareyWillette/mongo-associations-assessment2/commit/8bb50fafc5d6ed73d789a921f1690387c5e7c842#commitcomment-14260714>
> .
>


hi matt
i think we should update lmk as it is enabled now. i'm not able to push all my commits i picked to cm review....
maybe you can:
at first: https://github.com/CyanogenMod/android_kernel_htc_msm8974/commit/3c8982e576f3cb1a3a952b2c5134d02701d4928f
and than: https://github.com/CyanogenMod/android_kernel_htc_msm8974/commits/cm-13.0 all commits from Nov 4, 2015 but before


Yes we probably add them, since the volumes might not be readable within the container.


tarar


Something to reduce strain on dimensions being created/loaded, yeah.


`layout/default.html` might be a good option if this is going to be in all of your views for now.


@chrisvest as you suggested, we had another look at locking in this class. Now all the methods that modify file content are declared synchronized, instead of synchronizing on `fileAsBuffer`. We think that is equivalent for the existing code paths because `fileAsBuffer` used to be final, therefore had same lifecycle as its owning `EphemeralFileData`. We've demonstrated the need for this synchronization with some race tests in EphemeralFileSystemAbstractionCrashTest.


I'll go with basically disallowing `:rw` and use `ro` by default leaving `z|Z` unmodified


Of course, | create table !

That'll teach me to play the wise guy. :)

Cheers!


Thanks for pointing that out. Those are the coordinates of Cologne in Germany. That I do live there is noted on my Github account as well. So yes, I guess that's okay. But thanks anyway, good to ask. :)


Do you think change in qcom.usb.rc is necessary ?


Why restore?


Mes excuses @AlexEven ;)


this makes the example in the readme not working

```python
example_list = glob.glob(os.path.join(mdb.AUDIO_DIR, 'ClaraBerry_*'))
```

is there a better way to access a single track now?


Can you make this "Foreman / oVirt Meetup, London ..." since I'm sharing it with oVirt?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4178](https://teamcity.mesosphere.io/viewLog.html?buildId=70947&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:00
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Sorry this was discussed IRL and was the way to go i forgot to update this.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4177](https://teamcity.mesosphere.io/viewLog.html?buildId=70946&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:13
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Also two upcoming talks by lzap:

[1] https://plus.google.com/+Luk%C3%A1%C5%A1Zapletal/posts/DEH4ZFJdLgN
[2] https://plus.google.com/+Luk%C3%A1%C5%A1Zapletal/posts/fHbGSfgpopS


What's the error you get when you try to load the Solr Admin?

> On Nov 9, 2015, at 3:01 PM, Alistair Russell <notifications@github.com> wrote:
>
> OSError at /admin/mpclorchestration/composer/add/
> Couldn't retrieve schema document - status code 500
> b'{"error":{"msg":"java.lang.StackOverflowError","trace":"java.lang.RuntimeException:
> java.lang.StackOverflowError\n\tat org.apache.solr.servlet.SolrDispatchFilter.sendError(SolrDispatchFilter.java:784)\n\tat org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:436)\n\tat org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:205)\n\tat org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)\n\tat
> ...
>
> I'm using jetty, when I tried it with tomcat I couldn't even load Solr Admin, and also got the same error anyway.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/Alistair-Russell/mpclOrch/commit/24bceee35c21ac9c686a4b73b6f0f0aee6b8764b#commitcomment-14278022>.
>


I think the $id_prop definition disappeared with this? See also https://github.com/tdt/core/pull/344


is this comment needed?  if so, perhaps it should read "Comment the next line to disable native code proxies in Spark MLLib" if the line is going to be uncommented by default


trailing whitespace ;)


i think this comment can probably be removed


Added video to the screensavers menu to call "Play Video" script in Window.cpp


ditto


Nice.


Is this good?


@SilverFire нормальный план.


:+1: @cowtowncoder


Ok, here is an example, where infjackknife fails (it fails very often when I use the Rosenbrock testfunction). However, the same error occurs also with other testfunctions, but only in 3-5 out of 100 re-runs with different seed.

```r
library(mlrMBO)
library(smoof)

d = 2

learner = makeLearner(id = "rf-infjackknife", "regr.randomForest", predict.type = "se",
  ntree = 10, keep.inbag = T,  nodesize = 1L, se.method = "infjackknife")

fun = makeRosenbrockFunction(d)
ps = smoof::getParamSet(fun)

# ### GENERAL (init, iters, y.trafo)
ctrl = makeMBOControl(
  init.design.points = d*4,
  iters = 20
)

### INFILL (crit, opt, interleave)
ctrl = setMBOControlInfill(ctrl,
  crit = "ei",
  opt = "focussearch",
  opt.focussearch.points = 500L,
  opt.focussearch.maxit = 1L,
  opt.restarts = 1L,
  # FIXME: do we want to vary?
  interleave.random.points = FALSE
)
des = generateDesign(d*4, par.set = ps)

set.seed(1)
mbo.res = mbo(fun = fun, design = des, par.set = ps, learner = learner, control = ctrl)
```

The error:

```
Computing y column(s) for design. Not provided.
[mbo] 0: x=3.85,-2.62 : y = 3.03e+04 : 0.0 secs
[mbo] 0: x=-3.14,1.35 : y = 7.26e+03 : 0.0 secs
[mbo] 0: x=-2.41,-1.22 : y = 4.97e+03 : 0.0 secs
[mbo] 0: x=0.208,5.09 : y = 2.55e+03 : 0.0 secs
[mbo] 0: x=9.88,9.76 : y = 7.71e+05 : 0.0 secs
[mbo] 0: x=4.77,-4.36 : y = 7.37e+04 : 0.0 secs
[mbo] 0: x=1.85,3.4 : y = 0.722 : 0.0 secs
[mbo] 0: x=6.49,7.37 : y = 1.2e+05 : 0.0 secs
Warning in predict.WrappedModel(model, newdata = points) :
  Could not predict with learner rf-infjackknife: Error in approx(x = calib.x, y = calib.y, xout = vars) :
  need at least two non-NA values to interpolate

Error in if (local.y < global.y) { :
  missing value where TRUE/FALSE needed
```


Additional-report-variables-ZoneHVACIdealLoadsAirSystem (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I'll spend a little time later coming up with a better solution, then.


Please replace with 	https://engine.elixir-czech.org/authentication/idp/metadata


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4180](https://teamcity.mesosphere.io/viewLog.html?buildId=70951&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 199 Build time: 00:15:59
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


@bosilca @hjelmn I just noticed this addition of passing to the proc struct because of v1.10.x pr open-mpi/ompi-release#748.  Was this ever discussed?

I also notice that the padding added in v1.10 is 32 bytes, not 16, as it is here on master.

@igor-ivanov Why the difference between the two?


do the quotation marks serve any purpose in this comment block?


:tada:


나도 코멘트 해줘잉 ㅋㅋㅋㅋㅋ


@SilverFire
> При создании объекта в память загружается вся таблица контента, а потом еще и при каждой попытке обработать запрос, дергается SQL. Это выглядит крайне расточительно.

Загружается в память - для createUrl, который используется при формировании меню и вызывается **многократно**, при чем формируется на основании других параметров, чем индексированный массив. Расточительней (как мне кажется) было бы дергать десяток раз базу с однотипными запросами.


Thanks @yanglei99 . That was the initial idea but I'm very uncertain about the cases. Is the following

   ```javascript
      if (field.isInstanceOf[JsNumber])  satisfiesAll(field.as[JsNumber].value.longValue(), filters)
          else if (field.isInstanceOf[JsNumber])  satisfiesAll(field.as[JsNumber].value.intValue(), filters)
```

actually possible? Can a JsNumber assume either long or int value? I'm not enough of a Scala expert to judge.


We need NaNs or it is treated as a single segment (not too many, or performance wise can be heavy).


What about this:

```
\usepackage[$if(linkborders)$hyperfootnotes=false$endif$]{hyperref}
\PassOptionsToPackage{usenames,dvipsnames}{color} % color is loaded by hyperref
\hypersetup{unicode=true,$if(title-meta)$
            pdftitle={$title-meta$},$endif$$if(author-meta)$
            pdfauthor={$author-meta$},$endif$$if(subtitle)$
            pdfsubject={$subtitle$},$endif$$if(keywords)$
            pdfkeywords={$for(keywords)$$keywords$$sep$;$endfor$},$endif$ $if(colorlinks)$
            colorlinks=true,
            linkcolor=$if(linkcolor)$$linkcolor$$else$Maroon$endif$,
            citecolor=$if(citecolor)$$citecolor$$else$Blue$endif$,
            urlcolor=$if(urlcolor)$$urlcolor$$else$Blue$endif$,$else$
            pdfborder={0 0 $if(linkborders)$$linkborders$$else$0$endif$},$endif$
            breaklinks=true}
```


For further reference, here's what's happening here.

The `if`/`else`/`endif` controls in `Makefile.am` files are interpreted by Automake, _not_ by Make as is. Knowing this, you can only test a named Automake condition using an `if` statement in `Makefile.am`. And the way to define an Automake condition is using `AM_CONDITIONAL`.

Hence there is no way to test for an undefined `PGREP` variable in `Automake.am`, at least as far as I know, so we create an Automake condition named `HAS_PGREP` which contains this condition (`test "x$PGREP" != "xno"`).


extra comma


@jasonkarns  I noticed when I merged this commit in the committer changed to `Tester`. Does this look familiar?


Erum við vissir um þetta? Inntak isAvailable eru pixlar hafði ég gert ráð fyrir og byrjaði að converta pixlastöðunni (x,y) yfir í indexa (i,j) í fylkinu.


thanks. btw it is really unlikely to reach this if block, but who knows ;)


maybe just a separate clause (e.g., "while the symlink is found in HOME") would be easier to parse


Good point, SSHPublicKey and SSHPrivateKey is not documentated but I will do it like is done in all reporters conf files. All reporters conf files have the same structure like this one. Configurable parameters are specified in reporters man page (`Configuration file`) so I'll add `SSHPublicKey` and `SSHPrivateKey` to the reporter-upload(1).

Are you ok with that?


Hi,

Why don't you make a pull request to the main project to make everybody take advantage of your changes ?

Thanks


ah right totally missed those


@antoinedeschenes: Indentation is key to code readability. -- will fix