Heh I have set my editor according to the code style so I always save
before now and commit those so the nits don't get mixed with the actual
functional commits

On Mon, Nov 2, 2015, 2:23 AM Twinaphex <notifications@github.com> wrote:

> Any point to this?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fr500/RetroArch/commit/b1d66e86ea02e72ce36ee45a947d0f03ec87361f#commitcomment-14120335>
> .
>


It looks like bad case ))


1 перевод строки - это "\n"
2 0x0a - это просто его код
3 "имена" команд не всегда совпадают со словами, которые надо отправлять в сокет (напр. Accept и accepted)


:cry:


Hi i tried to implement your Login master in github
When i am trying to login facebook it says that gollowing error
screenshot attached .
![2015_11_02_12 54 19](https://cloud.githubusercontent.com/assets/14123143/10876328/8f5c8ef0-80f0-11e5-8b11-616bca7d07c0.png)


test


Дарин Тодоров, Група 1, ф.н.:81100


Cool. Maybe we can update early this week and try it out


Навіщо просетувати таку кучеряву назву змінної? Чому не просетати так шоб було зручно користвуатися у вюві? Наприклад $view->set('sort', $get['sort']);


Можно повысить ридабилити

``` javascript
$scope.tours.forEach(function(tour) {
    if(isAddToPlaceFilter(tour, $scope.filteredPlacesIdsByTours, $scope.countryFilter)) {
      $scope.filteredPlacesIdsByTours.push(tour.place_object_id.objectId);
    }
  });
};
```
Не пиши аргументы, которыми не пользуешься. Лучше в итераторе использовать `tour`, а не `element`.

``` javascript
function isAddToPlaceFilter(tour, placesIds, countryfilterValue) {
  return (countryfilterValue === "" ||
    placesIds.indexOf(tour.place_object_id.objectId) === -1 &&
    tour.country_object_id.objectId === countryfilterValue)
};
```
Используй возможности логических `or` и `and`, чтобы метод содержал один return. Много return в функции - скорее исключение, чем правило.


Назва класу якась дивна. Я по ній неможу зрозуміти його рпизначення і відповідно прочитати код. Сам екземпляр класу теж "$add_user_contact", раз він ексезмпляр контакту чи чого там то і назвати йогоб так шо було зрозуміло шо він контакт.


Line exceeds maximum allowed length


Whoops commit naam verkeerd, er is hier een audioplayer toegevoegd aan het project


> If `*i` is an xvalue, there is no possible return type for `operator->` for `i->m` to be semantically identical to `(*i).m`.

Was thinking about exactly this while editing `move_iterator`; this is definitely the kind of breaking change I can get behind. Would it be reasonable to bring back [move.iter.op.ref] with a title like "(Removed) `move_iterator::operator->`" and an explanatory note?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3199](https://teamcity.mesosphere.io/viewLog.html?buildId=66709&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 193 Build time: 00:04:39


must implement OnChangeTripStateListener


This contains both the atm and two by four decoder


З назвами класів якас плутаниця вже. Ти вже їх стільки раз міняв шо вже ніхто не розбереться. Придумайте один раз як воно має бути, просто і чітко і слідуй тій домовленості з назвами. Бо це For_model так ніби шоб запрацювало і не мішало. Не розрахову на "заканало", має бути гарно.


Yes, that should be it. I'll try and update the example soon. You can keep track of the `expires_in` token by using `getTokenExpires` method at the same place you keep track of the access and expires tokens and set it with them as well. The client will refresh the tokens itself when the expires time is reached.


https://github.com/Poweruser/PowerServer/blob/master/src/main/java/de/poweruser/powerserver/main/gui/TextAreaOutputStream.java

Cool copying and pasting man


1: M111 unrecognized component name: install


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3200](https://teamcity.mesosphere.io/viewLog.html?buildId=66710&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:30


Why just omit negative branch altogether?
```fsharp
if isUsed then ...
```


@mrkschan It's best to judge on the output. Does it give you the expected output? I think @monicasarbu is the best person to have a look at this.


Same as before.


timestampsのnull: false　は消してあげましょう。


likeとcommentの件数カウントはどのカラムに保存する予定ですか？


...oops.


Is "Chevron" correct english?


この処理だと、top#indexのルーティングは残ったままになるので、まだ消してなければ消してあげてくだs台。


http://codeinthehole.com/writing/a-useful-template-for-commit-messages/

(oui, je suis chiant et je m'entête :stuck_out_tongue: )


Oops, forgot return. Fixed in 0d28e66894af2db6f56a12d60895a9e0a0a07042


I think so.
Take a look at font awesome icons, and search for chevron: http://fontawesome.io/icons/


I was not sure, but it's good to know!


burda output icin kullanacagin dosyayi mi acmaya calistin? input dosyasini yeniden write modunda aciyorsun yoksa.


et je [te bashe ailleurs](https://github.com/daida/TestTek/commit/cb6ff5749aad77eacb80c4a34e45e22a61716f40). @daida m'a dit qu'il était totalement d'accord :laughing:


せっかくstrong_paramsを設定しているので、
アクション内の記述はより簡潔にしてあげてください。

Prototype.create(prototype_params) の記述だけで保存がなされる方が綺麗です。


kaigyo


改行


Vrh :P


strtok kullanarak satirlara bolmussun, guzel. "token" satirin tamami yani. onun uzerinde bir daha strtok kullanarak parcalarina bolemez misin?


Hem yazabilecegim hem de okuyabilecegim sekilde acmaya calisiyorum. Fakat
sadece okuma islemini gerceklestirdim input dosyasini. Output dosyasiyla
simdilik bir islemim yok

On Monday, November 2, 2015, Özgür Akgün <notifications@github.com> wrote:

> burda output icin kullanacagin dosyayi mi acmaya calistin? input dosyasini
> yeniden write modunda aciyorsun yoksa.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/salihcany/ProjeDeneme/commit/b51d60836622f671026512eee2fc3c0cb5508959#commitcomment-14120641>
> .
>


Two intentional errors (%f and %d) and one unintentional error (a missing 's' at the end of the function name).


Hey @mralex,

I'm looking at duplicating similar functionality to your commit here and wanting to confirm I'm reading it correctly. Are you separating multiple slides in one file by having a line starting with "###" and an optional title? It looks like, otherwise, it uses the file's title and appends a number for each section separated by lines starting with "###".

Does that description match your understanding of how the code should work?
Thanks.


This tries to avoid avocado infinity hangs if early_status is not received in 10s (currently we modify stdout/logging, load the test, set is as the current test and put the early_status in the queue). When something fails we log the details and put early_status with traceback into the queue. Anyway when something really weird happens, it hangs for infinity even when job/test-timeout is set.


Of course, you could just change the README to AsciiDoc ;)


このコミットを行った意図がよくわかってないのですが、一時的な変更の場合、別にコミットしてみてもらう必要はないかと思います。
コミットしてPRを出す...というのは機能を完成に近づけていく作業なので、
一時的な変更なのであればわざわざコミットする必要はありません。


o zaman direk write modunda acarsan ayni zamanda okuyabilirsin de: https://en.wikibooks.org/wiki/C_Programming/C_Reference/stdio.h/fopen

ama ayni dosyaya yazman gerekmiyor sanirim, baska bi output dosyasina yazman gerekiyor. ama emin degilim, odevden bir daha bi bak.


suggest use error_code instead of dsn_error_t. size is the same, but it is easier for logging by calling error_code::to_string()


@chrmod we should try to avoid committing white space trimming which can cause merge conflicts later


I kinda feel like these files should have proper newline file endings. Mostly to avoid problems with editing these config files with editors that expect them. For the source files I'm okay with not having them since it's only us touching those. But for the configs I really think we should have them.


I remember... in panel we are also using Qt 5.4 newly added feature(s)... we probably should put the Qt version check into liblxqt CMakeLists.txt as it is used by all components...


Do we really need to have different titles for the modal? Is it really worth?


form_forを導入してアクションを指定する形はこれではないはず。。
この形は恐らくformタグの名残だと思うので、form_for用に修正してください。


What is the purpose of these lines down here?


加えて、form_forは引数に置くインスタンスが所属するモデルから自動でアクションを制定してくれます。

今回の場合はコントローラー側で新規のインスタンスを作ってform_forに渡せば自動でcreateアクションに飛んでくれるので、わざわざアクションを明記する必要はありません。


Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number
Call toll free *866-769-8127* turbotax support phone number ,turbotax support number, turbotax intuit support phone number, turbotax tech support phone number ,turbotax customer support number, turbotax intuit support phone number


difficult to judge who is responsible of the memory management of lockctx. Suggest the following way: lock(const std::string& lock_id, const std::string& my_id, const std::function<void (error_code err, std::string&& owner_id)>& cb);


改行


variadic vs. variaditic.


だいぶ綺麗な書き方になってきたと思います！
癖付けていきましょー！


for the three callbacks, u may use the same callback type <error_code, owner_id> to simplify the code. In addition, a query_lock(std::string& lock_id, cb) api can also be present.


Considering both Censor and StripColor are extra modules? Should we mention that those modules need to be loaded for this example to function?


Why didnt you use flag & BF_SHORT here? @aleos89


rmagickを入れた意図って画像編集ですかね？
簡単なバリデーションの設定とかだとcarrierwaveの方で出来ますが、それ以外の処理を実装する予定ですか？


We have bumped the max_dgram_qlen sysctl to 512 in Debian for a while [1] to make journald to syslog forwarding more robust and avoid losing messages (the infamous
systemd-journal[182]: Forwarding to syslog missed XXX messages.)

Doing that via a sysctl drop-in config was not sufficient in our case, since syslog.socket is typically run very early during boot, usually quite a bit before systemd-journald. So we ended up setting net.unix.max_dgram_qlen via a separate service file [2]

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=762700
[2] https://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=5ff84d8673bd2971985a3f14b8f34e2873ea8350


いいですね！　n+1！


per(8)の処理は今回モデル側に書いてあげましょう。
確か使用するのは、paginates_perメソッドだったかと思います。


@ComradePetr Да, больше похоже на правду.


> Opers are individual logins for your opers.

This is an odd sentence. May I suggest "Opers are individual logins for your server and/or network operators"?


わざわざ式展開にしなくても、= でいけます。


前コメントでここ削除しましょうとしてましたが、してたので問題ないです！


I have made the new connections and updated the firmware but now garbage screen and some behaviour with text LCD. Display works if i move the wires around but no encoder up/down, press button only. Is this a noise problem? Please explain how you fixed it?

I have simplified the picture
![radds fullgraphic](https://cloud.githubusercontent.com/assets/15606942/10876826/652b941a-8194-11e5-972d-c8945e830c4a.jpg)


Ну то все-таки зробити одинакові краї для всіх кнопок?


Thanks for the fix :)


改行


Please fix your manifest. There are many projects that don't have any 6.0 branch etc.


I'm not sure, to be honest. That's why I sent another PR instead of just merging. To the best of my knowledge, you cannot close & reopen a file without unlocking it, can you? Another option would be, as you say, just exit and forget about it. How likely is it for ftruncate() to fail?


Hi Dan, yes, I guess I could :) Though it was simpler this way around, and
I'd look at other Markdown contents we may have as well when doing such
change. Very happy with Asciidoc in our reference documentation btw.


Hi @carlosgarciac, please create a bugzilla and also a CHANGES entry for this one. Other customers might encounter this too.


addresses


oh...


> Code MUST use **4 spaces** for indenting, not tabs.
> http://www.php-fig.org/psr/psr-2/


多分、「拡張子の設定をコメントアウトをはずす」が正解じゃないですか？
そして僕が実装した時carriewwaveのアップローダー全然みてなかったんで勉強になりました！　笑


前コメントに同じくアクション内の記述はできるだけシンプルに。


The main reason why I didn't go for void when adding a callback is the same reason as why the async and sync version have the exact same interface. It means it does not break any existing code when using another feature, ex the callback.

You would always use the Future for getting the value, and you can add a callback when you want to attach (encapsulated) logic to when it occurs. One does not exclude the other.

I would even prefer it to allow multiple callbacks, already added the aggregate callback for that purpose so that callbacks can be functionally seperated.

When you have a usecase where you create an object and it needs to dispatch a message when it's created, you use a DispatchToRabbitMqCallback, when you just need to map it in a factory to return it to the client, the future is what you need. You would more or less get code like this

Future<Whatever> result = publisher.publish(command, DispachToRabbitMq, WriteToLog);
return factory.toWhateverDto(result.get());


Should we throw in a reference to said spec here?


It was to avoid the boilerplate of becoming a future, but indeed, super() call would be a lot better and then throwing whatever it set in super.onFailure(), it was mostly to preserve behaviour


へーーーーーーーーー　知らんかった。
予約語ってやつですね。


Un peu long et répétitif, non? Cecidevrait faire la même chose:

```php
$tournament = Tournament::create($input);
```

La documentation sur le sujet: http://laravel.com/docs/5.1/eloquent#mass-assignment


In corner cases this will be slower.  Here's a reasonably extreme synthetic test:
```
$ mkdir collider
$ cd collider
$ for i in {1..100000}; do truncate -s 10m "file$i"; dd if=/dev/urandom bs=1 count=`expr 1 + "$i" / 1000` >> "file$i" 2> /dev/null; done
$ cd ..
```
This generates 100,000 files in 100 groups of 1000 same-size files, which differ in the last few bytes.  This will require rmlint to do 100,000 search/inserts into 100 different GSLists with the length of each list growing from 0 to 1000.

Timings and mem usage:
9c4d942 (ghashtable):
* rmlint -g collider
    3930.55user 1393.84system 16:30.29elapsed 537%CPU (0avgtext+0avgdata 103120maxresident)k
* rmlint -g -pp collider
    31450.38user 1579.24system 1:40:19elapsed 548%CPU (0avgtext+0avgdata 983160maxresident)k
    *^^^ this is super-slow, suggesting a bug somewhere in https://github.com/SeeSpotRun/rmlint/blob/9c4d94232bd7b7b5d8da8f8e499eaf9bb1539196/lib/checksum.c#L701-L731  and also in the current https://github.com/sahib/rmlint/tree/master*
* rmlint -g /mnt/ssd/usr /mnd/hdd/usr # (a more real-world test):
    115.70user 69.26system 2:25.59elapsed 127%CPU (0avgtext+0avgdata 395188maxresident)k

f72c73d:
* rmlint -g collider:
    4056.67user 1399.40system 19:04.41elapsed 476%CPU (0avgtext+0avgdata 109052maxresident)k
* rmlint -g -pp collider:
    3286.65user 1625.24system 19:04.57elapsed 429%CPU (0avgtext+0avgdata 1023388maxresident)k
* rmlint -g /mnt/ssd/usr /mnd/hdd/usr  # (a more real-world test):
    125.98user 69.26system 2:27.04elapsed 132%CPU (0avgtext+0avgdata 373496maxresident)k

The memory usage actually goes up for the synthetic test but I think that's because the GSList searches all happen at about the same time and are in parallel with ongoing hashing and outputting.  In the real world case the memory saving (on a sample of 1) is ~5%.

Conclusion: Speed impact is significant in extreme cases but is acceptable.


> If the config loader is complaining about this line and you didn't load any modules, maybe just don't include this file.

This sounds kinda vague to me.


Ah, nice catch.


why do we need it? As I know OpenJDK should works well


How do I verify the index is set correctly on ES? I can't find any UI on kibana tell me about that.


Dommage d'avoir ôté cette fonctionnalité. En pratique, c'est fort utile.


Aha, you reverted previous commit and added new line in the end.
accepted


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 27](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=394&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 27](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=394&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:11


how about a.b.js?
a.b.js -> a.b, .js -> 'a-' + hash + 'b' + '.js'

```js
if (path.extname(file.path) === '.map') {
    // this is better
} else {
    file.path = revPath(file.path, file.revHash);
}
```


6.0.1 doesn't supports  iOS 7


> Provides a channel mode (+C)

> Provides the +f channel mode

Minor nitpick, but the way mode implementation is worded is inconsistent.


冗長です。
・あまりhidden使いすぎるのはよろしくない。
・画像投稿箇所は計３箇所(画像自体はmainとsubの二種類に分けられる)

なので、ここは画像投稿時に送られるパラメーターを2種類にしてあげましょう。

その上で、paramsがmainならばstatus:mainで保存、subならばstatus:subで保存... といった処理をしてあげれるようにコントローラー&モデル側で実装しましょう。

ここ、むずかしいですよ！がんばって！


Instead of looping through all the groups, perhaps this might be better?

`user.groups.pluck(:name).join(";")`


改行


it this a typo?


Done! https://github.com/Pylons/pyramid/pull/2070 Thanks for confirming.


Hi @fritsch , Yes the remove of malloc is one of my goal, Leaks are preprogrammed with them and I think if more add-ons are available is it not handled from everyone.

@Memphiz, ups :), thanks a lot.


a GoodCamera is i  want to


This commit stopped the build server last night, same for [master branch](https://github.com/LibreCAD/LibreCAD/commit/d1aaf36f57c853334741c7d3f5d508766e975995).
First error message is:
```
In file included from lib\engine\rs_variabledict.h:33:0,
                 from lib\engine\rs_variabledict.cpp:29:
lib\engine\rs_variable.h:45:25: error: field 's' has incomplete type 'QString'
                 QString s;
                         ^
lib\engine\rs_variable.h: In member function 'QString RS_Variable::getString()':
lib\engine\rs_variable.h:90:29: error: return type 'class QString' is incomplete
         QString getString() {
```
That means QString is unknown.

I reckon that not all sources were built on your system because of nested includes. Can you try to rebuild all to see if you get same errors.


I was not aware +W was a command. :P


In my case my firewall already has rules in the input chain:
-A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT
-A INPUT -p icmp -j ACCEPT
-A INPUT -i lo -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 22 -j ACCEPT
-A INPUT -p tcp -m state --state NEW -m tcp --dport 21 -j ACCEPT
If we append the DROP rule for the coova tun interface it will end up after these and it will never be enforced for ports 21 and 22 even though I don't want to expose those ports on the tun interface.


I see that Application,groovy was removed and then added again. So it was just changed, and we should keep history tracking


a good camera is i want to
i hope the code is clear, easy


it is wrong to call put_power here. the old code will call check link status and will return IRQ_HANDLED, but the current code calls the same code but can never return IRQ_HANDLED. so please remove it.


I don't think that this is a good idea to track autors in source code. Github itself do it better.


Should we rename this module and de SA* ones? No other optional modules have the *Command suffix.


redirect_to root　とかで良いのでは？
あと、「保存ができない」というケースも考えられるので、if文でリダイレクトする条件を分けるべきです。


Favorite color: green :+1


I think we can DRY up the above lines of code by extracting duplicated code into private methods? :smile:


:ok: :1234:


Ilias
The gamma used are :
* low : g=1.15 slope=2
*middle : g=1.30 slope=2
* high : g=1.45 slope=3
You must noted this gamma only effective on luminance retinex...at the end of retinex there is inverse gamma.
There is a bug in free...(very old RT bug!). I'll solve in a new change/branch  "gammadifferential"

Yes you can reduced "magenta" with gamma < 1, and/or also change settings (Curve Transmission map).


It looks for me better to keep static import.


this file was renamed but it marked as created


Should these check the doc type in case the form isn't wrapped correctly?


Just on XFormInstance, not the other ones


please modify it to return true or false. so that true will mean we have succesfully handled the short pulse and false means we failed to handle the short pulse. Any failure here should automatically trigger full detect.


This is nice utility. I think that the initialization will look exactly the same in all generators. Can we somehow refactor it to a common file?


前出したviewから送る画像保存用のparamsを変えることで、必然的にコントローラー側の変更も出てくるかと思います。
理想は、

def create
１行目：prototypeの保存
２行目：imageの保存
３行目：リダイレクト
end

です。
この３行でアクション定義を終わらせましょう。終わらせれます。
(もちろん別途メソッドの定義をする必要はあります)

結構な難所ですがめげずにがんばりましょう！


This should still happen above `unfinished_submission_stub.save()` so that if an exception is raised the `unfinished_submission_stub` doesn't get marked as saved.


What's the reason behind that?


nit: please remove this empty line


this one was wrong test


this setup secured in matching tests


ty, i have players complaining about this


@pgiraud there seems to be a lot of confusion on these modal dialogs .. can you please be more precise or make a PR to fix it?
We don't understand how you would want this to be done


Might be good to keep this around in the couch version?


it was deprecated? huh. Could you give me some link to read about?


Yeah, nice color! It' my favorite too! :+1:


ok, accepted


UI effect


Yes, I figured that. Still the main problem here is described in GH #141


I skimmed through everything quickly and left my initial response to some things. Might read through it a bit more thorough later.


Not sure why you decided to make these static methods.


the encoder use 48, 50, 52, no impact due to noise as far I can see
I think you inverted pin numbering for ext 1 ext 2 :
look at http://reprap.org/mediawiki/images/5/51/RRD_FULL_GRAPHIC_SMART_CONTROLER_SCHEMATIC.pdf
vcc and gnd are 10 and 9 not 1 and 2 so you may have mess up your connections

Also do not to use long cable but short ones - I have experienced garbage with long connection and none with short one


Just continuing my though - I think the only difference between this codegenerator and other potential ones are the "setsPackage" that we are passing here - everything else will be exactly the same, right?
So it would be great if we could refactor this code to some common utility function (thanks to it we will also have exactly the same flags in all generators, which is very desirable).


实打实的


Ce projet là n'est plus maintenu et a été déprécié avec Laravel 5.0. Pour ceux qui veulent s'en servir, il est conseillé d'utiliser `laravelcollective/html` à la place.

* http://laravel.com/docs/master/upgrade#upgrade-5.0
* http://laravelcollective.com/docs/master/html


OrderDeliveryTime model was using Model inheritance. This caused that every OrderDeliveryTime instance had corresponding DeliveryTime instance. When you visited "Delivery Times" in management panel then you were provided with a huge number of DeliveryTimes most of them being OrderDeliveryTime ones which was not desired.


To be honest, I would really prefer to separate all of the remaining code to a separate file (or even package?)


this merge contain all previous changes, or add something new? I see that README was changed


Please can you use isXXXX or canXXXX for boolean variables instead of *set* or *localRepository*


Thx!


Can you use  hack/boilerplate/boilerplate.go/txt file instead of copying it explicitly here?


this work done.

On Mon, Nov 2, 2015 at 2:14 AM ed-xj <notifications@github.com> wrote:

> Looks very good in general. There are a few things to clean up
>
>    - ajax calls made from ALL views(like robot,dashboard,confg. etc..)
>    should go through *window.BaseView.ajaxCall*.
>    - So have to make all views other than input views extend from
>    *window.BaseView*
>    - *window.BaseView.ajaxCall* should take additional parameters *cgi*
>    and *callback* so the cgi program on the server is provided by the
>    caller. Also the caller will provide the callback function which ajax
>    success/error will call to return data and/or error msgs.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ed-xj/qm/commit/d01b3fbd677e2702c81968497b381c33dc66cf72#commitcomment-14115160>
> .
>


Use the GET template API: https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-templates.html#getting


I searched over all the code for `isinf`. I didn't search for `vector`, `stoi`, `atoi`, or any of the rest of the members of std.


How come these got removed?


Это может быть неочевидно (хотя если бы я был ОЧЕНЬ ЗЛОЙ учитель, то послал бы тебя в доках искать соглашения об именовании ;), но в Руби принято такое соглашение об именовании сущностей:
* snake_case — переменные
* CamelCase (без подчёркиваний, каждое слово с большой буквы) — классы и модули
* SCREAMING_CASE — константы

То есть конечно технически, константа — это всё что с большой буквы (и да, имена классов и модулей — это тоже имена констант соответствующего типа!), но делать принято вот так, чтобы код лучше читался.


воскл.знак после uniq! — зачем?


you're right! it's now corrected


you didn't fix it
now this problem causes memory leak


Just looking at this again, and it would be clearer to call the ResourcesListener class something like ResourceReferenceRemover.

Or even go a step further and split it into 2 - a StylesheetLinkRemover and a ScriptReferenceRemover. We could then only pass them stylesheet and script resources respectively, and then only if there are stylesheet or script resources.


Same typo in the release notes https://github.com/composer/spdx-licenses/releases


Isn't this an implementation detail?


Maybe something like:

```HTML
<p>The lifetime of a <a href="#dfn-service-worker">service worker</a> is tied to the execution lifetime of events
**and** not references held by <a href="#dfn-service-worker-client">service worker clients</a> to the
<code><a href="#service-worker-interface">ServiceWorker</a></code> object.</p>

<p>A user agent <em class="rfc2119" title="MAY">may</em>
<a href="#terminate-service-worker-algorithm">terminate</a> <a href="#dfn-service-worker">service workers</a>
at any time that:
<ul>
   <li>it has no events to handle,</li>
   <li>or detects abnormal operation: such an infinite loop, or tasks exceeding user agent imposed time limits (if any) while handling the events.</li>
</ul>
```
It just breaks it up a little bit more.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3201](https://teamcity.mesosphere.io/viewLog.html?buildId=66714&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:07:50


I think I saw you using `.xpath(xpath)` in an earlier commit


У этой задачки, кстати, было чуть более изящное решение (хотя и это принимается), вот такое:

```ruby
films.map{|f| f[:author]}.uniq.   # => массив строк с ФИО режиссёров
  sort_by{|d| d.split(' ').last}. # => массив ФИО, отсортированных по фамилии —
                                  #    split мы делали только внутри sort_by,
                                  #    так что он вернул по-прежнему просто массив строк
  each{|d| puts d}
```


Shouldn't file filters be case-sensitive? Windows doesn't care but other filesystems might


We should rename this to something more clear


Hi!!!


hmm - I'm pretty sure you created a dedicate support for generating doc.go file (the PackageDocumentation var is used there).
Do we really need it?


@tymochko тут нет смысла расписывать цвет `#838383` в `rgba` формате. Посмотри сколько лишнего получилось


恩了解~


You might have to add spaces around ```VERSION_MKSTRING``` to make all compilers happy, see e.g. 3886ed0.


Вооо, это дело! :)
Тут есть два важных замечания, тем не менее:
Во-первых, если ты перебираешь массив пар, то можно писать вот так:
```ruby
...group_by {|a| a}.each{|name, group| puts ....}
```
↑ т.е. если твой блок принимает две переменные, а каждый элемент массива — это пара чего-нибудь, то Руби сам это поймёт и засунет в каждую переменную кусочек пары.

Во-вторых, для вывода строк, составленных из других строк, лучше использовать не суммирование строк, а string interpolation:

```ruby
each{ |name, group| puts "#{name} - #{group.size}"}
```


@tymochko да, сделай одинаковые у всех кнопок отступы


I think you could append these directly to inoutbuf.


proposing to revert this to get higher answer rate again.


Looks good :)


some of these long calls we could maybe proxy on the `FormProcessorInterface` to make them nicer to use.


Can you please add an explicit comment that a user needs to add a type comment "// + genset" to have a set of that types autogenerated?


`Path to OpenCover executable is missing` would be a better description.


Did you really want to remove the version?


Can you add config for other module systems like amd, root etc similar to react config


The class is stateless, as such there's no harm in using the copy instead of the move constructor. And as far as I can tell the STL containers only require a copy constructor for allocators of different types, no copy assignment. (Fwiw the default copy assignment (`Allocator< T, tag >& operator( const Allocator< T, tag >& )` is implicitly available.)


isn't it too often?


It might also be useful to add it as a file comment.


t

Deze letter heb je gemist


see #14


http://www.gelderlander.nl/polopoly_fs/1.4709667.1421000180!image/image-4709667.jpg
Deze is voor jou kleine bitch David.


Will those be sorted?
If not, can we add a support for the framework for sorting import lines?


`Path to OpenCover executable is not set` would be a better description


@msom yes, since we use ftw.upgrade the version in the metadata.xml isn't required anymore.


Convert? :)


Just use @simplecommand from basecommands.py ;)
I recently added some documentation for it. What are the downsides?


The export on line 121 above doesn't look right when I contrast it with the export on line 52.


Personally, I don't agree with that.
But forcing you to change that when you already wrote it would be waste of time :)
Anyway, I would suggest removing this comment.


On certain filesystems the files are case sensitive.


Fixed in 101eb31.


I might be confused, but it looks like this commit and https://github.com/Pylons/pyramid/commit/cd13bc7b1a16e930325c063fc27626a5cc92bbc9 broke something on Travis:
https://travis-ci.org/Pylons/pyramid/builds/88712134
https://travis-ci.org/Pylons/pyramid/builds/88712147


This is very nice, I always wanted this feature as in normal usage the state "unreachable" means that the bulb is turned off.


Forry practically never gets one-shot anyway, and Overcoat protects against powder moves...


This is so similar to the other one I wonder if we can't create a base class with a few functions to override:
```python
def new_form_id(self)
    ....

def create_form(json_form, form_id)
    ....

def is_duplicate(form_id):
    ....
```


~~afaik <~~ ro desc < Aegis script


Typo in the link to `spawns the test files`. => #isolated-environment


Missing `received_on`


Yes, ugh. Sorry.
I have committed a "better" fix: d250f19
I'm not sure if it's included in this pull request or not..


Sorry, I haven't been maintaining this a lot.
Thanks for your PR, will merge.


I think that all the comment after "written for every type." doesn't provide any value - it's just default syntax of templates, right? I would just remove it.


Should't this be a primary key? Also I think convention would place this field at the top.


老师为什么这两行不能有注释。把注释加上后，主体内容就没有了。只剩下Header和footer了


FYI, collective.solr (4.1.0) seems to have the same issue, and this tries to fix it - https://github.com/collective/collective.solr/commit/6e33ccc6e60813aedc079f43540ec4756b148e98


I have ```3.7.0-svn251177-1~exp1``` and did not see an issue here. What's your boost version? Did you check with gcc to exclude a boost issue?

Also, the header potentially defining ```BOOST_CLANG``` isn't directly included, which it really should for clarity/safety. Are sure you sure it's always defined to 0 or 1? Using ```defined(__INTEL_COMPILER)``` could improve readability.


This task is very fast so I don't think it will make big performance impact on app. Another problem is that we need to check that quite often to make sure developers are not booked for too long (7 days) and this really depends on timezone also.


Is this the JSON? I think we decided not to store that in SQL. If we abstract out the attachments handling we could just save them to disc for now which would allow tests etc. to work.


Should probably do here the same as in div_op().


why do you need that ? toString already does this ...


Will this URI (once the RFC number is minted, of course) resolve?


I just tried using the above solution but it's generating an additional query for each user, like:

```
SELECT "groups"."name" FROM "groups" INNER JOIN "group_users" ON "groups"."id" = "group_users"."group_id" WHERE "group_users"."user_id" = 33588
```

which is effectively doubling the CSV export time :disappointed:

Whereas:

```
user.groups.each do |group|
  group_names << "#{group.name};"
end
```

is not generating any additional query.


I don't like "rewrite that" commits without any rational why it's a good idea. What was wrong before rewrite ?


I don't see it? :x


Can you please format this comment in a more readable way?
Looking into example of generated code:

    // ByteKeySet creates a Byte from a keys of a map[byte](?
    // extends interface{}). If the value passed in is not actually a map, this
    // will panic.

the line split in the first two lines is not very readable.


We still need to discuss this url. IMO we should use just `https://torproject.org` since that is base url for the project.


@Mugi4ok Please delete this repo or hide it. We use the same tasks for all candidates.


nit: remove this line


No. This is the tool we intercept, and not the OpenCover executable.


Define 'likely' :-) It might happen *always* under some special situations (obscure OS, obscure file system, network mounts, who knows). Also, ftruncate could w

The 'perfect' approach would be to have an extra lock file and *not* overwriting the old data.
- lock the extra lock file
- read from hsts file
- write to temp file
- rename/move temp file to hsts
- unlock/close the extra lock file
In this scenario, we could stop processing (if an error happens) at any point without losing data.

Since we need this implemented also for cookies and ocsp... maybe we can think of one or two helper functions. Any idea ?


@lots0logs : Thanks. I will try asap.


why don't you restrict MailboxListener type (I mean using java types) ?


Yes. Correct. Will change.


I feel there are two problems with this fix
* it would not work as is if a scale is involved in the transformation. The correct code is
```C++
Ns = xfmNormal(local2world, Ns);
```
because a normal is only "quite" a vector
* the fix is application dependent. I think it could be better handled within Embree.
For instance, in FastInstanceIntersect1::intersect
```C++
      if (ray.geomID == -1) {
        ray.geomID = ray_geomID;
        ray.instID = ray_instID;
        ray.Ng = xfmNormal(instance->world2local,ray.Ng);
      }
```
and so forth for all variants and user-geometries


Hello,

This changes is already there. Still I got the same interrupt trigger.


collision with a record access function in Types.hs but probably it can be avoided with careful include statemnet


I wouldn't write "1, 2, 3" as elements of the set, because it doesn't have to be set of ints.
Maybe sth like:
s1 = {a1, a2, a3}
?
WDYT?


挤挤


Hi Jens,

First please accept my apologies for the delay in my response, i was away from anything looking like a computer during the past 2 weeks.
If i recall correctly the `ClientImpl.close()` method was committed here by mistake, it is like an "oops" commit then (that was my first time using git  ;-))

But please, keep in mind that my beanstalkd client fork is totally unusable as is, you should only rely on the official beanstalkd client branch.

Thanks a lot for your patience


Мне показалось это логичным, эти правила нужны для <a> которые под <li>, да, в данном случае других нет, и оба варианта сработают одинаково, но чтобы выдержать логику изменил. Это ошибка?


Same here.


Why don't you return a List ? And why not an immutable one ?


you are leaking your internal representation


?
I think you should remove this line.


4: M190 line is too long (76 > 72)
8: M190 line is too long (74 > 72)


Again, maybe
"s1 = {a1, a2}"


I am worried about deadlocks ...


Correct, I should create a private method for getting custom user fields and group info. Will do and verify that performance is not affected.


vim search/replace typo? ;-) (same for two lines above)


Can't find any usages of this in the code (except where it gets set). I wonder if we can get rid of it. @dannyroberts @czue


Also curious about the usefulness of this.


Can you just use IsSuperset here?
[This will simplify the code.]


The rest all LGTM.


Can't find any usages except where it gets set @dannyroberts @cz


Argh, I won't update to the changesets after the introduction of HDRColor. By making HDRColor the default, you are asking everywhere for instances that represent a special/rare behavior. I think a better change would be only to require HDRColor where it is effectively required, for example in Filters that are HDR aware (I like the Filter class). My main problem is that the backing panel you added is too heavyweight because it is a Group itself. By a forwarding panel, I meant an almost stateless panel that would translate colors when required. But it is difficult to do because you directly depend on HDRColor in HDRPanel, for example in the calls `HDRColor.rgbaHDR(color);` <- a static call, hurgh cannot be changed by a subclass.

As you said, we ultimately only display RGB colors; so the APIs should reflect that: they should accept Color, and *may* do fancy stuff when receiving HDRColors. For users, I think it is nice if SquidPanel and friends depend on libgdx' Color (or a T extends Color), because any code uI'm sorrysing libgdx can be upgraded to using SquidLib without too much trouble. It is fine with me if in a few key places or if in the root SquidPanel class there are a few methods that look dumb for Color, but have a special effect for HDRColor (a well placed `instanceof` is fine for me). To sump up, I have the feeling that the code could change very little, and be nicer to users that actually don't use HDR colors, who would like not be disturbed too much by their introduction.

I have little time to contribute these days, but I'll try to see this evening if I can come up with an alternative usage of Filter that doesn't propagate the dependency to HDRColor everywhere.


Total height greater than 2000000000 pixels? Even if every single node is as large as fullHD monitor, it will take 2000000 nodes to overflow. Int64 will slow down calculations on x32 systems.


Fixed in 51f73ec833d7eed6071aa5979250b154351985c2


Wird es die Möglichkeit geben, diese "Kategorisierung" auch auf der Webseite darzustellen? (vgl. http://dunningen112.de/c/einsaetze/einsaetze-2015/539-verkehrsunfall-eigeklemmte-person)

Und wird es diese Gruppierung auch für die EXTERNEN EINSATZMITTEL geben? Das wäre klasse ;-)


色彩视觉稿上已经更新了吧。


I see your nitpick and raise you a nitpick on your nitpick  :laughing:

```ruby
case matcher_key
  when 'Os'
    matcher_key = 'Operatingsystem'
  when 'Group'
    matcher_key = 'Hostgroup'
end
```


Right. For some reason the inspection did not run for me.


maybe move it outside the Test* as well as the testConsistentHashAlgorithm ?


bad idea


LCN, LCNBAT, VMUK: if service data from the NIT is partial, (i.e. not zero length) service data from the SDT must be confirmed by service data from the NIT for the service to be accepted.

LCN2 and LCNBAT2: This test is skipped, and service data is solely based on the content of the SDT.


why the bang?


no final ?


Just to ensure (I didn't check it, so I don't know): would append be efficient in this case?
Wouldn't sth like: res[i] = key, be better?


wow :) :+1:


FYI, babel-cli (latest) is still depending on babel-core@6.0.15


locale 这种改动升 MINOR 版本吧。


Am beginner in Sklearn
how to run this in windows ?
I want to use this for Language identification.I.e English and Hindi words with annotated with corresponding tag ( response/en from/en , Kysa/Hi ).


lgtm


... this commit log is so cool


just to make code more readable, please divide this into methods (references = methods running the following lines, etc)


I think this was last used in the v0 to v1 HQ migration when we wanted to preserve submission dates. my guess is that it can be removed


Why? I think we decided to get back to "OoptionalBody". didn't we?


(@dannyroberts should confirm though)


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 43](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=395&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


@smelc To be perfectly honest, after implementing this I have a hard time seeing where HDR has a significant advantage over regular Colors. There's some advantages for specific filters, but the most common uses don't really need HDR to work. I'd be perfectly happy to roll back the HDR changes but keep filters.


you should enforce immutable events by doing a immutablecopy of input list and maps


cool message...


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 43](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=395&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:11


no error case at all ?


guessing we can.


Because:

- It will be extremly difficult to find and debug. You'll need to go down
to assembler to actually see how the compiler has optimized the code...
- With TT, we are protected by the fact two threads will very rarely access
the same slot simultaneously. So even if the result is garbage every time
this happens, it doesn't make a difference.
- Here we'll ask threads to access same variables concurrently >100 times
per second. If the result is garbage every time this happens, it completely
breaks the behaviour.

On Mon, Nov 2, 2015 at 12:18 AM, mstembera <notifications@github.com> wrote:

> I think Marco is right. Any failure mode is benign(unless someone can
> think of a case) so why defeat any optimizations by using atomics?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mcostalba/Stockfish/commit/edac860627b6706e1c0722812c72731dc02d463d#commitcomment-14117263>
> .
>


Ah ok! I just realized that the user groups have already been eager loaded. :stuck_out_tongue_closed_eyes:


@pol0nium, what a commit <3


I'll start a discussion in issue #54 , where this all started.


why did you remove static import ?


I thought it should be copied and used from x86/64 folders based on the configuration. Would you submit a PR with working version please?


I think you ca remove "Based" from the class name


should not do a new query, just find the item in the array.


```ruby
references[key] = matcher_key.constantize.where(:id => ids.uniq).to_a
```

you want this to be an array, not a scope


The docs are a little confusing but I've done some testing and am pretty sure it works like this:

If `Read` gets any data from the stream, it will populate the buffer until either `count` bytes have been read or there is no more data to be read from the stream.  If there is no data to be read, it returns immediately, not after `ReadTimeout` milliseconds.  No data from the stream would normally be because the rest of the data is still being transmitted over the network.  It could also be due to the full request having already been received, but only if `count` was set to a value larger than the request.

If there is no data to be read when `Read` is first called, it waits until `ReadTimeout` before throwing an IOException.

In the case of our loop, multiple calls to `Read` will be normal for large requests.  In the case of a request being interrupted, the current `Read` request will not throw an exception, just return the number of bytes it's read.  The following loop iteration will then call `Read` and that will throw the IOException after `ReadTimeout` milliseconds.

The current approach (setting `count` to the content length of the request and letting `Read` process as many bytes as it can on each iteration) should therefore be the most efficient way of handling requests - for now at least.  When UploadFileExecutor is implemented we might need to limit `count` and flush data to disk on each iteration.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3202](https://teamcity.mesosphere.io/viewLog.html?buildId=66718&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:21


this comment looks useless, it's just a rewording of class name


河蟹赛高


nitpick: indentation


yay!


Logic: Player / Enemy values should be reversed.


Could you explain this class ?


Should we maybe test on stricter compilers, so that we can eradicate all such problems?


There's a bunch of very verbose, complex and non-obvious code in this commit. You should probably try harder to make things simpler


I think that this code should be in a hook function for `flyspell-mode-hook`.  If it's only in the toggle it won't affect modes that bypass the Spacemacs toggle and directly enable Flyspell Mode.


@urosaria
대충 설명해줬지만 이런 커밋은 전부 합쳐주세요.
리뷰할때는 커밋을 따라가므로 순간 제가 리뷰를 놓쳤네요.
참고하실 링크 두개를 소개합니다.
커밋을 언제합치고 나누는가는 여러 문제가 있지만 하나의기능 = 하나의 커밋 이 이상적입니다.
http://ko.gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
http://mohwaproject.tistory.com/entry/Git-rebase-%EB%AA%85%EB%A0%B9-%ED%85%8C%EC%8A%A4%ED%8A%B8

p.s
추가적으로 git commit 메세지도 제가 알려드린 다음과 같은 포멧으로 사용부탁드립니다.
```
<type>(scope) : 간략한메세지
== 빈줄 ==
자세한내용
```


:+1:

I would suggest one slight change...

`This project use several...`

should be:

`This project makes use of several...`

Also, you might want to provide links to the associated GitHub projects.


it doesn't help


Sorry about that! I pushed a fix that passes the tests. There might be a bug in the return type of one of the cases of the complex Base.LinAlg.givensAlgorithm.


the comment doesn't help. The interface could very well be used for other purpose like internal events.


implements Closable


@janekptacijarabaci
This entire polyfill *(I call them shims because they fill in the gaps and I'm old school ;)* should probably go in https://github.com/janekptacijarabaci/greasemonkey/tree/master/modules/third-party

Btw pinging me is using my username like I'm pinging you at the beginning of a message... although this is your repo so you'll know anyways. :)... you can always add them in after you create a comment too and remove them whenever necessary.

Anthony is keeping the project ES5 from what I've read too... so not sure a shim is a good idea at this time.


From a scientific point of view, the calculation power is best spent here in this test. A test should be given the opportunity to finish. Otherwise do not start it - you define test parameters (including stop conditions) first. In order to control resources the 128000 game limit should have been lowered before starting. One might consider which stop condition would have been fair and appropriate and try a correction to save the test.

Please consider: The average effort for a gain of 1 elo over the last two years has been between 1 and 2 million STC game equivalents (including overall quality control and maintainace). This particular test is having an impact of 100 STC games per test game, this amounts to 750 000 STC games.


please don't use setters, they are just promises we can't keep.


there's some util class for that in cassandra backend


When would we need to check for infix patterns here? It seems like everything is working fine with them right now.


Wow, weird that gcc will let me even compile this and even not give any warnings.


Oh, OK, I see the point now, you don't want to error out of the function that wraps both routines (one working without geographiclib).
Still, in this place it should definitely raise an exception, because calling this function makes no sense without `geographiclib`. Instead you should `try/except ImportError` where it's used (i.e. [here](https://github.com/obspy/obspy/pull/1164/files#diff-1667c484b259a6cf774ac6ea98b2e520R451) and [here](https://github.com/obspy/obspy/pull/1164/files#diff-1667c484b259a6cf774ac6ea98b2e520R494)) and make the exception message a warning..

i.e.
```python
    try:
        arrivals = add_geo_to_arrivals(arrivals, source_latitude_in_deg,
                                       source_longitude_in_deg,
                                       station_latitude_in_deg,
                                       station_longitude_in_deg,
                                       self.model.radiusOfEarth,
                                       self.model.flatteningOfEarth)
    except ImportError as e:
        warnings.warn(str(e))
```

Or if the message isn't fitting enough create a different message here..

(Or you could make it an `if HAS_GEOGRAPHILIB: /else: warn`, which might be even clearer to read in the code (because we're not really surprised about the ImportError if `not HAS_GEOGRAPHICLIB`))


@dschulten How would an `application/problem+json` document using the above context and vocab look like? I guess you'd need to reference them in a `Link` header if the `Content-Type` is not `application/ld+json`?


why ?


I cannot find this function in the latest version of python-pcl.
Was this commit removed later? Do we have any other function to calculate normal of  the point cloud?


Loooool


How will a JSON-LD processor resolve the `problem:HttpProblem` value? Don't we need to say that it's an `@id`?
```json
"rdfs:domain": {
  "@id" : "problem:HttpProblem"
}
```
Or am I missing or misunderstanding something?


Why not ExcpectedException? It would let you rid off try-catch in the test.


I tried looking into this also and what I noticed is that when I try to add the respective dlls from the nuget packages, its get copied to the bin folder - but if you clean the project, the files get removed and the next time you try to build/publish the files are missing...


Sounds good.


Namespace was already read from the transport stream for fastscan providers since it was fixed last year. Doing the same for all providers means no custom namespace hacks are needed for any provider.


Is it possible to get nil properties or it just does not happen?

If not, why don't we remove the = nil in the save method?


please avoid setters at all price


you don't really when a timer for each distant listener, don't you ?


would 2500 be ok?


it deserves a type


Dear @szaghi, you're right: I'm a good freediver but a very very poor Fortran programmer :-)
 The differences between Newton-Cotes formulas are not only the weights, because NC6 splits the integration interval [a,b] in five parts, while the NC7 splits the integration interval [a,b] in six parts; in practice, there's also an additional term in the integration formula, as can be seen from the general formula of Newton-Cotes:
Another aspect is that all the integration algorithms that I've already implemented can be attributed to the Newton-Cotes formula group, so I think that can be more clear and concise to make an only one module `<newton-cotes>` where I put all the algorithms: in this case, do you anyway think that can be valuable to use an `<init>` procedure to chose the integration formula? And what could be the parameter: the formula degree or the formula name? I think to something like [this](https://github.com/Fortran-FOSS-Programmers/FOODIE/blob/master/src/lib/foodie_integrator_tvd_runge_kutta.f90#L133-191), but in such way the integration formula will be more "abstract"...


why don't you use ImmutableSet.copyOf() ?


Is the intention that JSON-LD IRI processing will expand rdfs:Resource to http://www.w3.org/2000/01/rdf-schema#Resource ?


you should put the value in a named variable to make this readable


Remove?


Resolves #6


This project is deprecated.  Sorry!


Well, that's a bit harsh. Can't we do something even if we don't have a node? At least we should just exit this method without doing anything, but definitely not a crash.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3204](https://teamcity.mesosphere.io/viewLog.html?buildId=66721&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:17


Why is it no longer needed to update the operstate and make the link dirty now?


Is it possible to make this less hard coded? I guess it's fine for now as long as we remember that we have this here.


I can't seem to find a case when this code is used. The following code is highlighted correctly:
```
object Bar {

  def main(args: Array[String]) {
    type Foo[A, B] = Either[A, B]
    new TupleSmth(null, null) match {
      case (1, 2) TupleSmth ((1, 2, 3)) =>
    }
  }

  case class TupleSmth(a: (Int, Int), b: (Int, Int, Int))
}
```


@igorid какую логику? Ты понимаешь, что в цепочке появился новый элемент, по которому движок браузера будет осуществлять доп поиск? Да, браузеры сейчас очень крутые и оптимизируют поиск по селекторам. Но тем не менее, если есть возможность выбросить лишнее, нужно это делать. Ещё один минус твоего решение — ты добавляешь больше веса этому селектору. В дальнейшем, если нужно будет переопределить эти стили, нужно будет писать селектор с ещё бОльшим весом


This only tests, that timeout don't exceed given timeout, but not tests, that it isn't too short.


Hmm.. This will break setting playback start time right?


In my opinion, this is not a perfect solution as when the sticks back to neutral position, the aircraft will drift for a long time befor stop.


Ok... Written before your commits, I'll update


No it doesn't. It does brake hard because its commanded for zero velocity. I propose you try out it in sim to see the effect.


To be sure it's deleted.


@igorid зачем на ховер меняется тип элемента?


Ok, I see, `a` and `f` can also make an effect without `geographiclib`.. In that case (at least?) [this place needs a change](https://github.com/andreww/obspy/blob/taup_geog/obspy/geodetics/base.py#L108-L109). You need to pull up those hardcoded values into the call definition as defaults, otherwise [this change is without effect and even misleading](https://github.com/obspy/obspy/pull/1164/files#diff-1cce358018cd2fd1e26a5d8bdd928b36R38) (which ultimately shows that there should be a test for non-default `a`/`f`..).

Again, I'll just do a PR.. faster..


That question makes no sense out of context The frame size depends on the stack.


@igorid зачем это здесь?


Shouldn’t this be `LegacyDatabaseSessionHandler` instead of `DatabaseSessionHandler`?


No, you've got only one DistantMailboxPathRegister per James so only one Timer per James ;-)


@igorid это плохое решение с отрицательным марджином


The key value of pressing power key and holding power key is exactly same. Since SPEC may define these two actions with two different behavior. Maybe you can use two different key values. pkey_released & pkey_pressed could use KEY_POWER. And pkey_held could use KEY_RESTART.


@v01d The problem before was that the position was locked too early, so the quad would break and then go back some distance to where it came from. I noticed this on a outdoor test on Friday. I tested the fix in SITL and it feels good. But feel free to try it out and comment.


@igorid на границах элементов верхнего меню есть баг — при наведении курсора все меню «скачет»


couldn't?


Why not create the DualRouter inheriting Router against the fact that you did include an instance into it?


Been searching entire google database for monitor mode on rtl8188.. this is the closest one I've found. Thank you!
Question: What do you mean "You will need to select CONFIG_CFG80211 option to build it."? Where?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3203](https://teamcity.mesosphere.io/viewLog.html?buildId=66720&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:10:24


TeamCity pull requests :: netty [Build 551](https://garage.netty.io/teamcity/viewLog.html?buildId=2897&buildTypeId=pulls_netty&guest=1) is now running


Clearing the StringBuffer by using setLength(0) should fix the problem. Thought about using delete(0, stringBuffer.lenght()) but setLength is cleaner. What do you think?


At here, HZ means 1HZ. So it will wait with wake lock for 1 second. But you need 4 seconds. So updating to 4 * HZ is required.


@StreakyCobra @lunaryorn I changed that in https://github.com/syl20bnr/spacemacs/compare/ab9c8c020dbc...09cb12cf3049. Also made the toggle choose between flyspell-mode and flyspell-prog-mode (this was annoying me).


Isn't this a endless loop?


No. I was hoping such a change would at least bump a minor version and add a note to CHANGELOG and README. My project linked to erlware_commons/master and broke overnight.


Loose coupling sir :+1:


Attempted to make this error message more like the one for DOM properties: https://github.com/ali/react/commit/b2a86426ae0fd696ddb7192b1c9e5ad6582ae93a#diff-f04a397aa63ac69c28dab46e9863bb90R99


The purpose is :
 - to relocate the class in a new package
 - to generalize MailboxListenerRegistry to ease the writing of new Delegating Listeners


Sorry, forgot that after testing it. Next time I'll do that before committing.
"stringBuffer" instead of "s" should be ok I guess?


devm_kzalloc() is better.


Ok đã update


Let's go with critical, in the end we might revisit them. When Jens and I discussed it, we decided mostly to use critical checks because all lamba code is deferred so we need the checks even in the optimized code to fail-fast.


@Martii

> Btw pinging me is using my username like I'm pinging you at the beginning of a message... although this is your repo so you'll know anyways. :)... you can always add them in after you create a comment too and remove them whenever necessary.

I'll try to remember :-)

> This entire polyfill (I call them shims because they fill in the gaps and I'm old school ;) should probably go in https://github.com/janekptacijarabaci/greasemonkey/tree/_forkBranch_SeaMonkey_PaleMoon/modules/third-party

ECMAScript 6 is officially a standard (06/2015). See https://forum.palemoon.org/viewtopic.php?f=1&t=10009 - "Support for more key ES6 features (in progress)". I'm waiting for it - I'll remove it later.


I didn't wanted to rely on *instanceof*, and if I implement it using types, you'll see in later commits I'll need it ( Differences between Broadcast and Registered Delegating listeners )


this does not test time of timeout.


ok


Awesome - how do I stay tuned !


Previous implementation....


Ok


これって下の方は別に消さなくても良いよね？
というか コメント無いとうっかり消す人が出てくるのではないかと思うので。


here is also lack of time of timeout check.


I'm glad to read your message. This morning on the way to work I started trying to lessen the need for HDRColor, but it is pretty difficult, as it spread everywhere. What I think should be kept is the option to specify a filter in `SquidColorCenter`, because that's an elegant way to change the look'n'feel of a whole game in a single method call (normal color center, rogue gets a killing fury, clear the center's cache; set a filter redifying everything, redraw, et voila the fury is visible everywhere!). The only change is that I would made `Filter` an interface, to be more flexible.


bon commit! molt useful


Fixed.


Maybe we will use java or groovy configuration?


Grade for rock/paper/scissors: 100%. Watch for the double equals sign vs the triple equals sign (they mean the same thing in this scenario, but not always). Nice work!


Ah, ich sehe da was. Du hast da die Development Version verwendet die noch kein stable Release ist. Vermute, dass das deine Inkompatibilität verursacht hat...


@lucasart grow up!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3282](https://teamcity.mesosphere.io/viewLog.html?buildId=66966&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:11


@binky123 Not always true from what I'm now seeing (3 threads, HT, 60'+0.4"), indeed it's not uncommon that it is at the highest depth. I'd like to test again my latest patch after replacing "8" with "2" (in order to give the score difference 4 times as much weight...) but let's wait for your try first. :-)


Imho "Select all" should have filter which would add only contributors with approved translations for this locale. I'm not sure how often locale managers will use "select all" to select all contributors.


Ok.


Did we decide on what this should be called? I thought the examples said playbackCategory, not bufferingHint.


Ok, I will hack this around tomorrow.


No need to review this one. I have created a test to check if the fix from #8266 will fix this error.


Fixed


Day 7 (rock/paper/scissors): 16/16. Watch the double-equals sign vs the triple-equals sign, as that can change the meaning in certain scenarios. Nice work!


@dianakhuang I'm seeing errors in the LMS like this:

    Invalid 'X-Frame-Options' header encountered when loading 'http://localhost:8000/xblock/block-v1:AndyA+AA101+1+type@video+block@19858daa6bd54b43a6aa43d63192b7b3':
    'ALLOW' is not a recognized directive. The header will be ignored.

It looks like ``ALLOW_FROM`` is the only directive and that there isn't one called ``ALLOW``:

https://developer.mozilla.org/en-US/docs/Web/HTTP/X-Frame-Options


added similar method to UserController.java, I will remove my after merging


who does this guy think he is


Okay, I guess we'll leave it for now, and hope we aren't using the bits of
hibernate-validator and resteasy-cdi which are affected by the differences
in javax.validation 1.0 vs 1.1.  If not, we'll just have to come back to
this.

On 2 November 2015 at 12:12, Patrick Huang <notifications@github.com> wrote:

> hibernate-validator and resteasy-cdi are the two (plus gwt-user which I
> think it's fine to exclude). I can't seem to find zanata-api depending on
> newer version but somehow the require upper bound report shows it as well.
>
> On Mon, Nov 2, 2015 at 11:54 AM, Sean Flanigan <notifications@github.com>
> wrote:
>
> > @huangp <https://github.com/huangp> This may get rid of the "upper
> bound"
> > error, but presumably at least one of these libraries requires a newer
> > version of Validator than the one we have.
> >
> > We may need to look at downgrading some libraries. Which libraries were
> > bringing in the newer version of Validator?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/zanata/zanata-server/commit/d07bdf408a2d9b453bb16a60616d32f1c865173e#commitcomment-14117887
> >
> > .
> >
>
>
>
> --
> Patrick Huang
> Senior Software Engineer
> Engineering - Internationalisation
> Red Hat, Asia-Pacific Pty Ltd
> Level 1, 193 North Quay
> Brisbane 4000
> Office: +61 7 3514 8278
> Fax: +61 7 3514 8199
> IRC: pahuang
> github: github.com/huangp
> Website: www.redhat.com
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zanata/zanata-server/commit/d07bdf408a2d9b453bb16a60616d32f1c865173e#commitcomment-14118018>
> .
>

--
Sean Flanigan

Principal Software Engineer
Globalisation Tools Engineering
Red Hat


Why do you ask for their names if you are going to assume that they are Ned and Mary here?


Wow


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3283](https://teamcity.mesosphere.io/viewLog.html?buildId=66967&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:06:14


Tsss, tss, Ingo. Pushen ohne zu kompilieren. Schäm dich was! Dabei sollte es doch offensichtlich sein, das die letzte Zeile entweder einen Typfehler oder eine Endlosschleife produziert.


@Frenchaire You'll want to fix up your formatting here. Look at the "commits" to see what I did for others.


@Frenchaire You ask for two names, but then you assume that people are named Ned and Mary.


We could improve security of this view by adding decorator @login_required and has_perm check.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3284](https://teamcity.mesosphere.io/viewLog.html?buildId=66969&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:02


@1aries1 You should avoid having the same variable declared more than once. Look at the others' code to see how they picked a different name for the variable. Ask for help if you're having a hard time with this.


@phase Pretty much. I completely forgot to comment that line!


This instruction isn't 100% clear to me. Where does the multiple filenames separated by a delimiter thing happen? (and what are valid delimiters?)


Jeg ved ikke om det er relateret, men lige nu ser der altså ikke ud til
at blive ryddet op.

top - 01:12:34 up  8:58,  2 users,  load average: 8.74, 8.21, 7.97
Tasks: 223 total,   4 running, 218 sleeping,   0 stopped,   1 zombie
%Cpu(s): 99.8 us,  0.2 sy,  0.0 ni,  0.0 id,  0.0 wa,  0.0 hi,  0.0 si,  0.0 st
KiB Mem:   2071648 total,  1786684 used,   284964 free,     7808 buffers
KiB Swap:        0 total,        0 used,        0 free.    57476 cached Mem

  PID USER      PR  NI    VIRT    RES    SHR S  %CPU %MEM     TIME+ COMMAND
26862 odroid    20   0  170936  19424  14140 S  63.4  0.9  53:57.53 surf
 5464 odroid    20   0  170180   8008   2840 S  59.5  0.4 120:47.46 surf
28190 odroid    20   0  170936   8148   2852 R  59.1  0.4 168:05.22 surf
 5758 odroid    20   0  170936   8144   2852 S  57.8  0.4 449:05.67 surf
 3904 odroid    20   0  170176  19068  13888 R  56.5  0.9  25:06.80 surf
 9551 odroid    20   0  170928   8144   2852 S  52.6  0.4 108:49.58 surf
10970 odroid    20   0  170812   8088   2852 R  50.9  0.4 255:46.25 surf
13388 root      20   0    4732   1312    832 R   0.7  0.1   0:00.14 top
  288 root      20   0    3016   1584    416 S   0.3  0.1   0:05.58 upstart-udev-br
13166 root      20   0       0      0      0 S   0.3  0.0   0:00.03 kworker/0:2

On 02/11/15 11:37, Troels Henriksen wrote:
> Det er også risikabelt hvis nu processen ikke lukker ordentligt ned.
>
> Men når vi genstarter maskinen hver dag, så går det nok.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/datalogisk-kantineforening/infoscreen/commit/7bd177e8ff34d58a55a3785eb12fc7a635dec063#commitcomment-14136543


I guess the Q is how do you have golang.org/x/net already in your manifest as there really isn't anything to import there.


Taken from http://stackoverflow.com/questions/111529/create-query-parameters-in-javascript.

May want to consider building URLs with `jQuery.param()` function http://api.jquery.com/jQuery.param/ . You can encode GET parameters like so
```
var params = jQuery.param({
    var1: 'value',
    var2: 'value'
});
```
And `params` will be

`"var1=value&var2=value"`

You can also avoid jQuery dependency too with the following function.

```
// Usage:
//   var data = { 'first name': 'George', 'last name': 'Jetson', 'age': 110 };
//   var querystring = EncodeQueryData(data);
//
function EncodeQueryData(data)
{
   var ret = [];
   for (var d in data)
      ret.push(encodeURIComponent(d) + "=" + encodeURIComponent(data[d]));
   return ret.join("&");
}
```

Seems you're building a whole lot of Congress API wrapper functionality. Not sure if one exists outside node.js currently so may want to consider extracting that part to its own file so it can be used on other projects as well. Check out the ruby wrapper https://github.com/codeforamerica/congress or python wrapper for inspiration/ideas of how to approach the problem https://github.com/sunlightlabs/python-sunlight .


I hope you follow the coding convention


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 70](http://teamcity.otenv.com/viewLog.html?buildId=3674537&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) is now running


Isn't  it better to hold tenant identifier in Users table?


A link to more high level documentation on the way that helm uses git to manage open collaboration under a common authority (e.g., github.com/deis/helm) would be nice here.


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 70](http://teamcity.otenv.com/viewLog.html?buildId=3674537&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) outcome was **FAILURE**
Summary: Tests passed: 37; exit code 1 Build time: 0:0:0


> Makes sense, I just don't know if there are any side effects.

Only thing is that .rc files will need to be generated manually by sync.bat before compiling translation .dll.

> On a side note, you should remove the backup folder from .gitignore too.

PO files are still backup there.

> How about having a solution we can use via the IDE too? Build bat is OK but doesn't cover all cases.

What exactly do you have in mind? We have mpcresources.sln. Syncing translations is another optional step. It would be inconvinient to invoke sync form IDE.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3285](https://teamcity.mesosphere.io/viewLog.html?buildId=66970&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:21


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3286](https://teamcity.mesosphere.io/viewLog.html?buildId=66975&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:20


nit: Always a fan of using Get() for getting singletons (and using namespaces over singletons). Any way to refactor to not require a singleton?


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 74](http://teamcity.otenv.com/viewLog.html?buildId=3674577&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.508.ad796b71d01fe1b2f4dbf1b93ac19725a970e967](http://build.palaso.org/viewLog.html?buildId=65369&buildTypeId=bt323) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:35


current will be a set of integers and new will be a set of strings -> i don't think they'll ever match.


@artemp nice catch, updated the `tif-overviews` processor in d289f71


If d is the length of the stack, can't you just return it instead of recalculating it [here](https://github.com/phase/o/commit/3ab17b686fa59bd60b6185711aeb16f01d7fa5f0#diff-81d78cf95089bf7058db37fd1f0f96e4R210?


I'm curious, why is it named `phpunit-plugin-bootstrap.project.php` and not just `phpunit-plugin-bootstrap.php` and doesn't load and return in `dev-lib` when the file exists in the project?


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 74](http://teamcity.otenv.com/viewLog.html?buildId=3674577&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


Inside of the thumbcache databases there's a 4 byte version number and during the development of Windows 8, Microsoft ended up changing that number a few times. I've only ever come across three versions of the Windows 8 databases (0x1A, 0x1C, and 0x1E). For Windows 8.1, there was only one version (0x1F). The 0x1C Windows 8 version also had an extra (unknown) 4 byte value in it.


If I apply this, I am restricted to IPv4 and don't get any IPv6 support at all.

According to the documentation for `socket`:

> If `AF_INET6` is used, the `IPv6Only` socket option is set to 0 so that both IPv4 and IPv6 can be handled with one socket.

On my system, the effective (and intended) result is that both IPv4 and IPv6 are usable from the one socket. Is this not the case on your system?


Nevermind, just made a test case.


Hey Caroline - looks like you caught up on a bunch. Below are grades for what's turned in and notes about what's still left.

Day 3 - 8/16 points, missing 1) Used psuedo classes to made Benefits list bold (4 points) and 2) Used CSS3 box-shadow on "get it now" button (4 points)
Day 4 - 16/16
Day 5 - looks like you're still working on this
Day 6 - 0/16 codecademy javascript
Day 7 - 0/16 finish rock paper scissors
Day 8 - 0/16 codecademy jquery
Day 9 - 15/16 citipix (small js typo), 0/16 relaxr, 0/16 project wireframes
Day 13- 0/16 final project responsive layouts
Day 15 - 0/16 forms


Yes they are. :-(
Fixing.


The proper way is to define kits in class trigger and declare a typedef-name in tabbar class template. But I am not sure how doxygen works, I don't want the doxygen generates a doc that explains a member type kits for trigger. How to fix it? Thank you


IRC?


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 75](http://teamcity.otenv.com/viewLog.html?buildId=3674627&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


What logic change you are proposing in rand7()?


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 75](http://teamcity.otenv.com/viewLog.html?buildId=3674627&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


Thanks for confirming and fixing!


This sounds like there is detailed discussion in this document under the requestFinalize heading but I see nothing there.


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 71](http://teamcity.otenv.com/viewLog.html?buildId=3674644&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) is now running


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3287](https://teamcity.mesosphere.io/viewLog.html?buildId=66976&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:20


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3289](https://teamcity.mesosphere.io/viewLog.html?buildId=66978&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:20


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3288](https://teamcity.mesosphere.io/viewLog.html?buildId=66977&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:20


@binky123 This provides the basic information https://github.com/official-stockfish/Stockfish/compare/master...lucabrivio:thread_stats


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3290](https://teamcity.mesosphere.io/viewLog.html?buildId=66979&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:03:21


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 71](http://teamcity.otenv.com/viewLog.html?buildId=3674644&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) outcome was **FAILURE**
Summary: Tests passed: 37; exit code 1 Build time: 0:0:0


Don't use == unless you can explain what it does. Use === instead.


This won't even run.


It looks like you are supposed to have a `MAINIFEST.in` instead of including this file in git. Or if you decided that this is the best way to do things, you need to revet my earlier commit.


This will technically run in non-strict mode JavaScript, but it is not what you want. It sets a variable 'txt' that you never use.


Message me on hangouts and tell me which ones and we'll work it out.


Dan,
I assume that with just that line, the parser won't be able to understand the GRANT complete syntax.


It looks like this might be the actual culprit:
https://github.com/edx/edx-platform/blob/master/lms/envs/common.py#L1192

We should fix this in both cases, though.

On Mon, Nov 2, 2015 at 7:09 PM, Andy Armstrong <notifications@github.com>
wrote:

> @dianakhuang <https://github.com/dianakhuang> I'm seeing errors in the
> LMS like this:
>
> Invalid 'X-Frame-Options' header encountered when loading 'http://localhost:8000/xblock/block-v1:AndyA+AA101+1+type@video+block@19858daa6bd54b43a6aa43d63192b7b3':
> 'ALLOW' is not a recognized directive. The header will be ignored.
>
> It looks like ALLOW_FROM is the only directive and that there isn't one
> called ALLOW:
>
> https://developer.mozilla.org/en-US/docs/Web/HTTP/X-Frame-Options
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/edx/edx-platform/commit/0248f8af6d46069d950c052f057f713baf473f44#commitcomment-14142069>
> .
>


зачем нам тут минимальная высота?


typo?


безпрефиксное свойство мы всегда используем в конце. И вообще, префиксы не пиши, я тебе расскажу про autoprefixer))


Interesting.  On my system (which has no IPv6 support) when I try to run without this it says:
```
etamoo: getAddrInfo: does not exist (Name or service not known)
```
I figured "preferred socket type or protocol" meant "otherwise use a reasonable default" but I guess not, and the `AI_V4MAPPED` doesn't seem to work either. I'm not sure what to suggest. A command-line flag, or a catch, or `isSupportedSockAddr` somehow...


I'm a bit skeptical about this simplification because sometimes you have threads whose completedDepth is quite low, but I tend to make no assumptions...


I added jquery ui


`img/slider1.jpg` — давай текст сделаем текстом, а не в картинке


Well, I'm just poking at this with stick right now, and I should have been doing it in a separate branch. The ReadTheDocs build is failing (message is that RELEASE-VERSION) file is not found. Also a user is reporting that the python setup script is failing for the same reason.


we use None and not [] here?


@urosaria
넵 status 는 다른 의미로 사용될수가 있어서 useYn 이 좋을듯합니다.
추가적으로 아직 PR 보내지 않은커밋은 언제든지 사라질수있는 커밋이라..사실 리뷰나 질문 같은거에는 어울리지 않습니다
참고하세요~


quoteString() was the code taken out from fmtId(), which is double quoting the string. We kept the quoteString() method and replaced fmtId_with_single_quote() with appendStringLiteralConn() in the following update. https://github.com/tangp3/gpdb/commit/2c3ddd8aa7fd3269fe1440247763fdc16c9794d4


Clever!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3291](https://teamcity.mesosphere.io/viewLog.html?buildId=66980&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:35


Le faltan algunas correciones


I agree but lets see :)


The matching on the result had value: checking that no other error than `` `Count _` escapes the loop, with `Lwt.ignore_result` it is less future-safe.


@phase How's https://github.com/phase/o/commit/a925a0acfa2a783928e7657e54bda9c42574ab7d?


I dd with 0.4.2 - but I did not push the tag. Argh, OK, I'll fix up the two commits I just did and then issue a new 0.4.2 pre-release annotated tag for testing


Fui copiando e colando o function e nem reparei que tinha add os dois xD


I add  the missing file from the first commit


We should append `.DS_Store` to `.gitignore`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3292](https://teamcity.mesosphere.io/viewLog.html?buildId=66981&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:09:25


`frame.setTemporalModifier(1/Math.max(multiplier, 0.001f))` ?


`isSupportedFamily` and `isSupportedSockAddr` both return True for me for ipv6, so that's not helpful.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3293](https://teamcity.mesosphere.io/viewLog.html?buildId=66982&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:10:22


I highly recommend you make default variables = None and then check if they are None and assign as appropriate within the function. it's technically safe to do it with string arguments because they are immutable, but check out what happens when they are mutable, like lists: http://docs.python-guide.org/en/latest/writing/gotchas/


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3294](https://teamcity.mesosphere.io/viewLog.html?buildId=66987&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:22


Dear Ronak,
There is still one "\" left in the text between "co" and "HO"~~

I've a question, thanks. Is there any reason "/" needs to be removed? I believe"\/" and "||" is to just insert "/" or "\" in the text, not like "\n" or "t". Things like double quote "\"" also need to be removed if so?
Also, I am a little bit confused whether hashtags are extracted from raw JSON data or cleaned text from 1st feature. I am assuming they should be extracted from raw JSON data, but I noticed that in the first given example with text :"Spark Summit East this week! #Spark #Apache", its hashtag field is empty in the raw JSON data. Is it a typo?

Thanks!


These changes are effective but, I see UiHelper doing the work that is the responsibility of a Controller. In this pattern, UiHelper will keep getting bigger as more controllers are added. I propose an alternate way to implement the same functionality in the Controller itself, in a more encapsulated manner.  It uses the same techniques that you discovered, but a different design and it avoids duplicating the same functionality in child onboarding controllers. An outline of the changes is copied below. I have tested these changes on my local and I can submit a pull request if you want.

```

// RootController.ts

        /**
         * An event listerer to hide the left side menu during onboarding.
         * A child like OnboardingSplashController fires this event, like so,
         * this.scope.$emit(Constants.Events.BEGIN_ONBOARDING);
         */
        private begin_onboarding(): void {
            this.Configuration.hasCompletedOnboarding = false;
            this.viewModel.isOnboarding = true;

             // We do not need to call exposeAside() here
            this.$ionicSideMenuDelegate.canDragContent(false);
        }

        /**
         * An event listener to un-hide the left side and navigate to the default view,
         * after onboarding ends. A child like OnboardingSplashController fires this event,
         * like so, this.scope.$emit(Constants.Events.END_ONBOARDING);
         */
        private end_onboarding(): void {
            this.Configuration.hasCompletedOnboarding = true;
            this.viewModel.isOnboarding = false;

            // Expose the side menu in a tablet
            var isTablet = this.$window.matchMedia(this.viewModel.sideMenuMediaQuery).matches;
            this.$ionicSideMenuDelegate._instances[0].exposeAside(isTablet); // sigh
            this.$ionicSideMenuDelegate.canDragContent(true);

            // Tell Ionic to to hide the back button for the next view.
            this.$ionicHistory.nextViewOptions({
                disableBack: true
            });

            // Navigate the user to their default view.
            this.$location.path(this.Utilities.defaultCategory.href.substring(1));
            this.$location.replace();
        }

    export class RootViewModel {
        public categories: ViewModels.CategoryItemViewModel[];

        /**
         * Property to monitor onboarding.
         */
        public isOnboarding: boolean;

        /**
        * Property used to expose the media query for the side menu.
        */
        public get sideMenuMediaQuery(): string {
            return this.isOnboarding ?
                   "(min-width: 99999999px) and (orientation: landscape)" : // never show the side menu
                   "(min-width: 768px) and (orientation: landscape)"; // show the side menu only in a tablet
        }
    }

```


If we keep `d` as the length at the start of parsing, then we can use it there and in `l`.


:D


@dsalas1 this should be `<%=  form_for [@trip,  @entry] do | f | %>`


nextElementSibling will return non-Element node if the node is the last element in its parent and there are non-Element children following it.


LGTM


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 72](http://teamcity.otenv.com/viewLog.html?buildId=3674753&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) is now running


TeamCity Architecture Team :: Java Platform :: otj-components :: otj-data-structures :: build [Build 72](http://teamcity.otenv.com/viewLog.html?buildId=3674753&buildTypeId=ArchitectureTeam_JavaPlatform_OtjComponents_OtjDataStructures_Build) outcome was **FAILURE**
Summary: Tests passed: 37; exit code 1 Build time: 0:0:0


知乎观光团第四波，哈哈


Replace golint with $PYLINT


Would it be better to use URLEncoder or Apache commons codec's URLCodec to handle proper encoding of other characters in addition to " "?


i recommend using 'with connection.cursor() as cur:'. this will ensure that the cursor gets closed appropriately, which you forgot to do :)


Entries Index not necessary.


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 76](http://teamcity.otenv.com/viewLog.html?buildId=3674768&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) is now running


What about `addrInfoFlagImplemented` for `AI_ADDRCONFIG` or `AI_V4MAPPED`?


TeamCity Architecture Team :: Java Platform :: otj-logging :: build-config [Build 76](http://teamcity.otenv.com/viewLog.html?buildId=3674768&buildTypeId=ArchitectureTeam_JavaPlatform_OtjLogging_BuildConfig) outcome was **FAILURE**
Summary: Exit code 1 Build time: 0:0:0


Can you please add a note here something like this?

```
This file is based on the Go linter precommit hook "golint". Therefore, both files are very similar.
```


Line 19,24,29,34,39,44 should be the following `<%= f.text_field <fill in field here> %>`


you don't need local_entities nor local_sources in this query. removing them will improve perf


you should alias your tables consistently


should be `<%= f.text_area :summary %>`


Added a new header


why stat?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3295](https://teamcity.mesosphere.io/viewLog.html?buildId=66989&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:17


can use +=

also why are you using LIKE instead of =?


no need to use triple quotes in one-line queries


Why is this deprecated?


these functions shouldn't have print statements. we can replace them with log statements and the user can control the logging settings


Both True, as is `isSupportedSocketOption IPv6Only`...