The only code I'm really concerned with linting is the stuff in the modules
dir (and examples in the router repo). If you're not opposed I'd like to
revert this change.
On Tue, Nov 10, 2015 at 11:58 AM Jimmy Jia <notifications@github.com> wrote:

> Lint them with the same config as everything else, I mean.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rackt/history/commit/b3e985a091906f808a79ac05a856d39ca9dd0b72#commitcomment-14312216>
> .
>


These functions are another great addition to a `junit-util.sh` file that can be shared.


The docs still mention this -- update them? Or it's just getting moved to Model?

http://gpkit.readthedocs.org/en/latest/advancedcommands.html#feasibility-analysis


hallelujah.


docstring?


this is so cool (from watching the gifs)!

Move the implementation to `interactive` and just call it here in Model?


On MD5.cpp? I know, CppCheck is getting tons of false-positive warnings telling that many var declarations can be moved inside for/while. I skip all these false warnings but maybe this different do-while tricked me. But anyway I already fixed it on next commit :P


is this somehow better than `m1, m2 = Monomial(m1), Monomial(m2)`?


Pourquoi pas de svg ?


doesn't the `Constraint` superclass handle this? If not, why did it work before?


It's ok for me, just wait to see if tipbot stop complaining about it.


In this case nothing is returned, and since the caller to fromData will expect a promise, it will probably end in a new exception...


Yes! Next round of changes will include all of the docs fixes.


Is this supposed to be building a new array with unique values from the old one? Cause I don't see that.


The value I have for this is `sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855`. How was this calculated?


Hoho this is really nice!


This doesn't satisfy me as a test.  I'd like to see all the positive cases used exactly as expected in a normal `test-cmd` script.

```bash
oc::cmd::expect_success "echo ${foo} | xargs ls"
oc::cmd::expect_failure "echo \"This ${foo} should fail\" | grep missing"
```

I'm concerned about spaces and variable substitution in the commands and in the grep.  I'd also like to see tests around nested commands.

Then I'd like a section with
```bash
set +e
oc::cmd::expect_success "echo \"This ${foo} should fail\" | grep missing"
rc=$?
if rc is not as expected
    exit failure
set -e
```

I'm fine with keeping all the other tests, but a test layout like I just described is pretty easy to inspect by people not super familiar with bash.  I can't read what you have here and reason about whether its testing what I think its testing.


ModifyTimeBinsToUseRounding (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1966 of 1966 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'd probably recommend using `File::NULL` here instead of hard coding `/dev/null`.


Instance of https://github.com/MountainRoseHerbs/spree/commit/89721f04363317b9dc1240e400140d43485bb274#commitcomment-14313703


also mention composer/packagist?


@jonasschnelli I cherry-picked this commit and did the cleanup. Let me know when I can squash.


@dkubb A later PR will kill `spree_cmd` altogether, lets ignore this imporvement for now.


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 780](https://teamcity.labkey.org/viewLog.html?buildId=284132&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 50 (1 new), passed: 239 Build time: 00:44:27
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.core.admin.test.SchemaXMLTestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

##### there are 40 more failed tests, see build details
```


You dont know what I mean because I'm an idiot. I didn't use a RaspberryPi linux build and patch it... (hold yourself from crying) I just grabbed your whole tree :+1:   ... Dont think that can work :)  But still bugs me that the CONFIG_R8188EU was not found in menuconfig as it was on VM Ubuntu ...A lot of "?" marks...

Started with linux 2 weeks ago only because I found your r8188eu patch (after going through entire google database... twice). What a way to start... Crash course linux kernels...

Aaanyway..I'm pulling a Pi-kernel as we speak... I'll drop a little fyi if/when I got it working on the Pi.

Just stop me if you know for sure it wont work.
Cheers


This was the reason I moved my projects from 0.4.0 to 0.4.1 because I usually implement my own not-found interceptor and while implementing this is definitely trivial it still reduces the amount of code I type and is replicated across my various pedestal projects.  So again, thank you!


Actually lets ignore this whole PR, since it does not touch places outside `spree_cmd`.


Here's the commit with the update: https://gitlab.com/fdroid/fdroiddata/commit/637fe6


It changed: I threw it inside a `Command` class. The old code was a standalone script.


Extend the signature to innclude return types? eg:

  va(Awaitable<T1>, Awaitable<T2>): (T1, T2)


That's a bit awkward, as it is just a correction in a test ...


yolo swag


> I didn't see a nice way to integrate this into the code and make it no less cluttered. Currently my exit code test is [ ${result} -eq ${expected_code} ]. Could I make the suggested change and keep that line the same for all cases? I'd argue, also, that we need to be as precise as possible with our exit code expectations. If we want it to exit with 2, we should specify that. I don't want to see tests succeed because we allow any failure to be a success, when we specifically wanted a real failure. For reference, I think os.Exit() is only called with an number other than 1 two times, both in Cobra, when args are not parsed correctly.

Update the method to take a "failure" marker var.  Its its set to anything other than 0, then assume it means non-zero code.

The 99% case is that we care about zero and non-zero.  If someone wants to check for a specific code, they can write their own custom method.


You are right. I just fixed this, and also made another couple of refinements to `ruleInfo`. See most recent commit.


> Actually lets ignore this whole PR, since it does not touch places outside spree_cmd.

Do you want to close it?

OT What's interesting is if the code did use `File::NULL` from the beginning none of that conditional logic would be needed.


> Update the method to take a "failure" marker var. Its its set to anything other than 0, then assume it means non-zero code.

Update the `test::cmd::expect_exit_code_run_grep()` method with the "failure" marker, not an expected code.  Same failure marker technique should be used for the grep return code.


This is probably a bad title as these aren't actually VarArgs. - I just named this 'va2' becase it acts the same way as va is likely to act with 2 args


Yes. Lack of review in upstream. :(


we shouldn't encourage external people to create things in the HH namespace.


I opened [ERL-43](http://bugs.erlang.org/browse/ERL-43) for this.


> These functions are another great addition to a junit-util.sh file that can be shared.

We'll argue that in a separate pull.  I want this stripped down enough to merge and start using in `test-cmd`


I like the previous better. More likely this will fail faster if started from end (accounts for sorted sparse arrays).


DEPEND="|| ( app-misc/foo app-misc/bar )"
To depend on either foo or bar:  dev-python/PythonQt


Cuidado com a indentação.


If you make a mistake in your `grep` syntax and it's quietly eaten and you have to go into this file and explicitly print out the output and exit code, that would be a huge pain. A smarter display decision can be made, but I disagree that it should always be hidden.


@niltonvasques n sei s vc notou isso aki, mas comentei os glyphs aki pra achas eles mais rapido quando quisesse


@borshop merge


Gut


in the function replace foods with array, as you are passing into the function foods as array.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4388](https://teamcity.mesosphere.io/viewLog.html?buildId=72036&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:02


> If you make a mistake in your grep syntax and it's quietly eaten and you have to go into this file and explicitly print out the output and exit code, that would be a huge pain. A smarter display decision can be made, but I disagree that it should always be hidden.

Since you have the text of the command, its trivial to pull the output into a file and play with the grep locally.


So this be dependent on whether the feature flag is enabled?


In the case where the update is only over a particular ID then only the document with that ID can be effected by the change. So if the update is an "onlyIDQuery" we only need to clone the doc if it has the ID being updated.


in the function replace animals with array, as you are passing into the function animals as array.


i dont know what i did. i just tried to sync the master to get the files


106994938-FixFrontSideSolarReflectance (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (1913 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-97.55%25-yellow.svg)


in the function replace actionHeroes with array, as you are passing into the function actionHeroes as array.


@maengkom this has been fixed in v2.1.9


Wouldn't it be best just to declare the class as:
class ThreadPool final {...};


:trophy:


The thing is, the method exists. It's `expect_code(_and_text)`. One of the reasons we are re-writing these helper methods in the first place is that there were issues with exit code shadowing. Given the fact that we do not *ever* exit with a non-zero code other than 1 inside of Origin, I still think this is better. `expect_failure` is a convenience method - use it if it applies, but if it does not, use a different method and supply the code.


Creating


array.length = array.length - 1


Thanks for removing this!


same with trees


hey, you used the array parameter here!


This leaves browser windows open. Is there a way to close them when all the tests have finished?


This is a management command that will be called by new users installing orchestra, so they certainly can't be expected to know where workflows like the journalism_workflow store their loading scripts.

I suppose we could add the info to the `WorkflowVersion` manifest, as in:

    "sample_data_load_function": {
        "module": "myworkflow.load_sample_data",
        "name": "load"
    }

Is that what you had in mind?


Good call.


TeamCity LabkeyRelease15.3 :: Git postgres 9.4 [Build 31](https://teamcity.labkey.org/viewLog.html?buildId=284126&buildTypeId=LabkeyRelease153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 41, passed: 243 Build time: 00:49:22
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

##### there are 31 more failed tests, see build details
```


TeamCity LabkeyTrunk :: Git sqlserver 2014 [Build 43](https://teamcity.labkey.org/viewLog.html?buildId=284140&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:37


As with the other, just stuck it inside a `Command` class.


snd_soc_update_bits(wm8994->codec, WM8994_ANTIPOP_2,


The functions work, but you are passing in an array parameter, but then working on the array created outside the functions. Also, I think the assignment wanted these all to be prototypes on the array class.

i.e  Array.prototype.myPop = function(array)

Then you'd just call Array.myPop(animals);


I think the default e-mail should be set as the default for the new textarea:

https://github.com/cyclestreets/cyclescape/blob/master/app/views/notifications/added_to_group.text.erb

At present it is not at all clear to group admins (a) What kind of thing should be put in this box; (b) Whether an e-mail gets sent if it's left empty; and (c) If they somehow realise that an e-mail does get sent, they have no way of knowing what it does contain.

The default would solve all these problems, as it's then self-explanatory.


:-1:  :-1:  :-1:  muita duplicação.

```cshtml
@model string
@{
  var imagePath = "Bronze.png";
  if (Model == "Ouro") {
    imagePath = "Gold.png";
  } else if (Model == "Prata") {
    imagePath = "Silver.png";
  }
  <img src="~/Content/Images/@imagePath" />
}
```


	if (wm8994->jackdet && wm8994->jack_cb) {
		snd_soc_update_bits(wm8994->codec, WM8994_ANTIPOP_2,
				    WM1811_JACKDET_MODE_MASK,
				    WM1811_JACKDET_MODE_AUDIO);
		msleep(2);
	}


error when using 1.4.1 for reference

```
rake aborted!
SyntaxError: /home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/tins-1.4.1/lib/tins/token.rb:20: syntax error, unexpected tLABEL, expecting ')'
    def initialize(bits: 128, length: nil, alphabet: ...
                        ^
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/tins-1.4.1/lib/tins/token.rb:20: Can't assign to nil
...tialize(bits: 128, length: nil, alphabet: DEFAULT_ALPHABET, ...
...                               ^
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/tins-1.4.1/lib/tins/token.rb:20: dynamic constant assignment
...il, alphabet: DEFAULT_ALPHABET, random: SecureRandom)
...                               ^
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/tins-1.4.1/lib/tins/token.rb:36: syntax error, unexpected keyword_end, expecting $end
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/polyglot-0.3.5/lib/polyglot.rb:65:in `require'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/polyglot-0.3.5/lib/polyglot.rb:65:in `require'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.22/lib/active_support/dependencies.rb:251:in `block in require'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.22/lib/active_support/dependencies.rb:236:in `load_dependency'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/activesupport-3.2.22/lib/active_support/dependencies.rb:251:in `require'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/tins-1.4.1/lib/tins.rb:49:in `<module:Tins>'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/tins-1.4.1/lib/tins.rb:1:in `<top (required)>'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/bundler-1.10.6/lib/bundler/runtime.rb:76:in `require'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/bundler-1.10.6/lib/bundler/runtime.rb:76:in `block (2 levels) in require'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/bundler-1.10.6/lib/bundler/runtime.rb:72:in `each'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/bundler-1.10.6/lib/bundler/runtime.rb:72:in `block in require'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/bundler-1.10.6/lib/bundler/runtime.rb:61:in `each'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/bundler-1.10.6/lib/bundler/runtime.rb:61:in `require'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/gems/bundler-1.10.6/lib/bundler.rb:134:in `require'
/home/vagrant/foreman/config/application.rb:23:in `<top (required)>'
/home/vagrant/foreman/Rakefile:1:in `require'
/home/vagrant/foreman/Rakefile:1:in `<top (required)>'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/bin/ruby_executable_hooks:15:in `eval'
/home/vagrant/.rvm/gems/ruby-1.9.3-p448/bin/ruby_executable_hooks:15:in `<main>'
(See full trace by running task with --trace)
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4389](https://teamcity.mesosphere.io/viewLog.html?buildId=72042&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:58


Oh, I see now. I guess also link linsolve.


Hard to see it right now, probably locally on your machine ;)


The Meaning is in the "default" accessors I wrote first, the CategoryType is actually something different (maps to the SegmentedPropertyType rather than the SegmentedPropertyCategory that I think you're using here). Use these calls:
GetCategoryCodeFromLabel
GetCategorySchemeFromLabel
GetCategoryFromLabel


Omg yes I love you :D

that replace \n with \r\n was me testing replacing new lines with <br>, but it didn't seem to be working


:warning: :warning: :warning:

commit muito grande. Gera bastante impacto e fica difícil de revisar.


```sh
# ls -l /var/lib/docker/containers/eb2b5f7d5f5db47ba4496200eb7230e154b3e861e1e34ae86f5d299e48995ded/
total 28
-rw-r--r-- 1 root root 2034 Nov 10 20:16 config.json
-rw------- 1 root root 1216 Nov 10 20:16 eb2b5f7d5f5db47ba4496200eb7230e154b3e861e1e34ae86f5d299e48995ded-json.log
-rw-r--r-- 1 root root  651 Nov 10 20:16 hostconfig.json
-rw-r--r-- 1 root root   13 Nov 10 20:16 hostname
-rw-r--r-- 1 root root  921 Nov 10 20:16 hosts
-rw-r--r-- 1 root root  208 Nov 10 20:16 resolv.conf
-rw------- 1 root root   71 Nov 10 20:16 resolv.conf.hash
```
The containers directory contains files other than just the log files. So the current strategy should still work. May be the variable names are confusing.


@logolding Thanks. I think we should also make runInfo itself optional at this point. The only required property left is the command-line, and some tools don't have command lines (#3).


Is there a specific reason to change from (\cos(zq_z) + i \sin(zq_z)) to \exp(i z q_z) or is just make it shorter?
From the first form it is easier to see where the next and widely used equation comes from.
The latter would fit to one line though.


Ideally yes. The last time I tried that it was a time sink. Until that happens, this change will avoid overwhelming log files.


TeamCity LabkeyTrunk :: Git sqlserver 2014 [Build 44](https://teamcity.labkey.org/viewLog.html?buildId=284142&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:22


TeamCity LabkeyTrunk :: Git sqlserver 2014 [Build 44](https://teamcity.labkey.org/viewLog.html?buildId=284142&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:23


You should ask tyler if this modularity is worth it. You are attaching these functions on a global class, so it seems like you should just make the prototypes straight up (to me).


Maybe we should use `"imagemin": "~4.0.0"` to prevent things like #329 from happening again?


:warning: :warning: :warning:

Precisa melhorar. Pra isso define um `@model` para esta view e usa os HtmlHelpers. Ex:

```cshtml
<div class="form-group">
  @Html.LabelFor(m => m.Usuario, new { @class = "col-sm-2 control-label" })
  <div>
    @Html.TextBoxFor(m => m.Usuario, new { @class = "form-control" })
    @Html.ValidationMessageFor(m => m.Usuario)
  </div>
</div>
```


but it's good practice.


Tim,
     Your work on this has been impressive.


Isn't it bad practice to not handle self-assignment in operator=? If so, shouldn't we rather make sure we have a proper operator= implementation for the cases where this causes issues?


Ja, prima!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4392](https://teamcity.mesosphere.io/viewLog.html?buildId=72045&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:09


For supporting https, otherwise you end up always accessing http from https websites.


Do you mean the commit message?
I just copied the main commit message as this will get squashed when merging the PR.


@arthurian You might want to update to this commit sooner rather than later...it fixes some resizing/fullscreen bugs that popped up last time. It also stops using the Mirador fullscreen button and opts for one in the dashboard so that you can have both the dashboard **and** the target (since it works for both text and images).


Yup, I like this much better :+1: :tada:


sometime in the future, it would probably make sense to have an accessor that returns a (code,coding scheme designator,meaning) tuple instead


This is an interesting idea - I think we need to do something w/ the outdated foreverlive2015 content / link. By placing Valet in the "more" menu does it lose it's connection to the web app? Why not include the mobile apps in that menu as well? Just food for thought.


All of the sample workflows only have one version right now, so it's hard to see from the examples.

I was imagining a world where different versions of the workflow might need workers to have different certifications (e.g., if journalism v2 added a reviewer role for the editor, you'd need a user certified as a review-level editor, but you wouldn't need that user for v1).

Compelling enough, or should I remove it?


Didn't you merge it already? For me, it now sits on top of the other three commits as a separate commit, but with just the single change in the test.


> You mean they don't support 2013 anymore?

That's it.


@sks, thanks for the pull request.

Can you please provide test coverage for this feature? We'd like to document it for any future regressions.

Thanks!


This can and must use HTTPS.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4391](https://teamcity.mesosphere.io/viewLog.html?buildId=72044&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:43


Made the suggested schema changes


Forgot to put this in the commit message. Hence adding it as a comment.

1. Incrementing all file unit numbers by 1 for the fine mesh output.
2. Removed a function related to the villi
3. Functions that need to be worked on later. Not important for now.

   * Streamfunction_fine
   * MergeOutput_fine
   * MergeScalar_fine
   * MergeFields_fine
   * PrintPeriodicRestart_fine
   * PrintFinalRestart_fine
   * MergeMass_fine

4. The following functions are removed

   * PrintStatus_fine

5. Need to fix these functions before work can start

   * Compute_flux_fine
   * ScalarFlux_fine
   * PrintAbsRate_fine

6. Functions I'm not sure of
   * FixMass_fine


В данном случае вижу это маразмом. Го еще для каждой переменной свой класс создавать...
Предпочитаю разделение по смысловому признаку.


@hackdna It currently is not being updated based on permission changes. So far each cached object expires 10 mins from its creation, and only then would the permissions changes be picked up.


I like that you're building the relevant test around the same time you are building the actual tested functionality.


I didn't now where to write this, but I only wanted to thank you for finally adding this generate feature. And sorry for giving it up months ago…


@michaelcfanning Nick is right, and he's right to cite #3. Should we bit the bullet and do this now? Make `runInfo` optional, and make `commandLineArgs` optional within `runInfo`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4395](https://teamcity.mesosphere.io/viewLog.html?buildId=72049&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:11


I'm reverting this change for now. I don't want this discussion to block the other changes.


Let me try to defend this point a bit more -

The webpack case is a little bit of a degenerate example because it's just exporting an object.

If you take a look at how the Karma config is set up, there is a bit of logic in there with figuring out when to use the coverage reporter, when to publish to Coveralls, and when to use BrowserStack - we get a little bit of benefit from having access to ES6 syntax and from running basic linting rules on there, and it's annoying to have to jump back into ES5 mode just to tweak those.

I agree that standing on its own, just changing the webpack config here looks odd, but it's quite worthwhile for the Karma config, and it'd be weird to have one in ES6 and one in ES5.


The files other than the log file are trivial & ignorable IMO. Only log file is significant to care about.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.529.1fbd66f7ce1cebb6b9090f5cbaf4313e07dab98c](http://build.palaso.org/viewLog.html?buildId=65906&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 927, ignored: 54 Build time: 00:22:33


That isn't easy, I'll the placeholder show sensible text but not the exact text that we currently use. (e.g. you can't have new lines and the current text doesn't include the `{{full_name}}` but happy to add a placeholder.


Good question, I feel like based on the conversation around Forever Live 2016 today that this is only a temporary approach anyway.  I think one approach would be to have a 'download' page that has multiple types of downloads including the mobile app links, valet client, artisan & historian.  This page could link to the discreet pages for each.


Hmm. There's a whole lot of Item going on.. But I reckon I get your point.. Didn't even know that JLS supported something like this (expected conflict):

```java
public abstract class AbstractClassExposingItemC
    implements ItemProviderSomeItemA<ItemB>, ItemProviderSomeItemB<ItemC> {

}
```
Anyway.. It seems like the most specific version is selected. Should we play with compound generics somehow (or do we leave those for the time being)..


These seems to end up leaving out `AUTH_PASSWORD` from `.env`.


@srawlins FYI – I just ran docgen through the SDK with this update.

Some great fixes – but also a lot of breaks.

See the delta here: https://github.com/kevmoo/dartdoc/commit/42a7fa220df0dda7fb16886d68d550c284eecedd?diff=split


This works exactly as expected, but more generally _buttons.scss is getting pretty large and unwieldly. We should think about breaking out some separate modules and doing some refactoring soon. I'll create a separate issue for that.


For brevity, the content of the for loop could look something like this, eh?

if (map[letters[i]] === undefined)  map[letters[i]] = 0;
map[letters[i]] += 1;


Actually there's a `pontoon.settings.test` module where you can put settings for when the tests run rather than having to subclass everywhere.


great


The input is 1024 NUL bytes. There is a unit test that makes sure the `TarStream` method below creates a tar matching this digest.


Hopefully dart-lang/dartdoc#968 captures those breaks in the checklist.


should only be done if it's a $put or $post and $p.parts.isEmpty() and $p.fields.isEmpty() and (!$p.body)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4390](https://teamcity.mesosphere.io/viewLog.html?buildId=72043&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:12
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Do you want to also close the consumer in this case?


More precisely: "Decorated tasks are bound tasks, meaning their first argument is always their Task instance."


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.112.1fbd66f7ce1cebb6b9090f5cbaf4313e07dab98c](http://build.palaso.org/viewLog.html?buildId=65905&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 939, ignored: 50 Build time: 00:45:51


wrong comment


I don't think you needed to be so modular with the array functions. But it's good practice. I think the assignment wanted you to attach your new array functions to Array.prototype.


:+1:  Nice so i can using Forestry 3.6 too and update railcraft to 9.8

My compiled version works. Nice


sgtm - I'm a little busy this week so it may take a while to get this in -
I can revert this change and we can merge just the original PR if you
like...let me know.
-Dev

On Mon, Nov 9, 2015 at 12:50 PM, Randy Lai <notifications@github.com> wrote:

> it complicates the logic. Maybe, syntax/platform specific settings for
> prog are a better way to go? Perhaps, something like,
>
> {
>     "prog_user" : [
>         {
>             "plat" : ["osx", "linux"],
>             "scopes" : ["source.r"],
>             "prog" : "tmux"
>         },
>         {
>             "plat" : ["osx"],
>             "scopes" : ["source.r", "source.python"],
>             "prog" : "Jupyter"
>         }
>     ]
>
> }
>
> And add one more choice in the Choose Program list, -- [User Settings] to
> use the user customized settings.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/devjit/SendTextPlus/commit/58abf074c5cc6309259fe7bfed5fd8df0671a36f#commitcomment-14286754>
> .
>

--
*Devjit Chakravarti*
Data Scientist
310.944.0464 <+13109440464>
[image: Lyft] <http://www.lyft.com/>


Sphinx has a directive that I think we should use when documenting arguments called `param`:

```python
"""
Some function.

:param timeout: Timeout for the lock to be released in seconds.
"""


You can do a `remove_last_line` followed by `green "Success: ${cmd}". That would be far more readable and general purpose than what you've created here.


Dont worry, these things can happen with everyone lol :P


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4394](https://teamcity.mesosphere.io/viewLog.html?buildId=72047&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:32
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Will this work when install the package with `composer global require vinkla/climb`?


The inspect output does not include rotated files. The current
implementation will include old logs as well.

On Tue, Nov 10, 2015 at 1:19 PM, Jimmi Dyson <notifications@github.com>
wrote:

> The files other than the log file are trivial & ignorable IMO. Only log
> file is significant to care about.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/google/cadvisor/commit/ec449c47437b19463ded432fd8f7e0835b6bab1f#commitcomment-14314249>
> .
>


`wrapper` would be a clearer name than `_func`, which conveys nothing about what this function is and could be confused with `func`, the thing we're wrapping.


`self._element` should be here instead.


@micheleg hello, this commit breaks scrolling on the dock to switch workspaces. The shell freezes for 1-2 seconds before restarting. Trying to scroll again then crashes the whole gnome session.
Scrolling on the "Show Applications" icon works fine though.


How this was done doesn't make any sense to begin with. Would have been much easier to reason about if it'd simply been:
```js
function createServerHandle() { }
exports._createServerHandle = createServerHandle;
```


This is the lock name rather than the task name, but that's also a nit.


One thing to think about - we should try to avoid circular references with our `belongs_to` and `has_many` relationships in serializers. Fortunately this works, but sometime circular references will give us trouble. To avoid this, we will structure our serializers hierarchically and only pass as much data as we need to each request (we'll thoroughly plan more of this later).


This line's a bit long.


@dbolkensteyn I did intend to continue with this PR but other important family issues have kept me away for some time. There was some strange issue with the "its" tests that I never got around to fix.


So I definitely think the downloads page is a great idea and we'll need it soon when we get artisan and historian integrated into the forever store. I think I would expect that to be more closely associated w/ the products mega menu, and as we've talked about refining that, adding downloads there could be something to consider.


This works and I'd even be fine with merging it, but could you just decorate the wrapped function instead of manually calling this here?


My APIGateway client is now throwing this... I checked the release notes.. no mentions


Also, it'd be nice if unrecognized arguments passed to the decorator were passed on to `shared_task` in case we need to pass more parameters to celery.


@christian-fei @MatteoPierro yes, we will but for now we have only one route...so i don't see a reason to add such indirection right now.


Thanks, @hulpke for investigating and fixing this! Since this is a bug, it's good to leave a trail, so I've created an issue at https://github.com/gap-system/gap/issues/347 which will be displayed as ready for the GAP 4.8.1 release.

Let me also suggest to write commit messages following http://chris.beams.io/posts/git-commit/#seven-rules, especially if you're committing directly to the master branch without reviewed PRs. If you use very long 1st line of the commit, it will be split into two parts as you can see above, and many tools will truncate the rest of the commit if compact output is requested.


add your favorite color


According to http://stackoverflow.com/a/27993704/4358412 a multipart-form request must end with a final new line, after the boundary.


This link does not end up as a link on the PlayStore, in neither languages, just plain text.


Hmm, this is actually from a different PR. But we don't need to close it here because it should be handled in a different thread. This method runs in the sink task's dedicated thread. Some of the lifecycle is managed via the main driver thread for the process. That thread will trigger the stop and once the work thread has exited, it ensures close() is called.


This is the last commit prior to v2.0 development.


good point, will do!


Perhaps this should be in an `else` block, it would skip the functionality in some cases (tiny performance boost) and in cases where the data is weird, it wouldn't overwrite the location lat/long with the root lat/long.


nice way to use forEach


<b> THANKS! </b>


Say thanks to Eric


You could enforce some of the non-null constraints at the database layer as well if you wanted (such as title and content).


@Schpidi No surprise it breaks it when the `filename` attribute was introduced in the pull request which has not been merged with the master yet. But you already set the master's submodule reference to autotest which test this feature.

Please note, that the issue is not the content disposition test but the test WPS process which requires  the `filename` attribute in order to test it.

The problem will be solved when you merge the pull-request, I suggest you first merge the eoxserver code and then update  the autotest submodule reference next time.

The endless recursion  is another issue which needs to be fixed (ticket?) but it is a consequence rather then the cause in this case.


I've changed line indentations in my editor so it seems there's more changes to this file than I actually made. Sorry about that.


Is it acceptable that incorrect information could be returned by the API for up to 10 minutes?


Good catch.  Thanks!

Have you guys tested this in a wrapper cookbook of some kind?  If you have any Kitchen CI setup you can contribute back for Ubuntu or Debian, that would be great!


breaking out this function was a great idea


It's OK to use native handles for now. Active window is always top level, so we should miss nothing.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4396](https://teamcity.mesosphere.io/viewLog.html?buildId=72052&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:05
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Ok.. So should we use these methods in type factory in the future iso calling directly `getReturnType, getParameters, getThrownType` on the `ExecutableElement`?, So having those in the context of containing types?


good point, I'll get that added


Interestingly, some cache backends interpret a 0 timeout as meaning to cache indefinitely rather than as an instant timeout. It's weird. I do agree that we want to test this though...

I can't think of an alternative beyond mocking the cache API and checking the passed timeout. Hmmm. :\


What do you think of?

```elixir
client
|> Toolbox.PackageSync.FetchUpdates.fetch
|> Toolbox.PackageSync.StoreUpdates.store
```


Just noticed the test name for spec/parser_spec.rb line 619 should probably be 'should not parse...'


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4397](https://teamcity.mesosphere.io/viewLog.html?buildId=72055&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:04
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


I agree that removing the iptables resources is a good idea.  Single responsibility.

But I think a blurb in the README.md detailing Ambari prerequisites might be a good idea.  Or perhaps a link to a example wrapper cookbook that does so.


I don't understand this comment. Does it even apply?


This isn't necessary because of that parent class you used, and will still be unnecessary when you modify the test settings instead of using the parent class.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.530.1fbd66f7ce1cebb6b9090f5cbaf4313e07dab98c](http://build.palaso.org/viewLog.html?buildId=65915&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 927, ignored: 54 Build time: 00:23:02


TeamCity ReOpenLDAP :: next [Build 122](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1132&buildTypeId=ReOpenLDAP_Next&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:32:15


`find_best_control_matches` works with already wrapped controls. So what is the problem with wrapped controls? It's absolutely necessary because `findbestmatch` can use `Texts()` method that returns a list of item texts for ListView or TabControl or something like that.

Native wrappers are still useful. We are going to keep them working as a mandatory thing.


Please merge all Pull-requests :smile:


I'm not sure why your editor is using 4space indents, but you should change that to 2space indents before the next assignment submission (don't worry for this one). Otherwise, it looks good.


added a second paragreaph.


added a second paragraph


Should probably remove the commented out final or implement it.


`not fixed yet` is not a descriptive or actionable warning.

`This database is not supported yet` would be more accurate.  But honestly, I'd rather not accept an invalid parameter and then throw an error at run time.

We're only supporting mysql for now?  Why don't we only add that as a parameter and throw an `#{parameter} is not a supported database option` as an "else" for everything other than the default (postgres) or mysql.


Done


static_asserts are new with c++11 and a compile time thing only. They can only take a  constexpr bool (whose value is known at compile time), and produce a compilation error if false.(Try commenting out one of the lines in that array and compile. The compile will fail.)
      From: Jim Morris <notifications@github.com>
 To: trayracing/Smoothieware <Smoothieware@noreply.github.com>
Cc: trayracing <daqray@yahoo.com>
 Sent: Tuesday, November 10, 2015 2:20 PM
 Subject: Re: [Smoothieware] Robot config changes per code review - removed default robot actuator pins, etc. (da21d3a)

I'm not entirely sure static_asserts will work in smoothie, we do not have exceptions turned on. I'll need to research that.—
Reply to this email directly or view it on GitHub.


@rmcmx


Are we sure openssl no longer needs to be upgraded?

I'm not sure what the original need for this was.  Would be great if we had some test coverage on that.


so, this variable is semi-final. it should only be set/modified when the fragment is being created in onCreate. I've tried to come up with a way to represent that so that it doesn't accidentally get modified later on. the best I could come up with is the commented `final` keyword


oh cool


Extract to variable?


It sounds strange use a weapon without proper speed, but anyway thats ok, I never noticed this no-speed trick :P
But since this formula is sphere custom (it's not the real OSI pre-AOS formula), maybe we can add this other official pre-AOS formula as optional


I'm definitely open to suggestions of ways to signify this


"Do not be dependent on static class variables" - Grant "Quid" Titus


ModifyTimeBinsToUseRounding (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1430 of 1430 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.49%25-green.svg)


this does not fix the problem


Add your favorite color here!


BTW, the explanation text is not shown in the Device Admin settings screen if you want to enable/disable manually, **_only_** when your app opens the _add device admin_ dialog (eg. if device admin is off for NetGuard and you enable Verify ) you get the little text ( https://i.imgur.com/cY7tk5h.png ).

Android limitation I guess.


ModifyTimeBinsToUseRounding (Myoldmopar) - Win64-Windows-7-VisualStudio-12: OK (1966 of 1966 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Want to commit these I have changed them


Better, thanks!


I think I would prefer a small description like what you had here in the comment next to the variable. Then it's clearly a developer saying the intention vs maybe the developer forgot to delete something or forgot to implement something.


I get the general idea of these methods,  but I think they are not easy to understand. Would it be a good idea to (at one moment) to add some (class/interface) diagrams in a doc somewhere how this works and refer to those from the java doc?


We could also use temporary instead of tmp but I think those are abbreviations common in web dev. Plus its the file ending used for templates.


Yeah, you're totally right. I just optimized the code and only applied caching where it really is needed and now it actually performs better than before ;-)


yeah, this only has any affect on what ads are served if we're sending the DNT header to adzerk.


Hey @bcoca, thanks for looking into this so quickly.

To maintain backwards compatibility, I think we have to default replace_dash_in_groups to False.

Right now it's set to True:
https://github.com/ansible/ansible/blob/b2a9111b22dcd9662c0ae1537913a810e70b5c5c/contrib/inventory/ec2.py#L334


yes :)


@garonsky Please review this change that makes sure we don't call LDAP for scopes that don't contain an "ou". Note we are assured that "ou=" is specified in lowercase after it is read in from config file


It's not *that* annoying. What's annoying to me is to have two files for karma config and 3 extensions on the same file.

I'm going to revert here and in the router. Please don't change stuff like this w/out asking me first. Thanks :)


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 781](https://teamcity.labkey.org/viewLog.html?buildId=284144&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 56 (9 new), passed: 233 Build time: 00:45:46
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.core.admin.test.SchemaXMLTestCase: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testImmuneSpaceStudySubset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudySummaryWindow: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCards: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testNavigationDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testBackDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCardStudyLinks: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testFinderWebPartAndActionShareFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testRefreshDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

##### there are 46 more failed tests, see build details
```


Maybe something like:

````
// These variables should only be modified through onCreate
@NonNull
private String mGuid = INVALID_GUID;
@NonNull
private String mMinistryId = Ministry.INVALID_ID;


that's forward-thinking and totally makes sense :)


TeamCity LabkeyRelease15.3 :: Git sqlserver 2014 [Build 30](https://teamcity.labkey.org/viewLog.html?buildId=284163&buildTypeId=LabkeyRelease153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:33


You could use back-ticks instead.


Okay, I guess that makes sense - I'm getting lost in the naming conventions
though - why in the DICOM object do we have tuples of (code value, coding
schema designator, code meaning) for property category but the color logic
API uses (category type code, category scheme, and category)?  It would be
simpler (at least for me) if we could stick to the DICOM terminology.

Also I'm not seeing how to populate now that I look I'm not seeing how to
populate SegmentedPropertyType given the current API...?  Currently I hard
code "C94970,NCIt,Reference Region" but I think this should vary
per-segment based on the labelIndex.

On Tue, Nov 10, 2015 at 4:14 PM, Andrey Fedorov <notifications@github.com>
wrote:

> sometime in the future, it would probably make sense to have an accessor
> that returns a (code,coding scheme designator,meaning) tuple instead
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pieper/Reporting/commit/3630a022485036aac555cb61958477dbf7dd9560#commitcomment-14314132>
> .
>


this fork is not supported by anyone


I assumed the assignment was looking to implement without using methods like Array.sort().


I'd like some more comments about how any why things ended up the way they did. Otherwise, approved!


Looks good.


We use [dasherized names](https://github.com/sasstools/sass-lint/blob/develop/lib/rules/variable-name-format.js#L9-L11) for options, not camelCase. Please update for all instances.


I would prefer clearer attribute names.  I think this could all be a hash as well.

```
default['ambari']['database']['type'] = 'postgres'
default['ambari']['database']['host'] = 'localhost'
default['ambari']['database']['name'] = 'ambari'
default['ambari']['database']['username'] = 'ambari'
default['ambari']['database']['password'] = 'bigdata'
```

And I would suggest setting the `jdbc-driver` attribute in a hash of supported databases and their corresponding jdbc-drivers.


:tada:


It looks using an argument instead of STD-In.
Was the rule changed?

And I wander why you added this without noticing to me.


ModifyTimeBinsToUseRounding (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1966 of 1966 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@michael  Just saw that u pushed this commit after this branch was merged.
You could cherry-pick this commit into master.


```python
     # TODO: enum_elements() returns UIAElementInfo's from handles from enum_windows()
     # TODO: enum_windows() returns 100+ handles
     # TODO: what is enum_windows() supposed to return? all top-level controls from all windows?
```
`enum_windows` should return all top level windows. Probably for performance reasons we need to get desktop children using UIA. It really returns fewer number of elements (only visible and thus useful).

```python
import win32gui
root = pywinauto.UIAElementInfo.UIAElementInfo(win32gui.GetDesktopWindow())
len(root.children()) # returned 9 elements

for win in root.children():
    win.windowText
# currently returned:
''
''
''
''
'MainWindow'
'pywinauto-UIA'
''
''
''
```
That's strange why many texts are empty. Class names are OK. `FrameworkId == "Win32"` for most of them.


@davidheyman I just that noticed the zoom buttons are underneath the details panel in the web version of this. Can we get this fix pushed to the live site somehow?


@hackdna No I don't believe it is! I think adding an `updated` field to the `DataSet` model and clearing/recreating the cached object if a DataSet has been recently updated would alleviate this issue.... unless you have a better suggestion? Like you said throwing more code at a given problem isn't always best practice so I'm open for suggestions.


I'm not sure if I like this setting name, but can't think of one better ATM. @bgriffith @DanPurdy thoughts?


Ah yeah. Noticed that _globals.scss was missing. However i will integrate manually. Thanks for pointing out.


Messages should start with capitals.


failed to load :(


niiiice!! :+1:


typo: `colelctions`


So a release is not stable? I think a better name would be "isMilestone()"


Where is the header declaration???


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 782](https://teamcity.labkey.org/viewLog.html?buildId=284146&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 48, passed: 241 Build time: 00:47:33
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.core.admin.test.SchemaXMLTestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

##### there are 38 more failed tests, see build details
```


TeamCity LabkeyTrunk :: Git postgres 9.4 [Build 782](https://teamcity.labkey.org/viewLog.html?buildId=284146&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 48, passed: 241 Build time: 00:47:34
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.core.admin.test.SchemaXMLTestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyScatterPlotColorAxis: <no details avaliable>

##### there are 38 more failed tests, see build details
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4398](https://teamcity.mesosphere.io/viewLog.html?buildId=72060&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:10
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


wow


Should we remove GOMAXPROCS=1?


@bgoodri This is a problem even when using `\dontrun`?


Do you see this run fail?


I'm not sure if it's a good idea yet, but I usually go one step further.

```elixir
def run
  client
  |> fetch_updates
  |> store_updates
end

defp fetch_updates(client), do: Toolbox.PackageSync.FetchUpdates.fetch(client)
defp store_updates(data),   do: Toolbox.PackageSync.FetchUpdates.store(data)
```


Yes and cache coherency is a hard problem, so I'd simply try using a Python dictionary of permissions instead of memcached and see if that provides sufficient performance.


No.


@richardkchapman Please merge/close


@scalp42 yep, done!


Is this able to be patched into a 1.9.x installation? I desperately need the ability to provision from VMware template into a selected VMware cluster.


I think a comment will definitely help convey the intention and I'm going to add that in now. There needs to be a way to distinguish which set of properties that the comment applies to, either through leaving the commented `/* final */` or a pair of `// START` `// END` comments.

```
    // these properties should be treated as final and only set/modified in onCreate()
    @NonNull
    private /* final */ String mGuid = INVALID_GUID;
    @NonNull
    private /* final */ String mMinistryId = Ministry.INVALID_ID;
```
or
```
    // START: these properties should be treated as final and only set/modified in onCreate()
    @NonNull
    private String mGuid = INVALID_GUID;
    @NonNull
    private String mMinistryId = Ministry.INVALID_ID;
    // END
```


That's because I didn't publish these versions to public nuget yet :)

Thanks for pointing to Diagnsotics, you are the first who noticed :+1:


couldn't this buffer overflow the _md5 var?


These timeouts used to be 100ms, but the tests started failing on the CI server so I bumped it to 1000.

250ms might be OK, but I'd feel better if it was left at 1000ms. As much as I hate long-running unit tests, I hate sporadically failing tests more.


Input lab 9 per lab manual.  Has errors with addTen function not being declared properly


failed to load module :(


I was unable to confirm that my changes worked correctly, which is why I haven't made a pull request. I primarily use Atom on a Mac, where the Insert key itself is not supported.


good question: at one point it was possible to change the write permissions, however before launch we did a thorough review of the security boundary around algorithms and determined that we couldn't let those permissions be changed ... so the boxes got disabled (which keeps the same style as the editable boxes) and hasn't been changed since


cool! :)


I think the conventional way is to use config for this.

Access it like this:

```elixir
defp client, do: Application.get_env(:toolbox, :hex_client)
```

Configure default like: <https://github.com/joakimk/docker_services/blob/master/mix.exs#L24>

Configure test like: <https://github.com/joakimk/docker_services/blob/master/config/config.exs#L8>

Has the neat sideeffect of software using libraries being able to switch out subcomponents of them, like I've done with `:retry_strategy` in toniq.


I'd be fine with either of those personally.


Was the removal of coverage tracking intentional?


This is for coverage, so not sure the effect of removing.
That being said, we maybe should have on the line above:
go test -v -race ./...
*and*
GOMAXPROCS=1 go test -v -race ./...
since the behavior may be different when forced to 1 proc (scheduling wise, etc...). That may help us catch some type of issues?


this is currently disabled on purpose since I wasn't able to get capture new image support working yet.


Not necessary.


Please make the field private.


Yeah, if someone runs the example with dontrun = TRUE it changes the
mc.cores thereafter.  We could reset to what it was before the example.
On Nov 10, 2015 5:01 PM, "Jonah Gabry" <notifications@github.com> wrote:

> @bgoodri <https://github.com/bgoodri> This is a problem even when using
> \dontrun?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stan-dev/rstanarm/commit/49ae1d0a65c44853e400e9fdf86f634bcbda7b3c#commitcomment-14315161>
> .
>


we could make this a bit more stateless (re-entering the above block in case of auth never arrived the previous time) by including a header at the stat of the packet saying if it's initial request or auth.


This `src` starts well with `/assets/images` but after that you should only put the local name of the image (`taxi-driver.jpg`)


Nope.

On Tue, Nov 10, 2015 at 5:05 PM Jimmy Jia <notifications@github.com> wrote:

> Was the removal of coverage tracking intentional?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rackt/history/commit/b3e985a091906f808a79ac05a856d39ca9dd0b72#commitcomment-14315242>
> .
>


`myMap("key")` does the same thing as `myMap.get("key").get`


Fixes #16.


93653546B-FuelGenShowingInABUPSwhenPV (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


It might be better to remove the hacking all at once. Can we use environmental variable of some sort to detect the caching path? Something that is equivalent to `~/.typingCache`


These types are situated in 'java.lang' that is always visible;
thus that's not critical - although you're principally right ;-)


Why the different casts? Not following that..


`ns.sourcer` no longer has a default value so is this still safe to do without explicitly checking if it is None?


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.531.91965b1ddadc6de2bac54a84c447ed03d31bea58](http://build.palaso.org/viewLog.html?buildId=65924&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 927, ignored: 54 Build time: 00:18:10


easier for the user!, nice too! ;)


no, currently it is hardcoded to remove the -, which is what some people wanted to reverse, i just made it configurable and tried to keep the current setting (even though i messed up the conditional)


Thanks. If the same error happens in node 5.0.0, is there a workaround? I'm still a bit confused about the problem.


testN :=22 by default will be int..


Okay I don't have time to resolve this right now but are you okay with un-reverting that reversion? I don't care _that_ much about ES5 v ES6 but I do care about having coverage running here, and I do care about all the debug traces from Karma on React-Router now show all the coverage instrumentation and be unreadable.


We not need the kick on this channel?


I think we should not hold the lock when kicking the flusher. Since there is a lock internal associated with the fch, this is two locks correct?


`normalizePath` may be better


Yes,

user collections has `read permissions` that the user can change

everything else has system-defined permissions:
* .session -> read/write only from within that session
* .algo -> read/write from internal, guaranteed to exist for any algorithm

,.. just re-read the code on .algo data auth and there is a bug in there - algorithms are supposed to only be able to write to their own .algo collections and read from any .algo collection ... but the code allows writing to any .algo collection :/


We can see cutrent virtualenv from 'pyenv version' now. Basically I'd like to treat virtualenvs as an ordinary version as much as possible.


Fix tabbing here as well


I hear you; its taken about 100 re-runs to get my 10 open PRs through... :tired_face:


Thanks for fast merging! I am unsure, whether readonly dropdowns should get treated like disabled ones. If it is not possible to show up the options, it is not readable at all. Maybe it is worth thinking about a state, that allows showing the options without allowing to change the selection.


why only two hex bytes?, hostname is cheap, let's add them all and avoid collisions.


93653546B-FuelGenShowingInABUPSwhenPV (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1963 of 1966 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg)


@bonsaiviking Thanks for merging! Opened https://github.com/nmap/nmap/pull/231 to fix my name.


Challenge 2:11 is working ok on Atom, passes all tests, on Rake does not pass only one test when beers > 99 saying that I should not cap it to 99.
Challenge 2:12 is passing all tests


This captures wrong s1 since we will manually shut this down in the test. It closes over the current s1, which will mean the new s1 will not be shutdown I believe.


The reason there's a `karma.conf.babel.js` in the first place is because this sort of code: https://github.com/rackt/react-router/blob/v1.0.0/karma.conf.babel.js#L117-L136 is a lot clearer with ES6 syntax.

Obviously you can write this with ES5 but the ES6 version is IMO just clearer and easier to understand.


May be I'd increase that timeout, a packet loss with TCP could trip for a few seconds.


Don't we want to fail the test?


Was trying to be explicit, since the subscriber expect this type. There is two test, one with int and one with int32, yet, they both have testN := 22. Anyway, will remove.


It turns out that the changes to `StartApp` aren't actually required -- see

https://github.com/rgrempel/elm-route-hash/commit/887b03300899600cdebab83522582a7246029d20

for the alternative approach with an unmodified start-app.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.113.91965b1ddadc6de2bac54a84c447ed03d31bea58](http://build.palaso.org/viewLog.html?buildId=65923&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 939, ignored: 50 Build time: 00:36:10


Ok, will remove.


Go has waitGroups that implement barrier functionality.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4393](https://teamcity.mesosphere.io/viewLog.html?buildId=72046&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:03


I see. It's no big deal, I just like when examples are written how someone
should actually run them, e.g. setting cores once instead of in every call
to stan_*.

On Tuesday, November 10, 2015, bgoodri <notifications@github.com> wrote:

> Yeah, if someone runs the example with dontrun = TRUE it changes the
> mc.cores thereafter. We could reset to what it was before the example.
> On Nov 10, 2015 5:01 PM, "Jonah Gabry" <notifications@github.com
> <javascript:_e(%7B%7D,'cvml','notifications@github.com');>> wrote:
>
> > @bgoodri <https://github.com/bgoodri> This is a problem even when using
> > \dontrun?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/stan-dev/rstanarm/commit/49ae1d0a65c44853e400e9fdf86f634bcbda7b3c#commitcomment-14315161
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/stan-dev/rstanarm/commit/49ae1d0a65c44853e400e9fdf86f634bcbda7b3c#commitcomment-14315258>
> .
>


There was 2 ch <- true in that callback, one is enough ;-)


We shut this down manually, this not needed.


Is this necessary? Sometimes, a link can be a chain of different shorten links. People do that on purpose.


Thanks! BitHub has sent payment of  $40.92USD for this commit.


Solo por curiosidad.. ¿Porque cambiaste el GTK_RESPONSE_APPLY por GTK_RESPONSE_HELP?
Si no tiene razón de ser, te das cuentas que estas introduciendo mas cambios de los necesarios?.

No es mayor problema, pero fijate que para revisar un commit que debería ser simple, hay pequeños cambios innecesarios que te obligan a pensar porque hiciste tal o cual cosa, distrayéndote del objeto original del parche, que en este caso debería ser CSD.


I beg to differ. kickFlusher() is then manipulating nc.bw that can't be done without nc.mu lock:

==================
WARNING: DATA RACE
Write by goroutine 115:
  github.com/nats-io/nats.(*Conn).doReconnect()
      /Users/ivan/dev/go/src/github.com/nats-io/nats/nats.go:805 +0x206

Previous read by goroutine 197:
  github.com/nats-io/nats.(*Conn).kickFlusher()
      /Users/ivan/dev/go/src/github.com/nats-io/nats/nats.go:1197 +0x3a
  github.com/nats-io/nats.(*Conn).close()
      /Users/ivan/dev/go/src/github.com/nats-io/nats/nats.go:1695 +0x12e
  github.com/nats-io/nats.(*Conn).Close()
      /Users/ivan/dev/go/src/github.com/nats-io/nats/nats.go:1747 +0x3c
  github.com/nats-io/nats/test.TestPingReconnect()
      /Users/ivan/dev/go/src/github.com/nats-io/nats/test/cluster_test.go:455 +0x7ef
  testing.tRunner()
      /private/var/folders/q8/bf_4b1ts2zj0l7b0p1dv36lr0000gp/T/workdir/go/src/testing/testing.go:456 +0xdc

Goroutine 115 (running) created at:
  github.com/nats-io/nats.(*Conn).processOpErr()
      /Users/ivan/dev/go/src/github.com/nats-io/nats/nats.go:931 +0x284
  github.com/nats-io/nats.(*Conn).readLoop()
      /Users/ivan/dev/go/src/github.com/nats-io/nats/nats.go:976 +0x3c5

Goroutine 197 (running) created at:
  testing.RunTests()
      /private/var/folders/q8/bf_4b1ts2zj0l7b0p1dv36lr0000gp/T/workdir/go/src/testing/testing.go:561 +0xaa3
  testing.(*M).Run()
      /private/var/folders/q8/bf_4b1ts2zj0l7b0p1dv36lr0000gp/T/workdir/go/src/testing/testing.go:494 +0xe4
  main.main()
      github.com/nats-io/nats/test/_test/_testmain.go:206 +0x20f
==================


Technically the `readonly` attribute isn't a valid select attribute (https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select) so my thinking was to treat it as `disabled` as an 'enhancement,' but maybe it should just be removed from the plugin?

I should probably post these thoughts before just pulling the trigger :)


hmm, while correct, defers should be closed and close to where the object is created IMO. This is confusing.


I'm getting an error when I try to import:

```
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
<ipython-input-30-4f8d7962da52> in <module>()
----> 1 import ensure

/home/vagrant/venv/lib/python3.4/site-packages/ensure/__init__.py in <module>()
      9 from collections import namedtuple, Mapping, Iterable
     10
---> 11 from ._types import NumericString, NumericByteString, IntegerString, IntegerByteString
     12
     13 USING_PYTHON2 = True if sys.version_info < (3, 0) else False

/home/vagrant/venv/lib/python3.4/site-packages/ensure/_types.py in <module>()
      3 import sys
      4
----> 5 from six import add_metaclass
      6
      7 USING_PYTHON2 = True if sys.version_info < (3, 0) else False

ImportError: cannot import name 'add_metaclass'```


Code Review complete. All looks good.

Some package changes will need to be added in the submit branch that has the latest KualiCo code:
Class: kfs-core/src/main/java/org/kuali/kfs/fp/businessobject/options/EncumbranceUpdateCodeValuesFinder.java
Line 7: replace import org.kuali.rice.krad.keyvalues.KeyValuesBase; with import org.kuali.kfs.krad.keyvalues.KeyValuesBase;


Ha, thought that was already included. Sorry for the noise.


Ah flip. I did squash it but for some reason merged the wrong branch.


Awesome work, some comments, but WOW! :)

This is real collaborative work! :)


Why can't this check be done in the Binder? Do we not know there whether the column is one of the sample columns?


mmoll/foreman@731c3da but no idea if this was cherry-picked correctly and working Foreman and fog wise with the versions coming with 1.9.


s / proxyInstance / interopLayerInstance


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4399](https://teamcity.mesosphere.io/viewLog.html?buildId=72071&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:07
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


can/should `kerberos` now be installed as a dependency of `node-mongodb-native`?


Temporary fix was to create a symbolic link in `/usr/local/bin` for python2:

```
sudo ln -s ../../../System/Library/Frameworks/Python.framework/Versions/2.7/bin/python2.7 python2
```
It now compiles.


OK, so just pretend that this was squashed - it will be pretty obvious in the changelog.
Sorry about that.


Relaying one more comment from boris: can we also move the v4 version of the layer to jitsi? would potentially make the migration easier.


refs #29


I thought that was just for the array prototypes.  I'll go back and fix the
freq and unique.

On Tue, Nov 10, 2015 at 1:55 PM, Paul Laskowski <notifications@github.com>
wrote:

> I assumed the assignment was looking to implement without using methods
> like Array.sort().
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mskalandunas/data-structures-and-algorithms-i/commit/3e5e59025b533b96230c4dce43be44d279e2a792#commitcomment-14315038>
> .
>

--
Mike Skalandunas
203.548.1521
www.mikeskalandunas.com
*Composer & Audio Designer for Video Games*


TeamCity LabkeyRelease15.3 :: Git sqlserver 2014 [Build 31](https://teamcity.labkey.org/viewLog.html?buildId=284184&buildTypeId=LabkeyRelease153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:28


@whitequark @sbourdeauducq This is a problem. We can't run non-LTS Ubuntu here at NIST.


I'm mitigated about reusing `${maven.compiler.source}` variable here, meaning "we use the same target as the source"

I would keep the initial `1.7` hardcoded value here
But doesn't make a big deal, it is just a thought.


Beware, you rolled back your previous guava commit here ;-)


Beware, you bumped this version from 2.3.1 to 2.5.0 (if really needed, shouldn't this bump be part of #228 instead ?)


Then why add the -p1?


I totally agree and think it should get removed. Readonly select does not make any sense due to the problem described above. I just use this (invalid) option sometimes, but obviously I need to find another solution for displaying but not allowing to change larger enum sets.


For coverage I agree, does not matter..


You are right. It does say that.


tpl is far away from being as easy to understand as tmp is.

That's why my comment only mentioned templates and not tmp.
*templates* is the de facto standard name for the template folder across most frameworks imho.


Ah ok ;)


Is it intended to remove `javax.servlet api` from this module ?

Anyway, I'm wondering if it shouldn't be declared as a `provided` dependency here rather than `compile` dependency


ok, good point.


Like jetty module, I'm wondering if we shouldn't improve this and use `provided` scope for this dependency rather than `compile` one


An information about adding samples and sharing work:

* The filelists named *_sample_*_recent.txt are symlinks to the latest ones with the name *_sample_*_<date>.txt. They are created with `createInputFilelists.py -r` (https://github.com/artus-analysis/Artus/blob/master/Configuration/scripts/createInputFilelists.py#L32-L33)

* The filelists named *_collection_*_recent.txt are real files (no symlinks) but they contain (ideally) recent filelists (*_recent.txt). They are meant for collecting multiple samples into a collection of samples (e.g. all backgrounds for the SM Htt analysis). They should not need to be updated after existing samples have been updated by a new skim. Therefore they optimally point to/contain recent filelists (*_recent.txt).

* The recent filelists are the ones that are used for most of our studies as we mostly want to use the latest skim. Therefore there is no reason for not creating these symlinks together with the other filelists. An exception could be the case, where filelists are added, that are already known to be valid only for few days and a new skim is already running.

* Adding new samples requires at least four steps:

  1. Create the filelists
  2. Update/add the cross sections in https://github.com/cms-analysis/HiggsAnalysis-KITHiggsToTauTau/blob/master/data/ArtusConfigs/Includes/settingsCrossSection.json
  3. Update/add the numbers of generated events in https://github.com/cms-analysis/HiggsAnalysis-KITHiggsToTauTau/blob/master/data/ArtusConfigs/Includes/settingsNumberGeneratedEvents.json using the script https://github.com/artus-analysis/Artus/blob/master/KappaAnalysis/scripts/getNumberOfGeneratedEvents.py
  4. Update/add the generator weights (for NLO samples) in https://github.com/cms-analysis/HiggsAnalysis-KITHiggsToTauTau/blob/master/data/ArtusConfigs/Includes/settingsGeneratorWeight.json using the script https://github.com/artus-analysis/Artus/blob/master/KappaAnalysis/scripts/getGeneratorWeight.py

  It is desirable, if this is all done by one person and in one go in order to avoid mistakes when running Artus with wrong/old/missing settings. See https://github.com/cms-analysis/HiggsAnalysis-KITHiggsToTauTau/commit/06bca391fae0ec075334ed474b55b137bac0226b for a quick fix of this commit.


Like my comment before, I'm wondering if this `servlet-api` version bump is a good thing

It may imply code incompatibilities with servlet 2.5 containers which is not (presently at last) willed to my POV (see recent discussion on #220 about this topic)


:+1: Works great!


Can we please define these as constants?


How about if we add a comment in examples where we use cores=1? Maybe
something like

# Note: cores=1 is used for examples. For real usage, cores>1 is
recommended.

On Tue, Nov 10, 2015 at 5:14 PM, Jonah Sol Gabry <jgabry@gmail.com> wrote:

> I see. It's no big deal, I just like when examples are written how
> someone should actually run them, e.g. setting cores once instead of in
> every call to stan_*.
>
>
> On Tuesday, November 10, 2015, bgoodri <notifications@github.com> wrote:
>
>> Yeah, if someone runs the example with dontrun = TRUE it changes the
>> mc.cores thereafter. We could reset to what it was before the example.
>> On Nov 10, 2015 5:01 PM, "Jonah Gabry" <notifications@github.com> wrote:
>>
>> > @bgoodri <https://github.com/bgoodri> This is a problem even when using
>> > \dontrun?
>> >
>> > —
>> > Reply to this email directly or view it on GitHub
>> > <
>> https://github.com/stan-dev/rstanarm/commit/49ae1d0a65c44853e400e9fdf86f634bcbda7b3c#commitcomment-14315161
>> >
>> > .
>> >
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/stan-dev/rstanarm/commit/49ae1d0a65c44853e400e9fdf86f634bcbda7b3c#commitcomment-14315258>
>> .
>>
>


Espacios no!!!.
Maikel, por favor no cambies la interface.. (Mas alla de lo hablado de CSD jaja..).
En serio, si te fusiono este parche, revierto la mayoría de los cambios en el próximo commit y no es la idea.. :cry:


What do you mean?


There is no new s1, there is s1 and s2. Like I said in the commit message, using defer help us to protect against a failure between the start and the explicit shutdown. Following is what we had in some places:

```
s = startServer()
nc = opts.Connect()
err := nc.Publish(...)
if err != nil {
  t.Fatalf("Failed to publish!")
}
// explicit shutdown
s1.Shutdown()
// test continue here.
```
If for some reason we get an unexpected failure on publish, this would leave the server running, which may/will affect the other tests. Doing a defer s.Shutdown() will guarantee that if we fail unexpectedly before the explicit shutdown we are ok. The defer s.Shutdown() will be idempotent after the explicit shutdown.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4402](https://teamcity.mesosphere.io/viewLog.html?buildId=72077&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:07
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


@jwise Do you happen to get a return code of 0x1 when calling IOUSBDevice::open()? According to the comment it is an error that "should never be seen!" That is the issue I'm seeing writing a driver for samsung's ODIN mode right now.

    #define kIOReturnInvalid         iokit_common_err(0x1)   // should never be seen


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4403](https://teamcity.mesosphere.io/viewLog.html?buildId=72079&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:26
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Ah, so the hash I have above is for the empty string. Presumably, we got this value from tarsum.


Like I said on the commit, even locally I am getting failure sometimes because it took 1605 ms. There is nothing fundamentally wrong (that is, we still got the callback), but not as fast as we though we should get it. When multiple tests are running in a row, some connect() may be delayed, which is what is happening I believe.


No it will become a peer dependency as a tiny minority uses it and the problems caused by trying to install it confuses everyone who does not need it. Hopefully sometime soon (node 5.x and higher) it will be an application decision to use the library.


@jordens FIY I bumped the Ubuntu version solely because 14.04 does not have a builtin Python 3.5 package according to packages.ubuntu.com. Did you not try to upgrade ARTIQ since 3.5 migration and until now?

I'm sure it has a PPA though, so this shouldn't be an issue unless NIST policy also bans PPAs.


But if we fail we will t.Fatal which will cause the test to exit, correct? I can see both points of view, just a bit confusing to me, but as long as its idempotent, etc.


I am not sure how it works, but I believe if you drop just this last commit, everything should be green also in Travis.


Will use that instead. (I was getting a panic of close on closed channel without this change).


Excellent


See previous comment.


@fedorov I wanted to get the accessors to Steve quickly without taking a lot of time to dig into a python callable way to return a triple.

@pieper I'm following the naming conventions that were in the original Reporting code, I had to have them explained  a few different ways until I got the mapping between names as well. I set up the color logic to use slightly shorter accessor method names, apologies for the confusion. The color logic uses these names in an internal data structure (StandardTerm) that's used to specify each categorisation (names coming from the code in the Reporting module):
       std::string CodeValue;
       std::string CodeMeaning;
       std::string CodingSchemeDesignator;
A full terminology entry uses these names in another data structure, each being a StandardTerm with the tuple of value, meaning and scheme designator as above:
    StandardTerm AnatomicRegion;
     StandardTerm AnatomicRegionModifier;
     StandardTerm SegmentedPropertyCategory;
     StandardTerm SegmentedPropertyType;
     StandardTerm SegmentedPropertyTypeModifier;

For the logic accessor methods, I was translating SegmentedProperty as categories and using Category, Type, TypeModifier, then in each was just using the Meaning as the default string I needed to get from each for display.

To populate a term, there's one call with all the strings passed to it to create a new term. You can see how I use it here:
https://github.com/naucoin/Reporting/blob/52-Add-terminology-region-support/Py/DICOMSegmentationPlugin.py#L145-220


ok


Will change. Took that from other tests actually ;-)


This is a bc break ...


thats true, although we would still have to reconcile that with the in-app navigation versus the marketing site navigation.  I also think dramatic changes to the navbar are going to be increasingly difficult given the amount of markup copy/pasting going on.


@Schpidi There was the 1.8 Django issue which blocked the pull request. I updated the branch to the latest master and it seem to be all right again.


Yep


I checked in my changes to skinhelper, it is working much better better now. Also removed the cache on the widgets listing. Only the individual items are cached so in theory only the first call is slow, all further calls should be fast. Also it can now handle if any addon gets added by skinshortcuts..


I thought you meant with the change! Remember our emails last night? It is failing without that locally on my machine, and I think that it can't hurt on Travis.


Creo que 800 es un tamaño muy grande.. Tene en cuenta que el tamaño por defecto de la ventana de Pragha es 3/4 de la pantalla. En mi caso 1366*3/4=1024 o sea que el dialogo de busqueda es practicamente tan grande como el tamaño de la ventana principal..


hmm, not sure that was me.. git blame?


@pieper All that said, I could redo all the variable names and accessor method names to match the DICOM values, the names I picked were driven by top down display to the user decisions rather than developer use.


Is this just laying the groundwork to support new `source` capabilities? I ask because it's not clear how this patch on its own changes the behavior.


I squashed and re-pushed the commit, which has dropped the comments, sorry @nickpearson, et. al. :disappointed:


The latter.


ModifyTimeBinsToUseRounding (Myoldmopar) - i386-Windows-7-VisualStudio-12: OK (1966 of 1966 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


It's a generated function that the user has no access to.


That's whitespace cleanup :)


This could make for a good feature request. If the element is not in the DOM, modify it's contents and setup the api. There are several reasons we don't allow this. The main reason is several parts of the player - and Flash object tags specifically - do not function outside of the DOM.


Yeah, I think that's a good plan!


You are correct, I thought it was on another run. Yes I remember the -p1, sorry for confusion on my side.


Ha, no. I'll change it?


because before we called super.init


```c
sodium_bin2hex(hex, sizeof hex, data, size);
```


Your commit is dumb and you should feel bad


This test will be reported as failed, but I thought you mentioned yesterday that all tests of a package are running as go routines, so the failure of one does not prevent the other tests to run. And since the server is embedded, it will stick around for the other tests. If I misunderstood what you said yesterday, I will remove those changes.


The size()+1 hint is intended to reduce resizing right? The load factor is 0.75, so right now this is guaranteed to resize once.


Great. I'll give it a test tomorrow and, assuming all works as expected (which I'm sure it will), look to get this code completed & committed :)


yeah :/


“orderLine” → “orderLines”.


Bueno.. Saca todo lo referido a los espacios, y te prometo una revisión de pragha-hig.c/.h  para hacer esto mejor. La idea de estas funciones, es estandarizar el trabajo, y no tener que editar los espacios y margenes de cada dialogo individualmente como estas haciendo. :disappointed:


Hmm, I think your right.. ;)


Ok I'll do some testing tomorrow. I assume I'll need to implement the changes in each of these files? I originally tried just adding "cluster" => [args[:cluster]] to VMware.rb under opts but that didn't work


delete


TeamCity LabkeyRelease15.3 :: Git postgres 9.4 [Build 32](https://teamcity.labkey.org/viewLog.html?buildId=284161&buildTypeId=LabkeyRelease153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 17, passed: 247 Build time: 00:55:55
### Failed tests
```
org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyParticipantCounts: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSearch: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSTest: <no details avaliable>

##### there are 7 more failed tests, see build details
```


Cool! @phstc


TeamCity pull requests :: netty [Build 635](https://garage.netty.io/teamcity/viewLog.html?buildId=3196&buildTypeId=pulls_netty&guest=1) is now running


Interesting that you are passing in an element and not going down this branch:

```
         } else if (query.nodeType) { // player will be undefined
             domElement = query;
             player = _playerById(domElement.id);
         }
         // found player
         if (player) {
             return player;
         }
         // create player
         if (domElement) {  // but we should be getting your element and returning an api instance
             return _addPlayer(new Api(domElement, _removePlayer));
         }
```

What you need to do though is add `this.player.getContainer()` to your page, not the element you passed to jwplayer().


What is a reflection... and why would you need one?


TeamCity pull requests :: netty [Build 635](https://garage.netty.io/teamcity/viewLog.html?buildId=3196&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:54


See: http://docs.spring.io/spring/docs/3.0.x/spring-framework-reference/html/mvc.html#mvc-ann-controller


Disculpa.. Prefiero el diseño anterior.. Pero es discutible.


Should this condition be negated?
eg:
`if (StringUtils.isBlank(filePath)){`

I'm getting `File path is empty` output when I specify a Build name file path	.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.532.5d63946f02e3ce9bb63522dd0492d588bd878d58](http://build.palaso.org/viewLog.html?buildId=65929&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 927, ignored: 54 Build time: 00:22:44


yes, please go to my commit, add `.diff` to the URL and you can use this with `patch`, also it's probably not good to discuss here as a lot of people are getting GH notifications from here...


Should this condition be negated?
eg:
if (StringUtils.isBlank(filePath)){

I'm getting File path is empty output when I specify a Build name file path


Devuelta.. Entiendo que se puede integrar mejor a gnome, pero prefiero el diseño anterior.. :S


No actually it's not, because i didn't found an handy way to use it...


Spoke with @Tridge and it doesn't make sense to reserve the ComponentID for "Dumb" components


Could you clarify the intended result of this change?


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.114.5d63946f02e3ce9bb63522dd0492d588bd878d58](http://build.palaso.org/viewLog.html?buildId=65927&buildTypeId=bt2) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 740, ignored: 44 Build time: 00:57:56


Hi
    After finding good neuron parameters, layer = nengo.networks.EnsembleArray(N, b.size, **neuron_params) will load this parameter (max_rate, intercept) to build neurons. However when I probe the ensemble neurons's parameters, it shows different gain, bias for each neurons. This is because  build.ensemble.py still use rng to form  max_rate and intercepts from the given good neuron parameter...
So my question is: are you trying to use the same gain, bias(best parameters) for all neurons (like Nengo1.4) or you want to shuffle the gain,bias from the best max_rate and intercept founded in finding_neurons.py? thanks


> Basically there's a local clear() and h.clear()

@mhinz Right, I missed that (we normally import directly into global namespace--not sure which is a better practice).


Dear Sanderi44,

First, thank you for your work. I was wondering how I can increase reading frequency like it is done for arduino in the link below because we do not have begin function in your python code. I just could not find a way to implement it. If you could help me I would appreciate.  https://github.com/PulsedLight3D/LIDARLite_v2_Arduino_Library/blob/master/LIDARLite/examples/Single%20Sensor/Distance_as_Fast_as_Possible/Distance_as_Fast_as_Possible.ino

Thanks,

Isa


**Make sense**.

```R
> fit.gene.k(zf,"SOX3",do.plot=TRUE,do.k = 3)
```

**Make sense** as well.
```R
> fit.gene.k(zf,"SOX3",do.plot=TRUE, start.pct=mean(zf@insitu.matrix[,"SOX3"]))
```

**Not making sense** but this code is allowed to run.

```R
> fit.gene.k(zf,"SOX3",do.plot=TRUE,do.k = 5,start.pct=mean(zf@insitu.matrix[,"SOX3"]))
```


So any opinion on adding it to the regular `go test -rave ./...` to see if tests fail with `GOMAXPROCS=1`? The drawback is that it will make Travis checks longer...


Yeah just verified - you will get an API instance in jw 7. Maybe you're using v6? There are still issues running `setup()` on a player whose container is not in the DOM. We don't support that for the reasons I've mentioned, but the issue you're pointing out is not an issue in jw 7.


En gtk 3.8 va a devolver un error que GtkDialog no tiene la propiedad "use-header-bar". Tenes que hacer que este cambio dependa de 3.12 también.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 4410](https://teamcity.mesosphere.io/viewLog.html?buildId=72099&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 199 Build time: 00:13:07
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Learning from the best ;-)


Glad y'all figured it out! One comment I've been meaning to make is that I would rename this method to better express what it returns. If a method returns a boolean, I believe the convention is to make it end with a question mark. Given that this method determines whether or not it's time to send a message, I would rename it to something like `time_to_send_message?(time_zone)`. And to answer that question consistently with either `true` or `false` (as opposed to `true` or `nil`), I would use a guard clause at the top to make it clear what the failing scenario is:

```ruby
def time_to_send_message?(time_zone)
  employee_current_time = Time.current.in_time_zone(time_zone)

  return false if employee_current_time.day != Time.current.day
  # or return false unless employee_current_time.day == Time.current.day

  employee_current_time_value = employee_current_time.strftime("%H%M").to_i
  message_time_value = message.time_of_day.strftime("%H%M").to_i

  employee_current_time_value >= message_time_value
end
```

This new new name would then make the expression at the top much more readable IMO:
```
time_to_send_message?(employee.time_zone) && message_not_already_sent?(employee)
```


You should close the write end of the stdout pipe immediately after the task is launched, in order for the system to properly discover when the pipe is closed. Otherwise, if the child dies, this current process still has the write FD of the pipe open, and select/poll will not signal that the write-end of the pipe is closed.


The PHP ReflectionClass class reports information about a class. I use this to get the directory path of the CPT module class so that I can auto-load it to the page templates. The bug was caused when I manually set the cpt to a string different than the class name so I had to make this small change. Shouldn't affect anyone who didn't know about it.

More information about that class can be found here: http://php.net/manual/en/class.reflectionclass.php


93653546B-FuelGenShowingInABUPSwhenPV (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (892 of 892 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.12%25-green.svg)


thanks


I think this should be `href=#observations-layer-list` and aria-controls='observations'.


Estas usando la gtk_dialog_new_with_buttons y despues le decis que agregue ningún botón???


where are these two file descriptors closed?


Install a python3.5 conda environment on Ubuntu 14.04 LTS using
$ conda create -n py35 python=3.5
It's what the penning lab has been using to test ARTIQ builds lately.

No need to change the Ubuntu version.


This would also have to change accordingly.


You should probably use the same argument phrasing as you did [here][1], to show that we're not adding any value besides convenience with `AzureDrop.drop` (the value-added is `AzureDrop.contact`).

[1]: https://github.com/azurestandard/azure-angular-providers/commit/112cf0542a9e672d88a91b2eb98c6d60c180dc1d#diff-04c6e90faac2675aa89e2176d2eec7d8R399


Seguramente aca agregaste un warning que la funcion pragha_track_properties_response no esta siendo utilizada.


I am not sure but it seems that you cannot use "brightness" as a function name and a variable. I get the error "TypeError: object not callable", which disappears if I change the variable name.


So here's an "experiment" of the way I see it.. how it could go
https://github.com/ts2/ts2-sim-server
Missing are
sockets and stuff...
[And will delete if u disagree...]

The reason I kinda want eg trains seperate.. is that I see the online "shared database".. as being one we can share train defs and rolling stock.. between projects..
eg some new data on bracking performance, lengths of train as one exaple..

also having signals seperate so these can be reused and shared...

Its kinda the problem FlightGear has got, ie noone really updating and keeping a reasonably true db of train performance etc..

Note I am kinda wanting to make some model rail run of ts2.. eventually when I retire... (;-))
and kinda playing with go in general for integration with hardware...
and golang is heaven for this..
https://github.com/freeflightsim/fg-piface


Why is this needed? If I use either "hide log" or "focus mode" I don't see any trace of the log
<img width="1920" alt="screen shot 2015-11-10 at 22 45 13" src="https://cloud.githubusercontent.com/assets/369/11078273/be69ee00-87fc-11e5-8cd7-d82d9416b8d2.png">


Code Review complete. All looks good.

Some package changes will need to be added in the submit branch that has the latest KualiCo code:
Class: kfs-core/src/main/java/org/kuali/kfs/fp/document/authorization/DistributionOfIncomeAndExpenseDocumentPresentationController.java
Line 33: replace import org.kuali.rice.krad.document.Document; with import org.kuali.kfs.krad.document.Document;
Line 34: replace import org.kuali.rice.krad.util.KRADConstants; with import org.kuali.kfs.krad.util.KRADConstants;


On line 258 `close(info->fd);` in `ReadOutputsAndFeedOuputLinesToBlockOnQueue`.


TeamCity LabkeyRelease15.3 :: Git sqlserver 2014 [Build 32](https://teamcity.labkey.org/viewLog.html?buildId=284206&buildTypeId=LabkeyRelease153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:26


why is this needed?


Todo bien que arregles tabs-vs-espacios pero solo en las funciones que realmente modificaste.. No lo hagas en commits que no tienen nada que ver.. A lo sumo podrias hacer en un commit aparte llamado "Fix tab vs spaces", pero aca no vale la pena..


You're right. Ken did that. I will cleanup the other occurrences then, if that's ok?


On line 404-405 I am waiting for task to exit and then closing the pipe. Is it what you mean?


Todavia tengo que probar esto,, :wink:


it might be better to set the environment of the launching task using whatever api you are using to launch the task (i.e. `NSTask setEnvironment:`) instead of setting this globally for the current process.


@tomtor Maybe you should try something along the lines of:
Thread [0] → movecount + k * (Threads.size() - 1)
Thread [1] → movecount + k * (Threads.size() - 2)
...
Thread [n-2] → movecount + k * 1
Thread [n-1] → movecount
...which is of course equivalent to the current code in the case of 1 thread. Of course with a ceiling. In this way threads with higher additional depth would be more helpful in shaping the search tree? Actually I have no clue, or very close to that, so don't pay excessive attention! ;-))


Resolving Issue #3