@moebio
Small comment. If the original NumberList has very small values in it (like 0.00000000001 / 10) then the perturbations could overwhelm the original values. Not sure it's worth the extra performance hit but might be better to use something like:
var avg =  list.getAverage();
then Math.random()*avg/10000 in the loop

- another idea, you might want it stable for repeated invocations so maybe use a seeded random


calculate the IvrAndSmsStatisticReportsToUpdate separately from the usual records,
and remove each ReportToUpdate after calculation of it is done


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.739](http://teamcity.monogame.net/viewLog.html?buildId=11053&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:05:58


You don't need this "else" part


There's a rule in object-oriented design called the "[Liskov Substitution Principle](https://stackoverflow.com/questions/56860/what-is-the-liskov-substitution-principle)". This method is a good example of how following the LSP can simplify your code.

Here, computer players and human players both have a `make_move` method, but they take a different number of arguments in a different order: humans need `view.input` and `board`, while computer players just need `board`. That means any collaborators who want to call `make_move` (like this class) need to figure out which kind of player they have, with something like the `if` check above.

If human and computer players had the same interface and method signatures, this class wouldn't need to care if it had a human or computer player—it could just call `make_move` without worry.


Checkmarx scan results 05 Nov 2015 04:46 UTC -08:00

High
Medium
Low
Info

New
36
31
37
0

Recurrent
0
0
0
0

Fixed
0
0
0
0

 Open Viewer
Included commits

Commit ID	Owner

3f348b8cf3177fdd35260d941fc6d2143cbb428f	@dudug


You will want to template bind `HorizontalAlignment` and `VerticalAlignment` to `HorizontalContentAlignment` and `VerticalContentAlignment` respectively.


Need to account for properties of a single character


Why is liquidwar in this PR?


@bwoebi /push


At least on my Sony 5.1.1 and Samsung A5 5.0.2: _"Opening VPN settings only shows current VPNs added by hand, Netguard is not featured there."_

And neither are these:
* [NoRoot Firewall](https://play.google.com/store/apps/details?id=app.greyshirts.firewall)
* [NoRoot Data Firewall](https://play.google.com/store/apps/details?id=com.jianjia.firewall)
* [Mobiwol: NoRoot Firewall](https://play.google.com/store/apps/details?id=com.netspark.firewall)
* [LostNet NoRoot Firewall](https://play.google.com/store/apps/details?id=com.lostnet.fw.free)


You probably want to use __DIR__ instead of $dir here


Check the guidelines you referred to: https://source.android.com/source/code-style.html#use-standard-brace-style ;)

I think the risk of errors when not using braces far outweighs the benefits of more concise code. Actually, the first bug I stumbled upon when starting at Sense was such a bug: there was a log statement inserted before a single-line if-clause ... but no braces added.


Call this 'dsInfo'


TemplateTypes.setup.php as a file name will be enough :)


Mac OS doesn't have TCP_KEEP* properties.


> subtly different.

that's exactly what we can take advantage of inline formset, which I mentioned yesterday. much more cleaner and way simpler. I think we should go for `shift_from.html`.


Thanks! Is the worksheet called "use this" the one that has all the simulated lottery outcomes?


LOL


Anil, can we change link to https://docs.start.payfort.com/help/ssl

thanks


array()


please delete dead code


This is a small-blue tag:
![screen shot 2015-11-05 at 14 04 09](https://cloud.githubusercontent.com/assets/14334459/10969059/23b46884-83c6-11e5-8903-b20b989366ee.png)


Indentation !


can we get more details about error?
if it's a protocol error or certificates or something else?


Was this test batch intended to test the edge of that date range? If so, the createdDate is not on the start date - it is one day before.


감사합니다.. 멤버변수는 m 안붙이기로 이번에 정했는데... 다시 고민해봐야겠네요.


On my device (Nexus 5) it shows all approved VPN services. Anyway this menu option has been moved out of the way now.


Please update this message, this assertion is no longer related to test batches in Maseru.


Can this assertion be a little stronger?


Please wrap this line at 120 characters.


Does this really test the functionality of `View#clear`?


please use logger to print stacktraces


Remembering exactly what to test and how is one of the hard things, by the way, about testing after the production code is written.


@borshop: retry


please always externalize such strings befor committing


The "segments" folder is created with the parent folder in PhotographFormActivity.onCreate so the parent folder is never empty when onDestroy is called.


here is one more ;-) thought you would see it ;-)


а если строка


Is this still a useful test? When I'm test-driving something, I'll often start with something like this. But don't be afraid to remove tests that are no longer useful. What would it mean if this test broke? How would it break? What information is it giving you with each test run?


Uncaught TypeError: $(...).each.remove is not a function(…)


геррит удобнее.
может array_map ?


Do these cover all the validation rules?


Strange as I use the dispatch names in the error template just fine.


@christian-fei  Fortunately this text is still hidden in the page ;)


@dfosco you broke the search here


>1. no image_updated property added, users who have downloaded the previous image will not get the new images
2. removal and static property were removed, these affect the AI's scoring system
3. values were reverted back to 2.5 for Sylvan Bounty and Sphere of the Suns

@melvinzhang
Would these really need to have image_updated? They're having no real game impact (None of the scripts have oracle changes)

I've updated the two values, I'll have a look at the static and removal properties.


This might be due to the WSDL used at the moment isn't the most up-to-date:
```
<xsd:complexType name="RecurringDetailsResult">
  <xsd:sequence>
    <xsd:element minOccurs="0" name="creationDate" nillable="true" type="xsd:dateTime" />
    <xsd:element minOccurs="0" name="details" nillable="true" type="tns:ArrayOfRecurringDetail" />
    <xsd:element minOccurs="0" name="lastKnownShopperEmail" nillable="true" type="xsd:string" />
    <xsd:element minOccurs="0" name="shopperReference" nillable="true" type="xsd:string" />
  </xsd:sequence>
</xsd:complexType>
```
https://github.com/killbill/killbill-adyen-plugin/blob/master/src/main/resources/cxf/Recurring.wsdl#L49-L56


Версию изменили, это значить скоро релиз?
Fuze, посмотрите пожалуйста, проблемы со сменой шаблонов меню.


This seems like testing the implementation, not behavior. What did you want to get out of this test, and how else could you achieve it?


Somehow I don't have fsck running on boot on my x86_64 system, leading to multiple uncorrected errors in the fs. I thought it was the reason - wrong path. I doubt what else could be the reason then?


please delete dead code


Oh I thought you were talking about the message of the commit itself. Here I mean that the user can modify in this line of code in case they're using a different Junit. I didn't mean that they can use any other Junit version without changing anything here.


I will tag something.


just in case you still wonder how...

First,
> possible to create multiple shift instances on different dates in the shift creation dialogue

```
inlineformset_factory(..., extra=3)
```
we can play with this `extra` param.

Second,
> name the buttons in the create view Create/Cancel and in the edit view Save/Cancel

access django button fields inside form(or formset), and replace text with appropriate tokens.


>```
>size_t tocopy = (size_t) std::min((int64_t)size, mbuf->size-mbuf->pos)
>```
>This still isn't perfect, cause the minimum of those two might still be too large

I don't think that the min could be too large. But ```std::min((int64_t)size, mbuf->size-mbuf->pos)``` could be negative and then tocopy is too large.


Maybe investigating if updating to latest WSDL for `Payment.wsdl` and `Recurring.wsdl` would be feasible …


ok


@binky123: This is very interesting idea. For low depths, additionalDepth is high, and vice versa. Let's see how it works.


Да, сегодня-завтра.
Что за проблема со сменой шаблонов?


if size < 0 can be handled at the beginning of the function?


Didn't you miss cs.Configuration.Counters.DataDirectory here?


Update the comment to describe the expected formats e.g. 5.2, 5.2-SNAPSHOT, 5.2-RC1


How about implement search func such as `SearchSection(type, arg string) (*section, error)` ? This makes tests easier and becomes useful in the future, I think.


Thanks, I've done it already.
On Nov 5, 2015 8:02 AM, "Oluwatayo Shonibare" <notifications@github.com>
wrote:

> Reposition of directories for @serhiy10
>
> hey @serhiy10 dont forget to download the github interface......if you
> are having problems contact me
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Team-Tomahawk-CanSat2015/PCB_Boards2015-2016/commit/fddf8d661bac013df7128afed303b847ba1a597f
>


And ts.Configuration.TimeSeries.DataDirectory here?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3748](https://teamcity.mesosphere.io/viewLog.html?buildId=68740&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:06


Ahem https://github.com/supertuxkart/stk-code/blob/refactor_networking/src%2Fnetwork%2Fprotocols%2Fget_public_address.hpp  :beer:


Looking at this test, this might be misnamed...it accepts a piece *and* a move.


Your fix should work.

Maybe things are setup better if you first do a new(Host), and later set the request data. Maybe the the request data doesn't have the host.

The old problem was that z_context:get_all(Context), wasn't used. Then you miss the zotonic_dispatch vars in your template.


LGTM


I think there are a few warnings/errors that happen only with `cabal install`. For example a missing `LICENSE` file or missing `data-files`, IIRC.


Merci mitsu pour ajouter la dropdown, mais est ce qu'il serait aussi possible de pouvoir faire une recherche sur la france entiere ?


Clearing Cart after Enquiry and Showing Validation error of enquiry form after focus of input box.


@landreev @kcondon @scolapasta is there a GitHub issue tracking this change? Does it need to go through QA? (I assume it should.) I'm asking in case we end up creating a 4.2.2 branch from the 4.3 branch.


le soucis est au niveau de google api client je crois, non le sdk


This should be above checkconsistency call since it will also dereference o2.


I considered that, but I feel like that makes this a bit too dynamic. I would expect a single stream module to have on purpose... the URL and body might be mapped from the payload dynamically, but the actual REST call being made and especially whether a GET, POST, DELETE, etc. would probably be fixed don't you think? (can always deploy multiple modules if one should POST and one should GET... would then consume from different channels, and so on)


Oh Yeah!!!


I would tend to agree, yes. Just wanted to pass that by you


This is not consistent. Look at `get_base_url` function.


It was in the original PR, but I thought that seemed excessive. I feel somewhat the same as what I just replied wrt the method. Also, one could always use `Object.class` and then deal with the type downstream... even adding a payload-type router for example.


This one and the changes to lparser.c and lstate.c could be avoided by marking luaD_throw and its callers as noreturn. This way the analyzer would automatically see they're impossible. Also it would probably allow removing the unnecessary return-statement from lua_error in lapi.c 808.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3749](https://teamcity.mesosphere.io/viewLog.html?buildId=68741&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:10:44


Only jobs with CYBUILD=TRUE generate wheels, e.g. https://ci.appveyor.com/project/vmalloc/logbook/build/job/e2vk0bhcro0cr349

```
Creating "1.0.4" release for repository "mitsuhiko/logbook" tag "1.0.4" commit
"e50ed2b81acc7ac0fa66b63af8bdb49abdd24742"...Skipped (Release with tag "1.0.4" already exists)
Uploading "Logbook-0.11.4.dev0_20151105-cp26-none-win32.whl" to release assets...OK
```

It looks like it succeeded, is there a draft GitHub release "1.0.4"?

About 1.0.4: that is AppVeyor's build number. You removed this section:
```yml
  on:
    appveyor_repo_tag: true
```
This would use the git tag rather than the appveyor build number. You could tag the commit as 0.11.3-dev to test perhaps.


wrt discussion about dynamic http method above, I see more value for dynamicity here, WDYT?


Please use a separate commit of the automatic revoke. The user side of it needs more work, still listing the API key in the profile, marked as revoked.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3750](https://teamcity.mesosphere.io/viewLog.html?buildId=68742&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:11:21


This is a bug fix for #2719.

I'm mentioning it here because we are considering creating a 4.2.2 branch based on 4.3 and we need to account for all the changes since 4.2.1 (which are in the 4.3 branch).


@jalonsob this does not fix anything because the command will be executed even though the backend is not supported. You have exit from the function in these cases with a `return`.

Moreover, instead of printing a message to the standard output, write it on the main log saying that the execution was skipped and including the reasons.


Indentation is done with <tabs> in this file instead of 4 spaces.


Remove newline. Not consistent. See `smtp_mail` function.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3752](https://teamcity.mesosphere.io/viewLog.html?buildId=68745&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:46


Yes, a literal Map is probably the easiest way to supply a Map of headers in fact. But I have thought about some other alternatives. For example, should we support just a comma-delmited list of header names that would be grabbed from the request Message? That line of thought is what led to my question about Map selection (based on a list of keys) via SpEL yesterday.


`Object.class` is only about configuring the expected type. This would not allow access to something other that the response body though


lgtm!


thank you


Ugh. I will reformat. I'm surprised I didn't notice, but the original PR must have used spaces.


Oh, right, I missed that. But so does clang analyzer, it seems. :)


Sure, but ```mbuf->size-mbuf->pos``` could theoretically also be negative. I know I'm too pedantic ;)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3751](https://teamcity.mesosphere.io/viewLog.html?buildId=68744&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:09:45


May be this way:
String hostkey = System.getProperty("HOSTKEY", "/etc/grid-security/hostcert.pem");


Sure. I'll get to work.


Good point, and excellent idea to use the module itself. The only problem would be the lack of this same level of support to test things like POST, header-values, etc. Will explore.


OK, I guess this PR is blocked until I fix the bug...


Now I am curious on your final solution :-)


@aslabs why are you saying that writing to disk will make the changes available to the rest of the code? Can you provide an example? If you're manipulating `$_SESSION`, the changes are supposed to be available everywhere, since this is a global variable.

In my opinion, that session_commit+session_start in clear() can be removed.


"and and"


PasswordEncoder is deprecated. But can not find a way to not use this object to check the password.
@Hunsu : do you have any idea ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3754](https://teamcity.mesosphere.io/viewLog.html?buildId=68748&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:11


Do you think we should provide both properties: `expectedReturnType` and `expectedReturnTypeExpression`?


зачем в цикле?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3753](https://teamcity.mesosphere.io/viewLog.html?buildId=68747&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:28


This looks suspicious. What happens when _data is NULL but other._data isn't? This would skip the copy and then "this" wouldn't contain the same data as other. Also several members are not set from other leading to them possibly containing unexpected values.


@HongxuChen thanks. I do know about pep8, and general feeling towards extra whitespace, but that's my "reflex" coding style. Usually when working with others one needs to adapt, but this time around I got lazy. Still, thank you for pointing it out, I'll do a run of styling as soon as things get stable enough.

Also on the branch names, of course, pure lazyness :)


:+1: :x: :100: for this.


Same problem as indexbuffer.cpp above.


url is broken: conde-of-conduct


I think you can POST some stuff to the actuator


What is `h` now? The loop is removed, but `h` is still here. Probably the tests didn't come here this time.


Fixes also the version retrieving on non-English Windows instances where "Version" name is translated to local language.


* and some other dependencies to their latest version. Not sure if i'm doing something wrong so i hope not.


И что мне теперь делать?!


You should never blindly add stuff just to silence the analyzer but instead try to understand what the code does and what the analyzer is complaining about. I have blown up code before by trying to eliminate all compiler warnings without understanding the code.


$this->gLng und das "global $lng" weg?


@kalimatas so be it; see updated pull request


I think these entry points need to be REST API entry points so we can do AJAX calls in the profile page to dynamically add/remove tokens in a nice way.


The commit message says `Canceling flags in CMakeList.txt`, but you don't touch any CMakeLists.txt file, could you correct the commit log to what you are actually changing here?


Moving to a new thread


Here's an example how to do this and how the necessary changes can "cascade" through functions:

https://github.com/turol/webquake2/commit/259cf75a14961a0b08b431a56df142614848ff48


I suggest you take this to the forum as further discussion here is spamming github - on the forum post your boot configuration as that could be the reason fsck isn't being run (or perhaps fsck is being run, but simply isn't detecting the errors you say exist).


Actually, someone should file a bug report against DRM.  The page sizes of device IOMMUs may very well be different from the page size of the host CPU.  Considering the trend towards heterogeneous architectures, this becomes increasingly likely.  If a 128k buffer is requested because it matches the page size of the target DMA device, DRM should honor that and not secretly switch out values behind your back.

For a buffer here, any size is valid.  DRM should have an allocated_size in addition to size preserving the code authors intent.  This patch ensures that exynos requirements are meant and it is indeed a fix as without it, there is the potential for error.  The surface area for issue is not limited to code directly calling this routine.  The routine blindly takes any buffer->size that has been set by anyone. exynos_drm_gem_init does exactly that. It too sets the buffer->size without any validation.

Forks of this patch series are free to add/remove/modify any aspect they wish.  For my personal repo, this issue is "Will Not Fix".


lgtm


`hndls` list is not used anymore. Let's remove it or comment it out.


@jlhanl DWMR. Such a nice feeling when it finally works. Well done. Press ahead!


Actually finishes item 'e' :stuck_out_tongue_closed_eyes:


Just curious why the splash screen window gets dismissed here, before the app has started up?


In recent versions of ubuntu with apache 2.4, `sites-available` configuration files must end in `.conf` extensions because of this in apache configuration.
```
# Include the virtual host configurations: IncludeOptional sites-enabled/*.conf - See more at: http://lyemium.com/content/virtual-host-issues-when-upgrading-apache-22-24#sthash.JRsqCEOv.dpuf
```
I believe `/codebender-$PACKAGENAME` will leave them without the extension, so `a2ensite` will fail later.


Сделай, чтобы под маком тоже работало


Is it required to comment the method out? I would assume that it is enough to just override `getSubscribedEvents`.


You writing this in Django or node.js?


ah damn, should be regex, will fix later


I left a bunch of low level comments, but want to leave some high level feedback, too. There's not a great place to do it, so I'll leave them here.

### The Good
:+1: The included README had everything I needed to start the game and run the tests.
:+1: You added all the features we asked for.
:+1: AI seems to be unbeatable.

### The Bad
:-1: Players can choose the same piece! (Both X or both O)
:-1: The first move of the computer AI is really slow. (Any tricks for speeding this up?)
:-1: Your tests don't cover everything, and it doesn't look like they helped give you feedback on your design.

### Some things to think about:
:question: What are the benefits and drawbacks of the MVC design you chose to use here? How might things have turned out differently if you let tests drive that design?
:question: How do you know your minimax implementation works? How confident are you?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3755](https://teamcity.mesosphere.io/viewLog.html?buildId=68753&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:28


need pack unpack function


This file was already added in [this commit](https://github.com/CentroEPiaggio/kuka-lwr/blob/82f54804b662170cc2e896fd7f46aae56e8db8a9/lwr_controllers/include/utils/interpolationmb.h). Why is it here again?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22907/testReport/) for this commit**


You said "...unless they are on the **RHS** of an assignment"? `MultilineOperationIndentation` doesn't check if a `send` node is on the LHS or RHS. If it's in an assignment, and the style is `aligned`, then it aligns (not ident).


Update Cocktail to version 9.1 for El Capitan.


I thought I would leave the methods inline (commented) to ensure completeness. Certainly they are not needed at the moment, but if we were to need them later, it may be helpful. would you prefer they are removed entirely?


setSize() allocates _data and sets the members to the other values, so I'm fairly certain that's not possible.

_data is only every allocated through the setSize() method, and that only allocates _data when both count and size are != 0. So for _data to be NULL, other_data also has to be NULL.


It would indeed, i've updated the branch, moved `start_on_load_handler_process/0`from `boot/1` to `boot/3. Special case for `init:restart` is no longer needed
Fix still applies


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 basic_test|__suite_setup__|0|1|0|0
basic_test|_basic/test_create_vm_|0|0|0|1
basic_test|_basic/test_stop_vm_|0|0|0|1
basic_test|_basic/test_start_vm_|0|0|0|1
basic_test|_basic/test_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_volume_|0|0|0|1
basic_test|_basic/test_add_vol_to_stopvm_|0|0|0|1
basic_test|_basic/test_add_volume_reboot_vm_|0|0|0|1
basic_test|_basic/test_add_multi_volumes_|0|0|0|1
basic_test|_basic/test_add_volume_negative_|0|0|0|1
basic_test|_basic/test_crt_temp_from_volume_|0|0|0|1
basic_test|_basic/test_crt_vm_with_volume_|0|0|0|1
basic_test|_basic/test_vm_securitygroup_|0|0|0|1
basic_test|_basic/test_create_iso_vm_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account_|0|0|0|1
basic_test|_account/test_crt_vm_by_normal_account2_|0|0|0|1
basic_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
basic_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
basic_test|_suite_teardown_|0|0|0|1
virtual_router_test|__suite_setup__|0|1|0|0
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
virtual_router_test|_novlan/test_create_vm_|0|0|0|1
virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_vlan/test_create_vm_|0|0|0|1
virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_snat_create_|0|0|0|1
virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
virtual_router_test|_vlan/test_start_vm_|0|0|0|1
virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
virtual_router_test|_volume/test_add_volume_|0|0|0|1
virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
virtual_router_test|_sg/test_ingress_|0|0|0|1
virtual_router_test|_sg/test_egress_|0|0|0|1
virtual_router_test|_sg/test_icmp_|0|0|0|1
virtual_router_test|_sg/test_udp_|0|0|0|1
virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
virtual_router_test|_sg/test_vm_ops_|0|0|0|1
virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
virtual_router_test|_sg/test_detach_l3_|0|0|0|1
virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
virtual_router_test|_pf/test_attach_pf_|0|0|0|1
virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_multi_rules_|0|0|0|1
virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
virtual_router_test|_pf/test_tcp_|0|0|0|1
virtual_router_test|_pf/test_udp_|0|0|0|1
virtual_router_test|_pf/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_2_eips_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
virtual_router_test|_eip/test_attach_eip_|0|0|0|1
virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
virtual_router_test|_eip/test_vm_ops_|0|0|0|1
virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
virtual_router_test|_lb/test_create_lb_|0|0|0|1
virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
virtual_router_test|_host/test_reconnect_host_|0|0|0|1
virtual_router_test|_suite_teardown_|0|0|0|1
local_ps_virtual_router_test|__suite_setup__|0|1|0|0
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_ps_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_ps_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_ps_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_ps_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_ps_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_ps_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_udp_|0|0|0|1
local_ps_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_ps_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_ps_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_ps_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_ps_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_ps_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_ps_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_ps_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_udp_|0|0|0|1
local_ps_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_ps_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_ps_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_ps_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_ps_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_ps_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_ps_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_ps_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_ps_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_ps_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_ps_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_ps_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_ps_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_ps_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_ps_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_ps_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_ps_virtual_router_test|_suite_teardown_|0|0|0|1
local_nfs_virtual_router_test|__suite_setup__|0|1|0|0
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_account/test_vm_ops_by_normal_account_|0|0|0|1
local_nfs_virtual_router_test|_account/test_multi_accounts_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_novlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_snat_create_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_dnat_reboot_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_ping_vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_create_3vms_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_3l3s_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_remove_dhcp_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_2l3_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.0_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vms_with_limited_ips2.1_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_start_vms_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_crt_vm_with_hostname_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_reboot_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_chg_static_ip_vm_|0|0|0|1
local_nfs_virtual_router_test|_vlan/test_attach_nic_with_static_ip_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_m_vols_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_add_volume_vr_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_volume_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_2_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_24_volumes_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_volume_ops_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_volume/test_crt_vm_from_dvt_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_crt_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_template_image/test_del_temp_image_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_icmp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_egress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_2vm_ingress_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_4vm_complx_|0|0|0|1
local_nfs_virtual_router_test|_sg/test_detach_l3_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_2l3s_pfs_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_attach_pf_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_delete_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_del_vip_before_add_pf_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_pfs_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_multi_rules_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_after_destroy_vm_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pf_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_udp_same_vip_ports_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_pfs_tcp_with_same_vip_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_tcp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_udp_|0|0|0|1
local_nfs_virtual_router_test|_pf/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eip_pf_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_2l3s_eips_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_attach_eip_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_create_eip_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_del_vip_before_add_eip_to_vm_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_eip_sg_tcp_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_pf_eip_attach_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops_|0|0|0|1
local_nfs_virtual_router_test|_eip/test_vm_ops2_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_alone_vr_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_source_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_create_lb_|0|0|0|1
local_nfs_virtual_router_test|_lb/test_lb_health_check_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_sp_after_delete_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_create_image_by_snapshot_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_for_both_root_..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm2_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm3_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_delete_snapshot_on_ru..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_in_live_vm_|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_crt_sp_from_vol_crt_f..._|0|0|0|1
local_nfs_virtual_router_test|_snapshot/test_change_max_sp_depth_l..._|0|0|0|1
local_nfs_virtual_router_test|_regression/delete_sg_with_2_attache..._|0|0|0|1
local_nfs_virtual_router_test|_regression/rm_nic_sg_on_stopped_vm_|0|0|0|1
local_nfs_virtual_router_test|_regression/test_data_volume_with_vm..._|0|0|0|1
local_nfs_virtual_router_test|_vr/test_ping_vms_reboot_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_reconnect_vr_|0|0|0|1
local_nfs_virtual_router_test|_vr/test_start_vrs_simultaneously_|0|0|0|1
local_nfs_virtual_router_test|_host/test_reconnect_host_|0|0|0|1
local_nfs_virtual_router_test|_suite_teardown_|0|0|0|1
Total|304|0|4|0|300


This could be `require('./lib/server');`.


Do you know why INLINE is better than INLINEABLE in this situation ?
(Johan Tibell is generally advising against `INLINE` [here] (https://www.google.be/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&cad=rja&uact=8&ved=0CB4QtwIwAGoVChMIhaWgqbP5yAIVgrcUCh17TQD5&url=http%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3D_pDUq0nNjhI&usg=AFQjCNEDbv9MFJiDBkTdvU2i7JKAz52Byw&sig2=RabZnEqH6kC1MBKyB3lf5g))


You are not actually using git commands to make the branches even here, still looks like you copied and pasted what was in `ros-i-specs`


Don't know… after all it's something a bit special to it… in two years when every server has HTTP/2 by default we may drop it.


The UI side of this needs more work. I'm thinking
  -  list of current tokens
  - token creation: click on generate, AJAX API call, the new token appear in the list
  - button to revoke a token
  - button to remove a token


Oh, ok then.


You should add that as a comment to the code so the next person who reads it doesn't get confused.


No. My point was not about the return type (which indeed the user can know beforehand, or at least broaden to `Object.class`) but about `return response.getBody()`: I'm arguing about whether to introduce "`resultExpression`", so that for example, I can return the `Set-Cookie` header from the response (rather than the body only)


new file? missing the copyright header.


jpush工具类


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Why did you commit this change in first place? If you do not include the commit where you did it, this diff will not show.


Just FYI, the original intent of the short and long timeouts was this:
- The short timeout was used when the master and worker were in the middle of a synchronous conversation, and so an immediate reply was expected.
- The long timeout was used when the master's attention might be divided, and so the worker could not always expect an immediate reply.

That distinction might have gotten lost over the years, so it might be worth revisiting it throughout..


Maybe it's more evident for you when translating into German:

_Wir validieren aber nichts bezüglich der InternalRequest Instanz noch bezüglich Objekten, die nur über diese von außen erreichbar sind._


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22908/testReport/) for this commit**


I explicitly added the link so that everyone would know I am not the source (nor am I to blame) for the patch.  Git housekeeping was a not a priority; fixing the long standing issue was. Daniel (or anyone else) is free to submit a pull request.  Others have mentioned incorporating the original patch into their repos, so if you find a repo that has it, link it here and I will pull it.  My current workflow is less that ideally suited to me doing this.


> Isn't this awesome...

Yes.


that will not work when patchwork is installed in a site subdirectory:

 http://www.foo.org/patchwork/api/1.0/

I think this functionality will be better implemented as a permission class in the API views (so we don't incur the penalty of this check everywhere).

I've done something like this in the past: See MaintainerPermission is patchwork/views/api.py


@muglify I honestly think there was no need for this line, and exactly this line caused the problem reported in #68
I'm thinking of reverting this line back, what do you think?
@ssalcio can you please explain this line?


Good idea. I don't want to overcomplicate things, but it almost seems like the default behavior should depend on what HTTP method is being used. For example, returning "body" for a GET is a sensible default, but it probably makes more sense to return the status code after a POST.


This commit 0a8eedb831e83fb0938b624bc1fa9ae521dce384 I mean, but the file was modified along with other changes. Could you split that commit and only consider the changes in code?


你好啊


Hi,

Do you know when this will reach stable version? I'm having the issue this commit fixes in 2015.8.1 and it's really annoying to patch this after Salt is installed.

Thanks!


Schedule ... ~~on~~ for
(also, missing whitespace after Text)


Oh yeah, `/g` was indeed intended here.


Schedule ... ~~on~~ for
(also, missing whitespace after Paragraph)


Yeah. I think `body` is still an acceptable unconditional default, though


explain why xmlSerializingContext must be a r-value


L5-8 shouldn't be here, right?


IndicatorPeriod.baseline also looks for an "adjacent" period. Suggest factoring out common code:

```python
    def adjacent_period(self, next=True):
        """
        Returns the next or previous indicator period, if we can find one with a start date,
        and we have a start date ourselves
        """
        if not self.period_start:
            return None
        try:
            if next:
                return self.indicator.periods.exclude(period_start=None).filter(
                        period_start__gt=self.period_start).order_by('period_start')[0]
            else:
                return self.indicator.periods.exclude(period_start=None).filter(
                        period_start__lt=self.period_start).order_by('-period_start',)[0]
        except ValueError:
            return None
```
and use it in both places. NOTE: I haven't tested this code!


Please, let the joint_trajectory_controller as default.


Single |


Right now the worker does not seem to need the short timeout, as all its requests are asynchronous. The master does expect the workers to be snappy once in a while.


Thanks for bringing this to my attention. :+1:


See B2G/gecko/dom/events/KeyNameList.h for actual key names
+DEFINE_KEYNAME_INTERNAL(SoftLeft, "MozSoftLeft")
+DEFINE_KEYNAME_INTERNAL(SoftRight, "MozSoftRight")


я бы не перехватывал на этом уровне, а обрабатывал его уровнем выше


<marquee>updates
coming
soon</marquee>


Could you please split documentation updates and code changes in different commits?


I think it's not a great idea to have secrets in GET parameters. URLs are kept in the server log files, kept in the browser history, ... Sure with HTTPS, GET parameters will be encrypted.


I think this method name should be a bit more descriptive - perhaps `validate_training_options`?


I would have preferred just leaving them as they were. But not that important.


I'll give this a review.


А зачем ты удалил это?


это samdarka были ништяки, он расстроится.


I'm inclined to agree. That was the name I chose originally but `validate :validate_training_options` felt clumsy. WDYT?


There's a casting issue here.


I'm not sure, but I think you're taking the long road home here...

Instead of having `$plugin->app->execute_plugin_hook( 'my_hook' );` that ensure it's being called from within a plugin namespace, just have `execute_plugin_hook` be a method on the plugin object, like so: `$plugin->execute_plugin_hook('my_hook');`.  With that, no need for any `caller` magic.


Yes, it's fixed! IMG_Load() works without segfaults when filename is empty


Fixes incorrect hash key generation for variant positions.
Simplifies search and legal (and pseudo-legal) move validation.


composer.lock нужен, чтобы было у всех всё одинаково.


Uncomment one of these two calls to see a problem with casting in `CompilationUnit.cs`.
Wether or not the cast arise, `Check_BeforeAfterInsertion` runs into another problem with the parsing result.


@ShawnieBoy thanks for restoring the value, removal, and static property values. For image_updated, we can continue the discussion in #481


这里写错了。
应该改为：gpfcon = (volatile unsigned long *)ioremap(0x56000050, 16);


:heart:


genius ._.


You have to put the name of the Project "Smart Quote" also you can add "App" if you want


On Windows you might want to link to https://github.com/npm/npm/wiki/Troubleshooting#upgrading-on-windows as Windows people can't easily upgrade in many instances.


How can i use AdColony SKD if my app using Air SDK 18.0.0 (and i'm not planning to upgrade it due to instability of SDK 19)?


Indeed, thanks.


See: https://github.com/yeoman/doctor/blob/411f23e12e382167b81c79697957d8690e47f41e/lib/messages/npm-version.twig#L8-L9


Put the description of the solution. "Multi platform app for put requisitions and make offers ..... "


Pernix Labs information


Yo


Done


Put the description of the project


Thanks! Corrected.


Why do we need delete this file? We are using it in menujs


Please verify the local paths, we can't depend for fixed path


I would rather say "no bandwidth overhead"


Missing EOL at EOF

And what is `iml` anyway?


COOL :beers:


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22910/testReport/) for this commit**


django 可以传递对象，不知道变成json有什么意义


Fixed in 882a63a.


Cool. I've added a [Trello card](https://trello.com/c/kNGitIqn) to investigate that test helper method.


@bierik please make sure that there are no commits with commented-out code in your pull requests. if you need to disable code temporarily during development that's fine but please always rebase/squash before submitting the PR.
I think on `master` commented-out code is only justified in very rare circumstances and only in combination with a comment stating **exactly why** it is commented out.


get_avail_model -> get_admin_site(request=request) raise exception! because context is None


This sentence needs some refactoring, for sure. /cc @rdlowrey


@bwoebi so, maybe we should also add the german translation into the docs, to get the point ;)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3756](https://teamcity.mesosphere.io/viewLog.html?buildId=68765&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:55


review JC's changes to binary search in Tandem driver and handle merge conflicts with current tandem-mvp branch


Most recent revision as of 05/11/15


Yes.

--------------------------------------------------------------
Gail Schmidt
Software Engineer
Stinger Ghaffarian Technologies (SGT, Inc.)
Contractor to the USGS Earth Resources Observation and Science (EROS) Center
Rapid City, SD  57701
605-593-2722   Phone
605-394-6078   Fax
gschmidt@usgs.gov

Adaptation - "Manage the unavoidable"
Mitigation - "Avoid the unmanageable"

On Wed, Nov 4, 2015 at 3:22 PM, Nathan Genetzky <notifications@github.com>
wrote:

> Fixed. Is this suitable?
>
>         logger.info('Spawning {0} years for processing seasonal summaries via'
>                     ' {1} processors ....'
>                     .format(num_years, self.num_processors))
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/NGenetzky/espa-burned-area/commit/c4e9a580b4bd85ac423b507b0441cab216fb2a19#commitcomment-14197095>
> .
>


It's not Daniel's responsibility to check that you're doing things properly. I just pointed it out because I think it's important and good style in general. If you choose to ignore that, so be it.


Apa yang salah coy


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3758](https://teamcity.mesosphere.io/viewLog.html?buildId=68769&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:19


Are all these `sytle` typos done on purpose?


See #276


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22911/testReport/) for this commit**


Hi Roberto,

may I ask you to write a test for the whole sorting thing? We need to make sure nobody breaks it and it works for more values than one or two.

Thank you.


In https://github.com/codebendercc/eratosthenes/commit/63ece11d99259a030d875a461b9ca8add098ed64 you added `build` together with `build/logs`. Now you're removing it. One of the two commits has to have something wrong.


You're right.

I was basically assuming clang was being oversensitive, because Lua is "obviously" correct. That was premature and impatient of me.

I'll revert this, and see if marking luaD_throw as non-returning makes a difference.


Hi Victor,

I am now reading your new README. Nice work, now I understand FPL usage!

At this [line](https://github.com/victorsndvg/FPL/commit/769648fdd928d5a827f6f946234bcbc74e2382fa#diff-04c6e90faac2675aa89e2176d2eec7d8L79) you are showing the *get* method, but it seem the *set* one is listed.

I think that your FPL implements the concept of *dictionary*, maybe you can explicitly declare such an usage.

I think I will use FPL extensively... you are warned!

Thank you very much for sharing your work!


That's ok as long as our lines are not longer than 80 characters.  Anything over 80 needs to be fixed.


True enough for now… 💣


Yes please.


Hi @xoyojank
First of all thanks for your updating,
but I still have troubles:
![immagine2](https://cloud.githubusercontent.com/assets/15671987/10970333/431fd610-83ce-11e5-8cd9-449aaa74e946.png)
I really am stocked.

thanks


Then that's the problem. Not sure how things got messed up, but it was supposed to work as I previously mentioned. This is the default behaviour of a few prominent editor (e.g. Emacs, which me and @jonas054 are using). There should be 3 styles - always align, always indent, and align on assignment.


@VickiG DWMR. `return @"success here";` :crossed_flags:


@pbauer thanks for noticing and providing the fix!


Cool.  Thanks, @erwan


@prudhomm RT and Ned are vectorial elements. In 2D, the curl of u is a scalar. Does that make any problem here ? Do we have to define here something like
```c++
#if DIM==2
w.on( _range=elements(M_mesh), _expr=vec(curlv_op(u),cst(0.)) );
#else
w.on( _range=elements(M_mesh), _expr=curlv_op(u) );
#endif
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3757](https://teamcity.mesosphere.io/viewLog.html?buildId=68766&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:05


A small quibble with the description of the change:
   the change applies to `func`, which is either `numpy.median` and `numpy.mean` depending on the `useMedian` keyword.  The default is `numpy.median`, which itself falls back on taking the mean of the middle two elements of an array if N is even.

I might suggest generalizing the description to include both median and mean to clarify that it applies to either option in `_kclusters`.


is relation to Site necessary? we could get it from Clinic (since it is mandatory), so rather let's add two-way relationship Clinic-Site


Rename to addressableFieldTest() so that it's clear what's being tested


@ppekrol When does this happen?


потому что зависит от пользователя


对象能够解析是因为Django自带的那套模板引擎啊。。。


nice work ;)
the items are extremely correct !!!
A long time waiting for this
so much thank you


Попправила


You'll also need to mark everyone who unconditionally calls luaD_throw and all their callers. Just make sure they do so unconditionally, otherwise you will get nasty bugs.


I'm sorry to bug you, but could you describe normal values and the anticipated impact (like what it does?)


Means, when is "RemoveFromIndexTask" executed instead of the normal remove?


camel case


You could copy the above description here too...


respond once?


Could you add also a 20xx.yy compatbility (and tag 5.4.1)?
As it stands this is not compatible with eZCommuniity 2014.11


It is a bit clumsy, but I can't see an alternative and the clumsiness is limited to a single place.


it's better to do something like `logger.error(message, extra={'context': 'dispatcher'})`
then user might define his own format/prefix and isn't limited to yours


Yep,

Currently Manu has sent a new Test class for uploadServlet class but its
not in master yet

We are waiting this to be merged in master to add more test for our cases

Sounds good to you?

2015-11-05 15:02 GMT+01:00 Tomáš Polešovský <notifications@github.com>:

> Hi Roberto,
>
> may I ask you to write a test for the whole sorting thing? We need to make
> sure nobody breaks it and it works for more values than one or two.
>
> Thank you.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/robertoDiaz/liferay-portal/commit/f862c4b2c0bdd91974db343260ad9b1008405613#commitcomment-14211868>
> .
>

--
*Roberto Díaz*
Liferay Core Engineer

Liferay España y Portugal / Liferay Spain and Portugal
Tel. +34 917336343
www.liferay.com

Enterprise. Open Source. For Life.
Síguenos en  <http://www.facebook.com/pages/Liferay/45119213107>
<http://www.facebook.com/pages/Liferay/45119213107>
<http://www.twitter.com/%21/liferay_es>
<http://www.liferay.com/about-us/news>

Visit Us: www.liferay.com  |  Like Us: facebook.com/liferay  |  Follow Us:
twitter.com/liferay_es

*Aviso de Confidencialidad: *Este mensaje de correo electrónico, incluidos
los archivos adjuntos, enviados en nombre de Liferay SL es para el uso
exclusivo del destinatario (s) previsto y puede contener información
confidencial y privilegiada. Se prohíbe cualquier revisión no autorizada,
uso, copia, divulgación o distribución. Si usted no es el destinatario, por
favor póngase en contacto con el remitente por correo electrónico de
respuesta y destruir todas las copias del mensaje original. Gracias.

*Confidentiality Notice: *This e-mail message, including any attachments,
sent on behalf of Liferay SL is for the sole use of the intended
recipient(s) and may contain confidential and privileged information. Any
unauthorized review, use, copying, disclosure or distribution is
prohibited. If you are not the intended recipient, please contact the
sender by reply e-mail and destroy all copies of the original message. Thank
you.


> It's not Daniel's responsibility to check that you're doing things properly.

It may sound egotistic, but right now my time is spent on addressing this patch set and issues associated with this. If I have free time later where I am not triaging kernel code and vendor binaries, I will make the appropriate change.  But please understand that at this moment it is a very low priority for me which is why I stated I will accept a pull request.


Reverted it back to the first state


Ironically, in the time spent commenting on this, someone could have made the change and pull request.
;)


Damn your fast! :+1:


No, compilers are smarter than that. They're able to optimize for the noreturn case, but it never breaks the caller.


Test scripts will be uploaded tomorrow :)


Still a problem.
```
2015-11-05 14:09:30 ERROR ReviewResource:635 - Index: 0, Size: 0
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
	at java.util.ArrayList.rangeCheck(ArrayList.java:635)
	at java.util.ArrayList.get(ArrayList.java:411)
	at hoot.services.readers.review.ReviewItemsRetriever._getNodeCoord(ReviewItemsRetriever.java:367)

```


You're right. Thanks. I've updated the commit note accordingly.


thumb drawable can be customized with external drawables
<com.nolanlawson.supersaiyan.widget.SuperSaiyanScrollView
            android:id="@+id/scroll"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            app:ssjn_thumbDrawable="@drawable/custom_drawable1"
            app:ssjn_thumbPressedDrawable="@drawable/custom_drawable2">


This commit regards issue #41.


what's the sense of this assignment?


I believe we prefer to keep the local copy pristine except in exceptional circumstances.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3760](https://teamcity.mesosphere.io/viewLog.html?buildId=68773&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:58


Can you add ws4py to the requirements.txt please?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3759](https://teamcity.mesosphere.io/viewLog.html?buildId=68772&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:56


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3761](https://teamcity.mesosphere.io/viewLog.html?buildId=68774&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:25


Done with f8a4d11.


Wow this is definitely better :+1: Good job there. I also think that this deserves good documentation. WDYT?


Expected initial result.
The real result is consistent with that, as it has always be.
But that's just the first parsing.


Done with f8a4d11. Thanks


You're right. Well spotted! I've updated the commit note accordingly.


do you really need both 'showError' and 'message'?
I'd just have 'error' storing message or ''


I agree with your quibble. However, the commit message is part of history, which is (effectively) immutable: there is no practical way to adjust it.

On the bright side, this misleading description is _only_ part of the git commit log: it does not intrude into user-facing documentation or even in-code comments.


If "self.connect()" fails with an exception (for example, ConnectionClosed), "attemps_left" will not be decremented. Please review the code.


Hi

Will review this changes. Thanks for the collaboration.

I see you updated basically the packages but in what consisted your refactoring?


Addressed in fff311f.


do you think it's better to invert it and name 'isLoaded'?


@yoojinkimhong DWMR. You got this down pat. Thank you showing up and doing the work. :+1:


`Char` is a literal? or should I read this as as "each Char literal produces..."


só é para usar a macro se o último byte não for "cheio"

0x7 >> compense(8) = 0


You mean remove `add_prefix`? And add some variables to make logging format more flexible?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3762](https://teamcity.mesosphere.io/viewLog.html?buildId=68775&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:49


Merged with Master, @n00b2pr0.  All good?


Expected result after adding the following line at the end:
```cobol
END PROGRAM Empty.
```
The real result is off.


Because offsetXXX (for example offsetWidth) doesn't work for SVG element on Firefox (https://bugzilla.mozilla.org/show_bug.cgi?id=649285).


Does monte guarantee disjointedness of Null/Char/Int/Boolean/String/Double as scheme does?


What do you think of making this like ```field=(name, value)``` ?


Expected result after modifying the second line to:
```cobol
PROGRAM-ID. Emptier.
```
The real result is off.


@roymacdonald forgot a comma, that's why it wasn't loading


Expected result.
The real result is off.


Maybe there's a bad node in the dataset I'm using?
https://github.com/ngageoint/hootenanny/blob/mapinmap/hoot-services/src/main/java/hoot/services/readers/review/ReviewItemsRetriever.java#L360-L372


Чужой *groupId* -- плохой вариант


There is "connection_attemps" param in "pika.connection.ConnectionParameters" (see details here: http://pika.readthedocs.org/en/latest/modules/parameters.html#pika.connection.ConnectionParameters). Could it be utilized instead of "whilte" statement in "sendall"?


https://gcc.gnu.org/onlinedocs/gcc-5.2.0/gcc/Function-Attributes.html#Function-Attributes

"The noreturn keyword tells the compiler to assume that fatal cannot return. It can then optimize without regard to what would happen if fatal ever did return."

So if you mark a function "noreturn" but it can return you will break code. So if you have code like this:
```
if (some_error_condition) {
  fatal_func();
}

return success;
```
it must not be marked as noreturn. Whereas this is correct:
```
void some_error() __attribute__((noreturn)) {
  printf("fail\n");
  exit(1);
}
```


remove 'a'


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 60](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=426&buildTypeId=XbimEssentials_XbimEssentials) is now running


как уже говорили на семинаре, хорошо бы классы выносить в отдельные файлы


@mgrbyte I've done some work on this already - see my comments in #861


Can we add websockets support without tying it to a particular executor?


Сбилось форматирование


Please add a uni test for this.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 60](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=426&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:13


Please add a unit test for this


What is the profit of the change?


Also please add a uni test for this as well.


And (belatedly): @jdswinbank thanks for fixing this bug!


I think you'd only do this if you're replacing the model in the first dispatched _action_. *Odd*.


Is there a way to create links to a method in comments? Similar to Java's {@link ...} ?


it looks like a typo


не во всякой минуте 60 секунд... Иногда (раз в довольно длительный промежуток времени) случаются подгонки (например лишняя минута в високосный год и т д) поэтому лучше использовать уже написанную и предусматривающую это библиотеку ChronoUnit


为什么不去用


This commit breaks user interaction. Can no longer access hit events.


See inline comments


Each of monte's expression (and pattern) constructs is also documented elsewhere, but with (tested) examples. Non-kernel constructs include (tested) documentation of their expansion. I wonder if it would be easier to keep the material in sync if this material were folded into the existing sections.


It looks like this promotion step is failing due to the same issue:

https://jenkins.puppetlabs.com/view/All%20in%20One%20Agent/view/Stable/view/Puppet%20Agent%20Daily/job/platform_aio-suite_pkg-promote_stable-pe/18/console


@yvangagniere je dois remettre le commit de @floor0669 car on en a besoin.
Il faut que vous mettiez à jour google-api-client-python


Yes. I'm saying *not* marking something as noreturn will not cause a bug.


Http status 201 is `Created`, not `Accepted`. In described case `202 Accepted` is returned.

!mustfix bad http status description


а теперь кто угодно может взять и запостить в твой твиттер все что угодно, лучше было бы добавить этот файл в gitignore


Nice Ezee!
I think you don't need add all SDL headers in the .pro file.
The
INCLUDEPATH += ../libs/includes/sdl

in the bottom is enough.


Ok


Clarified


Note that this is a temporary update to store work in progress. There is much work to do on cleaning up markup and structure, in addition to reworking text in the 'Typography' sections, realigning some of the Chinese text, and adding more information.


nope just dramatic


Always, this is the task that is responsible from deleting entries from index (not from storage). It is scheduled during delete:
https://github.com/ayende/ravendb/blob/master/Raven.Database/Actions/DocumentActions.cs#L781


yep :)


I want to expand on this because I think its a design flaw in DRM.

On x86/64 and ARM devices, the page size can vary.  It may not be 4k (as it is now on ARM). If my CPU page size is 1MB and my device IOMMU is 4K, then rounding buffers up and reporting them in 1MB intervals causes useless extra DMA operations when all that the code authored wanted was to transfer 4K.

So I believe its important that buffers keep the as-authored size and accurately report it.  The CPU is free to assign a 1MB page to a 4K buffer, but it should not impose that constraint on other hardware.


И тогда использовать анонимные функции, которые доступны в 5.3


Je crois que tu as des remplacements qui sont mal passés.


Ah, I misunderstood you. But like we saw here, not marking stuff noreturn will cause spurious warnings.


`202 Accepted` is returned (not 201)

!mustfix bad http status in comment


TeamCity YaccConstructor :: YC.Core General Build [Build 507](http://teamcity.codebetter.com/viewLog.html?buildId=201873&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


может стоит вывести справку, а не просто умирать?


Slots refer to nouns? I got the impression from [E docs on four distinct indirections](http://erights.org/elang/kernel/index.html) that it was the other way around.


Thanks for the heads up, removed.


Given these were extracted from the shared menupanel.inc.css, I think it'd be nice to keep these as shared styles in case we change things.


if ! $_SESSION['glpishow_count_on_tabs']    ??
Nothing displayed ?


Better fix:

```ruby
group("read_marks.reader_type, read_marks.reader_id, #{reader_class.quoted_table_name}.#{reader_class.quoted_primary_key}").
```


:heart:


не получится, т.к. если строка, то будет один элемент, а значит parentPkAliases тоже должен быть один, а это уже первое условие и сработает условие count($this->relation->foreignKey) === count($this->_parent->_pkAlias)


Hi Fixes Have been Deployed


This commit is being reviewed as a part of review issue #11.


If the goal is to workaround a gcc 4.1 bug, can we include a specific #ifdef here so that this bit of ugliness is only present for that compiler+version?


Fixed in  88c7121


Ditto with these toolbarbuttons.inc.css ones.


Django y? Well speedys doing the django side
On 5 Nov 2015 13:34, "shaunmyles" <notifications@github.com> wrote:

> You writing this in Django or node.js?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BMG1010/ResourceApp/commit/e766e7d043c774eba437c6aaa1ac3a97cd7073b1#commitcomment-14211235>
> .
>


This is the correct place for jsps.


Thanks so much! That did the trick.


We need this variable only for tests. So it has to be in test are of code
It is ok keep apache commons library in test scope. So please remove this and all related declarations.


null and an empty string probably now mean the same thing at least - if GetCString returned null upon a null value in DB.


Good catch. I will add some handling here.


I like the name :)


Probably needs to be deleted?


Same. I'll add some handling.


Hi,

I am glad to help.

All I did is replace the deprecated: IGoogleApiClientConnectionCallbacks, IGoogleApiClientOnConnectionFailedListener with: GoogleApiClient.IConnectionCallbacks, GoogleApiClient.IOnConnectionFailedListener in the file GeofenceImplementation for Android. I also changed GoogleApiClientBuilder  to GoogleApiClient.Builder.
That's about it.


Delete?


Datatypes are read only thus removing


Is there some way we can copy this file as part of the build, rather than duplicate it?


typo! should be 'timeouts'


we do only 3D for now, we will see later for the 2D case


+1

It took me some time to wrap my head around why there cannot be late chunks of data in the new code. Very nice work.


`if` statement is redundant


But why does it work when the document ids don't match?


:tada:


I didn't have the time to test this code btw. does it work ?


Hi @haf

I'm using the fsharp/fsharp docker image for the first time.

It feels to me that perhaps this particular image should be called ``fsharp/fsharpi`` or ``fsharp/fsharp-script``?

This is my first time using Docker but I somehow expected ``fsharp/fsharp`` to be a base dev image containing the F# compiler.  How does this compare to other images for other languages with compilers?

thanks
don


Keep in mind that height is in device independent pixels, so if I'm not missing anything a cap of 1080 should only limit the height to 2160 actual screen pixels on retina displays. You might have to involve Screen.devicePixelRatio.


No entiendo este test, porque busca en $result que es una variable que esta definida en la linea 11 con un request al author y la salida es "no es correcto". Fijate que en la linea 19 la variable es resul1 con un uno al final no result con t al final.


nice cleaning :+1:


This file needs updating with the latest browser-loop - this line is no longer there in the newer version (and is currently causing errors).


BTW - does this stuff work with side-by-side indexing? And if so, how?


Ah interesting, I just saw that we had problems with this on retina screens. I'll play with devicePixelRatio


It hasn't been removed (not changed/altered either, to my knowledge):
https://github.com/radical-cybertools/radical.ensemblemd/blob/master/src/radical/ensemblemd/kernel.py#L96-L108.
I removed using post_exec in the example scripts since at some point it
might not be supported by rp (based on our discussion in one of the rp
calls).

But I believe it is supported in enmd:

>>> k = Kernel(name="misc.nop")
>>> k.post_exec = ['module load python']
>>> print k.post_exec
['module load python']

Am I missing something ?

- Vivek

On Thu, Nov 5, 2015 at 7:33 AM, Antons <notifications@github.com> wrote:

> Why? It is a HUGE assumption that kernels don't need any post_exec
> actions. For example you may need to unload/reload some modules. Besides
> users who simply want to add something to kernel's post exec will do
> kernel.post_exec += [something] and it will generate an error.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/radical-cybertools/radical.ensemblemd/commit/4cde4034b82fd2bec3645db26b6aa603dfe69eb0#commitcomment-14210028>
> .
>


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 61](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=427&buildTypeId=XbimEssentials_XbimEssentials) is now running


Superb!


If this means 4 pieces for us, that is much more than winning material.  One more past pawn than the opponent is often sufficient or 1 heavy piece, or 2 bishops, a bishop and a knight, sometimes 2 knights.  Without advantage, it can be pointless.  Just runs you out of time.

Sometimes you have to get the pieces off the board to take advantage of pawn structure advantages.  Maybe you need pawn structure to be part of this.  Winning is often done via promotion.


Редкий URL влезет в 45


The library still supports the Arduino Due, however Travis CI is throwing errors when testing with the Due. So, testing for Due compatibility has been temporarily disabled till this issue is resolved.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 61](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=427&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:14


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 62](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=428&buildTypeId=XbimEssentials_XbimEssentials) is now running


Нет больше одноимённых кроликов


en linea 11 esta $result en la 19 está $resul1


This file currently fails eslint. Lets add it to the .eslintignore for now and we'll sort it out when we change the directory structures for the add-on repo - currently this would require our "gecko" config, whereas due to its location it is using the "content" config. /cc @dmose


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 62](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=428&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:04


However, it would be nice to fix the trailing spaces!


:eyes:


@cvagrad86 DWMR. Ship code. :truck: :wine_glass:


해당커밋은 잘못된 커밋이므로 리뷰 무시용~


해당커밋도 무시~


saw approval from hmmr
at https://github.com/basho/riak_kv/commit/0b0df2233acd86a275e0c6f83a31131754ad9a9b


merging basho/riak_kv/feature/at/rts415_remove_sleep_and_poll_querying = 0b0df223 into borshop-integration-1255-feature/at/rts415_remove_sleep_and_poll_querying


basho/riak_kv/feature/at/rts415_remove_sleep_and_poll_querying = 0b0df223 merged ok, testing candidate = 3f35fe2c


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3763](https://teamcity.mesosphere.io/viewLog.html?buildId=68785&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:37


:+1: perfect this seams to work. Keeping the flexibility of the system on 100% https://github.com/tangrams/tangram/pull/212


Ha, sorry!


Capitalize, maybe more descriptive classname.


Oops... it's just misspelling. Thanks!


Why not just copy a file from assets instead of all this code?


I'm working on it to use the model framework, to determine convergence on that geo.


Shouldn't we throw an error instead if the file exists? Also, is there any chance it would?


UserInfo is a collection of the headers of the currently-logged-in user.

RawlsUser contains specifically what we care about, and may be a different user.


회사 세팅이에요. 로그가 길어지면 이게 더 보기가 좋아요 ㅎㅎㅎ

2015-11-05 20:55 GMT+09:00 hanwoong kim <notifications@github.com>:

> 완전 멋있는 로그로 나오네요..ㅋㅋ
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lazypic/init/commit/bd62b08a479b12997d9fb24f4139fe11ebf29a08#commitcomment-14209178>
> .
>


Note that this commit also opened up /rooms/:room_id/state because I am bad at merging or something.


Maybe a bit verbose?


I have a Shopify Fulfillment Request email notification coming through on a site I manage and it only displays the weight unit in Grams on line 10.  Is there a way I can utilize this unit conversion above to make this display the units in lbs (pounds)?
I have already changed the format settings in Shopify to Imperial system and display in lbs but this email notification we use for shipping is still in grams.

Im kind of a N00b to GitHub so any help is greatly appreciated!

Thanks,
Parker

{{ service_name }},
Please fulfill order {{ name }}.
Total number of items: {{ fulfillment.item_count }}
Unique items: {{ fulfillment.fulfillment_line_items.size }}
Items to fulfill:
{% for line in fulfillment.fulfillment_line_items %}
  Variant Title: {{ line.line_item.title }}
  SKU: {{ line.line_item.sku }}
  Quantity: {{ line.quantity }}
  Grams: {{ line.line_item.grams }}
  Vendor: {{ line.line_item.vendor }}
{% endfor %}
{% if shipping_address %}
Shipping Address:
  {{ shipping_address.name }}{% if shipping_address.company %}
  {{ shipping_address.company }}{% endif %}
  {{ shipping_address.address1 }}
  {{ shipping_address.address2 }}
  {{ shipping_address.city }}, {{ shipping_address.province }}
  {{ shipping_address.zip }}
  {{ shipping_address.country }}
{% if shipping_address.phone %}
  Phone: {{ shipping_address.phone }}
{% endif %}{% endif %}
Shipping Method:
  {% if shipping_method %}{{ shipping_method.title }}{% else %}None{% endif %}
Tracking Number:
  {% if fulfillment.tracking_number %}{{ fulfillment.tracking_number }}{% else %}None{% endif %}
Customer Email:
  {{ email }}
Thank you,
{{ shop_name }}


you're right, fix incoming


Es una boludes mi correccion, pero me parece que el nombre de las variables debería ser un poco más descriptivo.


Guard against subject ID / email mixups


we don't know the issue, so no.

if you don't do this, you can't push the resulting image once it's been squashed, that's all we really know.


Oi, o que esse SampleEntity e GenericConverter fazem?


WTF?!
`frogcraftOre` expected.


Estoy en eso, en seguida hago un commit nuevo con varias corrections


You are "returning" a void?   "too clever by half" ?


`pasture_type` -- нет такого поля в таблице... хотя это же тестовая таблица.

Вообще нет скрипта создания базы


Narp. The trait acts as the interface and common class for extending types.


I wish I could understand this 'linear-gradient' function :scream:


Pls change the function to a new function


Why is the production script not using minimize + uglify?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22913/testReport/) for this commit**


You should be able to get by without this line.


I feel like it would be cleaner to have the two endpoints. This field seems like a performance optimization we can add later if necessary. (My two cents, not a strong opinion)


@Jermolene

 I believe this one should be ```tiddlywiki --server 8080 $:/core/save/lazy-all```.


ohhh no that's not all the contents :cry:


We could, and I have thought about it.  I think this fix is relatively innocuous so I didn't initially.


I'm changing this endpoint to not take them in my project-skeleton branch.


This about about Catalyze making it easy for healthcare should be nuked.


reword this


As of 0.7.2, it would seem that vdirsyncer won't run without requests-oauthlib installed (even though I'm not using remotestorage).


I updated this already in master, fffw.


:joy: :joy: :joy:  你写个demo出来看看

一个页面那样的渲染只能一次


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 63](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=429&buildTypeId=XbimEssentials_XbimEssentials) is now running


This URI needs to be externalized into the local config of the server. The value must be either baked in by the server or retrieved via the REST API


git config --global user.name Arroavbai
git config --global user.email 84243673@qq.com


Thanks! Removed in 266524fbb2f0a9fe9be71bf51c9b08f919047fe4.


some tests failed:
failure: http://buildbot.bos1/builders/test-riak_kv/builds/2693


我擦，这不是有缺陷吗


this needs to be `typeof emoji !== 'undefined'` really


Fuck me.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 63](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=429&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:00


@cleverca22 Actually, why not just copy everything from /bin?


It's not counting the emoji as one char? As using the \U+199028932 ?


Das isch wennt committeti changes hesch wo nonid pushed sind und im eclipse as pull statt as fetch machsch :grin: (hann aigentli gmaint kah i hegs pushed kah aber anschiinend nid^^)  wie machsch das rückgängig wenns denn scho lokal hesch?


好像所有的框架都只能渲染一次。。。那种不刷新页面渲染只能ajax


TeamCity YaccConstructor :: YC.Core General Build [Build 507](http://teamcity.codebetter.com/viewLog.html?buildId=201873&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: System.Exception: NUnit test failed (9).   at Fake.NUnitSequential.NUnit(FSharpFunc`2 setParams, IEnumerable`1 assemblies)   at FSI_0002.Core.commonConfig@178-12.Invoke(Unit arg10@) in Z:\Builds\work\4138ce7c6332a78c\tools\Build.Tools\Core.fsx:line 1... Build time: 00:26:32
### Failed tests
```
GLLParserSimpleTest+GLL parser tests with simple lexer.Bad left rec: <no details avaliable>

GLLParserSimpleTest+GLL parser tests with simple lexer.Complex right null: <no details avaliable>

GLLParserSimpleTest+GLL parser tests with simple lexer.Cond: <no details avaliable>

GLLParserSimpleTest+GLL parser tests with simple lexer.Eps: <no details avaliable>

GLLParserSimpleTest+GLL parser tests with simple lexer.Eps2: <no details avaliable>

GLLParserSimpleTest+GLL parser tests with simple lexer.List: <no details avaliable>

GLLParserSimpleTest+GLL parser tests with simple lexer.ListEps: <no details avaliable>

GLLParserSimpleTest+GLL parser tests with simple lexer.Longest: <no details avaliable>

GLLParserSimpleTest+GLL parser tests with simple lexer.Simple right null: <no details avaliable>

```


removed oversighted debug code.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 64](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=430&buildTypeId=XbimEssentials_XbimEssentials) is now running


on a line


a new comment


Rewrote LCD_Blit, new version revealed no bugs so far.


是因为所用的框架旧了吧，支持多次渲染还有啥坏处？


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 64](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=430&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:05


What's changed since the revert?


I was wondering if that inheritance is necessary here? Don't we get it by default here?


Looks wonderful

![](https://media.giphy.com/media/mYSSwcIkyYkAU/giphy.gif)


It seems that this error message has the same code as the previous one (CWWKM2027E). So it should be CWWKM2028E.


Maybe I'm not understanding something.  I'm calculating here the inner size of all the non-deleted entries.  The cachedCoinsUsage variable in the child CCoinsViewCache will be reset to this number.  But DynamicMemoryUsage of the child CCoinsViewCache will still grab the new correct outer usage by calling DynamicUsage(cacheCoins) right?


Can you document the class with javadoc comments?


Can you explain in a (short) comment where trailing spaces could come from?


Ah, ok. I see. Thanks


Well when I `console.log` it, it shows as `['rob', 'lol', 🤘]` but then `['rob', 'lol', 🤘].split(' ')[2] !== 🤘`


musch au ned pull benutze, und wenns benutzisch, richtig konfiguriere :smiley: standardmässig isches nämlich uf fetch+merge igstellt und ned uf fetch+rebase. das chasch so ändere: http://stackoverflow.com/questions/17324715/git-pull-rebase-in-eclipse

und da na öppis zum läse bzgl rebase und merge: http://stackoverflow.com/questions/804115/when-do-you-use-git-rebase-instead-of-git-merge


@magnayn i've found retry lib, maybe you can try it to remove all that retry stuff from code?
https://github.com/rholder/guava-retrying


In short:
It seems that this works as well as it did with `upower`, and will be more portable to computers that don't have `upower` installed.

------------

Longer version:
I have a comment or two:

1. is the `battery_path` __always__ going to be `/sys/class/power_supply/...`? might we want to move this into a command-line argument instead of hard-coding it?
2. this is a very small comment, even related to the first question, and I haven't dug into this myself yet, but what do you do when you have 2 batteries? (this is not an uncommon thing these days). An advantage to using `upower` is that it still gets the overall charging/discharging/fully charged behavior correct, whereas if you are only looking at `BAT0`, we might miss that behavior. That may be a longer conversation about what to actually do about multiple batteries.

My vote is move the `battery_path` to an optional passed-in argument. That way you can say something like
```bash
./battery --path /sys/class/power_supply/BAT0
```
OR
```bash
./battery --path /sys/class/power_supply/BAT1
```
which uses the same script, same everything, but looks at your two batteries separately. On linux it could default to the BAT0 path for example.

We could alternatively look at ALL of the connected batteries, and calculate a single percentage, but this isn't what's commonly done with similar system tools built into various linux guis or Windows.


Interesting change. How come so? It does make sense, and I am glad you kept backwards compatible, because that'd have been one great breaking change... XD


`namedtuple` has an [`_asdict()`](https://docs.python.org/2/library/collections.html#collections.somenamedtuple._asdict) method which looks like it might work here (It returns an `OrderedDict`, but I suspect `json_response()` can handle that). Also I've read that `_asdict()` should be considered a public method because it is documented and was apparently written before the `_` convention was established.


Если в настройках виджета (меню) указать Шаблон виджета то система ищет шаблон в /templates/default/widgets/menu/ надо что бы искал в /templates/default/assets/ui/ или чтоб был возможность передать в функцию menu() и renderMenu() (в файлах template.php) параметр $tpl

А то сейчас все меню, вкладки, наборы создаются одним файлом /templates/default/assets/ui/menu.tpl.php


Now that I think about it, we shouldn't change this behavior. I'll submit an updated version of this patch. (both actually, because they need a rebase)


Renamed to `composed-petrinets`.


Actually it shouldn't ever be completely undefined, the result for just a normal string or unknown is always a graceful undefined


Yep - we're inheriting from `.site-navigation` which will be 47px on tablet breakpoint, and then 64px on the max tablet size. Without it we'll be defaulting back to the 54px declaration at line 49.


Sorry for this obscure feature; it's a feature appeared with the margin module that allow to add charges (shipping, custom, etc) to supplier price and help to manage cost prices.
In the margin module, margin can be calculate on supplier price or on cost price (it was before the feature disappeared !)
Next time you find an obscure feature, be welcome to ask on the developer mailing-list !
PS : now it's time to reenable the setting between cost price and supplier price in the margin module setup.


Thanks for your commit!


Will check it out again tomorrow in the office, I've already added the same yesterday, but it didn't work. That was the point were I've seen that you do exactly the same (in resumavble_get_lookup) like I do in my workaround.


不是，应该是做不到，请求头不能一个页面发送多个。。。


I'm not going to seriously fight for it, but `#if (__GNUC__==4 && __GNUC_MINOR__==1)` isn't a lot of code and it does remove some ugliness most of the time.


Om filen är trackad sen innan så laddas den den upp trots vad .gitignore säger. Kör git rm --cached <file> :)


FYI:
Tried this code in local, logged out of flarum, erased all js in assets/
I edit the information in the profile, press enter once nothing happens, press the second time and all text disappears.
Sharing information to know if master code is having the same issue too.


None of these are in the fast path, so does not make much sense here to mover away from defer. The ones in the fast path, like publish, may make sense.


Come on, where is your sense of humor :smile:


nice! looking forward upgrading lichess cluster!


It's possible, but only `eventlet` [is used by openstack projects](https://github.com/openstack/requirements/blob/master/global-requirements.txt#L41)


@milon
In developing env, the `daily` log system not gonna hurt because it's all stored in a single folder `storage/logs`, you clean it in a single command (or by using an custom alias).

But in production env, the `single` log system is a nightmare after months and years of use.

I don't see any benefit of using `single` log system. Unless if you are in dev mode ??


nice, I like it!!

--
Dr. Irina Overeem
CSDMS Community Surface Dynamics Modeling System
INSTAAR, University of Colorado at Boulder
PO Box 450, 80309-0450
Boulder, CO, USA
phone: +1-303-4926631
________________________________________
From: Mark Piper <notifications@github.com>
Sent: Wednesday, October 28, 2015 2:34 PM
To: mdpiper/wmt-selector
Cc: Irina Overeem
Subject: [wmt-selector] Rename wmt-prime to wmt-analyst (2ecef1b)

Rename wmt-prime to wmt-analyst

This change was suggested by @iovereem and @kettner, so as
to better set user expectations for this project.

Also tweaked text in tooltips.

---
Reply to this email directly or view it on GitHub:
https://github.com/mdpiper/wmt-selector/commit/2ecef1bb71cefb9a36054ec3b455ff28a88a610b


I added a [note](http://git-scm.com/blog/2010/08/25/notes.html) to the commit message. Unfortunately, GitHub doesn't display it on the web, but if you run:
```
$ git fetch origin refs/notes/*:refs/notes/*
```
Then you should find the commit message annotated in `git log`, `git show` etc. Not perfect, but the best we can do I think.


:ok: :1234:


I take it that this requires the other patches to work even when the anaconda RPMs are not installed, right? It should probably be the last patch in the set then.


Sorry but I'm not able to match the commit message to the patch: Don't you just replace `static ... main` by `static ... *main = new ...`? Please explain how this relates to *deletion*.


Needs a license on it and maybe worth putting in contrib if it's coming (with license) from a different project?

I guess this is unit agnostic?


Nooooice


Classic mistake


Feel free to make me review something substantial
as a "reward" for quibbling
on what at the code level was a clearly straightforward change.


The static object gets deleted at program exit, the dynamically allocated object not.


Oh yes, much better :+1:


I've just noticed that you removed only the println command. I was actually wondering what's the point of this ArrayList :-)

I will remove it now :)


*sigh*


Its better to use isEmpty and isDefined with options rather than comparing them to None and Some.


Hm, I get a merge conflict cherry-picking your commit. Could you please rebase on this nights staging branch?


@cy6erGn0m
Please take a look at this commit


Just out of curiosity, why not just go down to a single variable?

```
if openshift_master_ha is defined and (openshift_master_ha | bool or openshift_master_ha in ['native','pacemaker'])
```

would work for general ha testing..


@cy6erGn0m
Please take a look at this commit (fix for https://youtrack.jetbrains.com/issue/KT-7042)


Now that the data is checked in some CDS test are actually passing in the
nightly runs:
https://teamcity.labkey.org/viewLog.html?buildTypeId=bt855&buildId=282739&tab=testsInfo&pager.currentPage=1

Of course most of them still fail, but it is a start.

On Wed, Nov 4, 2015 at 5:45 PM, Nick Arnold <notifications@github.com>
wrote:

> @cnathe <https://github.com/cnathe> @labkey-matthewb
> <https://github.com/labkey-matthewb> @XingY <https://github.com/XingY>
> @labkey-jessim <https://github.com/labkey-jessim> We have test data!
> Thanks for putting this together Dan. I'd recommend all of you delete your
> test/sampledata/cdsimport directory before syncing fb_refinement again just
> to ensure you don't get any weird conflicts. Dan and I are going to update
> the tests so they run against these counts then we will be back to running
> tests to verify things are working! #reallifecode
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LabKey/cds/commit/81f029ecbc761e5a175f800829ed38576542e8cd#commitcomment-14200535>
> .
>

--
Thanks,
Dan


@Rochet2 - NULL DB values returns an empty string:

```c++
std::string GetString() const
{
    if (!data.value)
        return "";

    char const* string = GetCString();
    if (!string)
        return "";

    return std::string(string, data.length);
}

@BAndysc Change is needed for the PR #15671 and it prevents many conversions from char* -> std::string -> char* std::string


no debug print please


Good point I'll re-work it.


Nitpick: small typo in commit message.


Would update the copy to be as follows:

The following is a simple example which defines a schema with a single `hello` string-type field and a `Resolve` method which returns the string `world`. A GraphQL query is performed against this schema with the resulting output printed in JSON format.

and

For more complex examples, refer to the [examples/](https://github.com/chris-ramon/graphql/tree/master/examples/) directory and  [graphql_test.go](https://github.com/chris-ramon/graphql/blob/master/graphql_test.go).


do you touch here?


It can't pass the PlayerFishEvent to CommandHelper in versions based on Bukkit 1.7.9.


I was thinking the same but didn't want to go down that route just yet.


@eldy : here you have removed the raw margin / net margin setup (see my other comment here : https://github.com/Dolibarr/dolibarr/commit/c3b74e66ffc7f04f214884e271f11bbfd2c46e80 )


Nice! I look forward to hearing about it over lunch!

On Wed, Nov 4, 2015 at 4:16 PM, McBrainy <notifications@github.com> wrote:

> Word Ladder solution accepted!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Vendea/Programming-Team/commit/e163a074bcea9fc742fa48d21052328aeee2b9d1#commitcomment-14196968>
> .
>


close #479


Although this is a nice spot to capture the current bug ( #204 ).


@eldy : see also my comment here : https://github.com/Dolibarr/dolibarr/commit/1485ead215145c5afda1edce4f88ac16e928c6ba


That's even better. I'll adjust it today. Thanks for the idea!


/cc @pierre I added some review comments


I think the problem is that one of the nodes in the dataset got merged and no longer exists.  Not sure if the review item is supposed to be updated when this happens.


at least it doesn't hurt consensus.

Also, shouldn't have caused any problems yet, there's nothing user-facing that looks at the coveredfields element.


I missed adding it when I created the function. Copy paste mistake.


Took all the Sass and scss related stuff out of this one, and instead included the .css file generated from that .scss. Here's a video capture of how the responsive React menu is working: http://1drv.ms/1Qg7fyC


Gedaan, zie commit 0e28516.


@arosslau The original commit that excluded dots was https://github.com/capistrano/capistrano/commit/a95e44815229fe7c549b14d2245f7d6f70b8f532#diff-262ecea279f7e31b12cfebdec4bc6b36. I would be open to allowing dots (or adding a way to disable this validation altogether), but I'm also not sure why dots were prohibited in the first place. If you are using dots and have no problems, then I guess that is evidence that we should allow them.

You may also want to comment on this thread: #1512.


No Paul, We can not get more details. Because this is all PHP Exception handling returning US.