Hi,

Some things you can do out of the get to bring your tutorial up a notch - figure out how to represent commands or code in markdown, then set off accordingly the things the reader should be typing on her computer. Some embedded screenshots might be a good idea (there are lots of markdown cheat sheets around); perhaps also a sample document that you can take your reader through as you convert it to various output formats. Concerning academic writing, how does Pandoc deal with citations? Regarding YAML - it's not that its implementation is unclear, it's just you haven't sussed it yet, right? If it was unclear, the computer couldn't use it. It just may not have been translated well yet from computer-dude-userese into humanitiesjargon.


I guess you should use the following code:
int numToDiscard player.getAmount(0, player.getHand().size(), "Discard how many cards at random?", game);
player.discard(munToDiscard, true, source, game);


So that's not it. The additional lighting operations are being queued during LightVoxel, from normal propagation. I'm not sure why it behaves differently than the server. Will look more into it later.


pokemon taste good


I don't think this is right.


Hi,
If you're looking at this, you'd be better to go look at this https://github.com/digh5000/student-tutorials/commit/a22917ce248d9166c3a288677f41dff28662482c#commitcomment-14617021 instead.


@boggle what was the reason for this change?


can we have an `assert()` here?


为什么要throw?
···
$this->options = (array) $options;
···
即可。


I'm not sure this is the most up to date version. Perhaps it can be delete from the repository. In any event, see https://github.com/digh5000/student-tutorials/commit/a22917ce248d9166c3a288677f41dff28662482c#commitcomment-14617021


@mpaciore - z jakiego powodu to zostało dodane (jak i w innych metodach)?


I'm trying to better understand why you received this error and I do not.  I'm doing all my work in Python 3.4.  Are you perhaps using 2.7?
Side note: The [Jupyter notebook](http://jupyter.org/) is an awesome tool for data analysis and works very well with this module. I highly recommend it if you're not already using it.


git fetch origin
git checkout -b Sebastian2312-fork1 origin/Sebastian2312-fork1
git merge master


This was the comment from Crucial Web Host support:

The fix we put in place for you was to change the way bash interprets "php" and treat it as the absolute path to PHP 5.6.

When you run ```bin/grav clear-cache```, you are telling linux to execute the script without specifying the php binary ("php").

When you don't specify the PHP binary and then the filepath as the first argument, you leave Linux up to interpreting the binary to actually use.

In your script, you are influencing the decision to pick PHP 5.3* because your first line is:

```
#!/usr/bin/env php
```

You're basically telling it to use the PHP 5.3 binary at that point (which is the default version of PHP on a cPanel server).

If you want to have your bin/grav script actually use PHP 5.6, you need to change that first line to:

```
#!/usr/local/bin/php-56
```


LGTM


Sorry, it was my mistake. I made a stupid error in the code. Everything is working fine with the settings.


typo. and better off putting "number of hard links for this object"


Thanks for this!


buildSql 将会是你痛苦的源泉！


awesome!


Hi,
One thing to take this up a notch - why not embed all of the images you want the reader to see into the text? Also, can you figure out a hack to get all of the network data out of trailblazer into another program? (Hint - either figure out how the code stores the data, and where; or use your browser's 'inspect element' tool to see how that data gets passed to the html. You can always copy & paste that information elsewhere, then perhaps turn it into a list somehow... he said, remembering last week's conversation with Ian). It might be worth considering the ethics of that as well. Who owns this data? Does it get passed back to trailblazer hq? etc.


missing package


Wait, is this the patch that went into GAP or the one that goes into HPC-GAP?


Alignment issue here. The 'should' form should (haha) start two characters right of 'it', like if/let etc, and unlike with functions, which should line up on their first argument.


@bryk Any idea how to dynamically define in jsdoc that $scope has property labelsForm? Currently i'm getting error that labelsForm is not defined on angular.Scope.


one two three


I do not have permission. I think @phi-gamma or @eroux can do.


So I considered it. But the line is comically huge and I did not wanna swamp the test file

Considering how little of it I actually use I can change it to a truncated api call (just the section of the api I use)


Thinking about it, this shouldn't be checking what InfoRequest is doing at all - it should be checking what it's sending to InfoRequest. And the equivalent InfoRequest spec should be checking what's being returned instead of what query's being sent.


Should it be private if we are using angular getter/setter?


arbitrary


yeah, I can do that.


four fivth sixth


kk, work practice bleeding into personal projects. We pin everything as we have been bit a few times by upgrades in internal requirements


i like devin


typo


devin i bae


@bryk Should it be label.value()?


GitHub has a serious problem with that.

![image](https://cloud.githubusercontent.com/assets/187030/11399919/e00ca76a-934f-11e5-9147-82315cf92aa7.png)


Well done


not only applications, it may be a domain


for plugins.


Viva cheguei agora ao computador para ver com calma. Eu não retirei o authorship, está com o teu nome na descrição.

" * drivers/cpufreq/cpufreq_blu_active.c
 *
 * Copyright (C) 2010 Google, Inc.
 * Copyright (C) 2015 engstk (changes for blu_active)"

Eu ainda demorei uns minutros a colocar o resto para ficar compativel com o kernel do Oneplus. O commit é exatamente igual? Obrigado, Abraço


ここら辺　空行入れたほうがよい！


FYI @alexcjohnson


Tu vois une raison de ne pas mettre simplement des properties "public" sans getter/setters ?


lol, I just glanced at the contributors list for the project and updated the readme. 25 lines is still a contribution ;)


Maybe it will be better to add the BufferedReader into a try() segment available in java 7 and it will do the work for you


Oh, I meant more to the fact that @mickelsonm looks to have contributed.


Thanks @jogness that's included in this tree:
https://github.com/RobertCNelson/ti-linux-kernel/commit/fb8f164e2cbc85b604d4ba20524bacde8761e15d

This tree is: v4.1.x + ti-linux-4.1.y + beagleboard.org cape-manager..

(the v4.1.x + ti-linux-4.1.y is re-synced weekly)

Regards,


Hi Richard,

One thing you can do to bring it up a notch might be concerning your sound files. Github won't play the sound files because they're sound (otherwise, github would soon become a kind of music swapping service), but you could put them on soundcloud.com and then link there; another option to explore is https://soundcite.knightlab.com/ which allows for some funky stuff (see for instance https://rblades.gitbooks.io/pembroke-soundscapes/content/chapter2.html which is markdown with soundcite converted to html via pandoc). It's also worth pointing out that you *can* use html in a markdown file - you can mix both kinds of markup in a .md file (but not the other way around).


Maybe he's moonlighting.


Hola Ariel,

Si me gustaria participar en el refactor ya que me gustaria entender tu app mejor. Solo disculpa que esta semana, y parte de la que viene, estare demasiado ocupado y no tendre mucho tiempo libre por causa de los tiempos festivos y mi trabajo.

Si no sera muy tarde, la proxima semana intentare aparecer en el chat. De otra manera, vere la documentacion disponible en ese tiempo.

Solo disculpa que, aunque si entiendo PHP y Laravel, no soy experto en ninguna manera y sigo aprendiendo.
Entonces, intentare ayudar en lo que puedo y te agradeceria tu opinion tal como en la del commit de tu refactor.

Saludos!


Just for the sake of simplicity there I would prefer:
```js
addButton.disabled = false;
displayButton.disabled = false;
```


oh yes


:smiley:


Seems weird to have a NotManagedConnection that is a ManagaedConnection


I didn't feel it'd be useful enough for a website as simple as this, and I already had Google Analytics.
Heap is awesome though!


Its a public repo :+1:


opened https://github.com/elastic/elasticsearch/pull/15019


Since there are just two branches here, I would consider using if-let for this. (That might not be an exact fit, it's just a thought.)
http://clojuredocs.org/clojure.core/if-let


You committed the diff markers :-)
But don't worry, I'll take care of that. Typically in a case like this, you'll want to edit your latest commit. To do so, edit your file, add it with `git add <file>` then run `git commit --amend` to merge your changes in the latest commit.

Where Github fails, is that it teaches you to `push --force` on your branch, in order to propose a new version, but you get the idea.


@usama49 OK that should do as an example. Actually I had envisioned a custom Java class for this datatype that would reuse the regular expressions declared in https://github.com/daisy/pipeline-mod-braille/blob/master/pipeline-braille-utils/css-utils/css-core/src/main/java/org/daisy/pipeline/braille/css/Query.java. But don't worry about it. I might change it at some point.


Where are the sources for this doc kept?


Didn't your error happen in the DWChannel.scaled() method?  I don't think your changes have addressed this.  Maybe we should check for a negative count after DW.DWGetScaledSamplesCount(self.index).


@petebacondarwin, this final implementation is little bit different that the one in the PR:

If `timeout` is non-numeric, then cancellable will be false. In the PR, it would be calculated as if `timeout` was not specified. Was it an intentional change ?


You dont need to include it manually. Just use:

`bower install plotly --save`

and it will be added to your bower.json automatically.

After that the depency block in my bower.json looks like this:
```
"dependencies": {
  "plotlyjs": "plotly#~0.0.2"
}
```


fml


What is your opinion on type checking? e.g. if section is None, ...


@lizconlan no, that's not quite right - back to the drawing board with better/more realistic tests.


Mui thanks! :)


@mkonicek should make a pull request to support load font file from file system , since the Android framework is supporting that. After that we can load extra typeface by downloading font files at runtime.


It's basically the .clone function, but I renamed it. The subject changes, so it's not a full clone. https://github.com/bergos/simplerdf/blob/master/index.js#L157


늘 느끼지만 커밋 메시지랑 내용을 거의 일치하게 하는게 은근히 어렵네요... ㅠ_ㅠ


OK


You're downgrading the dapp styles ;) pls git pull push merge commit base


FMD can't be started in version 0.9.24.1, 32 and 64-bit. Unable to delete FMD.exe then because it's "open in System".and hangs Windows Explorer.


implemented at 69cbdff5ff4b3317f3e6051380cf4e136517d61a on #1786


Be careful with this....this may mess up the Recents icon when rotated.

Just a heads up....


true. fixed


Did you add an svg source in src/main/svg?


Why did you remove the stonecutter?


Better bind to controller, not to scope. Then in the controller have:

`/** @export {<type>} Initialized from the template. */
this.labelsForm;


It's worth reading up on propTypes in react, you get much better feedback about what data is being passed to your components.

It's also a cheap way of documenting what props are expected from it's parent.


@pynicolas We need update message to be compliant with RSPEC. I've created ticket for that https://jira.sonarsource.com/browse/SONARJS-560


I think this went into GAP, I'm not trying to merge it into HPC-GAP?


Definitely label.value() vars ending with _ are private. Compiler should complain here.


@adammurdoch: can you please review this? It's not obvious why previously it was forbidden from a `@Managed` type to call a super-constructor with arguments. I tried to find some explanation in the history, but couldn't.

Do we still have this restriction? If so, I'll revert this commit. If not, I think the simplification makes sense.


menu fait pour les gamePanel


Yes. What's more. The getter should be `@export`ed in order to use them in templates.


Wherever possible use camelCase in Javascript. Of course the backend server uses snake_case, so gravitate towards having one (or as few) place/s that makes that reference to the snake_case form - after that it should be changed to camelCase.


@majianpeng or you can check against `-EACESS` if `getuid() == 0`.


And what is the commit associated with 4.1.13-ti-r33? Where do I find this information?


Это здесь не нужно, сессию можно и без инета создать


Это здесь не нужно, getUserMedia можно и без инета вызвать


@petebacondarwin, won't this add the method even to non-instance call return values ?
Was this change intentional ?


This probably should drop the parentheses, right?


TeamCity pull requests :: netty [Build 743](https://garage.netty.io/teamcity/viewLog.html?buildId=3597&buildTypeId=pulls_netty&guest=1) is now running


@MrApocalypse Appreciate the tip, but we don't have any navbar customizations in DU currently. We haven't really decided what we want to do on that front just yet.


I got it from @vantu5z on:
https://github.com/gramps-project/gramps/commit/3b1687143df7ebe4d849361e55147ab6466faf55#commitcomment-14321446

Replaced current ru.po from gramps42 git repo, with the new one,
then made a simple "$ git diff" on a "read only git repo"!
Only pasted the (possible) related part.

Will be home this week-end (right access to git repo).
Should I commit something?


Why is #215 the latest release that is stable?


input latency seems to be reduced/eliminated for GB, GBA, Sega and Nes, but SNES has not improved.


Wording doesn't seem great at the beginning, would it be better worded as follows:
>To be able to send notification emails, enable the **SMTP** settings, as well as **notifications**

I also feel that the notification checkbox should be below the SMTP settings, as you need to fill that in first, before you can even send out notification emails.

Just a thought!


Could you move this up to line 166 so that it's next to the other section that sets up the testServer and add a comment to explain what's happening here?


Using jQuery in react is like using a shovel when you have a bulldozer, wasteful but also an anti-pattern - since React is the person in charge about what's on the DOM. Going so far to say that 'resetting' the values should be done with props or state.

Example: https://github.com/OpenFn/core/commit/9b8a5f653586b369929b0a4ff3d0a334036a839d#diff-95f3bc1113c9ce73770574763c3c759bR43


is that still needed?


Тут нужно не bool возвращать.
null если все ок и error если не ок
Можно по примеру чата формировать еррор
https://github.com/QuickBlox/quickblox-javascript-sdk/blob/develop.webrtc.QBWEBSDK-161_review/js/modules/qbChat.js#L1082

вынеси вообще эту функцию в qbUtils.js и дергай в чате и в webrtc


uh huh honey


ooooo you touched my tralala


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6799](https://teamcity.mesosphere.io/viewLog.html?buildId=80926&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:08


[BeheerhandleidingMonitoring_vJAMB.docx](https://github.com/CTMM-TraIT/trait_openclinica_selenium_scripts/files/43965/BeheerhandleidingMonitoring_vJAMB.docx)

Hoi Jacob, bijgevoegd wat aanvulling en opmerking
m.vr.gr. Jeroen


Yup - I was seeing the blocks being interleaved probably because the default deferred queue uses a concurrent - not serial queue which is fine for the default but not what I wanted in this case. I'll investigate a smarter concurrency pattern here instead of serially/chaining these calls together using the semaphore approach we talked about last night.


@nychitman1 Understood, like I said, it was just a heads up.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6804](https://teamcity.mesosphere.io/viewLog.html?buildId=80982&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:33


Really this is any jre 1.8, not just openjdk


Actually, the devs can decorates this extractor instead of extending it, and then simply inject the `pomm` in their decorator, so IMO a `getPomm` method is not useful at all.


What is the -* doing here?


This broke building on *nix since you started using libiconv without updating the *nix Makefile.


This makes me :D - I like it.


Sale, lo haré hoy a las 6:30pm


Ok, we are using the timeout function in order to wait that other functions like "initHeader", "initBody", "initSearch" are completely done


To my taste, decorator was better, just the implementation could have been slightly improved. I would like us adding a decorator later on.


Certainly


As discussed in IRC let's use /(?:#(\d+)|Issues?\s+(?:(\d+).{0,2})+)/gi . (I have no objection to increasing the {0,2} to match 3 or 4 characters if you like.)


I don't really like having the random booleans on the constructor.

Could we change them to be setters? Or maybe a list of options?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6805](https://teamcity.mesosphere.io/viewLog.html?buildId=80983&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:47


In general unless you need to create a circular dependency, don't put imports inside functions.


Sure. Maybe `serve-file`?


Hola, según yo ya está en ese folder, lo unico que se creó en la carpeta tbtaf fue un archivo "trash" que no sé de dónde salió pero lo pienso borrar hoy


I'm curious why you're flipping this language around. Is the current description confusing?


So you are saying that we should accept a `timeout` that is non-numeric alongside `cancellable: true`? That seems a strange mix of deprecated and new functionality...


Hi, is there a way to actually get it to only calculate once like apparently it used to?

| - POST TITLE
| - CKEditor body

If post title expands I want it to use the original position (just above post title), not place the toolbar in the middle of the expanded post title.


@MrApocalypse https://media1.giphy.com/media/zrvFl1IDvy0PC/200.gif


To tak naprawdę mój commit, zmienił się autor po rozwiązywaniu konfliktów przy rebase.

Co do pytania, linie 394, 409, 412 ten sam plik i commit.


Right! Sorry. It should be `if (!isInstanceCall && cancellable) {`


Where is this used?


Same as above sorry


Does dpkg need sudo?
Should the curl go to PWD or tmp? I'm ok but just asking if its reasonable to assume that PWD is writable.


Reviewing this in the abstract as I don't have much awareness of anything outside this code looks fine to me. :+1:


Зачем нам тут модификатор? В тело ссылки можем добавить текст, например, `×`


Procediment per a instal·lar el nou `burcat.py`:

1. Supuso que teniu el directori  `therompy-0.3`

2. Dins d'quest directori canvieu `burcat.py` pel d'aquest commit.

3. Al nivell de `thermopy-0.3` feu:
```
 python setup.py install
```


отзывы


конкурс


You're right! I have modified the commit and I think that print is used
everywhere now.

On Tue, Nov 24, 2015 at 09:45:25PM -0800, Tim Jenness wrote:
> Only some of the prints were fixed unless I'm misreading things on my iPhone.


Why is this here and the raw_html is also set to the same value? I assume overriding render_basic means this template is never actually used?


I'd added a dependencies_only option earlier to facilitate a development environment where you are going to run from source but not binary. Could you break this out so that redis, etc are covered by the dependencies part?


@bddbot  please build


@malirod, we already have such task named "Singletons removing" so I don't think we have to create another.


элемент элемента?.. Такого не бывает по БЭМу


может, это элемент блока?


@biyeun is this supposed to be a style tag?


please also remove this "Enter to Continue"
@nakamurameijin


and for some reason it worked so I didnt bother changing it d:

Will do


does this clash since it gets added to the compress tag?


для чего модификатор?


You're right! I have modified the commit and I think that print is used everywhere now.


It looks like this method is unused. Should it be removed now that you added {{getApiJar}}?


Hi, I had a question about an item here and another project also, could you email me at testmega00@gmail.com  ?

Or give me your email so I can email you, thank you.


you need to escape the parentheses :) (it's a regex)


Also, partially fixed in new commits


 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/49c89a3b884e7f75bbda6e31db90d987c5340658/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/49c89a3b884e7f75bbda6e31db90d987c5340658/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/49c89a3b884e7f75bbda6e31db90d987c5340658/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/49c89a3b884e7f75bbda6e31db90d987c5340658/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/49c89a3b884e7f75bbda6e31db90d987c5340658/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


@proteusvacuum this was the only way i could think of somewhat reliably testing for inline script tags. it ended up catching this: https://github.com/dimagi/commcare-hq/commit/a516fa4d096c9afc066953c56fb7011a259ed914


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6807](https://teamcity.mesosphere.io/viewLog.html?buildId=80990&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:56


Thank you... It's most likely that I broke this a few days ago... sorry


deuxéme fonction de test


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - i386-Windows-7-VisualStudio-12: OK (1961 of 1973 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.39%25-yellow.svg)


and while at it, we might as well put it together with the hack above on the same file!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6808](https://teamcity.mesosphere.io/viewLog.html?buildId=80991&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:52


SanitizerFixes (DeadParrot) - i386-Windows-7-VisualStudio-12: OK (1971 of 1971 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


you misspelled
![image](https://cloud.githubusercontent.com/assets/6706068/11400656/9707434c-935c-11e5-8bc2-97abe15650a3.png)


Hi, I have a few questions about some items in this project, would you mind emailing me at testmega00@gmail.com  ?

Or if you could give me your email I can email you ?

Thank you


It is there. https://github.com/bedatadriven/activityinfo/blob/production/ui/icons/src/main/svg/icomoon/close.svg


That's a good point. I'd almost treat this as a bug in django-admin, that it treats `None` as the string `None. Ideally I would create a `list_filter` method literally doing:

```
def note_column(self, obj):
    return obj.notes or ''
```

I like to be explicit with database values, and if you have `None` in the database, it should be `null` and not an empty unicode string. On the other hand, this detour is so much overhead I'd keep it as is here.


This is weird, and I learned something new! :+1:


```
/home/travis/build/SpongePowered/SpongeCommon/build/sources/main/java/org/spongepowered/common/registry/CommonModuleRegistry.java:248: error: incompatible types: cannot infer type-variable(s) T
            .registerBuilderSupplier(ValueFactory.class, SpongeValueFactory::new)
                                    ^
    (argument mismatch; invalid constructor reference
      SpongeValueFactory() has private access in SpongeValueFactory)
  where T is a type-variable:
    T extends Object declared in method <T>registerBuilderSupplier(Class<T>,Supplier<? extends T>)
```


Very good commit thanks a lot amdaboss for your contribution. You're the best element of the team.


TeamCity pull requests :: netty [Build 743](https://garage.netty.io/teamcity/viewLog.html?buildId=3597&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5291, ignored: 21 Build time: 00:17:34


@mak-ableton: missing `\` at eol


okay, fine with me.


I'm no perl-regex-expert, but from my knowledge this would match only 'Packag' and 'Package' and not 'Package' and 'Packages'.
Also http://perldoc.perl.org/perlre.html#Regular-Expressions doesn't state anything different (imo).

Regards,
Lico


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6809](https://teamcity.mesosphere.io/viewLog.html?buildId=80992&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:32


Shouldn't the pattern then be:
no-arg options: int opt_X = 0;
arg-options: const char opt_X = NULL;
?


Ah, that's a good point.


@malirod, @AGaliuzov, windows works fine with "/" slashes


`.registerBuilderSupplier(ValueFactory.class, SpongeValueFactory::getInstance)`


Why?


Also added the method build_exchange_df_flexible().


trusty is fine for me right now, but looks like your script is more general elsewhere. You hit trusty again below when you install the packages.


@bloodmc this should fix the supermixin validation across projects if you wanted to test it out.


Pete, why did you remove your "Home" repo project ?

Is it because you accidentally left something in a log ? Something maybe being PR 3.0 ?

I'm glad that I took screenshot before it was taken down.


d'aww


This should be `:service-account-id` instead of `:username`, right?


Насколько мне известно, в команде нету принятого, общеизвестного стандарта кодированию на языке Objective C, который бы регламентировал данный момент. Данный код работает корректно.

В рамках данного пул реквеста изменяться не будет.


At line 1310, there is still a 1/0.  Next time this method is used, activity links from byproducts and reference products should be treated differently.  Not complex, just, no time now.


TeamCity pull requests :: netty [Build 744](https://garage.netty.io/teamcity/viewLog.html?buildId=3598&buildTypeId=pulls_netty&guest=1) is now running


Ok, found it, and it works, but it's not as convenient and easy as it was
using the previous bottom bar 'black flag' icon.

I'm not the only one that finds this to be a missing feature, i'd go as far
as to say that, to me, it was considered as a basic way of working in
Osmand:
https://groups.google.com/forum/m/#!topic/osmand/bCb4tfKEOg8

--
Cumprimentos,
D.er Hugo Barrocas


I suppose the -n has to be removed to actually remove something ?
like :  git clean -xfd -e "/build_successful*" -e "/recently_updated"

(-n = dry run, what you probably used for testing )


nit: The aria-label is wrong here.


ditto


It's a matter of taste/implementation detail. I just wanted to make sure it was an intentional change.

BTW, the reasoning behind calculating `cancellable` even if `timeout` was a promise, is that `cancellable` could also be configured "resource-class-wide" (using the `options` parameter) or globally (using `$resourceProvider.defaults`), so trying to calculate `cancellable` whenever possible was an attempt to stay closer to the developer's intent.

Would be fine either way (as long as it is a conscious choice :smiley:)


Good


sure?


I'm sorry about all the bad indentation.  I'll be more careful in the future.


No problem will do.

On Wednesday, November 25, 2015, Schley Andrew Kutz <
notifications@github.com> wrote:

> Hi @clintonskitson <https://github.com/clintonskitson>,
>
> Before I'll review this please rebase this branch onto the upstream
> master. We've long-since accepted the dynamic config keys, and this feature
> is not using those. That will greatly affect the code being reviewed.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/clintonskitson/rexray/commit/b3cab0625320af0f848e0e33022ed1099511966e#commitcomment-14613173>
> .
>


Why not,
`elif arch.startswith(('arm', 'aarch64')):`
?


cool, thanks


Whooooot
rw


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6810](https://teamcity.mesosphere.io/viewLog.html?buildId=80999&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:53


my comment here


Is it hard to hide this hardcoded slash?


It's ok. We had inappropriate style before your commit :-) You can use this script `tools/check-style.sh` to format the code.


off_t is for files. I would use size_t here


dsf

df


Clearly it is not that easy to discover first time, but we have a plan to improve waypoint list to have sorting just there


Unfortunately this wording is a bit awkward and I fear only makes the message more confusing.  One of the participants in the original issue #3373 (like @mwcraig or @taldcroft) should comment).

In any case this change is also pretty irrelevant to the other changes in PR #4346.  It's best not to combine unrelated changes in the branch for a single PR.  You can remove this change by simply resetting your branch to the previous commit like:

```
$ git checkout <branchname>
$ git reset --hard HEAD^
$ git push origin <branchname> --force
```


Why the "/download" part has been removed from the URL? Now this function instead of downloading the file, downloads a useless XML file. This is a big breaking change. How must be retrieved the download url now?


I skipped this commit from r9_wc for now on my current staging merge as it seems to be possibly superseded by alex-ab/NOVA@77c00cf036534eded1dd2b4faf54475af9690304 from r9_wce.


you don't need 3 conditions here.
If used < (offset + size), it will be for sure less then each of them individually.


Typo that was found and removed in a later commit


Our ramdisk creates dir, ... on PDS
(It's also the stock fstab)


This is missing a few sprites, namely the reload, muzzle flash, and scope reticle. As it is now, this isn't ready to import just yet.


@bfontaine Why is `bottle :unneeded` needed in this formula? The package doesn't contain an OS X binary (only a Windows `.exe`), but it does come with the source, so it needs to be built locally. Maybe I'm misunderstanding the notion of this command — can you explain?


[Travis](https://travis-ci.org/feelpp/feelpp/jobs/93114598#L4366) failed to build everything


@jogness

https://github.com/beagleboard/linux/commits/4.1.13-ti-r33

4.1.13-ti-r33's sync/base point from ti-linux-4.1.y is: cd7dd5167fd6c64311669f2f33f27934cd71c0a0

https://github.com/beagleboard/linux/commit/cd7dd5167fd6c64311669f2f33f27934cd71c0a0
http://git.ti.com/gitweb/?p=ti-linux-kernel/ti-linux-kernel.git;a=commit;h=cd7dd5167fd6c64311669f2f33f27934cd71c0a0

Regards,


No, this part need some works. The type should match [Symfony\Component\PropertyInfo\Type::BUILDING_TYPE_*](https://github.com/symfony/property-info/blob/2.8/Type.php#L21) and for an object, the `$name` parameter provide the object class name.


I don't like this too, but this is as far as I can see the only way how we can inject a client into a plugin node level service. There is a cyclic dependency here, the node client can't be created until all transport services (transport actions, action filters etc.) have been created. The `IngestActionFilter` relies indirectly on `PipelineStore` which has `Client` as a dependency. This cyclic dependency prevents us from just injecting the Client, so we fall back to the injector hack...


![Look at that hole](http://mincore.c9x.org/3041841.jpg)


We have the same hack for Watcher. (See ClientProxy class)


Remaining space before the opening quote !


Just a really small point here. I prefer to have tests added in the same commit as the function is added.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6803](https://teamcity.mesosphere.io/viewLog.html?buildId=80956&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:08


@73rhodes "It's not easy to know if an upgrade is going to obviate an established precedent and suddenly invalidate your code."

Seems easy to me. For each new version you test it out, and if it doesn't work you fix it.


gah :)


Ah, right. Thanks for catching that!


@alex-ab please also keep in mind to merge r9_vm64 and r9_wc* as we only support one upstream branch ;-)


Is there a reason this hasn't been merged yet?


Are you sure?


I just had a broken deploy which didn't release the lock


Why adding a space here after () ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6811](https://teamcity.mesosphere.io/viewLog.html?buildId=81001&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:48


message @AnriShitko


No reason, some accident there.


LGTM


hello this my first time!


@MrApocalypse good looking out. Seems I'm lucky one tasked with bringing up some nav. I know the code that causes this to derp on cm. I'll definitely keep an eye out.


This version of CDR works well in which dist of Debian and CentOS?


Sweet :)


TeamCity pull requests :: netty [Build 744](https://garage.netty.io/teamcity/viewLog.html?buildId=3598&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5292, ignored: 21 Build time: 00:15:12


You mean install(... EXPORT) ?


That's ok in general but 'pagemap-cache:' commit tag is used in CRIU. I'll fix this.


Might be more grammatically correct to say _"...when passing boolean arguments to a method."_


wait the initkey changed?


Unfortunately, this was added to the public API in 2.9. So I don't want to remove it without a public replacement, and I don't think `getApiJar` is ready.


will be tracked in #3


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6812](https://teamcity.mesosphere.io/viewLog.html?buildId=81005&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:07:43


use default syntax for description of mandatory/optional options and arguments.


From further discussion on IRC:
Here is the set of some strings for testing.
```
Issue 2599,  2940 - Fix the presence of correct ATL version
Issue 1737 - ABP 1.3 for IE sometimes blocks navigation to the ad from Google search results
Issue 2599,  2940 - 2x something
Issue #123,  456 - some desc
Issue 189 - Implement API changes from #117, #153, #192 in libadblockplus (Closed)
Issue 189 - Implement API changes from #117, issue 153, #192 in libadblockplus (Closed)
Issue 1197 - change local copy of v8 to work with Visual Studio 2013
```
The regexp should be enough stable for some common typos like missed # for the second issue or additional spaces because it can happen in an issue without modification possibility, for instance, belonging to somebody else.
It seems the current regexp works quite good in such cases, although can look quite complicated.
[Visualization](http://regexper.com/#%2F(%3F%3A(%3F%3AIssues%3F%5Cs*%23%3F)%7C%23)(%3F%3A%5Cd%2B)(%3F%3A%5B%2C%2F%5D%5Cs*(%3F%3A(%3F%3AIssues%3F%5Cs*%23%3F)%7C%23)%3F(%3F%3A%5Cd%2B))*%2Fgi)


It's used by the EntityGroups.


One question. Why are we checking if SOL_BUFFER_FLAGS_NO_FREE is set? In my opinion if SOL_BUFFER_FLAGS_NO_FREE is set, but SOL_BUFFER_FLAGS_FIXED_CAPACITY is not, the buffer should be resized.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6813](https://teamcity.mesosphere.io/viewLog.html?buildId=81016&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:48


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6814](https://teamcity.mesosphere.io/viewLog.html?buildId=81017&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:11


I'm always happy to help @maximevaly ! Thank you!


... `hit the database when first called, not at import time.`


It's funny...reading this makes me feel like the functionality to view commit history is broken, someone doesn't understand how software versioning works, and a complete dismissal of an original contributor who helped put the groundwork in place for a project that has evolved into what it is. :smile:


awesome, thanks :+1:


Ok, I thought somehow that `@Incubating` means that we are allowed to break the API.


are these reinitialized each time the table is loaded?
the reason i ask, is that the time out interferes with the cookies being erased. I have tried to manually erase the cookies, but when the $(controls[0]).trigger(controls[0].tagName === 'INPUT' ? 'keyup' : 'change'); runs, the earlier values are reset. im trying to find the best way to avoid this, as we want the list to be cleared


It returns the same download file,
you just need to provide file's UID instead of ID


Where is #12802 ? @do3cc


What if we goto err from line 420? Please make this error handling more accurate.


quoting not needed here, as `[[` does no word splitting


quotes needed here


quotes


Typo.


This should not be a part of this commit.


Please use 'shmem: implement ...' - present simple, not past simple.


@vizanto `containium.core/eval-in` broke:
```
user=> (containium.core/eval-in "app" (prn 'foo))
foo

ArityException Wrong number of args (2) passed to: reactor/eval-in  clojure.lang.AFn.throwArity (AFn.java:429)
```


@RobertCNelson Thank you. I did not know these were tags in beagleboard git.
@leearmstrong You already have that patch. Do you have SysRq active so that you can dump all stacks (l) or all tasks (t) when the board hangs?


Well, it breaks on hosts that only have simplejson only if its loaded that why (without the try json/simplejson)


How then is that passed to the continuation in just a `void*`? We would need to pass a pointer to a length, data struct. In effect, a ts::ConstBuffer. I'll consider that.


the commit message and description are not helpful. this looks more like a bug fix than an improvement. what happened before? Which cases work now that didn't?


Done.


 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:679](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/include/chaiscript/language/chaiscript_parser.hpp#L679) Expression is always false because 'else if' condition matches previous condition at line 677. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:683](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/include/chaiscript/language/chaiscript_parser.hpp#L683) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 681. (multiCondition)
 - __style__: [include/chaiscript/language/chaiscript_parser.hpp:685](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/include/chaiscript/language/chaiscript_parser.hpp#L685) Expression is always false because 'else if' condition matches previous condition at line 683. (multiCondition)
 - __information__: [src/chaiscript_stdlib.cpp:1](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/src/chaiscript_stdlib.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __information__: [src/main.cpp:0](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/src/main.cpp#L0) Too many #ifdef configurations - cppcheck only checks 12 of 13 configurations. Use --force to check all configurations. (toomanyconfigs)
 - __information__: [src/main.cpp:1](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/src/main.cpp#L1) Skipping configuration 'CHAISCRIPT_MSVC;max;min' since the value of 'max' is unknown. Use -D if you want to check it. You can use -U to skip it explicitly. (ConfigurationNotChecked)
 - __style__: [src/chaiscript_stdlib.cpp:18](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/src/chaiscript_stdlib.cpp#L18) The function 'create_chaiscript_module_chaiscript_stdlib' is never used. (unusedFunction)
 - __style__: [src/main.cpp:169](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/src/main.cpp#L169) The function 'get_eval_error' is never used. (unusedFunction)
 - __style__: [src/main.cpp:140](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/src/main.cpp#L140) The function 'help' is never used. (unusedFunction)
 - __style__: [src/main.cpp:216](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/src/main.cpp#L216) The function 'myexit' is never used. (unusedFunction)
 - __style__: [src/main.cpp:158](../blob/4e69e5a3d2f79c340ea221443d337473d4f39efb/src/main.cpp#L158) The function 'throws_exception' is never used. (unusedFunction)


Mmmh, since cake auto sizes the buffer this is the value that let's the user get a feel how well the buffer actually is sized, no?


@evancz This commit overwrote the custom index.html with the one generated by elm-make. Is that OK? I think it loses the code that handled the JS side of the ports for focus control and loading/saving values.


Yes, I took that out during debugging to see if that was the problem.


Ahem I went too fast here; You’re right it fits in the rules we have for bottles. However I just tested it builds in 2 seconds on my machine so it might not be worth bottling here.


原有的 WT_ITEM 更符合实际需要，为什么要修改？
1 如果要保存的 value 中间有 \0 怎么办


Since this eats up the `err` everything would appear to have suceeded when it actually didn't... Shouldn't the error bubble up?


Не разу непонятно что такое res[0], res[1], а уж тем более res[1][0].
Если никак в список не запихать то можно класс создать на основе res у которого читаемые методы будут


Same here: shouldn't the error propagate?


tydligen så blev det någon bug så att github tyckte att analysarbetet enbart var en commit och sen ville den skicka en kommit gjord för några dagar sedan igen


i have a test branch with this change, because i needed the cookies to work: https://github.com/bitcrowd/bootstrap-table/blob/bugfix/filterControl_cookies_not_deleted/src/extensions/filter-control/bootstrap-table-filter-control.js


Are you having problems in this code? I was diving into this for most of the last two days. If you have questiions, shoot


@cabelitos why are you append sequential slices to a buffer instead of doing it in a single shot?
Won't it make dozens of unnecessary reallocs?

Can't you just declare the whole string in another .c and include it in this file, improving code readability?


Looks OK.  Haven't tried this.  One minor nit-pick though, cfg_error() will already append a "\n" for you.   But I wouldn't necessarily fix this up unless you have something else to change as well.


Isn't it possible to centralize code like this instead of repeating it in all files? (Just asking)

```lua
if reaper.GetPlayState() == 0 or reaper.GetPlayState() == 2 then  -- 0 = Stop, 2 = Pause
  current_position = reaper.GetCursorPosition() -- Position of edit-cursor
else
  current_position = reaper.GetPlayPosition() -- Position of play-cursor
end
```


thanks, I'll give that a try.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6815](https://teamcity.mesosphere.io/viewLog.html?buildId=81022&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:58


@jogness yeap we try to make things as easy as possible for comparison purposes!  ;)

SYSRQ is active by default with:
```
CONFIG_MAGIC_SYSRQ=y
CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE=0x01b6
CONFIG_DEBUG_KERNEL=y
```


Yes, can be done by:
```
install(TARGETS ... EXPORT ...)
install(EXPORT ... DESTINATION ...)
```

See: https://github.com/forexample/package-example/blob/cf2ea1d6a209fb9eca2ab83fdd0ac15fe4d3e807/Foo/CMakeLists.txt#L63


Thank you!


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 124](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=523&buildTypeId=XbimEssentials_XbimEssentials) is now running


`as *const i8` looks like the old behaviour, shouldn't it be `u8` ?


True. Any suggestions?


@bryk This actually has to be an array because every row needs its own object for correct validation. Is it ok?


//Este sera nuestro Proyecto Final de Programacion Web


It became a bit messy, would be a good candidate for a janitorial cleanup. There's some stuff in `lib/route/path` that could be consolidated.


I have reviewed and find this change makes sense


ws 这个库名字太短，容易冲突。需要修改


hi,

 the change you made to use the systemctl on debian 8 break the jessie that did not have systemd packages. This change without testing the existance of systemctl make the following issue:

1/ force us to install all the systemd compatibility thing and add a bunch of unecessary pacage so puppet do not choke on eahc 'service' statement
2/ see puppet choke and have it launch 'tsrat' for each service each time it launch

as solution 1 add surface of attack and bug and also risk that a future upgrade mess things up by forcing the boot to use systemd on system where systemd cannot run ( because its a inti and a cron and a syslog and a ntp and whatever next year i guess a x server too) and thereofr this change is a major issue.

i suggest to remove it or to add a condiftion on the presence of the systemd package on the line

 if ((os == 'debian' && majversion >= 8) || (os == 'ubuntu' && majversion >= 15))

best regards,
Ghislain.


About your FIXME, do we have other users for something like get_packet_type_as_string?

If it's the case, yeah, it would be better to have it in some place that could be shared between modules, like sol-flow-packet


changed.


yep, i have already done due the iscaro's sugestion


@diafygi Hey there. I've read your rules ;) I was thinking about a version focusing on simplicity and cuteness rather then focusing on the technical crowd. But now i am unsure if this is something that i should spent time on. I am bad at making things pretty without N dependencies so i am afraid i cant really help your original Readmap at this point.

Anyway, I think it is great and something we really need that SSL is so simple as buying a domain so everybody soon will encrypt their communications. Kudos!


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 124](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=523&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:21


Well, these are related to GSO/GRO packets, as long as bcake always peels these are not too interesting, except that:
"tc -s qdisc" shows among other stuff:
qdisc fq_codel 130: dev ifb4pppoe-ge00 parent 1:13 limit 1001p flows 1024 quantum 300 target 5.0ms interval 100.0ms ecn
 Sent 65985 bytes 97 pkt (dropped 0, overlimits 0 requeues 0)
 backlog 0b 0p requeues 0
  maxpacket 1538 drop_overlimit 0 new_flow_count 11 ecn_mark 0
  new_flows_len 0 old_flows_len 1
will report maxpacket, it might be interesting to be able to se whether large meta-packets actually hit the queue, no?


Nit: Could you stick to 80 character lines here and further down?


Oh I thought that he had removed you. It's my first time reading a commit graph, sorry guys amateur here.


erronius  -> erroneous


Is there a location for the dump? Nothing is logged at all on the console.


Ahh, good catch! Fixed.

On Wed, Nov 25, 2015 at 1:43 AM, Mikhail Gorbunov <notifications@github.com>
wrote:

> Seems that the [ -eq "0" ] branch is quite redundant here. The default
> exit code is 0 anyway, so I guess the following would be enough:
>
> if [ $n_failed -ne 0 ]; then
>     ... anything ...
>     exit 1fi
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/gittup/tup/commit/f0461a0c638d01b09a456e726715fa6e7c00e4a9#commitcomment-14607935>
> .
>


Here's the rest of my day....https://backlogtool.com/git-guide/en/.


@mangui - convinced ;-) https://github.com/flowplayer/flowplayer-hlsjs/commit/6da97b8580e88f58df2f29365461b96c073d3540


Danke


The sentence should have been something like:

> Defining SMTP is not enough to send notifications by email. If you want email notifications, check notifications checkbox AND fill SMTP settings

The ideas behind the split of the notification/SMTP settings:
- we can define SMTP regardless of the usage of notifications. For example we had the request to be able to use [gitbucket-announce-plugin](https://github.com/gitbucket-plugins/gitbucket-announce-plugin) without activating notifications
- we can latter on define other communication channels than just emails : SMS, gitter, twitter, ...


i'm getting
plone.app.relationfield.monkey in get_from_object
KeyError: 'from_object'
when removing a other relation item from a list


Nit: Might as well just write the `/\d+/g` directly here instead of using the issueRe variable?


Yes. It made incorrect and works incorrect.


Note used; so I'll remove it


Remettre cette ligne!!!


`install(EXPORT ...)` generates `*Targets.cmake` file: https://github.com/forexample/package-example#uml-sequence-diagram which can be included by `*Config.cmake`: https://github.com/forexample/package-example/blob/master/Foo/cmake/Config.cmake.in

If several configuration present then `*Targets-debug.cmake` and `*Targets-release.cmake` will be generated. These files included by `*Targets.cmake` automatically.


@leearmstrong should be able to dump it via: "0x01b6" looking up what key board combination that actually is..


还是提 PR 吧。。。


@bryk There is a problem with eslint check becuase it says that return value can be undefined. Actually it shouldn't but if i change return type then i have to change `this.value_` type also and then backend api. Any other idea how to manage this correctly?


Nit: Would prefer snake_case to camelCase for variable names if you're OK with that.


People are abusing this rule by swearing. Should be reverted/made so no excessive swearing.


Alt + PrintScreen + KEY


+1 but excessive swearing


key = any arrow key (up/right/left/down)


with attr_accessor, you can use entries instead of @entries


Same here. you could do "Name: #{name}\nPhone Number: #{phone_number}\nEmail: #{email}"


@bryk Additional Problem with formatting. gulp-clang-format wants to break this line before `from` and eslint does not allow that. I have disabled this for now, but we have to find some rule to make it cosistent for both.


self._fig.savefig(*args, **kwargs)


you can do when "m", "n", "d", "e"


Good point. We added this error handler because we did not assume that the promise is handled beyond the execution on the main side but now it actually flows into the extension host side and we loose the error case.


framework-version will give you the NUnit version in v3


TeamCity pull requests :: netty [Build 745](https://garage.netty.io/teamcity/viewLog.html?buildId=3603&buildTypeId=pulls_netty&guest=1) is now running


Fixed in d329aee.


Hi @davidamorimfaria ,
I had the same issue that @pdion891 had. I added missing quotes as you suggested in PR#1114 but still getting an error:

```
[root@XYZ packaging]# ./package.sh -p noredist -d centos63
 -p noredist -d centos63 --
Packaging CloudStack...
noredist
Preparing to package Apache CloudStack 4.7.0-SNAPSHOT
. preparing source tarball
. executing rpmbuild
error: failed to stat /home/t_vazqnadmin/cloudstack/dist/rpmbuild/DEFOSSNOSS: No such file or directory
RPM Build Failed
```


It's a bit hard to review it without the file diff.

On add_port_for_generated_code you may do something like

- int r;
+ int err = -ENOMEM;

And from
 port_desc = sol_vector_append(vector);
you could check with SOL_NULL_CHECK_GOTO(x, err_port)

you would add a label err_port before "return r";

I'm almost sure you're leaking port_desc doing SOL_NULL_CHECK(port_desc->name, -ENOMEM);

Please review this function error handling.


@bfontaine If it needs a compiler it's definitely worth bottling.


hey that was mine.


I think this is a great way to log the useful data of a slider without making too many events


So other packets also do this:
Handle_qThreadStopInfo
Handle_vAttachOrWait
Handle_vAttachWait


render_basic was actually removed in a later commit, but the Code Smell is still there - there should be a way for us to simply render whatever raw_html is without needing a template


Terrifying


I think the documentation for this function is put in the wrong place. This is the documentation that belonged to the original `timeRatioCooldownHeatup`.


should it be expect?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23658/testReport/) for this commit**


I see that algorithm that computes alloc size argument here is different to algorithm on lines 249, 350


downloaded from ActiveEon's (The "belonging 's ")


0x40 is not a good idea to me. Is there any decent constant for that?


@plugz I hope you don't mind :)


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8964/testReport/) for this commit**


The easiest way to achieve it is to simply hard code the method so it returns the expected value.


ActiveEon's


ok thanks :+1:


Fixed now, also made use of the _ macro...


if ``new_size`` is 0, it will work like ``free``


Можно сделать класс из нескольких переменных без методов, просто чтобы точечкой писать. (типа, res.status, res.exception, res.value).

Оно того стоит? Думаю, да.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6806](https://teamcity.mesosphere.io/viewLog.html?buildId=80988&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:07


pcm_fini does nothing on empty pmc.


1000 or 100?


Oh having $errors be global is ugly. I believe this was a way to pass back non critical errors to the user. If you look in the issue class, you can see there is a "getInsertErrors" method to return these when inserting an issue. Something similar could be done for updates.

Alternatively, we could have a "OperationResult" class that returns an overall status ("success", "failed") and an array of errors / warnings. Thoughts?


0x01b6 doese not allow dumping data. This can be set during runtime with (as root):
echo 0x1be > /proc/sys/kernel/sysrq
@leearmstrong Try it when the board is not hung to make sure it works. You are probably connected via serial, so you would send a <break> followed by t.


This constructor should be private.


Можно добавить tools:visibility="visible", чтобы видеть в дизайнере.


@borisspektor, fixed.


this works but only when i remove the
``` javascript
c.stop();
```


@leearmstrong github chopped up my last sentence. Over serial you need to send a BREAK and then press the appropriate request key. For tasks, that is t.
https://www.kernel.org/doc/Documentation/sysrq.txt


See 03ff86190424ba56bfeeec3732982b1e31f8ade5


This was a bug. See 4d17d1c


Please make macro that computes size in units of its arg:
#define BLOCKS_CNT(size, block_size) (size + block_size - 1) / block_size

si_nr_pages = BLOCKS_CNT(si->size, PAGE_SIZE);
pdirty_map_size = BLOCKS_CNT(si_nr_pages, sizeof(*si->pdirty_map));

I think it's more readable.


Странное значение константы. DisplayShowcase, например


I tried restoring the path after this line thinking that the call to initializeSSL would work since it searches the path when called with no arguments.  However that did not work for some reason that I don't understand.  Calling initializeSSL with the platform_specific_path above did work.


This should be implemented in Xwt.


We may want to get the platform_specific_path for Ruby as well


Please change "tp" -> "to" and "paritions" -> "partition"


thanks @MarcelloDuarte :+1:  that's changed now


Using the latest build the radios still don't align properly when it's inside a layout-row.

A simple demo here: http://codepen.io/anon/pen/xwobyO

I am doing something wrong on my demo?


Не надо сортировать параметры по алфавиту. Удобнее видеть их в порядке важности: key, title, summary и т.д.


wish i had an example for you, to replicate the issue we are seeing you need to have a subscription that changes the dropdown value by an event but doesn't trigger an onRender


Travis actually already sets this through an environment variable, so it should not be necessary


Please add job on teamcity that will build our artifact and put into artifactory.


That makes a lot of sense. Thank you so much for clearing things up. I have decided to write a blog post on this topic - http://www.newventuresoftware.com/blog/custom-authentication-with-azure-mobile-apps/


That's some exciting news sir!


Please change "infomration" -> "information", and bring it on the previous line so that it doesn't look like a separate bullet point.


Also VMAs sizes are always PAGE_SIZE aligned. I'll better add comment about this and remove PAGE_SIZE alignment code.


"scirpt" -> "script"


Thanks both, I'm sure we can get the source of these hangs!

I do a break and then t and it shows

```[ 3450.040507] sysrq: SysRq : Show State```

Nothing after that though or is that what you would expect?


TBH I don't really care, but if I had to choose I'd use `while(1)`


@redox this is what prevents us from using inline HTML within Markdown...
Added to fix #16 but I don't see how this is part of solving this issue's problem?

Using `element.html(val)` still allowed me to correctly paste HTML (that would be used as plain text)


Я бы весь этот код вынес в MytargetHelper.


See your code at L21-L23 in this file.


ok i [took care of both](https://github.com/doublethinkco/webthree-umbrella/commit/41879a06fea8f44876d30d6dbd3bde92566ccfee)


Is default value 1420 really needed here? Isn't it already stated in GelfAppender?


We already have a platform-agnostic ContextMenu class. No need to create a new one.


Maybe change "Updated" -> "Bug fix when updating" to make it a bit more clear?


Just a note. You use here the rule that VMA sizes are always PAGE_SIZE aligned.
So if suddenly size is 4097 then 4097 / PAGE_SIZE produces 1 and you don't check the second page for dirtiness.


TeamCity pull requests :: netty [Build 745](https://garage.netty.io/teamcity/viewLog.html?buildId=3603&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5292, ignored: 21 Build time: 00:15:28


:star:


This has already been fixed in the latest master.


И этот весь код можно унести в MytargetHelper.


En efecto, ya está ahí. Sorry, como que se maltripeó mi visor de diff en mi celular.

Saludos


No, it should dump all the task information. What about l (lower-case L)? Or can you cause a kernel panic with c? We want stack traces.


What is the purpose of first block? Isn't it a test testSendLongMessage''?


Поправил в следующих коммитах. Посмотри, пожалуйста.


Missed that one. I'll fix that.


Will fix.


А что с этим TODO? Когда будет расскомментировано?


Yeah, lol. Just noticed xD


in the docs[1] the callback handler, passed into `ob_start()` is called `output_callback`.. having consitent naming in this error msg would make the error more obvious for the php-dev

[1] http://php.net/ob_start


Почему в пакете статистики?


Céder à la facilité dans le core....


We are discussion on the wrong version of the code. The real version does not do self._from_id = intids.register(self.from_object), but self._from_id = intids.register(self.__dict__['from_object']

This is where the KeyError is coming from

This code is fragile, this is partially the fault of z3c.relationfield, but could/must be handled better here.
It should never happen that there is a RelationValue object which did not get a valid from_object set. When a from_object is set, there will always be a _from_id set.
The problem is that the from_object is only set in an event. If you use collective.solr and in turn collective.indexing, event handling gets queued to the end so it can happen, that you have an object on which was never a valid object stored on from_object.
Your problem should disappear, if you chagne set_from_object to store a marker on _from_id if obj is None.
Then in get_from_object, you check if the special marker is set, and return None if this is the case.
During instance initalization in z3c.relation.RelationValue, from_object will be initialized with None, so after that, you should be safe.
HTH


I don't think so. This empty line doesn't look better or easier.


А почему это тут не нужно?


Ok. But still it is better to fix because we can't rely on their internal implementations - this is independent subsystem, it can change. Also functions with init and deinit semantics are usually symmetric. One rollbacks work of the other. So we should maintain symmetry of calls and not break it.


Headerfältet heter "location"


Please see your code more and check out what you did. See the vmcb_state_t vm_start(vmid_t vmid)


`packages` (i.e., backticks).


As we'll have additional review iteration (by me) please fix this.


Onödigt med en exception här, scenariot hanteras ju ändå av returvärdet.


only to demonstrate that by default message is splitted on 2 parts


Nice. I was about to submit a PR for this :)


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1963 of 1973 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.49%25-yellow.svg)


Present simple in commit title please.


相应的目录也会创建吗？


I don't mind, but 'lose' was correctly spelled: http://grammarist.com/usage/loose-lose/


It works well with both tone and saturation effects in all tests I've done.


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1961 of 1973 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.39%25-yellow.svg)


This line allows us to use `android:persistent="true"` in the xml, so we can do away with a lot of initialize* functions. Should we make a base `PreferenceFragment` which sets this in its `onCreate` or `addPreferencesFromResource`?


Missing bracket? Should be ...});


I don't think we need these "*_n" interfaces


“demo"存在时，就没有任何操作了


Glömde jag skriva förut, men ID måste lagras som en sträng (innehåller inte bara siffror).


Just added this fancy git diff to my dotfiles: https://github.com/kdeldycke/dotfiles/commit/6b384a21525fb8ba1c47ea1fd69b5f77cf23c9d9

Thanks @paulirish ! :+1:


We need to set a period or deadline for vcpu when we create vcpu.
Let me know how you set/configure a period and deadline of vcpu.


Hello! Does Ubuntu 32 Bit support the Torch7? Thx


OK, I just tried my reference BBB before I have been messing around with different kernel's etc and that works fine.

When it hangs which ones are you most interested in?


No

On Wednesday, November 25, 2015, pavlovandrey <notifications@github.com>
wrote:

> Hello! Does Ubuntu 32 Bit support the Torch7? Thx
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/torch/distro/commit/9cf595075273c3dcfc792ed1fb3d5274882a332f#commitcomment-14620689>
> .
>


@leearmstrong I just realized that you probably do not see the task states because the loglevel for you console is too low. (With dmesg you should see them.) You can adjust the console loglevel at runtime with (as root):
echo 7 > /proc/sys/kernel/printk


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I have been thinking about this for some time: Don´t you guys think its time for 0.10.0? Its a whole new expansion including lots of bugfixes. I just need to start helping you more, I feel so bad for not doing it, i just can, yet :(


I would suggest to augment mng_db_object for limitting. Like this:

```
mng_db_object(DBCursor, one(DBObj)) :-
  mongo_interface(DB),
  mng_limit(DBCursor, 1, DBCursorLimited),
  jpl_call(DB, 'one', [DBCursorLimited], DBObj),
  not(DBObj = @(null)).

mng_db_object(DBCursor, some(DBObj, Count)) :-
  mongo_interface(DB),
  mng_limit(DBCursor, Count, DBCursorLimited),
  jpl_call(DB, 'some', [DBCursor, Count], DBObjsArray),
  not(DBObjsArray = @(null)),
  jpl_list_to_array(DBObjs, DBObjsArray),
  member(DBObj, DBObjs).

mng_db_object(DBCursor, all(DBObj)) :-
  mongo_interface(DB),
  jpl_call(DB, 'all', [DBCursor], DBObjsArray),
  not(DBObjsArray = @(null)),
  jpl_list_to_array(DBObjs, DBObjsArray),
  member(DBObj, DBObjs).
```


I would prefer getting this label and setting the value in code, rather than find and replacing the XML.


Hey Steve,
I don't want to backseat drive your code. But I think it might be a good idea to put this kind of code in a variant, that way it won't break while we introduce changes to OctoPi, and make your life easier. You can see a coding example and BananaPi working example at: https://github.com/guysoft/OctoPi/tree/devel/src/variants
Just thought I'd point out this before you start writing bigger things.


I didn't want to change this. I don't know how to control GIT


Most files were committed without me wanting to commit.


hey, no more public API without docs

even if there is no group defined, at least document functions you're changing / adding, please


>Aliases were added for commands
I've merged the commands that were right above each other because it's easier.

GJ. In fact they were right above each other because they were aliases and I was just waiting for 0.8.1 to merge them back into one.


Seeing the task states (t) is probably the most valuable. Hopefully the kernel is able to dump that information when you experience the hang.


Ouch. Ignorant me ! Gonna restore it


Oh.. good to know =( Thx.


so, "Cannot use output buffering in output_callback handler"?


Please write a code more completely and read your code more than a hunderds times before you are going to push your commit.


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-MacOS-10.9-clang: OK (1957 of 1967 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.49%25-yellow.svg)


tudo perfeito, "excepto"

1.4 scenarios that are high I/O bound.---> highly I/O bound

obg.

LV.


ubuntu wille error output:
a2x: ERROR: missing resource: /home/xxp/Github/elasticsearch-definitive-guide/images/icons/callouts/1.png


[_Coin Flip Test_ 112215.xlsx](https://github.com/jblasberg/Econ1970_Blasberg/files/44060/_Coin.Flip.Test_.112215.xlsx)


Refactored so that the nasty things only happen once instead of twice, but not sure if it's any better...


Please shorten commit title to 'one 80 symbols line':
page-read/xfer: add ability to open image hierarchy for shmem.


Why is it that you want to clone through `http`?
`ssh` or `https` please (https://help.github.com/articles/which-remote-url-should-i-use/).


Does a line like "post "/help" => "help#create", :as => :help" work on route.rb?


Call I add a commit documenting all functions of this file?


inline comment on encodings.xml line 3 in revision dde8


Ah. Ok.


Wait for one more small change before merge


Ah yeah great, this is much better. The initialize* functions are just leftovers from the old implementation which was backwards compatible for Android < 4.


This seems like a mistake


@RubyLouvre mmHistory 和 mmState 相互耦合太紧密，采用事件的方式更合适，就可以state单向依赖history。把mmHistory对state的调用换成一个onChange的接口，然后在state里进行实现就可以了。


The prototype here is wrong, a gboolean is *not* a bool. I'm fixing this in my rebased pull request.


My only recourse is to remove the assertion; we only know that it shouldn't fail, not what the response should be.


Looks like unnecessary blank line. Don't put a blank lines after `{` and before `}`, the prefered format should be
```Swift
someBlock {
  someOtherBlock { // no blank line here
  }
  // blank line here is okay
  someVar = someMoreCode
  ...
  // blank line here is okay
  someFinalCleanup() // no blank line at end of block either
}
```
In short, in a block, no blank line right after the start `{` and right before the `}`. Blank lines are welcome anywhere else in the body though.


成员:AutuanLiu,Yang,Xu,Hong


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6816](https://teamcity.mesosphere.io/viewLog.html?buildId=81050&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:05:06


ety


> Unfortunately I only have a few hours a week to work on this genome.
> Because of lack of time I was hoping for a "quick fix" to get the
> genome ready for NCBI. Your project seemed like the help I needed.
> When the genome is ready, I'll try it and let you know how it goes.
> I don't think I have time to be a useful collaborator but I will send
> feedback.

Sounds good. Give it a whirl and if (when) you get stuck let me know and
I'll try to get you unstuck.


post "help" => "help#create" will match the route /help to the help controller, create action. You can check which routes you have defined with **rake routes**


As per documentation only forward slashes are used for namespaces in add()

Backslashes make it very complex as users require to put them twice.


It's just too easy to make mistake, so we focus on supporting '/' only.


Great comment.


Yes you right, but we need to explain how we can do this. It's possible by default.


Also please make more detailed description of commit. Something like:
'In order to restore deduplicated anonymous shared memory we need to open its parent pagemap images. Code that opens parent pagemap images already exists for anonymous private memory. All we need to do is to remove couple checks from existing code.' ALso you need to add some words about renaming pid to id. Tell peaople why you do it.


What are you doing? Can you make anything useful changes?


I'll revert this now that we're keeping __impureHostDeps


This function not required additional memory allocations. Please don't remove it.


+ +<голова> Укладка с уценки поддерживается Писать Превью


It does not exist anymore!

> Am 25.11.2015 um 15:49 schrieb Landy005 <notifications@github.com>:
>
> Why did you remove the stonecutter?
>
> —
> Reply to this email directly or view it on GitHub.
>


This is always adding the repository to sources since this function is always called.


Present simple in commit message. Remove point in the end.


might break stuff  - such as Java extensions that do create blocks - using a home-grown block-body impl


No longer needed, because we handle VS2015 CRT allocations properly


very   good


Yes indeed. The idea was to eventually eliminate the basic-block variable completely. But it's a large refactoring so I thought it was best to commit what I had now.


yes, reads better to me.


This contains some corrections to mistakes I found in my code and should not be considered as part of the grading process.


哥，你要搞什么。。。


 Алексей, здравствуйте!

Можете пояснить, что делает строчка wd = self.wd? В нескольких словах. Спасибо.


You should use `extension` to make your code more clear. Example:

```Swift
extension BusinessesViewController: UITableViewDelegate, UITableViewDataSource {
    // Implement methods of table view
    func tableView(tableView: UITableView, cellForRowAtIndexPath indexPath: NSIndexPath) -> UITableViewCell {
        // Your code
    }

    func tableView(tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        // Your code
    }
}

extension BusinessesViewController: UISearchBarDelegate {
    // Implement methods of search bar
}
```


Do you want to mention why this is a more appropriate location in the commit message?


My compiler was complaining about needing an i8 instead of a u8/c_char here - I'd assumed we needed to switch backwards and forwards based on whether we're reading stuff in or out of the low-level bit.


You don't need add `;` at the end of line in Swift.


This got pushed accidentally while the evaluation process is going on. My apologies.


I think I'm going to leave this as-is; putting a colon in a filename seems like it'd be pretty annoying for users, and instead redefining `pool.NODE` to use periods would also look a little strange in the log messages.


>My goal is to make minetest better.

If you fix bugs and improve performance, they can't longer make minetest players become modders. If someone finds minetest and plays it, he/she quickly finds bugs which can be fixed easily, the first ones aren't called bugs yet.

fire burns down your houses not very realistic (no ashes, flying nodes left, it burns leaves even if they're not dry spreading around everywhere)
→ you search a way to disable it
→ you learn how minetest.conf works and (later) how mods add settings

playing gets boring because minetest_game is so small
→ you install mods which don't always fit correctly
→ you learn how to install mods (after learning it making mods is possible) and you learn editing simple parts of mods

minetest can be improved
→ a first simple mod from you appears which is buggy but works
→ in time lua skills get better and you edit your mods
→ by editing them the skills get better again (e.g. by finding out how tables work (fairly self evident))
your mods don't get merged into minetest because… idk
e.g. falling sand, gravel, etc making sounds when touching ground and more without (or hardly) causing lag:
https://github.com/HybridDog/falling_extras/blob/master/init.lua

so to make minetest better, you would add more and don't make it perfectly, which is the result of learning how to make mods, those mods also completely differ from each other, even if they do the same thing, e.g charcoal, sponges, compressed cobble

this way even that doesn't happen:
http://seriouspony.com/blog/2013/7/24/your-app-makes-me-fat

Of course code can be improved, but if more of this becomes done than possibilities of improving code appear, the easy bugs disappear and less people new to minetest try to make mods, don't they?


It won't assign the this when you define a function wrapper for example:
```
<div onClick={{ function() { this.classFunc() }}></div>
```
Here `this` is not bound. If you console the `this` inside, it points to the window.

The main reason for the bind is for when we use wrappers that always pass a single argument.


Double space after `=`.


Are you using libstd from 1.6?


Why replace `stabe` with `5`? Also, it'd probably be easier if you just opened PRs and we discussed them there.


actually no. If false it overwrites existing settings if needed and adds the new ones. If true, it *deletes* all the old settings and only the new ones will remain.


unack


@dachary Because pg_scrub waits for completion of the scrub I don't think ceph -w will output any of the log messages that occurred during the scrub. It would be better to have a NOWAIT option to pg_scrub. This code would have to background the ceph -w then wait for the scrub to finish and finally kill the background job and continue.


The reason is that `stable` is using 5.0.0 and nothing newer. I'd expect it to be using the latest but that's not the case.

As for the PR there are some conflicts if I try to split the patches so you know.


Coding convention. You shouldn't use upper case for constants.


Sounding great! This project is coming along well.


"I'm not sure if this way of deduping is compatible with old type images.". With this line you say 'I haven't checked on my own. Danger! I haven't put enough effort to provide patch with the best quality I could. So be careful about the whole patchset.":))
Why do you think that it can be incompatible? Please add your opinion to the description or tell it to me here.


Blank line.


well this function will dump false possitive memoryleaks then (that have not been previously resolved) :cry:


nice usage of `??`. ;)


> The reason is that stable is using 5.0.0 and nothing newer. I'd expect it to be using the latest but that's not the case.

I see, `5` makes sense then.

> As for the PR there are some conflicts if I try to split the patches so you know.

Ok.


ack


Blank line


Seems easy to fix with some extra quoting.  I'll do that.


antipattern:
unnecessary named views

justification:
This is a matter of taste, but I generally avoid named view where an unnamed `<ui-view/>` will suffice.  Your three states `auth`, `landing`, `history` can all target a single shared unnamed `ui-view`.

Named views are great for defining a toolbar section (for instance), then overriding that toolbar section when a child state gets activated.

created on antipattern.io


Приложение прошло все тесты и справляется с заявленными требованиями.
[TestResults.pdf](https://github.com/YegorChihchin/CheckRealPrice/files/44083/TestResults.pdf)
Дальнейшее расширение функционала возможно с помощью добавления категорий товара и подробной информации


const now


If you do not any special thing in the `override` method, you can remove it.


no need for node size here


Having the function name as xmldb_mod_morsle_install results in the below error message when initializing phpunit.

$ php admin/tool/phpunit/cli/init.php
-->mod_morsle
PHP Fatal error:  Call to undefined function xmldb_morsle_install() in /home/gedion/prj/moodle/git/docs/lib/upgradelib.php on line 693
PHP Stack trace:
PHP   1. {main}() /home/gedion/prj/moodle/git/docs/admin/tool/phpunit/cli/util.php:0
PHP   2. phpunit_util::install_site() /home/gedion/prj/moodle/git/docs/admin/tool/phpunit/cli/util.php:150
PHP   3. install_cli_database() /home/gedion/prj/moodle/git/docs/lib/phpunit/classes/util.php:440
PHP   4. upgrade_noncore() /home/gedion/prj/moodle/git/docs/lib/installlib.php:490
PHP   5. upgrade_plugins() /home/gedion/prj/moodle/git/docs/lib/upgradelib.php:1641
PHP   6. upgrade_plugins_modules() /home/gedion/prj/moodle/git/docs/lib/upgradelib.php:427

Fatal error: Call to undefined function xmldb_morsle_install() in /home/gedion/prj/moodle/git/docs/lib/upgradelib.php on line 693

Call Stack:
    0.0002     243944   1. {main}() /home/gedion/prj/moodle/git/docs/admin/tool/phpunit/cli/util.php:0
    0.1805   24028208   2. phpunit_util::install_site() /home/gedion/prj/moodle/git/docs/admin/tool/phpunit/cli/util.php:150
    0.1817   24030176   3. install_cli_database() /home/gedion/prj/moodle/git/docs/lib/phpunit/classes/util.php:440
    9.0132   35610104   4. upgrade_noncore() /home/gedion/prj/moodle/git/docs/lib/installlib.php:490
   11.4335   36295680   5. upgrade_plugins() /home/gedion/prj/moodle/git/docs/lib/upgradelib.php:1641
   11.4335   36296928   6. upgrade_plugins_modules() /home/gedion/prj/moodle/git/docs/lib/upgradelib.php:427


Please remove `;`


About TODO. Do we need to reset soft dirty bits after restore of pages? I don't know why we need it.


do we do an additional indentation here? I usually don't I think...


the quoting can be done by using `pipes`:
```python
"cd %s" % pipes.quote(os.getcwd())
```
I think. That's what I used in `sconsUtils`.


unack, closing brackets should be in the line above


In the last 5-6 commits, I made sure that the block api itself is unchanged. Ideally, extensions shouldn't really be messing around with JRuby internals like BlockBody, but I am curious to find out if there are extensions out there that are doing this.

In the coming months, I am going to make a fair bit of changes to the BlockBody interface (and hopefully eventually get rid of that class altogether). More code will migrate into IR land via instructions so they can be analyzed and optimized away. There is too much unnecessary block-invocation overhead that I want to get rid of.

So it is good to surface any of these extensions now and have them migrate to using the Block API only.
If really necessary, we can deprecate the old signatures and add them back temporarily for backward compatibility.


So if we're embedded in an iFrame, with a working iFrame phone, but it's not LARA or DG, then we won't log any messages?

Perhaps refactoring so that there's a single iFrame phone is outside the scope of this, and that's fine, but it seems like a pity that there isn't a generic way to send events to anyone who might be listening.

Currently both phones expect a `codap-present` or `lara-logging-present` message, or they won't be functional. I could see having these flags for stuff that's codap-specific or lara-specific, but logging seems like a generic activity (and we send the exact same message with the same format to both).


This line is unnecessary.


This is still probably not the final list, but it is close enough for now. Still have to update the TM learnsets to reflect this and use the tmlearn macro.

I may end up moving some of these around in terms of where you find them, and I may replace some more still. Not sure yet. I'll also be adding Move Tutors later, which will cover more of the new moves and such.

I'll have some NPC text to fix too, but I'm gonna hold off on that for now.


Waow, good job! I'll fork it now.


Did we send a PR to the maintainer?  We should avoid forks whenever possible.


ack


Not now, but we should start adding tests for this kind of things (frameRange, numFrames, etc)... it would be easier to identify potential regressions


Looks like logic in this branch is broken now. That should be fixed in some way.


i'll remove it in the next commit.


I'd rather shorten this comment so it fits into one line


Just now noticing that this commit obliterated some things. I'm going to do my best to restore.


I'm currently on stable, 1.4; that'll be the issue then.
I'll next get a chance to play with this tomorrow lunchtime, so I'll switch to 1.6 and see what happens.


Invalid change


More discussion: https://github.com/jbosstools/jbosstools-discovery/pull/279


revision comment


No need to check for _dataSourcePtr before using it here?


This broke slim by default. I will write tests


Created [DM-4420](https://jira.lsstcorp.org/browse/DM-4420) to address this later.


why?


Great, thank you Elena!


From line 178 to 184, you can use
```Swift
if let filterViewControler = navigationControler.topViewController as? FilterViewControler {
    filterViewControler.delegate = self
} else if let detailViewController = navigationControler.topViewController as? DetailViewController,
        indexPath = tableView.indexPathForSelectedRow {
    detailViewController.selectedBusiness = businesses[indexPath.row]
}
```


I'm just going to switch these to use `f.write(...)`.


Should not use double blank line to separate you code.


@barik111 Why you did not use the Spring test support? http://docs.spring.io/spring/docs/current/spring-framework-reference/htmlsingle/#testing


OK, so it just hung!  However I cannot get it to respond to any of these at all like when it was booted :-(


Invalid change. Restoring, with tests.


@ngraef - yeah... keep me in line!  LOL


You can also remove 2 override functions if you don't do any special thing in them.


Double blank line.


Did these changes maybe get added by accident?


Atualizando


Flexbox masta!


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1433 of 1433 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@leearmstrong by default we have "quiet" enabled in /boot/uEnv.txt, wonder if that's hidding something?


I'll convert this to use `print_function`.


Using md5 is not a good solution to hiding the version. Either salt it with something secret or don't use app version.


@kares if you can find an example of someone making their own blockbody or even how you might try and search for that I would love to see it in the wild.   Worst-case is we add back the deprecations (at least for now).


Nice finding, we can also bring it to here.


ref #1164


I am almost sure... Because this code was written with assumption that all the pages are stored in fd_pg without parent images. But now parent images exist. I've looked inside punch_hole. It doesn't look like it works with parent images.


At least for right now yes. I've prototyped all of these changes, just need to un-prototype them.


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (899 of 899 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-26.4%25-green.svg)


As I said earlier you can remove rounding to PAGE_SIZE.


@aqueos I filed https://tickets.puppetlabs.com/browse/PUP-5548 and will look into a solution.

Thanks!


Your code from line 29 to 41 is okay, but you should use `if let` to unwrap `input`.
```Swift
if let input = input {
    // Handle switch
} else {
    return YelpSortMode.BestMatched
}


It's already added, check primary repo, mate)
https://github.com/glebmachine/postcss-cachebuster


Excellent tests!


Ah so we do, removed and rebooted the unit.  We must able to capture this! :-D


Topp


Can someone add the documentation to these files? There is no link documented anywhere!


This will lead to having an error message at the end of each standalone job manager log, no? Maybe it's OK...


antipattern:
authentication checked inside controller (not using resolve)

justification:
When using a router, it's best to let the router handle authentication checks. Do this using a `resolve` which asks a service to return a auth promise which resolves if auth'd (or rejects, if they're not authenticated).

```resolve: {
    authData: function(Auth, $q, $state) {
      var authData = Auth.$getAuth();
      if (authData) return authData;
      $state.go("auth");
      return $q.reject("redirecting to auth state");
    }
}```

references:
https://github.com/angular-ui/ui-router/wiki#resolve

created on antipattern.io


Should we merge this to 0.10.2 as well?


I tried this on my own fork using my own token and got the same results. You can see results at: https://travis-ci.org/proplanr/polymer-starter-kit/builds/93174301

I will experiment using git commands instead of using `build-deploy-gh-pages` on my fork.


LGTM :+1:

Good looking out on the awesome spelling skills :)


:pray:  :pray:  :pray:


To be clear, this was an old commit that I'm commenting on, it's not a pull request. I was just trying to understand why the "less" file looked like a Css file that had already been compiled, and traced it back to this commit a couple years back.

> On Nov 24, 2015, at 9:16 PM, Richard Duivenvoorde <notifications@github.com> wrote:
>
> Hi Michael,
>
> well that was not intentional, but just because of the lack of knowledge and time :-)
>
> plz use the less file, both should be up to date by the way (small tweaks I did both in less in css if I was in a hurry....)
>
> For this to accept I need more time. There is a lot to check then...
>
> Can you describe what you tried to do (with a lot of edits?) or is it just a different less executable version?
>
> —
> Reply to this email directly or view it on GitHub.
>


Ok, I understood problem. Will make auto-dedup in separate commit.


this can actually be an interface ;)


but OK to leave for now


Title: Present simple, remove point.

"Because anon shared memory dumping using same mechanism as anon priv memory
dumping we can also use same manual deduping mechanism" => (to something like this)
We use the same dumping and restoring mechanism for anon private and anon shared memory.
Because of this we can implement manual deduplication of shared anon memory the same way we do it with private anonymous memory.


This code change is now ineffective when register .g is zero.


I've left this as is, but added one more code comment and switched it to use the new dict comprehension syntax, which I think makes it a bit more clear.


It does mean that, and I considered removing `getApiJar` and `setApiJar` without replacement. But this seemed a bit drastic, since there would be no public API for accessing the api jar file. So I left things as-is until the new API is more stable and ready to promote to `@Incubating`


description:
neither => either.


maybe you should call ``isCrtStartupAlloc()`` to properly initialize ``m_status`` before starting the dump loop, but that will go through the call stack twice :disappointed:


@DavidBerkut  Beautiful livery Berkut!
@legoboyvdlp Look at this one


gputop-web-worker.js is a bit special, compared to these other JavaScript files, and shouldn't be listed here...

The way the web worker gets launched, is that within gputop-ui.js it does:

```javascript
var ww = new Worker("gputop-web-worker.js")
```
which effectively spawns a new thread that runs the code in gputop-web-worker.js, which is different to the scripts listed here which will be executed in the pages' main process.


yes, it's basically interface, but ATK doesn't currently use interfaces, so ...


@Tuuleh :+1: I'm happy to update the specs. We should then think about getting this into the donations branch.


@jim-p This does not match the file name exactly? - ldapacpicker
I guess the string in IDENT (line 60) does not have to have the "ac" in it. But maybe this MATCH value needs to match the file name exactly.


ref : #1164


Adding blank line at the end of each file to prevent github's blame.


"If flags contain PR_TASK then id is pid, if flags contain
PR_SHMEM."  - please complete this sentence.


I love that animation!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6819](https://teamcity.mesosphere.io/viewLog.html?buildId=81061&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:09:24


Was removing this a mistake?


Let's just call this TestAvailable please, following the pattern in the other tests.


> So if we're embedded in an iFrame, with a working iFrame phone, but it's not LARA or DG, then we won't log any messages?

You're right. And I agree it doesn't make sense. I was just refactoring code here and was trying not to break compatibility with LARA or CODAP.

> Perhaps refactoring so that there's a single iFrame phone is outside the scope of this, and that's fine, but it seems like a pity that there isn't a generic way to send events to anyone who might be listening.

Actually it's already a single iframe phone. When you request iframe endpoint, you always get the same instance (it's singleton, as we can have only one parent window anyway). The problem is that both CODAP and LARA logging use RPC-style of iframe phone (which I don't like, especially in the context of logging).

> Currently both phones expect a codap-present or lara-logging-present message.

I don't think `lara-logging-present` message is necessary at all. We could always send logs to parent, which can simply ignore them.

But all that was designed before, it works, and the truth is that it's mostly matter of taste, so I didn't want to change it only because I didn't like it. But if we all agree it makes sense, I'm happy to do small refactoring at least for LARA (as I've never worked with CODAP, so that's probably out of scope for me right now).

However I would do it in a separate, small PR (as it would break compatibility and we would need to schedule releases of LARA and Lab in a right way). I would just:
1. Remove expectation of `lara-logging-present` message.
2. Simplify log format for a generic case (non-CODAP) and use plain `iframePhone.post('log', {action: <name>, data: <data>});` call, instead of RPC-style iframePhone.
3. Leave CODAP communication as it is, as it's pretty specific anyway.

(cc @scytacki)


Why was this removed? It was very useful for saving a WIP form without validation.


You should separate these lines to a func named `initMapWithMarker` or something to make your code easy to read.


Blank line


hmm, can't find what I though - but I recall I've seen it ... just can't figure where (thus feel free to ignore).
there's a piece in JRuby-Rack but that should be fine as it's using the `JavaInternalBlockBody` as a base: https://github.com/jruby/jruby-rack/blob/710c1a4cbde684f1d0bec5907ba3071d51de0a96/src/main/java/org/jruby/rack/ext/Response.java#L288-L294


@osahyoun The specs still need to be updated due to the changes I did yesterday (there's a call to Braintree API in one the new private method for managing subscrption so the method stub in the controller spec needs to be changed).

@NealJMD are you running into any cases that work as intended where you get 200 and errors?


Die app_dev.php zeigt mir leider keinen 302-Status sondern 200.
Aber extra nen Controller baun und den Status an die Response anhängen,
finde ich weniger elegant.
Und merke:
niemals
sudo symfony new ...
benutzen dann darf php nicht drauf schreiben :D

Am 25.11.2015 um 17:52 schrieb Robert Freigang:
>
> Topp
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pueppiblue/lapp/commit/09d404325d7530fa84ef177aec6c7af102d96586#commitcomment-14621787>.
>


Adding an autoban for reporting profile is usefull.


Please keep your `{` and `}` at right positions.


For consistency with the other tests, this should live in a global, not inside the test function:

    var availableTests = []struct {
         etc

FWIW I prefer this form because it makes it instantly clear that the test table is
static and not reliant on any in-function data.


Remove this blank line.


Add blank line between 2 methods.


Please name the fields - it makes it much easier to make sense of what's actually being tested.


Double blank line.


this will cause errors, leaves must be an array. I believe tests will already complain about this.... If you want to add an options flag which prevents the tree / leaves parts, thats fine, but I'd like to leave this here


Most of us are using typewriter font for values.

Something like:

@return @c 0 on success...

instead of:

@return '0' on success..

Sure, there isn't right and wrong here, but we should try to find and follow a standard for our project


Please remove `;`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6818](https://teamcity.mesosphere.io/viewLog.html?buildId=81058&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:14:07


maybe we should return `OperatorType?` since there will be a lot of cases where the keyType is not an operator (ex: `One`, `Four`...)


this might be a little more performant
``` javascript
Template.afSelect_semanticUI.onRendered(function() {
  let node = this.$(this.firstNode);

  node.dropdown(_.extend({
    fullTextSearch        : this.data.atts.fullTextSearch || false,
    allowAdditions        : this.data.atts.allowAdditions || false,
    maxSelections         : this.data.atts.maxSelections || false,
    allowCategorySelection: this.data.atts.allowCategorySelection || false,
    useLabels             : this.data.atts.useLabels === false ? false : true
  }, this.data.atts.settings));

  this.autorun((c) => {
    let data = Template.currentData();
		let prevData = {value: null};
    if (data.value && data.value !== prevData.value) {
			prevData.value = data.value;
      node.dropdown("set selected", data.value);
    }
  });
});
```


couldn't you use the M2Installation fixture here? seems like it does the same thing (at least to some degree)


This is not correct


You don't need `break` in `switch` block.


p.s., via sbt-coveralls repo (in bold):

> Do not store repo tokens inside your project if it is in a public git repository!


close #84


Yes, we should be using `M2Installation`, and not adding a different fix.


Note the functions validateBlock and validateProject above... shuold either use those, or get rid of those. I think that validation on the server is slightly diffreent (e.g. check for ID), so had different files


this method should be removed because we already have the enum method `toOperatorType ` above


Please use the internal time-deterministic methods throughout (like the other tests, you can use tb.startTime to find when the token bucket was created)


Please revert this and use `M2Installation` to provide a local maven installation to tests that require it.


Please re-indent your code when saving.
`cmd + A` to select whole file, then `control + I` to re-indent.


need to handle error with a `402`


should refactor this method to be more meaningful


Ta!


Re-indent your code please.


Deals with Issue #2


useful!? Tell me to do that?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6820](https://teamcity.mesosphere.io/viewLog.html?buildId=81070&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:11:07


Looks like auto-dedup is made automatically when reading pages. See page-read.c:207.


You should follow coding convention in Swift. Do not upper case the first letter in function's name.


yo


This flow looks incorrect


This is looking really good! I like the way it builds up the modifications iteratively.


Deals with issue #3


You can use `form.validate().value` instead of `form.getValue(true)`


can be refactored to 1 liner like this:
```Swift
    return keys.indexOf({ $0 == .Plus || $0 == .Minus })
```


Let's use NewBucket rather than NewBucketWithRate - it's more obvious when reasoning about the fill behaviour.


Deals with Issue #4


This should be:
`optionCell: OptionCell` and `onRowSelect selected: Bool`


Double blank lines


Thanks for the tip.  Will do.


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8967/testReport/) for this commit**


whenever you call into async-function from sync context, it is a good idea to do it like this: `countries().catch(e => { console.error(e); });`

otherwise, you'll never know if things go wrong, as exception will get swallowed