TeamCity Gensokyo Lobby :: Lobster Server [Build 0.0.1.57](https://pixelated.design/build/viewLog.html?buildId=192&buildTypeId=GensokyoLobby_LobsterServer&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:00:19


for archive parser (zip, bz2, tar etc.) we've a issue.
- no URL to access content file (anchor is striped in  index),  mime of  content wins
For the archive parsers I'd like to change/fix this, but don't see a optimal option.
- back to join - may create huge index docs (dto. the used alternative,.addsubdoc in 7zip)
- make up a main doc like a directory listing/html toc misses a lot of content
- allow anchor URL as sku not realy practicable (redundant target URL for browser) and likely other side effects (requiring special handling).
Add subdoc (like in 7zip) would be my preferred path to fix (possibly with reduced subdoc content).

Other preferences ?


class: form-signin 　や h2のタイトルは、すべてformの中の要素です。
外に出してしまうと別個のものとなってしまうので、
form_forの中に入れてあげましょう。


First Version


@borshop: retry


これもですね。
一度見本のソースをみてみてください。
form_for の中にタイトルやらなんやら入っていると思います。


Need `continue` statement otherwise `object.getClass()` will NPE if `object == null`


Looks awesome


Clone the repo, change the file and commit push. I just changed it.


saw approval from lukebakken
at https://github.com/basho/eleveldb/commit/0bf857ee9f7a1a01bafc83c48391b63b6d1cbb87


merging basho/eleveldb/feature/gg/rename_int_and_float_types = 0bf857ee into borshop-integration-167-feature/gg/rename_int_and_float_types


basho/eleveldb/feature/gg/rename_int_and_float_types = 0bf857ee merged ok, testing candidate = 1e186957


例えば、コミット名を　「perメソッドをモデルに移行」とした際には、
コントローラーからper(8)を消しましたよー　というソースの他に、
モデルにpaginates_per を追加しましたよー　というソースを含めてコミットするのが適切かと思います。
そのコミット名で影響を受けたファイルはもれなくコミットに含めてあげましょう。


This is not correct. The intent really is that the ``last_downloaded_uri`` in the metadata is the URI of the last version *downloaded* by this client. So the ``last_downloaded_uri`` field in the database should be set only on downloads, and the ``last_uploaded_uri`` field should be set only on uploads.

If, for example, Alice downloads version x from Bob, then uploads versions x+1 followed by x+2, then the ``last_downloaded_uri`` in the metadata of version x+2 should be the URI of version x, *not* the URI of version x+1. This is because a Bob that initially has version x should be able to go directly to version x+2 (which might happen if both uploads happened between two of Bob's scans), and treat that as an overwrite, not a conflict. If, on the other hand, Bob downloads version x+1 first and then version x+2, both of those are still overwrites because their ``last_downloaded_uri``s are both equal to Bob's ``last_uploaded_uri``, which is the URI of version x.

I think part of the problem with the tests is that ``did_upload_version`` is incorrectly called for downloads as well as uploads (on line 707 of ``magic_folder.py``).

It is more complicated if there are three or more clients. I'm not entirely sure that the conflict detection algorithm works properly in that case, but that should not affect the current tests, all of which use at most two clients.


簡潔なif文であれば、三項演算子で書いてあげましょう。
かなりの行数節約になります。
条件 ?  trueの時の処理 : falseの時の処理


완료


Same issue as above.


ここも三項演算子で。
コントローラーにif文書いちゃうともれなく長くなるので、できるところは短くしていきましょう。


commit comment


Hi @zenspider

Is this step used for shuffle all methods?

`methods.shuffle`


commit comment 2


Thanks for this. It inspired the change for liveeditor/draftsman@adc2843105e8fcf34d714557e82cf3f24942dbcb.


¡Qué velocidad en el pull! :+1:


Ok, I've now implemented fallback space width:
https://github.com/behdad/harfbuzz/commit/49ef630936325b2e56a870fcef9aa8473a8f8526


Space fallback happens independent of the decompose_compatibility() callback, which is now unused.


I fixed it but dates for events.csv should be in dd/mm/yyyy format.


The first change (to ``filecap``) is correct. I think that ``did_upload_version`` should not be changing ``last_downloaded_uri`` at all, so that argument should be removed (and we need something like a ``did_download_version`` method as well).


Did not notice this before: for this to render properly, there needs to be a space between the variable name and the colon:

    num_processes : int

Sphinx is very finnicky!


Yeah that's a good point. You could also argue that the NSOperation itself completed successfully - but it was the NSURLSessionTask that you passed in which has the error so I'm not sure if its weird that the operation is telling you that it has an error.

I'd say as a general rule I don't think I'm too worried about sticking exactly to Apples implementation as it has some issues of its own - but if it doesn't really offer any functional benefit then maybe we should stick to the original implementation.


I have added you on kik messenger.
On 5 Nov 2015 00:42, "LCraftPE" <notifications@github.com> wrote:

> Oh ! Thank you !
> It is possible to speak privately ? ( Twitter : @LCraft_PE /
> KikMessenger : LCraftPE )
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DRedDogPE/CustomCreativeMenu/commit/2cdad9bc613908bcde2ae33dcd7f9cc54868b3f1#commitcomment-14199742>
> .
>


durrrr


cc/ @BLangendorf for review.


It all started out as one function, and I thought it looked messy; so I wanted to break out the three context-special ones from the rest.


Use ``if metadata.get('deleted', False):``.


うーむエラー出てないしいけてるかも?(フォント使ったことないんですよね)


Are you willing to add git tags?


quitをexitにしてください。


素人仕事ですが例えばで。
この辺はデザイナーさんにお願いしたいですね。。。

```erb
<div class="col-md-2">
  <div class="thumbnail" style="background: #9F9">
    <div class="caption">
      <h3><%= sticky.comment %></h3>
      <span>@<%= sticky.author %></span>
    </div>
    <p><%= sticky.like %></p>
    <p>
      <%= bootstrap_form_for([@board, sticky]) do |fl| %>
          <%= fl.button(  name: "like_btn", class: "btn btn-default btn-sm") do %>
            <%= content_tag :span, "いいね", class: "glyphicon glyphicon-thumbs-up" %>
          <% end %>
      <% end %>
    </p>
  </div>
</div>
```


Added the GC.KeepAlive past the associated using.


TeamCity pull requests :: netty [Build 595](https://garage.netty.io/teamcity/viewLog.html?buildId=3011&buildTypeId=pulls_netty&guest=1) is now running


You change the signature of addline on orderline but you change caller only at one place where function is called at a lot of different places.
It would be better to add new parameters at end of list, event it is not same order than invoice or proposal...


thanks for the PR. what's the use case for this? why would someone needed to replace the overlay manager? (not questioning the PR, just curious as to what needs aren't supported by the existing implementation)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3686](https://teamcity.mesosphere.io/viewLog.html?buildId=68579&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:23


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3687](https://teamcity.mesosphere.io/viewLog.html?buildId=68580&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:54


Done.


nit: 'have' instead of 'has'.


Added a defensive try/catch, and the catch returns -1 (signalling than an error occurred during processing, and we'll then throw out of the other half).


Get rid of the extra space.


omit


That's not a very useful number without taking into account the CCoinsCacheEntry size of non-deleted entries as well.


`text/javascript/ucr-schedule-visualizer/` is not a proper MIME type


sdfsdfsd


These need to be reverted back to the `===` state.


ジェネリックを使おう


`{error:error}`
↓
`{error}`


Sorry, I'm not sure I understand what you're asking.

After this instance renders, I want to fire the `edit` event (defined in `BaseOptionsCellEditor`). Just like it was before. So there isn't any logic change in this commit.

I'm just trying to improve the code, by removing private method calls which are are already accessible via a public event.
https://github.com/blzaugg/alloy-ui/blob/m-AUI-2038-CellEditorValidator/src/aui-datatable/js/aui-datatable-base-options-cell-editor.js#L267

If this is holding up the review, I'd rather just remove the commit.


I think this is probably still wrong. The client doesn't have the file, and it sees a deletion marker for a version > 0. That's fine, it is perfectly okay to have missed downloading versions before the deletion marker (e.g. because the client was offline or running slow). It is only a conflict if we had uploaded a version that is not the version that the deletion marker depends on (in its ``last_downloaded_uri`` metadata field), which is covered by the 2c conditions.


@cnathe @labkey-matthewb @XingY @labkey-jessim We have test data! Thanks for putting this together Dan. I'd recommend all of you delete your test/sampledata/cdsimport directory before syncing fb_refinement again just to ensure you don't get any weird conflicts. Dan and I are going to update the tests so they run against these counts then we will be back to running tests to verify things are working! #reallifecode


And probably the lists/vectors of the path also might do better if they are dynamically allocated. Try to make big test files on your computer to get better debug-information.


```ruby
(extra.has_browseable_granules && extra.browseable_granule.nil?)
```
won't update browseable granule ID if has_browseable_granule is true but the granule ID is obsolete.


probably would not fail if there's no chance to


asd @arith-alexander


Initial files


`{ return x + y; }`
↓
`x + y`


all tests pass:
success: http://buildbot.bos1/builders/test-eleveldb/builds/523


Set the threshold to a week to prevent querying CMR for every collection every time ```ruby rake data:load``` is run. Note that the first time that ```ruby rake data:load``` is run after deploy will take longer time.


maybe it'd be better to do something along the lines of:

```c
int findAllocator(struct Allocator_pvt* list, int findChild) {
    int found = 0;
    struct Allocator_List** cpp = (findChild) ? &list->adoptions->children : &list->adoptions->parents;
    struct Allocator_List* cp;
    while ((cp = *cpp)) {
        if (cp->alloc == list) {
           *cpp = cp->next;
            found = 1;
        }
        cpp = &cp->next;
    }
   return found;
}
```

then on `disconnectAdopted`

```
static void disconnectAdopted(struct Allocator_pvt* parent, struct Allocator_pvt* child)
{
     Assert_true(parent->adoptions);
     Assert_true(parent->adoptions->children);
     Assert_true(child->adoptions);
     Assert_true(child->adoptions->parents);
     Assert_true(findAllocator(child, 1));
     Assert_true(findAllocator(parent, 0));
}
```

(or something along those lines)
#DRY


cara, `foreach` vazio é pecado. tira isso!

:scissors:


This is a pretty terrible way to check if we're within 2 subdirectories of the parent, but I couldn't think of a better way to do this w/o adding 500 lines of code.


this should be frameInfo.width, frameInfo.height


deixar campos públicos é uma péssima prática. Encapsula isso!


@lethosor - actually needs to just be

    `strangemood`

Shall I make a third pull, or can you take care of it?


xczxc


These examples are a little vague. Wonder if it would be worth another sentence to explain one of them a little more completely?


ㅋㅋㅋㅋㅋㅋㅋ이게 몬가요


cc/ @BLangendorf for review.


Needs to be fixed


@lethosor - another link issue; this shouldn't have the `-` in exportlegends.


@Quarx2k he won't see it here,
I think it may be built by another makefile in the actual device tree, I'll tell you tomorrow...


Causes display of GUI 306 thumb override for icon layout


Maybe we should return with an error here instead.


Hello


asd @arith-alexander


nit: Maybe 'supports dynamic control' instead of 'allows dynamic controlling'?


Needs localization + possible Var rename


Does this work? 'fd' was closed (even if it wasn't, it shouldn't be at the head of the file).


`NullReferenceException`


sdasasd @arith-alexander


TeamCity pull requests :: netty [Build 595](https://garage.netty.io/teamcity/viewLog.html?buildId=3011&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5246, ignored: 21 Build time: 00:15:20


@arith-alexander 123


Oops, I got this completely wrong (in the implementation, not the spec). 2a says that if the file doesn't exist, it is an overwrite (and the 2c conditions are ignored), not a conflict.

So it should be something like:
```
is_conflict = False
if pathinfo.exists:
    is_conflict_2c_i = ...
    is_conflict_2c_ii = ...
    is_conflict_2c_iii = ...
    is_conflict = is_conflict_2c_i or is_conflict_2c_ii or is_conflict_2c_iii
```


I specifically did the methods for points a), c), d), e), and most of g) for the BoundingObjectManager singleton .


sdfsdf


@arith-alexander dsf


Ok... Do we even need the dup()?


@sdfgsdf dfg


nbmbnmbnmbmn


reviewed


I don't think it can be correct to treat version 0 differently from later versions, because the first version that a given client sees may legitimately not be version 0, and that shouldn't affect conflict detection.


concordo.


interfaces (dont chage the ui inside a bg thread)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3688](https://teamcity.mesosphere.io/viewLog.html?buildId=68587&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:05:15


bnmbn


@danski JKJK This should fix my static route on the server and template.


I've moved these fields down into the ContactContentCtrl as they're not used this high.


mesmo se tu quiser fazer isso (o que acho desnecessário), é melhor usar:

```
decimal valorJogoMaisBarato = Decimal.MaxValue;
```


1899-HP-Loop-Crash (kbenne) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.52%25-yellow.svg)


-1; my mistake about condition 2a is probably confusing things. I suggest reverting this commit then fixing that first, and then fixing the issue I described in https://github.com/david415/tahoe-lafs/commit/23e76b0dfb5aae23d05458747f2bbd1845831f07#commitcomment-14200290


Execute the function once in the controller and access the result in the loop. If the function is called in the repeat it's executed many times, with an unnecessary performance hit.


@SthephanShinkufag а так? Я тебе сегодня надоем.


> Should this extend `UsageResponse`?

[It does](https://github.com/guardian/grid/commit/bb8bdaf5705860e1c664a9d934ccf18ab2ebfa1f#diff-e5c779e3f5ab3350bef8e6e45881f87cR29)


What these numbers mean:

* Let each goroutine process batches of `batchSize` objects.
* Each batch is "retrieved" by adding `batchSize` to the `index`, through `atomic.AddInt64`. Each goroutine will then get a different `nextIndex` value (see below), to which it has to add `0...batchIndex`.
* Each 10k objects, the `batchSize` grows by one. This could be any value, actually. I choce 10k without any good reason.


I agree. Even if it is used only with ADD_ADDR2 so far, it definitely belongs to version control.


The problem here is that you were passing an int; operator== takes exactly 1 argument. Also, it's a const function (it doesn't change the state of the Token).

There's a subtlety to this that we can talk about later, regarding the extra operator I added below ;)


Good practice to implement operator!= in terms of operator==


...eller bør alle felter kopieres fra den ene til denandre strukturen?


Кстати, раньше рефлинки были гораздо быстрее, потому что искались во всём посте, но потом я изменил скрипт так, чтобы они искались только в сообщении поста, поскольку иначе скрипт конфликтовал со встроенными в борду генераторами реф-карт. Отсюда видимо и произошло такое замедление между 13 и 14 годами.


Та ничё. На общее благо работаем жи есть.
Такое анализирование по оптимизации необходимо делать.
У тебя просто машина шустрая, и такие вещи могут быть не заметны.


This cool operator allows Token to be converted *implicitly* to const char* - very useful e.g. when we want to print out a token. Note that any function which takes a const char* can now *directly* take a Token!


 Reflinks map 86ms

**Лоооол.**


@spencergibb fair point, I must have been having a senior moment...I tried running java 8 (on mac osx) but it made no difference. I have got it working on ubuntu on ec2 so will try windows again


cstring is the library to use when dealing with null-terminated strings. The API is insanely horrible (because it dates back to the 70s) but it's about as efficient as you can get.


I think it will be easier to override getIndexSettings() and make it get the settings directly from the settings service. No need for the listener...


@woozzu Just curious, is there a bug you found on Windows? If so how do you reproduce this bug? Could you have a test for it?  and could this patch be contributed upstream? Thanks!


Should we also set the `instanceid` to `{user}-api` and `{user}-ui` for the developer configs? Because right now the api and ui are both mapped to `/{instanceid}`.


Марахайка RAM DDR2 1Gb / CPU Celeron E3400 2.6GHz / Win7 32 если чо :D


Good job )


Instead of modifying the options menu for custom hotkeys, I had been planning on adding some sort of "mod options" menu from within the Mods menu, sort of like how tAPI did it.


I had originally changed `int` to `size_t` here, because some compiler was issuing a compiler warning.

The issue is that `pluginDescriptors->size()` will produce something of type `size_t` (non-negative integer with no sign bit), and some compilers complain because a large non-negative integer might already be using the sign bit.  This would conflict with `int`.  I see that the termination condition `i >= 0` imlies that eventually, `i` will become `-1`.

To solve this, you might use one of the C++ casts that will do type-checking at runtime to see if the size is using the sign bit.  Or maybe you have a better way to do this.

By the way, I should have written an earlier inline note.  I'll do it next for the earlier commit.  But I would prefer that we change the name from `pluginDescriptors` to `pluginDescriptor`.  But this code makes the intention a little clearer.

If I understand, a `pluginDescriptors` is a pointer to a vector of `pluginDescriptor_t`.  So, it's analogous to writing:
`pluginDescriptor_t pluginDescriptors[100];`
If we have no intention of using a separate variable:
`pluginDescriptor_t pluginDescriptor;`
then I would read `pluginDescriptors[3]` as "the third pluginDescriptor", and not as "the third pluginDescriptors".  I hope this explains why `pluginDescriptor` seems like a better name to me.


Interesting: as a chess player, I think I understand the motivation of your change (pinned attackers can still support a king hunt).  Perhaps it failed regression tests because `b & ei.kingRing[Them]` evaluates to true more frequently, causing spending of extra CPU cycles.

I am confused why in the original code `attackedBy[Us]` does not use pinned attacks.  Pins are dynamic (not static), especially if the player intends to move the king anyway (due to check or due to the king being in a bad location).


Hey,
actually this is need for the Dual sim phone on the newest libsec-ril.so
i dont think it's need for a Single SIM
if u tooked it from Klte one that patch was added for the LP lib for the klteduos mix with dual sim stuff
i m using Grand 2 (msm8226) we had this on KK RIL too fix the accepting the calls


Tokens are null-terminated strings hence we want to compare more than just one character, strcmp does this but (in keeping with the weirdness of the cstring API) has an unintuitive return value (see http://www.cplusplus.com/reference/cstring/strcmp/).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3732](https://teamcity.mesosphere.io/viewLog.html?buildId=68705&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:44


Is it really necessary? The dev API and UI instances uses different ports, not really the instanceid.


It makes sense indeed to handle all that in the drop action directly.


SF


I would prefer that we change the name from `pluginDescriptors` to `pluginDescriptor`.

If I understand, a `pluginDescriptors` is a pointer to a vector of `pluginDescriptor_t`.  So, it's analogous to writing:
`pluginDescriptor_t pluginDescriptors[100];`
If we have no intention of using a separate variable:
`pluginDescriptor_t pluginDescriptor;`
then I would read `pluginDescriptors[3]` as "the third pluginDescriptor", and not as "the third pluginDescriptors".  I hope this explains why `pluginDescriptor` seems like a better name to me.


No, I mean when you run a dev instance via WSGI.


@jyotisingh - do you know why we were doing this for testing connections?

FYI: connection testing was not possible for dependency materials.


I think should call on_change only when value changes.
Here, it changes everytime when field lose focus, even if value didn't change.
Can you update it?


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


почему trait, а не class?


This is more work to so. I thin, I can so it.

@koji: The only thing I cant so is the About.html in the dev_2.11 branch: That is really other text!

----- Ursprüngliche Nachricht -----
Von: "Koji" <notifications@github.com>
Gesendet: 05.11.2015 07:41
An: "JabRef/jabref" <jabref@noreply.github.com>
Betreff: Re: [jabref] Updated Japanese help files and properties resources toconform to 2.11 release (8b50272)

Oops, thanks Jorg. I recommit on branch.

Koji

2015-11-05 1:57 GMT+09:00 Jörg Lenhard <notifications@github.com>:

> From the commit message, I assume that you want to include these changes
> in JabRef 2.11 as well?
>
> If so, you need to backport the changes in the 2.11 branch
> <https://github.com/JabRef/jabref/tree/dev_2.11>. Your current commit is
> on master.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/JabRef/jabref/commit/8b50272451be552330b1882a0933f4903de01643#commitcomment-14188608>
> .
>

—
Reply to this email directly or view it on GitHub.


IMO this could have waited for another PR, but as we have a history lately of not merging your PRs fast enough, I think you can rightfully continue to add new stuff ;)


Static member variables need to be defined in a .cpp file like this.


增加


В мире java принято использовать camelCase для именования )


Do we need this option? we can use 'apk-type' in suite.json


In fact the `if self.is_relative()` at line 55 is not necessary because the `range_in_seconds()` function is called once at line 54, and a check is already done in it.

According to me you can remove this check inside `range_in_seconds()` (ie. lines 55,57,58).


Hva skjer hvis noen prøver seg med ugyldig recordId?


Please don't change this file, it is automatically changed come release time.


Line is too long. [101/100]


Overall notes:

- Because Token is such a small class and is very closely related to TokenStream I'd consider putting it inside the same source file.
- We should add asserts to the code (added an issue for that) to check for a null pointer being passed to a token.


As usual, when function names become smaller, it's usually that good simplification is happening :D (at least in our project where we have a very good coding style I believe)


Also changed carousel pictures to black and white to maintain consistency with the rest of the site pictures


@binky123 Maybe you want to write
```
      // Set up the new depth for the helper threads
      if (!isMainThread)
      {
          Depth newDepth = Threads.main()->rootDepth + Depth(int(4.2 * log(1 + this->idx) /  log(1 + Threads.main()->rootDepth)));
          if (newDepth > rootDepth)
            rootDepth = newDepth;
      }
```
But I see no need to complicate things. Simply
```
      // Set up the new depth for the helper threads
      if (!isMainThread)
          rootDepth = Threads.main()->rootDepth + Depth(int(4.2 * log(1 + this->idx) /  log(1 + Threads.main()->rootDepth)));
```
should work as well.
But feel free to test as you like.


propose new file


shouldn't you take a const reference or the const is meaningless?


I tried google with:
`distributed algorithms "lift the barrier"`
and:
`distributed algorithms "release the barrier"`

The most common terminology (by a lot) is `release the barrier`.  Can we do a name change:
`liftBarrier()` -> `releaseBarrier()`


Thank you for great explanation!
I've investigated this step by adding `ps aux | grep docker-machine` right before `pkill` and found that there are some processes of virtualbox driver:
```
legal            5743   1.7  0.1 573401512   6196 s001  S+   11:42AM   0:00.01 /Users/legal/go/src/github.com/docker/machine/test/integration/../../bin/docker-machine-driver-virtualbox
legal            5741   1.5  0.1 573408656   6000 s001  S+   11:42AM   0:00.01 /Users/legal/go/src/github.com/docker/machine/test/integration/../../bin/docker-machine-driver-virtualbox
legal            5738   1.4  0.1 573400464   5928 s001  S+   11:42AM   0:00.01 /Users/legal/go/src/github.com/docker/machine/test/integration/../../bin/docker-machine-driver-virtualbox
```
So that, `pkill` kills these processes, then EXIT_STATUS is setting to 1, which causes integration tests are always considered as failed.
Is it an expected behavior? Do driver processes should not be running at this moment?


Видимо новомодные итератор-протоколы для горячего коде не очень. А можешь проверить эту версию: https://gist.github.com/Y0ba/86a389c70b2c84657618 ?

Если будет сильно быстрее, то по всей видимости, лучше использовать массивы в горячих местах вместо Setов вплоть до отказа от ES5.


public int Age { get; private set; }


Great. Thanks both. Seems we're in a fairly good place. Nulling cadence  should probably use the old mechanism since it doesn't control playback and tends to reduce more abruptly than wheel speed ?


достаточно солидное решение!

но для такого нужно уже структурировать код в разных файлах

хорошие комментарии, но нужно учить английский.

Good job!


Is this style really correct?  Space after function?


Let's do a global search (case insensitive) on `lift` and change it to `release` (preserving case, of course), since "release the barrier" seems to be the more common phrase in computer science discussions.


Вот прямая ссылка на файл: https://gist.github.com/Y0ba/86a389c70b2c84657618/raw/7464fc2a49a1fff95253f86ff09323e4c09a8c7b/DET.user.js

Только осторожно, скрипт не совсем рабочий. Только на один запуск и проверку.


ありがとうございます。
後この部分でlocationから-1しているのは、
[]に入れた時の順番と対応させて呼び出すためってことで大丈夫ですよね？
[]での順番は0から数え上げるからってことで。


rhel оно зовется, а не redhat и бывает не только на амазоне


Hi @antoineco, I won't be able to do it in the next few days but next week hopefully.


I'm not sure... Guess it can't hurt!


Ok, I'll handle it


As in the reference wouldn't hurt...


We need to change the JTRACE message to correspond to the new event name here: `DMTCP_EVENT_WRITE_CKPT`


GString can be used here


Indeed


Так наоборот же, только на gce обязательно прибивать сервер и оставлять его диск, когда делаешь имедж


Change JTRACE message to `DMTCP_EVENT_RESUME`.


Has already been backported by @kojiyokota in https://github.com/JabRef/jabref/commit/a16252e5b6c6f64a873b68dc3593f0ca339c8a0d.

Thanks!


yup :+1:


Good job!


:bird:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3733](https://teamcity.mesosphere.io/viewLog.html?buildId=68706&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:37


Don't you want to delete this `JTRACE("DMTCP_EVENT_THREADS_RESUME")`?  A few lines earlier, you have, instead:
`JTRACE("DMTCP_EVENT_RESTART")(_get_rmgr_type());`


Oops I'll fix that now.. I'll text the sdcard thing in the am
On Nov 5, 2015 1:49 AM, "OzzysCmAcc" <notifications@github.com> wrote:

> Should be target.... Derp
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Team-Hydra/android_device_samsung_klte-common/commit/56e31889152eaffaaf5d88fdfeee44ab5c1b3aea#commitcomment-14206302>
> .
>


I understand that this will fix the problem but doesn't this method has an hidden assumption now that there is currently no leader in the cluster (somebody might use this method in the future the wrong way).
Also i couldn't find where do we issue an empty commit after we are elected, can you point me to the line where that happens?


Hi,
where can i get clien side `<script src="syc.js"></script>` file ?  can you please ask me ?


The reference will avoid an extra copy of the element while currently you get a (write protected) copy. No?


please name variables starts with low case


I am also not always sure how to do the indentation in HTML templates. If you replace the tabs with spaces its okay from my perspective.


i think this is ok


Please use camelCase in naming


@rogerhutchings why did you remove `localStorageService`. I'm using for tutorial flagging.


This commit does more than merely adding comments. A commit message like this could be confusing or overlooked when doing a bisect...


@gforcada This seems to break the pull-request-job for 4.3: See http://jenkins.plone.org/job/pull-request-4.3/154/console


It's definitely a bug. Expression continuations should be indented with 2 spaces, unless they are on the RHS of an assignment.


I don't think you are, I can't see it in this controller and the linter flagged it as unused. And if it's not used, it shouldn't be in there...


I'm not 100% familiar with the server/client logic yet, but with your above changes, wouldn't something like "pollNewConnection" be more accurate than a "notify\*" function?


would be good to refactor this to avoid repeating the "for row in source_cur" loop. The loop above is identical


`stack-base` -> `stack base`
`in 64-bit system` -> `in 64-bit systems`


`32-bit system` -> `32-bit systems`


Looks quite good overall (still through my half-noob eyes, but well :P)


I can't find this method ('uri')anywhere. I get a -Wobjc-method-access when compiling with clang. I suspect this is a cherry picked commit that is missing another part not committed to v2 branch.


index.html


My fault. I merged my tutorial branch before merging your PR. If you look at this file on master, it'll make sense (hopefully).


Not sure I understand what the problem is about, @physikerwelt . Which version mathoid is actually using? And why this version wouldn't fit there?


744: if (*(mode+1) != '\0' && isdigit(*(mode+1)))
First part of condition is redundant, because isdigit('\0') is False


setNom et non setnom


Fair enough, add it back in then!


Do these need to be in here? Are we going to have the interface defined else where?


Used an elseif instead of continue


Maybe this is a good opportunity for more cleanup.  I don't know what `CB` stands for.  Does the `B` stand for barrier?  Can we do a global search, and replace it with something more verbose?


OK


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3734](https://teamcity.mesosphere.io/viewLog.html?buildId=68707&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:40


We should start tagging the frameworks repo (https://github.com/alphagov/digitalmarketplace-frameworks#versioning) when update the apps, even if we don’t do it every time we make a change to the content.


params :id


Nice commit message :P


It just has the Transform Viewer handle when adjusting the "Transform" tab or "Clone" tab of the RotoPaint node.


This looks very LG-specific...


Great class name o_O


Now, if the COPR repo is deprecated, what is the replacement for it?


Yup, looks like that did it. I knew it was something simple, but I was heading out the door when I checked the progress of my build and saw the failure so didn't have time to investigate.


we should set a proper status code too


The test says exactly the opposite: it affects the whitespace *inside* the tag.


The point why there are different templates for the shift creation and shift editing is that they are subtly different. Rian wanted that it is possible to create multiple shift instances on different dates in the shift creation dialogue. (This is the purpose of the TODO comment.) On the other hand, the edit shift dialogue is only for one single shift instance which only has one date. Furthermore, I'd name the buttons in the create view Create/Cancel and in the edit view Save/Cancel.

My idea was to extract the part which is the same and include it in both forms. From my point of view the complexity is not too big.


I suggest the following:

define `buf_bytes` as:

```python
buf_bytes = ((0xE0, 0xE0), (0xFC, 0xE0), (0xE0, 0xFC), (0xFC, 0xFC))
```

and then `update_buf` can be:

```python
def update_buf(self, data, start=0):
	buf = self.buf
	buf_bytes = self.buf_bytes
	brightness = self.brightness

    index = start * 24
    for color in data:
		color = color * brightness // 100
		for b in range (0, 8, 2):
			buf[index + b:index + b + 2] = buf_bytes[color >> (6 - b) & 0x03]
		index += 8
	return index // 24
```

Perhaps it's not very fast, but quite Pythonic ;-)


How about not to add this line? (so that we can decrease the number of changed files in this patch. :-p )


@borshop retry


should this be easier`@question = round.questions` ?


Cheers @FuhuXia


I will revert this commit but I have some comment for you
1. As I ask: you must implement just one function
2. Check it one time when try to push to master, you do not have to use 2 import


A bugfix release on pypi would be nice.


The point of the install script was: `Someone should be able to install the app using the install script and run the tests.`.  Xdebug is a PHPUnit dependency so it's always installed by the script. As for the production environment, the opsworks installation is much different than this script


it would be better to add a single-question class to this list element. Then we could have a global css statement `.singe-question .permalink {display:none;}`


DO NOT merge
DO rebase
!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3735](https://teamcity.mesosphere.io/viewLog.html?buildId=68713&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:41


I am not sure about this point. I just have a bad feeling about putting on part of the feature here and the other there. I suggest putting everything into the `organizations` app for now. Maybe we can see a good pattern when the feature is implemented and then we can re-factor it.


Here the `pipelineName` is the name of the pipeline that the material belongs to. So, you can define your material URL as `#{SOME_PARAM}`. In order to check connection, you need to expand `SOME_PARAM`, hence the call to `MagicalGoConfigXmlLoader.preprocess(config)`. If SOME_PARAM wasn't defined, the preprocessor would add a validation error. If there are no validation errors, then the check connection is performed. Make sense


Agree, fix seems to break deleting.


You currently store escaped HTML in the DB.

`ctrl.$setViewValue(_.unescape(elem.html()));` - maybe this could simply be  `ctrl.$setViewValue(elem.text());`?


+1 for verbosity


The previous implementation of the application/apache config included an alias to a local compiler installation in the vhost config file (no idea why). This is a remnant of this implementation, as the alias has been removed. Will remove that one too.


Did you change INTEGER from 16 bit to 32 bit and LONGINT/POINTER from 32
bit to 64 bit for the 64 bit version of ofront? If so, it is clear that
there are many problems in the modules that interface the underlying OS. If
the layout of the data structures does not match the layout of the
corresponding C structs everything can happen.

- Josef

2015-11-05 10:45 GMT+01:00 Norayr Chilingarian <notifications@github.com>:

> hey, Josef.
> I decided to write you here, probably to let you know about the following:
>
> I have forked ofront here on github in order to bring my Linux/x86_64
> <https://github.com/norayr/ofront> support to it(which is already tested
> on voc, which also ofront fork you may aware of).
>
> 64bit Linux ofront binary now works well, it can create itself with the
> exact same md5sum.
>
> however, there are problems in the V4 environment.
>
>    -
>
>    firstly, there is a problem with Fonts.Mod described here
>    <https://github.com/norayr/ofront/commit/81e11dc69f8b2c8fb5c2ee877a21886f42c0d2bf>.
>    It looks like Fonts.Mod was not tested on 64bit machine.
>    -
>
>    secondly, I suspect there is some problem with X11.Mod wrapper.
>    Currently V4 environment loads itself, draws window and crashes on my
>    Funtoo Linux with Debian kernel (3.19.3), glibc-2.20, and xorg-7.4.
>    Interesting thing is that this 64bit port does not crash on RHEL4/x86_64,
>    which has kernel 2.6.9, glibc 2.3.4, and xorg 6.8, thus I suspect that X
>    interfaces have been changed. It does not crash on this old system, but it
>    is not quite usable because it does not show fonts either, only initial
>    side pane, and mouse are visible.
>
> this <http://pastie.org/10531310> is strace output of the crash.
>
> My motivation was to bring Linux/x86_64 support to the traditional,
> classical ofront with V4 system. Later, if it works, I have some small
> changes in code generator, which I'd like to contribute upstream too. Right
> now I can remember of one fix, which silences some clang warnings about
> desirable parentheses in certain code segments.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jtempl/ofront/commit/4fd9fdf0352eb08e321599d4806cc8229eab5b47#commitcomment-14206198>
> .
>


Nice FIX! It works great !
Good job :+1:


Maybe we could change the directive so it creates a text field / text area instead of using contenteditable?


Книговыдача американский КЦ


Finally :D


I think when projectm was still in our tree we didn't use ftgl when compiling on osx. (indeed ftgl doesn't compile on osx in the current state). Can you think of any way on how to alter the addon to make ftgl optional for osx?


@avoinea: thanks Alin, I was going to do the same :)


Nice Ezee, I will check this soon.


True that. Will change it


Inline Comment


$record is not so nice, maybe generate a var name based on the module name that is nicer ;)


Overall Comment


test commit 1


Твой файл:
Init 10ms
Replace delform 7ms
Parse delform 191ms
Parse postform 13ms
Init keybinds 2ms
Init page 6ms
Add panel 6ms
Init AJAX 2ms
Audio links 6ms
Video links 15ms
Image names 23ms
Reflinks map 65ms
Apply CSS 8ms
Hide posts 11ms
Всего 365ms

Последний коммит
Init 8ms
Replace delform 4ms
Parse delform 196ms
Parse postform 14ms
Init keybinds 2ms
Init page 7ms
Add panel 6ms
Init AJAX 3ms
Audio links 5ms
Video links 23ms
Image names 26ms
Reflinks map 81ms
Apply CSS 6ms
Infinity scroll 2ms
Hide posts 11ms
Всего 394ms

Init 7ms
Replace delform 4ms
Parse delform 198ms
Parse postform 13ms
Init keybinds 2ms
Init page 8ms
Add panel 6ms
Init AJAX 3ms
Audio links 7ms
Video links 18ms
Image names 23ms
Reflinks map 83ms
Apply CSS 6ms
Hide posts 19ms
Всего 398ms


Comment From MA


Ещё раз попробуй: https://gist.github.com/Y0ba/86a389c70b2c84657618/raw/00a1fae9f45a27e91591edc544414ea793316d58/DET.user.js
В моём файле была ошибка, из-за чего скрипт работал быстрее, но неправильно.


Causes #11


 Init 5ms
Replace delform 5ms
Parse delform 196ms
Parse postform 12ms
Init keybinds 2ms
Init page 9ms
Add panel 5ms
Init AJAX 3ms
Audio links 7ms
Video links 15ms
Image names 25ms
Reflinks map 80ms
Apply CSS 5ms
Hide posts 13ms
Всего 383ms

 Init 9ms
Replace delform 5ms
Parse delform 197ms
Parse postform 13ms
Init keybinds 2ms
Init page 7ms
Add panel 6ms
Init AJAX 3ms
Audio links 6ms
Video links 18ms
Image names 22ms
Reflinks map 83ms
Apply CSS 9ms
Hide posts 12ms
Всего 392ms


提交


Ммм, разницы нет. Ну и ладно.


@pombredanne Actually, this is not a bug fix. Please refer to dw/py-leveldb@85


Oops sorry didn't pay attention


Guilherme; apenas dois detalhes.

1 - procure fazer os pull requests na branch DEVELOP a ideia disso e que as coisas sejam testadas em develop antes de serem trazidas para Master e haver nova tag

2 - Procure evitar usar "ELSE" nos IF sempre que possível, isso tende a reduzir a complexidade do código.

E desde já agradeço sua ajuda e será sempre muito bem vinda

Abraço


excuse me, this is not the right branch revision.
You are right about this.


This algorithm definitely does not work for three or more parties.

Alice downloads version x from Bob, then uploads versions x+1 followed by x+2.
The metadata ``last_downloaded_uri`` will be set to uri of version x.
Ada downloads version x+2 from Alice.
Ada uploads version x+3, setting the last_downloaded_uri in the metadata to URI of x+2 and last_uploaded_uri to version x+3.
Bob downloads version x+3 and sees it as a conflict because ``last_downloaded_uri`` is set to URI of x+2 and is not equal to Bob's ``last_uploaded_uri``.


>Did you change INTEGER from 16 bit to 32 bit and LONGINT/POINTER from 32 bit to 64 bit for the 64 bit version of ofront?
[yes](https://github.com/norayr/ofront/blob/master/V4_ofront/linuxamd64/Ofront.par)

As I said, 64bit version of Ofront is well tested in [my project](http://oberon.vishap.am), and ofront binary itself works and reproduces itself fine.

>If so, it is clear that there are many problems in the modules that interface the underlying OS.

Yes, in order to get proper 64bit Ofront binary [these](https://github.com/norayr/ofront/tree/master/V4_ofront/linuxamd64) modules were affected.

Just wanted to share this information with you, so that if you or somebody would need it, the working command line version is in my repository.

Later I'll try to bring commit something else.


The Licence must remain with this code as its an open source licence


remove the file maven.iml


However, what are you trying to say with "Or whatever JUnit you're using."
You specify a veryion which forces users to use 4.11.


normally, no need to do dup() any more.


Йоба, а нельзя как-то подробнее прологгировать `Parse delform`? Что там самое прожорливое?


Added.


Можно. Я уже делал так. Правда сам логгер может отжирать чутка времени.


Т.е. только для отладки.


1) move the current projectm directory from common to linux
2) duplicate in osx
3) add flags.txt in osx dir with '-DUSE_FTGL=0'

if that does the job, we can carry that until somebody (probably sascha /
wolfgang) adds support for platform-specific flags, so we don't have to
dupe everything.

On Thu, Nov 5, 2015 at 11:48 AM, Memphiz <notifications@github.com> wrote:

> I think when projectm was still in our tree we didn't use ftgl when
> compiling on osx. (indeed ftgl doesn't compile on osx in the current
> state). Can you think of any way on how to alter the addon to make ftgl
> optional for osx?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/notspiff/visualization.projectm/commit/9d38e010ca08f9852756b6de06076c52778c0594#commitcomment-14207846>
> .
>


Isn't it a pity to extract STATIC methods in the new class ?


You are still unsing an exception handler to ignore IOExceptions.
This is bad practice, because the program does not do what it is supposed to do and does not fail.


Тогда не надо.


Be careful! We should escape the loop after the first occurrence of a non-normal number and set the value at exactly -SpecFunc::LogMinNumericalScalar, else we could have a situation where we try to optimize in the non-feasible set.


> As far as I could tell, there wasn't actually any modification happening to the overlay's contents,

Ah, in that case yes. ok. Note that the modification hook should be idempotent anyways, so if some subtle modificaiton did take place (only in the wrong buffer), ignoring it might be problematic....


Thanks for catching this. Off to the docs for me to learn what Fabric is.


I think you have your IDE misconfigured as PSR-2 requires conditional opening braces in the same line where they are defined


you probably want to move freetype as well, not needed without ftgl.

On Thu, Nov 5, 2015 at 11:59 AM, Arne Morten Kvarving <cptspiff@gmail.com>
wrote:

> 1) move the current projectm directory from common to linux
> 2) duplicate in osx
> 3) add flags.txt in osx dir with '-DUSE_FTGL=0'
>
> if that does the job, we can carry that until somebody (probably sascha /
> wolfgang) adds support for platform-specific flags, so we don't have to
> dupe everything.
>
> On Thu, Nov 5, 2015 at 11:48 AM, Memphiz <notifications@github.com> wrote:
>
>> I think when projectm was still in our tree we didn't use ftgl when
>> compiling on osx. (indeed ftgl doesn't compile on osx in the current
>> state). Can you think of any way on how to alter the addon to make ftgl
>> optional for osx?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/notspiff/visualization.projectm/commit/9d38e010ca08f9852756b6de06076c52778c0594#commitcomment-14207846>
>> .
>>
>
>


The whole solution instead of simple script?
http://raol.github.io/2014/03/21/ascii-art-with-python/


oops, forgot to make a PR


We've mentioned using YARD in the ["Document the error cases possible from next_node" Trello card](https://trello.com/c/mqDDQEtM/116-document-the-error-cases-possible-from-next-node). Do you think that's enough for now, or is it worth capturing this in its own Trello card?


That made count work wrong with multiple arenas


ça aurait été mieux d'avoir une option pour l'activer/désactiver. On a besoin de le désactiver de notre coté.


Wieso machsch du ez plötzli au en merge??
Du häsch doch früener au mal rebase gmacht


This is not correct. The rule can calculate the price to all previous levels to that one.

![captura de pantalla 2015-11-05 a las 12 06 30](https://cloud.githubusercontent.com/assets/168744/10966707/ac1ac896-83b5-11e5-940e-6d9221db4058.png)


Rename to filterActiveMembersInGroup.


@EvilOlaf
This is for backwards compatibility, so players can't just take over the old, pre-UUID names


Maybe you need to explain this better!?


since we're using ```MSG_WAITALL``` ```recv()``` is not on non-blocking so we won't face EAGAIN (at least as far as I can see).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3736](https://teamcity.mesosphere.io/viewLog.html?buildId=68714&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:35


Vois avec @floor0669 , elle m'a juste dit de revert le commit (nos tests ne fonctionnaient plus du tout).


@musamusa have gone through this and i cant't create packing design docs via `gulp views` had to do it manually


this else part is not needed, is it?


sdsdssds


Because it's a lab work for my students, who learn C# from zero.
And Python version behaves differently from cs version.


while(!finished)多余


Hey @dmitry-livchak . Was this needed? The original solution looks for the words 'develop' and 'master' anywhere in the string already.


Le plus "propre" aurait été de mettre a jour le sdk sur jenkins


Maybe `github.com/aio-libs` is a better place for this note?
Anyway it would be nice to have there as well.


plzz give me  ping.. i need ur help.
hllboy12@gmail.com
skype:- shabrezkhan


Please return it back. :)


Try specifying a newer version, I [see that there's 3.5.2 available](https://rubygems.org/gems/devise).


Hi @tedschmidt , it's really cute to see these C style `m` prefixes for member variables, but if you ask me there is no need for them. We have IDE's with syntax highlighting nowadays and these sort of prefixes are therefore redundant (and not used in the Java world anyway as far as I know, unless it's retro again or something ;) ).


What exactly would be needed to get rid of this `@skip` ?


В общем, ради прикола удалил весь блок со вставкой кнопок постов в конструкторе класса Post
Было: 199ms
Стало: 60ms

Все, в принципе, ясно. Вставка кнопок сама ресурсоемкая часть.


Why is it necessary to set resident_on here for GPU passthrough? Isn't this also covered by the new code in Message_forwarding.allocate_vm_to_host?


That should go onto latest_release_doc_updates.


typo fixed in 7832c3c7cdb84ffbfb6420052931e751d4887483


I am not sure whether this is a good idea. `composer/installers` uses the name to determine where to install it using some rules (see [here](https://github.com/composer/installers/blob/master/src/Composer/Installers/MediaWikiInstaller.php)). `simple-saml-auth` would be installed in `extensions/SimpleSamlAuth` (like currently), whereas `simplesamlauth` would be installed in `extensions/Simplesamlauth`.


看upgrade_nginx-chacha20.sh这个文件辣，upgrade_nginx.sh是原始文件ww


typos fixed in 7832c3c7cdb84ffbfb6420052931e751d4887483


the extra space is part of the magic. Go figure. Blame Mr. gates :P


I've updated these in ab18762a77093277a71fd09b4dc93d9d981fa8c5. I've also updated a similar use of `when .. then` in calculate-married-couples-allowance in eebb8f8dad204fb9d896e25e13e6ca07c9b1b173.


+1 and add description like facebook does https://github.com/facebook


ouch... I see, not me magic's one... ok, this one you can blame mr. dorilex... thanks.


How about a hardcoded dictionary with the default values here and compare ony by one whether it matches? Then we don't need a reimplementation of `str_to_dict` (which is actually the function you want to test).

Then we can get rid of the `@skip`.


This commit is a result of the discussion in https://github.com/Ultimaker/CuraEngine/commit/d4adbb97bfcb62475c5943cd8f9867af546ae97a

[ REVIEWED ]


The master-level code only sets VGPU.scheduled_to_be_resident_on. This gets switched for VGPU.resident_on once the PCI is actually attached.


Also XenAPI.VGPU.atomic_set_resident_on is called in update_vgpu... I assume this does not include the passthrough case?


@yfdyh000 弄了个定时任务，每天跑一次，跑几天再看看


Yup. It's captured in the ["Remove predicate code" Trello card](https://trello.com/c/ixHKQNr5/69-remove-predicate-code).


Man kann das vereinfachen:
```java
int jahr = 2004;
```


I see you're using if statements without braces a lot. I think this a bad practice, it's quite error prone.

It's easy to forget adding the braces later on when adding a second statement to the if clause. Maybe you don't make such mistakes, but other less experienced developers in a hurry of fixing some obscure bug may overlook it and introduce a new bug because of it.


No, update_vgpu only applies to "true" vGPUs.


That is a valid point.  I should have included a comment in the commit history noting that it also replaced hardcoded constants with identical values from a table.  The good news is that this change is bit exact and equivalent to the previous commit:

https://arewecompressedyet.com/?r%5B%5D=master-2015-11-05T10-28-31.962Z&r%5B%5D=master-2015-11-05-e9a8eb7&s=ntt-short-1


I mean, can this line be removed entirely?


should be used in JMAPServlet, no?


I'm using 2 spaces indent too, but the existing code is using TABs.


Separate PR, or just do it?


This method is too long, break into small methods.


What about passthrough of other kinds of PCI devices?


Because if someone wants to translate it, it should to be there

> On 05.11.2015, at 10:57, Freso <notifications@github.com> wrote:
>
> Why not just remove the file outright, rather than just "resetting" it to English?
>
> —
> Reply to this email directly or view it on GitHub.
>


It looks good, it will be merged at what time?


I find the naming a bit weird.

I would name it middle_from_inside instead of inside_middle_from.
I like to have variables which are related starting the same rather than ending the same.
That way autocomplete can help you choose between the two.

I have a lot more arguments, but perhaps you are convinced already.
Are you?


never used?


Selbst die Aussage
```java
jahr <= 1581
```
gibt die Wahrheitswert zurück. Also, kann man einfach so schreiben:
```java
if (jahr <= 1581)
```


@josdejong It's standard in Android and part of their coding standard :)https://source.android.com/source/code-style.html#follow-field-naming-conventions
It's not C style but normal in OO languages.


Best OST to PST converter Software is reliable and smart way to perfectly convert OST file into PST with full conversion mode. This software confer you best opportunity to transfer OST to PST, MSG, EML and HTML formats along with all email metadata - To/ Cc/ Bcc/ subject/ date and time.

Read more:- http://www.recoverydeletedfiles.com/ost-to-pst-converter.html


good
following discussion in https://github.com/Ultimaker/CuraEngine/commit/263eb370e980c1bd77d2b76a1d6d0d79fc7b3d09
[ REVIEWED ]


yep, indeed. fixing. thanks.


just do it


Лучше используй тут `document.querySelector()`


sprt(0,5) please. your formula is certainly more complex than the original.


@RazerM Apparently the deployment filter has an issue with finding the wheel files. Could you take a look? (ran on a test branch at https://ci.appveyor.com/project/vmalloc/logbook/build/job/105qdge5ins65qnb)


Haha, what a lamer that FroMage…


why remove this ?


多了个逗号 = =


@nedbat your thoughts?


Ahh good point, I'll put it back then :-)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3737](https://teamcity.mesosphere.io/viewLog.html?buildId=68719&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:57


Can you install a full clean os on a different drive? And keep it all clean? Did you find something to get MAXWELL working? And has your card ever displayed anyting over any port? If you don't want to game or something you can try an 600,700,800 series card, i have a 670 and it works great for 4k@60hz but only over dp, maybe you can find a dp to HDMI2.0 adapter? Im out of ideas i have no idea why this should not work.. Maybe some future drivers will support MAXWELL, im sure..


No, you mixed the 2, either

SRCREV_FORMAT = "qtwebengine_chromium"

or

do_fetch[vardeps] += "SRCREV_chromium"


No, I see now that we need two of these: here, and below for vGPUs.


DateTimeFixes (macumber) - Win64-Windows-7-VisualStudio-12: OK (2338 of 2367 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.77%25-yellow.svg)


is it bug ? if yes, can you mak another task or PR ?


Vergiss nicht über die Formatierung. Ansonsten ist es den Code zu schwer zu lesen.


Could you please elaborate on this? int_64 comes from seek. In fact we only have unsigned ints in this special case, cf. LoadImageFromMemory


Leave a comment


Where are the test scripts and other files we need to do the assignment?


any reason to remove this stuff ?


Done


This is wrong, the x pos should just be:
bar_p.x + BAR_W_TOT
(not -1)


Hey, I only noticed it when I copy-and-pasted it and then the compiler told me off, so I'm not sure I know XML any better :-)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3738](https://teamcity.mesosphere.io/viewLog.html?buildId=68720&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:08:35


The command is here:
https://github.com/ayende/ravendb/blob/v3.5/Rachis/Rachis/Behaviors/LeaderStateBehavior.cs#L51

And WaitForLeader is only used in tests.

*Hibernating Rhinos Ltd  *

Oren Eini* l CEO l *Mobile: + 972-52-548-6969

Office: +972-4-622-7811 *l *Fax: +972-153-4-622-7811

On Thu, Nov 5, 2015 at 11:21 AM, talweiss1982 <notifications@github.com>
wrote:

> I understand that this will fix the problem but doesn't this method has an
> hidden assumption now that there is currently no leader in the cluster
> (somebody might use this method in the future the wrong way).
> Also i couldn't find where do we issue an empty commit after we are
> elected, can you point me to the line where that happens?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ayende/ravendb/commit/e3eef93fd6505b9ca9a96e7041481073e28fdd4d#commitcomment-14207141>
> .
>


First of all I have no other option but to use the 960. MAXWELL thing I have no idea how or what to search for to get it working. I did have the 2 DP ports to work and yes I have DP to HDMI converter. I can try to do a clean install, of course and get the SIP disabled like before but what about afterwards? What are we going to do about the MAXWELL thing you've mentioned?


//bfg


@josdejong I partly agree and while coding I constantly updated the if statements to have brackets, because it's an habit.  But then I think I forgot a few.
But you're saying python if for experienced programmers?
Of course it makes it less error prone, but i think it's a bad idea to make everything more verbose for less experienced programmers.


Btw. This bug raised concerns for the following GitHub bugs:

- [Idea: A voting system for comments #209](https://github.com/isaacs/github/issues/209)
- [Issue mentioning commit should be back-referenced on commit it-self. #510](https://github.com/isaacs/github/issues/510)


Yes, that's far enough for image dimensions (TM).

memcpy would use a gain a size_t - so - we could use size_t here?


Travis does not have `23.0.2` yet. Hopefully they'll add it soon.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 58](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=423&buildTypeId=XbimEssentials_XbimEssentials) is now running


@splendido any feedback on this? if possible, i would like make the necessary changes & have a version published to atmosphere soon.


Yeah just noticed that.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 58](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=423&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:20


I am not sure how.

It is [this XDA comment](http://forum.xda-developers.com/showpost.php?p=63667558&postcount=174) which triggered me to add this feature.

Other no root firewalls decode and encode IP packets, which uses battery power and will result in a reduced internet speed, even when allowed. NetGuard doesn't have this disadvantages.


if key is not string, ignore it


@riversx this is dutch! :laughing:


Should probably be strcmp() == 0, same below.


It appears the switch to the lodash _.bindAll didn't work.  Will investigate in a bit.


TeamCity pull requests :: netty [Build 596](https://garage.netty.io/teamcity/viewLog.html?buildId=3018&buildTypeId=pulls_netty&guest=1) is now running


First pass at addressing #42.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3739](https://teamcity.mesosphere.io/viewLog.html?buildId=68724&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:09


@mcginty Don't you want to use separate strings for singular and plural? That bracketed stuff looks a bit clumsy... Separate strings are easier to handle for the translators as well. Unfortunately, I'm too dumb to do this myself :smile:


It's not my formula. Its still tweaking a parameter so what does it matter that its more complex....There is nothing new.


@mcginty Same here.


Typo on my part.
I'll get it fixed


Es ist immer besser die Klammern zu stellen, egal wie viele Operationen in denen du hast.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22893/testReport/) for this commit**


@d00rman the problem was solved with this commit. Maybe it was just a problem that was caused by a bad state of the node modules folder of the test instance I was using.
If I understand the way how node and NPM are working correctly. There should be two copies of texvcjs.
One in the node_modules folder of mathoid (which comes from https://github.com/wikimedia/texvcjs) and another one in the node_modules folder of texvcinfo which cames from (https://www.npmjs.com/package/texvcinfo).
The difference between the versions is that we removed the unused h version in https://github.com/wikimedia/texvcjs/commit/93cae49b4b837c0c073a5061229fc204ddee2827.
For some reason mathoid tried to use the git version within texvcinfo which caused an exception which was hard to read (https://github.com/physikerwelt/texvcjs/commit/a282bfbab57a439bff3f9ad6c362f6d804776e2d).
However, all might simply be caused by a corrupted node_modules folder.


## This is a markdown file


Weil es nicht so einfach zu verstehen ist.


I know, the whole sinkhole argument.
I wanted a better text though: "Full internet speed ( no IP packets decoded, encoded or otherwise handled )"
But yeah, that's harder to summarize into buzzwords. :P


thx alot - thats something for my weekend for sure :)


I would as it does not support additional transports, so not sure of the value of this in the specs TBH


init


I don't see why checking if the value is empty is necessary here (and in other similar parameters). You already check that the value is either "8BIT" or "BASE64", so an empty value would be rejected anyway.


Can you not validate the host in a normal production environment?  It just seems odd that we're making an assertion in a test environment for a test environment as opposed to for a production environment i.e. this does not actually prove that the library works in production


Alternatives:
* No speed reduction
* No bandwidth reduction
* No speed lost
* No lost bandwidth
* No less bandwidth

But IMHO a positive variant like '*Full internet speed*' is better.


right, will try to avoid it in future


We shouldn't forget to account the send parameter on the server side


Mainly for consistency of error messages (in other parameters, there is no
fixed value so no value there would yield "empty parameter" and in other
code it could yield "invalid parameter"
On 5 Nov 2015 12:49 pm, "Ondrej Mosnáček" <notifications@github.com> wrote:

> I don't see why checking if the value is empty is necessary here (and in
> other similar parameters). You already check that the value is either
> "8BIT" or "BASE64", so an empty value would be rejected anyway.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LuboO/iCalendar-parser_PA193_Rteam/commit/b75f8bd0e0ef1978b522411cc72da8d756bd75fb#commitcomment-14209077>
> .
>


**Code Quality: Nitpick**

Remove these bits of commented out code.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3740](https://teamcity.mesosphere.io/viewLog.html?buildId=68726&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:50


That's probably good enough. And, of course, I'll remember it if it's really important!


완전 멋있는 로그로 나오네요..ㅋㅋ


update by adanac


What happens in versions prior to 1.7.10 with this change?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3741](https://teamcity.mesosphere.io/viewLog.html?buildId=68727&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:46


Delete the overlap-f-min option.


This breaks the site's context: from the error template I can no longer access the site's dispatch rules to create urls.

Changing (back) to
```
Context = z_context:new(Host),
ContextRd = z_context:set_reqdata(RD3, Context),
Vars = z_context:get_all(ContextRd),
```
makes it work, but not sure what will break.


Checked :)


Bugged dom structure, not as intended.


Since that doc targets end users, the obvious replacement is the new repo given bellow.

The building of the packages themselves can be done in "any" place: a COPR server, Koji or just mock on any box.

For release 0.30.0, the packages were built and signed locally.


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 46](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=424&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


"No bandwidth reduction" sounds ok


This will probably fail to give the expected answer on Python 2 due to integer division. You would need ``float(gc) / len(seq)`` or a similar work-around like a future import.


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 46](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=424&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **SUCCESS**
Summary: Running Build time: 00:00:40


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 59](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=425&buildTypeId=XbimEssentials_XbimEssentials) is now running


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 59](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=425&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:23


There are three cases for the object at:
doc.getDocumentCatalog().getCOSDictionary().getItem("AF");

1. It does not exist yet - we create a COSArray - a setter is necessary here
2. A COSArray already exists - then we call a setter though it is not necessary
3. The object exists but is not a COSArray but some COSObject - this was a surprise to me and the subject of the bug. Then there is a COSArray inside this base COSObject. A setter here is not necessary and not called. I am not an expert of PDF content so I decided to do the "minimum necessary".

This use case (point 3) has been tested - that the resulting PDF/A-3 is valid.

So the answer is: case 3 is correct IMHO, case 2 has an unnecessary setter.

Best regards,
  Ivan

On 5.11.2015 09:52, Bernd wrote:

In line 633 there is a setter even when you only modify the array, in this line 638 you do not call a setter after add. Is this correct?

—
Reply to this email directly or view it on GitHub<https://github.com/seeburger-ag/PDFA3/commit/162cdda7181ea54d412f9af1d50e6abcbf753972#commitcomment-14204078>.

SEEBURGER AG            Vorstand/SEEBURGER Executive Board:
Sitz der Gesellschaft/Registered Office:                Bernd Seeburger, Axel Haas, Michael Kleeberg, Friedemann Heinz, Dr. Martin Kuntz, Matthias Feßenbecker
Edisonstr. 1
D-75015 Bretten         Vorsitzende des Aufsichtsrats/Chairperson of the SEEBURGER Supervisory Board:
Tel.: 07252 / 96 - 0            Prof. Dr. Simone Zeuchner
Fax: 07252 / 96 - 2222
Internet: http://www.seeburger.de               Registergericht/Commercial Register:
e-mail: info@seeburger.de               HRB 240708 Mannheim

Dieses E-Mail ist nur für den Empfänger bestimmt, an den es gerichtet ist und kann vertrauliches bzw. unter das Berufsgeheimnis fallendes Material enthalten. Jegliche darin enthaltene Ansicht oder Meinungsäußerung ist die des Autors und stellt nicht notwendigerweise die Ansicht oder Meinung der SEEBURGER AG dar. Sind Sie nicht der Empfänger, so haben Sie diese E-Mail irrtümlich erhalten und jegliche Verwendung, Veröffentlichung, Weiterleitung, Abschrift oder jeglicher Druck dieser E-Mail ist strengstens untersagt. Weder die SEEBURGER AG noch der Absender (Vaklinov. Ivan) übernehmen die Haftung für Viren; es obliegt Ihrer Verantwortung, die E-Mail und deren Anhänge auf Viren zu prüfen.

This email is intended only for the recipient(s) to whom it is addressed. This email may contain confidential material that may be protected by professional secrecy. Any fact or opinion contained, or expression of the material herein, does not necessarily reflect that of SEEBURGER AG. If you are not the addressee or if you have received this email in error, any use, publication or distribution including forwarding, copying or printing is strictly prohibited. Neither SEEBURGER AG, nor the sender (Vaklinov. Ivan) accept liability for viruses; it is your responsibility to check this email and its attachments for viruses.


@pablobrodt

Foi um arquivo só, né?

Ele foi adicionado para implementar um exercício? Corrigir algo? Melhorar algo?


@markphi2013 can you have more than 1 inline box in the page? Yes
The thing is that the html ID should be unique.
```
The id attribute specifies a unique id for an HTML element (the value must be unique within the HTML document).
```
so if you have more than 1, use the class for the css.


This is too fragile as a doctest, the exact formating will be Python version/implementation dependent. Maybe:

```
>>> print("GC as a percentage %0.2f" % GC("ACTGN"))
GC as a percentage 40.00
>>> print("GC as a ratio %0.2f" % GC("ACTGN", False))
GC as a ratio 0.40
```


With customizations like these i see myself getting lazier every day :laughing:
Nice one!


Treba upisati nove podatke


ok


lokanaft, не смотрели по моему сообщению.
Если выбрать количество выводидимых записей в гриде, то при переходе по другим директориям  типов контента, применяется ранее выбранный фильтр.
Если пройтись по всем директориям, то в базу будет внесен первоначальный фильтр у всех типов контента.
Это так и задумано?


add plot1.R


why `(window.location.protocol == 'file:')` and not `(window.location.protocol === 'file:')`?


no comments


I think its unused code, is there any place where we passed selection in onchange result ?


color update via @ioana-chiorean https://github.com/mozilla/mozfest-schedule-app/pull/59


thanks)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3742](https://teamcity.mesosphere.io/viewLog.html?buildId=68730&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:44


Overall looks good :+1:

One minor thing is the space after the `!` on line 137. Conventionally its pushed up against the expression to become:

```ruby
if !entry
```


Well we should always propagate context, @vbh-odoo would you please create separate commit for this.


LGTM


superfluous comment


Incredibly minor: In the commit note you say, "courtesy of the __`next_node`__ block below it" where I think you mean, "courtesy of the __`next_node_calculation`__ block below it".


Will this work on VC++ as well? GCC and Clang offer this as an extension, but VC++ doesn't.

Also maybe it would be worth a static_assert for "unwelcome" types (ie the types are not polymorphic, abstract, etc)


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Change the help message to:
```python
help='Defines the columns of the sim_inspiral table ' \
'that store the optimal SNR for each detector. If the optimal SNR of an ' \
'injection is 0 for a detector, that detector is assumed to be down during ' \
'the time of the injection. If all of the optimal SNRs are 0 for an injection, ' \
'that injection is skipped.'
```


Change the last sentence in both of these help messages from:
```
If more than one ifo specified, this will be multipled by N**(1/2) where N is the number of detectors.
```
to:
```
This is multiplied by N**(1/2), where N is the number of non-zero snr-columns for each injection.
```


Is there no new tag for this? Should we ask them to tag a new release?


GitUI.csproj used for all builds


Comit


What does the statement

```rb
col_check || row_check || diagonal_check
```

evaluate to if one of those methods returns false? You don't need the `if` or `return` here.


Спасибо, Максим! Я старался )

Про код в разных файлах как-то интуитивно догадывался, учту в дальнейшем. Я
так мыслю, что там рефакторить еще и рефакторить :). camelCase обязательно
изучу. Ну а трейты решил использовать в целях саморазвития и лучшего
понимания материала. Практики у меня еще очень мало, поэтому постарался в
одной ДЗ попробовать несколько возможных решений. С классами оно вроде
как более
менее привычно и ясно, но все-равно после трейтов еще чуть-чуть лучше понял
механизм интерфейсов и наследования. Ну и показалось интересным применить
именно их вместо многоступенчатой иерархии и посмотреть поведение объектов
с трейтами и без - сама идея менять в рантайме поведение очень уж
заманчива. Насколько я понял, трейты позволяют в некоторых случаях
значительно сократить количество кода и облегчить последующее его
изменение, т.к. с помощью них одно и то же поведение можно будет назначать
разным, независимым друг от друга объектам, поскольку не нужно будет
описывать те или иные методы в разных ветках наследования. Получается
сквозная логика, которой еще вдобавок можно управлять с помощью цепочек
вызовов - получается оболочка, которая не зависит от конкретных реализаций
классов, а, наоборот, управляет их поведением. Поэтому я решил, что если
пойму до конца, как это все работает, то проблем с обычными классами у меня
точно никогда не будет. До этого, правда, мне еще предстоит написать не
одну тысячу строк кода :) Слегка сумбурно, наверно, но надеюсь, что со
временем и практикой я смогу более внятно и коротко выражать свои мысли.

А английский - да, без него никак. Ни одной книги по Groovy&Grails на
русском не нашел )

5 ноября 2015 г., 12:15 пользователь Maksym Bryzhko <
notifications@github.com> написал:

> достаточно солидное решение!
>
> но для такого нужно уже структурировать код в разных файлах
>
> хорошие комментарии, но нужно учить английский.
>
> Good job!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/alexkillgur/Groovy/commit/527daba88e4a65d8aa07c7828a6bec96dc85c9f6#commitcomment-14206917>
> .
>


@milon +1


What gives you confidence in a refactoring? How do you know it's a real refactor and not breaking anything?


:+1: I love when people use transpose.


I'm sorry about the WriteKeyVal error. I introduce it when adapt the code to mingw (copy - paste error). Sorry men :-(


Which exception happens here?


After this line, add:
```python
nzidx = sigmas.nonzero()[0]
if nzidx.size == 0:
    continue
sigmas = sigmas[nzidx]
```


`NullPointerException` ??


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3743](https://teamcity.mesosphere.io/viewLog.html?buildId=68731&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:50


This really should go upstream!


It's similar condition, isn't ?


See the comment before this function. "- calls $apply" should be removed from there.


This is the original file from here: https://www.gnupg.org/(fr)/download/index.html#libgpg-error ?


Accepted: https://github.com/M66B/NetGuard/commit/24ec979fe70ec0b8e25ae7fad80ecef1f9fd553f


Same thing here: if you rely on Ruby's implicit return, you can just use:

```rb
left_right_diag.uniq.length == 1 || right_left_diag.uniq.length == 1
```

without

 ```rb
return true if thing_that_evaluates_to_a_boolean
false
```


I need to change the image information a bit.
Is this correct? http://i.imgur.com/TJt1FBR.png


Replace this for loop with:
```python
for kk in range(nzidx.size):
    setattr(inj, opts.snr_columns[nzidx[kk]], sigmas[kk]/inj.distance)
```


:trollface:


I want to improve performance of layers by optimizing onDraw  method (for example not call it for every layer but only for those visible in current map view). More similar cases could be made with onDraw or with other methos - e.g. different construction of options menu etc.


Seeing this assertion reminds me that I came across [`FlowTestHelper#outcome_body`](https://github.com/alphagov/smart-answers/blob/master/test/integration/smart_answer_flows/flow_test_helper.rb#L25) recently which seems to let you do something similar.

I'm not suggesting you use `FlowTestHelper#outcome_body` as the reason I came across it was because I noticed that it was resulting in all flows being loaded when it was called.


误工费


The build was broken.


Maybe need take care the NPE for listItemsDisplayCodeName


OK, this all looks pretty straightforward (check columns, check rows, check diagonals), but how do you know it works? More important, is it as simple as it could be? We like to write unit tests first, which makes us more confident that things are working and helps drive a simple, iterative design.


J'avais aussi l'erreur en local, avec un sdk à jour.


@Saladoc Actually, lambdas still work properly. They are converted to a combination of an additional method and a method reference. SpongePowered/Mixin#71


LGTM


ok


I like this pattern, even though there's a little indirection.


"Arrays.asList(sourceArray)" will creat an array each time. Maybe can use List the API retainAll or removeAll to do, should be more better,


After you make the above changes, also change the name back to pycbc_randr_by_snr, then commit.


Should this be named `set_up_view`, maybe? The name doesn't immediately make it clear what this does.


Typo: “draggable,” not “draggle.”


Я потом его убрал :) Этот трейт был, чтобы посмотреть, какое влияние он оказывает на объект


TeamCity pull requests :: netty [Build 596](https://garage.netty.io/teamcity/viewLog.html?buildId=3018&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4796, ignored: 21 Build time: 00:35:56


Isn't that a syntax error?


Ага, теперь понял


Hmmm, I think I'd prefer a warning here:

```R
if (anyDuplicated(by)) {
  warning("Removing duplicated by variables", call.= FALSE)
  by <- by[!duplicated(by)]
}
```

I prefer using `!duplicated()` because I never remember the semantics of unique wrt to names.


I can maybe take a more "Janice" approach to things you don't want. What else was not being a bestie?


Ну вообще да. Надо собирать пользовательские мнения на этот счёт после релиза.


I like using methods in the standard Ruby object interface, like `to_s`, but its name is cryptic enough already. I'd consider extracting this line to a named helper.


Got it


Why is this here? Opening VPN settings only shows current VPNs added by hand, Netguard is not featured there.

And even if it would be, the only useful option there is the AlwaysOn selector, which is still broken: https://code.google.com/p/android/issues/detail?id=63450 ( aka you need [a root app](https://play.google.com/store/apps/details?id=ru.microlana.android.alwaysonvpnfix&hl=ro) to fix it :( )


This commit is being reviewed as a part of review issue #15.


Thanks for a pull request! However, I suggest using [get_object_vars](https://secure.php.net/manual/en/function.get-object-vars.php) function instead of explicit type casting, because the latter may produce some *garbage* keys in the resulting array: I'm talking about _private_ and _protected_ properties like described [here](https://secure.php.net/manual/en/language.types.array.php#language.types.array.casting) and in [this examples](https://github.com/kalimatas/zce/blob/master/arrays/arrays.php#L50).


What are the benefits of storing the winner statefully on this object? Any risks or disadvantages?


It is there to give the user an option to revoke VPN permission from NetGuard.


@diegomelo182 Não entendi bem: porque incluir o código-fonte do mdl? O bower ou npm poderia baixar isso.


As far as I can see the "2013-04-01" in the commit note should actually be "2013-03-30", as per the change in 413dee1e592df6de8b9141382146aab5cf9a5339.


Use an interface to be able to mock it for testing.


Tap the settings icon left to revoke.


ping to @mmzeeman


@robhurring this needed changed over to temp dir.  I didn't have an issue on El Capitan, but it was a problem on Yosemite.  Others apparently have run into it as well.


¿Qué tiene que ver? Mi duda es si al hacer esto

```java
 _test = Arrays.asList("hola", "chau", "jojo");
```
después podés agregar más elementos

```java
_test.add(...);
```


should be `===` indeed


This is ugly!! It causes building plugins even during instantiation (e.g. `--dry-run`). Please fix it.


This change is outside of scope of ChestShop's functionality, imho.


@matiasarayac direct commit to develop detected! :joy:. Se te pasó este `end` por lo que las seed arrojan error de sintaxis


The sentence under start_stop.rst is worded weird:
"The automated system setup with setup Apache to start on boot running the
+interoperability server."


CommonDate


What is the concrete difference between the dragmove event and the dragged event?
You can check this in the dragmove, too:

```javascript
el.on('dragmove', function(e, p, m, handler){

  if(handler.startPoints.point.x === p.x && handler.startPoints.point.y === p.y){
    // do nothing
    return
  }

  // do your stuff
})


На мой взгляд не совсем удобно. Тогда зачем для каждого типа контента создавать свою запись в таблице UPS, если в итоге настройка будет одинаковой для всех типов контента.


This works fine for me with any text I've tried. I get ^Ms at EOL but can easily fix that.


...  “indentation” was correct.


Is this being done to convert a `move` value into an array index? If so, you could put the expression right in the arguments like this:

```rb
place_piece(move - 1, board)
```

Or perhaps even better, explain what's going on by extracting a method:

```rb
place_piece move_to_index(move), board
```

By the way, writing tests alongside production code serves another purpose: documentation for others who read your commits. :smile:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3744](https://teamcity.mesosphere.io/viewLog.html?buildId=68733&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:49


Sure. This has been fixed since.


filters should not be a mutable keyword arg


Also in start_stop.rest:
"Teams should generally not be necessary for teams."


Can you simplify this further?


you are late :) 0.2.1 is out there?!


**README - Nitpick**
Use directory instead of folders i.e. `data` directory.


I :sparkling_heart: pry, but be careful about checking it in!


I think the ANDing logic is wrong here.
Will attempt a patch soon.


:+1:, I always like seeing this trick.


Why? It is a HUGE assumption that kernels don't need any post_exec actions. For example you may need to unload/reload some modules. Besides users who simply want to add something to kernel's post exec will do kernel.post_exec += [something] and it will generate an error.


Trick include:
Dynamic dashboards, auto email creation, auto powerpoint update, non conventional charts, conditional formatting and many more


remove this code, as we don't need to show any camera button.


В след раз если зайти откуда угодно, будет всё тот же фильтр и сортировка


Now that you have a view abstraction to handle your display logic, does `Board#to_s` still make sense?


**README - Nitpick**
This step is not needed.


Looks fine to me, apart from some minor comment


I'm unable to answer calls, and I think this will fix it. If I remember correctly, I had the same issue some months ago while testing KK blobs, and this sorted it then. I reverted it though since I went back to older blobs.


*README - Nitpick**
Check the casing — `Github`.


@matiasarayac ? definamos entonces con cuanto tiempo quedará el scheduler o si no movamos el tiempo al secrets


I second this!


Congratulations, very impressive work!

- Josef

2015-11-05 11:55 GMT+01:00 Norayr Chilingarian <notifications@github.com>:

> Did you change INTEGER from 16 bit to 32 bit and LONGINT/POINTER from 32
> bit to 64 bit for the 64 bit version of ofront?
> yes
> <https://github.com/norayr/ofront/blob/master/V4_ofront/linuxamd64/Ofront.par>
>
> As I said, 64bit version of Ofront is well tested in my project
> <http://oberon.vishap.am>, and ofront binary itself works and reproduces
> itself fine.
>
> If so, it is clear that there are many problems in the modules that
> interface the underlying OS.
>
> Yes, in order to get proper 64bit Ofront binary these
> <https://github.com/norayr/ofront/tree/master/V4_ofront/linuxamd64>
> modules were affected.
>
> Just wanted to share this information with you, so that if you or somebody
> would need it, the working command line version is in my repository.
>
> Later I'll try to bring commit something else.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jtempl/ofront/commit/4fd9fdf0352eb08e321599d4806cc8229eab5b47#commitcomment-14208011>
> .
>


Jaja, det var bare for at få noget ind. Rolf skulle gerne have ændret det til en anden Exception :)


This page is now linking to a adfarm playing howlers like this one: http://i.imgur.com/6tbGlDg.jpg

You might want to remove that from the docs.


I compiled for mips (AR9331), it succeeded, but when I try to run it I get `Illegal instruction`


Broken filenames should be fixed on Android now with https://github.com/dorkster/flare-engine-next/commit/74070a2433902793805c443218afc44152bd7812.


**README - Nitpick**
The last instruction on _press enter_ is not necessary.


not needed change


I can't see anything here that would warrant it but I just updated my box to test the dns changes and setup stopped after roundcube

```
Updating system packages...
Installing system packages...
Firewall is active and enabled on system startup
Creating initial SSL certificate and perfect forward secrecy Diffie-Hellman parameters...
Installing nsd (DNS server)...
Installing Postfix (SMTP server)...
Installing Dovecot (IMAP server)...
Installing OpenDKIM/OpenDMARC...
Installing SpamAssassin...
Installing Nginx (web server)...
Installing Roundcube (webmail)...
root@box:~/mailinabox#
```

Running setup/start.sh again worked

```
Updating system packages...
Installing system packages...
Firewall is active and enabled on system startup
Creating initial SSL certificate and perfect forward secrecy Diffie-Hellman parameters...
Installing nsd (DNS server)...
Installing Postfix (SMTP server)...
Installing Dovecot (IMAP server)...
Installing OpenDKIM/OpenDMARC...
Installing SpamAssassin...
Installing Nginx (web server)...
Installing Roundcube (webmail)...
Installing ownCloud (contacts/calendar)...
ownCloud is already latest version
Installing Z-Push (Exchange/ActiveSync server)...
Installing Mail-in-a-Box system management daemon...
Installing Munin (system monitoring)...
updated DNS: OpenDKIM configuration

-----------------------------------------------

Your Mail-in-a-Box is running.
```


I just meant that you should preserve Daniel's authorship, because currently you indicate that you wrote the patch. It's good practice to keep track of authorship.

In this case you can just use git am to import from an mbox file.


please remove additional empty line


oops


thx for making me notice it, I just don't exactly know the spelling of some words any more, so I might just write them differently each time again based on the context. I hope I won't misspell that again :)


Alex, please check this comment. From reading the code I think this is what happens but maybe I got it wrong.


if you want False only then provide `entrypoint_name=None` - see https://github.com/inveniosoftware/invenio-db/blob/master/invenio_db/core.py#L67


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3745](https://teamcity.mesosphere.io/viewLog.html?buildId=68734&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 196 Build time: 00:04:50
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


The strangeness is that ^M don't happen always, but that probably depends on the source/program that filled the clipboard.

In some cases It pasted unrelated text into the clipboard. I think this was related to unicode text being placed into the clipboard and winclip failing to convert, probably a result of the `-m` flag. We could use `-w` but then we need a way to convert from utf16 to utf8.


They don't copy because util._extend requires an Object as the second argument, instead of a Function. Anyway, I've been testing with browserify and using node's `util` module is not a good idea as it needs to be browserified entirely. I'm pushing a commit which replaces `util.inherits` for @isaacs `inherits` (it comes with a handy browser version) and adds the dependency `shallow-extend` for extending objects which handles multiple object extension (as in extends(<target>, <source1>, <source2>, ...)) and doesn't care about the type of the sources. Please check them and tell me what do you think.


Remove the blank line.


Hey,
I understood from the beginning that the restrictions were valid for SEL
only.
But, for instance, from the output of the check, i cant see the status of
the power supplies.
Im afraid that, if a PS fails, i wont be able detected it, because the
status of the sensor is not verified and the event will be ignored.
Jaime

On Wed, Nov 4, 2015 at 8:09 AM, Georg Schönberger <notifications@github.com>
wrote:

> Hi Jaime,
> just to let you know - the restriction is only valid for the SEL (System
> Event Log).
> For the ipmi command itself, we always request all sensor types. But we
> also have included the ipmi-sel command (which checks the BMC event log)
> and there we apply the filter as the event log showed up with unusable
> entries.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/thomas-krenn/check_ipmi_sensor_v3/commit/867d0dbab8e31bd194d97c9a0f346b842fa20233#commitcomment-14175862>
> .
>


А если ему не нужен фильтр по параметрам для новостей, допустим в объявлениях. Придется его сбрасывать. Но потом решит зайти в новости, но фильтр уже сброшен и придется заново его настраивать.
Зачем сбивать с толку. На мой взгляд, фильтр должен устанавливаться для каждого типа контента индивидуально и сохраняться в базе.
Это лично мое мнение.


scope.selection is for the items you want to preselect before rendering the directive. i don't think this change watcher made much of a difference there because this ran only once when the directive is being rendered. the watcher doesn't gets triggered after its loaded.


You may as well make a peep move game command since guests can be picked up as well.


Yikes! Look at how long and nested these methods are! It's dangerous to drop something like this in without any tests around it. Again, it also means the code is probably more complex than it needs to be.


I will check both in depth, I've certainly not used any so my opinion was superficial. I liked more jsonschema because of the declarative syntax (schemas can be moved around as json easily), but maybe I'm missing something.


I actually removed a few options last night since they were dupes of the defaults. https://github.com/robhurring/dotvim/commit/97f66f1a6cc3b6997d9e4dd7dc8e0ac9873a16f9


:cry:


Я понял ваше мнение


something like: https://gist.github.com/ace20022/f3fd12ff1e68aa747066
It's getting quite complex because of all the possible overflows...


There is nothing except exynos_drm_gem_create() that calls this, hence your argument is invalid.

I agree that one should harden this call (preferrably by putting a BUG_ON() there), but your commit message currently is misleading. This is not fixing anything, since the non-aligned situation never happens.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3746](https://teamcity.mesosphere.io/viewLog.html?buildId=68735&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 196 Build time: 00:04:11


Although, I do see `pry` up at the top. I assume you probably used it to drop in to various points in these methods and check out their state. In the abstract, that's essentially the same as unit testing (it's all hypothesis, test, deduction), but you throw away the results at the end!


This is actually a good idea, thanks for the code


[Plan de Pruebas.docx](https://github.com/HISATEIN/RentaCarros/files/27970/Plan.de.Pruebas.docx)
[Requerimientos Software 1 V2.docx](https://github.com/HISATEIN/RentaCarros/files/27971/Requerimientos.Software.1.V2.docx)


@lodici I use file comparison/merge tools. I wish we could just dump the output into the scripts folder, hehe.

As scripts-builder doesn't compare to the original file, there are many parts that need to be adjusted manually.
I guess working from the top down:
* Value - With the value updates not working these now need to remain as the original.
* Static and Removal properties - Should remain as the original.
Scripts-builder is unable to determine where an ability is static, or what value to assign to removal spells (Which do seem a bit arbitrary #95) - To be honest I completely forgot about the Static property, it's not something which is attached to script files very often.
* Ability/Effect property - Many spell properties are Abilities (This is something that Scripts-builder could probably be edited to deal with. (Things like Buyback, Devoid etc.) - The ability and effect would need to remain separate, but also take into account any template changes to the text (for example, Looks like there's a new standard for the use of 'all' as in 'all creatures you control', all seems to no longer appear for your creatures, only where there's a different identifier i.e. 'All creatures your opponents control' or 'All black creatures'.
* Groovy code involvement - Linking into the Abilities and Effects. While most cards are completely groovy, and only need to retain the 'requires_groovy_code', some scripts are 'partial groovy', where some Abilities or Effects are removed and implemented in groovy code. These would need to retain the original section, but as above, taking into account rules changes.

With the image property itself, using it for non game-breaking image updates feels like a bit of overkill. I always saw it for image errors (wrong image, old text etc.) Enforcing image updates for things that are non-rule affecting, but that's just me :smiley:

Having scriptbuilder more integrated with the magarena files will help with identifying abilities and effects, allowing those to be separated. Also to have access to the original script files in scripts and scripts_missing for comparisons. Some things will not be able to be automated, but should go some way to help.


Please remove unused parameters cidr, ip_version, dns_name
Also include parameters to set admin_state_up, mtu, router:external, shared
make their default values True, 0, False, False respectively.

you can check these values for a network by running
neutron net-show NETWORK_NAME


I don't follow this change. Is everything that changed together included in this commit, or is it part of a work in progress? It's a good practice to try and make commits as isolated and atomic as possible.


i probably was sleeping when i wrote this holy crap


Hello guys, you removed the session_commit() + session_start() from the set() function, but you didn't deleted it in clear().

This is causing me a lot of problems. I call clear() a bunch of times during a request, and this produces a lot of set-cookies headers. This is bad because a request's header can be up to 8Kb of data. Lot of traffic, bad performance.

Do you want me to push a commit? @ikkez can you help?

PS: @bcosca, you wrote that you can't recall why you put those 2 lines. I tell you why.
This is because in php default session handler, the session is locked at the begin of the request. but if you want the changes to be available to the rest of the code, you need to hardly save the session. this however will produce a new header.
You could create a "soft" and "hard version of the set/clear functions (for SESSION), where the soft version is without those 2 lines and hard version if with.


:+1: for giving the user some feedback with this. A lot of games will just hang without any explanation as the AI chooses a spot.


This is a closable tag:
![screen shot 2015-11-05 at 13 50 28](https://cloud.githubusercontent.com/assets/14334459/10968812/399d20ac-83c4-11e5-8896-c182f1dfc1ca.png)


Yes, that's correct. we called it in the past "all in air" or "all in water" model. It replaces the three lines (air, glass, water) with an approximated straight line as it would be "all in air".


Flaky guestbook test /cc @karlkfi


Do you always want this, even in human-vs-human games? Should this be specific to the computer player? How would you implement that?


You're right, I haven't read before what the community had to say about, it's very v8 specific. I suggest we use [proclaim](https://github.com/rowanmanning/proclaim). Thoughts?


it feels like it is missing one or two words in `only accessible through it from outside though`


Const can stay here, there's no need to remove it


@JosephMillsAtWork Could you please make a separate commit for the gitignore file? thank you


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.739](http://teamcity.monogame.net/viewLog.html?buildId=11053&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


LGTM :+1:


What is broken in the context?

When you don't add the request data in the context you don't longer know what controller caused the error. We use this to generate controller specific 404 pages.

IMHO this is an omission from webmachine's functionality. We should implement a proper solution for this.


[whaaat](https://www.youtube.com/watch?v=qORouZ-qOgg)! You're kidding me. It's indeed in the Android conventions, you're right. I only know this naming convention from C/C++, have never seen it in Java or other OO languages. It feels really old (and unhelpful) to me. Like this 65536 method limitation of Android, which also reminds me of this period where 16 bit was the standard ;).

Anyway if we want to follow the guide lines we should start using these `m` prefixes everywhere. Not my personal preference but ok, I will start refactoring my code.


@edwardpenoyar almost there, please keep ```class="profile-photo img-rounded"```


Yes - what about:
```
size_t tocopy = (size_t) std::min((int64_t)size, mbuf->size-mbuf->pos)
```
This still isn't perfect, cause the minimum of those two might still be too large - but yeah - we really want:

```
int64_t tocopyt = std::min((int64_t)size, mbuf->size-mbuf->pos);
size_t tocopy = 0;
if (__builtin_add_overflow(tocopyt,0, &tocopy))
  tocopy = 0;
```


I should also add my favourite colour


> On 05 Nov 2015, at 13:55, Maas-Maarten Zeeman <notifications@github.com> wrote:
>
> What is broken in the context?
>
Site config values and dispatch names are undefined for the current site.


超量=0x1e72
超量士=0x10d5
超量机兽=0x20d5


A improved version of the "singleGeneDeletion" funciton is going to be added to replace this old version. A pull request is already created and to be merged :)


I guess here is a `return` missing …


Typo in commit mesage


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/22901/testReport/) for this commit**