With sourceaccess you mean :includeallpackages?

For now I wasn't aiming for anything, except making things more readable and reducing duplication.
Not saying there isn't any duplication left though.

In a second step I would then think about removing methods or changing their behaviour.


Magic pixel?


fixed. thanks

On Wed, 25 Nov 2015 at 10:05 Jake Benilov <notifications@github.com> wrote:

> @duncanjbrown <https://github.com/duncanjbrown> this isn't necessary
> anymore
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/1Pass/1pass-reference/commit/0b578f1fb52570769e78373e1cab186bc86023b7#commitcomment-14611616>
> .
>


Make sure that you deepCloned this stuff
 https://github.com/drwebmaker/graph-explorer/blob/visible-dataset/src/GraphExplorer.js#L22


[`Object.try`](http://apidock.com/rails/Object/try) is ActiveSupport specific method. You shouldn't use it in gem which is not explicitly depending on ActiveSupport.


Okay don't get salty with me :P

Sent from my iPad

> On 25 Nov 2015, at 09:19, Orion <notifications@github.com> wrote:
>
> or not thinking properly about it
>
> —
> Reply to this email directly or view it on GitHub.
>


Is possible not assign null


Fixes are underway.


it would have been better if you could have all those changes in a separate commit


Ready to be made into a PR yet?


Moet `getLinkedCompanyIds` dan niet aangepast worden om altijd een array terug te geven in de plaats?


"var" need to determine at the beginning of the function


Couldn't this be merged with the main "check feature" commit?


Two comments:
1) It would be nice to have this logic implemented in FileService. For example, FileService.IsLocked(file). It may be useful in other places.
2) We can deal with locked files like we do for read-only files: we can offer the option to unlock. That's what TextEdit does.


We are only passing 'returned' at present.  All other values could be deleted!


It is better if this test before forming the "totalsGrid"


The ResolverService is meant to do the following:

* set the outcome on the 'intermediary object': Benefits, BenefitsOverride, Income, EvidenceCheck, PartPayment
* set the decision on the Application


Did you run `npm publish` itself or only tag it?
On 25 Nov 2015 5:30 pm, "Riki Fridrich" <notifications@github.com> wrote:

> This is strange. The releases are public and seem to be tagged properly (
> https://github.com/fczbkk/css-selector-generator/releases). Any idea why
> this is happening and how to fix it?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fczbkk/css-selector-generator/commit/465160064b8f62897d51cf0f2504ea13bc026bad#commitcomment-14607833>
> .
>


gpio_write_post should not be called if gpio_write_replace was used. Also I don't like gotos, their use should be limited to error/exit cleanups that get reused, this is not one of them.


Super tof !


Thanks @tde-banana-odoo , just a detail: don't you usually set the PR author as  commit author ? ref https://github.com/odoo/odoo/pull/9667


@dragotin @danimo Does this fix the tray woes we had or is it just a guess?


`def dump(*records, **kwargs)` or allowing `record` to be a generator?


uuu pa ovo je BAŠ lepo! :+1:


No worries.. it's already gone.. ;)


It's in the file service -it's in RequestFile edit which always fails. The text editor now treats locked files as uneditable file.

I think for the locked state there should be a solution outside of the IDE because it platform specific and we would interfere with other tools if we do that. However RequestEdit may unlock the file too.

In general I do not think that we should introduce IsLocked - we should handle that in one logic. It doesn't matter why the file is uneditable.
There are in general just two cases of uneditable files:

1) Files that can be made writeable
2) Files that can't

I put the locked files into 2) because of the interferance problems above (read: I need to know more about that before I can safely move it to 1) - in general it's safer to have things in 2).


I think I messed up my commit and pushed the wrong one. I added one commit with --author, but pushed the wrong one I think. But I am still not totally weaned from bazaar. Git hates me.


+1
updated


You forgot to update the javadoc accordingly.


nếu xóa hết sẽ bị lỗi session đấy .
t thử rồi


:+1: thanks!


Please, do not format the code automatically.
The exception was perfectly indented.


Same thing here.


I am new to Github and I would like to send you a message, unfortunately after some hours of trying :( I still haven't found a way to send you a private message.

I'll aks it this way and hope you'll read it.

I really like your Flappy duck interface and artwork!
Can I use the artwork from Flappy Duck for free?

Thank you very much in advance!

Iif you would like to discuss the above or send me a private message, you can send me an email at: mrjw1905@gmail.com


No need to mention author on methods.
Add your name on the class.


Ah no probs, was curious and it seemed like a strange thing to change. Thanks


Missing parameter name.


Yep you're totally right, I was quickly putting together a placeholder for future documentation and overlooked that, will be fixed soon! :)


(not null)


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23636/testReport/) for this commit**


Better use of ".bind(this)"


is `@comment` defined in this view? looks like you need it [here](https://github.com/hazukitran/Raddit/blob/master/app/views/comments/_comment.html.erb#L1)


Aha so you have the v2 PCB already working? :) Test it for a couple of days, if it works please release it on the mailing list :D


This method can hold in a single line.

```java
return map.containsKey( key ) ? map.get( key ) : defaultValue;
```


To rename into `openstack.volume-size`.


No. The first sentence of Javadoc comments MUST fit on a single line.
Please, update your Eclipse settings to use more than 80 characters per line.
And do not format automatically all the class code.


So @RobertCNelson this has definitely helped and I think it will help most situations.  There is certainly less errors on the port and it does handle the higher bit rate much better.

But...we are still getting our hangs when the data rate bursts to high levels.


The logic for checking if a file can be edited (your category #2) should be in a single place, because other features of the IDE may need to use it, that's why I suggested FileService.IsLocked. We can use a different name for the method.

I'm suggesting to deal with locked files like we do with readonly files because TextEdit does it, so it doesn't look that unsafe to do the same in XS.


No, there are options other than memory-related in the daemonJVMOptions


Neither. It's a prerequisite for the next patch to apply cleanly.


Not your fault here, but since we moved to Java 7 few months ago, you can write...

```java
private static final ConcurrentHashMap<String, Object> URL_TO_LOCK = new ConcurrentHashMap<> ();
```


Do not format...


Please, be more specific. Anyway, it is changed slightly in one of the next commits.


Rename CREATE_BLOCK into CREATE_VOLUME.


On a single line please...


Do not format automatically...
It makes more lines to review for nothing. You can format the lines you modify, not the other ones.


Hi @clintonskitson,

Before I'll review this please rebase this branch onto the upstream master. We've long-since accepted the dynamic config keys, and this feature is not using those. That will greatly affect the code being reviewed.


Ha I should removed it when 'office' was added to tablet/desktop version as well. Thanks!


Format this block comment correctly.


You can just require json file as regular js without reading and parsing


Why do we prefer numbers value for a line-height?


I see that after this merge the change from pull request #194 (https://github.com/domoticz/domoticz/pull/194)
is discarded. The pull request was accepted by gizomcuz 11 days.

Is this intentionally? Perhaps the change was not ok?


Useless log entries will have to be removed. Later.


Check if animation exists in hash


I think this won't work.. You should call the save method on the rails controller.


Really? :) I thought <br> is most hated tag ever :)


SanitizerFixes (DeadParrot) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1435 of 1435 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.5%25-green.svg)


If you look at https://cmake.org/cmake/help/v3.3/command/target_link_libraries.html
It's not wrong syntax, but it's preferred to use just PRIVATE and PUBLIC, tbh I'm not sure any of the links should be public, so maybe just replacing LINK_PRIVATE with private would be ok.


Please, suggest to me how to do.


@foolair it's not connected to the change in any way.


Yeah. I think that is good enough


I already made a few changes on that commit, but I am kind of lost. Have a bunch of web pages open to see if I can find what I need, but still nothing.


Problems


Mixed or pure spaces? And also what style are we using?


The RequestEdit method is a single place. However it can be extended - maybe splitted into:

GetFileReadbleStatus() (Category 1/2)
and
MakeFileWriteable()


Thanks for catching it @lucaa.


OK understand, miscommunication. Yeah the idea was indeed to have a proof-of-concept, an example to test with the web UI. Usability-wise a transformer query string with regex validation is maybe not the best, but what is the best approach is not relevant here, and will be decided on a different level. Right now I'm only interested in making the web UI datatype-aware.


I added https://github.com/trentm/python-markdown2 and a make file for conversion from markdown to HTML.


@tai271828 I think the title should be stronger, like "Design the Probe Facility".  How do you think?


This part is not good.
There is no waiting here. How do you check that the storage was created before attaching it? You don't.
And this block is not fully coherent with the previous line. It should look like...

```java
if (this.state == State.CREATE_VOLUME)
	if( createBlockStorage())
		this.state = State.ATTACH_VOLUME;

if (this.state == State.ATTACH_VOLUME)
	if( attachVolume())
		this.state = State.COMPLETE;
```

`createBlockStorage` will always return true.
`attachVolume` will return true if...

* ... no volume was supposed to be created.
* ... a volume was supposed to be created, and it was created, and it was attached.


Do not format...


xdg_data_home ne me semble pas une bonne idée.
Ca signifie que les données et les logs sont dans le répertoire home de l'utilisateur, donc pas d'accès à la même base pour un autre utilisateur ?
Par contre pour le config.dat ça me parait correct.

Peut-être pourrait-on se concerter avec le 3ème utilisateur noethys qui s'est penché sur les deb  pour que chacun se concentre sur ses spécificités de paquetage liées à la distrib, mais que les modifications qui touchent noethys soient compatibles avec ces différences ?


Thanks for your commit. However, the YQL console continue reading the flickr.photos.getInfo.xml ODT located in a http://www.datatables.org/flickr/flickr.photos.getInfo.xml path where contains the old document (http instead of https). Do you know when the committed ODT is updated in a YQL console?


if (options.domain && options.domain !== '[]') ?


Sounds good


Fixed


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 122](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=521&buildTypeId=XbimEssentials_XbimEssentials) is now running


What are you trying to do? Maybe I can give you a hand.


This method should retrieve the volume and verify its was created and is ready.
If it is not, then it returns false. Otherwise, it attaches it to the VM and returns true.

And if no volume was supposed to be created, it should return true.
True means this step is complete. False, that it has to wait.


channel might be undefined


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 122](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=521&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:05


No, do not store IaaS structures in this class.
Get them on every invocation. Remember that this class is used asynchronously. The **configure** method will be invoked every 2 seconds until it returns State.COMPLETE.


ha, good spot!


Generally it is because it's been misused to add line breaks in paragraphs, when you really should have just ended the paragraph tag and started again. Also a lot of WYSIWYG editors used them for that same reason. However, here we're not really defining a paragraph, and especially for the address tag it's common to break the lines up using `br`.


学习中心课程列表头像样式更改


ah no, you just changed it here :)


definitely


Step by step:
1) https://help.github.com/articles/configuring-a-remote-for-a-fork/
2) https://help.github.com/articles/syncing-a-fork/
3) git rebase master gh35_collection_service_tests


just wondering why we need this code


@{kCVPixelBufferIOSurfacePropertiesKey : @{}, kCVPixelBufferBytesPerRowAlignmentKey : @16, kCVPixelBufferOpenGLESCompatibilityKey : @YES}


you mean the trailling whitespaces ? yes i've commited this in bit too fast.


это мб вынести в cfg


ok


This slight change would allow an arbitrary number of committers or issues to be listed. Not sure if it's necessary for this commit though. Just an idea.

```
{{ range .Params }}
{{   if eq (substr . 0 1) "@" }}
<a href="//github.com/{{ substr . 1 }}">{{ . }}</a>
{{   else }}
<a href="//github.com/spf13/hugo/issues/{{ . }}">{{ . }}</a>
{{   end }}
{{ end }}
```


Seems @kmod suggest to use underscore_case for C function instead of camelCase.


103643052-FiniteDifferenceFluxOutput (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1963 of 1972 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.54%25-yellow.svg)


typeが数値になっています


运行了一下代码分析，发现了好多溢出方面的警告，貌似还有一个进程id泄露？？总之各种warning啊，，，，，一个char buff[4096] = { 0 };居然告诉我可能4096个字节不够用！WTF!!算了先这样


uiuiui! ich winke das mal durch...lock ist nicht POSIX und ich habe mich auch gestern auf der mailingliste beschwert, weil das was selbstgehacktes ist (nicht bei busybox dabei)


I think in our situation we could have left it as `em` because we're using it consistently throughout the styles for the font size. But using a numerical value is independent of a length value (px, pt, cm, em, etc) and instead it will be multiplied with the current font size instead.


Well, it's totally my fault, writing to English-speaking mailing list with Cyrillic "From:" field.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6778](https://teamcity.mesosphere.io/viewLog.html?buildId=80872&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:11:00


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6776](https://teamcity.mesosphere.io/viewLog.html?buildId=80864&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:55


La modificación no funciona. Las dimensiones de la matriz torques no son las correctas para ejecutar la línea 193:
plot(time, torques(1,:), time, torques(2,:), time, torques(3,:),...
        time, torques(4,:), time, torques(5,:), time, torques(6,:));


They don't have to be unique (though `idwt2` is currently broken, bugfix incoming).


If `:return` contains a naked non-object/non-array type on the top-level, it doesn't show up in Swagger UI. Is this an expected behaviour?


Param doc needs to be changed as well then. I suppose `array|string` is correct..?


I don't know how to implement binary search for r_list, therefore I use this silly loop.


Okay, added this one back as well.


# Build and Release Folders
bin/
bin-debug/
bin-release/

# Other files and folders
.settings/

# Project files, i.e. `.project`, `.actionScriptProperties` and `.flexProperties`
# should NOT be excluded as they contain compiler settings and other important
# information for Eclipse / Flash Builder.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6779](https://teamcity.mesosphere.io/viewLog.html?buildId=80874&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:47


Same problem passing from 1.6.0.1 to 1.6.1.2

Specific prices are not showing up in front office.
I add the index id_product_2 but no success.
I wonder if the specificprice_priority is not the problem because the value of the field has completely changed with shop_id added.

What I can see is that $specificprice array is empty in product.php classe.
Where can I find where this object is read ?

Jean-Marie


For download links, I suppose we can just register error and forward. For inline content, I am not sure how useful the html doc is going to be


@timgraham Please backport this fix on the 1.8 stable branch.


fixed


This is how you know you've "made it".


@ssaumitra see five lines below this one


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1961 of 1973 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.39%25-yellow.svg)


Why is it mutating?


Why do you want don's install? Who is don?


virutalenv still works, right?


Definitely don't do this!


I believe this is correct, see second commit on PR.


I like the style of passing sys.argv into main().  It make main() more testable.


应该在博客里这么写

> 然后在重启后的终端里输入`csrutil status && rm -rf /`


Ignore this commit, I hit the wrong button on accident


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6781](https://teamcity.mesosphere.io/viewLog.html?buildId=80876&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:05:02


да почему? мы эту строку меняем как угодно и в верхний регистр и в нижний, и склеиваем и символ вставляем. мне кажется не нужно ее конст делать.


上传框架代码


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


I asked about `service.lower()`. My change is in relation to that.


I'd rather the requirements.txt were hand-edited to have only *your* requirements.  Many of these are secondary requirements (requirements of your requirements).  It's harder to see the essence of your project this way.


如果一个{}被 [].push.apply,这个对象同时也会被增加length属性，并且值+1，不用显示地length=0！


Do you mind using Napoleon style docstrings?  http://sphinx-doc.org/latest/ext/napoleon.html   They are much more readable, IMO.


It's blu_active

Don't change authorship, thanks

git commit --amend --author "engstk <eng.stk@sapo.pt>"


This was updated in https://github.com/wincent/wincent/commit/93264abafe5ca907a699ffd7cd1554d71e3f6b39

(I'm mostly adding this for my own reference later just in case I run into similar problems and end up following your path here.)


You can wrap this line (it's all inside braces anyway), which would be much better than keeping this unreadability.


fabulous!


self. notation is not necessary


This could be used in `ContentQuestionSummary.answer_required`


This is a great idea and actually I want to do this : D
Thanks for doing that first!!


修改index.html


@mrclay, I have made changes based on your comments. Should I make a PR to core? What do you think the handler ID should be?


Question,
Why offset is not size_t ?


isn't this a bad idea when you don't use DHCP?


пробелы


It would be nice to have these as options but ... maybe later


I read this post first after trying to install it manually from github, it told me "This extension is already installed to all applicable products" so I guess that either means it will not install the update unless I uninstall first, or it has already autoupdated.
When I go to Extensions and updates it tells me the version is 1.4.0 so I guess mine autoupdated without human interaction :+1:


The commit message has a type in it (rmeove)


On plain tex, the catcode of `@` character probably could be 12.  We might have to remove it from `\@undefined`.


Parameter name `unpack` in the docstring doesn't match `autobuilding` in the function signature.


This is not ok with the plugin use of osgexport
keep old code for this change


I re-published it. That seems to make it work.


No that was more ment likte, now i think about It, that is stil not solved :D. Was nothing against you. :P


Same as above.


online Git aanpassing


@koying By the way, the error message that `libamplayer.so` cannot be loaded is still present in the logfile of course. Should I change the loglevel of this message from `LOGDEBUG` to `LOGWARNING`, so that users that don't have debug messages enabled won't be confused?


Better to use `^2.0.0` here, since it will otherwise unnecessarily break for users who use (and may need to continue to do so) 2.0.0.

Don't know if Bower supports the tilde operator for version expressions.


@leearmstrong I expect your hangs are because you are missing this patch:
https://git.ti.com/ti-linux-kernel/ti-linux-kernel/commit/fb8f164e2cbc85b604d4ba20524bacde8761e15d


Just wondering.

If data > buf->used why not just clear the buffer instead of returning an error?


I want to invest my capital and then relocate with my family.in your coutry

My name is mrs zafirah rafiq from damascus syria, i am 56 years old, i
am one of the former senior inspectors for kawkab oil company, there
is a serious war going on here in my country syrian and i need your
help to help me rescue the life of my family out from syria. I need a
foreign partner to enable me transfer my investment capital and then
relocate with my family.

I have the total sum 13.4million used (thirteen million, four hundred
thousand united state dollars) if we can develop a good business
relationship with you in your country, probably we can invest together
as partners,

full name:.
Contact address:
occupation:
age:
your country;
If you are interested kindly contact me with this email:
(mrs.zafirahrafiq01@gmail.com

regards
mrs zafirah rafiq


Hi @Mpdreamz.

Any reasons behind removing the score from IHit interface?
Can't get scores by interface in any query now with current 2.0 branch.

Thanks


[倫理審査申請書APSAチーム吐合.docx](https://github.com/sooheei/APSA_Teaching_2016/files/43776/APSA.docx)
IRBの初稿です。


Is there a way to use it, or I should just refer to it? Or may be copypaste from it?


maybe, probably. guess it depends on how you configure NTP when you don't run DHCP. maybe there should be another file_line statement ensuring the standard set for SUNET hosts is in ntp.conf, DHCP or not?


It is, in a later commit https://github.com/alphagov/digitalmarketplace-utils/commit/fc513d91ec7c96a148104b803ceb95f6a5025269


Haha I know :P It's sill pretty broken! :D I'll fix it at the weekend hopefully :)

Sent from my iPhone

> On 25 Nov 2015, at 11:52, "Orion" <notifications@github.com> wrote:
>
> No that was more ment likte, now i think about It, that is stil not solved :D. Was nothing against you. :P
>
> —
> Reply to this email directly or view it on GitHub.
>


Yeah, you need to run `npm publish` for every version. Currently npmjs only knows two of them - `0.5.0` and `1.0.1`.


This looks wrong and redundant. Check this out later as possible solution to issue#2?


one option is to make it default false and turn it on for eduid only
but why not test for dhcp-assigned address?


Or this one. Only need one line not both


Hi Matt,

I've a private fix which I've yet to commit from testing but without this I can't even submit a Bender Job for LHCb due to the race conditions that occur at the repo level.

I've got a few changes which I'll put into develop asap,

Rob


How do you think about introducing a dedicated type `Xml_node::Type` reasonably defined as `String<64>`? If we do this, we could change the weird accessor functions to something like:

```
Type type() const
```

In my opinion, this would be much more convenient and natural to use.


I mean using "fattest option" for run new daemon, but now I think it's ok


My previous comment on this line is still actual.

https://github.com/thenuntis/NewsObserver/commit/73620f28e2b32e8e736afa21835ddfc25eae8b36#commitcomment-14588300


This doesn't work => For new user coming from 5.2, this migration didn't do anything (I've tested it, the size remains to 10).
Indeed, as the size was set to 10, I imagine that rails detect that it's not possible to decrease the column size.

It's maybe not an issue, but it means that all users won't have the same size for SNAPSHOTS.SCOPE.


try to use [travis generator](https://github.com/iamstarkov/generator-travis) next time =)
```
npm install --global yo generator-travis
yo travis
```


Мне кажется тут нужна проверка на str, на всякий случай(как в деструкторе).


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (897 of 899 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.78%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.87%25-green.svg)


Looks like `daemonJVMOptions` will be mutated here, but for prev line You use the copy.


resume


Why this buffer of one day?


ffff


how do you know if it is dhcp assigned?


Thank you @jogness, I am not seeing that message logged but under heavy load the Beaglebone Black just locks up.

Will check in with @RobertCNelson to see if that has made it into the BBB kernel and if not how I can apply this to one of Robert's kernels!

Thank you for replying!

Lee


Логотип — ссылка на главную


This line (`if (pos.y >= -mapInfo->map.gravity)`) makes no sense?


:smile:


@sospartan I've nothing against config file. I just think that it shouldn't be a strict requirement. Falling back to this when there is no config file sounds like  good idea.


do you need this really?


Стилизовать будем лейбл к этому инпуту


`remove_token` is called on logout, right? How often does this happen? Do we risk that running this operation will take a long time because it has been a while since someone did an explicit logout?


different NICs might be different speeds (eg management 1Gbps, data 10Gbps). How would one achieve this?


@akbertram this icon is not rendered for some reason. Any idea?


Already I added a check for hostname https://github.com/meedan/checkdesk/blob/91cff6dad2a6088a50db441f4f3c981d584341a3/patches/nodejs-multi-sites.patch#L136


строки 57, 59, 75 выдают ворнинги на signed/unsigned несоответствие. поправь.
Остальное ок.


Man wird sich umgewöhnen müssen, viel hat Vulkan nicht mehr mit OpenGL zu tun, aus meiner Sicht hat sich der Umstieg aber gelohnt, auch wenn es etwas gedauert hat :)


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 61](https://teamcity.labkey.org/viewLog.html?buildId=287522&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 26 (4 new), passed: 21 Build time: 00:50:08
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

##### there are 16 more failed tests, see build details
```


might be nice to include the percentage here.  The potential message looks something like this at the moment:

"Network receive rate on eth0 is above your critical threshold of 75000000B/s"

which isn't hugely human friendly.


这么搞的话，在scrollview上方加了背景的情况下 header直接就被盖住了好么！！！！


leifj@trurl:~/work/sunet.se/puppet-sunet$ facter | grep dhcp
dhcp_servers => {"system"=>"193.10.94.1", "wlan2"=>"193.10.94.1"}

kanske?


This whole stanza could be moved up to main, removing the need for this interim file and making it easier to follow the flow


It is best that in future you don't try and fix other functions whitespace like this. Just a minor point no need to change patch now.


by modifying network_checks_list


строки 25, 102,108 signed/unsigned несоответствие


That sounds good. For now I've fixed the current implementation, as it was only handling `Discover` and `Create` rules. Added a bit of explanation as well.


Other than comments inline, I've tested this and it works (that is, ansible runs, config files are laid down and alarms are created).


Hi,

The idea behind this was more to create a obfuscation of the ICMP payload data (to circumvent Intrusion Prevention Systems) no so much a secure encryption.
I used NaCl to do some testing on encryption (since ciphertext should be indistinguishable from random data) without the risk of breaking something when there are some security critical issues with the code.

Anyhow,
according to the documentation (http://nacl.cr.yp.to/stream.html)
"Note that the length is not hidden. Note also that it is the caller's responsibility to ensure the uniqueness of nonces—for example, by using nonce 1 for the first message, nonce 2 for the second message, etc. Nonces are long enough that randomly generated nonces have negligible risk of collision."

So increasing by one should be fine as long as its large enough


тут могли бы сделать на уровне блока, а не элемента


Looks like you missed some removal of `extend/` in wordpress.org plugin URLs.


@sameersbn Do you mind to accept such a change?


`var onInit = ...`


Why is this `delete` required?


tableView.backgroundView可以设置背景，如果觉得不够后期可以执行bringSubviewToFront:移动到最前端


whitespace


roger, pushed an update to this PR to make it default off


Gives access to some items that still don't work properly yet (like the new doors) - might be best to test each new item and comment out what doesn't work correctly before making a PR.


зачем модификатор тут?


I will be doing just that next time I get on computer :-)


На уровне блока, может, лучше было бы..


instead of date, there should be "latest", now it crashes


и тут поясни зачем модификатор


Extra empty line detected at class body beginning.


Space missing after colon.


Global variables are bad!  Mainly because they make the program difficult to understand since there is some shared state across many bits of code that should be able to run seperately.  Since their scope is global, it also means that images for one report could leak in to another report if we generated them in the same python run!  Here's more detail: http://c2.com/cgi/wiki?GlobalVariablesAreBad

The problem you are solving by using a global is that the emailing code needs to know which images to attach, but right now the graph images are built inside the `generate_report` method.

`generate_report` currently returns an HTML string.  Since you are introducing images as another thing to generate, it would be good if `generate_report` returned the HTML string and the images dictionary together.  This could be an example return:

```
{
    'html': '<html>....</html>',
    'images': {'graph1': '...', ...},
}
```

Then, `send_report` can be changed so that it understands this return format and passes the information in to `send_email` correctly.  `send_email` could take the dictionary of images as an optional parameter.


THanks @ioana-chiorean !


:-1: for that...
we cannot assume that the user on 5.3 will have this flag On.

If the problematic fixer itself already has the restriction to test things only on 5.4+, we should follow that.
If you want to have this flag On then we should have 2 envs - one with that flag On and one with Off.


Кнопки лучше делать на уровне блока


py2app sets the env variable RESOURCEPATH. This is probably a more robust way to do this.


Note!  This would be a refactor for all of the reports so the other reports' `generate_report` methods need to be retrofitted to return this format.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6782](https://teamcity.mesosphere.io/viewLog.html?buildId=80882&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:08:49


If it is discarded, then this is unintentionally. Your pull request was made against the MyDomoticz branch. Changes for Domoticz can best be patched against the master branch, because that's where all pull requests go in the end, including the MyDomoticz branch itself.


А мы не можем каскадом наследовать белый цвет от модификатора `--blue-background`?


`for label, image in image_strings.items():` would be more pythonic!


В целом — очень хорошо, ты молодец!


Unnecessary cast, I just comment on this one but you have more of these


Yeah, no


other -> another


Лучше даже Please, confirm or select another language


That part of code is for ensuring that when the user clicks the 'Close' button of the modal, the video stops playing. Without it, the video keeps on playing in the background after the modal is closed.


Instead of reversing the output you should reverse the for loop, and for performance reasons I'd also use a `StringBuilder` here


Another thing to note is that there's a `bold` face.  Regarding `font-lock-face` vs. `face`, `font-lock-mode` manages text with the `font-lock-face` property.  That's why if you test inserting propertized strings in a font-locked buffer, nothing happens if you're using the `face` property.  However messages are not affected by this, so you should be using `face` there.


LanguageConfirmation


Ну ок. Только давай добавим текст в ссылку, что бы на случай того, если не подключаться стили мы смогли бы увидеть хотя бы текст, а не пустое место...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6784](https://teamcity.mesosphere.io/viewLog.html?buildId=80884&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:13


второй логотип?


Sorry about the comment.. The comment is confusing.
The comment logged in , send back to home page silently should come in the if clause


У registerJs есть второй параметр. Если туда передать \yii\web\View::POS_LOAD - оборачивать не придется


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6783](https://teamcity.mesosphere.io/viewLog.html?buildId=80883&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:09:25


Tokens are immediately removed on logout and expiration is checked during token validation.
As a consequence, purging expired tokens from the token table is just a simple maintenance operation to avoid the database to fill up.
Typically these operations (cron) are run once a day, hence the constant value.
Do you think another value would make more sense?


Давай классы на первое место ставить будем. И зачем нам тут модификатор?


Раз уж делаешь такую функцию - заменяй аналогичные вызовы к Language::find()->all() на неё же.


@kutsyk, в ідеалі було б гарно, якщо б ти ще й виводи повідомлення типу "пароль розміром 6-30 символів"


It's ok to use sync version here - `mkdirp.sync(path.dirname(filPath))`.


Always include `err` in error logs.


This should be linked to https://github.com/NRGI/resource-projects-etl/issues/68


inline in the defaults file? Or in the overrides file in rpc-openstack? How would you even?

I think there's clear doc impact here, but maybe a max_speed per nic might be useful too


а вот тут подошли бы модификаторы лучше всего


@alexbaumgertner, затряднуюсь написать, кинься в меня ссылкой, что нужно прочитать, чтобы понять


解决方案是有很多，我的意思是类似这种的commit可能导致原来的项目中出现问题。


@Uaman, це хардкодіг.. якщо я потім в якомусь іншому місці щось зміню, то я буду ДУЖЕ ДОВГО шукати, чому не працює


Not that I can think off :(, excellent catch :+1:


у каждой страницы будет свой класс?


@EugeneButusov I think it should be a different key, not SOOM_ENTITY_ID


not sure it should be done in pull-request


Wat is dat dann?


https://regex101.com/#javascript
Нужно в комментарии добавить пример строки, которая попадет под это регулярное выражение
(`new RegExp("(?:(?:^|.*;)\\s*" + encodeURIComponent(sKey).replace(/[\-\.\+\*]/g, "\\$&") + "\\s*\\=\\s*([^;]*).*$)|^.*$"), "$1"))`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6780](https://teamcity.mesosphere.io/viewLog.html?buildId=80875&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:07


This makes sense. I think I don't understand what you are doing with the variable `next_expire_cleanup`?


Should'nt tasks requiring crontab schedule be listed and documented somewhere?

By the way, is the auth system doc up-to-date?
https://github.com/c2corg/v6_api/wiki/Authentication-Concept


hi


>Actually, Renderer.InputRenderTarget will always be null when Update is called (input render targets aren't even created yet) so there's no point trying to add it to the texture pool.

That doesn't sound right, it can't be null when we're rendering right?

>Now on to the next bit - make the Audio class implement IFilter. Any chance you could do that bit? :)

I'll have a look at it this weekend. I think the scripts behave more like filters than renderChains at the moment, but I might be able to figure something out.


@cz8s can you squash all 3 `base.pp` commits into one pls ? after this, i'll merge. thx !


Add `do-encrypt="true"` on an variable entry which should get decrypted:

-->

Add `do-encrypt="true"` on an variable entry which should get encrypted:


I started by creating a "support" table on the schema.rb file to store the name, email and message of the person. Then I created the form which I then changed to be similar to the one used on edit_profile. Now I basically want to insert on the table after the user clicks submit.


@sdherr, do you mean .findAll here?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6785](https://teamcity.mesosphere.io/viewLog.html?buildId=80885&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:08:38


I might be thinking on this the wrong way, but I am having a few problems


>Probably not, but should it complain that the first book does not have a
book?

I'm having trouble to pin this one down. Should REQUIRE_PROPERTIES just be ignored when doing a scan? If yes this test would break.

```java
@Test(expected = PathNotFoundException.class)
public void require_single_property_fail() {

    List json = new ArrayList() {{
        add(singletonMap("a", "a0"));
        add(singletonMap("b", "b2"));
    }};

    Configuration configuration = JSON_SMART_CONFIGURATION.addOptions(REQUIRE_PROPERTIES);

    JsonPath.using(configuration).parse(json).read("$..a");
}
```

on the other hand the path can be expressed as:

`JsonPath.using(configuration).parse(json).read("$.*.a");`

Some how the current implementation just seems to complicate things without providing value. It is only useful in very flat documents. As soon as you put a nested object in the structure its hardly not useful anymore.


@sdherr, if we are iterating through all the deployment-plans, how is this faster for the UI?


А, это сторонняя библиотека.
@dmitrylebedev не нужно комментировать.


@sdherr, I assume it's async as I see you changed the response of the API's to be 200


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6786](https://teamcity.mesosphere.io/viewLog.html?buildId=80886&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:08:57


Schadenfreude is a German word, so _^_DE would be better.


``fseek`` uses long and off_t is also a long. It seemed reasonable use long


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6788](https://teamcity.mesosphere.io/viewLog.html?buildId=80888&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:51


ok


Also converted line ending to Unix format


Var det inte detta som skulle vara false?


> Should'nt tasks requiring crontab schedule be listed and documented somewhere?

I am wondering if we should rely on a cronjob, or use something like [APScheduler](https://apscheduler.readthedocs.org/en/latest/).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6789](https://teamcity.mesosphere.io/viewLog.html?buildId=80889&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:41


@alexbaumgertner, а можешь мне пояснить тогда что она может выводить?


Why might you want to always pull changes manually rather than having Git automatically stay up-to-date with your remote repository?


@twbs/bootlint: So any thoughts about this branch?

https://github.com/twbs/grunt-bootlint/compare/dev


Almost but not quite. This line is saying any donor can view any donor message on any item. We need to guard it with the user_id of the offer.

    can :messages, Item, Item.donor_items(user_id) do |item|
      item.offer.created_by_id == user_id
    end


godd point with ``size > bud->used``


Ah, thanks. Would be good to add such information to commit messages:-)


初始化提交


sorry, I'm very busy these days. This link could help you :http://stackoverflow.com/questions/16613464/will-pod-update-overwrite-my-code-changes-when-a-new-version-of-the-pod-is-ava


Neste caso, "antipessoal" concorda com "mina", então no plural seria "Minas antipessoais" mesmo (:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6790](https://teamcity.mesosphere.io/viewLog.html?buildId=80893&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:58


This method is present in both editors - maybe we could add an abstract method to the base class?


@pynicolas indeed


You shouldn't change the schema.rb file. You should create a migration with "rails generation migration MigrationFileName". Please try to revert that and start over. After that you'll need to go to routes.rb and defined a POST request to the create action. Then you need to create a Rails Controller and defined the create action there. After that you can start to code in AngularJS. For example, when you click in the "Submit" button you send a POST request to the server via AJAX. The request will respond with something, as defined in the Rails Controller, and you can change the frontend page based on the response from the server. Just don't forget to return the data in JSON in the controller.


This method looks similar to the one for post editor. Could it be abstracted into the base class?


aaaaa


мда, кажись откатили все вчерашние изменения.


I would just construct formatted JSON string to not waste time on translating things which can be done by hands easily - all this stuff should be fast as possible.


Можно одной строчкой написать http://www.yiiframework.com/doc-2.0/yii-helpers-basearrayhelper.html#index()-detail


Is this test_get_visualizations2 an unused method or we should rename it elsewhere too?


@chiunam :+1: awesome, i don't have to fork then


Acabei deixando como Pavise mesmo. Mesmo a palavra existindo em português, "Pavês" causaria uma certa confusão.


s/seek/locking/?


А как лучше будет?
Я просто рассуждал что навигация никуда скорее всего не переедет, т.е. по сути не независимый блок, хотя вроде она очень сильно вляет на раскладку страницы.


FewDocFixes (Myoldmopar) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.49%25-red.svg)


You set the targetAliases only if the 'name' is not in the allQuerySetNames. Please confirm.

Should you add a 'break' here?


*overridden


test check one


Whoops, left something after debugging code, sorry


Those comments here are for `grep` / `CTRL+F`


Изанчально сделал на уровне блока, а потом поменял на элемент, т.к. вроде логотип больше нигде не будет использоваться. Или всё таки может использоваться?


Added laravel IDE support for PHP storm
(you can find it on https://github.com/barryvdh/laravel-ide-helper)
v 1.11.3 - because i'm using laravel 4.2


@pynicolas thanks!


Dammit!


Сделал модификатор, т.к. на планшетном и десктопном размере не будет гамбургер меню, чтобы задизейблить её.


Perfect commit, isn't it?...


I think `~=1.8.0` with do the right thing. It should always give us the latest `1.8.*` release, but it won't match `1.9.*` without a change to the requirements file.

https://www.python.org/dev/peps/pep-0440/#compatible-release


@laanwj Travis complains because you have forgotten to commit the changes to `Makefile`.


$cmssb=true;


rtgrtt


argv[2] is a string you dork. You should also run this through the expression evaluator.


accel.hを変更し忘れてると思われ


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 123](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=522&buildTypeId=XbimEssentials_XbimEssentials) is now running


Done! https://github.com/saltstack/salt/issues/29186


note for the future, let's squash commits sometimes: this one could have been incorporated into last commit (bb0108c) as the change is purely about style.

Read [here](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html) how to


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 123](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=522&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:07


well this seems wrong and the reason for #8234

maybe this would be expressed more clearly as:

    while(currentCode < parts.size())
    {
        code1 = parts[currentCode++];
        trim2(code1);
        ...
    }

(and remove the ".clear" one since they're redundant cleanup that'll happen automatically)


please check if there is any public API that changes state. if so - please remove the public modifier and expose the new ack, nack methods via a new interface


please have one registerMessageHandler call the other to re-use code


Thank you!


Per https://github.com/TMRh20/RF24/issues/160


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6791](https://teamcity.mesosphere.io/viewLog.html?buildId=80895&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:53


what is the meaning of --force and why is it needed for now?


Через псевдоэлемент main-page__jumbotron--triangle:after сделать треугольник, но ведь его можно сделать и так main-page__jumbotron:after  ))
Т.е. main-page__jumbotron--triangle избыточен тут?


It shouldn't be there at all. fixed in an  additional commit.


Do you want to send this as a pull request? I could include it in the official release. Are you interested?


тут вроде в if надо включать только delete[] str;


please change to ERROR level


Yes please!

> Op 25 nov. 2015, om 13:59 heeft Konrad Paumann <notifications@github.com> het volgende geschreven:
>
> Do you want to send this as a pull request? I could include it in the official release. Are you interested?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/roelofk/RunnersField/commit/c3a19389b800d132a09307a452897d70dc73ed29#commitcomment-14615229>.
>


The files look like it's uploaded incorrectly. You can't actually view the code :(


I am very confused by this


Looks like the alias is only needed when loadBalanced = true. Please confirm.


@pynicolas useless variable `issue`


rename to AckNackMessage


Actually, no: The code does the same thing after this commit. As the commit messages says: I remove a superfluous if statement. If line 57 is true, then obviously line 65 is true, thus 65 may be removed.

Bottom line: This commit changes nothing, except simplifying the code.


Ah, I hadn't spotted the `~`. Ridiculous bloody syntax :-(


why it is needed? dont we use ompi_proc now?


Php storm template


ok ok saw that was removed anyway


Ich habe mir schon Mantle angeschaut und es ist die Art wie ich über OpenGL
intern denke wie es laufen sollte. Ich bin gespannt.

Am 25. November 2015 um 13:06 schrieb Sascha Willems <
notifications@github.com>:

> Man wird sich umgewöhnen müssen, viel hat Vulkan nicht mehr mit OpenGL zu
> tun, aus meiner Sicht hat sich der Umstieg aber gelohnt, auch wenn es etwas
> gedauert hat :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SaschaWillems/VulkanCapsViewer/commit/e664a59f57fec03230b14cab332806d4e20345ca#commitcomment-14614221>
> .
>


нет. надо еще и указатель занулять.


Are you sure? Shouldn't line 167 have been:
`if(count($values) == fieldCount)`

And I'm just reading code here, but the whole function 'bulkInsert' seems wrong. Only 1 INSERT statement is actually executed, so only the last values in the data array are inserted.


good, can you change the badges to the upstream repo?


#4399-ZoneSum-vs-VentilationRateProcedure-when-one-zone-has-zero-oa-requirement (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1435 of 1437 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.86%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.51%25-green.svg)


The same fix should be included in LongPollingTransport.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6792](https://teamcity.mesosphere.io/viewLog.html?buildId=80900&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:05:06


body_html = self._get_gitevent_body_html(pull_data.get('url'))
![1444056498_github_social-network-communicate-page-curl-effect-circle-glossy-shadow-shine](https://cloud.githubusercontent.com/assets/13314519/11397908/00f2e40a-93a3-11e5-838c-f1ffeb8526b2.png)
# This is an <h1> tag
## This is an <h2> tag
###### This is an <h6> tag
*This text will be italic*
_This will also be italic_

**This text will be bold**
__This will also be bold__

_You **can** combine them_
* Item 1
* Item 2
  * Item 2a
  * Item 2b

1. Item 1
2. Item 2
3. Item 3
   * Item 3a
   * Item 3b

![GitHub Logo](/images/logo.png)
Format: ![Alt Text](url)

http://github.com - automatic!
[GitHub](http://github.com)

As Kanye West said:

> We're living the future so
> the present is our past.

I think you should use an
`<addr>` element here instead.

@app-test
@jpr-odoo
@jpr-test


Should this commit be merged into maintenance/1.10.x?


Sorry guys, it seems that it's quite hard to write markdown which will give the same result in two different markdown parsers :(
I was "fixing" this to make output look correctly in web version (http://esp8266.github.io/Arduino/versions/2.0.0-rc2/), apparently need to make a few iterations to find the right amount of spacing so both versions look the same.


@baptistebriel haha did you see that?


you should not commit that to the repository, should be part of .gitignore


same stuff, whole '.idea' should be ignored by git


Сломана капча на ычане, nowere.net. Она должна меняться в зависимости от треда, а сейчас она постоянная.
Еще я не пойму логики, зойчем функция update выполняется три раза

```js
	update(focus, isErr, tNum) {
		console.log(1)
		if(tNum !== this.tNum) {
			this.remove();
			console.log(2)
		} else if(!this.hasCaptcha && !isErr) {
			console.log(3)
			return;
		}
		console.log(4)
		this.tNum = tNum;
		if(!this._added) {
			this.add();
			return;
		}
		console.log(5)
		this._lastUpdate = Date.now();
		...
```

```
1
2
4
1
2
4
1
4
```


merge test into master


should be an enum


Причем, `tNum === undefined`


@pynicolas `check` parameter is unused


component is really bad name for the package, should follow a convention with reversed domain name (could be the one from ug.edu.pl)


Why open with ":encoding(UTF-8)" here?  This does not follow the convention used in other parts of SSP.


don't use star (*) imports (there is a setting in intellij for that)


use access modifiers


be consistent with language of choice GifEngine vs. zaladujPlik


you don't need to merge your feature branch into your dev branch (if that's what you did here, according to the description of the commit)

all that is required is to have some changeset in a branch, and when the PR is accepted it will be merged into the destination branch (i.e. AEGEE:dev)

that was just FYI :)


use guava Preconditions for such cases


I suppose that onInit from options will override onInit method passed to JQuery.extend
Maybe we could reverse parameters in jQuery.extend(), but I found useful that the call can override options.


We don't generate these files. I am wondering why should we carry it in .gitignore file.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6793](https://teamcity.mesosphere.io/viewLog.html?buildId=80905&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:05:05


Надо, но почему-то я решил что
if (str)
{
			delete[] str;
}
str = nullptr;
Видимо переклинило;)


This should be fixed in https://github.com/ganga-devs/ganga/commit/5e233ff960b64a1d9d0720b3bafbc7c9add59fe8


So instead we provide an instance to the `RestModule` in `IngestPlugin#onModule(ResultModule)` or something similar?


magic number


in order of importance, it should be : page.twitter_image -> page.fb_image -> default logo


What do these two files do?


readme


where are types?


哥，发个新版本啊。我在用 v8 profiler 测性能，发现装下来的是旧版本


use Java 8 stream() for that


templates goi


no logging framework


A TrueCraft commit :D iluvu


Gostei muito dos nomes que você usou, na verdade! Acho que poderia ficar assim mesmo (:


Nyt täällä GitHubin puolella


Я так понял: если строка есть, str не равна нулю, то деструктор ее должен удалить(очистить.) и занулить указатель.
А если строки нет, то удалять str не нужно, а занулить указатель все равно можно, это ни на что не повлияет (т.е. ошибки не будет). так что твой вариант тоже норм.


Instalação na maquina virtual XP


yeah I think we should work on those in master to make it less instance dependent - I can take care of this for now


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6795](https://teamcity.mesosphere.io/viewLog.html?buildId=80907&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:10:50


@kosssi by curiosity, why circle-ci, and not travis?


Ok, I see what you mean. Maybe you want to use a different name to make it clear that there is a difference? For example `postInit` or `onPostInit`?


Please see https://github.com/composer/composer/pull/4637.


@mli-ableton: please change this commit to use the same technique as for `"-Wunused-local-typedef`.


this check should be moved to 'uaktualnikGifa' method


possibly unsafe


Instalação no windows XP


The list of IPs is incomplete, which I assume is meant to be a list of public DNS resolvers that are known to have been blocked by the most common RBLs?  Rather than attempt to curate a list of DNS resolvers that are known to have been blocked by the RBLs (does anybody have a list of those?), I suggest actively testing each of the resolvers in /etc/resolv.conf against one or two of the popular RBLs to see if that DNS resolver is being blocked.  This would also be a good opportunity to introduce a general check of each DNS resolver in /etc/resolv.conf to ensure that they are actually usable to make DNS queries.


It looks like github is bugged. The commit diff is not being showed here. :/
I guess one will need to review this patch locally.


Testing


Is it a good idea to keep both: jslint and eslint? It'll print many duplicate linting errors to the console. Also you haven't attached eslint to gulp watchers. And lastly, there's a great [eslint-plugin-angular](https://www.npmjs.com/package/eslint-plugin-angular) for linting Angular apps.
What do you think?
Cheers.


comments like that should be removed ;)


Можем. А так как я сделал лучше не делать?


Minor nit. Can we output something like "Device ${dev} is already partitioned and is part of volume group $VG"


Спасибо!


Sorry, but it's reversed.

Just downloaded today build, and when we already have a defined 'final
destination', if we choose another spot and click the bottom bar 'black
flag',  this new spot is then set as the final destination (not a
waypoint), and our previous 'final destination' is changed to be set as the
first waypoint.

--
Cumprimentos,
D.er Hugo Barrocas


Right, oops, I will revert. I am getting crashes reported in this function though so I'm not sure what else it could be...

If you have a clear view of the intent of the function, a rewrite would be appreciated, as I still don't understand exactly what it is trying to do :)


last note but most important - NO UNIT TESTS!


В том то и дело что он срабатывает дважды, получается второй раз он совершает лишнее действие?


i let the admin be the redirect page


This could probably be "Device $dev is already partitioned. Can not add it to volume group $VG".


`offset + size` may overflow. Please, check with `sol_util_size_add()` - and thus you may need to change `offset` to `size_t`.


Wouldn't it have been better to cherry-pick 8b78f2ed11c2686d3707a3b619f1b220b8700333?


Он захардкожен


Looks good to me.

@sjanuary is this ready to merge?


J'en déduis que je suis le 3ème utilisateur.

xdg_data_home est certainement le dossier ou placé l'installation de Noethys (je pense), donc /var/log/Noethys/ serait dans ce cas relatif à cet emplacement.

Aussi, je suggère de ne pas toucher au code original et de préparer des patch spécifique pour Debian qui seront appliqués automatiquement pendant la fabrication du paquet.

Je vais tenter de faire ça rapidement.

Olivier.


Hi Yariv,

Thanks for letting me know!

Didn't get the chance to check the imports. In general, GraphView is
instantiated 3 times in the landscape mode screen to visualize waveforms
for the green+blue optical signals and acceleration. What I usually do is
import the latest changes from our internal repo to GitHub and push. It's
possible I missed a dependency error as you described. Care to fix it so I
can pull it into master?

Ping me for any questions.

Be well,
--EJ

On Tue, Nov 24, 2015 at 11:11 PM, yarivs <notifications@github.com> wrote:

> Hi, I can't find out where the class GraphView came from. It's not
> imported, and it's not contained in the package either.
> Is the master branch stable?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SeraphimSense/angel-sdk/commit/833abb8df35e53900df45b4ce4f5d3325e588632#commitcomment-14600807>
> .
>


커밋내용이 메시지랑 안맞는것 같아요ㅋㅋ


Deleting 100'000 tokens based on the indexed expire value takes 70ms.
That seems reasonable.

c2corg_gberaudo=# explain analyze delete from users.token where expire > now();
                                                    QUERY PLAN
-------------------------------------------------------------------------------------------------------------------
 Delete on token  (cost=0.00..2138.00 rows=100000 width=6) (actual time=77.213..77.213 rows=0 loops=1)
   ->  Seq Scan on token  (cost=0.00..2138.00 rows=100000 width=6) (actual time=0.004..20.934 rows=100000 loops=1)
         Filter: (expire > now())
 Planning time: 0.104 ms
 Execution time: 77.226 ms
(5 rows)


Why not  `struct type_description type = { }`?


Yes, I missed it at the time.

On Wed, Nov 25, 2015 at 05:24:37AM -0800, Eelco Dolstra wrote:
> Wouldn't it have been better to cherry-pick 8b78f2ed11c2686d3707a3b619f1b220b8700333?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/NixOS/nixpkgs/commit/a890f8e6967d508f5588c24fff7862b12d3d828e#commitcomment-14615759

--
(Escriu-me xifrat si saps PGP / Write ciphered if you know PGP)
PGP key D4831A8A - https://emailselfdefense.fsf.org/


I am not sure that we need to add "when docker-storage-setup is initially run". Reason being that one can add a drive even later and re-run docker-storage-setup. So docker-storage-setup always expects unpartitioned drives in DEVS=.


fixed + fragments opening correctly now


Closes #5, #6, #4


ketzt mach ich schon mal nen PR ;)


Thanks.


@nono j'ai utilisé pendant 3 ans TravisCI, j'avais envie de voir un peu ailleurs :dancer: mais c'est vraiment identique.
En réfléchissant un peu plus sur la question, TravisCI est plus open source que CircleCI.

Vous utilisez TravisCI dans d'autres projets cozy ? Si c'est le cas ça vaut peut être le coup que je change.
Aussi je préfère le badge de TravisCI ^^


The index is not even used and there are 0 rows matching the condition (i am expecting that deleting the rows is more expensive than doing the query). But you don't have to test further. Thanks!


add new line. :no_entry_sign: it means that need new line


@ened I cannot fathom why you would need to encode there... The data returned is unicode. Encoding as UTF-8 would mean getting back a raw string that is UTF-8 encoded.... It would be great to have a test case.


Who changed?


As above, this block is also giving permission for any donor to view any donor message on any offer... need to tighten this up.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6787](https://teamcity.mesosphere.io/viewLog.html?buildId=80887&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:08


its not clear to me why this timeout is necessary --> it also causes issues with clearing the cookies. is there a way we can rethink this?


There is no API that change state


Fair enough. I'll look into this. I think someone should just added a few variants of propertize for common transformations like bold, italics, etc to Emacs itself.

> Regarding font-lock-face vs. face, font-lock-mode manages text with the font-lock-face property. That's why if you test inserting propertized strings in a font-locked buffer, nothing happens if you're using the face property. However messages are not affected by this, so you should be using face there.

Good to know. I was never certain what's the difference between the two.


yep. I'd prefer `/srv/docker/wowza/data:/var/lib/wowza` over `/srv/docker/wowza/lib:/var/lib/wowza`


Per #3261 this should be IAS.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6796](https://teamcity.mesosphere.io/viewLog.html?buildId=80918&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:53


why you use autorize! for all methods. It looks like you already used it here
```ruby
before_action :authenticate_user!
```


add translation for this text. and put it like `I18n.t('some.another')`


There is new action: 3 points -> add as last intermediate point


Thank you for your reply. I created a new pull request for the master branch.


@kosssi oui, on utilise travis sur la plupart des projets. https://github.com/cozy/cozy-home/blob/master/.travis.yml for example


:heart: thanks


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 Total|||||


Extension of JS files (`.js` | `.jsx` can be omitted).


don`t afraid to remove useless code. You can always find it on github if need.


Link looks better than button because with link we don't have those a few pixels text shifting up. E.g. in attachment case it looks not good with text near "No file selected".

So I've chosen:
```
<a ui:field="browseLink" href="#"><ui:text from='{res.userName}'/></a>
```


Warum :disappointed:


@mono Ok je fais le changement tout a l'heure alors ;)


Separate *exporting* from *class declaration*, and use *ReactClass* decorator (always for React classes).

```javascript
@ReactClass
class Clock extends React.Component { ... }

export default Clock;
```

*ReactClass* decorator provide proper static properties inheritance and facilitates error handling.


Am 25.11.2015 um 13:36 schrieb kallestenflo:
>> Probably not, but should it complain that the first book does not have a
> book?
>
> I'm having trouble to pin this one down. Should REQUIRE_PROPERTIES just be ignored when doing a scan? If yes this test would break.
>
> ```java
> @Test(expected = PathNotFoundException.class)
> public void require_single_property_fail() {
>
>      List json = new ArrayList() {{
>          add(singletonMap("a", "a0"));
>          add(singletonMap("b", "b2"));
>      }};
>
>      Configuration configuration = JSON_SMART_CONFIGURATION.addOptions(REQUIRE_PROPERTIES);
>
>      JsonPath.using(configuration).parse(json).read("$..a");
> }
> ```

I'd say that the test is invalid. IMO, the result should be "a0".

I'd say
[
   { "a" : { "b": "b0" } },
   { "a" : {} },
]
with $.a.b should fail, but $..b should return "b0".

As for a more complicated example:
[
   { "a" : { "b": { "c": { "d": "d0" } } } },
   { "a" : { "x": { "c": { "d": "d1" } } } },
]
$.a.b.c.d should fail
$.a..c.d should return ["d0", "d1"]

$..c.d should return ["d0", "d1"]
$.a.*.c.d should return ["d0", "d1"]
$..b..d should return ["d0"]

So yes, I'd say REQUIRE_PROPERTIES after a scan should be ignored.


There may also be some logic in placing it in local, I'm not sure which is most consistent with the intended design. The is no other direct use of ensure_local_checks in the main task file.


last time i checked a change like this did not fix any aliasing warnings.


Looks good.


heul nicht rum es ist wieder drin :P


old logic from https://github.com/OpenModelica/OMCompiler/commit/10dc7c39ab56ea40826788d8ec5b2200dfdb6bb5


Given that *class properties* are enabled in babel (`?optional[]=es7.classProperties`) you can avoid introducing `constructor`:

```javascript
class Clock extends React.Component {
  state = {
    dateNow: 0
  };
  ...
}
```


:dancer:


> This makes sense. I think I don't understand what you are doing with the variable next_expire_cleanup?
The `next_expire_cleanup` contains the date when the next cleanup of expired tokens will occur.
- when the application starts, the value is now();
- at the end of a clean up we, the value is set to now() + 1 day.

The cleaning method may be discussed later; If you want I can
remove this one from this PR.


Good.


Hmm, haven't thought of this. But one actually needs CDATA only if there is “>“ symbol.


Javadoc please?


Yes, please remove the variable `next_expire_cleanup`.


Alpine Linux gets it's hostname from /etc/conf.d/hostname and sets it via the init script /etc/init.d/hostname

Is it possible to hook the name of the server being created into /etc/conf.d/hostname ?


@ala-ableton: 809cfee


Hey @bmuenzenmeyer,

[EditorConfig](http://editorconfig.org/) is just a small yaml file that helps maintain a consistent coding stile. Name its ability to auto-format in supported editors (we use webstorm).

[Eslint](http://eslint.org/) is a pretty powerful JavaScript static analysis tool.

@geoffp or I would be happy to answer, if you have any other questions.


Hm. Shouldn't we be compiling with ```-DNOMINMAX``` everywhere anyways. Imho this should be fixed in the pro/pri file if there isn't some other strange reason for us needing those macros spawned directly from hell to taunt the living (srsly, what were they thinking...).


Javadoc please


Dunno. I can change that...


I am not sure that it is works. Let's look on this code http://codepad.org/9YNzqFco


- Added getResultImage() to each step so that you don't have to use WindowManager.getCurrentImage to pass the processed image from one thickness map step to another.
- Added runSilent option to each step so that the thickness map can be created without showing the intermediate results.


the same with last line


To make it more clear


Why ? I thought we were building from sources to actually fix that, not disable it.


Try to follow next class-members-ordering rule:

1 . Statics

```javascript
static A = 5;
```

2 . Class properties

```javascript
A = 5;
```

3 . Constructor
4 . Custom methods

```javascript
_getTime() { ... }
```

5 . React lifecycle methods:

```javascript
componentWillMount() { ... }
render() { ... }
```


- Changed Local_Thickness_Parallel so that it behaves similarly to other steps in the thickness map process.


try to use like 'buttons.show' or some similar namespace within `.yml` file


Read the error: cannot read property of undefined. Why is `user` undefined? Answer that and you'll solve the bug.


i though we don't need to include "import jason" as module_utils/basic.py does that?


^^ :no_entry_sign:


It seems that it would never happen, i think you did a typo here, use `https` instead of `https:`


^^ about namespaces


- Moved the classes to a named packaged because since Java 1.4 classes in the default package can not be accessed from the outside
- I'm proposing a naming convention for plugin packages here: net.imagej.<pluginName>


From the forum:

--

Hi,

I was running into problems with map generation on The Terrarium, where people would walk or change a specific ungenerated area and the server would crash, including if the user rejoined the game and would be at that same spot, rendering the server unusable.

With the help of Sokomine on IRC, we discovered the problem lay with Technic, and we were able to track down where it was coming from:

https://github.com/minetest-technic/technic/commit/798a885807a1e1d6f0e028dbf6dcdb5cc9517106

You replaced height_min and height_max with y_min and y_max. To avoid the crash, all four fields should be present, with the values you gave to each.

Thank you!

EDIT: Should probably mention that this happens when using the mg (Experimental Mapgen https://forum.minetest.net/viewtopic.php?f=11&t=7263) mod, and this is the error message:

ERROR[main]: Lua: Runtime error from mod 'mg' in callback environment_OnGenerated(): [path to global mods folder]/mg/init.lua:596: bad argument #2 to 'max' (number expected, got nil)

EDIT #2: I am using the latest minetest and minetest_game (v0.4.13).


Thanks. It is mistake


No need to extract such tiny HTML markup to separate method.
This way it will be more readable:

```javascript
render() {
  return (
    <span className="clock">
      {this.state.dateNow}
    </span>
  );
}
```


the version should be incremented :)


This commit is being reviewed as a part of review issue #137.


:no_entry_sign: ^^


if we don't want arguments how about this?
let sortedEntries = unsortedEntries.sort { $0.event.start < $1.event.start }


On 25 November 2015 at 11:50, Dohyun Kim <notifications@github.com> wrote:

> On plain tex, the catcode of @ character probably could be 12. We might
> have to remove it from \@undefined.
>
> —
>

agreed, do you want me to do a pull request or can you just change it here?

David


Hello how is everyone? I don't understand anything.


^^ namespaces


Same here: separate *exporting* from *class declaration* and use `ReactClass` decorator.


The original point was to move this part of code...


put it to translation


And to move it here...


= 0
が通らないのは問題だと思うんですが


^^ :no_entry_sign:


This is possible - but not doing it was confusing for people reading the code and seeing that we used json later in the file. I don't feel strongly about it.


I'm lost...


OK, done.


^^ namespace


Well spotted, thanks.


In a lost world...


* Added LocalThicknessWrapper class to add more programmatical control to how the steps in the thickness map process are executed
* Kept Local_Thickness_Driver so that plugin can still be executed just the way it was used to


This is mostly just being moved around, with some small changes.


Sanders Sanders!


Javadoc please


Great!!!!!


What was wrong with `__impureHostDeps` plus `resolve-system-dependencies.pl`?


^^ name


Sorry for the delay.

Sure, but I thought I'd highlight the difference since it looked suspect.
```
ace@ace5:~/src/buck$ grep DESC /etc/lsb-release
DISTRIB_DESCRIPTION="Ubuntu 15.04"
```
Pre
```
ace@ace5:~/src/buck$ git checkout before_jna_upgrade
Switched to branch 'before_jna_upgrade'
ace@ace5:~/src/buck$ git log --oneline -n 1
78af850 Send Python exceptions parsing BUCK files to Java
ace@ace5:~/src/buck$ ant clean >/dev/null && ant >/dev/null && ./bin/buck --help
Buck does not appear to have been built -- building Buck!
All done, continuing with build.
Shutting down nailgun server...
Using watchman.
buck build tool
usage:
  buck [options]
  buck command --help
  buck command [command-options]
available commands:
  audit       lists the inputs for the specified target
  build       builds the specified target
  cache       makes calls to the artifact cache
  clean       deletes any generated files
  fetch       downloads remote resources to your local machine
  install     builds and installs an application
  project     generates project configuration files for an IDE
  publish     builds and publishes a library to a central repository
  query       provides facilities to query information about the target nodes graph
  quickstart  generates a default project directory
  run         runs a target as a command
  server      query and control the http server
  targets     prints the list of buildable targets
  test        builds and runs the tests for the specified target
  uninstall   uninstalls an APK
options:
 --help         : Shows this screen and exits.
 --version (-V) : Show version number.
```
Post
```
ace@ace5:~/src/buck$ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
ace@ace5:~/src/buck$ git log --oneline -n 1
1a39f8e [Infer][Cxx] Change how json reports are merged
ace@ace5:~/src/buck$ ant clean >/dev/null && ant >/dev/null && ./bin/buck --help
Buck does not appear to have been built -- building Buck!
All done, continuing with build.
Using watchman.
Traceback (most recent call last):
  File "./bin/../programs/buck.py", line 53, in <module>
    propagate_failure(main(sys.argv))
  File "./bin/../programs/buck.py", line 46, in main
    return buck_repo.launch_buck(build_id)
  File "/home/ace/src/buck/programs/buck_tool.py", line 139, in launch_buck
    if use_buckd and self._is_buckd_running() and \
  File "/home/ace/src/buck/programs/buck_tool.py", line 323, in _is_buckd_running
    c.send_command('ng-stats')
  File "/home/ace/src/buck/third-party/nailgun/pynailgun/ng.py", line 137, in send_command
    self._process_next_chunk()
  File "/home/ace/src/buck/third-party/nailgun/pynailgun/ng.py", line 154, in _process_next_chunk
    process_nailgun_stream(self)
  File "/home/ace/src/buck/third-party/nailgun/pynailgun/ng.py", line 408, in process_nailgun_stream
    len(nailgun_connection.header_buf), nailgun_connection.header_buf, nailgun_connection)
  File "/home/ace/src/buck/third-party/nailgun/pynailgun/ng.py", line 322, in recv_to_buffer
    recv_to_buffer_with_copy(num_bytes, buf, nailgun_connection)
  File "/home/ace/src/buck/third-party/nailgun/pynailgun/ng.py", line 351, in recv_to_buffer_with_copy
    nailgun_connection.recv_flags)
socket.error: [Errno 104] Connection reset by peer
```


Yep, good idea or we'll never know from a plain log.


It doesn't work :(


Yes, I noticed afterwards that the index was not used.
There are 0 rows left after deletion (all 100'000 rows matched the filter).


Yes, thank you :)


`amPm` name is not as good as it could be.
I would suggest next:

```javascript
<Clock hourFormat="12" />
<Clock hourFormat="24" />
```

This way it will be more readable, I think.


b205d586ca482397cab29bbd02dbec99bf481847

Теперь все корректно. `update` выполняется два раза. При изменении номера треда первый раз очищает капчу

```js
		if(tNum !== this.tNum) {
			this.remove();
```

второй раз проходит дальше, и обновляет капчу в соответствии с номером.


Adding days to date with + operator doesn't work :(


You can try to find Admin. If record is exist then skip creation. You can use `find_or_create` method


Live and learn!  Wish I had known this a few weeks ago...  Looks good


ой. туплю)


oh yeah :smile:


Ah ok, because of `rows=0` I thought 0 rows were deleted. So, it should be no problem.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6797](https://teamcity.mesosphere.io/viewLog.html?buildId=80924&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:42


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6798](https://teamcity.mesosphere.io/viewLog.html?buildId=80925&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:52


I'd rephrase the first sentence simply as: "Don't wait for data-reading-done notification from readers, if the transaction is aborting."


Don't you mean `descendents` instead of `ancestor`, since it basically visits the children's-children-children-etc?


Pure formatting changes destroys history browsing. (git blame)

Only change from tabs to spaces when already touching that line.


Not in the defaults file. Based on the current structure it would have to be in the overrides file. 'Modify' was a rather lazy description, overriding would have been a better word. Obviously it being a list means that all the NICs would need to be defined for a host where the var is overridden.

I think we always risk creating too many variables in the attempt to give some additional level of fine-grained control.

I would rather use '/sys/class/net/eth0/speed' to get the speed automatically, although this doesn't seem to work for VMs, and allow it to be overridden if net_max_speed is set.

There is a documentation impact, but this is a new piece of monitoring so I think that was always going to be the case.


додай же фільтр подій. бо додадуться нові типи подій і буде не ок


Why you revert?


Sure, I'll change this.


scsdfsd


If -DNOMINMAX works, then we should use it in compiler.pri, and fix all users of the macros (if any) to use the STL versions.


dstmac_given is redundant since dstmac_opt not being NULL implies it, right?

same with the other _given variables.


Added the section Authorisation to the resources.
**To add the the required scopes to each call add the next line:**
```diff
get:
  description: Returns a list of products.
  ...
+ securedBy: [scope1, scope2]
  ...
put:
  description: Modifies the current stock level of a product.
  ...
+ securedBy: [scope1, scope2]
  ...
```

PD: don't add the SF scope


haha @legomushroom :D


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6800](https://teamcity.mesosphere.io/viewLog.html?buildId=80930&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:58


Don't you mean if @collaborator.save...


Thanks, @claiudius108! I researched it a bit more and posted my findings at http://markmail.org/message/tsy2afjwnsjr37l5.

> I noticed when upgrading from expath-crypto-exist-lib-0.2.6.xar to the current version (0.3.4), I had to update the 4th parameter for the crypto:hmac() function from $provider to $format.  As a result, my code, which provided "SunJCE" for this parameter, had to be changed to "base64". I figured this out by reading some of Claudius's wonderful unit tests:
>
> https://github.com/claudius108/expath-exist/commit/4a325bcaed9fa1e99945fa899193b580347858c7
>
> (See the diffs for the files on this page in
the crypto/src/test/java/org/expath/exist/crypto/xquery directory.)
>
> The actual change to the function signature happened on Feb 9, 2014:
>
> https://github.com/claudius108/expath-exist/commit/ab9167af774cca3dc4fc49e31dcf32ee83060c45
>
> If you've been working with versions more recent than Feb '14, you're probably already using the right value.  But since I'm not sure if the change was documented elsewhere, I thought I'd let everyone here know, just
in case.


where does .child come from?


And your notice should probably be along the lines of "Collaborator was added"


@pynicolas is it enough to test only first lines of secondary locations? What about columns?


Maybe Error adding collaborator.


This all needs to be changed to collaborator. That's what you're working with here.


Actually `float: right;` is not really style of *Clock component*. It is location of clock inside *TaskPanel*, not every *Clock* in general.
In future *Clock component* could be used in other placed, by other Components. And these Components doesn't expect that *Clock* will be floated to the right.

So `Clock.less` should contain styles, which are related solely to its own internal appearance (for instance `color: blue; font-size: 24px;`, etc), and it *shouldn't* contain positioning inside Component, which use it (`top: 0; float: left`, etc).
Good solution will be next:

```javascript
// Pass additional className to Clock component from Parent Component
class TaskPanel extends React.Component {
  render() {
    ...
    <Clock className="task-panel-clock" />
    ...
  }
}

class Clock extends React.Component {
  render() {
    const { className } = this.props;
    // classnames() function is used in React application to easily combine multiple class names under
    // different conditions.
    const classNames = classnames('clock', className);

    return (
      <span className={classNames}>
      ...
  }
}
```


Not even for libraries ??


lol, all name + email addresses have the same length XD


these were unnecessary extra steps


Shouldn't we remove the `config/elemoine` file?


You may provide a protected `getPomm` getter to allow class inheritance in case of.


Olá. Posso fazer uma sugestão sobre o .gitignore?

Há um grupo de pessoas que mantém um .gitignore feito especialmente para o Unity:
<https://github.com/github/gitignore/blob/master/Unity.gitignore>

Ele é especialmente útil por evitar que a pasta 'Library' seja versionada. Pois essa pasta e algumas outras são geradas automaticamente pelo Unity, caso ele detecte que elas não existam ainda. Então, para que seu repositório fique menor, é aconselhável que você as deixe de fora.


you can look on few examples here https://www.relishapp.com/rspec/rspec-rails/v/3-4/docs/controller-specs/controller-spec#simple-passing-example.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6794](https://teamcity.mesosphere.io/viewLog.html?buildId=80906&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:20


TXE is 1 when the register has been transferred, so this logic is inverted


See above


you can use this construction `expect{Counter.increment}.to change{Counter.count}.by(2)`


Just a little note, c99 supports declarations of variables wherever you want, c89 doesn't.
<pre>
$ cat la.c
int main(){
   int a;
   a = 0;
   int b = a * 2;
   return b;
}
$ gcc -std=c99 -pedantic la.c # it compiles
$ gcc -std=c89 -pedantic la.c # it doesn't compile
la.c: In function ‘main’:
la.c:4:4: warning: ISO C90 forbids mixed declarations and code [-Wpedantic]
    int b = a * 2;
    ^
</pre>

Note about the note: C90 == C89 standard.


test


maybe put the crit dmg calculations in a new method to remove redundancy


This is good, but at other places this instance's extruder count is set (also to machine_extruder_count) the config_per_extruder is not modified. Maybe we should not change config_per_extruder in setConfigs and computePrimeTowerMax (if initConfigs is always called before those functions), or maybe we should call initConfigs instead of setting extruder_count in those places (if initConfigs is not always called before those functions)?


This method should be called `_updateDate`, given that it doesn't *gets* anything, but *updates* existing. And not only *time*, but *date* in whole.


This does look like a cleaner setup, and may make it possible to have a One True Place™ to call libnet_init() instead of calling it multiple times.

But the description of this commit seems wrong. You don't have to specify -i at all. Libnet is perfectly happy with an ifname of NULL.


but change TileEventPacket to BlockEventPacket in ChestInventory and DoubleChestInventory


thanks for the fixes.

i changed it to that also hours and minutes are set to now and finish time to one hour after start time. and also added some javascript to move finish date with the start date on change.
this probably makes sense from a usability point of view i think...


One thing that can be done immediately to bring this up a notch are links and screenshots. Another thing that you could do is find a repository of interest to DH types (say for instance the Programming Historian) and run an analysis on that and take the reader through how to understand what the visualizer is saying about the evolution of that particular site.


Equals to:

```javascripot
setInterval(() => this._getTime(), 1000);
```


FewDocFixes (Myoldmopar) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-75.44%25-red.svg)


What problem does this change address?


What are all these files with No Changes?


Equals to:

```javascript
dateNow: date.toLocaleTimeString(this.props.amPm ? 'en-US' : 'en-GB')
```


RXNE == RX fifo not empty == RX fifo contains chars => should return true when set (logic is inverted!)


its not clear to me what this timeout is doing, can you explain?


See above


I'd prefer simple truthiness checks.
(Because I don't want to (need to) memorize all the type-casting rules for `==`/`!=`. I promote using exact comparison `===`/`!==` where required.)


This returns the converter name (ie `Timestamp`, `NumberRange`, `JSON`, `String` etc.). That’s fine with me as long as a strict PHP type is not requested.


update for main.lua


like this? https://github.com/Zyko0/documentation/commit/9064ad211ae016eebcb4145e096c7d0be68cfbb5
for **twitter** : twitter  -> fb -> default
for **fb** : fb  -> twitter -> default


Should be 'a number' instead of 'an number'. Kristin pointed this out.


Sorry, I just woke up and was a little groggy. `user` isn't undefined, but its `attributes` property is. This seems to mean that your User is being flagged as a Backbone Model, but isn't being initialized properly. It doesn't crash on the JSON version because things that aren't models follow a different code path to get their ID.


There is another update


Great, thanks for letting others know about this!


맨날 영어로만 설정해둬서 확인 못했습니다-


{this}


Vérifier que l'orphanumber n'a pas encore été attribué (pour éviter de l'écraser par un mauvais OrphaNum


bool start


`theano.sandbox.cuda.GpuAllocEmpty` could be faster.


Hi Marissa,
One thing that can be done out of the gate to bring this up a notch is to add some images. What does the 'terminal' look like? What does 'command prompt' look like, where can one find it? How does the user open a terminal/command prompt at a particular folder when using finder/explorer? What does it mean to install LaTex or its siblings? What's involved with all of that? What do these things do?

Could you provide a simple .txt or .md file, and walk the reader through converting it to different types, showing the output? Something that throws new comers to working on the command line / terminal is that if things *go right* there is nothing to indicate that anything has happened...


Contrôle


TEST a comment


`s/plugins run/plugin is run/` ?


Does the 'original image not being deleted after build' really depend on `dont_load=False` ?
Isn't `remove_former_image=False` sufficient ?


indentation


Instead of going the route of the `InverseLayer`, can't you call `theano.sandbox.cuda.dnn.dnn_gradinput` directly?


Vérifier que l'orphanumber n'a pas encore été attribué (pour éviter de l'écraser par un mauvais OrphaNum)


Try switching your user model to use `initialize` instead of `constructor` as well. I suspect I gave you bad advice, and as a result it hasn't been setting up the correct prototype chain. I think I got Backbone confused with the ES6 class syntax, and it's been messing with me ever since.


FYI, before you get too far, if you eventually want to make a pull request, please read what's not on the roadmap in the readme. So far, you'd have to remove the font and jquery.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6801](https://teamcity.mesosphere.io/viewLog.html?buildId=80937&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:56


Hi Sharon,

One thing that can be done out of the block is to add screenshots of all these different things you describe ('command palette? What the hang is that?' etc). You could also provide a practice .txt file for your reader to try some of your suggested manipulations.


Please rename it to a better, self explaining name. Then I will merge it.


ah, no, I left that blank on the form, but it appeared to use my account by default :(


Where do you need this reflection? That's surprising to me.


move these 2 lines up where interval_time is calculated?


Hey, I think @jpr will fix this issue with his unsigned_array branch. Imho with size_t datatype this kind of errors should be gone.


hmm, in testing on my local copy it shared http://10.10.10.10:3000/... weird


Yes, but is a good way to have similar _given variable for all opts.


no, it should do show up. Please write an issue.


Sortie pour vérifier tous les orphanumber de maladies trouvés lors du parsing de OBO_EBI.xml


**[phpUnit_trunkUnit run failed](http://qa-s2.wikia-prod:8080/job/phpUnit_trunkUnit/8961/testReport/) for this commit**


This is not necessary for the first reader.  From the example "Win32&64 C\DWDataReaderExample.c" line 66:
DWInit() already creates a data reader and adds it to the list. To add additional data readers DWAddReader() must be called.


Hi Shawn, to bring it up a notch...


jag gjorde en speciell option för just pool.ntp.org grejen - se class-deklarationen i manifests/ntp.pp


Hi @ArtHacker123 , I accidentally see this commit and find what a mistake I have made :joy:. You can open an issue to report these bugs or just edit the code and make a pull request.

Thanks every much to point these bugs out!!!


Nit: "Description: Adds links for related issue numbers to code reviews."?


I tested with sony blobs and get "unknown" tech type response.
Building from sources gets the wrong rf protocol type response for the classic type then rf will be disabled. Seems Mifare Classic was not supported from Nfcc, I have to dig through it to see why.
Currently I disable Mifare Classic (and Mifare plus) reader type is a workaround ( it does not have effect on others type such as Mifare Ultralight, Ultralight C, ...). It helps us remove the regression bug.
Thanks


does it appear in the swagger.json? Is it does, it's a swagger-ui bug.


@stevengj I have a question about this. Was it necessary because having `Conda` in the `REQUIRE` file would force everyone to download the full Conda installation even if it was not used ?

If so, what do you think of removing the lazy install here, and asking package developers to run
```julia
if !Pkg.installed("Conda")
    Pkg.add("Conda")
end
using Conda
```

In their `build.jl` file, if Conda is needed ?

I am asking because #19 might require more conditional logic (is the right environment created, loaded, ...), and I would prefer to handle all this in `deps/build.jl` and the `__init__` function.


This is a good check.  Do you still get this error?


You probably meant to remove this again, didn't you?


*Bump


> You don't have to specify -i at all. Libnet is perfectly happy with an ifname of NULL.

No in all cases.
If ifname is NULL then first iface will be used, but in my case first iface in /proc/net/dev is IPoIB device and I got error:
```arping: unknown physical layer type 0x20```


@nfeske Yes, I think that would be better than peppering the source with these capacity constants.


If you import Timepiece, it will work :)


@Martii

FYI


Which Kernel are you running, It might be newer than I have ever used. The one that ships on edison requires using debugfs for a lot of operations.
Ive never seen /sys/class/gpio/gpioN/pinmux on the edison at least.


Why did you changed it?


created pull request for evan-marshall.md


nit: the comma isn't needed, and printing the var doesn't seem useful either since here (and in _end()) it is always true (or false).


Yes, I probably thought about ``descendant`` and wrote ``ancestor`` instead. I don't remember.


:smile:


Can you pin this to a specific version?


Same here, you can use  'NSDate().beginningOfDay + 1.day'


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23650/testReport/) for this commit**


Causes a gulp error


@arantius

![comment](https://cloud.githubusercontent.com/assets/2373486/11399527/47b76d54-9388-11e5-8104-c9678bf40f37.png)


extruder_count should be set at a single place, i.e. the first function which is called.

The prime tower file is currently in a debuggy crappy state. This should all be fixed when we consider a new type of prime tower.


If the list is sorted (there are functions for that) you can optimize the search by starting at the begining or end. But you'll probably benefit in speed if the list is really huge by using Sdb


Hi Alex,

One thing that can be done out of the gate to bring this up a notch is to explain a bit more about Jekyll & how this particular thing you're describing here is actually a hack: you're not installing Jekyll on your machine & using it to generate a static site, but rather, using an already generated Jekyll site that has been ported to github & updating it by adding your own .md files. It's an important distinction - see the actuall [Jekyll site](http://jekyllrb.com/) and look at its 'getting started' info to see the difference! What you have here is a *way* easier way of using the Jekyll structure without the nuisance of all the other stuff.

Some more things that would make life easier are a series of annotated screenshots for each step.


Hey Barron,

I update my python, it works fine, however, it runs into another error,

UTILIO_DEFN.F:61.41:

         USE M3UTILIO, INTERPB => INTERP3
                                         1
Fatal Error: Can't open module file 'm3utilio.mod' for reading at (1): No such file or directory
make[1]: *** [UTILIO_DEFN.o] Error 1
make[1]: Leaving directory `/home/jiaoyanh/GEOS/testrun/test'
make: *** [build] Error 2

[jiaoyanh@borah testrun]$ which m3xtract
~/jiahuang/IOAPI/Linux2_x86_64ifort/m3xtract

I do make sure I have M3UTILIO .mod in ~/jiahuang/IOAPI/Linux2_x86_64ifort

I am using ioapi v3.1, do you have any idea what is causing the problem? What I can think about is ioapi version.

Thank you


少しだけ気になった点として、以下メモします。
* コメントアウトされているコードはデッドコードではないですか？？（と、書いているときにslackコメもらいました！ブラシュアップしている前状態とのこと、OKでっす！）
* 今後もし続けてゆけられるなら、ローカルのURLとクラウドのURLの切り替えは開発環境などの環境ごとで自動で行えるようにできたらなぁと、思いました。（前にコードを見ていた時にちらりと思ったことを勢い記載させていただきました）


please make pull request to Dynalon/JsonConfig so that all your nice changes get back to the mainline


Hi - see my comments here https://github.com/digh5000/student-tutorials/commit/8b0dd1dc61ddc4c6e4208fffa93eb1f46fa666d5#commitcomment-14617255


The component 'tab navigation' needed a clearfix, so I fixed like that to prevent for other floated component to collapse parent element and because parent element::after was already used.


byref should not be required here.  Arrays would be passed by pointer anyway as described in [ctypes type conversions](https://docs.python.org/3/library/ctypes.html#type-conversions).
I do wonder if an array is still created if nchannels=1.


Nah it's pretty nice to have this debug output every once in a while...


Your idea is good as well. But maybe we should stick to one convension. I've found another "sort" in roomguru's code and it is written like that:

    class func sortedByDate(items: [CalendarEntry]) -> [CalendarEntry] {
        return items.sort { $0.event.start.compare($1.event.start) == .OrderedAscending }
    }


@dstoup  Looks good to commit.


drop that else, it's implicit because previous condition will return


i like chincken nuggets


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6802](https://teamcity.mesosphere.io/viewLog.html?buildId=80948&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:05:03


Only create markers for active joints, i.e. type != None


@pynicolas Do we need the same logic for cost here? `cost == null ? -1 : cost`


This would consider all joints, even fixed ones.


REST通信のURL、ローカルとHerokuを切り替えるのは、今は手動で面倒くさいと思ってるので、自動化したいと思ってました。このへんの簡易スクリプトを作ってくださる方も募集です。


Here you need to apply your code from run_cbf (in master branch)
to compute the joint position from the difference of pose and original pose.


joint_id is passed in from above


pass the joint_id (j) to the callback


Don't know where this came from, but we're calling `std::isinf` on an `int32_t` here. It gets implicitly cast to a double and then always returns false since no value of `int32_t` translates to infinite.

It should check if the value is changed since its initialisation. I suggest making sure it is initialised properly to `std::numeric_limits<int32_t>::min()` or `std::numeric_limits<int32_t>::max()` and check for that instead.


Was the problem the length of the description or the positioning? Sorry for breaking things here.


Chicken nuggets*