Yes, it is possible to construct something in the filter `IsGroup and IsTransformationSemigroup` which does not have group or semigroup generators set, an example is that of an ideal of semigroup which happens to be a group. The reason these methods are here is so that they are used in preference to the default view method for a group. I will double check if all of these are really necessary, and remove them if not.


I'm sorry but did you just revert the changes you made for JENKINS-30023 in 49b206a35ebfe185d73801fd76a67251170f5e79 ?


TeamCity LabkeyRelease15.3 :: CDS postgres 9.4 [Build 15](https://teamcity.labkey.org/viewLog.html?buildId=285899&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 20 (1 new), passed: 7 Build time: 00:47:54
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

##### there are 10 more failed tests, see build details
```


@matklad this guy could be removed or replaced with next call ```ModuleTypeManager.getInstance().findByID(GoConstants.MODULE_TYPE_ID)```

see my [comment](#commitcomment-14466764) above


Maybe, I'll check and report what I find.


Hi @derekcollison , I am new to tls. May i know how to generate the server-cert.pem,server-key.pem,ca.pem files(which works across different machines). I hope the present tls implementation half way verification is done but not the two way( i mean client verifies the sever certificates & server verifies the client certificates).

Any points / help is useful to me...

Thanks & Regards,
SriniCH


`Reviewed-by: Joakim Bech <joakim.bech@linaro.org>`


Ok i will do dat

On Wednesday, November 18, 2015, Don Potencio <notifications@github.com>
wrote:

> U may want to revert, refactor and then commit and push again because I
> will commit or merge this to the master soon, so u may want to make the
> code clean.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jerryhanks/Xavitech/commit/8fe8e2dc4e01c4e205ae3a19e14bcce4bf4ec7f1#commitcomment-14465642>
> .
>


I think we can not accept this.... as this is not a good suggestion....


恩，我是在page里加上original: false解决的。。


You can use ``len(open(self.tempfile.name).readlines())`` for a slightly cleaner version of this.  There aren't enough lines to worry about pulling everything into memory.


Looks like I did some mistakes and didn't notice. I will clean up the log tomorrow.


You edited `create_with_source_file()`, yet here you test `create_with_source()`.


Yeah I coded it so that there was a new line character before and after the output for some reason. I'll recommit with those changes later


OpenCL kernel fails because it reads/writes out of memory boundary. Make sure indices to memory block are valid before reading/writing.


some tests failed:
failure: http://buildbot.bos1/builders/test-riak_kv/builds/2752


This all looks really good, but if we change our scoring system at all, this comment serves to remind us to update this.


Next time use, git pull --rebase origin working.


if the scoring system changes in the future, come back to this


I agree, since we have not shipped any clients that use v4 it is ok to add things to it.


Jo a taky jsem predelal currColor a bcgColor z pointeru


Remove either "interpret the" or "determine the".


Thanks for pointing out the extra line on line 9197. At the very end, we do have 1 newline character.


FYI, this is OK for now, however we may have one final change which does not default `clientId` to `*`, see https://github.com/ably/docs/pull/59 on why.  It should be a VERY small change.


@sumitkmr558 the coordinates are in the ```first_template.xml``` file. They are centers for the Blobs (circles to darken).
To create your own, map the circles. Try to measure the circle diameter, as the blob detection is dependent on the circle's area.


```OPENSSL_LDFLAGS``` should go on ```test_sslheaders_LDFLAGS```


Clever to modify a different byte on each iteration!


```OPENSSL_LIBS``` is already in this list. Is there a link ordering problem?


Also why are these `Integer`s and not `Int`s?


Nice catch. The -n vs. -z is pretty much to blame here. We should find an explicit solution for including netmap params and upstream it instead...


typo s/Even/Event


Tem pessoas que tentam comer um Kepa Grande às vezes. Não os deixe fazer isso.


Undo this removal of header text.


Is this actually harsher than /tg/station ?


Blocked


I'm not totally sure what you're talking about, and this is not the correct place. If you have a bug to report, please open a new issue here on the GitHub. If you have something to discuss or need help, you can post to our topic on Solarus Forums at http://forum.solarus-games.org/index.php/topic,71.45.html. Thanks!


Revert removal of header text.


Finally, a time machine for the humanity! ^_^ (re: commit timestamp)


TeamCity LabkeyModules15.3 :: Git postgres 9.4 [Build 25](https://teamcity.labkey.org/viewLog.html?buildId=286069&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 11 (2 new), passed: 235, muted: 5 Build time: 01:03:10
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyAntigenVariableSelector: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSHelpCenterTest: <no details avaliable>

org.labkey.test.tests.DataFinderTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.ScrumtimeTest: <no details avaliable>

##### there are 1 more failed tests, see build details
```


This should go on ```test_sslheaders_LDFLAGS```.


Can we make it a static getter. So it can be easily used across packages.


Just a little notice: Fist column in .xyz file was reserved for a type not a pid.


bump @ludennis can you confirm or push any remaining local commits?


need to adjust this.


TeamCity LabkeyModules15.3 :: Git sqlserver 2014 [Build 26](https://teamcity.labkey.org/viewLog.html?buildId=286076&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:24


igor


it should be pretty straightforward to list registries in docker info. I'm assuming we are talking about projectatomic/docker, if it's the case, again, it will be pretty easy to do


@kwonye In this case, you would want to instantiate and set the `UIAlertController` as you did previously with `UIAlertController *addSiteAlertController =`, and call `self.addSiteAlertController = addSiteAlertController;` at the end of your implementation. Since we're now using `weak` you would, technically, conflict with the fact that we do actually need the object to stick around (even though it works fine now), which is what you were concerned with before with losing the object.


In case I kill idle thread in the future, or change thread_id of it, I think it's safer.
Did I just think too much?


Here you're checking if the string `"compare_favs"` is `True`, rather than calling the function `compare_favs` and checking the result.  @paceko, I don't remember who your partner was, but can one of you update this?


TeamCity LabkeyRelease15.3 :: CDS postgres 9.4 [Build 21](https://teamcity.labkey.org/viewLog.html?buildId=286057&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 20 (1 new), passed: 7 Build time: 00:47:51
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

##### there are 10 more failed tests, see build details
```


It will be great, to make auto-generated help,

I have no experience with `jsDocs` or similar
and it will be really interesting for me to look how it works.


@kwonye it's also considered a best practice to go ahead and continue to use the local variable and not continually call `self.varName` when the local variable is already handy.


Sorry for being unclear earlier, we should pass config into here.


Thanks @dericed


type should say typo :p cruel irony


Where is this used?
Shouldn´t it be set to the view here?
https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/MVC/Symfony/View/Provider/Configured.php#L53


LGTM!


The slice should give you a list, not two (or more) values.  You should have square brackets around these to indicate that the result is a list.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5812](https://teamcity.mesosphere.io/viewLog.html?buildId=77775&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:06:03


I'm over optimizing here, but if you could probably do this with a `std::array` and avoid going to the heap.


range?


:grin:


> @kwonye In this case, you would want to instantiate and set the UIAlertController as you did previously with UIAlertController *addSiteAlertController =, and call self.addSiteAlertController = addSiteAlertController; at the end of your implementation. Since we're now using weak you would, technically, conflict with the fact that we do actually need the object to stick around (even though it works fine now), which is what you were concerned with before with losing the object.

I am going to kill this property in spite soon...

> @kwonye it's also considered a best practice to go ahead and continue to use the local variable and not continually call self.varName when the local variable is already handy.

Good to know! Done.


I think this change no longer captures the key point, which is that a thread's runloop needs to be *running* for auto-refresh to have any effect. The runloop merely existing isn't sufficient.


Call this HEX_DIGIT


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5814](https://teamcity.mesosphere.io/viewLog.html?buildId=77777&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:04


strange to use this class in this project but not in the other one. I guess that this is not your code.


I agree. We only need to update the universal rev after adding or deleting a photo.


I replied on your commit, but we can continue here.
1. ic_action is wrong icon to use on map, there we should use map_  icon
2. the functionality has changed and now it is not adding intermediate points at all, it is always adding point as destination but keeps other as intermediate points.

Because later this will be the only place how to add destination there is no compatibility needed. Right now only 2 rare places left (Search coordinate and search address only if you don't follow the sequence strategy).


Should be using ijson.


It would be great to leave a comment how the value was chosen.  Without a comment it looks like a mysterious, but important, magic value.


From experience, I tend to find simple explicit procedural code way easier to maintain and debug than a workflow hidden in a class (with inheritance added!).


+1 for this patch


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5815](https://teamcity.mesosphere.io/viewLog.html?buildId=77778&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:58


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5813](https://teamcity.mesosphere.io/viewLog.html?buildId=77776&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:10
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Two importers based on the same class for a simple straightforward process **really** smell otherengineering and should be avoided. Simplicity and maintainability is the win on a long term project.


merged as c7c95fd4e00f0c4d2410c2e9c8fece424f587f89


I just realized that maybe this spelling was intentional -- meaning "a thousand one-week projects.."?


Using databased information here seems kinda weird. It looks like some kind of "merge algorithm" attempt from this limited point of view, I don't know the justification but it looks like otherengineering again.

Boolean approach only in the process like the previous PR seems better.


It's weird than "get_or_create" is a manager method, that doesn't feel right. It either should be a utility or a django.db.model method.


again, a boolean approach seems better and more explicit.


@Khelek я сам, когда этот пересматривал, понял,что where внутри where уже говорит о том, что с запросом что-то не так.


    Confirmed, i made the following change, which is totally a hack , and real developer will have to fix it the right way, but given the change below if i just set the remote data set to what it really should be it works flawlessly.
    line 275 in autorepl.py

    # remotefs_final = "%s%s%s" % (remotefs, localfs.partition('/')[1],localfs.partition('/')[2])
    # real men test in production.... lets do this
    remotefs_final = "%s" % (remotefs)


Thanks!


'member_licenses' requires mim version 2.0  as well.


入力画面でs:hiddenを使うとプロパティ値末尾にカンマが入る
↑まだ理由不明


This *completely* breaks trying to enter pretty much anything on the O IDE from Android. Whenever I type a character, it doesn't appear until I enter another one.


What would you think of (acl_buf.read_long || 0)? I'm seeing a connection where acl_buf.read == "", but it appears to work if I skip this.


It's called "file" and it's actually ... downloading stuff from the web. Bad.


Doesn't this override the other?


Side effect hidden deep down in a class in an hidden workflow. Bad.


Grande Kepa seria mais adequado ou "Kepa Grande"


This is not standard class name. You could just name it

class WAPI(object):


@Khelek там внизу есть enumerize, которые явно показывают, что есть что.

но лишний комментарий добавлю.


Use urllib2 for urlopen, or even better requests.


Will you have both a user name / password and a certificate / password?

In cases like this maybe it makes sense that EncryptedPassword is used for both.


"Não permita" se encaixaria melhor


The class is not a class but a package, you forgot to write the class name at the end.


Added empty method for JComboBox.


nit: Add new line


ya


Why all of this? You only need to download one file. Keep it simple stupide.


Originalmente "eram" caules de plantas, "desde então" o Chinency evoluiu para sua forma atual. (mais coeso)


I suspect the `#include <iostream>` is unnecessary.


@tejasmanohar is there an issue with this change?


"Grande Banshee"


is_version_supported seems a better name.


Also, in line 424, it should be "changePizzaSizes" instead of "changePizzaSlices" :)


I'm not sure I'm following you.  You have stripped out logic that is used for many other drivers such as webkit or poltergeist, so your PR is not complete from what I can see.


Using etag is cool but I wonder if using it is not overkill and simplfy providing a CLI options wouldn't be better.


FEATURE_VERSIONS should belong here IMO.


Had problems with this. Gave me fc. Anything missing beside this change and build folder? Thanks


The process doesn't inform that the file is not downloaded because not modified according to etag.


Since I'm not an expert on that and this change was born today from a conversation with some developers (and a type column can be easily added, but just hard coded 0 seems just wrong and done for a specific case, unless every simulation uses only one type...), then someone can explain to me why in tools/DumpConfigurations.py  writexyz() (which for example is the one used in the polymer melt example in the repo) and fastwritexyz() have the pid as first column while fastwritexyz_standard() has just 0 in the first column (type)?


ninguém jamais viu "sua" face... (se referindo ao monstro)


remove this extra space


These checks should probably be added to the else in MSG_ReadDeltaUsercmdKey as well I would think?  Or clamp them in SV_UserMove instead?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5816](https://teamcity.mesosphere.io/viewLog.html?buildId=77786&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:18
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


This kind of option is bad from a design point of view, it changes the behavior of the whole class from unpredictable locations this really looks like "I should have used the strategy pattern but I didn't knew about it".


monstros "afetados" (erro de digitação)


I pushed a patch removing some test code from earlier, that should solve it.


you might want to check this at the class initialization, not after having done the download.


..."De" que eles se originaram


ijson is used there but not at the other places, love it :p


Aufgaben 1, 2ac, 3a, 4ab sind lösbar. Der Rest enthält zumindest keine offensichtlichen Fehler. Werde am Montag abgeben.


Should it only have fields that the GC actually uses (ie omit ullAvailVirtual and ullAvailExtendedVirtual)?


It does.  One more question...it seems like the second "Course" in "Find Course > People in Course XYZ Something something" is redundant, and just takes up space.  Any objections to just making it "Find Course > People in XYZ Something something"?


:+1: awesome!


i shouldn't be seeing this.


nit - new line


read over this again so that i u hide these variables correctly


if remote_id can be None or an empty string here, it should be tested explicitly.


why you need remove this


Are you talking specifically about the order of arguments or the fact that it returns `missing`? If it's the former, that's an unfortunate thing, but it's pretty ingrained into Marshmallow and possibly some things that depend on it as well. If it's the latter, it's because `None` is actual value that might come back that might be interesting to the receiver -- which is also unfortunate but happens.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5818](https://teamcity.mesosphere.io/viewLog.html?buildId=77807&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:51


Could this be `auto const`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5817](https://teamcity.mesosphere.io/viewLog.html?buildId=77806&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:58


Pair programmed with Kevin for 1.5 hours and caught him up on SDR_Algorithm_1.java.

Kevin will be paid $30 for $20/hour

Kevin noticed how if Fixed SDR becomes a very important principle we can optimize the old implementation by implementing a live quicksort during the first iteration of the Region while calculating overlapScore. We decided to not do this since this would distract us but will do this if in the future the general learning algorithm needs to be optimized :)


The verb "save" shouldn't be used there as ".save()" has a special meaning in Django, this would induce confusion.


Danke für den Punkt :-) und danke für den Lösbarkeitsbericht!


+++ dataSet schema +++

uid _________ ordered ___________itemCnt
703783 ___ 257769704000 _________ 1


I talked to Maoni when I did this -- she felt strongly that this should be a 'union' of whatever may be available on all platforms.  She explicitly wanted everything that Windows would give her, even if GC isn't using it right now..


TeamCity LabkeyModules15.3 :: Git postgres 9.4 [Build 23](https://teamcity.labkey.org/viewLog.html?buildId=286003&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Execution timeout (new); tests failed: 181 (160 new), passed: 16, muted: 2 Build time: 04:01:14
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.DataFinderTest: <no details avaliable>

org.labkey.test.tests.DataFinderTest: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testDisabledLoadAndSave: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.util.JUnitHeader: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.bigiron.mssql.GroupConcatInstallationManager$TestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.targetedms.TargetedMSController$TestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.targetedms.chart.ComparisonCategory$TestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.targetedms.chart.ReplicateLabelMinimizer$TestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.api.exp.OntologyManager$TestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.api.exp.xar.LsidUtils$TestCase: <no details avaliable>

##### there are 171 more failed tests, see build details
```


Their crates don't explode when shot, no.


Correct ^^


This self.representative_pre_save seems to be coming out of nowhere, I really don't like that.


TeamCity LabkeyModules15.3 :: Git postgres 9.4 [Build 26](https://teamcity.labkey.org/viewLog.html?buildId=286074&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 12 (10 new), passed: 233, muted: 4 Build time: 01:02:43
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSHelpCenterTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyAntigenVariableSelector: <no details avaliable>

org.labkey.test.tests.DataFinderTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifySubjectCounts: <no details avaliable>

org.labkey.test.tests.ScrumtimeTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

##### there are 2 more failed tests, see build details
```


Same


Right, I'm not even using the download code anymore so I'll just remove all this.


Alterado, commit em breve, obrigado!


It's not possible to make a generic flag for all the GREAT3 cuts, since some of them were resolution cuts that depended on the simulated seeing.  The ```exclude_fail``` and ```exclude_bad``` flags take care of basic failures with the fits only (like: Sersic fitting code failed due to lack of convergence so there is literally no parametric model for this galaxy).


Is this code actually working?


this code sucks


false indent


+++ dataSet schema +++

uid _________ orderid ___________itemCnt
703783 ___ 257769704000 _________ 1


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5819](https://teamcity.mesosphere.io/viewLog.html?buildId=77815&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:47


I think that this should be moved out of this method, either as a global constant at the top of the file or as a class attribute if the class approach is maintained.


Yeah so there's that too ... funny indentation i recon.


We can't, we need to apply the strips done below before it's valid json.


TeamCity LabkeyRelease15.3 :: CDS postgres 9.4 [Build 22](https://teamcity.labkey.org/viewLog.html?buildId=286082&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 14 (3 new), passed: 13 Build time: 00:48:12
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenVariableSelector: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

##### there are 4 more failed tests, see build details
```


I would be nice to get rid of ullAvailExtendedVirtual at least because of it never meant anything in shipping OS and it is documented to be always 0 since 2001.


you can use std::string instead of char* and remove (*free)


whoa, a stale comment about stale cache values


could be simplify with a dict.get I think


This commit breaks ansible. Line 191 references vars_copy which no longer exists


Ok, understood, thanks!


It's not mine, I download files with wget and pipe from unzx to this command directly, I'm going to remove all this downloading code that'll be awesome ^^


5321-GroundDomain_RDD (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1963 of 1968 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.75%25-yellow.svg)


ping @jimi-c please see above comment


Bad bad variable name.


TeamCity LabkeyRelease15.3 :: CDS postgres 9.4 [Build 23](https://teamcity.labkey.org/viewLog.html?buildId=286084&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 13 (1 new), passed: 16 Build time: 00:48:41
### Failed tests
```
org.labkey.test.tests.CDSLoginTest.testSessionTimeoutIntercept: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenVariableSelector: <no details avaliable>

org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifySubjectCounts: <no details avaliable>

##### there are 3 more failed tests, see build details
```


1. better change this to params.
2. and const SharedPtr<VADisplay>& display


same


yeah I don't have a strong opinion on what it should be named


Same than for the name, should be extracted from this method.


TeamCity LabkeyModules15.3 :: Git sqlserver 2014 [Build 27](https://teamcity.labkey.org/viewLog.html?buildId=286094&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:22


Thanks @justanr, I was talking about the arguments. Yeah, it is unfortunate...


Thank you, that just solved my runtime problem.  :-)


You might write this as `pub trait LayoutNodeTrait<'ln, Wrappers> : Sized + Copy + Clone where Wrappers: WrapperTypes<'ln> {`. I find `where` clauses make declarations look less scary :)

Also, in a couple of places we prefix traits with `T` where necessary to avoid ambiguity with an identically-named type. Perhaps follow that convention here (so `TLayoutNode`)?


no need indent for #ifdef


I assume this function is unchanged.


inverse if to avoid identation -> "if not mep_json.get...: return/something else"


misc_standard_report_measure_issues (macumber) - i386-Windows-7-VisualStudio-12: OK (2333 of 2370 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.44%25-yellow.svg)


107310700-change-license-text (jasondegraw) - x86_64-MacOS-10.9-clang: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.25%25-red.svg)


ditto: I suggest a `where` clause here (and in the above methods/impls too)


ww


false indent


actually, rest of the code doesn't seems great for that pattern, maybe it's not a good idea


I get it.  Thanks for the explanation.


Likewise, a `where` clause would let this be split up into two lines, and `TLayoutElement` would be less verbose too.


As above.


5321-GroundDomain_RDD (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Best to call grep -v once with

/usr/bin/grep -v '\"CLOG\"\|\"\033\"'


So may I change this part for BMC version control directly?  Or should I find line.rstrip?


ditto


Not used argument.


"if" is not needed.


Oh, I didn't see this commit, where you undid all the naming. Never mind on the naming comments on the first commit then :)


hello


@chetan51 I'm tracking down differences in getReal64 on Windows and Linux. Maybe another place to visit, if not already tried? I mailed Scott about some findings earlier.


RPi and RPi2 master builds succeeded with these commits reverted:

785752e5df9c5cf284e915d5916ebe30c290d515
a5364c6004cad040e9129dba0798f11fc44ece25
ce6a19e2369ef0344bbff6a033905f226ea56cf6
eee238d7087ec5d7fc15f0c04fadfc7626559040


Why don't you have an extension for this file. I mean Python files are .py.


@Emdek
> but also an issue for some workflows
What are the details of that?


Ben, could you add a CUDA test? I might do some more development so wanna make sure the previous work is stable. All you need is to build it with "-DIMP_CUDA=kernel", on a machine with cuda installed (e.g., piri)


Ah, previous commit wasn't complet, it's been added here. Still, signals for a linear importation process is bad.


:boom:


Great solution.


I'm with Goden: 3 digits


Sure.


just name it to m_enableSoftI420Convert as original


I'm still a bit bugged by this kind of dictionary initializations, it's not the first one I've saw.


forgot paradise compiler plugin...


You should add the shebang line as we talked. You have to add `#! python3` as the first line of each file.


please put your name here


This still ends up with a 'duplicate' log message from MagicScryEvent


do not remove original authors


shouldn't have added SourceContext where it was not needed before...


not used


I can clearly notice that you have copied this piece of code. This is really disappointed.


actually none of the imports are used in this commit


Hey Jon,

[There's no private messaging on github any more, so sorry about this weird comment-post-hijack thingy >_<]

My name is Robbie Iannucci, and I'm a member of the Chrome Infrastructure team at Google. I wanted to let you know that we've ended up incorporating some nds-style ideas into a pure-go appengine wrapper we've been working on (https://github.com/luci/gae).

It has a pure-go implementation of the datastore, memcache and taskqueue services which is Very Fast (~5 microseconds overhead per test to get a fresh instance of all three services). This means no more dev_appserver.py and no more flaky unit tests :).

In particular, it uses the nds algorithm for an ndb-style optional caching filter (in `filter/dscache`).

I mainly wanted to let you know since I just posted about it here (https://groups.google.com/forum/#!topic/google-appengine-go/sKIDZ06A5UQ), and I mentioned nds as a source of inspiration :).

The `luci/gae` project itself is still in flux, but maybe it could be interesting to you? Anyhow, just thought I'd let you know directly :)

Cheers,
Robbie


why.


Why didn't you use the `main` function as we have talked and the `if __name__ == "__main__"`?


Yep this is a hack. I believe the main issue is the one in https://github.com/firebase/firepad/issues/82 when that is solved it is possible this issue will disappear without the fix.


I hope to get back on Monday and write email about navigation/waypoints, I think I already described what is the target and you can find it by latest commits, but of course it requires shaking. We need to get release by 1st December, so unfortunately we will release now and stabilize current version, though navigation, track editing/viewing and audio/video notes are not finished. This long story about context menu touches almost every piece of software or it and I hope to get stable by the end of this year, then we can continue with stories related to search and routing algorithm issues.


merging


This ```return False``` has been added in df0e3d93.


Clever! :)


This commit closes #79


Richard,
What is your question exactly.
How is the refactoring going?
Let me know,
CPL


BasementDomainNumCounterBug (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1969 of 1969 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


可以问问NGU是啥吗。。。是指游戏吗？http://www.nextgenupdate.com/forums/ 这个？


This shouldn't use `devDependencies` since `devDependencies` actually installs a lot more than `dependencies` and adds another step to the npm install.


I am really sad about what you have done, and it is incredible because you want to make an app. So it means you are going to copy too while doing the app, doesn't it?


* jupyter notebook with JSON --> dataframe --> SQL
* python script: json_to_sql.py
* tested with info in commits.json
* put previous artifacts in the previous subfolder


grunt-cli needs to be installed via -g as it's a global package.


I'm confused, will this not cause any ZIP file to be detected as an APK?

Should it not be something like;
if raw[0:2] == "PK" and ('AndroidManifest.xml' in raw and 'META-INF/MANIFEST.MF' in raw):


This won't work because async is a function. :)

Can this just be a global that is returned from async?

eg,

```python
POOL = Pool(INT)

def async(decorated):

    ...
    def send(*args, **kwargs):
        return POOL.apply_async(decorated, args, kwargs)
    return send
```


nit - new line


have a visit


Input box prompt plug-in, support custom images, support the default color customization, support input custom color


Thanks Paul. Works like a charm!


You don't need the namespace qualifier in these calls.


   'X_unique_id
'X_typ

e' => "CAPTURE_ONLY"


Not clear from commit message why do we want to remove condition of development plugin


I feel like this is the wrong approach and is clobbering the work done in: https://github.com/crosstool-ng/crosstool-ng/blob/master/scripts/crosstool-NG.sh.in


Could you also remove #define ARRAYSIZE from sample\gcenv.h?


This seems not declared in kernel
https://github.com/sonyxperiadev/kernel/blob/misc-qcom/include/uapi/linux/msm_mdp.h#L165


This is better:

```java
  /**
   * Generates an identifier with a common prefix for this client.
   *
   * <p>The generated identifier is the fully qualified name of the
   * {@link OkHttpClient}, plus the {@link InstrumentedOkHttpClient#name} of
   * this is client, plus the given {@code fieldName}.
   */
```


Specifically: https://github.com/crosstool-ng/crosstool-ng/blob/master/scripts/crosstool-NG.sh.in#L342


Do we need this change?  What's the reason for adding the `executor-service` instead of just `OkHttpClient.class.getName() + this.name`?


teste


Marca error ...  Microsoft.Samples,FaceBasics.Face_p.DB  is not CLS - compilant
                          Microsoft.Samples,FaceBasics.Face_p.Table  is not CLS - compilant

ERROR  TypeInitializationException..


I still prefer to throw an error here if client ID is missing.
Any reason you do not want to return error here?


These tests fail on 0.10... realaxtion isn't implemented.


the rating system, whether that's an army of Google drones, a script that scans game text, or mTurk I have no idea


This file has to be refactored. It does not work correctly, does not properly handle all abnormal situations that can occur and is not readable.


Yes, I had been following it very closely, but am convinced now it was
worth it!
Best, Hardy

On Thu, Nov 19, 2015 at 2:18 AM, vshcherb <notifications@github.com> wrote:

> I hope to get back on Monday and write email about navigation/waypoints, I
> think I already described what is the target and you can find it by latest
> commits, but of course it requires shaking. We need to get release by 1st
> December, so unfortunately we will release now and stabilize current
> version, though navigation, track editing/viewing and audio/video notes are
> not finished. This long story about context menu touches almost every piece
> of software or it and I hope to get stable by the end of this year, then we
> can continue with stories related to search and routing algorithm issues.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/osmandapp/Osmand/commit/285a34f1ca41e67cd3ce5ad10cb41086b971f1bc#commitcomment-14488574>
> .
>


This is better:

```java
  /**
   * Create an instrumented {@code OkHttpClient}, using the given client.
   *
   * <p>{@code name} provides an identifier for the instrumented client.  This
   * is useful in situations where you have more than one instrumented client
   * in your application.
   */
```

Agree?


django创建projcet：django-admin startproject <project_name>
manage.py：一个命令行工具，可以使用多种方式与Django项目进行交互。
mysite/__init__.py：一个空文件，它告诉Python这个目录应该被看做一个Python包。
mysite/settings.py：该Django项目的配置文件。
mysite/urls.py：该Django项目的URL路由声明。
mysite/wsgi.py：用于你的项目与WSGI兼容的web服务器的入口。


Can you revert these whitespace changes in this class?


Whether this is only accidental or not, branches with this commit [pass](https://ci.appveyor.com/project/Eric89GXL/nibabel/build/1.0.413) Appveyor (unless they're breaking on a different test), branches without [don't](https://ci.appveyor.com/project/Eric89GXL/nibabel/build/1.0.412). Including in 2.0.2.


A few nitpicks.  I want to make sure the documentation and code style is consistent throughout the project.  Once this is merged, I'll release a 0.2.0 in the next day or so.


Opa, já fazendo aqui!


This class has to be refactored. It does not work properly, does not handle all abnormal scenarios and is not readable.


Sorry, faulty commit, this one fixed it: https://github.com/osmandapp/Osmand/commit/692dd68db92291a87db6125110399f9733a3bfdd

All I did is keep the display of the zoom level for a second, it was almost invisible before. Condition of Dev Plugin is untouched of course.


(not sure why I didn't get a notification for your comment sorry for the delay!)

The main reason is I didn't want to have this intermediate state where you haven't given Muzei permission so it can't show you random camera photos, but you haven't selected any photos from any sources. Basically the extension would be selected but it wouldn't have any photos it could actually show..


108453024-FixLeedNumberOfHoursNotMet (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1967 of 1968 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


@sparklemotion/nokogiri-core any objection to this change ?


Agreed. The one issue is this:
Either:
I read the bootstrap data (which is grouped by bootstrap) into columns, and then I compute the row statistics, OR
I read the bootstrap data into rows, and then I compute the column statistics...


There was a statement to center the crop box. I removed it and then it started to work fine.


Needs another pass to ensure proper error handling in all situations.


Yep, file this one under "Poor Design That's A Minor Annoyance". This function was adapted from Flask-RESTful and we never changed the argument order. Maybe in 3.0.


Needs complete refactoring for bug fixes and readability.


Readme for Samples Workspace to be used for Visual Studio 2015 tutorial and lessons and learning


we can't do this in the constructor because this whole object is created through deserialization and not through this constructor.  So to be actually backwards compatible you need properties to be a field.  Probably also want to add a method to this class like `public ETLStage getCompatibleStage()` that will do this logic and convert the old stage into our new one.


Has to be changed. We should not start a new game by creating a menu. Why does a menu implements Runnable anyway?


108453024-FixLeedNumberOfHoursNotMet (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


though it's temporary, perhaps a better name would be `isOld()`, with the flag indicating whether it's the old style or the new style.


though actually dont think we would need this if we had that method that returns the current stage


This sentence comes off backwards to me, as if it's saying that 'not being steady means the ticks are the same'.


管理站点


oops


认证系统


Again, remove 'currently'.


simpleaffy >10.5 years
affyio         >9.5 years
oligo          >8.5 years


用于内容类型的框架


会话框架


消息框架


管理静态文件的框架


此函数获取post数据所需要的各种参数


wrong commit message XD


should be rev1


创建Django app：python manage.py startapp <app_name>


django app是“热插拔”的，可以复用。


It just makes it much harder to link code into the enclave binary, because you now need to rewrite libraries to use these modified functions. Wouldn't it make more sense to prefix the functions that are *outside* the enclave with `sgx_` to signify that they are related to an SGX enclave?


"timem"


5321-GroundDomain_RDD (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (894 of 894 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.13%25-green.svg)


Lulz at exceptinons


simpleaffy >10.5 years
affyio >9.5 years
oligo >8.5 years


closes #2


`;` nit


@OmgImAlexis my bad, should have waited for you to check this. Revert if you think it needs to.


`;` nitpick 2


Nice!


Ansioso


TeamCity LabkeyModules15.3 :: Git postgres 9.4 [Build 27](https://teamcity.labkey.org/viewLog.html?buildId=286092&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 11 (1 new), passed: 235, muted: 4 Build time: 00:55:53
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.JUnitTest$RemoteTest.org.labkey.scrumtime.harvest.HarvestPayRateService$TestCase: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSHelpCenterTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyAntigenVariableSelector: <no details avaliable>

org.labkey.test.tests.DataFinderTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifySubjectCounts: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.ScrumtimeTest: <no details avaliable>

##### there are 1 more failed tests, see build details
```


same here


See also the follow-up in https://github.com/mapbox/mapbox-gl-native/issues/3069.


Whoops, some extra clean up, not all complete,  and a pointless update of some Bundle.properties files included by mistake.


project vs app
一个project可以包含多个app，一个app可以应用到多个project中。


107310700-change-license-text (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Can you fix it XD


`component` here is a `ModelNode`, not a view of the component. Don't know how to mock that. I'd be happy to simplify this.


Indeed did not seen you removed the goal execution.


IIUC, we never use these specific components when calling `getComponent()`, as we simply rely on features of `NativeComponentSpec` everywhere. If that's the case, I would remove these specialized versions of `getComponent()` (except for `NativeBinarySpec.getComponent()`).


You are correct I believe, what I meant to do there was if the file does not contain nameserver 127.0.0.1 go do more checks in 36 onward. So the grep should be normal and the if statement needs to be reversed. i.e. if not grep -q "^ nameserver 127.0.0.1"; then....

It did run fine but that's likely due to it not progressing that far as the --start flag was not set. I'll do some more tests and make the amendments necessary.


Be careful if you put back the execution that there's only 1 surefire execution (the issue was that we had no execution id before and thus we had 2 executions of surefire)


Done locally.


Do we need this here? `AbstractTargetedNativeComponentSpec` should already implement it.


This commit is being reviewed as a part of review issue #108.


add_role returns a WP_Role object, is it really needed to use get_role? Check return value from add_role instead and skip adding capabilities if the role already exists?


title added


Ah, all fine then.


kumajaya have u seen commit : https://github.com/CyanogenMod/android_device_smartfren_rendang/commit/d534cd4c78f2aa9c9e877a9718a7220ac214bea3


I guess we don't need this method here either.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.549.7e2763519691e5c409e80d88011bf57149bdf405](http://build.palaso.org/viewLog.html?buildId=66384&buildTypeId=bt323) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 926, ignored: 56 Build time: 00:26:37
### Failed tests
```
Chorus.Tests.dll: Chorus.Tests.ChorusSystemTests.CanMakeNotesBarWithOtherFiles: <no details avaliable>

```


Hi Jorge – you’re missing the comma at the end of this line. You can see there’s something wrong, as on the next line (2160), the colon character is highlighted in red.


Fixed in 58867894bd22efbc50195e48bb07e7b87e6b564f


That's because there was automated jar surefire execution, you won't have two now.


Removed in 58867894bd22efbc50195e48bb07e7b87e6b564f


By caching, I meant calling `toString()` once and storing the result in a local variable. A very minor improvement (avoids an `invokevirtual` call).


This is duplicated between CUnit and GoogleTest, and would throw an error if both plugins were applied. We need to extract this to some shared plugin, `NativeBinariesTestPlugin` looks like the right place.


rb.MovePosition() only updates in sync with the physics clock, so the movement lags behind the head tracking. I read that you can increase the physics clock rate to compensate, but that'd add additional processing overhead to the rest of the physics components in the game, which we probably can't get away with. So I switched it back to manipulating the transform directly. Since it's a kinematic rigidbody, this should be okay.


Using compiler pass now in 58867894bd22efbc50195e48bb07e7b87e6b564f


Discussed this with @dbu and refactored it to use a compiler pass instead. Fixed here: 58867894bd22efbc50195e48bb07e7b87e6b564f


Тут достаточно вместо raise просто написать super — выполнится дефолтное поведение method_missing (то есть исключение что такого метода нет)


CORINFO_HELP_METHODDESC_TO_RUNTIMEMETHODHANDLE_MAYBENULL_OBSOLETE should be deleted (notice that the original #if around it was other way around). I suspect that it is why hello world test is failing in CI on this change


I may have re-introduced this brittleness. Checking now


Looks so much better!


Checkmarx scan results 19 Nov 2015 12:07 UTC +02:00

High
Medium
Low
Info

New
2
0
2
0

Recurrent
0
0
0
0

Fixed
12
41
254
0

 Open Viewer
Included commits

Commit ID	Owner

ffed6f3c148f23deaa2c4243cd21f3695a283534	@cxehud

3d67385fc72bb7477487505938706ebda9cf3ecb	@cxehud


Oups en relisant mon commit je viens de me rendre compte que je supprime cette ligne alors qu'il ne faut pas !


Hi, you should iterate over groups from ``groupsWithSameGroupNameInTheSameNamespace`` and check if user is authorized for at least one group.
If yes, group belongs to him and he can use same name for this group too. If user is not authorized for any group from the list, then name belongs to somebody else (is already taken) and then he can't set value.
Thrown exception here is ok.


Cool! I had to do this today:

```
// bootstrap defines html {font-size: 10px;} - we don't like it
:root {
    font-size: 14px;
}
```

Now I don't need it :)


you can completely remove the line


Here is the reason: https://github.com/Telekom-PD/adb-vagrant-registration/commit/3407aa02d023de25cea581d034804e9eea8bc154#diff-5dd825e76cae19cf93d81b3b7bc4957fR91


INTEGRATION TESTING_2015-11-19 12:08:57


INTEGRATION TESTING_2015-11-19 12:09:00


orz...........


How is it going?


I was about to ask what this is used for, but it looks like you forgot to commit some changes here, and finally included them in your following commit about documentation. No big deal, but remember to check ```git status``` and ```git show``` to know what you're actually going to commit :)


Please don't convert this test to `@Managed`. This is about checking that you cannot use the default implementation type to instantiate a component. This is pointless to test for `@Managed` types, where there's no default implementation.


cool


Yes. I'll look into it. I suppose it would not matter if we moved to HDF5 but in reality it will still be some time before we have the resources to do that..


Its because of required upload in https://github.com/Telekom-PD/adb-vagrant-registration/commit/3407aa02d023de25cea581d034804e9eea8bc154#diff-7b85367729840c0c5f95b6b9c18229c5R36


I'd call this `UnmanagedSampleComponent` or even better: `UnmanagedComponent`. That specifies the intent better then `My`.


This addresses: https://github.com/readium/readium-sdk/issues/166


nice catch @alexandru-m-g


Hi Leandro, the name field should just be the name, not the site’s domain name. So I’m guessing this should just be ‘Empregos’.


cool
keep it up!


I got an error at some point because python was not installed. I was trying various things so I'll double check and make sure it is actually required.


This commit is being reviewed as a part of review issue #111.


This commit is being reviewed as a part of review issue #112.


This commit is being reviewed as a part of review issue #113.


I think to be extra clean, the surefire config in the coverage profile should also be inside the execution, WDYT?


I don’t think multiple URL entries would work. The URL is used in the site name, is that right @rmlewisuk?


Why the separate function?


some tests failed:
failure: http://buildbot.bos1/builders/test-riak_kv/builds/2757


its used only internal and private, to its makes sense to avoid the capability here


see above


Already in-scope


Hm. I'm not sure if we should use traits in samples. AFAIK, the docs talk about interfaces and classes, but don't mention traits. Let's ask @bigdaz: WDYT?


Yeah just one url, otherwise the json is invalid.


Ok. Seems it fails on machines that don't have ocl-icd available.
If I now understand correctly, the bug is with *funcptr[165] which should have one more entry.
```#ifdef HAVE_OCL_ICD``` hides this in pocl_icd.h


Suggeriment: Personalment, prefereriria anomenar-la d'alguna altra manera, que indicar el tipus de distribuidora. "Distribuidora amb capçalera" (i "distribuidora amb miniatures" per a l'altra, per exemple)


I changed this to use variables instead and tweaked the wording a bit in the paragraph before.


От этого визуальные побочки, например Избранное:
Было
![snap1](https://cloud.githubusercontent.com/assets/1483359/11268028/c8ad5608-8ebf-11e5-93cf-06bc33bd64c5.png)
Стало
![snap2](https://cloud.githubusercontent.com/assets/1483359/11268032/d0e530ac-8ebf-11e5-9234-7d1b4186dd59.png)


Вот этот ход мне сомнителен.
Во-первых, копировать все переменные класса в переменные объекта без разбора — это, ну, странное решение. Которое однажды может выстрелить в ногу и довольно больно (например если вследствие дальнейшего развития кода у класса тоже окажется переменная `@title`).
Во-вторых, заставляет СИЛЬНО задуматься читающего — этот код просто слишком «хитрый» для простейшей задачи копирования — на данный момент — ОДНОЙ всего переменной `@movie_weight`.
И, наконец, а зачем её вообще в instance variable копировать? По условиям данного задания, значение одно и то же для всех объектов этого класса, зачем КАЖДОМУ из этих объектов своя переменная, хранящая то же значение, что у остальных?..


INTEGRATION TESTING_2015-11-19 12:17:16


INTEGRATION TESTING_2015-11-19 12:17:18


Aquestes URL les extrauria a una extensió de Twig, per a que estigueren accessibles com a variables a totes les pàgines. Si vols, crea un ticket i me n'encarregue.


I swear I fixed this already, but I can't find any commit and now I don't remember how I fixed it.


No continues posant això del `attribute`... no cal que canvies els que ja estan (ja ho farem en el futur), però no fem gran "la bola" :)


A meaningful name is something like `numberToCheck`, `numNotChecked`, `uncheck_int`, or `a_fuxking_int_not_yet_check`.


It doesn't work with the class, as the type is the interface and the object is the concrete class.
But it's unit test it's not for the prod, so I don't feel it's risky.


Em sembla bé. Ja està fet.


Лучше символ (в смысле `define_method :to_s`)


Mola :)


Revisat


**Code Quality: Nitpick**

Ensure to be consistent with your model naming. Stick to singular names for the models.


I love this comment :heart: !


Решение, в целом, верное, но можно выражение немного упростить (обрати внимание, что у тебя тут zip'аются результаты двух выполнений `instance_variables.map{...}`)


fix: https://github.com/MOxFIVE/hexo-theme-yelee/commit/c732947298ca4f0340f7557c86daea6bd12aadbd


I now saw that these errors also show up in my log from the cronjob from last night. So I think I should be able to find the issue this evening. I'll keep you up to date.


#5287-EnergyPlus-crashes-when-assigning-2-UnitarySystem-to-same-zone (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1965 of 1968 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg)


Never mind, it's very obvious.


We don't have any info on the tx queue which woken up..


Segurament seria bona idea dir què estem afegint al `$context` en el nom del mètode.


Commit message is wrong, that file was only in the bs3 layouts repo.  This one fixes the groupBy in div layout.


Really we should be using Swift's `ErrorType` instead of `NSError`.


Why is this commented out?


is this a scalatest DSL?


This is causing issues (and seems a BC break).  The returned binary in my case is '/opt/remi/php56/root/usr/bin/php<space>'. This will cause the process not to find the binary.

https://github.com/sensiolabs/SensioGeneratorBundle/pull/430#issuecomment-158015092


This commit is being reviewed as a part of review issue #108.


woot, will update [koa-static](https://github.com/koajs/static) now


File in "releases" folder is for 0.11.0 '~', i can't join


Is this happening on a background thread? I see that `NSData(contentsOfURL:)` is being used. Perhaps we should consider switching to a `NSURLDataTask`?


ddddd


Açò (crec) que només mostrarà primer els destacats, però sense tindre en compte la data. Segurament volem posar els de data més propera primer.

De tota manera, és una cosa que podem resoldre més endavant (creem un ticket per a no oblidar-nos)


@ydx1013 按理应该可以，看不到你改的代码，不好判断问题所在。


Is this really the conditional you want to use here?


Open an issue, not comment.


А говорил — не понимаю :) Отличное остроумное решение.
Только название метода — лучше короче и с `?` в конце (так принято делать для всех методов, которые должны вернуть true/false), напр. просто `match?`


Looks like an interesting talk :+1:


Entraste com sucesso, {Player name}


looks ok. can you also commit the preprocessing script somewhere?
the code that inserts data into the db is not here yet, right?


@paveljanik I can get rid of those but have you seen https://github.com/MarcoFalke/bitcoin/commit/d53b5e176ecdae367ee2a0061d5e71372ef5b1ec#diff-b953c2b148ec2c0b65aef0ca6cf28a1aL75


Error handling with an enumerated `ErrorType` is much preferred. See https://developer.apple.com/library/prerelease/ios/documentation/Swift/Conceptual/Swift_Programming_Language/ErrorHandling.html


On 11/19/2015 11:38 AM, Robert Sim wrote:

> IIRC, members have been obliged to host people all these while. Just
> that it is ad-hoc and informal at the moment.

There has never been any such agreement. There have been specific
agreements to the contrary.

- Roland


segurament ací jo faria un `remove_filter`


These comment-related changes belong to e2916521 I reckon.


Только теперь хорошо бы и от этого case избавиться, чтобы код выглядел как-то типа «для всех известных подклассов → проверить, хочет ли он такой фильм → и если да, создать экземпляр именно этого подкласса».
Тогда от всего этого метапрограммирования будет реальное преимущество: если ты изменишь список классов (например, периодов станет больше или меньше) — в этот метод не нужно будет вносить изменения.


Maybe I'm missing something. This is the second time you've used `if (true)`. Explain?


We also use Bootstrap and everything was hm… tiny ;-)


Et sembla bé: add_user_nav_info_to_context? La veritat és que aquest mètode afegeix totes les coses específiques per a la navegació de l'usuari.


ID should just be "default"


Makes sense. :+1:


every sane modern distro has fakeroot. what about removing this and adding fakeroot to tools/depends. that's what I do already.


Can you please try the patch in PR #16595?


You need to add encode and verify methods to this interface


Because it's faster to define outside of config


Nope.


I'm in favor of using Fabric's analytics rather than Flurry's, unless you know of anybody ever checking our Flurry Analytics statistics.


Nope, not in scope.


After some further thought, let's have the amount field as sint64 and count it cents.

We can ensure precision at the level of calculations. Keeping cent precision is good enough for us.


Why not just Money?


Why did you decide to remove default values for all these functions ?
We have warnings, because of this:

Warning: Missing argument 2 for _multisite_twitterblock_entity_subform(), called in


Avoid using id selectors


Could you please fix the indentation, we use 2 spaces not 3. Also your new constructor should also be available as a static method in the BodyHandler interface.


Podfile.lock should be in the `.gitignore.`


Why not just Currency instead of CurrencyCode?


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.550.7e2763519691e5c409e80d88011bf57149bdf405](http://build.palaso.org/viewLog.html?buildId=66393&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 927, ignored: 56 Build time: 00:28:02


Hi @tupaschoal, it would be better to move the email address from this (and the translations) into the dedicated email entry, like so:

`"email": "social@tiecketweb.co.uk",`

That has the benefit of making the email address clickable.


Works with `asMutable(..)`. Made the change.


For some unclear reasons one EditText is not shown.

![my_profile](https://cloud.githubusercontent.com/assets/15831041/11268457/8e091dc6-8eb9-11e5-8d36-4874f445bdda.png)


The entire `Pods/` directory should be in the `.gitignore`.


Done.


Also a good one 8)


I'm going to say, I've butchered a perfectly good interface that would have allowed multiple inputs, to now only work with single values.


humm... did you notice that the indentation got even worse? :)


Slipped through the recent conflicts, fixed, thanks!


Ok, I see from the previous commit, that you tried to fix the codding standards but it is wrong!


Sure


thanks


#5287-EnergyPlus-crashes-when-assigning-2-UnitarySystem-to-same-zone (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1428 of 1432 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.47%25-green.svg)


Here has some condition in else(CMAKE_SYSTEM_NAME STREQUAL "Windows") with corresponding if(CMAKE_SYSTEM_NAME STREQUAL "Windows")


So I will just submit this commit in a separate PR after 7027 is merged as 7027 has higher priority.


Thank's for this licensed.


test


\o/ salve


Fet


Please have names in comments above the value.


Add, please, this these changes.


Also has some condition in else(CMAKE_SYSTEM_NAME STREQUAL "Windows") with corresponding if(CMAKE_SYSTEM_NAME STREQUAL "Windows")


Yeah I know about the warning. Don't think it is valid though. It has to with how invalid CSRF tokens are being handled. Before, the call chain was aborted with an exception, resulting in the default error page on heroku. With `:reset_session` the call chain is aborted and the session resets, which logs out the current user and redirects to the login page.
So, as far as I know and could find, there is no difference in the security. Difference is in what the user experiences: a random error page vs. being logged out.


Travel Reimbursements? Euses tool isch ned nur für reise spese. Chasch das mit em stiller namal abkläre?


Thx for the report ticket created NEXTEUROPA-7129


No need to check if the log level is enabled, that is done by the logger already when you log the message.


Я рассуждал так, кнопка скачать есть, если зашли с мобилки то какая ОС можно понять, т.е. это не ссылки для выбора приложения для конкретной ОС. Я решил пока поставить типа три картинки, можно и одной или фоном, вдруг они по отдельности пригодятся.


NB this is work in progress - next push will look quite differently.

I needed that because working on multiple feature branches, and copying across while all definitions are inline in the customise_* is too fiddly and slow, I don't have so much time. But cleanup will come, eventually.

Problem is that Tirgil is working in parallel so I had to share it before cleaning up.


I kept the name because it's 95% the same site (and thus same code) as the old Movie2k one. So, it's basically like they just changed URL. I'm not sure about pyload policy on a site changing URL tho; I'm fine with creating a new crypter too.


You're right, it was a mistake during a removal of some other useless default values.
Thanks for ticket, I will correct it.


I always update that branch with master to be able to merge it at anytime .
I know now how to resolve conflicts , that's good !


Sorry, blame me.
```
./configure --help
--without-PACKAGE       do not use PACKAGE (same as --with-PACKAGE=no)`
```


Who did the lazy coder script?
It would be nice to enhance it so it catches deprecated annotations and puts it into the "release notes".


Nit: Remove the "`"?


Parles de les URL de Facebook/Twitter/etc? En un principi vaig crear la plantilla share_links.twig, que m'ha servit per gairebé totes les plantilles que he creat fins ara. Tot i així, la plantilla distribuïdora 02 té altres estils i no l'he pogut fer servir.


ISO 4217 defines also 3-digit currency numbers. E.g. USD is 840. There are also currency symbols.
Can we define them as options?
See https://developers.google.com/protocol-buffers/docs/proto3#custom-options


Vince, mao ni ang partial design.


OK. I've used this definition from Java Money API.


@paveljanik If you also make the bitcoin-qt, I'd rather not call it `bitcoind`. Better suggestion? But honestly I don't have a strong opinion on this one.


If an on premise user made the update but not a -u, he'll have the correct js code + dynamically loaded XML but the webclie t XML won't include the dB_info assignment


Argh, `responseText` should've been `response` here. Logged in #37.


Ah, I see this isn't inside config()
I am used to functions being defined within config()


This is only for one, unique element so id is good in this case I think.


**Code Quality: Nitpick**

Use a better variable name here.


Nice! :-)


I tried to limit the visibility of RegularStatement methods, fields and inner classes to the bare minimum, but I couldn't avoid exposing those two. I'm not really satisfied with it so I might revisit it if I think of something better.


Why do that? Surely better to incldue within config() to share scope?


So, only one amount field and currency?


Channi mache. Söll ich ihm au d'demo zuegäng geh (junior, prof, fadmin)?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5863](https://teamcity.mesosphere.io/viewLog.html?buildId=77954&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 202 Build time: 00:09:58


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.134.7e2763519691e5c409e80d88011bf57149bdf405](http://build.palaso.org/viewLog.html?buildId=66388&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 939, ignored: 50 Build time: 00:38:04


28 @@


 > There has never been any such agreement. There have been specific
agreements to the contrary.

As I said, ad-hoc. You don't see people getting turned away just because
they walk in without prior appointment. Not at least the time for I have
spent at the space for the past couple of years. You should spend some
time during the weekdays in the space. Why? Cuz there is at least one
member (may not be me since I am not always at the door) who is willing
to host them.

Do show the specific agreements to the contrary.  No, wait, don't. This
PR is to at least make the opening hours clearer in the FAQ. If you
think the language needs to be changed, do it directly and commit it
instead of going on here. I have no qualms of the text being changed
arbitrarily by anyone. On a side note, I still have #119 opened as well
and I have yet to recieve feedback from the last changes.

Robert

On 19/11/15 6:26 PM, Roland Turner wrote:
> On 11/19/2015 11:38 AM, Robert Sim wrote:
>
> > IIRC, members have been obliged to host people all these while. Just
> > that it is ad-hoc and informal at the moment.
>
> There has never been any such agreement. There have been specific
> agreements to the contrary.
>
> - Roland
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hackerspacesg/hackerspace.sg/commit/d915f0ae68ed4186bb83b5190760722921651427#commitcomment-14495661>.
>


+*.Slo


Hi Ole, you’re editing the wrong file, the file you want to change is [sites.json](/olewels/justdelete.me/blob/master/sites.json).

I’d suggest something like this:

```
    {
        "name": "DHL (Paket.de)",
        "url": "https://www.paket.de/pkp/appmanager/pkp/desktop?_nfpb=true&_nfxr=false&_pageLabel=pkp_portal_page_footer_cah_faqs",
        "difficulty": "hard",
        "notes": "Write an email to request account deletion.",
        "domains": [
            "paket.de"
        ]
    },
```

I’ve snipped out the translated strings, in part because I wouldn’t be able to translate them, and I wonder too if a German site would need all of those international translations anyway – can packet.de be used outside Germany?


*tranbinhboiboi@gmail.com


Make that 1 thing.  Time of day transitions quit killing framerate sometime in the last month or so.


Shouldn't the source file also be committed if this is generated content?


@noise64 this is the fix :o


#5287-EnergyPlus-crashes-when-assigning-2-UnitarySystem-to-same-zone (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1428 of 1432 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.72%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.47%25-green.svg)


BasementDomainNumCounterBug (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Why should `\DOMDocument` not exist?


Don't we need CXX=clang++ too, then? Or does cmake infer the c++ compiler from the c compiler flag?


@tillrohrmann @mxm thank you both. It's good know where I can find binaries I build on my own (was looking for them in my target folder). I was also trying to find some of them on the website, but it is somehow difficult, e.g. this [page](https://ci.apache.org/projects/flink/flink-docs-master/) states that pre-built snapshot can be downloaded there, but what you find is 0.9.1 stable version.


Good to hear. I'll remove the exclusion.


**Code Quality: Nitpick**

Make use of the template view here to prevent the need to implement a redundant get method that just renders the template.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5864](https://teamcity.mesosphere.io/viewLog.html?buildId=77955&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 202 Build time: 00:04:48


@jodosha Is there a reason 0.5.0 was not published as a gem?
The latest version is 0.4.3 at https://rubygems.org/gems/lotus-router


Actually, I was a bit fast. This will not work, as you cannot override ENV vars in build time.

You have two options:
a) use `ARG JENKINS_UID`, docker build will then take a --build-arg JENKINS_UID=<id>
    this is only present in v1.9.0 though
b) rewrite to use an entry point which creates user from ENV var. this can then be configured runtime with --env options to run command


Aaah, nice, I tried [this](https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#links) initially, but it didn't work, so I reverted to the ugly inline links.


This commit is being reviewed as a part of review issue #114.


We did not follow same version for all component. But we will for the next 0.6.0


This commit is being reviewed as a part of review issue #115.


This commit is being reviewed as a part of review issue #116.


Yes, I know about it, new version of Moodle doesn't allow on installation plugins if they have old declaration, moodle shows error, so I fix it.


`cmake` moves in mysterious ways. it deduces `CXX=clang++` from the `CC` environmental variable


tags = ios, android


Yes, sure - as I said before: I moved into separate function to speed up implementation across multiple feature branches, as it was too fiddly to cherry-pick details from deep inside customise_* and I had to share it quickly since working in parallel with Tirgil.

Cleanup will follow, eventually. Be patient.


Ja eh :+1:


+import org.apache.log4j.Logger; - это зачем?


修改乱码


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5865](https://teamcity.mesosphere.io/viewLog.html?buildId=77956&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:07


Почему json игнор?


Зачем эта строчка тут? Она имеет отношение к коммиту?


`region` is the geographical region to send request to.
Valid options are currently:
* eu (Europe)
* na (North America)

`sync` enables anonymous-id syncing to Mojn (i.e. cookie sync)

We have some minor changes to the commit - should those be handled now or will the "change process" be a bit more swift going forward?


Так бинарных и нету. А прочие "автогенерируемые" попали в архив после make distrib - он их автоматом и упаковал. Написанный мною вручную make так не делал. Выложить его?


Do you think it's linked to this change?


@gautric Do you use standard IntelliJ indentation? If not, can you use it? This is the default indentation used in Apache Camel and Fabric8. It's pretty nice :) .


ユーザ個別ページの表示内容が、ログインユーザ(current_user)に必ずなってしまうという不具合が発生していたので修正しました。ついでに、自ユーザ以外がユーザ変更画面へアクセスできないようにしました。


I use the same cheatsheet when I forget stuff. Markdown is nice, but too many flavours.
Reference style links do not work on Github, but I still like them :-)


Aah, cool. I would still add it so that it is explicit, but that's up to you :)


"not testing locally"

"I did test locally"

:package:


I need your help please !!! Thanks in advance, I take time trying to find the solution to this problem. I am using your library EtsyBlur, to display a framgentDialog. Everything works fine, but the main activity is open the keyboard and pulse on the button to open the passage, but it opens the view where the keyboard was not working the drawable blur.


how the qdisc know what tx queue is free to send the packet on? I mean , the qdisc can return a packet, which then cannot be transmitted since its tx queue is blocked, and then you need to re-enqueue it. In fact, you have a livelock here. Say, tx queue 0 is blocked, 1 is free. Dequeue () returns a packet which tx queue is 0. I try to send, but the tx queue is blocked; so I re-enqueue the packet, and I'll stop running. Next time Run is invoked, i still dequeue the packet that has queue 0; but queue 0 is still blocked, and so on, until queue 0 is free. In this time, packets on queue 1 (that is free) are blocked inside the qdisc.


I had missed the "contains"


Cool, glad it's better :)


There shouldn't be param ``group`` but ``groupWithSameGroupName``.


!mustfix this will prevent script files from being copied.


Alright


rename to LOCALE_CACHE, please


Note the [DriveNotFound](https://msdn.microsoft.com/en-us/library/system.io.drivenotfoundexception(v=vs.110).aspx#Anchor_6) MSDN page says that it is actually thrown from PATH_NOT_FOUND exceptions based on metadata.


Может все таки общую функцию для failure блока :) Но одно и то же же


Ok, cleaned up.

And before you ask: yes, a prepop-option for case statuses is underway. I just need lunch first - I'm hungry.


Resize is run before editor is activated, so container em will not be defined for DnR, thus it is not possible to resize elements before resizing DQ.
Move resize to after activating editor.


This commit is being reviewed as a part of review issue #116.


Many people doesn't know about the website we have, I want them to see it as there are the rules.


这里主要是为了以后能加载网络图片，留出接口


BasementDomainNumCounterBug (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1969 of 1969 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


what about "only_core_step_added_to_container_when_DevCockpitBridge_is_null"?


Forgot this there while testing, thanks :-)


这里以后应该有一个判断，是加载本地图片还是网络图片


ok, just noticed this test is actually a duplicate of the next one


Wa ra ni pulos. Way changes.


This made the demo fail to "npm install" do to "make sure you have the correct access rights" for the Android version.


Oks. Lamats.


a mock of `DevCockpitBridge` could do it there, can't it?


Here you _assume_ that the return value from `gen_tcp:listen` call would be positive. And if it is not, then the process will crash and supervisor will restart it. This is, in general, a good approach. But you didn't read about erlang error handling, as far as I know. This should be learnt in the near future.

Ok.


This commit is being reviewed as a part of review issue #120.


This test is only there to check that at least one step is in the container : "at_least_one_core_step_is_added_to_the_container" ?


Tranbinhboiboi@gmail.com


A


**Code Quality: Critical**

This area needs to be re-implemented. You are failing silently if there is an invalid e-mail address used.


Changed my mind after:

https://github.com/wrygiel/emrex-ncp-response-schema-DRAFT/commit/71594412463e673f187b0bc6e7b27a023b787e6b#commitcomment-14494562

Currently I'd like this to be left unchanged.


I think there should be two separate tests on whether the `PersistDevelopersStep` is added and on whether the classes of `DevCockpitBridgeImpl#getCeComponents()` are added to the container


It could indeed


For 32-bit,  a `\` is missing


you are right. :P


This commit is being reviewed as a part of review issue #117.


In fact I indeed first separate this test into 2, bu tI thought it was too much.
But I can split it again.


This commit is being reviewed as a part of review issue #118.


Should it be `resp.Close()` or `resp.Body.Close()`.

Also, want me to do this for all your implementations as well?


I tried mocking this, and it's just too complicated. Let's keep it as it is then.


The reason this is a context is to be able to use it whenever a context is required without having to construct one.


...and here you again change the _'Let It Crash'_ approach to defensive programming style.


#5287-EnergyPlus-crashes-when-assigning-2-UnitarySystem-to-same-zone (rraustad) - i386-Windows-7-VisualStudio-12: OK (1965 of 1968 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg)


this doesnt work below php7 so....cant be used


This is https://issues.jboss.org/browse/WINDUP-823, @OndraZizka  please assign it to you and resolve it when you are done


Shouldn't these casts be done wrt the correct data type?
```
ptr_exp = (UNITY_PTR_ATTRIBUTE const void*)((UNITY_PTR_ATTRIBUTE const _US8*)ptr_exp + 1);
```
instead of
```
ptr_exp = (UNITY_PTR_ATTRIBUTE const void*)((_UP)ptr_exp + 1);
```
With the below code you actually skip most of the elements as _UP is UINT and _US8 is signed CHAR?!


Декоративное. Пока нет графики и изображение не совсем мелкое, я делаю img.


You can also use string array,  so that we can save a using statement


I have confirmed it is required. It is required to configure kerberos which is a dependency brought in by mongoose. If python is not installed this will result in an error during the npm install.


taken alone, this log is not very helpful (imagine seeing it in the middle of sonar.log)

what about "No id registered in repository for Developer '%s'"?

Same comment applies to 'id '%s' already registered in repository for Developer '%s', can not set new id '%s'" ?

Looks like the whole class could be improved regarding logs


@harry-wood any idea why the entire file has changed? I note one issue is the file currently is with "DOS" line endings as per the standard CSV spec. I could strip that but be careful you haven't changed all the line endings by accident. Would love to get this merged :-)


Should not delete this line


this is a  good idea


Can't we unify MonoGenericParam and MonoGenericParamFull ? Are anon generic params really created in such a number as to justify the complexity  ?


Yes, I was waiting decision from @xmd5a2 but then we used default colors from map activity. It should be aligned with map style, but so far I didn't hear any reasonable proposition, so it gets default implementation. We have at least 4 colors there.


@jodosha Thanks for quick reply. BTW, when 0.6.0 will be release? Only those 2 to be closed, I guess? https://github.com/lotus/lotus/milestones/v0.6.0


!mustfix remove this comment (it doesn't make sense here).


test name is explicit about its intent, go


We might want to change some of these into inline functions because they look kinda complex.


I mean, the `mode` command doesn't work as I expected it to.


If I saw it in sonar.log, then I'll know from where it comes from :).
But indeed, logs can be improved.


fixed


BasementDomainNumCounterBug (mmatts) - Win64-Windows-7-VisualStudio-12: OK (1969 of 1969 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


This line was designed to check command terminal width, but it appears that it doesn't work.


ok !


Bonjour,
Ne devrait-on pas changer le '<' en '<=' dans l'expression

$search->having("nextvisiteyear < YEAR(NOW())");

afin de voir tous les établissements qui doivent être visités dans l'année et qui ne le sont pas sans attendre l'année A+1 pour que cela soit signalé?


Here the PR with introduction of this feature: https://github.com/projectatomic/adb-vagrant-registration/pull/42/files#diff-012813ae38225959131ac73be3185031R28

Probably its a good idea to have here a dedicated improvement PR for https://github.com/projectatomic/adb-vagrant-registration/pull/42


Hm, not very fond of renaming "elmo" to "emrex-ncp-elmo-response". Any particular reason for that?


@charettes as you suggested I used the `_create_index_name` to remove only the index created by Django.


MrARM found this byte to be used for skin transparency. Apparently it will result in exploits, so it is wise to assume it not transparent anyway :)


`$this->perm === null` is faster.


You don't need a license


<attachment> only is not good enough, it should remain within <report>.


Why... Player__32bit should be something generated by a preprocessor, not manually. :-1:


There is a g_assert_not_reached () macro for this.


No reason. I simply saw that Richard and Miika have renamed it in their XSD. I will rename it back to elmo. (WRTODO)


Haha I prefer `.@rand` .. but nvm as long as it doesn't conflict with other `.@i` in the same script.


; fixed


Agreed, this should be encapsulated in a method.


This change is required because SslShutdown & SslGetError will be called from SafeSslHandle ReleaseHandle(). Otherwise if SafeSslHandle is used here, it will throw System.ObjectDisposedException as runtime will try to do AddRef before passing it to Native.


This commit is being reviewed as a part of review issue #120.


Commented temporarily to avoid the console error as the element #back is not present in the new markup.


This is very nice. Nice and neat and good use of && and toLowerCase()

Not better or worse but there are some other ways it can be done as well just in case you see some other examples. You can just check the computer wins conditions and then catch everything else as player wins ( and vice versa ). Just saves on a bit of code.


I think that Richard and Miika wanted it renamed in order to highlight the fact, the our response is *not* ELMO (and this is a fact).


javascript will let you away with things sometimes because it tries to be helpful. so this actually works. but it's good practise to end every "statement" with ;


Alternatively, we can rename it to <consistsOf>. But leaving it unchanged is fine by us.
From what we understand, ideally there should be only one <hasPart>, with multiple children (of multiple types), even though multiple <hasPart>s are also ok.


I think that these colors should be the same as icon colors used in "Manage map files". Green for up to date maps and orange for updateable maps. Blue color 1) interferes with water 2)difficult to understand that he represents


> only is not good enough, it should remain within .

What should remain within?


What do you mean bad ?

Here it's used for loose coupling between memopol and django-representatives, I'd like to know if there's a simpler way to achieve this.


OK, no strong opinions here regarding the wrapper.


please consider defining a dedicated type for Address as it guarantees type safety.
I admit i forgot to mention that on a previously merged PR.
take a look at the examples in consul.v1.common.Types


oops, of course this is not just for precise.


A few years ago I encountered crashes when using a previous version of SimpleJSON.  I tracked the problem down to my app's assigning JSONValues (e.g., *val1 = *val2).  The default assignment operator was not performing a deep copy.  Thus, when the source JSONValue was deleted, it invalidated the shallow pointers within the target JSONValue.

I see that you implemented a deep copying copy constructor.  I have therefore crafted an assignment operator from that, rather than submitting my own assignment operator code.  I've defined a member function "DeepAssignment", shared by the copy constructor and the assignment operator.

The trivial C++ program I used to test the pre- and post-fix is the following:

```C++
#include <json.h>

int main (int /*argc*/, char * /*argv []*/)
{
	JSONValue *value = JSON::Parse ("{\"root\":\"app_folder\"}");
	JSONValue copied = *value;

	// Test: ADDRESS (copied->object_value [0]->second) should differ from ADDRESS (value->object_value [0]->second)

	JSONValue assigned;
	assigned = *value;

	// Test: ADDRESS (assigned->object_value [0]->second) should differ from ADDRESS (value->object_value [0]->second)

	return 0;
}
```

Before my changes, `&assigned->object_value [0]->second == &value->object_value [0]->second` (using a debugger).  After the fix the addresses are different.


Maybe also fix the comment to ` // 00   03 09 00` too.


Is this web-compatible?
Code like -
```
relList.add("gallery");
...
if (relList.has("gallery-item")
{
 // Gallery item implementation.
}
```
Will fail.


BasementDomainNumCounterBug (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (895 of 895 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.13%25-green.svg)


:+1:

The README is not very clear and I got confused that `puppet_gem` was in fact a separate module.

This pull request removes this confusion, so please merge it in order to avoid any confusion for others as well.

Thanks!


Just a note: I have edited your answer add added backticks around XML elements (Markdown would hide them otherwise.)


这行是干什么的啊


@gautric I propose to avoid using short variables names, like `kr` or `pks`. Again, I'm trying to be in sync with Camel and Fabric8 coding style.


Regarding <credits>, we need multple instances of this, both ECTS and f.ex FS, and it should include <level>. For ECTS, <level> should be BACHELOR/MASTER/PHD.


LGTM


Thanks for this. Can you also upload so it can be installed with luarocks? ATM it is still installing 1.7.4-4


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5866](https://teamcity.mesosphere.io/viewLog.html?buildId=77958&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:02


Hmm, I think we probably do want this to be escaped in the generated HTML, don't we? Maybe we should be escaping the ampersand in the text in the ERB given that we emit that directly into the HTML.

Also, the commit comment talks about apostrophes rather than ampersands.


I have run a raft of tests and in the below gist is the one I think that shows the results we would want.
<script src="https://gist.github.com/baelish/288d08418cada6d71e2f.js"></script>

If you agree I will make the necessary amendments and do another pull request.


We have also national codes which we need to send, these should be kept as a type in <identifier>. For that reason, subjectArea and ischedCode were also types, but no strong opinion to make own tags for them.


I don't see why you say that. It looks correct to me.

Sent from my iPhone

> On Nov 18, 2015, at 2:47 PM, Not Mark <notifications@github.com> wrote:
>
> On line 1514, I think the four middle FredkinCells should die in generation 1
>
> —
> Reply to this email directly or view it on GitHub.
>


We need <resultDistribution> back!


Te trzy okna to dystrybucja, a ostanie magazyn. Proszę o opinię i pytania. Co do ostatniego nie mam pomysłu jeszcze


@mpuzar - Ok! But please comment on the *parent* of the `<credit>` element. Would you be okay with moving it inside the LOI?


This commit is being reviewed as a part of review issue #124.


+= 1 is a perfectly good way of increasing a number by 1. There is a helpful shortcut for this too called an incrementer.

i++;

you don't need an equals, a function or anything. that all by itself will increase "i" by 1.


.tar.gz бинарный ;) make distrib его упаковал, но не ОН его git add/commit/push ;)


No need for `state:open state:closed`, it implicitly returns both.


fehlen ifups für 3 weitere cases


@Bonczidai shouldn't the quotes wrap the `${}`?


stupid editor interpreting < and > Fixing the comment(s) now.


a


It makes sense to have python, as python is always installed on RHEL

Its own deveploemnt


# lmk


- Fixed a typo where a `/` was typed instead of a `.`
- Expanded `src` into `source`
- Updated the [puttylogs.py](puttylogs.py) description to match the rest.


Issue #5


@Argimon There are 2 main changes:

- The call to `linkCommitsToReviewIssue` is in the top-level function.
- `-open` is being processed in the top-level function.
- `-fixes` is being processed in the top-level function.

This makes the module more obvious and it also fixes the issue with linking commits multiple times. The functions now return a slice containing the commits that were newly posted for review, so then it is easy to just link these.


see above


It won't work with CM13. But there are some useful commits. So I'm reproducing some of them for CM12.1.
--
Sent from my microwave


BasementDomainNumCounterBug (mmatts) - i386-Windows-7-VisualStudio-12: OK (1969 of 1969 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


We also need the possibility to group courses, which seems to have been forgotten somehow. See attached image for an example. It could for instance be an attribute/tag referring to an element with a name that we'll show.
![elmo-grouping](https://cloud.githubusercontent.com/assets/11192048/11269885/98486fc0-8eba-11e5-94cb-0307c224b493.gif)


That solution double saves each object which isn't a great idea.  I reworked the code to allow you to use a `before_save`:

``` ruby
def check_for_spam
  if persisted?
    self.title = 'SPAM' if id % 5 == 0
  else
    self.title = 'SPAM' if (Post.last.id + 1) % 5 == 0
  end
end
```


What is the reason for this change? If all objects are removed before outside the batch update, the complete set will be cleared and all objects will be inserted again. In this case the set can't figure out, what to insert, update or delete.


It's OK but its not really moving ... its different viewpoint to credit.

From CWA 16077: "Instances of this class (credit) may be used to represent either an account of the
credits that can be obtained from completion of a learning opportunity, or of the credits
obtained as a result of completing a learning opportunity, depending on the context in
which an instance occurs. In each case, a separate Credit instance must be used to
represent credit within a particular scheme."


it's an expr which concatenates strings, first quote refers to `'{"id":'` as the first param. second str refers to `'","status":"available"}'` as last param


using sizeof(long) instead of 4 is problably better.


Why at all this file is in diff? *.iml's are included in .gitignore.


@chelmuth: please add to staging


Thanks for those comments, they are helpful now even for me.


@robertharm Good catch, these should definitely all be HTTPS


Thanks :)


Nevermind, just saw your [comment](https://github.com/luvit/luv/pull/194#issuecomment-157807464).


I renamed them to elements, because in previous schema they were classified as "types of course identifiers". It seems to me that these are rather course attributes (not identifiers).

Did you use identifier elements for your national codes only in order to be compatible with the schema? Perhaps we should allow custom elements in the schema? Poland could use such custom elements too. How about we include an optional `<meta>` element on to the end of some all other elements, which would accept `xs:any` elements?


No need for this comment here.


Use of wrappers can be disputed ... those who use xslt/xquery could not care less and those who use certain parsing libraries are strong supporters for the containers. Im just saying if you use wrappers ... use them consistently or do not use wrappers at all.


Changed in my next commit. xD


@kutsyk, вася.. знову логуєш


I see no reason to move them somewhere else from `<identifier>`.


@kutsyk, $('#email').val()


no newline at end of file! :-1:
everybody's text editor should enforce these tbh


1. As to the `<resultDistribution>` - have you noticed that Miika and Richard have replaced it with a `<shortenedGrading>` element? Is this not enough for Norway?

2. I don't understand what you mean about grouping courses. As far as I understood your database model, this can be achieved by adding additional `<learningOpportunitySpecification>` elements for your groups and nesting your courses under it. Am I wrong?


@AnnieRuru how about this?


5 != 33, not that it matters :D


$git--clone--vike--Neel --Mkfile-DIR-rw/neo20067*/


graduated


![screenshot from 2015-11-19 17 17 54](https://cloud.githubusercontent.com/assets/4609643/11270066/c514b49c-8ee1-11e5-83ef-bf25de3fdfc6.png)

frontend


triedy sa zacinaju velkym pismenom


Go for it. We might think it's obvious know, but in 2 months we probably won't remember.


GitHub editor is using the Markdown language. Whenever you want to quote code, you should use backticks: `like that`

```xml
<or>like that</or>
```


I just read your comment about post ids.  It is a good observation, I am used to thinking of all collections as being zero-indexed, but not the database.  So you could modify the above:

``` ruby
def check_for_spam
  if persisted?
    self.title = 'SPAM' if (id - 1) % 5 == 0
  else
    self.title = 'SPAM' if (!Post.last || (Post.last.id) % 5 == 0)
  end
end
```


My immediate thought at a glance:

Re-using an IV for a given key is quite dangerous, and it's possible for this to occur accidentally with filenames.

The generally accepted standard is to use (securely) random IVs and just prepend to the ciphertext for ease of decryption; why use deterministic IVs based on filenames in this case?


Ah, this is the bugfix, right? We were recording a one-off entry here.


Doh!!!


Thank you for this. I'll get on it today after work.


`string` is not in my system, can use `sed`:

```
set -l out (echo $argv | bc)
set out (echo $out | sed 's|\\\\ ||')
```


I don't really like using signed comparisons on variables that in principle should be unsigned and where negatives don't have clear numerical semantics. I'd much prefer we use a symbolic constant to denote UNKNOWN_HEIGHT.


@twangboy why is this the release notes for 2015.8.1 ? Shouldn't this really be the ones for 2015.8.2? (line 2 above?) And why is it 'ONLY' a 'TAG' and not an official release?

Is there NOT going to be a 2015.8.2 release? ;-(

I was very much hoping and waiting for the release of 2015.8.2 and it's windows minion installers as that will be the first 2015.8.x version that is actually useable (and update-able) on the 2015.8.x series, all the ones until now have serious limitations and can't really be used in production.


> This uploaded file has been marked private by the author. Sorry!

It may have changed since Sep 30...


ResultDistribution is still in the model and in my fork https://github.com/amiika/elmo-schemas/blob/10d4eaa5e76b7082cd6780459ea147c645214db9/emrex_ELMO.xsd


@airend The DRM libs will end up here eventually as well, yes. I just haven't sorted them out for Marshmallow yet.