Yeah, sorry for that, I should have included this in the description. The error improvements are a mix of drive-by and addressing feedback (iirc from Gustavo) from an earlier LP review.


Consider a graph with 4 nodes like this, the | indicate partition separator.
1 - 1 - | - 2 - 2*
After the first iteration, the graph is
1 - 1 - | - 1 - 2*
Yet the 2* vertex cannot be updated in subsequent iteration, since it is not in the work set (did not change value in the first iteration) and cannot receive any messages (internal-only vertex).


the needed function is available now -> can be merged


nice one!


添田です。
こちらもswitch文は必要無いですね。
switch文は条件分岐ですので、条件が無いのであれば使わなくて大丈夫ですよ。


Ah, right. Will loop through the layers.


add check `strictEqual(data.length, 3);`


remove


looks good

[ REVIEWED ]


http://purl.org/net/elmo has been used in the official ELMO specs, so I have assumed that it has been working in the past. If it hasn't then it shouldn't have been used at all.

What do you think about GitHub's permalinks as XML namespaces? I have described how this would work in the "schema versioning" section below.


This whole file needs revisiting. Going to bring it in line with the text
from the site

On Tue, 17 Nov 2015 at 21:08 Jake Benilov <notifications@github.com> wrote:

> Should this mention how to install the plugin from GitHub?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/1Pass/1pass-for-wordpress/commit/91510c8079c784403838b278ef02c3849ad56b12#commitcomment-14455618>
> .
>


Docstring lines should not exceed 79 characters.


Adding so many new FIXMEs (and there are others elsewhere) worries me.


ReadAt always returns a non-nil error when n < len(b). This is not the case for Read() and I'm too lazy to write more code to check how many bytes Read() returned. If the file is less than 20 bytes its not a valid snap in any case :)


I think there are two separate (but obviously connected) issues conflated in your comments:

1) The issue of the design of partial perms
2) The creation of monoids and groups with 0 generators but a specified identity

I don't think either of these is directly related to the changes in this commit.

To address these issues:

1) I guess this is really an issue that should be discussed on its own. There are some good reasons that partial perms are designed this way, which I can go into in more details (here or elsewhere) if necessary. I think the real issues are that it is not possible to fit  monoids of partial permutations into the previous GAP framework (i.e. One(x) = One(M) for all x in M) without either doing something highly clunky in the definition of partial perms (like specifying the overarching domain of every partial perm at its point of creation, or having a universal One for all partial perms whose domain would be all the positive integers, the former will be difficult for users, the latter will lead to "correct" GAP behaviour that disagrees with the expected mathematical behaviour), or it would not be possible to create monoids of partial perms at all. So, I guess I agree with your meta-level comment. I have struggled with `IsMonoid` and its meaning for years, early users of GAP also struggle with this (I get questions of the type: "I defined a monoid in GAP but `IsMonoid(S)` returns `false`, is GAP broken?" all the time). In any case, I don't think any of this discussion is directly related to the changes in this pull request.

2) This pull request has nothing do with this issue. The changes in this commit only apply to semigroup/monoid/inverse semigroup/inverse monoids defined by generators where a generator is the `One` of the object being created. If it is the case that it is easy to check if the `One` is a generator, we do this, and we check if it is ok to remove it, and only remove the `One` in case that it is ok. (This is also future proof, in the sense that, if partial perms are changed so that the `One` of any element in a monoid equals the `One` of the monoid, then nothing will break, only an unnecessary check will be done.) This has nothing to do with creating monoids with 0 generators and a specified identity element, and the changes in this commit do not introduce any inconsistency in the behaviour of monoids and groups, as you say.

The situation (before this pull request) is that if you do:

    gap> S := Semigroup(IdentityTransformation);
    <group>
    gap> GeneratorsOfSemigroup(S);
    [ IdentityTransformation ]
    gap> GeneratorsOfMonoid(S);
    [  ]
    gap> GeneratorsOfGroup(S);
    [  ]
    gap> Print(S); # non-GAP readable output!
    Group( ... )

With the current change you get:

    gap>  S := Semigroup(IdentityTransformation);
    <trivial transformation group of degree 0 with 1 generator>
    gap> GeneratorsOfSemigroup(S);
    [ IdentityTransformation ]
    gap> GeneratorsOfMonoid(S);
    [ IdentityTransformation ]
    gap> GeneratorsOfGroup(S);
    [ IdentityTransformation ]
    gap> Print(S); # GAP readable :)
    Group( [ IdentityTransformation ] )

This is entirely consistent with groups (before and after the pull request):

    gap> G := Group(());
    Group(())
    gap> GeneratorsOfSemigroup(G);
    [ () ]
    gap> GeneratorsOfMonoid(G);
    [ () ]
    gap> GeneratorsOfSemigroup(G);
    [ () ]

Previously, also before this pull request you got:

    gap> S := InverseMonoid(IdentityTransformation);
    <inverse monoid with 0 generators>
    gap> GeneratorsOfSemigroup(S);
    [ IdentityTransformation, IdentityTransformation ]
    gap> GeneratorsOfMonoid(S);
    [ IdentityTransformation, IdentityTransformation ]
    gap> GeneratorsOfInverseMonoid(S);
    [  ]
    gap> GeneratorsOfInverseSemigroup(S);
    [ IdentityTransformation ]
    gap> Print(S); # not GAP readable!
    InverseMonoid( [  ] )

Now you get:

    gap> S := InverseMonoid(IdentityTransformation);
    <trivial transformation group of degree 0 with 1 generator>
    gap> GeneratorsOfSemigroup(S);
    [ IdentityTransformation ]
    gap> GeneratorsOfMonoid(S);
    [ IdentityTransformation ]
    gap> GeneratorsOfInverseMonoid(S);
    [ IdentityTransformation ]
    gap> GeneratorsOfInverseSemigroup(S);
    [ IdentityTransformation ]
    gap> Print(S);
    Group( [ IdentityTransformation ] )


Would probably be cleaner to just split the whole string by commas once, make a lookup table and then check each gate action against the lookup table.


Closes #37, #36.


Alternative to purl.org: https://w3id.org/


All good with the new 304.131 driver and xorg-server-1.18.0 - thanks everyone (and nvidia).


Did u have a peek in the device tree commits other than the one listed?


Nope, it's just a generator returning `"foo"`, but `yield` should never be executed. Could also be `yield; return "foo";` actually.


There is no need for this `i < 10000` hack. We have already established this, at the cost of some expensive tests. Simply:
```
while (flag.test_and_set(std::memory_order_acquire)
    std::this_thread::yield();
```
Besides, there is no need for spin locks to start with. Mutex locks are fine, now that they are not on the hot path.


The commit message is too vague, please write several lines explaining what you did in each one.

Separate the first line with an empty ine - which will serve as a short summary, e.g. https://github.com/paplorinc/spock/commit/a421de5972f0b7fc2a73c85fbfcc5e04c2428c67


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5687](https://teamcity.mesosphere.io/viewLog.html?buildId=77397&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:10:04


Pulled, and working here!


why has this been removed?


Sketchup2016 (macumber) - Win64-Windows-7-VisualStudio-12: OK (2335 of 2370 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.52%25-yellow.svg)


I'm seeing this error in the log when the currently playing page refreshes:

2015-11-18 05:40:34 [stebe] (session) -> mfvfr3mlof8g3j80o9s52bgks4 has been extended to Thu, 19 Nov 2015 05:40:34 -0500 extension length 86400
2015-11-18 05:40:34 [stebe] (ajax.server.php) -> Called for page: {index}
2015-11-18 05:40:34 [stebe] (autoload) -> 'lib\Metadata\Metadata' not found!
2015-11-18 05:40:34 [stebe] (autoload) -> 'lib\Metadata\Repository\Metadata' not found!
2015-11-18 05:40:34 [stebe] (autoload) -> 'lib\Repository' not found!
2015-11-18 05:40:34 [stebe] (autoload) -> 'lib\Metadata\Repository\MetadataField' not found!


same here.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5688](https://teamcity.mesosphere.io/viewLog.html?buildId=77405&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:45


Thanks for taking the time to write and share this @slindstr.

What's the use case or problem this is trying to solve? Adding a delay would make it seem unresponsive. Is this to try and best guess the user's intention whether or not to use the zoom?


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.571.1a851e802fd2a6b7dd3a2aa0f2e1a5ef1e803531](http://build.palaso.org/viewLog.html?buildId=66307&buildTypeId=bt322) outcome was **FAILURE**
Summary: Execution timeout; tests passed: 3289, ignored: 106 Build time: 00:37:11


添田です。
良いですね！最後に結果を配列化して返すところは課題に無いですが、
結果をきちんと返却するのは良い事です。


again, these should be parameters to another method (extract line 42 to a separate method (ctrl alt m), that will have these exact paraeters ... again, the WHAT should be separated from the HOW)


2* doesn't have to be in the workset. Its neighbor that changed value will be, and consequently will produce a message for each of its neighbors, including 2*.


Yeah - just hacked the patch together this morning ... I need to find out where the old value was coming from ... as PA really needs them.


Consentici di rimanere in contatto?


The bottom can still be created even though there are no connection layers.
In wirePrint a layer consists of a vertical connection and a horizontal roof.
The bottom is an exception: it only consists of a horizontal part; it therefore is not a WeaveLayer.


This file does not validate as json, and thus break 'bower install'.
Please fix trailing comma in "main" section

 "dist/r360.css", =>  "dist/r360.css" // No comma


I think the z0 of the first layer should always coincide with z_bottom...


As mentiond: we should not use load_error for anything unless the load state is actually UNIT_ERROR.

Also, I am very sure the load state should be whitelisted, not blacklisted, i.e. we should only allow this for UNIT_LOADED really, nothing else..


Vorremmo renderti partecipe del nostro lavoro?


the chances that they are the same is high but no guarantees. This part of the code is a big big mess. If it works it should be ok :)


Looks OK.


French also ?


Changes at 155 should be performed differently.

Changes at 145 seem OK.


shouldn't this be wireFrame.z_bottom ?

If the layers are empty, there still is a bottom layer!


Currently finding out - where the old code setted encodedRate ...


Can you clarify why this wait is needed? You've referenced a call to onCreate() in the comment, which callback are you referring to?


Moving credit from LOS to LOI is a BIG deviation from MLO [CWA 15903:2008]


This should have already been reverted when my comments to another commit are followed.

[ REVIEWED ]


@ahocevar Ich habe die zeile jetzt ausgebessert, allerdings sehe ich wieder eine karte, aber der die geolocation von meinem browser (der standort wo ich mich gerade befinde) ist nicht mehr sichtbar..., könnte es sein, wenn ich die karte von brackets aus teste, dass es nicht funktioniert?
lg g04


Yes !
What do you thing about the next step with configurator , save presets in a folder ?


See my mail.


課題4.5の変数、定数宣言で数字をシングルクオーテで囲むのは危ないですね。PHPならその辺は無視してくれるのですがいちおう数字はそのまま書いてあげてください。

課題7番はよくできていますね


This makes sense.
0.0001 is one micron, which is the minimal integer representation of distance.

[ REVIEWED ]


Is `ecom_server_array` missing here?


good.

"INSANE!!!!" :P

[ REVIEWED ]


There's a small typo here: "availble"


Oh, i went to the moon but I'm back now 😁.
Can you take out your small card and open "System Information.app" then go to the extentions section and scroll to the part where the nvidia web drivers are, takes about 10-15 seconds to load the list. If you could make a screenshot of that?


Nice! Thanks for removing all the clutter.


elements_per_row_ is an array. It should be num_rows_ * stride_


nice

[ REVIEWED ]


Needless `do`? (That's not harmful, but it looks a bit strange having a do block with only one statement in it which then uses the `>>= ` operator).


typo: requ**i**red


So what changed exactly??


Why is node_modules in the .gitignore?


Proposition pour simplifier ce bout de code un peu compliqué :

    % if university.detail_page_enabled:

    % endif

     % if university.detail_page_enabled:

    % endif

fun.css:

    universities-list a img {
        /* border rule */
    }


I am doing  CLI catalog update and I'm seeing these errors in the log since this commit.

[ampache.txt](https://github.com/ampache/ampache/files/37738/ampache.txt)


Oh, yep! Want to add a pull request?


Vu que ce template devient compliqué et répété dans deux endroits différents, il pourrait être judicieux de le déplacer dans un fichier séparé.


Welcome back then :)

system information app, you mean system info? Cannot find that!

My small Nvidia is already out.


Wonder if we use `MUST` and `SHOULD` language re quality levels and parentheses levels. e.g. "There are 4 quality levels, X, Y, Z. To be in a given quality level for a given type of data certain information must be present. This is indicated in the table below. Where a number is there this information MUST be present to obtain this quality level or any higher one. Where the number is in parenthesis e.g. (2) this means that the information SHOULD be present but it is not required.

I also wonder if we should actually define quality levels and explain them a bit here as per the quote just provided (there's a bit in the intro to the content section but that could actually be moved down here - the intro is a bit overlong atm IMO)


I fear this would be incompatible with both Norwegian and Polish database model. Richard, could you elaborate?

In Poland, a single course may give a different number of credits, depending on various factors. So, in other words, in this particular **instance** the student would get this number of points. But some other student might get a different number of points for the same course.


Awesome commit!


@dannysmith Here's my solution to Questions 1 and 2.


I'll fix it. I wrote this before your update, when elements_per_row_ was a number!


I have done it.


nice! hope this never fails due to numerical inaccuracy?


Why not do that, then?


@davidkelley just a small thing but this will throw if `code` is not found in `names`.

Pythonic way to do this would be
```
return self.names.get(code, None)
```
If you're not working with python though as the main language that's understandable (I'd probably wouldn't pick up on a ruby eqivalent).


添田です。問題はありません。
ただ、foreach文の中でshow_dataを読んでいる部分について、少し危険を感じます。
できれば関数の結果を一度変数に受けるなどした方がよいですね。

特に、自分が知らない関数などを利用し、その結果をforeachで処理する場合などは、
最悪戻り値が配列であるというチェックができる様、一度変数に受ける事を進めます。


What is doing the cleanup of f? I don't see tihs from the diff.


du kannst copy/paste von der funktion "unixtime_from_newest_file_on_disk"
machen und dann:

timestamp="$( unixtime_from_newest_file_on_disk )"
_system date unixtime2date "$timestamp"


alter ich blick nicht durch :sweat_smile:


It directly came from dvdplayer ... via DVDAudioFrame ... so most likely it won't work anymore - as the data came from "external" before ...


was hast du jetzt verändert? ^^


```# /usr/bin/systemd-tty-ask-password-agent --watch --console=
Assertion 'ac < argc' failed at src/tty-ask-password-agent/tty-ask-password-agent.c:816, function ask_on_consoles(). Aborting.Assertion 'ac < argc' failed at src/tty-ask-password-agent/tty-ask-password-agent.c:816, function ask_on_consoles(). Aborting.
```


@raeno , will you share it to base repo ?


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=11)


To make clear that the function is all about its side-effects, rather than its return value, I'd like to separate the statement into two lines, e.g.

```
int ret = functionWhichDoesAllKindsOfStuff();
if (ret > 0)
...
```

instead of

```
if (functionWhichDoesAllKindsOfStuff() > 0)
...
```


It's spelled "Tempelhof", it has nothing to do with Hasselhoff ;)


ich glaub gar nix, das war nur mega merkwürdig, weil ich letztes mal nix gepushed hatte und das mergen ging auch nicht so gut aber eigentlich sollte es genauso sein wie es war ^^


Sorry about this bug. I mistook this scaling for the zoom-by-scaling-geometry scaling that was used in the old coordinate system, and incorrectly assumed it was no longer needed.


This code has already changed in a later commit from @Ghostkeeper

[ REVIEWED ]


I am very sorry, my remark was of course nonsense: Somehow I thougth that you *replaced* the method for `IsSemigroup` by one for `IsGreensDClass`. But in fact you just added a new method -- that is of course completely fine. So, please just disregard the above remark of mine, and sorry for my confusion.


@VinceVal few things here:

With Python 2.7.10 there is no need for pyOpenSSL (and it actually can cause issues)
AppURL could be http://sickrage.github.io

Thanks for the update!


Click the apple menu, then the option key, the the top most item, if I'm correct it changes the top most item on pressing option


`i < length - 3` ? to prevent int overflow problems (in theory)


Ah, indeed, the README needs to be updated. The equivalent functionality should now be provided by either of the two equivalent invocations:

`perl -Ilib -MBio::WGS2NCBI -e prepare - -conf share/wgs2ncbi.ini`

OR:

`wgs2ncbi prepare -conf share/wgs2ncbi.ini`

However, to be completely honest, I haven't looked at this code literally for almost two years so I can't vouch whether this will do what you want. I personally have used it to prepare a submission of a large-ish genome to NCBI and it did the trick for me. Once it was approved I moved on to other things. If you think this is still useful code (potentially with fixes/changes/feature upgrades) then let me know. Maybe this should be published somewhere as a quick software note? Would you be interested in collaborating on this?


Of course, what was I thinking. Ignore.


can we change this by the way, so that it fetches all configs and returns this first one? Don't like the idea of hardcoding an id that in reality depends on the datastore


Try inline comments


Yeah, you guessed correctly what I wanted to say, but faile to: I didn't mean to suggest that your code is wrong; just that I find it confusing that `IsFinite := false` is used to signal "I do not know whether this is finite or not". So, an alternate approach to addressing my concern would be to rename `fam!.IsFinite` to `fam!.IsKnownToBeFinite` or so... Anyway, this is a minor point, I'd not be terribly upset if you ignored it :).


Not an issue.


@lucabrivio Nice Idea! Wouldn't it be more accurate to use local thread branching factor? Also can you explain why using log of nodes searched


DVDAudioFrame get the info from the parser


is this additional space intended? (there's two in front of the 3)


I read over that line.
Indeed, it should be "video = audio = vote = flag = None"
Or your solution.


![screen shot 2015-11-18 at 13 05 40](https://cloud.githubusercontent.com/assets/13314439/11239507/20c38586-8df5-11e5-8f94-fcab57ce30aa.png)


Redundant ()'s... HLint? :)


Can you match the indentation of the corresponding line please?


`.slice(-1)[0]`?

А зачем?


ist das schon vereinigt? ich sehe keinen merge-knopf


So how does this work when running on 32-bit? (ptr32?)?


Perhaps you can keep the previous form of the code here, just use lambda case for the second parameter?

`\running -> \case ...`


That makes no sense ... :-) the old architecture
Am 18.11.2015 12:05 nachm. schrieb "Rainer Hochecker" <
notifications@github.com>:

> DVDAudioFrame get the info from the parser
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/FernetMenta/xbmc/commit/b488d90ba05ba3ff51392b56b515382eb7b67955#commitcomment-14468471>
> .
>


We typically don't include issue references in unit tests.
Can we remove this please?


Since map partition also update the graph, messages should be sent to the resulting graph. But the updated graph can only contains vertices that's already in the work set, so 2* doesn't receive any message.
If I modify to send the message to send to the original graph (the solution set), then it also means that the map partition doesn't update the graph, which, in my opinion, defeat the purpose of partition-centric computation.


BTW, what commit is this ? This is different from what I committed and was merged (for e.g. stride is not copied in the copy ctor or operator = ). The modified files in my commit are here: https://github.com/kaldi-asr/kaldi/commit/b31dd359baa445c8af0c37a5fce4139299c4551a


shailendra


https://github.com/samaaron/sonic-pi/pull/802 :)


Why change `\_running` ->  to `const`? it's nice to know what's being thrown away


Please fix indentation  here (and line below).


please use `$.data('profile-id-prefix')` when retrieving `data` attributes


OK, I see. Perhaps a brief comment in the source mentioning that competing method would be helpful -- so that if somebody needs to modify the code, they know the reason for the rank adjustment. (I realize that there is a lot of code in GAP *not* doing that -- and I think that's bad, so if you'd be willing to lead with a good example, I'd be very grateful :).


I actually prefer the blue wave much better than the gray line. The gray line is confusing with dark themes in Emacs, it looks like an underscore, and makes me think I have typed some extra underscore. Maybe a gray wave could be a tradeoff option?


Yeah, there's the other risk of it being too little tested (linux-wide).


Fix for utf-8 characters in the mask mercure


finally i found the root cause


what you are thinking as a "preset" exactly?
Gaz, a ninjamer, propose something very usefull in a jam: save and load "input setups". For example, you can create 4 subchannels, insert some plugins, adjust levels and pans, and save all this "setup" as a preset called "My Singing preset". Change all things, insert other plugins, etc, and save the "setup" using a new name. Now you can quickly load these setups.
This is your idea for "presets"?

I see a little problem here, and you mentioned the problem in another post: We have some intersection between the classes Settings and Configurator.  For me load and save presets are Settings stuff, because the user presets are "User Settings". Restore/load a preset is not too different from restore/load the inserted plugins (the current behario when Jamtaba opens). At moment Jamtaba handle just "one global preset" for user inputs, and this is handled in the Settings class.

I'm not shure if Configurator and Settings are the same "person", or if Configurator uses a Settings instance, etc. The relationship is not clear in my mind. I feel we have some intersection, and I know you feel the same, but I don't know yet how solve this design puzzle :)


`style.display` is preferred when you don't have dynamic values for object attributes or checking if attribute is defined


No `logger.exception(e)` just yet, right? We should spec the `exception` field out once we're ready. Simple log message is great until then.


Personally I'd prefer putting multiple statements in front of a `catchError` in a `where` block, not a `let` block (like the `let go` here) or a nested `do` in parentheses (as in line 242 above). Admittedly that's just a matter of style, but consistency is also useful, and we use `where` blocks for that purpose elsewhere.


warum willst du Jugendschutz wieder in Kindersicherung umbenennen?


I think it is a mistake in the specification, they are probably not the nitpickers that we are :smile:
Changing to outputting one space and being able to process all kinds of spaces (like we are already) is probably a good choice.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.588.d29f80e02ff7cf19bf401ac88bb0baf589f1631a](http://build.palaso.org/viewLog.html?buildId=66310&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3311, ignored: 125 Build time: 00:06:41


@iht customise the highlights. The defaults are only designed for use with stock emacs theme.


Cool!


These lines are too long (over 100 chars) and hence not fully visible in Github.


Is moving the #ifndef include guards down to beneath the includes necessary for VS support?
Concerned about #including files multiple times.


The concept `X * 2` are both here and when we are parsing the parameters (`__utee_{to|from}_param`). Can't we just simply make a new define (`#define FOO (TEE_NUM_PARAMS * 2)`)  and use that instead. Also at such a define on could also write a comment why we multiply by two.


And the JetBrains people might say that it should be IntelliJ IDEA instead of Intellij IDEA or Intellij.


Only needs ```if (txt) {``` here, only a minor display difference and any JavaScript optimiser will do it anyway - could add a second safety check though with ```if (txt && typeof txt === "string") {```.


same as above


ids should be unique thus return just one element.


@Fivell, sure, I will. Planned to do it right after the merge of my fork but encountered some problems with tests, they fail on some undefined constant in ransack gem ( version 1.7.0 ). I'll check it out this evening


File was found ... -> File too small for license to fit.


@mk0x9 задумывалось что пути будут абсолютными от корня проекта, вернее того места где лежит webpack.config.js

В Вашем варианте, спрайт собирался с hashом равным абсолютному пути до файла + hash


`event` should denote high-level business events and its properties/tags should be meaningful too. `data` is too technical. You should flatten the values into `site: 'abercrombie`, `partner: halsbrook` instead.

`{ filename: filename, topic: topic }.merge(extra_data)` does just that


File .. was found -> First line {} differs for {file}


don't forget the [radix](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt) param


New users will have default allow instead of default deny.


We should not have nested object anywhere in logging/events/metrics/analytics. It makes it very hard to work with the data. No way to record into Datadog, for instance or put it into a Redshift table.


添田です。
改行コード良いですね！ログは見やすくする方が実践でも役に立ちます。


e.g. https://github.com/fommil/darcula-theme-emacs/blob/master/darcula-theme.el#L51


when it should ... -> Expected: {}


Including Avro2Kafka is redundant. The event will show up as `source: avro2kafka`. `"Started publishing #{filename}", "Started publishing #{filename} to the #{topic} Kafka topic."`.

No empty strings as description please.


Sorry habe nicht aufgepasst. Kannst du vielleicht ändern?


Why not use a ConcurrentHashMap ?

Regards


I'm not sure if this whole file is currently intended as a demo or for actual usage, but we are not longer in the prototype phase, so this probably *is* serious.


I originally had my own customisation, inspired from https://github.com/ensime/ensime-emacs/wiki/Editing#semantic-highlighting


getIndex frisst hat bis zu 800 ifups mit der for-schleife
vielleicht kann man ja den index einfach mit übergeben...


indeed, let me fix that, right @yanncebron :smile:


Just call it `path` and `filename`, no need to further classify, there is only `path` and `filename`, no?


Calling it just `filename` or just `path` should be fine as there are no multiple filenames and paths to differentiate. Also more consistent with the tag names.


should 'soln' be 'spt' ?


aber wieso findet er meine übergebene location nicht in locations? ://


у нас по всему коду есть такие проверки, что само по себе дичь
Претензия не к тебе(сам такое же копипастил), а в общей бездумности разработки.
Нужно везде по коду убрать такие проверки, так как эта проверка выполняется в @PreAuthorize("@Secure.isReader()")


なんか時間がおかしいことになっている。


namespace is not resolving, but you could use xs:import instead


There should always be a `message` so that we stay compatible with dead simple logging. For instance, we should have a simple formatter that only spits out the `message` when we work with the project locally.

This should also be validated and an error thrown if `message == nil`.

Maybe the `monitored` title and text could be reused for this purpose somehow.


Actually, 'assess' does have more of an 'estimate' connotation. It may not come across that well though in general usage. The trouble is that 'estimate' needs a value to make sense, which is why I changed from 'Estimate the current situation'. I will see if I can find some suitable alternative.


@mauriziocingi is the DLLDATA definition different from the DLLEXPORT def? hard for me to tell since i'm not involved in windows development.


What's the purpose of this alias?


@raeno , :+1: , and  good luck with ransack


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.572.1a851e802fd2a6b7dd3a2aa0f2e1a5ef1e803531](http://build.palaso.org/viewLog.html?buildId=66309&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3289, ignored: 106 Build time: 00:16:39


давай как-то не так
Давай подумаем как лучше переделать


Lines 399, 400 :
```javascript
total = $('#id_profile_set-TOTAL_FORMS');
total.val(parseInt(total.val() + 1, 10));
```


the current code is really crap. the generic interface DVDAudioCodec has this method:
virtual int GetEncodedSampleRate() { return GetSampleRate(); }, that is overridden by the passthrough codec. It does even set encoded rate for pcm which is bullshit.


Он относительный не от файла конфига, а от `output.path`, если он указан. А зачем сплит последней директории? Хотелось бы сохранять спрайт куда указывает output. Если вместо `a/b/c/` собранный спрайт надо будет положить в `c`, то тогда в output можно просто поставить `c`.


Sure, was just a quick replacement of the map type. Will update shortly. The whole thread proxy storage code will need to be rewritten later on as keeping strong refs is not ideal, while WeakHashMap is problematic


强迫症患者顺便改了一些东西。


Now that we've removed the `match` function... would it makes sense to simplify these guys to:
```
{
  list: function(attrs) {
    return new ListModel(attrs);
  }
}
```
(`match` doesn't make much sense IMO now, it's more like a `type` now)


Good point, I'll fix it.


Hm. The patch I sent earlier should work.. It is for that file..


Actually this is first time we are talking about `async` option in basesink. You are probably thinking about `sync` option in basesink.

They are entirely different options:

[sync option](http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer-libs/html/GstBaseSink.html#gst-base-sink-set-sync)

>
Configures sink to synchronize on the clock or not. When sync is FALSE, incoming samples will be played as fast as possible. If sync is TRUE, the timestamps of the incoming buffers will be used to schedule the exact render time of its contents.

[async option](http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer-libs/html/GstBaseSink.html#gst-base-sink-set-async-enabled)
>
Configures sink to perform all state changes asynchronously. When async is disabled, the sink will immediately go to PAUSED instead of waiting for a preroll buffer. This feature is useful if the sink does not synchronize against the clock or when it is dealing with sparse streams.

I hope this clears it up


Shush.


Don't get me wrong. I'm not complaining about the PR at all. I like most of the stuff you have done there. Let us talk about the details tomorrow!


Ok thanks.


Looks good


I know Gaz too ... ^^

**This is your idea for "presets"?**
Exactly !

**I'm not shure if Configurator and Settings are the same "person", or if Configurator uses a Settings instance, etc. The relationship is not clear in my mind.**
I understand .
For me we have to change (for example) :

void MainController::storeIOSettings(int firstIn, int lastIn, int firstOut, int lastOut, int audioDevice, int sampleRate, int bufferSize, QList<bool> midiInputsStatus){
    settings.setAudioSettings(firstIn, lastIn, firstOut, lastOut, audioDevice, sampleRate, bufferSize);
    settings.setMidiSettings(midiInputsStatus);
}

with

bool configurator::saveAudioMidiSettings(param list); //implement the funks below inside ?
   // settings.setAudioSettings(firstIn, lastIn, firstOut, lastOut, audioDevice, sampleRate, bufferSize);
  //  settings.setMidiSettings(midiInputsStatus);
}

So Configurator could be a user of settings .
Sounds logical to me


Style guide calls for comments above function declarations and/or in the cpp file.. don't see them in either place.


@mk0x9 я тестирую с помощью таски npm run build, посмотрите на реализацию в webpack.config.js в этом репозитории. Возмжно стоит предусмотреть и другой вариант.


> Again, we should discuss this in person as written words can be misinterpreted in many ways. :fearful:

Agree.


Let's talk in twitter DM


I have changed it... although it is a bit tricky to be able to definitively say that stakeholder and management support is needed. For some, one or other will be sufficient. Minor though.


添田です。nl2br良いですね！
入力内容を変数に取得する処理と、変数の中身をechoする処理は分けて書いた方が良いですね。
メンテナンスもしやすくなるので、やってみてください。


Looks good for me


I did not get that impression. Just like I commented on the other commit: It's harder to discuss in text, since you can read things into words :grimacing:


This makes no sense. `u'foo'` will still produce a SyntaxError in Python 3.2. Wrapping that into if-block won't change anything as SyntaxErrors are produced when a file is parsed, not when it is executed.

You can try using `'\n'.encode()` for Python 2 or enable `from __future__ import unicode_literals` which will make all string literals in this file be parsed as unicode strings.


Of course if they are necessary, they should stay. But now I am wondering: If you have something in `IsGroup and IsTransformationSemigroup`, how would you like it to be printed? Should it perhaps also be printed using `_ViewStringForSemigroupsGroups`? In that case, one could merge the two functions, using this weaker filter, and perhaps a larger rank adjustment.

But perhaps you deliberatly would like a different view method in that case? I am guessing blindly here, mind you :)


Hello Dave,

Thank you for responding too !

We are now another person in our city working on this project and
our motivation is to spread the idea of Peace in the world.

Look forward to your ideas and progress,

best regards

Kathleen
website
<http://www.thereddoorgallery.org>

On 17 nov. 2015, at 00:02, Dave Revere wrote:

> Hello Kathleen,
>
> Thanks for reaching out. I'm not sure at this time how to allow people to
> send it, but I could try. As for personalization, I think you are talking
> about using AngularJS. I could look at your project on Wednesday?
>
> Sincerely,
>
> Dave
>
> Linkedin <https://www.linkedin.com/in/daverevere>
> Github <https://github.com/daverevere>
> Twitter <http://twitter.com/daverevere>
>
> On Sat, Nov 14, 2015 at 7:56 AM, Kathleen <notifications@github.com> wrote:
>
> > hello,
> > I would like to work with you on a card project for peace...It would allow
> > the people, friends and followers to send an idea of peace for the New
> > Year. I have the gif done but I do not know how to do the personalization
> > of the card and allow people to send it.
> >
> > Also I would like people to download it from our site
> > www.thereddoorgallery.org and the code will be enclosed in a catalogue
> > 'calendar' that you can see on our site...
> >
> > Would you be available next week to work on it with me?
> >
> > kindest regards,
> > Kathleen Imbert
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/daverevere/putlove/commit/a6e691b75ecc10d5b9b03ea31a9518a9787eb275#commitcomment-14397703>
> > .
> >
> —
> Reply to this email directly or view it on GitHub.
>


Nothing crashes with that, right? Reinstalling would be a pain you know :)


another bit of cleaning up and organizing to go, before pull request


In MLO and CM, Credit value is Literal which can be "5", "1-5" or "Fail/Pass"


Why not pass a single param with the attributes to this method? ("extend" widgetAttrs with layer_id and layer_index)?


yes you're right, I was thinking I needed the match function in the upcoming PR for integrating torque, but giving a 2nd thought I think the model will actually be the same. :+1:


Tried that... didn't quite fit. I will try again :)


hum this doesn't work on Linux, extensions library are installed into `/usr/local/jamoma/lib/jamoma/`
why do you need to change this ?


Ок, посмотрю вечером, что-то где-то и правда не так.


"FLY" is very solo specific so let's stick with the Copter mode name, Loiter.


@borshop: retry


Da dürfte ein " fehlen... Wahrscheinlich will man nochmal genau drüber schauen...


That's understandable.

When I first opened the app, I had no idea what was what.

I had to do a little experiment of "tap this, see what changed, tap that, see what changed, and so on".


Hey, as I get no answer on another question, maybe you can still help me: I would love to test 1.0-SNAPSHOT on my test cluster, but I am not able to find download link. I'm somehow not sure how to build right those sources or jars, that I need for the start!? If the scripts like start-cluster.sh or start-local.sh are still the same compared to 0.9.1, then how could I go further from what I have?
I would really appreciate your help!
Thanks in advance!


Given that this change hasn't been incorporated into the ES backend, I would suggest using an extended backend: http://www.stamkracht.com/extending-haystacks-elasticsearch-backend/


intval() nie jest konieczny, bo LMSDB::Execute() i tak eskejpuje przekazywane do zapytania parametry.


Overview:
1. make sure you don't have implicit global variables (variables declared without `var`)
2. ids should be unique, no need to get the the first element
3. always set the radix param when using parseInt().
   in IE: parseInt('01')  returns 0
   in FF, Chrome, etc parseInt('01')  returns 1
4. if using jQuery leverage it as much as possible


The docstring could be extended/clarified a bit. I get the generally (but mostly because I read the source).


Contest/Olymp Training 1/Решето Эратосфена.py

fhgg


Jep ... so in normal cases if we use IEC format (which pulseaudio normally does) - format.m_sampleRate should be fine - but only for EAC3 it needs the format.m_streamInfo.m_sampleRate;

I will change accordingly later ...

The current commit I did - would work, too - as PA only support DTS / AC3 where encoded rate seems to be sample_rate, too ...


Ok, I will try using custom options for semantic highlighting, thanks for the hints!


Btw, the code itself it a bit dense and could use a few extra comments.


Man!! i said media_codecs_performance.xml sucks :cry:
it kills performace.. is it working for u ??


Let's not have params named `p`. :-)


Adicionado botao fechar


Hello Dave,

Thank you for responding too !

We are now another person in our city working on this project and
our motivation is to spread the idea of Peace in the world.

Look forward to your ideas and progress,

best regards

Kathleen
website


Corrigido, quando clica no mostra nao limpa o campo de codigo


There was an exception by Cryptsy API: "Cryptsy markets sync with settings.ini markets mismatch.".

The correct markets have now been updated (added/removed).

She executes just fine now.


This is really nice and clear. Some people prefer to do it in one line. Neither option is better than the other. Just wanted to show you an alternative.

return move || getInput();

I like your version because it's clearer


Uncaught TypeError: Cannot read property 'getParent' of null(anonymous function) @ VM5997:20j.exec @ mootools-core-1.5.0-full-nocompat-yc.js:88Request.HTML.Class.success @ mootools-core-1.5.0-full-nocompat-yc.js:467i.extend.$owner @ mootools-core-1.5.0-full-nocompat-yc.js:114c.Request.Class.onStateChange @ mootools-core-1.5.0-full-nocompat-yc.js:443i.extend.$owner @ mootools-core-1.5.0-full-nocompat-yc.js:114


ack


seems like it's broken on Chrome...


@binky123 Thanks!
As for the local thread branching factor, helper threads do not search at all depths, so I don't know how that could be estimated...
I am using log of nodes searched because how often total nodes searched gets doubled with increasing depth is proportional to log of total nodes searched... I'm not really sure this formula is logically sound anyway!


As the 1st issue is fixed so far (thanks for that) have you already had the time to think about the 2nd one? I am currently working on the watch towers in C2M1 and I really would like to try that.


Hahaha)) Made my day)


I ran it, restarted, what should I try now? SwitchReX? To see if the custom resolution installs?


This should be split into 3 files :
lib/jquery.debouncedresize.js
lib/jquery.imagesloaded.js
profilegrid.js


Can I suggest that we rename `tpct_target_bases_0x` to `pct_0x` since we're already in a per-target file and none of the other column headers refer to `target`?


Implantado: botao sair


请补充;


returning numbers here instead of strings is a nice touch. choosing what a function will return so that people know what to expect is tricky sometimes. You're closer to what people should do which is use something simple for comparison. Like it! There are other options too which we'll discuss in class.


new int[]{255,255,255,255};
on every render on probably multiple points *shiver* poor GC
is that really reuqired? can't you use one instance and return it's reference?


Since you never actually assigned the result of dividing by interval.length() to this variable, maybe it would be more appropriate to just call it `targetBasesAt0x`.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.573.d29f80e02ff7cf19bf401ac88bb0baf589f1631a](http://build.palaso.org/viewLog.html?buildId=66311&buildTypeId=bt322) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3289, ignored: 106 Build time: 00:18:33
### Failed tests
```
SIL.Windows.Forms.Tests.dll: SIL.Windows.Forms.Tests.SettingsProviderTests.Upgrade_SectionsRenamed_SettingsMigrated: <no details avaliable>

```


我保留了最初写程序所有的code，包括被command掉的也保留了。非常清楚的展示了一个混乱的脑子。希望下次review的时候我能看着这些code笑出来。虽然到时候也可能不太好笑。eh, whatever


We should log an error if gps_glitch_on_event or off_event are called.


After this commit no one build started normally with anvil world for me...

 INFO [iNetServer] - Plugins loaded!
ERROR [iNetServer] - Error during startup!
System.MissingMethodException: Method 'Array.Empty' not found.
  at MiNET.Worlds.LevelInfo.LoadFromNbt (fNbt.NbtTag dataTag) [0x00000] in <filename unknown>:0
  at MiNET.Worlds.LevelInfo..ctor (fNbt.NbtTag dataTag) [0x00000] in <filename unknown>:0
  at MiNET.Worlds.AnvilWorldProvider.Initialize () [0x00000] in <filename unknown>:0
  at MiNET.Worlds.Level.Initialize () [0x00000] in <filename unknown>:0
  at MiNET.LevelManager.GetLevel (MiNET.Player player, System.String name) [0x00000] in <filename unknown>:0
  at MiNET.MiNetServer.StartServer () [0x00000] in <filename unknown>:0
 INFO [iNetServer] - Disabling plugins...
 WARN [Essentials] - MiNETEssentials Disable
 INFO [iNetServer] - Shutting down...
MiNET runing. Press <enter> to stop service..


LGTM

When integration tests are stopped in the middle, this is very useful to start from a clean state.


These last three values should be run through fmt.format() before emission to avoid default java formatting that will include a stupid number of decimals, and sometimes switch to scientific notation based on the value.


You could "nest" some of these ifs here. So for example. say IF playerMove == "rock" {
     // check all of these
     IS computer move "paper"
           computer wins
     IS computer move "scissors"
          you win!
}

reduces the complexity a bit and means you can write a bit less


ack


低级错误，不要在末尾出现逗号。 虽然高级浏览器能兼容...


Hi,
when adding a requirement it should also be added to the plugin.php file.
Now users which don't have the RainLab.Translate plugin will get an error.

https://octobercms.com/docs/plugin/registration#dependency-definitions

regards,

Jelle


never use setInterval 。  可以用setTimeout 来模拟setTintterval


But it's longer. :p You can change it if you want.


Is this function just here for testing? not a problem. but always best to remove functions that you're not using. or at least comment them out


Done!


I just updated the configurator branch to avoid later merge problems .
The workflow seem to be better here !
^^


This is perfectly good. You can also

computerWins++;

this line all by itself means "increase computerWins by 1"


LEONARDleonard_hofstadter
SHELDON Cooper should be sheldon_cooper
PENNY should be penny
HOWARD Wolowitz should be howard_wolowitz
Raj Koothrappali should be raj_koothrappali


用生命周期的componentWillReceiveProps来setState


yep my bad, I had `video, audio, vote, flag = None, None, None, None` and thought that was equally as wasteful. I'll submit pr later if someone hasnt fixed it yet to do `video = audio = vote = flag = None`


Shouldn't it call `FreeLibrary(p->libglesv2)`?


test


It would be easier to use container instead of multiple hasPart elements. Should be changed to:

maxOccurs="1" with a sequence of LOS with minOccurs="1" and maxOccurs="unbounded".

... if there are no major compability issues


We should probably still be calling each child's RenderControl even though it is not visible (Thats what the base class does that we're overriding).

You can accomplish the same thing though by just moving the cellCount++ inside one of the two existing checks for child being visible.


could we rename this to perhaps "gps_glitch_action_required"?  That might make it more clear the purpose of the function.
The comments is a bit misleading.  It should probably be "determine if action should be taken depending upon the curent flight mode and return true if yes".. or something to that extent.  It's a small thing but I'd probably move the storing of the mode_post_glitch down into the gps_glitch_on_event and make the "gps_glitch_action_mode" const.


already fixed in 948ebb8


ack


There are 2 things to consider here:
- Algorithms like connected components converge asymmetrically, i.e. a lot (almost all) vertices are updated in the first few iterations and very few vertices are updated in the last iterations. The mapPartition will make a big difference in the first few iterations, when a lot of vertices change their values.
- The bulk iteration creates a new dataset as the input of the next iteration, while the delta iteration keeps the state (vertices) in an in-memory hash table, which can be very efficiently updated.

You can of course experiment with both alternatives, but I'm pretty sure the bulk solution will be slower :)


We use assertj in this library.


What's the reason for reverting?


shouldn't the max be SecurityUtils.getMaxDHGroupExchangeKeySize()?


Yep, you're right.


@ashutosh-mishra, please, clarify why is it needed there? Because on the next line we have:

```proxy.use_server('fooserver').add(1, 1)```


testing


CIRCLE should probably also be added in here.


tesssssss


@atd, I am getting this message. Please let me know if we should proceed as explained here: http://stackoverflow.com/a/30231329 or if you know how to fix it with another approach.

Thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5689](https://teamcity.mesosphere.io/viewLog.html?buildId=77426&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:10:28


LGTM


>  The original function does not destroy the search property :

True, I think we should not do it.

I looked at your patch again (currently in the master) and it looks good to me.
setupSelectorSearchBox -> does call destroy
(new in Fx45) setupInspectorSearchBox -> does not  call destroy

Honza


Nice regex use. When using `{1}` it can normally be omitted.

`/[A-Z]{1}/` and `/[A-Z]/` have the same result.

Similarly `/\s{1}/` and `/\s/` work the same.


А здесь всегда есть firstObject?


Предлагаю здесь использовать просто bool


Okay. Do you have or know of a write-up of the conventions for writing
titles? I didn't realize I have to use brackets in there, though I can
infer that it has something to do with the need for case conversion.

--Kenneth

On Wed, Nov 18, 2015 at 3:18 AM, Adam Liter <notifications@github.com>
wrote:

> The abstract is actually longer than this, and it has paragraph breaks. So
> it should be something like this with \par after each paragraph break:
>
>   abstract                    = {This dissertation is a defense of the hypothesis that the noun phrase is headed by a \textit{functional element} (i.e., ``non-lexical'' category) D, identied with the determiner. In this way, the structure of the noun phrase parallels that of the sentence, which is headed by Infl(ection), under assumptions now standard within the Government-Binding (GB) framework.\par The central empirical problem addressed is the question of the proper analysis of the so-called ``Poss-ing'' gerund in English. This construction possesses simultaneously many properties of sentences, and many properties of noun phrases. The problem of capturing this dual aspect of the Poss-ing construction is heightened by current restrictive views of X-bar theory, which, in particular, rule out the obvious structure for Poss-ing, NP[NP VPing], by virtue of its exocentricity.\par Consideration of languages in which nouns, even the most basi
>  c concrete nouns, show agreement (AGR) with their possessors, points to an analysis of the noun phrase as headed by an element similar to Infl, which provides a position for AGR; I call this Infl-like element ``D''. D and Infl belong to the class of non-lexical categories, which I prefer to call \textit{functional} categories. The analysis in which D heads the noun phrase I call the ``DP-analysis''.\par Importing the DP-analysis into English yields an immediate solution for the problem of the Poss-ing gerund: Poss-ing gerunds (and by extension, noun phrases generally) have a more sentence-like structure than hitherto thought, namely, DP[DP's D VPing]. (In non-gerundive noun phrases, ``VP'' is replaced by a projection of N. This projection of N, despite being a maximal X-bar projection corresponds to N-bar in the standard analysis.)\par Current trends in the treatment of minor categories---so-called ``non-lexical'' categories---lead to a similar conclusion. Until recently, minor cate
>  gories like complementizers and modals had been treated as syncategorematic. Under current assumptions, however, they participate fully in the X-bar schema. In this way, two simplifications are achieved simultaneously: we eliminate syncategorematic elements, and we acquire an endocentric analysis of the sentence, which had been exceptional in being the only exocentric major category. To make these results fully general, we are led to treat the remaining syncategorematic elements---in particular, determiners in noun phrases and degree words in adjective phrases---as heads of full phrases. The analogy with complementizers and modals indicates that determiners and degree words should head noun phrases and adjective phrases, respectively. In other words, determiners are lexical instantiations of ``D'' in the same way that modals are lexical instantiations of Infl.\par However, despite the conceptual links, the question of the existence of a functional head of the noun phrase (the DP-ana
>  lysis), and the question of the place of the determiner, are independent questions, and I treat them separately: Chapters One through Three are concerned predominantly with the former question, Chapter Four with the latter.\par Chapter One provides a brief introduction. In Chapter Two, I present the DP-analysis, motivating it by examining languages with agreement between noun and possessor. I also discuss issues raised by the DP-analysis, with emphasis on the parallelism between noun phrase and sentence hypothesized under the DP-analysis. In particular, I treat the question of PRO in the noun phrase; and I show that the numerous differences between sentence and noun phrase do not invalidate the parallelism of structure proposed under the DP-analysis. In Chapter Three I apply the analysis to the three gerundive constructions, Acc-ing, Poss-ing, and Ing-of. Finally, in Chapter Four, I turn to the question of whether the determiner is the lexical instantiation of D, the functional head
>   of the noun phrase.},
>
> Also, it's an interesting question of what to do about the subscripts. Let
> me think about it for a bit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lingbib/lingbib/commit/e2f2ac963394e1a1bad11053a9713fd2c7a8d9d9#commitcomment-14451414>
> .
>


done with https://github.com/recalbox/recalbox-emulationstation/commit/fd9fce53ce07877138cd4d34ddd0832a238243a8


I think we want the gps-glitch state to be used in the auto-init, brake-init, etc functions rather than the failsafe.gps_glitch.  I think the way it is, during a gps glitch it would allow the pilot to switch into say Brake mode but then it would immediately trigger a GPS glitch and throw the vehicle into AltHold.


You could also reuse the hasPart wrapper here if it is fixed to maxOccurs="1"


@dannysmith


```c++
  if (adForbidden)
  {
    self.appWallAd = nil;
    return;
  }
```
а else убрать


but I can got message from +48 791 467 755 and reply to 791467855 and it still should count.

I really don't know how to handle that. Query only by date and then try to normalize queried numbers and compare them in for ... loop?


I think that non sprockets asset manages will need to use precompiled versions of action cable where the erb and sprockets require directives have already been evaluated. I see no reason that a precompiled version of the cable javascripts couldn't be distributed for non rails users.


OK


Opmerking: Is dit echt het begin?


Зачем? Это же одно и то же


else можно не писать


The upper 4 bytes are zero then.


The message IDs are added later by the CoAPMessageChannel, so new IDs  are managed in one place rather than being spread throughout the code.


Да, если он будет пустой, эта кнопка не будет показана.


Do we really need commented code here?


для красоты и единообразия, я не настаиваю


This should have `@Override` annotation I think.


Enumeration:

1: Bachelor
2: Master
3: Phd
4: Any level


You can make a pull request to fix them if you want.


This comes from SDL behavior, which likes to impose a bit nonstandard pattern: SDL would like to implement its own `main()` that is the "real" main that will be called at startup, and it would like to then call into your application main. Effectively to hook into application startup before your app runs. See https://github.com/emscripten-ports/SDL2/blob/e60718c37e5b4dbabdc87c21193ee9e6e9bf562a/include/SDL_main.h#L104 and https://github.com/emscripten-ports/SDL2/blob/e60718c37e5b4dbabdc87c21193ee9e6e9bf562a/src/main/windows/SDL_windows_main.c .


Also `@inheritDoc` comment to inherit parent javadoc (same for setIdempotent)


Я не понимаю этой любви к if/return, тут в обоих ветках надо что-то сделать.
Когда в дальнейшем в этом методе надо будет что-то сделать (не связанное с этим), return будет мешать и придется это править.
В текущей реализации можно быдет добавить новый код не трогая старый :)


nice catch. thanks.


@dannysmith


Hi.
This was fixed upstream.


Нижний предел нужно указать


The GUI class MainWindow knows the MainController instance. When is necessary save or load something MainWindow call some methods in mainController, a member class in MainWindow.

From the MainWindow point of view the MainController class is a "Facade", a magic class capable of execute usefull things. But MainController do some things and delegate others, and the gui don't need know this implementation details.

For me the design is more clean if MainWindow request a store/save operation to mainController, and mainController delegate this operation for a Settings or a Configurator instance. This is clean because the GUI code (MainWindow) don't need know about Settings or Configurator directly, these classes are hidden behind the "Facade", the MainController instance.

If you move the MainController::storeIOSettings to Configurator the MainWindow class need know the Configurator to call it directly. This is not good because we have more coupling.

A possiblity is:
1. MainWindow knows MainController instance
2. MainController contains a Configurator instance
3. Configurator instance contains a settings instance.

To save something MainWindow call a method in mainController, mainController delegate to configurator, and configurator finally delegate to settings. A lot of delegation :)

the step 2 can be complicated. If you put a Configurator instance inside MainController without a pointer you will have problems to initialize the member because the Configurator constructor is private now (a singleton requirement). But if you use a pointer to a Configurator is easy initialize the class member (configurator) requesting the correct instance using the singleton. But now the singleton don't make sense, because you have the configurator instance available all the time as a class member in MainController. Ok, just remove the singleton, right? You remove the singleton and now you have a problem inside the LogHandler function. How acess the fucking configurator instance inside the LogHandler function? Solutions: back to singleton, or back to external, ha ha ha.

We are in a class design loop...


es mues imfall nöd nur d accountnummerä übereinstimmä, es mues au ds projekt übereinstimmä, das hettisch eigetli au usegfunde wod mitm pdf generiere agfange häsch vor öpä 2 mönet! zum ds pdf korrekt generierä chönnä häsch ja müese luege was das excel file alles macht uf dä erste und zweitä sitä. aber anschinend häsch das nöd gmacht, wännder das dclaudia hät müese säge


@ckirchhoff This breaks the git ignoring for me. AFAIK the correct way to ignore directories in the same dir is just to prepend '/'. In this case I think we'd need /lib


А есть тесты на работу с чанками/svgXHR?

On 18/11/15 14:25, Mike wrote:
> @mk0x9 я тестирую с помощью таски npm run build, посмотрите на реализацию в webpack.config.js в этом репозитории. Возмжно стоит предусмотреть и другой вариант.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mrsum/webpack-svgstore-plugin/commit/c4eca1ad944b3b5d6427f60f809ba933c4efbd50#commitcomment-14469042


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.547.7e2763519691e5c409e80d88011bf57149bdf405](http://build.palaso.org/viewLog.html?buildId=66314&buildTypeId=bt323) outcome was **SUCCESS**
Summary: Tests passed: 927, ignored: 56 Build time: 00:24:10


this is your version now, I hope it is ok.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5690](https://teamcity.mesosphere.io/viewLog.html?buildId=77449&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:56


I think the reorderAuthorizations method is superfluous... See this diff for getChallenges

```
-       var responses []authorizationResource
+       var responses map[string]authorizationResource
        failures := make(map[string]error)
        for i := 0; i < len(domains); i++ {
                select {
                case res := <-resc:
-                       responses = append(responses, res)
+                       responses[res.Domain] = res
                case err := <-errc:
                        failures[err.Domain] = err.Error
                }
        }

+       challenges := make([]authorizationResource, 0, len(domains))
+       for _, domain := range domains {
+               challenges = append(challenges, responses[domain])
+       }
+
        close(resc)
        close(errc)

-       return responses, failures
+       return challenges, failures

```


shouldn't this be required?


Nice fix.


Keras uses MaxPooling2D, but it does not have AvgPooling2D.
May use MaxPooling2D and AvgPooling2D?


I think the issue came that we couldn't add items in the ploneintranet/suite/tests/lib directory. If that is possible, then /lib/ is a good solution


When I'm trying to run the example mentioned in README for client, it throws following error :

In [23]:
In [23]: proxy = callme.Proxy(amqp_host='localhost')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-23-0a754f413625> in <module>()
----> 1 proxy = callme.Proxy(amqp_host='localhost')
TypeError: __init__() takes at least 2 arguments (2 given)
In [24]:


Added Anna's feedback


I too am saddened by the move away from Github. It is incredibly useful to get automatic references between issues across repositories and automatic email notifications (without having to create an account in Phabricator).

I hope I'm wrong but I suspect you will see a sharp decline in community contribution in terms of issues and feature requests.

Also, please consider that you broke every previous link to a github issue. There are links in people's emails, stackoverflow posts, IM conversations, _etc._ that now link to a 404 page. :cry:


JetBrains also use a capital J in IntelliJ (as per http://blog.jetbrains.com/idea/)


Thanks! :blush:


shouldn't it be conditional as well?


you can omit public here


@mk0x9 руки не дошли (: но в планах покрыть


shouldn't need ctx since it's available via mxt_device


# python-compile-zip
递归 编译 zip

D:\PM-compile
    MPV100R002
    TMMV100R001
    ...

D:\PM-compile\MPV100R002
    MPV100R002
    __init__.py
    MPV100R002.xml

D:\PM-compile\MPV100R002\MPV100R002
    Item01_01_01.py
    Item01_01_02.py
    Item01_01_03.py
    Item01_01_04.py
    ...

需求：将py文件批量编译，编译后删除py文件并压缩为zip文件，最后保留zip文件，其余文件及文件夹都删除。


The issue here is that len(responses) may be less then len(domains) which may leave you with an empty spot in challenges.


Ок. Я просто не знаю как оно работает, так что смогу сломать там
что-нибудь вполне.


Ah, I wasn't aware of the true meaning of BROTLI_RESULT_SUCCESS, was just trying to make @kothar's code work for my test data in a late night debugging session :)

That said, what would happen if we're decompressing a stream that's cut short? We'd get `C.BROTLI_RESULT_NEEDS_MORE_INPUT` and keep trying to read from an EOF'd Reader.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5691](https://teamcity.mesosphere.io/viewLog.html?buildId=77450&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:50


Poexalo


The last line about typeToJME is wrong - typeToJME on a TExpression just returns the expression, with no `expr(.)` wrapper.


Не правильно понял задание надо классу задать параметр и в конструкторе (__init__) прописать всю логику


Unfortunately, yes. I was hoping there was a way to go around the iframe.

Thanks for checking.

Vittorio

On Fri, Oct 23, 2015 at 9:27 AM, elliottyates <notifications@github.com>
wrote:

> Can you please clarify "changing the iframe to a div"? Canvas loads this
> in an iframe, which we don't have any control over (it's part of the LTI
> implementation), is that what you're referring to?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Harvard-University-iCommons/TLT-UX/commit/98575cb30ebea0ab15ce0ebb57fd03d11bd30805#commitcomment-13951886>
> .
>


First working version of this new script.


use a local temporary buffer rather than passing in databuf?


One thing to document here might be that by default, CMake does a debug build, so this and the above native CMake invocation both will create unoptimized builds. To get CMake do a release build, might be good to show here the `-DCMAKE_BUILD_TYPE=Release` command line flag to `cmake` which will have CMake do the optimized build.


delete this blank line


This could get cached in travis to speed up builds (in line 23)


I guess we don't need to handle the case in which the set_mode to the mode_pos_glitch fails?
I think it could only happen if the position_ok() returned false (i.e. EKF's position estimate was bad) even though the gps glitch has cleared.  It's probably ok to remain in AltHold in any case.


just return here


shouldn't need this check


return MXT_SUCCESS


Yeah, looks missing.


Perhaps a bit simpler would be to use `mkdir build_native; cd build_native` in native path, and `mkdir build_emcc; cd build_emcc` in web path, which would avoid the need for this note, and both builds can coexist at the same time?


I have no problems with the `Reactive` prefix, especially if the class fulfills the same role as an existing class in Spring and needs to be differentiated with said class.

With regard to `WebRequest` containing both request and response: I never was a fan of that name, to be honest;  `ServerHttpExchange` or something similar would have been better. That said, what's done is done, and I think it is more important to stay consistent with existing names in Spring than to come up with better ones. New names will only create confusion.


I've a feeling there is a different convention for naming this elsewhere in the code


Здесь надо переопределить конструктор (__init__) и в него уже передавать параметры


Fixed the issue: https://github.com/lmars/packer-post-processor-vagrant-s3/issues/16


This can go away now that the file is being opened above.


generally we don't initialise such variables as a matter of course (address 0 will result in some very odd behaviour if it actually falls through an error initialising it)


ah ah ah .. Thank you for that deep analyse .
I think i will experiment in my branch , try your things , then we'll compare/test/merge ideas ?
I love to git reset --hard HEAD~1 now on my local branch ( mwah ah ah ah )

thanks to : http://stackoverflow.com/questions/927358/how-do-you-undo-the-last-commit
"
Undoing a commit is a little scary if you don't know how it works. But it's actually amazingly ezee if you do understand.

Say you have this, where C is your HEAD and (F) is the state of your files.

   (F)
A-B-C
.......↑
  master
You want to nuke commit C and never see it again. You do this:

git reset --hard HEAD~1
The result is:

 (F)
A-B
 ...↑
master
Now B is the HEAD. Because you used --hard, your files are reset to their state at commit B.
....
...
"


@lucasart
I don't think Mutex locks are fine.  See
http://tests.stockfishchess.org/tests/view/56286fca0ebc5964d3445e36
Can you please point me to where it was established that using the i < 10000 is useless?


Sorry, creo que Paloma y yo trabajamos justo en lo mismo. Acepté mi origin en casi todos los conflictos ya que reescribí varias cosas pensando en la intensión original.


it should be also kotlin-maven-plugin applied. See https://kotlinlang.org/docs/reference/using-maven.html


That is removed in later commit xD


SwitchResX 4.5.2 is installed but I am not sure if I am using it correctly. What should I do now?
Should I change the "594,00 Mhz"? or go directly to vertical scan rate and change the 30 to  60 Hz?
Well, I did that and cmd+s to save the setting. Then it showed "reboot is necessary"...
Did reboot but this message came up right after reboot.
![screen shot 2015-11-18 at 14 09 52](https://cloud.githubusercontent.com/assets/13314439/11240894/e1c1f250-8dfe-11e5-8c6b-e3ea799055ae.png)


Student？什么鬼？


@lgoldstein: I think this is also required.


I did the same last night in the 'new connection approach' branch.


Generally on Windows this will generate a Visual Studio solution (if one has VS installed), which can be built on command line using the `msbuild` tool (+ appropriate flags). `Clang++` doesn't build Windows executables very well, so it's better to avoid it there. Alternatively if one wants to use makefiles, one can install MinGW and pass `-G MinGW Makefiles` to CMake and use `mingw32-make` in place of `make`, or install Cygwin to use `-G Unix Makefiles` and `make` (though I wouldn't really recommend that path).

Visual Studio (like Xcode and some others) generator in CMake is a "multi-generator", so the `-DCMAKE_BUILD_TYPE=` command line flag doesn't apply when when generating VS solutions, but CMake will generate all build variants at once, and one uses the VS Debug/Release dropdown to choose which version to build.


把这个函数放到一个类里面，程序里面除了入口，不要有单独的函数。


> * We must convert an io.EOF received from the underlying Reader into an
io.ErrUnexpectedEOF. The only valid EOF condition is when the decompressor tells
us so with a BROTLI_RESULT_SUCCESS code.

So, we're assuming the underlying Reader does the following:

  * reads `0 <= x < len(buffer)` bytes, nil error
  * reads `< len(buffer)`, nil error, internally marks eof
  * if called again, reads 0, returns io.EOF as error

And:

  * if the stream is valid, we'll get C.BROTLI_RESULT_SUCCESS from the C decoder before we even have a chance to get `io.EOF` from the underlying Reader
  * if it's invalid, we won't get C.BROTLI_RESULT_SUCCESS, will get `io.EOF`, and convert it to `io.ErrUnexpectedEof` since clearly the stream is incomplete

Must seem obvious in retrospect, just making sure I'm understanding this correctly! :baby_chick:


把直接访问变量的地方统统改写成成员函数


Yeah, the empty spot will be a zero authorizationResource, because we didn't received any for the domain. Maybe add `if challenge, ok := responses[domain]; ok` to prevent from inserting it into the challenges array. Also there will be an error in failures array, which will stop further processing in ObtainSANCertificate.


Ок, согласен.


else не обязательно писать


这里有必要使用数组吗？


That sequence is "backward tab" (`kcbt` in terminfo), produced by shift-tab.


Please commit on `develop` next time :confused:


so, same pattern as writer. :+1:


Значит Assert.


is it a best practice to name return parameters ? haven't encountered that in golang code before


@MahalingamShanmugam
Thanks for your contribution! I didn't update the repository yet due some time issues, but I'll put your suggestion! Do you want to make a pull request?


Thanks for fixing!


so this is what messed up vijay's notifications.
@nerandell

    >>> import vyked
    Traceback (most recent call last):
      File "<stdin>", line 1, in <module>
      File "/opt/vyked/vyked/__init__.py", line 6, in <module>
        from .host import Host  # noqa
      File "/opt/vyked/vyked/host.py", line 10, in <module>
        from .bus import TCPBus, PubSubBus
      File "/opt/vyked/vyked/bus.py", line 13, in <module>
        from .services import TCPServiceClient, HTTPServiceClient
      File "/opt/vyked/vyked/services.py", line 15, in <module>
        from .utils.stats import Aggregator, Stats
      File "/opt/vyked/vyked/utils/stats.py", line 8, in <module>
        class Stats:
      File "/opt/vyked/vyked/utils/stats.py", line 9, in Stats
        hostname = socket.gethostbyname(socket.gethostname())
    socket.gaierror: [Errno -2] Name or service not known
    >>> import socket
    >>> socket.gethostname()
    '52a2b0df7373'

shall we revert it?


Control.Game？什么意思？换成game.start()不久好多了么。


怎么还有这种东西？


This seems a bit early-generalized. I'd put it as:
```
// verifyClickPath ensures file paths are absolute and relative to local content.
func verifyClickPath(path string) (string, err error)
```

But then if this is all going away, doesn't matter much.


Yes, I wanted to move it out of getChallenges as ObtainCertificates also uses this function and it continues even if some domains failed.


I agree with you (I think it's okay to use a directory that already exists, especially since we have the overwrite detection).


typo: substitute


alost不是一个单词，需要分隔开


`explicit` keyword here: `explicit GL(const Win& win)`


I'm not sure if you're aware of that but the panel example is based on the *report* event.


The established upstream Go convention is that error variables are ErrFoo, but error types are FooError.

Not worth fixing if this is all going away.


wait, is that related to #14 ? with a pointer to BrotliState instead of 'embedding' the BrotliState struct in the BrotliReader struct, is the Go GC still going to explore them?


参数名字没有意义，别人吊用这种函数的时候就不知所措了。如果你的类作为一个闭源的库交给别人使用，谁会用？


Metía el índice en el hasher (aunque no tuviese sentido semánticamente) para ahorrarme un map.


Well , now all  i see  :

_ Configurator is a stable tool to create directories and files
_ Settings is a stable tool to read/write in JSOn files and in memory .

Let's first code new funks in Configurator to create  ( and perhaps delete also ) new folders ( like Presets ) and update the tree ?


`node_modules` should never be added to version control


Will this correctly replace the existing plugin.xml and not add a second copy of it?


getShieldname应该是getShieldName，注意单词分隔


Makes total sense, thanks for the quick response!

Sent from my phone
On Nov 18, 2015 02:52, "Guillaume Plique" <notifications@github.com> wrote:

> Hello @panozzaj <https://github.com/panozzaj>. The problem here is that I
> wanted to finalize the react-blessed version of the project before
> linking towards it because otherwise it could mislead people.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Yomguithereal/react-blessed/commit/7cbbe5a4d1a8dd477e82205d7471980e7a71c151#commitcomment-14464674>
> .
>


Not sure about context here, but should this be a panic?  Doesn't look like the error message is oriented towards users.


May also go away given the Open above.


全く必要ない記述でした！
消します！


I'm just created a pull request.


Надо все переносить в отдельный py файл


Ja, s'projekt mues au übereinstimme, nur dänn wirds aggregiert. Aber das isch ja nur no en zuesätzlichi if-bedingig...
Ja, leider hannis nöd usegfunde...


Zamiast "KONIEC", zróbmy klawisz "WYJDŹ". Ogólnie co wysłałeś mi się podoba, ja bym został przy tym.


develop (axelstudios) - i386-Windows-7-VisualStudio-12: OK (2335 of 2370 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.52%25-yellow.svg)


Fixes issue #406 I'd say


Can confirm /lib/ works here.


It will be better to add `length` method which basically return `playlist` length and check it in `playCurrent` of `right-menu.js`


I see, my change with additional condition should work for ObtainCertificates as well.


@ahocevar könnten sie es vielleicht einmal in ihrem browser testen? lg g04


To jest tylko pierwsze okno. Trzeba by zaprojektować jak mają wyglądać
każde z trzech następnych okien


I believe that on Emscripten/Android/iOS, this will go about creating a GLES 2 context, but on native, it would be very much recommended to create a GL3.0 core context (or newer), which I've found to be a good match with GLES2.


Wyślę swój pomysł jutro do południa


Stu has commented that this commit causes a bug whereby the drag isn't 'released' if the cursor is not on the `this.$('.confidenceSlider-item-handle')` element. We'll most likely need to revisit/revert this commit.

Tested in Firefox on Mac.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=15)


Sure I can make a comment.
What purpose would `#define FOO (TEE_NUM_PARAMS * 2)` fill? It's only used here.
The `x * 2` thing is only done when looping n as `for (n = 0; n < TEE_NUM_PARAMS; n++)` but then with `n` and not as a limit for `n`.


Correction : Settings create the file , folders are for configurator .
example in code  :
>bool Settings::writeFile(APPTYPE type, QList<SettingsObject *> sections)// io ops ...
{
   //Works with JTBConfig
   if(type==plugin)
        fileDir = Configurator::getInstance()->getPluginDirPath();
    QDir dir(fileDir);//homepath
    dir.mkpath(fileDir);
    //qWarning(jtConfigurator) << "SETTINGS WRITE JSON IN:" <<fileDir;
    QString absolutePath = dir.absoluteFilePath(fileName);
    QFile file(absolutePath);
    if(file.open(QIODevice::WriteOnly)){
        QJsonObject root;
        //write user name
        root["userName"] = this->lastUserName;
        //write translate locale
        root["translation"] = this->translation;

>        root["intervalProgressShape"] = this->ninjamIntervalProgressShape;

>        //write sections
        foreach (SettingsObject* so, sections) {
            QJsonObject sectionObject;
            so->write(sectionObject);
            root[so->getName()] = sectionObject;
        }
        QJsonDocument doc(root);
        file.write(doc.toJson());
        return true;
    }
    else{
        qCritical() << file.errorString();
    }
    return false;
}


Na razie kolory chyba nie są istotne. Nawet nie wiem jak można je zmieniać.
Najważniejszy jest nawet nie tyle układ okienek co informacja jakie te
okienka mają być żeby dostosować funkcje tej całej apki


Actually, it's important to specify the private IP because we will be passing it in the docker-compose later on to be used by the interlock service and 0.0.0.0 isn't routable by that container.


Yeah this is probably a better way of doing it:
https://github.com/adaptlearning/adapt-contrib-slider/blob/ABU-1112/js/adapt-contrib-slider.js#L208-L214


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=16)


I think Drift, PosHold and RTL also need the failsafe.gps_glitch check added to their _init() functions.


together with this: https://github.com/adaptlearning/adapt-contrib-slider/blob/ABU-1112/js/adapt-contrib-slider.js#L160-L164


It will discussed -> It will discuss


https://github.com/NotGGhost/jDiscord/blob/master/src/main/java/me/itsghost/jdiscord/internal/impl/GroupImpl.java#L40

Was updated but that wasn't


so #14 is unaffected by this, I'm now realizing @dsnet added it probably so that it can be set to nil and avoid duplicate Cleanup calls ?


These inner classes for lambdas along with qualified class names really obfuscate the code. I would rather just do the plain Java way. There is no real need to use lambdas. Also could we keep the open pull request open for reviews next time?


ошибся, запрос должен быть
SELECT v.id as variant_id, v.product_id FROM __variants v, __products p WHERE v.sku=? AND v.product_id = p.id LIMIT 1


IMO This patch does too much. Please simplify it!

* Why updating the imports which a other formatter settings?
* Why adding +@SuppressWarnings({"rawtypes", "unchecked"}) ?
* There is a full diff of the *.xml. Do not change the EOL-character, so that the diff shows only the real changes.

I guess the changes in genfiles.properties and project.xml will be enough.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=17)


i have been looking for such a solution, thanks.


Thanks, I'll fix.


I'd say we're better off with an empty default app name than "shiny". I realize that this could cause the UI to come up indicating an invalid app name, but perhaps you could tweak that heuristic to not show as invalid when the name is empty (since that's obviously invalid and will be caught by the dialog validation step anyway).


@nfheredia excelente man


Freeing retrieved input here.


// FIXME: Move this to another class as there is a lot more we should do here


Any client that calls the API


Now imagine that funk update  :
bool Settings::writeFile(APPTYPE type, QList sections, QDir where)// io ops ...
{
//same code but we use
bool YouCanWriteHere=Configurator::getInstance()->CheckDIr(where) ;
//then just write in the folder
if(YouCanWriteHere) { //create if don't exist or write as usual } else return false ;
.....
return true
}


Why are these lines commented? Why not just remove them?


This file doesn't need to be in top level directory anymore. The file is moved to src/dist to make it usable by application plugin.


А что такое степы?


typo m_bResizeRequ**i**red

same below


Hi @poznet seems like [this PR](https://github.com/DarioSwain/DSReCaptchaBundle/pull/12) is fixed this issue.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=18)


Beware your indentation in collection.js: `var collectionItemTemplate = …` is a string spanning multiple lines, but on line 15, you're done with building that string, so the code after that shouldn't be indented further than `var collectionItemTemplate` is—meaning you should remove the couple of spaces from line 16 to line 25.


Deze URL moet naar een externe config file gaan. Want straks zal de analysisEngine niet op alle smoothwall servers gaan draaien.


are you sure it should not be `bundle/floobits-vim` ?


Why did you specify styling inside the HTML template? Usually it goes into a CSS file and it's easier to overridde those declarations.


I understand the process but what I'm referring to is that the collocation is wrong.


* TODO: rewrite this as it is doing way too much and is very messy now.


This commit is being reviewed as a part of review issue #120.


Request is not being imported....


ack


That would be quite inconvenient as the interesting fname and lineno isn't from where this function is called, that's from where the function calling this function was called.


Class UpdateGitMirror is missing a docblock.


Brother's Barbu solo para professional players.


Sphinx does not complain, I actually added it to try to remedy another doc issue, not quite sure its needed. We could remove all of them i suppose.


@duythien I'd be happy to do one for less than the offered rate, however not a fan of 99design much, it's too commercial for my tastes. Let me know if you think we can work together. Here are some samples:
https://dribbble.com/elioqoshi


This file is not needed anymore here. It is already there under src/dist so that it can be used by application plugin and be available in the distribution archive.


Do we not want to list `ipywidgets` as one of our dependencies, so that pip installs it automatically?


Do not walk the files, use a pattern to directly get what is needed.


Hi Marcello,

Ich habe
1234 => {
     Set(CHANNEL(_video)=off)
     DIAL(SCCP/1234, 20);
}

Probiert aber das geht leider nicht so ganz.

Der current 'sccp_asterisk_pbx_fktChannelWrite' handler (outgoing device), bekommt als argument string '_video' und nicht 'video'. Der variable wird nicht erkannt oder weiter geleited an der incoming extension )1234 (warend DIAL). Ich kann der match dort anpassen damit wir auch _video verstehen aber dann wird es noch immer nicht weiter geleitet, also das bringt nichts.

Also anscheinend macht CHANNEL() da nicht mit in der '_' und '__' variable sache.

BTW: Ich kann schon mal anfanger der dialstring erweiterung (video=...) zu entfernen (oder).

Gruss,

Diederik

On 17-11-15 18:32, marcelloceschia wrote:
>
> why do we use two ways to do that? What version wins if both are set.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/marcelloceschia/chan-sccp-b/commit/1000dd2cbfe04a97e4e26927bb8129703a8f8912#commitcomment-14450306>.
>


Fixed it in fdd8775


// FIXME: Delete tar file if it exists


exit 0 # FIXME: Not sure why I need this, otherwise it fails


OK, I'll remove it.


a


nice!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5692](https://teamcity.mesosphere.io/viewLog.html?buildId=77451&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:42


> s/version/gvString/, as above

`ObjectVersionAndKind` will be fixed later.  Why bother?


Interesting feature but it will require (quite some?) work to support that in the compiler.


> where were we calling parse with internal versions? should we be constructing GroupVersion{} there instead?

The object metadata functions used by resource builder need to be fixed.  This moves us forward.


that is wrong!


iFrame Added


I don't think they obfuscate the code, but it is noisy (as anonymous classes are).  If you prefer I will create a PR request next time.  It was easiest to translate the lambda directly.


NO IT IS NOT!


that's awesome!!


shut up!


I agree about your point with being a feature, @mariosky, and precisely, I think it would be a lot clear if we include it.


That doesn't look very useful (as is).


blame @jurgenvinju if I remember correctly ;)


this is lvl error


The mimetypes marked with "x" are third-party. They add support for some window managers.


s/every work/ever work/


OK. Should I add anything other than the MS copyright notice there? I think it would look weird if the copyright element only contained information about code copied from elsewhere and not the main software.


Thanx, seems good now, merging


If we want to go down that route (i.e. using predefined schemas) We should really look at an ORM library like Mongoose.(I generally despise ORMs but I could get over it if you think it's the way to go.)

I **really** like the idea of  abstracting the nastier database code away into promises and generators though and I think what you have here is perfect.

As a side note I've been using the async library should I switch to bluebird? Does it provide better/more functionality?

As a side side note, we should probably get in the habit of creating issues for whatever we are planning on working on / changing that way we know ahead of time because I now will have to rewrite large chunks of what I'm working on to fit your ( much much better ) model.


He puesto que uso el repositorio del proyecto, para no tener que hacerlo en el de las empresas también y así dedicarme a la entrega del hito 2 para que me diese tiempo a entregar todo.

En el readme del proyecto del commit concreto que indico en el ejercicio ya estaba puesto el badge con enlace al repositorio en travis: https://github.com/segura2010/CC-Proyecto-OpenSecureChat/blob/c6ce03b190f030e8b5d03b04ba86f51308682e91/readme.md

Es a eso a lo que se refiere?


Yeah, I agree. I read somewhere that the path should be absolute so I changed it. Now after reading the standard I found that to be inaccurate.


deleteAll() 을 보면 익명 내부 클래스 (Inner Class) 를 이용함


Hi @alexeyegorov, there are no binaries for 1.0-SNAPSHOT. But you can easily build it yourself by simply cloning the flink repository and then call `mvn clean package -DskipTests` in the root directory. If you then go to `build-target` you end up in the folder which contains the binary distribution of Flink. Thus, copying this folder to your cluster should do the job.


@mihai-stancu send a PR with the corrected return type


## 토비의 스프링 3   ~ P.250

> Template & CallBack : 변하는 것과 변하지 않는 것(Template) 을 분리. 익명 내부클래스로 CallBack


Actually, just the method name should be corrected


ionic 直接在controller调用发生错误 Wechat is not defined??

  .controller('LoginCtrl', function($scope) {
     try {
       Wechat.isInstalled(function (installed) {
         alert("Wechat installed: " + (installed ? "Yes" : "No"));
       });
     }
    catch(err)
    {
      alert(err);
    }
}


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5693](https://teamcity.mesosphere.io/viewLog.html?buildId=77452&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:47


Fair enough.  It probably didn't matter when we are smaller, but will do so now.


On line 33 you are missing a semicolon, other then that it looks good. :+1:

You can also remove line 46 in lecture.factory.js when you fix it. It is commented out code, you will understand it when you see it.


That's amazing. :boom: You're absolutely right! Maybe `footbits` could be used for a company name ;-)


I really think this is better than the fj version:
```
classes = com.google.common.reflect.ClassPath.from(Thread.currentThread().getContextClassLoader())
            .getTopLevelClassesRecursive(packageName);
for (com.google.common.reflect.ClassPath.ClassInfo clsInfo: classes) {
  Class<?> cls = clsInfo.load();
  if (!cls.isSynthetic() && !cls.isAnonymousClass() && !cls.isLocalClass())
    classes.add(cls);
}
```
> If you prefer I will create a PR request next time.

Yes, please. That way we can ensure that we don't have conflicting changes. For example, we don't really need types.properties top level directory anymore.


@jdillard
all the NOT(font-awesome) icons have been removed by removing that import.
there are still a lot of the glyphicons in use.this causes issue's.
https://forum.pfsense.org/index.php?topic=102601.0
https://forum.pfsense.org/index.php?topic=102617.0


split this line for <= 80 chars?


Der Logger wurde mir commit 2539677e5f8d793780722a41442f7bd1ecc08357 entfernt da nun die bereites vorhande Exceptionbehandlung in der Protocoll-Klasse genutzt wird


Does both /types.properties and /types2.properties need to be removed?


@Hguimaraes
Yes . further changes , I will do it through pull request


We could even make the db-utils return a "mock" db object for running tests with. i.e.

```
const db = require('db-utils').newMockDB();

db.getCardByName('magic', 'lightning bolt');
```

Will still return an object. This makes our code easier to test. I still have concerns about how we test our db-utils / other database code and the work I've been doing on add-cards is relevant to this discussion.

https://github.com/ChasingLogic/cardinal/blob/master/database/add-cards.js
https://github.com/ChasingLogic/cardinal/blob/master/database/download-cards.js


That was at the beginning of the semester to help get set up for the project.

Sent from Outlook<http://aka.ms/Ox5hz3>

On Wed, Nov 18, 2015 at 12:29 AM -0800, "James Little" <notifications@github.com<mailto:notifications@github.com>> wrote:

Jason, what the hell is this for?

-
Reply to this email directly or view it on GitHub<https://github.com/patrickbraud/CapstoneProject/commit/2fd3c71c0bbad05a5fb6d70db894caa38cc80633#commitcomment-14465188>.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5694](https://teamcity.mesosphere.io/viewLog.html?buildId=77453&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:56


I am still a bit suspicious about the "local" part in the path, I can't find the same pattern in any .config/ subdirectory. Why don't use just ~/.config/haskell-vim-now/vimrc.local, ~/.config/haskell-vim-now/plugins.local etc? The "local" is part of the file name and I can't see the reason for the duplicity.

I like the rest, definitely an improvement over my previous pullrequest.


Yes you're right, good catch! Resolved in e992bf8


Yes, both can be removed.

Thanks!

On Wed, Nov 18, 2015 at 7:55 AM, Mark Perry <notifications@github.com>
wrote:

> Does both /types.properties and /types2.properties need to be removed?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Frege/frege-native-gen/commit/1b8040a57b3608e8458784fd64ba79a2bbe60c3c#commitcomment-14470898>
> .
>

--
Regards,
Marimuthu Madasamy


Resolved in e992bf8


I know @paulkkint but without this Michael is stuck. He has two functions with more than 300 overloaded alternatives where the third and second argument are most distinguishing. The annotation can be ignored so no harm done to the compiler and let's see how the code runs in compiled mode. That is a major effort too because I've seen a large number of static errors which are in need of quick fix functionality in the IDE


Agreed.


I ran into a similar issue, but array seems like the wrong way of doing this.
These are name:value pairs, so it would make more sense to use a map.

```
    if (typeof val !== 'boolean')
      if (typeof val !== 'object') {
        args.push(quote(val))
      } else {
        Object.keys(val).forEach(function(name) {
          args.push(quote(name));
          args.push(quote(val[name]));
        })
      }
```

Note - te


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5695](https://teamcity.mesosphere.io/viewLog.html?buildId=77454&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:56


why don't you copy the other libs to VideoPlayer folder? dvdplayer life time is near the end


tag?


Having this:
```
Style/AndOr:
  EnforcedStyle: conditionals
```
in rubocop config should do the thing
https://github.com/bbatsov/rubocop/issues/2438#issuecomment-157694501


Ok, I understand. Let's see how this evolves. I am curious how the compiler would handle the current code.


I think load_error = 0 when UNIT_MASKED that's the reason why I trapped this special case.

Also I handled UNIT_NOT_FOUND separately because I prefered returning this error instead of the more generic FILE_NOT_FOUND one.


No, not yet.


@msteindorfer I just spotted a bug in line 101 of concrete pattern disp function..


@poettering :

I think load_error = 0 when UNIT_MASKED that's the reason why I trapped this special case.

Also I handled UNIT_NOT_FOUND separately because I prefered returning this error instead of the more generic FILE_NOT_FOUND one.


Maybe rename to RelRef?


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=21)


I'll try that now and push on success.


Why not _fslRelRef or even (gasp!) _fslRelativeRef?


"addded temporary gamemanager prefab" was meant to say "modified onPortalEnter to use GameManager.Instance instead of gameObject.find"


@OskarStark Can you fix this issue ? Thanks ;)


So late this answer, really sorry.... Use "Ahora" for "Now" its like "Rigth Now", and use "Hoy" for "Today" say something like "Im gonna tell you year, month, date, hour, minutos and seconds", because we are talking about dates, no hours, or minutes, or time related things... And again, sorry... Im late!


pay attention to the order


I'd personally remove `layerId` if is not being used (I don't think it is).


Are you suggesting that we should have two `<credit>` elements - one in LOS (of literal type) and one in LOI (of decimal type)? Something like this?

LOS:
```xml
<credit>
    <scheme>ects</scheme>
    <value>from 3 to 6 credits, depending on a degree and academic term</value>
</credit>

LOI:

<credit>
    <scheme>ects</scheme>
    <value>6</value>
</credit>

I'm not sure what would be the point of having a literal description: Since it would contain human-readable only, we could not import it - there is no such field in Polish database.


LGTM


Accidentally left out from the commit message that also started to use Waterline ORM


The IDE will autowatch file changes


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20569/testReport/) for this commit**


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=22)


Yep, I changed that in-world before putting it in the dispenser though. :see_no_evil:

Going to fix it here as well when I change news and version for a "ship". I wished we had a less obnoxious way to signal where we have boxed versions built at which point in the timeline.

Each time I do a "build" or "ship" commit I feel a bit silly but it turned out to be a useful method for others to find their way in the history.


TODO: FORMAT


@jurgenvinju, what kind of error? We didn't touch line 101. Thus is it an older bug?


`gradlew run` fails when types.properties is removed.


@tarzan I've missed this change, but I am getting a security warning about it right now. Are you sure this does not pose any threats?


It would be interesting to test that "non-existent user" and "bad password for existent user" are rejected with the same error message.


NOTE: **victor.hernandez it's me D:**