во первых у тебя вызывается неправильный `delete`! твой вариант это если вызывался `new []` -- т.е. аллоцировался массив, что явно не твой случай...
но anyway -- ты удаляешь только головы и хвосты -- середина списка не удалется! (это называется утечка памяти: т.е. тот неловкий момент, кода выделенная память попросту теряется/забывается и во время работы твоя программа все жрет и жрет память пока ее не отстрелит OOM killer -- специальная функция в ядре ОС убивающая процессы которые жрут всю доступную памть)


Yep, The memory that this code was trying to steal was not owned by the buffer, so NULL was being returned, leading to a crash.


Should be the logger used instead ouf sout ??


thanks.


Thx !
I love that poetry :
" if(Joy)
    {
     Joy->updateInput();
 ... "
ah ah ah !


Getting this now:  (did a Git Pull after it wouldn't work, still busted)

![capture](https://cloud.githubusercontent.com/assets/10908173/10996957/30079098-8457-11e5-8bcb-aa62b9c8e621.PNG)


No not anymore. At first I started there for consistency if I needed it, then it became unnecessary. I'll update to remove it.


It would be better to refer to the files explicitly by their name. If some other `.in`, `.out` files exist in the same folder, it might mess up the solution. Besides, `.out` file is not expected to exist already — we should create/overwrite it :)


instead of zero, maybe we should not touch size if memdup fails.


I would check for SOL_BUFFER_FLAGS_NO_FREE instead of SOL_BUFFER_FLAGS_MEMORY_NOT_OWNED. If SOL_BUFFER_FLAGS_NO_FREE is set and SOL_BUFFER_FLAGS_FIXED_CAPACITY is not, we will still return the pointer that may be incorrectly freed.
Afaik, no one is using it, but I think that if the flag is defined, we need to care about it.


We just wanted to create a easier API, so the caller do not have to check by himself/herself if the memory is owned or not.


The same apply for other points where SOL_BUFFER_FLAGS_MEMORY_NOT_OWNED is used


I don't really understand. 'remote-ip' is the PC that run the simulator, ScalaHDL have to send message to simulator first, so need the ip.


Hello,

If I understand correctly, you can't use VRRP virtual Mac with VMware ? Is it related to http://www.ogris.de/docs/vmware-server-vrrp.html ?

Regards,
Arnaud A.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.746](http://teamcity.monogame.net/viewLog.html?buildId=11081&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@mjfrey Here are the latest changes. Please notice that I've added `EnrollmentCode` model in order app.

I have some questions regarding that though.

1) Are you sure we need ManyToMany relationship between `EnrollmentCode` and `Voucher`? I thought that an Enrollment Code could be associated with multiple vouchers, but that a voucher would always belong to a single Enrollment Code.

2) What would be the final use of this model? For now, I only see this as an association link between a voucher and an order line. If that's the only purpose of the `EnrollmentCode`, wouldn't it be more natural for a voucher to have an association field in its model and not the entire new model that would contain the records of this association? I believe that we did this for a relationship between a range and a catalogue.


Java 8 Streaming API ?


Thank you so much :)


Realmente te parece mas copada esta forma de magia? Lo del or esta bien, pero guardar una función, después meter identity por ahí, no me convence.
Además porque anda? si en una devolves una función (cambio de estado) y en la otra ya la devolvés aplicada? Hay algo raro acá


Use lambda


Are you sure about backticks?


Use Lambda


A test?


Remove empty line


Remove commented out code


I am able to run it only on Windows and Ubuntu Linux, so far. I dont have a Mac, so I am unable test for that platform. I'm hoping that someone can jump in for that. On Windows, I'm using git bash and on the Linux side vanilla bash. I don't forsee any issues for Mac OSX or ZSH.


Reproducible only on injections, too lazy to test it


Java 8 Streaming API paralell ?


nope, don't know why I used it, feel free to change


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3936](https://teamcity.mesosphere.io/viewLog.html?buildId=69467&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:05:05


Purpose of this Method ?????


use lambda


видя этот цикл столько раз, написать для него отдельную функцию должно быть естественным желанием...


remove empty line


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20235/testReport/) for this commit**


Java 8 Streaming API parallel


have i tried it...yes...cant say I've had good experiences with it


If buffer has memory_not_owned flag, memory will be duplicated here, and then duplicated again at set_string_option. Why passing using buf.data to set_string_option and remove the free from there?


go on. I tested it, maybe put "no credit + actual credit to error dialog" but, status bur is ok, If I have time, I made it all in erro dialog.


Esta función con tres funciones adentro, termino quedando mas confusa, preferiría repetir la palabra energiaAtaque y que el 3* y el 2* este en daniosBase, entiendo como funciona y se que te encanta usar aplicación parcial con 2* y 3* pero nose mepa que confunde.


Remove commented out line


Use Java 8 streaming API


remove whitespace


Estas SobrePatternMatcheando juan stap ajaja


Is there a typo here? Should this be `@onTypeMessage`?


remove commented code


Remove empty line


Same comment about memory duplication here


Sos un Hdp JAJAJAJ


Use Java 8 Streaming API


Тут выравниваете по скобке, а [тут](https://github.com/doubledare704/djangt/commit/3867d0b88c5ac25f5b24b84b164f8bdf7c2f70ce#diff-1715904dcbe6ec9609e465428bcff10bR20) и выше по блокам


@chrisdpeters My pleasure. Sorry, I didn't have time to create a proper Pull Request.
I'm planning to continue contributing to this gem. Great Work!


если ты в своем коде добавишь такую вот перегрузку:

    std::ostream& operator<<(std::ostream& os, const poly* const node)
    {
        // тут выводим в os чего хотим из ноды...
        ...
        return os;
    }

то можно будет писать так:

    std::cout << "Created X-pression:\n" << head << std::endl;


m unable to use with cygwin n alternate method i cant understand, will you plz guide me personally ..
thank youu...


Check the whitelines here


Please modify to :
```
if ( NOT ${CMAKE_SYSTEM_NAME} MATCHES "Windows")
  add_definitions(-DOS_POSIX)
else()
  add_definitions(-DWIN_NATIVE)
endif()
```


Possible testing working lua version with luabind, see here:
https://github.com/Project-OSRM/osrm-backend/pull/1185
https://github.com/Project-OSRM/osrm-backend/issues/1179


What do you think of this approach: https://gist.github.com/aynik/f04b4388ce6d08326bc2

I've used a smaller module than `jsonschema` in order to minimize size when bundling for browsers. I tried to reimplement buyer_seller.js in a more declarative way, referencing shared functionality as a third type `party`. I think we should delegate as much as we can to schema-type validation, and pack the rest in a custom method, these schemas will come quite handy in the future.


@mrietveld we cannot use it here as TaskSummaryQueryBuilder is not a remote object so this method will not work for EJB remote. That's why having simple methods to get tasks by variables was added. Same thing is for process variables so I opt to revert to the removed methods from this interface. Wdyt?


please remove 'ls' line


Well it is completely okay for me but:
- Are you sure github doesn't discard old files?
- Our IT Risk dep. won't be amused ;)


Works!


memory here is also duplicated without need


@Synchro May I ask why was this done? Since Haraka is a single-process application, why did you switch towards an Phusion baseimage, init-based approach? It seems to go against the best practices of Docker.


please create an issue for this - it needs to be fixed in a future version!


Added blocks to the canavs.


если переписать `sum` как показано выше, то не будет вот этого уродства... и все станет сильно проще: не нужна будет третья переменная (кстати имена с цифрами это уродство! может лучше `p_sum` и `q_sum`??), и инициализацию переменных можно будет сделать сразу!
и кстати, глядя сюда видно, что для твоего случая `sum` вообще не нужен первый параметр -- можно смело сделать (допустить) начальное значение нулем...


really we should change eris-abi to have log levels so the default won't print the message!


### New Feature

Actually previously unmentioned feature.

[Datalayer Events](https://github.com/happner/happner/blob/ef283ce771d3175a76ff58675c493ed872cbce86/docs/datalayer.md#datalayer-events)

Components can know when endpoints attach and detatch


@hillelcoren I see an anniversary coming... :)


Please IGNORE this pull request!
I have some problems with my repository and here are some disturbed files.


Two bugs I haven't fixed. When I win it is updating correctly the number of wins, but when i lose it is not.
Flash messages are not showing anymore.
After losing money, everything resets to 1000 and breaks.
No card images.


I wonder if could make the regex shorter here so that it applies to all versions, i.e. by removing the 'at line xyz'. What do you think?


это лучше назвать `is_equal` и возвращать она должна `bool` (да/нет)... а вот что делать, когда они равны, это выходит за рамки ответственности данной функции... -- ее дело просто вернуть "да" или "нет" (что с этим делать, не ее дело! -- это лучше перенести в `main`).


Afhv. er `name="land"` þegar verið er að velja kyn ?


I would use memchr here. But I am not sure what is better.


Dachte, ich hätte davon schon alles eliminiert. Das liegt, wenn ich nicht falsch liege, daran, dass wir oft etwas überschwenglich mit `\newunit`bzw. `\setunit{}` (bes. ohne Asterisk) umgehen. Manchmal kumulieren die "unit"-Einträge bei leeren \print...-Befehlen (vor allem, wenn auf ein bibmacro zugegriffen wird). Ich kümmer mich darum.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.746](http://teamcity.monogame.net/viewLog.html?buildId=11081&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 541, ignored: 6 Build time: 00:20:32


`video.category.name` returns a string, there isn't a need to interpolate that. you can also use short hand named routes. instead of `category_path(video.category)` - just `video.category`


Thank you @allanino it works perfectly now. It’s the most useful extension ever!


Can you please remove this comment as it's no longer relevant, following your changes?


I would rather use `= image_tag @video.large_cover_url` than the ugly %img tag :)


There isn't a need to interpolate string here.


we should add `brew install gmp` for mac and `sudo apt-get install libgmp3-dev` for ubuntu


@przemas75 If you submit a PR to `config.mk.in` and/or `Makefile` I'd consider it.


Using `create!` would be better as throws an exception when the record is not valid. Standard `create` does not do that. and in `seeds.rb` you want to see it because you run it from command line.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20237/testReport/) for this commit**


I think it is better this way. forget about it


good point. will bring this up


thanks!


I don't think memchr is good here, otherwise I would have to check all !(alpha num) to check if they are present.


remove whiteline


Great, I love it! :+1:


I fork this project (jrjang2/lab), then git pull, it say "already up-to-date", not a "conflict ".
I delete the lab on my computer before and git clone again.
Does it result in the consequence?
So do I need to delete the github's repository and do it again?
Thank you.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20238/testReport/) for this commit**


This should just be `$HOME` not `\\$HOME`. Also, the comment on line one can be deleted too.


This is great, not sure why we didn't think of this before. See my note.


Mig minnir að þegar ég hafði `type="submit"` fékk ég eitthvað bug sem ég gat lagað með því að setja `type="button"`. Sjáum bara hvort það bug komi aftur, ef ekki skiljum við þetta bara eftir svona


@ThadT Output path should match other relative output paths.


while we're up here we could grab jq for everyone too. tho I'd rather just say "you're expected to install gmp and jq, and not deal with all the cross platform installs in script. or have an additional script for them. would be much cleaner


Time flies...


All set to go. I disabled SIP before I installed the WebDriver-346.03.03f02. Do I have to anything to do re-disable it or it is just set?

kextstat | grep nvidia
  111    2 0xffffff7f82906000 0x2d6000   0x2d6000   com.nvidia.web.NVDAResmanWeb (10.0.7) 53A7D683-CD5C-3EDD-A58E-5BB7FF28BDE9 <108 95 80 12 7 5 4 3 1>
  112    0 0xffffff7f82bdc000 0x1fd000   0x1fd000   com.nvidia.web.NVDAGM100HalWeb (10.0.7) 1C1114D7-6B7D-370C-BDDC-DBFA42222D6A <111 12 4 3>
  114    0 0xffffff7f82e44000 0x94000    0x94000    com.nvidia.web.GeForceWeb (10.0.7) 5B05573A-E155-3BD2-B763-928AE33471EC <113 111 95 80 12 7 5 4 3 1>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3937](https://teamcity.mesosphere.io/viewLog.html?buildId=69487&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:26


whiteline


if we find a '%' at the end of the string, shouldn't we fail? Or % followed by a non number?


Rather than created nested `if` blocks for checking the Puppet version, could you please this with a switch and case statements?


please delete dead code


несколько общих советов:
* делай функции делающие простые и понятные (из названия) действия... функции делающие слишком много, сложны в понимании и отладке! в твоем коде `link_node` или `equal` -- примеры функций "делающих слишком много"
* у функций есть возвращаемое значение! если функиця должна чего-то вернуть используй это! (а не ссылочные входные/выходные параметры -- это плохой код и вообще bad design). тем более что у нас теперь есть C++11 (и даже С++14), где есть семантика перемещения!
* если ты копируешь кусок кода и меняешь в нем "чуть-чуть" -- это называется **копипакостничество** (за это надо вырывать руки)... это значит, что самое время выделить копируемый функционал в отдельную функцию и вызывать ее...


Nope, because it can be just the "%" sign.


Tu w skrypcie warto zrobić define dla stałej o wartości 16, żeby nie posługiwać się wartością, a nazwą z define-a.


I also forgot to do isxdigit(value.data[i+2])


@drmarkwslater ah it appears you're correct. I'm surprised I've not seen this in lhcb testing... I'll see if it's reproducible there and put in this fix unless you've beaten me to it :)
Sorry for not spotting this before!


Is it possible to create 1 public function to use in both the metabox and taxonomy-metabox? The SVG looks the same.


No i ten ciąg zapytań można zamienić na jedno zapytanie...


actually i will delete this part, not used and increases memory use


Ermal,

The correct term is “employee” and with that comes certain duties and obligations.

I’m sorry you are distressed by the work I have been tasked with completing, but I would suggest the best course of action is to engage in a polite and reasoned conversation with my employer rather than calling me names.

Respectfully,

Steve
--
Stephen Beaver | +1 (512) 646-4100;239 | sbeaver@netgate.com | www.netgate.com

> On Nov 6, 2015, at 3:08 AM, etph <notifications@github.com> wrote:
>
> Hey sbeaver even you are stupid or you are a puppet.
> Rollback my copyright ASAP and ask your employer to do the commit if he so pleases to do so!
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/pfsense/pfsense/commit/9da2cf1c6e8e2e9b99d2369dbedb13c580a39377#commitcomment-14235111>.
>


@otaviobp
`SOL_BUFFER_FLAGS_FIXED_CAPACITY            = 00000001`
`SOL_BUFFER_FLAGS_NO_FREE                           = 00000010`
`SOL_BUFFER_FLAGS_MEMORY_NOT_OWNED = 00000011`
So the comparison will return `00000010` (`00000010 & 00000011`), `true` and NULL will be returned. I've failed to get your point (and now I'm curious with my confusion =D).
Maybe your point was the other way round (fixed capacity set and nofree not), and we could return the memory but we are not - if that's the point, then it's ok - a steal finalises the buffer.


Hi Rob,

No trouble - It's easy to reproduce, just put something like

[Logging]
GangaLHCb=INFO

(this is what Atlas rather pointlessly has) and it will show up.

Thanks!

Mark

On 06/11/2015 12:57, Robert Currie wrote:
>
> @drmarkwslater <https://github.com/drmarkwslater> ah it appears you're
> correct. I'm surprised I've not seen this in lhcb testing... I'll see
> if it's reproducible there and put in this fix unless you've beaten me
> to it :)
> Sorry for not spotting this before!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ganga-devs/ganga/commit/504bc6040b41a9045f1e3fe17dee3bd38d838497#commitcomment-14240430>.
>


P.S. Add the above to a config file like LHCb.ini :)


OK. Due to not enough time I will leave there cmd.run and next week I will try to change.


But you are adding a different API, and it's not even using it  on this new code. Maybe it should have it's own patch?


dead


yes, that's what it says. what's your point?


s/one match query/one match predicate/

so that a user hopefully doesn't imply into this that it is not possible to use 2 different match predicates


UPDATE customercontacts SET type = 16 WHERE type & 8 = 8 AND customerid IN (SELECT id FROM customers WHERE einvoice = 1 AND invoicenotice = 1);

Nie wiem czy CONTACT_EMAIL_INVOICE też nie powinien stać się odrębną flagą CONTACT_NOTIFICATIONS i wtedy w połączeniu z CONTACT_EMAIL lub CONTACT_FAX pozwalałby wysyłać powiadomienia różnymi ścieżkami.


shouldn't be set to 75 rather then 750? If 750 is correct then you need to fix line 172


dead code


with an?


-> #20


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.747](http://teamcity.monogame.net/viewLog.html?buildId=11085&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


empty ref?


`Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>`


Прости, но так не сейчас непишут. Почитай для начала что такое [CBV](https://docs.djangoproject.com/en/1.8/topics/class-based-views/) и в частности https://docs.djangoproject.com/en/1.8/topics/class-based-views/generic-editing/, в любом случаи нужно валидацию делать через формы, а не через if


I don't see "autodetect line break" in editor options setup. Do you have? How


That's an interesting idea. I wonder if all our standard exceptions shouldn't include an option to supply the provider's internal exception.  Feel free to create a JIRA issue on that for further discussion:

https://issues.apache.org/jira/browse/TINKERPOP3


it seems this driver breaks the build on msvc 2010, after disabling it, i could build again (sorry was my first compile so i may be wrong)
first i had "__restricted errors"
(was solved by removing "#define restrict __restrict" in opus_config.h)
never use restrict use RESTRICT ? :) (btw i think its evalueted correctly in nedmalloc.h)
after that i run into
"_LRINTF" and "_LRINT" linker errors
even when i changed to :
/* Define to 1 if you have the `lrint' function. */
#define HAVE_LRINT 0
/* Define to 1 if you have the `lrintf' function. */
#define HAVE_LRINTF 0

then i disabled it :)


What does the suffix 'Depr' mean? Is the class deprecated?


Please don't execute the prototype functions. You can use YoastSEO.app.scoreFormatter.scoreRating


For a tutorial like this, latest is fine.


CR done


We already got to bottom of that issue.


см. коментарий ниже. С CBV кода будет на 5 строк (меньше кода - меньше багов)


Es magua


> I'm not a fan of that term anymore, because it's a binary state.

Hm, "engaged" is used to indicate whether or not the `maybe` holds a `T`, so it's used to describe a binary condition. However, I'm not a big fan of the term either.

What about this wording?

```cpp
/// - Valid, i.e., a value of type `T` is present
///   + `valid() == true`
///   + `is_none() == false`
///   + `has_error() == false`
/// - Neither value nor error present (default-constructed `error_condition`)
///   + `valid() == false`
///   + `is_none() == true`
///   + `has_error() == false`
/// - No value present with error condition
///   + `valid() == false`
///   + `is_none() == false`
///   + `has_error() == true`
```


dead code


Magia*


Точно)))) Я просто на автоматі так зробив)


You're welcome.


Also da der gesamte Vorkurs darauf abziehlt den Erstis schönes Programmieren und Modulo beizubringen, sind die praktisch darauf trainiert genau diese Lösung zu finden.

Ich würde das so lassen wie es jetzt ist.


Added a "For example" like the step above.


Where have you seen that PasswordEncoder is deprecated?


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20240/testReport/) for this commit**


What do you mean "not a remote object"?


@CharlesWoodhill Could you open a specific ticket for your issue? It will be easier to track down than with a comment in an already merged PR.


Interesting…


· The source is now the backup done by rsnapshot instead of the original data


It lacks a dot.


fv = syscall.MAP_SHARD | syscall.MAP_POPULATE


if you call that method from ejb client you will get instance the that is not a remote proxy anymore and thus calling query on that builder will not hit the server where remote ejb is running


same here.


Telling users how to view the help info is always good. Also using a containerized utility CLI like this might be unfamiliar to people so they wouldn't even know this is an option.


'Normal' steal also resets `capacity` and `used`, shouldn't you reset `used` in this case? Not sure really - but if not, maybe this function is not a real steal, and should have a name alongside 'copy_data' or so.


I see!


Could you please, upload a Demo with nib? Im trying but I don't know how.
Thank You.


Problem with loading is in PersonBean.java

pet setter sets firstname, should set pet


The forum is there to discuss things and to answer any questions people may have.


You're right. this will be true if one of them are set. In my mind the if was like this:
if ((buf->flags & SOL_BUFFER_FLAGS_MEMORY_NOT_OWNED) == SOL_BUFFER_FLAGS_MEMORY_NOT_OWNED)

But the problem is even worse. If SOL_BUFFER_FLAGS_FIXED_CAPACITY is set, but SOL_BUFFER_FLAGS_NO_FREE is not, we will return NULL, but we could have the pointer stolen.


@mswiderski OOoo.. of course! _remote_ EJB's. :D

Yes, I'll update the PR so that these are methods with primitive arguments.


Removed demo link. The demo no longer works since it is blocked by the browser when trying to log in. The reason (I think) is that the site is using HTTPS but is connecting to the server using WS (not WSS).


This one is a bit overkill


public class T2{

}


Sure, I can split tthis code.


whiteline


I have made another attempt. Does this satisfy these requirements? https://github.com/openmrs/openmrs-module-legacyui/commit/2623b931aaca5dee23bac8b71207f86c1f648f35


please add javadoc explaining what requesterWebID does


On Fri, 2015-11-06 at 02:42 -0800, jobol wrote:
> but will it really solve the concurrency error? the rule would be for
> do_patch to apply only when the dependencies of the package are
> installed. Is it what you want to enforce? Is it possible to do that?
> globally? by package? Waiting for more knowledge about that....

http://www.yoctoproject.org/docs/latest/bitbake-user-manual/bitbake-user-manual.html#inter-task-dependencies

do_patch[depends] = "libcap:do_populate_sysroot"


The second colon is needed to render the indented section as a [preformatted\literal block](http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#literal-blocks).


I'll add it again in future to keep some consistency :)


Why InsufficientAccessException ? At this point we don't really know why we got an error ...


dead code


ben je dit zeker?


@vmsw/noord test


Yes, that is clear, I mean it was just a minor suggestion.  By the way, don't forget to update `README` with the relevant example:

```
(add-hook 'dired-after-readin-hook #'dired-k-no-revert)
```

so that others are immediately aware of this feature.  Thanks for your effort!


@seyko2 : This is outdated branch/patch. The latest patch is at https://github.com/MidnightCommander/mc/pull/49/files .


Puedo hacer un:
def noHacerNada:Combatientes=>Combatientes = identity


@borshop: retry


* Would be weird if they'd remove stuff from a CDN. But let's see..
* We'd be nowhere if we followed each and every rule :wink:


You forgot a slash here: https://github.com/openmrs/openmrs-module-legacyui/commit/03083da4f70071970b9a83cd8771366b22433178


@ademilter sağolasın hacım, ne mutlu bana faydalı oluyorsa. şurada da es6 ile v2'sini yazmaya başladığım hali var, ona da bi göz at derim; https://github.com/uxrocket/uxrocket.factory/tree/v2.0


This commit tries to resolve the problem of weird override signals being "detected" by the arduino. This is due to the fact that in many cases, interrupts were disabled in order for the reading of volatile variables handled by interrupts to become safer. However, this affected how the signals were perceived by the arduino board, as sometimes the interrupt would "delay" to be fired up.

Moreover, the baud rate was increased to 115200, since at low rates it was observed that it was affecting the override signal handling (which is in turn based on an interrupt). My guess is, that since sending through serial is also interrupt based, when the data to be sent were too many and therefore the whole sending procedure was relatively slow, then how we read the signal was affected.


defaultLabel


Is it, though?

    ~ » ghci
    GHCi, version 7.10.2: http://www.haskell.org/ghc/  :? for help
    Prelude> import Data.List
    Prelude Data.List>


Igual si, la función ahí no es necesaria para nada JAJAJJA


By not putting the Wordlist+Rules last, the TS will simply abort upon that test, until we get it fixed.


This is to avoid
![screen shot 2015-11-06 at 10 21 20 pm](https://cloud.githubusercontent.com/assets/4310419/10997958/c8295f00-84d4-11e5-8ea4-03feabe4d2dd.png)


thanks for fast response. New to this, wasn't expecting such helpful
feedback.

On Thu, Nov 5, 2015 at 11:26 PM, Tejas Manohar <notifications@github.com>
wrote:

> @barryaprogrammer <https://github.com/barryaprogrammer> I recommend you
> read the README. Windows isn't supported and 99% never will be due to the
> deep reliance on ext-pcntl in Boris- would be a new project :P
>
> Here's an alternative- @bobthecow <https://github.com/bobthecow>'s psysh
> <https://github.com/bobthecow/psysh> is an alternative.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisrepl/boris/commit/0e4127fb01a1ea518ad45d7926bd7b40532e66bd#commitcomment-14229913>
> .
>


Seeing as you've removed the `lastModified` tests from `HistorySynchronizerTests`, how about adding them to `DownloadTests` to ensure that we are not losing coverage? I couldn't see anything in there that tester for the same thing.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.747](http://teamcity.monogame.net/viewLog.html?buildId=11085&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 551, ignored: 6 Build time: 00:19:46


Shouldn't all the IDs be irrelevant?


Great piece of refactoring!


@nedbat Any particular reason for pinning django==1.8.4. Due to this fixed version edx-ora2 tests were failing. I have made it flexible, now edx-ora2 tests are passing but `xblock-sdk` build is failing.


Missing transalations!


Missing translation!


Line is too long. [102/100]


Добавил пробелы, чтобы выровнять вертикальную линию.


I will create an issue from this.


Все вот это не нужное в гитигнор файлик


For all the reasons that phusion lists on their page. While haraka itself may be a single process, it's very likely to spawn others (e.g. for DKIM, spam filtering etc), and moving them to their own containers would be academic exercise in creating unnecessary overhead. Having an init process that's designed to be one (i.e. not node) makes things more robust. It's also lighter than the stock ubuntu image.


this commit looks good


s/Explicite/Explicit/


sounds good had no idea. what do you think about naming this class XFormMobileMetadata?


s/witch one/which/


s/also can/can also/


pls add comments for include field


Agreed. Blacklisting was used mainly do stop on imap folders -- increase performance.


never done :) ill try ;)


This is the same as the 163 line.


This is the same as the 169 line.


Well, it is in older versions of GHCi. :sweat_smile:

GHCi, version 7.6.3: http://www.haskell.org/ghc/  :? for help
Prelude> import Data.List
Data.List>


We might have some surprises as any exception can arrive here. Some of them might have a description which is not intended to be displayed. What about checking `isinstance(e, HTTPException)`?


TODO MM: Get difference from expected data instead of actual.


I agree, this was probably relevant one year ago :)


@0x00B1 this makes test_analysis_worker's test_03_07_a_sad_ending test fail because of this line here: https://github.com/CellProfiler/CellProfiler/blob/fab746f5da837ff7fb69747d35c781634d19fd4f/cellprofiler/analysis_worker.py#L699

cellprofiler.utilities.rpdb is a little different than the rpdb package - it sends a hashed secret across to provide some level of security when someone connects. I have never used the remote debugging facility - I usually start an instance of the analysis worker in my debugging environment in order to debug. IMHO - it's ok to take this functionality out, will modify so that it uses the rpdb package if it happens to be installed, but the release will not install it.


lgtm.


check the condition firstly.

    CHECK(layer.include_size() == 0 || layer.exclude_size() == 0); // either using include or exclude

then

     if (layer.include_size()) {
       include = false;
       ...
     }
     if (layer.exclude_size()) {
       include = true;
       ...
      }


Uh... Now I'm confused

    root@d8c1ea534818:/# ghci
    GHCi, version 7.6.3: http://www.haskell.org/ghc/  :? for help
    Loading package ghc-prim ... linking ... done.
    Loading package integer-gmp ... linking ... done.
    Loading package base ... linking ... done.
    Prelude> import Data.List
    Prelude Data.List>


A to po co?


To również po co?


Double checked this.  The places in `src/ostree` where we set `G_IO_ERROR_NOT_SUPPORTED` are already immediately followed by printing command usage, so I think this is okay.  :+1:


New stuff for sound handling.


跟踪sln文件


check the code format for .cc and .h files you edited.

    python tools/cpplint.py  <sourcefile>

The title of the commit msg is not complete.

pls address the comments, commit and push again.


Just wondering, isn't the AnyRef redundant here?


i go to not change `capacity` and `used` in case of copy. In both cases will be necessary call `sol_buffer_fini()`, so the memory will not leak. The advantage of this (instead of a 'copy_data' function) is not always copy the memory.


You're right I don't need to duplicate here. I will change that.


`version` still at 0.12.2 here.


Why cherry pick this? There is no need of this with the current base code on master


The `<base>` url, when defined
is prefered over the response's url.
Maybe the doc should state this.


Ok, then I'll throw it on it being a Windows issue. It can't be specifically _my_ installation of Haskell Platform that's doing this, right?


OOPS - there's some necessary synchronizing behavior in cellprofiler.utilities.rpdb that's not in the package. Either we restore cellprofiler.utilities.rpdb or we get rid of this functionality.


imo splitting this line would make it less readable


Aha! :D


Thanks for the patch. But unfortunately it doesn't look enough.
Both of them are actually of size_t (not always equivalent to unsigned long).
C99 standard has a "%z" format specifier for size_t, but this is C++ (moreover, "%z" is not supported by MSVC). See here: http://stackoverflow.com/questions/1546789/clean-code-to-printf-size-t-in-c-or-nearest-equivalent-of-c99s-z-in-c

I think easiest fix is just using %u and explicitly casting corresponding arguments to unsigned integer.


negative value makes sense ???? `request_node_get_timeout` was rejecting negative values


great commit message :-P


I'm slightly worried about some API that takes initialised buffers mixed with other that require uninitialised buffers. For the last, wouldn't be better to return a `sol_buffer`? Create a more consistent API? Then all worries I've told you about ownership of buffers would also be solved.


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 Total|||||


Small nitpick ... we should really think about a better name for this to avoid confusion with invokedynamic ...


What's with this function?


This is no longer in sync with org.eclipse.xtext.generator.parser.antlr.ex.common.AntlrFragmentHelper.getAllPredicatedElements(Grammar) - why did you change it here?


@poupotte why do you declare a `folderDir` if you don't use it here?


No problem. Look forward to any ideas/improvements you run across.


2 long days of working :sweat: :sweat_drops: :goberserk:

congrats!!


right, i'll just call it `Virtual`


@giuseppec with the infJackknife? do you have an example I could look at? i ran some basic things and didn't have any errors.


Hi @yelmontaser,

Good catch, this should be fixed in https://github.com/PrestaShop/PrestaShop/pull/4412

Thanks!


I see - because of getAllPredicatedElements in XtextAntlrUiGeneratorFragment - the other location needs an update, too - both should delegate to GrammarUtil.


Huh. Didn't the compiler yell about an unused static function? Or do you not have `-Werror` in your `CXXFLAGS`?


**Code Quality: Nitpick**

The error message defined here is not complete.


For timeouts no, I don't know for other uses.


I don't have to go that far. We already refresh the grid to update the recent games. All I have to do is redraw the menu at the same time we update the recent games.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3938](https://teamcity.mesosphere.io/viewLog.html?buildId=69507&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:07


`Reviewed-by: Jerome Forissier <jerome.forissier@linaro.org>`


Maybe s/caseeq/case_eq/?


%sh blocks are always executed by the server, so that window_id thing wont work.

A solution would be to use tmux ls-windows to list the windows, then loop on windows with tmux ls-panes to find the current $kak_client_env_TMUX_PANE


It works. I got a message also.

On Thu, Nov 5, 2015 at 2:54 PM, Massy1989 <notifications@github.com> wrote:

> Looks like it worked. I received an email notification with your message.
>
>
> > On Nov 5, 2015, at 10:05 AM, tsgirard <notifications@github.com> wrote:
> >
> > Testing, not sure how this works but I wanted to see if I am doing this
> right.
> >
> > —
> > Reply to this email directly or view it on GitHub.
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Massy1989/CollaborationWebsite/commit/b45ab053628c255c5e5d5dd9e10904b1f6622076#commitcomment-14222843>
> .
>


Why was all of this removed? Now, the drawer doesn't have a longclick context menu...


yeah wasn't really a really a bug :smiley:
but nice that the field does no longer get deleted


**Code Quality: Nitpick**

Try to move information like this to a separate configuration that can be accessed application wide. You could also make use of environment variables for enhanced security.


I don't think we have that in our default flags. Eclipse did mark it but I
didn't notice it because all the flag validator constants are unused and I
was expecting to see yellow markers.

On 6 November 2015 at 13:45, Pierre Phaneuf <notifications@github.com>
wrote:

> Huh. Didn't the compiler yell about an unused static function? Or do you
> not have -Werror in your CXXFLAGS?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Martin2112/certificate-transparency/commit/da999f3e68d57fbb1cc58c43f068a5fd9d15dfd0#commitcomment-14241401>
> .
>


Misspelled?


woul it not be easier to do:

    if (!String.IsNullOrEmpty(market))
        return DownloadData<SearchItem>(_builder.SearchItems(q, type, limit, offset));
    return return DownloadData<SearchItem>(_builder.SearchItems(q, type, limit, offset, market));


Is Frequency the right term?


Why was all of this removed? o_O


Heh, it could be. Anyway, the implementation as merged uses ':module' instead of 'import' and explicitly loads Prelude, so that should be okay.


Doesn't `with_webp` get initially set from the command line arguments?  Then if the user runs `./configure --with-webp` there's a value `with_webp=yes` set before we hit the `AC_ARG_WITH`, and its *action-if-given* also sets `withval=yes`.  Then if libwebp is missing locally, this test will fire.

(If the user didn't specify the `--with-webp` argument, then `with_webp` is unset and `withval=yes`, and so we continue on, setting `with_webp=no` along the way.)

In practice, I can get the error message output if I run `./configure --with-webp` on a system with a missing libwebp, so I'm pretty sure this test can fire!


@firejun Thank you for taking benchmarks. I've recognized ``s3cmd`` seems bottleneck because I've created the same situation on my environment, after that I directly requested retrieving list objects to Leo's Storage one by one. Its result is so fast - average of the result is 40-50ms as below:

```erlang
(storage_0@127.0.0.1)8> begin
(storage_0@127.0.0.1)8>   Start = leo_date:clock(),
(storage_0@127.0.0.1)8>   {ok, MetaL} = leo_storage_handler_directory:find_by_parent_dir(<<"test/1/">>, <<"/">>, <<>>, 1000),
(storage_0@127.0.0.1)8>   End = leo_date:clock(),
(storage_0@127.0.0.1)8>   (End - Start) / 1000
(storage_0@127.0.0.1)8> end.
28.644 (ms)

(storage_1@127.0.0.1)1> begin
(storage_1@127.0.0.1)1>   Start = leo_date:clock(),
(storage_1@127.0.0.1)1>   {ok, MetaL} = leo_storage_handler_directory:find_by_parent_dir(<<"test/1/">>, <<"/">>, <<>>, 1000),
(storage_1@127.0.0.1)1>   End = leo_date:clock(),
(storage_1@127.0.0.1)1>   (End - Start) / 1000
(storage_1@127.0.0.1)1> end.
32.877

(storage_2@127.0.0.1)1> begin
(storage_2@127.0.0.1)1>   Start = leo_date:clock(),
(storage_2@127.0.0.1)1>   {ok, MetaL} = leo_storage_handler_directory:find_by_parent_dir(<<"test/1/">>, <<"/">>, <<>>, 1000),
(storage_2@127.0.0.1)1>   End = leo_date:clock(),
(storage_2@127.0.0.1)1>   (End - Start) / 1000
(storage_2@127.0.0.1)1> end.
48.548

(storage_3@127.0.0.1)1> begin
(storage_3@127.0.0.1)1>   Start = leo_date:clock(),
(storage_3@127.0.0.1)1>   {ok, MetaL} = leo_storage_handler_directory:find_by_parent_dir(<<"test/1/">>, <<"/">>, <<>>, 1000),
(storage_3@127.0.0.1)1>   End = leo_date:clock(),
(storage_3@127.0.0.1)1>   (End - Start) / 1000
(storage_3@127.0.0.1)1> end.
31.579

(storage_3@127.0.0.1)4> begin
(storage_3@127.0.0.1)4>   Start = leo_date:clock(),
(storage_3@127.0.0.1)4>   {ok, MetaL} = leo_storage_handler_directory:find_by_parent_dir(<<"test/2/">>, <<"/">>, <<>>, 1000),
(storage_3@127.0.0.1)4>   End = leo_date:clock(),
(storage_3@127.0.0.1)4>   (End - Start) / 1000
(storage_3@127.0.0.1)4> end.
56.206

(storage_3@127.0.0.1)6> begin
(storage_3@127.0.0.1)6>   Start = leo_date:clock(),
(storage_3@127.0.0.1)6>   {ok, MetaL} = leo_storage_handler_directory:find_by_parent_dir(<<"test/3/">>, <<"/">>, <<>>, 1000),
(storage_3@127.0.0.1)6>   End = leo_date:clock(),
(storage_3@127.0.0.1)6>   (End - Start) / 1000
(storage_3@127.0.0.1)6> end.
34.452

(storage_3@127.0.0.1)8> begin
(storage_3@127.0.0.1)8>   Start = leo_date:clock(),
(storage_3@127.0.0.1)8>   {ok, MetaL} = leo_storage_handler_directory:find_by_parent_dir(<<"test/4/">>, <<"/">>, <<>>, 1000),
(storage_3@127.0.0.1)8>   End = leo_date:clock(),
(storage_3@127.0.0.1)8>   (End - Start) / 1000
(storage_3@127.0.0.1)8> end.
70.772

(storage_3@127.0.0.1)10> begin
(storage_3@127.0.0.1)10>   Start = leo_date:clock(),
(storage_3@127.0.0.1)10>   {ok, MetaL} = leo_storage_handler_directory:find_by_parent_dir(<<"test/5/">>, <<"/">>, <<>>, 1000),
(storage_3@127.0.0.1)10>   End = leo_date:clock(),
(storage_3@127.0.0.1)10>   (End - Start) / 1000
(storage_3@127.0.0.1)10> end.
30.833
```

I'll consider method of the benchmark.


Cool feature!  LGTM, but I'd wait for @cgwalters to comment.


All parameter checks should happen in `SpotifyWebBuilder`, so people can use the class independently


fantastic !!


:blush:


В базовых классах не должно быть никакой логики, а особенно в конструкторе работы с пользователем.


should this really be silent? under what situations are you expecting this to occur?


Ok thats better indeed


Всю работу с консолью нужно выносить в отдельный класс.
Читай про паттерн MVC


**Code Quality: Nitpick**

Since you had already injected `$app` as a dependency in this class, you don't need to do `Slim::getInstance()` anymore. You can reference the app instance anywhere in the class using `$this->app`.


@joelanman Yea that's a good idea. I used 1000, 2000, 3000, 4000, 5000, 6000 earlier this week and had forgotten that other 'things' may be using those ports. The error you get isn't that helpful.

Why not recommend common safe ports to use.

Like you can use 3001 - 3009 in most cases.


Congratulation on new JS memory leak: now destroyed textures will remain in _managed.


Does it make sense to have `//` comment syntax inside javadoc?


Having all this code inside of Linux namespace have a benefit? For what I can see it is only adding the definition of 'union pwm_params' to it.


@dhanvi Is that correct to move the task reference to completed writeups? Didn't you just add another external writeup?


Why pwmXXXXX? pwmXXX is enough.


Nice catch the s/%d/%u.


We should also check for overflow, since snprintf() return the number of chars need to store the formated string even if it is bigger than sizeof(path).


There's a PR treating this, in case you want to just drop it.


I think that its better to assign new pixiId's to textures and store them in Object, not in array. But that thing will work too :)


Is it worth using vulcan-config for new services?


Nice catch.


KademikaLesson


Why not have a ``sol_buffer_steal_or_copy()`` then only and keep the safety check in the steal one? This avoids confusion/double behavior.


**Code Functionality: Nitpick**

Don't fail silently. Since `Emoji::find($id)` does not throw an exception, you need to effectively write code to handle scenarios where no emojis exist with that id.


line 151 indicates that the `p` switch should have an argument - it's just a switch for using `pmset` on mac. Maybe change to

```bash
while getopts ":g:m:w:tapb:" opt; do
```

The `-b` switch works very nicely, I like it.

-------------------------

Haven't quite gotten it right in my `.tmux.conf` yet. Probably something like

```
set -g status-right '#([ -d /sys/class/power_supply/BAT1 ] && /path/to/battery -tap -b /sys/class/power_supply/BAT1 ) #(/path/to/battery -tap)'
```
Seems a little verbose, but it looks like without the check to see if there is actually a battery in `BAT1`, it draws the regular ASCII outline with the square brackets, no percentage, and no bars.

This could be more or less good behavior, as in, some users may want to see some feedback if they have an attached external battery pack, to see whether or not it's there (this is the case with the Dell Latitude). Some users may not want to see that. This way gives them options.

Only two comments I have about that:
1. Maybe we might consider adding a bit of logic that checks to see if the battery path exists, and when not in `-t` (tmux) mode, throw an error, and when not in `-t` mode, just print nothing, or print 'NO BATTERY' or something like that.
2. Depending on how we tackle the first point, write into the documentation how it might look in your `.tmux.conf`. I'm happy to do that.


Доп задание:
добавить проверку уникальности добавляемых товаров.


Hey Vlad - Not sure I agree with the name change for this. I like the other pull request making everything virtual. Maybe @jasonbert can weigh in on this.


cool, just added your version check here https://github.com/mapillary/OpenSfM/blob/master/opensfm/context.py#L8 so @edgarriba can use `context.OPENCV3` as a flag


implicit*


Using uint32_t may be wise to already start adressing this: https://github.com/solettaproject/soletta/issues/1011


Продукт не должен знать, сколько его есть. Количество не относится к свойстам самого объекта


**Code Functionality: Nitpick**

It's not very clear what exception the `find()` method is throwing. Need to put in code to better handle errors.


Not sure how this is done with `gclient`, but I put `CXXFLAGS=-O2 -ggdb -Wall -Werror` in the `./configure` flags, to get the good stuff (`-O2 -g` is the default, `-ggdb` is slightly better, and mo' warnings!). `-Wextra` would be nice, but it's a bit too much at the moment... :smiley:


I added support for the 'current' scope to the set command, global should be 'current'.


**Code Quality: Nitpick**

This assignment is needless. You could just say `echo Emoji:all()` to achieve the same thing without needing to waste space on a variable you never used.


I think the flags are OK in gclient, which is why the travis build reported
it. I set my local build up before we had that working and one day I'll get
round to fixing it ...

On 6 November 2015 at 13:57, Pierre Phaneuf <notifications@github.com>
wrote:

> Not sure how this is done with gclient, but I put CXXFLAGS=-O2 -ggdb
> -Wall -Werror in the ./configure flags, to get the good stuff (-O2 -g is
> the default, -ggdb is slightly better, and mo' warnings!). -Wextra would
> be nice, but it's a bit too much at the moment... [image: :smiley:]
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Martin2112/certificate-transparency/commit/da999f3e68d57fbb1cc58c43f068a5fd9d15dfd0#commitcomment-14241678>
> .
>


It seems odd to zero-check each of ascender/descender/linegap individually, in order to decide whether to override OS/2 values with *hea ones. This could (in peculiar cases) lead to using a mixture that the font designer never intended.

IMO, the three values should always be used from the same source, whether it be OS/2 or *hea; don't mix'n'match.


No need to unalias there is we are going to override the alias anyway


I think we should, yes. was going to say the same but I thought I'd at least get one merged to production first.  Maybe I should do a mini-doc to explain the subtleties.


Why is `endptr` optional? Isn't it fundamental to know if conversion was ok?
Unless you create a different wrapper - one that returns if conversion was successful and takes a 'result' pointer. No need for `endptr` then.


Full contents


Create icon asset


Didn't mean to commit this straight to master; was using GitHub UI and expected it to open a PR


I just followed the macro strcaseeq(), but I can change it.


`5` should be `spacemacs-number-of-rollback-slots`


Does that mean that every new window created with `:new` does not result into the creation of a full-fledged "client" ? Because this implementation mostly works, but not with all the windows made with `:new`, so that would explain it.


Да, спасибо.

Но я вижу, что нет обработки неправильного логина-пароля, например. Или проблем с нахождением csrf токена. В результате, если произойдет ошибка на сайте или пользователь введет неправильный логин-пароль, то пользователь получит невразумительное сообщение.

Вот здесь есть шаблоны для обработки ошибок: https://github.com/dukei/any-balance-providers/blob/master/extra/development/ab-stark-typical-provider/main.js

При получении странной ситуации, мы стараемся найти текст ошибки и показать её. Если не получается, печатаем в консоль страницу и сообщаем, что сайт, возможно изменен. Распечатка в консоль позволяет потом по логам исправить проблему, если это возможно.

Можете исправить?


尝试再次提交


Doubt it matters but you should maybe use \\` and \\' in place of ^ and $.


+1 then


I guess it could be useful to have debug versions of `condvar_signal()` and `condvar_broadcast()` too?


But you can have the local machine running the simulator at the same time, right?


A to?


Great! Thank you

Sent from my iPhone

> On Nov 6, 2015, at 7:46 AM, mlxiong <notifications@github.com> wrote:
>
> It works. I got a message also.
>
> On Thu, Nov 5, 2015 at 2:54 PM, Massy1989 <notifications@github.com> wrote:
>
> > Looks like it worked. I received an email notification with your message.
> >
> >
> > > On Nov 5, 2015, at 10:05 AM, tsgirard <notifications@github.com> wrote:
> > >
> > > Testing, not sure how this works but I wanted to see if I am doing this
> > right.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub.
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <https://github.com/Massy1989/CollaborationWebsite/commit/b45ab053628c255c5e5d5dd9e10904b1f6622076#commitcomment-14222843>
> > .
> >
> —
> Reply to this email directly or view it on GitHub.
>


Sorry, I thought this was one of your changes but I was wrong. Generally, I prefer to block messages but in this application this is not probably necessary. We can be back to the previous version.


Why did you remove this? The exception is still deprecated as we no longer use it and it will be removed in Contao 5


whiteline ^.^


Yes, then the 'remote-ip' is localhost


fixes #2


I created this function to make it easir to use strtol on slices. Also endptr is optional in strtol as well


МАЮ??!!!!!


Fold this commit with the previous one so we don't have failed commit on master when we merge.


does nothing?


Nod.


@ssalcio this behaviour happens when the calendar is not inline and hidden
The timelist height is calculated based on calendar height, and when it's hidden it's height is 0
I'm studying a way to solve this, if anyone have any ideas, welcome =)


@edersondisouza I will change to make all functions initialize the buffers before using them.


ModifyTimeBinsToUseRounding (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


good catch, this can be removed.  it was originally added because HashedListTargetCollection#targets returns targets in lexicographical order, and a previous version of my code required that the coverages be in the same order as the segments.  this is not necessary with the nested streams (see comment below), and the segmenter returns natural-sorted segments anyway---so i'll take this out.


What I want is that the tests pulled from GitHub can be run on any machine by default. To do that, I think it's best to change the `remote-ip` to localhost. If the users want to try out the remote simulation, they can do that by changing the configuration file themselves.

Also setting this to localhost will make it easier to add this repo to CI servers (e.g. [Travis](https://travis-ci.org/)).


Great!


Looks good to me.  This is what I've got mixed in with patches that link with GSSAPI libraries, so that we can test code that uses them.


On 06-11-2015 12:06, Guilherme Íscaro wrote:
> I created this function to make it easir to use strtol on slices. Also
> endptr is optional in strtol as well
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cabelitos/soletta/commit/c3136a794fab73e4423002845274320d375f77fb#commitcomment-14241846>.
>
Fair.


Me referia al ultimo de peelar round que usa genkidama


You are right.


could be `.append(new Option(contact._id, contact.name, true, true))` too


I would make the `from_date ` here different to that of `vacation2`, ex `2015-09-09`.


remove commented section


whiteline ^.^


This is the only change I see in setup.py. So I'm not following how this PR changes what is include in sdist uploads?


This test tests that there's a new vacation and it ends later.
Would it be worth it maybe to test that there's a new vacation, but it starts earlier?


nice!


Maybe some flag whether call for papers are already open?


import org.openide.awt.Mnemonics


If you have a pre-gclient build, run `./config.status --config` to get your current set of `configure` flags, then call `./configure` with all those flags, plus whatever extra tweaks you want. `make clean` isn't a bad idea if you change anything related to code generation, but for warning flags only, no need to bother.


Agree. :smile:


It shows up fine in the output javadoc, because it is inside the `<pre>{@code}</pre>` block. I think the `//feed type normal` comment in this case is probably not the most useful in the world, but with two nearby sample blocks it might help people distinguish which one they are looking at.


[Artur Mas aprueba este commit] (http://www.lavanguardia.com/politica/20151106/54438627994/democracia-libertad-y-catalunya-nombre-cdc-20d.html).


That is a rather massive change. Might be best to open an issue and assign it to me or some such if you want review.


Weird, since I noticed it by pulling your branch and running `clang-format`!


I almost sure that <Process.h> is enough, isn't it?


`__unused` is not needed on `fname`


Nit: s/it's/its/


The overlay looks OK. The README has trailing whitespace, there is no Makefile change causing it to be built, and your commit message has a typo - "capavitive".

If you like I can fix these and merge it - you're name will still be on the commit, so you'll still get the credit. Otherwise, patch up your commit then "git push -f" to update the pull request.


Same again here.


You can chain classes so `.panel-body.description` should be sufficient here. (The only reason I did it different above was because the class name was dynamically generated)


I can solve the mystery. The clang Eclipse plug in doesn't support custom
styles and it's set to "Google".

On 6 November 2015 at 14:18, Pierre Phaneuf <notifications@github.com>
wrote:

> Weird, since I noticed it by pulling your branch and running clang-format!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/Martin2112/certificate-transparency/commit/9623478f9beeda99210cb43b9ceed707344b99db#commitcomment-14242209>
> .
>


phpunit/phpunit package should be under require-dev.


Maybe include priority as a parameter too?


No `__unused` needed I think


Już znikło :)


Seems like a good idea.  Just curious why?


Here also, all parameters are used


Technically the C++ coding standard is lowercase first letter for functions. C# is caps, for the purposes of this project I recommend we don't dispute method capitalization, only method naming conventions and the likes


Hi Jaime,
normally a server has "normal" sensors for power supplies, which are listed in the ipmi-sensors output. So problems with a power supply should be detected without reading power supply information from the SEL. Could you maybe provide the "-vvv" verbose output of your system when you execute the check_ipmi_sensors plugin? (So we could see if this is maybe different for your system - in that case we should think about how we could support your system in the best way, but also prevent multiple alarms for one failure for other systems - this could happen when a failure is both reported with ipmi-sensors and ipmi-sel)


Adding OpenMP, serious s**t !


Time to run the tests with different Xdebug version and same PHP code base:

* 2.2.7:   4.76 sec
* 2.3.2: 10.78 sec


Ok, thanks, looks good to me then. Merging...


So, your assumption here that `qmake` is always located directly int the root of drive?


I changed the variables c and r to col and row just to make them that bit easier to understand what they are. I added a brick collision detection function. All the bricks status' are set to one meaning they are printed on the canvas but when a brick gets hit it is then set to zero which makes it disappear from the canvas.


rip


Don't we want to use the "correct" EvaluationContext here, with PropertyAccessors and all?


Also switched to tabs?


Not clear what's that. Why are they called in such a strange manner?


WTF


whiteline ^.^


This was on the whiteboard Workshop #52
https://github.com/ocpi/ocpi/issues/52

I documented what was on the whiteboard, I think tokens are needed to be able to exchange CDRs


Please create the release version 1.1.1


Yea!! we are pro, too bad it allocates n threads on the same cpu core, instead of putting one thread per core, so actually it goes slower than before :-1:


handler


bjdksfb


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20247/testReport/) for this commit**


@mrdima not quite sure what you mean? :)


With What?


Don't think we should hard-code the file size here.


Хорошо бы написать более информативное сообщение в коммите, а так вроде все понятно. Наверняка они захотят что-то поменять, но это уже потом.


With what?


It was pretty late. I'm glad I didn't try to do an actual release ☺


Ну еще ты ломаешь существующие задачи, которые рассчитывают на random.seed


The ball is now colliding with the blocks on the canvas and are not being re-painted to the canvas when hit. The balls x position must be within the confines of the rectangle for the collision.


Centered the canvas on the screen.


I was thinking about this but I am not sure if it won't be YAGNI


ok


@Changsst :+1: the best Pull Request I have ever seen.


:joy:


Esto es un Merge sin fix


ModifyTimeBinsToUseRounding (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Merged - sorry for the delay! Pushed to npm as 0.0.5


Yes, good point.


Good question ...


You don’t need (pdf) either because it’s in the icon

![image](https://cloud.githubusercontent.com/assets/355079/10999432/d1124a32-8493-11e5-8802-55e8a367d2a2.png)


Hmmm


I was using the Brazil OSM POI and Geonames data.  I had merged one or two review items.  Because the service described in this ticket searches all review items and filters by bounding box on the node coord, one missing node would cause it to blow up.

At least that's my operating theory as this commit seems to fix it, https://github.com/ngageoint/hootenanny/commit/2914fd412b0414fc3cd80416c6d3bb8b059bd71e?w=1


It's implementing something from the Linux namespace, not only using things from there.  Thus the preference to enclose it like this. It doesn't really change anything.


@spite @tschw @bhouston @WestLangley

Because of [this](http://stackoverflow.com/questions/19529690/index-expression-must-be-constant-webgl-glsl-error) I had to do this horrible hack:

```glsl
for ( int j = 0; j < NUM_SHADOWS; j ++ ) {
  if ( j == pointLight.shadow ) {
    directLight.color *= shadows[ j ];
  }
}
```

Instead of just this:

```glsl
directLight.color * shadows[ pointLight.shadow ];
```

Is there a not-so-horrible way of using dynamic index?


`<extension version="3.4"` Should be `<extension version="3.5"` Sorry i have missed that on my other reviews :(


missing `|| die`?


Si vas a dejar la Excepcion borra el comentario ajja.
Y si vas a comentar comenta aca que para eso esta, igual te explico porque lo había puesto, la cuestión es que antes con el mayor ventaja de ki calculábamos solo que quede ganando. Entonces si quedaba perdiendo nunca iba a encontrar uno y tiraba error, por lo que yo te ataco, cuando me queres contratacar si no quedas ganando tiras excepción, los oponentes nunca pierden jaja

Sin embargo ahora con el fix que hicimos supongo que se debe haber arreglado, queres seguir tirando la excepción?


Because it is uint16_t, not uint8_t.


ok


Igual no confio en el merge, seguro en el medio borraste espacios... maldito asesino de espacios


my son


Where does `Option` come from?

I think I did this nicer elsewehre like:
```js
.append($('<option>', {
  selected: 'selected',
  value: contact._id,
  text: contact.name,
}));
```
I would happily change to this if you think it's important.


We calculated the space above so it doesn't overflow.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20248/testReport/) for this commit**


Y lo habria logrado de no ser por git y sus logs entrometidos


Thanks for double-checking this!


Yes, please go ahead with these small fixes, if you don't mind. Thanks.


nice!


Doing this involves 2 pieces of non-obvious logic:
* The top source/includes file has to end in .mb.erb (which is saying "Ok Ruby, you have to generate some markdown")
* The partial has to begin with an underscore, despite the reference in the .erb not including the underscore


ooh.. and I changed this because the compiler was complaining about enable the variable shadowing enable the method :-)


:+1: Every REPL basically starts it's life as a clj REPL anyways.


Btw, @bhouston @WestLangley, thanks to the light code refactoring this was fairly easy to implement! 😊


At least for now - this won't be the case when we add support for Clojure 1.8 REPLs. :-)


I needed to change this version from 2.3 to 2.2.  See here: http://codegur.com/22856289/jaxb-xew-plugin-in-maven-jax-ws


Se no había revisado eso, como te lo había pasado yo en vez de hacer / diferencia, hacia /energiaO-energiaA (es decir daba vuelta la resta) con abs queda mejor


Спасибо за комментарии, вот как раз хотел разобраться с такими вьюшками и переписать на более чистый вариант


spelling: "TestExtended..."


ahhh puede ser, y si, porque dejarseFajar podria ser una mala alternativa, o hasta podria no estar en los movimientos del chabon, asi que no se si tendria sentido


Yes, if `DMSG()` isn't doing anything.


After a while I think that  You are right 4 developers is example of such conference


addressed this by storing the cumsum of the number of targets in dataCollection instead.


Is this test function also run when it starts with `ttot_` instead of `test_`?


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1073.a9c2d24dfacb419934b3f3e8fe3ce687feabef8e](http://build.palaso.org/viewLog.html?buildId=65697&buildTypeId=bt431) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 482, ignored: 4 Build time: 00:35:46


I was thinking of using this class to register enums and use enum names directly in and from the json. Maybe too much invesment though.


A remark: no need for ` = Facets +1`. That is the default construction of enum values. See [cppreference.com]( http://en.cppreference.com/w/cpp/language/enum) about `enum`:
> For any other enumerator whose definition does not have an initializer, the associated value is the value of the previous enumerator plus one.

Another remark: *next time*, please use upper-case names for the enumerators (that are constants). See the [CGAL developers manual](http://doc.cgal.org/latest/Manual/devman_code_format.html):
> Names of constants are uppercase (e.g., ORIGIN).


Since `wq_rpc()` is static it can be optimized aggressively. Depending on what the compiler does it may notice that these parameters aren't used when `DMSG()` does nothing.


Var button = (x)
Variable+parser;


Same motivation as above.


view this
- [ ] @nazar-ivantsiv


You still have `if (fname)`...


Close #28


hehe I had to fix this in master too :D


2 things. taking away MH_PIE will probably cause flags to be corrupt. correct method is flags &= ~MH_PIE.

Also from what I've noticed, you can't remove MH_PIE from arm64 binaries or else they will just be rejected when loaded by the system. if you ever find a way around that feel free to tell me :)


already fixed


Sure, as soon as we add support to l10n.xwiki.org to detect when translations keys are being moved across files.


Do not change the code or the PR because of those remarks. Just keep them in mind for future modifications.


Integer_
{ parser (({Dropbox.createChooseButton (options); =
Var


ModifyTimeBinsToUseRounding (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (888 of 888 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.58%25-green.svg)


I think I just need to learn how to use forked repo :) I didn't mean to commit that to pull request. Will try to create another pull request.


@code2be @addyosmani I agree. And probably the starter kit is not the right place for it as people not using the starter kit would not benefit from it.


Yes, that's the reason. And to replace the CIR. We just should look for an approach that is more advanced. If it is planned to have it in the release 2.0 we should schedule a workshop about it. If not then we should imo mention that it will be added in the next release and move this draft to a branch.


Comment for future reference: If all you're logging is the exception message (and no custom text), `logging.exception` is a useful helper for capturing info about the problem.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20250/testReport/) for this commit**


Thank you for fixing these so fast! Hope you are ok with me adding all these issues :)


yes, those classes are deleted in later commits.


You're right. :-)


Solid! That's obviously a bug. Thanks for the catch!


No sería borrar?


Would it be possible to put the shadow sample2D into the light struct itself?


Since supporting of old CPU is not need it would be fine to use fast a20 gate (see http://wiki.osdev.org/A20#Fast_A20_Gate ).


package.mo will be there for sure


Technically this will give a message box for every single user who failed to save. I'm not going to worry about that right now, because if they hit this branch at all, they're already pretty well hosed.


rename section


'CURL must be enabled to use the OutgoingRequest class.' - Needs renaming here too?


@wilhen01 @thomasnymand . Hey I was not thinking of getting rid of the  preview panel, just the little green margin control on the side.  I do need a better way to collect bugs.. If anyone has suggestions :)


i originally just streamed targetCoverages (which is flat), but this gives the coverages in the order given by HashedListTargetCollection, which is lexicographical and may not be in the same order as the segments.  there might be a nicer way than nested streams, but it's not obvious to me.


replace by macro


thanks, didn't realize this!


It's not automated but you have a tools to move translations (which we did several times already). See http://l10n.xwiki.org/xwiki/bin/view/L10N/Refactoring#HMoveakey.


prova


I'm getting the following error console message on the login pages and `step=new_pass_form` page...

    Failed to load resource: the server responded with a status of 404 (Not Found)
    http://www.textpattern.dev/textpattern/vendors/dropbox/zxcvbn/zxcvbn.js.map


log


Catching up `SensorsError` should be enough.


@mrclay is there a better way to do this in Elgg 1.11+?


Ah, well. I would have expected that the "unused" check would be restricted to the function scope, but let's not bother too much about this and play safe. I'm fine with the current code then.


Here i added a function that counts the amount of bricks broken by the ball. I also relocated the position of where the ball starts off from after you die.


Can you alter this to *.js? Like that all the scripts will be minified.


Why not call it district?


Ca aurait pas été le moment de faire un follow service ? Parce que dans eventMinCtrl, ça ne me semble quand même pas top.


I will add this


where   can I find ?TAT


The why: http://askubuntu.com/questions/694510/invalid-argument-error-in-httptunnel-client/694568


What's Builder Pattern? Do I need to change to that pattern?


This is not, it can be removed.


WRONG


was it really that easy, im disappointed


Context: https://talk.jekyllrb.com/t/deprecation-warning-ruby-2-2/1475

Thanks @gynter for pointing this out 👍🏻


yes, I intended to make that change... needs to happen before this replaces the existing PR


issue created #348


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20251/testReport/) for this commit**


Small thing but `upload size` is a bit misleading


@pkdash we need this part to write the "ExecutedBy" metadata term in the resourcemetadata.xml file once the resource is created. Once the resource is create, maybe the user will not specify a specific model program resource that is used for executing the Model Instance. At this point the "ExecutedBy" term is not available yet for this resource. Without this 'else' part you will not find any information about "ExecutedBy" term in the  resourcemetadata.xml in that case.


Done


eww


Should we consider automatically injecting that via `setEvaluationContext` on `Expression` typed properties within any `@ConfigurationProperties`?


This might be confusing as there's the concept of an `organisation_admin` too.


I'm going to go ahead and merge this, after sleeping on it, it makes sense.


here!


here


Yes, I think it would be nice. And what do you think about something like "last call" warning to show only conferences with 2-3 days to the C4P end?


done


These extraneous <g> nodes seem to be from copy/pasting existing items from another drawing or a base simple drawing.  They aren't a problem except when you try to parse these into a font.  I was originally removing these while doing font-icon stuff, but I just handled it on the font generation side because I can't rely on people not doing it.


A couple nits.

1) The whitespace between the key and the value is not optional, but the comment says it is.

2) On the previous commit you said: `we're matching <hexkey><optional whitespace><optional value>`. The value group here is not optional. The constructor of `AmendmentTableImpl` checks for an empty value, implying it can be empty. I'm OK making this mandatory in in the config, I just want to make sure it's coded as intended.

3) Nit: The `(?:\\s+)` can be more simply written as just `\\s+`.

4) Nit: I like this one-line-with-a-comment style for complex regex (and had not seen it before now). For simple groups separated by white space like this regex, I think `R"(^\s*([a-fA-F0-9]{64})\s+(\S+))"` with a comment `<hex amendment ID> <value>` is less noisy. But I'm OK either way.


issue created #349


Hmm, I guess?


I guess you could separate out the lights into MAX_POINT_LIGHTS and MAX_POINT_LIGHTS_WITH_SHADOWS and then have two structs, one for the ones with shadows and one for the lights without shadows.  Somewhat messy, but likely fast and efficient.


<source id="chocolatey" value="https://chocolatey.org/api/v2/" disabled="true" priority="0" />
The last part priority="0" could/should be a parameter for this defined type, if I look at the code you can't set the priority now. BTW, any timeline on putting this in? Currently the sources and the failonautouninstaller parameter are the reasons we still have a small chocolatey_client module (using a template) ourselves and we're keen on deprecating it and fully using the official chocolatey puppet module.


Awesome solution for a problem I noticed a number of students having!


I'm not saying any of this is a good idea, the limitations of glsl are pretty brutal.


Thanks.  I will apply this patch.


Maybe stick with what you have for now, if it works and isn't slow, that is probably good enough? :)


I believe the EC is not part of the Expression, but set at `getValue()` time.
Or can it (in which case your proposal would nicely simplify things)


Yes, and it doesn't go away, just because techniques advance.
What's a "semantical website" anyway? Does it refer to certain W3C standards? How do you define that?

Search Engines understand javascript and it's trivial for people building their own ones to use tooling that can interpret what's on a page (e.g. http://www.nightmarejs.org/)

It doesn't need to keep an open connection to somewhere - depends on the app.
The "Single Page App" served before was hosted on github as a normal github page, so no special server required.


How is `require_2sv` being set here if it's only `build`ing the users? Setting `require_2sv` based on admin or superadmin is a `before_save` callback.


in `SpelExpression`:

```	/**
	 * Set the evaluation context that will be used if none is specified on an evaluation call.
	 * @param evaluationContext the evaluation context to use
	 */
	public void setEvaluationContext(EvaluationContext evaluationContext) {
		this.evaluationContext = evaluationContext;
	}```


You're already in your `db` folder, so you can actually just write: `require_relative 'connection'`

Note that I didn't include the file extension.


This should still be based on `require_2sv`, not just on the role. It should be possible to force 2SV off for an admin/superadmin user.


Can I move all the keys at once (e.g. by specifying only the source/target application/name and not the key) or do I have to more the keys one by one?


Yeah we do accept italic as soon as a font with the file name `family-Italic.ttf` is bundled or present as a system font.


notified?


Yep, discovered that. I guess I always manipulated the interface.
Will issue a PR


I didn't notice performance loss. It's just a feelings thing 😁


Not that I can think of. :(


```
$ ./run_conflict_test.sh
Apache Jackrabbit Oak 1.4-SNAPSHOT
# IndexConflictsProvokingTes       C     min     10%     50%     90%     max       N
Oak-Mongo                          2       4     339    1929   60348   60623      19
Cluster Size: 3
Nodes created: 1003
Conflicts: 210
Exceptions thrown:
  class javax.jcr.ItemExistsException: 194
  class javax.jcr.InvalidItemStateException: 6

# IndexConflictsNonProvoking       C     min     10%     50%     90%     max       N
Oak-Mongo                          2       1       2     362    2981    3191     146
Cluster Size: 3
Nodes created: 4450
Conflicts: 79
Exceptions thrown:
  class javax.jcr.ItemExistsException: 3037
  class javax.jcr.InvalidItemStateException: 13
```


Now that using the Lexik maintenance bundle is optional, we need our own `ServiceUnavailableException`.


useless space after function


You can indicate all the keys to move as JSON. The is no wildcard support, they have to all be listed.


Yes, they are useful, thanks! I will just close the ones which I consider too bloated.

For some time I wanted to do the vimtutor with vis and see what compatibility issues come up. Maybe you could give it a try?


god dammit


What for? We're never throwing it


mother fucker


Good use of an array to create multiple AR objects in one command.


so ${mw.managers.distributedmw.osgi.version} works, you have to add mw.managers.distributedmw.osgi to the dependencies of the project (in the pom). Make sure the version is defined in the partent pom where it proceeds.


More specifically, we don't really want to treat 'italic' and 'Italic' (or
'bold'/'Bold') add two separate fonts. These should resolve to the same on
JS but I don't know about file naming on devices. Is it consistently upper
or lower case? Should we be looking for filenames with both?

On Friday, November 6, 2015, Karim Naaji <notifications@github.com> wrote:

> Yeah we do accept italic as soon as a font with the file name
> family-Italic.ttf is bundled or present as a system font.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tangrams/tangram-docs/commit/9bbf1394ef927d3a4cbdac0113bd8b0c0e961048#commitcomment-14243448>
> .
>


Shouldn't the address need the `.com` suffix i.e. `https://source.example.com/source-db`?


@pkdash I do not think that we have database table field for it as it is not defined the at the attributes or fields of the "ModelInput" metadata term. I just defined "warmupPeriodType" here to use with the get_xml function. The target of that, to show the type of the warm-up value as we do for rainfall time, routing t, and simulation time step values:

-<hsterms:ModelInput>

-<rdf:Description>

<hsterms:warmupPeriodType>Year</hsterms:warmupPeriodType>

<hsterms:warmupPeriodValue>5</hsterms:warmupPeriodValue>

<hsterms:rainfallTimeStepType>Daily</hsterms:rainfallTimeStepType>

<hsterms:rainfallTimeStepValue>1</hsterms:rainfallTimeStepValue>

<hsterms:routingTimeStepType>Daily</hsterms:routingTimeStepType>

<hsterms:routingTimeStepValue>1</hsterms:routingTimeStepValue>

<hsterms:simulationTimeStepType>Hourly</hsterms:simulationTimeStepType>

<hsterms:simulationTimeStepValue>1</hsterms:simulationTimeStepValue>

</rdf:Description>

</hsterms:ModelInput>


I actually need to set the style on the select-control div. Will do a PR.


Should be tunnel_in_setsockopts as in patch at: https://bugs.launchpad.net/ubuntu/+source/httptunnel/+bug/1443660


That is a pretty bad ass example:
http://jsfiddle.net/wgwoqncy/5/

What is causing the bright ring around the sphere in the jsfiddle you posted?

I removed the bias adjustment and got rid of the bright ring around the sphere:

![image](https://cloud.githubusercontent.com/assets/588541/11000214/63e3bd44-846e-11e5-82f5-328673883cdb.png)

This looks better:

http://jsfiddle.net/wgwoqncy/6/


Ok. Will keep it at that. Die 1.x, die!


@janhahne My mistake here. If you move the following two lines
```
(unittest) run
/unittest using
```

up to right after the docstring, then `exit_test_gracefully` will be available and should be used.


If you remove it, you either have to remove the respective unit tests (exception converter and pretty error screen listener) or you have to add the Lexik bundle as dev requirement. Both sucks.


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 135](http://teamcity.corp.dirigodev.com/viewLog.html?buildId=1646&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 6 Build time: 00:01:12


It's a bit of work to build the JSON but doable. Thanks.


I'm seeing a bit of acne on the back of the sphere with a few different settings:

![image](https://cloud.githubusercontent.com/assets/588541/11000290/d40fcbc6-846e-11e5-9552-425f666e3f71.png)

I wonder if one needs to use shadow maps on the surfaces facing away from a light in most cases -- because the light's shadow is already accounted for in the dotNL.


I actually started doing this originally, but removed it for whatever reason


@kshefchek Thanks for the information. I've removed the added orthologList and paralogList since geneList contians them already.


Why do we need these symlinks? This breaks `make install` with some versions of cmake.

```
CMake Error at CMake/HPHPFunctions.cmake:221 (file):
  file COPY cannot duplicate symlink
  "/tmp/tmp.WOp8Ra1bc5/third-party/mcrouter/src/mcrouter/lib/network/CaretSerializedMessage.h"
  at
  "/tmp/tmp.qzoEW01KTz/usr/include/hphp/third-party/mcrouter/src/mcrouter/lib/network/CaretSerializedMessage.h".
Call Stack (most recent call first):
  third-party/cmake_install.cmake:117 (HHVM_INSTALL_HEADERS)
  cmake_install.cmake:101 (include)
```

```
$ cmake --version
cmake version 3.0.2
```


黒七味は行けそうな気がする


actually it works fine! I'll send you a video on twitter


Also the only preview-specific behaviour is the auto flagging of promoted users. The behaviour of the `require_2sv` flag doesn't change.


Could this `unless` be change to an `if` condition, i.e. `if Puppet::PUPPETVERSION.to_i < 4`? I think it would be easier to understand.


Nice!


Can you please keep the `require`s sorted alphabetically?


@tomfulton I'm hoping I have found the fix by adding a listener for readystatechange. My theory is that sometimes the init of the iFrame runs between DOMready and Load events. Which means the CSS hasn't finished loading. This should trigger a resize once the CSS has finished rendering.

I've checked the fix into the dev branch and would be grateful if you could give it a try.


rekt xD


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20252/testReport/) for this commit**


I believe this one should be `$idleDetectionEnabled`.


Oops - not sure how this worked in my testing.  Thanks.


Also reported as an issue : https://jira.ez.no/browse/EZP-25066


Sure!


This causes unbalanced parenthesis, which breaks the package.


Did you read this?

http://forum.xda-developers.com/showpost.php?p=63685307&postcount=187


We've just encountered `g_assert(_check_free_space(self, size))` in PE at postmortem core file analysis. We recommend patching this in both OSE and PE to log the error, and only then abort. It could save developer time used for debugging.


whoops, sorry! I'll fix it now


From what I've seen so far, it seems to be consistently 'Italic', 'Bold', first letter uppercase. We should treat `italic` as `Italic` though, since it's directly fed from the stylesheet right now.


Yes, I have really wondered why the assertion has ever been set to 0.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20253/testReport/) for this commit**


typos here?  Should be SAUCE_*


Rename according to naming style


Thanks. I was about to craft a PR, but I'll let you take care of it since I don't even have a fork yet.


Ok that's opposite of what I thought! Let's add either a check for both, or
transform to capitalized please. Thanks!

On Friday, November 6, 2015, Karim Naaji <notifications@github.com> wrote:

> From what I've seen so far, it seems to be consistently 'Italic', 'Bold',
> first letter uppercase. We should treat italic as Italic though, since
> it's directly fed from the stylesheet right now.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tangrams/tangram-docs/commit/9bbf1394ef927d3a4cbdac0113bd8b0c0e961048#commitcomment-14243773>
> .
>


I think adding it as dev would be totally ok, same as Composer. Did you add the `suggests` btw?


done


@mkomitee 2150274


This broke zeromq http://hydra.nixos.org/build/27430184


log


Great. Vimtutor Is a good idea. I will do that this weekend and give feedback if i find any wrongs.


I'd suggest to use local non-final variable instead of four '= null' statements


I know @gdelhumeau script it last time he had to do this, me you can stole something from him


It's good now, thanks for the _incredibly quick_ response & all your work.


@KindDragon Maybe add a comment here so we know why the test behaves differently in these versions
```
The reason for reporting 1 leak at this point is that the vld_dll1 module build with <VS2013 calls internally
HeapDestroy when it unloads and the leak is either
 - reported automatically by VLD when the Heap is destroyed if VLD_OPT_SKIP_HEAPFREE_LEAKS was specified or
 - ignored since the destroyed Heap was removed from VLD heap map.
```

Ideally for me we should save the HeapDetroy leaks and report them together with all other leaks so the test would be consistent. The only difference would be that these leaks will not have a memory dump as it is unavailable at this point.


it should be a service!


Same as above


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20254/testReport/) for this commit**


The spec is really saying that you should be able to create an MD that spans all of memory, and the underlying implementation needs to do what it has to in order to support this. This code is no longer needed for any P4 implementation of which I am aware, so removing it seems like a good idea.


yep


`Seeh` typo?


`.example` is a [reserved TLD](https://en.wikipedia.org/wiki/.example) for documentation purposes.
`example.com` is also, so we could update if you prefer.


'/users/geographicPoint ' should be '/users/geographicPoint' (without space at the end)
There is two others like this after


@mkomitee Thank you. I'm glad you find it useful


done


PWM_Sysfs(uint8_t chip, uint8_t channel)


Like...
```
var x = new Object()
    .setX(1)
    .setY(2)
    .setZ(3);
```
as opposed to:
```
var x = new Object();
x.setX(1);
x.setY(2);
x.setZ(3);
```
I don't think that's applicable here, the methods return void anyways


I put priority of the current test to -2, because I still hope for better tries.


Out of curiosity, why is the ID needed?


Thanks! And thank you for sharing the improvement you did!

I'm sorry again for contact you on a commit page.


After clarification with Reema, it seems the trello story was off-base so this behaviour is being dropped/simplified now anyway.


@darkwing - do you remember which exception we're passing on this? I'd like to catch a more specific exception here.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20255/testReport/) for this commit**


I don't, this was a very long time ago.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20256/testReport/) for this commit**


No obligations through.


It would have been a problem with pyquery parsing


it probably should be in a service


teste


@rohanryan This seems to be very cautious. SF has a very low effective branching factor. I would suggest to start with 1/3 or 1/4 of the time. But an iteresting idea. You need to update your master branch in any case.


@sergeylaptev Yep.. I had the first at first but I don't like because I want to keep the constructor clean and not pollute so this way the adding the bind when setting up the props solve that.

Second option is the ideal and preferred one but Babel 6.0 haven't fix a bug related to when defining a property with arrow func inside the class definition


should be fixes #1


this function makes useless things: why don't you directly push trackIds to the localStorage?
Btw, it should probably not be pushed to the localstorage but keeped in a service.


> The last part priority="0" could/should be a parameter for this defined type

Agreed, the only issue is that priority can only be set in choco 0.9.9.9+, so we need to check the version. However defined types would rely on facts to do this. Stick with me for a minute and you will understand the dilemma.

Defined types are compiled on the master, which also require facts from the agent. Before Chocolatey is installed, the chocolateyversion == 0, so priority would be excluded the first time through. The second time through when the agent has sent the updated fact to the master it would then be the actual version and the defined type can adjust the command accordingly.

Defined types are great for the most part, but we are going to need to change this to a custom type/provider so that it will be run on the agent, which will be able to detect the new chocolatey install on the first convergence (first run of Puppet that would also install Chocolatey).

Keep in mind you are commenting on something that is not yet released and still in progress in a pull request. So expect wild changes until it gets merged back into master.


@purbon, @enebo, thought you might be interested, I've now converted my rpextras.jar (JRubyArt extension) build from rake-compiler to maven. Unfortunately processing libraries are not properly available from maven repository, but perhaps it is interesting to see a work-around?


You don't need to use the `!` symbol when saving. `.save` alone will make sure your changes are saved in the database.

You would include the `!` if the action could return an "exception." That's a topic for a later class, but feel free to google that if you're interested...


change disk geomery installation algorithm!


Looks good !


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20257/testReport/) for this commit**


I assume you know this already, but everyone who uses https://github.com/syl20bnr/spacemacs finds it useful.


> any timeline on putting this in?

Because we'll need to adjust fire and move it to a custom type/provider, I'd expect it to take a bit longer. Look for it by Q1 of next year if not sooner. Most likely it's going to take longer.


I am not sure how the others got added.  I only added the pass_gen.pl  There was a conflict when I did the git stash pop, but I was not aware that the other 2 changes were added.


Let's use Clojure/ClojureScript in user-visible places. CLJ is just hideous.


Babel 6 isn't stable right now, I personally recommend use 5 for now


By longer I mean sometime in Q1.


check for using export name


You don't need an `initialize` method in an ActiveRecord class. You also don't need `attr_accessor` because ActiveRecord automatically makes each property readable and writeable!


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20258/testReport/) for this commit**


name should filterSignaledTracks


* Also relocated unzipping function elsewhere to make function organization more logical


I'd change this to Clojure/ClojureScript as well.


Just FYI, this just overrides the line above it ;)


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 48](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=436&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


is there a way to get around the limitation highlighted with having multiple lines in a single row.  Is there a method i could override to try and improve the ability of the code to identify rows with multiple lines.


Would be nice if we could avoid hardcoding the name SURFconext and the URL and instead make them config variables.


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 48](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=436&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **SUCCESS**
Summary: Running Build time: 00:00:50


The problem is that this comes from the same function that's used to produce the mode-line string. So it needs to be kept short.


There is unfortunately a lot of room for ambiguity in this domain, because of two subtly different concepts:
* Districted Events (an Event which is associated to a DistrictFieldValue) vs Districted Event Signups (an Event Signup which is associated to a DistrictFieldValue)
* District Fields (which is the platonic concept for a district, e.g. "Congressional District" as a concept) and District Field Values (which are the list of available values for a district, e.g. "Congressional District 003")

There are good names in the VAN data model to disambiguate these concepts, which I've used above.  In order to prevent any confusion while communicating with developers, I think it's helpful to reduce redundancy in naming unless it's really necessary; in this case, I think providing "externally friendly" names is not really all that valuable, and certainly less valuable than clarity in communication.

So TLDR: I took the name from the VAN data model because that is the clearest way to make sure that third-party developers, and internal developers, are on the same page.


fzahle, can you try this version of the SqliteRecorder?
https://github.com/hschilling/OpenMDAO/blob/parallel_recording_sqlite/openmdao/recorders/sqlite_recorder.py
Thanks!


very tasty.  One more change we should consider is how to manage volumes for user data.
We'd like to have all user actions (conda and pip installs, data downloads etc) occur in volume mounted space.  Looks like there are two methods.
1. Volume Container mounted into jupyter container
http://stackoverflow.com/questions/20856385/how-can-i-make-a-host-directory-mount-with-the-container-directorys-contents
Then we install our conda env into the volume container and mount from it.  To save user workspace we docker save the volume container.
2.  Or install python2 stuff at container build in
CONDA_ENVS=/home/$NB_USER/envs
And either
  a. use .condarc to look in
      ~/work/envs (mounted in), then ~/envs then /opt/conda/ (baked into container)
or
  b. copy everything in ~/envs from buildtime to ~/work/envs at runtime and switch to this as the active  conada env as part of the entrypoint /cmd startup.

Then all user work would survive jupyter container crashes/relocations because it is on the hard-drive and we avoid running out of btrfs volume space.


ugh... my bad. I don't know where I saw uint16_t.


Can we make this optional to build with gucharmap/mucharmap?
I don't want to include a death package in fedora again, only for maybe 1 year when we probably switch to gtk3.
Also, i build it with gucharmap for gtk3.

Thank you


Can you please add a test for this case, i.e. that an exception is raised if EPP templates are validated in Puppet versions below 4?


It is already cached in PWM_Sysfs.


Can you please add tests for the logic here?


Yea this would be nice to have. See a discussion on the [mesos users mailing list](http://mail-archives.apache.org/mod_mbox/mesos-user/201511.mbox/%3CCAEtyV3j_eEBOBUdESpoyezrqkJy2BBGi8i2z94V88LuPy6EXxQ@mail.gmail.com%3E).


Yeah isn't but it's working fine at most part that way I can keep forward approach and won't need to change much down the road. they are moving/fixing stuff fast though so I hope soon will be good.


:+1: checked generic_error cant be null so no issue of bombing


Take a look at the content of `add_tenant`. Does it serve any purpose anymore? If you're going to keep it, how would you need to refactor it so that it adds a tenant to an apartment in the database?


Ditto what I said about `attr_accessor` and `initialize` in my `apartment.rb` comments.


done


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3939](https://teamcity.mesosphere.io/viewLog.html?buildId=69550&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:11:28


I'm totally lost, so you **allow** by _add**Dis**allowedApplication_ ?


I am unable to execute ant -f build-swellrt.xml dist-swellrt-android
I am getting
BUILD FAILED
Target "dist-swellrt-android" does not exist in the project "SwellRT".

Please advise.
Looking forward for a prompt response


Greetings! I'm in the process of overhauling this repo to bring things up to date in various ways. I just redacted any credentials from the commit history on master, which allowed me to make this a public repo now (no more oauth tokens!). I was then upgrading this to be compatible with django 1.8 and noticed this branch existed.

I went ahead and duplicated your efforts here on my branch "upgrade" which was created from the "new" master after the redactions. This will save the trouble of having to do a careful rebase to merge your branch back in.

I should be merging this into master by the end of the day, after which you can just pull from there. Let me or Ben know if you have any questions or concerns.


"Invalid client type" isn't quite accurate to describe the error here, something like "Invalid root path" is more clear.


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/20260/testReport/) for this commit**


GetConfigName()


$errmsg would be undefined.


Looking up a user by ID should probably only return a single user, not an array of users with 0 or 1 elements.


ModifyTimeBinsToUseRounding (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1426 of 1426 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.41%25-green.svg)


Can you at least print out when it happens and where it happened?

It's kind of a big deal to me, and I'm sure many others when lossless is suddenly lossy...


@MarkEWaite I've added the unit test.  Without my changes the test fails on Windows on CliGitAPI implementation and passes on JGitAPI implementation.  With my changes it passes on both implementations.


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 69](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=437&buildTypeId=XbimEssentials_XbimEssentials) is now running


TeamCity Xbim :: Xbim Essentials :: XbimEssentials [Build 69](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=437&buildTypeId=XbimEssentials_XbimEssentials) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:10


Should this read "exception"?


Yep, Tom spotted that one, I fixed it in 6392530


Change `(?:(?:\\u)|(?:\\x))` to `\\[ux]`.


performance~~s~~


Closes #2


Let's log the actual exception message as well - $e->getMessage().


@heplesser

Thanks. I also adapted this for the other two gap junction unit tests.


data retention issue, no?


No, it's fine, just checking.


No but thanks for asking. I'm relatively new to git and gitHub and I'm trying to put up some resources for students to use. I meant to delete the cards array as it is incomplete. My apologies for the inconvenience.


intention was to uncomment this slide images so that it stops making a request for this images at every reload in development


style: should be numberOfRates / 10 and probably should not be an array


why does the wbm_setWorldLink still exist? Shall I remove it? @francesco-romano @traversaro


Done


Line 172 is the TestNet Rules. They're different. Specifically they use a 100-block period instead of 1000-block, can be triggered earlier and have a shorter grace period.


If you don't mind: In two sentences, what is VPack?


done


@pavel-v-chernykh could you verify that this works as intended?


remove


should be ===


Almost the same as https://github.com/mlocati/concrete5/commit/b5b8006661145be14a6a0e6021267173a82d1f5f (included in  https://github.com/concrete5/concrete5/pull/3095)


Marcel is like 2 James Bond?


woops, header incorrect


this is the list i am talking about--> each uni will have a list of students who have **registed to be registered** in the next intake :smile: if that makes sence


Let's log the entire $reference array.


removing some old fixtures


Accidentaly deleted


Justin has back-ported code from the far future ;)


actually, it should be

```
logging.debug('Transferring content from "%s" to "%s"' % (src,
                                                          abs_dest))
```


@matklad :+1: everything works like a charm, thanks


Ah yeah, @TimDix mentioned this issue in the IRC so I put in a quick fix without checking.


This commit looks like it broke our tests:

https://travis-ci.org/gramps-project/gramps/builds/87622862

@romjerome Can you check that?


interesting item, wonder if it relates to issue 1?


ensuring that on /tester we can see the list objects of each university ...