Maybe its time to review the tesb-sam-common feature deps to avoid pax-web-jsp at all?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5459](https://teamcity.mesosphere.io/viewLog.html?buildId=76707&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:07:43


五笔输入法？果断=json？


Small typo on line 9983,
should be
dladdr \


At least pass it as `en_packet const &`.


тогда можно будет
```objc
switch(UI_USER_INTERFACE_IDIOM())
{
case UIUserInterfaceIdiomPad:
  return iPadDPI * scale;
case ...
}
```


>Btw: why we have wdt.alive if we cant use it right :)

We also have a system restart() function, but that does not mean that we must often use it  :)


I cannot check for the signed error. I don't think it's reachable. Before typeck you can't reach it because `-5` is an unsigned integer [according to the const evaluator](https://github.com/oli-obk/rust/blob/8488eebe9cfe169c99d1671e4536ae803e04055f/src/librustc/middle/const_eval.rs#L575-L579). After typeck you can't reach it because typeck prevents the op from occurring.

I'm not sure what would happen if we assumed `-x` to be signed in the const evaluator.


This didn't look correct at all.


Can you `go fmt` your code please?  Go fmt will re-write the above to `if s.readSeconds != 0 {` which is canonical go style


Please use
include <fstree.h> instead of "fstree.h"
This shows your intention better. Your intention is to include header file from external library.
See here:
http://stackoverflow.com/questions/3162030/difference-between-angle-bracket-and-double-quotes-while-including-heade


Cool! You've got familiar with git branching and rebasing!


That should do it for our skeleton task. We still have to figure out some methods. One that will save the data in the local disk, another that adds() a contact and those that restricts the user from blank fields and wrong character entries. We can discuss that in class


Eigentlich müsste es funktionieren, wenn man die Backsticks verdoppelt. Denn so werden die escaped.

> Identifier quote characters can be included within an identifier if you quote the identifier. If the character to be included within the identifier is the same as that used to quote the identifier itself, then you need to double the character.

https://dev.mysql.com/doc/refman/5.7/en/identifiers.html


This will work, but you are right, there are unhandled cases.
Something like: async(if(cond) await(x) else y)
I'll fix it.


Bad stuff. But this is still work in progress.


Yes it did on MySql 5.5.36:

Request 30 sql='ALTER TABLE llx_user_param MODIFY COLUMN value text NOT NULL DEFAULT '';'
**Fout DB_ERROR_1101: ALTER TABLE llx_user_param MODIFY COLUMN value text NOT NULL DEFAULT '';
BLOB/TEXT column 'value' can't have a default value**
Request 31 sql='ALTER TABLE llx_expedition ADD COLUMN import_key varchar(14);'


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5460](https://teamcity.mesosphere.io/viewLog.html?buildId=76709&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:05
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


I don't think moving that is wort it. It would make commits more complicated since they will be changes to the changes. I think it's better to add files in one peace.


You can easily merge this function with `getSubGoalInternal` by just writing `Some(subGoals(i))` here (`Seq` does bounds checking for you).  And please only catch the specific exception that you want to handle (`IndexOutOfBoundsException` then), if you absolutely have to catch them.


Hi @gurneyalex , sorry for disturbing you. I'm not really sure if this commit is the problem. What I'm sure is that from yesterday arrount 16:00 every build is done is runbot goes to "Pending queue", if you force any build it will go to the queue. Could you help us please?
![2015-11-17_10-02-10](https://cloud.githubusercontent.com/assets/8736623/11206971/a2ce61c4-8d12-11e5-8eeb-e2eb33c8319e.png)


We shouldn't be calling the local ship functions. Let the change happen as the server confirms it.

Let's not pretend we have a real client-side prediction system by just mangling the local state.


What about use indexOf() collection method?


Yes, later. Right now it helps if I get the real data.


ブレークポイントおいて確認済かとは思いますが、

https://github.com/aipocom/aipo/blob/master/portlets/schedule/src/main/java/com/aimluck/eip/schedule/ScheduleSelectData.java#L783-L785

のメソッドが呼ばれます。


reviewed-by: me


These files are generated from the `package-info.java` source, if you do not change it there next time there is a build they will get overwritten.


If you enable global CSRF, you have to add the `@csrf.exempt` decorator to *every* view that does form validation, as the UI will break without it (in the case of form timeout).


Может и коммент обновить? Он сейчас не совсем точно отражает на мой взгляд смысл метода. Да и coefficient c опечаткой написано.


OK


Start trash


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5461](https://teamcity.mesosphere.io/viewLog.html?buildId=76710&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:23


Честно говоря я не понял, каким образом эти partials помогут(и улучшат) отображение списка пользователей в виде простой таблички. По описанию их нужно использовать, когда есть общий код для нескольких view, например header, footer и т.д.


s/depricated/deprecated/


You shouldn't create object if you aren't shire that it will be created


s/vmcb_state{/vmcb_state {/


wwwwwwwwwwwwwwww


Out of curiosity, what was the reason for this change? Is there a general benefit, or was the change made for your own specific use case?


Постинг через Iframe криво работал $mdash если `document.body` не загрузился до конца.


- les pointeurs sont obligés à cause de la classe abstraite `Expression`, non? j'ai remplacé par des références où je pouvais mais ça suffit pas apparemment
- si tu veux parler de `List`, `Vector`, et `Set`, je suis complètement d'accord avec toi, c'est pour ça que je suis en train de refaire les trois classes (cf #1 ), j'aurais pu en effet faire une seule et une même classe template mais au final je savais déjà à l'avance que j'allai refaire une ré-implémentation tôt ou tard
- c'est justement pas l'utilité du modifier `const`, de rendre explicite les mutations? Je l'ai foutu dans pas mal d'endroits notamment dans `Expression` et ses enfants, dans `Interpreter`. En gros toutes les expressions sont read-only sauf `InterpreterContext` que l'on peut modifier en l'état, mais qui ne peut pas modifier son parent.


Add a space after the declaration of data type.


Al crear los vectores de selección e inserción, al ser el mismo user y pwd. Está de forma cutre pasando una S o una I y hay que mejorarlo con lo del usuario Inserter y Selector


Hmm, I need to understand better what is happening here... First reaction is : this doesn't look quite right. Looking deeper


Remove an empty line.


This class is a generic class, we should not import any specific class as
import org.openqa.selenium.WebElement;
Please put it to the sub-class.


При использовании `Iframe` постинга json-сдержимое выглядело не как `<body>{...}</body>`, а было обернуто как `<body><pre>{...}</pre></body>`.


There are several nice Scala features that can make this code shorter and more easily readable:

1) You can define an anonymous function as a sequence of cases:
```scala
s map {
  case (formula, label) => formula
  // here there is only one case,
  // but in general you can add futher cases as well
}
```

2) Pairs in scala have projection methods, i.e. `pair._1` returns the first component.
```scala
s map { labelledFormula => labelledFormula._1 }
```

2b) For anonymous functions like in 2), you can also drop the argument name entirely:
```scala
s map { _._1 }
```

3) Just for completeness, you can do it with a `for` expression as well:
```scala
for ((formula, label) <- s) yield formula
```


Please extract method for split string and set fields
For example boolean splitString (String str)
How we can understand  that string contains executed command exactly?


@alonewolfx2
Delay example (arduino model):
switch led on, wait 50 ms (keep this time for yourself) switch led off

Timer example (sming and esp model):
switch led on, 50 ms give this time for others, I am back after 50 ms and switch led off


лучше button type="submit" по html 5


I suposse it's ok too.


это инпут type="file"


вместо дива label а див оборачивает label и инпут, подписи к полям это всегда лейбл


я бы разметил дивами в html вместо таблицы и средствами css сделал бы вид таблицы это более гибко будет


табличной верстки нужно стараться избегать и пользоваться в тех случаях, где явная таблица вида аля excel здесь просто на каждый инпут с лейблом обертка form-wrapper, внутри пишу пример первого инпута - Фамилия: *
<input type="text"  name="lstname" id="lastname" placeholder="Иванов" required> и так далее в подобных  разделах далее


вместо дива внутри fieldset такие заголовки это legend


каждый блок с подчеркиванием можно разметить fieldset


We shouldn't define setters if it isn't required


форма не может тут же закрыться, она закроется после кнопки отправить отзыв


это p


здесь это h1 явно


OK


здесь начинается сначала main потом открывается контейнер отцентровщик который закроется после формы


обернуть пока в див


нужно вынести из списка и поставить перед ul


лого и иконка меню которые идут ниже у тебя после хедера должны находиться внутри хедера


> We don't use {} for single-line if blocks. See CODING_STYLE.

Does the rule also apply to single-statement multi-line blocks like this?


You shouldn't define setters if it isn't required


s/creat fail/vm_create() is failed/.


AFAICT changing the client to automatically send the FQDN option when
the hostname has a domain part will change behavior of already
deployed machines and potentially introduce regressions since DHCP
servers may behave differently when a different option is received.

In my opinion it would be better to leave the hostname option as
default but allow the system administrator to explicitly switch to
FQDN.


Ditto.


Why are you executing the command without any argument?


It depends, because in case of local precompiling it should be under `--save-dev`.


rename the function as test_rsync


> Shouldn't be there a single function that writes the whole fqdn field, that we then just call twice? Otherwise we have two places where we put together the full field.

Yep, I'll change that.


I'm going to move this off into a separate PR to discuss further


This would be more readable if the indents were more consistent. I like the one prop per-line thing - I'd suggest doing that consisently rather than switching around. Also you can move the braces in between new objects onto one line too.

e.g:

```javascript
export const FOO = [{
  prop: 'value',
  prop2: 'value2',
}, {
  prop: 'value',
  prop2: 'value2',
}];
```


Please note that those samplerate tweaks are only for IEC61937.
For "RAW" passthrough, we use the nominal samplerate in the sink (i.e. mostly 48000)


Could you link to the demo page instead and order alphabetically please?

I will then merge the pull request.


@aertmann After our switch to PSR-2 and the addition of .editorconfig files all code is (to be) indented using spaces… so what is missing is a reformat of existing files, IMO.


Теперь очистка файлов работает корректно, и счетчик отрабатывает как надо.

Но ошибка 500 при повторном постинге никуда не делась.
Причем, что я заметил, если повторно постить без скрипта - то выбрасывает на страницу с ошибкой "Вы постите слишком часто". Скорее всего, проблема в функции `html5Submit` на доброчане в том, что страница с ошибкой приходит со статусом 500, и обработчик промиса ее перехватывает

`lastFuncs.reject(new AjaxError(xhr.status, xhr.statusText))`

тупо выкидывая алерт.


For method _convertCoords(), please remove it and call the static method in StringUtils instead.
+	public String[] _convertCoords(String coords) {
+		return StringUtils.extractCoordStringPair(coords);
+	}


Please correct warnings.


Dictionary too big for memory-based spell check. Dictionary not written to be used with disk-based solution


This is an `abstract class`, not a `trait`.


^ вместо того, чтобы обрабатывать как `lastFuncs.resolve({done: true, data: $DOM(xhr.responseText)}` и брать оттуда текст ошибки.


ERROR 404 when i click on the link !


You do not want to use the vmcb.


well that depends on the js linting we want to use, but I think it should be fine.. the .editorconfig came from a PSR-2 change which has nothing to do with other files, although it's been set for all file types


I don't think there's anything wrong with RMD160, though :)


Если постить подряд два поста без скрипта, то при втором постинге ханабира на странице с ошибкой предлагает более сложную капчу.


fixes #1


Looks like deprecated is consistently mispelt as 'DEPRICATED'.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5462](https://teamcity.mesosphere.io/viewLog.html?buildId=76711&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:28


Thanks for reply anyways!

And thanks for the work!


Merging L118-L119 into a line.
} else if(vm_head == vm) {


В этом разделе есть подпункт 3.4.5 Rendering Collections, на который ссылался Юра (но у него подпункта нет якоря). Так говориться о шаблонах для рендеринга коллекций однотипных объектов.


I'd split this up. At the first glance it looks like something was being assigned to `str` as well.


OK pour tertiaire et Empêche


An abstract class that does not contain any methods doesn't really serve any purpose.

I think a good idea for the type hierarchy is the following:
```scala
trait Tactical {
  def apply(proofState: ProofState): Option[ProofState]
}

trait Tactic extends Tactical {
  def apply(goal: OpenAssumption): Option[LKProof]

  override def apply(
    proofState: ProofState): Option[ProofState] = ...
}
```


where is the license?


"fixed"


Can you perhaps not revert this and just add it to the failing test section?


*For our future us:*

This is much more convenient because instead of `acc.accumulators[acquisition].items` it is enough to do `acc.items[acquisition]`. On the other hand, it makes me a little nervous because if the objects which store the data in `Accumulate` coroutine, whatever they may be in the future, change their location in memory the reference becomes invalid here after an experiment run. We could implement the `__getattr__` but I don't really want to build a dictionary on-the-fly or switch back to the more complicated notation or *be very careful when implementing new accumulation data storage*.


TeamCity TripleA :: UnitTest [Build 82](http://188.177.191.210/viewLog.html?buildId=146&buildTypeId=TripleA_UnitTest&guest=1) is now running


TeamCity TripleA :: UnitTest [Build 82](http://188.177.191.210/viewLog.html?buildId=146&buildTypeId=TripleA_UnitTest&guest=1) outcome was **FAILURE**
Summary: Compilation error: Software\TripleA\CashRegister\CashRegister.csproj (new); number of tests is too small: 0 (new) Build time: 00:00:06


Can you also remove the extra whitespace ?


Хм. Нифига. Вот ответ от сервера.

```html
<html>
<head><title>500 Internal Server Error</title></head>
<body bgcolor="white">
<center><h1>500 Internal Server Error</h1></center>
<hr><center>nginx/0.8.42</center>
</body>
</html>
```

А должна выскакивать страница с предложением сложной капчи.


I'm not found of rewriting such recursive method:
```java

    @Override
    public String toString()
    {
        StringBuilder sb = new StringBuilder(32 + (size() << 4));
        sb.append("{");
        int count = 0;
        for (Map.Entry<String, JsonNode> en : _children.entrySet()) {
            if (count > 0) {
                sb.append(",");
            }
            ++count;
            TextNode.appendQuoted(sb, en.getKey());
            sb.append(':');
            sb.append(en.getValue().toString());
        }
        sb.append("}");
        return sb.toString();
    }
```


TeamCity TripleA :: UnitTest [Build 83](http://188.177.191.210/viewLog.html?buildId=147&buildTypeId=TripleA_UnitTest&guest=1) is now running


Agree


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5463](https://teamcity.mesosphere.io/viewLog.html?buildId=76712&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:08:19


TeamCity TripleA :: UnitTest [Build 83](http://188.177.191.210/viewLog.html?buildId=147&buildTypeId=TripleA_UnitTest&guest=1) outcome was **FAILURE**
Summary: Tests passed: 52; number of inspection errors is too large: 32 (new) Build time: 00:00:31


TeamCity TripleA :: UnitTest [Build 84](http://188.177.191.210/viewLog.html?buildId=148&buildTypeId=TripleA_UnitTest&guest=1) is now running


TeamCity TripleA :: UnitTest [Build 84](http://188.177.191.210/viewLog.html?buildId=148&buildTypeId=TripleA_UnitTest&guest=1) outcome was **FAILURE**
Summary: Tests passed: 52; number of inspection errors is too large: 32 Build time: 00:00:29


@borshop: retry


Looks good.


probably an attempt to solve a circular dependency problem; however it would be good we have no circular dependencies between parameter objects so using lazy should not be needed to "fix" them.


would love to get osg comments in our osg file, even if just a copy/paste
like https://github.com/openscenegraph/osg/blob/master/include/osgUtil/RenderBin#L27-L32


where is the license?


Ok, I will investigate further


@borshop: merge


What is the return type of getParameters ?


I think the other changes should have fixed the circular dependency, so lazy is not needed here


this is the test comment


qweqweqweqe


I think you want to use `self.request.validated`.


wenn du es getestet hast und dir die arbeit machen willst für leute die in spaltennamen/tabellennamen backticks verwenden, kannst du dafür gerne das escaping einbauen.

ich würde der einfachheit halber das zeichen verbieten (d.h. exception werfen wenn enthalten)


dari sini
https://github.com/codeigniter-id/codeigniter-id.github.io/blob/master/app/teams/teams.controller.js#L16
ambil dari dari parameter **url** tiap kontributir
misalnya https://api.github.com/users/puterakahfi maka disana bisa ambil data **company**, **name** etc
atau ada cara lain?


It doesn't look like a major problem right now. I'm sure there are many other bugs left, so let's see the reaction of users.


ObjectNode


qwe


qwewqeqe


Why is it necessary to get the password in `utf-8`? Isn't everything already in utf-8?


dickysa


Done.


looks good (but also yuck that we have to do this)


You could use a validator to check if an email is already used:
http://cornice.readthedocs.org/en/latest/validation.html#validation-using-custom-callables


bin 0 is a valid bin number so here we want to test === undefined I think


saw approval from lukebakken
at https://github.com/basho/riak_pipe/commit/be9a36418cbc3b193448abee3c72405b54834713


merging basho/riak_pipe/fix/az/riak_pipe_exec_option_type = be9a3641 into borshop-integration-102-fix/az/riak_pipe_exec_option_type


basho/riak_pipe/fix/az/riak_pipe_exec_option_type = be9a3641 merged ok, testing candidate = 19eeae7d


También se agrego el de comentarios https://github.com/Informante/api/commit/9c4848b76f653f519edd323625b794f07bdd1cdf


Good Job you have a great  future God willing ,and will get all full mark  for all subject , you are very luxury men,and breakout star help people .God blesses .
SalwaGafour


That's ok then, if it's jackson API.

On Tue, Nov 17, 2015 at 10:35 AM, aduprat <notifications@github.com> wrote:

> ObjectNode
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/aduprat/james-project/commit/fe4f1fefcde29875b845d1cf206b4732d5308e6c#commitcomment-14437725>
> .
>


лол. оптимизация что ли такая, проверки на null убрать?


Test


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5464](https://teamcity.mesosphere.io/viewLog.html?buildId=76717&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 176 Build time: 00:04:25


@pmlopes ok got it, I'm fixing this


TeamCity pull requests :: netty [Build 673](https://garage.netty.io/teamcity/viewLog.html?buildId=3312&buildTypeId=pulls_netty&guest=1) is now running


Well, good point, but we're not using `openMenuOffset` any more.
Also, I'm trying to get your point with `width: this.props.openMenuOffset`. Why should it be openMenuOffset? Menu should be a 100% as I think (because you can keep moving side menu almost to the end of the screen if you're using gestures)


isn't bin is an object ?


TeamCity TripleA :: UnitTest [Build 85](http://188.177.191.210/viewLog.html?buildId=149&buildTypeId=TripleA_UnitTest&guest=1) is now running


Not sure if we do create each frame the renderbin ?


Пробовал отключить опции `Возможность отправки одинаковых картинок`,
`Удалять EXIF из JPEG`,`Удалять имя файлов`. То же самое.


TeamCity TripleA :: UnitTest [Build 85](http://188.177.191.210/viewLog.html?buildId=149&buildTypeId=TripleA_UnitTest&guest=1) outcome was **FAILURE**
Summary: Tests passed: 52; number of inspection errors is too large: 32 Build time: 00:00:30


Well, your front view you can customize without this.


Можно создать partial с одной строкой таблицы в `users/_user.html.erb` и потом сделать `render @users` вместо цикла


Propably yes. Do you want to send a PR?


The same for the menu: you can customize it without this prop


You also committed Beta Search with this one :-(
I will remove it from the commit with a rebase


Well, any use case for customizing container?


不用qq的 如果你方便的话 能否把问题用一个小的demo重现出来，方便我调试


Code looks fine to me, even so I think these null checks could be prevented by using some fancy JDK8 feature, but that's another topic I think.


TeamCity TripleA :: UnitTest [Build 86](http://188.177.191.210/viewLog.html?buildId=150&buildTypeId=TripleA_UnitTest&guest=1) is now running


This one may be a good one


It is indented by the `:` signs. So i'm guessing in this case it should get 4 spaces instead? changed to that.


TeamCity TripleA :: UnitTest [Build 86](http://188.177.191.210/viewLog.html?buildId=150&buildTypeId=TripleA_UnitTest&guest=1) outcome was **FAILURE**
Summary: Tests passed: 52; number of inspection errors is too large: 32 Build time: 00:00:28


Do not use the unnecesary variable.
- Please remove vmcb.


Ditto.


changes are located on 757d54f651e9ae7ab770a4972f59e65fef353997


requires dev/build flush @maent45


Looks good, can we promisify (http://bluebirdjs.com/docs/api/promisification.html) bcrypt and return a promise from comparePassword? Also could we rename it to checkPassword (to me, compare implies passing two values)?


(It's not clear what `label` is supposed to be here, I guess it's the label for the formula the tactic should operate on?)

In any case, I don't think this is a practical interface for tactics.  If we have tactics as objects, then the main thing we want to do with them is pass them to the tactics prover, so it can apply them one after another.

If the tactic doesn't already know about the label it should operate on, then this requires that you tell the tactics prover (and all combinators) about the label separately.  This would probably look like this:
```scala
use(OrLeftTactic, "some_label")
repeat(OrLeftTactic, "some_label")
(OrLeftTactic, "some_label") then (OrLeftTactic, "some_label")
```

So instead of working with tactics, you'd need to work with pairs of tactics and labels.  This might even be reasonable, but most tactics require more parameters than just a label (such as terms used to instantiate the quantifiers, more labels, formulas, ...).

By adding the information into the tactic object, it becomes much more convenient to work with them, as you no longer need to work with pairs but just with tactics:
```scala
use(OrLeftTactic("some_label"))
repeat(OrLeftTactic("some_label"))
OrLeftTactic("some_label") then OrLeftTactic("some_label")
```


There should be no whitespace here, maybe that's causing the trouble.


Use @object('user') directly in view
e.g. @object('user')->username


OK


проверка  пользователя поручается бизнес-объекту, объект доступа к данным
отвечает только за сохраняемость и т.д.

2015-11-17 11:39 GMT+02:00 Kuzmenko Alexander <notifications@github.com>:

> лол. оптимизация что ли такая, проверки на null убрать?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kalexi/MailBot/commit/da51b3b191aae09c60d8c0d197e72bd76eeda782#commitcomment-14437826>
> .
>


Please separate line:89 to two lines.
vmcb = (struct vmcb *) malloc(sizeof(struct vmcb))
if (vmcb == NULL)


Если подождать минут десять, то пост проходит — очевидно, в ханабире стоит таймер на частоту постинга. Если постить редко, то предложения ввести более сложную капчу не будет.

То есть, проблема действительно в том, что при HTML5 отправке вместо страницы со сложной капчей приходит 500 Internal Server Error.


What are these TODOs?


Maybe you should add a sql update script which deletes all of these beforehand?


зря исправили тест TEST(TStack, can_split_string_on_tokens) - надо просто сделать 2 теста, старый и новый


all tests pass:
success: http://buildbot.bos1/builders/test-riak_pipe/builds/121


Thank you Jim, you'll be missed !!


where is variable map used?


@borshop: merge


Do you want to call out these params are optional.


if (receiverValue instanceof TransientReceiver || receiverValue instanceof ImplicitReceiver) { ...


ну можем еще продублировать во всех слоях проверку

17 ноября 2015 г., 11:47 пользователь Alena Shramko <shramko.zp@gmail.com>
написал:

> проверка  пользователя поручается бизнес-объекту, объект доступа к данным
> отвечает только за сохраняемость и т.д.
>
> 2015-11-17 11:39 GMT+02:00 Kuzmenko Alexander <notifications@github.com>:
>
>> лол. оптимизация что ли такая, проверки на null убрать?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/kalexi/MailBot/commit/da51b3b191aae09c60d8c0d197e72bd76eeda782#commitcomment-14437826>
>> .
>>
>
>


Please check only the existence of the public folder, we can imagine having several type of public pages (like `my.cozycloud.cc/public/calendar/event_accept.html`) and no index.

Moreover, I dont understand why you want to redirect /apps/ requests to the public side too. I suppose the redirection should be as follow :
`my.cozycloud.cc/apps/foo/  -> /foo/index.html`
`my.cozycloud.cc/public/foo/ -> /foo/public/index.html OR /foo/index.html`
`my.cozycloud.cc/public/foo/bar.html -> /foo/public/bar.html OR /foo/bar.html`


typo in sentence... advisable to *sue* arguments in place of....


Should this really be done here and not in clif?


WrapToNewLine can use Util.join ( "\n", ... )


nothing


Remove this


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=1)


Why discard listings that do not contain lat/long? Is that a remain from when filtering out non-geolocalized listings was done at the input step?


Unfortunately that is not possible right now. I think what we're going to end up with is to move and isolate all nats related stuff into a web worker.

For now this yielding hack is good enough for us.


Please do not catch exceptions.

Exceptions make it very hard to reason about programs--in a way they are a non-local dynamic goto (and "comefrom").  When you throw an exception, you have no idea where you will jump to.  When you catch an exception, you have no idea where it came from.

In this case here, the exception could mean that the tactic doesn't apply, and in this case `None` is the correct return value.  But what if it is due to an error in the tactic implementation, then we don't want to silently ignore the exception, we want to know that something went wrong!


Some non-ascii characters creeping in here. Please \u encode or remove,  ta


TeamCity TripleA :: UnitTest [Build 87](http://188.177.191.210/viewLog.html?buildId=151&buildTypeId=TripleA_UnitTest&guest=1) is now running


Fantastic response time, I thought my change was to my local repo and I didn't even create a ticket yet!


test comment


TeamCity TripleA :: UnitTest [Build 87](http://188.177.191.210/viewLog.html?buildId=151&buildTypeId=TripleA_UnitTest&guest=1) outcome was **FAILURE**
Summary: Tests passed: 52; number of inspection errors is too large: 32 Build time: 00:00:30


I know it's common practice to put `final` modifiers on methods in Java, but in Scala it feels a bit out of place.


TeamCity TripleA :: UnitTest [Build 88](http://188.177.191.210/viewLog.html?buildId=152&buildTypeId=TripleA_UnitTest&guest=1) is now running


Quest with ID


:+1:
may want to consider formatting when there is no middle name.


Nice implementation


TeamCity TripleA :: UnitTest [Build 88](http://188.177.191.210/viewLog.html?buildId=152&buildTypeId=TripleA_UnitTest&guest=1) outcome was **FAILURE**
Summary: Tests passed: 52; number of inspection errors is too large: 32 Build time: 00:00:28


Thanks Damien,

There are a couple of nits I will fix to help;
1. the combo box is not initialised the first time through
2. when you change the setting it does not trigger a metric refresh

I'm happy to fix these up :)

Cheers


啥玩意儿哦


Why would I get warnings as a client here?


ack


Quest with ID
+ you could also add "|| quest_search(quest_id) == &quest_dummy" to this if to avoid duplicate message


The better practive here would be to check if the err is nil, a badly written command can return an error and a message, i would write this like:

```
if err != nil {
  Log.Println("Periodic command failed ", err)
  return
}
if message != "" {
  ...
}
```

I don't like using if/else, else is aways harder to understand.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=2)


@neutraltone ok. pull requested updated #53


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=3)


Order by nearness

you might want to say

Enlisted in order of proximity


Already removed in next commit.


OK


What's up with the weird <<<<<Head, =====, and >>>>>>master that you have in random files?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5465](https://teamcity.mesosphere.io/viewLog.html?buildId=76722&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:43


I don't like that idea very much, packing each line into a source range? That sounds awful. Lots of overhead for a rarely used function.


Odd number of parameters(%d) - pairs of requirements are expected.


@steelbrain Sorry for mentioning you again, but you're the only person I know with solid Atom knowledge.

Do you know if there's any way of not having to pass `atom` here? I tried `var atom = require('atom')`, but the returned object was not the same as the passed one, and didn't contain `atom.views`. I guess it's not a singleton. Just trying to figure out the best to make reusable modules that require Atom APIs.


I'm wary of hard-coding 0.01 in here. I think this should be a parameter which can be passed in (or just 0 as the default... any other number seems a little too much like a magic number)


This breaks browser builds. Might wanna separate "browser" version into another file, e.g. spreadsheets.browser.js?


You're right that doesn't make sense.


Start of POSIX discussion


5225_tmains (nmerket) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


End POSIX discussion


if blocksonly=1 and whitelisted=1 and whitelistalwaysrelay=1 then we want to relay the transaction, but not call AcceptToMemoryPool

but actually thinking about it this wouldn't work either since this just sends an inv and then we wouldn't have the transaction to respond with


just drop it


How would you feel about creating a flattenArray function? Not a big deal if you don't want to, but on my first two passes reading this, I thought these lines were pretty complicated and they took away my focus from the main logic


TeamCity LabkeyRelease15.3 :: CDS postgres 9.4 [Build 13](https://teamcity.labkey.org/viewLog.html?buildId=285823&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 19 (2 new), passed: 8 Build time: 00:47:25
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

##### there are 9 more failed tests, see build details
```


imnotsureilikethis


nit space


слайдер — яваскриптом!
никакого говнокода в разметке!


Why can’t this be set when creating the `local_candidate` in the first place?


Yeah, seems so. I think they're new but I'm not sure when they were introduced exactly. Last time I tried to use them they were a bit buggy but it seems okay here.


Hi m,

Only 4.3 patch will crash and have high load ?


есть гугол :D:D:D
http://codepen.io/search/pens?q=css+counter&limit=all&type=type-pens


дивами


removed space.


we should exit with non-zero exit code here.


fixed.


i really don't like redefining everything :(


imho no


Should I let it panic further down or actually do the check and panic. The check puts a performance penalty on all calls of the function.


what's with this { } block?


![Ça marche :D](http://puu.sh/lpmCa/a707608669.png)


!done


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5612](https://teamcity.mesosphere.io/viewLog.html?buildId=77196&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:04:28


Ouhalala il me plaît pas du tous ce commit ><


Maybe this fixed aux_list? We can't find anything else that might have done so...


Seems like the removal of this endpoint from the documentation was just
a mistake when applying season 6 changes to the API. It is now fixed, so I'm removing the annotations.


@cbrauns you need to add an image called `tree.jpg` to https://github.com/ArdourIO/ardourio.github.io/tree/master/images.


+1, probably we can just put the pointers in a struct.


5321-GroundDomain_RDD (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1963 of 1968 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.75%25-yellow.svg)


@EggDice why did you merge?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5613](https://teamcity.mesosphere.io/viewLog.html?buildId=77200&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:05:09


para el proximo commit cambiar de public a private! se me olvido :
public List<IResultado> resultadosDeRonda;


Должен быть только 1 параметр, contact


This `unicode` shouldn't have to be here. All files have at the top `from future import unicode_literal`, which is supposed to make every string unicode in Python 2 (they're all unicode in Python 3). Anywhere you are adding `unicode()` should be a flag and looked at to see if something can be done in a different way. Forcing a `unicode()` when we've already done `from future import unicode_literal` should be a red flag.


boolean MODIFICATION - это лишнее


:?: @cassus I'm not sure I can follow the direction you are heading


можно обйтись без if, сразу сделать return условия


удалить


Because of the: https://github.com/lab-coop/lab-governance/blob/master/README.md#policy-async-governance-process-tlc
and the 4th point


shouldn't we be autoreleasing?  who/how is memory being released here?


Could you remove this else (and just put the content in the function body), it is unnecessary since you raise the exception in the if.


Are you sure that `1.0.0-SNAPSHOT` is greater then `1.0-alpha-4-SNAPSHOT` for Maven?


Could you put all the exceptions in this file? I don't really see the need to split them up like this.


my bad, I've missed the original


Thanks :) This was breaking my builds!


Let the panic fall out by itself.


Possibly something going on in the `compression()` function that I need to look at? Maybe we need to add some tests to make sure everything gotten back is always unicode? I don't know...it's strange that your other functions will break if you don't add `unicode()`. Do you have all the imports at the top of the files you've created? That might be the problem.


I guess we could detect if the currently displayed view is the first one (show privacy button) or not (show back button)...


Exclamation points are here for testing purposes.


5321-GroundDomain_RDD (mmatts) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


You can't have one without the other.


Git is too mainstream


Just want to note this so we can look at it late. We shouldn't have to add `unicode()` like this. We may end up with compatibility issues later. See comments on: 076a129a8468a6c85c8b55a752aca87a60f90d79.


Getting an error on this (trying to run a 3D model): NameError: global name 'offset' is not defined... any idea what it should be?


Just saved us 3 weeks worth of work.


Que foda veiiii...

Agora podemos fazer uma analise das senhas brazucas do exercito
brasileiro.... topppp!11!1!!1eleven!onze!

On 17/11/15 15:18, Marinofull wrote:
> @romariorios @niltonvasques que delicia
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Marinofull/analysis-password-leak/commit/6101a5cd0859937c772b28458f5a8315684a86e0#commitcomment-14458419

--
Att.,

Nilton Vasques Carvalho Jr.
Mobiloucos Team
Graduando em Ciência da Computação
Universidade Federal da Bahia
telefone: +55 71 9278-0148 (Tim)
Github: https://github.com/niltonvasques
linkedin: http://goo.gl/hUOs7W


TeamCity TripleA :: UnitTest [Build 139](http://188.177.191.210/viewLog.html?buildId=207&buildTypeId=TripleA_UnitTest&guest=1) is now running


I inverted the colors here: black is "safe/hidden" mode, red is "warning zone" mode


5321-GroundDomain_RDD (mmatts) - i386-Windows-7-VisualStudio-12: OK (1963 of 1968 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.75%25-yellow.svg)


TeamCity TripleA :: UnitTest [Build 139](http://188.177.191.210/viewLog.html?buildId=207&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:24


Shouldn't the callback function here have an error parameter?

The problem is that you're calling `db.getChatHistory`, but `db` is the raw SQLite client. You want `database.getChatHistory`.


@azturner any objections to me changing this regex to this "(?<=\^FD)((?!\^FS).)*(?=\^FS)"  You can see it in action here https://www.debuggex.com/r/lISHKIN3snXP9Bev

I ran into a case where it was not matching our merge fields when the field contained a F or an S in it as seen here: https://www.debuggex.com/r/olTQjCmwqPdLp3Gd


LiuShu, please ignore this file, LoginClient.swift.  I forgot to delete it from the folder. Sorry for all inconvenience!!


the metaphone and dmetaphone functions were returning normal strings

On Tue, Nov 17, 2015 at 4:22 PM, Nikhil Haas <notifications@github.com>
wrote:

> Possibly something going on in the compression() function that I need to
> look at? Maybe we need to add some tests to make sure everything gotten
> back is always unicode? I don't know...it's strange that your other
> functions will break if you don't add unicode(). Do you have all the
> imports at the top of the files you've created? That might be the problem.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nsh87/ehrcorral/commit/076a129a8468a6c85c8b55a752aca87a60f90d79#commitcomment-14459485>
> .
>


Seems a bit hackish but why not if there is no cleaner way.
Please add a comment to explain that this is a workaround for a limitation of the standard.
Please also file a PR against Odoo/master so it can be fixed cleanly eventually.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5615](https://teamcity.mesosphere.io/viewLog.html?buildId=77210&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:48


Local variable `review` is not used anywhere and should be removed.


@supercfanx
Liu Shu, I have added my 3rd project, finally.  In this project, I haven't implement the data storage yet. This project is mainly about networking.  I will work on the 4th course and also make changes of my 2nd project based on your previous comments.  Thanks a lot!  Enjoy the trip!~


"delete" is a verb and should therefore be the HTTP method and not in the path, for example:

`delete '/reviews/:id' do`


@mortzu @genofire
Ist das ein Transfer-Netz? Dann sollte es besser ein /127 sein: https://tools.ietf.org/html/rfc6164


@supercfanx
Liu Shu, please ignore the file "LoginClient.swift" when you got a chance to look at it.  That file should be deleted.  I noticed after submit pull request and decide to leave it there temporarily to avoid mess on the page.  Thank you!


But why do you need to unicode an empty string in our own module?


Yank out the prysm url and some how pass it in via config


a


Perhaps also accomodate for taxonomy files that contain '; ' separators as well as ';'?


Lets add comment here for the additional check.


Is there another name we could publish under, e.g. `clever-discovery`?

I personally prefer to avoid `clever` in the package name if it's open-source, but can't think of another good name off the top of my head, and the effect is mostly mitigated by `discovery = require 'clever-discovery'`.


5225_tmains (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (895 of 895 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.13%25-green.svg)


Should create a new method for the retry


Datatables was choking on decimal objects, which caused it to throw a nasty ajax error for the user. This patches it.


Also can be more concise. See http://stackoverflow.com/a/22890355


good point. I just got frustrated with it. I will change that now.

On Tue, Nov 17, 2015 at 4:34 PM, Nikhil Haas <notifications@github.com>
wrote:

> But why do you need to unicode an empty string in our own module?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nsh87/ehrcorral/commit/076a129a8468a6c85c8b55a752aca87a60f90d79#commitcomment-14459645>
> .
>


worth a comment? `(* id *)`


好

在 2015年11月17日 下午8:22，Cat73 <notifications@github.com>写道：

> id重复（两个logo）
> 有多余的js代码（Quit默认隐藏取消后没删掉的）
>
> 先记下来回家处理。。。
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/XX-net/XX-Net/commit/81f75d9cd16e6c550cf8f1777504ec7c90bc9a9a#commitcomment-14441587>
> .
>


Asked the same question, the answer I got is to use 4 digits for this time. Thanks.


Not sure we want to store the color here. The Stores should not contains UI related values. I plan on having two different icons anyway :)


why set on separate line from the definition?


TeamCity TripleA :: UnitTest [Build 140](http://188.177.191.210/viewLog.html?buildId=208&buildTypeId=TripleA_UnitTest&guest=1) is now running


TeamCity TripleA :: UnitTest [Build 140](http://188.177.191.210/viewLog.html?buildId=208&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:24


Looks good to me.


HTTP GETs should not modify state. GET requests "safe" and "idempotent" so should only return state. For creating state on the server, the route should use POST.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec9.html#sec9.1


Think it does already, even tested
On 18 Nov 2015 10:38 am, "geronimp" <notifications@github.com> wrote:

> Perhaps also accomodate for taxonomy files that contain '; ' separators as
> well as ';'?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wwood/graftM/commit/3cefabe920b604a4c5dd2297051ea16ac0b5867a#commitcomment-14459693>
> .
>


This is good for now, but I'll actually bring in the Chef standard Rakefile and then also convert Travis over to using ChefDK & Kitchen-Docker to run Ubuntu/CentOS docker integration tests.


Shouldn't these three just pass through to the Context functions instead of copying the implementations?


I like the idea of the BackButton protocol :+1:
But I think we should always show the Privacy button though. Would it be an anti-pattern to put it next the back arrow?


It's better to add the prefix `xwalk` before `ZOrderOnTop`


so slow


why aren't you working faster


go do your homework


Good catch, Seb - thanks for pointing this out.
I've updated the javadoc comment accordingly and credited you in 51bffbe


TeamCity TripleA :: UnitTest [Build 141](http://188.177.191.210/viewLog.html?buildId=209&buildTypeId=TripleA_UnitTest&guest=1) is now running


What's the thought behind removing these.  If we support CentOS we support derivative distros


TeamCity TripleA :: UnitTest [Build 141](http://188.177.191.210/viewLog.html?buildId=209&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:23


god


damn


commie


commit*


anime sucks


no it doesn't


pls


xip is god


umm


cannot top that


gtfo


you stupid shit


of a commit


ugh


sfdsgfdshdfshdf


gfdg


fddf


gfdhfdhd


this is boring


why am i so dumb


I plan on building the UI only with NSConstraints anyway. So we might get it for free. But I agree, disables is good for now :)


gg still there


Done


see usgs-r/sbtools#140. i hope this bandaid is temporary.


The song_id should be found from the review rather than a parameter passed in.
On the destroy, it might be best and cleaner to use:
delete "/reviews/:id"

Some guidelines:
https://github.com/blindgaenger/sinatra-rest
http://guides.rubyonrails.org/routing.html#crud-verbs-and-actions


HI，辛昕
- 1、ENV 本身是支持在程序运行过程中动态增删改查，详细使用方法参见 API 文档（[点击查看](https://github.com/armink/EasyFlash/blob/master/docs/zh/api.md#123-获取环境变量)）。只不过在裸机Demo中只演示了修改功能。增加、删除及查询的功能演示，我也想个办法有时间加到裸机中去。
- 2、首先 RAM 中的缓存是为了提高增删改查的效率，如果担心在掉电时， RAM 中的 ENV 修改过，但是未保存，那么用户也可以牺牲效率，每次都使用 `ef_set_and_save_env()` 方法操作环境变量，这样每次操作后会自动保存环境变量。其次如果担心在往Flash保存 ENV 时发生掉电，则可以开启 EasyFlash 提供的掉电保护模式（[点击查看](https://github.com/armink/EasyFlash/blob/master/docs/zh/port.md#512-掉电保护)）。这是个软件模拟的掉电保护模式，当然最可靠的方法应该是硬件提供掉电保护机制，并支持系统在掉电时有充足的时间保存 ENV 。
- 3、你说的很对，实际上对于用户来说字符串方式不仅仅增加了开销，也使得软件编写时增加了过多的类型转换方法，代码也变得臃肿。所以接下来的时间里，我是有计划从以下几个方面解决上述问题的
 - 1、（正在进行）提供类型转换插件，简化用户操作流程。例如：`ef_set_float_env("temp", 13.5) //修改浮点型的 ENV ` ，甚至支持数组及结构体类型，这个插件差不多快完成了，我同时还未其开源了另外一个库 struct2json （[点击查看](https://github.com/armink/struct2json)）与之配套。
 - 2、（未开始）提供轻量级模式，所有的 value 直接保存的是 RAW 数据，同时把 key 也替换为整形的ID，将开销减低到最小。


his accounts*


Overall impressed by the clean coding. Good work.


gfdgfdg


gf


fdgfd


fdgfdg


fddfdgdf


develop (evanweaver) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-85.06%25-red.svg)


THIS IS MY CODE. I COULD NOT UPLOAD IT TO GITHUB SO REBECCA DID.


Note that the Search Distance value can also cause molecules to not find surfaces. The default search distance is currently 0 which will often cause surface molecule release locations to not match the calculated location of the desired surface.


In the future, a better commit message is "bumped version to 1.2.0"  this means you can scan the git commit messages and know which version was cut when, and includes which commits, from the commit history on github, etc.


I had the same question. Would you accept a pull request to the react-blessed README to add a link to the sandcrawler-dashboard project?


No need to use the `typeof` statement combined with `Array.isArray()`


TeamCity LabkeyRelease15.3 :: Git postgres 9.4 [Build 86](https://teamcity.labkey.org/viewLog.html?buildId=285836&buildTypeId=LabkeyRelease153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 16 (2 new), passed: 234 Build time: 00:57:42
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSHelpCenterTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

##### there are 6 more failed tests, see build details
```


Hmm, I played with them a bit and they aren't what I expected.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5619](https://teamcity.mesosphere.io/viewLog.html?buildId=77241&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:51


Awesome!!!!!


how about:

// AddRpcTagsToContext adds the given log tag mappings (...) to the given context, creating a new one if necessary. Returns the resulting context with the new log tag mappings.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5622](https://teamcity.mesosphere.io/viewLog.html?buildId=77244&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:11


I think this should be configurable in a better way.


@felexx90

Me interesa llegar al fondo del asunto de los problemas de codificación que estás viendo en tus equipos Android y Windows.

Mi idea es que, si te parece, mantangamos el addon en forma conjunta.

De esa manera vamos a evitar problemas de colisiones de versiones y confusión en los usuarios, duplicación de esfuerzo, etc.

Te cuento cuales son las plataformas en las cuales pruebo el addon antes de hacer un release:

* XBMC 13.2 en Windows 7 64 bits English
* SPMC 14.2.0 (http://spmc.semperpax.com/ -- Un fork de Kodi 14.x con código optimizado y arreglos para Android en TV sticks/TV boxes con SoCs ARM chinos, cuyo maintainer es miembro del Team Kodi) en Android 4.1
* Kodi 15.2 en Untuntu Linux 14.04 64 bits
* Kodi 14.x en Windows 7 64 bits Español

Todos tomando la colección via SMB desde un servidor Linux Debian 8.2 64 bits + Samba 4.1.17

¿Vos puntualmente en qué plataformas y versiones ves problemas? ¿Con cuáles subtítulos? (mi experiencia es que el subtítulo a descargar tambié es un factor impoortante).

En general trato de ser conservador a la hora de incorporar cambios para solucionar problemas que no puedo reproducir. Un ejemplo de eso es el issue ramiro/service.subtitles.subdivx#12 que estamos investigando en conjunto con el usuario que la reportó.Afortunadamente él está haciendo un buen trabajo ya que ha posteado la URL del subtítulo con el que experimenta el problema y ha detallado la plataforma que está usando.

Creo que es posible que haya que crear casos de test con el tipo de datos (Unicode/str) y posiblemente codificación porque mi temor es que Kodi esté pasando algunos datos (paths del sistema de archivos vía `xbmcaddon.Addon()..getAddonInfo(...)` y/o en URLs) con esas características en forma inconsistente o dependiente de la plataforma. Es va a ser la única forma de solucionar corner cases que ve un grupo de usuarios A sin miedo de romper el funcionamiento del addon para otro grupo de usuarios.

¡Saludos!


Can't we just move this up to line 71?


I think line 26 of react-dom-server.js should be g.ReactDOMServer = f(g.React);
Am I correct?


Yeah, i know that problem. In 3D it's broke, i got working on the 'logging'
branch for a better implementation.

As a work around i believe you can change the line 258 in
~/underworld/utilts/_utils.py.
*from*
out += "\t\t\t<DataItem Dimensions=\"3 2\" Format=\"XML\"> 0 %u 1 1 %u 3
</DataItem>\n".format(offset, nodesGlobal)
*to*
out += "\t\t\t<DataItem Dimensions=\"3 2\" Format=\"XML\"> 0 0 1 1 %u 3
</DataItem>\n".format(nodesGlobal)

let me know if that helps?

On 18 November 2015 at 11:24, OKaluza <notifications@github.com> wrote:

> Getting an error on this (trying to run a 3D model): NameError: global
> name 'offset' is not defined... any idea what it should be?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/underworldcode/underworld2/commit/103e6e933dcf5e72767865d7195f58245c30d4e0#commitcomment-14459528>
> .
>


5225_tmains (nmerket) - x86_64-MacOS-10.9-clang: OK (1963 of 1963 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5620](https://teamcity.mesosphere.io/viewLog.html?buildId=77242&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:08:58


而反而给 V人人


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5621](https://teamcity.mesosphere.io/viewLog.html?buildId=77243&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:04:43


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5624](https://teamcity.mesosphere.io/viewLog.html?buildId=77247&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:11


Not really. It's just that we seem to use xnio, so almost flipping a coin I decided to go with that one. There's no documentation for either of them...


5321-GroundDomain_RDD (mmatts) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (894 of 894 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.13%25-green.svg)


lgtm


@ueyudiud
Also, creidt ---> credit


Raté, celui-ci est justement présent pour vérifier que si on enregistre deux fois la même transaction, le transfert d'argent n'est pas effectué deux fois ;) (ie. une fois dans le .create() et une fois dans le .save())


Subsections/CPL - C-sytle programming.md

1. 공용을 공통으로 바꾸는 것을 깜빡했네요.
2. 부분집합
부분과 전체는 대립어입니다. 비록 수학에서는 부분집합이라는 말이 선호되지지만 여기서 subset은 전체집합(universal set)의 반대로 쓰인 것은 아닙니다. 접두어 sub의 의미 중에서 하위를 선택한 것입니다.
subculture를 부분문화가 아닌 하위문화로 번역하는 예를 참고하였습니다.


:trollface:


user['id'] = user.pop('user_id') (User initialization will fail otherwise, as `user_id` is not a field in the `User` graphene ObjectType.)


I just got here because I was tracking how i crashed my device with:

for key,value in pairs(wifi.sta) do print("found member " .. key);end


TeamCity TripleA :: UnitTest [Build 142](http://188.177.191.210/viewLog.html?buildId=210&buildTypeId=TripleA_UnitTest&guest=1) is now running


TeamCity TripleA :: UnitTest [Build 142](http://188.177.191.210/viewLog.html?buildId=210&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:24


Can just combine this and the line below


@Daniel15 I reach this commit message is because my bookmarked issue links were 404ed, so have been a little bit sad about the move. Github definitely has its strong and weak parts, so as other tools. As a Github user, I find tracking issues in a single place is easier, but I respect the team to choose what is the best for their workflow.


_FINALLY FIGURED THIS OUT!!!_


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5625](https://teamcity.mesosphere.io/viewLog.html?buildId=77248&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:43


I don't think that will fix it. If you add console logging logic, you can see it firing at 100 words. The issue is that the fetch_next_kitten function doesn't fire until after the first 100 words have been input. To fix, you can run the fetch_next_kitten function on page load so that the buffer always contains a kitten.


Add a space to separate the two method declarations.


TeamCity TripleA :: UnitTest [Build 143](http://188.177.191.210/viewLog.html?buildId=211&buildTypeId=TripleA_UnitTest&guest=1) is now running


Can't do, `Set()` takes canonical value - `Set(key, val string)` and `v` is `[]string` in this context.


Remove the private access modifier so that this method can be visible for testing.


TeamCity TripleA :: UnitTest [Build 143](http://188.177.191.210/viewLog.html?buildId=211&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:23


Done.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5623](https://teamcity.mesosphere.io/viewLog.html?buildId=77245&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:10:52


TeamCity TripleA :: UnitTest [Build 144](http://188.177.191.210/viewLog.html?buildId=212&buildTypeId=TripleA_UnitTest&guest=1) is now running


(You should be able to write one unit test for this method)


absolute typo


TeamCity TripleA :: UnitTest [Build 144](http://188.177.191.210/viewLog.html?buildId=212&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:23


TeamCity TripleA :: UnitTest [Build 145](http://188.177.191.210/viewLog.html?buildId=213&buildTypeId=TripleA_UnitTest&guest=1) is now running


Possible duplicate.


TeamCity TripleA :: UnitTest [Build 145](http://188.177.191.210/viewLog.html?buildId=213&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:24


TeamCity TripleA :: UnitTest [Build 146](http://188.177.191.210/viewLog.html?buildId=214&buildTypeId=TripleA_UnitTest&guest=1) is now running


Can we get a better default client name?  Maybe `default-client`?


`_create_relay_user` is the right name, maybe `user_container`? ;)


>> Demo
Computing candidate regions...Invalid MEX-file 'D:\zifu\Edge_Boxes-master\Edge_Boxes\edges-master\imPadMex.mexw64':
找不到指定的模块。
这是什么原因啊？谢谢~


TeamCity TripleA :: UnitTest [Build 146](http://188.177.191.210/viewLog.html?buildId=214&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 52 Build time: 00:00:23


Maybe consider making an `EMPTY_ROUTE_PATH` or `DEFAULT_ROUTE_PATH_VALUE` const value that you use around to add more context to the default path value.


Add Javadoc for this method.  A one-liner is good enough.


good


This is the old syntax, with 0.4.0 you could do:
```python
users = graphene.List(User,
                      user_name=graphene.String(),
                      sort_key=graphene.String(),
                      sort_direction=graphene.String())
```


GDS used to be, when we resale inventory from 3rd parties. There days we supply to other third parties !

So no need to keep them around. And yes I need to clean the SQL examples out of them too.

Thanks!


foi um dos meus contatos que mencionou que houve esse leak semana passada no pastebin, aí fui procurar la e encontrei


Remove the `@param` and `@return` annotations from the Javadoc comment.  I prefer the one-liners if possible.


the bit I think is not accurate is this one:

"if there is a function that takes a system, or a system subset, or a component, this function needs to do a lookup to get to other functions (that live within components)."

I think a clojure programmer should never create a function that lives within a component, unless he/she has a very good reason for it, as this is equivalent to creating objects, as we know them from java and dotnet (it complects behavior and state). Having a function bound to a component is no different from having a map whose keys are functions names and the values are functions themselves, so this is something clojure already allows people to do. This is why I think this is not component's doing.

Component most certainly doesn't discourage doing that though (it may accidentally encourage it), but the same can be said about clojure sans component, I think.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5626](https://teamcity.mesosphere.io/viewLog.html?buildId=77249&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:08:48


You should comment on what makes it an *intra* visitor


Este commit se baso mas que nada en la nueva clase CantosEnProcesoParaElTruco. Se hicieron varias modificaciones para que pasaran los Test Unitarios de dicha clase y también se movieron excepciones de carpetas, unificando todas las excepciones de Cantos en una carpeta propia.


LGTM


I am wondering if we don't have an issue here: We call `getPluginJavaConfig `, but if this is a ruby plugin shouldn't we be calling `getPluginRubyConfig` instead?


Se pudo completar la delegación de las responsabilidades que habia estado ocupando a mesa a el nuevo objeto CantosEnProcesoParaElTanto. Sin embargo, primero dichos mensajes pasan por la ronda, como corresponde, ya que los cantos involucran multiples chequeos sobre la ronda y la mano donde se esta produciendo un canto.


misspelled function name


Cool, yep not using the xdmf anyway so just needed it to not die, up and running again, cheers!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5614](https://teamcity.mesosphere.io/viewLog.html?buildId=77201&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:55


I'm unable to run the tests - when I do either at command line or inside VS the execution starts but I never see any progress.


These two work:

build/ALPHA/gem5.debug --debug-flags=GOV configs/spm_based_mesh/mesh_spm_se.py --cpu-type=detailed -c "tests/test-progs/hello_spm/bin/alpha/hello_spm;tests/test-progs/hello_spm/bin/alpha/hello_spm;tests/test-progs/hello_spm/bin/alpha/hello_spm;tests/test-progs/hello_spm/bin/alpha/hello_spm" -o "15000; 500; 1000; 1500" -n 4 --topology=Mesh --mesh-rows=2 --caches --gov-type="Local"

build/ALPHA/gem5.debug --debug-flags=GOV configs/spm_based_mesh/mesh_spm_se.py --cpu-type=detailed -c "tests/test-progs/hello_spm/bin/alpha/hello_spm;tests/test-progs/hello_spm/bin/alpha/hello_spm;tests/test-progs/hello_spm/bin/alpha/hello_spm;tests/test-progs/hello_spm/bin/alpha/hello_spm" -o "15000; 500; 1000; 1500" -n 4 --topology=Mesh --mesh-rows=2 --caches --gov-type="Random"

[hello_spm.txt](https://github.com/mjshoushtari/gem5-with-spm/files/37401/hello_spm.txt)


해석에 if의 의미를 포함하지 못했네요.
의견을 반영하여 문맥에 맞는 의미로 수정하겠습니다.
빌드모드를 C로 컴파일하도록 사용하는지 확인하라.


Okay, removed it :p :-1:


LGTM

On Tue, Nov 17, 2015 at 6:14 PM, bjflanne <notifications@github.com> wrote:

> LGTM
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nats-io/nats-site/commit/09b74e9e2cd8d1c85c026aa4d48c265acefd21a4#commitcomment-14460192>
> .
>

--
*Larry McQueary* | Director, Messaging Technology
larry@apcera.com | @mcqueary | github.com/mcqueary


5225_tmains (nmerket) - i386-Windows-7-VisualStudio-12: OK (1969 of 1969 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Done - changed to `LogError` and removed non-blocking send - no risk of error events being dropped.


Is it just me or the shifting In keys are messed up?


Done.


@wmorgan believe me, there was much discussion between @bdd and I about using one of 🎩, 💣 or 🛁 instead.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5627](https://teamcity.mesosphere.io/viewLog.html?buildId=77260&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:53


these are allocated on the stack (via `alloca`) so you shouldn't call `delete` here.


@yoojinkimhong DWMR. Well done here. Press ahead! :cherry_blossom:


Se creo una nueva clase que se encargara de tener las responsabilidades (que actualmente tiene mesa) relacionadas con el canto del envido o de la flor y todas las verificaciones que hacen falta.


El objetivo de los proximos commits es lograr delegar la responsabilidad de la mesa en cuanto a las verificaciones correspondientes ante un canto de envido o de la flor a la ronda, y luego a un nuevo objeto que implemente la interfaz CantoEnProceso


Добавь проверку на пустоту массива, если он пустой то получим бесконечный цикл...


Return type info missing.


5225_tmains (nmerket) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1433 of 1433 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.49%25-green.svg)


네. 혹시 '여러'는 어떻게 생각하시나요?
'많은'으로 번역하지는 않겠습니다.


What is the difference between `1.0` & `1.1`?


> my bookmarked issue links were 404ed

That's yet another Github limitation - You can't redirect links to new URLs if you decide to move to a different service. The same with Github-hosted websites - There's no way to do 301 redirects. That's one major advantage of a self-hosted solution like Phabricator - If you ever decide to move away from it, you can simply redirect all the old URLs to corresponding new URLs.


Could you explain the purpose of this change?

I've looked at the code and i see what it does, just don't get why you would want it


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5629](https://teamcity.mesosphere.io/viewLog.html?buildId=77267&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:05:01


Looks good!


> my bookmarked issue links were 404ed

That's yet another Github limitation - You can't redirect links to new URLs if you decide to move to a different service. The same with Github-hosted websites - There's no way to do 301 redirects, which means you're basically locked in if you ever use Github issues or a .github.io subdomain. That's one major advantage of a self-hosted solution like Phabricator - If you ever decide to move away from it, you can simply redirect all the old URLs to corresponding new URLs.

That's one reason I suggest to people to never use .github.io subdomains. That and it's very tacky - foo.github.io is like the geocities.com/foo of the 21st century. It's not very professional.


WrappedException is not used


We should add the author's name for each post so we can also credit contributions from the community as we get them. Otherwise, LGTM.


pessoas que usam linux, utilizar:
make
make clean


Only `Map` is used here.


Hello, @Kubuxu do you have an example of a pattern that triggers that array out of bound error?


Revert these whitespace changes.


I was thinking it might be worth keeping consistency. I'll recover them to single quotes then.


It is hard to know all affected Chrome versions for now, maybe M47+ (M47,M48...) or just some of M47? so I think we can add the upper version condition when we catch it.


None of these are used.


Or both of these.


@polomani ти перевірив чи просто так кажеш, адже воно працює.


Looking forward to merging this pull request.  A few changes need to be made.


This one too.


Yes, it should be, I will correct it. :)


@enoter The MCPE lib says all.


I dont know Why it is required but this has to be in all aplications. Otherwise it throws exception even application doesn't use exception handling.


Instruction isn't used


Would be nice to include more context in the error msg, e.g. the element id


abstract


Google Chrome Frame was discontinued in [January 2014](http://blog.chromium.org/2013/06/retiring-chrome-frame.html), and the W3C validator will flag chrome=1 as an error. I think it's a best practice to start removing this from X-UA-Compatible meta declarations.


@borsch так, я знаю.


If You want to handle runtime exceptions add this line.


Thanks, I wasn't completely sure how to handle the delete calls. I'll get that fixed up.


@leonerd Then you could use `pkg-config --exists ncurses && pkg-config --cflags ncurses` and similar for LDFLAGS.


This is a misleading error msg - "on" might be specified but "request" was not.


Should this read `(dictionary)` instead of `(string)` and `state` instead of `channel name`?

Also, I get
```
/Users/eric/src/chronster/battle_site/apps/core/messaging.py in _set_state(auth_key, state)
     15
     16 def _set_state(auth_key, state):
---> 17     pubnub.state(uuid=auth_key, state=state)
     18
     19

/Users/eric/.virtualenvs/chronster/lib/python2.7/site-packages/pubnub.pyc in state(self, channel, channel_group, uuid, state, callback, error)
    949                              'urlparams': data},
    950                              callback=self._return_wrapped_callback(callback),
--> 951                              error=self._return_wrapped_callback(error))
    952
    953     def where_now(self, uuid=None, callback=None, error=None):

/Users/eric/.virtualenvs/chronster/lib/python2.7/site-packages/pubnub.pyc in _request(self, request, callback, error, single, timeout, encoder_map)
   2674                  timeout=5, encoder_map=None):
   2675
-> 2676         url = self.getUrl(request, encoder_map)
   2677
   2678         if callback is None:

/Users/eric/.virtualenvs/chronster/lib/python2.7/site-packages/pubnub.pyc in getUrl(self, request, encoder_map)
   1248                      hex(ord(ch)).replace('0x', '%').upper() or
   1249                      ch for ch in list(bit)
-> 1250                      ]) for bit in request["urlcomponents"]])
   1251
   1252         if ("urlparams" in request):

TypeError: 'NoneType' object is not iterable
```

When trying to use this, am I doing something wrong??


I had to reload whole new page because after runtime exception GUI is totally friezed.


Ah, I remember why I returned deps here -- so that we could write out a depfile in case the tool was being run under ninja


You specify it is in google_checks.xml, but you made no changes to the google_checks.xml file adding the new check.


is it dangerous here to return a non-promise-like value?


Yes, 'y' input is needed as before.


It seems unreferenced anywhere, or i might be missing something.


typo: IF


fuck dead zhuangbi fan


I think the `extractBox` function is still returning `None` instead of NULL.


Same concern as google_checks.xml for sun_checks.xml.


I don't think we need this change.

I think we can do better by having something like `OkHttpClient.class.getName() + name`.


IKAnalyzer author's blog:
http://linliangyi2007.iteye.com/blog/1703916#comments;

A simple source analyzing blog for IK:
http://blog.csdn.net/li_ablexiao/article/details/49231879.


Could you create a more appropriate method name here like generateComponentPathValues or something?


Interesting, I didn't know about the "qualified this" notation (: ...

http://stackoverflow.com/questions/4080868/using-this-with-class-name


give you some 颜射 see see


Not used


When logging in with a hash type of 'reset', an error message is shown with a link to the reset page. This line prevents the link markup from being rendered.


[You're changing the value of testBook](https://github.com/acucciniello/SilentSight/blob/f23e0febbc62ae927f0ce4970f456abe36af6ba2/server.js#L71)


If you use them in conjunction with `syntax` you can do some nice things but yeah they are somewhat limited.


One thing you could have done differently is `console.log` the value of `testBook` before each of your save attempts to see what the object was.


@private ?


アソシエーション使おう。
currnt_user.like.create で、引数のuser_idは書く必要なくなります。


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5630](https://teamcity.mesosphere.io/viewLog.html?buildId=77280&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:04:38


I think you may need to export this, too?


これは同じユーザーが違うプロトタイプにlikeしてるケースも想定できるよね？
なので、prototype_idとuser_idでの突合が必要になってきます。


Don't override the value of testBook and you should be good to go.

Also another thing you can quickly do to avoid the error

```js
  // make sure save property exists
  if (testbook && testBook.save) {
  }
```

---

Note.. You'd want to be less messy than this in cleaner JS. But hackiness is more than fine for now. Just get your app working!!


Ask @droazen :)
He told me to copy his UnmarkDuplcates tool. (But in all seriousness, it'd be good to have an answer on this @droazen).


Why? Separated into its own src file unittests are a bad idea, IMHO


Although, there is moved only large unittest checks, not elementary, so I'm not sure.


this should rollback to origin code.


:smile:


Right. Done.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5631](https://teamcity.mesosphere.io/viewLog.html?buildId=77285&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:53


you might want to put the log under `target` dir, to prevent accidentally. or put .gitignore for `logs` dir.


ここってdeleteの時も引数でprototypeのidとか渡してあげないと、どのlikeを消すか特定できなくないですか？


LGTM


的确， Browser 端只有 IE 支持，而且还仅限于 10+


let all = this.requests_.keys().join('|');


good job


Ponle hola mundo wey


yeah baby


It seems like one of the main uses for them would be to make some of the stuff like what we were doing in the ABT code a little less clunky. Instead of having to turn off eta and use records so much, we could probably keep things readable with this pragma. I think Ulf has some fancier examples in one of his repos but I haven't looked at them too closely.


let val = requests[name] || '';


contains plots of 0.5m iterations


これビューに渡す必要あります？
form_forとか使ってたら別ですけど、見た感じviewで@likeを使ってる場面がなさそうだったので


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5632](https://teamcity.mesosphere.io/viewLog.html?buildId=77286&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 199 Build time: 00:08:46


Yes, there are competing `ViewString` methods for `IsGroup and HasGeneratorsOfGroup`:

    gap> RankFilter(IsGroupAsSemigroup and HasGeneratorsOfSemigroup);
    32
    gap> RankFilter(IsGroup and HasGeneratorsOfSemigroup);
    40

I found that 8 was the minimum I could add so that these methods are actually used instead of the ones for groups. I'll review this and write a more detailed summary.


But the universal kernel number is not what you decide.. ive made my kernels.. and even updated to linux upstreams till 3.10.88 i believe .. thats when i lost my phone and lap... then now i intend to start working again.. but need to set up all again. on a slow internet .. and new lappy..

3.10.y is a Linux branch.. updating that number means you have to update it to its upstreams...
you can also use your own version codes. but not in that.... lol.

Im intending to bring my razorreborn kernel to Redmi 2.,,, need a base kernel to work on.. so was looking.. need to ask permissions.. from you and kamujaya..lol........


Ganhamos um pouquinho, mas não muito. :/

(usando a entrada atual)
Antes:
real	1m8.258s
user	1m8.348s
sys	0m0.000s

Depois:
real	0m57.579s
user	0m57.664s
sys	0m0.000s


minOccurs="1" ?


There's no easy way to comment on parts of `Interpreter.scala` now that the file has been renamed, so I'll write a list here:
1) Lines 94-107. Why don't you merge these cases in one?
2) Same lines. The pattern should be `${name: Ctor.Name}`.
3) Lines 163-183. Can you merge these two cases?
4) Line 210. Do you need this one? It is most likely taken care of by desugar.
5) Line 154. Don't we need to create a new stack frame here?
6) Line 107. What about `foo.bar(..$args)`. How do you handle that?
7) Lines 66-77. Why not unify these three cases?
8) Do you plan to implement unimplemented cases on lines 85-89?
9) Line 128. Why does this assume that we always call methods on objects?
10) Line 111. When does the execution reach this line?
11) Why not unify handling of normal method calls and infix method calls?
12) Why do you assume that unary method calls are always primitive?
13) Line 234: Why do you create a new stack frame here?
14) Lines 239 and 241 can be unified.
15) Lines 333-342. That's an excellent example of code duplication.
16) I think that's enough for now.

Also, I would like to see more tests. Indeed, the immediate examples from the tickets are covered, but tickets never said that these are the only snippets that need to be supported.


This is a plain text file and the url is not clickable, I don't think it makes much sense.
Maybe I can add back the license text to the README and add the full url there?

What do you think?


Nothing. I will amend the commit message.


Might want to add a comment here ;)


Re the FIXME: No, json is officially a binary (application/...), not a textual format (text/...) and hence doesn't have a "charset" parameter (see the RFC somewhere). If one is specified anyway it should be disregarded by well-behaving browsers, but it never has a positive effect.


Reuse http://europass.cedefop.europa.eu/xml/EUROPASS_ISOCountries_V1.1.xsd


ここ最初画像投稿フォームを3つとも隠しておく仕様にしてるんですかね？


just one detail before compile :

bool Configurator::treeExists() const
{
    QDir d(QStandardPaths::writableLocation(QStandardPaths::AppLocalDataLocation));
    if(!d.exists())
    {qWarning(jtConfigurator) << " HOME folder don't exist ! :" ;
        return false;
    }

    return true;
}

My idea was to replace if(!treeExists() || !pluginDirExists()) by if(!treeExists()
using :
bool Configurator::treeExists() const
{
    QDir d(QStandardPaths::writableLocation(QStandardPaths::AppLocalDataLocation));
    if(!d.exists()||!pluginDirExists())
    {qWarning(jtConfigurator) << " HOME folder don't exist ! :" ;
        return false;
    }

    return true;
}

I make the changes ... but the code looks better now , well integrated with the sources .
Nice collaboration !
^^


I don't think it is correct to remove the br-int creation, it is still needed.


I replied on pull request, but let write one more time :)
In the documentation is perfectly explained how should work/use it, just was a bug in your code. This on-drop-failure was never executed.


We should look at this. Same as for that vtor,


> @victorpopkov thanks for reminding.

Wrong person.


sq looks OK. Thanks!


TeamCity LabkeyRelease15.3 :: CDS postgres 9.4 [Build 16](https://teamcity.labkey.org/viewLog.html?buildId=285932&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 16 (4 new), passed: 13 Build time: 00:48:30
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAxisSelectors: <no details avaliable>

org.labkey.test.tests.CDSLoginTest.testLoginPage: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenVariableSelector: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSVisualizationTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenBoxPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest: <no details avaliable>

##### there are 6 more failed tests, see build details
```


++i is faster than i++...


@Turbo87 :smile: almost at the same time


Thank you Paul for your reply :-) Yes, I also thought to resolve dates on a front-end. And for **ReferenceOwner.executionId** - now I get it! I thought that the executionID is unique per job, which basically means it is unique per record. So now I understand that **ReferenceOwner.executionId** is unique per workflow! Am I right?


Agree. I don't know why we have it, but I'd rather fix that in a later patch.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.570.06a2e2581ba20a22c71ed3c35e2f42196f983e19](http://build.palaso.org/viewLog.html?buildId=66305&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3290, ignored: 106 Build time: 00:30:23


WRTODO: Yes, I think you're right.


nice! :) now I can just iterate over my Dir and return the load_sample instead of the path <3
thanks! :)


WRTODO: Okay, why not. However, I think that we should NOT copy their XSD to our repository. We can simply reference their namespace in one of ours xmlns attrs. What do you think?


We should really discuss this in person. I forgot you're not coming in today.

The gist is: This was the first commit in an attempt to untangle the mess of three semantically different things all named "command". Maybe it wasn't the best choice to subclass Command right away, we can undo that.

But renaming the `command()` to something else is a change I would still stand by, as it makes the code much more approachable in my opinion. Otherwise we once again have this well-known-mess of layers of abstractions all named using the most generic terms possible and suddenly talking about the code becomes incomprehensible:

> Commands are classes which represent commands the user can execute which in turn implement a method commands which returns commands that are executed in its context (an instance of the Command class that is). The latter commands are created through a function named command, but are not the kind of Command we mentioned at the start of this novel. The commands executed by the Command classes via their commands method are actually shell commands, but you haven't actually read this far, have you?

Sounds like something from another Ruby project we're involved in :wink:


I think you introduce code in a lot of places for the single case where the output gcode should be empty.
Personally I don't care whether the output gcode is empty or an error is generated.

I caught the case where the meshgroup is empty early in commit c8f19229661c1cb5c9b45c1cf74ec04ce950734d

With that the code at line 58 should be superfluous, also the code changes in Wireframe2gcode should be superfluous.
As for the changes around line 150: can you maybe see if it is superfluous?
If so this whole commit can be undone.

[ REVIEWED ]


I thought the same but then I tried and when I started the neutron-openvswitch-agent br-int got created (it's in the conf file after all). I think it doesn't hurt to create it first but its usefulness is only necessary later when you start the Openstack services.


If you haven't submitted this yet, you should definitely mention your involvement in the R Users Group


@adrianschroeter I've changed it and rebased


I don't see any TODOs in this file, but yes, let's not make scope creap.


Theme phpboost


So, the one bit I'm not super happy with is that the lang files and up all mixed up with the CSS files... maybe should add "lang" directory to contain all the langs.


My editor is doing /something/ weird with whitespace.. the important modifications are on lines
173 in ijvm-util.c
and
403 and 409 in ijvm.c


Add attachments etc. wrapper. Common best practice to use container elements when maxOccurs="unbounded"


nice catch, despite the typo :)


Here!


Again, we should discuss this in person as written words can be misinterpreted in many ways. :fearful:

The gist: There is still a lot to be refactored in `Duty::CLI` as it is currently doing everything and nothing. The registry should not be loaded there IMHO, since I would see it as a command-line *interface* and not the actual application.

BTW: Why should this be called `boot`? Even if we consider liberal interpretations of the term "booting"?


Done :smile:


And here!


I see the TODO, but indeed: let's not edit this. The retraction_config is not the standard_retraction_config, which is obtained from settings.

Looks good.

[ REVIEWED ]


versão correta é "v3.3.2"


@grzesiul
```
styles.filter(s => !keyframes.contains(s.className))
```
removes styles added by usages of style(...) inside keyframes(...).
We can also handle this by adding some other method like kstyle(...) which will return StyleA like style(...), but will not register this style. There will be one more method in API, but it will make possible something like that:

```
val s = style(
  height(100 px),
  width(30 px)
)

val kf1 = keyframes(
  (0 %%) -> s,
  (20 %%) -> style(
    height(150 px),
    width(30 px)
  ),
  (100 %%) -> style(
    height(200 px),
    width(60 px)
  )
)
```
I think it's worth of try.


global_variables.jsp:getPercentageOfAlteredCases calculates the percentage for the overview with Number.toFixed(1), which does normal rounding so why use Math.ceil instead of Math.round?


:eggplant:


> have a look into

or

> have a look at


dfdf


Fixed in 062fc499f6e. Thanks.


There are cases where some vertices is internal only, and never receive any message from other partition. These vertices need to be updated when you run map partition operation. However, if they are not updated in one iteration, they are not included in the next work set. Yet it might be necessary to update them in subsequent iterations if some other vertices in their partitions receive new message and change value.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5684](https://teamcity.mesosphere.io/viewLog.html?buildId=77377&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:07:00


I will have a peek tomorrow.


@SlimBim  hello))))


添田です。5000未満の条件追加、確認しました！OKですね。


Add description, type and url elements

Type should be enumeration:

0: Diploma supplement
1: Transcript of Records
2: Letter of Nomination
3: Certificate of training
4: Learning agreement


Ezee, I totally agree with the change in treeExists. Please push this change.


#31 Alphabetische und nummerierte Listen wurden hier bereits implementiert. Deployment geschieht umgehend.


`Reviewed-by: Joakim Bech <joakim.bech@linaro.org>`


#32 Erkennung von URLs in Listen wurde hier implementiert, inklusive "Hyperlink Font" (blau, unterstrichen). Deployment geschieht umgehend.


could be minOccurs="0" is url element is added and external attachments are accepted?


This is an excellent fix!


This is supposed to always return a fixed size map with a well known set of keys, right? How about returning an `EnumMap` ?


Unmodifiable?


That logo image appears to be invalid @kennethreitz  (try in an anonymous tab)


Nothing much to grab from there.


So this would give me `[ArticleEl]` for `<article><body></body></article>` right?

I want to be able to access the article element (aka root element) easily as there could be some attributes stored on it. By returning the root document I could do doc.find('article') to get it. This is not possible on the childNodes array. However, assuming that there is always one root element we could return that. I couldn't think of any example where this would not work.

```js
nativeEls = doc.children[0]; // doc should always have just one child
```
What do you think?


One more thought though:

What if some NCP implementers want to include the `<attachment>` *only* (and don't want to generate the `<report>` elements)?

We have already concluded that some EMREX Clients will want to ignore the `<report>` elements and just fetch the PDFs. If so, then wouldn't it be prudent to expect that some (very simple) NCP implementations would want to do exactly the same?


just remove (expand-file-name buffer-file-name) from this string and all works fine


maxOccurs="unbounded" in a wrapper doesnt make any sense and is against best practices


The socket in being created after accepting inbound connection.


actually, yeah... it's way nicer having things in the langs dir. It looks like this now:

<img width="1217" alt="screenshot 2015-11-18 21 23 31" src="https://cloud.githubusercontent.com/assets/870154/11238582/bf071d8a-8e3a-11e5-863d-9c47b5b2b32e.png">


I believe we need to release the lock when we return NULL two lines below? (Cannot add the comment on that particular line in the GitHub gui).


That will only work if there is only one layer, right?


I _think_ I changed the apostrophe so that it was consistent with those in the line added below. I'll change those to use `’` instead, though.


update


This broke the reporting functionality, my Python (2.7.10) does not accept this way of declaring multiple variables.
Changed it to
```python
video = None
audio = None
vote = None
flag = None
```
In PR #389


WRTODO: Ok!


> Minor: It feels a bit weird to me to update the regression test checksums before updating the artefacts.

I think this might've been because I was originally planning to have a single commit that included the updates and test artefact changes. I only split the test artefact changes when I realised how many there were. I'll update the checksums at the end.


At least on FreeBSD, SA_SIZE() always returns at least sizeof(long), so the "else" branch in line 131 will never be used. Also, are you sure that "4" is the correct value to use on both 32b and 64b platforms? On the latter, the result with 4 will not necessarily be naturally aligned...


cool .
I have an error with that path  :
E:\JamTaba\build-Jamtaba-Desktop_Qt_5_5_1_MinGW_32bit-Release\Standalone\ui_ChordsPanel.h:21: erreur : ChordsWidget.h: No such file or directory
 #include "ChordsWidget.h"
                          ^
I can fix it , but don't push anything before my push to avoid conflicts please .


When my comment has been addressed:
`Reviewed-by: Joakim Bech <joakim.bech@linaro.org>`


Should this not be managed in hawkular-parent?


:heart: :heart: :heart: :heart: :heart: :heart: :heart:


External attachments? I haven't heard about this idea yet. Could you tell me more about it? How would such attachments get signed?


description, type: will do. (WRTODO)
url: more information needed :)


whoops, changes to polygon.h shouldn't have been committed.

Will change this in next commit.


Reuse http://europass.cedefop.europa.eu/xml/EUROPASS_ISOCountries_V1.1.xsd


添田です。課題6が少しおかしいですね。
switch文を書いていますが、caseが１つしかなく、
しかもswitchで対象とする変数とcaseの値が同じ$keyになっています。
これだと、チェックを掛ける意味がないですね。。。
ここは、単純にswitch文を外して割り算でOKですよ。


И почему это называется "make_best answer"?


よく修正できています。正しいです。アルゴリズムも頑張ってみてください


Wysłałem Natalii pomysł na GUI. Fajnie byłoby się zdecydować na jedną stylistykę żeby jakąś spójność zachować.

![gui_przyklad](https://cloud.githubusercontent.com/assets/15143716/11238679/aa79da7c-8de7-11e5-84f1-8a6d0257da8c.jpg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5685](https://teamcity.mesosphere.io/viewLog.html?buildId=77393&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:33


Sounds great. Pending any comment from toddrjen I think we should include the change


Ты сделал лучшим последний ответ, а проверяшь что лучшим стал первый?
Порядок элемента на странице с id не связан, должен быть селектор, который выбирает первый вопрос из списка.

Кроме того, не надо использовать `first`/`last`, у тебя есть конкретные переменные для ответов.
Какой вопрос `first`, какой `last` – непонятно.

Как и непонятно, почему я кликаю на _последний_ (с точки зрения ассоциации) вопрос, а лучшим становится первый.


This looks a little bit strange: we assign a new Map to `this.status` just once lazily in `getStatus()` but we write to that Map instance on every request? - Those writes may happen concurrently, can they not?


I don't think that it is a wrapper in this sense. The original ELMO schema allowed multiple `<hasPart>` elements, each one consisting of a **single** `<learningOpportunitySpecification>` element. Do you propose that we should change that?


I still think we should remove the __unused, since the variables are clearly used in the code below. If the compiler magically does things with it, then we should deal with the problem when that happens (isn't that a bug in the compiler?).


Here's the definition of SA_SIZE() on FreeBSD 9:

#define SA_SIZE(sa)                                             \
    (  (!(sa) || ((struct sockaddr *)(sa))->sa_len == 0) ?      \
        sizeof(long)            :                               \
        1 + ( (((struct sockaddr *)(sa))->sa_len - 1) | (sizeof(long) - 1) ) )


WRTODO


Yeah, I had it working fine on my open source intel and amd machines. However I just tested it on nvidia 352.63 and it seems to break the mouse and keyboard for that machine. I'm downgrading to 1.17.4


additionalLanguage (A list of available languages in the report. This is to help the automatic processing of these reports) has been dropped ... not required?


И что ты проверяешь тут?

Пиши тесты внимательней, это не просто отписко "чтобы было", а то, что спасет тебе уйму времени при дальнейшей разработке.


из предыдущего копировал


Meh


OK, I see that this Map is supposed to be enhanced from @RestStatusInfo instances. EnumMap probably makes no sense.


И как так? Мы сделали один ответ лучшим, а потом проверяем, что все _нелучшие_? А где же этот ответ?


Foundation for #68


Agree, if we think it is interesting to see what happens with wait, then I'd say it's just as interesting to get debug information for the other functions also related to condvar.


Some unrelated changes here. I don't mind, just pointing out if that is deliberate.


Why ReadAt?


**Code Quality: Nitpick**

This name as well as the names given to the other routes can be misleading as to the function of the API endpoint.


atomictests.py only contains the tests for atomic project :)


Yes, it turned out that no one is using this. Sorry, you have been left out of CC. Pasting it here for reference:

![image](https://cloud.githubusercontent.com/assets/2168535/11238812/797e5398-8de8-11e5-89fe-f4b2c594330d.png)
![image](https://cloud.githubusercontent.com/assets/2168535/11238820/8481cb62-8de8-11e5-9ae5-0c6190828779.png)


Sorry Paul, could you give me more details for how I can take **updatedAt**. In order to populate the table on UIM page I use **harvesterClient.findJobsByCollectionAndState(collectionId, Arrays.asList(ProcessingState.values()))**. Then I can sort out all the jobs by their **JobState**s, I can group the jobs by their **ReferenceOwner.executionId**s, but I don't really see how to get **updatedAt** per job. Give me a hint please... :-)


I'm going to guess that wasn't intended.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 5686](https://teamcity.mesosphere.io/viewLog.html?buildId=77396&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:32


How can i create my own template. I mean how can i find bubble's coordinates.
Would you please help me.


Please revert this.

I have not been able to reproduce bugs without this code, and class member objects are initialized with the empty contructor by default already.

This code change doesn't result in any different behaviour.

[ REVIEWED ]


hard to say. it is the sample rate our parser gets from the encoded stream: https://github.com/FernetMenta/xbmc/blob/master/xbmc/cores/AudioEngine/Utils/AEStreamInfo.cpp#L419


Done ! Please check if it's good on your side .
thx


status being a `HashMap` does not guarantee the same order of keys over equivalent requests and equivalent states of the app. Not sure if this might be an issue (when testing, e.g.?)


Seems to be an unused variable.


investigating it, due to the Anti-adblock stuff on the site previously.


Yes no problem. My current coding-job requires me to do the opposite, every variable starting with uppercase which is a real bad choice. It seems I've taken this bad design over to this code... :-(


I think I'd like to see the same concept here as you've done with the `condvar_wait` above. I.e, when it's the debug version built, only then enable `fname` and `lineno` are used and not otherwise (same for the `wq_wake_one` below).


purl.org administration is in sad state, but all the exisitng purls are still working:

For example:

http://purl.org/net/elmo doesnt work because there is no such purl or its not configured properly

http://purl.org/net/mlo is redirected properly but the original pages are long gone.


`$('<iframe></iframe>')` => `$('<iframe>')`


Ezee, how you fix this path error?


Already reverted in ee8dd680466709b67dc4b3044f4740b9e3e4e59f .

Nothing to be done here.


changed in ee8dd680466709b67dc4b3044f4740b9e3e4e59f