Thanks!

On Fri, Nov 6, 2015 at 11:15 AM, Spencer Norman <notifications@github.com>
wrote:

> [image: :+1:] on the move to an event based workflow.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/getoutfitted/reaction-advanced-fulfillment/commit/4c945c4d6cd9614d11a83b739e3fb8186632de46#commitcomment-14248438>
> .
>

--

Paul Grever |Software Engineer |GetOutfitted  |m. 608-239-2471 |e.
paul@getoutfitted.com |w. getoutfitted.com
<http://www.getoutfitted.com/?utm_source=Email-Signature-Rescue&utm_medium=Email-Signature&utm_campaign=Email-Signature-Rescue>


this function was completely removed in another commit


This commit is only cosmetics, the real fix comes later


`website/static/css/onboarding.css` is still in the repo, but I couldn't find any inclusion of it anywhere else.  Can it be deleted?


naveno you wanted to write ```[\w\._\-]+``` screening or not necessarily


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3955](https://teamcity.mesosphere.io/viewLog.html?buildId=69654&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:38


# better to clear the code impl


You are awesome!


1. Did you mean ```Append```?
2. This string will always be the first part of the comment, so what's the reason behind ```\n---\n```?


https://github.com/CyanogenMod/android_frameworks_opt_net_wifi/commit/af2b86673c2743e1a7074da281a7db79f0389be8 should fix that, aquast


In general, let's declare variables at the top. E.g.
```
let date = new Date();
let historyEvent = {
 event: 'orderCompleted',
 userId: userId,
 updatedAt: date
};
let items = order.advancedFulfillment.items;

_.each(items, function (item) {
  item.workflow.status = 'completed';
  item.workflow.workflow.push('inspected');
});
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3957](https://teamcity.mesosphere.io/viewLog.html?buildId=69664&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:03:59


hello Mr.fung.
 in "ReadMe.txt" you have stated "ITSA.cpp - This is the main application source file." but there is no such file. If it is possible send for me these file.
thank you.


Shouldn't we explicitly check if the value "IsNumeric()" and leave the .ToString() if it is not?  If the user expectation was that ToString() was being called on objects. newtonsoft serializer will in a lot cases try to create json objects {...} instead of generating a string from "ToString()". AFAICT, GELF only supports "Strings" and "Numbers".


something that we discussed during one of our dev tech talk lunches was polymorphism vs. inheritance. we were discussing how to implement polymorphism without inheritance in python. in java you just use an interface. i think it's somewhat interesting to try that with this model -- don't implement any of the functions on the base and if they have the same functionality write the code in a util function and still define the function on the model that inherits this model. no action here, just something to think about


@tbranyen I noticed you wrote `normalizeOptions`. I'd like to know if this matches up with your intention behind the fn.


You still have a space between create! and the parenthesis. It should be:

```
user = User.create!(
```


`listRepos()` has error checking to change strings to lists. This code does work, but for the sake of clarity I'll change it.


Yeah! Of course, I'm fine with the polishing. :smile:
Thank you!


Then we have to figure out a way to make the water stop erupting when I'm walking on the edge of the shark tank, because the footstep actors are falling into the tank


93653546B-FuelGenShowingInABUPSwhenPV (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1958 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg)


Estos locks son porque este `MonoBehaviour` va a ser llamado desde threads? Ten en cuenta que Unity y llamar a `MonoBehaviour`(s) desde threads (sobretodo si acceden al GameObject/Monobehaviour en sí) no son muy amigos y normalmente peta.

Iría bien que hablaramos que irá en threads y que no, ya que si nunca la FOW va en thread, la AI va en thread (aunque no creo) y el PathFinding va en thread, podemos acabar creando flujos raros y deadlocks.

Si es para hacer la operación de `OnResourceAdded` (y las demás) atómicas, tranquilo porque los `Update` de Unity son sincrónicos, nunca llegarían dos llamadas a la vez a la función, por lo que el `lock` solo causaría un drop en performance.

De cara a la AI, esta es la clase donde podremos consultar si hemos ganado la partida? O el progreso que llevamos, etc.? O esta solo controla y tales peticiones se hacen en otro objecto? De cara a un futuro irá bien consultar que objetivos tiene la partida, sobretodo si van a ser complejos, aunque supongo que por el momento tiraremos con "matar al héroe", así que aunque no sea esta clase no te preocupes mucho por nosotros :wink:

BTW, intenta dejar algún commit sin `[ci skip]`, sinó Travis nunca dirá como va la rama, y para integraciones es mucho más fácil si sabemos que funciona y que no. Y, sobretodo, en caso de error es fácil localizar que commit lo causa y como arreglarlo, o al menos por donde ir. Si en algún momento una rama personal no compila no pasa nada (creo yo), de hecho es totalmente normal, pero así al menos tenemos referencias.


I get it now, did you benckmark it though?

**Route allowed packets through the VPN** vs **Route blocked packets through the VPN to nowhere**


So I think there are a number of issues with the Makefile.am changes I made with you which I think I'll look at separately.

Roughly I think:

The gputop program itself shouldn't need to be linked with libgputop.so, as it's really just meant to be a launcher for setting environment variables. Notably though one thing it should be linked with (but it isn't a.t.m) is GL because that's how it discovers where your real system libGL.so is to set LIBGL_GL_LIBRARY. The wrapper/libGL.so that's built as a GL interposer needs this information to be able to chain on to the real libGL.

It looks like I messed up an earlier change and there's a left over reference to a GPUTOP_DEP_LIBS variable which in some places should now be GLX_DEP_LIBS

It looks like libgputop should be linked with librt for clock_gettime but currently only gputop_system is being linked with -lrt.


Just tend to switch these things to timers whenever I get the chance... It decouples them from the loop rate. Oh, also it gets called at 10hz now, so it should probably be commented as such or the comment should be removed as it is no longer accurate and we shouldn't ever rely on such a comment being accurate.


You need to rebase off latest master.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3956](https://teamcity.mesosphere.io/viewLog.html?buildId=69655&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:08:36


The parent is current.


ah ok see where you're going. maybe `abstract` folder and then we can split up the `abstract_models` file into `xform.py` and `case.py` and move these ones into there. out of scope probably for this PR


Also renamed variable "current" to "courseAtI" to keep naming conventions constant


Can the constants `DD_TYPE` and `ELV_TYPE` be removed?


Creeeeeeepy


It was already updated (#99 #98) -- https://github.com/Islandora-CLAW/CLAW/commit/f707fae551145a548a7616ff22787e7cb41a2b1d

If you think it should be further clarified, I'd do another pull request. You'll need to update the chullo contributing document as well.


Does this generally happen when you walk on top of a 3d floor when there is water below?


Merged as b041fe9992be3047c85dc5d7c0441da0119490d4


I attached a potentiometer to the arduino and used Atm_comparator to react to 4 different threshold "bins" and in the callback, sent a PWM value for the bin to a LED. This worked fine, except upon startup, the LED is off, regardless of the position of the pot. I feel that this behaviour is wrong, because upon startup, you want to know the state of the analog input. You don't want to have to wait until it changes to a value in a different bin to get notification. However, I know you didn't want to change the behaviour, so I added an optional parameter to threshold. If it is not used, the behaviour is the same as it has always been. When catchUp is true, will cause the Atm_comparator state machine to call the callback repeatedly, assuming the starting value is 0 and catching up to the current value.

Since I think that this is the correct behaviour, I would prefer to remove lines 49-52, instead of doing what I have done, but lets discuss.


Okay :+1:


Not on a 3D floor, because there's something solid for the actor to hit before it touches water. But when I had to walk around the edge of a pool, they were falling down the edge into the water. Frankly I don't see why they need to fall such a great height anyway. The gravity on them is very intense, so they fall a noticeable distance before disappearing. Give them a sprite and you can see just how far they travel.


:tophat: @aroben :blush:


removed name "Referral" so Signup pages all look the same.
removed form section Class Preference, not needed for Training & Assessment form


5255-EMS-dual-Temp-Node-Setpoints (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


very good catch :)


done


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2710


Thank you!


all tests pass:
success: http://buildbot.bos1/builders/test-riak_pb/builds/271


fixed


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3958](https://teamcity.mesosphere.io/viewLog.html?buildId=69677&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:36


`values`, hmm..

![commentphotos com_1407346387](https://cloud.githubusercontent.com/assets/2286385/11005426/e0c66c90-84a4-11e5-82d7-4aac3b459165.jpg)


Try killing the caret and dollar sign:

```
t.throws(
  function() {
    herfindahlIndex([1, 'not a number']);
  },
  /Value must be a number\./,
  'throws with non-number array items'
);
```


No trouble, thanks! ;)


I recall adding it, not sure what happened, thanks!


Minor: in `website/static/css/projectorganizer.css` there are three rules for `div.project-grid-menu` and one for `#project-grid`.  I grepped for both and didn't find either being used anywhere.


is this as opposed to `XFormInstanceSQL`?


Sorry. Newbie mistake. Will get around to doing it when I get back to my
laptop in a couple of hours.
On 6 Nov 2015 11:59 pm, "VoyagerOne" <notifications@github.com> wrote:

> You need to rebase off latest master.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rohanryan/Stockfish/commit/ddeb65d7117904b22ca04e6deae368253cb6126e#commitcomment-14248749>
> .
>


@borshop: merge


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3960](https://teamcity.mesosphere.io/viewLog.html?buildId=69679&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:00


@borshop: retry


Maybe use `$push` here instead of `$addToSet` for the historyEvent and perhaps for the workflow as well.

[`$addToSet`](https://docs.mongodb.org/manual/reference/operator/update/addToSet/) ensures that there are no duplicate items added to the set.


Saweet!  That did the trick! Thanks man!


They're forced to a maximum height. You worried about the differences in width? If you know how to force that in CSS, go for it. Something like a maximum width/height, and pad the width or height if it's less...


Sorry about the newbie mistake. Will be back at my laptop after a couple of
hours. Will update the master branch then.
On 6 Nov 2015 8:58 pm, "Jörg Oster" <notifications@github.com> wrote:

> @rohanryan <https://github.com/rohanryan> This seems to be very cautious.
> SF has a very low effective branching factor. I would suggest to start with
> 1/3 or 1/4 of the time. But an iteresting idea. You need to update your
> master branch in any case.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rohanryan/Stockfish/commit/a5b2033b675a0ecc46ba0cc7918d452f3b429dac#commitcomment-14244042>
> .
>


Indeed, you're right.
However, it's that way for ages in Ardent's codebase and it never was an
issue (https://github.com/laravel-ardent/ardent/issues/267). If that bogs
you, I'll happily accept a PR and open a new branch with PHP 5.3 / Laravel
4 support :)

*Igor Santos*
Desenvolvedor web / mobile
igorsantos.com.br <http://www.igorsantos.com.br>

On Fri, Nov 6, 2015 at 2:13 AM, harry <notifications@github.com> wrote:

> But the composer.json says required php version is >= 5.3.0 in ardent
> 2.5.0 .
>
> https://github.com/laravel-ardent/ardent/blob/v2.5.0/composer.json#L21
>
> Maybe the composer.json should update?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel-ardent/ardent/commit/f6496331f6ee80ff5159bacc3e8e2df17e08b7b4#commitcomment-14229831>
> .
>


ok


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3961](https://teamcity.mesosphere.io/viewLog.html?buildId=69686&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:52


replace b and c


How are you testing it with Beignet?


this is cool


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3959](https://teamcity.mesosphere.io/viewLog.html?buildId=69678&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:22


Does `website/static/js/pages/dashboard-page.js` still require Knockout?  I don't see `ko` being used in the script.


this line should be removed --- tit: "$t_str", cached didn't update as editing came after the add command had been sent.


saw approval from lukebakken
at https://github.com/basho/riak_kv/commit/e1b2acd0f35466e4c13efff668123676a0b0f518


merging basho/riak_kv/fix/az/split-ts-bits-off-riak_kv.proto = e1b2acd0 into borshop-integration-1259-fix/az/split-ts-bits-off-riak_kv.proto


basho/riak_kv/fix/az/split-ts-bits-off-riak_kv.proto = e1b2acd0 merged ok, testing candidate = 4a527c95


It's not necessary since it's the last char.


hahaha, I have the same idea... with the same name! I'm from Uruguay


could this be a default somewhere?


I created Issue #69


Why not extend HttpServletRequestWrapper to avoid overriding all these methods?


Instead of `Please shorten é expression`, do `Please shorten é "expression..."`.


Nice, didn't know about that new list feature in `@use`, thanks for the upgrade :)


Nitpick: The parentheses around the DOCS_VERSION_PATTERN can be non-capturing `(?: ... )`


The collocation of inside the tree didn't matter before, but to deal with the notes I need to make sure that the `<anchor ana="start">` whose parent is a sentence is going to have its `<anchor ana="end">` also inside a sentence (but it doesn't need to be exactly the same sentence, that's why I use `name()`)


Fixed in https://github.com/brianjmiller/CMI-5_Spec_Current/commit/acf517ebc8e709ae4e9af909484817520f66eab7


Derp. Zen**H**ub.


Not very proficient with github when it comes to upload non-textual files. Hence, kindly be lenient if you see all the png files in one branch here


@vinferno why did you remove the debug mode?
Where there any side effects or errors from removing it?


where do you habe the boolean icon from? Apart from the subprograms icon I like it!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3963](https://teamcity.mesosphere.io/viewLog.html?buildId=69698&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:58


Absolutely! Objects may not be serialized as is. Please have a look at my next commit aa74710ed


Starting from this commit, bundle-server needs nodejs v4 or later as a dependency.
Nodejs on Debian repositories is quite outdated, therefore we need a strategy for bridge nodes running Debian stable.


What is this?


Yes, it is in the file right above this one :)


@geekwise does not work with current config/ no side effects


seems good


Ah, I think I see why this is the case. The problem is that for whatever reason the input section alignment for x86-64 seems to default to 16, so in the intermediate .o file before linkage, the struct is the right size but the input section has an alignment of 2**4 (you can see it with objdump -x on the mod.o file that contains one of these).

When the linker combines them, it seems to pad out the input sections to their natural alignment before combining. Specifying ALIGNED(8) or 4 here seems to override the input section alignment. 4 is probably sufficient, and i suspect that most ABIs would pad out the size of the struct to be 4 as well.


ewwwww.


"Genius", lol

Think they changed something about the order some time ago, so if it is HIGHEST last now, that's okay for me. ;)


Are the following changed done in the inline docs?


@raghuramg this breaks plan year specs


this is still meant to return.


Not sure this was supposed to happen :P


warning	1	warning C4018: “<”: 	server\dep\libmpq\libmpq\mpq.c	916	1	libmpq


How about creating tracker directly here, and removing getTracker function? I don't see anything interesting going on there


I might file this under "too clever by half" if I were chasing a bug and had to figure my way through it.  Sort of like "auto"...


Actually this seems to be the only one that should  be done in the inline doc instead. Also I think the line wrap is automatically generated...


I would still use constants for field names (those removed private static final String...), as it is easier to reuse later and keep track of the uses


Electric-Storage-Improvements (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1961 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


That's the one line that hides the private studies?! And it all works now?


Hello, I looked for issues mentioning argparse and found this. If it helps, instead of this hack you could remove the help printing action from the `--help` option, like this:

```lua
local parser = Arguments {
  name        = name,
  description = "cosy command-line interface",
  add_help = {action = function () end},
}
```


done


this also addresses issue #21


saw approval from lukebakken
at https://github.com/basho/riak-erlang-client/commit/8dea012c96dc6ec95e9edbcd1a8ad55b450b2acf


merging basho/riak-erlang-client/fix/az/split-ts-bits-off-riak_kv.proto = 8dea012c into borshop-integration-245-fix/az/split-ts-bits-off-riak_kv.proto


basho/riak-erlang-client/fix/az/split-ts-bits-off-riak_kv.proto = 8dea012c merged ok, testing candidate = 74f5a5e7


Here http://www.bilder-upload.eu/show.php?file=8d901b-1446837306.png you can see your master is stil from 2013!


Agree with not changing for now.  I really like to keep it based on gen-cat.


5255-EMS-dual-Temp-Node-Setpoints (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


fast-forwarding end-to-end/timeseries to borshop-integration-1260-fix/az/check-key-length-in-get-and-delete = 7e04500d


Merge sha 4a527c95 is stale.


merging basho/riak_kv/fix/az/split-ts-bits-off-riak_kv.proto = e1b2acd0 into borshop-integration-1259-fix/az/split-ts-bits-off-riak_kv.proto


basho/riak_kv/fix/az/split-ts-bits-off-riak_kv.proto = e1b2acd0 merged ok, testing candidate = d24568e3


I have no idea what Uniscribe allows.


I think you could have accomplished this with minimal code, can't you just register a filter and in the filter you forward to the expected URL?


Electric-Storage-Improvements (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Wow, great catch. Does [this](https://github.com/fluxbb/fluxbb/commit/e12b2335e4236642406b4117058df9ee66fd47db) look better?


fixed


eu acho que corrigi, isso, porem ele não deu erro nos testes,
por nulli como não existe ele tb é null.
deixa eu ver no próximo patch


in libm/Android.mk i had to change lines 300 and 302 (from s_floor.S to floor.S and e_sqrt.S to sqrt.S) to unfuck build :)


@admmasters Can you provide an example?


Do you really need this, i would imagine forwarding is all you need to do


Yes!  thank you, I just realized your next commit handles this nicely. Perfecto!


Should be the same as the filename:
```ruby
cask :v1 => 'servetome-beta' do
```


мета тег знову написаний неповний
дивись сюди http://www.w3schools.com/tags/tag_meta.asp - Differences Between HTML 4.01 and HTML5


done


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3969](https://teamcity.mesosphere.io/viewLog.html?buildId=69708&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:01:05


Obrigado pela observação amigo,
eu já arrumei da uma olhada no código, porem esse erro fico um tempo no codigo
https://github.com/Pompeu/be-mean-instagram/blob/master/sistema-mongoose-atomico-promises-events/server/tests/photos-routes.test.js


This doesn't seems like tests? :-)


Why do you need a custom ServletConfig class? I see nothing different in it


Ok. Try 1.5-beta8 ?

On Fri, 6 Nov 2015 08:43 Glen Stone <notifications@github.com> wrote:

> This commit doesn't seem to be part of the Nuget 1.42 release
> <https://www.nuget.org/packages/Dapper/1.42.0>. Calling Get before
> parameters have been added still throws a NullPointerException.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/StackExchange/dapper-dot-net/commit/24e55162f47780f509ee373c081234431bc5d576#commitcomment-14246247>
> .
>


Context why this was done: it makes the behavior consistent with Android and web. If you want to make a click-through view, use `pointerEvents: 'none'` on all platforms.


Sorry, 1.50-beta1 (which uses beta8 of the dnx tools, hence the confusion)

On Fri, 6 Nov 2015 11:06 Marc Gravell <marc.gravell@gmail.com> wrote:

> Ok. Try 1.5-beta8 ?
>
> On Fri, 6 Nov 2015 08:43 Glen Stone <notifications@github.com> wrote:
>
>> This commit doesn't seem to be part of the Nuget 1.42 release
>> <https://www.nuget.org/packages/Dapper/1.42.0>. Calling Get before
>> parameters have been added still throws a NullPointerException.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/StackExchange/dapper-dot-net/commit/24e55162f47780f509ee373c081234431bc5d576#commitcomment-14246247>
>> .
>>
>


On 11/06/2015 08:16 PM, Pengcheng Tang wrote:
> We did read your previous comment on this, this is the fix to quote it correctly.
>
> errtblname (not the errtablename one) is not quoted, and it concats the prefix later in the PQExpBuffer.
>
> then tmpStr = fmtId(but->data)  does the final quotation properly.

Ah, I see. I didn't notice the difference between "errtblname" and
"errtablename". Might want to rename "errtablename" to
"errtblname_quoted" to highlight it.

- Heikki


Seems a little over kill to me, why do you need the other changes like the replacing and the custom servlet config, i would imagine the filter's forwarding is all you needed


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3964](https://teamcity.mesosphere.io/viewLog.html?buildId=69699&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:08:50


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3970](https://teamcity.mesosphere.io/viewLog.html?buildId=69710&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:41


I dont know how to edit this commit.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3965](https://teamcity.mesosphere.io/viewLog.html?buildId=69701&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:10:17


`doc.form` is a wrapped dict (actually a jsonobject "`JsonDict`") that has values auto-converted, whereas `_extract_case_blocks` expects an unwrapped dict—i.e. exactly what's saved in couch. This `if isinstance(doc, XFormInstance)` check is really just a somewhat-sloppy convenience for the caller so that they can pass in either a wrapped XFormInstance or a form data dict. I think previously it didn't end up mattering in practice, but when I tightened up the way we deal with datetimes, this ended up mattering. Or maybe it always mattered, but the bug it caused was obscure enough that it never came to our attention until recently. (According to the commit message it has to do with the behavior we get when a case block's date_modified is a bad datetime.)


all tests pass:
success: http://buildbot.bos1/builders/erlang-client-test/builds/192


@amcmahonBNL Can you make sure my edits didn't break the code on Windows. It *should* no longer fail given path separation and it should also create the output folder dynamically if it doesn't already exist.


The patch itself is not based on that. In fact, pawns.cpp did not even have 300 lines back then.


As is, a matrix entry that has 'use_stock' set will show stock levels even if the parent product is set to not use stock; I don't see why this couldn't be a valid use case, but if we'd prefer the parent product setting to take precedence in this case, it's an easy change:
```
if (empty($product['use_stock_level']) && !empty($matrix['use_stock_level'])) {
    $matrix['use_stock_level'] = 0;
}
```


@borshop: merge


I have reverted the changes regarding our own `ServiceUnavailableException` in c7d83062eecb43bbc03a4bc9f6b05760e59b5537.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3954](https://teamcity.mesosphere.io/viewLog.html?buildId=69653&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:38


are you sure that you need FRAGMENT_NO_NOTIFY here?
i think !FRAGMENT_NO_SYNC.equals(uri.getFragment()); is enough

also according to the notifyChange method isSyncToNetwork will not be reached if FRAGMENT_NO_NOTIFY.equals(uri.getFragment())


no use of this commit :open_mouth:


This should be an apostrophe: `’`. (Which also doesn't need escaping)


In addition, all quizzes are of my own doing too.


This is mutating `$PWD` and results in `Error: No start script specified.` because `$PWD` ends up being `/`.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.568.20db414a27f96c3dcdc7aef5ae82e19881b95d32](http://build.palaso.org/viewLog.html?buildId=65705&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3307, ignored: 125 Build time: 00:06:43


No, I didn't. The speed will depend on the speed of the CPU and the battery drain will depend on the efficiency of the CPU, but we all know battery usage on modern mobile devices is still more or less problematic. So, any test will depend on a specific device type and therefore will be more it less subjective.


At this point, $disabled is always false (line 271), so test again this variable is unnecessary


I have been thinking about tagging the response for a while. What do you think @christian-fei ,@MatteoPierro and @gpad ?


node-sass-middleware uses 2.2.1 so it needs to be updated to 0.9.7


No, it was correct :)


u rock.


I'm not sure that adding declarations for my_pe, num_pes, shmem_int4_swap, shmem_int8_swap, etc in the tests is needed or correct.  These are already declared in the Fortran header.


we can drop the `:5` suffix now, right?


Corrected ;)

thx

--
Julien Lavergne
+33670273883
http://julienlavergne.com
Sent with Airmail

On November 6, 2015 at 8:04:01 PM, Victor Popkov (notifications@github.com) wrote:

Should be the same as the filename:

cask :v1 => 'servetome-beta' do
—
Reply to this email directly or view it on GitHub.


What does "frozen" mean? If the effect of a node being "frozen" is that it will not execute, the node should be explain as much:
> When IsFrozen is true, the node and all nodes downstream will not participate in execution.


But you must test against your master branch! So you MUST update your master branch!


opa, essa classe representa a ideia de um post. Então é melhor deixar o nome no singular


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3975](https://teamcity.mesosphere.io/viewLog.html?buildId=69715&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:01:04


should use ssize_t here


se as tags são armazenadas como string, como vc faz para não duplicar noticias que pertecem a mesma tag?


> I don't like valid, because to me, the none state does not reflect an invalid state. Semantically, it means often "empty" or "nothing."
>
> Overall, I'd prefer simply three adjectives. For the same reason we omit get/set prefixes in our style guide, I also find it consistent if we avoid is/has prefixes and use an adjective for boolean condition instead.
>

Makes sense to me. I don't like "active", though. available()/empty()/error()? The latter returns the error condition which is convertible to bool (there's actually no reason for a separate has_error).


also, need to check if beg_pos < 0, if so return request_uri, shouldn't continue


any reason for taking this 3rd party?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3972](https://teamcity.mesosphere.io/viewLog.html?buildId=69712&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:24


s/i/I/


`if (beg_pos < 0) return request_uri;`


s/os/OS/


put the ampersand attached to the string


@admmasters This diff unifies behaviour across all platforms. It introduces two behavioural changes:

 - Transparent views on iOS now receive hit events while previously their parents would have (this is how it works on Android / web).
 - The original code had a bug when falling through `RCTPointerEventsBoxNone`. It didn't take into account `clipsToBounds` which meant that a subview outside the bounds might have received events even though its parent might have been clipping it.

If you're not receiving events, you must have relied on one of the behaviours described above.


@vmcloud please see my comment, otherwise look ok


Don't do this in the middle of all the checks. Do it somewhere below, close to where you remount /proc


I think I have it figured out. Testing out a solution here:

remove the alignment stuff in the linker script and set each of these sections as
__ALIGNED(sizeof(void *))

That seems to naturally align things on the proper boundary for all machines, and the output section in the linker script will be aligned on the input sections' alignment.


Class.class.isPrimitive() ?


o código vai do inicio do servlet até aqui, é só para construir um objeto do tipo Post em função dos argumentos do request. Tenta criar uma classe que isola essa conversão. Algo como: Post post = new CadastroPostConverter().converte(request)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3978](https://teamcity.mesosphere.io/viewLog.html?buildId=69724&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Failed to create a directory Build time: 00:00:00


In both of these cases, objdump -x is handy to see the alignment of the sections and objdump -s is great for looking at their contents to see how its padded out.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3977](https://teamcity.mesosphere.io/viewLog.html?buildId=69723&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:42


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3976](https://teamcity.mesosphere.io/viewLog.html?buildId=69721&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:56


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.547.20db414a27f96c3dcdc7aef5ae82e19881b95d32](http://build.palaso.org/viewLog.html?buildId=65704&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3286, ignored: 106 Build time: 00:14:05


não quero uso do scriptlet aqui. Troca isso para usar as taglibs


How do I do that?


Não verifiquei o arquivo antes de mandar, havia erros


Hmm.. we could create a new `Order` stub as a constructor (vs. object like above) for this test and proxyquire `actions` by test..? Eh not sure...


esse menu precisa ser dinâmico


TeamCity pull requests :: netty [Build 608](https://garage.netty.io/teamcity/viewLog.html?buildId=3074&buildTypeId=pulls_netty&guest=1) is now running


onde ta as mensagens de validações, caso eu tenha deixado de preencher alguma coisa?


How about adding some log here to let the use know that the data haven't been sent?


Same here


Теперь даже если ввести неверные данные пользователь перейдет на главную активити. Нужно метод addHero() сделать возвращающим булево значение и проверять его


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3974](https://teamcity.mesosphere.io/viewLog.html?buildId=69714&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:08:31


& -> &&
и вынеси это всё в метод isValid() или как-то так


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3971](https://teamcity.mesosphere.io/viewLog.html?buildId=69711&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:09:23


Looks all good to me.


thanks


The master bench number entered is the same as the other patches testing.  If you are right the patch should just fail and say wrong bench or something.


@TristanWright This should fix the invalid item id issue we are seeing


Should make the name of this more descriptive to what it's actually providing.


Could we not just do:
return xlSheetWriteStr(sheet, row, col, Z_STRVAL_P(data) + 1, format);


If i am wrong then correct me but your work uploading on GIT after test in Local so keep in mind after filtering mistake you did :imp:


If there is a place to bikeshed interfaces are the best area. Let me ponder on this a little more. My only reservation is that it is the current `ID` which is used to reference the layer while the `DiffID`is used as metadata for the image to re-construct the `ID`. I sympathize with the confusion though, it should be immediately obvious what these represent.


The intention is to recapture data from the beginning of the current year to today every Friday?


ta precisando de validação aqui... não deixa entrar nenhum dado inválido, isso sempre causa problema no sistema... vc vai buscar um dado achando que ta de um jeito e ta de outro


using template.HTML looks very dirty here,  I'm thinking to refactor that with a JS specific delimiter (in addition to %% and <> )


There seem to be a bug in content_by_lua_block.  If you look at the below code,  ( -- local msg_test = "test") is commented out.  If I uncomment,  I get following error.
nginx: [emerg] Lua code block missing the "}" character in

Seem parsing bug due to "

    content_by_lua_block {
            local file_name = "rules.json"
            local file, err = io.open(file_name, "r")
            if not file then
                ngx.log(ngx.ERR, "Failed to open file:" .. file_name)
                ngx.status = ngx.HTTP_NOT_FOUND
                 ngx.header["Content-type"] = "text/html"
                ngx.say("Failed to open file: " .. file_name .. ". Error:" .. err)
                ngx.exit(0)
            end
            local data, err = file:read("*a")
            file:close()
            if data then
               -- ngx.log(ngx.DEBUG, data)
               ngx.say(data)
            else
                ngx.log(ngx.ERR, "Failed to read data from file:" .. file_name  .. ". Error:" .. err)
                ngx.status = ngx.HTTP_INTERNAL_SERVER_ERROR
                ngx.header["Content-type"] = "text/html"
                -- local msg_test = "test"
                ngx.say("Failed to open file:" .. file_name .. ". Error:" .. err)
                ngx.exit(0)
            end
    }


Ok with this fix but please please add a comment that this is intended, e.g. FALLTROUGH


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3979](https://teamcity.mesosphere.io/viewLog.html?buildId=69750&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:31


@shua123 Is there any way that we can specifically ask about the keyword we are using? Therefore, if the keyword is "SCHOOL" the return message would say something like: "Oops, I did not understand that. If you are interested in this test, please text back this keyword: SCHOOL"

I understand not wanting to say "re-type the keyword" because we did not reference "keyword" earlier, but it is confusing to ask them to re-type the message. I immediately thought they might type the incorrect message again.


This change stops dropbear for working with the SSHLibrary of robot test.  Connections do not close so all the tests just hang.
https://github.com/robotframework/SSHLibrary/issues/128


Make sure you are in the correct branch
git checkout master

Then fetch the actual code, merge it and push it to your repository.
Here are the commands:
git fetch upstream
git merge upstream/master
git push origin master

Hope this works!


Use descriptive names for the nodes


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3980](https://teamcity.mesosphere.io/viewLog.html?buildId=69753&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Failed to create a directory Build time: 00:00:00


Worried about log spew. Will add a VLOG.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3982](https://teamcity.mesosphere.io/viewLog.html?buildId=69757&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Failed to create a directory Build time: 00:00:00


Ditto


`+ '/nodes'`  should be `+ '/nodes/'`.  Canonical APIv2 urls always end with slashes.  The non-slashed version will work, but will 301 redirect you to the slashed version.


Смотри, у тебя тут немного лишнего есть в этом методе. collect — это как раз метод, который собирает то, что выдал каждый блок, и возвращает результат. То есть, если ты сделаешь вот так:

```ruby
def struct_movies(movies_list)
 movies_list.collect { |movie|
   {
       link: movie[0],
       name: movie[1],
       year: movie[2],
       county: movie[3],
       date_published: movie[4],
       genre: movie[5],
       duration: movie[6],
       rating: movie[7],
       rating_stars: rating_star_format(movie[7].split('.')[1]),
       director: movie[8],
       stars: movie[9]
   }
 }
end
```

то есть без промежуточных переменных — всё по-прежнему будет отлично работать.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2713


Same as above, add a trailing slash to `/children`.


OK.. bugs enabled.. Also went ahead and fixed the commit issue, put another release out in the release tab.. @wilhen01, tell me if that fixes your issue.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3981](https://teamcity.mesosphere.io/viewLog.html?buildId=69755&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:58


- No longer crashes when sound fails to load!
- Sound now loads correctly when in random mode
- No double sound loads
- @RedInquisitive being awesome.


5255-EMS-dual-Temp-Node-Setpoints (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1426 of 1426 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.47%25-green.svg)


Electric-Storage-Improvements (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (887 of 887 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.57%25-green.svg)


Совсем мелкая придирка, но важная для читабельности: когда ты знаешь. что `split('.')` разделит число аккурат на две части, и нужна тебе из них точно последняя — лучше написать это вот так: `movie[7].split('.').last` — даже несмотря на то, что символов чуть-чуть больше ;), такой код более явно выражает твои намерения.


SGTM


also, do public methods here need javadoc?  (even though they are trivial...)


Maybe this commit could be reviewed. I ported the use of `Future` to `Task` to be support cancellation. This is my first foray into `Task` so comments are welcome. This has been tested by the users and works fine


So this means that each command could be executed on a different machine?


noticed an empty @return in the javadoc for convertToTargetCoverageList below (not in this commit)


sink?


/cc @robrix if your swift grammar ends up having any `expectedConflicts`, you might need to bump tree-sitter to get this bugfix. Ambiguities w/ 3 or more interpretations would sometimes mess up the parse.


Wouldn't it be better to fix the typo in this line instead of removing it altogether?  There's an extra `=` character here. Should be:

    -D "CMAKE_INSTALL_PREFIX:PATH=$PREFIX" \


Заповедь тебе дана была ещё в предыдущем задании: не усложняй! То есть я вижу, что у тебя опыта в программировании на Руби больше, чем нужно для этого задания. Но настоящий мастер кунфу отличается от ненастоящего тем, что знает, когда кунфу применять НЕ НАДО. В этом задании нет других фильтров, так что [вспоминаем полезный принцип](http://c2.com/xp/DoTheSimplestThingThatCouldPossiblyWork.html) — и не плодим лишние сущности, типа Полезного Списка Фильтров, без необходимости!

Вот честное слово — усложнить всегда успеешь. Мастерство в том, чтобы решать поставленную задачу минимальными средствами, пока тебе не уточнили требования.


Это неоптимально, но оставим до следующего задания, тогда и разберёмся ;)


TeamCity pull requests :: netty [Build 608](https://garage.netty.io/teamcity/viewLog.html?buildId=3074&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5249, ignored: 21 Build time: 00:16:00


TeamCity LabkeyRelease15.3 :: Git postgres 9.4 [Build 5](https://teamcity.labkey.org/viewLog.html?buildId=283350&buildTypeId=LabkeyRelease153_GitPostgres) outcome was **UNKNOWN**
Summary: Canceled (Exit code 137 (new)) Build time: 00:05:09


@ohporter is the "am335x-abbbi.dtb" staged for mainline kernel.org?  The "am335x-bonegreen.dtb" should hit v4.4.-rc1, and then i'll send @trini a u-boot patch for the green board.  Otherwise queue'd up, this will be in our weekly u-boot build..

ps: the "fdtbase" can be dropped as it's an old 3.11-3.14 era "cape" hack, i just have it their for users who upgrade u-boot on those image from last year..

Regards,


Thanks! Killed it!


well spotted.


Good catch!


Hey @mathieuanthoine, even though the api says `{String|Number}` I don't think `fill` and `stroke` will accept hexadecimal numbers.

Can you test and see?


Closes #15


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3983](https://teamcity.mesosphere.io/viewLog.html?buildId=69759&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:15


develop (macumber) - Win64-Windows-7-VisualStudio-12: OK (2337 of 2370 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.61%25-yellow.svg)


Minor: Use `“` and `”` for double-quote characters.


Nice catch :+1:


Accident merge. Nothing added


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 136](http://teamcity.corp.dirigodev.com/viewLog.html?buildId=1652&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 6 (6 new), passed: 0 Build time: 00:02:30
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.CreatePage: <no details avaliable>

SmokeTests.dll: SmokeTests.AdminTests.LoginTest: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


A simple fix is to just add that if we have targets and only add it in that case.


I have tested it and it works perfectly :)

Le 06/11/2015 20:45, Adi a écrit :
>
> Hey @mathieuanthoine <https://github.com/mathieuanthoine>, even though
> the api says |{String|Number}| I don't think |fill| and |stroke| will
> accept hexadecimal numbers.
>
> Can you test and see?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mathieuanthoine/haxe-pixi/commit/7f939338ead54418c7ec55b90372246e4ff695af#commitcomment-14250327>.
>

--
Mathieu


Вообще норм, я понимаю что задания для тебя слишком простые. Можешь мои комменты учесть в кач-ве информации, а задание сдавать, я его приму и перейдём к следующему. И там-то уж пощады не жди! :)


What encryption scheme are you using here?  Maybe we could use some builtin library functions to make it more stable? javax.crypto looks like it could be useful but I've never used it


This seems to make NodeGit install on Node.js v5.0.0 https://travis-ci.org/thisconnect/nodegit-kit/jobs/89714234


fast-forwarding end-to-end/timeseries to borshop-integration-245-fix/az/split-ts-bits-off-riak_kv.proto = 74f5a5e7


nit: occured


TABS!


fast-forwarding end-to-end/timeseries to borshop-integration-1259-fix/az/split-ts-bits-off-riak_kv.proto = d24568e3


You're one to talk.


Why the gratuitous underscores? They are already private, nobody can use them by mistake.


What does `CrispyTemplate` get used for? Is it intentional that `render()` will have side affects on the passed in `context`?


HiHi, that was made so you can decide if the standard or the template from the template was loaded .
... hey you submitted it to Git !!! Good Job !


I Know it looks strange, but you have to consider the possibility that some captures are going to fail and once a week you have the chance to fill in for missing data,  by scraping it again. Don't worry because I have added a check to see if the data is already in the database, before hitting the website, so this will not generate any unnecessary requests.


точняк, поправил.


can you point this to `https://travis-ci.org/telusdigital/ansible-nginx.svg?branch=master`


Текст в тайтлі повинен бути обов'язково


I don´t think we would have a benefit with it.
I think we should keep the code styling as simple as possible to be understandable also for Newcomers in php.
Of course, deprecated expressions or styles, ... absolutely!
Too many rules and improvements to expert coding style would scare off users having fun learning programming.


Corrected calculation of VAC


Put these files back into an "examples" directory.


LGTM


Why drop `preload`?


Add a second External Project step here to build the ITK Module.


this is minor, but any reason why you need to overload writerWithIntervals to take a ReadCountCollection?  this is only called in write, where it seems collection.columnNames() could be passed.


similar point here.


TABS  (╯°□°）╯︵ ┻━┻


This should be the top level file.


Solves this issue : https://github.com/openwrt/packages/issues/1784


Please delete this. We can write appropriate test data in when we know what to test.


фывфывфы


This file should be located at examples/CMakeLists.txt


Esse é o meu commiter!


Добавь крч


awesome :) it definitely didn't work in pixi 2 :)

Anyway I am more inclined to set the type as `Int` so that we can always use hex code. Not a big fan of dynamic usage. What do you think?


Yes, this fixed a test failure.  I'm pretty sure it was the exact same failure you fixed a different way in commit 0ad061b.


@stevengill is this true, I still need to check in to cordova-js any changes to cordova-js-src in cordova-ios?


aicl_done_handler is referenced at line 2602.   so move #endif in front of line 2216 to pass compiling ?


:) Yes, the CSS spec has never been particularly pellucid...


Cool, would just review the final classes at this point.


the below is also required. thanks!

https://github.com/robvogelaar/WebKitForWayland/commit/033bff39bd6204ad0e34433a819b15debaa3372d.patch


I think we can use https://github.com/heroku/heroku-buildpack-c to build the C and https://github.com/heroku/heroku-buildpack-jvm-common to install the JVM


@yichengq however, detailed error messages are useful for troubleshooting. I agree with a message with  multiple lines isn't good, especially for processing with script. I'll consider the change again.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3877](https://teamcity.mesosphere.io/viewLog.html?buildId=69288&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:18


`pellucid: false`


@yichengq thanks for your comment. Actually, this change is breaking a test case, sorry for that.


heu and why not :

<pre>
stor = line.replace('ETCD_DATA_DIR=', '')
store = "".join([stor.replace(i, "") for i in ['\n', '\t', ' ', '/']])
</pre>

not tested tho but that double rstrip is seriously ugly (and not even talking about that eval which is a crime against humanity ;))

Hola @ZuluPro enjoying openshift rcip-scripts? aren't those lovely!


@yuyuyu101  From the code, IndexManager::get_index
>>Mutex::Locker l(lock);
>>  ceph::unordered_map<coll_t, CollectionIndex* > ::iterator it = col_indices.find(c);
I don't see any dependence. I try by git log to see why  but can't see any usefull info.


and if you hacve some time to loose: https://stackoverflow.com/questions/3411771/multiple-character-replace-with-python


Pois é, nem tinha notado, doeu até em mim essa :(


@IIvec: Luca's test is always 2nd thread vs always last thread, not a test against master. It shows that the last thread must catch up.


Should this be `Task.Yield()`?


Just giving you a heads up guy. As far as being able to "track your own mistakes"... That is all the more reason to have complete history available. For example, here you went and spent all this time putting in work on this here repo, but say, down the road, something gets reverted upstream, now your screwed. Plus it looks shady as all hell to guys that been doing this for a long time. Generally, if it looks like a duck, walks like a duck....
 And yeah, it's all open source man, no one cares if you pull there commits, until you hide the fact. Maybe that isn't your intention, but most people, in the community, ain't gonna see it that way.
 If you enjoy doing this stuff, you might as well devote the time to learn to do it right, it'll pay off in the long run.
 Last thing, I don't know if them dudes would care or not, they probably don't, it really don't matter, but it is respectful to list people, and not just an open "devs of the open source community" in your OP.
 Especially when the only original "code" you have is a string where you change the rom's name...


@phase Good idea! Since Fbuild is kinda needed to configure the JVM (why the hell is getting the Java home directory so gosh-dang difficult??), I could always use a Makefile like:

```
all :
    fbuild
```

That way, neither of us need to use Maven, either! ;)


Could be just

`return number++;`


Could be just:

`return number1 +=number2;`


In the development of a forum based website for stories at sea


Nice work Tyler!

You can also combine some of the code above into your return statements. See comments in the code.

Best,
Antonio


Add the `attache_rails` gem while leaving `paperclip` and `aws-sdk-v1` intact


FBuild needs to compile the Java code, make the dll (or whatever Linux has) from the C, and build a jar. The configure script I just added also needs to download Python 3 and Fbuild.


Maybe fixes issue #6


LGTM with a revert back to IOUtils instead of bytebuffers. Unfortunately, the latter will break Hadoop 1


It is a good idea.  I think I can create a sample repo with commit messages in Russian, pack it as a zip file, during the test unpack it and read changelog.  Without the latest changes it should fail on every version of Windows.


esto esta mal aca


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3878](https://teamcity.mesosphere.io/viewLog.html?buildId=69295&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:10


que significa modificacion en linea ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3879](https://teamcity.mesosphere.io/viewLog.html?buildId=69296&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:45


Hey @wadewegner, @dcarroll . Sorry I never actually replied any earlier! Yes, this looks great. Great job!

Let me know if you need anything else. In the meantime, I'm going to create a new pull request and start doing some extra work, especially as they relate to [assignment-rule headers] (https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/headers_autoassign.htm?search_text=Assignment%20Rule%20Header). Cool?

Thanks again, folks!


lol pls


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3880](https://teamcity.mesosphere.io/viewLog.html?buildId=69297&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:20


Looks good, thanks for the codes


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3866](https://teamcity.mesosphere.io/viewLog.html?buildId=69261&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:10


right!


No pb.  The current code is not great in that the expected error for most values is 0, and only different for some large values, so it would be better to work out which values we are expecting to suffer from errors, or even switch to using a relative threshold.


@phase Well, you're definitely one step ahead of me.

Side note: should that really be named `configure`? Considering that most times when someone sees `configure`, they equate it to "I need to run this to configure the build scripts!". What about `configure-heroku`? Or does Heroku need it to be named `configure`?


This has broken the script. Possibly a syntax error.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3881](https://teamcity.mesosphere.io/viewLog.html?buildId=69298&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:03


looks good


This will cause UI flashing. You can test yourself and input a word in a constant speed.  User usually query for a word, e.g. I search yyy for "网易云音乐", there is no reason to query each word. I have download and run the latest master code, and I found this problem. Maybe you can compare the UE between this refactoring.


Hey @joto heads up that I'm also seeing `way.geojson()` handing out empty coordinate arrays.

```
{"type":"LineString","coordinates":[]}
```


This method is now duplicated, generated failing code:
published/OptiML/shared/src/optiml/shared/ops/SparseMatrixOps.scala:55: method * is defined twice
[error]   conflicting symbols both originated in file '/Users/cedricbastin/folders/03-uni/00-class/MA5-PPL/hyperdsl/published/OptiML/shared/src/optiml/shared/ops/SparseMatrixOps.scala'
[error]     def *(__arg1: Rep[DenseMatrix[T]])(implicit __pos: SourceContext,__imp0: Arith[T],__imp2: Overload255) = sparsematrix_mul[T](self,__arg1)(implicitly[Manifest[T]],__pos,__imp0,overload255)
[error]         ^


Related to https://github.com/CapitalJS/capitaljs/issues/5


forgot to delete it


Yeah, shouldn't be too hard to fix, we can do it later though.


Elieser the rock star !
thank you bro' !
^^


Determines whether the value of the Edm expression is same with the target.


Hãy set nam là trường bắt buộc, còn hai trường còn lại có thể null và blank


More specifically `HOSTEXE=((! $?))`.


LGTM


Hãy thử phân trang theo dãy số. Ví dụ: 1 2 3 4 5 6. Trong project thường dùng load more và pagi theo số. Ít khi dùng next và previous


@hackinhukk @Tameshon @hoodsy
we have a great thing going here guys XD


Những import nào ko sử dụng thì xóa nó đi


Inicio


Nếu đã sử dụng get_queryset thì ko cần dòng này


"Voy escribiendo por commit visto, si esto ya esta corregido no me den bola. "
Este valor debe ser pasado, asì que hagan un has server => (); ya que el requesting tambièn sirve para otras api que usen otro server.


No idea why this shows as a branch merge. I only change 3 files in ender IO. It then proceeded to include the last changes made by Glowstronium and Oddface as if I were the one who merged the branch. It didn't break anything thou so.....


Usar camel case.


you could make render_as_markdown(markdown) as a private method since it's supposed to be used only for the post model.

private
def render_as_markdown(markdown)
...
end


The UI flickering should not be handled this way.
See https://github.com/Wox-launcher/Wox/issues/350
It can be fixed.
If you think this is a serious issue, I will speedup my progress of learning WPF :smile:


nếu trong get_context_data() không làm gì thì hãy xóa nó đi. Chỉ để get_context_data() của class cha thực hiện


ok


诗词


How about a systemd timer too? I can write a quick one for you. Have it fire 10 minutes after boot and then once a week?


test


I believe the commit message reads "Added error description", can you confirm?


This doesn't return the proper state, it should be `{:reply, list, _state}` instead of  `{:reply, list, todo_list}`. This is fixed later.


camelCase y que sea mas descriptiva la variable, piensen que su código lo ve otra persona y debe de ser lo mas comprensible que se pueda.


`<br>` тут не нужен


Variable mas descriptiva


It's not just a UI issue. It's fine for C# plugin if you can fix root cause for UI flashing. But for JSONRPC plugin, there is a performance issue if we query so frequent.


тут так же без `<br>`'ок делаем!)


//Apparently we do need a pin


That would be great!


shallowCompare is also exposed in the global ReactWithAddons build at React.addons.shallowCompare. I think we should add there like it's being done with the other addons. (just throw `shallowCompare` under the `__React.__Addons` namespace.


В общем везде убираем за исклчением адреса в футере!)


also this is just for parity. form is probably a bad name


sacar librerias que no se usan o que solo existe para depurar,


Логотип у нас контентное или декоративное изображение?


No dejar funciones que son para depurar o que no se usan


`class="active"`?


Y te digo más, si el formato de archivo de datos de props y mobs es similar (un formato único, como habíamos hablado para lo de los objetos 3D), tranquilamente podría eliminarse la distinción entre props y mobs acá también. Total, acá lo único que quedan son las posiciones iniciales.


yes


Androidstudioのアプデで自動的に変わると思うのでコピペする必要はないですたぶん


lzma without -e option,
gunzip -f < $(recovery_ramdisk) | lzma -e > $@
should be
gunzip -f < $(recovery_ramdisk) | lzma -c > $@ ?


I believe that this pull request originated from me to bring in mosart and dwav to the cime trunk.
I thought I was following the correct workflow.


The alternative 'positive' block might be something like:
```ruby
  if ENV['RAILS_ENV'] == 'test'
    Rake::Task['argo:install'].invoke
    jetty_params = jettywrapper_load_config
    error = Jettywrapper.wrap(jetty_params) do
      Rake::Task['argo:repo:load'].invoke  # load 'em all!
      Rake::Task['spec'].invoke
    end
    raise "test failures: #{error}" if error
  else
    msg = 'NEVER run CI outside RAILS_ENV=="test" '
    msg += "(RAILS_ENV=#{ENV['RAILS_ENV']})"
    raise msg
  end
```


Прям весь слайд в большой лейбле?..

+`<h1>` — не самый лучший вариант, скорее `<h2>`. Посмотри внутреннюю страницу, там заголовок больше.


Smart. I think this neatly solves the `HTMLAttributesBase` issue in #5915


в этом месте я бы делал через `background-image`


Ok i understand, so to done with this, im gonna upload from now one with commit history started right now.


Nah -e gives "extreme" compression.

http://linux.die.net/man/1/lzma


Ну и будь аккуратее, пожалуйста)


Заголовок лучше делать именно заголовком. Для этого у нас есть `h1-h6` и ещё тег `header`


New Board


тут, видимо, будет опять же `<h2>`. А вот длинное тире можем вставлять через такую комбинацию в коде: `—`


great catch! :punch:


lzma -e
lzma: invalid option -- 'e'

maybe  i have the wrong lzma version.
lzma -V
LZMA command line tool 9.22
LZMA SDK 9.22


Зачем делить на 2 изображения?


Это вроде бы ссылками должно быть...


@chrlutz Can you kindly add xunit tests?


@chrlutz Please add xunit tests?


В целом — хорошо, ты молодец. Старайся оформлять код с правильными отступами сразу (существуют плагины для редакторов, если самому сложно следить за этим)


I got no beefs with your thread dude, no sense in that. I seriously doubt any of them guys care if you pull their commits or even fork a repo, it's open source. It's not like I have a dog in the deal at all. Just advice man. No more than that.


"test":"mona --timeout 0"


The issue here is that if you use the virtual keyboard Enter, Backspace or arrow keys, the browser does not update the scrollTop accordingly; that is why line 545 is calculating the position based on the caret position.

I'm not sure why it isn't working for you... I'll try to take a more in-depth look at it this weekend.


After update to 3.1 got errors on all previously worked documents:
```
File: russian.lbx 2015/10/21 v3.1 biblatex localization (PK/JW/AB)

! Package keyval Error: langjapanese undefined.

```
No japanese sources in *.bib
Only russian and english.


ok al cambio


The commit message is wrong.  cursor_value raises an exception if the cursor has no rows.  In this case, there is exactly one row with exactly one column -- containing NULL.


After update to 3.1 got errors on all previously worked documents:
```
File: russian.lbx 2015/10/21 v3.1 biblatex localization (PK/JW/AB)

! Package keyval Error: fromjapanese undefined.
```
No japanese sources in *.bib
Only russian and english.


haha


не особо понял вопрос..


No. Not true.


looks good


I would be in favour of removing comments and latin1 from the original schema definitions and letting them explode in unit tests if anyone put them in.


Because @lgarron told me to.


Work on upstream ITK files -- do not copy!


This looks like an improvement.


Good catch! I'll make the change.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3966](https://teamcity.mesosphere.io/viewLog.html?buildId=69702&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:29


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3968](https://teamcity.mesosphere.io/viewLog.html?buildId=69707&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:35


This is going to be very slow and generate a lot of garbage.

Isn't this just the same as obj[p.name] ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3967](https://teamcity.mesosphere.io/viewLog.html?buildId=69703&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:58


whitespace


me parece que los floats deben terminar con F, osea 0.8625F.


\o/


Hehe, I wrote this on a fresh install of ubuntu, so I guess i never changed to spaces on sublime. oh well!


elimina la alarma si no es necesaria, tambien del oil.


This is so weird, its recommiting a commit Louis did. but I don't know how to remove it.


@lgarron Concerned about people accidentally copy/pasting the `preload` flag without knowing the effect, and then getting preloaded and complaining? The `includeSubDomains` flag is likely to be more devastating as an accidental inclusion (and if `includeSubDomains` were fine, hard to imagine why an accidental `preload` flag would be that catastrophic).

Having more `preload` awareness seems good. :)


@intervigilium While I was working on forward porting to M, I came across this, and it doesn't seem right to me after comparing LA.AF and LA.BF branches on CAF.

I think the last 3 ifdefs shouldn't be there.

CAF's git log is a bit weird, because a change can be in one commit, and in the next it's gone. Very confusing.


Never mind, I see you're talking about the table t in which we compute `SELECT MAX(_rowid_) FROM t`, not the table that `SELECT ...` returns.


What's the rationale for removing the error message?


@yanick Done!


Always a good start. :smile: I'm going to leave some comments commit-by-commit. Get ready for your Github notifications to blow up!


В этом файле добавил только этот див


Should the Color param go here?


Why do we need LOOKUP if we have .dot()?


This doesn't seem necessary to make a constant.


Please use prefix increment operators per ITK style.


why not use this one by default? it looks very awesome!


Done


i think this description in the javadoc could be made more general


Why not just add this to Property in the first place?


I was consistent in not using spaces for this (like KeyPairs, ScalingGroups, etc.) @JMoLo, thoughts?


Is this board structure simpler than a flat board? What are the benefits of using a two-dimensional array like this?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3984](https://teamcity.mesosphere.io/viewLog.html?buildId=69770&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:51


esto esta mal. no es la idea :(


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3985](https://teamcity.mesosphere.io/viewLog.html?buildId=69771&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:03


tampoco, la idea es que uses el makefile.mine y no el .config sino todo el mundo haria commit de su makefile, que no es la idea... :)


What happens if I call

```rb
Board.new(boars_size: 'three')
```
?


yikes.


@SGOrava If this merge does not work, don't panik, we can easily revert it.


(Also, note that I don't actually intend this to be a normative document. It's a "note" at best, which means that exactly 0 people outside of the echo chamber of people that already care will read it. :) The normative work will go into Fetch and MIX and RFC 6797.)


`@type` -> `@param <F>`


My Vim defaults to tabs instead of spaces, and I can't get it fixed.


There's a lot going on in this line, and Ruby makes it possible to write a lot in a single line. What is each step here doing? Can you give each one a name to make it more readable?


Please add some validation.


This syntax (and concept) isn't supported by SQL, so if you use it then you're precluding yourself from using SQL databases.  Or, just replace the . with a _ and the SQLDAO could flatten the object structure.


:+1: Shannon just mentioned this issue to me earlier (https://github.com/Harvard-ATG/annotationsx/issues/45).


Is this the most descriptive possible name? What is this doing in addition to creating a new `Board`, and how does it differ from `Board.new`?


:+1: for thinking about bad input early on.


uf aca hay que tener mucho cuidado, ya que num_elements es en bytes pero dst->data es del tipo matrix. yo creo la suma se va a ir al cuerno. hay que hacer cast de todo a void* antes de hacer la suma. de todas formas hacer el cast es una buena practica.


I think that externs have to be as close as possible to pixijs even if
we need to use Dynamic :/

Le 06/11/2015 20:58, Adi a écrit :
>
> awesome :) it definitely didn't work in pixi 2 :)
>
> Anyway I am more inclined to set the type as |Int| so that we can
> always use hex code. Not a big fan of dynamic usage. What do you think?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mathieuanthoine/haxe-pixi/commit/7f939338ead54418c7ec55b90372246e4ff695af#commitcomment-14250601>.
>

--
Mathieu


Here's an example where using good names makes the code read like English. :+1:


Why is this change here?  isa should never be called as a function like this (see the explicit discouragement in the UNIVERSAL documentation).


A lot going on here. Can you break this down further?


I was trying to make flake8 happy. Even the latest version doesn't like this and if we want to use that for travis-ci, might as well keep this change.


I don't think there would be too much downside to piping everything through babel.


esto no se deberia modificar, no se por que?


parece estar quedando muy bueno :100:


:+1:, I love it when I see `Array#transpose`.


Can you use Ruby's implicit return to simplify this?


where is the wukong dsds config?


Also, are there any other conditions where the game is over that aren't covered here?


You need to remove "ro.telephony.ril_class=LgeLteRIL"


making a tarball depend on a built library? that's not very intuitive


What's up with removing these from the Makefile -- are we also planning to remove the source code from the repo? (Is Brennan on board with this...?)


Absolutely not. UGHUHUHUHU


Two general comments here:
1) Most of the methods on this object make sense and are nicely named, but many of them are long and dense. Don't be afraid to break them down even further until each one just does one thing.
2) How are you sure this works? This is a lot of new code to commit without any tests.


I don't know where to enter these commands. Is that in GetDesktop? My computer is not compatible with GetDesktop  My newer one probably is, but the pump died, so I can't run it.
On the page https://github.com/official-stockfish/Stockfish/commit/9c9205860c5ab0e4f3180298e3f7082be259772c I see watch, star, fork, Brows files, code, issues, pull requests, pulse, graphs, master (#486) which appears to do the same thing as Browse files?, parent link, changed files, unified/split, and view for each of the changed files.

I used code, src, pawns.cpp and then edit to make my change.  In code there is Raw, Blame, History, GetHub Desktop (which directs me to a download that does not run on my machine), Edit, Delete.

Is there a way to delete my master and then Fork from the newest master?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3986](https://teamcity.mesosphere.io/viewLog.html?buildId=69773&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:26


...although I know the tests end up in here eventually! Maybe it's an artifact of your Git workflow. It's nice to see tests checked in alongside production code because they help document what you were thinking and how it works.


Also for any certain statement related things, right now only for statement terminators.


@rpavlik Actually I made a comment in PR #260 about it, it's in the documentation.


The folder also includes the NetBeans project folder.


Thinking in terms of concepts in the domain of Tic-Tac-Toe, does a piece need to know the concept of an opponent?


Looks like I can rename my repository. Maybe that will achieve the same thing as deleting it.


los a.out los podes ingorar poniendolos en el .gitignore
no es buena idea subir binarios


Try `var App = App || {};` ;)

... don't put the wink in there, but you know what I'm sayin'.


will subclasses require access to drivingFeaturesInput (i.e., does this need to be a field?)


What are the benefits and drawbacks of making this a module rather than a class?


Nice! Yeah, I'm still using it constantly.  :)


Forgot comma.


Similarly, are the concepts related to the `View` (displaying messages, getting input) related to the responsibilities of a `Piece`? This class combines a few separate responsibilities that could be extracted to their own collaborating objects.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3987](https://teamcity.mesosphere.io/viewLog.html?buildId=69774&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:01


:+1: I think this is a good start.  We may need to expand upon this.


no, because we just make it white and then tint the sprite with the very next line. So whenever you change the color it just works.


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 137](http://teamcity.corp.dirigodev.com/viewLog.html?buildId=1658&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **FAILURE**
Summary: Tests failed: 6, passed: 0 Build time: 00:02:27
### Failed tests
```
SmokeTests.dll: SmokeTests.AdminTests.CreatePage: <no details avaliable>

SmokeTests.dll: SmokeTests.AdminTests.LoginTest: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadBlogListingPage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.LoadHomePage: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateBlogListing: <no details avaliable>

SmokeTests.dll: SmokeTests.HomePageTests.ValidateHomePage: <no details avaliable>

```


If you talk through all the things this class does and group the conceptually similar things, you'll have a good idea of what to extract where.


Здесь хорошо, но можно все вызовы тестов запихнуть в один длинный try


Hi, I saw that you added Licence.md...
Please add here:
[##Licence](/Licence.md).


Right, I'll remove them.


Looks good.  I think that takes care of the confusion.  +1 on merge from a technical perspective.  Needs another review.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3988](https://teamcity.mesosphere.io/viewLog.html?buildId=69777&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:32


Here there is some space missing around `OFFSET`, the limit query should look like:
`"LIMIT " + String.valueOf(limit) + " OFFSET " + String.valueOf(offset))`

if you don't put the spaces the raw query would look like this: `SELECT * FROM rss_items WHERE rss_feed = 1 LIMIT 10OFFSET3`. Notice that this would result into `SQLException` as the raw query would not be valid.

Otherwise, looks really nice :+1:


какой нахуй тигр?


Inheritance is a strong relationship, implying that every subclass *is an instance of* its superclass. To help think about it, I like to read the `<` symbol as "is a". Is a `Player` a `Piece`? These seem like distinct concepts, implying that 1) maybe they shouldn't rely on inheritance or 2) maybe one of them is misnamed.


This is where we test CancelledBills are created


Here we check messages are logged


Is `RootFS` the right name? Should we go for something more general (such as "Dependencies")?


Isn't this an information we already have in the layer itself?


Having two different things called "index" is confusing ... could we disambiguate this somehow? Such as rename this to ```molecularIdentifierIndices``` (which would suggest renaming other variables as well), or at least expand it to ```molecularIndexIndices```.


why not allow alias here? default value could be `@app/web` then.


Plus, this includes the responsibilities of `View`!


the String.format is redundant


LGTM


> Either "host" or "host:port".

this comment does not make sense here.


WDYM?


{@code null}


That did not work.  "Fork" at the top of the current master just redirected me to the renamed old master.


Does it make sense to use alias in this case?


Again, maybe a side effect of the order in which you checked these in, but what gives you confidence that this implementation is correct?


0.13 should be removed as well. There is no such Node and there'll never be.


Thanks for taking care of this. I did not expect any problem with my last change, so I pushed it late at night.


Hmm, so this change in itself is not valid, but it may suggest the source of the problem.  The invariant being violated by this change is that the meta-data (stored in the task context) is not being kept consistent with the actual mapped state of the physical regions.  However, it also looks like the opposite polarity of the invariant is not being maintained by the current version of the code (prior to the change).  Can you get a backtrace for your stalls to confirm this?


5255-EMS-dual-Temp-Node-Setpoints (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Node 5 should be added as well.


io.js shouldn't be needed anymore. It's not even supported by upstream currently.


http://xiper.net/collect/html-and-css-tricks/karkas-verstki/kolonki-ravnoy-visoty
я з другого рішення це взяв


Don't be afraid of long names! `display_message_and_get_response` is much more readable!


I'm with @mattsooknah - I think it would be good to have clearer names for sample barcodes and molecular indices, and then use those full names everywhere, especially here where you're referring to arrays of offsets/indices!  How about sampleIndex[Indices] and molecularIndex[Indices]?


Thanks again


Why not just make this static?


can combine the first two if statements?


Just tested, and no problems here.


I've found a different issue in the same area and created some test-cases. But your fix is correct, while mine was not. I'm glad, you pushed your changes quicker than me :-)


Is a `Controller` responsible for the same things a `View` does? Even though it's more flexible, this is really an "is a" relationship, too. Is a `Controller` a `View`?


TeamCity LabkeyTrunk :: Git sqlserver 2014 [Build 36](https://teamcity.labkey.org/viewLog.html?buildId=283365&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:21


similar comment here (and would be nice to have the same order as above).


really?


Exactly 80 in this case. Pep8 complains for everything over 79.

I have not been correcting other instances of lines longer than 80 - only code I personally write.


sensible


Здесь должно быть 12 )


> Because @lgarron told me to.

From my email:

> In section 1.1, the response has the `preload` token. I believe that's not relevant to the example; would you mind taking it out to avoid any such implication, Mike?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3989](https://teamcity.mesosphere.io/viewLog.html?buildId=69779&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:08


A suggestion: `View` and `Controller` might not be the right objects with the right combination of responsibilities for this problem domain. Instead of fitting the concepts of Tic-Tac-Toe into the structure of `View`, `Controller`, `Model`, what if your objects came directly from Tic-Tac-Toe? Even abstract concepts (`Rules`, `Game`, `Turn`) can have names and be objects!


Arg, I guess this is the only call point for `SetParent`, but it forces us to have it in the interface?


Made permanent: https://github.com/JuliaLang/julia/commit/bbec2913bd64c6e8d1ff32798909ec4042ddc374


haha


А здесь должен быть 0, т.к. результат целочисленный


Strange could it be something with keystore or something?I'm assuming when
it makes it internal it encrypts it? I.e. the encryptable=userdata option
On Nov 6, 2015 12:37 PM, "Arne Coucheron" <notifications@github.com> wrote:

> Just tested, and no problems here.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CyanogenMod/android_device_samsung_serrano-common/commit/c9db59221d0f99494fe5b826f102be1c8a751dcb#commitcomment-14251327>
> .
>


yeah, it's a little tricky since the (binaries) tgz explicitly ignores whether the intermediate source files are up-to-date and directly uses the tgz if it is available. that leads to a inconsistency when creating one of these binary tgz files will require having some other dependency already installed.


'abcd' -> runs against MAX_PATH first?


The hex value should be 0x071305 instead.


Paul, your commit looks fine from this list:

https://travis-ci.org/gramps-project/gramps/builds

It seems that the breakage started with this commit. Perhaps it is just that the tests are wrong. Here is one that fails:

```
AssertionError: 'до мая' not found in 'до май 1945'
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3990](https://teamcity.mesosphere.io/viewLog.html?buildId=69785&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:04:55


:dizzy:


Shouldn't this come later down the function? In particular, it seems that we might exit early when `id` doesn't map to any know image.


combine ifs


combine catches


Here are a few typos to fix before I merge this.

ressources should be resources
powerfull should be powerful
Solution should be lowercase
Apps should be lowercase
Terminal should be lowercase
differiante should be differentiate


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3991](https://teamcity.mesosphere.io/viewLog.html?buildId=69786&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 197 Build time: 00:05:07


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3992](https://teamcity.mesosphere.io/viewLog.html?buildId=69787&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:01


Electric-Storage-Improvements (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1425 of 1425 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.4%25-green.svg)


Any reason why we rebuild instead of cache? This has been a source of performance issues (most notably on the `rmi` codepath while determining if an image had children).


The hex value should be 0x071306 instead.


Code looks good, though indentation is weird, it should probably have one tab more.


One observation here: you're requiring all the dependencies required for the game here, but many are hidden a few levels deep in `Controller` or `Board`. That means they're tightly coupled. As you revise this, consider pulling some of the dependencies up to this level. A more flexible design might look like:

```rb
player_one = Player.new('human')
player_two = Player.new('computer')
board = Board.new(3)
game = Game.new(board, player_one, player_two)
Controller.run(game)
```

You can still allow objects that depend on each other to talk to each other and collaborate without coupling them together through inheritance or module inclusion.


removed


Generally agree. I did think about making a util function but after
thinking about it for 2 mins I decided to move on.


Ah maybe that's the purpose of the `all` flag (to at least avoid non top-level images).


Are coordinates the best, simplest UI for this game?


Ну и зашибись. Берём.


@thomas-rcv Thats exactly what I mean.
@ximex I know that it doesn't break anything but we should discuss in team if we change code styles that affect the programming syntax. Removing spaces or empty lines or something similar could be done without discussion but this affects how we want to write code. It's a minor change but this should also discussed ;)


I guess a call to `UpdateScoreData(ArmyScore)` is missing, otherwise `scoreData.current` and therefore `Sync.Score` and `Sync.ScoreAccum` will always stay empty.


line 55 and 56 are basically appending to `@app` just with this solution you are bound to `@app` while with real alias it is fully flexible.


@yaniaular can you please review this section of code, I was testing this out and I think that it wasnt working as expected to be.


No, this function was getting called with either a dict or an xform obj.


ModifyTimeBinsToUseRounding (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Oops. How embarassing. Good that you are a native speaker :blush:

I fixed them and did a force push.


The last try to run automated tests on Travis CI. Next time only rebuild project.


@yaniaular this condition never gets accomplished, what was the main target for this one?


Yes probably. I was in a bit of a rush by this point, wanted to get
something working by end of day.


waiting for emulator takes more than one minute


TeamCity LabkeyModules15.2 :: CDS postgres 9.4 [Build 41](https://teamcity.labkey.org/viewLog.html?buildId=283363&buildTypeId=LabkeyModules152_CdsPostgres93) outcome was **FAILURE**
Summary: Tests failed: 3, passed: 22 Build time: 00:35:54
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBinnedPlot: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

```


Thanks!


killing emulator before tests start.


lineIterator == null is redundant given check in constructor


check status of facebook/react-native#3621


Sorry, i did not even realize those issues were up when i committed this... but i did the reverse of this..


so ive also added an example to nautilus-js.  its slightly more up to date (using the schemaFactory).  Should we copy/paste that here? or just have this example be a .md file that links to the other example (so that they will always be in sync)?


could you clarify. node-sass-middleware must be updated to 0.9.7 because node-sass 3.3.2 requires a higher version?


thought it might be that this is a binary tarball. will be easy to get confused between the two. shouldn't a binary tarball be invalidated or not used when sources are newer than it?

these makefiles are rapidly becoming self aware.


Yeah, maybe. My device isn't using keystore, fwiw.


That seems potentially heavy on performance, especially as I see it called from `rmi` and from `images` (as part of another loop's body). Do you think it's fine, or should we cache the reverse-index?


Why not return the state itself?


I left the comment on line 1 only because this only solves it for os x, so windows and linux would still need to do that process I would assume, I don't actually know how it's set up on those OS's.


Makes sense. https://github.com/yiisoft/yii2/commit/effc4facdad9ad51cb33a2284ada8fd894222047


I'm worried by performance here given the implementation of `tagStore.References()` and `imageStore.Map()`.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.548.991e0c0a67beca24482f7053544b85f9792aa3ee](http://build.palaso.org/viewLog.html?buildId=65709&buildTypeId=bt322) outcome was **FAILURE**
Summary: Tests passed: 3287, ignored: 106; exit code 163 (new) Build time: 00:16:34


What are possibles reasons to not making a resource not un-observable? If it's unreachable?
I'm not sure if you should return an error here. Maybe you should just warn about it and proceed.
Otherwise you may get stuck to a buggy resource or something, right?


This is a good README! It had everything I needed to know to get started, including how to run the tests. :+1: :x: :100:


ah, nice.


Hmm since the examples will be a basic project, i think this directory will end up have basic implementations of the core services (Registry, patrol, web client, etc.). Since we want to show off many languages I suspect that the Web Client will be the javascript example. It's probably safe to remove this for now


I meant 1.0.2


yes, it gets invalidated when the sources are updated. however, it doesn't get invalidated if the build outputs get modified (or don't exist)


@yaniaular **```stock.quant```** model doesn't have ```lot_rma_id``` (as it was in [L115](https://github.com/vauxoo-dev/rma/commit/3fecfb881ebeb759aa836e22e02e11dc1fb6c1a4#diff-1a425653177836c3a5c9ddf2811f1a49L115) in  the commit just before this one) but it does have ```location_id```


you mean pass the state itself to schemaFactory?

if so:

because the state changes.
so if you were to pass the state then the schema's resolve functions would always return the initial values.


Hi @miigotu,
I wanted to look at this issue before but I have been sick two days without getting out of bed ...
I've been a few hours debugging the code and these are my conclusions about how SR matching results:

- Firstly, SR has a show object of episode searched
- Secondly, for each result obtained from each provider SR tries to construct an object of type show
- If SR has succes building the object, SR compared ir to the original show object. If they are equal gives it as valid result.

The problem of passing the show object to Name Parser method is that, if at any time fails to get some attribute (as in the case of incidence, attribute with name of the show) it isn't overwritten, but show object had all atributes from original show object so SR gives a valid result.

I don't know if I'll be explained well (my English is not very good...), but in short we must never send the original show to NameParser method when trying to search results.

After all, I've made some modifications to avoid passing the original show object, but would suggest that kind of show is to be analyzed. By this way SR will only compile necessary regexes to avoid false positives with invalid regexes. You can see the changes made in my fork: https://github.com/CristianBB/SickRage Could you take a look? I'll not make any pull request until we're sure it works properly.

Regars,
Cristian.


ModifyTimeBinsToUseRounding (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Having a service which automatically puts together Limba bundles from upstream software would be absolutely amazing!
Doing something like that shouldn't be too hard, as long as apps have AppStream metadata or that data can be generated.
Regarding the build-script, what Limba uses is currently based on the Travis config, but I could still change that to use a different format as default. In the end it all comes down to calling `lipkgen` anyway, and that can be done by any tool, given metadata is present :)


How is this oic_res lifecycle? Do you really need to duplicate this string? No way to ref it or something like that?


ok, sounds reasonable to me


"#warning" isn't C89. I realize intrinsics code will generally require more than a C89 compiler, but please use "#pragma message" like we do elsewhere for consistency.


Oh right, you wouldn't want to have to regenerate the schema every time. Sorry that was a silly suggestion. I should have spent some more time thinking it through


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.569.991e0c0a67beca24482f7053544b85f9792aa3ee](http://build.palaso.org/viewLog.html?buildId=65708&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3308, ignored: 125 Build time: 00:21:34


I agree that `if obj.is_valid():...` is a natural thing to write and expect to work.  I would therefore not expect a function with that name to raise an exception if the object is not valid.  The problem is that "valid" is a pretty generic term.  For simple classes it may be enough, but when you have a class with some complexity, and the function only tells you it's not "valid", it's not telling you much, and the function becomes less useful.  Think about those error messages that say nothing more than "An error occurred" when something goes wrong.  It's annoying!

There are ways of addressing this without resorting to raising exceptions.  Just throwing some ideas out there:
* Instead of returning a tuple, a custom object can be returned with a suitable `__bool__()` and/or `__nonzero__()` implementation that allows you to use it in a simple if-statement.  The object would also contain the message.
* Allow a second parameter to `is_valid()` which acts as an out-parameter to receive the message.  It could default to None, meaning the message isn't needed.  We'd need to choose/create a type to use for this; Python3 doesn't have a mutable string type and Python2 has one which is deprecated.
* Have a separate function that gives a message, like `get_validity_message()`, which returns a helpful message if the object is invalid, and just returns "Ok" or an empty string or something if the object is valid.
* Have an `is_invalid()` function which returns only a string, which is empty (therefore False) if the object is valid.  So you get the True/False validity and message all in one.  It would be nice if you could both assign and test the return value in one line (and same with the first option too!), but as far as I can tell, Python doesn't let you do this.  So if you wanted to save the message, you'd always need two lines of code.  I also don't like the prospect of double negatives, e.g. `self.assertFalse(obj.is_invalid())` or `if not obj.is_invalid(): ...`.

I would certainly prefer the name `assert_valid` if the function were to raise an exception.


Für Anfänger.
Achte auf Lesbarkeit.


I would like to keep this break here, because we're planning on replacing most of the calls below this line with stuff that's pretty substantially different.


It might make sense to calculate the Breadcrumb label and url from self.collections[0] a.k.a. the default collection, rather than duplicating its properties here.


I'm going to leave some more general feedback here, since there's plenty of line-by-line stuff elsewhere. In general, these changes make the Tic-Tac-Toe game do the things we asked you to make it do (:+1: for that), but I think it could benefit from some simplification.

I want you to revise this with an eye towards simplifying things, and think about two things in particular:

1) Go over every component (modules, classes, methods, etc.) and ask if each one is as simple as it possibly could be. If not, extract something simpler.
2) Think about the domain of Tic-Tac-Toe, and model it with the objects you create. Let the domain guide you, and think about whether the relationships between those objects in code are the same as they are in the real world.


Fix for "PagerViewModel.PreviousNode and NextNode are always null #2309"


Deleted text file.


kjlk


@medo
```
A,A,P13,P01M,
P02,G0,A,P03M,
O,O,A,P02M,
O,A,O,I0,

Exception in thread "main" java.lang.StringIndexOutOfBoundsException: String index out of range: 1
	at java.lang.String.charAt(String.java:658)
	at eg.edu.guc.rolltheball.impl.Tile.getOneDirection(Tile.java:36)
	at eg.edu.guc.rolltheball.impl.Board.isGoal(Board.java:108)
	at eg.edu.guc.rolltheball.impl.BoardProblem.isGoal(BoardProblem.java:24)
	at eg.edu.guc.rolltheball.search.Search.search(Search.java:48)
	at eg.edu.guc.rolltheball.main.Main.main(Main.java:14)
```


It's the first time I have ever seen it happen.


TeamCity LabkeyModules15.3 :: Git postgres 9.4 [Build 2](https://teamcity.labkey.org/viewLog.html?buildId=283369&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Snapshot dependency failed: LabkeyModules15.3 :: build Build time: 00:00:00


TeamCity LabkeyModules15.3 :: Git sqlserver 2014 [Build 2](https://teamcity.labkey.org/viewLog.html?buildId=283371&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **FAILURE**
Summary: Snapshot dependency failed: LabkeyModules15.3 :: build Build time: 00:00:00


Eingabe für Gleitkomma hinzugefügt. ;)


I don't know for sure. we need to investigate that. I just used the same strategy from closing.  Won't we have bad consequences if we proceed?


if i am thinking about things correctly then we will probably want to also eventually pass `dispatch` to the `schemaFactory` so that mutations can dispatch actions?


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 138](http://teamcity.corp.dirigodev.com/viewLog.html?buildId=1664&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 6 Build time: 00:01:25


`generateLinks()` seems like it should be a method on the LinkObject.


Makes me wonder if we should embed a reference to `_currently_computing_jacobian` into the base class.  It would be more MOOSEish.  What do you think?


Dispatch will be completely independent of the actual reducer. It needs to be our own thing that send the message to every service in the cloud


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1074.6c34f34d6844c5ba761d6529dafdc02b9a26e747](http://build.palaso.org/viewLog.html?buildId=65710&buildTypeId=bt431) outcome was **UNKNOWN**
Summary: Canceled (Tests passed: 483, ignored: 4; exit code 1 (new)) Build time: 00:21:23


+1

So be it. Going to fix the corresponding wrapper in riak-erlang-client.


Are these conffile names compatible with our board detection schema?


right, so they will just be able to import it like

```javascript
import {dispatch} from 'nautilus'
```

?


Offline Macros for D0-h  AuAu 200GeV Run14


nautilus-js * but yea


actually, nautilus :wink:

the npm package doesnt need a js in it