Usually it's clear what '0' stands for. Given the context of method call, it is unclear here. If this means
.getExternalLinks.get(0).click() it would be much clearer phrased as such


ModifyTimeBinsToUseRounding (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1426 of 1426 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.41%25-green.svg)


Об этом косяке знал с самого начала, но вот исправил только что. Вынес enum в отдельный класс


)))) As you can see you moved all the polymorphism to your command system. Maybe remove states system? Is it dead now?


сделано


Ditto.


исправил


Terrain should be  lowercased for consistency.


Storing a 16-bit value on a bytearray seems to "work" because micropython doesn't check the range, but you'll see that the actual value stored is wrong, only the first byte is assigned, the second is 0. With a 32-bit value it fails for another reason. Long story short, this optimisation is not possible :-(


Запишется `-1` и никогда не прочитается.


My thinking in general for currencies at this point is that as we learn of other zero decimal currencies, we confirm those in the ISO standard:

http://www.currency-iso.org/en/home/tables/table-a1.html

And in general the Gateway class maintains this list.

We've seen though that some gateways like Stripe and Paypal Express explicitly list the zero decimal currencies they support.  In those cases, we'll trust the docs for that gateway since they may have special handling in place for only those currencies.  Right now, we have a custom list for Paypal Express and a custom list for Stripe.  Their custom lists may actually conflict with
http://www.currency-iso.org/en/home/tables/table-a1.html

but that's ok.

Summary: Trust the gateway's particular docs for that gateway's adapter.  Barring that, trust the currency-iso.org site for the default list.


Terrain should be lowercased for consistency.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3580](https://teamcity.mesosphere.io/viewLog.html?buildId=68141&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:16


Cool! You guys are awesome!


I actually didn't intend to keep that.


This is the code I REALLY want to :boom: but it just keeps resisting like some :imp:


Ops, not here, but on next label =D


На всякий случай еще раз напоминаю, что текст, записанный writeUTF, содержит вспомогательные байты и "текстом" как таковым не является.


@yfdyh000 在VPS上跑了2遍nogoogleip.txt，并没有出现192.119.29.0/24这一段，也许要换个VPS才行?
出来几个印度尼西亚的零星IP，一个/24段有一个，貌似并不是GGC
36.68.97.73 4908 google.com gws
36.75.24.21 1186 google.com gws
36.75.25.158 1403 google.com gws
36.76.168.212 1536 google.com gws
36.82.44.47 2976 google.com gws
36.82.232.133 1131 google.com gws
180.246.148.105 1392 google.com gws
180.248.129.219 1192 google.com gws

找时间换个VPS再验证吧，目前就先这样了


Заказчик не знает слов "декораторов в фабрике и ее иньекции в логгер". Он
мыслит функционалом и его его изменениями.

4 ноября 2015 г., 20:20 пользователь antego <notifications@github.com>
написал:

> Здравствуйте.
> Вопрос:
> Заказчик желает форматировать вывод по своему? Т.е. с помощью определения
> декораторов в фабрике и ее иньекции в логгер. Или стоит убрать этот
> функционал из библиотеки?
>
> 2015-11-04 17:41 GMT+03:00 eugene-krivosheyev <notifications@github.com>:
>
> > Where is the *sum*?
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/antego/java-junior/commit/03191fd16005423e1d81382be5b42a5f0d7daafd#commitcomment-14184481>
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/antego/java-junior/commit/03191fd16005423e1d81382be5b42a5f0d7daafd#commitcomment-14189156>
> .
>


"Вес" колонки. У второй 0 - она занимает минимальное выделенное ей место (`InfoValueColumnWidth`), а первая в данном случае - 100% оставшегося. Это уже переделано (в случае с диалогом размеры таблицы не меняются и я обоим колонкам задаю 0.


По логике ведь интерфейс описывает поведение, которое мы может дать классу. Если BufferPrinter - интерфейс, то я бы реализовывал его состояниями. В задании просили сделать класс и подсовывать его состояниям


.figure out


valeu


Круто, но за чей счет Вы запилили эти усложнения? Например, кастомеру
важнее были тесты.

4 ноября 2015 г., 20:34 пользователь Dmitry Pugachev <
notifications@github.com> написал:

> Додумал за заказчика. Теперь он может менять формат вывод прям посреди
> вызовов api. Можно кончено и конструктор добавить
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SuperDuperPugach/java-junior/commit/78420be1945f1f1be1663c98eed7a4b860253408#commitcomment-14189539>
> .
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3581](https://teamcity.mesosphere.io/viewLog.html?buildId=68143&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:51


olmuş mu :+1:


ModifyTimeBinsToUseRounding (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I would remove `HiveMetastore` and `HdfsEnvironment` from both of these methods, it seems like those are static configuration properties of a `LocationService` implementation, so I would make the implementation get them in its constructor


Kanskje også fjerne slett-knappen for brukere som ikke er HIGHEST_ADMIN?
Og oppdatere security.yml?


Not blocking but this if condition could be extracted to a function which would be much more readable.


@dorkster Can you look into it? mods->locate() returns non-existing file, shouldn't it return empty string?


laf


It would be nice if the armrest gem can do list per region.
Better to use multithreads to list for resource groups just like what is implemented in armrest. For example
```
    def list_in_all_groups
      array = []
      threads = []
      mutex = Mutex.new

      resource_groups.each do |rg|
        threads << Thread.new(rg['name']) do |group|

          results = arm_service.list(group)

          if results && !results.empty?
            mutex.synchronize{ array << results }
          end
        end
      end

      threads.each(&:join)

      array.flatten
    end
  end
```


Of course, it's better to do that. I'm sure that when you change the type of one of arguments or add another argument you will forget to update this comment. So better to exclude this right now to make tests always up-to-date. (Now, you should argue that in this case we also shouldn't include method name in a comment because we also may forget to update comment when we'll rename a method.)


Why this `sol_blob_unref`? I'd guess you wanted a `sol_blob_ref`?


We have a code fix in that exe, so we can't use nuget to grab it :/

There fix is here: https://github.com/napernik/node/commit/d51418e488dfc6c70a277c43ece499fba4fac6f1


По папке с изображениями:
img/catalog-item-preview-1.png - лишняя
img/promo-image.png,  два других промо-изображения и карта - это jpg - прозрачность не нужна
сделала спрайт - отлично. Теперь можно смело удалять все исходники для этого спрайта.
Все остальное правильно.


All the Network Services designed and implemented by me.


Please remove those unnecessary empty lines (27-28, 40) :-)


that’s right. thank you


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.558.52019fae015fc7d3ec114b1f45b81d0c797b2fb2](http://build.palaso.org/viewLog.html?buildId=65535&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3307, ignored: 125 Build time: 00:07:56


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.559.9f24c85042b908a222a0196c19e8d931482391ab](http://build.palaso.org/viewLog.html?buildId=65536&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3307, ignored: 125 Build time: 00:07:51


Why not move `crc32` outside `Reflection`, maybe even to `3rdparty`?


Should be `terrain`.


No idea why but IMG_Load() doesn't like trying to load non-existing file, this causes crash on Android. We should check filename before loading.


Same here


on this addition, i think the package json file wasn't updated, when i try to run tests I'm getting "cannot find module"
was this tested on another computer before merging?


And here


I think the `start_url` is relative to the `manifest.json` path, this should this be `./index.html` (not 100% sure).


first add


Denne .gitignore trenger vi ikke vel ikke å laste opp.
Samme som med stillinger, kanskje også fjerne slett-knappen for brukere som ikke er HIGHEST_ADMIN og oppdatere security.yml?


Good catch


This file is removed from command line


Perhaps add a test case to show that `KnownTypesCountForUnitTest` is incremented not globally, but upon the thread-local `Reflector()` is being asked to reflect on a new type.


Das sollte vom jquery plugin datetimepicker gesetzt werden.


Du tenker på å gjøre sjekken i twig fila? Hva burde vært gjort i security? Er ikke det kun for å "hjemme" sider helt?


This commit looks good.

A general good practice is to put some of the warning message contents in the commit message so it is known what the change indends to address.


Пушк коммитит и пушит :3


This should use assertNotNull.


Ich würde sage, es ist alles vorhanden, was in Aufgabe 1 gefragt war. Good job.


The location service already checks this


Correct now https://github.com/manjaro/manjaro-tools-iso-profiles/commit/a62c5342c717c6247c4424d8cc05849356a6085b#diff-be56c9b098121c3eaca44344a8d4b858


Use a more meaningful variable name


@alvare52 DWMR. Good work here - noice. :checkered_flag:


LGTM


Thanks!


Agreed. Will go through all old tests and update where needed.


Why do you include that in `lib/` in addition to the maven reference?

Also, there can be problems when analysis engines provide core UIMA jars (which are already provided by the environment, e.g. CPE, that the pipeline runs in): https://mail-archives.apache.org/mod_mbox/uima-user/201206.mbox/%3C4FE0E60A.5060107@schor.com%3E

It is therefore preferable to declare that dependency as `provided` rather than `compile` to avoid packaging it accidentally.


Isn't the FileAlreadyExistsException something you want to assert on (make sure its thrown)? So you need a separate test method with (@Test(expected=FileAlreadyExistsException.class)).


Wow, so much better!


Forgot to edit iso variable, should be:

iso = date.replace('T',' ').replace('Z','')


Thanks, @tsurdilo. Two comments to improve the tests above. Could you take a look and squash the commits into one when you're done?


I decided to get rid of the ball as an object as i was just getting too confused with changing the collision detection code around, and so i made it into a function that can be called in the main repeatme function. I uncentered the canvas for the time being. I simplified the collision detection code for that ball as much as i could to my understanding with help from code snippets online which i will have available later in my readme.md file.


FYI @drewhk


We would need at least one test case using more than one config file.


Ja, gjøre sjekken i twig for å se om man skal rendre en knapp eller ikke.
I security kan man nekte avgang til bestemte sider, utifra hvilke rettigheter du har.
Altså:
```
- { path: ^/teamadmin/stilling/slett/, roles: ROLE_HIGHEST_ADMIN }
```


Fantastic!


Huh?


В папке проекта есть файл с техническим заданием. Наверное, ты его не заметила.
Там написанно что логотип - ссылка на главную страницу, значит img нужно обернуть в тег a


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3582](https://teamcity.mesosphere.io/viewLog.html?buildId=68144&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:57


Just for my curiosity, doesn't the [spec allow for this already](https://github.com/Microsoft/TypeScript/blob/master/doc/spec.md#361-type-parameter-lists), meaning the

> Omitting a constraint or specifying type `any` as the constraint corresponds to specifying the empty object type `{}`.

I ask because if there is a constructor that allows for no generic type parameters it becomes impossible for those paranoid folk like me to enforce (via `tslint` or equivalent) that `{}` must be explicitly specified if that's what was intended. Leading to the scenario @use-strict highlights


Removed the following warning messages:

/scratch/dashboards/MacOSX-clang6/ITK-build/KWStyle/kwsCheckSemicolonSpace.cxx:36:12: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
    while(i>=0)
          ~^ ~
1 warning generated.
/scratch/dashboards/MacOSX-clang6/ITK-build/KWStyle/kwsCheckTypedefs.cxx:178:12: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
    while(i>=0 && inWord)
          ~^ ~
1 warning generated.

/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/Utilities/KWSys/CommandLineArguments.cxx:619:23: warning: format string is not a string literal [-Wformat-nonliteral]
      sprintf(buffer, format, argument);
                      ^~~~~~
1 warning generated.
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:216:17: warning: declaration shadows a local variable [-Wshadow]
    std::string dir = kwssys::SystemTools::GetFilenamePath((*it).GetFilename());
                ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:131:44: note: previous declaration is here
bool Generator::GenerateMatrix(const char* dir,bool showAllErrors)
                                           ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:314:17: warning: declaration shadows a local variable [-Wshadow]
    std::string filename = parser.GetFilename();
                ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:135:15: note: previous declaration is here
  std::string filename = dir;
              ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:325:18: warning: declaration shadows a local variable [-Wshadow]
    unsigned int i=0;
                 ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:164:16: note: previous declaration is here
  unsigned int i = 0;
               ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:350:18: warning: declaration shadows a local variable [-Wshadow]
    unsigned int width = 90/nTests;
                 ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:193:16: note: previous declaration is here
  unsigned int width = 90/nTests;
               ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:410:18: warning: declaration shadows a local variable [-Wshadow]
    unsigned int width = 90/nTests;
                 ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:193:16: note: previous declaration is here
  unsigned int width = 90/nTests;
               ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:411:22: warning: declaration shadows a local variable [-Wshadow]
    for(unsigned int i=0;i<NUMBER_ERRORS;i++)
                     ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:164:16: note: previous declaration is here
  unsigned int i = 0;
               ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:588:23: warning: declaration shadows a local variable [-Wshadow]
     for(unsigned int i=(*itError).line;i<=(*itError).line2;i++)
                      ^
/Users/builder/external/ITK-clang-rel-x86_64-static/KWStyle/kwsGenerator.cxx:553:18: note: previous declaration is here
    unsigned int i = 0;
                 ^


We want to fail if FileAlreadyExistsException is thrown. This BZ fix is to make sure that does not happen when createGlobalDirOnNewProject is called 2+ times


PSR-2 code style.
Opening brackets should be on the same line with this if statement.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3583](https://teamcity.mesosphere.io/viewLog.html?buildId=68147&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:52


That would be nice - can you or @djberg96  put it into the gem?


Have you tested this code?


not use


Если ты даешь классу название slide-title стоит задуматься о том, что и тег тоже заголовочный - h2-h6.


Looking great - one thing I've learned since yesterday: I thought it was confusing to call extraction happening off the coast as happening on land, so I've been saying waters. I've gotten some feedback that saying submerged lands or offshore lands is preferred by the MSG. Sighing. I think we just have to define what offshore lands are, and go with that. Thoughts?


Please get the latest versions of KWSys from ITK instead.  They can be found in Modules/ThirdParty/KWsys


[Symfony code style guide.](http://symfony.com/doc/current/contributing/code/standards.html)
There should be no additional spaces with concatenation.


:+1: Cool


Hello. Can you fix this issues?


Create a constant for "metadataAnnotations" and use it in all files


тег br допустим в текстах вроде стихов, когда требуется вынужденный перенос и в адресах (это по спецификации). Крайне редко бывают случаи, когда мы не можем управлять переносом текста с помощью размера текстового блока - только тогда допустим br


First push


заголовок


br


shouldn't file name should also be part of this class?


Ja tror jeg det beste er hvis du @vegardbb kan legge inn sjekk i twig fila også. Slik at knappen ikke vises for brukere som ikke er highest admin. Vi har jo ikke lyst til administrere dette utover å passe på at det er trygt å slette overflødige stillinger. Bare søk på "is_granted" i views-mappa


first commit


I'm an aspiring grammar nerd so this will be fun. for "federally-owned" our copy editors said that when its an adverb plus an adjective, there is no hyphen. I don't know if this is the same for 18F style guide, but they kept eliminating all my hyphens in publicly-available to publicly available. If you know the answer - pass it on because I'm always trying to grow my grammar knowledge!


Gathering all inventory for a region is a rather big operation. I don't know that it should go in the armrest gem, unless the REST API has an easy way to do it. Otherwise, that's a lot of calls.


Did you forgot to remove this method?


hi dude


Weird :S


Не хватает класса помимо служебного clearfix


I mentioned this in the commit note:

> Note that I have to `reset_translation_files!` in the "ignore any interpolation
> errors" test. Without this, I think both the flow_sample.yml and
> flow_sample_interpolation.yml file are being combined which results in the test
> failing because it doesn't actually run into an interpolation error.

I can't use `using_additional_translation_file` because that simply appends to the `I18n.load_path` in the same way that `use_additional_translation_file` does (i.e. both "flow_sample.yml" and "flow_sample_interpolation.yml" end up on the load path). I think the only real alternative would be to have this test run with a different `setup` block that the one currently in use. I didn't do that as I wanted to keep this change as small as possible.


Заказчик желает изменять текст описания сообщений, выводимых логером?

4 ноября 2015 г., 20:38 пользователь eugene-krivosheyev <
notifications@github.com> написал:

> Заказчик не знает слов "декораторов в фабрике и ее иньекции в логгер". Он
> мыслит функционалом и его его изменениями.
>
> 4 ноября 2015 г., 20:20 пользователь antego <notifications@github.com>
> написал:
>
> > Здравствуйте.
> > Вопрос:
> > Заказчик желает форматировать вывод по своему? Т.е. с помощью
> определения
> > декораторов в фабрике и ее иньекции в логгер. Или стоит убрать этот
> > функционал из библиотеки?
> >
> > 2015-11-04 17:41 GMT+03:00 eugene-krivosheyev <notifications@github.com>:
>
> >
> > > Where is the *sum*?
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/antego/java-junior/commit/03191fd16005423e1d81382be5b42a5f0d7daafd#commitcomment-14184481>
>
> >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/antego/java-junior/commit/03191fd16005423e1d81382be5b42a5f0d7daafd#commitcomment-14189156>
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/antego/java-junior/commit/03191fd16005423e1d81382be5b42a5f0d7daafd#commitcomment-14189659>
> .
>


Sure, I understand. I just thought it would be good to cover that behaviour of the method with a test as well to make sure it does in fact propagate the exception in the error case...but that would be an additional test.


@reinzor, I just forgot to update the position :disappointed:


0 is a better default value

`NA↑NA↓` looks stranger than `0↑0↓`


Yes, but can any compiler check the arguments?  Presumably whoever *calls* it should be marked with `FORMAT_STRING()` so that calls to that routine would get checked.


О! Математика!


wrong path here @dannon


Fint om du gjør dette for semester også :)


Do we need this space?


That looks extremely dangerous. It changes app.action.get_all_data for all tests, so you'll encounter weird behaviour easily. In general overriding a real implementation in a tests is a bad thing to do, specially if it is not restored to its original state afterwards.


/*comment*/


comentario


Should read "on your branch" not "on your dev branch"


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3584](https://teamcity.mesosphere.io/viewLog.html?buildId=68151&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:05:05


Хорошо. Можно улучшить. Вот подсказка: https://gist.github.com/ilyubin/f7995f18a9adc1b0590b


The filename is not available at the parser, so it cannot be in this class. When spring loads the file, that's where we get the filename.


I think status 200 is returned by default so you can omit it.


I would rather test that the response is deepEqual to the expected response.


@lucabrivio It's also possible that my patch is suboptimal. I will try a modification.
Good luck with your attempts.


www


Otherwise looking great.


Sweet. I have this running via launchd as root with the .homebridge folder outside my user folder. Might allow it to run without logging in.


we have changed this a number of times, but rpm calls it "topdir".  should we just name it "RPMTOPDIR" or something?  i do like using the -D of rpmbuild rather than hack the home path.  good idea!


Just the parent (base) class.


Yes, this is fine :+1:


Any thoughts about updating tutorial to point compass arrow to North?


Intellij refactor.


Separaet Security commit plz


Separate CS comimt


Если это только для горизонтальной линии, то это лишний элемент. Линию будем делать css.


@DeanMarkTaylor Thank you very much for this fix, it has been included for version 1.9.0 about to be released.


Separate CS commit plz


From `INSTALL.txt`?  Done in 767d97ad73f5517aa26b849769330ca1a09b9225.


Yep, already had the fix on the way :)


promo-text-title - даёшь заголовочный класс. Почему бы ему не стать настоящим h2-h6 ?


Hmm.. agreed,
Lets discuss it.


br


Hi @bebraw ! Can you merge this line with the new one? I'm the same person in the end... :smile:


Даёшь заголовочный класс. Почему бы ему не стать настоящим h2-h6 ?


No. Keep the next statement separate. It's clearer. Still, the conditional structure should be:

```ruby
if ! comm.is_a(String)
   puts BlahBlah
   next
end
```

that way I can de-indent the rest of the block. I'll do that in my next commit.


I guess it's because static members can be accessed from instances (which IMO is a stupid language design). I'm not sure if something like this is legal in C++ or Java

struct A {
    static struct B {
        static void foo() {}
    }
}

A a = new A();
a.B.foo();

but in this case you'd get autocompletion for B after typing "a.". The problem is this is not a very common thing to do and starts adding types into the autocompletion list which are in most cases false positives.


Need another pair of parentheses here!  Better: `print('%r' % (key, ...))`


The starting point for this content seems different that what we sent over - which is ok. For @nicoleslaw @meiqimichelle: changing the language to learn more probably more accurately reflects the content, though not the aspiration, which was to also provide folks with public engagement opportunities (joining resource councils, commenting on environmental impact statements) - just don't want it to be lost that the public can not only learn but also participate in the leasing process for various resources.


You know what, it is in the c172p-tiedown.blend (tiedown.ac) not the c172p.blend (c172p.ac). Is it suppose to be in c172p.ac instead of tiedown.ac?

>Because as I pointed out the wing strut is part of the fuselage object (they are a single thing), and therefore making it activate the tiedowns would make the whole fuselage clickable as well. That's why we have to fake it.

You could instead do the following
>you would probably want to add the two objects in c172p.ac "TieDownLeft" and "TieDownRight" as hot spots.

You could use "TieDownLeft" and "TieDownRight"  which is attached to the wing strut and is contained in c172p.ac for the hot spot instead of "faking it". In real life they are what the strap clips to and so would be logical to be hot.
Just saying, but with that said I have no problem doing the hidden one and making it work correctly as you want it.


Nice.


The style guides for javascript state that vars and functions shouldBeInThatFormat instead of that_other_one, except for constructor functions which ShouldHaveTheFirstWordCapitalized. Also, and that is not only style but also code safety, before Ecmascript 6 it's important to use the ; to end logic blocks. Otherwise javascript may not be able to distinguish where a statement ends and another starts (take into account that javascript ignores new lines, he sees everything in one very big line of code).


ok cool, sounds good.

iSchool lobby 4pm it is =)

________________________________
From: Aaron Campbell <notifications@github.com>
Sent: November 4, 2015 11:43 AM
To: 2015SebINF1340/inf1340_2015_asst2
Cc: Sebastien Dagenais-Maniatopoulos
Subject: Re: [inf1340_2015_asst2] What do you think of this method? The code works well but I'm not sure if it is the format we want.. (304e2ac)

I am on campus, but working this afternoon. I can meet for a bit at 4:00, and we can definitely work for an hour after class. Unfortunately, I am also working tomorrow afternoon as well. Hopefully, she will give us class time.

I can meet you in the iSchool lobby at 4:00.

Best,
A-

-
Reply to this email directly or view it on GitHub<https://github.com/2015SebINF1340/inf1340_2015_asst2/commit/304e2accfd50407997026000cdea37761ca38b08#commitcomment-14188232>.

[https://avatars3.githubusercontent.com/u/14332774?v=3&s=200]<https://github.com/2015SebINF1340/inf1340_2015_asst2/commit/304e2accfd50407997026000cdea37761ca38b08#commitcomment-14188232>

What do you think of this method? The code works well but I'm not sur... · 2015SebINF1340/inf1340_2015_asst2@304e2ac<https://github.com/2015SebINF1340/inf1340_2015_asst2/commit/304e2accfd50407997026000cdea37761ca38b08#commitcomment-14188232>
github.com
...e if it is the format we want..


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.537.52019fae015fc7d3ec114b1f45b81d0c797b2fb2](http://build.palaso.org/viewLog.html?buildId=65537&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3286, ignored: 106 Build time: 00:34:05


Lol code dupliqué 5 fois ça commence à faire bcp
Déplace ca dans une methode private


居然还不碎！赶快碎觉去喵！

Mike Lei <notifications@github.com>于2015年11月5日周四 03:04写道：

> www
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hanzexu990323/lnmp-chacha20/commit/781c379210032c8c6125df667b27e0dbde0bcaaa#commitcomment-14190305>
> .
>


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


this test is now effectively equivalent to `TRUE`


Это очень грубая ошибка - блочный элемент не может находиться внутри строчного.
Черточку можно сделать на css с помощью псевдоэлемента или закодированного символа.


...never mind, I guess it takes *args and an output file keyword argument separately in Python 3.


> I'm having trouble seeing how the notifications you added will result in less noise than KVO, except when all entries are removed.

Sorting blows up the KVO. Which wouldn't be a problem, except we can't use KVO to observe changes because we make a different structure than the list (a sectioned data source).

In this case we need a notification because we only care when the list is done changing - not each fine grained notification of when the elements are moved during the sort operation

>  i'd prefer to not mix communication methods unless we absolutely have to

Its pretty common to support multiple ways of delivering notifications for events in Cocoa. Most objects you can at least use 2 methods. I don't see this as being an architectural problem.

- You can use delegation to know when the app resumes, or subscribe to the notification.
- You can set the completion block of a NSOperation or observe the isFinished property.
- You can implement the didSave method of an NSManagedObject or subscribe to the did save notification.
- …and lots of others.

The method used is mostly determined by the use case. Apple recommends KVO is only when fine grained notifications are needed. You probably shouldn't use KVO if thats not the level of detail you require.

Also we shouldn't get too worried here - we already know that using fetch requests and NSFetchResultsControllers just make these issues go away. These lists are a terrible pattern and lead to workarounds to support the UI we are developing.


You're right, TMPBUILDROOT isn't a good name.  RPMTOPDIR sounds good to me, will add another commit.


Your site is published at : http://tudada89.github.io/assign3/


Блочный элемент не может находиться внутри строчного.


@mmsxv3
It looks like a few of your team members are still missing from the list. (Or they got accidentally added to `master` instead of `develop`).


заголовок


Will fix.


If you still want the hidden "fake" hot spots and they are suppose to be in c172p.ac, do you want both left and right joined as one or as separate objects.


The term "engaged" comes from a very old proposal, before `std::optional` was adopted into `std::experimental`. I'm not a fan of that term anymore, because it's a binary state. For naming and documentation purposes, I think we should come up with something that reflects the three states. If you like engaged, I suggest:

1. engaged
2. disengaged
3. erroneous/failed

Otherwise, I'd propose:

1. active
2. empty
3. failed

There are several other terms I could think of, but let's start the discussion with these.


> Is it suppose to be in c172p.ac instead of tiedown.ac?

Yes! Since the tiedown disappears when it's removed, so you can't click on any object on it (even an invisible one) to add it back :wink:

> You could use "TieDownLeft" and "TieDownRight" which is attached to the wing strut and is contained in c172p.ac for the hot spot instead of "faking it". In real life they are what the strap clips to and so would be logical to be hot.

We could try that (didn't think of it!), but I am afraid those objects might be too small and require too much precision. I would rather have a largish area around them if that makes sense. Would you think you could do that?

> do you want both left and right joined as one or as separate objects.

Joined in a single object would be better, less xml code ;)


Why not just check whether the tab list is empty or not?


`var_array` and `searched_array` could (should) be const


please check this . metal is not available on all osx versions
https://github.com/mamedev/mame/commit/f63bd0189425751241f61df96072ca0f466bb57a


Линия делается  с помощью css. Сейчас это больше похоже на лишний элемент в разметке. Все что нужно только для красоты выносим в стили.


This is already fixed on the release branch


Remove this


And I really appreciate your help with this, as I am completely illiterate when it comes to Blender (if you just knew how long it took me to create that yellow chock....)


Yep (copy/paste error).


Линия делается с помощью css.


@cmdcolin   @deepakunni3   This is what I did to remove Environment.TEST flags in the 2.1 genometry branch as Bookmark is heavily dependent on the User object:

Also:
https://github.com/GMOD/Apollo/commit/98cc12a1f5417aa1f12c39f4a6404caaf62b87ea
and
https://github.com/GMOD/Apollo/commit/d94be3ae61145062700ec902533dd8db48d527c7

Functional tests are still a good idea, but this is how to clean it up within integration tests.   I'll create an issue for 2.0.2 #655.


Can you make it so when no bbox param is in the request all records are returned?


Minor: name of program is wrong.


Are you getting compilation errors in system_core?
I am getting weird errors after merging r26 tag


please add ```override```


shouldn't this be sorted by "circle", so we first try candidates from the current file, then workspace, then global?


I just the talk pot on this


Хорошая практика оформления телефона
<a> class="telephone" href="tel:+78122757575">тел. +7 (812) 275-75-75</a>


Odd to see you using magic numbers.


Looks like this memory is leaked. Please change the variable to be ```std::unique_ptr<UETable>```.


Names are wrong, I think.


заголовок


Your site is published at : http://涂心達.github.io/assign3/


Your site is published at : http://tudada89.github.io/assign3/


Should this be renamed?


@bgerstle LOL - you are getting too predictable. I was waiting for this when I wrote the commit message.

So, this doesn't make a lot of sense if you think about it:
1. From our code review discussion, the whole point was to *replace* the collection views with table views - taking the time to make a unified interface to support a class that is going away doesn't sound practical.
2. If this code could be unified easily, then Apple would unify it for us and UITableView would just be a subclass of UICollectionView.
3. The parts that can be DRYed up to a common interface are already DRYed up - thats what we use SSDataSources for.


This has been fixed locally.


Здесь более уместен р


I don't see where you delete these files when the module is stopped/removed?


Rename?


And here?


could be `tags->pdata[0]`


Nit: Use set comprehension on L157 and L160 to avoid making an unneeded list: `{(c.block_type, c.block_id) for c in children}`.


I also was wondering how precise you would have to be to use the Tiedown Anchor Points, I thought clicking on the strap and its hardware wasn't to difficult, but no problem, I'll do it now.


@nicoleslaw: Nicole - it's awesome to have someone else work on the words, since these processes are arcane but important. I'm not through all of them yet, but for BOEM offshore oil and gas, lease holders don't create Environmental Assessments - those fall under NEPA which requires the federal government to create EISs and EAs for major federal actions, so the only party ever creating an EIS or an EA would be the government itself.


This commit does nothing. The value is anyways defaulted. I don't really agree this is the correct fix anyway.


Mmm I like this in theory but it kind of obfuscates what's going on and also gives the mistaken impression that we can truly control framerate, whereas all we really can do is control frame *interval*, e.g. 60/1, 60/2, 60/3, etc.  I would be more in favor of using frameInterval as is but just leaving a comment somewhere.  Note that this is also a standard iOS idiom.


OK nevermind it changes in the next commit and render this comment moot


Thank you so much!


Hello,
I was wondering, won't you get a "document is not defined" error with this code being executed server side?


I don't think that I agree with this test. It implies that eql isn't transitive. In other words, although user1 == user2, user2 !== user1.


Nice work on LocationServiceBundleIT!


заголовок


This test fails. I think you meant to say

    expect(user1).to_not eql user2


I don't like it((((


I think this introduced a bug rather than fixing one. If dateend is "no more jobs will run after this date" as per the SQL file's comment, the code should instead read ```$line->dateend <= $now".
But a similar fix is indeed needed for #3798.
In fact it would even be better if the two files shared the same code rather than duplicating it.
This is a perfect example of why I always advocate for factorized code. We're not omniscient and always forget to fix the same code elsewhere. Better not have copied it in the first place.


What is a point to ifdef off #pragma once?


Yeah but it's not in the final code so it's probably not worth fixing.

Unfortunately as I was writing this patch set my ideas about what to do were evolving all the time so I often rewrote what I wrote before. Maybe it's not worth reviewing every single patch (you have already reviewed it for most of the patches before - there are just a few new ones at the end) and just have a look at the new ones and the final result.


Но это же не состояние по-умолчанию, а именно состояние, отличное от IntState или StringState, но при этом единственное для похожих по поведению состояний.


Ok, this sounds fair. I'll back that out, add some comments, and then rebase and I think we're good here.


deleting


Code Review complete. All looks good.

Some package changes will need to be added in the submit branch that has the latest KualiCo code:
Class:  kfs-core/src/main/java/org/kuali/kfs/coa/businessobject/inquiry/AccountInquirable.java:
Line 37: replace import org.kuali.rice.kns.inquiry.KualiInquirableImpl; with import org.kuali.kfs.kns.inquiry.KualiInquirableImpl;
Line 38: replace import org.kuali.rice.kns.lookup.HtmlData; with import org.kuali.kfs.kns.lookup.HtmlData;
Line 39: replace import org.kuali.rice.kns.lookup.HtmlData.AnchorHtmlData; with import org.kuali.kfs.kns.lookup.HtmlData.AnchorHtmlData;
Line 44: replace import org.kuali.rice.krad.util.KRADConstants; with import org.kuali.kfs.krad.util.KRADConstants;
Line 45: replace import org.kuali.rice.krad.util.ObjectUtils; with import org.kuali.kfs.krad.util.ObjectUtils;
Line 46: replace import org.kuali.rice.krad.util.UrlFactory; with import org.kuali.kfs.krad.util.UrlFactory;

Class: kfs-core/src/main/java/org/kuali/kfs/coa/document/authorization/AccountDocumentPresentationController.java
Line 30: replace import org.kuali.rice.kns.document.MaintenanceDocument; with import org.kuali.kfs.kns.document.MaintenanceDocument;


main class="main". Служебный класс clearfix задается блоку-ролителю, в котором лежат элементы со свойством float


вот тут clearfix уместен


So question is why now BufferPrinter is not interface? Do you have state in current  BufferPrinter?


Here i added the paddle to the canvas but it doesn't move. I also added the right and left arrow key variables, but i still have to add "addEventListener(s)" and functions to control the arrow keys in order to move thr paddle


The observations just update the entire table - so you won't get the deletion animation unless you do it this way. The other way just causes a reload.


Great! It is in the right place now. Thanks!
Nikita


`block_key` or just `block`?


заголовок


> In general, I'm not so sure it's a good idea to share fixtures between unrelated tests, but I don't think it's worth changing this now.

Agreed on both counts.


Пока нет. Но в будущем возможно.


Ah, even better.


There is a lot of motion with moving localization folders and monte updating all the files… I didn't want to get conflicts all over the place so was not doing that on purpose until we are finished up.


OK.


I think this line broke the previous layout. Can someone take a look?


This makes me wonder if the 2 new AWS dlls should have this "requireReinstallation" property set too. I know very little in this area.


Тогда чем оно отличается? может, отсутствием буферизации?


Перегрузила разметку. Список тут не нужен. Просто подряд инпуты с lables


...why...are...there...parentheses...here...?


Is it me? I can see my name on the list but I know we had trouble adding mine last Thursday and we made some changes to the files since then so I'm not sure if that deleted my name from the list.


How would fd not be >= 0? In the original path, this was under the err label, so it made sense to check for it, but here it doesn't.


hetnya


It's a non-standard should we keep it or use include guards instead?

2015-11-04 19:23 GMT+01:00 Alexandr Akulich <notifications@github.com>:

> What is a point to ifdef off #pragma once?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vincent-t/xray/commit/b46717a9083e9e711df624bff833b141c2aa9a6e#commitcomment-14190772>
> .
>


Nice error log :)


The purpose of this challenge was to create an entirely new styles.xml that would be used on devices at API level 21 or higher. You should have created the file in this path app/src/main/res/values-v21/styles.xml and then made the adjustments to utilize the material style.


Тут тоже достаточно будет блочного элемента (div) для обертки и в нем подряд инпуты с лейблами


So you guys have got several h1 header tags on this page. Although that's *technically* allowed in html5, the goal of it being allowed is to allow for embedded items to come into your page without breaking validation/Google search. Organically, it can get you booted out of search results, so you probably want to change this.


заголовок


I'm afraid this won't work everywhere.  Some parsers report fully qualified scopes (e.g. `Foo.Bar.Baz` -- with non-standard separators) and some only the direct parent (e.g. `Baz`), so I would guess this can't handle both cases, can it?


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.538.9f24c85042b908a222a0196c19e8d931482391ab](http://build.palaso.org/viewLog.html?buildId=65538&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3286, ignored: 106 Build time: 00:22:15


Let's get rid of this altogether.


@cshaver I broked it. I accidentally removed the score value from the payload. Should be working on the frontend now


Wasn't sure whether to fail the test if the method was missing or not. If we ever want unit tests to work with custom builds we'll need some way to skip excluded modules. Perhaps it could be done by checking for one alias like `.click()` and using `Qunit.skip` for this whole test?


> It's not obvious to me why you've had to introduce the setup block i.e. the stubbing of SmartAnswer::FlowRegistry.instance. It's a bit of a shame the test has become so "stubby". If nothing else, I think it would be good to explain why it's needed.

The `FlowContentItem#payload` returns a hash containing the `FlowRegistrationPresenter#title` which is looked up in the cover page ERB template. If we don't stub `SmartAnswer::FlowRegistry.instance` then the  `FlowRegistrationPresenter#title` method results in an exception because it tries to find the cover page ERB template for bridge-of-death in lib/smart_answer_flows.

I'll amend the commit note with this comment.


You and me bro, never could understand this code.  And I have actually no clue what the hell it's even supposed to do, testing `var_type` against a part of the scope!?


I have no idea how to format this line so it looks less like modem noise, but hey it's a unit test. :smiling_imp:


:+1: meant to remove that


Ist so ähnlich wie meine Lösung:
[Jahr.pdf](https://github.com/zitryss/Programmierung-I/files/27356/Jahr.pdf)


Please create a jira issue for this and link to the issue from here.


The reason for this change is to quick fix an error we saw after we did a db upgrade from 2.0 to 2.3. We have not finished the upgrade process yet, and when it is finished, I will re-evaluate this change to see if it is necessary or not.


Also, du musst erst ein Program auf deinem PC installieren. Hier ist ein [Link](https://desktop.github.com). Dann "forkst" (kopierst) das Repository und nachdem kannst du die Dateien ablegen.


invis mob is right here catbon


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.90.dc68c6199a4cc2b73aacac9b8057b99c5d257bec](http://build.palaso.org/viewLog.html?buildId=65546&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 939, ignored: 50 Build time: 00:40:32


And here too catbon


I'm not sure we want to have different tests than mainline Vim does.  Is the non-passing of 87 a serious problem that warrants a divergence?


Just `return` here


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - WIN_S2012 [Build 237](http://ci.infinispan.org/viewLog.html?buildId=31782&buildTypeId=HotRodCpp_PullRequestsMonitorWinS2012&guest=1) for a6c8a7becee52f22903995defba7646623fb0085
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:06:25


this is nice


whoopsie. good thing we waited for tests...


:+1: looks good to me


103643052-FiniteDifferenceFluxOutput (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Ага, переименовал :)


You want the normal errno, no need to reverse the sign.


@mhegazy , do you think it could be possible to remove these, including `Array`? Is there a reason for needing such loose typing? You can always opt out from type checks with `new Array<any>()`.

By the way, I'm not sure who actually still uses `new Array()` over array literals, but that is definitely not the case with `Map` and `Set`, where you always have to use the constructor.


This is not correct.  The _Annotation_'s URI was not discussed. /annotations is the Annotation List that contains the annotations that target the canvas.


"ready"


@aembler What about making this method `static`?
Otherwise he have a bounce of warnings like
`Non-static method Concrete\Core\Page\Stack\Stack::addStackToCategory() should not be called statically`


Ich kann deine PDF–Datei leider nicht öffnen. Versuch bitte noch mal abzulegen.


Не доделала еще? Я не понимаю что это за лэйблы.


Shouldn't we rather report the test 87 failure to Vim and wait for them to fix it?


Please add new lines at the end of your files.
See the red warning symbol at the bottom? That means new line at end of file is missing.


I'm getting ready to push, can you hold off making any change to bug-303 while I merge and push?


A few nits inline.


:raised_hands: amen


Да, заказчик допускает, что этот функционал потребуется в будущем.
Имена исправлены.

4 ноября 2015 г., 10:39 пользователь fomindmitry <notifications@github.com>
написал:

> Зачем было создавать интерфейс? Планируются разные реализации? И почему
> такое имя у интерфейса, ведь в результате реальный класс обзавелся странным
> именем?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/antego/java-junior/commit/6e1c102e74e20d9794a5221a993a2ccd64314841#commitcomment-14175538>
> .
>


can we keep the add times[1] > 0  check ? we hit a condition when resuming a build the times[1] is not set in this case we should return "N/A"


Not any. I read the above SAL stuff so that:
```
  extern int pcap_vsnprintf(char *, size_t, FORMAT_STRING(const char *), va_list ap);
```
expands to:
```
  extern int pcap_vsnprintf(char *, size_t, const char *, va_list ap);
```

unless using MSVC >= 1400. (not sure on the version 1400 though).


same here: can we keep the add times[1] > 0 check ? we hit a condition when resuming a build the times[1] is not set in this case we should return "N/A"


Gah...


shouldn't `typedef_file` be reset to `NULL` here?  With the logic here I fail to see how it can handle a typedef that has the definition in another file, as `typedef_file` is never res-set to `NULL` and passed to `find_scope_members_tags()` at the end.  So IIUC whenever a typedef is resolved, only this file will actually be a candidate, no matter what.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.560.7b94cb1977c24770fcd9aa68326c99cf1430b568](http://build.palaso.org/viewLog.html?buildId=65555&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3307, ignored: 125 Build time: 00:06:22


TeamCity pull requests :: netty [Build 589](https://garage.netty.io/teamcity/viewLog.html?buildId=2999&buildTypeId=pulls_netty&guest=1) is now running


I suggest using `six.moves.range` here instead of the built-in `range`.  T may be large, so avoiding an intermediate copy may be worthwhile.


continuing the discussion from https://github.com/nanomsg/nanomsg/issues/505, can we look at objectives behind some of these changes?

please compare this descriptive code comment to the one it replaced from lines 325-326. I'm weary of `NN_RCVMAXSIZE`. Does this thing actually have a default that kicks in, in order to drop connections?

If we need that kind of a default, I would hope the default is inactivation as a socketopt. Generally I want to remove obstacles to transport, not create more


right now updateMetrics takes an int, and 0 is sent if no resp code (i.e  apiserver down).  this allows anyone to call url metrics wether or not they have a status code.  maybe i could leverage an interface if i think deeper about it, but for now ill leave as is and impl other changes.


OK, done. I haven't checked to see if they both show up. For some reason only one side showed up when they were in tiedown.ac. There may be a special way to join them. I'm checking now.


Likewise `six.moves.range`.


I am testing it as well.


Thanks @FTG-003 - maybe it would be good to update the License on the peeragogy.github.io to cover "Peeragogy Organization's Github Repositories", just so that it's simple.


%s ---> %r sounds good here, but separate commit, please?  (And maybe do it consistently for all the other ones in that commit?)


statSync, or it slips


new commits on top of this layer in the `util/backoff.go`, which actually totally implements this logic for us.  Now this is changed to URLBackoff in the new commits (in this branch), and wrapps the Backoff struct.


A reason for these constructors is for the case of migrating from JS - swapping to TS suddenly requiring you add generic parameters to all of your collection constructor calls can be cumbersome, whereas with these constructors you simply get `any` types (as one many expect).


Ah, forgot... Sure!


(And while doing that -- also tuplify the % arguments: `'missing key in params: %r' % (key,)`)


J'ai aussi terminer la suppression et fait plusieurs validations suplémentaires


Yes, I believe other languages should start checking for invalid frame sizes, throwing errors, and closing the connection. Implementations are very different right now. Some don't enforce a frame size at all.

I didn't worry about updating the error codes for all languages together because they are already not consistent:
https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/TTransportException.h#L43
https://github.com/apache/thrift/blob/master/lib/csharp/src/Transport/TTransportException.cs#L59


Изначально абстрактная фабрика нужна была, чтобы использовать её в тестах, унаследовать от нее FakeFactory и подменить State. Сейчас просто унаследовал FakeFactory от StateFactory


this is now eliminated from the patch.   its now backoff.go's responsibility to  give us this if we want it


Is the hardwired path necessary?


why does this not delete?


Да не нужны они. Вы можете сделать обычную конкретную фабрику и свободно ее мокировать в тестах.


too much C++ :-) Well spotted I'll remove them


Did you turn off the csf check?


Works perfectly well, thanks a lot! :smile:


BTW, I think it would make more sense if data were stored in json ordered by exposure rather than by quantities, i.e.
```
expo1:
  filename
  outname
  etc.
expo2:
  filename
  outname
  etc.
...
```
rather than
```
filenames = [expo1_fname, expo2_fname, ...]
outnames = [expo2_oname, expo2_oname, ...]
...
```


@ravikiranse , Need to complete final step.


yep, should be -errno here, thanks for point


22.+みたいな形でversionを指定するのは非推奨です。
23.1.0が今最新です。以下のページで最新版は確認できるので、見ておきましょう。
http://developer.android.com/intl/ja/tools/support-library/features.html#design


"else if"?

We should check for "!stop"


@dimitriv: Compile with `EXTRAOPTS="--vectorize" make test_mitig-bug.out`


これも同じく


"Shutting down"?


Definitely use `six.moves.range` (or `from six.moves import range`) where the old code used `xrange`, since -- although I'm in the habit of writing `xrange` all the time for iteration no matter how small -- use of `xrange` often indicates an expectation that the size of the range will be large, which penalizes `range` in Python 2.


Why isn't this just `(unicode, bytes)`?  Why do we need a `six` indirection here?


Ik zou getters en setters weghalen, ze doen niets.


Is it used?


Because Python 3 dropped the `unicode` keyword.


memberId must be an integer.
in particular, it's a 16-bit value.


OK, can any compiler *that can check arguments to printf-like functions* (which excludes the older versions of MSVC without SAL, as well as really really old versions of GCC and some non-GCC compilers) check the arguments to a function that takes a format string and a `va_list` rather than one that takes a format string and a list of arguments to the format string?


On 11/03/2015 09:52 PM, onox wrote:
>     Version 2.1.4 in on my Linux box
>
> I find that a bit old :smile:

if that's old, then my Ubuntu 14.04 must have one that's ancient ;)

myuser@mymachine:~/myflightgear/c172p-detailed-dev$ git --version; uname --all
git version 1.9.1
Linux shadow 3.13.0-65-generic #106-Ubuntu SMP Fri Oct 2 22:08:27 UTC 2015
x86_64 x86_64 x86_64 GNU/Linux

--
  NOTE: No off-list assistance is given without prior approval.
        *Please keep mailing list traffic on the list* unless
        private contact is specifically requested and granted.


I'm just curious, what's the point of adding a "\" at end of lines like that ? :)


Looks good to me bruh.


fixed.


this fix issue #15


i think had some random tabs that i removed in the last update.


nit: import order


Urk.  What a rotten idiom this is here.  Nothing should ever rely on the ordering of `name_to_idx.keys()` -- it's nondeterministic.  I guess there's already a FIXME comment below, so this is OK for now...


This breaks deliver-lib CI - because I think some of these new versions can't be compiled correctly by old npm version used within `deliver-cli`


Т.е вы утверждаете, что если нет полей - интерфейс, в противном случае - абстрактный класс?


On 11/03/2015 09:57 PM, wlbragg wrote:
>     I find that a bit old
>
> That is odd as I just set this Debian system up and would have thought it would
> have had the newest stuff when I put it on or got the package. I don't remember
> if it came on it or I had to install it. What version is current?

remember, debian sticks with stable packages unless you are maybe running an
unstable installation... which debian is that you are running?


```
/local.properties

#for gradle, IDEA
.gradle
gradle.properties
!.idea/runConfigurations/*
.idea/copyright/
.idea/inspectionProfiles/
.idea/libraries/
.idea/*.xml
.idea/.name
build
*.iml

captures
.DS_Store
```
これは俺のgitignoreです。
gradle.propertiesの設定をいちいち上げる必要はないので、ignoreに入れてください。
あとideaフォルダはrunConfigurations以外は必要ないので消してください。


Since you are making this change, can you also remove the last five entries from me, which are basically other emails forwarded by me for testing?

-K


Ок. Пока это будет экспериментальной фичей.
On Nov 4, 2015 9:27 PM, "eugene-krivosheyev" <notifications@github.com>
wrote:

> Пока нет. Но в будущем возможно.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/antego/java-junior/commit/03191fd16005423e1d81382be5b42a5f0d7daafd#commitcomment-14190830>
> .
>


nit: missing a couple of spaces


Worth adding a comment explaining that FT_ATTACHMENT isn't searchable, otherwise this will look like an error.


Call this before set to `null`?


Good job adding alt text :+1:


このファイルもgitignoreに含まれるファイルなので、消してください。
git rm --cachedでファイルを残したまま、消してください。
http://qiita.com/megu_ma/items/a438a71c84145f14d04e


Fuck ME!


同じく


同じくあ


Ok I'll add that.


I am closing this PR to clean the commit history from the unnecessary commits, sorry @tib-tib


Send error before set the context to `null`


The method name doesn't need to be so verbose. It's clear from the arguments what it takes in. I'd just call it `input`


Ik zou hier polymorphisme gebruiken om de complexiteit beheersbaar te houden. Dus een aparte class met dezelfde interface voor IE, Mozilla, etc.


This is the protection against null hits, for @cvuosalo.
Please let me know if this is not kosher, I generally don't know what I'm doing.


Pull Request
add favorite color to list.


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1056.e334805154a4f7faea314d6a361043573c25f2ec](http://build.palaso.org/viewLog.html?buildId=65559&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 721, ignored: 6 Build time: 00:12:04


`accuracy > 0`. The extra "." is unnecessary.


Lets use decorator like in nav-block.jsx


These are defines, so they all need to be "on one line".  For example:

```c
#define SOMETHING {
   printf("SOMETHING\n");
}

int main() {
    SOMETHING
}
```

Normally, you'd expect this to translate to (logically):
```c
int main() {
   {
      printf("SOMETHING\n");
   }
}
```

But actually, it translates to:

```c
   printf("SOMETHING\n");
}

int main() {
    {
}
```

Which is a compile error.  By using the \ at the end, we tell the compiler "this isn't the end of the line yet."  And so we get the expected result.

Sure is ugly though.  In general, the C preprocessor (`#define`s etc.) is very ugly imho.

-[Unknown]


いらない記述は消去。クラス名の説明記述のみ書く
Javadoc


waitForClusterComplete better?


Fragmentで
`android.support.v4.app.`
の部分はimportできるはず。


how about use IOException for now instead of creating a new one.


No chance of a partial write here?


const


Possible fixed via https://github.com/qubitdigital/deliver-cli/pull/25


I think it would be easier to detect drinkable item by parsing its contents - just look through all Contents item infos and check if there is water or tea. No need for reflection. Plus there is much more container types than there is drinkable liquids.


On 11/04/2015 06:15 AM, wlbragg wrote:
> If we decide not to use the hidden hot spots, you would probably want to add
> the two objects in c172p.ac "TieDownLeft" and "TieDownRight" as hot spots.

might also include the ground anchors at the other end of the tie down as a hot
spot... linked with the two on the wings we could click on the wing point or the
ground point to apply the tie downs...

aslo, question... are the two tie downs linked together where clicking on one
removes both or do we need to click on each one?


hey


Leaks the buffer.


This shouldn't be necessary if the regular expressions are matching the first instance on a line, but they make me less concerned that we'll have a false match in the comments.


Is het zo dat je via het geretouneerde object de cursor en positie alsnog kan wijzigen, omdat er een referentie teruggeven wordt? Dan is het wellicht een goed idee om een kopie van de positie te retouneren.


I think I prefer the latter too, but the former should be fine for now.


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.91.84061e9aaaaebc4ff0c5328c7b448a99074e4cb5](http://build.palaso.org/viewLog.html?buildId=65553&buildTypeId=bt2) outcome was **SUCCESS**
Summary: Tests passed: 939, ignored: 50 Build time: 00:41:31


Lauraaaaaaaaaaaa


If `accuracy` does not have an acceptable value, this should raise an error.

This should also ensure that accuracy <= 1;


SingleSubtabInMemory (evanweaver) - i386-Windows-7-VisualStudio-12: OK (2333 of 2368 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.52%25-yellow.svg)


The latest commit should actually handle the latter now.

—
Sent from Mailbox

On Wed, Nov 4, 2015 at 2:00 PM, Arthur Barrett <notifications@github.com>
wrote:

> I think I prefer the latter too, but the former should be fine for now.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lduarte1991/hx-annotations-lti/commit/d5549d806d3fe08c72b009124bae29b7015b5a22#commitcomment-14191560


Possibly fixed by you coming down to the pub


Waarom is deze if nodig?


What is the reason for this change? This is rarely seen in `numpy` code and may have unexpected results in follow-on code.


serviceUri

This URI represents the URL prefix to use when forwarding requests to this node.


I'm using 4.10 Xfce Descktop environment. I'm not sure what version my Debian is, but I think it is pretty current.


Please use piwik instead, Google analytic is full of backdoors... My uBlock Origin let you recupe stats of me with piwik but not with Google spyware :p


つまりこのクラスはListFragmentを継承したクラスになるということです。


I think the right-hand set should be filtered down to just relationships.  This currently allows attributes to be valid values for `embed` e.g. `http://localhost:8000/v2/users/?embed=full_name`


ListFragmentの内部実装を追うと、(またわからなければ教えます。)なかで色々な処理をかわりにやってくれています。


Please don't use this bizarre indentation.

Same below.


Don't mind at all. It's workaround fix to release snapshot-80 and it was already reported in some Vim group. It will be gone after the Vim fixed.


Isn't the test m_core.GetNumAtts() > 0 sufficient?


Действительно, косяк. Осталось еще со времен процедурщины.


good catch! changed b5846cf126f399f0eb


In dice elf fps is slower by 10 for me. Though there is no "see-thriught" table bug in disgaea 3.
Also both with this branch and master rpcs3 crashes everytime on exit from dice elf.
Also I've encountered strange thing: with current master I get 37-40 fps in dice elf with r9 290 and solid 60 (vsync cap) fps with intel HD4600 !!! In disgaea after pause/resume trick it also seems to be 1-2 fps faster.
But again, there is never high gpu load (in dice elf it's around 20-40 % I think).

But with this branch intel HD performance is terrible. Like 2-4 fps with dice elf (100% gpu load). And it's seems to be logical only if not for those unbelievable results I have with master branch right now.


Oh, ok !
So you're actually escaping the "newline" character, right ? :)


I'm having trouble with this change.  (Just filed a [bug report](https://github.com/ansible/ansible/issues/13037))

It seems to provoke the following exception:
```
$ ansible-playbook -vvv test.yml
Using /etc/ansible/ansible.cfg as config file
Unexpected Exception: Values instance has no attribute 'serial'
the full traceback was:

Traceback (most recent call last):
  File "/usr/bin/ansible-playbook", line 84, in <module>
    sys.exit(cli.run())
  File "/usr/lib/python2.7/site-packages/ansible/cli/playbook.py", line 140, in run
    pbex = PlaybookExecutor(playbooks=self.args, inventory=inventory, variable_manager=variable_manager, loader=loader, display=self.display, options=self.options, passwords=passwords)
  File "/usr/lib/python2.7/site-packages/ansible/executor/playbook_executor.py", line 59, in __init__
    self._tqm = TaskQueueManager(inventory=inventory, variable_manager=variable_manager, loader=loader, display=display, options=options, passwords=self.passwords)
  File "/usr/lib/python2.7/site-packages/ansible/executor/task_queue_manager.py", line 97, in __init__
    num_workers = min(self._options.forks, self._options.serial, len(self._inventory.list_hosts()))
AttributeError: Values instance has no attribute 'serial'
```

Maybe a missing import somewhere?


ListFragmentを使う場合。この書き方をするとスーパークラス(ListFragment)のonCreateViewが呼ばれません。
ListFragmentを使う理由はこのonCreateViewを呼びたいからです。
その場合
このonCreateViewのメソッド自体消去してください。ListFragment(スーパークラス)内部のonCreateViewが呼ばれ、デフォルトで設定されているxmlが呼ばれます。以下の記述はonViewCreatedに書いてください。


TeamCity pull requests :: netty [Build 590](https://garage.netty.io/teamcity/viewLog.html?buildId=3000&buildTypeId=pulls_netty&guest=1) is now running


これもいりません。ListFragmentの機能であります。


これもgetAcivityで取れるのでいりません。


I think  in form.html this:
span class="require-star">*</span
should be removed, don't I? ;) But, up to you. Great job, cool!


is this field necessary? this should be available from config.getSiteIdByHost()


Shapes *aren't* special - they're just arrays. You can't call those functions on them. You should actually be able to call HH\Shapes\idx.


so remove this one :)


gondolaAddress?


Looks fine.


"Утверждаете"? Давайте без этих институтских подколов )))
Вы строите полиморфный алгоритм (в других классах), основанный на BufferPrinter. Хотите сделать BufferPrinter абстракцией. Вопрос – абстрактный класс или интерфейс?
Так вот – интерфейс дает вам гораздо больше гибкости. Если свои алгоритмы будете основывать на интерфейсах, это позволит в дальнейшем при реализации куска печати свободно использовать code reuse с помощью наследования. Интерфейс не ограничит вас в том, чтобы кусок кода печати зареюзать при помощи наследования.
Поэтому использование класса в этом месте просто связывает вам руки. И когда прилетит изменение требований касательно печати, вам придется дальше и тяжелее их реализовывать.


Let's move this under kafka


statSync does not have callback... It returns the resulting stat and that should be checked, see http://stackoverflow.com/questions/4482686/check-synchronously-if-file-directory-exists-in-node-js


Ok, so the issue is still open. We have to see what was created and why **manjaro-tools** didn't detect your login session. I think this might be still wrong:

```
		elif [ -e "$1/usr/bin/budgie-session" ] && [ -e "$1/usr/share/xsessions/budgie-session.desktop" ]; then
			default_desktop_executable="budgie-session"
			default_desktop_file="budgie-desktop"
			msg2 "Detected Budgie desktop environment"
```
We have to check what.


Is*() should be const


I would specifically use the phrase "provisioning and orchestration system" since its really whatever is being used to provision and orchestrate that is responsible.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#WUVkRxyEQ9SFu5_-1bbDbQ


Can you remove *all* the System.out calls in this method?


> might also include the ground anchors at the other end of the tie down as a hot spot...

To remove them the whole strap is clickable, bottom or top.

> aslo, question... are the two tie downs linked together where clicking on one removes both or do we need to click on each one?

They are a single object.


s/execute/implement/


serverAddress -> gondolaAddress.
i think would be clearer if we use this term everywhere.


Ahh - fair enough. You are right. Yep. I will add that back.


> A reason for these constructors is for the case of migrating from JS

Ah I see now (ignore my previous comment)

To my mind use of such constructors should constitute an error if `noImplicitAny` is set... is that doable/some sort of compromise?


@aluitink Yeah. You probably want to swallow errors from CopyToAsync.


За которую я буду платить из своего кармана. За code review, документирование, покрытие тестами. Меня это печалит.


TeamCity Chorus :: chorus-precise64-master Continuous [Build 2.6.513.84061e9aaaaebc4ff0c5328c7b448a99074e4cb5](http://build.palaso.org/viewLog.html?buildId=65551&buildTypeId=bt323) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 927, ignored: 54 Build time: 00:36:28


It would be very well possible for fake players to be not included in the event but the `Player` or `User` included instead, this way we have that sort of differentiation.

I would honestly have it as a requirement for there to be a `GameProfile` or name associated with a `PlayerSimulator`, otherwise the default would be the `ServerGovernedSimulator` or something of that kind.


I wouldn't confuse with hybrid. Since the `temp` token is pulled and not pushed, lets just refer to this as `pull`


Doing this disables PAM by default on all installations. This is probably not what you want.


Here too, just errno.


Indeed. I just saw you turned it off, but it obviously cause compilation fail.


usually a listener event contains a code that describes what changed - e.g. added, removed, updated, etc.
I'm not sure if it's needed or not since I don't full understand when the event is created.


Looks fine.


typo "via"


Looks good.


"&> /dev/null" is supressing error messages that is not good in case of error


And here.


Try not to require this config here. There are many ways of doing this, for example:
A) put config vaules as const values in Storage class
B) create Config class with those values stored as array (with additional function to get those values as you need them) + inject object of that class wherever you need it.

I think we can do it together as pair programming excersise. We will first try A and then we will convert it to solution B.


initialize in instance var.


Consider "Overall, a co-process based approach requires little support from the provisioning and orchestration systems and minimal changes to applications."


initialize in instance var


Hello,

Can you add the argument ```from_version```` for the new output values and add input argument ```with_prev_next_info``` in the brand loop.

Thank you !

Nb : I'm sorry ! I'm a tyrant :)

Thank you !


Hey Zac. I just double checked. Diamonds is part of the ggplot2 package so I'm going to change this back. Good check though.


Nueva clase implementaciom


Need to add a check on the '$' object, it might not exist (I think Chrome adds it, but I wouldn't depend on it)
```js
var $ = (window || {} ).jQuery || {} // I think jQuery trumps '$'
```


how about IOException instead?


またListFragmentとは別の話で混乱しそうなのですが、この部分は全くレビューとしてみてください。
container.findViewByIdとやっていますが、そもそもこの状況では、岡田くんがほしいxmlがセットされていない状況です。
なぜかというとFragmentにおいて(また他のAdapterなどにおいても)、xml(R.layout.hogehoge)でfindViewByIdしたいときには、まずinflate(増やす)する必要があります。
具体的にはonCreateViewの引数を使って、
```
View view = inflater.inflate(R.layout.hoge, container, false);
```
にしてください。これでxmlが追加されました。
あとはview.findViewByIdでlistViewのidをとるとデータがとれます。


This still needs to be pushed to npm:

```
npm publish
```


That's a good place to run some code, but try to add it where application runs actual processing.
This file was supposed to be only a running script. Apart of that, the code below is not that bad, see the comments below.


Doesn't jquery _steal_ the `$` scope when loaded?


Or, better yet. Don't run the jQuery code at all, if we don't have it in scope (and issue a warning)...


Exactly.

-[Unknown]


De Pico.UI.Container is een implementatie detail. Ik zou daarom PicoExtend niet public maken, en een nieuwe methode Pico.UI.Window::add maken die delegeert naar de private container.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3589](https://teamcity.mesosphere.io/viewLog.html?buildId=68213&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:07:43


Would you mind using Markdown syntax instead (`.` instead of `)` after each numeral)?

1) test
2) test
3) test

1. test
2. test
3. test


yes @olesalscheider you are right
i'm going to add an option which is ON by default


103643052-FiniteDifferenceFluxOutput (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (887 of 887 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.57%25-green.svg)


since this is a specific impl, maybe "curator" instead of "client" would be clearer.


Do we maybe want this to be in a callout block, such as a NOTE or WARNING?


Sorry for late review.
Would it not be nicer if start_on_load_handler_process() was called once
as the first thing in boot/3. Then we don't need a special case for init:restart.
I can't see that it would matter if on_load handler was started after the argument parsing
in boot/1.


これもまた上記の話ですが、
基本的にonCreateViewには(一部省略)
```
onCreateview(){
　　return inflater.inflate(R.layout.hoge, container, false);
}
```
のみ書いてください。そのあとに呼ばれるonViewCreatedでfindViewByIdしてください。
```
onViewCreated(View view){
　　view.findViewById ...
}
```


If you put it into some class (you probably know where), you will probably add use DependencyInjectionTraining\Entity\User and then you will just create a new User object with new User(..., ..., ...) instead of full class name with namespace. The code will be cleaner then.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3590](https://teamcity.mesosphere.io/viewLog.html?buildId=68235&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:52


That's what I was thinking. I can change it to be a warning block. :warning:


i wonder why you removed $date parameter here?


Hmm, not following here, really. Note that parse_proc_cmdline() already diverts to /proc/1/cmdline in case we are running in a container. Why do we need an additional layer for this?


Wouldn't it be better to use `body` local variable here, since it is already defined and compiler knows it is not nil?


上記方法でもlistViewはnull出なくなるはずです。


I hate repeating myself, but how is that related to this patch?


Should this block of code execute even if `Content-Type` is not `application/x-www-form-urlencoded`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3587](https://teamcity.mesosphere.io/viewLog.html?buildId=68211&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:11:28


same comment about `existingFiles`


Theoretically it can also throw TimeoutException right?


上記の番外編から戻ってListFragmentから実装するとするとここで、
```
setListAdapter(adapter);
```
をしてください。勝手に描画されます。


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3586](https://teamcity.mesosphere.io/viewLog.html?buildId=68210&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:11:54


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3588](https://teamcity.mesosphere.io/viewLog.html?buildId=68212&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:11:54


I think it would be cleaner to wrap these 3 methods in try / catch Exception throw new IOException.
and then have all these methods throw Exception.
this will eliminate unnecessary try/catches.


上記をする場合、この行は削除です。


It should be named shouldStringBufferNOTPrintedInsideStringState
It's about switching to same state - in this case print buffer should not called (for integers and strings)
Now i'm making new separated tests for fabric and states and I will push it after a while.
And I think current test will not be important.


How to help ?


What is $columnName1 and $columnName2 ? Are these names correct? Why not to try passing User object here instead two values?
What about function name? insertData2Store is pretty long and confusing. Let's pick a better one like storeUser().


Probably not important, as IIUC 00146c2966550f958e6455bd13150b3327fdf58e fixes this anyway


You should use using `!=`, remember.


Axon:
> Would you mind using Markdown syntax instead (`.` instead of `)` after each numeral)?
>
> 1) test
> 2) test
> 3) test
>
> 1. test
> 2. test
> 3. test
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/adrelanos/qubes-doc/commit/8e103caad7535ef00f93b07397ee33a2168d4d19#commitcomment-14191955
>

I explicitly did not. Please have a look at the actual resulting page:
https://www.qubes-os.org/doc/vpn/

It contains three times "1.".


@taylorotwell @milon

It's better to you use a daily log system to avoid a big & massive single log file in production environment.

And also, many of artisans use packages like a log viewer to read there log files and it may crash or having some performance issues to their apps if they use a single log system.


Why do we filter this? I don't know how Hive partition storage locations work, but it seems weird that we're ignoring some of the partitions


Thank you! We do translations on [Crowdin](https://crowdin.com/project/tunnelblick), so I have changed it there instead of accepting the patch.

The change won't show up in the Tunnelblick source code until shortly before the next release because Crowdin translations are merged into Tunnelblick just before each release.

If you (or anyone) would like to help translate for us on Crowdin, please email developers@tunnelblick.net.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3591](https://teamcity.mesosphere.io/viewLog.html?buildId=68236&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:46


Понял, спасибо. Исправлю


xmlのフォーマットがちょいちょいおかしい。


good idea ;)


コマンド + shitf + Lでフォーマットきれいにしてください。


これもgit rm --cached


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3585](https://teamcity.mesosphere.io/viewLog.html?buildId=68209&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:15:38


Is this intentional?


in template_editor.php

line no 206-210 supposed to show a save button to save the template. including a hidden canvas. It's gone now. Please get the button back on place. see the scripts


Let me test that out.


Mergeó mal, estoy arreglándolo. Había que mergear antes de hacer más cambios...


Trivial maybe, but due to lazy evaluation, if either cb->action or cb->subsystem are NULL, the next condition won't be checked, so it could just be the string comparison.


What does it mean?
Change kek for some other string?


Well, each day a new knowlages :smile: !
Of course it works both ways. Because `errorChannel` header is the same `TemporaryReplyChannel`:
```
TemporaryReplyChannel tempReplyChannel = new TemporaryReplyChannel();
		requestMessage = MessageBuilder.fromMessage(requestMessage).setReplyChannel(tempReplyChannel).
				setErrorChannel(tempReplyChannel).build();

```

The polishing looks good.
Feel free to merge


Great job using actual content. :smile:


Hello,

Why not ?
```php
public function addValues(array $values)
```

;)


Yes. I can document it here, but it's probably not worth documenting at KafkaConsumer.commitSync since it would just waste people's time trying to handle it.


should probability be 2.3.10 since there are no breaking changes.


Maybe name this `LocationPolicy`? I don't really care, but "service" seems a little odd in this case


seems like a pretty narrow fix.  is this the only module that does such a thing?


Not "other". But string values explicitly expressing scenario you test.
"String that should be logged" or "String to log" fill fit ))


... or kill.


Nope, I'll remove.


@arcanedev-maroc +1


have rabbit as the default and put L57 in README under section Kafka. Also it would be good to give instructions on how to have kafka running, unless you didn't do anything special other than getting it from their site and running it.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.561.2351931ff13275a8ebbfa2213bc6e9859cf58334](http://build.palaso.org/viewLog.html?buildId=65565&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3307, ignored: 125 Build time: 00:07:43


Just added an example. Opened a [PR](https://github.com/ciaranj/node-oauth/pull/272)


"String that should be logged without duplication" fill fit


**SUCCESS** - TeamCity HotRod C++ Client :: Pull requests monitor - RHEL6 [Build 270](http://ci.infinispan.org/viewLog.html?buildId=31784&buildTypeId=HotRodCpp_PullRequestsMonitorRhel6&guest=1) for a6c8a7becee52f22903995defba7646623fb0085
Tests: 0, 0 failed (0 new), 0 ignored. Build time: 00:07:39


check if these files exists: /usr/bin/budgie-session and /usr/share/xsessions/budgie-session.desktop. If not, tell me how we should check for budgie then.


I feel this timing-dependent check it a bit too much and vulnerable to testing environments; in fact, personally I think the two tests in ConsumerCoordinatorTest is sufficient, as we usually do not test on "how much time a server can take to process one request".


Change the & to an & to escape the character


TeamCity pull requests :: netty [Build 589](https://garage.netty.io/teamcity/viewLog.html?buildId=2999&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5643, ignored: 21 Build time: 00:41:47


Maybe it is now **budgie-desktop.desktop**


Who wears a watch on the hand itself, and why is wearing one going to interfere with one's ability to do manual dexterity related tasks? Also, what kind of weird hand-watch covers 20% of your entire hand?


this. is not needed


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3593](https://teamcity.mesosphere.io/viewLog.html?buildId=68239&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:18


OOPS! Accidentally committed this.


I don't know, only a subset of people building packages intend to submit them to CRAN and this would add a bunch of warnings that are perhaps not relevant?


Das Rezept bitte für meta-openembedded/meta-networking/recipes-support/openvpn streichen


INSANEEE! That's why I love you :heart:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3592](https://teamcity.mesosphere.io/viewLog.html?buildId=68238&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:03:19


I would say yes to the use of "(e)" to match both genders. This is a widely used technique :+1:


Uggg.


Because $_POST['date'] is not being passed from the template, it is causes a warning.

When you post a note a date field is set in the template and I assume this code was copied from there originally.


meta-openembedded/meta-networking/recipes-support/openvpn stattdessen bitte updaten


Oops, this was actually already done in 6ce0700568b4824e58e230bb29a2a9ffce57d015


что за фигня?


Это что такое!?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3594](https://teamcity.mesosphere.io/viewLog.html?buildId=68240&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:50


A .swp file creeped into your commit. Please remove.


Ты совсем дурак?


bitte in e87072fcf squashen


There's also a `.trim()` in the README.md which can be removed.


Works great! :clap:

Thanks for the mention!


not sure what this list is. don't quite understand myHosts.


reading this again, I guess the author didn't know a ClassCastException would be thrown - probably a different language would have just returned 'null' if the cast failed...


I'd personally find "where relevant" clearer than "as they are relevant", unless I'm misinterpreting the meaning. Not sure if that's just me though or if that would be true in general.


SOL_ERR might abort, we tend to use SOL_WRN instead. And for the EINTR case, it isn't even WRN worthy.
However, what about EAGAIN?


In 6020c94 squashen


I guess I agree. This behavior is really an implementation detail. It doesn't affect the correctness of KafkaConsumer. I'll remove the test case.


There's also a `.trim()` in the README.md which can be removed.

On Wed, Nov 4, 2015 at 2:20 PM, Kyle Mitchell <notifications@github.com> wrote:
> Upgrade to spdx-exceptions@1.0.4
>
> Thanks to @cscott's kemitchell/spdx-exceptions.json#2, spdx-exceptions
> strings no longer contain trailing whitespace, so there is no need to
> trim them before feeding to the parser generator.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/kemitchell/spdx-expression-parse.js/commit/33eecfc3f9b411bcc78d1a95557d4322e92a2f3e

--
                         ( http://cscott.net/ )


Doest this implementation mean that the RotoPaint curves now has the ability to be moved with a transform overlay and able to link to any tracker individually?


yep, I remember doing this same neutering code.


What I have now - is Factory tests - I will correct that


Did you remove this loop on purpose?


Another way to do this would be `!!processing`.


Ukrainian locale sync


The main reason for issuing this patch was that during real life training sessions the response time was not good with previous code (waiting 3 seconds of inactivity to declare speed as null and then stopping without slowdown). Thereby the video was not smooth.
Using this fix you can see that the speed will decrease smoothly when you stop (speed shown on screen & video synchronisation).

In addition the distance shown during training is based on speed only (not on sensor distance values which is not considered) thus any time you stop cycling the distance still increase. This is not significant but this disturb me...

In my opinion this patch creates more accurate display but do not introduce any bug or issue. It reflect more closely the real life (your speed cannot be more than D x rpm x ... If you do not detect the sensor then you know that rpm is less than assumed)

In any case maybe we can adjust the trigger to detect null speed and null cadence (setup to 4 rpm in my patch)

I hope I was clear.

I already used this code on an arduino connected to ANT chip which was used as bicycle computer.
None of previous or my code are part of ANT specification (chapter 4.4.1 "speed computation" from "bike speed and cadence device profile" document)


User etc. muss wahrscheinlich auch noch gefixt werden ...


Just the suggestion to remove all the System.out.printn calls.


plan to fix it


TeamCity pull requests :: netty [Build 590](https://garage.netty.io/teamcity/viewLog.html?buildId=3000&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5241, ignored: 21 Build time: 00:25:52


cool, thanks!

> On Nov 4, 2015, at 10:12 AM, Christopher Beck <notifications@github.com> wrote:
>
> Similarly, you can replace lines 14 - 16 with:
>
> <%= render @topic.posts %>
> —
> Reply to this email directly or view it on GitHub <https://github.com/dkempner1/bloccit/commit/a9915ecd2f2c4d57082d70feefd8993387443ae1#commitcomment-14188958>.
>


103643052-FiniteDifferenceFluxOutput (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1952 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.54%25-yellow.svg)


@alaricb not a good place to report an issue (I assume you're the same person that started the stack overflow thread). We build with java 8 and using the `./mvnw.bat` command (for windows).


Same here with columnNames and function name.
Maybe the name getUserByNameAndEmailAddress() would be better? But, selecting something here by name and address is probably not a good idea, as the only thing you will get is an Id.
Maybe let's create a function which gets All users first.


There is a trailing whitespace here breaking the build


The thing here is to find the type nearest to the position where we are editing - we don't care much where the variable of this type was defined. So assume for example files

file a.c:
class A {
//something
}

A a;

file b.c:
class B {
//something
}

B a;

Now assume we are editing inside a.c and we type "a." Now even if we find the "wrong" "a" first inside b.c, next we search for the nearest definition of the type which is found in a.c and we get autocompletion from A.


Hier fehlt dann die Umstellung in der distro/rdm.conf auf preferred_version 2%


pic


Not really sure what does this mean. This function performs select and then returning one of the arguments with PHP.EOL?


Thank you!


I'd recommend using sha256 sum instead and give the expected result.


Тогда придется делать реализацию этих методов во всех потомках. А они во многих потомках не нужны. Я думал в стандартной реализации просто выкидывать исключения.


Hi,
From the doc
> Invoked once, only on the client (not on the server), immediately after the initial rendering


EAGAIN won't happen because you read a single event and break the loop, ok. I do wonder, though, if the poll is level triggered for that case.


fixed with https://github.com/manjaro/manjaro-tools/commit/3ed620a27f241ab1951678bd803d4724c7b6f368


No, CONFIGURATION_FILE would get defined on the command line, or by menu selection,

It gets used in MarlinFirmware.h to pull in the top level of the configuration.
That will, in turn, pull in lower levels. Eventually, the default values will be considered for anything not yet defined.


Wow.


We have [guards](https://github.com/jquery/jquery/blob/769446c69775f6c44e35cee1bcdeccafba51be7b/test/unit/css.js#L1) for [some](https://github.com/jquery/jquery/blob/769446c69775f6c44e35cee1bcdeccafba51be7b/test/unit/wrap.js#L3-L5) other modules although they just skip tests definition.

QUnit.skip sounds better to me than dummy `assert.ok`s - the latter is a pattern we have in many files (although usually not because of a missing jQuery API but a browser one) but we didn't have QUnit.skip back then.


@somewebmedia nomenclature aside, this is the reasoning behind this: https://github.com/zurb/foundation/issues/6921


tested on ubuntu 14.04


It looks fine to me. :smile:


I've found XDebug always return fixed `line_start=11, line_end=13` for the anonymous function no matter if the file is modified (https://github.com/sebastianbergmann/php-code-coverage/blob/master/tests/_files/source_with_class_and_anonymous_function.php)

@derickr Could you help me with this?


That's what the linter was asserting. I've found I can convert it to single space. https://github.com/tkruse/design/pull/1


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3595](https://teamcity.mesosphere.io/viewLog.html?buildId=68242&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:05:04


TeamCity pull requests :: netty [Build 591](https://garage.netty.io/teamcity/viewLog.html?buildId=3001&buildTypeId=pulls_netty&guest=1) is now running


complete = false;
t = now
while (now - t < timeoutMs && !complete)
    complete = true;
    for (hostId ... )
       Stat stat = curator.check....
       if (stat == null)
         complete = false;
       Thread.sleep(RETRY_DELAY_MS);  // maybe 10ms?
    }
}

don't catch interrupted. let it flow through as ioexception.


ModifyTimeBinsToUseRounding (JasonGlazer) - Win64-Windows-7-VisualStudio-12: OK (1962 of 1962 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


You should try to keep the constant, if not in MetaK, then somewhere else.
This is always a bad idea.


no need for try. throw Exception (or some more specific exception)


Here too. Constant instead of string instance please.


Yep, I'm afraid this is the case. But should be OK at least for the parsers from c.c.


are you sure?


Same as previous. Handling of anonymous variables should be encapsulated in a single place, like a specialized class.


Don't you miss the case here where either action or subsystem is NULL?


Ack'ing the write before replication sounds like something MongoDB would do :P


Same here.


Melhorar utilização do PSR-1


Maybe change Var name??


Similar comment.


Сюда тоже наверное нужно добавить https://github.com/instantsoft/icms2/blob/master/update/install.sql#L25


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.539.7b94cb1977c24770fcd9aa68326c99cf1430b568](http://build.palaso.org/viewLog.html?buildId=65554&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3286, ignored: 106 Build time: 00:29:19


Nit: `module_state` is only used once.  No need for an intermediate variable.


looks like you're breaking the logic. the comment says it clearly. IF there is NO association, then it's available.
can't accept the fix like this.

Please make each fix separately.


Yeah :+1:


missing comma


@cloakfox this commit is open as PR #245 and has not yet been pulled into the main repository


@iluwatar Not trying to be annoying, but is this alternative name from GoF? Thanks for your time to answer.


No it should not.


although, nvm, the if condition before didn't make sense...
I'll merge. Thanks!


why changed to old notation ?


O Laravel já possui uma forma de retorno de json quando o valor retornado está em formato array.


Yes, but that's because the Markdown syntax is not correct in the first place, isn't it?

I'm not sure why we should intentionally abandon Markdown syntax for numbered lists here instead of just implementing it correctly.


Maybe clarify as, "Return `True` if selected block should be removed."


This ignores partitions whose directory that is under the table directory. Say, you don't need to add `/a/b/c` if you've already added `/a/b`.


Ok you got me there. OTOH I imagined a modern gcc with it's `__builtin_va_list` could do that. But I failed to find a reference to that.


I am assuming that you will take out these?


Why is this being removed?
I think we have use cases when we want to parse with the ground parser, or the rule parser (of the main module).
I think only the `newprogram` should be removed.


This means constant assignments create a temporary alloca - not sure we want this.


building on openwrt:
eigrp_update.c:185:7: error: format not a string literal and no format arguments [-Werror=format-security]
       zlog_info (alist->name);
please update
--- a/eigrpd/eigrp_update.c
+++ b/eigrpd/eigrp_update.c
@@ -182,7 +182,7 @@

                          if (alist) {
                                  zlog_info ("ALIST:");
-                                 zlog_info (alist->name);
+                                 zlog_info ("%s", alist->name);
                          } else {
                                  zlog_info("ALIST je prazdny");


Yes. As mentioned in the commit message "Also change existing tests to not write into existing partitions or existing
unpartitioned tables unless it's the primary subject of the test."


Or alternatively, if `noImplicitAny === false` then treat omitted generic constraints as `any`. But if `noImplicitAny === true` then treat omitted constraints as `{}`.

```typescript
// for what follows assume we no longer have this definition
// new (): Map<any, any>;

// with noImplicitAny === true
let x = new Map(); // x is Map<{}, {}>;

// with noImplicitAny === false
let x = new Map(); // x is Map<any, any>
```

This hopefully satisfies both camps. And obviates the need to define these additional constructor types.

That said, I have no idea how sensible/feasible this is. Even if it is feasible you may not want to overload `noImplicitAny` in this way...


Commented out because it shows as background when using icons layout and user has overridden icon using GUI 306 when default background is used


Its in the topper view now, just beside the signin/registration button

Sent from Yahoo Mail on Android

From:"Tajuddin Khandaker" <notifications@github.com>
Date:Thu, 5 Nov, 2015 at 1:21 AM
Subject:Re: [WebBuilder] Views added for Control Palette (ea32cc2)

in template_editor.php

line no 206-210 supposed to show a save button to save the template. including a hidden canvas. It's gone now. Please get the button back on place. see the scripts

—
Reply to this email directly or view it on GitHub.￼


Product::where('cod', '=', $cod) é o mesmo que Product::where('cod', $cod)


Should be better now :)


@talumbau said:
> What is the reason for this change? This is rarely seen in numpy code and may have unexpected results in follow-on code.

What "unexpected results" could happen?  Isn't array in the numpy core package?


TeamCity pull requests :: netty [Build 592](https://garage.netty.io/teamcity/viewLog.html?buildId=3006&buildTypeId=pulls_netty&guest=1) is now running


Also, the deployment config controller shouldn't have access to build configs.  This check may be too much.


Nit: not a method.


hahaha


And there's no guarantee that the build that generates an image stream is in your namespace.


please delete this line altogether.


Nit: Not a method.


Also.... this is loading EVERY build config in EVERY namespace, which is a crazy performance hit just to display an error.

We shouldn't be doing this.


I would imagine it's not very common for a module to be writing into read-only memory.


Yup, you're right (see https://github.com/killbill/killbill-adyen-plugin/commit/33c42a498799496ec4bf2d2cf45d4d388c77f51e).


Great that you managed to fix this! It's been bugging me a lot. Any idea on when the next release will be?


Yeah, it makes sense. Thanks.


This commit helped save your grade on this project.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3596](https://teamcity.mesosphere.io/viewLog.html?buildId=68247&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:05:00


Fair enough :)


just looked it up. This bridge goes over goldwater, not greenway. So the name should be "goldbridge"


This code is absolutely remarkable. I remember spending something like 3 hours looking at it. I think at one point I "understood" it:

1. the whole s_backup variable serves just for obfuscating the code
2. the only "valuable" thing is the "if (i == j) continue;" which if I remember correctly somehow skips variables of types which also appear in the scope (but why?)

I spent that much time with this code because I couldn't believe someone would write something like that without any reason...


The current version in git... It already uses the syntax you suggested.
And leads to the "multiple 1." issue. I wouldn't know how else to fix
it. I don't think this can be fixed with the current implementation of
markdown. It gets confused by the pictures in the middle. There doesn't
seem to be a promising place to report a bug against markdown either.


Ajustar seed de **groups** e rules


Yes, that's the quasi-standard approach. And `click` is as good a choice as anything else.


Separarar em diferentes requisições. Uma para cada  método http.