`<br>` does not need a closing tag, also please don't use `<br>`-s :) use paragraphs in this case


应该要改成local变量吧


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6901](https://teamcity.mesosphere.io/viewLog.html?buildId=81518&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:15


Love your strings :)


Well what you described is something specific to your use case.
The method isn't being invoked from anywhere in the code. Don't see the need of it. If you are trying to add a util method which will be helpful for different implementations then call it 'pauseScanning'


Great commit message :)


Checking for the type of just one snapshot looks wrong to me. What if the first snapshot is `type != :POST`and the second one is `type == :POST`? In that case you will not delete the corresponding pre snapshot for the second one, something the original code did.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6902](https://teamcity.mesosphere.io/viewLog.html?buildId=81519&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:56


BTW, mixing refactoring/polishing of old code in the same commit that this new feature makes review and bug hunting harder. Can you split it in one commit for the cleanup and another one for the multidelete thingy?


可以把post_tag tag表的表结构定义下firekylin.sql里面么


Hello, I also had to add the following lines after the new of three GanttBars and the MileStone. In order to display Chinese word correctly.
$t_activity_main->caption->SetFont( $t_graph_font,FS_NORMAL,10);
$t_activity_main->title->SetFont( $t_graph_font,FS_NORMAL,10);


@AndrKlesh @Omennight
Любой текст следует выносить в ресурсы


state = state = ?


Great !! :) thanks a lot


File rename


`wScriptStack:: ds 3 * 5`


NP: we usually indent this one tab less


setting to 9 didn't work for me. If I plug in with USB it immediately starts beeping, turning failsafe and vbatt off did not stop it either.


I was discussing this linking issue with Jason, sorry you were not in CC. Below is that discussion:

> Ok, thanks. I had to add libjournal.la and libcls_journal_client.la to
> rbd_LDADD to be able to use journal:: and cls::journal:: methods. I
> also wanted to use librbd::Journal (I was planning to add
> librbd::Journal::reset(), similarly to librbd::Journal::create/remove()
> we have now) but it fails to link with "undefined reference to
> librbd::Journal::reset" error, when I try to use it from
> tools/rbd/action/Journal.cc.

That's most likely because rbd links with librbd.so, which only exports the public API symbols.

>
> Do you have any idea how it could be resolved? Right now I added
> reset() implementation directly to tools/rbd/action/Journal.cc, it
> works but I had to redefine CLIENT_DESCRIPTION, which is defined in
> librbd/Journal.cc.
>

Hmm, this might be tricky.  Normally, you could just create a new library, add it to noinst_LTLIBRARIES, and just link librbd and rbd against that new library.  The issue is that Journal.cc needs lots of things defined within librbd, so you would end up mixing static and dynamic library definitions.  If you could segregate the functions to a new class such as librbd/journal/Utils.cc which only depends on libjournal, you could statically link that as a new library in rbd / librbd.

--

Jason


@jdurgin  --yes-i-really-really-mean-it and additional checks on import/reset is a good idea, I will do it.


TeamCity pull requests :: netty [Build 757](https://garage.netty.io/teamcity/viewLog.html?buildId=3625&buildTypeId=pulls_netty&guest=1) is now running


wait, are you renaming E2E.exe to corehost.exe? can you call E2E.exe directly?


Минус один `aib.__name__` \o/


Don't leave code in comments


Why are you copying this to `snapshots`? Looks like that variable is never used


Awesome! Would be great see a PR.


Yes that's right. Corehost has two modes, CoreConsole like and CoreRun like.

If the name is anything other than corehost.exe it uses coreconsole mode, which is not want we want.

The problem with calling it directly before rename is that it will execute the entry point in E2e.dll


Yeah, the signed/unsigned warnings are bad... we have too many useless warning on compiles.  Over commented code may be a theoretical possibility, but I think we are batting 100% for new people viewing this code for the first time and being surprised and encountering difficulty due to the lack of comments (Me when I arrived, and Brett recently).

Outside of removing warnings though, I'd probably vote against a large refactor here, this all might change quite a bit with the next model, and we have a lot of other important things to do that will have a much larger and direct benefit.  Your time is too valuable!


I don't quite understand what is this rename for. Is this behaving differently when you rename it?


observer 建议改成项目名


good work till.....maybe you need swap.


`deep_copy` not needed


Yes, details on other comment.


this patch have been merged as d1b5f56d14821b4af41de0ef6bc1b9abbaa01e4f.


name 建议以「项目名 + location.path + key」来命名，避免多个页面下与业务冲突。


hey


What is this variable for? I see you add elements there, but then you never query for its value.


please modify and send other pull request.
one thing important is make type converion as little as possible. better change it from it's definition.


@nazarhussain Awesome! Now you are our rock star on promises :) Don't break any promises :)

Feedback on this is same as for RSVP. Rest is Mashallah Awesome!


How would you write these 4 lines shorter?


I would prefer just `table` or `snapshots_table`. This is the only method with `draw_` on the name, but it's actually no different from `table_footer`, `config_select` and other methods than return a widget (but don't draw it).


Approved.


Approved


建议把 for 循环内的操作定义为一个以 DOM 元素为参数的函数，严格模式下不能这么 var


var 丢到循环外


I would like to see three separate commits. One for cleaning up the tests, one for cleaning up the code and a third one for implementing the multi-delete


Put code in separate files instead of put it to commetns


var 丢到循环外。。


Why not in an other file?


lol simply solution. Thank you for your update :smiley:


Testing


hey josh ,

no needed for a coin swap .. this is a Hardfork / mandatory update it works with the old blockchain.
the ppl just have to update the wallet

From: joshafest
Sent: Thursday, November 26, 2015 7:57 AM
To: Tillkoeln/Kolschcoin
Cc: Tillkoeln
Subject: Re: [Kolschcoin] Mandatory Update Version 1.7 (db03106)

good work till.....maybe you need swap.

—
Reply to this email directly or view it on GitHub.


Would be nice if we could find a way not to use a temporary folder, as it could be time consuming, producing extra errors or the C: drive could run out of space, especially on SSDs :P

But it can always be improved later offcourse. For me it looks OK.

Maybe we could install this extension so all formatting will always be the same:
https://visualstudiogallery.msdn.microsoft.com/3ea1c920-69c4-441f-9979-ccc2752dac56

No more "if(", but "if (". Or use CTRL + K, D more.


Instead of put it to every case you can do it like this:
```python
while a < 100:
    if '3' in str(a) and '5' in str(a) or a % 15 == 0:
        print('fizzbuzz')
    elif '3' in str(a) or a % 3 == 0:
        print ('fizz')
    elif '5' in str(a) or a % 5 == 0:
        print ('buzz')
    else:
        print(a)
    a += 1
```


What's the reason why you have deleted `android:configChanges="orientation|screenSize"`? Is this causing bugs?


Does this work? Shouldn't it be `DummyClass`?


bỏ ()


Yeah, since its just a file I dont need "-r"


Just for colors on the stdout


For in-place editing it creates a .bak file
Its an issue between Mac based sed (BSD) vs GND sed on linux


Dear Kabbi,

Please replace kabbi/node-webgl by * or >=5.0.0 and then all works correctly now that node-webgl and node-glfw are updated to latest node4/nan2 and latest third-party libraries.

Thanks,

--mike


I agree, could you submit a PR?


Good one. In our agent directory we dont need to, but the plist in /Libray/LaunchDaemons should be owned by root.


Dear Kabbi,

Please replace kabbi/node-webgl in utils/build/node.three.js/package.json by * or >=5.0.0 and then all works correctly now that node-webgl and node-glfw are updated to latest node4/nan2 and latest third-party libraries.

Thanks,

--mike


i was just gussing..... i thought that pow limit exceed ...so; if one want to change past ...he need a new blockchain.


Amazingly AWESOME job! Please commit the python codes for review! :)


Shouldn't this be "charger_consumption"?


convention


I don't think that's quite how it works :)


You are using the string in `it` to describe the context, not the behavior.
What about?
```ruby
it "returns false if no values has changed" do
  expect(subject.snapshot_modified({:a => 1, :c => 2}, {:a => 1})).to eq false
end

it "returns true if some value has changed" do
   expect(subject.snapshot_modified({:a => 1, :c => 2}, {:a => 4})).to eq true
end
```
Note the usage of `eq true` and `eq false`. They are preferred over the less deterministic options you have used.


I think you wanted to write: `print ("kacsa \\ alma")`


do you wnat me to do anything in this case?


my node has allright 14 connections and yobit has updatet to the latest source too .
just waiting for cryptopia

From: joshafest
Sent: Thursday, November 26, 2015 8:12 AM
To: Tillkoeln/Kolschcoin
Cc: Tillkoeln
Subject: Re: [Kolschcoin] Mandatory Update Version 1.7 (db03106)

i was just gussing..... i thought that pow limit exceed ...so; if one want to change past ...he need a new blockchain.

—
Reply to this email directly or view it on GitHub.


Nice job! :)


It's fixed now


also change application structure to a tab bar based app


@matthewberryman The verified tweets process is now ready for operational testing. We'll need to coordinate on this so I can send a confirmed report, and test verification  whilst you watch the logs to check everything runs OK on prod environment. Let me know if you're happy with this plan.


nice! :)


Хм. Я тут по-быстрому просмотрел, запрос с рандомными числами есть только на синче.


Ok, after reading your test, it looks intentional for this method to not be exactly `==`.


`if not ('3' in n):` is cleaner :)


Скрипт делает запросы с числами только там, где нужно. Т.е. фича не захардкожена на работу с конкретными бордами, а включается только при подобной херне.


do you have some kind of document the shows the design at a more abstract level?


@talltom Sounds good, happy to run 1600 WIB / 0900 UTCish today if that's good with you; will DM you when I'm ready.


Да я не про скрипт. В тиниборде есть встроенный апдейтер. Я сразу подумал, что это его особенность. Ан нет, на синче используется старая версия тиниборда, просто сильно модифицирования. Т.е., это чисто синчевский костыль.


Great! =) Thanks for fixing this!


Mmmm, I liked more having `Yast::Snapper`. Using `Yast::SnapperClass.new` looks a bit like exposing implementation details for me.

And to be honest, I don't see the usage of `subject` specially needed here (yes, I know it's considered nicer by RSpec experts, but it doesn't help legibility here).


so; you made pos/pow hybrid ...
This will increase change of collision as have 2 proofs ...pow and pos ..
Suppose block time is 30sec. and in 30 a pos block found , and at that time pow also found, but network can have only one block so one should be rejected ..every 30 sec. This may cause a lot of orphane blocks.
And most generally pow block get rejected as pos have large community to verify it.

lol...


Интересно, а что же тогда с mlpg.co


なんで？


Use separate files rather put code in comments


go for it :-)


The same comment below for `subject` and using directly `WhateverClass.new` applies here.


Хрен их знает. :confused:

Главное, что кукла теперь работает.


block time is 58 seconds, and pos has just 2% per year... there will be never a point where every seconds a pos block is generated

maybe max. 60 per day .,. maximum

From: joshafest
Sent: Thursday, November 26, 2015 8:21 AM
To: Tillkoeln/Kolschcoin
Cc: Tillkoeln
Subject: Re: [Kolschcoin] Mandatory Update Version 1.7 (db03106)

so; you made pos/pow hybrid ...
This will increase change of collision as have 2 proofs ...pow and pos ..
Suppose block time is 30sec. and in 30 a pos block found , and at that time pow also found, but network can have only one block so one should be rejected ..every 30 sec. This may cause a lot of orphane blocks.
And most generally pow block get rejected as pos have large community to verify it.

lol...

—
Reply to this email directly or view it on GitHub.


На синче вообще забавная ошибка вылетает при попытке удалить пост. И при этом он удаляется.


Не только на синче. Везде на тинибордах почти


I try to use this "cors_xml" module modification and get the following error:

```
TASK: [s3_bucket ] ************************************************************
failed: [localhost] => {"failed": true, "parsed": false}
Traceback (most recent call last):
  File "/root/.ansible/tmp/ansible-tmp-1448521647.51-136510376834450/s3_bucket", line 2261, in <module>
    main()
  File "/root/.ansible/tmp/ansible-tmp-1448521647.51-136510376834450/s3_bucket", line 442, in main
    create_bucket(connection, module)
  File "/root/.ansible/tmp/ansible-tmp-1448521647.51-136510376834450/s3_bucket", line 266, in create_bucket
    if cors_xml is not None:
NameError: global name 'cors_xml' is not defined
```

How to fix:
```
@@ -161,6 +161,7 @@ def create_bucket(connection, module):
     requester_pays = module.params.get("requester_pays")
     tags = module.params.get("tags")
     versioning = module.params.get("versioning")
+    cors_xml = module.params.get("cors_xml")
     changed = False

     try:
```


Может её в детектор тогда добавить?


Надо просмотреть список тиниборд-досок и попробовать, что где. Может содержание ошибок отличается.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.587.46f7d8c2c1b2c09f10f6581f2b9fc663f606fd0d](http://build.palaso.org/viewLog.html?buildId=66617&buildTypeId=bt322) outcome was **UNKNOWN**
Summary: Canceled (Tests passed: 1922, ignored: 57) Build time: 00:13:21


abcd


And the following error on second-pass module execution (after bucket creation):

```
TASK: [s3_bucket ] ************************************************************
failed: [localhost] => {"failed": true, "parsed": false}
Traceback (most recent call last):
  File "/root/.ansible/tmp/ansible-tmp-1448522210.17-140786683072748/s3_bucket", line 2262, in <module>
    main()
  File "/root/.ansible/tmp/ansible-tmp-1448522210.17-140786683072748/s3_bucket", line 443, in main
    create_bucket(connection, module)
  File "/root/.ansible/tmp/ansible-tmp-1448522210.17-140786683072748/s3_bucket", line 274, in create_bucket
    h = handler.XmlHandler(cors_config, bucket)
NameError: global name 'handler' is not defined

FATAL: all hosts have already failed -- aborting
```

How to fix:

```
@@ -127,6 +127,7 @@ try:
     from boto.s3.tagging import Tags, TagSet
     from boto.exception import BotoServerError, S3CreateError, S3ResponseError
     from boto.s3.cors import CORSConfiguration
+    from boto.handler import XmlHandler
     HAS_BOTO = True
 except ImportError:
     HAS_BOTO = False
@@ -269,7 +271,7 @@ def create_bucket(connection, module):
         else:
             # Convert cors_xml to a Boto CorsConfiguration object for comparison
             cors_config = CORSConfiguration()
-            h = handler.XmlHandler(cors_config, bucket)
+            h = XmlHandler(cors_config, bucket)
             xml.sax.parseString(cors_xml, h)
             if cors_config.to_xml() != current_cors_config.to_xml():
                 cors_rule_change = True  # Update
```


Je confirme Travis est notre intégration continue depuis le début (important pour un projet libre et open source).


I don't think there is much of a point of adding a .bls to the end since the keys are not the filenames anyway.


We do not need two methods, both classes are extending abstract class Migration, so we need just one method which will tell addMigration method that it accepts any class which extends Migration.
```
public <T extends Migration> void addMigration(final T migration) {
```


There comes a documentation like this https://github.com/AlwinEsch/kodi/blob/internet-addon-handler-2/addons/library.kodi.guilib/guilib-v2/Readme.md (was on begin and this not correct) on the header folders to show how it is handled.

After the documentation is finished I create a request.


But I think it's perfectly okay for an admin not to set this property. So
there's no need to pollute the log with a warning in that case.

On 26 November 2015 at 13:56, Patrick Huang <notifications@github.com>
wrote:

> When the value is null, it will also throw NumberFormatException and the
> warning log will tell us that (value is null)
>
> On Thu, Nov 26, 2015 at 12:58 PM, Sean Flanigan <notifications@github.com>
> wrote:
>
> > It would be good to avoid a warning for the common (non-exceptional) case
> > where the system property hasn't been set.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/zanata/zanata-server/commit/45be747238b7b9fcf4300ce5ea7206b4cac6375f#commitcomment-14631385
> >
> > .
> >
>
>
>
> --
> Patrick Huang
> Senior Software Engineer
> Engineering - Internationalisation
> Red Hat, Asia-Pacific Pty Ltd
> Level 1, 193 North Quay
> Brisbane 4000
> Office: +61 7 3514 8278
> Fax: +61 7 3514 8199
> IRC: pahuang
> github: github.com/huangp
> Website: www.redhat.com
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zanata/zanata-server/commit/45be747238b7b9fcf4300ce5ea7206b4cac6375f#commitcomment-14631808>
> .
>

--
Sean Flanigan

Principal Software Engineer
Globalisation Tools Engineering
Red Hat


shoot, I did something very similar on my own fork


sad


`a => { return b; }` → `a => b`


yes it is needed , the comment is wrong


mvn test shows errors (not failures) for all units, so I kind of gave up on that a while ago. Will go investigate why it's unhappy this time.

-----Oorspronkelijk bericht-----
Van: Bert Frees [mailto:notifications@github.com]
Verzonden: dinsdag 24 november 2015 20:53
Aan: snaekobbi/pipeline-mod-dedicon <pipeline-mod-dedicon@noreply.github.com>
CC: Davy Kager <DavyKager@dedicon.nl>
Onderwerp: [pipeline-mod-dedicon] Fix test (a55659f)

Fix test

Note to @dkager: always run mvn test before committing to master

---
Reply to this email directly or view it on GitHub:
https://github.com/snaekobbi/pipeline-mod-dedicon/commit/a55659fd17e9fac1a64160e8afd6457774a13400
DISCLAIMER:
De informatie verzonden met dit e-mail bericht is uitsluitend bestemd voor de geadresseerde. Indien u niet de beoogde geadresseerde bent, verzoeken wij u vriendelijk dit aan de afzender te melden (of via: info@dedicon.nl<mailto:info@dedicon.nl>) en het origineel en eventuele kopieën te verwijderen.

The information sent in this e-mail is solely intended for the individual or company to whom it is addressed. If you received this message in error, please notify the sender immediately (or mail to info@dedicon.nl<mailto:info@dedicon.nl>) and delete the original message and possible copies.


@evocateur do you have similar problems with react-router? They are handling the dependency the same way. Also mind that this current commit isn´t published to npmjs.org yet.
I think it was the right approach as it loosens the tight coupling between redux-router and the `history` module. You could have, for what I understand, your own `history`-ish module and use it with the router.


В общем, если я правильно понял, тиниборд (или некоторые его версии) коряво работает с кешированием, а синчевский админ просек эту фишку, и придумал костыль с рандомными числами, чтобы его апдейтер работал корректно.
Ну, и теперь эта фишка присутствует у нас.


so far I have done bootstrap for the layout, I added my own js coding for the modual that I created. I was able to have the three videos at the bottom of the screen have three different videos pop up as using the click function. I created the css and the html and customized it. Looking to add scrolling to the page and possibly an additional page for the three circled descriptions in the center of the page so when clicked will go to separate page.


I don't understand the registration date change. Now you need to pass in now() or the date will be incorrect.


where is the `case x if x.isInstanceOf[BigDecimal] => x.asInstanceOf[BigDecimal].bigDecimal` ? :)


Возможно не тинибоард сам по себе а его `vichan`овская модификация.


What do you think about using a @dataProvider here and iterate over all possible dtd's ? I think this will tell us wether the lib is still able to create still all valid formats. By correctly setting these up wie can also check for BC. I don't know if 01.002 is compatible with 01.003 in sense og BC. These are the only concerns I have about this change at all. Thank you.


Are you using tornado?

On other boards you can do
set beeper_off_flags = 4

That disables beeps on failsafe.
Op 26 nov. 2015 07:52 schreef "David Trounstine" <notifications@github.com>:

> setting to 9 didn't work for me. If I plug in with USB it immediately
> starts beeping, turning failsafe and vbatt off did not stop it either.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/betaflight/commit/3d9c17712670ef3d5b44b9e07b5880702c8c1764#commitcomment-14632931>
> .
>


Well, we are checking for the mouse focus, so the window has to be open anyway.


That comments says "Synchronous FIFO" then instanciate a fifo_async ? :)


为何已经有offer还在刷题。。。。。 :sob:


Good point, will add this immediately


Да уж, с такими темпами скоро наша кукла научится стирать, пылесосить, и готовить чай. :D


:heart: :100: @PeterDaveHello


@Ranlvor Hab die 4 Keys von Matthias gerade eingetragen. Überhaupt, ich mach die Keys jetzt immer rein, wenn ich kurz Zeit hab. Bevor du also auf Eintragewünsche reagierst, schau grad oben auf "last commit" ob das nicht schon erledigt ist. Ich mach' dir dann in Folge jetzt keine extra comments mehr wg der Keys.
Grüße tackin


and just for your info .. any kind of Hybrid coin has the same timings for pow and pos ...

expect my newest project . it has different timings for pow and pos

PoW 180 seconds
PoS 15 seconds
with 100% pos .

i was testing it since 48 hours on my network and it has not a single orphaned block ..

so please . what are you talking about ?

From: joshafest
Sent: Thursday, November 26, 2015 8:21 AM
To: Tillkoeln/Kolschcoin
Cc: Tillkoeln
Subject: Re: [Kolschcoin] Mandatory Update Version 1.7 (db03106)

so; you made pos/pow hybrid ...
This will increase change of collision as have 2 proofs ...pow and pos ..
Suppose block time is 30sec. and in 30 a pos block found , and at that time pow also found, but network can have only one block so one should be rejected ..every 30 sec. This may cause a lot of orphane blocks.
And most generally pow block get rejected as pos have large community to verify it.

lol...

—
Reply to this email directly or view it on GitHub.


This should be in the UserManager class, the *Object classes are just for data storage and relevant accessors


TeamCity pull requests :: netty [Build 757](https://garage.netty.io/teamcity/viewLog.html?buildId=3625&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 5713, ignored: 21; resource leak detected Build time: 00:41:47


When I run "phpunit tests" from tests/php I actually need only two levels of dots.  I will see if I can fix that.


＝ ＝别闹了。。。谁说我有offer了。。。


# -*- coding: utf-8 -*-


コミットちゃうやん


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6903](https://teamcity.mesosphere.io/viewLog.html?buildId=81520&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:05:02


空格统一


config.jsonで設定可能にした方がよいのでは


TeamCity pull requests :: netty [Build 758](https://garage.netty.io/teamcity/viewLog.html?buildId=3626&buildTypeId=pulls_netty&guest=1) is now running


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.145.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=66616&buildTypeId=bt2) outcome was **FAILURE**
Summary: Execution timeout; tests passed: 805, ignored: 45 Build time: 00:55:49


better formatting required


不过这样就变成接近与轮询，会占满1个CPU ...


TeamCity pull requests :: netty [Build 758](https://garage.netty.io/teamcity/viewLog.html?buildId=3626&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:39


formatting screwed up


Ну, а в принципе, пока зайдешь в тред и наберешь пост, апдейтер уже успеет аякснуть страницу и проверить заголовки.
Ну, а те, у кого апдейтер отключен, звиняйте.
Хотел аще подумать про постинг с доски, но вспомнил, что у нас он отключен)


give attention to code sanity.


formatting again.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6904](https://teamcity.mesosphere.io/viewLog.html?buildId=81521&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:52


这里和上面的为什么要 || null ？


I think having a pure Backbone structure is something that will come in time, but for now the ability to do this is completely unneeded. Initial BlockModel configuration comes from drupalSettings and new/edited BlockModel configuration comes from Forms. There isn't a huge use case as of yet for syncing BlockModels to/from the server.


aren't you saving locations in DB?

Try using Parse.com for easy backend DB


Да, наверное, ни у кого нет такой мощной адаптивной аякс-логики, как у нас. Под все подстраиваемся.


This is hard-coded. Not a functional location logger.


Не, на постинг фича (да и сам баг) не влияет совершенно. В следующем коммите я вообще убрал эти костыли в `ajaxLoad`, который занимается исключительно загрузкой страниц.


Sure @steveyken
I will add those changes.. Thanks :)


クエリで指定可能にします


Did they change the response format?

I was going off here: http://docs.onfleet.com/docs/errors


setTimeout 应该加在这行代码上，而不是把所有东西包起来。。


Great stuff!


Use process_apicall_response() in assign_user() and you won't need this error handling.


Давно они мне в aib глаза мозолили. Это хорошо.


不用这么快吧？我觉得 500 到 1000 差不多。。


Use """ . """ comments, after the function, to allow auto documentation of functions.


这个 name 的生成规则可以写成一个函数了，读取和设置时都用


Use process_apicall_response() here and specify expected the expected return structure.


update


:facepunch:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6905](https://teamcity.mesosphere.io/viewLog.html?buildId=81522&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:37


Sure I know it.
but this is so far the only place that can resolve the hanging issue.


also send a PR to instantsearch.js here #691 https://github.com/algolia/instantsearch.js/pull/691


i can send you my latest source for my test coin with different timings on pow and pos
if you are interested

From: joshafest
Sent: Thursday, November 26, 2015 8:21 AM
To: Tillkoeln/Kolschcoin
Cc: Tillkoeln
Subject: Re: [Kolschcoin] Mandatory Update Version 1.7 (db03106)

so; you made pos/pow hybrid ...
This will increase change of collision as have 2 proofs ...pow and pos ..
Suppose block time is 30sec. and in 30 a pos block found , and at that time pow also found, but network can have only one block so one should be rejected ..every 30 sec. This may cause a lot of orphane blocks.
And most generally pow block get rejected as pos have large community to verify it.

lol...

—
Reply to this email directly or view it on GitHub.


when socket is closed and trying to read from it, the returned result is not an error but an 0 sized buffer.


hi @rodsol  you were earlier contradicted by @AmeBel  who says its a temporary thing until something else changes ..!?


We're under JRuby/Truffle, this line is probably wrong


没有呀，只是存放一些简单实体类的，方便UI那方面做


This doesn't appear to be settable anywhere.


Is there any use case for passing a non-zero array to it? If not, I think we should rather zero the array inside pinv(), as this is an easy mistake to make. I don't see any comments in pinv() mentioning that the caller is responsible for clearing the array either.


I don't think you needed to escape the '\' if you are using %r.


Indeed you need.


great work till it will not have any  orphan block (your new project) as you already told have different timings for pos &pow .
So, no problem of time clash=no rejection (no orphan block)
nice till you already solved problem.


I think fixing the table dimensions isn't the correct way to go about things.
At any rate the new build upload page looks either squished with the long form table or way too spread out with just formtable.


特に意味はないです


Unnecessary spacing detected.


Annotation keywords should be all upper case, followed by a colon and a space, then a note describing the problem.


this problem occurs in coins having same timing of pos pow


8d0803f861045e17ede39fd3c9ffb813e9fa5aee comment


assign_user() is only in \local_o365\rest\azuread, but $this->construct_user_api can return \local_o365\rest\unified. It's fine if the feature is only in the legacy API but there should be a check here to handle when $apiclient is a unified API class.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6906](https://teamcity.mesosphere.io/viewLog.html?buildId=81523&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:57


get_app_service() is only in \local_o365\rest\azuread, but $this->construct_user_api can return \local_o365\rest\unified. It's fine if the feature is only in the legacy API but there should be a check here to handle when $apiclient is a unified API class.


Update README.md (25th Nov '15)
+48 - 25th November


No need to leave this commented-out line here AFAICS


Это были ловушки в делформе? Скрипт принимал одну из них за кнопку удаления?


I think you can move this up above the URN stuff, and then replace `for urn in contact.urns.order_by('-priority'):` with `for urn in contact.get_urns():` to avoid another db hit.


Ahem :-)


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.588.46f7d8c2c1b2c09f10f6581f2b9fc663f606fd0d](http://build.palaso.org/viewLog.html?buildId=66618&buildTypeId=bt322) outcome was **FAILURE**
Summary: Tests passed: 2160, ignored: 78; exit code 1 Build time: 00:31:31


@justin808 fixed in PR 124


This doesn't appear to be used anywhere.


@szyablitsky that looks cleaner! :+1:


> .youtube.embed

Этот нативный ютуб-эмбеддер характерен для всех нульчан-клонов, или только для 0chan.cc?


Woah woah woah woah.  Let's talk first thing tomorrow morning.  We need to go back to basics.


s/exsample/example/


ooops! I was testing! fixing it


Glad you got it to work, did you test some other sizes (not breaking things that worked before) ?


Кстати, я вчера узнал, что некрооперане поддерживает `initial`. По крайней мере, для `display`.


what cleans this up, to prevent this instance from leaking?


It was written that geopoint is already given. Code quality might not be
very good and also I would have used database if I have been told so even I
asked explanation then also nothing was specified. I was not aware that I
have to include database. Also I have tried to implement basic
functionality in the application.

Sir regarding proper spacing etc I want to tell you that I am still in
learning phase and not have very much  experience of professional coding
these are things which I want to learn from you guys.

Regards,
Regards,
On Nov 26, 2015 1:11 PM, "praha1991" <notifications@github.com> wrote:

> This is hard-coded. Not a functional location logger.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vjs3/LocationLogger/commit/afcee25395d0b4b6bcda35b360617313fb3f037c#commitcomment-14633602>
> .
>


Lets change the method.


No, not direct. With my planned changes where the add-on have a own format is to reduce API level changes.

The probability for changes on headers in kodi is higher as on add-on's itself. Want to have the binary add-on's still usable with any changes on Kodi itself.


Yeah, will fix.


59fd4d42b8fa4a352b24de07acc4010d7050729c comment


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6907](https://teamcity.mesosphere.io/viewLog.html?buildId=81528&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:26


Последнее. Проблема в том, что кроме 0chan.cc я других сайтов с этим движком не знаю.


Yes, I've seen the implementation. But, as I understand, `isAllDay()` changes nothing. I just creates a variable, makes some comparisons (with use of `if var` and temporary variables) and returns value of initially created `var result`. So where is the change of this struct that made you marking `isAllDay()` as mutating?


Мда, мне эти сообщения уже вконец глаза замозолили.
Странно, чому лисоразрабы не обращают внимания на подобные глюки песочницы.


I worked only with the previous test-data, it worked. I will have many
other occasions to test the tool with other datasets in the incoming days
;-)

Chris

Christophe Antoniewski

ARTbio <http://artbio.fr/> - Tel +33 1 44 2*7 70 05*
Drosophila Genetics & Epigenetics <http://drosophile.org/> - Tel +33 1 44 2
*7 34 39*Mobile +33 6 68 60 51 50
https://twitter.com/ARTbio_IBPS
https://twitter.com/drosofff

2015-11-26 9:00 GMT+01:00 Marius van den Beek <notifications@github.com>:

> Glad you got it to work, did you test some other sizes (not breaking
> things that worked before) ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/drosofff/tools-artbio/commit/450d1b3d954cc7d96e53652d468811546951f995#commitcomment-14633806>
> .
>


What's the reason of this move ?


3847456394bca51005b278e743d078e72c830a82 commit


TeamCity pull requests :: netty [Build 759](https://garage.netty.io/teamcity/viewLog.html?buildId=3627&buildTypeId=pulls_netty&guest=1) is now running


+1 comment


@eviltrout and I did a moment of silence in honnor of the fallen ninjas.


:clap:


Потому что эта песочника мало где используется. Да и было хуже, теперь только типизированные массивы, да и символы (Symbols) этой песочницей не поддерживаются, а остальное работает нормально.


I think the squawk should be definitely separate all the time from callsign.


You forgot to modify another section of the pom using the duplicate finder plugin (in the legacy profile section). This is causing the failures for http://ci.xwiki.org/job/xwiki-enterprise/


can't we rather check if the map field has nullable=false, rather than doing a string compare?


ditto


Pushed a few more commits. [This](https://github.com/wincent/wincent/blob/master/roles/dotfiles/files/.hammerspoon/init.lua) is what the new config looks like on the master branch right now, and it should be roughly equivalent to what I had before. For comparison, see [the old `.slate.js` one](https://github.com/wincent/wincent/blob/deeebf238cd0a8a2d7626e010f8fd472c179ed88/roles/dotfiles/files/.slate.js) as it was before I deleted it.


http://claire.ws/sg/
http://www.2chan.su/b/


What is .bind for??


No problem.

Do the following.

- User should be able to save GeoPoints and log them into DB(of your
choice).
- SavedLocationsViewer: User should be able to see image snippets of that
location just like WhatsApp.

On Thu, Nov 26, 2015 at 1:30 PM, Vishwajeet Srivastava <
notifications@github.com> wrote:

> It was written that geopoint is already given. Code quality might not be
> very good and also I would have used database if I have been told so even I
> asked explanation then also nothing was specified. I was not aware that I
> have to include database. Also I have tried to implement basic
> functionality in the application.
>
> Sir regarding proper spacing etc I want to tell you that I am still in
> learning phase and not have very much experience of professional coding
> these are things which I want to learn from you guys.
>
> Regards,
> Regards,
> On Nov 26, 2015 1:11 PM, "praha1991" <notifications@github.com> wrote:
>
> > This is hard-coded. Not a functional location logger.
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/vjs3/LocationLogger/commit/afcee25395d0b4b6bcda35b360617313fb3f037c#commitcomment-14633602
> >
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vjs3/LocationLogger/commit/afcee25395d0b4b6bcda35b360617313fb3f037c#commitcomment-14633812>
> .
>


string replacing a star is fine, but when looking for a star I would prefer checking nullable.


Like this :)


asdas


Понятия не имею. Этому коду уже три года: b390ab2983329d23af71c34f0cc69e95b18bcb30


Squawk is not currently in the packet. We can include it if needed. Do we
need it?

On Thu, Nov 26, 2015 at 12:06 AM, Lorenz Meier <notifications@github.com>
wrote:

> I think the squawk should be definitely separate all the time from
> callsign.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mavlink/mavlink/commit/794b5956ab20e1694f891b5591c65475f378d1ec#commitcomment-14633912>
> .
>


Weird, I just got a notification for this


Yes, absolutely. It tells you if you're dealing with a commercial aircraft or military. Different rules apply to these.


Do not use `arguments` builtin. Name param of this method `opt_newValue` and check for its existence with `isDefined`. agruments builting is dangerous and should be avoided whenever possible.


I assume you have to add "you may" to get a correct rule tooltip text.


this failure case was fixed for master (libgit2) in https://github.com/JuliaLang/julia/commit/e4ac8bd84f55ed1125288f70dbeada2152660b2d


How about:
```
if (angular.isDefined(opt_newValue)) { // or if(opt_newValue !== undefined)
  this.value_ = opt_newValue;
}
return this.value_;
```


Do not use square brackets in param name.


Хех. Может он и не нужен уже.


Видимо характерен для всех:
http://claire.ws/sg/res/14421.html
http://www.2chan.su/b/res/396.html


Are you sure you need that, if you set the "attachTo:" value?


Maybe split every import into a separate line?


What problem eslint has btw?


@vilchik-elena no, this -1 is indeed when calling `commonAddIssue` because of its (implicit) contract.


Ok, so that's 4 sets of octal values, 24 bits total. Best to go with a
char[4]?

On Thu, Nov 26, 2015 at 12:11 AM, Lorenz Meier <notifications@github.com>
wrote:

> Yes, absolutely. It tells you if you're dealing with a commercial aircraft
> or military. Different rules apply to these.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mavlink/mavlink/commit/794b5956ab20e1694f891b5591c65475f378d1ec#commitcomment-14633993>
> .
>


This breaks on OS-X builds on Travis as they have Maven 3.2.3 installed

see: travis-ci/travis-ci#5170


Couldn't get it to work :/

- Blake
On Nov 25, 2015 10:56 PM, "Christoph Hermann" <notifications@github.com>
wrote:

> Awesome! Would be great see a PR.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/blake-regalia/babel-plugin-array-includes/commit/1776aa8dd376c542ba99544539f6c9b3261461be#commitcomment-14632969>
> .
>


if I wrote a function for while loop?

2015-11-26 8:01 GMT+01:00 Tamas Kokeny <notifications@github.com>:

> How would you write these 4 lines shorter?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/greenfox-academy/bejczib/commit/a450e0d4a36d4d60ee306dd682ca0956d78ca73b#commitcomment-14633018>
> .
>


О, зашибись тогда.


@Anrishitko


Лолнет, нужен. Это просто поле копирующее поле пароля из `.userdelete`, но расположенное внутри формы. Учитывая, что мы переносим `.userdelete` внуть формы, то скрытый элемент дублирует инпут для ввода пароля.


@vilchik-elena Good question. So far, I reproduced the syntax which is used in the Java plugin. We could add something for the columns of secondary locations, but I wonder if it will still be readable.


Только надо ещё добавить поддержку встроенного `Vimeo`.


That would be an uint8[3] in the minimal case or an uint32_t for something that is easier to parse.


Or is it 4 distinct sets?


eslint does not allow breaking the import line and does not allow spaces between bracket and imported variable name.


Можно заменить на `$del($q('input[type="hidden"]', el));`. Других скрытых полей там вроде нет.


This means that parameter is optional


Please see commit 45bf5a3d72.
I already changed the dots to underscores.

$action is defined in line 466 of this file.

Am 26. November 2015 6:35:02 vorm. schrieb Adrian Voicu
<notifications@github.com>:

> Shouldn't it be:
> preg_replace('/rename_|remove_|modify_|delete_|add_|_table|_tbl/gi', '',
> $action);?
> ...And... where is $action defined?...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/greensn0w/codeigniter-matches-cli/commit/bc80cd49093fbb6a4b05935e57fcd8816391a02f#commitcomment-14632441


Hint: Python is not Java, so you can (and should) put multiple related classes into the same file. ;)


JRuby+Truffle supports some of the Rubinius APIs therefore this works, but the comment is definitely outdated and wrong, thanks I fix it.


I'm going till end with this test. After that I'll go with one more try - a continuous version of rohanryan's patch. After that I'll be back with this testing only one day in the future when we'll have cheap 15+ cores testing available. I still have a feeling that this formula
http://tests.stockfishchess.org/tests/view/5654c3570ebc5902cdc08490
could be good on 15+ threads, but I don't want to test that if it is not cheap/available.

I'll explain on the forum how I get the formula, and if somebody else wants to try - go ahead.


Good to know. In angular documentation however example for getter/setter binding uses it and it is called as best practice example.

https://docs.angularjs.org/api/ng/directive/ngModel


It's 4 sets of octal data. We can squeeze it into char[3] and then break them back up. That's the question. Lets get @jwuavionix to chime in on this.


You know what...? I think that the best solution to solve this problem is to create a directive for uniqueness validation. Every other solution require fighting with angular's quirks and complex interactions.

Imagine that you create directive named `validate-unique`. And use it on the key input like: `<input ng-model="label.key" validate-unique="ctrl.getAllLabelKeys">`. No more $index nor ng-change here.

See how to implement such validation directive here: https://docs.angularjs.org/guide/directive . This should be actually very easy and quick to implement.


Тут можно исправить на `max-width: 100% !important;`


tak


nom


kl


nhbj


I've tried it all with no luck. It's like lint check can't see that there is check if this variable is defined and second example with directly comparing to undefined triggers another check and says that we should use angular.isDefined method.


@larsbrinkhoff : What differentiates `.ms` files from other GAS files? When/where are they used?


Anytime!


How is this supposed to help with performance? Prevoius code just shared the bufferptr and new code copies (except data), which is both slower and adds work to already overloaded memory allocator.

```c++
unsigned long long gettickcount(void) {
  struct timespec ts;
  if (clock_gettime(CLOCK_MONOTONIC, &ts) != 0) {
    return 0;
  }
  return (ts.tv_nsec) + ts.tv_sec * 1000000000;
}

void test_default() {

 bufferlist bl;
 char data[49152];
 bufferptr bp(&data[0], 128);

 unsigned long long ti = gettickcount();
 for (int i=0; i<1000000; i++) {
   bl.clear();
   for (int j=0; j<100; j++) {
     bl.append(bp);
   }
 }

 printf("old ti: %.2f\n", (gettickcount()-ti)/1000000000.0);

}

void test_new() {

 bufferlist bl;
 char data[49152];
 bufferptr bp(&data[0], 128);

 unsigned long long ti = gettickcount();
 for (int i=0; i<1000000; i++) {
   bl.clear();
   for (int j=0; j<100; j++) {
     bl.append(bp, 0, bp.length());
   }
 }

 printf("new ti: %.2f\n", (gettickcount()-ti)/1000000000.0);

}
```

The above code shows the following on Xeon E5-2420 v2 @ 2.20GHz:

```
old ti: 3.91
new ti: 5.92
```

In other words, your "optimization" slows down bufferlist encode by at least around 2us per call.


I guess it's needed, as I'm not sure that lzma_easy_encoder creates the bitwise identical output as lzma_stream_encoder_mt with threads set to 1.


try to use commit


These should be added in the pull request that is introducing espresso.


It would break deltarpms.


Python already has you covered: [`itertools.count`](https://docs.python.org/2/library/itertools.html#itertools.count)


new commit


@namreeb There's a file in my CMaNGOS build directory called 'genrev'. Is this the 'genrev_binary' you're talking about? When I use: gdb build/genrev and follow up with the command 'bt', I get the following output:

mangos@SNOWFALL:~$ gdb Build/genrev
GNU gdb (Ubuntu 7.7.1-0ubuntu5~14.04.2) 7.7.1
Copyright (C) 2014 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "i686-linux-gnu".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from Build/genrev...(no debugging symbols found)...done.
(gdb) bt
No stack.


This patch looks good to me, thank you. Actually only the fix at line 299 is needed to address the issue. If you clear all the other changes I'll accept the request and merge the patch into the "next" branch.


Okay, what about log level as second optional parameter, with no 2nd parameter defaulting to VERBOSITY_NORMAL?


Hello, adding the trap is a good idea, but oid { pacemakerNotification 1 } is already assigned to pacemakerNotificationNode.
I would suggest to redefine pacemakerNotification to pacemakerObjects (oid { pacemaker 1 }),
define pacemakerTraps (oid { pacemaker 2 }) to prepare base for more traps possible, and send  (currently the only one) trap with oid { pacemakerTraps 1 }. Could that be?


Lets make sure we're talking about the right thing: squawk vs squitter.

On Thu, Nov 26, 2015 at 12:20 AM, Lorenz Meier <notifications@github.com>
wrote:

> Or is it 4 distinct sets?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mavlink/mavlink/commit/794b5956ab20e1694f891b5591c65475f378d1ec#commitcomment-14634137>
> .
>


Ok, I see that `undefined` is a valid value for ngModel. Then use `arguments` builtin and document JSDoc that undefined value is OKay


We use internally but we need oshmem function to do oshmem specific stuff
```
int oshmem_proc_init(void)
{
    OBJ_CONSTRUCT(&oshmem_proc_lock, opal_mutex_t);

    assert(sizeof(ompi_proc_t) >= sizeof(oshmem_proc_t));

    return OSHMEM_SUCCESS;
}
```


я его на 13 строчку перенес


However, please verify that `undefined` value gets passed here when validation fail.


Thomas - the check in itself is problematic. It needs to be fixed. Secondly, the release process related check is are made through Jenkins account and not your personal account. So you are already not following the process you refer to. You do not need dev@ to tell you to do job  without mistakes.

-
Chetan

From: Thomas Weise <notifications@github.com<mailto:notifications@github.com>>
Reply-To: apache/incubator-apex-core <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wednesday, November 25, 2015 at 6:23 PM
To: apache/incubator-apex-core <incubator-apex-core@noreply.github.com<mailto:incubator-apex-core@noreply.github.com>>
Cc: Chetan Narsude <chetan@apache.org<mailto:chetan@apache.org>>
Subject: Re: [incubator-apex-core] Add since tags for release 3.2.0 (42927bc)

@since<https://github.com/since> tags have been automatically added to classes that don't have them as part of the release process for a long time. There was also never a pull request review for release management related changes. If you want to propose a different process, please take it it the dev@ list.

-
Reply to this email directly or view it on GitHub<https://github.com/apache/incubator-apex-core/commit/42927bc5c00d8c1a2f75f046434a2fc69594da2e#commitcomment-14631034>.


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.589.ccccab2eee2729126c51be22471bd3ceb6be6983](http://build.palaso.org/viewLog.html?buildId=66623&buildTypeId=bt322) outcome was **FAILURE**
Summary: Tests passed: 2161, ignored: 78; exit code 1 (new) Build time: 00:24:16


Hi, I am not expert to SNMP, so I did it as I know


TeamCity Chorus :: chorus-win32-master Continuous [Build 2.6.146.8515507208c1539220ebee854cf5e7e479e1de6d](http://build.palaso.org/viewLog.html?buildId=66620&buildTypeId=bt2) outcome was **FAILURE**
Summary: Execution timeout; tests passed: 803, ignored: 45 Build time: 00:56:21


This is also wrong!


Also fix `mono --version` output


For private vars it's probably most appropriate that I fork the public repo
and just mimic the private one with the bare minimum of the servers I need.
Also, then I just make sure to have aorth + sudo on those few servers
(linode01 and linode02?) and I can provision like that. Really, it would be
inappropriate for me to have all the servers + provisioning password...

On Thu, Nov 26, 2015 at 5:48 AM James Oguya <notifications@github.com>
wrote:

> I don't mind reviewing & merging your PRs, but for the private vars,
> you'll just have to push directly to the private repo.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ilri/rmg-ansible-public/commit/5d7c4e20c833b6d48120b6c66a74b72aecdbe282#commitcomment-14631746>
> .
>


If you start using `arguments` and make `undefined` a valid value of this. Then it'll work.

To make compiler aware of the check use `goog.isDef` or `goog.isDefAndNotNull`. This is a compiler builtin.


Hi, this commit is not yet available in main project dudapiotr/ZfTable
https://github.com/dudapiotr/ZfTable/commits/master
could you please merge it?


@rad3ks : We have spoken with @lukwol and we think that using `sort { $0.event.start.compare($1.event.start) == .OrderedAscending }` is better because the another (shorter) solution depends on Timepiece. Less dependencies == better. What do you think @rad3ks?


Actually it can stay with isDefined if it's ok. I think it is easier to read and understand.


You might want to explain a little bit, either in the commit message or as a comment here.


missed that one, thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6908](https://teamcity.mesosphere.io/viewLog.html?buildId=81532&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:20


TeamCity pull requests :: netty [Build 759](https://garage.netty.io/teamcity/viewLog.html?buildId=3627&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4799, ignored: 21 Build time: 00:35:51


@crazymaster Fixed. Thanks!


Change to
```red = (deg_temp - red) / scale * 255;```
And same on line `102`


@frankrousseau j'ai bien fait le changement ;) https://travis-ci.org/cozy/cozy-mobile/builds/93201766


@anrishitko


@bryk So this way it actually works and gulp check passes with no errors.
```javascript
   /**
   * @param {string} [newValue]
   * @return {string}
   * @export
   */
  value(newValue) {
    if (!goog.isDef(newValue) && goog.isDef(this.derivedValueGetter_)) {
      this.value_ = this.derivedValueGetter_(this.key);
    }

    return goog.isDef(newValue) ? (this.value_ = newValue) : this.value_;
  }
```

We should use good instead of angular checks. This is something we can write in guideliness i think.


Hi Carsten,

sure, that would be great! In the meantime, I have also found and fixed another issue that I haven't yet pushed to this repo. I'll push those changes here as well - if you could integrate them, we could drop our custom version of cuckoo-ra.

Thanks
Lars


ack, but shouldn't the MatlabIndentationBearTest editing be separated of this commit?


ack


Missing messages in the Is* asserts. Once all the tests are run and only several (but not too few) fail, only messages visible will be "Expected True but was False." – that is not sufficient and prolongs time to fix the product. Test names are usually not expressive enough, so it is best to start writing messages from very beginning.


блок для загрузки изображений представляет собой просто блок с картинками внутри. Там сверху одна кнопка inout type="file" + её лейбл с надписью выбрать файл. А дальше просто
```
<div class="photo">
  <figure class="photo-preview">
    <img src="" alt="" width="" height="" class="photo-preview__image">
    <a href="" class="photo-preview__delete">
  </figure>
  ....
 .....
</div>
```

И таких блоков м фото, столько, сколько картинко в макете


Yes this is specific to my usecase. If there is no way to pause/stop scan from outside, then either I have to abruptly kill the scanner thread or I need to override entire scanner class to get better control of running state.
There is no way to resume the scan, that's why I added stopScan. But if we see pause is more appealing than stop I will rename the method to pauseScan. Let me know your thoughts on this.


Remove the line


Should be changed ?


Single test case does not make sense.


The test tests the test generation function ;)


**[unitTests_js_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_js_branches/21018/testReport/) for this commit**


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6909](https://teamcity.mesosphere.io/viewLog.html?buildId=81536&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:08:38


Ok, I will do that.


Ok


等下个版本了。。。。


I will do that too.


I will free it in the constructor


Congratulations :)


After the change, line 277 should be useless. And self.release_component_info will do it again, should it be removed?


I had implemented that in case of possible implementations where other paths wouldn't be needed but I will change that too


Yes, I think the test should be changed to something like this: https://github.com/maidsafe/crust/blob/69c3f589374a1b771b9b98b9dba4c4ebe2ae09f6/src/utp_wrapper.rs#L34


What is your point?

Should I use the travel speed instead of the hard coded 150? Is that your point?


I thought the coding style was to put parenthesis around multiple tests but you are right about the alignment.


Should the same be done for the {{$namespaceXml = $xml->children($namespaceUri);}} too?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6910](https://teamcity.mesosphere.io/viewLog.html?buildId=81538&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:09:19


this could be wrote in this way:
`expose(:position_numbers_repo) do { PositionCountRepository.new }`


давай лучше __title


Везде, где у тебя headline замени на title


I will panic at startup if no period path and remove those checks.


Shouldn't this be `self.path = new_path`? There's already a check above which made sure `self.path` wasn't True-ish.


I suggest to have a list of workloads for each day. Can we use this also for the information we store as *annual plan row values* in the current implementation?


Like it, will fix it. Thanks! :smile:


Ok


I will do that to.
I will resend this in a separate PR


Please do not delete null checks.


When do we add terms at `simple_term` ? Does that mean we expect them to evaluate to something meaningful in type theory?

In that case, `Yield` should probably be up in `app_term`. But so should `Tag`.

Otherwise, why don't we move other entries of `app_term` down to `simple_term` ?

@andrejbauer, wdyt?


Oh dear God, something indented itself.


I kind of applied the current policy of "commit per directory" but I agree it's bad.


Do we need to make a judgement here to check if /var/log/messages exists? If not, the return code will always be non-zero


You don't need this file in repository.


TeamCity pull requests :: netty [Build 760](https://garage.netty.io/teamcity/viewLog.html?buildId=3628&buildTypeId=pulls_netty&guest=1) is now running


Same with above judgement


/ * Tlačítka Popis * /
$locale['html_000'] = 'tučně ";
$locale['html_001'] = 'kurzíva';
$locale['html_002'] = "zdůraznilo, ';
$locale['html_003'] = 'Přeškrtnuté';
$locale['html_004'] = 'citace';
$locale['html_005'] = 'vodorovná čára ";
$locale['html_006'] = 'Zarovnání doleva ";
$locale['html_007'] = 'zarovnání na střed ";
$locale['html_008'] = 'Zarovnat vpravo ";
$locale['html_009'] = 'Zarovnání ospravedlnit ";
$locale['html_010'] = 'Vložit odkaz';
$locale['html_011'] = 'Vložit obrázek';
$locale['html_012'] = 'Center';
$locale['html_013'] = 'malý';
$locale['html_014'] = 'Small2';
$locale['html_015'] = 'Alt';
$locale['html_016'] = 'Oddělovač stránek';
$locale['html_017'] = 'Barva písma ";
$locale['html_018'] = 'Bod';
$locale['html_019'] = 'Nadpisy';
$locale['texty'] = "Text";
$locale['náhled'] = "Náhled";
$locale['word_count'] = "Počet znaků";
$locale['error_preview'] = "Preview Error";
$locale['error_preview_text'] = "Náhled nelze generovat dočasně Obnovte stránku a zkuste to znovu.".;


ack


TeamCity pull requests :: netty [Build 760](https://garage.netty.io/teamcity/viewLog.html?buildId=3628&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:33


Does this make sense? It's only 2 CPU in a container have a look. This too high.


Don't leave such commented lines.


Вот в этом патче, возможно, и есть проблема.
Откати его и поправь отдельным патчем опции монтирования /system, /data....


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6912](https://teamcity.mesosphere.io/viewLog.html?buildId=81548&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:56


Je teste les commentaires


lgtm


könnte man vielleicht auch in ne protected methode auslagern


I will fix the PXF and ErleBrain boards. It would indeed be better. Do you mind if I don't fix that here?


coucou


Насколько помню, если перенести эти строки из init*.rc скрипта в fstab, то U9200 (P1) не грузится. У U9500(D1) данной проблемы нет.


alleeeeeeeeeeeeeeeeez


Perfect. My one note is that this code allows for chaning value in a derived label. Better fail, because this does not make sense to set a new value when it is derived. Throw an error. Otherwise, we may run into hard to debug issues when values are not propagated. If you fail loud and fast, this will be discovered quickly.


crowbar_databags_path.join(...) müsste auch gehen


Please describe why in the commit message.


Yep, I took it in our userland driver code. True about the mistakes in indentation.


crowbar_databags_path.join(file) müsste auch gehen. und die anderen unten auch


It's about the `__*` macros in boost/detail/workaround.hpp.


crowbar_databags_path.join(file).open(...)


TeamCity pull requests :: netty [Build 761](https://garage.netty.io/teamcity/viewLog.html?buildId=3629&buildTypeId=pulls_netty&guest=1) is now running


I'll look into the instance. it's firing search regex parsing two times now. can be more optimized.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6911](https://teamcity.mesosphere.io/viewLog.html?buildId=81547&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:13:24
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


@bryk Sure i will do that. One more thing, because goog passes checks but function itself can not be executed in browser. Where I can import this or make it available to use?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6913](https://teamcity.mesosphere.io/viewLog.html?buildId=81549&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:42


This doesn't fix the issue, user cannot use the arrow keys to move the cursor in text boxes in Firefox browser.


HHVM tests does not fail.


pourquoi cela ne serait pas le cut_edge_topo qui ferait un set_dart_embedding à chaque fois au lieu de faire une premier tour de cycle ici puis un second dans le bloc lignes 194-200 ?


permission


can't we put this version in parent ?


Why did you rename the phpunit file?

Surely it only applies to this project...so it won't conflict with users other projects?


That was fast! Awesome. :)


Shouldn't it be `${PKGVER:-autogenerated}`?


@ala-ableton https://github.com/mli-ableton/aqt-stylesheets/commit/7e596b544e903661c592304c09f84406d9939733


Curse youo ;-;


Consider changing coding rules so once a (second, third, ...) parameter is wrapped, all parameters are wrapped to new lines – improve readability. Same should apply on all fluent interface calls.


why static ?


Sorry. HHVM fail too. Could you open a PR with the fix?


@bryk: Actually I've struggled with directive before and couldn't make it work. I can try again :)


So, what is the relationship between this account and mystic AutumnsWind?


pourquoi le set_dart_embedding ne se ferait pas là à chaque creation plutot que de faire deux tours (un tour topo ici + un tour dans les lignes 194-200 ?


У меня по плану было в другом месте про неё сказать. Но пусть будет здесь. Только я бы чуть выше про неё вскольз упомянул тогда уж:

> Кстати, выставляются маркеры не только командой поиска, но и многими другими
командами, которые потенциально перемещают курсор на большие расстояния,
например, переходы в начало и конец буфера (=C-<= и =C->=), переход к строке с
заданным номером (=M-g M-g=), а также командой =C-SPC=.

Wot u sey?


I deactivated this, because I wanted to put the zoom controls outside the map und the grey bar below.


I built XE web before committing and it was working well and the message on jenkins does not make much sense: "Some plugins are missing valid versions:(SNAPSHOT are not allowed )".


TeamCity pull requests :: netty [Build 761](https://garage.netty.io/teamcity/viewLog.html?buildId=3629&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3731, ignored: 3 Build time: 00:02:56
### Failed tests
```
io.netty.buffer.UnpooledTest.shouldAllowEmptyBufferToCreateCompositeBuffer: <no details avaliable>

```


Should use function parameter?


FYI, Graylog 1.x doesn't and won't ever support Elasticsearch 2.x. Support for this will be added in Graylog 2.0.x.


django 1.7 still not supported yet?


No, I was just thinking that if the idea with doubling the speed to keep the flow rate the same, you probably want to double the speed of an extrusion, but not of travel moves.  Taking the travel speed and doubling it doesn't do anything to help keep the flow rate constant.  Now that I'm typing this, it does seem like this (max extrusion speed) also wants to be a setting, no?


TeamCity pull requests :: netty [Build 762](https://garage.netty.io/teamcity/viewLog.html?buildId=3630&buildTypeId=pulls_netty&guest=1) is now running


???
Pidin 2 korda pushima. Üks kord ei pandnud Deliver.


ack


Должен быть в tools


Hey @Wall-ee can you check if after #45 it is fixed?


Hmm... I'd go and disable eslint check forcing you to use angular.isDefined. I dont want to include `goog/base.js` as a runtime dependency do the project. Just comparing with undefined should be OK. What do you think?


replace `currencyFormats` by `numberFormats`


If anybody ever looks at this, it is a bug it shouldn't be set to true


typehint


Congatulations Stephane!


You built without the legacy profile


isEmpty(), если это List


Yes, if we remove it swiftype autocomplete's dialog shows without any design on it


Suggestion: You can set encoding in readFile (mostly utf8 if that's the encoding you wrote the file with) so that you needn't do .toString() here.


you can define as the third argument the pattern :
`$formatter = new \NumberFormatter($options['locale'], $options['type'], $options['number_format']);`

and remove
```
if (null !== $options['number_format']) {
     $formatter->setPattern($options['number_format']);
}
```


I don't think it's related to this class : it's only some http calls, nothing internal is used


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6914](https://teamcity.mesosphere.io/viewLog.html?buildId=81550&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:23


AFAIU the docs --stats-http does not take parameters, also with your example one can think it can be used alone while should be used with --stats. So I'll just add a last example like:
...
--stats @foobar
# same as before but using HTTP protocol, works with all kind socket addresses
--stats @foobar --stats-http
```

What do you think?


you can define a default type, e.q. `\NumberFormatter::DECIMAL`


Если в конечном счёте интервал используется в секундах, то может сразу его так возвращать из JNI?


unit_test_framework tek satır olması gerekmiyor mu?


you should extract the module definition, there's no reason to put it into before()


ack


how does it work ? InjectedClassProxy is static, how can it access mailboxManager ?


maybe we could just throw runtime exceptions on server.stop ?


Thank you for your time.

On Linux platform tests passes.
`CentOS Linux release 7.1.1503 (Core)`
`Java version: 1.8.0_60, vendor: Oracle Corporation`
`Apache Maven 3.3.3`

On windows where is a **jacoco** exception and tests hang on **GenericCollectionMultiThreadedTest** class.
`Windows 8.1, version 6.3`
`Java version: 1.7.0_71, vendor: Oracle Corporation`
`Apache Maven 3.3.9 `

[openpojo_mvn.log.txt](https://github.com/oshoukry/openpojo/files/44776/openpojo_mvn.log.txt)
[openpojo_mvn-X.log.txt](https://github.com/oshoukry/openpojo/files/44777/openpojo_mvn-X.log.txt)


it should be a dynamic port, don't you think ?


You have mentioned utf8 encoding here. Could have done the same for the previous exercise too.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6915](https://teamcity.mesosphere.io/viewLog.html?buildId=81551&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:05:04


you should use input arguments


I did. Noticed it because it seems to be the only difference in this code between zf1 and zf2 and we are hitting some bug on the zf1 version with each() not working in ~5% of cases - http://pastebin.com/4GRELFpJ trying this as a fix in there too.


А disconnect разве не надо оборачивать в try {} catch?


Livre?


why do we need cassandra specific code here ? There's a Manager for this in Cassandra


И что с телом ответа?


Consider uniformity in your messages.


Hello Sir,
I will have done this but I am travelling towards my home and its not
possible for me to do anything right now.
I would request you to judge me over the work which I have done in past
two-three days.Also I am not making any excuse I have already done two
tasks within two days as problem statement was not clear.

Please let me know your decision based upon my skills so that I can plan
everything.
Sorry to disappoint you.

Regards,

*Vishwajeet Srivastava*
B.Tech, Pre-Final (Computer Science and Engineering)
The LNM Institute of Information Technology
Mob:+91-9461787316

On Thu, Nov 26, 2015 at 1:39 PM, praha1991 <notifications@github.com> wrote:

> No problem.
>
> Do the following.
>
> - User should be able to save GeoPoints and log them into DB(of your
> choice).
> - SavedLocationsViewer: User should be able to see image snippets of that
> location just like WhatsApp.
>
> On Thu, Nov 26, 2015 at 1:30 PM, Vishwajeet Srivastava <
> notifications@github.com> wrote:
>
> > It was written that geopoint is already given. Code quality might not be
> > very good and also I would have used database if I have been told so
> even I
> > asked explanation then also nothing was specified. I was not aware that I
> > have to include database. Also I have tried to implement basic
> > functionality in the application.
> >
> > Sir regarding proper spacing etc I want to tell you that I am still in
> > learning phase and not have very much experience of professional coding
> > these are things which I want to learn from you guys.
> >
> > Regards,
> > Regards,
> > On Nov 26, 2015 1:11 PM, "praha1991" <notifications@github.com> wrote:
> >
> > > This is hard-coded. Not a functional location logger.
> > >
> > > —
> > > Reply to this email directly or view it on GitHub
> > > <
> >
> https://github.com/vjs3/LocationLogger/commit/afcee25395d0b4b6bcda35b360617313fb3f037c#commitcomment-14633602
> > >
> > > .
> > >
> >
> > —
> > Reply to this email directly or view it on GitHub
> > <
> https://github.com/vjs3/LocationLogger/commit/afcee25395d0b4b6bcda35b360617313fb3f037c#commitcomment-14633812
> >
>
> > .
> >
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vjs3/LocationLogger/commit/afcee25395d0b4b6bcda35b360617313fb3f037c#commitcomment-14633953>
> .
>


coucou


This could work but when i deleted `no-undef` from eslintrc then suddenly `angular` is not defined. Additionally we can try to do this goog way and compare `value !== void 0` which also passes this check.


Точку перед getBoolean?


зачем ты исправил что-то в editorconfig? надо вернуть то, что было


Sweet deal!


только самой обёртке ещё класс не помешает


тут всё таки лучше не кнопку а ссылку


Shouldn't it be writeFile() here instead of writeFileSync()


this is a great time to introduce BeanTester, don't you think ?


The new URI (http://dart-lang.github.io/eclipse3/) for the plugin software site is not working.


Please add a comment on the method. Why is it necessary, what is the code doing?


BLABLABLA


Should you have a default regional instead of returning null?


I would rather use InMemory implementation than mocks here.


Selge

--
Henno Täht
Sent with Airmail

On 26. november 2015 at 11:08.53, Veebiarendaja (notifications@github.com) wrote:

???
Pidin 2 korda pushima. Üks kord ei pandnud Deliver.

—
Reply to this email directly or view it on GitHub.


As we discussed before, these are asynchronous writes and read. It works in this case but you should be very careful!


TeamCity pull requests :: netty [Build 762](https://garage.netty.io/teamcity/viewLog.html?buildId=3630&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5485, ignored: 18 Build time: 00:15:11


We do not need bidirectional relation between these entities for now. Only Post should have user.


Can you add a test for this function? Thanks!


Hi, thanks for the merge! Did you have any time to test the whole commit and release version 1.4?


pourquoi return 0 ?


This line needs a refresh too. ;)


Good! Your consistency in file names and coding convention has improved a lot! 👍


Equals shouldn't have all parameters.
For now only id comparation is nessesary.


Tu peux migrer ces paramètres dans config.sample.properties ?
Comme par exemple sms.connector.smsenvoi.account.apikey?


what was this removed?

Also, current implementation returns a doubly url encded url when calling getUR()


what happens if the server crashes?


Nice and clean 👌


We should work with stable code; _master_ branch?


`sleep(1) until Crowbar::Installer.successful?` und auch irgendwie einen Timeout einbauen


:+1:
I have got a few more things to finish up first but then I will!
(more in the pipeline, e.g. Metal compute)


make some tests, and looks like both ways are correct:

```bash
#!/bin/bash

one=${VER:-1}
two=${VER-1}

echo one: $one
echo two: $two
```

```
 Ψ  /tmp ./tests
one: 1
two: 1
 Ψ  /tmp VER=2 ./tests
one: 2
two: 2
```


test


Well, having it as a second parameter means we have to make sure that the message to sqm_logger is always quoted. An option could also be to check if the first option is numerical and if it is, interpret it as a loglevel, otherwise as a message with a default. The default should probably be VERBOSE, no?


You might want to consider having uniformity in the messages that you write to the file. This assignment isn't a big deal, but still.


'psuedo' should be 'pseudo'


spam


@borsch пояснюю, для людини яка не вкурсі нюансів, mongo погано працює з енамом, по правді він взагалі з ним не працює через jdbc connector, поки ти не напишеш спеціальні кодеки. Плюс розкажи мені, яка принципова різниця між енамом, і окремим класом для констант, в які я все - таки, винесу ці значення для зручності.


What if the user is already running a service on 8765? We should [choose an open port](http://stackoverflow.com/questions/2838244/get-open-tcp-port-in-python/2838309#2838309).


@ash37 reckon you can run through this and add short names? `['Herb & Cheese', 'Herb & C']` or whatever you want.


Please consider having lower cases w/o spaces in your folder names.


'WEHER {}' should be 'WHERE {}'


writeFile() and readFile() are async. It works here but be very careful when you deal with async operations.


No, this is worse. If you want date stamps in the debug log, add them inside sqm_logger when writing to the file.


Well, there are lots of things that can go wrong with the server...

Twisted wraps everything in try/catch, so it never completely crashes. (I've never seen it crash.)

If our code crashes, then the status stops updating. That's not great, but at least at present the status updates frequently enough that someone who uses Gentle regularly would know that something isn't right.

The biggest failure mode I'm seeing is deadlock. Something blocks, and then there's silence. It's not exactly a crash, so none of the usual mechanisms work.


I think the formatting is slightly off here.


Well, the GUI is for people who like double clicking on .app bundles to run software. I'd love to run into a user who's already running a service on port 8765; I'll buy them a beer.


Unnecessary indentation


You need do disable this eslint check: https://github.com/Gillespie59/eslint-plugin-angular/blob/master/docs/definedundefined.md

And then compare to just `undefined`. Comparing to `void 0` looks hacky :)


この部分で Cookie の ID を取得するようにしていますが、aipo.message.reloadRoomList 自体はいろんな箇所で呼ばれているので、最初に aipo.message.reloadRoomList が呼ばれる箇所で、aipo.message.getCookieRoomId() を入れる実装は難しかったでしょうか。この場所で管理すると、ロジックが複雑になりそうです。


Good work! Please have a watch on you formatting. Also good that you have commented your code.


Good work! 😊 Just get your conventions a bit stricter.


プロダクトコードの場合はコメントは使わずに行ごと削除するようにしましょう。


That might be an issue, since the isset checks if 'regional' exists. Now if it doesn't for that locale it will keep using the one it has, there is no guarantee that default locale will have regional. This is also why I only setLocale when regional isn't null. The whole problem is that current users do not any reginal set


For instance, VM users of [IntraVUE](http://i-vue.com/intravue/help/TomcatPortChange.html) may struggle with the Gentle GUI.

![mainscreen](https://cloud.githubusercontent.com/assets/208551/11419726/1b43b1f0-93de-11e5-97ad-0e02bd775e5e.jpg)


is this a review comment?


maybe :+1:


And NetBSD ? perhaps can be replaced by:

    elif self.stats['os_name'].endswith('BSD'):


C&P


The changes are correct.


a line note?


This commit appears to be breaking on Drone atm.


I have this very same problem, the ".click" methods produces the same error while the ".trigger(:click)" method works like a charm.


This condition is always false, you never go in the loop


:+1: another line note


Experimenter actions should not be reported via this bitmask.
なので、
ofp.OFPAT_EXPERIMENTER: 'EXPERIMENTER'}
は削除です。


What do you mean by unusable?
I obviously forgot to add the new class to autocomplete.js but i do not understand the removal of display: block since this makes the info show in one line and thus to big in width...
If you ok with that i'll revert this. Please report any dropdowns that are broken and report them... I'll fix them than...


what are these line notes :+1:


I am fine about this index.


@dannysmith Morning Danny, can you review my code please


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6916](https://teamcity.mesosphere.io/viewLog.html?buildId=81576&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:53


hi


'instructing the database' should be 'instruct the database'?


Just switch line 725 to:
`var amt = parseFloat(amount);`


I dunno, people's computers running all sorts of strange things. I think it's easier to handle this case now than track down weird behavior in a cryptic bug report later.


lol @ IntraView


TeamCity HR_RAVENDB :: test [Build 1](http://phi.ais.pl:8989/viewLog.html?buildId=25569&buildTypeId=HrRavendb_Test) outcome was **SUCCESS**
Summary: Running Build time: 00:00:15


TeamCity HR_RAVENDB :: test [Build 2](http://phi.ais.pl:8989/viewLog.html?buildId=25570&buildTypeId=HrRavendb_Test) outcome was **SUCCESS**
Summary: Running Build time: 00:00:04


```
PHP Notice:  Undefined variable: data in phar:///home/cabox/workspace/phploy.phar/vendor/banago/bridge/src/Backend/Ssh2.php on line 89
```
looks like the `$data['path']` is not defined.


TeamCity HR_RAVENDB :: test [Build 3](http://phi.ais.pl:8989/viewLog.html?buildId=25571&buildTypeId=HrRavendb_Test) outcome was **SUCCESS**
Summary: Running Build time: 00:00:03


delete


Hi there


TeamCity HR_RAVENDB :: test [Build 4](http://phi.ais.pl:8989/viewLog.html?buildId=25572&buildTypeId=HrRavendb_Test) outcome was **SUCCESS**
Summary: Running Build time: 00:00:03


-_- ....


this -> This


I wish I was more familiar with the whole pg_temp stuff, but I believe this does what you say it's supposed to do in the commit message -- the command will indeed not race with a pending update.

Because of that, LGTM.


@AmiraSh
@untilovdmitriy
@alinok
Now we can use js-scripts at PartialViews


What are you doing here?


TeamCity HR_RAVENDB :: test [Build 5](http://phi.ais.pl:8989/viewLog.html?buildId=25573&buildTypeId=HrRavendb_Test) outcome was **FAILURE**
Summary: Error message is logged (new) Build time: 00:00:03


Blev vi ikke enige om at sende $jsonSchema med post request? Så skal den ikke ind som argument her og optional parameter i routes. Den kan tilgås med `$request->input('jsonSchema');`


Hi Toke,
with the log levels we introduce some requirements on the use of sqm_logger, quoting the actual call value does not seem to onerous to me.


Husk at skrive `@param type $var`


You mean disable it locally for this method using `/*eslint-disable angular/definedundefined */ or globally?


Rafał Rak/Rafał Dominika GIT/trunk/wspolnyPlik.txt

To jest okrutne :(


Konflikt się dopiero zaczął


To jest źle


Ale to jest dobrze


TeamCity HR_RAVENDB :: test [Build 6](http://phi.ais.pl:8989/viewLog.html?buildId=25574&buildTypeId=HrRavendb_Test) outcome was **FAILURE**
Summary: Not all commiters signed CLA, please visting http://ravendb.net/ and sign CLA (new) Build time: 00:00:03


Ale to jest nie do pomyślenia!


Mądrze prawisz


Dobry sposób rozwiazania problemu


Zajmie to zbyt dużo czasu


Can you refactor this to use an internal `yas--default-user-snippets-dir` variable or function everywhere?


Ok


nie ok


Goed hoor


za długie


Also, if possible, follow the ChangeLog format guidelines described in the CONTRIBUTING.md file.


you need to take here to account that tier.txt file does not necessarily have 7 columns (you didn't even check for it)


Za dużo błędów


So close


I was thinking about what happens if the server crashes and restarts. It'll 404 on the status page. Maybe it makes sense to persist the status in a file or a database.


co teraz?


To nie zadzaiała


it is hard


Coś jest nie tak


to be safe I would here support both count == 6 and count == 7 versions


and here too ofc


this needs condiitonal then


page profile


dzisiaj


więc


taki commit


smutno


before this block you should insert the migration from 7 columns to 8 columns, similar to rows before this using migration from 4 to 7 columns with additional decay stats


on to jest


ale jak


dlaczego


dzisiaj?


ale ale


tak jewst


yyy


qeswewr


werewrewrewrew


There's a big bug here :-), you have to either use `list` or backquote and comma.


werwerewr


ewrwerewrewrew


Other than that, it's a good change.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6917](https://teamcity.mesosphere.io/viewLog.html?buildId=81585&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:58


It's something to think about. I don't want to over-engineer the webserver part right now. Just trying to get it "good enough" and then we'll see where the pain points actually are.


No more use for the `bias` ? Should we remove it completely ?


This is a lot better than mine ;)


把orm 的增删改查操作封闭成函数放在models包里  然后controllers包里调用。


Then you'll have to do removeWindow($this->getInventory())


Anyway, you're right. It's an easy fix. 948d9922a855615bddbe651d74d234d4216843de


Build failed :(
Could not find goal 'skip=true' in plugin org.codehaus.mojo:findbugs-maven-plugin:3.0.3 among available goals check, findbugs, gui, help -> [Help 1]


Why not simply move this into the try statement above (line 30 here)?


Hi Toke,

On Nov 26, 2015, at 10:32 , Toke H�iland-J�rgensen <notifications@github.com> wrote:

> No, this is worse. If you want date stamps in the debug log, add them inside sqm_logger when writing to the file.

	Well, I want separators in the log file between the different instances and/or invocations of the same instance, that change gives me exactly that. I do not care for a time stamp for each individual call. DSo I really want to do this from start-sqm and stop-sqm. Since you rightly pointed out the ugliness of showing the date in syslog, I changed it. I could defend leaving it in the sqm_logger call as that would allow easier correlation between debug.log and logread outputs. But having the dates as separators with a few newlines in debug.log is nice enough for me�

Best Regards
	Sebastian

>
> �
> Reply to this email directly or view it on GitHub.
>


@alice you can take a look at monthly stats over at https://www.npmjs.com/package/accessibility-developer-tools and more detailed stats at http://npm-stat.com/charts.html?package=accessibility-developer-tools&author=&from=&to=


...the main "cost" of random-port-by-default is that it makes it difficult to use other people's Gentle on mDNS.


`isAllDay()` doesn't seems to be mutating.


bodyPart maps to DICOM BodyPartExamined in the converter. It definitely should not be HEAD in all cases.

In [this commit](https://github.com/QIICR/Reporting/commit/5836c84e5226cd42fc859c728d27027c6d7ca0da) I added a capability to the EncodeSEG to populate that attribute from the source data, if it is not empty. Otherwise, the converter will use the bodyPart argument passed to it.


I want to avoid modifying the Spoon code as much as possible because of how terrible it is. Eventually I'll replace it with a better solution (javaparser probably). Until then it will stay as is.


не импортирован класс FigureType


имя файла и имя класса не совпадают


ах вот оно что. Ты используешь не существующий класс FigureTipe вместо FigureType


Nie je nutné. Service triedy majú anotácie `@Service` a Spring si ich nájde sám, keďže máme "component scan".


You're right, that was committed by accident, thanks for noticing!


Tak JUnit alebo TestNG? Dva rozdielne test frameworky...


Hi Brady
Unit testing ok At Reports -> Procedures -> Statistics -> Submit


@lojack5: any clue why NS and not N like the rest ?


@lojack5 I guess this was just a bug (as detailed in the commit message) ?


@lojack5: Posted some questions for you - in general any insights on the refresh of BAIN is appreciated - will be merging those soon, so I'd rather do it without my ugly `##:` comments.

In general merging your fallout and my utumno-wip branch + the skyrim patchers branch and we have enough for a beta (dev already contains radical changes and more reside in my bleeding edge branch)


shit, my fault.


AKA should the rest be NS also ?


Make sure client is not null.  In all 3 procs.


Never too late to change it :)

Just trying to figure out how to code that cleanly - it also should not show it when returning from the menu, and the current mechanism is really ugly so I want to make it nicer. I'll commit a better solution later.


This actually does not compile on gcc-arm-none-eabi-4_9-2015q1
It seems that unless you use C++11, you need to use constexpr for it to get compiled.
What backward compatibility are you referring to @pingdynasty  ?


Where's the script file and why's the "2-6" in there?


I link that ringbuffer.c doesn't belong in libc, but probably lib/utils (or something like that) instead.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6992](https://teamcity.mesosphere.io/viewLog.html?buildId=81894&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:08:11


It would be good if these could be allocated dynamically. Then if boot.py set usb_mode to None, the app would have 2k more heap memory.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6993](https://teamcity.mesosphere.io/viewLog.html?buildId=81895&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:08:16


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6994](https://teamcity.mesosphere.io/viewLog.html?buildId=81896&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:25


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6995](https://teamcity.mesosphere.io/viewLog.html?buildId=81897&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:23


This is the user's own version number, which I stripped out (but forgot this part)


Enabling JIT also improves performance on most modern spec devices (Nexus 5 included)


Thanks!


<img width="598" alt="screen shot 2015-11-27 at 01 27 14" src="https://cloud.githubusercontent.com/assets/2320/11432104/1eed17e6-94a7-11e5-87da-a398373f019f.png">


@bw0lff @nicklockwood thoughts on adding the `1.4.1` tag to the repo so this podspec will validate? 😀


@Gigi1237 any ideas about CDataStores?


This should use private/json/getPageComments.php instead.  The whole point of the private/json/* thing is to put together the data for a page in a uniform way before sending it off to either be rendered as a webpage or an in-game page.  You can probably just json encode the current output of the page.  I might need to rewrite it to not rely on $_GET or $_POST since I have not heard of $_REQUEST


r+


Can we do this before these route handler methods are hit? It would avoid duplication.


np :wink:


I didnt test that, but yes it seems like the talent is bugged. When it procs the next aracane missiles are instant.
From a 4.72s cast to instant (it should be only 2.5 secs faster)


actually list what you changed.


well this is pretty awkward..


Maybe just make Group itself inherid from < Dry::Validation::Schema.
And then we just add the `call` method.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6996](https://teamcity.mesosphere.io/viewLog.html?buildId=81898&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:53


Yep, am talking with @lmars about how to do that.


We should include an error message to go with the assert (there won't be anything useful printed if this fails)


go going, you managed to move every sound into the tools folder.


@kriox26 @Jorch95 se me hacia loco implementar graficas de objetos dinamicos sin que tengan el codigo funcional... pero OK :) Solo para confirmar antes de borrarlo... ¿estan seguros? Pregunto porque la grua si mal no recuerdo interactua con niceland (""lo construye"") y niceland tal vez para que todo quede joya deberia tener un metodo que reaccione a la accion de la grua tipo "builtByGrua()"


should add this to your `.gitignore`


4-space indent


Impressive, i know


Could you move this to https://github.com/snowcapdigital/snowcapdigital.com/blob/master/src/scss/layout/vendor/_headers.scss? This file is for the splash element on the home page. The other file is for vendor header overrides (which is what this is).


em...this has already been reverted in another commit. Actually the
previous DefaultFingerprintFor was using a unexported otrVersion struct,
which seem more wierd to me...
2015年11月26日 上午5:44，"Ola Bini" <notifications@github.com>写道：

> I don't really like this - I already added DefaultFingerprintFor() to
> Conversation. Also, it should be Fingerprint, not FingerPrint.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/twstrike/otr3/commit/d9924a82c854ce25ef5d3d0659959657401c1536#commitcomment-14636993>
> .
>


true, but it's something like a 3rd check in line between sigAlg being different that the value for rsa. It's just so that when we add support for ecdsa the appropriate code "raises hand" that it needs to get changed


Yes exactly. I dont think you can do it at all in VC, its C99 thing, and VC is stuck as C89.


I call it in block `{% block content_content %}` in my twig template that extends `{% extends 'MopaBootstrapBundle::base_less.html.twig' %}`.

If I want to use 'button' as close_tag instead of default 'a', I should use this code
`{{ advanced_flash('info', 'title', 'message', 'button', true) }}`
then
`{% if close_tag == true %}` is (bool)true because 'button' == (bool)true is true.
and then
`{% set close_tag = 'a' %}`
and there is no way to use 'button' or something else as close_tag.


Also, since you've removed `1em` from the height of the top area, you need to also remove `1em` from this line: https://github.com/snowcapdigital/snowcapdigital.com/blob/master/src/scss/env/vendor/purecss/splash-layout.scss#L39, this line https://github.com/snowcapdigital/snowcapdigital.com/blob/master/src/scss/env/vendor/purecss/splash-layout.scss#L45, and this line https://github.com/snowcapdigital/snowcapdigital.com/blob/master/src/scss/env/vendor/purecss/splash-layout.scss#L48


All this just to remove a single cast [here](https://github.com/gradle/gradle/commit/e8b242991aa05cd2d2fcea9305910b356e7bc42a#diff-79643d382161ba364aed7cfd4ff00180L39)...


@ericbrisrubio Coño pipo, la cagastes!! Tests fail because the UsersData struct no longer exists. I fixed it


média de um aluno apenas dos números pares, maiores do que 10.


I don't know what is the proper way but this is broke wxWidgets 2.8 compilation. So I revert it.


Esse arquivo náo deve entrar no github, ele é pessoal ( .user ), remova ele com git rm


r+


Nah, the change wasn't redundant.
I figured out the issue: the partition segments code didn't account for the case where all the segments belong to the first n sections, and there are more than n sections for that track. Looks like I have fixed it now, looking at my tests on 300 of the tracks. Committing changes in a bit, so that we may both generate the correct features for all the tracks.
Sorry for the inconvenience, as I know you had already generated all of the features for the 4,000 tracks already.


That unexported type thing was fixed here: cc3cdf3471717a1fd352fb354d9437156f4f5903


See also: https://code.google.com/p/android/issues/detail?id=195501


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6997](https://teamcity.mesosphere.io/viewLog.html?buildId=81899&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 203 Build time: 00:04:42


is this going upstream? I'm also using Spoon on Java 8 code


It's okay, it only takes an hour or so and I can just start it and let it
run. I'll let you know if I run into another issue so that we can debug
more constructively next time around

On Thu, Nov 26, 2015 at 8:18 PM, LaggFTW <notifications@github.com> wrote:

> Nah, the change wasn't redundant.
> I figured out the issue: the partition segments code didn't account for
> the case where all the segments belong to the first n sections, and there
> are more than n sections for that track. Looks like I have fixed it now,
> looking at my tests on 300 of the tracks. Committing changes in a bit, so
> that we may both generate the correct features for all the tracks.
> Sorry for the inconvenience, as I know you had already generated all of
> the features for the 4,000 tracks already.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LaggFTW/CMSC396H/commit/fefd574a690065a1dfe68255d2e7c6f575a5028b#commitcomment-14647796>
> .
>

--
Matthew A. Myers
Majoring in Computer Science, Music (Wind Performance Emphasis)
University of Maryland College Park | Class of 2017
Gemstone Honors Program <http://gemstone.umd.edu/>: Team STRIDE
<http://gemstonestride.weebly.com/>
(240) 499-6560


My understanding is that your statement was true until the very latest, VC2015, where enough C99 features were picked up (still not all, though), that most C99-y code works.  Note: hearsay, I have not used VC2015 myself.


TeamCity ReOpenLDAP :: master [Build 35](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1250&buildTypeId=ReOpenLDAP_Master&guest=1) outcome was **SUCCESS**
Summary: Tests passed Build time: 01:32:05


Redo this to maintain classpath order. Put the additional development paths at the end, or the beginning?


encontrei!


:+1:

Any plans on creating a PR for this?


@vlj j'ai droit a ça dans le log
>RSX: W {rsx::thread} Unknow Teture format 9f, fallback to UNORM.

ça peut t’aider le 9f ?


@itsjeyd Thanks for these fixes! +1 from me on the accessibility commits now.


Truth be told this wasn't even supposed to be a public repository, but beggars can't be choosers ;)

That being said, yeah, I usually try to write meaningful commits (mostly for myself), especially when I'm making major or cryptic changes. But after so many commits in a day, sometimes I just get lazy I guess.

As for that particular commit, the comment was referring to how the hacky algorithm became more stable and "less buggy": less asteroids were being lost in limbo (i.e failing to wrap properly and remaining offscreen).


markdown 沒辦法指定寬高，所以只能 html 解


@sebastian-leidig What did I change in the log file? (I don't actually recall modifying it. Could something else have triggered it?)


s/unknow/unknown/

Otherwise, looks good :smile:


This commit breaks support with `ionic serve` livereload. The livereload script is unable to be loaded because it would break the content security policy.


Required ok!


Used code from adafruit motorshield libraries to attempt to make the motor move, but did not work.


WAT


I have an error with 'OPEN_WEATHER_MAP_API_KEY'

it cannot resolve this symbol


Minor suggestion: "added as a family member" or "added as family" would be more correct.


Well I was talking with a Win32 tester and they are telling me it is failing... alas...


r+


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 6998](https://teamcity.mesosphere.io/viewLog.html?buildId=81900&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 201 Build time: 00:04:48


Quick Google dip leads me to believe that already VC2013 gained some C99-isms, and maybe even the variadic macros.  (But yes, it's stupid that the C99 support isn't there yet.)


This is good, you moved `post.update_rank`, but you also need to move the `after_create` callback as well.


Do you see why?


I have no plans on requesting this to be merged to upstream, it's not a proper fix for Java 8 issues. I designed this to make our code that depend on it work, so it's really hacky and probably not entirely correct.

One big issue is the new TypeIntersection which is a subtype of Type. Since it represents multiple types, most CtTypeReference methods, which expect a single type, can't properly be implemented by CtTypeIntersectionReference.


Can't put URL from internet for streaming. Only tracks in MP3,MP4,WAV,etc.


Is the Spoon team aware of the problem?


把你的presenter中的接口们移到了ui里面去了，再把OkHttp2.5.0升级到2.6.0，嘿嘿


I haven't contacted them, but I assume they would know since it's quite a major issue.


comment 1


This will need to be updated for the next stable release.


Why not quickly file an issue referencing this commit?


Sure, I'll do it.


Sorry I didn't see that you'd responded before. Serializing the subject makes it threadsafe, but I see now that you were talking about the passed in object and not the subject itself. Serializing the subject might still help, but it would help if you elaborated on why and when the object needs to be threadsafe


great, thanks


I will apply this rule to the Github API, maybe the same error occurs because this.


If you could tell what exactly is broken, I might look in fixing it, although, to be honest, it's hard to be motivated on compatibility with an almost 10 year old release.


So I added a little blurb but feel free to change it to better fit or whatever.


j'ai trouvé ça pour fixé motorstorm, et j'ai plus d'erreur pour ça dans le log, tu pense que c'est bon ? :)


Might be best to address this separately. I don’t think adding the rhetorical comment helps.


@vlj j'ai trouvé ça pour fixé motorstorm, et j'ai plus d'erreur pour ça dans le log, tu pense que c'est bon ? :)


Those comments would have been useful! ;)

I didn't realize the conditions corresponded to TCTDAFunctionParamType...


TeamCity pull requests :: netty [Build 779](https://garage.netty.io/teamcity/viewLog.html?buildId=3679&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5291, ignored: 21 Build time: 00:26:20