Seeing this probably means that we only need 1 of these concepts in Mokap for now. Screens is a more general grouping of the structure of the game, intended to identified different modes in the game. So, for example, in a simple game you could have two screens: the menu screen and the game screen. It's still kind of undefined, so the safe bet here is use zone, which delimits different virtual zones inside the game world.


yep


Absolutely, but you might want to wait a day or two. I'm still playing around with some of it and there's a few more things I want to take a pass at. After that I can clean things up and make a better PR for you depending on what you want. There was more code in common between the two representations than I thought, but you (for instance) probably don't want a separate `Internal` module just for list.


Done in https://github.com/lis-epfl/MAVRIC_Library/commit/cbeead016c68d86afef6bc8eda3591b9757bb648


And I got the error again on this

==> soa2admin2: Notice: /Stage[main]/Basic_config/Wls_server[BamServer1]/ensure: created
==> soa2admin2: Notice: /Stage[main]/Basic_config/Wls_server[AdminServer]/arguments: arguments changed '-XX:PermSize=256m -XX:MaxPermSize=512m -Xms1024m -Xmx1532m -Dweblogic.Stdout=/var/log/weblogic/AdminServer.out -Dweblogic.Stderr=/var/log/weblogic/AdminServer_err.out' to '-XX:PermSize=256m
==> soa2admin2: -XX:MaxPermSize=752m
==> soa2admin2: -Xms752m
==> soa2admin2: -Xmx1532m
==> soa2admin2: -Dweblogic.Stdout=/var/log/weblogic/AdminServer.out
==> soa2admin2: -Dweblogic.Stderr=/var/log/weblogic/AdminServer_err.out'
==> soa2admin2: Notice: /Stage[main]/Basic_config/Wls_server[AdminServer]/log_file_min_size: log_file_min_size changed '5000' to '2000'
=

with this as error text
=> soa2admin2: Notice: /Stage[main]/Basic_config/Wls_server[AdminServer]/log_http_format: log_http_format changed 'date time cs-method ctx-ecid ctx-rid cs-uri sc-status bytes' to 'date time cs-method cs-uri sc-status'
==> soa2admin2: Info: modify default/AdminServer
==> soa2admin2: Info: Creating state file /var/lib/puppet/state/state.yaml
==> soa2admin2: Error: Could not run: compile error
==> soa2admin2: (erb):12: syntax error, unexpected ';'
==> soa2admin2: ... unless arguments.nil? then -; _erbout.concat "\narguments  ...
==> soa2admin2:                               ^
==> soa2admin2: (erb):17: syntax error, unexpected ';'
==> soa2admin2: ...- unless bea_home.nil? then -; _erbout.concat "\nbea_home   ...
==> soa2admin2:                               ^
==> soa2admin2: (erb):22: syntax error, unexpected ';'
==> soa2admin2: ... unless classpath.nil? then -; _erbout.concat "\nclasspath  ...
==> soa2admin2:                               ^
==> soa2admin2: (erb):27: syntax error, unexpected ';'
==> soa2admin2: ...ess listenaddress.nil? then -; _erbout.concat "\nlistenAddre...
==> soa2admin2:                               ^
==> soa2admin2: (erb):32: syntax error, unexpected ';'
==> soa2admin2: ; - unless machine.nil? then -; _erbout.concat "\nmachineName    = '"
==> soa2admin2:                                ^
==> soa2admin2: (erb):302:in `on_modify'
==> soa2admin2: /tmp/vagrant-puppet/modules-e130052d73d3d620104b72a4a92d8aa8/orawls/lib/puppet/type/wls_server.rb:29:in `on_modify'
==> soa2admin2: /tmp/vagrant-puppet/modules-e130052d73d3d620104b72a4a92d8aa8/easy_type/lib/easy_type/provider.rb:96:in `call'
==> soa2admin2: /tmp/vagrant-puppet/modules-e130052d73d3d620104b72a4a92d8aa8/easy_type/lib/easy_type/provider.rb:96:in `build_from_type'
==> soa2admin2: /tmp/vagrant-puppet/modules-e130052d73d3d620104b72a4a92d8aa8/easy_type/lib/easy_type/provider.rb:85:in `flush'
==> soa2admin2: /usr/lib/ruby/site_ruby/1.8/puppet/type.rb:990:in `flush'


Done in https://github.com/lis-epfl/MAVRIC_Library/commit/f3bea820845d2de7cab11da8b5a96efcc41dbbd4


After I added back the bean, I compared my file to master and these lines were present. I added them because I did not want it to appear as if I had removed them.

In addition to your earlier comment, I should always check my merge on GitHub for such strangeness before I request a review.

I will review the request and fix these things.


Creating a query is cheap. No need to memoize. It doesn't hit the db until
you call all, count, etc or slice/iterate over the query


hhh


Some deep emacs working knowledge and clever solution here !


Got it from here: http://staticfiles.productiondjango.com/blog/failproof-favicons/


So `UnixWindow` has an `X11Window` even though it doesn't use it?


How come we are giving null values as the last two parameters for the SSlSocketFactory?


Ah, I see what happened: the one in rpu raised an early error...  I fixed that now.

We don't have a policy, really: we sometimes check in the tools, sometimes in the util layer.  Its probably safer to always check in the util layer, so I'll revert this one, and willl fix on that level then...

thx!


感觉怪怪的。不知道可不可以设置三列，在第三列说明是 static 还是 dynamic。


We tend to use a descriptive label for the revision so that it appears nicely when listing.


Ball now collides with the paddle; otherwise it just falls through the canvas.


Additional question...the subtitle is successfully add in the mp4,I can see it on PC,but once if move it in an android phone,the subtitle is missing..Can you tell me the reason?
Rogers
  Best regards.


The thing is that the `resources.groupBy { it.url }.find { it.value.size() > 1 } ` results in null if no duplicates are found, which causes the exception when the `getAt` is called, as the safe navigation operator does not cancel the evaluation of the expression.

On the second thought, the `with` operator seems a bit more intuitive than the `each` in this case. Also, taking any resource from the list of resources with duplicate urls must be sufficient enough to do the job. So the snippet could be replaced with the following:

```groovy
resources.groupBy { it.url }.find { it.value.size() > 1 }?.value?.head()?.with { res ->
    throw new RuntimeException("Encountered duplicate resource URL: ${res.url}")
}
```


Стоит вынести в стиль.


hi ower.
DcmViewer class dosen't  exist.
Can you help me ?
thanks


It does. Check the constructor.


this is from a457978d6e703d57f9b04bcb1cec6810cb458623
do you think I should change the version in MPT too?


didn't know about the rmd; noted


Just checked how it performs on www.composite.net: ~5 ms on the front page, which has ~39kb of html.
It is actually strange for me that it is that slow on the airshoppen.com, which has twice less markup (at least on the frontpage).

It could be that some specific kind of markup causes the issue, will try to profile it some time later on.


On Android? It's not like there is only one single player on android. Which
player are you using? Is the player at least expected to support subtitles?
If yes: Which format is supported

2015-11-03 10:45 GMT+01:00 xszfqs <notifications@github.com>:

> Additional question...the subtitle is successfully add in the mp4,I can
> see it on PC,but once if move it in an android phone,the subtitle is
> missing..Can you tell me the reason?
> Rogers
> Best regards.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sannies/mp4parser/commit/d527c284a067f3e8d518387179c5f35d10561fe3#commitcomment-14149192>
> .
>


ショップ回復ボタンをお金が足りない場合は押せないようにする #290


没找到。改回显示一个 pod 了。我合并了。


Переделала


Sure, xxpermdi, as it was defined, i.e. following the vasm convention of putting source before destination, must take inst.d operand first and its destination after, not the opposite. I'll fix it.

My major concern is how to ensure that vasms like  xscvsxddp, xxlxor, and xxpermdi will use the same register, because otherwise the emission won't make sense. The reference you've provided (22a8beb781d0bf7e328314a035a2ae882032bcf3)  says "it **can** be optimized to but lowering **is not the phase for that**". Hence, is there a chance that non-optimized code using different registers will be executed? What am I missing here? I just lower the vasm in question because I need an additional VSX register to get a zeroed doubleword.

My major concern is how to ensure that vasms like  xscvsxddp, xxlxor, and xxpermdi will use the same register, because otherwise the emission won't make sense. The reference you've provided (22a8beb781d0bf7e328314a035a2ae882032bcf3)  says "it **can** be optimized to but lowering **is not the phase for that**". Hence, is there a chance that non-optimized code using different registers will be executed? What am I missing here? I just lower the vasm in question because I need an additional VSX register to get a zeroed doubleword.

What you mean by "save" the inst.d to the final destination of my vasm? Could you point out an example, please?


But that's exactly the case. You would need to call `count()` twice.


we do not all build shamu, you wish :8ball:


ショップ全回復金額を残りHPから算出する #289


ショップ回復金額をレベルから算出する #288


Добавила


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3333](https://teamcity.mesosphere.io/viewLog.html?buildId=67227&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:32


But then memoizing the query object won't help anyway. It doesn't store any
"state" or results.


wenn ich diesen operator sehe fällt mir gerade folgendes ein: welche php version ist mindestversion?

Ich denke wir sollten auf 5.5+ setzen, da php 5.4 bereits aus dem support rausgelaufen ist
siehe http://php.net/supported-versions.php


I had already removed "Select all", but then added it back, because it might be useful when you filter available users with a keyword. But I'm no longer sure about that either.

I think your proposal about locale contributors makes sense and I was planning on doing something about it, but haven't figured out the UX yet.


wann ist der fieldsetName == $this->name?


Nice commit! Was much needed!


You're right, this line should be removed or completed.
Noted in my reminder for the next update...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3332](https://teamcity.mesosphere.io/viewLog.html?buildId=67218&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:06:11


TeamCity pull requests :: netty [Build 561](https://garage.netty.io/teamcity/viewLog.html?buildId=2937&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 4795, ignored: 21 Build time: 01:10:00


@hvelarde With that change, you're dropping support for Plone 4.3.x with Python 2.6 also.


This variant of patch is not work or why you revert it?


Sorry - must check the value of the string; otherwise you will get unexpected behavior:

```txt
setenv ERT_VERBOSE False
```
will give you `verbose = True`


ist die legend aus optischen/ästhetischen gründen weggefallen? aus semantik sicht, war sie sinnvoll?


falls die legend hier wegbleibt bitte auch den sprachkey entfernen


Es ist 5.4, aber habe ich auch schon überlegt, ob wir das nochmal anheben sollten.


and so strange I don't even set bea_home or classpath

Puppet version 3.7.5 and ruby 1.8.7 (2013-06-27 patchlevel 374) [x86_64-linux]


This PR fails on travis; probably not the fault of this PR - but good if you double check that.


Is the version number still be 0.0.27 rather than 0.0.32?

The package I received from pypi is still named after 0.0.27, even though it's made of 0.0.32 actually.


My question was more like "isn't there a nicer way to structure this without always having an `X11Window` variable lying around" :)


here we go https://github.com/redaxo/redaxo/issues/429


Done: c2d2500


install_packages is not documented (yet), this change seems to break R CMD check.


You just won the price of being the first person to write a release note! We will try to enforce one line of release note information, in the not-yet-existing file `release-notes.txt` in the root of the distribution:

```txt
[Feature]  Set the the verbose flag from the environment variable ERT_VERBOSE.
```


IGNORE THE ADDITIONAL HEAD TAGS


It was slower than this one. but this one doesn't have the corrmap feature,
nor return the correlation coefficent to stop the fast forward tool, so its
temporarily broken it. I'm going to fix it up to get the cofficent back.
Really I think SIFT is the right way to go but this is working in the
interim.

On Tue, Nov 3, 2015 at 1:31 PM, Brad Busse <notifications@github.com> wrote:

> What was wrong with the old correlation?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fcollman/MosaicPlannerLive/commit/28df7bc972e16d246e8635bbe1d2cf90a050509a#commitcomment-14167376>
> .
>


Reviewed, looks good apart from my existing concerns about changing log numbers at all.


yt


TeamCity pull requests :: netty [Build 573](https://garage.netty.io/teamcity/viewLog.html?buildId=2971&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:17


typo here - there is an unpushed commit sitting on my local branch with a fix for this failboat


Well, we could default to debug mode, but I'm not sure if that's a good idea. But I think I like that better than a debug output in production mode.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2683


Put this line in a single try catch block. Only `SemanticException` should be caught.


I dunno. Default production mode is safest, right? Maybe it is just a readme/docs/tutorials thing: "be sure to confirm which config is being used with -d"...


Put this line in a single try catch block. Catch Throwable. Retain stack trace of `e`.


Put this line out of try catch block


TeamCity pull requests :: netty [Build 574](https://garage.netty.io/teamcity/viewLog.html?buildId=2972&buildTypeId=pulls_netty&guest=1) is now running


just trying this out lets see how it goes


I updated the `README.md` at 7955e4d225992385bbb2f9d96b799991e68b62c9.

But maybe we should also test on the LTS version (currently 4.2.2)?


Safe? As long as there's a warning I don't see any issue with defaulting to debug mode. Well, somebody will probably still manage to miss the warning.

Problem with debug mode is that we need to explain its implications, because e.g. not handled exceptions will show up in error 500 responses while in production mode, there's just a little `something went wrong :-(` message.


Thank you Erick.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3461](https://teamcity.mesosphere.io/viewLog.html?buildId=67699&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:58


@sofiabravo103  https://github.com/MAC-USB/reserva/wiki/Sign-up,-login,-logout-y-borrar-cuenta
Despues la pongo mejor, pero eso es lo basico.


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/89124923


This may improve in Photoshop in the future.  The bounds currently reported by Photoshop include the filter mask (which you get when you have smart filters).  The filter mask starts out as the doc bounds.  If the smart filters are disabled, Photoshop could just report the bounds of the smart object, but it's probably not a common case.  If you do have filter effects, with a used mask, you'd need to composite the filter mask to get the real bounds (technically you want to get the pixels if there's any masks, since you really need to test/composite the data to figure out the real bounds).

I made a similar comment in another bug, but I think this logic should be inside Photoshop since it will change/improve in the future.  Would something like "boundsArePixelAccurate" in the json suffice?


`stable` is a bit passe now that they've gone semver. I suppose `node` and `argon` would work.


fast-forwarding master to auto = 6c60b212


I'm not sure this is a good idea. A single <select multiple> element is meant as a replacement for both of our lists (available and selected users). Its default browser usability is probably the poorest of all browser widgets, because you need to hold Ctrl/Cmd to select multiple users. And if you click an item without holding these keys, your entire selection is lost. Also, you need to scroll the entire list (could be thousands of users) to see what's selected.

We could use two elements and turn them into something closer to our current UX, but that would require way more CSS/JS magic than a few lines required for sending IDs to Django.


@alfredodeza maybe we should specify the "--pid-file" when launching ceph-mon daemon (at https://github.com/ceph/ceph-deploy/commit/238965633015f35573bee237b8513975198bbc6e#diff-5c348c201f421ef3dfddc8fb3d51bec1R165) instead of when mkfs?

as what we care more about is the status of the running status of the daemon after  it is started, instead of the running status of "mkfs". unless `remoto.process.run` is able to update the ceph.conf with the `--pid-file` option, but i don't think that's the case.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3462](https://teamcity.mesosphere.io/viewLog.html?buildId=67700&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:55


@jkeiser running into a new issue now:

```
    amazon-ebs: ================================================================================
    amazon-ebs: Recipe Compile Error in /var/chef/cache/cookbooks/gz-papertrail/resources/monitor.rb
    amazon-ebs: ================================================================================
    amazon-ebs:
    amazon-ebs: NoMethodError
    amazon-ebs: -------------
    amazon-ebs: undefined method `super_method' for #<Method: Class(Chef::ChefCompatDeprecation)#log_deprecation>
    amazon-ebs:
    amazon-ebs: Cookbook Trace:
    amazon-ebs: ---------------
    amazon-ebs: /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef.rb:6:in `log_deprecation'
    amazon-ebs: /var/chef/cache/cookbooks/gz-papertrail/resources/monitor.rb:16:in `class_from_file'
    amazon-ebs: /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef/resource/lwrp_base.rb:50:in `build_from_file'
    amazon-ebs:
    amazon-ebs: Relevant File Content:
    amazon-ebs: ----------------------
    amazon-ebs: /var/chef/cache/cookbooks/compat_resource/files/lib/chef_compat/monkeypatches/chef.rb:
    amazon-ebs:
    amazon-ebs: 1:  class Chef
    amazon-ebs: 2:    NOT_PASSED = Object.new if !defined?(NOT_PASSED)
    amazon-ebs: 3:    # Earlier versions of Chef didn't have this message
    amazon-ebs: 4:    module ChefCompatDeprecation
    amazon-ebs: 5:      def log_deprecation(message, location=nil)
    amazon-ebs: 6>>       if method(:log_deprecation).super_method
    amazon-ebs: 7:          if !location
    amazon-ebs: 8:            # Pick the first caller that is *not* part of the Chef or ChefCompat gem,
    amazon-ebs: 9:            # that's the thing the user wrote.
    amazon-ebs: 10:            chef_compat_gem_path = File.expand_path("../../..", __FILE__)
    amazon-ebs: 11:            chef_gem_path = File.expand_path("../..",::Chef::Resource.instance_method(:initialize).source_location[0])
    amazon-ebs: 12:            caller(0..10).each do |c|
    amazon-ebs: 13:              if !c.start_with?(chef_gem_path) && !c.start_with?(chef_compat_gem_path)
    amazon-ebs: 14:                location = c
    amazon-ebs: 15:                break
    amazon-ebs:
    amazon-ebs: [2015-11-04T00:15:51+00:00] ERROR: Running exception handlers
    amazon-ebs: [2015-11-04T00:15:51+00:00] ERROR: Exception handlers complete
    amazon-ebs: [2015-11-04T00:15:51+00:00] INFO: Sending resource update report (run-id: 8429fd23-aece-491a-9c40-b052826e2b79)
    amazon-ebs: [2015-11-04T00:15:51+00:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
```


typo


same here


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3463](https://teamcity.mesosphere.io/viewLog.html?buildId=67701&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:42


はっきり書いておいた方がよさそう!というニュアンスです!


IF you just write `car` and `cdr` there, then I believe the optimizer turn that into more efficient code that what you wrote here (making the cdr unsafe). I'm not sure it does that in this case, but it does do that in some cases.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3464](https://teamcity.mesosphere.io/viewLog.html?buildId=67702&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:52


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3465](https://teamcity.mesosphere.io/viewLog.html?buildId=67703&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:59


:+1: やっときます!


this v21 styles file should only have the references to the Material buttons. You would also need to define the app theme style again. Should look similar to this:

```xml
<resources>
    <style name="AppTheme" parent="Theme.AppCompat">
        <item name="colorPrimary">@color/red</item>

        <item name="colorPrimaryDark">@color/dark_red</item>

        <item name="colorAccent">@color/gray</item>

        <item name="android:windowBackground">@color/soothing_blue</item>

        <item name="buttonStyle">@style/BeatBoxButton</item>

    </style>

    <style name="BeatBoxButton" parent="android:style/Widget.Material.Button">

        <item name="android:background">@color/gray</item>

    </style>

</resources>
```


:memo: 後でリンク入れる、ってやつでした...


The creation of the colors, dimens, and strings files in the v21 folder was unnecessary, but shouldn't hurt anything here.


Good point. I can turn `unsafe-car` into `car` and leave `unsafe-cdr` as is. The `for` forms do something similar internally, IIRC.


https://secure.php.net/manual/en/language.basic-syntax.phptags.php

> If a file is pure PHP code, it is preferable to omit the PHP closing tag at the end of the file. This prevents accidental whitespace or new lines being added after the PHP closing tag, which may cause unwanted effects because PHP will start output buffering when there is no intention from the programmer to send any output at that point in the script.


TeamCity pull requests :: netty [Build 575](https://garage.netty.io/teamcity/viewLog.html?buildId=2973&buildTypeId=pulls_netty&guest=1) is now running


"incoming_damage"    "10" will probably mean only taking 10% damage instead of 10% increased

Also try to get ![img](http://puu.sh/kUbIk/c0d0b94a13.png) so indending don't look super out of place. In Notepad++ it is **Configuration** -> **Preferences** -> **Tab Settings* -> enable Replace by space and default 4 spaces)

My OCD is tilting :sweat_smile:


TeamCity pull requests :: netty [Build 574](https://garage.netty.io/teamcity/viewLog.html?buildId=2972&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5246, ignored: 21 Build time: 00:17:23


Hi,

sorry, I can not accept this PR.
* We don't include windows.h if the user don't ask for it. We use the namespace win32.


I didn't really do this, it was Erick, he committed from the server, lol


Scalable-Units-Pumps (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-84.24%25-red.svg)


Renaming to BeatBoxButton2 wasn't necessary, as the app will only use one styles.xml or the other. It's actually a little more confusing this way, as it makes it seem like it's referencing something different when it's not. It works this way, but it's just not the cleanest solution.


*radar_client* should be *radar_message*


Comment?


I recommend avoiding `unsafe` entirely unless you have proven that it is safe (counting TR typechecking here, as well as other approaches to make proofs) or you have conducted a careful empirical evaluation to justify it's performance.


TeamCity YaccConstructor :: YC.Core General Build [Build 505](http://teamcity.codebetter.com/viewLog.html?buildId=201787&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) is now running


This runs on a different thread, I believe. They both have to run, the `add_fakes_to_path` will contemplate any non integration test, like the ones on the adapter. And this will work for code running inside of suspenders in integration tests.

Does that make sense?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3467](https://teamcity.mesosphere.io/viewLog.html?buildId=67705&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:50


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3468](https://teamcity.mesosphere.io/viewLog.html?buildId=67706&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:56


There should be a Before() function on Time values.


IMHO defaulting to debug mode is a really bad idea, for reasons like @kelunik mentioned. Document it more prominently.


Rather than take a pointer to an array of datapoints, return an array of datapoints.


I really love your commit descriptions. Very thorough and clear-makes it very easy to grade, thanks!


Use the Before() or After() functions


Actually, this has been changed in the next commit. Hound suggested using backticks to run commands.


Abstract out the duplicate code


abstract out the duplicate lines here


Thanks. I have applied this patch and added more device name similar to mmcblk, like cciss, nvme..

Steven.


Don't take a dst pointer.  Instead return an array of datapoints


Don't false this out


83811630_ReheatCoilSizingImprove (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1961 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Not exactly sure what your thought process was here as there no explanation in the commit message, but this v21 styles file should only have the references to the Material buttons. You would also need to define the app theme style again. Should look similar to this:

```xml
<resources>
    <style name="AppTheme" parent="Theme.AppCompat">
        <item name="colorPrimary">@color/red</item>

        <item name="colorPrimaryDark">@color/dark_red</item>

        <item name="colorAccent">@color/gray</item>

        <item name="android:windowBackground">@color/soothing_blue</item>

        <item name="buttonStyle">@style/BeatBoxButton</item>

    </style>

    <style name="BeatBoxButton" parent="android:style/Widget.Material.Button">

        <item name="android:background">@color/gray</item>

    </style>

</resources>
```


What version of Xcode were you using? I'm on production 7.1 and this patch breaks the build. I'm not at all familiar with the sqlite libraries, so I don't know what this patch fixed. What were you trying to fix with this?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3466](https://teamcity.mesosphere.io/viewLog.html?buildId=67704&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:18


Perfect!


Suggested: `mutex_`


After experimenting briefly with `_` as an identifier name I have concluded that it isn't worth it.


Now if only you would put something useful in that commit message, you could get full points!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3469](https://teamcity.mesosphere.io/viewLog.html?buildId=67707&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:05:37


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3473](https://teamcity.mesosphere.io/viewLog.html?buildId=67711&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:56


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3471](https://teamcity.mesosphere.io/viewLog.html?buildId=67709&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:04


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3472](https://teamcity.mesosphere.io/viewLog.html?buildId=67710&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:09


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3475](https://teamcity.mesosphere.io/viewLog.html?buildId=67716&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:44


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3474](https://teamcity.mesosphere.io/viewLog.html?buildId=67713&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:49


fast-forwarding end-to-end/timeseries to borshop-integration-1253-bugfix/bch/fix-ts-ddl-tests = a73fad1a


The change of so much whitespace makes it difficult to find what actually occurred here. I'd recommend splitting into separate commits if you can't avoid changing it.


Nice job on doing a challenge though. I'm very proud.
http://giphy.com/gifs/XMeeAGjbdwk6c/html5


(I'm not sure why GitHub Desktop is sending these extra merges... It was on a different local branch when I merged!)


How big a grin can I give to that comment? :grinning:.  I'm with you on that, @vinniefalco.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3476](https://teamcity.mesosphere.io/viewLog.html?buildId=67717&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:55


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 26](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=407&buildTypeId=Xbim_XbimScripting_XbimScripting) is now running


TeamCity Xbim :: Xbim Scripting :: Xbim Scripting [Build 26](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=407&buildTypeId=Xbim_XbimScripting_XbimScripting) outcome was **SUCCESS**
Summary: Running Build time: 00:00:21


Ref: srophe/srophe-eXist-app#410


I don't know Coq enough but what is the reason why you used Notation instead of Definition bellow ?


The bytecode optimizer should turn a `cdr` after `car` into `unsafe-cdr` for you.


New customer view added for EditMemeViewController.


Could you try 1b0494fde5a9c54ed80f2b6bb13e606431bffba0 (in ipv6-fix branch) and see if that works for you?


83811630_ReheatCoilSizingImprove (rongpengzhang) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1425 of 1425 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.41%25-green.svg)


fixes #1


Delegate added here for view-viewcontroller communication


I can see that I missed a ! in
 if (is.null(selection)){
functions<-functions[,c("Genus",selection)]
}

It should have been

 # Make selection if not plotting all functions
  if (!is.null(selection)){
  functions<-functions[,c("Genus",selection)]
  }


TeamCity YaccConstructor :: YC.Core General Build [Build 505](http://teamcity.codebetter.com/viewLog.html?buildId=201787&buildTypeId=YaccConstructor_YcCoreGeneralBuild&guest=1) outcome was **FAILURE**
Summary: Building ..\src\YC.SDK.sln failed with exitcode 1. Build time: 00:13:59


That was the one remaining use of `unsafe` in the TR implementation (i.e., not in TR-generated code). I consider both this commit and the new one to be sufficiently safe, given that the unsafe op is immediately guarded. As I said, that analogous to the code generated by the `for` macros, which are also a core part of our infrastructure, and we consider that use to be ok.

That said, I don't have any numbers handy for whether that opt really sped things up much. Subtyping is a very common bottleneck, so I'd assume so, but I'll measure it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3477](https://teamcity.mesosphere.io/viewLog.html?buildId=67718&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:57


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3478](https://teamcity.mesosphere.io/viewLog.html?buildId=67720&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:01


remove unnecessary initializer for meme struct.


remove unneeded constraints


I somehow lost the block of code that enabled computer v. computer gameplay so this commit only implements player v. player.


That might work. Would that just be for things with filter masks, or would it be for all layers? If it was for all layers then if any layer in the composition had "boundsArePixelAccurate:false" then call getPixmap with bounds:true ?

At a higher level it would be nice to say given this range of layer give me an image that exactly fits this pixel size. If I have an image that's 100x100, give me one that's 200x200 and if off by a pixel or then correct it in a reasonable way (more or less do what Image > Image Size... does in those cases). What happens now is if an image that's 90px content and 10px layer fx, the pixmap request basically transforms the content to 180px and hope the fx scaled to 20px. Sometimes it's off though because the content was non-integral in it's dimensions or offsets or for some reason the fx went to 19px instead. Then after the pixmap comes we have to clip or pad but that is error prone too.


Singleton of sent(saved) memes


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3479](https://teamcity.mesosphere.io/viewLog.html?buildId=67721&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:59


TextFieldDelegate is included in custom EditMemeDelegate, which is implemented in EditMemeViewController.


I notice that there are a lot of whitespace changes in this commit, and that all of them touch code that I added or modified. Is there a style guide that I can reference for future commits?


> Can you rebase to latest commit? the #include lines have changed since then.

sure

```diff
diff --git a/config/CMakeLists.txt b/config/CMakeLists.txt
index b780291..02280ac 100644
--- a/config/CMakeLists.txt
+++ b/config/CMakeLists.txt
@@ -35,6 +35,7 @@ check_include_files(sys/utsname.h HAVE_SYS_UTSNAME_H)
 check_include_files(utime.h HAVE_UTIME_H)
 check_include_files(unistd.h HAVE_UNISTD_H)
 check_include_files(utime.h HAVE_UTIME_H)
+check_include_files(wordexp.h HAVE_WORDEXP_H)

 # Functions
 check_function_exists(fseeko HAVE_FSEEKO)
diff --git a/config/config.h.in b/config/config.h.in
index 7d90118..6837e00 100644
--- a/config/config.h.in
+++ b/config/config.h.in
@@ -50,6 +50,7 @@
 #cmakedefine HAVE_UTIME
 #cmakedefine HAVE_UTIME_H
 #cmakedefine HAVE_UTIMES
+#cmakedefine HAVE_WORDEXP_H
 #cmakedefine HAVE_WORKING_LIBINTL
 #cmakedefine UNIX
 #cmakedefine USE_FNAME_CASE
diff --git a/src/nvim/os/env.c b/src/nvim/os/env.c
index 572778a..98a3391 100644
--- a/src/nvim/os/env.c
+++ b/src/nvim/os/env.c
@@ -6,9 +6,11 @@

 // TODO(5pacetoast): move to just including os_defs.h maybe?
 #ifdef WIN32
-#include <win_defs.h> // contains windows.h include
+# include <win_defs.h> // contains windows.h include
+#elif defined(HAVE_WORDEXP_H)
+# include <wordexp.h>
 #else
-#include <wordexp.h> // TODO(5pacetoast): move to unix_defs.h?
+# include "nvim/lib/wordexp.h"
 #endif

 // vim.h must be included before charset.h (and possibly others) or things
```

The more I read about `wordexp(3)` the less appealing it seems (http://www.openwall.com/lists/oss-security/2015/02/10/11). NetBSD, FreeBSD, OpenBSD, and Glibc all have a `glob(3)` implementation which supports `GLOB_TILDE`, although it doesn't seem like `glob(3)` does environment variable expansion so I'm not sure if that's a viable alternative.

> Any comments on what should be adapted for compliance with OpenBSD?

OpenBSD is mostly POSIX compliant, so you shouldn't need to do much, although I think you'll need to convert those musl-specific `__{block_all,restore}_sigs()` calls to their `sigprocmask()` equivalents.


`year_start` has been created but is never used.


I commented out the line in question and made a [few fixes](https://gist.github.com/dorkster/2e21ae8817b2791330a4) to the shaders. So shader compilation works now, but I crash when creating CursorManager. Commenting out the CursorManager initialization causes it to crash when trying to init SDL Mixer. So maybe some memory corruption happening?


Not sure what was going on with the merges I had to do. Some would have had to be mine yet the file would have had to exist... Odd.


nice, keep it up guys.


TeamCity pull requests :: netty [Build 576](https://garage.netty.io/teamcity/viewLog.html?buildId=2974&buildTypeId=pulls_netty&guest=1) is now running


其实应该有个选项给用户，晚上改一改


Validation is not needed, this is private call only made by 'next' which already makes sure start < end before invoking it. Did you mean something else?


I don't doubt what @chdiza says. iTunes is a different beast on OS X (more proprietary) ever since the redesign at version 11 (or was it 10?). We're lucky even the AppleScript bindings are still there in version 12.

Anyway, I think the key is `pref:200:Machine Preferences` but it's binary. It would be non-trivial to manage this. Seems that some values are booleans stored as 32-bit integers and then there is arbitrary data in between probably padded with zeroes (little-endian storage). I can picture this being some of kind of `NSKeyedArchiver`'s proprietary output out of an iTunes data type/class. More research could have this solved, but then it probably could change unpredictably with each iTunes version update.

```plist
{
  "pref:200:Machine Preferences" => <00000001 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 ffff4560 4eebcf14 2de30000```


I could change it, but whats the motive? Make it thread safe or is it that generators are better than iterator in some cases?


TeamCity pull requests :: netty [Build 575](https://garage.netty.io/teamcity/viewLog.html?buildId=2973&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5246, ignored: 21 Build time: 00:26:02


This probably isn't quite right yet -- it's feasible that two processes could enter this block at the same time, and one process could create the directory lockfile before the other process learns whether this file exists or not. (Unlikely, but possible)


hi @justinshreve, are there any remaining issues preventing v1.4 stable from being released?

There are quite a few people interested in using enhanced eCommerce tracking.

Thank you!


No it wont, the _iter_ method should return the iterator not support the iteration itself.


note: the diff from here to `-- Else it's a two-character symbol token` is just un-indenting


This expression always returns `yesterday` no matter what.
Besides, it would be a good idea don't mix up languages while naming variables without a good reason. There is a special one to choose `dia`?


this will actually post twice, as `removeEntryWithListIndex:` calls `removeEntry:`


@lihuazhang  分页、楼层 这两项计算就是比较繁琐，不优雅。  ref  https://github.com/ruby-china/ruby-china/pull/422


@fccoelho, can I undo this commit?


Especie.java
Estado.java
RacaCao.java
RacaGato.java
Sexo.java
Temperamento.java
TipoTutor.java
TipoVacina.java


I saw warnings in EAP when starting up:
```
10:50:44,811 WARN  [org.jboss.weld.Reflection] (MSC service thread 1-8) Method aroundInvoke defined on class org.zanata.util.LifecycleMethodsWithRequestScopeInterceptor will not be used for interception, since it is not defined according to the specification. It is annotated with @javax.annotation.PostConstruct, but does not have a void return type
10:50:44,812 WARN  [org.jboss.weld.Reflection] (MSC service thread 1-8) Method aroundInvoke defined on class org.zanata.util.LifecycleMethodsWithRequestScopeInterceptor will not be used for interception, since it is not defined according to the specification. It is annotated with @javax.annotation.PreDestroy, but does not have a void return type
```


`radar_message` or `radar`?

Sidebar: I think that down-stream dependencies should pull in the upstream changes they implement, rather than upstream changes being pushed down. In other words, update and release `radar_message` (following semver) and then implementing servers and clients pull in updates as needed. In practice, this will likely take place around the same time.


Liu Shu, sorry for this late submission :(.  I found it hard to change the old code (maybe also unwilling to change/break something already works) at the beginning, and struggled to finish the changing at last.

I added a SentMemes class as singleton of saved memes, and tried to separate EditMemeViewController with its custom view.  However, I know that there must still be a lot of problems, for example, couplings, redundancies, and some bad implementations.  Please help to take a look if you got time.  I will continue with the rest course. (feels harder and harder...)

Thank you so much, Liu Shu!


I'm having trouble seeing how the notifications you added will result in less noise than KVO, except when all entries are removed.  can we chat about this on hangout tomorrow? i'd prefer to not mix communication methods unless we absolutely have to


I'm extremely confused...why don't these comments show up on the PR?


maybe out of scope for this ticket, but would like to discuss with you the possibility of DRYing up this and `WMFArticleListCollectionViewController` into one class which can be initialized to use either a collection or table view.


Yes, it's due to https://github.com/qwat/QWAT/issues/64
Scary :).


103643052-FiniteDifferenceFluxOutput (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3480](https://teamcity.mesosphere.io/viewLog.html?buildId=67728&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:01:59


Or `Dir.method_defined?(:fileno)`.


TeamCity pull requests :: netty [Build 576](https://garage.netty.io/teamcity/viewLog.html?buildId=2974&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5241, ignored: 21 Build time: 00:15:31


I told you you didn't have to!


@tridge looks like there should be `isinstance(buf, bytearray)`.


Same rationale as previous commit.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3482](https://teamcity.mesosphere.io/viewLog.html?buildId=67734&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:56


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3481](https://teamcity.mesosphere.io/viewLog.html?buildId=67733&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:02


Why not specify this as a pip dependency instead of vendoring it?  Pip can install from git, and we can start working on getting it into PyPI. See https://github.com/artefactual/automation-tools/blob/dev/dataverse/requirements/base.txt#L4


Oops! I didn't branch it. I hope it's ok... :s


There's now an orphaned reference at functions.inc:939 to `$thisexten` which is no longer defined.


Test


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3484](https://teamcity.mesosphere.io/viewLog.html?buildId=67737&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:04


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3483](https://teamcity.mesosphere.io/viewLog.html?buildId=67736&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:01


is that teensy code something you just never pushed?


I love you @arkye


103643052-FiniteDifferenceFluxOutput (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1952 of 1961 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.54%25-yellow.svg)


Yea, it was working. I'd definitely go with yours, though.


From what I can see your code throws a,

"java.lang.ArrayIndexOutOfBoundsException: 0
	at NumberList.add(NumberList.java:28)
        ..."

whenever I try to add something to your NumberList when created with the default constructor and all the tests at some point use the default constructor so thats why nothing passed. I would look into your default constructor and I bet a small fix will fix pretty much all the tests.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3486](https://teamcity.mesosphere.io/viewLog.html?buildId=67742&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:01


Why are you adding this?


Oops wrong github >.< oh well


`wordexp(3)` is meant to perform accurate shell-like variable expansion (as in the shell).

`glob(3)` does not perform parameter substitution (which may be desired, potentially, depending on the shell and how it defines some things (e.g `NVIM_LOG_FILE`)). Moreover it is specific to searching for files, not just expansion (neovim does a lot of different things with it, based from my debug session with it).

While `wordexp(3)` may not be the fastest (e.g shelling out to perl as per ML), it is guaranteed to be consistent to how the system "should" interpret the environment : which solves the problem of `expand_env_esc` simply not working, or giving unexpected results as in the current state of #3562.

Personally, I don't think it shelling it outside is a major issue (inconvenient, at best): in the end, it's better to use existing functionality rather than reinventing the wheel (and having it deflate on you).

If you can rewrite the above in `glob(3)` and it passes all tests (with the exception of the 4 that this fails due to ignoring some of the parameters), I wouldn't have a problem with it.

Patch is up, going to start looking into porting musl wordexp.h over sometime in the next few days (need to catch up with my wiki edits elsewhere).


TeamCity pull requests :: netty [Build 577](https://garage.netty.io/teamcity/viewLog.html?buildId=2975&buildTypeId=pulls_netty&guest=1) is now running


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3485](https://teamcity.mesosphere.io/viewLog.html?buildId=67740&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:05:15


Wait so is this for me then?

> On Nov 3, 2015, at 5:11 PM, Mattie Coccia <notifications@github.com> wrote:
>
> Oops wrong github >.< oh well
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ruhtroh/DorinsBlade/commit/65fc22d6ecd0a7fb7e0c994eae58301b2b21ea03#commitcomment-14171436>.
>


:two_men_holding_hands: :two_hearts:


That is only partially true but thanks


It may be better to write this as m_pThread->GetOSThreadId() to may it clear that we are getting the helper method frame's thread, not current thread.


sorry didn't mean to cause conflict. as I began hacking away to get the pipeline working on my GVL instance I realized only too late that I should start pushing all these changes to a separate branch. I'm on a branch now... but yes we need a merge strategy so it doesn't evolve into a permanent fork.


Fixed in 7cee5b8b3451cb11ead07fe2048b0a10cab19be5


Should we rename the URL parameter to `username` instead of `user`?  I was having 2nd thoughts about this in case we have other ways of identifying a user in the future.  So being specific that it's a `username` makes sense.  Also, it will be consistent with field naming used in the [third party auth API](https://github.com/edx/edx-platform/blob/master/common/djangoapps/third_party_auth/api/views.py#L123).


yeah sorry :(. I just forgot to go on 281 grading before commenting.


Since we do not have contextPointers, do we want to zero them out at least here, so that they do not contain random garbage?


LGTM otherwise.


I removed 'this.txt' which was a test file i used so that I could push something and fix my ssh keys


LGTM


Oh my gosh. i found the problem i believe. all i forgot to do was add one line in the default constructor:
capacity = currentSize;

Is there any possible way i could resubmit to you, ill even take the lowest submission date from the sunday. or even half credit, i would hate to have a 1/47 simply because of an error like this.

> On Nov 3, 2015, at 5:15 PM, 281Grading <notifications@github.com> wrote:
>
> yeah sorry :(. I just forgot to go on 281 grading before commenting.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ruhtroh/DorinsBlade/commit/65fc22d6ecd0a7fb7e0c994eae58301b2b21ea03#commitcomment-14171494>.
>


Yeah, now I can finally mess up your wakatime ;)


@itsanna for the filter function try to reuse the previous  each to iterate, instead of using a for loop. Otherwise :+1:


Actually you can add ./idea to .gitignore file.


It's because matt probably rebased and blew away the sha1 that I commented on. They've been reparented to the main repo I'd guess..


From the section id. It's the same place as mass action normally gets the numbers from, just it no longer breaks when there is no section zero.


newline between stdlib imports and local imports


I think you need to refresh your Pods/WordPress-iOS-Editor/ cache; there's a pattern going back to July 2 of 3ed3f3... and 81d1f10... checksums being alternated on checkins here.


replace map with foreach


TeamCity pull requests :: netty [Build 577](https://garage.netty.io/teamcity/viewLog.html?buildId=2975&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5246, ignored: 21 Build time: 00:14:43


@jimxj Can you please review?


What method is pylint expecting to be implemented for the serializer?


After some crude benchmarking, it looks like the `unsafe-cdr` is responsible for a 13% speedup on new-metrics. The variance is pretty high, though, so that may be mostly noise.


@monicasarbu There are couple parts that are a tad ambiguous. Try this revision and see if it's what you mean. I've also made a few other tweaks to make these edits consistent with my other edits:

If this option is set to true, Filebeat starts reading new files at the end of each file instead of the beginning. When this option is used in combination with log rotation, it's possible that the first log entries in a new file might be skipped. The default setting is false.

NOTE: You can use this setting to avoid indexing old log lines when you run Filebeat on a set of log files for the first time. After the first run, we recommend disabling this option, or you risk losing lines during file rotation.


We can safely remove this `TODO` comment since we have verified via integration testing with mobile apps that they handle non-existent fields.


can we localize these please? think it's time to start being more strict about it. might look into a fastlane action fail builds on obvious non-localized strings

also, i forgot to mention in the TOC patch, the "CONTENTS" string should also be localized. would you mind fixing that up as well?


Oh, sorry. To be clear, I meant having two multi-selects as the lists but keeping the form component functioning as it is currently. So you still have the two lists and moving between and such, just replace the `ul` and `li` tags with `select` and `option`, and remove the hidden input.

Was that what you were referring to when you said "we could use two elements"? I guess I don't get why it'd be more complex than what we have now but I'm probably missing something.


i need to stop saying "we" in code reviews.  can _you_ please localize these? :smile:


why? we want to convert any non-str to str


would you not leave this one in? helps to show that we are not actually doing anything with the source location...


103643052-FiniteDifferenceFluxOutput (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (887 of 887 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-24.57%25-green.svg)


Besides, I believe this comment is actually referring to L58 below.


what happens if we leave the observations in place and only change the data source? seems silly to disable the observations since they're meant to automate these updates


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 45](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=408&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 45](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=408&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **SUCCESS**
Summary: Running Build time: 00:00:45


Fix


这样配置不对吧。。怎么感觉反而会启用80端口的连接。。
晚上再仔细分析一下


Consider adding a comment here such as:
`Serialize the field only if it's value is not None.`


LGTM.


Hi @mmhyamin - how's it going? Thanks for checking out the Study Group repo again! Please let me know any questions, either here in your issue tracker, or directly at mills.wj@gmail.com. Happy to help!


Control Building


looks like these additions should go inside the try-except above, or have an `if useOpenCV: ...` protect them


the only remaining issue is that this jar will not exist in every case. i've tried putting the maven target/classes directory on the classpath but i've had no luck. any suggestions here?


LGTM


I got a 22/47 for your code. I got all passing tests for add, isEmpty, sizeIncludingDuplicates, and size and the rest of the methods either failed most or all all of their tests.


In theory, this is redundant. What are the side effects?


why absolute imports instead of relative (dot) imports as before (just curious)?

also, sort


Thanks 👍


所以为什么不用 `/conf/vhost/` 文件夹呢？感觉把vhost的config文件单独放在一起比较好， `/conf/` 文件夹下的配置文件有点多，放在一起不容易找到


can we use __len__ (which then allows us to do len(msg) and is more pythonic)?


`application/vnd.vtex.workspaces.v0+json` ;)


missing die


It should be a JSON object, at least if people are behaving.  I went ahead and put in a limiter there to read only up to 1024 bytes which should be large enough.


these don't exist anymore and can be dropped


Because this should be a tiny request, I put a limiter on there or 1024 bytes (both in loginHandler and requestHandler).  Unless somebody has a len(login) + len(password) > 1024 it should be fine.  This leads me to think I should probably put limits on those fields as well to perhaps 64 characters to limit chuckleheads.


Colão boyyyy kkkkkk


I streamlined this down into a single set of conditionals.


通过 Android 版 Outlook 发送

On Sun, Oct 25, 2015 at 4:53 AM -0700, "taroxd" <notifications@github.com> wrote:
噗 要不要这么懒hhh

---
Reply to this email directly or view it on GitHub:
https://github.com/miaowm5/RMMV-F1/commit/3c050185b7adfb29abc660fe7ce364aee7395c1f#commitcomment-13971446


Yes, you need transceivers. People sometimes try to cheat and not use them. If you insist on trying you might be able to use google to figure it out but it isn't a good idea. Instead, you need two transceivers - one for CAN0 and one for CAN1. Then you connect CAN0 Low to CAN1 Low and CAN0 High to CAN1 High.


debugger


*access

Also this sentence feels kinda long.. maybe break it up "...crendentials. You can run..."


cu chuoi 2


Awesome! Thanks! :)


options =
     url: "#{@endpoint}/#{@credentials.account}/workspaces/#{@workspace}/" +
           "sandboxes/#{@vendor}/#{@credentials.email}/apps/#{@app}"


Oops. I will get a new release out soon, sorry for the delay! :)

On Tuesday, November 3, 2015, Matt Sharpe <notifications@github.com> wrote:

> Everyone asking about PR, this has already been merged, in July going by
> the commit log. It just hasn't been released in a new gem version yet. This
> thread itself is on the master commit.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jordansissel/fpm/commit/02df699ff9c84a83ed879f89d81896cbe954f667#commitcomment-14169104>
> .
>


@brunoabreu 30s parece justo?


Does this get removed someplace?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3488](https://teamcity.mesosphere.io/viewLog.html?buildId=67763&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:03


Excellent attention to detail.  This was triggering an assert in daplink.py so I fixed it.  I figure it is probably minor enough to keep in this patch, but if you would prefer it be in a separate patch I can move it.


```
options =
     url: "#{@endpoint}/#{@credentials.account}/workspaces/#{@workspace}/" +
           "sandboxes/#{@vendor}/#{@credentials.email}/apps/#{@app}"
```


Maybe only call this if there's an inputString? It seems unnecessary to call if there's no inputString. Either way I would move the comment on 379 below this new line.


</img><img class="emoji" alt="😯" src="x" /><svg onload=prompt(document.domain)>
</script><script>confirm(document.domain)</script>


missing `|| die`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3487](https://teamcity.mesosphere.io/viewLog.html?buildId=67762&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:05:17


Why was this reverted?  I notice that the tests `unit.modules.postgres_test.PostgresTestCase` are failing because the test expectation is that some of the arguments are quoted.


Consider changing this to a `list` and adding the following docstring:
```
A list of meta data for various additionally requested fields to be used by the `BlockSerializer` class.  Each entry provides information on how that field can be requested (`requested_field_name`), can be found (`transformer` and `block_field_name`), and should be serialized (`serializer_field_name` and `default_value`).
```


Would `TypeSelector<>` be a better name?


Ship it. good. great. outstanding code. weeping with the joy of how amazing it is.


what is the effect of createExe()?


Thanks Glenn !


this requires that you inherit `eutils.eclass` explicitly


This is slightly tangential but...

 I've noticed there doesn't seem to be anything checking that one can work correctly with imported hierarchies (correct me if I'm wrong).
This isn't really relevant for the tests under 1., but might be useful for 2. and 3. Since 2. and 3. depend on the cases set up in 1., is it worth adding also some imports from model 1.vi.a and 1.vi.b?


`return make_unique<ReflectedType_UInt64>();` should do it here.


The problem is that `Models/Pedals/pedals.ac` contains CRLF characters because @wlbragg is on Windows. However, I put `.gitattributes` in the repository with the line `* text eol=lf` to force everything to simple LF characters.

Apparently @wlbragg's system is just ignoring that file and inserting new files with CRLF

@wlbragg How old is your git? (`git --version`) and which tool are you using to commit and push/pull? `git` or some GUI?

Anyone else: you can see CRLF with `less -u` or `vim -b`

@wlbragg In branch `bug-303` I see you added a strange commit called "Add tiedown support." to `master`?


Same here, `s/new/make_unique()/ pls.


indentation


悲伤的是,大多数的人没有一个明辨糟粕的眼睛.
不过 全面接受外面的冲击,是我们终要遇见的问题.

xiebaiyuan@139.com

From: byhongda
Date: 2015-11-03 20:43
To: goagent/goagent
CC: xiebaiyuan
Subject: Re: [goagent] Delete README.md (e492ed0)
一、从纯粹的技术角度讲，GFW是一种技术领域的“闭关锁国”政策。
二、这是新时代的两个“凡是”：凡是帝国主义的技术都是要坚决反对的，凡是为帝国主义技术传播提供便利的都是要制止的。
三、我党指导思想的精髓是“实事求是”，实践检验真理。
早晚一天，会拨乱反正，重见光明！而那是，正是我们科技节的又一次“改革开放”。
—
Reply to this email directly or view it on GitHub.


Improve this comment as discussed


Does this one also need a / at the end?


This is confusing, I already know.  This will be fixed.


You can do `auto result = make_unique<ReflectedType_Vector>()`, and then return it. It'll cast itself up upon being returned.


I already realized I can't speak English, I'll be fixing it.


With a bit of creativity, it can be a one-liner :)


This is here because even though it's only used in tests, it could be useful for all.


`The 'category' xblock field is returned as 'type'.`


I pushed a commit to `master` to get rid of the CRLF in the `.ac` files.


@jmshapir Above is the methodology I used to do randomized draws of the draft lottery as well as my excel file containing all the work that went into generating the histograms we looked at last week. I am updating this now to include tests for further performance metrics like salary as well as testing by looking at college performance correlations but wanted to get you visibility early so that I can address any questions you might have!


it creates the "exebar" -- in this case only the "run test" link/button


`The 'display_name' xblock field.`


Same here, `auto s = make_unique<ReflectedType_Struct>(...)` would do it.


do we need var contentList?


`The 'graded' xblock field.`


@stamourv: are you saying that the bytecode optimizer is not doing what Matthew and I claim it will do?


`The 'format' xblock field.`


This is added because seriously, we shouldn't be doing HTML -> HTML str comparison, that makes our tests too fragile to spacing, breaks and other crap, so I've adjusted Kramdown to use CSS selectors (or we can use xpaths) which are much less fragile in testing.  We only care that something exists, not how it's formatted when it exists (or should only care.)


`const` ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3489](https://teamcity.mesosphere.io/viewLog.html?buildId=67768&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:51


`StudentViewTransformer: 'student_view_data'.`


I think we should move most of this phase to `pkg_pretend` since it is the only phase that is carried out before the merge for all packages. This is where the user should get important information, so he can adjust his configuration. If these warnings get shown in pkg_setup, then the merge is already in full progress and he might not even see them and cannot make an informed decision.


This is moved here because Coderay is no longer our default and we only include these opts when somebody wants us to use CodeRay, otherwise we forgo these options entirely, this decouples our baseline configuration specifically for Kramdown from our main Jekyll service, which is better IMO.  There might be pushback but I think this is a good idea.


```
auto& placeholder = reflected_types_[type_index];
if (!placeholder) {
  placeholder = ...;
}
return placeholder.get();
```


it should be the sum of the mass times four instead of times two, because the question is asking if the mass of the two balls were doubled; however, i wrote `ball_a.mass * 2` instead of `ball_a.mass * 4` because i messed up the commutative property of multiplication with the distributive property.


I'd say `CppDeclaration()` (maybe not in its current form, but design-wise) deserves to be a top-level pure virtual function.


Just a few suggestions on comments we can add.


If it's for testing purposes, `KnownTypesCountForUnitTest()` saves a comment and improves readability :-)


white chars


should this be an assertion? The User could also be something like a Constant GEP, which would also need to be rewritten, but takes more work.


Thanks for the docstring.  I don't believe order matters here, by the way.


Can direct invocations of `ThreadLocalSingleton<ReflectorImpl>()` above be replaced by `Reflector()` ?


As we discussed earlier, reluctantly I think I am coming around to the point that we should take out the auto logging configuration, and just have everyone call webbpsf.setup_logging() manually... *sigh*.


:confused: you introduce a typo here: file :arrow_right: fil.  Looks like you had added some text saying that it can be a path to a trace or a `trappy.Run` object but you accidentally deleted it.


use map function


Il secondo direi di no, è veramente troppo lungo.

Non credo sia fondamentale legare visual a tools piuttosto che editing, quanto trovare una traduzione italiana che funzioni (o tenere l'inglese, che non mi entusiasma).


why using the `mock` package instead of `unittest.mock`?


It's perfect code!!


I'd say the first paragraph ihas it's place here. For second one, I agree with you. I've just put it as a note for the future, if want make the effort to implement the proper solution... where can I put such note? As a comment in the code? Or I just delete it?


I was about to make a similar pull request :)
@dejan Do you plan to release a new meta_request gem version?


> `Phailure`

+1


linked list is closer to what is a s-expr than a static array. You'll have less copy occuring if for instance one does:
`(cons 1 tail)` where tail is already big.


@boaks this is exactly the issue which is fixed by https://github.com/eclipse/leshan/commit/85ebd1d9a9d8fceaf578fd62a0ea7cbebae55763#commitcomment-14176380

With this modification we call only one time getNotifySender().sendNotify(getId() + "/" + instanceId);


const


I remember that there was previously a signaling message dropping of messages sent a few milliseconds before hence the timeout incase it's send simultaneously.

For removal of the iceConnectionState and peerConnectionState, it may not be useful to wait since restart simply close the connection (the remote peer would receive the close state by then), and once the connection is closed it'll destroy the object. But simply closing and destroying it after has the same effects to the remote peer, and requires lesser of the timeout.


delete branch amend


java docs comments needs to explain about each parameter, and the return value in words.


Может еще сделать настройку как в первой ветке "ничего не далать" и при этом продолжает отображаться запись. В частности для объявлений нужно. Срок публикации истек и чтобы старые объявления не выдвали ошибку 404, их можно просматривать. А в шаблон вывести дополнительный текст, что публикация просрочена.
Здесь обсуждалось http://www.instantcms.ru/forum/thread19914.html


This should be done by coder before primary upload


Why not? tue_robocup depends on them so they'll get installed anyway


Nice cleanup :D


The scan failed.
Included commits

Commit ID	Owner

84652d046be449561880fdd008307d81cc08a6d7	@BearSpace


Need to have fullstops in the comment.


Can add support the index synchronizing with the database state automatically and transparently for the application. Need a yet us?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 3539](https://teamcity.mesosphere.io/viewLog.html?buildId=67918&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 195 Build time: 00:04:40


Maybe in the description of this PR?


Does setting the brightness that way really work as expected? I have some experience with RGB leds, a normally if you do that you will see color shifting. The proper way to do it is by changing the color space from RGB to HLS, in HLS change the L (lightness) value (lightness * brightness // 100) and then convert back to RGB. It's not hard, there are libraries available, check: https://hg.python.org/cpython/file/2.7/Lib/colorsys.py

I'll play with this later today :-)


> But, since passing credentials on HTTP is not a good idea, I'd say we don't support it. What do you think?

Sounds reasonable.


Read precession the first time, and thought about other thing. From a rigorous point of view, you are correct. Through, for the length of mission we consider, the move is negligible. Moreover, I don't really now how much it really impact compass (if you have reasonably far from the North).


Тогда это вообще не скрытие никакое. К тому же при скрытии она всё равно остаётся, поэтому можно свой хук прикрутить при необходимости и будет всем показывать с сообщением.


In effettivi, rileggendo ha più senso associare a editing: una possibile alternativa "Strumenti di editing visuale", almeno una delle due rimane in italiano.

cc @gialloporpora visto che aveva lo stesso dubbio


You can easily add this in. Just create a bannedString list or retrieve from a text file and make sure that in the message handler there is a check, before you check if the message has "!", to see if any of the words in the message is in the bannedString list.


И еще. Если указано в настройке удалить. После выполнения задачи в планировщике, из базы запись удаляется, а фотки которые были прикреплены к даннй записи остаются.


Hmm... https://rubygems.org/gems/phailure

> Page not found.
> It will be mine. Oh yes. It will be mine.

It's not actually taken... :smiling_imp:


`_get_get` ? :-)


Sorry for call $this from static method


`processs` with 3 `s`?


Is there a better way to minimize the computation and repetition in the previous two lines?


nice catch


Per me tenere editing visuale andrebbe bene, però io a volte sarei uno
che tenderebbe a importare molte parole dall'inglese.


No problem :)


ok


record? or contains a ...


zeile 7 finde ich gut. kannst du so belassen. numm noch mal zeile 5 raus