nice testcase :)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8761](https://teamcity.mesosphere.io/viewLog.html?buildId=89012&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:10:49


the comments of python files should start with '#'.
I cannot run the program now..


This can be simplified using `spyOn`. See https://github.com/angular/angular.js/blob/master/test/jqLiteSpec.js#L1168


@jschueller The main problem is to wrap this method in Python order to avoid input/output arguments, but I don't know how to do it. Your help is needed!


Not if this is part of the build process. STARLINK_DIR is for runtime.


Thanks for this @UniqMartin and sorry that I forgot about @xu-cheng's comment to fix this.


Issue would be great, and you do excellent markdown  of everything.


- Về file game.cpp và game.h
   + Thêm list<CGameObject*> là m_listWorld (chứa tất cả đối tượng trong màn hình) và m_listMovable (chứa các đối tượng di chuyển;)
   + Cách xét va chạm giữa các vật
    for gameobject in m_listMovable : /*codd xử lý đối tượng ko di chuyển -> do đối tượng di chuyển làm. Vd Mario va chạm vs gạch, gạch võ -> xử lý gạch vỡ ở Mario. Còn nếu cả 2 đối tượng đều di chuyển -> xử lý riêng cho từng đối tương */
      for otherGameobject in m_listWorld :
        if gameobject == otherGameobject: continue
        collision DIr= CheckCollision(gameobject, otherGameobject) // trả về hướng va chạm ở đây.
        if collision:
          gameobject.Collide(otherGameOjbect, collisionDir)
          otherGameobject.Collide(gameObject , collisionDir)
   + Nếu goomba không va chạm vs tất cả đối tượng trong màn hình => nó đang lơ lửng giữa không trung => lúc này có gia tốc trọng trường.
   + Nếu goomba đang dứng trên nền gạch (va chạm bottom) => xuất hiện phản lực (Định luật 3 Newton) -> cộng thêm gia tốc trục y
---------------------------------------------------------------------------------------------------------
Các đối tượng đề có gia tốc trọng trường ACCELERATION_OF_GRAVITY khai báo trong Utility.h


It would be very easy to move all those js/css files from templates to kernel.
It's just about letting the possibility to template builders to handle those interface scripts and style sheet as they want.


the api didn't work again
they have change it


It's nice to see my elite Markdown skills appreciate so.

I'm converting your current roadmap into an Issue now. Or do you have anything to edit before I start?


No need to bind here. Just keep a reference to the event name and then call `progress(eventName)`.


while we have more and more cli commands, let's have some name conventions. One way is to follow the object oriented scheme, i.e., object.method. In this case, counters.list and counters.query


у нас нету конфигов!


Sometimes it did work, sometimes didn't. Bash confuses the hell outta me.


The spy data collected will track the type and the amount of calls. This way we don't have to keep track of a bunch of global variables.


Возможно использовать shared_ptr<base_object> f_obj( new first_object() )


@okms We need to either just do our own debug message, or if we're doing a pull request to original, we should use CoreResources.


Let me check if I understand what you mean, with this example:
```
class F():
    def __radd__(self, other):
        print "radding"

f = F()
print (1, 2) + f
```

CPython will fail to find `__add__` on the tuple, and fall back to calling `__radd__`. However, if we throw an exception in tuple's `__add__`, then `__radd__` is never called.

However, at this time, returning `NotImplemented` will not fall back to `__radd__` but rather hit an assertion and crash.

```
../../src/runtime/objmodel.cpp:4167: pyston::Box *pyston::callCLFunc(pyston::FunctionMetadata *, pyston::C
allRewriteArgs *, int, pyston::BoxedClosure *, pyston::BoxedGenerator *, pyston::Box *, pyston::Box *, pys
ton::Box *, pyston::Box *, pyston::Box **) [S = 1, rewritable = 0]: Assertion `chosen_cf->spec->rtn_type->
isFitBy(r->cls)' failed: pyston::tupleAdd(pyston::BoxedTuple*, pyston::Box*) (0x15a0c40) was supposed to r
eturn NormalType(tuple), but gave a NotImplementedType
```

So I think it might still be preferable to throw an exception for now? I think it's better than crashing.

Otherwise the following hack in the NumPy test can sidestep this problem for now:

```
def _is_bytes_like(obj):
    """
    Check whether obj behaves like a bytes object.
    """
    try:
        asbytes('') + obj
        # used to be: obj + asbytes('')
    except (TypeError, ValueError):
        return False
    return True
```


Change this to include two global spy values:

```js
elementOnSpy = spyOn(element, 'on');
elementOffSpy = spyOn(element, 'off');
```


guess who did that : (
;)


you moved the line above but not the `end` :smile:


We should be testing to see that they were never registered here in the first place. Change the assertion to look for:

```js
expect(spyOn).toNotHaveBeenCalled();
expect(spyOff).toNotHaveBeenCalled();
```


if you want to do that see python/src/OrthogonalUniVariatePolynomialFamily.i
OrthogonalUniVariatePolynomialFamily::getNodesAndWeights returns nodes & weights this way
but you cannot use it if the two methods are not renamed as there would be no way to distinguish these two:
```
isInside = mesh.checkPointInSimplex(point, index)
isInside, alpha = mesh.checkPointInSimplex(point, index)
```


Fantastic.


Remember to simplify this and remove the binding calls.


correct, I will send another pull request to fix that


@UniqMartin @mikemcquaid you may want to remove ```share/doc``` from ```line: 116```. I believe ```Homebrew``` did create the ```share/doc``` folder, but I may be wrong.


`TRANSITION_PROP` is always just `transition`. It's `ANIMATION` that needs the constant variable (which contains the vendor prefix).


Caching conditionId is important in single node or in distributed one.
Basically we don't want to use the RulesEngine processing just to discard data, so having a filter to previous check if a data has conditions is interesting.
In a distributed scenario is even more important, as with a partition scenario, data is propagated to the cluster nodes, but not all of them need to process it.
If not, we might have additional cycles of the runtime just for discarding data, which is more expensive than just a hit on the cache.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8762](https://teamcity.mesosphere.io/viewLog.html?buildId=89053&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:16


I've simplified it now. The problem is that features parsed by `luaotfload` are table containing also script and language, which aren't valid features, so we must remove them. Also semicolons, instead of commas, are used in `luaotfload`  and they can be used in `\SetFontOption` as well, so we must take care of it as well. I simplified it now, I hope.


Always one step ahead... 10 days ago at that! haha


Assert here to verify that the events have been added:

```js
expect(spyOn).toHaveBeenCalled();
```


@johan718 `share/doc` is not excluded for Homebrew. So it shouldn't be deleted. However, if we end up with a empty `share/doc` dir after uninstalling Homebrew, it will then be auto deleted by uninstaller.


check to see that the off event was called right after this:

```js
expect(elementOffSpy).toHaveBeenCalled();
```


@andela-gjames -- Hi George, I hope now you are okay with fixing merge conflicts?


`expect(elementOffSpy).toHaveBeenCalledOnce();`


The closing timeout also applies to animation events as well.


![screen shot 2015-12-09 at 1 01 26 am](https://cloud.githubusercontent.com/assets/2508142/11680983/db911920-9e10-11e5-9174-d333ca7b3c48.png)


Use the spy objects here.


Fat arrows are a bit of a pain in this area. In this case it's as you suggest @timoxley, though the following styles would also work:
```js
this.process.on('error',
                (code, signal) => this.emit('error', code, signal));
```
```js
this.process.on(
    'error', (code, signal) => this.emit('error', code, signal));
```
```js
this.process.on(
    'error',
    (code, signal) => this.emit('error', code, signal));
```
So breaking on the `=>` would essentially suggest breaking on the `{`. Which would mean that other rules of breaking at `{` would apply.

Sorry @JungMinu for all of this. When explaining the wrapping rules I only took into consideration the line I was examining, and not other cases such as this. It also seems that the linter doesn't understand how to treat fat arrows correctly either.


Faut mettre tout en anglais ^^


Not sure a client would be happy to receive internal followup subtypes in his channel.


+1
Sorry, old school habit, hard to change from my mind :-).
I will change it on my feedback commit.


Am I the only one who hates empty brackets going onto new lines? :)


Why do you use ```FromTicks(... .Ticks)```? ```DateTime.Subtract``` returns TimeSpan:
https://msdn.microsoft.com/en-us/library/8ysw4sby(v=vs.110).aspx


Yes, serpent is not affected. The minimum solidity version is 1.2, which is already out for several months. I will add a version check.


I think you should only send a `propertyChanged` message if `!p_is_get_operation`


No, no you're not :)


Yes, agreed!


Please review your exception handling, e.printStackTrace() is considered a bad practice.

See expetion handling hints at http://howtodoinjava.com/2013/04/04/java-exception-handling-best-practices/


gggyuj


I kinda preferred using the comma separated. I know it's not implicit, but having them grouped made them seem more like a "pipeline". Obviously, it doesn't REALLY matter, but preference I guess.


ok, 1 sec


It's just to be explicit about the `TimeSpan` and `Ticks`. In case somebody would want to change it.


Disallows.


Redolved


:+1: thanks


Add the messages into the messages properties files. Do not hardcode any user facing messages.


nul !


return


Did you mean `#define OBJDIR struct ObjDir`?


In one test the frontend element was not yet loaded at the time the click was executed leading to failing the test.


It is better to use a qualifier in the name which refers to the page / managed bean where the message is used, eg:
instead of "error", use "login.error" or "login.authenticaton.error"


Really? Unmatched parentheses...


InvokeMethod


The assessments in the mail parsing callback were not fully performed as the browser seemed to be closed before. The tests were listed as passed, even for something like expect(false).toBe(true).


return InvokeMethod


Are you sure that 1 minute session is user friendly?


I tried to migrate the db so the answer_text column is not null, default "", but I keep getting InvalidRecord, and error is actable.answer_text can't be blank. Couldn't find out which validation does this.


+1
Removing the synchronized from the method and applying on the addAll() is a good improvement.
I will apply this on the feedback.


删掉，加到.gitignore里


Watch out the message in title attribute, it is not localized.


Tried to use CppmlPrettyPrinter::indented() and group(), but the behavior was not what I expected. I read through some of the code, but in the interest of time did a simple fix to the implementation of indent, which should improve performance enough (not that I've had any issues so far).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8763](https://teamcity.mesosphere.io/viewLog.html?buildId=89063&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:13


group改掉


isResolved


Doesn't HotRod client already have operations such as getAll, putAll, putAllAsync? It this new implementation better?


建议用官方库


static variables are always initialized to zero so there is no need to explicitly zero `zr_circle_vtx`.


不是最佳实践


I did https://gist.github.com/BenMQ/f6fbc9508f352831f5ca and then most of the tests, such as `assessment_attempt_spec.rb` will fail with the above invalid record error.


why not define it outside the function?


A bit of both. Are you not happy with it?


@iankko
Req-8.7.c Seems to be much better, I will change it.


只加已经用到的lib包


是否需要括号，遵循统一的风格


out文件夹删掉


defaults at database level is not respected at model side, you'll need to implement it in the model.


This is a pure compatibility change with EAP64 + WF9/10.
The REST implementation on EAP64 throws error with isMember() and isLoadable() methods as those don't have a member.
I can try other workaround but adding those members was the easy one.
Perhaps we can add a transient to mark them as part of a computation state.


this function is long enough, just expect a list of lines like we do everywhere else!


I think this file was committed accidentally!


Try setting it to "Inline": it seems to allow short functions for inlined method definition:

```.cpp
class A {
    int thisIsShortened() {return 1;}
    int thisIsNotShortened();
};

int A::thisIsNotShortened()
{
    return 0;
}

```


This is fixed a long time ago in kNet's master but not in stable https://github.com/juj/kNet/commit/82c52da4f4508c71c4319851f76d23374e255eed


命名风格


Personally I still see 46 as 'stable' in my Play Store: https://play.google.com/store/apps/details?id=com.google.android.webview
Is this a phased rollout?


zxc


Oh I just notice the minor version number is changed.
And I am curious :D


Add all user facing messages into messages properties. Do not hardcode them.


Расширение не забудь убрать


unit tests missing


Yes it's modal window. Should I rename it to *modalWindow* ?


Extend JpaSpecificationExecutor<User> which contains this method and more usefull ones.


nit: module docstring needs to be before imports

From pylint:
```
tlslite/handshakehelpers.py (92.3%):
    1: C0111: (missing-docstring), : Missing module docstring
    8: W0105: (pointless-string-statement), : String statement has no effect
```


I basically just count upwards - 1.0.9 goes to 1.1.0. But this time it matched. ;)


Probably yes, _modal_ itself is not very verbose as for me


Correct. Good catch.
I miss in this logic that an alert generates an even as well.
So, notifying events to other nodes should be enough.


This can be automatically generated by including hibernate-jpamodelgen in the maven dependencies

http://mvnrepository.com/artifact/org.hibernate/hibernate-jpamodelgen/5.0.5.Final


I think some other gems would make it `1.0.10` if there is only bug fixes.


Migrating bootstrap from composer to npm impact install and usage. Mechanism of install is a mystery for me at the moment :)


@trevnorris @timoxley then, may I revise it to following code?
```javascript
this.process.on('error', (code, signal) =>
  this.emit('error', code, signal)
);
```
or one of suggestions by @trevnorris ?
Thanks a lot


Oops, sorry I had read your line note but not the actual change, in which you've commented out the variable, and removed the unused imports. I think I would have either commented both or removed both, but no matter.


No worries there. :smiley:

As requested: https://forge.puppetlabs.com/arioch/redis/1.2.1/readme.
I didn't realise people actually use the Forge. I'll try to keep the Forge more in sync when it comes to bugs like this.


setup_git.sh was not updated with my latest changes of the regression.
I did not tested it yet. Giuseppe is now doing the test.

--
 							Shervin

On Wed, 9 Dec 2015, pmeridian wrote:

> Date: Wed, 9 Dec 2015 08:42:25 +0100
> From: pmeridian <notifications@github.com>
> Reply-To: ECALELFS/ECALELF
>     <reply+0045c2257430c519b1a32a313d7aa02e643a77f3f83bfc7b92cf00000001127f9d6
>     192a163ce00e2d967@reply.github.com>
> To: ECALELFS/ECALELF <ECALELF@noreply.github.com>
> Cc: shervin86 <shervin@cern.ch>
> Subject: Re: [ECALELF] fix for EleNewEnergiesProducer not compiling (0a22ebe)
>
> which SCEnergyCorrectorSemiParm are you using?https://github.com/pmeridian/cmssw/blob/regression_74X/RecoEgamma/EgammaTools/interface/SCEnergyCorrectorSemiParm.h
>
> We should tell josh however to make SCEnergyCorrectorSemiParm also configurable in his branch
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/ECALELFS/ECALELF/commit/0a22ebe9f33647b3900def28182d31b4693646f9#commitcomment-14866791
>


Do not include a frontend specific package into the service layer. Create a new custom SortOrder class/enum in the service api and map the primefaces one to the new type in the managed beans


something went wrong and the IDE didn't want to commit this...


We don't use input, select or textarea here


Just for the sake of transparency: This is still needed.


Correct.
sendEvents() would be better to keep the notification logic on the send method.
I will modify it on the feedback commits.


afair php 7 on debian completely changes the directory structure, so enabling php 7 needs a lot more work..


On 9-12-2015 08:42, Yan, Zheng wrote:
> malloc.h is for mallinfo(). this change breaks compilation on linux.
> see ukernel@128c7d6
> <https://github.com/ukernel/ceph/commit/128c7d6a53bf5cfefcde81813066b92ecbd79efa>

Oke,
You are right. Strange that my testrun on CentOS7 did not reveil that,
either in
compilation of in linking.

I will update the patch.

--WjW


After [Language Grammars (macromates.com)](http://manual.macromates.com/en/language_grammars) at “Naming Conventions”.


nit: backslash unnecessary


asfds


Looks like getAll was added in ISPN 7.2 (see https://issues.jboss.org/browse/ISPN-5265). I didn't have any requirement to use batch reads, but it makes sense to add custom BulkOperations trait implementation in infinispan72 plugin if anyone needs it.


nit: there should be space between "#" and "C"


Why is there a seperate response function for multithreading? Does it have to be defined in the instance of the forward operator? Or in other words, will `fop.response` be used, if `fop.response_mt` does not exist?


Looks like the `symphonyTimeAgo`-function initially was created to only handle short timespans for temporary feedback in the message bar at the top.

If this function is now used by an extension like this - and therefore also for older entries - wouldn't it be best to extend it to handle new **and** old dates in a proper manner? Like supporting terms like _"2 days ago"_, _"a month ago"_ or _"4 years ago"_?

@nitriques - I could give this a try if you want - might be something my basic coding skills could be sufficient for.


Morning Agoston, we're using commons-ip-math in one place, during the authoritative resource data import of RIR mirror data (search for net.ripe.commons in the whois-commons module). IP*Resource is very good, but currently doesn't handle "frankenranges" properly. See #155 for more information.


should write a test before creating the extension


TeamCity LabKey :: LabkeyModules15.3 :: Git postgres 9.4 [Build 64](https://teamcity.labkey.org/viewLog.html?buildId=290484&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0 Build time: 00:02:25
### Failed tests
```
org.labkey.test.Runner.BeforeFirstTest: <no details avaliable>

```


Yes it is. It is possible if corresponding **restrict** option is set.


Remove commented out codes if you don't need it


should write clearly in plain English


Hey Seb,
For reasons yet unknown :-), I've decided to clean up the code of the SVG
logo, so here is the version i created in case you want to use it or put it
in the same google drive. It just makes more sense to me to create the
components this way and not what inkscape does.
Cheers,
Gustavo

On Tue, Dec 8, 2015 at 9:27 AM Seb <notifications@github.com> wrote:

> I converted the logo to svg long ago. This and my custom versions are in
> our public Google Drive:
>
>
> https://drive.google.com/folderview?id=0BwdiZp7qSaBhRktiNFE1Y0NNdVk&usp=sharing&tid=0BwVhnCYdaHnGWm1idWxBdi1mTEE
>
>
>
> On December 8, 2015 11:09:47 AM GMT+02:00, Gustavo Salazar <
> notifications@github.com> wrote:
> >OK so here is what I think...
> >
> >The web page looks outdated and that's independent of been BioJS 2 or
> >3. I
> >agree the BioJS3 project has been stuck for a while, but I also think
> >it is
> >related to the novelty of web components, most of us aren't very
> >familiar
> >with the technology, and although you guys have clearly contributed
> >with
> >videos and tutorials about it, there is a big gap between watching a
> >video
> >and been able to contribute to a project using that technology, or even
> >discussing designs about it.
> >
> >But I also understand Seb when he says that is easy to complain about
> >it
> >without actually contributing, so let's take action.
> >
> >My suggestion is to focus on the website for the current version,
> >Manuel
> >have mentioned the idea of a meta-component to dynamically display
> >biojs
> >components, i got a couple of ideas about it and I'm happy to work on
> >that,
> >but that's only one part of the work that needs to be done. BTW anyone
> >has
> >an SVG version of the logo???
> >
> >About BioJS 3.0 i think we can postpone this discussion to immediately
> >after the planned JavaScript course, that way most people will have a
> >better idea of the technology and hopefully we can contribute more.
> >
> >It would be also ideal if you guys who have worked on the current
> >systems
> >can present the current state of things, I consider key to understand
> >the
> >current logic of the registry(snipper, slush, workmen) to be able to
> >talk
> >about BioJS3. Maybe this can be a complement to the JavaScript course,
> >only
> >for people willing to contribute to BioJS 3??
> >
> >Cheers,
> >
> >Gustavo
> >
> >
> >
> >On Tue, Dec 8, 2015 at 1:16 AM David Dao <notifications@github.com>
> >wrote:
> >
> >> Sure, hopefully it worked.
> >>
> >> —
> >> Reply to this email directly or view it on GitHub
> >>
> ><
> https://github.com/biojs/biojs.net/commit/cce125d0688ae8674a5ac38ba9654992b6881193#commitcomment-14836624
> >
> >> .
> >>
> >
> >
> >---
> >Reply to this email directly or view it on GitHub:
> >
> https://github.com/biojs/biojs.net/commit/cce125d0688ae8674a5ac38ba9654992b6881193#commitcomment-14841995
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/biojs/biojs.net/commit/cce125d0688ae8674a5ac38ba9654992b6881193#commitcomment-14842341>
> .
>


TeamCity LabKey :: LabkeyModules15.3 :: Git sqlserver 2014 [Build 64](https://teamcity.labkey.org/viewLog.html?buildId=290486&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:17


What is the value of the ${log} variable? On my computer it has no value, so it  tries to write into root folder and fails with exception.


this can be **swiftly** refactored to:
```Swift
func getFloatNumberFromInput(keyCodeInput : [KeyCode], fromIndex : Int, toIndex : Int) -> Float? {
    guard fromIndex <= toIndex && fromIndex >= 0 && toIndex < keyCodeInput.count else {
      return nil
    }
    return Float(keyCodeInput[fromIndex...toIndex].reduce("0", combine: { return $0 + $1.toString()}))
  }
```


hmm ok die datei wird ja autogeneriert... die sollten wir vielleicht dann noch von rubocop ausschließen.. macht mein commit hier also wenig sinn...sorry


Is this page really necessary? I guess the administrators.xhtml is the one we should use.


lol


should have a **space** after `,` `-` `:`


J'ai oublié "git init" au début et du coup mes commits n'étaient pas enrégistrés.... Désolé!


hihi


Let's just drop this one for now then - it will be quick enough to revive it if we find an actual use for it later.


Change the page title, add it to messages properties.


need **space**
```Swift
} else {
```


@andela-sachungo - However, the _diff_ on this commit does not in tandem with the subject of the commit message. I can't see the removed files.


The prerequisites for this commit from 12.1 where mainly there. Adding in this last bit frees up the data connection telephony.registry reports data reason as nvready. "No sim card inserted" still present in builds.


Relates to issue #5


Ты сохраняешь `read_controller`, но при этом прокидываешь его в методы `process_streaming`, `process_whole_file` и т.д.


主業不是前端 +1。


this `stringResult` method is not used anywhere in the project. Please remove it


Hm. Probably better to just redirect tundra-urho3d to use master.


Should this really be a `case object` rather than a plain `object`?


@ybznek
> @iankko
Req-8.7.c Seems to be much better, I will change it.

Ok, Thanks!


maybe add colour


No worries - I had to convert the "original" version from PowerPoint ;-)

Ps: this is a github discussion on a commit - therefore attaching files doesn't work


Diff is showing lot more changes than expected. Can you pls fix and resubmit?


maybe add color


Rspec error:

 1) RecipesController#destroy deletes the recipe
     Failure/Error: expect {
       expected #count to have changed by -1, but was changed by 0


and also, what kind of conversion is this? should use the system one


a test comment on commit


if we don't need it, just remove, don't comment. It's safe in the git history


@snicoll Actually, I guess the `-` should be dropped in this case, otherwise, `-` will be printed.


It figures out hat for blocksize 6 we are 18 new half-density combos to use before going to blocksize 8,
so it would probably be a mistake to skip them.
000111
001011
001101
001110
010011
010101
010110
011001
011010
011100
100011
100101
100110
101001
101010
101100
110001
110010
110100
111000


`"should display [1]"`


Yep


correct


Please work on that a little more.


Well, I'm not sure whether the formulation from [C89](http://port70.net/~nsz/c/c89/c89-draft.html#3.5.7) (*If an object that has static storage duration is not initialized explicitly, it is initialized implicitly as if every member that has arithmetic type were assigned 0 and every member that has pointer type were assigned a null pointer constant.*) implies recursion as is explicitly mentioned in [C99](http://port70.net/~nsz/c/c99/n1256.html#6.7.8p10) (*if it is an aggregate, every member is initialized (recursively) according to these rules;*). But let's hope so (I don't have such detailed knowledge of widely used compilers).


Finally find it!


why are you passing , recipe: {user: recipe.user}  to a delete action? does it make any sense to you?


this  is content  . please pull the file


That's not what we have in our own default config. Ping @wilkinsona


sorry about my previous comment I didnt see what you were trying to do.


Please put a comment here to explain what these conditions are.


These checks should really be inside `self::get()` call (probably already are?) and the code should look like:

    $result = self::get($theme);
    if ($result) {
        $list[$theme] = $result;
    }

Same is true with plugins.

The issue is that we also support `theme.php` and Gantry themes (maybe others too) will disappear because of this change.


Maybe a different issue, but can we also fix the @file comment at the top of this file and the comment describing the class.


Is this class used anywhere, seems like the same functionality exist in UserService as well


the problem you have is that in your test current_user is nil.


Good point. Switched them over to PyBytes.

FWIW, using the same rbd.c worked for me (after the PyBytes change):

    $ gcc -shared -fno-strict-aliasing -pthread -O2 -Wall -fPIC -I/usr/include/python2.7 rbd.c -lrbd -o py2/rbd.so
    $ gcc -shared -fno-strict-aliasing -pthread -O2 -Wall -fPIC -I/usr/include/python3.4 rbd.c -lrbd -o py3/rbd.so
    $ PYTHONPATH=py2 python2 -c "import rbd"
    $ PYTHONPATH=py3 python3 -c "import rbd"


The first parameter of regFunc is the actual callback function *f*. *f* has this form: *f(rt, _this, <function_parameters>...)*. Each element of <function_parameters> is a [typed value](https://github.com/felixhao28/JSCPP/blob/master/CONTRIBUTE.md#types), which should has a **v** for value and **t** for type. In this case, your code should be like:

```coffee
rt.regFunc ((rt, _this, x) ->
    rt.val sizet, 1 << x.v
  ), g, "_BV", [ sizet ], sizet
```


@lezab The default port is already set via ```long port = LDAP_PORT;``` on line 325, there is no point having the ```if``` there as ```port``` would never be ```null``` where the ```if``` is.


Looks good to me


OK, try to merge


Why does the glob method needs the `swallowIOExceptions ` argument?


congratulate


Hello, thanks for writing a great template!

I'm curious why this commit was removed... is browserSync incompatible with something else youre using?


Ты уверен, что в методы `process_streaming`, `process_whole_file` и т.п. нужно передавать именно `http_response`? Можешь объяснить почему ты так сделал?

Мне кажется, что передавать `http_headers` достаточно, т.к. эти методы и так предполагают определенный status code, и кажется очень странным например возможность выставить какой-то (несогласованный) status code вне метода `process_whole_file`.

Т.е. я вижу "правильную" логику следующим образом. Каждый из описанных методов отвечает за обработку запроса, он может получить набор общих хидеров, которые нужно добавить в ответ, но при этом он (и только он) отвечает за status code и специфичные хидера.
Единственная проблема, которая может возникнуть - это если специфичные хидера или даже status code реально определяются вне конкретного метода.


Ok then we agree that should display will be the final result in the end of input!


Missing `;` after the second path.


& #4 too


test for comment


Ok, I will try to find the shortest code for that extension.


Please explain here the general intention of the entire method.


kein problem


ncie


dfgsdf


should organize like this:
```
context("grammar pattern #1") {
  context("exampl #1") {}
  context("example #2") {}
  ...
}
context("grammar pattern #2") {...}
...
```


maybe add a color


是特意要留 Slack 的？


Yes, that's not complete yet. Will address in a another PR soon.


Fixed.


Good catch, this one slipped by when I moved everything over to cstr. Fixed.


I'm still not very convinced the current implementation is the simplest one to pass those tests


Is it works if the project doesn't contains a local mocha installation?
Now it uses the mocha from the boar-tasks-server library, but after the modification it seems that it will use the local mocha - but it's not necessary to have it in your project directly. After all, if it works I think it is the same as using a single "mocha" command because the local node_modules/.bin path is bound to the project directory context.


So like:
context("plus operator"){
     context("[1]+"){}
     context("[23]+"){}
     ....
}

Is it right ?


In fact, 'information' has no plural in the english language, so s/informations/information.

    As the install process start, we may need to collect information from


can't use `self` here


or here


Thanks! One question -- are you sure about "Картон"? In our context "Hard paper" means texture like http://dl-stockandresources.deviantart.com/art/Hard-Paper-Texture-334738384


Может ли `iobuf` быть неинициализирован?


never mind - didn't realize at first that this was in a different function


input = wait.untill {
element = browser.find_elements(:name,"textbox")
element if element.displayed?
}


No new line at end of file


等下一起调整


no, it's like:
```
context("[number][operator]"){
  context("example #1"){}
}
```


@snicoll Actually, that's what I was confused in #4708 . `:-` is a delimiter for default, so the default is `%5p` there.


@ajithcj Diff is not working properly in all cases. Please choose the correct first branch (master) from the dropdown menu, and you get the correct diff. Hope this helps.


The only actual change in this pr is that I'm passing a task object here instead of a task name.  Everything else is a refactor.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8764](https://teamcity.mesosphere.io/viewLog.html?buildId=89081&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:10:42


Имеет смысл здесь использовать executor?


Is this code easy to read and understand ? Is this Swift style apply to open source project ?


Oh.. Agreed!


Would it be possible to also strip the hash-bang in passing? It is a source of conflicts when two people work together on a branch with different configured destination directories.


It does not try to convert, but Kakoune assumes the buffer contents is utf8, not only in that case conversion code, but in all the buffer code, it should be robust enough nowadays so that it will operate correctly, not crashing, but the invalid bytes will be displayed as invalid.


`speaking()` instead of `speaking`.


That was a mistake on my part. It should be `%clr(%5p)`


The uint type is undefined under MSYS2. I quickfixed it by inserting ```typedef unsigned int uint;``` .


Tabs snuck in here, and the indentation level is rather off.


Please merge this with the other exisiting method that creates a reference.


yes, this is the recommended way to write in Swift. It is extremely and expressive


Oops, fixing now.


lol this method... all the possible bugs, 3 tries by 3 people to fix. (channel is still shadowed though :P)


@ahsansandiah nama model tidak relevan dengan isinya. Nama modelnya dashboard, tp isinya cuma status.
Dalam hal ini, lebih baik modelnya pake yg di modules Konsultasi aja, gaperlu bikin model di dashboard.


Ok! Then swiftly style is more priority when writing code.


if this method is no used, please delete the file also


@dmlloyd do you mind to review the new push ? I made two changes.

1) sync operation with the connectionLock of the endpoint, ensuring that is not going to be a race condition during connection creation: Two cases:
       a) if it reaches there before the closeAction of the endpoint. This will lead to a normal close by the endpoint as it is already registered
       b) if it reaches after the closeAction of the endpoint. This will lead to a close opeartion during handleDone

2) it runs in its own thread. This avoid a potential deadlock (cancel of the future result during RemoteConnectionProvider shutdown + the new sync block from point 1)


中文是？


Это кажется неэффективным начинать отправку рейнджа только когда boundary получена клиентом.


Did you mean canola?


<!-- PMABOT:SOB -->
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check [contributing documentation](https://github.com/phpmyadmin/phpmyadmin/blob/master/CONTRIBUTING.md) for more information.


Ok, let's leave it simple as it is. Maybe a short hint in documentation about copying from/to clipboard etc. might be helpful.


Thanks for fixing and adding the tests.


Fixed in https://github.com/spring-projects/spring-boot/commit/2d003a698fcb80744b609f584e3f18f6af86bd5e


GitHub


this is from the SNAP_Analyses within the github folder


Me parece que tampoco esta muy bien identado esto


typo in {{exception}}


@martint should review


Mala identacion


почему бы не использовать .map?

var promises = dependencies.map(loadJSFile)


Looks like there is only one caller?


Interesting, me and @Krisiacik thought this would fail on a In-Call status bar.


el "a" va dentro del li, no alrevez


Lo mismo que la linea 27


PR


может попробуем пооптимизировать? что если несколько модулей будут зависеть от одного? сколько раз он будет загружен?


Am 10.12.2015 um 01:00 schrieb Bernhard Landauer:
> https://github.com/manjaro/packages-extra/commit/bc4c9c03c2573f6eb9302060156b61326745dda8
>

Kannst Du auch MSM mitmachen. Bin grad beim Kernel-Kompilieren ...

https://github.com/manjaro/packages-extra/commit/2f55a3546588ce985f37909f8e48258312a69059


Not your fault, but this comment is wrong. We don't use tarsum for these digests.


Add a helper for all these three-line methods
```java
return buildGlobal(Global.distributed(nodeDistribution, partitioning));


also related to #7


no-extra-semi: Unnecessary semicolon.


no-unreachable: Found unexpected statement after a return.


semi-spacing: Missing whitespace after semicolon.


It's ok.


Sorry, I don't speak German... but I'll do it anyway :D


ResortedSurfaces (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-73.67%25-red.svg)


I don't have a use case in mind. That makes my statement immediately suspect.


@martint should review


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8889](https://teamcity.mesosphere.io/viewLog.html?buildId=89755&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:13


Klar ;)


not going to share it through this project.
But you can take a look at here.

https://github.com/cht8687/test-project/blob/master/gulpfile.js


This interface is identical to `ConnectorBucketFunction`. Why duplicate it?


Not sure about this naked goto here :)


Add the access modifiers to attributes.


The input has to be a file. Analytic queries can be very large with hundreds of lines of SQL and comments in-between. psql does not take large multiline queries very well.
We tried using text as output but Haisheng found that for very large queries, since the output is large, psql truncates the output? Haisheng can you confirm that?


Null check


@piroor This extension no longer works in Firefox 42.  Is it working for you?  Does this code need to be improved?


@ahrens I think this affects upstream as well, although I don't recall if IllumOS core dumps on double free. I'm not sure this fix is the cleanest either.


The `this` isn't needed. Also easier to read on one line:
```java
this.partitionCount = IntStream.of(bucketToPartition).max().getAsInt() + 1;


Esto no es semantico


ResortedSurfaces (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8890](https://teamcity.mesosphere.io/viewLog.html?buildId=89756&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:53


antipattern:
foo makes foo

justification:
hey foo

created on antipattern.io


```java
bucketToPartition = IntStream.range(0, partitionToNode.size()).toArray();


still doesnt work from RStudio


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8888](https://teamcity.mesosphere.io/viewLog.html?buildId=89750&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:10:08


Por que isso agora? Jskajskajsa

Em 9 de dezembro de 2015 20:36, Gerson Sales <notifications@github.com>
escreveu:

> Pode comentar as linhas tambem! o.O
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ManoelF/Projeto_P2/commit/95664e9c94cd4deb5811d282872dedce995748bb#commitcomment-14888109>
> .
>

--
Atenciosamente,

*Ítalo Héctor de Medeiros Batista*
Universidade Federal de Campina Grande
Graduando em Ciência da Computação
Programa de Educação Tutorial - PET Computação


s/WebSocketMain/flashsocket/ ?


I think this isn't going to work very well with destructuring.


étrange que ça ressemble à la ligne 75


What a cleanup /no1


Perhaps we can use the `ImportStatement` stuff that was recently extracted?


That's interesting...by omitting the protocol from in front of the address, it's supposed to use the protocol that the server is using to retrieve the fonts. I was using https: and was receiving an error because it tried to load fonts using http and threw a security error and instead I was getting Arial. Can you post a screencap of the error? Thank you.


Most likely just followed a Linux crypto example when that was pulled in. It probably isn't needed.


something


acho que sim


have you looked at https://github.com/sindresorhus/np and https://gist.github.com/stevemao/280ef22ee861323993a0?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8891](https://teamcity.mesosphere.io/viewLog.html?buildId=89757&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:47


Thanks Vlad, we've updated the page.


@dcci Is there a test case that this fixes or is it only possible if someone forgets to override addParentMetadataRef()?


Utilidade futura! :D kkkkk


Can you give a reason for this change?


Wow, really? Cool.


This code is familiar, it is exactaly the same found in sol_http_split_str_key_value().
I think we should rename sol_http_split_post_field/sol_http_split_query to sol_http_str_to_post_field/sol_http_str_to_query and add one more function that does the exactly thing for http headers (sol_http_str_to_header())


This fixed #28.


separate commit?


I sent out a proposal for a syntax to swift-dev:
https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20151207/000195.html


the changes to sidebar-interface.tpl are not acceptable as it includes a bunch of placeholder text for no apparent reason


please roll back this commit so that it stops showing up in your pull requests


That's the same structure I use although I prefix it with the root module name:

```
INSTALLED_APPS = [
    ...
    'trbs.apps.foo',
    'trbs.apps.bar',
    ....
]
```

I'm sorry but for the moment I do not have the time to really dive into this... I do use graph_models but not with projects upgraded to Django 1.9 yet.

Do you have time to debug where your problem is originating from ?

I would really like to solve this one before a next release but at some point we might consider releasing a next version of django-extensions for all the other people with this as a "known-bug".


We should move the base path for the map to requests.yml. I'll do that in the PR I'll pull together for the account stuff.


Collapse these two if statements?


Make sure they are set with this sort of mechanism so it works on build and install steps:

```
    target_include_directories(sawConstraintController INTERFACE
-      $<BUILD_INTERFACE:${CMAKE_CURRENT_PROJECT_DIR}/include>
-      $<INSTALL_INTERFACE:include>  # <prefix>/include/mylib
-    )
-
```

I don't know the exact call off hand but I'm sure it is in the cmake documentation.


This file shouldn't have been committed.


LGTM


dangit. doing badly with this today


yep, due to the 300-line limit, the formatter "class" would be too large, so better not use it as a receiver. technically it will still pass the check, but would make it harder in the future when we try to convert this into G language where all methods must be defined inside the class.


Thanks Vlad, we've added your recommendations for the page.


Thanks.


If you make `start()` return `this` then it can be one line


Hey Andy

Can you try something like this to add those classes back in?  This was
Ray's suggestion to grab all the inner classes.

@../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringPool*.class,\
    @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringURLCodec*.class,\
    @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringUtil*.class,\
    @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/Validator*.class,\

On Wed, Dec 9, 2015 at 4:43 PM, Raymond Augé <notifications@github.com>
wrote:

> doing this
>
>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringPool.class,\
>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringURLCodec.class,\
>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringUtil.class,\
>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/Validator.class,\
>
> allowed the module to not have external dependencies on these utilities.
> Therefore it could run outside of Liferay.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AndyWu2015/liferay-portal/commit/f2f2cc8200ef9db71b3ec9ef76a89f3515e6ea61#commitcomment-14887184>
> .
>

--
Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com


I avoid metafunction forwarding. If `value_type<I>` is a user specialization that has other garbage in it, we don't want that garbage to be inherited by accident.


Andy just send a new pull request that uses LPS-60660 as ticket.

On Wed, Dec 9, 2015 at 6:25 PM, Greg Amerson <gregory.amerson@liferay.com>
wrote:

> Hey Andy
>
> Can you try something like this to add those classes back in?  This was
> Ray's suggestion to grab all the inner classes.
>
> @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringPool*.class,\
>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringURLCodec*.class,\
>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringUtil*.class,\
>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/Validator*.class,\
>
>
> On Wed, Dec 9, 2015 at 4:43 PM, Raymond Augé <notifications@github.com>
> wrote:
>
>> doing this
>>
>>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringPool.class,\
>>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringURLCodec.class,\
>>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringUtil.class,\
>>     @../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/Validator.class,\
>>
>> allowed the module to not have external dependencies on these utilities.
>> Therefore it could run outside of Liferay.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/AndyWu2015/liferay-portal/commit/f2f2cc8200ef9db71b3ec9ef76a89f3515e6ea61#commitcomment-14887184>
>> .
>>
>
>
>
> --
> Greg Amerson
> Liferay Developer Tools
> Liferay, Inc. www.liferay.com
>

--
Greg Amerson
Liferay Developer Tools
Liferay, Inc. www.liferay.com


> Performance. Since we're now blocking basically every interaction with the data structure on a single lock object, have we made anything worse in terms of perf bottlenecks than how it was before?

Not sure I answered this elsewhere but the `LinkedBlockingDeque` that we use in current code also uses a `ReentrantLock` to internally guard calls made to the `take` and `poll` methods it exposes such that only one taker can be processed at a time.  In theory, at least, this code might be "faster" than what we have in Puppet Server today since we'd be down to just one `ReentrantLock` to get to a borrow instead of both a `ReentrantReadWriteLock.ReadLock` and a `ReentrantLock` needing to be taken in order to pull an element out of the pool.


That's fine.


Are not these last two lines unreachable now?


But why not start it?


Minor question, otherwise LGTM.


perf-wise `_.isUndefined()` and `_.isNull()` are about the same as vanilla JS strict comparisons, and we tend to favor the more readable syntax. <3 lodash


Check for null


Wrap this


"does" :)


LGTM


ResortedSurfaces (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (897 of 897 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.35%25-green.svg)


Invert this


> libopencm3 is one of the widely used embedded library and it would be a great example for developers how to do things right.

Which is why we should drop `make install`, because that's doing it wrong. Doing it right for a library of this kind is IMO to link it as a git submodule underneath the project itself, which allows the full history of project vs library versioning to be kept.

> Thus path `/usr/arm-none-eabi/lib/` should be provided by the command line.

Except it's the wrong path. Remember that this is a cross compiler targetting multiple sub-architectures, and therefore have a multilib mechanism containing multiple libc (and friends) builds.

For cortex-m, you need one of the thumb-only builds. Linking in a libc built for a different sub-architecture tends to work for a while but lead to unexpected crashes when the resulting code tries to change to arm mode which is not present in cortex-m.

It's strongly advised to leave the compiler library tree alone and let the multilib mechanism pick the right variant from the supplied compiler flags.

The other option would be to actually build multilib variants of libopencm3 itself. The latest gcc-arm-embedded version ships with 10 different ones for cortex-m, which means that you'd need to have 10 copies of libopencm3, built with different options (and for each of these, you'll have multiple builds to support each vendor and chip family that that variant could be appropriate for).


Wrap


Meaning do multiple pulls?


Excuse me, what are these "pixelmon sprite" ? because from what I know, a sprite is like an imp, right ?


What is `100`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8892](https://teamcity.mesosphere.io/viewLog.html?buildId=89786&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:50


# What did you learn about pseudocode from working on this challenge?
# => I learned that pseudocode is a very useful practice for making larger
# => problems seem smaller and more manageable.
# What are the tradeoffs of using Arrays and Hashes for this challenge?
# => Arrays are ordered but cannot have valued assigned to their contents.
# => Hashes are unordered but their keys have corresponding values.
# What does a method return?
# => Methods return the work done within the problem if called. Otherwise, nil.
# What kind of things can you pass into methods as arguments?
# => You can pass arguments and data.
# How can you pass information between methods?
# => You can put two methods inside of a greater method and state functions
# => or data outside of the smaller methods.
# What concepts were solidified in this challenge, and what concepts are still confusing?
# => I still need to look up a lot of methods that I use even if I don't have a
# => problem with thinking of the pseudocode. Also, I don't know how to use all the
# => different ways to set up a hash and what their differences are.


I think this should be `UnsupportedOperationException`


So this sounds like a caveat that I have worried about before - a good OO design might be compromised under this style idiom.

Nonetheless I will proceed without receiver.


ResortedSurfaces (JasonGlazer) - i386-Windows-7-VisualStudio-12: Tests Failed

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-73.67%25-red.svg)


I didn't know a doe could be a core contributor! :P


Great to see the steps involved :)


No


If you look at my most recent commit, it's been renamed to "Token".


I was wrong about removing the second `max-width` though (see b6808a42a182d595cc5f0399b3ef49479c59100e).


This was intentional, accounts are not handled by the displaynames, they are handled by the names, which are supposedly unique.


Yup sorry i just saw that, i opened all the history changes ^^'


I get a "maybe uninitialized" warning for valCount at this point, might be worth looking into?


Closes #1 .


Sorry, the connattrs branch didn't have latest fixes in it -- this was already fixed on the `spec-updates` branch (https://github.com/ably/ably-js/commit/1b151df5558339d8b2fd80bbadd2375d9a138b4a#diff-e77b7978a3ffc923f65b10234263d45eR268)


That implies people with  pirated copies cannot be admins, or even administrate their own server. Also admins would need to use their original nickname.


An earlier patch splits  expandTypeIntoLeafProjectionPaths(... bool OnlyLeafNode), into 2 functions (expandTypeIntoLeafProjectionPaths and expandTypeIntoNodeProjectionPaths).

The same patch also reimplements expandTypeIntoLeafProjectionPaths. There is a problem with the re-implementation, but i do not want to revert the entire patch. so I revert to the old expandTypeIntoLeafProjectionPaths(... bool OnlyLeafNode) implementation with slight modifications (i.e. OnlyLeafNode is true)


Corrected here and in `counted_iterator`.


Thanks Andy :+1:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8893](https://teamcity.mesosphere.io/viewLog.html?buildId=89791&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


Now you return DNS_TRANSACTION_PENDING where before you would return DNS_TRANSACTION_NULL. Is that intentional?


Thumbs up (Y)


I think the issue comes down to this C++ lambda

https://github.com/pyopencl/pyopencl/blob/528e81f3941fb40c75921537c0444f56a87c1314/src/c_wrapper/event.h#L43-L50

needing to have the `stdcall` convention. According to this answer:

https://stackoverflow.com/questions/17714175/how-to-use-stdcall-to-qualify-c-lambda

a `static_cast` may do that. I've implemented this in  b45bc73. It doesn't break *nix builds, FWIW. Let me know how it goes on Win32.


Casual inspection of the code suggests that this can't happen: earlier, we check if `seq != 0` and if it is we set `valCount` (or we return, in which case we don't get here). Here we only check `valCount` if `seq != 0` so `valCount` must be set.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8895](https://teamcity.mesosphere.io/viewLog.html?buildId=89792&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:07:55


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8894](https://teamcity.mesosphere.io/viewLog.html?buildId=89793&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:08:17


Is this in some RFC? I remember reading somewhere a suggestion of caching NSEC/NSEC3 from the authority section, but then only for a limited period of time, and it did not seem to apply to other records. To me it seems totally fine to cache all that is validated as you do though... Maybe worth double checking.


Or from the cache, right?


@osahyoun I'm not sure at what point the last four digits get stored in the transaction, so I'm not sure any changes are required to ensure that the last four digits that have been stored for the user match the ones in the transaction. Could we talk about that / could you tell me if there's anything that would check and update the Braintree customer in the transaction class?

That said, we were talking some about our local storage for Braintree customers.
I feel like the storage for local customers should be tied closer to members. There could be a foreign key column for `member_id` in the braintree customers table (after all, all donors are members). Other than that, I'm not sure I understand the necessity of storing extensive BT customer data in a table locally. There's a lot of duplicate data with the members table, and the only step where we use the local donors table currently is to see if the customer exists in the Braintree vault (if they have an existing payment token locally). I think everything else in the table is accessible from the Braintree response object for transactions or subscriptions, and we will be using the response objects together with params to construct the JSON that gets sent to ActionKit. So we basically don't even use the local donors table. Is there a good reason for making the distinction between members and braintree customers, or could the local donors table be stripped down to just contain data that's not duplicated in the members table? (Is there a use case for that data, generally speaking, other than to look up if the payment method token exists?)

Another thing I thought of is that we should be able to distinguish payments made with PayPal from credit card payments. Overall I feel like we should rethink our local architecture a little bit. @osahyoun if you're feeling better tomorrow and have some time, it'd be great if you could think about this a little and write back to me or we could have a talk.


:DDDDDDDDDD


noted ;)


@camlow325 i'm good with going back to the other approach


Xin, this is inefficient. You can save the iterator and return the value.


LGTM


tests all pass

```
$ psql -U skmehta -f test/test.sql | grep ERROR
$
```


Minor comment, but LGTM otherwise.


Why are you doing a second lookup? You can save the result in a variable and return that.


Call `poolSizeLimit` ?


This method is a duplication of the other method.  Why do we have both?  Can you merge them and pass a flag (enum) that decides what expansion method to use?


private[memory] ?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8896](https://teamcity.mesosphere.io/viewLog.html?buildId=89817&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:38


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8897](https://teamcity.mesosphere.io/viewLog.html?buildId=89818&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:36


JOKER IS SO FUNNY NOW GIVE THEM THA BAT


1) inserire la modalità "dev" nel file composer

2) installare il pacchetto:
$ composer require bestmomo/scafold

3) aggiungere il service provider

4) pubblicare:
$ php artisan vendor:pulish

https://github.com/bestmomo/scafold


@pelwell I've been running an A+, B, B+ and 3x 2B's, having switched to sdhost driver on all. Nothing bad to report. In fact, even my deliberate attempts to cause issues, (I have a few "problematic" cards that I only use for testing purposes), haven't been successful..... Only time will tell, but it's looking good! I'll switch a CM and Zero to use sdhost driver tomorrow. They run 24/7, but currently testing something else on them.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8900](https://teamcity.mesosphere.io/viewLog.html?buildId=89821&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:58


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8898](https://teamcity.mesosphere.io/viewLog.html?buildId=89819&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:07:13


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1118.4a4424f29b567e4452da464d523a97cb34589f99](http://build.palaso.org/viewLog.html?buildId=67145&buildTypeId=bt431) outcome was **UNKNOWN**
Summary: Canceled (Tests passed: 502, ignored: 4; exit code 1) Build time: 00:15:43


@scalp42 I have to plans to at least support Consul.


seems fine to add this in. Just make sure the self object passed in addObserver is a weak reference since it's in a block here.


There was a pull request https://github.com/minimod/minimods/pull/6/files that did exactly the same.


% 課題８ ラベリング
% 二値化された画像の連結成分にラベルをつけよ．
% 下記はサンプルプログラムである．
% 課題作成にあたっては「Lenna」以外の画像を用いよ．
% 例

ORG = imread('Lenna.jpg'); % 画像の読み込み
ORG = rgb2gray(ORG); % 白黒濃淡画像に変換
imagesc(ORG); colormap(gray); colorbar; % 画像の表示
pause;
IMG = ORG > 128; % 閾値128で二値化
imagesc(IMG); colormap(gray); colorbar; % 画像の表示
pause;
IMG = bwlabeln(IMG);
imagesc(IMG); colormap(jet); colorbar; % 画像の表示
pause;


hi @reshama !
Just found it...
:dancers:  :smile:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8901](https://teamcity.mesosphere.io/viewLog.html?buildId=89829&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:11


Unfortunately you can't see the line endings in github's diff view


This is blocking on https://github.com/hackclub/hackclub/pull/540


Nice!


I checked this before committing and get the following:

DETAIL:  drop cascades to type entity_type


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8902](https://teamcity.mesosphere.io/viewLog.html?buildId=89832&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:33


should rename "completionHandler" in the signature to something else, to get rid of the ambiguity with the instance variable completionHandler (Xcode warning)


Edit the following fields in your s3cmd configuration file. ~/.s3cfg

host_base = localhost:9000
host_bucket = localhost:9000
access_key = YOUR_ACCESS_KEY_HERE
secret_key = YOUR_SECRET_KEY_HERE


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8899](https://teamcity.mesosphere.io/viewLog.html?buildId=89820&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:10:09


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8903](https://teamcity.mesosphere.io/viewLog.html?buildId=89833&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:21


GruntFile.js 작성


LOL! I was about to make the same change, @hmmr, but I guess you are still awake. After all, it's only 1:06 a.m. in the UK.


TeamCity LabKey :: Trunk :: Premium :: Git postgres 9.4 [Build 837](https://teamcity.labkey.org/viewLog.html?buildId=290630&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 38 (9 new), passed: 243 Build time: 01:31:26
### Failed tests
```
org.labkey.test.tests.DataFinderTest.testImmuneSpaceStudySubset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudySummaryWindow: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCards: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testNavigationDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testBackDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCardStudyLinks: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testFinderWebPartAndActionShareFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testRefreshDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.util.JUnitFooter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testDatasetExport: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelection: <no details avaliable>

##### there are 28 more failed tests, see build details
```


TeamCity LabKey :: Trunk :: Premium :: Git postgres 9.4 [Build 837](https://teamcity.labkey.org/viewLog.html?buildId=290630&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 38 (9 new), passed: 243 Build time: 01:31:37
### Failed tests
```
org.labkey.test.tests.DataFinderTest.testImmuneSpaceStudySubset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudySummaryWindow: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCards: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testNavigationDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testBackDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCardStudyLinks: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testFinderWebPartAndActionShareFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testRefreshDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.util.JUnitFooter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testDatasetExport: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelection: <no details avaliable>

##### there are 28 more failed tests, see build details
```


Yeah, I was thinking the same thing - probably just a confused compiler/preprocessor that doesn't check if an identical condition is already present in previous parts of the code.


Doesn't seem to for me, just tried (DROP SCHEMA bookbrainz CASCADE;). I wouldn't expect it to, since it's not part of the schema, is it?


:beer:


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1119.4a4424f29b567e4452da464d523a97cb34589f99](http://build.palaso.org/viewLog.html?buildId=67147&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 745, ignored: 6 Build time: 00:08:25


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8904](https://teamcity.mesosphere.io/viewLog.html?buildId=89841&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:58


not sure if doing this on the main queue is really necessary. The receiver should really handle this, not you.


The reason it's there is because the other `setCamera` needs it; that's why we pass in null with `flyToCamera`.


ok for now...but I'd really like to get away from using this map and instead storing the name with the config like the TODO says.


Unlikely here -- but blocks can be nil. So if you don't check for it, it can potentially crash


I am here


does this compile? you need to change the function name above, no?


might be nice if these also lived in configs


![image](https://cloud.githubusercontent.com/assets/16192186/11703896/9c22e21c-9ea8-11e5-839a-b250fa7e05c4.jpeg)
![image](https://cloud.githubusercontent.com/assets/16192186/11703897/9c25c36a-9ea8-11e5-9ca7-9f1a8f8044c7.jpeg)
![image](https://cloud.githubusercontent.com/assets/16192186/11703898/9c2a90de-9ea8-11e5-8eef-90d7f3e7af91.jpeg)
![image](https://cloud.githubusercontent.com/assets/16192186/11703899/9c2cadb0-9ea8-11e5-9e25-1a00c6aa5722.jpeg)
![image](https://cloud.githubusercontent.com/assets/16192186/11703900/9c3170e8-9ea8-11e5-953e-cf7c77e59f44.jpeg)
![Uploading image.jpeg…]()
![Uploading image.jpeg…]()
![Uploading image.jpeg…]()
![Uploading image.jpeg…]()
![Uploading image.jpeg…]()
![Uploading image.jpeg…]()
![Uploading image.png…]()
![Uploading image.gif…]()
![Uploading image.jpeg…]()
![Uploading image.jpeg…]()
![Uploading image.jpeg…]()
![Uploading image.png…]()
![Uploading image.gif…]()


looks good


what was the history of this being put in?


I assume you wanted to change the function name to getClaimedTopicState?


3b63c19d6b51353ffaab4305f624be0e7677f95e

It looks like it went in with adjustments to PS and Agg, should those also be removed (or have already been removed)?


Yes, sorry about that. Merge issue.


I dislike them all, because they sound weird in the singular. I think "domain" is best, but just doc what it does in the struct


Looks like a rogue import now?


I would argue that it is *not* a good OO design to have a big class that does too many things. Or in other words, a clear modularization and dependency hierarchy is more important than a context correlation that mimics somebody-does-something in grammar for better comprehensibility. In golang, x.f() is fundamentally no more than a syntax sugar for a function call of T.f(x). And the type T here essentially serves as a namespace for all functions that correlates with the context. The key idea of e8vm is to prevent a namespace to be too large and hence has a flat and collapsed structure that has a interface surface so wide to understand at a time. A big namespace is a bad namespace; and a big class is a bad class.

Imagine sometime someone need/want to understand and translate this formatter into G language, then we would need to find the most basic method functions of the formatter and start with that. So the structure of how this formatter is organized in files needs to reflects its layering architecture.

This is also how I use builder in g8 and asm8. The functions bind to g8.builder and asm8.builder are only basic helper functions for building, but not all the building procedure.

In contrast, try read this golang parser: http://lonnie.io/gostd/go/parser/parser.go.html
it's really painful without a code-search like index, and even with an index, it is hard to tell the internal layering structure.

OO is mostly a fake concept, and often the sin for lots of industry boilerplate code of unnecessary creations of classes and objects. the real key point of OO is just namespaces, and effective namespaces must be small to have good readability.

okay... so much for back-firing... smiley :)


is this needed in 1.8 branch too?


The CREATE TYPE docs specify that the type name can be schema-qualified, so I suspect it's added to the default schema. Just checked and my search_path is "$user",public and I'm working as the bookbrainz user, so that's presumably where it's going. I'd say we want the entity_type ENUM to be schema-specific, so perhaps we should explicitly qualify it.


Will do. Thanks!


Yes, it should.


Can we remove this, and uncomment this section from existing config.py?  There is already a commented out section in the file.


This won't work, at this point status is still not bound to the class -- unless you mean something far more lazy and magical than is immediately implied


`release = molecule.__version__`, don't think there is a need to assign a temp version variable.


In the modern Objective-C runtime, you can call methods that are in the same `@implementation` block without predeclaring them.


@sgdc3 why you inserting so much TODO, so spammy in todo list.


The commit comment is a little misleading. The lastPlayed value will still update if the game was already part of the gallery cache.


Take care that fields (and hence models) don't come to depend on forms


got it


```
In file included from src/c_wrapper/clhelper.h:1:0,
                 from src/c_wrapper/event.h:1,
                 from src/c_wrapper/event.cpp:1:
src/c_wrapper/event.h: In instantiation of 'void event::set_callback(cl_int, Func&&) [with Func = event::release_private()::<lambda(cl_int)>; cl_int = int]':
src/c_wrapper/event.cpp:95:18:   required from here
src/c_wrapper/error.h:255:35: error: invalid static_cast from type 'event::set_callback(cl_int, Func&&) [with Func = event::release_private()::<lambda(cl_int)>; cl_int = int]::<lambda(cl_event, cl_int, void*)>' to type 'void (__attribute__((__stdcall__)) *)(cl_event, cl_int, void*) {aka void (__attribute__((__stdcall__)) *)(_cl_event*, int, void*)}'
     call_guarded(func, #func, args)
                                   ^
src/c_wrapper/event.h:41:13: note: in expansion of macro 'pyopencl_call_guarded'
             pyopencl_call_guarded(
             ^
src/c_wrapper/event.h: In instantiation of 'void event::set_callback(cl_int, Func&&) [with Func = event__set_callback(clobj_t, cl_int, void*)::<lambda()>::<lambda(cl_int)>; cl_int = int]':
src/c_wrapper/event.cpp:236:22:   required from here
src/c_wrapper/error.h:255:35: error: invalid static_cast from type 'event::set_callback(cl_int, Func&&) [with Func = event__set_callback(clobj_t, cl_int, void*)::<lambda()>::<lambda(cl_int)>; cl_int = int]::<lambda(cl_event, cl_int, void*)>' to type 'void (__attribute__((__stdcall__)) *)(cl_event, cl_int, void*) {aka void (__attribute__((__stdcall__)) *)(_cl_event*, int, void*)}'
     call_guarded(func, #func, args)
                                   ^
src/c_wrapper/event.h:41:13: note: in expansion of macro 'pyopencl_call_guarded'
             pyopencl_call_guarded(
             ^
error: command 'X:\\mingwpy_win32_vc90\\bin\\gcc.exe' failed with exit status 1
```


Minor, but should be `===`


#107 would have caught this ;)


there's some event that impossible to fired by npc plugins.
like quit and join event


This isn't supposed to be a hard coded 'Incident' at all.. I'm pretty sure "Incident" is an example of a Post type name.. so it should be "Add {{type}}"


Translate


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8905](https://teamcity.mesosphere.io/viewLog.html?buildId=89853&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:46


.. wheres the context for this? We really shouldn't be seeing partial sentences in i18n files. Add the rest as variables if needed.


saw approval from javajolt
at https://github.com/basho/riak-erlang-client/commit/8e3bc956f223f98ac513da5de6e43fde05f8e50d


merging basho/riak-erlang-client/fix/az/ts-streaming-list_keys = 8e3bc956 into borshop-integration-253-fix/az/ts-streaming-list_keys


basho/riak-erlang-client/fix/az/ts-streaming-list_keys = 8e3bc956 merged ok, testing candidate = 52554533


I think we should still be doing this.. not calling all posts incidents.


BTW, there was a tiny compile error on clang in the code (template default
argument apparently can only appear in the declaration, not again in the
definition of the function). It looks like we should compile with clang and
g++ before committing, or setup some test system that tests with clang too.
clang tends to be a bit more picky about the standard.

Cheers,
Ludwig

On Wed, Dec 9, 2015 at 4:46 PM, Ilya Razenshteyn <notifications@github.com>
wrote:

> Done: 304e006
> <https://github.com/FALCONN-LIB/FALCONN/commit/304e006d0aae06923149e50fdfa227a5e2fe2872>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/FALCONN-LIB/FALCONN/commit/abdadc720a499e33c3e0ac53118814bec84e3632#commitcomment-14885849>
> .
>


This code uses google web speech to convert videos to text and sends the text to insertToDB.jsp


It may look strange that model is updated even if dialog is cancelled.
ManageProjectsHandler opens ManageProjectsWizard in OkButtonWizardDialog so that any changes may be persistent. In this case, the wizard is opened in OkCancelButtonWizardDialog and ok/cancel is for selecting project. I would suggest to change wizard title and description for this invocation. Title may be 'Select project', and description should mention that all changes to projects are permanent and will not be cancelled.


I believe this was happening because of line ~529 `.uomcontent .page-header.floating` (there's an earlier one that does reset to ff-sans, but it's on `not:floating` :sweat: ) - maybe delete that one (line ~45), since it's redundant now


:dancer:


I see what you're saying. How about instead:

1. keep this parseEmailDomain function
1. get rid of the validateIndentity concept
1. add a new method to the connector which calls parseEmailDomain, compares to domain (or does nothing if c domain == "")
1. in the main body reduce the logic to something like
```
if !c.validateDomain(email)
...
}
```

So the main body ends up just as small as you have it now.


seems good to me in general, but don't roll your own email validation regex -- let's use `validator` like we do in hylo-node.


i assume this is by mistake?


:tada:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8906](https://teamcity.mesosphere.io/viewLog.html?buildId=89865&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:43


Hi, there seems to be some glitches with this implementation.

My PIN is more than 4 numbers long.

When trying to enter more than 4 numbers the device becomes laggy (Probably because the checks happens in the main thread) and upon getting more numbers than my actual PIN length, no matter what PIN I enter, (even the good one) the devices doesn't unlock automatically. Moreover, I have a message with a timeout when pressing on the check button.

I have found that the AOSP team changed their checks to be Async checked. I

https://github.com/zephiK/android_frameworks_base/commit/6e38058908d6e49a241e384cd7023d9ac0927afb

I don't know if it makes a difference but it's probably worth a shot.


LGTM. Thanks.


ResortedSurfaces (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1435 of 1435 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.5%25-green.svg)


See #127.


LGTM


How about refine it as below
```
String xwalkUserAgent = preferences == null ? "" : preferences.getString(XWALK_USER_AGENT, "");
String xwalkAppendUserAgent = preferences == null ? "" :
preferences.getString("AppendUserAgent", "");
if (!xwalkAppendUserAgent.isEmpty() && xwalkUserAgent.isEmpty()) {
     xwalkUserAgent = XWalkSetting.getUserAgent() + " " + xwalkAppendUserAgent;
}
if (!xwalkUserAgent.isEmpty()) {
    webView.setUserAgentString(xwalkUserAgent);
}
```


#4994-ControllerWaterCoil-TemperatureAndHumidityRatio-control-active-when-it-shouldn't-be (mjwitte) - i386-Windows-7-VisualStudio-12: OK (1968 of 1983 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.24%25-yellow.svg)


this deserializeForSync is a bit worrisome for me.  Seems like it should have or could have a different type from the serialize/deserialize message.  Maybe we should remove this method from this interface and create separate interfaces for other interactions like sync.


Ah good, I'll drop the commit or perhaps you can merge with your branch when you merge?


A configuração do git como source elimina a necessidade de utilizar o source do repositório de gems privado The Shire (geminabox implantado no Heroku).


I just ran this code and got the following:

panic: interface conversion: marshal.message is *marshal.msgHeartbeat, not *marshal.msgBase

goroutine 114 [running]:
runtime.panic(0x8a7420, 0xc2096b1680)
	/usr/local/go/src/pkg/runtime/panic.c:279 +0xf5
github.com/dropbox/marshal/marshal.(*Marshaler).consumeFromKafka(0xc208056fc0, 0x0, 0xc208366000, 0xc208364100)
	/srv/server/go/src/github.com/dropbox/marshal/marshal/rationalizer.go:129 +0xc22
created by github.com/dropbox/marshal/marshal.(*Marshaler).kafkaConsumerChannel
	/srv/server/go/src/github.com/dropbox/marshal/marshal/rationalizer.go:24 +0xfb

goroutine 16 [chan receive]:
main.main()
	/srv/nfs-server/go/src/dropbox/cape/dispatcher/cape_dispatcherd/main.go:67 +0x8d3


I added this as another pass (which runs first). Should I merge it with one of the others? Should I match cases that aren't `PositionedValue`s? I assumed this was safe since it runs before other case desugarings. Is there a better way to throw a single positioned error? I didn't notice a combinator for that.


SlowMo it's not supported in AOSP builds.


I added a method for Raptor:
```java
private static PropertyMetadata<?> stringListSessionProperty(TypeManager typeManager, String name, String description)
{
    return new PropertyMetadata<>(
            name,
            description,
            typeManager.getParameterizedType(ARRAY, ImmutableList.of(VARCHAR.getTypeSignature()), ImmutableList.of()),
            List.class,
            ImmutableList.of(),
            false,
            value -> ImmutableList.copyOf(stringList(value).stream()
                    .map(s -> s.toLowerCase(ENGLISH))
                    .collect(toList())));
}


some people that already own gta v use pirated gta because if rockstar wants to ban people that inject or edit the game sp or mp they can ban us because modding isnt allowed as their licenses and eula says, so we are safe with pirated copy because we dont use the normal Social Club Account


Hive needs the same thing. Would be nice to add to `PropertyMetadata`, except it has the lowercase behavior.


I called this `bucketed_on` in Raptor.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8907](https://teamcity.mesosphere.io/viewLog.html?buildId=89866&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:53


Null check


Sure. The original directive fires an event called "g-places-autocomplete:select" with the prediction as parameter. My patch adds the possibility to add a callback when that event is fired, ie: when a new place is selected.
To use it, just add an attribute: on-place-updated="myCallback(prediction)" to your directive. In your controller, define $scope.myCallback(prediction). That function will be called every time a new place is selected from the directive.


Maybe add comment
```java
// required for Jackson


moved to test_transform


Hi Marcin,

Any chance this will have any additional benefit in sorting out the GEMP LOTR Towers Sealed issue (since the error is the same), or is this strictly for your MTG integration?

Thanks
dmaz


This seems really weird. If you can't edit a post, I think we could just skip this element entirely. Theres no context so I just see "Everyone" and have no idea what it means.


`abs` can return negative. Use something like
```java
int value = (int) (hash & Integer.MAX_VALUE);
return value % bucketCount;


Another way to do this would be add a `none` to the level:

typedef NS_ENUM(NSUInteger, FLLogLevel) {
    FLLogLevelNone = 0,
    FLLogLevelError,
    FLLogLevelWarn,
    FLLogLevelInfo,
    FLLogLevelDebug,
    FLLogLevelVerbose
};

(alternatively could be a bit mask).

After that, the log block could be  `+ (void)setLogBlock:(void (^)(NSString *logString))logBlock;` which would probably (for most users) end up just wrapping `NSLog` or similar.

We can also expose a log level variable that the parent application can set. Then,  `+ (void)logString:(NSString *)logString withLevel:(FLLogLevel)level;` can determine if we actually call the log block, so that the user doesn't have to handle the various cases within the block.

There are for and against reasons for this, but for most users it might be simpler.


I think the rationale should explain why enum/enum34 is not enough.

Also, this raises doubts about mixing concerns and layers (something which is in the model layer is suddenly a user of forms and templates... I know you use the names indirection, but still).


```java
if (nodes.isEmpty()) {
    throw new PrestoException(NO_NODES_AVAILABLE, "No black hole nodes available");
}


"split the data using split" ??


all tests pass:
success: http://buildbot.bos1/builders/erlang-client-test/builds/232


if the thread is still running, the `nfsThread` object will not have a success attribute. This will then raise a attribute error right?


How does this stop a thread? I still don't understand who is listening to the `_stop` event.


error when starting dd game. gonna put a screenshot on slack


Hmm, I think this should check connector ID, but none of the others do... seems broken


saw approval from javajolt
at https://github.com/basho/riak_kv/commit/87d4a5d34810cd72cd8d3d181bab0580b8577b21


merging basho/riak_kv/fix/az+jm/enable-streaming-for-ts-list_keys = 87d4a5d3 into borshop-integration-1291-fix/az+jm/enable-streaming-for-ts-list_keys


basho/riak_kv/fix/az+jm/enable-streaming-for-ts-list_keys = 87d4a5d3 merged ok, testing candidate = fb790ff2


nice :ok_hand:


ok nvm, found it :+1: .
http://stackoverflow.com/questions/323972/is-there-any-way-to-kill-a-thread-in-python


ሰላም Swift


use `WMFDefaultSiteDomain` from `MWKSite.h`


I see from @henare’s comments here https://github.com/OPORA/publicwhip/pull/165#commitcomment-14864631 that he suggested making a change to the data. @beastie87 could you explain why it’s better to `gsub` out this text here, rather than remove it from the source data?

I think changing the data could be better because it’s very hard for someone looking at this code for the first time ( me ;-) ) to understand what the purpose of this `gsub` is. I can see from the link to the issue #162 that it is there to remove repetition in the MP’s name, but it seems to me that removing the repetition from the data would be better and much more maintainable.

Also, this would be helpful information to put in the commit message :) Here's the basic guide I try and follow for commit messages https://robots.thoughtbot.com/5-useful-tips-for-a-better-commit-message


I'm thinking monster specific weapons would make a fair bit of sense, currently domesticated monsters are getting tech bonuses and that seems weird, when Juggers had something called a laser that was understandable shortcut, but having them get better with research breaks suspension a bitt too much for me.


```java
checkState(nodeManager != null, "NodeManager has not been set");
checkState(typeManager != null, "TypeManager has not been set");


Tested OK :+1:


Capitalize "AS"


@willdoran Can we drop the placeholder please?? either swap it for the users gravatar OR remove it if we don't have the author


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1982 of 1983 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


These should be updated to `assertUpdate`


Thinking about condition codes in getTicks further. I can see two use cases:
* Filter by condition codes: this could be done in C++, without necessitating using of data.frame, assuming one did not need to work with the condition codes on R side
* Return data with condition codes attached: character data in condition codes would necessitate supporting a data frame return option

I am thinking of an options vector for getTicks which would include the returnAs option, plus an option to filter to condition codes in a character vector, and an option to return condition codes or not.

I think the behavior would be the condition codes would not be returned (i.e., ignore the option) if the returnAs option was one which did not support character data.

What do you think @eddelbuettel?


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 99](https://teamcity.labkey.org/viewLog.html?buildId=290661&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:18


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8908](https://teamcity.mesosphere.io/viewLog.html?buildId=89875&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


Was wondering if that was possible, let's do it.
On 10 Dec 2015 1:16 am, "Sean Burke" <notifications@github.com> wrote:

> The CREATE TYPE docs specify that the type name can be schema-qualified,
> so I suspect it's added to the default schema. Just checked and my
> search_path is "$user",public and I'm working as the bookbrainz user, so
> that's presumably where it's going. I'd say we want the entity_type ENUM to
> be schema-specific, so perhaps we should explicitly qualify it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/bookbrainz/bookbrainz-sql/commit/dc9cc62f8fcc2e61d15c7e98355705e405b3fa01#commitcomment-14889504>
> .
>


This is an implicit constructor, and you're not even using it. Please remove this even if the rest of the patch stays.


My comment is more implementation-focused: why hardcode `unsigned` instead of using a template?


You may want to `rez` the Ice Wall in your Quetzal test to future-proof it. Right now she doesn't check the ice type, but we might incorporate that in the future.


Had to move around to please the ```lint``` check.


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


fix keil armcc compiling report "Error: #29: expected an expression" (Add C99 support)


At this point we can probably drop this comment. Marc is still listed in AUTHORS.txt...


"built on Globalize"


I'd prefer you display 0, 1 or 2 decimal parts
 - `24h` -> `1d`
 - `12h` -> `0.5d`
 - `6h` -> `0.25d`
 - `8h` -> `0.33d`

use the `number` filter and find the wanted precision with
```js
var p = 2;
var days = d.asDays();
if ( (days * 10) % 10 === 0){
  p = 0;
} else if ( (days * 100) % 10 === 0 ){
  p = 1;
}
values[0] = $filter("number")(days, p);
```


Fixed in https://github.com/ylatuya/longomatch/commit/4d536fb982954ccffb13120e8a1297946e87c38a. I will squash it here after it's all done


@teeparham I think the old more explicit setup is better, now you might be including generated files with the gem.


I figure you mean the last pargraph of this:

https://tools.ietf.org/html/rfc4035#section-4.5

But then there's also this:

https://tools.ietf.org/html/draft-fujiwara-dnsop-nsec-aggressiveuse-01

But quite frankly I'd say the RFC is stupid here, and that draft makes more sense, hence we should cache everything that's signed regardless where we find it.


This is causing some problems in the test framework since there the GPI is not imported in full by default and so `__main__.__dict__` does not contain `Local` etc. I can fix it by changing `import __main__` to `import Ganga.GPI` but I'd rather not do that if not necessary.

What problem was this trying to solve and why does:
```python
if hasattr(stripProxy(self.backend), 'remove'):
    stripProxy(self.backend).remove()

if hasattr(stripProxy(self.application), 'transition_update'):
    self.application.transition_update("removed")
    for sj in self.subjobs:
        sj.application.transition_update("removed")
```
not do?


this should be a `POST`. You use `POST` when creating data, `GET` when you're reading.


This is getting more complicated - can we merge everything before this commit (addressing the minor issues), and get this and the remaining commits into a new PR?


No, it's not simple.  The build system references that name in many places to access files, it's a chore to change.


I am afraid that this test has nothing to do with SCE and datastreams, This tests evaluation of a simple OVAL that contains one sysctl_test.


This can also land with the other housekeeping commits.


`options` est le nom de variable, ce qui n'est effectivement pas très clair. Je vais les passer en mode "code" pour les isoler (c'est le cas pour subscribe aussi un peu plus bas).

Sinon, sur cette phrase l'idée était de lister les propriétés de l'objet. Dans la phrase originale les proprités sont le COD de need.
En français : "Il prépare également les propriétés de la chat room dont nous aurons besoin."


yeah, your version is much clearer, will have to change it


@LiyouZhou See the resulting photo at https://twitter.com/FoolsDelight/status/499362255495262208


This works and this is good! You just need to remember here that this view shouldn't be responsible for displaying another view (it's not a layout view, right?). Composite view in general is responsible for displaying leafs (nodes) of collection. You should trigger this data OR even do whole ajax outside of this view (probably 1 level higher).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8947](https://teamcity.mesosphere.io/viewLog.html?buildId=90129&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:09:19


As far as i understand status is required only in win version. So in posix version it could be removed.


ich dachte an eine allgemeine vorgabe anstatt jetzt konkret dieser fall. Ich denke es wäre generell sinnvoll wenn wir im fragment ordner nochmals den addon namen nehmen, damit man eben nicht so eindeutige namen nehmen muss (welche zu langen dateiennamen führen etc).

Ausserdem werden viele Addon entwickler nicht daran denken eindeutige dateinamen zu nehmen, die addon übergreifend eindeutig sind.


я вот тут не понял, ты присваиваешь значение ??? или сравниваешь ?


true. will extend the comment!


А на предыдущие версии платформы это повлияет? Те у кого нет 8.3.7 не отвалятся?


nice presentation!


Even with this function, we still need an `if-else` in switch to choose corresponding flag. So it will not make the code more brief.


nitpick: as usual our destructors are NOPs when you pass NULL to them, hence no need for the if check first, dns_packet_unref() does that anyway...


@vladsch, looks like missing C# files for this test. And it is better to avoid adding new test projects and put additional tetss into existing ones.


I'd change "#first-column" by "#first-column-first-row".


Great commit message. I think I can read it 10 times and still feel like it doesn't make sense, even though it actually does!


lgtm


Given the way we currently do things, pivot should have been part of the `kwords` passed to the `DynamicTypeFactory`.  But I want that to be fixed (see #29), so I'm happy to leave this as it is. I'll submit a PR for #29 soon (tm).


Yep, that should be better. Then we can iterate over `statement.variables`.

However, this line checks to see that the variable in the import is used in the file, so we need to keep something like this here. I'm on the fence about using jshint/eslint here, it has proven to be hard to maintain functionality that integrates with it (e.g. https://github.com/trotzig/import-js/issues/56).


dsadsa


How does this fix the test, and does this working only by setting it twice imply that setting a MemoryIcon is just unreliable?


cool!


lgtm.


In https://github.com/elexis/elexis-3-core/commit/b83089cc72c01c20b06aa9f1aaf86964f6eb9469 habe ich die Änderungen reingesetzt wie ich sie mir vorstelle. Kannst du damit arbeiten?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8948](https://teamcity.mesosphere.io/viewLog.html?buildId=90130&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:52


Effectivement, la phrase n'est pas claire. On devrait avoir 2 sujets différents.
"Une fois que la souscription à Kuzzle est établie, <cet attribut est>  utilisé pour enregistré l'objet KuzzleRoom correspondant."

Je mettrais plutôt "Once the subscription to Kuzzle is establised, used to store the matching KuzzleRoom object."


I tried changing this code but appears to make no difference to the dropdown in the back office which doesn't change on selection. Restarted site and recycled after making change.


Here it should be "#third-column-first-and-second-rows".


```
diff --git a/jerry-core/parser/js/bc/bytecode-data.cpp b/jerry-core/parser/js/bc/bytecode-data.cpp
index 5bf74d9..2e862af 100644
--- a/jerry-core/parser/js/bc/bytecode-data.cpp
+++ b/jerry-core/parser/js/bc/bytecode-data.cpp
@@ -130,12 +130,12 @@ bc_dump_single_scope (scopes_tree scope_p,
   const uint16_t var_decls_count = linked_list_get_length (scope_p->var_decls);
   const size_t bytecode_size = JERRY_ALIGNUP (instrs_count * sizeof (vm_instr_t), MEM_ALIGNMENT);
   const size_t hash_table_size = lit_id_hash_table_get_size_for_table (entries_count, blocks_count);
-  const size_t func_scopes_table_size = JERRY_ALIGNUP (((size_t) (func_scopes_count + var_decls_count)
-                                                        * sizeof (mem_cpointer_t)),
+  const size_t declarations_area_size = JERRY_ALIGNUP (func_scopes_count * sizeof (mem_cpointer_t)
+                                                       + var_decls_count * sizeof (lit_cpointer_t),
                                                        MEM_ALIGNMENT);
   const size_t header_and_tables_size = JERRY_ALIGNUP ((sizeof (bytecode_data_header_t)
                                                         + hash_table_size
-                                                        + func_scopes_table_size),
+                                                        + declarations_area_size),
                                                        MEM_ALIGNMENT);

   uint8_t *buffer_p = (uint8_t *) mem_heap_alloc_block (bytecode_size + header_and_tables_size,
```


And here "#first-and-second-columns-second-row".


Depricated


We need interface like `bc_get_var_decls_for_scope`


Make sure to follow the instructions here: http://issues.umbraco.org/issue/U4-7496#comment=67-24646
Including updating version in ClientDependency.config and clearing your browser cache after that.


数据库创建与使用

数据库创建

create database test on(name=testdata,filename='e:\db\td.mdf') log on (name=testlog,filename='e:\db\tdlog.ldf')

数据库创建附加参数

creacte database new_db on primary (name=new_db,filename='d:\new_db.mdf',size=5mb,maxsize=50mb,filegrowth=10%)

数据库的创建与维护

修改数据库数据文件的初始大小

alter database new_db modify file(name=new_db,size=15mb)

修改数据库名

exec sp_renamedb 'new_db','old_db'

删除数据库

drop database old_db

查看系统中有哪些数据库

exec sp_helpdb

查看test数据库定义信息

exec sp_helpdb test

数据库的分离、附加与备份、还原


The fact is that you are currently returning a vector for the order, and having an output parameter for the orientations, which I assume are in corresponding order. This is ugly. You should bundle the E's with the orientations in a single class, so that you can return one vector which contains E's and their orientations at the same time.

Also passing functions to the constructor of TravelingSalesman is very ugly.

I think the code will become a lot cleaner when pairing the functions into a class and the E's and the orientations into one class.

Whether this class is the same class as WayPoint is up to you, I just said that as a suggestion.


Really appreciated your efforts.


<html> & <head> tags are not mandatory, so you can skip them if you want.

See for example: http://testthewebforward.org/docs/test-templates.html#reftest-including-metadata


syslog_filter is never saved with the proper value - it's always shown as "EMERG" (0), but set to "DEBUG" (7)...


Also: you can't just update angular.js, you need to update angular.min.js, it's downloadable from the link above.


So, they aren't connected. When I do the same kind of thing you did, stores are perfectly independent, as they should. So it has to do with the way you setup the online store....

I've had some issues where the store was being null in the adapter. Maybe your case is the adapter using the regular store instead of the onlineStore.


Also "type="text/css"" is not needed in HTML5.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8949](https://teamcity.mesosphere.io/viewLog.html?buildId=90133&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:59


hey @ofZach, i was just wondering if this is a bit to far off regarding "re-interpretation".
i guess it could be a late night favorite, but maybe its kind of missing the point. what do think -
should i bring it back to a aesthetic much closer to the original artworks ?
also if you guys think whitneys are well covered with other scenes i'd rather move on an try a animated gif glitch for rosa menkman...