TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8124](https://teamcity.mesosphere.io/viewLog.html?buildId=86734&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:05:11


Linking phase fails if I remove the `--rocksdb` scons parameter:

```
g++ -o build/percona/mongo/mongod ... -lz -lsasl2 -lHotBackup -lsasl2 -lm -lpthread -lssl -lcrypto -lrt -ldl -lpthread
build/percona/mongo/db/client.o: In function `mongo::OpDebug::reset()':
/ssd/ps4mdock/git/percona-server-mongodb/src/mongo/db/client.cpp:453: undefined reference to `rocksdb::SetPerfLevel(rocksdb::PerfLevel)'
/ssd/ps4mdock/git/percona-server-mongodb/src/mongo/db/client.cpp:454: undefined reference to `rocksdb::perf_context'
build/percona/mongo/db/client.o: In function `mongo::OpDebug::report(mongo::CurOp const&, mongo::LockStats<long> const&) const':
/ssd/ps4mdock/git/percona-server-mongodb/src/mongo/db/client.cpp:543: undefined reference to `rocksdb::perf_context'
/ssd/ps4mdock/git/percona-server-mongodb/src/mongo/db/client.cpp:544: undefined reference to `rocksdb::perf_context'
/ssd/ps4mdock/git/percona-server-mongodb/src/mongo/db/client.cpp:545: undefined reference to `rocksdb::perf_context'
/ssd/ps4mdock/git/percona-server-mongodb/src/mongo/db/client.cpp:546: undefined reference to `rocksdb::perf_context'
build/percona/mongo/db/client.o:/ssd/ps4mdock/git/percona-server-mongodb/src/mongo/db/client.cpp:547: more undefined references to `rocksdb::perf_context' follow
build/percona/mongo/db/client.o: In function `mongo::OpDebug::reset()':
/ssd/ps4mdock/git/percona-server-mongodb/src/mongo/db/client.cpp:454: undefined reference to `rocksdb::PerfContext::Reset()'
collect2: error: ld returned 1 exit status
scons: *** [build/percona/mongo/mongod] Error 1
scons: building terminated because of errors.```


- "When calling a service with sensitive data, validate that the correct service is being called and not a malicious service."?
- "If you know the exact name of the component to which you want to connect, specify that name in the Intent used to connect."?
- "Another method is to use `checkPermission()` again to verify that the calling package has the permissions needed to receive the desired Intent."?
- "The user grants permissions to the app during installation."


I have to if I want the empty directory to be created on clone.
Yeah I guess it's redundant to have the same files exluded in both ./.gitignore and ./bin/.gitignore. I think I'll either make the bin one empty, or remove the ignore from the root .gitignore


Good to know about this linux quirk!


I'd rather not bother with reverting the doc-length changes unless there's a strong reason to do so.  As I said, 72 is actually the field-recommended number.  edX just hasn't caught up yet.  Our current standards require maximum of 79 right now, so 72 fits the spec.  And since the work has already been done to make it 72-compliant at this point, why revert it?

However, in the future, I'll stick with 79 for docstrings.


Later in the function (line 295).  I really wish Github was smarter about how many lines of context to show.


How did you choose this value? Have you got any resources saying it is the value to use?


you don't need to use `pull-pushable` here, because you are only adding one thing at the start, and not anything later. Since you have a single value, use `pull.once(ImageInput.canvasToPng(canvas))`.
If you had more than one thing and knew it beforehand, you can use `pull.values(array)`


these lines look one column off


@nabijaczleweli Is there even a way to run a program with Makefile on every platform?
Like detect an environment variable in the Makefile and use `run programname.exe` on windows?


Why does a domain have to be specified?  Spinners don't require domains.


>Before, I was simply doing the first half of the operation before the if check, and the second half inside the if check if animation.curAnim existed, but you said to change that.

You weren't, though. In`doFlipX = FlxMath.boolXOR(flipX, animation.curAnim.flipX);`, the initial value of `doFlipX` isn't taken into account - it's the same as `flipX != animation.curAnim.flipX`. Which is why I was confused why you didn't simply use an if-else.


I think either way is fine.


This is expected. That's why I call it hacky. :) But you compile Percona Server with rocksdb, right? So why would you remove --rocksdb parameter?


What if a domain isn't specified?  Why did you change this to not handle that anymore?


bad! My IDE keeps insisting on doing this


No example for this case?


If we manually set the config to this path, we ought to adjust the `dataDir` accordingly.


Your right.  Is it tabs or spaces around here?


Please try running behave with both analyzedb and minirepro tags, just to make sure.


Is padstring required to contain a single character? what's the behavior if it's longer? what about if it's empty?


Sure. Since it is identical, what about using a single common class (UNIX? POSIX?) and breaking out subclasses when changes are required in the future?


It just came out of the air.  What would be a better value?


Great idea! How often does this update the thumbnail, though? On every frame?


I fell that i missed something at the end. You write about first/rest/cons but i couldn't find them above. Maybe you should write the final my-map function to summarize above terms.


@hiteric, is it really a good idea to free memory in a sub-routine where it is allocated by its caller?  Seems maintaining this kind of code becomes problematic in the future.  Can we keep the allocation and free in the same location?


I'm not sure why GitHub is marking so many things as changed, the only thing I really did change starts here on #2288 and goes through #2303.

Everything else is still the same.


I think this is minirepro_UI


@Zorgatone I use [this](https://github.com/nabijaczleweli/Cwepper/blob/master/configMakefile) pretty universally (except the project-specific directories at the bottom.


double space. after "simulator"


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8126](https://teamcity.mesosphere.io/viewLog.html?buildId=86736&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:03:57


@ReubenBond That's outdated changeset, the latest one is here - https://github.com/dotnet/orleans/pull/1060/files.


Reword as "Failed to prepare X simulator to run tests."


+1. The test mentioned by Xin is very important.


I cleaned up the code from the first commit, and fixed the tests.
I added totalGCTime in order to color totalDuration when GC goes over 10% of total time.
Also added comments with short explanations of the percentages for each color


@xushengping, is it really a good idea to free memory in a sub-routine where it is allocated by its caller? Seems maintaining this kind of code becomes problematic in the future. Can we keep the allocation and free in the same location?


@nickcamel
I did **modprobe r8188eu monitor_enable=1** and it added mon0 interface but there is no wireless extensions on it. Therefore, I do not see all packets in network. What could help me? I am using TP-link WN-725N. I tried **ip link set mon0 up** or via ifconfig but it did not help either.


ок


Thought I had already done this. Damn


`[CWE-280: Improper Handling of Insufficient Permissions or Privileges](http://cwe.mitre.org/data/definitions/280.html)`


Yes it should be relative to the file's directory, otherwise i can't work in two projects at the same time with two different style guides. Also depending from where I open the file, the formatting style of that file would change, which is not something somebody would expect who uses this plugin the first time.

And yes, I think looking for a clang-format config once per format should be fast enough, `clang-format -style=file` does it anyway.


Oh this was me


@nbougalis Will do. I'll check if the environment variable `XDG_DATA_HOME` is set. If not, I'll set `dataDir` to CONFIG_DIR here.


I think this is normal.


Don't know, but it would be good if we looked into some research for that.


So for some weird reason GitHub is marking a whole lot more changes than have actually changed...

The only things I actually did change start at line #2288 and go through #2303.


added method createWebinar()


Just be consistent with rest of file.


I might just be a newbie, but what's the difference in variable with `:=` and "normal" `=`?


@nbougalis Actually, let's think about this. I'm not sure `/etc/opt/ripple` is ever a good place for a data dir.


capitalize "carefully"


@vanpire110, this looks incomplete, what about the success path from any of the other three cases?  I believe #637 takes care of this as well.


> Yep... Do you mind doing a new PR reverting?

Sure, can do - but would have to know what to revert and test for.

Are we talking about the entire commit, just the single line you quoted, or all `event.preventDefault`?

I ask, because I'd really like to keep it from swallowing too many events - it behaves quirky in combination with `TransformControls` in case it does.

What exactly is the (un)desired behavior?

The cursor? Or selection being possible? On double click, I guess? It would still be possible to select the canvas via mouse drag and that would have to be stopped by styles or handlers on higher level HTML elements, correct?


Was this change necessary?


NO. We said no more globals! Why isn't this string simply generated inside the lock?


https://developer.mozilla.org/en-US/docs/Web/Events/timeupdate

> The event frequency is dependant on the system load, but will be thrown between about 4Hz and 66Hz (assuming the event handlers don't take longer than 250ms to run).

But even if that's still too fast, I think I've also seen some throttling logic in `TabItems.jsm`.


Would this work as
`auto constexpr`?


"If no permission is set when sending a broadcast Intent, then any unprivileged app can receive the Intent unless it has an explicit destination"?


these packages are available on my linux system, why do we need to install Anaconda?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8128](https://teamcity.mesosphere.io/viewLog.html?buildId=86742&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:43


I updated my fork to this PR earlier this week. However, I ended up keeping but modifying withStyles to clean up my components. It looks like this now:

```actionscript
import React, {Component, PropTypes} from 'react';

function withStyles(styles) {
  return (StyledComponent) => class WithStyles extends Component {
    static contextTypes = {
      insertCss: PropTypes.func.isRequired,
    }

    constructor(props) {
      super(props);
    }

    componentWillMount() {
      this.removeCss = this.context.insertCss(styles);
    }

    componentWillMount() {
      this.removeCss = this.context.insertCss(styles);
    }

    render() {
      return <StyledComponent {...this.props}/>;
    }
  };
}

export default withStyles;
```


This sounds good to me, but CC'ing Jordan since he probably has an opinion.  @jrose-apple


Just an observation, but I'd be happy to have an alternate route in lita-wtf that matches "what is" in addition to "wtf".


commit


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23963/testReport/) for this commit**


"custom" is kind of ambiguous.  I would rename it (e.g. customControls) or comment what it is.


Hi Miguel,

I have to assume no one has it. So you don't have to install it if you
already have it.

Best,
Alexey
On Dec 4, 2015 4:10 PM, "Miguel de Val-Borro" <notifications@github.com>
wrote:

> these packages are available on my linux system, why do we need to install
> Anaconda?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ASvyatkovskiy/BigDataCourse/commit/70099eb2d8ef11b9befbc50fd34bdc3e61785cfb#commitcomment-14797172>
> .
>


@jaredpalmer cool, thanks for sharing! I'm also considering leaving a higher-order component for injecting CSS styles. Do you think this approach may have any drawbacks?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8127](https://teamcity.mesosphere.io/viewLog.html?buildId=86741&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 205 Build time: 00:11:45
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Ich habe in den VL-Folien noch etwas schönes gefunden:
"Einzelnes Objekt darf aber immer auch als einelementige Menge interpretiert werden." (VL 4 Folie 14)
Das macht vieles einfacher. Zusammen mit der neuen Struktur für Spieler im Klassendiagramm schrumpft die Komplexität enorm


#hw04
#Dennis Scheglov
# This file takes three points specified within the code that create a triangle. It then calculates this triangle's area and perimeter and uses them to find the radius of a circle inscribed in the triangle.


In JS, if something isn't defined, referencing it is an error.  The way to check if it's defined is `typeof Notification === 'undefined``.


:+1: :wink:


@igorcanadi  isolation testing


Yes, will do that.


@MatGB, my complain was not about broken save games and AI, I plan to make this PR long time ago.

It is about half done work. Removing some part means removing its stringtables too.  It is really unpolite to translates to leave unused entries. It will lead to extra work. It will take less then minute to make work done, but dead entries are still there.

I don't sure that old binary will work properly with last commit, but will try to launch and check if I can fix something.


The name is also very wrong. I understand this is a unique identifier for the reports but it can be confused with the pid too easily.

Another reason for not having this global is if a user disabled the reports. This variable is hanging there for no reason.


`i` not` i - 1` (since it is the number of elements to drop, not the index of the element as I first thought)


find mistakes that were made in dis text,


@Random-Liu
As for rkt, it actually only has pod level events for now, so once there's an error, all the container sync events will share the same error. I think maybe we can also propose something like

```go
type PodSyncEvent struct {
    Name string
    Event pleg.PodLifeCycleEventType
    Error error
    ErrorMessage string
    ContainerEvents []*ContainerSyncEvent
}
```

Which gives pod level runtimes more flexibility?


You should use an array here like `[4]C.Uint8{0, 0, 0, 255}`, not a slice. A am not 100% sure, but I doubt that slices can be stack allocated, and that means, that you will create garbage for the garbage collector per call of `SetDrawColorArray`. Garbage creation should be avoided if possible from calls that might get called in the rendering loop.


OK thanks, just wanted to make sure if it is really needed for some reason.


Yes, also see https://github.com/sourceryinstitute/opencoarrays/issues/19 for more details.


I don't think this is strictly limited to pods


TeamCity pull requests :: netty [Build 792](https://garage.netty.io/teamcity/viewLog.html?buildId=3804&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6220, ignored: 21 Build time: 01:25:46


TeamCity pull requests :: netty [Build 795](https://garage.netty.io/teamcity/viewLog.html?buildId=3808&buildTypeId=pulls_netty&guest=1) is now running


You're not checking if `Notification` is defined here, so it would blow up on page load.


Perhaps it would be better to check for the existence of the directory and if found symlink all shared objects you find to the correct location?  Thus if we add another shared object in the future we are covered too.


duplicate line


Good point, I will update.


TeamCity pull requests :: netty [Build 794](https://garage.netty.io/teamcity/viewLog.html?buildId=3806&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6230, ignored: 21 Build time: 00:40:39


TeamCity pull requests :: netty [Build 796](https://garage.netty.io/teamcity/viewLog.html?buildId=3809&buildTypeId=pulls_netty&guest=1) is now running


Yay for removing twisted (python2 only).


I'm not sure you should just make up error domains in apple's namespace. I'd rather have it be com.facebook.xctool.timeout or something


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8129](https://teamcity.mesosphere.io/viewLog.html?buildId=86764&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:47


По хорошему, `Выполнить` - это тоже `support.function`


Adding that if statement would work, but that assumes all the hosts you mention implement the `System` interface and we won't be able to make any changes to it. I think the current implementation gives both sides of the interface, consumers and implementers, the most freedom.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23964/testReport/) for this commit**


Verbols assigned with `=` will be evaluated each time they are expanded (that means, that for `SUBMODULES_GIT` ([here](https://github.com/nabijaczleweli/Cwepper/blob/master/Makefile#26)) I'd be invoking `git submodule` (which is slow as shit) each time I expanded the verbol ([here](https://github.com/nabijaczleweli/Cwepper/blob/master/Makefile#L29) and [here](https://github.com/nabijaczleweli/Cwepper/blob/master/Makefile#L60))), whereas verbols assigned with `:=` are expanded *once*, at assignment-time, and stored as text.


comment typo: definition


Impossible to detect is for server plugins. Players would even suspect the most undetected hacks like tracers, or parkourjump (never missing a single jump), but servers cannot.


And the `@` part before a command suppresses error/warnings/echoing or what else?


In step 3, which system am I supposed to be making the files on? The vagrant box we started up in Step 2 or the host system? I'm guessing the vagrant box, but it would be nice to be more specific. The only mention of vagrant is in the note saying there's a sync feature.

The note about the vagrant sync feature has a typo on the word synchronized.


Shouldn't `init_state_global` be reset (set to `0`) after we finish multiple `loader.ntrain` iterations?
It makes little sense to carry on knowledge from the future of the current line of text. Correct?


@nabijaczleweli: any idea to make the `$(RM)` work correctly on cygwin/Git bash?


Are global queues guaranteed to be concurrent?


Sorry, I need to revert this.  The change is breaking display on FF and Chrome (theme switching file doesn't get loaded).


@MarceloCajueiro I loved this tool! Thanks for the tip man :beers:


You may want to restructure your try with only the int(byte) in the try body and put the rest of the calc in a try else. See http://stackoverflow.com/questions/855759/python-try-else
This isolates the trouble spot the try is designed to hit:

try:
    int(byte)
except:
    return "N/A"
else:
    (all other calcs with byte)...


ah cool


Let's think about what we need to verify here:
- out.sql should have the DDLs of all the tables/views related to the query
- out.sql should not contain unnecessary DDLs
- those DDLs should be in correct order
- out.sql contains table stats (UPDATE pg_class ...)
- out.sql contains column stats if column stats exist before
- out.sql can be loaded to create a new database without error

I think the existing test does not cover the 4th and last point. Should we load the out.sql into a new database and check the output does not contain 'ERROR'? Or may be even run the original query on it? Then you automatically cover everything except the stats.


@lwahlmeier Thanks, I understand the issue now.  I will have a fix incoming here in a bit and will release as 4.4.1 at a minimum later tonight.


Hola Swift!


I would use mod.

    var hours = Math.floor(timeInSecs / 3600);
    timeInSecs = timeInSecs % 3600;
    var minutes = Math.floor(timeInSecs / 60);
    timeInSecs = timeInSecs % 60;
    var seconds = timeInSecs;

But it's the same thing.


edit: Changed project structure


If you bail in the middle here, the memory for the sd_path_list is lost as is the python objects which haven't been decremented.


Do we error out if the input query is pure garbage (not a sql)?


hey @temasek  I picked This commit In our Rom (Resurrection Remix)
But this option doesnt seem to stick with Selinux Enforcing
only works With Permissive
Any ideas?


s/Fake/FakeConfigMaps/


Could this be the problem somehow? I can't see anything else problematic.


what the fuck, it's the template from leetcode. I am the innocent one that simply did the copy and paste. WTF.


Wouldn't it be better to return a tuple instead of a list?  See PyTuple_New.


shouhua.


That's about what I do with the widget icons, or if I'm lucky Google will have some icon that'll work (Maps for Directions, etc.), which is how I ended up with these: https://github.com/AMKohn/iChrome/blob/v3/app/icons/currency.png https://github.com/AMKohn/iChrome/blob/v3/app/icons/quotes.png But, I'd look for something more for an app icon.


it's bool. fuck me.


@LeonYang5114 we need a blank image here.  generateFloatArrayTestImg creates a random image.  The idea is that we create a blank image, then add a sphere, to form a test image with an object in it.


The day is right, but the year was wrong.  Fixed.  Good eye, thanks!


Yes. I have added other cases. Will push later with other changes.


What if the query is like
```
EXPLAIN
ANALYZE
SELECT * FROM FOO
```


I guess only the `event.preventDefault();`.


Indeed I noticed these classes and was hoping to find some time to experiment with them (they are not standard, but since the code is already rather tied to windows...), the more so that I found another race condition (around `CCodeCoverage::m_thresholds`) that triggers less frequently, but would likely incur a bigger performance hit if fixed with a lock.


Can you add test cases for the following queries:
```
select 1+2;
select 1 from foo;
select generate_series(1,100);
select 1=2 from foo;
```


@andyli This should be fixed now.  I didn't re-run the failing travis build (because it was not the latest), but I did pull the updates manually.  We'll keep an eye on the next build.

Basically the `www` folder on the server is a git repo.  The hidden `.git` folder had some internal files owned by root, and so the `www-haxe` user that travis logs in with didn't have permission to do a `git pull`.  It was probably due to someone (probably me, but I'm not sure...) doing a git operation on the server while logged in as root.


Use `NewUpdateSubresourceAction` instead? like https://github.com/kubernetes/kubernetes/blob/master/pkg/client/unversioned/testclient/fake_pods.go#L100


Here we are creating memory for the output image.   I don't think we want to fill it with random values since we are using it as the output.  It might be harder to detect if something goes wrong.  Maybe we could just use the create op to get an empty image.


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 95](https://teamcity.labkey.org/viewLog.html?buildId=289526&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 12, passed: 35 Build time: 01:09:34
### Failed tests
```
org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

##### there are 2 more failed tests, see build details
```


I think this should be `webRequest.getServletContext()`. For whatever reason `getServletContext()` returns null in cases where a template is rendered with an explicit layout. Switching to use the webRequest fixes the issue.


I think we need to do something to the DumpQueryFromFile function such that it errors out instead of crashing when the input is garbage.


```
exit(path, state) {
  transformRequireCall(state, path.node, path);
  transformJestCall(state, path.node, path);
}
```


wo shi shabi..


Did you mean to touch this file?


Any ideas for ARMv6 (i.e. Raspberry Pi)?


bool. wo shi shabi.

What do you mean by specify by size? bool dp[10][10] is not good enough?


byte array


fuck me


Thanks John! 'unknownUnowned' is still an unfortunate tongue-twister. Replacing the 'unknown' prefix with an 'AnyObject' suffix might be easier to read, so you have 'swift_unownedRetainAnyObject' instead of 'swift_unknownUnownedRetain'.


lowercase configmap


I was also thinking it'd be helpful to name runtime entry points that are only available on ObjC platforms with 'swift_objc_' or something similar.


Looks like it's `disabled` here: https://github.com/18F/fec-style/blob/master/scss/components/_buttons.scss#L26-L29. Am I looking at the wrong styles?


The above 2 callse should probably stay as ```ops.create(...)``` instead of ```generateFloatArrayTestImg```


Anglicismes*

On 12/04/2015 09:31 PM, Bruno Pagani wrote:
> C’est la faute aux anglicisme !
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/M2-AAIS/BAD/commit/6b8229ea543a136e68805fbc7f4f821950c27bc2#commitcomment-14796327>.
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8130](https://teamcity.mesosphere.io/viewLog.html?buildId=86778&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:05:23


What you think of keeping the method signatures as just a pass-through of the visitor?

```
function transformJestCall(path, state) {
  var calleePath = path.get('callee');
  if (!t.isMemberExpression(calleePath)) {
       return;
  }
  /* ... */
}
```


How about updating to `e`, which appears to be the latest?


`http://developers.cartodb.com/cartodb-platform/` redirects to `http://docs.cartodb.com/cartodb-platform/`, which is also a 404.


I [still][1] think we want to drop pause/resume/signal until we have more clarity on how they will work.  For more background here, especially around complications with shared state on Linux, see wking/oci-command-line-api#3.  Alternatively, if we already have a clear idea of how these will work [in the absence of /run/opencontainer][2], I'd appreciate some comments in the CLI-spec PR explaining what the CLI should look like.

[1]: https://github.com/opencontainers/specs/pull/231#discussion_r45532412
[2]: https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/q6TYqVZOcX8


No need to return `undefined` anywhere, since return values don't matter in Babel 6 plugins.


Is this check redundant?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23966/testReport/) for this commit**


No need to return undefined anywhere, since return values don't matter in Babel 6 plugins.


I can take a look. Though I've still not managed to get a from blank clone working. I'm getting this:

```
cp bundle-env destroot/bundle/bin/bundle-env
chmod +x destroot/bundle/bin/bundle-env
/usr/bin/curl -sSL https://rubygems.org/downloads/rubygems-update-2.5.0.gem -o downloads/rubygems-update-2.5.0.gem
'/Users/orta/dev/mac/cp-app/destroot/bundle/bin/bundle-env' gem install downloads/rubygems-update-2.5.0.gem --no-document --env-shebang
Successfully installed rubygems-update-2.5.0
1 gem installed
'/Users/orta/dev/mac/cp-app/destroot/bundle/bin/bundle-env' update_rubygems
RubyGems 2.5.0 installed

=== 2.4.8 / 2015-06-08
------------------------------------------------------------------------------

RubyGems installed the following executables:
	/Users/orta/dev/mac/cp-app/destroot/bundle/bin/gem

chmod +x destroot/bundle/bin/gem
PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Applications/Postgres.app/Contents/Versions/9.3/bin:/Users/orta/dev/shell/ pod repo update master
[!] Unable to locate the CocoaPods.app application bundle. Please ensure the application is available and launch it at least once.
rake aborted!
Command failed with status (): [PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbi...]
/Users/orta/dev/mac/cp-app/Rakefile:59:in `install_cocoapods_version'
/Users/orta/dev/mac/cp-app/Rakefile:406:in `block in <top (required)>'
Tasks: TOP => app:prerequisites => bundle:build => bundle:build_tools => destroot/bundle/bin/pod
(See full trace by running task with --trace)
```


This should be all lowercase, shouldn't it?


Because we're currently getting candidate information server-side only. For the client-side code to get access to it, we either have to pass it through the templates or have the client request it via AJAX. If we update this to do more rendering on the client and less on the server, we'll be able to roll this back.


There is some variation in the code base for if this should be all lowercase or camel case. It would be nice to unify (separate PR).


self.predicates.is_empty() ||

#golfing


Fixes thymeleaf#358


This will cause an infinite loop. You replace the node, then it gets visited, and replaces the node, and gets visted.

You need to tag the node as having been seen.

```
exit(path, state) {
  if (path.node.seen) {
    return;
  }
  transformRequireCall(path, state);
  transformJestCall(path, state);
  path.node.seen = true;
}
```


I think we use attr_free* consistently in navit code, and use memory allocation functions to fill attribute members, when it's required. For example, code in our command language interpreter, command.c uses attr_free_content to free results of sub expressions. If we do not follow this contract, I expect location double attributes to produce crashes when accessed from our script.

Also, I have created a [pull request](https://github.com/mvglasow/navit/pull/1) to [fix](https://circleci.com/gh/mvglasow/navit/10) your issues with vehicle modules linking errors.


That script is expecting `pod repo update master` to run with e.g. a normal CP gem installation somewhere in that `PATH` it sets up. In your case it’s finding a `pod` binstub of a CocoaPods.app installation.


Quite simple, generating acf files is the key to loading games not made for Linux on Steam for Linux, removing this will display a "This game is not available for your platform" dialog.


All good now, thank you!


You already have this, so you can do:

```
path.replaceWith(
  t.callExpression(calleePath.node, args)
);
```

…where

```
var calleePath = path.get('callee');
```


s/state/overlay/


Go for it


do we test armv6?  this is only relevant for the sequence point tests that we do on jenkins, e.g. https://jenkins.mono-project.com/job/test-mono-mainline/label=debian-armhf/2965/parsed_console/log_content.html#WARNING1


Use the correct thingy!


I like it.

On Dec 4, 2015, 16:40 -0500, Alexis Beingessner<notifications@github.com>, wrote:
>
> self.predicates.is_empty() ||
>
>
> #golfing
>
>
> —
> Reply to this email directly orview it on GitHub(https://github.com/steveklabnik/semver/commit/b1479cf87f9ddba235b58b577bc98b5bf1638c8d#commitcomment-14797729).
>
>
>


@LeonYang5114 thanks for cleaning this up.  It is probably fine to just test the endpoints.  Actually there is also a flag called "imagej.ops.expensive.tests" (see ```ChunkerBenchMarkTest```).  Maybe you could check the flag, and only perform the complete test if the flag is true.


@benkruger


some goes wrong in this script. This is the output of query monitor (sorry not very readable, the errors are in lines 12 and 20):

SELECT DISTINCT ID, post_parent
FROM wp_2_posts
WHERE post_type = 'page'
AND post_parent =	get_next_button()
 wp-content/plugins/editor-next-button/editor-next-button.php:12
do_action('admin_enqueue_scripts')
 wp-includes/plugin.php:503	Plugin: editor-next-button 	You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1
SELECT post_parent from wp_2_posts
WHERE ID =	get_next_button()
 wp-content/plugins/editor-next-button/editor-next-button.php:20
do_action('admin_enqueue_scripts')
 wp-includes/plugin.php:503	Plugin: editor-next-button 	You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1


unversioned.ListOptions


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8131](https://teamcity.mesosphere.io/viewLog.html?buildId=86785&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:09:24


@bklare FYI


ValidateConfigMapUpdate


You can implement the Singleton pattern directly in the `AccountRepository` class! And you should do this!!!


You can still use dot syntax though. This'll do :wink:


Nice separation here.


I assume the `api.Pod` instances here need to be `extensions.ConfigMap`?


Nice!


Danke FireEmerald!
Hab's korrigiert.


@adrianluisgonzalez I saw you merge the pull-request, were you able to publish it to the snapshot repository?


@gfronza I'm sorry I didn't test the "new way" of integrating with labels but I guess it might works


it might be slightly cleaner to define a WORKQ_PRIO_INVALID constant or sth to abstract the -1 comparison below


E.g. You can cache the value of removed `contains`  call since the last time updateSubviewClippedStatus was called, check if it changed from `true` to `false` and only then update recursively


ah, this makes sense!


can you not just call free() here to balance the malloc() above ?


Why have 3 objects here when you should have only one?

The `GameManagement` class should have a constructor which gets a difficulty as a parameter. You only need a field like

```
AI computerPlayer;
```

which based on the difficulty passed in the constructor should get instantiated like
```
switch(difficulty) {
    case 0:
        computerPlayer = new EasyAI();
        break;
     etc. etc.
}
```


Maybe this can be simplified by not using `pod repo update` but just `cd ~/.cocoapods/repos/master && git pull` instead?


This is a great call, doing so now.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8132](https://teamcity.mesosphere.io/viewLog.html?buildId=86810&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:48


typo in class name


Judging from @burtonageo history, it looks like he is experienced with Github and this happened by accident. He is busy coding :smile: I've sent an email to get in touch.


Removed this because after switching from NSLinkAttributeName to NSForegroundColorAttributeName in WMFRelatedSectionController.m, the article name was no longer blue, because this was overriding the color.


these 3 if/else statements can (and should!) be compressed into just one.

You should have something like this:
```
if (difficulty != PVP) {
    computerPlayer.executeMove(playerLastMove);
    // additional logic which you need to do...
} else {
    // the pvp part
}
```


Empty try and catch statements are a HUGE no-no. There's exceptionally rare places where you should do this, and this is not one of them.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8123](https://teamcity.mesosphere.io/viewLog.html?buildId=86733&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:08


Sorry, I shouldn't call it a bug. But it is just not necessary to double assign the variable? Maybe it is more readable to simply change it to:
<code> int userType = Shortcut.CURRENT_USER; </code>


Let's see how things look after these modification + the serializable accounts save


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23970/testReport/) for this commit**


This fixed my problem, unsurprisingly, so far using `e` isn't working, looking into that now


Your odd magic numbers (-2, -3) are coming from the >= vs >. As for the width magic number I'm not sure, it's possible that World is miscounting the width of the map.


@talltom there was no need to do this as I have already merged master and 2.0.x in merge


Should use `#respond_to?`


Also, are you 100% sure that you need all these as class _fields_? maybe... keep some as local variables?


OK, I think I got this now, and for sake of completeness, I'll post my understanding for future reference.
Each of these `batch_size` long-lines are continuously fed to the network in the same location within the batch. So that the *status* of the RNN (associated with each line) is consistent when showing the `i * seq_length + 1` *symbol*. Although, this doesn't mean that the gradient will be able to propagate backwards for more than `seq_length` *symbol*s.


We shouldn't change passable at ALL, literally everything uses it. We only want to change the player's behavior.


@talltom would have been a lot easier if you'd done this API version update in the [merge branch](https://github.com/smart-facility/petajakarta-web/tree/merge), saving you the merge here.


I don't know how to use this exploit. :confused: How do I execute this exploit remotely? What will be my connect-back host and port? How will I enter the shell?


If i save accounts by the object (if i got the definition right) there will be one file/account(because every account represents an object) and i will have to have a method which i will call only when i want to add a new account right?


I'd just use a string.


I would do
```python
class Pushes(object):

   def __init__(self, **kwargs):
        self._push = kwargs
```
and then in your loop do

```python
for push_id in sorted(pushed.keys()):
   pushs_list.append(Push(pushes[push_id]))
```

Since we are not allowing the user to manipulate the JSON pushes (since we are just downloading and representing them) we should treat them as immutable (as much as possible).


Hmm, this is quite interesting property of items.


I'm not too sure, but I think you need a comment for Provider and AuthenticateRequest types


There are alignment options in the Python string formatting which would work here - you might as well switch to the new curly bracket template with the format method here too (work from the Python 2.6 documentation if you can, there are a couple of minor catches like positional insert points like ``{}`` must be explicitly numbered like ``{0}``).


id's won't play nice when you instantiate multiple instances.
If we aren't using them in the code we should strip references to ID when we add to the DOM


Are we going to uninstall xchat then?


No, you will actually save an array list of accounts -> one array list will be saved into one file.
Then, when the program starts, you will load that array list into the `AccountsRepository` and then, if any modifications are done in the meantime, you will save it again to file.


You could also just loop through smaller number ie 15 to 20, instead of 115 to 120... that will speed it up like 100 times I think... (instead of creating 115 by 115 by 115, volume, it will create 15 by 15 by 15)


Haha, no problem. I just ran through them all briefly to see if I could find anything wrong with them.


Same here loop from 15 to 35


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8125](https://teamcity.mesosphere.io/viewLog.html?buildId=86735&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:21


The clear log button in the manage log section defaulted to closed works.  See the example I posted earlier.


Мне кажется лучше сделать так: "Повторная отправка письма с активацией" без слов "Активация аккаунта"


No, they're just going to stay installed side-by-side.


and change i, 129, 129, to i 29, 29.


Currently, it doesn't crash, just print 'ERROR:  syntax error at or near .....'


development was merged into this hotfix branch by mistake, the branch was deleted and the code was properly redeployed


Another commit with repetitive code, looks like we could create Makefile creating this Makefile ;)

Besides - very long lines, hard to read, I guess we could use `\` to escape new lines.


TeamCity pull requests :: netty [Build 796](https://garage.netty.io/teamcity/viewLog.html?buildId=3809&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6230, ignored: 21 Build time: 00:40:44


Agreed.  I pushed an additional change to the branch with this fix.


Shouldn't this be: `containerData.Cmd = 'bash'` ?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23972/testReport/) for this commit**


Is it ok to put it on system classloader?


Trivial, remove trailing whitespace


Move the else one line up, like } else {


Apply all :D


Ok, I'll try that. I know how it should work just didn't know I can save an array of accounts. Thanks for the help!


Remember to adjust this code block also


This LGTM, good catch on style and correctness. Liz would be proud. :-)


Bad indentation, please review the file before pushing!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8133](https://teamcity.mesosphere.io/viewLog.html?buildId=86839&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:53


Same here!


And here!


can you change the name from `addFields` and update the docstring?  I'm always confused reading it whether `addFields` means "add these additional fields to the filter (remove them from the returned doc)" or "remove these additional fields from the filter (do not remove them from the returned doc)".  Especially when I call it like

    filtermodel(model='folder', addFields=...)

it seems like I am adding fields to a filter.

Similarly

    Extra fields (key names) that should be included.

included in the filter, or the returned document?

A better name is the hard part.

unfilteredFields?
additionalUnfilteredFields?
includedReturnedFields?
:strawberry:
fieldsToNotBeFiltered?
recoveredFields?
overrideFilteredFields?


Change made.  I wasn't sure if this function might be sometimes be called in a context where the semaphore wasn't created by dispatch_thread_semaphore_create.


Plugins don't extend `init_by_lua` so this is the only way of doing it.


Indentation is off


`pipeline2` could be more selfdescriptive.


Why was this removed?
Suggestion, add a comment here on github at your discretion


Hola, roaming_disable no debería ser: "No conectar a servicios de datos en itinerancia"?, se supone que es lo opuesto a roaming_enable por lo que me choca que la traducción sea la misma para ambas.

Un saludo.


Yes. That is a problem. Besides that, there can be comment lines such as single line comment -- or multiple lines comment /* */.
```sql
/*
 some comments here
another comment*/ EXPLAIN /* with detail */ VERBOSE --new line
select * from foo
```


Again, indentation, it may seem painful, but its a client request!!


This needs a better implementation, in case one is using the normal Windows MinGW on Cygwin too


Well, from the testing I done, it works as expected and does not break anything. I understand that it's not a nice thing to do, but so far I don't see any other solution how to create save getOrCreate in our environment.


Thanks. After 8ab1e2dd502fc7f37a67572699165e03f268c377, this assertion should always hold.


Better!! :D


can you update this function to have `@describeRoute` ?  I think it is the last endpoint in this file.


same here man.... when ı deleted string completely(libbinder.so for example) ı got a corrupted lib... but when ı edited string and change string "libbinder" to "libshim".. no corruption..all went good.. :+1:
but ım afraid we need to block libs to load libui.so or libbinder.so directly so we need to kill those strings.. because if we dont do that.. libcamera or libseccameradaptor will load "original libui" directly that doesnt include our "overlay instructions needed by cam... ı mean overlay.cpp" ...  but ı dont know how to delete those lines completely...because as ı said and as you experienced we gets corrupted libs :(


Name methods, document them!!


What are all the new files with the strange names that this commit is adding?


What are those other criteria?


it looks like everything from here to the end can be moved into a function instead of manually inlining this big ast


@xWASABI, can you eyeball this and see what I might be missing?


good to hear that you got it :+1:


I'm not sure the image panel should be included in this pattern - since it more closely resembles and acts like the pages/formns/styles panels. Images loaded within the editor cannot be cancelled once uploaded so this gives a false impression.

That is the only exception to the rule though I think - all other edit pages should have the cancel button.


logcat to show FC after this commit: http://hastebin.com/tuwinixefe.xml


could you comment this change since it is much less explicit now?


Start


It would be better to split the commit with the type of warning you are fixing, but ok.


`unsafe_load` is only weakly non-allocating


same here, add comment


Yes.  If you prefer that ordering I'll switch 'em all around.


I am wondering whether it is possible to iterate over `KeyValue` pairs in Python?

I know in Java we will avoid accessing map values by iterating over all keys.


This section seems to need an <h> tag.


What is the reason why this can'e be done in the resty lock then?


Why was this merged without a proper review?


Forgot to remove -b (branch) argument on git clone.


We no longer needs these.


read is not necessarily the inverse of unsafe_store


This line shouldn't be translated.


`solidfire`


login - entering the system


no, only _dispatch_get_thread_semaphore/_dispatch_put_thread_semaphore and the TSD destructor for the they manage use this


fixes #102


humn... parse a double and then cast to float looks like wasted effort. would strtof() be better?


Because it's the only way of doing it, not much to review - I am adding a parameter to the output. Same parameter can be used everywhere to track logs and error chain belonging to the same process.


Also shouldn't be translated.


This is not directly related to this PR. I probably should extract it to another PR.


`additionalKeys`, similar to what I said before, then name can be a bit confusing--but this already exists and I wouldn't want to change the API.

More importantly, I like the explicit description

    Any additional keys that should be included in the document for this call only.


`Debug` level rather than `Error`


The problem we are seeing is actually a change of `false` to `true`.  It is initially not contained so we do clipping on the child, and then later the view expands and then it now contains the child view so we weren't updating.  (though maybe that is what you mean since the original call is negated).

I can look at that, though it would require an array of information since it is per child.  I can look at this.  This didn't seem to have any perf implications.  Metrics were neutral.


Oops! My bad.


The day we need such a value to be used elsewhere, we will consider using a global, and by the time, we will have come with a solution for all the other globals Kong is already using. Until then, there is no reason for this to be a global.


As of this commit, something with `bin/grader` is broken... I can't get it to run.


Verify it's a legit type?


> Until then, there is no reason for this to be a global.

As I already said, there is no other way of implementing this. It needs to be a unique value shared across all the workers.


Same as above, debug level.


OK. I'll take that one out. What about Files, though? Doesn't that have 'replace file' and stuff too when there are missing files?


```
syslog.log({signal = "ping", requests=reqs, unique_id=utils.random_string()})
```


Looks like it might be helpful if you could pass the array of app identifiers to a single sigh call


Oh, checking is here. But not called?


If the user selects "debug" for the (new) Image Type option in the Radiance Measure, user gets one image showing the daylight distribution and ingress for each window group, and for each shade condition (if applicable). The view is a hemispherical fisheye, from the primary daylighting control. e.g.:
![screen shot 2015-12-04 at 3 12 01 pm](https://cloud.githubusercontent.com/assets/3161332/11602703/8bfed39a-9a99-11e5-9834-da339af7f158.png)


That sounds good to me. I suggest "GenericUnix". (It almost even works for OS X at this point, but no one's tested that.)


> It needs to be a unique value shared across all the workers...

...that uniquely identifies the process. It needs to be created when Kong starts and used from then on.


"full polymerization" ??
erinnert mich an den Chemieunterricht...


Cool, thanks, that was fast.
Looks good.


classic


forget about it, I just recognised this is only working on the edit page plugin. Any way to catch the error and not have it failing?


So far, no other module uses this value, and I doubt there will be, and if there is, like I said, but the time I hope we will have a better handling of the variables Kong currently stores as globals. The code I posted does the same and does not use one more global.


yes, it was intended.


Probably we should query for some state here instead of sleep?


That's a great solution!!!!


I need to use a value that uniquely identifies the master process in the logs, that will be used by every worker when sending the reports.

The code you posted doesn't do this, because it generates a new value every time.


mrmrmrmr this is weird


Factoring out retain/release into a single set of operations that take the ReferenceCounting is definitely something that I've wanted every since I first worked on that code. Thanks a ton!


TeamCity LabKey :: Trunk :: Premium :: Git postgres 9.4 [Build 823](https://teamcity.labkey.org/viewLog.html?buildId=289536&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 29 (9 new), passed: 260 Build time: 01:40:09
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testImmuneSpaceStudySubset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudySummaryWindow: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCards: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testNavigationDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testBackDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCardStudyLinks: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testFinderWebPartAndActionShareFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testRefreshDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

##### there are 19 more failed tests, see build details
```


TeamCity pull requests :: netty [Build 797](https://garage.netty.io/teamcity/viewLog.html?buildId=3811&buildTypeId=pulls_netty&guest=1) is now running


@jckarter But AnyObject is native-refcounted on Linux, so that's not a great suffix either.


Better check for devices since sometime it would result in e.g `/dev/xxxp1` rather than `/dev/xxx1`, though I saw that for loopback device mostly.


@slavapestov The entry point doesn't have to exist on Linux. What if it were `swift_objc_unownedRetainAnyObject`?


The insertion of this function seems unrelated to the rest of the commit? Is it here just because?


I see. Then store the value as a local inside this module.

```
local unique_identifier =
```

And define it in the mutex inside `create_timer`. There is still no need for a global here.


No, oops.  I grepped TOO WELL


Rename class and file to match the test case class name of system under test, `TalksController`. Class and file name should be `TalksController`


Using "unknown" as a suffix instead of a prefix might work well enough.
`-swift_unknownUnownedRetain`
`+swift_unownedRetainUnknown`


@pfalcon I think you need to use MP_ROM_PTR here (see eg lines 148, 149 of same file).


It needs to be the same value across **all** the workers.


```php
// Create our fake talk
```


Old code...


although while I'm sure this rule is correct, I don't understand what `tun_src=0.0.0.0` means


Since waypoint_radius is AP_Float, get() will return a float. I think the mistake is in the printf attribute... you shouldn't need to cast to double because our printf implementation does use float.


i dont think it really matters does it? as long as the function is avaiable for it to call it should be fine? which if it loads libshim properly then it will be? idk maybe @shantur can provide some insight.


Fair enough hen use the ngx.shared.DICT API. Nothing justifies globals.


Hmmm, true. I think the files pane is OK to have the cancel button though - I can live with that even though there's some inconsistency.

Maybe I should merge the mammoth PR when this is all done?


Works great!


How far are you with this project?


I don't think I understand the changes to this file - what's different about the way completion queues work between the two stacks that these five lines (and the similar five lines also deleted elsewhere in the file) have to go?


Check out my Java repository


It would be great to have full PSD support but I know how complex it's layer structure is. I've delved into it myself in the past. It's been a long awaited feature in FreeImage for years, I also wondered why the devs gave up on it.

I tested several of my photos in RAW with the new PSD export and they all load fine in both Photoshop CS6 and Lightroom 5.


TeamCity LabKey :: Sprint :: Premium :: Git sqlserver 2014 [Build 1](https://teamcity.labkey.org/viewLog.html?buildId=289544&buildTypeId=LabKey_Sprint_2_LabkeyPremiumTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:06:04


> use the ngx.shared.DICT API. Nothing justifies globals.

This is a terrible idea. You are suggesting that in `init_by_lua` I need to store a property in a shared dictionary, that will then be retrieved by the workers, instead of doing a table lookup (which is what happens with global variables) that will be faster performance-wise (instead of accessing the shared dictionary, which will also do a lookup anyways).


The package uses /etc/php/7.0, check the dir on PNX qa.


Right, I borrowed that part from Amit's version – should have read more thoroughly.


No apcu package.


Then MP_ROM_PTR is not ROM ptr, but "ptr to one of uPy's sections (vs heap)". Fixed, though mistakes like will happen for a while ;-).


The part that fills the buffer isn't generic, but yes, this can definitely be refactored to generate less code.


No memcache package.


No twig for php7.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8135](https://teamcity.mesosphere.io/viewLog.html?buildId=86851&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 204 Build time: 00:05:05


@chuckbook I tested the LSE to LSI transition (that's what you mean, right?).  It works very well, thank you!  I don't even need the black magic, there is no noticeable delay upon startup.  The issue with DFU is that the RTC does not start but the registers seem to say that it is actually enabled and running (which makes sense given @dhylands' observations).  When I do the automated programming and testing of fresh pyboards I include an RTC test.  This test runs after the DFU without a physical power disconnection (because that would require too much human intervention).  So I need a way to force the RTC to initialise, and then I can test it.  I'll get to the ADC stuff soon.


@edx/devops this  commit implements a change to our role inclusion strategy that we have discussed.  Role inclusion is explicit in plays rather than via ```meta/main.yml```  The operating theory is that we'll use plays for composing roles and ```meta``` for "extending" "abstract" roles in the fashion of edx_service.

@stvstnfrd @antoviaque @tusbar would you also chime in here as this may affect your plays.

The reason this is related to the docker PR is that it enables use to have more flexible plays depending upon the target platform.


I don't think this commit deserves 15 comments - it's pretty straightforward. The only better option would be the plugins being able to hook into the `init_by_lua` and provide the global variable there, so that the value is only generated by the plugin that uses it (unless we decide to use it everywhere, so in that case needs to be moved out again).


I think this commit includes three things that I'd like to see decoupled: (1) whole-file deletions of the C code, (2) tweaks to the cython code to get it ready to be swapped into place of the C code, and (3) the actual swapping. Could I ask you to break it into (2) in one commit, then (3) in another commit, and let's not bother with (1) right now at all? If the point of exposure to the layers above is just `_types.py`, `_low.py`, and `_intermediary_low.py`, could we have those files be duplicated at the top of each of the C and Cython stacks, so that the switch is just a matter of changing `from ... import _c_intermediary_low` to `from ... import _cython_intermediary_low`? Right now it kind of looks like there are behavioral difference between the stacks intermingled into the switch from one stack to the other; I'd like to see those explicitly.


LGTM, thanks for the additional context.


Wow, look at all these extra lines.  They look like they are asking for another test were we call `set_customization_spec` with the name of the spec not the object.  :smile:


I'm not sure what that means. That there are cases where it might allocate?


One comprehensive solution is to make a dedicated system process/thread which takes care of IO and maybe other low level things.  Then it can complete independently of a blocked irq.


> Having said all that, @geoffthemedio, I don't think this should have been merged directly into master, as far as I can tell the AI is broken and unable currently to build ships with the new system, I'm on turn 121 of a testgame built with this commit and not a single AI has built any warships yet.

> @Morlic-fo , IIRC the AI ship design system was yours, is there a chance of a quick fix from someone that groks Python, or is it a bit more serious?

@MatGB I can not reproduce your problem. Using the latest test build and current github-files, the AI is able to build  military ships. Either there is some C++ change relevant to the problem from after the latest test build (I couldn't find anything which seemed relevant for the AI) or there is some other issue going on. Unfortunately, I can't compile at the moment (or any time this remaining year for that matter).

Could you provide an AI log? As relevant information is dumped only every 10 turns, please make sure that it includes a turn dividable by 10 (e.g. 100, 110 etc.) if loaded from a savegame.

Not sure how to teach the AI about the tech-upgrades, right now these do not even work with my binary. But I guess hardcoding them should be easy and work as an interim solution...


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 85](https://teamcity.labkey.org/viewLog.html?buildId=289548&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:06:05


Feel free to revert this. I reverted my use of the library so this change
is moot now.
On Dec 4, 2015 4:16 PM, "Michael Wisely" <notifications@github.com> wrote:

> As of this commit, something with bin/grader is broken... I can't get it
> to run.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/brhoades/grader/commit/f5312a3aecf4690a11cba0a316a0293944cb8e93#commitcomment-14798399>
> .
>


It is actually not, since ngx.shared.DICT access are *extremely* fast (I believe faster than an ngx_lua global). They are also considered the *right* way of sharing values between workers, while globals are *very much* not recommended, and it heavily insisted in ngx_lua's doc not to use them.

The introduction of a new global *does* deserve a significant debate since Kong should reflect all the best practices of ngx_lua development to ensure it's stability and performance.


either way i know how to remove one as well but i think we still need it to load libui because our shim doesnt provide every function does it? I thought it only expanded on whats avalable.


When dealing with Java stuff, it would be nice to create Scala-idiomatic wrappers. Let me show you something that you could use in the future - I don't think you need to refactor this now, but I think you'll like what I come up with.

```scala
// First, let's create a nice constructor for our error case class
case class TokenParsingError(e: Throwable) extends Exception(s"Failed to parse token ${e.getMessage}", e)

// next let's create a wrapper for Java stuff
def wrapFuture[A](a: A, onFailure: Throwable => Throwable): Future[A] =
  Try(a) match {
    case Success(v) => Future.value[A](v)
    case Failure(e) => Future.exception[A](e)
  }

// next let's create the JwtParse function
def JwtParse(tokenStr: String): Future[JWTClaimsSet] =
  wrapFuture(PlainJWT.parse(tokenStr).getJWTClaimsSet)
```

We could even make our `wrapFuture` method account for `null` values, too!

```scala
def wrapFuture[A](a: A, onFailure: Throwable => Throwable): Future[A] =
  Try(a) match {
    case Success(v) if v != null => Future.value[A](v)
    case Success(v) => Future.exception[A](new NullException("jwt parsing returned null, so sad, bad api"))
    case Failure(e) => Future.exception[A](e)
  }
```


Xin, please don't do that. Running clang-format makes it difficult to use git-blame. If you are working on some code then you should refactor/cleanup that area, but running clang-format on large files does more harm than good.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8138](https://teamcity.mesosphere.io/viewLog.html?buildId=86855&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:04:03


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8139](https://teamcity.mesosphere.io/viewLog.html?buildId=86856&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:14


I think we need to do the entire operation inside the lock - otherwise we are subject to Check-Then-Act concurrency bug.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8140](https://teamcity.mesosphere.io/viewLog.html?buildId=86857&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:11


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.4 [Build 24](https://teamcity.labkey.org/viewLog.html?buildId=289538&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 12 (2 new), passed: 35 Build time: 01:19:31
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProductsSearch: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSLoginTest.testSessionTimeoutIntercept: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

##### there are 2 more failed tests, see build details
```


Er, got ninja'd so title makes no sense.


@jckarter that sounds good, also I like @gparker42's idea.

Also, OSS people will see how much bikeshedding goes on around here :)


@MatGB I have same 'version' as Morlic-fo and have same effect.


`http://ftpmirror.gnu.org/gcc/gcc-5.2.0/gcc-5.2.0.tar.bz2` seems to be missing, but
`http://gnu.mirror.iweb.com/gcc/gcc-5.3.0/gcc-5.3.0.tar.bz2` is up... I'm gonna switch this in unless anyone objects


yes man our libshims.so provides every function because all the other libs are whole_statically_linked :+1:


No - it was nothing like that!  Rubocop forced me to add those lines! :laughing:


TeamCity pull requests :: netty [Build 797](https://garage.netty.io/teamcity/viewLog.html?buildId=3811&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 5812, ignored: 21 Build time: 00:14:44


Comment typo: boundary


TeamCity pull requests :: netty [Build 798](https://garage.netty.io/teamcity/viewLog.html?buildId=3812&buildTypeId=pulls_netty&guest=1) is now running


Doc string needed.


fixed some git commit issues


TeamCity pull requests :: netty [Build 795](https://garage.netty.io/teamcity/viewLog.html?buildId=3808&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6215, ignored: 21 Build time: 01:20:14


TeamCity pull requests :: netty [Build 799](https://garage.netty.io/teamcity/viewLog.html?buildId=3813&buildTypeId=pulls_netty&guest=1) is now running


I recommend the `git-clang-format` script to just format areas that are already being changed in a patch.


But it does sound very spaghetti, and performance is not an issue here because pings are generated only once every hour anyways.

In ngx_lua global variables are not reccomended when:

> * misuse of Lua globals has very bad side effects for concurrent requests when these variables are actually supposed to be local only,
* Lua global variables require Lua table look-up in the global environment (which is just a Lua table), which is kinda expensive, and
* some Lua global variable references are just typos, which are hard to debug.

The only reason could be the performance issue, but it says nothing about the performance of global vs shared dict, it only mentions that in a global vs local variable access use-case (and of course local access will be faster). We can test it, and see how much does it take in a shared dict vs global variable only.


```asm
...
dbbw $10, $39, .Removed
dbbw $10, $24, .Removed
dbbw $10, $21, .Removed
.Removed:
```


Heads up, we hit a case where a lib monkey-patches `collect_responses` that this commit broke: https://github.com/Mange/roadie/blob/v2.4.3/lib/roadie/action_mailer_extensions.rb#L12-L17

Just a heads up for anyone else on an older version of Roadie or some other lib that patches this directly.


and yes...maybe you are right...maybe deleting libui.so string(blocking to load original libui) is not required...  because as you said needed functions are available already...
but  not %100 sure... it also can be required...
tests will show us.. :+1:


Thanks!  Yes, we need a build that has OBJ_REPR_D enabled (or at least something to check this stuff).  MP_ROM_PTR is a "ptr stored in ROM", like MP_ROM_QSTR is a "qstr stored in ROM".  But these pointers to MP_STATE_VM will eventually need some special handling because if you try to make the state something other than a global object, these lines don't compile (because MP_STATE_VM is unknown at compile time).


Oki doke. I'll just revert the Images panel then.

The Sections panel is tricky, btw. It'd be nice to make it work like the others (so if you hit an error, it stays on the Edit panel) but the way it's coded means this is way more difficult than it should be. For example, it loads the defaults in if you empty the name and hit Save. And if you create/edit a Section and give it the same name as an existing Section, it throws an error, but loads the existing Section's details into the panel for editing! Some may call this a feature...

So we'll probably just go with a cancel button, but errors will throw you back to the list panel.

One other thing I just noticed:

* Edit your default Section and save it after writing in a few words for the Description.
* Create a new Section. Notice the description from the default Section is pre-loaded into the field.

That's a by-product of the SELECT * FROM ... in the Edit panel code, which pulls the details from the default Section. In days gone by, that just pulled in the page and css. Do we want the description to be pulled in as well, or should it be blank when creating a new Section? I'm inclined to think that blank is better, but could do with a second opinion.

Regarding the PR, is there any need for a PR at all? Surely since we're virtually up-to-date with pulling master forward into the admin-layout-update branch, a simple:

    git checkout master
    git merge admin-layout-update
    git push

will be enough? Maybe there's some Travis stuff going on that I'm not aware of which requires a pull request?


Ah sorry, you're right. I totally missed that, you know, fridays :-)
Will change this. Thanks.


Ah, yeah. So what about restricting it to winesteam ?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/23976/testReport/) for this commit**


_bs_ is not referenced outside the `SetDrawColorArray` function according to the output of `go build -gcflags '-m'` so it should be stack-allocated.


Port to JK2game so JK2 compiles too?


Curious, why the setting of the pointers to NULL in this error check?


This is out of sync with what it actually returns.


I don't think we need this `bindCallback` call at all here anymore. We can just use the predicate directly below (with `tryCatch()` or course.


"1 2 3 4 1 2 4 3 2 3 1 5 6 1 2 7 8 9"
	|> String.split(" ")
	|> Enum.chunk(3, 1)
	|> Enum.reduce(%{}, fn(tri, acc) ->
				Map.update(acc, Enum.join(Enum.take(tri, 2), " "), [List.last(tri)], fn(val) ->
					val ++ [List.last(tri)]
				end)
		 end)


perhaps an explanation for why you're reverting the change? you're almost always better off using strlcpy(), the use of sizeof() would make it explicit in size, is that a problem?


We are returning an error here without releasing the sd_name_list...


Yes, that's correct. I oversighted it.


It's more a matter of following good development practices (which means avoid globals if we can, and we can) rather than performance. You are the one who mentioned performance first, I simply replied detailing the performance implications.

Kong (especially the core) should follow the best practices of ngx_lua, (and Lua in general) and both mention not to use global variables for various reasons, I believe not polluting the global scope is a good enough reason by itself. People will read Kong's code, and take example on it to write their own plugins (this *already happens*, people copy paste a lost of our code to adapt it to their needs for their plugins). We need to lead by the example. Using globals is, imo, a bad example when it can be avoided.


I updated my gem to this version, and started having trouble with my urls on my 404 pages since I was using `controller_action_path` instead of `main_app.controller_action_path` throughout the header on my site. That may have been bad form on my part, but since my site is only one module, it was annoying to have this break unexpectedly.

Rather than go change everything to include `main_app.`, I instead added a helper method to the `ExceptionController.rb` file.

    def method_missing(method, *args, &block)
      if (method.to_s.end_with?('_path') || method.to_s.end_with?('_url')) && main_app.respond_to?(method)
        main_app.send(method, *args)
      end
    end

And I also added `helper_method :method_missing` to the top of the ExceptionController. If anyone else has a similar problem after updating, this is a hacky, but effective solution.


There's a typo here. I imagine this won't compile.


If you'd rather keep them in the class definition so they don't get lost, you can do something like this as properties:
```
metric_name => { via => '__self__', to => 'name' },
metric_value => { via => '__self__', to => 'value'},
```

Then they'll also work as params to ```create()``` and ```get()```


return value not checked, check and set rc to library error?


Well I guess the way I've done this in drivers in the past is that the interrupt which want to do the potentially blocking thing would put it on a queue with a callback function. Then when the current sdcard operation finished it would call the callback, and start processing the next request. Eventually the Mass Storage request would get processed and its callback would get called.

Having said that, the above adds quite a bit of complexity (although if its generalized the same queues and data structures can be used across numerous devices) and assumes that the Mass Storage is able to deal with async stuff. I'm pretty sure it must be able to, because when the linux usb gadget driver acts as a mass storage device it definitely doesn't wait for the operation to complete inside any interrupts.

There are probably other ways of dealing with this too.


- "If no permission is set when sending a broadcast Intent, then any unprivileged app can receive the Intent unless it has an explicit destination."?
- second sentence "An attacker could take advantage of an Intent that doesn't have any set permissions in the following way:
  - Create a malicious app that includes a component with the same name as a legitimate component
  - As long as that name (or namespace) is not already in use, the malicious app will install on the target device
  - Extract sensitive data from the broadcast Intent sent to that component name"?


In this case I think the global does the job. Simple en reliable. If there are more of these to come, then another approach can be added later to improve on that. Let's not optimize prematurely (also a good development practice).


Comentario de prueba: ese teléfono parece ai-fon


"Cannot open %s"

I would fetch the errno, convert to text and put that in the error message too.


I think it shows laxity on code quality and opens the way to adding more globals in the future.


FindConstructor() should be able to find the protected default constructor of ParseObject and use that. I'll see why this is failing, would you mind adding this as an issue? It makes it much easier for us to track.


What is the sense of those doubled lines?


I think that @pfalcon is saying is that under linux, the pointers aren't really stored in ROM. They're just pointing into RAM outside what gets gc'd.


I'll take a look soon at providing a windows #ifdef for it
for now you could simply remove the header and any calls to htole since on little endian machines (x86) they are nops


Yes.
> Returns a system-defined global concurrent queue with the specified quality of service class.

Ref: https://developer.apple.com/library/ios/documentation/Performance/Reference/GCD_libdispatch_Ref/#//apple_ref/c/func/dispatch_get_global_queue


r+


Domain of the error isn't used anywhere below but I will update just in case.


@adelq thoughts on what to do with this?


nit: trailing whitespace on this and line above


I like the idea of hooking the plugins to `init_by_lua`. That can be combined with the event bus. Plugins would be reduced to event handlers, with a first call from `init_by_lua`.


should use `usize` for things like this (counts, positions, etc). This will also save you from doing `position as u32` (should generally avoid doing casts)


shouldn't that be a whitelist?
https://hg.adblockplus.org/easylist/rev/2d0b508d7923


@zurbchris I'm guessing **Blurb** is test code?


Had to download the bleeding edge version of theano to support 'relu' activations and to resolve the maxpool error with convolutions


just that you know now we define HAL_GPIO_*_LED_PIN per board. So if you have board LEDs you have to define them here, too.


Would you be more comfortable with renaming it and storing it inside the `kong` global? seems more logical to me.


- "Use permissions to protect Intents in your application."
- "Keep in mind that when sending information via a broadcast Intent to a third party component, that component could have been replaced by a malicious install."


Looks good to me :)


Yes, the other ```Public``` service is still there, and it still returns the same as it used to, including the timestamp. But I don't need it just to open the project in Snap, and the ```Raw...``` family of services bypasses uri-encoding on the backend side, which has been causing a lot of the load. So getting rid of encoding (especially large) projects enables us to serve more projects and more quickly. That's the essence of our recent backend activities.


You need to replace " to ', to make it work.


Yes, that sounds like a less drastic way than making an entire separate thread/process.  But it's not a big priority now.  As you say, best thing is to just disable MSC completely :)


TeamCity LabKey :: Sprint :: Community :: CDS postgres 9.4 [Build 2](https://teamcity.labkey.org/viewLog.html?buildId=289540&buildTypeId=LabKey_Sprint_2_LabkeyTrunkCommunity_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 11, passed: 36 Build time: 01:20:52
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.tests.CDSLoginTest: <no details avaliable>

org.labkey.test.tests.CDSLoginTest.testSessionTimeoutIntercept: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProductsSearch: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

org.labkey.test.tests.CDSSecurityTest.verifyFirstTimeUse: <no details avaliable>

##### there are 1 more failed tests, see build details
```


:+1: to both @nadavrot and @benlangmuir.

If you have clang-format in your path, you can do:
  git add <files or paths>
  git clang-format
and now your working directory has the clang-format generated changes available to diff against your original changes which you've staged.


This will panic if they never go into the basement, so in this case it is not a good idea to unwrap and you should instead handle the error. Although I don't think this function is the place for that error handling, so you should just return an Option (which you conveniently already have).

In cases where it is okay to panic, you should pretty much always use `expect`. There's no reason not to and it just gives you better error messages and is self documenting (since the message can explain why you're expecting the value to always be there)


// FIXME: Move this to another class as there is a lot more we should do here


`[CWE-925: Improper Verification of Intent by Broadcast Receiver](http://cwe.mitre.org/data/definitions/925.html)`


Gotcha, good call.


There were cases where failing tests without `cancel_all_calls()` during `tearDown` would infinitely hang due to bugs I had to filter through during some of the Cython work. Adding this in made it possible to debug those bugs. Whether or not it should be in this commit is a different question, but pulling it out now seems unnecessary to me.


For the sake of argument regarding performance (useful for another use-cases too), I have created the following application:

```nginx
worker_processes auto;
error_log logs/error.log info;
daemon off;

events {
  worker_connections 1024;
}

http {

  lua_shared_dict store 100k;

  init_by_lua '
    ngx.shared.store:set("hello", "world")
    hello="world"
  ';

  server {
    listen 9000;

    location / {
      access_by_lua '
        local dict_start = os.clock()
        local value = ngx.shared.store:get("hello")
        local dict_duration = os.clock() - dict_start

        local global_start = os.clock()
        value = hello
        local global_duration = os.clock() - global_start

        ngx.say("Shared value is "..value.." (took "..dict_duration..")")
        ngx.say("Global value is "..value.." (took "..global_duration..")")
        ngx.exit(200)
      ';
    }
  }

}
```

The results are in the order of:

```
Shared value is world (took 5.0000000000015e-06)
Global value is world (took 0)
```

Which makes the global access faster than using the shared dict.


I'm digging your use of `reduce` method :)


:laughing: yep


we need to adjust the build.gradle file to explicitly depend on Guava if you want to use `Strings`


Having a `kong` global which at least namespaces those values is something we have also been talking about, and *somewhat* fixes this. However, it is definitely not a real solution.

The correct way of doing it would be to store values we consider "global" inside a local variable in the `kong.lua` module.

Those values would then be passed along all plugins when they are being executed. If a value needs to be shared accross all workers (such as this one), it needs to be in the ngx.shared.DICT.

It is what I described in those 2 issues: https://github.com/Mashape/kong/labels/task%2Fcode%20quality


And why return the `repository` info? Seems out of scope of this module.


* TODO: rewrite this as it is doing way too much and is very messy now.


Well, not just under Linux. On any port, MP_STATE is currently statically allocated at compile-time (in .bss or in .data). Based on that, MP_OBJ_TO_PTR/MP_OBJ_FROM_PTR is used for heap-allocated objects, and for all other objects (and these other can be only statically allocated), MP_ROM_PTR, regardless whether objects are r/o or r/w.


Looks good.


better to use verb in func names


nevermind, it already includes it for the Preconditions calls.


no problem :-)


Class UpdateGitMirror is missing a docblock.


- "concerns" to "issues"?


Need to add this info? : "MetaDataKeys that match the operations excluded will be removed before returning them in the getMetaDataKey invocation." https://www.mulesoft.org/jira/browse/DEVKIT-1964


Yep! That and sometimes
```sh
git commit
git clang-format HEAD~
````
are the workflows I use.


You needn't define operators other than `==` and `<`; the standard library supplies extensions for the rest (`!=`, '>', '<=' and '>=').


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8141](https://teamcity.mesosphere.io/viewLog.html?buildId=86874&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:05:42


That... might actually be debug nega-cruft. Pretty sure it's nega-cruft.


This is a good place for `expect()` since the program is useless if the file isn't there


// FIXME: Delete tar file if it exists


exit 0 # FIXME: Not sure why I need this, otherwise it fails


I am not against improving this - given the current code this was the best way to implement this commit. If we introduce a local variable into `kong.lua` (+1) then we need to move it inside there.


I'll fix the comment in the next commit..


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8134](https://teamcity.mesosphere.io/viewLog.html?buildId=86846&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:09


Check this out if you have some time: https://github.com/rails/rails/issues/22498.


you can to use path 'utils/validation', and higher 'data/...'
validation file contains more than one func for validation, so validations.js better


- "WebViews can introduce a number of security issues and should be implemented carefully. In particular, a number of exploitable vulnerabilities arising from the use of the addJavascriptInterface API have been discovered."?


This closes #5


Isn't a generic exploit, you need a Nexus 5


You're pretty safe to just use `rm`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8143](https://teamcity.mesosphere.io/viewLog.html?buildId=86876&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:05:08


Oh, just kidding. It's something in lib/utils.py that breaks. It looks like maybe a file is missing?


Is it guaranteed that `Literal` is null terminated here?


can be used { isEmty } from validation.js and do it like a boss


Class UpdateGitMirror is missing a docblock.


```make
all:
	echo kek
```
will output
```
echo kek
kek
```
to the terminal.
However
```make
all:
	@echo kek
```
will output
```
kek
```


@dpgeorge Thank you for the quick response. I meant the LSI to LSE transition because I observed the LSI surviving a rel. long period without Vdd off and Vbat on. So if the LSI is active for any reason, it is hard to switch back to LSE. Can we extend the rtc.init() to (optionally) reset RTC/BKP domain? I was reluctant to put it in my PR, thinking it was too exotic.


@IllusionPerdu Fixed the issue with this commit: b53e0b539e9d3c5002c445e73067fa62168d4f89


@gakimball @zurbchris

One fix is needed here.  If the animation fails, the message sent will be incorrect.  Instead the code should be updated to:
```javascript
promise.then(function() {
  publish(element[0].id, futureState ? 'active-true' : 'active-false');
}, function() {
  publish(element[0].id, 'active-aborted');
});
```

I think the messages being sent should be updated as well as the term **active** might not be what most people think.  The current messages that are use by F4A are:
- open
- show
- close
- hide
- toggle

When zf-advise is enabled on a component, the result is being able to be notified when one of those messages have been responded to and the component is fully displayed or fully hidden.  The addition of being able to be notified when the animation failed (albeit rarely to happen if ever) requires another type of tag to be included in the message.  This is where using a complex object in F4A messaging would have been helpful.


My understanding is that FindConstructor looks only for public constructors, because GetConstructors returns only public constructors by default.

Sure I raised an issue here: https://github.com/ParsePlatform/Parse-SDK-dotNET/issues/111


- Second sentence "While both are disabled by default, best practices call for explicitly setting them as disabled."?


I'm sorry, but your benchmarks appear to be wrong.

```
worker_processes auto;
error_log logs/error.log info;
daemon off;

events {
  worker_connections 1024;
}

http {

  lua_shared_dict store 100k;

  init_by_lua '
    ngx.shared.store:set("hello", "world")
    hello="world"
    ngx.update_time()
  ';

  server {
    listen 9000;

    location / {
      access_by_lua '
        local now = ngx.now
        local dict = ngx.shared.store
        local value1, value2

        local dict_start = now()
        for i = 1, 10000000 do
          value1 = dict:get("hello")
        end
        local dict_duration = now() - dict_start

        local global_start = now()
        for i = 1, 10000000 do
          value2 = hello
        end
        local global_duration = now() - global_start

        ngx.say("Shared value is "..value1.." (took "..dict_duration..")")
        ngx.say("Global value is "..value2.." (took "..global_duration..")")
        ngx.exit(200)
      ';
    }
  }

}
```

```
Shared value is world (took 0)
Global value is world (took 0)
```

Both seem to take about the same time, fair enough since it is not my main concern about the use of globals in this case. I repeat, this argument is not about performance for me.


I don't think you need the `'static` here


@adityadalal924 It should be anaconda**3** not anaconda2 on line 5 and line 21.


Yes, the public cmark API always returns null-terminated C strings.


Using `os.clock()` is more accurate that `ngx.now()`


You can just unconditionally use `RM := rm -rf ` for all cases (this way you also depend on the user using GCC)


Thanks. I was looking for where you had supported_linear_models defined. Don't know how I missed it. So then I assumed that PCA was included. Whoops.


@ndahlquist-cc Thanks for mocking games! :+1:


Thanks for the reference, I'll definitely browse through it.

I've taken a better look at things, and here are my thoughts now:
  * It seems like GetWindowText modifies the name attribute of a Town class, which is probably then used somewhere else in the code. Changing that attribute to a wide string might thus cascade into multiple modifications to be made here and there (which I feel should be avoided).
  * I have not found any use of dialog.cpp in the editor_vs project. A solution would thus be not to include it there which would solve the conflict between character mode.
  * My viewpoint is not broad enough to be able to judge the pros and cons of staying in MultiByte versus Unicode, I'll read about the motivations behind that conversion (I recall one being that the Chinese alphabet contains a large amount of characters). But I feel like you're suggesting to stay in the original, simplest frame.

I was wondering about that "double extraction". Intuitively I feel like there should be a way to overload (not sure that's the proper word) the function DisplayError in the scripting.cpp source code. The overloaded function would do the extraction and then call the more general function with the msg from Lua.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8145](https://teamcity.mesosphere.io/viewLog.html?buildId=86879&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:57


`\@` does not start at 0 per rept


> Работает отлично

Ура!

> Варнинги

Не, я имел в виду при сборке. Эти у меня тоже есть, видимо что-то не совсем корректно со спрайтами монеты и игрока.


That comma is wrong. The original line had two string literals next to each other, for automatic concatenation.


Not sure we need the module.exports() line in the samples.


GCC-dehydra support has been abandoned by Mozilla since 2010 (and doesn't work anyway), so there's no reason to leave it in our code.


71行目の "それから、\*\*app.php\*\*にて"  の "\*\*app.php\*\*" と ”にて” の間に空白が必要です。


Ditto here.  Also, can you change the enyo.Panels reference above to enyo/Panels (and probably add a @link to it?)


intentional misspelling?  ;)


You may be right, because `os.clock` implementation is weird and also changes depending on the system. Not sure if Lua has a better standard way of getting more precise time.


Avoid unused local variables such as '$tokens'.


* TODO: rewrite this as it is doing way too much and is very messy now.


// FIXME: Move the archive to a seperate command


Check out the `try!` macro https://doc.rust-lang.org/nightly/book/error-handling.html#the-try-macro

It does exactly what you want here. Right now you are returning a `String` with the contents on success, and a `String` with an error message on error - should return a `Result` instead. This function could be written like this instead:

```rust
fn read_directions_file(file_name: &str) -> Result<String, Error> {
  let file = try!(File::open(file_name));
  let mut directions = String::new();
  let contents = try!(file.read_to_string(&mut directions));
  Ok(directions)
}
```


The string.h include is missing for this.


Cool, removed


use `socket.gettime()`


:) done


Done


Guys this is not about performance :cry:


Bahh.. yeah, I had meant to circle back on that and actually call the simple check I implemented.  I'll get that fixed up. Thanks!


Jk for whatever reason the cloud code didn't actually save to git.


done


Yeah... Ooops :)


- "Disallow the loading of content from third-party hosts. This can be difficult to achieve from within the app. However, a developer can override shouldOverrideUrlLoading and shouldInterceptRequest to intercept, inspect, and validate most requests initiated from within a WebView. A developer may also consider implementing a whitelist scheme by using the URI class to inspect components of a URI to ensure it matches an entry within a list of approved resources."?


Yeah, so this can actually go away, I added a waitForDevice in the api call there so we shouldn't ever get the return without first verifying that the device is there.


Not a huge fan of the named `interpret_direction` since it is not really a function signature you'd ever use outside of `scan`.

Also not sure if it is better to do the `.chars()` in this function, or to have this function take an Iterator<Item=char> and let the consumer get you that however (they could do my_string.chars(), or my_file.chars() - although File::chars() is unstable).


nit: trailing whitespace


(Also those benchmarks do not take concurrent access (from concurrent requests) into account, which is what the ngx_lua documentation is most worried about)


added animated GIF to README.md


just curious, why is only Android supported, and not other platforms?  I thought appium is cross-platform...


Yeah, that's good to know! And I can imagine not seconding saves lots of (computer) effort!

It'd be nice to have a list of all the services and the data they return. :)


`[CWE-79: Improper Neutralization of Input During Web Page Generation ('Cross-site Scripting')](http://cwe.mitre.org/data/definitions/79.html)`


I think this is more idiomatic (since it sucks to tie your API to the `Scan` type since that is pretty much an impl detail)

```rust
// the `char`s inside the provided iterator must live as long as the iterator I return
fn scan_directions<'a>(directions: Chars<'a>) -> Box<Iterator<Item=isize> + 'a>
```


Although in this benchamark they seem to be using `os.clock`: http://lua-users.org/wiki/ObjectBenchmarkTests

Using `socket.gettime()` the results vary, but still shared is slower most of the times (not all the times):

```nginx
worker_processes auto;
error_log logs/error.log info;
daemon off;

events {
  worker_connections 1024;
}

http {

  lua_shared_dict store 100k;

  init_by_lua '
    ngx.shared.store:set("hello", "world")
    hello="world"
  ';

  server {
    listen 9000;

    location / {
      access_by_lua '
        local socket = require "socket"

        local dict_start = socket.gettime()
        local shared_value = ngx.shared.store:get("hello")
        local dict_duration = socket.gettime() - dict_start

        local global_start = socket.gettime()
        local global_value = hello
        local global_duration = socket.gettime() - global_start

        ngx.say("Shared value is "..shared_value.." (took "..dict_duration..")")
        ngx.say("Global value is "..global_value.." (took "..global_duration..")")
        ngx.exit(200)
      ';
    }
  }

}
```

```
Shared value is world (took 3.0994415283203e-06)
Global value is world (took 0)

Shared value is world (took 2.8610229492188e-06)
Global value is world (took 0)

Shared value is world (took 4.0531158447266e-06)
Global value is world (took 0)

Shared value is world (took 2.8610229492188e-06)
Global value is world (took 9.5367431640625e-07)
```

Maybe the results vary when the GC kicks in (?).

The ngx_lua documentation is only comparing global access vs local access, not global access vs shared_dict access. Anyways now we know that shared access is usually slower.


Thank you for testing it!  Great news that the files worked with CS6 and Lightroom.

I'll keep pestering the FreeImage team for more information, and in the meantime, I may throw together a multipage TIFF export option.  While not exactly elegant, it would at least provide a way to get layers into/out of Photoshop if need be...


> Those values would then be passed along all plugins when they are being executed

hmmm, I disagree. This is conceptually the same as a global to me. You have a value lingering somewhere and pass it all over the place. Same as storing it as a global. Except that you dodge the "globals are bad" argument.

I would then come back to [my earlier co-routine approach](https://github.com/Mashape/kong/issues/736#issuecomment-158746336). Implement an event bus and write plugins as;

```lua

-- generic piece of Kong for event dispatching
function kong.nextEvent(...)
   return coroutine.yield(...)
end

-- plugin module
return function(my, generic, parameters)
   -- initialize plugin, we now have my-generic-parameters as local upvalues

  while true do
     local event, parameters = kong.nextEvent()
     -- deal with the event
  end
end
````

Each module function is wrapped in a coroutine and resumed when an event arrives. The initial call passes the global data required. From there on everything remains local to the plugin module and its upvalues.

obviously assuming that OpenResty can handle such a coroutine based setup, which I haven't tested.


Use `-when-let`, there's no ELSE.


Make this a method: `isAvailable`


@mwjames Could we use plural in this message for $1? Is there a special reason for the brackets?


TeamCity pull requests :: netty [Build 798](https://garage.netty.io/teamcity/viewLog.html?buildId=3812&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6222, ignored: 21 Build time: 00:44:06


And requiring Winesteam to install games that don't need it? No! Why would we do that?