Just a few minor comments, I think we could land it in the next iteration.
Thanks for your patience. :-)


ja das hani drus gno und en anderi methodä gschribä, will im fall vum assignä chamer nöd goToNext state ne, will ds assignä dspesä us de reihefolg rissä chan, darum ischs schlauer gsi wänni en anderi methodä gno han, hans sus nöd schlau chönä abdeckä ez ischs expense.assignToFinanceAdmin()


After this change the init system starts running at about 3 seconds (as far as the kernel knows, that doesn't include the bootloader and stuff).  I suspect we can make bootup appear faster by moving wifi + bt enabling till after the bootanim goes away.

In my latest tests, bootanim starts about +5sec, where before it was +9-10sec.  Can probably trim off another 250-500ms by removing some of the useless stuff from the init scripts, but those are just small wins.  I'm pretty certain the shitty USB system is adding another 3-5 second delay in there (even after removing some small delays)


C'est bien la logique qui est gérée par angular et pas la présentation.

En français, j'aurais mis "Ce tutorial utilise AngularJs, qui prend en charge pour nous l'ensemble de la logique d'affichage et nous permet de nous concentrer sur le code métier."


Même si le déterminant est ici pour le count ?


Fixed in https://github.com/ylatuya/longomatch/commit/ab615dc5cee63f709b3f1288f49c42333c7d352d. I will squash it here after all it's done


Ran into the same issue, please fix.


Ruben:
I addressed a different issue today where the optimised path would often contain a travel move to the other side of a line, after which it would traverse the cluster, and then it would make another travel move to the other side of the last line to continue with the next cluster. This was because the starting point of a cluster was arbitrarily chosen and therefore also the orientation of every line. I made an option today to mirror a cluster, reversing all lines, that prevents this. To do this while keeping the method generic, I changed the functions of TSP's constructor to return a list of possible start and end positions. This also prevents having to write additional code to check the reverse case, and makes it easier to use actual lines instead of average points. During this refactor, I also reversed the change to insert the starting point last; it's now again inserted first.


De pincodes moeten pas gecheckt worden in het login scherm, waarvan het onbekend is voor de app zelf wat de pincode is. Mag dus weg ;)


jangan load di baris bawah, pindahin ke baris atas ya... ya baris 3 aja, jgn lupa dikasih jarak enter ya... sekalian diganti jadi ini:

    require __DIR__.'/../app/bootstrap/autoload.php';


I'll rebase this branch on master after mine's merged


I am my own friend ;)


I guess that can be done ;)
I'll have a look.


Thanks


for https://github.com/fireball-x/fireball/issues/612


yup, looks like GHC's doc string is broken, I copy-pasted.


I have bumped up version.


why only uncomment the old arch?


done.


done, nice catch.


I'd be wary of moving more stuff to after the bootanim at the moment.
There's already a delay there for some things (eg: SWC intents don't first for the first 30 seconds or so) and it's a pain in the backside when it looks like the system has booted but it isn't usable yet.


fixed, thanks!


Этого класса не должно быть вообще, мы говорили об этом.


on random tick for now (but seems like.. never xD)


(1) It is unclear to me whether for a typical cluster you would have two start and end point or four, given that any start point may also become an end point. Please add documentation so that such questions are solved.
Also: isn't it best to make it four, so that you don't have to try reversing each cluster separately? Then reversing is done implicitly by checking all four possible traversings.
Example:
```
A |  | B
C |  | D
```
four start/end-point pairs: (A,B), (C,D), (B,A), (D,C)

(2) Another point is that when you require the start_points and end_points to be of the same size because they are linked, it's better to make this link explicit and put them in a single class. Then you can just receive a single list of startpointEndpointPairs for which you don't have the requirements.


А редирект без реверса не работает?


Always resolves to false. Weird, since it is defined on line 50.


Были еще замечания.


okay. isPowered returns if its powered or not.. also.. levers now work lol


you need to use the "name" of the parameter like Phase in this case, not pPhase.....


Why implementation in header?


I will take a look today and let you know :)  thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8950](https://teamcity.mesosphere.io/viewLog.html?buildId=90134&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:42


which units is that number in ?


I also think that there should be Pimpl.


Tim:
https://github.com/Ultimaker/CuraEngine/blob/PathOptimizer_RandomInsertion/src/utils/TravellingSalesman.h#L265
This case will always be true
You should just initialize best_distance to the distance to the first element, instead of to max()


@joelmoss maybe this should be a redirect to the forum post?


Ajuda maiúsculo.


Seems it wasn't a good idea to split set&get status. Here should be autolock. Current impl leads to data races.


apache2.conf et docker-entrypoint.sh viennent surcharger l'image officielle wordpress:4.3.1-apache
Je n'ai pas bien compris  ou vu quels sont les éléments qui nécessitent une surcharge ?


Casa maiúsculo.


Missão maiúsculo.


I test and edit lever.php for near 2hours…


Wow, nicely done! Way to add tests!! :100:


"is not" -> "are not"


Done


@PEMapModder suggest me use
scheduleUpdate()
For this
To reduce lag


hours (See [qgsoptionsbase.ui:4448](https://github.com/qgis/QGIS/commit/9c340d7b4b8fb7bf03182155d2e883b084e31e8d#diff-abbcee45f1123faace68ee36d2384af9R4448))


include alarm forum link


Should we use SQL to show the formulas we used here?


Por mi parte :+1:


This test fails! I have created an issue about this that needs to be fixed!


This Icons where missing during update


The updated link would be https://www.opengroup.org/austin/restricted/issue7-tc1/C138.pdf


Fasu stands for "Filtered And Sliced Universe". We use this class a lot in our software products as part of the pyPcazip and CoCo software tools.


It's what this request expects as a response. I could have created it entirely within `ListSpaceServicesResponse`, but it seemed more efficient and safer to create the actual object(s), with the bonus that it will presumably be required later anyway.


Whoops! I removed the Debian specific build files and accidentally bulldozed the `setup.py`. It's back in now.


Should we also remove EBDT/EBLC from default-drops?  I'm not sure.  Maybe dropping them is fine.


"'Loop' content"? Sounds weird, doesn't it? This is the reason why code exited loop, maybe something along the lines of 'loop finished successfully' wouldn't be better?


Good catch. I've made some changes to be more specific about the props passed to the Button:
```js
		const buttonProps = omit( this.props, [
			'loading',
			'loadingText',
			'text',
			'size',
			'disabled'
		] );

  ...
				<Button disabled={ loading || disabled } { ...buttonProps }>
					{ loading ? loadingText : text }
				</Button>
```

Once this PR is merged, I'll open a new independent one for discussion on moving it into the components directory. The [devdocs recommend avoiding spinners](http://calypso.localhost:3000/devdocs/docs/reactivity.md), so there might be some resistance to a component like this in the Calypso library.


Тут присваивание, и у меня результат присваивания возвращает булевское значение, вот его я тут и проверяю, успешно ли прошло присваивание


Fixed


Hmm that reminds me of something i noticed a while back and forgot about.   If a server isn't running midspace admin mod (ie /chat )   are we logging the player trading activity anywhere else?

For all our concern on balance and exploit avoidance seems odd we are not logging the actual player trades anywhere.

In our

        private bool ProcessMessage(string messageText)
        {

We could slap an "else" on this, and in there simply tell the server to dump player name and command entered into our log file with a time stamp.

            if (split.Length == 0)
                return false;

A more elegant but more labour intensive solution might be logging events at the stage where money changes hands, and log the who/what/when of each trade.


I find this description confusing (as well as the commit message's). The `Assay`s don't have any natural order (they don't implement `Comparable`. I think what you mean is that `assays` are ordered based on a lexicographical comparison of the assay codes.


This line is ended at line 180!
Please put the functions in a separate variable with an understandable name.

However, in another comment I say you should move the functions into a separate class, so you should first look at the comments below before implementing the change advised here.


Thanks @omarjackman, fixes are pushed in [4517a4c](https://github.com/Automattic/wp-calypso/commit/4517a4cd3dcd0bc8178c7f63b7d1c475163c802a)


[Uploading TakeSScreenshot.txt…]


Please document why you use size_t here.


Maybe explain why would one want to do that?


Имхо для старых версий параметр -format просто не анализируется и будет
просто пропущен

чт, 10 Дек 2015, 13:06, Andrei Ovsiankin <notifications@github.com>:

> А на предыдущие версии платформы это повлияет? Те у кого нет 8.3.7 не
> отвалятся?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EvilBeaver/oscript-library/commit/91ba744973a6834bba3c21a99fff01b2a8ba1966#commitcomment-14895843>
> .
>


Need sain raamatupidamisest, kes võttis SAPist välja järgnevad read: Admin. kulud (bürootarbed, side-, postikulud jm), Lähetuskulud, Koolituskulud, Kinnistute, hoonete, ruumide maj.kulud, IKT kulud (sh seadmete rent), Inventar, Töötervishoiu kulud ning jagas summa inimeste arvuga. Suht robustne ja mitte väga täpne meetod, kuid teeb loodetavasti otsa lahti.


TakeSScreenshot.txt

(https://github.com/praveen443/SeleniumCodes/files/57961/TakeSScreenshot.txt)


Oops, good catch


I don't know if it works, but maybe an `@see sol_json_type`? Of course, if the generated doc already does this link as it's the return of the function, ignore this comment =D


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8951](https://teamcity.mesosphere.io/viewLog.html?buildId=90135&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:40


We don't set XDG_RUNTIME_DIR when the user changes UIDs like this, and this is documented. Apps need to be able to deal with XGD_RUNTIME_DIR not being set, and that's documented in the XDG basedir spec... Also, /run/user/0 will not exist when root isn't logged in properly, hence the code wouldn't even work... We shouldn't reference a dir there that does not exist, not is not properly lifecycled.

Sorry, but this isn't right.


-> CODE FOR TAKING SCREENSHOT USING JAVA WEBDRIVER FOR THE FAILED TESTS:

package Actions;

import java.io.File;

import org.apache.commons.io.FileUtils;
import org.openqa.selenium.OutputType;
import org.openqa.selenium.TakesScreenshot;
import org.testng.ITestResult;
import org.testng.Reporter;

public class TakeSScreenshot extends Actions.DriverObject
{
   public static void onTestFailure(ITestResult result) throws Exception
   {
      String workingDirectory = System.getProperty("user.dir");
      String fileName = workingDirectory + File.separator + "screenshots" + File.separator +  result.getMethod().getMethodName() + "().png";//filename

      File scrFile = ((TakesScreenshot)driver).getScreenshotAs(OutputType.FILE);

      try {

    	  FileUtils.copyFile(scrFile, new File(fileName ));
    	  System.out.println("*** Placed screen shot in "+fileName+" ***");

      }catch (Exception e){
         System.out.println("---> Exception while taking the screenshot : "+e.getMessage());
         throw new Exception();
      }

      Reporter.log("<a href=\"" + fileName  + "\"> #### Test Failed. Click-here for Screenshot : #### </a>");
      Reporter.setCurrentTestResult(null);
  }

}


You might have been right the first time. d3d_destroy() is only called by dxinterop_uninit(), which is called externally and from the fail case at the end of dxinterop_init(). Assuming .uninit isn't called when .init returns -1, it should be fine to not reset these fields.


any hint? or site where I can read about it!!!


CC @DomT4 who asked for this.


Why do you include os.os.h here? It doesn't seem used in the added code AFAICT.


I figured the window size could have been changed? I think VO_EVENT_RESIZE is sent anyway, so I'll remove this.


This code is not DRY, you're repeating the same assertion over and over again. This should either be part of `dataMatcherFor` or maybe tested only in one of the tests, if that's enough to cover all the cases.

In any case, this assertion is only needed because you build the matcher partially based on the result itself, which is a very dubious course of action, as the test is circular in that respect. Just pass `dataMatcherFor` the actual assays that you expect.


We're are only sending the "keys" of updated settings.
We should, instead,  send the keys and the values, otherwise we can't use them when building funnels on server side, since we don't know if the user enabled or disabled the setting.

EX: I enabled and then disabled some settings on a test site and in both case I got the following response:
`    [items_saved] => ["default_pingback_flag","default_ping_status","default_comment_status"]`

Probably something like the following is the easiest solution:
```
                        if (response != null) {
                            JSONObject updated = response.optJSONObject("updated");
                            if (updated == null) return;
                            HashMap<String, Object> properties = new HashMap<>();
                            Iterator<String> keys = updated.keys();
                            while (keys.hasNext()) {
                                String currentKey = keys.next();
                                Object currentValue = updated.opt(currentKey);
                                if (currentValue != null) {
                                    properties.put("item_saved_" + currentKey, currentValue);
                                }
                            }
                            AnalyticsUtils.trackWithCurrentBlogDetails(
                                    AnalyticsTracker.Stat.SITE_SETTINGS_SAVED_REMOTELY, properties);
                        }


looks nice, good luck for LTC :-)


Nice!


Ok, peaks ära dokumenteerima.


This should most likely be 10.0.3.11 ...


This essentially reverts 6a044c8718ed9ef34458735438fd7b354e286bb6. I'll add a dedicated test to make sure we don't drop support for unicode queries. I think however that the existing test for unicode named parameters already covers this, but better to explicit.


Does this function need to be documented? It starts with `_`, maybe it should be hidden somehow?


Good catch!


These changes are OK.


Correct local IP to use should be 10.0.3.11


Why start the timer again here? IIUC this is called when the left mouse button is released no? Or is it to handle cases where a user might release the mouse button and then click very quickly again, and the increment would therefore continue?


@gaestu what are you actually asserting here? how do you know that the command really succeeded? currently it seems that you only check for `Succeeded` which is just an error code. I would definitely check some output of the Cmdlet (the code you commented out must be adjusted)


Ditto for this and all the others where `^_` applies.


Fortsätt med att skriva in html kod


Viva


testar


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8954](https://teamcity.mesosphere.io/viewLog.html?buildId=90141&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:17


The sed change is OK. For the removal of commented out lines -- they were actually those modifying the config file (writing the changes there). The currently present / kept ones would just print out intended changes to the stdout.

But nevermind. I will fix this during manual merge.


I don't know what's going on, but @thakyZ thinks all the guns need to be activeitems now.


Hehe, I'm going to change this one back...


Does this serialize changes the string, I mean, by escaping stuff? Maybe note that on doc, so no one is surprised.


I doubt many people are going to call unsubscribe with a callback, but put it there for consistency with `#subscribe` (which mostly only has one so it can pass it to attach). 'Normal' behaviour is that it throws the error.


What this is supposed to mean is that the `assayIndexMap` ordered map maintains the same iteration order as that of the `assays` list, which is important because `SnpLzRow.iterator()`/`getAt()` must match the order in `TabularResult.indicesList`.


NB this will require changes to realtime tests that use `!!page.next` to check for last page.


Right - it checks every field, the hash, the code, even 'reason' which isn't strictly defined by any BIP, but according to our own convention where the prefix is an abbreviated error name (hence the starts_with).


Apparently Windows 7 still has a 16-bit colour mode. I have no idea whether D3D9Ex actually creates a 16-bit backbuffer, or if it ever chooses a pixel format other than D3DFMT_X8R8G8B8 for a windowed swapchain. Maybe I should just set it to D3DFMT_X8R8G8B8 and always set depth_* to 8.


Oh sorry I've debugged and found the problem. The stores aren't connected.

The problem is after the `onlineStore.findAll` resolved, each record I run 'this.offlineStore.findRecord(type, record.get('id'))` to check if the record is existed in the `offlineStore` or not.

Ember-data is so smart with `adapter.coalesceFindRequests = true`, so it group multiple `findRecord` request into one `findMany` call on the adapter. And the problem occurs on `findMany` somehow... new records are created in the store with only id....


Please reconsider wording, it's ok to ask. But users should be willing to provide help to others if they claim help.


wait wait
onEUnCll
is lag
I will see if I can change a way


@woshilapin, probably we should add a file documenting all the ports the learnpad platform is using.
Specifically we may think to impose that in each component has a specific file which shows the default
ports used, and then compile an overall document including all the files?
Would it be possible?


Why not in header. We implement getters and setters in headers usually


Students/30425/Farcas S. Silviu Vlad/snake/src/Snake.java

Even though this class has the name `Snake`, it doesn't really model a .. snake, does it?
You have a frame in the constructor, you have action listeners, key listeners, timers, everything is here!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8952](https://teamcity.mesosphere.io/viewLog.html?buildId=90140&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:43


This static variable is confusing as well


I've clarified this a bit in an update.


I cannot implement pimpl within bugfix task


Nicely done (I mean, about the escapeXML).


The SWC thing is something I haven't personally experienced, but usually after a cold boot I'm not in a rush (waiting for kids to get buckled in before moving).  That should be a resolvable issue though.

It's hard to know what the normal expectation is.  I suspect people want to see their default apps running as quick as possible after starting the vehicle up.  If they are using Pandora or some network based app I would assume they expect it to take a bit longer for network to come online, but if someone is just using the radio or local files that should happen as fast as possible.

My last test from power on till seeing something other than bootanim was 31.19s and the dmesg shows bootanim exiting at 26.3 sec so there is almost 5 sec before the kernel is even counting time.  I'd really like to get it down to 16-18sec

There is a possiblity of switching to something like u-boot which would cut out a second or two of that, but I haven't tried it yet.


Also restores search text and search results for active tab.


Also, every variable seems to be public which makes this class very exposed, and because you have a public static instance of this class (`snake`) you will be able to access every field from everywhere! Really, really bad


`msc_p1` is already defining the property `id` so this Property is not useful.


I don't really like this, it feels like we're replicating connectionManager functionality in the transport to get around the problem of connectionManager not having a reference to not-proved-viable transports. We might want to consider changing that, eg giving connectionManager a `proposedTransports` array or something and having tryConnect return the transport.


Students/30425/Farcas S. Silviu Vlad/snake/src/models/Snake.java

Again, a snake class, but this time it's somehow.. different? What am I looking at exactly?


Pimpl should have been implemented within the porting task. When and who will do this? Next editor of this file?


@jrgarcia which issue?

It would be nice to make it work using autoload and decrease the amount of objects loaded on initialization.


Could you push this commit into any new branch? I can't merge it in a regular way, because it's not in the index anymore.


I find this function very hard to read.
If I'm correct `polygons` consists of lines for LineOrderOptimizer, i.e. polygons with two vertices, which get a special treatment everywhere in the program.

I think it would be better if this would be reflected in variable names.
You should introduce something like
`Polygons& lines = polygons;`

And replace all occurrences of the word "polygon" with "line" where appropriate (e.g. `polygon_index` ==> `line_idx`).


Oh this is actually separate and contains a cool menu, nice!


@nyalldawson I have trouble understanding why the callback is required. Does the context change through the lifetime of these buttons?

I wonder because in the geometry generator config widget there's an expression widget which does not have the same "on demand popup" semantics like the button and it would benefit from a setter approach.


Ok, so it looks and moves great! Awesome job on the frontend part, the graphics and all that. I also like the menu a lot! Great work on that part, however, you have a lot, a lot of work on the class design.


"increase eg threats by 10%" version seems to perform worse than the original


`solar-dev1` is invalid python code in this case.


Sorry, I accidentally pushed the project.pbxproj as well...


**Pimpl should have been implemented within the porting task** Who said that?


Thanks for the tips @msteiger, I'll do that.

By the way, should we get "This module has no dependencies." and "Module dependencies:" from the language assets (i18n) or is there any other way to do it besides leaving it "hard-coded"?


the changes to [system_name].py is not quite right.   it would start sensor_manager2 twice.   sensors_virtual_p8.py should be changed to hwmon.py


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8953](https://teamcity.mesosphere.io/viewLog.html?buildId=90142&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:10:24


Jupp, deshalb hatte ich mit @gharlan schon wegen einer Art Namespace nachgedacht. Ich finde es irgendwie unsinnig, innerhalb des Fragmentordners nochmals den eigenen Addonnamen zu notieren. Es liegt ja bereits im eigenen Addon.


TeamCity TripleA :: UnitTest [Build 376](http://home.k-moeller.dk/viewLog.html?buildId=705&buildTypeId=TripleA_UnitTest&guest=1) is now running


I don't really know what the actual entry point of the program is as you have 2 `main` methods. Also, try to follow the "single responsibility" principle a little bit. Your classes know too much about everything.


Students/30425/Farcas S. Silviu Vlad/snake/src/views/StartMenu.java

Again, everything is static...


TeamCity TripleA :: UnitTest [Build 376](http://home.k-moeller.dk/viewLog.html?buildId=705&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:46


Change also the docs description


"a. list item" is not a valid list, according to the markdown spec and my testing.  Neither is "1.list item".  You need a number, followed by a space.


Do you think you can do some refactoring, remove whatever is not used and restructure your code?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8955](https://teamcity.mesosphere.io/viewLog.html?buildId=90144&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


there is only one if-else now, not four similar code.


@jareguo 提交的时候还是尽量走 pr 吧


resolves part of #51
remaining: delete, in the beginning of the pipeline, output folders if exist.
improvement: replace PDF publishDir pattern by negation : reject all '*empty.pdf'


We're using bower, so whatever comes there..


Dear Justin,
There is a preprocessor directive in Eigen for this
EIGEN_INITIALIZE_MATRICES_BY_NAN
see
http://eigen.tuxfamily.org/dox-devel/TopicPreprocessorDirectives.html
Best,
Olivier.


Ruben said about some later commits that he "made an option today to mirror a cluster, reversing all lines."

Here it seems you decide on connecting two lines into a cluster if only the endpoint of the last and the start point of the next are close enough to each other.

```
v start
|   v end
|   |
|...|
```

The difference would be in the above example; when connecting lines into a cluster based on the endpoint of the last line alone it is not simply possible to reverse each line in a cluster, since the `start` and `end` don't align.


There should be a modelset title here.  However, I've looked into the modelset overview and there is none (I missed that point).  I'll send an email to Nesat.


see related discussion in Netty:
https://github.com/netty/netty/pull/3969#issuecomment-132559757
The problem with using longs is the potential for preventing otherwise feasible loop optimizations. In particular to Aeron/Agrona the use of Unsafe sort of currently prevents superword and fill, but losing loop unrolling can hurt too.


Are you sure the code here is correct with respect to the above?


Awesome!


Change suggestion....

+		if windowTitle is None:
+			windowTitle = _("Select")
+		self.setTitle(windowTitle)
+

->

+self.setTitle(windowTitle or _("Select"))


Najbojsi commit
# E V E R


I would suggest to stick with our policy to not annotate our code to silence compiler warnings.


I say. This is usual approach for the cross-platform code. You've already faced with issues because you've avoided the pimpl here. Next task could involve more ifdefs. Or ifdefs are considered as the best practice?


Can you please add some more comments.... What is going wrong here, why etc this patch is required?


Ja, ich bin auch noch nicht so glücklich mit dem aktuellen Verhalten.
Meiner Meinung nach ist der Standardfall, dass man für's eigene Addon eigene Fragmente ablegen will.
Und Core-Fragmente oder Fragmente anderer Addons überschreiben ist eher der Sonderfall, hauptsächlich relevant für Skins.

Das aktuelle Verhalten ist aber mehr auf den Sonderfall ausgerichtet, als auf den Standardfall, so empfinde ich es.


Where is `NewBond` defined?


yes


Fair enough, though it seems it would be simpler to just replace `indicesList: assays` with `indicesList: assays.sort { ... }`. This way the assays will be ordered by assay id in the result, I guess.


TeamCity TripleA :: UnitTest [Build 377](http://home.k-moeller.dk/viewLog.html?buildId=709&buildTypeId=TripleA_UnitTest&guest=1) is now running


I would just consider to leave it as _("Restart GUI").... because changing it will "break" all other translations and the extra "now" does not have a real added value.


To be more explicit, I will explicit say which name components we have, `surname`, `givenname`?


TeamCity TripleA :: UnitTest [Build 377](http://home.k-moeller.dk/viewLog.html?buildId=709&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:45


Changed.


`*[ATCG].pdf` is a good idea, but don't forget deletions ending with `-.pdf`, so it should be `*[ATCG-].pdf`


I know, but Nathan wanted to do it this way <.<


@malirod, if you can create task for replacing current implementation with `pimpl` please do that and I'll process it with pleasure. I have no such task.


thank you =) i'd still like to align the name of the reference on the right side and make the boxes / margins better (to use less space) - not sure how to solve it, but we'll find a way


There will be a single VCF produced, so I don't think we need to put it in a subfolder here.


`msc_p2` already define the `name` property.


Frederiks recommendation is a good example. it is just a line too long to fit on an entire page..


There is still quite a lot of duplicate code in your `move` method. 10 lines are common on every switch branch. Why not group them together and place them before the switch?


Other than this, I have no objection. Great work!


Going to need the help added also. :grin:


@jelledevleeschouwer the behavior of these macros is not clear to me. What is the purpose? when you do *vtf = IPHC_XXX(*vtf), what do you expect? If this is enabling a bit, should it not be vtf |= (XXX_BIT << XXX_MASK) instead?


Some interesting stuff here http://hilton.org.uk/blog/source-code-line-length
I propose you 125, because this is the maximum number of characters that you can see in the GitHub diff view :)


Quoting from https://en.wikipedia.org/wiki/VAT_identification_number :
> 11 digits (the first 7 digits is a progressive number, the following 3 means the province of residence, the last digit is a check number)


And why `mode: copy`and not `mode: move`here?


Declaring a method with parentheses `qed()` and then calling it without parentheses `qed` will result in a warning in IntelliJ.  You can just `def qed: LKProof` here.

Semantically there is no difference between parentheses and no parentheses in a method declaration in Scala.  However, usually you use parentheses to indicate that the function has side effects.


There isn't any `modelid` property for the object `LPCode.ModelSetClass`.


added this so everyone will know fractions exist


not everyone is perfect
third time lucky they say


There isn't any `type` property for the class `LPCode.ModelSetClass`.


I think we should also review the book size, feels wrong now...

scrambled by yPhone

> Op 10 dec. 2015 om 12:09 heeft Markus Wissekal <notifications@github.com> het volgende geschreven:
>
> thank you =) i'd still like to align the name of the reference on the right side and make the boxes / margins better (to use less space) - not sure how to solve it, but we'll find a way
>
> —
> Reply to this email directly or view it on GitHub.
>


Class UpdateGitMirror is missing a docblock.


* TODO: rewrite this as it is doing way too much and is very messy now.


// FIXME: Delete tar file if it exists


exit 0 # FIXME: Not sure why I need this, otherwise it fails


Same here, don't define twice the `id ` property.


Yep! I thought about something similar. because we only introduce the coupled balls (only 1 blue AND 1 red count) a few rounds later, we could either have another column / team, or have them multiply their number by two, or add the points from the other team to their score


This function is not used anywhere (anymore?).

Why is it not used anymore?

Shouldn't it be used when creating clusters?

Penalize sharp corners is not a thing anymore now. Is it not possible with the new architecture?


There isn't any `modelid` property for the class `LPCode.ModelClass`.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.614.e162ac6175e2e3708e71d0776b9f1eaf3f7c0986](http://build.palaso.org/viewLog.html?buildId=67154&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3324, ignored: 125 Build time: 00:07:05


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.622.e162ac6175e2e3708e71d0776b9f1eaf3f7c0986](http://build.palaso.org/viewLog.html?buildId=67155&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3304, ignored: 106 Build time: 00:07:21


It's a good idea to add some test to all data types ensuring that the you get the same sequence of values no matter the iteration method you choose: `row[0]`, `row[1]`, `row[2]`... / `indicesList.each { row[it] }` / `row.iterator()`. Perhaps in the `HighDimensionAllDataTests`.


What to do with image upload in SCC? Do we still let WP generate thumnails and a few different sizes, so the upcoming WP responsive images can use those in WP mode?


Same here, don't define twice the `name` property.


@nitsanw Is there a difference in impact when the underlying implementation is calling Unsafe which is all long indexed anyway?


TeamCity TripleA :: UnitTest [Build 378](http://home.k-moeller.dk/viewLog.html?buildId=713&buildTypeId=TripleA_UnitTest&guest=1) is now running


Same here, don't define twice the `type` property.


I'm sorry. `LineOrderOptimizer::polygons` could just be renamed to `LineOrderOptimizer::lines` instead of intrucing a local reference variable.


TeamCity TripleA :: UnitTest [Build 378](http://home.k-moeller.dk/viewLog.html?buildId=713&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:46


Can't `sol_util_fill_buffer` be used here? Probably not, as it's on shared... pity...


Bluebird.defer() is actually deprecated, see http://bluebirdjs.com/docs/api/deferred-migration.html


s/True/False/


While it's a good idea to prefer case classes when possible, case classes should be 1) immutable and 2) not have subclasses.  Lemma is mutable, and we want to create subclasses of it (`new Lemma(...) { ... }` creates an anonymous subclass).

(Creating subclasses of case classes is a bad idea because the case class implementation doesn't expect this, and methods like equals and hashCode will fail in more or less unexpected ways.)


you mean the entire template? -> width and height vs font size?


OK, as @cdondrup stated in https://github.com/strands-project/strands_systems/pull/114#issuecomment-163581528 this commit needs to be reverted. I'll do it but want to make @Pandoro and @lucasb-eyer aware of it.


Is it ok to send the response even if it couldn't set 'Content-Type'?


Empty `history_id` or `job_id` ?


If we keep track of the exact number of balls per color and the combination we could in a spreadsheet after the workshop do multiple calculations To find a better rule

scrambled by yPhone

> Op 10 dec. 2015 om 12:14 heeft Markus Wissekal <notifications@github.com> het volgende geschreven:
>
> Yep! I thought about something similar. because we only introduce the coupled balls (only 1 blue AND 1 red count) a few rounds later, we could either have another column / team, or have them multiply their number by two, or add the points from the other team to their score
>
> —
> Reply to this email directly or view it on GitHub.
>


Now fixed. Note that behaviour with in-call status bar is horrible, but I couldn't find a solution. Using windowLevel also doesn't work (in fact it's worse in some aspects).


Cannot the following steps be executed as part of the do_setup() method of the driver?


Class UpdateGitMirror is missing a docblock.


Good job, i'm proud :+1:


Ok


typo?


Students/Others/Huruiala V. Vasile Alexandru/java/The Baer and the Seals/src/theseal/view/GamePanel.java

(în lipsă de alte lucruri de spus) - this variable is unused.


Some of the command are logged when they run from the Message side.
But the log file will be overwritten when the server restarts.
Properal transaction logging of command would require a new more complex data structure (or simply if you are storing the text command). But if you are wanting proper transactional, since messages could be invoked externally from chat commands, it would mean the Message portion does it along with all it's parameters.

I still consider logging transactions as proper due diligence. Record what was sold, bought, traded, received for each player for at least 50 transactions, along with dates, times, players.


Yes in the leanpub website you can Change the size of the document .

scrambled by yPhone

> Op 10 dec. 2015 om 12:17 heeft Markus Wissekal <notifications@github.com> het volgende geschreven:
>
> you mean the entire template? -> width and height vs font size?
>
> —
> Reply to this email directly or view it on GitHub.
>


Sure, if you think that's the beast way to go. I will merge everything before this commit and add a PR soon.

@scottgonzalez


Oh lol.. me for 3 days


Shouldn't this `sol_buffer_ensure_nul_byte` be after the loop? After you read all that was to be read?


`bzip2-devel` is the name of the RPM/deb package, right? The error message seems to be implying that a check for the presence of this package has been performed. But really what it did was look for `bzlib.h` . . .

There may still be systems out there that do not use RPM/deb packages.

Maybe change the error message to say: "bzlib.h (bzip2 library header required by --with-librocksdb-static) not found; maybe you forgot to install the bzip2-devel (or equivalent) package?"


Espirito tem acento.


sollten wir in der package.yml nen schalter einbauen mit dem man den fragment-ordner in den globalen mapped (disabled by default)? im default fall könnten wir autom. den namen des addons vor die pfade des aktuellen pfades setzen...


It does what it should ;)


Falta acento no espírito.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.615.c7b04edf8335197ef3e7a6f0cb300f52d37c5291](http://build.palaso.org/viewLog.html?buildId=67158&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3324, ignored: 125 Build time: 00:04:55


Done


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8956](https://teamcity.mesosphere.io/viewLog.html?buildId=90145&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:41


Thanks, means a lot coming from you.


Ah, nevermind, now I noticed the `break` after...


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1000.e162ac6175e2e3708e71d0776b9f1eaf3f7c0986](http://build.palaso.org/viewLog.html?buildId=67156&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3304, ignored: 106 Build time: 00:05:47


Thanks @omarjackman, updates in [802b7d](https://github.com/Automattic/wp-calypso/commit/802b7d4fd643f59f96bf5cfdc818a0c3ca2281db)


C'est même pas celle qui marche celle là, faut voir la complète dans les commits suivants !


This isn't going to work I think - the logger object needs to be created to it can be appended to
Also, you can't fire a hook inside a hook currently. It's a limitation of the design, I'm not even sure how this code yielded anything as once a hook process is in the queue, it holds up the entire queue as we only have 1 worker, and nesting would require us to pause hook callbacks and other funky stuff.


Ahah, je suis mauvais ^^


the API calls fails as,
Edited m-shr service log,
ERROR manila.share.manager Shrink share failed.
Traceback (most recent call last):
File "/opt/stack/manila/manila/share/manager.py", line 1456, in shrink_share
share_instance, new_size, share_server=share_server)
File "/opt/stack/manila/manila/share/drivers/cephfs/__init__.py", line 214, in shrink_share
used = self.volume_client.get_used_bytes(share['share_id'])
 File "/usr/lib/python2.7/dist-packages/ceph_volume_client.py", line 738, in get_used_bytes
 return int(self.fs.getxattr(self._get_path(volume_path), "ceph.dir.rbytes"))
 File "/usr/lib/python2.7/dist-packages/ceph_volume_client.py", line 271, in _get_path
   volume_path.group_id if volume_path.group_id is not None else NO_GROUP_NAME,
AttributeError: 'unicode' object has no attribute 'group_id'


Hi,

would be great to see an example in the documentation on how to do:
1. "You can also freely combine and nest multiple filter joins to create complex query plans."
I assume its something like this or`?
{
	"query": {
		"filtered": {
			"query": {
				"match_all": {}
			},
			"filter": {
				"filterjoin": {
					"aaa": {
						"path": "id",
						"query": {
							"filtered": {
								"query": {
									"match_all": {},
									"filter": {
										"filterjoin": {
											"bbb": {
												"path": "id",
												"query": {
													"term": {
														"name": "abc"
													}
												}
											}
										}
									}
								}
							}
						}
					}
				}
			}
		}
	}
}

2. Understand if it is possible (and if so how) to also get the filterjoin to combine the results from the join.  As of now its only filtering. using the exameple above I would like to get this included in the result JSON "id": "2", "name" : "Orient Technologies"

thanks


强烈赞同！

2015-12-10 13:50 GMT+08:00 MelodySo <notifications@github.com>:

> Everything that has a beginning has an end, including GFW.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/goagent/goagent/commit/e492ed0283f5cde7cf71d7ac47429f64aa48cd13#commitcomment-14891916>
> .
>


There is no need to add stub comments.  It's fine if something is not documented, but empty comments just add noise to the code.

We often have code like this where you have a class/object that contains just one method (usuall `apply`); there we only document either the class or the method.  It's probably a good idea to just document the case class here.


should this trigger a deprecation warning ?


Ratail typo so dunno if keep it on that way or use proper name


this does not work for all kinds of callables, even on 5.4 (5.4 adds more than 5.3, but not all of them)


TeamCity libpalaso :: palaso-precise64-libpalaso-2.6 Continuous [Build 2.6.1001.c7b04edf8335197ef3e7a6f0cb300f52d37c5291](http://build.palaso.org/viewLog.html?buildId=67157&buildTypeId=PalasoPrecise64v26Cont) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:05:37


TeamCity TripleA :: UnitTest [Build 379](http://home.k-moeller.dk/viewLog.html?buildId=717&buildTypeId=TripleA_UnitTest&guest=1) is now running


should it trigger a deprecation warning ?

and you should mention the trait


Update banhammer.lua


TeamCity TripleA :: UnitTest [Build 379](http://home.k-moeller.dk/viewLog.html?buildId=717&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:47


Avoid unused local variables such as '$tokens'.


what does this do>


* TODO: rewrite this as it is doing way too much and is very messy now.


// FIXME: Move the archive to a seperate command


you're welcome @mkrnr


to distribute ZeroBuf objects


Dammit HTC
On Dec 10, 2015 02:14, "Dennis S Lebhardt jr." <notifications@github.com>
wrote:

> this breaks build!!
>
> drivers/input/touchscreen/synaptics_dsx_htc/built-in.o:(.bss+0x100):
> multiple definition of `android_touch_kobj'
> drivers/input/touchscreen/max1187x.o:(.bss+0x38): first defined here
> make[5]: *** [drivers/input/touchscreen/built-in.o] Error 1
> make[4]: *** [drivers/input/touchscreen] Error 2
> make[3]: *** [drivers/input] Error 2
> make[3]: *** Waiting for unfinished jobs....
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/CandyDevices/kernel_htc_msm8994/commit/0813d6b2092b59edd5147aaeb8bc4fd44634f670#commitcomment-14893659>
> .
>


OK, I know this change was proposed to help our contributors in China to get around their firewall issues. Is the git version shipped by RHEL 6 completely unable to use http repos? No extra package that can be installed to solve that problem?


s/osd/mds/


yep, but we don't care about this here: we don't have to preserve any bc


打发


It had already more functionality in the first commit than 5 years later.


We shouldn't support piracy, period. You want to play the mod? buy the game.

This change makes AdminTools useless while displaynames are on, because if you change your display name, you won't be able to access your existing account, also if someone "steals" your username, it'll not allow you to access the account, even if you use the same display name, since your name is then re-assigned with a number.

And, finally, IPs change, that's a completely unreliable source for long term identification.


great.


@danielinux IPHC_XXX(vtf) only gets the value out of the original IPv6 vtf-field, but since IPHC compression re-orders these fields I immediately shift it to the proper position. This isn't enabling any bits. The construction of the compressed field is done in sixlowpan_iphc_tf(). XXX(vtf) on the other hand does exactly the opposite, it gets the values out of the compressed field and puts it immediately at the correct position for the to reconstruct IPv6 vtf-field.

Since it's not modifying it, is it still unpredictable behaviour?


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.623.c7b04edf8335197ef3e7a6f0cb300f52d37c5291](http://build.palaso.org/viewLog.html?buildId=67159&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:05:39


no, it's different, here we do not receive N elements separated by `&` neither the separator is the same, here it uses `:` instead of `=`. So i can add a new function there that splits a string into headers but it should follow the same behaviour.

Here i tried to reproduce, as much as possible, the **curl** behaviour.


Re: `indicesList: assays.sort { ... }`, We don't care about the actual order the assays have, just that the order of assays in the `indicesList` matches the order in a `SnpLzRow` (which takes its order from the `assayIndexMap` created here). Or did I misunderstand that core api uses `TabularResult.indicesList` to indicate the assays for the values in a data row? The previous code messed up and gave a silent data corruption bug.

About testing iteration order I agree.


I do not have any comments at the RHBZ. The status was changed to ASSIGNED. It is not critical for me now. I can wait for a few weeks. Let us wait until the RHBZ:1289984 gives us more info.


There's a convention that plugin methods with a leading "_" presume the caller already has a context.session, while methods without a leading "_" will get a context.session (see line 657 of neutron/plugins/ml2/plugin.py for get_network, and line 128 of db/l3_db.py for _get_router).


нормуль.


comentario nº 1


@rhukster  got it working. A few things:

- you were extending login.html.twig, but that does not use the Form plugin but the Login form directly. In that file there’s an admin-form nonce, but since you are using the Form plugin, there you must use the form-nonce, because that’s what gets validated automatically by the Form plugin, so: https://github.com/getgrav/grav-plugin-admin/blob/4c109d002c1829521bd15bad20049ac4e22f4de5/themes/grav/templates/partials/register.html.twig#L17. The page null problem was caused by this problem (nonce not validated) but when the Form plugin handled the onFormValidationError https://github.com/getgrav/grav-plugin-form/blob/develop/form.php#L207-L228 it tried to get a page that was not existing. I am inspecting this problem now, since it applies to the form validation, and it's currently still not working fine.

- the process.register_user has been changed since your first commit to include the options in the Login plugin yaml, so it's easier to edit by a user. So that was not working any more

- the user registration uses those yaml options, very much thought for the frontend in the first place, I didn't anticipate this usage, so I just added a new form handler in the Admin plugin: https://github.com/getgrav/grav-plugin-admin/blob/4c109d002c1829521bd15bad20049ac4e22f4de5/admin.php#L135 that directly handles an admin user registration, dedicated to the admin registration form.

- dropped the `name="task" value="register"` in the registration form, which was triggering the Admin form controller, but the form does not have the admin nonce


Nota de línea 1


then don't document the input type as ``callable``


Could you point in the commit message which spec section determines so.


Cuando dev_TeamC haya hecho merge a dev, volveré a subir la versión nueva.


Unfortunately, `Ligatures=TeX` is not the same as `Mapping=tex-text` with fontspec v2.3c that comes with Ubuntu 14.04 LTS. Are there any implications by specifying both?


Yeah, this looks better that way. Thanks!


Sorry, I just noticed this, for some reason last night it did not copy over one of the changed to fix that Num_phrase was been registered as a phrase. There is a new pull request that fixes this.


Pushed by accident, will fix before lunch


According to Tics, calling multiple macros with the same arguments in the same line is a CS violation. Could you please change sixlowpan_iphc_tf() to have one macro invocation per line?


ack


改动有点大哦


* TODO: rewrite this as it is doing way too much and is very messy now.


Recently they had supported it. That's the reason why I made this change.
They have undone it again...


Hi,

Thanks, could you please post your questions on the siren-user mailing list [1], instead on github. Github is for development purpose only.

[1] https://groups.google.com/a/siren.solutions/forum/#!forum/siren-user

Thanks


Also, perhaps we need a better comment explaining what's happening in iphc_tf, rather than just listing byte masks


Will do tonight! (really late probably, I have a deadline for an assignment)


с переносом, а не со спанами внутри — может оказаться сложнее стилизовать.


This is remaining unimplemented code, it doesn't matter.


This does not work. consider the case in the example:

```
dup_index_left = 1
dup_index_right = 2
```

in this case the loop does not run as the call to xrange becomes ```xrange(2,2)```. For me using a while loop feels more intuitive here.


пишите блок в корневом контексте, а все элементы внутри через амперсанд.


Class UpdateGitMirror is missing a docblock.


I thought it should be part of the `README.md` documentation of each component.  That would be minimum (and I think I didn't do it for CW, haha).


тут и ниже — через амперсанд.


Please have a look at the _map_names() implementation in networking-cisco/networking_cisco/plugins/cisco/l3/drivers/asr1k/aci_asr1k_routertype_driver.py, and _get_network_aci_tenant() implementation in apic-ml2-driver/apic_ml2/neutron/plugins/ml2/drivers/cisco/apic/mechanism_apic.py. The first gets the mapped network name in ACI from the DB, while the second checks to see how the ML2 mechanism driver is configured, and may return the common tenant name instead.


I've just checked that BZ, that very much looks like a bug in the git version shipped by RHEL6, from the logs you pasted there. I am happy to move back to git myself, but then our friends in China will have problems, and we don't want that.

So let's wait and see how it goes.


двойной белый!


@rap1ds This doesn't seem quite right - do you remember why overwriting `email_changed?` is done? Shouldn't `email_required?` be enough?


Hello! Can you post a source code of CreateMonsterData.exe?


Check in


Oh, I'm so sorry, you're right. Looks good.


Have you considered created a macro?

```
#if BYTE_ORDER == LITTLE_ENDIAN
#define ENDIAN_32BIT_MASK (u_int32_t)0xffff0000
#else
#define ENDIAN_32BIT_MASK (u_int32_t)0x0000ffff
#endif
if ((ip6->s6_addr32[3] & (u_int32_t) htonl((0xffffffff << (32 - bits)))) == net->s_addr && (ip6->s6_addr32[2] == ENDIAN_32BIT_MASK) && (ip6->s6_addr32[1] == 0) && (ip6->s6_addr32[0] == 0))
```


I can change it to this though:

```
        for idx in xrange(dup_index_left + 1, dup_index_right + 1):
            new_index[idx] += delta
            delta += delta
```

But any bias against while loops :wink:


So what if someone writes their own bot using Discord.js?
There is no way to effectively override the user agent.


OK, I've at least add documentation in CP and CW `README.md` files.


README.md


Why do we need the full iostream include here?


@topherfangio It seems that way. Hiding the name/email fileds with ng-show works:
http://codepen.io/anon/pen/PZqEaM

However that is not a solution for me, I am trying to dynamically hide parts of a form. If i just hide them with ng-show/hide they still get validated and submission fails.


Missing comma


Fix #146


I don't think this belongs in the library, but in the decompiler. Although if we choose to normalize new lines, we should do it correctly. See http://stackoverflow.com/a/141069/2200891


what a trash


Awesome, thanks.


This was commited by me, not DRW SQL.
Still figuring this github out...


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8957](https://teamcity.mesosphere.io/viewLog.html?buildId=90149&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:08:14


Hi Mark, I just noticed this when we started forking the repo. You can remove the commit/key from github with a little work


Yep j'ai vu juste après :p


Needs a check/case for `None selected` ?


OK


Maybe a stupid suggestion, but could this be applied there : https://github.com/odoo/odoo/blob/9.0/openerp/tools/mail.py#L46 ?
Otherwise, cleaning is processed every time the message is read, which might not be the most efficient.


All right, nice work there.


nay he's right. your being defensive for no reason


typo, `tje` -> `the`


I have just get rid of duplicit definitions of the < li >


I have no idea. I spend like two hours debugging this with no success. Can you add a todo and investigate this? Try tuning compiler options.


The role is created if necessary during push:
https://github.com/travcorp/aws-tools/blob/assuming-roles/TTC.Deployment.AmazonWebServices/Deployer.cs#L132
...should this actually happen during deploy?


Great


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8958](https://teamcity.mesosphere.io/viewLog.html?buildId=90151&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:01


Use { }


this isn't better, cause:

1. std::function is the `devil` and causes a lot overhead (it's not the same as a function pointer, see http://goo.gl/oI2eSv)
2. gcc sometimes can optimize branches to even better code than array lookup, while it cannot further optimize arrays


```
Bot authors, please include the following in your user-agent "DiscordBot (githubUrl, versionNumber)"
i.e.: python-requests/1.2.3 DiscordBot (https://github.com/Rapptz/discord.py, v0.9.0)
```
The user-agent addition is a new requirement from the Discord devs. Unless I'm misunderstanding, there is no need for hydra or any library author to expose this to the users for changing as it shouldn't be changed unless you're writing your own library.


Hi ,bạn làm thêm cái nghe nhạc lossless ở trang chiasenhac nữa đi nha


Remove space


that was fast! It's not even pulled to the main branch yet ;-)


Ah. ok. This is only about push, so it's probably correct.  So this thing relies on a permission that can create roles.

Possibly seems odd that the S3 Push command requires the ability to read and perhaps create roles?


back


Hmm, I tried to reproduce by adding or updating the platform but this code path is not triggered with cordova-cli@4.3.1 or 5.x AFAICT.

However, there is clearly a bug in that the function is missing. It should rather be something like:
instalNodeDependencies(checkNodeDependencies.bind(null, callback));

Can you verify if that helps in your case ? Thanks


Should be EMERALD.


I was going to comment on this in your last PR, but strings are in alphabetical order in the en.json files. It was unfortunatly "broken" with the L4/L5 string.

Also, if these strings are for the mouse over, perhaps the "description" field should say that (it's a helpful string shown to the translators when they work on the string, so they know how it is used).

Also, because the strings are in alphabetical order, I usually choose a name that is prefixed by something so similar strings are close. Here I would perhaps have prefixed them by: `"TOGGLE_`. The message text itself can be unchanged.

Anyway, that is my suggestion. I don't know what the others think about this.


@marcin992, mam pytanie:
* ten $http.get idzie jakoś zastąpić? Dawałem do parametrów in Timesheet, ale sypał błędem (trzeba coś gdzieś dorzucić?)


This `{`…`}` is completely superfluous.


Please avoid whitespace only lines


Ah, OK, it's not that hard of a decision to make. It's fine to find the test first, then go to the dreaded nested try/except preprocess/run/postprocess block. Looks good to me.


"if" into sql request must be managed with $db->ifsql
Also this report is not relevant because there is not date filter so may be too stable to be interesting to have it as "always visible".
That's why for the moment, i prefer keep by default only common view to all objects (opened draft, last modified). But you can introduce a hidden option to keep it in standard code.

In a future, i planned to introduces boxes for other "home pages" than home page.


Should we fix this? Is it really necessary to add formatting rules, or would that add too much [unmanageable] bloat?


Had to change this because changing the form_id could mean moving it to a different DB


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8960](https://teamcity.mesosphere.io/viewLog.html?buildId=90154&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:08


Fix #147


Do jakich parametrów?


Maybe just remove 'Loop'?
```
 Content successfully parsed
```
And that is it.


Как ты понимаешь, имхо не считается :)

-----Исходное сообщение-----
От: "Artur Ayukhanov" <notifications@github.com>
Отправлено: 10.12.2015 13:41
Кому: "EvilBeaver/oscript-library" <oscript-library@noreply.github.com>
Копия: "Andrei Ovsiankin" <ovsiankin.aa@gmail.com>
Тема: Re: [oscript-library] Исправил работу с 8.3.7 (линейная выгрузка) fix #39 (91ba744)

Имхо для старых версий параметр -format просто не анализируется и будет
просто пропущен

чт, 10 Дек 2015, 13:06, Andrei Ovsiankin <notifications@github.com>:

> А на предыдущие версии платформы это повлияет? Те у кого нет 8.3.7 не
> отвалятся?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/EvilBeaver/oscript-library/commit/91ba744973a6834bba3c21a99fff01b2a8ba1966#commitcomment-14895843>
> .
>

—
Reply to this email directly or view it on GitHub.


I am currently working on a tank with  gui in 1.8.8 and I was using the vanilla way of gui/container updates (via detectAndSendChanges). Therefore I used fluid.getID() to send the fluid id. I thought this way was "standard", shall I use own packets now or is there another way?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8959](https://teamcity.mesosphere.io/viewLog.html?buildId=90152&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:07:03


テストユーザー入れたんだ。　いいね！


I think it already does, but I will double check while applying the rest of the review to be sure.


It's a temporary work around to get this job passing and unblock others
while I continue to figure out why a couple tests fail only on postgres 8.4
(I.e el6).
On Dec 10, 2015 2:44 AM, "Dominic Cleal" <notifications@github.com> wrote:

> @ehelms <https://github.com/ehelms> is this needed? We don't have a lot
> of el7 capacity.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/theforeman/foreman-infra/commit/8f4feb3e1d4fc9443a7518c1497d0e7af4d89ae7#commitcomment-14893347>
> .
>


ここらへんの自動生成のやついらないから消しましょう。
マニュアルに消し方&今後自動生成されない方法書いてたかと思います。


nope ;)


No it can't because the method "html_sanitize" is applied on every field of type html and we sanitize those fields on the website. We only want to sanitize classes (and maybe the inline style, still in discussion) in the incoming mail and on messages. But I agree that it is not the most efficient, this will probably be refactored in master.


null falseいらないです


Excuse me, in your plugin you use phone-codes.js, but i have an error with it, but if i rename phone-codes.js to phone-codes.json - it is ok, why you use phone-codes.js???


Hi
thanks.

I updated both. Cleared the browser cache completely. No difference.

I am changing the files in umbraco/lib/angular/1.1.5/angular.js
I am changing the files in umbraco/lib/angular/1.1.5/angular.min.js

thanks
stephen

On Thu, Dec 10, 2015 at 10:14 AM, Sebastiaan Janssen <
notifications@github.com> wrote:

> Also: you can't just update angular.js, you need to update angular.min.js,
> it's downloadable from the link above.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/umbraco/Umbraco-CMS/commit/d5f9dfecc465d9d5e8d44f01d3e1dd94c4822840#commitcomment-14896018>
> .
>


+  .controller('TimeSheetController', function($scope, $http, Auth) {
zamiast $http


up till lately i was just hitting /chat and that pretty much covered my needs but that isnt ideal now that the mods starting to mature.


Looks like this needs more changes in tests and other modules importing Prelude. Will fix it as a separate issue.


カラムはただ追加するだけなので今やっちゃってもいいよ


Not true.  I just tested and every setting works except syslog filter.


I will add a fix now


That was a flawed approach anyways, since fluid IDs can be bigger than a short.


Is part of the public header, therefore someone can use it so it doesn't hurt to be documented.
Also, isn't a major issue if someone decides to use it even that it wasn't intended.


Fix #147


Maybe I'm misunderstanding what the intention is here but won't this just fix the observed yield to the sum of backgrounds, not the shape?


Fix #148


Hi, so i just try to update my ptoject here and i got a lot of erros because my environment just don't know what is "p1_time_compat", i see that the method that you use belongs to the "erlang", you create some king of alias?


this doesn't look right, I think you want to use the `adt` module in trans (`librustc_trans/trans/adt.rs`). First you want to find the type of the discriminant and convert it to an `trans::Adt` using `adt::represent_type` (note that this trans ADT has no relation to the `adt_def` you already have, other than modeling the same thing but in different parts of the compiler and in different ways). You can then call `adt::trans_get_discr`, where `scrutinee` would be `discr_lvalue.llval` and the `r` parameter is the result of `adt::represent_type`. I THINK you can pass `None` for `cast_to`. This will return to you an integer then you can use to build the switch below.


**Code Quality - Nitpick**

Your function names should depict their action. Currently, this function get's the user's session, and hence can be class `.session`. As discussed during your defense.


自傲组 --> 小组？


yes, it's not the best thing but it's possible to proceed. The client should treat as  `application/octet-stream` when not content-type is set.


Running `make update` should update the dependencies in the `deps` folder, and "p1_time_compat" should then be found.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8961](https://teamcity.mesosphere.io/viewLog.html?buildId=90155&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:28


We could just issue a warning instead of going-to here as well, no?


I get a warning when defining case classes without arguments; you can use `case object` instead:
```scala
case object TopAxiomTactic extends Tactic {
  ...
}
```


"Hybrid" is a nice term for that, but you're calling it "mixed" elsewhere, so it's a bit confusing.


@imcaffrey 额，非常感谢。


wow :+1: thanks a lot. i will try this


I have no idea, will check that.


Fix #149


With this commit you can use Spectrum 128 ROM even if you have spectrum.rom on SD card.
If you need ESXDOS with TAP format, then press F11 and ESXDOS will be launched with Spectrum 48 Basic. Subsequent F11 presses will open ESXDOS menu.


No, why, just select nothing (or all).


Dobrze rozumiem, że zamiast $http dawałeś Timesheet do argumentów controllera i sypało Ci błędy, że nie może znaleźć Timesheeta? Bo ogólnie chodzi o to, że te argumenty to są nazwy serwisów, które muszą być wcześniej zdefiniowane. Musisz zrobić serwis Timesheet (to angular-fullstack:service Timesheet) i tam dać jakąś logikę.


Please revert this one. As discussed in some cases the optimisations detract from the readability.


My understanding is that the concept of something being counted depends upon the type of the loop condition. So using Unsafe and long's won't affect things like loop unrolling.

Sidenote: pretty sad that the safepoint polling affects so many other things.


@mauricioac may be you'll be interested in this commit:

https://github.com/ptgamr/ember-offline-sync/commit/5fabb0c627aefa1de9afc7a3508a7542f3d4bc52

Here I introduced `AdapterSyncSupportMixin` which you can mixin into your application adapter, which will handle the creation of `sync-operation` on the offlineStore. So you can still use `record.save()` function rather than using `record.emberSync.save()`.

The `sync-operation` then should be picked up & process by the queue. I'm working on this.

Let me know what do you think?

Cheers,


This fixes the issue #30


Why is this "internal-only"? Why can't you create a user-defined function that behaves this way?


Like we discussed please keep this change only, and revert the rest of the changes in this commit.


ok. And could this be applied in create/write method of 'mail.mail' and 'mail.message'?


yes, but everywhere else in this code, if the return fails it goes to `end`. I just follow the current treatment.


For this one, we must keep a static js file. Goal of this is to know if js static files are compressed by server so testing on dynamic php file return false result.


@avontoun don't forget to update your clientdependency.config as well.


I've written you already that you need to make comprehensive patch title and description. Please find my comment and fix.


The name is a bit confusing. In GANGTYPE_ENTRYDB_READER, the "ENTRYDB" part means that it reads the entry db, and in GANGTYPE_PRIMARY_READER, the "PRIMARY" part means that it reads the primary. Following that example, I would expect the new type to be called "GANGTYPE_MIXED_READER" or "GANGTYPE_BOTH_READER" or similar.


Also a simple way to do the blinding with the shape would be something like (assuming the `bin` name is unique for each category):

~~~cpp
for (auto b : bins) {
  cp().cp().bin({b}).ForEachObs([&](ch::Observation *obs) {
    obs->set_shape(cp.cp().bin({b}).backgrounds().GetShape(), true);
  };
}
~~~


you can use nil directly.


Have you tested this feature? How have you done it?


What is wrong with
parseFloat(amount).toFixed(rounding);
?


This file is now exclusively made for json stuff (see the name), no?


oops I think this commit broke the `oc explain` completion (which used `__oc_k8s_types`)


Start of


Please make sure that the comments aren't removed here and in the changes above.


Not according to "tde", apparently we had trouble in the past because we did not keep the original messages.


document? Why not string?


Comments should be kept in this file as well.


@imcaffrey fixed in https://github.com/QingdaoU/OnlineJudge/commit/932d2ea3e77ef81a06cb57cbc4f4eee2567590cc


And?


We can initialize this with `Set` as we are parsing each cell so it may be a performance hit, so `set` will give highest performance at cost of little more memory, thoughts?


I'm just about shutdown for the night but was having a look through the logcat for obvious stuff.

Commenting preloadResources(); in line 236 of /frameworks/base/core/java/com/android/internal/os/ZygoteInit.java
might shave a couple more seconds during the boot animation and possibly free a tiny bit of ram at the expense of apps take a moment longer to load.


What's this all about? Unrelated leftover test changes?


... because some invalid JSON construct was found


ok thanks


trying to fix master_5.txt


Why not current token's type?


leaking mmf


I recognize that my page does not compatable with 15.6 inch monitors. Because all my tests are done on my 17.3 inch computer. I will fix it.


remove extra newlines


Please revert this change.


@173210 Thanks for reply. I was wondering if the corresponding key is set during the normal code aside with the process9. And ..
1.Process9 of N3DS NATIVE_FIRM 9.6 cann't decrypted by us now.
2.fs, pxi, sm, and other modules are inside ARM11 and all decrypted.
I don't expect a full launch, I just wonder if we can have it decrypted by using the code with it, and don't need to do a full boot. Eh, just use it for a decryption.


So that it writes None if None are selected. Now it just ends in `:`


Fix for issue #48


Really good point. Can you provide a PR? I gotta head to work. :smile:


There is no actual error description page for ngAnimate[areq], so I would just access the ng[areq] error. I think that's okay because argument required is a very generic error.


Thanks for all this typos :)


Sure.


fix in next commit


Set this as temporary as well, to make the OS avoid writing to it if possible.


What's the difference from the other without the *ALL* thing? It won't stop in intermediate errors?


Need to do this in the temp path folder defined in the Options.


It also makes sense put ERROR_VALUES in the parent Excelx class, that way, we avoid the issue all together.


No problem, happy to help :-)

Is it planned to add support for TokuDB?


Formatted some code, added global function to mdlGlobal.
Account page is working correctly at barebones.


Since we got the non-nested variation, we could write ``@b nested`` or something like that.


So we always have tmp files to restore?


Ditto, WRT ``ALL``.


Set to null afterward


Only in debug? `since` might need a translation.


Ederson's point is valid here too.


Only in debug builds


It is not the current type. It is the type of all elements. I would add here that macro will fail if any element with different type is found.


Extra line at end of file :)


Please remove one extra line.


setting `_action = null;` prevents me from using an action within a `Repeat`, since the first time the action runs, it sets `_action` as null and then the next time it will be skipped, so for example in this code:

``` java
      anim.repeat(button)
            .delay(500).then().action(() -> button.setImage(dnImg)).then()
            .delay(500).then().action(() -> button.setImage(upImg).then()
            .shake(button);
```
it will only display the images the first time, then it will only delay and shake (without changing the images)

Any workaround for this?


Add apache license text


I wonder why is this exposed. Document why/how one would actually need it, also.


Is there a way to make clear which parameters are set by macro and which are expected to have some value? scanner and element_type_ are set by the user. Token_ and end_reason_ are filled by macro. that is not clear in doc.


Use
if (!img)
     return -1;
Code style everywhere.


It would be nice to have sample codes for these macros. Are you planning to do it later?


I also prefer string.


debug output


@stevendaniels Why are we using both `Minitest` & `Rspec`?


The problem here is 2 fold. We got some user code, e.g:

    int position = YYYY;
    int limit = XXX;
    for(;position<limit;position++){
        DirectBuffer.putByte(position, 0);
    }

And with the API change they are likely to do:
    long position = YYYY;
    long limit = XXX;
    for(;position<limit;position++){
        DirectBuffer.putByte(position, 0);
    }

The first problem is that since we use Unasfe we won't get the OptimizeFill lovin'. In either version.
The second problem is that the second loop will have a safepoint poll and won't get unrolled. This is a reality rather than a necessity. The compiler could (and should) unroll and then safepoint poll, but it doesn't.
Changing the offset type can have the above knock on effect in user code. I think if the limit is an int the loop is still counted, but that seems wrong usage.


Add @see to macros that uses this scanner, so users will know how to use the scanner.


We had that internal discussion on this. We think there needs to be a clearer distinction between the memory attributes that are simple boolean attributes (e.g. Secure/Non-Secure) and the ones that have a more complex representation (for example, the cacheability, shareability and device memory specific attribututes). For the latter, this probably involves allocating a bitfield to represent the valid combinations of these more complex memory attributes. We think we can do this in a backwards compatible way but the precise API changes are going to require some more thought.

We are happy to do this (by implementing https://github.com/ARM-software/tf-issues/issues/336) but this won't be possible until early next year. Are you able to carry your change as a temporary fix in your own branch until then? Perhaps we can work through upstreaming of the other PRs while this is in progress?


Hi heikki,
    You are right,thanks for pointing out my mistakes to me :).
    When I first saw "checking for builtin __sync int64 atomic operations... no" on my 32bit Linux, i mistakenly thought that 32-bit gcc don't support int64 atomic operations(Even if I was just use __sync_val_compare_and_swap(int64 ...) a few days ago on 32bit platform),Maybe there was a glitch in my brain at that time :) ,I thought it was normal, so i was not dig into it(config.log)
    I'll fix this

Date: Tue, 8 Dec 2015 00:09:38 -0800
From: notifications@github.com
To: gpdb@noreply.github.com
CC: dbx_c@hotmail.com
Subject: Re: [gpdb] Fix issue #74, make cluster in gpdemo failed(initdb failed on a 32-bit VM) (9a28a44)

On 19/11/15 08:39, Robert Mu wrote:

> @hlinnaka

> Thanks for review the  code.If we on 32-bit linux:

>

> ./configure --enable-debug --enable-cassert

> checking for builtin __sync int64 atomic operations... no

> checking for builtin __atomic int64 atomic operations... no

Hmm. Looking at config.log, those configure tests are actually not

failing because the support isn't there, but because of a little glitch

in the backport:

> configure:13656: checking for builtin __sync int64 atomic operations

> configure:13673: ccache gcc -o conftest -O3 -std=gnu99  -Wall -Wmissing-prototypes -Wpointer-arith -Wendif-labels -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-unused-but-set-variable -Wno-address -g -ggdb   -D_GNU_SOURCE    conftest.c -lbz2 -lrt -lz -lreadline -lcrypt -ldl -lm  -L/usr/lib/i386-linux-gnu -lcurl >&5

> conftest.c: In function 'main':

> conftest.c:174:1: error: unknown type name 'PG_INT64_TYPE'

> conftest.c:175:43: error: 'PG_INT64_TYPE' undeclared (first use in this function)

> conftest.c:175:43: note: each undeclared identifier is reported only once for each function it appears in

> conftest.c:175:58: error: expected ')' before numeric constant

PG_INT64_TYPE was introduced in PostgreSQL in commit

95d035e66d8e4371d35830d81f39face03cd4c45, which is not in GPDB yet. That

patch changed a bunch of things, so I'd suggest only picking the

PG_INT64_TYPE part of that patch. IOW, take this:

diff --git a/configure.in b/configure.in

index fef8e7f..2dee4b3 100644

--- a/configure.in

+++ b/configure.in

@@ -1580,13 +1580,19 @@ dnl 64-bit type.  But we still handle the case

of snprintf being broken.

  PGAC_TYPE_64BIT_INT([long int])

-if test x"$HAVE_LONG_INT_64" = x"no" ; then

+if test x"$HAVE_LONG_INT_64" = x"yes" ; then

+  pg_int64_type="long int"

+else

    PGAC_TYPE_64BIT_INT([long long int])

-  if test x"$HAVE_LONG_LONG_INT_64" = x"no" ; then

+  if test x"$HAVE_LONG_LONG_INT_64" = x"yes" ; then

+    pg_int64_type="long long int"

+  else

      AC_MSG_ERROR([Cannot find a working 64-bit integer type.])

    fi

  fi

+AC_DEFINE_UNQUOTED(PG_INT64_TYPE, $pg_int64_type,

+  [Define to the name of a signed 64-bit integer type.])

  dnl If we need to use "long long int", figure out whether nnnLL

notation works.

With that, you can remove the assembly from gp_atomic.h.

I would also suggest replacing the calls to the GPDB-specific

compare_and_swap_64, compare_and_swap_ulong, gp_atomic_add_32 and

gp_atomic_add_64 functions with direct calls to the corresponding

pg_atomic_* functions.

With those changes, and rebasing over current master, I think this is

pretty much ready for merging.

- Heikki

―
Reply to this email directly or view it on GitHub.


Owu, you are saying because of the group? We do that for all major "groups" on which we organize stuff in. Like IO, you dont have a sol-io.h, we define this group on gpio.h, the same for comms. For every category (except common) we choose a file to hold the code defining the group.


we do not have image_upload attribute type


sorry s prijímateľov, pomýlil som si to s iným inputom


I also vote for removing the _.


TeamCity pull requests :: netty [Build 819](https://garage.netty.io/teamcity/viewLog.html?buildId=3931&buildTypeId=pulls_netty&guest=1) is now running


TeamCity pull requests :: netty [Build 819](https://garage.netty.io/teamcity/viewLog.html?buildId=3931&buildTypeId=pulls_netty&guest=1) outcome was **UNKNOWN**
Summary: Canceled Build time: 00:00:31


TeamCity pull requests :: netty [Build 820](https://garage.netty.io/teamcity/viewLog.html?buildId=3932&buildTypeId=pulls_netty&guest=1) is now running


Nice! Thanks for sorting this Mike :beer:. Another thing saved from my to-do list.


"with locale == C" might be worth citing.


I would add an @see to link to scanner_init.


Actually, these changes only impact test resources. And yes, this is just to remove deprecated use of bean declarations. worst case scenario, unit tests will fail


I'll remove the commented code - its safe in another branch if needed later


I would place BaseTest in top of hierarchy  to have possibility to use it for other components as well.
Just in case


That's not how you do that


please make passing strings by reference or const reference, not by value. If u want pass by value, you should force move sematnics


do something like `schedule_hook` or something? :)


fgf


maybe `shell:stubAppJS`? not sure if it's clear what `touchApp` would do


**Code Quality - Critical**

You should have just one attribute container in JADE.


Next release will show "-"


The difference from SOL_JSON_SCANNER_OBJECT_LOOP is not clear. I would state that the difference is that it is not starting from the beginning of the JSON string pointed by scanner.


It does.


Because 'document' is the usual word for the content to be parsed on "parser's world". It's the same for xml and other parses. You dont parse a XML string, you parse a xml document that is happens to be in a string.


kk


Why
     -O, --to-stdout
           extract files to standard output
tar option isn't used here?


I thing it is better to move the helpers below in BaseTest, or even create some middle class NeutronBaseTest move the helpers in it.


Не проверял нигде кроме лисы :D


I think invalid construct isn't the only reason, sometimes the construct is valid but isn't the one you are looking for, than invalid is returned.


I am a nice comment


**Code Quality - Critical**

You don't 3 conditionals for this check.
 - Ideally, if `err` is set, `doc` will not be set.
 - The `res.send` here will send a status code of `200`, which is wrong, being an error.


I wonder why ``json_serialize()`` and ``json_serialize_key_element()`` are not exported, since we got these.


Happy 1000-nth commit!


**Code Quality - Nitpick**

Use `.send` or `.json` consistently. Given that you are sending objects, and both send and object response to the client.


Why not node `5.x`?


readme


Why not just delete this file if you're moving all the logic to package.json?


w :smile:


**Code Quality - Nitpick**

Using commas to separate attributes in JADE is redundant.


Is this a compiled file? Why is it included?


stripes = strips...


Dunno, but the case of reason is even trickier, you gives an initial valid that is taken in consideration, only after the first iteration it becomes an output parameter. Its useful when parsing nested loops.


@blpabhishek @BinduST @negiDharmendra  @ar000n
I regret for my commit message. It was not html section but it was
"Help section has been added."
  Thank You.


dangerous syntax here with the starting `.`...


State here that the string in JSON may be escaped and in this case this won't work and user needs to use sol_json_token_get_unescaped_string() to compare


same comment about escaping here.


This now requires to checkout the new KappaTools master and compile it using cmake:
```
cd ../KappaTools
cmake .
make -j12
```
It might be safer to do a `make clean` before or clone KappaTools from scratch.


These reformattings looks tons better :grinning:


Ok ignore earlier comment haha


updatess


a


No, the difference is what is said in additional of 'no-ALL' version: "ignoring the elements type". It parses no homogeneous arrays, 'no-ALL' triggers an error if an element in the array isn't of the expected type.


なんで is とかつけたんだ、とか思って直そうとして
さらにこういうのは AR がよしなにしてくれることを思い出した。


Ow, then I need to quit developing


Add a comment saying that this function is used by Macros and using the macro instead of calling the function is recommended. Or something like that.


I don't think `return` is intentional here.


Well, it is perfect. Its ok now. Thanks again. :+1:


should be deleted, not just commented out


@anandpdoshi the error just changed

```python
Traceback (innermost last):
  File "/vagrant/frappe-bench/apps/frappe/frappe/app.py", line 67, in application
    response = frappe.handler.handle()
  File "/vagrant/frappe-bench/apps/frappe/frappe/handler.py", line 77, in handle
    execute_cmd(cmd)
  File "/vagrant/frappe-bench/apps/frappe/frappe/handler.py", line 94, in execute_cmd
    ret = frappe.call(method, **frappe.form_dict)
  File "/vagrant/frappe-bench/apps/frappe/frappe/__init__.py", line 788, in call
    return fn(*args, **newargs)
  File "/vagrant/frappe-bench/apps/frappe/frappe/handler.py", line 29, in runserverobj
    frappe.desk.form.run_method.runserverobj(method, docs=docs, dt=dt, dn=dn, arg=arg, args=args)
  File "/vagrant/frappe-bench/apps/frappe/frappe/desk/form/run_method.py", line 41, in runserverobj
    r = doc.run_method(method, **args)
  File "/vagrant/frappe-bench/apps/frappe/frappe/model/document.py", line 551, in run_method
    return Document.hook(fn)(self, *args, **kwargs)
  File "/vagrant/frappe-bench/apps/frappe/frappe/model/document.py", line 706, in composer
    return composed(self, method, *args, **kwargs)
  File "/vagrant/frappe-bench/apps/frappe/frappe/model/document.py", line 689, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "/vagrant/frappe-bench/apps/frappe/frappe/model/document.py", line 545, in <lambda>
    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
  File "/vagrant/frappe-bench/apps/bios_mx/bios_mx/bios_mx/doctype/sat_settings/sat_settings.py", line 35, in test_authorize
    xml = self.__xml_signature(cfdi, xslt)
  File "/vagrant/frappe-bench/apps/bios_mx/bios_mx/bios_mx/doctype/sat_settings/sat_settings.py", line 100, in __xml_signature
    key_data = get_file(self.certificate_key)[1]
  File "/vagrant/frappe-bench/apps/frappe/frappe/utils/file_manager.py", line 294, in get_file
    file_path = get_file_path(fname)
  File "/vagrant/frappe-bench/apps/frappe/frappe/utils/file_manager.py", line 321, in get_file_path
    frappe.throw(_("There is some problem with the file url: {0}").format(file_path))
  File "/vagrant/frappe-bench/apps/frappe/frappe/__init__.py", line 257, in throw
    msgprint(msg, raise_exception=exc)
  File "/vagrant/frappe-bench/apps/frappe/frappe/__init__.py", line 250, in msgprint
    _raise_exception()
  File "/vagrant/frappe-bench/apps/frappe/frappe/__init__.py", line 235, in _raise_exception
    raise raise_exception, encode(msg)
 ValidationError: There is some problem with the file url:
```

I'm passing the value of a attach field and getting this error


add here that size is in bytes.


@belangeo : Did this issue only affect 64-bit pyo? I am guessing that it affected 32-bit as well, by the look of the code here. If its only 64 that would save @peircej from having to recompile for Windows 32.


You don't even know what that is, do you? it is not "the Maven package". it refers to "maven's package command", i.e. the command `mvn package`, where `mvn` is short for maven.


Thanks, please pull, should be fixed now.


Oups, bad quick rewriting. Thanks


What this change is for? How it's related to WMPL?
property_overview.css must not be edited directly. Use /static/styles/src/property_overview.less file for it.


Code repetition


I like the `-i` in the `System.out.print` it backs up a letter as the `for` loop moves forward. I was wondering why you started the `for` loop at 1, now it makes sense.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8962](https://teamcity.mesosphere.io/viewLog.html?buildId=90166&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:03:00


Sure. I've added todo and will investigate this further.


I think that the explanation is very straight forward already, there is no reason to complicate or over explain simple stuff. You have a token, this tells you the type of this token.

While parsing stuff to is common practice to receive a token from the parser and check it's type to decide what to do.


json_serialize() and json_serialize_key_element() are defined in json.c file that is the code for JSON nodes. They use specific json node structures to decide how to serialize the json. It doesn't make sense to export them.


This code still exists. Why?


You could invert the comparisons, no? Like ``size && SOL_JSON_TOKEN_STR_LITERAL_EQ(&key, "size")``.


Great, it works fine now


j


It's first try to use WiHD as a Jackett Provider,
Working as well, but **not ready for using in a production environment**.
Actually using global search (limited to five torrent results)
Need rewrittinge to use torrent search.

**Informations on release:**
- [x] Title
- [x] Guid
- [x] Link
- [x] MinimumSeedTime (*Not official*)
- [x] MinimumRatio (*Not official*)
- [x] Category (*Forced*)
- [ ] Size
- [ ] Description
- [ ] Seeders
- [ ] Peers
- [ ] Comments


It's ok.


Not sure if it's due to this commit, but Travis CI tells me that ever since this one has been merged, the builds haven't passed ever since. There are core dumps and segmentation faults.


This should probably say who disproved it.


As far as I remember all methods works fine if the string is not null terminated. It would be nice to state that in scanner_init() what do you think?


Looks like a sensible move


needs to be,
id=${MDS_ID}


Ifdef this part, I guess.


Ditto.


Credit to mailwl and Kloen.


@nickrobson this is faster and cleaner, aside that he forgot that there was a join Collector


@ivan19871002 Sorry, I never wanted to rush you. I just want to help you ... but I think you don't want it.


gah, cant believe i missed this :)


Nice, short and very `DRY`. In out and over. Nice use of the `for` to load then print the items.


It seems the pattern is "use the STL, explode your asm, kill your instr-cache, go back to raw C".

(I do know inlining breaks, but the functions called here are probably too big for it)


std::string(xyz.c_str()) would still look wrong...


You will have to fix the field value. Remove attach_files:

Sent from my phone

> On 10-Dec-2015, at 6:23 PM, Maxwell <notifications@github.com> wrote:
>
> @anandpdoshi the error just changed
>
> Traceback (innermost last):
>   File "/vagrant/frappe-bench/apps/frappe/frappe/app.py", line 67, in application
>     response = frappe.handler.handle()
>   File "/vagrant/frappe-bench/apps/frappe/frappe/handler.py", line 77, in handle
>     execute_cmd(cmd)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/handler.py", line 94, in execute_cmd
>     ret = frappe.call(method, **frappe.form_dict)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/__init__.py", line 788, in call
>     return fn(*args, **newargs)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/handler.py", line 29, in runserverobj
>     frappe.desk.form.run_method.runserverobj(method, docs=docs, dt=dt, dn=dn, arg=arg, args=args)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/desk/form/run_method.py", line 41, in runserverobj
>     r = doc.run_method(method, **args)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/model/document.py", line 551, in run_method
>     return Document.hook(fn)(self, *args, **kwargs)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/model/document.py", line 706, in composer
>     return composed(self, method, *args, **kwargs)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/model/document.py", line 689, in runner
>     add_to_return_value(self, fn(self, *args, **kwargs))
>   File "/vagrant/frappe-bench/apps/frappe/frappe/model/document.py", line 545, in <lambda>
>     fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
>   File "/vagrant/frappe-bench/apps/bios_mx/bios_mx/bios_mx/doctype/sat_settings/sat_settings.py", line 35, in test_authorize
>     xml = self.__xml_signature(cfdi, xslt)
>   File "/vagrant/frappe-bench/apps/bios_mx/bios_mx/bios_mx/doctype/sat_settings/sat_settings.py", line 100, in __xml_signature
>     key_data = get_file(self.certificate_key)[1]
>   File "/vagrant/frappe-bench/apps/frappe/frappe/utils/file_manager.py", line 294, in get_file
>     file_path = get_file_path(fname)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/utils/file_manager.py", line 321, in get_file_path
>     frappe.throw(_("There is some problem with the file url: {0}").format(file_path))
>   File "/vagrant/frappe-bench/apps/frappe/frappe/__init__.py", line 257, in throw
>     msgprint(msg, raise_exception=exc)
>   File "/vagrant/frappe-bench/apps/frappe/frappe/__init__.py", line 250, in msgprint
>     _raise_exception()
>   File "/vagrant/frappe-bench/apps/frappe/frappe/__init__.py", line 235, in _raise_exception
>     raise raise_exception, encode(msg)
>  ValidationError: There is some problem with the file url:
> I'm passing the value of a attach field and getting this error
>
> —
> Reply to this email directly or view it on GitHub.
>


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8963](https://teamcity.mesosphere.io/viewLog.html?buildId=90167&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:07:04


i'll be working on more testing today


I am a nice comment


Thanks! BitHub has sent payment of  $35.80USD for this commit.


Thanks! BitHub has sent payment of  $35.09USD for this commit.


Thanks! BitHub has sent payment of  $34.39USD for this commit.


Thanks! BitHub has sent payment of  $33.70USD for this commit.


Thanks! BitHub has sent payment of  $33.03USD for this commit.


Change please to the following construction:

`$value  = ($tag == 'property_type') ? apply_filters('wpp_stat_filter_property_type',$data[ 'value' ]) : $data[ 'value' ];`


Indeed. Something broke... didn't have time to see which mix of versions
gets hit.

On Thu, Dec 10, 2015 at 1:58 PM, Patrik Wenger <notifications@github.com>
wrote:

> Not sure if it's due to this commit, but Travis CI tells me that ever
> since this one has been merged, the builds haven't passed ever since. There
> are core dumps and segmentation faults.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/zeromq/czmq/commit/f142c5e99062d971e9241c479d1ee24762fc6ef5#commitcomment-14899210>
> .
>


You have a token on the function below, here you have crude memory.


Change please to the following construction:

`$value = ($tag == 'property_type') ? apply_filters('wpp_stat_filter_property_type',$data[ 'value' ]) : $data[ 'value' ];`


I'm quite worried about the config approach:

1. Most users don't care about configs, they just expect it to work. What we want is to make sure that strange values won't get in their way. I'd rather use a config to prevent flooring the `devicePixelRatio` (opt-out) rather than one that must be defined to fix something (opt-in)
2. With a config, once the user will have changed it, we won't be able to respond to changes at the os level (people tweaking their os scaling, people moving Atom from a retina screen to a non retina screen, etc.)
3. Some users use a package to synchronize their config across several computer, with that config, the user may get weird result on one computer if it adjusted it to fix an issue on another one.

My advice here would be to keep the `Minimap#getDevicePixelRatio` method, but to make it floor/ceil the value unless a `preventDevicePixelRatioRounding` setting is defined.


Let's free all the tmp file nodes here.


You can even remove `@dev`, 3.0 is stable now and this becomes "dangerous".


为什么是 33 和 126?


> This is not really used in this setup. It is used in the commented out Landrush config, but nowhere else.

Will remove it.

> Why do you not change the default route? Being able to specify a hostname here, but then still getting the default OpenShift route names seems non intuitive to me.

It was written sometime back and now I know about changing default Openshift name so will add it.


分享QQ，
YCQQ.shareToQQ(function(){
alert("share success");
},function(failReason){
alter(failReason);
},args);
点击后,提示“cancelled by user”,请问这是怎么回事？why?


Oach, sorry, missed that piece.


pr_err("Can't restore tmp files. Please check restore log for details\n");
Byt please check that  errors are written to such a log.


My Autodeploy fails with error

Failed to Start Docker Application Engine. This is my third attempt to install it.

http://pastebin.com/jC596Qa4

please help!

Jay Soni
jay.soni@outlook.com


you mean only hostname config not landrush part because landrush part do work for Mac/Linux.


I really like class nesting


Use self.env.ref() .


please do the same verbose error reporting as you've done in restore.
pr_err("Can't dump...");


I am using MG-SOFT Visual YANG Designer, which includes compiler and verifier modules.

I will add it back just to have it closed.


Too bad, that you've choosen to use such an ancient thing. IMHO SLF4J would have been much much more appropriate ...


well, this is not really thread safe


Don't forget also to fix:
Во время дампа проверяем access() на путь к файлу. Если путь не доступен, тогда пишем, что файл не найден. А к help'у ключика командной строки добавить что все переданные пути работают в относительно рута процесса CRIU dump/restore.
[20:13:25] Eugene Batalov: Что такое рут процесса CRIU читай в man chroot
[20:24:01] Eugene Batalov: Посмотри, если tar упадет, то можно ли его вывод напечатать в stdout criu.
[20:24:21] Eugene Batalov: А то файл задампить не получилось,  почему  - не понятно


Samples and code snippets are intended for a second pass over the documentation. First we want to have 100% of our C api described. Than we will document the samples and after that add samples and code snippets to the documentation


ok


I would also rename 'tmp files' to 'user saved files'. There are already many concepts of temporary file in CRIU. So current naming may introduce some 'mess' in names. But let's leave it for CRIU ML discussion.


My first comment.


I am a nice comment


2 tanede revert attımmı tamamdır :D :D


closing } should be on the same position as other } in this piece of code


@WWGate You should find another solution. Probably, modify $wp_properties['taxonomies'] before property.php template loaded.

The current template is default. Denali and Madison themes are using own property.php template. And, any user can just move the template to their theme and modify it.


用 chr() 和 ord() 这两个函数。


I'm not sure that this relates directly to the config persistence either, does it? Again, let's split this out if it isn't related - or at least make it another commit with an explanation of the change - think of commits as associated documentation.


Здесь выражение компилируется заново при каждом вызове insertCity, а должно компилироваться один раз в начале, в потом переиспользоваться -- в этом суть оптимизации. В таком виде это ничем не лучше простого инсерта с ContentValues.


uuuhh glad you catched this one :+1:


Uploaded tag 8.5-1.


Fixed. Mistake in my commit.


Q_memset32 is deprecated, use memset.


You can now use `faculty` query param on `/semesters` resource. Example usage: https://sirius.fit.cvut.cz/staging/api/v1/semesters?faculty=18000


MAX_QPATH should only be used for things like shader names. There is MAX_NAME_BYTES.


MJEEENNN!!! JUST REPLACE!


And the import ? IOException is (Iguess) still imported but not used...


MJEEEEN! HERE IT IS!


MJEEEEN! NICE OEPDATTE!!!!


Hi , just asking to @c-schmitz  now :
> (14:15:43) c_schmitz: shnoulle: 2.5 please
> (14:16:30) c_schmitz: shnoulle: gT("columns missing") needs to be fixed to use printf

Then : for 2.5 .... more work i think.


still typo?


what release would this like to make?


MJEEEEN! +1


MJEEEEN LIKE


please remove space


@adammurdoch: That would seem to add a lot of complexity to the relative path computation required when files are removed => https://github.com/gradle/gradle/blob/83fbb3560398721cb2cbe92ed1a5a98330e8189a/subprojects/platform-jvm/src/main/java/org/gradle/jvm/tasks/api/ApiJar.java#L157-L157


MJEEEEEN THATS SOME NICE CODE


i've done it locally, but I'm checking whether to bump to 2.8 as well.


Why are you casting with <List<...>>? You should cast with Boolean/Map<>/String, no?


Uninstall all you docker, restart and try again. It's not a problem of the script but Docker start.
Please use community forum or use my professional services - info@monitoringartist.com.
Thx


MJEEEEEN! YIZ


これなんですけど、いっその事
http://cpplover.blogspot.jp/2015/11/c-p0050r0-p0059r0.html
で紹介があった
[[PDF] P0052R0: Generic Scope Guard and RAII Wrapper for the Standard Library](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/p0052r0.pdf)

のようなものを実装してしまいますか？ユーザーに提供してもいい気がしまして。