> I do not think that the time to compile the tests is not that large

neither do I.

> should be named OGDF_WITH_TEST (or OGDF_WITH_TESTS)

I don't care as long as it is prefixed with `OGDF`.
`OGDF_ENABLE_TESTS` sounds good to me.
Should we hide the option `OGDF_SEPARATE_TESTS` if tests are disabled?


this is a good clean-up, ty


Thanks for the tip Bromix!


109649198_EvapCoolers (Nigusse) - i386-Windows-7-VisualStudio-12: OK (1974 of 1980 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.7%25-yellow.svg)


complete


Yeah, I was thinking the same thing, actually. I almost had a case statement of sorts for operator searching :)


I can confirm `Kontakt.io` is working w/o issues.


If you have one, add a link here to the list or description of atomic operations.  If there isn't one, I think we need it because then this sentence isn't well-defined without such a description.


Should this one be fixed too?


What do you think of addinga  top-level data/ directory, containing HHVM/Hack-specific config, like the redirects and search boosting? (as PHP arrays)


this doesn't need to be changed, but you can use ``{ $maybe string }`` and it will print the same text but link ``string``.


we're no longer using a concurrent data structure here, which I think I  understand since you are managing the locking at a much lower level now, but we are still using a concurrent set for the registered instances.  seems inconsistent, seems like either both or neither of the data structures should be / need to be concurrent?  Or is it because we're exposing the set directly via an accessor?


"an" -> "a".

Again, make it clear this is non-normative!


``{ $maybe string } print-element``


Seeing what a comment on a middle line looks like


Use the plugin `application` in this Gradle file


I think what I did should work. Seems to work when running locally (need each thread to flush its own thing).


Where's typo?


Should we name this for each of the separate modifiers?


When running this application, run the `static void main(String[])` method in `io.github.ztaylor54.CTF_Toolkit.App`


Why no `mv-g--c`? (Same for other unprefixed classes)


dddddddd


complete


im process-diagramm fählt nu e verbindig vum message throw event "forward expense to manager" zum catch event i dä lane vum employee, de prozess vum employee isch durchgängig.
i han dverbindig ez hinzuegfüegt, muesch eifach uf github nu dsneuä diagramm ufelade


"of" -> "in" seems better.


nitpick and not something you introduced, but I'd like to consider tweaking the API docs (javadocs) to not include some of the information about the implementation details.  This gets back to the question that we had a week or so ago about whether it was OK to introduce a new public method that interacted with the lock directly.  I felt pretty strongly that a user shouldn't have to / want to / need to know that the lock existed, and thus, that introducing that method would be a really weird change of direction for the API.  In retrospect it seems like leaking some of these implementation details in the javadocs kind of also reveals more info than an API consumer should need to know?

This is not a big issue, just food for thought.


looks like "other" is not showing up on the cards anymore?


Doh, I knew I forgot to do something when I got home.

I can't accept this pull request unfortunately as it includes many generated and intermediate files. The changes to make this 4.10 compatible are within files Source/ProductivityPlugin/Private/ProductivityPluginCommands.cpp and Source/ProductivityPlugin/Private/ProductivityPluginModule.cpp only. If you can limit the pull request to that I'd love to pull it in. Otherwise I'll just commit them separately.


comment


"node is" -> "If node is"
"DelayNode part" -> "DelayNode that is part"


This should work for now. It might still be nice to output the command line so you can watch a buildbot build and ask "has my particular new test run yet?" but we can always change it later.


LGTM


Hàm chuyển một số nguyên thành một thừa số nguyên tố, trả về kiểu String.


How is muting done here?  I think this needs to be described.


not the greatest check, but better than nothing


Which microbrewery should I check out when I go to Denver?


Hello


Choose how?  Randomly? Some other order?


Class Matrix dựa trên bài tập số 9.


Marked how?  I think it's marking needs to be described before checking if a node is marked.


psst it should be `<img src="">` not `href`


Why did we remove these args?


That way the controllers stay a bit more generic too, maybe?


"connect to node" -> "connected to the node" ?


When you specify a plugin eg:` ['extra-rules']` eslint prepends `'eslint-plugin-'` to the plugin name and tries to load that node module. so the the plugin name needs to be eslint-plugin-*. I changed it to extra rules becuase eslint-plugin-rules seems confusing to me, extra rules seems more descriptive but it could be switched back if you prefer.


That still displays the nametag. If you want to completely hide it, set that :

```Lua
color = { a = 0 }
```


whoops, just fixed in 4fe4055150f5ca2adaa06736766c4481c9346b4f - good catch!


What does visiting the input mean?


`ReferenceError: Can't find variable: Handlebars` - Error when running


Is it alright to leave the secret codes here?


"availabel"?  Is this a typo?


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 67](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=569&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


Make this ordering more explicit by saying we process each AudioNode in the order given by the ordered list?


thank u for everything. if u r who i thinku R i am so sorry fpr being such a week selfish stupid bitch. Everyday witjout u is like a punchbin the face with fresh regrets :(


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 67](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=569&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:40


You mean connected to it inputs, right?


So If I do this in copter 3.3 ... [Note #3: set SERIAL2_PROTOCOL to "3" and reboot the board to enable FrSky telemetry like in previous versions.]  Then I can wire directly from the telem port to a smart port on the Xr8 receiver and not need the teesny board?


Also fixes text domain issues once and for all - one text-domain which matches the theme's slug correctly so that the theme will be compatible with WordPress.org language packs - cute!


JNI code was originally done because, Eugene being my first Android application and my first Java project, I felt more comfortable with C than with Java. While this is still the case, Eugene has long since been running on pure Java, as evidenced by the much longer conversation supported in Java compared to in C. This commit removes the old relics of the use of JNI, which has been with Eugene for far too long.

Goodbye, and good riddance.


PP Kolbrún og Tinna


Some nodes have more than one input.  Is there an implied order for processing these inputs?

When are AudioParams processed?  Is there an order for these too?


shouldn't this be empty ?


That should say "did not have `jekyll-assets` installed"


Since this is a test it's probably fine. Otherwise I prefer getCanonicalPath so that paths can be safely compared. It's especially a problem on Windows where you can get stuff like `C:\PROGRA~1\` instead of `C:\Program Files\` etc.

I can't test this PR until I get daisy/pipeline-build-utils#24 to build, but I don't expect any problems.


Copying the input data to where? Internally? Some where else?


@drewbarontini that was a mistake; I made a commit right afterwards adding it


Necessary because I forgot to pull a367f294357a3ceeba5e2a893e3940146555e667 to my phone (testing system) before 2f5596eac1fcbfd8f7cb47fcf0572ed16ca35889.


It allows the MapFunctions not to be bound to a specific JsonProvider. Problems?


Testar


I always forget this:
https://github.com/mlr-org/mlr-tutorial/issues/30


AudioParams must come in to play at this time too.


+100 for use of strerror(errno)


> Anpassung FHEM/00_SIGNALduino.pm --> ."SD_WS09:"
> 2,212 additions and 2,210 deletions.

Dieser commit dürfte die Ursache für die Probleme beim merge von dev-proto9 nach dev-r32 sein.
Wäre es nicht einfacher diesen commit zu löschen und ihn dann manuell ins dev-r32 zu commiten?


gets my list of words and makes sure that they work in a manner that i need them to


Having the metadata reader here is odd.


@drewbarontini probably should have spelled it out better; I was going to have a `// ----- Grid Box ----- //` section below it with `.mv-g-b--r` and other things like that. But I’m neutral as to the base modifiers.

Fun fact: you can push right in flexbox with `margin-left: auto` (https://medium.com/@samserif/flexbox-s-best-kept-secret-bd3d892826b6#.b1msaoni1) if you wanted to use that for `.mv-g-b--r`


This particular line seems covered by the previous one


So, we're signaling here because... it's possible that the size of the queue is now less than the max size, and thus it's possible that all of the remaining registered elements are available in the queue.  This seems, technically/logically correct, but I'm trying to think if there is an actual use case where something would be waiting on this condition and we would want/need to trigger it as the result of an 'unregister'.  It seems like something that shouldn't happen during the normal use of this data structure given our current use cases, though, again, technically correct for the data structure itself.

Not suggesting a change, just trying to understand.


Should i change it to a array of one empty string?


In my opinion yes


I also use things like `.mv-g--vam { align-items: center }` (vertical align middle), and lots of other alignment modifiers, but I didn’t want to blow out this section with unused styles. I probably tend to use more grid modifiers than normal, so I’m fine with whatever gets shipped by default, really.

Feel free to just do what you feel is appropriate for the whole modifier section.


If `semver` isn't installed, this will fail, even if it's in the `package.json`. Bit of a chicken and egg situation :)


Does matching against both the completion text and list item text provide any benefit?  The list item text is typically a substring of the completion text.


Why do we need a separate interface for this one?


I'm looking through atmos issues on tgstation upstream and I saw this commit
this is a horrible, horrible "fix" that makes things fail silently without actually fixing anything. nice work!


Yeah, I just left the `CopyOnWriteArraySet` alone since it allows for a copy of the set to be made atomically for clients via the accessor.  I'd be good with moving to another data type and make the private copy inside of the `ReentrantLock` from the set accessor instead if you think that would be better.


And to answer my own question, it looks like they have identical values in this case, so it provides no benefit.  If I'm correct, remove the comparison with ListItemText and I'll accept the PR.


Just ITypeProvider?


I am unhappy with that! Can we somehow reduce the TestEventListener output level without loosing the ability to filter for debug events?


problem here... should be !=

most sgminer.c changes seems incorrect, to double check...


glad to see someone backporting that extra stuff to GageHud. thumbs up.


Сложно разобраться в правилах именования переменных. Почему не `m_executor`?


extra "!"


Hi, was für ein Problem haben wir beim merge?


@JMSerruya seems like a pretty bad bug, any idea about this one: https://github.com/spotify/ios-sdk/issues/505


looks good


Is this specific to Decoding or could it be in System.Reflection(.Metadata) namespace?


https://launchpadlibrarian.net/229076080/buildlog_ubuntu-vivid-i386.kodi_2%3A17.0~git20151208.0200-2b9689a-0vivid_BUILDING.txt.gz <- this is needed upstream or official ppa won't build


Actually, new_tab and force_reload are positional Boolean params, not named params


Why `lockInterruptibly` here?  Did you see this pattern in the source of one of the other data structures?


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 92](https://teamcity.labkey.org/viewLog.html?buildId=290295&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:24


Might make the code clearer if we call this `writeLockThreadId`.


Maybe just put a prominent link right under RackHD (TM) and before the first paragraph?

![videolink](https://cloud.githubusercontent.com/assets/15105919/11664128/f0d6c630-9dad-11e5-8800-b0d0b0e25165.png)


Note: there's still shadowing here for 'channel'


... oops, not here :D


Looks good, though I think the 2nd argument in `SetWeaponArmourRule` would be better of being something like `bool:affects_armour`, and `torso_only` should default to `false`.
The default settings should also not have the torso logic enabled - updating to a newer version of this include should not change default behavior.


:+1: Make sense.


it would probably be worth extracting a method called something like `isWriteLockHeldByCurrentThread` to make this easier to read.


Remeber to also fix this name on server


I think this could come up today.  Like if you had a write lock requested while we have just one instance out of the pool which is in the process of being flushed.  In the flush case, I think we just do an `unregister` to get rid of the old instance and so this code would signal the write locker to wake back up.


not sure about this. this follows an example give by vdr. the constructor has to be called at a defined time when loading. you can't control this with static members.


"A an"


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8565](https://teamcity.mesosphere.io/viewLog.html?buildId=88269&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:08


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8567](https://teamcity.mesosphere.io/viewLog.html?buildId=88271&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:09


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8568](https://teamcity.mesosphere.io/viewLog.html?buildId=88272&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:09


The Tree part was tricky. Is it fine to initialize mods to false? I suppose they are irrelevant when mouse is held.


109649198_EvapCoolers (Nigusse) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1444 of 1444 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.52%25-green.svg)


@mikesherov I was hoping the PEAR site would be back by now so I could do a proper release (it will be 2.5.0 as I've got some new features in there as well) but it isn't ready yet.

If it isn't back up by Friday, I'll be releasing regardless.


That's a nitpick, but that integer just kind of bugs me as an implementation detail, so abstracting it further seems like it'd be nice.


isn't this checked above?


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 93](https://teamcity.labkey.org/viewLog.html?buildId=290303&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:06:38


@knowtheory How did I not know about this task?? Gonna be happy.


I guess nothing! We can cut it.


I would put it in the plant section, myself.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.612.4a5592da664822293f997188b91198d3b9309887](http://build.palaso.org/viewLog.html?buildId=67009&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3324, ignored: 125 Build time: 00:10:12


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.620.4a5592da664822293f997188b91198d3b9309887](http://build.palaso.org/viewLog.html?buildId=67010&buildTypeId=bt322) outcome was **SUCCESS**
Summary: Tests passed: 3303, ignored: 106 Build time: 00:10:12


For my own edification, what prevents an array member from being added or removed? What needs to be implemented to make either action possible? For example, here, or in Skyrim's VMAD.


Did you copy/paste some of this out of the source for the concurrent queue?  If so, a link to the source might be useful.


Yeah, that's what `LinkedBlockingDeque` does for its own `ReentrantLock`, only in the cases where `pollFirst` / `pollLast` is called with a timeout.  It just does `lock.lock()` for the blocking `takeFirst` and `takeLast` methods.  Seemed like it would be good to follow that pattern.


@vkotovv thank you for your contribution!


as a comment, i mean.  that way it's obvious to reviewers that we didn't make this up ourselves, and serves as a warning to be super careful about any future modifications.


I've never tried it but I believe that's right. http://copter.ardupilot.com/wiki/arducopter-parameters/#telemetry_2_protocol_selection_serial2_protocol Would be great for someone else to confirm


Should we not bump it to 3.1 then?


EditorConfig page recommend not set `indent_size` for `indent_style = tab`

> For example, tab_width need not be specified unless it differs from the value of indent_size. Also, when indent_style is set to "tab", it may be desirable to leave indent_size unspecified so readers may view the file using their preferred indentation format. Additionally, if a property is not standardized in your project (end_of_line for example), it may be best to leave it blank. http://editorconfig.org/


Thanks for the offer to help testing the Debian packages, but for the moment this is not necessary.

About adding this package to the VTK build, well, personally I prefer small packages, but since VTK upstream changes the ABI all the time it might actually be a good idea. I'll talk to the Debian science team about this, but I seem to remember that the  guy maintaining VTK was already a bit overwhelmed.


I didn't "copy" it but the approach it uses for a single `ReentrantLock` with condition variables to signal waiters was definitely inspired by it.  I could make mention of that in the class somewhere - maybe comments up top?


looks like a TODO item?


also if any of the above is true, and if the concurrent data structures in the JDK use this pattern with the lock thread id, then, disregard my previous comment about extracting a method for the test to see if the lock is held.  i'd vote for making the code look similar to some linked source code from the JDK over my own personal opinions about readability.


Just a little thing: you should add a newline at the end of line 42, then that error will go away.


Do you mean that delete() now checks for NULLs?


I'm adding a few comments about things I notice. I know this isn't ready for review yet, so feel free to ignore known issues.


ty for removing that exception, I realized as we were testing that patch that it was probably unnecessary, but didn't want to risk changing it then.


Looking good ;)


boom


please don't check in .env


This is done on purpose. We could not safely modify those part of the VMAD for Skyrim.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8570](https://teamcity.mesosphere.io/viewLog.html?buildId=88275&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:25


xyzzy


Is this iteration necessary?  As opposed to just calling something equivalent to `clear` / `removeAll` on both structures sequentially?  (since we are already holding a lock anyway)


Thought the plan was to return nil if this is unsupported?


This still refers to the old interrupt group names (INT_TYPE_GXX), not the new ones. The next patch corrects this but that should be applied in this commit instead.


where can I get svi package used here?


@kostis, you may want to take a look at this hack.


me sale este error

[13:25:09] Using gulpfile ~\Documents\Desarrollo\ED-GRID-master\gulpfile.js
[13:25:09] Task 'watch' is not in your gulpfile
[13:25:09] Please check the documentation for proper gulpfile formatting


@ligadata-yasser

Should this be in the FileDataConsumer Project?  The way I understand it, HDFS code is also a standalone utility, so if we put this code in the FileDataConsumer we would have to provide 2 jar files to run HDFS code...  I may be wrong.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24104/testReport/) for this commit**


Die können nicht die einzige Fehler sein. Ich glaube dir nicht!  :smile:


alpha = 0.85 #damping factor

def maxnorm(x1, x2):
    norm = 0
    for i in range(len(x1)):
        if (abs(x1[i]-x2[i]) > norm):
            norm = abs(x1[i]-x2[i])
    return norm

accuracy = 10**(-6)


s/passive-only/passive_only/ right?

Also is there a relationship between this and the transport_passive_only property below that should be documented?


This function looks incomplete.


can be val, right?


All this for only the et8k5 display???


I'll try to solder up the wire needed and give it a try. I can't believe I didn't read more on this in the 3.3 thread as the Taranis is popular.


The way the thread id comparisons are done here does look more similar to what the implementation of the `ReentrantReadWriteLock` class does.  Assuming we might want to have the stubbed private `getThreadId` call through to the corresponding one in `ReentrantReadWriteLock` - via some nasty reflection, I assume - I thought it would be easier to follow that code's pattern.  Presuming there isn't any noticeable performance overhead around factoring this inline code out into a helper method, though - which may be why the JDK does it the way it does, dunno for sure - I'd be good with factoring this out for better readability / less repetition.


comment seems out of date


In the queue data structure, does `size` return the number of items currently in the queue?  Or does it return the capacity?


@jdurgin I'm slightly confused if you are saying this includes is incorrect. were you addressing @stiopaa1?


myeah, just non-greedy, but in this case it's the same as greedy because next character that should not be matched is `!` or `:` anyway, which is not in `\w`. For the second one it's necessary though, to not match the end curly bracket.


Is it worth mentioning optional end-of-line padding for alignment purposes, or would that just confuse the tutorial?


I think `sealed abstract class` can be better from a code size standpoint if the subclasses don't extend any other classes (sucks to have to think about this and the compiler not notice, but since this is about perf geekout).


above you say you thnow `NoSuchElementException`. Either `throw new ...` here or change the comment?


This change should be applied in the previous patch


This variable also really only applies to the (conceptual) write lock, correct?  If so maybe we should also change its name to `notWriteLocked`.  I keep getting confused between these operations and their relationship with the main/global `lock` object.


>  but the fact is 2x 32 byte = 64 bytes...

Isn't L1_CACHE_SHIFT=5 somewhat that specifies 32 byte cache line size for each core?


why InlineArraySpecializedOption? Why not just `SpecializedOption`?


also if we return this value anywhere, we create a runtime dependency on this project, which could be okay, but it was nice not to do that.


El archivo gulpfile.js se optimizó, se crearon varias tareas watch adicionales, la tarea que sustituye al `watch` de este commit es `watch:all`, puedes ver los detalles del cambio en https://github.com/escueladigital/ED-GRID/commit/95dac7e2eb6cb028f52bf4096593562bd6283881 adicionalmente puedes ver el video en youtube en el que se explica como usar las nuevas tareas https://youtu.be/mZyPR4GqTG0


please fix group spelling


$("#clean_search_field").click -> doesn't work
if move it above $('.sort_paginate_ajax  a') it works but $('.sort_paginate_ajax  a') doesn't works
so works only first function.
I read that installing turbolinks gem could help but you said remove it


Minor modification. Changed the name of the vulnerability in the README file.


I do not have other receivers for verification.
It is better to make the owners of receivers.


@jelder unfortunately not. ActiveJob doesn't have any *options* that can be set.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8572](https://teamcity.mesosphere.io/viewLog.html?buildId=88278&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:10


@KevinH-MS You were the original author of these lines of code, with the check-in comment in TFS

```none
Test for 11542 (TFS Integration from 'DDP' Id: 21226;CreationDate: 2012-03-16 05:22:45 UTC;)
```

Also the bug is marked with IDs 538246 and 543655.

Do you have any idea what any of these issues were or how I can see them?


@davelab6  I guess this backslash is a typo? Shall I remove it?


reject changes to master


"Ultrascale Visualization Climate Data Analysis Tools", per http://uvcdat.llnl.gov


Сразу видно phpшника ))


No, not at all I was just wondering:) Thanks for the update! It was pretty easy to move over from my branch to the official, great work!


Don't you mean `directoryFilenames()` here?


+1 The changes look good to me.


oh I see this just matches all the other ones that add on depending on how many more bytes there are in the sequence


Why remove extends line? Autoloads are supposed to extend Node, AFAIK.


Consider `std::os::num_cpus` to pick up the number of available hyperthreads (original hard-coding was a hack).


I think this needs to inherit from BaseUserManager. https://github.com/django/django/blob/master/django/contrib/auth/base_user.py#L17

It implements normalize_email, make_random_password, and get_by_natural_key. Get by natural key is used internally for fixtures so it's required. We were using normalize_email earlier, not sure if we still are.


I guess it was to avoid triggering markdown emphasis markup, before it was in a \`\`\` section. It is a bug and should be removed.


Two unitest are failing:
- *NDbfReader.Tests.ReaderTests.Read_TableBasedOnNonSeekableStream_ReadsAllRowsAsUsual*
- *NDbfReader.Tests.ReaderTests.Read_TableOnNonSeekableStreamWithDeletedRows_SkipsDeletedRows*

The problem is that we have to support non-seekable streams (like [NetworkStream](https://msdn.microsoft.com/en-us/library/system.net.sockets.networkstream%28v=vs.110%29.aspx?f=255&MSPPError=-2147217396)), so we can't rely on *Seek* method.

Moreover, we need a unit test that checks reading of dBase7 file.


The folder `contribs/gmf/src/directives/partials` does not exist within this PR.
I don't know why it passes Travis.


You should probably remove this line.  There's some specific configuration needed on br-int.  ovn-controller will create br-int at startup if it's not already created for you.


done, thanks.


Yes, sorry for the vagueness. I think your comment about headers is correct.

I meant this commit in general breaks the librados ABI by changing buffer from a class to a namespace (@stiopaa1)


Nice addition!  Any plans to upstream this?


sure, I understand now, ok, will merge and publish new version!


Not used elsewhere, but certainly could go one level up. Would be consistent with other existing enums like CustomAtributeNamedArgumentKind. We should probably move SignatureTypeHandleCode up one too if we go that way. Thoughts?


Hey @danfowler

There's an app for that :).

https://github.com/okfn/datapackage-validate-py#usage


Yes, should be 'passive_only'.  I also added some text about mutual exclusivity.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1978 of 1981 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.85%25-yellow.svg)


Good point. The way this one is handled still doesn't make sense. i'll fix it.


Just curious... Why did  you revert this?


Thanks


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.910](http://teamcity.monogame.net/viewLog.html?buildId=12025&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


When you add ports to br-int, ovn-controller looks at the iface-id to match up the port to the OVN logical port.  This line should probably be:

    $ sudo /usr/local/bin/ovs-vsctl add-port br-int vethe1 -- set Interface vethe1 external_ids:iface-id=$CONTAINER1_NAME

The same applies for the 2nd container later.


Rename to HasDuplicateRegistryKeyPaths so it's obvious what the return value should be. Flip the logic.


alpha.13 is out. Should solve your problem. I think you already know this via @jeffbcross though.


It's the size in the queue.  There is no "capacity" in the `LinkedList` class.  It grows as you add elements to it.  I think size currently in the queue is what we want here, though, right?


I'm trying to understand how this implementation gives precedence to the writer thread.  If there were 100 requests queued up before this method was called, then all of those threads would be blocking attempting to acquire this lock via the `borrow` methods, right?  And the thread that was calling this `lock` method wouldn't have any precedence?  Or am I missing something?


We had tests that decode blobs that they just invent out of nothing (no corresponding reader). Previously, we used to ask the provider for a reader when we needed it and test provider would return null. Then we talked about having a MetadataReader getter on the provider was odd and I broke the tests when I threw on non-null. The scenario (outside of testing) is limited, but there's no reason to block it.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


You can use the Lock API to add a lock to the array making it impossible to `erase` / `ReDim` the array outside of your method here (VB will throw a safe error of its own). The `Alias1DArray` method may also be able to set the lock count manually on the array structure. An example from blu: https://github.com/Kroc/blu/blob/master/CORE/bluString.cls#L429


Yeah that makes sense, I'll change it up real quick.


@ligadata-william

Hi will, can we crate Exception with the original e as a cause... For example  throw new CleanUtilException("xxxx", e)


It's for the custom attribute decoder (not seen in this PR), which only requires primitives, sz-arrays, and def-or-ref.


It looks like I may be wrong, take a look at the wiki here
http://copter.ardupilot.com/wiki/common-frsky-telemetry/
I'd say hold off until someone who uses this can comment on it


Agreed. The rules for punctuation for quotes in English don't apply in this context.


How would you disambiguate?


Its ok, but exists to observations that have to improve on the next pull request


:+1: Perfect :)


Thanks for the tips :)!


The location successfully added needs to be get it from a CONSTANT


OK.


Fixed errors


This is a great change, but it may be breaking for some applications doing i18n. It's not a big issue, so I don't think this is a stopper, but we should make it clear in the changelog.


Could you elaborate more on the complain from FuseStubFS constructor?


More pep8 nitpicking


TeamCity LabKey :: Sprint :: Premium :: Git postgres 9.4 [Build 5](https://teamcity.labkey.org/viewLog.html?buildId=290299&buildTypeId=LabKey_Sprint_2_LabkeyPremiumTrunk_GitPostgres94) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:04:40


Ah.  The Day Is Complete, as I learned something new:  It is now safe to pass NULL to delete().  It wasn't always the case, hence my habitual verbosity.


Sorry, my comment was perhaps too terse ;) I agree not having a reader is certainly a valid scenario. I was wondering about the use of Spec# comment for nullable reference type... I'd rather avoid it. Internally we could use -Opt suffix. For public facing arguments we should just add a doc comment saying it might be null.


Commit message should have been "Fix incorrect Debug handle".


I took a first pass over all of the production code, haven't really reviewed the tests much yet.

Mostly looks good, I'm on board with the approach of using conditions like this.  Last time I was messing with this stuff and digging through the JDK source, I kept thinking we might need to but I never quite got to the point where I'd figured out a reasonable path forward; this seems like a reasonable start.

Overall I only have two main areas of concern / question:

1. Performance.  Since we're now blocking basically every interaction with the data structure on a single lock object, have we made anything worse in terms of perf bottlenecks than how it was before?  If the way we're using the lock here, though, is similar enough to the implementation of the concurrent queue object that we were using before, then the answer is "no, it's not any worse".
2. The question that I raised above about whether we are actually giving precedence to the write requests with this implementation.  If we are, and I'm just missing / not understanding something about the implementation, great.


:boom:


I see. OK.


@camlow325 done reviewing for now.  Would be interested in sitting down w/you and hashing out some of the questions in meatspace, but not sure I'll have time for that until these releases are out the door.


Done from GH interface, but it might have been an overzealous change. Depends on whether References have _ready callback or not.


Is correct `select('[[user_id]]')` ?


java.lang.String on steroids - cильно, поржал )))
но:
Double quotation marks, no template -> no GString


TeamCity LabKey :: Sprint :: Premium :: Git sqlserver 2014 [Build 5](https://teamcity.labkey.org/viewLog.html?buildId=290301&buildTypeId=LabKey_Sprint_2_LabkeyPremiumTrunk_GitSqlserver2014) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:04:45


Отправил вроде бы


Remove readonly. `readOnly: true` will prevent the attribute from updating it: `<google-codelab last-updated="...">


@ligadata-dan
actually, i understand from krishna that it will be one tool that reads files from OS / HDFS / SFTP based on configuration. i agree regarding the extra jars that might not be needed by some installations. not sure if sbt supports conditional/configured dependencies, but i can check that.
anyway this check in is still initial, i am expecting notes from Krishna

@ligadata-krishna
what do you think ?


@studansp what are the workspace.xml files... Can i add them to gitignore? There is no reason to have them committed is there?


ok so basically if you look at the hex there are "." after the list of needed libs. you need to use those when editing. Basically when you change a lib name that is smaller than the current you add "00" aka "." to the hex code to add more characters so the table size remains the same. Now if you change a longer small name to be bigger you need to remove 00 aka "." from the end so again the table size remains the same.


	The default settings should also not have the torso logic enabled - updating to a newer version of this include should not change default behavior.

So basically, the entire thing should be disabled by default. Instead of changing all of the defaults to 0 would it be better to just add a single boolean (and a function to set it) that would enable/disable the whole thing?


Well at least I'll have the wire ready :]


Yes, I've heard that before. I disagree and would like to explore it on my own; however, being not as familiar with the source, it's not clear to me how you are preventing array members from being added or removed, or whether they cannot be added or removed due to the omission of specific code.


Sorry for the delay, code tested and accepted.


Final Version of the program


PrimitiveTypeCode seems like just a subset of SignatureTypeCode, so it feels like it should be next to it. SignatureTypeHandleCode is kind of like that too, but it has very narrow use case that seems to only matter for Decoding.

I'll have a couple more enums coming in for the writer. We can revisit when we have all together at the end :)


Ah. Will fix.


I'm climbing into my time machine now...set the date for 1985!

:smile:


typo in commit message.  s/Matchine/matching/


@ligadata-yasser
I see, we should move the HDFS code into this project.  As I understand its in a separate repository.


You are correct that the field is not used in the code. I have no idea
why my Eclipse does not think the annotation is necessary.

On 12/08/2015 08:54 AM, Erik Kemperman wrote:
>
> Hm, for me Eclipse complains that this field is not used, so it wants
> to add the |@SuppressWarnings| you removed. I guess that means your
> local copy is different from mine in that this |context| member is
> used whereas in mine it's not?
>
> That's odd, I haven't touched this class, it should not differ in any
> interesting way from spring-upgrade.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/erikkemperman/common/commit/86eca4966f89e8faa5cd29b18bb9a7536d55274a#commitcomment-14848992>.
>


Thanks for this - I was scratching my head wondering why it wasn't working!


Why does it still step by rune and not by byte?


такой `id` уже есть выше


Wooo!! Thanks :heart:


Yes, that's the reason why we need `setUp` instead of `setUpBeforeClass` here. It will run before each test case and preserve the original global in the property. So that we can safely modify it in the tests knowing that it will be restored before the next test runs.


Hi Dan & William,

In next release we will change all exceptions are derived from KamanjaException. Where KamanjaException is like below

class KamanjaException(e: String, inner: Throwable) extends Exception(e)

The changes should be like this

case class UnsupportedObjectException(e: String, inner: Throwable) extends KamanjaException(e, inner)

case class Json4sParsingException(e: String, inner: Throwable) extends KamanjaException(e, inner)

So, that way we can simply check for KamanjaException if we don’t want to handle all explicit in some places.

Thanks

Pokuri

From: Dank [mailto:notifications@github.com]
Sent: Tuesday, December 08, 2015 10:47 AM
To: ligaDATA/Kamanja
Subject: Re: [Kamanja] Checking the heartbeat in zookeeper to determine if any metadata or kamanja nodes are currently running. If they are, throw an exception. (5d86df0)

@ligadata-william <https://github.com/ligadata-william>

Hi will, can we crate Exception with the original e as a cause... For example throw new CleanUtilException("xxxx", e)

—
Reply to this email directly or view it on GitHub <https://github.com/ligaDATA/Kamanja/commit/5d86df057d70deb8b6fcb45d92c6b8979cf872fd#commitcomment-14855217> .  <https://github.com/notifications/beacon/AITH1KM2wx43-leQSvUWQIw-pfEwRx5Eks5pNx0QgaJpZM4GjZuk.gif>


> If there were 100 requests queued up before this method was called, then all of those threads would be blocking attempting to acquire this lock via the borrow methods, right

Those 100 requests would presumably be blocked on a `notEmpty.await()` initially - but would relinquish their hold on the `ReentrantLock` while waiting for that condition to be signaled.  In the meantime, the writer thread's call to `lock()` should get the `ReentrantLock` - while those other 100 requests are still waiting - and set the `lockThreadId` to the `currentThreadId`.  When an item is added back into the queue while `lockThreadId` is set, a reader may be woken up but will see that the `lockThreadId` is set and go into a `notLocked.await()`.

So, effectively, the writer and reader threads compete on an equal footing for the `ReentrantLock` but readers are held off from borrowing between the time the write lock is taken and items become available in the queue for borrowing.


Nice! /me needs to read up more on PHPUnit's built-in joy.


@bajtos: Probbaly it makes more sense to have an argument in MySQL.prototype.updateOrCreate for `replace` and if it is true we get the fields by calling `this.buildReplaceFields(model, data);` as opposed to `var fields = this.buildFields(model, data);` thoughts?

Aslo please note this is a very initial implementation


There's certainly a better way to create strings/URLs. Find it.


Imho this whole define can go or be set for all platforms.


complete


@bajtos: Probably it makes more sense to have an argument in MySQL.prototype.updateOrCreate for `replace` and if it is true we get the fields by calling `this.buildReplaceFields(model, data);` as opposed to `var fields = this.buildFields(model, data);` thoughts?

Aslo please note this is a very initial implementation


I wonder whether it could be more efficient to look up the presence of one record only instead of counting them. (some people use large lists). We could use something like:

``` sql
select 1 from cg_caches where reason=[LISTID] limit 1;
```

and check whether the result is empty or not.

However, it may not be worth the additional complexity in code, but I'd keep the `isEmpty()` check anyway in front of the database check to avoid hitting the database when it won't be needed most of the time (with a comment explaining that we do this for performance reason).


Most of this object reads like an OpenStruct waiting to be born


Why are all these constants saved as URL encoded strings rather than hash params?


I notice this commit is very similar to the commit in https://github.com/ARM-software/arm-trusted-firmware/pull/392. Andrew made some detailed comments on why tracking of the on_pending state is probably unnecessary. Could you either:
a) Addresss this by following a similar pattern to the ARM platform ports, or
b) Confirm that you want to retain this functionality. In this case, it would be helpful to explain why you still think it is needed.


Same question as above — why strings instead of hashes you can munge/turn into URLs?


added


That should be fine.
On Dec 8, 2015 1:56 PM, "sstangle73" <notifications@github.com> wrote:

> @studansp <https://github.com/studansp> what are the workspace.xml
> files... Can i add them to gitignore? There is no reason to have them
> committed is there?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/opticaliqlusion/clueless/commit/b68cdda0dd6aa88c1c44d4e07dbfeb64c6accb08#commitcomment-14855436>
> .
>


Hi Pokuri,

Sounds good.

 should we also have a KamanjaException(e: String) only…

Say.  KamanjaExcetion(e: String = null, inner: Throwable = null) ????

That way if we want to throw an original exception we can just do throw new KamanjaException(“xxxx”
)

> On Dec 8, 2015, at 11:01 AM, ligadata-pokuri <notifications@github.com> wrote:
>
> Hi Dan & William,
>
>
>
> In next release we will change all exceptions are derived from KamanjaException. Where KamanjaException is like below
>
>
>
> class KamanjaException(e: String, inner: Throwable) extends Exception(e)
>
>
>
> The changes should be like this
>
>
>
> case class UnsupportedObjectException(e: String, inner: Throwable) extends KamanjaException(e, inner)
>
> case class Json4sParsingException(e: String, inner: Throwable) extends KamanjaException(e, inner)
>
>
>
> So, that way we can simply check for KamanjaException if we don’t want to handle all explicit in some places.
>
>
>
> Thanks
>
> Pokuri
>
>
>
>
>
>
>
>
>
> From: Dank [mailto:notifications@github.com]
> Sent: Tuesday, December 08, 2015 10:47 AM
> To: ligaDATA/Kamanja
> Subject: Re: [Kamanja] Checking the heartbeat in zookeeper to determine if any metadata or kamanja nodes are currently running. If they are, throw an exception. (5d86df0)
>
>
>
> @ligadata-william <https://github.com/ligadata-william>
>
> Hi will, can we crate Exception with the original e as a cause... For example throw new CleanUtilException("xxxx", e)
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ligaDATA/Kamanja/commit/5d86df057d70deb8b6fcb45d92c6b8979cf872fd#commitcomment-14855217> . <https://github.com/notifications/beacon/AITH1KM2wx43-leQSvUWQIw-pfEwRx5Eks5pNx0QgaJpZM4GjZuk.gif>
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ligaDATA/Kamanja/commit/5d86df057d70deb8b6fcb45d92c6b8979cf872fd#commitcomment-14855551>.
>


Are you sure about this?  Using 3.5.1 I did my own async loader and I'm loading UIImages from thread pool threads without problems.  I do however need to set them to my UIImageView in the main thread, which I do using a callback like the in MvxImageViewLoader


Кажется, что этот try/catch должен быть только вокруг `get_cached_groups`, иначе любая ошибка после получения cached_groups будет логироваться как "cannot get cached groups", но `result` будет не пустой и будет использоваться.


@wsnipex whatever you like best.


We can see that when we implement it. But I prefer to have inner once always, whether caller care about it or not.

From: Dank [mailto:notifications@github.com]
Sent: Tuesday, December 08, 2015 11:06 AM
To: ligaDATA/Kamanja
Cc: ligadata-pokuri
Subject: Re: [Kamanja] Checking the heartbeat in zookeeper to determine if any metadata or kamanja nodes are currently running. If they are, throw an exception. (5d86df0)

Hi Pokuri,

Sounds good.

should we also have a KamanjaException(e: String) only…

Say. KamanjaExcetion(e: String = null, inner: Throwable = null) ????

That way if we want to throw an original exception we can just do throw new KamanjaException(“xxxx”
)

> On Dec 8, 2015, at 11:01 AM, ligadata-pokuri <notifications@github.com> wrote:
>
> Hi Dan & William,
>
>
>
> In next release we will change all exceptions are derived from KamanjaException. Where KamanjaException is like below
>
>
>
> class KamanjaException(e: String, inner: Throwable) extends Exception(e)
>
>
>
> The changes should be like this
>
>
>
> case class UnsupportedObjectException(e: String, inner: Throwable) extends KamanjaException(e, inner)
>
> case class Json4sParsingException(e: String, inner: Throwable) extends KamanjaException(e, inner)
>
>
>
> So, that way we can simply check for KamanjaException if we don’t want to handle all explicit in some places.
>
>
>
> Thanks
>
> Pokuri
>
>
>
>
>
>
>
>
>
> From: Dank [mailto:notifications@github.com]
> Sent: Tuesday, December 08, 2015 10:47 AM
> To: ligaDATA/Kamanja
> Subject: Re: [Kamanja] Checking the heartbeat in zookeeper to determine if any metadata or kamanja nodes are currently running. If they are, throw an exception. (5d86df0)
>
>
>
> @ligadata-william <https://github.com/ligadata-william>
>
> Hi will, can we crate Exception with the original e as a cause... For example throw new CleanUtilException("xxxx", e)
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ligaDATA/Kamanja/commit/5d86df057d70deb8b6fcb45d92c6b8979cf872fd#commitcomment-14855217> . <https://github.com/notifications/beacon/AITH1KM2wx43-leQSvUWQIw-pfEwRx5Eks5pNx0QgaJpZM4GjZuk.gif>
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/ligaDATA/Kamanja/commit/5d86df057d70deb8b6fcb45d92c6b8979cf872fd#commitcomment-14855551>.
>

—
Reply to this email directly or view it on GitHub <https://github.com/ligaDATA/Kamanja/commit/5d86df057d70deb8b6fcb45d92c6b8979cf872fd#commitcomment-14855653> .  <https://github.com/notifications/beacon/AITH1PHbG-wS-yiPJrYe6z7OeVuEQoLlks5pNyGigaJpZM4GjZuk.gif>


using System;
using System.Threading;
using System.Threading.Tasks;
using Cirrious.CrossCore;
using Cirrious.MvvmCross.Plugins.DownloadCache;
using Cirrious.MvvmCross.Plugins.File;
using Intervals.Core.Helpers.Converters;
using Intervals.Core.Model;
using Intervals.Core.Services;

namespace Intervals.Core.Helpers
{
    internal class MvxCloudImageAsyncLoader<T> : IMvxLocalFileImageLoader<T> where T : class
    {
        private object mLock = new object();

        public MvxImage<T> DefaultImage { get; set; }

        private Action<MvxImage<T>> SetImageAction { get; set; }
        private IMvxLocalFileImageLoader<T> LocalFileLoader { get; set; }

        private CancellationTokenSource mCancellationToken;
        private CancellationTokenSource CancellationToken
        {
            get
            {
                CancellationTokenSource result = null;

                lock (mLock)
                {
                    result = mCancellationToken;
                }

                return result;
            }
            set
            {
                if (CancellationToken != value)
                {
                    lock (mLock)
                    {
                        if (mCancellationToken != null)
                        {
                            mCancellationToken.Cancel();
                            mCancellationToken.Dispose();
                        }

                        mCancellationToken = value;
                    }
                }
            }
        }

        private MvxImage<T> mCurrentImage;
        public MvxImage<T> CurrentImage
        {
            get
            {
                MvxImage<T> result = null;

                lock (mLock)
                {
                    result = mCurrentImage;
                }

                return result;
            }
            set
            {
                if (CurrentImage != value)
                {
                    lock (mLock)
                    {
                        mCurrentImage = value;

                        if (SetImageAction != null)
                        {
                            MainThread.Context.Post((sender) => { SetImageAction(CurrentImage); }, this);
                        }
                    }
                }
            }
        }

        public MvxCloudImageAsyncLoader(Action<MvxImage<T>> setImageAction, MvxImage<T> defaultImage = null, IMvxLocalFileImageLoader<T> loader = null)
        {
            DefaultImage = defaultImage;
            CurrentImage = DefaultImage;

            SetImageAction = setImageAction;

            if (loader == null)
            {
                LocalFileLoader = Mvx.Resolve<IMvxLocalFileImageLoader<T>>();
            }
            else
            {
                LocalFileLoader = loader;
            }
        }

        public MvxImage<T> Load(string localPath, bool shouldCache)
        {
            Task asyncLoad = null;

            CancellationToken = new CancellationTokenSource();

            if (localPath.StartsWith(ImageFromResourceNameOrPath<object>.ResourcePrefix) || Mvx.Resolve<IMvxFileStore>().Exists(localPath))
            {
                asyncLoad = new Task((tokenObj) =>
                                     {
                                         CancellationToken token = (CancellationToken)tokenObj;

                                         if (!token.IsCancellationRequested)
                                         {
                                             MvxImage<T> loadedImage = LocalFileLoader.Load(localPath, true);

                                             if (!token.IsCancellationRequested)
                                             {
                                                 CurrentImage = loadedImage;
                                             }

                                             // Clear token on completion
                                             CancellationToken = null;
                                         }
                                     },
                                     CancellationToken.Token);
            }
            else
            {
                asyncLoad = new Task((tokenObj) =>
                                     {
                                         CancellationToken token = (CancellationToken)tokenObj;

                                         if (!token.IsCancellationRequested)
                                         {
                                             TaskCompletionSource<string> downloadTaskSource = new TaskCompletionSource<string>();
                                             Task<string> downloadTask = downloadTaskSource.Task;
                                             MvxImage<T> loadedImage;

                                             Mvx.Resolve<CloudWorkoutCache>()
                                                .DownloadBackgroundImage(localPath.Replace(CloudWorkoutCache.BackgroundPath, string.Empty),
                                                                         (string imagePath) =>
                                                                         {
                                                                             downloadTaskSource.SetResult(imagePath);
                                                                         });

                                             loadedImage = LocalFileLoader.Load(localPath, true);

                                             if (!token.IsCancellationRequested)
                                             {
                                                 CurrentImage = loadedImage;
                                             }

                                             // Clear token on completion
                                             CancellationToken = null;
                                         }
                                     },
                                     CancellationToken.Token);
            }

            CurrentImage = DefaultImage;

            asyncLoad.Start(TaskScheduler.Default);

            return CurrentImage;
        }
    }
}


Good start of refactoring, but why is there is a method with name `getLastComment` inside `SqlConnection`.
Does it mean that here should be only methods related to the connection only, not about particular model.


It should be, I'll test it tomorrow. The `any` should be faster than the for loop.


Awesome, thanks!  That's super helpful.


IIRC, this is not correct, it will cause some random conflicting change to be lost. Edits that are inside conflcits are not also kept in the main diff object's edit list.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.910](http://teamcity.monogame.net/viewLog.html?buildId=12025&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 557, ignored: 6 Build time: 00:25:10


We can take this. Can you split this into it's own PR?
    git checkout master
    git checkout -b jqueryify
    git cherry-pick 8c568dce5efd6f80a5eef32229d576f0226be431
    git push -u origin jqueryify


Yes.


Done.


complete


Please, respect united code formatting. Also write `Array` with small cap.


okay danke. d'neu version isch dobe.


Hi, @krnflake, I have been working to adapt what @Nikratio asks for the inclusion in s3ql, but I can't get your code working. I ended having an error "No S3QL file system found at given storage URL.". I have checked all the parameters. Do you know what can happen?


Can we add a new branch for Frameworks work and do all jobs there?


А вот это некрасивый хак! То есть ты кагбэ создаёшь (загружаешь из файла) низачем ещё одну копию данных, которые у тебя уже есть.

![Не надо так](http://images.vfl.ru/ii/1402882405/b473b96a/5438988_m.png)


Thanks, Dan


Во-первых, "Cannot determine groups" (без "to").

Во-вторых, тут сообщения об ошибках ("group must be greater than zero", "Cannot determine groups") теряют контекст. Не очень понятно, где они будут перехватываться и обрабатываться, но кажется, что в этих сообщениях не хватает информации для того, чтобы нормально понять что произошло не так.


You shouldn't stop crawling just because you get a HTTP Error. You should retry the request atleast once to be sure its not a temporary error.


Note that this modification will introduce a BC Break that should explained in the UPGRADE.md file.

Maybe we could start a good practice by filling the UPGRADE.md file for each pull request that introduce BC breaks in order to forget nothing. (we also should fill the UPGRADE.md file with the previous BC breaks that we have introduced)


@sindresorhus care to take a look?


@pb00068 ,

A related formula is to use columns of the hadamard matrix
http://mathworld.wolfram.com/HadamardMatrix.html
In particular, if you use the _complement_ of the hadamard matrix, then column 1 corresponds to the main thread (no skips), and the other columns follow roughly the scheme you gave.

Further properties are that it  approaches density 1/2 as size grows (meaning equal ratio zero and nonzero), and also is given by a simple recursive formula.


hello


зачем ты это удалила?


Если class между словами имеет нижнее подчеркивание, то это подразумевается как одно слово. Нужно  ставить тире.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1443 of 1443 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Я художник, я так вижу!


По коду не очень ясно, но ты уверен, что здесь хорошо обрабатываются случае с malformed url (когда `path.find` не найдет нужный символ)?


#### 538246 is in the DevDiv2 project collection in TFS (not VSO):

Incorrect Calculation of float constants - (1.0f + 1.0e-15f) = 1.0000000000000011 but Roslyn =1

**Eric Lippert:**
```
Associated with changeset 26139: In this checkin: a simple fix for bug 14064.
The native C# compiler does floating-point constant arithmetic in doubles, even
if the constants in question are singles. That is, we convert constant floats to
doubles, do the arithmetic in higher precision, and then convert back to floats if
necessary. (Implementing this was tracked by bug 3821.) However, what I did
not realize when doing that work is that *conversions* of constants to floats *do*
throw away extra precsion. In the particular example here, when converting
int32.MaxValue to float, we do not keep all 32 bits of integer precision around in
a double in the native compiler. Rather, we round the integer off to the nearest
float, and then convert *that* to double for subsequent calculations. A C#
compiler is *permitted* by the spec to make any optimization to floating point
arithmetic that meets a minimum level of precision, so the code we have is *legal*
according to the spec, but it is unfortunate that it does not match the native
compiler. I've changed Roslyn to match the native compiler behaviour; floats are
represented as doubles for the purpose of doing math, but conversions to float
are rounded to float precision before being stored internally as doubles. While
debugging this code I noticed there was an unused single-line method in the
binder; I've removed the dead code.
```

#### 543655 is also in DevDiv2 (it was ported from the DevDiv_Project project collection in TFS, bug id 11542):

Compiler should not drop explicit casts to double/float

**Neal Gafter:**
```
Resolved with changeset 21980.
```

Let me know if you need any other info.


Hellen, cuales eran las 3 cosas que te ibas encargar?


TeamCity LabKey :: Sprint :: Community :: CDS postgres 9.4 [Build 3](https://teamcity.labkey.org/viewLog.html?buildId=290325&buildTypeId=LabKey_Sprint_2_LabkeyTrunkCommunity_CdsPostgres94) outcome was **FAILURE**
Summary: Snapshot dependency failed: LabKey :: Sprint :: Community :: build Build time: 00:00:00


+1 for this! Was going to create a pull request, and this would've been exactly my changes.


I'm a little surprised you didn't call `beast::rand_int(10000000)` here instead of using a modulus.  I doubt it makes much difference in this case.


Just FYI it does not in fact work even after setting serial 2 to '3' and rebooting. I guess it's just not done yet. Until then = teesny.


Yes, this is an existing issue. Should not matter.

Perhaps we should support trims in the attitude controller rather than in input shapers? @R-Lefebvre?


Can you add the [radix parameter](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseInt)  here and on line 33?


You think that these data were used? It is not detailled in the documentation. I wonder what the user could do with it?

I concur with your second point. I will work on it ASAP.


Сообщение как-то не очень, давай попытаемся переформулировать.

Можешь описать как это сообщение будет участвовать в логе? Можно на примере какого-нибудь фиктивного лога.


The hash doesn't need to be removed - it should stay a part of the name IMO?


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - Win64-Windows-7-VisualStudio-12: OK (1979 of 1981 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.9%25-yellow.svg)


Желательно чтобы значение "alt" содержало соответствующее название картинки (или действия на картинке). Избегать сокращений.


commit made by kinpat7. Issue with cloud9


Это правило относится ко всем "alt"


ok


Cryptoki (including OpenSC) is thread-safe and OpenSSL is thread-safe.  Why exactly was libp11 (basically, an interface between OpenSC and OpenSSL) **designed** not to be thread-safe?  Who was the designer who designed libp11 not to be thread-safe?
Is it because the designer thinks that cryptographic applications never use multithreading?
Are there any fundamental technical reasons to prevent libp11 from being thread-safe?


why is this being renamed to stage1initcommon?


Do you manually change this for every druid node (Master, Data, Query)?


```room``` is a property of ```_``` on the DubAPI instance. So both replacements here fail.


It's your anus


whoops. nice catch


Может ли так получиться, что `make_read_controller` выкинет exception из-за внутренних (серверных) проблем, и по-хорошему тебе нужно будет сообщить о серверной ошибке (5xx), а не о клиентской?


Why .gedit-plugin extension ? Could you give me a reference about that fact ?


Тут нужно сделать `return`.


What happens if `!Objects.equals(...)` but `User.Attr.EMAIL` is not specified?


```roomPlaylistActiveDubs``` isn't used exclusively for updub/downdub.
Please add as a new endpoint, ```roomPlaylistVote``` or something to that effect should do.


I don't quite object to changing all of this, but it's worth noting that this stuff is basically initialization that ends up setting a property on the session too.


I think the `var self = this;` in the init function() is not useful anymore, no ?


I think you're suggesting something like this?

```
import setuptools_scm

setup(
    version=setuptools_scm.get_version(parse=my_parse_func),
    ...
)
```

The difficulty for me is the `import setuptools_scm` line. I'm currently bringing `setuptools_scm` in via `setup_requires`.  To avoid the need to have it pre-installed into the environment in order to run `python setup.py <command>`, I followed the advice [here](https://pypi.python.org/pypi/setuptools_scm/1.10.0#importing-in-setup-py). So... _I'm_ not calling `setuptools_scm.get_version()`, `setuptools` is—or so I assume. Not sure how/whether I can get it to inject the extra `parse` arg when it calls `get_version()` for me. If there _is_ a way to do it, I'll definitely use it! But the temp hack I posted above seems okay(-ish) for now. (Don't love the monkey patching, but it works.)

Incidentally, I found I had to add a 'dummy' `pop()` method to my `GetUseScmVersionArg` class to make it work with `tox`. I found that—when running `tox` (with no arguments)—there's a code path that expects my callable to be a dictionary, and it tries to call `pop()` on it. (Fix looks easy, I'll create a PR for it as soon as I can.)


``content/images/expense-process.jpg`` -> das file isch ja als svg im tool dinne. chasches ned i dem format la? bzw eifach s'svg bearbeite.. aber ja isch ned mega wichtig


shouldn't this be:
```java
if (outputDictionaries[projectionIndex] != null && inputDictionaries[projectionIndex] == dictionary) {
```


the gif of the moving prayer wheel http://www.dharma-haven.org/tibetan/prwhbl1.gif


There already is `a = 0`


https://github.com/uakfdotb/gedit-autotab/commit/c5609fa6d5bcb21397e161ccf2f4db8ca3507833

The current README says .gedit-plugin, but there is no file with .gedit-plugin extension in the repository.


#4702-AirloopHVACUnitarySystem-autosizing-incorrect-for-heating-only-systems-when-using-FlowPerHeatingCapacity (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (906 of 907 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.89%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.72%25-green.svg)


I think it is used, otherwise JSHint would report an error (and my IDE as well).
It is used a lot under (maybe you will see in later commits?)


the `ModifyDnOperation` won't execute, and the regular update will use the `originalDn` instead of what would have been the new `dn`.

also, I'm not completely sure the reasoning for using `Objects.equal` there instead of `originalDn.equals()` I'll need to check to see if either dn value can be null, but I might change that to the direct equality test instead.


FINAL?


Why you use `template` and not `templates`?


Содержимое тега <span> должно иметь курсивное начертание шрифта. Это о всех аналогичных случаях.


The same question here.


Yeah, whoops!

Although honestly this whole abstracted matchers thing just isn't a good idea IMO. I'm probably going to drop it.


Don't we want to parse and split the ```startInfo.Arguments``` string into separate arg strings?


I can read, thanks. But you must **only** set that to have an invisible nametag.


You actually need to put in some configuration for ovn-controller, as well.

Here are example commands from ovs-sandbox, but will have to be adapted to this env.

This one needs to be the path to the unix socket for ovsdb-server, which should be /usr/local/var/run/openvswitch/db.sock by default.

     ovs-vsctl set open . external-ids:ovn-remote=unix:"$sandbox"/db.sock

This one should be fine unchanged.

     ovs-vsctl set open . external-ids:ovn-encap-type=geneve

This should be changed to be the IP address that another node running ovn-controller would use for creating a tunnel to this node.  For a single node env, the value isn't important and localhost is fine.

     ovs-vsctl set open . external-ids:ovn-encap-ip=127.0.0.1


complete


add check for `outputDirectories[projectionIndex] != null`


No, that's for the shell to do.


Is this basically what would need to be done to add support for the old api?  And adjusting the indexes.


+ @alancameronwills


Can we move CoreFX to C# 6 now? This would have been much simpler:

```
public struct MethodSignature<TType>
{
        public SignatureHeader Header { get; }
        public TType ReturnType { get; }
        public int RequiredParameterCount { get; }
        public int GenericParameterCount { get; }
        public ImmutableArray<TType> ParameterTypes { get; }

        public MethodSignature(...) {...}
}


I think you can use early return to simplify this... just put `ifTrue(outputDictionaries.getElement(projectionIndex).ret)


@pb00068 ,

Also, if you want _exactly_ a formula for what you wrote, you can do this:

Let M = index of most significant bit of 1+th->idx.
(there are a number of ways to compute this; you can use bit tricks or an assembly instruction).

then your formula is

((th->idx + ply) >> (1 << (M -1)) ) % 2


@BryanBumgardner
:egg:  :sun_with_face:
OK, I guess that emoji is not available on GitHub.  :-1:


@KindDragon The problem with leaving `indent_size` as blank comes when you have `editor.insertSpaces` set to `"auto"` in the configs, then for some reason [vscode-editorconfig](https://github.com/Microsoft/vscode-editorconfig) reads that as having only 1 indentation.

![2015-12-09_02-21-15](https://cloud.githubusercontent.com/assets/5663877/11665851/07873cc0-9e1c-11e5-874e-e662eaa6065b.png)

Right now, setting `indent_size` to `4` is the only workaround that fixes the issue. I don't know if this is a known bug for vscode-editorconfig, but maybe I might put up an issue report there as well.


(Working through the backlog.) Why do we need to do this? Even if something changes in the inheritance hierarchy for the class—which we're not sure we want to allow—the *immediate* superclass can't change.

…unless this is inlineable, but still.


효과적이고 안전한 웹 플랫폼에 새로운 기본기능을 추가하는 방향으로 표준절차의 촛점이 맞추어져야 합니다.


Пусть public секция будет сверху


:+1: on the idea to change the name to `notWriteLocked`.


Ah, it seems like maybe we could just define `liftAcc` to be the identity function for the non-fission case... if we need to use it for the medium term.  Long term, all ops should be reexported from Fission, so there should be no need to do a `liftAcc`.


Instead of taking in two types of input for all of these methods, they should do the conversion themselves.  That way you ensure that you don't end up with test inconsistencies.


`UnexpectedStatusException` should be thrown


Hi. I've tested and the code works for Copter v3.2 and above. For X-receivers, you need to set the SERIALX_PROTOCOL parameter to “4.” This will get some telemetry data down to your Taranis. After that, you’re pretty much on your own regarding the display of the telemetry data on the Taranis...

If you would like, you can buy a ready-made cable and User Interface here: http://www.craftandtheoryllc.com/frsky-telemetry-cable-and-user-interface-for-pixhawk/. It comes with an advanced interface for the Taranis that includes a real-time 24fps hud and a lot more data than the official Copter firmware.


I don't know if anyone else has already pointed this out, but LockOSThread() doesn't prevent the creation of new, unlocked OS threads.  So if you mess with the thread's namespaces, the unique state can be leaked into newly created OS threads, if you do anything causing the Go scheduler to decide a new thread is needed (blocking syscalls for example, can't simply be permitted to tie up the runtime, so more threads get created under the hood).

I'm a bit surprised to see all this networking and namespace stuff here in stage1-fly, as I thought it was just a shared-host execution environment for plainly running what stage0 prepared for it.


@Illyohs I approve of this change :D


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1107.9fc5bb048717d44c09479c3123c3714daeebf821](http://build.palaso.org/viewLog.html?buildId=67017&buildTypeId=bt431) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 500, ignored: 4 Build time: 00:35:37


I already have created new branch. I pushed there old version without any
frameworks. Is it okay?
>
>


complete


Each of these can be `--N` to trigger no documentation generation.  Or `--no-document`.


The ICU section here is much abbreviated from previously. It's missing the Third-Party Software Licenses from the ICU license.html file.


Shouldn't `send_origin_headers()` take care of the problem you list in the commit message?


Thanks!


Looks good!


8 December 2015 Quests update


this is where i left off, this doesn't work at all, just figure something like this is what I'll do.


Should probably namespace the `'loaded'` hook.


That was quick! Go LTC!


Is there a way to turn this feature off? My introduction to it was being awakened in the middle of the night by it. I'd be fine with silent notifications.


Ahh, I see why this is necessary.  However, it might be better to just set it as default via the script-templates/Makefile?

We could make a new configure option like JAVA_DEFAULT (or something similar) and default it to to the Java 1.7 path.  Then it would be configured into the Makefile like all of the other settings.


I need to update that. The reason for the comment out was that this no longer works if the receiver is at depth. It was an efficiency thing, reuse the phase if nothing had changed. Short term, don't do the reuse, longer term would be good to reuse if phase, source depth and receiver depth are all the same.


typo here, REUQIREMENTS


No new line at the end of file


lustre not luster :-)


I'm not sure this is accurate, don't we use the exported JSON file from the live content store data export in step 6 to resolve any draft content items with a different `content_id` that are not substitution formats?


I extended this comment and moved some of the comments from lines 46-53 to it.


@mbootsector @ajithcj: Old versions of cutechess-cli will eat away the "ponder on". Cutechess-cli does not transfer ponder settings from fishtest towards stockfish. So cutechess-cli will manage a no-ponder game but the test engines will use their default ponder settings for time control while playing:

master will have parameters according to "Ponder=true" and the test version will have whatever default is set in the code (in most other cases "Ponder=true", but in the current test it will use Ponder="false")

This is not very obvious.

Brand-new cutechess-cli development versions support pondering and will manage uci commands accordingly. I am not aware which version is currently used for fishtest. Do you know?


Пожелание: для закрывающегося дива широко расположенных дивов, желательно  сбоку прописывать комимт с названием класса или айди который он закрывает. Это делает читабельным код  и просто удобно.


@weshaggard - C# 6 status?


Remove canola oil line


웹 플랫폼은 표준 제정자(authors)들이 이해하고 재현하는 HTML이나 CSS같은 기존의 기능들을 설명할 수 있는 기본적 기능을 제공해야 합니다.


Hmmm, actually.  Perhaps we should have a default HADOOP_FILESYSTEM_MODE option in the script-templates/Makefile instead.  It would probably be beneficial overall??


make classes use underscore to match existing code


see above


Кажется, было бы полезно добавить сюда сообщение о реальной ошибке (с помощью gai_strerror):
[getnameinfo RETURN VALUE](http://man7.org/linux/man-pages/man3/getnameinfo.3.html#RETURN_VALUE)

и задампить сам `addr`:
[MAN 3 inet_ntop](http://man7.org/linux/man-pages/man3/inet_ntop.3.html)


How can this be matching anything?


I put a test in place to test that specific corner case with the expected result of the user not being updated


change classes to use underscore (to match css)


How can that not be giving a compilation error …


change classes to use underscore (to match css)
 Add a line note


@danlipsa I don't mind removing this `if` but as far as I remember it was there to speed up things for projections that didn't need so many points.


Noooooooo


well i tried to make  an pull request but intelliJ decided to push instead.


CLOSED - no change to code


oops...


Literally translating jokes won't work. We need to find something better and leave it in English for now


so the server can ban/mute if wanted (chatserver?)


Would prefer `Count(None, None, None)` here since the values are known, mostly because it makes it easier to compare with the next case.


I need to call `Overlaps` from a few other places.


Same here.


this is unnecessary,  you can remove


What is that thing? It's obviously much more than just a cable. If it's a convertor isn't it basically the same thing as the teesny? Thanks for the info.


roll back!


I don't think this should happen here, the method returns `bool` to indicate whether the update happened or not


What's wrong with `HttpsURLConnection`?


`Serializer` should be `Writer`?


I was half hoping you would think of a good name for this and promote it to quasar.fp._. If not, I can live with this.


Aaargh, why is this always here? :)


Ok.


remove translations


Do not remove this.

GD bbPress Attachments requires the second parameter:
https://plugins.trac.wordpress.org/browser/gd-bbpress-attachments/tags/2.3.1/code/attachments/front.php?marks=41-42#L29


It is being converted to negative and positive offset
Op 8 dec. 2015 17:56 schreef "lkaino" <notifications@github.com>:

> errorGyroIf can be negative also and shrink to zero
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/borisbstyle/betaflight/commit/4138565be4284583b47b4df4911fb48b9d4dfd8d#commitcomment-14852624>
> .
>


I don't think this should happen here, the method returns `bool` to indicate whether the delete happened or not


class -> file


It's possible to do by writing `for name, node in result.nodes.items():` instead of lines 42-43. However, this would result in an error because we would be using dictionary's iterator while deleting its items in the subsequent lines (see this [SO](http://stackoverflow.com/questions/5384914/how-to-delete-items-from-a-dictionary-while-iterating-over-it) topic).


Nothing was, I dont even remember changing it ever.


Would be great if you could merge this back into the original project since you've already done the work!


Это коммент на первый commit


hi @shermanash
:cool: emoji!


Can you change it back then, please? :3


I didn't do it!


Ok I experienced the same problem as is mentionned in this change.  It happens only with UIImage.FromBundle, not FromFile


@pdilyard I know, it keeps popping up :( not sure how/why, maybe aliens trying to tell us something?


Не относится к PR, но не лучше ли оборачивать подобный include в `define`/`undef`?


hi @chuckwondo
cool emoji's! :+1:


Add closing @ after dropWhileEnd


this will need to be amended to include CSRF tokens in the request when CSRF protection goes live. might as well add them now. see https://github.com/dimagi/commcare-hq/commit/b44b3dea4a2ffd29b892f8cf3d318deb49ea5818 for an angular example.


Oops, my bad. :blush:


@whatyouhide Aliens hate Ruby style guides


@yawitzd
cool choice of emoji!  :+1:
Is that in anticipation of the bootcamp? :smile:


We should move this back to PreludeList, the Standard demands it.


could we chat on skype? my username is the same as the github one. thanks


Well, it’s called `foldLeft` 😉

I could see this version of it being useful on arbitrary values, but yeah, I don’t know what to call that.


TeamCity LabKey :: Sprint :: Premium :: Git postgres 9.4 [Build 6](https://teamcity.labkey.org/viewLog.html?buildId=290338&buildTypeId=LabKey_Sprint_2_LabkeyPremiumTrunk_GitPostgres94) outcome was **FAILURE**
Summary: Snapshot dependency failed: LabKey :: Sprint :: Community :: build Build time: 00:00:02


TeamCity LabKey :: Sprint :: Premium :: Git sqlserver 2014 [Build 6](https://teamcity.labkey.org/viewLog.html?buildId=290340&buildTypeId=LabKey_Sprint_2_LabkeyPremiumTrunk_GitSqlserver2014) outcome was **FAILURE**
Summary: Snapshot dependency failed: LabKey :: Sprint :: Community :: build Build time: 00:00:04


TeamCity LabKey :: Trunk :: Premium :: Git postgres 9.4 [Build 832](https://teamcity.labkey.org/viewLog.html?buildId=290305&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 24, passed: 256 Build time: 01:37:35
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testDatasetExport: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelection: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelectingEmptyMeasure: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnStudyNavigator: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testGroupSaveAndLoad: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyParticipantCounts: <no details avaliable>

##### there are 14 more failed tests, see build details
```


hi @same1009
Cool choice of emoji!  :+1:


You mean
    sortBy (comparing f)


Passing 259/267 LabTS tests, needed one more day to sort out scope and nested functions...


drop the 'e' in sortOne


I cannot duplicate the "ol\ul\a\img and del tags" problem on my install.

Do you have any sample text I can use to duplicate this?

I use `stripslashes()` above the fold:
https://github.com/r-a-y/bbp-live-preview/blob/master/bbp-live-preview.php#L213

Why does `stripslashes()` need to be called again?


Ah! Cool, I did not know this was possible with CMake.

So is there no alternative to hard-code each dynamic and static library file extension for each operating system?


hi @emilyhoughkovacs
cool choice of emoji's!  :+1:


I'd like to merge this PR, but need two things first: (1) If you've not already done so, can you sign the individual contributor agreement at https://support.springsource.com/spring_committer_signup; and (2) Can you add some tests around the changes shown here?


I added a new method `DotBuilderWrapper.get_reserved_node_names()` that groups reserved words.


oo, thanks, missed all that. I guess this is a job for some proper html stripping.


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.4 [Build 27](https://teamcity.labkey.org/viewLog.html?buildId=290315&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 17 (7 new), passed: 31 Build time: 01:05:41
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterPane: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

##### there are 7 more failed tests, see build details
```


Just `equal`


hi @ingrid88
cool choice of emoji!  :+1:


CLOSED - requested change implemented


complete


this comment was for another kata 12/8


no issues here, tested an works good. magento is not providing files directly.


that's awesome, thanks :+1:


선순환 for virtuous cycle (반대말은 악순환 - vicious cycle)


@BryanBumgardner
wait, another student picked it too!
:moyai:


@santigimeno Would you please explain this code? In what case would `base` not be an `instanceof Date`? Also, on [line 288](https://github.com/node-schedule/node-schedule/commit/ce8d7a6b27c0ead77b15d031de23a28be44cb096#diff-e548a7b1975de2141f59ab352467fc5eR288), why do we need to pass in a timezone if you're scheduling for *now*? The timezone conversion/manipulation there seems unnecessary (may be missing something).

// cc @mrmayfield


@jamesevers
cool choice of emoji!  :+1:


This was my commit, still having trouble with sourcetree showing my profile.


This issue appears due to the recent update of QQ Connect. Uppercase  letters are NOT accepted any more.


That looks fine to me.


test


add comments: selected_level in [0, 1, 2, 3]


This index and the other two should refer to the current table (page_assessments_log), rather than page_assessments.


TeamCity SFRGSS :: Linux 64-bit [Build 0.1.35](https://pixelated.design/build/viewLog.html?buildId=282&buildTypeId=Sfrgss_Linux64bit&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:08


are these parameters just for testing?


Nodejs checks pass on local build, server only issue, uploaded


TeamCity DnnPackager :: Continuos [Build 42](http://dazinator.ddns.net:81/viewLog.html?buildId=1461&buildTypeId=DnnPackager_Continuos&guest=1) is now running


TeamCity DnnPackager :: Continuos [Build 1.1.0-unstable.23](http://dazinator.ddns.net:81/viewLog.html?buildId=1461&buildTypeId=DnnPackager_Continuos&guest=1) outcome was **FAILURE**
Summary: Compilation error: src\DnnPackager.TestModule\DnnPackager.TestModule.csproj (new) Build time: 00:00:11


Thanks! :)


add
++hashtable->collision_times;


Need to remove the comma at the end.


Yes, this is strictly a test module which chose a then-unused block of message codes.

Sadly this will collide again someday.

> On Dec 7, 2015, at 9:05 PM, Brett Hazen <notifications@github.com> wrote:
>
> are these parameters just for testing?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/basho/riak_api/commit/87507ce6cddff6d75d51954b2bbc7181e40b3020#commitcomment-14837301>.
>


TeamCity SFRGSS :: Linux 64-bit [Build 0.1.36](https://pixelated.design/build/viewLog.html?buildId=283&buildTypeId=Sfrgss_Linux64bit&guest=1) outcome was **FAILURE**
Summary: Tests failed: 3 (3 new), passed: 4; exit code 134 (new) Build time: 00:01:03
### Failed tests
```
Table: 1D: #[]: treat as 3D: treat as 3D raises an ArgumentError: <no details avaliable>

Table: 1D: #[]: with negative x: with negative x returns nil: <no details avaliable>

Table: 1D: #[]: treat as 2D: treat as 2D raises an ArgumentError: <no details avaliable>

```


"docs/en/index.mx" :)


My preference would be to have the config file found via an environment variable:
```
config_path = os.environ['DATACAT_CONFIG']
client = datacat.client_from_config_file(config_path)
```
and have DATACAT_CONFIG set in the site-specific setup script.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8447](https://teamcity.mesosphere.io/viewLog.html?buildId=87936&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:10


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1443 of 1443 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.52%25-green.svg)


Perhaps we should use :::yml to open the yaml block instead of ``` so as to be consistent with :::php, :::ss, :::html etc.


Fixes #2


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8459](https://teamcity.mesosphere.io/viewLog.html?buildId=87957&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:05:08


Hey @alexandramedway - everything looks super good! This is a quick, nitpicky, and minor stylistic comment. Since there are only two options here (true and false), it would make more sense to use a conditional `if-then-else`. So:

```ocaml
let stmt' = if ia then Sast.Assign(id, if_ew) else Sast.If(stmt) in
```
etc...


@jacksenechal will you submit this as a PR?  They still have this bug :frowning: https://github.com/ipfs/js-ipfs-api/blob/9fd8ced1a40670dbc34e936f71f0111d9c8bfaa1/src/request-api.js#L95


this drops the error tracking, is that deliberate?


Can you publish a new minor version that includes this change?


same


could you add some friendly error handling messaging when the appropriate arguments aren't provided?  For an example look at the `get` command


:::yml ?   :)


that's great, exactly what i was trying to do. glad this is getting in! :)


Sure @frewsxcv, is the libc dependency causing problems?


TeamCity SFRGSS :: Linux 64-bit [Build 0.1.37](https://pixelated.design/build/viewLog.html?buildId=284&buildTypeId=Sfrgss_Linux64bit&guest=1) outcome was **FAILURE**
Summary: Tests failed: 6 (6 new), passed: 9; exit code 134 (new) Build time: 00:00:09
### Failed tests
```
Table: 3D: #[]: treat as 2D: treat as 2D raises an ArgumentError: <no details avaliable>

Table: 3D: #[]: with negative y: with negative y returns nil: <no details avaliable>

Table: 3D: #[]: with negative x: with negative x returns nil: <no details avaliable>

Table: 3D: #[]: with negative z: with negative z returns nil: <no details avaliable>

Table: 3D: #[]: treat as 1D: treat as 1D raises an ArgumentError: <no details avaliable>

Table: 3D: #_dump: #_dump generates expected result: <no details avaliable>

```


saw approval from javajolt
at https://github.com/basho/riak_api/commit/87507ce6cddff6d75d51954b2bbc7181e40b3020


merging basho/riak_api/feature/jrd/toggle-pb-t2b = 87507ce6 into borshop-integration-101-feature/jrd/toggle-pb-t2b


basho/riak_api/feature/jrd/toggle-pb-t2b = 87507ce6 merged ok, testing candidate = 57dffc9d


TeamCity SFRGSS :: Linux 64-bit [Build 0.1.38](https://pixelated.design/build/viewLog.html?buildId=285&buildTypeId=Sfrgss_Linux64bit&guest=1) outcome was **FAILURE**
Summary: Tests passed: 23; exit code 134 (new) Build time: 00:00:09


Yes, the root cause is `(not (company-in-string-or-comment))` in company-etags.el, web-mode doesn't matter.


do not need indent this


add comments: no replacement, no need to keep the signal


do we need #ifndef ANDROID?


@corwinstephen I see 15 annoying files as there is a ReadMe and a .gitignore in the files folder.  Unfortunately there is no nice way to do this.  I think step one is to get the addresses normalized in each file, that might require a custom normalizer for each one sadly.  Also a lot of the excel files seem to have a lot of sheets, so I will likely go in and export each sheet into its own csv.  I'll have a closer look tomorrow


setUpdateDateメソッドを利用しましょう


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8461](https://teamcity.mesosphere.io/viewLog.html?buildId=87960&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:38


we need hide this in v4l2 wrapper. caller do not need know it have vpp or not


This, and all the other functions that are called statically in this class, should be explicitly declared as static functions.


404 on the blog link....should be: http://addons.silverstripe.org/add-ons/silverstripe/blog
404 on the widgets link...should be: https://addons.silverstripe.org/add-ons/silverstripe/widgets
404 on the comments link should be: http://addons.silverstripe.org/add-ons/silverstripe/comments

The add-ons in the path seems redundant when the host is addons.silvertripe.org... :)


v4l2decode.cpp is v4l2 user. they do not need know any thing about va, If they need. maybe we have some thing wrong in api design.


@simonyangme this is no longer supported in the new ConvenienceKit Cocoa Pod.

had to use:

```followingUsers = followingUsers.filter { $0.username != user.username }```


add


Should this be `!= SOURCE`? Or add a `SOURCE` case here and a default to fail for any unhandled type?


v4l2 user do not need know any thing about yami


nice!


404 on the comments link...see above


is there already a product-row in the markup?


глобальная переменная?


This could be inverted


все 3 сценария похожи, можно как-то обобщить?


we need hide this details in v4l2 wrapper


bug! I think


Looks like this should be $values['pa_user_id'].


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8463](https://teamcity.mesosphere.io/viewLog.html?buildId=87964&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 206 Build time: 00:04:46


Fix injection of $log


move all display logical to tests/v4l2decode.cpp


Remove un-necessary call.


I don't know how may developers does it take to change a light globe?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8462](https://teamcity.mesosphere.io/viewLog.html?buildId=87961&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:09:52


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8452](https://teamcity.mesosphere.io/viewLog.html?buildId=87944&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout Build time: 01:00:08


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8454](https://teamcity.mesosphere.io/viewLog.html?buildId=87946&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Execution timeout (new) Build time: 01:00:09


日，以後不要用帶空格的 shebang


why?


$values['pa_timestamp'] is not defined. You can use wfTimestampNow() instead.


Please hide L278 to L 285 in one function named getVideoFrame(ANativeWindowBuffer*)


你新名字就叫「日 njit」了。


Great work. thanks for your contribution. I like your addition of the joke to the Hello World project. It creates a sense of ease for new readers. Please finish the joke and I'll merge the pull-request final updates to the master project.


all tests pass:
success: http://buildbot.bos1/builders/test-riak_api/builds/163


Versão final do artigo
[Artigo Siscon Patrimônios.docx](https://github.com/SIN1028ProjetoSoftware2015/ALMOX/files/54847/Artigo.Siscon.Patrimonios.docx)


I suppose I can add an option `company-etags-everywhere`, similar to `company-dabbrev-code-everywhere`.


稍等，readlink -f 处理绝对路径有什么不对的吗？


画蛇添足吧。


do we need include NATIVE_DISPLAY_DRM in this ifndef?


TODO:
1. add code in cm_experiment_setting to separate selecte_flow thresholds and target_flow thresholds.
2. add code in tcpreplay to update selecte_level based on selecte_flow thresholds and target_flow thresholds.


yes, please


I'm using https://github.com/moteus/lua-travis-example which builds luarocks ready for install without sudo. Local is not necessary. See: https://github.com/moteus/lua-travis-example/blob/master/.travis/setup_lua.sh#L17


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8464](https://teamcity.mesosphere.io/viewLog.html?buildId=87966&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:13


I got lazy about the constants.


So you are saying I forgot to call parent::beforeSave()?


objectListからまとめてリレーション用のパラメータを作成するのであれば、JSONArrayのobjectsは不要になると思います。


It's looks good.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8467](https://teamcity.mesosphere.io/viewLog.html?buildId=87971&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:49


forgive me, i just forget to write message for  this commit
how  can i  add relative message?


Yes, that looks good. We'll have to go through the code base and apply such fixes.


@yehudasa It is great,I dont want update the clients too,If client can input custom command.But I really can not find the structure you mentioned,can you specify it for me? Thanks!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8468](https://teamcity.mesosphere.io/viewLog.html?buildId=87972&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:48


This is supremely gross. One alternative is to enumerate the partial functions we want to hide from `Data.List`?


レスポンスの確認がaddとremoveで共通なので、メソッド名を変更したほうがいいと思います。


Hacky would be rendering alert dialogs based on a bunch of booleans passed to the template! :P Using the flash messaging framework means the template just needs to call ``get_flashed_messages()`` and render them only if they're there.


should we need time flag?


Shouldn't this be `var xriUrl = match[0].slice(7,match[0].length - 4);`?


It looks like "BLOCKING" and "NON_BLOCKING" are exclusive values. So, why not set a boolean "NonBlocking" instead of two enumerations? If it is non-blocking, we can handle it directly, otherwise put it into queue. Then it is clear also for the handler table.


Needs to be updated to $row->pa_class and $row->pa_importance.


assertFailを利用すればテストが失敗すると思います。


Esse projeto foi criado com HTML e CSS.


Should have t.cast = 1 so that quanta cost of ability is 1, not 1 or 2


スタブサーバーからのレスポンスも確認してもらえますでしょうか


You can include java config files in the xml config too like:
<bean class="com.myapp.config.AppConfig"/> <!-- this is a java config class -->
<bean class="com.myapp.config.DataConfig"/> <!-- this is one too -->
<bean class="org.springframework.config.java.process.ConfigurationPostProcessor"/> <!-- this is the one that uses them -->
But for now I would stick to the basics, and use the methods I described in my earlier comments.


you can use hack.Slice to prevent memory allocation.


You may want to also commit the project file for Windows. The solution file is there, but the project file isn't.


テストの命名規則がバラバラになっています。


四角阴影


NCMBRole側では、belognUser / belongRoleがどうなっているか確認してもらえますでしょうか


May I know the reason why adding connection notification listener twice?


With the latest changes and what you already submitted, you have demonstrated a good understanding of all the concepts and can clearly perform all the associated tasks. I will record a final mark on blackboard for you for the bash assignment now.


Only one concern here. Since "vmbusQ" work queue does not lock when invoking the handler, but "control" work queue has to lock. Please make sure there is no race condition before this modication.


A站弹幕文件的那个pageSizeh后面的数字可以是1000


`shared_mt` is being declared twice in this file, basically the latest declaration (this one) overrides the first one, making the first one obsolete.


yeah I saw


I suggest `MAKE_PARALLELISM` here. `_J` is straight up ugly.


Gah, [fixed](https://github.com/freeorion/freeorion/commit/f31f3ea975ef411d62ef76f85a1a64610463bb87) thanks mate.

Morlic, it was back when I was last working on it, before release, didn't try any renaming this time as I wanted to get at least something done, breaking it down into smaller chunks makes sense. I'll try again at some point soon but I don't think changes have been made in that area since I last tried. May've been something I did wrong anyway, was in a rush.


Please don't depend on git packages as a library...


datetime explode 써서 나눠주기


data['upgrade_messages'] = [step.order_index][module.tool.name]?


@untitaker don't worry, I will update this before I release 0.10.0


I don't recall if we're doing this in the other prettyprinters, but this can lead to N^2 behavior (where N=indent level) if the strings are large. The CppmlPrettyPrinter has a stream indent that can be better. I wouldn't spend a lot of time on it, but you might try that, as this could be quite slow for large functions.