It doesn't seem to break anything:
```
]$ ./cipherscan --sigalg cloudflare.com
.............................
Target: cloudflare.com:443

prio  ciphersuite                    protocols      pubkey_size  signature_algoritm     trusted  ticket_hint  ocsp_staple  pfs                 curves      curves_ordering
1     ECDHE-ECDSA-CHACHA20-POLY1305  TLSv1.2        256          ecdsa-with-SHA256      True     None         True         ECDH,P-256,256bits  prime256v1  server
2     ECDHE-ECDSA-AES128-GCM-SHA256  TLSv1.2        256          ecdsa-with-SHA256      True     None         True         ECDH,P-256,256bits  prime256v1  server
3     ECDHE-ECDSA-AES128-SHA256      TLSv1.2        256          ecdsa-with-SHA256      True     None         True         ECDH,P-256,256bits  prime256v1  server
4     ECDHE-ECDSA-AES128-SHA         TLSv1.2        256          ecdsa-with-SHA256      True     None         True         ECDH,P-256,256bits  server
5     ECDHE-ECDSA-AES256-GCM-SHA384  TLSv1.2        256          ecdsa-with-SHA256      True     None         True         ECDH,P-256,256bits  prime256v1  server
6     ECDHE-ECDSA-AES256-SHA384      TLSv1.2        256          ecdsa-with-SHA256      True     None         True         ECDH,P-256,256bits  prime256v1  server
7     ECDHE-ECDSA-AES256-SHA         TLSv1.2        256          ecdsa-with-SHA256      True     None         True         ECDH,P-256,256bits  server
8     ECDHE-ECDSA-DES-CBC3-SHA       TLSv1.2        256          ecdsa-with-SHA256      True     None         True         ECDH,P-256,256bits  server
9     ECDHE-RSA-AES128-SHA           TLSv1,TLSv1.1  2048         sha1WithRSAEncryption  True     None         True         ECDH,P-256,256bits  server
10    AES128-SHA                     TLSv1,TLSv1.1  2048         sha1WithRSAEncryption  True     None         True         None                None        server
11    ECDHE-RSA-AES256-SHA           TLSv1,TLSv1.1  2048         sha1WithRSAEncryption  True     None         True         ECDH,P-256,256bits  server
12    AES256-SHA                     TLSv1,TLSv1.1  2048         sha1WithRSAEncryption  True     None         True         None                None        server
13    ECDHE-RSA-DES-CBC3-SHA         TLSv1,TLSv1.1  2048         sha1WithRSAEncryption  True     None         True         ECDH,P-256,256bits  server
14    DES-CBC3-SHA                   TLSv1,TLSv1.1  2048         sha1WithRSAEncryption  True     None         True         None                None        server

OCSP stapling: supported
Cipher ordering: server
Curves ordering: server - fallback: no
Server supports secure renegotiation
Server supported compression methods: NONE

TLSv1.2 ephemeral sigalgs:
PFS ECDSA fallbacks to pfs-rsa-SHA512
server forces SHA1 with RSA
Server side sigalg ordering

Supported PFS ECDSA signature algorithms
prio  sigalg
1     SHA512
2     SHA384
3     SHA256

Supported PFS RSA signature algorithms
prio  sigalg
1     SHA512
2     SHA384
3     SHA256
4     SHA224
5     SHA1

TLS Tolerance: yes
```


I can't reproduce the error so likely it was happening early in development when I didn't have the classloader stuff set up correctly. I don't see a problem with not resetting the classloader, but I only need the modified one when the script engine is instantiated (as it becomes the engine's parent classloader), so I figured I would leave things the way I found them :)


Just nitpicking here, but I think "Please, report this error to the developers. ..." is grammatically more correct.


+1 LGTM :shipit:


点赞...


Still no new items like redstone working 😣


Весь кусок:
```php
$data = mysqli_fetch_array($result, MYSQL_ASSOC);
		$count=0;
		while ($data) {
			$count++;
			$news_list[$count] = array (
				'id' => $data['id'],
				'news' => $data['news']
			);
			$data = mysqli_fetch_array($result, MYSQL_ASSOC);
		}
```
Можно было заменить на:
```php
while($row = mysqli_fetch_array($result, MYSQL_ASSOC)) {
    $news_list[] = $row
}
```

Общее количество элементов в массиве получать так:
```php
count($news_list)
```


A virer dans un modulé générique


Comment référence-t-on ce template ?


Шаблонизацию значений нужно делать на этапе форматирования данных для вывода, а не в процессе выборки из БД.


Looks good to me :+1:


в это правило можно загнать все общие стили для select и input: border-radius, height, border. Сейчас у тебя бордеры и высота разные


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9854](https://teamcity.mesosphere.io/viewLog.html?buildId=95525&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:08:14


This commit is being reviewed as a part of review issue #139.


these `<li>`s can also contain the `<p>` and `<img>` that comes immediately afterwards - they are also list item content


It looks OK


null is assumed by default in ```reset```


I would move all the table creation in one function.


Yep, sure


I'll just reword to:
````
The event user module uses the circular buffer library interface for the creation
and management of event queues. Separate user and kernel thread routines are used.
The kernel thread receives events from the kernel layer and posts them into the
user-internal event queue. The user thread processes all events received from
the user-internal event queue.
````


gh-pages


Отсутствует проверка на получаемое значение.


Ok, this works for me and gets rid of eval. I am not too fond of globals though so how about the below for master, or something similar?

```diff
diff --git a/blueman/plugins/mechanism/Network.py b/blueman/plugins/mechanism/Network.py
index ffc5e6b..f4dd833 100644
--- a/blueman/plugins/mechanism/Network.py
+++ b/blueman/plugins/mechanism/Network.py
@@ -10,6 +10,9 @@ import subprocess
 from gi.repository import GObject
 from blueman.main.NetConf import NetConf, DnsMasqHandler, DhcpdHandler, UdhcpdHandler

+DHCPDHANDLERS = {"DnsMasqHandler": DnsMasqHandler,
+                 "DhcpdHandler": DhcpdHandler,
+                 "UdhcpdHandle": UdhcpdHandler}

 class Network(MechanismPlugin):
     @dbus.service.method('org.blueman.Mechanism', in_signature="s", out_signature="s", sender_keyword="caller",
@@ -53,7 +56,7 @@ class Network(MechanismPlugin):
     def EnableNetwork(self, ip_address, netmask, dhcp_handler, caller):
         nc = NetConf.get_default()
         nc.set_ipv4(ip_address, netmask)
-        eval("nc.set_dhcp_handler(%s)" % dhcp_handler)
+        nc.set_dhcp_handler(DHCPDHANDLERS[dhcp_handler])
         nc.apply_settings()

     @dbus.service.method('org.blueman.Mechanism', in_signature="", out_signature="", sender_keyword="caller")
```


It would be great to have a new release with this fix


I'm not a big can of magic numbers, could these be named in someway?

Something like
```
  const int32_t StereoBitOffset = 100;
  const int32_t StereoSpacing = 10; // E=10 Z=20
  bt = StereoBitOffset * StereoSpacing * (... )
```

These names are made up of course :)


If you run into a problem with the code that imports cancer types please either suggest a better way or ask about it, removing the functionality and hiding your question in a cryptic comment somewhere in a commit that is supposed to be about the meta script is dangerous.


Agreed and no order complexity stuff is involved here, so better to use a set


This should be in a seperate page, try making the About Me and Portfolio as two different pages, and link them together with `<a>` links in a `<nav>`


The base `#phantom?` method already checks more than one condition, which is actually used to then set the flag in a callback. Refer to https://github.com/instedd/cdx/blob/release/0.7/app/models/concerns/entity.rb#L69 and https://github.com/instedd/cdx/blob/release/0.7/app/models/concerns/entity.rb#L116.


I really like the test case. Thanks for putting the effort test this edge condition


Thanks a lot!


Логику, отделяют от представления.


não sei se isso deveria ser versionado :/


Good work with the correct path for the image


Perect! :rose:


Done in the morning... Added transients for caching ( 1 day )


Blocked members are getting a 404 page #624


:kiss:


le format pour un char c'est %c


Дубль указания настроек. В случае возникновения потребности в изменении параметров конфигурации придется ходить по всем файлам.


The indentation is done using spaces here and on some following lines.


This code is almost finished.
Please look error log on log cat.


your styles are simple and you could be more adventurous. however there is a clear and consistent use of selectors which is good


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9855](https://teamcity.mesosphere.io/viewLog.html?buildId=95528&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:08:43


okay xmas comes early for you :) implemented in 7cf2247fd540e41447688dcd8bf0646a1d950844


double scrollbar on friend request #631


Нет форматирования данных, полученных с клиента. SQLInjection


Huh, I'm not sure. Here is the original commit to plone.app.widgets before it was moved here: https://github.com/plone/plone.app.widgets/commit/fd6c683b32bbc59aaf641dc343cf38f5eaf27937


Didn't even think of doing that, thanks so much! :+1:


Clever way to delve into the data rather than strictly defaulting to numeric


Hot reload everything!


lol


Nice catch, Severin :-)


Форматирование даты, целесообразно было бы вынести в отдельную функцию. Если учесть наличие инструкции:
```sql
`date` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP
```
то изменение даты не имеет смысла.


Yes, the general case should work just fine, I'm afraid about buggy servers. That's why said "may break" not "is breaking". Will need to do some experiments to check.


porcelain is actually spelled like that


FIX: remove commented code


selecting a CLOSED group I'm neither member nor owner of gives Warning #632


:shipit:  - the same documentation link also covers all the models we discussed this morning


Вставка данных на основе грязного хака. Без предворительнгого форматирования - уязвимость.


We need to time intervals. So please add start_banjax_timestamp and stop_banjax_timestamp


Not a bad first attempt. I've put the solution files for the Week1 assignment in the **ga-fewd-files** repo. Just select this in GitHub Desktop and click **Sync**.

They are in the **week2_working_files/week1_solutions/assignment-solution/** folder


english:

ok, let's for parts like YOU guides me:
as the search is on relnotes:
4. Download MinGW C compiler by typing: `getmingw.bat`
I thought several "getmingw.bat" on Google.
But the link that most closely matches the reality is this one with your signature:
https://github.com/vszakats/harbour-core/blob/master/package/getmingw.bat
but I did not see any means of download mingw.
How to?
grateful once again for your attention!
====================
portugueses:
ok, vamos então por partes, como V.Sa. me orienta:
ao pesquisar conforme está no RELNOTES:
4. Faça o download MinGW compilador C, digitando: `getmingw.bat`
ACHEI vários "getmingw.bat" no Google.
Mas, o link que mais se aproxima da realidade é este aqui com sua assinatura:
https://github.com/vszakats/harbour-core/blob/master/package/getmingw.bat
mas, nele não vi nenhum meio de baixar o mingw.
Como fazer?
grato mais uma vez pela sua atenção!


need no set, `recolved` is deleted a few lines below


其实这里直接写 `vec2Str.slice(1, -2)` 更简单


Int-ы не нужно оборачивать кавычками в запросах. SQL запросы заканчиваются точкой с запятой.


This test runs now only in debug configuration, because it relies on `disableFormatUpgrade`, which I re-exposed only internally for testing purposes.


Wouldn't this cause errors if line 36 was false


I changed describe package for a messaging app for teams.

Diogo Leal [estranho]
Site : http://diogoleal.com
talk: estranho@jabber-br.org

On Fri, Dec 18, 2015 at 11:46 AM, Duncan Overbruck <notifications@github.com
> wrote:

> Maybe its better to say what it is and not the obvious info that its for
> Linux.
> Sounds like a desktop environment.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/diogoleal/void-packages/commit/6299b38579633dfd0f2dab6900b37e92e14eddeb#commitcomment-15065385>
> .
>


Дубль
```php
if($result) {
			$_SESSION["result"];
			header("Location: /admin/");
		}
```


no its get converted to a typeOf _unit in L36


? It's what it's been changed to.


Полный дубль функции.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9856](https://teamcity.mesosphere.io/viewLog.html?buildId=95530&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:09


english:
It is to take the data and create my own file "getmingw.bat" (ie in the text editor, use the "Save As")?
if so, which folder is to save this new file "getmingw.bat"?
portuguese:
é pra pegar os dados e criar meu próprio arquivo "getmingw.bat" (ou seja no editor de textos, usar o "salvar como")?
se sim, em qual pasta é pra salvar esse novo arquivo "getmingw.bat"?


```X* x``` or ```X *x```? it should be a single codestyle.


remove comment block


Hi,

I would like there to be an option to exclude attachments form searches and
only have the gallery. It is too risky for me at the moment to include all
media in searches which come up as sellable originals. At the moment I have
had to do an ugly fix in my sell-media/inc/class-search.php.

Yours

Sam

On 18 December 2015 at 11:41, Sam Edgecombe <sam.edgecombe@gmail.com> wrote:

> Hi,
>
> Maybe you could add that if the post is an attachment (post_status =
> inherit), check that it is actually attached to a post (post_parent = !0),
> but I haven't managed to work out how to do it yet.
>
> Yours
>
> Sam
>
> On 17 December 2015 at 23:33, Thad Allender <notifications@github.com>
> wrote:
>
>> Thanks Sam. This is a known issue. Unfortunately, doing this prevents
>> gallery images from showing up in search results. We're working on a
>> solution that should solve this for everyone.
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/samedgecombe/sell-media/commit/9f96e13f952e53a105f5b4a9ebea163278f1915f#commitcomment-15054236>
>> .
>>
>
>
>
> --
> mobile: +46730922298
> skype: samedgecombe
>
>

--
mobile: +46730922298
skype: samedgecombe


What is this about?

```markdown
25.4.4.5 Promise.resolve ( x )

The resolve function returns either a new promise resolved with the passed
argument, or the argument itself if the argument is a promise produced by this constructor.

1. Let C be the this value.
2. If Type(C) is not Object, throw a TypeError exception.
3. If IsPromise(x) is true, then
    a. Let xConstructor be ? Get(x, "constructor").
    b. If SameValue(xConstructor, C) is true, return x.
4. Let promiseCapability be ? NewPromiseCapability(C).
5. Let resolveResult be ? Call(promiseCapability.[[Resolve]], undefined, « x »).
6. Return promiseCapability.[[Promise]].
```
It looks like resolve is called immediately, to me


Remove comment block


Yes, but only when L36 is true :smile:


This looks good to me! :-) Another way might be:

```
$htaccess_file_contents !== wp_check_invalid_utf8($htaccess_file_contents)
```


This is great. I'm trying to create a responsive us-map. If I create several and display the one for the right viewport and hide the others (I know not an elegant solution) only one of the maps having the labels show up correctly. The others have to have the page refreshed for it to work. Any ideas on how to fix this?


This commit is being reviewed as a part of review issue #124.


english:
C:\MVinfo\hb34>getmingw.bat
Error: This script has to be run from a Harbour binary installation.


#178 Looks like make doesn't run a format as it does elsewhere.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#aGXd4d1DSPOtMvKlqqDChg


@vcunat: See, that's a very good example for a commit that's unacceptable in regards to the commit policy in https://github.com/NixOS/nixpkgs/pull/11609#issuecomment-163844858 ;-) So can you please keep the commit messages intact and/or provide a detailed alternative description (best with a `Signed-off-by` you at the point your message starts) when squashing my commits? Thanks =)


So where is the call yaws_log:setup(), the diff looks as if you - just removed - that call???


Yeah, remove it.


Ah wait, params default value to the rescue! Ignore me, I'm hungover :smile:


re @gaocegege: :laughing:


there's nothing in NewPromiseCapability, GetCapabilitiesExecutor, or Promise.resolve that would prevent `resolve` from being synchronously called here, as far as I can tell


毕竟靖哥哥.........


According to the docu, download_by_url should require target_filename in this case, since the tar archive name and the directory name do not match.


[Only in c++17](http://en.cppreference.com/w/cpp/memory/unique_ptr/reset).


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#GjnYhLipRhOXN9a_4ivDdw


Nice!!!


Nevermind, it was my issue.  I had to turn on C++11 support for CMake on my system.  Fixed in commit 18bd6388eaf0fb6405bec32476c3c48cfb3f3d3a.  I don't know how to use Unity though, so I can't vouch for functionality.


Resolves #8


LGTM!


Resolves #9


@klacke No, ```yaws_log:setup/0``` is still there. Steve has moved it before ```nit2/5``` instead of after.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9857](https://teamcity.mesosphere.io/viewLog.html?buildId=95533&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:06


@hppritcha it is not a new parameter, it is a new value for an existing parameter (io_ompio_grouping_options) which influences the number of aggregators used in collective I/O operations. The new 'simple' option does not require any communication, in contrary to the previous default. Is this sufficient or do you need more?

I noticed btw. that I forgot to list this parameter in the ompio section of the FAQ, will try to update that over the break.


Thanks : )


Shouldn't you return the data.frame that's read?


@danilaml Seems like I typed the correction wrong. I have corrected my correction.


@klq I've finished homework #0. I'm ready to submit it for review.


Indeed! (if you follow the step-by-step RELNOTES.txt instructions, you'll reach the same result.)


@vinoski I've just check it quickly, but it seems good.


I don't understand quite how halfAxes works, and it seems the sides of the box I create are twice the lengths I expected, and thus the distance test for when camera should be outside the box fails. How does halfAxes work?


in case of ```!ck_holder.empty()``` and ```!bytes_transferred``` there will be no ```ck_holder``` deallocation... this behavior is not the same as in the original code.


@stinos What we are doing her is the standard behavior. But in a specific program, your might want to have a different behavior anyhow. For that, the possibility to set tty to raw mode and installe your own signal handling is much more important. And that's possible with the Windows and Linux versions. The PyBoard and especially the WiPy version are a little bit more restricted. In one of his examples, @pfalcon provdided sample code to set tty to a transparent mode and back :
```
    def init_tty(self):
        import tty, termios
        self.org_termios = termios.tcgetattr(0)
        tty.setraw(0)

    def deinit_tty(self):
        import termios
        termios.tcsetattr(0, termios.TCSANOW, self.org_termios)
```
Using that, you can define the terminal behavior as you like. B.t.w.: That's what is done for the REPL prompt.


You should add the documentation of the new parameter on the command line


@glyn The problem is of course that users are asking for `Route`s (`operations.routes().list()`) and yet being handed back a response that is not a `Route`.  As far as the name conflict, we're going to have a great many of those because the CLI shadows many of the concepts of the REST API, but augments them for user experience.

Fundamentally, the problem is that CLI is sloppy in it's naming.  But I still believe that our goal here is to adhere to the CLI's design, sloppy or not.  And from that perspective, running `cf routes` return a list of `Route`s, not a list of `RouteBinding`s.


This is not an intentional change, probably deleted first and then added back without paying attention to the style.


This commit is being reviewed as a part of review issue #139.


One question though: what is that new binary?  I can't seem to find a code reference for it but I didn't look too hard.


This "defer" line should not be added here: this function returns `tests` and the callers needs them. The callers actually already do the `defer osArchTestRemoveImages(tests)`.

/cc @krnowak


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9858](https://teamcity.mesosphere.io/viewLog.html?buildId=95534&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:03:43


There's no change to the tests in this file.  The only change is that the imports have been re-ordered, which is done automatically by my IDE when the class was refactored into the sub-package.  I also had to import classes that were previously in the same package as this test and now aren't (lines 28-30).


The commit is over 3 years old. Write a test, submit a PR.


oh yea, good idea, don't wan't folks confusing this for a "new aesthetic" jam


Resolves #19 - Extracted object info dialog code from ModelController and renamed it too


@monsta
This works for gtk2 build too, but i'm pretty sure you can improve that.
Otherwise merge it to maste please.


Hi, it is a test branch done by @DaOnlyOwner he shows here possible realization of new features, I think
they does not work. I will discuss with him the development. Do you want to join the discussion?


```
if (!ck)
    return;

std::unique_ptr<completion_key> ck_holder(ck);
if (!bytes_transferred)
    return;

// bla bla 1

if (impl)
{
     // bla bla 2
}

ck_holder.release();
```


現在Alpha版で更新中です


It appears that previously, we were storing the address - storing the PKH/redeemScript without context is causing https://github.com/bitpay/bitcore-node/issues/377


Not sure, maybe krzysztof can answer that.


@klq I've finished homework #1. I'm ready to submit it for review.


Ay waite i forget something:)


Ahh ... I see now, yes. Looks good.


The reason for moving this has been OBE'd.  I've moved it back into the same package as everything else.


We should throw an exception.


or
```
if (!ck_holder || !bytes_transferred)
    return;
```


Changed this back to int.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=2)


@klq I've finished homework #2. I'm ready to submit it for review.


Fixed in most recent push. Using Qt-style names, as this is a Qt widget. I will change later if you wish.


@HEskandari What is the purpose of `IsNotSystemDSid`?


At least the naming of the variables isn't quite clear.


@russgray landed on Maven Central, let me know if you face any issues.


Done! See for details:
https://github.com/h2non/rocky/blob/36507031c94e2bbe93c4e553d50e772a3fee020b/lib/middleware/to-path.js
https://github.com/h2non/rocky/blob/36507031c94e2bbe93c4e553d50e772a3fee020b/test/middleware/to-path.js#L66-L91


Inconsistent indentation: one line above tabs were used. This commit uses spaces.


Что ты тут складываешь? Проверяешь свой код перед комитом?


Yeah, it was a typo. It should be normal.


What if a license is in both locations?
What if the license in HKLU is invalid and HKLM is valid?
How does the user or admin know which license is loaded?


This function call has been made obsolete by refactoring from getopt to argparse, right? If so, you can remove the call and the function.


I like this one.


Strive for atomic commits http://www.freshconsulting.com/atomic-commits/

This commit can be split into two commits, as the commit message itself says that:

1. fix Error parse.We should always readString after read errorCode
2. getValue add pre check binary condition


Fixes #1641


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=3)


Объясни, что буквально ты хочешь сделать в этой и следующей команде?


Yeah sure, I'd like to help out if possible.  I made some changes already to support the CMake build system.


@monsta
maybe you want improve that, otherwise merge it please.


"Foundation 6 uses one such declaration"

This probably is not a problem anymore. https://github.com/rstacruz/sinatra-assetpack/blob/master/lib/sinatra/assetpack/package.rb#L109-L114 seems to have fixed this. My original bug report: https://github.com/rstacruz/sinatra-assetpack/issues/76 I've created a temporary repo here: https://github.com/kgrz/temp to check if this still is a problem.

I've followed most of the instructions. The compass parts can be removed, I think. Same goes for instructions to install bower; `npm install` covers it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9859](https://teamcity.mesosphere.io/viewLog.html?buildId=95535&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:07:19


Hey guys,
I don't know about that binary file either...
I am going to make a video explaining how this can be used in Unity or other game engines. I'll upload it this evening.


My two cents is to remove the binary until we know what is is though.  Hopefully we can get some clarification.


@klq I've finished homework #3. I'm ready to submit it for review.


This is wrong. It will only generated for the MSVS generator, leaving nmake out of luck.


Ok, thanks for a quick response on the binary @DaOnlyOwner.  I'm going to push a commit to remove it.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=4)


Oh, you're absolutely correct. It *used* to use `.scss` if `Sass` was selected. I'm not sure where that code went.. Anyhow, I'll fix it.


Missing `*`


Stray println


Thanks. Looking into your updates


What does "nonvariant" means here ?


I'm sorry. I thought the link to the PR would be sufficient for anyone truly wanting the details of "why", especially for documentation. (I also personally tend to push the "why" information into the actual code/docs instead of commit messages.)

I seem to have missed the point of `Singed-off` lines; can you point me to an explanation?


@spamik   Interesting! I am okay in pulling the change to InfluxDBClient.cs, may I know what you changed in project structure?


Vet inte om vi ska använda $_SESSION till error, om vi ska göra det behöver vi tömma ['error'] på varje sida vi kommer använda den på.

Ex: Om användaren får upp error i  calendar.php så kommer samma error att visas i index.php.

Om vi tömmer $_SESSION['error']  varje gång en ny sida laddas kan vi inte använda oss av header('location: <page')
Inte titta mer in på error hantering, men kanske finns en bättre lösning


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9860](https://teamcity.mesosphere.io/viewLog.html?buildId=95543&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:03:43


There really doesn't seem to be another pure CSS solution to that problem. Maybe we should go with 50em max-height or fix it with JS?


This implementation is not working on trusty


There is no _unicode_ in Python 3. According to [this](https://docs.djangoproject.com/en/1.9/topics/python3/#string-handling) the new function names like `force_text` are available since Django 1.4.2, and this project has a dependency on Django>=1.5.


I agree, that's better. Please add it to master and 2-0-stable. I'll drop the eval branch and make a 2.0.3 release of 2-0-stable.


Reverted my change


In Python 3, `json.dumps()` doesn't accept an `encoding` kwarg, and in Python 2 the default is `'utf-8'`, so we can just omit it.


Giving the argparse result of the arguments to the meta script verbatim to the validator looks fragile. I’d suggest either defining explicit arguments for the function you are calling here, or somehow making the validator in charge of parsing its own arguments.


Did you merge [this](https://github.com/zador-blood-stained/lib/commit/2b5f13fea0517acfa590609affc1630524af5c50)?


I believe, for example, if the x axis (which is the first column of the matrix) is `(1, 0, 0)` then the box would be two meters wide.


`.iteritems()` is called `.items()` in Python 3. Fortunately _six_ provides a compatibility function for this.
(see [here](https://docs.djangoproject.com/en/1.9/topics/python3/#dict-and-dict-like-classes))


the future is getting more awesome, every week, find out, sign up!

Maybe it's getting too long 😜or you guys already followed through...


Sorry, 现在已经拆了。程序部分是用RepRap上面开源的


@vcunat: See the section `11) Sign your work` in https://www.kernel.org/doc/Documentation/SubmittingPatches, it's not a must per se if it comes to `<nixpkgs>` (but I do it anyway for every commit) but at least for rewriting commit messages it would be a good idea to do.


I had commented that out while testing something. It can be un-commented.
Please remember we need to test everything extensively. Please avoid such comments.


Alright.
I wrote this class in order to improve unsatisfying results when importing metallic maps into Unity etc.


```reset()``` assumes (1) with ```pointer()``` passed by default. right?


Much needed. Ty.


Oh, I see, pv doesn't know anout '-S' switch


Since this one also isn't Gulp related, could you pull it into it's own PR? Thanks! : D


I'd have to look at the Selenium docs, there's a way to have it re-scan the DOM but I don't remember how


This needs to be tested before removing the function call.


Very fast renpytom ;) Thank you! But still not working for me :/ tag is ignored or/and not played with the representive "persistent._character_volume" of the character!?


I'll modify this to read /dev/zero with dd


So if `center` is the origin, an x axis of `(1, 0, 0)` and other axes all zeroes, that should be expected to result in a line from `(-1, 0, 0)` to `(1, 0, 0)`?


Super das geht doch schon in die richtige Richtung :+1:  . Aber meinst Du nicht es würde Sinn machen zwischen 2 Objekten bzw. Klassen zu unterscheiden, ähnlich wie beim InnoZ-Scraper bzw. auch bei PyBikes. Sprich ein Objekt/Klasse für den Provider bzw. das Carsharing System und ein Objekt/Klasse für die Station?


agree, 4c65918904330825d32d3f8cccadda09fd0cd13f


maybe solve this TODO?


Yes, you're right.

This is hoe OrientDB transaction works on the binary protocol.


@mcalmer , thank you for pointing out the problem. I tried to address it with 737c7837889591ffe3e8d1412da3a39eb777c462. I hope this will resolve the junit issue. Our nightly isn't in the best shape now to run the tests.


slurp


I think it will be better to make some special issue for Unity support done here. We will be able to discuss there ideas and code changes. @DaOnlyOwner  I made you a collaborator you may commit now a code without my permission.

PS: Just to clarify I'm leaving tomorrow. Probably next time I will be able to work with AB will be in January. I will probably able to answer mails.


Well deserved!


Hi Arno,

I have a few comments, feel free to ignore them if you wish :-)

FYI, this output list format is not compatible with Busybox's "ps"
```
ps -o "%p %u %c %a" $PID
```
```pgrep -P PID```, will match if the lockfile PID is a parent process to sub process (should be if active and created with ```echo "$$"```)
** needs testing **
```
if [ -z "$PID" ] || ! pgrep -P $PID >/dev/null; then
  rm -f "$LOCK_FILE"
  echo "Note: Removed stale lockfile: $LOCK_FILE" >&2
fi
```
Finally, the simplest, since you use the plugin_restart(), plugin_start() should only be called once for each valid start.
How about simply making sure the lock file does not exist when the plugin is started.
```
plugin_start()
{
  ...

  # Remove possible stale lock file
  rm -f /var/tmp/aif_dyndns_helper.lock

  # Create cron job
  ...
}
```
Correct me, but a stale lockfile can only occur if the system was not cleanly shutdown and /var/tmp/ is persistent storage.


Ez mi?


The current htmlformentry module requires versions 1.10.2+, 1.9.9+, 1.11.3+ and anything else above this, as per this: https://github.com/openmrs/openmrs-module-htmlformentry/blob/master/omod/src/main/resources/config.xml


thx !


As you can see below, there is a code:
```go
retTests := tests
tests = nil
return retTests
```
so if everything goes fine, the defer will be called on nil tests, so it basically is a noop. If something fails during creating the missing or invalid tests, then this defer will clean up the mess.


This commit is being reviewed as a part of review issue #125.


Don't need the tableView reference here. Only reason I figured to register it within the data source is because external clients of the data source shouldn't need knowledge of what kind of cell is registered since but I think that's overkill here.


Their reasons are legal, it seems. I'm not used to do it here, as it *is* recorded that I'm committer and you're author (github even shows this). When I change something during the committing, I indicate what (and why) in the message, but that wasn't the case here.

A merge might've been cleaner... I don't know.


@Zteve made a good suggestion IMO: call this type `RouteInfo`. This allows for other `XxxInfo` classes for cf commands which return "gratuitous" extra information. Wdyt?


Even without modifying validateData.py you could give it explicit arguments by doing something like this:
```Python
validator_argv = ['--study-directory', args.directory]
if args.html_table:
    validator_argv += ['--html-table' args.html_table]
validator_args = validateData.interface(validator_argv)
exitcode = validateData.main_validate(validator_args)
```


Thanks! That is a lot cleaner. :-) Updated.


Right, which is not null and vc++2015 is unhappy.   I  didn't think much and just fed null to shut it up. There might be a  trivial performance gain this way.


中文


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9861](https://teamcity.mesosphere.io/viewLog.html?buildId=95544&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:03:58


In fact, it would be better to load this from your own account `(☉ᴥ☉)`


This line is giving me trouble, failing with the following message, just before chapter 3.2.1 in the book;

```
  1) Api::V1::UsersController GET #show
     Failure/Error: it { should respond_with 200 }
     NoMethodError:
       undefined method `respond_with' for #<RSpec::Core::ExampleGroup::Nested_1::Nested_1:0x007fddc8abb3c0>
     # ./spec/controllers/api/v1/users_controller_spec.rb:17:in `block (3 levels) in <top (required)>'
```

Any idea why that would happen?


Whats wrong in sending the entire "args" variable?

On Fri, Dec 18, 2015 at 9:51 AM, Fedde Schaeffer <notifications@github.com>
wrote:

> Even without modifying validateData.py you could give it explicit
> arguments by doing something like this:
>
> validator_argv = ['--study-directory', args.directory]if args.html_table:
>     validator_argv += ['--html-table' args.html_table]
> validator_args = validateData.interface(validator_argv)
> exitcode = validateData.main_validate(validator_args)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/priti88/cbioportal/commit/b2117cf122a68b634cbe1faf608819c3217e35e7#commitcomment-15067034>
> .
>

--
Priti Kumari
Bioinformatics Engineer
Department of Biostatistics and Computational Biology
Dana-Farber Cancer Institute <cerami@jimmy.harvard.edu>
3 Blackfan Cir,
Center for Life Science Boston, Room 11037,
Boston, MA 02115
617-632-6133


No, we do not need this. The tag can be extracted from the base image name.
ubuntu:latest => tag is latest
ubuntu => tag is latest


Same thing here, you can get it from the base image name.


Add a line break before the default values.
It makes the code more readable.


this part should be in the APi Methods class


This part to should be in the API methods


Thing is, these shadows made the text visible when there's an image underneath with the same color as the font.


Yes it does.. I noticed that I have to run it iwth linux32 after making this pull request. linux32 build will handle this as expected. So this can be dropped.


why is this called "incomplete" ? Name is confusing...why not just getSampleLists ?


Good option.
You forgot one: should we download the base image if it does not exist?

=> DOWNLOAD_BASE_IMAGE, with default to false.
It means that by default, if the base image does not exist, an error will be thrown.


Should be named `mask_trailing_ones_and_least_significant_zero`.


Seems another file (and in wrong part of config)


struct cr_img* img = open_image(CR_FD_TMP_FILES, O_DUMP);


Minor corrections...


Please, do not format all the classes.
So, bring the indentation back to what it was.


Bring the indentation back to what it was.


This should be in the API methods


seems like an unnecessary return statement


Done


Actually works, it was just that the comment.php file is unfinished/has errors


This commit is being reviewed as a part of review issue #126.


Not a huge fan of string typing here, but obviously without having been in the design discussions I understand that this was probably necessary.


This kind of message is acceptable for debug, but not when you push your code.
Either you remove it, or you update it with a suitable sentence.


Done :smile:


Non-suitable log message.


Perhaps just reapply where text might overlap an image then, that seems only to happen on the small screen in the room you guys are in, but it's just the bottom of the right hand side isnt it?


This commit is being reviewed as a part of review issue #127.


A max age of two years is maybe too much don't you think ?

```
1 year  = 31536000
2 years = 63072000
```


Yes.  Is that what you are seeing?


No, split the base image name.
If it contains a colon, then it has a tag and an image name. Otherwise, it only has an image name. The tag will be "lastest".


instead of passing nil, it would be better to pass a done channel and demo it's usage.
`Print until exhausted done channel is set to 'nil'.` does not say much too.


The USB Core changed too, which was a drastic change, so this minor uless, time and flash consuming feature shouldnt be a big problem.


Not opposed to what you have here, but it is a little murky to read. Would prefer:
```
if (_.isFunction(this.valueSelector) {
   let function = <{ (item: T): any}> this.valueSelector;
   return function(item);
} else {
   let property = <string> this.valueSelector;
   return item[property];
}
```


Indeed.


Just a test!


```java
if( baseImage == null
              && Boolean.parse( targetProperties.get( DOWNLOAD_BASE_IMAGE )) {
      // ....
}
```


What if restored weren't deleted? Would tar overwrite them and remove their changes? Or would tar fail? Or would it silently ignore this and won't overwrite existing file?


Primarily preferred because line 24 is a beast and requires a long look to figure out.


+	struct cr_img *img = open_image(CR_FD_TMP_FILES, O_RSTR);


The tests suggest that's how it works. Then everything's fine, and I guess
that makes sense. Sorry for bothering you about this!

On Fri, Dec 18, 2015 at 3:58 PM, Patrick Cozzi <notifications@github.com>
wrote:

> Yes. Is that what you are seeing?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/e-andersson/cesium/commit/2fd1f32f2150d9e0746ccecee0f81f624915996f#commitcomment-15067251>
> .
>

--

Erik Andersson

Mobile +46 704244916

Email erik.andersson@vricon.com

Vricon Systems AB

SE-581 88 Linköping, SWEDEN

www.vricon.com


What about an `event` package under `bus` with all the events ?


@sjackman Hi Shaun, just trying to get in touch with you to chat a bit about status and plans for this formula.

I'll try to send you a 'regular' email.

Regards,
Rob


No, don't do these functions at cli.py, let's move them to netconfaccess. Also, don't forget to add comments in there too.


Intentionally nothing. To be hones this is first time after several years when I did something in Visual Studio :-) It will be ok when I split it and send pull request on commit which change InfluxDBClient.cs only?


You did change something, namely the commit message. And if you don't remember the issue IDs (or the old issue IDs should get lost for whatever reason) by heart you're having a very hard time following the commit history.

In this case it's only a documentation change, but when travelling I found it very hard to browse the commit history offline when the messages are only referencing issue/PR IDs.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9862](https://teamcity.mesosphere.io/viewLog.html?buildId=95545&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:04:06


ok, so related to my comment above...this method adds the sample_ids to the sample lists. I would call this method something like: addSampleIdsToSampleLists


this and next line round braces for `($xmlJobConfig)` and `($dbJobConfig)` are superfluous aren't they? ;)


see https://github.com/letsencrypt/boulder/pull/1295


Why do we need it? Why didn't you provide a unit test?


I tested with a centos image and it does not work.
I have not checked how this method was implemented in Docker's REST client.
`withRepository` returns a PullImageCmd instance. Your code would be better like...

```java
PullImageCmd cmd  = this.dockerClient.pullImageCmd(imageRegistry)
                              .withRepository(imageRepository)
                              .withTag(imageTag);
```


Could variable "cache" be  java.util.concurrent.ConcurrentHashMap?
If DefaultCamelCatalog.java is mutated by multiple threads, it might not be safe to use HashMap without synchronization.


Debug message to remove.


To update since we now check whether we should download the image or not.


grattis till godkänt


Yes, I think the way you have sent now, makes the default dll to be 64bit only. At this point I am not ready make it that way. Please send only InfluxDBClient.cs, and I will be glad to merge it.


This is really just an ease of use/readability thing to allow them to use a property selector or a select function. We could've used `(item: ITestObj): string => { return item.value; }` for the tests, although either way, the tests should fail if something gets changed here.


Fix the indentation please.


GRADLE_HOME should be pointing to where it's been unzipped


Thanks! sounds good


Shouldn't we change this table name as well?


@edikgat спасибо большое за Code Review. :beers:
Согласен практически со всеми замечаниями.
Буду исправлять =)


Cool, that makes sense. Saves them from having to use a lambda if desired. Just easy for this to fail if the property is renamed or mistyped where the lambda is compile safe...


Here is my comment on this on the issue instead of the commit

https://github.com/sIKE23/Mage-Wars/issues/291#issuecomment-143400550

This is going to be fun cause I was doing most of this over in the V2 code
base.

Here is the commit

https://github.com/sIKE23/Mage-Wars/commit/b8d5cad1e0f483cc81c90f05252427855d4c4611

You can then see what I meant by "On the 1.x side of things if I add
[Defense 8+ 1x No Ranged] it works, note [Defense=8+ 1x No Ranged] does not"

//FC

On Fri, Dec 18, 2015 at 2:22 AM, Ananda <notifications@github.com> wrote:

> Sure. You're trying to fix spiked buckler, right?
>
> I guess this fell off my radar.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sIKE23/Mage-Wars/commit/fd59e6b5d7cb0cb08accee9d940583321f90ec04#commitcomment-15060220>
> .
>


Her en lille kommentar...


ok


I could not test this part as it did not want to download my centos image.
To be honest, I do not understand why it would work.

Either the **exec()** method is blocking, and therefore the waiting time should be constant (e.g. always wait 20 seconds). Or it is not blocking, and I do not see why the waiting time would be related to the duration of the REST invocation. I am fairly skeptical. I will give it another try once my other comments are fixed. ;)


Hi @nachowski ,
did you experienced any kind of problem without adding this proguard rule?


No print. Use `Utils.log( e );` instead.


@olegz Agreed.  I'll update this to remove the test oriented changes to PutJMS.


DevLife


Right


that's gonna break if it goes through different frames. is that an issue?


Lines 48 and 49 have spaces instead of tabs. Not a big deal, but def throws off the indentation in GH...


Couple concerns:

1) Loading Test::More for them seems like overkill, maybe just die if it looks like subtest() is not in the callers namespace, with a helpful message saying Test::More needs to be loaded first?

2) Your string eval pretends to be in the callers package, but does not alter the line number or file. If someone used this and Class::Method::Modifiers was not installed then the require error will report inside an eval and be very confusing.

This would be a good way to make the errors in your string eval sane, the comment is not a true comment, it makes perl think it is in that line and file+extra little note
```perl
eval <<EOT
#line 55 "filename (inside Test::Some)"
use Test::More; use Class::Method::Modifiers; around ...;
EOT
```

3) Loading Class::Method::Modifier into their namespace for them could also potentially cause problems.

I would suggest simplifying this:

```perl
sub import {
    my $class = shift;
    my $caller = caller;
    my $subtest = $caller->can('subtest') or croak "Test::More must be loaded before Test::Some";
    no warnings 'redefine';
    no strict 'refs';
    *{"$caller\::subtest"} = sub { Test::Some::_subtest( \@_, $subtest ) };
}
```

This is shorter, and does nto contaminate their namespace. It also passes in their current subtest subref so that your subtest code can defer to it instead of assuming they just have Test::More's, which means you can wrap subtest from other tools, and support other tools that also wrap subtest.


Where have you found such formatting? Is it ok?


lgtm


@pb00068
Thanks.  That make sense.  If it passes I'll wait to run LTC only after #525 gets merged.


Why not ? :+1: I'll do that

On 18 December 2015 at 16:00, PaulM <notifications@github.com> wrote:

> What about an event package under bus with all the events ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/amasciulli/GmPR-Android/commit/6cb17ba914f3c41498d9de7c484c4de082318b81#commitcomment-15067315>
> .
>


strange indentation (spaces instead of tabs)


You probably didn't mean to leave these in? Likewise on line 590.


yeah sure, the catalog is however a standalone module for tooling providers. As the operations is idempotent it doesnt matter if 2 threads concurrently have a cache miss and race to put to the cache.

The cache is not meant for highly concurrent environements, but for tooling.


:+1:   Approach here is fine and harmless.

minor nitpick, rubocop line length, maybe move to 3-line if block.  Thanks!!


Yes, the app crashes if this rule is not present. I'm using v2.0.1.

    Fatal Exception: java.lang.NullPointerException: Attempt to read from field 'java.lang.String com.usabilla.sdk.ubform.data.FormConfiguration$Data.c' on a null object reference
       at com.usabilla.sdk.ubform.ui.FeedbackFormActivity.com.usabilla.sdk.ubform.data.FormConfiguration$Data.getAppSubmit(SourceFile:11047)
       at com.usabilla.sdk.ubform.ui.FeedbackFormActivity$getFormTask.onPostExecute(SourceFile:1307)
       at android.os.AsyncTask.finish(AsyncTask.java:636)
       at android.os.AsyncTask.access$500(AsyncTask.java:177)
       at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:653)
       at android.os.Handler.dispatchMessage(Handler.java:102)
       at android.os.Looper.loop(Looper.java:145)
       at android.app.ActivityThread.main(ActivityThread.java:6837)
       at java.lang.reflect.Method.invoke(Method.java)
       at java.lang.reflect.Method.invoke(Method.java:372)
       at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1404)
       at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1199)


Still a 'User' typo in the commit message ;-)


The argument lists for the validator and the meta script and the validator script are already different (e.g. the validator has no `--override-warning` or `--jvm-args` options), and this may change further in the future. Developers (other than you and me) will assume that, say, adding an argument `--command` to the validator will not affect the behaviour of the meta script, as they do not expect that the meta script will call it with this argument.


Wifi passwords are not kept in xsce-WAN


Let's find a different way to get to this information and keep this variable ```protected```. Something such as ```getOutgoingFlow(String)``` could work nicely, and will hide the ```Map``` from users.


Hi Jan,

Then seahub should also be removed as it only works with 1.5.  The
current seafile-seahub downloads, builds, and uses Django 1.5, so by
your logic seafile-seahub doesn't belong in the packages feed.

There is no point keeping Django 1.5 out of the packages feed unless
seafile-seahub is removed, because it pulls in Django 1.5 as part of
it's build; the only difference is that for seafile-seahub Django 1.5 is
not a separate package.

Regards,

Daniel

On 18/12/15 07:34 AM, Jan Čermák wrote:
> I understand the motivation here for this version of Django, but 1.5 is
> behind EOL for more than a year and it has multiple unresolved CVEs.
> Either there must be someone who backports fixes for these as patches or
> we should not add such package (i.e. vulnerable software) into the
> distribution at all.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cshore/packages/commit/634e29473bd8e21c9bacec14720221cf3f8a470c#commitcomment-15064144>.
>


As with Django this is pulled in by seafile-seahub through it's
dependency chain and therefore if PIL doesn't belong in packages neither
does seafile-seahub.

Regards,

Daniel

On 18/12/15 07:40 AM, Jan Čermák wrote:
> PIL is currently abandoned (it is replaced by the Pillow fork) and
> contains a major security issue:
> https://www.cvedetails.com/cve/CVE-2014-3007/
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cshore/packages/commit/9b754ae9d47881ccb9b21e364dde3eb39add8c5e#commitcomment-15064228>.
>


I just borrowed a windows laptop, and will test it before merging code to master. :)


najs commit mannen


Couldn't help myself.


This may be just me, but in these cases, I like to invert the logic. This way, you can do ```if (!(root instanceof Process)) continue;``` and then don't have to indent all those lines of code. To me, this looks much simpler to understand.


I see.
Would it be possible to see the proguard file you're using?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9863](https://teamcity.mesosphere.io/viewLog.html?buildId=95551&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:11


I think this change introduce an error:

{:timestamp=>"2015-12-18T15:11:28.905000+0000", :message=>"undefined method `close' for #<Manticore::Client:0x16506b32>", :class=>"NoMethodError", :backtrace=>["/opt/logstash/vendor/bundle/jruby/1.9/gems/elasticsearch-transport-1.0.15/lib/elasticsearch/transport/transport/http/manticore.rb:115:in `__close_connections'", "org/jruby/RubyArray.java:1613:in `each'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/elasticsearch-transport-1.0.15/lib/elasticsearch/transport/transport/http/manticore.rb:115:in `__close_connections'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/elasticsearch-transport-1.0.15/lib/elasticsearch/transport/transport/base.rb:99:in `__rebuild_connections'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/elasticsearch-transport-1.0.15/lib/elasticsearch/transport/transport/base.rb:77:in `reload_connections!'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-elasticsearch-2.2.0-java/lib/logstash/outputs/elasticsearch/http_client.rb:85:in `sniff!'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-elasticsearch-2.2.0-java/lib/logstash/outputs/elasticsearch/http_client.rb:73:in `start_sniffing!'", "org/jruby/ext/thread/Mutex.java:149:in `synchronize'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-elasticsearch-2.2.0-java/lib/logstash/outputs/elasticsearch/http_client.rb:73:in `start_sniffing!'", "org/jruby/RubyKernel.java:1479:in `loop'", "/opt/logstash/vendor/bundle/jruby/1.9/gems/logstash-output-elasticsearch-2.2.0-java/lib/logstash/outputs/elasticsearch/http_client.rb:72:in `start_sniffing!'"], :level=>:error}


Looks good, but the problem (and the solution) is specific to the MSE player. Please, declare maxTimeSeekable() as virtual in MediaPlayerPrivateGStreamer and override it from MediaPlayerPrivateGStreamerMSE, so the changes don't affect the non-MSE player.


OwnPtr has been replaced by std::unique_ptr<PlatformTimeRanges>. Change it, or just avoid the hassle by dropping the intermediate timeRanges variable and just chaining arrows.


The same could be said here.


And here.


And here once more. :-)


teste


Good point.  See commit 405da15.


If this comment was only here for debugging purposes, you should mark it clearly so you don’t forget to take it out before committing and sending a pull request next time.


@gustavo-moreira @allisongreene
I made this addendum code change as well, and would like to include in the pull request. Please review it, thanks! :)


If you use ```assertEquals``` here, you can get rid of the ```if``` altogether - both branches of the condition are identical otherwise.


Should this be set to `false` at any point?


No need to name this, you're not using it anywhere.


Is there any specific reason for using iterators here? Map entries can be used in ```for()``` as well.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24618/testReport/) for this commit**


I think some more comments in the code at this place would be good. At this part of the code the desired_samples are kept in a list only to be used later on as a filter in a loop that iterates over all the samples....and this is related to the current (and slightly odd) way of storing all sample ids and values in csv string in the DB (by the way, please also comment this part of the code, i.e. lines ~260-280 )


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24619/testReport/) for this commit**


Ah, just to double check in the JS side it does:
```
if not changed_model.attribute_is_serializable(key)
        return null
```
But I don' t think this is applicable on the python side?


test com


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24620/testReport/) for this commit**


Added these content changes to the server.


Thank you for the commit. I was having the same problem now it is all good :)


Whats the reason for disabling coverage report?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9864](https://teamcity.mesosphere.io/viewLog.html?buildId=95552&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:02:13


It's not accidental.  These are inside the parentheses, part of the conditional expression.  I lined up the "operand" parts to make it easier to read.  Judging by the conditional around line 1580, this appears to be consistent with the style of the rest of the file.


Круто!
Спасибо


Could you document how you mean for me to test it, say in a TODO comment or here on GitHub?


Put this on /run not /tmp, Evil users can do stuff on /tmp but can not on /run


@jdef Do you mind giving me a hint on how I can idiomatically use `f.asRegisteredMaster.Do(...)` here? This func returns an err, `Do()` returns an err channel and does not accept a `func() err`, only `func()`.

Do I have to build an outer err channel and then selecting over the proc error channel and the outer err channel?


This isn't as suspicious as some other spots. :-)  I left that note in to check that the lines are actually used.  Hopefully with the macros working I can test them now.  So the "check" comment should be removed before the merge.


Regarding "when messages are only referencing issue/PR IDs". I completely agree. That's the worst. Even for really trivial issues too. Makes me think we could just as well switch to a centralized version control system ;-) \</rant\>


Sure, will adapt.


FYI Djblets in seahub pulls in PIL (it's part of the required
dependencies listed in the metadata).

Regards,

Daniel

On 18/12/15 07:40 AM, Jan Čermák wrote:
> PIL is currently abandoned (it is replaced by the Pillow fork) and
> contains a major security issue:
> https://www.cvedetails.com/cve/CVE-2014-3007/
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cshore/packages/commit/9b754ae9d47881ccb9b21e364dde3eb39add8c5e#commitcomment-15064228>.
>


Also, it is far better to take CMDLINE from boot image since we have control over bootloader.


Можешь объяснить, почему в этом примере block2 отображается справа, а block1 - слева?
И почему использовалась опция float:right? Ответ можно прям здесь написать


Is the *value_json.light* correct? The rest have *value.x* or value_json.x


Что-то странное происходит с блоками.
Подскажи, почему 4 и 5 блоки поменялись местами?
И для чего в block3 используется float:left?


Am 17.12.2015 um 13:46 schrieb Colomban Wendling:
>
> I agree with @codebrainz <https://github.com/codebrainz> (as I already
> mentioned earlier).
> Sure, there is a gray area on what's public and private inside
> publicly accessible structures, as we (currently) don't have any way
> to enforce privacy here.
>

We do have FooStructPrivate, and use it in quite a few struct types. Now
there is another way to introduce private fields, and this is quite news
to me and quite awkward if you're used to the FooStructPrivate convention.

> But we always stated that anything undocumented was /not/ part of the
> API and could not be relied upon, so although in practice it was
> possible, we explicitly said we didn't support that.

Yea, only stuff that's documented is officially part of the API. That
doesn't automatically make everything else strictly private, though. We
can't just go and change or remove the so-called "private" members so
because that breaks the ABI even for well-behaving plugins. So these
"private" members are in fact part of the ABI and in practice public. We
should simply document the fact and do not allow such grey areas to
remain grey.

If we really want private fields, that we can change freely, use
FooStructPrivate. But we also have to accept that, documented or not,
all public struct members are part of the ABI and subject to concerns
before changing.


Nice :+1:


That seems a really good move. And something to talk about with responsible to document the attribute in Google >(

Did you test it?


TeamCity Civic Assembly :: Build backend + frontend [Build 113](http://54.229.176.143/tc/viewLog.html?buildId=247&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


I'm afraid not, sorry. Feel free to email me if you'd like to discuss this further (contact details are in my github profile).


isn't this a good pace to use the `Settings` object?

if you're just hackin around and Im being pedantic ignore me :palm_tree:


up to this line it looks like this SQL repeats what is already in other queries. Maybe you can make a "variable" to hold this generic part and then include it here with
```
<include refid="genericPart"/>
```
where genericPart is something like:
```
<sql id="genericPart">
select
        gene.HUGO_GENE_SYMBOL as hugo_gene_symbol,
        gene.ENTREZ_GENE_ID as entrez_gene_id,
....
</sql>
```


Also would you be open to a name change. Maybe something like `fb-dash`. The current name is really close to lodash.


Well, this fix should work without causing any undesirable side-effects, so...


Just remove the check then?


Would you be able to issue a PR with this?


Spelled correctly! :)


The import of `Post` is missing, I suppose because of rebasing on top of one of my commits that removed it.


Reviewed. @adamabeshouse : please take a look.


Missed c27383110.lua, it doesn't use `Auxiliary.AddRitualProc`


I did tested it. It sync every 3hrs.
Documentation lies about this field ;)


this works but we also still have to pass in the actual Document object, since eventually there is this code block:
```
for id, model in to_doc._all_models.items():
            if id in from_references:
                update_model_events = Document._events_to_sync_objects(
                    from_references[id],
                    to_references[id],
                    value_refs
                )
                events.extend(update_model_events)
```
But I note it only seems to be using the id and not the actual model... can this be extracted from `to_json`?


TeamCity Civic Assembly :: Build backend + frontend [Build 113](http://54.229.176.143/tc/viewLog.html?buildId=247&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:04:07


Hmm, does that disables it globally, no?  I think it should be at the end of the next line.


Minor: I guess it would have been better to use an `options` map with `extraAddons` and `extraParameters` as keys instead of an array. Maybe in a future patch?


`!prepareTable` instead of `!prepareTabel`


OK


jasperTemplaet -> "JasperReports template"


Please run `gofmt` on the file. Or place the azure import before the `registry/storage/driver/filesystem`.


:+1: @krocard please review and merge if you're ok.


Besides, I don't know what's the fuzz about. I didn't actually start to document the members, their status is unchanged. I merely documented the *type* of these (as required for gir generation). So at the end of the day things are pretty much the same


You rock.

I think we should go with this ASAP. Other optimizations are possible, but this should be enough by itself to stop killing batteries. Would you make a PR?


consider moving this out of the template, if it's purely rendering you can put it in the layout package


what happened here? I think you used a bad editor...there is no change here other than white space differences...


Hmm, yeah I think you're right.
http://docs.pylint.org/faq.html#is-it-possible-to-locally-disable-a-particular-message

Will move it to the same line.


Hey it looks like the issue was resolved in commit 142c726fd246504cf22549a9f6ef99e042d91026. Thanks!.


yup, seems to be fine now


Remove these


What is this supposed to fix?


Definitely not crazy about taking in a String: it makes it difficult to do things like load a resource from inside a Jar. Most IO APIs will take in a File, Path (but I don't think this is Java 7), and/or InputStream, which I think would be preferable.


are you sure???


Oops. Thanks.


i can't find any `TBL_INVENTORY` constant. My IDE also shows an error


@adamabeshouse : I'm having trouble spotting the difference...maybe you can commit again without the white space changes?


In fact I did it in this instance, but @codebrainz commented to the doc-comments of the type. Member documentation is not strictly necessary for gir, so the below hunk could be removed. It's just that all public struct types must be complete.


LGTM. Those echo commands could be replaced with pure python, but I will leave it as is for now.


God damn it, this was fixed before but I'll fix it again.


The creation of this SmallVector causes too much heap allocation at the creation of the multiple Interpreters, therefore its initial size was reduced from 64 to 4 elements of type SharingMapTy.


Thankyou


why can't the sample_list_id just be used. I don't see the need for this variable.


What is purpose of this?


Few more nitpicks:

- please bump this to the same revision, `docker/distribution` is using in `v.2.2.1`. It should be [97d9593768bbbbd316f9c055dfc5f780933cd7fc](https://github.com/Azure/azure-sdk-for-go/commit/97d9593768bbbbd316f9c055dfc5f780933cd7fc)
- include only the `storage` package, just like the Godeps entry suggests (no `management`, `core`, etc. is necessary)


Is this more correct ? (What validator do you use ?


This happens when you pull from github after having made local changes. You don't have to worry about that. If you want to avoid these merge commits, you can use 'git pull --rebase'.


Rearrange domain files/diretories


@cnocito That would be weird, see the tests. Note that it relies on a fairly nws version of the manticore library, which one do you have?


This will center the whitespace inside a block with no arguments. Previously, the drop target was flush-left, when the intuitive place to expect it would be in the center.


@vmx Well, the README on `master` pointed me towards `newvtree`, so that's what I started with (I wanted to use it with the most recent Apache CouchDB, so I figured I'd start with bleeding-edge GeoCouch). Moreover, that's where I was when I made this comment.

Eventually, after some issues (linking problems I think: I'm not much of an Erlanger) I landed at `couchdb1.3.x`, which was a lot easier to configure.


What's the problem being fixed here ?


yes, the `refs` function defined above works great


Can this one be renamed to e.g. floatingpoint2.h. Problem is at least on Solaris, that there is already a /usr/include/floatingpoint.h which gets usually pulled in via math.h <- <cmath>, however, since '.' aka src/util is in the includes path, the whole thing breaks with more or less strange error messages ...


> That doesn't automatically make everything else strictly private, though. [...]. So these "private" members are in fact part of the ABI and in practice public.

You keep confusing compiler with convention. When we say "public" or "private" we mean "plugins should/shouldn't use this stuff", not "plugins can/can't technically use this stuff". Once you grok the difference, it will become clear. Basically if you're thinking in terms of ABI, you're not getting it :) A better example @b4n eluded to is "private" fields/methods in Python. To make something "private" in a class, you append/prepend an underscore or some other convention. The members are still technically public, but the convention is that if there's an underscore like that, they're private and should not be used outside of the class, and there's no guarantee they won't change.

> I didn't actually start to document the members, their status is unchanged. I merely documented the *type*

You added new types to the "public" API (remember "public" by convention, nothing to do with compiler/ABI).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9865](https://teamcity.mesosphere.io/viewLog.html?buildId=95557&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:08:38


> Spin!

> I'm going to need you to taste that spin in order for me to actually believe your accusation.


* Function `channel/0` renamed to `get_channel/0`


I think it's a problem with the Gemfile, which should have bumped the minimum required version for the manticore gem :(


Close... This line has no effect any more and should probably just be removed : )

The intent was to set the local DrawTile function pointer based on the caller's choice of DrawMode.  Later, DrawTile would be called in any case.

However, the containing function DrawBackgroundOffset itself does not appear to use DrawTile anywhere (there is only DrawClippedTile around line 1661).  This is probably copypasta from DrawOBJS which DOES use DrawTile.


Same as above.


I'm slightly surprised that this hasn't caused circular import problems, but if it works, that's fine!


A break after a return?


ja guet das isch ja im titel, im titel hämmer doch alles gross gschribe?


uncomment to show spreadsheet input (#149)


Great catch, thanks a lot!


Nice site!


It's an example. In the end it's just whatever attribute is in the json. Being more realistic will help out. We could consider  adding a comment above it in yaml with example value that were  parsing


by 4404 I meant 4408


Is it necessary here ? We're only dealing with one transaction here, no need to distinguish it from the second field.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9866](https://teamcity.mesosphere.io/viewLog.html?buildId=95563&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:01:12


this unfortunately dies with an NPE since this whole thing runs in IteratorInterpreter and has no access to an actor backed interpreter.


I think there's a typo here - it should be `@data[:platform]`. This change is giving me an undefined local variable error when I try to use `deliver`.


* Did this so I could work on multiple projects locally without committing them to this project
* May add ability for multiple webroots at some point but wanted to keep things simple for now


辛苦了！前面的问题都完美的解决了！

现在只有 ACGDB 的显示样式稍微需要调整一下：
![nw rnylte__ pgoj9 s8a](https://cloud.githubusercontent.com/assets/1846356/11900639/2449894e-a5e2-11e5-8bfe-0674d14d10fc.png)
这个地方只要有个小角就可以了，角里面斜着显示三个点，现在提示比较重了些
鼠标 hover 上去有个 title 提示在 acgdb 里阅读更多

另外鼠标直接 hover 上去不要变成 pointer，只有在标题/字幕组/图片上变成 pointer

番组列表的日文好像没加：「番組表」


Cleanup is good, on the other hand some of those comments are useful for debugging and future work..


Sorry, I have no idea how to do this in a homebrew package.


Interestingly, this site has the images I created for missing tokens for the old site. This could become our new default.


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=2)


辛苦了~

有一些问题需要处理一下：

除了页数之外的按钮放大之后好像不是垂直居中的
![Uploading U)_$1S6KKE@`)I691S1]FK1.png…]()

![Uploading 6QOS52PF9EMLPQP11C`T~VA.png…]()
在最上的时候底下不要加阴影，右侧的滚动条也让它显示在上面

![Uploading B(B6)5WNC%}GPW1~26_2}FG.png…]()
缩回来之后，让这些按钮的宽度相等

最后，用户和团队的展示样式参考 /week 下的


to correct my previous statement: this is not about the Gemfile or gemspec specifying the wrong version of manticore.
Since the transport is selectable (between manticore, faraday, curb), there is no runtime dependency on these transport gems. Which creates a problem in this scenario where we need to ensure at least manticore version X is used IF you select it as your transporter.
A workaround is to check the gem version when doing a require and abort, but that doesn't fix the dependency resolution at install time..


This was me again. Sorry!


Коммит 10 / 10, ты лучший


@twiecki does that regression include an intercept term by default?  (we'd want to include an intercept IMO)


We might want to rename as coroutines already come in contact with two other Context classes. One with the connection and the other is the ripple Context which contains the coro itself.


Why do you have:
````js
this._cancelled = true;
````

Shouldn't this happen automatically when you call ````cancel()````?


This isn't thread safe and worse sets the global locale which is not usually the right thing to do.

I think you can use:

```
sstr.imbue(std::locale::classic());
```
instead.


TeamCity Civic Assembly :: Build backend + frontend [Build 114](http://54.229.176.143/tc/viewLog.html?buildId=248&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Ok, I agree with jsvd. Latest Manticore version is 0.5.2, the elastic search installer comes with 0.4.4... I yum installed today, something needs to be updated for this fix.


I'll try this and the other changes soon. You already explained why using dates were bad, could you remind me again ? Aren't date anchors a bit more robust than tindex-based ones, eg if the file is edited a date link will still take you to roughly the right place ?


两个都是加了nodein~,add函数里面，是要在head的前面，再加一个节点吧？create函数里面的，是要释放链表吗？


roger that

https://github.com/MonetDB/eanthony/commit/dcaacc0dc842ee30fdd491fc54616b7cda97aac1


Where is the xsd part?, anyone want to do it? or i can do it by myself?


I think we should rename community-minimal --> minimal as you suggested.
I started a devel branch for 0.10.x, it has it renamed already.
If me rename in master, a merge should be possible, reducing merge conflicts to shared pkglists eventually


Removed unneeded thing


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=3)


You don't need to restore stub if you want to change returns behaviour. I believe this should be enough.
`streams.has.returns(true);`


I fetch the PR heads from github automatically (using refspec `+refs/pull/*/head:refs/remotes/pr/*`), so there is an easy way to keep the code accessible offline at least. I don't know if one can do something similar with the comments. (However, I use it mainly to inspect/test/merge PRs without the github web UI, not to dig through history.)

> when messages are only referencing issue/PR IDs

I assume you refer to what github creates when you push the merge button? I do find that badly chosen by github and I edit the message to contain a title at least. I assume we can't change that default, except by abandoning github.


Nit no need for space here. A space before Note makes it more clean.


Rest looks good.


TeamCity Civic Assembly :: Build backend + frontend [Build 114](http://54.229.176.143/tc/viewLog.html?buildId=248&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:04:17


Ja uf dütsch ned oder? Das isch doch en englischi konvention?


`const auto` :)


Committed
https://github.com/igniterealtime/Smack/commit/46f01109499ceca81a28113c0384a893cdc632ca


Perhaps rename `NewStorage` into `SmokeTestStorage` ?


Thanks for the edits @aeligature - I reverted because it was committed directly to master. Can you submit a PR instead?


`const auto` ?


@cnocito We'll have a look at tightening up the versions here, thanks for the report!!


Just going to take a look at this... My QEMU builder doesnt boot up, I believe it is the KS file, but I will give your file a try ;)


Second PR created.
https://github.com/igniterealtime/Smack/pull/62

Committed.
https://github.com/igniterealtime/Smack/commit/feff0815472c05ad4966ef24253b0717e4059c58


Also, let's develop a habit of accepting a `const CurrentStorage<T>` for immutable "transactions"?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24623/testReport/) for this commit**


-> #89


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24624/testReport/) for this commit**


ok I agree, but I do not think we should be forcing users via convention into supplying callbacks for each publish() just so they can process an error that is local.

The original code would throw an exception, should that be the case again unless a callback is provided?


right, the basic structure of the json is that when there's a model value we just have the "ref" which is like `{ 'id' : id, 'type': 'typename' }`, and then we have the `references` array which contains actual attributes for all models which are referenced. this way if we refer to a model more than once we still only serialize its attributes once.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24625/testReport/) for this commit**


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 37](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=579&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


com.badlogic.gdx.utils.Queue should be added to reflection cache as this commit broke Json parsing on GWT backend


I think that requires another example. Since it's a recursive operation it made sense to not have a done channel. Let me add another set of code for done channel.


... can ignore the exception.


Looks like a typo there tell me when you fixed this


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 37](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=579&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:33


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 38](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=580&buildTypeId=Xbim_XbimWebUi_XbimWebUi) is now running


... not returning the value.


TeamCity Xbim :: Xbim Web UI :: Xbim Web UI [Build 38](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=580&buildTypeId=Xbim_XbimWebUi_XbimWebUi) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:07


Karmi, you are welcome!


Had to split this into two export instead of default exporting this function. Any better ideas? I find this unconsistent.


I would remove the comment for sure, since it's wrong for python. We can raise RuntimeError, but someone will almost certainly encounter it - they just have to `add_root(something)` (or do that indirectly via `figure()` or `vplot()`), and then `push_notebook()`, and they will hit this exception. To remove the check we'd have to implement generating those RootAdded and RootRemoved events.


Is this section necessary?


AFAIR we discussed introducing another function which casts storage to const reference.


though maybe you do need it in order to implement collecting references


`this._cancelled = true` clears the interval in the command.

`cancel()` is called when the command is cancelled to clean up but it does not set any vars or make any assumptions about the command.


:+1: . Someday some kind of `checkstyle` or `lint` or so in the CI testing of proposed change would be neat to reduce whitespace/style thrash.  (Cf. Google Style for [HTML/CSS](http://google.github.io/styleguide/htmlcssguide.xml) , [JavaScript](http://google.github.io/styleguide/javascriptguide.xml), [AngularJS](http://google.github.io/styleguide/angularjs-google-style.html), ...).


Time for waiting should be added


Just in lambda / functor definitions, I meant.


I am hacking, but also this happens before `Settings` has been initialised.


Hi Raphael,

after this commit I am unfortunately unable to compile.
I get the message:
In MetSelectors.cc:18:25: error: 'm_puppiMet' is not a member of HttTypes::event_type

I suspect event_type has to be replaced, maybe by product_type.
Is anyone else having this issue?

Cheers,
Gregor


An `@Ignore` annotation would probably be cleaner and would show up as an ignored test in the test output


不是，是为了让后面的结点放在链表后面，比如第一次插入a 下次插入b是在a后面。以前都是插在第一个前面，就是b a。，这么做是为了让链表中的顺序和文件中一致。create中是为了让以后再次用的时候nodein是null，不然就没法让他指向头结点了


This totally requires a comment, along the lines of `"The exception is captured with `std::current_exception()` below.


Yeah - it was on my list to go research how to get rid of that silly "~vivid" in the name ;-). OK let me test out that above and submit a new commit if I get something that works. Thanks for looking into this!

BTW yesterday did apt-get install nmve-utils on a ppc64el machine and it worked ;-)!


I think it may be bogus on the JS side because if the attribute isn't serializable how is it in the serialized json?

There are non-serializable props on the python side (notably foo_units) but we don't put them in the JSON so I don't think you'd have to worry about it.


HipChat ;-)


@vcunat: I don't remember exactly when or who did that, and it was unnecessary of me to have that rant. (It was not directed at you.)


Maybe:
`NewStorageDefinition` -> `TestStorage`
`NewStorage` -> `Storage`?


Is this `<T>` necessary, here and on line 41?


Yes, it does.


Why not?


Is there Maximize necessary?


it is "more" valid as hamlet will add </script> tags, maybe a bug in hamlet?

Using w3 validator since 1998 (or whenever that launched)


Because we're checking `_.isUndefined(options)` in the controller


you got all of the unknown node colors I have found so far, plus some!


There is no need in multiple ids anymore.


怪不得，之前执行删除的时候，总是把要删除的那个节点的信息直接放在了第一个位置上！😂
thank you!


Oh, makes sense, thanks.


It's just the `<a .small` in the text won't be compiled into the expected `<a class="small"`


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=5)


Entrez_Gene_Id is a valid column to have in the file. We don't have to add it in/fix the file but it should be validated if it exists. The original purpose of this script was different, and it only generated "fixed" files if the user specified they wanted them.


Doh! Good catch.


Sorry, I couldn't resist to use `value_json.light` because the unit of measurement is/was `ca`.

In the description of the variables is the link to the templating docs available. I think that if a reader is unsure about the usage of the template she/he will visit the docs anyway.


I've decided I agree with you and removed Django 1.5 and dependants from the PR and additionally filed a PR here and on packages-abonded to move seafile to abandoned since it has Django 1.5 dependency as well as, through old Djblets, a dependency on PIL.


My day-job is in ruby on rails, we are super strict about naming conventions like using the same names througout the app. They make live more simple and code more readable.


I think that's reasonable for backwards compatibility.  (I don't think that would be expected behaviour from the average NodeJS library.)


No, the defer line should not be here for a different reason:
> A deferred function's arguments are evaluated when the defer statement is evaluated.

http://play.golang.org/p/Fr03lVfPRw


if icalcolor is not set (this should be the case for standard event), this seems to overwrite $color with empty.
Why not adding a if (! empty($event->icalcolor))  before this line ?


This will prevent any user from deleting a project if there are any datasets not owned by the user.


Hmm. Clang says
`warning: 'const' qualifier on reference type 'CurrentStorage<Storage>' (aka
      'transactional_storage_test::CURRENT_STORAGE_FIELDS_TestStorage<current::storage::DeclareFields> &') has no effect`


Collaborator:
A review for this commit was created. [Link to review](http://127.0.0.1:8080/ui#review:id=6)


@yegor256 why did you change this line?
it was ```  list = new MediaTypes("*/*");``` before


Hey @alexanderdean, I've squashed that into https://github.com/ninjabear/snowplow/commit/1141c461b34dd537139f2c8fa3dfcc810525c15d


What does this mean? It's copy pasted in three places :p


It is not clear the automatic test is not ready or the SUT's functionality is not ready.


spec_helper can go


Hmm. Will probably need to introduce a dedicated type for read-only transactions then.


@osahyoun can you think of a way to get an `ActiveRecord::Relation` with 3 objects without making them in the db


right you are


well, there's the git log for that. I've read a good article on the topic of checking in commented code and in a nutshell: cleaner source is easier to read and less error-prone.


Without it test will exit with exception. Is it ok?


Will fix in PT-2236 Pedigree buttons PR.


"a weapon mode of specified." ?


Cool - keep grinding on this.

-tom

> On Dec 18, 2015, at 11:06 AM, Chris Bullers <notifications@github.com> wrote:
>
> Just going to take a look at this... My QEMU builder doesnt boot up, I believe it is the KS file, but I will give your file a try ;)
>
> —
> Reply to this email directly or view it on GitHub.
>


I think Ex or Ext sounds better than "2" as in extended version. :/


It doesn't `ASSERT_TRUE(false)` now, why would it exit with an exception?


Some thoughts:

+ A linear increase seems alot more sane than previous exponential proposals
- It should be noted that if SW is implemented, any blocksize would be the equivalent of 2x-4x in practice (as far as bandwidth/storage/validation costs are concerned). Given this fact, the step of 1MB per year may seem too aggressive, ie at trigger point, blocksize could effectively be 8mb in worst case.
-An indefinite increase could be fatal to bitcoin in the future if it turns out that offchain solutions/other scaling solutions/etc.. take off and become the primary means transacting, resulting in non-full blocks, which would effectively kill the fee market and in turn the security of the network.

Personally i would prefer if the step size was reduced by 4x with the assumption that SW is going to be merged in.


It's better to use [`urlparse.urljoin()`](https://docs.python.org/2/library/urlparse.html#urlparse.urljoin) to construct URLs.


btw game is not starting for me with this match the crashes with no logs.


Export plus export default should work, we use it most of the time. This is broken in Babel 6, but we are still on 5.


http://www.jetbrains.com/idea/
试试这个


What you need to do is flatten this commit with the previous one you made, because instead of uploading a new version of the previous change, you now have two commits.

You can do this locally by doing:

git reset HEAD^
git add tinyplay.c
git commit --amend

Then re-upload.


date anchors are not unique, not a problem as the entries are well-sorted but it's not valid html. What if you edit the date of an entry?

I have no problem with those ids changing over edits, that is the nature of the ledger file format if you don't add GUIDs. Which might be something for another issue..


No, `module[key]` will be `undefined` if we have never seen this before (meaning we are at the top of the stack - the first transform to see a given module), since we immediately set it to `true` and never change it `!modue[key]` tells us if we are the "entry" transform (the top of the stack, where the transform should be applied before calling the final `._compile`


Fixed an issue where interrupts wouldn't show up when debugging.


Change day to month (not date). Is this function is common for couple of the platforms? If yes looks like it should be placed in common files and not duplicated.


fghgfh


I mean, if something goes wrong and some incorrect exception type is propagated.


Its private though


It would be beautiful if you could not r/w to the DB. It'll keep things a lot faster for us:

```ruby
allow(Campaign).to receive(:all){ [
  build(:campaign)
]}
```


@@ -0,0 +1,17 @@
# Auto detect text files and perform LF normalization
* text=auto

# Custom for Visual Studio
*.cs     diff=csharp

# Standard to msysgit
*.doc	 diff=astextplain
*.DOC	 diff=astextplain
*.docx diff=astextplain
*.DOCX diff=astextplain
*.dot  diff=astextplain
*.DOT  diff=astextplain
*.pdf  diff=astextplain
*.PDF	 diff=astextplain
*.rtf	 diff=astextplain
*.RTF	 diff=astextplain


This thing needs a unit test


Is de controller class bedoelt als 'interface' voor andere controllers?


Thanks, Daniel, that is probably a better solution. Having insecure and deprecated software in the main packages feed just to support one specific piece of software does not seem to be right. Alternatively, you can backport some of the CVE patches from other distros that have the same versions of the problematic Python packages in their LTS repositories.


Sure, but in production code these lines do look redundant.
IIRC, there's a flag to `gtest` to propagate exceptions (not catch them on per-test) level, so seeing which one has leaked is relatively straightforward with `gdb`.


yeah I agree. this is nice, but the only problem is that it returns an array rather than an `ActiveRecord::Relation`. You think that's fine?


There isn't a `campaign` ivar for `index`


get rekt fag


thank


shit you're right, that's supposed to be `campaigns`


I'm fine with the rename.


I think this could probably be better. `__filename` protects against multiple non-deduped copies of `append-transform` being used. I don't know that `random()` is necessary. I could just increment an integer with every call (if you install more than `Number.MAX_VALUE` require extensions your system is not going to accomplish much.

I'm not sure why I chose random. Maybe to protect against require cache deletions? Seems unlikely.


@base32 i think the log path can be relative as we have a `logs` directory within the source.


this could probably be merged as soon as #147 is done


I think so. I'd concern myself with testing messages the view is sending. It doesn't care or know anything about `ActiveRecord::Relation`.


This is the List fragment class not the detail fragment


first it here


Nice! I hope you submit a pull request for this. The other thing that would be nice is to use Pygments built-in styles: http://pygments.org/docs/styles/


Understandable.

I've got a counterfeit rrd glcd on order, and a spare lpc1769 xpresso in a box somewhere, so I might be able to look into this more thoroughly in a week or two.


@JMitnik Wat denk je om de Interest een naam en een parent mee te geven. De eerste Interest:
$root = new Interest('root', null);
$sport = new Interest('sport', $root);
$theater = new Interest('theater', $root);

$i1 = new Interest('basketbal', $sport);
$i2 = new Interest('Voetbal', $sport);
$i3 = new Interest('Volleybal', $sport);

Dan heeft de Interest een lijst met Interest en een boven liggende parent


Nope, removed (in `OptionalResult` as well).


Please, provide a test for it.


Actually, we don't need a test here. Sorry. It's just a demo.


How do I find out what group the neutron is in before knowing what cell it's in? The group depends on chi, which depends on the material of the cell.


These two strings can be merged :)


Ja, klopt. Dus eigenlijk de vraag waarom geen interface? (luiheid, misschien).


This broke `./configure` with no arguments (it doesn't detect jack or pulse), and also `./configure --without-jack` doesn't find pulse. Looking at the other code I think the test should be `[[ "x$with_jack" != "xno" ] || [ "x$with_pulseaudio" != "xno" ]]`.

I still haven't figured out which of `aclocal`/`autoconf`/`automake` rebuilds the damn configure script :P


Looks like the the comment about temporary decision is needed.


I try to avoid introducing translations to admin-only interfaces, since this adds extra overhead to our translators.


This is a brand new provider so you're not really extending it. I'd just remove this line.


esto es nuevo


I like that. But also, the haskell world has a strong tradition of using less noisy single-letter names (chosen by convention) when there's no ambiguity and the area of scope is small. t is used for transactions elsewhere in hledger..

As an alternative, we could rename TransactionsReportItem's parts: (t, tinacct, ...) or something.

I'll go with what you decide for this code.


Dit stukje code is een 'input' die als waarde een return waarde van stukje php code ontvangt. Als de variable person een waarde heeft, gebruikt hij de methode van de person object 'getEmail()'.

Waar komt die $person vandaan? Wordt dit stukje tekst in een controller opgeroepen, waar de variable is gedefinieerd?


Yes, I for sure will. I will just add an additional optional parameter to take a style input (like how bg works now). I didn't PR because this code will break non-256 color terminals (-- line 92) which I was planning on fixing.

Thanks for the great tool, been of immense help in my work on [Zim](https://github.com/Eriner/zim)!

I should have a PR ready around Monday, as I'm a bit busy this weekend. Thanks again!


done


approved removal of require 'pp'.  Its not needed


:+1: Much better!


I've forgot to change local git user. @Mochomoch :)


Hoe vind de controller de locatie van list.html.php?


updated readme


Alright @hackdna Thank you, I'll check that out.


FileSystemElement is playrole of 'Visitable'. Your Visitable interface is Visitor and you don't need deferent implementation of it - just one ( Your current class DirictoryVisitable)


TBH I've decided against using seafile myself and that was my motivation
for 1.5.

I've got other python-based packages in the works that are better
maintained upstream, so I'll still do the original PR less the
deprecated packages.

For sync I'm looking at syncthing (though that depends on whether my
patch to add (optional) gccgo support to the openwrt toolchain gets
accepted).  I'm hoping it does because syncthing works well where I have
used it; I got interested in seafile because it was in the packages feed
already, but even without the django thing I had become disappointed by
the state of seafile.

It was really kind of a squirrelly package to begin with (esp. the whole
business of not doing proper packages for it's dependencies and doing a
whole set of downloads / easy_installs as part of the build of seahub.
It also was never properly cross-compiling (seafile-server for instance
actually has native code that was getting compiled for host arch).

Regards,

Daniel

On 18/12/15 11:25 AM, Jan Čermák wrote:
> Thanks, Daniel, that is probably a better solution. Having insecure and
> deprecated software in the main packages feed just to support one
> specific piece of software does not seem to be right. Alternatively, you
> can backport some of the CVE patches from other distros that have the
> same versions of the problematic Python packages in their LTS repositories.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cshore/packages/commit/634e29473bd8e21c9bacec14720221cf3f8a470c#commitcomment-15069543>.
>


Wat houdt de ```@return``` en ```@param```? Waarom gebruikt je dit?


Надо убрать пробелы в конце строки.


Нужен ли этот коммит в мастере? Мы ведь по-любому будем новый whatsnew делать.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24627/testReport/) for this commit**


I'm not sure I follow.  Do you mean replacing ```alert-error``` with ```.alert-info```?


There is still an issue remaining, I am just preparing a PR.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24628/testReport/) for this commit**


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24629/testReport/) for this commit**


Don't prefix user password with static key, please. bcrypt truncates input at 72 chars (see https://3v4l.org/UquGg), and by prefixing user password with 56 static string you effectively limit the length of the password to 16 chars only.

I'd recommend changing the line to just

```
return password_hash($passwd, PASSWORD_BCRYPT);
```


Me too, but I still have a feeling comments are sometimes more practical. A comment somewhere back in the history is much less discoverable. But you're working on this code, so I'll go with your call.


Can you file an issue with more details?


@azturner ok, ooops.  Thanks for fixing that up :)


`BCryptSHA256` is not a correct name here. There's no SHA256 involved. I'd recommend changing it to just `bcrypt`.


Is it really needed to copy this Event? During the copy we can miss some properties for example in this case we don't copy Documentation for BoundaryEvents (Maybe BoundaryEvents not support Documentations that's why I not fixed it here)


это в via_set_reg_vT2CH должно делаться, по идее


Ну пока что в любом случае надо скрыть whatsnew же


Можно и вообще удалить строку, это просто черипик.


I tried to do the same. This was what I came up with:
https://github.com/epond/scala-sketchpad/commit/82909af279ce02de4fd28dea013a9adc6c571ba5


LGTM :)


Don't you have to add this module in ``requirements.txt``?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9868](https://teamcity.mesosphere.io/viewLog.html?buildId=95574&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:03:58


Looks like the locator should has name just item[0-x].deliveryAdress.
The same is true for locator item[0-x].classifier.


see 0f66aa6


Goed idee, mogelijk zou de gebruiker dan op die 'categorie' kunnen drukken, en andere interests onder die categorie kunnen vinden. Het lijkt me om dat te kunnen doen door te $category te specificeren als Object type Interest in de __construct()functie. Dus zo ongeveer:

```
public function __construct($name String, Interest $category = NULL){}

```

Reden waarom ik bij de constructor een tweede parameter een default waarde meegeef, is omdat het misschien zo is dat een interesse zoals sport geen 'parent' heeft. Mogelijk leeglaten dan, of een ander idee?


Oh you're right, they should have a alphabetic prefix to be valid.

Either way these links will break when entries are changed. When they don't change, the tindex link is more precise. Ok, I agree with you. And yes, permanent unique IDs will be better (though, more ugly).


Another problem here: beEntry can't to be instance of ErrorEventDefinition at all. (We need to extract EventDefinitions from beEntry).


Thanks for the kind words. I understand business, so no rush on the PR.

As for set style I was thinking along the lines of https://gist.github.com/rocky/bdfb17319ff9aee8f32d


Also: is there any specific reason for using iterators here? Map entries can be used in for() as well.


Разве бит прерывания не должен сброситься?


Yes it's needed. nice catch yes documentation does seem missing. feel free to add


Bedoel je hiermee, waarom hebben we eerder geen interface gebruikt, of waarom zouden we geen interface gebruiken?


Looks like the same xpath can be used for the items[0].additionalClassifications[0].id and for items[0].additionalClassifications[0].description


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9870](https://teamcity.mesosphere.io/viewLog.html?buildId=95577&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 206 Build time: 00:03:45


Can we make this a private static member instead?


I think the way it is now is fine, prevents some extra casting later on.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9869](https://teamcity.mesosphere.io/viewLog.html?buildId=95576&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:08:24


interesting: i commented on a line that wasn't part of the diff, and apparently github displays that as a comment on the entire commit. i suppose that commenting on something that isn't the diff is a good indicator that the comment is out of scope, so nevermind.


Who uses the return value? Anyway it's better to use SS_* constants for return code, like SS_STOP.


wtf xdxd