お！　そうそう。
いいね！

でもviewは作らないとだめだから...

     g.test_framework  nil #to skip test framework
      g.assets  false
      g.helper false
      g.stylesheets false

こんな感じかな


I've added your changes (641da48). Thanks.


Oh, and by the way: the game runs fine on the GeForce 9600 GT now! It seems there was a problem with the mvn clean install last time when I said the 9600 still had garbage rendering after the update.


well, no, actually it's up to the server implementation, it doesn't handle NUL termination in this case...


:+1: just noticed it.


test ?


A  subsequent pull request (for spills and groups) would make this easier to integrate.  If you think it is something we should do please open a separate jira.


Not sure why we've done this? Is it just to distinguish the templates? It means my IDE is unable to recognise the contents of the files as HTML and I lose all the HTML editing goodness it possesses.
In Matt C's version the templates have the suffix swig.html does that give us the best of every world - would like to adopt that, though currently I can't get it to work. Can I persist?


This is not the file you want to update. `test/end-to-end/core.sh` is. I'm not sure why we keep this old file, though.


Yes, it's just to see if it works without it xD. It's genetic debugging.


well, true... I'll change it wherever appropriate... thanks for catching this one :)


Include bool is_flash_official_build (void) function into pmloglib


Continued working on loading in the Rdat file I created. I can now load in all the variables exposed and set them to a parameter and trace object. The zero argument constructor also works now. Some changes had to  be made to the plotting functions because they assumed some global variables such as numMixtures. I now get those from the size of the traces that concern them.

Categories must be exposed in some manner of speaking. The expectedSphi trace depends on it. However, this is not a stored variable, but one created on the fly. Exposing the entire class is proving unnecessary and more complex. My current solution is to just store the values in vectors of vectors and re-instate it that way. Following this, most of the plots should run completely. I will have to create an actual function for all the things I am currently doing with the loading, but otherwise I should be able to replicate results (graph wise) soon.


TeamCity Civic Assembly :: Build backend + frontend [Build 77](http://54.229.176.143/tc/viewLog.html?buildId=173&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 76 (76 new), passed: 60, ignored: 4 Build time: 00:10:30
### Failed tests
```
Organization tests: Check that admin can change organization image: <no details avaliable>

Organization tests: Check that admin can cancel change organization image: <no details avaliable>

Organization tests: Should not delete organization if cancel pressed: <no details avaliable>

Organization tests: Should delete organization: <no details avaliable>

Organization category tests: Should navigate to Organization Categories page: <no details avaliable>

Organization category tests: Should not create new organization category if cancelled: <no details avaliable>

Organization category tests: Should add new organization category: <no details avaliable>

Organization category tests: Should not change organization category: <no details avaliable>

Organization category tests: Should change organization category: <no details avaliable>

Organization category tests: Should not delete organization category if cancel pressed: <no details avaliable>

Organization category tests: Should delete organization category: <no details avaliable>

##### there are 66 more failed tests, see build details
```


There are two places where penalising sharp corners could still be done: in the nearest-neighbour search or in the randomised insertion's penalty.

In the nearest neighbour search, it is only allowed to find adjacent where both endpoints are near to the other's end points. The old algorithm had a nearest neighbour search where only one endpoint needs to be close. In the old algorithm, the following case was possible:

        /  /
       /  /

     /
    /

Starting from above left going down, there are two possible choices: Go further down or go back up with the adjacent line to the right. In that case going further down would be chosen, since it had a less sharp corner. In the new case, the line further down wouldn't get considered since one of the endpoints is not nearby. Actually, only lines that are exactly reversed alongside can get chosen, so the angle of the corner should always be more or less the same. Penalising sharp corners then only increases computation time.

The other possible place to penalise sharp corners is between clusters, by adding it to the cost of inserting a cluster in the path. But by design, a cluster should group a separate segment of the shape, resulting in travel moves between clusters that are often deformed by combing. There are cases when it would matter: when three or more endpoints of clusters are near to each other and the first line of one cluster is in the direction of travel of the last line of the second cluster and the first line of the third cluster is not. Or when combing is disabled. But I thought the use case is too narrow to warrant communicating to TSP what the outgoing and incoming direction of travel is for each orientation of each cluster.


Not junk. You merged something, but didn't resolve conflicts. How are you using git? Command-line? Eclipse plug-in? Github application?


I've done this for the exact reason you are saying... I am not sure which editor you are using but most editors have an extension for supporting swig syntax highlighting... The reason for doing this is so that swig files get syntax highlighting.

Can you see if there is an extension for your editor? I use Sublime, it has this, as does Coda... What are you using?


On hashes, I'm not sure this is ok (overflow).


This should be a &reference,right? Now you're modifying copies


I'll remove this function, since it is no longer used.


yep, true, like discussed with @edersondisouza , I'll change it wherever appropriate... thank you.


1) Update metadata.xml and specify parseonly IUSE flag. See comment above for description
2) Rebuild manifest


Shouldn't this be:
```scala
derivedSelect(prefix.EtaExpandCore(this.prefix.typeConstructor.typeParams))
```
Otherwise we lose the `#Apply`, and `i966.scala` is typed after frontend as:
```scala
package <empty> {
  final lazy module val Test: Test$ = new Test$()
  final module class Test$() extends Object() { this: Test.type =>
    def foo[M <: [X0] -> ]: M[Int] = ???
    val x: ([X0] -> Nothing)[Int] = Test.foo[Nothing]
  }
}
```
After adding back the `derivedSelect`, the type of `x` is `Nothing` as expected:
```scala
package <empty> {
  final lazy module val Test: Test$ = new Test$()
  final module class Test$() extends Object() { this: Test.type =>
    def foo[M <: [X0] -> ]: M[Int] = ???
    val x: Nothing = Test.foo[Nothing]
  }
}
```


Make ``` ReadMe.md ``` file or type summary of your projects.
That will help to understand another developer your projects.


yep, true. thanks.


Okay, but how is this any different from https://github.com/ceph/ceph/blob/master/src/include/encoding.h#L91-L108?  I don't understand what the purpose of encode_packed() is.. it looks like it just makes the code more convoluted without any performance gain (and probably compiles down to the same machine code)


absolutely, have being using that locally now... thanks.


@digitaltoad it looks like no, there's no such config


Thanks.
Haven't looked into large number of requests but IP or URL requests shouldn't make that much of a difference.


I use IntelliJ- extension doesn't exist :(


Hey, would you mind to submit a pull request with this feature? It would be great if you could contribute to this project


1) Please recheck nyx-lib SHA
2) If SHA is wrong, please, regenerate manifest. Recheck, that manifest contain checksum for EBUILD


Are you planning on using the torrent hashes for the files as well


TeamCity Jarvis Framework :: CI-GitFlow [Build 71](http://build.prxm.it:8811/viewLog.html?buildId=5166&buildTypeId=CqrsFramework_CiGitFlow) is now running


I am ok within this change


is really send 2x height ?


Should be protected.


Thanks,
I had forgotten a little add+commit !
It should be working now.
Olivier

________________________________
De : sicotfre [notifications@github.com]
Envoyé : vendredi 11 décembre 2015 13:52
À : olivierhagolle/Sentinel-download
Cc : Hagolle Olivier
Objet : Re: [Sentinel-download] S2_download transformed into Sentinel download, thanks to -s option (7c84e7c)

Hi,
thanks for this nice script!
just a quick comment: the python script does not seem to have any -s option, only the README.md file changed in this commit.
thanks!

—
Reply to this email directly or view it on GitHub<https://github.com/olivierhagolle/Sentinel-download/commit/7c84e7c13900102036b71e2d52beae3639f8654d#commitcomment-14924203>.


```Config conf = req.require(Config.class)``` ;)


TeamCity Civic Assembly :: Build backend + frontend [Build 78](http://54.229.176.143/tc/viewLog.html?buildId=175&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Should be able to get it to recognise .swig as an html file though I will solve it that way.


I'm scared by the global var usage here. I think I'd rather see that nasty warning than using this approach. Is somebody complaining specifically about this warning?


If you are interested, I was using this link to push the changes: http://kbroman.org/github_tutorial/pages/fork.html


WebStorm supports text mate bundles… Looks identical to IntelliJ so maybe it has support for Textmate bundles also…?

Kind Regards

Tom Lynch

> On 11 Dec 2015, at 13:44, mattPress <notifications@github.com> wrote:
>
> Should be able to get it to recognise .swig as an html file though I will solve it that way.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/southlondonmakerspace/membership-system/commit/5d0784bda6ad2bd0dbd610e3fd914fa9b31fd2d9#commitcomment-14925196>.
>


I finally fixed this on the latest release.
The composer.lock file has been removed.


забыл сохранить в UTF-8?


update


add packed_encode and packed_decode because of the issue mentioned
at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36566. So I should use (char *). I think this is the simplest way.
What do you think?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9108](https://teamcity.mesosphere.io/viewLog.html?buildId=90955&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:11:29


Heh. In this regard I found it hard to split up into atomic changes. Would this be per TODO, per file, per module? In any case the reviews would quickly spam the commit logs. You might argue that my direct code changes should have separate commits but I consider that too bold as they have not been tested in any way - let alone parsed by a PHP runtime.

In general I do not think the code review comments should not be a part of the codebase but we have had trouble finding a better approach for newly developed modules where there are no pull requests.

As I see it this will become easier with the consolidated repo as new modules can be merged into the codebase via pull requests using the same model as any other change.

Here I would have been happy if @martinb14 had commited changes to the source codebase making my comments obsolete.


okay.. maybe later.


Get this abomination out of my repo... :)


Dw


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.1.12](http://build.prxm.it:8811/viewLog.html?buildId=5166&buildTypeId=CqrsFramework_CiGitFlow) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 137 Build time: 00:04:06
### Failed tests
```
Jarvis.Framework.Tests.dll: Jarvis.Framework.Tests.ProjectionEngineTests.V2.ProjectionEnginePriorityTests.verify_priority_is_maintained: <no details avaliable>

```


TeamCity Jarvis Framework :: CI-GitFlow [Build 72](http://build.prxm.it:8811/viewLog.html?buildId=5167&buildTypeId=CqrsFramework_CiGitFlow) is now running


Ultimately we will have a different alerting rule syntax where users define all these fields. Until we have that change in the alerting rule definition, we should keep what we have.


URL name is wrong. Adding toggle, so I'll fix at the same time.


That simple!


http://www.devblogi.pl/2010/03/dlaczego-moje-optymalizacje-nie.html

W dniu 2015-12-11 o 14:17, radluki pisze:
>
> sum(Vector==0);
>
> % nie byłoby prościej i szybciej?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kalelek/MMWD/commit/8a8c350572c1864c5e4a0926497e1f1878f8ceb1#commitcomment-14924648>.
>


I only meant the `value` field. The rest we need to keep right now.


These tests weren't deleted until commit bc3ec82 later on, when the algorithm was deleted


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.2.0-unstable.5+5](http://build.prxm.it:8811/viewLog.html?buildId=5167&buildTypeId=CqrsFramework_CiGitFlow) outcome was **FAILURE**
Summary: Tests passed: 138; exit code 1 Build time: 00:03:16


Do we need iterationCount anymore?


Ok, let me know if you want to do it. On the one hand, that will make git history harder to read for a while, on the other hand, that might be more future-proof. Let me know!


for system administrators 'with one goal:` ...
or:
or application whose goal is to make the life easier for sysadmins.


That looks promising. For now have got it to parse .swig files as .html so I am happy with this change.


a simple shell application rather than.

What exactly is 'this' in this context?


I can't find such file nor variable. Can't we use that value if it exists?


Cool

Kind Regards

Tom Lynch

> On 11 Dec 2015, at 13:52, mattPress <notifications@github.com> wrote:
>
> That looks promising. For now have got it to parse .swig files as .html so I am happy with this change.
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/southlondonmakerspace/membership-system/commit/5d0784bda6ad2bd0dbd610e3fd914fa9b31fd2d9#commitcomment-14925351>.
>


Yeah, it'll be awesome if we can get these to be tracked automatically somehow...


Mh, but in an alert I want to see what the value based on which was alerted. Sure, the GeneratorURL shows me something better, but for quick overview I find this useful.


woudl this make it work on lollipop secondary sd card?


I don't like this sentence. maybe:
Rather than using dedicated library APIs embedded into your pmemobj application.


consists


This is bad design.

This method should return a Project, and only a Project. If you need the groups for a project, then write a different method and make two calls.


TeamCity Civic Assembly :: Build backend + frontend [Build 78](http://54.229.176.143/tc/viewLog.html?buildId=175&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests failed: 76, passed: 60, ignored: 4 Build time: 00:10:29
### Failed tests
```
Organization tests: Check that admin can change organization image: <no details avaliable>

Organization tests: Check that admin can cancel change organization image: <no details avaliable>

Organization tests: Should not delete organization if cancel pressed: <no details avaliable>

Organization tests: Should delete organization: <no details avaliable>

Organization category tests: Should navigate to Organization Categories page: <no details avaliable>

Organization category tests: Should not create new organization category if cancelled: <no details avaliable>

Organization category tests: Should add new organization category: <no details avaliable>

Organization category tests: Should not change organization category: <no details avaliable>

Organization category tests: Should change organization category: <no details avaliable>

Organization category tests: Should not delete organization category if cancel pressed: <no details avaliable>

Organization category tests: Should delete organization category: <no details avaliable>

##### there are 66 more failed tests, see build details
```


We should check whether session isOpen before sending the PING message too, shouldn't we?


This is what made me think `view_project` was off... no core method should be returning tuples like this.


No, it was Junk on my side.  Strange characters spewed randomly around.
Good thing I had a backup.
I did not ask for a merge since there was nothing to merge.  Im using
Github app on Windows.  Lots of bugs.  I think I will switch to Ecplise
plugin or command line from now on.

On Fri, Dec 11, 2015 at 3:40 PM, TDI-tenderholt <notifications@github.com>
wrote:

> Not junk. You merged something, but didn't resolve conflicts. How are you
> using git? Command-line? Eclipse plug-in? Github application?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/DavidARivkin/mzmine2/commit/d596e6402b2299db7cfcd44a4cf37465d5817e45#commitcomment-14925103>
> .
>


I didn't put the documentation everywhere, since I think this will need to be refactored anyway. Why use a wrapper around the diceroller in the first place?


@indexzero Could you please publish `1.2.0`? Thanks!


I'm quite sure. It checks in L256 and L263 for the two possible directions of the neighbouring line. The comment in the line you're pointing to is no longer up to date however, so I'll change that.


,in the vein of UNIX philosophy, doing one specific task.


useful


You want to make sure that this only applies to request with vertices because it is valid when the request is based on edge_id and position the the start and end can both be on the same edge.


No


Did you use the unlocked version? Long press on a recording to see the menu.

Piotr Kuchciak <notifications@github.com> schrieb am Fr., 11. Dez. 2015 um
08:35 Uhr:

> But where i can found it because in my Galaxy S6 with Android 5.1.1 i dont
> have DOWNLOAD in menu and apps.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rsiebert/TVHClient/commit/2d2a059d970b06cd842b03fedafd5ef34f60ecc3#commitcomment-14919061>
> .
>


Sorry about that @dianakhuang! This should fix it.


for ... for .. for .. for.

Maybe:
The pmempool utility is useful for sysadmins and programmers alike. It can be used for debugging, test automation and more.


The following blog series


無駄な空行２行．空行は１行でいい


Would you mind commenting this line?


なぜこの配列のサイズが100なのかが不明


Alteração revisada ok


Thanks for your explanation. I am aware of the discrepancy of the OCL compare_exchange builtin and SPIRV compare exchange instruction. I am OK with the change as far as all these builtins translated correctly to SPIRV and back to LLVM.


while ( 1 ) { と空白をつけるルールを統一して守ってください．


würds Sinn machen, die passport Initialisierung und die entsprechenden Routen in ne eigene Datei zu packen, und per require() in index.js einzubinden?
Wär was übersichtlicher denk ich.


この-10はなに？？


for creating and displaying information about the pol.


Multumesc !


oops :smile:


When does this happen?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9109](https://teamcity.mesosphere.io/viewLog.html?buildId=90956&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:01:40


This better make it to production, or I'll be very :disappointed: It should be done in regex, someone might try and hide the name inside of other chars.


same deal, try not to repeat the same words multiple times.


while ( 1 )  に統一してください 中括弧の付け方も 改行するのかしないのか統一してください


@miketaylr if you look at the line 286. It's what was there. Not sure why @hallvors decided to move away from it.


sws


ここはキャメルケースになっている


hmm, not sure but:
the future

?


ここはスネークケースになっている 統一してください


merge versions


:( just import it as `log`


複数の処理を行うブロックは改行してインデントをずらしてください


bash completion, ..., which helps in completion.
maslo maslane.


Actually, `simplifyTokenList1()` and `simplifyTokenList1()` run in different phases.

 * `simplifyTokenList1()` runs in the normalization phase, called through `tokenize()`;
 * `simplifyTokenList2()` runs in the simplification phase, called directly.

So it seems to me that there is a case for renaming simplifyTokenList1 to avoid mistaking the phase it is running in; or, alternatively, to find another name for the "simplification" phase.


while ( 1 )


Yes i use unlocked version. But i mean how i can cancel download on Android. Because i have icon that file is downloading but when i click on this icon i can not cancel. File must downloaded 100%.


I made `.vm_config_default.yml`  hidden so that it didn't cause confusion on which file should be edited (because its hidden `.` it shouldn't be next to `vm_config.yml` in the directory tree):

```
.tmp
.vagrant
.vm_config_default.yml
foo
bar
baz
vm_config.yml
```


PIDのパラメータは定数化してください．


同じ関数を連続して５回も呼び出すならばfor文をつかってください


this method is ambiguous cause you are using the "!" in the if statement, the method could be called:
isLocationPresent(Location location) or maybe existsLocation(Location location)
remove the if statement and use only:
return locationComboBox.getText().contains(location.getName())
so you avoid use the if statement


この ±30はなんですか？


Nah, but if you do need I could make one. :)


could you also please fix typo on line 69?


Don't like this sentence. Maybe:
My guess is that you will end up relying on this feature because it's just extremely useful.


What's wrong with [Sails] (http://sailsjs.org/)?


if () {  } 中括弧を省略しないでください．


Please note that full pmempool documentation is available [here].


Since `<script>` is essentially deprecating, these should probably be `<template>` ... unless there's a reason I'm missing why they should be `<script>` tags.


This could be a formatter?!


it just replies with "invalid arguments"


if ( ++counter == 10 ) ではなく 40/4 の理由はなんですか？


Is it correct to be 0.0.1 here? I saw 1.0.0 here:
https://github.com/codrops/AnimatedHeader/blob/master/js/cbpAnimatedHeader.min.js#L2
```js
/**
 * cbpAnimatedHeader.min.js v1.0.0
 * http://www.codrops.com
```


That looks to me like a refactor, not a bug fix or a feature fix. The code actually works either way, right? So there's no need for it to be included in a bug-fix release?


with two basic commands


コミット粒度がでかすぎます．gitで管理している意味がありません．


Why camel case field names? I thought we only camel case the entry types?!


creation of the pool file.


TeamCity Jarvis Framework :: CI-GitFlow [Build 73](http://build.prxm.it:8811/viewLog.html?buildId=5169&buildTypeId=CqrsFramework_CiGitFlow) is now running


@teddybeermaniac what was the reason in the first place to replace the relative URL ``<a id="adminsortable_update_url" href="adminsortable_update/">`` against ``{% url 'admin:sortable_update' %}``.


app.cppが肥大化しています．責務ごとにファイル分割してください


この状態でcppで各メリットがありません．c言語のほうが良いでしょう．


Here's why this is a bug:

If someone reads a comment in a comment notification email and then clicks "add reply", the most common expectation will be that we're _replying to the comment_, not replying to the entire post (after all, we just read a specific _comment_ and then clicked 'add reply'; we didn't read the entire post and click 'add reply').

However, prior to this commit, the 'add reply` link was linking directly to the comment. You could argue that the user then just needs to click the "Reply" button on the comment form to reply to that comment, **however there is one common scenario where this does not happen**:

If a new comment notification arrives and a user clicks 'add reply', they are sent to the permalink for the comment (e.g., `/hello-world/#comment-34`). However, if this comment is the most recent comment (i.e., the last comment in the list of comments), **the main comment reply form will be directly beneath the comment**:

![2015-12-11_08-58-02](https://cloud.githubusercontent.com/assets/53005/11745358/9e5b0774-9fe5-11e5-8f5d-31ff57946bde.png)

When the user sees this comment form, there won't be any reason for them to click "Reply" on the comment they're _actually_ responding to, so instead they will use the comment form that is visible thinking they're replying to the comment they just read, when in fact they're just posting a new top-level comment responding to the whole post.

This makes for _a lot_ of confusion! I recall fixing a similar bug in StCR over a year ago.

In any case, this commit changes the link for by 'add reply` in the email templates so that it uses `replytocom=`, e.g.,  `/hello-world/?replytocom=34#respond`. This causes the reply form to be loaded _already assigned to the comment to which the user is replying_.

The only downside to this is that using `replytocom` doesn't load the form in-line with the comment being replied to (i.e., you'd have to scroll back up and look for the comment you're responding to if you want to re-read it), however in my experience that's worth giving up in return for linking to a comment form that doesn't require clicking "Reply" on the comment you want to reply to.


The decision on #1002 was that all annotations must be user provided, so this doesn't belong here. The meaning of the value of an alert also can be quite different to what the user expects once you get beyond trivial alert expressions, so it's not a safe default generally.

If a user wants to see the value, they need to put it in an annotation themselves.


wonder if the `lock + check version` part should be done in a caller of `Apply` functions, so that it always happens. would make the `Apply` func smaller. (though meh, nbd here)


parece estar Ok.


Hm, what would be the correct way to fix this? For example, would `platforms = [ "i686-linux" "x86_64-linux" ]` be enough?


Oh, now I've read the message saying implicit wasn't working, so I see what you're saying. Presumably this broke when lazy imports were added


Not sure how I feel about the 'that's it!'.


TeamCity Civic Assembly :: Build backend + frontend [Build 79](http://54.229.176.143/tc/viewLog.html?buildId=177&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


maybe import it as `pin3.NewPinner` or `newpin.NewPinner`


I think this will cause a problem with CGUIDialogAudioSubtitleSettings that sets this to 0 if no steams are available.


Please emphasize that the pmem.io is just a string of characters. Maybe:

and *pmem.io* layout string identifier.


fijate que considera los account.domain, account.api.domain y si entras al microsites.dev central


maybe express it's `loadKeysV2` or `loadOldKeys` or something


もうすこし複数人で開発することを意識がけましょう．
人がよめないコードはダメです．
５年後の後輩が突然みてもわかるようなソースコードを目指しましょう．
全体的に無駄なコメント分が多すぎます．
コメント文をドキュメント化したいのであれば，doxygenを使いましょう．
それがわからないのであれば，極力コメント文は無くしてください．
複雑な定数や微調整のための意味付けが難しい変数に対してのみコメントをつけてください．
呼ばれていない関数が多すぎます．メインタスクの処理が長過ぎます．
1関数80行以内にとどめてください．


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.1.12](http://build.prxm.it:8811/viewLog.html?buildId=5169&buildTypeId=CqrsFramework_CiGitFlow) outcome was **FAILURE**
Summary: Tests passed: 138; exit code 1 (new) Build time: 00:03:23


I think this is wrong in #116:
- Bibtex keys are created only lower case
- Field keys are formatted in camel case

Imho it should be the other way round!


do we have a post about pool sets? This might be confusing. Maybe link to it.


Strona główna:
![zrzut ekranu z 2015-12-11 o 15 06 42](https://cloud.githubusercontent.com/assets/33876/11745507/f8419874-a018-11e5-8740-c90d830e59ff.png)

Kalendarz:
![zrzut ekranu z 2015-12-11 o 15 07 19](https://cloud.githubusercontent.com/assets/33876/11745515/ff36b7fe-a018-11e5-83e2-48351887ba27.png)


Эту и следующую переменные можно заменить константами (решарпер умеет такое подсказывать)


Perhaps merge MemberType and SelectableMemberType?


:shipit:


Note that player "id" will go away with https://github.com/xbmc/xbmc/pull/8525
returning VariantTypeNull if no player is available sounds plausible.


TeamCity Jarvis Framework :: CI-GitFlow [Build 74](http://build.prxm.it:8811/viewLog.html?buildId=5171&buildTypeId=CqrsFramework_CiGitFlow) is now running


Same link to time ? One time without string ?


@wilensky Ой, что-то я завтыкал... О_о


failed_2_resolve_link message is displayed in case there's an error handling a link that triggers the app (from a shared trip url, google, etc)


I think this might be confusing for someone who doesn't know what a pool set is.


とりあいず動くもの，攻略できるものをつくるのは絶対にやめてください．
人にコードを見せることをもっと意識してください．
このままでは，2015年度と同じ結果になりますよ．
今はオフシーズンなのですぐに結果を出す必要はありません．
着手したという事実が大切です．
去年のコードを流用して楽をしないでください．
もっとプログラムと向き合ってソースコードを愛してください．


А тут соединить объявление с присваиванием


always scared by queries like this. maybe print out all the keys in a verbose option so that we could _test_ the migration only deletes the intended keys?


@DorCoMaNdO your entire argument is just "because it works this way now it can never be changed, haha u loser read le codes xD"

Whatever your point is about being a "completely different person", that's where passwords come in. I'm telling you the best practice, you can ignore it or not, I don't care.


これらの指摘を踏まえて，再度ソースコードを作りなおしてください．
わからないことはなんでもすぐに聞いてください．教えます．
なので手をぬくようなことはしないでください．


this should delete the new pinsets too, no?


We've tried to make thread create/join explicit in init/shutdown methods, mainly because we often instantiate objects pre-fork and need to ensure that threads don't get started and then lost.  I don't remember if that is problematic with the timer class or not, but it's where RAII has failed us in the past.


Same comments as above about style and missing default.


maybe `writeKeysV2` or `writeOldKeys`?


Нигде не используется?


clarify it's `V2` or `Old`


ここから似たような処理が多すぎる．80%同じ処理をしているものは関数化しましょう．


この700はなにか，iはなにか．


この10000はなにか


gcd же :)


'the new sections' phrasing would indicate that it was previously mentioned that new sections should have appeared. Drop 'the'.


That's a good point. Mainly to make the code more readable in the various classes that need it. But the wrapper doesn't add any functionality or anything.


So, the function is not handling the case where category is None and include_aliases is True. In that case, you would want to include every branches and every aliases in the return statement.


Also your insistence on the magical element of the Social Club name is hilarious. Is RLD! a valid SC account? How about 3DMGAME? If those cracks can set it so can a third party program, it's just that no one has ever bothered to do so before because no one has raised the issue. If you raise it I'll be happy to write a "unique" ID changer. You're the one not making any valid points.

If it's sent over the network don't trust it.


Occasionally happens with specs. Possibly just in one that I made, now I come to think of it. Maybe it shouldn't


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.1.12](http://build.prxm.it:8811/viewLog.html?buildId=5171&buildTypeId=CqrsFramework_CiGitFlow) outcome was **FAILURE**
Summary: Tests passed: 138; exit code 1 Build time: 00:03:59


Yeah, I know what you mean.  You might A) see if the later versions of the docs for the same endpoint have more information or B) send a message to `#CAPI` and get them to respond.  I realize that might significantly slow down the work, so use your discretion.


Fixed in the last chkumar246 PR.


you can just do:
```python
if include_aliases:
```
(without == True)


バランサーAPIを呼び出している箇所が非常に多いのでラッピング関数をつくったほうがよさそうですね．


This looks consistently. if anything.
But consistently is not the right word here. Just start with "We can explain..."


That's a good point actually - I was thinking more of RL terms where responding to a game loss event is normally futile.

I think there may be a card that can counter a triggered ability. I know for sure that activated abilities can be

Sent from my iPhone

On 11 Dec 2015, at 11:27, Melvin Zhang <notifications@github.com> wrote:

> I don't see why "you lose the game" should be any different from say "destroy target nonblack creature" from Chime of the Night's "When SN is put into a graveyard from the battlefield, destroy target nonblack creature."
>
> —
> Reply to this email directly or view it on GitHub.
>


We need to catch and log *all* exceptions here. Uncaught exceptions in `@Singleton` constructors will prevent the server from starting. Subsequent calls should check to see if credentials are present and throw a 503 Service not available if not.

This mitigates the risk of external service failure in production, so that it only results in limited functionality rather than total downtime.


これ以降のwhile文の連打はどんな気持ちでコーディングしたの？？？


Thank you Kasper for the high quality review. The suggestions are much appreciated.
We considered it the best way just to accept the pull request and work through the suggestions locally in parallel. Once we're done we will commit a huge update. And from here on I assume pull requests and commits will converge to the usual functional scope.


この形式のwhile文の呼び出しが多すぎる


Let's make a try is weird ;d


I didn't want to break everything at once. But will remove it since we will have the new alerting definitions as we release this anyway.


:clap: :)


I didn't do any scaffolding so I'm not sure how that happened.


Dude, you're probably 8, you keep arguing in order to support piracy, if you didn't buy the game, it's your own fucking problem, supporting piracy will have Take2 targeting this mod faster, they, as mentioned earlier, target all alternative multiplayer mods, regardless of how they're made and what their progress is like, http://gta-mp.net explains it all, the devs had contacts in Rockstar Games and that didn't save them from a shut down, doing what we can against piracy will ensure us that at least temporarily we'll be safe from Take2.


Not sure, just wanted to get your attention on this ;)


There is a default app "Downloads" which should be installed on all android
phones. There you can cancel the download. Try this.

Piotr Kuchciak <notifications@github.com> schrieb am Fr., 11. Dez. 2015 um
15:01 Uhr:

> Yes i use unlocked version. But i mean how i can cancel download on
> Android. Because i have icon that file is downloading but when i click on
> this icon i can not cancel. File must downloaded 100%.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/rsiebert/TVHClient/commit/2d2a059d970b06cd842b03fedafd5ef34f60ecc3#commitcomment-14925545>
> .
>


OK, let's try setting `platforms` first and see what happens. Thanks for the heads-up!


TeamCity Civic Assembly :: Build backend + frontend [Build 79](http://54.229.176.143/tc/viewLog.html?buildId=177&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **FAILURE**
Summary: Tests passed: 136, ignored: 4; exit code 1 Build time: 00:11:36


can you please add an Apache license header here so it's clear that the code you're contributing is licensed that way?


Nope, don't need someone to send me something like for (new i = 1; i <= MaxClients; i++)


It was ugly. There were three places where the url to the endpoint was hardcoded, in python when adding the route to admin, here in the template (which was not even used if I'm not mistaken) and in the javascript file. I thought that it would be better this way.


Sorry, this was overlooked. We may add that back but in the meantime you can still use [`1`](https://github.com/robbyrussell/oh-my-zsh/commit/25b1cd687b28cb8d05229130ee5a0e2494276894#diff-f7d0a3ef1bc4893bc37a320a5c593e70L13) or add the alias yourself in your zshrc file.


I'm 21, my real name is on this account, try clicking it.

This mod is decentralized, takedowns won't work. All components are open source (master relay server, server and client). It doesn't rely on cooperation from SC like FiveM because it doesn't use their login API. The only ones who could face legal trouble are the authors, depending on their jurisdictions and their OpSec (is Guad anonymous?). Even if they do, if anyone cares enough they can continue development anonymously. Isn't open source grand?

If you wanted to be safe don't attach your real name to this. Who cares if you're save for a week versus safe for a year?


probably want to flush() the session before printing this, to be accurate


Might be nice to change to use a function like:

echoerr() { echo "$@" 1>&2; }
echoerr "ERROR: $dev is not a block device file."


@felliott `extensions` is also used outside of the function which is why I pass as a parameter (so if we ever need to change it the change is only in one place).


can you just let the exception fall through so that the program returns with a non-zero code on failure?


I think could looks better if you change to:
if (texDiffuseFileName != null && !texDiffuseFileName.isEmpty()) {
      if (loadFromSDCard) {
      else {
      }
}


I'll see if it can be fixed without reverting back to the way it was.


Ага, да, exception.


Would it be better to take an args and walk through it rather then examining a global?


Will NOW.. learn to spell


What's the license of this code? It seems you didn't write it, so it's important to check the provenance and licensing here. We may need to add a NOTICE file in this directory which mentions that this 'sbt' script has a copyright or a particular license.

Also, for the sake of an example, do we need this fancier 'sbt' script, or would a standard one suffice? I'm afraid of confusing users into thinking something non-standard is required.

I'm not a Scala developer, btw, so I don't know if this is actually normal to check in this file.


Can you add an Apache license?


See Above
check_block_devs ${DEVS}


И то же для админов )
`MESSAGE_HELP_ADMIN`


Well then, if you're 21 you should know that supporting piracy hurts the developers, while yes, people hate Take2, it's not right to do this to the developers, of any game, they worked hard and they deserve the money if you wish to play the game.


I am just being nit picky other then these LGTM


that will do ;)


This `else` branch is unnecessary, you can simply write:

```js
    let weekText = ''
    if (translationExists) {
      weekText = CP.translate('weekNav.week_' + this.props.weekType, { weeknum: this.props.weekNum, parity: weekParity })
    }
```


indentation looks wrong on this line (it's not a continuation of the previous line, is it?)


I don't quite understand what you mean. If you mean the optimization of checking whether move.from is in sliding piece move positions from king position, then this will not work here, because move.from is generated from PinPos for appropriate directions.


Опять перевод строки)


same


Is this OK ? https://travis-ci.org/os-autoinst/os-autoinst-distri-opensuse/builds/96015349


Тебе надо сделать подсветку в редакторе, там сразу бросается в глаза.


@teddybeermaniac OK, thanks.
Currently I'm busy with other stuff.


Можно, но точно не в ущерб простоте/читабельности кода.


Nice.


How about constructor overloading, like here:

https://github.com/killbill/killbill-adyen-plugin/blob/master/src/main/java/org/killbill/billing/plugin/adyen/client/model/PaymentType.java#L140-L144

to avoid `new String[]{` in the single value cases?


Oh, I see.

Can we avoid __attribute__((packed)) and simply order the struct such that we know the compiler to align it properly?  The current fields of object_stat_sum_t are already perfectly aligned (28 u64's, 4 u32's, some u64's again).  Adding the packed attribute doesn't actually change the in-memory layout for the current struct.

It would be nice if there was a compile-time assert that the packing remains valid, but even without that we can add comments to that effect and we can ensure that the encode/decode unit tests fail if packing is wrong...


Still here. Follow this -> https://help.github.com/articles/remove-sensitive-data/


This is way too general. You don't want every image to have this functionality.


It Looks OK


Looks good - as mentioned on the other PR, I don't know how the UI could end up zoomed to topics on a given stream & then have the user select a different stream -- the if statement is always going to evaluate true, which is why I ended up omitting it.


are they non vbv or just bins ____?????


"*we will commit a huge update*" - I will strongly suggest to commit more often.

Having periodic checkpoints is a huge advantage and it means that you can understand where and how you broke something.

https://crealytics.com/blog/2010/07/09/5-reasons-keeping-git-commits-small/


@jfalcou looks good to you?


Also, are you sure this gets fired after every retry?


Cry me a river. Your attempts to add weak DRM to your third party mod because of your imagined moral high ground is hilarious. I have told you from a technical standpoint that the RLD!/3DMGAME is easily changeable and if you continue to push for this will be changed and all you can do is counter with "muh developers".

If TT couldn't stop the game from being cracked why should mod authors do their job for them on top of doing the job of, I don't know, creating proper multiplayer? You're creating a false dilemma.


I manually reverted those Microsoft.TargetingPack.* changes that were made automatically, and the builds are now passing (other than Ubuntu Debug, which is suffering Jenkins failures here and in other PRs.)


Make sure you also check in subsequent calls to GcsBlobStoreservice that everything is properly initialized. If not, throw a WebApplicationException with status code 503 (Service Unavailable) and a clear error message rather than allow some random NPE to bubble up.


@kevinushey This is an attempt to return a predictable error code from FileLock::acquire in the case where the lock cannot be acquired. Note we already do this from the AdvisoryBasedFileLock:

https://github.com/rstudio/rstudio/blob/master/src/cpp/core/file_lock/AdvisoryFileLock.cpp#L115-L118

The idea is to allow callers of `acquire` to be able to check for this value and in that case not log an error if it was expected that they wouldn't be able to acquire the lock.

Does this look like the correct implementation to you?


Ah sorry just saw below. But what if bucketName is empty or null?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9110](https://teamcity.mesosphere.io/viewLog.html?buildId=90960&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 205 Build time: 00:08:34
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


The following "if ... else" could be
```recurseAssimpNodes(context, assimpImporter, assetRelativeFilename, wholeSceneObject, rootNode, sWrapperProvider, loadFromSDCard);``` ?


Holy buffer overflow! How about snprintf?


@akbertram for each call we check anonymous access. Here I've added also 503 error. Should I split it in separate method to make it more clear/readable ?


Maybe a reverse lookup for performance reasons?
```
private static Map RESULTS = ...;
...
return RESULTS.get(res);
```


@liewegas , Yes , I think this is a great idea to avoid attribute((packed). I would do this based on your suggestion.
Thanks.


Нужно просто проверять `len(events['values']) > 0` (ну и другие проверки).


cc @BLangendorf for review.


Also the following " if ... else"
```sceneObject = createSceneObject(context, assimpImporter, assetRelativeFilename, node, 0, wrapperProvider, loadFromSDCard);``` ?


In this case we prefer to keep the commits low until the dirt settles. From that point I agree we want to keep the commits small.


lkchixclewlkn/f


Ah, right. docopt is cool that way :)


development in progress ...


```sceneObject = createSceneObject(context, assimpImporter, assetRelativeFilename, node, i,
                               wrapperProvider, loadFromSDCard);``` ?


By magic I think that 1 + 3 + 1 + 100 + 1 + 8 < 127, so we should not get overflow?


Yes I've seen this one that's the reason of my remarks about ids ;)
But I'll let @Montellese speak first there :) (There's still the big question about starting playing on external / upnp renderer removal, and the impact on global ecosystem is quite huge) but this is not the point of this PR :)

About this one, from JSON perspective there's currently no null usage for arrays as it causes problems on some library but also from a logical point of view.

IMO if there's no data but the API says it returns an array an empty array is the correct answer. Having array or null is like having 2 ways to say it's empty, it sure can mean the same thing, but does null represent really no data or empty one or problem to get it ? If array is empty does it really means there's no data ? Like imagine one day a video player without audio, should it return null or empty arrays ?
IMO an API that can return null or empty array for same case but also for different case leave way too much interpretation problems.

To resume the API should return empty array when there's no data, if there's no data because there's no player then it should return an error because it's the user error to try to get data from non existing thing. Allowing null here leaves too much questions, is there a player ? is there really no data just for this field, did I made a mistake ?

API should be clean and well defined.


fixed in d19fa16


Also, change to
```recurseAssimpNodes(context, assimpImporter, assetRelativeFilename, parentSceneObject,
                            node.getChildren().get(i), wrapperProvider, loadFromSDCard);```


Done in 1c2c1537fac6ef220911adc608406b04ffe51dec.


are they non vbv bins ????????????????


Might be worth at least a comment :)


are they non vbv


ursgal_params.xls also.


Piracy does not hurt developers. I torrent music and I also buy music. I torrent games and I also buy games. I buy things I want a permanent copy of on Google Music or Steam. If a game is worth owning, and worth having a quality assurance provided by a distributor like the ones I mentioned, it gets my money.

You are writing software. It's important to understand that software is not a political statement. If you are to respect the freedom of your users, you have to relinquish power over them. What you build is not a reflection of you and your morals, otherwise you are morally corrupt to begin with.

t. wise blue fish man


These icons are better.   I suggest you take a screenshot of the browser showing the blockers [1], and showing your icon in place.  I am concerned the vertical shrinking you did to your hand made it look less like a hand, and shrinking even further will loose the effect more; you may have to redraw it.   I like the orange outline, because I like Firefox orange, but that level of detail is too fine given how tiny they will show in the browser tab.  Finally, the text on the images is too small to read, please remove it.

On the subject of "shortcut icon":  You added lines to the html, for example:

    <link rel="shortcut icon" href="./images/blockers.png" type="image/x-icon" />

The "shortcut icon" is a value only used by Internet Explorer.  Google Chrome, and Mozilla Firefox do not show the icon on the tab.  Please open the pages you change in Firefox to ensure they are showing as you intend.

[1] http://charts.mozilla.org/fxos/blockers.html#project=2.0,2.1,2.2,2.5,2.6


Chyba omyłkowo kropeczka weszła do wersji schematu ;-)


tu również ;-)


on the left


right side


This is cool, but I think it would be good to stop using `npm.commands` altogether fairly soon. becuz like https://github.com/npm/npm/pull/10777 and like https://github.com/npm/npm#using-npm-programmatically


Am Donnerstag, 10. Dezember 2015, 23:18:05 schrieb Lars Brinkhoff:
> So why wasn't it possible to install swig in $HOME?

The container build failed, because gforth and/or yodl are not on the
whitelist (probably both).  yodl is necessary to build swig, gforth is
necessary to build gforth.

--
Bernd Paysan
"If you want it done right, you have to do it yourself"
net2o ID: kQusJzA;7*?t=uy@X}1GWr!+0qqp_Cn176t4(dQ*
http://bernd-paysan.de/


#Tested on a Win7 machine and was unable to send msg. No idea.

You're using subprocess to make calls to the curl command instead of using a python library to make your requests. Windows doesn't have curl, so this won't work on anything but a Linux machine that has curl installed (which is standard).


@cesine sorry about this. git told me server.js was unmerged whenI pulled from upstream, didn't know so many file changes I accidentally made!


Comment not updated according to name change.


Klar, mach ich gleich!

> Am 11.12.2015 um 14:59 schrieb Norwin <notifications@github.com>:
>
> würds Sinn machen, die passport Initialisierung und die entsprechenden Routen in ne eigene Datei zu packen, und per require() in index.js einzubinden?
> Wär was übersichtlicher denk ich.
>
> —
> Reply to this email directly or view it on GitHub.
>


Stifle is one such card that exists in our card pool.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9111](https://teamcity.mesosphere.io/viewLog.html?buildId=90966&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:13


A *bit* late, but here it is.


typo


? What happened ?

> On Dec 11, 2015, at 9:27 AM, smithcube <notifications@github.com> wrote:
>
> are they non vbv or just bins ____?????
>
> —
> Reply to this email directly or view it on GitHub.
>


I'm complaining about it :-). Nobody else has got a chance. Warnings don't look nice at the beginning of registry's log. I wonder, what is less evil:

- patch registry's config parsing code again to ignore our `REGISTRY_` variables
- rename our other variables so they don't begin with `REGISTRY_`


:+1:

Though we can probably just go `childProcess.exec('npm install --clever --args', function (err, stdout, stderr)` from the get go instead of wrapping some substandard npm internals in an additional `childProcess`


You seem to be right: https://github.com/apple/swift/blob/master/utils/update-checkout#L89


Coucou je comprends rien du tout


Looks good :sheep:


Ah yeah typically Cargo tends to use `chain_error` instead of `map_err` to preserve the original error context, but beyond that this looks good to me!


Idejau Web.Release.config i ignore lista bet as vistiek matau repositoriuje sita faila online?! Kaip istirnti Web.Release.config is repositorijaus jei netycia as ji commit'inau?


This looks pointless. It's just noise I think - if any exceptions are thrown a) they are runtime, so no need to catch, b) they are logged by the `SpringApplication`.


Shouldn't there be "return true" at the end? -- I think now the warning is always displayed on the installation page


Then you don't need previousBuildData ?


As discussed, I'll leave it that way for now until we find a clever™ way to do it without duplicating the Strings.


Remove debugging statements.


Could you also describe in comment what expected flow around buildData to exclude such future unknown problems?


I fixed that in https://github.com/shehzan10/arrayfire/commit/cda0923579c9700829ce6cc780893b34f0e3fed5


New graph that shows a ranking by time for the groups that have work with the ticket more than 15 days.


`previousBuildData` is still used in changelog generation, looks like.


I'm curious. I never used Travis, but is Travis needing objective-c as linker or is it just a typo?


Sure thing, will do.


@abhi12ravi pdf.js is a project and FSA is a program!look at remo portal on github about how should we maintain readme for programs in mozilla! We have certain guidelines to follow for readme.md to get added to github.com/mozilla and we are following the same.


you committed in the wrong way


This is literally like talking to a wall, just like those kids who cheat in GTA Online and think it's okay, that's just sad.

Piracy does hurt the developers and anyone involved, buying the game shows that there is a demand, and it also puts money towards the next installment if one is to be made.

Now please, grow a fucking brain.


unused?


No, objective-c is just the environment, meaning a Mac host.

Travis supports many different languages, its just that historically objective-c == osx and they haven't changed their wording.


Fixed in the last chkumar246 PR.


really thank you your tool. can you tell me how to create code for download free 3d model from nonecg.com, or any website? Please tell me.
THANKS


WHOAA GITHUB API AND GIT STOP YOU'RE BUGGING AND MESSING IMAGICALMINE'S CODE :no_mouth:


nitpicking: "cannot load module $mod_path"


TeamCity Civic Assembly :: Build backend + frontend [Build 80](http://54.229.176.143/tc/viewLog.html?buildId=179&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Thank you for this quick and efficient fix!


The problem is that TEXTAREA contents will render those entities, so escaping everything will mangle any CSS code that contains ```<>&```.
AFAIK the only risk here is input with a TEXTAREA end tag followed by malicious stuff.


what is this ?


That's my understanding: well and truly broken, but only when doing the lazy import. A user reported not being able to import TextBox, so maybe this is actually a BF. I was thinking lazy imports were a new thing, so this would be a FF.


I think all this is covered in Spring Boot: https://github.com/spring-projects/spring-boot/blob/master/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/cassandra/CassandraProperties.java. Probably best to use whatever Spring Boot provides out of the box.


Still a couple problems:

* `\<space>` and `\&` are generated for `.TH`'s fourth and fifth arguments (the manpage title), and the backslashes in these become verbatim, when they should not.

* `\fB` and the like (i.e., your exceptions on line 24) entered inside inline-code and listings should be verbatim, but they are not.


not required


```@course = Course.new(course_params)```


don't need


Students/Others/Hada I. Maria/Assignment 2/Assignment 2.2/Zoowsome/app/src/main/java/com/example/maria/zoowsome/CustomAdapter.java

I see quite a lot of duplicate code here and all for a small little image resource.
What if you'd put an attribute in each animal called "image" and instantiate it with `R.drawable.butterfly` or whichever image resource is appropriate for each animal.
This way, you would completely remove this switch statement and simply write:

```
myText.setText(theAnimal);
nameText.setText(animal.getName());
myImage.setImageResource(animal.getImage());
```


should not use params[:id]. you should use course_path(@course)


I'm not much of a Cassandra user, but judging by what is available in Spring Boot I'd say this ought to be using a `Cluster` not a `Session` as it's main contact point with the middleware (like the difference between `DataSource` and `Connection` in JDBC).


[Mongoose promises don't have a `.catch()` by default](http://mongoosejs.com/docs/promises.html) so don't use that :) really no need to use `.then()` in the tests here, just add a separate test for that.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9112](https://teamcity.mesosphere.io/viewLog.html?buildId=90967&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:06:58


should be in private.. it is not find_course; it should be load_course


Great!


This broke CI since there are more places that render the partial.


Then what's about `buildData`? If builddata exist then we should extract it and use. In current logic i see that 3 different buildData can be operated (but i may mistake).


The webhook is for Slack. I didn't consider abuse a problem. This approach was also the simplest albeit dirtiest.

In the worst case, my Slack feed would become cluttered with junk, at which point, I would change the URL and brainstorm a more secure solution.


It doesn't matter if piracy is good or bad. You're changing the argument to be about something else. The argument is more narrow, it's about whether to add DRM to GTACoop. I vote no. Given how many RLD/3DMGAME are on _my_ server, they also all vote no.

There are other reasons to crack the game than because you're pirating it. On the 10th of November, [TakeTwo sent private investigators to the homes of the developers of FiveM](http://arstechnica.com/gaming/2015/11/gta-5-modders-claim-take-two-sent-private-investigators-to-their-home/) and also banned their Social Club accounts, making it so that they couldn't play the game, _even offline_. That ironically means the only way to play games they bought would be to crack them. In most countries, as I wrote way up there, this is not illegal.

Your DRM attempt ("let's just block RLD!/3dmgame") shows lack of critical thinking, and you continue to dodge the question of how you would change people from faking their UID to a Coop server. (Which yes is absolutely possible considering they got it to be RLD! in the first place.)

#CrackedLivesMatter


It is definitely worth mentioning in the release notes, in my opinion, that FreeRADIUS will interoperate correctly as of 3.0.11 with a security hardened Windows domain that has set the LmCompatibiltyLevel to 5 to mandate that NTLMv2 be used, when used in cahoots with an appropriate version of Samba.

This is the same setting applied via Group Policy with "Send NTLMv2 response only\refuse LM & NTLM".

This is Microsoft recommended security best practice. It is trivial to brute force NTLMv1 these days.

The current default is for a LmCompatibiltyLevel of 3, but it's not a stretch to imagine that Microsoft could soon set this to 5 by default.

I suggested to Arran yesterday that the flag be enabled at least by default via Twitter to avoid taking on a technical debt, and avoid a compatibility time bomb.

(As this is a simple security related fix, I'd be minded to make it for FreeRADIUS 2.2 also.)


how about `singleStatementBlock`?


Тут во все конструкторы передается парсер, а по факту от него требуется только получить некий ресурс. Может сразу конструктору на вход ресурс дадим? :)


I had some issues going that way, one test not passing, so I tried to update everything and then it worked. Probably not a strategy to use for a large app.


I have curl installed on the win7 machine.


I went ahead and made a small change to show the route list sorted by date.


Just want to make sure that you are aware of daf_base's DateTime class that already has this conversion...


There is likely a debug message available that is more deterministic to look at.


Ah OK, I thought id wanted to leave a possibility to add SP entities such as zombies for MP by keeping such code :)


As discussed via chat, we'll fix that in the next developer telco.


I can agree that warning is not something you want to see at top of the log. Still global vars are bigger evil, imho! If something, I'd go with your 2nd option, rename our vars.


107959140_selectAll (evanweaver) - Win64-Windows-7-VisualStudio-12: OK (2340 of 2373 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.61%25-yellow.svg)


> (As this is a simple security related fix, I'd be minded to make it for FreeRADIUS 2.2 also.)

2.2 doesn't implement the native winbind.  So nothing can be done there.

Commit c86967da2 always sets that option, which is the best approach.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9113](https://teamcity.mesosphere.io/viewLog.html?buildId=90968&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:06:54


could you avoid a separate traversal and bake it into some existing transformation in ersaure?


I'm sorry, I am a little lost here. Could you please pass me the URL for remo portal on github?
I found [this] (https://github.com/mozilla/remo)  and the [documentation] (http://remo.readthedocs.org/en/latest/) - didn't find any useful info there about README files!


GroceryCrud may be used for Post Type feature.


Cheers, thanks!

I didn't know that! *grin*


Done in dfb9c59c599895073a113bf8fb6543a40b3870e4.


Maybe adding a method to the enum that returns the first value from `String[] responses`, so this could still reuse the value in the enum rather than hard-coding the String value here?


This datetime call is used as a throw away to make sure `strptime` is thread safe before starting threads.  Since we do this already in SickBeard.py this can be removed.

See http://bugs.python.org/issue7980#msg221094 for more details.


Why?


Hey there, Sorry to get back to you so late. I've tested your PR and it seems more logical to me with the logic of your PR. However, since this is a breaking change somehow, we'd need to wait for `1.0.0` to ship it.


Are you typically able to call it from the command prompt or sure that the directory is added to the PATH variables


Now with :100: percent less dirt


It’s documented in the readme, actually before the code was written (I think). But I can break it out too.


Again, why?


Now actually curious - why?


:+1:  I agree


I think this is ok


Hi Damian / @sourceryinstitute,
Just to clarify, this is an old commit, added by @naveen and already merged into OCA... I was just a bit confused---before your comment---about the architecture and OS checks were taking place, but now I understand why this needs to be here.


This commit has been made since we had already stored a GlobalCollectCheckout for the same payment. There's no need to create a new payment but we can use the previously generated one.


sdfsfsdfd


Yes, it's right that it's always set if there's no compatibility implication of having the flag set. I just think that you ought to consider mentioning the change in the release notes due to the interoperability impact. That was the main point of what I was trying to say above.


Linux kernel 2.6 or later required?


O arquivo foi adicionado novamente, pois o commit não havia sido entregue ao repositório


Sails is closely coupled with waterline orm which does not support having a nested schema cleanly.
The issue has been open on sails-mongo repository for ~2 years


Shouldn't it just return the returned value from the above "accept"?


TeamCity Civic Assembly :: Build backend + frontend [Build 80](http://54.229.176.143/tc/viewLog.html?buildId=179&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 136, ignored: 4 Build time: 00:11:38


      项目：学生会办公室管理信息系统  	    项目经理：X先生

      创建人：汪鹤祥 	 最后修改人：汪鹤祥

      创建日期：2015年10月 	最后修改日期：2015年12月

      问题、机会和指示的简要描述 	  紧急程度 	 可见性	 优先权 	   建议方案

      活动、部门、物品信息的处理不够及时，效率低下，还有很多信息均采用人工记录
      1个月 	   高 	       1     	        开发MIS系统

      各个部门与办公室之间的沟通不够及时，信息传递不畅，容易搁置问题，引起各种误解   	    半个月 	    中等 	    3 	 开发之后改进

      部门存档信息更新不及时导致部员办活动时策划信息与实际不符合   	    1个月 	  低 	            2	           开发MIS系统


Leaving that refactoring for a later time. But yes, it could be a good idea.


This question was answered [here](https://github.com/sourceryinstitute/opencoarrays/commit/0f5709132d38ca23958c81be57a076304b28d5ef#commitcomment-14915663).


Good suggestion, however, I did look and it is added to the path variable. I can call curl from any directory.


@danielinux, do you perhaps know why TICS triggers so many OOB and overflow-violations? It shouldn't really be an issue in those places, right?


So previousBuildData is just used as reference and never changed. buildData
is the one we mutate and add if it's not a duplicate (I.e., if this is the
second time checkout has been run in this build against the same repo and
hash). Not sure what the third one is?


Thanks for the change, can you open a PR on this?


Should we create new structure like `ReplicaSetSpec` with only basic information needed to update it? For now i'm using existing `ReplicaSetDetail` structure and `backendApi.ReplicaSetDetail` that already exists also in controller and I'm updating `podsDesired` property, but I'm not sure if this is good.


That would be a *lot* better. I will try it soon. Thanks.


I sort of thought of this entire class as the wrapper :)

Not sure if wrapping it would give much. Which level would you like to wrap it on? (http, webhook-api, …)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9114](https://teamcity.mesosphere.io/viewLog.html?buildId=90969&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:38


mmmmmmmmm


Fair enough, thanks!
On Dec 11, 2015 9:56 AM, "Gion Kunz" <notifications@github.com> wrote:

> Hey there, Sorry to get back to you so late. I've tested your PR and it
> seems more logical to me with the logic of your PR. However, since this is
> a breaking change somehow, we'd need to wait for 1.0.0 to ship it.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/tonyjmnz/chartist-js/commit/5cfb6b182fc86bb2bb1222f2beb18c8f3066d2b6#commitcomment-14926900>
> .
>


LOL! why will this have info about README files? it is not about remo ,it
is about a repository to put under /mozilla account. i guess readme format
info is not documented anywhere. bdw I need your help in documenting how to
run this portal locally. Not sure how to run this ruby project locally.
help us and create an instruction file to run this locally.That would be so
helpful.

On Fri, Dec 11, 2015 at 6:55 AM, Abhiram Ravikumar <notifications@github.com
> wrote:

> I'm sorry, I am a little lost here. Could you please pass me the URL for
> remo portal on github?
> I found this <https://github.com/mozilla/remo> and the documentation
> <http://remo.readthedocs.org/en/latest/> - didn't find any useful info
> there about README files!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fayetandog/fsa-training/commit/df9633f78a0c0a1aa7e912fad6a7bc924ca46863#commitcomment-14926864>
> .
>


@jco-odoo toassign_move_ids is removed there, thus it should be removed from the loop


Hello. I would suggest to use O2 since strange things can happen with O3.


@kares Fixed, thanks!


@jaredallard hey i already said sorry ;(


This out of date comment should be removed.


> I disagree with the main presumption that it's better to harm users who are able to run spring (forcing no shaders on all intel cards, even those who deal with them OK) than harming those who can't (assume the drivers say the truth).

disabling shaders reduced amount of posts in forum about crashes / people not beeing able to run spring with the side-effect of fewer time needed to investigate crash reports. also intel gfx usually are to slow to run spring with many effects, so imo the benefits are bigger than the drawbacks.

maybe sth. like this could be done:

on spring start, set in config CleanShutdown = 0 and when spring quits, set CleanShutdown = 1

when CleanShutdown is 1 on start, automatically enable safemode and don't set CleanShutdown at exit.


In my opinion, both functions simplify the token list, so they should be named accordingly.


s/addapted/adapted/.  But I don't follow much of the comment. "waf variant demo" is a demo inside the waf tree?


PS: Esse commit não subiu com o nome que deveria, devido a um problema que tive de conexão na hora, então corrigindo o nome seria: Correção de erros básicos na função gerar imagem após a implementação do esqueleto do allegro.


Erf, why is that needed?


@bryk: There is a problem with refreshing the view currently. Adding and deleting replicas is not immediate process so we need some kind of watch to see if cluster changes have been applied. One solution would be to get from backend replicaSetDetail periodically and check if desired replicas count is same as retrieved. This needs also some timeout because sometimes backend do not want to rescale replica set properly (f.e. when there is bad container image link set).


(1) - prevBuildData.
You are getting buildData (2) from prev build, then you are checking whether buildData exist (3d state), and later you are using (2)? While BuildData from build will be (3)?


Fixes #13


yepp, less stepps less mess :+1:


what's the directory for each of them?


The static checker is considering those cases where we try to do an address conversion from a buffer, and the length of the buffer is not checked  in advance. This does not seem to be possible, so they could be false positives. I am not sure if adding a length field to the address conversion functions, and checking against the size before converting to addresses, would actually convince the static analyzer that the function is safe


looks good, will merge


Ah, ok. (2) starts as a copy of (1), but then gets updated with the
revision and build number along the way, and is used where you're thinking
of (3).


If you like searching shotter vars s/Present/Exist/ :)


I'm confused now, you mentioned that there were some guidelines for writing a README file - which we are supposed to follow. Anyways, we'll come to that later.

I've created a [new issue] (https://github.com/fayetandog/fsa-training/issues/40) for adding instructions related to setting up a Ruby instance on localhost. Let's take the discussion there! :)


I don't understand this


Pull from upstream.


This commit [breaks](https://travis-ci.org/LWJGL-CI/openal-soft/builds/96151432) threads.c compilation on OSX. Setting _POSIX_C_SOURCE fixes the build.


Do we need a default value of '' here ?


Can we keep the quotes "{{...}}"?


Common Lisp, if I recall correctly, does not seem particularly well suited
to accessing fields in record types either; the syntax is clumsy.  Also,
being a LISP2, the bizarre distinction between function names and other
names is jarring to me.

So far what I have in mind is basically a simple subset of C but with
s-expression syntax.
On Dec 10, 2015 11:43 PM, "Lars Brinkhoff" <notifications@github.com> wrote:

> To summarize your lessons so far: Lisp, Lisp, Lisp.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/sam-falvo/kestrel/commit/2096df5f4c6ef081e50e0d455121a205791756c1#commitcomment-14919133>
> .
>


This has been pushed along with other updates so do a pull and see if it sorts your issues out :)


Does this need `\numexpr` or would `\number` work? I'm wondering about accidentally picking up `+ 10` or whatever following.


params: Object should be enough


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9115](https://teamcity.mesosphere.io/viewLog.html?buildId=90970&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:52


thx intyre for making official pocketmine 0.13


@ashdnazg

maybe with other words: feel free to enable shaders for intel, but then please feel also responsible for helping users with crashes / beeing unable to run spring


Hm, this file isn't even compiled on Linux. Are you referring to old linux kernels without epoll support?


I wonder if this could be the default number. If not, at least use a constant somewhere to ensure that the number of rows displayed though push updates are the same as the ones displayed initially.


При изменении длительности разве не нужно удалять трек?


Can we go with just var params = { .... } and only set this.$.nxResource.params before the execute ?


I was wondering about adding `\relax`  but decided to make no changes in
the original checkin as all of the \pdf.... definitions are as in the
luatex manual (apart from addition of \protected) we probab;y want to
adjust some of them
when doing this "for real"


I tried to use macros everywhere in my last commit, let me know if I miss something.


I think we shouldn't be binding to params since it can be an Object or an Array, right ?


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 102](https://teamcity.labkey.org/viewLog.html?buildId=291014&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:44


I like AlreadyPresent here - it's more accurate and specific. But I'm not averse to changing it if you feel strongly. =)


Yes it is useless, removed.


Oh boy. I was just wondering how much disk space we have, just keeping all the nightly builds consumes about 1.5 GB per day.
Can you manage that?


Done in my last commit.


yep indeed… also `content: '> ';`


I'm not convinced about adding a specific method since it's used in one place, in tests (also, the ordering is a bit arbitrary). I did 82b59fdb4ba32cb5aa376ffa4df69816d44e2b07 though.


We clean them regularly, keeping only the x latest days on Linux (when the script runs)...


Those are not remo guidelines so u can't find them in remo! The guidelines
are to add a repository to /mozilla which are not documented anywhere
AFAIK. Thanks for creating the issue.
On Dec 11, 2015 10:12 AM, "Abhiram Ravikumar" <notifications@github.com>
wrote:

> I'm confused now, you mentioned that there were some guidelines for
> writing a README file - which we are supposed to follow. Anyways, we'll
> come to that later.
>
> I've created a new issue
> <https://github.com/fayetandog/fsa-training/issues/40> for adding
> instructions related to setting up a Ruby instance on localhost. Let's take
> the discussion there! :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/fayetandog/fsa-training/commit/df9633f78a0c0a1aa7e912fad6a7bc924ca46863#commitcomment-14927300>
> .
>


Pour garder une logique avec la trame de l'article, j'aurais mis la map précédente :
```javascript
myMap.has(2) // false
```

Car si on suit la trame :
```javascript
 map.has(1) // ReferenceError: map is not defined
```


What the whileExpression has to do with hasReturn?


You still have a potential wrap-around there. If `textInput` is false and `_textInputCounter` is already 0, that `--` will wrap `_textInputCounter`.

Thinking about it a bit more, since that would be a bug in the usage of the method, we should probably catch that. I'd check if `_textInputCounter` is 0 right at the start of the else-branch, and if so, throw a `Common::Exception`. With a simple message of "EventsManager::enableTextInput(): Counter underrun" or something like that.

Likewise, `enableKeyRepeat` should probably do similar. Instead of `else if (_repeatCounter > 0)`, it should check for `!repeat` and _repeatCounter == 0, and then throw, right at the start of the function.


Stupid me.. Thank you! :)


When you say the next version, do you mean the just released v2.2.0 or the version after that.


it should be just:
freebsd: posix64 posixXOP

(we decided that we should not recommend avx/avx2 targets for the time being)


Ok but please correct the typo in french:
+ public $mid_msg_fr = "Authoriser le test de la Mobile ID? (#TRANSID#)";
should be "Autoriser..." without 'h'


Initializing int *a to memory location 0x1000 which you don't know if that is safe or not.


obtaineD


Better to just do
int b = 0;
int *a = &b;


可以


Indeed. I was kind of thinking something like: Hey TICS, it's C, what do you expect? A literal size would be of no use.


@eldy This looks like a mistake. I don't think you wanted this in the public repository ;)


TeamCity Jarvis Framework :: CI-GitFlow [Build 75](http://build.prxm.it:8811/viewLog.html?buildId=5177&buildTypeId=CqrsFramework_CiGitFlow) is now running


I might know how to fix this


Hello Daniel,

Why did you removed LightInject?


yes, thanks for spotting!


You may want to have a look at https://help.github.com/articles/remove-sensitive-data/


Think embedded ...

Why would I know 0x1000 is safe to access?  It's not so much the absolute value of the address, more that we're using a hard-coded address.


There is convention saying

<tab> key should be translated to spaces and should have 2-space width

This allows to avoid conflicts and blank lines editing on team work.


Why so much empty lines here?


Merged and bumped version to 0.4.1


Fix n_samples in __init__.py

address #235

Fixes n_samples at line 117

n_samples is in arguments for other functions except this


This test goes beyond looking at the source at face-value...


license missing


OK, so back to renaming this `simplifyTokens()`. How about one of  `cleanupTokens()` or `scrubTokens()`?
They don't carry the sense of transformation that 'normalizeTokens()' does.


Yes, I can delete my cache to solve this problem; my point is that everyone (who has ever run an rpc test that uses `initialize_chain`, which I assume is all the developers who work on bitcoin core) will have to do so.  But if you make the code behave the same way it used to then no one should have to do that.


I'll undo this and won't do the `--rm` options.


Maybe still use the LTS version, if there are no significant improvements that are being used.


TeamCity Jarvis Framework :: CI-GitFlow [Build 1.1.12](http://build.prxm.it:8811/viewLog.html?buildId=5177&buildTypeId=CqrsFramework_CiGitFlow) outcome was **SUCCESS**
Summary: Tests passed: 138 Build time: 00:04:12


@asr0 Why did not you submit a pull request?


Not really sure. If you're going to choose a specific memory address that you want to point to, you better be sure it's not in a protected space.


Maybe I am overseeing or misunderstanding something, but shouldn't it be `self._queue[0]` instead of `self._queue[i]` because there is already a `self._queue.shift()` happening that shortens the queue? E.g. if the queue has 2 entries and the concurrency limit is 2, then this current algorithm will only push one element from the queue.


Hides announcement message for:
* debug commands
* capt duels


I prefer to see this call in the try, so we know why there is a finally statement when looking quickly.


That was the one I was thinking of - things like Time Stop which end the turn can also get around the game loss.

I'll make the edits to the Liches (Nefarious Lich was the other one - at least it has an 'R' in it)


Hey guys I'm not sure if this will be moved to /mozilla, the initial plan is to add it as part of the [Mozilla Community Education portal] (http://education.mozilla-community.org/) and the repo of that project is with Emma. But yeah I dunno what are rules in getting something into the Mozilla Github account.


do it saveworld before the stop command ?


@mworrell Can this also go to 0.13.6?


Should be fixed now in commit 13bf636a345b6caf65444c684b4a4c3b52fc263b.


A closing parenthesis is missing here.


Think about how code executes.

The fact that "a" is at a hard-coded address should tell you something.

Your suggestion has implications that would render this function useless.


JSONField... 1.9 won....


Should this line be `baseUrl = baseUrl.substring(0, baseUrl.length()-1)`, without the assignment substring don't have effect.


I still don't understand what this class is


Why did you have to add the SRException type? Doesn't it have the same effect? Notice the isinstance(e, SR.SRException) call afterwards


Look at my first comment. There is error message and that file isn't in out directory. I'm trying to manually copy atmel dir there and see what will happen


+1 for 1.9+, as  there never is a reason to start a project with an outdated feature set.


This class should probably be named SetProcessingGraphRequest


Again, what is this class for?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9116](https://teamcity.mesosphere.io/viewLog.html?buildId=90975&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:56


It can't work on my server, and here are the fix:
https://github.com/Daniel17173/ygopro/commit/406b4c1ee5cf199eb699dd28ca03b91b73a11641


typo: ETX_DIVOSOR --> ETX_DIVISOR


looks strange


I'd say we should go simple in this PR and then do refreshing/watching next. What do you think?


For everyone else, with a 30 character limit this should almost never happen, BUT just in case...

Well done on figuring this out last night! :+1:


Great, let's leave the README.md as is right now.

This [readme] (https://github.com/fayetandog/fsa-training/blob/gh-pages/modules/README.md) was what I was looking for, will get started working on the issues. Let's figure out the actual README when the time comes.


Илья, подскажи, как эту строку правильно читать ?


@rosskarchner gulp scripts command to be run on page save etc. but i'm curious if this will work on apache.. i feel like it should..


We can discuss that on tuesday and for now I'll add todo here.


Btw., this needs to be `'editReplicasFn'`. Basically, all props of scope, bindToController, resolve and locals have to be stringified.


There have been reports of some issues with the 'touchstart' event additions here, such as #2413


Probably files got removed due https://github.com/CM-LG-MSM8226/android_kernel_lge_msm8226/blob/cm-13.0/firmware/.gitignore
Check if in your clone all files from this directory exist: https://github.com/CM-LG-MSM8226/android_kernel_lge_msm8226/tree/cm-13.0/firmware/atmel


:+1:  [Travis CI Job](https://travis-ci.org/killbill/killbill-adyen-plugin/builds/96277878) passed as well


I'm aware of MVC, though not very experienced with using it in java. In any case, I'm mostly untangling some of the mess now, switching to a more MVC-like approach (if not full MVC, perhaps using the observable pattern or some similar event-based approach) might be a good next step.

Perhaps you can recommend an open-source java project that has a good MVC implementation I could look at for inspiration?


Yeah, I wasn't thinking clearly about that! The fields and any methods we don't want exposed should be protected though.


Ok, I'll remember


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9117](https://teamcity.mesosphere.io/viewLog.html?buildId=90976&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:08


Gonna merge it and I'll add something more.
Please, let me do it!


Ok, will add a function to send errors to stderr and also exit. Something like fatalerr()

Also will walk through a passed in device list instead of inspecting global. makes sense.


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 101](https://teamcity.labkey.org/viewLog.html?buildId=291008&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 12, passed: 36 Build time: 01:08:47
### Failed tests
```
org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterPane: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

##### there are 2 more failed tests, see build details
```


Looks good to me!
Go ahead.


Así, lo haré :+1:


So doing a ``refresh-all`` and ``make-my-image`` followed by trying to bootstrap gives me this:

```
You have triggered a bug in Factor. Please report.
critical_error: Invalid header in base_size: 101c1fe50
Starting low level debugger...
Basic commands:
  q ^D             -- quit Factor
  c                -- continue executing Factor - NOT SAFE
  t                -- throw exception in Factor - NOT SAFE
  .s .r .c         -- print data, retain, call stacks
  help             -- full help, including advanced commands

> ^C
```


Fix to point to master after when merging


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9121](https://teamcity.mesosphere.io/viewLog.html?buildId=90983&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:46


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9118](https://teamcity.mesosphere.io/viewLog.html?buildId=90980&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


The `main.js.map` file is being generated, and it's located in the build folder right next to the `main.js`.

For some reason this configuration didn't work for me in the manner that the sourcemap file hasn't been generated on the correct path.

    const sourceMapLocation = global.isProd ? './' : '';

When I've changed it from `''` to `'./'`, as it is for the production, the file got generated.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9120](https://teamcity.mesosphere.io/viewLog.html?buildId=90982&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:18


Out of curiosity (and perhaps ignorance), why do you use these curly braces here? Is it to limit the scope of the `nbr`variable? Or is it for compatibility with C89?


I think these two lines of code don't do what we want?

        user_data['brkt'] = {'api_host':endpoints[0]}
        user_data['brkt'] = {'hsmproxy_host':endpoints[1]}

After the second line is executed the dictionary has only one key, hsmproxy_host. This could be written as:

        user_data['brkt'] = {
          'api_host':endpoints[0],
          'hsmproxy_host':endpoints[1]
        }

And then we'd get both keys.


```New player connected: poop (ayylmao)
ayylmao: lol
Player disconnected: poop (ayylmao)```

Boy, that was easy. Good night Commando. Think about what I wrote. For this to be successful we need to not have to rely on "unique" IDs.


Also, ``./build-support/factor.sh update`` doesn't work:

```
truncated image: 4060024 bytes read, 4060064 bytes expected
fatal_error: load_data_heap failed: 0

Nursery   : [0x10e040000 -> 0x10e240000]    2097152 bytes
Aging     : [0x10d840000 -> 0x10dc40000]    4194304 bytes
Tenured   : [0x101840000 -> 0x10d840000]  201326592 bytes
Cards     : [0x10e242000 -> 0x10e30c400]     828416 bytes

Contexts:

  Datastack   : [0x10018e000 -> 0x1001ce000]     262144 bytes
  Retainstack : [0x100601000 -> 0x100641000]     262144 bytes
  Callstack   : [0x100643000 -> 0x100743000]    1048576 bytes

./build-support/factor.sh: line 602:  9783 Abort trap: 6           ./$FACTOR_BINARY -i=$BOOT_IMAGE
```

So maybe it needs new boot images uploaded?  But since I can't bootstrap myself, I can't upload them...


Done.


Instead of `map`, seems like it would be clearer to use `each` here. Conventionally, `map` returns an array of values, and `each` just calls a callback on each value. This code creates an array of `undefined` values, and then discards it.


We speculatively added support for this in pydisque a month ago, testing the compatibility now.


Looks like we're getting specific paths rather than relative paths here as part of our source map. If we ship source map files that have paths like this the source map won't work for most people because they will have a different path.

I think we need to find a way to strip out these inline source maps and rely on the .css.map files only. I'm not sure what these are adding currently, but for me with just the .css.map files we had before the source mapping was working fine. Do we know if these were always part of our built .css files or did they start to get added after the recent rework of our Grunt tasks?


test


bireert


@jaswsinc If we want the header to be mobile-ready across all of the major email clients, we cannot use tables or floats, so the logo just doesn't fit. Besides, the logo doesn't really make sense at the top of the email (it's confusing for readers because the Comment Mail logo appears next to the name of the site... making it look like the site's logo is the Comment Mail logo). We have the "Powered by" note at the bottom of the templates anyway, so it's not necessary to have the Comment Mail logo at the top.

![2015-12-11_10-46-06](https://cloud.githubusercontent.com/assets/53005/11748112/aa671b7a-9ff4-11e5-87ed-7983cc4c5148.png)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9119](https://teamcity.mesosphere.io/viewLog.html?buildId=90981&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:08:08


This may break the scripts that relies on their position in light DOM (relative to enclosing tile structure)


I have left back only this due to need for converting between UpdatePercent and MaxSurge,MaxUnavailable


Copy that! :-)


Alright, interesting to hear it worked well here.


@ironcladlou fyi


Looks good to me!


@openshift/api-review @ironcladlou


I know we had talked about not using referer but after a ton of test, this is only way to identify some of these requests. Some requests have no `headers.from` and `user-agents` that appear very normal. Instead of just checking `headers.referer` for 'google.com', we more specifically look for either 'goo.gl' or the 'invite code'(as these requests are coming from the Google Shortner http://stackoverflow.com/questions/29949220/google-url-shortener-automaticaly-visits-my-links-on-shortening). If this is a request from an organic google search, 'goo.gl' or the invite code will not be in the referring url.

Attached is a screen shot of a request with no `headers.from` and very normal looking `user-agent`. But we see the invite code in `headers.referer` and can identify it as a request from Google Shortner.

![screen shot 2015-12-11 at 10 49 29 am](https://cloud.githubusercontent.com/assets/7050925/11748174/0518c85c-9ff5-11e5-84e8-c9762155fe56.png)


Aha, didn't realize this is the only place in the codebase that does HTTParty stuff. I was thinking on the level of a HTTP client: `HTTPClient.post(…)` or whatever. But it sounds like it'd be overkill here.


@ironcladlou


@nakamura-to `EntityListenerProvider`の実装内容についてコメントください


Following up from in person conversation, we do support (as found in `test_algo_fetch_csv`):

```
        signal=data[sid(24)]['signal'],
        scaled=data[sid(24)]['scaled'],
```

So we do currently need to allow for dynamic fields.


remove consol logs.


```
if "currency" == "bits"
```
intentional?


@turboMaCk while I appreciate the refactoring, I'm not sure what this has to do with this feature.  As a general rule of thumb, I try not refactor code unless its code I am currently working on (e.g you are making an improvement to the database service, so while you are in there you refactor).  Does that make sense?


See comment below.


remove that, if function is empty.


really ? By convention, the change we want to rollback is outside the try block (or in the try-with-resource block)


arf, new IDE, old problems


These manual conversions are almost all removed in favor of generated conversions so no need to review from now on.


:ok:


> so no need to review from now on.

Except the changes in the end at pkg/deploy/api/validation/validation.go


This equals 1 nanosecond. Is this desired?


This is the only way right now to have the right installation of Pillow for the Ideascube server and make the server up and running.

I can't manage any more to build a proper package without any error like Pillow or missing datetime module.

We have to find a better solution anyway


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9122](https://teamcity.mesosphere.io/viewLog.html?buildId=90985&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:08


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9123](https://teamcity.mesosphere.io/viewLog.html?buildId=90986&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:53


Done.
On 11.12.2015 15:54, Maciej Szulik wrote:
> I can agree that warning is not something you want to see at top of the log. Still global vars are bigger evil, imho! If
> something, I'd go with your 2nd option, rename our vars.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/miminar/origin/commit/d11a9a43facb5253044c13919dadaaadff98c594#commitcomment-14926832>.
>


@ralmidani , the name of the relationship itself has nothing to do with pluralization. It is defined by the model fields names. In a sense, you are correct to understand that the pluralization of the relation key happens inside the "data" array, on the "type" key but this documentation fix has nothing to do with that as the actual demonstration is properly depicted in the example code ("type": "home_town" vs "type": "home_towns")


ack


#5174-Zone-Name-for-Condenser-Placement-in-DX-Coils-is-misusing-the-zone-name-as-a-node-name (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


s/image stream tag/ImageStreamTag?


Ok, I will document them.


The changes in this file are somewhat interesting but I think they are correct since we don't save in etcd or surface in clients `params.RepositoryName` and `params.Tag` anymore.


When using the cdef class for SidView, here is the result for referring to `data[sid(24)].bar_data` in an algorithm.

```
qexec.executor.fail.AlgorithmError:   File "qexec/qexec/algo/algoproxy.py", line 790, in call_function
    return func(*args)
  File "<algorithm>", line 11, in enter_apple
  File "zipline/_protocol.pyx", line 84, in zipline._protocol.SidView.__getattr__ (zipline/_protocol.c:1646)
    return self.data_portal.get_spot_value(
  File "qexec/zipline/data/data_portal.py", line 351, in get_spot_value
    raise KeyError("Invalid column: " + str(field))
KeyError('Invalid column: bar_data',)
```


plz add bots to this line


Minor comment, otherwise LGTM


Remove 1970-... ? and replace with Epoch?


Still LGTM, much cleaner


Looks good :+1:


All Volume and Container related conversions are being pulled due to PodTemplateSpec being used internal now instead of ReplicationControllerSpec.


what is 20151207?


Ranger 通常翻遊俠居多


Can we check with && instead of ||?


is it still used?


I'd suggest making an own package `bears/js` and put this bear, I've been trying to sort everything according to language, think it makes everything a bit easier. I don't care if you change this commit or put some on top.


dont assign function direct to vm object. define private function and assgin it to vm on the top of your service/controller/anything


We should require a pod template for a dc resource, right?


Use momentJs - I think it is the best way to deal with dates.


Yes, your validation is correct


Changed a function name accordingly to Sketch 3.4.4 update.


remove empty lines, or setup autoformatting.


ack, same note as last commit (make a `php` package)


OK, cool. I'll cherry-pick this one over as well then


@o5 Nejsem si jist, proč to dělá problém. O proměnné gridoTemplate ani nevím. Můžeš mi k tomu říct více?

Také dotkne se to nějak pull requestu #240 ? Budeš jej mergovat?


We could support dynamic field lookup with a special method rather then `__getitem__` or `__getattr__`, ala:

```
class SidView(object):

    @property
    def close(self):
        # Get close
    @property
    def volume(self):
        # Get volume.
    ...
    def custom_attr(self, name):
        # Get custom attribute.
```


:+1: The static instance methods are much clearer


Upon more review, a fetcher name is also allowed.


"etc...) are present in the template but it can also contain parameters that need to be set by the"


Believe it or not, it actually varies D: Some requests have invite code in `headers.referer`, others have 'goo.gl'.


Nah, I meant that is about the *seconds* relative to that time.


ack


Not working on my Surface Book unfortunately :(


I followed the same behaviour that's already found in sol_platform. One function is used to register and another one to unregister. No handles are returned.
I'm also using the data to delete, because a monitor may be registered with the same callback but with different data.


ok.


> This is the only way right now to have the right installation of Pillow for the Ideascube server and make
> the server up and running.

It can't be that way ;)

> I can't manage any more to build a proper package without any error like Pillow or missing datetime
> module.

Give me the error you have, I'll see what's going on. :)
About missing Pillow or datetime, it's because the build as not been made in an environment consistent with where it is installed.


Agree,  much simpler


very bad.
1. li is block element - width: 100% is default.
2. use namespaces - now you define style for all li tags in project.
3. create global.scss for globals style.


is that necessary?


we should find a way to shorten those tests for linters further, I assume you can't use the test generator because your linters don't work with stdin/out but with file input.


bad formating


This condition is inverted.  Previously the condition was Exclude when OSEnvironment == Unix.  Now it is only include with OSEnvironment == Unix.

If this is passing CI then I guess that means we can remove this condition, yes?  /cc @ellismg @weshaggard @akoeplinger


Wonderful effort @lethalman! This is a much better way of creating docker images than writing a `Dockerfile`.

1. This line should be `registryUrl`.

2. It might be worth noting that the provided example values of `indexUrl`, `registryUrl`, `registryVersion` are the defaults for `pullImage`.

3. What happens when the tag is updated on the docker registry? The `sha256` value becomes invalid for one. Is it best to recommend always setting a value for `imageId`? Although I imagine unused image ids are soon deleted from docker hub.

4. For `imageId`, it needs to be said that the full 64 character ID (as seen in `docker inspect`) is used, not the short 12 char version.

5. At a later date (not necessarily for this pull request), could it be possible to remove the `sha256` hash and just use `imageID`?


Odd. There are some false positives here. I'll message you about it.


This array is used multiple times.  What about having just one instance to remove duplicates?


This query is used multiple times.  What about having just one instance to remove duplicates?


Could this one be applied to release-2.x.y too ?


Looks like tests are not passing on this:

https://travis-ci.org/gramps-project/addons-source#L2358


why did you commit the binary `bears/tests/linters/test_files/csharplint_test1.exe` in here?