ok, but what i don't understand is that :

0) in game settings, you can set rewind to yes or no. By default it's no.

1)
So, in advanced snes, i set it to yes.
I understand that snes will allow rewind.

2) in game settings, i set it to yes.
I understand that snes will allow rewind.

3) in game settings, i set it to no.
I understand that snes will NOT allow rewind.

but 1 and 3 have the same configuration values, but a different behavior.

2015-12-29 15:36 GMT+01:00 digitalLumberjack <notifications@github.com>:

> Rules are :
> default cores (set in configgen) < advanced settings (per system) < game
> settings in metadata
>
> Si if you touch nothing, you will have the default emulator and core, if
> you set at the system level, all games will have the settings except the
> ones you overrides in the metadata menu. We could refactor some things as
> it's not very clean, but it works like that.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/recalbox/recalbox-emulationstation/commit/9f96d94c00d99a022da557a58599e4188ad1736e#commitcomment-15190288>
> .
>


Did you intentionally leave this in?


実は、ヘッドはapplication.html.erbに記述されたあるから%headはいらないね。


Hm, I never had that.

Maybe because I am on the bfd linker, not the gold linker.


It'd probably be clearer if we said something like "If Diego isn't enabled by default", I think the "it's" here is a bit ambiguous


I tried that actually, to use it for the score calculation too, but optimizing for eucledian distance squared, starting from the latest chunks (1249 at the time IIRC) resulted in chunks that - calculated with the haversine distance - resulted in 2100+.

It makes sense, as going from antarctic to the north pole all of a sudden becomes a lot cheaper (but from Gent to Brussels is only a bit cheaper), so it's really a different optimization case.


shi~


This is a combination of our CM12.1 sepolicy and the sepolicy from i9300.


If so, don't we throw the not supported exception?


The `is_left_consumable` and `is_right_consumable` are for internal use only, and indicate the default behavior (i.e. Will left/right argument be consumed by default). They are used in the calls to the eval functions to select the correct code path. The consume `consume_left` and `consume_right` functions override this behavior.

These constants probably should be made private to reflect the intended use.

The unit test only test the case where the tiles are the same, not where they are different. The reason being, mixed tiles were not fully supported.

I have no problem changing the name of these variables to better reflect the intent/meaning of the variables. Do you have a suggestion?


It's not about duplication. And even if it were why do you think they can't contain different qualities? It's about consistency with previous behavior. Same goes for plain links. Obviously:
```
format code  extension  resolution note
HQ-RTMP      mp3        unknown
HQ-HTTP      mp3        unknown    (best)
```
is better than:
```
format code  extension  resolution note
HQ-0         mp3        unknown
HQ-1         MP3        unknown    (best)
```


Great work, @milancurcic thank you very much! I have got it!


В конфигурационном файле старайся использовать одинаковые переменные для данных, либо какие-либо префиксы. Идея конфигурационного файла как раз в том, чтобы ты мог его просто подключить, и к примеру в переменной $cfg или $config иметь все нужные тебе данные по настройкам. Использовать такие вещи как $local, $admin, $user не стоит, потому что например при выборке пользователя из базы ты запишешь ее в одноименную переменную, затерев данные из конфига. На крайний случай используй пару переменных конфигурации, например $nav, или $navigation.


d


This kinda breaks the expectation that code comments are copy & paste-able. I don't see the win of this rather than just repeating the line.


全体をwrapperで囲うといいよ！


The most specific the most priority.

Game Settings < Specific system settings for the rewind, smooth and ratio properties.


Thx! much much better like that ;)


Опечатка: *ахрив*


Сириосли? Отступ в процентах?
Никогда не делай отступы в процентном соотношении.
Проценты всегда относительны, и их использовать нужно только для этого.


Does the intended audience already know what VCAP variables are? Even if they do, maybe it'd be better to just say "you will see the app running", since that's really the interesting bit. We can explain what the app is showing in a separate sentence if we think people would care.


fix doesn't work
![comment-pic-preview2](https://cloud.githubusercontent.com/assets/9904364/12036082/109c23c0-ae43-11e5-8f59-a0e7df813eec.png)


i want user to override the configuration when setting specific options for a system or a game, that make sense for me. If it's not clear enough for everyone after i document it in the wiki, i'm ok to change some titles or names (like OVERRIDE SETTINGS in place of advanced in the menu)


This could be its own class. And I LOVE how it doesn't mess with or mangle state, it just takes takes and input and returns an output. That makes for much easier refactoring. I'd pull this into its own file before doing anything else. A module with its own namespace and this as a single method would be a good place to start.


This is pending the design decision on how to implement AllergyAPI REST by Darius and Burke.


do you mean files? i dont know how to push bits


TeamCity pull requests :: netty [Build 931](https://garage.netty.io/teamcity/viewLog.html?buildId=4352&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6364, ignored: 23 Build time: 01:21:15


This logic appears a few times throughout the code, I'd pull it into its own method.


@ThisuraThejith what happens when you run this module on platform 2.0 which also already has this jar?


It's on moviesE now, right?


ok. I will retry tonight to see if i understand betterly (plusmieux).
thanks.

2015-12-29 15:45 GMT+01:00 digitalLumberjack <notifications@github.com>:

> i want user to override the configuration when setting specific options
> for a system or a game, that make sense for me. If it's not clear enough
> for everyone after i document it in the wiki, i'm ok to change some titles
> or names (like OVERRIDE SETTINGS in place of advanced in the menu)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/recalbox/recalbox-emulationstation/commit/9f96d94c00d99a022da557a58599e4188ad1736e#commitcomment-15190401>
> .
>


The current date and time isn't exactly what we are going for but it wouldn't matter when the program would be running in the server as the values will match.


Looks good indeed!


Is this meant to be `remote`?


It's not called ViewEnvironment by anything except this sample app. Maybe we should talk about publishing an app in VS? Link to something like https://msdn.microsoft.com/library/1y1404zt(v=vs.100).aspx?


@dkayiwa This ticket is actually now pending waiting on  the design decision on how to implement AllergyAPI REST by Darius and Burke. It may have to be completely redone once an approach has been decided on.
see: https://talk.openmrs.org/t/questions-about-resources-in-allergy-ui-module/3750


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10454](https://teamcity.mesosphere.io/viewLog.html?buildId=98592&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:04:01


Interesting.

Clearly if the ck is too low, nothing will happen.
And if the parameter is sensitive, a ck which would be too high will also be wrong.

Here is the rule of thumb I used for this one, once I saw the default value did not worked.

The "exact" range would be for mg (5, 22)  and for eg (15, 32)
I took (22-5) = (32-5) = 17 and divided by 3.
So my ck was manually changed to 6.


IIRC _G.ValkyrieC over _G.Valkyrie is not required, unless in play solo.


hmmm with this patch is not any more possible to build with android-eabi- right?


How does this change it?


derp - just realized i should read this from the config (this won't work in production like this)


+t ia2 -ae still_exp 100 1000 1000


This was removed in #449.


I prefer them sorted by descending date order -- like my online banking transactions. What if we made that an option on the profile? Maybe for now, we just go with this and put profile option in the backlog.


with this one : https://github.com/andip71/boeffla-kernel-cm-bacon/commit/acb3839be59dcf4d88539d0eb67ecbfe10eee45b

Do you know what to change to be compatible again with android-eabi ? thanks


If the condition doesn't trigger, it's better to remove it instead of adding a todo about removing it. :-)


Remove the -fno-pic and try again.


good call on both accounts


This looks like an edge case for what to do with a blank board that should exist in `get_best_move`


A general comment - often, only the first line of the commit message is visible, so it should contain a summary of the commit if the commit message is longer.

If there are multiple changes, it's best to split them in multiple commits; sometimes it's a bit entangled and possibly not worth the effort, but here it'd have been quite easy.


you should add empty CR/line at the end of files to avoid diff on the latest line


It looks like the original author did not want to keep resetting the cache for each item in list. But rather decided to do it once after iterating through the list. Have you thought about this? :)


Manage LAN/Manage LAN/Library Class/WakeOnLan.cs

это же дичь, Игорь, мы же с тобой её исправляли)


Avoid unused local variables such as '$remember'.


// Change the login email - FIXME: Shouldn't this be in the auth section?


* TODO: Refactor the validator to reduce duplication, maybe move the askWithValidation to an external library.


Any reason not to just put this on master?


你的代码不对


Зачем это условие нужно?  - Выведи все твиты, которые были созданные не позже чем сейчас?


This seems harmful as we don't know anymore what subset of questions (instead of the complete test set) are we benchmarking. What differences are there in the sets?


please do not delete QObject instances with parent set. It can break things in signals/slots.


i didn't explain correctly.
> so what if i use the protocol as the id for m3u8 and f4m and the old format(protocol-quality) for direct links?

i mean using protocol and quality variable from the the json-data like this.
```
python2 __main__.py -F 'http://www.srf.ch/play/tv/10vor10/video/gedraenge-auf-den-wenigen-pisten?id=743f1f80-4c3a-4132-b5e3-e2bdc6aa97b8'
[SRGSSR] 743f1f80-4c3a-4132-b5e3-e2bdc6aa97b8: Downloading JSON metadata
[SRGSSR] 743f1f80-4c3a-4132-b5e3-e2bdc6aa97b8: Downloading f4m manifest
[SRGSSR] 743f1f80-4c3a-4132-b5e3-e2bdc6aa97b8: Downloading m3u8 information
[info] Available formats for 743f1f80-4c3a-4132-b5e3-e2bdc6aa97b8:
format code    extension  resolution note
HTTP-HLS-meta  mp4        multiple   Quality selection URL
HTTP-HLS-30    mp4        unknown      30k , mp4a
HTTP-HDS-133   flv        unknown     133k
HTTP-HLS-133   mp4        320x180     133k , avc1,  mp4a
HTTP-HDS-333   flv        unknown     333k
HTTP-HLS-333   mp4        480x272     333k , avc1,  mp4a
HTTP-HDS-659   flv        unknown     659k
HTTP-HLS-659   mp4        512x288     659k , avc1,  mp4a
HTTP-HDS-1323  flv        unknown    1323k
HTTP-HLS-1323  mp4        640x360    1323k , avc1,  mp4a
HTTP-HDS-2123  flv        unknown    2123k
HTTP-HLS-2123  mp4        960x544    2123k , avc1,  mp4a
HTTP-HDS-3619  flv        unknown    3619k
HTTP-HLS-3619  mp4        1280x720   3619k , avc1,  mp4a
HTTP-SD        mp4        unknown
HTTP-HD        mp4        unknown    (best)
```


Условие говорит - выведи последние опубликованные твитты, сортировка по id и так по дефолту работает, зачем тебе это надо?


Close #14


Ok! bien! faltan los tests por hacer! vamos a ponerlos antes de aceptar el pull request =D


Closes #14


Выноси по возможности весь JS-код в отдельный файл, например script.js и подключай его на страницу.


TeamCity Reaver Project :: ReaverLib :: Test Build with Clang [Build 89](http://ci.reaver-project.org/viewLog.html?buildId=1396&buildTypeId=reaverlib_TestBuildWithClang&guest=1) is now running


@rohman21 did you try to lock the expo and use the native timelapse?

take a look at my pr #45, it can help you with it.


TeamCity Reaver Project :: ReaverLib :: Test Build with Clang [Build 89](http://ci.reaver-project.org/viewLog.html?buildId=1396&buildTypeId=reaverlib_TestBuildWithClang&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:08


Fixes #14


jQuery после подключения реализует удобный алиас - $.
Поэтому достаточно писать $.ajax({...});


We don't need this line anymore, do we?


But a good proportion of BB editors will initially be MB editors, so I felt it would make sense to have this section to help them adjust. It may not be necessary if the guidelines move closer to what MB has.


Hey @billtomczak, thanks. Now I see this as a pattern to follow :)


Why not just use exactly same `format_id`s as before?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1076](http://teamcity.monogame.net/viewLog.html?buildId=12979&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Ты подключил jQuery, но почему-то все равно работаешь с элементами через нативный JS.
Можно было бы написать так: $('#' + result_id).html(response);


TeamCity Reaver Project :: ReaverLib :: Test Build with Clang [Build 90](http://ci.reaver-project.org/viewLog.html?buildId=1397&buildTypeId=reaverlib_TestBuildWithClang&guest=1) is now running


@carlossg @michaelneale could you please update it to point to the plugin page? This currently makes that plugin having an entry in https://github.com/jenkinsci/backend-update-center2/blob/master/src/main/resources/wiki-overrides.properties#L33

Thanks


TeamCity Reaver Project :: ReaverLib :: Test Build with Clang [Build 90](http://ci.reaver-project.org/viewLog.html?buildId=1397&buildTypeId=reaverlib_TestBuildWithClang&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 83 Build time: 00:00:11


ERROR: modpost: Found 11 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
To build the kernel despite the mismatches, build with:
'make CONFIG_NO_ERROR_ON_MISMATCH=y'
(NOTE: This is not recommended)
/home/jorge/new/msm8974/scripts/Makefile.modpost:98: recipe for target 'vmlinux.o' failed
make[1]: *** [vmlinux.o] Error 1
Makefile:938: recipe for target 'vmlinux.o' failed
make: *** [vmlinux.o] Error 2
cp: cannot stat ‘/home/jorge/new/msm8974/arch/arm/boot/zImage’: No such file or direc

Still get this error .


I think you do right:)


`get_date` is meant to be used to get the most relevant date for a transaction. If the transactions has been completed, it's the `end_dt`, otherwise it's the date it's scheduled for (`start_dt`), else creation date. It's meant to be a display helper for all `BaseTransaction` subclasses, guess it would make it clearer to call it `get_display_date`.

If not a `BaseTransaction` method, what would be the best way to make it available to all of its subclasses? Subclass 'BaseTransaction' and have new transaction classes inherit from it? Or create a template tag?


ill give it a try


Is this TODO still relevant? It looks like LeftOp and RightOp are handled elsewhere.


We seem to have a problem right here, don't we? The order of people in actors.txt and other files changed, therefore the ordering of questions changed.

Could it be that you have a different locale settings and therefore the sort produces a different order? What does the `locale | grep LC_COLLATE` command output look like? Mine is LC_COLLATE="en_US.UTF-8", perhaps we should add

    export LC_COLLATE="en_US.UTF-8"

to the beginning of gen.sh?


Лучше всего при использовании jQuery использовать селекторы в функции, нежели вызывать функции по событиям в HTML. То есть в HTML надо удалить onchange и вызов функции, а в .js файле после загрузки DOM-дерева просто повесить событие на элемент по селектору, например вот так:
$('select[name=status]').on('change', AjaxFormRequest);
А параметры в функцию можно передать уже через теги data-name, которые получить через элемент $(this), либо же вызвать функцию уже в функции:
$('select[name=status]').on('change', function () { AjaxFormRequest('messegeResult', 'formMain', 'scripts/ajax.php'); } );


Тут написано, что если если у пользователя есть твитты без userId, тогда он у него нет ни одного твитта. Это не правда. Запрос должен звучать так - выведи пользователей, к-во твиттов которые равняется 0.


Thanks! I'm not sure we really needed the gen.sh changes, but they don't hurt either. :-)


Change this to:
float priceRatio = static_cast<float>(classRatio * qualityRatio) / 10000.0f;

Since classRatio and qualityRatio are int values, and the 10000 is int, the resolved value BEFORE being assigned to priceRatio will be int and therefore will have the decimal stripped.  Example: if classRatio was 100 and qualityRatio was 90, before assigning to priceRatio the value would be 0 (100 * 90 = 9000, int 9000 / int 10000 = 0 as int always rounds down)


The name could be better. This function appends the `tail argument to the `head function by following the `head.otherwise "link" until an Empty() function is found. Perhaps, simply `appendFunction would be clearer?


indent.


API/Worker is not used during font testing


extra space.


If you do change the board to init to all nil, this will have to change. Maybe do it more like a search?
```ruby
# I'd gather all potentials paths before even checking for winners
potential_win_paths = [
  [b[0],b[1],b[2]]
, [b[3],b[4],b[5]]
...
...
]

# then you could do something like the following to look for a winner
potential_win_paths.find(['X','X','X'])
potential_win_paths.find(['O','O','O'])
```

It might feel kinda weird, but its on the principal of separating data from logic. The more I do that, the easier I find it is to test.


Зачем тебе в этом запрос jion-ы? Выбери к-во комментов комменты, сгруппированные по twitt_id.

Сейчас же ты считаешь к-во комментов сгруппированные по комментам.


Variables are good code smells, `gather_potential_win_paths` could very well be its own method.


Can you please add info about how was it produced to the commit message? What commitId of YodaQA generated the questionDump (was it on the master or d/movies branch? they'll produce slightly different output; d/movies is preferrable for us now)?


Can you take a look that we don't have a memory leak here? Memory is allocated in extractObjectDefinitionTermMembersAndOperators, and released in `pullMembersAndOperatorsToTop...


@kinow please fix that to point to the wiki page. W/o it, the plugin needs a wiki-override entry in the update center code generation. Thanks!


Где здесь к-во?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10455](https://teamcity.mesosphere.io/viewLog.html?buildId=98596&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:07:19


そんな裏協定があったのですか、、、勉強になりました。
有難うございます。
ちょっとよろしくない仕組みですね。


The next step is to queue these method calls and execute them once the SDK ready callback fires. Maybe we could wrap everything in a new `this.onReady` method?

```js
setVolume (fraction) {
  this.onReady(() => {
    this.player.setVolume(fraction * 100)
  })
}
```

Right now I'm thinking my initial calls to `setVolume` will fail, and the player will initialize with the incorrect volume set.


Не правильно.


All exports of the pdfjsCoreFonts are attached to the window at the unit_test.html

(In the future we might refactor to use e.g. `pdfjsLibs.pdfjsCoreFonts.`, but now it's not possible due to common data used by the several tests.)


Change to
float divisor = ((itemProto->GetClass() == ITEM_CLASS_WEAPON || itemProto->GetClass() == ITEM_CLASS_ARMOR) ? 284.0f : 80.0f);


Change to:
float tempLevel = (itemProto->GetBaseItemLevel() == 0 ? 1.0f : itemProto->GetBaseItemLevel());


В этом запросе нужно использовать Group_Concat функцию


Change to:
float tempQuality = (itemProto->GetQuality() == 0 ? 1.0f : itemProto->GetQuality());


Не правильно, нужно вывести к-во поство, к-во тегов которых равняется 0.


Change to:
buyPrice = tempLevel * tempQuality * static_cast<float>(GetBuyModifier(itemProto)) * tempLevel / divisor;


I see now, thanks!


These could be clearer using custom `Reads`/`OReads` (and allow to avoid unsafe `.get` on lookup result)


Зачем тебе здесь join?


> why do you think they can't contain different qualities?

```
[
            {
              "@quality": "HD",
              "text": "http://srfvodhd-vh.akamaihd.net/z/vod/10vor10/2015/12/10vor10_20151228_215057_v_webcast_h264_,q10,q20,q30,q40,q50,q60,.mp4.csmil/manifest.f4m"
            },
            {
              "@quality": "SD",
              "text": "http://srfvodhd-vh.akamaihd.net/z/vod/10vor10/2015/12/10vor10_20151228_215057_v_webcast_h264_,q10,q20,q30,q40,.mp4.csmil/manifest.f4m"
            }
          ]
```
from the url you can see that the HD manifest conatin 2 additional formats(q50,q60) and the other are the same in both of the manifests so there is no benefit of extracting both of them.


なるほど！機能的には翻訳可能にするところだと思うんですよ。でも英語の文章のほうがおしゃれというか推奨したい気がしますね。なんかすいません。。。


### Missing semicolon.

```
return "Hello, World!"
                      ^
```


### Use '===' to compare with 'null'.

```
if (bla == null) return;
        ^
```


Agreed, thanks!


Это обычная many to many таблица, зачем тебе в ней id?


So, I compile with arm-linux-androideabi-4.9.

What do you try to use? Afaik there is no eabi 4.9 version available at all.


I like to have a separate `runner.rb` that starts the process as intended to be used by a human.

Once you pulled these two lines into their own file, this whole module could be included without a problem into any test suite.


For issue #10


@mislav

My original branch for the version-name/version-origin hooks included a commit that extracted the `create_hooks` helper function to the test_helper file. Prior to this removal, there was a [single use](https://github.com/rbenv/rbenv/blob/4fde4ecbaf1e1f3082c9275a6f244c70527ad497/test/version-name.bats#L39) in `test/version-name.bats` and a [single use](https://github.com/rbenv/rbenv/blob/4fde4ecbaf1e1f3082c9275a6f244c70527ad497/test/version-origin.bats#L49) in `test/version-origin.bats`. But there were [8 invocations](https://github.com/rbenv/rbenv/blob/4fde4ecbaf1e1f3082c9275a6f244c70527ad497/test/hooks.bats#L5-L8) in `test/hooks.bats`. And the same function is already inlined in [exec](https://github.com/rbenv/rbenv/blob/4fde4ecbaf1e1f3082c9275a6f244c70527ad497/test/exec.bats#L46-L69), [rehash](https://github.com/rbenv/rbenv/blob/4fde4ecbaf1e1f3082c9275a6f244c70527ad497/test/rehash.bats#L108-L114) and [which](https://github.com/rbenv/rbenv/blob/4fde4ecbaf1e1f3082c9275a6f244c70527ad497/test/which.bats#L104-L110) tests, and could be reused there.

Re-use across 6 test files, I think, is worthy of extraction to the common test_helpers.

Would you be open to another PR that completes this?

Alternatively, instead of moving `create_hook` to the test_helper shared helpers, the hook-specific tests from version-name, version-origin, exec, rehash, and which could be moved to `test/hooks.bats`. This would keep the create_hook helper local to the tests that use it and keep all the hook tests together.


I think you should mention here the case when batch_limit and batch_flush_timeout are both not set.


Все переменные и методы по PSR-2 должны именоваться в camelCase - $hallsList. Как же ты проверял это дело в CodeSniffer-е?


Ah, I see. Cheers.


It isn't the problem.
On AOSPARADOX I can't keep time between reboots if I don't do this


You don't need to worry about the uint32 casts and ceil above, and can omit that.  lines 710 through 714 can simply be:
float basePrice = (buyPrice * stackCount * priceRatio) / (itemProto->GetClass() == 6 ? 200.0f : static_cast<float>(itemProto->GetBuyCount())) / 100.0f;


you should either be using a shared_ptr here, or you should allocate this on the stack and pass to the relevant functions. using naked pointers like this is very error prone.


Thanks for the effort - however, if the set of synthetic questions changed, that's something we really need to deal with! Right now, the set of synthetic questions does not coincide with the syn- questions in moviesE. This probably caused the desyncs you had to deal with later in the other scripts. However, next time we update our dataset (to, say, moviesF), this will also cause a lot of confusion. Per se, this is not a big issue if we properly roll over our dataset to use the new set of synthetic questions, but we should be sure we fix this for good and not hit the issue the *next* time we regenerate the synthetic dataset. Another thing is that the question IDs should be globally unique, but right now different questions share the same ID. If we decide we need to change the set of questions, we'll need to bump the generation counters for the syn qId.

Changing the set of questions in our benchmarking datasets is something non-trivial. So, right now, I'd like to hold this off and figure out precisely what's going on. For that purpose, I've force-rewound master back to 82c70dd (Modification of generators of synthetic questions so they are including concepts, the previous commit to this one) and the rest of commits now live on branch f/synth-reproducible. I'd prefer we retired that branch and instead try this again and more carefully; but you might want to cherry-pick some of the later commits, e.g. the sorting fix.

I think the first step is to figure out if the cause for all this mess is the sorting locale problem - can you please check that?


Volume should be fine, as the [volume is already set when players become ready](https://github.com/CookPete/react-player/blob/master/src/players/Base.js#L37), but this is not the case for seeking. Perhaps we could set `this.seekOnReady` in the method if `!this.isReady`, then when `onReady` is called, check to see if `seekOnReady` is set, and `seekTo` if so..


They may be hosted on different cdns/some may be broken/whatever.


it's exactly the same the value defined in `sol-util.h`.  About the comment explaining it, we already have the comment above explaining, this value is arbitrary AFAIK, as you can see the `20` there,


The function `isBuildForScala211` does no longer work with the SBT build, and should be removed entirely. It is obsolete because the Scala version is now encoded the value of `TARGET_FOLDER`.


COMMAND!


Try: uint32 range = static_cast<uint32>((basePrice * 0.04f) + 0.5f);
This will properly round to the nearest value, and suppress the compiler warning about float-to-int conversion.


Обрамляй такие вещи по возможности так:
header("Location: {$local}?page=admin");
Чтобы было явно видно, что здесь идет подстановка значения переменной.

Потому что такой вариант будет пиздецом если строка будет чуть сложнее:
header("Location: $local?page=admin&category=$category&mode=$action");


TeamCity LabKey :: LabkeyModules15.3 :: Git postgres 9.4 [Build 82](https://teamcity.labkey.org/viewLog.html?buildId=293920&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 28 (15 new), passed: 264, muted: 1 Build time: 01:33:33
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testDatasetExport: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testImmuneSpaceStudySubset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudySummaryWindow: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCards: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelection: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testNavigationDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testBackDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCardStudyLinks: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testFinderWebPartAndActionShareFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnStudyNavigator: <no details avaliable>

##### there are 18 more failed tests, see build details
```


I do consider this a scope change, since the intent of this PR is that each commit does exactly what it says it does, plus or minus whatever the NetBeans formatter does on its own.  Let's add this issue to another ticket (or, if there isn't a ticket that we can piggyback off of, create another code cleanup ticket).


Do explicit casts here to avoid compiler warnings.  IE:
buyp = urand(static_cast<uint32>(_basePrice - range), static_cast<uint32>(_basePrice + range)) + 1;


* TODO: Refactor the validator to reduce duplication, maybe move the askWithValidation to an external library.


sorry andi in case i confused here. if i compile with arm-linux-androideabi-4.9. from here: https://bitbucket.org/jgcaap/arm-linux-androideabi-4.9-a15

gives me : warning: unwinding may not work because EXIDX input section 33 of net/built-in.o is not in EXIDX output section

but compiles just dont know if is a healthy warning to ignore.

when i compile with:
https://bitbucket.org/jgcaap/arm-eabi-4.9-a15

Gives section missmatch error.

I've done make debug and came this:

  MODPOST vmlinux.o
WARNING: vmlinux.o(.data+0x19b18): Section mismatch in reference from the variable gdsc_driver to the (unknown reference) .init.data:(unknown)
The variable gdsc_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x19bd8): Section mismatch in reference from the variable krait_power_driver to the (unknown reference) .init.data:(unknown)
The variable krait_power_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x19c28): Section mismatch in reference from the variable krait_pdn_driver to the (unknown reference) .init.data:(unknown)
The variable krait_pdn_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x19cc8): Section mismatch in reference from the variable qpnp_revid_driver to the (unknown reference) .init.data:(unknown)
The variable qpnp_revid_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x19d18): Section mismatch in reference from the variable msm_cpu_pm_snoc_client_driver to the (unknown reference) .init.data:(unknown)
The variable msm_cpu_pm_snoc_client_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x19d68): Section mismatch in reference from the variable msm_cpu_pm_driver to the (unknown reference) .init.data:(unknown)
The variable msm_cpu_pm_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x19db8): Section mismatch in reference from the variable msm_cpu_status_driver to the (unknown reference) .init.data:(unknown)
The variable msm_cpu_status_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x1a17c): Section mismatch in reference from the variable msm_rpm_device_driver to the (unknown reference) .init.data:(unknown)
The variable msm_rpm_device_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x1a2f0): Section mismatch in reference from the variable cpu_modes_driver to the (unknown reference) .init.data:(unknown)
The variable cpu_modes_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x1a340): Section mismatch in reference from the variable system_modes_driver to the (unknown reference) .init.data:(unknown)
The variable system_modes_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

WARNING: vmlinux.o(.data+0x1a390): Section mismatch in reference from the variable lpm_levels_driver to the (unknown reference) .init.data:(unknown)
The variable lpm_levels_driver references
the (unknown reference) __initdata (unknown)
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console

To build the kernel despite the mismatches, build with:
'make CONFIG_NO_ERROR_ON_MISMATCH=y'
(NOTE: This is not recommended)
/home/jorge/new/msm8974/scripts/Makefile.modpost:98: recipe for target 'vmlinux.o' failed
make[1]: *** [vmlinux.o] Error 1
Makefile:938: recipe for target 'vmlinux.o' failed
make: *** [vmlinux.o] Error 2

xD that's why i asked if you were able to compile without that warning.


worked but sometimes it gives error when the page is on error 404.
you can keep it for now or you can or you can change the ul value of weasel.php line 100 by adding
$_DATA['menu'] = '<ul class="nav navbar-nav">';           and remove
$_DATA['menu'] = '<ul>';

either ways it works


mainの画像を必須とするvalidationを作りました。
ベストなやり方ではない気がしてます。
もし他にオススメの方法があったらヒント下さい！


Similar to above about explicit cast
bidp = urand(static_cast<uint32>((basePrice - range) + 0.5f), static_cast<uint32>(basePrice + range + 0.5f)) + 1;


Yeah it gets a little weird. I'm not sure i'd always want the command to go through if the SDK loads like ~2 seconds later...


#_# Lol


in all the urls that i've tested i find the manifests use the same host they are diffrent only on the number of formats.
but no problem i will return the old format.


ul class="nav navbar-nav"
and remove
ul


Package `it.unipd.math.pcd.actors.impl` does not exist.


sometimes, but not on any libvdpau-sunxi channel


Ok, I never tried an eabi 4.9 toolchain, as I did not find any a while ago.
I do not have rewind errors with my toolchain here, but I removed -fno-pic and also use bfd linker, then it seems to work.

I know zanezam also had issues with the mismatches when he recompiled with his various other toolchains. But he fixed the mismatches in code. I copy him in, maybe he can point you to the commit...
@zanezam: Can you help?


Гем aasm предоставляет возможность валидировать устанавливаемые значения состояний?


@JustAkan 안그래도 틀럭 고정되는 원인이 뭔지 도통 감히 안잡혔는데 감사합니다.


@micahsaul This looks great! Would you mind if I solicited feedback from #dev re: the tool choices? Or is it too soon?


No it's not. The number on `sol-util.h` has 6 zeros, the one here has 9...


put comments above these helper functions to explain what they do.


При инициализации объекта state автоматически проставиться в initial state, поэтому в фабрике нет смысла прописывать.


I have a lot of C++ experience, and can help with that-- But I'm not a TrinityCore maintainer, so take my project-specific convention notes with a grain of salt.

1. [C++] Be careful about implicit casts from int to float.  I usually do explicit static_cast on all values that step up or down exactly where I intend, but I didn't markup the code above for that because C++ convention does do implicit casts.  I called out where it it was a problem though.
2. [Convention] I'm pretty sure that the underscore (_) suffix on values is only to be used on private/protected class member values.  Local method variables should just start with a lower case character (sellPrice instead of _sellPrice).  If they extend beyond function scope, that's when you add the underscore.  I do see what you did there as having two versions of the same value for the changes down on lines 712.
3. [C++] Note that when finally converting back from float to int, there's a + 0.5f being added.  C++ always does round-down through decimal truncation (1.9f => 1 int).  Adding 0.5f is a fast way of performing proper nearest-neighbor rounding ONLY for positive float values.
4. [General] Beyond that, look at anywhere else those config values may be being used.  I think this is the only spot though.

Overall, you had it down great.  Nice.  It'll be cool if this area of code gives a more accurate value.


use a let to avoid count-initial-repeat twice?


extra space.


TeamCity LabKey :: LabkeyModules15.3 :: Git postgres 9.4 [Build 81](https://teamcity.labkey.org/viewLog.html?buildId=293884&buildTypeId=LabkeyModules153_GitPostgres) outcome was **FAILURE**
Summary: Execution timeout (new); tests failed: 159 (145 new), passed: 30 Build time: 04:01:09
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyColorStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyStudyAndTreatmentVars: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyLogAndLinearScales: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.DataFinderTest: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testDatasetExport: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testImmuneSpaceStudySubset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudySummaryWindow: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyCards: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelection: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testNavigationDoesNotRemoveFinderFilter: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelectingEmptyMeasure: <no details avaliable>

##### there are 149 more failed tests, see build details
```


thanks andi you are amazing :D


I prefer this way too.


Hi, I had a problem with /opt/smartdc/marlin/node_modules/manta/lib/client.js:signRequest being called with opts.sign == {}, and I patched it in an older version of signRequest like so:

```javascript
function signRequest(log, opts, cb) {
    assert.object(opts, 'options');
    assert.object(opts.headers, 'options.headers');
    assert.func(cb, 'callback');

    if (!opts.sign || Object.keys(opts.sign) == 0) {  // make sure to catch an empty sign object
        return (cb(null));
    }

    assert.func(opts.sign, 'options.sign');

    var rs = auth.requestSigner({
        sign: opts.sign,
        mantaSubUser: true
    });

    // Force 'date' header to contain the current datetime in order to prevent
    // signature authorization clock skew.
    opts.headers.date = rs.writeDateHeader();

    rs.sign(function (err, authz) {
        if (err)
            return (cb(err));
        opts.headers.authorization = authz;
        return (cb(null));
    });

    return (null);
}
```

Is your fix here going to catch an empty object as well?


I assume this is due to a redcarpet issue that I've seen on RubyDoc.  See --

* rb file - http://www.rubydoc.info/github/MSP-Greg/SketchUp/master/SUMD_List
* raw - https://raw.githubusercontent.com/MSP-Greg/SketchUp/master/lib/su_info/sumd_list.rb

It seems that md files are intermittently affected  --

* md file - http://www.rubydoc.info/github/MSP-Greg/SketchUp/master/file/README.md
* raw - https://raw.githubusercontent.com/MSP-Greg/SketchUp/master/README.md

Oddly, same file but different url often renders correctly --

* md file - http://www.rubydoc.info/github/MSP-Greg/SketchUp/master

I've never seen the issue using my local system, which has the current YARD & Redcarpet code, only on RubyDoc.  The telltale indicator is that the header row is shaded, along with the first tbody row.

I have the following in my git .yardopts
```
--markup markdown
--markup-provider redcarpet
```

Greg


I'll need a min.  Having a problem with my markup showing up odd.


I was just going to let those sit until we update those metadata files, but good catch.


console.log(d3.scale)
color = d3.scale.linear()
    .domain([1, 500])
    .range(["red", "blue"])
for(var i = 1; i < 500; i++) {
  var band = document.createElement('div');
  band.style.background = color(i);
  band.style.width = '100%';
  band.style.height = '1px';
  document.body.appendChild(band);
}


Indeed it doesn't.
So, I prevented snowballs to collide with other snowballs belonging to the same thrower.
https://github.com/MinetestForFun/server-minetestforfun/commit/9ede33a7c380b68559a48e549a5751381c96ee78


These two don't need to be converted here, they will automatically be converted inside `ScalarValue.Create` called by `Structure.FromPrimitive` below.


Can you sign up on slack and give me your email so I can invite you?

[Slack](https://slack.com/)


How often are account credits going to exist? Thoughts on hiding this column when there are no account credits, rather than using a flag?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1076](http://teamcity.monogame.net/viewLog.html?buildId=12979&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 555, ignored: 6 Build time: 00:29:07


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1077](http://teamcity.monogame.net/viewLog.html?buildId=12983&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Просто find. Он хотя бы exception выкинет, если не найдёт.
find_by_id и другие скоро будут deprecated. Поэтому find_by(id: params[:task_id]) либо where(...).first


Want to filter with an empty filter, but I'm required to give [] whilst Collection->find has a default $filter of [].


Translators call: @sbenejam @tornel @lachmex @plugz @janosvitok @kripton @joepadmiraal @jeromelebleu

These are 2 new files with information that are exposed to the Linux software managers. (more info here #739)
If you have time, can you please add the translation in your language ?

Thank you very much !


It would be really great to support PHP-CS-Fixer again by static review @sjparkinson !


i think i found:  https://github.com/zanezam/boeffla-kernel-cm-bacon/commit/ac9f60470613541b80630408e6893a838bd5b96e

is it safe to do that change? It is preciselly the 11 mismatches.


Great Job!


It's been quite awhile since I looked at this. I think it may have simply been defensive programming. There's no reason to create the reloadService if it's already created.


@olegz what is unclear?


Give it a go :)


nice :+1:


This change I'm pretty sure I don't want.
In the current wollok version you must explicitly tells "return" so it would be

```xtend
method getNombre() { return "pepita" }
```

Anyway, I think that what we need to discuss or address is a way to activate/deactivate this feature. But I do want to have it at least not for the student but for me :P or teacher's code, etc.

Agree ?

Can we delete this branch to clean up then ?


Incidentally, now that we're compiling these things on client, it's now okay to use `let` and other post-ES3 features in `data/`.


that's true, i have confused with NSEC_PER_SEC, sorry !


Http-метод get не подходит под методы start и finish. Как вариант, patch или put.


^[a-zA-Z0-9.\-_@]+$ can be replaced with ^[\w\d.\-_@]+$


btw you use neon optimizations right?


Updated notes.  Anywhere you see the static casts as static_cast< type >, remove the spaces around type.  If I don't put the spaces, it seems that github markdown removes the type.  No idea why.


=D
-ETOOMANYZEROES


`pushd` and `popd` still not in busybox? :disappointed:


typo, "tom@..."


А, что, _paths из Routes не работают?


I'd prefer a blank line before the final comment.


I'm not sure I fully understand your question. Do you want to know when it will have more than 2 siblings in this context? If so, AFAIK only assignment inside function triggers this, which is what this PR meant to fix. A slightly cumbersome way to reproduce this is:
```r
filename <- tempfile()
cat(file = filename, "fun(a=1)\n")

# load all private/public funtions
devtools::load_all()

source_expressions <- get_source_expressions(filename)
parsed_content <- source_expressions[[1]][[1]]$parsed_content
parsed_content
siblings(parsed_content, parsed_content[parsed_content$text == '=', "id"], 1)

unlink(filename)
```
which gives
```
> parsed_content
   line1 col1 line2 col2 id parent                token terminal text
11     1    1     1    8 11      0                 expr    FALSE
1      1    1     1    3  1      3 SYMBOL_FUNCTION_CALL     TRUE  fun
3      1    1     1    3  3     11                 expr    FALSE
2      1    4     1    4  2     11                  '('     TRUE    (
4      1    5     1    5  4     11           SYMBOL_SUB     TRUE    a
5      1    6     1    6  5     11               EQ_SUB     TRUE    =
6      1    7     1    7  6      7            NUM_CONST     TRUE    1
7      1    7     1    7  7     11                 expr    FALSE
8      1    8     1    8  8     11                  ')'     TRUE    )
> siblings(parsed_content, parsed_content[parsed_content$text == '=', "id"], 1)
[1] "3" "2" "4" "7" "8"
```


можно просто create писать без FactoryGirl


Let's say.. I have not changed it. So I use the same as CM.

Never bothered checking it, as I am not a believer in that optimizations and any significant difference (honestly).


DRY. Повторение строки в 79 строчке. Вынести в отдельную переменную на случай изменения.


Можно использовать также сиквинсы для генерации данных.


@zubair-arbi: Excellent. I didn't realize we could do this in the docker-based CI builds.


Wanna try something which actually works ? :P


Add a `.gitignore` file which mentions the `TOKEN`. Or allow to read the token from an environment variable.

Consider to use [Foreman](https://github.com/ddollar/foreman)/Forego to manage your application. Or move to application to a PaaS offering so that the usage is more encapsulated.


Hello, no, I have no problem with the torch, is working well, at first Antocha closed for a few seconds but change the kernel to all 0s and everything started working well, in any case, the correct commit is this in Gerrit de cyanogen and have a flattened in the same tree but in another branch, sensors, camera, GPS works perfectly

https://github.com/Arc-Team/android_device_htc_evita/commit/0628bafd7dd0ae5746da447fb3e2b117b8040ed5

http://review.cyanogenmod.org/#/q/topic:htc-s4-m


this temporary value is never stored.  I'm going to change it to reference the class field instead.


Во всех запросах в тесте повторяются эти 3 строчки. Вынести в общую переменную их. DRY.


good


Some results come back as "30" or "85" with no dot. Turn them down.


I'm getting the same error?

@micnguyen were you able to solve it?


+# [ontouchstart](https://github.com/ontouchstart)


The fixed worked :D happy


For readability I'd like to have this more like:

    assert_timer_expired = 0;
    if (mrg_grp->flags & MRTF_ASSERTED)
        assert_timer_expired = TIMEOUT(mrt_grp->assert_timer);

The `&& mrt_grp->flags & MRTF_ASSERTED` statement is ambiguous as it stands now,
should at the very least read `&& (mrt_grp->flags & MRTF_ASSERTED)`.


Same here.


If you are only comparing distances, then use getPosition.distanceSquared(this.getTransform.getPosition)) <= (distance*distance) it avoids a sqrt which is infamous for it's performance hit.


Yes that is what I was asking, thank you for the example.

Technically I don't think this should be called assignment within a function, it is really just using named arguments in a function call.

Note you actually can do assignment within a function call with `<-`
``` r
a <- 1
print(x = a <- 2)
#> [1] 2
a
#> [1] 2
```
This is usually discouraged in practice as it is easy to overlook the assignment.


Shouldn't setting this flag be inside the if() statement?


it has be fixed else where because leaving the state here causes other issues. can you provide a sample to reproduce?


hooray, no more magic numbers


(Going through some of your changes now).

Do you mean in the code, or in the paper?  In the code, we use the definitions from the Category library, which are complete.


@maxGimeno: I don't see how this fixes something. To me it looks like you move some code to a function and call this function instead of the code. Could you elaborate?


Screenshot in the commit message: pro move.


Page https://github.com/openbay/openbay does not exist, but page https://github.com/isohuntto/openbay does.


@mosterta, would be cool if you can join #linux-sunxi on freenode... if you want. it's the faster way to ask some things.


what boot issues did you find ?


… in the paper. Our definition does not have  the unit coherence law. I think I copied the definitions from Selinger’s survey paper which didn’t have or I missed it somehow. Every other definition has the law. —Amr

On Dec 29, 2015, at 5:41 PM, Jacques Carette <notifications@github.com<mailto:notifications@github.com>> wrote:

(Going through some of your changes now).

Do you mean in the code, or in the paper? In the code, we use the definitions from the Category library, which are complete.

—
Reply to this email directly or view it on GitHub<https://github.com/JacquesCarette/pi-dual/commit/1cde2f95dd493a4ddab7be256f25e0d10c92d6ea#commitcomment-15191386>.


Thanks for your comments and advice. Much appreciated.

I made suggested changes and will open a PR + get maintainer feedback for the variable naming conventions. Went ahead and reverted back to no-underscore since I realized I was being an idiot and those variables were not used outside the function though.

I did take a quick look and it seemed like this was the only place those values were being used, at least in the seller specific stuff. I'll look over buyer stuff in the future.

In future, I think using `static_cast<type>` (enclosed in backticks) works for line notes / comments.


> Do you need to add ANY to CHOICES? Or is this just for use in the code?

Just for use as a constant

> (Also, looks like API isn't in CHOICES here, might be intentional)

Yes!  Handling that in a separate branch.


I assume this is due to a redcarpet issue that I've seen on RubyDoc. See --

* rb file - http://www.rubydoc.info/github/MSP-Greg/SketchUp/master/SUMD_List
* raw - https://raw.githubusercontent.com/MSP-Greg/SketchUp/master/lib/su_info/sumd_list.rb

It seems that md files are intermittently affected --

* md file - http://www.rubydoc.info/github/MSP-Greg/SketchUp/master/file/README.md
* raw - https://raw.githubusercontent.com/MSP-Greg/SketchUp/master/README.md

Oddly, same file but different url often renders correctly --

* md file - http://www.rubydoc.info/github/MSP-Greg/SketchUp/master

I've never seen the issue using my local system, which has the current YARD & Redcarpet code, only on RubyDoc. The telltale indicator is that the header row is shaded, along with the first tbody row.

I have the following in my git .yardopts

```
--markup markdown
--markup-provider redcarpet
```

Greg


Hi all,

I fully agree with Ajedrecista and if I had my way, I would have stopped this test already days ago,
since it clearly remained below my expectations. But there are others which refuse SPRT test being stopped on principle, so I think at this point maintainers should decide.
And regardsless of the decision, we also should decide how go on with distinct_iter_11.
Marco suggested me to use TC 10+0.1 for another test, is that ok for a next LTC try?
I also like to discuss whether [0,4] or [0,5] is appropriate for distinct_iter_11.
It introduces a modulo-operator which takes effect when threads are more than 21,
so from that point of view [0,5] is required.
But someone could argue that basically just other matrix-values are applied, so that's somehow actually just a parameter tweak thus [0,4] should be enough.
Since LTC SMP tests take a lot or ressources, IMO this is a relevant question.


Hi @matabele this is the cause of #2174 - your edits removed the field declarations from the top of the file, which breaks the `.tid` format, causing the tiddler to be lost.

I'm guessing this is because of your workflow of editing pull requests directly in the GitHub UI. A downside of that approach is that you lose the chance of testing your changes before submission. That's ok for simple changes, but it is error prone for more complex changes. And here's an example of a simple change with a simple mistake with profound consequences.

It would be great if you were able to get up and running with Node.js so that you can run tests more easily. @tobibeer and others have been through the same rite of passage, and can help and advise.


Glad to help only have limited time for chatting,  email works for me well

Sent from my iPad

> On Dec 28, 2015, at 15:39, Thomas Uster <notifications@github.com> wrote:
>
> @codeservice Totally, if you're in there I'll ask you one. I'll also spend time helping you out with the bug you issues earlier if you want.
>
> —
> Reply to this email directly or view it on GitHub.
>


Fixes #8


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10456](https://teamcity.mesosphere.io/viewLog.html?buildId=98597&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:18


这种不好对齐..


Thank you!


*reception


Thanks to: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797259


Maybe make a note about internal updates to location-descriptor-based APIs? I guess just on `isActive`.


Not the most useful commit I've ever seen...lol


Shouldn't we comment explicitly on this?  It was an explicit design decision to make things be syntactically reversible instead of building-in reversibility.  We discussed this amongst ourselves, wouldn't it make sense to discuss it in the paper as well?


Initialization


In file included from coreclasses.cpp:1:0:
coreclasses.h:348:1: error: expected unqualified-id before ‘using’
make[2]: *** [../../../build/release/Utilities/coreclasses.o] Error 1
make[2]: Leaving directory `/home/travis/build/po-devs/pokemon-online/src/libraries/Utilities'
make[1]: *** [sub-Utilities-make_first-ordered] Error 2
make[1]: Leaving directory `/home/travis/build/po-devs/pokemon-online/src/libraries'
make: *** [sub-src-libraries-make_first-ordered] Error 2

No idea how to fix or what is causing the errors (maybe because Travis is using old versions of Clang/GCC?)


do we need it? because we are using the file to compare it to the newNews we get. for that we will have to again remove the date.


Might be worth linking to the codemods here.


I don't really understand what is the point of plotting the learning curves only every two runs instead of every times


I'd like to temporarily leave this as is in the current master (just moved around), and come back to it soon.  I'd like to have the models only support one product rate per software plan version, since this is all we ever use (YAGNI, etc etc)


TeamCity Reaver Project :: ReaverLib :: Test Build with Clang [Build 91](http://ci.reaver-project.org/viewLog.html?buildId=1398&buildTypeId=reaverlib_TestBuildWithClang&guest=1) is now running


good point,  also on the 3.0 branch we had done something to handle branches surrounded in quotes (to handle branches with colons in them for different repos), i'll pull that back here too.


TeamCity Reaver Project :: ReaverLib :: Test Build with Clang [Build 91](http://ci.reaver-project.org/viewLog.html?buildId=1398&buildTypeId=reaverlib_TestBuildWithClang&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 83 Build time: 00:00:14


Давай не будем на русском вообще писать, это "моветон" :)


It was firing this error:

```
Retrieving speedtest.net configuration...
Retrieving speedtest.net server list...
Traceback (most recent call last):
  File "/usr/bin/speedtest-cli", line 796, in <module>
    main()
  File "/usr/bin/speedtest-cli", line 790, in main
    speedtest()
  File "/usr/bin/speedtest-cli", line 644, in speedtest
    print_('Testing from %(isp)s (%(ip)s)...' % config['client'])
  File "/usr/bin/speedtest-cli", line 146, in print_
    write(arg)
  File "/usr/bin/speedtest-cli", line 111, in write
    fp.write(data)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xea' in position 25: ordinal not in range(128)
```


It's also common practice in python to try to avoid having additional white spaces (where they are not needed)


Hello Mate !

Pushbullet is needed for this ? For OTA's (like the way it is implemented in this project) pushbullet is needed ?


Это проверки можно сделать через Spring MVC аннотации


I don't think that `min-version` should refer to something that doesn't exist. That seems confusing and could introduce problems.

Instead, I suggest setting this to the version number as of this PR.


That's not true!  That is 'functional extensionality', which we don't want.  f=g of course implies f ~ g, but the other direction is where all the trouble lies.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1077](http://teamcity.monogame.net/viewLog.html?buildId=12983&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 555, ignored: 6 Build time: 00:27:34


Just curious, is this addressing issues with eMMC storage, or some other card?


не понял зачем этот метод?


Only if you want to make it fully automatic. But configuring PushUpload just for OTAs is a bit overkill. Read the KrexusOTA README, for OTA to work, you need to edit your hotlinked ota.xml file. PushUpload modifies this file automatically for me (when uploading to BasketBuild) but it doesn't have to be automatic.

This is what I am talking about: https://github.com/krexus/vendor_krexus/commit/bb53d782f6e08ffffcaccc46c0247f080086b791

So, tl;dr: No, PushUpload isn't needed for KrexusOTA to work.


давай избегать таблицу верстку. По свободе - посмотри bootstrup. Это сэкономит нам много времени в будущем.


в последнем:  actions.o: actions.c actions.h


не коммить *.class файлы, нам они незачем


Please keep stylistic consistency here. Elsewhere in the code and in the function itself, the error is recycled. At the end, err1 is declared. Instead, consider redeclaring err, check if err != nil { ... } and then at the end of the function return nil.


Does Amazon's JDBC driver have a different class name or does it provide an org.postgresql.Drive class too?


Hi! This change broke my API documents. Do you think to add additional parameter to a config. I want to read all response as JSON, could it be setting named jsonOutput, and then the code will changed:
 if (!jsonOutput && type === 'get') {
 -          ajaxRequest.url = url + paramToQueryParms(param),
...
Thanks for the apidoc !


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10457](https://teamcity.mesosphere.io/viewLog.html?buildId=98598&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:08:04


No need to export this function (use writeNewFile instead).


huehuheuheu


vfork might be better here than fork, since fork may cause an out-of-memory condition. However you need to make sure that you do not allocate any memory in the child process (avoid the use of std::string).


Umm, shouldn't the engine-dependant animations be just skipped when there's no engine?

I mean:
```
if ( (flag_state & ANIM_FLAG_CLUTCH) && engine != nullptr)
```

Also, what does the ```div++;``` mean?


I'm stopping the test to stop wasting resources.

In the future please think about your expectations BEFORE submitting the
test. SMP tests consume a huge amount resources.

- If you expect the patch to be a killer and want to prove it, you have two
choices: Just measure its ELO value using a fixed game test. Or use
different SPRT bounds, like [0, 8].

- Also for 31 threads, something like 15+0.15 as an LTC is clearly
sufficient.

On Tue, Dec 29, 2015 at 3:48 PM, pb00068 <notifications@github.com> wrote:

> Hi all,
>
> I fully agree with Ajedrecista and if I had my way, I would have stopped
> this test already days ago,
> since it clearly remained below my expectations. But there are others
> which refuse SPRT test being stopped on principle, so I think at this point
> maintainers should decide.
> And regardsless of the decision, we also should decide how go on with
> distinct_iter_11.
> Marco suggested me to use TC 10+0.1 for another test, is that ok for a
> next LTC try?
> I also like to discuss whether [0,4] or [0,5] is appropriate for
> distinct_iter_11.
> It introduces a modulo-operator which takes effect when threads are more
> than 21,
> so from that point of view [0,5] is required.
> But someone could argue that basically just other matrix-values are
> applied, so that's somehow actually just a parameter tweak thus [0,4]
> should be enough.
> Since LTC SMP tests take a lot or ressources, IMO this is a relevant
> question.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/pb00068/Stockfish/commit/02c9544ca4dd30de5f01cd4ac1cae9b73cae8793#commitcomment-15191483>
> .
>


I don't remember but the order of operations was important.  I'm pretty sure it's because parted had not fired


@jkleinsc did you push this directly to master...

![no-no](https://cloud.githubusercontent.com/assets/1319791/12037318/d5e0eff8-ae1b-11e5-9bb6-d1e783df1001.gif)


Thanks, I actually thought `storageToEntity` returns `IEntity` (not that I makes much sense in hindsight though) and never checked the api.  I will update that…


Just use a std::vector<uint8_t> instead. It requires an extra copy & allocation in the VM, but this isn't on the performance-critical path anyways. Don't worry about the extra allocation, the IPC code needs to allocate memory anyways.


Thanks to: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=797259


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10459](https://teamcity.mesosphere.io/viewLog.html?buildId=98600&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:03:46


Thank you for your tip @HybridDog


он вызывает страницу регистрации. Наверное можно по другому вызывать страницу, в которую не передаются никакие параметры?


c/p from `ScrollToBlockOffset` where we do this already.


Just wait a few minutes, I have a orm's solution, it may fit your needs :)


This is unnecessarily inefficient. You can just use `rangeOfComposedCharacterSequenceAtIndex:` to count the composed sequences.


@dkayiwa What is the preferred way in situations like this? How ever this PR will be updated using WebUtil methods. Any way please advice what is the preffered method in situation like this. :+1:


I'm particularly worried about exception safety issues which could cause RawBytes to leak memory.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10458](https://teamcity.mesosphere.io/viewLog.html?buildId=98599&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:10:16


I install it via homebridge-harmonyhub which looks like they use the repo
in package.json

On Tuesday, December 29, 2015, Manuel Alabor <notifications@github.com>
wrote:

> do you install directly via the git repo? the version published on npm has
> a proper version included.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/swissmanu/harmonyhubjs-discover/commit/2a8f1303712c6b6f10eaf49c80f6db7ef21e4336#commitcomment-15188522>
> .
>


@edolstra cool, I hadn't seen that. I should probably amend the Darwin sandboxing mechanism to do the same thing (and ideally share more code between them).


а как мне выводить русский текст пользователю на странице? хранить в отдельном файле, как если б у нас было две языковые версии сайта?


Alright ednhzrd10@gmail.com, invite me


second!!


This should become a static function as it doesn't access any ivars.


TeamCity LabKey :: LabkeyModules15.3 :: Git sqlserver 2014 [Build 80](https://teamcity.labkey.org/viewLog.html?buildId=293886&buildTypeId=LabkeyModules153_GitSqlserver2014) outcome was **SUCCESS**
Summary: Tests passed: 218 Build time: 00:15:59


Looks like our list is starting to shape up. I am going to start working on practicing my skills with adding folders to the repository.


Not everybody knows what a firewall is.


что за переменная?


понял, ок


After a given task is completed, the output of its corresponding TaskIOTab can be closed. The tab itself remains open, but the title font is changed from bold to normal, signaling the task completion to the user.


Please don't catch the `Exception` superclass


@bgruening I like where this is going :)


What if the number is negative?


talloc_freee(NULL) is valid.


Created Logo
Created Login
Created Register
Updated Navigation


Perhaps edit the changelog before publishing this?


quels jeux ?


@cuzz1369 It was necessary. All of the references for Settings.Candy needed this to be located here instead of under Settings.System


Yep, my bad.


Хорошо, посмотрю, как будет возможность. На этот проект будет нанимать отдельного верстальщика, чтобы сверстал все красиво и правильно, но мне тоже не помешает уметь.


If someone started a transaction from within a transaction, they probably expect a nested transaction, which is not supported.  Attempting to start a transaction from within a transaction should result in an error.


ack


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 142](https://teamcity.labkey.org/viewLog.html?buildId=293938&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:18


TeamCity pull requests :: netty [Build 932](https://garage.netty.io/teamcity/viewLog.html?buildId=4355&buildTypeId=pulls_netty&guest=1) is now running


I am very sad to find that this project is not that good compared with what they demoed in the video.

What they claimed in the video is like this:

![image](https://cloud.githubusercontent.com/assets/4420550/12037563/f3626550-ae1d-11e5-9fde-dc99ad27866f.png)

After I merged their project, it looked like this:

![image](https://cloud.githubusercontent.com/assets/4420550/12037573/0d327042-ae1e-11e5-984b-0881a9ba9e18.png)


I think we should completely get rid of the ConnectInterfaces, ConnectTier1Libraries and ConnectTier2Libraries functions. We just need to fill out the gEngineInterfaces/gGameInterfaces variables with the interfaces we want to use.


Thanks, I will merge some of your suggestions in one batch. But don't really need to translate word-by-word. It's just writing English with Chinese characters.


@vcunat @edolstra yeah, just got that error too :frowning:


This has been done on a newer commit including moving other parts to a new PermissionsUtil class :smiley:


To be honest this worries me a little.

```java
		isSelect = false;
		isDelete = false;
		isUpdate = false;
		isInsert = true;
```

Since only one can be `true` it seems that this should be an enum, but it's not quite clear and another one of those `update()` methods might be called...

But more generally I'm not really sure if that renders everything more clearly, especially later on if we want to fine-tune the queries for performance.


Please fix code style. Look at existing plugins and try to make it look similar.


Fix license header. See S2E documentation for what to put there.


Desculpe a minha ignorância, mas overflow em movements o que seria?


Ah, this might be problematic with 08dd527cc7, if it hasn't been resolved yet.


Я сейчас делаю вот так http://www.beingjavaguys.com/2013/05/spring-form-validation.html
Это современный подход или надо использовать аннотации как ты показал?


If MRTF_ASSERTED is set inside if() statement, then also mrt->asserted_oifs shold be set inside same if as asserted_oifs are cleared in timer.c only if MRTF_ASSERTED flag is set. But on the other hand, if mrt->assert_timer is already running (in the case where it is smaller than PIM_ASSERT_TIMEOUT), flag is most likely set previously. Both ways are fine with me, shouldn't change the end result.


Some blank lines would help


Everything is now in the TTS. If you try to install the "suite_gemini" it will hopefully install everything what you need. :)


Having to check whether I am in a transaction everytime I want to start one produces a lot of syntactic clutter. If somebody starts a transaction in a transaction, (s)he gets what (s)he wanted anyway because any error will be propagated to the "outer" transaction which would cause a rollback. Therefore, I don't see any risk in just ignoring the second start of a transaction. I can however, throw a warning to be more transparent what is happening.


Alignment looks random


Thanks; will fix!


Why does this commit touch qemu/rom?


Change you propose is ok to me.


Commit messages should be prefixed by the name of the module/plugin that they affect.


ok


Invite sent


can we change this to `src/` and `src\\` ? Other wise we will not know if the file is in `src/api/c` or `src/api/c++` or any of the backends.


This is ugly. C++ has string class, use them.


You can remove this branch safely. It has little sense after the block syntax changes.

We should discuss if we want implicit returns. In an industrial language, I definitely want it. But here... I don't know. I am not so interested in adding that feature anymore.


I was thinking of proper RST documentation, just like for the rest of S2E, not just a binary PDF blob.


started [a branch](https://github.com/jasonkarns/rbenv/tree/extract-hook-helper). It's not completely functioning yet, but a start.

https://github.com/rbenv/rbenv/compare/master...jasonkarns:extract-hook-helper


Sorry I've been MIA. When I notice issues I first try to fix it, but I'm still working on grasping the Xcode API... not very easy without documentation. I'm definitely impressed with your work!

I'm not sure how much we care about supporting older versions of Xcode. But, my work requires Xcode 6.1 so I can't update. The last time I ran into an issue like this, it was because I was on 6.1 and not 6.4.

Anyway, that being said, this line seems to break the build on 6.1. There is no menuKeyBindingSet and I don't see anything that looks like a quick substitute.


There shouldn't be bug fix commits in a pull request. If you have a bug fix, squash it with the commit that implemented the feature.


The line you are commenting on isn't even part of the PR anymore.


My only concern about using `fetch` is it not being available on all platforms (http://caniuse.com/#feat=fetch). Maybe `$.ajax` would be a more reliable options.


The function API will be printed along with the filename, so that can be differentiated.
The cleanest way to show from src/ would be to use std::string. If this is ok, I can go ahead and change it.


@Brottweiler ninja!!


One more thing, after I shrink the width of the page and re expand it, the content will not go up:

![image](https://cloud.githubusercontent.com/assets/4420550/12037671/2b95d226-ae1f-11e5-91fd-bd6b4c85232b.png)


Why is there obfuscation in some of these classes?

https://github.com/Waterpicker/Paydirt-Washingplant/commit/35eccf83e66903648b096e6d445e5f5315c2164a#diff-b0e58c4e1aaa0b3154d1da8de8ece63aR218


ack


Here to be fully defensive, I'll return
`roundIndex >= MAXIMAL_ROUND_NUMBER`


Ah, OK. You're more into the code atm. than me, I'm fine with the code as it is. Just
thought you used `MRTF_ASSERTED` as a "timer has been started" kind of flag?


По максимуму используй аннотации. Там и patterns можно применять к переменным.


Neću više ništa komentarisati.
Evo, obećavam!!!


Why rename this from IVs to DVs?


I think "IVs" might be clearer since this was doubled from "DVs".


Nvm, I found the actual issue and will create a PR for AlliedModders.


this script is for counting how many data we have on the firebase. It's is not used in the application. :smile:


Hmm. I just tried removing the .so files copied to rb-native/windows folder and SP wouln;t run Gave a rugged load error, so in my case they ARE needed.
> On 29 Dec 2015, at 13:30, Sam Aaron <notifications@github.com> wrote:
>
> Agreed. I didn't need to do copying either. Want to create a pull request with some improvements to this doc?
>
> —
> Reply to this email directly or view it on GitHub.
>


Use native LLVM API for path manipulation (llvm::sys::Path IIRC)


I renamed this one first then it didn't make sense to leave the rest.


you shouldn't remove this


So it should be okay :+1:


I moved the check to where it belongs, on creating site. Even some performance gained.


It's OK to be verbose, no need for DEBUG macro.


Merged here, right now.


It doesn't.


Corrected


This module duplicates file system API offered by LLVM. I would remove it and use standard functions instead.


split added.


pls
![english](http://www.quickmeme.com/img/e2/e2d278c546432c8b0a30ce8982752deb56d0249aff996c923378fdf2524a5981.jpg)


Done


I was thinking of putting this stuff into the S2E makefile


@moonglum the content is up! http://tynn.xyz/

I didn't make changes to the tutorial and the routing basics. I want to do some changes to the Routing Basics but I think that I should ask first :-)

- Maybe we can move the Cookies section to a different guide.
- I would like to add a note that explains that cookies aren't signed/encrypted.
- I don't think it's necessary to use cURL in the guides.
- We can add "See also: HTTP Cookies (https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies)"

Let me know what you think :-)


It's also tricky to reproduce. We are developing on Ubuntu where no problem occurs but target environment AIX encounters this problem but not always.

What we can see in the heapdump is that these Stream$Cons instances
- represent 89% of the heap
- have no parent and therefore should be candidate to GC

We are using by name parameter
The stream is consumed using a while loop with current = current.trail at the end of the loop.

The same piece of code has never encountered OOM with 2.10

if there is any best practices to consume stream let me know.


@rbnpi that's because you used a *different* ruby than the one you packaged in Sonic Pi to install the gems before copying them across. If you use the `gem` binary in the packaged Sonic Pi then you don't need to copy anything across. In fact, you don't even need any of the code in the vendor directory. Using gem like this is something I'm going to look into post `v2.9` to simplify things and potentially provide a path for people pulling in their own gems from Sonic Pi itself.


The diff shows what I mean. Before I knew what the query did, now I have to string it together and it's hidden in a combination of method and constructor calls.

```diff
-            pst = con.prepareStatement("SELECT * FROM " + tableName + ";");
-            rs = pst.executeQuery();
+        	PreparedStatement st = getConnection().prepareStatement(new Query(this)
+            		.select("*")
+            		.from(tableName)
+            		.build()
+            		.getQuery());
+            ResultSet rs = st
+            		.executeQuery();
```

---

Also, this change is not OK. `newOne` and `oldOne` should be added with the prepared statement `setString` method for safety, now it's prone to SQL injection again.

```diff
-            String sql = "UPDATE " + tableName + " SET " + columnName + "=? WHERE " + columnName + "=?;";
-            PreparedStatement pst = con.prepareStatement(sql);
-            pst.setString(1, newOne);
-            pst.setString(2, oldOne);
+            PreparedStatement pst =
+            		con.prepareStatement(new Query(this)
+            		.update()
+            		.from(tableName)
+            		.addUpdateSet(columnName + "='" + newOne + "'")
+            		.addWhere(columnName + "='" + oldOne + "'", null)
+            		.build()
+            		.getQuery());
```


Unbelievably fast response, guys.

Confirmed that it fixes the issue I had here.

Thanks

Dave

On Tue, Dec 29, 2015 at 7:00 AM, Aleksei Magusev <notifications@github.com>
wrote:

> Yes, and also:
>
> with !(a = "a"), b <- "b", do: [ a, b ]
> with b <- (a = "b"), do: [ a, b ]
> with 1 <- 1, do: c = 1
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/lexmag/elixir/commit/0f6c9d159492266df19bbeb6d546f120a70d746f#commitcomment-15188983>
> .
>


Remove this huge comment from your final code.


I'm expecting this credits to exist very rarely.  Could you explain what would be the difference between hiding the column vs using a flag?


I thought my edits might have been the cause :-(

I currently test the code in my browser, then: in the case of javascript files, cut and paste the whole file into Github and; in the case of tid files, export the tiddler, open this in a text editor, then cut and paste the whole file into Github. In this way, I hope to post only tested versions of code -- not sure how the header was lost.

I started out with nodejs some time back, but abandoned my efforts due to unpredictable synchronisation errors between the browser and nodejs, which caused me to lose my work on numerous occasions. I have, however, recently moved from a Linux Mint environment to an iOS environment, but haven't got round to repeating my efforts (there's much to learn in the move.)


Use english everywhere


What's the purpose of the try here?


This looks like a huge function, break it down.


If you have this much trouble with the pull request why don't you just bump the bcrypt version and repub please.


LGTM
Great move!


In case anyone's following along, I figured this out in https://github.com/modocache/swift/commit/6bba5f3432d186f94a9b66ce9fe13d01b2b6440f. It comes down to the note at the top of that commit:

> When instantiating test cases for a particular test method using the `XCTestCase(selector:)` initializer, those test methods must be marked as `dynamic`. Objective-C XCTest uses runtime introspection to instantiate an NSInvocation with the given selector.


Why not call exit()?


Actually, I think it needs to be like this (using YAML list syntax, rather than repeating the hash key):

```yaml
- !permit
    role: !host job
    privilege: [ read, execute ]
    resource:
    - !variable access_key_id
    - !variable secret_access_key
```


LGTM


Thanks @matabele. Even if you don't use the client-server configuration it's worth using Node.js to build the index.html from the source files for testing.


та то я пробовала из примера)) просто еще не до конца разобралась как делать навигацию между страницами и передавать данные.


Did I? I installed ruby2.2 under c:/ but copied the entere install into sonic-pi\server\windows\ruby and installed the gems from there. I did however link ruby dev to the c:\rub21 BEFORE copying ruby to sonic-pi. Would it be better to either link this AFTER the copy, or alternatively use sonic=pi\server\windows\ruby as the install directory in the first place?

> On 29 Dec 2015, at 16:35, Sam Aaron <notifications@github.com> wrote:
>
> @rbnpi that's because you used a different ruby than the one you packaged in Sonic Pi to install the gems before copying them across. If you use the gem binary in the packaged Sonic Pi then you don't need to copy anything across. In fact, you don't even need any of the code in the vendor directory. Using gem like this is something I'm going to look into post v2.9 to simplify things and potentially provide a path for people pulling in their own gems from Sonic Pi itself.
>
> —
> Reply to this email directly or view it on GitHub.
>


хорошо ))


IMHO there's a much simpler approach at writing more readable SQL. Instead of the following:

```java
String sql = "UPDATE " + tableName + " SET " + columnName + "=? WHERE " + columnName + "=?;";
```
The code below would be a possible alternative:
```java
String sql = String.format("UPDATE %s SET %s = ? WHERE %s = ?;",
   tableName, columnName, columnName);
```
A smart IDE will even know if the `%s` count doesn't correspond with the replacement arguments, and it seems to me a lot more concise than a lot of method calls where I have to skip a few SQL keywords but pass the rest of the query I want as SQL.


Gordon created a FlowDocumentChangeListener


The contents of the change look good. Would you mind splitting the printf fix and the bang line into separate commits?

Also, could you add a line to the AUTHORS file under the Contributors section?


[eastron sdm220.pdf](https://github.com/peninquen/Modbus-Energy-Monitor-Arduino/files/74128/eastron.sdm220.pdf)
[Eastron-SDM630-DC-user-manual-2013.pdf](https://github.com/peninquen/Modbus-Energy-Monitor-Arduino/files/74129/Eastron-SDM630-DC-user-manual-2013.pdf)
[SDM530D Three Phase Din Rail Energy Meter with S0 Output user manual.pdf](https://github.com/peninquen/Modbus-Energy-Monitor-Arduino/files/74131/SDM530D.Three.Phase.Din.Rail.Energy.Meter.with.S0.Output.user.manual.pdf)


u should re configure your resharper lol


Yes coffee sounds like an excellent addition to this list and one of the most important items.


We have no implicit return anymore.
Pablo and Nico changed this a while back ago.
At first I was not sure because I liked to be able to write less amount of
code.
Later I found that having the explicit "return" allowed us to detect a lot
of errors with static checks.
It will also help the type system inference, since you are explicitly
telling that the method has a return type.

The only "similar" case is this short method syntax, where you don't need
the return but you have the '=' symbol instead.

I think that this "short-version" fits all the cases where I wanted to
avoid writting the return. So it ended up a win-win.


[Eastron SDM320M user manual 2014 V2.0.pdf](https://github.com/peninquen/Modbus-Energy-Monitor-Arduino/files/74132/Eastron.SDM320M.user.manual.2014.V2.0.pdf)


@Jermolene

I presume you mean build from my edited branch? I often build a standalone from the master repository to get the latest code to work with, but his doesn't test my PR's.

Even though my edits are tested in my standalone wiki, there are a few more steps after that where things can go wrong before submitting the PR. I'll work on this.


Hmm... I guess it's not that important. Anyways, our news would be instant and the time of the email will do the job.


Whoops sorry for missing this instance


hi @FernetMenta - thanks for looking into this. Can you be more specific about where this was fixed? Are you referring to the removal of call to SkipStill in the navigator (CDVDInputStreamNavigator::ProcessBlock line 333)? Anyway I kept all other changes - removed only the if condition here... So I'm guessing that the fix must not be compensating it. I have uploaded a sample here : https://www.dropbox.com/s/hquzbke1x6pvz4e/SPONGEBOB.zip?dl=0 . It is a DVD where I kept the menu but deleted VTS 8 (the one with the episodes). Just choose German or Dutch in the language screen and then you'll get a still with some 'disclaimers'... It's hanging there.


Isn't that an argument for changing it to a named exception now? You could raise a `ProductRateDoesntExist` exception, which `forms.py` would catch, which would still be applicable even if there is only one product rate per software plan version in the future. Fine with leaving as-is for now, but something to think about.

Also, super duper in favour of one product rate per software plan version. :+1:


We wan't only one throws annotation here, using the `|` syntax don't we?


Same as return annotatiosn.


name     | description    | type     | default  顺序跟 antd 上一致了，实际编辑这里的时间比较少、table tr td 这种占地太大、看着也太麻烦。本地编辑器工具可以格式对齐看的。


(offlined, resolved)


consensu -> consensus


Are you sure?

It does work in http://www.es6fiddle.net/iirlbg79/ but [Babel isn't checking](https://babeljs.io/repl/#?experimental=false&evaluate=true&loose=false&spec=true&code=function%20testFor(iterable)%20%7B%0A%20%20%22use%20strict%22%3B%0A%0A%20%20for%20(const%20a%20of%20iterable)%20%7B%0A%20%20%20%20console.log(a)%3B%0A%20%20%7D%20%20%0A%7D%0A%0AtestFor(%5B1%2C2%2C3%5D)%3B%0A).

It [works in Node v4.2.2](https://coderpad.io/9EK7TDQD) and [in Chrome](http://stackoverflow.com/questions/28344365/es6-why-can-i-reassign-a-constant-when-defined-in-a-loop) but none of those have [full `const` implementation](https://kangax.github.io/compat-table/es6/#const).

In Firefox 43 (which has 8/8 on const), it's a syntax error:
<img width="325" alt="for const in ff 43" src="https://cloud.githubusercontent.com/assets/21505/12038015/6e882f40-ae22-11e5-8365-4e2caa9ed5d8.png">


可以把 generate-rc 工具里的table tr td 模板也改为这种吧，大家更愿意接受。


TeamCity LabKey :: Trunk :: Premium :: Git postgres 9.4 [Build 882](https://teamcity.labkey.org/viewLog.html?buildId=293936&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 15, passed: 248 Build time: 00:35:58
### Failed tests
```
org.labkey.test.tests.DataFinderTest.testDatasetExport: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelection: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSelectingEmptyMeasure: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnDataset: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStickyFinderFilterOnStudyNavigator: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testGroupSaveAndLoad: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testStudyParticipantCounts: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testCounts: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testSearch: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.cas.SSOwithCASTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.premium.FooterTest: <no details avaliable>

##### there are 5 more failed tests, see build details
```


I was trying to explain why f ~ g is not the usual definition of function equality. It is of course in the traditional sense but there are subtleties in hott. Sec. 2.9 is clear that the intention in hott is to have (f = g) ~= (f ~ g). The thing is that the equivalence cannot be proved and requires an axiom. I didn’t want to get into univalence etc. —Amr

On Dec 29, 2015, at 5:55 PM, Jacques Carette <notifications@github.com<mailto:notifications@github.com>> wrote:

That's not true! That is 'functional extensionality', which we don't want. f=g of course implies f ~ g, but the other direction is where all the trouble lies.

—
Reply to this email directly or view it on GitHub<https://github.com/JacquesCarette/pi-dual/commit/7f7fb601c49add27ce686befce8a3ba3ed7408f4#commitcomment-15191610>.


According with the [Java Guides by Oracle](https://docs.oracle.com/javase/8/docs/technotes/guides/language/assert.html): "Do not use assertions to check the parameters of a public method". Could we open an issue?


I had to remove it as an operation came along that did not use the d variable. This caused the program counter to be 1 position ahead than it should have been


The bug has been fixed!  Should be in the next release :+1:


Is this for debugging?


Thanks for your comments, i haven't finish at all! I've push it to keep track of it and because it actually works :')


Hi @cooperq,

This commit closed #243 but there are a number of concerns raised there that it doesn't address.

It made no change to how alternateErrorPagesEnabled setting is handled, nor provided any option to toggle it in the preferences. There are a handful of other settings #243 mentioned that also aren't addressed here.

To me, it makes a lot of sense to override these settings by default. Without having some inbuilt means of modifying the overridden settings, though, I lose a lot of control over how I want my browser to behave.

Could you please revisit this issue with a holistic approach to managing all the privacy-related settings centrally, and with a particular eye to giving users some control over PB's behavior around chrome settings?

Thanks very much!


By the way, i'm working on 2 different PC with 2 different env Win10/Debian each, that's why i need to push my changes sorry :3


Adding $server_port to the host header was a bad idea and needs to be removed.  I can't remember why I thought this was needed.


Would it be possible to set up a branch?

And does this really seem like a better idea than the `String.format()` example I posted?


Thanks @dkayiwa. Resetting the cache isn't an issue, I believe, because it simply sets a variable to issue.

*But* the bigger issue and the reason for creating this method (if I remember correctly) was because when saving a 40,000 entry hierarchy, making a separate @Transactional service call for each entry was not working from a performance perspective.  I have to look the code in greater detail (don't have my dev machine in front of me at the moment) but I think that issue would be a blocker for mering this request.  Are there any alternatives?  Would it be possible to use a Hibernate interceptor instead of Spring AOP?


I'd avoid using #defines where constants will work.


TeamCity pull requests :: netty [Build 932](https://garage.netty.io/teamcity/viewLog.html?buildId=4355&buildTypeId=pulls_netty&guest=1) outcome was **FAILURE**
Summary: Tests passed: 6364, ignored: 23; resource leak detected (new) Build time: 00:41:55


Unit tests?


:heart:


500 words per minute sounds like a lot!


What about something with tags? Like first construct some sort of object that holds all the column names into a map (we can construct it easily by getting the values once from `Settings` and then passing that object on) and then queries like

```java
String sql = QueryBuilder.replaceTags(
    "UPDATE {tableName} SET {columnName} = ? WHERE {columnName} = ?;", columns);
```

would be possible. This means:
- I can write almost SQL and don't have to worry about the constraints of the current Query class
- Convenient way of adding column names into the query

But a call to `String.format` still seems simpler to me, since I know where the text and data is coming from directly at the spot where I am building it, and it's the simplest, most readable solution.


Wow, neat trick! Though now it looks like over-engineering. I thought of something simpler (I haven't tested/run this code, please don't copy-paste):

``` vim
function! s:CursorManager.save_positions() dict
  call self.start_loop()
  for _ in range(self.size())
    call add(self.saved_positions, self.get_current().visual[0])
    call self.next()
  endfor
endfunction

function! s:CursorManager.restore_positions() dict
  call self.start_loop()
  for _ in range(self.size())
    let pos = remove(self.saved_positions, 0)
    call self.get_current().update_position(pos)
    call cursor(pos)
    call self.next()
  endfor
endfunction

function! s:CursorManager.save_positions_conditionally() dict
  if s:char =~# 'I\|A' && s:from_mode ==# 'v'
    if s:char ==# 'I'
      call self.save_positions()
    endif
    let s:saved_char = s:char
    let s:char = 'v' " spoof a 'v' input to transiton from Visual into Normal mode
  endif
endfunction

function! s:CursorManager.restore_positions_conditionally() dict
  if s:char ==# 'v' && s:to_mode ==# 'n'
    if s:saved_char ==# 'I'
      call self.restore_positions()
      call feedkeys('i')
    elseif s:saved_char ==# 'A'
      call feedkeys('a')
    endif
    let s:saved_char = ''
  endif
endfunction
```

Names `save_positions_conditionally` and `restore_positions_conditionally` are smelly and better names are welcome. I just wanted to show the idea.


Yup, i will, sry, by the way, i will keep the Query builder, it will allow us to validate the build and get a queryqueue in the future, let me finish the rework before :p


Let's use a `const unsigned int` here, instead of a preprocessor macro, and please add a comment signifying what the value means.


Haven't gotten to cleaning up code yet.


Why is the builder better than the alternatives I posted?

> "it will allow us to validate the build"
What will it validate? To me it obscures the actual SQL query that will be executed.


Despite larger indentation, I liked the version with straight (not negated) conditions better. For me it's harder to reason in negated conditions.


@ljharb I fixed only this instance based on your comment

> Our styleguide prohibits noop expressions which includes `.to.be.true`

I see that there are a number of existing violations throughout the docs. I'm sure this could make a good [Your First PR](https://yourfirstpr.github.io/) for someone if posted as an issue.

![image](https://cloud.githubusercontent.com/assets/1240178/12038245/9ed55f6a-ae13-11e5-9068-9719a09d6f4a.png)


dfgdf


Same thing here (negated conditions).


Do we not still do this?


Probably can yank this box-shadow. Don't think it does anything


One uber-minor comment. Otherwise, :+1:


If this also works on other platforms as well, you should probably submit a PR in SMQTK for this.


I did it so to be consistent with the est. read time we have now (client side):

https://github.com/discourse/discourse/blob/master/app/assets/javascripts/discourse/models/topic.js.es6#L231-L232


I can check the logs, but my thought was to provide , in general, versions 1) without spaces; 2) with underscores instead of dashes. For ignore-sets, I also wanted singular versions (because I've been bitten by that repeatedly). And for --no-offsite-links and --user-agent-alias, I though it would be nice to have versions that dropped the last word, to save typing.


The commit fixed ignores not mutes!!!


Exquisite, thanks @ianobermiller! One thing to note is that I wasn't able to fix it by supplying a displayName manually.


If I'm understanding this write, you need to add `|| inv.type == MSG_WITNESS_TX` 6 lines up.  Also I think you shouldn't first be serializing the tx to the DataStream because you aren't passing the witness flag there, but to be honest it was never clear to me why that step existed in the first place.


@JustAkan 확실히 저번처럼 클럭이 확 올라가면서 핫플러깅도 cpu 가 여러개 켜져야 하는 상황이 없어졌네요.
덕분에 배터리도 오래 갈 것 같습니다. 추가로 msm_performance 핫플러깅 비활성화를 안해 놓은 상태여서  비활성화 했습니다.


Absolutely, I didn't intend to increase the scope of your PR :-) thanks!


Hi Joona,

Im fully aware about the fact that SMP tests consume a huge amount of resources and for saving resources I already expressed my concerns about TC 30+0.3 on these tests 5 days ago (see earlier post in this thread) and since you were already mentioned, I guess you was also been notified about.
So why this reprehension now and why so late?

>>In the future please think about your expectations BEFORE submitting the test.
How should I understand this?
For me it is impossible to estimate in advance how strong a patch will perform (N.B.: I have only a 8 core machine at my disposal). I guess it is impossible for us all.

>>Just measure its ELO value using a fixed game test
I did it in the past and was criticied for not using SPRT.

>>Just measure its ELO value using a fixed game test.
Also on SPRT-tests the ELO performance can be measured easily and continuosly,
for instance by using http://www.3dkingdoms.com/chess/elo.htm
so I don't understand the point.

That said I must add that I now feel dissappointed and intimidated.
You also did't give me an answer about the [0,4] or [0,5] bounds and pardon [0, 8] sounds like a provocation to me. I really don't know how to go on, please tell me how to stipulate the next test.

Günther


Need to find out the way to emulate Spring animation. Of course, we already have it with `Animated`. Any ideas?


you're no longer throwing this exception


I'm adding back `String` -> `[Array|Object]` coercion as I removed it by mistake when working on something else.


nit: NetMsgType:TX  instead of "tx"
(let me know if you don't want nits now)


I would split this into two contracts, the reason being that you could split this up a bit more with some refactoring, and I think it should remain obvious that you can in the tests.

I know it seems pedantic to have so many contracts, but I think that's pain you should feel. The reason that there are so many contracts between the model and the view is that they are tightly coupled. The way to reduce the number of contracts would be not to find clever ways of reducing the sheer numbers for the same code, but instead to find some refactoring that can reduce their coupling.


Strange - I don't remember changing this.  It may have been left over from the earlier CMakeLists version?  All I care about is getting rid of the TPL build, since I handle those separately.

I will clean this up.


FYI that BSP structure only applies to Q3.  There is differences for ET, RTCW, JA, QL etc.

ET and QL share version 47 but there are additional changes in each I believe.


For my money, a single-item array is enough to cover this thing. Adding the extra item doesn't really add anything IMO, unless there was some extraordinary difference between the two.


Instead of if's like
 if ('Local' %in% class(repository)) {
}

we can use S3 generics
searchIn.LocalRepo()

wouldn't it be better?


Makes sense. It would be nice if that constant was centralized but it's not a priority.


Same not as other side, I would probably split this into to contract lines.


If DEBUG log ERROR; seems counter intuitive. Not a big deal, just wanted to see if there is a reason. IMHO if there is error I want to see as much info as could possibly be shown, regardless of the log level


would be better to store in a list (or iterator), and to send is separatly.


@mrshu This is getting really messy... Is there a better way to do this?


@Rocky640 : I see a lot of bouncing up and down for parameters with start value 10 and 15. It seem Ck=6 is too much for them.


flush is triggered by close.


I can try to replace that modules with Perl-only implementation, but this will affect on the performance.


Typo: yor -> your.


no camel case in python please :)


use a list instead, append strings, print and join strings with "\n"