Почему собственно так написано? Операция то производится с pVector, а не с tmp.pVector.
А, понял. Можно было обойтись без приравнивания к this. lol


To improve readability, use a different delimiter char with sed, like:
```
sed -e 's,\/wp\-config\.php,,g'
```
Can be anything other than comma, I just like to use it as it makes things clearer.


??? return a blank string?


Yeah, those are exported symbols, so probably will break any external exts using FAST_ZPP. Though it'd be nice to fix those typo. I would suggest to have the fixed functions, and the wrapper functions with the old symbols - that for 7.0 only. For 7.1 those typo'ed functions will just go away as it'll be most likely forked from master and the API numbers are different anyway.

Thanks.


@lodewijkloos: seems a good idea to use `xxHash`, but since `hashed-diff` is not installed by default, it would be a good idea to add a configuration option to histograph/config and make the diff command line argument that IO or node-diff-utility uses configurable!


#NotAllProgrammers are C programmers x3


- [ ] this import is necessary


If you don't implement any special thing in override func, you can remove it.


@amoreira Chega aqui daqui a pouco para conversarmos sobre este trecho? Não estou vendo como deixá-lo mais claro.


@mbootsector  I feel in order to measure the value of the (arithmetic) TC parameter changes this should also be tested against a modified master with ponder off to be fair:
o["Ponder"]                << Option(false);


Same recommendation on `sed` here


Adicionado:

>**(?)**
>
>`/?workspace=sb_seuemail` é uma querystring que aponta seu browser para o ambiente de desenvolvimento ao invés do site em produção


Ce genre d'exercice seront dans le controle ?


:sparkles:


Можно смоделировать ситуацию, принудительно удалив треды.


Missing ","


You should declare this variable like this to prevent unwrapping it when using.
```Swift
var tweets = [Tweet]()
```


The previous behaviour on encountering any type error in either overlay was to bail out of the connection; this change makes the overlay switch skip over the problematic overlay. An alternative would be to have `PrepareConnection` return a specific type of error which signals to the overlay switch that it can continue, and we would only return that from fastdp if a session key is supplied - thoughts welcome.


Delegate method should be removed - its no longer being used.


Ha, thanks. I see colors and numbers and those russian glyphs :)


Sim! O artigo da intro `ambiente-de-desenvolvimento` atende bem essa demanda, mas se precisarmos expandir o conceito criamos um outro depois.


Maybe fix the `$`s? Not sure but I think all numbers need it. Also might need to check the syntax.


Should no longer assign the delegate to self. Not using delegate methods anymore.


> [..] also some people are more conscious about libraries that they use, and some companies have approval process for each library, so async is HUGE, and its dependency tree is enormous, and approval process for async is less than optimal.

Spot on. We just approved removing all instances of async indefinitely (replacing them with Promises) and it's really a pain negotiating with the teams about wether we should use a module or not, because many engineers have stakes on *only using as few modules as possible*.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8353](https://teamcity.mesosphere.io/viewLog.html?buildId=87645&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 205 Build time: 00:05:02
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Хм, запуск оказывается частично успешен. Падает на `yield* readPostsData(DelForm.first.firstThr.op);` в инициализации, тем не менее скрипт юзабелен.


nice


Yes I knew about it as soon as you released it: I'm having a search box on TweetDeck for all "jhipster" tweets, and there is npmbot tweeting about each new NPM package :-)
Anyway, that's good for my tests, I needed this!


Sorry @julienlancelot , I meant "Issues and Technical Debt" widget (which key is "rules").


- [ ] `Collection` not used


Looks like unnecessary blank line. Don't put a blank lines after `{` and before `}`, the prefered format should be
```Swift
someBlock {
  someOtherBlock { // no blank line here
  }
  // blank line here is okay
  someVar = someMoreCode
  ...
  // blank line here is okay
  someFinalCleanup() // no blank line at end of block either
}
```
In short, in a block, no blank line right after the start `{` and right before the `}`. Blank lines are welcome anywhere else in the body though. Don't use double lines to separate your code.


Should it return a `Null<Dynamic>` like in the `DynamicAccess` class?


Até que fim ein brow.' heuehuh


`update_type` shouldn't be necessary for `put_content`, it's only required for the `publish` endpoint.


U just need to download more RAM ;)


Should make sure it's not the 'hosted' satellite for those who are directly connected, they can't 'enable' insights.


Frlon line 85 to 89, you can write like this:
```Swift
likeButton.setImage(UIImage(named: newTweet?.isLiked ? "like-action-pressed" : "like-action-default"), forState: .Normal)
```


pushed corrected version, thanks!


TeamCity KB-QS :: content-editor :: build [Build 8](http://teamcity.nice.org.uk/viewLog.html?buildId=108794&buildTypeId=KbQs_Editor_Build) outcome was **SUCCESS**
Summary: Running Build time: 00:11:25


@oberon2007  my fail. Here is merge fix. https://github.com/manjaro/packages-community/pull/80


Boo.


Whee!


- [ ] `countByName -> countByContainsName` or `findPageByContainsName` -> `findPageByName`


I am not very happy about this as a method of detecting whether encryption is enabled on the overlay connection or not, especially given how `weave status connections` is implemented - ideas for improvement are welcome


Fixed !


:tada:


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8354](https://teamcity.mesosphere.io/viewLog.html?buildId=87648&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:28


Note how ':id' is supposed to be somehow fine because it's not a variable here?  Booo.  $id is fine with an obvious context.


Because the model was being loaded async, this templates aren't updating if the value changes. Creating a method that watches the property does. There might be some way to make the property itself observable, which would be a better approach.

I'm in the midst of trying to rewire how ember data is set up, and I think a lot of this code I wrote is going to go away.


Not sure why the `sw/ext/mavlink` entry exists in the pull request?


This is the skipping resulting map.
A 1 in the table-cell means that for that game-ply and thread->idx the iteration gets skipped.

idx       1 2 3 4 5 6
ply 1    0 1 0 0 1 1
ply 2    1 0 0 1 1 0
ply 3    0 1 1 1 0 0
ply 4    1 0 1 0 0 1
ply 5    0 1 0 0 1 1
ply 6    1 0 0 1 1 0
ply 7    0 1 1 1 0 0
ply 8    1 0 1 0 0 1

In avg now each second ply get skipped, so now skip-density is half which is more than in previous 7-threads attempts.


Too many `?` and `!` in this line. It's unsafe. You should unwrap `newTweet` before using. By using this, you don't need to use `?` or `!` to unwrap it anymore.
```Swift
if let newTweet = newTweet {
  // set tweet's detail
}


What do you have in mind there?
Is it required at all, with the delegates feature?


- [ ] `createMember` -> `create`


Is there a better way to pull in injectables from the constructor into private class variables? This is how they are doing in TS `constructor(private el: ElementRef, private renderer: Renderer) {}`. I just wan to make sure Im not missing something.


This will always override the other `FILESDIR=` set instruction above.


- [ ] `updateMember` -> `update`


@marija-p As a rule of thumb, one should always build before PRing.


change again.


@dstoup David,  I have a grant due today, so I can not do an independant test.

This does, however, look PERFECT as the correct solution.  I think you should merge it.

Hans


You can customize colors and chat format simply using this plugin plus another one which manages chat format (like CustomChat)


> Or is it that you want some sort of version resolution to bump these to 1.2.1 when running or compiling with 1.2.1?

But this is exactly what @tombentley has been doing the last weeks. The `dist-overrides.xml` file you have in your distribution repo specifically says:

```xml
  <replace module="com.redhat.ceylon.typechecker" version="1.2.0">
    <with module="com.redhat.ceylon.typechecker" version="1.2.1"/>
  </replace>
  <replace module="com.redhat.ceylon.compiler.js" version="1.2.0">
    <with module="com.redhat.ceylon.compiler.js" version="1.2.1"/>
  </replace>
```

@FroMage I'm not asking for a Java `--target` option, I'm not asking for the 1.2.1 compiler to generate 1.2.0 compatible code. I'm just asking for the same code to compile on both versions simply taking into account the above `dist-overrides.xml`.

Without this check that you made Tom put back it would work just fine. So why can't we relax this restriction? What would go wrong without it?


K


I'll get to this later today. To be clear you want this for those 2 nslookups I commented about? @zonzorp


Space format doesn't matter !


Hey @danfowler - I updated the positions as you specified in the above comment. I will create a pull request for this; we can cancel the pull if @davbre would like a different title.


If your are not = if you are not


- [ ] `deleteMember` -> `delete`


Please make space indentations consistent with the project next time. Having 4 space and 8 space mixed indentation isn't consistent with the project style.


I know but it looks Good :)


@alwey I don't see why it's unfair. I'm trying to fix the "ponder bug" without losing elo. Already tried tuning only the slow mover variable, without success.


It's better if you set default value for these properties, such as `""` for String and `0` for Int. By this way, you needn't to unwrap them before using it later.


Do we care if the previous request responds with an error? Is there a danger of publishing something by accident here?


Adding ","


- [ ] `escapedName` -> `name`


I'll open a pull request shortly to fix this


@scottschurr Yes, that's my reasoning.


Yep, that would be fine with me, as would having the format at the end of the list in the UI.


Create an user = create a user


The repository name was previously being auto-derived by title-casing the URL.  I've added the repo name explicitly to the repos.yml, so this now is fixed on master. Should show up when Github refreshes the site.


PR #3846 raised


Sorry @askb I missed this test in my review. I don't understand what it does.


**using** should be uppercase, and the phrase should end with a dot.
Also, I think it's still not that clear to everyone why this is necessary. It's best to also explain that these functions don't exist specifically on **node** environment, and that's why using `core.isFunction` on them would throw an error.


Первій файл на ГитХабе


Just use `if !newTweet?.isRetweeted`.


check refned spelling.


Send Pull request


Thanks, that input was enough. We have several people here performing testing, just wanted an eyeball on it. Merging....


You are probably generating with a old version. Are you sure that the recent gapi-codegen is invoked?


Hello, I had difficulty to install EAGLE see attached log files.
Could you please help with what I may have missed?
Thanks!
Yifang
[CMakeError.txt](https://github.com/sequencing/EAGLE/files/54305/CMakeError.txt)
[CMakeOutput.txt](https://github.com/sequencing/EAGLE/files/54304/CMakeOutput.txt)


adding 65536, rather


Is that the case? I wasn't certain. I think you're probably right though.


I think it should be `center`.


107310700-change-license-text (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1977 of 1977 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


database is accessible at = database should be accessible at


@danfowler + @jwieder

Advisory Group Member is fine with me (although I don't quite know what
that means yet ;))

On 7 December 2015 at 17:04, Josh Wieder <notifications@github.com> wrote:

> Hey @danfowler <https://github.com/danfowler> - I updated the positions
> as you specified in the above comment. I will create a pull request for
> this; we can cancel the pull if @davbre <https://github.com/davbre> would
> like a different title.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jwieder/okfn.github.com/commit/46b3311bbae16049b4fab15e6ec34c2c81ae5770#commitcomment-14826173>
> .
>


sploh nism vedu, da se je moje sarjenje pushal


I want to avoid dereferencing null if getParent returns null. I also removed the is\<ErrorType> check from the loop condition.


pa xml filov ti nism nic rihtu


So I wanted to ask you about this, but I think how we are using the explorer service is basically bypassing most of ember data. If we set up custom adapters to specify where to fetch the correct records for a given resource, and then use custom serializers to normalize responses to the way that ember data expects them, we get all the real value out of ember data (intelligent resource loading).

I am going to try and get everything wired up correctly for the resources involved in this PR as a proof of concept and it should simplify this entire branch dramatically. If that works, maybe I can spend an afternoon and port over the rest of the app? All the resources seem pretty straight forward except for the recursive map stuff, which I might shelve. Thoughts?


I don't think you pulled my changes yet. This conficts with the commits that I made.


This test is now a repeat of https://github.com/barbour-em/osf.io/blob/4da2bbd7f71b56587edb32a5dc534c5b8d0177b4/api_tests/comments/views/test_comment_replies_list.py#L196, so I think this test can be removed.


NVM Done!


```
run.go:236: isolator.Set undefined (type types.IsolatorValue has no field or method Set)
run.go:237: cannot use isolator (type types.IsolatorValue) as type types.Isolator in append
```

I stopped here.


Oh Great (y)


Exactly. here there's 6 different test. Removing lag is a great improvement


Not sure about the logic here. In case a random value is required, it'd be better to build it using `$RANDOM` var, like:
```
PRIVATEDIR="/$RANDOM$RANDOM$RANDOM"
```
However that can be broken at any given time. What about an `if` condition just to check is there's a private folder and then proceed in success. Relying on a randomly generated name seems to be prone to errors.


@diraimondo: Are you sure you're using it for the Webclient, which this commit is for? I know Mobileclient is what's used in GMusicProxy; app-specific passwords still work fine with Mobileclient. Not sure what other recent commits you're referring to.


r+


107310700-change-license-text (jasondegraw) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


The previous call will raise an exception if something goes wrong, because api-adapters uses `put_json!`:

https://github.com/alphagov/gds-api-adapters/blob/master/lib/gds_api/publishing_api_v2.rb#L5


I don't know about DART.  It is a very convenient syntax in TS because it pulls the injectable and assigns it to a (private) local variable in one step.


107310700-change-license-text (jasondegraw) - x86_64-MacOS-10.9-clang: OK (1971 of 1971 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Well said!  :+1:


Aww, I like "prefixies", so cute.


maven { url "https://jitpack.io" }


Try to use a simple option when indenting, like 2 spaces per tab or similar, to avoid mixing approaches and having code looking disorganized.


On last line , this is not needed bro.


Надо бы для пользовательских CSS скрипта запилить разделение на глобальные и локальные, чтобы вещи типа  [css-tricks](https://github.com/SthephanShinkufag/Dollchan-Extension-Tools/wiki/css-tricks) не требовалось добавлять на каждом чане, но и чтобы чаноспецифичные правки были возможны.


this shouldn't be enabled. not sure what else might enabled/disabled, but can you reset this so that all the options are off?


@emmenko is this ok?


Again, I think all of this is going to go away if I can get Ember Data set up correctly, but allSettled returns all the different promises whether they succeeded or failed. For example, if a project doesn't have any indexes setup, that promise would fail, but obviously we don't want execution on everything else to stop. Allsettled lets us handle this, and returns the different promises with their promise state (fulfilled or rejected).


+apply from: 'extra.gradle'


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/80dee4af5a34a4a7386788c1c5ab0813299ecdcf


merging MonsieurNicolas/stellar-core/previousMeta = 80dee4af into auto


MonsieurNicolas/stellar-core/previousMeta = 80dee4af merged ok, testing candidate = eed89649


I would get rid of the description logic - we need a helper module to configure this instead like dispmanx etc.


Hahaha we've been encoding errored


sorry, disregard, this is a merge commit. i'll fix it separately


This should be in a different commit. The function `moxunit_set_path` is not introduced until 6b499bbef3b9a178, three commits later.


of just `[[ "$ini_value" == "1" ]] && return 1`

since you return 0 at the end anyway.


#修正文法bug
Why use the high level consumer


Can you use log4j Logger? The Log4j is the logging used for PerformanceTestTool module.


**Code Functionality**

Why are you returning 100 here?


this chart should be battery voltage based instead of g.fs_ based. Lots of people don't have this set or not set correctly. Also, chart should not have any "holes" in it. Currently if ==10.0 then cell_count=0.

A Full battery is roughly cell*4.2. A "low" battery is above (cell-1)*4.2 but a "dead" battery is quite low, lower than (cell-1)*4.2 so a direct scale check won't work. Checking for time-since-boot gets us pretty close but still has the problem of plugging in a dead 4S battery and booting up thinking it's a fully charged 3S.

cell_count = (battery_voltage()/4.25) +1 // works for full charged, fails for dead

if BATT_CAPACITY is measured as being half used (or some other helpful metric), then use a different scaler


Can you follow Logging format that we follow and print exception Localized message along with exception?


I don't know if this is overkill or not, but I want to point out a few things.

The scan only happens for unreachable blocks which are typically tiny, so it's hard to say if the extra memory is worth it. This could actually be adding overhead. If hash entries were only added for unreachable blocks, it would be more efficient, regardless of whether it's an analysis.

Making this a formal analysis does add some complexity in reasoning about its invalidation.

As a side note, I want to point out that we should have a clear distinction between a "caching" analysis vs. a "decaying" analysis. A caching analysis such as this would at least never need to be serialized between passes (otherwise making it an analysis would definitely add too much complexity).


A little pedantic of me, but there are too many newlines here.


Just to be clear, the +1 was for @ta2-1 comment.


А зачем же тогда гем 'state_machine' подключался? Тут как раз ситуация для его применения


Hi,
I can't see what compiler it is trying to use.
Would you mind trying with gcc, in case it's not already using it?
Thanks,
Lilian


Michael, I created a new branch "merge-up" in my fork let me know where you want me to send the pull request.
Anthony


I agree with @ta2-1.


Does the ruby 1.9+ syntax not work here? We shouldn't be using hash rockets if they're not necessary


did you mean to use throttle_suppressed here instead of suppress_throttle()?


You didn't notice this commit, carry on.


so, I created translation image for you :)


Can you also do Logging here and in other places where you catch exception?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.904](http://teamcity.monogame.net/viewLog.html?buildId=12001&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 559, ignored: 6 Build time: 00:30:50
### Failed tests
```
MonoGameTests.exe: MonoGame.Tests.Visual.RasterizerStateTest.VisualTestCullMode(CullCounterClockwiseFace): <no details avaliable>

```


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.905](http://teamcity.monogame.net/viewLog.html?buildId=12005&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Snapshot dependencies failed: 2 Build time: 00:00:02


Sometimes, we hope reading messages with multiple threads and care about that if the data is consumed instead of the order of it.


- "Employ anti-tamper and tamper-detection techniques to prevent illegitimate applications from executing."?


Thanks for the input!


I will remove it. I do not use it at the moment and it is not really necessary.


walking off the end of an array in style.


Not sure, I think there were problems with a different version, not sure if they fixed it. Just keep the current version for this.


The point of these partials is to ONLY have the code you need to render one instance of that object. You shouldn't need the loop.


What if it extends Element rather than implementing toE()?


See above.


Hmm wait, why do you need `coffeelint` dep above?


Yes, your code is faster, but it is not easy to understand. I think the readability is more important than performance.


Erase above;
rewrite below;
test


It was being pulled in transitively https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Extensions.CompilationAbstractions/project.json#L9.


here's a line note.
over 'n out


This call will make it loop through each topic, calling the topics/_topic partial. Hence the lack of the need for the loop in the partial.


another comment


hahaha


When throttle is suppressed you want it to be on a little bit?!?!? What does "radio_min" do on your ESC? How does this work on bungee launches where there is no RC input (fully auto) you want the throttle to be zero until a confirmed launch?


That was simple and embarassing :D


20151208 start


**Code Quality**

Please return a proper json response than just returning numbers like so:

```php
return response()->json(['status' => 101, 'message' => 'Blah blah blah']);
```


Please note that any changes that you want to be on pqr0 need to be merged with the env/prod branch


@rwrzesien  You should be able to test against the isolateScope.

Once you get it, you may need to do a $rootScope.apply() to make it possible to stub against the functions in the controller.


Done!


When I upgraded `grunt-coffeelint` it told me `UNMET PEER DEPENDENCY coffeelint@^1`


High Level Consumer stores last offset read from a specific partition in ZooKeeper ,and it`(這邊的it指的是？)` would be re-consumed the msg from the last offset.


Ah sorry, didn't see that. For consistency, I wanted the size modifier for all inputs to be identical.


Try fzf instead of ctrl-p.
Plug 'junegunn/fzf.vim'


@DavidGoldwasser can you bump to 1.10 now?  How did you update these, using the OS app to open the files?


Looks much cleaner and easier. I thought to return -1 if ini_value is not 0 or 1. But if getAutoConf returns no 1 nothing will be executed anyway.


- [ ] Please modify to use JOIN fetch (Currently, this mapping has N+1 problem)


Here are some very specific rules from the official documents:


**Code Quality - Critical**

Why would you name a variable `$e`. Did you run out of variable names :laughing: ? Please give it an appropriate name


They have different meaning in x86_64.


Thanks for adding this, @maruilian11


**Code Quality - Critical**

Please return a proper json response than just returning numbers like so:

```php
return response()->json(['status' => 200, 'message' => 'Blah blah blah']);
```


Hi @sevazhidkov This test.py is a sample file of how the code has to be used and not the actual representation, Could you use the `unittest` library in python to create a test case.
Here's a link to the unit test documentation and how to write unit tests.
- https://docs.python.org/2/library/unittest.html


hallettim hocam hepsini. uyarılarınız için teşekkürler


Could be `inner_iterations.times { return false unless verify_result(benchmark) }


What's the point?


Ruby normally uses `snake_case`.


Remove


hi


**Code Quality - Critical**

The variable name `$delete` is not descriptive enough. In this case, it should be something like `$deleteStatus`


Could be `puts("Starting #{@name} benchmark ...")`


If you look up a domain name instead of a host in the domain, do not use the default record type. Use SOA (or NS would be fine). I'm not sure which ones you mean when you refer to the ones you "commented about".


- [ ] `s_rest_member` -> `s_member`


ahh yes, i see. The commit msg says you want it to spin a little, probably to signify that it' sready to be launched. This is certainly not good for general use and will need to be disabled by default. Perhaps a check for TKOFF_THR_MINACC==0 would help here but there needs to be some way to not do this behavior unless the user specifically enables it somehow.

Remember, many flying wings have no landing gear and the motor is almost touching the ground so any prop spin is bad, pre-launch or after-land.


My first comments did not show up


Because it's incomplete. If we do that people are going to assume we can generate 1.2.0-compatible code but we can't.


Fixes


@sl4m: please take a look at this PR again.....:P


Could be `puts ("#{@name}: iterations=#{@num_iterations} average: #{@total / @num_iterations}us total: #{@total}us\n")`


Nice transition


@trentxintong Can you please review this commit?


Oh, sry. Interesting that 3 ppl didn't notice :\


Could be `puts ("#{@name}: iterations=1 runtime: #{run_time}us')`


Is `itterations=1` correct?


**Code Quality - Critical**

300 shouldn't be used in this case. `200` indicates a successful request. This is a link [https://en.wikipedia.org/wiki/List_of_HTTP_status_codes](https://en.wikipedia.org/wiki/List_of_HTTP_status_codes)


@dstftw .. does this code also check for the 2 formats being audio ?


Make a pull request or send an email to the list. I have a generic feeling that there's a bit of an impedance mismatch going on between the type system and cffi-libffi that needs to be sorted out sooner or later.


The 'no-Octave' method can also be used when `numel(elem) > max_chars`, and would be a more useful fallback than the current `elem_str = sprintf('(%s)', class(elem));`.

Could we move this around so we have as follows:
```matlab
try
    if numel(elem)<=max_chars % Needs to be in a try in case no numel method
        % try pretty printing
        elem_str=tiny_elem2str(elem); % raises an error if there is no disp function
        has_elem_str=true;
    end
catch
end
if ~has_elem_str
    try
        siz = size(elem);
        siz_cell = arrayfun(@num2str, siz, ...
                        'UniformOutput', false);
        sizstr = strjoin(siz_cell, 'x');
        elem_str = sprintf('%s(%s)', sizstr, class(elem));
    catch
        elem_str = sprintf('(%s)', class(elem));
    end
end
```
or something similar?


Could be `puts "Total Runtime: #{total}us"`


How can I name new file with test?


pleaes leave the def

please!


Lo del cache me olvidé de agregarlo!!!! Ahi lo agrego se resuelve con una sola linea,


I think both of these lines could simply be `unless require_relative benchmark_name.downcase` - without the need to add `./` or `.rb`


Thanks :) Another option was to export only function itself, but wanted example to be realistic and easy to export to real plugin, so decided to go with such hack :)


I'm certainly in favor of this, however I would prefer it used in a slightly different way. First, it should be index 1 so the flow of the states are in order.
Next, it should signify the state we are in before a launch, either hand or bungee launch. Right now in a bungee pre-launch state, we are idle in "NORMAL" which I think is totally horrible and needs to be changed. That's what this change does, but it will be scruitinized heavily by Tridge for safety reasons. This is not related to reverse thrust so it needs to be separated into it's own PR.


An integration test maybe wasn't really necessary (this is also something a bit special)


$ git init
$ git add .
$ git commit -m 'initial commit'


我有找到原文 https://cwiki.apache.org/confluence/display/KAFKA/Consumer+Group+Example
但是我真心覺得原文文法怪怪的...XD
if total number of threads which you provided is more than the number of partitions on one topic, some threads will never see any message.


it's not necessary to change knownHeaders array type  to dictionary. All of this code related to known headers can be simply changed to:

    knownHeaders [idx] = String.IsNullOrEmpty(knownHeaders [idx]) ? value : knownHeaders [idx] + ", " + value;


- [ ] CDATA is unnecessary


What sorts of warnings do you see? For Guava, we have this for a different `javax` annotation package:

    <!-- GWT requires a library's transitive dependencies to be present when
         compiling a project that uses that library, thanks to its full-program
         compilation, so we don't use optional=true. -->
    <dependency>
      <groupId>com.google.code.findbugs</groupId>
      <artifactId>jsr305</artifactId>
      <optional>false</optional>
    </dependency>

Would something like that work here, or is `javax.inject` or Dagger different in some way?


Create develop branch
In CacheableDataService.cs you should add an else to any method that access cache, and add an empty list if null is returned.

else
                        {
                            cachedItems = new List<T>();

                            lock (itemLock)
                            {
                                if (cacheType != null)
                                {
                                    //create list of parameters
                                    List<ICacheItemExpiration> cacheParameters = new List<ICacheItemExpiration>();

                                    //add sliding expiration time to cache parameters
                                    if (expirationMinutes > 0)
                                        cacheParameters.Add(new SlidingTime(TimeSpan.FromMinutes(expirationMinutes)));
                                    else
                                        cacheParameters.Add(new SlidingTime(TimeSpan.FromMinutes(DefaultExpirationMinutes)));

                                    //add items, key, and parameters to cache through CacheManager
                                    CacheManager.Add(
                                        key,
                                        cachedItems,
                                        CacheItemPriority.Normal,
                                        null,
                                        cacheParameters.ToArray<ICacheItemExpiration>());
                                }
                            }


You can write a short text there in OSMBC that you have done a review in Wordpress.


I just took lang/squeak dragonfly patch as example: sqVirtualMachine.c
all checking if freopen returns NULL looks to be just on NT (based on comment)
This code segment is just for bugreport submission, text still be printed in stderr


My understanding is that there is no need to manually exclude `super`. Apparently the `super-source` element takes care of that? Can you remove the `exclude` and see if it causes any problems?


This should go into it's own PR.


Nope that's wrong. check the bytes:
```-0x0000008a hit0_0 ac6c6c68
+0x0000008a hit0_0 000e0007


data 是複數
Sometimes, when reading messages from multiple threads, we want to know how those data are consumed rather than the order of data


FYI bisect shows that this commit introduced #4097


This seems to break loading Brython from localhost; here's a message from my console

Uncaught SecurityError: Failed to construct 'Worker': Script at 'https://cdn.rawgit.com/brython-dev/brython/master/www/src/load_file.js' cannot be accessed from origin 'http://localhost:8000'.load_ext @ brython.js:4040brython @ brython.js:4137onload @ monde.html:25


This should work fine as a harness. You may not get `inner_benchmark_loop` optimised in some implementations, which may reduce the speed in JRuby, as it can't independently compile the block either.


Please keep the .gitignore stuff as a separate commit


Why is this overriden


Why is this overriden?


Benchmark code itself seems fine.


Opened by hand in OS app. Then deleted the directories that got made when doing that. If we are at 1.10 I can do this again.


To je sam rename biu


@krux02 pushed a new commit adressing the relativeness.


Code Quality - Critical

301 shouldn't be used in this case. It indicates that a URL/resource has been moved permanently. 400 or 500 is appropriate in this instance. This is a link [https://en.wikipedia.org/wiki/List_of_HTTP_status_codes](https://en.wikipedia.org/wiki/List_of_HTTP_status_codes)


It's worth noting that this is not an atomic operation though in this case it doesn't matter.


When I add foreign key to players table, the program does not work correctly on blumix. It works but I can not add new player to database.


Umm, haven't touched the `package.json`...

Used `npm install --save redux-logger@2.0.4`. I should have used `--save-dev`, right? :/


I'm not sure why I don't just send the item ID over the network (Because I know its synchronized), and my logic was that it was NBT and I pretty much didn't care about that quite as much as to include a full on registry.

What's also annoying (this is in my forum post) is that item IDs can change whenever they feel like it in 1.8.8, so I'm going to have to make everyone who wants to take an existing 1.7.10 world into a custom version of BC for 1.7.10 to transform the id's into the registry ID's.


Hi @tuan23, this commit make all my transitions "flickering". For example when I change tab (transition "instant"), the new window open, then the old window reappear and the new window reappear again, all that in 0.4s. I tested with 0.7.1 and I don't have this problem.


a couple of improvements:

1) only display the "add domain" button if it was an external script (or any other XSS attack to which it applies)
2) don't bother searching for URLs regardless of the policy content, because if you extract a URL from any other content, it has no effect. it could be misleading to the user.
3) possibly wrap and pass the effective domain from `XSSFilter::NotifyViolation`, instead of re-getting it in javascript. not sure what's cleaner.
4) the whitelist could also control `PermitsBaseElement` and `PermitsExternalObject`.


Worth adding an alias here? Also, grammar seems a bit off.

    -q, --quiet     Quiet mode: don't print the config, only validate


what does this try to do?

```python
>>> match = re.search('^/(.+?)(/.?|$)', '/pets'); match.groups()
('pets', '')
>>> match = re.search('^/(.+?)(/.?|$)', '/pets/'); match.groups()
('pets', '/')
>>> match = re.search('^/(.+?)(/.?|$)', '/pets/test'); match.groups()
('pets', '/t')
>>> match = re.search('^/(.+?)(/.?|$)', '/pets/test/ff'); match.groups()
('pets', '/t')


Yes in Outlook Express spell checker for example, if you operate the button with space, you now gat pressed not pressed spoken, but if you use enter the speech is bypassed as you then get the focus shifted by the sound of it.
 This seems to have opened up a whole can of worms hitherto un-noticed with the lack of pressed, so to speak.
 Maybe the better solution was to suppress the unavailable we heard before when the button was not flagged as a toggle or a one time press type.

Brian

bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
  ----- Original Message -----
  From: James Teh
  To: nvaccess/nvda
  Sent: Sunday, December 06, 2015 11:16 AM
  Subject: Re: [nvda] When a toggle button is focused, NVDA now reports when it is changed from pressed to not pressed. (f67746d)

  The problem is that although this issue was filed for these particular
  toggles, there are other similar toggle buttons elsewhere for which we
  should also speak "not pressed". So, this is a core issue, not just an
  issue for these specific controls.

  We definitely shouldn't speak "not pressed" for checkboxes, but it's not
  so simple for buttons. Even normal buttons get the pressed state briefly
  (even visually); you would always have heard "pressed" in the past. I
  agree that hearing "pressed" and then "not pressed" is rather annoying,
  but I'm not sure how we can differentiate normal buttons from toggle
  buttons yet.

  —
  Reply to this email directly or view it on GitHub.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.906](http://teamcity.monogame.net/viewLog.html?buildId=12009&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


Nevermind the bug was because of my `addr -> base_addr` change


I know the difference between build and install, but IMHO the make tasks are misleading as build in reality invokes install which should be a separate task


OK, it looks like jsr305 includes its sources in the main jar. That's probably at least part of the story.


This is generated code from the mavlink common.xml, you would add it here https://github.com/Event38/ardupilot/blob/E386_Autolanding3/libraries/GCS_MAVLink/message_definitions/common.xml#L142

however, you don't want to put E386 specific things into master. I assume your custom MissionPlanner is checking for this. This belongs in your own branch


This does not belong in master.


Develop is at 1.10, thanks @DavidGoldwasser


# Stuff 'n things ...


@juliaelman Might you consider contributing these upstream to 18F/guides-style?


This doesn't sound right... The whole *point* of Ember object properties is that they're observable, and react to value changes.
In fact, all that a function ending in `.property()` does it turn that function into an Ember property (like the original `available`).


TeamCity Dirigo Edge :: Pull Requests :: Pull Request Smoke Tests [Build 151](http://teamcity.corp.dirigodev.com/viewLog.html?buildId=1794&buildTypeId=DirigoEdge_PullRequestFullChain) outcome was **SUCCESS**
Summary: Tests passed: 6 Build time: 00:01:23


- "Use checksums, digital signatures and other validation mechanisms to help detect file tampering."?
- "When an attacker attempts to manipulate the application, the correct checksum would not be preserved and this could prevent illegitimate execution."?


check if flirt_func->name[name_offs] != 0 to avoid unexpected explossions


@mbland of course, friend! :+1:


in fact, you can just use strchr


Thanks Tony, previously I had downloaded from 84cc4e4<https://github.com/tonytomov/jqGrid/commit/84cc4e47fbe0b7ab38a5ee59c225ab982855625c>, I have now downloaded from 232ba0a<https://github.com/tonytomov/jqGrid/commit/232ba0abed8b9ab4bbab2d591256b73a40018248> and now the change is present in jquery.jqgrid.js.

I have tested it with both minified and unminified, and it appears that the problem is fixed, so I have closed the ticket.

Thanks again Tony for the prompt response.

Regards,
Alan

From: Tony Tomov [mailto:notifications@github.com]
Sent: Monday, December 07, 2015 11:35 AM
To: tonytomov/jqGrid
Cc: Abel, Alan - PENNINGTON NJ
Subject: Re: [jqGrid] Equality set of width in dragEnd and setGroudHeaders. Thanks to iguana3 (84cc4e4)

Hello,

Please go here: https://github.com/tonytomov/jqGrid and there is a button Download ZIP (at right in the middle of the screen) click on it. Alternatively go here 232ba0a<https://github.com/tonytomov/jqGrid/commit/232ba0abed8b9ab4bbab2d591256b73a40018248> download the file.

—
Reply to this email directly or view it on GitHub<https://github.com/tonytomov/jqGrid/commit/84cc4e47fbe0b7ab38a5ee59c225ab982855625c#commitcomment-14825424>.

----------------------------------------------------------------------
This message, and any attachments, is for the intended recipient(s) only, may contain information that is privileged, confidential and/or proprietary and subject to important terms and conditions available at http://www.bankofamerica.com/emaildisclaimer.   If you are not the intended recipient, please delete this message.


Nothing major done just moved things around for consistency, removed php file as we don't need it, and commented and referenced all external site we used.


That's realy rude! Why completely removing the original author? THAT IS A COPYRIGHT ISSUE THOUGH AND IS AGAINST THE LAW! Read the offical LICENSE Notes!


there are big endian PE files, this just breaks the support for them. im not going to merge this. tests needed


also the `alert` in the other button could be changed to a neater UI element. no idea what, but alerts are really ugly :-)


Okay you can do the following.
1. Move this current `test.py` file to `sampleUsage.py`
2. Create a new `test.py` file and `import unittest`
3. Write a simple test in `test.py` as follows, here's an example for you to experiment with
```python
from loklak import Loklak
import unittest

class loklakTest(unittest.TestCase):

	def testHello(self):
		l = Loklak().hello()
		self.assertEqual(l['status'],'ok')

if __name__ == '__main__':
    unittest.main()
```
You can directly use this, but You need to write another test for this for any other function before I can accept your submission.


Already?... really?


There's a typo. And I think, you should add <p> elements, so that it looks good in HTML as well.


@tboerger If anything is misleading it is `go install`, as it isn't really "installs" stuff system wide, like other (eg. autoconf) tools do, putting files in `/usr/local/`. It just copy stuff into your `$GOPATH`. I don't see anything wrong with having that executed by default by make.

If we ever have `make install` target, then it should in fact install gogs into so system wide place, copying also all necessary templates.

Btw. This PR didn't change the Makefile behavior in regards to that, it just optimized install & build pair into simple install & copy.


- "If an attacker has tampered with or re-signed the application, the comparison will fail resulting in the detection of tampering with the application."?


I think the `resp_expiry_key='expires_in'` here is an error.  The box response token has `expires_in` as the integer number of seconds until expiry.  It does provide `expires_at`, which is the expected floating-point timestamp.


Tests pass with just:

```
<module>
  <source path=""/>
  <super-source path="super"/>
</module>
```

That's a good start, anyway.


Thanks so much! Please send a PR along when you are ready. <3


https://gist.github.com/derivator/7a870555cf4b5976c9fa This is the result of make, after I modified the makefile to echo "executing $(GAPI_CODEGEN)" and with gapi3-codegen modified to read
```
echo "gapi3-codegen up-to-date version invoked"
mono --debug /usr/lib/gapi-3.0/gapi_codegen.exe "$@"
```
/usr/lib/gapi-3.0/gapi_codegen.exe is from the gtk-sharp-git package that I built myself today using this https://github.com/mono/gtk-sharp/commit/89b2dae6d82bfb22ee8641e5bbd6d42dcbab8c17 revision and [this](https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gtk-sharp-git) build script.


@lattner You the man! Hello Swift!


`[CWE-354: Improper Validation of Integrity Check Value](http://cwe.mitre.org/data/definitions/354.html)`


？

- 发送自我的Sony Xperia™智能手机

---- Mingcong Bai编写 ----

Already?... really?

---
Reply to this email directly or view it on GitHub:
https://github.com/AOSC-Dev/aosc-umaru/commit/de0adb3d43c2d3972fc9dc73c90049758bef377f#commitcomment-14827114


looks like clang also obeys that GNUC >= 4 rule, so this patch looks good to me. can you also send this PR for the SDB project, not just r2? because those sdb files come from the other repo, r2 just copies then when `make -C shlr sdb-sync`


Good catch here @rbarbera


I think it'd be good to use the `isPlainObject` function here instead of `_.isObject and _.isArray`, because that function contains this same loigic, but it looks like it handles a few additional edge cases (e.g. `Color` objects).


Try rebasing when you need to...


this stuff is related to https://github.com/radare/sdb


Heh, did the linter really complain about this? I suppose I should have put `// falls through` here, but this kind of thing is done elsewhere in this very file so it's interesting if it only caught one case.


:clap: @rbarbera


I'm slow. But I get there sometime :)
On Mon, Dec 7, 2015 at 9:01 AM Jeffrey Wescott <notifications@github.com>
wrote:

> Whee!
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/LearnersGuild/guide/commit/588029583217dd0ab971d86674e5de095f29b077#commitcomment-14826076>
> .
>
--
"When they tell you to grow up, they mean stop growing.” ~Tom Robbins


Pretty sweet! We have C++14 now, perhaps the lambda could be written as
```
[](auto const& p)
...
```


LGTM. Thanks for adding this.


Line 171 and 196


Ah, I see, makes sense.

Wait, though -- don't rejected promises get kicked up as exceptions? I don't think you're ever going to get to the `then` with rejected promises...


Should this be in this commit? Kind of confusing.


unsigned what (i know it defaults to int, but r2 codestyle tries to enforce type size in definitions). please use `ut8` here.


rejecting since I'm replacing all the files right now.


Any way to do this in C++?


Thanks, fixed.


is b really that big?


- capitalize the "i" in "iOS" because it begins the sentence


Ok.


I dig it (sorry I missed this earlier). I'll have it in the next release.


This will probably have a merge conflict with this PR once it gets accepted since it's the same lines of code. Easy conflict to resolve, just saying it's probably inevitable.

https://github.com/diydrones/ardupilot/pull/3196


@ncannasse I feel like this should not be necessary for private types, but XmlParser gives `Incompatibilities between _List.ListNode in neko and js (type kind is different)`, if they are not both classes.


I don't agree with you. make install does exactly the same, install the files with a predefined prefix, exactly what go does with GOPATH. I suggest a make install task and make build executes install and the cp afterwards. That's a consistent behavior.


**Code Quality - Nitpick**

The `])` should be on a new line


OK.


Changes uploaded to develop-branch.


@EladBezalel Regarding this snippet of code:
```javascript
 element.addClass(isSmScreen ? 'md-bottom' : options.position.split(' ').map(function(pos) {
         return 'md-' + pos;
 }).join(' '));
```
If the screen is resized to be larger while the toast is visible, it can have incorrect values.  Really it is kind of trivial, and watching for a screen change is probably too expensive? Maybe mdMedia could emit an event on a breakpoint change?

More importantly, is the media query still correct after the addition of xs?


@matheussilvasousa tenta sempre colocar a ISSUE que se refere o teu commit na mensagem do teu commit


Exactly that. Or to be more precise:

```python
>>> match = re.search('^/(.+?)(/.?|$)', '/pets'); match.group(2).strip('/') == ''
True
>>> match = re.search('^/(.+?)(/.?|$)', '/pets/'); match.group(2).strip('/') == ''
True
>>> match = re.search('^/(.+?)(/.?|$)', '/pets/foo'); match.group(2).strip('/') == ''
False
>>> match = re.search('^/(.+?)(/.?|$)', '/pets/foo/bar'); match.group(2).strip('/') == ''
False
>>>
```
It doesn't handle nested resource names. Possible, but with a lot of other implications.


I think the message should be something like `Sorry, This page does not exist`


Wait a sec, other issues in animation.py


Why is the `min_version` on Mac "10.7.x" but on Windows it is "7"?  Is there something platform-dependent there?


Please add tests for the cases in which `refresh_oauth_key` does nothing, i.e. `account`, `auto_refresh_url`, `client_id`, or `client_secret` are None, and when `force` and `_needs_refresh()` are both False


**Code Quality - Awesome**

I like that you are using helper functions rather than Facades :smile:


Aha plus si dal namesto minusa. Now that makes sense...


Halleluja!


This aborts without saving the new meta,
so if 5 items are there and it's charged for 4.5,
after using it 1 item is there then but it's still charged for 4.5.
Did l miss sth?


I recently fixed the other case: https://github.com/Zarel/Pokemon-Showdown-Client/commit/1d514bc6eca49df062969f511006e5c1b2611496#diff-b502a7533835db1d325f945bc2b7fc08R4066


No, 1000 is too much for ut8.


@duglin this is what i was referring to in https://github.com/docker/docker/pull/15964#issuecomment-162562641


Thanks for your contribution!
I've opened up https://issues.apache.org/jira/browse/AMBARI-14254 for this as every change needs to accompany a JIRA.
Please upload your patch there and we can move forward with merging the patch.


- "When an application is in use, user- or application-specific data may be stored in RAM and not properly cleared when the user logs out or the session times out."?
- "Because Android stores an application in memory after use until the memory is reclaimed, encryption keys may remain in memory."?


Max 7 platform requirements? Is that incorrect?


@thebigmunch Ok, sorry. I missed that it was related only to the WebClient interface. I'm wondering if it would be possible to use some kind of token authentication (to generate with help of the browser visiting an authorization page or using password once).


use wunderlist or Wunderlist / Microsoft, at least if we re-use this list somewhere :)


both items showing the same price because both menus were having the same items.


Fixed this:
<img width="447" alt="screenshot" src="https://cloud.githubusercontent.com/assets/7561396/11634934/cbb47ffe-9d13-11e5-9d1c-f1c1af0d123a.png">


See https://github.com/rstudio/AdminLTE/tree/shiny-mods.


107310700-change-license-text (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (903 of 903 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.57%25-green.svg)


Thanks for prompt response!
I am using gcc version 4.8.
Here is the stderr.
[20151207_compile_log.txt](https://github.com/sequencing/EAGLE/files/54368/20151207_compile_log.txt)


@rbarbera I created a task for that and I'll review it. I'll try to make it more clear graphically.


Done.


Nevermind, my brain is bent and I was conflating Max version vs OS version.  Sorry.


TeamCity pull requests :: netty [Build 805](https://garage.netty.io/teamcity/viewLog.html?buildId=3863&buildTypeId=pulls_netty&guest=1) is now running


Yeah, I agree. I'll revisit this and see whats going on.


threshhold recently got renamed to threshold
see https://github.com/minetest/minetest/commit/a78dd7f2b6b0e1fefdbaa1ae21b722dd4459e4f4


Did you mean to remove these output modes?


I am so dumb. I "tried" this the first time I wrote this but for some reason thought `super(mqtt.Client, self).__init__(*args, **kwargs)` was the right way to do.


Please see BioroboticsLab/biotracker_gui#22 for additional information


Yeah. We didn't actually have 'verbose', 'short' or 'json' modes. github.com/rlerdorf/phan had a 'verbose' mode that added some summary info, but that wasn't copied over.


Yeah, thats the difference between `allSettled` and `all`.

"RSVP.allSettled is similar to RSVP.all, but instead of implementing a fail-fast method, it waits until all the promises have returned and shows you all the results. This is useful if you want to handle multiple promises' failure states together as a set."


Landscaping changes look great, though I'm sure many of those static plants are not selectable. I'll definitely add support in Pro Farming.


I created a task for it https://trello.com/c/MNOynKbZ/7-materialize-dematerialize-example-is-not-clear , thanks @rbarbera


@TobbeMobiTV
So if we take this out which we did in 2.0 we should also do something like this in buffer level rule.

if (type === "fragmentedText"){
            bufferTarget = textSourceBuffer.getAllTracksAreDisabled() ? 0 : trackInfo.fragmentDuration;
}

So that we do not schedule too much forward  buffer allowing much quicker switchers since we are not clearing the buffer.  Obviously there is some underlying issue when clearing the buffer that should be fixed but that is much bigger project.


- "Do not keep sensitive data (e.g., encryption keys) in RAM longer than required. Nullify any variables that hold keys after use. Avoid using immutable objects for sensitive keys or passwords such as in Android `java.lang.String` and use char array instead. Even if references to immutable objects are removed or nulled, they may remain in memory until garbage collection occurs (which cannot be forced by the app)."?


Sure, I can make this public. What would you suggest as a different exception for this method to throw? It's implementation is reading some input source, so I think IOE is entirely reasonable.


Ah right, maybe add text to the array though?


https://github.com/18F/guides-style/pull/22 FYR


OK, could you refactor the logic into a small function like "is_collection_endpoint(...)" returning True/False?
The current split between re.search and the strip() in the if statement is pretty weird and hard to understand


:D


Thisis ammended, will be rectified on merge


Good catch. Added in https://github.com/etsy/phan/commit/31903b3c4c94739de6ca086b576ec6cda161d57b


> Data must be an array, a file string or a Config object.

I added the todo because of the`InvalidArgumentException` message. I'm assuming it would be something like:

```
if ($data instanceof ConfigInterface) {
	$this->set_data($data->data());
}
```

But I've just realized there isn't such a method and all data is attributed to the `AbstractConfig` class and not some `AbstractConfig::$data` property like `Pimple\Container` to make it easy to extract.


no spaces around binary op *? any reason you need to test 0 == data->Temperature? Is it for performance?


- `[CWE-316: Cleartext Storage of Sensitive Information in Memory](http://cwe.mitre.org/data/definitions/316.html), [CWE-200: Information Exposure](http://cwe.mitre.org/data/definitions/200.html)`


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.906](http://teamcity.monogame.net/viewLog.html?buildId=12009&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 560, ignored: 6 Build time: 00:21:36


Right that's why i use these cheaper versions. Also for trylock and unlock below.


You're right. I've inserted the return statement at the end of the catch IOE clause.


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 66](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=568&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) is now running


Here and in other places, we pass ImmutableTreeMap<T1,T2> by value (instead of say by reference to const). I see the implementation of ImmutableTreeMap will only copy the root of the tree which has constant size and is therefore cheap, but it is still up to 6 members (and possibly a tag member; not sure how CPPML compiles down to C++). Wouldn't it be beneficial for performance to change these to references to const?


I see, you have forked minetest now. Diversity is a concept that has created humans, so it isn't too bad, but still I'm sad every time this happens.

Little note: If you used merge commits to merge stuff from minetest, the links to commits (like in this one) would actually work (compare to https://github.com/minetest/minetest/commit/51e8c2b27786c050f0271eeeaed5eea17d62f0a0). I guess its more work to actually manually replace it. You can still not do merge commits for other things like pull requests, this avoids most of the arrow mess while still being "stable" with commit hashes.

Good luck!


Can you please check if the time spent in AA inside DSE is reduced?


TeamCity Xbim :: Xbim Windows UI :: Xbim Windows UI [Build 66](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=568&buildTypeId=Xbim_XbimWindowsUi_XbimWindowsUi) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:00:47


If this change is only to suppress a compiler warning, maybe it'd make the most sense to use compiler directives to do that (if possible), instead of adding a meaningless line of code. I'm inexperienced with C++ and seeing this in the code (especially uncommented as is) would confuse me.


A good name for a cat


why is the order of the two lines swapped? it is typically better for merging to avoid changing the order of lines unnecessarily


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8355](https://teamcity.mesosphere.io/viewLog.html?buildId=87675&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:10:24


I've checked all PE in tests, there are only one file with this flag: "imports_1210.exe". But it's also little-endian, look at virtual addresses stored in "DATA" section.

https://msdn.microsoft.com/en-us/windows/hardware/gg463119.aspx
> IMAGE_FILE_BYTES_REVERSED_HI
> 0x8000
> Big endian: the MSB precedes the LSB in memory. This flag is deprecated and should be zero.


Tested fix. LGTM


I am about to.


OK, it looks like I went down this road last year. This approach seems fine to me.

Here are my notes from last year (internal bug 18168870, for any Googlers), slightly revised and updated:

Gin has a .gwt.xml that covers javax.inject and its own copies of the javax.inject sources.

Last year, we modified the Google-internal copy of jsr330_inject to have the same.

My concerns are:

1 (minor, I hope): Does everything work right with GWT if both jsr330_inject and Gin are on the classpath? I assume that it must because I assume that this is already happening internally.

2 (larger): What do we do outside Google, where only the standard, source-less jsr330_inject jar is available? Options:

a) Change jsr330_inject to contain a .gwt.xml and sources (feels unlikely to me)
b) Have jsr330 provide an official jsr330_inject-gwt (more likely but still questionable)
c) Do basically what Gin does: Provide our own copies of the jsr330 sources, referenced from our .gwt.xml as part of Dagger
c(2)) the same but as a separate artifact, an unofficial jsr330-inject-gwt artifact that would also be usable by Gin and others


Yeah it's missing quite a few methods, thats just what I got done in 2 free hours. Stuff I want to add are: ContainsAtLeast(ItemMap), ContainsExactly(ItemMap), a constructor from a list of itemstacks, a method to convert an itemmap into a list of itemstacks, containsMultiplier(ItemMap) (how often is it contained/ how should we scale the output) and everything you mentioned.

I dont plan to specifiy those ItemMaps in the config, we can just use the standard itemstack descriptions there and then internally turn those into itemmaps. That makes it easier to understand and in terms of config options its pretty much the same.


it's usually better to do validity check at the beginning of the function and avoid complicating the logic inside the implementation.


Just a drive-by review: although you check $seven later on, you still "require" utf8, so that breaks -seven's semantics. An explicit 'use utf8' shouldn't be necessary since this is conditionally done in the BEGIN block, though obviously I haven't checked to see if it works without it.


Hello everyone!


That was a change from the original code... might be helpful to revert changes that don't work?

(P.S. What do you think about separating this page into another repository? It would be set up like the website-testing repo, so you'd view the site at farmingtonrobotics.org/hourofcode but its code would be separated from the rest of the site.

Might have saved you a bunch of work moving around the files. But we are already in this far so you can ignore me lol)


(1) is there an easy way to check policy type (If i want to use l10n in the future for this, I'd rather not check on exact strings)

I don't understand (2). What exactly are you saying?
As far as I understand, if you have an external script or (base element/object), the only place to get it cleanly would be from the unsafe content. The URL itself will have the attacked domain as a first.
How else would I get the base domain? Maybe I misunderstand your interface.

(4) yeah, found that out the hard way (e-mail) ;)

I'm not sure what else to use but an alert for the other button, really. Do you have any ideas what would work better that doesn't interfere with page content?


The object search didn't work, it returned true no matter what was being searched for!


For simple things like this, any reason not to use `package` which abstracts over this and avoid the code duplication?


@cathydeng These comments should be docstrings. http://stackoverflow.com/a/3899154/98080


Okay.

*Opeyemi Ogunjimi | Software Developer | Andela*
*See what CNN
<http://edition.cnn.com/2014/12/24/tech/africa-tech-startups-2014/> and WSJ
<http://www.wsj.com/articles/is-africa-hiding-the-next-mark-zuckerberg-the-future-of-tech-talent-1449242360>
are saying about Andela!*
(c) +234-703-936-2475 | Andela.com <http://andela.com/>


Зачем `call`? Разве простой вызов не сработает? Ниже он-то нужен потому что передаётся функция, а тут она сразу вызывается.


❤  @jeremy


This is essentially a blot map vector.


Why do you need the isTopLevel() check? It's perfectly OK to perform this operation for a top-level property.


Makes sense except for one thing I was trying to solve with AdvancedItemStack in Contraptions:reboot -- wildcards. So the easiest case is: All log types (unbounded durability, multiple top-level types).

In other words, how do we specify that the input rate is allowed to be any kind of log, etc.

Otherwise, sounds awesome :D


The zero check is because the sensor returns 0 as temperature once in a while and it throws off the logic. No way to tell why it gives a 0 reading but it clearly is not true so I just ignore it.


glm has mat2 as well. why not remove this too?


Okay.

*Opeyemi Ogunjimi | Software Developer | Andela*
*See what CNN
<http://edition.cnn.com/2014/12/24/tech/africa-tech-startups-2014/> and WSJ
<http://www.wsj.com/articles/is-africa-hiding-the-next-mark-zuckerberg-the-future-of-tech-talent-1449242360>
are
saying about Andela!*
(c) +234-703-936-2475 | Andela.com <http://andela.com/>


Можно написать короче:
```js
var fn = a => $join(a, '<span class="de-menu-item">', '</span>');
```


Why not use a blot map vector?


*we're not worthy*
*we're not worthy*


Maybe not the best place to ask, but none I'm aware of, anyway.


This ignores any other itemmeta than enchants (name,lore,repair value etc.), while for isSimilar everything has to be the same except for the amount. The functionality of isSimilar is represented in the standard getter here which uses an itemstack


Yep, thanks


You can (and should) use the 'spot' tag in the after template too.


Seems this should be

```
if (svg.childNodes && svg.childNodes.length > 0) {
```


@ephemer This is the commonly used method to suppress unused variable warnings in LLVM and Swift.


Бездумный копипаст.


What do you think of merging the github issue link into the top of the footer?


current element data?


можно я избавлюсь от helpingArray а не от этой? или ты хочешь чтобы я именно от filteredArray избавилась?


They're linked by a GitHub server at [team178.github.io](http://team178.github.io). GitHub is magical.


Co to za głupia nazwa


Nice, works like a charm! :ok_hand:


Głupia nazwa głupia nazwa :(


@classilla That's why this is a pull req and not a direct push to `master` :-D

AFAIK the `use utf8` is required for the file to be parsed if it contains any UTF8 characters at all, in this case `␤` and `␍`, but my perl-fu is not good enough to know how to do that using codepoints and go back to ascii-7.

But, yeah, I only tested this for my specific use case.


@nadavrot thanks for the reply


swietny program, daje plusa


Dzięki Krzysztof :dancer:


thanks for updating this!


dobry poczatek programu


fajne zmienne


i dont like it <3'/[


Hmm. It looks fine to me:

1. execute regex
2. conditionally interpret group 1
3. conditionally interpret group 2

Could be because you we're looking at the diff instead of the whole function, but I guess being more explicit can't hurt.


truman is lame


we should change this - we shouldn't call anything 'minioStorage'  we should call it `isVirtualHostSupported`


suuuuuuuuuuuuuuuuuppppppppppppppppeeeeeeeeeeeeeeerrrrrrrrrrrrrrrrr lame


jk <3 truman


fajna klamra


mogło być lepiej


Ой вей. А ведь и да.


The Key is a pair of pointers (plus other stuff). BlotMapVector does not allow you invalidate parts of the key. So, if you want to invalidate a pointer you need to iterate over all of the keys in the map.


co za niespodziewany koniec


Did you intend to change the username here and at line 46/47?


Intended change?


architecture


LGTM here.

I'd have had a little easier time reading if the commit had said _what_ was different about how it works


nie narzekaj. sam byś tego lepiej nie zrobił


Seems good idea. Need to see if docker copies the file (not the symlink itself) though.


Shiny!


I like the look of this a lot… how did you produce this? TeX?


false is invalid in C


reliability


``endPoint has to be "https://s3.amazonaws.com" for AWS S3`` -> can be better ``AWS S3 endpoint should be https://s3.amazonaws.com``


bool is invalid in C


Keynote.


Shiny shiny! A much better primitive.


This brings the version closer to the "master" copy in the other branch. Agreed in general but this case is pretty innocent..


Это не то что я имел ввиду. Имя файла не должно содержать пробелов. Документация должна оформляться внутри /**<документация>*/ посмотри pep8.


This should be the paycoin port.


`true` is invalid in C


probably


I was going to chip in because I so desperately need this addon, but it says campaign not found.


Krzysiu gdzie masz krzesło ??


Dobra biblioteka, polecam


self лишний :) хотя это и мелочь.


I think that could be solved with the current implementation and an additional flag to only compared based on material. ItemMap already offers a method to get all entries with a specific material, so you could just use that and count how many items of that specific material are in the map. Might get a bit weird to implement, but should be possible.


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.610.9ba181bd0fedb570c52489efdafcc267126b306e](http://build.palaso.org/viewLog.html?buildId=66956&buildTypeId=bt223) outcome was **SUCCESS**
Summary: Tests passed: 3404, ignored: 125 Build time: 00:08:16


nie rozmawiam z tobą jak nie masz krzesła :(


Thanks for clarifying. Actually, you didn't ignore it in this line. When data->Temperature == 0, sensors.Temperature = 0.


Krótki program ale działa


During peak hours <comma>


Doesn't appear to exist.


saw approval from javajolt
at https://github.com/basho/riak_kv/commit/de3da45c2c26cc246819a4b95d99024118c58189


merging basho/riak_kv/bugfix/jrd/1293 = de3da45c into borshop-integration-1295-bugfix/jrd/1293


basho/riak_kv/bugfix/jrd/1293 = de3da45c merged ok, testing candidate = 5ae1901f


Ah - for record around here, this changed from a "grab all subscriptions and filter" to "one specific call"


Add some comments here.


Also doesn't appear to exist.


trolololol


huehue


Again the port number needs to be updated.


Here a small preview for the BioJS 3.0 project website (how I imagine it) http://daviddao.github.io/biojs3/ - i will create a polymer interface for our best components until friday


Troubleshooting. UTF-8 Character enc. dec. '195 133' problem. Same for the other changes this date too.


dadasdsadasdas


How do I get the mini-games to work?


GameUI was split in the 3 new classes, so it's due to be deleted from the project


Fix the space in SEO Title.


Agreed in general but in this specific case the sensor could give erroneous reading of 0 so I have to ignore it in this location.


we can support 'authenticated-read' as well for libraries.


It sis OK, but maybe standardize the parameters and the Given should be on background


drugi komentarz pod caloscia


Removal of mat2 happens in a subsequent commit


This was intended to work with https://github.com/rackt/history/pull/173. Right now the API between `createHref`/`createPath` and `push`/`replace` is not consistent. I don't know how we want to sequence this - my first choice would be to merge and release https://github.com/rackt/history/pull/173.


а) вот это не очень хороший подход, когда у класса есть метод `stars` где грязные данные, и метод `get_stars` где «чистые»
б) ну и в целом код «разделить по запятым, соединить по запятым с пробелом» — он какой-то мммм немножко слишком вычурный; я бы сделал чтобы в классе хранился _массив_ актёров, а кому нужен он более красиво представленный — пусть сам форматирует


Hmm. We'll see how it plays out. There are a few other edge cases that might be harder/impossible regardless: "Any chestplate" etc.


> I see, you have forked minetest now. Diversity is a concept that has created humans, so it isn't too bad, but still I'm sad every time this happens.

Why sad? I'm not leaving Minetest nor will this fork likely split the community or anything ;)

> Little note: If you used merge commits to merge stuff from minetest, the links to commits (like in this one) would actually work.

Ah, good to know. Anyway, i don't like merge commits, so i will try to do this manually in future. (let's see how long).

Here i actually didn't think of it, for issues and pull i didn't change since i didn't want cross-notify that much.

> Good luck!

Tanks, but I don't think there will be a (large) userbase anytime soon. I forked mainly because of doing the stuff i want to, without the need to argue weeks (or endless) to merge a new feature or change things that needs to be changed IMO.

But contibutions are welcome ofc ;)


LGTM


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.618.9ba181bd0fedb570c52489efdafcc267126b306e](http://build.palaso.org/viewLog.html?buildId=66955&buildTypeId=bt322) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 3382, ignored: 106 Build time: 00:11:13
### Failed tests
```
SIL.Windows.Forms.Tests.dll: SIL.Windows.Forms.Tests.Progress.Commands.ProgressDialogHandlerTests.EndsInFinishedState: <no details avaliable>

```


Also move this to 'isValidACL' function.


RIP my good notation


Constants don't count. But you have something like `GAME_TYPE` so you might not even need the `PLAYER_1_TURN` thing..


Proofread.
Some spelling typos and one missing comma.
I feel that some areas could use less verbiage and more active voice.


Goody


I find the lack of transactionality here disturbing. An exception in revokeSponsorship after it has been revoked will leave the user unsponsored


Looking at these two together, we should factor out this bit of code into a separate function.


why is this commented?


Add comments for newly added functions.


@gravgun This is my try to merge both versions. Let us talk a bit more about the terms.


True about the ignoring. The formatting is fixed in a subsequent commit; after the final one there are spaces around binary operator *.


Then you have a toHTML compatibility method, so the first case now catches
it (when previously it was to restrictive)

On Mon, Dec 7, 2015 at 12:21 PM Kevin Glen Roy Greer <
notifications@github.com> wrote:

> What if it extends Element rather than implementing toE()?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/foam-framework/foam/commit/fff4f970f05f90a0b94a0585e5d0ff3d2c23350c#commitcomment-14826576>
> .
>


I'd actually rather have a hard invariant here that we don't get both `to` as an object _and_ the extra `<Link>` props specified - I think we want to eventually drop those, so we don't want people to do e.g. `<Link to={{ pathname: '/foo', state: { the: 'state' } } query={{ the: 'query' }}>`.


where are util and lodash used in this code?


:+1: again.


Hurray! It worked! Thanks @gluxon & @gisellegk!


I love you.


Why did you move the include upper?


Nicely spoted. Thanks.


for https://github.com/sunsetmtn84/studio/pull/6455


Keywords:
Entrepreneurship Bootcamp for Veterans
Boots to Business
Veteran Women Igniting the Spirit of Entrepreneurship
Onward to Opportunity


estava a ver que não xD


Basic framework

Zaczyna się w klasie MyGame, gdzie tworzymy nowy ekran, czyli GameScreen. GameScreen przekazuje robote do GameRenderer czyli do miejsca gdzie wszystko bedzie rysowane i do GameWorld czyli takiej klasy gdzie mogą być tworzone wszystkie inne elementy gry. Jest tu jeszcze player, ale tylko po to, żeby się coś działo. Feel free to change anything.


Thanks for the quick response. I tried this out today, and you're absolutely right, `0.4.7` fixed my issue. I had the line `include Rails.application.routes.url_helpers` already, but for some reason it didn't make a difference previously. Thanks for confirming this for me, and thanks for `exception_handler`, it's be extremely helpful.


This creates a use after free.
fclose frees this->urandom_fp in the if statement.


ahushaush,
Deu trabalho, mas queria concluir ^^ !

2015-12-07 13:59 GMT-03:00 Ruan Nícolas <notifications@github.com>:

> Até que fim ein brow.' heuehuh
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nicolasmatos/siteIteva/commit/280bcbeae3c4a5cc83ba816ab461ab8c19fccafc#commitcomment-14826034>
> .
>


Wrong error code...


I have moved the include upper because the PlayerUtils class get called while registering an user and the $GLOBAL['reslist'] would be empty.


`RLock` кажется излишним, почему не `Lock`? И почему вообще тут потребовался лок?


See PR https://github.com/mantisbt-plugins/EmailReporting/pull/18


I guess I just write too much JavaScript nowadays ;)


![player swf](https://cloud.githubusercontent.com/assets/5007900/11635710/5d370df4-9d53-11e5-9f4b-d183a8539b2b.png)


Estos thumbnails son parte de una colección que compré expresamente para pelisalacarta 4.0. El problema es que tengo licencia para usarlos, pero obviamente no para redistribuirlos y mucho menos con licencia GPL.

Seguirán estando en la distribución de pelisalacarta, pero por motivos de licencia no pueden estar en Github.


We're not watching for screen size change,
When the toast is opened we take the screen media query and save it for later use,
It does works with xs cause we're taking grater than sm.

Right now if the toast is set to top and re-sizing it will transform to bottom as expected but the dismiss direction will be up instead of down, IMHO this is nothing to worry about cause there's no physical screen that can transform its size so it's the last of our worries.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8356](https://teamcity.mesosphere.io/viewLog.html?buildId=87687&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:58


Works for me as well.


Fixed


Нельзя из типа `result` определить exception это или нет (проверять `Exception`/`BaseException`)?
Как я понимаю такой флаг нужен в случае, если Exception может являться валидным результатом или исключения какой-то библиотеки не наследуются от Exception, или тут другая логика?

Что насчет отдельного метода `set_exception`?


Ah, I see. I'm hitting cases where I take a reference fasta but have no need to recompute all the md tags. Updating this now to add a `--recompute-md-tags` option to the callers, so we can do that when necessary


'auto' ?


That's alright! Well done.


ugh, my bad. i'll fix this asap


Wow. This looks good as implemented but I have my reservations about this as a whole system design.


@camilorivera Commands should not actually DO anything. They should only carry information. I think you need another class that will take the command and do the actual work.


done


I think switching from the parallel 'map' to the serial `mapSeries` is only desirable for restarting. The change that's made here would slow down the `startall` case. Before, all Node instances would start in parallel. This change would make `startall` start the node instances one at a time.

See my related PR, which also produces `mapSeries` here, but only for the  restarting cases:

https://github.com/markstos/forever/commit/2040f90177c1963c4c0b702f6323efab077d53fc


탭메뉴 구조 변경


Oh that ***was*** the fix! I saw that and thought, okay this is legal, good. My bad!


Magic? :sparkles::crystal_ball::sparkles:


done. Added a warning paragraph about this in the group description instead of repeat on every function


Please don't raise issues here, we have no visibility into them. You can raise this issue on our issue tracker.


107310700-change-license-text (jasondegraw) - Win64-Windows-7-VisualStudio-12: OK (1977 of 1977 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


:+1: thanks!


Ah j'ai pas vu effectivement maintenant c'est comme ça ^^


Выглядит не очень из-за работы с приватным членом, хелперы в виде проверок на то, что хранится, кажутся лишними?


Interpolating isn't doing anything here.


TeamCity pull requests :: netty [Build 805](https://garage.netty.io/teamcity/viewLog.html?buildId=3863&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6222, ignored: 21 Build time: 00:40:47


Yeah, since the default behavior (use samtools for local files, otherwise hadoop bam) is what users are going to want in 99% of cases, I think just throwing an error if the user explicity requests samtools for an hdfs file is the most explicit / least error prone option. Updating that now.


J'ai copié coller sur google analytics ^^'


put a space above line 20 - so a space between 19 and 20.


same on all of these...space between the post create and expect block


Может дефолт значение должно быть `False`? Это просто выглядит логичнее, т.к. это булевский флаг.


the real magic :sparkles:


What's the difference between an author and supplier? Is supposed to be the person who submitted the quote from the person the quote originated from (just curious)


> It does works with xs cause we're taking grater than sm.
Sorry, I suppose a better way of phrasing is: should sm still be full-sized?

In the spec the sm breakpoint is listed at 600dp and the max-toast size outlined on the component page (tablet/desktop section) is 568dp.


There's a spurious '/'  before This.


Hahaha... I missed spelled the word ceil...


woo! :tada:


Heh, yeah, the Explorer service absolutely bypasses Ember Data. There are two main reasons for this.

One -- Ember Data doesn't support nested/composite keys easily. (There are numerous discussions and failed PRs on the net about this, sadly.) Ember Data (and JSON API), for better or for worse, assumes that a resource is accessible via a single ID. Most of Riak's resources, however, have composite keys -- for example, a bucket's key is `<clusterId>/<bucketTypeId>/<bucketName>`, essentially.

For example, the `findRecord` API only passes the model name and a single ID (not the model instance). And as far as I see it, there's only two ways around this:

1. Pass in the concatenated composite string as the ID (like `<clusterId>/<bucketTypeId>/<bucketName>`, and be sure to escape your delimiting characters within the actual ID fragments), and then parse that string into the component IDs to compose the Riak URL in the adapter.

2. Use `queryRecord` instead of `findRecord`, and pass in the parent IDs. (This is what we do in `self.store.query('bucket-type', {clusterId: clusterId})`, for example.)

Either way is sub-optimal and hack-y. Though still preferable to using the Explorer service, in the long run.

So that brings us to the second reason that we went with the Service approach -- simple time pressure :)

We went the 'ok let's make it work via manual AJAX first, and refactor it later'. Which brings us to today, heh.

Don't under-estimate the effort required to port all of the Explorer service to Ember Data, however (I speak this from a week's worth of beating my head against the wall trying to). It is definitely more than the work of an afternoon. So, given all that, here's what I think:

- Leave the assembling of the cluster children collections (nodes, bucket types, indexes) as a manual process, for the moment. (Which is what you're doing, currently).
- Create a custom Ember Data adapter and serializer for the Node model, so that we can at least load the nodes via a proper `store.findMany()` and `store.findRecord()` (since Nodes are the only other resource, aside from clusters, that can be retrieved via a single unique id (`GET /explore/nodes/$node`).
- We can convert SearchIndexes to use Ember Data when we implement https://github.com/basho-labs/riak-explorer-gui/issues/18 (which will require creating explicit models for them, which will be a good excuse to create a custom ED adapter, etc).
- We can then see if we can convert Bucket Types to proper use of ember data (by hacking findMany, etc), which will mean we can convert the whole Cluster model to the proper use of ED relationships.


There's the `warning` above that should alert devs to it. It seems weird to enforce something that's going to go away anyways.


Any reason for not including `jsc_memory` source files, which I imagine include `JSHandleMemoryPressure`?


The commit message references a test case, where is it?


@CodaFi The commit message references a test case, where is it?


И может этот флаг по дефолту должен быть `True`? Это все же `CachedGzipResponse`, кажется вполне нормальным ему отдавать сжатые данные.
Или дефолтный `False` по какой-то логике выставлен?


A palavra "Quando" está escrita errada.


@CodaFi In the future, please squash the tests into the patch that fixes the bug -- this makes code easier to review because everything is in one place.


Agreed. But with the currently published API, we will have to do this for now. Let's not get ahead of ourselves :smile:


I feel like this code is supporting a use case that shouldn't ever come up, though - it'd only be if someone were deliberately mixing the new syntax and the old syntax.


difficulty with understanding the assignment. i was not able to come back to the answers. I will move along but maybe we can discuss how we came to the above during our next call.


@ccourtney I assume that this would make sense almost anywhere booleans are used, maybe instead of making a named "nullable-boolean" we should apply this logic to all booleans?


This signature can be made a function? That way, it becomes easier to consume in other parts of the code.


hello


Named them in the next commit -they are the keys from parse db


I thought it would look a little bit weird on a top-level property, but now I think it could make sense. Will fix.


The changes to ExplosionParticle.cs need to be reverted. Currently the "get color from environment" feature has been removed and the other changes are unnecessary.


Both commits look great Kevin.


This won't work if someone passes `to={{ pathname: '/foo', query: { the: 'query' } }}` though.


bGetColorFromEnvironment should be restored and updated to work with your new changes.


This is coming from moment.js, so it'll be 0-59


Not necessarily relevant to this patch, but what do you think about moving all of these into the files where they're actually used. I think it's silly they're all in container.go, because I always have to open that file when I want to see what the members are.


SaveSettingsToStorage can likely also be removed since settings are directly reading and writing to the static properties now.


Which is why I don't think this is really an issue. They'll get yelled at for using the old syntax anyways. Adding an invariant will just (potentially) double up the alerts.


Is this intentional here, or just omission, aacording your TODO comment in the `MqttPahoClientFactory` ?


@ligadata-yasser

Hi Yasser, is this part of the HDFS "adapter"?  What is it going to be used for?  Does it monitor the File Consumer pieces?


duza zmiana


Useless cat


This probably also needs a check for the 'ip' binary, seems this will be loaded on *BSD, Solaris/illumos,... which do not have the 'ip' binary.


Setting the CswUrl was reordered so that the SecureCxfClientFactory can be built with new timeouts (if they are changed during the refresh).


zostawiam komentarz


Troubleshooting. UTF-8 Character enc. dec. '195 133' problem. Same for the other changes this date too.


tu tez zostawie


Fair enough - would you mind adding a comment to the effect that this is something we'll have to unwind once we get rid of the old props, then?


As the package is to be installed as “Sublime Command”, not as “SublimeExternalCommand”, the reference to `external_command.hidden-tmLanguage` in `external_command.py`, was wrong.


i tu
i tam


Improve naming. Current naming sounds like tlliExtFn is different from a normal tlli C function.

Suggestions:
+ tlliExtRAIIFn
+ tlliExtInitFn


should be in an enum instead


Oh, never mind, you're using `location.query` rather than `query`. I'm okay with this to get the build green.


#comment


same thing, enum


The data is then viewed in a list view<https://github.com/SeasonFour/Mpolice/blob/81b75f2cc8aeb79e686d41ad4a217b5dbdfc18bf/Mpolice/app/src/main/java/com/example/ibra/newproject/MainActivity.java> when the push notification is opened.


Makes sense :)


This bit shouldn't have been in this commit... oh well. It's the original file before I renamed it to `configinfo.ts`


I think you can make this and all the error cases cleaner by dropping the &


Nice point, thanks!

Ozan Kurt

> On 7 Dec 2015, at 19:24, bergi9 <notifications@github.com> wrote:
>
> I have moved the include upper because the PlayerUtils class get called while registering an user and the $GLOBAL['reslist'] would be empty.
>
> —
> Reply to this email directly or view it on GitHub.
>


Onde se lê "assert_not flash.FILL_IN", leia-se "assert_not flash.nil?"


I like the idea but I'm concerned about the consequences of doing this unconditionally, even if fish does not own the tty. Am I correct that this is only for interactive uses? If so, would it make sense to conditionalize this on the `is_interactive_session` variable? (This is set at startup and never changed once set.)


Ut8 is unsigned char

> On 07 Dec 2015, at 18:51, dmtch <notifications@github.com> wrote:
>
> No, 1000 is too much for ut8.
>
> —
> Reply to this email directly or view it on GitHub.
>


@wch, I did, I'm referring to it exactly, and it does not have this change.


/\*\*док\*/


This fix would close the issue #91


On Wed, Dec 2, 2015 at 10:48 PM, Heikki Linnakangas <
notifications@github.com> wrote:

>
> > Syscache receives invalidations several times during
> > parsing / optimizing / executing a query. Basically whenever we need
> > a lock on a catalog object we accept syscache invalidation messages.
>
> You have to, for correctness. If another backend has just modified the
> object, the information in the cache is outdated. By checking for
> invalidation messages after acquiring a lock, you ensure that if another
> backend had modified the object just before you acquired the lock (i.e.
> while you were waiting on the lock), you will see the invalidation message.
>
>
Thanks for pointing that out, you are exactly right. We had a discussion in
the Query Execution team and agreed that we need to enhance the feature to
check for changes every time we accept invalidation messages. Basically
we'll keep the existing mechanism of a shared memory counter (Global
Generation), but we'll check it in more places, rather than just at command
start. As you pointed out, this is required for correctness.

I'll update the PR with that change soon.


I decided to make this change in nginx-proxy v2.1 so it creates a new cert using the supplied domain rather than copying the container cert.  This makes sure the cert matches the requested domain rather than the container name.  It decouples nginx-proxy from the container, doesn't require the container to be started when creating the site proxy and greatly simplifies the code.  I kept the check that the container exists, but technically even that could be eliminated.


Did you mean `return true` here? Or can we just drop this?


yes, definitely.  I'll amend the test names when I get the chance


Why not add a "GetConnectorByID" method to the ConnectorConfigRepo?


Почему бы не использовать context manager?
К сожалению `with` не работает со `StringIO`, но можно использовать `contextlib.closing`:
```
with contextlib.closing(cStringIO.StringIO()) as buf:
    with gzip.GzipFile(fileobj=buf, mode='wb', compresslevel=1) as gz:
        gz.write(json.dumps(result))
    return buf.getvalue()
```


Bah. This is for `case "none"`.


Can you please try something like

typealias A = B
typealias B = A

Even if it already works, adding a new test is nice for completeness.


Почему ты решил не выносить `compresslevel` в параметры?


@schreiaj That sounds good to me.


the sensor reading is a parameter to this function, isn't it still better to check it first?


@jbmouret the default for OdomEnable is true. Only if the config file is specifying false it will change. The `hexa_control_odomless` is not called, unless you want to do a demo or something.


My general rule is, if you're going to submit another patch that touches this, go ahead and fix the formatting, otherwise I won't insist on it :-)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8360](https://teamcity.mesosphere.io/viewLog.html?buildId=87697&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:00:41


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8359](https://teamcity.mesosphere.io/viewLog.html?buildId=87696&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:05:16


for #18


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/95394728


Hi Anthony,

I've added the 'eventsource_aliasversion' branch on jenkinsci/aws-lambda-plugin on the same commit where you forked.

You can create a pull request for that branch.

I did some work regarding aliasing and versioning on the original xt-i fork, but I'll evaluate evaluate both and solve any conflicts.

Thanks,

Michael


Can you squash this commit with the one that did the initial fix?


Much love to linuxbrew and homebrew-science, but I'm also starting to favor conda for @galaxyproject. For the practical reasons @chapmanb mentions (simple bootstrap is huge), but also philosophically, conda seems to embrace explicate versioning more.

Unfortunately some recipes are linux only (e.g. bowtie, bowtie2):

  https://github.com/bioconda/bioconda-recipes/blob/master/recipes/bowtie2/meta.yaml

So we'd need to do some improving there. Doesn't look too bad though.

Is there a reason the travis buils have a whitelist of osx rather than a blacklist? Would be nice to build as many packages as possible for testing platform independence.


should be fixed now, thanks for catching that


all tests pass:
success: http://buildbot.bos1/builders/test-riak_kv/builds/2856


@jtbandes This is awesome, thanks!


Well, according to the `getAsyncClientInstance()` contract it won't work.
So, changing this to the interface is wrong.
Will fix during merge if that is only the concern.


Yes, generally speaking it would be better. However, all CPPML union types
have reference semantics, so all you'll really be saving there is an atomic
refcount (which can be substantial, but usually only in tight loops).

On Mon, Dec 7, 2015 at 1:00 PM, Alexandros Tzannes <notifications@github.com
> wrote:

> Here and in other places, we pass ImmutableTreeMap by value (instead of
> say by reference to const). I see the implementation of ImmutableTreeMap
> will only copy the root of the tree which has constant size and is
> therefore cheap, but it is still up to 6 members (and possibly a tag
> member; not sure how CPPML compiles down to C++). Wouldn't it be beneficial
> for performance to change these to references to const?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/ufora/ufora/commit/ce7146413059e2ddc48ca3b27800f1578510390d#commitcomment-14827556>
> .
>

--
-------------------------------------------------------------------------------------------
Braxton McKee                             CEO / Ufora
www.twitter.com/braxtonmckee       www.ufora.com


I think thise big endian PEs are for alpha arch.. Which is deprecated but already exists. Is any new PE using yhat deprecated bit for aomething else?

> On 07 Dec 2015, at 19:02, dmtch <notifications@github.com> wrote:
>
> I've checked all PE in tests, there are only one file with this flag: "imports_1210.exe". But it's also little-endian, look at virtual addresses stored in "DATA" section.
>
> https://msdn.microsoft.com/en-us/windows/hardware/gg463119.aspx
>
> IMAGE_FILE_BYTES_REVERSED_HI
> 0x8000
> Big endian: the MSB precedes the LSB in memory. This flag is deprecated and should be zero.
>
> —
> Reply to this email directly or view it on GitHub.
>


sounds reasonable :+1:


Clearly <3


Perfeito gostei desse jeito vc sabbe aonde eu consigo as fontes?


You can probably drop this :)


This was my first instinct, I'm finding it hard to think of anything else that isn't excessively verbose, obfuscated or inefficient. Call it conditioning. I could probably eliminate the `strip()` but that doesn't change anything, really. How would you do it?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8358](https://teamcity.mesosphere.io/viewLog.html?buildId=87693&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1, passed: 0, ignored: 199 Build time: 00:20:23
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 87](https://teamcity.labkey.org/viewLog.html?buildId=289990&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:02


Yeah, that sounds like a very good game plan. And yeah I was running into some of the same issues you mentioned when trying to implement it this weekend. Thanks for the detailed response!


If you can make those changes I'll merge this in and publish a new package. Open to suggestions on which version it should be, since we moved to a new Ember Data version I'd assume bumping the major version. At which point maybe we should peg it to the Ember Data major release version, opinions?


It actually works fine because `MqttAsyncClient` __implements__ `IMqttAsyncClient`.

As you can see in the next commit; though, I have changed the API in 4.3 to use the interface.


typo: `incredibly active forum` -> `incredible forum`?


:+1: LGTM


fast-forwarding master to auto = eed89649


:-1: This is awful


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 88](https://teamcity.labkey.org/viewLog.html?buildId=289992&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:01:55


I'm not entirely sure about the operator precedence here. But either you are dereferencing ppListNode and then taking the address of it which would cancel out, or (more likely) you are taking the address of "next" which is already a pointer. Which I'm assuming you do because you wanna dereference it in the loop condition. But why not write the code a bit more elegantly like:

``` c
tlliExtListNode* pListNode = g_extensions;
while(pListNode) pListNode = pListNode->next;
```
?

I guess I don't see the purpose of this extra indirection.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8362](https://teamcity.mesosphere.io/viewLog.html?buildId=87703&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:01


This broke my workflow. How am I supposed to keep my house warm this winter?


TeamCity libpalaso :: palaso-win32-master Continuous [Build 3.0.611.b3c00e07dbd181194b7b40c7495b9a5f7aca7678](http://build.palaso.org/viewLog.html?buildId=66957&buildTypeId=bt223) outcome was **FAILURE**
Summary: Compilation error: SIL.Windows.Forms.DblBundle\SIL.Windows.Forms.DblBundle.csproj (new) Build time: 00:01:58


this search could be optimized by using `first` as the lower bound.


???
`MqttConnectOptions`: `private boolean cleanSession = true;`

Am I missing anything?
The `DefaultMqttPahoClientFactory` has `cleanSession` as `null` by default, so we don't change the `MqttConnectOptions` default. Hence it retains as `true`.


The excessive use of ellipses indicates my concerns have not been accepted with the gravity with which they were meant.


looks mostly OK, but out of curiosity do you have numbers supporting this change?


@sigmavirus24 :deciduous_tree:


Shouldn't we have alt text for the icons?


TeamCity libpalaso :: palaso-precise64-master Continuous [Build 3.0.619.b3c00e07dbd181194b7b40c7495b9a5f7aca7678](http://build.palaso.org/viewLog.html?buildId=66958&buildTypeId=bt322) outcome was **FAILURE**
Summary: Exit code 1 Build time: 00:02:46


107310700-change-license-text (jasondegraw) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1441 of 1441 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.51%25-green.svg)


Ты уже находишься в ветке, где `namespaces` не пустой, поэтому `or namespaces_states` лишнее.


вот это всё ещё фигня: метод rating, возвращающий одно, и метод get_rating, возвращающий другое. я бы конечно это назвал rate_stars, но ты слово stars уже занял под актёров :) которые должны быть actors, конечно (одна из двух сложнейших вещей в программировании: Правильно Называть Сущности)


this should be nullable