As part of refining the test validators for https://github.com/TechEmpower/FrameworkBenchmarks/ we got into a discussion about whether it is appropriate to include charset in Content-Type for application/json responses. I had originally thought it appropriate to include charset, but then I found that the JSON RFCs say charset is not appropriate:
* http://www.ietf.org/rfc/rfc4627.txt "JSON text SHALL be encoded in Unicode.  The default encoding is UTF-8."
* http://www.ietf.org/rfc/rfc7159.txt "No "charset" parameter is defined for this registration. Adding one really has no effect on compliant recipients."
* http://www.iana.org/assignments/media-types/application/json
"Note:  No "charset" parameter is defined for this registration. Adding one really has no effect on compliant recipients."

Since I saw that Compojure added the charset in 2013, I am curious: Do you recall why the charset was added? Is there perhaps some real-world advantage that isn't covered by the RFCs?


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - i386-Windows-7-VisualStudio-12: OK (1983 of 1985 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.9%25-yellow.svg)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9526](https://teamcity.mesosphere.io/viewLog.html?buildId=93439&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:07:09


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9527](https://teamcity.mesosphere.io/viewLog.html?buildId=93457&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:03:12


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9524](https://teamcity.mesosphere.io/viewLog.html?buildId=93434&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:07:53


"check that all meta appear before non-meta because you seem to depend on this in methodHandle.bindTo"

I did. Here. Or did I misunderstand you?


@jmuhlich using the UI Dialog default for height ("auto") and allowing the iframe to set the height seems to work - was there a reason for trying to use "100%" iframe height and "600" for the UI Dialog height? See comment, this appears to cause double scrollbars for me in Chrome.


Original Android Client


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9523](https://teamcity.mesosphere.io/viewLog.html?buildId=93433&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:09:44


@nlottig94 @brookestewart I've revised these variables to work a little differently, with the benefit of David Birnbaum's advice today. They are generating a raw count of all the dashes in each poem. I've renamed them to:
*  $dashContainers (to hold the whole element whose text node contains dashes), and
* $dashCount (to subtract the string-length of those full text nodes from the string-length without any dashes). Dash count looks like it's giving us a correct count of the dashes now when I run this output.

This isn't enough to get you percentages, but maybe you can try taking it from here--and let me know if you have any questions!


I've been debating (with myself) whether we should return nil or the basic status. I think there are pros and cons and this code (filling in ID, name, etc) has to reside somewhere. I can be convinced either way though.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9525](https://teamcity.mesosphere.io/viewLog.html?buildId=93438&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:10:49


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9528](https://teamcity.mesosphere.io/viewLog.html?buildId=93458&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:58


wstring is a windows string?


If there are inspection errors, we need to propagate this upstream for the caller to handle. The cache itself has no idea how to deal with errors.


Hey @JulianEberius, this commit breaks this error message. Found via your own plugin :)

<img width="465" alt="2015-12-15 16 22 07" src="https://cloud.githubusercontent.com/assets/1570168/11828266/14747cc8-a348-11e5-9e33-1bc5eef72914.png">


It works for me. Make sure the .eslintrc file is in the same folder as the .js file you are linting or in a folder above it.

The extension looks for .eslintrc files at the same folder and all folders above it until the root of the drive. If it doesn't find any, it will use the one located in %userprofile%


This is not within an inner loop. It will basically be called once per call of bam2plx.


On the other hand, since you have a vector, you might as well use the `vector(size, val)` constructor:

    std::vector<uint8_t> buffer(block_sz, 255);

If that's slow, then `std::fill` is probably just as slow. `memset` can be faster (since it sets full-words at-a-time). But with `-O3` gcc should optimize all this inlined template code into `memset` anyway. So the vector ctor is simplest, safest, and probably as fast as anything.


Please check the repository, which has the fork - https://github.com/ashmachado/ExData_Plotting1

I had missed forking Roger's repository


Why did the default increase? Just curious.


@Thunderbottom
Implementations that hide the bar when you scroll is very difficult.
I believe it's possible in the Behavior of CoordinatorLayout.
If I can do it, it will merge.


Trying to find a long-term fix for https://github.com/BioroboticsLab/biotracker_core/issues/48


Tanya, teacher dashboard uses the strings in pegasus which are in the
gsheet. These are unused.

On Tue, Dec 15, 2015 at 3:49 PM, Tanya Parker <notifications@github.com>
wrote:

> @laurelfan <https://github.com/laurelfan> was removing these strings
> intentional? Are they no longer being used in the teacher dashboard? Or
> were they double included?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/code-dot-org/code-dot-org/commit/d82be354e9430f12b0d7296e582b75a2a3a829d7#commitcomment-15000520>
> .
>


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1137.3f08761c54c73fd109f13e11a4f10a0cd0899b24](http://build.palaso.org/viewLog.html?buildId=67336&buildTypeId=bt431) outcome was **UNKNOWN**
Summary: Canceled (Tests failed: 1, passed: 774, ignored: 6) Build time: 00:09:53
### Failed tests
```
GlyssenTests.dll: GlyssenTests.ProjectTests.UpdateProjectFromBundleData_BundleDoesNotContainLdmlFile_MaintainsOriginalQuoteSystem: <no details avaliable>

```


For the life of me I cannot get this to work even though my RPi server is confirmed to be live and functioning. I even had it working with rgraciano's code but you've got some great additional features! I just keep getting the "Sorry, I'm having trouble connecting to Sonos..." error both verbally and via Lambda. I'm a bit of a noob so pardon any ignorance!


I jettisoned this template match because `<xsl:analyze-string>` doesn't seem to work here as I thought it should. Oh well. I think i found a simpler way with the variable definitions above.


very nice touch!


Haha, thanks Koush!


why pass in values and values.updater_ami separately?


I suppose so, though implementing IEEE arithmetic correctly is a pain.


@maxrice looks great :beers:


Wait, found a bug when you right-click a folder and then click Run Web Analyzer. Fixing now


Thanks! :)


Where does this happen?  And shouldn't it stop rather than continuing?


That's wise! Let me fix this.


aqui; acho que deveria ser `<!-- more -->`


boa


These prototypes should be removed from the headers.  Since it's minor I'll make this  small change when I merge it.


Return type is `int`, but `i` has type `size_t`. I think Clang will want a cast, or maybe some compiler flags would require it.


Why change this?


Not really. The timestamp is global to the cache and it means that we only guarantee the content of this cache is newer than the timestamp.

PLEG does the following
 1. Get time.Now as timestamp
 2. GetPods
 3. Inspect pods that changed and call cache.Set() for each pod using timestamp in (1)
 4. cache.SetTimestamp()

There is only one time.Now() in each relisting.


develop (Myoldmopar) - x86_64-MacOS-10.9-clang: OK (1447 of 1447 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


I'm not really sure why it doesn't work. Something about OS X namespaces.  I don't know the low-level details...

The error messages are:

```shell
$ make install
...
/Users/yourname/Library/LaunchAgents/com.frobware.cmd-key-happy.plist: Operation not permitted
```

and if you try with `sudo`:

```shell
$ sudo make install
...
/Users/yourname/Library/LaunchAgents/com.frobware.cmd-key-happy.plist: Service cannot load in requested session
```

I wasn't sure if that was all too noisy for this file, although I guess we could say something generic like "the above command might fail with error messages like: \"Operation not permitted\" or \"Service cannot load in requested session\" when run under tmux".  What do you think?


To be clear, if the sink wants, its totally valid to buffer and delay the commit (and I imagine if you are writing parquet or something you might want to do this).  The only contract here is that in the case of the failure, the data that you retain and the watermarks that you report should be consistent.


oops


:clap: that's awesome


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (911 of 911 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.86%25-green.svg)


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1138.3f08761c54c73fd109f13e11a4f10a0cd0899b24](http://build.palaso.org/viewLog.html?buildId=67338&buildTypeId=bt431) outcome was **UNKNOWN**
Summary: Canceled (Tests failed: 1, passed: 651, ignored: 5) Build time: 00:08:29
### Failed tests
```
GlyssenTests.dll: GlyssenTests.ProjectTests.UpdateProjectFromBundleData_BundleDoesNotContainLdmlFile_MaintainsOriginalQuoteSystem: <no details avaliable>

```


Reported to Koush on August 9th, 2013.


This is actually not new in DevTools—it's a feature in React Redux. You can either use `store` prop or context, both work.


:metal:


clear screen


move cursor


OK,thanks


It was a bit of a judgment call.  For encryption (and eventually updating), we get the AMI from the service.  I didn't want to pollute the values object, since it represents what was specified on the command line.


This should be in scope, and is part of having test suite honour the current convention.


sure


:sparkles:


@smountjoy i cant find your comment, ill add a check, but now the exploit database comes with the chroot, so it is always installed.

https://github.com/offensive-security/kali-nethunter/blob/2b7a2291a47a07d5028337dcd979edd4d219de81/nethunter-fs/build.sh#L106

If you update the app for testing, remember to update the chroot also.

my best, Jaime


EconomizerIntegrationNew (lgu1234) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1443 of 1444 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.93%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.48%25-green.svg)


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1139.3f08761c54c73fd109f13e11a4f10a0cd0899b24](http://build.palaso.org/viewLog.html?buildId=67340&buildTypeId=bt431) outcome was **SUCCESS**
Summary: Tests passed: 775, ignored: 6 Build time: 00:07:29


is this a documentation to guide customer how to use XWalkView not java code?


@BrakesTilApex, can you hit the FQDN and port combination that you're specifying in your options.js file from the internet (not a device on your home network)?  You can try hitting the URI from your smart phone or some other device that isn't on your local network.
For example: http://mylocalserver.mydomain.com:5005/zones
You should get back a bunch of JSON


Cookie.php Должен инклудиться именно из CFSS


no it is disabled for now.... need to verify if it works with the new code


в этом вся фишка, хочешь - пиши своё ядро на основе архитектуры и идеологии Some.Thing


I'm seeing the same error `Warning:Failed propType:Invalid prop 'colors[0]' of type 'number' supplied to 'AndroidSwipeRefreshLayout', expected 'string'.Check the render method of 'PullToRefreshViewAndroid'.`

when using ` colors={['#ff0000', '#00ff00', '#0000ff']}` as demonstrated in http://facebook.github.io/react-native/docs/pulltorefreshviewandroid.html


@nazrulcse why needed? database.yml should be pg


свои функции. выруби просто CFSS


@jeffchampagne Sure can!


On 16/12/15 01:52, George Caragea wrote:
> Can we use a #define constant instead of -1? Numerical constants are
> hard to search for in the code. Thanks.

Yeah, that'd be good. Also, I just realized that we already use negative
"cache ids" in SharedInvalidationMessage to denote relcache and smgr
invalidations, so we can't use -1 for this.

I'm starting to feel that it's easier to just register to all the
individual caches that ORCA cares about. It would be nice to collect a
list of the relations that affect the metadata cache anyway. Then we
don't need any changes outside src/backend/gpopt.

- Heikki


Link?


Simple rule now uses a 50-day window instead of looking ahead at all the values. Simple rule in exactly the same fashion as the old script. To generate new values:
- pyspark ..../SimpleRule.py
- python convertToJson_2.py


that isn't on any of the Handle interfaces


Do we need to have a real URL here?  Does ImagePropertiesInfo actually start attempting to send an HttpRequest based on this?  If so, can we avoid the unnecessary network chatter?  Especially in disconnected scenarios, what will this code do?


Will your mkbootimg.mk work with zeroltetmo as well?


이 Fragment가 어느 액티비티로부터 시작되었는지를 나타내기위해 매겼던 태그입니다. 실제로 AccountDialogFragment가 MainActivity로부터 시작되었는지, ScheActivity에서 시작되었는지에 따라서 달라지는 로직이 있어서요.

아무래도 이 부분은 Bundle로 처리를 하고, 태그는 쓰지않거나, 의견주신대로 Fragment 이름을 작성하는게 나아보이네요.


Rationale is that usage of `loaded` and `isLoaded()` can cause confusion IMO. Should we handle this separately?


This version was published in Esolangs on December 14, 2015


not sure why time.Sleep is happening after restart call. should it be before?


위의 리뷰와 같은 내용이지요? 답변 역시 일치합니다~


Im not really sure im still working on getting ril/3g/lte working so idk
yet what works

On Tue, Dec 15, 2015 at 7:41 PM, bio4554 <notifications@github.com> wrote:

> Will your mkbootimg.mk work with zeroltetmo as well?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/SamsungGalaxyS6/android_device_samsung_zerofltespr/commit/24a526ea30bd040b99dcea92b44d57a5e4efd3d5#commitcomment-15001950>
> .
>


"can depend on" doesn't mean anything. Should be something like:

Given a library in a Maven repo:

1. Only the API artefacts of the library are visible at compile time.
2. The runtime artefacts of the library are visible at test execution time.

The API artefacts of a library in a Maven repository are:

1. The jar of the library
2. The API artefacts of all libraries declared in 'compile' scope in the library's POM

The runtime artefacts of a library in a Maven repo are:

1. The jar of the library.
2. The runtime artefacts of all libraries declared in 'runtime' scope in the library's POM.

We'll also need something equivalent for a library in an Ivy repository.


should revert commit https://github.com/wongsyrone/libsscrypto/commit/613ebdb62520ebc1418820343b66b2159ebb01ca


    "app.subnodes[{"+str(self.parent.num)+"}].subnodes[{"+str(self.num)+"}]

should be replace with

    self.nodestring

everywhere.  This allows us to build the waveguide as a subnode of a Device without any extra code, for example.


급하게 짜다보니 Getter / Setter로 참조하는 것을 놓친것같군요 ㅎㅎ;;

반영하도록 하겠습니다.


좋은 지적입니다


Prefer omitting "static" here.  In practice, Params() will always be the same in every call to this function, but it would be a pain to find if it were ever not true (maxVout will be set on first call to this function, and never again).


This was an unintentional change, right?


I do not see any memory allocation in this link, the test added in this commit will only check if you're using malloc in your function (which is a pretty bad idea), it seems you're confounding memory allocation and static buffers.
Moreover the c99 implementation of memmove is not protected and will segfault if you send too many datas, the only valid implementation on this page is the C standard implementation.


follow up patch did the work.


../game? :)


Bug report for this?  It doesn't seem to have been fixed in ioq3 yet.  Should probably PR upstream unless it's somehow jka specific.


정확히 `orderSessionChronologically`가 되겠군요.

주신 제안에 큰 문제 없으니 반영할게요~


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1449 of 1449 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


BTW @robyurkowski


This isn't technically a reducer as it doesn't take into account action types.  Your top level switch in index.js could just be a call to combineReducers.


I've made a separate PR for this: https://github.com/mapbox/mapbox-gl-native/pull/3318.


Good point.


I'm not sure I understand the question. Compojure added the charset to HTML responses, but you're asking about JSON responses. I don't see how adding a charset to a HTML response is related to whether a charset should be added to a JSON response.


TeamCity pull requests :: netty [Build 881](https://garage.netty.io/teamcity/viewLog.html?buildId=4106&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6253, ignored: 21 Build time: 00:43:26


Very nice. I am glad that Unirest's send method is working on our endponit. It kept failing on mockbin, though that was likely an id10t error.


HI there,

I believe the check added into pe_version.rb is incorrect, as the puppetversion fact does not contain the string 'Puppet Enterprise x.y.x' but 'x.y.z' instead.

I'm having problems in PE 2015.3 and this check results in is_pe=false, and the 3 other facts in this class not being set correctly.

Cheers,
Josie


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


@nairdo I can see how it could potentially be slow.  I'll fix it up by either changing the Include or refactoring a little to do the database qry's as needed and more specific, etc


- running `gradle assemble` does not build or run the test suite.


good catch, that would have broken a lot of subtle stuff in skill checks and such


should be in `testSuites { }` rather than `components { }`?


@adjohnson916
Thank you so much for your help.
I have updated my chrome to latest Version 46.0.2490.86 m.
Now its working for me after adding options ;cssMode: as like below,
Coming to example:

				$('.outer-drag-thumb').html('');
				$('.outer-drag-zoom').html('');
				var $host;
				$host = $('[mag-thumb="outer-drag"]');
				$host.mag({
					mode: 'outer',
					position: 'drag',
					theme: 'default',
					toggle: false,
					smooth: true,
					renderIntervalTime: 20,
					cssMode: 'position',
				});
			});

Still one issue remained for me,

after dragging  / scrolling(to zoom the picture) and if i click on the zoomed image,
that's it now again i can't drag the image in [mag-thumb],
So i have to reload it again.

For a quick reference please have a test on [outer-drag] sample   at
https://andrz.me/magnificent.js/examples/demo/


My non-master branch is stockfishdeveloper/Stockfish/ and the "tune" branch.


Faltou juntar o "se quer".


I had the wrong bench and the test cancelled. It is fixed now. Thanks @Rocky640!


Hm. True. But I didn't want to change the entire sentence, making it look out of place.
How about this instead?
Sometimes you may want to know which optimization inserts, removes or moves ..


@yujuhong I found that we still do docker list each `GetPodStatus()`. I thought we could do list once and generate all the pod status.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9529](https://teamcity.mesosphere.io/viewLog.html?buildId=93481&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:13


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9530](https://teamcity.mesosphere.io/viewLog.html?buildId=93482&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:28


Can we pass the running pod in, and just do inspect in `GetPodStatus()`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9531](https://teamcity.mesosphere.io/viewLog.html?buildId=93483&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **UNKNOWN**
Summary: Canceled Build time: 00:15:52


Your are not testing against latest master.


I changed the threat weights to near 256, but could @Rocky640  or @VoyagerOne tell me why they must be near that number?
Thanks
David(stockfishdeveloper)


#4994-ControllerWaterCoil-TemperatureAndHumidityRatio-control-active-when-it-shouldn't-be (rraustad) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


How do I test against letest master?


I'm intrigued - I don't remember my feedback :).  Perhaps another Harsh?  Or else it was a long time ago because I *did* intern at Cray in 1987 - 3rd shift systems test for that summer in Chippewa Falls.  But back then we programmed with a Z80 microassembler creating tight loops to write specific bit patterns into the vector memory on the XMP to stress the hardware before delivery to a customer.  But I haven't seen one since and actually kinda wondered what ever happened with the company anyway.


cniNetworkPlugin.ReloadConf() references it.


Fixed


not a huge deal, but if it is easy to fix, please do


fixed, thanks


I'm trying to basically copy your commits for G925T. Sorry, it just looks like you're ahead of everyone else in this area :smile: I'm guessing it has to do with the ramdisk as well?


I had originally considered `current`/`write_current`, but I'm not wild for that.

> It is a bit strange that a reference returned from `read`/`get` can be used to modify the referent, which I think was clear for `current` [...]

That's true, but `current`/`write` is just as odd.


Simple and to the point. :+1:


Sorry. I missed this line.


I meant ring-json instead of Compojure, sorry.

I mean this particular change in src/ring/middleware/json.clj:
```
-            (content-type "application/json")`
+            (content-type "application/json; charset=utf-8")
```

It looks to me like originally ring-json did not specify the charset for application/json, which fits with my reading of the RFCs. Then in this this commit you added the charset for application/json, and I was wondering why. If there is a situation where specifying the charset for application/json helps some client, I'd like to know.

I don't think this is relevant to HTML responses, but maybe I'm just confused about what I'm looking at?


wow, I missed that too. thanks!


I think you do not know what you are doing at all.

Where did you get your new tuned values ?
Why do you want to reintroduce the threat weight ?
What are you trying to test exactly here ?
Have you read something about git ?


arduino 1.6.6 compatible


Can this be formatted in a way that uncrustify stays happy but the wrapped line doesn't appear on the same level?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9533](https://teamcity.mesosphere.io/viewLog.html?buildId=93497&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:37


good cleanup


Where did this number come from?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9532](https://teamcity.mesosphere.io/viewLog.html?buildId=93488&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:26


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9534](https://teamcity.mesosphere.io/viewLog.html?buildId=93499&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:04:12


Agreed, this doesn't look great, I'll try something.


"Common" prefix shouldn't be used in public API. Wouldn't ```TypeNameFormatter``` do?


Offline discussion with @yujuhong, we won't do this now. If this becomes some kind of bottleneck in the future, maybe we'll consider it.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9535](https://teamcity.mesosphere.io/viewLog.html?buildId=93500&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:06:18


I have tested the new values with LittleBlitzer with several thousand games, I know a few thousand is not much, but it might be worth the try. I know about git, and it would seem that I am testing against the master branch; I filled in the base branch field in the test with "master". Should I do "official-stockfish/master" or something similar? I hate to be a burden to this project, but if I may say so it seems to be relatively complicated to make a test. I think I could make a few good patches if I can get going. "Give a man a fish and he can eat for a year, teach a man how to fish, and he can eat for a lifetime". I just need a little help up to my first successful test and then I can begin to actually benefit this project.
Thanks for your patience,
stockfishdeveloper


Couldn't this be just enum? It's used only as a parameter to FormatTypeName, correct?
Also I'd avoid nested types in public APIs. What about ```TypeNameFormatOptions```?


r=jedmccaleb


Oops, thanks. I read the patches in the wrong order.


Should be a property (public API guidelines).


@yujuhong I mean you don't have to use a pointer.
```go
c.lock.RLock()
defer c.lock.RUnlock()
return c.timestamp.After(timestamp)
```
have the same effect.


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/8b08a309a80e997fdb6832acddd022c7446f836a


merging MonsieurNicolas/stellar-core/maintenanceStartup = 8b08a309 into auto


MonsieurNicolas/stellar-core/maintenanceStartup = 8b08a309 merged ok, testing candidate = 666004e0


lol find and replace


Seems like it might be a good idea to try and separate the game logic from the animation a bit more.


@timheuer I was unable to set the URI to an empty string since it would then generate another `UriFormatException`. I think we could completely scrap away the `else` block but I wasn't sure about it so I left it there and added a generic URL.

I've been testing it out and for some reason I couldn't get my OLW instance to lose all it's settings. I guess removing it would be the way to go. Could someone try building it after commenting out the `else` block and see what happens?


Why do we define our own StackFrame?


Yes, I suppose white list is a good option.


uh


I've changed this so that `std::_Binder...` is on a separate line, `uncrustify` doesn't complain on my machine.


If it is so, test shouldn't pass.


whoops


nah I think we should keep it


shouldn't you check the active flags, it can contains ERR/HUP/NAL

also, `read` can return `EAGAIN` or `EINTR` and you can treat it, instead of close the file descriptor and delete the watch, last but no least, you should considerer that read can read less than `sizeof(buf)`


dude


Yeah, it’s weird, but this test really passes and `groupEventsByDays()` definitely behaves as I’ve described above; It uses [R.groupBy](http://ramdajs.com/0.18.0/docs/#groupBy).


Hi Paul,

Sorry for the late reply!

My name is Bogdan and I implemented the Arduino101 specific part of OneWire library.

It has been a while but I remember I had the same thought/question/goal: to use only macros.
It proved to be not very feasible because changing the sate of a Quark managed GPIO (just writing to a specific address) is completely different story than modifing an ARC GPIO (use an ARC specific assembly instruction).

Do you want me to create a pull-request for the 101 specific changes?


I think rewriter is more general than we need. A "filter" should be sufficient. We wouldn't need to define a new StackTrace struct then.


welcome to the world of coding. :)


> Unless the type is known to be a GtkWidget subclass, those are always transfer none (because GtkWidget is derived from GInitiallyUnowned).

There's a ["transfer floating" annotation](https://git.gnome.org/browse/gtk-doc/tree/gtkdoc-mkdb.in#n189) alias for those, if it matters.


lgtm


Your new values might be fine, but since then the master values have been improved a lot.
You must test your new values against the latest master.

1) Please delete your test.
2) create a fork from "official-stockfish/master" (this is your master)
3) create a branch. Name it as you want. Make your changes.
4) https://github.com/glinscott/fishtest/wiki/Creating-my-first-test


@maelee DWMR. Nice work here. Keep it up!!


Couldn't this class implement the behavior of CommonStackTraceRewriter and thus reduce he number of public classes?


an overflow can happen here if `n == sizeof(timezone_str)`, you should give `sizeof(timezone_str) - 1` for `readlink()`


To be honest I'm not sure what's the best way to handle the exception in this case.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9536](https://teamcity.mesosphere.io/viewLog.html?buildId=93505&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:12


That totally works ! This is great, thanks !
I'm not sure why, but the spine is now upside down now though ?
![untitled](https://cloud.githubusercontent.com/assets/16247219/11829386/1d5d27d0-a394-11e5-888c-37900956ed7b.png)


I HAVE MY OWN FORK. I am just curious, what did you think I was testing from? Fine, I'll delete the test.
Thanks,
David


I have battery drain in Doze after 14 december in my ROM. And I'm suspecting this commit)


Agreed - I thought about this, but it felt weird to do only slightly different behavior in another method. Happy to implement this approach.


adding background color and font color


So this is interesting... I know we said we'll use an enum, but now that I'm thinking about it more an int would be better. First, it's easier to use -- no need to add an import of Microsoft.CodeAnalysis.Scripting.Hosting. Second, this is quite general concept and I don't think we should be defining our own enum for that.


And as far as the `HttpRequest` is concerned, it does send it out to grab the image but not from that URI. I don't know what the URI is there for. The `HttpRequest` is being sent to the `src` attribute in the `imgHtmlElement` and is getting sent anyway since I can see a preview of the image at the URL right away. The `imgHtmlElement` contains the inner html to render the inserted image.


Ah, okay, your post makes more sense now. The charset for JSON is because while JSON mandates unicode, there are several ways of encoding unicode. For example, the charset could be UTF8 or UTF16. Even though UTF8 is the default, there's no reason not to explicitly set the charset as that as well.


sweet :+1:


@teckjon DWMR. Ship that code! :truck: :trophy:


@teckjon DWMR. Checkpoint and assignment done. Well done. Press ahead.


why use signed here ? negative value has meaning ?


@yujuhong My suggestion is if there's an error, we clear the cache.
And upstream then does GetPodStatus() again.


If the user visits the socialArray twice, it will still show the loading since the videoArray is empty. Is this expected?


This commit is detached from master?


why not use time_t ? isn't it widely available ?


I think we're gonna have a problem with enums here. In REPL the host would need to add import on "Microsoft.CodeAnalysis.Scripting.Hosting" for the user to see the enums. But then they'd see all sorts of other stuff that's not supposed to leak. Hmm.

Perhaps the host should add import alias? "MemberDisplayFormat = Microsoft.CodeAnalysis.Scripting.Hosting.MemberDisplayFormat".


>   I was wondering about that. If you use the templates as written I don’t
>   think anything ends up outside a frame. So there’s nothing to ignore.

If you have a slide show like this:

```
# Main section

Introduction

## Slide one

content

## Slide two

content
```

then the "Introduction" part does not currently get inside a
frame. (See the discussion of "slide level" in the User's
Guide.)


Why illuminate/database@5.0? It's not the latest (https://packagist.org/packages/illuminate/database) and is preventing me from updating to the latest dev release on my Laravel 5.1 installation.


Okay, so adding the charset to application/json is a case of being extra-conscientious and not in response to some particular problem that cropped up when charset was omitted? Just wanted to make sure I wasn't missing something. An unrelated web framework is considering omitting charset for application/json, and I just wanted to make sure we weren't walking into a trap. :)


![GitHub Gif] (http://images.comunidades.net/alp/alphavendas/Setas.gif)


@dallas-matthews DWMR (Done with my review). This is jsut right. Nice. Ship code. :articulated_lorry: :+1:


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (911 of 911 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.86%25-green.svg)


Fix-allocation-for-feneSolarDelaySeq (JasonGlazer) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1449 of 1449 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.53%25-green.svg)


gg


TODO:
1. JSON
2. Add publicmenuitems.html
3. Flash
4. Code style fix
5. Users' Photos


some tests failed:
failure: https://travis-ci.org/stellar/stellar-core/builds/97123734


@stockfishdeveloper The point @Rocky640 is hinting at is that most of the 3,700+ commits to Stockfish are from pull requests branched from the most recent `official-stockfish/master` commit; so `official-stockfish` can't accept your changes unless your `master` is in sync with `official-stockfish/master` and *then* you branch, committing your changes.  Consequently if they aren't in sync there isn't much motivation for FishTest to run your tests, since `official-stockfish` can't pull/merge your changes even supposing a successful test.


Here is where we watched, as a team, how to translate a basic text such as "Hello World" in the computer language which is python.


Great dan, I was just going to try that
Thanks


Hello html


![screen shot 2015-12-15 at 5 43 05 pm](https://cloud.githubusercontent.com/assets/2508142/11829698/5606b862-a353-11e5-8d69-9cbec0410405.png)
![screen shot 2015-12-15 at 5 42 54 pm](https://cloud.githubusercontent.com/assets/2508142/11829701/5a7e7df8-a353-11e5-8bcb-47328632881f.png)


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9537](https://teamcity.mesosphere.io/viewLog.html?buildId=93514&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:56


Yeah all my pent up "having used php5.3 for years" caught up with me. :D


Hello HTML

![python-idle-hello-world](https://cloud.githubusercontent.com/assets/14898767/11829757/cbae980a-a353-11e5-80db-fc36a710912e.png)


might want to kill the aicp.dependencies too


what is this part?


rename this function to print_text


109626134-VariousDocumentationIssues (mjwitte) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Fuck

On Tue, Dec 15, 2015 at 5:47 PM -0800, "Rob Thompson" <notifications@github.com> wrote:

might want to kill the aicp.dependencies too

—
Reply to this email directly or view it on GitHub.


109626134-VariousDocumentationIssues (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Мир прекрасен!!!!! Живите  в МИРЕ!!!!!


@yujuhong why can't we have a global timestamp for the whole cache? If N*GetPodStatus() is going to take much time, then the global timestamp can't really represent the freshness of the cache. How bad is we have individual timestamp for each cached item?


@BrakesTilApex Nope, you don't need http://, just the FQDN.  The socket hang up message is being generated because the socket is closing before receiving the end message. This is most likely because we're timing out the connection too fast. I set the timeout to 1.5 sec and Lambda will timeout after 3 seconds and throw a fatal error.  I might need to add some better handling for timeouts.

If you want to send me your FQDN via email (I'll set my email to public), I can check it out a bit more. I promise not to play all of your zones :-)


[surgery-2015-12-13.zip](https://github.com/pswat/learning/files/63451/surgery-2015-12-13.zip)
[psychiatry-2015-12-13.zip](https://github.com/pswat/learning/files/63452/psychiatry-2015-12-13.zip)


#4994-ControllerWaterCoil-TemperatureAndHumidityRatio-control-active-when-it-shouldn't-be (rraustad) - i386-Windows-7-VisualStudio-12: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ah, I thought I caught these, sorry!

Thanks!


LGTM


既存からですが、

LOG = logging.getLogger(__name__)

でも良いかも知れません。


fixes


Why not use the bantObject.createdAt directly?


Thanks @ProDrone done in https://github.com/skaman82/cleanflight-configurator/commit/63dde67097066c8a392799665cc2dcaf1dd1c802


Tous va bien avec image. J'ai réussit le update aussi.Il va update le listView automatic dans le activity BookList et FilterList.
Mais c'est pas très jolie quand on voir un livre dans BookDisplay, parce que il y a des chevauchement.


I feel returning non-nil PodStatus really makes this kind of interface unclean.


Isn't this literally the *exact* same thing as the `set` code, save the type/method names? What about something like (on a phone, so there may be issues!):

```python
infer_meths = {
    'builtins.list': ('extend, 'typing.List'),
    'builtins.set': ('update', 'typing.Set')
}

# Original if here!
# ...
elif typename in infer_meths and infer_meths[typename][0] == methodname and e.arg_kinds == [ARG_POS]:
    # Up to arg_typename check.
    # ...
        if arg_typename in (typename, infer_meths[typename][1]):
            # ...
```


_onKeepAliveExpiredFactory() returns a bound function. It isn't necessary to rebind it here.


この関数ですが、実は1行で書けますね...

int(str(src), 0)

この書き方をすると、２進数、８進数でもいけました。


I was looking for that. Good find.


Profit!


No, this deletes the SHA folder for this file, not the folder dataobject.
This is because the SHA is considered a component of the file, not the parent folder, which has no sha. :)


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.973](http://teamcity.monogame.net/viewLog.html?buildId=12437&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


It's still true. :)


Looks good; I have a couple other things I'd like to clean up (commented out things, Visual Studio files) before we merge. I'll be quick.


rename this function to print_text


It is compatible now with at least Wordpress 4.3.1


既存からですが、この

str(dp.id)

ってすごく冗長な処理ですね。


Do we need the additional tags?


The MomentumRule.py implements a momentum trading strategy. ConvertToJson_3.py created json/profits_2/ which contains the json files for this strategy, in exactly the same format as the first.

Also, this strategy seems to make a huge amount of money!


Ok, I'll add them back in for the .protected folder.


This is incorrect, the spec states `the ClientOptions#clientId takes precedence`, yet your test asserts that the `overridenClientId` from `defaultTokenParams` is used


how come you commented out the tracing?


start 还是保留吧，antd 的文档里是 start 。


Why define this if it's not used in the options below?


Any reason to swallow this?


备注


Same comment about swallow


哦不是，搞错。是 `npm run dev`。


Not a good idea to use inline style. Try to do it in other way


TeamCity Civic Assembly :: Build backend + frontend [Build 110](http://54.229.176.143/tc/viewLog.html?buildId=244&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:04:35


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9571](https://teamcity.mesosphere.io/viewLog.html?buildId=93699&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


I can't find %CSP.WebSocket:Page (in 15.1 and 15.2) method or Blocks.WebSocket:Page method.


Use empty instead of size.


I think we dont need to give special styles to default biitstrap styles.


@steveeJ How is configured `/etc/ld.so.conf` and `/etc/ld.so.conf.d/` on NixOS?


Because logging isn't fully integrated yet.

Please, use developer forum for feedback


why removal of annotation ?


can we use srclineno = lineno; instead here?


this commit broke my sites =(


Done


line[0] == '#'


it is temporary


> I missed blacklisting the StringTest (we also test deprecated features) when run under PHP 7

I can't actually find any tests called StringTest.

It appears to have been renamed to TextTest and not simply duplicated. Can you point me in the correct direction for this test?


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#eBFOj4BpRC27ngFgeJ7bNw


@stieglma Awesome, thanks!


And does constantly. Will fix.


@benzonico it should be private, it is not accessed, will set it private at the end of review.


It's not used/configured by default.


rename this "arg" to something else. For instance "dumpfile".


Ok for "const". For undescores, I would prefer to keep them to help the reader clearly see what is the class member and what is the constructor argument.


Sure, np.

For reproduction: nothing extraordinary, I took the HTML code from your page (https://dl.dropboxusercontent.com/u/3224458/example/test.html) but (as I'm working on symfony 2.7.7) used assetic with leafo/scssphp parser to get foundation-sites.scss file (instead of the compiled foundation.css).

So again, maybe just a parser issue. If nobody else raises the issue, I'll investigate it further on my own. For the time being I can live with extra media-query code...


Fetch for @ManyToOne is EAGER by default.


EconomizerIntegrationNew (mjwitte) - Win64-Windows-7-VisualStudio-12: OK (1943 of 1980 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-98.13%25-yellow.svg)


не коммить в репозиторий пароль и имя пользователя


@christianrober fyi


thanks for your share ，bug could you give me a all the step code ？i want to implemente this effect when my net was lose i send a message （this time this message must be failed）。then the net was recovery，and that fail message would be auto resend。how to implementate it？


Hopefully fixed in https://github.com/NixOS/nixpkgs/commit/0944d05e2e7ea4754cff9658afdc186208ae4004


@JJ do you think we can remove now "blue" in line 787 since the figures are in grayscale now?


I believe you could also write sorted(dumpfiles) then you don't need to sort the dumpfiles before the loop.


> but I don't know why we need lkl_` prefixed type/struct name (e.g., __lkl_u8). can we just use the original one ?

> if we don't need to have type translation, we can consider to have a manual header file instead of auto-generated one. it solves all the issue raised above.

We need to prefix the types to avoid conflicts with the ones from /usr/include on Linux systems or other Unix systems since we can mix LKL headers with system headers.

We can't use the system headers directly because they might not be available (e.g. win32 or some unix variants) or have different definitions (e.g. unix variants or even particular Linux architectures: see ioctl.h, fnctl.h, poll.h, stat.h).

Also, there are lots of types and data structures we need to provide for non Linux systems (e.g. Win32 or FreeBSD) so I don't think manual header files is an option.


nope.


Comment rewritten to indicate the risk that a C/C++ preprocessor directive might contain characters such as double quotes, "<", or ">", which could make the XML dump invalid.


Soory for being harsh, but IMHO this `strip` option is crap for several reasons:
- Why is it necessary at all?
  - value `-1` is unchanged filename, which is what we have now and which is useless and irritating - which is why we wanted to get rid of it
 - What is the use-case for value `2`?
 - value `1` is missing, which is irritating

We shoould decide on *one* option and implement only this. Or has there been reasonable demand for other options? (I did not have time to follow the whole discussion.)


чтобы замапиться на актеров лучше использовать мапинг на коллекцию, иначе это адцкий хардкод
https://docs.jboss.org/hibernate/orm/3.6/reference/en-US/html/collections.html


s/if/elif/ ?


This comment does not fir anymore, expansion is done above.


I forgot to make a pull request, and made a direct push instead. This push includes the selection of correct OMTF candidates. The candidates wth wrong hit patterns have quality=0, so for making any plots please select candidates with quality>0.


EconomizerIntegrationNew (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (906 of 906 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.8%25-green.svg)


Same as on camel, can you revert


Because this versions unsupported. Version must be 2015.3/2016.1 or later.


plz add TL;DR at the top of your commit messages too :wink:


Instead of having this commit in all the PRs, you could have committed it directly on master, since you have commit rights.

Even so, this should not create problems, since the merge does not seem affected and the PR can be applied.


Danke für den Hinweis, damit bekomme ich den Rest hin.
Das
"ITClock"  => '200,300,400'
ergibt dann aber ein Auswahlfeld, wäre da ein Eingabefeld nicht besser?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9572](https://teamcity.mesosphere.io/viewLog.html?buildId=93701&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 206 Build time: 00:03:48


strip_paths *must* also go into `GUTS`.


Works but still need to make tests pass.


剽窃チェックの実行が完了してない場合、「学生同士の類似度」のところは「実行中」と表示する


Никогда не оборачивай в
e.printStackTrace();

либо логируй ошибку, либо накрайняк оборачивай в RuntimeException


ApplicationName isn't required, so "True" should probably be changed to "False".


Maybe https://android-review.googlesource.com/#/c/187614/


Will this be available in new package in Pypi soon ?


I don't think this comment help much. can be removed.


:ok:


why does `if not csrf_token` defeat the purpose of everything?


For PC, that value the distance between 2 ticks.


Oops.  I've updated the body of the commit with the info about GSS codes too.  Thanks!


I forgot to mention in the previous review, but this block of code needs a comment explaining what is going on and why was this needed.


XEP-0198 is already in XMPPFramework upstream with detailed instructions

2015-12-16 13:11 GMT+03:00 abei <notifications@github.com>:

> thanks for your share ，bug could you give me a all the step code ？i want
> to implemente this effect when my net was lose i send a message （this time
> this message must be failed）。then the net was recovery，and that fail
> message would be auto resend。how to implementate it？
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/vitalyster/XMPPFramework/commit/afe250873863a8e7a77729501f6ccfbfa808b3d9#commitcomment-15009563>
> .
>


Done


I have to do that until @thibauts gives some guidelines on how to fix the issue properly. Probably propagating close to the top-level client


Accidental paste?


一般用 web gui 来干啥?


Can't we have just this commit in master to fix the bug? Or does this commit also depends of the changes on the Tags?


Please run perf tests on those two versions


если сортировка не важна, то лучше использовать абстракцию повыше - Collection


web gui 依赖了太多东西，让这个包变地比较重。


検出した学生を特定できるため、コード表示のところに授業名、問題の開始時間と終了時間を追加した。


Has this proven valuable to you? Thinking of merging this commit...

Also, why 'var.rxdShellPrompt'? Are you modifying the 'var' object?
Why not 'var rxdShellPrompt'?


TeamCity pull requests :: netty [Build 891](https://garage.netty.io/teamcity/viewLog.html?buildId=4116&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6229, ignored: 21 Build time: 01:21:13


This commit throws me back to the good old pmix days where this workaround was already here :D


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1450 of 1450 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


@olleolleolle :+1:


Since remote server does physic simulation, we only have to translate it. And let's create EntityCache.newPlayer().


@jeffminnear Looks good though lets discuss anything here that would be helpful to go over in the call today/tomorrow.


@BettinaMigot Ca m'a tout l'air d'être un problème de depth, si ici on met `box.d *= z*1.5;` par exemple les collisions sont déjà plus réalistes.
La profondeur doit pas être impactée pareil quand on fait un scale, faudrait trouver la formule magique :confused:


Nvm, this is appropriately already handled in the modules.


Может использовать здесь сразу `add_dependencies`? Сейчас ты собираешь список `test_list`, а потом его добавляешь в зависимости к таргету `run_tests`, кажется этот промежуточный шаг лишний.


@razor84 mate please check syntax before pushing commits
There was some more build erros
this is the 2nd or 3rd time we have had errors because of faulty syntax in your translation

luckily another member fixed it here https://github.com/ResurrectionRemix/Resurrection_packages_apps_Settings/commit/dcff3bedea7f1f539de1d3b8e7544608e07f869f


I think there's an overlay for the hw key switch ,at least there was on LP with cristiano's commit, idk how it is here


Nope, thought initially it was going to go there, will remove it


We can do a new package soon. When do you need one?

2015-12-16 11:20 GMT+01:00 Saad Zaher <notifications@github.com>:

> Will this be available in new package in Pypi soon ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/kontron/python-ipmi/commit/4413c7313067ca84d586a0528b65d5302f587aef#commitcomment-15009746>
> .
>


@akhilnarang it wont work here becaus of CM HW api


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Closes #660


There's no surname variable. The name already contains full name, what are you trying to do?


Autocorrect changed changelog to changeling, of course it should be changelog.


Done


Anyway, i would use both together lol :P


Looks interesting
thanks will check it out thanks


The only reason it's an option at all is because I thought "There could be several entries in sys.path+pathex where a file could be included from, and it might be useful to have a little info about which sys.path entry provided the file.". But you're right, having an option does add complexity, and it would be much simpler to just strip the entire sys.path entry off of the filename.

If you don't think it would be useful, I'll remove the option.


It seems that you have serious problems with encoding...


> Okay, the default change didn't make it into this patch, sorry.

I wonder if we can fix this by making the defaults
different for int and uart modes. If we have 5 for uart
and 2 for int, I guess all games will still work?

> Just actually applying the already existing config setting is good enough

What do you mean?


wtf why oeaxtx? this register doesnt exist


two spaces after in


I added it to simplify test cases by avoiding castings. But if it breaks compatibility I can revert it tonight.


wtf


I'm a fan of KISS, so I would vote YAGNI :+1:


typo? should it be data.configurations?


This breaks building on OSX.


totally messed up indentation


Please don't indent comments


just passing ... I think this api is oudated and should be replaced by `this.get_selected_cells()'. I may be wrong


Вместо
```php
@for ($i = 0; $i < $size; $i++)
     ... $m[$i]
```
лучше писать
```php
@foreach ($m as $message)
     ... $message
```
Короче, яснее и не надо передавать _$size_.


This is by purpose. This acts as a low pass filter for the spi clk signal from the arm controller to the fpga. The compiler doesn't like this kind of combinatorial loop. But in this case it's by purpose.


same here `.get_selected_cells()`


You need to include "base.moc" when you use Q_OBJECT in an implementation file (instead of a header). This tells qmake and moc to create a qobject definition.

However, #419 removes this need but you also said that doesn't build so maybe it's something else?


It's yet more issues with moc generation on OSX when Boost is involved.


cannot merge: - "i386 Linux" state is "failure" - "AMD64 Linux" state is "failure"


Does it just leak `ck` memory here?


This comment could be wrapped at 80 columns :)


All the control, but in configuration. Keeps the CSS clean, and the config is in charge of adding the appropiate prefixes.

Right now we're not defining anything, but it would be a good idea to set the browsers we support in the configuration so that it manually adds the corresponding prefixes.

See https://github.com/passy/autoprefixer-loader#options, you can pass any options that autoprefixer supports.

I'm not a fan of manually specifying prefixes, I prefer to define the supported browsers and let a tool do it for me. Makes the CSS leaner and the upgrade path for supporting more or less browsers is a config change instead of diving through css files figuring out which prefixes to add or remove.

Also less code is always a win IMO.


Why dictionary? It looks like the keys and values are same. Or am I missing something?


Just out of curiosity, is this your syntax for private vars?


TeamCity Civic Assembly :: Build backend + frontend [Build 111](http://54.229.176.143/tc/viewLog.html?buildId=245&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


Extra whitespace before parenthesis.


but there should also be an option to disable atleast one which wasnt possible


add for


Ну да, надо пройтись по остальным депенденсям.


How about adding here:
```
std::unique_ptr<completion_key> ck_holder(ck);
```
?

`ck` can then be used as a pointer, but the holder will delete it when going out of scope anyway.


Auto generated :(


cannot merge:
 - "i386 Linux" state is "failure"
 - "AMD64 Linux" state is "failure"


I prefer keeping 'arg' as a later evolution of the script may introduce command line options for instance.
Also, `sorted(dumpfiles)` would be useful if dumpfiles was in a significant order to begin with. Here it is not the case, the only meaningful order is the sorted order, so it's best to `.sort()` once and for all.


If I get things correctly this can be a noop. Would maybe be more readable to have a return this in case of noop ?


Cyberium slaps @Tobschinski around a bit with a large trout


Comment should start from the new line, I think.


Missing var ?


Which "this" are you referring to, that can't be controlled? Doxyfiles have quite a few options relating to including/excluding documented/undocumented symbols as well as (IIRC) allowing to filter/add stuff by patterns. Also I think there's a comment command like "@internal" or such that allows to enable/disable various symbols based on an option in the Doxyfile. IMO, since Doxyfiles are so trivial and low maintenance burden, it makes sense to have one for each purpose, as opposed to having to make API changes to allow codegen to work with the Doxyfile used for the reference manual.


Why the code style is so strange?


Close brace should be on the new line.


TeamCity Civic Assembly :: Build backend + frontend [Build 111](http://54.229.176.143/tc/viewLog.html?buildId=245&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:04:14


Yeah, it's a convention that is used sometimes. It allows you to have variables of the same name but denote what is private or public - good for sets e.g. _bob = bob;


Grhh... I'm on Linux Wheezy which runs with cmake 2.8.9. At the moment I can not change the whole OS. Maybe there are any other possibilities?
https://cmake.org/Wiki/CMake_Life_Cycle_Considerations


rather than messing with files in the current directory, i recommend using a temporary directory, like i did in [integration-test.bats](https://github.com/X1011/git-directory-deploy/blob/master/integration-test.bats)


Hmm right I thought you could use a dummy IP and -v to see what command it tries to run but it will always try to do status before doing anything else.. Should be possible to test if the command it tries to run looks alright with verbose and an old ipmi though, even if the command diag itself will fail :)


@andresgutierrez I fixed the Oracle dialect in my private branch at https://github.com/rlaffers/cphalcon/commit/91985cf28e10ef8434e0f2ddf07ff2b5e92c11cb

This fixes https://github.com/phalcon/cphalcon/issues/11033#issuecomment-164334983 and https://github.com/phalcon/cphalcon/issues/11217

Unfortunately I had to branch off from the last known working commit from just before your commit #1fe6089a2773fe0926af34c6202470ee32c199be . After that, it seems Phalcon does not step into the limit method in the Oracle dialect when using findFirst() or find with limit specified. Can you confirm this  behavior? I would like to bring my fix into the 2.0.x branch but first we have to figure out what went wrong later.


What version Boost? Does #420 build?


Sure.
I think the translation will be finished till Christmas. I'll create a pull request as soon as it will be done.


Technically it could be turned into an elif, but the fragment at lines 131-139 is about _TIME_BITS whereas the fragment at lines 141-152 is about _USE_TIME_BITS64, and I prefer each fragment to be a statement on its own.


Just idea generated automatically


Removed.


bro please learn to cherry pick and dont create more pull req.
It makes commit  history untidy


That's 1.1 :)


Please add braces around the body of the if condition, even if it is a single line.


Same as above.


Boost is 1.59.0. The one I had to work with Nathan to fix the other day after he broke it. Testing #420 right now.


Typo, fixed.


All good now. Thank you! :)


This function can use some comments to explain what it does and why.


There should be a space between the function name and the opening brace, the same for the lines below.


Builds just fine. OSX does have issues with moc files though. To make ti all build before we had to avoid using some boost libraries when compiling the moc files and that fixed the issue.


Hi @adiel . Thanks.

Just wondering, was removing shadows altogether intended here?

For such a change next time It would be awesome if it was added via a pull request, just to get some second opinion.
Thanks again for the contribution.


oh :)


you can make this less tricky:
```bash
parse_args
assert that "$append_hash" = dotenv-hash
```


I think that instead of doing that spaghetti if-elif-fi stuff all over the script I think is better to factorize it in a function.

For example, declare something like
```
sha1sum() {
	if type "sha1sum" > /dev/null 2>/dev/null ; then
		sha1sum "${1}" | awk '{print $1}'
	elif type "shasum" > /dev/null 2>/dev/null ; then
		shasum "${1}" | awk '{print $1}'
	elif type "sha1" > /dev/null 2>/dev/null ; then
		sha1 -q "${1}"
	else
		echo "Unable to find something to compute sha1" 1>&2
	fi
 }
```

And then call this as:

 ```
sha1sum=$(sha1sum "${tmpdir}/wpa-psk-linksys-dec.cap")
```


Name of a field or method should not be capitalised in Java (per common code-style).

Java doesn't have any language support for accessors (getter/setter), so this code means that the *field* `id` is public. This is usually very bad idea and java programmers avoids it as a devil of a crucifix, so in a real world code there would be `order.getId()`.


This breaks our test runners as they can no longer initialize DesktopService properly. I'm going to remove the boolean for now as i don't think a full initialization would cause more problems than this partial init causes.


You should use `FRIBIDI_LEVEL_IS_LTR` here for clarity.


I am thinking how to distinguish words "shared" and "propagated". We could state something like:
> Application context is shared between all asynchronous observers as defined in "19.3.3. Application context lifecycle in Java EE". Additionaly all other contexts associated with built-in normal scope do not propagate across asynchrounous observers.

However I am not sure if it is reasonable to reference EE chapters from within "Core" spec part. And maybe "contexts are not propagated" sounds to me better thane "contexts do not propagate".


This is a good enough fix for 1.5.*  but if there's similar code post refactor, we should ensure that
this.sourceBufferExt.remove
is guaranteed to call the end pruning event, or the same bug will trip us up elsewhere.


i havnt tested that case yet. but what happens if $bizRule throws an Exception in php 3.6.? Does the catch  block generate a "class not found exception"?


Great! Thanks for this. I assume it's so you can bookmark it with your username as the qry arg? Cool.

Couple things:
 - $_GET is a PHP function, afaik. I really don't want to add a dependency to the whole of PHP just for this, plus it looks like you've already implemented $_GET in native js with  getVars? Could you just call this instead within the document.ready?
 - For consistency, could 'u' be username?

Cheers,
Laurie


What? No travis?


Again, method name should not be capitalised, so there should be `method()`, not `Method()`.


Yeah I think I ran into those issues when I first tried to get the Mac build script working as well. Haven't tried again since then. If #420 builds fine let's merge #419 based on @IngCr3at1on and my testing on Windows and Linux and then move onto #420 which should then have full Windows, Mac and Linux build support. Can you please comment on #420 that it builds fine?


TL;DR is the first line; the rest are details :wink:


You should use 4 spaces for indentation instead of taps.


I have reverted this change, and created a temporary 2d version of the node. I understand that you want to be able to do extra things with this node, but I use it the way it is.. there's no harm in having an almost duplicate node for temporary purposes... or even use a branch with your own version if it is temporary.

The better overall solution is ofcourse to rethink the Curve Node entirely https://github.com/nortikin/sverchok/issues/758

an MK1 version (because current svcurve node is beta). I'm willing to do this, but @nortikin for now please make edits to the Alternative curve viewer node `curve_viewer_2d.py`


As soon as possible.
I have no preferences for the supported interfaces just to make a generic package which can be used by most of people, any way If you want a hand on this just give me a shout :)
Thanks for the support and fast replies ...


It is possible to run docker within subuser by seeting the `privileged` permission. Unfortunately, it is not possible to do so without compromising security.


yeah that makes sense


What are you trying to do?


本文


Do you really need to keep wizard.count?


`if not conversion required` -> `if conversion is not required`


補足すると、マルチスレッドな非同期処理を止めるにはそれなりの配慮が要ります。
EndAcceptTcpClient()からObjectDisposedExceptionが飛びますしserver変数をnull参照するかもしれません。
こういうのを解決してまでポート番号の動的変更に対応するコスパは低いと判断しました。


Crashes on mobile. document.body is not available here, if cocos2d is included in html <header>


There are multiple configuration options which allow you to target specific file types, project files, directories of files, and more. Using the available tools, you can customize your find or find/replace to quickly make changes to text or code in a directory of files.http://pass4surebraindumps.com/


Hmm, what do you mean with "mostly academical"?


"default" is invented exactly for that.
It is an alias that the user is supposed to map to something.
Otherwise every single prog would require the alsa dev name
in its config. There should be a single config instead, and that is
asoundrc.
BUT, as long as it doesn't suit for the run-time configuration
from dosemu, I'll look into other solutions. Its just something
that you can use yourself, instead of hacking the midi plugin
code for a different name.


We can't do that. We should perhaps move the shared mention to core for application context.
Anyway repeating this here is... wrong from the denormalization pov... and right from user pov :-)


typo:

s/is/it


Do you have an IRC channel for this package or how do you communicate with the rest of the team ?


@shruthidipali @HemanthGowda Spring boot is awesome :+1:


I think that you do not need to write the header for an empty section


add Reading Report


wanted a O(1) lookup and not use a contains. Should I use HashSet?


Could also use:

```bash
$TRAVIS_TAG = $(awk -F '"' '/version/ { print $4 }' package.json)
```


Yes, they were contributing to how hard it was to read on the (poor contrast) big screens.

I'm all for pull requests, and certainly would have if I'd made any functional changes. However, it looks completely different on proper monitors like we code on to how it is up on the wall, so no way for anyone to review it and give useful opinion until it was up on the screens, so just dived in and made a bunch of quick css changes and refreshed the monitor here till it I could read we could read it from my side of the office.

But please everyone dive in and improve further on what I did, it still doesn't look great by any means.


ok


maybe it can be macro and not 1-line function?


TeamCity Civic Assembly :: Build backend + frontend [Build 112](http://54.229.176.143/tc/viewLog.html?buildId=246&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) is now running


$< looks weird alone separated. Is it possible to merge it with before line?


> I can't actually find any tests called StringTest.
> It appears to have been renamed to TextTest and not simply duplicated. Can you point me in the correct direction for this test?
> I assume it is to do with autoloading, but can't be sure.

OK, then this wasn't the issue and I had already moved the string tsts. I guess there's some place else loading/calling it. Ensure the app is also on 1.1. You have to trace this back.

> Is there a reason why this class is still being used / called.

No there should be no code in 1.1 calling String.

> Also, what is holding back the #1211 from being implemented? Is there something there that I can help work towards?

It needs to reviewed if this is a fitting replacement. I'll ping nate on this.


The getGigInfo() function failed this morning as our request to https://thelist.co.uk timed out. Yesterday, it was because reddit was having problems and the submission function returned an error.

Now, it will wait 15 minutes before retrying. It will attempt to post for two hours.


Ein get C wäre auch nützlich. Eine Antwort wäre dann z.B. "CES,CDU,CEC"


建立结构体数组，其成员有name,age,和student类型的指针变量next。定义一个i变量，用来for循环。定义3个student类型的指
针变量。利用new建立一个无名结构体，并让head指针指向这个无名结构体。让指针head中的next指针为空，同时p也指向这个无名结构体。利用f
or循环4次（几次都可以），又建立一个无名变量，并让q指针指向它。让p中的next指针指向q（这个就是链表，让这些结构体链接起来）。让q中的ne
xt变量为空（第二个结构体中的地址域为空）。将name,age输入p所指向的无名结构体中。再令q的值赋给p，这样也就传递下去了。wihle循环将
p指针中的name,age依次输出。并让p中的指针变量next赋值给p。


can you please give more details about the issue and provide an example, thanks.


a `O(1)` for 3 items?


TeamCity Civic Assembly :: Build backend + frontend [Build 112](http://54.229.176.143/tc/viewLog.html?buildId=246&buildTypeId=CivicAssembly_BuildBackendFrontend&guest=1) outcome was **SUCCESS**
Summary: Running Build time: 00:04:16


I figured we might extend it. But yes might be YAGNI


Fixed in https://github.com/odoo/odoo/pull/10080


建立结构体数组，其成员有name,age,和student类型的指针变量next。定义一个i变量，用来for循环。定义3个student类型的指针变量。利用new建立一个无名结构体，并让head指针指向这个无名结构体。让指针head中的next指针为空，同时p也指向这个无名结构体。利用for循环4次（几次都可以），又建立一个无名变量，并让q指针指向它。让p中的next指针指向q（这个就是链表，让这些结构体链接起来）。让q中的next变量为空（第二个结构体中的地址域为空）。将name,age输入p所指向的无名结构体中。再令q的值赋给p，这样也就传递下去了。wihle循环将p指针中的name,age依次输出。并让p中的指针变量next赋值给p。


You should keep the complexity settings and change your code by doing refactor/functions reuse etc.


@href How about this?

Btw: The datetimepicker is currently in onegov.town. I moved to code to a separate file so we can easily move it to onegov.shared.


also this only runs once at startup?


why need set http.setRequestProperty(\"Accept-Language\", \"zh-CN\")?


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (912 of 912 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.87%25-green.svg)


regex should be constant values. Write them with upper case


\"Accept-Language\"


Test


\"zh-CN\"


Ok after some investigation I found that the problem was that I was injecting the object mapper in the same Configuration class where I was creating my modules. Even if the modules beans did not depend on the injected object mapper, they were created after Jackson2ObjectMapperBuilder. I did not know that behaviour in Spring, but it's logical since Configuration are spring beans! It worked before thanks to @PostConstruct. This is not a bug but the behaviour clearly changed ;) Thanks.


Pushed a version with a HashSet. Are you proposing YFHCI?


The timeout is actually needed I think?  See https://github.com/radical-cybertools/saga-python/blob/feature/osg/src/saga/task.py#L556  I guess that all the other sigs need fixing... :/


имеет ли это смысл ?


Unfortunately no. Played a lot with this, without success, and decided to move to the inbuilt ajax file, that maintains WP Core.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9573](https://teamcity.mesosphere.io/viewLog.html?buildId=93710&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 207 Build time: 00:11:25


You are right,  this will be made in another PR


Let's continue the discussion on #1224


Just use sentinels.


Why the empty string?


I think we don't need to give special styles to default bootstrap styles


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#D1ltePYQQ3ahfd6STqVPtA


Added a new branch for me to develop into. So we can avoid merge nightmares on each commit.
we just have to do a big merge conflict when we merge this branch into indigo devel.


The sites-dropdown already defaults to primary site so you could simplify your logic here.


Duplicit declaration of $lang['upload_file_exceeds_limit']


Is there a new link for a CI build? The previous link is to the specific previous version I tried.

To summarise after your flurry of activity :)

* I have node 4.2.3 installed (via nvm-windows)
* .eslintrc is in project root as is server.js, the file to be linted.
* NTVS 1.1 installed - only config change is to use ES6 intelliSense preview
* tools -> WebAnalyzer -> Edit .eslistrc opens `%userprofile%\.eslintrc`
* Right click on server.js and run appears to do nothing - no new errors
* Moved proj eslintrc to userprofile but WebAnalyzer still produces no errors

Is there a way to get visibility on what WebAnalyzer / eslint is doing?

I just realised that my config is a little unusual and may in fact not work with Web analyzer. So my eslint.rc uses a plugin `"extends": "eslint-config-hapi",`. As I want the project config to be independent of the users config I try to specify everything in the projects package.json. Thus eslint and the plugins are all project installs and I run `eslint` from `.node_modules/.bin` (actually using a npm script which puts it on the path). ESLint finds the plugin just fine and works as expected, finding a missing 'use strict'.

However trying to run any global install of eslint with throw a missing plugin error as it is not found. I wonder if your config suffer this as well? Unless you ensure the project installed plugins are found in node_modules then I guess ESLint is going to fail.

However I see no errors. I'll try it with a global install of the HAPI plugin later.


@cbrune
The statements was moved from ``50_onie_grub``.  Is it reasonable that NOS/DIAG installer can override ONIE's ``GRUB_SERIAL_COMMAND`` and ``GRUB_CMDLINE_LINUX``?


Don't forget to wrap parenthesis :).


And here


I think this file is redundant


`CMAKE_SOURCE_DIR` -- отлично, project() на данный момент только один. Больше пока не предвидится.
https://github.com/v-nikulichev/mastermind/commit/28eead1462556f608df07aec55124f5e01b19f72


`esc_attr__( 'Found in translation', 'glotpress' )` would be better than `__( 'Found in translation', 'glotpress' )`


`(( H > W ))`?


Why not `[[`?


Looks good!


I have no idea what these questions mean :).

This patch is working for us is all I know.


It is for the sake of the homepage url. It's a special case, unlike other base urls which are followed by something like `/en/videos/*`.
I hope I have explained it well


This entire block could be DRY'd up by using a shared example?


I've tested on 5.4, 5.6 and 7. Works well.


thanks @darokel I will just that


@NathanWalker great point!


No need for `$(())`, arithmetic is supported already.


Isn't it easier to just do a server-side download of the json-document to insert the thumbnail picture?


No problem! Unfortunately, I think fixing the linking issues is not possible for us. CVC4 uses libtool for creating the libraries and according to https://lists.gnu.org/archive/html/libtool/2014-04/msg00001.html $origin is not supported. This is what we would need in order to get the linking issues fixed (libcvc4jni.so needs libcvc4.so.3 and searches for it in ```/localhome/stieglma/cvc4-2015-12-15/builds/x86_64-unknown-linux-gnu/production/src/.libs/libcvc4.so.3```. But as it can be seen this path is specific for my computer.

The bug request at CVC4 can be found at http://church.cims.nyu.edu/bugzilla3/show_bug.cgi?id=695


Even better would be to put `$(TRANS)/xccdf2table-byref.xslt` to the next line. I'll do it.


Great job, don't forget to closed the associed issue :)


It is possible to add some templates by a command like ".template add Hand", ".template add (item)" and create a file with all templates the originals and the custom this will be OP but we can't do that because the chat limite is too small


Yes. Fixed in [next commit](https://github.com/FrontAccountingERP/FA/commit/75a427435541f54e1834409dde4c9b02e81dc2de) - better to expand tabs to 4 spaces.


I'm not sure how this is being used outside this file but I don't see much use for this from a user perspective. It could be a utility and I am happy for this on the interface classes but not on Columns itself (unless you can convince me that users will want it).


Yes, added - https://github.com/sprightly/bbp-live-preview/commit/749544973b688bc63ca479c81880c0f8b87110d3


You shouldn't have to make pull requests into your own repo.  That is designed more for contributing to other people's repositories, like when I updated your readme. This allows you to approve it.  When working in your own repos, it is preferable to just create feature branches for your work and then merge those branches to master when you're ready.


We regularly update the font icons as and when we need a new icon. It may be best to parse the icons from https://github.com/thebeansgroup/plinth/blob/master/vendor/assets/stylesheets/plinth/fonts/_fontello.scss  so we can keep them up to date.


Im not sure if it is needed on cancel in this case, but I see that the spec defines the parameter on cancel too. I likely changed that because of some signature mismatch in other parts of the stack.


Oh, I thought I moved it already. :)

Anyway looks good to me. It would be great if we got the date format information from the locale somehow, instead of hard-coding the information for each locale (Babel should know what we need). But since this is not really something we use yet we can skip this for now.

We do use it_CH, fr_CH and rm_CH though, so you should add those locales alternatively.


What kinds of exceptions are you catching here ?  What happens if you don't catch them ?


:trollface:


and here


You're right, I have thought urandom is not available on another UNIXes, but it seems it's everywhere (at least as symlink).


it's not tested but it shall fix graphic


yeah, the other container_cancel sigs seem not aligned indeed...


It is obvious from the two lines of code that 10 seconds is being subtracted, but the comment should address *why* this is being done.


That's wicked cool :smiley:


Looks like ```gradle clean``` doesn't delete GWT generated files - is it intended?


```bash
printf -v spaces '%*s' $W
```


yep it has to be instantiated


Ah. This method already exists on ``Dimensioned``, in which case it *is* consistent. Looking at ``Dimensioned.dimension_type``, I see that it isn't entirely trivial as it infers the dimension type from ``dimension_values`` if not declared on the dimension. I don't think users will use this often but I'm no longer going to argue that this should necessarily be a utility.


Please elaborate this one a bit.

Removed because of remove_filter accept only 3 argument, therefore work in the same way with '2' or without - https://github.com/WordPress/WordPress/blob/c2248060fe3ab1cb9bec15256e138c1e4e9a3f14/wp-includes/plugin.php#L321

Basically PhpStorm noted that there is issue with number of arguments, and fixed this in order to avoid notice -]


empty or === ?


Quite an odd import – does this belong here?


Looks fine as this makes ``Columns`` consistent with ``Dimensioned``. I don't see myself using ``dimension_type`` very often though...


No I can remove it, you're right.


E.g. "The obs tstart and tstop times are derived from the OFLS maneuver summary file, which for implementation reasons gives the maneuver times offset by 10 seconds from the actual command timing.  Fix this here."


Forgot that I had changed it, it contained more code which was removed before the push.


bø


Right. This was the main difference between how groups and labels were processed.


Visibility was fine on any display I tested it on.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9574](https://teamcity.mesosphere.io/viewLog.html?buildId=93718&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:08


Misspelled 'Canola'


@mileo


Does not matter, it will kill the browser tab in what ever way you do it.
On Tue, 15 Dec 2015 at 18:08, koefoed <notifications@github.com> wrote:

> Why read in the data a second time?? In particular the
> "sfpd_districts.geojson" file, which you do not use at all?
> Why not put
> $("#killBrowser").click(function(){L.geoJson(sf_c).addTo(map);}); right
> after startVisualization(sfpd_d, sf_c); in line 52 (along with drawMap()
> )??
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cnrd/IDE15-16/commit/65ce63ad3793ba969f74aad70b65b39ad776c61e#commitcomment-14991686>
> .
>


just use fake_physical_device_name here to remain consistent.


If use `printf` for a spaces string like `spaces`, then replace all spaces with the trunk character, two lines and no loop, it should gain a bit of performance, although I doubt it would be much.


Sorry to be pedantic, but can we capitalize the `sets` and make the comment something like:

```
Sets the maximum length of each sentence in the input data. Any sentence longer than this threshold will be divided into chunks of up to `maxSentenceLength` size (default: 1000)
```


What does this mean, IsAllocated? Isn't the root always allocated?


I think this type can be moved above the each loop, since the poll is always the same :)


Yaaaaaaaaaaaaaaay


参数里面指明了类型，如果传入的接口不符合接口或者不是null，则会直接抛出异常，无需再用empty检验。


Using the external URL is not going to work in some cases, what you need to do is copy the attachment (original) to the filesystem, then transcode it.

This is how you stream an attachment into a file.
```
import org.apache.commons.io.IOUtils;
import java.io.FileOutputStream;
....
def origFileName = makeRandomFilename(videoDir);
IOUtils.copy( videoDoc.getAttachment(videoName).getContentInputStream(), new FileOutputStream(origFileName) );
....
invokeFFMpeg(origFileName, outputFiles, whatever other parameters);
```


I meant that it is not used that much in real projects. Will remove it as it is matter of opinion


Thank you


нельзя обойтись без обявления локального инстанаса?
```
WestPanel localWestPanel
```


ok.


It's very easy to make some words **bold** and other words *italic* with Markdown. You can even [link to Google!](http://google.com)


Von meinem Samsung Gerät gesendet.

-------- Ursprüngliche Nachricht --------
Von: Ralf9 <notifications@github.com>
Datum: 16.12.2015  11:18  (GMT+01:00)
An: RFD-FHEM/SIGNALDuino <SIGNALDuino@noreply.github.com>
Betreff: Re: [SIGNALDuino] Added option to enable / disable manchester,
  unsynced and synced messages via (87be46e)

Danke für den Hinweis, damit bekomme ich den Rest hin.

Das

"ITClock"  => '200,300,400'

ergibt dann aber ein Auswahlfeld, wäre da ein Eingabefeld nicht besser?

—
Reply to this email directly or view it on GitHub.


参数里面指明了类型，如果传入的参数不符合接口或者不是null，则会直接抛出异常，无需再用empty检验。


Thank you, not sure how this happened


А чего такое странное название-то?


Don't we already have a NextPowerOfTwo method?


BTW: Should this be `unmarshaller(_).fast` instead?


Oh, yeah, thanks for poiting that out. I figured that line was redundant and commented it out to see if it doesn't break anything and forgot to remove it.


А как? С цифры-то нельзя начинать название.


santhosham


Copy-pasted oversight:)


Params3dMode, например. Сойдёт?


Thanks :)


EconomizerIntegrationNew (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1444 of 1444 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-warnings-yellow.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.53%25-green.svg)


Oops @SavionLegendZzz

At least there was only one screw up ;P


Not needed, you should have the same workflow as above.


Получше наверное, подчёркивание на мой взгляд совсем режет глаз.
> On Dec 16, 2015, at 2:41 PM, Alexander Marchuk <notifications@github.com> wrote:
>
> Params3dMode, например. Сойдёт?
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/trashkalmar/omim/commit/26ed657a3ee0e88c8578fb7f1f676c4b4a0dd670#commitcomment-15011434>.
>


just use range


git push command:
git push -u origin HEAD:master


@varund7726 Very sorry for the mistake. I'll be more careful. Thanks for the warning


the sed script has messed this up, resend the patch with correct changes


@bamboo, I've just tried to fix the output processing in gradle/features build.gradle to avoid stripping this line of output, but was unable to do so. The problem is that stdout and stderr are being written in two separate threads, and along the way, this line gets overwritten (perhaps due to its trailing newline character, but I'm not sure). I'm hoping I can talk to @paulk-asert about this and get some advice on better ways to work with Groovy's process output handling. In the meantime, I'd say let's just let it be and not waste any time on it; it's fairly minor, and the first such instance of this problem I've run into.


whoops


Hi Thomas,

Cool stuff. Just wondering why you roll your own formatter instead of integrating cljs-devtools :-)


Only noticed because I got an email from Packagist about it :wink:


You're welcome ;)


It was fun working with you


Hi Anton,

you are right, yade --test causes "segfault". However, I don't thing my commit
is to blame. In fact, I run version ad1ac86 from December 4, which is the
oldest version I have on my computer, and this problem existed already there.
It must have been introduced sometimes before. BTW, I thought that the server
in Grenoble is automatically compiling --test every day? Do we have to compile
each version and run --test to find out or is there a quicker way?

Anyway, let me know what you think.

Cheers
Klaus

On Tue, 15 Dec 2015 11:36:51 PM Anton Gladky wrote:
> Klaus, could you please check, whether you are able to run --test after this
> commit? It looks like this commit causes "segfault".
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/yade/trunk/commit/dfec2028eb64ec78a99535ad309a9cee4317c4f
> 4#commitcomment-15006722


ditto.


Newly added lines should sport braces according to our style guide.


Why should the condition considered twice?


obvious wrong.


@msom Very nice!!! I would like to see this released asap.


This last bit is unnecessary, existing implementations only count if the spec was written for them (e.g. MONITOR). The current existing implementations simply do not match the specification because the authors thought it is a better idea to do what is being proposed here instead of the original spec.


Isn't the correct url updates/latest? https://github.com/gephi/gephi.github.io/blob/master/updates/latest


It is? What should be the correct order?

From the context of Auth::authorise():
`TokenParams.clientId` overrides
`AuthOptions.clientId` overrides
`ClientOptions.clientId` overrides
`ClientOptions.defaultTokenParams.clientId`
Is this correct?


@doefler Awesome idea! :+1: Thanks for your contribution Kim!


Can you switch to `WPAppAnalytics` - we have convenience methods on here and just decided in the past couple days to call it using that class instead of WPAnalytics to not use both classes.


Why should the condition counted twice?


Oh snap, you're right!


Hm, looks like it can never become negative with the current code (unless perhaps `number_of_steps` is negative and `step_number` overflows. Perhaps convert both to unsigned instead (in a separate commit, I guess).


Done.


We do not use dots in the keys in Camel, please CamelPahoQos etc


test


Aici trebuie luat serviciul din container - $this->get('nume_serviciu')


git push origin HEAD:refs/heads/master = git push origin master

1.refs/for 是gerrit概念，通过refs/for提交需要codereview
2.local tag: v2.0(=refs/tags/v2.0)， local branch: git_int(=refs/heads/git_int)


You can do this in one line

 return exchange.getIn().getHeader(PahoConstants.CAMEL_PAHO_MSG_QOS, getEndpoint().getQos(), Integer.class);


Whoops this comment was on a commit and not the PR diff.


in loc de tot if-ul asta apeleaza o functie din serviciu care sa intoarca true/false (ex: isValid(), isSuccess())


You could mock vmutils in setUp.


O extensie de twig ar fi fost frumoasa, care sa decida daca e "active" sau nu


construct sa devina init()


Nice


Ey @hsato42 why do you do this? And also the next line with the link


Hey,
Thanks for the response, it doesn't break anything. It solves a problem we
are facing, hence I requested information on why this change was made.
Cheers,
r.
On 16-Dec-2015 16:00, "Lluis Josep Martinez" <notifications@github.com>
wrote:

> I added it to simplify test cases by avoiding castings. But if it breaks
> compatibility I can revert it tonight.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/openmrs/openmrs-module-webservices.rest/commit/5db24504a6239db8648dd336d7951fa74ba55524#commitcomment-15010052>
> .
>


This is so misleading, mock_get_vm suggests something completely different than this.


imho, `unique_ptr<>` makes the code more complicated. the owner ship of the txn is transferred to the caller when the OSD completes the comparison/check. and we need to do something tricky to prevent from `unique_ptr<>` from calling the deleter when getting the underlying raw ptr.


Why don't you use a decorator instead?


могу предположить что в случае str == null исполнение не доходит до этой строки, как думаешь?


Bonjour

Au revoir

Cordialement


Looks like you've missed updating the `image.get_rendition` in wagtailimages/blocks.py, which is the one you wanted to fix in the first place... :-) No problem, I'll add this.


you are right. Thats wrong.


gwt files are generated from scratch each time, the gwt task isnt setup for incremental builds. It isnt intended, should i add it if possible?


@varund7726
line 222
Is this string may be wrong?

<b>Nav bar dimensions</b>


а, на счёт смены int на Integer, этой мой прокол - не учёл что int не может быть null


Thanks, done.


Save3DMode не надо внутрь DrapeTask-a положить?


lui contact action poti sa ii dai parametrii (Request $request) .... symfony injecteaza tot requestul cand se acceseaza actiunea. Ca sa iei body-ul unui request (daca are .... daca e POST, atunci are) faci $request->request->all(). da un var dump sa vezi ce intoarce asta


Нет, в этом и состоит смысл рефакторинга. DrapeTask выполнится только после создания движка, а нужно сохранить настройки сразу.


What is the MOC error? Using both the extractors and the writers seems like a convenient way.


Have a look at how the PDF extractor and epub / mobi extractor are implemented. You can use the same libraries.


If, I am on 0.13.1 of Minecraft Pocket Edition and I can join 0.13.0 server.


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1449 of 1450 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.93%25-yellow.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.04%25-green.svg)


These seem unnecessary?


These seem unnecessary? And unrelated?


Buildbot is since end of November does not compile anything
due to maintenance. Should be fixed soon. I compiles the version
#09967be (just before your commit) and it did not give any
segfault.

Regards

Anton

2015-12-16 12:47 GMT+01:00 Klaus Thoeni <notifications@github.com>:

> Hi Anton,
>
> you are right, yade --test causes "segfault". However, I don't thing my
> commit
> is to blame. In fact, I run version ad1ac86 from December 4, which is the
> oldest version I have on my computer, and this problem existed already
> there.
> It must have been introduced sometimes before. BTW, I thought that the
> server
> in Grenoble is automatically compiling --test every day? Do we have to
> compile
> each version and run --test to find out or is there a quicker way?
>


We should say how to run these somewhere (either in the next section, or linked if you can achieve that).  People might think "that sounds like a big hurdle" and give up.


Line is too long. [106/100]


lgtm


Where did this key ID come from?  Just wondering i case it needs updating


Fair enough. Honestly, I didn't even realise that I was deviating from the spec when writing the implementation, otherwise I'd have submitted this back before 3.2 was released.


разве это правильно? В моём понимании `X I X` это 3 отдельные цифры, в этом случае я бы выбрасывал ошибку формата входных данных. Это касается всеx тестов с пробелами. А вот регистр я думаю не важен, то есть x == X == 10.


Added "md" to this, to support Markdown. But then it gets thrown to a new line.
I hacked the css with:

.checkbox p {
  display: inline;
}


Seems ok, I guess your plan is to have later a list of `add_${something}_input` followed by the `add_${something}_output`.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9575](https://teamcity.mesosphere.io/viewLog.html?buildId=93722&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 206 Build time: 00:03:36


This doesn't sound essential to me.  And the way it is expressed seems like a big turn-off for potential users.


We also have swig on our channel btw ;)


в названии фукции указано empty (то есть ""), а передаёшь null :), не последовательно как-то...


**Code Quality - Critical**

You should one style of string encapsulation in Javascript, either single or double quotes.


You can use _basepath instead of "entities/player1/"


I welcome the patch!

On Sun, Dec 6, 2015 at 1:15 AM, Thiago Farina <notifications@github.com>
wrote:

> May be add include guards to this header?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/flok99/httping/commit/d0699b8a47da23edb718829692cdf424fb7adb7d#commitcomment-14806318>
> .
>

--
www.vanheusden.com  www.slimwinnen.nl | www.smartwinning.info


I think it would be nice to delete it on clean then.
Also, some of the dependencies are kept with the source (
https://github.com/wisebaldone/incubator-wave/tree/feature/Gradle/wave/dependencies/compile)-
is it intended too? I think it increases the repo size by 60+ MB.

On Wed, Dec 16, 2015 at 2:01 PM wisebaldone <notifications@github.com>
wrote:

> gwt files are generated from scratch each time, the gwt task isnt setup
> for incremental builds. It isnt intended, should i add it if possible?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/wisebaldone/incubator-wave/commit/76b0b9a78535d4efba23e5eb0382167449de0ba2#commitcomment-15011829>
> .
>


**Code Quality - Critical**

You should style your closures with the consistent style adopted in other parts of your codebase. Like so:

```
if (hour > 10) {
  hour = '0' + hour;
}
```


а чем boringRTC лучше?


About "ol\ul\a\img and del tags".
There was issue with my installation styles, removed this specific changes - https://github.com/sprightly/bbp-live-preview/commit/2fa6957976c18b86bd9e5ee5e712cc134a30937a

About "stripslashes".
There was some problems with attributes, that I can't reproduce already, but with use stripslashes directly exist problem with strings like "Symfony\Component\Security\Core\User\User", that become "SymfonyComponentSecurityCoreUserUser" in preview. On current code, where stripslashes done on filter (https://github.com/sprightly/bbp-live-preview/commit/5153d0b3665c6a9555849cb1a68022dc5fefd0d1), all fine.


Go easy on the reader, and don't lump these commands together so.  I.e., describe "service" first, then describe "select"


Could you move this into a separate file and folder ```app/validators```? This may not be the first and would rather its clear to see that we have our own custom validators and where they are.


Alright, I will look into it.

Cheers
Klaus

On Wed, 16 Dec 2015 04:07:09 AM Anton Gladky wrote:
> Buildbot is since end of November does not compile anything
> due to maintenance. Should be fixed soon. I compiles the version
> #09967be (just before your commit) and it did not give any
> segfault.
>
> Regards
>
> Anton
>
> 2015-12-16 12:47 GMT+01:00 Klaus Thoeni <notifications@github.com>:
> > Hi Anton,
> >
> > you are right, yade --test causes "segfault". However, I don't thing my
> > commit
> > is to blame. In fact, I run version ad1ac86 from December 4, which is the
> > oldest version I have on my computer, and this problem existed already
> > there.
> > It must have been introduced sometimes before. BTW, I thought that the
> > server
> > in Grenoble is automatically compiling --test every day? Do we have to
> > compile
> > each version and run --test to find out or is there a quicker way?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/yade/trunk/commit/dfec2028eb64ec78a99535ad309a9cee4317c4f
> 4#commitcomment-15011920


по сравнению с чем? :)


Does the ```focus: true``` need to come out?


this is unncessary because lengthCol is already set to 'length'


People might not get that this means that it is a floating IP address.  They might thing they need to make it correspond to real IP address somehow ("arbitrary" doesn't quite get the point across).  So elaborate it, and give an example.


>  For undescores, I would prefer to keep them to help the reader clearly see what is the class member and what is the constructor argument.

Personally I would not use underscores. But I am not sure what the community thinks here. You can keep the underscores unless others start complaining also.


"Better statistics" -> "HTTP-specific metrics"


More logging is good IMHO, but it is unreleated.


**Code Quality - Critical**

When an error occurs in your processes, you should set an error status code to indicate that there was an abnormality in the operation.

In this case, a status code of  `500` will do just fine.


This is a duplicate of https://github.com/smiley22/S22.Xmpp/issues/1. Unfortunately it seems that S22.Xmpp is currently frozen.  S22.Xmpp is forked as Sharp.Xmpp. Sharp.Xmpp includes this fix and some other improvements.


Other klte variants use common for dependencies, this makes them pull nothing lol. Maybe just add vendor there