Sorry, but the maven coordinate standards are pretty picky on this, especially for stuff in OSSRH. I can't accept this PR with this change in it, our maven coordinates (especially the groupId) are set.

I know why you did it. You wanted the groupId to match the package names.

The real problem is that the  package names don't allow '-', so really, thats the wonky part.


Mucho espacio en blanco


Ok, it was late last night when I did that, but I really thought I had that in a separate package directory...


1.微調頁面Grid比例與按鈕位置
2.調整說明文字樣式使用標楷體、字型大小、位置
3.新增底色圖片
4.強化try catch安全機制
5.使用全螢幕


Oops - this header really shouldn't be in the repository. It's auto generated and can be included in your application's header if you want. Otherwise it'll change every single time you commit.


Great idea; done;


whoops!


Are you ok if I go straight to 1.4 of go?

On Wed, Dec 9, 2015 at 2:15 PM, Dave Carroll <dcarroll@salesforce.com>
wrote:

> Yeah, I think that it only matters for contributors what version is
> current.  I'm happy to drop 1.1 and 1.2.  It will take some coding to fix
> this in the build system, but I'm about to take some "time off" and will
> address that.  By the way, that's not the jenkins stuff.
>
> On Wed, Dec 9, 2015 at 2:13 PM, Christian G. Warden <
> notifications@github.com> wrote:
>
>> Great. Did you find out if we can drop go 1.1 (and maybe 1.2) support so
>> you can merge #221 <https://github.com/heroku/force/pull/221>?
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/cwarden/force/commit/a21109d75ac1f31f8c1ee468c2885e2bbf7069bf#commitcomment-14886488>
>> .
>>
>
>
>
> --
> Thanks,
> Dave
>

--
Thanks,
Dave


que pasa si se cambia la clase del icono de ionicons?


I will remind about it. Yes it should be now that color everywhere.


Currently, best way is by email (which is displayed on my profile) since I generally can't answer quickly (right now has been an exception).
Feel free to email me, I'll get back to you as soon as I can


espacio de sobra


Ahh sorry Hannah, my bug made it here too! :S
The path should be "./TestData/5x5testmap1.txt" (ie the working directory is the renispace directory, not src!)


I just have to work on this and I have no amavis SQL db so I just completly blindcoding this driver :(


Media queries *


Done, fixed, thx to gmt.


Thanks for the tip. It worked well!


Eliiminar espacios


Will double check the code and update naming to avoid confusion.


Also changed the default place for textures to VRAM, because we have a lot of it and it's faster.


podria ser mejor así
section{
    &.slider{

    }
}


Err you have to change this bit, that should be your name ;)


gj


That’s like 300% harder!


fuuuu


I think this could potentially backfire. We'll exit with reason 'shutdown' if the node is being stopped, but I believe this can also happen if, e.g., our supervisor hits max_restart_intensity and restarts. In that case I suspect we'd lose our sweepers with no way to recover them.


BTW I think to delete THRESHOLD_MULTIPLIER_SKIP_STREETS_AFTER
STOP_SEARCHING_STREET_WITH_MULTIPLIER_RADIUS
cause they don't give good effect and mostly it is better to search streets in wider radius even if we have nearest street in 5 meters, the building could belong to the street for 200-300 m away.


Okay, give me a sec ^^"


Hey @rotty3000  which change ?  The deletion of the -includeresources broke it?


Gotcha.


Looks good.


Looks good


Oh, never mind, disregard my comment above. I just realized this code is all replaced anyway in 593269ad2f31797c015ded363f88c03da30fe695


One day we should bring in babel :)


looks good.


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1447 of 1447 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.53%25-green.svg)


OK.


Preaching to the choir, but if you show up with more template introducer syntax in Jacksonville, they'll want to know why their guidance was ignored.


TeamCity LabKey :: LabkeyRelease15.3 :: Git postgres 9.4 [Build 104](https://teamcity.labkey.org/viewLog.html?buildId=290612&buildTypeId=LabkeyRelease153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 45 (20 new), passed: 242 Build time: 00:45:29
### Failed tests
```
org.labkey.test.tests.CDSTest.verifyFilterDisplays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGrid: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutAssays: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyHomePage: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGridCheckerboarding: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudies: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyAssaySummary: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFilters: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyInfoPaneCounts: <no details avaliable>

##### there are 35 more failed tests, see build details
```


Regarding the change about plugin/NERD_tree.vim, there is an mistake.

The code piece is the following:
```
if !nerdtree#runningWindows()
    call s:initVariable("g:NERDTreeDirArrowExpandable", "▸")
    call s:initVariable("g:NERDTreeDirArrowCollapsible", "▾")
else
    call s:initVariable("g:NERDTreeDirArrowExpandable", "+")
    call s:initVariable("g:NERDTreeDirArrowCollapsible", "~")
endif
```

However, this section means
> When RunningWindows, arrows are +/~
> Not RunningWindows, arrows are ▸/▾

The logic is reversed.

To make the logic right, we could remove ! from the above code.
```
if nerdtree#runningWindows()
    call s:initVariable("g:NERDTreeDirArrowExpandable", "▸")
    call s:initVariable("g:NERDTreeDirArrowCollapsible", "▾")
else
    call s:initVariable("g:NERDTreeDirArrowExpandable", "+")
    call s:initVariable("g:NERDTreeDirArrowCollapsible", "~")
endif
```


Should be a * instead of # here?


so all is good now after most recent commits? need confirmation on auto ban phrases as well so I can update the release, pretty important bug


ashe 4 stack fix


@deric I'm facing a problem whereby ``accounts::users`` supplied in hiera in different level of the ``hierarchy`` can't be merged even if the merge behaviour was ``deeper``. This is the change that breaks it. Please, what was the reasoning behind this change ?

Thanks


Some mistakes  - will them correct later


OK, so it is forbidden to name e.g. output as `OUTPUT`?
It's quite difficult to balance between visually appealing names and difficult to be picked accidentally.


Two suggestions:

1. The way you added the logtoolDir arg in DatafileIterator will destroy compatibility with all scripts that already use the existing version, because you added as a positional arg. Better to make it a keyword arg and provide the default value. This makes sense to me because the two directories are siblings in the repository.
1. Your conversion to csv (I guess that's what the main script is for) makes a strong assumption about the number of columns in the data file. Meanwhile, you asked me to add a column. Why not do that with a loop, after detecting the number of columns in the source file? Better, why not just fix the code that generates the file if it's not coming out in a form that can be recognized as csv. Up to now that hasn't been a requirement, but it could almost certainly be done with an option, so again it need not invalidate existing code.


nit: s/lagacy/legacy


All the maven configuration has been deleted, I cannot see that it has been moved to another page. Was this intentional? It is a very handy reference.


Why are Double arrays being used? If the array represents the positions of the stars, surely it must be an integer value?


I would say HtmlCounter looks way better, than HTMLCounter


I added 1.4 and 1.5 to .travis.yml in #221, but we're running into #150.

Should we switch to the version of `config` in your repo with the build constraint added or configure travis to use the godeps vendored packages and fix it there?


BTW: Are you sure users will understand this? For me, this sounds like "I now can delete timers." and that's not what we mean, right.


latest chrome is actually broken for testing
https://github.com/tastejs/todomvc/commit/74ceed6e7b39b19add5d1cebf6f39bbc5889204b

best to lock it to this known good revision ^


I reworded `index: ...` to `fix: ...` so https://github.com/semantic-release/semantic-release can do its release magic :)


@indutny ^^


Maybe later.


I have a couple other questions too that I'll come by to ask


This was actually fixed in the main repo. See 447d2cad4cff3e5d56af149ef734ebdb099ed796.


What's the idea of having this class abstract?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8864](https://teamcity.mesosphere.io/viewLog.html?buildId=89648&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:43


@jurrick : I'm just starting to test. Big work. But you removed BonusPackHelper.requestStringFromPost ?!


Why not
```
for image in image_list:
       rpmimage := RpmDiff(image.chroot, image.name, self.args.name_only)
       if not rpmimage.is_rpm:
               raise ValueError("{0} is not RPM based.".format(rpmimage.name))
      rpm_image_list.append(rpmimage)
```

Or Raise the exception inside of RpmDiff()


nice


Ok, cool :) Thanks!


Seriously Pingwings?!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8863](https://teamcity.mesosphere.io/viewLog.html?buildId=89643&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:24


Hallöchen,
das sieht insgesamt so aus, als wäre es gegen die Philosophie von GWT programmiert! Sprechstunde?


This fixes the failing Travis builds, I assume?


TeamCity DnnPackager :: Continuos [Build 44](http://dazinator.ddns.net:81/viewLog.html?buildId=1463&buildTypeId=DnnPackager_Continuos&guest=1) is now running


@novemberborn, in the future, please try to leave detailed commit messages. :stuck_out_tongue_winking_eye:

Great work!


You could expose it so that other collaborators can use the same script to release


Should this be Refresh rather then force.  Force seems to be the wrong meaning.


:+1: :shipit:


The integration server doesn't integrate, here's the build: https://www.dropbox.com/s/2tf95dj53k500ae/ctruLua.b4d025d.3dsx?dl=1


:-)   Got it!


short and sweet :+1:


Should this be from. ?


Hallo,
oh, ha, das sieht noch nicht sehr tragfähig aus! Übrigens: Showcase ist etwas anderes, als das, was Sie jetzt daraus zu machen versuchen!!! Hm, vielleicht doch eine Sprechstunde?


wiem ze tu tez brzydko:P


goddammit: http://www.imako.net/en/2-dental-sealer.html

but it can be done better


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8866](https://teamcity.mesosphere.io/viewLog.html?buildId=89650&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:10


Minor typo


Sorry about the misleading commit message, just pushing the report.tex stub


Does this help with torrent names that don't use "HDTV" or similar in the file name? I have to set the TV show quality to "custom" and to just grab any quality it can find, as the torrent files aren't usually specified.


Pour gérer correctement l'orientation, il a fallu créer un second fichier identique dans le dossier "layout-land" avec une propriété "orientation" différente.


Yes, it is like defer using gcc cleanup attribute.


Changed to asprintf.


Looks like this instance of `WeakInputIterator` got left in by accident.


Añadido botón para ver un cuestionario


doing this
```
	@../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringPool.class,\
	@../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringURLCodec.class,\
	@../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/StringUtil.class,\
	@../../../portal-service/portal-service.jar!/com/liferay/portal/kernel/util/Validator.class,\
```
allowed the module to not have external dependencies on these utilities. Therefore it could run outside of Liferay.


A++ commit message.


For instance "Strictly Come Dancing" has this.


nono, thank _you_ :bouquet:


@whipcracker i mean the full release name


yay!!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8867](https://teamcity.mesosphere.io/viewLog.html?buildId=89651&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 174 Build time: 00:03:31


Hopefully! :fearful:


This is -d  in Unix top

```
man top
...
       -d  :Delay-time interval as:  -d ss.t (secs.tenths)
            Specifies the delay between screen updates, and overrides the  corre‐
            sponding  value  in  one's personal configuration file or the startup
            default.  Later this can be changed with the `d' or  `s'  interactive
            commands.
```


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8865](https://teamcity.mesosphere.io/viewLog.html?buildId=89649&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:23


Use of `__import__` does not seem to be recommended by the Python documentation. Why isn't `importlib` used here?


Moved up the debug statement.


hello-world
this is test aaa


`mod_names` is not needed. Just use this for loop directly in the loop below.


@juannavascalvente , Can you check the current code is doing the same as before?
This array was newly created each time in the previous version.
I think now element are accumulated during the loop, I guess some kind of clean-up is needed.
Please double-check.


Help is wrong on interval.
Could you add containers last after options.


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - i386-Windows-7-VisualStudio-12: OK (1972 of 1983 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.45%25-yellow.svg)


Why is this name so generic? Shouldn't we use a more descriptive name for exception classes?


Assuming that you describe behaviour on your Features/Scenarios and that, Web APP is used by a human being and REST API is used by another computer program I wouldn't mix them. Probably sometimes some scenarios will be very similar but, as you have mentioned, Step Definition implementations are different.

An example not related with DHIS but helps to understand my rational

REST API
```
Feature: Fruit list
  In order to make a great smoothie
  I need some fruit.

  Scenario: List fruit
    Given the system knows about the following fruit:
      | name       | color  |
      | banana     | yellow |
      | strawberry | red    |
    When the client requests GET /fruits
    Then the response should be JSON:
      """
      [
        {"name": "banana", "color": "yellow"},
        {"name": "strawberry", "color": "red"}
      ]
      """
```

Web APP
```
Feature: Fruit list
  In order to make a great smoothie
  I need some fruit.

  Scenario: List fruit
    Given the system knows about the following fruit:
      | name       | color  |
      | banana     | yellow |
      | strawberry | red    |
    When I go to the home page homepage and click button list fruits
    Then the homepage should display a Fruit List with select option.
```


But you would expect from it to handle strings. Splitting is needed anyway in the function but it's definitely a little performance gain if you presplitted them.

And why I shall use `arguments_to_lists`? I don't want to turn a string into a single-itemized-list, I split it then internally since I need it.


No need for  epilog,  Just repeats what you just said.


DROP SCHEMA bookbrainz CASCADE;

doesn't remove types - therefore the entire script will fail when dropping and recreating the schema.


I think you forgot to add this domain, test/test_all_urls fails (it doesn't match http://video.pbs.org/viralplayer/2365173446/).


`BreakOut` is not accessible from outside, in fact it makes no real difference whether it's defined inside or outside the function^^
But if you want I could move it out^^


Need to handle -i and -o.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8868](https://teamcity.mesosphere.io/viewLog.html?buildId=89664&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:08


TeamCity pull requests :: netty [Build 817](https://garage.netty.io/teamcity/viewLog.html?buildId=3903&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6243, ignored: 21 Build time: 00:40:41


I would say this are additional fields to display.


I can update it if you want. We can either just duplicate the day icons, or better we simply suppress references to the night icons, like I had done here to produce a usable test build I can use productively: https://github.com/osmandapp/Osmand/commit/4e3f1600e67978b08acb3cff00000d8c5eb63f05


you sure? this is more or less a one-liner^^


I just did it as well ... It seems that lines are always added, so at one point it will be stopped. But it is much better than app crash before.

https://hosted.weblate.org/projects/osmand/main/tr/#history
History here somebody can contact him ?  Nesim İŞ


THIS IS NOTHING!!! ACHIEVE!


Why are we deleting these operations? They seem useful.


shouldn't we timer.suspend() here?
and don't we need to timer.resume() on startup to create the thread?


but my stuff below does not search only for end of comment but also ensures the each-line marker and alignments are handled correctly, using a function like `find_end_of_comment` is not really useful^^


It looks like NCrunch has a way to change the platform configuration so that it affects only test and nothing else: https://www.ncrunch.net/documentation/reference_project-configuration_use-cpu-architecture

I'd prefer not changing the build config for the main project as much as possible. Changing build config for the example project and/ or the test project is fine, however.


Did you mean to make this change? It's currently breaking me. Protobuf 3.0.0 beta1 is generating methodHandlers with the signature `func(srv interface{}, ctx context.Context, codec Codec, buf []byte) (interface{}, error)`

Not sure if I'm missing something but I can't find a more recent update to protobuf 3 than the beta 1


Supressing is bad, what if in future we want to update them again. Yes for now alignment is good.


Maybe I should consider using different markers:
`/**, \ *\ , \ */` instead of `/**, \ *, \ */`


Ah wait this doesn't make sense (already tried that), if you have an empty line like
```
/** main
 *
 * detail
 */
```


But I consider this. Problematic is then later to reassemble doccomments if you cleaned too much away^^


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8871](https://teamcity.mesosphere.io/viewLog.html?buildId=89675&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 (new) Build time: 00:00:20


This can just be `toSet()`


Moving forward should we just pass on the opts to WriterImpl?


offset and length will also be useful here.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8869](https://teamcity.mesosphere.io/viewLog.html?buildId=89673&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:18


Declare as `List`


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8870](https://teamcity.mesosphere.io/viewLog.html?buildId=89674&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:23


Voce pode comentar os commits :D :+1:


The check "window.WebSocket.CLOSING === 2" fails for windows phones with IE 11, although IE 11 fully supports rfc-6455. Is this not tested on windows phones?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8872](https://teamcity.mesosphere.io/viewLog.html?buildId=89676&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:14


imo you should make the "force" parameter optional to "generic_kick". If it isn't passed, use the hero kick default speed. On top of this, if force is passed as a scalar, multiply that from default.

In addition, I don't like how you add the z bump globally, it should be set per kick.

curveshot won't work (you pass it keys not keys.caster)


mal identado, solucionar


This can, and should, be removed totally.


I think here is fine. '<str>'.join(<array of string>) is frequently used and comes very handy.


bootstrap blablabla ???


VALID :+1:


Again, just because these operations are no longer needed doesn't mean we should take them out. What's the rationale?


Guten Abend! Dankeschön für Ihr Feedback. Wir sind morgen (wie fast immer) jeden Donnerstag bei Ihnen in der Sprechstunde. Bis morgen


delete commented code


Cool. I will pull back the config changes for non test projects


Si es una lista, no deberia tratarse como tal?


I think this is supposed to say `p : vector_like (n,)`?


This looks reasonable to me.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8874](https://teamcity.mesosphere.io/viewLog.html?buildId=89678&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Exit code 2 Build time: 00:00:20


implement Java standars


Actually, I'm in a weird inbetween state, protobuf3 is currently generating the following signature for my method handlers which doesn't match either of these: `func(srv interface{}, ctx context.Context, buf []byte) (interface{}, error)`.

Any ideas?


same as above per sean's comment


@jurrick : GoogleRoadManager is not working anymore:
parser.parse(is, handler); => raises an IOException.
Apparently, InputStream is is now an "okio.RealBufferedSource". I never used OkHttp, I imagine I have to dig inside now ... :-(


I tried to conjure up a test case for this violation however I found it hard. I am not an expert at operator completion, could you try to add one test for swift ide?


It's a pain to get NGCount.java to compile on the server when its all inside of the t1000 package. Can we do away with the package ?


wait.. what.. generic_kick asks for an abil keys argument. ugh. wierd system. ill let you do whatever, break, than fix it. just get map 100%


I assume the main issue was around locking during commit?


delete comented code


Karl Rieb,

2015-12-09 7:28 GMT+09:00 Karl Rieb < notifications@github.com > :
Hi @uramoty , nice to meet you too.

If you have an issue with one of the examples, please create an issue for it so
we can properly track it: https://github.com/dropbox/ dropbox-sdk-java/issues .

Thanks!

—
Reply to this email directly or view it on GitHub .


@GiantCrocodile don't worry. Indeed, I definitely like your idea. I will open up a dedicated issue for this.


this version of rest assured cause conflicts in the project.


Victor, I am wondering if "Live updates" is a good wording for what we are actually doing here? It may create false expectations ... "Live updates" sounds more like something you would have for traffic layers, etc.  Should we rename to something like "Daily map updates", or similar?


TeamCity pull requests :: netty [Build 816](https://garage.netty.io/teamcity/viewLog.html?buildId=3902&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6243, ignored: 21 Build time: 01:24:44


I committed the fix to this before I saw your pull request


ship it!


This patch seems to require adjustments in automated tests:
* https://github.com/ntop/nDPI/blob/dev/tests/result/KakaoTalk_talk.pcap.out
* https://github.com/ntop/nDPI/blob/dev/tests/result/quickplay.pcap.out


Don't wrap these


me parece aca te falta sumarle el id de la propia cuenta.


avoid commented code


its ok


What is the significance of `byte(2)`?  Any chance 2 could be moved to a named constant?


This is interesting. Is it a common pattern? It threw me off because I searched for `beginSearchFor()` and couldn't find anything. If this isn't anywhere else in the app, I'd prefer if we do:

`beginSearchFor("")` and `private func beginSearchFor(pattern: String) {`


Because I have no intuition about what '...' and '*' are supposed to be doing in this code, I'm finding it really hard to review. Would it be worth it to add a few comments here about what those parameters are supposed to do?


write a decorator *like* that


You forgot HTSLIB_LIBRARIES


move out! This function is freakingly too long, I will never acknowledge a function that long!


That will unfortunately not work. The version number is read with each section compared by its numerical value, rather than what an alphabetical sorting of the versions would do. This means people doing a `pip install pyrebase` will get version 0.3.33 as it's the one with the highest version number.


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-MacOS-10.9-clang: OK (1976 of 1977 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


it looks complicated, this function needs simplification, a well speaking name would be awesome


TeamCity Glyssen :: Glyssen-master Continuous [Build *.*.1117.4a4424f29b567e4452da464d523a97cb34589f99](http://build.palaso.org/viewLog.html?buildId=67140&buildTypeId=bt431) outcome was **FAILURE**
Summary: Execution timeout (new); tests passed: 503, ignored: 4 Build time: 00:35:44


Y que te parece hacer esta inicializacion mas abajo....justo antes de la linea donde le das uso, o sea la 99


you should try to divide up complexities a bit more, why do you handle alignments here? Why not use `inspect.cleandoc`?


It's forbidden to name an Oozie action `OUTPUT`.

To solve this problem, I could have introduced a mechanism that would map the names of the Oozie actions to consecutive integers (in fact, I applied this approach in [oozie2dot script in OpenAIRE IIS project](https://github.com/openaire/iis/tree/master/iis-core/src/main/scripts/oozie2dot)) and these integers would be used as technical identifiers of nodes inside of the dot file. As a result, the names of the nodes displayed in the image could be non-unique, as a consequence, we wouldn't have to reserve any words. This approach has 2 disadvantages:

- It's slightly more complicated.
- The generated dot file is much less readable because of all these integers as identifiers.


I can justify the usage, but given the direction from LWG I think it would better received if I submit an actual proposal on usage of the terse syntax variants and get some buy-in first.


Pasted the wrong link in, fixing.


Cool, I was thinking this evening of adding the flush interval and the Ubuntu repository handling.

Could you open a pull request?

I would like to merge your enhancments


@hawky-4s- that was your issue, right?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8875](https://teamcity.mesosphere.io/viewLog.html?buildId=89679&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:28


Nevermind, my bad. grpc plugin was out of date.


done


That great! :) Any objections or concerns before packaging that?


Massa!
E tem até emotion :dart:


@martint should review


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8879](https://teamcity.mesosphere.io/viewLog.html?buildId=89687&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Cannot start build runner Build time: 00:00:28


Conventions for default arguments are rather wooly right now. Since we call this two places, making it explicit is fine!


Having to do this kind of stuff obviously isn't ideal.  Not having to catch any Exceptions, per the code before this commit, is better.


7.2-linux here!


Put on previous line


A linter will tell you these aren't used.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8876](https://teamcity.mesosphere.io/viewLog.html?buildId=89684&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:11


Should be `if classTaskInstance is None:`


This may block kubelet when the channel is full, is this acceptable?


Same `==` vs `is`.


LGTM


Similarly here `mod_names` is not used as it is only constructing a list for a loop.


Not that I can tell, since the original app icons were merged the same way.
We should just go ahead and package it. I'll then update xfce profiles to use the now fitting whisker menu icon for Manjaro. If it needs adjustment, we can do it in between rc2 and launch.


Composite!!!
Manjador dos patterns :D


It will be renamed cause it will be more than live updates, though I don't want to create public discussion yet, cause can't formulate exactly the goal.


But wouldn't that leak an external subinterface on the global router?


Couldn't it just be in a `finally`?


I would say "`__new__` allows you to do class customization before initialization" since `__new__` returns an instance, not a new class.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8878](https://teamcity.mesosphere.io/viewLog.html?buildId=89686&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:58


This produces runtime exception about liveupdates.LiveUpdatesActivity not being declared in Manifest


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8877](https://teamcity.mesosphere.io/viewLog.html?buildId=89685&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:21


@GiantCrocodile see https://github.com/gi0baro/weppy/issues/77


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8880](https://teamcity.mesosphere.io/viewLog.html?buildId=89691&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:44


Yes I know... It is ok for today :)


What I meant is, you are assigning ri.router['*tenant_id*'] to a variable called router_id... I presume this should be called tenant_id instead?


Right so features in this case are very imperative and therefore implementation specific

From what i gathered there seem to be two camps, the _imperative_ and _declarative_ guys.

While i can see the benefit in the more _imperative_ examples you provide regarding implementation details. Those details could be in the steps or perhaps lower down in the integration/unit tests?

The _declarative_ style seems to still describe the same use case. While additionally being applicable to both API and Web. So we could share some features between both, while implementing them multiple times for different test cases.
I presume we could add some more imperative features for the more specific technical behavior.

Another reason why the declarative stuff feels attractive, our web in certain cases (increasingly so) gets ported to Android apps. Obviously their UX can be very different, but the more declarative scenarios might still apply, where the imperative would likely be platform specific.

I'm obviously not an expert on this stuff and have only been reading up on it recently, so perhaps you have some insights why this stuff above makes no sense :)


No, will remove.


I don't understand this return after the `sys.exit()`.


You copied the wrong checker.  You don't need a `g:syntastic_javascript_mixedindentlint_generic`.


You don't need an `IsAvailable()` function, either.


Do you have a phar I keep getting error says on hungergames main.php on line 208 there's a sytac errot


I would change "`__init__` is called after an instance is created" so as not to confuse class definitions and instances.


false => true


You can just not have this file in the CMake file


@camlow325 This seems OK too, I guess I don't have a strong preference between this one and the other one.  This one seems a little cleaner and easier to read, perhaps (sans the exception handling stuff).  Having a second lock to worry about creeps me out a little, but, that's probably FUD given how few places you're using it in.


A `returns` check would be nice.


just a few simple git commands... I would rather keep the project clean


Fixed


Yes, this has been a thorn in my hoof for a long time.  I think configuring
travis is the right way to go. Godeps provides better control over
dependency version, AFAIK.

On Wed, Dec 9, 2015 at 2:31 PM, Christian G. Warden <
notifications@github.com> wrote:

> I added 1.4 and 1.5 to .travis.yml in #221
> <https://github.com/heroku/force/pull/221>, but we're running into #150
> <https://github.com/heroku/force/issues/150>.
>
> Should we switch to the version of config in your repo with the build
> constraint added or configure travis to use the godeps vendored packages
> and fix it there?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/cwarden/force/commit/a21109d75ac1f31f8c1ee468c2885e2bbf7069bf#commitcomment-14886932>
> .
>

--
Thanks,
Dave


pr_pinfo should be syslogging at Debug level, otherwise LGTM


No, because we wouldn't want the `notWriteLocked.signalAll()` call to be done unless something bad happened during the `while` loop above.  If nothing bad happened, this signal wouldn't be fired until the caller invokes `unlock` later.


Might be github formatting, but we might need to indent this


Do I? Do you? ;)


Ditto .. can these be constants?


Should we really be exiting here? That bypasses lots of control logic. Should this be something like a `RuntimeError` exception instead?


Oh, no, wrong change. :sleeping:


niiice :wink:


This appears to be broken again in Websphere (I'm on 8.0.10), using 6.2 GA4.  With Context Path at "/", no services appear.  If any other available Context Path is selected in ../api/jsonws, it works.


Oh.  yuck.  In that case you may have done the signal but actually still be holding the write lock.  That seems real bad.


`checkNotNullOrEmpty`


The floor makes larger windmills more efficient


I would just call it mscorpe - there is nothing "host" about it. And maybe build it one level up.


Very cool. Sorry I missed this. I'll look at it shortly.

Any problems with locking up the event chain with large number of requests?


add it to npm scripts?


Right, only the new fstype "cgroup2" has made it to Linus' tree, but not the cgroup namespace code. I should have made a separate PR, sorry.

I think cgroupns is not specific to the unified hierarchy, but I don't know if it is worth implementing cgroupns support in nspawn for non-unified hierarchy hosts. I have not yet tested cgroupns on non-unified hierarchy.

I made it an option because of an incorrect reasoning: I want nspawn to support starting old containers before cgroupns existed. But I now realize that it does not make sense because cgroupns is transparent to the container. It's not like the option for unified hierarchy, which is not transparent.

I can remove the option, and handle the error in `unshare()` more gracefully.


Adding #ifdef around the `#include` instead may be better


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8881](https://teamcity.mesosphere.io/viewLog.html?buildId=89697&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:48


I'm sorry, I just don't know if you do boxit, @alexandruianu :)


Since this is just test code, can have the method propagate the exception rather than catch it.


What can I say, dota 2 modding is full of mystery and awe :dizzy_face:


@martin review this


sure!


@romanbsd thanks for the suggestion! We'll consider adding a check.
Please note that this file is here for backward compatibility. If you are not using the Blueimp plugin, you should use [cloudinary-jquery](https://github.com/cloudinary/pkg-cloudinary-jquery) or [cloudinary-core](https://github.com/cloudinary/pkg-cloudinary-core).


Now, this is a strange situation.  If you remove this line, our unit tests still pass; however, `composer drupal-scaffold` does not.  The error is:

```ERROR: Call to undefined function GuzzleHttp\choose_handler()
in /Users/ga/local/drupal-project/vendor/guzzlehttp/guzzle/src/HandlerStack.php:40```

The odd thing is that the Composer autoloader seems to have included all of the classes we need, but the files are not included at the same time.  To whit:
```
            "autoload": {
                "files": [
                    "src/functions_include.php"
                ],
                "psr-4": {
                    "GuzzleHttp\\": "src/"
                }
            },
```
The second, but not the first, are available. The classes seem to be available by some method other than the Composer autoloader.  Does this make any sense to anyone?


That's correct.  WsECL will use the alias if loadBalanced = true because the alias is used to reference corresponding targets on any of several clusters behind a load balancer.


ah yeah, good point.  Suppose we could work around this by doing an `writeLock.unlock()` call before the `notWriteLocked.signalAll` call and then set some state or something to avoid doing the second `writeLock.unlock()` call in the outer try/catch block.

Yeah, this whole approach is seeming worse to me overall the more I think about it.  Managing more than one lock just seems to be asking for trouble.


Note that because of this line, you guys all need to build the latest git, as set_hidden() is a function that was merged in master yesterday :p


Can't we do separable convolution here?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8882](https://teamcity.mesosphere.io/viewLog.html?buildId=89705&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


I would implement `visitCall` and `visitArgument` in the analyzer.  Then you would acquire all types for the expressions in a single shot.


Branch for premium should be merged with others: Standard, Select and Certified, given they have the exact same behavior.


Is `mk` for "map.keys"? If the keys are classes then maybe `cls` would be a better variable name?


Can't use `goto` in Java, too, right?  :smile_cat:


it's not only publishing this project, but also move generated codes to example sites...


Here's a line comment


Here's a commit comment


Superseded by develop branch.


Pour éviter le blocage de l'UI, on utilise un Thread et un Handler. Source : Cours 2


That's right, I don't allow you to "redefine" an existing target name as something else.  If you use a target name it should go to that target.

I don't think I need 'break', I need to keep processing all alias names (ignoring any that are already target names).


Useful how? They provide no more information than `==` and `!=`.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8883](https://teamcity.mesosphere.io/viewLog.html?buildId=89712&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 205 Build time: 00:04:07
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


Call `TypeRegistry.canCoerce`


Why was this file added when an equivalent already exists?
https://github.com/jhu-saw/sawConstraintController/blob/devel/cmake/sawConstraintControllerConfig.cmake.in


We can initialize this with expected entries.


@Fishrock123 Sorry, I will keep it mind


I don't think there will be any meaningful performance difference between the 3 options, so we should choose based on which yields the cleanest, simplest, and most understandable code. Either way you are juggling 2 blocking resources (mutex or channel), so you need to be careful to avoid deadlock.

I'd like to think of status.Manager as 2 separate components (preferable actually separate them later): the local interface (status.Manager, status cache, etc.) and the "syncer", which works to ensure that the api server status matches the local status. `ReconcilePodStatus` doesn't change the local status at all, it just effects the api server, so I think it belongs in the "syncer" component. By this model, I would vote that (3) is the best option.


```Build failed
```


@cprice404 I'm leaning toward going back to the one lock approach.  Feels like it would better protect us from inadvertently doing something work in the future - like I did with the try/catch Exception blocks in this commit.  I can definitely work on renaming things to make the code more readable in the process - open to further suggestions as you have them.


nice! I was wondering where the explosions were!


Vendoring dependencies is probably the better solution, but the right way to do it seems to be in flux.  Go 1.5  introduces a [vendor experiment](https://docs.google.com/document/d/1Bz5-UB7g2uPBdOx-rw5t9MxJwkfpx90cqG9AFL0JAYo/edit), which adds support for vendored packages without rewriting the import paths or setting a special GOPATH (by using `godep go ...`, for example).

I got #221 to build on 1.3, 1.4, and 1.5 by using your fork of the `config` package and removing unused packages from `.travis.yml`, one of which failing because of the [canonical import](https://golang.org/doc/go1.4#canonicalimports) support added in 1.4.


TeamCity LabKey :: LabkeyRelease15.3 :: Git postgres 9.4 [Build 105](https://teamcity.labkey.org/viewLog.html?buildId=290619&buildTypeId=LabkeyRelease153_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 27 (3 new), passed: 260 Build time: 01:27:55
### Failed tests
```
org.labkey.test.tests.CDSTest.testLearnAboutStudyProductsSearch: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSMeasureStoreTest: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.tests.CDSSecurityTest: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyBoxPlots: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

##### there are 17 more failed tests, see build details
```


I think, you may restore it. Just change `jx install babel` to `jx install babel-cli`.

I did that on the blog post already.


budget; demand; aggregate_demand; derived_demand; elastic_demand; potential_demand; reproduction; decreasing_reproduction; expanded_reproduction; simple_reproduction.


Was the info printout getting in the way?


Just making sure you intended for these commits to go in kevin's branch rather than in master


I don't think these lines would disrupt anything in their previous state, would they?


Ok, now I see. Stupid question :D
It's confusing with all those different user name identities here sometimes... ;)


have you tested the 2 search sqf's as a fix? i tried this early on in my attempts at bug fixing but it did not seem to fix it for me?


I think I would have expected the order here to be e,u,p. Is that a lot harder? Seems like the pre-postTask shouldn't happen if the main task errors out.


Ok this produces a bunch of errors, I'll clean them up

```
psql -U skmehta -f test/test.sql | grep ERROR
psql:sql_scripts/initialize.sql:3: ERROR:  invalid input syntax for type double precision: "null"
CONTEXT:  COPY users, line 2, column avg_rating: "null"
psql:sql_scripts/initialize.sql:4: ERROR:  insert or update on table "cars" violates foreign key constraint "cars_userid_fkey"
DETAIL:  Key (userid)=(2) is not present in table "users".
psql:sql_scripts/initialize.sql:5: ERROR:  insert or update on table "creditcards" violates foreign key constraint "creditcards_userid_fkey"
DETAIL:  Key (userid)=(7) is not present in table "users".
psql:sql_scripts/initialize.sql:6: ERROR:  insert or update on table "trips" violates foreign key constraint "trips_driverid_fkey"
DETAIL:  Key (driverid)=(2) is not present in table "users".
psql:sql_scripts/initialize.sql:7: ERROR:  insert or update on table "ratings" violates foreign key constraint "ratings_userid_fkey"
DETAIL:  Key (userid)=(2) is not present in table "users".
psql:test/trigger_tests.sql:10: ERROR:  insert or update on table "trips" violates foreign key constraint "trips_driverid_fkey"
DETAIL:  Key (driverid)=(4) is not present in table "users".
psql:sql_scripts/simple_queries.sql:66: ERROR:  insert or update on table "trips" violates foreign key constraint "trips_credit_cardid_fkey"
DETAIL:  Key (credit_cardid)=(7) is not present in table "creditcards".
psql:sql_scripts/simple_queries.sql:74: ERROR:  insert or update on table "creditcards" violates foreign key constraint "creditcards_userid_fkey"
DETAIL:  Key (userid)=(10) is not present in table "users".
```


que pasa si se cambia el icono por otro?


![The future!](http://www.quickmeme.com/img/32/329861e5c9413e00219b686deacef1bedfb690d107924072df2bd3ac9e1a5492.jpg)


AFAICT this isn't calculating a cross product (which would be a vector in the same vector space again) but the oriented volume of the parallelogram spanned by vectors (v2 - v1) and (v3 -  v2). Thus, the comment and the actual naming seems confusing to me.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8884](https://teamcity.mesosphere.io/viewLog.html?buildId=89723&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:43


Leave this to 1.7 (I want to keep kobalt 1.7 as long as possible).


Espacio de sobra


Any reason to delete this file?


composite <3


You're correct...


@lmineiro its etcd the only provider or do you plan on adding extra ones (based on fact its just using the k/v side of it) ? :smile:


No, no I did not. But I already caught and corrected :)


I didn't have the chance to test it.


Done: e7eb3d3


Ah yes -- good call. The name was a copy-paste from the original ASR1k implementation. Will fix in the updated patchset.


Pode comentar as linhas tambem! o.O


It's good to know that our write concern at the app level is 1.  Our mongo config uses the default of 2.
@feanil @e0d


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8885](https://teamcity.mesosphere.io/viewLog.html?buildId=89734&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:18


```

BUILD FAILED
/var/lib/jenkins/jobs/test-job/sfdc-dev-tools/build.xml:18: Problem: failed to create task or type antlib:com.salesforce:deploy
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.
No types or tasks have been defined in this namespace yet

This appears to be an antlib declaration.
Action: Check that the implementing library exists in one of:
        -/usr/share/ant/lib
        -/var/lib/jenkins/.ant/lib
        -a directory added on the command line with the -lib argument

Total time: 0 seconds

```


Another good question. I have a call with the cisco router team on Friday, and will ask them how this is supposed to work.


Patch proposal related to https://github.com/elastic/beats-dashboards/issues/49


Was there a reason for changing the label here?


Rather than `errors.New("Wrong block for sequence")`, what about `fmt.Errorf("Wrong block for sequence: %d vbNo: %d", sequence, vbNo)`


This is great, thanks a lot Przemek! I'll start testing it in the coming weeks.


Did you revert your early commit or is this something else?  The commit message is not clear.


Tests now pass

```
$  psql -U skmehta -f test/test.sql | grep ERROR
$
```


no-extra-semi: Unnecessary semicolon.


no-unreachable: Found unexpected statement after a return.


semi-spacing: Missing whitespace after semicolon.


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 98](https://teamcity.labkey.org/viewLog.html?buildId=290636&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:39


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 98](https://teamcity.labkey.org/viewLog.html?buildId=290636&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:40


cool


So what happens now for this graph?

```
# perFrame1
# |
# TaskList
# |
# perFrame2
```


@gottesmm Why are you adding this?  The c-style for loops is not going away in c++.


@gottesmm Please document this enum.


Esto no se comitea.


Esto no se comitea


esta mal el commit.


Mal identado


`unicode` isn't defined in python 3 anymore. There `str` is always unicode.
What about defining a python-agnostic alias?


Haha! Yep!


How do you share the scripts with other collaborators?


<figure>
    <a>
        <img>


Maybe add a comment here about null is returned if we can't detect an encoding?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8886](https://teamcity.mesosphere.io/viewLog.html?buildId=89736&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:05


Yup, will do.


This shouldn't be changed to unicode. The except branch is for python 3 where `basestring` and `unicode` are not defined anymore, but `str` is always unicode. `_basestr` was used for string checks, i.e. isinstance(..., _basestr).


Should this be wrapped in a ConsoleEncoding?


Oops, yes! Thanks.


its ok


I found this the hard way :stuck_out_tongue_winking_eye:


ack, I didn't realize that; thanks for pointing it out! How would a python-agnostic alias work? Does that mean using something like `xacro_str` (or whatever) everywhere, that we assign differently depending on the Python version (i.e., to `unicode` or to `str`) ?


https://github.com/fabiancrtv/Landingpage/commit/60e7c3a758c3e386c345180cb2ca4fe877b3fd93#diff-eacf331f0ffc35d4b482f1d15a887d3bR17

El id se repite!


Mala identacion


Thanks for the change Amanda.
This must be a merge issue. We do want to check for bin rather than LICENSE.txt.


These lines should have been included. I can add them to the file in the cmake folder instead, I didn't see that there was an equivalent file added there. This would require a change in the CMakeLists as well to point to a new location. I'll commit these shortly.


Is this a test showing that something is slow? Isn't that just going to make running the tests slow?


If you're trying to "learn" why remove this imagine?


EL h2 esta mal identado


Yes -- there's actually a bug here that I meant to come back to.  The plotting of labeled data seems to force-set the tick_label to '0'.


No.


That makes more sense - thanks :)


Este merge esta mal hecho.


Po velho não era pra ter tirado meus comentários... Vacilão...


Merge mal hecho


I was under the impression that this was just for debugging. If it's important for your build you can add it back, I just didn't see much of a need to print all of this.


:)

the real difference is that it now forces a major collection


Because it belongs to BrokenROM.

On Wed, Dec 9, 2015, 3:47 PM Alex Cruz <notifications@github.com> wrote:

> If you're trying to "learn" why remove this imagine?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/TestROM/platform_manifest/commit/0bf6d330d443ff83acb42605f29fa41c98b27991#commitcomment-14888291>
> .
>


The package is called testgroup now.


Haha, thanks! I wasn't entirely sure what that did, but it was present in several other checkers. I'll take it out.


Mala identacion, se repite en todos los img


I have no problem deleting the damn project in whole, I honestly wanted to learn by watching my favorite ROM evolve.


Oh I see! Ok I get it now, I see how I broke the versioning by jumping up to 33, I thought you were joking saying it was a leap!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8887](https://teamcity.mesosphere.io/viewLog.html?buildId=89740&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:20


Agregar a hoja externa


Não entendi o por que disso acontecer. Se por exemplo, (for X in Y:), acredito que (if X in Y:) é sempre verdadeiro.


figure
   a
     img


No
a
figure
img


Nit: Shouldn't this be `False` instead of `None`, since `FEATURES` entries are always booleans, and you're treating it as a boolean on the next line?


@Manoj-nathwani Looks like a merge thingy. It's just the styles I added for the button. Seems fine.


Wonder why it's coming up under my commit then, seeing as you did it :/


O que estava acontecendo? Tava vindo mais itens do que tinha na array?


address no adress


THrough the clients NPC has been nerfed several times.

Wowhead has most current data (WOD) so it would prob show lower health then normal but wowwiki is not anywhere near as up to date.


Also, some cleaning and some comments


.map возвращает массив значений, полученных выполнением коллбека на значениях исходного массива, т.о.
можно просто написать
var promises = dependecies.map(function(dep) {
 return new Promise(function(res, rej) {
    var xhr = ...
  })
})


No, these lines actually look fine if I left them as they were.


Should INTERFACE be initialized here for completeness ?


I see what's going on -- saying `tick_label='a'` when `data` is passed means that `'a'` is replaced with `data['a']`, which in this case is 0.  So the only way to get the two figures in this test to look the same is to forcibly set it to `0` (or anything that isn't a column in `data`).

Strange quirk of the labeled data stuff?  Yes.  A bug?  Not really.  Best to just keep the test working like this and we can clean up that dark corner as a separate PR.


Would be nice if lineNumber was optional and did not append `line %lu` everytime to the image name. Maybe passing `-1` or using NSNumber and checking for nil.


You both have access to boxit. It depends who will update the PKGBUILD ...


I like this! Our first step towards broadening the horizon of TRAPpy! The good part is that these custom events can be accessed in the plotter and grammar API. There are some changes required for that. But this one can be merged as it is. :+1:


spelling for availability and continue, if you are touching this file.


если все модули объявлять как
define([], function() {
})
то дополнительно оборачивать ничего не надо + из коробки вложенные зависимости


I wanna suck your cock @myo


[![Portrait of Dr. Hannibal Hamlin Kimball](http://api.artsmia.org/images/1642/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=1642)


[![Coat-of-Arms with a Skull](http://api.artsmia.org/images/47058/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=47058)


[![Il vero modo et ordine per dissegnar tutte le parti et membra del corpo humano.](http://api.artsmia.org/images/115331/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115331)


[![Scuola perfetta per imparare a disegnare](http://api.artsmia.org/images/115360/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=115360)


[![Livre de Portraiture](http://api.artsmia.org/images/116227/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=116227)


[![Studi di Pittura giÃ  dissegnati da Giambatista Piazzetta ed ora con l'intaglio di Marco Pitteri](http://api.artsmia.org/images/120598/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=120598)


[![On Compasses and Straightedges, also simplified perspective and proportions of humans and horses...](http://api.artsmia.org/images/122958/300/small.jpg)](http://collections.artsmia.org/?page=simple&id=122958)


Donde estan los li?


@wido can you move initialization into the constructor?


Вообще, если еще не надоело задание, можно оптимизировать загрузку модулей, например:
если модуль А зависит от модулей Б и В, и модуль В зависит от Б, то при текущем коде, файл с модулем Б будет загружен дважды, в чем нет необходимости


I was thinking about it as comments handling would require matcher to hand on printer.

In fact it makes more sense to make this "formatter" as printXXX functions' receiver, what do you think? One downside is that "formatter" methods have to be distributed in multiple files due to 300-line limit.


Simplify
```java
PlanNode source = partial.getNode();
if (exchanger != null) {
    source = exchanger.apply(source);
}


@wido same here


About fucking time........


Done. :)


Identar bien.


Me parece que no esta muy bien identado


no-unreachable: Found unexpected statement after a return.


semi-spacing: Missing whitespace after semicolon.


no-extra-semi: Unnecessary semicolon.


Commit message grammar: "is a subset"


fast-forwarding 2.1 to borshop-integration-1275-ku/merge-2.0 = 1a1a56f5


After some investigate work, I find the way call through native to java go to onReceivedIcon, and I don't know what the overriden one does.


@tchaikov . if pg delete, it can't call on_change. So for this case we should free related source.  The later case, on_change can handle.


Is the placement of opening/closing parens here on different lines enforced by the styleguide?

Just my opinion, but this pattern is like doing this kind of weirdness with curlies:

```js
if (options.process) {
  this.process = options.process;} // what
util.inherits(Worker, EventEmitter);
```

IMO better to match the style of `}` on its own line when closing of a multi-line block, by closing a multi-line expression with `)` on its own line:

```js
this.process.on('error', (code, signal) =>
  this.emit('error', code, signal)
);
```

or just use single line if it fits:

```js
this.process.on('error', (code, signal) => this.emit('error', code, signal));
```

IMO. Perhaps @trevnorris disagrees.


dfg


@liewegas , please look at https://github.com/XinzeChi/ceph/commit/26475eff9094f01552589f87ee7fe209480dab50. This patch could support big-endian.


TeamCity pull requests :: netty [Build 808](https://garage.netty.io/teamcity/viewLog.html?buildId=3878&buildTypeId=pulls_netty&guest=1) is now running


@J-Sarnoff , Fixed it : 457dd34.
Feel free to email or open a new [Pull Request](https://github.com/svaksha/Julia.jl/pulls) (PR) when you are ready. And of course, thanks for writing it :)


develop (Myoldmopar) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1446 of 1446 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.52%25-green.svg)


Nitpick: should this be a YAML array?


Weird extra newline here.


Let's fold this into the body of the blockquote: `Warning: **This document`...


Hm, in the GitHub rendering this might be nicer as a real title.


The second change here seems unrelated to the headers?
Also doesn't seem like it would make a difference beyond adding an allocation?


Test Pull.


@spalger It looks like that one. Lucky 2 not 7. :smile_cat:


Why did you leave the empty comments in?


```
/**
 * It's an internal legacy class which is to handle kinds of ui related
 * callback functions. It only handles those which are not exposed to
 * external users compared to XWalkUIClientInternal.
 *
 * @hide
 */
public class XWalkWebChromeClient {
```
But `onReceivedIcon` have exposed to XWalkUIClientInternal.


Another special blockquote that can probably just be `> Note: Possible implementations`...


Haha :)


Commit by bash 12/08/15


Here the original does *not* make this a link. I don't think it really needs one.


Can you expand on why you think the "." should be specified automatically rather than by the user? It seems the way it is provides more flexibility (i.e. the separator can be anything without the need for an extra property).


Que significa ortografia brian ?, algo curioso que veo con este tipo de archivos es que al ser como binarios no los muestra todos.


Yes, I've read this. But after check with hengzhi, he said this class is also on use.  So if we could ensure this onReceivedIcon is not need, is is suitable for me to delete it in my PR?


watchNamespaces() will ignore existing namespaces and only starts watching for new namespace creation. So we don't expect NetNamespace objects to be present for the new namespaces.


this will be next version x3


[This comment](http://stackoverflow.com/questions/32374483/android-databinding-where-to-get-context#comment56066207_32385583) was useful for this.


Do you really have to uninstall it? Did you try without? Asking BC I think
that might only be a problem when provisioning ...

In any case, yes, vagrant plugins are clearly not really well designed.
From our vagrant file we can nether require nor disable vagrant plugins for
that instance - it's really stupid.

I think I saw a switch for that disabled the check for this particular
plugin though, if that trouble continues, let me know and I'll research
that again...
On 9 Dec 2015 09:33, "Ethan Miller" <notifications@github.com> wrote:

> @ligthyear <https://github.com/ligthyear> is there maybe a way to prevent
> this plugin from running on this particular vagrant instance? it's funny,
> my work repo requires this plugin, so i have to uninstall it for beavy and
> then reinstall when i do work. it seems strange that vagrant runs all
> plugins on all instances, no?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/beavyHQ/beavy/commit/1888ce78dcd08f7463c11bb1afec733a5282dbc4#commitcomment-14863953>
> .
>


Its not even remotely done and I am fried for the night.


@jhawkzz looks good. Only thing I'd mention is that when you make the commit, can you prefix the comment with a + or -, and make it just a short description of what was changed. Reason for this, is that when we package updates, these are automatically added to the Readme.txt file (those that begin with the '+'). For example:

+ Added new REST endpoint for getting known relationships.


No problem, I was just trying to get my build to complete and found some extra "+" tags.


fair enough, this has been a feature I've wanted for a while, so I can wait a few days more (and anything we can do to make @riskable's builds better is a definite plus)


- Whisper NPC rolls option added to Config page
- added weapon property/key for "Type" to pf_attack roll template
- removed the default "checked" state from armor and shields
- added PC whisper option to config tab.
- added level, range to NPC spell-like abilities and spells and added to macro text.
- added {{subtitle}} into sheet macros.
- removed readonly from buff checkboxes and re-numbered rows.
- reduced size of clickable area for attack repeating item show/hide (was overlapping button roll).
- added option to hide Attention text at the top of the sheet.


Yea he makes some pretty impressive stuff.


這個檔案是我故意拿掉的… 因為用不到
還是 safari 上會需要？


Looks good except I can't really tell which part of the code is new.. but it seems to do what it supposed to do.. I assume the actual pausing and rewriting RAM happens in the FSM module


looks like you misspelled 'canola'


That will most likely not be the right check. :-/ I think it's "is the current function in the same resilience domain as the superclass?".


@oscar-broman How about this?


we need this for the AIMS database (their official one, with login and password).


順帶一提，Jekyll 可以寫 CoffeeScript 唷


shondaboyer.com


太多 Fix typo 了，我晚點來 Rebase


There are a lot of these. Do the same?


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-MacOS-10.9-clang: OK (1976 of 1976 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Ah, yeah. I figured we'll be setting conventions to apply in future docs as we work through these first few.


tooty :100:


给定一个数x，求出某个数，这个数的三次方的末几位也为x
举例：输入为123，输出为947，因为9473=849278123，末尾刚好是以123结尾

思路：
取模公式：`(a^3) % m = (((a * a) % m) * a) % m`


Yep, you're right. Changed the communications specs.


Bump version :+1:


I don't see the relevant change here for the PIOS_BOOTLOADER_DELAY, was it missing from this branch?


然後等 Safari 支援就可以用這個了，雖然我從 iOS 8 等到現在…
https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API


Did you mean to put this in .gitignore?


The original intent of this separation was that XYZ should be rendered directly into the *target* space (e.g. the screen space or LUT space), rather than into any sort of source space (which doesn't really make sense for XYZ input either way).

I wonder why that wasn't the case in the version of the code before this commit, I thought that's the way it worked in the past.

Either way, since they're all just linearly related, it should be equivalent to this current behaviour assuming we don't clamp in between colorspace conversion and screenspace conversion, which unfortunately we do. But I'm not sure if this is an issue in practice, since XYZ files neither exist nor do we have any good knowledge about them.


Is this seconds? @tracernz?


Isn't it the "closest class with a non-final implementation?" The immediate superclass that happens to be in your module may not have the implementation.


milliseconds


operator precedence bug here? `A/B*B` is just A (give or take integer division rounding). I suspect you meant to square the city size before dividing so that city size greater than 4 would reduce the number of cities on an overmap. This is one of two bugs(?) that are responsible for the "megacity" situation at city size 16. I'm addressing this in a bigger PR related to city spacing, but wanted to poke you here for feedback in context of this change in case I've misunderstood your intentions.


Sorry, I was just referring to "devirtualizing" the superclass access, not devirtualizing all the way down to static dispatch of the call. Yes, that one requires that the method being called be in the same resilience domain as the call.


That's right you helped a lot: )
On Dec 8, 2015 8:12 AM, "Exerosis" <notifications@github.com> wrote:

> Hey... x) Don't I get some credit there hahah JK
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/BlockServerProject/BlockServer/commit/3e27d1981161ac8891f92eee2bff1a5a596c39bb#commitcomment-14847998>
> .
>


Tomcat does that. In tomcat's setting, if set `jvmRoute="node01"`, then you will get the cookie name `abc123.node01`(see #256).
If design this as an extra suffix, maybe a new name should be used to avoid confusion.


Ah! Yes, that totally makes sense. So really we are saying that there are two different optimization opportunities, then?


添加栏目与内容实体


@TaskeHAMANO

https://github.com/togostanza/togostanza/blob/sparql-hbs/environment_attributes_stanza/sparql/query.hbs
こんな感じで変数を埋め込んで使うイメージでした(hbs の例ですが)

たしかに、SPARQL を使われる方には、rq 以外は違和感ありますよね。
しばらく手いっぱいで、すぐには対応できませんが、検討させて頂きます :bow:


技术博客


使われてたらインポートがいいなあ(´・ω・`)


修改


LocalTime LocalDateTimeなんてやつもいるよね((o(´∀｀)o))


確かにー！！


That is a good point. I created #326 to address this. Thanks for bring this up!


I try
Олександр Абдуллін
Член фракції Фракція політичної партії "Всеукраїнське об'єднання "Батьківщина" у Верховній Раді України обрано від партії Фракція політичної партії "Всеукраїнське об'єднання "Батьківщина" у Верховній Раді України
 here is taken from member Фракція  is your code?
remove (Фракція), because again we have a tautology (
у Верховній Раді України too we have a tautology, since repeated twice
and it is not necessary, so much  it is clear who they Deputies.

Please help for me  Find exactly where in the code are added to these lines
'у Верховній Раді України' and  'Фракція'
Tank You!


Could you fix the spelling of `Don't` currently shows as `Doin't`


hmm, start and end are unsinged, this part maybe wrong... (the b->end-- above)


TeamCity pull requests :: netty [Build 808](https://garage.netty.io/teamcity/viewLog.html?buildId=3878&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6231, ignored: 21 Build time: 00:41:28


Here's the other spot where I think there's a bug. The old code had city sizes of 3d4, or 3-12 (avg 7.5). This new code has city sizes of 3d5 (3-15, avg 9) for CITY_SIZE==4, and city sizes of 7d9 (7-63, avg 35 !!) for CITY_SIZE==8. This is the other issue responsible for megacities at high city size settings. This behavior also means "village" and "city" are both smaller than "town" in the newer three-sizes system.


The name of the method seems a bit unclear.
find what?
what is `rowIndex`?

I think only the `TableView` have this method.


Please kindly help to review and merge it. Thx!


@reidmv what version does this work with.  Seems like a 3.7+ thing.


what i write is just for a test.


All the options look acceptable to me, though I guess you're right that the negate does look a little strange. I don't have any strong preference here, so I'll leave it to your discretion :)


Also the `require 'pathname'` still needed?


>Please help for me Find exactly where in the code are added to these lines
>'у Верховній Раді України' and 'Фракція'
>Tank You!

@beastie87 both those come from the source data. Here's a list of every faction name we have in [the data](https://morph.io/openaustralia/ukraine_verkhovna_rada_deputies):

```
Фракція політичної партії "Всеукраїнське об'єднання "Батьківщина" у Верховній Раді України
Фракція ПАРТІЇ "БЛОК ПЕТРА ПОРОШЕНКА"
Фракція Політичної партії "НАРОДНИЙ ФРОНТ"
Фракція Радикальної партії Олега Ляшка
Фракція Політичної партії "Об'єднання "САМОПОМІЧ"
Фракція Політичної партії "Опозиційний блок" у Верховній Раді України восьмого скликання
Група "Економічний розвиток"
Група "Воля народу"
Група "Відродження"
Група "Партія "Відродження"
```
(You can see this with this morph.io query: `https://api.morph.io/openaustralia/ukraine_verkhovna_rada_deputies/data.json?key=[YOUR_KEY]&query=select%20distinct%28faction%29%20from%20%27data%27`)

Would it be better if we removed 'у Верховній Раді України' and 'Фракція' from the source data?


TeamCity pull requests :: netty [Build 809](https://garage.netty.io/teamcity/viewLog.html?buildId=3879&buildTypeId=pulls_netty&guest=1) is now running


If we shouldn't remove it from the source data we can add a helper, something like:

```ruby
def ukrainian_display_name(party)
  party.gsub("у Верховній Раді України", "").gsub("Фракція", "")
end
```

That way there's less logic in the view.


hmm, I feel a little uncomfortable you change this in PHP-7.0 , it's a bc break (in strict_types) , that's why it was not fixed at the first time(prefer doc bug)


@sfentress, could you review this when you get a chance? I should have created pull request, but it seems be pretty straightforward and I wanted to merge that into staging ASAP (so we can release this change soon, as it's going to be used by HAS space model).


Do we need to throw this error?

Can it be displayed in the OutputView above the status-bar instead?


TeamCity pull requests :: netty [Build 810](https://garage.netty.io/teamcity/viewLog.html?buildId=3880&buildTypeId=pulls_netty&guest=1) is now running


I tried pushing these with my original sprint artifacts, however I was having issues uploading images.  This is a basic run down of the MVC diagram and the procedures of the Python script that I outlined to help everyone understand how data is moving around and the way that their piece fits into the application itself.


Ah.  Are we seeing these?  I can't even run `samtools faidx` on an empty file, it segfaults!


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (1982 of 1982 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


English name is "Jordan" ;)


I get your concern it changed parameter type , but before the fix the code couldn't even work in strict mode, it seems didn't break exist code. in weak mode it didn't change the behavior.


Also fixed the issue where it would FORMATERROR when playing a double down.


Is this method complete?  How do the values from the old HashNode get copied to the new HashNode?


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg)


Yes. Do we need it? I was thinking it is added by mistake.


merge


这。。。。版本工具记录的也真是详细啊，空格都能给标出来。


but you break the common used :
````
$data->diff($data2, 1));
````

please do not commit bc break without a asking, I've revert your commit.

please drop a mail to internal and cc to the maintainer if you insist to do this.

thanks


@ChrisGuzman shouldn't this be > 0 ?


Your change is fine. Yes, the issue is latent because we have been wrong for a period of time. getStorageClass() just fetches the wrong field of OpTypeInt and OpTypeFloat and it treats the value as storage class, which should appears in OpTypePointer. I will drop my change then. Thank you for looking into this issue.


For typos in pushed commits messages (like jeystream, above), would you leave them/it alone until it's time to rebase?


OK. Thanks ~

Personally I think it is a bug, but it breaks. master seems better.


Notifications seemed to be handled by the calling code in other cases, so I was trying to stick to that convention.

If the user's gitconfig file is malformed you can get an error like `fatal: bad config file line 2 in /home/brettle/.gitconfig`.


@sospartan +1


LGTM.

At first I wondered if this would have a larger impact that should be tested, but since both are combined in ```topicsIneligibleForDeletion``` and that is the only place its used there should be no real impact. Just better names.


Originally I had - ```for (;tickets_dispensed < tickets_requested;)``` but honestly for something like this I have no idea if there is a benefit or difference to either as every endpoint in the loop results in a complete reset. The way it's written now, booth loops never actually end before one of it's sub functions resets the whole system. In this scenario, do you know if one is better or preferred over the other?

I agree to move the dispensing out - I just need a good day to figure out the intricacies of it... I had some weird results with my first attempt... I'd also like to move the input counter but that one was giving me problems as well.


That is me


`is not filled` or `was not filled`


This is also me.


How do you go to the 3.6 optional codeset?


Move the respective files from there onto your SD card, overwriting the 3.61 files.


Yup! Good call. Thanks


yeah, it breaks in the case what you are trying to fix. thanks


This is cool Matthew! Thank you for merging my pull request


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-MacOS-10.9-clang: OK (1976 of 1976 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


Guys, please don't copy code around like that, use git merge. There is an error here, which looses part of optimization.


Oh what I meant here about the convention is based on the observation of the code in l3_apic.py. Over there they always call/define postcommit() after adding or updating stuff in DB and then precommit() before deleting stuff in DB. For example as you can see there, they never define/call postcommit() while deleting stuff in DB....


Sorry, I tried merge but there became conflicts that I didn't know how to resolve. I'll try to enhance my git skills.


should be fixed in https://github.com/php/php-src/commit/245a8c3cdf7ea0654667c1470a742a7354a0c147


So risky it breaks all the tests!  I've effectively done what you suggested in a roundabout way subsequent to this commit, will change as per your suggestion.


I'm sorry, I forgot about the database. Thanks for the detailed explanation! I'm going to sleep and then continue.


Test case update


This broke this selector. no space! :P


Probably gets handled by the pool now.


Missed them in the diff. I added another commit.


Right, that was leftover from debugging. I reverted in a new commit.


One last question for today and when you can update the code on the server to make the new deployt?


Good point. I think this is an exception where we should complain gracefully to the user. We can use the notifications to display an error message like that


Actually, I'm not sure why it's necessary to add this restriction.
Linux makes no restriction that the IP alias must belong to any specific subnet.
If a driver needs it because of a specific network semantic, it's fine but in my mind the core library should not restrict what linux allows.

IP aliases have many different roles, and using it as a virtual ip, for example:
  -  floating ip across HA cluster members using keepalived, which means that the IP is provisioned on only one container at a time.
  - VIP provisioned on pool members to allow the src IP to be be the VIP in direct client responses.
  - anycast DNS where the real IP is used for accessing instances and VIP to access the service.

Only in the first case I've seen using an IP on the same subnet/L2. All other cases are using different subnets, sometimes even not routable to the instance (e.g. in direct response case).

I don't think it's necessary to have the notion of VIP if the restriction on subnet is lifted. IP and IPAliases are sufficient.

The full commit is here, with the osl part : https://github.com/jc-m/libnetwork/commit/2010a0ea928a1ff7577d226dcb9fbbf22881ac2c

I've tested it with the following plugin https://github.com/jc-m/test-docker-plugin
and it does work (you need proxy arp configured on docker-machine)


Edit


Accidental commit message, make header private


Shouldn't this be `appName`, not `"Apple"`?


so we can't just use atenant_id we retrieved earlier?


Should this be `createDefaultApplicationMenu` or `createDefaultAppMenu`?


@yujuhong `existing` here is a pointer to `api.Pod`. IIUC, `config` always keeps the same `api.Pod` and updates it. However, because we always use `api.Pod` as pointer, this value is passed all the way to `SyncPod()`. If so,
* The pod status was never updated before this PR, we can't use `OldStatus` in `SyncPod()`
* Is there any chance that the pod by config again, during the process?

Or maybe there is a copy anywhere, I haven't noticed. :)


Oops, my local config slipped in!


This `.run` right here makes me sad.  We might be able to proxy a `BlazeClientStage` if the startup and shutdown operations were asynchronous and public?


`bzero` is considered deprecated.  `memset` should be used instead.  See http://pubs.opengroup.org/onlinepubs/009695399/functions/bzero.html for details.


does this need to under "with context.session.begin(subtransactions=True):"? A few lines ago I saw "network = self.ml2_plugin.get_network(context, port['network_id'])" by itself so just wondering....


This `ignored` is dubious, too.


Комментируемый код не должен присутствовать в ветках, которые планируются к интеграции в мастер. Удалите, пожалуйста.


LGTM


>One last question for today and when you can update the code on the server to make the new deployt?

To deploy you run:

    bundle exec mina ukraine-production deploy

We normally tell someone when we're going to deploy in our Slack chat: https://oaf.slack.com/messages/hackerspace/

I've invited you there but you don't need to join if you don't want to :)

I've just done a deploy :rocket:


What's the point of this?


guarantee


Subsequent versions of pandas will throw an error without it.


add_router_interface_postcommit() is a no-op in parent's class so not sure if this call is needed....


'-' is rift runner, I get the name in test server '---'


Y u do dis?


TeamCity pull requests :: netty [Build 809](https://garage.netty.io/teamcity/viewLog.html?buildId=3879&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6232, ignored: 21 Build time: 00:41:02


Understood.


There are tools for merging like kdiff3, meld, etc. You can call it with `git mergetool`, it prompts you for your preferred tool when you start it first. I am using kdiff3, it's a bit ugly visually, but allows resolving conflicts in seconds, often even automatically.


This is the route I should have gone all along. Logic for each promise after it has been resolved or rejected can be handled in it's own method. Versus one large `then` statement that handles all the scenarios.


@jeffbyrnes Just wondering, isn't it supposed to be `recipe[et_apache_test::default]` or is it assumed that run list items not wrapped in a `something[...]` are recipes?


What subsequent version? I use whatever in `requirements.txt` - pandas == 0.16.2.


Because this is lazily loaded via ember data, I was having trouble figuring out how to load dependent async relationships. Turns out doing a `model.get` on the relationship will return a promise object.


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (908 of 908 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.7%25-green.svg)


add favourite colour


这个方法是否需要在APP获取到设备号DeviceToken后再次调用一次呢？因为用户如果拒绝接受消息通知的话，是无法获取到设备号的。


It's very important that all these methods have the `return` statement. Does not work without returning.


Sounds good!


This code does not belong here.  resource.Builder knows nothing about Kube objects.


didn't see this piece of codes in l3_apic.py but I assume you saw it somewhere that's why its needed here....


Because this is the `RESTadapter`, it will automatically prepend this resources route structure to this url. So, not positive but we _might_ be able to handle the composite url problem we were having, if we get all the relationships right in Ember Data. Needs more exploration.


17.0+. I now have an environment specifically for stargeo with the `requirements.txt` versions, so I am indifferent on this change.


I am seeing more duckies now on Mac than with commit: https://github.com/SchizoDuckie/DuckieTV/commit/621ed47f8032dabb2f8bd8b29c027062a5b68225
Which is the only one not giving me issues with multiple duckies on minimize, just additional duckies after the midnight update process and not having issues with the window being invisible/permanently minimized but running.

This one creates multiple duckies when minimizing/maximizing the window.
I also noticed that the duckie icon is not present on the app, just the nwjs icon.
Attaching screenshots.

![screen shot 2015-12-09 at 01 26 13](https://cloud.githubusercontent.com/assets/13501166/11676865/062639c2-9e16-11e5-9141-6d0a052565ee.png)
![screen shot 2015-12-09 at 01 28 27](https://cloud.githubusercontent.com/assets/13501166/11676866/0633b7f0-9e16-11e5-9121-bf3faf3cd2d5.png)
![screen shot 2015-12-09 at 01 30 35](https://cloud.githubusercontent.com/assets/13501166/11676867/0659005a-9e16-11e5-937c-b213abde7801.png)


Y u do dis?


I agree with the logic but I might try to re-arrange a bit to make more obvious that it's an alternative to emptying a region.


This is fixed in v2.6.5, FYI.


That works.  I think the render and attach code are consolidated enough that this is now sensible.


I cannot refute this, let's put it in :)


Click the Rich Diff button to set it in effect


天哪，太强了，短短的几行代码就避免了iOS爆炸！


Herro Github!


it is not an alternative I don't think.  if you are about to empty the region, you want to stop the listener.. but you also want to stop the listener if you're not going to destroy the view.


I did the thing


OK.


@kmalakoff https://docs.npmjs.com/misc/config#global-style to turn off the flat hierarchy style.


Its probably a good idea to list those precommit() & postcommit() in order. Just like ASR1kL3RouterDriver class does. For example, add_router_interface_precommit() then add_router_interface_postcommit(), ...etc. Right now it jumps around so its not so easy to follow....


@nsgc
ご返答ありがとうございます。
変数を埋め込めるんですね！確かにこっちのほうが便利だと思います。
僕も使い方がわからなかっただけなので、ありがとうございました。


nicely done Husky, I must chat to you about how you did them sometime :)


For my Android port, I just removed the swift_ssize_t check and nothing seems to be broken.


Reverted: 4bb9314, fixed: 3610ca3. Thanks!


Any reason for switching from Swig to Jade? I am using jade in my project and was thinking of switching to Swig, I have run tests and Swig is much faster.


I think some comments on the PR as to what this change accomplishes and why would be helpful.  This code is not very self-evident perhaps comments in the CSS would also be helpful


I'll delete this overriden API.


Okay! As far as I know, we can remove that part of the code. If there is no connection it must show a notification modal, am I right?


Can you try and define `PYOPENCL_CL_CASTABLE_THIS` to be `data()`? It looks like it might help. (It should only be active on gcc 5.2 and up anyhow, but who knows...)

https://github.com/pyopencl/pyopencl/blob/3610ca3ea6bc53531e97d24f8fb774596e7634fc/src/c_wrapper/error.h#L18-L22


You know you don't have to refer to the modules in winapi right? Their contents are all glob imported to the root module for convenience. The modules are only there for my sanity and doc organization.


Ha, I was just coming back to say nvm, I noticed that as soon I tried to move the off-destroy.


Commenter extraordianire


The problem with merging is @davkean's TypeNameParser doesn't ever ask for ref-or-def and I tried to segregate the interfaces according to 3 use cases (signatures, custom attributes, type names).

I'd be fine with GetXxx(), it would even be slightly more efficient as there would be no need to switch twice.


I just realized that, in order to be compatible with Backbone.View, we can use `_isRendered` internally but not `isRendered()`.


I think this is too restrictive, when trying to open a text file with vim for example it return a "Permission Denied"


您好，能联系下联系方式吗？


The API in XWalkWebChromeClient also need to be deleted.


Looks ok. Ready to merge?


Yes, I forgot add this change into patch....


@andersonba done, published in 0.4.1


Hi, I'm glad if that helped. We are a startup with our own AR engine (www.easyar.com) and AR content delivery platform (www.sightp.com) (Chinese only). We are evaluating glTF as an alternative delivery format for our augmented reality scenes.


Why does DD want to ignore prizes?


This is just to get it to work. See later commits for how to reuse the original instance.


Change once we deploy.


@zackbloom I couldn’t figure out how to get it to work anywhere but here.


The JSON string printed in the test looks like this:

```json
{
   "methodName":"method-name",
   "parameterTypes":[
      "com.thoughtworks.go.server.service.AgentRuntimeInfo",
      "com.thoughtworks.go.domain.JobIdentifier",
      "com.thoughtworks.go.domain.JobState",
      "com.thoughtworks.go.domain.JobResult",
      "java.lang.String"
   ],
   "arguments":[
      {
         "identifier":{
            "hostName":"localhost",
            "ipAddress":"176.19.4.1",
            "uuid":"uuid"
         },
         "runtimeStatus":"Idle",
         "buildingInfo":{
            "buildingInfo":"",
            "buildLocator":""
         },
         "location":"/var/lib",
         "usableSpace":0,
         "operatingSystemName":"linux"
      },
      {
         "pipelineName":"pipelineName",
         "pipelineLabel":"lastgood",
         "stageName":"stageName",
         "buildName":"buildName",
         "buildId":1,
         "stageCounter":"LATEST"
      },
      "Scheduled",
      "Failed",
      "some-string"
   ]
}
```


oh yeah.. makes sense.


oops. ignore this.


white balance is no problem on dng. it can easy adjusted by selecting auto in ps or rawtherapee. only important is that the matrixes works. else the colors gets shifted wrong


Nevermind, the type name parser gets primitives by name like any other type. I can collapse them.


Missing right '}' and ')' in the exec callback function.


CM build system didn't require this at this point. We deprecated it.


Wrong args for the callback function in the exec function. It should be function(err, products)...


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - i386-Windows-7-VisualStudio-12: OK (1982 of 1982 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg)


yes


Example of an inline comment.


This should close #12 after some testing.


Alright, It seems that I'll change my test case to call getFavicon on Ui thread.


should this be "openstack_owner=router['tenant_id']" instead?


Hi @mayoub and @qbuat. @lspiller just discovered that this doesn't merge the ntuples properly. The cutflow histograms were empty. We've just fixed this up and he should be submitting a PR. Is it fine to submit a PR to this branch on htautau?


Average rating before updates
('Raja', 'Soorimurthi', 3.3)
('Joshua', 'Hankinson', 4.9)
('Martha', 'Twain', 4.4)
('Buzz', 'Lightyear', 2.3)
('Monster', 'Beefington', 3.2)
('Areolia', 'Wu', 4.4)
('Droze', 'Mongom', 5.0)
('Frankie', 'Talapia', 3.9)
('Nick', 'Jankous', 1.9)
('Help', 'Me', 3.5)
('Bingo', 'Town', 4.4)

Average rating after updates
('Raja', 'Soorimurthi', 3.3)
('Joshua', 'Hankinson', 3.5)
('Martha', 'Twain', 3.5)
('Buzz', 'Lightyear', 4.0)
('Monster', 'Beefington', 3.0)
('Areolia', 'Wu', 2.5)
('Droze', 'Mongom', 2.66666666666667)
('Frankie', 'Talapia', 4.0)
('Nick', 'Jankous', 4.0)
('Help', 'Me', 4.5)
('Bingo', 'Town', 2.5)


TeamCity pull requests :: netty [Build 810](https://garage.netty.io/teamcity/viewLog.html?buildId=3880&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6232, ignored: 21 Build time: 01:28:44


HI @ndawe,
We had to disable the cutflow hist merging because it was buggy in the previous version of the skims.
Can you pull this to my github repo? I'll migrate everything here soon (in the next days).

Cheers,
Quentin


why it needs @sync_init here while all other precommit()/postcommit() don't need it?


oops.. i'll add a new line, thank you


change 'product' in the callback function to 'seller'
and return res.render("seller/edit_product", { products: seller.products, user: req.user });


Sure. A little surprised that works though.


@alwey, Thanks for clarifying. Yes I suspected that cutechess was not handling ponder correctly(based on fishtest posts). But the fact remains that ponder=false impacts time management.
when SF is tested in ccrl/cegt/tcec etc. ponder is turned off and the timemanagement is different from what is used in fishtest. So the question is whether Mikael's ponder patches perform better than master when ponder is turned off for both sides.


didn't mean to add the one with a tilde, deleting it now


so we can't just use "owner=tenant_id" here like self.manager.enable_router() does below? The logic to get the tenant seems quite convoluted.....


Insertion sort using Python


Do we really want to leave out curly braces and parenthesis when possible?

```
.then( foo =>
  // success one liner
, err =>
  // error one liner
)
```
vs.
```
.then((foo) => {
  // success one liner
}, (err) => {
  // error one liner
})
```


- added whisper options to config tab
- added level and range to npc spells and sla
- added {{subtitle}} key/property to sheet macros
- fixed readonly and row numbers on buffs array
- added weapon {{Type}} formatting to pf_attack
- misc stuff


again, why it needs @sync_init here while all other precommit()/postcommit() don't need it?


[Uextract] (http://www.murga-linux.com/puppy/viewtopic.php?t=87864) is another nice extracting utility.
One question with the default{something} is how you prioritise when multiple options co-exist. And also why the default priority list is the given one.
BTW default applications chooser that can "waste" all these after a single run ;)


this comment from l3_apic.py doesn't seem to apply here....


Nice, very nice. Two thoughts:
- it would be nice to have project / system colors in there if possible
- could we find a way to insert this useful shortcut for childless layers (i.e. simple symbology)? maybe the color well could be added within the Styles > sub menu?


Don't remove that line.


What about Character, Boolean, Number and other classes?

`new JsonPrimitive(Object)` seems to do the trick but raises an exception in case `object` is not primitive.

See `com.google.gson.JsonPrimitive#isPrimitiveOrString`


The problem is that without these values it fails in other hardware (tried it).
So would be nice if we could detect the sync failure and add do the modification as a result of it by xorgwizard.
But you may have  noticed that we are phasing out xorgwizard, so I'm not sure how much of it is needed.


Thanks! Made some changes. I suck at typing D:


I am taking a look


I think we prefer STARLINK_DIR environment variable here to enable relocation.


Maybe even Todos.Model? That's basically what it is, let's be real.


This doesn't seem to do anything. The lights keep blinking.


@PatrickPijnappel Please write a small benchmark that tests the performance of Zip in -O. I want to make sure that we are not regressing the performance of zip.


#4853-Fully-autosized-DX-coil-should-not-fail-with-a-fatal-SHR-error (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1446 of 1446 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.52%25-green.svg)


#PFP


I think adding an additional step will work.
https://github.com/RichardBronosky/xobjective-c/commit/ae278427bb7952422969daa506a78472a40c2e92

I know it sounds mundane, but the first time through, seeing "**your project** in the Project navigator" made me think I needed to change the Build Phase for "**ExerciseName**" rather than "ExerciseName Tests"


parameter id is not being used at all here.....


Oops how did I miss that one.


有空去你那写写代码（顺便认识妹子


Cool. I was wondering whether they had such a thing. Anyway, in this case it is not needed because the top level is the only one that is needed by this. And, in our `BuildRepositoryRemote`, we have just enums and strings. But, thanks. With a real implementation I'll use this.


What I mean is [this method (toJsonTree)](https://github.com/arvindsv/gocd/commit/3101646174a8bfee6d2138ef75dd1fa52699c504#diff-57ddcef0c2be8b2ac4c0a0ae4e08f76bR37) takes care of other primitives further down.


If/when this gets merged we can stop this https://github.com/adamw/macwire/pull/87


could we maybe move the beta notice to line 1?


Muy bueno Kieryn! How about some sound effects and a coin counter? Maybe we could do that on another Saturday. Then your Zelda clone game will be easy.


write功能 这是用来做什么的呢


This Repository is Study For Github.


这是一个评论功能 有啥用呢


Done https://github.com/gaearon/babel-plugin-react-transform/commit/7cfc2dff87ebbb7b8570befafc0de2b6b1379eec


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8699](https://teamcity.mesosphere.io/viewLog.html?buildId=88795&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:06:29


you are the man


I don't see l3_apic.py does this notify_port_update() for those FIP operations.....Is this needed?


Is this a shared instance, that could lead to thread safety issues?


Waring:Failed propType:Invalid prop 'colors[0]' of type 'number' supplied to 'AndroidSwipeRefreshLayout', expected 'string'.Check the render method of 'PullToRefreshViewAndroid'.


Are you referring to the file named ppdFilename? The defer statements above are executed in LIFO order, so unless there's a panic, this will happen refresh() returns:
```
r.Close()
os.Remove(C.GoString(ppdFilename))
C.free(unsafe.Pointer(ppdFilename))
```


Ah, I see. @lspiller, can you submit the PR to @qbuat's fork? Just include the changes to this file, I suppose (cherry-pick onto a temp branch).


Neglected to note the changes to 'anvil-fio-tester';
* Added checks to report various sysfs values
* Added reporting on write cache, read-ahead and emulation information.


Shall we use a more generic tag name, such as `eventuate-chaos/sbt`?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8701](https://teamcity.mesosphere.io/viewLog.html?buildId=88796&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:09:49


also cleaned up layout :smile:


Remove?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8700](https://teamcity.mesosphere.io/viewLog.html?buildId=88797&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:11:22


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 8702](https://teamcity.mesosphere.io/viewLog.html?buildId=88798&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:08:54


Just hold left shift.