A message for all of these- something like:
```scala
  @deprecated("Import from org.scalajs.dom.experimental.worker instead.")
```


this is one of the change, filters and class names to inlines


Ok, I'll take it :) but let's wait to change gettext until we need to so we don't clutter the commit history, is that ok?


> My original intent is that the commit id is not embedded when building is done from released version(*.tar.gz).

Ah, okay.

> If yes, how can I do it?

Can we use `git describe --tag --exact-match`?

E.g. echoes 0 when `HEAD` matches a tag:

```
git describe --tag --exact-match HEAD > /dev/null 2>&1 && echo 0 || git rev-parse --short HEAD
```

Or show the tag when matches:

```
git describe --tag --exact-match HEAD 2> /dev/null || git rev-parse --short HEAD
```


Once we also change install scripts to pull this ovs repo, yes.
Dind't change it yet though...

On Fri, Dec 11, 2015 at 8:17 PM, John Reumann <notifications@github.com>
wrote:

> that means I can nuke my local patch
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jreumann/ovs/commit/1597f07fabf81f241893691f9be036c9603cd5d0#commitcomment-14931651>
> .
>


We are not live yet so I hope for a soonish release of 1.6.1.4 and will then do the re-install of the module.
Thanks a lot for clearing this up, @tchauviere.


Just friendly advice, I suggest that at some point you slightly reformat the code (try-except statements are easier to read if they are at least four-liners) and go over the code comments to ensure that the comments reflect the general code structure and explain the most tricky points. As for the style guide, [PEP 0008](https://www.python.org/dev/peps/pep-0008/) is a good reference.


тут тебе зачем параметр? и в аналогичном методе в MWMOpeningHoursAllDayTableViewCell?


ну вот тут еще согласен про магическую константу, чет страшное на вид.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9251](https://teamcity.mesosphere.io/viewLog.html?buildId=91940&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:21


This is rather `CategoryCode`...


тут либо стронг убрать, либо уже копи дописать (в принципе, копи не нужно, потому что установится ровно 1 раз)


Probably makes more sense if insideCenterTile evaluates to true when the provided coord are within the center.


I think this if statement should not be here. It blocks page content rendering when user is logged in


^^ Good point!


@purcell https://github.com/milkypostman/melpa/pull/3362#discussion_r47450256


Yes definitely!


You said don't enable in the commit itle, but it's still enabled here. Bad commit or it's ok ?


TeamCity TripleA :: UnitTest [Build 389](http://home.k-moeller.dk/viewLog.html?buildId=760&buildTypeId=TripleA_UnitTest&guest=1) is now running


`(it+1)` fails gcc with `error: no match for ‘operator+’` and clang with `invalid operands to binary expression`


TeamCity TripleA :: UnitTest [Build 389](http://home.k-moeller.dk/viewLog.html?buildId=760&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:44


TeamCity TripleA :: UnitTest [Build 390](http://home.k-moeller.dk/viewLog.html?buildId=761&buildTypeId=TripleA_UnitTest&guest=1) is now running


Yes, I got a report by e-mail, including logcat.


TeamCity TripleA :: UnitTest [Build 390](http://home.k-moeller.dk/viewLog.html?buildId=761&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:52


if you want people to get into the project, you should do way smaller commits...
each commit changing only one thing.

most of all: please, don't mix new features and bug fixes  with the coding style ones!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9252](https://teamcity.mesosphere.io/viewLog.html?buildId=91945&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 206 Build time: 00:08:22


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9254](https://teamcity.mesosphere.io/viewLog.html?buildId=91953&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:49


Not really, not that are better than the current system.

In TraitImpl, the best alternative would be a class MartialArtsTraitImpl that overrides that method - but this would just push the hard-coded reference into the location that instantiated the TraitImpl. To push that reference out of hard-coding and into configuration would imply substantially more detailed configuration of traits than currently exists. That may be desirable, but my command of the whole system isn't really strong enough right now to implement it.

In AbilitiesModelImpl, I went back and looked at the old 2E codebase (for the last public 2E Anathema release) and imitated the implementation of Craft. Again, without adding additional properties directly to traits in the configuration files I don't see a better method.

I also am not really sure generalizing this is worthwhile; the only other trait I think is likely to require similar behavior is Craft, and I think that behavior will be sufficiently different as to require a different implementation anyway.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9253](https://teamcity.mesosphere.io/viewLog.html?buildId=91952&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:23


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9255](https://teamcity.mesosphere.io/viewLog.html?buildId=91954&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:06


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9256](https://teamcity.mesosphere.io/viewLog.html?buildId=91955&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:13


i had enabled cboqs modules but i cannot find the header menu to view cbqos graphs


@slarosa  There are svgs missing in this commit


LGTM


Well, Egor deserves a cookie. Give it to him! Medium


RubyKaigiってすごい！


bah, will fix :P


Yep :disappointed: an alternative (which I'm not sure how to implement right now, but seems possible) is to add configuration information for the MartialArtsModel that includes a list of available styles. This might actually be useful in the future since plausibly mortals cannot learn SMA styles, period. It would also decouple the MartialArtsModel from the CharmModel.


@qiansen1386  没检查你顺便弄了呗。 我这是前几天收到邮件看到没人弄才弄一下，我用 Laravel 四个月了，基本都精通了，yii 这个实在是想不起来了。。


No big technical reason; we gain some simplicity, while the user can achieve the same effect by linking a tachyon directory from another external point in the local fs hierarchy.


stray 6


The problem here isn't that the directories must exist for Clojure to start up, it's that directories on the classpath that do not exist when the JVM is started, are ignored when they are created and filled with data.

As with semver – yeah, we could probably be better there. =|

I'd be happy to take the discussion over to #2010. It's not immediately obvious for me whether we should create those directories, warn about nonexisting ones or not include some of the directories we automatically include.


The PrerequisiteList doesn't know the Charm's category. It was a tossup between adding the new method, giving the PrerequisiteList information it doesn't strictly need, or (worse than either, in my opinion) copying the logic "primaryTraitType, or MA if this is an MA charm" into each location it is needed.


WILLRUN


TeamCity LabKey :: Trunk :: Community :: CDS postgres 9.4 [Build 34](https://teamcity.labkey.org/viewLog.html?buildId=291391&buildTypeId=LabkeyTrunk_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 13 (1 new), passed: 35 Build time: 01:11:43
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyAntigenScatterPlot: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSHelpCenterTest.verifyHelpCenter: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

##### there are 3 more failed tests, see build details
```


Any idea what changed in NG? As I doubt LG put up some update for this old device.


would be good to add a comment pointing out what 'stream' is needed for.


I don't know


@StefanoSalsano thanks for this, I didn't know that.


```log
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c: In function ‘yy_reduce’:
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c:8763:38: warning: passing argument 2 of ‘xx_ret_scall’ from incompatible pointer type [-Wincompatible-pointer-types]
  yygotominor.yy132 = xx_ret_scall(0, yymsp[-6].minor.yy0, 1, yymsp[-3].minor.yy0, NULL, status->scanner_state);
                                      ^
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c:1189:14: note: expected ‘char *’ but argument is of type ‘xx_parser_token * {aka struct _xx_parser_token *}’
 static zval *xx_ret_scall(int dynamic_class, char *class_name, int dynamic_method, xx_parser_token *M, zval *parameters, xx_scanner_state *state)
              ^
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c:8775:38: warning: passing argument 2 of ‘xx_ret_scall’ from incompatible pointer type [-Wincompatible-pointer-types]
  yygotominor.yy132 = xx_ret_scall(0, yymsp[-7].minor.yy0, 1, yymsp[-4].minor.yy0, yymsp[-1].minor.yy132, status->scanner_state);
                                      ^
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c:1189:14: note: expected ‘char *’ but argument is of type ‘xx_parser_token * {aka struct _xx_parser_token *}’
 static zval *xx_ret_scall(int dynamic_class, char *class_name, int dynamic_method, xx_parser_token *M, zval *parameters, xx_scanner_state *state)
              ^
In file included from /usr/include/string.h:630:0,
                 from /usr/include/php5/main/../main/php_config.h:2554,
                 from /usr/include/php5/Zend/zend_config.h:1,
                 from /usr/include/php5/Zend/zend.h:51,
                 from /usr/include/php5/main/php.h:35,
                 from /home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c:9:
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c: At top level:
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c:9257:7: error: expected identifier or ‘(’ before ‘__extension__’
 char *strndup(const char *s, size_t len)
       ^
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c: In function ‘xx_parse_program’:
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c:9235:17: warning: return makes pointer from integer without a cast [-Wint-conversion]
 #define SUCCESS 1
                 ^
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/parser.c:9350:10: note: in expansion of macro ‘SUCCESS’
   return SUCCESS;
          ^
make: *** [parser/parser.lo] Błąd 1
make: *** Oczekiwanie na niezakończone zadania....
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/scanner.c: In function ‘xx_get_token’:
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/scanner.c:1274:4: warning: implicit declaration of function ‘free’ [-Wimplicit-function-declaration]
    free(token->value);
    ^
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/scanner.c:1274:4: warning: incompatible implicit declaration of built-in function ‘free’
/home/mruz/Dropbox/git/ice/framework/vendor/phalcon/zephir/parser/parser/scanner.c:1274:4: note: include ‘<stdlib.h>’ or provide a declaration of ‘free’

```


wow) its work!


Maybe call this `AbstractCategory`? Introducing the concept of "type" doesn't sound like a good idea since it doesn't match anything in the Unicode standard.


No, there is not.


@slarosa you can revert it when you add the missing files


Wiki page is at ozwillo/ozwillo-datacore, not pole-numerique/oasis-datacore (even though it correctly redirects there)


I've probably commented before that I'd find `proportion` clearer than `percentage` for a value in `[0,1]`


I would define these inside the `Cat` module, just like abstract types (or move them both outside).


コミットログかな？化けてるのは。


I think method name should be `getUserIdsByRole` for consistency, like `\yii\web\User` `getId` method.


TeamCity TripleA :: UnitTest [Build 391](http://home.k-moeller.dk/viewLog.html?buildId=768&buildTypeId=TripleA_UnitTest&guest=1) is now running


You do not need calculateWidth because Image Workshop knows how to keep aspect ratio.


TeamCity TripleA :: UnitTest [Build 391](http://home.k-moeller.dk/viewLog.html?buildId=768&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:46


TeamCity TripleA :: UnitTest [Build 392](http://home.k-moeller.dk/viewLog.html?buildId=769&buildTypeId=TripleA_UnitTest&guest=1) is now running


:-) I hate xterm... BTW bisogna aggiungere sshpass alla lista delle dipendenze ??


TeamCity TripleA :: UnitTest [Build 392](http://home.k-moeller.dk/viewLog.html?buildId=769&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:44


You should use `asset-path('bg-image.png')`


#123
This ended up being serindipidously successful: I am getting a slight performance improvement using COMPRESSED_RGBA. This is contrary to years ago when it slowed things considerably.

I suspect it has to do with fill rates: In traditional rendering, assuming models aren't ordered front-to-back, a lot of draw surface gets re-drawn over and over. Having many overlapping quads like in New Kroy was particularly slow. The decompression operation has a cost which scaled with this waste.

In the case of deferred texturing, the texture fetches remain constant with zero waste. The bandwidth reduction apparently comes through more than the cost.

This shrunk the codebook costs by a factor of 4. Removing the third codebook (currently unused) reduced codebook costs another 30%.


Aaaaah, I misread the function. Sorry. I'm still paranoid though :)

Now that I see how the function works, I think we need something like this instead?

    assert os.path.isdir(os.path.join(src, path))
    assert not os.path.exists(os.path.join(dst, path))

Note that `shutil.copytree` creates all *parent* directories! This is surprising to me, and might not be what we want. So we might want to keep checking `os.path.exists(dst)`, and complain if the parent path does not exists. On the other hand, we might not? I'm not sure.

Stepping back a bit, I want to go over this carefully because I think the file system interactions are the key failure points. This is where the bugs arise. There are lots of ways to install Python modules, and they mean that the file system is in lots of different states when you run setup.py. Then you hit these confusing errors, and there's a real risk of deploying fixes that are also not correct. So, I'd like to reason about this stuff up-front.

I've tried to set out the logic tree for `dst`. I don't know what behaviours we want at the leaves, or whether some branch should be impossible. I assume the same code can cover multiple branches. I've written this more flat than nested. The 1.1.1 branch is the happy path.

    1. dst exists
        1.1 dst is a writeable, non-symlink diirectory
            1.1.1 dst_path does not exist
            1.1.2 dst_path is a writeable, non-symlink file
            1.1.3 dst_path is a writeable, non-symlink directory
            1.1.4 dst_path is a writeable symlink file
            1.1.5 dst_path is a writeable symlink directory
            1.1.6 dst_path is a non-writeable, non-symlink file
            1.1.7 dst_path is a non-writeable, non-symlink directory
            1.1.8 dst_path is a non-writeable, symlink file
            1.1.9 dst_path is a non-writeable, symlink directory
        1.2 dst is a writeable, symlink directory
        1.3 dst is a writeable, non-symlink file
        1.4 dst is a writeable, symlink file
        1.5 dst is a non-writeable, non-symlink directory
        1.6 dst is a non-writeable, symlink directory
        1.7 dst is a non-writeable, non-symlink file
        1.8 dst is a non-writeable, symlink file
    2. dst does not exist. Does its parent exist? Is its parent writeable?


commit + rollback commit
Le 14 déc. 2015 10:05, "digitalLumberjack" <notifications@github.com> a
écrit :

> You said don't enable in the commit itle, but it's still enabled here. Bad
> commit or it's ok ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/nadenislamarre/recalbox-buildroot/commit/7193abedc9b17f9780c0c794ba4b43039677120e#commitcomment-14953428>
> .
>


TeamCity TripleA :: UnitTest [Build 393](http://home.k-moeller.dk/viewLog.html?buildId=775&buildTypeId=TripleA_UnitTest&guest=1) is now running


Penso di si, controllo


And the same :arrow_up:


TeamCity TripleA :: UnitTest [Build 393](http://home.k-moeller.dk/viewLog.html?buildId=775&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:42


No we use commits from you, and the march commit I will change.
But did you notice that your commit is only 7 days old?
My commit is more than 2 weeks old... I don't think that I can travel back to the future.
I also don't see credits for your benzo optimizations which are based on Sabermods and chet's commits,  just a side not


@lazedo, should it be `['local']` instead of just `'local'`?


Right


@indexzero ping :)


Bitte Defaultwert belassen!


I don't know whether or not possible because not familiar with VPN and Visual Basic.


お題を読んだかんじ、 `CSVParser` のオブジェクトに対して呼べるインスタンスメソッドの公開の粒度は適切でしょうか？


In let's say 95% of the commits I've checked, those eligible for copyright did not extend the respective declarations or the AUTHORS file. In general this should be interpreted so that they would like to release their changes under the public domain and/or would like to donate the code to us. This could be either because they don't think the contribution was major, or they would like to remain anonymous. I have no problem with the current practice how it is done here, I'm only documenting what I see.

Your comment seems to suggest that after literally any change that is made, we must record the identification of the author so we could waive some of the issues we could face in a later legal incident. Am I reading you correctly?


literówka, siezke- sciezke


Broken link, should be `https://data.ozwillo-preprod.eu/dc-ui/index.html#!/dc/findDataInType_get_2` (same for all other links below)

Also maybe put backticks around the linked text:

    [`GET /dc/type/{type}`](…)


That is unnecessary


TeamCity TripleA :: UnitTest [Build 394](http://home.k-moeller.dk/viewLog.html?buildId=780&buildTypeId=TripleA_UnitTest&guest=1) is now running


if (tablis[i]==this) 这一句 难以理解


Use the `@Ignore` annotation:

```scala
/** Disabled due to #2109 */
@Ignore @Test def test_until_disabled(): Unit = {
  for {
    d1 <- samples1
     d2 <- samples1 if d2.isAfter(d1)
  } {
    assertEquals(d1.until(d2).negated, d2.until(d1))
  }
}
```


Okay, I could remove the mention about patent rights. However, we'll need to link the relevant parts of our EULA or other documentation we have on the question, because it is important for a contributor and this is the best place to mention it.


TeamCity TripleA :: UnitTest [Build 394](http://home.k-moeller.dk/viewLog.html?buildId=780&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:52


TeamCity TripleA :: UnitTest [Build 395](http://home.k-moeller.dk/viewLog.html?buildId=781&buildTypeId=TripleA_UnitTest&guest=1) is now running


*If* I were starting from a clean slate, I'd probably allow it. But since this functionality is not brand new, I got to think about some poor soul that put their config together by trial and error, and found that `color011` or something is exactly what they need. I believe explicit fail (an error message) is better than implicit/silent one, so I decided to reject colours where number start with zero.


TeamCity TripleA :: UnitTest [Build 395](http://home.k-moeller.dk/viewLog.html?buildId=781&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:51


Please rename to MavenProject so it is not confused with project from SonarQube API.


Sorry I fixed it here:

Done at https://github.com/OCA/project/commit/c56b243a53609721211ea4dedc8e57e97390cc38


Shouldn't these set_* functions be in intset.c ?


Thanks for this commit. Do you want to make a PR for it ? I can add test if needed.


Actually, use `@Ignore("Disabled due to #2109")`


Super


This software update is still improvable because of [inappropriate underscores in a few identifiers](http://stackoverflow.com/questions/228783/what-are-the-rules-about-using-an-underscore-in-a-c-identifier#answer-228797 "What are the rules about using an underscore in a C++ identifier?").


Actually my "back to the future" commit was made before. I re did it after removing some shit commits. And my commits look like SaberMod's because I was on the team when we made them. Paul just decided to go with vendor commits instead.


Stupid question: Wouldn't we need to delete all nodes and elements that have already been allocated at this point?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9259](https://teamcity.mesosphere.io/viewLog.html?buildId=91966&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Error while applying patch Build time: 00:00:07


I meant to write "install", but your change is fine.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9257](https://teamcity.mesosphere.io/viewLog.html?buildId=91956&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:15


Co to ma być?


jesteś programistą. brawo.


@Dinno Looks like some definitions added on different platforms so I guess we need to have it in CMake too. Though detecting of linux can be done on C++ level: https://github.com/boostorg/predef/blob/9de744244971bb133c57acda5d90a1777ebeaf02/include/boost/predef/os/linux.h#L30


wspaniale pawle.


I tend to think that reporting is fairly insufficient here. We should precise which element is not properly placed as currently it is nearly unusable information (and even worse, you could end up fixing things without really fixing the issue). As such, checkPositions should probably return some line to report issue on and maybe type of element.


javadoc?


https://github.com/yiisoft/yii2/commit/cc4849a3aec225749ea9d15270eaad3f04073bd7 :+1:


Shouldn't we update the README badge as well?


Didn't realise you would see this ;)

I wanted to make a proper PR with tests, but have time constraints on my current project so was planning later.

If you think the above looks correct, then I'll make a pull request so you can tidy up and add tests :)


We already have a class named Location in JavaFileScannerContext, could you please rename this one to avoid confusion.


Hello,

I don't think the `line.isNull()` check (or the while loop) helps here.  As far as I see the only issue with the original code was that it used a temporary (`str.readLine()`) after its lifetime ended (via the refs that `splitRef()` created). In my opinion it would be enough to simply use `QString line = str.readLine();` and later use `line` in the foreach loop (without the outer while loop you added).

I don't quite see how reading multiple lines here would help anyway, as the input is coming from a previous readLine() -> QString -> QTextStream path, so multiple lines at this place sounds unlikely.


I get an email every single time you write `@public` in a commit message :(


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9258](https://teamcity.mesosphere.io/viewLog.html?buildId=91965&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:13


Uh-oh, looks like 'groundnut' has a typo!


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9260](https://teamcity.mesosphere.io/viewLog.html?buildId=91967&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **FAILURE**
Summary: Tests failed: 1 (1 new), passed: 0, ignored: 205 Build time: 00:04:16
### Failed tests
```
null: Kubernetes e2e suite.Kubectl client Guestbook application should create and stop a working application [Conformance]: <no details avaliable>

```


~~~
object TestGroupByKeyOnSpoutproxy extends App{
  val env = ExecutionEnvironments.get[StormExecutionEnvironment](args)

  val tuples = Seq(
    Entity("a", 1),
    Entity("a", 2),
    Entity("a", 3),
    Entity("b", 2),
    Entity("c", 3),
    Entity("d", 3)
  )

  env.fromSpout[String](TestSpout())
    .groupByKey(_.charAt(0))
    .foreach(println)
  env.execute()
}
~~~


this causes some troubles with existing projects.
In projects where I had some external python file referenced, it was chosen "provide code in this dialog" with just an unfinished line in the editor.

Of course, this causes python error.


TeamCity pull requests :: netty [Build 855](https://garage.netty.io/teamcity/viewLog.html?buildId=4048&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6225, ignored: 22 Build time: 00:46:05


@toddlipcon There is already a license file at the root directory. Isn't that enough? Should I copy the same to scala subfolder?


What is the impact of your latest changes? Did you improved the performance?


@elpaso shall I open an issue or will you take care of it soon?


Ah I see, thanks for the tip. ;)


You are right. This could confuse users. I will remove this and provide the steps in README to use the default sbt installation. This script is a flexible one to download the required versions. Let us keep it simple as that's the purpose of this example.


Thank you for the example, which fluid do you refer to? `ref=`?


TeamCity TripleA :: UnitTest [Build 396](http://home.k-moeller.dk/viewLog.html?buildId=787&buildTypeId=TripleA_UnitTest&guest=1) is now running


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9261](https://teamcity.mesosphere.io/viewLog.html?buildId=91968&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:23


TeamCity TripleA :: UnitTest [Build 396](http://home.k-moeller.dk/viewLog.html?buildId=787&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:40


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9262](https://teamcity.mesosphere.io/viewLog.html?buildId=91969&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:58


updated.


updated


lol. whoops.

in my defense i fixed that afterward, i just pushed it to the wrong branch ~_~


Looking at wine code it looks like it's what I'd return and do.


:clap:


为什么不直接写成"require_once __DIR__.'/vendor/autoload.php';"


I have 4 Key Wireless Remote Control Kits ,when press a button for example print 5592512,how can detect key press or hold with program??


@rhenz  this is not included yet.


1.6.1.4 should indeed be released really soon (this week or next week) so I guess you can wait if you are not live yet.

Best regards,


Shouldn't configure.ac be modified as well ?


@giang69 xem tui sửa cái validator nè


Что это? Почему версию не инкременировали? Публиковать?


I change the default commit message next time. sorry.

原始邮件
发件人:Alex Stapletonnotifications@github.com
收件人:weixinhost/yaryar@noreply.github.com
抄送:Albert Leelb13810398408@gmail.com
发送时间:2015年12月14日(周一) 17:35
主题:Re: [yar] test @public (83a35e5)

I get an email every single time you write @public in a commit message :(
—
Reply to this email directly or view it on GitHub.


:+1:  :smile:


@hajoeichler Still working on it? :)


Good to merge!


Other addresses in the file seem to have country names in them. I think it would be better to add the country name to the previous address.


I've got over 100 messages from my Symfony 2.8 on Windows with the original line.

-

With (line 140)
```php
|| ($this->isRunningOnWindows && ($this->directoryStringLength + 4 + strlen($id) * 2 + $this->extensionStringLength) > 259)
```
I got ~10 errors:
```
rename(C:\xampp\htdocs\XXXXXXXXXX\app\cache\dev\annotations\fd\swa419E.tmp,C:\xampp\htdocs\XXXXXXXXXX\app\cache\dev\annotations\fd\5b5b435d53796d666f6e795c42756e646c655c4672616d65776f726b42756e646c655c436f6e74726f6c6c65725c436f6e74726f6c6c6572236372656174654e6f74466f756e64457863657074696f6e405b416e6e6f745d5d5b315d.doctrinecache.data): Invalid argument
Context: { "type":2,"file": "C:\\xampp\\htdocs\\XXXXXXXXXXX\\vendor\\doctrine\\cache\\lib\\Doctrine\\Common\\Cache\\FileCache.php", "line":254,"level":28928,"scream":true}
```
-

and with (line 140)
```php
|| ($this->isRunningOnWindows && ($this->directoryStringLength + 4 + strlen($id) * 2 + $this->extensionStringLength) > 258)
```
I got no more errors related to this.


No more blue screens, no more crashes, no more stuttering, no more ads . . . .

Little Smart Dot release date announced to be 20th Dec. can't wait
it even comes with it's own fancy subdomain lol :P

http://agar.strlbs.com


Gi den heller navnet QueryParameters - ideelt sett er den ikke export-spesifikk


Ça serait bien de rebaser pour squasher ce commit dans le suivant !


Also, a code which was ok before doesn't seem to work anymore:

```

from PyQt4 import uic
from PyQt4.QtGui import QComboBox, QWidget

subForms = None

def formOpen(dialog, layer, feature):

	typeSelector = dialog.findChild(QComboBox, 'installation_type')
	typeSelector.currentIndexChanged.connect(typeSelection)

	global subForms
	subForms = []

	for i in range(0, typeSelector.count()):
		widgetName = typeSelector.itemData(i)
		childWidget = dialog.findChild(QWidget, widgetName)
		subForms.append(childWidget)

	typeSelection(typeSelector.currentIndex())

def typeSelection( index ):
	for i, widget in enumerate(subForms):
		widget.setVisible( i == index )
```

produces this error:
```
Traceback (most recent call last):
  File "", line 1, in
NameError: name 'formOpen' is not defined
```

am I doing anything wrong?


callbackError?


Looking at the changes I don't think they introduce any new code branches. If that's the case I'd advice removing those two entries and regenerating artefacts again as the last commit :)


I wouldn't say just recoverability, how about "thrown to request the message to be rolled back to the input queue" ?


@3nids please open an issue with a small test project and I'll take care of it ASAP.

I don't understand your second comment: if that is related or not with the first.


How else should I modify the commit ?


大丈夫ですか


cunt


is this on pip yet ?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.931](http://teamcity.monogame.net/viewLog.html?buildId=12159&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


TeamCity TripleA :: UnitTest [Build 397](http://home.k-moeller.dk/viewLog.html?buildId=792&buildTypeId=TripleA_UnitTest&guest=1) is now running


Line 31 looks like a partial debug line, shouldn't be needed.


TeamCity TripleA :: UnitTest [Build 397](http://home.k-moeller.dk/viewLog.html?buildId=792&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:55


TeamCity TripleA :: UnitTest [Build 398](http://home.k-moeller.dk/viewLog.html?buildId=793&buildTypeId=TripleA_UnitTest&guest=1) is now running


Maybe you could try to split your commits to [avoid mixing multiple logical changes in a single one](https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes).


多分大丈夫です :mask:


But please leave the `#include <errno.h>` in, it was needed when compiling with `WITHOUT_XATTR` defined.


I think the root cause is higher up in the chain. The contents of _index.js_ will be automatically overwritten when running the jsx compiler, so any changes in this file will be lost. I'm going to remove this file from the repo :)


TeamCity TripleA :: UnitTest [Build 398](http://home.k-moeller.dk/viewLog.html?buildId=793&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:49


update


Why hide the cause?
$error= new Error($base->getMessage(), $base);


Is IllegalStateException a Runtime Exception? No need to handle by calling method?


`parse` を呼び出した結果 `IndexError` となるというのは、どういう状況なのでしょうか？
メソッドから raise される例外も、メソッドのインタフェースの一部です。
メソッドのインタフェースについて、ドキュメンテーションコメントを書いてみてはいかかがでしょうか？

例外については、どのような種類の例外が、どんな時に発生するのか？が書いてあって欲しいです。
そして、発生した例外から状況がわかるだけの情報が得られると嬉しいです。


done


this fails on julia 0.3 unless preceded with an `isdefined` call


missing formatting?


Thanks for fixing it. I'll remove my comments so they're not here for everyone to see.


TeamCity TripleA :: UnitTest [Build 399](http://home.k-moeller.dk/viewLog.html?buildId=800&buildTypeId=TripleA_UnitTest&guest=1) is now running


TeamCity TripleA :: UnitTest [Build 399](http://home.k-moeller.dk/viewLog.html?buildId=800&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:45


TeamCity TripleA :: UnitTest [Build 400](http://home.k-moeller.dk/viewLog.html?buildId=801&buildTypeId=TripleA_UnitTest&guest=1) is now running


I think this is the right way wo implement it:
https://github.com/Tkkg1994/Nova-Kernel/commit/a10b7384444a6f303854260d6a1878f3566e83d5


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9263](https://teamcity.mesosphere.io/viewLog.html?buildId=91974&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:41


TeamCity TripleA :: UnitTest [Build 400](http://home.k-moeller.dk/viewLog.html?buildId=801&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:43


I just disabled this in master as i believe it's failing because the 20ms window is too strict. If we want a more reliable test we should make the actual animation longer (> 1 second) and give a much wider accepted range between the expected and actual time.


dataBeforeStart - Let's update it so that field name which is compared to should come as argument


Not able to test since not at home, but didn't https://github.com/SpringCabal/LD34/commit/03318e0ef640d30643dfc6624ee9ad6eb6b5c350 remove those ground decals?


sa


Are you sure Eclipse Java editor width is set to 120?


Undo comment


Yup, sounds good to me.


Unused imports? Or why was `noqa` necessary?


saw approval from javajolt
at https://github.com/basho/riak-python-client/commit/9c098ddbcf5362f5f0ff92f17dd427050feeaeb2


merging basho/riak-python-client/features/lrb/riak_pb-submodule = 9c098ddb into borshop-integration-418-features/lrb/riak_pb-submodule


basho/riak-python-client/features/lrb/riak_pb-submodule = 9c098ddb merged ok, testing candidate = f558141b


Ah, yes, I misread it [here](http://linux.die.net/man/7/socket). You have to use `getsockopt` to see to what it was set. I think this is OK as it is.


avoid dupping all those similar strings, just put asingle r_cons_printf and construct a string that ends with `r_str_newf ("; %s", comment);` or NULL and just do `arg?arg:""` in the last printf


SYNOPSIS of this function needs to be updated


local.c: In function 'main':
local.c:1048:13: error: 'nofile' undeclared (first use in this function)
             nofile = atoi(optarg);
             ^
local.c:1048:13: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [ss_local-local.o] Error 1


ruby indentation is 2 spaces, not 4


not sure why i choosed `12` here. maybe we should move this 12 into a const or a define.


const?

Now that I see the fixtures I realised, what will happen if between different versions of the executables they change the output? It's kinda likely that it will happen.


@mkonicek Yeah, I think we can replace the redundant stuff with a link. I'll send a PR.


Sorcery helpers are required if user params.
However, test_helper.rb is required at all times.


Would it be better to have this fixtures in files and load them from there? It's going to be more readable and the `\n`s and similar will not be a problem.


Ah that's pretty odd. Have you successfully been able to switch over to regular Maven Central releases?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9394](https://teamcity.mesosphere.io/viewLog.html?buildId=92496&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


You can also add info that it creates a WorkingFolder for test files which is getting cleaned after tests


Isn't this a fixture as well?


DITTO


Any idea why we have this test?


d


antipattern:
small commit

justification:
small "testing" commits aren't great for providing constructive feedback :)

created on antipattern.io


exactly, pytest fixtures. The thing is, it dosn't work.


I'd rather we focus on getting the desktop version back up to demo-ready and then I'll shift all my effort into pushing out on android and other platforms.

That way we can have something as soon as possible to try to drum up interest from hobbyists/devs with desktop app before we push the demo out into a market with ratings and all that.


There are a lot of files regarding tests in the `pkg/` folder, couldn't they be organised in some other way?


I'd move servicing up. It's important everyone does it.


Leave a line note


why are we removing path to our module from PSModulePath?


> There was some discussion on the matter on mozilla.dev.tech.crypto:
> https://groups.google.com/forum/#!topic/mozilla.dev.tech.crypto/fohi1x40UKo

Ah, could the wiki be updated to reflect that?

> Modern recommendations, which is intended for systems that have AES-NI instructions


This doesn't use ``workflow_outputs_dicts`` at all right. Did the step model get assigned to a dictionary at some point? Ekkk...

Feel like merging https://github.com/galaxyproject/galaxy/pull/1306 would be a better fix :smile:, I believe it does fix this problem also.

:+1:


My guess is my gradle config is looking at all Maven snapshots and https://oss.sonatype.org/content/repositories/snapshots/com/parse/parse-android/1.11.1-SNAPSHOT/ gets added because of the wildcard nature of:

```
dependencies {
    compile 'com.parse.bolts:bolts-android:1.+'
    compile 'com.parse:parse-android:1.+'
}
```
 https://www.parse.com/apps/quickstart#parse_data/mobile/android/native/existing


#5252_TinDiscrepancyNewVRFModel (rongpengzhang) - i386-Windows-7-VisualStudio-12: OK (1983 of 1984 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-99.95%25-yellow.svg)


note


:confused:
![image](https://cloud.githubusercontent.com/assets/4734691/11798165/67e15762-a27d-11e5-8cfa-f19117e7e190.png)


Il faut simplement faire attention à ne pas accepter des réponses du genre ``"yusternutieu*"``. Pour cela, ce test juste après le `input()` devrait faire l'affaire :
~~~python
if answer not in ["y", "n", "y*", "n*"]:
    continue
~~~


Nit: braces are not needed, just the `let` will do.


This doesn't seem to be working as expected.
I can't make it working, it looks like vars don't get interpreted as bool but strings, so basically `ceph_infernalis` contains something like `True and True` but this eventually returns False.
The issue with the `when` I proposed earlier is that the fact is not set if false... so we need 2 versions of the fact.

Thoughts?


Kind of wonky/hard to find, but not bad.


@rzarzynski should verify that the first char is actually a slash


Addressed this in my latest amended commit.


typo


The only comment I have for this is that we might want to ask the user to confirm on `unmute` as well as `mute`. Otherwise the change looks pretty good.


It doesn't need to be `public`.


Leave a line note


I created two new functions in my latest amended commit, ```getReplicaTypeForPartition()``` and ```renameReadOnlyV2Files()```. This also allowed me to simplify the legacy code below.


Once the changes are done, I am fine with this. Only thing I would recommend is, see if the existing tests can be parameterized to test the new functionality or make testing the new functionality default. Other than that I am fine with merging this change.


This of course doesn't fix OSX but keeps Windows working as before...


This is the only thing I have not addressed in my latest amended commit. It seems messy to me to have all of this ad-hoc plumbing code all over BnP, which is why I wanted to limit it to one function, which could be rewritten better later. But let me know if you insist, and I can split the function into three.


We also used the platform to develop an Android app. The app serves as a proof of concept, showing that we can extract the data from the Pubnub and let a mobile app use it in real-time. In the future this could provide a framework for a fitness app, showing useful analytics of dancing sessions such as the number of calories burned. Since the app is made in the multiplatform Corona SDK, it is very easy to build it for IOS as well.


@mikegehard,

Our work & notes from Saturday.

I changed one thing that I'm curious if you like this idea... that instead of `use_cases` I namespaced as `Runner` in that it has a `#run` method. I also went one step further and [put it under the models](https://github.com/woodall/api-practice/blob/182a096103b43362f8d3c132007e35eff7110a8d/app/models/runner/pay_bill.rb) because I could justify that it's still 'business logic' and that models are supposed to house all that.  But, of course I can put it back at the top level if the nested is too much...


As per the SubmittingCode file, please submit this patch with a Signed-off-by: line to libhugetlbfs@googlegroups.com


Please add formatting for the above if-else block (add spaces for the appropriate places)


The new functionality is the default in the above commit.


This Tobschinski-guy, the one and only, the legend!


I benchmarked it, it is fine.


Any chance of unit tests for this stuff?


Fixes issue #164


You can ignore this.


Jim, I believe this functionality which is shared between SHOP and IVL, broke IVL.

The button will always be disabled in SHOP after first purchase.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24379/testReport/) for this commit**


Leave a line note


Do you have a TWRP that supports it?


This is actually removed in the last commit


Overriding `NSLog` with `LogMessageCompat_NSLog` is very brutal and using mach_override is not even necessary. You can easily *hijack* NSLog with a much softer hack, see [WebObjects 4: NSLog and Slow NT Application Response Time][1].

Overriding inside an `__attribute__((constructor))` function is even more brutal, replacing NSLog should be opt-in.

  [1]: https://support.apple.com/kb/TA45403


Because one could create or download an .img file through a pre build script it is not sure anymore if there is a zip file to unzip.


LGTM, but can't we use lodash's `isObject` instead?


Check if a pre build script set OCTOPI_IMG_PATH to an img, if not fall back to ls method


Huh, seemingly no reason. Probably from before I implemented the failure-raise mode.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9395](https://teamcity.mesosphere.io/viewLog.html?buildId=92560&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


compareDocumentPosition() takes an amount of time proportional to the tree depth, i.e. the number of ancestors of the two compared nodes. You could say it is O(ND) where D is the depth, but I think O(N) is also correct, since D is constant with varying N.


seems like we probably want something from `librustc_trans::consts` in here, no? e.g., `get_const_val`? perhaps it doesn't matter though.


Done.


Should these be `PyFloat_Check` and `PyLong_Check`?


Actually, it does not appear that there is a space here?


#4994-ControllerWaterCoil-TemperatureAndHumidityRatio-control-active-when-it-shouldn't-be (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (911 of 911 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-25.84%25-green.svg)


If you're not purposely trying to use Snapshots for anything, you might want to check if you have something like the following in your `.gradle` files:

```
repositories {
  maven { url 'https://oss.sonatype.org/content/repositories/snapshots' }
}
```

Otherwise that makes sense.


Likely? I'm using this one because it's what Vue's native orderBy uses and
I was trying to mimick that as much as possible.

On Mon, Dec 14, 2015 at 7:31 PM Phan An <notifications@github.com> wrote:

> LGTM, but can't we use lodash's isObject instead?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/mattstauffer/koel/commit/90250eb337f6a32b7ae57ed492859b57f90af70f#commitcomment-14974174>
> .
>


just fyi to cover 60%~ of node users you should shoot for

0.12, 4, 5

to bump up to ~90%

adding 0.10 is required


I might reword this a bit to something like:

Continuous queries do not backfill data, that is, they do not compute results for data written to the database before the CQ existed. Instead, users can backfill data with the `INTO` clause. Unlike continuous queries, backfill queries require a `WHERE` clause with a `time` restriction.


nit: add "Examples" subtitle


@rzarzynski ah, I actually understand this now, nm


Yeah I do have it for other repos.


"example bellow" --> "example below"


Great find!


The issue with this, is that if there are dots on the selected day, and you refresh the calendar, the dots are blocked by the circleView that's on the selected day


This would be nice to have as a note:

> **Note**: In InfluxDB...


actually, this will work as is (if the underlying deleter does the right thing)


Is this supposed to fix the issue where if there are dots on the selected day, and you refresh the calendar, the dots appear under the circleView that's on the selected day?


Cameras have never been working, although I recall seeing lsusb output including those devices at one point. I booted into a stock kernel and one of your priors but I can't find the cameras, here is my lsusb -v output from a stock 4.4 kernel:

https://gist.github.com/gregorycollins/2c9010698ab0350605f6

I've tried the firmware fix, thanks for the tip.


Deleting fields (vs setting to undefined) is a performance issue where an object is upgraded to a "class" by the compiler and optimized based on the assumption that the shape doesn't change. So, in the Parsoid codebase, deleting a field of a Token (or data-mw, data-parsoid) would be disastrous for performance.

In tihs case, this is an array and removing an element of an array is unlikely to be an issue especially since the size of the array is not a constant anyway.


Also, trailing lines and ID-less PURLs were removed.


done


This breaks the build with only oe-core, without meta-openembedded, because of `llvm3.3_%.bbappend`.


...Um. What was the logic behind this?


I combined the two descriptions, maybe this is clearer:

* `null` - sets `null` as the value for intervals with no data
* `previous` - copies the value from the previous interval for intervals with no data
* `none` - skips intervals with no data to report


Fhdhdhd


Dlaczego to jest wykomentowane? Bo juz sam nie pamiętam o co mi tam chodzilo...


Another thing to note: your latest kernel breaks two-finger scroll on the touchpad, unless I have to do something special to configure it.


Jak cos wymyslisz to daj znac.


@pootzko, thank you! I recommended a couple edits but otherwise it looks good. @gunnaraasen, any additional comments?


Why are you prefixing this?


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9396](https://teamcity.mesosphere.io/viewLog.html?buildId=92578&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:42


This was an accidental premature commit, but it's OK.


asdf


Fixes #47 - Fixes #36 - Fixes #13


should i move the 'should' clauses into utils as well or should we limit the utils to only return true/false values?


You also need to change REQUIRE, including on the broken tag.


add .gitignore


wow, nice. can't wait to merge it :)


yea, but I think we can do refactor later (use quad_graph for battle arena too?)


you're bad and you should feel bad


@mikegehard,

Connected by following [rails checkout guide](https://stripe.com/docs/checkout/guides/rails)
![screenshot 2015-12-14 17 48 11](https://cloud.githubusercontent.com/assets/587705/11798759/e31c0136-a28a-11e5-8e9c-c7e6ccee03fe.png)


Closed #11


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9397](https://teamcity.mesosphere.io/viewLog.html?buildId=92581&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:02


This should be a config option instead of a changing of constants.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9398](https://teamcity.mesosphere.io/viewLog.html?buildId=92583&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:01


Ok, capping to 12 (4096 => a little over an hour).


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9399](https://teamcity.mesosphere.io/viewLog.html?buildId=92584&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:23


is this true for all versions of APCu?


I have some comment for you.
- I think in code you don't need using many try catch in 1 function. only one is ok.
- You need careful when set Name for class, function, parameter, event,... How set Name for easy understand.
- I think if you using jquery for call event servlet is easy. Because if you using action in form, how do you do alert when have error login?


The method was calling itself (therefore stack overflow) in obfuscated env so I looked at how this was solved in another mixin and it was shadowed (I forget how to fix things sometimes) but it works


Voxelv was here.


I like your changes.  Interested in submitting a pull request to the main Budabot project?


this could be an autodetect, checking if apcu is intalled, use it, if apc is installed, use it, if none is installed, throw exception.


controlable -> controllable


If you run this, you should be able to connect to it from your browser http://localhost:54363


这样写是不对的，谁教的?


This... may not be in the API at all?


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24380/testReport/) for this commit**


Thanks @shettyg !


We don't know the expected size here, only the maximum bucket count, which will typically be much larger than the number of buckets written on a single node. I doubt it matters much either way. If it is large, it will expand quickly.


Not yet


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24381/testReport/) for this commit**


I'm not completely clear what the proposal review process is, but I don't believe this section accurately represents the counter argument it's supposedly trying to represent (as discussed in the mailing list).

Sorry if this isn't the right place to comment, but I became worried when I noticed this proposal was merged with insufficient representation from the opposing camp.


Aah, yeah, protected would probably have been fine.  That was just force of habit on my part, to default things to the least visibility.


감사합니다. ~ 더 신중하게 개발할께요 ~


saw approval from bkerley
at https://github.com/xing/riak-ruby-client/commit/7b6e33d59d4cd466e8e160a71d1d5ca19d444df6


merging xing/riak-ruby-client/PR-microseconds = 7b6e33d5 into borshop-integration-247-PR-microseconds


xing/riak-ruby-client/PR-microseconds = 7b6e33d5 merged ok, testing candidate = a3fa7bb6


saw approval from bkerley
at https://github.com/xing/riak-ruby-client/commit/a1afe901f9a3ba5dc1a7b3d91e63808228a3e0a5


merging xing/riak-ruby-client/PR-log-network-errors = a1afe901 into borshop-integration-248-PR-log-network-errors


xing/riak-ruby-client/PR-log-network-errors = a1afe901 merged ok, testing candidate = cffbd866


See #1498


TeamCity ReOpenLDAP :: master [Build 39](https://binbug.bigbrother-matrix.ru/teamcity/viewLog.html?buildId=1414&buildTypeId=ReOpenLDAP_Master&guest=1) is now running


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9400](https://teamcity.mesosphere.io/viewLog.html?buildId=92616&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:58


Yes it is, to add operator under kitchenSink, may need update below files only.

```
Rx.KitchenSink.ts
operatorxxx.ts -> newly added operator
add\operatorxxx.ts - > to be imported into Rx.Kitchensink.ts
```


I'm worried that if read stops returning (but doesn't throw an error or throws an error that is caught), then we may yield forever and not exit.


Hot.


Money


wow! I am learning so much here! :+1:


Why did you add a 3 here? I would assume its a mistake. Did your tests not break from this addition?


Test


This was a severe bug.


Not sure how that matters, polymer doesn't need to be testing on multiple versions of node.


Whoah, this is three years old! I no longer use NSLogger, but thanks for the info. I wasn't aware of a soft override like that.


> why inline 3 copies of the tree walk function?

Because most callers want tree walk without the additional parameters, and I think naming the function appropriately makes the functionality clearer in the calling code. I felt that passing in two different return variables that are rarely used warranted splitting the function up.

> Why not inline these functions in misc.i

They don't need to be in misc.i because they are only called from within a single file, so inlining will work when they are in the c file. i.e: inline functions should only be in ``.i`` files if they are referenced from multiple different source files.

> or use a #define?

I'd always choose a function over a define - debugging through #defines is a pain.


o


should this be "v1.6"?


Thanks Birdman.


TeamCity pull requests :: netty [Build 864](https://garage.netty.io/teamcity/viewLog.html?buildId=4075&buildTypeId=pulls_netty&guest=1) is now running


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9401](https://teamcity.mesosphere.io/viewLog.html?buildId=92634&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:04:03


Should this be a numbered list rather than an indented block?


thanks for you reply,  because the Xen server is not on my host，it installed in AWS or ALIYUN ，so i don’t konw how to use it ，and more details as follow:
when i  excute this command on my OS(kernel version is 3.4.x), it returns some errors:
![image](https://cloud.githubusercontent.com/assets/11690682/11798952/a4952cd2-a30a-11e5-9c3e-4f067fad0e8b.png)
and i open the 、etc/init.d/kdump, found that what cause this problem is
![image](https://cloud.githubusercontent.com/assets/11690682/11799045/88b6d1cc-a30b-11e5-867c-d4eb3a1e6124.png)
![image](https://cloud.githubusercontent.com/assets/11690682/11799055/9d771266-a30b-11e5-91c4-fb8d1f134c60.png)
that means my guest is pv model, so it tips  : kdump does't support on this kernel , and i excute this command . it returns:
![image](https://cloud.githubusercontent.com/assets/11690682/11799115/287c1866-a30c-11e5-92d9-cd05dfa7ef99.png)
how can i start the kdump ? can you give me any suggestion?


Should this include the --delete command-line option to remove files that are no longer part of the website?


I still need to edit the links for the new docs site.


Avoid passive voice.  A reader could interpret this as that some other process has committed them by now.


If someone is following the current release instructions they wouldn't be tempted to have changed the version numbers yet.  This seems to be for the benefit of people who read a previous version of the manual; can you cut the sentence?


There were a few things I needed to fix when merging in 0.17.0. Here's the relevant commit in the submodule:

https://github.com/michaelbarlow7/crawl/commit/530ae902b5cb769733ad009aaed48b9dd043e13f

If you look at Android.mk you can see there were a few .cc files removed and a couple added. Also, to build the stuff in rltiles I needed to tell it to use c++11 (I was getting that "nullptr not recognised" error). Normally this is passed via the root Makefile, but I just changed the call to make in setup.sh to be `make STDFLAG=-std=c==11`.

Also there were a few weird things with the merge which added closing curly braces to some functions in some files, but checking out the original 0.17.0 version of those files got rid of those. I also got rid of the symlink to README.txt from assets since that file no longer exists. As far as I can remember those were the major problems.

I'm running almost the same setup as you, but with Linux Mint. I'm using Crystax's NDK version 10.1.0.


I might try and fix that issue with rotating the screen on Marshmallow before submitting a new version.


You removed supervisord.conf, but this still adds it.


Do you mean `Url.Encode` or `HttpUtility.JavaScriptEncode`?


comment Test


Thanks you, all set...


@FGCarvalho tome cuidado ao publicar estes tipos de dados sensíveis no Github, senão alguém mal intencionado pode te prejudicar financeiramente :+1:


r+


I think, this block of "see if it is already there ... no ... then lets create it" should be synchronized on the map.


That throws me "timhaak/timhaak/docker-plex is not a valid repository name".


Why is this step necessary?


saw approval from jedmccaleb
at https://github.com/MonsieurNicolas/stellar-core/commit/8b25e61e33f879b46ea9048c3d6483c1d2f78b46


merging MonsieurNicolas/stellar-core/betterQuorumOutputOutOfSync = 8b25e61e into auto


MonsieurNicolas/stellar-core/betterQuorumOutputOutOfSync = 8b25e61e merged ok, testing candidate = 4897ca7b


You should have put your favorite color


Test comment


Cool, thanks for the feedback everyone. Going through 24 hours of travel,
will try to have something out tomorrow.
On Dec 14, 2015 7:06 PM, "OJ Kwon" <notifications@github.com> wrote:

> Yes it is, to add operator under kitchenSink, may need update below files
> only.
>
> Rx.KitchenSink.ts
> operatorxxx.ts -> newly added operator
> add\operatorxxx.ts - > to be imported into Rx.Kitchensink.ts
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/justinwoo/RxJS/commit/767b1f54e2d73551f3f1c156f6e1714502cd79e4#commitcomment-14974617>
> .
>


indent please


I don't think you should delete this line.  Rather than up on line 2548 telling the user to remember to run every command from a particular directory, it's more foolproof to make the commands work regardless of where they are run from, and you can do that by doing `cd $DAIKONDIR` before each command.


Egor for president!!!


move this line into closure below.


Maybe we should clear git database and build it again


Is this necessary?  I thought the idea was to have a separate process that the user should go through before running "make staging", and that process would run the "make doc/CHANGES" target.  Then you can remove doc/CHANGES as a prerequisite for the staging target.


Correct.

On Mon, Dec 14, 2015 at 5:14 PM, Mior Muhammad Zaki <
notifications@github.com> wrote:

> Our auth implementation would only load "api" guard if the application
> actually request it right? So I would think it is safe to uncomment this.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/laravel/laravel/commit/435104304e9f6afc326f639cf3d884ae60644617#commitcomment-14972862>
> .
>


This cannot possibly happen because you just did "touch doc/CHANGES".  This discussion should be moved into a set of instructions that are run in the user's main clone, before making a new clone or running "make staging" in it.


Another comment


Thanks. Yeah, the IDs in the camera patch I have associate with the
internal USB hubs in your Surface Book so the patch I have won't work. I
could make a new patch, but I'd need to know the exact USB product IDs to
do so. I will note that the Linux uvcvideo driver doesn't officially
support UVC 1.5 devices right now (according to the maintainer). Some UVC
1.5 devices, like the SP3 cameras, will work with the current UVC 1.1 code
but it is possible that the Surface Book cameras won't work. The camera
patch that started this thread enables detection of UVC 1.5 devices and if
the device works with the current uvcvideo driver it will work (like the
SP3 cameras). Though I'm pretty sure I've seen reports of the cameras
working on the Surface Book. I'll look around and see what patches others
are using, and if I find anything new I'll incorporate it into my builds.

I haven't changed anything with the touchpad / keyboard. I'm not sure why
it stopped working. The hid-multitouch module needs to be loaded for the
touchpad / keyboard to work. If you use GNOME, you can check the settings
in the Settings app under Mouse & Touchpad. Failing that I'd just try
disconnecting then reconnecting the keyboard or rebooting a few times.


Here's a German version of the lanterna-ui bundle:
```
short.label.ok=Ok
short.label.cancel=Abbrechen
short.label.yes=Ja
short.label.no=Nein
short.label.close=Schließen
short.label.abort=Abbrechen
short.label.ignore=Ignorieren
short.label.retry=Wiederholen
short.label.continue=Fortsetzen
short.label.open=Öffnen
```


This is the PDF file with the description of changes applied to be able to put the application to work properly


gsdsgd


haha :dizzy_face:


Wah ?


有意思的逻辑~
确实是删了两次


Note: I edited the previous comment.  If you see this only through notification mail, then please look up the correct contents from github.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24382/testReport/) for this commit**


Is this a set of instructions to the reader (in which case, shouldn't they be more specific)?
Or is it a summary of what is coming up (in which case wouldn't the descriptions of the following steps be sufficient)?

I thought it was the latter, but then I was confused by the difference in terminology for the first item:  "Copy the release candidate to the public share point." vs "Update the website.".  In technical writing, please always use exactly the same terminology when you are referring to the same concept.  If you use different words, then a reader should assume that you mean different things and you are emphasizing the difference.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9402](https://teamcity.mesosphere.io/viewLog.html?buildId=92652&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:41


Atualização


Does the "cd $DAIKONDIR" a few lines below go to the temporary checkout or the user's original one?
I don't see DAIKONDIR being reset, so I think it goes to the temparary one, which I think would not be correct; but maybe you have a different intention.  (Or does the user have to log out and back in again?  I don't see those instructions either.)
I think that the user should never reset DAIKONDIR.  I think that "make staging" should be made not to depend on DAIKONDIR, and id doesn't seem to do so right now.


I'm unsure whether `swconfig` should be installed on / or /usr.  The argument for the former is many/most small router devices may be difficult to recover without their switch chip being configured.  On the flip side, many will have minimal network access even with their switch chip being unconfigured.

Meanwhile, moving `swconfig` from a sbin directory to a bin directory is a really *bad* idea.  `swconfig` *requires* root permission to do anything of use, as such /usr/bin is completely inappropriate and should be in /sbin or /usr/sbin.

\* note, upon inspection it appears OpenWRT's kernel may allow non-root to reconfigure switch chips, this is a rather Bad Idea(tm) as it is a distinct security hole and I'll be advising them shortly of this issue.


The reason the previous system gets "locked up" is that over time there are lots of edit variables and suggestions floating around and suddenly, adding one more suggestion isn't powerful enough to override the weight of previous suggestions.

A first approach around the problem is to make each edit a bit more important than the ones before it. Cassowary supports a notion of the strength of a constraint, in other words, how much we care that it not be violated. If we tell it that each edit is a little more important than the one before, it makes it less likely things will freeze up.

But eventually they still will. Play with the system for perhaps ten or twenty edits of different variables and you will eventually run into a situation where dragging no longer has an impact.

In my experience, this is the point where many people assume Cassowary is either buggy or just too confusing to be useful. But we're just not using Cassowary the way it expects to be used and there's a perfectly-good solution.


Okay!!
i didn't know we can alterate the state of readyState like that. I don't really see the point except for testing but ok. Now i know how to test $.ready() at least.

Thank !! :P


文件最后需要一个
`#endif`

该文件名称为 `Iniread.h` 对应的 `.c` 文件却是 `iniread.c` 大小写不一致


Is this flag really needed? You can instead run your tests with -enable-resilience and add a new test/Inputs/resilient_classes.swift module (like resilient_structs/enums) that defines @_fixed_layout and non-@_fixed_layout classes


#4994-ControllerWaterCoil-TemperatureAndHumidityRatio-control-active-when-it-shouldn't-be (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1449 of 1449 tests passed)

![Build Badge](http://img.shields.io/badge/build%20status-passing-green.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-100.0%25-green.svg) ![Coverage Badge](http://img.shields.io/badge/coverage%20status-70.53%25-green.svg)


yea just limit it to returing true/false and do the assertion inside the tests :+1:


Nice work!


All it does is build the three `PerfTests_*` targets, so you can just do that manually.


Yeah I think that would be much better imo. I'll do that.


Le hice para ver como trabaja github


Forgot to mention - I sanitized the constants file so that things like db passwords and salt constants are not shared with the public. Will need to keep a local copy preserved for each location where the files will be run (live server + any local environments)


I tried to remove all systemd packages and replace it with sysvinit-core sysvinit-utils. did not find a way to get it working


Yeah I think it's better if I stick these into some files in some subdirectory. It will be more readable actually.


hello world


This has fixed #9.

Though, the bans system is not fully functional or as efficient as it could be. Optimization will be coming shortly.


Don't know. I kinda like them this way, but I'm totally open to suggestions


SurfaceProperties (macumber) - i386-Windows-7-VisualStudio-12: Build Failed

![Build Badge](http://img.shields.io/badge/build%20status-failing-red.svg) ![Test Badge](http://img.shields.io/badge/tests%20passed-88.98%25-red.svg)


I see, cool. I completely missed the addition of `_.over` and friends :P


OK, fine, leave it, we'll sort it out later.

My usual instinct is to make things public and immutable; but we don't have Guava ImmutableList in avatica because we're trying to keep the dependencies minimal.


Oops yes. :)


添田です。
コードの意図を載せていただき、ありがとうございます。また、「**」に関してですが、自分が知りませんでした。
累乗をこの様に表記できるのですね。３つ目の引数$typeについては、基本的にtrue/falseのみを想定しており、
trueの場合は掛け算の結果を２乗していただく事を想定しておりました。


This value should stay a bit field to allow all combinations, please only use powers of two.

> 1 = OCG
> 2 = TCG
> 4 = Anime
> 8 = Korean
> 16 = Beta
> 32 = Custom

If you want to host a OCG+TCG duel, you simply use `1 | 2 = 3`.
If you only want TCG+Anime, you can use `2 | 4 = 6`.
If you want to use OCG, TCG and Beta cards, you use `1 | 2 | 16 = 19`.
... you get the idea.


Oh, I didn't know we already had something like that, nice. Will `@_fixed_layout` be the right attribute for classes as well?


all tests pass:
success: https://travis-ci.org/stellar/stellar-core/builds/96882439


The chained asynchronous queries are the worst part of Mongo/Mongoose. It's enough to make you miss SQL.


Thanks!


The arguments on both sides have evolved quite a bit since I first wrote he proposal. Not sure if it would be updated or discussed in mailing list.

> On 15 Dec 2015, at 01:57, Nick Shelley <notifications@github.com> wrote:
>
> I'm not completely clear what the proposal review process is, but I don't believe this section accurately represents the counter argument it's supposedly trying to represent (as discussed in the mailing list).
>
> Sorry if this isn't the right place to comment, but I became worried when I noticed this proposal was merged with insufficient representation from the opposing camp.
>
> —
> Reply to this email directly or view it on GitHub.
>


happy 600


Fixed with https://github.com/open-sausages/silverstripe-framework/commit/0e0fb253a5c5209838a8674058ca09c201373c34


well you cant actually, at least not on a document. its read only.
thats why i made a "fake"" document which is really just an element and put that var on it.
I wish i could have done it without the timeouts...

but it tests the 2 main situations,
- when the doc is already complete when you register it
- when the doc finishes after you register it


Bah this is an update to #698


fast-forwarding master to auto = 4897ca7b


See http://expressjs.com/en/api.html#res.redirect. It defaults to a 302.

You may want to use until.format() for a cleaner URL string also.

https://nodejs.org/api/util.html#util_util_format_format


You can do `from 1 through $unit` here to omit the `+ 1`.


Thanks. This fixes travis builds too.

On Mon, Dec 14, 2015 at 2:50 PM, Lance Putnam <notifications@github.com>
wrote:

> Oops. I always thought M_PI was a standard define in math.h. I guess not.
> Should be fixed now.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/AlloSphere-Research-Group/AlloSystem/commit/c326d6bc6fbcba18fdda89f1ffdcc02a76d94d69#commitcomment-14972418>
> .
>


Can you sync with upstream repo?
Actual place for job files are in /test/ directory as well as -test.yaml
More instructions https://github.com/common-workflow-language/workflows


Totally awesome Slava!


Oops, I should probably call this somewhere.


I think we should go with yuv420p an specify the range, see my thumbnail pr. Will change it to the code of yours, much easier.

I used 420p out of the same reason. Yuvj420p is the same AS yuv420p but full range.


TeamCity pull requests :: netty [Build 872](https://garage.netty.io/teamcity/viewLog.html?buildId=4085&buildTypeId=pulls_netty&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 6229, ignored: 21 Build time: 00:42:22


Would it work to use "test" scope instead? The description from Maven describes provided with

    This is much like compile, but indicates you expect the JDK or a container to provide the dependency at runtime.

, but we don't expect the dependency to be provided by a third party at runtime.


Typo


I think the error is not related to this commit itself. The error is because there are a call to `lager:debug` and maybe in that part lager is still not loaded or the parser_transform was not applied to the application.


Kakoi molodec!


how do i use pigskin.py?


saan yung gagawin dito


I commit to you


Don't we need a translation from `link => url_pattern`


This could fail on non-Unix platforms - it will certainly fail on Windows: see:
https://docs.oracle.com/javase/7/docs/api/java/io/File.html#separator
https://docs.oracle.com/javase/7/docs/api/java/io/File.html#separatorChar
Suggest you just use "/".


```
sudo apt-get install rng-tools
```
Don't confuse default kernel support with default user-space support; most people find it easy to install extra packages, whereas building a custom kernel and keeping it updated is a significant barrier.


dbi change is the only relevant change in the new version, please review your previous commits. I picked up April's version :
    {dbi, ".*", {git, "https://github.com/altenwald/dbi.git", "abf6caf1edcde4f2afbded9238cbc45495b5926e"}},


Oops, updated those tests.


TeamCity TripleA :: UnitTest [Build 505](http://home.k-moeller.dk/viewLog.html?buildId=1247&buildTypeId=TripleA_UnitTest&guest=1) is now running


TeamCity TripleA :: UnitTest [Build 505](http://home.k-moeller.dk/viewLog.html?buildId=1247&buildTypeId=TripleA_UnitTest&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 205 Build time: 00:00:45


 @pmackay @mkllnk can we also keep all the email translations in transifex?
 e.g app/views/spree/user_mailer/signup_confirmation.en-GB.text.erb


You can just write a brief explanation about what these variables for.


@bradenmacdonald There is a `gettext` call in this file (L37, in the error handler for `$.when`). Could that be reached before the code that ensures `gettext` is available (which is now in `view.js`)? Or does the fact that the code in `view.js` is wrapped in an IIFE guarantee that it runs before any of the logic in the `init` function defined in this file?


I am assuming here that the if statement does the following:
If name is not the last to be edited (lastEdited) then edit it [(addEditVar(variable)] and set the name as lastEdited
(I am assuming lastEdited is a pre-defined cassowary method.)
Is this correct?


Haha, thx Charlie


onclose here also


There probably is a typo about the property name: $this->_file_handler
$this->_file_handle seems to be the proper name.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9434](https://teamcity.mesosphere.io/viewLog.html?buildId=93041&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:59


remove blank line


You can comment a little about the mechanism here to make it more understandable for other people benefit from in case of adding a function like this.


Nice list @rldhont . I'd say this should go into the documentation somewhere so this work is not in vain.

Concerning the snippet: If False is returned, I would suggest the `value` should not be changed at all.

@volaya Can we use this in the parent class and implement a `setValueCheck` method only where required in subclasses which is called from the default `setValue` method?

Or overwrite `setValue` it in subclasses to do the check and then call the parent's default implementation?

-------------------

@volaya I think the `None` value is used ambiguously: For "not set" and for "set default". There should probably be a value `Parameter.default` or similar that can be used to explicitly specify using the default value.

`None` should be reserved for "not set". For mandatory (non-optional) parameters `None` can be treated as `Parameter.Default` or even better (if it doesn't break existing code) an exception could be thrown : "You are trying to set `None` on a mandatory parameter: bad idea!".


revert


Thank you for telling that. I will observe pull request what you created.


wow. yo guys, how come???? this terrible, really!!!


Hello,

In this repository I store a slimmed version of the numerical code that was used to produce folding and boudinage finite element simulations with REDBACK, used for my dissertation thesis (to be defended April 2016). Note that this code is a slimmed version that allows you to quickly reproduce the presented results. Feel free to play around with the outputs, parameters or develop the code further. For layer-parallel extension, you have to invert the sign of displacement, The mesh used can also be found in the folder. Please let me know in case you have a problem running it.

For details about references, directly assess the input file and see the comments. For questions, feedback etc. contact me via:

max.peters@geo.unibe.ch


I couldn't get the use of the variable "tags". It had been defined but had not been used later on.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24388/testReport/) for this commit**


reverting back fixes the problem ,
please label commit "abf6caf1edcde4f2afbded9238cbc45495b5926e" as stable , i will need to update the whole ecomponents based apps not to pickup the master!


We usually follow a convention of using shorter paths since IDEs are good at handling imports and shorter paths are easier to read


I think the changes effects only the arguments of record constructors. Therefore, this shouldn't have any impact on external functions.


you can put abf6caf as the release you want to use, I'm going to check why it's possible this is failing for you. Let me check...


Now that we're using `@SuppressFBWarnings`, we no longer need the old `@SuppressWarnings`


Accepted. Some styling is needed.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.962](http://teamcity.monogame.net/viewLog.html?buildId=12373&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


can you please provide a PR @lipiluk


`material_config_errors` or `environment_variable_errors`?


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 107](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=572&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


TeamCity LabKey :: LabkeyRelease15.3 :: CDS postgres 9.4 [Build 102](https://teamcity.labkey.org/viewLog.html?buildId=291540&buildTypeId=LabkeyRelease153_CdsPostgres94) outcome was **FAILURE**
Summary: Tests failed: 12, passed: 36 Build time: 01:07:03
### Failed tests
```
org.labkey.test.tests.CDSVisualizationTest.verifyDensePlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisWithMultipleSchedules: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifySubjectCountsWithFiltersAdvancedOptions: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBrushing: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyGutterPlotBasic: <no details avaliable>

org.labkey.test.tests.CDSVisualizationTest.verifyTimeAxisBasic: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyCounts: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyGroups: <no details avaliable>

org.labkey.test.tests.CDSTest.testLearnAboutStudyProducts: <no details avaliable>

org.labkey.test.tests.CDSTest.clickOnLearnAboutStudyProductsItem: <no details avaliable>

org.labkey.test.tests.CDSTest.verifyFilterPane: <no details avaliable>

##### there are 2 more failed tests, see build details
```


I think the code itself,the variable names and functions are mostly self explanatory but it is no harm adding some extra comments on what is done here.Overall,the code seems functional and it is highly recommended to be tested(unit) in my opinion.Thank you Ömer.


@chovy pigskin.py is the python library we wrote to interact with GamePass. It's meant to be independent of Kodi, so that others can use it in other projects. Despite some interest here and there, as far as I'm aware, no one has actually used it that way. You mentioned sending the streams URLs directly to ffmpeg (which, I assume, means you're not using Kodi to play the streams), which won't work well unless you manage the cookies, etc, which pigskin.py does for you.

pigskin.py is located in ``recources/lib/``. It's not well documented, nor do we have any examples other than the mini-mess we've written in ``default.py`` ;-). We should write some docs for it, someday.

Basically, if you're not going to play the streams via Kodi, then you have your work cut out for you, but writing some python code to call pigskin.py and pass the URLs to ffmpeg makes it a much more tolerable task.

---Alex

PS. Is there a reason why you chose this 1+ year old commit to comment on?


By this point all the constants that could’ve possibly been const-evaluated have already been const-evald, thus here we must translate code that build these constants (most notably, arrays) at runtime.

I didn’t use any of the functions in `trans::consts` (similarly for translation of method and function items) because they all want some sort of reference expr id (something `expr::trans` doesn’t need) only to retrieve information we already have in MIR.


@Sam-Spencer Do we have to use modules? They are not supported by Objective-C++ (.mm).


Yes. I see what you mean. At some point you cannot drag things around anymore. Is it because this "more important" condition for the last edited var cannot go on indefinitely?


TeamCity LabKey :: Trunk :: Premium :: Git postgres 9.4 [Build 848](https://teamcity.labkey.org/viewLog.html?buildId=291548&buildTypeId=LabkeyTrunk_GitPostgres) outcome was **FAILURE**
Summary: Tests failed: 24 (2 new), passed: 223 Build time: 00:26:05
### Failed tests
```
org.labkey.test.Runner: org.labkey.test.util.JUnitHeader: <no details avaliable>

org.labkey.test.Runner: org.labkey.test.util.JUnitFooter: <no details avaliable>

org.labkey.test.tests.RedCapTest.testMergeDuplicateNames: <no details avaliable>

org.labkey.test.tests.RedCapTest.testFailDuplicateNames: <no details avaliable>

org.labkey.test.tests.RedCapTest.testConfiguration: <no details avaliable>

org.labkey.test.tests.RedCapTest.testLongitudinal: <no details avaliable>

org.labkey.test.tests.RedCapTest.testDataTypes: <no details avaliable>

org.labkey.test.tests.RedCapTest.testDateBased: <no details avaliable>

org.labkey.test.tests.RedCapTest.testSeparateDemographicProject: <no details avaliable>

org.labkey.test.tests.RedCapTest.testVisitBased: <no details avaliable>

org.labkey.test.tests.DataFinderTest.testDatasetExport: <no details avaliable>

##### there are 14 more failed tests, see build details
```


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 111](https://teamcity.labkey.org/viewLog.html?buildId=291550&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:27


I know, I uses rngd.
Oh, bcm2835_rng size is 2207 bytes.  I'm voting for enable :)


Thanks for the heads up! I did not intend this fork to be an official one, I just needed the 5.5 compatibility to be available via a public repo.


komisch, das war natürlich kjoscha und nicht magdalena19(mein fake-account)


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 107](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=572&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **UNKNOWN**
Summary: Canceled (Exit code 1 (new)) Build time: 00:04:56


By the way, you shouldn't need to list `os` here - anything in the [standard library](https://docs.python.org/3/library/) will be available automatically.


I think it does if the record is sent to an external function. @sjoelund you know better how is the spec regarding external records sent to functions, do we have any issues with these changes?


Invalid data type. Should be date (without time).


This was previously fixed in a separatee commit https://github.com/nagisa/rust/commit/1a1f474d23f5fadb51984c4c22713c8660ff9021, but I went ahead and squashed it with this commit.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.962](http://teamcity.monogame.net/viewLog.html?buildId=12373&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **FAILURE**
Summary: Exit code 1 (new) Build time: 00:08:12


I'm not sure if that's the behavior we want. Consider the case where it's expanded, then you pull down a bit, let go, and it snaps back to the top. Should we notify again there even though it's still expanded? It did technically move after all, but the user for one reason or another just go far enough down.


elasticsearch-2.1.0

bigdesk:master


I'd change to name. `move.name` vs `movie.movieName`


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 108](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=573&buildTypeId=Xbim_XbimGeometry_XbimGeometry) is now running


profile updated


Not sure, might very well be


I think, a little bit comment about the general mechanism of what the code does and the variables would help a lot someone in both gaining some understanding about code and speeding up the process of the further possible developments on the code.


It should just be a void pointer that is sent, so the names should not matter.


похоже этот комит завалил сборку:

https://jenkins.igov.org.ua/view/new/job/regional-alpha/6369/console

нужно срочно поправить


Compiles without problem on gcc version 5.2.1 20151010. The method interface is generated by my qtcreator. But it is still an inconvenience when it breaks, thus a bug is filled and ill remove them: #51


What kind or problems are you thinking? I'm trying to think of any, but can't think of any in this particular case.


I've tried with tests in several projects and it's working well (channels mainly). Could you push your changes to I can review them? The change we put in the code is only about a definition and only changes the way to compile, the runtime system should be the same.


hello


I opted to storing the bare minimum of information necessary for translation here.


It ws thinking about it.
But what will we put there if we dont know the birth date?
Or we know only the year in which the actor was born?
I fought that less problematic would be if make the 'bitrhDate' field as String


Interesting., so finally return LockMode.READ at ResultSetProcessingContextImpl.java line 127 was just some kind of typo?


What about using ipAddress labels to have a full example?


@coolo of what?


Hi , this is the only my relevant changes https://github.com/Jongla/server-official/commit/1241edf8e213776fe058d799d8ad2279f614078b,
according to https://app.asana.com/0/19214578765328/73893625773715


@Sacrifice78 Of course, he doing good job, but 50% of his reworks need to rework again, because something missing or bugged.

From @Zoey76  too. Why commiting not done L2AttackAbleAi... if not finished :-D and with +1 TODO..

I have already fixed, but its just think :)


I felt a little dirty putting this in there :) In order to be CLS-Compliant the parameters to an Attribute Ctor must be CLS-Compliant types, so having just string would work. Will update.


add array before $facades

public function testConfig($file, $tmp, $compression, $thumbnail, array $facades)


Probably needs `license = licenses.unfree`, unless it's open source?


parce que je trouvais ça trop obscur et c'était visiblement pas la manière officielle d'accéder à une région http://marionettejs.com/docs/v2.4.2/marionette.layoutview.html#region-naming


Yep, thanks.

2d6d9ab0bfeb546d8c9d7924af7ccc095f798e41


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9436](https://teamcity.mesosphere.io/viewLog.html?buildId=93048&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:03:56


This commit alone can be a reason to release 0.9.1 asap :smile:


Cool. Any plans to push that upstream?


Sorry, my git has some problems, fixes comming soon.


@mbbderobles Ma'am ito po iyong ginawa ko for retrieve employee po.


AFAIK there's no reason to have `-linux` here, support for other platforms could always be added later.


Yes.  Use "Until" rather than "Till".

The link explains the difference well.  "Till" is mostly used in poetry or phrases.


makes the whole thing often not work at all!


wouldn't it be more logical to return 0 ?

If SetupReady is 0 (false), this indicates that the device is busy or requires some user input before being
ready to proceed with a setup operation. Specific details regarding what the user should do at this point are
not indicated by SetupReady. Instead, the Control Point can obtain protocol-specific status information by
invoking SendSetupMessage(). When conditions have changed such that the Device is ready to proceed
with a setup operation, it signals this to the Control Point by changing SetupReady to 1 (true). Note that
even if SetupReady is 1 (true), this is no guarantee that the setup operation will succeed. The CP should
simply use changes in the state of SetupReady as input to help it decide when to invoke
SendSetupMessage().


D'oh - thanks for catching


We're missing the highscore file!


`live` is not in use. It was meant to specify which server must be used for requesting certificates. Staging or live. This is obsolete since commit 5f58e3c2e0c18b3719e5678049122bb88dabb6c2 .

It is now stored in admin.conf

Also see issue #9


I have to bring ExternalMedia up to date anytime soon, for use in OMC as well. If there is any problem with that, I'll get back to you (hopefully not...)


dat ascii art doe


The spec needs a version number.  Right now, the version number slot is taken by the Java build, and if we added a version number to the spec that was different from the Java build, that would also be confusing.

I think Dilip is right, we need a clear story for how we assign version numbers to the spec.  I don't think that having two different version numbers for one repo is a good way to do that.


ok, the error is in the line 53 of dbi_pgsql because we are using `lager` and that library is not a dependency of dbi. Let me fix it.


**[unitTests_php_branches run failed](http://qa-s2.wikia-prod:8080/job/unitTests_php_branches/24390/testReport/) for this commit**


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.963](http://teamcity.monogame.net/viewLog.html?buildId=12377&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


No worries, @Garbee, it happens :)


What does this do?


It was a sinatra dependency. I required because it was loaded dynamically an non-thread safe version of that gem.


hmm , the app uses lager , it brings lager to the app environment, so dbi can use it --- IMO something else, interested to know that the reason


I had to cast it to int because in the UserPolicy, when checking the authenticated user against the user to delete, one's id was int and the other's was a string.


Is this enough to work with Symfony3?
Could you add a PR to the 'official' repo? https://github.com/misd-service-development/phone-number-bundle/issues/65


Hello Sir,
I want to build your book in windows machine. some of the commands like "apt-get" and make are unix specific. how to build the part 2 pdf in windows.??


lager:debug' is not a method but compile transform -- though


@bradenmacdonald Unused import


fixed, you can try again.


@bradenmacdonald Unused imports


very nice!


ok, thank you -- i will try on my next bug. so far this one is fixed


good catch @m-kuhn. All parameters shoud have a parameter.default value, so instead of using None, one could do param.setValue(param.default), and leave setValue(None) to indicate that the parameter doesnt have a value and should not be used (which would return false if the parameter is mandatory).

That was more or less how it was before, i think... I would let @rldhont comment on this approach. I find it easier to understand, but not sure if it might cause some issues in the QGIS server side.


:) cool , did not come up with something else ? i cannot test all cases for you :)


微信群的二维码过期了，可以更新下么？


This branch is not compatibility for version 2. So can you please use https://github.com/AIsaac08/bigdesk


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9435](https://teamcity.mesosphere.io/viewLog.html?buildId=93047&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:14:32


Add Mockito JAR to the project to run the tests  (https://code.google.com/p/mockito/downloads/detail?name=mockito-all-1.9.5.jar&can=2&q=)


You have missed the changes at cae29df7d984d20c2cb736498b37bfb42545d67a. Are you sure you have correctly rebased your code?


You have missed the changes at cae29df. Are you sure you have correctly rebased your code?


conn still not closed when errors are raised from request() (or getresponse())


my pleasure!


"coninience"


You can't, at least not without a lot of extra work. You'll at least have to install a unix wrapper like mingw, and manually install all the dependencies.


@bradenmacdonald `templates` ⟶  `template`?


SignV2 and SignV4 don't have to return req as it's not useful


Why? This commit merged by Google. What problem did you find?


Слушай, ну явное же дублирование этого кода в каждом наследнике. Совсем не ок!


Different comparison style across module.
We either keep the comparison style or change it everywhere.


This should not be removed
This is not the same... see the fc spec file. This refers to /run/nologin.*


$this->close() returns $this->_success
$this->read($session_id) might return $this->_failure , also on a new file might return an empty string.
So this fragment ( ! $this->close() OR $this->read($session_id) === FALSE) needs an update, I think.


@kittnz It's happens very rare, maybe it's related to #15172


Couple of empty lines.


These are things we are sending!


Are you sure about this one? Unless `foo` is a crate root, rustc errors with

```
foo.rs:1:9: 1:12 error: cannot declare a new module at this location
foo.rs:1 pub mod bar;
                 ^~~
foo.rs:1:9: 1:12 note: maybe move this module `foo` to its own directory via `foo/mod.rs`
foo.rs:1 pub mod bar;
                 ^~~
foo.rs:1:9: 1:12 note: ... or maybe `use` the module `bar` instead of possibly redeclaring it
foo.rs:1 pub mod bar;
```


@michaeljs1990 Are you talking about this commit or the one it fixes?


great，thanks！


To save you some time: this is already fixed on the master branch.


Please add "no-print" class if list gets folded (and remove "no-print" when unfolded)


@cpuguy83 shouldn't this be `||` instead of `&&` ? (I'm comparing it to the contrary of `if c != nil !daemon.configStore.DisableBridge && container.HostConfig.NetworkMode.IsPrivate()`)


The `? FALSE : TRUE` is not needed.
The comparison already returns either TRUE or FALSE.


I do not believe!


Why trim? Isn't the password ready to be used?


Maybe move these values to constant.


So, if maven has no proxies configured, it ignores the settings in pom.xml ?


hmm.. this (98 and 99) could be actually be merged. Obviously init_daemon_pid_file() are files_pid_file()

so we could just call files_pid_files($1) in init_daemon_pid_file(` ... ',` ... ') for brevity


Some CSW does not apply that rule.

eg. a GN3.0.2 with 19 records and requesting last record:
```
<?xml version="1.0" encoding="UTF-8"?>
<csw:GetRecordsResponse xmlns:csw="http://www.opengis.net/cat/csw/2.0.2" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.opengis.net/cat/csw/2.0.2 http://schemas.opengis.net/csw/2.0.2/CSW-discovery.xsd">
  <csw:SearchStatus timestamp="2015-12-15T11:44:08" />
  <csw:SearchResults numberOfRecordsMatched="19" numberOfRecordsReturned="1" elementSet="summary" nextRecord="19" />
</csw:GetRecordsResponse>
```

So this trigger infinite loop when harvesting some CSW.


Hm, will this affect the JSON serialization of `CargoTarget`?


Maybe move this value to a constant.


涛哥也是闲着没事来凑热闹啊！


@lucadegasperi Was this command ever moved into a separate package? I know I can just add rows manually but this was handy.


I'm reverting some commits for testing purposes


Bring this line to same single-quote style.


Nevermind, saw the next commit =)


Please improve this doc. Now it simply duplicate the type name.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 9437](https://teamcity.mesosphere.io/viewLog.html?buildId=93051&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 205 Build time: 00:07:37


TeamCity Xbim :: Xbim Geometry :: XbimGeometry [Build 108](http://xbimbuilds.cloudapp.net/viewLog.html?buildId=573&buildTypeId=Xbim_XbimGeometry_XbimGeometry) outcome was **SUCCESS**
Summary: Running Build time: 00:29:28


The `==` operator's  result is already either TRUE or FALSE.
So `? FALSE : TRUE` is not needed.
Moreover the whole check can be simplified to this:
`$quick_reservation = empty($user_quick_reservation)`


@Dartanjan no, but we've it on our todo list.


Actually this should really be changed to use DI:

```
public function __construct(\Dice\Dice $dice) {
    $this->dice = $dice;
```

As it will make unit testing this class easier. We can then use a mock Dice instance and test the validation without also testing Dice's internal methods (which have their own tests)


Well spotted!


Ok. Let's do it in next stage... :)


There is `mapNotNull`


Usually you won't need to ascribe types for "literal" collections.


Yep, the case is broken, it's removed on later. The branch is WIP.


Open question (I don't know the answer) - does indexWhere preclude a lazy solution that returns as soon as it finds the basement?


There is also `emptyList()` in Kotlin's prelude. Is there any difference between these two?


Footer shows up in dashboards, didn't see it