Hello,

The trouble is that the macro casts the length value to int -- so I think
it is a bug in the macro for OpenWRT.  I tried casting len to int as an
argument to the macro, but to no avail.  Anyway, let me know your preferred
approach, and I will try to build it under OpenWRT.

Paul.

On Sat, Dec 26, 2015 at 10:22 PM, Jeremy Lakeman <notifications@github.com>
wrote:

> I think nlmsg_len is uint32?
> (http://lxr.free-electrons.com/source/include/uapi/linux/netlink.h#L42)
> Though the documentation on NLMSG_OK does suggest that len should be an
> int.
>
> I'd rather drop the cast from the macro, and make sure we pass in an
> unsigned value as our argument. Preferably a size_t, since that is what we
> are comparing to.
>
> Yikes this seems to be a problem that should be fixed in the linux
> headers. But we have to live with the implementations that already exist.
> http://thread.gmane.org/gmane.linux.network/376842/
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/servalproject/serval-dna/commit/ef0a8a9b5754f260095e874a3ae43a272faad8e7#commitcomment-15163726>
> .
>


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1068](http://teamcity.monogame.net/viewLog.html?buildId=12947&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


This looks very much like the `CommandLineEditor`. Can we use that instead of creating a new one? I think the only difference is `ask_for_selection`, which you can feel free to change for `CommandLineEditor` to always select the first.


No that's right, we absolutely need s64 for update as not sending means not updating for an update call.
s64 for add is the only correct solution and I don't think a version bump is needed as htspv25 is not documented yet and therefore probably no other clients are using it. And ofc these are tvh dev builds, people running those will update quite frequently.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10321](https://teamcity.mesosphere.io/viewLog.html?buildId=98027&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:08:59


This looks a bit fragile. If we depend on the gem being installed, can't we instead just call `import-js-sublime-text`?


Noel, can you please make every line you've added conform to checkstyle?
We use spaces, but not tabs in Java code.


 #[zstack Test Bot Report] P A S S
 Integration Test Result:
Test Summary:

 TestSuite|TestCase | Pass | Fail | Timeout | Skip
 ---------|---------| ---- | ---- | ------- | ----
 Total|||||


I think we could use the `import-js` executable instead of making a copy.


#include


Lets stop generating debug strings if debug is disabled.


This is almost the same as `bin/import-js`. I think we can use that instead.


Thanks for cleaning up my mess!


Сделал проще:
https://github.com/nitrogen-project/android_device_lge_geeb/commit/80e0fd2517285c4e42cdc375207da31ec6372129


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10322](https://teamcity.mesosphere.io/viewLog.html?buildId=98028&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:04:09


Previously, performAction() was only called when _closeDataPtr wasn't a null pointer. Is it normal it's no longer checked?


This `processKey` used to be a pre-processing step, but now you've changed the rest of the function to be in an `else` block.


@SandPox Okay. I did not get any unrecognized SIM errors. It seemed to work fine on CM11. But I bricked the phone, so I can't develop on this phone unless I can unbrick it or find another one.. I tried to get rid of the red "!" at the top left corner of the screen when booting unsigned kernels. Looks like the bootloader is also signed and the "main bootloader" check if it is valid. Not sure why there is a backup bootloader partition, if it doesn't even use it.


Are you sure you wanted to replace that nested if by a single condition? If changes the behaviour if `_longWinInFront` is true but the other condition is false.


It might be better if it built all branches, but only complained with e-mails when something is wrong in master. Can Appveyor do that? It would kick ass if I could check if my branch builds on windows before I merge it...


These changes work when testing via duckpan, but unit tests fail.

```
t/URLDecode.t .. 1/?
    #   Failed test 'Deep: full ZCI object'
    #   at /Users/charlie/perl5/perlbrew/perls/perl-5.18.1/lib/site_perl/5.18.1/DDG/Test/Goodie.pm line 76.
    #     Structures begin differing at:
    #          $got->{structured_answer}{result} = 'äöü'
    #     $expected->{structured_answer}{result} = '���'
    # Looks like you failed 1 test of 1.

#   Failed test 'Query: %E4%F6%FC'
```


hardbricked? wow..
the ! are report by bootloader because there's no valid boot.img checksum, just open stock boot.img you'll see in the end of file there is some unknown bytes which are checksum (i think) when I modify some bytes in it then it have "!" when turn on, this definitely a checksum feature by samsung, just don't care about it


https://github.com/showdownjs/showdown/blob/master/package.json#L33
please check with author. thank you.


Oups, ok, it was also in the else statement. Sorry.


It may be possible that no change to the .form occurred. I actually do not see the vertical anchor attribute in this decomposed file...


Not the correct file.  Please change.


> Pro všechny prohlížeče postavené na jádře WebKit máme dobrou zprávu.

Nemáš zprávu pro prohlížeče, ale jejich uživatele, potažmo webové vývojáře. ;)

Jinak tohle mi, Martine, zas tak zásadní nepřipadá. Máme Picturefill, takže drobné posuny v podpoře prohlížečů není potřeba zmiňovat.


So you propose to change add channelId to s64 without another htsp version bump, making this change part of v25? This would be fine by me.

BTW: if you send me the htsp v24 and v25 changes text I will be happy to update the wiki.


уфф... не надо водки... XD


https://github.com/trevorlinton/webkit.js#license
please check with author. thanks.


looks like this section didn't get re-added. I can see the new phrase is now api key vs auth token too (a change in api 3?)


Super! Flexboxu prosím říkejme jen "flexbox". Není potřeba s velkým nebo jako "CSS flexbox".


Yeah, I know. I just tried to get rid of it by replacing the ! with a space.. :D I assumed it would load the backup if it fails, but nope. I tried every possible button combination with and without a SD-card that has the full eMMC backup cloned to it. Nothing. I have to get a Bus Pirate or something and find the GPS UART points. (Used as a debug console when GPS is disabled, according to kernel sources) Maybe I could access some kind of shell there and possibly restore the bootloader. Or boot the backup, so I can flash the main SBL. The bus pirate has JTAG too, so maybe I can use it if everything else fails.


Hi! Where did you get these patches? I get these errors:
drivers/cpuquiet/governors/balanced.c: In function 'get_avg_nr_runnables':
drivers/cpuquiet/governors/balanced.c:224:14: error: implicit declaration of function 'nr_running_integral' [-Werror=implicit-function-declaration]
   integral = nr_running_integral(i);
              ^
drivers/cpuquiet/governors/balanced.c: In function 'balanced_speed_balance':
drivers/cpuquiet/governors/balanced.c:261:41: error: 'PM_QOS_MAX_ONLINE_CPUS' undeclared (first use in this function)
  unsigned int max_cpus = pm_qos_request(PM_QOS_MAX_ONLINE_CPUS) ? : 4;
                                         ^
drivers/cpuquiet/governors/balanced.c:261:41: note: each undeclared identifier is reported only once for each function it appears in
cc1: some warnings being treated as errors


This changes the behaviour of the function. You can't replace this nested if by a joint one.


@kos59125 @MatsuuraKentaro ありがとうございます！この後はどうすればいいでしょう？


> CSS proměnné si pomalu, ale jistě získávají podporu v prohlížečích.

Tohle je diskutabilní. Zní to jako bychom je mohli brzy začít používat. A ono ne. :)

Spíše bych zmínil, že se zásadně liší od preprocesorových proměnných. To je podstatná informace. Jinak článek super, souhlas.


this is  a test


Wildcard import, against convention


@hhirsch Because none of these are even supposed to be compiled by GCC 4.x. **You** said we use C++14, which support is claimed by GCC only as of version 5.0+.
Unless you explicitly state that we must go back to C++11, I'll keep developing with C++14 features, even if they're not supported by outdated compiler versions.


yes


i doubt about bootloader would give any kind of "help" to give you chance writing bootloader back
beside.. what's bootloader you broke? SBL1 or SBL2? if SBL2 then you may still have chance to access SBL console, if SBL1 like me then you're doomed

the microusb port are UART port, need a resistor to short pin 5 (unused) with GND to make it go to specified mode, I only tested with 560kOHM resistor which give me access to standard linux UART shell, in your case then it's useless

more info here
http://www.de7ec7ed.com/2013/09/uart-dongle-samsung-galaxy-siii.html


> S CSS moduly tento problém odpadá. Už nikdy nebudete muset myslet na to, zda omylem nepřepíšete styly někde jinde na webu.

Netýkají se CSS modules náhodou jen psaní aplikací? Myslím si to, protože vycházejí z čistě javascriptového stacku.


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1068](http://teamcity.monogame.net/viewLog.html?buildId=12947&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 555, ignored: 6 Build time: 00:30:01


What's wrong?


why not to post the handler to the io_service?


I think that that's what we concluded at the time.
Where would you put it? noarch? we do not have binaries there?
Have a new pet list/dir?


Martine, "Javascriptu/JavaScriptových" prosím vždy česky jako "Javascriptu/javascriptových". Jinak bezva trik, díky za vydolování. :)


> Přednáška poskytuje hned několik rad a zajímavých triků, jak se dá toho docílit. Ukazuje ale také věci, kterých je dobré se vyvarovat.

Marťas, tohle je takové moc obecné, dá se napsat k čemukoliv. Nevytáhneš místo toho z videa nějaký konkrétní trik co tě tam zaujal?


就先 0.5 cm 和 0.3 cm 吧，我后面边写边看看是不是有更好的方式...


We settled on a compromise of using some C++ 14 features that are in 4.x until we switch to 5.x in a few months when the server will support them.


Do people use Package Control for managing packages in Sublime? I read this tutorial that suggested publishing it there: http://code.tutsplus.com/tutorials/how-to-create-a-sublime-text-2-plugin--net-22685


That's nice. I made another commit here: https://github.com/molinch/FFImageLoading/commit/bf1ae880a2a61a3acad2584e27717f019272fa20


IntelliJ does it for me, but alright


@SandPox I broke SBL1.. SBL2 is just a backup of SBL2. I had a USB-UART adapter (that I fried on my old router..) and I had tried the MicroUSB-port, but I only got this:
AST_POWERON
Decompressing kernel..
etc.
Maybe the GPS UART will show something else. I think I know where it is, as I was probing some points with a multimeter and saw voltage jumping around 1-1.8 volts on one pin when booting and it settled to a steady 1.8 volts. It looks like it might be outputting something.


Is symlink an option here?


Is there a reason why standalone-package js is blank?


hmm.. that's what I got too, try with different resistor value in the table in gave you, let me know if you have something interesting


Oui je fais des essais ça risque de casser un peu


Copy-paste error :)


Pěkný! Vylepšit by se to dalo  zase jen o fous větší konkrétností. Třeba zmínkou, že to dělá pomocí "Enable Paint Flashing" a záložky Timeline v devtools.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10323](https://teamcity.mesosphere.io/viewLog.html?buildId=98029&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:03:50


oh ok :) j’espère tu va y arriver ^^


看见了


@PZerua Thank you for noticing!


@chinedufn


@ksooo
https://github.com/Glenn-1990/tvheadend/commit/eb7d1c444c8f973073011fa74299a9a013bb1284
What do you think? "channel" in the build_autorec/timerec methods will stay u32 as this should be clear enough and should stay the same as build_dvrentry


Ok can you add one more line


Isn't that already done in https://github.com/Zarel/Pokemon-Showdown/blob/master/mods/gen2/typechart.js


Hmm. My goal was for the 'backports.unittest_mock' to provide the platform selection to avoid these conditional (non-declarative) requirements. I can see how adding this complication might simplify running tests in some test environments, but I'd prefer the slight inefficiency over the less readable and imperative code.

What's the impact of not accepting this change?


Why it is only for *BoundaryEvent*? What about *IntermadiateCatchEvent*?
With Start Listener engine adds this activity to the history.
This test will be failed if we check signal activity:
`historyService.createHistoricActivityInstanceQuery().activityId("signalEvent")`
I think it should be for *IntermadiateCatchEvent* too or just for common *Event*. I've tested it with *Event* - it's ok and all activities are in history.


I tried it out locally, and it looks like `message` is handled differently too. But that can be changed to a no-op. Nothing is using the `CommandLineEditor` at the moment.


@Snekili given that Article 17 looks to have been dropped are you sure the article numbering is still correct - e.g. should old Article 18 now be numbered Article 17?

Ans: I've actually just checked the PDF http://unfccc.int/resource/docs/2015/cop21/eng/da01.pdf and the answer is that you are absolutely right here - they just dropped article 17 and did not renumber!


I tried it out locally, and the only thing we need to change is avoiding to reset stdin. We need to handle prompting the user in a different way anyhow, so we can just make it a no-op for now.


Yes, I moved the preprocessing step code above


Thanks a lot! :smiley:


Comment to explain what is the method for?


Okay. So after using an independent diff checker (diffchecker.com) I see that 79 deletions, 91 additions occurred. Almost all changes where done by Access and are in the binary portions of the decomposed form.
The only change that appears to be explicitly done by my update is  the removal of "VerticalAnchor =1" from line 1106.


No. Before this commit, the `processKey` call would be done, and then the large block of ifs. Now, the large block of ifs is skipped after the `processKey` call.


Google


Imports DAO
Imports DTO_DoAn

Public Class BUS_HocSinh

    Shared dt As DataTable
    'Xuat danh sach cac hoc sinh trong lop hoc
    Shared Function Bus_XuatDanhSachHocSinh(ByVal malop)
        dt = New DataTable()
        dt = DAO_HocSinh.DAO_XuatDanhSachHocSinh(malop)
        Return dt
    End Function
    'chuyến đổi từ datatable thành mảng
    Shared Function Datatable_Mang(ByVal data As DataTable)
        Dim array(data.Rows.Count() - 1) As String
        For i As Integer = 0 To data.Rows.Count() - 1 Step 1
            array(i) = data.Rows(i).Item(1).ToString()
        Next
        Return array
    End Function
    'thêm một học sinh mới vào lớp học
    Public Shared Sub Bus_ThemHocSinh(ByVal hocsinh As DTO_HocSinh)
        DAO_HocSinh.Dao_ThemHocSinh(hocsinh)
    End Sub
    'xóa một học sinh cụ thể
    Public Shared Sub Bus_XoaHocSinh(ByVal mahs As Integer)
        DAO_HocSinh.Dao_XoaHocSinh(mahs)
    End Sub
    'xem kets qua hoc tap cua mot hoc sinh
    Public Shared Function Bus_XemKetQuaHocTap(ByVal mahs As String)
        Return DAO_KetQua.Dao_DocKetQua(mahs)
    End Function
    'xem thong tin chi tiet cua mot hoc sinh
    Public Shared Function Bus_KiemTraHocSinh(ByVal mahs As String)
        Return DAO_HocSinh.Dao_KiemTraHocSinh(mahs)
    End Function
    'luu thông tin trong datagridview xuống database
    Public Shared Function Bus_Update(ByVal dt As DataTable)
        Return DAO_HocSinh.Dao_Update(dt)
    End Function
End Class


Comment to explain what method is for?


I tried with 150K and 619K, but I still got the same results.
Hmm.. Maybe it is possible to replace the eMMC with a microSD card? I have seen people do this when their eMMC has died. If I just solder in a microSD-connector, I could just take the card out, rewrite it on my PC and pop it back in if I fuck up something.


Add a comment here.


For this virtual client you're releasing today, will it have a damaged OEP also ?


what? replace the... EMMC chip with SDCARD? never heard of it without an adapter, could it be? the pins just too much different...
EMMC could be write by solder it on compatible pin USB Flash Drive board, it's just a flash chip


`mv` is missing here


Nice. :+1:


Not effective yet always True if no buyable period applied? IIRC this means the buyable item is not buyable yet.


Good job man!


Thanks for the feedback! Changes are pushed.


I am glad that it is helpful for someone. :)


As in a loop statement using `i++` or `++i` is the same, I like to keep the most common form `i++` as it may confuse people, but that is maybe just me.


Если хотите, чтобы вместо баффов показывались ваши дебаффы, ставим в настройке дебаффы:3, баффы:0. Если же не выставить у баффов 0, то дебаффы будут высвечиваться выше фрейма босса.


Hm, strange that my build environment didn't complain about this...


Don't use inconspicuous terminology from other domains when there's a simple way to explain something to most people.


Thanks for the link! This is great!
I really need to use more functions. That should already improve readability so much more.

Here's another great resource I've been using lately:
https://google.github.io/styleguide/shell.xml


Aside from the issues of not seeing the diffs in this view, the insane amount of auto-changes made by Access might make the diff feature for anything other than code changes (.bas) unusable / unhelpful. So, it might not be a *huge* deal that we aren't explicitly seeing the diffs on forms: it's actually "too much" change to be consumable.  I also see that the form filter for the [assigned PDC] is exposed. I would actually expect that the form would be exported without the parameters under which it was opened. These will register as "false changes" as they really aren't changes to the form, but parameters that got stuck in the form on decompose.


typo


Write a program that lets a maker of chips and salsa keep track of sales for five different
types of salsa: mild, medium, sweet, hot, and zesty. The program should use two
parallel 5-element arrays: an array of strings that holds the five salsa names and
an array of integers that holds the number of jars sold during the past month for each
salsa type. The salsa names should be stored using an initialization list at the time the
name array is created. The program should prompt the user to enter the number of jars
sold for each type. Once this sales data has been entered, the program should produce
a report that displays sales for each salsa type, total sales, and the names of the highest
selling and lowest selling products.
Input Validation: Do not accept negative values for number of jars sold.


Use `{}` with if and else even if you have just one line.


Good job :+1:


@fabpot I assume you changed your mind about which branch you wanted it merged into?


Space between `()` and `{`


(Sorry for the duplicate message; the first one looked like it had timed out here, but apparently not.)


their encoders can be removed too ? https://github.com/MSM8226-Samsung/android_device_samsung_msm8226-common/blob/cm-13.0/msm8226.mk#L103
@zwliew


Yes, if you follow the code logic you'll see the new code has the exact same results


interesting


I can't verify this right now, I'll recheck later


nice! more https is always good!


А что изменится, если убрать эту строку? То есть, зачем она нужна, если мы и так всегда возвращаем false для неадминов?


I'd prefer we didn't use webpack to bundle such assets. (There are various reasons for this, I can elaborate another time.)


Update package references


Years


Are you sure that it's correct compare int64_t to uint32_t ? Signed & unsigned...?


I did, and it doesn't. (In particular, it breaks the tab key.)


deleting .class file


음 이미 업로드되어 있어서 올렸다가 다시 지우신 것 같은데 revert 하시는 중 tex 파일까지 지워진것같네요 ㅠㅠ


Thanks for catching this also.
Was getting late and bed was calling me...


May be change `#include <string.h> -> #include <string> `?


May be const?


So not having the `respond_to` corrected would indicate a server side problem.  You can tell if this is the issue by checking

1.  Are there any errors in the server log?  Does it show something like `Completed 200`?
2. In the browser dev console, network tab, do you see a successful response?  If so then this is likely an issue with the javascript running in the browser, and not the ruby on the server.


Ref. #52


@SandPox Well, I wouldn't do this to a working phone.. But if you have two, or more of these phones and you can resolder the eMMC back on the board, you could try it. I am not sure if it will read the SD-card straight away, or if it needs some more modification.


@globin, @exi did this already https://github.com/NixOS/nixpkgs/pull/11951


I would force-convert the value to integer here like this: `@context.itemsPerPage = ${q(node).property('itemsPerPage') > 0 ? String.toInteger(q(node).property('itemsPerPage')) : 24}`

Perhaps the same should be done with other properties like `limit`, just to be safe.
Also maybe it makes sense to add validation to nodetype configuration of other properties.


사라진 tex파일을 다시 올렸습니다.


:wink:


No problem! I was working today (I'm in software support) with very little actual work to do. So I was able to play with your latest updates.


Please make sure to indent consistently, using 2 spaces.

It looks like you know where to indent.. but used 3+ plus spaces for line 10 and only one space for lines 11 and 12


Line 9 should actually be indented to the same leave as line 7.  Did you notice there is no `end` corresponding to the the `factory :user do` on line 2?  That means that lines 9-14 are actually inside that `user` factory.

This is desired because it allows `user_with_post_and_comment` to share some of the same properties with use `user` so don't have to redefine them 2x.

Another code smell is that lines 15-16 have `end` indented at the same level.


I think this will never happen, as `$content` is encoded as JSON, XML or other, and it is unlikely to be `"0"`. But it makes the code cleaner accordingly with the comment above.
Not easy to produce a test...


Better worded this way.

```
// For an incorrect region S3 server always sends back 400.
// But we will do cache invalidation for all errors proactively.
```


@zolotov what if we have a statement like this:

```go
if true {
	println("")
} else if true {
	println("")
} else if true {
	println("")
}
```

or if the if / else block is less than 2-3 lines of code (so not much to fold in the first place).


What happends if it fails to sync the latest commits? Or if it fails to compile? Or if the server crashes completely during an update? Will it do a proper compile when there's new assets/maps?
It is a bit scary to run unsupervised updates with no access to a shell to fix any problems that might pop up.


@djc that's the plan. Pillow is using the same module syntax.
Thanks for the comment.


基于局域网络安全日志的审计


> what if we have a statement like this

Obviously it will be fold, what's the question?

> or if the if / else block is less than 2-3 lines of code (so not much to fold in the first place).

I didn't reimplement block folding algorithm, it works for `if`-blocks in the same way as for other blocks


did this fix it :3 @DavidVazGuijarro


@RobotXLabs shhhhh... in [version 2 they said nothing about that](https://github.com/twbs/bootstrap/blob/b4c4072679943773a7582daa63f545ba818fa627/docs/getting-started.html)


ainda falta criar novas telas tf para implementar nos actions listeners, assim como arrumar a tela adicionar novo usuário de grid para null e fazer os posicionamentos manuais, ou simplesmente reduzir  o tamanho da tela.


Inspect should return a `String` object.


you can delete this.  Remember we just added this code temporarily for debugging


This is causing a crash on exiting the game for me. Strangely, this happens only with a release build, with a debug one there's no such issue.


This seems to break non-context scrolling. If the context === window, my `scrollHeight` and `offsetHeight` for document.body are equal, which means we're doing `Math.min(end, 0)`, thus our end is always 0.

Apologies if I'm missing something! Thanks for the great commits and PRs!


Branches should be fixed in next commit. Emails can be set only by Appveyor users themselves and there are three options: Notification on all builds, do not send notification and send notification only on my commits.


Are you missing a slash here?


Also created a separated method to create the #mainHeader


# Smell - Readability - Perf: Use a setter instead of complicated multi line array into an `Enumerator`:

```ruby
array = [:val1, :val2]
array.flatten.method do |blah|
  # Work
end
```


build sub project could be the solution ?

in QtCreator
1. select project node in tree view
2. build the sub project from context menu or build menu

root project can do build full


Smell - Major Perf: Use `Enumerator#each_with_object`
```ruby
hash.each_with_object({}) do |(key, val), hash|
  hash[key] = val unless hash.key?(key)
end
```


Yeah, just noticed this as well. This change doesn't exist in 5.2 nor the master branch at this stage.


I guess it got reverted for some reason. I propose we remove this note from the 5.2 docs, add it to the 5.3 upgrading guide, and make the change on laravel/framework's master branch.


Shouldn't these urls be added only if DEBUG ? In Django docs, this is advised "for development": https://docs.djangoproject.com/en/1.8/howto/static-files/#serving-files-uploaded-by-a-user-during-development

If the production server is misconfigured and doesn't serve media files statically then Django would serve it and it wouldn't be obvious that they are not served statically.


@triska Danke für den Hinweis. Ich werde diesen Tip an meinen Prof. weiterleiten.


Just made a PR to remove this from the docs. Is there a good reason to actually make this change, or is it possible to take a second argument that can disable this? A common use case is for pointing to your assets on a CDN with another domain name.


Smell - Breaking Default Behavior - Logic Error: Do not raise in `<=>` unless necessary, `return nil`.
```ruby
"string" <=> 1 # => nil
class MyClass
  # Empty
end

MyClass.new <=> 1 # => nil
```


Smell - Obfuscated Setter: Do not use setters in if..elsif it confuses a user who can misread it and it can lead to eventual mistakes where `=` is corrected to `==` or the verse.


I would recommend to use the username in the url, ie. <username>/settings/, because then you could open that setting page as an admin - if you authorize it in the view - and that could make debugging easier.


Smell - Encapsulation - Optional - Suggestion: Errors should be encapsulated globally on an Errors class so they are obviously spotted and easily organizable as they grow.


where is the change ?


Smell - Old Usage of Raise - Do not raise Class.new("Msg") - Use Arguments
```ruby
raise Class, "Msg"
```


I think I'm missing something here... I'm seeing the addition of the IndicesModule.registerMapper() method, and you adding an 'onModule()' method to a few pluggins, but how are those methods called? It's not part of the Plugin interface... How do I register a new FieldMapper?


great,how fast now :dancer:


it takes from the method name the field it has to query on


This commit broke some integrations tests. Please check http://ci.ops4j.org/jenkins/job/org.ops4j.pax.jdbc/120/


It doesn't matter if you use single or double quotes, but it's good to pick one of them and stick to it
https://www.python.org/dev/peps/pep-0008/#string-quotes

> In Python, single-quoted strings and double-quoted strings are the same. This PEP does not make a recommendation for this. Pick a rule and stick to it.


Update manually


If you're only supporting python2, then maybe this could be misleading to a user who would try it on python3


why not merging??


The testsuite would previously raise the new `.cmx`  warning of #319 while running. I find it a bit troubling that we missed this -- the testsuite still passed despite raising new, unplanned-for warnings.


Hahaa xD

> Am 26.12.2015 um 14:58 schrieb MrDoni98 <notifications@github.com>:
>
> уфф... не надо водки... XD
>
> —
> Reply to this email directly or view it on GitHub.
>


I don't think so. Some tags use material icons, some don't. From my point of view, adding another separate component will only add unnecessary complexity. At the end of the day, you need to determine the class name, url, and an icon anyway.


Hello


This file should be place in the acc folder.


G


ack


I revert the details with the header to avoid duplicating the code to show the Revision Content both in positive and negative branch of the if. This way I can just test if it's a template and expand the detail by default.

I'm not sure if it's the best way to do it.


Just write code with a `get` that returns `0` and see if the response is `0`. :)


@kalashnikovisme лучше вместо if signed_in? ... redirect_to ... сделать первой строкой authenticate_user!


Is there a standard for how properties should be treated when no longer needed?


So it appears the issue was with the .gitattributes folder. Over-writing a file still not giving expected diff output.


NotificationsController::create?
This is very very wrong. Controller cant be used with create. Model should be used


I am debugging a minidump using CLRMD and I am getting ``` _firstChar ``` null. This causes to break the if condition and we get a Object null reference exception -
``` if(_firstChar.Type == null) ```

In what scenario is _firstChar null and should we be handling the scenario here?

I ran the minidump using other tools and it was able to analyze it properly.

Let me know if should create a issue for it.


Not sure if Django doesn't already use the prefix automatically


that is already done in my other test. This one is under serializer, and to_json, for example, will complain if the scalar is not a hash ref or array ref ;)


帅啊


удалить бы нафиг


readme


Why was this change made? Several applications do not require polyfilling process.env.NODE_ENV and not even going to mention the applications that only use Node.js for prerendering (eg. ASP.NET 5+)


This file mustn't be pushed


Conversation


It's a classification used for the European Fisheries Fund 2007-2013 (see [here](https://github.com/openbudgets/data-model/blob/master/spending/eu-fishing-subsidies/eu-fishing-subsidies-dsd.ttl#L43-L47)). Example concepts from this classification are [here](https://github.com/openbudgets/data-model/blob/master/spending/eu-fishing-subsidies/eu-fishing-subsidies-data.ttl#L96-L117).


thanks


Is this really required ? With non abstract user it's not needed:

![2015-12-26-175550_643x161_scrot](https://cloud.githubusercontent.com/assets/94636/12007033/df30b1b4-abf1-11e5-820e-3a1c644d8767.png)

User.username is unique already: https://github.com/django/django/blob/master/django/contrib/auth/models.py#L307

If you're using this form outside the admin, maybe it should be in forms.py, but then again please check that it doesn't check for uniques by default cause it would make sense for django to do it so that might as well be the case and *please* let me know when you find out !


I deleetd this


路过->如果


I added this to make it longeer


Tea, I agree this is the best solution.
I'm too used to CONTROL + R shortcut in QtCreator, but this shortcut run (and compile the changed files) the entire project. I check the google and is not possible execute just the current subdir. So the solution is open just the subdir I will work, and use the Jamtaba.pro only when is really necessary.

Thanks for the discussion, is something very little and easy, but sometimes we need help (clear eyes and mind) to see the solution.


@ahmetilhann dil desteği vermeyi düşünüyor musunuz? Bana biraz gereksiz gibi geldi ama yaparsanız 4-5 dile çevrilmesini sağlayabiliriz.


Good idea.


Sorry, was going to tell you about that as I noticed it.


Not sure if you need that in every file ^^


Vraiment nécessaire de parler des affaires internes dans un guide FOSDEM ?


No trouble, thanks for helping out


remove this


C'est vrai que c'est pas nécéssairement nécéssaire


@idisblueflash  @zoey4lee

先适应一下ES6，然后就可以换redux了

欢迎补充：
https://github.com/2remote/yaopai-mobile/wiki/How-to-write-React-using-ES6


remove this.. prefer using debugger over dd statements


This is wrong, it only works with your pc since the path is relative, check the Utils/Testing form to see how a new row should be added, also dont forget to do sync first.


format it properly, wrong indentation


# N/B

If anyone looks at this, this was a mistake on my part. I was working off a fiends server which was loaded with his SSH key, so even if I committed with my login credentials, the SSH key took precedence.


@kalashnikovisme лучше делать функции без _not_ , ибо такое !submissions_petitions_not_begins? сложнее читается, чем !submissions_petitions_begins?


Still lorem ipsum here :dancer:


I still use `g:pathogen_disabled`. Do you want to abandon it in next commits?


Commented code should either have a comment to describe why it's commented either be removed ;)


this isn't needed..


“你为什么这么熟练”


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10324](https://teamcity.mesosphere.io/viewLog.html?buildId=98034&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:07:54


Thanks, but as I wrote here, the one comment is not correct.


Oops, thanks for the heads up. Will fix and add some tests before creating a PR.


thanks


Díky za feedback. Odeberu to.


Is this a known bug?  If y, can you link to it?  (as in #coreclr/1234)


<img width="941" alt="2015-12-27 00 11 23" src="https://cloud.githubusercontent.com/assets/165936/12007081/b44f2344-ac2e-11e5-9060-7e79630114e2.png">

這邊不能這樣改，這樣會讓預設狀態的圖片文字位置變得很怪，像是壞掉了
比較好的作法是改原圖，或讓背景圖片改用下方對齊


:+1: oki


This will potentially fail on android, we need to throw away this error.


Commented code without comment !


oki :+1:


现在 tag 比较明显了~辛苦了~

标题栏上的状况可能需要修改成下载状况比较合适
试试 蓝 / 红 / 绿 三个颜色标记一下吧
另外那个头像，不是固定高度的，在图片加载出来之前会有一瞬间变扁，修一下吧~


The script fetches the latest commit and parses the changed files for any resource files added (sound and dmi). If none are present then it merges and recompiles the server, redirecting output from both to ".getupdatelog" verb.

Since byond only saves changes to the .dmb file on successful compiles we don't need to worry about failed compiles.

Only devs and admins will have access to it, so it's really it should be fine. If it works well, I might hook it to escape shuttle launch.


Hi, There is a bug in GTA SA when player is immune to Tear Gas and MTA Fixes that, where's that patch located? And also, When crouching, and zooming with sniper rifle, the player stands up, I Would like to have them for single player, Thanks.


500 的 delay 是不是有点慢了，感觉设置成 0 都 ok，现在加载完后跳到顶部有时会有一瞬间看不到列表头
![image](https://cloud.githubusercontent.com/assets/1846356/12007092/274fdc58-ac2f-11e5-959a-da879abed19b.png)


the space around equality is also not like usual.


Musím si dát na ty nepřesné formulace víc bacha. Díky za kritiku, zapracuju na tom do příště.


space after the closing `)`


![image](https://cloud.githubusercontent.com/assets/1846356/12007096/5578c36a-ac2f-11e5-80c7-fbef52831149.png)
这里 rss 好像还是不怎么居中


Ah, alright. @AudriusButkevicius
Will fix :)


@kalashnikovisme с .where.not(state: :removed) эти скоупы выделяются на фоне остальных, и их сложнее комбинировать, лучше его бы убрать.
 Тем более что здесь https://github.com/ulmic/ulmicru/blob/6c1c7eb55e8622690fe7ab532d9fd7b551cb5617/app/controllers/web/admin/events_controller.rb#L8 , например, ты всё равно используешь `::Event.presented.future`


You can define new mode names here such as "paranoia" if you want: PyLink simply stores most modes and doesn't really do anything with them.


Imho the commented block below should be extracted into a function. It's equivalent to what is done above (with the same comment).


Ještě to tam přidám


So this will redirect to /list which will redirect to /list/ ? Maybe with url="list/" it would save a redirect.


Not exactly. One works on a QVariant, one works on a QString, but I will try to look at it.


TaskCluster-GitHub: https://tools.taskcluster.net/task-graph-inspector/#PllaUaL2SX6H_Lce56BsaQ


You should add `self.hook_map = {'EOB': 'ENDBURST'}` into `__init__`. That will automatically send all hook data returned by the `EOB` handler to plugins listening on `ENDBURST` instead.

(I should write more documentation on this really)


Yeah. Just ignore any error return on that one.


Určitě. Přepíšu to


Thanks! BitHub has sent payment of  $29.11USD for this commit.


Agreed.

Just saying though, in your mentioned case people could still track the HTTP confirmation requests and extract the device ID from the query parameters.


This could crash if no Legend object is found raising Legend.DoesNotExist


add theese two commits and the build error is gone:
http://gerrit2.xenonhd.com:8081/1407
http://gerrit2.xenonhd.com:8081/1406


İstek geldiğinde yapabiliriz alt yapı hazır.


I wonder how the ^\d+ strings will render here


@kalashnikovisme confession.member.decorate - не оч круто. лучше https://github.com/drapergem/draper#decorating-associated-objects


稍微縮減高度 ca6eb4ad80f86a97f56a6c2218d04e456323eb3f


It is still possible to assign any value to either message.version and message._version


Sehr gute Änderung


I've raised an issue for the same - https://github.com/Microsoft/clrmd/issues/37


@phase :D Yeah, I know. However, I wasn't testing this locally. I was pushing a single commit to the repo so AppVeyor and Travis would run. Then, when they failed, I'd push *another* commit.


We don't use ExclusiveGroup on quest_template in this case?


what's the difference between self_ and _obj?


Teď podobná otázka padla na {f}rontendistech a odpověď byla, že se to dá použít i pro web. Osobně si to ale také nemyslím. I když můžeme použít renderování na serveru, javascriptový stack je nutností.

Souhlasím, formulovat to pro použití jen v aplikacích bude lepší.


@kalashnikovisme а зачем state: removed, первый where(state: :unviewed) же должен уже удаленные исключить?


fc96355990a51fdfea9915f8d8ea311c77859f14 @carlos-bsb carlos-bsb committed 2 minutes ago


cool


Unfortunately uint32_t is not a valid type in VS2013. UINT32 is a valid type. Do we need to make this a conditional type or is there a wx portable type that can work?


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1069](http://teamcity.monogame.net/viewLog.html?buildId=12951&buildTypeId=MonoGame_DevelopWin&guest=1) is now running


@kalashnikovisme а зачем такие скоупы, они же должны автоматически концерном добавляться?
Надо только   include TeamScopes в модели делать после объявления всей стейт машины


You should disconnect previous account too if present :)


I could make an option for that? What do you think?


isClass will change soon to isType as what we are looking is the type of an object, also isClass isn't used like this, it's used this way: isClass( element, 'Array'  ) which return true or false.

Thank you for your help, but this pull request isn't right.


Oczywista porażka. Serwer i klient się wzajemnie blokują, próbując na raz wysyłać wiadomości.


Changement de routes.
le GET était pour le test


plot сейчас находится не в том цикле - он должен выполняться m раз


@klightspeed and @FezVrasta review. Better solutions?

Example output of the JSON format:
``{"running":"yes","listening":"yes","serverName":"ARK Server - (v228.2)","maxPlayers":"70","online":"yes","version":"912764"}``


That's the idea, though I don't plan to rip it out until I am ready to do a backwards incompatible release.


MySQLとSQLiteで実行結果が違うぞ :anger:


According to http://doc.qt.io/qt-4.8/qmainwindow.html#addToolBar-2 that is equivalent to calling ```addToolBar(Qt::TopToolBarArea, toolbar)```. Afaik we call setupView quite liberally so I would imagine this to undo any customization.


I didn't mean anything. I only patched up florin's dependency files.

But yeah, this should probably be CUDA-OpenCL-headers.
Thanks for the review! I changed it.


Are you facing this issue because of this commit?


Nice catch :)


I would probably be better to use an interface for this


Модуль 5


hold on вызывается m*n раз - это не эффективно
лучше его вызвать один раз на старте приложения


I'm not trying to prevent other applications from launching the PasswordActivity.


Can we do that in 3.2 this way?


With an interface? Yes. We just make the entity class implement it


http://build.zfsonlinux.org/builders/Ubuntu%2014.04%20x86_64%20%28TEST%29/builds/261/steps/shell_2/logs/make

This error doesn't make any sense !

```
/tmp/zfs-build-buildbot-mQEbFDAO/BUILD/zfs-kmod-0.6.5/_kmod_build_3.13.0-48-generic/../zfs-0.6.5/include/sys/dmu.h:48:30: fatal error: sys/zio_priority.h: No such file or directory
 #include <sys/zio_priority.h>
                              ^
compilation terminated.
make[7]: *** [/tmp/zfs-build-buildbot-mQEbFDAO/BUILD/zfs-kmod-0.6.5/_kmod_build_3.13.0-48-generic/module/zcommon/zfs_deleg.o] Error 1
make[6]: *** [/tmp/zfs-build-buildbot-mQEbFDAO/BUILD/zfs-kmod-0.6.5/_kmod_build_3.13.0-48-generic/module/zcommon] Error 2
make[6]: *** Waiting for unfinished jobs....
  CC [M]  /tmp/zfs-build-buildbot-mQEbFDAO/BUILD/zfs-kmod-0.6.5/_kmod_build_3.13.0-48-generic/module/zfs/blkptr.o
In file included from /tmp/zfs-build-buildbot-mQEbFDAO/BUILD/zfs-kmod-0.6.5/_kmod_build_3.13.0-48-generic/../zfs-0.6.5/module/zfs/blkptr.c:21:0:
/tmp/zfs-build-buildbot-mQEbFDAO/BUILD/zfs-kmod-0.6.5/_kmod_build_3.13.0-48-generic/../zfs-0.6.5/include/sys/zio.h:32:30: fatal error: sys/zio_priority.h: No such file or directory
 #include <sys/zio_priority.h>
```

the file is there :question:


Dang. I did this because in order for the "movable" property to take effect, I have to re-add it.

Unfortunately, there does not seem to be a way to get the current toolbar area from the toolbar.

I'll look into this.


I was wondering about the BC part and how BC breaking that might be with an interface solution vs soft-check approach.


Сейчас все edittext'ы имеют tag (имя переменной), что в будущем может и приведет к путанице
Лучше их заменить на (тип ui control'а)_(имя переменной)
Например, lambda -> edittext_lambda


usless


optional


....but `MonoEQConstraint` (and future `SPEQConstraint` classes) also inherit from `OneEqConstraint`...


seems like its worthing


Ya peut-être moyen d'utiliser le `default_authorized_parties` de cette façon :

```
has_one :comment_owner, through: :sender, class_name: 'User'
has_one :post_owner, through: :post, class_name: 'User'
default_authorized_parties :comment_owner, :post_owner
```


It inherits from both, because it can be either.


makeCacheMatrix <- function(X = matrix()) {
  inverse <- NULL
  set <- function(Y){
    X <<- Y
    inverse <<- NULL
  }

  get <- function() X
  setinverse <- function(Inverse) inverse <<- Inverse
  getinverse <- function() inverse
  list(set=set,get=get,setinverse=setinverse,getinverse=getinverse)
}

cacheSolve <- function(X, ...)
{
  ## Carregando a função
  if(require("corpcor")){

    print("A função está carregada corretamente.")
  } else {
    print("Tentando Instalar a Função...")
    install.packages("corpcor")
    if(require(corpcor)){
      print("Função:corpcor instalada e carregada...")
    } else {
      stop("Não foi possivel instalar a função...")
    }
  }
  inverse <- X$getinverse()
  if(!is.null(inverse)){
    message("matrix is in memory")
    return(inverse)
  }
  message("inverse is not in memory so the inverse (if exist) is gonna be computed")
  data <- X$get()
  inverse <- pseudoinverse(data, ...)
  X$setinverse(inverse)
  inverse
}


Сейчас все переменные заполняются по коллбеку - т.е. нужно заполнить каждое, что не ок
Все переменные нужно заполнять значениями по умолчанию при старте приложения


Сейчас много неиспользуемых функций, например, (имя)_CreateFcn
Убери их из .m и .fig файлов


@bbatsov, thanks for pushing me to look at this closer.

This code is from @jonas054. His intention was that if a percent string contains `"` and escapes (like `\t`), then it shouldn't be flagged. It can't be converted to a double-quoted string because of the `"`, and it can't be converted to a single-quoted string either, because of the escapes.

BUT! There is *always* a "but".

There is no such thing as escapes in a `%q()` string. `%q(\t)` has 2 characters, not 1. So this code erroneously suppressed warnings for `%q()` strings. For `%Q()` strings, it was correct.

I have updated the PR according to the above. Just as @jonas054 intended, `%Q()` strings with embedded double quotes and escapes are not flagged. BUT, we are doing even better now, since gratuitous escapes *are* flagged. Like `\x68\x65\x6c\x6c\x6f` for `hello`.

We allow double-quoted strings if: there are embedded single quotes, OR there is a character which is only printable using escapes, OR there is a character which is printable without escapes, but doesn't appear on a standard keyboard. The same principle is applied to `%Q()`.


resources :comments, shallow: true, path: "relationships/comments"


your api key is still visible here :P


ありがとうございます！　文章周りとか基本的なところが落ち着いたら具体的にお願いするようにいたします～


L14-L22 supprimable


I spoke....before.... :P


Bloc bad parameters supprimable


I don't understand what you mean. Is there a specific problem you have? Node everironments have this field specified. For CommonJS in-browser build you can tell your bundler (Browserify, Webpack) to fill it in. For the UMD build you don't need to worry about it at all because it is pre-specified during the UMD compilation. What is the problem?


here it should be `"running": true` or `false`, use booleans, not strings, when possible.


Nice.


OMG Who is that ???


because all conditions must be met since all are negative.


numbers don't need the `"` around them


TeamCity MonoGame :: Develop (Win) [Build 3.5.0.1069](http://teamcity.monogame.net/viewLog.html?buildId=12951&buildTypeId=MonoGame_DevelopWin&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 555, ignored: 6 Build time: 00:31:48


as in DB the id is a 'small int', maybe it could be number already here? same goes for show ids, and all other ids..


This wasn't needed.


Looking good :clap:! This site is :100:


dssdsd


I don't like all these repetitions...  What if we always output **JSON** and then we convert it to simple stdout when needed?

We could have all the functions returning JSON, then, a single function to convert JSON to plan text.

eg:

status will output: `{"running": true,"listening": true,"serverName":"ARK Server - (v228.2)","maxPlayers": 70,"online": true,"version": 912764 }`

then, the JSONtoText function could convert it to:

```
Running: Yes
Listening: Yes
Server Name: ARK Server - (v228.2)
Max Players: 70
Online: Yes
Version: 912764
```

I don't think it would be so difficult to accomplish... We may ask help to @klightspeed maybe?


# AWESOME!
Now I can play _Pixel Quest_ right from my GitHub! This is an awesome :christmas_tree: present!


Is this artist or album?


func를 쳤는데 fun이 되어버린건가...


Yeah that would be a lot better.


Yea, but my laptop is clearly slower and the 100 nearby setting along with 400 LA probably needs more hours.
I am trying to set up this script on my old machine so I can do a 24 hour run:
  https://github.com/droolsjbpm/optaplanner-simple-benchmark-daemon


Thanks. I'll pull in a moment.

The only change I will make (on top of your commit) is to move the include of math.h to the .cpp file. I did that in Sodaq_BMP085 too. I want the .h file to be just the interface and math.h is not needed for the interface.


Nice idea, and something I kept dragging my feet on.

One thing though: the multiplayer button would be better placed between the `New (singleplayer) game` and `load game` buttons in my opinion.


start progect!


I like this, actually. In Go, they work around the confusing nature of the `=` vs `==` by having first the setter, then the boolean statement that follows:

```go
if replacement = placeholders.GetReplacement(match); replacement != nil {
    return escapePath(replacement)
} else {
    return ""
}
```

Could I do something like that?


Nice indeed! It's something I wanted to do at some point but kept dragging my feet on :$


Seriously look at what you did


@csmbuild, please test


We should change "pois.elblogdehumitos.com.ar" to "upoi.org" which is the new address.


Here, and in the previous ones, you are removing CDN link for local ones but those files are not in the repository so it will fail.


I want to make another button in the future which will use the image of new game or a spade and represent start new sandbox game. This can launch you into a new park with a wizard to do random map generation and quick object selection.

The existing new game button can be start new scenario which can either keep same image or be change to have a the trophy icon from objective window.


thx


This commit is being proposed because it allows you to use some other common BDD-style file extensions with Turnip. This is always something that has been difficult to do with Cucumber, but seems very easy with Turnip.


Smell - Optional - Readability - Prefer terse ternary Boolean statements if statements are single lines with simple logic that parses quickly.

```ruby
if val
  # Single Line
else
  # Single Lin
end
```

Reads easier as:

```ruby
val ? work : other_work
```


...,int duration, bool doNotSuppress,...


I think the trophy icon would be more ideal for that I think. Also, the earth icon is perfect for this - it even looks correct :P


same here


Please use common.createTestClip() to create clip1


Needed to perform true 16 bit SPI (write) transfer.


@PFCKrutonium Its from Locomotion which is why it matches art style.


Aha! Zee bug ist found!


@umgelurgel what is the purpose of this `get_date`? I don't see reason to include it in the `BaseTransaction` class, I suspect this method can have an specific application in the class subclassing `BaseTransaction` and could be implemented directly there... We should try to only add the essential functionality to the package, as opposed to an "batteries included" approach (contrary to Django philosophy).

Anyway if I'm missing something, just tell me.


Константу бы сюда!


Как ни странно, хотя синтаксис `#@name` работает — он считается не очень хорошим тоном, т.е. лучше здесь использовать стандартное `#{@name}`


Ah, I figured you just pulled it off of an archive.org website ;)


Ca aurait été beaucoup plus simple de faire plein de petits commits pour s'y retrouver. C'est une bonne pratique et dans le présent cas, ça m'aurait permis de corriger beaucoup plus facilement.


ack, although I'd use "Split up" instead of "Update" in commit message


Хитренький! По заданию тут должно быть написано, что в списке топ-250 ещё N его фильмов (что свидетельствует о том, какой он популярный режиссёр).


ack


Il y a un commit où le nom d'Adel apparaît. Si vous avez bossé ensemble, autant ne faire qu'une seule Pull Request...


@smalyshev I have been wondering why NULL is uppercase, but true/false are lowercase in var_export().
Is this the first commit where the uppercase spelling was introduced?

(I don't really need this for myself, but want to bring this question to a worthy answer: http://stackoverflow.com/questions/34467743/why-does-php-var-export-print-null-uppercase-but-true-and-false-lowercase?noredirect=1#comment56688089_34467743)


delete it


use LIMIT 1


rename `ind` to `book`


rename `data` to `book`


use `LIMIT 1` in your SQL


Thanks for this fix, Brad.


Why all braces? O_o That style is strictly required?


Just for my benefit, why would that fail on android?


Thank you. This fixes a bug I injected.
Could you split your commit into two?
I would like to merge this one first.


This line is too long. Could you insert a newline before the comment?


Les commentaires ne se font jamais avec /* ... */ : cette méthode est là pour compatibilité ascendante, mais // est recommandé.


if `book == null` -> redirect to main page


Hmm, maybe I don't understand the new implementation, but in the old (skipping) one I've had an issue here. Basically, since `BodyAndHeaderParser` extends `ParserBase`, it will call its own `shutdownParser` and stop the parsing here - not very lenient.


The comment line is too long.
Could you write in multiple lines?


Could you write in multiple lines?


s/nothign/nothing/


Je ne comprends pas à quoi correspond le .idea rajouté dans Python. On dirait un framework pour préparer des tests unitaires, mais je ne vois pas de cas de test. Dommage car c'était une bonne idée.


temporary only? :(


Array size should probably be written as `sizeof(usec_t) * 8`, and of course, please never use timeval or timespec, only use usec_t and now(), which return easy-to-user 64bit integers instead of a those annoying structs...


Фуй! Бросая исключение, надо объяснить что произошло. Т.е. что-то типа `raise ArgumentError, "Unexpected movie year: #{movie[4]}"`


L'instruction commentée // return "mwahah"; aurait certainement pu être supprimée :-)


A quoi servent les assets qui ont été rajoutés dans ce commit ?


I've added `proselint` :)


Use u64log2() from util.h for this, and use it directly on the usec_t type...


ELEMENTSOF()


please, add a `-1` to the `ny` somehow. Otherwise, we would spawn with the lower part of our body underground since the `ny` is the position of the upper part of our body…


1. Вообще, movie.viewed как отдельный attr_setter — излишний. Ясно же, что если у фильма есть дата просмотра — то он посмотрен, а если нет, то нет :)
2. `date_movie` — не очень хорошее название поля; посмотри просто глазами «фильм.дата_фильма = ...» — эээ чочо?
3. Мне кажется, тут напрашивается один метод у фильма: «кино.посмотрено!(дата, рейтинг)»


Ca aurait été mieux de faire un README par projet.


La suppression du fichier correspondant à la classe abandonnée aurait été mieux dans ce commit.


gcc actually is smart enough to replace strlen() of a literal string by at compile-time by a constant number, we hence have removed all logic for doing "sizeof(s)-1" on literal strings from our sources, and just use strlen() directly.

That said, in this case it appears you want to use DECIMAL_STR_MAX()?


Oui on a bossé sur certaines parties ensemble. Faire un pull request on y a pas vraiment pensé.. Aussi quelques petits problèmes de github résolu au dernier moment. C'est vrai que j'aurais aussi pu faire de petits commits intermitemps. Mais en travaillant périodiquement j'ai opté pour un gros commit.
Cordialement
Gilles ESSOKI NDAME

Le 26 déc. 2015 6:58 PM, JP Gouigoux <notifications@github.com> a écrit :

Il y a un commit où le nom d'Adel apparaît. Si vous avez bossé ensemble, autant ne faire qu'une seule Pull Request...

—
Reply to this email directly or view it on GitHub<https://github.com/robertoNdams/votes/commit/ad3b0d055c7ae2f8b78098cc9127df767bd4126d#commitcomment-15164535>.


Attention à surveiller la taille des commits. Celui-ci est monstrueux (dans le mauvais sens du terme).


Yes, In one of the commits I accidentally committed it :P


За явное сравнение булевской переменной с true/false в дореволюционной гимназии учитель бил бы указкой по пальцам! Во-первых, `select{|movie| movie.viewed}` это абсолютно то же самое! Во-вторых, это уже сокращается до `select(&:viewed)`. В третьих, я бы добавил кину метод `viewed?` просто для красоты: `select(&:viewed?)`


Les traductions sont celles de Visual Studio, donc dur à voir ce qui a été effectivement commité.


Fixes #6


That's the style used in the rest of haxelib and in most part of std lib, so...


А для чего предполагался этот each (который ничего не делает?)


@bmneely

Using `Entry.count` (and `Entry.all` below, etc.) is a little weird.

- What happens if there's more than one address book?
- If that's impossible, why do we even need `@address_book`?
- Are we going to use the one-to-many `AddressBook` to `Entry` relationship in checkpoint 4?
    - It would be nice to have something like `@address_book.entries`, but even something like `Entry.find_by('address_book_id', @address_book)` would be nice. (`find_by` only returns one item, I think — I'm not sure what happens in `init_object_from_row` if more than 1 row is returned.)
    - Checkpoint 3 seems like a more logical place for this than Checkpoint 4


I meant removed slash from README.md.


I don't see the point to await the task here. Tasks created by Task.Run are "hot" so they start immediately.
Also if we await we should then add ConfigureAwait(false).


just curious: why isn't this `util.Errorf`?


Ifndef is not required and actually suggests it can be set somewhere else.
I also suggest to create a define for the blocksize. This because buffersize=blocksize * 1024.


PRODUCT_COPY_FILES is ignored for recovery target


Même si c'est public, il n'est partagé qu'aux inscrits et pas sûr que grand monde le lise.

L'idée c'était que les gens sachent pourquoi ils viennent aider, que c'est important de venir aider, et montrer qu'on ne demande pas aux gens de venir, qu'ils fassent gagner beaucoup d'argent au cercle mais qu'ils le verront pas disparaitre comme les années précédentes sans que rien ne change. C'est de l'histoire du CI plus que des indiscrétions comptables.


An App can chmtime in its own dirs (`/data/appname/`, `/storage/emulated/0/Android/data/appname/`), so this should work.


Hang on, I'm raging like crazy becoz I lost all my previous trees ... XD
I'll fix this


Added for a custom subdomain


Nope :P
PRODUCT_COPY_FILES target isn't triggered during recoveryimage target ( afaik )
Put it in recovery/root and it will be copied directly


Saberize patching seems to not work on marshmallow.  How many times have you tried now like 20?


Можно не считать символы самостоятельно, а доверить это компилятору: `char str[] = { 'a', 'b', 'c' };`.


Hi
i would like to know why are you removing, sitemap functionality?
Regards


Смотри, вся идея выделения функциональности в модуль, в данном случае — в том, чтобы ВСЁ про рейтинги (выставить рейтинг, сохранить рейтинг в кине, взять рейтингованные фильмы и т.д.), не только один метод — который не имеет смысла без остальных (и остальные без него тоже оказываются беспомощны).


Чисто терминологическое: `@parent` — это родитель в цепочке наследования (Movie is a parent of ClassicMovie). То что у тебя здесь, лучше назвать `@owner` (владелец) — или по смыслу, просто `@list`.


This https://github.com/AOSParadox/android_device_motorola_falcon/blob/falcon-par-6.0/device_falcon.mk#L40 works on recoveryimage task


Если здесь дополнительная ячейка предназначена для завершающего `'\0'`, то она не заполняется далее. А должна бы --- иначе получается строка "без конца".


ok


Should line 566 be changed from
			<dataarea name="rom" size="16384">
to
			<dataarea name="rom" size="524288">
?


Требуется не текст от найденного фрагмента и далее, а позиция фрагмента в тексте (`k`).


Форматирование безобразное, поправьт перед тем, как защищать работу (в Code::Blocks: *правая кнопка мыши / Format (use AStyle)*).


@qdao ，收到。


При использовании систем контроля версий нет нужды хранить старый код в комментариях на случай, если вдруг он понадобится. Совершайте commit, удаляйте старый вариант --- и всегда сможете его восстановить.


Утечка памяти: не удаляется `YNY`.


I'm using SystemJS as a module loader (using commonjs config) and as a bundler I naturally use SystemJS Builer. Haven't tested yet does the problem occur on bundled setup but during dynamic loading I have to polyfill process object to window by hand as SystemJS doesn't do it naturally.

Indeed I have no such problems when using aforementioned loaders due to their internal polyfills.


Не реализована сортировка предложений.


tokensbll must get authorization information in constructor, so details of endpoint can be retrieved only for current session user.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10325](https://teamcity.mesosphere.io/viewLog.html?buildId=98036&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 206 Build time: 00:09:01


Sorry, I mean System.register format.


По заданию требовались беззнаковые 16-битные целые числа.


Hi Michel,

Sure! How do you do this? I haven't committed in years and probably
the first time on git.

Thanks,
George

Quoting Michael L Heuer <notifications@github.com>:

> @gwaldon changes to biojava-legacy should all come in on pull
> requests so that they can get proper review
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/biojava/biojava-legacy/commit/e8b04248079398c20f6c9c492846f9f98bb2203d#commitcomment-15150809

--------------------------------
George Waldon
Gene Infinity LLC


See:

- https://github.com/dotnet/roslyn/pull/7684#discussion_r48374655
- https://github.com/dotnet/coreclr/issues/2467

Wanted to get this submitted first so that I had a simple repro to give the CoreCLR team when filing the bug.  Circling back later today to get the issue linked into the file.


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10326](https://teamcity.mesosphere.io/viewLog.html?buildId=98037&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:04:35


Arduino library for LCD 1602 Rus chars (you need LiquidCrystal_I2C library installed)


How are you guys liking Drone?


The easiest compatibility with System.register modules would be to simply check if process is defined as a global before checking for process.env.NODE_ENV value.

This is the only file currently in redux using the process-object so it wouldn't require a great deal of refactoring either.

Think this is doable or does it go against the bigger picture?


Hi Michel,

Yes, final map. The problem is that Edit class is final and still the
only way to communicate between a sequence editor and the sequence. In
my case the properties are String,Boolean but how can you guaranty
that no one will ever need something else? Otherwise we can make the
class not final. That would be fine with me.

Cheers,
George

Quoting Michael L Heuer <notifications@github.com>:

> ```HashMap``` should be ```Map```, the field should be ```final```
> and wrapped for immutability, and I'm not sure the value type should
> be ```Object```.  Maybe you could add some unit tests demonstrating
> the use case(s)?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/biojava/biojava-legacy/commit/e8b04248079398c20f6c9c492846f9f98bb2203d#commitcomment-15150843

--------------------------------
George Waldon
Gene Infinity LLC


I tried to make `fill` method to stick to the behaviour of both [ndarray-fill](https://github.com/scijs/ndarray-fill) and [typedarray-fill](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/fill).
This separation trages off elegancy for some performance/theoretical purity benefit, which is questionable for the user. E. g. changing `util.fill(buffer, 1)` to `util.fill(buffer, function (value) {return value})` now takes two editions instead of one, and two terms to keep in memory (transform and fill).
Is that really reasonable?


Thanks @ADDCreative - New commit based on feedback https://github.com/opencart/opencart/commit/33642ba18dc2645396dd35a0434964d7721d5eb3


Somewhere I saw the code-style rules for contributors. It said something like this: "it is necessary that all the code in one file was in the same style".


So most chtime errors we just throw away, and I feel we should do the same here too, regardless if it will break android or not.


Works Great!

Thanks!


I wasn't sure what to do as there was a warning about Task is not awaited. We should mark it with `pragma disable` I think.


I've already done that


Yep definitely the way to go!


@lpantano I added this as a workaround for now, if there are no compatible features skip running it. I had to guess at what was compatible for now.


Ahhh, forgot something. On Windows it must be async because of `await initTask.ConfigureAwait(false);`. What do you think should I await Task.Run or add pragma disable without it there?


XAX


On Windows we can still keep the `async void` but I think it's pointless to await the Task.Run: it will generate a state machine that we won't use.


no error found :+1:


Now can't find. Okay. But _я протестую просто потому, что мне так больше нравится_. Maybe need write a style-guides for contributors.


Whoops! Sorry.


Ok. I'll make a commit now. :)


so is it right?


:-1:

I hate to drum up a 6 month old commit, but the removal of routing filters (and more specifically after filters) has left my application dead in the water since it relied on after filters for processing the controller and building the template up. At first, I thought I could just switch it over to use an after middleware, but as it turns out, I have a situation that after middleware simply doesn't cover. Here's how the application worked in 5.1:

1. The base controller runs and sets up the controller with a bunch of data (the view location and its data for example).
2. The route resource (another controller) runs and updates that data. (I __do not__ return a view object from the controller method, I just set the data.)
3. The base controller fires an after method that collects all the data from the controller and builds up the template with those pieces. (I just called `$this->afterFilter('@processController')` at the end of the constructor and that method took care of everything.)
4. The after filter set the response content to the fully rendered template before the response was sent to the browser.

Simple enough.

In 5.2, with the removal of the after filters, I figured I could just write an after middleware that would do the same thing. Unfortunately, that's where I ran into the issue I'm having.

1. The base controller runs and sets up the controller with a bunch of data.
2. The route resource runs and updates the data.
3. The base controller serializes the controller data (since middleware parameters can't be objects) and passes it to the after middleware.
4. The template renders without any of the information from the route resource because the data is stale... it's never gotten the updated view location or view data that's set in the route resource method.

I've gone through a tried a bunch of things, but the results are the same.

- Middleware can't be called from a controller method (nothing happens, just a blank white screen and no errors).
- Terminable middleware runs after the response is sent to the browser.
- Calling middleware from a destructor doesn't work.
- Serializing data by reference doesn't work (PHP doesn't allow it).

What I need is a way to pass controller data to _something_ that will run after the route resource has finished running but __before__ the response is sent to the browser. I went back and forth with @taylorotwell through the Laravel Twitter account the other day and he thought he might have an idea, but nothing has come of it so far. I'm trying to figure out what to do about this so we can keep building the application or go back to the drawing board.

Any guidance would be greatly appreciated.


@mrbernnz this is why it's better to use
````bash
$ git mv README README.mv
````
All history is preserved in the rename.


is there a reason for not using File.expand_path(File.dirname(File.dirname(__FILE__)))


Herp


Oui, cela a été corrigé, il m'a fait mergé avant de pouvoir commit, et du coup je n'avais pas vu les symboles de merges.


Merci :)


We can use a manual  :     var s : String = v; (v being Dynamic) this will trigger the native flash toString as it does currently


Most of these changes are from my commits. Give me some authorship man.


Not at all ok: this will fail as long as the target language has proper variable scoping (ie not ECMA): Neko, C, C++, Java etc.


Which is why it's only done on JS and As3.


Please rebase rather than use these sorts of merge commits.


Can you in the future, please rebase instead of use merges.


where I can find 64core ?


Like many other IntelliJ features, this can also be configured.


yes, search `adjgroup` on the forum
I use this `atcommand "@adjgroup x;"` trick a lot


That's why I disabled it


I always leave this out so not to duplicate it as it's already in the readme further up.


It looks like this might have some unintended consequences. In my case _modal is undefined so calling remove yields an error.


Молодец -- очень удобно


So you have SaberMod code under uber copyright?


Pretty much the same thing uber does.


Updated package location - Fuse has moved to Github


done.


no reason. Changed.


Здесь, и везде ниже, у тебя проблемы с кодировкой -- используй нормальный язык(eng) или utf8


On the contrary, it seems it will not reach 3-4 ELO gain. I hope that we'll find a better solution for LTC ELO gain. This double testing seems worse than 100+1 time controls.


makeCacheMatrix <- function( m = matrix() ) {

  i <- NULL

set <- function( matrix ) {

  m <<- matrix
  i <<- NULL

}

get <- function() {

  m

}

setInverse <- function(inverse) {

  i <<- inverse

}

getInverse <- function() {

  i

}

list(set = set, get = get, setInverse = setInverse, getInverse = getInverse)
}

cacheSolve <- function(x, ...) {

  m <- x$getInverse()

  if( !is.null(m)) {
    message("getting cached data")
    return(m)
  }

  data <- x$get()

  m <- solve(data) %*% data

  x$setInverse(m)

  m
}


makeCacheMatrix <- function( m = matrix() ) {

i <- NULL

set <- function( matrix ) {

m <<- matrix
i <<- NULL

}

get <- function() {

m

}

setInverse <- function(inverse) {

i <<- inverse

}

getInverse <- function() {

i

}

list(set = set, get = get, setInverse = setInverse, getInverse = getInverse)
}

cacheSolve <- function(x, ...) {

m <- x$getInverse()

if( !is.null(m)) {
message("getting cached data")
return(m)
}

data <- x$get()

m <- solve(data) %*% data

x$setInverse(m)

m
}


When "Error loading message" shown, pressing delete key delete current message.


Looks like you misspelled "canola"! Let me know when you've updated the change.


Это выглядит весьма убого, погугли конструктор или создай функцию createString
Это должно выглядеть как то так
+ curentString = createString(size, capacity);


Wow, way not to commit the only important thing.


Лучше создать enum, -1 - не ок


Have you tried the magazine covers, I don't know if it will work on a mac.

On 26/12/15 20:13, Maxcore wrote:
>
> +1:)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/philborman/LazyLibrarian/commit/f3266727ca9035bd08d22eb0cb7a2da27a3a5833#commitcomment-15164750>.
>


dknight, C1008, size = 65536
dinopark, C1061, size = 524288
goldpyra, C1068, size = 524288


Not really. I generally go with the shortest first thing that comes to mind when having to use that pattern. Today I probably would have written it as:

`File.expand_path("#{File.dirname(__FILE__)}/..")`


Hi I like you script, will it be upgraded to allow downloading and renaming of the actual video files? I use plex and want to be able to keep track of which videos I have viewed. I'd also like to run this in a cron job to auto-grab new content as it is made available without me having to manually run the job.

Thanks for what you have put together.


Действительно ли тебе нужен cstring?
Я полагаю, что этот заголовочный файл уже включен в  string.h(по крайней мере должен быть)


Filters have been deprecated since 5.0. Fee free to ask on the forums. We never deal with issues of any kind through commenting on commits.


глобальная переменная -- плохой тон


hey... are you guys keeping the project up?

boxa, one question, is there any possibility to bring r2 as close as possible with code, with cmangos? or you have done that allready?


смотри замечание из main


вот поэтому глобальные переменные не ок


Fixes the following error observed on a Raspberry Pi:
```
  File "gps.py", line 59
    firstFixDate = gpsData['fix_date'] + "-" gpsData['fix_time']
                                                   ^
```


Hey, I added most of this into master branch as of https://github.com/google/skflow/commit/fef58ae728837dbf8c33751c74c3b44b64defa3d  let me know if anything is missing that you would like to have! And feel free to send PR next time :) And feel free to send PR next time :)


For what it's worth, Debian's `libpcap0.8.symbols` file doesn't list `pcap_read()`, so they apparently don't consider it something exported by libpcap.


@Yomguithereal is this actually a scenario in which mutability plays a role? i.e. would this code work any differently if the monkey were mutable?


используй ifstream


пробелы


Не null, а nullptr


Магическая константа -- это плохо


еще одна магическая константа


Geel can you plz help me with this sorry if I am in the wrong chat Can you help me I had the authenticator for more than a week but i still had to wait 7 days so i decided to remove the authenticator and now i got the version 1.00 every time i try it i put in the code it sent to my email it keeps saying general failure for about 20 times in a row and I cant do any trading cuz ppl dont want to wait 7 days and the bots get clogged up so anyone have answers ?


Отделяй вывод от логики


nullptr


На будущее -- лучше использовать касты в стиле с++


Здесь происходит лишнее копирование
передавай массивы по указателю


If I understand correctly, you have moved the breaker between the feedback loop and the external consumer. My intuition is that the feedback look will remain live even after the breaker is tripped. In other words, given the following graph:
```
                        sink 1
                     /
source --> broadcast
                     \
                       breaker ->  sink 2
```
I'd expect that tripping `breaker` will only stop `sink 2` but data will keep flowing between `source` and `sink 1`.
If I am wrong, I'd love to see a test that demonstrates it :)


куча-куча-куча лишнего копирования
За такое ставят незачет(


Sorry, meant "... + maintainTeam 'No round..."


correction, libmpq => dbcfile


опять же
лучше создать функцию конструктор


А зачем нам тут определять `question`? Должно работать просто `create(:answer)`.

И лучше сделать `let(:target){ ... }`, а не создавать переменные в `before { ... }`. Почитай [betterspecs](http://betterspecs.org/ru/).

Еще проблема: `if model.to_s == "Answer"`. Таким образом мы зашиваем в shared_example _зависимость_, он уже не универсален.
Shared example должен работать как консерн - подключил и все готово. Он не должен знать наперед, куда его могут подключать.


cool


This doesn't work yet, but it will soon when Travis updates the precompiled binaries. I think we can leave it for now.


какая-то неявная логика
используешь значение типа int, как bool( происходит неявное приведение к типу book, так можно писать, но не стоит)
наверное лучше явно написать, что i >= 1


перепиши весь код, где используется копирование массивов, полюби указатели и ссылки


I m sorry I will fixed it


Задача НЕ зачтена


отступы


closes #107


добавь везде const


Сделай  enum для состояний
а то как то все непонятно, для постороннего человека


asdfasdf


разумно инициировать не нулем


разумно инициировать строку каким-нибудь значением поменьше
10, 20


Didn't realise it was a common API, I'll revert this.


Tested on several sites, the problem remained. I tried with and without the NPC on the production site and at the new, clean.

If you install a clean database, create the tags 4-5, and put in the admin setting: Tag on the page in a cloud of tags 1

When the friendly padzhinatsiya: just switch the tags, but the pagination does not change the numbers, remains in first.

When you turn off the friendly padzhinatsiya: does not work, but with a small number of tags still appears endless pagination, 1..5..100 ... 5000 ...


Thank you, good catch, that is now fixed.


Changes in .classpath allow to export the project to runnable jar from Eclipse


But why would a normal

```mv README README.md```

Save as well. @snuggs?


Should we write this to some other place, rather than in the package directory?


I was thinking that we could change this to `return pageLabels` if we initialize `pageLabels` to `null` at https://github.com/Snuffleupagus/pdf.js/commit/e5d107ef97933ec0dd43ed800fc353fce3b3e8e6#diff-3fd0fc66c9db990d996e595419b3f1e1R272. We can then make it an array in the if-statement at https://github.com/Snuffleupagus/pdf.js/commit/e5d107ef97933ec0dd43ed800fc353fce3b3e8e6#diff-3fd0fc66c9db990d996e595419b3f1e1R275, which would also save an array allocation for PDFs that do not have page labels, which will likely be most of the existing PDFs. What do you think?


No worries. It still computed the right answer, just really slowly. My fault for not having tests or anything. ><


This logic looks wrong to me. It looks like you're reordering the input. Shouldn't you simply call `lookahead_front()` to get the next token in the input queue and break out of the loop if it isn't below __R_MIN__? Not to mention that you're treating the token as an arg to be re-evaluated as well as an arg for the function if it is in the magic range __R_MIN__ to __R_MAX__. That can't possibly be correct.


The id is 2.


I can't understand this line "delegate.canRemove == true ? true * false"
Perhaps you wanted to write "return delegate.canRemove" ? .


sdhsjkjd


请勿下载，此版本经测试，有问题


I would not recommend leaving an actual, valid CMS API Token in your public repo. I would think it defeats the purpose of your code calling another js file containing it ;)


ppp


This commit breaks the build under Windows because gettimeofday() is not defined. Is there a wx function we can use for portability?


This is a smell.  It obfuscates a setter.


Yess


Okay


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10317](https://teamcity.mesosphere.io/viewLog.html?buildId=98018&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:09:31


Dan..
I think

::wxGetLocalTimeMillis
wxLongLong wxGetLocalTimeMillis()
Returns the number of milliseconds since local time 00:00:00 Jan 1st 1970.

should work.

I'll fix it.
Thanks
Dave


Excellent, well that gives me something to do on my holiday break :) I will start taking a look firstly at the other repos already with a readme first.


frist,we can bulid string


Well, that makes sense, thanks. :-)


>Note: The changes are stored in the local project specific .pro.user file. Therefore, they are not suitable for sharing between developers or development PCs. To share settings, incorporate them into the build system. For example, if you use qmake, make the changes in the .pro file.

- the note said .pro.user is not suitable for sharing
- other place set parameter is command line argument for qmake.

> We can discuss a better approach in other moment.

Ok. for now. using win{ } or !macx{ } conditional guard - or -
apply this flow, enable/disable VstPlugin only when needed, not add to commit the temporary change.
any ways keep the .pro file history clean.


nice!


return_value needs to be imported


NuGet update -self won't work either. The 2.8 series won't update to 3.x. You really need something like either an appveyor download command:
https://github.com/onovotny/Zeroconf/blob/master/appveyor.yml

Or a build script that downloads it:
https://github.com/xunit/devices.xunit/blob/master/xunit.devices.proj#L102-L136


TeamCity LabKey :: Trunk :: Premium :: Git sqlserver 2014 [Build 132](https://teamcity.labkey.org/viewLog.html?buildId=293505&buildTypeId=LabkeyTrunk_GitSqlserver2014) outcome was **SUCCESS**
Summary: Running Build time: 00:02:24


大师


I think we should place this in the `Util` module (much like the annotation type constants) to avoid recreating this array each time a label is processed. Placing it in a utility module also seems like a better place for this kind of static data to me.


Can't we just do this once at the end of the loop so we can avoid doing this in each switch case?


What's the API change you are referring to, @TylorS ?


Леся, я внесла все исправления и запушила их. Пока без pop-up, запушу заново, когда он будет готов :)


Tutorial 2 *** commit 3


`pet_packages-firmware` would be clearer I guess.


I don't know if it's hard, but I tried a bunch of different files and import_all seemed to work just fine, so I didn't want to bother. If it becomes a problem we can iterate.


`0x41` seems a bit magical here. Could you replace this with either a constant or a character (as I assume it is meant to indicate ASCII character `A`)?


I'd say that cast to String could work differently on AS3. On Java/C# for
example casting to string actually calls a static function that returns
`value + ""` if the value is not null

On Fri, Dec 25, 2015, 10:16 AM Simon Krajewski <notifications@github.com>
wrote:

> haxe.format.JsonPrinter has this thing for flash/as3:
>
>     @:extern inline function add(v:String) {
>         // argument is not always a string but will be automatically casted
>         buf.writeUTFBytes(v);
>     }
>
> The problem with inserting a cast here is that As3 generates it as this.buf.writeUTFBytes(((v)
> as String)) and that causes the argument to be null.
>
> This is technically a regression, but honestly it's quite silly to rely on
> this weird automatic casting in the first place. I'm not sure what to do
> with that.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/HaxeFoundation/haxe/commit/781442433e3bc8cac6d25d914109621db5918454#commitcomment-15160441>
> .
>


Till this commit, previous version is working perfectly fine!


I realized that the mutability comes into play only **after** you declare the monkey and are accessing it elsewhere, and need to change it. So this is a perfectly fine example.


Yeah, I didn't want to bother for the first pass. I can have a look later. Or not. :)


Seriously? Where is your vagrant file or your travis file or....


Great


I would create Packages-puppy-common-i686 and Packages-puppy-common-x86_64 ?

Where I would upload static binaries and cli apps compiled in a very old puppy like puppy or wary


This should probably be changed also to `djangocms_grid.south_migrations`.


Php Documentor


WinControl::removeItem is a typo. Should be WinListBox::removeItem.


I think it's better to keep it a separate file. I think in the future we can evolve the Sublime Text version to a more sophisticated protocol, where we can actually prompt the user to choose.


See above.


Ah, I'll clean it up.


See comment above. I think it might be useful to keep it separate so we can evolve it differently.

We could nuke `CommandLineEditor`, but it seems like a nice reference implementation to me.


Unfortunately `subprocess.Popen` doesn't get the right $PATH environment variable. It does depend on using rbenv, that's true, that does make it fragile. Open to suggestions!


Oh man! You're fast.


Overriding ```isApplicable(Descriptor)``` in this DescriptorImpl will allow you to filter SCMs.


**This file contains unused source code.**
*PyUnusedCodeBear, severity 1, section `pythoncheck`.* *Related to file `coalib/tests/bearlib/abstractions/CorrectionBasedBearTest.py`, line 1.*

The issue can be fixed by applying the following patch:

```diff
--- a/coalib/tests/bearlib/abstractions/CorrectionBasedBearTest.py
+++ b/coalib/tests/bearlib/abstractions/CorrectionBasedBearTest.py
@@ -1,4 +1,3 @@
-import subprocess
 import sys
 import unittest
 from queue import Queue
```


#2  #3  #4  #5  added all pages


Students/30425/Farcas S. Silviu Vlad/snake/snake/src/models/Snake.java

Much, much better, but take a look here.

These 4 if statements contain so much duplicate code! Do you think you can.. shrink'em somehow?


commented out "cout"s could have been dropped


I still don't think the `Snake` should have an attribute `cherry`. The cherry is not part of the snake, it should "live" somewhere else. Maybe in the `GameManagement` class?


Comment on commit


Great improvement!


was there before, it helps debugging. I hate LogDebug: it is useless (requires recompilation anyhow) and unfriendly to switch on...


Should revert this, msm8916 supports latest camera2 api


That's what I thought, thanks. I'm working on another patch to annotate other temporary allocas.


Tidy data text file


Smell - Semantics - Invalid Hash Initialization - Use `{}` instead of `Hash` to initialize a hash.


this one wasn't here before


Test Smell - Invalid Assertion - Do not assert a Hash value as true, it will always be true unless it raises.


Smell - Wrap Arguments in `()` when used in a setter.


* "thus" と "process" を訳文に組み込んで「つまりそれは一種のソフトウェア開発プロセスです」とするのはどうでしょう。
* "so" の意味を入れて「とても多くのことが」とか。
* "go wrong" は「狂う」で良いかと。
* "moving parts" というのは「動く部品」だと思います。部品だとかたければ「パーツ」とか。


was added intentionally. it is one of the few ways to monitor onDemand unpacking...


after this some item can't be crafted (like sticks) but the crafting bug is fixed with this (i think)


I don't know that much about SystemJS but I'd say that if it lets you use CommonJS builds with `module.exports` (Node idiom) it should also allow you to specify `process.env.NODE_ENV` (another Node idiom). Otherwise you can just use the UMD build (`redux/dist/redux.min.js`) which is precompiled and doesn't contain any Node idioms.


protip: use the same email adress and name on your desktop app if you want your commits to be added to your account


Yes, the entire problem is that it raises. It should not raise.

Is there a better way to check for this?


Thank you for the great work!
Word forms for words in the end of a sentence with period or other symbols do not work. (Even the mobi is complied with the command "-w wordforms", if i remember correctly).


This seems buggy on my side. I may not be using `cmake`, but it seems typing `cmake -DHAVE_EXYNOS_API=1 ..` always outputs `Exynos support: no`. You might want to test it as well on your side, to see if you have the same result. I got this result on Archlinux using cmake 3.4.1.


im trying to add some of the idler parts to a lg volt kernel. would i have to add the powersuspend.c & .h to my kernel if they are not present?


Thank you


thanks for comments, I'll be back soon with improvements


The patch looks ok to me. I have not tested it though.


Hi Alex,
first of all: Merry Christmas!
now second of all, I do have some problems,
I keep getting the index out of bounds exception when running the method paintTetromino() in the
GamePanel class. I don't see how I am getting out of the bounds there and I have tried many things to fix it.


There is no better way because Minitest is pretty opinionated on the matter of `refute_raise` and they are right in most cases but the problem here is that you don't double tap other tests and ensure that the hash has values that you expect.


*binary* isn't necessarily arch dependent. You could argue that Java apps are shipped in binary form and should go to noarch. I think `noarch` is an appropriate place for firmware.

>I would create Packages-puppy-common-i686 and Packages-puppy-common-x86_64 ?

I suppose its not a bad idea but things with libraries could run into troubles with different distros - (re 64 and possibly 32 as well if at some point in the future we discard the symlink to /lib, /usr/lib for debian/rhel based distros)


Was this new API reviewed? It should be internal and `_underscored` if not.


* "inherent" は「固有の」とかどうでしょう。
* "both" が抜けているので「もしくはその両方に話題がそれます」とか。


just included: https://github.com/minetest/minetest_game/pull/464/files


Fair enough, yes. For this, you can have a single table for that, even though, usually, you will want them separated.


the are got lost.


I'm okay with any code style as long as it's consistent within at least a single project. Having different modules with different code styles in a single project is not consistent at all.


yes very good ;)


gharar shod baraye controller ha az arrow function ha estefade nakonim chon controller ha new object mikonan error mide!!!


inja ham hamintor


A standalone patch file for this commit.
[dhc6-patten.patch.zip](https://github.com/bolan/dhc6/files/72520/dhc6-patten.patch.zip)


:+1: I can do another round of profiling for you once I have more time


ma motaghayeri be name chats nadarim !!!
(ehtemalan mikhasti news benvisi eshtebahi chats neveshti)


Runtime O(n), Space O(n)


inja hamintor


Added javadoc and pushed.

I recommend to comment not on commits, but on the pull request. Comments on commits remain in the **Conversation** tab, even after a corrective commit was pushed.


Use spaces for indentation, please.


@drewolson @jeregrine @ericmj @michalmuskala @MSch @alco this commit changes Ecto so only non-fields are sent to the database on insert. This will make `:read_after_writes` work out of the box, send less data on inserts and be more consistent across adapters.

The downside is that if you insert and read right away, you may not get the same record, but that can happen anyway with triggers and other database operations.


Вызов отладочной информации специально оставлен?


Using the single dispose function returned by run()

```js
{sinks, sources, dispose} = run(main, drivers)
```


book != null always!


I haven't really tested the List part properly yet, I'd like to re-write it as of 0.3.


I didn't update the inline documentation there.


I should be able to investigate the profiling trace as well, I just didn’t know `METEOR_PROFILE` before :-)


* 脚注は Markdown では以下のように記述します。

```
用意しておくべきです[^注1]。

[^注1]: StanはSubversion...
```

* 「労力の」というのが原文にないように見えます。
* "but it's well worth" の前までで文を切るのはよいと思いますが，それ以降は文を区切らずに一文にした方がよいと思います。
* 細かいですが，「差」は「差分」にしていただきたいです。専門用語的な感じなので。
* "even on a paper" は文字どおり「紙の上であっても」で良いと思います。バージョン管理ソフトを導入しているコンピュータとの対比じゃないでしょうか。


Hi Vic,

I am looking at porting this to the new OpenNetworkLinux repository and I noticed that you re-used the AS5712 definitions in x86-64-wnc-sst1-n1-r0/src/boot/x86-64-wnc-sst1-n1-r0-devices.sh .. I assume this is incorrect, do you have an updated one?


3 months of correct working


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.433.0](http://build01:8888/viewLog.html?buildId=13691&buildTypeId=ConfigInjector_CI) is now running


Yeah I thought about submitting a patch to async-ssl in opam-repository for darwin > 10.11 but there's no way to express that constraint unfortunately.


TeamCity Open-source Libraries :: ConfigInjector :: CI [Build 2.0.433.0](http://build01:8888/viewLog.html?buildId=13691&buildTypeId=ConfigInjector_CI) outcome was **SUCCESS**
Summary: Tests passed: 38 Build time: 00:00:33


Es un afijo que agrego en un commit anterior.


Using the minified build during development might give a little hindrance during debugging though.

SystemJS doesn't care about bundling in unbundled operating mode. It downloads the file directly to the browser.

It also does not strip the process-object itself. Apparently only the builder does the stripping in minified mode. So the solution to using that without manual polyfilling would be to go through additional configurations to setup the bundler for the test-server.

I'll just toss the ball to the SystemJS contributors since it will influence more CommonJS-packages and this probably won't cause a lot of issues with your average react-redux developer who prefers other loaders anyway.  ¯\_(ツ)_/¯


* 原文に忠実になるなら学習曲線が急なことについては「SVN より学習曲線が急なこと」ではなくて「より急な学習曲線」かなぁ。


cool, i didn't know you could check them off like that.


У меня фабрика answer требует question_id. Поэтому сделал это условие. Но замечание я понял.


TL;DR : I changed it and pushed.

They are identical in a `for` statement, they should not be confusing.

I'm not aware of a recommended writing style. So that makes this a matter of taste. When it comes to a matter of taste, I like to give the author of the branch the right to do as he wishes, not the reviewer.

I prefer `++i` instead of `i++` for historical reasons. In C++, you can implement prefix and postfix `++` operator for objects. It's a common exercise to a implement a `Counter` class and override the prefix and postfix operators. When doing so, the prefix version is simple: increment the counter and `return this`. But the postfix version is messy. In order to return the previous version of the `Counter` instance before the increment, you must make a copy. Of course, there are no such issues surrounding the postfix `++` operator of an `int` in Java. But by principle, I dislike the postfix `++` operator because of its behavior with side effect.

That said... In my code review experience, I almost never see anybody using `++i` in a `for` statement instead of `i++`. It's better to write code in a way that's familiar for the majority. So I think I should adopt `i++` for the future. I made the change and pushed it.


That's waste of CPU cycles, you could use cs.c_str_len() instead


Neveremind. It was just a typo :/


Wow. Just wow. After 20 min of game even this gives an error...

```
2015-12-26 21:54:18.844638 [error] AI :   File "C:\Users\FabianAdmin\Github\freeorion\default\AI\AIstate.py", line 667, in rate_fleet
2015-12-26 21:54:18.849639 [error] AI :     for partname in design.parts:
2015-12-26 21:54:18.849639 [error] AI : AttributeError: 'NoneType' object has no attribute 'parts'
```
Moderator games are seriously f****ed up...

Well, try-catch it is then...


This was a bug in Github and Gui Desktop I think... The mod is fine, At least...


Could you comment this constraint, please?


Why? exit() is defined in stdlib.h


any idea how we might be able to test this without having to wait 2s?


* CmdStan とかそのへんに言及するのは翻訳の域を超えているような。訳注にするとか。


вообще, для этих целей существуют стандартные функции


* and じゃなくて are ですよ。


лишняя копия


* "e.g." を訳出して「例えば」


Ok. Voy a retirar el pull request y lo voy a hacer nuevamente.


{{ baseurl }} is not necessary here.


No worries, I will extend it to take start/end arguments


... Nevermind, duplicate declaration made it go haywire. Sorry for the hassle... Works fine with SystemJS properly configured.


I'm also not sure this is better than doing an assignment. If there was a performance reason for this function, @atrick's recent copy forwarding improvements may have eliminated it.


Ok. Lo que estoy intentando poner es el sufijo que permita el voseo (jugás, podés, olés). Lo voy a revisar y hacer un nuevo pull request.


Caused bug in src/menu/ComponentContainer.java:44 and other wrong renames, fixed in 9339906c823e39bed0b9e6576c8d5f4229b3ed5c


For reference if someone stumbles I opened an issue for it: https://github.com/systemjs/systemjs/issues/991


TeamCity OSS :: Kubernetes Mesos :: 4 - Smoke Tests [Build 10327](https://teamcity.mesosphere.io/viewLog.html?buildId=98038&buildTypeId=Oss_KubernetesMesos_5SmokeTestsDockerMesos&guest=1) outcome was **SUCCESS**
Summary: Tests passed: 1, ignored: 211 Build time: 00:08:53


* "rubber duck" は「ラバーダック」で良いかと。


Since we're moving to ES6, maybe we should be using `Object.assign`?


Je ne comprend pas trop l'utilité d'un splice avec seulement deux paramètres ?


Syntax, sans e, en anglais (commentaire de commit).


We have to find the way to avoid globals


Un petit commentaire pour expliquer l'intérêt de la ligne passant le contenu de la collection à vide n'aurait pas été de refus.


Très bonne idée d'avoir ressorti les noms dans un fichier.


There was some reason to generate casts like that, but I don't remember it.


Attention à bien gérer la libération du lock lors des exceptions, mais sinon c'est pas trop mal.


اینکه این موقع شب رفتی خونه و هنوز وقت میزاری جای تقدیر داره


اینجا هم همینطور 😊


Probably need more accurate 'type identifiers' instead of just zzzzz


Pas mal du tout pour l'implémentation de OAuth. Je vais déboguer tout ça, et si ça se tient, je l'incluerai dans le fork original. A première vue, ça m'a l'air bien, mais seuls les tests nous diront si ça fonctionne bien. En attendant, vu le nombre de lignes et l'effort, je mets le max de points. Bravo !


You like,  @misternu ?


J'aurais quand même préféré un README.md dédié pour chacun des sous-projets.


"no longer appears to be the case" means MediaElement only works from which iOS version up?


Ca aurait été bien de garder la même syntaxe pour les autres appels que pour l'appel sur "all".


Hallelujah! I was always moving by hand (and was puzzled on the reason of that).


Any idea how this affects execution speed?


Pourquoi tes commentaires de commit commencent-ils par un tiret ?


Aren't we also shipping unminified build in the disy folder? You can use that in development.


Might want to look at Phinx for handling migrations! It's super easy and you don't need to write separate up/down migrations which saves a tooon of time.


explicit sans "e" en anglais.


@qrntz I think the ssh-keygen statements should remain together because the presence of the IP in known_hosts is independent of the lease.  Example sequence, a container is created and started resulting in a dhcp lease.  A login from the lxc host via ssh occurs due to an ansible play, adding the container name and ip to lxc's known hosts file.  The container is shutdown and remains stopped until the lease expires. When the container is destroyed, both $name and $ip remain in the known hosts file.

If you think it is advisable, we could add a test to see if the $name is present in known_hosts before attempting to remove the $name and $ip.


Bon commentaire de commit, très complet. Vue la différence des actions, ça aurait toutefois valu le coup de créer différents commits. Voir les conventions de type FEAT, FIX, CHORE pour savoir comment séparer.


Voilà ! Ca, c'est du README :-)


@biscan607 去掉container是为了让页面宽度更大吗？


Haven't done this yet, seems easy to read tho
On Sat, Dec 26, 2015 at 3:34 PM Brian Wagner <notifications@github.com>
wrote:

> You like, @misternu <https://github.com/misternu> ?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/hazelmaeby/sinatra_todo/commit/7333d840ffcc662cb91cfbceb5ded71741aec8aa#commitcomment-15165109>
> .
>


Awesome! :D


Wherever you end up putting this, can you add a comment explaining this information?


## HelloWorld.MD


if(marqueur[0] == null){
+ marqueur[0] = m;
+ }else if (marqueur[1] == null){
+ marqueur[1] = m;
+ }else{
+ marqueur[2] = m;
+ }

==> for